url
stringlengths 50
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 64
67
| comments_url
stringlengths 59
62
| events_url
stringlengths 57
60
| html_url
stringlengths 38
43
| id
int64 597k
2.65B
| node_id
stringlengths 18
32
| number
int64 1
6.83k
| title
stringlengths 1
296
| user
dict | labels
listlengths 0
5
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
4
| milestone
dict | comments
int64 0
211
| created_at
stringlengths 20
20
| updated_at
stringlengths 20
20
| closed_at
stringlengths 20
20
⌀ | author_association
stringclasses 3
values | active_lock_reason
stringclasses 4
values | body
stringlengths 0
65.6k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 59
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | draft
bool 2
classes | pull_request
dict | is_pull_request
bool 2
classes | issue_comments
listlengths 0
30
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/psf/requests/issues/2831
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2831/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2831/comments
|
https://api.github.com/repos/psf/requests/issues/2831/events
|
https://github.com/psf/requests/pull/2831
| 111,813,558 |
MDExOlB1bGxSZXF1ZXN0NDc4OTk2NTg=
| 2,831 |
added fix for #2826
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1321193?v=4",
"events_url": "https://api.github.com/users/shagunsodhani/events{/privacy}",
"followers_url": "https://api.github.com/users/shagunsodhani/followers",
"following_url": "https://api.github.com/users/shagunsodhani/following{/other_user}",
"gists_url": "https://api.github.com/users/shagunsodhani/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/shagunsodhani",
"id": 1321193,
"login": "shagunsodhani",
"node_id": "MDQ6VXNlcjEzMjExOTM=",
"organizations_url": "https://api.github.com/users/shagunsodhani/orgs",
"received_events_url": "https://api.github.com/users/shagunsodhani/received_events",
"repos_url": "https://api.github.com/users/shagunsodhani/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/shagunsodhani/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shagunsodhani/subscriptions",
"type": "User",
"url": "https://api.github.com/users/shagunsodhani",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-10-16T11:35:26Z
|
2021-09-08T06:00:52Z
|
2015-10-16T12:21:45Z
|
CONTRIBUTOR
|
resolved
|
Added some data to 2 sample requests on quickstart as discussed [here](https://github.com/kennethreitz/requests/issues/2826).
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2831/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2831/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2831.diff",
"html_url": "https://github.com/psf/requests/pull/2831",
"merged_at": "2015-10-16T12:21:45Z",
"patch_url": "https://github.com/psf/requests/pull/2831.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2831"
}
| true |
[
"Thanks for this @shagunsodhani! :sparkles: :cake: :sparkles:\n",
":smile: \n"
] |
https://api.github.com/repos/psf/requests/issues/2830
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2830/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2830/comments
|
https://api.github.com/repos/psf/requests/issues/2830/events
|
https://github.com/psf/requests/issues/2830
| 111,741,354 |
MDU6SXNzdWUxMTE3NDEzNTQ=
| 2,830 |
custom retries doesn't work while using POST method
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3613180?v=4",
"events_url": "https://api.github.com/users/tribals/events{/privacy}",
"followers_url": "https://api.github.com/users/tribals/followers",
"following_url": "https://api.github.com/users/tribals/following{/other_user}",
"gists_url": "https://api.github.com/users/tribals/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/tribals",
"id": 3613180,
"login": "tribals",
"node_id": "MDQ6VXNlcjM2MTMxODA=",
"organizations_url": "https://api.github.com/users/tribals/orgs",
"received_events_url": "https://api.github.com/users/tribals/received_events",
"repos_url": "https://api.github.com/users/tribals/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/tribals/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tribals/subscriptions",
"type": "User",
"url": "https://api.github.com/users/tribals",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2015-10-16T01:43:52Z
|
2021-09-08T21:00:55Z
|
2015-10-16T02:14:42Z
|
NONE
|
resolved
|
I had very confused
```
#!/usr/bin/env python
import logging
import requests
from requests.adapters import HTTPAdapter
from requests.packages.urllib3 import Retry
logging.basicConfig()
logging.getLogger().setLevel(logging.DEBUG)
requests_log = logging.getLogger('requests')
requests_log.setLevel(logging.DEBUG)
requests_log.propagate = True
with requests.Session() as s:
retry = Retry(status_forcelist=[503])
adapter = HTTPAdapter(max_retries=retry)
s.mount('http://', adapter)
try:
# r = s.get('http://httpbin.org/status/503')
r = s.post('http://httpbin.org/status/503')
r.raise_for_status()
except requests.HTTPError:
print 'BANG!'
print "where are my retries???"
except requests.exceptions.RetryError:
print 'computation does not rich this exception'
```
When `session.get()` all works fine.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2830/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2830/timeline
| null |
completed
| null | null | false |
[
"You need to specify the methods via the `method_whitelist` parameter to the Retry class. \n",
"thx, forgive my inattention\n",
"No worries @tribals. If you read my blog post about retries with requests I probably failed to mention this. Cheers!\n",
"if it's [this post](http://www.coglib.com/~icordasc/blog/2014/12/retries-in-requests.html), then yep, i've read it\n"
] |
https://api.github.com/repos/psf/requests/issues/2829
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2829/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2829/comments
|
https://api.github.com/repos/psf/requests/issues/2829/events
|
https://github.com/psf/requests/pull/2829
| 111,623,043 |
MDExOlB1bGxSZXF1ZXN0NDc3ODk3ODk=
| 2,829 |
Use buffering for HTTP responses on chunked requests
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5539301?v=4",
"events_url": "https://api.github.com/users/dblia/events{/privacy}",
"followers_url": "https://api.github.com/users/dblia/followers",
"following_url": "https://api.github.com/users/dblia/following{/other_user}",
"gists_url": "https://api.github.com/users/dblia/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dblia",
"id": 5539301,
"login": "dblia",
"node_id": "MDQ6VXNlcjU1MzkzMDE=",
"organizations_url": "https://api.github.com/users/dblia/orgs",
"received_events_url": "https://api.github.com/users/dblia/received_events",
"repos_url": "https://api.github.com/users/dblia/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dblia/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dblia/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dblia",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 6 |
2015-10-15T14:00:08Z
|
2021-09-08T06:00:52Z
|
2015-10-15T14:37:06Z
|
CONTRIBUTOR
|
resolved
|
For non-chunked requests, the request is performed using the 'urlopen'
method that underlying uses buffering for the HTTP responses (for Python
2.7+ versions). For chunked requests though, the request is made via a
different code path and so the 'getresponse' method is called without
using buffering. So, the response is consumed per single byte via a
recv() call on the underlying socket.
This patch, fixes that issue to mimic the non-chucked request behavior.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2829/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2829/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2829.diff",
"html_url": "https://github.com/psf/requests/pull/2829",
"merged_at": "2015-10-15T14:37:06Z",
"patch_url": "https://github.com/psf/requests/pull/2829.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2829"
}
| true |
[
"This seems like a sensible change to me, I'm :+1:. @sigmavirus24?\n",
"What's the benefit?\n",
"Without `buffering`, `httplib` will issue a lot of 1-byte reads in order to satisfy the constraints of the `read` call. That's...not good.\n",
"Sorry, I was reading the commit message/PR message backwards. LGTM :+1: \n",
"Thanks for this @dblia! :cake: :sparkles: :cake:\n",
"Thanks for the immediate response @Lukasa and @sigmavirus24!\n"
] |
https://api.github.com/repos/psf/requests/issues/2828
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2828/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2828/comments
|
https://api.github.com/repos/psf/requests/issues/2828/events
|
https://github.com/psf/requests/issues/2828
| 111,614,881 |
MDU6SXNzdWUxMTE2MTQ4ODE=
| 2,828 |
PUT send is doing Quotation on json payload
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5641381?v=4",
"events_url": "https://api.github.com/users/czerwe/events{/privacy}",
"followers_url": "https://api.github.com/users/czerwe/followers",
"following_url": "https://api.github.com/users/czerwe/following{/other_user}",
"gists_url": "https://api.github.com/users/czerwe/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/czerwe",
"id": 5641381,
"login": "czerwe",
"node_id": "MDQ6VXNlcjU2NDEzODE=",
"organizations_url": "https://api.github.com/users/czerwe/orgs",
"received_events_url": "https://api.github.com/users/czerwe/received_events",
"repos_url": "https://api.github.com/users/czerwe/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/czerwe/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/czerwe/subscriptions",
"type": "User",
"url": "https://api.github.com/users/czerwe",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 6 |
2015-10-15T13:19:01Z
|
2021-09-08T21:00:59Z
|
2015-10-15T13:20:47Z
|
NONE
|
resolved
|
Hi,
i need to send via PUT an octetstream/json element via put. requests is quoting the full string. Example:
```
testdata = '[{"cid": "1","uuid": "sdasd"}]'
response = requests.put(requestUrl, auth=self.auth, json=testdata)
```
can be seen in Wireshare like this:
"[{\"cid\": \"1\",\"uuid\": \"sdasd\"}]"
if i use POST it is unquoted.
My remote REST Interface is not able to handle the quoted strings. I wasn't able to find any option where i can turn of the quotation.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2828/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2828/timeline
| null |
completed
| null | null | false |
[
"If you read the [documentation](http://docs.python-requests.org/en/latest/user/quickstart/?highlight=json#more-complicated-post-requests) closely, you'll see your code should look like:\n\n``` py\n testdata = [{\"cid\": \"1\",\"uuid\": \"sdasd\"}]\n response = requests.put(requestUrl, auth=self.auth, json=testdata)\n```\n",
"the response is within a class which contains the auth definitin like:\n\nself.auth = HTTPBasicAuth(username, password)\n\nand i use this later on.\nAnd how does the auth content influence the payload?\n",
"@czerwe \n1. I don't understand your question\n2. The issue tracker is not a support forum. Please use [StackOverflow](https://stackoverflow.com/questions/tagged/python-requests)\n",
"I am sorry about missleaded:\nif found out that this seems to work:\n testdata = [{\"cid\": 1, \"uuid\":2}]\n response = requests.put(requestUrl, auth=self.auth, headers={\"Content-Type\": 'application/json'}, data=json.dumps(testdata))\n\nusing jsons doing quotation. From my point it's a missbehavior of the json handler in the session. \nNevertheless sorry.\n",
"It is not an error in the Json handler. The json handler does not accept a _string_, it accepts the Python object directly. The difference between what you provided and what @sigmavirus24 gave is this:\n\n``` python\ntestdata = '[{\"cid\": \"1\",\"uuid\": \"sdasd\"}]'\ntestdata = [{\"cid\": \"1\",\"uuid\": \"sdasd\"}]\n```\n",
"I was already wondering.\nYour right. I tried so many things that some error output from the response miss leaded me. \n\nThank you both. Next time i will ask in StackOverflow first.\nSorry.\n"
] |
https://api.github.com/repos/psf/requests/issues/2827
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2827/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2827/comments
|
https://api.github.com/repos/psf/requests/issues/2827/events
|
https://github.com/psf/requests/pull/2827
| 111,608,494 |
MDExOlB1bGxSZXF1ZXN0NDc3ODA5MTI=
| 2,827 |
Fixed usage example in sessions.py
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3153932?v=4",
"events_url": "https://api.github.com/users/daniel-mueller/events{/privacy}",
"followers_url": "https://api.github.com/users/daniel-mueller/followers",
"following_url": "https://api.github.com/users/daniel-mueller/following{/other_user}",
"gists_url": "https://api.github.com/users/daniel-mueller/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/daniel-mueller",
"id": 3153932,
"login": "daniel-mueller",
"node_id": "MDQ6VXNlcjMxNTM5MzI=",
"organizations_url": "https://api.github.com/users/daniel-mueller/orgs",
"received_events_url": "https://api.github.com/users/daniel-mueller/received_events",
"repos_url": "https://api.github.com/users/daniel-mueller/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/daniel-mueller/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/daniel-mueller/subscriptions",
"type": "User",
"url": "https://api.github.com/users/daniel-mueller",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-10-15T12:43:54Z
|
2021-09-08T06:00:52Z
|
2015-10-15T13:01:13Z
|
CONTRIBUTOR
|
resolved
|
The usage example for sessions.py's Session class is not correct in my opinion. The get method in fact returns a `Response <Response>` object, the notation "200" may be misleading the user into thinking only the http statuscode will be returned. Furthermore the output you get on console if typing the example in is different from the example and similar to my change.
The two usage examples in models.py are also similar to my change.
Thank you for considering.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2827/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2827/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2827.diff",
"html_url": "https://github.com/psf/requests/pull/2827",
"merged_at": "2015-10-15T13:01:13Z",
"patch_url": "https://github.com/psf/requests/pull/2827.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2827"
}
| true |
[
"Thanks for this @daniel-mueller!\n"
] |
https://api.github.com/repos/psf/requests/issues/2826
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2826/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2826/comments
|
https://api.github.com/repos/psf/requests/issues/2826/events
|
https://github.com/psf/requests/issues/2826
| 111,390,933 |
MDU6SXNzdWUxMTEzOTA5MzM=
| 2,826 |
Bad examples of PUSH and PUT in Quickstart
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/227449?v=4",
"events_url": "https://api.github.com/users/TorKlingberg/events{/privacy}",
"followers_url": "https://api.github.com/users/TorKlingberg/followers",
"following_url": "https://api.github.com/users/TorKlingberg/following{/other_user}",
"gists_url": "https://api.github.com/users/TorKlingberg/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/TorKlingberg",
"id": 227449,
"login": "TorKlingberg",
"node_id": "MDQ6VXNlcjIyNzQ0OQ==",
"organizations_url": "https://api.github.com/users/TorKlingberg/orgs",
"received_events_url": "https://api.github.com/users/TorKlingberg/received_events",
"repos_url": "https://api.github.com/users/TorKlingberg/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/TorKlingberg/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/TorKlingberg/subscriptions",
"type": "User",
"url": "https://api.github.com/users/TorKlingberg",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2015-10-14T12:48:36Z
|
2021-09-08T21:00:58Z
|
2015-10-19T09:48:54Z
|
NONE
|
resolved
|
The quickstart guide had these examples:
```
>>> r = requests.post("http://httpbin.org/post")
>>> r = requests.put("http://httpbin.org/put")
```
With PUSH and PUT you almost always want to include some data. Without it they become fairly meaningless.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2826/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2826/timeline
| null |
completed
| null | null | false |
[
"That's certainly true, though with the quickstart guide we're generally trying to err on the side of not providing _too_ much extraneous information. Nevertheless, if you'd like to open a pull request giving both of those some data (a simple bytestring will do), I'd be happy to merge that. =)\n",
"@Lukasa I have opened a pull request for this.\n",
"Thanks @shagunsodhani. I got busy and didn't notice this.\n"
] |
https://api.github.com/repos/psf/requests/issues/2825
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2825/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2825/comments
|
https://api.github.com/repos/psf/requests/issues/2825/events
|
https://github.com/psf/requests/pull/2825
| 111,386,635 |
MDExOlB1bGxSZXF1ZXN0NDc2NTE5OTk=
| 2,825 |
Add warnings about text/binary mode files.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 7 |
2015-10-14T12:24:27Z
|
2021-09-08T06:00:50Z
|
2015-10-24T14:37:16Z
|
MEMBER
|
resolved
|
Resolves #2725.
@sigmavirus24 I'm wondering if we should add a warning to `super_len` for whenever we decide on the length of the file using `os.fstat`, if the file has not been opened in binary mode. It should be easy enough to do. Thoughts?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2825/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2825/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2825.diff",
"html_url": "https://github.com/psf/requests/pull/2825",
"merged_at": "2015-10-24T14:37:16Z",
"patch_url": "https://github.com/psf/requests/pull/2825.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2825"
}
| true |
[
"@Lukasa do we want to add that warning in `super_len` and then make it a hard exception in 3.0.0?\n",
"@sigmavirus24 Yeah, probably.\n",
"♥ thanks brosephs @sigmavirus24 @Lukasa \n",
"@Lukasa do you want me to send that separately or do you want to do that as part of this PR?\n",
"Ah, I forgot about that. Let's do it here.\n",
"Ok, I added a warning that should fire once the first time this happens (no need to spam the crap out of people with it). It's strictly a subclass of `DeprecationWarning`, which I think is ok too.\n",
"Excellent work @Lukasa . Thanks!\n"
] |
https://api.github.com/repos/psf/requests/issues/2824
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2824/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2824/comments
|
https://api.github.com/repos/psf/requests/issues/2824/events
|
https://github.com/psf/requests/issues/2824
| 111,162,613 |
MDU6SXNzdWUxMTExNjI2MTM=
| 2,824 |
Test failure for 2.8.0
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/25111?v=4",
"events_url": "https://api.github.com/users/cournape/events{/privacy}",
"followers_url": "https://api.github.com/users/cournape/followers",
"following_url": "https://api.github.com/users/cournape/following{/other_user}",
"gists_url": "https://api.github.com/users/cournape/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cournape",
"id": 25111,
"login": "cournape",
"node_id": "MDQ6VXNlcjI1MTEx",
"organizations_url": "https://api.github.com/users/cournape/orgs",
"received_events_url": "https://api.github.com/users/cournape/received_events",
"repos_url": "https://api.github.com/users/cournape/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cournape/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cournape/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cournape",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-10-13T11:41:16Z
|
2021-09-08T21:00:59Z
|
2015-10-13T12:07:20Z
|
NONE
|
resolved
|
I see this test failure:
```
y.test test_requests.py
============================================================================================================================= test session starts ==============================================================================================================================
platform linux2 -- Python 2.7.10, pytest-2.8.2, py-1.4.30, pluggy-0.3.1
rootdir: /home/davidc/src/python/requests, inifile:
collected 165 items
test_requests.py ......................................................................................x...........................................................F..................
=================================================================================================================================== FAILURES ===================================================================================================================================
_______________________________________________________________________________________________________________ TestMorselToCookieExpires.test_expires_valid_str _______________________________________________________________________________________________________________
self = <test_requests.TestMorselToCookieExpires testMethod=test_expires_valid_str>
def test_expires_valid_str(self):
"""Test case where we convert expires from string time."""
morsel = Morsel()
morsel['expires'] = 'Thu, 01-Jan-1970 00:00:01 GMT'
cookie = morsel_to_cookie(morsel)
> assert cookie.expires == 1
E AssertionError: assert -3599 == 1
E + where -3599 = Cookie(version=0, name=None, value=None, port=None, port_specified=False, domain='', domain_specified=False, domain_in...False, secure=False, expires=-3599, discard=False, comment='', comment_url=False, rest={'HttpOnly': ''}, rfc2109=False).expires
test_requests.py:1455: AssertionError
=============================================================================================================== 1 failed, 163 passed, 1 xfailed in 33.37 seconds ===============================================================================================================
```
Is this expected ?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2824/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2824/timeline
| null |
completed
| null | null | false |
[
"Sadly, this is a known problem. See #1859 for the initial report and #1860 for a proposed fix that never landed. Currently we don't have a good proposal for how to fix this permanently, but the test failure you have right there is benign.\n",
"understood. Thanks for letting me know\n"
] |
https://api.github.com/repos/psf/requests/issues/2823
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2823/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2823/comments
|
https://api.github.com/repos/psf/requests/issues/2823/events
|
https://github.com/psf/requests/issues/2823
| 111,011,545 |
MDU6SXNzdWUxMTEwMTE1NDU=
| 2,823 |
Please create v2.8.0 tag
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/229453?v=4",
"events_url": "https://api.github.com/users/Natim/events{/privacy}",
"followers_url": "https://api.github.com/users/Natim/followers",
"following_url": "https://api.github.com/users/Natim/following{/other_user}",
"gists_url": "https://api.github.com/users/Natim/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Natim",
"id": 229453,
"login": "Natim",
"node_id": "MDQ6VXNlcjIyOTQ1Mw==",
"organizations_url": "https://api.github.com/users/Natim/orgs",
"received_events_url": "https://api.github.com/users/Natim/received_events",
"repos_url": "https://api.github.com/users/Natim/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Natim/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Natim/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Natim",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-10-12T16:36:01Z
|
2021-09-08T22:00:41Z
|
2015-10-12T17:08:44Z
|
NONE
|
resolved
|
Tag v2.8.0 seems missing: e499b354c4215b158db6d4210136e0b9adbe8d14
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2823/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2823/timeline
| null |
completed
| null | null | false |
[
"Sorry, pushed it up now. =)\n",
"Thanks\nLe 12 oct. 2015 19:09, \"Cory Benfield\" [email protected] a écrit :\n\n> Sorry, pushed it up now. =)\n> \n> —\n> Reply to this email directly or view it on GitHub\n> https://github.com/kennethreitz/requests/issues/2823#issuecomment-147463056\n> .\n"
] |
https://api.github.com/repos/psf/requests/issues/2822
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2822/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2822/comments
|
https://api.github.com/repos/psf/requests/issues/2822/events
|
https://github.com/psf/requests/issues/2822
| 110,997,302 |
MDU6SXNzdWUxMTA5OTczMDI=
| 2,822 |
requests doesn't prepare the request before passing it to the Auth backend.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/229453?v=4",
"events_url": "https://api.github.com/users/Natim/events{/privacy}",
"followers_url": "https://api.github.com/users/Natim/followers",
"following_url": "https://api.github.com/users/Natim/following{/other_user}",
"gists_url": "https://api.github.com/users/Natim/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Natim",
"id": 229453,
"login": "Natim",
"node_id": "MDQ6VXNlcjIyOTQ1Mw==",
"organizations_url": "https://api.github.com/users/Natim/orgs",
"received_events_url": "https://api.github.com/users/Natim/received_events",
"repos_url": "https://api.github.com/users/Natim/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Natim/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Natim/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Natim",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 9 |
2015-10-12T15:21:38Z
|
2021-09-08T22:00:42Z
|
2015-10-12T16:16:02Z
|
NONE
|
resolved
|
I know you will answer that this is a feature, but I am really stuck with https://github.com/mozilla-services/requests-hawk/pull/7/files
My Auth backend create a signature for the body, and I cannot read the body from the `Request()` object. Also it doesn't work with the json parameter.
I am not sure of the strategy I should adopt. Any thoughs?
``` python
# Auth backend call method.
def __call__(self, r):
if self.host is not None:
r.headers['Host'] = self.host
content_type = r.headers.get('Content-Type', '')
body = ''
if r.data:
body = r.data
elif r.json:
body = json.dumps(r.json)
content_type = 'application/json'
sender = mohawk.Sender(
self.credentials,
r.url,
r.method,
content=body,
content_type=content_type,
_timestamp=self._timestamp
)
r.headers['Authorization'] = sender.request_header
return r
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/229453?v=4",
"events_url": "https://api.github.com/users/Natim/events{/privacy}",
"followers_url": "https://api.github.com/users/Natim/followers",
"following_url": "https://api.github.com/users/Natim/following{/other_user}",
"gists_url": "https://api.github.com/users/Natim/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Natim",
"id": 229453,
"login": "Natim",
"node_id": "MDQ6VXNlcjIyOTQ1Mw==",
"organizations_url": "https://api.github.com/users/Natim/orgs",
"received_events_url": "https://api.github.com/users/Natim/received_events",
"repos_url": "https://api.github.com/users/Natim/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Natim/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Natim/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Natim",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2822/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2822/timeline
| null |
completed
| null | null | false |
[
"I have no clue how you're using the auth plugin, but it only works with `PreparedRequests`. It has never worked with `Request` objects. It's called by [`PreparedRequest.prepare_auth`](https://github.com/kennethreitz/requests/blob/14a555ac716866678bf17e43e23230d81a8149f5/requests/models.py#L473).\n",
"If it works with PreparedRequest, then it should have a populated `r.body` isn't it?\n",
"Ok so this `__call__` method:\n\n``` python\n def __call__(self, r):\n if self.host is not None:\n r.headers['Host'] = self.host\n\n sender = mohawk.Sender(\n self.credentials,\n r.url,\n r.method,\n content=r.body or '',\n content_type=r.headers.get('Content-Type'),\n _timestamp=self._timestamp\n )\n\n r.headers['Authorization'] = sender.request_header\n return r\n```\n\nWorks.\n",
"Body can be `None` or a file-like object or a string or a bytes object. The body attribute is not guaranteed to be \"populated\" depending on what you call that.\n\nAlso on redirects, we will (based on RFCs) clear out a body [if we've determined it's the right conditions to do so](https://github.com/kennethreitz/requests/blob/14a555ac716866678bf17e43e23230d81a8149f5/requests/sessions.py#L160..L165).\n",
"Do you see anything wrong with this call: \n\n``` python\n auth = HawkAuth(hawk_session=codecs.encode(b\"hello\", \"hex_codec\"),\n _timestamp=1431698847)\n\n request = Request('PUT', 'http://www.example.com',\n json={\"foo\": \"bar\"}, auth=auth)\n r = request.prepare()\n self.assertTrue('ts=\"1431698847\"' in r.headers['Authorization'],\n \"Timestamp doesn't match\")\n self.assertEqual(r.body, '{\"foo\": \"bar\"}')\n```\n",
"Not immediately. Why?\n",
"Oh I think I found the problem!\n\nhttps://github.com/kennethreitz/requests/blob/14a555ac716866678bf17e43e23230d81a8149f5/requests/models.py#L417\nversus\nhttps://github.com/kennethreitz/requests/blob/v2.8.0/requests/models.py#L406\n\nActually the tag for 2.8.0 doesn't seems to exists.\n\nThis was changed with https://github.com/kennethreitz/requests/commit/3948a9562db886e7ead6a48dbcbada34fbeb0838\n",
"The tag not existing is something @Lukasa can fix immediately\n",
"I guess I need to wait for the release of 2.8.1 with the fix in order to fix my problem.\n"
] |
https://api.github.com/repos/psf/requests/issues/2821
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2821/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2821/comments
|
https://api.github.com/repos/psf/requests/issues/2821/events
|
https://github.com/psf/requests/pull/2821
| 110,943,374 |
MDExOlB1bGxSZXF1ZXN0NDc0MDE0MjA=
| 2,821 |
Allow non-native-string method names.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[] |
closed
| true |
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
[
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
] | null | 4 |
2015-10-12T09:49:35Z
|
2021-09-08T06:00:53Z
|
2015-10-12T14:50:53Z
|
MEMBER
|
resolved
|
Resolves #2818.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2821/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2821/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2821.diff",
"html_url": "https://github.com/psf/requests/pull/2821",
"merged_at": "2015-10-12T14:50:53Z",
"patch_url": "https://github.com/psf/requests/pull/2821.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2821"
}
| true |
[
"I'm starting with just the failing test to confirm that our environment can actually reproduce it.\n",
"@sigmavirus24 I'd like to slip this into 2.8.1, which I plan to release tomorrow. Mind doing a quick review before then?\n",
"I feel certain that we've fixed this already, perhaps in 3.0.0?\n\nAnd a quick look shows we fixed it on July 18th: https://github.com/kennethreitz/requests/commit/ea1cbb3a1d9c6fb0edebb1bf0ac222c50054a367\n\nI don't see discussion in the [bug](https://github.com/kennethreitz/requests/issues/2613) about why we didn't propose that against master though (although parts of it are backwards incompatible).\n\nI'm +1 on fixing this and this looks like a good, simple, probably backwards compatible change.\n",
"Yeah, I don't really see why we didn't either. I think this fits here, and that past me was an idiot. =)\n"
] |
https://api.github.com/repos/psf/requests/issues/2820
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2820/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2820/comments
|
https://api.github.com/repos/psf/requests/issues/2820/events
|
https://github.com/psf/requests/issues/2820
| 110,910,683 |
MDU6SXNzdWUxMTA5MTA2ODM=
| 2,820 |
TypeError: unsupported operand type(s) for *: 'NoneType' and 'int'
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/14935567?v=4",
"events_url": "https://api.github.com/users/zajalo/events{/privacy}",
"followers_url": "https://api.github.com/users/zajalo/followers",
"following_url": "https://api.github.com/users/zajalo/following{/other_user}",
"gists_url": "https://api.github.com/users/zajalo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zajalo",
"id": 14935567,
"login": "zajalo",
"node_id": "MDQ6VXNlcjE0OTM1NTY3",
"organizations_url": "https://api.github.com/users/zajalo/orgs",
"received_events_url": "https://api.github.com/users/zajalo/received_events",
"repos_url": "https://api.github.com/users/zajalo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zajalo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zajalo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zajalo",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-10-12T05:25:25Z
|
2021-09-08T22:00:42Z
|
2015-10-12T08:05:45Z
|
NONE
|
resolved
|
I've been getting this error randomly while using [RoboBrowser](https://github.com/jmcarp/robobrowser). RoboBrowser installs with requests 2.7.0 but I checked line 166 of current version (2.8) of retry.py and it's the same.
I should add that I made a small modification to a file in RoboBrowser as described here: https://github.com/jmcarp/robobrowser/issues/52#issuecomment-144929550
```
Traceback (most recent call last):
File "fetch.py", line 139, in <module>
go()
File "fetch.py", line 120, in go
result = fetch(url)
File "fetch.py", line 29, in fetch
browser.open(url)
File "C:\Users\Vidpe\Desktop\mpb\venv\lib\site-packages\robobrowser\browser.py", line 205, in open
response = self.session.request(method, url, **self._build_send_args(**kwargs))
File "C:\Users\Vidpe\Desktop\mpb\venv\lib\site-packages\requests\sessions.py", line 465, in request
resp = self.send(prep, **send_kwargs)
File "C:\Users\Vidpe\Desktop\mpb\venv\lib\site-packages\requests\sessions.py", line 573, in send
r = adapter.send(request, **kwargs)
File "C:\Users\Vidpe\Desktop\mpb\venv\lib\site-packages\requests\adapters.py", line 370, in send
timeout=timeout
File "C:\Users\Vidpe\Desktop\mpb\venv\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 617, in urlopen
release_conn=release_conn, **response_kw)
File "C:\Users\Vidpe\Desktop\mpb\venv\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 598, in urlopen
retries.sleep()
File "C:\Users\Vidpe\Desktop\mpb\venv\lib\site-packages\requests\packages\urllib3\util\retry.py", line 175, in sleep
backoff = self.get_backoff_time()
File "C:\Users\Vidpe\Desktop\mpb\venv\lib\site-packages\requests\packages\urllib3\util\retry.py", line 166, in get_backoff_time
backoff_value = self.backoff_factor * (2 ** (self._observed_errors - 1))
TypeError: unsupported operand type(s) for *: 'NoneType' and 'int'
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2820/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2820/timeline
| null |
completed
| null | null | false |
[
"So a quick code read suggests that this is _impossible_ using standard requests. The `backoff_factor` attribute is defaulted to `0` and never assigned to `None` by any code in requests, as far as I can see.\n\nHowever, a quick search of RoboBrowser reveals that _it_ sets the `backoff_factor`, [here](https://github.com/jmcarp/robobrowser/blob/a243352a25f093d8107067cc63f5784b00e6f39c/robobrowser/browser.py#L109), and in the default case will set it to `None`. `None` is not an allowed value for the backoff factor: this is a bug in RoboBrowser.\n"
] |
https://api.github.com/repos/psf/requests/issues/2819
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2819/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2819/comments
|
https://api.github.com/repos/psf/requests/issues/2819/events
|
https://github.com/psf/requests/issues/2819
| 110,859,702 |
MDU6SXNzdWUxMTA4NTk3MDI=
| 2,819 |
Problem with `json` parameter in POST for requests 2.8.0
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3287067?v=4",
"events_url": "https://api.github.com/users/asieira/events{/privacy}",
"followers_url": "https://api.github.com/users/asieira/followers",
"following_url": "https://api.github.com/users/asieira/following{/other_user}",
"gists_url": "https://api.github.com/users/asieira/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/asieira",
"id": 3287067,
"login": "asieira",
"node_id": "MDQ6VXNlcjMyODcwNjc=",
"organizations_url": "https://api.github.com/users/asieira/orgs",
"received_events_url": "https://api.github.com/users/asieira/received_events",
"repos_url": "https://api.github.com/users/asieira/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/asieira/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/asieira/subscriptions",
"type": "User",
"url": "https://api.github.com/users/asieira",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2015-10-11T14:31:02Z
|
2021-09-05T00:06:49Z
|
2015-10-11T14:32:28Z
|
CONTRIBUTOR
|
resolved
|
The following code works in requests 2.7.0 but raises an assertion error in 2.8.0:
```
import requests
session = requests.session()
session.headers.update({'x-api-key': 'blah', "Accept-Encoding": "gzip, deflate",
"User-Agent": "magnet-sdk-python"})
session.verify = True
req = requests.Request(method='POST', url='https://portal.niddel.com/api/v1-beta/alerts', params=None, json={'a': 1, 'b': 2})
req = session.prepare_request(req)
assert req.body
```
Since I provided neither `files` nor `body`, I would have expected `json` to work.
In case you need this info to reproduce the issue, all tests were performed on a Mac OS X with Python 2.7.10 (installed using homebrew).
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2819/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2819/timeline
| null |
completed
| null | null | false |
[
"@asieira Thanks for this! This is a duplicate of #2813, and should be resolved in 2.8.1.\n",
":+1:\n",
"Bom dia Pessoal, estou com o um projeto na empresa onde devo se comunicar com o serviço do governo e estou patinando para se autenticar no mesmo onde pede para enviar o certificado encapsulado em uma keystore como demostra o link abaixo:\r\n\r\nhttps://val.portalunico.siscomex.gov.br/docs/api/\r\n\r\nJá tentei de diversas formas, mas sempre me retorna o erro:\r\n\r\nHTTPSConnectionPool(host='val.portalunico.siscomex.gov.br', port=443): Max retries exceeded with url: /portal/api/autenticar (Caused by SSLError(SSLError(\"bad handshake: Error([('SSL routines', 'tls_process_server_certificate', 'certificate verify failed')])\")))\r\n\r\nFiz o teste pelo Postman tambem e esta se comunicando corretamente, ate copiei o código gerado por ele, só que o mesmo não gera o parte do codigo do handshake:\r\n\r\nO certificado esta VALIDO, e é utilizado no ambiente de produção, ou seja não tem nenhum problema com o mesmo.\r\n\r\nimport http.client \r\n\r\nconn = http.client.HTTPSConnection(\"portalunico.siscomex.gov.br\") \r\n\r\nheaders = {'role-type': \"IMPEXP\"} \r\n\r\ntry:\r\n\r\n conn.request(\"POST\", \"/portal/api/autenticar\", headers=headers) \r\n\r\n res = conn.getresponse()\r\n\r\n data = res.read()\r\n\r\n print(data.decode(\"utf-8\"))\r\n\r\nexcept Exception as erro:\r\n\r\n print('Erro:'+str(erro)) \r\n\r\n \r\n\r\nSegue abaixo o codigo que tenho:\r\n\r\n# coding:utf-8\r\n\r\n#!/usr/bin/env python \r\n\r\nfrom OpenSSL import crypto\r\n\r\nfrom requests_pkcs12 import post\r\n\r\nimport requests_pkcs12 \r\n\r\nurl = \"https://val.portalunico.siscomex.gov.br/portal/api/autenticar\"\r\n\r\ncertificado = \"certificado.p12\"\r\n\r\n \r\n\r\n#certif = pkcs12_filename = certificado\r\n\r\n#key = pkcs12_password = '123456'\r\n\r\n \r\n\r\n#certificado = (pkcs12_filename=certificado,pkcs12_password='123456') \r\n\r\nheader = {\"Content-Type\": \"application/json\", \r\n\r\n \"Role-Type\": \"IMPEXP\"} \r\n\r\ntry:\r\n\r\n post(url,headers=header,proxies =proxy, pkcs12_filename=certificado,pkcs12_password='123456') \r\n\r\nexcept Exception as e: \r\n\r\n print('Erro:'+str(e))\r\n\r\n \r\n\r\nSe alguém souber de como eu realizar essa autenticação ficaria muito grato. \r\n\r\nObrigado ...."
] |
https://api.github.com/repos/psf/requests/issues/2818
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2818/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2818/comments
|
https://api.github.com/repos/psf/requests/issues/2818/events
|
https://github.com/psf/requests/issues/2818
| 110,825,868 |
MDU6SXNzdWUxMTA4MjU4Njg=
| 2,818 |
TypeError after 2.7.0 -> 2.8.0 upgrade (cannot make memory view...)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/950506?v=4",
"events_url": "https://api.github.com/users/simon-weber/events{/privacy}",
"followers_url": "https://api.github.com/users/simon-weber/followers",
"following_url": "https://api.github.com/users/simon-weber/following{/other_user}",
"gists_url": "https://api.github.com/users/simon-weber/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/simon-weber",
"id": 950506,
"login": "simon-weber",
"node_id": "MDQ6VXNlcjk1MDUwNg==",
"organizations_url": "https://api.github.com/users/simon-weber/orgs",
"received_events_url": "https://api.github.com/users/simon-weber/received_events",
"repos_url": "https://api.github.com/users/simon-weber/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/simon-weber/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/simon-weber/subscriptions",
"type": "User",
"url": "https://api.github.com/users/simon-weber",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 27 |
2015-10-11T00:33:59Z
|
2021-09-08T20:01:02Z
|
2015-10-12T14:50:53Z
|
NONE
|
resolved
|
I'm running into this traceback after upgrading to 2.8.0 from 2.7.0:
```
<snip>
response = self.session.send(request)
File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/requests/sessions.py", line 579, in send
r = adapter.send(request, **kwargs)
File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/requests/adapters.py", line 369, in send
timeout=timeout
File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 559, in urlopen
body=body, headers=headers)
File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 353, in _make_request
conn.request(method, url, **httplib_request_kw)
File "/opt/python/2.7.9/lib/python2.7/httplib.py", line 1001, in request
self._send_request(method, url, body, headers)
File "/opt/python/2.7.9/lib/python2.7/httplib.py", line 1035, in _send_request
self.endheaders(body)
File "/opt/python/2.7.9/lib/python2.7/httplib.py", line 997, in endheaders
self._send_output(message_body)
File "/opt/python/2.7.9/lib/python2.7/httplib.py", line 850, in _send_output
self.send(msg)
File "/opt/python/2.7.9/lib/python2.7/httplib.py", line 826, in send
self.sock.sendall(data)
File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/requests/packages/urllib3/contrib/pyopenssl.py", line 216, in sendall
data = memoryview(data)
TypeError: cannot make memory view because object does not have the buffer interface
```
The problem goes away after downgrading to 2.7.0.
A full traceback can be found [here](https://travis-ci.org/simon-weber/gmusicapi/jobs/82365307).
Here are the versions of relevant packages:
```
httplib2-0.9.2
ndg-httpsclient-0.4.0
pyasn1-0.1.9
pyasn1-modules-0.0.8
pyopenssl-0.15.1
requests-2.8.0
```
And a full list of packages:
```
MechanicalSoup-0.3.1
appdirs-1.4.0
beautifulsoup4-4.4.1
cffi-1.2.1
cryptography-1.0.2
decorator-4.0.4
enum34-1.0.4
gmusicapi-7.0.1.dev0
gpsoauth-0.0.4
httplib2-0.9.2
idna-2.0
ipaddress-1.0.14
mutagen-1.31
ndg-httpsclient-0.4.0
oauth2client-1.5.1
proboscis-1.2.6.0
protobuf-2.6.1
pyasn1-0.1.9
pyasn1-modules-0.0.8
pycparser-2.14
pycrypto-2.6.1
pyopenssl-0.15.1
python-dateutil-2.4.2
requests-2.8.0
rsa-3.2
six-1.10.0
validictory-1.0.1
```
Any ideas?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2818/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2818/timeline
| null |
completed
| null | null | false |
[
"Can I see a bit of sample code? I suspect you're passing a Unicode string somewhere. \n",
"Good call. To reproduce this, you need both a unicode method and an https url, eg\n\n```\npython -c 'import requests; s = requests.Session(); r = requests.Request(u\"POST\", \"https://httpbin.org/post\"); pr = s.prepare_request(r); print s.send(pr).content'\n```\n\nIn my case, the unicode method comes from [this line](https://github.com/hickford/MechanicalSoup/blob/0dd97c237cbad16e7c3f6a46dcbd6f067b319652/mechanicalsoup/browser.py#L36) in a library I'm using.\n",
"So, this is strictly a regression IMO: requests is supposed to handle this reasonably correctly. Clearly we regressed that somewhere down the line. I'll see if I can get a fix for this into 2.8.1.\n",
"The reason we regressed this is because urllib3's PyOpenSSL compatibility layer started using memoryviews. I think we can likely only reproduce this bug when using that, but we were definitely doing this wrong and should fix it.\n",
"Ok, proposed fix in #2821.\n",
"Nice; thanks for the quick fix.\n",
"I just got this error with requests 2.8.1. I can't be specific about what caused it, since I'm using a library that uses Tweepy, which uses requests. The test case posted by simon-weber above worked, but the actual POST didn't. I'm using Python 2.7 on Linux.\n\nDowngrading to requests 2.7 fixed the issue.\n",
"@fitnr It's going to be really important to have a traceback/use-case. The problem will be mixing unicode/bytes, but we really need to see where the unicode is getting into our system. =)\n",
"@Lukasa I understand, but I don't have time to crack open Tweepy at the moment. The POST payload did contain unicode, I can tell you that.\n",
"The payload itself _should_ be fine, I'm more worried about the headers.\n",
"We received a report about this as well with requests 2.8.1\n",
"@jorilallo care to elaborate? Any details you can provide? Anything to help us help you?\n",
"@netanelkl reported this so it's probably better if he explains, I haven't had time to test this\n",
"I got this same issue when unicode strings were being passed as the header keys.\nI'm now coding a test code to help you reproduce it.\n",
"This for example:\nI stubbed this from the source lib that caused the problem.\nRemoving the single unicode header, solves the problem\n\n``` Python\nimport hashlib\nimport hmac\nimport requests\nfrom requests.auth import AuthBase\nimport time\n\n\nclass HMACAuth(AuthBase):\n\n def __call__(self, request):\n timestamp = str(int(time.time()))\n message = timestamp + request.method + request.path_url + (request.body or '')\n secret = \"TEST\"\n\n if not isinstance(message, bytes):\n message = message.encode()\n if not isinstance(secret, bytes):\n secret = secret.encode()\n\n signature = hmac.new(secret, message, hashlib.sha256).hexdigest()\n request.headers.update({\n 'CB-VERSION': \"\",\n 'CB-ACCESS-KEY': \"\",\n u'CB-ACCESS-SIGN': signature,\n 'CB-ACCESS-TIMESTAMP': timestamp,\n })\n return request\n\n\nsession = requests.session()\nsession.auth = HMACAuth()\nsession.headers.update({'Accept': 'application/json',\n 'Content-Type': 'application/json',\n 'User-Agent': 'coinbase/python/2.0'})\na = session.get(\"https://www.google.com\")\n```\n",
"Ok, so this is a tricky one.\n\nWe validate header keys when they are passed in through the functional APIs at the top, and convert them to the native string on the platform. However, we do _not_ do that when you work directly with a `PreparedRequest`, which is what you're doing here. Neither should we: the purpose of the `PreparedRequest` is that we promise not to mess with it anymore.\n\nIn your case, you may find it useful to wrap each of the keys in `requests.utils.to_native_string`.\n",
"oh I see. Makes sense.\nI guess the problem goes back to @jorilallo , this is a rather simple fix in the coinbase python library.\nThank you for checking this out!\n",
"This issue still occurs for me on 2.8.1 when posting a unicode string:\n\n```\n>>> import requests\n>>> r = requests.post('https://example.com', data=u'unicode data')\nTraceback (most recent call last):\n File \"<stdin>\", line 1, in <module>\n File \"/usr/local/lib/python2.7/dist-packages/requests/api.py\", line 109, in post\n return request('post', url, data=data, json=json, **kwargs)\n File \"/usr/local/lib/python2.7/dist-packages/requests/api.py\", line 50, in request\n response = session.request(method=method, url=url, **kwargs)\n File \"/usr/local/lib/python2.7/dist-packages/requests/sessions.py\", line 468, in request\n resp = self.send(prep, **send_kwargs)\n File \"/usr/local/lib/python2.7/dist-packages/requests/sessions.py\", line 576, in send\n r = adapter.send(request, **kwargs)\n File \"/usr/local/lib/python2.7/dist-packages/requests/adapters.py\", line 370, in send\n timeout=timeout\n File \"/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/connectionpool.py\", line 559, in urlopen\n body=body, headers=headers)\n File \"/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/connectionpool.py\", line 353, in _make_request\n conn.request(method, url, **httplib_request_kw)\n File \"/usr/lib/python2.7/httplib.py\", line 979, in request\n self._send_request(method, url, body, headers)\n File \"/usr/lib/python2.7/httplib.py\", line 1013, in _send_request\n self.endheaders(body)\n File \"/usr/lib/python2.7/httplib.py\", line 975, in endheaders\n self._send_output(message_body)\n File \"/usr/lib/python2.7/httplib.py\", line 839, in _send_output\n self.send(message_body)\n File \"/usr/lib/python2.7/httplib.py\", line 811, in send\n self.sock.sendall(data)\n File \"/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/contrib/pyopenssl.py\", line 216, in sendall\n data = memoryview(data)\nTypeError: cannot make memory view because object does not have the buffer interface\n```\n\nAfter fiddling a bit, this only happens if `ndg-httpsclient-0.4.0` is installed. When removed, the problem no longer occurs.\n\nOf course sending byte strings in the post data also solves the problem.\n",
"It is a very bad idea to send unicode strings in body data. This is because the body data goes onto the wire as-is. The reason it appears to \"work\" in your example above is because of Python 2.7's loose handling of byte and unicode strings, but it's definitely wrong, and will explode if your unicode string contains any data outside of the default encoding on your system. For example, try changing your example to this:\n\n``` python\n>>> import requests\n>>> r = requests.post('https://example.com', data=u'unicode data\\ua000')\n```\n\nYou'll find that this fails with a `UnicodeEncodeError`, as it should.\n\nThe rule here is: do not send unicode in the body.\n",
"@Lukasa It appears that example works with requests 2.7.0 and a default encoding of 'utf-8'. The issue we are encountering is that upgrading requests from 2.7.0 now breaks all requests that could have utf-8 data being sent in the data field, without prior warning. Would there be a way to avoid this breaking change?\n",
"@vinodc To be clear, the error you're encountering is a known bug in urllib3 that has been fixed (see shazow/urllib3#719). However, that fix will not be pulled into the released version of requests until urllib3 ships a new release and then requests ships 2.9.0. Until such time, you could apply the diff from the linked patch to your installation or, alternatively, simply encode the data yourself.\n\n> It appears that example works with requests 2.7.0 and a default encoding of 'utf-8'.\n\nThe reason I encourage you to encode the data yourself is that the example only works _by sheer good luck_. There are many ways this could fail, and it could fail in other environments. Relying on Python 2.7's implicit encoding/decoding is extremely dangerous, and I strongly encourage you to resolve this problem.\n",
"@Lukasa Got it. Thanks for the detailed response.\n",
"Got an email about this today. Sounds like there's a demand for 2.9 :)\n",
"Yup. We're on track, but @shazow is taking a well-deserved birthday break so it'll be a little bit. \n",
"Meow. What do we need from me? A urllib3 release?\n",
"Yarp. Let me know when you want to do it, and I can spend a few hours ahead of time looking at PRs and stuff you want to merge before a release. =)\n",
"Okely, thanks! Made an issue: shazow/urllib3#755\n"
] |
https://api.github.com/repos/psf/requests/issues/2817
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2817/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2817/comments
|
https://api.github.com/repos/psf/requests/issues/2817/events
|
https://github.com/psf/requests/issues/2817
| 110,692,438 |
MDU6SXNzdWUxMTA2OTI0Mzg=
| 2,817 |
RFE: Be able to pass 'no_proxy' in proxies dictionary argument
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/578155?v=4",
"events_url": "https://api.github.com/users/JohnVillalovos/events{/privacy}",
"followers_url": "https://api.github.com/users/JohnVillalovos/followers",
"following_url": "https://api.github.com/users/JohnVillalovos/following{/other_user}",
"gists_url": "https://api.github.com/users/JohnVillalovos/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/JohnVillalovos",
"id": 578155,
"login": "JohnVillalovos",
"node_id": "MDQ6VXNlcjU3ODE1NQ==",
"organizations_url": "https://api.github.com/users/JohnVillalovos/orgs",
"received_events_url": "https://api.github.com/users/JohnVillalovos/received_events",
"repos_url": "https://api.github.com/users/JohnVillalovos/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/JohnVillalovos/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JohnVillalovos/subscriptions",
"type": "User",
"url": "https://api.github.com/users/JohnVillalovos",
"user_view_type": "public"
}
|
[
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
},
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
}
] |
closed
| true | null |
[] | null | 23 |
2015-10-09T16:23:16Z
|
2021-09-08T12:00:59Z
|
2017-02-10T21:50:11Z
|
CONTRIBUTOR
|
resolved
|
It would be good if were able to pass the 'no_proxy' value in the proxies dictionary argument. Currently it appears have to set the environment variable 'no_proxy'.
For example:
```
proxies = {'https_proxy': 'http://proxy.example.com:3128',
'no_proxy': '10.0.0.0/16,example.com,.example.com'}
requests.get('http://www.example.com', proxies=proxies)
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2817/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2817/timeline
| null |
completed
| null | null | false |
[
"This is reasonable request, but the use-case seems small, especially as we now support per-host proxies. The only risk is that you might get redirected off-host, to a host that you don't want to reach via a proxy, but in most cases I'd expect that to be relatively unlikely and covered by the per-host proxies functionality.\n\nIs that incorrect?\n",
"We see this use case when using Ironic bare-metal provisioning in the OpenStack project to provision a system from scratch. So the underlying temporary installation OS isn't really configured with proxies in mind.\n\nI have not heard of 'per-host proxies' before. So unsure if that would work or not.\n",
"The per-host proxies feature is mentioned in our changelog for 2.8.0, but it allows you to set up a proxies dictionary like so:\n\n``` python\nproxies = {'http://my-host.com/': 'http://proxy.example.com:3128'}\n```\n\nThis will only use the proxy for requests to `my-host.com`: other requests will not use the proxy.\n",
"Unfortunately we don't have a good idea which hosts we will be accessing. Thus want the more general method.\n",
"So you don't know what hosts you _will_ access, just which ones you mustn't? It does feel like you should be setting the `NO_PROXY` environment variable, so that other tools obey these rules too.\n",
"Right. So this installation OS is thrown away when done. So doesn't have the variables set. All the work is done by the Ironic Python Agent, which is a Python program.\n\nOur current plan is to just use os.environ['no_proxy'] = '....' but that seems a little hackish but will work. Thus why I filed this RFE.\n\nI'd be happy to try to come up with a pull-request, given a few pointers on what to modify.\n",
"I think we could do it easily enough, but I'm increasingly reluctant to add further features to the already quite complicated proxy logic. In the short term, your solution will work. Longer term, I need to think about where the line is with further proxy features.\n",
"I _think_ this one is probably ok to have. But I'm going to start putting the brakes on proxy features very soon.\n",
"> I think this one is probably ok to have. But I'm going to start putting the brakes on proxy features very soon.\n\nThat said, we are in a feature freeze and have been making exemptions for proxies for a reason I'm still not entirely certain of.\n",
"The main reason I've been exempting proxies is because our proxies support has always been fairly limited, and it would be nice if it were better. I think 'better' is not very far from here, though.\n",
"Thank you very much. Please let me know if I can help out!\n",
"So, we haven't had a chance to make any forward progress on this and I believe we need to push 2.9.0 out soon, so I'm deferring this to the hypothetical 2.10.0 release.\n",
"I thought we had fixed this in 2.11.0 or 2.10.0 but it looks (from a cursory glance) that I'm wrong.\n",
"A proof of concept patch to fix the issue:\n\n https://github.com/JohnVillalovos/requests/commit/ee88bccaeb529f3023ddc0c9b92d4bc455c0a183\n\nNo unit tests though :(\n",
"@JohnVillalovos Generally that patch is fine. It'd better to pass the `no_proxy` entry around directly rather than the entire proxies dictionary, so I'd suggest refactoring to do that.\n\nFeel free to open a PR with that patch and we can make suggestions about testing.\n",
"So I was working on things, doing unit tests and such, and it was looking pretty good until I noticed this:\n\nhttps://github.com/kennethreitz/requests/blob/7c80222afa17e3c02a41eb465f886699dfd56687/requests/utils.py#L589\n\nSo I'm not sure of a good way to handle that call to proxy_bypass().\n\nUgly hack would be to write a context manager to set the 'no_proxy' variable and restore the old one. And use that before calling proxy_bypass. But it just seems ugly to me.\n\nFollowup: Decided to go with hack. Maybe not so ugly.\n",
"@JohnVillalovos We shouldn't even get to there if `no_proxy` has been set by the user. That function has short-circuit returns, so if `no_proxy` was set by the user we should be able to get out of the function well before we ever reach it.\n",
"@Lukasa Do you think that on https://github.com/JohnVillalovos/requests/blob/a3c5b0325f74517707ddda91de38d55071c9c76a/requests/utils.py#L613\n\nIt should maybe just be:\n\n```\nif no_proxy_arg:\n return False\ntry:\n ...\n```\n",
"@JohnVillalovos Arg, further reading suggests that maybe it _is_ necessary. Sorry!\n",
"@Lukasa Arg, I just removed it! heh.\n\nLet me know if I should put it back, or if you think it will work.\n",
"Let's put it back. =) We can discuss alternatives with it there.\n",
"/me is glad he knows about 'git reflog' :)\n",
"Latest version:\nhttps://github.com/JohnVillalovos/requests/commit/a3c5b0325f74517707ddda91de38d55071c9c76a\n"
] |
https://api.github.com/repos/psf/requests/issues/2816
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2816/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2816/comments
|
https://api.github.com/repos/psf/requests/issues/2816/events
|
https://github.com/psf/requests/issues/2816
| 110,673,988 |
MDU6SXNzdWUxMTA2NzM5ODg=
| 2,816 |
Downstream unbundlers should populate setup.py
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[] |
closed
| true |
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
] | null | 21 |
2015-10-09T14:48:30Z
|
2021-09-08T21:00:48Z
|
2015-11-05T10:00:58Z
|
MEMBER
|
resolved
|
/cc @ralphbean @eriol
OpenStack has encountered yet another breakage caused by people combining `pip` installed and system packages: specifically, updating urllib3 via `pip` when requests/urllib3 are already installed via the system packages.
@dstufft tells me that, if the system packages correctly populate the `install_requires` part of `setup.py`, `pip` would respect those requirements. Previously this wasn't possible because requests would include mid-release versions of urllib3, but as of v2.6.2 our [new release rules](http://docs.python-requests.org/en/latest/community/release-process/) mean that we only use proper urllib3 releases.
For this reason, I think it would be extremely good if downstream unbundlers (most notably Fedora and Debian), when they unbundle requests, would populate setup.py with the correct `install_requires`. For 2.8.0, that would be `urllib3==1.12`. For 2.7.0, that would be `urllib3==1.10.4`. This should ensure that `pip` won't casually install a version of urllib3 that will break the system requests package.
Thoughts?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2816/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2816/timeline
| null |
completed
| null | null | false |
[
"I think we can do that. I'll have to think about the implications but this is a great improvement. Right now Debian has requests 2.7.0 and urllib3 1.11 so they should be updated.\n",
"> Right now Debian has requests 2.7.0 and urllib3 1.11 so they should be updated.\n\nI've heard of issues with 2.7.0 and 1.11. I think Fedora pinned to 1.10.4. I'm surprised you haven't had complaints yet.\n",
":smiley: Thanks Barry. For the sake of keeping track of everything, it would be _super_ convenient if you could drop a link to any Debian discussion of that change in this issue. Obviously if you can't then that's not a big deal.\n",
"My plan is to update both soon! I was waiting for the DPMT migration to git. I don't see particular problems but we can always upload on experimental first to see if it's all right.\n",
"On Oct 09, 2015, at 11:09 AM, Daniele Tricoli wrote:\n\n> I was waiting for the DPMT migration to git.\n\nDone!\n\nhttps://wiki.debian.org/Python/GitPackaging\n",
"@warsaw thanks to make this happen! :smile: \nI started reading [email protected] after my reply here!\n@Lukasa if you can point me to the OpenStack issue I will include it into the description of the patch Debian will use.\nThanks!\n",
"> Thoughts?\n\nGood idea. Will report back when its in place.\n",
"@eriol OpenStack issue is [here](https://review.openstack.org/#/c/213310/0).\n",
"Patch to Fedora .spec files:\n- http://pkgs.fedoraproject.org/cgit/python-requests.git/commit/?id=f73b98e44a519ee15f3ceeea4c53e0e4dd25a5d4\n\nFedora updates created:\n- https://bodhi.fedoraproject.org/updates/FEDORA-2015-20de3774f4\n- https://bodhi.fedoraproject.org/updates/FEDORA-2015-1f580ccfa4\n- https://bodhi.fedoraproject.org/updates/FEDORA-2015-d7c710a812\n",
"Thank you @ralphbean and @eriol for working with us on this. :)\n",
":heart: Indeed, thanks so much (and thanks @warsaw and @dstufft as well!).\n",
"On fedora, now it's showing this error on update to this package\nRunning transaction\n Upgrading : python-requests-2.7.0-7.fc22.noarch 1/2 \nError unpacking rpm package python-requests-2.7.0-7.fc22.noarch\nError unpacking rpm package python-requests-2.7.0-7.fc22.noarch\nerror: unpacking of archive failed on file /usr/lib/python2.7/site-packages/requests/packages/chardet: cpio: rename\npython-requests-2.7.0-7.fc22.noarch was supposed to be installed but is not!\n",
"@ralphbean Theories?\n",
"People have been commenting on this bug about this error in fedora\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1236312\n",
"@vvro At this point there is no evidence that requests did anything to introduce this bug: it was almost certainly introduced downstream. It is _possible_ that this issue caused it, but that remains a Fedora problem. I highly recommend centralising the discussion of this problem on the Red Hat bugzilla, rather than here.\n",
"Agreed. 'cpio: rename' issues are almost always a result of having done a 'sudo pip install requests' on the system and introducing ownership conflicts with the rpm management system -- dueling package management systems.\n",
"Sorry for the horrible delay, I had to change my usual workflow after the git migration, but a positive note is that now, after the usual testing, I'm also rebuilding some dependants (I had to speedup my setup to rebuild all of them) of requests.\n\nDebian patch: https://anonscm.debian.org/cgit/python-modules/packages/requests.git/commit/?id=6c882aca203bd33c129e2b4e1e4f82886e4b1fe0\n\nThe package will uploaded soon: unfortunately although now I'm officially a Debian Maintainer my sponsor had problems to give me upload permissions. He tried but he got an error, and we will investigate during these days.\n",
"Uploaded: https://packages.qa.debian.org/r/requests/news/20151028T232257Z.html.\n",
"Alright, that's Debian and Fedora handled. Thanks so much @ralphbean @warsaw @eriol, we :heart: you greatly.\n",
"Thanks @eriol and I'm always happy to help sponsor. One thing we need to keep in mind is that as we update requests' dependencies, we have to make sure to also update requests setup.py. I don't think we have any mechanisms in Debian to ensure this but we can probably rely on Ubuntu's -proposed migration to keep track of mismatches: http://people.canonical.com/~ubuntu-archive/proposed-migration/update_excuses.html\n\nThe other thing we may want to think about is DEP-8 tests to make these verifications. Then at least we'll see problems on qa.debian.org. A README.Debian is a good idea too, but they are easy to miss :(\n",
"@warsaw it's a pleasure work with you! Also reading your hints! I had the same thought on README.Debian, but I will add it in the next upload.\n\nUbuntu's -proposed migration is very interesting! I will keep an eye on it for my packages.\n\nAfter the git migration I updated my workflow and I discovered some useful tools.\nBefore the last requests' upload I tried to use [ratt](https://github.com/Debian/ratt) on my laptop to rebuild all the reverse dependencies: it was a bit troublesome since one of the rdeps is blender and it take more than 1 hour to build, so I did not rebuild all of them but only some.\nTo \"fix\" my building problems I was suggested to use debomatic: https://debomatic.github.io/ :smile: I'm reading the documentation right now.\nThe only problem is that it's not automated, but I will start to use it for all my packages before uploading them on the archive.\n\nWhat about a more draconian approach in addiction to DEP-8 test? I'm thinking about testing at build time and let the package fail to build if the setup.py was not correctly updated.\n\nDo you have any hints about safely parse a setup.py? Thanks!\n"
] |
https://api.github.com/repos/psf/requests/issues/2815
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2815/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2815/comments
|
https://api.github.com/repos/psf/requests/issues/2815/events
|
https://github.com/psf/requests/issues/2815
| 110,671,499 |
MDU6SXNzdWUxMTA2NzE0OTk=
| 2,815 |
Python 3.5 install requests failed
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3759816?v=4",
"events_url": "https://api.github.com/users/gengjiawen/events{/privacy}",
"followers_url": "https://api.github.com/users/gengjiawen/followers",
"following_url": "https://api.github.com/users/gengjiawen/following{/other_user}",
"gists_url": "https://api.github.com/users/gengjiawen/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gengjiawen",
"id": 3759816,
"login": "gengjiawen",
"node_id": "MDQ6VXNlcjM3NTk4MTY=",
"organizations_url": "https://api.github.com/users/gengjiawen/orgs",
"received_events_url": "https://api.github.com/users/gengjiawen/received_events",
"repos_url": "https://api.github.com/users/gengjiawen/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gengjiawen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gengjiawen/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gengjiawen",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-10-09T14:34:25Z
|
2021-09-08T22:00:43Z
|
2015-10-09T14:41:38Z
|
NONE
|
resolved
|
```
C:\Users\gengjiawen>pip install --no-cache requests
Collecting requests
Downloading requests-2.8.0-py2.py3-none-any.whl (476kB)
100% |████████████████████████████████| 479kB 122kB/s
Installing collected packages: requests
Exception:
Traceback (most recent call last):
File "c:\program files\python\lib\site-packages\pip\basecommand.py", line 211, in main
status = self.run(options, args)
File "c:\program files\python\lib\site-packages\pip\commands\install.py", line 311, in run
root=options.root_path,
File "c:\program files\python\lib\site-packages\pip\req\req_set.py", line 646, in install
**kwargs
File "c:\program files\python\lib\site-packages\pip\req\req_install.py", line 803, in install
self.move_wheel_files(self.source_dir, root=root)
File "c:\program files\python\lib\site-packages\pip\req\req_install.py", line 998, in move_wheel_files
isolated=self.isolated,
File "c:\program files\python\lib\site-packages\pip\wheel.py", line 339, in move_wheel_files
clobber(source, lib_dir, True)
File "c:\program files\python\lib\site-packages\pip\wheel.py", line 310, in clobber
ensure_dir(destdir)
File "c:\program files\python\lib\site-packages\pip\utils\__init__.py", line 71, in ensure_dir
os.makedirs(path)
File "c:\program files\python\lib\os.py", line 241, in makedirs
mkdir(name, mode)
PermissionError: [WinError 5] Access is denied: 'c:\\program files\\python\\Lib\\site-packages\\requests'
```
I am on win10(64bit), python 3.5.0.
Python 3.4 has not this problem.
Run the terminal as Admin will fix this.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3759816?v=4",
"events_url": "https://api.github.com/users/gengjiawen/events{/privacy}",
"followers_url": "https://api.github.com/users/gengjiawen/followers",
"following_url": "https://api.github.com/users/gengjiawen/following{/other_user}",
"gists_url": "https://api.github.com/users/gengjiawen/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gengjiawen",
"id": 3759816,
"login": "gengjiawen",
"node_id": "MDQ6VXNlcjM3NTk4MTY=",
"organizations_url": "https://api.github.com/users/gengjiawen/orgs",
"received_events_url": "https://api.github.com/users/gengjiawen/received_events",
"repos_url": "https://api.github.com/users/gengjiawen/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gengjiawen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gengjiawen/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gengjiawen",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2815/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2815/timeline
| null |
completed
| null | null | false |
[
"I believe this is a problem with your installation, not with requests. Do you encounter this problem with other packages? E.g., try running `pip install --no-cache hyperframe`.\n",
"@Lukasa yes, you are right,this is may be a issue of python 3.5,I will close this issue:)\n"
] |
https://api.github.com/repos/psf/requests/issues/2814
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2814/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2814/comments
|
https://api.github.com/repos/psf/requests/issues/2814/events
|
https://github.com/psf/requests/pull/2814
| 110,456,412 |
MDExOlB1bGxSZXF1ZXN0NDcxNTUxNzU=
| 2,814 |
Use general null check for JSON
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2015-10-08T13:54:23Z
|
2021-09-08T06:00:54Z
|
2015-10-08T15:13:08Z
|
MEMBER
|
resolved
|
Resolves #2813.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2814/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2814/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2814.diff",
"html_url": "https://github.com/psf/requests/pull/2814",
"merged_at": "2015-10-08T15:13:08Z",
"patch_url": "https://github.com/psf/requests/pull/2814.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2814"
}
| true |
[
"I think we're going to start needing some tests that our set of data-y parameters interact correctly together when using different parts of the API.\n",
"Or we need to stop duplicating logic everywhere that will break logic in different places.\n",
"Or both?\n",
"Yes. I commented in the wrong place. I greatly dislike the reliance on False-y values for tests. That should have been on #2813 \n"
] |
https://api.github.com/repos/psf/requests/issues/2813
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2813/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2813/comments
|
https://api.github.com/repos/psf/requests/issues/2813/events
|
https://github.com/psf/requests/issues/2813
| 110,454,512 |
MDU6SXNzdWUxMTA0NTQ1MTI=
| 2,813 |
Requests json argument is ignored in 2.8.0
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/422264?v=4",
"events_url": "https://api.github.com/users/vasiliy-bout/events{/privacy}",
"followers_url": "https://api.github.com/users/vasiliy-bout/followers",
"following_url": "https://api.github.com/users/vasiliy-bout/following{/other_user}",
"gists_url": "https://api.github.com/users/vasiliy-bout/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/vasiliy-bout",
"id": 422264,
"login": "vasiliy-bout",
"node_id": "MDQ6VXNlcjQyMjI2NA==",
"organizations_url": "https://api.github.com/users/vasiliy-bout/orgs",
"received_events_url": "https://api.github.com/users/vasiliy-bout/received_events",
"repos_url": "https://api.github.com/users/vasiliy-bout/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/vasiliy-bout/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vasiliy-bout/subscriptions",
"type": "User",
"url": "https://api.github.com/users/vasiliy-bout",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-10-08T13:45:16Z
|
2021-09-08T22:00:44Z
|
2015-10-08T15:13:08Z
|
NONE
|
resolved
|
In version `2.7.0` I was using `Requests` constructor with `json` parameter specified, like:
```
json_data = [ ... ];
r = requests.Request('POST', url, json=json_data)
```
And in the `2.8.0` version this code does not work, because I do not specify `data` parameter. Inside constructor we get `self.data` assigned as `[] if data is None else data`, so we finally get `self.data` equal to `[]`.
And because of this commit: 7a0cd16c1a5be16f3df395ee12ed11d0ddde7837 we get `json` parameter ignored, because now we have to explicitly specify `data={}` when calling constructor, like:
```
json_data = [ ... ];
r = requests.Request('POST', url, json=json_data, data={})
```
I think that this issue definitely breaks documented API.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2813/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2813/timeline
| null |
completed
| null | null | false |
[
"Ah, yeah, that definitely happened. Sorry. =(\n\nThis was introduced in #2763. Looks like we need a slightly more subtle check than the one we introduced.\n",
"See #2814 for a proposed fix.\n"
] |
https://api.github.com/repos/psf/requests/issues/2812
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2812/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2812/comments
|
https://api.github.com/repos/psf/requests/issues/2812/events
|
https://github.com/psf/requests/pull/2812
| 110,446,257 |
MDExOlB1bGxSZXF1ZXN0NDcxNDk4MTA=
| 2,812 |
Don't treat NewConnectionErrors as timeouts.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2015-10-08T13:06:53Z
|
2021-09-01T00:11:45Z
|
2015-10-08T13:10:01Z
|
MEMBER
|
resolved
|
Resolves #2811.
Fundamentally I view this mostly as a compatibility change, to get us back into line with how we've processed this kind of error in the 2.X series. I think I'd like to back it out in 3.0.0, which is why I've left a note in the code to that effect.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2812/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2812/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2812.diff",
"html_url": "https://github.com/psf/requests/pull/2812",
"merged_at": "2015-10-08T13:10:01Z",
"patch_url": "https://github.com/psf/requests/pull/2812.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2812"
}
| true |
[
"@sigmavirus24 How do you feel about removing this in 3.0.0?\n",
"+0\n",
"@Lukasa I've found a TODO made by you and associated with this issue https://github.com/requests/requests/blob/3.0/requests/adapters.py#L531"
] |
https://api.github.com/repos/psf/requests/issues/2811
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2811/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2811/comments
|
https://api.github.com/repos/psf/requests/issues/2811/events
|
https://github.com/psf/requests/issues/2811
| 110,441,115 |
MDU6SXNzdWUxMTA0NDExMTU=
| 2,811 |
2.8.0 release raise ConnectTimeout on not known url
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/9213840?v=4",
"events_url": "https://api.github.com/users/aarefiev22/events{/privacy}",
"followers_url": "https://api.github.com/users/aarefiev22/followers",
"following_url": "https://api.github.com/users/aarefiev22/following{/other_user}",
"gists_url": "https://api.github.com/users/aarefiev22/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/aarefiev22",
"id": 9213840,
"login": "aarefiev22",
"node_id": "MDQ6VXNlcjkyMTM4NDA=",
"organizations_url": "https://api.github.com/users/aarefiev22/orgs",
"received_events_url": "https://api.github.com/users/aarefiev22/received_events",
"repos_url": "https://api.github.com/users/aarefiev22/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/aarefiev22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aarefiev22/subscriptions",
"type": "User",
"url": "https://api.github.com/users/aarefiev22",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 11 |
2015-10-08T12:47:34Z
|
2021-09-08T22:00:43Z
|
2015-10-08T13:10:01Z
|
NONE
|
resolved
|
2.7.0 and 2.8.0 raises diff exception on not known url:
import requests
requests.get('http://fake')
2.8.0:
requests.exceptions.ConnectTimeout: HTTPConnectionPool(host='fake', port=80): Max retries exceeded with url: / (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x7fac9c476110>: Failed to establish a new connection: [Errno -2] Name or service not known',))
2.7.0
requests.exceptions.ConnectionError: ('Connection aborted.', gaierror(-2, 'Name or service not known'))
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2811/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2811/timeline
| null |
completed
| null | null | false |
[
"Hmm, looks like urllib3 changed how it wrapped this exception. Let me see if I can find where this problem got introduced.\n",
"I suspect shazow/urllib3#703 may have introduced a new exception type that urllib3 treats differently to `socket.error`.\n",
"@Lukasa if the OpenStack gate is indicative of anything, it's between 1.10.4 and 1.11\n",
"Looks to me like it was actually done in 1.12: `NewConnectionError` is a subclass of `ConnectTimeoutError`, whereas previously `socket.error` wouldn't have been.\n",
"@Lukasa : yes looks like new NewConnectionError raised here: https://github.com/kennethreitz/requests/blob/master/requests/packages/urllib3/connection.py#L142\n",
"Hmm, that's not right though: `socket.error` should have entered the retry block.\n",
"Regardless, the reason we think it's a `ConnectTimeout` is because the new exception is a child of `ConnectTimeoutError`. This is somewhat tricky to deal with: `NewConnectionError` is _sometimes_ a timeout, but sometimes not. \n",
"I think from requests' perspective we just want to treat `NewConnectionError` as _not_ a timeout, even though under the hood urllib3 will attempt to retry when it hits it.\n",
"Also cc'ing @shazow \n",
"Ok, a proposed bugfix is in #2812. There's some discussion in there about whether this fixes a permanent bug, or whether it's strictly a compatibility fix.\n",
"I suspect some of this might be platform/configuration-specific. I can't remember the exact details but I think there was a distinction between how OSX vs Linux (maybe Posix vs GNU?) systems behave when you make a new socket to a bad host. It might also have to do with the DNS settings. I vaguely remember in one case it would try to resolve it and hang around until timeout, in the other case it would quickly eliminate it as not resolvable and return a lower-level error.\n\nI tried to normalize them under the same exception but not sure if I succeeded.\n"
] |
https://api.github.com/repos/psf/requests/issues/2810
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2810/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2810/comments
|
https://api.github.com/repos/psf/requests/issues/2810/events
|
https://github.com/psf/requests/pull/2810
| 110,386,904 |
MDExOlB1bGxSZXF1ZXN0NDcxMTg1MDU=
| 2,810 |
Update requests certificate bundle.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2015-10-08T07:12:37Z
|
2021-09-08T06:00:53Z
|
2015-10-08T16:12:09Z
|
MEMBER
|
resolved
|
This brings it up-to-date with the certifi 2015.9.6.2 release, specifically the `weak.pem` bundle that still contains the 1024-bit root certificates. This is really as aggressive as I'm happy to be with requests at this time.
Resolves #2809.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2810/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2810/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2810.diff",
"html_url": "https://github.com/psf/requests/pull/2810",
"merged_at": "2015-10-08T16:12:09Z",
"patch_url": "https://github.com/psf/requests/pull/2810.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2810"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/2809
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2809/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2809/comments
|
https://api.github.com/repos/psf/requests/issues/2809/events
|
https://github.com/psf/requests/issues/2809
| 110,323,983 |
MDU6SXNzdWUxMTAzMjM5ODM=
| 2,809 |
Cert present in certifi but not in requests
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/2438391?v=4",
"events_url": "https://api.github.com/users/hombremuchacho/events{/privacy}",
"followers_url": "https://api.github.com/users/hombremuchacho/followers",
"following_url": "https://api.github.com/users/hombremuchacho/following{/other_user}",
"gists_url": "https://api.github.com/users/hombremuchacho/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hombremuchacho",
"id": 2438391,
"login": "hombremuchacho",
"node_id": "MDQ6VXNlcjI0MzgzOTE=",
"organizations_url": "https://api.github.com/users/hombremuchacho/orgs",
"received_events_url": "https://api.github.com/users/hombremuchacho/received_events",
"repos_url": "https://api.github.com/users/hombremuchacho/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hombremuchacho/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hombremuchacho/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hombremuchacho",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2015-10-07T21:40:16Z
|
2021-09-08T22:00:43Z
|
2015-10-08T16:12:09Z
|
NONE
|
resolved
|
https://github.com/certifi/python-certifi/blob/master/certifi/cacert.pem#L5026
Can the Entrust G2 certificate be added to the requests certificate store?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2809/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2809/timeline
| null |
completed
| null | null | false |
[
"I think the core issue here is that requests' certificate store is somewhat out of date. I propose we ship a 2.8.1 containing a cert store update, specifically the `weak.pem` bundle that ships with certifi.\n\n@hombremuchacho Someone I presume was your colleague or another team member (@aehlke) suggested that certifi was missing a certificate you needed, so you couldn't use it as a drop-in replacement. Did you try using `certifi.old_where()`?\n",
"(To be clear, the bundle pointed at by `certifi.old_where()` is exactly the same as the bundle I'm proposing in #2810, so if that works for you I'll know it's a good choice to move forward with.)\n",
"@Lukasa Thanks, I'll test this now.\n"
] |
https://api.github.com/repos/psf/requests/issues/2808
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2808/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2808/comments
|
https://api.github.com/repos/psf/requests/issues/2808/events
|
https://github.com/psf/requests/pull/2808
| 110,316,211 |
MDExOlB1bGxSZXF1ZXN0NDcwODE3OTM=
| 2,808 |
Adding Entrust G2 CA Cert
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/2438391?v=4",
"events_url": "https://api.github.com/users/hombremuchacho/events{/privacy}",
"followers_url": "https://api.github.com/users/hombremuchacho/followers",
"following_url": "https://api.github.com/users/hombremuchacho/following{/other_user}",
"gists_url": "https://api.github.com/users/hombremuchacho/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hombremuchacho",
"id": 2438391,
"login": "hombremuchacho",
"node_id": "MDQ6VXNlcjI0MzgzOTE=",
"organizations_url": "https://api.github.com/users/hombremuchacho/orgs",
"received_events_url": "https://api.github.com/users/hombremuchacho/received_events",
"repos_url": "https://api.github.com/users/hombremuchacho/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hombremuchacho/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hombremuchacho/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hombremuchacho",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2015-10-07T21:03:37Z
|
2021-09-08T06:00:54Z
|
2015-10-07T21:16:00Z
|
NONE
|
resolved
|
Adding Entrust G2 CA Cert to cacerts.pem
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2808/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2808/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2808.diff",
"html_url": "https://github.com/psf/requests/pull/2808",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2808.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2808"
}
| true |
[
"I could be mistaken but I'm rather certain that we don't accept additions to the certificate bundle directly. They have to go through [certifi](/certifi/python-certifi) first. @Lukasa am I right?\n",
"We do not accept changes to the cert bundle in requests in this manner: certainly not one certificate at a time. \n\nWould you like to open an issue that discusses the actual problem you have encountered?\n",
"@Lukasa @sigmavirus24 Thanks for clarifying how this works. I'll open an issue. We use the requests library as part of our project and are missing a certain certificate -- this certificate is present in certifi; however, it hasn't been added to requests. https://github.com/certifi/python-certifi/blob/master/certifi/cacert.pem#L5026\n",
"To clarify, Certifi was not a drop-in solution for us as it was missing at least one cert that's bundled with Requests.\n"
] |
https://api.github.com/repos/psf/requests/issues/2807
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2807/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2807/comments
|
https://api.github.com/repos/psf/requests/issues/2807/events
|
https://github.com/psf/requests/issues/2807
| 110,258,668 |
MDU6SXNzdWUxMTAyNTg2Njg=
| 2,807 |
HTTP Proxy with prepared request (honouring env. var.)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/2509872?v=4",
"events_url": "https://api.github.com/users/mxjeff/events{/privacy}",
"followers_url": "https://api.github.com/users/mxjeff/followers",
"following_url": "https://api.github.com/users/mxjeff/following{/other_user}",
"gists_url": "https://api.github.com/users/mxjeff/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mxjeff",
"id": 2509872,
"login": "mxjeff",
"node_id": "MDQ6VXNlcjI1MDk4NzI=",
"organizations_url": "https://api.github.com/users/mxjeff/orgs",
"received_events_url": "https://api.github.com/users/mxjeff/received_events",
"repos_url": "https://api.github.com/users/mxjeff/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mxjeff/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mxjeff/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mxjeff",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 6 |
2015-10-07T15:58:44Z
|
2021-09-08T21:00:51Z
|
2015-11-05T10:01:18Z
|
NONE
|
resolved
|
Running the following it looks like the proxy env. var. is not honoured:
``` python
>>> # requests version 2.2.1 / python 3.4.0
>>> import requests
>>> import os
>>> os.environ['HTTP_PROXY'] = 'http://some.wrong.dns.example.org'
>>> req = requests.Request('GET', 'http://httpbin.org/get')
>>> r = req.prepare()
>>> s = requests.Session()
>>> s.send(r)
<Response [200]>
```
Is it the expected behaviour with the lower level interface ?
I was actually expecting request to transparently use HTTP_PROXY as it does with the main interface requests.get() or requests.request('GET',...).
Cheers
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2807/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2807/timeline
| null |
completed
| null | null | false |
[
"It's certainly the _coded_ behaviour: if you don't use something that goes through `Session.request` then you never get the environment variables.\n\nHowever, I think this is unexpected. It doesn't seem like there's any reason we couldn't move the call to `Session.merge_environment` into `Session.send`, so I'm inclined to say we should do that. Unfortunately, it's a bit backward-incompatible IMO, so I'd want to sit on this until 2.9.0 or, more likely, 3.0.0. Thoughts @sigmavirus24?\n",
"OTOH such isolation from the environment could be desirable and the reason someone uses prepared requests in the first place.\n",
"So we explicitly made [`merge_environment_settings`](https://github.com/kennethreitz/requests/blob/e499b354c4215b158db6d4210136e0b9adbe8d14/requests/sessions.py#L615) a public method which could be used by people taking advantage of the PreparedRequest flow. Perhaps we never quite documented it very well when we added it, but I'm not really for moving most of the logic into send because then someone's going to want something that does far less than send does and we will be wanting to move things back into `Session.request`. I think the existing behaviour is fine. We probably just need to document `merge_environment_settings` as a _potential_ part of the Prepared Request flow.\n",
"Sounds reasonable to me.\n",
"Alright, thanks for the clarification.\n\nThen how should I use merge_environment_setting in order to merge only HTTP proxies var ?\n\nIs this correct ?\n\n``` python\n>>> import requests\n>>> import os\n>>> os.environ['HTTP_PROXY'] = 'http://some.wrong.dns.example.org'\n>>> req = requests.Request('GET', 'http://httpbin.org/get')\n>>> r = req.prepare()\n>>> s = requests.Session()\n>>> settings = s.merge_environment_settings(req.url, {}, None, False, None)\n>>> s.send(r, **settings)\n# => should raise a gaierror because of wrong proxy in os.environ\n```\n\n@sigmavirus24 : I agree, the existing behavior is fine, It just lacks some precision in the documentation though.\n",
"@mxjeff right, that's why I said we probably need to document it better.\n\nAlso your code sample is correct.\n"
] |
https://api.github.com/repos/psf/requests/issues/2806
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2806/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2806/comments
|
https://api.github.com/repos/psf/requests/issues/2806/events
|
https://github.com/psf/requests/issues/2806
| 110,161,530 |
MDU6SXNzdWUxMTAxNjE1MzA=
| 2,806 |
read timeouts and iter_lines
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/521953?v=4",
"events_url": "https://api.github.com/users/jkarneges/events{/privacy}",
"followers_url": "https://api.github.com/users/jkarneges/followers",
"following_url": "https://api.github.com/users/jkarneges/following{/other_user}",
"gists_url": "https://api.github.com/users/jkarneges/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jkarneges",
"id": 521953,
"login": "jkarneges",
"node_id": "MDQ6VXNlcjUyMTk1Mw==",
"organizations_url": "https://api.github.com/users/jkarneges/orgs",
"received_events_url": "https://api.github.com/users/jkarneges/received_events",
"repos_url": "https://api.github.com/users/jkarneges/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jkarneges/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jkarneges/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jkarneges",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 5 |
2015-10-07T06:42:12Z
|
2021-09-08T21:00:50Z
|
2015-11-05T10:01:39Z
|
NONE
|
resolved
|
I want to be able to consume an HTTP stream of indefinite length, but I also want a way to cleanly exit the read loop that doesn't involve killing the thread. Here's what I've got:
``` python
import threading
import socket
import requests
resp = requests.get('http://some-url/', stream=True, timeout=5)
quit = False
quit_lock = threading.Lock()
it = resp.iter_lines(chunk_size=1)
while True:
quit_lock.acquire()
if quit:
quit_lock.release()
break
quit_lock.release()
try:
line = next(it)
except StopIteration:
break
except socket.timeout:
print('read timed out')
it = resp.iter_lines(chunk_size=1)
continue
print(line)
```
The idea here is that a separate thread can set `quit = True` and this read loop will exit within some seconds. The approach works fine on Python 2 but fails on Python 3. On Python 3, once a read has timed out, a subsequent read will fail with the exception:
```
OSError: cannot read from timed out object
```
Is this a bug in the requests library? Or is it simply a limitation of Python 3? Or is there some other workaround?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2806/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2806/timeline
| null |
completed
| null | null | false |
[
"This seems to be a limitation of Python 3, introduced in [Issue #7322](https://bugs.python.org/issue7322). The core problem here is that the `read` and `readline` methods of Python socket objects use internal buffers, in order to satisfy the read contract that says that reads should only return less than `amt` if the data stream is closed (see also shazow/urllib3#709). These internal buffers can get screwed up if the timeout is thrown during a later `recv` call.\n\nNow, we don't actually _use_ those methods directly, but `http.client` does, and also provides some internal buffers of its own. Those buffers are also at risk of being screwed up.\n\nFinally, `iter_lines` _also_ uses buffers internally, which are _also_ lost when this exception fires. This doesn't matter for you in the \"everything is working fine\" case, because you only expect the exception to fire once a newline has been received (so the internal buffer is empty), but if anything went wrong it would fire _mid-line_ and you'd lose the whole line.\n\nThere are two ways that leap out at me to make this work, only the first of which uses the majority of your code. The first is a bit gross, because it involves reaching _way_ into requests and urllib3, but it should be fairly stable (the objects you're touching aren't moving around a lot). This involves using `select` and timeouts instead. You could write this:\n\n``` python\nimport threading\nimport select\nimport socket\nimport requests\n\nresp = requests.get('http://some-url/', stream=True, timeout=60)\n\nquit = False\nquit_lock = threading.Lock()\nit = resp.iter_lines(chunk_size=1)\nwhile True:\n quit_lock.acquire()\n if quit:\n quit_lock.release()\n break\n quit_lock.release()\n\n try:\n if not select.select([resp.raw._fp.fp], [], [], 5)[0]:\n continue\n except TypeError:\n # Raised if the connection is completed\n break\n\n try:\n line = next(it)\n except StopIteration:\n break\n\n print(line)\n```\n\nThe second approach is to use a proper concurrency framework for this job. Obviously, that's a bit out of scope for this repo so I won't go into it more, though I'm happy to point out some frameworks that would help if that would be useful (e.g. asyncio, Twisted).\n",
"Ah yes, I wondered if I could use `select` somehow. Thanks for the tip. Would this also work for HTTPS connections or would there be a different fd to check?\n",
"It should be the same fd.\n",
"So this approach almost works. On the first iteration, the `select` is not considering the fd readable even though there is data to read. I think what is happening is any initial data is being buffered inside the response object (or some other layer) and so has already been read by the time we poll the socket. Once new data arrives on the socket, it becomes readable, and the client reads the initial data.\n\nIs there a way to test if there is buffered data to try to read?\n",
"> Is there a way to test if there is buffered data to try to read?\n\nOof, harder. I don't immediately see anything here. I can't even see where the buffer is: it's not in `socket` or `io` AFAICT, so I'd have to guess it was in `http.client`, but I can't see it in there either. Someone, somewhere, has buffered your data above the socket level, but I don't know who did it.\n"
] |
https://api.github.com/repos/psf/requests/issues/2805
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2805/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2805/comments
|
https://api.github.com/repos/psf/requests/issues/2805/events
|
https://github.com/psf/requests/pull/2805
| 109,834,518 |
MDExOlB1bGxSZXF1ZXN0NDY4MDE1NDU=
| 2,805 |
allows user paths for ca_cert verify path
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1832772?v=4",
"events_url": "https://api.github.com/users/a-tal/events{/privacy}",
"followers_url": "https://api.github.com/users/a-tal/followers",
"following_url": "https://api.github.com/users/a-tal/following{/other_user}",
"gists_url": "https://api.github.com/users/a-tal/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/a-tal",
"id": 1832772,
"login": "a-tal",
"node_id": "MDQ6VXNlcjE4MzI3NzI=",
"organizations_url": "https://api.github.com/users/a-tal/orgs",
"received_events_url": "https://api.github.com/users/a-tal/received_events",
"repos_url": "https://api.github.com/users/a-tal/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/a-tal/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/a-tal/subscriptions",
"type": "User",
"url": "https://api.github.com/users/a-tal",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-10-05T16:17:32Z
|
2021-09-08T06:00:55Z
|
2015-10-05T16:18:36Z
|
NONE
|
resolved
|
currently you get the following error:
`SSLError("bad ca_certs: '~/example.crt'", Error([('system library', 'fopen', 'No such file or directory'), ('BIO routines', 'BIO_new_file', 'no such file'), ('x509 certificate routines', 'X509_load_cert_crl_file', 'system lib')],))`
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2805/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2805/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2805.diff",
"html_url": "https://github.com/psf/requests/pull/2805",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2805.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2805"
}
| true |
[
"Thanks for this! However, this is a change in the [urllib3](https://github.com/shazow/urllib3) library, which we vendor in. Can you please open this pull request over there? Thanks!\n"
] |
https://api.github.com/repos/psf/requests/issues/2804
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2804/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2804/comments
|
https://api.github.com/repos/psf/requests/issues/2804/events
|
https://github.com/psf/requests/pull/2804
| 109,810,663 |
MDExOlB1bGxSZXF1ZXN0NDY3ODg3NDY=
| 2,804 |
Final 2.8.0
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-10-05T14:39:54Z
|
2021-09-08T06:00:55Z
|
2015-10-05T16:21:40Z
|
MEMBER
|
resolved
|
This contains the final remaining chunks of work for 2.8.0: updated changelog and updated urllib3. When we merge this we'll be in code-freeze until we release.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2804/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2804/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2804.diff",
"html_url": "https://github.com/psf/requests/pull/2804",
"merged_at": "2015-10-05T16:21:40Z",
"patch_url": "https://github.com/psf/requests/pull/2804.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2804"
}
| true |
[
"@sigmavirus24 Happy for you to merge this when you think things look good.\n",
"LGTM. :+1: :fireworks: \n"
] |
https://api.github.com/repos/psf/requests/issues/2803
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2803/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2803/comments
|
https://api.github.com/repos/psf/requests/issues/2803/events
|
https://github.com/psf/requests/pull/2803
| 109,806,355 |
MDExOlB1bGxSZXF1ZXN0NDY3ODYxODc=
| 2,803 |
Update default user-agent (#2785)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3287067?v=4",
"events_url": "https://api.github.com/users/asieira/events{/privacy}",
"followers_url": "https://api.github.com/users/asieira/followers",
"following_url": "https://api.github.com/users/asieira/following{/other_user}",
"gists_url": "https://api.github.com/users/asieira/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/asieira",
"id": 3287067,
"login": "asieira",
"node_id": "MDQ6VXNlcjMyODcwNjc=",
"organizations_url": "https://api.github.com/users/asieira/orgs",
"received_events_url": "https://api.github.com/users/asieira/received_events",
"repos_url": "https://api.github.com/users/asieira/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/asieira/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/asieira/subscriptions",
"type": "User",
"url": "https://api.github.com/users/asieira",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 8 |
2015-10-05T14:19:17Z
|
2021-09-08T06:00:56Z
|
2015-10-05T14:54:17Z
|
CONTRIBUTOR
|
resolved
|
- Updated default user agent so that it includes only the requests
version;
- Added PyCharm / IDEA project directory to `.gitignore`.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2803/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2803/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2803.diff",
"html_url": "https://github.com/psf/requests/pull/2803",
"merged_at": "2015-10-05T14:54:17Z",
"patch_url": "https://github.com/psf/requests/pull/2803.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2803"
}
| true |
[
"If we can clean this up relatively swiftly it'll make it into 2.8.0: otherwise, it'll fall out until 2.8.1.\n",
"I wouldn't be comfortable including this in 2.8.1. 2.9.0 definitely, but not 2.8.1\n",
"@asieira No, I think I recommend adding it to your local `.git/info/exclude` file. Text-editor specific config really shouldn't go into the project repository, the world just gets really complex really fast that way.\n",
"Ok, will do that. \n",
"LGTM. @sigmavirus24?\n",
"@Lukasa will you handle the release notes for this or should I do it later tonight?\n",
"@sigmavirus24 I'll do it.\n\n@asieira Thanks so much for this change! :sparkles: :cake: :sparkles:\n",
":bow: my pleasure, thank you all again for the awesome package. :)\n"
] |
https://api.github.com/repos/psf/requests/issues/2802
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2802/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2802/comments
|
https://api.github.com/repos/psf/requests/issues/2802/events
|
https://github.com/psf/requests/issues/2802
| 109,652,530 |
MDU6SXNzdWUxMDk2NTI1MzA=
| 2,802 |
IP Address of target host in Response
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/10950287?v=4",
"events_url": "https://api.github.com/users/sezginriggs/events{/privacy}",
"followers_url": "https://api.github.com/users/sezginriggs/followers",
"following_url": "https://api.github.com/users/sezginriggs/following{/other_user}",
"gists_url": "https://api.github.com/users/sezginriggs/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sezginriggs",
"id": 10950287,
"login": "sezginriggs",
"node_id": "MDQ6VXNlcjEwOTUwMjg3",
"organizations_url": "https://api.github.com/users/sezginriggs/orgs",
"received_events_url": "https://api.github.com/users/sezginriggs/received_events",
"repos_url": "https://api.github.com/users/sezginriggs/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sezginriggs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sezginriggs/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sezginriggs",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-10-04T00:03:53Z
|
2021-09-08T20:00:46Z
|
2015-10-04T00:14:59Z
|
NONE
|
resolved
|
Hello,
Is there any way to get IP address of target host of a request? Looks like it's possible to get it from urllib3's HTTPResponse object with <Object>._fp.fp._sock.getpeername() but I couldn't find how to get it working with requests.
Is there any easy way or work around for it? Or can you please add it to feature requests and to Response object as an attribute? It would be good to use it like
r = requests.get("http://blabla.com")
print r.ip_addr
Best Regards,
Sezgin
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2802/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2802/timeline
| null |
completed
| null | null | false |
[
"Hi @sezginriggs thanks for taking the time to open this. We've discussed this previously on https://github.com/kennethreitz/requests/issues/2158 and decided against this. We're currently in a feature freeze (and will be for the rest of the project's life time in all likelihood) so we're not adding new features.\n\nIn the future, please search all issues using GitHub before opening new feature requests.\n\nCheers,\nIan\n",
"@sezginriggs use `stream=True`, grab the IP before you read the response body.\n\nMore here https://github.com/kennethreitz/requests/issues/2158\n"
] |
https://api.github.com/repos/psf/requests/issues/2801
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2801/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2801/comments
|
https://api.github.com/repos/psf/requests/issues/2801/events
|
https://github.com/psf/requests/issues/2801
| 109,603,572 |
MDU6SXNzdWUxMDk2MDM1NzI=
| 2,801 |
async and await
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/149248?v=4",
"events_url": "https://api.github.com/users/screendriver/events{/privacy}",
"followers_url": "https://api.github.com/users/screendriver/followers",
"following_url": "https://api.github.com/users/screendriver/following{/other_user}",
"gists_url": "https://api.github.com/users/screendriver/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/screendriver",
"id": 149248,
"login": "screendriver",
"node_id": "MDQ6VXNlcjE0OTI0OA==",
"organizations_url": "https://api.github.com/users/screendriver/orgs",
"received_events_url": "https://api.github.com/users/screendriver/received_events",
"repos_url": "https://api.github.com/users/screendriver/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/screendriver/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/screendriver/subscriptions",
"type": "User",
"url": "https://api.github.com/users/screendriver",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-10-03T05:44:51Z
|
2021-09-08T22:00:46Z
|
2015-10-03T07:30:28Z
|
NONE
|
resolved
|
Python 3.5 [introduced](https://docs.python.org/3/whatsnew/3.5.html#new-features) coroutines with async and await syntax. Specification about that can be read in [PEP 492](https://www.python.org/dev/peps/pep-0492/).
Are there any plans to support this? Because of network lags or slow connections it would make sense to make asynchronous http requests.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 29,
"-1": 1,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 30,
"url": "https://api.github.com/repos/psf/requests/issues/2801/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2801/timeline
| null |
completed
| null | null | false |
[
"@screendriver At the current time there are no plans to support async and await. This is not because they aren't a good idea: they are. It's because to use them requires quite substantial code changes.\n\nRight now requests is a purely synchronous library that, at the bottom of its stack, uses `httplib` to send and receive data. We cannot move to an async model unless we replace httplib. The best we could do is provide a shorthand to run a request in a thread, but asyncio already has just such a shorthand, so I don't believe it would be valuable.\n\nRight now I am quietly looking at whether we can rewrite requests to work just as well in a synchronous environment as in an async one. However, the reality is that doing so will be a lot of work, involving rewriting a lot of our stack, and may not happen for many years, if ever.\n"
] |
https://api.github.com/repos/psf/requests/issues/2800
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2800/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2800/comments
|
https://api.github.com/repos/psf/requests/issues/2800/events
|
https://github.com/psf/requests/pull/2800
| 109,586,702 |
MDExOlB1bGxSZXF1ZXN0NDY2OTEyNzE=
| 2,800 |
Update Quickstart documentation of Response.json()
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/330633?v=4",
"events_url": "https://api.github.com/users/hosamaly/events{/privacy}",
"followers_url": "https://api.github.com/users/hosamaly/followers",
"following_url": "https://api.github.com/users/hosamaly/following{/other_user}",
"gists_url": "https://api.github.com/users/hosamaly/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hosamaly",
"id": 330633,
"login": "hosamaly",
"node_id": "MDQ6VXNlcjMzMDYzMw==",
"organizations_url": "https://api.github.com/users/hosamaly/orgs",
"received_events_url": "https://api.github.com/users/hosamaly/received_events",
"repos_url": "https://api.github.com/users/hosamaly/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hosamaly/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hosamaly/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hosamaly",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 11 |
2015-10-02T23:02:42Z
|
2021-09-08T06:00:58Z
|
2015-10-03T17:33:57Z
|
CONTRIBUTOR
|
resolved
|
Fixes #2799
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2800/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2800/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2800.diff",
"html_url": "https://github.com/psf/requests/pull/2800",
"merged_at": "2015-10-03T17:33:57Z",
"patch_url": "https://github.com/psf/requests/pull/2800.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2800"
}
| true |
[
"This is really good! One note: can we remove the reference to `response.ok`? It's at risk of deprecation, so I'd rather not add new references to it.\n",
"Thanks. I beg to differ on `response.ok`. I find it useful and advise people to use it, although I'd prefer to change its implementation to avoid raising and catching exceptions. It could be as simple as `return self.status_code < 400`. I could update the pull request if you wish.\n",
"The problem with `ok` is that it's not entirely clear what exactly it means: it's ambiguous and weird. Changing it would be better, yeah. =)\n",
"I've updated the implementation of `ok` and added a docstring to it.\n",
"Sorry, that was me being really unclear. I didn't want you to change `ok` itself, I wanted you to change the reference to it. =( Sorry.\n",
"Feel free to edit the description to fit your needs. I still think using `ok` is clearer for new users (to whom the Quickstart guide is targeted), IMHO.\n",
"To be clear, I'm not going to accept a change to the implementation of `ok`, especially one that changes the contract. If you'd rather not make further changes to this, that's fine, I can merge it and make the changes myself.\n",
"My change to the implementation of `ok` certainly did not change the contract; it still behaves exactly the same. And certainly feel free to accept it or not; it isn't really important.\n\nI'm just not comfortable changing the reference to `ok` in the Quickstart guide, so I'd rather you do it yourself if you really think it's better without it.\n",
"@Lukasa would you like to revert these changes, or should I?\n",
"Thanks so much @hosamaly!\n",
"You're welcome @Lukasa . Thanks for accepting it.\n"
] |
https://api.github.com/repos/psf/requests/issues/2799
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2799/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2799/comments
|
https://api.github.com/repos/psf/requests/issues/2799/events
|
https://github.com/psf/requests/issues/2799
| 109,570,280 |
MDU6SXNzdWUxMDk1NzAyODA=
| 2,799 |
Quickstart note about json rendering is misleading
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/330633?v=4",
"events_url": "https://api.github.com/users/hosamaly/events{/privacy}",
"followers_url": "https://api.github.com/users/hosamaly/followers",
"following_url": "https://api.github.com/users/hosamaly/following{/other_user}",
"gists_url": "https://api.github.com/users/hosamaly/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hosamaly",
"id": 330633,
"login": "hosamaly",
"node_id": "MDQ6VXNlcjMzMDYzMw==",
"organizations_url": "https://api.github.com/users/hosamaly/orgs",
"received_events_url": "https://api.github.com/users/hosamaly/received_events",
"repos_url": "https://api.github.com/users/hosamaly/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hosamaly/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hosamaly/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hosamaly",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-10-02T20:53:53Z
|
2021-09-08T22:00:45Z
|
2015-10-03T17:33:57Z
|
CONTRIBUTOR
|
resolved
|
In the Quickstart document, the [JSON Response Content](http://docs.python-requests.org/en/v2.0-0/user/quickstart/#json-response-content) section says:
> In case the JSON decoding fails, `r.json` raises an exception. For example, if the response gets a 401 (Unauthorized), attempting `r.json` raises `ValueError: No JSON object could be decoded`
This is a bit misleading, especially that the [`json()`](https://github.com/kennethreitz/requests/blob/v2.7.0/requests/models.py#L798) method makes no attempt to validate that. It is accurate to say that failure to decode JSON will result in an error being raised. However, receiving 401 does not necessarily mean that JSON decoding will fail. Some APIs might return a JSON object in the response body (e.g. `{ 'error': 'Unauthorized' }`), in which case `r.json()` will work fine.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2799/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2799/timeline
| null |
completed
| null | null | false |
[
"That's a fair observation. Got a suggestion for clearer language?\n"
] |
https://api.github.com/repos/psf/requests/issues/2798
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2798/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2798/comments
|
https://api.github.com/repos/psf/requests/issues/2798/events
|
https://github.com/psf/requests/pull/2798
| 109,484,678 |
MDExOlB1bGxSZXF1ZXN0NDY2MzE1NTI=
| 2,798 |
Clarified description for option "trust_env"
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/2008673?v=4",
"events_url": "https://api.github.com/users/Doctor-love/events{/privacy}",
"followers_url": "https://api.github.com/users/Doctor-love/followers",
"following_url": "https://api.github.com/users/Doctor-love/following{/other_user}",
"gists_url": "https://api.github.com/users/Doctor-love/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Doctor-love",
"id": 2008673,
"login": "Doctor-love",
"node_id": "MDQ6VXNlcjIwMDg2NzM=",
"organizations_url": "https://api.github.com/users/Doctor-love/orgs",
"received_events_url": "https://api.github.com/users/Doctor-love/received_events",
"repos_url": "https://api.github.com/users/Doctor-love/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Doctor-love/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Doctor-love/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Doctor-love",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-10-02T12:48:06Z
|
2021-09-08T06:00:58Z
|
2015-10-02T12:48:56Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2798/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2798/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2798.diff",
"html_url": "https://github.com/psf/requests/pull/2798",
"merged_at": "2015-10-02T12:48:56Z",
"patch_url": "https://github.com/psf/requests/pull/2798.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2798"
}
| true |
[
"Thanks! :sparkles: :cake: :sparkles:\n"
] |
|
https://api.github.com/repos/psf/requests/issues/2797
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2797/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2797/comments
|
https://api.github.com/repos/psf/requests/issues/2797/events
|
https://github.com/psf/requests/pull/2797
| 109,450,764 |
MDExOlB1bGxSZXF1ZXN0NDY2MTI2NTY=
| 2,797 |
Updated Documentation for Issue #2756
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/11199045?v=4",
"events_url": "https://api.github.com/users/sumitbinnani/events{/privacy}",
"followers_url": "https://api.github.com/users/sumitbinnani/followers",
"following_url": "https://api.github.com/users/sumitbinnani/following{/other_user}",
"gists_url": "https://api.github.com/users/sumitbinnani/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sumitbinnani",
"id": 11199045,
"login": "sumitbinnani",
"node_id": "MDQ6VXNlcjExMTk5MDQ1",
"organizations_url": "https://api.github.com/users/sumitbinnani/orgs",
"received_events_url": "https://api.github.com/users/sumitbinnani/received_events",
"repos_url": "https://api.github.com/users/sumitbinnani/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sumitbinnani/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sumitbinnani/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sumitbinnani",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-10-02T08:29:38Z
|
2021-09-08T06:00:59Z
|
2015-10-02T09:08:23Z
|
CONTRIBUTOR
|
resolved
|
Updated Documentation as mentioned by @taion in #2756 :
`data` as well as `files` supersedes json
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2797/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2797/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2797.diff",
"html_url": "https://github.com/psf/requests/pull/2797",
"merged_at": "2015-10-02T09:08:23Z",
"patch_url": "https://github.com/psf/requests/pull/2797.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2797"
}
| true |
[
"Thanks @sumitbinnani! :sparkles: :cake: :sparkles:\n"
] |
https://api.github.com/repos/psf/requests/issues/2796
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2796/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2796/comments
|
https://api.github.com/repos/psf/requests/issues/2796/events
|
https://github.com/psf/requests/pull/2796
| 109,449,942 |
MDExOlB1bGxSZXF1ZXN0NDY2MTIzNzM=
| 2,796 |
Updated Documentation (Ref: #2756)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/11199045?v=4",
"events_url": "https://api.github.com/users/sumitbinnani/events{/privacy}",
"followers_url": "https://api.github.com/users/sumitbinnani/followers",
"following_url": "https://api.github.com/users/sumitbinnani/following{/other_user}",
"gists_url": "https://api.github.com/users/sumitbinnani/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sumitbinnani",
"id": 11199045,
"login": "sumitbinnani",
"node_id": "MDQ6VXNlcjExMTk5MDQ1",
"organizations_url": "https://api.github.com/users/sumitbinnani/orgs",
"received_events_url": "https://api.github.com/users/sumitbinnani/received_events",
"repos_url": "https://api.github.com/users/sumitbinnani/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sumitbinnani/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sumitbinnani/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sumitbinnani",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2015-10-02T08:25:24Z
|
2021-09-08T06:00:59Z
|
2015-10-02T08:27:51Z
|
CONTRIBUTOR
|
resolved
|
Updated Documentation:
`data` as well as `files` supersedes json
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/11199045?v=4",
"events_url": "https://api.github.com/users/sumitbinnani/events{/privacy}",
"followers_url": "https://api.github.com/users/sumitbinnani/followers",
"following_url": "https://api.github.com/users/sumitbinnani/following{/other_user}",
"gists_url": "https://api.github.com/users/sumitbinnani/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sumitbinnani",
"id": 11199045,
"login": "sumitbinnani",
"node_id": "MDQ6VXNlcjExMTk5MDQ1",
"organizations_url": "https://api.github.com/users/sumitbinnani/orgs",
"received_events_url": "https://api.github.com/users/sumitbinnani/received_events",
"repos_url": "https://api.github.com/users/sumitbinnani/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sumitbinnani/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sumitbinnani/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sumitbinnani",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2796/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2796/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2796.diff",
"html_url": "https://github.com/psf/requests/pull/2796",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2796.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2796"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/2795
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2795/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2795/comments
|
https://api.github.com/repos/psf/requests/issues/2795/events
|
https://github.com/psf/requests/pull/2795
| 109,438,293 |
MDExOlB1bGxSZXF1ZXN0NDY2MDY4Mzk=
| 2,795 |
Fixed Bug #2756
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/11199045?v=4",
"events_url": "https://api.github.com/users/sumitbinnani/events{/privacy}",
"followers_url": "https://api.github.com/users/sumitbinnani/followers",
"following_url": "https://api.github.com/users/sumitbinnani/following{/other_user}",
"gists_url": "https://api.github.com/users/sumitbinnani/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sumitbinnani",
"id": 11199045,
"login": "sumitbinnani",
"node_id": "MDQ6VXNlcjExMTk5MDQ1",
"organizations_url": "https://api.github.com/users/sumitbinnani/orgs",
"received_events_url": "https://api.github.com/users/sumitbinnani/received_events",
"repos_url": "https://api.github.com/users/sumitbinnani/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sumitbinnani/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sumitbinnani/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sumitbinnani",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-10-02T06:42:20Z
|
2021-09-08T06:00:59Z
|
2015-10-02T07:13:59Z
|
CONTRIBUTOR
|
resolved
|
1. Updated code: `data` supersedes `json`
2. Updated doc: `files` also supersedes `json`
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2795/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2795/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2795.diff",
"html_url": "https://github.com/psf/requests/pull/2795",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2795.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2795"
}
| true |
[
"Sorry @sumitbinnani, but there's already an open fix for this in #2763 that I think we're likely to merge. Thanks so much for your contribution though! :sparkles: :cake: :sparkles:\n"
] |
https://api.github.com/repos/psf/requests/issues/2794
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2794/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2794/comments
|
https://api.github.com/repos/psf/requests/issues/2794/events
|
https://github.com/psf/requests/pull/2794
| 109,437,597 |
MDExOlB1bGxSZXF1ZXN0NDY2MDYzOTA=
| 2,794 |
Fixed Bug #2756
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/11199045?v=4",
"events_url": "https://api.github.com/users/sumitbinnani/events{/privacy}",
"followers_url": "https://api.github.com/users/sumitbinnani/followers",
"following_url": "https://api.github.com/users/sumitbinnani/following{/other_user}",
"gists_url": "https://api.github.com/users/sumitbinnani/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sumitbinnani",
"id": 11199045,
"login": "sumitbinnani",
"node_id": "MDQ6VXNlcjExMTk5MDQ1",
"organizations_url": "https://api.github.com/users/sumitbinnani/orgs",
"received_events_url": "https://api.github.com/users/sumitbinnani/received_events",
"repos_url": "https://api.github.com/users/sumitbinnani/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sumitbinnani/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sumitbinnani/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sumitbinnani",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2015-10-02T06:31:50Z
|
2021-09-08T06:01:00Z
|
2015-10-02T06:34:49Z
|
CONTRIBUTOR
|
resolved
|
Updated Code to meet following specs:
1. Data supersedes JSON
Updated Doc to meet following specs:
2. Files supersedes JSON
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/11199045?v=4",
"events_url": "https://api.github.com/users/sumitbinnani/events{/privacy}",
"followers_url": "https://api.github.com/users/sumitbinnani/followers",
"following_url": "https://api.github.com/users/sumitbinnani/following{/other_user}",
"gists_url": "https://api.github.com/users/sumitbinnani/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sumitbinnani",
"id": 11199045,
"login": "sumitbinnani",
"node_id": "MDQ6VXNlcjExMTk5MDQ1",
"organizations_url": "https://api.github.com/users/sumitbinnani/orgs",
"received_events_url": "https://api.github.com/users/sumitbinnani/received_events",
"repos_url": "https://api.github.com/users/sumitbinnani/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sumitbinnani/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sumitbinnani/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sumitbinnani",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2794/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2794/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2794.diff",
"html_url": "https://github.com/psf/requests/pull/2794",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2794.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2794"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/2793
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2793/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2793/comments
|
https://api.github.com/repos/psf/requests/issues/2793/events
|
https://github.com/psf/requests/issues/2793
| 109,349,430 |
MDU6SXNzdWUxMDkzNDk0MzA=
| 2,793 |
No module called utils
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/325887?v=4",
"events_url": "https://api.github.com/users/mango314/events{/privacy}",
"followers_url": "https://api.github.com/users/mango314/followers",
"following_url": "https://api.github.com/users/mango314/following{/other_user}",
"gists_url": "https://api.github.com/users/mango314/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mango314",
"id": 325887,
"login": "mango314",
"node_id": "MDQ6VXNlcjMyNTg4Nw==",
"organizations_url": "https://api.github.com/users/mango314/orgs",
"received_events_url": "https://api.github.com/users/mango314/received_events",
"repos_url": "https://api.github.com/users/mango314/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mango314/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mango314/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mango314",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2015-10-01T17:48:41Z
|
2021-09-08T22:00:45Z
|
2015-10-03T20:30:12Z
|
NONE
|
resolved
|
I recently installed requests 2.7 using `pip install requests` and received an error message.
See my question to [StackOverflow](http://stackoverflow.com/questions/32874326/python-email-module-importerror-no-module-named-utils) but will copy-paste here:
My installation of Python's [requests](http://www.python-requests.org/en/latest/) library has been working perfectly for months and it has decided to break today.
```
Python 2.7.6 (default, Jun 22 2015, 17:58:13)
[GCC 4.8.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python2.7/dist-packages/requests/__init__.py", line 58, in <module>
from . import utils
File "/usr/local/lib/python2.7/dist-packages/requests/utils.py", line 26, in <module>
from .compat import parse_http_list as _parse_list_header
File "/usr/local/lib/python2.7/dist-packages/requests/compat.py", line 7, in <module>
from .packages import chardet
File "/usr/local/lib/python2.7/dist-packages/requests/packages/__init__.py", line 3, in <module>
from . import urllib3
File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/__init__.py", line 10, in <module>
from .connectionpool import (
File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/connectionpool.py", line 37, in <module>
from .request import RequestMethods
File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/request.py", line 6, in <module>
from .filepost import encode_multipart_formdata
File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/filepost.py", line 8, in <module>
from .fields import RequestField
File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/fields.py", line 1, in <module>
import email.utils
ImportError: No module named utils
```
The trouble calling [`utils`](https://docs.python.org/2/library/email.util.html) is related to the [email](https://docs.python.org/2/library/email-examples.html) module in Python 2.7
```
>>> import email
>>> import email.utils
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ImportError: No module named utils
```
`utils` is clearly a part of Python's `email` library, but it can't be accessed. If I uninstall and reinstall:
```
$ sudo pip install email
Collecting email
Downloading email-4.0.2.tar.gz (1.2MB)
100% |████████████████████████████████| 1.2MB 286kB/s
Installing collected packages: email
Running setup.py install for email
Successfully installed email-4.0.2
```
**Worst of all `utils.py` is actually present. What am I doing wrong?**
```
$ ls /usr/local/lib/python2.7/dist-packages/email/
base64mime.py errors.py header.py message.py parser.pyc
base64mime.pyc errors.pyc header.pyc message.pyc quoprimime.py
charset.py feedparser.py __init__.py mime quoprimime.pyc
charset.pyc feedparser.pyc __init__.pyc _parseaddr.py test
encoders.py generator.py iterators.py _parseaddr.pyc utils.py
encoders.pyc generator.pyc iterators.pyc parser.py utils.pyc
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/325887?v=4",
"events_url": "https://api.github.com/users/mango314/events{/privacy}",
"followers_url": "https://api.github.com/users/mango314/followers",
"following_url": "https://api.github.com/users/mango314/following{/other_user}",
"gists_url": "https://api.github.com/users/mango314/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mango314",
"id": 325887,
"login": "mango314",
"node_id": "MDQ6VXNlcjMyNTg4Nw==",
"organizations_url": "https://api.github.com/users/mango314/orgs",
"received_events_url": "https://api.github.com/users/mango314/received_events",
"repos_url": "https://api.github.com/users/mango314/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mango314/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mango314/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mango314",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2793/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2793/timeline
| null |
completed
| null | null | false |
[
"I observe this issue has been raised before. None of which really answer my question:\n- https://github.com/kennethreitz/requests/issues/2340\n- https://github.com/kennethreitz/requests/issues/2461\n- https://github.com/kennethreitz/requests/issues/2788\n- https://github.com/kennethreitz/requests/issues/2780\n",
"This is almost certainly caused by you having a file in your cwd called `email.py`, which is breaking the import.\n",
"Try the following steps:\n<ol><li>Change your current working directory and rerun the command. If error, the issue is as pointed out by Lukasa. If you don't get the error, proceed to step 2</li>\n\n<li>Try running\n\n``` python\nimport email.parser\n```\n\nIf this line also throws the error, there is a conflict and most probably there is another `email.py` in your dependency list</li>\n",
"@Lukasa You are most certainly correct. God only knows when I did it.\n"
] |
https://api.github.com/repos/psf/requests/issues/2792
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2792/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2792/comments
|
https://api.github.com/repos/psf/requests/issues/2792/events
|
https://github.com/psf/requests/pull/2792
| 109,261,373 |
MDExOlB1bGxSZXF1ZXN0NDY1MDE1NzA=
| 2,792 |
Update test dependencies
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-10-01T09:26:32Z
|
2021-09-08T06:01:00Z
|
2015-10-01T09:27:25Z
|
MEMBER
|
resolved
|
Brings our test dependencies up to date.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2792/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2792/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2792.diff",
"html_url": "https://github.com/psf/requests/pull/2792",
"merged_at": "2015-10-01T09:27:25Z",
"patch_url": "https://github.com/psf/requests/pull/2792.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2792"
}
| true |
[
"I think there's no good reason not to do this so I'm merging immediately.\n"
] |
https://api.github.com/repos/psf/requests/issues/2791
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2791/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2791/comments
|
https://api.github.com/repos/psf/requests/issues/2791/events
|
https://github.com/psf/requests/issues/2791
| 108,692,878 |
MDU6SXNzdWUxMDg2OTI4Nzg=
| 2,791 |
Request doesnt work on Ubuntu to fetch a TLS1.2 https
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3865309?v=4",
"events_url": "https://api.github.com/users/adrianzhang/events{/privacy}",
"followers_url": "https://api.github.com/users/adrianzhang/followers",
"following_url": "https://api.github.com/users/adrianzhang/following{/other_user}",
"gists_url": "https://api.github.com/users/adrianzhang/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/adrianzhang",
"id": 3865309,
"login": "adrianzhang",
"node_id": "MDQ6VXNlcjM4NjUzMDk=",
"organizations_url": "https://api.github.com/users/adrianzhang/orgs",
"received_events_url": "https://api.github.com/users/adrianzhang/received_events",
"repos_url": "https://api.github.com/users/adrianzhang/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/adrianzhang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adrianzhang/subscriptions",
"type": "User",
"url": "https://api.github.com/users/adrianzhang",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 15 |
2015-09-28T16:13:56Z
|
2021-09-08T20:01:04Z
|
2015-09-30T17:43:24Z
|
NONE
|
resolved
|
I did search long time try to figure out what is the root reason but still have no clue.
There is a simple script used Request to put information to https://dictation.nuancemobility.net, however, the script works on CentOS box but doesn't on Ubuntu ( both on ElementaryOS Freya which is based on Ubuntu 14.04 TLS and ElementaryOS Luna which is based on Ubuntu 12.02).
I have tried to use adapter, and got an error:
<pre><code>
Traceback (most recent call last):
File "LanguageIdentify.py", line 11, in <module>
from APIclasses import speech2text
File "speech2text.py", line 11, in <module>
s.mount('https://dictation.nuancemobility.net/', SSLAdapter(ssl.PROTOCOL_TLSv1_2))
AttributeError: 'module' object has no attribute 'PROTOCOL_TLSv1_2'
</code></pre>
I assumed the error caused by python ssl module on Ubuntu is without TLS 1.2 support, but when I ran test on CentOS box, it got:
<pre><code>
python
\>>>import ssl
>>>'PROTOCOL_TLSv1_2' in dir(ssl)`
False
</code></pre>
So above test informed me at least python ssl in not the root reason.
Some posts show the openssl on Debian/Ubuntu doesnt have default root CA certs configured. So I also tried to follow Certifi doc to import CA certs. But no clue how to operate the next step. I'v tried to follow Request doc that using REQUEST_CA_BUNDLE but also no help.
`export REQUEST_CA_BUNDLE=/etc/ssl/certs/ca-certificates.crt`
Well, all methods I tried and failed on Ubuntu. It is appreciate if anybody can help.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2791/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2791/timeline
| null |
completed
| null | null | false |
[
"Can you provide a more detailed description of \"doesn't work\"? How does it not work? What exception(s) (if any) are you seeing? What version of python are you using? What version of requests?\n",
"A quick test locally shows this:\n\n```\n$ openssl s_client -connect dictation.nuancemobility.net:443\n# ...\nSSL-Session:\n Protocol : TLSv1.2\n Cipher : RC4-SHA\n# ...\n$ openssl s_client -no_tls1_2 -connect dictation.nuancemobility.net:443\n# ...\nSSL-Session:\n Protocol : TLSv1\n Cipher : RC4-SHA\n# ...\n```\n\nHowever, if we provide a list of ciphers we prefer (as we do in requests)\n\n```\n$ openssl s_client -no_tls1_2 -cipher 'ECDH+AESGCM:DH+AESGCM:ECDH+AES256:DH+AES256:ECDH+AES128:DH+AES:ECDH+HIGH:DH+HIGH:ECDH+3DES:DH+3DES:RSA+AESGCM:RSA+AES:RSA+HIGH:RSA+3DES:!aNULL:!eNULL:!MD5' -connect dictation.nuancemobility.net:443\n```\n\nContinues to work just fine. We still need much more detail before we can help you debug this and determine if this is _actually_ a requests bug or not (I'm suspecting not).\n",
"@sigmavirus24 \nThanks for take care the case.\nMore details are:\n\n## Environment\n\n1) A basic ElementaryOS without any configurations, which means a total clean installation from DVD or ISO. (Actually I used 3 different Ubuntu)\n- ElementaryOS Freya, based on Ubuntu 14.04 TLS\n- ElementaryOS Luna, based on Ubuntu 12.02 TLS\n- Docker official python 2.7.10 image which is based on Debian.\n\n2) A basic CentOS 6.5 without any configuration.\n- Python version: 2.6.6\n- >>> import ssl\n- >>> import requests\n- >>> import urllib3\n\nTraceback (most recent call last):\n File \"<stdin>\", line 1, in <module>\nImportError: No module named urllib3\n\n## Problem\n\nI wrote a script to require Nuance ASR service, see below code. When I run this script on ElementaryOS or Debian, it get a 500 error from Nuance ASR. And Nuance ASR returns correct 200 http response with recognized text content when I run the script on CentOS.\n\n<pre ><code>\nimport os\nimport requests\nclass Nuance_api():\n \"\"\"Nuance ASR Service API\"\"\"\n def __init__(self, appid, appkey, n_id):\n self.appid = appid\n self.appkey = appkey\n self.id = n_id\n def recogenize(self, language, voicefilename):\n nuance_url = 'https://dictation.nuancemobility.net/NMDPAsrCmdServlet/dictation'\n n_params = {'appId':self.appid, 'appKey':self.appkey, 'id':self.id}\n voice_file = {'file': open(voicefilename, 'rb')}\n n_headers = {'Accept-Language':language, 'Content-Type':'audio/amr;codec=amr;bit=4.75;rate=8000', 'Accept':'text/plain', 'Accept-Topic':'Dictation'}\n r = requests.post(url=nuance_url, params=n_params, headers=n_headers, files=voice_file, verify=False)\n if r.status_code == 200 :\n return r.text\n</code></pre>\n\n## Additional problem\n\nWhen I use `openssl s_client -connect dictation.nuancemobility.net:443` on Ubuntu evn (whatever which one), it gives an error: \n\n<pre><code>\nSSL handshake has read 4032 bytes and written 609 bytes\n---\nNew, TLSv1/SSLv3, Cipher is RC4-SHA\nServer public key is 2048 bit\nSecure Renegotiation IS supported\nCompression: NONE\nExpansion: NONE\nSSL-Session:\n Protocol : TLSv1.2\n Cipher : RC4-SHA\n Session-ID: 9986FC667995B0BEF3325136811A0D8C4E14901627854D8DC042F9920F341903\n Session-ID-ctx: \n Master-Key: 15199FB75D47C6B7C1CA86D12010C63C34E7908EBC4902EB5AC91E39A6C965121F9906719857CFDCBC319BEA5824C356\n Key-Arg : None\n PSK identity: None\n PSK identity hint: None\n SRP username: None\n Start Time: 1443494743\n Timeout : 300 (sec)\n Verify return code: 20 (unable to get local issuer certificate)\n---\n</code></pre>\n\nWhen I use `openssl s_client -connect dictation.nuancemobility.net:443` on CentOS env or `openssl s_client -connect dictation.nuancemobility.net:443 -CApath /etc/ssl/certs` on Ubuntu or Debian, it gives correct response:\n\n<pre><code>\n---\nNew, TLSv1/SSLv3, Cipher is RC4-SHA\nServer public key is 2048 bit\nSecure Renegotiation IS supported\nCompression: NONE\nExpansion: NONE\nSSL-Session:\n Protocol : TLSv1.2\n Cipher : RC4-SHA\n Session-ID: 9986FC667994C5F4F3325136811A0C8C0F5A769166086DE7C042F9920F341B05\n Session-ID-ctx: \n Master-Key: 0B893DBEF29821430934D7AB665AF2E24E6322E7990EB77415A6715D6196F73E503DC0395DDDFF209D491A144371F5D5\n Key-Arg : None\n Krb5 Principal: None\n PSK identity: None\n PSK identity hint: None\n Start Time: 1443495250\n Timeout : 300 (sec)\n Verify return code: 0 (ok)\n---\n</code></pre>\n\n## Reproduce the fault\n\nfor debug purpose, I would suggest the easiest way that to create Docker env and run official python 2.7.10 image, then test Request in it. The instructions for these:\n\n<pre><code>\n# Docker installation\n$ sudo sh -c \"echo deb https:/get.docker.io/ubuntu docker main > /etc/apt/sources.list.d/docker.list\"\n$ curl -s https://get.docker.io/gpg | sudo apt-key add -\n$ sudo apt-get update\n$ sudo apt-get install lxc-docker\n# run docker image\n$ sudo docker run -i -t python:2.7.10 /bin/bash\n# then the current bash is in python 2.7.10 image, and user is root.\n# pip install requests\n# python MY_SCRIPT_WITH_NECESSARY_PARAMETERS'_VALUE or just to connect dictation.nuancemobility.net:443\n</code></pre>\n",
"Looks like your problem is with openssl, not Python, not requests.\n\nYou still haven't described the error you're receiving when using requests.\n",
"@sigmavirus24 When using Requests, it gets below response.\n\n<pre><code>\n/usr/local/lib/python2.7/dist-packages/requests-2.6.0-py2.7.egg/requests/packages/urllib3/connectionpool.py:769: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.org/en/latest/security.html\n InsecureRequestWarning)\n<html>\n<head>\n<meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\"/>\n<title>Error 500 x-nuance-sessionid71887ede-d26d-448d-b154-256eecd3dda0\nReceived QueryRetry: 1 AUDIO_INFO</title>\n</head>\n<body><h2>HTTP ERROR 500</h2>\n<p>Problem accessing /NMDPAsrCmdServlet/dictation. Reason:\n<pre> x-nuance-sessionid71887ede-d26d-448d-b154-256eecd3dda0\nReceived QueryRetry: 1 AUDIO_INFO</pre></p>\n</body>\n</html>\n</code></pre>\n\nThere are tons discussions of the openssl behavior on Debian/Ubuntu. It is quite clear that every ssl client software on Debian/Ubuntu MUST define CA bundle with some parameters by themselves. The sample is how I use `openssl s_client`. To Requests, I tried `export REQUEST_CA_BUNDLE=/etc/ssl/certs/ca-certificates.crt` but still got 500. \n\nIf Nuance ASR service is hard for troubleshooting. My question can be replaced by \"How to make Requests working to access https://www.google.com via TLS v1.2 on Debian/Ubuntu?\"\n\nBTW, in order to identify where the problem is, I also tried to revise my code below to use TLS v1, but also got 500. Can you also let me know the usage of Adapter is correct or not please? \n\n<pre><code>\nimport os\nimport requests\nfrom requests_toolbelt.adapters.ssl import SSLAdapter\nimport ssl\ns = requests.Session()\ns.mount('https://dictation.nuancemobility.net/', SSLAdapter(ssl.PROTOCOL_TLSv1))\nclass Nuance_api():\n \"\"\"Nuance ASR Service API\"\"\"\n def __init__(self, appid, appkey, n_id):\n self.appid = appid\n self.appkey = appkey\n self.id = n_id\n def recogenize(self, language, voicefile):\n nuance_url = 'https://dictation.nuancemobility.net/NMDPAsrCmdServlet/dictation'\n n_params = {'appId':self.appid, 'appKey':self.appkey, 'id':self.id}\n voice_file = {'file': open(voicefile, 'rb')}\n n_headers = {'Accept-Language':language, 'Content-Type':'audio/amr;codec=amr;bit=4.75;rate=8000', 'Accept':'text/plain', 'Accept-Topic':'Dictation'}\n r = requests.post(url=nuance_url, params=n_params, headers=n_headers, files=voice_file, verify=False)\n if r.status_code == 200 :\n return r.text\n</code></pre>\n",
"A 500 error is a problem with the server. It has nothing to do with TLS or requests.\n",
"Also, to answer your question: you are using the SSLAdapter correctly.\n\nTo be clearer than I was on my phone:\n\nIf you were seeing an exception from requests about an SSLError, that would indicate that the problem was with TLS configuration. The 500 error is something I even see with OpenSSL's `s_client`.\n\nAfter `s_client` verifies and initiates the connection, you can type anything, e.g., `GET /`. When I do that, the server gives me the following:\n\n```\nGET /\n<html>\n<head>\n<meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\"/>\n<title>Error 500 JSP support not configured</title>\n</head>\n<body><h2>HTTP ERROR 500</h2>\n<p>Problem accessing /index.jsp. Reason:\n<pre> JSP support not configured</pre></p>\n</body>\n</html>\n```\n\nThis looks to be a problem on their server. Even if I do\n\n```\nGET /index.jsp\n<html>\n<head>\n<meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\"/>\n<title>Error 500 JSP support not configured</title>\n</head>\n<body><h2>HTTP ERROR 500</h2>\n<p>Problem accessing /index.jsp. Reason:\n<pre> JSP support not configured</pre></p>\n</body>\n</html>\n```\n\nIf I attempt to reproduce your request (a bit):\n\n```\nPOST /NMDPAsrCmdServlet/dictation\n<html>\n<head>\n<meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\"/>\n<title>Error 401 Unauthorized, invalid application id or key.</title>\n</head>\n<body><h2>HTTP ERROR 401</h2>\n<p>Problem accessing /NMDPAsrCmdServlet/dictation. Reason:\n<pre> Unauthorized, invalid application id or key.</pre></p>\n</body>\n</html>\n```\n\nSo their application seems to work up until a point. Then it fails. I'll repeat, this has nothing to do with TLS.\n",
"If 500 is caused by server side, why the same code working well on CentOS?\n\nAnd yes you will get 500 or 401 because there is no necessary credentials in your URL. \n\nI did further tests in the past hours, on the same Debian/Ubuntu, curl successfully get 200 response, Requests doesn't. So the problem must be caused by Python2 or Requests. \n\nCatching TCP/IP packages on Debian/Ubuntu, server side send 4 HELLOs after TLS handshaking, but if on CentOS server side will start receiving data after TLS handshaking. \n\nThere is another discussion about SSL failure. Interesting thing in the comment, maybe that is the reason but I don't know how to make Requests working on Debian/Ubuntu.\n\nDiscussion:\nhttp://stackoverflow.com/questions/10667960/python-requests-throwing-up-sslerror\n\ncomment in this discussion:\n\n> Sorry Boud, I needed to down vote this answer as requests does not handle HTTPS requests \"like a web browser\". If the full SSL chain of trust (including intermediate certificates) is not declared on a server and requires an extra certificate download, you will receive the above SSL verification error. Web browsers will do the extra download and not flag any certificate errors. This is one way that a web browser and Requests differ. There are others. Requests does some verification, but it is not as good as a browser. – Louis Cremen Jun 29 at 3:39 \n",
"@adrianzhang We're really going to need a working repro scenario to help you here. Can you give us some code that fails in the way you observe where curl succeeds?\n",
"@Lukasa \nFirst of all, I am really appreciate of your support. I did not post the full url because there are credentials in it. Can I send to you and sigmavirus24 via email? \n",
"@adrianzhang Of course. If you are concerned about security, my GPG key is available at [Keybase](https://keybase.io/lukasa).\n",
"@Lukasa Thank you so much, email sent to [email protected]. Any more details you want to know, feel free and let me know please.\n",
"This has been resolved offline. \n",
"Would love to know about the solution... I have the same issue :(\n",
"@frenchy75 Are you sure it's the same issue? The issue from the original post was nothing to do with TLS, and it was a coding error in their software. What problem _exactly_ are you seeing?\n"
] |
https://api.github.com/repos/psf/requests/issues/2790
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2790/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2790/comments
|
https://api.github.com/repos/psf/requests/issues/2790/events
|
https://github.com/psf/requests/issues/2790
| 108,619,994 |
MDU6SXNzdWUxMDg2MTk5OTQ=
| 2,790 |
Update urllib3 for performance issue
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1401705?v=4",
"events_url": "https://api.github.com/users/ClemPi/events{/privacy}",
"followers_url": "https://api.github.com/users/ClemPi/followers",
"following_url": "https://api.github.com/users/ClemPi/following{/other_user}",
"gists_url": "https://api.github.com/users/ClemPi/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ClemPi",
"id": 1401705,
"login": "ClemPi",
"node_id": "MDQ6VXNlcjE0MDE3MDU=",
"organizations_url": "https://api.github.com/users/ClemPi/orgs",
"received_events_url": "https://api.github.com/users/ClemPi/received_events",
"repos_url": "https://api.github.com/users/ClemPi/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ClemPi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ClemPi/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ClemPi",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-09-28T09:27:12Z
|
2021-09-08T22:00:46Z
|
2015-09-30T13:29:54Z
|
NONE
|
resolved
|
Hi,
Can you update urllib3 to this commit https://github.com/shazow/urllib3/commit/4aebc69dbf1f2eecbff61c3902a9074be4722837 ?
It's a serious performance issue to not have this patch for large file uploads.
Regards,
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2790/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2790/timeline
| null |
completed
| null | null | false |
[
"The next release should include an update to the most recent release of urllib3.\n"
] |
https://api.github.com/repos/psf/requests/issues/2789
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2789/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2789/comments
|
https://api.github.com/repos/psf/requests/issues/2789/events
|
https://github.com/psf/requests/pull/2789
| 108,580,221 |
MDExOlB1bGxSZXF1ZXN0NDYxMTY1Nzk=
| 2,789 |
Remove offer to pair with others from README
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
[] |
closed
| true |
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
] | null | 0 |
2015-09-28T02:51:36Z
|
2021-09-08T06:01:01Z
|
2015-09-30T13:29:27Z
|
CONTRIBUTOR
|
resolved
|
I don't have the time to dedicate to this any longer unfortunately.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2789/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2789/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2789.diff",
"html_url": "https://github.com/psf/requests/pull/2789",
"merged_at": "2015-09-30T13:29:27Z",
"patch_url": "https://github.com/psf/requests/pull/2789.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2789"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/2788
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2788/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2788/comments
|
https://api.github.com/repos/psf/requests/issues/2788/events
|
https://github.com/psf/requests/issues/2788
| 108,453,780 |
MDU6SXNzdWUxMDg0NTM3ODA=
| 2,788 |
ImportError: cannot import name certs
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1618719?v=4",
"events_url": "https://api.github.com/users/Boshomi/events{/privacy}",
"followers_url": "https://api.github.com/users/Boshomi/followers",
"following_url": "https://api.github.com/users/Boshomi/following{/other_user}",
"gists_url": "https://api.github.com/users/Boshomi/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Boshomi",
"id": 1618719,
"login": "Boshomi",
"node_id": "MDQ6VXNlcjE2MTg3MTk=",
"organizations_url": "https://api.github.com/users/Boshomi/orgs",
"received_events_url": "https://api.github.com/users/Boshomi/received_events",
"repos_url": "https://api.github.com/users/Boshomi/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Boshomi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Boshomi/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Boshomi",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2015-09-26T10:15:46Z
|
2015-09-26T21:36:09Z
|
2015-09-26T21:36:04Z
|
NONE
| null |
opensuse 13.1 / python-requests = 2.7.0-63.1 /
## In [8]: import requests;
ImportError Traceback (most recent call last)
<ipython-input-8-eedc5c747136> in <module>()
----> 1 import requests;
/usr/lib/python2.7/site-packages/requests/**init**.py in <module>()
56 pass
57
---> 58 from . import utils
59 from .models import Request, Response, PreparedRequest
60 from .api import request, get, head, post, patch, put, delete, options
/usr/lib/python2.7/site-packages/requests/utils.py in <module>()
23
24 from . import **version**
---> 25 from . import certs
26 from .compat import parse_http_list as _parse_list_header
27 from .compat import (quote, urlparse, bytes, str, OrderedDict, unquote, is_py2,
ImportError: cannot import name certs
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2788/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2788/timeline
| null |
completed
| null | null | false |
[
"this issue is fixed with version -requests = opensuse 13.1 / 2.7.0-66.1 /\n"
] |
https://api.github.com/repos/psf/requests/issues/2787
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2787/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2787/comments
|
https://api.github.com/repos/psf/requests/issues/2787/events
|
https://github.com/psf/requests/issues/2787
| 108,398,187 |
MDU6SXNzdWUxMDgzOTgxODc=
| 2,787 |
Failure in tests on specfic host
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/186766?v=4",
"events_url": "https://api.github.com/users/rixvet/events{/privacy}",
"followers_url": "https://api.github.com/users/rixvet/followers",
"following_url": "https://api.github.com/users/rixvet/following{/other_user}",
"gists_url": "https://api.github.com/users/rixvet/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/rixvet",
"id": 186766,
"login": "rixvet",
"node_id": "MDQ6VXNlcjE4Njc2Ng==",
"organizations_url": "https://api.github.com/users/rixvet/orgs",
"received_events_url": "https://api.github.com/users/rixvet/received_events",
"repos_url": "https://api.github.com/users/rixvet/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/rixvet/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rixvet/subscriptions",
"type": "User",
"url": "https://api.github.com/users/rixvet",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-09-25T20:02:25Z
|
2021-09-08T22:00:46Z
|
2015-09-25T20:18:05Z
|
NONE
|
resolved
|
Hi I am facing a weird issue both with python2 and python3 which seems to be limited to a specific host (my laptop). A few of the test cases are failing and I do not know why.
```
[rvdzwet@rvdzwet-asus tmp]$ git clone https://github.com/kennethreitz/requests.git
Cloning into 'requests'...
remote: Counting objects: 15705, done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 15705 (delta 0), reused 0 (delta 0), pack-reused 15701
Receiving objects: 100% (15705/15705), 6.52 MiB | 147.00 KiB/s, done.
Resolving deltas: 100% (8874/8874), done.
Checking connectivity... done.
[rvdzwet@rvdzwet-asus tmp]$ cd requests/
[rvdzwet@rvdzwet-asus requests]$ ls
AUTHORS.rst docs ext HISTORY.rst LICENSE Makefile MANIFEST.in NOTICE README.rst requests requirements.txt setup.cfg setup.py test_requests.py
[rvdzwet@rvdzwet-asus requests]$ ./test_requests.py
................FF.................................................................................................................................
======================================================================
FAIL: test_auth_is_retained_for_redirect_on_host (__main__.RequestsTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "./test_requests.py", line 1002, in test_auth_is_retained_for_redirect_on_host
assert h1 == h2
AssertionError
======================================================================
FAIL: test_auth_is_stripped_on_redirect_off_host (__main__.RequestsTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "./test_requests.py", line 995, in test_auth_is_stripped_on_redirect_off_host
assert not r.request.headers.get('Authorization', '')
AssertionError
----------------------------------------------------------------------
Ran 147 tests in 33.126s
FAILED (failures=2)
```
Some details of the host:
```
[rvdzwet@rvdzwet-asus requests]$ lsb_release -a
LSB Version: :core-4.1-amd64:core-4.1-noarch:cxx-4.1-amd64:cxx-4.1-noarch:desktop-4.1-amd64:desktop-4.1-noarch:languages-4.1-amd64:languages-4.1-noarch:printing-4.1-amd64:printing-4.1-noarch
Distributor ID: Fedora
Description: Fedora release 21 (Twenty One)
Release: 21
Codename: TwentyOne
[rvdzwet@rvdzwet-asus requests]$ python -V
Python 2.7.8
[rvdzwet@rvdzwet-asus requests]$ python3 -V
Python 3.4.1
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/186766?v=4",
"events_url": "https://api.github.com/users/rixvet/events{/privacy}",
"followers_url": "https://api.github.com/users/rixvet/followers",
"following_url": "https://api.github.com/users/rixvet/following{/other_user}",
"gists_url": "https://api.github.com/users/rixvet/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/rixvet",
"id": 186766,
"login": "rixvet",
"node_id": "MDQ6VXNlcjE4Njc2Ng==",
"organizations_url": "https://api.github.com/users/rixvet/orgs",
"received_events_url": "https://api.github.com/users/rixvet/received_events",
"repos_url": "https://api.github.com/users/rixvet/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/rixvet/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rixvet/subscriptions",
"type": "User",
"url": "https://api.github.com/users/rixvet",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2787/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2787/timeline
| null |
completed
| null | null | false |
[
"Found the culprit (after looking looking at the streams with wireshark). It was caused by a erroneous `~/.netrc` entry.\n\n```\n[rvdzwet@rvdzwet-asus requests]$ cat ~/.netrc \ndefault login anonymous password user@site\n```\n\nRemoving this entry fixed my issue. Thanks to you folks for providing the extended test suite, allowing quick debugging! \n"
] |
https://api.github.com/repos/psf/requests/issues/2786
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2786/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2786/comments
|
https://api.github.com/repos/psf/requests/issues/2786/events
|
https://github.com/psf/requests/pull/2786
| 107,960,351 |
MDExOlB1bGxSZXF1ZXN0NDU4MDI2ODM=
| 2,786 |
adapters: Fix bug causing ingored read_timeout for chunked requests
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1258054?v=4",
"events_url": "https://api.github.com/users/swistakm/events{/privacy}",
"followers_url": "https://api.github.com/users/swistakm/followers",
"following_url": "https://api.github.com/users/swistakm/following{/other_user}",
"gists_url": "https://api.github.com/users/swistakm/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/swistakm",
"id": 1258054,
"login": "swistakm",
"node_id": "MDQ6VXNlcjEyNTgwNTQ=",
"organizations_url": "https://api.github.com/users/swistakm/orgs",
"received_events_url": "https://api.github.com/users/swistakm/received_events",
"repos_url": "https://api.github.com/users/swistakm/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/swistakm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/swistakm/subscriptions",
"type": "User",
"url": "https://api.github.com/users/swistakm",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 5 |
2015-09-23T16:45:57Z
|
2021-09-08T05:00:56Z
|
2015-10-01T07:26:01Z
|
NONE
|
resolved
|
Whenever chunked request was made (using generators) read timeout value was ignored because socket timeout was not set.
This can be a problem when system default timeout is very long because blocks process waiting for response for a period of time that cannot be controlled.
Changes:
- `HTTPAdapter.send()` now sets read timeout on `low_conn.sock` socket when request body is chunked.
- socket.error, socket.timeout are explicitely translated to urllib3 exceptions using `conn._raise_timeout`
as expected with non-chunked request bodies to be later translated to `requests` exceptions with existing code.
- test added for timeouts on chunked-message body requests
Additional notes:
- due to convention to use httbin in requests tests and no posibility
to tests POST timeouts with `delay/:n` endpoint (method not allowed)
test for this bug uses GET with chunked message-body. This is OK
because RFC-2616 does not explicitely say that message-body is
forbidden in GET requests. And also it works
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2786/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2786/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2786.diff",
"html_url": "https://github.com/psf/requests/pull/2786",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2786.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2786"
}
| true |
[
"Paging @shazow to make sure we don't step on any toes here with urllib3 by accident.\n",
"Looks painful but don't think urllib3 would break this.\n",
"This went how I expected. It was closed but never fixed. If it won't be fixed this way but is planned to be done in urllib3 can we just reopen it as an issue so it will be left as a reminder that such issue exists?\n",
"Also I found another reason why it may be worth fixing. Some servers can send a response before whole request is transmitted. I know HTTP was designed as a synchronous protocol but it looks like a lot of software implements it asynchronously.\n\nOne of notable examples is Jetty. In case of issues like unhandled read timeouts on its side it sends response before even consuming a request. I noticed that various services using this server may behave in unexpected ways if they send error response but client is still writing its response (this is another issue by the way). Currently I experience an issue where requests lock indefinitely on `sendto` sys call and never quit due to lack of timeout when talking to Jetty server using chunked transfer encoding.\n\nI think that instead of saying that there is better way to do it we could merge this as a working fix to a critical issue (never-ending blocking calls) even if not elegant and only then think about rectifying this in urllib3.\n",
"@swistakm We have merged chunked upload support into urllib3. We have not updated to the version of urllib3 that contains that fix, but when we do we'll also remove our own support for timeouts.\n\nHowever, requests should _never_ lock on sending a socket: that suggests the connection is still up but Jetty is not consuming any data from the socket, leading to the TCP stream being forced open.\n"
] |
https://api.github.com/repos/psf/requests/issues/2785
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2785/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2785/comments
|
https://api.github.com/repos/psf/requests/issues/2785/events
|
https://github.com/psf/requests/issues/2785
| 107,941,992 |
MDU6SXNzdWUxMDc5NDE5OTI=
| 2,785 |
Information leakage in default user agent
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3287067?v=4",
"events_url": "https://api.github.com/users/asieira/events{/privacy}",
"followers_url": "https://api.github.com/users/asieira/followers",
"following_url": "https://api.github.com/users/asieira/following{/other_user}",
"gists_url": "https://api.github.com/users/asieira/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/asieira",
"id": 3287067,
"login": "asieira",
"node_id": "MDQ6VXNlcjMyODcwNjc=",
"organizations_url": "https://api.github.com/users/asieira/orgs",
"received_events_url": "https://api.github.com/users/asieira/received_events",
"repos_url": "https://api.github.com/users/asieira/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/asieira/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/asieira/subscriptions",
"type": "User",
"url": "https://api.github.com/users/asieira",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 14 |
2015-09-23T15:09:52Z
|
2021-09-08T22:00:44Z
|
2015-10-05T14:56:31Z
|
CONTRIBUTOR
|
resolved
|
I've noticed that requests adds a user-agent header by default that looks like the following: `python-requests/2.7.0 CPython/2.7.9 Linux/3.14.44-32.39.amzn1.x86_64`.
Including the CPython and OS kernel version are an unnecessary information leakage that could have security implications, as per the [OWASP documentation](https://www.owasp.org/index.php/Information_Leakage).
I would like to suggest the default is changed to follow the 'bot' convention described [here](https://en.wikipedia.org/wiki/User_agent#Format_for_automated_agents_.28bots.29) with the requests version and a link to the requests documentation: `python-requests/<version> (http://http://www.python-requests.org/)`.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2785/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2785/timeline
| null |
completed
| null | null | false |
[
"Eh, I'm 50/50 on this. I agree the default user-agent isn't ideal. I don't agree that this is a large problem. I'd like to hear @Lukasa's opinion on this but he's away on vacation (as I should be).\n",
"Agreed that this is not a critical issue, but it is a security problem nonetheless.\n\nThank you very much for the awesome project, enjoy your vacation and let me know if there's anything I can do to help. :)\n",
"So, I've ruminated a bit on this now that I've had a chance and I'm not quite convinced it's a security problem. \n1. this is easily overridden by the user\n2. your attackers without knowledge of your use of requests, can not be certain that the information there is entirely accurate or if it has been faked (just like other user-agents can just as easily be used)\n3. attackers in this case are not very clear\n - An attacker could be the server your intentionally talking to (e.g., example.com) but at that point, there are potential other attacks that they could carry out even without (for example) knowledge of your Python version or kernel information\n - An attacker could be someone who is actively performing a MITM attack on a connection, in that case you have much larger problems than the attacker knowing your Python version or kernel information\n\nIn short, I think we need a much better threat model here before we change the existing behaviour. I'm fine documenting that for some use-cases the default user-agent is perhaps not ideal, and they can reference the existing documentation that shows how to set a UA.\n",
"My responses:\n1. the fact that there is a workaround (setting another UA value) doesn't make the default any less secure;\n2. since this is the default, I have to imagine the vast majority of requests-based software will be leaking valid data through this mechanism, so the odds are in favor of the attackers;\n3. let me try to help you understand the potential threats here:\n - If HTTP is being used (rather than HTTPS), then anyone in the communications path can access that information on any request it is able to observe. So one attacker inside an organization trying to do lateral movement into a neighboring server will be able to learn a lot about which software is running on the machine, for example.\n - There are many ways in which a requests-based client could be led to a malicious server: DNS poisoning, XSS on a valid web page, etc. If a malicious server is contacted by a requests-based client it will then learn useful information about the client that can help an attacker that controls it choose a method to try and compromise it. This obviously applies even to HTTPS traffic.\n - I disagree with \"if you are vulnerable to X you have much larger problems already\". Someone might have control over the network but know nothing about the target host OS and software versions, and giving them this information can make their lives a lot easier. Even if you argue the attacker could find the same information elsewhere, the fact that he is able to do it passively allows him to obtain that data while minimizing the chances of being detected. Most alternatives, such as doing a port scan with service fingerprinting, would be much noisier and might tip the defenders of the attacker's efforts.\n\nAt the end of the day, even if you think the security gain is marginal, I guess we can all agree that it is not zero. Also, AFAIK changing this default breaks no requests functionality whatsoever (correct me if I'm wrong here). So, I would still maintain this is worth doing.\n\nThat is just my opinion, of course. More than happy to speak on a Skype or Google Hangouts call since complex subjects such as these might be easier to discuss that way.\n",
"My general position on this is that removing the kernel version is a good idea and we should do it. Other UA strings do not include it, and it's unlikely to be of much use in any role other than attacking a Linux kernel directly, so I'd be happy to strip it.\n\nI'm +0 on removing the Python version, though we need to confirm with @dstufft that pip's not relying on our use of it. I don't believe it's a serious attack vector, but neither is it information that it's vital to be sending in the UA string.\n\nIMO the biggest security risk in there is actually the _requests_ version, and that's the one thing it's hard to justify removing. ;)\n",
"pip doesn't use the default user-agent at all, feel free to change it to whatever you want.\n",
"For the record I agree completely with @Lukasa, his proposal matches perfectly my original suggestion of using `python-requests/<version> (http://http://www.python-requests.org/)` as the default UA.\n",
"@asieira that is not @Lukasa's proposal. Please don't misrepresent people's comments.\n",
"If I understand @Lukasa 's comments correctly, he agrees that a) removing the kernel version is a good idea, and that b) the Python version is not a vital information to include in the UA, so it could be removed provided this doesn't break pip (which was subsequently confirmed by @dstufft). \n\nSo that would leave us with a default UA with no kernel or Python version, and only contains the requests version. Which is precisely what I had originally proposed.\n\nI'm sorry if I misunderstood any of that. I don't want to start a flame war here or anything, but now I'm genuinely curious as to what part of @Lukasa 's comment you believe I misinterpreted or misrepresented.\n",
"The thing you're disagreeing about is whether a URL would be contained in the User-Agent: I did not propose that, you did. =)\n\nI'm -1 on the URL, but +1 on everything else.\n",
"Damnit @Lukasa you always post a comment ~30s before I can.\n\n@asieira I didn't mean to put you on the offensive. I simply didn't want someone coming along and implementing the wrong thing based on your comment. Clarity and correctness is important.\n\nFrankly, I'm -0 on removing this information but I wouldn't block a PR removing it.\n",
"@Lukasa and @sigmavirus24 thank you for clarifying that. The important part for me is removing the sensitive information. Not at all married to the specific format or having the requests URL there at all, sorry I didn't make that clearer before. You are absolutely right that clarity and correctness are important.\n\nDo we all agree with `requests/<version>` as the UA string, then?\n\nI can submit a PR for this, if you wish, as soon as we agree on the exact format.\n",
"That suits me =)\n",
"Resolved. =)\n"
] |
https://api.github.com/repos/psf/requests/issues/2784
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2784/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2784/comments
|
https://api.github.com/repos/psf/requests/issues/2784/events
|
https://github.com/psf/requests/issues/2784
| 107,878,540 |
MDU6SXNzdWUxMDc4Nzg1NDA=
| 2,784 |
pooled connections are not returned to the pool
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/200878?v=4",
"events_url": "https://api.github.com/users/sileht/events{/privacy}",
"followers_url": "https://api.github.com/users/sileht/followers",
"following_url": "https://api.github.com/users/sileht/following{/other_user}",
"gists_url": "https://api.github.com/users/sileht/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sileht",
"id": 200878,
"login": "sileht",
"node_id": "MDQ6VXNlcjIwMDg3OA==",
"organizations_url": "https://api.github.com/users/sileht/orgs",
"received_events_url": "https://api.github.com/users/sileht/received_events",
"repos_url": "https://api.github.com/users/sileht/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sileht/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sileht/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sileht",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-09-23T09:17:46Z
|
2021-09-08T22:00:47Z
|
2015-09-23T10:28:35Z
|
NONE
|
resolved
|
Hi
When pool_block=True on an HTTPAdapter is used and the connection fails
this one seems not return to the pool.
To reproduce:
```
# python
>>> import requests
>>> a = requests.adapters.HTTPAdapter(pool_maxsize=1, pool_block=True)
>>> s = requests.Session()
>>> s.mount("http://", a)
>>> s.get("http://localhost:12345")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 477, in get
return self.request('GET', url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 465, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 573, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/adapters.py", line 413, in send
raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', error(111, 'Connection refused'))
>>> s.get("http://localhost:12345")
# here the session objects is stuck.
```
Cheers,
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/200878?v=4",
"events_url": "https://api.github.com/users/sileht/events{/privacy}",
"followers_url": "https://api.github.com/users/sileht/followers",
"following_url": "https://api.github.com/users/sileht/following{/other_user}",
"gists_url": "https://api.github.com/users/sileht/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sileht",
"id": 200878,
"login": "sileht",
"node_id": "MDQ6VXNlcjIwMDg3OA==",
"organizations_url": "https://api.github.com/users/sileht/orgs",
"received_events_url": "https://api.github.com/users/sileht/received_events",
"repos_url": "https://api.github.com/users/sileht/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sileht/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sileht/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sileht",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2784/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2784/timeline
| null |
completed
| null | null | false |
[
"After deeper investigation it seems to be that one: https://github.com/shazow/urllib3/issues/659\n",
"Duplicate of kennethreitz/requests#2687\n"
] |
https://api.github.com/repos/psf/requests/issues/2783
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2783/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2783/comments
|
https://api.github.com/repos/psf/requests/issues/2783/events
|
https://github.com/psf/requests/issues/2783
| 107,794,059 |
MDU6SXNzdWUxMDc3OTQwNTk=
| 2,783 |
SSL: CERTIFICATE_VERIFY_FAILED on valid(?) cert chain with verify="./bundle.crt"
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1677760?v=4",
"events_url": "https://api.github.com/users/neutrinus/events{/privacy}",
"followers_url": "https://api.github.com/users/neutrinus/followers",
"following_url": "https://api.github.com/users/neutrinus/following{/other_user}",
"gists_url": "https://api.github.com/users/neutrinus/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/neutrinus",
"id": 1677760,
"login": "neutrinus",
"node_id": "MDQ6VXNlcjE2Nzc3NjA=",
"organizations_url": "https://api.github.com/users/neutrinus/orgs",
"received_events_url": "https://api.github.com/users/neutrinus/received_events",
"repos_url": "https://api.github.com/users/neutrinus/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/neutrinus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/neutrinus/subscriptions",
"type": "User",
"url": "https://api.github.com/users/neutrinus",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 7 |
2015-09-22T20:23:58Z
|
2021-09-04T00:06:08Z
|
2015-09-30T20:15:58Z
|
NONE
|
resolved
|
## Story
We are using requests in [MonitOwl](https://github.com/whitehats/monitowl-agent) agent to communicate with API servers, big "thank you" for great software. Few days ago we ordered new certificates for *.monitowl.com and deployed it to new instance, our issuer is `nazwa.pl`. Pointing a webbrowser to https://activeo.monitowl.com works flawlessly, requests seems to have some problems, when setting verify="./cabundle.crt".
## Technical notes
In front of the tornado server handling ssl there is a haproxy checking SNI and redistributing the traffic, part of the config file:
```
acl app_activeo req_ssl_sni -i activeo.monitowl.com
use_backend bk_activeo if app_activeo
```
We _need_ to provide own cabundle to have control what is accepted - because of security issues and deployment scripts. We are using debian jessie everywhere.
```
# from issuer https://panel.nazwa.pl/uploads/ssl/nazwaSSL_SHA-2.zip
$ cat monitowlcom.crt nazwasslsha2.pem certumca-ctncasha2.pem gscasha2.pem > ./ca_bundle.crt
# exported from firefox
$ cat monitowl.com nazwaSSL CertumTrustedNetworkCA CertumGlobalServicesCASHA2 > ca_bundle_ff.crt
$ openssl verify -untrusted ./ca.crt monitowlcom.crt
monitowlcom.crt: OK
$ c_rehash ./
$ openssl s_client -CApath ./ -connect activeo.monitowl.com:443 -servername activeo.monitowl.com
CONNECTED(00000003)
depth=4 C = PL, O = Unizeto Sp. z o.o., CN = Certum CA
verify return:1
depth=3 C = PL, O = Unizeto Technologies S.A., OU = Certum Certification Authority, CN = Certum Trusted Network CA
verify return:1
depth=2 C = PL, O = Unizeto Technologies S.A., OU = Certum Certification Authority, CN = Certum Global Services CA SHA2
verify return:1
depth=1 C = PL, O = nazwa.pl S.A., OU = http://nazwa.pl, CN = nazwaSSL
verify return:1
depth=0 C = PL, CN = *.monitowl.com, emailAddress = [email protected]
verify return:1
[...]
* Verify return code: 0 (ok)*
$ curl -I --cacert ca_bundle.crt https://activeo.monitowl.com
HTTP/1.1 200 OK
$ curl -I --cacert ca_bundle_ff.crt https://activeo.monitowl.com
HTTP/1.1 200 OK
```
As you can see, the `openssl s_client` verifies the connection, curl works without problems.
## Problem
```
In [1]: import requests
In [3]: requests.get('https://activeo.monitowl.com', verify=True)
Out[3]: <Response [200]>
In [4]: requests.get('https://activeo.monitowl.com', verify="./ca_bundle.crt")
---------------------------------------------------------------------------
SSLError Traceback (most recent call last)
<ipython-input-3-c92a3091d6ce> in <module>()
----> 1 requests.get('https://activeo.monitowl.com', verify="./ca_bundle.crt")
/home/vagrant/.virtualenvs/test/local/lib/python2.7/site-packages/requests/api.pyc in get(url, params, **kwargs)
67
68 kwargs.setdefault('allow_redirects', True)
---> 69 return request('get', url, params=params, **kwargs)
70
71
/home/vagrant/.virtualenvs/test/local/lib/python2.7/site-packages/requests/api.pyc in request(method, url, **kwargs)
48
49 session = sessions.Session()
---> 50 response = session.request(method=method, url=url, **kwargs)
51 # By explicitly closing the session, we avoid leaving sockets open which
52 # can trigger a ResourceWarning in some cases, and look like a memory leak
/home/vagrant/.virtualenvs/test/local/lib/python2.7/site-packages/requests/sessions.pyc in request(self, method, url, params, data, headers, cookies, files, auth, timeout, allow_redirects, proxies, hooks, stream, verify, cert, json)
463 }
464 send_kwargs.update(settings)
--> 465 resp = self.send(prep, **send_kwargs)
466
467 return resp
/home/vagrant/.virtualenvs/test/local/lib/python2.7/site-packages/requests/sessions.pyc in send(self, request, **kwargs)
571
572 # Send the request
--> 573 r = adapter.send(request, **kwargs)
574
575 # Total elapsed time of the request (approximately)
/home/vagrant/.virtualenvs/test/local/lib/python2.7/site-packages/requests/adapters.pyc in send(self, request, stream, timeout, verify, cert, proxies)
429 except (_SSLError, _HTTPError) as e:
430 if isinstance(e, _SSLError):
--> 431 raise SSLError(e, request=request)
432 elif isinstance(e, ReadTimeoutError):
433 raise ReadTimeout(e, request=request)
SSLError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:581)
In [5]: requests.get('https://activeo.monitowl.com', verify="./ca_bundle_ff.crt")
[same error]
In [7]: import ssl; ssl.OPENSSL_VERSION
Out[7]: 'OpenSSL 1.0.1k 8 Jan 2015'
In [8]: import sys; print (sys.version)
2.7.9 (default, Mar 1 2015, 12:57:24)
[GCC 4.9.2]
In [2]: requests.__version__
Out[2]: '2.7.0'
```
On server side (tornado):
```
SSLError: [SSL: TLSV1_ALERT_UNKNOWN_CA] tlsv1 alert unknown ca (_ssl.c:581)
```
I asked some friends to test it with the bundle exported from webbrowser and:
Python==2.7.9 + OpenSSL==1.0.1k => FAILS
Python==2.7.10 + OpenSSL==1.0.1k => FAILS
Python==2.7.9 + OpenSSL==1.0.1l => FAILS
Python==2.7.10 + OpenSSL==1.0.1p => WORKS
Python==2.7.10 + OpenSSL==1.0.2d => WORKS
Python==2.7.9 + OpenSSL 1.0.2d => WORKS
I'm aware that python verifies the certs [differently](http://stackoverflow.com/questions/27804710/python-urllib2-ssl-error/27826829#27826829) than web browsers.
Do you have any clues what is wrong with the bundle? What else can I check? It's a bug? In requests, openssl, python or urllib3?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1677760?v=4",
"events_url": "https://api.github.com/users/neutrinus/events{/privacy}",
"followers_url": "https://api.github.com/users/neutrinus/followers",
"following_url": "https://api.github.com/users/neutrinus/following{/other_user}",
"gists_url": "https://api.github.com/users/neutrinus/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/neutrinus",
"id": 1677760,
"login": "neutrinus",
"node_id": "MDQ6VXNlcjE2Nzc3NjA=",
"organizations_url": "https://api.github.com/users/neutrinus/orgs",
"received_events_url": "https://api.github.com/users/neutrinus/received_events",
"repos_url": "https://api.github.com/users/neutrinus/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/neutrinus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/neutrinus/subscriptions",
"type": "User",
"url": "https://api.github.com/users/neutrinus",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2783/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2783/timeline
| null |
completed
| null | null | false |
[
"I've posted a [$30 bounty for this](https://www.bountysource.com/issues/26878061-ssl-certificate_verify_failed-on-valid-cert-chain-with-verify-bundle-crt).\n\nI've tested the server with [ssl checker](https://www.ssllabs.com/ssltest/analyze.html?d=activeo.monitowl.com&latest) and there was no issues, beside accepting old crypto algorithms..\n",
"Sorry about the delay on this: due to some bad luck on your end, both core maintainers were on holiday at the same time when you raised this issue.\n\nWhat cert are you providing in the bundle?\n",
"The StackOverflow link you provided has the core bug summary, but I'm finding that in this case it's not so hard to resolve. Can you try using just this as your cert bundle and reproducing your test?\n\n```\n-----BEGIN CERTIFICATE-----\nMIIDDDCCAfSgAwIBAgIDAQAgMA0GCSqGSIb3DQEBBQUAMD4xCzAJBgNVBAYTAlBM\nMRswGQYDVQQKExJVbml6ZXRvIFNwLiB6IG8uby4xEjAQBgNVBAMTCUNlcnR1bSBD\nQTAeFw0wMjA2MTExMDQ2MzlaFw0yNzA2MTExMDQ2MzlaMD4xCzAJBgNVBAYTAlBM\nMRswGQYDVQQKExJVbml6ZXRvIFNwLiB6IG8uby4xEjAQBgNVBAMTCUNlcnR1bSBD\nQTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAM6xwS7TT3zNJc4YPk/E\njG+AanPIW1H4m9LcuwBcsaD8dQPugfCI7iNS6eYVM42sLQnFdvkrOYCJ5JdLkKWo\nePhzQ3ukYbDYWMzhbGZ+nPMJXlVjhNWo7/OxLjBos8Q82KxujZlakE403Daaj4GI\nULdtlkIJ89eVgw1BS7Bqa/j8D35in2fE7SZfECYPCE/wpFcozo+47UX2bu4lXapu\nOb7kky/ZR6By6/qmW6/KUz/iDsaWVhFu9+lmqSbYf5VT7QqFiLpPKaVCjF62/IUg\nAKpoC6EahQGcxEZjgoi2IrHu/qpGWX7PNSzVttpd90gzFFS269lvzs2I1qsb2pY7\nHVkCAwEAAaMTMBEwDwYDVR0TAQH/BAUwAwEB/zANBgkqhkiG9w0BAQUFAAOCAQEA\nuI3O7+cUus/usESSbLQ5PqKEbq24IXfS1HeCh+YgQYHu4vgRt2PRFze+GXYkHAQa\nTOs9qmdvLdTN/mUxcMUbpgIKumB7bVjCmkn+YzILa+M6wKyrO7Do0wlRjBCDxjTg\nxSvgGrZgFCdsMneMvLJymM/NzD+5yCRCFNZX/OYmQ6kd5YCQzgNUKD73P9P4Te1q\nCjqTE5s7FCMTY5w/0YcneeVMUeMBrYVdGjux1XMQpNPyvG5k9VpWkKjHDkx0Dy5x\nO/fIR/RpbxXyEV6DHpx8Uq79AtoSqFlnGNu8cN2bsWntgM6JQEhqDjXKKWYVIZQs\n6GAqm4VKQPNriiTsBhYscw==\n-----END CERTIFICATE-----\n```\n",
"Yeah, with your bundle it works. But it's SHA1, not SHA256.\n\nMy bundle (SHA256 only):\n\n```\n-----BEGIN CERTIFICATE-----\nMIIEbjCCA1agAwIBAgIQUooUzakaS0WlY3wDZH9CwTANBgkqhkiG9w0BAQsFADCB\ngzELMAkGA1UEBhMCUEwxIjAgBgNVBAoTGVVuaXpldG8gVGVjaG5vbG9naWVzIFMu\nQS4xJzAlBgNVBAsTHkNlcnR1bSBDZXJ0aWZpY2F0aW9uIEF1dGhvcml0eTEnMCUG\nA1UEAxMeQ2VydHVtIEdsb2JhbCBTZXJ2aWNlcyBDQSBTSEEyMB4XDTE0MDkzMDEx\nNTQxOFoXDTI0MDkyNzExNTQxOFowUjELMAkGA1UEBhMCUEwxFjAUBgNVBAoMDW5h\nendhLnBsIFMuQS4xGDAWBgNVBAsMD2h0dHA6Ly9uYXp3YS5wbDERMA8GA1UEAwwI\nbmF6d2FTU0wwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDjAfhBk7mv\nZ5MlDV34icf8DwkugIYgm6bKBI4aZKa+SoL7tb64OymtOhZxLX2XRMhKqj84GcUE\njg0yQ0vkG/CS/ssJLqo1t56mZJXi5wFCP8eWYcIJoVvGG1QIe1oG1Umtm1dUeDT+\nORHoejbp5XQsubD4bAw3f/vAaBztEKRxB2fGRa07ruY20z4Tm1cKKXASwexzftzQ\ng0F/mGm4bAiIm5nodphpWVdqaMxZDXhe7ix90ziUR33P/gbxFpZDGMhQIk8bcZbN\n1Cvq9URgKZ7jLkZdbQIBJGN2vMMOaPMb/nt2cyvNZcyRMZoP4u+p6x88SEul9zlw\nufjsV2Qdbk3PAgMBAAGjggEMMIIBCDASBgNVHRMBAf8ECDAGAQH/AgEAMDIGA1Ud\nHwQrMCkwJ6AloCOGIWh0dHA6Ly9jcmwuY2VydHVtLnBsL2dzY2FzaGEyLmNybDBu\nBggrBgEFBQcBAQRiMGAwKAYIKwYBBQUHMAGGHGh0dHA6Ly9zdWJjYS5vY3NwLWNl\ncnR1bS5jb20wNAYIKwYBBQUHMAKGKGh0dHA6Ly9yZXBvc2l0b3J5LmNlcnR1bS5w\nbC9nc2Nhc2hhMi5jZXIwHwYDVR0jBBgwFoAUVJndm//opw6jGZ1bvkJX3zD8jzIw\nHQYDVR0OBBYEFLJhdoKVWgE3F5fCdyG17Yv8KfdnMA4GA1UdDwEB/wQEAwIBBjAN\nBgkqhkiG9w0BAQsFAAOCAQEAHnOtSeZgWlG3Ly/I0QrG7T0eviYdjtHNbmddiuPR\nk9UVLoQtDU53MjKl5YvoMWVfUe3ROymD0gvPfh44luLRFzdZ+IO21z90DGEq4utz\nuU4DLKI5uzYffuUOAY3k5839ZnEs/1h0yZ4VHcF95IY0IcQ91W0rc3cm0/1WEj++\nbcMm4CZzKkbX61+7pnjIw3eAKotNQ3b6QDOnAgNhZSVBTzBJtnoBL4BsoVubYmbP\nwOq/vvWmKj901NYI2Iawm6W58hJrI+xEn/vG4vq2Hpku3YE9CKDq8kqjILNxn9n/\nd7w1te4vPp7cUhW+2DVfpjPbYWHbbPhDvEgOYG+lsQVb4w==\n-----END CERTIFICATE-----\n-----BEGIN CERTIFICATE-----\nMIIEzTCCA7WgAwIBAgIRANBLb+XdW9Ih58dM9kaLMUYwDQYJKoZIhvcNAQELBQAw\nfjELMAkGA1UEBhMCUEwxIjAgBgNVBAoTGVVuaXpldG8gVGVjaG5vbG9naWVzIFMu\nQS4xJzAlBgNVBAsTHkNlcnR1bSBDZXJ0aWZpY2F0aW9uIEF1dGhvcml0eTEiMCAG\nA1UEAxMZQ2VydHVtIFRydXN0ZWQgTmV0d29yayBDQTAeFw0xNDA5MTExMjAwMDBa\nFw0yNzA2MDkxMDQ2MzlaMIGDMQswCQYDVQQGEwJQTDEiMCAGA1UEChMZVW5pemV0\nbyBUZWNobm9sb2dpZXMgUy5BLjEnMCUGA1UECxMeQ2VydHVtIENlcnRpZmljYXRp\nb24gQXV0aG9yaXR5MScwJQYDVQQDEx5DZXJ0dW0gR2xvYmFsIFNlcnZpY2VzIENB\nIFNIQTIwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDHhvLXeA4kyBVY\nDr12JusjW+/HPPWpBmWnSZC9gadbNXCD/GlHrGruRWrKn0YBasbonXi5FLRon717\naCCDt2+7URnJx4mLGt3X73yH3I+T+COuyTFOuLId68jYV4vfBm1N/N1/KohGr8+R\n7eT4f4agfXVQ+gDZT3pGTywqc9IId4uHaFjW+mr5vVfu7WjL8A20jOawvlqV2K4/\nqSrjPZsqHlzf46LHgbQEK1EjTPsFrfvAQxvGpHiEIAFsS+1d2xPIEJVIxvq+KyGb\nW/0SJIj7/SfYo+ItvJ2a4/G2JfoPF9wTCC0N8U5I/KXxjYYXBcIE9pQ16T24T+dr\nMfPG2mYtAgMBAAGjggE+MIIBOjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBRU\nmd2b/+inDqMZnVu+QlffMPyPMjAfBgNVHSMEGDAWgBQIds3LB/8k9sXN7buQvOKE\nN0Z19zAOBgNVHQ8BAf8EBAMCAQYwLwYDVR0fBCgwJjAkoCKgIIYeaHR0cDovL2Ny\nbC5jZXJ0dW0ucGwvY3RuY2EuY3JsMGsGCCsGAQUFBwEBBF8wXTAoBggrBgEFBQcw\nAYYcaHR0cDovL3N1YmNhLm9jc3AtY2VydHVtLmNvbTAxBggrBgEFBQcwAoYlaHR0\ncDovL3JlcG9zaXRvcnkuY2VydHVtLnBsL2N0bmNhLmNlcjA5BgNVHSAEMjAwMC4G\nBFUdIAAwJjAkBggrBgEFBQcCARYYaHR0cDovL3d3dy5jZXJ0dW0ucGwvQ1BTMA0G\nCSqGSIb3DQEBCwUAA4IBAQDRhC+yVHfF/IFcNNKbkxX1aVsCZ0fa2t+MxyFcs7KO\nqW1fGpOOycughOFnbM+lz4Y3gt5RaOFJTm7YVUZZ3751s5tv8nhXeXfrRIpQN7Cu\n+Nei457HlDxEUItPlkYnDbdDes/96T19cICd1TmIPekYRXiyuPW4Wgx6vykmk91x\nLkJ0y74TzVtUofVF446qXvea95zNpzYCVMg+AOX3ZZyy9XfST6g4um+cw/Idv31d\nbnJdBzMOgHH3uw2YMiZQgDqvNRE+wAs+PTFEIKHmBc/t1n3Shvg9e68M+5ZRM8bE\nWGqgLqfreTgCsCQcv9MDYw9TFUbS17RdE6NtiPfszTky\n-----END CERTIFICATE-----\n-----BEGIN CERTIFICATE-----\nMIIEtDCCA5ygAwIBAgIRAJOShUABZXFflH8oj+/JmygwDQYJKoZIhvcNAQELBQAw\nPjELMAkGA1UEBhMCUEwxGzAZBgNVBAoTElVuaXpldG8gU3AuIHogby5vLjESMBAG\nA1UEAxMJQ2VydHVtIENBMB4XDTA4MTAyMjEyMDczN1oXDTI3MDYxMDEwNDYzOVow\nfjELMAkGA1UEBhMCUEwxIjAgBgNVBAoTGVVuaXpldG8gVGVjaG5vbG9naWVzIFMu\nQS4xJzAlBgNVBAsTHkNlcnR1bSBDZXJ0aWZpY2F0aW9uIEF1dGhvcml0eTEiMCAG\nA1UEAxMZQ2VydHVtIFRydXN0ZWQgTmV0d29yayBDQTCCASIwDQYJKoZIhvcNAQEB\nBQADggEPADCCAQoCggEBAOP7faNyusLwyRSH9WsBTuFuQAe6bSddf/dbLbNax1Ff\nq6QypmGHtm4PhtIwApf412lXoRg5XWpkecYBWaw8MUo4fNIE0kso6CBfOweizE1z\n2/OuT8dW1Vqnlon686to1COGWSfPCSe8rG5ygxwwct/gounS4XR1Gb0qnnsVVAQb\n10M5rVUoxeIau/TA5K44STPMdoWfOUXSpJ7yEoxR+HzkLX/1rF/rFp+xLdG6zJFC\nd0wlyZA4b9vwzPuOHpdZPtVgTuYFKO1JeRNLukjbL/ly0znK/h/YNHL1tEDPMQHD\n7N4RLRddH7hQ0V4Zp2neBzMoylCV+adUy1SGUEWp+UkCAwEAAaOCAWswggFnMA8G\nA1UdEwEB/wQFMAMBAf8wHQYDVR0OBBYEFAh2zcsH/yT2xc3tu5C84oQ3RnX3MFIG\nA1UdIwRLMEmhQqRAMD4xCzAJBgNVBAYTAlBMMRswGQYDVQQKExJVbml6ZXRvIFNw\nLiB6IG8uby4xEjAQBgNVBAMTCUNlcnR1bSBDQYIDAQAgMA4GA1UdDwEB/wQEAwIB\nBjAsBgNVHR8EJTAjMCGgH6AdhhtodHRwOi8vY3JsLmNlcnR1bS5wbC9jYS5jcmww\naAYIKwYBBQUHAQEEXDBaMCgGCCsGAQUFBzABhhxodHRwOi8vc3ViY2Eub2NzcC1j\nZXJ0dW0uY29tMC4GCCsGAQUFBzAChiJodHRwOi8vcmVwb3NpdG9yeS5jZXJ0dW0u\ncGwvY2EuY2VyMDkGA1UdIAQyMDAwLgYEVR0gADAmMCQGCCsGAQUFBwIBFhhodHRw\nOi8vd3d3LmNlcnR1bS5wbC9DUFMwDQYJKoZIhvcNAQELBQADggEBAI3m/UBmo0yc\np6uh2oTdHDAH5tvHLeyDoVbkHTwmoaUJK+h9Yr6ydZTdCPJ/KEHkgGcCToqPwzXQ\n1aknKOrS9KsGhkOujOP5iH3g271CgYACEnWy6BdxqyGVMUZCDYgQOdNv7C9C6kBT\nYr/rynieq6LVLgXqM6vp1peUQl4E7Sztapx6lX0FKgV/CF1mrWHUdqx1lpdzY70a\nQVkppV4ig8OLWfqaova9ML9yHRyZhpzyhTwd9yaWLy75ArG1qVDoOPqbCl60BMDO\nTjksygtbYvBNWFA0meaaLNKQ1wmB1sCqXs7+0vehukvZ1oaOGR+mBkdCcuBWCgAc\neLmNzJkEN0k=\n-----END CERTIFICATE-----\n```\n",
"The problem with the SHA256 bundle is that the 'root' cert in that case is cross-signed with the SHA-1 cert, but older OpenSSL's wont like that at all. The way older OpenSSL builds a cert chain is that it builds the longest one it can out of the certs provided by the remote server, and then looks for a trusted certificate that signs that chain. If it can't find that certificate, it'll bail out, without checking whether it can build a shorter chain using its trust roots.\n\nThis is an ongoing problem with the deprecation of SHA1 root certs: see certifi/python-certifi#26. Unfortunately, the only fixes are to temporarily use the SHA1 root in your trust store or to upgrade to a newer OpenSSL version.\n",
"Oh. Shame on you Python.\n\nThank you, Lukasa for explaining this. As it works for now, closing. Next year, new certificate - hope Python will got support for cross signed certificates.\n",
"I was looking for Certum API via cURL [ Certum Certificate](https://sslretail.com/certum/) but it seems to work only via __soapCall only."
] |
https://api.github.com/repos/psf/requests/issues/2782
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2782/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2782/comments
|
https://api.github.com/repos/psf/requests/issues/2782/events
|
https://github.com/psf/requests/pull/2782
| 107,567,620 |
MDExOlB1bGxSZXF1ZXN0NDU1ODAzODM=
| 2,782 |
Does't escaped ASCII characters when post json data by default
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3264292?v=4",
"events_url": "https://api.github.com/users/tao12345666333/events{/privacy}",
"followers_url": "https://api.github.com/users/tao12345666333/followers",
"following_url": "https://api.github.com/users/tao12345666333/following{/other_user}",
"gists_url": "https://api.github.com/users/tao12345666333/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/tao12345666333",
"id": 3264292,
"login": "tao12345666333",
"node_id": "MDQ6VXNlcjMyNjQyOTI=",
"organizations_url": "https://api.github.com/users/tao12345666333/orgs",
"received_events_url": "https://api.github.com/users/tao12345666333/received_events",
"repos_url": "https://api.github.com/users/tao12345666333/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/tao12345666333/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tao12345666333/subscriptions",
"type": "User",
"url": "https://api.github.com/users/tao12345666333",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 5 |
2015-09-21T18:09:10Z
|
2021-09-08T05:01:01Z
|
2016-01-30T03:29:55Z
|
NONE
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2782/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2782/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2782.diff",
"html_url": "https://github.com/psf/requests/pull/2782",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2782.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2782"
}
| true |
[
"@tao12345666333 could you explain this? Why is this necessary? Did you encounter a bug? We don't just accept code thrown over the wall without an explanation.\n",
"@sigmavirus24 Thanks for your reply.\n\nWhen I use requests to post json data, the json data will be escaped by default. \nMy code is here:\n\n```\n#!/usr/bin/env python\n# coding=utf-8\nimport requests\n\n\ndef push_message():\n body = {\n 'touser': '@all',\n 'msgtype': 'text',\n 'agentid': 0,\n 'text': {\n 'content': '测试'\n },\n 'safe': 0\n }\n\n res = requests.post(\n url='http://mytest_url',\n json=body,\n headers={\n 'Content-Type': 'application/json',\n 'encoding': 'utf-8'\n }\n )\n\n print res.content\n\nif __name__ == '__main__':\n push_message()\n```\n\nThe api server can't parse data correctly, `if include \\\\uxxxx will create fail!` (The api server is a third party)\n\nBecause of requests's default json dumps, all Chinese character will be escaped `\\\\uxxx`, so I want to change default json.dumps() by it's `ensure_ascii` options.\n",
"Hi， @sigmavirus24 I have modified the code before, does not change the original behavior, but to provide a keyword argument. Using this because escape does not an action of `prepare_body()` function.\nTherefore, don't use explicit arguments.\n",
"@tao12345666333 in this case, you should simply encode the json data yourself and pass it through the `data` parameter. Thanks for sharing, though! I see where you're coming from. \n",
"@kennethreitz Thanks! I will try again. :-)\n"
] |
|
https://api.github.com/repos/psf/requests/issues/2781
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2781/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2781/comments
|
https://api.github.com/repos/psf/requests/issues/2781/events
|
https://github.com/psf/requests/issues/2781
| 107,494,799 |
MDU6SXNzdWUxMDc0OTQ3OTk=
| 2,781 |
requests.get(verify='path/to/self-signed-certificate') cannot verify SAN
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/244203?v=4",
"events_url": "https://api.github.com/users/kissgyorgy/events{/privacy}",
"followers_url": "https://api.github.com/users/kissgyorgy/followers",
"following_url": "https://api.github.com/users/kissgyorgy/following{/other_user}",
"gists_url": "https://api.github.com/users/kissgyorgy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kissgyorgy",
"id": 244203,
"login": "kissgyorgy",
"node_id": "MDQ6VXNlcjI0NDIwMw==",
"organizations_url": "https://api.github.com/users/kissgyorgy/orgs",
"received_events_url": "https://api.github.com/users/kissgyorgy/received_events",
"repos_url": "https://api.github.com/users/kissgyorgy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kissgyorgy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kissgyorgy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kissgyorgy",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-09-21T11:49:34Z
|
2021-09-08T22:00:47Z
|
2015-09-21T12:41:54Z
|
NONE
|
resolved
|
Verifying a certificate which have Subject Alternative Names with IP addresses (or DNS names), Common Name should not be checked and those addresses should be checked instead.
[RFC6125 section 6.4.4 describes this.](http://tools.ietf.org/html/rfc6125#section-6.4.4)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2781/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2781/timeline
| null |
completed
| null | null | false |
[
"@kissgyorgy Thanks for this!\n\nWe already do this for DNS names, as you can see in [this code](https://github.com/kennethreitz/requests/blob/master/requests/packages/urllib3/packages/ssl_match_hostname/_implementation.py#L67-L105). The reason we don't do it for IP addresses in SANs is because we currently don't support authenticating IP addresses in SANs.\n\nThis is a bit of a flaw in urllib3, and we have an open issue for it in shazow/urllib3#258. Fixing that issue would automatically fix this problem, so I recommend focusing on that.\n"
] |
https://api.github.com/repos/psf/requests/issues/2780
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2780/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2780/comments
|
https://api.github.com/repos/psf/requests/issues/2780/events
|
https://github.com/psf/requests/issues/2780
| 107,358,696 |
MDU6SXNzdWUxMDczNTg2OTY=
| 2,780 |
ImportError: cannot import name certs
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/6767924?v=4",
"events_url": "https://api.github.com/users/muhammad-ammar/events{/privacy}",
"followers_url": "https://api.github.com/users/muhammad-ammar/followers",
"following_url": "https://api.github.com/users/muhammad-ammar/following{/other_user}",
"gists_url": "https://api.github.com/users/muhammad-ammar/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/muhammad-ammar",
"id": 6767924,
"login": "muhammad-ammar",
"node_id": "MDQ6VXNlcjY3Njc5MjQ=",
"organizations_url": "https://api.github.com/users/muhammad-ammar/orgs",
"received_events_url": "https://api.github.com/users/muhammad-ammar/received_events",
"repos_url": "https://api.github.com/users/muhammad-ammar/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/muhammad-ammar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/muhammad-ammar/subscriptions",
"type": "User",
"url": "https://api.github.com/users/muhammad-ammar",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-09-19T22:16:09Z
|
2021-09-08T22:00:47Z
|
2015-09-20T12:51:22Z
|
NONE
|
resolved
|
All the requests versions except `requests==0.14.2` giving me below exception. Any idea what might be wrong?
``` python
Traceback (most recent call last):
File "/usr/lib/python2.7/wsgiref/handlers.py", line 85, in run
self.result = application(self.environ, self.start_response)
File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/core/handlers/wsgi.py", line 189, in __call__
response = self.get_response(request)
File "/edx/app/xqueue/xqueue/xqueue/wsgi.py", line 50, in get_response
return super(ForceReadPostHandler, self).get_response(request)
File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 218, in get_response
response = self.handle_uncaught_exception(request, resolver, sys.exc_info())
File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 264, in handle_uncaught_exception
if resolver.urlconf_module is None:
File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/core/urlresolvers.py", line 396, in urlconf_module
self._urlconf_module = import_module(self.urlconf_name)
File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
__import__(name)
File "/edx/app/xqueue/xqueue/xqueue/urls.py", line 4, in <module>
url(r'^xqueue/', include('queue.urls')),
File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/conf/urls/__init__.py", line 33, in include
urlconf_module = import_module(urlconf_module)
File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
__import__(name)
File "/edx/app/xqueue/xqueue/queue/urls.py", line 4, in <module>
from . import ext_interface
File "/edx/app/xqueue/xqueue/queue/ext_interface.py", line 7, in <module>
import requests
File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/requests/__init__.py", line 58, in <module>
from . import utils
File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/requests/utils.py", line 24, in <module>
from . import certs
ImportError: cannot import name certs
```
**_requests==0.14.2**_ gives this exception
``` python
Traceback (most recent call last):
File "/usr/lib/python2.7/wsgiref/handlers.py", line 85, in run
self.result = application(self.environ, self.start_response)
File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/core/handlers/wsgi.py", line 189, in __call__
response = self.get_response(request)
File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 218, in get_response
response = self.handle_uncaught_exception(request, resolver, sys.exc_info())
File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 264, in handle_uncaught_exception
if resolver.urlconf_module is None:
File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/core/urlresolvers.py", line 396, in urlconf_module
self._urlconf_module = import_module(self.urlconf_name)
File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
__import__(name)
File "/edx/app/xqueue/xqueue/xqueue/urls.py", line 4, in <module>
url(r'^xqueue/', include('queue.urls')),
File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/conf/urls/__init__.py", line 33, in include
urlconf_module = import_module(urlconf_module)
File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
__import__(name)
File "/edx/app/xqueue/xqueue/queue/urls.py", line 4, in <module>
from . import ext_interface
File "/edx/app/xqueue/xqueue/queue/ext_interface.py", line 7, in <module>
import requests
File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/requests/__init__.py", line 52, in <module>
from . import utils
File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/requests/utils.py", line 22, in <module>
from .compat import parse_http_list as _parse_list_header
File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/requests/compat.py", line 95, in <module>
from .packages import chardet
File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/requests/packages/__init__.py", line 3, in <module>
from . import urllib3
File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/requests/packages/urllib3/__init__.py", line 16, in <module>
from .connectionpool import (
File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 22, in <module>
from Queue import LifoQueue, Empty, Full
ImportError: cannot import name LifoQueue
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/6767924?v=4",
"events_url": "https://api.github.com/users/muhammad-ammar/events{/privacy}",
"followers_url": "https://api.github.com/users/muhammad-ammar/followers",
"following_url": "https://api.github.com/users/muhammad-ammar/following{/other_user}",
"gists_url": "https://api.github.com/users/muhammad-ammar/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/muhammad-ammar",
"id": 6767924,
"login": "muhammad-ammar",
"node_id": "MDQ6VXNlcjY3Njc5MjQ=",
"organizations_url": "https://api.github.com/users/muhammad-ammar/orgs",
"received_events_url": "https://api.github.com/users/muhammad-ammar/received_events",
"repos_url": "https://api.github.com/users/muhammad-ammar/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/muhammad-ammar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/muhammad-ammar/subscriptions",
"type": "User",
"url": "https://api.github.com/users/muhammad-ammar",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2780/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2780/timeline
| null |
completed
| null | null | false |
[
"> All the requests versions except requests==0.14.2 giving me below exception. Any idea what might be wrong?\n\nCan you enumerate exactly which versions you've tried? The latest version would not match your first traceback. Further, how are you installing requests? You've given no information to help you out. I can presume you're trying to set up an edx development environment but provided nothing to help us reproduce.\n",
"@sigmavirus24 As per my further debugging, the issue is not related to requests. I am closing this issue.\nThanks @sigmavirus24 \n"
] |
https://api.github.com/repos/psf/requests/issues/2779
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2779/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2779/comments
|
https://api.github.com/repos/psf/requests/issues/2779/events
|
https://github.com/psf/requests/issues/2779
| 107,285,006 |
MDU6SXNzdWUxMDcyODUwMDY=
| 2,779 |
switch to alabaster theme
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-09-18T21:55:08Z
|
2021-09-08T19:00:38Z
|
2016-01-25T23:05:45Z
|
CONTRIBUTOR
|
resolved
|
this may prove difficult, due to some ad tracking codes we have enabled
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2779/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2779/timeline
| null |
completed
| null | null | false |
[
"@kennethreitz: Is this what you have in mind? https://github.com/kennethreitz/requests/pull/2915 How do I confirm that ad tracking codes are still enabled and nothing broke?\n",
"The PR for this issue is merged, so the issue could be perhaps be closed. \n"
] |
https://api.github.com/repos/psf/requests/issues/2778
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2778/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2778/comments
|
https://api.github.com/repos/psf/requests/issues/2778/events
|
https://github.com/psf/requests/issues/2778
| 107,188,451 |
MDU6SXNzdWUxMDcxODg0NTE=
| 2,778 |
Requests fails to fetch a TLS 1.2 site
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1014189?v=4",
"events_url": "https://api.github.com/users/adamatan/events{/privacy}",
"followers_url": "https://api.github.com/users/adamatan/followers",
"following_url": "https://api.github.com/users/adamatan/following{/other_user}",
"gists_url": "https://api.github.com/users/adamatan/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/adamatan",
"id": 1014189,
"login": "adamatan",
"node_id": "MDQ6VXNlcjEwMTQxODk=",
"organizations_url": "https://api.github.com/users/adamatan/orgs",
"received_events_url": "https://api.github.com/users/adamatan/received_events",
"repos_url": "https://api.github.com/users/adamatan/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/adamatan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adamatan/subscriptions",
"type": "User",
"url": "https://api.github.com/users/adamatan",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2015-09-18T11:58:19Z
|
2015-09-18T23:55:02Z
|
2015-09-18T23:54:57Z
|
NONE
| null |
# The problem
I have been trying to make a GET request to https://service.isracard.co.il/I_logon.jsp using requests.
The site seems to have a valid SSL certificate (see screenshots below), and cURL can get the content without a problem.
However, requests fails to fetch the site with a `sslv3 alert handshake failure` error.
# Notes
- I have asked [a stackoverflow question about this problem](https://stackoverflow.com/questions/32650984/why-does-python-requests-ignore-the-verify-parameter)
- The original problem happened when I was using mechanize, which uses `requests` internally.
- The problem happens both on OSX and Ubuntu 14.04.
- The same call worked for me a few months ago. I assume that the server side was somehow changed.
- SSL connections to other sites (e.g. github) work fine.
# Stack Trace
```
>>> import requests
>>> LOGIN_URL = 'https://service.isracard.co.il/I_logon.jsp'
>>> requests.get(LOGIN_URL)
/tmp/blahenv/local/lib/python2.7/site-packages/requests/packages/urllib3/util/ssl_.py:90: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
InsecurePlatformWarning
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/tmp/blahenv/local/lib/python2.7/site-packages/requests/api.py", line 69, in get
return request('get', url, params=params, **kwargs)
File "/tmp/blahenv/local/lib/python2.7/site-packages/requests/api.py", line 50, in request
response = session.request(method=method, url=url, **kwargs)
File "/tmp/blahenv/local/lib/python2.7/site-packages/requests/sessions.py", line 465, in request
resp = self.send(prep, **send_kwargs)
File "/tmp/blahenv/local/lib/python2.7/site-packages/requests/sessions.py", line 573, in send
r = adapter.send(request, **kwargs)
File "/tmp/blahenv/local/lib/python2.7/site-packages/requests/adapters.py", line 431, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: [Errno 1] _ssl.c:510: error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure
```
# Certificate
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2778/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2778/timeline
| null |
completed
| null | null | false |
[
"Have you tried the approach suggested in [this blog post](https://lukasa.co.uk/2013/01/Choosing_SSL_Version_In_Requests/)?\n",
"So I took a quick look\n\n```\n$ openssl version\nOpenSSL 1.0.2d 9 Jul 2015\n$ openssl s_client -connect service.isracard.co.il:443 -no_ssl2 -no_ssl3 -no_tls1 -no_tls1_1\n# Works\n$ openssl s_client -connect service.isracard.co.il:443 -no_tls1_2\n# Works\n$ openssl s_client -connect service.isracard.co.il:443 -no_tls1_2 -no_tls1_1\n# Works\n$ openssl s_client -connect service.isracard.co.il:443 -no_tls1_2 -no_tls1_1 -no_tls1\n# Fails\n```\n\nSo using something like what @Lukasa has suggested should work. Note: the adapter that @Lukasa references in his blog post is also available in the [requests-toolbelt](https://toolbelt.readthedocs.org/en/latest/adapters.html#ssladapter).\n",
"@Lukasa @sigmavirus24 Thanks a bunch for the advice! I've used the adapters, and:\n- Python code works on Ubuntu machines but fails with `SSLV3_ALERT_HANDSHAKE_FAILURE` on OSX\n- `openssl s_client -connect service.isracard.co.il:443 -no_ssl2 -no_ssl3 -no_tls1 -no_tls1_1` works on the OSX machine, with `OpenSSL 1.0.2d 9 Jul 2015`\n\nIt's probably out of the `requests` scope, but any idea how to fix this on OSX? The obvious solution seems to be upgrading openSSL version, but it's already upgraded to a pretty new version. Is Python using the same OpenSSL binaries as the command line tools, or is there a way to upgrade the libraries to a working version?\n",
"@adamatan well that depends on how you've installed Python on OSX. If you used brew and installed that after installing OpenSSL 1.0.2d then Python _should_ be using that. You can check that with \n\n```\n$ python -c 'import ssl; print(ssl.OPENSSL_VERSION)'\n```\n\nSince that's the case, I'm going to close this. Feel free to pop into IRC for better help debugging your OpenSSL problems.\n"
] |
https://api.github.com/repos/psf/requests/issues/2777
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2777/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2777/comments
|
https://api.github.com/repos/psf/requests/issues/2777/events
|
https://github.com/psf/requests/issues/2777
| 106,957,516 |
MDU6SXNzdWUxMDY5NTc1MTY=
| 2,777 |
Withholding a post body in AuthBase until a security context has been established
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1713677?v=4",
"events_url": "https://api.github.com/users/ianclegg/events{/privacy}",
"followers_url": "https://api.github.com/users/ianclegg/followers",
"following_url": "https://api.github.com/users/ianclegg/following{/other_user}",
"gists_url": "https://api.github.com/users/ianclegg/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ianclegg",
"id": 1713677,
"login": "ianclegg",
"node_id": "MDQ6VXNlcjE3MTM2Nzc=",
"organizations_url": "https://api.github.com/users/ianclegg/orgs",
"received_events_url": "https://api.github.com/users/ianclegg/received_events",
"repos_url": "https://api.github.com/users/ianclegg/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ianclegg/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ianclegg/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ianclegg",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-09-17T10:42:09Z
|
2021-09-08T22:00:48Z
|
2015-09-17T10:46:15Z
|
NONE
|
resolved
|
**Background**
I'm working with a server which uses SPNEGO/GSS authentication, to keep it simple lets say the GSS mechanism is NTLM. As usual, the client and server exchange tokens to establish the context. What's different here is that once the context is established I want wrap (encrypt) the request body using the negotiated GSS context (in this case it would use NTLMv2 Session Security) and send it.
The authentication and encryption is not a problem. I'm using AuthBase and a response hook to exchange the tokens in the authenticate header.
**Problem**
My AuthBase derived class is sending the plaintext request body every time during the token exchange. I only want to send it in its encrypted form on the final exchange.
Looking at the PizzaAuth example on the Requests page:
``` python
from requests.auth import AuthBase
class PizzaAuth(AuthBase):
"""Attaches HTTP Pizza Authentication to the given Request object."""
def __init__(self, username):
# setup any auth-related data here
self.username = username
def __call__(self, r):
# !! = !! = !! = !! = !! = !! = !! = !! = !! = !! = !! = !! =
# I want to manipulate the request body here and ensure the request
# that is returned is empty, or is otherwise encrypted
# !! = !! = !! = !! = !! = !! = !! = !! = !! = !! = !! = !! =
r.headers['X-Pizza'] = self.username
return r
```
If I change the request body to an empty string
`r.body = ""`
I find that the remote server does not respond. This is because I have changed the body, but the Content-Length header is not re-calculated, and so my empty request is sent with a non-zero content-length - leaving the server waiting for more bytes. Now, I can also set the Body and the Content-Length header to zero - and that seems to work.
**Question**
Is is safe to manipulate the request body in AuthBase, will this cause a memory leak or any quality problems? Is it safe to simply set the body to an empty string and set the Content-Length to 0 until my final response, and then simply set the body and set the right content length?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2777/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2777/timeline
| null |
completed
| null | null | false |
[
"Yes, it is safe to set the request body. This will not cause memory leaks because we do not have any reference deletion anywhere in requests' codebase. Leaking the reference to the body will be absolutely fine. Yes, it should be safe to simply set the body to an empty string and set the content-length appropriately, then set them back on the final response.\n\nNote that this is one possible approach. Another approach would be to issue new requests in `__call__`.\n\nIn future, these questions are better asked on StackOverflow: the users there have much higher bandwidth to provide quality answers to questions like this one.\n",
"Thanks Lukasa!\n"
] |
https://api.github.com/repos/psf/requests/issues/2776
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2776/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2776/comments
|
https://api.github.com/repos/psf/requests/issues/2776/events
|
https://github.com/psf/requests/issues/2776
| 106,265,260 |
MDU6SXNzdWUxMDYyNjUyNjA=
| 2,776 |
SSLError when use Pyinstaller
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1305553?v=4",
"events_url": "https://api.github.com/users/zotix/events{/privacy}",
"followers_url": "https://api.github.com/users/zotix/followers",
"following_url": "https://api.github.com/users/zotix/following{/other_user}",
"gists_url": "https://api.github.com/users/zotix/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zotix",
"id": 1305553,
"login": "zotix",
"node_id": "MDQ6VXNlcjEzMDU1NTM=",
"organizations_url": "https://api.github.com/users/zotix/orgs",
"received_events_url": "https://api.github.com/users/zotix/received_events",
"repos_url": "https://api.github.com/users/zotix/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zotix/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zotix/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zotix",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2015-09-14T03:34:49Z
|
2021-09-08T15:00:41Z
|
2015-09-14T03:37:28Z
|
NONE
|
resolved
|
I try to mix my python desktop app to exe file. When execute without compiler is OK but EXE it show error as below
```
Exception in Tkinter callback
Traceback (most recent call last):
File "C:\try\build\main\out00-PYZ.pyz\Tkinter", line 1536, in __call__
File "<string>", line 154, in on_btn_download
File "C:\try\build\main\out00-PYZ.pyz\usgsDownloader", line 57, in search
File "C:\try\build\main\out00-PYZ.pyz\usgs.api", line 302, in search
File "C:\try\build\main\out00-PYZ.pyz\requests.api", line 109, in post
File "C:\try\build\main\out00-PYZ.pyz\requests.api", line 50, in request
File "C:\try\build\main\out00-PYZ.pyz\requests.sessions", line 465, in request
File "C:\try\build\main\out00-PYZ.pyz\requests.sessions", line 573, in send
File "C:\try\build\main\out00-PYZ.pyz\requests.adapters", line 431, in send
SSLError: [Errno 2] No such file or directory
```
Compile command
```
C:\try>pyinstaller -F --hidden-import=requests main.py
```
What should I fix it? thank
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2776/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2776/timeline
| null |
completed
| null | null | false |
[
"This is not a bug in requests. This is a bug in PyInstaller since it doesn't know how to detect static package data (e.g., the certificate bundle that requests is packaged with).\n",
"Thanks sigmavirus24 for giving a hint.\n\nFix this by http://stackoverflow.com/questions/21201238/twilio-python-module-errors-after-compiling/21206079#21206079\n",
"I too have the trouble with Pyinstaller and Requests. Thanks folks for posting the question and for pointing us in the right direction, much appreciated! \n"
] |
https://api.github.com/repos/psf/requests/issues/2775
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2775/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2775/comments
|
https://api.github.com/repos/psf/requests/issues/2775/events
|
https://github.com/psf/requests/pull/2775
| 106,209,319 |
MDExOlB1bGxSZXF1ZXN0NDQ4NzA2ODI=
| 2,775 |
Removed unused module from hooks.py
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3393794?v=4",
"events_url": "https://api.github.com/users/ueg1990/events{/privacy}",
"followers_url": "https://api.github.com/users/ueg1990/followers",
"following_url": "https://api.github.com/users/ueg1990/following{/other_user}",
"gists_url": "https://api.github.com/users/ueg1990/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ueg1990",
"id": 3393794,
"login": "ueg1990",
"node_id": "MDQ6VXNlcjMzOTM3OTQ=",
"organizations_url": "https://api.github.com/users/ueg1990/orgs",
"received_events_url": "https://api.github.com/users/ueg1990/received_events",
"repos_url": "https://api.github.com/users/ueg1990/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ueg1990/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ueg1990/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ueg1990",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-09-13T10:36:42Z
|
2021-09-08T06:01:02Z
|
2015-09-13T12:26:05Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2775/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2775/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2775.diff",
"html_url": "https://github.com/psf/requests/pull/2775",
"merged_at": "2015-09-13T12:26:05Z",
"patch_url": "https://github.com/psf/requests/pull/2775.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2775"
}
| true |
[
"Thanks @ueg1990! :cake:\n",
"You know someone's going to complain that they were using `hooks.defaultdict` now, right? ;)\n"
] |
|
https://api.github.com/repos/psf/requests/issues/2774
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2774/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2774/comments
|
https://api.github.com/repos/psf/requests/issues/2774/events
|
https://github.com/psf/requests/pull/2774
| 106,192,661 |
MDExOlB1bGxSZXF1ZXN0NDQ4NjQyOTU=
| 2,774 |
Some pythonic suggestions for requests/hooks.py
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3393794?v=4",
"events_url": "https://api.github.com/users/ueg1990/events{/privacy}",
"followers_url": "https://api.github.com/users/ueg1990/followers",
"following_url": "https://api.github.com/users/ueg1990/following{/other_user}",
"gists_url": "https://api.github.com/users/ueg1990/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ueg1990",
"id": 3393794,
"login": "ueg1990",
"node_id": "MDQ6VXNlcjMzOTM3OTQ=",
"organizations_url": "https://api.github.com/users/ueg1990/orgs",
"received_events_url": "https://api.github.com/users/ueg1990/received_events",
"repos_url": "https://api.github.com/users/ueg1990/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ueg1990/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ueg1990/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ueg1990",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-09-13T00:42:11Z
|
2021-09-08T06:01:02Z
|
2015-09-13T05:05:34Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2774/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2774/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2774.diff",
"html_url": "https://github.com/psf/requests/pull/2774",
"merged_at": "2015-09-13T05:05:34Z",
"patch_url": "https://github.com/psf/requests/pull/2774.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2774"
}
| true |
[
"these look pretty good to me! :sparkles: :cake: :sparkles:\n"
] |
|
https://api.github.com/repos/psf/requests/issues/2773
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2773/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2773/comments
|
https://api.github.com/repos/psf/requests/issues/2773/events
|
https://github.com/psf/requests/issues/2773
| 106,176,479 |
MDU6SXNzdWUxMDYxNzY0Nzk=
| 2,773 |
option to disable .netrc
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/141546?v=4",
"events_url": "https://api.github.com/users/jwilk/events{/privacy}",
"followers_url": "https://api.github.com/users/jwilk/followers",
"following_url": "https://api.github.com/users/jwilk/following{/other_user}",
"gists_url": "https://api.github.com/users/jwilk/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jwilk",
"id": 141546,
"login": "jwilk",
"node_id": "MDQ6VXNlcjE0MTU0Ng==",
"organizations_url": "https://api.github.com/users/jwilk/orgs",
"received_events_url": "https://api.github.com/users/jwilk/received_events",
"repos_url": "https://api.github.com/users/jwilk/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jwilk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jwilk/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jwilk",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 16 |
2015-09-12T18:12:09Z
|
2021-09-08T07:00:24Z
|
2017-09-01T09:54:41Z
|
CONTRIBUTOR
|
resolved
|
I don't want my applications to read `.netrc` files, because they are [inherently insecure](http://jwilk.net/blog/20131104-netrc-security).
I know there's (undocumented) `trust_env=False`, but it also turns off support for `*_proxy` environment variables.
Please add a separate option to disable `.netrc` support.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2773/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2773/timeline
| null |
completed
| null | null | false |
[
"@jwilk This is certainly a thing we could do. However, it's a bizarrely application specific fix that will not actually help in a lot of cases because applications that use requests will need to opt-in to that functionality. This means they need to know enough to do that, which is not likely.\n\nReally from a security perspective we should switch to disable netrc auth by default (a change that would need to wait until a 3.0.0 release because it's backwards incompatible, though potentially something worth doing).\n\nIn the short term, you will get more security either by not using `~/.netrc` files at all (thereby removing the source of the vulnerability altogether) or by constructing AppArmor profiles that limit access to the file to those applications you have pre-authorized to use it.\n\n@sigmavirus24 For the longer term, I'm open to swapping our default here, which is arguably somewhat insecure, though I also just think people shouldn't be writing their passwords down anywhere at all, at least not in plaintext.\n",
"@Lukasa isn't there already an open issue for turning auto-loading of netrc off by default for 3.0.0? I thought we were in agreement on this already. I've never once thought this was a good idea but we haven't had opportunity to break this behaviour previously.\n\nI'd also be okay moving `get_netrc_auth` (or whatever the function is actually called) into the `auth` module and documenting it publicly.\n",
"Quite possibly. \n\nMoving `get_netrc_auth` to `auth` could work, but it hurts the redirec case unless we turn it into some fancier kind of auth handler. \n",
"`NetrcAuth` class then?\n",
"Then we can leave the function in utils and have the auth handler do the hard work\n",
"Suits me. Do we need the ability to have multiple auth handlers?\n",
"to work around this, i added a way to disable authentication:\n\n``` python\nclass NullAuth(requests.auth.AuthBase):\n '''force requests to ignore the ``.netrc``\n\n Some sites do not support regular authentication, but we still\n want to store credentials in the ``.netrc`` file and submit them\n as form elements. Without this, requests would otherwise use the\n .netrc which leads, on some sites, to a 401 error.\n\n Use with::\n\n requests.get(url, auth=NullAuth())\n '''\n\n def __call__(self, r):\n return r\n```\n\nCould that be added in an earlier release? It won't break API...\n",
"@anarcat That works fine as a user-specific workaround, but we won't ship it in requests itself.\n",
"FWIW, you can disable this functionality today with `trust_env`. Due to strong opinions I had when I started this project, its default is set to `true`. \n\n```\ns = requests.session()\ns.trust_env = False\n\nr = s.get(...)\n```\n\nThe idea was that `.netrc` is a well-adopted standard that tools like curl utilize automatically, therefore I wanted Requests to honor it automatically as well. If a user was concerned with that security implication, they shouldn't trust their environment at all, and I provided an option for them to do so. \n\nSetting `trust_env` to `false` may be a good next step. It's one of those things, though, that if it doesn't work automatically out-of-the-box, then there's really no point in having the functionality at all. \n",
"On 2016-01-31 04:05:17, Kenneth Reitz wrote:\n\n> FWIW, you can disable this functionality today with `trust_env`. Due to strong opinions I had when I started this project, it's default is set to `true`. \n> \n> ```\n> s = requests.Session()\n> s.trust_env = False\n> \n> r = s.get(...)\n> ```\n> \n> The idea was that `.netrc` is a well-adopted standard that tools like curl utilize automatically, therefore I wanted Requests to honor it automatically as well. If a user was concerned with that security implication, they shouldn't trust their environment at all, and I provided an option for them to do so. \n> \n> Setting `trust_env` to `false` may be a good next step. It's one of those things, though, that if it doesn't work automatically out-of-the-box, then there's really no point in having the functionality at all. \n\nThe problem with trust_env is that it works too broadly. For example, it\nalso disables proxy configuration... \"and similar\", according to the\ndocs. It should be made clear what, exactly, is disabled there and\nideally, those bits should be possible to disable one at a time.\n\nAnd I think it's fine that requests support .netrc by default, it makes\nperfect sense. It should just be easier to disable it.\n\nA.\n\n## \n\nLa démocratie réelle se définit d'abord et avant tout par la\nparticipation massive des citoyens à la gestion des affaires de la cité.\nElle est directe et participative. Elle trouve son expression la plus\nauthentique dans l'assemblée populaire et le dialogue permanent sur\nl'organisation de la vie en commun. - De la servitude moderne\n",
"i got the same problem, Is there way to solve it",
"```\r\ns = requests.session()\r\ns.trust_env = False\r\n```",
"i will use proxy info, whether not it will influence it",
"If you set the proxies from environment variables then yes. ",
"so , finally, I detele the .netrc",
"I'm not sure why this was closed. The only rationale I had so far was that `trust_env` can be used to disable this, but the problem with that is that is also disables proxy configuration... not just the .netrc...\r\n\r\nor should I send a PR to document my NullAuth workaround?"
] |
https://api.github.com/repos/psf/requests/issues/2772
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2772/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2772/comments
|
https://api.github.com/repos/psf/requests/issues/2772/events
|
https://github.com/psf/requests/pull/2772
| 106,061,121 |
MDExOlB1bGxSZXF1ZXN0NDQ4MTA2NzU=
| 2,772 |
Move CA Certificates documentation next to SSL Cert Verification
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240575?v=4",
"events_url": "https://api.github.com/users/jimbrowne/events{/privacy}",
"followers_url": "https://api.github.com/users/jimbrowne/followers",
"following_url": "https://api.github.com/users/jimbrowne/following{/other_user}",
"gists_url": "https://api.github.com/users/jimbrowne/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jimbrowne",
"id": 240575,
"login": "jimbrowne",
"node_id": "MDQ6VXNlcjI0MDU3NQ==",
"organizations_url": "https://api.github.com/users/jimbrowne/orgs",
"received_events_url": "https://api.github.com/users/jimbrowne/received_events",
"repos_url": "https://api.github.com/users/jimbrowne/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jimbrowne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jimbrowne/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jimbrowne",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-09-11T17:56:06Z
|
2021-09-08T06:01:02Z
|
2015-09-11T19:22:13Z
|
CONTRIBUTOR
|
resolved
|
When reading the SSL Cert Verification documentation and working on directing requests to use a system's local CA store I never noticed the CA Certificates documentation as it is at the tail end of the Advanced page. I suggest it would be better to have the CA Certificates documentation immediately follow the documentation regarding SSL Cert Verification.
No content change, just a relocation of existing verbiage.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2772/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2772/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2772.diff",
"html_url": "https://github.com/psf/requests/pull/2772",
"merged_at": "2015-09-11T19:22:13Z",
"patch_url": "https://github.com/psf/requests/pull/2772.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2772"
}
| true |
[
"Thanks @jimbrowne! :cake: :sparkles: :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/2771
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2771/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2771/comments
|
https://api.github.com/repos/psf/requests/issues/2771/events
|
https://github.com/psf/requests/issues/2771
| 106,038,732 |
MDU6SXNzdWUxMDYwMzg3MzI=
| 2,771 |
Please add absolute_import at the beginning of every file
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/860977?v=4",
"events_url": "https://api.github.com/users/co-dh/events{/privacy}",
"followers_url": "https://api.github.com/users/co-dh/followers",
"following_url": "https://api.github.com/users/co-dh/following{/other_user}",
"gists_url": "https://api.github.com/users/co-dh/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/co-dh",
"id": 860977,
"login": "co-dh",
"node_id": "MDQ6VXNlcjg2MDk3Nw==",
"organizations_url": "https://api.github.com/users/co-dh/orgs",
"received_events_url": "https://api.github.com/users/co-dh/received_events",
"repos_url": "https://api.github.com/users/co-dh/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/co-dh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/co-dh/subscriptions",
"type": "User",
"url": "https://api.github.com/users/co-dh",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 13 |
2015-09-11T15:53:01Z
|
2021-09-08T19:00:37Z
|
2016-01-25T23:05:56Z
|
NONE
|
resolved
|
I have an import warning:
```
site-packages/requests/utils.py:17: ImportWarning: Not importing directory '/home/x/platform'
missing __init__.py
import platform
```
so my directory: platform hided system module platform.py
This can only be fixed by adding
`from __future__ import absolute_import` at the first line of utils.py
Also it would be nice to have this for every module.
This should do no harm to python 3.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2771/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2771/timeline
| null |
completed
| null | null | false |
[
"This is not a totally unreasonable thing to do, though it's totally tragic that we need it: if we didn't support Python 2.6 this wouldn't be a problem. @sigmavirus24?\n",
"So I have done this before to debug other problems. The major issue is that it doesn't protect urllib3 so if someone shadows another standard library module locally, they will still have this problem. I'm +0 on the change (and to be clear this is only not an issue on Python 3+) but I don't think it will help people too much who already aren't following best practices for module naming, i.e., not shadowing standard library modules.\n",
"I'm working in a company that we have python and c++ code site together,\nand the c++ guys definitely don't care or know about standard python\npackage name.\n\nShadowing another standard library is another problem.\n\nOn Sat, Sep 12, 2015 at 10:07 AM, Ian Cordasco [email protected]\nwrote:\n\n> So I have done this before to debug other problems. The major issue is\n> that it doesn't protect urllib3 so if someone shadows another standard\n> library module locally, they will still have this problem. I'm +0 on the\n> change (and to be clear this is only not an issue on Python 3+) but I don't\n> think it will help people too much who already aren't following best\n> practices for module naming, i.e., not shadowing standard library modules.\n> \n> —\n> Reply to this email directly or view it on GitHub\n> https://github.com/kennethreitz/requests/issues/2771#issuecomment-139774010\n> .\n",
"> I'm working in a company that we have python and c++ code site together, and the c++ guys definitely don't care or know about standard python package name. \n\nIf the C++ code is used in Python then perhaps your company needs a naming convention such that this doesn't happen. If your C++ developers don't care about not causing problems in the languages they're being consumed from then I'd say find new C++ developers because the ones your company has hired have some serious attitude problems.\n\n> Shadowing another standard library is another problem.\n\nFor example, if your company starts shadowing `socket`, `httplib`, `http.client`, `ssl`, `OpenSSL`, `threading`, `collections` or countless others, the protections in requests would only go so far because urllib3 imports those and doesn't also use this. Getting every upstream dependency of yours to use this will likely be more work than just fixing your corporate development process. Also, note that we're not against this change, I'm just being realistic about exactly how helpful it will be for people who carelessly shadow standard library modules.\n",
"The C++ developer is our CEO and I like this company.\nI agree with you that fixing every upstream dependency would be not\npossible, and this seemed to be a python 2 problem that cannot be fixed.\n\nIt's still unrealistic to check every standard library modules' name before\nmake a directory.\n\nRegards.\n\nOn Mon, Sep 14, 2015 at 9:40 AM, Ian Cordasco [email protected]\nwrote:\n\n> I'm working in a company that we have python and c++ code site together,\n> and the c++ guys definitely don't care or know about standard python\n> package name.\n> \n> If the C++ code is used in Python then perhaps your company needs a naming\n> convention such that this doesn't happen. If your C++ developers don't care\n> about not causing problems in the languages they're being consumed from\n> then I'd say find new C++ developers because the ones your company has\n> hired have some serious attitude problems.\n> \n> Shadowing another standard library is another problem.\n> \n> For example, if your company starts shadowing socket, httplib, http.client,\n> ssl, OpenSSL, threading, collections or countless others, the protections\n> in requests would only go so far because urllib3 imports those and doesn't\n> also use this. Getting every upstream dependency of yours to use this will\n> likely be more work than just fixing your corporate development process.\n> Also, note that we're not against this change, I'm just being realistic\n> about exactly how helpful it will be for people who carelessly shadow\n> standard library modules.\n> \n> —\n> Reply to this email directly or view it on GitHub\n> https://github.com/kennethreitz/requests/issues/2771#issuecomment-140078395\n> .\n",
"@shazow If I open a PR that does this for urllib3, would you merge it?\n",
"No strong feelings about this, I'd merge it if you think it's a good idea. :)\n",
"I think it's probably a good idea. It runs the risk of breaking people who are doing really sketchy crap on Python 2, like attempting to alias stdlib modules by having specially named modules on the import path, but...I feel like that's ok?\n",
"Worth a shot, we can always revert once people inevitably complain. :P\n",
"@Lukasa it's getting late by you, want me to tackle this tonight?\n",
"There's no rush, I'm happy to do it tomorrow, but if you're looking for something to occupy you then feel free to pick it up. =)\n",
"I had already done this and stashed it previously, so it was a matter of popping that and committing it. See also: https://github.com/shazow/urllib3/pull/735\n",
"This seems like an already solved issue too, so perhaps it's worth closing? \n"
] |
https://api.github.com/repos/psf/requests/issues/2770
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2770/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2770/comments
|
https://api.github.com/repos/psf/requests/issues/2770/events
|
https://github.com/psf/requests/pull/2770
| 105,944,115 |
MDExOlB1bGxSZXF1ZXN0NDQ3NDYxNzk=
| 2,770 |
Use context manager for Session
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3393794?v=4",
"events_url": "https://api.github.com/users/ueg1990/events{/privacy}",
"followers_url": "https://api.github.com/users/ueg1990/followers",
"following_url": "https://api.github.com/users/ueg1990/following{/other_user}",
"gists_url": "https://api.github.com/users/ueg1990/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ueg1990",
"id": 3393794,
"login": "ueg1990",
"node_id": "MDQ6VXNlcjMzOTM3OTQ=",
"organizations_url": "https://api.github.com/users/ueg1990/orgs",
"received_events_url": "https://api.github.com/users/ueg1990/received_events",
"repos_url": "https://api.github.com/users/ueg1990/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ueg1990/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ueg1990/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ueg1990",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-09-11T04:42:27Z
|
2021-09-08T06:01:03Z
|
2015-09-11T06:15:28Z
|
CONTRIBUTOR
|
resolved
|
Since a context manager is defined for session, i thought it would be better (and more pythonic) to use it. All the tests passed. Let me know what you guys think
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2770/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2770/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2770.diff",
"html_url": "https://github.com/psf/requests/pull/2770",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2770.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2770"
}
| true |
[
"I'm afraid we actually don't want this.\n\nThe use-case is extremely uncommon, but it's possible that if an exception is hit during request processing that a user may want to keep hold of state from the connection pool or urllib3 layer. Using the context manager potentially prevents that by forcing the Session closed.\n\nBasically, remember that a context manager is not the same as this:\n\n``` python\nobj = something()\nobj.action()\nobj.close()\n```\n\nIt's the same as this:\n\n``` python\nobj = something()\n\ntry:\n obj.action()\nfinally:\n obj.close()\n```\n"
] |
https://api.github.com/repos/psf/requests/issues/2769
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2769/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2769/comments
|
https://api.github.com/repos/psf/requests/issues/2769/events
|
https://github.com/psf/requests/pull/2769
| 105,894,643 |
MDExOlB1bGxSZXF1ZXN0NDQ3MTc0MTg=
| 2,769 |
docs: Fix typos
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/141546?v=4",
"events_url": "https://api.github.com/users/jwilk/events{/privacy}",
"followers_url": "https://api.github.com/users/jwilk/followers",
"following_url": "https://api.github.com/users/jwilk/following{/other_user}",
"gists_url": "https://api.github.com/users/jwilk/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jwilk",
"id": 141546,
"login": "jwilk",
"node_id": "MDQ6VXNlcjE0MTU0Ng==",
"organizations_url": "https://api.github.com/users/jwilk/orgs",
"received_events_url": "https://api.github.com/users/jwilk/received_events",
"repos_url": "https://api.github.com/users/jwilk/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jwilk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jwilk/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jwilk",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-09-10T20:48:37Z
|
2021-09-08T06:00:51Z
|
2015-09-10T21:14:11Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2769/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2769/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2769.diff",
"html_url": "https://github.com/psf/requests/pull/2769",
"merged_at": "2015-09-10T21:14:11Z",
"patch_url": "https://github.com/psf/requests/pull/2769.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2769"
}
| true |
[
"Thanks @jwilk! :cake: :sparkles: :cake:\n"
] |
|
https://api.github.com/repos/psf/requests/issues/2768
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2768/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2768/comments
|
https://api.github.com/repos/psf/requests/issues/2768/events
|
https://github.com/psf/requests/pull/2768
| 105,891,152 |
MDExOlB1bGxSZXF1ZXN0NDQ3MTQ5OTk=
| 2,768 |
Replace hardcoded class with dunder class attribute
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3393794?v=4",
"events_url": "https://api.github.com/users/ueg1990/events{/privacy}",
"followers_url": "https://api.github.com/users/ueg1990/followers",
"following_url": "https://api.github.com/users/ueg1990/following{/other_user}",
"gists_url": "https://api.github.com/users/ueg1990/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ueg1990",
"id": 3393794,
"login": "ueg1990",
"node_id": "MDQ6VXNlcjMzOTM3OTQ=",
"organizations_url": "https://api.github.com/users/ueg1990/orgs",
"received_events_url": "https://api.github.com/users/ueg1990/received_events",
"repos_url": "https://api.github.com/users/ueg1990/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ueg1990/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ueg1990/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ueg1990",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 6 |
2015-09-10T20:26:51Z
|
2021-09-08T06:01:03Z
|
2015-09-10T22:01:59Z
|
CONTRIBUTOR
|
resolved
|
Small suggestion as this was something I heard in Raymond Hettinger's talk at PyCon 2015
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2768/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2768/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2768.diff",
"html_url": "https://github.com/psf/requests/pull/2768",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2768.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2768"
}
| true |
[
"Btw if this is accepted, i can do it for the other modules/python files...in that way i can also read some of the requests code :stuck_out_tongue: \n",
"I certainly want the change in `super` removed: as pointed out in the diff comment by @jmoldow, that isn't valid. Otherwise, I suspect it makes the class somewhat more subclass-friendly, which I don't object to. \n",
"i am not sure why this is considered invalid. can you elaborate?\n",
"There is a reason that `super()` requires two arguments. It's because the first argument can't be deduced from `self`, because the first argument isn't (in general) `self.__class__`.\n\nIf you have a method-resolution order C -> B -> A -> object, `C.__init__` is going to call `super(C, self).__init__`, which will call `B.__init__`, which will call `super(B, self).__init__`, which will call `A.__init__`. The only call where the first argument is `self.__class__` is the first one, but you don't know in advance what will even be the first one.\n\nThe first argument needs to be the hard-coded class name, in order for super to figure out what the super object should refer to.\n",
"Actually `__class__` and `self.__class__` are a whole different level of magic that will thoroughly break this for any subclass. Sorry @ueg1990 this is not something I will allow in requests.\n",
"lol i do not have any objection to that. learnt something new in python :)\nonto the next pull request\n"
] |
https://api.github.com/repos/psf/requests/issues/2767
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2767/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2767/comments
|
https://api.github.com/repos/psf/requests/issues/2767/events
|
https://github.com/psf/requests/pull/2767
| 105,852,961 |
MDExOlB1bGxSZXF1ZXN0NDQ2OTMwMTk=
| 2,767 |
Remove redundant function call list when iterating over status codes
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3393794?v=4",
"events_url": "https://api.github.com/users/ueg1990/events{/privacy}",
"followers_url": "https://api.github.com/users/ueg1990/followers",
"following_url": "https://api.github.com/users/ueg1990/following{/other_user}",
"gists_url": "https://api.github.com/users/ueg1990/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ueg1990",
"id": 3393794,
"login": "ueg1990",
"node_id": "MDQ6VXNlcjMzOTM3OTQ=",
"organizations_url": "https://api.github.com/users/ueg1990/orgs",
"received_events_url": "https://api.github.com/users/ueg1990/received_events",
"repos_url": "https://api.github.com/users/ueg1990/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ueg1990/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ueg1990/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ueg1990",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-09-10T17:01:47Z
|
2021-09-08T06:01:04Z
|
2015-09-10T17:38:25Z
|
CONTRIBUTOR
|
resolved
|
Refer to issue [2765](https://github.com/kennethreitz/requests/issues/2765)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2767/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2767/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2767.diff",
"html_url": "https://github.com/psf/requests/pull/2767",
"merged_at": "2015-09-10T17:38:25Z",
"patch_url": "https://github.com/psf/requests/pull/2767.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2767"
}
| true |
[
"yay!!! :D\n",
"Thanks @ueg1990! :cake: :sparkles: :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/2766
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2766/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2766/comments
|
https://api.github.com/repos/psf/requests/issues/2766/events
|
https://github.com/psf/requests/issues/2766
| 105,808,876 |
MDU6SXNzdWUxMDU4MDg4NzY=
| 2,766 |
Document threading contract for Session class
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/51437?v=4",
"events_url": "https://api.github.com/users/gward/events{/privacy}",
"followers_url": "https://api.github.com/users/gward/followers",
"following_url": "https://api.github.com/users/gward/following{/other_user}",
"gists_url": "https://api.github.com/users/gward/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gward",
"id": 51437,
"login": "gward",
"node_id": "MDQ6VXNlcjUxNDM3",
"organizations_url": "https://api.github.com/users/gward/orgs",
"received_events_url": "https://api.github.com/users/gward/received_events",
"repos_url": "https://api.github.com/users/gward/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gward/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gward/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gward",
"user_view_type": "public"
}
|
[
{
"color": "fad8c7",
"default": false,
"description": null,
"id": 136616769,
"name": "Documentation",
"node_id": "MDU6TGFiZWwxMzY2MTY3Njk=",
"url": "https://api.github.com/repos/psf/requests/labels/Documentation"
}
] |
closed
| false | null |
[] | null | 13 |
2015-09-10T13:44:25Z
|
2024-11-06T16:38:06Z
|
2024-05-19T18:38:20Z
|
NONE
| null |
Right now, it's quite difficult to figure out if the Session class is threadsafe or not. The docs don't say, apart from a "thread-safe" bullet on the home page. Google led me to http://stackoverflow.com/questions/18188044/is-the-session-object-from-pythons-requests-library-thread-safe, whose first answer boils down to "be very careful".
Inspired by that SO author, I've been auditing the code myself, and have come to the conclusion that Session is probably not threadsafe. (The use of `self.redirect_cache` set off red flags for me.) Reading through other requests bug reports, I see maintainers recommending one Session per thread, which implies that it's not threadsafe.
The documentation should clarify this and recommend how to use Session in multithreaded programs. Possible text:
```
Session is not threadsafe. If you are using requests with an explicit Session
object in a multithreaded program, you should create one Session per thread.
```
If that's accurate, let me know and I'll submit a PR.
Also, I think the "thread-safe" bullet should be removed from the home page, or maybe replaced by "thread-safe in certain circumstances".
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
}
|
{
"+1": 73,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 8,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 81,
"url": "https://api.github.com/repos/psf/requests/issues/2766/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2766/timeline
| null |
completed
| null | null | false |
[
"Why do you think the redirect cache is not threadsafe?\n",
"I'd go further: I think the redirect cache is a bad idea. I still think that.\n\nI think re-adding thread-safety would be a good idea. We can get away with it, I think, by locking around the CookieJar (which should be the only other thing that is a risk here). That's a cheap-and-easy way to get something approximating thread safety, even if it doesn't necessarily get great performance.\n",
"It would be pretty cool if `requests.Session` was guarateed to be safe.\n\nThis would make [that sort of code](https://github.com/fprimex/zdesk/blob/master/zdesk/zdesk.py#L70) safe by default.\n\nThis sounds better than pestering every maintainer of every API client based on requests to make their Session objects thread-local :-)\n\nI don't expect a large overhead from locking around writes to the cookie jar. Requests is supposed to spend most of its time waiting for I/O.\n",
"The cookie jar, sadly, is not the only concern: the entire Session class needs auditing for thread safety. It's not a bad idea, it's just a matter of finding someone with the time to spare to do it. =)\n",
"Sounds like someone should write a tool that makes this really easy :P\n",
"What is the motivation for the \"thread-safety\" bullet point on the main page? I can't find the word \"thread\" almost anywhere in the documentation and definitely nothing about thread safety. This issue alongside several others indicate that the session is not actually thread-safe. The bullet point really should be removed as it seems unfounded right now.",
"I've opened an issue with urllib3 as the main underlying issue appears to be with PoolManager and HTTPConnectionPool, both of which are part of urllib3 and not requests.\r\nhttps://github.com/shazow/urllib3/issues/1252",
"From what I can tell, @reversefold's PR culminated with https://github.com/urllib3/urllib3/pull/1263, but looking at the work he did, it didn't sound impossible. So assuming we can fix that, what is the current state of thread safety in `requests`? I know that the redirect cache was removed in https://github.com/kennethreitz/requests/pull/4100, but @Lukasa mentioned that the whole `Session` class needs to be audited, is this something I could help with?\r\n\r\nAs a general question, is this downprioritized in favor of `async` stuff like https://github.com/kennethreitz/requests/issues/1390? (And if so, should I put my full attention there as well? 😉)\r\n\r\n(For future reference, the note about thread safety was removed in 66293b830a8b9507a458d26e305664bf4ea03d55)",
"Any official word on this? There's been a lot of foundational work in urllib3 to be thread safe, is the official recommendation still \"[one session per thread](https://github.com/psf/requests/issues/1871#issuecomment-32751346)\"? ",
"I too would like an official statement on this.",
"> I've opened an issue with urllib3 as the main underlying issue appears to be with PoolManager and HTTPConnectionPool, both of which are part of urllib3 and not requests. [urllib3/urllib3#1252](https://github.com/urllib3/urllib3/issues/1252)\r\n\r\nlooks like urllib is thread safe now: https://github.com/urllib3/urllib3/pull/2661",
"Closing this until a separate threading issue is shown in Requests, please open a new issue if that's the case.",
"Trying one last time:\r\n\r\nIs the official statement that using a single session object from multiple threads simultaneously is **intended** to be safe, we have a reasonable belief that it is, and that any cases where this is not true is considered to be a bug?"
] |
https://api.github.com/repos/psf/requests/issues/2765
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2765/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2765/comments
|
https://api.github.com/repos/psf/requests/issues/2765/events
|
https://github.com/psf/requests/issues/2765
| 105,736,737 |
MDU6SXNzdWUxMDU3MzY3Mzc=
| 2,765 |
Redundant creation of list?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3393794?v=4",
"events_url": "https://api.github.com/users/ueg1990/events{/privacy}",
"followers_url": "https://api.github.com/users/ueg1990/followers",
"following_url": "https://api.github.com/users/ueg1990/following{/other_user}",
"gists_url": "https://api.github.com/users/ueg1990/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ueg1990",
"id": 3393794,
"login": "ueg1990",
"node_id": "MDQ6VXNlcjMzOTM3OTQ=",
"organizations_url": "https://api.github.com/users/ueg1990/orgs",
"received_events_url": "https://api.github.com/users/ueg1990/received_events",
"repos_url": "https://api.github.com/users/ueg1990/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ueg1990/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ueg1990/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ueg1990",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 5 |
2015-09-10T05:51:42Z
|
2021-09-08T22:00:49Z
|
2015-09-10T18:05:36Z
|
CONTRIBUTOR
|
resolved
|
Hello, I came across this code under status_codes.py:
for (code, titles) in list(_codes.items()):
for title in titles:
setattr(codes, title, code)
if not title.startswith('\'):
setattr(codes, title.upper(), code)
in the first line (the outermost loop), i think the list(_codes.items()) step is redundant. it should just be iterating over _codes.items(). what i am not sure is if the items method here returns a list (python 2) or an iterator/generator (python 3). if its the former, maybe its better to loop over _codes.iteritems(). In either case, you do not really need to convert it to a list.
Though this is a very small issue, if its worth doing a PR, I can do it. (in that way, i can contribute my first PR to the requests library :) )
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3393794?v=4",
"events_url": "https://api.github.com/users/ueg1990/events{/privacy}",
"followers_url": "https://api.github.com/users/ueg1990/followers",
"following_url": "https://api.github.com/users/ueg1990/following{/other_user}",
"gists_url": "https://api.github.com/users/ueg1990/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ueg1990",
"id": 3393794,
"login": "ueg1990",
"node_id": "MDQ6VXNlcjMzOTM3OTQ=",
"organizations_url": "https://api.github.com/users/ueg1990/orgs",
"received_events_url": "https://api.github.com/users/ueg1990/received_events",
"repos_url": "https://api.github.com/users/ueg1990/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ueg1990/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ueg1990/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ueg1990",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2765/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2765/timeline
| null |
completed
| null | null | false |
[
"Thanks @ueg1990! I think you're right: feel free to provide a pull request. =)\n",
"## To be clear: please do not use iteritems. Just remove the use of list()\n\nSent from my Android device with K-9 Mail. Please excuse my brevity.\n",
"I will send the pull request today. But i am curious, why should we not use iteritems?\n",
"@ueg1990 It doesn't exist in Python 3. =) Given that this is a one-time operation, we don't care too much about the one-off memory allocation for the temporary list on Python 2.\n",
"oh yeah make sense. \n"
] |
https://api.github.com/repos/psf/requests/issues/2764
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2764/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2764/comments
|
https://api.github.com/repos/psf/requests/issues/2764/events
|
https://github.com/psf/requests/pull/2764
| 105,497,251 |
MDExOlB1bGxSZXF1ZXN0NDQ1MDA2MjE=
| 2,764 |
minor refactoring to function
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/6500837?v=4",
"events_url": "https://api.github.com/users/suhussai/events{/privacy}",
"followers_url": "https://api.github.com/users/suhussai/followers",
"following_url": "https://api.github.com/users/suhussai/following{/other_user}",
"gists_url": "https://api.github.com/users/suhussai/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/suhussai",
"id": 6500837,
"login": "suhussai",
"node_id": "MDQ6VXNlcjY1MDA4Mzc=",
"organizations_url": "https://api.github.com/users/suhussai/orgs",
"received_events_url": "https://api.github.com/users/suhussai/received_events",
"repos_url": "https://api.github.com/users/suhussai/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/suhussai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/suhussai/subscriptions",
"type": "User",
"url": "https://api.github.com/users/suhussai",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2015-09-09T01:05:06Z
|
2021-09-08T06:01:06Z
|
2015-09-09T01:13:32Z
|
NONE
|
resolved
|
I was just looking through the code base and noticed this small "improvement" I could make. Is the focus more on readability or is this kind of refactoring acceptable as well? I understand that this format does decrease readability a little bit, so I didn't look into it too much, thought I'd get feedback first.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2764/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2764/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2764.diff",
"html_url": "https://github.com/psf/requests/pull/2764",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2764.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2764"
}
| true |
[
"Dictionary comprehensions were introduced in Python 2.7. Prior to that they are invalid syntax, e.g., for Python 2.5 and 2.6, both of which are supported versions for ~~pep8~~ requests. \n\nThanks for contributing though @suhussai!\n\nPerhaps you could look through the bugs and find one that doesn't have a linked PR to try to work on.\n\nCheers,\nIan!\n\n**Edit** I said pep8 but I meant requests. I clearly can't keep my projects straight anymore. :(\n",
"Your right, I noticed that in the tests. Even though dictionary comprehension isn't supported directly in python2.6, this format works according to http://stackoverflow.com/questions/1747817/python-create-a-dictionary-with-list-comprehension:\n\n```\ndict((cookie.name, cookie.value) for cookie in cj)\n```\n\nI installed python2.6/2.5 and ran an example program using that format, and it worked as expected. Do we want to include this other format, which is supported by at least python 2.5 and greater?\n",
"So `dict()` is actually bizarrely slow. That said, being a style issue I don't think we're concerned enough to change it.\n",
"Ah, I didn't know that. Thanks for the information.\n"
] |
https://api.github.com/repos/psf/requests/issues/2763
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2763/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2763/comments
|
https://api.github.com/repos/psf/requests/issues/2763/events
|
https://github.com/psf/requests/pull/2763
| 105,337,897 |
MDExOlB1bGxSZXF1ZXN0NDQ0MDkzNzg=
| 2,763 |
Fixed issue #2756
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/4507088?v=4",
"events_url": "https://api.github.com/users/ravipra/events{/privacy}",
"followers_url": "https://api.github.com/users/ravipra/followers",
"following_url": "https://api.github.com/users/ravipra/following{/other_user}",
"gists_url": "https://api.github.com/users/ravipra/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ravipra",
"id": 4507088,
"login": "ravipra",
"node_id": "MDQ6VXNlcjQ1MDcwODg=",
"organizations_url": "https://api.github.com/users/ravipra/orgs",
"received_events_url": "https://api.github.com/users/ravipra/received_events",
"repos_url": "https://api.github.com/users/ravipra/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ravipra/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ravipra/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ravipra",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 8 |
2015-09-08T09:19:51Z
|
2021-09-08T05:01:00Z
|
2015-10-05T14:27:53Z
|
NONE
|
resolved
|
Now 'json' parameter will be used to prepare body only if the 'data'
parameter is not present
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2763/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2763/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2763.diff",
"html_url": "https://github.com/psf/requests/pull/2763",
"merged_at": "2015-10-05T14:27:53Z",
"patch_url": "https://github.com/psf/requests/pull/2763.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2763"
}
| true |
[
"One minor comment, otherwise I'm fine. =)\n",
"With `if data is None` I get the following test failure. Please advice.\n\n```\n|======================================================================\nERROR: test_json_param_post_content_type_works (__main__.RequestsTestCase)\n----------------------------------------------------------------------\nTraceback (most recent call last):\n File \"test_requests.py\", line 1062, in \ntest_json_param_post_content_type_works\n assert 'application/json' in r.request.headers['Content-Type']\n File \"/home/ravi/oss/requests-temp/requests/structures.py\", line 54, \nin __getitem__\n return self._store[key.lower()][1]\nKeyError: 'content-type'\n\n----------------------------------------------------------------------\nRan 148 tests in 85.057s\n\nFAILED (errors=1)\n```\n\nOn Tuesday 08 September 2015 08:24 PM, Cory Benfield wrote:\n\n> One minor comment, otherwise I'm fine. =)\n> \n> —\n> Reply to this email directly or view it on GitHub \n> https://github.com/kennethreitz/requests/pull/2763#issuecomment-138591292.\n",
"Ugh, you're right, our code sets data to the empty dict. Nevermind, I rescind that feedback. This LGTM, @sigmavirus24?\n",
":+1:\n",
"The documentation also needs to be updated.\nThe `files` also supersedes `json` as already pointed out by @taion in comments of #2756 \n",
"@sumitbinnani I'd happily accept a pull request that adds only that documentation change.\n",
"This looks okay to me. How about you @Lukasa? We should probably not have this pending after having merged the documentation for next week.\n",
"I'm happy for us to merge this in for 2.8.0.\n"
] |
https://api.github.com/repos/psf/requests/issues/2762
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2762/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2762/comments
|
https://api.github.com/repos/psf/requests/issues/2762/events
|
https://github.com/psf/requests/issues/2762
| 105,288,881 |
MDU6SXNzdWUxMDUyODg4ODE=
| 2,762 |
Post requests to more complex HTML elements
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/11060902?v=4",
"events_url": "https://api.github.com/users/aewhatley/events{/privacy}",
"followers_url": "https://api.github.com/users/aewhatley/followers",
"following_url": "https://api.github.com/users/aewhatley/following{/other_user}",
"gists_url": "https://api.github.com/users/aewhatley/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/aewhatley",
"id": 11060902,
"login": "aewhatley",
"node_id": "MDQ6VXNlcjExMDYwOTAy",
"organizations_url": "https://api.github.com/users/aewhatley/orgs",
"received_events_url": "https://api.github.com/users/aewhatley/received_events",
"repos_url": "https://api.github.com/users/aewhatley/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/aewhatley/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aewhatley/subscriptions",
"type": "User",
"url": "https://api.github.com/users/aewhatley",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 5 |
2015-09-08T02:35:16Z
|
2021-09-08T22:00:49Z
|
2015-09-08T03:39:42Z
|
NONE
|
resolved
|
Does the requests module support post requests to more complex HTML elements where values cannot be accessed just by dictionary lookup? For example, say we have the following HTML code, which is present on most Wikipedia pages to support the text of the article:
</div><textarea tabindex="1" accesskey="," id="wpTextbox1" cols="80" rows="25" style="" lang="en" dir="ltr" name="wpTextbox1">
(body of the article)
</textarea><div class='editOptions'>
Is there a way to access the part that says (body of the article) using the requests API, and post to it? I tried 'wpTextbox1' : '' in the dictionary, but this did not work.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2762/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2762/timeline
| null |
completed
| null | null | false |
[
"Sorry, the HTML headers got messed up by the Github reply form, and I'm not sure how to post them to this page.\n",
"Here's a link to my Stackoverflow post of the same question, which has gotten not substantial replies: http://stackoverflow.com/questions/32447809/use-python-requests-to-access-mediawiki-text\n",
"This is not a support forum. Please be patient with the stack overflow community\n",
"While I understand that this is not a support forum, my experience with Github issues forums is that they also discuss possible improvements to APIs as well as documentation pages. Given that changing the values of more complex HTML elements is a task that should come up fairly often, I would think that this might be something you would add to your current API, if not already, or if it is possible already, described to some detail in your documentation page. I am not trying to be rude, just pointing out some facts......\n",
"Except that requests is an HTTP library, not an HTML library. We don't parse HTML for the user, nor will we ever. This seems to have been [explained to you](http://stackoverflow.com/a/32448030/1953283) already but you ignored it. The question you should ask in response to that answer is \"Then what do I use to scrape the HTML.\" That's not something I'll answer for you here because Google can give you many better options and I am not Google.\n"
] |
https://api.github.com/repos/psf/requests/issues/2761
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2761/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2761/comments
|
https://api.github.com/repos/psf/requests/issues/2761/events
|
https://github.com/psf/requests/pull/2761
| 105,248,284 |
MDExOlB1bGxSZXF1ZXN0NDQzNzE5NDQ=
| 2,761 |
Fix for Json supersedes data in prepare_body #2756
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/4507088?v=4",
"events_url": "https://api.github.com/users/ravipra/events{/privacy}",
"followers_url": "https://api.github.com/users/ravipra/followers",
"following_url": "https://api.github.com/users/ravipra/following{/other_user}",
"gists_url": "https://api.github.com/users/ravipra/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ravipra",
"id": 4507088,
"login": "ravipra",
"node_id": "MDQ6VXNlcjQ1MDcwODg=",
"organizations_url": "https://api.github.com/users/ravipra/orgs",
"received_events_url": "https://api.github.com/users/ravipra/received_events",
"repos_url": "https://api.github.com/users/ravipra/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ravipra/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ravipra/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ravipra",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-09-07T17:12:31Z
|
2021-09-08T06:01:06Z
|
2015-09-07T17:16:38Z
|
NONE
|
resolved
|
Now json will be attached to the body only if data is not present.
(I hope the fix is not more complicated than this.)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/4507088?v=4",
"events_url": "https://api.github.com/users/ravipra/events{/privacy}",
"followers_url": "https://api.github.com/users/ravipra/followers",
"following_url": "https://api.github.com/users/ravipra/following{/other_user}",
"gists_url": "https://api.github.com/users/ravipra/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ravipra",
"id": 4507088,
"login": "ravipra",
"node_id": "MDQ6VXNlcjQ1MDcwODg=",
"organizations_url": "https://api.github.com/users/ravipra/orgs",
"received_events_url": "https://api.github.com/users/ravipra/received_events",
"repos_url": "https://api.github.com/users/ravipra/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ravipra/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ravipra/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ravipra",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2761/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2761/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2761.diff",
"html_url": "https://github.com/psf/requests/pull/2761",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2761.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2761"
}
| true |
[
"Tests are failing. Will figure out how to run the tests, fix it and will resubmit. Apologies for the trouble!\n"
] |
https://api.github.com/repos/psf/requests/issues/2760
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2760/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2760/comments
|
https://api.github.com/repos/psf/requests/issues/2760/events
|
https://github.com/psf/requests/issues/2760
| 105,241,572 |
MDU6SXNzdWUxMDUyNDE1NzI=
| 2,760 |
Log in to Wikipedia not working
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/11060902?v=4",
"events_url": "https://api.github.com/users/aewhatley/events{/privacy}",
"followers_url": "https://api.github.com/users/aewhatley/followers",
"following_url": "https://api.github.com/users/aewhatley/following{/other_user}",
"gists_url": "https://api.github.com/users/aewhatley/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/aewhatley",
"id": 11060902,
"login": "aewhatley",
"node_id": "MDQ6VXNlcjExMDYwOTAy",
"organizations_url": "https://api.github.com/users/aewhatley/orgs",
"received_events_url": "https://api.github.com/users/aewhatley/received_events",
"repos_url": "https://api.github.com/users/aewhatley/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/aewhatley/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aewhatley/subscriptions",
"type": "User",
"url": "https://api.github.com/users/aewhatley",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-09-07T16:06:15Z
|
2021-09-08T22:00:50Z
|
2015-09-07T16:17:31Z
|
NONE
|
resolved
|
I'm trying to log into Wikipedia using the following code:
import requests
s = requests.Session()
url = 'https://en.wikipedia.org/w/index.php?title=Special:UserLogin&returnto=Main+Page'
values = {'wpName' : '.....',
'wpPassword' : '.....'}
s.get(url)
req = s.post(url, values)
print(req.cookies)
print(req.url)
However, it does not work. The req.url is the same as the login page (https://en.wikipedia.org/w/index.php?title=Special:UserLogin&returnto=Main+Page), and the cookie jar is empty. Does the MediaWiki software block the requests module, or am I doing something wrong?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2760/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2760/timeline
| null |
completed
| null | null | false |
[
"Your URL is wrong.\n\nPlease open the page in your browser and enable your browser developer tools, and then try the login yourself. You'll note that the POST target is actually `https://en.wikipedia.org/w/index.php?title=Special:UserLogin&action=submitlogin&type=login&returnto=Main+Page`, not the URL you used (which is missing the `action=submitlogin&type=login` portions.\n\nAdditionally, your form is missing some values. My test (username 'test', password 'testpass') ends up sending the following values:\n\n```\nwpName:test\nwpPassword:testpass\nwpLoginAttempt:Log in\nwpLoginToken:3cc5dc5e021f5790ad020deced537681\nwpForceHttps:1\nwpFromhttp:\n```\n\nThe loginToken, in particular, is something you'll need to scrape out of the page. I'm not going to provide instructions here because this is a bug tracker, not a generalised help forum: if you need more specific advice I'd recommend using [StackOverflow](https://stackoverflow.com/).\n"
] |
https://api.github.com/repos/psf/requests/issues/2759
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2759/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2759/comments
|
https://api.github.com/repos/psf/requests/issues/2759/events
|
https://github.com/psf/requests/issues/2759
| 105,102,996 |
MDU6SXNzdWUxMDUxMDI5OTY=
| 2,759 |
python3: does not un-gzip replies
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/236571?v=4",
"events_url": "https://api.github.com/users/smurfix/events{/privacy}",
"followers_url": "https://api.github.com/users/smurfix/followers",
"following_url": "https://api.github.com/users/smurfix/following{/other_user}",
"gists_url": "https://api.github.com/users/smurfix/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/smurfix",
"id": 236571,
"login": "smurfix",
"node_id": "MDQ6VXNlcjIzNjU3MQ==",
"organizations_url": "https://api.github.com/users/smurfix/orgs",
"received_events_url": "https://api.github.com/users/smurfix/received_events",
"repos_url": "https://api.github.com/users/smurfix/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/smurfix/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/smurfix/subscriptions",
"type": "User",
"url": "https://api.github.com/users/smurfix",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2015-09-06T16:37:11Z
|
2021-09-08T22:00:50Z
|
2015-09-08T07:33:35Z
|
NONE
|
resolved
|
It seems that (at least) a 403 response with gzipped body is expanded when running Python2, but not so with Py3.
```
desk ~/src/librssreader$ python run.py
AppId required! Contact app developer. See http://www.inoreader.com/developers
[ traceback because of unrelated missing error check ]
desk ~/src/librssreader$ python3 run.py
[[[ binary gibberish ]]]
[ same traceback ]
desk ~/src/librssreader$
```
run.py is simply:
```
#!/usr/bin/python3
from librssreader.inoreader import RssReader, ClientAuthMethod
auth = ClientAuthMethod('USERNAME','CENSORED')
reader = RssReader(auth)
print(reader.getUserInfo())
```
You need to register with inoreader.com (or find another web server) before testing this.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2759/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2759/timeline
| null |
completed
| null | null | false |
[
"Requests has no logic relating to response code that should affect whether or not the body of the request is expanded. If you read the content, you should get the gzip expanded. My money is that the 403 response does not include a Content-Encoding header. Can you show me the request/response please (sanitising secure headers if needed)?\n",
"Found it. The reply header looks like this:\n\n```\nHTTP/1.1 403 Forbidden\nServer: nginx/1.7.9\nDate: Mon, 07 Sep 2015 17:20:42 GMT\nContent-Type: text/html; charset=UTF-8\nContent-Length: 90\nConnection: keep-alive\nX-Powered-By: PHP/5.4.41\nX-Content-Type-Options: nosniff\nX-Frame-Options: SAMEORIGIN\nX-Reader-Google-Version: 555-000\nX-XSS-Protection: 1; mode=block\nAppId required! Contact app developer. See http: //www.inoreader.com/developers\nVary: Accept-Encoding,User-Agent\nContent-Encoding: gzip\n\n[gzipped content]\n```\n\nObviously the problem here is that Requests, on Python2, manages to ignore the inserted line of nonsense (note how the sender's server cleverly inserted a space after the colon), while on Python3 it does not.\nI'll send them a bug report.\n\nStill, there should not be inconsistent behavior between Py2 and Py3 versions.\n",
"So the header parsing is done by httplib (on Python 2, renamed to http.client on Python 3). This is a bug in the standard library, not in requests.\n\nWe cannot control the dependencies that are far beneath us (like the standard library).\n",
"Yup, unfortunately there's nothing we can really do about this at the moment, until such time as we stop using `httplib` to do the low-lying HTTP stuff for us.\n\nI am extremely sorry about this. In the short term, I recommend you contact the server provider if possible and tell them to stop sending that nonsense in the HTTP headers (or at least to give the HTTP header a proper key).\n"
] |
https://api.github.com/repos/psf/requests/issues/2758
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2758/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2758/comments
|
https://api.github.com/repos/psf/requests/issues/2758/events
|
https://github.com/psf/requests/pull/2758
| 105,018,377 |
MDExOlB1bGxSZXF1ZXN0NDQyODAyODQ=
| 2,758 |
Fix RFC Quotation
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1019198?v=4",
"events_url": "https://api.github.com/users/mhils/events{/privacy}",
"followers_url": "https://api.github.com/users/mhils/followers",
"following_url": "https://api.github.com/users/mhils/following{/other_user}",
"gists_url": "https://api.github.com/users/mhils/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mhils",
"id": 1019198,
"login": "mhils",
"node_id": "MDQ6VXNlcjEwMTkxOTg=",
"organizations_url": "https://api.github.com/users/mhils/orgs",
"received_events_url": "https://api.github.com/users/mhils/received_events",
"repos_url": "https://api.github.com/users/mhils/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mhils/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mhils/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mhils",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-09-05T10:08:59Z
|
2021-09-08T06:01:07Z
|
2015-09-05T21:01:39Z
|
CONTRIBUTOR
|
resolved
|
Minor nitpick: The quote in http://www.python-requests.org/en/latest/user/quickstart/#response-headers is currently not formatted properly. This PR fixes this.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2758/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2758/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2758.diff",
"html_url": "https://github.com/psf/requests/pull/2758",
"merged_at": "2015-09-05T21:01:39Z",
"patch_url": "https://github.com/psf/requests/pull/2758.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2758"
}
| true |
[
"Fantastic @mhils! Thanks! :cake: :sparkles: :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/2757
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2757/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2757/comments
|
https://api.github.com/repos/psf/requests/issues/2757/events
|
https://github.com/psf/requests/pull/2757
| 105,008,959 |
MDExOlB1bGxSZXF1ZXN0NDQyNzc4MTE=
| 2,757 |
Add PreparedRequest pickling tests
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/6401746?v=4",
"events_url": "https://api.github.com/users/keyan/events{/privacy}",
"followers_url": "https://api.github.com/users/keyan/followers",
"following_url": "https://api.github.com/users/keyan/following{/other_user}",
"gists_url": "https://api.github.com/users/keyan/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/keyan",
"id": 6401746,
"login": "keyan",
"node_id": "MDQ6VXNlcjY0MDE3NDY=",
"organizations_url": "https://api.github.com/users/keyan/orgs",
"received_events_url": "https://api.github.com/users/keyan/received_events",
"repos_url": "https://api.github.com/users/keyan/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/keyan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/keyan/subscriptions",
"type": "User",
"url": "https://api.github.com/users/keyan",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 5 |
2015-09-05T06:33:55Z
|
2021-09-08T04:01:08Z
|
2016-04-06T19:15:38Z
|
CONTRIBUTOR
|
resolved
|
Trying to address #1558 by first creating a failing test, but I'm not sure when `PreparedRequest`s fail to be pickleable. Pulling early to see if anyone has suggestions on how to re-create the issue, also maybe these tests are useful on their own as well.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2757/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2757/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2757.diff",
"html_url": "https://github.com/psf/requests/pull/2757",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2757.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2757"
}
| true |
[
"Thanks @keyan! From the issue:\n\n> On a prepared request, the only thing I think can hurt us is the case when the body attribute is a file object. Is there a specific hook that we're concerned about not being pickleable?\n\nSo the concerns seem to be body file objects and hooks.\n",
"@keyan do you have intentions to update this with the tests we were looking to add?\n",
"Hey @sigmavirus24, I could use some advice on how to add a file object in the test environment. I just added a commit with a failing test containing a hook. Not sure how to address the actual issue though.\n",
"@keyan It is often easiest to just create a file handle to the file under test: `open(__file__)`.\n",
"Closing due to inactivity, (now) merge conflict, and failing tests. These look very much needed though, so please open another PR when ready to proceed!\n"
] |
https://api.github.com/repos/psf/requests/issues/2756
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2756/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2756/comments
|
https://api.github.com/repos/psf/requests/issues/2756/events
|
https://github.com/psf/requests/issues/2756
| 104,987,769 |
MDU6SXNzdWUxMDQ5ODc3Njk=
| 2,756 |
Json supersedes data in prepare_body
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3417501?v=4",
"events_url": "https://api.github.com/users/xEtherealx/events{/privacy}",
"followers_url": "https://api.github.com/users/xEtherealx/followers",
"following_url": "https://api.github.com/users/xEtherealx/following{/other_user}",
"gists_url": "https://api.github.com/users/xEtherealx/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/xEtherealx",
"id": 3417501,
"login": "xEtherealx",
"node_id": "MDQ6VXNlcjM0MTc1MDE=",
"organizations_url": "https://api.github.com/users/xEtherealx/orgs",
"received_events_url": "https://api.github.com/users/xEtherealx/received_events",
"repos_url": "https://api.github.com/users/xEtherealx/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/xEtherealx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xEtherealx/subscriptions",
"type": "User",
"url": "https://api.github.com/users/xEtherealx",
"user_view_type": "public"
}
|
[
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
},
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"name": "Contributor Friendly",
"node_id": "MDU6TGFiZWwxOTEyNzQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Contributor%20Friendly"
}
] |
closed
| true | null |
[] | null | 4 |
2015-09-04T23:44:09Z
|
2021-09-08T22:00:44Z
|
2015-10-06T14:52:47Z
|
NONE
|
resolved
|
When not a stream, json supersedes data in prepare_body:
https://github.com/kennethreitz/requests/blob/f5dacf84468ab7e0631cc61a3f1431a32e3e143c/requests/models.py#L446
This conflicts with the docstring, which indicates that json is only used when data is not specified:
https://github.com/kennethreitz/requests/blob/f5dacf84468ab7e0631cc61a3f1431a32e3e143c/requests/models.py#L195
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2756/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2756/timeline
| null |
completed
| null | null | false |
[
"Thanks for this! Yes, that's well spotted: we're definitely in conflict with the documented behaviour.\n",
"I may try to find someone who wants to get started in requests to see if they want to fix this: it's a perfect fix for someone relatively new to OSS.\n",
"BTW, `files` also supersedes `json` - the docs could use a small update there.\n",
"This is resolved in 2.8.0. Thanks all!\n"
] |
https://api.github.com/repos/psf/requests/issues/2755
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2755/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2755/comments
|
https://api.github.com/repos/psf/requests/issues/2755/events
|
https://github.com/psf/requests/issues/2755
| 104,783,245 |
MDU6SXNzdWUxMDQ3ODMyNDU=
| 2,755 |
allow custom JSONEncoder for the request's json param
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/165819?v=4",
"events_url": "https://api.github.com/users/drmaples/events{/privacy}",
"followers_url": "https://api.github.com/users/drmaples/followers",
"following_url": "https://api.github.com/users/drmaples/following{/other_user}",
"gists_url": "https://api.github.com/users/drmaples/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/drmaples",
"id": 165819,
"login": "drmaples",
"node_id": "MDQ6VXNlcjE2NTgxOQ==",
"organizations_url": "https://api.github.com/users/drmaples/orgs",
"received_events_url": "https://api.github.com/users/drmaples/received_events",
"repos_url": "https://api.github.com/users/drmaples/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/drmaples/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/drmaples/subscriptions",
"type": "User",
"url": "https://api.github.com/users/drmaples",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 5 |
2015-09-03T21:14:09Z
|
2021-09-08T22:00:51Z
|
2015-09-03T21:20:34Z
|
NONE
|
resolved
|
Using the [json param](http://docs.python-requests.org/en/latest/api/?highlight=json#requests.request) when making a request is awesome:
``` python
payload = {'blip': 'blaz'}
r = requests.get('http://foo.bar', json=payload)
```
Using the [response property](http://docs.python-requests.org/en/latest/api/#requests.Response.json) is great as well, especially since you can use a custom json decoder:
``` python
r.json(cls=MyCustomDecoder)
```
It would be nice to allow a param to be passed that could be applied to the `dumps` of the [json value](https://github.com/kennethreitz/requests/blob/master/requests/models.py#L417-L419).
``` python
payload = {'blip': Decimal(69)}
json_params = {'cls': MyCustomEncoder}
r = requests.get('http://foo.bar', json=payload, json_params=json_params)
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2755/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2755/timeline
| null |
completed
| null | null | false |
[
"I think this is interesting, but generally requests is very averse to adding new keyword arguments to `requests.*`. I don't think it's valuable enough to justify adding the new argument, I'm afraid. Sorry!\n",
"Is there a better way to always use a custom json encoder? This way is brittle and gross and does not even work with stuff in master (fine for 2.7.0).\n\n``` python\nimport json\nimport functools\nfrom decimal import Decimal\n\nimport requests\n\n\nclass CustomJSONEncoder(json.JSONEncoder):\n def default(self, obj):\n if isinstance(obj, Decimal):\n return round(float(obj), 2)\n return json.JSONEncoder.default(self, obj)\n\n# yuck\nrequests.models.json_dumps = functools.partial(json.dumps, cls=CustomJSONEncoder)\n\nr = requests.post('http://foo.bar', json={'foo': Decimal(69)})\n```\n",
"I think the better way is to manually use it yourself:\n\n``` python\nr = requests.post('http://foo.bar', data=json.dumps(some_data, cls=CustomJSONEncoder), headers={'Content-Type': 'application/json'})\n```\n",
"Yep, I am already doing it that way. Was wanting a way to globally have it use a specific encoder/decoder when messing with json\n",
"@drmaples then make a function that handles that \"globally\" for yourself. We won't be introducing this.\n"
] |
https://api.github.com/repos/psf/requests/issues/2754
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2754/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2754/comments
|
https://api.github.com/repos/psf/requests/issues/2754/events
|
https://github.com/psf/requests/pull/2754
| 104,215,667 |
MDExOlB1bGxSZXF1ZXN0NDM4NTAwMjc=
| 2,754 |
Fix unicode redirects on Python 3.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] |
{
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
}
| 13 |
2015-09-01T08:35:36Z
|
2021-09-08T04:01:06Z
|
2016-04-15T21:39:18Z
|
MEMBER
|
resolved
|
Resolves #2653.
Follows on from #2655: please read the discussion there for more information.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2754/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2754/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2754.diff",
"html_url": "https://github.com/psf/requests/pull/2754",
"merged_at": "2016-04-15T21:39:18Z",
"patch_url": "https://github.com/psf/requests/pull/2754.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2754"
}
| true |
[
":+1:\n",
"there's a lot of pending merges — trying hard not to merge them :)\n",
"@kennethreitz You're doing an admirable job. ;)\n",
"Soon™\n",
"Oh right, this is for 3.0.0... did we have a test for this? If not I'm :+1: \n",
"I don't think we do, though I can see if I can create one.\n",
"Tests are nice :-P\n",
"Ok, got some extra tests for `unquote_unreserved`, which is a start.\n",
"And a failing test for the original issue, which now passes. It's only valid on Python 3, so I added a skip for Python 2.\n\nUnfortunately, this now requires a more up-to-date py.test version.\n",
"Hurrah! All tests green. Over to you @sigmavirus24.\n",
"One tiny comment. I'd like your thoughts on it (not necessarily action unless you agree). Otherwise :+1: \n",
"Rebase required. \n",
"Rebased.\n"
] |
https://api.github.com/repos/psf/requests/issues/2753
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2753/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2753/comments
|
https://api.github.com/repos/psf/requests/issues/2753/events
|
https://github.com/psf/requests/pull/2753
| 104,017,682 |
MDExOlB1bGxSZXF1ZXN0NDM3NDY0MjU=
| 2,753 |
Document the string form of the verify parameter.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2015-08-31T09:26:44Z
|
2021-09-08T06:01:08Z
|
2015-09-01T01:34:11Z
|
MEMBER
|
resolved
|
Just a little bit of extra example documentation.
Resolves #2652.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2753/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2753/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2753.diff",
"html_url": "https://github.com/psf/requests/pull/2753",
"merged_at": "2015-09-01T01:34:11Z",
"patch_url": "https://github.com/psf/requests/pull/2753.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2753"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/2752
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2752/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2752/comments
|
https://api.github.com/repos/psf/requests/issues/2752/events
|
https://github.com/psf/requests/issues/2752
| 103,971,198 |
MDU6SXNzdWUxMDM5NzExOTg=
| 2,752 |
Upgrade urllib3 to 1.11
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/90853?v=4",
"events_url": "https://api.github.com/users/thanatos/events{/privacy}",
"followers_url": "https://api.github.com/users/thanatos/followers",
"following_url": "https://api.github.com/users/thanatos/following{/other_user}",
"gists_url": "https://api.github.com/users/thanatos/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/thanatos",
"id": 90853,
"login": "thanatos",
"node_id": "MDQ6VXNlcjkwODUz",
"organizations_url": "https://api.github.com/users/thanatos/orgs",
"received_events_url": "https://api.github.com/users/thanatos/received_events",
"repos_url": "https://api.github.com/users/thanatos/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/thanatos/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/thanatos/subscriptions",
"type": "User",
"url": "https://api.github.com/users/thanatos",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-08-31T01:45:25Z
|
2021-09-08T22:00:55Z
|
2015-08-31T01:57:42Z
|
NONE
|
resolved
|
I'm running into [the following bug](https://github.com/pypa/pip/issues/2753) in `pip`:
```
File "/usr/lib/python2.7/httplib.py", line 780, in close
self.sock.close() # close it manually... there may be other refs
File "/…/pip/pip/_vendor/requests/packages/urllib3/contrib/pyopenssl.py", line 213, in close
return self.connection.shutdown()
File "/…/OpenSSL/SSL.py", line 1522, in shutdown
File "/…/OpenSSL/SSL.py", line 1178, in _raise_ssl_error
SysCallError: (32, 'EPIPE')
```
This is caused by [a bug in urllib3](https://github.com/shazow/urllib3/issues/612); urllib3 has since [patched](https://github.com/shazow/urllib3/commit/90946207d2aedd41fcfcf8e6d68b07fa5a834ada) the bug, but pip can't get the patch until requests upgrades their copy of urllib3.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2752/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2752/timeline
| null |
completed
| null | null | false |
[
"We'll hopefully be creating a release soon. When that happens we'll upgrade our version of urllib3.\n"
] |
https://api.github.com/repos/psf/requests/issues/2751
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2751/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2751/comments
|
https://api.github.com/repos/psf/requests/issues/2751/events
|
https://github.com/psf/requests/pull/2751
| 103,822,899 |
MDExOlB1bGxSZXF1ZXN0NDM2ODY3OTY=
| 2,751 |
Add link to ES translation.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3130883?v=4",
"events_url": "https://api.github.com/users/carlosvargas/events{/privacy}",
"followers_url": "https://api.github.com/users/carlosvargas/followers",
"following_url": "https://api.github.com/users/carlosvargas/following{/other_user}",
"gists_url": "https://api.github.com/users/carlosvargas/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/carlosvargas",
"id": 3130883,
"login": "carlosvargas",
"node_id": "MDQ6VXNlcjMxMzA4ODM=",
"organizations_url": "https://api.github.com/users/carlosvargas/orgs",
"received_events_url": "https://api.github.com/users/carlosvargas/received_events",
"repos_url": "https://api.github.com/users/carlosvargas/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/carlosvargas/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/carlosvargas/subscriptions",
"type": "User",
"url": "https://api.github.com/users/carlosvargas",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-08-29T02:19:45Z
|
2021-09-08T06:01:08Z
|
2015-08-29T12:21:07Z
|
CONTRIBUTOR
|
resolved
|
Fixes #2750
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2751/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2751/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2751.diff",
"html_url": "https://github.com/psf/requests/pull/2751",
"merged_at": "2015-08-29T12:21:07Z",
"patch_url": "https://github.com/psf/requests/pull/2751.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2751"
}
| true |
[
"Thanks @carlosvargas \n"
] |
https://api.github.com/repos/psf/requests/issues/2750
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2750/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2750/comments
|
https://api.github.com/repos/psf/requests/issues/2750/events
|
https://github.com/psf/requests/issues/2750
| 103,822,877 |
MDU6SXNzdWUxMDM4MjI4Nzc=
| 2,750 |
Spanish translation is missing from documentation sidebar
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3130883?v=4",
"events_url": "https://api.github.com/users/carlosvargas/events{/privacy}",
"followers_url": "https://api.github.com/users/carlosvargas/followers",
"following_url": "https://api.github.com/users/carlosvargas/following{/other_user}",
"gists_url": "https://api.github.com/users/carlosvargas/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/carlosvargas",
"id": 3130883,
"login": "carlosvargas",
"node_id": "MDQ6VXNlcjMxMzA4ODM=",
"organizations_url": "https://api.github.com/users/carlosvargas/orgs",
"received_events_url": "https://api.github.com/users/carlosvargas/received_events",
"repos_url": "https://api.github.com/users/carlosvargas/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/carlosvargas/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/carlosvargas/subscriptions",
"type": "User",
"url": "https://api.github.com/users/carlosvargas",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2015-08-29T02:18:36Z
|
2021-09-08T22:00:55Z
|
2015-08-29T12:21:07Z
|
CONTRIBUTOR
|
resolved
|
Now that http://es.python-requests.org/ has been set up, a link to it needs to be added in the documentation sidebar, along the other languages.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2750/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2750/timeline
| null |
completed
| null | null | false |
[] |
https://api.github.com/repos/psf/requests/issues/2749
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2749/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2749/comments
|
https://api.github.com/repos/psf/requests/issues/2749/events
|
https://github.com/psf/requests/issues/2749
| 103,699,976 |
MDU6SXNzdWUxMDM2OTk5NzY=
| 2,749 |
form data encoding can't be modifid
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1189879?v=4",
"events_url": "https://api.github.com/users/pynixwang/events{/privacy}",
"followers_url": "https://api.github.com/users/pynixwang/followers",
"following_url": "https://api.github.com/users/pynixwang/following{/other_user}",
"gists_url": "https://api.github.com/users/pynixwang/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pynixwang",
"id": 1189879,
"login": "pynixwang",
"node_id": "MDQ6VXNlcjExODk4Nzk=",
"organizations_url": "https://api.github.com/users/pynixwang/orgs",
"received_events_url": "https://api.github.com/users/pynixwang/received_events",
"repos_url": "https://api.github.com/users/pynixwang/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pynixwang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pynixwang/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pynixwang",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2015-08-28T11:10:08Z
|
2021-09-08T22:00:52Z
|
2015-08-28T12:48:38Z
|
NONE
|
resolved
|
these days, I 'm doing a poster to an old system,it only accepts gbk encoding,but form data is utf8, python 3 can pass a encoding parameter to urlencode then pass to post method,but python 2 urlencode does'nt support this parameter.
any opinion about this?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2749/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2749/timeline
| null |
completed
| null | null | false |
[
"This isn't something requests would do for you anyway, so what you should do is urlencode the data, and then pass it to the `data=` parameter, e.g., \n\n``` py\npostdata = urlencode(...)\npostdata = postdata.encode(...)\nrequests.post(url, data=postdata, headers={'Content-Type': 'application/x-www-form-urlencoded'})\n```\n\nIt isn't pretty but requests clearly meets the 95% use case here. The remaining 5% is something we won't add support for to the API.\n\nAlternatively, you could use the PreparedRequest flow and encode the body before sending the request, but that (I think) might end up being more work than what I've sketched out above.\n",
"Also in the future, if you're looking for help, please ask questions on [StackOverflow](https://stackoverflow.com/questions/tagged/python-requests).\n",
"@sigmavirus24 sorry.\n\nurlencode in python 2 encode unicode to ?\n\nthis is a problem\n"
] |
https://api.github.com/repos/psf/requests/issues/2748
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2748/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2748/comments
|
https://api.github.com/repos/psf/requests/issues/2748/events
|
https://github.com/psf/requests/issues/2748
| 103,388,556 |
MDU6SXNzdWUxMDMzODg1NTY=
| 2,748 |
during redirecting the host adress in header did not update correctly
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/8402502?v=4",
"events_url": "https://api.github.com/users/hxzhao527/events{/privacy}",
"followers_url": "https://api.github.com/users/hxzhao527/followers",
"following_url": "https://api.github.com/users/hxzhao527/following{/other_user}",
"gists_url": "https://api.github.com/users/hxzhao527/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hxzhao527",
"id": 8402502,
"login": "hxzhao527",
"node_id": "MDQ6VXNlcjg0MDI1MDI=",
"organizations_url": "https://api.github.com/users/hxzhao527/orgs",
"received_events_url": "https://api.github.com/users/hxzhao527/received_events",
"repos_url": "https://api.github.com/users/hxzhao527/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hxzhao527/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hxzhao527/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hxzhao527",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-08-26T23:47:18Z
|
2021-09-08T22:00:56Z
|
2015-08-27T01:44:22Z
|
NONE
|
resolved
|
Situation:POST or GET a adress which will redirect an adress which the host adress in header is different with the last request.
I write a small script to simulate login my school account.But the exception,
> requests.exceptions.ConnectionError: ('Connection aborted.', error(10054, ''))
> is always happening.
I try to print the information of every request.So in [session.py](https://github.com/kennethreitz/requests/blob/master/requests/sessions.py) class SessionRedirectMixin function resolve_redirects ,I print the header information before a real request.
I find during redirecting,the header information is just copied from its last request.So if a request is redirected to an adress which the host adress in header is different with the last request,it will failed.
I try to solve this problem.
I add these lines in function resolve_redirects at 172th line in [session.py](https://github.com/kennethreitz/requests/blob/master/requests/sessions.py) before send the request.
```
if headers.get("Host"):
headers["Host"] = urlparse(url).hostname
```
And it worked for me.
more information:
```
import requests
print request.__version__
'2.7.0'
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/8402502?v=4",
"events_url": "https://api.github.com/users/hxzhao527/events{/privacy}",
"followers_url": "https://api.github.com/users/hxzhao527/followers",
"following_url": "https://api.github.com/users/hxzhao527/following{/other_user}",
"gists_url": "https://api.github.com/users/hxzhao527/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hxzhao527",
"id": 8402502,
"login": "hxzhao527",
"node_id": "MDQ6VXNlcjg0MDI1MDI=",
"organizations_url": "https://api.github.com/users/hxzhao527/orgs",
"received_events_url": "https://api.github.com/users/hxzhao527/received_events",
"repos_url": "https://api.github.com/users/hxzhao527/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hxzhao527/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hxzhao527/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hxzhao527",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2748/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2748/timeline
| null |
completed
| null | null | false |
[
"@HeartUnchange are you specifying your own `Host` header? If so, why?\n",
"~(≧▽≦)/~I got it.I delete the Host ,and it works.I see browser send this field ,so I add this(I am a beginer).Thanks for your help.\n"
] |
https://api.github.com/repos/psf/requests/issues/2747
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2747/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2747/comments
|
https://api.github.com/repos/psf/requests/issues/2747/events
|
https://github.com/psf/requests/issues/2747
| 103,210,039 |
MDU6SXNzdWUxMDMyMTAwMzk=
| 2,747 |
Session connection with stream=True unusable after response.close()
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1076393?v=4",
"events_url": "https://api.github.com/users/mherrmann/events{/privacy}",
"followers_url": "https://api.github.com/users/mherrmann/followers",
"following_url": "https://api.github.com/users/mherrmann/following{/other_user}",
"gists_url": "https://api.github.com/users/mherrmann/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mherrmann",
"id": 1076393,
"login": "mherrmann",
"node_id": "MDQ6VXNlcjEwNzYzOTM=",
"organizations_url": "https://api.github.com/users/mherrmann/orgs",
"received_events_url": "https://api.github.com/users/mherrmann/received_events",
"repos_url": "https://api.github.com/users/mherrmann/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mherrmann/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mherrmann/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mherrmann",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2015-08-26T08:42:45Z
|
2021-09-08T22:00:56Z
|
2015-08-26T09:55:49Z
|
NONE
|
resolved
|
Please consider the following code:
```
import requests
session = requests.Session()
resp = session.get('http://www.w3schools.com/html/demo_sse.php', stream=True)
resp.close()
session.get('http://www.w3schools.com')
```
It results in the following exception:
```
Traceback (most recent call last):
File "<console>", line 1, in <module>
File ".../venv/lib/python3.4/site-packages/requests/sessions.py", line 477, in get
return self.request('GET', url, **kwargs)
File ".../venv/lib/python3.4/site-packages/requests/sessions.py", line 465, in request
resp = self.send(prep, **send_kwargs)
File ".../venv/lib/python3.4/site-packages/requests/sessions.py", line 573, in send
r = adapter.send(request, **kwargs)
File ".../venv/lib/python3.4/site-packages/requests/adapters.py", line 415, in send
raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', ResponseNotReady('Request-sent',))
```
Unless I am doing something wrong, It appears to me that `resp.close()` returns the connection to the pool in an inconsistent state. What's interesting is that the exception does not occur when the last line in the example above connects to a different server (eg. `session.get('http://www.google.com')` instead of `http://www.w3schools.com`). What's also interesting is that the problem only occurs when working with a `requests.Session`. That is, the following code does not raise an exception:
```
import requests
resp = requests.get('http://www.w3schools.com/html/demo_sse.php', stream=True)
resp.close()
requests.get('http://www.w3schools.com')
```
I am using requests version `2.7.0`. The problem occurs on both Windows 7 with Python 2.7.10 and on OS X with Python 3.4.3.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/2747/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2747/timeline
| null |
completed
| null | null | false |
[
"This is a known issue (#2593), and was fixed in #2610. =) The next release of requests should contain the fix.\n",
"Awesome, thanks :-) Is there an ETA for the next release?\n",
"Nothing beyond \"soon\" I'm afraid. Hopefully our release process will get a bit more concrete over the next few weeks.\n",
"Ok, thanks for letting me know!\n"
] |
https://api.github.com/repos/psf/requests/issues/2746
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2746/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2746/comments
|
https://api.github.com/repos/psf/requests/issues/2746/events
|
https://github.com/psf/requests/pull/2746
| 103,105,851 |
MDExOlB1bGxSZXF1ZXN0NDMzMzA1ODY=
| 2,746 |
Add link to IT translation
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5172190?v=4",
"events_url": "https://api.github.com/users/csparpa/events{/privacy}",
"followers_url": "https://api.github.com/users/csparpa/followers",
"following_url": "https://api.github.com/users/csparpa/following{/other_user}",
"gists_url": "https://api.github.com/users/csparpa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/csparpa",
"id": 5172190,
"login": "csparpa",
"node_id": "MDQ6VXNlcjUxNzIxOTA=",
"organizations_url": "https://api.github.com/users/csparpa/orgs",
"received_events_url": "https://api.github.com/users/csparpa/received_events",
"repos_url": "https://api.github.com/users/csparpa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/csparpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/csparpa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/csparpa",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-08-25T20:10:24Z
|
2021-09-08T06:01:08Z
|
2015-08-26T00:38:04Z
|
CONTRIBUTOR
|
resolved
|
Fixes #2744
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2746/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2746/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2746.diff",
"html_url": "https://github.com/psf/requests/pull/2746",
"merged_at": "2015-08-26T00:38:04Z",
"patch_url": "https://github.com/psf/requests/pull/2746.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2746"
}
| true |
[
"LGTM.\n"
] |
https://api.github.com/repos/psf/requests/issues/2745
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2745/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2745/comments
|
https://api.github.com/repos/psf/requests/issues/2745/events
|
https://github.com/psf/requests/issues/2745
| 102,989,781 |
MDU6SXNzdWUxMDI5ODk3ODE=
| 2,745 |
Very slow read of large files compared to many other modules/binaries (e.g. urllib/curl/wget)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/208316?v=4",
"events_url": "https://api.github.com/users/davechallis/events{/privacy}",
"followers_url": "https://api.github.com/users/davechallis/followers",
"following_url": "https://api.github.com/users/davechallis/following{/other_user}",
"gists_url": "https://api.github.com/users/davechallis/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/davechallis",
"id": 208316,
"login": "davechallis",
"node_id": "MDQ6VXNlcjIwODMxNg==",
"organizations_url": "https://api.github.com/users/davechallis/orgs",
"received_events_url": "https://api.github.com/users/davechallis/received_events",
"repos_url": "https://api.github.com/users/davechallis/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/davechallis/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/davechallis/subscriptions",
"type": "User",
"url": "https://api.github.com/users/davechallis",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-08-25T09:50:34Z
|
2021-09-08T22:00:56Z
|
2015-08-25T10:01:07Z
|
NONE
|
resolved
|
Using python 3.4 and requests 2.7.0 (on both Ubuntu 14.04 and Mac OS X), I've noticed that fetching raw content of large files is significantly slower (~5x) with requests than many other applications and python modules, performance as below is typical:
```
import requests
import urllib.request
import time
# returns a 100Mb JSON file
url = 'http://some.host.on.local.network/'
def with_urllib():
with urllib.request.urlopen(url) as f:
return f.read()
def with_requests():
return requests.get(url).content
s = time.time()
a = with_urllib()
print('urllib:', time.time() - s, 'seconds')
s = time.time()
b = with_requests()
print('requests:', time.time() - s, 'seconds')
assert a == b
```
This outputs:
```
urllib: 1.113746166229248 seconds
requests: 5.458410978317261 seconds
```
curl, wget, pycurl and urllib all complete in similar times (~1.1s on average), requests consistently takes ~5.4s on average, even with various combinations of parameters I've tried (e.g. with streaming, with different streaming chunksizes, etc.).
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2745/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2745/timeline
| null |
completed
| null | null | false |
[
"I believe this is the same bug report as #2371. We'd like to keep investigating this performance problem to see if we can work out where we're spending the time, so if you feel like trying to track it down yourself please do. Otherwise, it'll go on my backlog of work to be investigated.\n",
"Thanks, looking at #2371, it sounds like it could be the same thing. I'll do some additional investigation, and report there if I find anything.\n"
] |
https://api.github.com/repos/psf/requests/issues/2744
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2744/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2744/comments
|
https://api.github.com/repos/psf/requests/issues/2744/events
|
https://github.com/psf/requests/issues/2744
| 102,968,894 |
MDU6SXNzdWUxMDI5Njg4OTQ=
| 2,744 |
Missing link to Italian translation of documentation
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5172190?v=4",
"events_url": "https://api.github.com/users/csparpa/events{/privacy}",
"followers_url": "https://api.github.com/users/csparpa/followers",
"following_url": "https://api.github.com/users/csparpa/following{/other_user}",
"gists_url": "https://api.github.com/users/csparpa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/csparpa",
"id": 5172190,
"login": "csparpa",
"node_id": "MDQ6VXNlcjUxNzIxOTA=",
"organizations_url": "https://api.github.com/users/csparpa/orgs",
"received_events_url": "https://api.github.com/users/csparpa/received_events",
"repos_url": "https://api.github.com/users/csparpa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/csparpa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/csparpa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/csparpa",
"user_view_type": "public"
}
|
[
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
},
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"name": "Contributor Friendly",
"node_id": "MDU6TGFiZWwxOTEyNzQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Contributor%20Friendly"
},
{
"color": "fad8c7",
"default": false,
"description": null,
"id": 136616769,
"name": "Documentation",
"node_id": "MDU6TGFiZWwxMzY2MTY3Njk=",
"url": "https://api.github.com/repos/psf/requests/labels/Documentation"
}
] |
closed
| true | null |
[] | null | 0 |
2015-08-25T07:42:43Z
|
2021-09-04T00:06:28Z
|
2015-08-26T00:38:04Z
|
CONTRIBUTOR
|
resolved
|
Link shall point to: http://it.python-requests.org and be inserted in sidebar, alongside the other links to translations
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2744/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2744/timeline
| null |
completed
| null | null | false |
[] |
https://api.github.com/repos/psf/requests/issues/2743
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2743/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2743/comments
|
https://api.github.com/repos/psf/requests/issues/2743/events
|
https://github.com/psf/requests/pull/2743
| 102,930,426 |
MDExOlB1bGxSZXF1ZXN0NDMyNDE3MTc=
| 2,743 |
Fix tests on python 2.6
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
[] |
closed
| true |
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
] |
{
"closed_at": "2015-10-12T10:32:06Z",
"closed_issues": 7,
"created_at": "2015-04-29T13:03:39Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
},
"description": "",
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/25",
"id": 1089203,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/25/labels",
"node_id": "MDk6TWlsZXN0b25lMTA4OTIwMw==",
"number": 25,
"open_issues": 0,
"state": "closed",
"title": "2.8.0",
"updated_at": "2015-10-12T10:32:06Z",
"url": "https://api.github.com/repos/psf/requests/milestones/25"
}
| 0 |
2015-08-25T01:47:46Z
|
2021-09-08T06:01:09Z
|
2015-08-25T07:27:20Z
|
CONTRIBUTOR
|
resolved
|
On Python 2.6, there's no `OrderedDict` in the `collections` module.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2743/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2743/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2743.diff",
"html_url": "https://github.com/psf/requests/pull/2743",
"merged_at": "2015-08-25T07:27:20Z",
"patch_url": "https://github.com/psf/requests/pull/2743.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2743"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/2742
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2742/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2742/comments
|
https://api.github.com/repos/psf/requests/issues/2742/events
|
https://github.com/psf/requests/pull/2742
| 102,913,545 |
MDExOlB1bGxSZXF1ZXN0NDMyMzQyNDY=
| 2,742 |
Include file-like object in data arg description
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/634901?v=4",
"events_url": "https://api.github.com/users/etoews/events{/privacy}",
"followers_url": "https://api.github.com/users/etoews/followers",
"following_url": "https://api.github.com/users/etoews/following{/other_user}",
"gists_url": "https://api.github.com/users/etoews/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/etoews",
"id": 634901,
"login": "etoews",
"node_id": "MDQ6VXNlcjYzNDkwMQ==",
"organizations_url": "https://api.github.com/users/etoews/orgs",
"received_events_url": "https://api.github.com/users/etoews/received_events",
"repos_url": "https://api.github.com/users/etoews/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/etoews/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/etoews/subscriptions",
"type": "User",
"url": "https://api.github.com/users/etoews",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-08-24T23:29:58Z
|
2021-09-08T07:00:42Z
|
2015-08-25T01:44:45Z
|
NONE
|
resolved
|
If `requests.api.request()` uses `requests.sessions.Session.request()` to get it's work done then the data arg description should match between the two.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2742/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2742/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2742.diff",
"html_url": "https://github.com/psf/requests/pull/2742",
"merged_at": "2015-08-25T01:44:45Z",
"patch_url": "https://github.com/psf/requests/pull/2742.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2742"
}
| true |
[
"Thanks @everett-toews ! :sparkles: :cake: :sparkles: \n"
] |
https://api.github.com/repos/psf/requests/issues/2741
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2741/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2741/comments
|
https://api.github.com/repos/psf/requests/issues/2741/events
|
https://github.com/psf/requests/pull/2741
| 102,893,646 |
MDExOlB1bGxSZXF1ZXN0NDMyMjI5MzQ=
| 2,741 |
Implement per-host proxies
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/192614?v=4",
"events_url": "https://api.github.com/users/jasongrout/events{/privacy}",
"followers_url": "https://api.github.com/users/jasongrout/followers",
"following_url": "https://api.github.com/users/jasongrout/following{/other_user}",
"gists_url": "https://api.github.com/users/jasongrout/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jasongrout",
"id": 192614,
"login": "jasongrout",
"node_id": "MDQ6VXNlcjE5MjYxNA==",
"organizations_url": "https://api.github.com/users/jasongrout/orgs",
"received_events_url": "https://api.github.com/users/jasongrout/received_events",
"repos_url": "https://api.github.com/users/jasongrout/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jasongrout/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jasongrout/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jasongrout",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 24 |
2015-08-24T21:17:16Z
|
2021-09-08T06:01:01Z
|
2015-09-06T03:02:41Z
|
CONTRIBUTOR
|
resolved
|
This change allows the proxy dict to be have entries of the form
`{'<scheme>://<hostname>': '<proxy>'}`. Host-specific proxies will be used in
preference to the scheme-specific proxies (i.e., proxy dict entries with keys
like 'http' or 'https').
Fixes #2722
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2741/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2741/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2741.diff",
"html_url": "https://github.com/psf/requests/pull/2741",
"merged_at": "2015-09-06T03:02:41Z",
"patch_url": "https://github.com/psf/requests/pull/2741.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2741"
}
| true |
[
"This looks reasonable enough to me.\n\nThoughts @sigmavirus24?\n",
"Nope. This thoroughly breaks backwards compatibility. This changes the behaviour to **only** behave for per-host which means anyone passing `proxies={'http': ..., 'https': ...}` will see everything fail as soon as they upgrade.\n\nWe should support both, not one or the other.\n",
"Closing/re-opening to trigger a new CI build\n",
"Also there aren't any tests for this\n",
"This does support both.\n\nIt does a lookup for `u.scheme+'://'+u.hostname`, and if that does not exist falls back to the get for `u.scheme`. Or have I missed something?\n",
"@Lukasa - that's what I intended, and what I'm sure the code does. Fall back to the scheme lookup if the scheme+hostname lookup fails. Would you rather I make it 5 lines of code to make that clearer?\n",
"@sigmavirus24 - this is my first contribution to requests. How does testing work in this package?\n",
"I added a note to the documentation about this.\n",
"> It does a lookup for u.scheme+'://'+u.hostname, and if that does not exist falls back to the get for u.scheme. Or have I missed something?\n\nNesting it like that made me miss it without having had enough coffee. It should be done separately to be very explicit.\n\nAs for tests, they go in the `test_requests.py` file.\n",
"@sigmavirus24, I didn't see any tests in test_requests.py for the current proxies argument to request methods. I saw a few places where it is set from the urllib getproxies function, presumably to do some actual network calls. I also saw two tests for the no_proxy environment variable. Is there a test for the proxies argument to a request that I missed? I'm happy to write one, just wanted to make sure I didn't miss it (and I was looking for a model for how to write a test that is consistent with your framework).\n",
"Testing proxies code is tricky, normally, because of our tendency to do 'live' testing, and because this function is very side-effect-y. The best way to do it might be to pull this 'find the correct proxy url' logic into its own function in `util.py` and then unit test that specifically to verify the logic. I think that would keep everyone happy. =)\n",
"@Lukasa, I've done that now. I'm not very clear on how this plays with the environment proxies, especially in rebuild_proxies() in the sessions code (https://github.com/kennethreitz/requests/blob/master/requests/sessions.py#L228). Any help from someone that already knows the call flow and how the proxies are changed at each step is appreciated. I think I don't need to do anything, but I'm not absolutely sure.\n",
"One note here, otherwise fine.\n\nThe change you've made should be ok, but we do need to verify it. I can't do that right now, but I'll hopefully get to it Monday.\n",
"@Lukasa - a friendly ping about reviewing this. Thanks again for helping this along!\n",
"One small docs note. Otherwise, a live test appears to validate that this works. =)\n",
"I changed the docs to emphasize that the per-host proxy matches only on the scheme and exact hostname. Thanks!\n",
"Ok, I'm officially happy with this. @sigmavirus24, can I get you to take a quick look?\n",
"Looks good to me. Thanks for your hard work and diligence @jasongrout \n",
"Hurrah! @sigmavirus24 do we want to merge this before 2.8.0 or hold off until the release after?\n",
"May as well pull it into 2.8.0. Seems like @jasongrout needs this sooner rather than later.\n",
"Cool!\n",
"Thanks!\n",
"@Lukasa - just curious, is there a planned release date for 2.8.0?\n",
"There is not. I'm hoping to get to it this week, maybe tomorrow, but currently 2.8.0's release is a best-effort kind of thing.\n"
] |
https://api.github.com/repos/psf/requests/issues/2740
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2740/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2740/comments
|
https://api.github.com/repos/psf/requests/issues/2740/events
|
https://github.com/psf/requests/pull/2740
| 102,775,659 |
MDExOlB1bGxSZXF1ZXN0NDMxNjYyOTQ=
| 2,740 |
params of proxy_headers are inconsistent with its docstrings
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5804868?v=4",
"events_url": "https://api.github.com/users/qingyunha/events{/privacy}",
"followers_url": "https://api.github.com/users/qingyunha/followers",
"following_url": "https://api.github.com/users/qingyunha/following{/other_user}",
"gists_url": "https://api.github.com/users/qingyunha/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/qingyunha",
"id": 5804868,
"login": "qingyunha",
"node_id": "MDQ6VXNlcjU4MDQ4Njg=",
"organizations_url": "https://api.github.com/users/qingyunha/orgs",
"received_events_url": "https://api.github.com/users/qingyunha/received_events",
"repos_url": "https://api.github.com/users/qingyunha/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/qingyunha/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/qingyunha/subscriptions",
"type": "User",
"url": "https://api.github.com/users/qingyunha",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-08-24T11:51:35Z
|
2021-09-08T07:00:43Z
|
2015-08-24T12:43:01Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2740/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2740/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2740.diff",
"html_url": "https://github.com/psf/requests/pull/2740",
"merged_at": "2015-08-24T12:43:01Z",
"patch_url": "https://github.com/psf/requests/pull/2740.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2740"
}
| true |
[
"Thanks @qingyunha! :cake:\n"
] |
|
https://api.github.com/repos/psf/requests/issues/2739
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2739/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2739/comments
|
https://api.github.com/repos/psf/requests/issues/2739/events
|
https://github.com/psf/requests/issues/2739
| 102,688,525 |
MDU6SXNzdWUxMDI2ODg1MjU=
| 2,739 |
params of proxy_headers are inconsistent with its docstrings
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5804868?v=4",
"events_url": "https://api.github.com/users/qingyunha/events{/privacy}",
"followers_url": "https://api.github.com/users/qingyunha/followers",
"following_url": "https://api.github.com/users/qingyunha/following{/other_user}",
"gists_url": "https://api.github.com/users/qingyunha/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/qingyunha",
"id": 5804868,
"login": "qingyunha",
"node_id": "MDQ6VXNlcjU4MDQ4Njg=",
"organizations_url": "https://api.github.com/users/qingyunha/orgs",
"received_events_url": "https://api.github.com/users/qingyunha/received_events",
"repos_url": "https://api.github.com/users/qingyunha/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/qingyunha/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/qingyunha/subscriptions",
"type": "User",
"url": "https://api.github.com/users/qingyunha",
"user_view_type": "public"
}
|
[
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"name": "Contributor Friendly",
"node_id": "MDU6TGFiZWwxOTEyNzQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Contributor%20Friendly"
}
] |
closed
| true | null |
[] | null | 2 |
2015-08-24T02:28:54Z
|
2021-09-08T22:00:57Z
|
2015-08-24T12:43:12Z
|
CONTRIBUTOR
|
resolved
|
requests/adapters.py
```
def proxy_headers(self, proxy):
"""Returns a dictionary of the headers to add to any request sent
through a proxy. This works with urllib3 magic to ensure that they are
correctly sent to the proxy, rather than in a tunnelled request if
CONNECT is being used.
This should not be called from user code, and is only exposed for use
when subclassing the
:class:`HTTPAdapter <requests.adapters.HTTPAdapter>`.
:param proxies: The url of the proxy being used for this request.
:param kwargs: Optional additional keyword arguments.
"""
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2739/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2739/timeline
| null |
completed
| null | null | false |
[
"Yup, that does look wrong. Are you interested in providing a pull request to make this fix?\n",
"Yes, I'm grad to.\n"
] |
https://api.github.com/repos/psf/requests/issues/2738
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2738/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2738/comments
|
https://api.github.com/repos/psf/requests/issues/2738/events
|
https://github.com/psf/requests/issues/2738
| 102,325,351 |
MDU6SXNzdWUxMDIzMjUzNTE=
| 2,738 |
osrandom engine already registered
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/863727?v=4",
"events_url": "https://api.github.com/users/komakino/events{/privacy}",
"followers_url": "https://api.github.com/users/komakino/followers",
"following_url": "https://api.github.com/users/komakino/following{/other_user}",
"gists_url": "https://api.github.com/users/komakino/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/komakino",
"id": 863727,
"login": "komakino",
"node_id": "MDQ6VXNlcjg2MzcyNw==",
"organizations_url": "https://api.github.com/users/komakino/orgs",
"received_events_url": "https://api.github.com/users/komakino/received_events",
"repos_url": "https://api.github.com/users/komakino/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/komakino/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/komakino/subscriptions",
"type": "User",
"url": "https://api.github.com/users/komakino",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-08-21T08:27:07Z
|
2021-09-08T22:00:57Z
|
2015-08-21T12:21:31Z
|
NONE
|
resolved
|
Getting "osrandom engine already registered" from cryptography module when including requests in kodi addon.
http://xbmclogs.com/pq07deaup
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2738/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2738/timeline
| null |
completed
| null | null | false |
[
"This is strictly a cryptography bug, I think: @reaperhulk?\n",
"@komakino has already filed a bug there. Closing to centralize discussion where it belongs.\n"
] |
https://api.github.com/repos/psf/requests/issues/2737
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2737/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2737/comments
|
https://api.github.com/repos/psf/requests/issues/2737/events
|
https://github.com/psf/requests/pull/2737
| 102,318,316 |
MDExOlB1bGxSZXF1ZXN0NDMwMTE4NzU=
| 2,737 |
Avoid altering dictionary size during iteration
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/46775?v=4",
"events_url": "https://api.github.com/users/mjpieters/events{/privacy}",
"followers_url": "https://api.github.com/users/mjpieters/followers",
"following_url": "https://api.github.com/users/mjpieters/following{/other_user}",
"gists_url": "https://api.github.com/users/mjpieters/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mjpieters",
"id": 46775,
"login": "mjpieters",
"node_id": "MDQ6VXNlcjQ2Nzc1",
"organizations_url": "https://api.github.com/users/mjpieters/orgs",
"received_events_url": "https://api.github.com/users/mjpieters/received_events",
"repos_url": "https://api.github.com/users/mjpieters/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mjpieters/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mjpieters/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mjpieters",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-08-21T07:45:10Z
|
2021-09-08T07:00:44Z
|
2015-08-21T08:08:19Z
|
CONTRIBUTOR
|
resolved
|
Fixes `RuntimeError` on Python 3 introduced in 53ea23128e375ef84511fd2b22b740eca15d0854
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2737/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2737/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2737.diff",
"html_url": "https://github.com/psf/requests/pull/2737",
"merged_at": "2015-08-21T08:08:19Z",
"patch_url": "https://github.com/psf/requests/pull/2737.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2737"
}
| true |
[
"Yup, this looks right to me. Thanks @mjpieters!\n"
] |
https://api.github.com/repos/psf/requests/issues/2736
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2736/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2736/comments
|
https://api.github.com/repos/psf/requests/issues/2736/events
|
https://github.com/psf/requests/pull/2736
| 102,172,749 |
MDExOlB1bGxSZXF1ZXN0NDI5NDY4ODM=
| 2,736 |
quick fix to make session cookies work with mocked HTTP responses
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5888989?v=4",
"events_url": "https://api.github.com/users/FodT/events{/privacy}",
"followers_url": "https://api.github.com/users/FodT/followers",
"following_url": "https://api.github.com/users/FodT/following{/other_user}",
"gists_url": "https://api.github.com/users/FodT/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/FodT",
"id": 5888989,
"login": "FodT",
"node_id": "MDQ6VXNlcjU4ODg5ODk=",
"organizations_url": "https://api.github.com/users/FodT/orgs",
"received_events_url": "https://api.github.com/users/FodT/received_events",
"repos_url": "https://api.github.com/users/FodT/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/FodT/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/FodT/subscriptions",
"type": "User",
"url": "https://api.github.com/users/FodT",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-08-20T16:01:32Z
|
2021-09-08T07:00:44Z
|
2015-08-20T16:07:41Z
|
NONE
|
resolved
|
I ran into an issue working with Responses/HTTMock where session cookies were not being set. Tracked it down to here, looked like a quick (possibly dirty?) fix. Doesn't break any tests!
Throwing it up here for wider consideration. Comments welcome.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2736/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2736/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2736.diff",
"html_url": "https://github.com/psf/requests/pull/2736",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2736.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2736"
}
| true |
[
"Generally speaking, we don't really believe it's the role of this library to fix abstraction errors in Responses or HTTMock. Our goal is to function with the standard library, which this code does. In rare cases we allow for really obvious differences (e.g. `StringIO`), but we are _extremely_ reluctant to add more special case code to account for libraries that _pretend_ to be other libraries. This is particularly true when it comes to attribute access, given that Responses or HTTMock could easily just provide that attribute in their mocked response.\n\nI recommend opening this issue with the respective projects. =) Sorry!\n"
] |
https://api.github.com/repos/psf/requests/issues/2735
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2735/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2735/comments
|
https://api.github.com/repos/psf/requests/issues/2735/events
|
https://github.com/psf/requests/issues/2735
| 102,140,710 |
MDU6SXNzdWUxMDIxNDA3MTA=
| 2,735 |
AttributeError: '_socketobject' object has no attribute 'set_tlsext_host_name'
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/38136?v=4",
"events_url": "https://api.github.com/users/RuudBurger/events{/privacy}",
"followers_url": "https://api.github.com/users/RuudBurger/followers",
"following_url": "https://api.github.com/users/RuudBurger/following{/other_user}",
"gists_url": "https://api.github.com/users/RuudBurger/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/RuudBurger",
"id": 38136,
"login": "RuudBurger",
"node_id": "MDQ6VXNlcjM4MTM2",
"organizations_url": "https://api.github.com/users/RuudBurger/orgs",
"received_events_url": "https://api.github.com/users/RuudBurger/received_events",
"repos_url": "https://api.github.com/users/RuudBurger/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/RuudBurger/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RuudBurger/subscriptions",
"type": "User",
"url": "https://api.github.com/users/RuudBurger",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 18 |
2015-08-20T13:37:51Z
|
2021-09-08T17:05:26Z
|
2015-08-20T20:19:59Z
|
NONE
|
resolved
|
Getting a few users who are having this issue when doing requests: https://github.com/RuudBurger/CouchPotatoServer/issues/5239
The call is being done on this line: https://github.com/RuudBurger/CouchPotatoServer/blob/master/couchpotato/core/plugins/base.py#L250 with verify disabled, so I don't understand why it tries to validate the connection in the first place.
Is this because of an older pyopenssl installation or do I need to do something else?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/38136?v=4",
"events_url": "https://api.github.com/users/RuudBurger/events{/privacy}",
"followers_url": "https://api.github.com/users/RuudBurger/followers",
"following_url": "https://api.github.com/users/RuudBurger/following{/other_user}",
"gists_url": "https://api.github.com/users/RuudBurger/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/RuudBurger",
"id": 38136,
"login": "RuudBurger",
"node_id": "MDQ6VXNlcjM4MTM2",
"organizations_url": "https://api.github.com/users/RuudBurger/orgs",
"received_events_url": "https://api.github.com/users/RuudBurger/received_events",
"repos_url": "https://api.github.com/users/RuudBurger/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/RuudBurger/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RuudBurger/subscriptions",
"type": "User",
"url": "https://api.github.com/users/RuudBurger",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2735/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2735/timeline
| null |
completed
| null | null | false |
[
"Are there other bug reports with more information? There's no way for us to know what's happening based on the information there.\n",
"Another one with version information: https://github.com/RuudBurger/CouchPotatoServer/issues/5219\nAnd https://github.com/RuudBurger/CouchPotatoServer/issues/5225\n\nSeems like all the errors are for the same domain (example https://image.tmdb.org/t/p/w154/bmOG5k07nrnS8T49NVPM1LnrOf1.jpg), maybe something to do with the certificate on https://image.tmdb.org/?\n",
"So with the following packages\n\n```\ncffi (1.2.0)\ncryptography (1.0)\nenum34 (1.0.4)\nidna (2.0)\nipaddress (1.0.14)\nndg-httpsclient (0.4.0)\npip (7.0.1)\npyasn1 (0.1.8)\npycparser (2.14)\npyOpenSSL (0.15.1)\nrequests (2.7.0)\nsetuptools (16.0)\nsix (1.9.0)\nwheel (0.24.0)\n```\n\nOn Python 2.7.9 (and 2.7.10) I cannot reproduce this using the example URL you provided. Neither you nor your users are really giving us enough information to reproduce this. One says it's fixed by 0.13 of pyOpenSSL which would imply it's fixed by that or newer versions of pyOpenSSL.\n",
"Yeah I couldn't reproduce it either. But I though maybe someone reported the same kind of error earlier.\nI'll just ask them to make sure they're on the latest version for now. Thanks\n",
"@RuudBurger the next person to report this, please ping me on the bug on your end\n",
"Hi!\n\nI get this error in Plex - not sure if you aware of what that is.\nAnyhow I have developed a Plex plugin that recently got SSL handshake issues and tried to get around this by using requests[security] modules. However I get this:\n`AttributeError: '_socketobject' object has no attribute 'set_tlsext_host_name'`\n\nThis is not a normal python installation - i.e. it's Plex Framework that makes the rules. But it's possible to import external python modules - but while doing this I get the error above.\n\nPython version is 2.7.4 and OPEN SSL version is \"1.0.0m 5 Jun 2014\"\n\nI have imported \nOpenSSL (pyOpenSSL - trried 16, 0.15.1 and 0.13.1)\ncertifi\nndg (ndg-httpsclient 0.4.1)\npyasn1\nrequests (2.10)\nsix.py\nurllib3 (1.16)\n\nPlease let me know what more info I can provide.\n\nbr\nJesper\n",
"That error _strongly_ suggests you have had a problem with your compilation of the cryptography module. Do you have installation logs?\n",
"As mentioned Plex provides the Python environment. So \"installation logs\" aren't available. I guess I might try to download that module and add it to my plugin. I'm not sure if Plex allows a plugin to override python modules with plugin specific versions.\n",
"In the absence of installation logs, it's really hard to know what's going on, but the overwhelming likelihood is that your Plex installation does not ship appropriate headers to actually compile a whole bunch of stuff.\n",
"I tried import of cryptography - failed with \"no such module\".\nSo I downloaded it and added to my Plugin. Import now works but I still get an issue with \"no set_tlsext_host_name\".\n\nAny other ideas?\n",
"Can you provide a full traceback, please?\n",
"`File \"C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\code\\sandbox.py\", line 294, in call_named_function\n result = f(*args, **kwargs)\n File \"C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Code\\__init__.py\", line 118, in Start\n contents = MyJson(\"https://content.viaplay.\"+site)\n File \"C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Services\\Shared Code\\viaplaylib.pys\", line 59, in MyJson\n return JSON.ObjectFromString(requests.get(re.sub(\"{\\\\?dtg}\", \"\", url)).text)\n File \"C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\api.py\", line 71, in get\n return request('get', url, params=params, **kwargs)\n File \"C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\api.py\", line 57, in request\n return session.request(method=method, url=url, **kwargs)\n File \"C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\sessions.py\", line 475, in request\n resp = self.send(prep, **send_kwargs)\n File \"C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\sessions.py\", line 585, in send\n r = adapter.send(request, **kwargs)\n File \"C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\adapters.py\", line 403, in send\n timeout=timeout\n File \"C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\connectionpool.py\", line 578, in urlopen\n chunked=chunked)\n File \"C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\connectionpool.py\", line 351, in _make_request\n self._validate_conn(conn)\n File \"C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\connectionpool.py\", line 814, in _validate_conn\n conn.connect()\n File \"C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\connection.py\", line 289, in connect\n ssl_version=resolved_ssl_version)\n File \"C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\contrib\\pyopenssl.py\", line 344, in ssl_wrap_socket\n cnx.set_tlsext_host_name(server_hostname)\nAttributeError: '_socketobject' object has no attribute 'set_tlsext_host_name'`\n\nNot so readable perhaps...\n",
"Did a sys.modules as well:\n\n`{'nturl2path': <module 'nturl2path' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\nturl2path.py'>, 'logging.cPickle': None, 'ctypes.os': None, 'lxml.html.sys': None, 'Framework.api.select': None, 'Framework.interfaces.time': None, 'Framework.api': <module 'Framework.api' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\__init__.pyc'>, 'logging.weakref': None, 'base64': <module 'base64' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\base64.py'>, 'Framework.api.threadkit': <module 'Framework.api.threadkit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\threadkit.pyc'>, 'subsystem.posixpath': None, 'routes.routes': None, 'Framework.code.RestrictedPython': None, 'string': <module 'string' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\string.py'>, 'RestrictedPython.exceptions': None, 'encodings.utf_8': <module 'encodings.utf_8' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\encodings\\utf_8.py'>, 'pyasn1.type.univ': <module 'pyasn1.type.univ' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\type\\univ.py'>, 'Framework.components.routes': None, 'RestrictedPython.SelectCompiler': <module 'RestrictedPython.SelectCompiler' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\RestrictedPython\\SelectCompiler.pyc'>, 'Framework.components.localization': <module 'Framework.components.localization' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\components\\localization.pyc'>, 'requests.packages.urllib3.util.request': <module 'requests.packages.urllib3.util.request' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\util\\request.py'>, 'Framework.api.parsekit': <module 'Framework.api.parsekit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\parsekit.pyc'>, 'json.encoder': <module 'json.encoder' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\json\\encoder.py'>, 'crypto.cipher.base': <module 'crypto.cipher.base' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\crypto\\cipher\\base.pyc'>, 'Framework.base64': None, 'Framework.components.Framework': None, 'tornado.mimetypes': None, 'requests.os': None, 'tornado.iostream': <module 'tornado.iostream' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\tornado\\iostream.pyc'>, 'pyamf.adapters._decimal': <module 'pyamf.adapters._decimal' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\pyamf\\adapters\\_decimal.pyc'>, 'compiler.warnings': None, 'Framework.api.playerkit': <module 'Framework.api.playerkit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\playerkit.pyc'>, 'pyasn1.type': <module 'pyasn1.type' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\type\\__init__.py'>, 'certifi.core': <module 'certifi.core' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\certifi\\core.py'>, 'gc': <module 'gc' (built-in)>, 'lxml.copy_reg': None, 'requests.logging': None, 'pyamf.versions': <module 'pyamf.versions' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\pyamf\\versions.pyc'>, 'dis': <module 'dis' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\dis.py'>, 'Framework.components.demjson': None, 'logging.threading': None, 'subsystem.sys': None, 'urllib3.packages.ssl_match_hostname._implementation': <module 'urllib3.packages.ssl_match_hostname._implementation' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\packages\\ssl_match_hostname\\_implementation.py'>, 'Framework.components.simplejson': None, 'tornado.time': None, 'pyasn1.type.constraint': <module 'pyasn1.type.constraint' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\type\\constraint.py'>, 'Framework.modelling.shutil': None, 'tornado.functools': None, 'Framework.handlers.runtime': <module 'Framework.handlers.runtime' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\handlers\\runtime.pyc'>, 'compiler.struct': None, 'tornado.contextlib': None, 'Framework.interfaces.socketinterface': <module 'Framework.interfaces.socketinterface' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\interfaces\\socketinterface.pyc'>, 'Framework.interfaces': <module 'Framework.interfaces' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\interfaces\\__init__.pyc'>, 'abc': <module 'abc' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\abc.py'>, 'pyamf.adapters.pyamf': None, 'Framework.api.resourcekit': <module 'Framework.api.resourcekit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\resourcekit.pyc'>, 'xml.sax.io': None, 'pyasn1.compat': <module 'pyasn1.compat' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\compat\\__init__.py'>, 'ntpath': <module 'ntpath' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\ntpath.py'>, 'pyasn1.codec.ber.decoder': <module 'pyasn1.codec.ber.decoder' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\codec\\ber\\decoder.py'>, 'Framework.code.context': <module 'Framework.code.context' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\code\\context.pyc'>, 'new': <module 'new' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\new.py'>, 'Framework.components.caching': <module 'Framework.components.caching' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\components\\caching.pyc'>, 'pyamf.adapters.decimal': None, 'encodings.aliases': <module 'encodings.aliases' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\encodings\\aliases.py'>, 'urllib3.packages': <module 'urllib3.packages' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\packages\\__init__.py'>, 'requests.packages.urllib3.exceptions': <module 'requests.packages.urllib3.exceptions' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\exceptions.py'>, 'compiler.imp': None, 'simplejson.decoder': <module 'simplejson.decoder' from 'C:\\Program Files\\Plex\\Plex Media Server\\Exts\\simplejson\\decoder.pyc'>, '_ctypes': <module '_ctypes' from 'C:\\Program Files\\Plex\\Plex Media Server\\DLLs\\_ctypes.pyd'>, 'fnmatch': <module 'fnmatch' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\fnmatch.py'>, 'json.scanner': <module 'json.scanner' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\json\\scanner.py'>, 'tornado.email': None, 'Framework.api.Queue': None, 'tornado.uuid': None, 'codecs': <module 'codecs' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\codecs.py'>, 'Framework.components.threading': None, 'tornado.cStringIO': None, 'requests.cookies': <module 'requests.cookies' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\cookies.py'>, 'pyamf.__builtin__': None, 'urllib3.util.timeout': <module 'urllib3.util.timeout' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\util\\timeout.py'>, 'email.socket': None, 'StringIO': <module 'StringIO' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\StringIO.py'>, 'Framework.components.gc': None, 'urllib3.packages.ssl_match_hostname.re': None, 'weakref': <module 'weakref' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\weakref.py'>, 'compiler.misc': <module 'compiler.misc' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\compiler\\misc.py'>, 'Framework.components.traceback': None, 'dateutil.dateutil': None, 'Framework.api.uuid': None, 'tornado.csv': None, 'json.decoder': <module 'json.decoder' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\json\\decoder.py'>, 'encodings.binascii': None, 'Framework.traceback': None, 'ctypes.struct': None, '_sre': <module '_sre' (built-in)>, 'tornado.urllib': None, 'email.FeedParser': <email.LazyImporter object at 0x01529EF0>, 'pyamf.adapters._array': <module 'pyamf.adapters._array' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\pyamf\\adapters\\_array.pyc'>, 'Framework.components.cgi': None, 'urllib3.exceptions': <module 'urllib3.exceptions' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\exceptions.py'>, 'routes.urllib': None, 'logging.re': None, 'select': <module 'select' from 'C:\\Program Files\\Plex\\Plex Media Server\\DLLs\\select.pyd'>, 'ctypes._ctypes': None, '_heapq': <module '_heapq' (built-in)>, 'Framework.handlers.tornado': None, 'urllib3.util.ssl_': <module 'urllib3.util.ssl_' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\util\\ssl_.py'>, 'requests.api': <module 'requests.api' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\api.py'>, 'Framework.policies.cloudpolicy': <module 'Framework.policies.cloudpolicy' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\policies\\cloudpolicy.pyc'>, 'requests.packages.urllib3.util': <module 'requests.packages.urllib3.util' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\util\\__init__.py'>, 'crypto.common': <module 'crypto.common' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\crypto\\common.pyc'>, 'binascii': <module 'binascii' (built-in)>, 'pyasn1.logging': None, 'tornado.urlparse': None, 'Framework.components.socket': None, 'email.MIMEMessage': <email.LazyImporter object at 0x01537290>, 'email._parseaddr': <module 'email._parseaddr' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\email\\_parseaddr.py'>, 'email.sys': None, 'tokenize': <module 'tokenize' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\tokenize.py'>, 'pyasn1.time': None, 'pyamf.remoting.pyamf': None, 'md5': <module 'md5' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\md5.py'>, 'pyasn1.type.error': <module 'pyasn1.type.error' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\type\\error.py'>, 'pyasn1.error': <module 'pyasn1.error' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\error.py'>, 'OpenSSL.OpenSSL': None, 'pyasn1.codec.cer.decoder': <module 'pyasn1.codec.cer.decoder' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\codec\\cer\\decoder.py'>, 'Framework.components.hashlib': None, 'cPickle': <module 'cPickle' (built-in)>, 'ndg.httpsclient.ndg': None, 'simplejson.sys': None, 'Framework.components.BeautifulSoup': None, 'Framework.handlers.types': None, 'compiler.syntax': <module 'compiler.syntax' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\compiler\\syntax.py'>, 'requests.packages.urllib3.contrib.pyopenssl': <module 'requests.packages.urllib3.contrib.pyopenssl' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\contrib\\pyopenssl.py'>, 'pyamf.inspect': None, 'tornado.xml': None, 'unicodedata': <module 'unicodedata' from 'C:\\Program Files\\Plex\\Plex Media Server\\DLLs\\unicodedata.pyd'>, 'Framework.code.urllib': None, 'Framework.api.Framework': None, 'lxml.__builtin__': None, 'compiler.dis': None, 'Framework.policies.standardpolicy': <module 'Framework.policies.standardpolicy' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\policies\\standardpolicy.pyc'>, 'markupbase': <module 'markupbase' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\markupbase.py'>, 'dateutil.tz': <module 'dateutil.tz' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\dateutil\\tz.pyc'>, 'lxml.html': <module 'lxml.html' from 'C:\\Program Files\\Plex\\Plex Media Server\\Exts\\lxml\\html\\__init__.pyc'>, 'exceptions': <module 'exceptions' (built-in)>, 'sre_parse': <module 'sre_parse' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\sre_parse.py'>, 'crypto.keyedHash.struct': None, 'pickle': <module 'pickle' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\pickle.py'>, 'Framework.code.loader': <module 'Framework.code.loader' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\code\\loader.pyc'>, 'xml.sax.types': None, 'Framework.api.modelkit': <module 'Framework.api.modelkit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\modelkit.pyc'>, 'logging.cStringIO': None, 'pyamf': <module 'pyamf' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\pyamf\\__init__.pyc'>, 'compiler.pyassem': <module 'compiler.pyassem' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\compiler\\pyassem.py'>, 'encodings.cp1252': <module 'encodings.cp1252' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\encodings\\cp1252.py'>, 'cerealizer.cStringIO': None, 'lxml.html._setmixin': <module 'lxml.html._setmixin' from 'C:\\Program Files\\Plex\\Plex Media Server\\Exts\\lxml\\html\\_setmixin.pyc'>, 'Framework.components.myplex': <module 'Framework.components.myplex' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\components\\myplex.pyc'>, 'numbers': <module 'numbers' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\numbers.py'>, 'simplejson.simplejson': None, 'lxml.html.htmlentitydefs': None, 'requests.exceptions': <module 'requests.exceptions' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\exceptions.py'>, 'Framework.api.unicodedata': None, 'lxml.inspect': None, 'Framework.code.Framework': None, 'requests.packages.urllib3.packages.ssl_match_hostname.ssl': None, 'lxml': <module 'lxml' from 'C:\\Program Files\\Plex\\Plex Media Server\\Exts\\lxml\\__init__.pyc'>, 'strop': <module 'strop' (built-in)>, 'crypto.errors': <module 'crypto.errors' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\crypto\\errors.pyc'>, 'six': <module 'six' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\six.py'>, 'OpenSSL': <module 'OpenSSL' from 'C:\\Program Files\\Plex\\Plex Media Server\\Exts\\OpenSSL\\__init__.pyc'>, 'pyamf.util': <module 'pyamf.util' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\pyamf\\util\\__init__.pyc'>, 'pyasn1.debug': <module 'pyasn1.debug' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\debug.py'>, 'Framework.signal': None, 'tornado.Cookie': None, 'Framework.components.urllib': None, 'config': <module 'config' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\config.pyc'>, 'requests.packages.urllib3.packages.types': None, 'Framework.socket': None, 'requests.packages.urllib3.packages.operator': None, 'Framework.handlers.debugging': <module 'Framework.handlers.debugging' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\handlers\\debugging.pyc'>, 'tornado.template': <module 'tornado.template' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\tornado\\template.pyc'>, 'ctypes.util': <module 'ctypes.util' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\ctypes\\util.py'>, 'dateutil.relativedelta': <module 'dateutil.relativedelta' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\dateutil\\relativedelta.pyc'>, 'htmlentitydefs': <module 'htmlentitydefs' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\htmlentitydefs.py'>, 'urllib3.fields': <module 'urllib3.fields' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\fields.py'>, 'subsystem.propertyfix': <module 'subsystem.propertyfix' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\subsystem\\propertyfix.pyc'>, 'ndg.httpsclient.subj_alt_name': <module 'ndg.httpsclient.subj_alt_name' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\ndg\\httpsclient\\subj_alt_name.py'>, 'compiler.types': None, 'crypto.hash.sha1Hash': <module 'crypto.hash.sha1Hash' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\crypto\\hash\\sha1Hash.pyc'>, 'Framework.api.re': None, 'dateutil.tzwin': <module 'dateutil.tzwin' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\dateutil\\tzwin.pyc'>, 'requests.packages.urllib3.packages': <module 'requests.packages.urllib3.packages' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\packages\\__init__.py'>, 'os.path': <module 'ntpath' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\ntpath.py'>, 'urllib3.packages.six': <module 'urllib3.packages.six' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\packages\\six.py'>, 'compiler.symbols': <module 'compiler.symbols' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\compiler\\symbols.py'>, 'Framework.components.binascii': None, 'OpenSSL.sys': None, 'pyasn1': <module 'pyasn1' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\__init__.py'>, 'requests.base64': None, '_weakrefset': <module '_weakrefset' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\_weakrefset.py'>, 'pyasn1.codec.der.pyasn1': None, 'tornado.tornado': None, 'requests.certs': <module 'requests.certs' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\certs.py'>, 'tornado.hashlib': None, 'dateutil.os': None, 'Framework.api.cerealizer': None, 'Framework.modelling.model': <module 'Framework.modelling.model' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\modelling\\model.pyc'>, 'Framework.operator': None, 'Framework.interfaces.string': None, 'functools': <module 'functools' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\functools.py'>, 'Framework.api.objectkit': <module 'Framework.api.objectkit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\objectkit.pyc'>, 'Framework.components.storage': <module 'Framework.components.storage' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\components\\storage.pyc'>, 'sysconfig': <module 'sysconfig' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\sysconfig.py'>, 'email.MIMEImage': <email.LazyImporter object at 0x01537270>, '__future__': <module '__future__' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\__future__.py'>, 'tornado.gzip': None, 'cerealizer': <module 'cerealizer' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\cerealizer\\__init__.pyc'>, 'subsystem.__builtin__': None, 'email.MIMEText': <email.LazyImporter object at 0x01537410>, 'sgmllib': <module 'sgmllib' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\sgmllib.py'>, 'lxml.lxml': None, 'pyamf.sol': <module 'pyamf.sol' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\pyamf\\sol.pyc'>, 'tempfile': <module 'tempfile' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\tempfile.py'>, 'OpenSSL.SSL': <module 'OpenSSL.SSL' from 'C:\\Program Files\\Plex\\Plex Media Server\\Exts\\OpenSSL\\SSL.pyd'>, 'Framework.api.cryptokit': <module 'Framework.api.cryptokit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\cryptokit.pyc'>, 'pyasn1.compat.octets': <module 'pyasn1.compat.octets' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\compat\\octets.py'>, 'imp': <module 'imp' (built-in)>, 'dateutil.struct': None, 'lxml.etree': <module 'lxml.etree' from 'C:\\Program Files\\Plex\\Plex Media Server\\Exts\\lxml\\etree.pyd'>, 'routes.mapper': <module 'routes.mapper' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\routes\\mapper.pyc'>, 'Framework.plistlib': None, 'requests.adapters': <module 'requests.adapters' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\adapters.py'>, 'Framework.api.operator': None, 'lxml.re': None, 'email.calendar': None, 'Framework.policies.pickle': None, 'Framework.policies': <module 'Framework.policies' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\policies\\__init__.pyc'>, 'Framework.components.shutil': None, 'Framework.modelling.objects': <module 'Framework.modelling.objects' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\modelling\\objects.pyc'>, 'email.urllib': None, 'compiler.token': None, 'Framework.components.random': None, 'httplib': <module 'httplib' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\httplib.py'>, 'Framework.components.weakref': None, 'Framework.code.sandbox': <module 'Framework.code.sandbox' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\code\\sandbox.pyc'>, 'Framework.string': None, 'decimal': <module 'decimal' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\decimal.py'>, 'crypto': <module 'crypto' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\crypto\\__init__.pyc'>, 'Framework.api.string': None, 'logging.handlers': <module 'logging.handlers' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\logging\\handlers.py'>, 'token': <module 'token' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\token.py'>, 'email.encoders': <module 'email.encoders' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\email\\encoders.py'>, 'OpenSSL.crypto': <module 'OpenSSL.crypto' from 'C:\\Program Files\\Plex\\Plex Media Server\\Exts\\OpenSSL\\crypto.pyd'>, 'tornado.bisect': None, 'requests': <module 'requests' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\__init__.py'>, 'requests.packages.urllib3.packages.ordered_dict': <module 'requests.packages.urllib3.packages.ordered_dict' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\packages\\ordered_dict.py'>, 'csv': <module 'csv' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\csv.py'>, 'Framework.components.mimetools': None, 'subsystem': <module 'subsystem' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\subsystem\\__init__.pyc'>, 'cStringIO': <module 'cStringIO' (built-in)>, 'RestrictedPython.MutatingWalker': <module 'RestrictedPython.MutatingWalker' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\RestrictedPython\\MutatingWalker.pyc'>, 'pyasn1.type.tag': <module 'pyasn1.type.tag' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\type\\tag.py'>, 'Framework.components.urlparse': None, 'requests.datetime': None, 'Framework.api.socket': None, 'urllib3.packages.ssl_match_hostname.ssl': None, 'encodings': <module 'encodings' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\encodings\\__init__.py'>, 'pyasn1.sys': None, 'Framework.api.weakref': None, 'cerealizer.logging': None, 'tornado.base64': None, 'Framework.components.time': None, 'requests.packages.urllib3.util.url': <module 'requests.packages.urllib3.util.url' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\util\\url.py'>, 'Framework.components.ctypes': None, 'lxml.cssselect': <module 'lxml.cssselect' from 'C:\\Program Files\\Plex\\Plex Media Server\\Exts\\lxml\\cssselect.pyc'>, 'lxml.html.lxml': None, '_subprocess': <module '_subprocess' (built-in)>, 'Framework.modelling': <module 'Framework.modelling' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\modelling\\__init__.pyc'>, 'Framework.sys': None, 're': <module 're' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\re.py'>, 'pyamf.util.inspect': None, 'Framework.code.os': None, 'Framework.api.helperkit': <module 'Framework.api.helperkit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\helperkit.pyc'>, 'math': <module 'math' (built-in)>, 'Framework.constants': <module 'Framework.constants' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\constants.pyc'>, 'Framework.api.urllib': None, 'Framework.urllib': None, 'Framework.utils': <module 'Framework.utils' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\utils.pyc'>, 'requests.packages.urllib3.packages.ssl_match_hostname.re': None, 'simplejson.scanner': <module 'simplejson.scanner' from 'C:\\Program Files\\Plex\\Plex Media Server\\Exts\\simplejson\\scanner.pyc'>, 'pyasn1.type.tagmap': <module 'pyasn1.type.tagmap' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\type\\tagmap.py'>, 'requests.packages.urllib3.util.retry': <module 'requests.packages.urllib3.util.retry' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\util\\retry.py'>, 'Framework.components.services': <module 'Framework.components.services' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\components\\services.pyc'>, 'Framework.components.lxml': None, 'Framework.components.cerealizer': None, 'Framework.components.cStringIO': None, 'Framework.components.zipfile': None, 'Framework.components.Cookie': None, '_locale': <module '_locale' (built-in)>, 'logging': <module 'logging' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\logging\\__init__.py'>, 'lxml.html.UserDict': None, 'thread': <module 'thread' (built-in)>, 'pyamf.util.pure': <module 'pyamf.util.pure' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\pyamf\\util\\pure.pyc'>, 'traceback': <module 'traceback' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\traceback.py'>, 'email.Message': <email.LazyImporter object at 0x01529F90>, 'routes': <module 'routes' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\routes\\__init__.pyc'>, 'requests.copy': None, 'routes.threading': None, 'Framework.modelling.copy': None, 'Framework.simplejson': None, 'Framework.components.select': None, '_collections': <module '_collections' (built-in)>, 'compiler.cStringIO': None, 'tornado.calendar': None, 'Framework.code.types': None, 'Framework.api.mimetypes': None, 'pyamf.adapters.collections': None, 'pyasn1.codec.cer.pyasn1': None, 'email.Utils': <email.LazyImporter object at 0x01529FD0>, 'Framework.interfaces.threading': None, 'Framework.components.types': None, 'array': <module 'array' (built-in)>, 'email.Errors': <email.LazyImporter object at 0x01529ED0>, 'ctypes.sys': None, 'tornado.htmlentitydefs': None, '_LWPCookieJar': <module '_LWPCookieJar' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\_LWPCookieJar.py'>, 'posixpath': <module 'posixpath' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\posixpath.py'>, 'sha': <module 'sha' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\sha.py'>, 'Framework.api.datakit': <module 'Framework.api.datakit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\datakit.pyc'>, 'urllib3.response': <module 'urllib3.response' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\response.py'>, 'compiler.os': None, 'types': <module 'types' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\types.py'>, 'Framework.api.urlparse': None, 'Framework.modelling.accessor': <module 'Framework.modelling.accessor' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\modelling\\accessor.pyc'>, 'json._json': None, 'xpython': <module 'xpython' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\xpython.pyc'>, '_codecs': <module '_codecs' (built-in)>, 'Framework.api.xmlrpclib': None, 'json.sys': None, 'pyasn1.type.pyasn1': None, 'Framework.api.messagekit': <module 'Framework.api.messagekit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\messagekit.pyc'>, 'requests.codecs': None, 'copy': <module 'copy' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\copy.py'>, 'hashlib': <module 'hashlib' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\hashlib.py'>, 'tornado.logging': None, 'Framework.components.operator': None, 'Framework.code.urlparse': None, '_csv': <module '_csv' (built-in)>, 'xml.sax.saxutils': <module 'xml.sax.saxutils' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\xml\\sax\\saxutils.py'>, 'Framework.interfaces.httplib': None, 'tornado.sys': None, 'subsystem.weakreffix': <module 'subsystem.weakreffix' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\subsystem\\weakreffix.pyc'>, 'requests.cgi': None, 'tornado.errno': None, 'requests.models': <module 'requests.models' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\models.py'>, 'Framework.api.templatekit': <module 'Framework.api.templatekit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\templatekit.pyc'>, 'pyamf.util.calendar': None, 'Framework.code.xpython': None, 'sre_compile': <module 'sre_compile' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\sre_compile.py'>, 'Framework.api.random': None, '_hashlib': <module '_hashlib' from 'C:\\Program Files\\Plex\\Plex Media Server\\DLLs\\_hashlib.pyd'>, 'routes.util': <module 'routes.util' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\routes\\util.pyc'>, 'tornado.hmac': None, 'Framework.api.struct': None, 'dateutil._winreg': None, 'email.base64': None, 'tornado.win32_support': <module 'tornado.win32_support' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\tornado\\win32_support.pyc'>, 'requests.packages.urllib3.packages.thread': None, '__main__': <module '__main__' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python/bootstrap.py'>, 'requests.Cookie': None, 'dateutil.sys': None, 'requests.packages.urllib3.packages.ssl_match_hostname._implementation': <module 'requests.packages.urllib3.packages.ssl_match_hostname._implementation' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\packages\\ssl_match_hostname\\_implementation.py'>, 'Framework.components.base': <module 'Framework.components.base' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\components\\base.pyc'>, 'Framework.weakref': None, 'requests.packages.chardet.sys': None, 'pyamf.remoting.client': <module 'pyamf.remoting.client' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\pyamf\\remoting\\client\\__init__.pyc'>, 'encodings.codecs': None, 'Framework.api.subprocess_new': None, 'pyasn1.type.namedtype': <module 'pyasn1.type.namedtype' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\type\\namedtype.py'>, 'requests.urllib2': None, 'requests.structures': <module 'requests.structures' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\structures.py'>, 'tornado.socket': None, 'Framework.components.stat': None, 'Framework.components.runtime': <module 'Framework.components.runtime' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\components\\runtime.pyc'>, 'Framework.handlers': <module 'Framework.handlers' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\handlers\\__init__.pyc'>, 'subsystem.importer': <module 'subsystem.importer' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\subsystem\\importer.pyc'>, '_ssl': <module '_ssl' from 'C:\\Program Files\\Plex\\Plex Media Server\\DLLs\\_ssl.pyd'>, 'warnings': <module 'warnings' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\warnings.py'>, 'tornado': <module 'tornado' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\tornado\\__init__.pyc'>, 'encodings.ascii': <module 'encodings.ascii' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\encodings\\ascii.py'>, 'urllib3.packages.six.moves': <module 'urllib3.packages.six.moves' (built-in)>, 'Framework.modelling.serialization': <module 'Framework.modelling.serialization' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\modelling\\serialization.pyc'>, 'email.MIMEBase': <email.LazyImporter object at 0x015371F0>, 'Framework.handlers.plugin': <module 'Framework.handlers.plugin' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\handlers\\plugin.pyc'>, 'Framework.api._winreg': None, 'ctypes.imp': None, 'requests.packages.urllib3.packages.six': <module 'requests.packages.urllib3.packages.six' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\packages\\six.py'>, 'requests.compat': <module 'requests.compat' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\compat.py'>, 'Framework.api.constkit': <module 'Framework.api.constkit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\constkit.pyc'>, 'pyamf.remoting.client.urllib2': None, 'Framework.policies.modelpolicy': <module 'Framework.policies.modelpolicy' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\policies\\modelpolicy.pyc'>, '_io': <module '_io' (built-in)>, 'compiler.future': <module 'compiler.future' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\compiler\\future.py'>, 'Framework.code.cookielib': None, 'pyasn1.type.math': None, 'pyamf.remoting.client.pyamf': None, 'OpenSSL.rand': <module 'OpenSSL.rand' from 'C:\\Program Files\\Plex\\Plex Media Server\\Exts\\OpenSSL\\rand.pyd'>, 'simplejson.cStringIO': None, 'email.quopri': None, 'hmac': <module 'hmac' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\hmac.py'>, 'Framework.types': None, 'Framework.components.tempfile': None, 'Framework.api.cgi': None, 'random': <module 'random' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\random.py'>, '_bisect': <module '_bisect' (built-in)>, 'lxml.os': None, 'datetime': <module 'datetime' (built-in)>, 'subsystem.imp': None, 'requests.urlparse': None, 'urllib': <module 'urllib' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\urllib.py'>, 'Framework.components': <module 'Framework.components' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\components\\__init__.pyc'>, 'logging.os': None, 'ctypes._endian': <module 'ctypes._endian' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\ctypes\\_endian.py'>, 'encodings.encodings': None, 'tornado.datetime': None, 'xml': <module 'xml' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\xml\\__init__.py'>, 'logging.stat': None, 'email.time': None, 'pyasn1.compat.sys': None, 'requests.sessions': <module 'requests.sessions' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\sessions.py'>, 'urllib3.connection': <module 'urllib3.connection' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\connection.py'>, '_json': <module '_json' (built-in)>, 'requests.packages.urllib3.packages.six.moves': <module 'moves' (built-in)>, 'pyexpat.errors': <module 'pyexpat.errors' (built-in)>, 'tornado.web': <module 'tornado.web' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\tornado\\web.pyc'>, 'logging.thread': None, 'modulefinder': <module 'modulefinder' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\modulefinder.py'>, 'requests.packages.urllib3.fields': <module 'requests.packages.urllib3.fields' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\fields.py'>, 'pyamf.adapters': <module 'pyamf.adapters' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\pyamf\\adapters\\__init__.pyc'>, 'routes.re': None, 'Framework.code.sys': None, 'zipfile': <module 'zipfile' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\zipfile.py'>, 'requests.packages.urllib3': <module 'requests.packages.urllib3' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\__init__.py'>, 'ssl': <module 'ssl' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\ssl.py'>, 'requests.threading': None, 'RestrictedPython.compiler': None, 'crypto.cipher.rijndael': <module 'crypto.cipher.rijndael' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\crypto\\cipher\\rijndael.pyc'>, 'cookielib': <module 'cookielib' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\cookielib.py'>, 'compiler': <module 'compiler' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\compiler\\__init__.py'>, 'crypto.hash.sha': None, 'Framework.api.utilkit': <module 'Framework.api.utilkit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\utilkit.pyc'>, 'keyword': <module 'keyword' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\keyword.py'>, 'tornado.httputil': <module 'tornado.httputil' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\tornado\\httputil.pyc'>, 'bisect': <module 'bisect' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\bisect.py'>, 'dateutil': <module 'dateutil' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\dateutil\\__init__.pyc'>, 'compiler.consts': <module 'compiler.consts' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\compiler\\consts.py'>, 'threading': <module 'threading' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\threading.py'>, 'pyexpat.model': <module 'pyexpat.model' (built-in)>, 'ndg.httpsclient.pyasn1': None, 'crypto.keyedHash.math': None, 'ctypes.wintypes': <module 'ctypes.wintypes' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\ctypes\\wintypes.py'>, 'crypto.keyedHash.hmacHash': <module 'crypto.keyedHash.hmacHash' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\crypto\\keyedHash\\hmacHash.pyc'>, 'requests.hashlib': None, 'Framework.api.networkkit': <module 'Framework.api.networkkit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\networkkit.pyc'>, 'requests.packages.urllib3.packages.StringIO': None, 'ndg.httpsclient.logging': None, 'locale': <module 'locale' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\locale.py'>, 'pyasn1.type.base': <module 'pyasn1.type.base' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\type\\base.py'>, 'compiler.transformer': <module 'compiler.transformer' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\compiler\\transformer.py'>, 'atexit': <module 'atexit' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\atexit.py'>, 'email.quopriMIME': <email.LazyImporter object at 0x01537090>, 'Framework.modelling.urllib': None, 'compiler.parser': None, 'compiler.symbol': None, 'pyamf.util.imports': <module 'pyamf.util.imports' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\pyamf\\util\\imports.pyc'>, 'calendar': <module 'calendar' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\calendar.py'>, 'requests.io': None, 'lxml.html.soupparser': <module 'lxml.html.soupparser' from 'C:\\Program Files\\Plex\\Plex Media Server\\Exts\\lxml\\html\\soupparser.pyc'>, 'requests.auth': <module 'requests.auth' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\auth.py'>, 'tornado.__future__': None, 'Framework.logging': None, 'pyamf.alias': <module 'pyamf.alias' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\pyamf\\alias.pyc'>, 'plistlib': <module 'plistlib' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\plistlib.py'>, 'Framework.hashlib': None, 'Framework.api.runtimekit': <module 'Framework.api.runtimekit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\runtimekit.pyc'>, 'Framework.api.datetime': None, 'Framework.components.base64': None, 'tornado.ssl': None, 'optparse': <module 'optparse' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\optparse.py'>, 'requests.collections': None, 'requests.StringIO': None, 'requests.struct': None, '_MozillaCookieJar': <module '_MozillaCookieJar' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\_MozillaCookieJar.py'>, 'urllib3.util.connection': <module 'urllib3.util.connection' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\util\\connection.py'>, 'email': <module 'email' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\email\\__init__.py'>, 'Framework.interfaces.base': <module 'Framework.interfaces.base' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\interfaces\\base.pyc'>, 'requests.urllib': None, 'pyamf.util.cStringIO': None, 'Framework.handlers.resources': <module 'Framework.handlers.resources' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\handlers\\resources.pyc'>, 'Framework.api.errno': None, 'pyamf.adapters.glob': None, 'Framework.api.agentkit': <module 'Framework.api.agentkit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\agentkit.pyc'>, 'Queue': <module 'Queue' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\Queue.py'>, 'compiler.sys': None, 'ctypes': <module 'ctypes' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\ctypes\\__init__.py'>, 'tornado.select': None, 'requests.simplejson': None, 'Framework.policies.servicepolicy': <module 'Framework.policies.servicepolicy' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\policies\\servicepolicy.pyc'>, 'certifi.os': None, 'Framework.code': <module 'Framework.code' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\code\\__init__.pyc'>, 'Framework.components.debugging': <module 'Framework.components.debugging' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\components\\debugging.pyc'>, 'uuid': <module 'uuid' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\uuid.py'>, 'json.re': None, 'Framework.modelling.weakref': None, 'requests.time': None, 'Framework.code.weakref': None, 'requests.packages.urllib3.connection': <module 'requests.packages.urllib3.connection' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\connection.py'>, 'crypto.hash.hash': <module 'crypto.hash.hash' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\crypto\\hash\\hash.pyc'>, 'tornado.threading': None, 'itertools': <module 'itertools' (built-in)>, 'opcode': <module 'opcode' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\opcode.py'>, 'Framework.api.localekit': <module 'Framework.api.localekit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\localekit.pyc'>, 'Framework.Framework': None, 'Framework.api.sys': None, 'Framework.api.textwrap': None, 'requests.warnings': None, 'Framework.modelling.os': None, 'urllib3.poolmanager': <module 'urllib3.poolmanager' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\poolmanager.py'>, 'tornado.traceback': None, 'logging.errno': None, 'encodings.unicode_escape': <module 'encodings.unicode_escape' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\encodings\\unicode_escape.py'>, 'crypto.hash.md5': None, 'demjson': <module 'demjson' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\demjson.pyc'>, 'pkgutil': <module 'pkgutil' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\pkgutil.py'>, 'routes.route': <module 'routes.route' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\routes\\route.pyc'>, 'BeautifulSoup': <module 'BeautifulSoup' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\BeautifulSoup.pyc'>, 'logging.struct': None, 'sre_constants': <module 'sre_constants' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\sre_constants.py'>, 'json': <module 'json' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\json\\__init__.py'>, 'pyamf.adapters._collections': <module 'pyamf.adapters._collections' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\pyamf\\adapters\\_collections.pyc'>, 'Framework.api.servicekit': <module 'Framework.api.servicekit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\servicekit.pyc'>, 'Framework.components.data': <module 'Framework.components.data' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\components\\data.pyc'>, 'certifi': <module 'certifi' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\certifi\\__init__.py'>, 'Framework.components.gzip': None, 'urllib3.filepost': <module 'urllib3.filepost' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\filepost.py'>, 'requests.packages.urllib3._collections': <module 'requests.packages.urllib3._collections' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\_collections.py'>, 'Framework.components.notifications': <module 'Framework.components.notifications' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\components\\notifications.pyc'>, 'requests.packages.urllib3.util.connection': <module 'requests.packages.urllib3.util.connection' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\util\\connection.py'>, 'pyamf.util.struct': None, 'Framework.policies.Framework': None, 'ndg.httpsclient.ssl_peer_verification': <module 'ndg.httpsclient.ssl_peer_verification' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\ndg\\httpsclient\\ssl_peer_verification.py'>, 'requests.utils': <module 'requests.utils' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\utils.py'>, 'logging.atexit': None, 'Framework.handlers.Framework': None, 'crypto.cipher.crypto': None, 'contextlib': <module 'contextlib' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\contextlib.py'>, 'email.MIMENonMultipart': <email.LazyImporter object at 0x015373D0>, 'email.email': None, 'urllib3.util.url': <module 'urllib3.util.url' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\util\\url.py'>, 'Framework.components.messaging': <module 'Framework.components.messaging' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\components\\messaging.pyc'>, 'requests.packages.urllib3.util.ssl_': <module 'requests.packages.urllib3.util.ssl_' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\util\\ssl_.py'>, 'zlib': <module 'zlib' (built-in)>, 'simplejson.re': None, 'pyasn1.codec.cer': <module 'pyasn1.codec.cer' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\codec\\cer\\__init__.py'>, 'email.random': None, 'requests.certifi': None, 'tornado.stat': None, 'Framework.handlers.cookielib': None, 'Framework.api.types': None, 'ndg.httpsclient': <module 'ndg.httpsclient' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\ndg\\httpsclient\\__init__.py'>, 'Framework.interfaces.tornado': None, 'copy_reg': <module 'copy_reg' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\copy_reg.py'>, 'logging.logging': None, 'RestrictedPython.RestrictionMutator': <module 'RestrictedPython.RestrictionMutator' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\RestrictedPython\\RestrictionMutator.pyc'>, 'Framework.base': <module 'Framework.base' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\base.pyc'>, 'ndg.httpsclient.re': None, 'site': <module 'site' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\site.py'>, 'requests.packages.urllib3.filepost': <module 'requests.packages.urllib3.filepost' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\filepost.py'>, 'Framework.components.datetime': None, 'Framework.api.plistlib': None, 'io': <module 'io' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\io.py'>, 'pyamf.remoting.client.urlparse': None, 'pyexpat': <module 'pyexpat' from 'C:\\Program Files\\Plex\\Plex Media Server\\DLLs\\pyexpat.pyd'>, 'shutil': <module 'shutil' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\shutil.py'>, 'lxml.html.re': None, 'tornado.re': None, 'Framework.api.math': None, 'pyamf.util.sys': None, 'lxml.sys': None, 'compiler.pycodegen': <module 'compiler.pycodegen' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\compiler\\pycodegen.py'>, 'xml.sax.handler': <module 'xml.sax.handler' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\xml\\sax\\handler.py'>, 'requests.sys': None, 'pyasn1.codec.ber.eoo': <module 'pyasn1.codec.ber.eoo' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\codec\\ber\\eoo.py'>, 'encodings.hex_codec': <module 'encodings.hex_codec' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\encodings\\hex_codec.py'>, 'requests.packages.urllib3.util.response': <module 'requests.packages.urllib3.util.response' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\util\\response.py'>, 'tornado.binascii': None, 'pyamf.remoting': <module 'pyamf.remoting' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\pyamf\\remoting\\__init__.pyc'>, 'lxml.html.BeautifulSoup': None, 'pyamf.types': None, 'Framework.cerealizer': None, 'pyasn1.type.useful': <module 'pyasn1.type.useful' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\type\\useful.py'>, 'subprocess_new': <module 'subprocess_new' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\subprocess_new.pyc'>, 'rfc822': <module 'rfc822' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\rfc822.py'>, 'json.json': None, 'email.re': None, 'Framework.components.OpenSSL': None, 'Framework.code.binascii': None, 'sys': <module 'sys' (built-in)>, 'Framework.api.streamkit': <module 'Framework.api.streamkit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\streamkit.pyc'>, 'xml.sax.sys': None, 'tornado.httpserver': <module 'tornado.httpserver' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\tornado\\httpserver.pyc'>, 'requests.hooks': <module 'requests.hooks' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\hooks.py'>, 'email.Header': <email.LazyImporter object at 0x01529F50>, 'tornado.httplib': None, 'RestrictedPython': <module 'RestrictedPython' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\RestrictedPython\\__init__.pyc'>, 'dateutil.string': None, 'Framework.modelling.templates': <module 'Framework.modelling.templates' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\modelling\\templates.pyc'>, 'tornado.cgi': None, '_weakref': <module '_weakref' (built-in)>, 'requests.cookielib': None, 'Framework.modelling.attributes': <module 'Framework.modelling.attributes' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\modelling\\attributes.pyc'>, 'email.MIMEMultipart': <email.LazyImporter object at 0x015373B0>, 'urlparse': <module 'urlparse' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\urlparse.py'>, 'dateutil.parser': <module 'dateutil.parser' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\dateutil\\parser.pyc'>, 'tornado.locale': <module 'tornado.locale' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\tornado\\locale.pyc'>, 'gzip': <module 'gzip' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\gzip.py'>, 'requests.status_codes': <module 'requests.status_codes' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\status_codes.py'>, 'Framework.objects': <module 'Framework.objects' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\objects.pyc'>, 'pyamf.pyamf': None, 'urllib3.util.response': <module 'urllib3.util.response' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\util\\response.py'>, 'Framework.api.logkit': <module 'Framework.api.logkit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\logkit.pyc'>, 'heapq': <module 'heapq' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\heapq.py'>, 'xml.sax.urlparse': None, 'Framework.modelling.datetime': None, 'tornado.json': None, 'Framework.handlers.services': <module 'Framework.handlers.services' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\handlers\\services.pyc'>, 'tornado.os': None, 'pyasn1.codec.der': <module 'pyasn1.codec.der' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\codec\\der\\__init__.py'>, 'subsystem.weakref': None, 'Framework.modelling.combination': <module 'Framework.modelling.combination' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\modelling\\combination.pyc'>, 'email.mime': <module 'email.mime' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\email\\mime\\__init__.py'>, 'msvcrt': <module 'msvcrt' (built-in)>, 'requests.packages.chardet': <module 'requests.packages.chardet' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\chardet\\__init__.py'>, 'struct': <module 'struct' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\struct.py'>, 'xml.parsers.pyexpat': None, 'Framework.components.plistlib': None, 'xml.sax.urllib': None, 'subsystem.os': None, 'Framework': <module 'Framework' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\__init__.pyc'>, 'Framework.mimetypes': None, 'email.warnings': None, 'collections': <module 'collections' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\collections.py'>, 'Framework.api.crypto': None, 'logging.socket': None, 'email.Parser': <email.LazyImporter object at 0x01529FB0>, 'compiler.ast': <module 'compiler.ast' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\compiler\\ast.py'>, 'zipimport': <module 'zipimport' (built-in)>, 'pyasn1.type.namedval': <module 'pyasn1.type.namedval' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\type\\namedval.py'>, 'Framework.re': None, 'pyasn1.pyasn1': None, 'dateutil.time': None, 'textwrap': <module 'textwrap' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\textwrap.py'>, 'certifi.warnings': None, 'requests.packages.urllib3.response': <module 'requests.packages.urllib3.response' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\response.py'>, 'Framework.components.errno': None, 'urllib3.util.request': <module 'urllib3.util.request' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\util\\request.py'>, 'Framework.api.BeautifulSoup': None, 'Framework.api.pyamf': None, 'pyamf.util.datetime': None, 'crypto.hash': <module 'crypto.hash' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\crypto\\hash\\__init__.pyc'>, 'signal': <module 'signal' (built-in)>, 'xml.parsers': <module 'xml.parsers' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\xml\\parsers\\__init__.py'>, 'Framework.api.base': <module 'Framework.api.base' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\base.pyc'>, 'RestrictedPython.Guards': <module 'RestrictedPython.Guards' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\RestrictedPython\\Guards.pyc'>, 'Framework.modelling.Framework': None, 'ndg.modulefinder': None, 'requests.socket': None, 'requests.packages.urllib3.poolmanager': <module 'requests.packages.urllib3.poolmanager' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\poolmanager.py'>, 'Framework.core': <module 'Framework.core' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\core.pyc'>, 'quopri': <module 'quopri' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\quopri.py'>, 'tornado.types': None, 'lxml.io': None, 'Framework.code.threading': None, 'requests.packages.urllib3.contrib': <module 'requests.packages.urllib3.contrib' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\contrib\\__init__.py'>, 'mimetypes': <module 'mimetypes' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\mimetypes.py'>, 'ndg.pkgutil': None, 'Framework.api.cloudkit': <module 'Framework.api.cloudkit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\cloudkit.pyc'>, 'xml.parsers.expat': <module 'xml.parsers.expat' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\xml\\parsers\\expat.py'>, '_winreg': <module '_winreg' (built-in)>, 'urllib3.util.retry': <module 'urllib3.util.retry' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\util\\retry.py'>, 'Framework.exceptions': <module 'Framework.exceptions' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\exceptions.pyc'>, 'Framework.policies.base': <module 'Framework.policies.base' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\policies\\base.pyc'>, 'logging.traceback': None, 'requests.re': None, 'Framework.api.email': None, 'tornado.stack_context': <module 'tornado.stack_context' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\tornado\\stack_context.pyc'>, 'pyamf.remoting.client.cStringIO': None, 'email.MIMEAudio': <email.LazyImporter object at 0x015373F0>, 'pyasn1.type.sys': None, 'dateutil.cStringIO': None, 'crypto.hash.crypto': None, 'Framework.api.dateutil': None, 'tornado.itertools': None, 'routes.lru': <module 'routes.lru' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\routes\\lru.pyc'>, 'glob': <module 'glob' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\glob.py'>, 'cgi': <module 'cgi' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\cgi.py'>, 'requests.packages.urllib3.packages.sys': None, 'pyasn1.type.operator': None, 'UserDict': <module 'UserDict' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\UserDict.py'>, 'inspect': <module 'inspect' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\inspect.py'>, 'Framework.interfaces.sys': None, 'pyamf.python': <module 'pyamf.python' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\pyamf\\python.pyc'>, 'tornado.escape': <module 'tornado.escape' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\tornado\\escape.pyc'>, 'pyasn1.type.char': <module 'pyasn1.type.char' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\type\\char.py'>, 'Framework.api.os': None, 'Framework.modelling.sys': None, 'logging.sys': None, 'lxml.gzip': None, 'crypto.cipher': <module 'crypto.cipher' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\crypto\\cipher\\__init__.pyc'>, 'dateutil.calendar': None, 'compiler.visitor': <module 'compiler.visitor' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\compiler\\visitor.py'>, '_functools': <module '_functools' (built-in)>, 'Framework.components.os': None, 'email.Iterators': <email.LazyImporter object at 0x01529F70>, 'socket': <module 'socket' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\socket.py'>, 'simplejson.compat': <module 'simplejson.compat' from 'C:\\Program Files\\Plex\\Plex Media Server\\Exts\\simplejson\\compat.pyc'>, 'email.base64MIME': <email.LazyImporter object at 0x01537050>, 'ndg': <module 'ndg' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\ndg\\__init__.py'>, 'email.Charset': <email.LazyImporter object at 0x01529DF0>, 'lxml._elementpath': <module 'lxml._elementpath' from 'C:\\Program Files\\Plex\\Plex Media Server\\Exts\\lxml\\_elementpath.pyc'>, 'os': <module 'os' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\os.py'>, 'marshal': <module 'marshal' (built-in)>, 'lxml.objectify': <module 'lxml.objectify' from 'C:\\Program Files\\Plex\\Plex Media Server\\Exts\\lxml\\objectify.pyd'>, 'urllib3.connectionpool': <module 'urllib3.connectionpool' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\connectionpool.py'>, 'Framework.modelling.classes': <module 'Framework.modelling.classes' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\modelling\\classes.pyc'>, 'Framework.handlers.base': <module 'Framework.handlers.base' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\handlers\\base.pyc'>, 'routes.os': None, 'Framework.api.copy': None, 'Framework.interfaces.socket': None, 'OpenSSL.version': <module 'OpenSSL.version' from 'C:\\Program Files\\Plex\\Plex Media Server\\Exts\\OpenSSL\\version.pyc'>, '__builtin__': <module '__builtin__' (built-in)>, 'Framework.code.preferences': <module 'Framework.code.preferences' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\code\\preferences.pyc'>, 'tornado.ctypes': None, 'xml.sax.xmlreader': <module 'xml.sax.xmlreader' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\xml\\sax\\xmlreader.py'>, 'operator': <module 'operator' (built-in)>, 'requests.packages.urllib3.packages.ssl_match_hostname': <module 'requests.packages.urllib3.packages.ssl_match_hostname' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\packages\\ssl_match_hostname\\__init__.py'>, 'Framework.modelling.namespace': <module 'Framework.models.metadata.com_plexapp_plugins_viaplay' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\modelling\\namespace.pyc'>, 'json.struct': None, 'lxml.html.threading': None, 'pyamf.adapters.__builtin__': None, 'Framework.components.sys': None, 'errno': <module 'errno' (built-in)>, '_socket': <module '_socket' from 'C:\\Program Files\\Plex\\Plex Media Server\\DLLs\\_socket.pyd'>, 'Framework.components.__future__': None, 'urllib3.request': <module 'urllib3.request' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\request.py'>, 'Framework.handlers.sys': None, 'Cookie': <module 'Cookie' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\Cookie.py'>, 'urllib3.util': <module 'urllib3.util' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\util\\__init__.py'>, 'urllib3._collections': <module 'urllib3._collections' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\_collections.py'>, 'simplejson.encoder': <module 'simplejson.encoder' from 'C:\\Program Files\\Plex\\Plex Media Server\\Exts\\simplejson\\encoder.pyc'>, '_warnings': <module '_warnings' (built-in)>, 'compiler.compiler': None, 'encodings.__builtin__': None, 'routes.sys': None, 'simplejson': <module 'simplejson' from 'C:\\Program Files\\Plex\\Plex Media Server\\Exts\\simplejson\\__init__.pyc'>, 'Framework.interfaces.pipeinterface': <module 'Framework.interfaces.pipeinterface' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\interfaces\\pipeinterface.pyc'>, 'email.os': None, 'cerealizer.datetime': None, 'pyamf.adapters.array': None, 'RestrictedPython.PrintCollector': <module 'RestrictedPython.PrintCollector' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\RestrictedPython\\PrintCollector.pyc'>, u'viaplaylib': <module '?' (built-in)>, 'pyamf.adapters.util': <module 'pyamf.adapters.util' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\pyamf\\adapters\\util.pyc'>, 'Framework.api.time': None, 'crypto.keyedHash': <module 'crypto.keyedHash' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\crypto\\keyedHash\\__init__.pyc'>, '_struct': <module '_struct' (built-in)>, 'requests.packages': <module 'requests.packages' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\__init__.py'>, 'crypto.hash.binascii': None, 'crypto.keyedHash.crypto': None, 'logging.time': None, 'pyamf.adapters.os': None, 'crypto.cipher.cbc': <module 'crypto.cipher.cbc' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\crypto\\cipher\\cbc.pyc'>, 'tornado.signal': None, 'pyasn1.codec': <module 'pyasn1.codec' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\codec\\__init__.py'>, 'logging.warnings': None, 'xml.sax.os': None, 'Framework.handlers.messaging': <module 'Framework.handlers.messaging' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\handlers\\messaging.pyc'>, 'mimetools': <module 'mimetools' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\mimetools.py'>, 'subsystem.ospathfix': <module 'subsystem.ospathfix' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\subsystem\\ospathfix.pyc'>, 'xml.sax': <module 'xml.sax' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\xml\\sax\\__init__.py'>, 'logging.codecs': None, '_random': <module '_random' (built-in)>, 'pyasn1.codec.ber.pyasn1': None, 'parser': <module 'parser' (built-in)>, 'Framework.components.re': None, 'Framework.policies.elevatedpolicy': <module 'Framework.policies.elevatedpolicy' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\policies\\elevatedpolicy.pyc'>, 'Framework.api.base64': None, 'lxml.html.urlparse': None, 'RestrictedPython.RCompile': <module 'RestrictedPython.RCompile' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\RestrictedPython\\RCompile.pyc'>, 'email.Generator': <email.LazyImporter object at 0x01529F10>, 'lxml.html.defs': <module 'lxml.html.defs' from 'C:\\Program Files\\Plex\\Plex Media Server\\Exts\\lxml\\html\\defs.pyc'>, 'requests.packages.urllib3.connectionpool': <module 'requests.packages.urllib3.connectionpool' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\connectionpool.py'>, 'pyamf.util.pyamf': None, 'linecache': <module 'linecache' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\linecache.py'>, 'subsystem.shutil': None, 'requests.packages.urllib3.packages._abcoll': None, 'gettext': <module 'gettext' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\gettext.py'>, 'lxml.html.copy': None, 'requests.packages.urllib3.util.timeout': <module 'requests.packages.urllib3.util.timeout' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\util\\timeout.py'>, '_abcoll': <module '_abcoll' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\_abcoll.py'>, 'Framework.components.Queue': None, 'Framework.code.__future__': None, 'subsystem.types': None, 'nt': <module 'nt' (built-in)>, 'Framework.policies.unpicklepolicy': <module 'Framework.policies.unpicklepolicy' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\policies\\unpicklepolicy.pyc'>, 'requests.packages.urllib3.request': <module 'requests.packages.urllib3.request' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\requests\\packages\\urllib3\\request.py'>, 'xml.sax._exceptions': <module 'xml.sax._exceptions' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\xml\\sax\\_exceptions.py'>, 'genericpath': <module 'genericpath' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\genericpath.py'>, 'stat': <module 'stat' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\stat.py'>, 'Framework.handlers.urllib': None, 'Framework.api.corekit': <module 'Framework.api.corekit' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\api\\corekit.pyc'>, 'pyasn1.codec.ber': <module 'pyasn1.codec.ber' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\codec\\ber\\__init__.py'>, 'Framework.os': None, 'symbol': <module 'symbol' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\symbol.py'>, 'pyasn1.codec.der.decoder': <module 'pyasn1.codec.der.decoder' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\pyasn1\\codec\\der\\decoder.py'>, 'urllib3': <module 'urllib3' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\__init__.py'>, 'urllib2': <module 'urllib2' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\urllib2.py'>, 'crypto.keyedHash.pbkdf2': <module 'crypto.keyedHash.pbkdf2' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\crypto\\keyedHash\\pbkdf2.pyc'>, 'Framework.components.cookielib': None, 'cerealizer.new': None, 'email.Encoders': <email.LazyImporter object at 0x01529E30>, 'email.utils': <module 'email.utils' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\email\\utils.py'>, 'ctypes.ctypes': None, 'requests.calendar': None, 'urllib3.packages.ssl_match_hostname': <module 'urllib3.packages.ssl_match_hostname' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Viaplay.bundle\\Contents\\Libraries\\Shared\\urllib3\\packages\\ssl_match_hostname\\__init__.py'>, 'Framework.time': None, 'pyamf._version': <module 'pyamf._version' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\pyamf\\_version.pyc'>, 'xmlrpclib': <module 'xmlrpclib' from 'C:\\Program Files\\Plex\\Plex Media Server\\python27.zip\\xmlrpclib.py'>, 'crypto.cipher.random': None, 'Framework.interfaces.Framework': None, 'crypto.hash.md5Hash': <module 'crypto.hash.md5Hash' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\crypto\\hash\\md5Hash.pyc'>, 'pyamf.remoting.client.gzip': None, 'time': <module 'time' (built-in)>, 'Framework.components.networking': <module 'Framework.components.networking' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Versions\\2\\Python\\Framework\\components\\networking.pyc'>, 'dateutil.datetime': None, 'compiler.marshal': None, 'tornado.ioloop': <module 'tornado.ioloop' from 'C:\\Documents and Settings\\Owner\\Local Settings\\Application Data\\Plex Media Server\\Plug-ins\\Framework.bundle\\Contents\\Resources\\Platforms\\Shared\\Libraries\\tornado\\ioloop.pyc'>}`\n",
"It seems OpenSSL is taken from \nc:\\Program Files\\Plex\\Plex Media Server\\Exts\\OpenSSL\nIts version.py says\n`\"\"\"\npyOpenSSL - A simple wrapper around the OpenSSL library\n\"\"\"\n\n**version** = '0.11'`\n\nNot sure if this may be the problem...\n",
"That is absolutely the problem. That module is _ancient_.\n",
"Hmm, too bad. Not sure I can override it - I just tried to replace it, but it made Plex run extremly slow. It seems they made pyd files of SSL and crypto. I might try it later on again.\nAnyhow - thx for your help!\n",
"I try to solve my issue anyhow - by simply renaming all OpenSSL to myOpenSSL. This to be able to override the pyOpenSSL provided by Plex.\nAnyhow - I seem to get a bit further and now get this problem:\n\"No module named _openssl\"\n\nWhich I believe comes from the cryptography module:\n`from cryptography.hazmat.bindings._openssl import ffi as _ffi`\n\nFrom the downloaded cryptography module - there's no \n`cryptography\\hazmat\\bindings\\_openssl`\nJust a \n`cryptography\\hazmat\\bindings\\openssl`\n\nDo you know anything about this?\n\nEDIT:\nI realized that my local Python installation had a _openssl - so I copied cryptography from there instead,\nBut then I'm not sure it's OS independent? Or perhaps not evenet mahcine independent?\nIf I get the plugin working it may only work on windows? Or worse - it will only work with my machin/python installation?\n\nHmm I guess it needs my installation - since it didn't work on my machine even...\n`ImportError: DLL load failed: The specified module could not be found.`\n",
"That strongly suggests that your installation is still not working properly.\n"
] |
https://api.github.com/repos/psf/requests/issues/2734
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2734/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2734/comments
|
https://api.github.com/repos/psf/requests/issues/2734/events
|
https://github.com/psf/requests/issues/2734
| 101,969,104 |
MDU6SXNzdWUxMDE5NjkxMDQ=
| 2,734 |
PyOpenSSL support doesn't work with TLSv1.1 and TLSv1.2
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3266662?v=4",
"events_url": "https://api.github.com/users/itamarst/events{/privacy}",
"followers_url": "https://api.github.com/users/itamarst/followers",
"following_url": "https://api.github.com/users/itamarst/following{/other_user}",
"gists_url": "https://api.github.com/users/itamarst/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/itamarst",
"id": 3266662,
"login": "itamarst",
"node_id": "MDQ6VXNlcjMyNjY2NjI=",
"organizations_url": "https://api.github.com/users/itamarst/orgs",
"received_events_url": "https://api.github.com/users/itamarst/received_events",
"repos_url": "https://api.github.com/users/itamarst/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/itamarst/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/itamarst/subscriptions",
"type": "User",
"url": "https://api.github.com/users/itamarst",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-08-19T18:42:37Z
|
2021-09-08T22:00:58Z
|
2015-08-20T01:04:51Z
|
NONE
|
resolved
|
`docker-py` tries to use latest protocol version in the `ssl` module, so use `ssl.PROTOCOL_TLSv1_2`. Unfortunately the version of urllib3 included with requests (and likely upstream?) only has older versions:
https://github.com/kennethreitz/requests/blob/master/requests/packages/urllib3/contrib/pyopenssl.py#L71
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2734/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2734/timeline
| null |
completed
| null | null | false |
[
"So raise this issue against urllib3?\n"
] |
https://api.github.com/repos/psf/requests/issues/2733
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2733/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2733/comments
|
https://api.github.com/repos/psf/requests/issues/2733/events
|
https://github.com/psf/requests/issues/2733
| 101,965,736 |
MDU6SXNzdWUxMDE5NjU3MzY=
| 2,733 |
"Interrupted System Call" in select.select
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/41057?v=4",
"events_url": "https://api.github.com/users/samv/events{/privacy}",
"followers_url": "https://api.github.com/users/samv/followers",
"following_url": "https://api.github.com/users/samv/following{/other_user}",
"gists_url": "https://api.github.com/users/samv/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/samv",
"id": 41057,
"login": "samv",
"node_id": "MDQ6VXNlcjQxMDU3",
"organizations_url": "https://api.github.com/users/samv/orgs",
"received_events_url": "https://api.github.com/users/samv/received_events",
"repos_url": "https://api.github.com/users/samv/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/samv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/samv/subscriptions",
"type": "User",
"url": "https://api.github.com/users/samv",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-08-19T18:26:42Z
|
2021-09-08T22:00:57Z
|
2015-08-20T04:56:39Z
|
NONE
|
resolved
|
Hi there,
The `pyopenssl.py` under `requests/packages/urllib3/contrib/pyopenssl.py` is using `select.select` without trapping the exception raised when the underlying _select(2)_ system call returns EINTR. This results in an exception:
```
response = session.request(method, full_url, params=params, timeout=TIMEOUT, headers=HTTP_HEADERS)
File ".../.virtualenv/local/lib/python2.7/site-packages/requests/sessions.py", line 465, in request
resp = self.send(prep, **send_kwargs)
File ".../.virtualenv/local/lib/python2.7/site-packages/requests/sessions.py", line 573, in send
r = adapter.send(request, **kwargs)
File ".../.virtualenv/local/lib/python2.7/site-packages/requests/adapters.py", line 370, in send
timeout=timeout
File ".../.virtualenv/local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 544, in urlopen
body=body, headers=headers)
File ".../.virtualenv/local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 372, in _make_request
httplib_response = conn.getresponse(buffering=True)
File "/usr/lib/python2.7/httplib.py", line 1127, in getresponse
response.begin()
File "/usr/lib/python2.7/httplib.py", line 453, in begin
version, status, reason = self._read_status()
File "/usr/lib/python2.7/httplib.py", line 409, in _read_status
line = self.fp.readline(_MAXLINE + 1)
File "/usr/lib/python2.7/socket.py", line 480, in readline
data = self._sock.recv(self._rbufsize)
File ".../.virtualenv/local/lib/python2.7/site-packages/requests/packages/urllib3/contrib/pyopenssl.py", line 184, in recv
[self.socket], [], [], self.socket.gettimeout())
select.error: Interrupted system call
```
Current versions of pyopenssl don't make these calls; perhaps this can be fixed by updating the internal dependency?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2733/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2733/timeline
| null |
completed
| null | null | false |
[
"Thanks for reporting this! Unfortunately, this is a urllib3 problem: can you raise this issue over there?\n",
"Thanks, logged as shazow/urllib3#700 - I'll follow up with a request to update the internal urllib3 dependency once they deal with it there.\n"
] |
https://api.github.com/repos/psf/requests/issues/2732
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2732/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2732/comments
|
https://api.github.com/repos/psf/requests/issues/2732/events
|
https://github.com/psf/requests/issues/2732
| 101,857,235 |
MDU6SXNzdWUxMDE4NTcyMzU=
| 2,732 |
file:// protocol not available
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/2722756?v=4",
"events_url": "https://api.github.com/users/Moliholy/events{/privacy}",
"followers_url": "https://api.github.com/users/Moliholy/followers",
"following_url": "https://api.github.com/users/Moliholy/following{/other_user}",
"gists_url": "https://api.github.com/users/Moliholy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Moliholy",
"id": 2722756,
"login": "Moliholy",
"node_id": "MDQ6VXNlcjI3MjI3NTY=",
"organizations_url": "https://api.github.com/users/Moliholy/orgs",
"received_events_url": "https://api.github.com/users/Moliholy/received_events",
"repos_url": "https://api.github.com/users/Moliholy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Moliholy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Moliholy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Moliholy",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-08-19T10:23:00Z
|
2021-09-08T22:00:58Z
|
2015-08-19T11:40:59Z
|
NONE
|
resolved
|
Hello all, and first of all thanks for this awesome library.
While working with requests I was surprised to find out that it doesn't handle the file:// protocol. Even though I understand it's maybe not a key feature of this library it would come in handy for compatibility reasons.
Concretely I have sort of a 'Fetcher' class that servers files from a 'Repository', but this repository can be local or remote. In case of being local I tried (unsuccessfully, of course) to use the file:// protocol. Finally it forced me to considerably increase the number of lines of code I needed to handle the issue.
For example, something like this would be fine:
```
response = requests.get('file:///Users/User/my_file.txt')
```
So far it raises this exception:
```
File "/usr/local/lib/python2.7/site-packages/requests/sessions.py", line 649, in get_adapter
raise InvalidSchema("No connection adapters were found for '%s'" % url)
requests.exceptions.InvalidSchema: No connection adapters were found for 'file:///Users/User/my_file.txt'
```
My questions are:
1) Would there be a reason to not to implement this feature?
2) In case there isn't, shall I submit a a pull request, or it is already planned to add this functionality soon?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 2,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 2,
"url": "https://api.github.com/repos/psf/requests/issues/2732/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2732/timeline
| null |
completed
| null | null | false |
[
"Thanks for this issue!\n\nThe reason we don't support the `file://` protocol is because requests is a HTTP library. Our core purpose is to do HTTP: anything else is outside the scope of the core library.\n\nI believe there is a pluggable Transport Adapter for the file protocol floating around. You can also consider adapting one from [this answer](http://stackoverflow.com/a/22989322).\n",
"Before opening issues, please search all issues (not just open ones) for similar issues. [This](https://github.com/kennethreitz/requests/issues/847) is just the earliest issue I could find and there are several others (including pull requests).\n"
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.