url
stringlengths 50
53
| repository_url
stringclasses 1
value | labels_url
stringlengths 64
67
| comments_url
stringlengths 59
62
| events_url
stringlengths 57
60
| html_url
stringlengths 38
43
| id
int64 597k
2.65B
| node_id
stringlengths 18
32
| number
int64 1
6.83k
| title
stringlengths 1
296
| user
dict | labels
listlengths 0
5
| state
stringclasses 2
values | locked
bool 2
classes | assignee
dict | assignees
listlengths 0
4
| milestone
dict | comments
int64 0
211
| created_at
stringlengths 20
20
| updated_at
stringlengths 20
20
| closed_at
stringlengths 20
20
⌀ | author_association
stringclasses 3
values | active_lock_reason
stringclasses 4
values | body
stringlengths 0
65.6k
⌀ | closed_by
dict | reactions
dict | timeline_url
stringlengths 59
62
| performed_via_github_app
null | state_reason
stringclasses 3
values | draft
bool 2
classes | pull_request
dict | is_pull_request
bool 2
classes | issue_comments
listlengths 0
30
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/psf/requests/issues/2630
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2630/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2630/comments
|
https://api.github.com/repos/psf/requests/issues/2630/events
|
https://github.com/psf/requests/pull/2630
| 85,420,258 |
MDExOlB1bGxSZXF1ZXN0MzcwMDA1MDU=
| 2,630 |
Declare tests_require and hook up 'test' command
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1011612?v=4",
"events_url": "https://api.github.com/users/koobs/events{/privacy}",
"followers_url": "https://api.github.com/users/koobs/followers",
"following_url": "https://api.github.com/users/koobs/following{/other_user}",
"gists_url": "https://api.github.com/users/koobs/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/koobs",
"id": 1011612,
"login": "koobs",
"node_id": "MDQ6VXNlcjEwMTE2MTI=",
"organizations_url": "https://api.github.com/users/koobs/orgs",
"received_events_url": "https://api.github.com/users/koobs/received_events",
"repos_url": "https://api.github.com/users/koobs/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/koobs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/koobs/subscriptions",
"type": "User",
"url": "https://api.github.com/users/koobs",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 14 |
2015-06-05T04:39:31Z
|
2021-09-08T05:01:00Z
|
2016-01-30T03:49:28Z
|
CONTRIBUTOR
|
resolved
|
This change allows the existing test script (test_requests.py) to be invoked via the standard setuptools test command. It also declares pytest as a test_dependency, so that it is installed on a test run, if not available.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2630/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2630/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2630.diff",
"html_url": "https://github.com/psf/requests/pull/2630",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2630.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2630"
}
| true |
[
"Hey @koobs, thanks for the PR. Can I ask why you're adding this?\n",
"@sigmavirus24\n\nTLDR: Best practice python packaging.\n\nLonger version:\n\nThe 'test' command is the canonical method for running tests in Python land (ala make check for autotools projects) independent to how or what tests are run, or the tools that get used.\n\nIt also makes for a great downstream (users and os packaging) experience so we/they can QA, orthogonally to how an upstream might do 'development' testing (read: tox, travis, whatever)\n\nFor me (and FreeBSD), I have the following in the port for requests, so that I can QA updates and commit changes quicker with confidence.\n\n```\nregression-test: build\n @cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test\n```\n",
"If you want to derive *_requires *_require from requirements files, that's fine (and probably good so they're only referenced in one place).\n\nIn that case distinctions should be made between pre-release \"development testing\" and post-release testing requirements.\n\nAdditionally, distinctions between 'compulsory' requirements and optional test requirements (coverage, etc) in the same way extras_require is used for optional runtime dependencies.\n\nFor proper context and detail see: [cryptography Issue #764 comment](https://github.com/pyca/cryptography/issues/764#issuecomment-37152604)\n",
"I have no objection to this, though it's off the mainline development path and therefore runs the risk of getting overlooked if we ever change our test dependencies (unlikely).\n",
"Correct me if I'm wrong, (I posted my question right before going to sleep) but this doesn't actually run the tests with py.test. Don't we need a py.test setuptools command in the code and registered as `test_class` or something like that?\n\nFurther, doesn't `setuptools` still use unverified TLS to download the test dependencies when someone who doesn't already have `pytest` installed runs `python setup.py test`?\n",
"> Correct me if I'm wrong, (I posted my question right before going to sleep) but this doesn't actually run the tests with py.test. Don't we need a py.test setuptools command in the code and registered as test_class or something like that?\n\nProbably\n\n> Further, doesn't setuptools still use unverified TLS to download the test dependencies when someone who doesn't already have pytest installed runs python setup.py test?\n\nI was told at DjangoCon EU that setuptools has been improved in that regard: @dstufft?\n",
"[This](https://pytest.org/latest/goodpractises.html#integration-with-setuptools-test-commands) seems like it's probably pretty relevant.\n",
"@Lukasa that command class is definitely what I had in mind. Without using py.test to _run_ the tests, only a fraction of them will be run since we have test functions that aren't attached to any test class that `unittest` could discover.\n\nAlso, regarding unverified TLS, I hope that setuptools has improved it but I'd be skeptical. It'd have to load certificates from somewhere and I doubt that it is also willing to vendor them. (The problem may be mostly alleviated on 2.7.9+ or 3.x, but that still leaves tons of people on systems without those versions in a lurch.) That said, I like being friendly to our downstream redistributors, so I'm happy to accept work to make `python setup.py test` work, but I think we need to actively discourage contributors from using it given the security concerns.\n",
"setuptools will (probably) use verified TLS if it's 0.7+, however it still will hit random websites on the internet which may or may not be HTTPS so it's certainly not \"safe\" by default. You can add a thing to your setup.cfg to tell setuptools to only accept pypi.python.org though (or to not install anything at all, just exist for the test dependency declaration).\n",
"This seems harmless, and certainly inline with the expectations of `setup.py` oriented workflows. However the fact that running `test_requests` directly won't result in a full run of our test suite (though it should), I'm going to close this.\n",
"@kennethreitz Where is the full test suite and how is it run?\n",
"@koobs it is all contained in `test_requests.py`, but it does not all use the unittest framework, instead relying on py.test to automatically pick up some functions and run them as tests. \n\nThis should be fixed, in my opinion. I see no reason to be lazy just because we're using py.test.\n",
"It's not laziness: we _actively_ use pytest. We import helpers from it, we use its assertion style, the whole nine yards.\n",
"I'll create a separate PR for proper integration as per [pytest: Good Integration Practices](http://pytest.org/latest/goodpractises.html#manual-integration)\n"
] |
https://api.github.com/repos/psf/requests/issues/2629
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2629/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2629/comments
|
https://api.github.com/repos/psf/requests/issues/2629/events
|
https://github.com/psf/requests/issues/2629
| 84,977,975 |
MDU6SXNzdWU4NDk3Nzk3NQ==
| 2,629 |
Connection pool not recycling connections on timeout or connection exceptions
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/12744068?v=4",
"events_url": "https://api.github.com/users/jlatherfold/events{/privacy}",
"followers_url": "https://api.github.com/users/jlatherfold/followers",
"following_url": "https://api.github.com/users/jlatherfold/following{/other_user}",
"gists_url": "https://api.github.com/users/jlatherfold/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jlatherfold",
"id": 12744068,
"login": "jlatherfold",
"node_id": "MDQ6VXNlcjEyNzQ0MDY4",
"organizations_url": "https://api.github.com/users/jlatherfold/orgs",
"received_events_url": "https://api.github.com/users/jlatherfold/received_events",
"repos_url": "https://api.github.com/users/jlatherfold/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jlatherfold/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jlatherfold/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jlatherfold",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-06-04T08:18:13Z
|
2021-09-08T23:00:57Z
|
2015-06-04T08:29:02Z
|
NONE
|
resolved
|
If preload_content is not specified on a request, connections are implicitly returned to the pool after the request is read. However, when a timeout error occurs or the connection is dropped the connection is closed but not returned in to the pool (since the response is None). This problem is compounded when retries are turned on since the next attempt will grab a new connection from the pool thus depleting it further. With non-blocking pools this is not a problem since we will create a new connection if the pool is empty but when the pool is blocking we have found that eventually the pool size becomes zero (after no.of connections timeout errors) which causes the calling application to hang on it's next request.
This can be fixed in connectionpool.urlopen in the exception handlers by explicitly returning the closed connection to the pool via _put_conn (if release_conn is false), since subsequent calls to _get_conn will check if the connection has been dropped and return a new one.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2629/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2629/timeline
| null |
completed
| null | null | false |
[
"This is a bug in [urllib3](https://github.com/shazow/urllib3): can you please open it there?\n",
"Thanks for the response. Yes I will do that.\n"
] |
https://api.github.com/repos/psf/requests/issues/2628
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2628/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2628/comments
|
https://api.github.com/repos/psf/requests/issues/2628/events
|
https://github.com/psf/requests/issues/2628
| 84,629,211 |
MDU6SXNzdWU4NDYyOTIxMQ==
| 2,628 |
Incomplete HTML Request
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/12733738?v=4",
"events_url": "https://api.github.com/users/Blizz8975/events{/privacy}",
"followers_url": "https://api.github.com/users/Blizz8975/followers",
"following_url": "https://api.github.com/users/Blizz8975/following{/other_user}",
"gists_url": "https://api.github.com/users/Blizz8975/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Blizz8975",
"id": 12733738,
"login": "Blizz8975",
"node_id": "MDQ6VXNlcjEyNzMzNzM4",
"organizations_url": "https://api.github.com/users/Blizz8975/orgs",
"received_events_url": "https://api.github.com/users/Blizz8975/received_events",
"repos_url": "https://api.github.com/users/Blizz8975/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Blizz8975/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Blizz8975/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Blizz8975",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 13 |
2015-06-03T15:43:36Z
|
2021-09-08T23:00:58Z
|
2015-06-03T17:29:33Z
|
NONE
|
resolved
|
Hey guys! I'm currently working on some content migration and I can't seem to pull the entire html source code using Python.
Here is the on of the pages I'm working on: http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=0b744865-ad8a-4e76-8d42-15966cd7c4e2
So by using:
html = requests.get("http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=0b744865-ad8a-4e76-8d42-15966cd7c4e2")
and the calling:
html.text
gives me
```
'<HTML><HEAD><TITLE>Holy Trinity Diocesan High School</TITLE></HEAD><BODY>Holy Trinity Diocesan High School<BR>98 Cherry Lane<BR>Hicksville, NY 11801<BR><BR>516-433-2900</BODY></HTML><!--\r\nWeb Server: W04ECNJ\r\nTotal Time: 31.2492ms\r\nCache Key: site_res_view_photoalbum_aspx_Down_en_2107878629\r\n//--> \r\n'
```
which is not the full html source code.
Any help would be very much appreciated!
Thanks!
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/12733738?v=4",
"events_url": "https://api.github.com/users/Blizz8975/events{/privacy}",
"followers_url": "https://api.github.com/users/Blizz8975/followers",
"following_url": "https://api.github.com/users/Blizz8975/following{/other_user}",
"gists_url": "https://api.github.com/users/Blizz8975/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Blizz8975",
"id": 12733738,
"login": "Blizz8975",
"node_id": "MDQ6VXNlcjEyNzMzNzM4",
"organizations_url": "https://api.github.com/users/Blizz8975/orgs",
"received_events_url": "https://api.github.com/users/Blizz8975/received_events",
"repos_url": "https://api.github.com/users/Blizz8975/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Blizz8975/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Blizz8975/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Blizz8975",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2628/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2628/timeline
| null |
completed
| null | null | false |
[
"Hmm, I can't test this because I keep getting 504s. Are you sure they sent a complete response?\n",
"I'm not exactly sure what you mean by a complete response, can you tell me how can I verify this? :)\n",
"Yeah, that's a bit tricky to verify. It would help to see the response headers if you can print them out. That way I can check whether this is prone to truncated responses, at the very least.\n",
"Does this help?\nimport urllib3\nhttp = urllib3.PoolManager()\nr = http.request('GET', 'http://example.com/')\nr.headers['server']\n==> 'ECS (mdw/1275)'\n",
"My site gives this:\nimport urllib3\nhttp = urllib3.PoolManager()\nr = http.request('GET', 'http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=78224c68-7155-4b2e-999c-cc9abf549f2b')\nr.status\n200\nr.headers['server']\n'Microsoft-IIS/6.0'\n",
"Sorry, I'd like to see _all_ the headers.\n",
"How about this? (from urllib3) \nHTTPHeaderDict({'Server': 'Microsoft-IIS/6.0', 'X-Powered-By': 'ASP.NET', 'Date': 'Wed, 03 Jun 2015 16:10:14 GMT', 'X-AspNet-Version': '4.0.30319', 'PICS-Label': '(PICS-1.1 \"http://www.rsac.org/ratingsv01.html\" l by \"[email protected]\" on \"2005.04.14T14:34-0400\" exp \"2008.04.18T12:00-0400\" r (n 0 s 0 v 0 l 0 oa 0 ob 0 oc 0 od 0 oe 0 of 0 og 0 oh 0 c 0)), (PICS-1.1 \"http://www.rsac.org/ratingsv01.html\" l by \"[email protected]\" on \"2005.04.14T14:34-0400\" exp \"2008.04.18T12:00-0400\" r (n 0 s 0 v 0 l 0 oa 0 ob 0 oc 0 od 0 oe 0 of 0 og 0 oh 0 c 0))(PICS-1.0 \"http://www.rsac.org/ratingsv01.html\" l by \"[email protected]\" on \"2005.04.14T14:34-0400\" exp \"2008.04.18T12:00-0400\" r (v 0 s 0 n 0 l 0)), (PICS-1.1 \"http://www.rsac.org/ratingsv01.html\" l by \"[email protected]\" on \"2005.04.14T14:34-0400\" exp \"2008.04.18T12:00-0400\" r (n 0 s 0 v 0 l 0 oa 0 ob 0 oc 0 od 0 oe 0 of 0 og 0 oh 0 c 0))(PICS-1.0 \"http://www.rsac.org/ratingsv01.html\" l by \"[email protected]\" on \"2005.04.14T14:34-0400\" exp \"2008.04.18T12:00-0400\" r (v 0 s 0 n 0 l 0))(PICS-1.1 \"http://www.rsac.org/ratingsv01.html\" l by \"[email protected]\" on \"2005.04.14T14:34-0400\" exp \"2008.04.18T12:00-0400\" r (l 0 s 0 v 0 o 0))', 'Cache-Control': 'private', 'Content-Type': 'text/html; charset=Windows-1252', 'Content-Length': '304', 'Set-Cookie': 'WebHostServer=W09ECNJ; path=/'})\n",
"This is the header I get from using requests: \n{'cache-control': 'private', 'x-aspnet-version': '4.0.30319', 'set-cookie': 'WebHostServer=W07ECNJ; path=/', 'date': 'Wed, 03 Jun 2015 16:16:16 GMT', 'x-powered-by': 'ASP.NET', 'content-type': 'text/html; charset=Windows-1252', 'content-encoding': 'gzip', 'content-length': '370', 'server': 'Microsoft-IIS/6.0', 'pics-label': '(PICS-1.1 \"http://www.rsac.org/ratingsv01.html\" l by \"[email protected]\" on \"2005.04.14T14:34-0400\" exp \"2008.04.18T12:00-0400\" r (n 0 s 0 v 0 l 0 oa 0 ob 0 oc 0 od 0 oe 0 of 0 og 0 oh 0 c 0)), (PICS-1.1 \"http://www.rsac.org/ratingsv01.html\" l by \"[email protected]\" on \"2005.04.14T14:34-0400\" exp \"2008.04.18T12:00-0400\" r (n 0 s 0 v 0 l 0 oa 0 ob 0 oc 0 od 0 oe 0 of 0 og 0 oh 0 c 0))(PICS-1.0 \"http://www.rsac.org/ratingsv01.html\" l by \"[email protected]\" on \"2005.04.14T14:34-0400\" exp \"2008.04.18T12:00-0400\" r (v 0 s 0 n 0 l 0)), (PICS-1.1 \"http://www.rsac.org/ratingsv01.html\" l by \"[email protected]\" on \"2005.04.14T14:34-0400\" exp \"2008.04.18T12:00-0400\" r (n 0 s 0 v 0 l 0 oa 0 ob 0 oc 0 od 0 oe 0 of 0 og 0 oh 0 c 0))(PICS-1.0 \"http://www.rsac.org/ratingsv01.html\" l by \"[email protected]\" on \"2005.04.14T14:34-0400\" exp \"2008.04.18T12:00-0400\" r (v 0 s 0 n 0 l 0))(PICS-1.1 \"http://www.rsac.org/ratingsv01.html\" l by \"[email protected]\" on \"2005.04.14T14:34-0400\" exp \"2008.04.18T12:00-0400\" r (l 0 s 0 v 0 o 0))'}\n",
"The cleaned up version:\n\n```\n{'Cache-Control': 'private',\n 'Content-Length': '304',\n 'Content-Type': 'text/html; charset=Windows-1252',\n 'Date': 'Wed, 03 Jun 2015 16:10:14 GMT',\n 'PICS-Label': '(PICS-1.1 \"http://www.rsac.org/ratingsv01.html\" l by \"[email protected]\" on \"2005.04.14T14:34-0400\" exp \"2008.04.18T12:00-0400\" r (n 0 s 0 v 0 l 0 oa 0 ob 0 oc 0 od 0 oe 0 of 0 og 0 oh 0 c 0)), (PICS-1.1 \"http://www.rsac.org/ratingsv01.html\" l by \"[email protected]\" on \"2005.04.14T14:34-0400\" exp \"2008.04.18T12:00-0400\" r (n 0 s 0 v 0 l 0 oa 0 ob 0 oc 0 od 0 oe 0 of 0 og 0 oh 0 c 0))(PICS-1.0 \"http://www.rsac.org/ratingsv01.html\" l by \"[email protected]\" on \"2005.04.14T14:34-0400\" exp \"2008.04.18T12:00-0400\" r (v 0 s 0 n 0 l 0)), (PICS-1.1 \"http://www.rsac.org/ratingsv01.html\" l by \"[email protected]\" on \"2005.04.14T14:34-0400\" exp \"2008.04.18T12:00-0400\" r (n 0 s 0 v 0 l 0 oa 0 ob 0 oc 0 od 0 oe 0 of 0 og 0 oh 0 c 0))(PICS-1.0 \"http://www.rsac.org/ratingsv01.html\" l by \"[email protected]\" on \"2005.04.14T14:34-0400\" exp \"2008.04.18T12:00-0400\" r (v 0 s 0 n 0 l 0))(PICS-1.1 \"http://www.rsac.org/ratingsv01.html\" l by \"[email protected]\" on \"2005.04.14T14:34-0400\" exp \"2008.04.18T12:00-0400\" r (l 0 s 0 v 0 o 0))',\n 'Server': 'Microsoft-IIS/6.0',\n 'Set-Cookie': 'WebHostServer=W09ECNJ; path=/',\n 'X-AspNet-Version': '4.0.30319',\n 'X-Powered-By': 'ASP.NET'}\n```\n\nSo the content-length header there is 304 bytes. That seems about right, so we haven't missed any HTML. It suggests that you're not making quite the same request your browser is. Do you know how to use your browser development tools?\n",
"I think so, the entire html should give this:\n\"<html style=\"height: 100%;\" class=\" js no-touch svg inlinesvg svgclippaths no-ie8compat\" xmlns=\"http://www.w3.org/1999/xhtml\"><head id=\"ctl00_header\"><title>\n Holy Trinity Diocesan High School - Art Show\n</title>\n <script src=\"//www.google-analytics.com/analytics.js\" async=\"\"></script><script type=\"text/javascript\">\n function applyPNGFix() {\n var pngs = $('.header, .headerBullet, .upcomingEvent, .upcomingEventInner, .icon-new, .mainContainer, .breadCrumbSeperator, .quickList img, .springFever_bs5 .box-header, .springFever_bs7 .box-header');\n pngs.each(function() { DD_belatedPNG.fixPng(this); });\n }\n </script>\n<link type=\"text/css\" rel=\"stylesheet\" href=\"http://static1.echalk.net/css.axd?t=pb&k=19593256&sid=091f2fe6-232e-11d7-a86d-0002b3b77bcf&v=1376519991&l=T\"><script language=\"javascript\" type=\"text/javascript\" src=\"http://static3.echalk.net/js/jquery/jquery.min.js\"></script>\n\n<!-- Start Custom Header -->\n\n<link rel=\"SHORTCUT ICON\" href=\"http://static3.echalk.net/images/favicon.ico\">\n\n<!-- End Custom Header -->\n\n<!-- Start Theme Custom Header -->\n\n<meta name=\"viewport\" content=\"width=device-width, initial-scale=1, maximum-scale=1\">\n<meta name=\"google-translate-customization\" content=\"c1646143b510e247-f3e4f5ef6f6f76e8-gcc2c67efa72a51e8-1a\">\n<link rel=\"stylesheet\" href=\"http://static2cdn.echalk.net/www/corporate/site/hosting/pd/common/css/normalize.css\">\n<link rel=\"stylesheet\" href=\"http://static2cdn.echalk.net/www/corporate/site/hosting/pd/common/css/foundation.mod.css\">\n<link href=\"http://fonts.googleapis.com/css?family=Lato:400,700|Merriweather:400,700\" rel=\"stylesheet\" type=\"text/css\">\n<link rel=\"stylesheet\" type=\"text/css\" href=\"http://holytrinityhs.echalk.com/pd/holytrinityhs/preview/css/main.css\">\n<link rel=\"shortcut icon\" href=\"http://holytrinityhs.echalk.com/pd/holytrinityhs/preview/img/favicon.png\">\n<link rel=\"apple-touch-icon\" href=\"http://holytrinityhs.echalk.com/pd/holytrinityhs/preview/img/apple-touch-icon.png\"><!--[if lt IE 8]>\n\n<script type=\"text/javascript\" src=\"http://static1cdn.echalk.net/www/corporate/site/hosting/pd/common/js/css3-mediaqueries.js\"></script>\n\n<![endif]-->\n\n<!--[if lt IE 9]>\n<link rel=\"stylesheet\" type=\"text/css\" href=\"http://holytrinityhs.echalk.com/pd/holytrinityhs/preview/css/ie.css\">\n<script src=\"http://www.modernizr.com/downloads/modernizr-2.0.6.js\"></script>\n<script src=\"http://html5shiv.googlecode.com/svn/trunk/html5.js\"></script>\n<script>window.html5 || document.write('<script src=\"http://static1cdn.echalk.net/www/corporate/site/hosting/pd/common/js/html5shiv.js\"><\\/script>')</script>\n<![endif]-->\n\n<!--[if gt IE 9]>\n<script type=\"text/javascript\" src=\"http://static1cdn.echalk.net/www/corporate/site/hosting/pd/common/js/vendor/custom.modernizr.js\"></script>\n<![endif]-->\n\n<script>\n var pathname = window.location.pathname;\n if(pathname.indexOf(\"intranet\") == -1 && (pathname.indexOf(\"home\") > -1 || (pathname.indexOf(\"/\") == 0 && pathname.length == 1))) {\n window.location.replace(\"http://holytrinityhs.echalk.com/pd/holytrinityhs/preview/index.html\");\n }\n</script>\n\n<!-- End Theme Custom Header -->\n\n<style type=\"text/css\">\n .ctl00_TopHeaderZone_0 { border-color:Black;border-width:1px;border-style:Solid; }\n .ctl00_logoZone_0 { border-color:Black;border-width:1px;border-style:Solid; }\n .ctl00_headerZone_0 { border-color:Black;border-width:1px;border-style:Solid; }\n .ctl00_navigationZone_0 { border-color:Black;border-width:1px;border-style:Solid; }\n .ctl00_bannerZone_0 { border-color:Black;border-width:1px;border-style:Solid; }\n .ctl00_footerZone_0 { border-color:Black;border-width:1px;border-style:Solid; }\n .ctl00_subFooterZone_0 { border-color:Black;border-width:1px;border-style:Solid; }\n .ctl00_BottomFooterZone_0 { border-color:Black;border-width:1px;border-style:Solid; }\n\n</style><link href=\"https://translate.googleapis.com/translate_static/css/translateelement.css\" charset=\"UTF-8\" rel=\"stylesheet\" type=\"text/css\"><script src=\"https://translate.googleapis.com/translate_static/js/element/main.js\" charset=\"UTF-8\" type=\"text/javascript\"></script><script src=\"https://translate.googleapis.com/translate_static/js/element/26/element_main.js\" charset=\"UTF-8\" type=\"text/javascript\"></script></head>\n<body style=\"position: relative; min-height: 100%; top: 0px;\" id=\"ctl00_body\">\n <form name=\"aspnetForm\" method=\"post\" action=\"site_res_view_photoalbum.aspx?resourceId=0b744865-ad8a-4e76-8d42-15966cd7c4e2\" onsubmit=\"javascript:return WebForm_OnSubmit();\" id=\"aspnetForm\"><span><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div></span><span><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div><div style=\"position: absolute; z-index: -999; left: 0px; top: 0px;\"></div></span>\n\n<div>\n<input name=\"__WPPS\" id=\"__WPPS\" value=\"s\" type=\"hidden\">\n<input name=\"__EVENTTARGET\" id=\"__EVENTTARGET\" value=\"\" type=\"hidden\">\n<input name=\"__EVENTARGUMENT\" id=\"__EVENTARGUMENT\" value=\"\" type=\"hidden\">\n<input name=\"__VIEWSTATE\" id=\"__VIEWSTATE\" value=\"/wEPDwULLTIxNDIwNjg2NTRkGAEFCGN0bDAwJHNtDxQrAAJkZGTnM9zlBwEQW6bv8Fmoodad+PQbaQ==\" type=\"hidden\">\n</div>\n\n<script type=\"text/javascript\">\n//<![CDATA[\nvar theForm = document.forms['aspnetForm'];\nfunction __doPostBack(eventTarget, eventArgument) {\n if (!theForm.onsubmit || (theForm.onsubmit() != false)) {\n theForm.__EVENTTARGET.value = eventTarget;\n theForm.__EVENTARGUMENT.value = eventArgument;\n theForm.submit();\n }\n}\n//]]>\n</script>\n\n<script src=\"http://static2.echalk.net/WebResource.axd?d=Z5n3L3eoqgu1bMH8n0VBMEJdBl_8nKRMtzw8X395wE1NmqCk2qteIUBiPkU_heXs2mazSqFuKrGVdfU9Rtw7dG2hQKA1&t=635219704397744380\" type=\"text/javascript\"></script>\n\n<script type=\"text/javascript\">\n//<![CDATA[\nsetTimeout('void(0);', 1);//]]>\n</script>\n\n<script type=\"text/javascript\">\n//<![CDATA[\nwindow.ComponentArt_Atlas=1;window.ComponentArt_Fw35=1;\n//]]>\n</script>\n\n<script type=\"text/javascript\">\n//<![CDATA[\nvar bIE = false;\nvar bMac = false;\nvar bNetscape = true;\nvar bNetscape6 = true;\nvar bNetscape6up = true;\nvar bNetscape46 = false;\nvar bFireFox = true;\nvar bSafari = false;\nvar iBrowMinorVer = '0';\nvar iBrowMajorVer = '39';\nvar sPlatform = 'winnt';\nvar sVersion = '39.0';\nvar sBrowName = 'firefox';\nvar sBrowserId = 'firefox3';\n//<!--UserAgent:Mozilla/5.0 (Windows NT 6.3; WOW64; rv:39.0) Gecko/20100101 Firefox/39.0-->;\n//]]>\n</script>\n\n<script src=\"http://static2.echalk.net/ScriptResource.axd?ec=172054585A716F70AEAF9C97BEBF95&t=7461ef9d8fe9d52\" type=\"text/javascript\"></script>\n\n<script type=\"text/javascript\">\n//<![CDATA[\nfunction WebForm_OnSubmit() {\nComponentArt_FormSubmitHandler(null, true);\nreturn true;\n}\n//]]>\n</script>\n\n```\n<script type=\"text/javascript\">\n```\n\n//<![CDATA[\nSys.WebForms.PageRequestManager._initialize('ctl00$sm', 'aspnetForm', [], ['ctl00$mainContent$dlPhotoAlbum$flashviewer','','ctl00$lm',''], [], 90, 'ctl00');\n//]]>\n</script>\n\n```\n<span id=\"ctl00_vm\"><div id=\"ctl00_vm_ctl00_ValidationPrompt\" class=\"promptStyle ui-draggable\" style=\"display: none; width: 300px; position: relative;\">\n<div style=\"cursor: move;\" id=\"ctl00_vm_ctl00_ValidationPrompt_Handle\" class=\"titleStyle\">\n <span id=\"ctl00_vm_ctl00_ValidationPrompt_Title\">Validation Warning</span>\n</div><div class=\"bodyStyle\" id=\"ctl00_vm_ctl00_ValidationPrompt_Body\">\n <span id=\"ctl00_vm_ctl00_ValidationPrompt_Message\"></span>\n</div><div class=\"footerStyle\">\n <input id=\"ctl00_vm_ctl00_ValidationPrompt_ok\" value=\"Ok\" type=\"button\">\n</div>\n```\n\n</div></span>\n\n```\n <div>\n <div id=\"header\">\n```\n\n<div id=\"alerts\" class=\"collapsed\"></div>\n\n<header class=\"header\">\n <div id=\"header-top\">\n <div class=\"wrap\">\n <div id=\"logo\"><a href=\"http://holytrinityhs.echalk.com\" class=\"ir\">Holy Trinity Diocesan High School - Home</a></div>\n <ul class=\"quick-links\">\n <li><a href=\"http://holytrinityhs.echalk.com\"><span class=\"icon-home\"></span>Home</a></li>\n <li><a href=\"http://www.drvcschools.org\"><span class=\"icon-users\"></span>Diocese</a></li>\n <li><a href=\"http://24.190.163.242/NetClassroom7/Forms/login.aspx?ReturnUrl=%2fnetclassroom7%2fDefault.aspx\"><span class=\"icon-key\"></span>Portal</a></li>\n <li><a href=\"http://holytrinityhs.echalk.com/help\"><span class=\"icon-help\"></span>help</a></li>\n <li><a href=\"http://holytrinityhs.echalk.com/search\"><span class=\"icon-search\"></span>Search</a></li>\n </ul>\n </div>\n </div>\n <div id=\"nav\">\n <div class=\"wrap\">\n <nav class=\"top-bar\">\n <ul class=\"title-area\">\n <li class=\"name\">\n <h1><a href=\"#\"> </a></h1>\n </li>\n <li class=\"toggle-topbar menu-icon\"><a href=\"#\"><span>Menu</span></a></li>\n </ul>\n\n```\n <section class=\"top-bar-section\">\n <ul class=\"left\"><li id=\"ae32f19a-2ff8-4739-aa93-ecb760dbb72b\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=ae32f19a-2ff8-4739-aa93-ecb760dbb72b\">About Us</a><ul id=\"catae32f19a-2ff8-4739-aa93-ecb760dbb72b\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=ae32f19a-2ff8-4739-aa93-ecb760dbb72b\">About Us</a></label></li><li id=\"bfbf0d03-73f6-4e99-b9c1-3f4d3df03d15\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=bfbf0d03-73f6-4e99-b9c1-3f4d3df03d15\">Mission and Philosophy</a></li><li id=\"c5a58717-2966-430e-a320-855281b69f82\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=c5a58717-2966-430e-a320-855281b69f82\">Our Leadership Team</a></li><li id=\"386fb0cd-181f-4e3d-ae29-1955962e164f\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014%20FAQ%20sheet.pdf\">Top 10 FAQ's</a></li><li id=\"9f21dd5a-1526-4fbc-b179-cd76a865f394\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=9f21dd5a-1526-4fbc-b179-cd76a865f394\">Graduate Profile</a></li><li id=\"e3306212-bd47-4077-a43e-b269a4cf071e\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=e3306212-bd47-4077-a43e-b269a4cf071e\">Our Viewbook</a></li><li id=\"c4d747f9-e6ef-482c-8165-32254aeabd51\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=c4d747f9-e6ef-482c-8165-32254aeabd51\">Holy Trinity Video - Trinity Will Be The Best Years of Your Life</a></li><li id=\"1860eade-7960-4d8e-b842-1b55b2fb47f1\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=1860eade-7960-4d8e-b842-1b55b2fb47f1\">Holy Trinity - A Student's Perspective</a></li><li id=\"8fc04232-736e-4609-8092-1dbd1e150bc7\"><a href=\"http://rtvpix.com/bu-7290-ns1z22-01\" target=\"_blank\">Holy Trinity Virtual Tour</a></li><li id=\"b1700cee-96e4-4a5f-9155-879766e06ec4\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=b1700cee-96e4-4a5f-9155-879766e06ec4\">Student Handbook</a><ul id=\"catb1700cee-96e4-4a5f-9155-879766e06ec4\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=b1700cee-96e4-4a5f-9155-879766e06ec4\">Student Handbook</a></label></li><li id=\"e5b99612-eb3d-462f-aaa5-04a52b661bef\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Attendance%20Policy%20(updated%208-13).pdf\">Holy Trinity Attendance Policy</a></li><li id=\"530efd88-21ab-415a-a202-9484f0214d80\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014-2015%20Student%20Handbook.pdf\">2014-15 Student Handbook</a></li></ul></li><li id=\"cb6642f2-6d65-4914-a4e9-9c2b48a624fe\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=cb6642f2-6d65-4914-a4e9-9c2b48a624fe\">Office of Recruitment & Public Relations</a><ul id=\"catcb6642f2-6d65-4914-a4e9-9c2b48a624fe\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=cb6642f2-6d65-4914-a4e9-9c2b48a624fe\">Office of Recruitment & Public Relations</a></label></li><li id=\"f5884786-83ed-4476-a8d9-697926ee7214\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=f5884786-83ed-4476-a8d9-697926ee7214\">Experience a Day at Holy Trinity - Shadow Program</a></li><li id=\"49cb08e1-5b82-47a4-8f90-b8cdaf4928c3\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=49cb08e1-5b82-47a4-8f90-b8cdaf4928c3\">Shadow Ambassador Program (Current students)</a></li><li id=\"9e02b9ba-d214-43b4-be57-cb6fca23ca31\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=9e02b9ba-d214-43b4-be57-cb6fca23ca31\">School Ambassador Program (Current students)</a></li><li id=\"52df6093-9e80-40c5-97d6-440900b44d2d\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=52df6093-9e80-40c5-97d6-440900b44d2d\">Internship Opportunities for current students</a></li></ul></li><li id=\"019fc78a-fdcc-4d6d-9801-96e782fe1567\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=54b1a189-adcc-48ec-b6ef-0a1d0d8c265d\">Press Releases</a></li><li id=\"871cf1b0-6cf1-4513-a9d9-486424451546\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014%20Triumphs.pdf\">Trinity Triumphs</a></li><li id=\"f6a41260-80fc-4acb-b1b5-433b3166380b\"><a href=\"http://holytrinityhs.echalk.com/site_view_calendars.aspx?dt=M\">Calendars</a></li><li id=\"f3ced177-44fe-47c4-9bec-c8f73b18c442\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=f3ced177-44fe-47c4-9bec-c8f73b18c442\">Middle States Accreditation</a><ul id=\"catf3ced177-44fe-47c4-9bec-c8f73b18c442\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=f3ced177-44fe-47c4-9bec-c8f73b18c442\">Middle States Accreditation</a></label></li><li id=\"17d6a5af-d53e-4971-9b21-c5b3c9c3c614\"><a href=\"http://holytrinityhs.echalk.com/download.axd?file=17d6a5af-d53e-4971-9b21-c5b3c9c3c614&dnldType=Resource\">Holy Trinity Belief Statements</a></li><li id=\"5d430ec3-d90f-4171-99ab-62afa0f777a7\"><a href=\"http://holytrinityhs.echalk.com/download.axd?file=5d430ec3-d90f-4171-99ab-62afa0f777a7&dnldType=Resource\">Middle States Accreditation Facts</a></li><li id=\"c76ab52a-c533-4ea1-b284-e1dc20fe2161\"><a href=\"http://holytrinityhs.echalk.com/download.axd?file=c76ab52a-c533-4ea1-b284-e1dc20fe2161&dnldType=Resource\">Mission Statement/Belief Statement Affirmation</a></li></ul></li><li id=\"67e0ff29-2209-4495-a847-91d2d9926722\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=67e0ff29-2209-4495-a847-91d2d9926722\">Uniform Information</a><ul id=\"cat67e0ff29-2209-4495-a847-91d2d9926722\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=67e0ff29-2209-4495-a847-91d2d9926722\">Uniform Information</a></label></li><li id=\"a1d2a233-9bf1-40f4-b193-1a00cd6a480f\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Uniform%20Information/Boys%20Uniform%20Price%20List.pdf\">2015 Boys Uniform Requirements and Pricelist</a></li><li id=\"9b227524-a10a-4665-b6f1-686b3758a249\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Uniform%20Information/Girls%20Uniform%20Price%20List.pdf\">2015 Girls Uniform Requirements and Pricelist</a></li><li id=\"c40e10ea-ac8f-4df9-ac08-e322c9ad4954\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Uniform%20Information/Wnite%20Cross%20Shoes%20Price%20List%20and%20Measurement%20Form.pdf\">2015 White Cross Shoes Pricelist and Order Form</a></li><li id=\"1a807b74-8282-4301-9f6e-a40a3f6a4338\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Uniform%20Information/2015%20Uniform%20Measurement%20Form.pdf\">Upperclassmen (Gr. 10, 11, 12) 2015 Uniform Order Form</a></li></ul></li><li id=\"1e4044ae-aaed-44c9-9ce8-18c72948bfda\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=1e4044ae-aaed-44c9-9ce8-18c72948bfda\">Health and Medical Forms</a></li><li id=\"3e564729-8178-4dd3-b0a0-0697a7c302c4\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=3e564729-8178-4dd3-b0a0-0697a7c302c4\">School Directory</a><ul id=\"cat3e564729-8178-4dd3-b0a0-0697a7c302c4\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=3e564729-8178-4dd3-b0a0-0697a7c302c4\">School Directory</a></label></li><li id=\"e80df9ed-1789-4b34-9098-1d27b2b2d20b\"><a href=\"http://holytrinityhs.echalk.com/site_user_directory.aspx?type=DA\">Administration</a></li><li id=\"edbef76f-6987-4054-ae83-1207dc63a52e\"><a href=\"http://holytrinityhs.echalk.com/site_user_directory.aspx?type=DT\">Teachers</a></li><li id=\"9bdf3140-5080-478a-b75e-c3e4917ac1aa\"><a href=\"http://holytrinityhs.echalk.com/site_user_directory.aspx?type=DM\">Staff</a></li><li id=\"9f28c29a-d1cf-4c99-86b6-50fdd69f0467\"><a href=\"http://holytrinityhs.echalk.com/site_listing.aspx\">Diocese of Rockville Centre Education Department</a></li><li id=\"01a793cf-64c5-4b5e-b288-eb875727deaf\"><a href=\"http://holytrinityhs.echalk.com/site_user_directory.aspx?type=DF\">Show All</a></li></ul></li><li id=\"c00b4e46-013f-44e1-bddd-b682fcc045b1\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=cf6de365-16bc-476f-82d2-bdca52dc594f\">Titan Parents Club</a></li><li id=\"c1d8667a-d771-42c0-9b6e-94e4063d21f0\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=c1d8667a-d771-42c0-9b6e-94e4063d21f0\">Directions to Holy Trinity</a></li></ul></li><li id=\"d4c0b909-035d-4acb-a53c-530aaa44b2e8\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=d4c0b909-035d-4acb-a53c-530aaa44b2e8\">Admissions</a><ul id=\"catd4c0b909-035d-4acb-a53c-530aaa44b2e8\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=d4c0b909-035d-4acb-a53c-530aaa44b2e8\">Admissions</a></label></li><li id=\"d3b3e544-6591-41cd-a06c-ec2a74c57091\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=d3b3e544-6591-41cd-a06c-ec2a74c57091\">Admissions Policy</a></li><li id=\"bb486875-ddfe-4743-809a-7a5614fa14e4\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Special%20Acceptance%20Consideration%20for%20Holy%20Trinity%20Families.pdf\">Special Acceptance Consideration for Holy Trinity Families</a></li><li id=\"bdd2b85f-fd17-426b-b434-45b2fe7f5f43\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=bdd2b85f-fd17-426b-b434-45b2fe7f5f43\">Important Dates for 2014 - 2015</a></li><li id=\"d562e746-f1f8-44f8-aa53-65deb86fccc2\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=d562e746-f1f8-44f8-aa53-65deb86fccc2\">Scholarships and Financial Aid</a></li><li id=\"35b9af55-c9c2-4b42-8ca7-3364c09b54d1\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=35b9af55-c9c2-4b42-8ca7-3364c09b54d1\">Transportation & Textbooks</a></li><li id=\"0761fcb4-51a2-434a-bee5-d97384bc7faf\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=0761fcb4-51a2-434a-bee5-d97384bc7faf\">Chinese Applicants</a><ul id=\"cat0761fcb4-51a2-434a-bee5-d97384bc7faf\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=0761fcb4-51a2-434a-bee5-d97384bc7faf\">Chinese Applicants</a></label></li><li id=\"297a0fd2-e026-42e7-b673-511c31934acd\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/China%20Contact%20Information%202014.pdf\">Contact Information</a></li><li id=\"2caadac8-94f9-43e0-a9ed-25f262ca71c6\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/ChineseBrochure.pdf\">General Information</a></li><li id=\"63612bbd-1e85-4014-8b40-001901dcb5fc\"><a href=\"https://accelerate-educere.brainhoney.com/Welcome.vp/page.htm\" target=\"_blank\">Accelerate ESL Course</a></li><li id=\"427143a2-5cc1-4914-bdd4-3b2b40ee29af\"><a href=\"https://totale.rosettastone.com/sign_in\" target=\"_blank\">Rosetta Stone - Online</a></li></ul></li><li id=\"2b1315c4-6bea-4e69-8169-b0c0d494f055\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014%20FAQ%20sheet.pdf\">Top 10 FAQ's</a></li><li id=\"fbb2ca16-ba7f-4adb-9578-24988bb45c28\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014%20Triumphs.pdf\">Trinity Triumphs</a></li><li id=\"b7f531e0-98c3-4700-9afe-13af8d4b8616\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=ffb55195-ef22-411f-93fb-5832cdd34d1c\">Experience a Day at Holy Trinity - Shadow Program</a></li></ul></li><li id=\"3e43921d-0d50-42ba-bc24-d2e82c38cf6a\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=3e43921d-0d50-42ba-bc24-d2e82c38cf6a\">Academics</a><ul id=\"cat3e43921d-0d50-42ba-bc24-d2e82c38cf6a\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=3e43921d-0d50-42ba-bc24-d2e82c38cf6a\">Academics</a></label></li><li id=\"bf9a2eaa-c2aa-494f-af12-3cac86a27b4e\"><a href=\"http://24.190.163.242/netclassroom7\" target=\"_blank\">Parent Information System</a></li><li id=\"2050b6cd-fe81-44e1-956b-0c67846906f2\"><a href=\"http://24.190.163.242/netclassroom7\" target=\"_blank\">Student Information System</a></li><li id=\"a3d44877-8c35-4203-b034-aca0f3fa4ced\"><a href=\"http://holytrinityhs.echalk.com/site_classes.aspx\">Class Pages</a></li><li id=\"c30c5ca3-eaa5-4f49-b21c-4c10fb379dc1\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Intro%20to%20Advancement%20Placement%20Program.pdf\">Advanced Placement Program</a></li><li id=\"ffcde31c-fe74-4036-ac10-2c4033f971ab\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2015-2016.pdf\">2015-2016 Course Bulletin</a></li><li id=\"6e49f4de-28af-4f10-99b0-33c1c9dd78ff\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=6e49f4de-28af-4f10-99b0-33c1c9dd78ff\">Library Media Center</a><ul id=\"cat6e49f4de-28af-4f10-99b0-33c1c9dd78ff\" class=\"dropdown right\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=6e49f4de-28af-4f10-99b0-33c1c9dd78ff\">Library Media Center</a></label></li><li id=\"963b668d-17ca-4d10-b21d-aa9c587dc226\"><a href=\"http://holytrinity.mlasolutions.com/oasis/catalog/?installation=Default\" target=\"_blank\">Holy Trinity Library Catalog (OPAC)</a></li><li id=\"d51054cf-c4b9-4621-bd05-c108fe7f1939\"><a href=\"https://drive.google.com/a/holytrinityhs.echalk.com/file/d/0B0Qo-exorcD6THRGYzBhclhxS1E/view?usp=sharing\" target=\"_blank\">Online Research Resources & PASSWORDS!</a></li><li id=\"5f3ffa32-b802-46b1-af22-359284d8a9fe\"><a href=\"http://galepages.com/nysl_li_holytr/\" target=\"_blank\">NOW EASIER TO USE - Online Research - Gale Databases & eBooks</a></li><li id=\"7e6c7aee-1843-42f0-af8b-f721c7af1a19\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=7e6c7aee-1843-42f0-af8b-f721c7af1a19\">Online Research - Research Articles, Newspapers, Video & More!</a></li><li id=\"66375dd7-f88c-48e6-a5ba-e3397154991a\"><a href=\"http://holytrinityhs.echalk.com/download.axd?file=66375dd7-f88c-48e6-a5ba-e3397154991a&dnldType=Resource\">AP U.S. History Resources<span class=\"image-newindicator\"></span></a></li><li id=\"5d1e6edc-98cb-4c72-a62e-5403559007de\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=5d1e6edc-98cb-4c72-a62e-5403559007de\">Works Cited/Bibliography Help</a><ul id=\"cat5d1e6edc-98cb-4c72-a62e-5403559007de\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=5d1e6edc-98cb-4c72-a62e-5403559007de\">Works Cited/Bibliography Help</a></label></li></ul></li><li id=\"8e7f4c6c-58b3-4f29-b6f1-74407dfeb56b\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=8e7f4c6c-58b3-4f29-b6f1-74407dfeb56b\">FREE IMAGES for PROJECTS</a><ul id=\"cat8e7f4c6c-58b3-4f29-b6f1-74407dfeb56b\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=8e7f4c6c-58b3-4f29-b6f1-74407dfeb56b\">FREE IMAGES for PROJECTS</a></label></li></ul></li><li id=\"694e3996-8be9-4d01-9bb8-48db9c4259b4\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=694e3996-8be9-4d01-9bb8-48db9c4259b4\">History & Social Studies Resources</a><ul id=\"cat694e3996-8be9-4d01-9bb8-48db9c4259b4\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=694e3996-8be9-4d01-9bb8-48db9c4259b4\">History & Social Studies Resources</a></label></li></ul></li><li id=\"eed41c35-d114-41f7-8d92-a5ca7283aa68\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=eed41c35-d114-41f7-8d92-a5ca7283aa68\">Religion and Philosophy Resources</a><ul id=\"cateed41c35-d114-41f7-8d92-a5ca7283aa68\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=eed41c35-d114-41f7-8d92-a5ca7283aa68\">Religion and Philosophy Resources</a></label></li></ul></li><li id=\"8c518513-faa4-4300-81dd-89995257b705\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=8c518513-faa4-4300-81dd-89995257b705\">Science Resources</a><ul id=\"cat8c518513-faa4-4300-81dd-89995257b705\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=8c518513-faa4-4300-81dd-89995257b705\">Science Resources</a></label></li></ul></li><li id=\"845246ef-29e6-4ad7-aaed-b0f9884b38b4\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=845246ef-29e6-4ad7-aaed-b0f9884b38b4\">English Language Arts Resources</a><ul id=\"cat845246ef-29e6-4ad7-aaed-b0f9884b38b4\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=845246ef-29e6-4ad7-aaed-b0f9884b38b4\">English Language Arts Resources</a></label></li></ul></li><li id=\"270f3379-722c-4c76-9800-44d700beb881\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=270f3379-722c-4c76-9800-44d700beb881\">Sports Research Resources</a><ul id=\"cat270f3379-722c-4c76-9800-44d700beb881\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=270f3379-722c-4c76-9800-44d700beb881\">Sports Research Resources</a></label></li></ul></li><li id=\"5f06108a-42f7-427c-828f-cc2c3572b065\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=5f06108a-42f7-427c-828f-cc2c3572b065\">Class-Specific Research Guides</a><ul id=\"cat5f06108a-42f7-427c-828f-cc2c3572b065\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=5f06108a-42f7-427c-828f-cc2c3572b065\">Class-Specific Research Guides</a></label></li></ul></li><li id=\"94865fb2-0352-4617-8e03-8f6943e8c496\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=94865fb2-0352-4617-8e03-8f6943e8c496\">Teacher Resources</a><ul id=\"cat94865fb2-0352-4617-8e03-8f6943e8c496\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=94865fb2-0352-4617-8e03-8f6943e8c496\">Teacher Resources</a></label></li></ul></li><li id=\"ee5d2262-ef5f-4a15-8298-1d754a4eb926\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=ee5d2262-ef5f-4a15-8298-1d754a4eb926\">Digital Citizenship</a><ul id=\"catee5d2262-ef5f-4a15-8298-1d754a4eb926\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=ee5d2262-ef5f-4a15-8298-1d754a4eb926\">Digital Citizenship</a></label></li></ul></li><li id=\"cdd73211-013b-469f-8131-e61f8578999a\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=cdd73211-013b-469f-8131-e61f8578999a\">Library Computer Help Desk</a><ul id=\"catcdd73211-013b-469f-8131-e61f8578999a\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=cdd73211-013b-469f-8131-e61f8578999a\">Library Computer Help Desk</a></label></li></ul></li><li id=\"f526649e-2633-4ae2-8482-5bd540c3f8e8\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=f526649e-2633-4ae2-8482-5bd540c3f8e8\">Our Mission</a></li><li id=\"340ab936-a765-4bcf-adfb-dd097d0b2cf7\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=340ab936-a765-4bcf-adfb-dd097d0b2cf7\">AP Info</a><ul id=\"cat340ab936-a765-4bcf-adfb-dd097d0b2cf7\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=340ab936-a765-4bcf-adfb-dd097d0b2cf7\">AP Info</a></label></li></ul></li><li id=\"742e6cd0-3e0b-4e8a-b68c-5f296ec8e34c\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=742e6cd0-3e0b-4e8a-b68c-5f296ec8e34c\">Free Downloadable E-Books</a><ul id=\"cat742e6cd0-3e0b-4e8a-b68c-5f296ec8e34c\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=742e6cd0-3e0b-4e8a-b68c-5f296ec8e34c\">Free Downloadable E-Books</a></label></li></ul></li><li id=\"bd05e0c5-809e-410a-b2c0-63747e6d1512\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=bd05e0c5-809e-410a-b2c0-63747e6d1512\">Flashcard Makers</a><ul id=\"catbd05e0c5-809e-410a-b2c0-63747e6d1512\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=bd05e0c5-809e-410a-b2c0-63747e6d1512\">Flashcard Makers</a></label></li></ul></li><li id=\"cbf61a62-5bf5-4b78-9d42-ec64f9c08ee6\"><a href=\"http://www.how-to-study.com\" target=\"_blank\">Study Skills, Study Strategies, & Study Tips</a></li><li id=\"a7f2ecef-4cc7-488a-a62e-53749f148763\"><a href=\"http://citationmachine.net/index2.php?reqstyleid=1&newstyle=1&stylebox=1\" target=\"_blank\">Son of Citation Machine</a></li><li id=\"512842e6-15f4-4767-9d31-57b177789d11\"><a href=\"http://holytrinityhs.echalk.com/download.axd?file=512842e6-15f4-4767-9d31-57b177789d11&dnldType=Resource\">Latest MLA Style Manual</a></li><li id=\"29f12df9-96e9-4be5-90e7-1f8717b3449e\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=29f12df9-96e9-4be5-90e7-1f8717b3449e\">Online Resources - Research Articles, Newspapers, Video & More!</a></li><li id=\"723d193b-9cad-432f-a5ca-8e384c820e1f\"><a href=\"http://holytrinityhs.echalk.com/blogs\">Blogs</a></li><li id=\"994ea57e-5c95-4858-a1f9-96e35df2a68d\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=994ea57e-5c95-4858-a1f9-96e35df2a68d\">ESL Links</a><ul id=\"cat994ea57e-5c95-4858-a1f9-96e35df2a68d\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=994ea57e-5c95-4858-a1f9-96e35df2a68d\">ESL Links</a></label></li></ul></li><li id=\"8eb13f76-178f-4ebd-a8df-c61e39ab732d\"><a href=\"http://www.studyblue.com/\" target=\"_blank\">Flashcards - Create Online Flashcards</a></li><li id=\"bd3fffb1-12c5-4e0f-aae0-7c7509fbd2cd\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=bd3fffb1-12c5-4e0f-aae0-7c7509fbd2cd\">Forgot your Scientific Calculator?!?</a></li><li id=\"e8809f03-3e8e-4709-aeaf-a21a62a9ffd3\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=e8809f03-3e8e-4709-aeaf-a21a62a9ffd3\">SAT -College Board</a></li></ul></li><li id=\"aca25559-4ed4-43b4-a87d-0f43165dd85b\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=aca25559-4ed4-43b4-a87d-0f43165dd85b\">Guidance Department</a><ul id=\"cataca25559-4ed4-43b4-a87d-0f43165dd85b\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=aca25559-4ed4-43b4-a87d-0f43165dd85b\">Guidance Department</a></label></li><li id=\"afc81b1a-62be-4803-b33e-0627ed4e3f3e\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=390fb32d-22b5-4f93-8783-3fe0a465f3a0\">Freshmen</a></li><li id=\"a26ac07a-4e49-4010-a566-5223f1a81262\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=a3a90b0a-4136-49b1-9869-69e476ce0f37\">Sophomores</a></li><li id=\"7ff9e1a2-9e50-4e5c-96f8-38b4b07a950f\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=4c6c7ece-707d-41ed-b9dc-1be5480bd8b8\">Juniors</a></li><li id=\"525a5fe9-210f-4c0a-b653-442bd21ce642\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=5fe5d11b-2bd2-4069-988e-2145851c87ba\">Seniors</a></li><li id=\"9a924e31-be4c-4b3d-a53e-d052abc8df20\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=9e2e7590-f17f-45f9-96fe-fb62fcb324fe\">Graduates</a></li></ul></li><li id=\"0d76a0a0-562a-4935-8569-64bf6030b0cb\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=0d76a0a0-562a-4935-8569-64bf6030b0cb\">Honor Roll</a><ul id=\"cat0d76a0a0-562a-4935-8569-64bf6030b0cb\" class=\"dropdown right\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=0d76a0a0-562a-4935-8569-64bf6030b0cb\">Honor Roll</a></label></li><li id=\"6a74bb2a-9c63-4793-8fa2-dce007e8a0a7\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Second%20Quarter%2014-15%20Honor%20Roll.pdf\">2014-15 Second Quarter Honor Roll</a></li><li id=\"a30da400-3104-4abe-99a1-d4aad38c556c\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014-15%20Honor%20Roll/First%20Quarter%2014-15%20Honor%20Roll.pdf\">2014-15 First Quarter Honor Roll</a></li><li id=\"592f0c63-b7b7-43ca-8b46-8299a56f3316\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=592f0c63-b7b7-43ca-8b46-8299a56f3316\">2013-2014</a><ul id=\"cat592f0c63-b7b7-43ca-8b46-8299a56f3316\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=592f0c63-b7b7-43ca-8b46-8299a56f3316\">2013-2014</a></label></li></ul></li></ul></li><li id=\"5255832e-ab52-41f4-88dc-1128d0f6ce74\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=5255832e-ab52-41f4-88dc-1128d0f6ce74\">The Masters Program</a></li><li id=\"50e795e2-93c3-4266-a2a0-58443e1aa247\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014%20Graduation%20Program.pdf\">Class of 2014 Graduation Program/Senior Awards and Scholarships</a></li><li id=\"6b10d448-b4be-457b-b935-bfcae86ef1d4\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=6b10d448-b4be-457b-b935-bfcae86ef1d4\">AP Course Information</a><ul id=\"cat6b10d448-b4be-457b-b935-bfcae86ef1d4\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=6b10d448-b4be-457b-b935-bfcae86ef1d4\">AP Course Information</a></label></li><li id=\"cf855716-816b-435d-8c63-7808688b0520\"><a href=\"http://www.collegeboard.com/student/testing/ap/sub_bio.html?biology\" target=\"_blank\">AP Biology Information</a></li><li id=\"d22cc8a3-2df4-4331-8676-3ba863087142\"><a href=\"http://www.collegeboard.com/student/testing/ap/sub_englit.html?englit\" target=\"_blank\">AP English Literature Information</a></li><li id=\"54daf25f-46e7-4ea6-a3b7-d47fc2830b40\"><a href=\"http://www.collegeboard.com/student/testing/ap/sub_usgov.html?usgovpol\" target=\"_blank\">AP U. S. Government & Politics Information</a></li><li id=\"a84d95a9-0e83-4dfd-8f42-30c047de94cf\"><a href=\"http://www.collegeboard.com/student/testing/ap/sub_ushist.html?ushist\" target=\"_blank\">AP U. S. History Information</a></li></ul></li><li id=\"604b4d3a-2ac3-4454-a282-2190a03090d8\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=604b4d3a-2ac3-4454-a282-2190a03090d8\">PSAT/SAT Information</a><ul id=\"cat604b4d3a-2ac3-4454-a282-2190a03090d8\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=604b4d3a-2ac3-4454-a282-2190a03090d8\">PSAT/SAT Information</a></label></li><li id=\"ffd30105-bcf9-424a-95de-3202e215755e\"><a href=\"http://holytrinityhs.echalk.com/download.axd?file=ffd30105-bcf9-424a-95de-3202e215755e&dnldType=Resource\">New York Times SAT Prep</a></li><li id=\"c29e8b22-03ff-495f-a94d-dbd1fb4225cf\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=c29e8b22-03ff-495f-a94d-dbd1fb4225cf\">SAT Practice</a></li><li id=\"f12f733f-69c7-49e6-b9f3-e6d2f42b5129\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=f12f733f-69c7-49e6-b9f3-e6d2f42b5129\">SAT Question of the Day</a></li></ul></li><li id=\"859191e1-bce1-4240-a8f0-898f7f9d6913\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=859191e1-bce1-4240-a8f0-898f7f9d6913\">Honor Societies</a></li><li id=\"b28e23c0-9e1a-4c00-8a1a-be9cd338f3b9\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=b28e23c0-9e1a-4c00-8a1a-be9cd338f3b9\">Science & Technology Fair Information</a><ul id=\"catb28e23c0-9e1a-4c00-8a1a-be9cd338f3b9\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=b28e23c0-9e1a-4c00-8a1a-be9cd338f3b9\">Science & Technology Fair Information</a></label></li><li id=\"b1056bf6-5381-4017-84ef-d561eee1e3d0\"><a href=\"http://holytrinityhs.echalk.com/download.axd?file=b1056bf6-5381-4017-84ef-d561eee1e3d0&dnldType=Resource\">Guidelines and Tips</a></li><li id=\"f03eb0a8-6c16-42d9-b8a4-829480f4bfd0\"><a href=\"http://holytrinityhs.echalk.com/download.axd?file=f03eb0a8-6c16-42d9-b8a4-829480f4bfd0&dnldType=Resource\">Judging Rubric</a></li><li id=\"0a7b2f26-5943-4f08-8c8f-26ab27b5172d\"><a href=\"http://holytrinityhs.echalk.com/download.axd?file=0a7b2f26-5943-4f08-8c8f-26ab27b5172d&dnldType=Resource\">Science & Technology Fair Announcement</a></li><li id=\"5e68a03c-bbfe-4478-bc9f-26a8ae8ca1b6\"><a href=\"http://holytrinityhs.echalk.com/download.axd?file=5e68a03c-bbfe-4478-bc9f-26a8ae8ca1b6&dnldType=Resource\">Web Resources for Projects</a></li></ul></li><li id=\"50883ba2-f4c7-4666-8e45-9377e4a9df8f\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=50883ba2-f4c7-4666-8e45-9377e4a9df8f\">For Parents</a><ul id=\"cat50883ba2-f4c7-4666-8e45-9377e4a9df8f\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=50883ba2-f4c7-4666-8e45-9377e4a9df8f\">For Parents</a></label></li><li id=\"25117860-86e4-4e41-b4a6-3ef01aed0451\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=cf6de365-16bc-476f-82d2-bdca52dc594f\">Titan Parents Club</a></li><li id=\"1c145070-aeae-494a-b2be-0f45121b595e\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=1e4044ae-aaed-44c9-9ce8-18c72948bfda\">Health and Medical Forms</a></li><li id=\"ec203ab3-03f1-47a9-a2dd-8705c4c0029e\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=0feec5ac-8ac8-44da-b41c-a27067d70d22\">School Reach Messages</a></li></ul></li></ul></li><li id=\"b6e43065-53ae-4154-a4df-dbd4be0f314e\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=b6e43065-53ae-4154-a4df-dbd4be0f314e\">Athletics</a><ul id=\"catb6e43065-53ae-4154-a4df-dbd4be0f314e\" class=\"dropdown left\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=b6e43065-53ae-4154-a4df-dbd4be0f314e\">Athletics</a></label></li><li id=\"dcc83511-0178-4835-ae00-68f1778f2356\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=dcc83511-0178-4835-ae00-68f1778f2356\">Titan Athletic Team Information</a></li><li id=\"b527ee15-9be4-44ec-9e4c-000e1ee03c04\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Titan%20Summer%202014TRYOUT.pdf\">Tryout Information for 2014-2015 School Year</a></li><li id=\"8d431915-a863-45a0-99dc-c841d7dfb8df\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=1e4044ae-aaed-44c9-9ce8-18c72948bfda\" target=\"_blank\">Health and Medical Forms</a></li><li id=\"b29a7798-9d45-43b4-ab6f-61184e79fbe5\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=b29a7798-9d45-43b4-ab6f-61184e79fbe5\">Titan Athletics in the News</a><ul id=\"catb29a7798-9d45-43b4-ab6f-61184e79fbe5\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=b29a7798-9d45-43b4-ab6f-61184e79fbe5\">Titan Athletics in the News</a></label></li><li id=\"90f62f0b-e44b-421c-aff6-985c86059b3c\"><a href=\"http://www.newsday.com/sports/high-school/golf/holy-trinity-s-chris-lambrou-wins-chsaa-golf-title-1.8108411\" target=\"_blank\">Senior Christopher Lambrou wins CHSAA Individual Golf Championship</a></li><li id=\"97f8a086-6698-4ed5-a44d-6f7dd97b9b87\"><a href=\"http://nesn.com/2014/05/patriots-sign-maine-wide-receiver-derrick-johnson-as-undrafted-free-agent/\" target=\"_blank\">Derrick Johnson '09 Signs with the New England Patriots</a></li><li id=\"0c93c34b-c60c-44cf-bacc-d34c4ff743b4\"><a href=\"http://www.nj.com/rutgersfootball/index.ssf/2014/04/rutgers_spring_practice_mike_bimonte_and_chris_laviano_making_their_case_for_starting_qb_job.html\" target=\"_blank\">Alumni Chris Laviano '13 at Rutgers</a></li><li id=\"2bdb56bf-8d68-445c-a730-ee9952755b0c\"><a href=\"http://swimswam.com/university-southern-californias-jack-wagner-fears/\" target=\"_blank\">Alumni Jack Wagner '10 Swimming for USC</a></li><li id=\"3ca0f59d-73db-469e-8cd7-2b531b05c34d\"><a href=\"http://ny.milesplit.com/articles/123914-perseverance-on-long-island-the-story-of-victoria-st-john%23.U1cPMleoVrw\" target=\"_blank\">Mile Split New York - The Story of Victoria St. John</a></li><li id=\"cd76f086-5ab8-430f-894f-e0cef6719ba2\"><a href=\"http://www.newsday.com/sports/high-school/boys-basketball/titans-made-a-mark-for-holy-trinity-1.7611272\" target=\"_blank\">Newsday - Boys Varsity Basketball Team Made a Mark for Holy Trinity</a></li><li id=\"07f3308b-ff86-4966-aba3-1248b8dd119b\"><a href=\"http://www.newsday.com/sports/high-school/golf/holy-trinity-s-chris-lambrou-looks-forward-to-big-season-1.7768329\" target=\"_blank\">Newsday - Holy Trinity Golfer Chris Lambrou</a></li><li id=\"da2f7e48-358d-4519-800d-2d408d42d142\"><a href=\"http://www.newsday.com/sports/high-school/boys-lacrosse/holy-trinity-lacrosse-coach-steve-denapoli-is-a-stickler-and-the-players-love-it-1.7768596\" target=\"_blank\">Newsday - Lacrosse Coach Steve DeNapoli</a></li><li id=\"21c60665-e077-4a94-8a5d-39795650c102\"><a href=\"http://www.newsday.com/sports/high-school/track/kristina-insingo-qualifies-in-weight-throw-for-holy-trinity-for-millrose-games-1.6828344?utm_source=twitterfeed&utm_medium=twitter\" target=\"_blank\">Newsday - Trinity Athletes Qualify for Millrose Games</a></li></ul></li><li id=\"15a80036-2520-484d-9812-24478166486a\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=15a80036-2520-484d-9812-24478166486a\">Team Pages</a><ul id=\"cat15a80036-2520-484d-9812-24478166486a\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=15a80036-2520-484d-9812-24478166486a\">Team Pages</a></label></li><li id=\"c8ae66c9-2839-457e-b426-0f4b364073c6\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=8b5d2c9a-b323-410b-a43c-c0fe95b6572e\">Baseball</a></li><li id=\"16541cba-dbb1-4dee-a15a-27b98e3d371a\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=42914227-942b-4454-bf08-2d0dd2593fc2\">Boys and Girls Cross Country</a></li><li id=\"d1458990-9527-494e-a09b-5a6ed5ccd240\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=9b81d156-236e-457e-936c-e813828a4aa7\">Boys Basketball</a></li><li id=\"ec32fc9f-6c7b-4c0d-b901-78b3492fca57\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=c72ded59-db7e-4796-abde-6dc2b3adb002\">Boys Bowling</a></li><li id=\"71b3e8c8-60aa-4d4e-89ff-759d051ce7b9\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=7b8b1130-aee0-4174-a991-b4b79e225ab5\">Boys Golf</a></li><li id=\"66342bc2-0252-4f82-9124-dca673e4c301\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=ed5c9bd4-de6a-4528-802b-fbb7b67551c7\">Boys Lacrosse</a></li><li id=\"6f0f8d0f-3d89-4eea-a3a5-2c4823e3c693\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=488558b8-fc03-46a0-b3f1-fba2b3a4c9aa\">Boys Soccer</a></li><li id=\"5ab43d0c-f478-4dd3-bac3-a877e438a533\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=17d906d6-a6a5-42e1-88be-c926fe62f552\">Boys Spring Track</a></li><li id=\"cfbc380c-c8b8-44ea-af2a-7af6ca05c715\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=d2fc2e1d-1f80-439c-b430-c0b0663d5f92\">Boys Swimming</a></li><li id=\"4c0f9d7f-4f2b-4045-b5e8-1ba9d37f22b4\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=b55cf365-ab0e-4bdd-8954-d5ddcbd8988e\">Boys Volleyball</a></li><li id=\"a7595546-f682-4621-8268-d172b66e26bb\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=b35c1a82-f688-45c0-9ce4-f460dc63bdc3\">Boys Winter Track</a></li><li id=\"ca0e9b1c-01de-4e90-a2ab-5e039906fe85\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=532ac490-6624-4c9d-b552-9c2465ed96f6\">Cheerleading</a></li><li id=\"a5eea0b2-4971-4048-b3b0-f637c814cdde\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=6e63f109-924d-4d0c-bd07-483c401922f9\">Football</a></li><li id=\"55f72cc3-d310-4cf1-a963-d31e5ebd9a6a\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=02cf95f8-dc83-4670-9131-abafe2071245\">Girls Badminton</a></li><li id=\"8b8e79c3-d6fa-468a-b4f2-7d4766cc874c\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=c66aa7ea-4455-4d8a-b501-a0b731189d35\">Girls Basketball</a></li><li id=\"8de3febe-fd8d-494a-a6ea-6220f0955287\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=0a4b6aa5-7e41-4fc3-a846-c90e11caac9e\">Girls Bowling</a></li><li id=\"31149360-6c3f-4749-9a84-cce44d3cffec\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=48154cd6-ace3-4c00-a55d-5281baa94b5a\">Girls Golf</a></li><li id=\"2a781083-2929-4e59-b5cf-d5b9205d6c3e\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=88a29d1f-5510-4cd7-b08f-a4354d227db8\">Girls Gymnastics</a></li><li id=\"8681a510-dd11-4118-b0b1-85c83c12ad1a\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=411c89da-17bc-43ba-a3ed-bc72de36128c\">Girls Lacrosse</a></li><li id=\"92941eec-f2cd-4e9f-a358-47c0b561b8bb\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=ca80a511-9665-4566-9d7e-313731a15712\">Girls Soccer</a></li><li id=\"ff71c314-3ae2-44d7-bfd1-87624dd4305d\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=88206b63-5bf4-472b-8426-525fcf528820\">Girls Softball</a></li><li id=\"2ca1433f-f765-434c-b325-682921502654\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=8c527a1c-205d-4ea9-ad66-765f78021525\">Girls Spring Track</a></li><li id=\"5bda9700-b432-4def-8e8f-17f8b2d21866\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=9042b2f0-79f8-4bfa-8028-e46ba563c7e3\">Girls Swimming</a></li><li id=\"bae3908f-03f8-4406-87c1-fc12b4f37f4d\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=57cbb122-d5d7-4808-9686-b869305ef55f\">Girls Tennis</a></li><li id=\"c06ff323-8417-4754-ade7-48455653a377\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=f9e3de2b-3091-417f-9a17-9185a7ce73fb\">Girls Volleyball</a></li><li id=\"31830a5f-bb2f-4076-81c7-0ab2c6b9cf81\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=480d2e49-6bb3-43ba-8172-5fe5e99cdf57\">Girls Winter Track</a></li><li id=\"3bc927b7-b629-4ee3-bc17-643d5ba00ee8\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=4a3b7f93-897f-4f79-9cac-b9347882005e\">Kickline</a></li><li id=\"df6147f4-f472-4a7c-93ce-ee36ec01966d\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=1bcd2627-ca46-4e75-bbb4-96c68d6c9513\">Wrestling</a></li></ul></li><li id=\"6f2e702b-c8ab-40e0-9da9-436e311407ab\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2015%20Holy%20Trinity%20Summer%20Camp%20Brochure.pdf\">2015 Summer Sport Camps - Mail-in Registration</a></li><li id=\"b9aefa51-79e1-4d6d-ba44-05c22d3e433c\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=b9aefa51-79e1-4d6d-ba44-05c22d3e433c\">Follow Titan Athletics on our league pages</a></li><li id=\"b125afb8-655a-4504-b6c2-c3ab8544b3dd\"><a href=\"http://www.msgvarsity.com/long-island/holy-trinity\" target=\"_blank\">Catch up on all the Titan Sports Scores and more on MSGVarsity.com</a></li><li id=\"690779b4-30ca-4bd1-b031-f8e4443b3f29\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=690779b4-30ca-4bd1-b031-f8e4443b3f29\">Titan Athletics 2012-2013</a><ul id=\"cat690779b4-30ca-4bd1-b031-f8e4443b3f29\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=690779b4-30ca-4bd1-b031-f8e4443b3f29\">Titan Athletics 2012-2013</a></label></li><li id=\"e810a75c-c713-4497-8b9e-2d431613aa1d\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=e810a75c-c713-4497-8b9e-2d431613aa1d\">2012-2013 Winter Sports Awards</a></li><li id=\"c6cd4b70-88bd-4406-ae66-f9283e84bcc0\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=c6cd4b70-88bd-4406-ae66-f9283e84bcc0\">2012 Fall Sports Slideshow</a></li><li id=\"93c52adf-a58e-4268-bd93-cef72860e6da\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=93c52adf-a58e-4268-bd93-cef72860e6da\">2012 Fall Sports Awards and Communion Breakfast Photos</a></li></ul></li><li id=\"4dc61164-027f-410e-adc1-4a18e1e4b028\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/FIELD_SCHOOL_DIRECTONS.pdf\">Directions to other schools and fields<span class=\"image-newindicator\"></span></a></li><li id=\"3e32003a-77ac-4b40-9bd6-242e8fa4cf29\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=cf6de365-16bc-476f-82d2-bdca52dc594f\">Titan Parents Club</a></li></ul></li><li id=\"eb382525-a0a7-4bf9-b3d5-f8e4bfb12cb6\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=eb382525-a0a7-4bf9-b3d5-f8e4bfb12cb6\">Arts</a><ul id=\"cateb382525-a0a7-4bf9-b3d5-f8e4bfb12cb6\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=eb382525-a0a7-4bf9-b3d5-f8e4bfb12cb6\">Arts</a></label></li><li id=\"63558ef3-dc1c-4cd1-8738-ebbf8b46f1a4\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=63558ef3-dc1c-4cd1-8738-ebbf8b46f1a4\">Performing Arts Department</a><ul id=\"cat63558ef3-dc1c-4cd1-8738-ebbf8b46f1a4\" class=\"dropdown right\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=63558ef3-dc1c-4cd1-8738-ebbf8b46f1a4\">Performing Arts Department</a></label></li><li id=\"518c37f6-67a0-4ebe-bc38-2cbf8ac71691\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/HT_PA_Handbook_-_Final_Draft%20PDF-2.pdf\">Performing Arts Student Handbook<span class=\"image-newindicator\"></span></a></li><li id=\"d402ae7c-0b17-4e06-bb77-45d1486a82ee\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=10d65daf-a91c-4bee-a7ba-23e0d7c8e871\">Trinity Dance Company</a></li><li id=\"ea07efd0-8604-46c6-abee-45cb5af7b3e3\"><a href=\"http://holytrinityhs.echalk.com/class_profile_view.aspx?id=70c6ad0f-1715-4486-ad27-3f235f052531\">Select Choir</a></li><li id=\"bcb1d629-87a7-4d12-900e-3130263a80f2\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=43779334-eef2-436c-bf56-d956ab6979a4\">2015 Spring Musical</a></li><li id=\"3b462563-637e-4409-9242-427d718d8277\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/SummerTheatreInside2015.pdf\">Summer Performing Arts Camp Registration Form</a></li><li id=\"9f9e75d2-4136-4111-a47c-566f6afae9a3\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=cf6de365-16bc-476f-82d2-bdca52dc594f\">Titan Parents Club</a></li><li id=\"05b619a6-9153-491a-b226-a825d58092d1\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=05b619a6-9153-491a-b226-a825d58092d1\">2013-2014 Season</a><ul id=\"cat05b619a6-9153-491a-b226-a825d58092d1\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=05b619a6-9153-491a-b226-a825d58092d1\">2013-2014 Season</a></label></li></ul></li><li id=\"2319c28e-d57e-41ad-878b-bc87f587620b\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=2319c28e-d57e-41ad-878b-bc87f587620b\">2012-2013 Season</a><ul id=\"cat2319c28e-d57e-41ad-878b-bc87f587620b\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=2319c28e-d57e-41ad-878b-bc87f587620b\">2012-2013 Season</a></label></li></ul></li><li id=\"eaa0e028-a390-4c65-8d6c-ff6d8dd869ee\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=eaa0e028-a390-4c65-8d6c-ff6d8dd869ee\">2011-2012 Season</a><ul id=\"cateaa0e028-a390-4c65-8d6c-ff6d8dd869ee\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=eaa0e028-a390-4c65-8d6c-ff6d8dd869ee\">2011-2012 Season</a></label></li></ul></li><li id=\"e8efd608-c9ee-4c62-8ede-90fad4d39b8c\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=e8efd608-c9ee-4c62-8ede-90fad4d39b8c\">2010-2011 Season</a><ul id=\"cate8efd608-c9ee-4c62-8ede-90fad4d39b8c\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=e8efd608-c9ee-4c62-8ede-90fad4d39b8c\">2010-2011 Season</a></label></li></ul></li><li id=\"8c0de69a-124f-4f69-af81-7d9de9bbfe31\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=8c0de69a-124f-4f69-af81-7d9de9bbfe31\">2009-2010 Season</a><ul id=\"cat8c0de69a-124f-4f69-af81-7d9de9bbfe31\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=8c0de69a-124f-4f69-af81-7d9de9bbfe31\">2009-2010 Season</a></label></li></ul></li></ul></li><li id=\"4e0f1bfb-0fd3-4ca5-9ac1-494b46acf3d1\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=4e0f1bfb-0fd3-4ca5-9ac1-494b46acf3d1\">Fine Arts Department</a><ul id=\"cat4e0f1bfb-0fd3-4ca5-9ac1-494b46acf3d1\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=4e0f1bfb-0fd3-4ca5-9ac1-494b46acf3d1\">Fine Arts Department</a></label></li><li id=\"e34e76d4-7929-44f7-818b-7d8ba18e2ec9\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=e34e76d4-7929-44f7-818b-7d8ba18e2ec9\">Student Work Project of the Month</a><ul id=\"cate34e76d4-7929-44f7-818b-7d8ba18e2ec9\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=e34e76d4-7929-44f7-818b-7d8ba18e2ec9\">Student Work Project of the Month</a></label></li></ul></li><li id=\"71641b2b-9d4c-4f8b-9c30-8148359f72eb\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=84ad0ea3-10e1-4733-87e2-a909edfe2a6a\">National Art Honor Society</a></li><li id=\"786622b5-6a2d-4f95-9f3b-b0614afb2c24\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=d5b77a17-f341-493e-979b-c4bdf840a77b\" target=\"_blank\">2013 Art Show</a></li><li id=\"3d076e1f-34da-44d3-96cc-29797a231b51\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=3d076e1f-34da-44d3-96cc-29797a231b51\">2012 Art Show</a></li><li id=\"c510511d-42af-4a0e-9be2-b6f5f745077e\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=e3f0ca4c-6221-44c2-9e18-a20673180e55\" target=\"_blank\">2014 Art Show</a></li></ul></li></ul></li><li id=\"95c983b4-7767-487d-a0e0-11225a619254\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=95c983b4-7767-487d-a0e0-11225a619254\">Faith Life</a><ul id=\"cat95c983b4-7767-487d-a0e0-11225a619254\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=95c983b4-7767-487d-a0e0-11225a619254\">Faith Life</a></label></li><li id=\"95514d80-0dde-4fb0-8792-03892a92d5c6\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=95514d80-0dde-4fb0-8792-03892a92d5c6\">Welcome to Campus Ministry</a></li><li id=\"a1b64662-0727-4b98-8e27-ccd95e3ace89\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=a1b64662-0727-4b98-8e27-ccd95e3ace89\">Pray</a></li><li id=\"f8810da1-e5d1-4a00-b6dc-6a58694c73a0\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=f8810da1-e5d1-4a00-b6dc-6a58694c73a0\">Serve</a></li><li id=\"96b3f71c-bd4b-4f81-969e-6649e421a7d3\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=96b3f71c-bd4b-4f81-969e-6649e421a7d3\">Believe</a></li><li id=\"3ab39737-599f-4166-8b4f-1734cb71f59b\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=3ab39737-599f-4166-8b4f-1734cb71f59b\">Our Students reflect on their Faith</a><ul id=\"cat3ab39737-599f-4166-8b4f-1734cb71f59b\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=3ab39737-599f-4166-8b4f-1734cb71f59b\">Our Students reflect on their Faith</a></label></li><li id=\"e3851e8e-3eb2-449a-a385-2220aa8080c2\"><a href=\"http://www.youtube.com/watch?v=f4SZwIoxXxQ&list=UUbAwh_PysJSt--1YCRyq4Hg\" target=\"_blank\">Religious Freedom</a></li><li id=\"6727723a-ff1f-484b-aa20-760c2b107dea\"><a href=\"http://www.youtube.com/watch?v=pgYG5HKc_M8&list=UUbAwh_PysJSt--1YCRyq4Hg\" target=\"_blank\">The Ten Commandments</a></li><li id=\"7255b01c-20e9-4a8b-b03f-415a1330c600\"><a href=\"https://www.youtube.com/watch?v=lirD22NoaqY\" target=\"_blank\">Theology of the Body</a></li></ul></li><li id=\"578dc192-8c36-4dcd-8951-edd6f6e1a833\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=578dc192-8c36-4dcd-8951-edd6f6e1a833\">News & Events</a><ul id=\"cat578dc192-8c36-4dcd-8951-edd6f6e1a833\" class=\"dropdown right\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=578dc192-8c36-4dcd-8951-edd6f6e1a833\">News & Events</a></label></li><li id=\"87a689ac-160c-49be-a773-1bdbb5788025\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=87a689ac-160c-49be-a773-1bdbb5788025\">Virtue of the Month Winners</a><ul id=\"cat87a689ac-160c-49be-a773-1bdbb5788025\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=87a689ac-160c-49be-a773-1bdbb5788025\">Virtue of the Month Winners</a></label></li></ul></li><li id=\"1ed9e7f9-5efa-45f8-aebe-3b1990c4d830\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=1ed9e7f9-5efa-45f8-aebe-3b1990c4d830\">2013-14 Event Photos</a><ul id=\"cat1ed9e7f9-5efa-45f8-aebe-3b1990c4d830\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=1ed9e7f9-5efa-45f8-aebe-3b1990c4d830\">2013-14 Event Photos</a></label></li></ul></li><li id=\"6230225a-2602-4e47-b1e0-a04b47f5ade8\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=6230225a-2602-4e47-b1e0-a04b47f5ade8\">2012-2013 Photos</a><ul id=\"cat6230225a-2602-4e47-b1e0-a04b47f5ade8\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=6230225a-2602-4e47-b1e0-a04b47f5ade8\">2012-2013 Photos</a></label></li></ul></li><li id=\"1d97d1ae-d8f4-48a9-8ee6-6d03195454c9\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=1d97d1ae-d8f4-48a9-8ee6-6d03195454c9\">2011-12 Event Photos</a><ul id=\"cat1d97d1ae-d8f4-48a9-8ee6-6d03195454c9\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=1d97d1ae-d8f4-48a9-8ee6-6d03195454c9\">2011-12 Event Photos</a></label></li></ul></li><li id=\"7d5f9154-584a-4528-86ca-346a4449e761\"><a href=\"http://www.msgvarsity.com/long-island/holy-trinity-hs-feature-1.386690\" target=\"_blank\">MSG Varsity Feature - LIGHTs and Power Writing</a></li><li id=\"d3c36c91-416b-481f-93aa-af3c6678002d\"><a href=\"http://www.msgvarsity.com/long-island/hs-experience-holy-trinity-hs-1.180827\" target=\"_blank\">MSGVarsity High School of the Week - Community Service</a></li></ul></li><li id=\"0163761f-a053-4331-afd3-68be6189f1dd\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=0163761f-a053-4331-afd3-68be6189f1dd\">Prayer Requests</a></li><li id=\"39d0de19-49a9-46ba-9e2a-8ea2fa9f9902\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=e4bfbcae-0205-4f85-85e9-3f6a3ef58b7a\">Lectors & Eucharistic Ministers</a></li><li id=\"8ffe0242-12b9-4b85-91f2-ad1821d24b79\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=a55e08db-64d0-4d2c-a023-9c41401f63c4\">Music Ministry</a></li><li id=\"513ae54b-da1d-4f82-b123-968f0330fd9b\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/MinistryofConsolationForm.pdf\">Ministry of Consolation</a></li></ul></li><li id=\"bc9f9958-b1d8-4df8-856d-c6853c0df365\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=bc9f9958-b1d8-4df8-856d-c6853c0df365\">Student Life</a><ul id=\"catbc9f9958-b1d8-4df8-856d-c6853c0df365\" class=\"dropdown right\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=bc9f9958-b1d8-4df8-856d-c6853c0df365\">Student Life</a></label></li><li id=\"7eeec091-7efd-42d2-8383-d7319e9c7c77\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=7eeec091-7efd-42d2-8383-d7319e9c7c77\">Extracurricular Activities Information</a></li><li id=\"0144fbca-1af5-442c-b926-896178da2ecf\"><a href=\"http://holytrinityhs.echalk.com/group_listing.aspx?id=7a1ff4bb-6358-4120-bec0-5c106cf89255\">Club Pages</a></li><li id=\"a65a8309-c882-4cab-bcc3-73a77e26ea26\"><a href=\"http://holytrinityhs.echalk.com/site_groups.aspx\" target=\"_blank\">Group pages</a></li><li id=\"e2939760-da67-4108-ac9c-24a524442057\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=e2939760-da67-4108-ac9c-24a524442057\">Class of 2015 Yearbook</a><ul id=\"cate2939760-da67-4108-ac9c-24a524442057\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=e2939760-da67-4108-ac9c-24a524442057\">Class of 2015 Yearbook</a></label></li><li id=\"cb227c9a-5f7e-4cdb-88e2-1552fe94f8ec\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014-15%20Yearbook%20Ad%20Letter.pdf\">Yearbook Ad</a></li><li id=\"47bc361d-c26e-420c-b22f-a90d92b41d73\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Yearbook%20order%20letter-November%202014%20-%20v2.pdf\">Yearbook Order form</a></li></ul></li><li id=\"5c214002-ea2a-4a1d-8838-bdcc7c580ab7\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=5c214002-ea2a-4a1d-8838-bdcc7c580ab7\">Trinity Triangle</a><ul id=\"cat5c214002-ea2a-4a1d-8838-bdcc7c580ab7\" class=\"dropdown left\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=5c214002-ea2a-4a1d-8838-bdcc7c580ab7\">Trinity Triangle</a></label></li><li id=\"dd916f88-891f-4be6-8922-241b811d2350\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Trinity%20Triangle%20May%20June%202015.pdf\">June 2015<span class=\"image-newindicator\"></span></a></li><li id=\"6a802aaa-fe40-4454-aaec-59f511d2f06f\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Trinity%20Triangle%20March%20April%202015.pdf\">April 2015</a></li><li id=\"5cd80f0b-db3c-41e6-b70c-95253122e3eb\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Trinity%20Triangle%20February%202015.pdf\">February 2015</a></li><li id=\"da178af3-51b2-4eb4-8ee4-a6bc19c3cb8f\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Trinity%20Triangle%20December%202014.pdf\">December 2014</a></li><li id=\"3ffbf37d-8355-423b-b5f6-1b7ee4df7352\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Trinity%20Triangle%20October%202014%20v2.pdf\">October 2014</a></li><li id=\"65a03d12-8d22-410c-99af-a234575360a8\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=65a03d12-8d22-410c-99af-a234575360a8\">2013-14 Publications</a><ul id=\"cat65a03d12-8d22-410c-99af-a234575360a8\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=65a03d12-8d22-410c-99af-a234575360a8\">2013-14 Publications</a></label></li></ul></li><li id=\"9585c817-54a5-4404-8fe4-f6ce6bc6deb8\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=9585c817-54a5-4404-8fe4-f6ce6bc6deb8\">2012-2013 Publications</a><ul id=\"cat9585c817-54a5-4404-8fe4-f6ce6bc6deb8\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=9585c817-54a5-4404-8fe4-f6ce6bc6deb8\">2012-2013 Publications</a></label></li></ul></li></ul></li><li id=\"37ab4e34-1fe1-49df-80d9-5fb6f9493e01\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/May%202015%20Prism.pdf\">2015 Prism - Holy Trinity Student Literary/Media Magazine</a></li><li id=\"4d904b42-630d-4218-a6ef-c0e07a7aa610\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=e0d6db52-45ae-403f-bc42-ba7afeae0370\">Driver Education</a></li><li id=\"e25e87ed-376a-4b1a-9e6a-0f13cca605c0\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014-2015%20Student%20Handbook.pdf\">Student Handbook</a></li><li id=\"b3d091f9-7e83-4f4c-be63-58078952227c\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=c8d9679b-0148-4ee8-81d7-ed99f547f00f\">International Trips</a></li><li id=\"c056e987-f2c4-496e-ac97-799ac5b201c3\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=c056e987-f2c4-496e-ac97-799ac5b201c3\">Holy Trinity Bookstore</a></li><li id=\"7ebba792-ef1d-4c0e-8112-e15e88343df2\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Titan_Cafe_Menu.pdf\">Titan Cafe Menu</a></li><li id=\"1ef572ea-8afd-408d-8241-44d371423d57\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=1ef572ea-8afd-408d-8241-44d371423d57\">Summer Camps 2015</a><ul id=\"cat1ef572ea-8afd-408d-8241-44d371423d57\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=1ef572ea-8afd-408d-8241-44d371423d57\">Summer Camps 2015</a></label></li><li id=\"dff5dd13-d630-498b-a6be-fdec13ff72e1\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2015%20Holy%20Trinity%20Summer%20Camp%20Brochure.pdf\">Summer Sport Camps - Mail-in Registration</a></li><li id=\"a215da6e-9baa-43f2-9d11-37945a81f493\"><a href=\"http://abcsportscamps.com/hths\" target=\"_blank\">Summer Sports Camps - Online Registration</a></li><li id=\"5639ee04-bf4d-4e49-b2cc-cef9fcb97cc6\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Summer%20Art%20Camp2015a.pdf\">Summer Art Camp Information and Registration Form</a></li><li id=\"ca07d9ec-6693-4097-be69-4e1014e9dfba\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/SummerTheatreInside2015.pdf\">Summer Performing Arts Camp Information and Registration Form</a></li></ul></li><li id=\"bcdb5273-10c0-45a1-9591-3667a1d14086\"><a href=\"http://holytrinityhs.echalk.com/group_profile_view.aspx?id=cf6de365-16bc-476f-82d2-bdca52dc594f\">Titan Parents Club</a></li><li id=\"320e79bb-95c8-4814-8d5b-03304f15d3de\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=0d0422bd-3e13-4db1-8261-a3470cf0f3b8\" target=\"_blank\">Discounts for the Holy Trinity Family</a></li></ul></li><li id=\"b8a37ed6-6833-4c0b-af64-0408f2b9d7ce\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=b8a37ed6-6833-4c0b-af64-0408f2b9d7ce\">News</a><ul id=\"catb8a37ed6-6833-4c0b-af64-0408f2b9d7ce\" class=\"dropdown right\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=b8a37ed6-6833-4c0b-af64-0408f2b9d7ce\">News</a></label></li><li id=\"d0c98794-3e99-48a8-ac9b-66383ebfa28b\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=d0c98794-3e99-48a8-ac9b-66383ebfa28b\">News From the Principal</a><ul id=\"catd0c98794-3e99-48a8-ac9b-66383ebfa28b\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=d0c98794-3e99-48a8-ac9b-66383ebfa28b\">News From the Principal</a></label></li><li id=\"3e350fe8-2671-49e2-abdf-8762c290b7a3\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=3e350fe8-2671-49e2-abdf-8762c290b7a3\">Class of 2015 - Yearbook Letter<span class=\"image-newindicator\"></span></a></li><li id=\"78bf08fe-f89d-4533-8cd6-944f28f29c8c\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=78bf08fe-f89d-4533-8cd6-944f28f29c8c\">March 2015</a></li><li id=\"7d514941-49c0-41e6-96fe-94978506849a\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=7d514941-49c0-41e6-96fe-94978506849a\">January 2015</a></li><li id=\"ad314bc4-d7e0-4a58-9477-b4c114c0e482\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=ad314bc4-d7e0-4a58-9477-b4c114c0e482\">December 2014</a></li><li id=\"c351ba8f-cfaa-433a-976a-fee1448ca81e\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=c351ba8f-cfaa-433a-976a-fee1448ca81e\">November 2014</a></li><li id=\"e8ea9918-c397-4469-8316-b74c538517e5\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=e8ea9918-c397-4469-8316-b74c538517e5\">September 2014</a></li><li id=\"0df9ab55-e819-48a4-be0a-5407ddfb04ce\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=0df9ab55-e819-48a4-be0a-5407ddfb04ce\">October 2014</a></li><li id=\"58c304a0-1f84-4f5b-8256-d8a1a1ac4723\"><a href=\"http://holytrinityhs.echalk.com/download.axd?file=58c304a0-1f84-4f5b-8256-d8a1a1ac4723&dnldType=Resource\">Closed Campus</a></li></ul></li><li id=\"c4ff588c-62be-44e4-a13b-2a544a2be2bf\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=c4ff588c-62be-44e4-a13b-2a544a2be2bf\">News from the Deans</a></li><li id=\"ee107204-883d-43ff-b2de-c90d4cf1004c\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=ee107204-883d-43ff-b2de-c90d4cf1004c\">Email Registration</a></li><li id=\"a3ea6aa7-3d54-47eb-80f3-10218090ac54\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=a3ea6aa7-3d54-47eb-80f3-10218090ac54\">Daily Announcements</a><ul id=\"cata3ea6aa7-3d54-47eb-80f3-10218090ac54\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=a3ea6aa7-3d54-47eb-80f3-10218090ac54\">Daily Announcements</a></label></li><li id=\"21ca2bd0-112c-4271-ad7d-ad92054abe96\"><a href=\"http://holytrinityhs.echalk.com/download.axd?file=21ca2bd0-112c-4271-ad7d-ad92054abe96&dnldType=Resource\">Daily Announcements 5/27/15<span class=\"image-newindicator\"></span></a></li><li id=\"f4c9a246-7816-45b2-8871-9fb19f7bac78\"><a href=\"http://holytrinityhs.echalk.com/download.axd?file=f4c9a246-7816-45b2-8871-9fb19f7bac78&dnldType=Resource\">Daily Announcements 5/28/15<span class=\"image-newindicator\"></span></a></li><li id=\"19501b8e-0906-454a-86f0-63122d212bad\"><a href=\"http://holytrinityhs.echalk.com/download.axd?file=19501b8e-0906-454a-86f0-63122d212bad&dnldType=Resource\">Daily Announcements 5/29/15<span class=\"image-newindicator\"></span></a></li><li id=\"375ce1f0-2e79-4c4e-b0f0-a58446c81f47\"><a href=\"http://holytrinityhs.echalk.com/download.axd?file=375ce1f0-2e79-4c4e-b0f0-a58446c81f47&dnldType=Resource\">Daily Announcements 6/1/15<span class=\"image-newindicator\"></span></a></li><li id=\"164161b0-51f0-4b4e-96fc-38f5dfacf509\"><a href=\"http://holytrinityhs.echalk.com/download.axd?file=164161b0-51f0-4b4e-96fc-38f5dfacf509&dnldType=Resource\">Daily Announcements 6/3/15<span class=\"image-newindicator\"></span></a></li></ul></li><li id=\"5bc27ee2-453d-4b52-959f-8d2d12c6ac84\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=5bc27ee2-453d-4b52-959f-8d2d12c6ac84\">Freshman Letters</a><ul id=\"cat5bc27ee2-453d-4b52-959f-8d2d12c6ac84\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=5bc27ee2-453d-4b52-959f-8d2d12c6ac84\">Freshman Letters</a></label></li><li id=\"2a659b80-a649-44d8-944a-30751608cbc6\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Uniform%20Information/Uniform%20Measurement%20Letter.pdf\">2015 Uniform Letter (March 2015)</a></li><li id=\"becd7e79-af0b-4c45-bc09-2d712f13766c\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Freshman%20July%20Summer%20Letters/Dress%20Code%20Letter%20from%20the%20Principal.pdf\">Dress Code letter from the Principal (July)</a></li><li id=\"cec04e2a-2ed8-4acc-90c4-a0e3b7884300\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Freshman%20August%20Summer%20Letters/Freshmen%20-%20First%20Days%20of%20School.pdf\">First Days of School (August)</a></li><li id=\"152b189b-8dac-4921-abf0-95fc68616443\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Freshman%20August%20Summer%20Letters/Freshman%20and%20Parent%20Events.pdf\">Freshman and Parent Events</a></li><li id=\"ad0b1869-0aae-49b3-83af-e5bf0e15775d\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Freshman%20July%20Summer%20Letters/Freshman%20Summer%20Reading%20Letter.pdf\">Freshman Summer Reading Letter (July)</a></li><li id=\"d406fd0b-a757-4f09-b8d1-d12c472505f4\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Freshman%20August%20Summer%20Letters/Important%20Information%20from%20the%20Deans%20office%202014%20Freshman.pdf\">Important Information from the Dean's Office (August)</a></li><li id=\"d0052c35-598d-440d-81be-f6773a9e4e22\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Freshman%20August%20Summer%20Letters/Parent%20Student%20Handbook%20Calendar%20Declaration.pdf\">Parent Student Handbook Calendar Declaration (August)</a></li><li id=\"d9fe3d75-5cd4-4412-a97e-52e636bd89e0\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Freshman%20July%20Summer%20Letters/Personal%20Appearance%20-%20Dress%20Code.pdf\">Personal Appearance - Dress Code (July)</a></li><li id=\"955814ab-b025-4d12-9b8f-e461d1c96e54\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Freshman%20July%20Summer%20Letters/Religion%20Service%20Letter.pdf\">Religion Service Letter (July)</a></li><li id=\"5ed90c09-3024-4625-b297-97d4fd0fc372\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Freshman%20July%20Summer%20Letters/Titan%20Parent%20Club%20Sponsor%20Brochure.pdf\">Titan Parent Club Sponsor Brochure (July)</a></li><li id=\"b1fbb520-8c35-415f-a727-c6827a1c8dd7\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Freshman%20July%20Summer%20Letters/Titan%20Parents%20Club%20Letter.pdf\">Titan Parents Club Letter (July)</a></li></ul></li><li id=\"58dc8e55-7d27-4d68-81cb-6c83419e6651\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=58dc8e55-7d27-4d68-81cb-6c83419e6651\">Sophomore Letters</a><ul id=\"cat58dc8e55-7d27-4d68-81cb-6c83419e6651\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=58dc8e55-7d27-4d68-81cb-6c83419e6651\">Sophomore Letters</a></label></li><li id=\"00515761-d8c7-4c84-9f9f-cbee12a0aac8\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Uniform%20Information/Uniform%20Measurement%20Letter.pdf\">2015 Uniform Letter (March 2015)</a></li><li id=\"a6d4ca8f-93af-4c01-ae4b-b9e1ce35f0c7\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Sophomore%20August%20Summer%20Letters/10th%20Grade%20Guidance%20Office%20Testing%20Information.pdf\">10th Grade Guidance Office Testing Information (August)</a></li><li id=\"b72ea73d-1a14-4f9b-abc8-19d40fcac25c\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Sophomore%20July%20Summer%20Letters/Dress%20Code%20Letter%20from%20the%20Principal.pdf\">Dress Code Letter from the Principal (July)</a></li><li id=\"342725e2-ff54-4b22-9c36-b506cfce56dd\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Sophomore%20August%20Summer%20Letters/10th,%2011th,%2012th%20grades%20-%20First%20Days%20of%20School.pdf\">First Days of School (August)</a></li><li id=\"96cb8a4a-0bf4-483b-9183-fb5e5529cbca\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Sophomore%20August%20Summer%20Letters/10th,%2011th,%2012th%20Important%20Information%20from%20the%20Principal%20and%20Dean.pdf\">Important Information from the Principal and Dean (August)</a></li><li id=\"6d1a53f3-46e8-4ce0-8972-87df0bec858a\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Sophomore%20August%20Summer%20Letters/Parent%20Student%20Handbook%20Calendar%20Declaration.pdf\">Parent Student Handbook Calendar Declaration (August)</a></li><li id=\"67a173b4-cdbd-4609-abe7-f1b0271a5a5c\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Sophomore%20July%20Summer%20Letters/Personal%20Appearance%20-%20Dress%20Code.pdf\">Personal Appearance - Dress Code (July)</a></li><li id=\"dfe9e7b4-7f06-41b8-a493-389fa1f6a9d0\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Sophomore%20July%20Summer%20Letters/Religion%20Service%20Letter.pdf\">Religion Service Letter (July)</a></li><li id=\"ad1dafe3-57c8-4526-85ce-bd6b090aa939\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Sophomore%20July%20Summer%20Letters/Sophomore%20Summer%20Reading%20Letter.pdf\">Sophomore Summer Reading Letter (July)</a></li><li id=\"b0a17bdd-a570-4cf9-b373-990c81d86235\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Sophomore%20July%20Summer%20Letters/Titan%20Parent%20Club%20Sponsor%20Brochure.pdf\">Titan Parent Club Sponsor Brochure (July)</a></li><li id=\"b5662577-4b88-41e9-b30d-8ee20918afdb\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Sophomore%20July%20Summer%20Letters/Titan%20Parents%20Club%20Letter.pdf\">Titan Parents Club Letter (July)</a></li></ul></li><li id=\"9c3cd3ee-efdf-4e19-b1df-e151a1fd7667\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=9c3cd3ee-efdf-4e19-b1df-e151a1fd7667\">Junior Letters</a><ul id=\"cat9c3cd3ee-efdf-4e19-b1df-e151a1fd7667\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=9c3cd3ee-efdf-4e19-b1df-e151a1fd7667\">Junior Letters</a></label></li><li id=\"d3d25118-70f3-41cf-afdd-1c51378aee30\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Uniform%20Information/Uniform%20Measurement%20Letter.pdf\">2015 Uniform Letter (March 2015)</a></li><li id=\"b57e8404-260e-4a38-a66d-3757d19aa4a4\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Junior%20August%20Summer%20Letters/11th%20Grade%20Guidance%20Office%20Testing%20Information.pdf\">11th Grade Guidance Office Testing Information (August)</a></li><li id=\"40f125d8-04e1-414f-8903-92a273c5c643\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Junior%20July%20Summer%20Letters/Dress%20Code%20Letter%20from%20the%20Principal.pdf\">Dress Code letter from the Principal (July)</a></li><li id=\"3aff1e3d-f1a0-4afd-ad30-7b477fe8f913\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Junior%20August%20Summer%20Letters/10th,%2011th,%2012th%20grades%20-%20First%20Days%20of%20School.pdf\">First Days of School (August)</a></li><li id=\"bc829803-d1ea-4ab3-a12c-63774ca381c6\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Junior%20August%20Summer%20Letters/10th,%2011th,%2012th%20Important%20Information%20from%20the%20Principal%20and%20Dean.pdf\">Important Information from the Principal and Dean (August)</a></li><li id=\"71625ad4-55e6-4849-b95e-0eb7622cf985\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Junior%20July%20Summer%20Letters/Junior%20Summer%20Reading%20Letter.pdf\">Junior Summer Reading Letter (July)</a></li><li id=\"9c0bef4a-89d1-4cc9-8598-ef077b268e87\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Junior%20August%20Summer%20Letters/Parent%20Student%20Handbook%20Calendar%20Declaration.pdf\">Parent Student Handbook Calendar Declaration (August)</a></li><li id=\"8dcee51e-b11b-4c03-b614-bab53dbf2741\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Junior%20July%20Summer%20Letters/Personal%20Appearance%20-%20Dress%20Code.pdf\">Personal Appearance - Dress Code (July)</a></li><li id=\"0d986f31-c0e6-4e56-a047-a538c17dcc65\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Junior%20July%20Summer%20Letters/Religion%20Service%20-%20Reading%20Letter.pdf\">Religion Service Letter (July)</a></li><li id=\"6bd8d984-4563-4b17-8e8d-d1c93afb04f6\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Junior%20July%20Summer%20Letters/Titan%20Parent%20Club%20Sponsor%20Brochure.pdf\">Titan Parent Club Sponsor Brochure (July)</a></li><li id=\"c3b54cea-bcdc-4883-bd0e-001fb6a39639\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Junior%20July%20Summer%20Letters/Titan%20Parents%20Club%20Letter.pdf\">Titan Parents Club Letter (July)</a></li></ul></li><li id=\"18211706-e694-458d-acd4-7ea217b36e83\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=18211706-e694-458d-acd4-7ea217b36e83\">Senior Letters</a><ul id=\"cat18211706-e694-458d-acd4-7ea217b36e83\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=18211706-e694-458d-acd4-7ea217b36e83\">Senior Letters</a></label></li><li id=\"e11a2bf2-86c2-49d2-9f31-fedc85828bed\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Senior%20August%20Summer%20Letters/12th%20Grade%20Guidance%20Office%20Testing%20Information.pdf\">12th Grade Guidance Office Testing Information (August)</a></li><li id=\"519edc3b-542b-468e-b503-3d2f747706ae\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Senior%20July%20Summer%20Letters/Dress%20Code%20Letter%20from%20the%20Principal.pdf\">Dress Code Letter from the Principal (July)</a></li><li id=\"60e1df1e-64ff-4f8f-a2dd-59203ccd0449\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Senior%20August%20Summer%20Letters/10th,%2011th,%2012th%20grades%20-%20First%20Days%20of%20School.pdf\">First Days of School (August)</a></li><li id=\"71ba73c5-6ad4-4582-b7b4-8e8e21d639b8\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Senior%20August%20Summer%20Letters/10th,%2011th,%2012th%20Important%20Information%20from%20the%20Principal%20and%20Dean.pdf\">Important Information from the Principal and Dean (August)</a></li><li id=\"dd45328e-6633-4995-b470-254b710492c0\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Senior%20August%20Summer%20Letters/Parent%20Student%20Handbook%20Calendar%20Declaration.pdf\">Parent Student Handbook Calendar Declaration (August)</a></li><li id=\"fefb0c27-9f8e-44ab-b920-58caa7553eb8\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Senior%20July%20Summer%20Letters/Personal%20Appearance%20-%20Dress%20Code.pdf\">Personal Appearance - Dress Code (July)</a></li><li id=\"21ec4f83-ab96-485d-9074-bd780aef15a8\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Senior%20July%20Summer%20Letters/Religion%20Service%20Letter.pdf\">Religion Service Letter (July)</a></li><li id=\"59401a37-c9ab-41ac-bb5e-21429ea3a74c\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Senior%20July%20Summer%20Letters/Senior%20Privileges.pdf\">Senior Privileges (July)</a></li><li id=\"097a9a4b-4e59-4925-9f8b-4488f0531e5a\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Senior%20July%20Summer%20Letters/Titan%20Parent%20Club%20Sponsor%20Brochure.pdf\">Titan Parent Club Sponsor Brochure (July)</a></li><li id=\"a53c291e-47d7-47f9-8c98-a9c25b766fc2\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/Senior%20July%20Summer%20Letters/Titan%20Parents%20Club%20Letter.pdf\">Titan Parents Club Letter (July)</a></li></ul></li><li id=\"38d5e348-81b7-4bab-8c35-51814b14b2a7\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=38d5e348-81b7-4bab-8c35-51814b14b2a7\">Family Participation Program</a></li><li id=\"0feec5ac-8ac8-44da-b41c-a27067d70d22\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=0feec5ac-8ac8-44da-b41c-a27067d70d22\">School Reach Messages</a></li><li id=\"fa44e63c-bedf-45b6-97a2-26477ca5196d\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=fa44e63c-bedf-45b6-97a2-26477ca5196d\">Photo Albums</a><ul id=\"catfa44e63c-bedf-45b6-97a2-26477ca5196d\" class=\"dropdown left\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=fa44e63c-bedf-45b6-97a2-26477ca5196d\">Photo Albums</a></label></li><li id=\"0b744865-ad8a-4e76-8d42-15966cd7c4e2\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=0b744865-ad8a-4e76-8d42-15966cd7c4e2\">Art Show<span class=\"image-newindicator\"></span></a></li><li id=\"1df89e65-2fe8-4094-8028-b0416aa45ad1\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=1df89e65-2fe8-4094-8028-b0416aa45ad1\">Quill & Scroll Honor Society Induction<span class=\"image-newindicator\"></span></a></li><li id=\"559016a8-9ebf-4098-9b21-402c03e425a7\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=559016a8-9ebf-4098-9b21-402c03e425a7\">Performing Arts Honor Societies Induction Ceremonies<span class=\"image-newindicator\"></span></a></li><li id=\"f485bc14-dff5-4fcc-86ef-2edec661c537\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=f485bc14-dff5-4fcc-86ef-2edec661c537\">Foreign Language Honor Society<span class=\"image-newindicator\"></span></a></li><li id=\"ae3851f7-3753-4722-9e03-7522d5ba35fe\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=ae3851f7-3753-4722-9e03-7522d5ba35fe\">National Honor Society Induction</a></li><li id=\"256a2d53-f417-434f-928c-f8c123172208\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=256a2d53-f417-434f-928c-f8c123172208\">Math Honor Society Induction Ceremony</a></li><li id=\"3b696ead-7873-4a49-8697-c6bb79ac39ab\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=3b696ead-7873-4a49-8697-c6bb79ac39ab\">Science National Honor Society Induction</a></li><li id=\"6c740415-82cc-47ff-ad9a-180d7dee2f7b\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=6c740415-82cc-47ff-ad9a-180d7dee2f7b\">National Art Honor Society</a></li><li id=\"48219f29-f17f-4272-b965-c4a9bc20c270\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=48219f29-f17f-4272-b965-c4a9bc20c270\">Spring Musical \"Big Fish\"</a></li><li id=\"cba6e878-7cdd-4039-9631-e1cb00a7e35e\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=cba6e878-7cdd-4039-9631-e1cb00a7e35e\">Spring Blood Drive</a></li><li id=\"2391c1ba-60c5-403b-b388-ca74af32b3bb\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=2391c1ba-60c5-403b-b388-ca74af32b3bb\">Black History Show</a></li><li id=\"3026448e-756f-4aaa-8bdb-48f6795f5b59\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=3026448e-756f-4aaa-8bdb-48f6795f5b59\">Spirit Spirit Week - Twin Day</a></li><li id=\"2c5dfe60-fe7d-47e0-8a2d-11e682408e08\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=2c5dfe60-fe7d-47e0-8a2d-11e682408e08\">Senior Spirit Week - Decades Day</a></li><li id=\"b7692c36-7f9c-4f29-8cb0-9aa201dd56c5\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=b7692c36-7f9c-4f29-8cb0-9aa201dd56c5\">Senior Spirit Week - Celebrity Day</a></li><li id=\"8db1cdfc-7ef2-45a0-b118-f55092b726f4\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=8db1cdfc-7ef2-45a0-b118-f55092b726f4\">Senior Repertory Show - \"REP\"</a></li><li id=\"78224c68-7155-4b2e-999c-cc9abf549f2b\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=78224c68-7155-4b2e-999c-cc9abf549f2b\">Junior Ring Night</a></li><li id=\"a4899494-7542-463b-9f2f-6cee4aa0f73d\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=a4899494-7542-463b-9f2f-6cee4aa0f73d\">Junior Banquet</a></li><li id=\"a2f1accc-e5ed-481a-9a03-d65bc16a3f89\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=a2f1accc-e5ed-481a-9a03-d65bc16a3f89\">Pops Concert</a></li><li id=\"0f51718d-2786-4aef-b5f0-2d737260594b\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=0f51718d-2786-4aef-b5f0-2d737260594b\">Math Madness</a></li><li id=\"9fe3988b-dbba-4f0f-9bad-1707c34e7cdc\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=9fe3988b-dbba-4f0f-9bad-1707c34e7cdc\">Science & Technology Fair</a></li><li id=\"934126f6-9536-41bf-912a-d8449bb225c9\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=934126f6-9536-41bf-912a-d8449bb225c9\">Dance Concert - \"Look Up\"</a></li><li id=\"25a9569b-37cc-44ee-a110-c6e550f1eb36\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=25a9569b-37cc-44ee-a110-c6e550f1eb36\">Christmas Liturgy</a></li><li id=\"6be49c9a-36ad-4fa6-8753-3927837db43b\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=6be49c9a-36ad-4fa6-8753-3927837db43b\">Christmas Concert</a></li><li id=\"a8a1efad-ac64-4784-a01c-09953e927fe5\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=a8a1efad-ac64-4784-a01c-09953e927fe5\">Catholic Charities Christmas Serve-a-thon</a></li><li id=\"b81169dc-0f07-47ee-9eb1-a9bd11873007\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=b81169dc-0f07-47ee-9eb1-a9bd11873007\">Career Forum</a></li><li id=\"e53e6f23-51be-45dc-9650-777ce41d1c1b\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=e53e6f23-51be-45dc-9650-777ce41d1c1b\">Thanksgiving Liturgy</a></li><li id=\"7350d1a4-7544-4f81-b593-01858b61a6cd\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=7350d1a4-7544-4f81-b593-01858b61a6cd\">Fall Blood Drive</a></li><li id=\"d7b3b361-1c9c-47df-ad3e-f5caffca12b5\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=d7b3b361-1c9c-47df-ad3e-f5caffca12b5\">Fall Drama - Macbeth</a></li><li id=\"650c9d03-7cca-4184-9cbd-1bbef4a1cfbb\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=650c9d03-7cca-4184-9cbd-1bbef4a1cfbb\">Volley 4 Life</a></li><li id=\"a11801cf-1b77-48a6-8a84-89fa18dcc972\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=a11801cf-1b77-48a6-8a84-89fa18dcc972\">College Fair</a></li><li id=\"04897a25-6b53-493a-a1ef-560409771520\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=04897a25-6b53-493a-a1ef-560409771520\">Womens Communion Breakfast</a></li><li id=\"e76fd36b-c756-4b56-8312-c2effa0c6263\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=e76fd36b-c756-4b56-8312-c2effa0c6263\">Pasta Night</a></li><li id=\"184ee977-503f-4f68-9261-a4a335e5abf9\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=184ee977-503f-4f68-9261-a4a335e5abf9\">Pilobolus Dance Workshop</a></li><li id=\"655c7d04-0475-4fa3-ae88-3dd846a0fc98\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=655c7d04-0475-4fa3-ae88-3dd846a0fc98\">Homecoming</a></li><li id=\"71ae885b-100c-4835-b473-00ebd8404afc\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=71ae885b-100c-4835-b473-00ebd8404afc\">Fall Pep Rally</a></li><li id=\"4701694f-805a-4dd1-898d-7e34f8beba75\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=4701694f-805a-4dd1-898d-7e34f8beba75\">Grotto Dedication</a></li><li id=\"1a91fb8e-df2f-4f84-9211-fc2b8d33a930\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=1a91fb8e-df2f-4f84-9211-fc2b8d33a930\">Mass on the Grass</a></li><li id=\"b61d427c-159e-4a67-b3d1-bf2a80bda5d8\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=b61d427c-159e-4a67-b3d1-bf2a80bda5d8\">Freshman Bunco Party</a></li><li id=\"ad0087a3-3f2d-4dbe-abf5-310d48a1811e\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=ad0087a3-3f2d-4dbe-abf5-310d48a1811e\">Class of 2018 - Freshmen Orientation Day</a></li><li id=\"22ff5ab3-405b-487f-87db-437a1e4c5948\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=22ff5ab3-405b-487f-87db-437a1e4c5948\">October 2014 Digital Photo Club Pictures</a></li><li id=\"66124d84-8162-4267-a90a-8840268bafb8\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_photoalbum.aspx?resourceId=66124d84-8162-4267-a90a-8840268bafb8\">Gym Make-Over Project</a></li><li id=\"e987f722-5ffa-4c73-96f3-bf4a285ae5b8\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=e987f722-5ffa-4c73-96f3-bf4a285ae5b8\">2010-2011 Photos</a><ul id=\"cate987f722-5ffa-4c73-96f3-bf4a285ae5b8\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=e987f722-5ffa-4c73-96f3-bf4a285ae5b8\">2010-2011 Photos</a></label></li></ul></li><li id=\"35a89f62-5bd2-4994-883f-2aa11ab71a61\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=35a89f62-5bd2-4994-883f-2aa11ab71a61\">2011-2012 Photos</a><ul id=\"cat35a89f62-5bd2-4994-883f-2aa11ab71a61\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=35a89f62-5bd2-4994-883f-2aa11ab71a61\">2011-2012 Photos</a></label></li></ul></li><li id=\"3904e3b1-fe0f-4a1e-8ccf-e1a8a790c914\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=3904e3b1-fe0f-4a1e-8ccf-e1a8a790c914\">2012-2013 Photos</a><ul id=\"cat3904e3b1-fe0f-4a1e-8ccf-e1a8a790c914\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=3904e3b1-fe0f-4a1e-8ccf-e1a8a790c914\">2012-2013 Photos</a></label></li></ul></li><li id=\"2049fc2d-3d24-4c62-8da5-a561370df621\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=2049fc2d-3d24-4c62-8da5-a561370df621\">2013-2014 Photos</a><ul id=\"cat2049fc2d-3d24-4c62-8da5-a561370df621\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=2049fc2d-3d24-4c62-8da5-a561370df621\">2013-2014 Photos</a></label></li></ul></li></ul></li><li id=\"54b1a189-adcc-48ec-b6ef-0a1d0d8c265d\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=54b1a189-adcc-48ec-b6ef-0a1d0d8c265d\">Press Releases</a><ul id=\"cat54b1a189-adcc-48ec-b6ef-0a1d0d8c265d\" class=\"dropdown left\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=54b1a189-adcc-48ec-b6ef-0a1d0d8c265d\">Press Releases</a></label></li><li id=\"21b4c9f7-68c6-4147-9d11-062377826cd7\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014-15%20Press%20Releases/Valedictorian%20and%20Salutatorian%20Press%20Release.pdf\">April 27, 2015 - Holy Trinity Announces Valedictorian and Salutatorian</a></li><li id=\"ed92cfb4-d8ef-4381-8505-607965adffe8\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014-15%20Press%20Releases/2015.Gala.Honorees.pdf\">March 3, 2015 - 3rd Annual Principal’s Gala Honorees</a></li><li id=\"615a78a4-eb65-425d-b7aa-5735f3a6c408\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014-15%20Press%20Releases/Synthia%20Link%20Press%20Release.pdf\">Feb. 13, 2015 - Holy Trinity Alumna Synthia Link Speaks to Students about Her Broadway Success</a></li><li id=\"3179aaf1-b6ff-4a83-a18a-298079fde561\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014-15%20Press%20Releases/Abiola%20Adedeji%20National%20Merit%20Scholar%20Press%20Release.pdf\">Feb. 10, 2015 - Holy Trinity Diocesan High School Announces National Merit Scholarship Finalist</a></li><li id=\"78e32cf5-6e24-475f-8dd8-7591e0bec88e\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014-15%20Press%20Releases/March%20for%20Life%20Press%20Release.pdf\">Feb. 5, 2015 - Holy Trinity’s Respect Life Club Attended “March for Life”</a></li><li id=\"3fc8e9fb-e20f-44e0-92e2-bb6cf766b70f\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014-15%20Press%20Releases/Masters%20Press%20Release.pdf\">Jan. 8, 2015 - Holy Trinity Announces New Academic Recognition Program</a></li><li id=\"87358781-4efd-4244-96ec-9628e4bcca6c\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014-15%20Press%20Releases/ACE%20Program%20Press%20Release.pdf\">Nov 19, 2014 - Holy Trinity Diocesan High School Brings the ACE Mentor Program On Campus</a></li><li id=\"ba42ea4c-0bec-4285-902c-00688eeb34b5\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014-15%20Press%20Releases/Volley%20for%20Life%20Press%20Release.pdf\">Nov. 19, 2014 - Holy Trinity’s Respect Life Club Holds 2nd Annual “Volley for Life” Event</a></li><li id=\"10a4a65f-acc3-441a-91a7-1b8b4ad4ad2d\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014-15%20Press%20Releases/Career%20Forum%20Press%20Release.pdf\">Nov. 13, 2014 - Holy Trinity Preparing for 2nd Annual “Career Forum”</a></li><li id=\"ae9d1be0-58b3-41cd-980a-cd1d48cbe81b\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014-15%20Press%20Releases/Grotto%20Dedication%20Press%20Release.pdf\">Oct. 24, 2014 - Holy Trinity Class of 2014 Dedicates New Grotto</a></li><li id=\"5cd32a79-9a09-417f-b1f5-b25a6502b246\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014-15%20Press%20Releases/Isabella%20Mazza%20National%20Merit%20Commended%20Press%20Release.pdf\">Oct. 3, 2014 - Holy Trinity Announces Commended Student in 2015 National Merit Scholarship Program</a></li><li id=\"42bb7475-36b9-4e18-a424-931c5ecf0814\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/2014-15%20Press%20Releases/Abiola%20Adedeji%20National%20Merit%20Scholar%20Press%20Release.pdf\">Oct. 1, 2014 - Holy Trinity Diocesan High School Announces National Merit Scholar Semifinalist</a></li><li id=\"d463cf0c-423e-4697-9c59-c9be96cdb792\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=d463cf0c-423e-4697-9c59-c9be96cdb792\">2013-2014 Press Releases</a><ul id=\"catd463cf0c-423e-4697-9c59-c9be96cdb792\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=d463cf0c-423e-4697-9c59-c9be96cdb792\">2013-2014 Press Releases</a></label></li></ul></li><li id=\"aa63c133-cf3c-429b-b6b9-2527432fc5a1\" class=\"\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=aa63c133-cf3c-429b-b6b9-2527432fc5a1\">2012-2013 Press Releases</a><ul id=\"cataa63c133-cf3c-429b-b6b9-2527432fc5a1\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=aa63c133-cf3c-429b-b6b9-2527432fc5a1\">2012-2013 Press Releases</a></label></li></ul></li></ul></li><li id=\"c55fd7f1-f899-4172-a1d4-40a0d8a55a92\"><a href=\"http://www.wcbs880.com/snow-closings/3073\" target=\"_blank\">WCBS School Snow Closings</a></li><li id=\"37a07d39-9c58-4902-ade3-0484f87906b6\"><a href=\"http://www.drvc.org\" target=\"_blank\">Diocese of Rockville Centre</a></li><li id=\"e47435f6-f304-4159-98d6-bec9e87cd790\"><a href=\"http://holytrinityhs.echalk.com/download.axd?file=e47435f6-f304-4159-98d6-bec9e87cd790&dnldType=Resource\">Announcements 5/5/15</a></li><li id=\"b2259d4d-d7bb-4734-bcab-634665ac2345\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=b2259d4d-d7bb-4734-bcab-634665ac2345\">Ready America</a></li></ul></li><li id=\"b837b1ac-1ebc-4fcc-b79e-66501e6b538d\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=b837b1ac-1ebc-4fcc-b79e-66501e6b538d\">Alumni / Giving</a><ul id=\"catb837b1ac-1ebc-4fcc-b79e-66501e6b538d\" class=\"dropdown right\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=b837b1ac-1ebc-4fcc-b79e-66501e6b538d\">Alumni / Giving</a></label></li><li id=\"d6d16dc6-47b1-4a60-8c3f-9874d415b273\"><a href=\"http://holytrinityalumni.org/\">Alumni Website</a></li><li id=\"e7008794-0599-4d20-9c51-1937041edb36\"><a href=\"http://www.mcssl.com/store/holytrinitydiocesan/trinity-fund\" target=\"_blank\">Donate Now</a></li><li id=\"9af45961-7d9f-4856-87a2-9ce2a1a99c47\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=9af45961-7d9f-4856-87a2-9ce2a1a99c47\">Turf Field Campaign</a></li><li id=\"fc95e41f-ff4f-4a9a-af48-5477f4a4f401\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=fc95e41f-ff4f-4a9a-af48-5477f4a4f401\">Principal's Gala</a></li><li id=\"0cec7430-66bb-400f-a61a-35b599474a8e\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=0cec7430-66bb-400f-a61a-35b599474a8e\">Annual Golf Outing</a></li><li id=\"f758df69-7f42-4b02-a4f7-a83dadbb6f2e\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=f758df69-7f42-4b02-a4f7-a83dadbb6f2e\">Bleacher Initiative - Thank You!</a></li><li id=\"c55cc740-a026-4a22-810e-710ca08be5ee\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=c55cc740-a026-4a22-810e-710ca08be5ee\">Class Pride Bleacher Competition</a></li><li id=\"c91b7cb4-27e7-41c2-9331-a632bdfa1f54\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=c91b7cb4-27e7-41c2-9331-a632bdfa1f54\">Career Forum</a></li><li id=\"56247149-4d6e-48cf-907b-53ca98b4bdd5\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/HT%20DONOR%20BK14%20R17.pdf\">2014 Honor Roll of Donors</a></li><li id=\"15a386d3-cc30-42e1-9a1a-99da48d806b5\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=15a386d3-cc30-42e1-9a1a-99da48d806b5\">Reunions - Fall 2014</a></li><li id=\"b4b1b28d-7c6a-4c2d-98c8-d54521448ea9\"><a href=\"http://holytrinityhs.echalk.com/www/holytrinityhs/site/hosting/HT%20ANN%20REP2014%20r5.pdf\">2013-2014 Annual Report</a></li><li id=\"12d285e1-cbd9-4960-82e0-c4a0a12a9e48\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=12d285e1-cbd9-4960-82e0-c4a0a12a9e48\">Hall of Fame</a></li><li id=\"c294edaf-4255-4c8f-a57f-d71f2fe259a6\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=c294edaf-4255-4c8f-a57f-d71f2fe259a6\">Field Banners</a></li><li id=\"1ed9c732-5a2d-4576-b2d4-0c31a6d31346\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=1ed9c732-5a2d-4576-b2d4-0c31a6d31346\">Remember When?</a></li><li id=\"dd6dccd5-177c-4673-88af-d8bf137a2722\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=dd6dccd5-177c-4673-88af-d8bf137a2722\">Alumni Profiles</a><ul id=\"catdd6dccd5-177c-4673-88af-d8bf137a2722\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=dd6dccd5-177c-4673-88af-d8bf137a2722\">Alumni Profiles</a></label></li><li id=\"8fac2738-05ea-4122-bf81-2eac5f82655a\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=8fac2738-05ea-4122-bf81-2eac5f82655a\">Alumni \"On the Road\" - The Silva Brothers Cycle Around the World</a></li><li id=\"52e02506-d6a2-4284-9bda-9624a9c01a47\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=52e02506-d6a2-4284-9bda-9624a9c01a47\">Jean (Lutri) Shafiroff, Class of 1972</a></li><li id=\"e580c650-4dab-4363-aee0-badb43dee873\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=e580c650-4dab-4363-aee0-badb43dee873\">Joe Zwilling, Class of '77</a></li><li id=\"a2604105-0287-4bbb-ab3c-2bd602c3696d\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=a2604105-0287-4bbb-ab3c-2bd602c3696d\">Christina Lynch Markham, Class of '00</a></li><li id=\"d59849a4-0029-4d3f-a31c-a15c0840a035\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=d59849a4-0029-4d3f-a31c-a15c0840a035\">Ronnie Cameron, Class of '07</a></li><li id=\"bed65139-f901-4af9-b491-e6f259e4d41a\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=bed65139-f901-4af9-b491-e6f259e4d41a\">Michael Lavelle, Jr. - Class of 2008</a></li><li id=\"e6ce1833-b3cc-442d-a398-0e1d997b61af\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=e6ce1833-b3cc-442d-a398-0e1d997b61af\">Meaghan Flatley, Class of 2011</a></li><li id=\"2049c336-cd9e-4b13-8aa1-8a30b2ea9912\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=2049c336-cd9e-4b13-8aa1-8a30b2ea9912\">Aidan Campolettano, Class of 2013</a></li></ul></li><li id=\"0d0422bd-3e13-4db1-8261-a3470cf0f3b8\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=0d0422bd-3e13-4db1-8261-a3470cf0f3b8\">Benefits for Alumni and HT Families</a><ul id=\"cat0d0422bd-3e13-4db1-8261-a3470cf0f3b8\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=0d0422bd-3e13-4db1-8261-a3470cf0f3b8\">Benefits for Alumni and HT Families</a></label></li><li id=\"9c7692e7-8ca6-464a-9845-179cefd0ec43\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=9c7692e7-8ca6-464a-9845-179cefd0ec43\">Club Agency - Insurance Discounts</a></li><li id=\"aab80233-259c-4b6e-b7e7-ca8c97cfcd4f\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=aab80233-259c-4b6e-b7e7-ca8c97cfcd4f\">Plum Benefits</a></li></ul></li><li id=\"343f923e-6f3f-46c5-aa6a-60b175684eb7\" class=\"has-dropdown\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_folder.aspx?id=343f923e-6f3f-46c5-aa6a-60b175684eb7\">Shop & Giveback to Trinity</a><ul id=\"cat343f923e-6f3f-46c5-aa6a-60b175684eb7\" class=\"dropdown\"><li class=\"title back js-generated\"><h5><a href=\"#\">« Back</a></h5></li><li><label><a href=\"/site_res_view_folder.aspx?id=343f923e-6f3f-46c5-aa6a-60b175684eb7\">Shop & Giveback to Trinity</a></label></li><li id=\"5be5a58f-7cae-44aa-a91c-302da4b85567\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=5be5a58f-7cae-44aa-a91c-302da4b85567\">Goodsearch.com and Goodshop.com</a></li><li id=\"efa76996-1f44-48a0-8d93-e6c90b21979d\"><a href=\"http://holytrinityhs.echalk.com/site_res_view_template.aspx?id=efa76996-1f44-48a0-8d93-e6c90b21979d\">iGive.com</a></li><li id=\"4f3ff488-4004-45cb-a90b-084217e3972e\"><a href=\"http://www.onecause.com/\" target=\"_blank\">OneCause: Support Holy Trinity when you shop online</a></li><li id=\"24424563-9b7f-45c3-bf35-852c905a4a31\"><a href=\"http://www.stopandshop.com/savings-and-rewards/rewards-program/aplus/\" target=\"_blank\">Stop & Shop A+ School Rewards (Trinity # is 07858)</a></li><li id=\"091d7799-700e-4922-9221-dfd69b5c93ef\"><a href=\"https://www-secure.target.com/redcard/tcoe/home\" target=\"_blank\">Target: Take Charge of Education</a></li></ul></li></ul></li></ul><a href=\"http://www.mcssl.com/store/holytrinitydiocesan/trinity-fund\" class=\"image-donate-btn ir\">Donate Now</a>\n </section></nav>\n</div>\n```\n\n </div>\n</header></div><div id=\"ctl00_TopHeaderZone\">\n\n</div>\n </div>\n <div class=\"wrapper topNavOnly\">\n\n```\n <div class=\"navRpt color-pc clear-both\"></div>\n <div id=\"ctl00_bannerZone\">\n```\n\n</div>\n <div id=\"ctl00_mainSpaceHeader_breadCrumbs\" class=\"breadCrumbs\">\n <a href=\"#ctl00_mainSpaceHeader_breadCrumbs_SkipLink\"><img alt=\"Skip Navigation Links\" src=\"/WebResource.axd?d=5mOOCSTE9Eh6UN2FPdziw0Urnj32t0tNaCdgA4yyWqej9mDpoYtBvyBwUxwNVhSvOVC43zRlGLKncgiHEu3jwGXUero1&t=635219704397744380\" style=\"border-width:0px;\" height=\"0\" width=\"0\"></a><span></span><span></span><span><a onmouseover=\"return showStatus('News');\" onmouseout=\"return showStatus('');\" class=\"rootBreadCrumb\" href=\"/site_res_view_folder.aspx?id=B8A37ED6-6833-4C0B-AF64-0408F2B9D7CE\">News</a></span><span class=\"breadCrumbSeperator\"> </span><span><a onmouseover=\"return showStatus('Photo Albums');\" onmouseout=\"return showStatus('');\" class=\"parentBreadCrumb\" href=\"/site_res_view_folder.aspx?id=FA44E63C-BEDF-45B6-97A2-26477CA5196D\">Photo Albums</a></span><span class=\"breadCrumbSeperator\"> </span><span class=\"currentBreadCrumb font-pc\">Art Show</span><a id=\"ctl00_mainSpaceHeader_breadCrumbs_SkipLink\"></a>\n</div><div class=\"content template clear-both\">\n <div class=\"mainContainer\">\n <div class=\"insideMainColWrapper\">\n\n```\n <div></div>\n```\n\n<h1 class=\"pageTitleContainer\">\n <span class=\"headerBullet color-pc\"></span><span id=\"ctl00_mainSpaceHeader_ctl00_pageTitle\" class=\"pageTitle\">Art Show</span>\n</h1>\n\n<div class=\"clear-both\"></div>\n \n\n```\n <div>\n<div id=\"ctl00_mainContent_dlPhotoAlbum\">\n<div id=\"ctl00_mainContent_dlPhotoAlbum_directoryContent\" style=\"margin-top:6px;margin-top:6px;\">\n\n <div style=\"margin: 15px 0px 20px 0px;\">\n <span id=\"ctl00_mainContent_dlPhotoAlbum_descText\"><br></span>\n </div>\n <div id=\"ctl00_mainContent_dlPhotoAlbum_flashviewer\" class=\"box-nc box-1503227594 flashviewer\">\n <div id=\"ctl00_mainContent_dlPhotoAlbum_flashviewer_ctl00_Template_flashViewer\" class=\"photoAlbumFlashViewer\"><object id=\"ctl00_mainContent_dlPhotoAlbum_flashviewer_FlashPlayer\" classid=\"clsid:D27CDB6E-AE6D-11cf-96B8-444553540000\" codebase=\"http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=10,1,53,64\" type=\"application/x-shockwave-flash\" style=\"width:700px;height:700px;\"><param name=\"movie\" value=\"/WebResource.axd?d=UQ3OteQpUrv3kfXcgikq_bECx2CdpXPnmjA9F6yoGcgw1gprjYGi1s5lWfdi_GUwzJ6nqrc1KUTlfUy4jKUTxf3fxU5jGR8LZ8_Bvm_G75tPetwvxT6mXEX4llYHkCXTphf3tcu04BcFNumiN3xbBJaWxNEORN63VtLwokm6x1oIzXfI0&t=635654252639671069\"><param name=\"quality\" value=\"high\"><param name=\"wmode\" value=\"transparent\"><param name=\"FlashVars\" value=\"xmlFilePath=http%3a%2f%2fholytrinityhs.echalk.com%2fFlashXml.axd%3fid%3d0b744865-ad8a-4e76-8d42-15966cd7c4e2%26mode%3dview%26isMgtMode%3dFalse\"><embed src=\"http://static2.echalk.net/WebResource.axd?d=UQ3OteQpUrv3kfXcgikq_bECx2CdpXPnmjA9F6yoGcgw1gprjYGi1s5lWfdi_GUwzJ6nqrc1KUTlfUy4jKUTxf3fxU5jGR8LZ8_Bvm_G75tPetwvxT6mXEX4llYHkCXTphf3tcu04BcFNumiN3xbBJaWxNEORN63VtLwokm6x1oIzXfI0&t=635654252639671069\" quality=\"high\" name=\"ctl00_mainContent_dlPhotoAlbum_flashviewer_FlashPlayerEmbed\" pluginspage=\"http://www.macromedia.com/go/getflashplayer\" type=\"application/x-shockwave-flash\" wmode=\"transparent\" style=\"width:700px;height:700px;\" flashvars=\"xmlFilePath=http%3a%2f%2fholytrinityhs.echalk.com%2fFlashXml.axd%3fid%3d0b744865-ad8a-4e76-8d42-15966cd7c4e2%26mode%3dview%26isMgtMode%3dFalse\"></object></div>\n```\n\n<div class=\"clear-both\"></div>\n\n```\n </div>\n\n</div>\n```\n\n</div>\n</div>\n\n<div class=\"backLink\">\n <span class=\"backLinkBullet color-sc\"></span><a id=\"ctl00_mainSpaceFooter_ctl00_backLink\" href=\"/site_res_view_folder.aspx?id=FA44E63C-BEDF-45B6-97A2-26477CA5196D\">Back to Photo Albums</a>\n</div>\n \n\n```\n </div>\n </div>\n <div class=\"clear-both\"></div>\n </div><!-- content end-->\n\n </div><!-- wrapper end -->\n <div class=\"footer template clear-both\">\n```\n\n<footer class=\"custom-footer\">\n <div class=\"wrap\">\n <div class=\"footer-right\">\n <div id=\"google_translate_element\"><div style=\"\" dir=\"ltr\" class=\"skiptranslate goog-te-gadget\"><div class=\"goog-te-gadget-simple\" style=\"white-space: nowrap;\" id=\":0.targetLanguage\"><img style=\"background-image: url("https://translate.googleapis.com/translate_static/img/te_ctrl3.gif"); background-position: -65px 0px;\" class=\"goog-te-gadget-icon\" src=\"https://www.google.com/images/cleardot.gif\"><span style=\"vertical-align: middle;\"><a href=\"javascript:void(0)\" class=\"goog-te-menu-value\"><span>Select Language</span><img src=\"https://www.google.com/images/cleardot.gif\" height=\"1\" width=\"1\"><span style=\"border-left: 1px solid rgb(187, 187, 187);\"></span><img src=\"https://www.google.com/images/cleardot.gif\" height=\"1\" width=\"1\"><span style=\"color: rgb(155, 155, 155);\">▼</span></a></span></div></div></div>\n <script type=\"text/javascript\">\n function googleTranslateElementInit() {\n new google.translate.TranslateElement({pageLanguage: 'en', layout: google.translate.TranslateElement.InlineLayout.SIMPLE}, 'google_translate_element');\n }\n </script>\n <script type=\"text/javascript\" src=\"//translate.google.com/translate_a/element.js?cb=googleTranslateElementInit\"></script><a href=\"http://echalk.com\" target=\"_blank\" class=\"image-echalk-logo ir\">Powered by eChalk</a>\n </div>\n <div class=\"footer-left\">\n <p>Holy Trinity Diocesan High School, 98 Cherry Lane, Hicksville, NY 11801</p>\n <ul class=\"lined-list divided-list\">\n <li>Phone: 516-433-2900</li>\n <li>Fax: 516-433-2827</li>\n </ul>\n <ul class=\"lined-list divided-list\">\n <li><a href=\"/contact\">Contact Us</a></li>\n <li><a href=\"/directions\">Locate School</a></li>\n <li><a href=\"/userpolicy\">User Policy</a></li>\n </ul>\n </div>\n </div>\n <div class=\"wrap\"><small>Accredited by board of regents of the University of the state of New York middle states association of colleges and schools recipient of the National Exemplary School Award Holy Trinity High School does not discriminate on the basis of race, color, national or ethnic origin in the administration of its admission, educational, athletic or administered policies or programs.</small></div>\n</footer></div>\n\n```\n <div>\n <div id=\"ctl00_BottomFooterZone\">\n```\n\n</div>\n </div>\n\n<script type=\"text/javascript\">\n//<![CDATA[\nvar Page_ValidationSummaries = new Array('ctl00_vm_ctl00');\n//]]>\n</script>\n\n<script type=\"text/javascript\">\n//<![CDATA[\nSys.Application.initialize1 = Sys.Application.initialize; Sys.Application.initialize = function(){}; var PostAppInitialize = function(){ Sys.Application.initialize = Sys.Application.initialize1; Sys.Application.initialize(); $removeHandler(window, 'load', PostAppInitializeHandler); PostAppInitializeHandler = null; }; var PostAppInitializeHandler = Function.createDelegate(window, PostAppInitialize); $addHandler(window, 'load', PostAppInitializeHandler);var Sorted_Validators_PrePopulate=false;\nSys.Application.add_init(function() {\n $create(eChalk.Web.UI.WebControls.Prompt, {\"allowDrag\":true,\"backgroundCssClass\":\"modalStyle\",\"causesValidation\":false,\"handle\":$get(\"ctl00_vm_ctl00_ValidationPrompt_Handle\"),\"message\":null,\"messageFile\":null,\"messageLabel\":$get(\"ctl00_vm_ctl00_ValidationPrompt_Message\"),\"modal\":true,\"postBackTarget\":0,\"postBackUrl\":null,\"title\":\"Validation Warning\",\"titleLabel\":$get(\"ctl00_vm_ctl00_ValidationPrompt_Title\"),\"validationGroup\":\"\"}, null, null, $get(\"ctl00_vm_ctl00_ValidationPrompt\"));\n $create(eChalk.Web.UI.WebControls.PromptButton, {\"autoCallBack\":false,\"autoPostBack\":false,\"commandArgument\":\"ok\",\"onClientClick\":null,\"text\":\"Ok\"}, null, {\"prompt\":\"ctl00_vm_ctl00_ValidationPrompt\"}, $get(\"ctl00_vm_ctl00_ValidationPrompt_ok\"));\n});\nSys.Application.add_init(function() {\n $create(eChalk.Web.UI.WebControls.ValidationPrompt, {\"displayMode\":2,\"headerText\":null,\"id\":\"ctl00_vm_ctl00\",\"validateAll\":false,\"validationGroup\":null}, null, {\"prompt\":\"ctl00_vm_ctl00_ValidationPrompt\"}, $get(\"ctl00_vm_ctl00_ValidationPrompt\"));\n});\nSys.Application.add_init(function() {\n $create(eChalk.Web.UI.WebControls.Validation.ValidationManager, null, null, null, $get(\"ctl00_vm\"));\n});\n//]]>\n</script>\n\n</form>\n\n<!-- Start Theme Custom Footer -->\n\n<script src=\"http://static1cdn.echalk.net/www/corporate/site/hosting/pd/common/js/vendor/jquery.js\"></script>\n\n<script src=\"http://static1cdn.echalk.net/www/corporate/site/hosting/pd/common/js/underscore-min.js\"></script>\n\n<script src=\"http://static1cdn.echalk.net/www/corporate/site/hosting/pd/common/js/mustache.js\"></script>\n\n<script src=\"http://static1cdn.echalk.net/www/corporate/site/hosting/pd/common/js/moment.min.js\"></script>\n\n<script src=\"http://static1cdn.echalk.net/www/corporate/site/hosting/pd/common/js/async.js\"></script>\n\n<script src=\"http://static1cdn.echalk.net/www/corporate/site/hosting/pd/common/js/json2.js\"></script>\n\n<script src=\"http://static1cdn.echalk.net/www/corporate/site/hosting/pd/common/js/eChalkServicesMosaicJS.js\"></script>\n\n<script src=\"http://static1cdn.echalk.net/www/corporate/site/hosting/pd/common/js/eChalkRenderControlsMosaicJS.js\"></script>\n\n<script src=\"http://holytrinityhs.echalk.com/pd/holytrinityhs/preview/js/eChalkRenderTemplates.js\"></script>\n\n<script src=\"http://static1cdn.echalk.net/www/corporate/site/hosting/pd/common/js/jstorage.js\"></script>\n\n<script src=\"http://static1cdn.echalk.net/www/corporate/site/hosting/pd/common/js/vendor/custom.modernizr.js\"></script>\n\n<script src=\"http://static1cdn.echalk.net/www/corporate/site/hosting/pd/common/js/foundation.min.js\"></script>\n\n<script src=\"http://static1cdn.echalk.net/www/corporate/site/hosting/pd/common/js/modFoundationMenu.js\"></script>\n\n<script src=\"http://static1cdn.echalk.net/www/corporate/site/hosting/pd/common/js/PageRenderer.js\"></script>\n\n<script src=\"http://holytrinityhs.echalk.com/pd/holytrinityhs/preview/js/footer.js\"></script>\n\n<script>jq18 = jQuery.noConflict(true);</script>\n\n<script>\n $(document).ready(function() {\n $('.goog-te-menu-value').slice(1).hide();\n });\n</script>\n\n<script>\n (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){\n (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),\n m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)\n })\n (window,document,'script','//www.google-analytics.com/analytics.js', 'ga');\n ga('create','UA-24101432-12', 'auto', {'name': 'pwdCrossDomain'});\n ga('create','UA-46831390-2', 'auto', {'name': 'site'});\n ga('create','UA-7357366-1', 'auto', {'name': 'client'});\n ga('pwdCrossDomain.send', 'pageview');\n ga('site.send', 'pageview');\n ga('client.send','pageview');\n</script>\n\n<!-- End Theme Custom Footer --><div id=\"goog-gt-tt\" class=\"skiptranslate\" dir=\"ltr\"><div style=\"padding: 8px;\"><div><div class=\"logo\"><img src=\"https://www.google.com/images/icons/product/translate-32.png\" height=\"20\" width=\"20\"></div></div></div><div class=\"top\" style=\"padding: 8px; float: left; width: 100%;\"><h1 class=\"title gray\">Original text</h1></div><div class=\"middle\" style=\"padding: 8px;\"><div class=\"original-text\"></div></div><div class=\"bottom\" style=\"padding: 8px;\"><div class=\"activity-links\"><span class=\"activity-link\">Contribute a better translation</span><span class=\"activity-link\"></span></div><div class=\"started-activity-container\"><hr style=\"color: #CCC; background-color: #CCC; height: 1px; border: none;\"><div class=\"activity-root\"></div></div></div><div style=\"display: none;\" class=\"status-message\"></div></div>\n\n```\n <iframe style=\"visibility: visible; box-sizing: content-box; width: 860px; height: 285px; display: none;\" class=\"goog-te-menu-frame skiptranslate\" frameborder=\"0\"></iframe><div class=\"modalStyle\" style=\"display: none; position: absolute; left: 0px; top: 0px;\" id=\"prompt_modal_background\"></div></body></html>\"\n```\n",
"Sorry, what I want you to do is use your developer tools to see what web request your browser is making. I suspect you need some cookies you don't have.\n",
"My bad :)\nDo you mean the information under cookies in the resources tab?\n",
"Nvm found the problem\n\nThanks for everthing!\n"
] |
https://api.github.com/repos/psf/requests/issues/2627
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2627/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2627/comments
|
https://api.github.com/repos/psf/requests/issues/2627/events
|
https://github.com/psf/requests/issues/2627
| 83,953,323 |
MDU6SXNzdWU4Mzk1MzMyMw==
| 2,627 |
SSLv3 - OSX use last OpenSSL version [tag: ssl.OPENSSL_VERSION // SSL.SSLeay_version(SSL.SSLEAY_VERSION)]
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/122271?v=4",
"events_url": "https://api.github.com/users/PMickael/events{/privacy}",
"followers_url": "https://api.github.com/users/PMickael/followers",
"following_url": "https://api.github.com/users/PMickael/following{/other_user}",
"gists_url": "https://api.github.com/users/PMickael/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/PMickael",
"id": 122271,
"login": "PMickael",
"node_id": "MDQ6VXNlcjEyMjI3MQ==",
"organizations_url": "https://api.github.com/users/PMickael/orgs",
"received_events_url": "https://api.github.com/users/PMickael/received_events",
"repos_url": "https://api.github.com/users/PMickael/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/PMickael/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PMickael/subscriptions",
"type": "User",
"url": "https://api.github.com/users/PMickael",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 9 |
2015-06-02T10:09:43Z
|
2021-09-08T23:04:43Z
|
2015-06-02T11:31:47Z
|
NONE
|
resolved
|
Hi,
To reproduce the bug,
``` python
import requests
requests.get('https://www.monova.org/')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python2.7/site-packages/requests/api.py", line 69, in get
return request('get', url, params=params, **kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/api.py", line 50, in request
response = session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/sessions.py", line 465, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/sessions.py", line 573, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/adapters.py", line 370, in send
timeout=timeout
File "/usr/local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 544, in urlopen
body=body, headers=headers)
File "/usr/local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 344, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=conn.timeout)
File "/usr/local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 314, in _raise_timeout
if 'timed out' in str(err) or 'did not complete (read)' in str(err): # Python 2.6
TypeError: __str__ returned non-string (type Error)
```
On OSX python 2.7.10 and openssl 1.0.2a and requests 2.7.0
With openssl 0.9.8zd and python 2.7.8 and requests 2.6.0
``` python
File "python2.7/site-packages/requests/adapters.py", line 431, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: [Errno 1] _ssl.c:510: error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/122271?v=4",
"events_url": "https://api.github.com/users/PMickael/events{/privacy}",
"followers_url": "https://api.github.com/users/PMickael/followers",
"following_url": "https://api.github.com/users/PMickael/following{/other_user}",
"gists_url": "https://api.github.com/users/PMickael/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/PMickael",
"id": 122271,
"login": "PMickael",
"node_id": "MDQ6VXNlcjEyMjI3MQ==",
"organizations_url": "https://api.github.com/users/PMickael/orgs",
"received_events_url": "https://api.github.com/users/PMickael/received_events",
"repos_url": "https://api.github.com/users/PMickael/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/PMickael/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PMickael/subscriptions",
"type": "User",
"url": "https://api.github.com/users/PMickael",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2627/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2627/timeline
| null |
completed
| null | null | false |
[
"Yeah, this is a result of a change in urllib3. We fixed it in shazow/urllib3#622, and this should be fixed in the next release.\n",
"Yes for this error TypeError: **str** returned non-string (type Error), but the problem is also that I can do requests.get('https://www.monova.org/') for no reason ? The website is online and work.\n\nWith this fix, I get this error :\n\n``` python\n(\"bad handshake: Error([('SSL routines', 'SSL23_GET_SERVER_HELLO', 'sslv3 alert handshake failure')],)\",)\n```\n",
"Oh, my apologies, I didn't read your report correctly. Sorry!\n",
"The most likely problem is that your OpenSSL is too old, and we cannot negotiate a cipher with the remote server. When I test with a newer OpenSSL version I negotiate TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, using TLS v1.2. When I use my system OpenSSL, I don't offer that cipher (or any ECDHE cipher), and I only use TLS v1.0. I suspect that's your problem.\n\nWhat OS are you using?\n",
"I'm using OSX.\n\n``` bash\npython -c 'import ssl; print ssl.OPENSSL_VERSION' (06-02 12:50)\nOpenSSL 1.0.2a\n```\n\nTo get this I had to use brew\n\n``` bash\nbrew install python --with-brewed-openssl\n```\n\nBecause default ssl version is \n\n``` bash\noldpython -c 'import ssl; print ssl.OPENSSL_VERSION' \nOpenSSL 0.9.8zd 8 Jan 2015\n```\n\nWith openssl 1.0.2a\n\n``` bash\nopenssl s_client -connect monova.org:443 -servername monova.org -verify False \nverify depth is 0\nCONNECTED(00000003)\ndepth=2 C = GB, ST = Greater Manchester, L = Salford, O = COMODO CA Limited, CN = COMODO ECC Certification Authority\nverify error:num=20:unable to get local issuer certificate\n140735182091088:error:14090086:SSL routines:ssl3_get_server_certificate:certificate verify failed:s3_clnt.c:1205:\n---\nno peer certificate available\n---\nNo client certificate CA names sent\n---\nSSL handshake has read 3842 bytes and written 7 bytes\n---\nNew, (NONE), Cipher is (NONE)\nSecure Renegotiation IS supported\nCompression: NONE\nExpansion: NONE\nNo ALPN negotiated\nSSL-Session:\n Protocol : TLSv1.2\n Cipher : 0000\n Session-ID:\n Session-ID-ctx:\n Master-Key:\n Key-Arg : None\n PSK identity: None\n PSK identity hint: None\n SRP username: None\n Start Time: 1433242404\n Timeout : 300 (sec)\n Verify return code: 0 (ok)\n---\n```\n\nI have also try this without success (same error) :\n\n``` python\nfrom requests.adapters import HTTPAdapter\nfrom requests.packages.urllib3.poolmanager import PoolManager\n\n\nclass Ssl3HttpAdapter(HTTPAdapter):\n \"\"\"\"Transport adapter\" that allows us to use SSLv3.\"\"\"\n\n def init_poolmanager(self, connections, maxsize, block=False):\n self.poolmanager = PoolManager(num_pools=connections,\n maxsize=maxsize,\n block=block,\n ssl_version=ssl.PROTOCOL_SSLv3)\n```\n",
"The SSLAdapter you've used won't help you here, because you need a _more_ recent SSL, not a less recent.\n\nCan you try this for me please? `python -c 'from OpenSSL import SSL; print SSL.SSLeay_version(SSL.SSLEAY_VERSION)`\n\nI believe you're using PyOpenSSL, and that you didn't build it against the home-brew OpenSSL. If that command prints something other than OpenSSL 1.0.2, you will want to run this command:\n\n`env ARCHFLAGS=\"-arch x86_64\" LDFLAGS=\"-L/usr/local/opt/openssl/lib\" CFLAGS=\"-I/usr/local/opt/openssl/include\" pip install -U cryptography`\n\nThen try again.\n",
"``` bash\npython -c 'from OpenSSL import SSL; print SSL.SSLeay_version(SSL.SSLEAY_VERSION)' (06-02 13:05)\nOpenSSL 0.9.8zd 8 Jan 2015\n```\n\nWell that's the problem but this not working :\n\n``` bash\nenv ARCHFLAGS=\"-arch x86_64\" LDFLAGS=\"-L/usr/local/opt/openssl/lib\" CFLAGS=\"-I/usr/local/opt/openssl/include\" sudo pip install --upgrade cryptography\nRequirement already up-to-date: cryptography in /Library/Python/2.7/site-packages\nRequirement already up-to-date: idna in /Library/Python/2.7/site-packages (from cryptography)\nRequirement already up-to-date: pyasn1 in /Library/Python/2.7/site-packages (from cryptography)\nRequirement already up-to-date: six>=1.4.1 in /Library/Python/2.7/site-packages (from cryptography)\nRequirement already up-to-date: setuptools in /usr/local/lib/python2.7/site-packages/setuptools-17.0-py2.7.egg (from cryptography)\nRequirement already up-to-date: enum34 in /Library/Python/2.7/site-packages (from cryptography)\nRequirement already up-to-date: ipaddress in /Library/Python/2.7/site-packages (from cryptography)\nRequirement already up-to-date: cffi>=0.8 in /Library/Python/2.7/site-packages (from cryptography)\nRequirement already up-to-date: pycparser in /Library/Python/2.7/site-packages (from cffi>=0.8->cryptography)\n```\n",
"Add the `--force-reinstall` flag. =)\n",
"I just uninstall/reinstall :D.\n\nenv ARCHFLAGS=\"-arch x86_64\" LDFLAGS=\"-L/usr/local/Cellar/openssl/1.0.2a-1/lib\" CFLAGS=\"-I/usr/local/Cellar/openssl/1.0.2a-1/include\" sudo pip install cryptography\n\n``` bash\npython -c 'from OpenSSL import SSL; print SSL.SSLeay_version(SSL.SSLEAY_VERSION)' \nOpenSSL 1.0.2a 19 Mar 2015\n```\n\nThanks for you're help\n"
] |
https://api.github.com/repos/psf/requests/issues/2626
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2626/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2626/comments
|
https://api.github.com/repos/psf/requests/issues/2626/events
|
https://github.com/psf/requests/issues/2626
| 83,953,163 |
MDU6SXNzdWU4Mzk1MzE2Mw==
| 2,626 |
Mistake
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/255794?v=4",
"events_url": "https://api.github.com/users/leakid/events{/privacy}",
"followers_url": "https://api.github.com/users/leakid/followers",
"following_url": "https://api.github.com/users/leakid/following{/other_user}",
"gists_url": "https://api.github.com/users/leakid/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/leakid",
"id": 255794,
"login": "leakid",
"node_id": "MDEyOk9yZ2FuaXphdGlvbjI1NTc5NA==",
"organizations_url": "https://api.github.com/users/leakid/orgs",
"received_events_url": "https://api.github.com/users/leakid/received_events",
"repos_url": "https://api.github.com/users/leakid/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/leakid/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/leakid/subscriptions",
"type": "Organization",
"url": "https://api.github.com/users/leakid",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-06-02T10:08:43Z
|
2021-09-08T23:04:43Z
|
2015-06-02T10:09:22Z
|
NONE
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/255794?v=4",
"events_url": "https://api.github.com/users/leakid/events{/privacy}",
"followers_url": "https://api.github.com/users/leakid/followers",
"following_url": "https://api.github.com/users/leakid/following{/other_user}",
"gists_url": "https://api.github.com/users/leakid/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/leakid",
"id": 255794,
"login": "leakid",
"node_id": "MDEyOk9yZ2FuaXphdGlvbjI1NTc5NA==",
"organizations_url": "https://api.github.com/users/leakid/orgs",
"received_events_url": "https://api.github.com/users/leakid/received_events",
"repos_url": "https://api.github.com/users/leakid/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/leakid/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/leakid/subscriptions",
"type": "Organization",
"url": "https://api.github.com/users/leakid",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2626/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2626/timeline
| null |
completed
| null | null | false |
[
"wrong account\n"
] |
|
https://api.github.com/repos/psf/requests/issues/2625
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2625/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2625/comments
|
https://api.github.com/repos/psf/requests/issues/2625/events
|
https://github.com/psf/requests/issues/2625
| 83,790,226 |
MDU6SXNzdWU4Mzc5MDIyNg==
| 2,625 |
expose request start time
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/23570?v=4",
"events_url": "https://api.github.com/users/est/events{/privacy}",
"followers_url": "https://api.github.com/users/est/followers",
"following_url": "https://api.github.com/users/est/following{/other_user}",
"gists_url": "https://api.github.com/users/est/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/est",
"id": 23570,
"login": "est",
"node_id": "MDQ6VXNlcjIzNTcw",
"organizations_url": "https://api.github.com/users/est/orgs",
"received_events_url": "https://api.github.com/users/est/received_events",
"repos_url": "https://api.github.com/users/est/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/est/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/est/subscriptions",
"type": "User",
"url": "https://api.github.com/users/est",
"user_view_type": "public"
}
|
[
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
}
] |
closed
| true | null |
[] | null | 7 |
2015-06-02T02:06:39Z
|
2021-09-08T23:00:55Z
|
2015-06-15T03:59:05Z
|
NONE
|
resolved
|
When implementing time based throttle mechanism, the start of request time is quite useful, please consider expose it as instance property, so we don't need to wrap requests in a multiple `time.utctime()` calls. It's a waste of syscall and duplicated code.
https://github.com/kennethreitz/requests/blob/master/requests/sessions.py#L570
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2625/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2625/timeline
| null |
completed
| null | null | false |
[
"I don't think we're going to expose it. We weren't keen to expose the `elapsed` attribute in the first place. We're not going to add yet another attribute, especially one we've never had a request for before. `elapsed` was only necessary because the hooks provided by requests were severely trimmed in 1.0.\n",
"If no one comments in the next 6 days, I'm going to close this.\n",
"I am ok with closing this, as long as `elapsed` will be obsolete\n",
"## Why do you want a widely used feature to be removed? \n\nSent from my Android device with K-9 Mail. Please excuse my brevity.\n",
"@sigmavirus24 Pardon my poor English, but how could `elapsed` be widely used and you weren't keen to expose it?\n\nMy rationale is like this, since `elapsed` is widely used, and it involves a system call to get start request time, so it'd better to directly expose the start request time as a property directly, so other developers can make more use of this measure without wrapping yet another get current time system calls. As you can see people use `requests` often involve with time based constraints and there would be a ton duplicated code.\n",
"> how could elapsed be widely used and you weren't keen to expose it?\n\nIt wasn't widely used before we added it. We were hesitant to add the attribute in the first place but (like most things that are added to public APIs) people use it because it's there. It's widely used now and it's not something we're going to remove.\n\nThere's two things to consider though:\n1. Requests is in a feature freeze at the moment. That means no new additions to the API.\n2. You are the first person in several years to ask us to expose this feature. Without a large number of people needing this to be provided by requests, the default answer is \"No.\"\n\nThat said, you keep complaining about needing this causing you to make another system call. If you think system calls are inhibiting the performance of your application, I would strongly urge you to do real benchmarking to determine what is the actual cause of performance degradation. If you've already optimized every part of your application and have found that these system calls are causing performance problems that are noticeable, I think you have other problems to solve.\n",
"Now I feel stupid since me alone is complaining this.\n\nThis must be a bad idea. Sorry for this, I'll see myself out.\n"
] |
https://api.github.com/repos/psf/requests/issues/2624
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2624/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2624/comments
|
https://api.github.com/repos/psf/requests/issues/2624/events
|
https://github.com/psf/requests/issues/2624
| 83,783,239 |
MDU6SXNzdWU4Mzc4MzIzOQ==
| 2,624 |
Use keep-alive / streaming while processing
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/505939?v=4",
"events_url": "https://api.github.com/users/kvarga/events{/privacy}",
"followers_url": "https://api.github.com/users/kvarga/followers",
"following_url": "https://api.github.com/users/kvarga/following{/other_user}",
"gists_url": "https://api.github.com/users/kvarga/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kvarga",
"id": 505939,
"login": "kvarga",
"node_id": "MDQ6VXNlcjUwNTkzOQ==",
"organizations_url": "https://api.github.com/users/kvarga/orgs",
"received_events_url": "https://api.github.com/users/kvarga/received_events",
"repos_url": "https://api.github.com/users/kvarga/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kvarga/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kvarga/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kvarga",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2015-06-02T01:40:21Z
|
2021-09-08T23:04:44Z
|
2015-06-02T02:19:36Z
|
NONE
|
resolved
|
Is there a way to send intermittent responses to client to avoid timeout for long-running tasks (~2minutes) ?
If not, I guess I will have to do the following flow:
1. User requests a webpage
2. Check if that webpage is available in cache
3. If not, redirect them to a holding page that checks ~15 seconds if that request is ready
4. Load the response
Seems less than ideal, but gets the added benefit of showing some sort of progress indicator to the user.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/505939?v=4",
"events_url": "https://api.github.com/users/kvarga/events{/privacy}",
"followers_url": "https://api.github.com/users/kvarga/followers",
"following_url": "https://api.github.com/users/kvarga/following{/other_user}",
"gists_url": "https://api.github.com/users/kvarga/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kvarga",
"id": 505939,
"login": "kvarga",
"node_id": "MDQ6VXNlcjUwNTkzOQ==",
"organizations_url": "https://api.github.com/users/kvarga/orgs",
"received_events_url": "https://api.github.com/users/kvarga/received_events",
"repos_url": "https://api.github.com/users/kvarga/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kvarga/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kvarga/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kvarga",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2624/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2624/timeline
| null |
completed
| null | null | false |
[
"@kvarga sorry, are you using the requests library? You seem to not be using it at all unless I'm misunderstanding your bug.\n",
"Oops. I meant to post this to flask. \n",
"No worries! :8ball: says the flask maintainers will be more helpful.\n"
] |
https://api.github.com/repos/psf/requests/issues/2623
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2623/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2623/comments
|
https://api.github.com/repos/psf/requests/issues/2623/events
|
https://github.com/psf/requests/issues/2623
| 83,778,310 |
MDU6SXNzdWU4Mzc3ODMxMA==
| 2,623 |
why implement requests.util.timeout.Timeout() instead of bsd socket options?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/23570?v=4",
"events_url": "https://api.github.com/users/est/events{/privacy}",
"followers_url": "https://api.github.com/users/est/followers",
"following_url": "https://api.github.com/users/est/following{/other_user}",
"gists_url": "https://api.github.com/users/est/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/est",
"id": 23570,
"login": "est",
"node_id": "MDQ6VXNlcjIzNTcw",
"organizations_url": "https://api.github.com/users/est/orgs",
"received_events_url": "https://api.github.com/users/est/received_events",
"repos_url": "https://api.github.com/users/est/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/est/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/est/subscriptions",
"type": "User",
"url": "https://api.github.com/users/est",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2015-06-02T01:26:39Z
|
2021-09-08T23:04:42Z
|
2015-06-02T07:15:50Z
|
NONE
|
resolved
|
In python's socket module, `socket.timeout` could be used as connect timeout, also `setsockopt` can be used with `SO_RCVTIMEO` and `SO_SNDTIMEO`. It there a reason to implement our own `requests.util.timeout.Timeout` class instead?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2623/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2623/timeline
| null |
completed
| null | null | false |
[
"Are you looking at the right project? https://github.com/kennethreitz/requests/blob/master/requests/utils.py\n",
"More generally, the answer is yes. `Timeout` is not special: it's just a wrapper over the timeout functions available in the socket module. The reason it was written into urllib3 (which is where I think you meant to say) is that it is useful to have an abstraction that is at the same layer as urllib3. Generally, passing things from the `socket` module into `urllib3` should be considered an expert-level action and only taken rarely: timing out requests is good practice, and should be done often.\n",
"Ah yes, I meant this file\n\nhttps://github.com/kennethreitz/requests/blob/master/requests/packages/urllib3/util/timeout.py\n\nThanks for the explaination!\n"
] |
https://api.github.com/repos/psf/requests/issues/2622
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2622/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2622/comments
|
https://api.github.com/repos/psf/requests/issues/2622/events
|
https://github.com/psf/requests/issues/2622
| 83,689,331 |
MDU6SXNzdWU4MzY4OTMzMQ==
| 2,622 |
get fails for "http://www.merrickbank.com/"
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/12498397?v=4",
"events_url": "https://api.github.com/users/benreisner/events{/privacy}",
"followers_url": "https://api.github.com/users/benreisner/followers",
"following_url": "https://api.github.com/users/benreisner/following{/other_user}",
"gists_url": "https://api.github.com/users/benreisner/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/benreisner",
"id": 12498397,
"login": "benreisner",
"node_id": "MDQ6VXNlcjEyNDk4Mzk3",
"organizations_url": "https://api.github.com/users/benreisner/orgs",
"received_events_url": "https://api.github.com/users/benreisner/received_events",
"repos_url": "https://api.github.com/users/benreisner/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/benreisner/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/benreisner/subscriptions",
"type": "User",
"url": "https://api.github.com/users/benreisner",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 10 |
2015-06-01T20:55:20Z
|
2021-09-08T23:04:42Z
|
2015-06-01T21:38:44Z
|
NONE
|
resolved
|
I try requests.get("http://www.merrickbank.com/"), but it does not work. It takes minutes for it to just fail, freezing up quite a bit.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2622/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2622/timeline
| null |
completed
| null | null | false |
[
"Weirdly curl gets back a `Content-Length` header but requests gets `chunked`.\n",
"So if you announce compression it chunks.\n",
"So if they send chunked responses (when doing gzip) they send broken data. Especially:\n\n``` http\nX-Frame-Options: SAMEORIGIN\nSet-Cookie: mb-CookieP=; HttpOnly; \nSecure\nSet-Cookie: mb-CookieP=; HttpOnly; Secure\nTransfer-Encoding: chunked\n```\n\nThat is a newline there in the `Set-Cookie`-header which is simply invalid.\nWe then miss the chunked encoding and break.\nThis has to be fixed on their side.\nYou can work around it with\n\n``` py\nrequests.get(\"http://www.merrickbank.com/\", headers={'Accept-Encoding': None})\n```\n",
"@t-8ch has diagnosed this correctly. Sadly there isn't much we can do about this on our side beyond what has been described here.\n",
"That's a bit of a cop-out. Chrome, Firefox, and Internet Explorer (Internet Explorer, for God's sake) can all successfully fetch that page. This glitch in their webserver can be worked around. The requests lib ought to be a little more forgiving.\n",
"@mgdelmonte this isn't our fault. This is httplib's fault. Raise the bug there and eventually if it's ever fixed it'll trickle down to here.\n",
"@mgdelmonte That's extremely disingenuous, and I think you know that.\n\nChrome, Firefox, and Internet Explorer are browsers whose development is backed by the paid, full-time efforts of a team of developers. They own the entirety of their software stack, do not have backwards compatibility concerns with other libraries, and are beholden only to themselves for release schedules.\n\nRequests is a tool whose development is funded by zero people. Three core developers devote more than 40 cumulative hours a week to this project, _for free_, with ancillary and extremely important contributions from people like @t-8ch which total probably another 10 hours, also _for free_. We do not control our entire software stack: many of the tools we build on top are are in the python standard library, like `httplib`, `cookielib`, `ssl`, and more. The fact that this project exists _at all_ is entirely down to the goodwill of a series of developers whose names you will never know and who received exactly no compensation for their work other than, if they are extremely lucky, the thanks of someone else.\n\nAs @sigmavirus24 points out, the bug is in httplib, which we rely on to do our HTTP parsing. Even then, I wouldn't call it a bug: there is a very clear specification for HTTP headers which is being violated by the server in question. At some point we need to stop tolerating the mistakes of others and say that something is simply not HTTP. This is particularly true of [Merrick Bank](http://www.merrickbank.com), a presumably financial institution that actually _did_ pay someone to build their website.\n\nIf you would like to get this fixed, please file a bug against httplib. More than that, please submit a patch. The last time we had one of these bugs was in #1804. For that bug I actually did provide a fix for `httplib`, which was merged more than one year after it was proposed. For that reason, I do not have particularly high hopes for this being fixed any time soon.\n\n@mgdelmonte Please consider the way you act towards purely volunteer run projects. We are doing the best we can, but we need to pick our battles. If you'd like to pay one of us some money to address this bug, I'm sure we can come to some arrangement. Otherwise, we will pursue this in terms of the priorities of the requests project, and in those cases we promise nothing when the bug is upstream of us.\n",
"@Lukasa my sincere apologies, and I do appreciate the value of the requests lib. My point was more to mock Internet Explorer (which frankly surprises me if it handles anything less than perfectly clean data) than to deride your efforts.\n\nI'll file a bug report with httplib, which appears to be the source. It's hard to foresee someone breaking spec like Merrick has, but nevertheless it seems like an easy accommodation to make with no penalties elsewhere, to ignore a broken HTTP header line.\n",
"@mgdelmonte Sincerely, thankyou for the apology. =) Miscommunications on the Internet are easy, and I'm sure you meant no ill-will. Your apology was extremely graceful.\n\nWhen you file your httplib bug, please link it here. I'll make sure to keep an eye on it, and if I find time tomorrow I may even try to flesh out a patch. We'll see if this one merges quicker. ;)\n",
"@Lukasa no problem, we're all pulling in the same direction (usually). I submitted an issue for httplib here\n\nhttp://bugs.python.org/issue24363\n\nThis is my first time submitting an issue through that system so I was a little mystified and wasn't sure how to submit a patch, so just recommended my fix. I'm amazed there aren't more problems with readheaders() as it seems to completely ignore the requirement of a blank line to terminate the header. Yes, you shouldn't have malformed header lines, either; but certainly it's easier to skip them and accommodate the mistakes of others than to terminate parsing altogether, especially when the specification has a clear and (mostly) unambiguous terminator.\n\nAnyway, hopefully this clears it up for good. Famous last words, right?\n"
] |
https://api.github.com/repos/psf/requests/issues/2621
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2621/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2621/comments
|
https://api.github.com/repos/psf/requests/issues/2621/events
|
https://github.com/psf/requests/issues/2621
| 83,582,676 |
MDU6SXNzdWU4MzU4MjY3Ng==
| 2,621 |
TLS hostname validation logic does not support subjectAltName with IP records
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3266662?v=4",
"events_url": "https://api.github.com/users/itamarst/events{/privacy}",
"followers_url": "https://api.github.com/users/itamarst/followers",
"following_url": "https://api.github.com/users/itamarst/following{/other_user}",
"gists_url": "https://api.github.com/users/itamarst/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/itamarst",
"id": 3266662,
"login": "itamarst",
"node_id": "MDQ6VXNlcjMyNjY2NjI=",
"organizations_url": "https://api.github.com/users/itamarst/orgs",
"received_events_url": "https://api.github.com/users/itamarst/received_events",
"repos_url": "https://api.github.com/users/itamarst/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/itamarst/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/itamarst/subscriptions",
"type": "User",
"url": "https://api.github.com/users/itamarst",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 25 |
2015-06-01T16:13:37Z
|
2021-09-08T21:00:49Z
|
2015-11-05T17:54:19Z
|
NONE
|
resolved
|
If I am running a custom certificate authority I might want to generate a TLS certificate that encodes its `subjectAltName` using an IP address (`iPAddress` in https://tools.ietf.org/html/rfc5280#section-4.2.1.6). this is useful when I do not have DNS records for servers in my application but I still want to validate identity.
Unfortunately, the hostname validation logic `requests` uses does not validate these records. It only validates DNS records within `subjectAltName`.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2621/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2621/timeline
| null |
completed
| null | null | false |
[
"You are entirely correct. This likely applies a bit more broadly than requests: we pulled this algorithm out of the standard library, which means it is likely affected. Similarly, I checked `service_identity`, and I believe it may also not handle this appropriately.\n\nCan I get some input from @reaperhulk, @hynek, and @tiran about whether that assessment is right?\n",
"Please note that I believe if you set the IP as a `dNSName` this will work correctly. This is quite a common practice, plenty of browsers have (and have had) similar limitations, so many `iPAddress` fields are duplicated in `dNSName` fields. That is technically poor practice, but it's a common work-around.\n",
"1. We filed issue with service_identity too (https://github.com/pyca/service_identity/issues/12).\n2. We can't use the workaround of putting IP in `dNSName` because that blows up `service_identity` :wink:: https://github.com/pyca/service_identity/blob/master/service_identity/_common.py#L156\n",
"Yeah IP in dNSName is an (unfortunately) common thing. service_identity definitely needs to support iPAddress but probably will need to loosen its restrictions on dNSName as well...\n",
"Ok then, so I think the first priority here is working out whether or not this is a problem in the stdlib as well. @tiran?\n",
"AFAIK an IP in dNSName is invalid pre RFC? IIRC it’s okay in commonName.\n",
"It is definitely invalid. Unfortunately, browsers have previously had problems where they allowed IP addresses in dNSName, but didn't use the iPAddress field, so you could expect to see certificates of that form.\n",
"Has anybody seen a cert with an IP address in the wild? I've never seen one that is signed by a public CA.\n\nYes, the stdlib doesn's support ipAddress. It only validates dNSName. It also uses server_hostname for two jobs: SNI and host name validation. That is going to make it more tricky...\n",
"Oooof. Thanks @tiran. For the moment I'll leave the stdlib in your hands, I think we should update the algorithm we've back ported to add this support. I'll take a look at this today and see if I can extend it.\n",
"I just checked how OpenSSL 1.0.2 has implemented the checks:\n- OpenSSL supports multiple host names (X509_VERIFY_PARAM_add1_host() and X509_VERIFY_PARAM_set1_host()). One of the host in the host list must match. The matching host name can be accessed with X509_VERIFY_PARAM_get0_peername()\n- OpenSSL has a couple of extra flags like X509_CHECK_FLAG_ALWAYS_CHECK_SUBJECT and X509_CHECK_FLAG_NO_WILDCARDS\n- For IP address and S/MIME email address only one address of each is supported\n- If both IP address and hosts are set, then BOTH are validated.\n- If no host and no IP address is set, then the check passes.\n",
"As for s_i, adding non-RFC conform behavior that weakens the security is out of question unless I’ll get overwhelming proofs that it is a problem in real life.\n\nIf someone wants to help with pyca/service_identity#12 be my guest. :)\n",
"Oh, this is fun: we actually can't validate the iPAddress when using the stdlib `ssl` module because it doesn't return iPAddress fields from the SAN extension. That's extremely unfortunate. We can still add support for it from pyOpenSSL though, and require that people use pyOpenSSL when they want to do this validation.\n",
"Mozilla's NSS library doesn't support IP addresses in dNSName either: https://dxr.mozilla.org/mozilla-central/source/security/nss/lib/certdb/certdb.c#1427\n",
"FYI 1: http://bugs.python.org/msg244665\n\nFYI 2: https://tools.ietf.org/html/rfc3546#page-9\nLiteral IPv4 and IPv6 addresses are not permitted in \"HostName\".\n",
"I'd be interested in seeing what a browser developer thinks is the \"right thing\" in this case since the reality of what is required for validation is sometimes at odds with RFCs. Unfortunately I don't know any on GitHub so I'm not sure who to CC ;)\n",
"I could try to get in contact with NSS developers at Red Hat.\n\nAnd there are Ryan Sleevi and Adam Langley from Google and the Chromium project.\n",
"@tiran the use case is only for private CAs. Can't imagine a public CA would sign an IP, yes.\n",
"@Lukasa do you think cURL handles this? Should we give Daniel a ping?\n",
"Why not. @bagder?\n",
"Ok, here's a response from the \"there's no such thing as a simple answer\" department:\n1. I don't think I've ever actually seen such a cert used\n2. curl supports roughly speaking a bazillion TLS backends and most of them feature their own name checking functions so then we use those and then we of course rely on them doing this check correctly.\n3. OpenSSL is the by far mostly used TLS backend with curl and for this we of course have written our own verifying code and yes, we do check 'iPAddress' fields[1]. But please consider my point (1) again for this.\n\n[1] = https://github.com/bagder/curl/blob/master/lib/vtls/openssl.c#L1211\n",
"@bagder thanks so much. :cake:\n\nOk, with Daniel's point 1 in mind, I still think we should aim to do this _if possible_. I don't believe we need to do it on both of our SSL backends (stdlib and PyOpenSSL), but if we can make it possible in our PyOpenSSL backend I think we should. That will allow users who desperately need this function to achieve it, but we won't bend over backwards to make this available to all our users.\n",
"It's worth noting that cURL's implementation doesn't do anything particularly clever on IP address checking, which bodes well for us. I do think we need to normalise the IP address though, and that may be somewhat painful (the stdlib doesn't provide any function that does that I think, though I'll check).\n",
"## If by normalize you're referring to RFC 3986's definition of normalization, we can steal code from rfc3986\n\nSent from my Android device with K-9 Mail. Please excuse my brevity.\n",
"Ok, having made a tweak to urllib3's `match_hostname` function I've now discovered that we don't use it if there is a match_hostname function available in the standard library. Which is unfortunate.\n",
"Actually, I think this just means that until the standard library does this, we can't. Closing until the Python stdlib is capable of doing something with iPAddress fields.\n"
] |
https://api.github.com/repos/psf/requests/issues/2620
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2620/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2620/comments
|
https://api.github.com/repos/psf/requests/issues/2620/events
|
https://github.com/psf/requests/issues/2620
| 83,513,544 |
MDU6SXNzdWU4MzUxMzU0NA==
| 2,620 |
Connect Error or Timeout Error
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3735327?v=4",
"events_url": "https://api.github.com/users/jongiddy/events{/privacy}",
"followers_url": "https://api.github.com/users/jongiddy/followers",
"following_url": "https://api.github.com/users/jongiddy/following{/other_user}",
"gists_url": "https://api.github.com/users/jongiddy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jongiddy",
"id": 3735327,
"login": "jongiddy",
"node_id": "MDQ6VXNlcjM3MzUzMjc=",
"organizations_url": "https://api.github.com/users/jongiddy/orgs",
"received_events_url": "https://api.github.com/users/jongiddy/received_events",
"repos_url": "https://api.github.com/users/jongiddy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jongiddy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jongiddy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jongiddy",
"user_view_type": "public"
}
|
[
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
},
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
}
] |
closed
| true | null |
[] |
{
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
}
| 6 |
2015-06-01T14:00:42Z
|
2021-09-08T23:04:42Z
|
2015-06-02T20:53:50Z
|
NONE
|
resolved
|
At https://github.com/kennethreitz/requests/blob/8b5e457b756b2ab4c02473f7a42c2e0201ecc7e9/requests/models.py#L664 the urllib3 `ReadTimeoutError` gets mapped to a `requests.exceptions.ConnectionError`. It seems like the `requests.exceptions.ReadTimeout` would be a more obvious exception.
Is this just an oversight, or is there a reason for keeping it as `ConnectionError`?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3735327?v=4",
"events_url": "https://api.github.com/users/jongiddy/events{/privacy}",
"followers_url": "https://api.github.com/users/jongiddy/followers",
"following_url": "https://api.github.com/users/jongiddy/following{/other_user}",
"gists_url": "https://api.github.com/users/jongiddy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jongiddy",
"id": 3735327,
"login": "jongiddy",
"node_id": "MDQ6VXNlcjM3MzUzMjc=",
"organizations_url": "https://api.github.com/users/jongiddy/orgs",
"received_events_url": "https://api.github.com/users/jongiddy/received_events",
"repos_url": "https://api.github.com/users/jongiddy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jongiddy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jongiddy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jongiddy",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2620/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2620/timeline
| null |
completed
| null | null | false |
[
"Good spot! I think this is an oversight.\n\nUnfortunately, changing the exception type is a backward incompatible change, because `ReadTimeoutError` does not inherit from `ConnectionError`. I think we should do it, but we can't do it until 3.0.0.\n",
"Sorry, just noticed this is a duplicate of https://github.com/kennethreitz/requests/issues/2392\n",
"Ah thanks @jongiddy. It's been long enough (over a year, wow) that I completely forgot that was open. Would you mind if we closed this since it's a duplicate?\n",
"No problem. I would have closed it myself, but wasn't sure how that affects the labels and milestone info.\n",
"It doesn't affect it. You're still welcome to do so yourself. I'll make a reminder to close it next week if it's still open\n",
"Closing as duplicate.\n"
] |
https://api.github.com/repos/psf/requests/issues/2619
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2619/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2619/comments
|
https://api.github.com/repos/psf/requests/issues/2619/events
|
https://github.com/psf/requests/issues/2619
| 83,418,208 |
MDU6SXNzdWU4MzQxODIwOA==
| 2,619 |
HTML PUT and GET
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/11629690?v=4",
"events_url": "https://api.github.com/users/RubenvWyk/events{/privacy}",
"followers_url": "https://api.github.com/users/RubenvWyk/followers",
"following_url": "https://api.github.com/users/RubenvWyk/following{/other_user}",
"gists_url": "https://api.github.com/users/RubenvWyk/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/RubenvWyk",
"id": 11629690,
"login": "RubenvWyk",
"node_id": "MDQ6VXNlcjExNjI5Njkw",
"organizations_url": "https://api.github.com/users/RubenvWyk/orgs",
"received_events_url": "https://api.github.com/users/RubenvWyk/received_events",
"repos_url": "https://api.github.com/users/RubenvWyk/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/RubenvWyk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RubenvWyk/subscriptions",
"type": "User",
"url": "https://api.github.com/users/RubenvWyk",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2015-06-01T10:07:20Z
|
2021-09-08T23:04:44Z
|
2015-06-01T10:41:44Z
|
NONE
|
resolved
|
Hi there,
I am new to the whole thing :) read n00b 101 hehe
Currently I am requesting sending a requests.get() to a html page. If I now print(r.text) the output shows the whole page.
The page has query section in which the request range can be set:
1. Is there a way for me to send the range required?
Then the data gets displayed:
1. Is there a way for me to only return this data?
At the moment, I can see the data in the text that is returned:
<tbody>
```
<tr class="even">
<td>
<input type="checkbox" class="noborder"
name="paths:list" id="cb_1566205447"
value="1566205447"
title="Select Channel 8"
alt="Select Channel 8" />
</td>
<td style="text-align:left">May 31, 2015 11:30 am</td>
<td style="text-align:right">2.28839</td>
</tr>
```
And here is the code returned for the range request:
</select>
</span>
```
<span>:</span>
<span>
<select name="end_query_minute"
id="date_select_form_end_query_None_minute"
size="1"
onchange="update_date_field('date_select_form_end_query_None','date_select_form_end_query_None_year','date_select_form_end_query_None_month','date_select_form_end_query_None_day','date_select_form_end_query_None_hour','date_select_form_end_query_None_minute','date_select_form_end_query_None_ampm')">
<option value="00">--</option>
<option value="00">00</option>
<option value="05">05</option>
<option value="10">10</option>
<option value="15">15</option>
<option value="20">20</option>
<option value="25">25</option>
<option value="30">30</option>
<option value="35 selected="selected"">35</option>
<option value="40">40</option>
<option value="45">45</option>
<option value="50">50</option>
<option value="55">55</option>
</select>
```
I am guessing that I can set the range using some code that will set the "end_query_minute" (and all other request range variables) and then query the page right after that to return the appropriate range of data. I can then extract the data using another method from the text returned... but I cannot find any relevant documentation on hoe Requests handles data/returns data/etc...
Any help would be highly appreciated.
A big thanks for this development, it has thus far made my life much easier :)
Regards,
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2619/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2619/timeline
| null |
completed
| null | null | false |
[
"So, requests doesn't know anything about HTML. This means there's no programmatic code you can use to simply interact with that page by searching through the HTML.\n\nHowever, you can form the same requests that your browser would do. If you hit F12 in your browser it should bring up a developer console that you can use to see all the HTTP requests your browser makes. If you then fill out the forms and submit them, you can see the way the data is structured and replicate that in requests.\n\nIf you want to follow this up, though, I recommend you ask a question on [StackOverflow](http://stackoverflow.com/). That is a community focused on providing answers to questions like this one, while this bug tracker is mostly to track actual bugs in requests.\n",
"Kief,\n\nSorry for the post :) Thanks for the advice\n",
"Hi Lukasa,\n\nEven though this isn't the place, I decided to post the answer to my question, in case someone else comes a looking:\n\npayload = {'start_query': '2015-05-30 10:30:00 GMT+2', 'end_query': '2015-05-30 15:30:00 GMT+2'}\n\nr = s.get(url, params=payload)\n\nRegards,\n",
"@RubenvWyk Thanks for the follow-up! :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/2618
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2618/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2618/comments
|
https://api.github.com/repos/psf/requests/issues/2618/events
|
https://github.com/psf/requests/issues/2618
| 83,270,944 |
MDU6SXNzdWU4MzI3MDk0NA==
| 2,618 |
get url redirect hangs in requests
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3759816?v=4",
"events_url": "https://api.github.com/users/gengjiawen/events{/privacy}",
"followers_url": "https://api.github.com/users/gengjiawen/followers",
"following_url": "https://api.github.com/users/gengjiawen/following{/other_user}",
"gists_url": "https://api.github.com/users/gengjiawen/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gengjiawen",
"id": 3759816,
"login": "gengjiawen",
"node_id": "MDQ6VXNlcjM3NTk4MTY=",
"organizations_url": "https://api.github.com/users/gengjiawen/orgs",
"received_events_url": "https://api.github.com/users/gengjiawen/received_events",
"repos_url": "https://api.github.com/users/gengjiawen/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gengjiawen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gengjiawen/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gengjiawen",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2015-06-01T02:23:52Z
|
2021-09-08T23:04:44Z
|
2015-06-02T01:08:05Z
|
NONE
|
resolved
|
I am trying to handle url redirect using requests,but it hangs.The original python lib works as expected.Below is the code(**Python 3**).
``` python
import urllib.request
import requests
url = "http://go.microsoft.com/fwlink/p/?LinkId=522148"
final_url = urllib.request.urlopen(url)
print(final_url.geturl())
r = requests.get(url)
print(r.url)
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3759816?v=4",
"events_url": "https://api.github.com/users/gengjiawen/events{/privacy}",
"followers_url": "https://api.github.com/users/gengjiawen/followers",
"following_url": "https://api.github.com/users/gengjiawen/following{/other_user}",
"gists_url": "https://api.github.com/users/gengjiawen/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gengjiawen",
"id": 3759816,
"login": "gengjiawen",
"node_id": "MDQ6VXNlcjM3NTk4MTY=",
"organizations_url": "https://api.github.com/users/gengjiawen/orgs",
"received_events_url": "https://api.github.com/users/gengjiawen/received_events",
"repos_url": "https://api.github.com/users/gengjiawen/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gengjiawen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gengjiawen/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gengjiawen",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2618/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2618/timeline
| null |
completed
| null | null | false |
[
"The code below also works fine:\n\n``` python\nr = requests.head('http://github.com', allow_redirects=True)\nprint(r.url)\n```\n\nshould I use **requests.head** over **requests.get** when handling url redirect?\n",
"@gengjiawen This URL redirects to a 4GB big ISO image. So the download takes a little bit.\nYou probably don't want to read this into memory anyways.\nTry `requests.get(url, stream=True)` and then iterate over the content.\n",
"@t-8ch Thanks, your solution also works.\n"
] |
https://api.github.com/repos/psf/requests/issues/2617
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2617/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2617/comments
|
https://api.github.com/repos/psf/requests/issues/2617/events
|
https://github.com/psf/requests/pull/2617
| 82,033,090 |
MDExOlB1bGxSZXF1ZXN0MzY0MjkyODM=
| 2,617 |
Move native string conversion to Request
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[] |
closed
| true |
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
[
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
] |
{
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
}
| 11 |
2015-05-28T17:09:51Z
|
2021-09-08T07:00:50Z
|
2015-07-18T15:43:50Z
|
MEMBER
|
resolved
|
This fixes #2613. I believe that this technically constitutes a backward-incompatible API change, so I've proposed this against 3.0.0. Let me know if you disagree @sigmavirus24 (the other option is really that this is a bugfix), and I'll propose against master.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2617/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2617/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2617.diff",
"html_url": "https://github.com/psf/requests/pull/2617",
"merged_at": "2015-07-18T15:43:50Z",
"patch_url": "https://github.com/psf/requests/pull/2617.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2617"
}
| true |
[
"hehehe The tests are trying to pass `None` as a method. We should either change that default or fix the tests.\n",
"Grr.\n",
"Stupid question: Why default to an empty string if method is None? I'm not entirely comfortable with that\n",
"Yeah, it was definitely a bit of a blind shot. A better idea might just be to have no default for `method`. I can't think of anything else non-surprising.\n",
"@Lukasa thoughts on the last commit that I pushed?\n",
"Note that if we want to present a better error to the user, we can catch the error raised by `to_native_string` and raise a new one.\n",
"If we're going this route, we should remove the default argument from `method`, as it cannot safely be used any longer.\n",
"I feel like using an empty string as a default value is a footgun. That said, I don't feel strongly about whether method should be a required argument. Currently, in our own code we do, one might do\n\n``` py\nreq = requests.Request()\nself.update_request(req)\nprepped = req.prepare()\n```\n\nI think this is something valid for someone to do. That said, perhaps `req.prepare` could raise a `ValueError`, `TypeError`, or something more descriptive that we include in `requests.exceptions`? That stops the user from shooting themselves in the foot and then we just move the `to_native_string` into `Request.prepare` or into `PreparedRequest.prepare_method`. In fact, I think that `PreparedRequest.prepare_method` should actually be where we raise the exception. Currently, we do nothing if `method` is `None` and I'm pretty sure that's bad.\n",
"I can see the advantage in that approach, I'd be ok with that.\n",
"@Lukasa updated with that approach.\n",
"ping\n"
] |
https://api.github.com/repos/psf/requests/issues/2616
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2616/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2616/comments
|
https://api.github.com/repos/psf/requests/issues/2616/events
|
https://github.com/psf/requests/issues/2616
| 81,839,555 |
MDU6SXNzdWU4MTgzOTU1NQ==
| 2,616 |
requests.exceptions.SSLError: EOF occurred in violation of protocol (_ssl.c:600)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1203138?v=4",
"events_url": "https://api.github.com/users/kristjanr/events{/privacy}",
"followers_url": "https://api.github.com/users/kristjanr/followers",
"following_url": "https://api.github.com/users/kristjanr/following{/other_user}",
"gists_url": "https://api.github.com/users/kristjanr/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kristjanr",
"id": 1203138,
"login": "kristjanr",
"node_id": "MDQ6VXNlcjEyMDMxMzg=",
"organizations_url": "https://api.github.com/users/kristjanr/orgs",
"received_events_url": "https://api.github.com/users/kristjanr/received_events",
"repos_url": "https://api.github.com/users/kristjanr/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kristjanr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kristjanr/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kristjanr",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 21 |
2015-05-28T09:09:15Z
|
2021-09-08T05:00:48Z
|
2015-05-31T12:51:52Z
|
NONE
|
resolved
|
```
r = requests.get('https://www.digitist.com', verify=False)
```
```
Traceback (most recent call last):
File "<input>", line 1, in <module>
File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/requests/api.py", line 69, in get
return request('get', url, params=params, **kwargs)
File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/requests/api.py", line 50, in request
response = session.request(method=method, url=url, **kwargs)
File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/requests/sessions.py", line 465, in request
resp = self.send(prep, **send_kwargs)
File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/requests/sessions.py", line 573, in send
r = adapter.send(request, **kwargs)
File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/requests/adapters.py", line 431, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: EOF occurred in violation of protocol (_ssl.c:600)
```
I am using Python 3.4 on OSX Yosemite
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2616/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2616/timeline
| null |
completed
| null | null | false |
[
"Python 3.4, OS X Yosemite, Requests 2.7.0: I cannot reproduce this bug. =) Can you consistently hit it? What requests version are you using?\n",
"Also, what version of openssl and do you have `pyOpenSSL` installed?\n",
"requests 2.7.0\nOpenSSL 1.0.2 22 Jan 2015\nI did not have pyOpenSSL installed.\n\nI installed the latest version of pyOpenSSL 0.15.1 and ran the same request again.\nStill the same result.\n",
"Are you behind a proxy?\n",
"No, I am not behind a proxy.\n",
"I consistently get this problem. By now, I have tried with 3 different networks. \n\nAs soon as you are sure that this problem is not relative to requests, we can drop this :) because I only have this problem on my dev machine. Our production environment is Ubuntu and the request to the same url works fine there.\n\nBut until then, I am more than happy to give all the information you need for debugging.\n",
"The OpenSSL version number you gave us: how did you obtain it?\n",
"I typed in \"openssl version\" in the terminal:\n\n```\nKristjans-MBP:leech kristjan$ openssl version\nOpenSSL 1.0.2 22 Jan 2015\n```\n\nAnd for the one in Python:\n\n```\n>>> import OpenSSL\n>>> OpenSSL.__version__\n'0.15.1'\n```\n",
"Sorry, can you do\n\n``` python\nimport ssl\nprint ssl.OPENSSL_VERSION\n```\n",
"```\n>>> import ssl\n>>> ssl.OPENSSL_VERSION\n'OpenSSL 0.9.8zd 8 Jan 2015'\n```\n",
"Awesome, so you're using a very old OpenSSL version. How did you install Python 3?\n",
"I used Mac OS X 64-bit/32-bit installer from here https://www.python.org/downloads/release/python-340/\n",
"Weird, I thought that bundled a newer OpenSSL. I recommend installing it using [Homebrew](http://brew.sh/), which will link against a newer OpenSSL.\n",
"What about macports? I use this as my package manager.\n\nOn 18:54, Fri, May 29, 2015 Cory Benfield [email protected] wrote:\n\n> Weird, I thought that bundled a newer OpenSSL. I recommend installing it\n> using Homebrew http://brew.sh/, which will link against a newer OpenSSL.\n> \n> —\n> Reply to this email directly or view it on GitHub\n> https://github.com/kennethreitz/requests/issues/2616#issuecomment-106855278\n> .\n",
"I don't know about macports: you'll want to check with them whether they compile against the system OpenSSL or against one they provide.\n",
"If somebody still encounters this issue on their OS X stack I'll strongly recommend reinstalling Python 3 from https://www.python.org/downloads/ rather than homebrew - I've faced exactly the same thing and this was a proper solution for me :smile: \n",
"@mieciu thanks for the input. That said, my recommendation is to use homebrew. :wink: \n",
"EOF occurred in violation of protocol (_ssl.c:590) i am getting this error. \ndo this\nimport requests\nsess = requests.Session()\nadapter = requests.adapters.HTTPAdapter(max_retries = 1000)\nsess.mount('http://', adapter)\n\nand do sess.post() but still got the same error. could you guys help me it that???\n",
"@biplab-dholey This error can occur for a number of reasons. The retries count is unrelated. This error results from your TLS configuration, and without more information it's very difficult for us to help.\n",
"I hit this error and I finally find I was accessing a none HTTPS service with a HTTPS protocol.",
"`SSLEOFError` occurred when getting `www.google.com` using proxies.\r\n```python3\r\ndefault_socket = socket.socket\r\nsocks.set_default_proxy(socks.SOCKS5, SOCKS5_PROXY_HOST, SOCKS5_PROXY_PORT)\r\nsocket.socket = socks.socksocket\r\nimport requests\r\nhtml_source = requests.get(url, headers={\"User-Agent\": \"Mozilla/5.001 (windows; U; NT4.0; en-US; rv:1.0) Gecko/25250101\"}).text\r\n```\r\n```\r\nTraceback (most recent call last):\r\n File \"/usr/lib/python3/dist-packages/urllib3/connectionpool.py\", line 560, in urlopen\r\n body=body, headers=headers)\r\n File \"/usr/lib/python3/dist-packages/urllib3/connectionpool.py\", line 346, in _make_request\r\n self._validate_conn(conn)\r\n File \"/usr/lib/python3/dist-packages/urllib3/connectionpool.py\", line 787, in _validate_conn\r\n conn.connect()\r\n File \"/usr/lib/python3/dist-packages/urllib3/connection.py\", line 252, in connect\r\n ssl_version=resolved_ssl_version)\r\n File \"/usr/lib/python3/dist-packages/urllib3/util/ssl_.py\", line 305, in ssl_wrap_socket\r\n return context.wrap_socket(sock, server_hostname=server_hostname)\r\n File \"/usr/lib/python3.5/ssl.py\", line 377, in wrap_socket\r\n _context=self)\r\n File \"/usr/lib/python3.5/ssl.py\", line 752, in __init__\r\n self.do_handshake()\r\n File \"/usr/lib/python3.5/ssl.py\", line 988, in do_handshake\r\n self._sslobj.do_handshake()\r\n File \"/usr/lib/python3.5/ssl.py\", line 633, in do_handshake\r\n self._sslobj.do_handshake()\r\nssl.SSLEOFError: EOF occurred in violation of protocol (_ssl.c:645)\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n File \"/usr/lib/python3/dist-packages/requests/adapters.py\", line 376, in send\r\n timeout=timeout\r\n File \"/usr/lib/python3/dist-packages/urllib3/connectionpool.py\", line 589, in urlopen\r\n raise SSLError(e)\r\nrequests.packages.urllib3.exceptions.SSLError: EOF occurred in violation of protocol (_ssl.c:645)\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n File \"request.py\", line 19, in <module>\r\n html_source = requests.get(url, headers={\"User-Agent\": \"Mozilla/5.001 (windows; U; NT4.0; en-US; rv:1.0) Gecko/25250101\"}).text\r\n File \"/usr/lib/python3/dist-packages/requests/api.py\", line 67, in get\r\n return request('get', url, params=params, **kwargs)\r\n File \"/usr/lib/python3/dist-packages/requests/api.py\", line 53, in request\r\n return session.request(method=method, url=url, **kwargs)\r\n File \"/usr/lib/python3/dist-packages/requests/sessions.py\", line 468, in request\r\n resp = self.send(prep, **send_kwargs)\r\n File \"/usr/lib/python3/dist-packages/requests/sessions.py\", line 576, in send\r\n r = adapter.send(request, **kwargs)\r\n File \"/usr/lib/python3/dist-packages/requests/adapters.py\", line 447, in send\r\n raise SSLError(e, request=request)\r\nrequests.exceptions.SSLError: EOF occurred in violation of protocol (_ssl.c:645)\r\n```\r\nthe environment of my computer\r\n```\r\nUbuntu 16.04\r\npython3.5.2\r\n>>> import ssl\r\n>>> ssl.OPENSSL_VERSION\r\n'OpenSSL 1.0.2g 1 Mar 2016'\r\n>>> import requests\r\n>>> requests.__version__\r\n'2.9.1'\r\n```\r\n\r\nBUT, this code works well when getting `https://www.facebook.com/`"
] |
https://api.github.com/repos/psf/requests/issues/2615
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2615/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2615/comments
|
https://api.github.com/repos/psf/requests/issues/2615/events
|
https://github.com/psf/requests/pull/2615
| 80,957,978 |
MDExOlB1bGxSZXF1ZXN0MzYyMDExMTM=
| 2,615 |
Docs: Add more section labels for referencing
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3237256?v=4",
"events_url": "https://api.github.com/users/awiddersheim/events{/privacy}",
"followers_url": "https://api.github.com/users/awiddersheim/followers",
"following_url": "https://api.github.com/users/awiddersheim/following{/other_user}",
"gists_url": "https://api.github.com/users/awiddersheim/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/awiddersheim",
"id": 3237256,
"login": "awiddersheim",
"node_id": "MDQ6VXNlcjMyMzcyNTY=",
"organizations_url": "https://api.github.com/users/awiddersheim/orgs",
"received_events_url": "https://api.github.com/users/awiddersheim/received_events",
"repos_url": "https://api.github.com/users/awiddersheim/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/awiddersheim/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/awiddersheim/subscriptions",
"type": "User",
"url": "https://api.github.com/users/awiddersheim",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2015-05-26T13:17:17Z
|
2021-09-08T07:00:56Z
|
2015-05-26T14:12:33Z
|
CONTRIBUTOR
|
resolved
|
Allows for sections to be linked from other projects using Intersphinx.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2615/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2615/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2615.diff",
"html_url": "https://github.com/psf/requests/pull/2615",
"merged_at": "2015-05-26T14:12:33Z",
"patch_url": "https://github.com/psf/requests/pull/2615.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2615"
}
| true |
[
"No objection from me: @sigmavirus24?\n",
":+1: \n",
"Thanks @awiddersheim! :sparkles: :cake: :sparkles: \n"
] |
https://api.github.com/repos/psf/requests/issues/2614
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2614/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2614/comments
|
https://api.github.com/repos/psf/requests/issues/2614/events
|
https://github.com/psf/requests/pull/2614
| 80,668,713 |
MDExOlB1bGxSZXF1ZXN0MzYxNTc5MjE=
| 2,614 |
fix unittest typo
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/739280?v=4",
"events_url": "https://api.github.com/users/colindickson/events{/privacy}",
"followers_url": "https://api.github.com/users/colindickson/followers",
"following_url": "https://api.github.com/users/colindickson/following{/other_user}",
"gists_url": "https://api.github.com/users/colindickson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/colindickson",
"id": 739280,
"login": "colindickson",
"node_id": "MDQ6VXNlcjczOTI4MA==",
"organizations_url": "https://api.github.com/users/colindickson/orgs",
"received_events_url": "https://api.github.com/users/colindickson/received_events",
"repos_url": "https://api.github.com/users/colindickson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/colindickson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/colindickson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/colindickson",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-05-25T21:10:37Z
|
2021-09-08T07:00:56Z
|
2015-05-26T19:56:18Z
|
CONTRIBUTOR
|
resolved
|
IDE auto-complete error.
edit: edited to be a bit more pythonic
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2614/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2614/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2614.diff",
"html_url": "https://github.com/psf/requests/pull/2614",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2614.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2614"
}
| true |
[
"@colindickson Thanks for this! Rather than merge two identically named commits and a merge commit I rebased them down into fd31453aa25f80f04e1ce36de9abff0460bd136a, and merged it in 8b5e457b756b2ab4c02473f7a42c2e0201ecc7e9.\n\nThanks again! :cake: :sparkles:\n"
] |
https://api.github.com/repos/psf/requests/issues/2613
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2613/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2613/comments
|
https://api.github.com/repos/psf/requests/issues/2613/events
|
https://github.com/psf/requests/issues/2613
| 80,666,973 |
MDU6SXNzdWU4MDY2Njk3Mw==
| 2,613 |
Prepared requests containing binary files will not send when unicode_literals is imported
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/48100?v=4",
"events_url": "https://api.github.com/users/bboe/events{/privacy}",
"followers_url": "https://api.github.com/users/bboe/followers",
"following_url": "https://api.github.com/users/bboe/following{/other_user}",
"gists_url": "https://api.github.com/users/bboe/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bboe",
"id": 48100,
"login": "bboe",
"node_id": "MDQ6VXNlcjQ4MTAw",
"organizations_url": "https://api.github.com/users/bboe/orgs",
"received_events_url": "https://api.github.com/users/bboe/received_events",
"repos_url": "https://api.github.com/users/bboe/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bboe/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bboe/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bboe",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 9 |
2015-05-25T21:02:58Z
|
2021-09-08T22:00:54Z
|
2015-08-31T09:33:34Z
|
CONTRIBUTOR
|
resolved
|
``` python
#!/usr/bin/env python
from __future__ import unicode_literals
import requests
import sys
def main():
request = requests.Request(method='PUT', url='https://httpbin.org/put')
with open(sys.argv[1], 'rb') as fp:
request.files = {'hello': fp}
prepared = request.prepare()
requests.Session().send(prepared)
if __name__ == '__main__':
sys.exit(main())
```
The above program works perfectly in python3, and in python2 when `unicode_literals` is not imported. If the request isn't prepared it works without a problem unfortunately, I require both prepared requests and `unicode_literals` in my project.
The exception raised is:
``````
Traceback (most recent call last):
File "./test.py", line 15, in <module>
sys.exit(main())
File "./test.py", line 12, in main
requests.Session().send(prepared)
File "/Users/bboe/.venv/p27/lib/python2.7/site-packages/requests-2.7.0-py2.7.egg/requests/sessions.py", line 573, in send
r = adapter.send(request, **kwargs)
File "/Users/bboe/.venv/p27/lib/python2.7/site-packages/requests-2.7.0-py2.7.egg/requests/adapters.py", line 370, in send
timeout=timeout
File "/Users/bboe/.venv/p27/lib/python2.7/site-packages/requests-2.7.0-py2.7.egg/requests/packages/urllib3/connectionpool.py", line 544, in urlopen
body=body, headers=headers)
File "/Users/bboe/.venv/p27/lib/python2.7/site-packages/requests-2.7.0-py2.7.egg/requests/packages/urllib3/connectionpool.py", line 349, in _make_request
conn.request(method, url, **httplib_request_kw)
File "/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 1001, in request
self._send_request(method, url, body, headers)
File "/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 1035, in _send_request
self.endheaders(body)
File "/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 997, in endheaders
self._send_output(message_body)
File "/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 848, in _send_output
msg += message_body
UnicodeDecodeError: 'ascii' codec can't decode byte 0xff in position 109: ordinal not in range(128)```
``````
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2613/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2613/timeline
| null |
completed
| null | null | false |
[
"Unfortunately this is a bit of a limitation imposed on us by httplib. As you can see, the place where unicode and bytes are concatenated together is actually deep inside httplib. I'm afraid you'll have to pass bytestrings to requests.\n",
"Can you explain why it works fine when the request isn't prepared? That seems inconsistent.\n",
"Because the higher level code coerces your strings to the platform-native string type (bytes on Python 2, unicode on Python 3). One of the problems when you step this 'more control' abstraction is that we stop doing some of the helpful things we do at the higher abstraction levels.\n\nWe have a `to_native_string` function that you could use (it's what we use).\n",
"I'll check that out. Thanks.\n",
"@bboe it's in your best interest to copy and paste `to_native_string` out of requests though. It's an undocumented function that's effectively meant to be internal to requests. If we move it around or change something in it, it could cause compatibility problems for you and there's no guarantee of backwards compatibility for that function as it isn't a defined member of the API.\n\nThat said, @Lukasa and I agree that it's highly unlikely to break, change, or disappear. So, while I'd prefer you to copy and paste it out, there's nothing I can do to enforce that. ;)\n",
"As it turns out, only the request `method` needs to be in the right format. In my above example changing:\n\n```\n request = requests.Request(method='PUT', url='https://httpbin.org/put')\n```\n\nto\n\n```\n request = requests.Request(method=to_native_string('PUT'), url='https://httpbin.org/put')\n```\n\nis all that is needed. Maybe this simple of a fix could be included in requests?\n",
"I'm frankly starting to wonder why we don't do all of this `to_native_string` work when we prepare the request in the first place. It seems like the more correct place for this conversion than [here](https://github.com/kennethreitz/requests/blob/a0d9e0bc57c971823811de38e5733b4b85e575ae/requests/sessions.py#L436).\n",
"Suits me. =)\n",
"Ok, see #2617.\n"
] |
https://api.github.com/repos/psf/requests/issues/2612
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2612/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2612/comments
|
https://api.github.com/repos/psf/requests/issues/2612/events
|
https://github.com/psf/requests/issues/2612
| 80,359,825 |
MDU6SXNzdWU4MDM1OTgyNQ==
| 2,612 |
strange behavior with PostData - Set Cookie Header in Oracle Server
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3330998?v=4",
"events_url": "https://api.github.com/users/nguaman/events{/privacy}",
"followers_url": "https://api.github.com/users/nguaman/followers",
"following_url": "https://api.github.com/users/nguaman/following{/other_user}",
"gists_url": "https://api.github.com/users/nguaman/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nguaman",
"id": 3330998,
"login": "nguaman",
"node_id": "MDQ6VXNlcjMzMzA5OTg=",
"organizations_url": "https://api.github.com/users/nguaman/orgs",
"received_events_url": "https://api.github.com/users/nguaman/received_events",
"repos_url": "https://api.github.com/users/nguaman/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nguaman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nguaman/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nguaman",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 5 |
2015-05-25T02:59:20Z
|
2021-09-08T22:00:53Z
|
2015-08-31T09:35:52Z
|
NONE
|
resolved
|
Hello!
First of all, thanks for this lib!
Sorry for my english.
well, I already solve this, but I just want to make the report about an issue I found.
I am trying to make a simple login to a website (with all the headers, with session, etc)
Server where i am trying to send the request is an Oracle XML DB/Oracle Database Oracle-Web-Cache-11g/11.1.1.6.0
I use httpliveheader to see the log networking, I use all the headers!
Example :
s = requests.Session()
headers = { 'User-Agent': 'Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0',
'Accept': 'text/html,application/xhtml+xml,application/xml;q=0.9,_/_;q=0.8',
'Accept-Language': 'es-CL,es;q=0.8,en-US;q=0.5,en;q=0.3',
'Accept-Encoding': 'gzip, deflate',
'Referer': 'http://domain:9090/apex/f?p=102:1',
'Content-Type': 'application/x-www-form-urlencoded',
}
data = { "data":"1",
"data":"2",
}
r1 = s.post('http://www.domain.com:9090/apex/wwv_flow.accept',data=data,allow_redirects=False,headers=headers)
print r1.headers
print(r1.status_code, r1.reason)
I use allow_redirects to see the set-cookie. that is all I want.
but for some reason, this is not working. honestly I dont know why, I dont see the header set-cookie, and the system say, the user and pass are incorrect, and that is wrong, because I can login in firefox with that credentials.
So I use sockets and works.
import socket #for sockets
import sys #for exit
# create an INET, STREAMing socket
try:
s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
except socket.error:
print 'Failed to create socket'
sys.exit()
print 'Socket Created'
host = 'domain.com';
port = 9090;
try:
remote_ip = socket.gethostbyname( host )
except socket.gaierror:
#could not resolve
print 'Hostname could not be resolved. Exiting'
sys.exit()
# Connect to remote server
s.connect((remote_ip , port))
print 'Socket Connected to ' + host + ' on ip ' + remote_ip
# Send some data to remote server
message = 'POST /apex/wwv_flow.accept HTTP/1.1\r\n'
message += 'Host: domain:9090\r\n'
message += 'User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0\r\n'
message += 'Accept: text/html,application/xhtml+xml,application/xml;q=0.9,_/_;q=0.8\r\n'
message += 'Accept-Language: es-CL,es;q=0.8,en-US;q=0.5,en;q=0.3\r\n'
message += 'Accept-Encoding: gzip, deflate\r\n'
message += 'Referer: http://domain.com/9090/apex/f?p=102:1\r\n'
message += 'Connection: keep-alive\r\n'
message += 'Content-Type: application/x-www-form-urlencoded\r\n'
message += 'Content-Length: LEN\r\n\r\n'
message += 'DATA'
try :
#Set the whole string
s.sendall(message)
except socket.error:
#Send failed
print 'Send failed'
sys.exit()
print 'Message send successfully'
# Now receive data
reply = s.recv(4096)
print reply
and now I receive the header with set-cookie.
maybe this could help to another person.
Regards.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2612/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2612/timeline
| null |
completed
| null | null | false |
[
"can you use tcpdump or a similar tool to compare the headers generated by requests and your code?\n",
"Hey @Lukasa !\n\nI use this command. (http://justniffer.sourceforge.net/)\nsudo justniffer -i eth0 -r > log_socket.txt\n\nHere is the log related with request:\nhttp://paste2.org/mhZCj2t7\n\nand here is the log related with socket.\n\nhttp://paste2.org/8ztZbD7K\n\nwhat I see is, socket make two request. and requests just make one.\n\nthe important value for me is:\nSet-Cookie: LOGIN_USERNAME_COOKIE=<ID_USERNAME>\nSet-Cookie: WWV_CUSTOM-F_1279122985171442_102=8DA9C805E89B5CAE; path=/\n\nbecause with that value I create another requests to get the content in the system.\n\nI hope this help!\n\nAnd thanks Lukasa!\n",
"PD: \nthis value in the requests log\n\nLocation: f?p=102:101:4311424845483966¬ification_msg=Credenciales%20de%20conexi%C3%B3n%20no%20v%C3%A1lidas/FBB8C9F8A0FFD40A59B8FBFE55E8E065/\n\nis related with the failure, because I will be redirected to the login page with the message \"invalid connection\" (but in spanish - Conexion invalida)\n\nand in the postdata is the same for each request (using requests and sockets)\n",
"Are you sure the postdata is the same for both requests? Because requests is setting the content-length to 189, but your socket code sets it to 218.\n\nOut of interest, do you have some non-ASCII characters in your body?\n",
"Closing due to inactivity.\n"
] |
https://api.github.com/repos/psf/requests/issues/2611
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2611/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2611/comments
|
https://api.github.com/repos/psf/requests/issues/2611/events
|
https://github.com/psf/requests/issues/2611
| 80,344,926 |
MDU6SXNzdWU4MDM0NDkyNg==
| 2,611 |
[Bug?] json.dumps(json)?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/2705927?v=4",
"events_url": "https://api.github.com/users/maxdandan/events{/privacy}",
"followers_url": "https://api.github.com/users/maxdandan/followers",
"following_url": "https://api.github.com/users/maxdandan/following{/other_user}",
"gists_url": "https://api.github.com/users/maxdandan/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/maxdandan",
"id": 2705927,
"login": "maxdandan",
"node_id": "MDQ6VXNlcjI3MDU5Mjc=",
"organizations_url": "https://api.github.com/users/maxdandan/orgs",
"received_events_url": "https://api.github.com/users/maxdandan/received_events",
"repos_url": "https://api.github.com/users/maxdandan/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/maxdandan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maxdandan/subscriptions",
"type": "User",
"url": "https://api.github.com/users/maxdandan",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2015-05-25T02:10:39Z
|
2021-09-08T23:04:46Z
|
2015-05-25T02:53:11Z
|
NONE
|
resolved
|
download from https://pypi.python.org/pypi/requests/2.7.0
models.py
line 418
bug?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2611/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2611/timeline
| null |
completed
| null | null | false |
[
"Do you mean https://github.com/kennethreitz/requests/blob/b7bd29734022e634634d908e10bbf7a5ac15e76b/requests/models.py#L428 ? If so, no.\n",
"Yes,“json_dump” is True\nBut in kennethreitz-requests-v2.7.0-8-g4505f71.zip there is “json.dumps”\nFixed right now\nTks :) \n",
"There is no such file on PyPI. If you're downloading files from GitHub, I'd advise you not to.\n"
] |
https://api.github.com/repos/psf/requests/issues/2610
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2610/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2610/comments
|
https://api.github.com/repos/psf/requests/issues/2610/events
|
https://github.com/psf/requests/pull/2610
| 80,170,358 |
MDExOlB1bGxSZXF1ZXN0MzYxMDMwMjM=
| 2,610 |
fix contextlib.closing bug for sessions where content is not consumed…
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/739280?v=4",
"events_url": "https://api.github.com/users/colindickson/events{/privacy}",
"followers_url": "https://api.github.com/users/colindickson/followers",
"following_url": "https://api.github.com/users/colindickson/following{/other_user}",
"gists_url": "https://api.github.com/users/colindickson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/colindickson",
"id": 739280,
"login": "colindickson",
"node_id": "MDQ6VXNlcjczOTI4MA==",
"organizations_url": "https://api.github.com/users/colindickson/orgs",
"received_events_url": "https://api.github.com/users/colindickson/received_events",
"repos_url": "https://api.github.com/users/colindickson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/colindickson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/colindickson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/colindickson",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 6 |
2015-05-24T14:01:17Z
|
2021-09-08T07:00:57Z
|
2015-05-25T17:15:57Z
|
CONTRIBUTOR
|
resolved
|
… (issue #2593)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2610/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2610/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2610.diff",
"html_url": "https://github.com/psf/requests/pull/2610",
"merged_at": "2015-05-25T17:15:57Z",
"patch_url": "https://github.com/psf/requests/pull/2610.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2610"
}
| true |
[
"Why are you making 25 requests to three websites that we don't use anywhere else in the test suite?\n",
"mainly as an attempt to reproduce the bug demonstrated in the original issue. i suppose i could simplify it a great deal\n",
"Please don't create a new pull request. If you continue to push commits to this branch they'll just show up here.\n",
"Also, let me be clear, your fix here is 100% correct.\n",
"test should be better now :) \n",
"LGTM. :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/2609
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2609/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2609/comments
|
https://api.github.com/repos/psf/requests/issues/2609/events
|
https://github.com/psf/requests/issues/2609
| 78,970,053 |
MDU6SXNzdWU3ODk3MDA1Mw==
| 2,609 |
Memory Leak
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/6700330?v=4",
"events_url": "https://api.github.com/users/030io/events{/privacy}",
"followers_url": "https://api.github.com/users/030io/followers",
"following_url": "https://api.github.com/users/030io/following{/other_user}",
"gists_url": "https://api.github.com/users/030io/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/030io",
"id": 6700330,
"login": "030io",
"node_id": "MDQ6VXNlcjY3MDAzMzA=",
"organizations_url": "https://api.github.com/users/030io/orgs",
"received_events_url": "https://api.github.com/users/030io/received_events",
"repos_url": "https://api.github.com/users/030io/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/030io/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/030io/subscriptions",
"type": "User",
"url": "https://api.github.com/users/030io",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 24 |
2015-05-21T12:16:26Z
|
2021-09-08T21:00:48Z
|
2015-11-05T18:02:43Z
|
NONE
|
resolved
|
### I just started applications
---
### After 24h
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2609/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2609/timeline
| null |
completed
| null | null | false |
[
"At the beginning, the memory usage is 32MB.\nAfter 24h, the memory usage is 1.2G.\n",
"Unfortunately, this 'leak' is somewhat unclear. Can you reduce this to a single bit of reproducible code for me to see?\n",
"Sorry.\nMy code is very simple.\n\nLike:\n\n```\nclass GetHtml():\n ...\n def get(self, headers)\n self.response = requests.get('http://'+self.target_host+self.uri, headers=headers) \n self.body, self.headers = self.response.content, self.response.headers\n ...\n```\n",
"Running at:\n- CentOS7.1\n- Python3.4.3\n\nOther module:\n- chardet\n- flask\n",
"Do you have any active `GetHtml` classes lying around, or any references to `self.response` still active?\n",
"Absolutely no.\n",
"```\n def get(self, **headers):\n try:\n headers['Referer'] = 'http://' + self.target_host + '/'\n self.response = requests.get('http://'+self.target_host+self.uri, headers=headers)\n self.body, self.headers = self.response.content, self.response.headers\n if self.headers.get('Content-Type', '').startswith('text') and self.headers.get('Content-Type', '') != 'text/css':\n if self.target_host in self._encodings and self._encodings[self.target_host] in self.body:\n encoding = self._encodings[self.target_host].decode('utf-8')\n else:\n encoding = chardet.detect(self.body[100:1000])['encoding']\n self._encodings[self.target_host] = encoding.encode('utf-8')\n self.body = self.body.decode(encoding, 'ignore')\n self.replace()\n self.body = self.body.encode(encoding, 'ignore')\n return self.response.status_code, self.body, self.headers\n except Exception as e:\n return 500, str(e), {'Content-Type':'text/html'}\n```\n",
"## in flask\n\n```\ncode, body, headers = rp.get(\n **{\n 'User-Agent' : request.headers.get(\n 'User-Agent',\n '''Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.2; Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET4.0E; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; .NET4.0C)'''\n ),\n }\n)\nresp = make_response(body, code)\n#for name, value in headers.items():\n #self.set_header(name, value)\nif 'Content-Type' in headers:\n resp.headers['Content-Type'] = headers['Content-Type']\n\nreturn resp\n```\n",
"With a very basic code example, I cannot reproduce this leak. objgraph shows no extra allocations.\n\nCan you try using objgraph to find out what is keeping those objects alive?\n\nFYI, the code I used is below:\n\n```\nimport requests\nimport signal\nimport threading\n\n\ndef handler(*args):\n import pdb\n pdb.set_trace()\n\n\ndef req_thread():\n while True:\n r = requests.get('http://www.http2bin.org/get')\n r.content\n\n\nsignal.signal(signal.SIGBREAK, handler)\n\nts = [threading.Thread(target=req_thread) for _ in range(0, 8)]\nfor t in ts:\n t.start()\n\nfor t in ts:\n while True:\n try:\n success = t.join(5)\n except IOError:\n continue\n if success:\n break\n```\n",
"How about 599 error? \nThere are so many 599 error. \nAnd I control source address and port by hook http.client.HTTPConnection.**init** method. \n\n```\ndef HTTPConnection_init_hook(HC):\n def wraps(*args, **kwargs):\n global IPS #It is list of my server ip.\n if IPS:\n kwargs[\"source_address\"] = (random.choice(IPS), random.randint(10000,30000))\n return HC(*args, **kwargs) \n return wraps\n\n\nhttp.client.HTTPConnection.__init__ = HTTPConnection_init_hook(http.client.HTTPConnection.__init__)\n```\n\n**The port is possible be used, it will raise a Error.**\n",
"No more code,other code is not important.\nI'm sorry, I can not do more.\n",
"Once again, it's going to be easiest if we can track down what is keeping these objects alive. If it's inside requests we can deal with it, and if it's inside your code I can provide guidance on how to improve things. Are you familiar with objgraph?\n",
"# rproxy.py\n\n```\nimport re\nimport random\nimport http.client\n\nimport chardet\nimport requests\n\nfrom . import host\nfrom . import config\n\n\nIPS_PATH = 'ips'\nIPS = []\n\nwith open(IPS_PATH, 'rt') as f:\n for line in f.read().replace(' ', '').split('\\n'):\n if line:\n IPS.append(line)\n\n\nclass ReverseProxy():\n _encodings = {}\n _titles = {}\n def __init__(self, local_host, target_host, uri):\n self.local_host = local_host\n self.target_host = target_host\n self.uri = uri\n self.is_index = uri == '/'\n\n def get(self, **headers):\n try:\n headers['Referer'] = 'http://' + self.target_host + '/'\n self.response = requests.get('http://'+self.target_host+self.uri, headers=headers)\n self.body, self.headers = self.response.content, self.response.headers\n if self.headers.get('Content-Type', '').startswith('text') and self.headers.get('Content-Type', '') != 'text/css':\n if self.target_host in self._encodings and self._encodings[self.target_host] in self.body:\n encoding = self._encodings[self.target_host].decode('utf-8')\n else:\n encoding = chardet.detect(self.body[100:1000])['encoding']\n self._encodings[self.target_host] = encoding.encode('utf-8')\n self.body = self.body.decode(encoding, 'ignore')\n self.replace()\n self.body = self.body.encode(encoding, 'ignore')\n return self.response.status_code, self.body, self.headers\n except Exception as e:\n return 500, str(e), {'Content-Type':'text/html'}\n\n def replace(self):\n self.replace_title()\n self.replace_keywords()\n self.replace_description()\n self.replace_meta()\n self.replace_host()\n self.replace_js()\n self.replace_outlink()\n\n def replace_host(self):\n body = self.body\n body = re.sub('http://'+self.target_host + '/', '/', body, 0, re.IGNORECASE)\n body = re.sub(self.target_host, self.local_host, body, 0, re.IGNORECASE)\n self.body = body\n\n def replace_js(self):\n body = self.body\n body = re.sub(r'<script[\\s\\S]+?/script.*?>', '', body, 0, re.IGNORECASE)\n body = re.sub(r'<noscript[\\s\\S]+?/noscript.*?>', '', body, 0, re.IGNORECASE)\n if self.is_index:\n if re.search('</head', body, re.IGNORECASE):\n body = re.sub(r'</head', '<script type=\"text/javascript\" src=\"/local.js\"></script>\\n</head', body, 1, re.IGNORECASE)\n elif re.search('<body', body, re.IGNORECASE):\n body = re.sub(r'<body', '<script type=\"text/javascript\" src=\"/local.js\"></script>\\n<body', body, 1, re.IGNORECASE)\n else:\n raise Exception('no </head> and <body>')\n self.body = body\n\n def replace_outlink(self):\n self.body = re.sub(r'''<a[^<>]*?href=['\"]?http://[^<]*?</a>''', '', self.body, 0, re.IGNORECASE)\n #add outlink\n self.body += ''.join([\n '<div id=\"footer\"><b style=\"color:#03F; font-size:14px;\">友情链接：</b>',\n '<ul>',\n ''.join([\n '<li><a href=\"http://'+h+'\">'+config[h].get('host', 'title').split(',', 1)[0]+'</a></li>' for h in host.get_outlink_host(self.local_host)\n ]),\n '</ul>',\n '</div>',\n ])\n\n def replace_title(self):\n body = self.body\n\n title = config[self.local_host].get('host', 'title')\n main_key = title.split(',', 1)[0]\n\n if self._titles.get(self.target_host, None):\n replaced_title = self._titles.get(self.target_host)\n elif self.is_index:\n replaced_title = re.search('<title.*?>(.*?)</title', body, re.IGNORECASE).groups()[0]\n replaced_title = re.sub(r'[a-zA-Z0-9\\s\\-\\.\\*\\\\\\/\\,]', '', replaced_title, 0)\n replaced_title = ''.join(set(replaced_title))\n self._titles[self.target_host] = replaced_title\n else:\n replaced_title = '囃'\n\n if self.is_index:\n body = re.sub('<title.+?</title', '<title> '+ title +' </title', body, 0, re.IGNORECASE)\n body = re.sub('<h1.+?</h1', '<h1> '+ main_key +' </h1', body, 0, re.IGNORECASE) # replace h1\n body = re.sub('[' + replaced_title + ']{3,}', main_key, body) #替换页面中的标题相关关键词\n\n self.body = body\n\n\n def replace_keywords(self):\n if self.is_index:\n self.body = re.sub(r'''<meta[^\\n<>]+?name\\s*=\\s*(['\"]?)keywords?\\1[^\\n]*?>''', '<meta name=\"keywords\" content=\"'+ config[self.local_host].get('host', 'keywords') +'\" />', self.body, 1, re.IGNORECASE)\n\n def replace_description(self):\n if self.is_index:\n self.body = re.sub(r'''<meta[^\\n<>]+?name\\s*=\\s*(['\"]?)descriptions?\\1[^\\n]*?>''', '<meta name=\"description\" content=\"'+ config[self.local_host].get('host', 'description') +'\" />', self.body, 1, re.IGNORECASE)\n\n def replace_meta(self):\n if self.is_index:\n body = self.body\n body = re.sub(r'''<meta[^\\n<>]*?refresh[^<>]*?/>''', '', body, 0, re.IGNORECASE)\n if self.is_index:\n if re.search('</head', body, re.IGNORECASE):\n body = re.sub(r'</head', '<meta http-equiv=\"Cache-Control\" content=\"no-transform\" />\\n<meta http-equiv=\"Cache-Control\" content=\"no-siteapp\" />\\n</head', body, 1, re.IGNORECASE)\n elif re.search('head>', body, re.IGNORECASE):\n body = re.sub(r'head>', 'head>\\n<meta http-equiv=\"Cache-Control\" content=\"no-transform\" />\\n<meta http-equiv=\"Cache-Control\" content=\"no-siteapp\" />', body, 1, re.IGNORECASE)\n self.body = body\n\n\ndef block_ext(url):\n if '.' in url and url.split('?', 1)[0].rsplit('.', 1)[1] in \\\n config.get('other', 'block_ext').replace(' ', '').split(','):\n return True\n else:\n return False\n\ndef HTTPConnection_init_hook(HC):\n def wraps(*args, **kwargs):\n global IPS\n if IPS:\n kwargs[\"source_address\"] = (random.choice(IPS), random.randint(10000,30000))\n return HC(*args, **kwargs)\n return wraps\n\n\nhttp.client.HTTPConnection.__init__ = HTTPConnection_init_hook(http.client.HTTPConnection.__init__)\n```\n\n# view.py\n\n```\nfrom flask import redirect, request, abort, make_response\n\nfrom . import app\nfrom . import host\nfrom . import rproxy\nfrom . import config\n\n\[email protected]_request\ndef all():\n host_ = '.'.join(request.host.split('.')[-2:])\n if host_ != request.host:\n return redirect('http://'+host_)\n\n if not host.is_allow(request.host):\n return abort(400)\n\n uri = request.url[len(request.url_root)-1:]\n if rproxy.block_ext(uri):\n return abort(403)\n\n # local.js\n if uri == '/local.js':\n with open('local.js', 'rt') as f:\n return f.read()\n\n # reverse_proxy\n rp = rproxy.ReverseProxy(request.host, config[request.host].get('host', 'target'), uri)\n code, body, headers = rp.get(\n **{\n 'User-Agent' : request.headers.get(\n 'User-Agent',\n '''Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.2; Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET4.0E; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; .NET4.0C)'''\n ),\n }\n )\n resp = make_response(body, code)\n #for name, value in headers.items():\n #self.set_header(name, value)\n if 'Content-Type' in headers:\n resp.headers['Content-Type'] = headers['Content-Type']\n\n return resp\n```\n\n# That is my code.\n",
"I use 'dozer' to trace memory leak. \nIt gave me the above two pictures. \n",
"The memory leak is slow.\n",
"So I need to say again that I agree that you have a memory leak, but without using `objgraph` we're going to find it very difficult to track it down. That's something you can do just as easily as I can. =)\n",
"For the requests you're making is there a content encoding? If not, this may be coming from chardet.\n",
"Thank you.\nI remove the chardet module, and reinstall CentOS6.x.\nLet me see tomorrow.\n",
"@Lukasa It is very difficult to using `objgraph` in my code.\nBecause the memory leak is slow and `objgraph` can't track every `requests` instance,\n it will create a lot of pictures, Which picture Useful?\n\nThank You for your help.\nIf I find the code of memory leaks, I will contact you again.\n",
"# It's still here.\n\n\n",
"@030io can you please tell us what version of requests you're using? As you're using it, I see absolutely no way that this is coming from us. Since I don't know how your app is used, I can't tell you for sure, but you do realize that those class attributes will continue to accumulate information. Specifically `ReverseProxy._encodings` and `ReverseProxy._titles`. Those are class level attributes and will continue to grow over time even though you access them as `self._encodings`.\n",
"@sigmavirus24 \nI use `http.client` instead of `requests`. And the memory leak is gone.\n",
"I'll ask again, can you please tell us what version of requests you're using?\n",
"sorry.\nthe newest version of requests in pypi.\nrunning at: python3.4.3\n"
] |
https://api.github.com/repos/psf/requests/issues/2608
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2608/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2608/comments
|
https://api.github.com/repos/psf/requests/issues/2608/events
|
https://github.com/psf/requests/pull/2608
| 78,757,189 |
MDExOlB1bGxSZXF1ZXN0MzU4ODk4MTk=
| 2,608 |
Fixed typos
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3112309?v=4",
"events_url": "https://api.github.com/users/radarhere/events{/privacy}",
"followers_url": "https://api.github.com/users/radarhere/followers",
"following_url": "https://api.github.com/users/radarhere/following{/other_user}",
"gists_url": "https://api.github.com/users/radarhere/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/radarhere",
"id": 3112309,
"login": "radarhere",
"node_id": "MDQ6VXNlcjMxMTIzMDk=",
"organizations_url": "https://api.github.com/users/radarhere/orgs",
"received_events_url": "https://api.github.com/users/radarhere/received_events",
"repos_url": "https://api.github.com/users/radarhere/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/radarhere/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/radarhere/subscriptions",
"type": "User",
"url": "https://api.github.com/users/radarhere",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-05-21T00:26:12Z
|
2021-09-08T07:00:57Z
|
2015-05-21T08:16:24Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2608/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2608/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2608.diff",
"html_url": "https://github.com/psf/requests/pull/2608",
"merged_at": "2015-05-21T08:16:24Z",
"patch_url": "https://github.com/psf/requests/pull/2608.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2608"
}
| true |
[
"\\o/ Thanks @radarhere! :cake: :sparkles:\n"
] |
|
https://api.github.com/repos/psf/requests/issues/2607
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2607/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2607/comments
|
https://api.github.com/repos/psf/requests/issues/2607/events
|
https://github.com/psf/requests/issues/2607
| 78,148,003 |
MDU6SXNzdWU3ODE0ODAwMw==
| 2,607 |
UnicodeDecodeError when post a local image file
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/546163?v=4",
"events_url": "https://api.github.com/users/shelper/events{/privacy}",
"followers_url": "https://api.github.com/users/shelper/followers",
"following_url": "https://api.github.com/users/shelper/following{/other_user}",
"gists_url": "https://api.github.com/users/shelper/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/shelper",
"id": 546163,
"login": "shelper",
"node_id": "MDQ6VXNlcjU0NjE2Mw==",
"organizations_url": "https://api.github.com/users/shelper/orgs",
"received_events_url": "https://api.github.com/users/shelper/received_events",
"repos_url": "https://api.github.com/users/shelper/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/shelper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shelper/subscriptions",
"type": "User",
"url": "https://api.github.com/users/shelper",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-05-19T16:01:08Z
|
2021-09-08T23:04:46Z
|
2015-05-19T16:31:47Z
|
NONE
|
resolved
|
i am using python 3.4, and request 2.7
i am trying to post a local jpg image like this, and got encoding error:
```
import requests
response = requests.post("url here",
params={
"image": open("path to local image", mode="r")
}
)
```
if i change the mode to 'rb' the error is gone:
```
import requests
response = requests.post("url here",
params={
"image": open("path to local image", mode="rb")
}
)
```
the error details are listed below:
'Traceback (most recent call last):
File "test_facemark.py", line 7, in <module>
"image": open("path to the jpg file", mode="r")
File "c:\python34\lib\site-packages\requests\api.py", line 109, in post
return request('post', url, data=data, json=json, *_kwargs)
File "c:\python34\lib\site-packages\requests\api.py", line 50, in reques response = session.request(method=method, url=url, *_kwargs)
File "c:\python34\lib\site-packages\requests\sessions.py", line 451, in
t
prep = self.prepare_request(req)
File "c:\python34\lib\site-packages\requests\sessions.py", line 382, in
e_request
hooks=merge_hooks(request.hooks, self.hooks),
File "c:\python34\lib\site-packages\requests\models.py", line 304, in pr self.prepare_url(url, params)
File "c:\python34\lib\site-packages\requests\models.py", line 397, in prurl
enc_params = self._encode_params(params)
File "c:\python34\lib\site-packages\requests\models.py", line 92, in _enarams
for v in vs:
UnicodeDecodeError: 'gbk' codec can't decode byte 0xff in position 0: illeltibyte sequence'
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2607/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2607/timeline
| null |
completed
| null | null | false |
[
"In Python 3, if you open a file in `'r'` mode, that will open the file in _text_ mode. This means that Python will attempt to use your system encoding to decode the bytes in the file. That is causing this exception here.\n\nWhen uploading binary data to the web, you should always open the file in bytes mode: `'rb'`. You _should_ also do that with text files, really, to avoid problems with an encoding round trip.\n"
] |
https://api.github.com/repos/psf/requests/issues/2606
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2606/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2606/comments
|
https://api.github.com/repos/psf/requests/issues/2606/events
|
https://github.com/psf/requests/pull/2606
| 78,084,605 |
MDExOlB1bGxSZXF1ZXN0MzU3MjkwNDE=
| 2,606 |
Don’t break IPv6 address format
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1102886?v=4",
"events_url": "https://api.github.com/users/da2x/events{/privacy}",
"followers_url": "https://api.github.com/users/da2x/followers",
"following_url": "https://api.github.com/users/da2x/following{/other_user}",
"gists_url": "https://api.github.com/users/da2x/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/da2x",
"id": 1102886,
"login": "da2x",
"node_id": "MDQ6VXNlcjExMDI4ODY=",
"organizations_url": "https://api.github.com/users/da2x/orgs",
"received_events_url": "https://api.github.com/users/da2x/received_events",
"repos_url": "https://api.github.com/users/da2x/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/da2x/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/da2x/subscriptions",
"type": "User",
"url": "https://api.github.com/users/da2x",
"user_view_type": "public"
}
|
[
{
"color": "e11d21",
"default": false,
"description": null,
"id": 78002701,
"name": "Do Not Merge",
"node_id": "MDU6TGFiZWw3ODAwMjcwMQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Do%20Not%20Merge"
}
] |
closed
| true | null |
[] | null | 1 |
2015-05-19T13:20:55Z
|
2021-09-08T07:00:57Z
|
2015-05-19T13:26:58Z
|
NONE
|
resolved
|
No idea what this does to older supported Python versions. In Python 3.4.2, at least, you can’t strip away the brackets otherwise no IPv6 address will resolve.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2606/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2606/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2606.diff",
"html_url": "https://github.com/psf/requests/pull/2606",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2606.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2606"
}
| true |
[
"Thanks for this!\n\nTwo notes. First, this is a change in [urllib3](https://github.com/shazow/urllib3), please open this pull request on that repository. Secondly, given the comment above I don't think we can unilaterally remove this logic. Likely we'll have to detect what versions are affected.\n"
] |
https://api.github.com/repos/psf/requests/issues/2605
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2605/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2605/comments
|
https://api.github.com/repos/psf/requests/issues/2605/events
|
https://github.com/psf/requests/issues/2605
| 77,701,599 |
MDU6SXNzdWU3NzcwMTU5OQ==
| 2,605 |
ENH: Session constructor should acccept kwargs as well, not just its get, post... methods
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3160562?v=4",
"events_url": "https://api.github.com/users/dr-leo/events{/privacy}",
"followers_url": "https://api.github.com/users/dr-leo/followers",
"following_url": "https://api.github.com/users/dr-leo/following{/other_user}",
"gists_url": "https://api.github.com/users/dr-leo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dr-leo",
"id": 3160562,
"login": "dr-leo",
"node_id": "MDQ6VXNlcjMxNjA1NjI=",
"organizations_url": "https://api.github.com/users/dr-leo/orgs",
"received_events_url": "https://api.github.com/users/dr-leo/received_events",
"repos_url": "https://api.github.com/users/dr-leo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dr-leo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dr-leo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dr-leo",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2015-05-18T15:33:07Z
|
2021-09-08T23:04:46Z
|
2015-05-18T17:00:36Z
|
NONE
|
resolved
|
The documentation states that things like proxies, auth etc. can be set through the Session properties. That's fine, but leads to verbose code: Setting those properties when you have a kwargs dict requires a for loop and call to setattr() on each item.
Why not allow the following:
s = requests.Session(stream=True, proxies=myproxies)
or
s=requests.Session(**myhttp_config)
Am I missing something?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2605/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2605/timeline
| null |
completed
| null | null | false |
[
"Removing the arguments to the `Session` constructor was a deliberate decision made by @kennethreitz in 92355ada54a3a19341f7fbc65a8bc50816858c63. In this issue I cannot pretend to speak for him, but I believe in his view this was done for cleanliness (which seems reasonable to me). We have no plans to change that portion of the API at this time. Sorry! :smile:\n",
"To be fair, you can do this yourself.\n\n``` py\ndef make_session(**with_config):\n session = requests.Session()\n for attr, value in with_config.items():\n if hasattr(session, attr):\n setattr(session, attr, value)\n return session\n\nsession = make_session(proxies={'http': 'http://10.9.8.7:9191/'}, headers={'Accept': 'application/json'})\n\n# Alternatively\n\nclass Session(requests.Session):\n def __init__(self, **config):\n super().__init__()\n for attr, value in config.items():\n if hasattr(self, attr):\n setattr(self, attr, value)\n```\n\nOf course, this doesn't let you set anything that the session doesn't already have defined, but that seems like a fair trade-off that you can ignore if you write this yourself. That said, there were some complaints about this shortly after we removed the functionality, but this is the first complaint we've had in years that it's not there. That indicates that it isn't something that a lot of people are having trouble with it.\n",
"Thanks. Yes, it's no big deal to write a factory function or wrapper\nclass for this. Even so, simple-minded humans like me will scratch their\nheads wondering how this is cleaner than simply accepting kwargs to\ninitialize a Session.\n\nBut I am sure Kenneth will have a good reason for removing this feature.\nAnd now that I know I'm not alone looping over items and setting\nattributes, I will delightfully loop on.\n\nThanks for an excellent library,\n\nLeo\n\nAm 18.05.2015 um 20:57 schrieb Ian Cordasco:\n\n> To be fair, you can do this yourself.\n> \n> def make_session(**with_config):\n> session = requests.Session()\n> for attr, value in with_config.items():\n> if hasattr(session, attr):\n> setattr(session, attr, value)\n> return session\n> \n> session = make_session(proxies={'http': 'http://10.9.8.7:9191/'}, headers={'Accept': 'application/json'})\n> \n> # Alternatively\n> \n> class Session(requests.Session):\n> def **init**(self, **config):\n> super().**init**()\n> for attr, value in config.items():\n> if hasattr(self, attr):\n> setattr(self, attr, value)\n> \n> Of course, this doesn't let you set anything that the session doesn't\n> already have defined, but that seems like a fair trade-off that you\n> can ignore if you write this yourself. That said, there were some\n> complaints about this shortly after we removed the functionality, but\n> this is the first complaint we've had in years that it's not there.\n> That indicates that it isn't something that a lot of people are having\n> trouble with it.\n> \n> —\n> Reply to this email directly or view it on GitHub\n> https://github.com/kennethreitz/requests/issues/2605#issuecomment-103176002.\n"
] |
https://api.github.com/repos/psf/requests/issues/2604
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2604/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2604/comments
|
https://api.github.com/repos/psf/requests/issues/2604/events
|
https://github.com/psf/requests/issues/2604
| 77,360,557 |
MDU6SXNzdWU3NzM2MDU1Nw==
| 2,604 |
SSL Error 14077438
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/12233053?v=4",
"events_url": "https://api.github.com/users/sergedroz/events{/privacy}",
"followers_url": "https://api.github.com/users/sergedroz/followers",
"following_url": "https://api.github.com/users/sergedroz/following{/other_user}",
"gists_url": "https://api.github.com/users/sergedroz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sergedroz",
"id": 12233053,
"login": "sergedroz",
"node_id": "MDQ6VXNlcjEyMjMzMDUz",
"organizations_url": "https://api.github.com/users/sergedroz/orgs",
"received_events_url": "https://api.github.com/users/sergedroz/received_events",
"repos_url": "https://api.github.com/users/sergedroz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sergedroz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sergedroz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sergedroz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 5 |
2015-05-17T18:03:28Z
|
2021-09-08T23:04:47Z
|
2015-05-17T20:58:14Z
|
NONE
|
resolved
|
Certain cloudflare websites cannot be access with requests. I have dis problem across different distros. Same problem here: https://github.com/SiCKRAGETV/sickrage-issues/issues/1231
requests.get('https://sceneaccess.eu')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "requests/api.py", line 69, in get
return request('get', url, params=params, *_kwargs)
File "requests/api.py", line 50, in request
response = session.request(method=method, url=url, *_kwargs)
File "requests/sessions.py", line 465, in request
resp = self.send(prep, *_send_kwargs)
File "requests/sessions.py", line 573, in send
r = adapter.send(request, *_kwargs)
File "requests/adapters.py", line 431, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: [Errno 1] _ssl.c:510: error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2604/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2604/timeline
| null |
completed
| null | null | false |
[
"Where have you installed requests from, and what versions do you have installed?\n",
"This is likely because you're linked against an old version of OpenSSL. Can you run this for me and show me the output?\n\n``` bash\npython -c 'from cryptography.hazmat.backends.openssl.backend import backend; print backend.openssl_version_text()'\n```\n",
"Yup, I can confirm: if I have PyOpenSSL compiled against OpenSSL 0.9.8 the handshake fails because there are no overlapping cipher suites. If I compile against OpenSSL 1.0.2, however, the handshake succeeds.\n",
"@Lukasa it's probably best to use print() for instructions like that in case the end user is on a distro which has changed the sym link for python to point to python 3 instead of 2.\n\nAs a side note, I generally recompile python after installing a new version of OpenSSL, so I was a little surprised to see my workstation here reporting the version as 1.0.2 instead of 1.0.2a and it turns out that the cryptography module requires a force reinstall to detect that change in addition to whatever is done to the python installation (which normally includes byte compiling installed modules), it would be quite easy for anyone to overlook that even after upgrading OpenSSL.\n",
"> it's probably best to use print() for instructions like that in case the end user is on a distro which has changed the sym link for python to point to python 3 instead of 2.\n\nThat's not really relevant. =) The number of users using Python 3 instead of Python 2 is very low, and I trust that most users capable of reporting bugs on this bug tracker are also capable of translating this extremely common line of code into the correct syntax for their platform. Given that `print()` won't work on Python 2 without an appropriate **future** import, I'm choosing to optimise for the more likely case.\n\nRegardless, I think we can close this. @sergedroz, your OpenSSL is too old. If you're using pyOpenSSL, please reinstall cryptography linked against a more modern OpenSSL. If you're not, please upgrade to a newer version of OpenSSL and then rebuild Python.\n"
] |
https://api.github.com/repos/psf/requests/issues/2603
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2603/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2603/comments
|
https://api.github.com/repos/psf/requests/issues/2603/events
|
https://github.com/psf/requests/pull/2603
| 76,451,587 |
MDExOlB1bGxSZXF1ZXN0MzU0NDg4ODA=
| 2,603 |
Change "Staring new HTTP/S connection..." log message to DEBUG level
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3641285?v=4",
"events_url": "https://api.github.com/users/goodboybeau/events{/privacy}",
"followers_url": "https://api.github.com/users/goodboybeau/followers",
"following_url": "https://api.github.com/users/goodboybeau/following{/other_user}",
"gists_url": "https://api.github.com/users/goodboybeau/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/goodboybeau",
"id": 3641285,
"login": "goodboybeau",
"node_id": "MDQ6VXNlcjM2NDEyODU=",
"organizations_url": "https://api.github.com/users/goodboybeau/orgs",
"received_events_url": "https://api.github.com/users/goodboybeau/received_events",
"repos_url": "https://api.github.com/users/goodboybeau/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/goodboybeau/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/goodboybeau/subscriptions",
"type": "User",
"url": "https://api.github.com/users/goodboybeau",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-05-14T18:40:11Z
|
2021-09-08T07:00:58Z
|
2015-05-14T18:42:16Z
|
NONE
|
resolved
|
Of course there are ways to work around this on a per-execution basis (programmatically or manually), but I figured I'd address what I've heard from various developers as "the only annoying thing about python requests".
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2603/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2603/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2603.diff",
"html_url": "https://github.com/psf/requests/pull/2603",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2603.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2603"
}
| true |
[
"This is a change to urllib3 and so belongs on [urllib3](/shazow/urllib3)\n",
"Ah, thanks...\n"
] |
https://api.github.com/repos/psf/requests/issues/2602
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2602/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2602/comments
|
https://api.github.com/repos/psf/requests/issues/2602/events
|
https://github.com/psf/requests/pull/2602
| 76,318,369 |
MDExOlB1bGxSZXF1ZXN0MzU0MTEzMzQ=
| 2,602 |
morsel['max-age'] may be a str. Should it be converted to float?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1551736?v=4",
"events_url": "https://api.github.com/users/ly0/events{/privacy}",
"followers_url": "https://api.github.com/users/ly0/followers",
"following_url": "https://api.github.com/users/ly0/following{/other_user}",
"gists_url": "https://api.github.com/users/ly0/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ly0",
"id": 1551736,
"login": "ly0",
"node_id": "MDQ6VXNlcjE1NTE3MzY=",
"organizations_url": "https://api.github.com/users/ly0/orgs",
"received_events_url": "https://api.github.com/users/ly0/received_events",
"repos_url": "https://api.github.com/users/ly0/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ly0/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ly0/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ly0",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 10 |
2015-05-14T10:45:17Z
|
2021-09-08T07:00:58Z
|
2015-05-15T15:14:56Z
|
CONTRIBUTOR
|
resolved
|
Example:
here are Set-Cookie list:
``` python
sclst = ['dwac_bcIBMiaagZmkYaaadeYtg11eVR=j9jHdmPjUhgDOhyH9f89X4lQgehEmflVyeA%3D|dw-only|||CNY|false|Asia%2FShanghai|true; Path=/',
'sid=j9jHdmPjUhgDOhyH9f89X4lQgehEmflVyeA; Path=/',
'geoLocation=CN; Path=/',
'dwpersonalization_fae107a9dd0fc32ed99532ec1977f31f=bc8sEiaagZqRsaaadk8XoNTL8h20150506; Expires=Sun, 14-Jun-2015 10:37:07 GMT; Path=/',
'dwanonymous_fae107a9dd0fc32ed99532ec1977f31f=abjpA8kng31LjPp8ZEERDT4XVg; Version=1; Comment="Demandware anonymous cookie for site Sites-abercrombie_cn-Site"; Max-Age=15552000; Expires=Tue, 10-Nov-2015 10:37:07 GMT; Path=/',
'myStore=91156; Path=/',
'AF_PREF=en_CN; Path=/',
'dwsid=MiHJy3KYZKDcN0lZg4HS1zSpj1VV4s_tFu39ar0KXNpAx9aX8X2LlvZQ9m5fOOknb6QXtmmukHcOjmivYf31hg==; path=/; HttpOnly']
```
``` python
for sc in sclst:
C = Cookie.SimpleCookie(sc)
for morsel in C.values():
cookie = requests.cookies.morsel_to_cookie(morsel)
cookiejar.set_cookie(cookie)
```
Then, exception occured
``` shell
File "/Library/Python/2.7/site-packages/requests/cookies.py", line 402, in morsel_to_cookie
expires = time.time() + morsel['max-age']
TypeError: unsupported operand type(s) for +: 'float' and 'str'
```
As Cookie.SimpleCookie is in STL, should `morsel_to_cookie` check the type of `max-age`? On the other hand, if **max-age** can not be converted to float, it's illegal obviously.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2602/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2602/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2602.diff",
"html_url": "https://github.com/psf/requests/pull/2602",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2602.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2602"
}
| true |
[
"I think you're using `morsel_to_cookie` incorrectly. It expects a `Cookie.Morsel`. Did you try that to see if it works?\n",
"It's a `Cookie.Morsel` object.\n\nhere's the test code from real world:\n\n``` python\nimport Cookie\nimport requests\n\ncookiejar = requests.cookies.RequestsCookieJar()\nsclst = ['dwac_bcIBMiaagZmkYaaadeYtg11eVR=j9jHdmPjUhgDOhyH9f89X4lQgehEmflVyeA%3D|dw-only|||CNY|false|Asia%2FShanghai|true; Path=/',\n 'sid=j9jHdmPjUhgDOhyH9f89X4lQgehEmflVyeA; Path=/',\n 'geoLocation=CN; Path=/',\n 'dwpersonalization_fae107a9dd0fc32ed99532ec1977f31f=bc8sEiaagZqRsaaadk8XoNTL8h20150506; Expires=Sun, 14-Jun-2015 10:37:07 GMT; Path=/',\n 'dwanonymous_fae107a9dd0fc32ed99532ec1977f31f=abjpA8kng31LjPp8ZEERDT4XVg; Version=1; Comment=\"Demandware anonymous cookie for site Sites-abercrombie_cn-Site\"; Max-Age=15552000; Expires=Tue, 10-Nov-2015 10:37:07 GMT; Path=/',\n 'myStore=91156; Path=/',\n 'AF_PREF=en_CN; Path=/',\n 'dwsid=MiHJy3KYZKDcN0lZg4HS1zSpj1VV4s_tFu39ar0KXNpAx9aX8X2LlvZQ9m5fOOknb6QXtmmukHcOjmivYf31hg==; path=/; HttpOnly']\n\nfor sc in sclst:\n C = Cookie.SimpleCookie(sc)\n for morsel in C.values():\n print type(morsel), morsel\n cookie = requests.cookies.morsel_to_cookie(morsel)\n cookiejar.set_cookie(cookie)\n```\n\nReturns:\n\n``` python\n<class 'Cookie.Morsel'> Set-Cookie: dwac_bcIBMiaagZmkYaaadeYtg11eVR=j9jHdmPjUhgDOhyH9f89X4lQgehEmflVyeA%3D|dw-only|||CNY|false|Asia%2FShanghai|true; Path=/\n<class 'Cookie.Morsel'> Set-Cookie: sid=j9jHdmPjUhgDOhyH9f89X4lQgehEmflVyeA; Path=/\n<class 'Cookie.Morsel'> Set-Cookie: geoLocation=CN; Path=/\n<class 'Cookie.Morsel'> Set-Cookie: dwpersonalization_fae107a9dd0fc32ed99532ec1977f31f=bc8sEiaagZqRsaaadk8XoNTL8h20150506; expires=Sun, 14-Jun-2015 10:37:07 GMT; Path=/\n<class 'Cookie.Morsel'> Set-Cookie: dwanonymous_fae107a9dd0fc32ed99532ec1977f31f=abjpA8kng31LjPp8ZEERDT4XVg; Comment=Demandware anonymous cookie for site Sites-abercrombie_cn-Site; expires=Tue, 10-Nov-2015 10:37:07 GMT; Max-Age=15552000; Path=/; Version=1\nTraceback (most recent call last):\n File \"test.py\", line 18, in <module>\n cookie = requests.cookies.morsel_to_cookie(morsel)\n File \"/Library/Python/2.7/site-packages/requests-2.5.1-py2.7.egg/requests/cookies.py\", line 393, in morsel_to_cookie\n expires = time.time() + morsel['max-age']\nTypeError: unsupported operand type(s) for +: 'float' and 'str'\n```\n",
"I'm failing to understand why this doesn't happen when we handle cookies on a response with `max-age` set, but I guess it isn't that big of a deal. This is a small enough change. I would just like a comment explaining why it's necessary and maybe referencing this issue as `kennethreitz/requests#2602`\n",
"That is, assuming, @Lukasa has no objections\n",
"I have no particular objection to this. =)\n",
"Hoping to retrigger CI\n",
"So this breaks an existing test that guarded against a different problem: http://ci.kennethreitz.org/job/requests-pr/665/PYTHON=2.7/console \n",
"Codes updated.\n\nAccording to [RFC6265](https://www.ietf.org/rfc/rfc2616.txt),\n\n```\n5.2.2. The Max-Age Attribute\n\n If the attribute-name case-insensitively matches the string \"Max-\n Age\", the user agent MUST process the cookie-av as follows.\n\n If the first character of the attribute-value is not a DIGIT or a \"-\"\n character, ignore the cookie-av.**\n\n If the remainder of attribute-value contains a non-DIGIT character,\n ignore the cookie-av.\n\n Let delta-seconds be the attribute-value converted to an integer.\n\n If delta-seconds is less than or equal to zero (0), let expiry-time\n be the earliest representable date and time. Otherwise, let the\n expiry-time be the current date and time plus delta-seconds seconds.\n\n Append an attribute to the cookie-attribute-list with an attribute-\n name of Max-Age and an attribute-value of expiry-time.\n```\n\nSo, if `max-age` value is not positive or negative numbers, we should ignore its affection.\n\n:-o **but according to unittest, it is supposed to be raised a TypeError exception.**\n",
"LGTM, but I'm going to wait for @sigmavirus24 on this one.\n",
"Hi @ly0 \n\nI pulled down your PR and squashed those three commits with the same exact message. The fix is on master as of https://github.com/kennethreitz/requests/commit/ab1f493c8b6f82cbf80f8554b5fbbd02f2b2a363\n\nThanks!\n\n:sparkles: :cake: :sparkles: \n"
] |
https://api.github.com/repos/psf/requests/issues/2601
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2601/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2601/comments
|
https://api.github.com/repos/psf/requests/issues/2601/events
|
https://github.com/psf/requests/pull/2601
| 76,249,293 |
MDExOlB1bGxSZXF1ZXN0MzUzOTY3NzI=
| 2,601 |
Auth handler calls close instead of raw.close_conn
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/5676959?v=4",
"events_url": "https://api.github.com/users/sahutd/events{/privacy}",
"followers_url": "https://api.github.com/users/sahutd/followers",
"following_url": "https://api.github.com/users/sahutd/following{/other_user}",
"gists_url": "https://api.github.com/users/sahutd/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sahutd",
"id": 5676959,
"login": "sahutd",
"node_id": "MDQ6VXNlcjU2NzY5NTk=",
"organizations_url": "https://api.github.com/users/sahutd/orgs",
"received_events_url": "https://api.github.com/users/sahutd/received_events",
"repos_url": "https://api.github.com/users/sahutd/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sahutd/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sahutd/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sahutd",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-05-14T06:13:53Z
|
2021-09-08T07:00:59Z
|
2015-05-14T06:15:10Z
|
CONTRIBUTOR
|
resolved
|
Issue #2599
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2601/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2601/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2601.diff",
"html_url": "https://github.com/psf/requests/pull/2601",
"merged_at": "2015-05-14T06:15:10Z",
"patch_url": "https://github.com/psf/requests/pull/2601.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2601"
}
| true |
[
"\\o/\n",
"thanks for this! :cake: :sparkles: \n"
] |
https://api.github.com/repos/psf/requests/issues/2600
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2600/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2600/comments
|
https://api.github.com/repos/psf/requests/issues/2600/events
|
https://github.com/psf/requests/issues/2600
| 76,221,981 |
MDU6SXNzdWU3NjIyMTk4MQ==
| 2,600 |
requests silently sends second request and drops first response (auth in use)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/656957?v=4",
"events_url": "https://api.github.com/users/sawall/events{/privacy}",
"followers_url": "https://api.github.com/users/sawall/followers",
"following_url": "https://api.github.com/users/sawall/following{/other_user}",
"gists_url": "https://api.github.com/users/sawall/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sawall",
"id": 656957,
"login": "sawall",
"node_id": "MDQ6VXNlcjY1Njk1Nw==",
"organizations_url": "https://api.github.com/users/sawall/orgs",
"received_events_url": "https://api.github.com/users/sawall/received_events",
"repos_url": "https://api.github.com/users/sawall/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sawall/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sawall/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sawall",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2015-05-14T04:08:07Z
|
2021-09-08T23:04:47Z
|
2015-05-14T05:10:05Z
|
NONE
|
resolved
|
= short version =
When I am using a param and auth with `requests.get()`, `requests` appears to send a second request silently that's missing the param and then shows me the second response when i look at `response.text`.
= long version, with example and dumps =
I've been using requests to play a game. One level involved adding a param to a GET request in order to see hidden content on the webpage. This works fine with curl:
`curl --user natas22:chG9fbe1Tq2eWVMgjYYD1MsfIvN461kJ "http://natas22.natas.labs.overthewire.org/?revelio"`
Strangely, when I try something similar in requests I don't see the same response html text:
```
auth = ('natas22', 'chG9fbe1Tq2eWVMgjYYD1MsfIvN461kJ')
site = 'http://natas22.natas.labs.overthewire.org/?revelio'
r=requests.get(site,auth=auth)
r.text
```
After scanning with tcpdump, it appears that requests is getting the correct response, but then it interacts with the server a second time for some reason. During that second interaction requests fails to send the URL param.
Initial request:
```
22:59:10.459925 IP (tos 0x0, ttl 64, id 27245, offset 0, flags [DF], proto TCP (6), length 331)
XXXXXX.58647 > melinda.labs.overthewire.org.http: Flags [P.], cksum 0x6cdb (correct), seq 1:280, ack 1, win 4117, options [nop,nop,TS val 377042043 ecr 980610639], length 279
..{...|.......E..Kjm@[email protected]_.).3.......l......
.y4{:r.OGET /?revelio HTTP/1.1
Host: natas22.natas.labs.overthewire.org
Connection: keep-alive
Accept: */*
Accept-Encoding: gzip, deflate
Authorization: Basic bmF0YXMyMjpjaEc5ZmJlMVRxMmVXVk1nallZRDFNc2ZJdk40NjFrSg==
User-Agent: python-requests/2.7.0 CPython/2.7.9 Darwin/14.3.0
```
Initial successful response that I never see from the interpreter:
```
22:59:10.579617 IP (tos 0x0, ttl 53, id 61399, offset 0, flags [DF], proto TCP (6), length 1500)
melinda.labs.overthewire.org.http > XXXXXX.58647: Flags [.], cksum 0xed92 (correct), seq 1:1449, ack 280, win 235, options [nop,nop,TS val 980610675 ecr 377042043], length 1448
|.......{[email protected]..._.+............
:r.s.y4{HTTP/1.1 302 Found
Date: Thu, 14 May 2015 03:59:10 GMT
Server: Apache/2.4.7 (Ubuntu)
X-Powered-By: PHP/5.5.9-1ubuntu4.9
Set-Cookie: PHPSESSID=p6ls9fd6jqaveoha3vc4kav7g0; path=/; HttpOnly
Expires: Thu, 19 Nov 1981 08:52:00 GMT
Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0
Pragma: no-cache
Location: /
Content-Length: 1049
Keep-Alive: timeout=5, max=100
Connection: Keep-Alive
Content-Type: text/html
<html>
[html page that I want]
```
Unlike curl, after this `requests` immediately sends some traffic back for reasons that are unclear to me. Note the `r.sGET / HTTP/1.1` line is missing the revelio param:
```
22:59:10.579704 IP (tos 0x0, ttl 64, id 53914, offset 0, flags [DF], proto TCP (6), length 52)
XXXXXX.58647 > melinda.labs.overthewire.org.http: Flags [.], cksum 0x4bc7 (correct), seq 280, ack 1497, win 4071, options [nop,nop,TS val 377042162 ecr 980610675], length 0
..{...|.......E..4..@[email protected]_.+.3.......K......
.y4.:r.s
22:59:10.584887 IP (tos 0x0, ttl 64, id 54853, offset 0, flags [DF], proto TCP (6), length 369)
XXXXXX.58647 > melinda.labs.overthewire.org.http: Flags [P.], cksum 0x2c85 (correct), seq 280:597, ack 1497, win 4096, options [nop,nop,TS val 377042167 ecr 980610675], length 317
..{...|.......E..q.E@[email protected]_.+.3.......,......
.y4.:r.sGET / HTTP/1.1
Host: natas22.natas.labs.overthewire.org
Accept-Encoding: gzip, deflate
Accept: */*
User-Agent: python-requests/2.7.0 CPython/2.7.9 Darwin/14.3.0
Connection: keep-alive
Cookie: PHPSESSID=p6ls9fd6jqaveoha3vc4kav7g0
Authorization: Basic bmF0YXMyMjpjaEc5ZmJlMVRxMmVXVk1nallZRDFNc2ZJdk40NjFrSg==
```
The server then responds with a gzipped version of the page, which is what ends up being what requests shows me when I type `r.text`:
```
22:59:10.707316 IP (tos 0x0, ttl 53, id 61401, offset 0, flags [DF], proto TCP (6), length 843)
melinda.labs.overthewire.org.http > XXXXXX.58647: Flags [P.], cksum 0x8233 (correct), seq 1497:2288, ack 597, win 243, options [nop,nop,TS val 980610713 ecr 377042167], length 791
|.......{[email protected]..._.,>.....3.....
:r...y4.HTTP/1.1 200 OK
Date: Thu, 14 May 2015 03:59:10 GMT
Server: Apache/2.4.7 (Ubuntu)
X-Powered-By: PHP/5.5.9-1ubuntu4.9
Expires: Thu, 19 Nov 1981 08:52:00 GMT
Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0
Pragma: no-cache
Vary: Accept-Encoding
Content-Encoding: gzip
Content-Length: 383
Keep-Alive: timeout=5, max=99
Connection: Keep-Alive
Content-Type: text/html
```
Why is `requests` making this second request and dropping the param on the floor?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2600/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2600/timeline
| null |
completed
| null | null | false |
[
"Out of curiosity I checked to see if the problem persisted if I gave the param a value (i.e., `site = 'http://natas22.natas.labs.overthewire.org/?revelio=foo'`). I'm still experiencing the same pattern.\n",
"Because we got redirected. =)\n\nThe first response is a HTTP 302, which means 'the target resource resides under another URI'. Per RFC 7231, we follow that redirect, making another request with the URL set to the value of the 'Location' header on the 302. By default curl does not follow redirects: by default we do. To get curl to do what we do, pass it the `-L` command line flag. To get us to behave like curl, set `allow_redirects=False` in your call to `requests.get`.\n",
"Oh thanks! I didn't think to look at the return code. :)\n"
] |
https://api.github.com/repos/psf/requests/issues/2599
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2599/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2599/comments
|
https://api.github.com/repos/psf/requests/issues/2599/events
|
https://github.com/psf/requests/issues/2599
| 76,019,537 |
MDU6SXNzdWU3NjAxOTUzNw==
| 2,599 |
Auth handler should be calling close, not release_conn
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
[
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
},
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
},
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"name": "Contributor Friendly",
"node_id": "MDU6TGFiZWwxOTEyNzQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Contributor%20Friendly"
}
] |
closed
| true | null |
[] | null | 2 |
2015-05-13T15:10:24Z
|
2021-09-08T23:04:48Z
|
2015-05-14T06:15:18Z
|
CONTRIBUTOR
|
resolved
|
On [this line](https://github.com/kennethreitz/requests/blob/956ec8321a76f0b5a9f5bcb591cf6e77d773f819/requests/auth.py#L182) we should be using the response's "close" method. We shouldn't be explicitly calling a method on the "raw" attribute.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2599/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2599/timeline
| null |
completed
| null | null | false |
[
"Resolved in #2601.\n",
"Should I add a test to ensure close gets called?\nWould using a mock object be the right way?\n"
] |
https://api.github.com/repos/psf/requests/issues/2598
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2598/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2598/comments
|
https://api.github.com/repos/psf/requests/issues/2598/events
|
https://github.com/psf/requests/pull/2598
| 75,861,193 |
MDExOlB1bGxSZXF1ZXN0MzUyOTY4OTc=
| 2,598 |
Partially revert ab84f9be5740d4649d734e73b84f17f85e52ffc9
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[] |
closed
| true |
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
[
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
] | null | 8 |
2015-05-13T06:08:49Z
|
2021-09-08T07:00:58Z
|
2015-05-14T22:32:19Z
|
MEMBER
|
resolved
|
As discussed in the comments for ab84f9be5740d4649d734e73b84f17f85e52ffc9, this code block is necessary thanks to our shiny `json` parameter.
As a temporary workaround, this reinstates the code Kenneth hates so much so that the builds start working again. @kennethreitz feel free to replace this with something else longer term if you still hate it. :grin:
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2598/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2598/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2598.diff",
"html_url": "https://github.com/psf/requests/pull/2598",
"merged_at": "2015-05-14T22:32:19Z",
"patch_url": "https://github.com/psf/requests/pull/2598.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2598"
}
| true |
[
"`import json as notsimplejson` :P\n",
"`import json as complexjson`? :grin:\n",
"`import json as _json` Really anything to make sure this works properly is a good thing.\n",
"ping @sigmavirus24 \n",
":+1: but the tests still seem to be broken because other things were relying on `json` being a module defined in `requests/models.py` http://ci.kennethreitz.org/job/requests-pr/662/PYTHON=2.7/console\n",
"I'm doubling down on complexjson here.\n",
":cake: \n",
"Forgot something...\n\n:sparkles: :cake: :sparkles: \n"
] |
https://api.github.com/repos/psf/requests/issues/2597
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2597/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2597/comments
|
https://api.github.com/repos/psf/requests/issues/2597/events
|
https://github.com/psf/requests/pull/2597
| 75,776,064 |
MDExOlB1bGxSZXF1ZXN0MzUyODA5OTA=
| 2,597 |
do not blindly catch all AttributeErrors
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/717901?v=4",
"events_url": "https://api.github.com/users/t-8ch/events{/privacy}",
"followers_url": "https://api.github.com/users/t-8ch/followers",
"following_url": "https://api.github.com/users/t-8ch/following{/other_user}",
"gists_url": "https://api.github.com/users/t-8ch/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/t-8ch",
"id": 717901,
"login": "t-8ch",
"node_id": "MDQ6VXNlcjcxNzkwMQ==",
"organizations_url": "https://api.github.com/users/t-8ch/orgs",
"received_events_url": "https://api.github.com/users/t-8ch/received_events",
"repos_url": "https://api.github.com/users/t-8ch/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/t-8ch/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/t-8ch/subscriptions",
"type": "User",
"url": "https://api.github.com/users/t-8ch",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-05-12T23:22:24Z
|
2021-09-08T07:00:59Z
|
2015-05-13T06:16:44Z
|
CONTRIBUTOR
|
resolved
|
see shazow/urllib3#618
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2597/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2597/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2597.diff",
"html_url": "https://github.com/psf/requests/pull/2597",
"merged_at": "2015-05-13T06:16:44Z",
"patch_url": "https://github.com/psf/requests/pull/2597.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2597"
}
| true |
[
"So, perhaps this is a stupid question, by why is there this condition in the code in the first place?\n",
"It's to allow you to return file-like objects that aren't urllib3's HTTPResponse class. This is super common in tests, for example.\n\nThis LGTM.\n"
] |
https://api.github.com/repos/psf/requests/issues/2596
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2596/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2596/comments
|
https://api.github.com/repos/psf/requests/issues/2596/events
|
https://github.com/psf/requests/issues/2596
| 75,665,167 |
MDU6SXNzdWU3NTY2NTE2Nw==
| 2,596 |
colon in get params is double encoded
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/37143?v=4",
"events_url": "https://api.github.com/users/makoshark/events{/privacy}",
"followers_url": "https://api.github.com/users/makoshark/followers",
"following_url": "https://api.github.com/users/makoshark/following{/other_user}",
"gists_url": "https://api.github.com/users/makoshark/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/makoshark",
"id": 37143,
"login": "makoshark",
"node_id": "MDQ6VXNlcjM3MTQz",
"organizations_url": "https://api.github.com/users/makoshark/orgs",
"received_events_url": "https://api.github.com/users/makoshark/received_events",
"repos_url": "https://api.github.com/users/makoshark/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/makoshark/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/makoshark/subscriptions",
"type": "User",
"url": "https://api.github.com/users/makoshark",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2015-05-12T16:44:14Z
|
2021-09-08T23:04:48Z
|
2015-05-12T16:53:38Z
|
NONE
|
resolved
|
Thanks for maintaining requests! I love it!
If a parameters in <code>params</code> passed to <code>get()</code> includes a colon (as is required for categories in the MediaWiki AP, for exampleI) requests double encodes it. Here's some example code:
```
import requests
parameters = {'action' : 'query',
'list' : 'categorymembers',
'format' : 'json',
'cmtitle' : 'Category:London'}
r = requests.get('http://wikivoyage.org/w/api.php', params=parameters)
print(r.url)
```
This returns a double escaped colon as <code>http://en.wikivoyage.org/w/api.php?action=query&cmtitle=Category%253ALondon&list=categorymembers&format=json</code>.
A working URL would be: <code>http://en.wikivoyage.org/w/api.php?action=query&cmtitle=Category%3ALondon&list=categorymembers&format=json</code> or even the unescaped <code>http://en.wikivoyage.org/w/api.php?action=query&cmtitle=Category:London&list=categorymembers&format=json</code>, both of which work fine.
Shouldn't a colon in a parameter only be escaped once as "<code>%3A</code>"? Composing the URL and passing it directly in seems to work just fine.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2596/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2596/timeline
| null |
completed
| null | null | false |
[
"Requests does not double encode the colon. =)\n\nWhat you don't see in that code is that you've been redirected. That URL is actually where you ended up after a chain of redirects. If you look for the _first_ request in the chain, you'll see the correct URL:\n\n``` python\n>>> r.history[0].url\nu'http://wikivoyage.org/w/api.php?action=query&cmtitle=Category%3ALondon&list=categorymembers&format=json'\n```\n",
"Got it! Thanks for the incredibly quick response and resolution! The URL seems to also be correct in the second step in the chain.\n\nIs this a bug in the redirect code that WikiVoyage is using or is this an unavoidable side effect of relying on the 301s? This is simple enough to fix on my end but I'm wondering if I should file a ticket with the Wikimedia Foundation.\n",
"I think the bug is with WikiVoyage, it seems to be incorrectly parsing the URLs. The bug is not in the first redirect (from wikivoyage.org to www.wikivoyage.org), but in the second redirect (from www.wikivoyage.org to en.wikivoyage.org). You can therefore probably avoid the bug in your own code by going straight there, and then file a bug with whomever is managing that code to check why it mishandles URL escaping.\n",
"Thanks! I had already fixed the bug by avoiding the redirects but I wanted to let Wikimedia (who run WikiVoyage) about the issue so that others who make the same mistake don't run into the issue.\n\nThanks again for your help!\n"
] |
https://api.github.com/repos/psf/requests/issues/2595
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2595/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2595/comments
|
https://api.github.com/repos/psf/requests/issues/2595/events
|
https://github.com/psf/requests/issues/2595
| 75,352,263 |
MDU6SXNzdWU3NTM1MjI2Mw==
| 2,595 |
UnicodeEncodeError handling gzipped responses on Google App Engine
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/963973?v=4",
"events_url": "https://api.github.com/users/agfor/events{/privacy}",
"followers_url": "https://api.github.com/users/agfor/followers",
"following_url": "https://api.github.com/users/agfor/following{/other_user}",
"gists_url": "https://api.github.com/users/agfor/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/agfor",
"id": 963973,
"login": "agfor",
"node_id": "MDQ6VXNlcjk2Mzk3Mw==",
"organizations_url": "https://api.github.com/users/agfor/orgs",
"received_events_url": "https://api.github.com/users/agfor/received_events",
"repos_url": "https://api.github.com/users/agfor/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/agfor/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/agfor/subscriptions",
"type": "User",
"url": "https://api.github.com/users/agfor",
"user_view_type": "public"
}
|
[
{
"color": "fbca04",
"default": false,
"description": null,
"id": 615414998,
"name": "GAE Support",
"node_id": "MDU6TGFiZWw2MTU0MTQ5OTg=",
"url": "https://api.github.com/repos/psf/requests/labels/GAE%20Support"
}
] |
closed
| true | null |
[] | null | 17 |
2015-05-11T20:45:32Z
|
2021-09-08T09:00:49Z
|
2015-05-12T18:15:48Z
|
NONE
|
resolved
|
https://github.com/braintree/braintree_python/issues/53 originally reported the issue. It's due to using requests 2.6.1+, which pulled in a version of urllib3 including f21c2a2b73e4256ba2787f8470dbee6872987d2d, which causes the problem.
I am able to reproduce using app engine development mode when switching https://github.com/agfor/braintree-python-appengine to use requests 2.6.1+ and un-commenting out the development mode enabling code in main.py.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2595/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2595/timeline
| null |
completed
| null | null | false |
[
"Have you tried requests 2.7.0? That fixed a number of problems associated with that urllib3 release.\n",
"@Lukasa The problem happens in requests 2.7.0 as well -- all released versions after 2.6.0. The problem is in urllib3 versions before https://github.com/shazow/urllib3/commit/22a9713fab2ed831204711906a974c3beba3319e, so would be fixed by merging in a more recent urllib3.\n",
"@agfor https://github.com/shazow/urllib3/commit/22a9713fab2ed831204711906a974c3beba3319e should be in 2.7.0.\n",
"@sigmavirus24 @Lukasa It looks like there are actually two different problems, and that commit only fixed one. With requests 2.6.2 / urllib3 before https://github.com/shazow/urllib3/commit/22a9713fab2ed831204711906a974c3beba3319e it blows up inside requests:\n\n```\n File \"/Users/agf/projects/appengine/braintree-python/requests/api.py\", line 108, in post\n return request('post', url, data=data, json=json, **kwargs)\n File \"/Users/agf/projects/appengine/braintree-python/requests/api.py\", line 50, in request\n response = session.request(method=method, url=url, **kwargs)\n File \"/Users/agf/projects/appengine/braintree-python/requests/sessions.py\", line 465, in request\n resp = self.send(prep, **send_kwargs)\n File \"/Users/agf/projects/appengine/braintree-python/requests/sessions.py\", line 605, in send\n r.content\n File \"/Users/agf/projects/appengine/braintree-python/requests/models.py\", line 750, in content\n self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes()\n File \"/Users/agf/projects/appengine/braintree-python/requests/models.py\", line 673, in generate\n for chunk in self.raw.stream(chunk_size, decode_content=True):\n File \"/Users/agf/projects/appengine/braintree-python/requests/packages/urllib3/response.py\", line 304, in stream\n for line in self.read_chunked(amt):\n File \"/Users/agf/projects/appengine/braintree-python/requests/packages/urllib3/response.py\", line 401, in read_chunked\n line = line.decode()\nUnicodeDecodeError: 'ascii' codec can't decode byte 0x8b in position 1: ordinal not in range(128)\n```\n\nbut after that commit / in 2.7.0, we blow up later inside the Braintree library. This appears to be because requests has tried to convert gzipped data to Unicode as if it had already been un-gzipped, and so replaced most of it with the unicode replacement character:\n\n```\n File \"/Users/agf/projects/appengine/braintree-python/braintree/util/http.py\", line 73, in __http_do\n return XmlUtil.dict_from_xml(response_body)\n File \"/Users/agf/projects/appengine/braintree-python/braintree/util/xml_util.py\", line 11, in dict_from_xml\n return Parser(xml).parse()\n File \"/Users/agf/projects/appengine/braintree-python/braintree/util/parser.py\", line 15, in __init__\n self.doc = minidom.parseString(\"><\".join(re.split(\">\\s+<\", xml)).strip())\n File \"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/dom/minidom.py\", line 1924, in parseString\n return expatbuilder.parseString(string)\n File \"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/dom/expatbuilder.py\", line 940, in parseString\n return builder.parseString(string)\n File \"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/dom/expatbuilder.py\", line 223, in parseString\n parser.Parse(string, True)\nUnicodeEncodeError: 'ascii' codec can't encode character u'\\ufffd' in position 0: ordinal not in range(128)\n```\n\nexample unicode code points for the response body:\n\n```\n[31, 65533, 8, 0, 65533, 51, 81, 85, 0, 3, 65533, 88, 77, 111, 65533, 54, 16, 65533, 65533, 48, 124, 103, 36, 123, 65533, 32, 27, 40, 10, 10, 20, 5, 1698, 64, 65533, 77, 65533, 65533, 94, 2, 90, 28, 91, 108, 40, 65533, 37, 41, 65533, 943, 65533, 65533, 65533, 20, 81, 73, 78, 69, 15, 65533, 602, 121, 28, 14, 103, 65533, 51, 65533, 65533, 58261, 88, 28, 65533, 88, 65533, 65533, 65533, 114, 117, 65533, 46, 23, 32, 11, 376, 65533, 65533, 46, 31, 65533, 127, 34, 65533, 763, 65533, 83, 65533, 12, 65533, 65533, 22, 14, 81, 65533, 65533, 65533, 34, 65533, 44, 65533, 65533, 65533, 65533, 65533, 89, 65533, 63, 65533, 65533, 58, 65533, 106, 65533, 65533, 1685, 65533, 65533, 23, 96, 89, 1162, 65533, 1437, 52, 65533, 10, 530, 65533, 65533, 714, 65533, 24, 65533, 65533, 68, 65533, 85, 4, 65533, 65533, 65533, 65533, 65533, 89, 50, 21, 123, 48, 65533, 84, 45, 93, 65533, 74, 47, 65533, 52, 75, 65533, 47, 65533, 65533, 65533, 20, 37, 65533, 65533, 1058, 65533, 66, 65533, 65533, 84, 87, 5, 65533, 65533, 126, 65533, 47, 65533, 65533, 65533, 65533, 85, 65533, 37, 49, 65533, 95, 65533, 12, 3, 65533, 31, 11, 65533, 65533, 65533, 1177, 26, 65533, 73, 65533, 1, 65533, 17, 65533, 22, 65533, 65533, 65533, 37, 65533, 79, 65533, 43, 88, 65533, 65533, 116, 65533, 33, 37292, 86, 65533, 65533, 65533, 65533, 65533, 65533, 102, 115, 65533, 39, 65533, 65533, 47, 8, 65533, 107, 65533, 62, 65533, 126, 65533, 65533, 65533, 11, 65533, 65533, 88, 65533, 65533, 107, 65533, 17, 65533, 65533, 65533, 67, 20, 60977, 65533, 72, 90, 65, 68, 41, 36654, 80, 65533, 65533, 65533, 20, 65533, 64, 69, 65533, 65533, 543, 97, 107, 65533, 65533, 65533, 1189, 65533, 49, 65533, 65533, 30, 39, 65, 77, 65533, 65533, 694, 92, 8, 44, 65533, 127, 65533, 65533, 65533, 25, 0, 65533, 3, 65533, 12, 88, 27, 11, 65533, 1089, 100, 62, 19, 65533, 16, 65533, 10, 42, 65533, 65533, 65533, 55, 65533, 65533, 59, 18, 65533, 65533, 65533, 65533, 32, 66, 65, 71, 65533, 354, 52, 65533, 65533, 65533, 52, 106, 65533, 65533, 80, 65533, 75, 65533, 65533, 16, 65533, 65533, 123, 40, 89, 99, 54, 120, 49, 65533, 65533, 32, 57, 120, 65533, 93, 45, 89, 65533, 65533, 26, 65533, 86, 57, 53, 65533, 65533, 70, 74, 12, 65533, 121, 268, 88, 112, 78, 64, 5, 120, 43, 65533, 65533, 21, 101, 20, 83, 114, 65533, 65533, 47, 65533, 65533, 104, 65533, 12, 65533, 65533, 118, 46, 65533, 65533, 32, 65533, 109, 0, 65533, 96, 9, 24, 65533, 12, 65533, 24, 105, 37, 45, 68, 65533, 22, 112, 65533, 65533, 65533, 65533, 65533, 65533, 65533, 65533, 65533, 4, 116, 38, 65533, 89, 65533, 91, 121, 19, 19, 65533, 113, 56, 76, 87, 78, 65533, 30, 65533, 65533, 65533, 65533, 76, 79, 65533, 65533, 11, 65533, 42, 65533, 89, 96, 65533, 65533, 884, 81, 5, 65533, 113, 65533, 65533, 36, 13, 65533, 96, 65533, 65533, 95, 127, 65533, 65533, 37, 75, 65533, 4, 65533, 65533, 65533, 93, 89, 65533, 126, 52, 65533, 105, 103, 86, 58, 65533, 65533, 65533, 7, 65533, 65533, 65533, 31, 65533, 115, 65533, 16, 90, 440, 65533, 4, 65533, 63, 65533, 77, 65533, 122, 80, 65533, 65533, 9, 65533, 97, 65533, 113, 5, 65533, 65533, 22, 65533, 52, 34, 65533, 65533, 760, 75, 51, 65533, 103, 80, 65533, 30, 73, 51, 65533, 42, 56, 66, 65533, 65533, 57, 65533, 85, 74, 0, 65533, 65533, 124, 71, 65533, 65533, 116, 65533, 7, 116, 115, 29, 79, 65, 10, 106, 88, 91, 65533, 78, 61, 65, 65533, 14, 110, 65533, 65533, 47, 87, 65533, 65533, 119, 67, 57, 65533, 35, 65533, 121, 35, 110, 63, 1707, 65533, 38, 73, 32, 55, 127, 112, 75, 65533, 86, 65533, 65533, 85, 104, 110, 65533, 84, 86, 74, 65533, 50, 79, 55, 89, 50, 17, 78, 65533, 39, 65533, 6, 41, 65533, 58, 29, 65533, 65533, 65533, 1911, 65533, 65533, 65533, 55, 65533, 64, 65533, 30, 65533, 65533, 39, 65533, 89, 122, 65533, 65533, 84, 34, 4, 59, 65533, 62, 120, 69, 65533, 64, 106, 35, 65533, 65533, 57, 109, 111, 65533, 65533, 90, 108, 65533, 65533, 98, 107, 40, 65533, 65533, 1716, 65533, 126, 65533, 125, 51, 65533, 65533, 65533, 59, 65533, 99, 5, 88, 65533, 65533, 81, 65533, 65533, 74, 14, 120, 65533, 11, 45, 65533, 119, 32, 15, 65533, 40, 65533, 1, 65533, 65533, 74, 65533, 85, 71, 17149, 65533, 102, 65533, 90, 65533, 107, 104, 83, 65533, 65533, 31, 65533, 28, 65533, 484, 10, 66, 65533, 65533, 65533, 65533, 65533, 30, 65533, 84, 65533, 1175, 107, 35, 104, 65533, 37, 80, 65533, 74, 60, 33, 65533, 17, 3, 89, 3, 98, 65533, 65533, 65533, 111, 62, 91, 85, 109, 48, 65533, 88, 65533, 65533, 90, 120, 46, 54, 64, 65533, 65533, 65533, 65533, 19, 75, 78, 65533, 25, 58, 65533, 65533, 78, 1235, 81, 98, 65533, 65533, 4, 109, 65533, 65533, 65533, 65533, 117, 65533, 65533, 79, 103, 65533, 72, 58, 110, 65533, 106, 71, 65533, 65533, 65533, 2, 65533, 65533, 78, 65533, 93, 65533, 20, 65533, 65533, 64, 120, 7, 97, 65533, 101, 13, 65533, 0, 65533, 82, 306, 65533, 65533, 75, 65533, 65533, 91, 26, 55, 65533, 68, 45, 65533, 39, 37, 474, 51, 65533, 17, 21, 65533, 7, 105, 64, 0, 26, 106, 65533, 65533, 111, 30, 65533, 97, 84, 84, 65533, 65533, 20, 65533, 65533, 65533, 22, 65533, 124, 116, 4, 65533, 1851, 65533, 41, 61, 65533, 84, 65533, 65533, 119, 65533, 1555, 65533, 87, 66, 65533, 65533, 27, 65533, 22, 65533, 65533, 79, 65, 78, 53, 71, 47, 65533, 65533, 65533, 65533, 65533, 67, 65533, 65533, 54, 48, 77, 65533, 19, 52, 898, 65533, 45, 12, 1523, 44, 105, 65533, 65533, 59, 84, 65533, 104, 68, 65533, 84, 86, 65533, 32, 17, 33, 62, 65533, 65533, 94, 54, 66, 65533, 91, 65533, 69, 65533, 65533, 65533, 125, 124, 65533, 39, 65533, 65533, 35, 4, 65533, 113, 27, 65533, 46, 65533, 65533, 394, 65533, 65533, 65533, 76, 65533, 65533, 123, 62, 96, 127, 65533, 65533, 54, 54, 65533, 65533, 639, 21, 65533, 92, 51, 85, 65533, 65533, 911, 65533, 63, 9, 83, 65533, 65533, 65533, 31, 85, 59, 65533, 65533, 33, 65533, 85, 996, 65533, 65533, 68, 65533, 97, 65533, 65533, 65533, 54, 12, 65533, 65533, 65533, 23, 65533, 65533, 58, 65533, 72, 21, 65533, 832, 65533, 439, 31, 99, 38, 65533, 65533, 15, 65533, 65533, 65533, 3, 65533, 65533, 65533, 65533, 65533, 65533, 92, 29, 43, 21, 73, 91, 65533, 96, 93, 20, 17, 118, 65533, 25, 65533, 57, 65533, 63, 65533, 65533, 29, 65533, 74, 65533, 29, 25, 65533, 75, 36, 97, 117, 65533, 25, 65533, 100, 65533, 85, 30, 125, 87, 594, 57, 1048, 65533, 12, 14, 58, 102, 59, 67, 38, 51, 11, 122, 65533, 86, 65533, 62, 65533, 65533, 65533, 9, 65533, 65533, 65533, 65533, 103, 65533, 65533, 65533, 65533, 65533, 115, 65533, 65533, 65533, 65533, 65533, 75, 65533, 65533, 65533, 91, 65533, 65533, 65533, 36, 1806, 65533, 65533, 65533, 65533, 116, 65533, 727, 118, 43, 9, 97, 29, 89, 65533, 92, 65533, 67, 65533, 65533, 65533, 65533, 12, 24, 65533, 65533, 26, 103, 98, 1300, 65533, 79, 65533, 0, 0, 0, 65533, 65533, 3, 0, 124, 65533, 65533, 65533, 65533, 17, 0, 0]\n```\n\nVersions 2.6.0 and below work.\n",
"> This appears to be because requests has tried to convert gzipped data to Unicode as if it had already been un-gzipped\n\nCan you provide how you're using requests so that we can understand where this comes from?\n",
"The [Braintree client library calls `response.text`](https://github.com/braintree/braintree_python/blob/master/braintree/util/http.py#L82-L90) on a gzip-encoded response from the Braintree gateway to get the decoded response body. It doesn't work properly on Google App Engine, presumably because GAE proxies the request and causes the response to be chunked.\n\nThis diff against 2.7.0 causes things to work as they did on 2.6.0 and earlier:\n\n```\ndiff --git a/requests/models.py b/requests/models.py\nindex 45b3ea9..bbe9437 100644\n--- a/requests/models.py\n+++ b/requests/models.py\n@@ -781,9 +781,13 @@ class Response(object):\n if self.encoding is None:\n encoding = self.apparent_encoding\n\n+ import gzip\n+ content = gzip.GzipFile(fileobj=StringIO(self.content)).read()\n+\n+\n # Decode unicode from given encoding.\n try:\n- content = str(self.content, encoding, errors='replace')\n+ content = str(content, encoding, errors='replace')\n except (LookupError, TypeError):\n # A LookupError is raised if the encoding was not found which could\n # indicate a misspelling or similar mistake.\n@@ -791,7 +795,7 @@ class Response(object):\n # A TypeError can be raised if encoding is None\n #\n # So we try blindly encoding.\n- content = str(self.content, errors='replace')\n+ content = str(content, errors='replace')\n\n return content\n\n```\n\nBut I haven't had time to dig into why the content hasn't been gzip-decoded yet at this point, so I don't have a real fix.\n",
"I really need to find a sample URL, I think.\n",
"@sigmavirus24 @Lukasa I haven't been able to reproduce off of Google App Engine, so here is a minimal GAE repo you can test with the development environment that exhibits the problem: https://github.com/agfor/requests-2.7-appengine-fail\n\nThe core of it is:\n\n```\nimport webapp2\nimport requests\nimport gzip\nfrom StringIO import StringIO\n\n\nURL = \"https://api.sandbox.braintreegateway.com:443/merchants/pgd875t7kmgp5q6x/transactions\"\nHEADERS = {\n 'X-ApiVersion': '4',\n 'Content-type': 'application/xml',\n 'Authorization': 'Basic aHl6a2h4OGRtcDd4Zmc1aDoxZWZiN2YzMWM0ZjM1ODIwNmIxMjk4OTIzYWU0OGE2YQ==',\n 'Accept': 'application/xml',\n 'User-Agent': 'Braintree Python 3.5.0'\n}\nBODY = \"\"\"\n<transaction>\n <amount>10.00</amount>\n <type>sale</type>\n <credit_card>\n <expiration_date>05/2020</expiration_date>\n <number>4111111111111111</number>\n </credit_card>\n</transaction>\n\"\"\"\n\nclass MainHandler(webapp2.RequestHandler):\n def get(self):\n response = requests.post(URL, headers=HEADERS, data=BODY)\n # this is still gzipped data\n print response.content\n # what response.content should be\n print gzip.GzipFile(fileobj=StringIO(response.content)).read()\n # essentially what is blowing up in the braintree library\n response.text.encode('ascii')\n\napp = webapp2.WSGIApplication([\n ('/', MainHandler)\n], debug=True)\n```\n\nIt will dump the still-gzipped response body, and the un-gzipped response body, to the logs, then blow up on the `response.text.encode('ascii')` line, since `text` is producing gibberish full of unicode replacement characters from trying to encode gzipped data as unicode.\n",
"Aha, this is interesting. I also cannot reproduce this, so it's actually important that we're on GAE. It seems like this is going to be caused by GAE being different to stdlib Python.\n\nThis means, unfortunately, that this _is_ a urllib3 issue (requests is unlikely to be at fault here), and in particular I think GAE is screwing this up. Unfortunately, it's screwing it up _silently_, which is doubly bad.\n\n@shazow What's your position on GAE support in urllib3? I know requests considers it an unsupported platform...\n",
"I'd like to support GAE on urllib3. It used to work great, then GAE changed some stuff and now it's not. :/ Needs more investigation.\n",
"Possibly related to https://github.com/shazow/urllib3/issues/583\n",
"@shazow Just to close the loop, I was able to bisect the issue back to https://github.com/shazow/urllib3/commit/f21c2a2b73e4256ba2787f8470dbee6872987d2d specifically.\n",
"Here's a theory: does GAE patch `HTTPResponse.read` to do special GAE things, and our new `read_chunked` method break that?\n",
"Here's a suggestion: Since GAE is a for-profit platform, why doesn't GAE provide support for it for OSS projects that attempt to support it? Or better yet, will they give us an environment to test against and pay us to support it? If not, I'm not certain any of us should be really supporting it.\n",
"@agfor Ah good find, thanks.\n\nFreakin' chunked encoding, breaking errything.\n\nDoes this mean GAE still works for non-chunked/non-streaming?\n\n@sigmavirus24 Lovely idea, any interest in reaching out to the GAE team and asking if they'll fund this? :P\n",
"Alrighty, looks like we're moving this to shazow/urllib3#618.\n",
"There are a few possible of workarounds for this probem:\n1. Use requests 2.6.0 or earlier\n2. Use requests 2.6.1 - 2.7.0 with agfor/requests@da863cc\n3. Use requests 2.7.1+ (when released) with the above patch and agfor/requests@a1847ae\n4. [Switch the GAE httplib to use sockets](https://cloud.google.com/appengine/docs/python/sockets/#making_httplib_use_sockets) by adding this to `app.yaml`:\n\n```\nenv_variables:\n GAE_USE_SOCKETS_HTTPLIB : 'anyvalue'\n```\n\nThat can affect your billing so please be careful before changing it.\n"
] |
https://api.github.com/repos/psf/requests/issues/2594
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2594/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2594/comments
|
https://api.github.com/repos/psf/requests/issues/2594/events
|
https://github.com/psf/requests/issues/2594
| 75,086,835 |
MDU6SXNzdWU3NTA4NjgzNQ==
| 2,594 |
grequest hangs after about 250,000 requests on windows 7
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1405491?v=4",
"events_url": "https://api.github.com/users/fivejjs/events{/privacy}",
"followers_url": "https://api.github.com/users/fivejjs/followers",
"following_url": "https://api.github.com/users/fivejjs/following{/other_user}",
"gists_url": "https://api.github.com/users/fivejjs/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/fivejjs",
"id": 1405491,
"login": "fivejjs",
"node_id": "MDQ6VXNlcjE0MDU0OTE=",
"organizations_url": "https://api.github.com/users/fivejjs/orgs",
"received_events_url": "https://api.github.com/users/fivejjs/received_events",
"repos_url": "https://api.github.com/users/fivejjs/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/fivejjs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fivejjs/subscriptions",
"type": "User",
"url": "https://api.github.com/users/fivejjs",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 6 |
2015-05-11T04:56:26Z
|
2021-09-08T23:04:48Z
|
2015-05-13T06:59:57Z
|
NONE
|
resolved
|
I was running grequests with 390,000 youtube video urls. But it hang there after about 250, 000 urls.
The error message:
Traceback (most recent call last):
File "D:\Users\189120\AppData\Local\Continuum\Anaconda\lib\site-packages\gevent\greenlet.py", line 327, in run
result = self._run(_self.args, *_self.kwargs)
File "D:\Users\189120\AppData\Local\Continuum\Anaconda\lib\site-packages\grequests.py", line 71, in send
self.url, *_merged_kwargs)
File "D:\Users\189120\AppData\Local\Continuum\Anaconda\lib\site-packages\requests\sessions.py", line 464, in request
resp = self.send(prep, *_send_kwargs)
File "D:\Users\189120\AppData\Local\Continuum\Anaconda\lib\site-packages\requests\sessions.py", line 576, in send
r = adapter.send(request, **kwargs)
File "D:\Users\189120\AppData\Local\Continuum\Anaconda\lib\site-packages\requests\adapters.py", line 424, in send
raise ConnectionError(e, request=request)
ConnectionError: HTTPSConnectionPool(host='www.googleapis.com', port=443): Max retries exceeded with url: /youtube/v3/videos?part=snippet&id=nv85S4L0kTU&key=xxxxxx (Caused by ProxyError('Cannot connect to proxy.', error(10053, 'An established connection was aborted by the software in your host machine')))
<Greenlet at 0x35eecc0L: <bound method AsyncRequest.send of <grequests.AsyncRequest object at 0x0000000007434128>>(stream=False)> failed with ConnectionError
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1405491?v=4",
"events_url": "https://api.github.com/users/fivejjs/events{/privacy}",
"followers_url": "https://api.github.com/users/fivejjs/followers",
"following_url": "https://api.github.com/users/fivejjs/following{/other_user}",
"gists_url": "https://api.github.com/users/fivejjs/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/fivejjs",
"id": 1405491,
"login": "fivejjs",
"node_id": "MDQ6VXNlcjE0MDU0OTE=",
"organizations_url": "https://api.github.com/users/fivejjs/orgs",
"received_events_url": "https://api.github.com/users/fivejjs/received_events",
"repos_url": "https://api.github.com/users/fivejjs/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/fivejjs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fivejjs/subscriptions",
"type": "User",
"url": "https://api.github.com/users/fivejjs",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2594/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2594/timeline
| null |
completed
| null | null | false |
[
"I'm afraid we need significantly more information to diagnose this. You say 'about' 250,000 URLs: is it consistently 250,000, or does the exact number vary? Do you have any logs from the run? Is there anything in stdout?\n",
"I just repeat the error. Ran the code last night and got it this morning. The youtube key is masked as xxxxxx. \nI run the code behind the Proxy. It would be the proxy problem. But if we can add a connection rebuild (need discussion) function to grequests, that will be perfect.\n\nBTW: python 3.4 got asyncio. Is it possible to use asyncio to replace gevent in this package?\n",
"So in that case the connection is being aborted by one of the other servers, probably the Proxy server.\n\nHow exactly are you using grequests here?\n",
"step 1:\n\n```\ndef req_gen(urls):\n proxies = {\n \"http\": \"http://qfwsg-prod.qantas.com.au:8080\",\n \"https\": \"https://qfwsg-prod.qantas.com.au:8080\"\n }\n\n url = 'https://www.googleapis.com/youtube/v3/videos'\n for cur in urls:\n # because of yield, we need put payload inside the loop\n vid = os.path.basename(cur)\n payload = {'key': 'xxxxxxx',\n 'part': 'snippet',\n 'id': vid}\n #yield grequests.get(url, proxies=proxies, params=payload)\n yield grequests.AsyncRequest('GET', url, proxies=proxies, params=payload)\n```\n\nstep 2:\nloop each 1000 ulrs in about several thousand urls\n\n```\nreqs <- req_gen([1000 urls each time])\n```\n\nstep 3:\n\n```\nfor rs in grequests.map(reqs):\n ....Transfer rs.json() to target data row\n```\n",
"It's hard for me to provide useful advice here. I don't think this is a requests bug: sometimes proxies will refuse connections, and it should be possible to handle them appropriately.\n\nI'm not sure exactly how grequests works here (I've never used it myself) but I suspect it should be possible to iterate manually over the map and retry anything that fails:\n\n``` python\nrqs = grequests.map(reqs)\n\nwhile True:\n try:\n rs = next(rqs)\n except ConnectionError:\n # Do something to retry here, put it on a list or something\n else:\n # Transfer rs.json() to target row\n```\n\nThis is less clean, but lets you handle the errors.\n",
"Thanks for your response.\nThis may be a solution. Close this issue. I will come back to you if I got some useful error message with your method.\n\nPS: It looks like our proxy problem. The code ran smoothly last night. Thanks, @Lukasa \n"
] |
https://api.github.com/repos/psf/requests/issues/2593
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2593/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2593/comments
|
https://api.github.com/repos/psf/requests/issues/2593/events
|
https://github.com/psf/requests/issues/2593
| 74,703,156 |
MDU6SXNzdWU3NDcwMzE1Ng==
| 2,593 |
contextlib.closing(response) is not enough when using sessions and stream = True
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/6313150?v=4",
"events_url": "https://api.github.com/users/Beluki/events{/privacy}",
"followers_url": "https://api.github.com/users/Beluki/followers",
"following_url": "https://api.github.com/users/Beluki/following{/other_user}",
"gists_url": "https://api.github.com/users/Beluki/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Beluki",
"id": 6313150,
"login": "Beluki",
"node_id": "MDQ6VXNlcjYzMTMxNTA=",
"organizations_url": "https://api.github.com/users/Beluki/orgs",
"received_events_url": "https://api.github.com/users/Beluki/received_events",
"repos_url": "https://api.github.com/users/Beluki/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Beluki/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Beluki/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Beluki",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 7 |
2015-05-09T16:03:20Z
|
2021-09-08T22:00:53Z
|
2015-08-31T09:35:35Z
|
NONE
|
resolved
|
The requests documentation suggests using the following idiom to partially read response bodies (e.g. when stream = True):
``` python
from contextlib import closing
with closing(requests.get('http://httpbin.org/get', stream=True)) as r:
# Do things with the response here.
```
I thought this would be applicable to sessions, but it seems it's not enough.
The following program reliably raises an exception (BadStatusLine) even while it uses contextlib.closing, and the only way to stop that from happening is to consume the whole response content:
``` python
import contextlib
import random
import requests
urls = [
'http://reddit.com',
'http://news.ycombinator.com',
'http://github.com',
'http://bitbucket.org',
]
try:
session = requests.Session()
while True:
try:
with contextlib.closing(session.get(random.choice(urls), stream = True)) as r:
# uncomment the line below and the errors dissapear:
# r.content
pass
except Exception as ex:
print(str(ex))
except KeyboardInterrupt:
pass
```
Is this the expected behavior or actually a bug? (to be fair the documentation doesn't actually say that the idiom is also applicable to requests coming from sessions).
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2593/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2593/timeline
| null |
completed
| null | null | false |
[
"I think this is expected, but it could arguably be worked around.\n\nThe problem is that urllib3 doesn't know whether we consumed the response, so it doesn't know that the socket has unread data in it. We should be able to support that case, I think.\n",
"Wait. I have a question.\n\nIn your first example, you have a comment \"Do things with the response here\". If you put that in your while loop with a \"pass\" statement, do you see the same behaviour? If so, this issue seems a bit misleading as it is currently presented.\n",
"Hi.\n\n> In your first example, you have a comment \"Do things with the response here\". If you put that in your while loop with a \"pass\" statement, do you see the same behaviour?\n\nThe errors disappear if:\n\n``` python\n# I just use requests.get instead of sessions:\nwith contextlib.closing(requests.get(random.choice(urls), stream = True)) as r:\n # no need to consume the whole content, no errors:\n pass\n```\n\n``` python\n# I use sessions but I consume the whole response body:\nwith contextlib.closing(session.get(random.choice(urls), stream = True)) as r:\n r.content\n```\n\nIn other words, the problem is that `closing(requests.get(...), stream = True)` is always safe regardless of the content, but `closing(session.get(...), stream = True)` is not, you must consume the response content.\n",
"Just so that everything is as clear as possible:\n\nThe [documentation](http://docs.python-requests.org/en/latest/user/advanced/#body-content-workflow) states that `closing(requests.get(..., stream = True))` is safe. This works well, but it may lead an user to assume that `closing(session.get(..., stream = True))` is also safe.\n\nThis is not true as can be seen by running the program in my first post. It eventually raises an exception with a BadStatusLine. When using a session, you have to consume the content, calling `response.close()` is not enough.\n\nUnfortunately, this may lead to hard to reproduce bugs in user's code. You need a program like the one in the first post (or in my use case a multithreaded link crawler) to reproduce it consistently. \n\nI can see two solutions:\n- Be explicit in the documentation and state that `closing(session.get(...), stream = True)` is unsafe.\n- Always consume the content when `response.close()` is called.\n",
"I think blindly consuming the content when `response.close()` is called is a bad idea, because it could potentially take an unbounded amount of time to complete. If `response.close()` is called without having drained the response, we should close the underlying connection instead.\n",
"Yeah, that seems a way better solution.\n",
"Fixed by #2610.\n"
] |
https://api.github.com/repos/psf/requests/issues/2592
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2592/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2592/comments
|
https://api.github.com/repos/psf/requests/issues/2592/events
|
https://github.com/psf/requests/issues/2592
| 73,242,223 |
MDU6SXNzdWU3MzI0MjIyMw==
| 2,592 |
Redundancy when requesting URLs
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1908620?v=4",
"events_url": "https://api.github.com/users/cornelinux/events{/privacy}",
"followers_url": "https://api.github.com/users/cornelinux/followers",
"following_url": "https://api.github.com/users/cornelinux/following{/other_user}",
"gists_url": "https://api.github.com/users/cornelinux/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cornelinux",
"id": 1908620,
"login": "cornelinux",
"node_id": "MDQ6VXNlcjE5MDg2MjA=",
"organizations_url": "https://api.github.com/users/cornelinux/orgs",
"received_events_url": "https://api.github.com/users/cornelinux/received_events",
"repos_url": "https://api.github.com/users/cornelinux/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cornelinux/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cornelinux/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cornelinux",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-05-05T08:05:16Z
|
2021-09-08T23:04:49Z
|
2015-05-05T08:33:31Z
|
NONE
|
resolved
|
This is just a question I'd like to mark as feature request.
Is it ever planned to provide some kind of redundancy - i.e. add a list or URLs to the Request Object and the Request Object would try to fetch the next URL, if the first one timed out.
This might be interesting if requesting web APIs, where redundancy is not provided by the service.
Just tell if this is a bad idea.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2592/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2592/timeline
| null |
completed
| null | null | false |
[
"Thanks for the feature request @cornelinux!\n\nThis seems like the kind of thing that could easily be built on top of requests. =) If a `Session` object is used, it shouldn't be hard to write a little wrapper around it that does exactly that.\n\nHowever, I don't think we'll be adding this feature to requests core, as we're in an indefinitely feature freeze. Sorry!\n"
] |
https://api.github.com/repos/psf/requests/issues/2591
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2591/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2591/comments
|
https://api.github.com/repos/psf/requests/issues/2591/events
|
https://github.com/psf/requests/issues/2591
| 73,086,681 |
MDU6SXNzdWU3MzA4NjY4MQ==
| 2,591 |
Session post() sending a GET instead of a POST intermittently
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/648320?v=4",
"events_url": "https://api.github.com/users/kkochis/events{/privacy}",
"followers_url": "https://api.github.com/users/kkochis/followers",
"following_url": "https://api.github.com/users/kkochis/following{/other_user}",
"gists_url": "https://api.github.com/users/kkochis/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kkochis",
"id": 648320,
"login": "kkochis",
"node_id": "MDQ6VXNlcjY0ODMyMA==",
"organizations_url": "https://api.github.com/users/kkochis/orgs",
"received_events_url": "https://api.github.com/users/kkochis/received_events",
"repos_url": "https://api.github.com/users/kkochis/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kkochis/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kkochis/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kkochis",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-05-04T18:07:46Z
|
2021-09-08T23:04:49Z
|
2015-05-04T18:40:58Z
|
NONE
|
resolved
|
I can't figure out how this would be happening by looking into the source code but here is the behavior I am seeing:
```
>>> import requests
>>> s = requests.Session()
>>> r = s.post('http://mydomain.com/login/attempt', data={'username': 'user', 'password': 'pass'})
>>> r.request
<PreparedRequest [POST]>
>>> r2 = s.post('http://mydomain.com/api/v1/something', data={'name': 'foobar'})
>>> r2.request
<PreparedRequest [GET]>
>>> r3 = s.post('http://mydomain.com/api/v1/something', data={'name': 'foobar'})
>>> r3.request
<PreparedRequest [POST]>
```
I'm using Requests 2.7.0. Let me know if I should provide any other debug information.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/648320?v=4",
"events_url": "https://api.github.com/users/kkochis/events{/privacy}",
"followers_url": "https://api.github.com/users/kkochis/followers",
"following_url": "https://api.github.com/users/kkochis/following{/other_user}",
"gists_url": "https://api.github.com/users/kkochis/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kkochis",
"id": 648320,
"login": "kkochis",
"node_id": "MDQ6VXNlcjY0ODMyMA==",
"organizations_url": "https://api.github.com/users/kkochis/orgs",
"received_events_url": "https://api.github.com/users/kkochis/received_events",
"repos_url": "https://api.github.com/users/kkochis/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kkochis/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kkochis/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kkochis",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2591/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2591/timeline
| null |
completed
| null | null | false |
[
"`Session.post` is not sending a GET, you're being redirected. Check `r.history` for each one.\n",
"Thank you! user error.\n"
] |
https://api.github.com/repos/psf/requests/issues/2590
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2590/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2590/comments
|
https://api.github.com/repos/psf/requests/issues/2590/events
|
https://github.com/psf/requests/issues/2590
| 72,993,352 |
MDU6SXNzdWU3Mjk5MzM1Mg==
| 2,590 |
PATCH get response 301(moved permanently) is redirected with empty body
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3015139?v=4",
"events_url": "https://api.github.com/users/sainttail/events{/privacy}",
"followers_url": "https://api.github.com/users/sainttail/followers",
"following_url": "https://api.github.com/users/sainttail/following{/other_user}",
"gists_url": "https://api.github.com/users/sainttail/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sainttail",
"id": 3015139,
"login": "sainttail",
"node_id": "MDQ6VXNlcjMwMTUxMzk=",
"organizations_url": "https://api.github.com/users/sainttail/orgs",
"received_events_url": "https://api.github.com/users/sainttail/received_events",
"repos_url": "https://api.github.com/users/sainttail/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sainttail/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sainttail/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sainttail",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] |
{
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
}
| 18 |
2015-05-04T11:14:05Z
|
2021-09-08T13:05:40Z
|
2016-12-12T16:10:44Z
|
NONE
|
resolved
|
I don't know this is normal behaviour or not but any reason to set body to empty with patch?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2590/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2590/timeline
| null |
completed
| null | null | false |
[
"What kind of body are you sending?\n",
"i sent something like this\n`r = requests.patch(url, data={\"data\": \"test\"})`\n",
"I think we're a bit over-zealous with stripping bodies on redirects. In #1084 we allowed 307 and 308 to keep their bodies, but all other redirects lose theirs. Arguably, a 301 for a non-POST should also behave the same way. Assigning this to 3.0.0, because it'd be a breaking change.\n",
"Same for response 302.\n",
"<blockquote>I think we're a bit over-zealous with stripping bodies on redirects.</blockquote>\n\nOut of interest, why would you _ever_ strip bodies?\n",
"On a redirect? Consider being redirected to a different domain that you did not want to send that body to... That is why we tend to be overzealous\n",
"If you don't want to send the body to the new location, presumably, you don't want to send the request at all. Either preserving the body or raising an exception would be sensible behavior. Sending an altogether _different_ request to the new location makes no sense at all, IMHO. Certainly not as default behavior.\n\n-------- Original message --------\nFrom: Ian Cordasco [email protected] \nDate: \nTo: kennethreitz/requests [email protected] \nCc: Kilian Evang [email protected] \nSubject: Re: [requests] PATCH get response 301(moved permanently) is redirected with empty body (#2590) \n\nOn a redirect? Consider being redirected to a different domain that you did not want to send that body to... That is why we tend to be overzealous\n\n—\nReply to this email directly or view it on GitHub.\n",
"> Out of interest, why would you ever strip bodies?\n\nWell that's easy, really. A very common pattern is to POST to some endpoint, receive a 302, and GET the location from the 302. You obviously want to strip the body in that case.\n\n> Sending an altogether _different_ request to the new location makes no sense at all, IMHO. Certainly not as default behavior.\n\nAgain, sure it does. That's exactly what many redirects _are_. Status codes 301, 302 are standardised to turn POST into GET (which is definitionally an \"altogether different request\"), and status code 303 is standardised to turn _any_ verb into HEAD or GET (again, an \"altogether different request\"). If your web server really wants to keep everything the same it should issue 307 (302 with no verb change) or 308 (301 with no verb change).\n",
"Now I'm really confused.\n\n<blockquote>A very common pattern is to POST to some endpoint, receive a 302, and GET the location from the 302. You obviously want to strip the body in that case.</blockquote>\n\nWhat is the purpose of this pattern?\n\nFrom the perspective of the client, requests is doing something completely different from what it was asked to do, without giving any notice about this.\n\n<blockquote>Status codes 301, 302 are standardised to turn POST into GET</blockquote>\n\nWhere is that standardized? On http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html it says this is erroneous behavior:\n\n<blockquote>Note: When automatically redirecting a POST request after receiving a 301 status code, some existing HTTP/1.0 user agents will erroneously change it into a GET request.</blockquote>\n\nAlso, if the current behavior is expected for 301 and 302 (which I think it isn't), aren't you contradicting your own answer in this thread: https://github.com/kennethreitz/requests/issues/2590#issuecomment-98685804\n",
"RFC 2616 is _not_ the current HTTP/1.1 standard. In this case, you want RFC 7231 which has the following blocks.\n\nIn [section 6.4](https://tools.ietf.org/html/rfc7231#section-6.4):\n\n> Note: In HTTP/1.0, the status codes 301 (Moved Permanently) and 302 (Found) were defined for the first type of redirect ([RFC1945], Section 9.3). Early user agents split on whether the method applied to the redirect target would be the same as the original request or would be rewritten as GET. Although HTTP originally defined the former semantics for 301 and 302 (to match its original implementation at CERN), and defined 303 (See Other) to match the latter semantics, prevailing practice gradually converged on the latter semantics for 301 and 302 as well. The first revision of HTTP/1.1 added 307 (Temporary Redirect) to indicate the former semantics without being impacted by divergent practice. Over 10 years later, most user agents still do method rewriting for 301 and 302; therefore, this specification makes that behavior conformant when the original request is POST.\n\nAnd in [section 6.4.2](https://tools.ietf.org/html/rfc7231#section-6.4.2), on the 301 status code:\n\n> Note: For historical reasons, a user agent MAY change the request method from POST to GET for the subsequent request. If this behavior is undesired, the 307 (Temporary Redirect) status code can be used instead.\n\nAnd in [section 6.4.3](https://tools.ietf.org/html/rfc7231#section-6.4.3) on the 302 status code:\n\n> Note: For historical reasons, a user agent MAY change the request method from POST to GET for the subsequent request. If this behavior is undesired, the 307 (Temporary Redirect) status code can be used instead.\n\nAnd in [section 6.4.4](https://tools.ietf.org/html/rfc7231#section-6.4.4) on the 303 status code:\n\n> A user agent can perform a retrieval request targeting that URI (a GET or HEAD request if using HTTP), which might also be redirected, and present the eventual result as an answer to the original request. \n\nAnd in [section 6.4.7](https://tools.ietf.org/html/rfc7231#section-6.4.7) on the 307 status code:\n\n> Note: This status code is similar to 302 (Found), except that it does not allow changing the request method from POST to GET. This specification defines no equivalent counterpart for 301 (Moved Permanently) ([RFC7238], however, defines the status code 308 (Permanent Redirect) for this purpose).\n\nYou asked:\n\n> What is the purpose of this pattern?\n\nIt's usually used for form submission. A HTTP form is _usually_ submitted using a POST, but most servers will not return a page that way. Instead, they take the POST and then issue a redirect to some GET-able resource that the browser can display. Requests will appear to be broken if it doesn't behave the same way as browsers do, so we need to follow that logic.\n\n> Also, if the current behavior is expected for 301 and 302 (which I think it isn't), aren't you contradicting your own answer in this thread: #2590 (comment)\n\nNo, I'm not. =) I was a) answering your question about stripping bodies, and b) explaining that plenty of redirect codes do generate entirely different requests from the redirect. However, I do not believe that 301 to PATCH should do that, expressly because the spec doesn't expect so either. I think there's still a bug here, don't you worry! =)\n",
"That explains it, thanks a lot. Also, I somehow overlooked this issue is only about PATCH. Sorry about that.\n",
"No problem at all. =)\n",
"This happens with PUT requests returning 301, too. I see you mentioned \n\n> Arguably, a 301 for a non-POST should also behave the same way\n\nIs it correct behaviour for PUT as well?\n\nThanks!\n",
"@borbamartin I believe so, yes. I think really _only_ the logic we use with POST is wrong here.\n",
"Thanks @Lukasa !\n",
"So I think I have a PR ready for this, but I have a couple of clarifying questions.\r\n\r\n>In #1084 we allowed 307 and 308 to keep their bodies, but all other redirects lose theirs. Arguably, a 301 for a non-POST should also behave the same way.\r\n\r\nI'm reading this as \"a 301 for a non-POST should also behave like a 307/308\" which seems to be consistent with RFC 7231. However, the last few comments are making me wonder if I'm interpreting this wrong.\r\n\r\n>This happens with PUT requests returning 301, too. [...] Is it correct behaviour for PUT as well?\r\n\r\n> I believe so, yes. \r\n\r\nAre you saying PUT should be converted to a GET like POST? That seems reasonable, but I can't find any examples of this happening in the wild, or even in the RFC.\r\n\r\n>I think really *only* the logic we use with POST is wrong here.\r\n\r\nPOST requests are converted to a GET like browsers currently do. Isn't that the behaviour we want here? I've been reading this issue as the logic for everything *except* POST (and GET/HEAD) needs to be adjusted here.",
"Yeah, sorry, I think 301 to PUT should also stay PUT.",
"This will be resolved in 3.0.0 with #3757."
] |
https://api.github.com/repos/psf/requests/issues/2589
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2589/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2589/comments
|
https://api.github.com/repos/psf/requests/issues/2589/events
|
https://github.com/psf/requests/issues/2589
| 72,913,324 |
MDU6SXNzdWU3MjkxMzMyNA==
| 2,589 |
Can't post BytesIO file-like object
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/401600?v=4",
"events_url": "https://api.github.com/users/JetForMe/events{/privacy}",
"followers_url": "https://api.github.com/users/JetForMe/followers",
"following_url": "https://api.github.com/users/JetForMe/following{/other_user}",
"gists_url": "https://api.github.com/users/JetForMe/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/JetForMe",
"id": 401600,
"login": "JetForMe",
"node_id": "MDQ6VXNlcjQwMTYwMA==",
"organizations_url": "https://api.github.com/users/JetForMe/orgs",
"received_events_url": "https://api.github.com/users/JetForMe/received_events",
"repos_url": "https://api.github.com/users/JetForMe/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/JetForMe/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JetForMe/subscriptions",
"type": "User",
"url": "https://api.github.com/users/JetForMe",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2015-05-04T03:41:29Z
|
2021-09-08T03:00:20Z
|
2015-05-04T03:48:50Z
|
NONE
|
resolved
|
Hi. I'm trying to zip a directory in memory and then POST that to a server. Unfortunately, I don't seem to be able to use the BytesIO object to which the zip data is written. Instead, I have to get the bytes from it. But the docs seem to indicate I can provide either bytes or a file-like object in the tuple.
Here's a condensed version of the code:
```
zipData = io.BytesIO();
with zipfile.ZipFile(zipData, mode="w") as zf:
zf.write(<some content>)
url = "https://some.host/api/upload"
files = { "ipa" : open(ipaPath, "rb") }
#files["dsym"] = (zipName, zipData) # file-like object doesn't work?
files["dsym"] = (zipName, zipData.getvalue()) # works
r = requests.post(url, files=files)
```
It may well be user error; if so, sorry for the noise.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/401600?v=4",
"events_url": "https://api.github.com/users/JetForMe/events{/privacy}",
"followers_url": "https://api.github.com/users/JetForMe/followers",
"following_url": "https://api.github.com/users/JetForMe/following{/other_user}",
"gists_url": "https://api.github.com/users/JetForMe/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/JetForMe",
"id": 401600,
"login": "JetForMe",
"node_id": "MDQ6VXNlcjQwMTYwMA==",
"organizations_url": "https://api.github.com/users/JetForMe/orgs",
"received_events_url": "https://api.github.com/users/JetForMe/received_events",
"repos_url": "https://api.github.com/users/JetForMe/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/JetForMe/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JetForMe/subscriptions",
"type": "User",
"url": "https://api.github.com/users/JetForMe",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2589/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2589/timeline
| null |
completed
| null | null | false |
[
"So try this on for size:\n\n``` py\nzipData = io.BytesIO();\nwith zipfile.ZipFile(zipData, mode=\"w\") as zf:\n zf.write(<some content>)\n\nzipData.seek(0, 0)\nurl = \"https://some.host/api/upload\"\n\nfiles = { \"ipa\" : open(ipaPath, \"rb\") }\n#files[\"dsym\"] = (zipName, zipData) # file-like object doesn't work?\nfiles[\"dsym\"] = (zipName, zipData.getvalue()) # works\nr = requests.post(url, files=files)\n```\n\nThe problem is that the `BytesIO` object moves the position when you write to it. If you do\n\n``` py\nfp = io.BytesIO()\nfp.write(b'some data')\nassert fp.read() == b''\nfp.seek(0, 0)\nassert fp.read() == fp.getvalue()\n```\n\nCheers!\n",
"Yep! That was it! Totally explains what I was seeing, too (empty content). Thank you.\n",
"Happy to help!\n",
"Perfect Answer. Always worked with files when we open default point is at start in case of write to streams we have to explicitly put the pointer back at start of the object. Saved my day thanks for the explanation."
] |
https://api.github.com/repos/psf/requests/issues/2588
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2588/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2588/comments
|
https://api.github.com/repos/psf/requests/issues/2588/events
|
https://github.com/psf/requests/pull/2588
| 72,889,953 |
MDExOlB1bGxSZXF1ZXN0MzQ2MTA4MTI=
| 2,588 |
use reST link syntax
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/219470?v=4",
"events_url": "https://api.github.com/users/benjaminp/events{/privacy}",
"followers_url": "https://api.github.com/users/benjaminp/followers",
"following_url": "https://api.github.com/users/benjaminp/following{/other_user}",
"gists_url": "https://api.github.com/users/benjaminp/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/benjaminp",
"id": 219470,
"login": "benjaminp",
"node_id": "MDQ6VXNlcjIxOTQ3MA==",
"organizations_url": "https://api.github.com/users/benjaminp/orgs",
"received_events_url": "https://api.github.com/users/benjaminp/received_events",
"repos_url": "https://api.github.com/users/benjaminp/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/benjaminp/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/benjaminp/subscriptions",
"type": "User",
"url": "https://api.github.com/users/benjaminp",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-05-04T00:34:20Z
|
2021-09-08T07:01:00Z
|
2015-05-04T02:18:37Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2588/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2588/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2588.diff",
"html_url": "https://github.com/psf/requests/pull/2588",
"merged_at": "2015-05-04T02:18:37Z",
"patch_url": "https://github.com/psf/requests/pull/2588.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2588"
}
| true |
[
"Thanks for catching this @gutworth! :sparkles: :cake: :sparkles: \n"
] |
|
https://api.github.com/repos/psf/requests/issues/2587
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2587/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2587/comments
|
https://api.github.com/repos/psf/requests/issues/2587/events
|
https://github.com/psf/requests/pull/2587
| 72,852,379 |
MDExOlB1bGxSZXF1ZXN0MzQ2MDYxMjA=
| 2,587 |
Remove the __bool__ and __nonzero__ response methods
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
[] |
closed
| true |
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
] |
{
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
}
| 5 |
2015-05-03T19:24:01Z
|
2021-09-08T07:01:00Z
|
2015-05-04T13:05:36Z
|
CONTRIBUTOR
|
resolved
|
Many people expect to be able to say:
```
response = make_request(url)
if response:
body = response.content
```
Where the first part should test for whether or not response is None.
Instead, the **bool** and **nonzero** methods return response.ok, so if
the response is actually a 4xx or 5xx response, then the user would
expect to get the body of the response.
By removing these methods, we restore the functionality that most users
expect.
Closes #2002
---
**Note** this is development for 3.0.0
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2587/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2587/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2587.diff",
"html_url": "https://github.com/psf/requests/pull/2587",
"merged_at": "2015-05-04T13:05:36Z",
"patch_url": "https://github.com/psf/requests/pull/2587.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2587"
}
| true |
[
"For the 3.0.0 stuff, I think we should try to be adding changelog updates for this: ideally, fairly thorough ones.\n",
"Otherwise, this looks totally reasonable. =)\n",
"Since we've discussed keeping this branch around for a while and the likelihood of having another release (at least), I made a different file to store the 3.0 history to avoid messy merge conflicts. Let me know if you just want it in `HISTORY.rst` instead\n",
"I think you accidentally a word, but this is otherwise perfect.\n",
"The word is unaccidentallyied\n"
] |
https://api.github.com/repos/psf/requests/issues/2586
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2586/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2586/comments
|
https://api.github.com/repos/psf/requests/issues/2586/events
|
https://github.com/psf/requests/pull/2586
| 72,808,110 |
MDExOlB1bGxSZXF1ZXN0MzQ2MDE2ODk=
| 2,586 |
Cut 2.7.0 this weekend
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 10 |
2015-05-03T13:43:44Z
|
2021-09-08T08:00:47Z
|
2015-05-03T15:02:21Z
|
MEMBER
|
resolved
|
Ok, I believe we've left enough time for the chunked stuff to bake, and no further issues seem to have come out of the woodwork. At this point, I think we should cut 2.7.0 and begin the switchover to our new release process.
@shazow are you open to tagging a new urllib3 release, and if so what commit would you like us to use? If you don't really care, by default we'd use shazow/urllib3@74073791a3429d9b9f375563954f57f2181599dc.
Things to do:
- [x] Update urllib3.
- [x] Confirm that the #2455 problem sites still work.
- [x] Update changelog.
- [ ] Tag.
- [ ] Push release.
- [ ] Have a drink.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2586/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2586/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2586.diff",
"html_url": "https://github.com/psf/requests/pull/2586",
"merged_at": "2015-05-03T15:02:21Z",
"patch_url": "https://github.com/psf/requests/pull/2586.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2586"
}
| true |
[
"In my ideal world we'd update the `certifi` bundle as well, but I'm now strongly averse to trying to do too much with these releases. @sigmavirus24?\n",
"I'm not strongly opposed to it. I'd like confirmation that the problem sites in #2455 at least work. Thoughts?\n",
"Agreed. Adding it to the list.\n",
"Alright, the chunked keep-alive problem does appear to be resolved after synchronizing urllib3.\n",
"Hm, this downgraded the embedded version string of urllib3.\nI think it is confusing to have a quite arbitrary version in the bundled library.\n\nThoughts:\n- Wait for a @shazow to cut a new release and update the version in urllib3 itself, then pull that.\n- Rewrite the version string to be actual the commit id.\n",
"Tagged and pushed urllib3 v1.10.4.\n",
"And I updated the commit to resolve that problem. The only delta between the previous commit and the new one is the version identifier.\n",
"@sigmavirus24 Any objections to me merging this PR (manually without a merge commit, because we don't need it) and pushing the release?\n",
"0 (zero) objections here.\n",
"Done.\n"
] |
https://api.github.com/repos/psf/requests/issues/2585
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2585/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2585/comments
|
https://api.github.com/repos/psf/requests/issues/2585/events
|
https://github.com/psf/requests/issues/2585
| 72,459,274 |
MDU6SXNzdWU3MjQ1OTI3NA==
| 2,585 |
Session.get_adapter won't work correctly for case-sensitive URLs
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1110390?v=4",
"events_url": "https://api.github.com/users/agilevic/events{/privacy}",
"followers_url": "https://api.github.com/users/agilevic/followers",
"following_url": "https://api.github.com/users/agilevic/following{/other_user}",
"gists_url": "https://api.github.com/users/agilevic/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/agilevic",
"id": 1110390,
"login": "agilevic",
"node_id": "MDQ6VXNlcjExMTAzOTA=",
"organizations_url": "https://api.github.com/users/agilevic/orgs",
"received_events_url": "https://api.github.com/users/agilevic/received_events",
"repos_url": "https://api.github.com/users/agilevic/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/agilevic/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/agilevic/subscriptions",
"type": "User",
"url": "https://api.github.com/users/agilevic",
"user_view_type": "public"
}
|
[
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
}
] |
open
| false | null |
[] |
{
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
}
| 6 |
2015-05-01T15:44:12Z
|
2015-07-18T14:22:31Z
| null |
NONE
| null |
In its current implementation Session.get_adapter turns url to lowercase in line 637. If it is aiming for case-insensitive compare it should also turn prefix variable to lowercase in the same line or do that at registration in the mount() method. But this whole idea seems incorrect because URL paths can be case sensitive and one might register different adapters for different paths on the same site.
The fix should most likely be spliting the URL into components and using that tuple as a key in the self.adapters dictionary. Changes mount() and get_adapter().
``` python
In [48]: urlparse.urlparse('HTTP://lala.mi.do/path')
Out[48]: ParseResult(scheme='http', netloc='lala.mi.do', path='/path', params='', query='', fragment='')
In [49]: d = {}
In [50]: purl = urlparse.urlparse('HTTP://lala.mi.do/path')
In [51]: d[purl] = 'myadapter'
In [52]: purl = urlparse.urlparse('HTTP://lala.mi.do/Path2')
In [53]: purl
Out[53]: ParseResult(scheme='http', netloc='lala.mi.do', path='/Path2', params='', query='', fragment='')
In [54]: d[purl] = 'myadapter2'
In [55]: d
Out[55]:
{ParseResult(scheme='http', netloc='lala.mi.do', path='/Path2', params='', query='', fragment=''): 'myadapter2',
ParseResult(scheme='http', netloc='lala.mi.do', path='/path', params='', query='', fragment=''): 'myadapter'}
```
| null |
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2585/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2585/timeline
| null | null | null | null | false |
[
"Agreed that the case-insensitive compare is a bad idea, but I also think splitting the URL into components is not a good idea either. The correct thing to do is to remove the case-insensitive compare in 3.0.0.\n",
"If I remember correctly, we compare them case-insensitively because most people don't use adapters with paths (which isn't to say that your use-case is invalid or that this bug is invalid).\n\nAt least 90% of people mounting custom adapters will be doing it based on scheme alone (e.g., `http://`) while at least another 5% will probably be mounting based on scheme + host (e.g., `http://lala.mi.do`). For those use-cases the case-insensitive comparison is 100% valid. Scheme and non-user-info authority comparisons _should_ be case-insensitive.\n\nIt's probably over-kill, but I think we should [normalize](https://github.com/sigmavirus24/rfc3986/blob/master/rfc3986/api.py#L65) the input to `mount` and `get_adapter`. That way we can appropriately make a comparison. That of course, does not preclude anyone from messing with the underlying attribute that stores the adapters and their mount points directly and thereby breaking these assumptions/safe-guards.\n",
"Thanks for looking into this. The case here is using different caching strategies for different paths and is valid perfectly sensible. \n\nTuple or string as key is an implementation detail, but doing a plain case-sensitive compare is not entirely correct either. See my example below where one spelling uses HTTP:// and another is http:// for a scheme. Parser correctly normalizes URL fragments and its result can be used as key. If you want to use strings call geturl() on the parsed object.\n\n``` python\n\nIn [3]: urlparse.urlparse('http://lala.mi.do/Path2')\nOut[3]: ParseResult(scheme='http', netloc='lala.mi.do', path='/Path2', params='', query='', fragment='')\n\nIn [4]: urlparse.urlparse('HTTP://lala.mi.do/Path2')\nOut[4]: ParseResult(scheme='http', netloc='lala.mi.do', path='/Path2', params='', query='', fragment='')\n\nIn [5]: urlparse.urlparse('HTTP://lala.mi.do/path2')\nOut[5]: ParseResult(scheme='http', netloc='lala.mi.do', path='/path2', params='', query='', fragment='')\n\nIn [6]: urlparse.urlparse('ftp://user:[email protected]/path2')\nOut[6]: ParseResult(scheme='ftp', netloc='user:[email protected]', path='/path2', params='', query='', fragment='')\n\nIn [7]: urlparse.urlparse('ftp://User:[email protected]/path2')\nOut[7]: ParseResult(scheme='ftp', netloc='User:[email protected]', path='/path2', params='', query='', fragment='')\n\n# performance-wise any implementation will work\nIn [14]: %timeit hash(urlparse.urlparse('ftp://User:[email protected]/path2').geturl())\n100000 loops, best of 3: 3.73 µs per loop\n\nIn [15]: %timeit hash(urlparse.urlparse('ftp://User:[email protected]/path2'))\n100000 loops, best of 3: 2.18 µs per loop\n```\n",
"Agreed, we should be normalising those inputs. Regardless, this is an API change and so can't land until 3.0.0.\n",
"@sigmavirus24 I'm beginning to wonder if we should have a 3.0.0 feature branch, and should start landing these things we keep deferring to 3.0.0.\n",
"@Lukasa I've been thinking of starting just such a branch in my fork. I wasn't sure if we would want to keep it here or elsewhere. While having people test it would be nice, having bug reports here about it might become confusing to some.\n"
] |
https://api.github.com/repos/psf/requests/issues/2584
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2584/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2584/comments
|
https://api.github.com/repos/psf/requests/issues/2584/events
|
https://github.com/psf/requests/issues/2584
| 72,456,839 |
MDU6SXNzdWU3MjQ1NjgzOQ==
| 2,584 |
Timeline for HTTP/2
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/401438?v=4",
"events_url": "https://api.github.com/users/AstraLuma/events{/privacy}",
"followers_url": "https://api.github.com/users/AstraLuma/followers",
"following_url": "https://api.github.com/users/AstraLuma/following{/other_user}",
"gists_url": "https://api.github.com/users/AstraLuma/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/AstraLuma",
"id": 401438,
"login": "AstraLuma",
"node_id": "MDQ6VXNlcjQwMTQzOA==",
"organizations_url": "https://api.github.com/users/AstraLuma/orgs",
"received_events_url": "https://api.github.com/users/AstraLuma/received_events",
"repos_url": "https://api.github.com/users/AstraLuma/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/AstraLuma/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AstraLuma/subscriptions",
"type": "User",
"url": "https://api.github.com/users/AstraLuma",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-05-01T15:33:48Z
|
2021-09-08T23:04:54Z
|
2015-05-01T15:59:30Z
|
NONE
|
resolved
|
With the finishing of the HTTP/2 standardization process, does requests have a timeline, goal, or idea of its HTTP/2 support?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2584/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2584/timeline
| null |
completed
| null | null | false |
[
"Please check old issues: #2082 #2451.\n"
] |
https://api.github.com/repos/psf/requests/issues/2583
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2583/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2583/comments
|
https://api.github.com/repos/psf/requests/issues/2583/events
|
https://github.com/psf/requests/issues/2583
| 72,431,519 |
MDU6SXNzdWU3MjQzMTUxOQ==
| 2,583 |
ImportError: No module named 'requests.packages.chardet.sys' when frozen by PyInstaller
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/784161?v=4",
"events_url": "https://api.github.com/users/htgoebel/events{/privacy}",
"followers_url": "https://api.github.com/users/htgoebel/followers",
"following_url": "https://api.github.com/users/htgoebel/following{/other_user}",
"gists_url": "https://api.github.com/users/htgoebel/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/htgoebel",
"id": 784161,
"login": "htgoebel",
"node_id": "MDQ6VXNlcjc4NDE2MQ==",
"organizations_url": "https://api.github.com/users/htgoebel/orgs",
"received_events_url": "https://api.github.com/users/htgoebel/received_events",
"repos_url": "https://api.github.com/users/htgoebel/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/htgoebel/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/htgoebel/subscriptions",
"type": "User",
"url": "https://api.github.com/users/htgoebel",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-05-01T13:21:28Z
|
2021-09-08T23:04:55Z
|
2015-05-01T13:57:52Z
|
NONE
|
resolved
|
When running a simple test-program frozen by [PyInstaller](http://www.pyinstaller.org) this program fails with an `ImportError: No module named 'requests.packages.chardet.sys'`. The same program runs fine when run unfrozen (which means: directly from the command line).
This seams to be a problem with the import magic done in requests.packages. For some reasons requests.packages.chardet tries a relative import.
How to reproduce:
```
$ git clone --depth=1 https://github.com/pyinstaller/pyinstaller.git
$ cd pyinstaller
# the script runs unfrozen (well, it has an SSL-error, but no import error):
$ python tests/libraries/test_requests.py
# now freeze the application
$ cd tests/libraries/
$ ../../pyinstaller.py test_requests.py
# the frozen app fails:
$ dist/test_requests/test_requests
[...]
File "/tmp/pyinstaller/PyInstaller/loader/pyi_importers.py", line 276, in load_module
exec(bytecode, module.__dict__)
File "/tmp/pyinstaller/tests/libraries/build/test_requests/out00-PYZ.pyz/requests.packages.chardet", line 19, in <module>
File "/tmp/pyinstaller/tests/libraries/build/test_requests/out00-PYZ.pyz/requests.packages", line 95, in load_module
ImportError: No module named 'requests.packages.chardet.sys'
```
Tested with requests **version** = '2.6.0', **build** = 0x020503 and Python 2.7.9
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2583/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2583/timeline
| null |
completed
| null | null | false |
[
"This is a known issue in 2.6.0 with the update machinery we introduced in 2.5.2. We fixed it in 2.6.1, but unfortunately that release also broke some chunked encoding stuff. The reality is that there are no good releases right now for pyinstaller (2.1.0 through 2.5.3 are affected by CVE 2015-2296, so don't use them either), but 2.7.0 should be along shortly which will resolve this.\n",
"@Lukasa Thanks for the quick reply. I can confirm the error is gone in 2.6.1.\n"
] |
https://api.github.com/repos/psf/requests/issues/2582
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2582/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2582/comments
|
https://api.github.com/repos/psf/requests/issues/2582/events
|
https://github.com/psf/requests/pull/2582
| 72,348,225 |
MDExOlB1bGxSZXF1ZXN0MzQ1MjAyMTQ=
| 2,582 |
Make docstring of api.get more clear
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1484098?v=4",
"events_url": "https://api.github.com/users/mhavard999/events{/privacy}",
"followers_url": "https://api.github.com/users/mhavard999/followers",
"following_url": "https://api.github.com/users/mhavard999/following{/other_user}",
"gists_url": "https://api.github.com/users/mhavard999/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mhavard999",
"id": 1484098,
"login": "mhavard999",
"node_id": "MDQ6VXNlcjE0ODQwOTg=",
"organizations_url": "https://api.github.com/users/mhavard999/orgs",
"received_events_url": "https://api.github.com/users/mhavard999/received_events",
"repos_url": "https://api.github.com/users/mhavard999/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mhavard999/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mhavard999/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mhavard999",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-05-01T04:01:51Z
|
2021-09-08T08:00:48Z
|
2015-05-01T05:59:46Z
|
CONTRIBUTOR
|
resolved
|
I opened issue #2581, and since it is such a small change, I just went ahead and opened the pull request immediately.
This makes the docstring for `requests.get` clearer so when someone does `help(requests.get)` they can see that `params` is an optional kwarg that can be used to attach query string parameters to a GET request. I think this change makes it symmetric with `requests.post` which specifically mentions `data` and `json` for body and json parameters. As I mentioned in #2581, query string parameters are as relevant to GET requests as json and body parameters are to POST requests, so this change makes a lot of sense in that respect.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2582/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2582/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2582.diff",
"html_url": "https://github.com/psf/requests/pull/2582",
"merged_at": "2015-05-01T05:59:46Z",
"patch_url": "https://github.com/psf/requests/pull/2582.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2582"
}
| true |
[
"Thanks for this @mhavard999, it looks great! :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/2581
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2581/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2581/comments
|
https://api.github.com/repos/psf/requests/issues/2581/events
|
https://github.com/psf/requests/issues/2581
| 72,347,918 |
MDU6SXNzdWU3MjM0NzkxOA==
| 2,581 |
The docstring for `get` in `api.py` should be more clear.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1484098?v=4",
"events_url": "https://api.github.com/users/mhavard999/events{/privacy}",
"followers_url": "https://api.github.com/users/mhavard999/followers",
"following_url": "https://api.github.com/users/mhavard999/following{/other_user}",
"gists_url": "https://api.github.com/users/mhavard999/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mhavard999",
"id": 1484098,
"login": "mhavard999",
"node_id": "MDQ6VXNlcjE0ODQwOTg=",
"organizations_url": "https://api.github.com/users/mhavard999/orgs",
"received_events_url": "https://api.github.com/users/mhavard999/received_events",
"repos_url": "https://api.github.com/users/mhavard999/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mhavard999/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mhavard999/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mhavard999",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-05-01T03:56:46Z
|
2021-09-08T23:04:55Z
|
2015-05-01T05:59:57Z
|
CONTRIBUTOR
|
resolved
|
This is the docstring for `get` from `api.py`:
``` python
"""Sends a GET request.
:param url: URL for the new :class:`Request` object.
:param \*\*kwargs: Optional arguments that ``request`` takes.
:return: :class:`Response <Response>` object
:rtype: requests.Response
"""
```
So when someone does `help(requests.get)` they won't see anything about the optional kwarg `params` used to attach query string parameters to the request. If they're extra clever, they'll understand what "Optional arguments that ``request`` takes" mean and do `help(requests.request)`, which then explains the `params` kwarg parameter. Note that the docstring of `requests.post` mentions `data` and `json`, even though those params are explained in the docstring of `requests.requests`. Since query string parameters are as relevant to GET requests as body and json parameters are to POST requests, should the `requests.get` be changed to:
``` python
def get(url, params=None, **kwargs):
"""Sends a GET request.
:param url: URL for the new :class:`Request` object.
:param params: (optional) Dictionary or bytes to be sent in the query string for the :class:`Request`.
:param \*\*kwargs: Optional arguments that ``request`` takes.
:return: :class:`Response <Response>` object
:rtype: requests.Response
"""
kwargs.setdefault('allow_redirects', True)
return request('get', url, params=params, **kwargs)
```
Current version for reference:
``` python
def get(url, **kwargs):
"""Sends a GET request.
:param url: URL for the new :class:`Request` object.
:param \*\*kwargs: Optional arguments that ``request`` takes.
:return: :class:`Response <Response>` object
:rtype: requests.Response
"""
kwargs.setdefault('allow_redirects', True)
return request('get', url, **kwargs)
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2581/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2581/timeline
| null |
completed
| null | null | false |
[
"Closed by #2582.\n"
] |
https://api.github.com/repos/psf/requests/issues/2580
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2580/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2580/comments
|
https://api.github.com/repos/psf/requests/issues/2580/events
|
https://github.com/psf/requests/issues/2580
| 71,988,571 |
MDU6SXNzdWU3MTk4ODU3MQ==
| 2,580 |
Documentation for context manager?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/4295636?v=4",
"events_url": "https://api.github.com/users/Microserf/events{/privacy}",
"followers_url": "https://api.github.com/users/Microserf/followers",
"following_url": "https://api.github.com/users/Microserf/following{/other_user}",
"gists_url": "https://api.github.com/users/Microserf/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Microserf",
"id": 4295636,
"login": "Microserf",
"node_id": "MDQ6VXNlcjQyOTU2MzY=",
"organizations_url": "https://api.github.com/users/Microserf/orgs",
"received_events_url": "https://api.github.com/users/Microserf/received_events",
"repos_url": "https://api.github.com/users/Microserf/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Microserf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Microserf/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Microserf",
"user_view_type": "public"
}
|
[
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
},
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"name": "Contributor Friendly",
"node_id": "MDU6TGFiZWwxOTEyNzQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Contributor%20Friendly"
},
{
"color": "fad8c7",
"default": false,
"description": null,
"id": 136616769,
"name": "Documentation",
"node_id": "MDU6TGFiZWwxMzY2MTY3Njk=",
"url": "https://api.github.com/repos/psf/requests/labels/Documentation"
}
] |
closed
| true | null |
[] | null | 4 |
2015-04-29T20:59:27Z
|
2021-09-08T23:00:43Z
|
2015-08-07T20:41:21Z
|
NONE
|
resolved
|
The documentation makes only a single reference to the fact that `requests` provides some sort of context manager, and it's in the release notes from version 0.6 in 2011:
> New persistient sessions object and context manager
Would it be possible to get examples of how to implement these context managers? Specifically, I'm looking to replace the following code:
``` python
with contextlib.closing(urllib2.urlopen(self.url)) as dl:
```
I can't find any place that documents how to use an equivalent `requests` context manager, so I'll have to dig through the code to find out. It would be nice to get a bit more visibility into the `requests` API...
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2580/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2580/timeline
| null |
completed
| null | null | false |
[
"So I believe that refers to the fact that you can do:\n\n``` py\nwith requests.Session() as session:\n response = session.get(self.url)\n```\n\nTo get the equivalent to that code though, you could do\n\n``` py\nimport requests\n\nsession = requests.Session()\n\nwith contextlib.closing(session.get(self.url, stream=True)) as response:\n response.raw.read(...)\n\n# or\n\nwith contextlib.closing(requests.get(self.url, stream=True)) as response:\n```\n\nI could have sworn there were well documented examples of using Sessions and responses as context managers.\n",
"> I could have sworn there were well documented examples of using Sessions and responses as context managers.\n\nNothing I can find in the docs, only your `contextlib.closing` example from above. Feels like a good enhancement!\n",
"@sigmavirus24 Thanks for the quick response with examples. I'll try these and report back...\n",
"Update: I got the second form (the one with `requests.get` instead of `session.get`) to work. Didn't test the first form.\n\nI had to remember to use `response.raw` as the file-like object, not `response`. (This is different from the `urllib2.urlopen()` example I gave above, where `dl.read()` gives the response). This makes sense, when I considered how the code wrapped within the context manager may want to check the response status, encoding types or other metadata, before reading the contents of the response.\n\nThanks!\n"
] |
https://api.github.com/repos/psf/requests/issues/2579
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2579/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2579/comments
|
https://api.github.com/repos/psf/requests/issues/2579/events
|
https://github.com/psf/requests/issues/2579
| 71,858,093 |
MDU6SXNzdWU3MTg1ODA5Mw==
| 2,579 |
ResponseNotReady when getting GitHub raw URL
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/634?v=4",
"events_url": "https://api.github.com/users/Bjwebb/events{/privacy}",
"followers_url": "https://api.github.com/users/Bjwebb/followers",
"following_url": "https://api.github.com/users/Bjwebb/following{/other_user}",
"gists_url": "https://api.github.com/users/Bjwebb/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Bjwebb",
"id": 634,
"login": "Bjwebb",
"node_id": "MDQ6VXNlcjYzNA==",
"organizations_url": "https://api.github.com/users/Bjwebb/orgs",
"received_events_url": "https://api.github.com/users/Bjwebb/received_events",
"repos_url": "https://api.github.com/users/Bjwebb/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Bjwebb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Bjwebb/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Bjwebb",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-04-29T12:15:01Z
|
2021-09-08T23:04:56Z
|
2015-04-29T12:44:51Z
|
NONE
|
resolved
|
Trying to get https://github.com/kennethreitz/requests/blob/master/README.rst?raw=true fails. Getting https://github.com/kennethreitz/requests/raw/master/README.rst (which the former redirects to) succeeds, so I think this has something to do with the handling the redirect.
I'm not 100% sure this is an issue with requests (it's possible the server is misbehaving), but the same URL does work in the browser and in curl and wget.
```
$ python bjwebb@winslow
Python 3.4.3 (default, Mar 25 2015, 17:13:50)
[GCC 4.9.2 20150304 (prerelease)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests
>>> requests.__version__
'2.6.2'
>>> r = requests.get('https://github.com/kennethreitz/requests/blob/master/README.rst?raw=true')
Traceback (most recent call last):
File "/usr/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 372, in _make_request
httplib_response = conn.getresponse(buffering=True)
TypeError: getresponse() got an unexpected keyword argument 'buffering'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 544, in urlopen
body=body, headers=headers)
File "/usr/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 374, in _make_request
httplib_response = conn.getresponse()
File "/usr/lib/python3.4/http/client.py", line 1162, in getresponse
raise ResponseNotReady(self.__state)
http.client.ResponseNotReady: Request-sent
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/lib/python3.4/site-packages/requests/adapters.py", line 370, in send
timeout=timeout
File "/usr/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 597, in urlopen
_stacktrace=sys.exc_info()[2])
File "/usr/lib/python3.4/site-packages/requests/packages/urllib3/util/retry.py", line 245, in increment
raise six.reraise(type(error), error, _stacktrace)
File "/usr/lib/python3.4/site-packages/requests/packages/urllib3/packages/six.py", line 309, in reraise
raise value.with_traceback(tb)
File "/usr/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 544, in urlopen
body=body, headers=headers)
File "/usr/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 374, in _make_request
httplib_response = conn.getresponse()
File "/usr/lib/python3.4/http/client.py", line 1162, in getresponse
raise ResponseNotReady(self.__state)
requests.packages.urllib3.exceptions.ProtocolError: ('Connection aborted.', ResponseNotReady('Request-sent',))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3.4/site-packages/requests/api.py", line 68, in get
return request('get', url, **kwargs)
File "/usr/lib/python3.4/site-packages/requests/api.py", line 50, in request
response = session.request(method=method, url=url, **kwargs)
File "/usr/lib/python3.4/site-packages/requests/sessions.py", line 465, in request
resp = self.send(prep, **send_kwargs)
File "/usr/lib/python3.4/site-packages/requests/sessions.py", line 594, in send
history = [resp for resp in gen] if allow_redirects else []
File "/usr/lib/python3.4/site-packages/requests/sessions.py", line 594, in <listcomp>
history = [resp for resp in gen] if allow_redirects else []
File "/usr/lib/python3.4/site-packages/requests/sessions.py", line 196, in resolve_redirects
**adapter_kwargs
File "/usr/lib/python3.4/site-packages/requests/sessions.py", line 573, in send
r = adapter.send(request, **kwargs)
File "/usr/lib/python3.4/site-packages/requests/adapters.py", line 415, in send
raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', ResponseNotReady('Request-sent',))
>>>
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2579/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2579/timeline
| null |
completed
| null | null | false |
[
"This is a duplicate of #2568.\n"
] |
https://api.github.com/repos/psf/requests/issues/2578
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2578/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2578/comments
|
https://api.github.com/repos/psf/requests/issues/2578/events
|
https://github.com/psf/requests/issues/2578
| 71,778,533 |
MDU6SXNzdWU3MTc3ODUzMw==
| 2,578 |
POST Request turns into GET when prepared without a Session
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/223908?v=4",
"events_url": "https://api.github.com/users/krey/events{/privacy}",
"followers_url": "https://api.github.com/users/krey/followers",
"following_url": "https://api.github.com/users/krey/following{/other_user}",
"gists_url": "https://api.github.com/users/krey/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/krey",
"id": 223908,
"login": "krey",
"node_id": "MDQ6VXNlcjIyMzkwOA==",
"organizations_url": "https://api.github.com/users/krey/orgs",
"received_events_url": "https://api.github.com/users/krey/received_events",
"repos_url": "https://api.github.com/users/krey/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/krey/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/krey/subscriptions",
"type": "User",
"url": "https://api.github.com/users/krey",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-04-29T04:58:41Z
|
2021-09-08T23:04:56Z
|
2015-04-29T06:07:58Z
|
NONE
|
resolved
|
The code below prints `<PreparedRequest [GET]>`
This isn't a huge issue (as I'm using `Version 2`), just kinda weird that POST is flipped to GET
``` python
import pickle
import requests
from lxml import html
from urllib.parse import urljoin
session = requests.Session()
form_url = "http://www.transtats.bts.gov/Data_Elements.aspx"
get_request = requests.Request("GET", form_url)
get_response = session.send(get_request.prepare())
page_html = html.fromstring(get_response.content)
form = page_html.xpath("id('form1')")[0]
action_url = urljoin(form_url, form.xpath("@action")[0])
hidden_inputs = form.xpath("//input[@type='hidden']")
extra_data = dict([(hidden.xpath("@name")[0],hidden.xpath("@value")[0]) for hidden in hidden_inputs ])
data = {"CarrierList" : "VX", "AirportList" : "All", "Submit": "Submit"}
data.update(extra_data)
post_request = requests.Request("POST", action_url, data=data)
# Version 1
post_response = session.send(post_request.prepare())
# Version 2
#post_response = session.send(session.prepare_request(post_request))
print(post_response.request)
```
(I'm using 2.6.2 on Arch)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2578/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2578/timeline
| null |
completed
| null | null | false |
[
"This is not a bug, you're being redirected. requests automatically follows redirects, when the POST is finished you're getting a 302 to some other URL. Check `post_response.history` to confirm. =)\n",
"You're absolutely correct, thank you\n"
] |
https://api.github.com/repos/psf/requests/issues/2577
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2577/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2577/comments
|
https://api.github.com/repos/psf/requests/issues/2577/events
|
https://github.com/psf/requests/issues/2577
| 71,746,970 |
MDU6SXNzdWU3MTc0Njk3MA==
| 2,577 |
Custom auth handler not called on redirect
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/2001681?v=4",
"events_url": "https://api.github.com/users/cefolger/events{/privacy}",
"followers_url": "https://api.github.com/users/cefolger/followers",
"following_url": "https://api.github.com/users/cefolger/following{/other_user}",
"gists_url": "https://api.github.com/users/cefolger/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cefolger",
"id": 2001681,
"login": "cefolger",
"node_id": "MDQ6VXNlcjIwMDE2ODE=",
"organizations_url": "https://api.github.com/users/cefolger/orgs",
"received_events_url": "https://api.github.com/users/cefolger/received_events",
"repos_url": "https://api.github.com/users/cefolger/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cefolger/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cefolger/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cefolger",
"user_view_type": "public"
}
|
[
{
"color": "e11d21",
"default": false,
"description": null,
"id": 136589914,
"name": "Needs Info",
"node_id": "MDU6TGFiZWwxMzY1ODk5MTQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20Info"
}
] |
closed
| true | null |
[] | null | 1 |
2015-04-29T00:43:23Z
|
2021-09-08T23:04:45Z
|
2015-05-31T12:54:29Z
|
NONE
|
resolved
|
Hi,
I have a custom auth handler, and my problem is that if the service returns a 302 the handler needs to be re-run to generate auth headers for the request to the new url.
Right now I'm setting allow_redirects=False and handling this manually, but can this be done by requests instead?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2577/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2577/timeline
| null |
completed
| null | null | false |
[
"So auth handlers tend to register themselves as `response` hooks which are called every time [`send`](https://github.com/kennethreitz/requests/blob/master/requests/sessions.py#L579) is called. And that's also called when [requests handles redirects](https://github.com/kennethreitz/requests/blob/master/requests/sessions.py#L188).\n\nThat said, without more details about your auth handler, I have no clue how to help you.\n"
] |
https://api.github.com/repos/psf/requests/issues/2576
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2576/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2576/comments
|
https://api.github.com/repos/psf/requests/issues/2576/events
|
https://github.com/psf/requests/issues/2576
| 71,728,416 |
MDU6SXNzdWU3MTcyODQxNg==
| 2,576 |
Set-Cookie - violating rfc6265
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1061223?v=4",
"events_url": "https://api.github.com/users/henadzit/events{/privacy}",
"followers_url": "https://api.github.com/users/henadzit/followers",
"following_url": "https://api.github.com/users/henadzit/following{/other_user}",
"gists_url": "https://api.github.com/users/henadzit/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/henadzit",
"id": 1061223,
"login": "henadzit",
"node_id": "MDQ6VXNlcjEwNjEyMjM=",
"organizations_url": "https://api.github.com/users/henadzit/orgs",
"received_events_url": "https://api.github.com/users/henadzit/received_events",
"repos_url": "https://api.github.com/users/henadzit/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/henadzit/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/henadzit/subscriptions",
"type": "User",
"url": "https://api.github.com/users/henadzit",
"user_view_type": "public"
}
|
[] |
closed
| false | null |
[] |
{
"closed_at": null,
"closed_issues": 29,
"created_at": "2024-05-19T18:29:04Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
},
"description": "",
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/34",
"id": 11073254,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/34/labels",
"node_id": "MI_kwDOABTKOs4AqPbm",
"number": 34,
"open_issues": 0,
"state": "open",
"title": "Bankruptcy",
"updated_at": "2024-05-20T14:37:16Z",
"url": "https://api.github.com/repos/psf/requests/milestones/34"
}
| 10 |
2015-04-28T22:52:08Z
|
2024-05-20T14:36:08Z
|
2024-05-20T14:36:07Z
|
NONE
| null |
Hey,
I found that requests (version 2.6.0) violates one paragraph of rfc6265 - http://tools.ietf.org/html/rfc6265#section-4.1.2.3
"If the server omits the Domain attribute, the user agent will return the cookie only to the origin server."
It means that if Set-Cookie is set without domain at test.com, the cookie shouldn't be visible at subdomain.test.com.
However, the RFC warns that some user agents behave that way. Have this been discussed before? I haven't found anything. I encountered that issue when I was requesting endpoint which sent me 301 to subdomain of the initial endpoint. The service didn't handle that properly.
Below the code that shows the issue.
``` python
"""
Use twoliner to add hosts to /etc/hosts
echo "127.0.0.1 test.com
127.0.0.1 subdomain.test.com" | sudo tee -a /etc/hosts
"""
import BaseHTTPServer
import requests
import threading
# http server
class RequestHandler(BaseHTTPServer.BaseHTTPRequestHandler):
def do_GET(self):
l = self.headers.get('Host').lower()
print "Server: processing {}".format(l)
if l == 'test.com:8000':
self.send_response(301)
self.send_header('Set-Cookie', 'Test=True')
self.send_header('Location', 'http://subdomain.test.com:8000')
elif l == 'subdomain.test.com:8000':
print "---> Cookie: {} <---".format(self.headers.get('Cookie'))
self.send_response(200)
else:
assert False, "Not supported"
httpd = BaseHTTPServer.HTTPServer(('', 8000), RequestHandler)
def server_callback():
while True:
httpd.handle_request()
server_thread = threading.Thread(target=server_callback)
server_thread.daemon = True
server_thread.start()
# http client
requests.get('http://test.com:8000')
```
The code outputs
```
Server: processing test.com:8000
127.0.0.1 - - [28/Apr/2015 23:47:55] "GET / HTTP/1.1" 301 -
Server: processing subdomain.test.com:8000
---> Cookie: Test=True <---
127.0.0.1 - - [28/Apr/2015 23:47:55] "GET / HTTP/1.1" 200 -
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2576/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2576/timeline
| null |
completed
| null | null | false |
[
"So the code that handles cookies for us in the standard library. We rely on [the `add_cookie_header` method on a CookieJar](https://github.com/kennethreitz/requests/blob/master/requests/cookies.py#L135). We create a mock request object but as far as I can tell we're doing everything we should. If we look at that, we'll see that [the `add_cookie_header` method](https://hg.python.org/cpython/file/293d9964cf6e/Lib/http/cookiejar.py#l1331) calls [`_cookies_for_domain`](https://hg.python.org/cpython/file/293d9964cf6e/Lib/http/cookiejar.py#l1247) which calls [`domain_return_ok` on `DefaultCookiePolicy`](https://hg.python.org/cpython/file/293d9964cf6e/Lib/http/cookiejar.py#l1166). The check explicitly says that it is a liberal check. \n\nWith that information, I think I'm comfortable saying that we should start providing a way for users to enable a stricter policy. I don't think we can start doing that by default, though, until 3.0 since it will be a breaking change. Does that sound reasonable?\n",
"Also, I wasn't previously aware of this so I'd like to sincerely thank you for bringing this to our attention.\n",
"@sigmavirus24 Can users not provide a stricter policy by replacing the cookiejar on the `Session` object?\n",
"@lukasa they can. I'm proposing that we provide a stricter policy by default in the near future to make requests comply better with 6265\n",
"> With that information, I think I'm comfortable saying that we should start providing a way for users to enable a stricter policy. I don't think we can start doing that by default, though, until 3.0 since it will be a breaking change. Does that sound reasonable?\n\nI very agree. I am not sure how many people this change could break and whether the behavior should be configurable. I'm also wondering how this is handled in requests analogues.\n",
"Yeah, I want to know what browsers do and what curl does. I'll test this at some stage.\n",
"I'm pretty sure we can use the script in @henadzit's original report to test browsers and curl both. It's well done.\n",
"I updated the test script to test curl and wget. I also tried to use Ruby httpclient but it failed on my server answers. Probably, it requires some headers or something like that. I will look into it later. Anyway, the script is at https://github.com/henadzit/henadzit-various/blob/master/requests-show-rfc6265.py\n\nIts output\n\n```\nClient: curl\nServer: processing test.com:8000\n127.0.0.1 - - [30/Apr/2015 01:02:01] \"GET / HTTP/1.1\" 301 -\nServer: processing subdomain.test.com:8000\n---> Cookie: None <---\n127.0.0.1 - - [30/Apr/2015 01:02:01] \"GET / HTTP/1.0\" 200 -\n\nClient: requests\nServer: processing test.com:8000\n127.0.0.1 - - [30/Apr/2015 01:02:01] \"GET / HTTP/1.1\" 301 -\nServer: processing subdomain.test.com:8000\n---> Cookie: Test=True <---\n127.0.0.1 - - [30/Apr/2015 01:02:01] \"GET / HTTP/1.1\" 200 -\n\nClient: wget\nServer: processing test.com:8000\n127.0.0.1 - - [30/Apr/2015 01:02:01] \"GET / HTTP/1.1\" 301 -\nServer: processing subdomain.test.com:8000\n---> Cookie: None <---\n127.0.0.1 - - [30/Apr/2015 01:02:01] \"GET / HTTP/1.1\" 200 -\n```\n\nAs you can see, both wget and curl follow the RFC and don't store the cookie.\n\nI still want to test browser behavior.\n",
"So I've had this bug nagging at me for no particular reason. I started digging into it tonight and I found that the problem is that the standard library's cookie handling library actually [always adds a domain](https://hg.python.org/cpython/file/293d9964cf6e/Lib/http/cookiejar.py#l1461) if it's absent to a cookie. It also, helpfully (and I literally just realized this while writing this comment) adds `domain_specified` which is a bool. If `domain` isn't in the parsed cookie then that attribute will be false. This makes making our own policy really easy.\n",
"In an effort to clean up the issue tracker to only have issues that are still relevant to the project we've done a quick pass and decided this issue may no longer be relevant for a variety of potential reasons, including:\r\n\r\n* Applies to a much older version, unclear whether the issue still applies.\r\n* Change requires a backwards incompatible release and it's unclear if the benefits are worth the migration effort from the community.\r\n* There isn't a clear demand from the community on the change landing in Requests.\r\n\r\nIf you think the issue should remain open, please comment so below or open a new issue and link back to the original issue. Again, thank you for opening the issue and for the discussion, it's much appreciated."
] |
https://api.github.com/repos/psf/requests/issues/2575
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2575/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2575/comments
|
https://api.github.com/repos/psf/requests/issues/2575/events
|
https://github.com/psf/requests/issues/2575
| 71,606,845 |
MDU6SXNzdWU3MTYwNjg0NQ==
| 2,575 |
HEAD request not following redirects since 2.6.1
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/133945?v=4",
"events_url": "https://api.github.com/users/markunsworth/events{/privacy}",
"followers_url": "https://api.github.com/users/markunsworth/followers",
"following_url": "https://api.github.com/users/markunsworth/following{/other_user}",
"gists_url": "https://api.github.com/users/markunsworth/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/markunsworth",
"id": 133945,
"login": "markunsworth",
"node_id": "MDQ6VXNlcjEzMzk0NQ==",
"organizations_url": "https://api.github.com/users/markunsworth/orgs",
"received_events_url": "https://api.github.com/users/markunsworth/received_events",
"repos_url": "https://api.github.com/users/markunsworth/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/markunsworth/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/markunsworth/subscriptions",
"type": "User",
"url": "https://api.github.com/users/markunsworth",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 13 |
2015-04-28T14:33:31Z
|
2021-09-08T23:04:57Z
|
2015-04-28T15:26:27Z
|
NONE
|
resolved
|
The following should follow the redirects but it just hangs
```
import requests
requests.head("http://bit.ly/DyE5", allow_redirects=True)
```
Have tested this on version 2.6.0, 2.6.1 and 2.6.2 and it stopped working at 2.6.1.
Have also tested as a GET request and that works fine on all versions.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2575/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2575/timeline
| null |
completed
| null | null | false |
[
"_not_ a duplicate of #2568\n",
"Most probably a duplicate of shazow/urllib3#601\nThe server does not do `Transfer-Encoding: chunked` but rather an explicit `Content-Length` without a body following.\n",
"@t-8ch This is an odd dupe of shazow/urllib3#601 then, but I suppose it's possible. Definitely seems like the relevant smoking gun for now, so I'm closing to centralise there.\n",
"Ha, I was wrong. We survive the brokenness of bit.ly and die in brokenness of google.\nGoogle seems to be generally bad on `HEAD` requests. So it definitely a dupe.\n\n``` py\nrequests.head(\"http://www.google.co.uk\", allow_redirects=True) # google.com is also broken\n```\n\nCurl also breaks.\n",
"I don't think Google is wrong, I think we're screwing up, as per shazow/urllib3#601.\n",
"But should they then not just do `Content-Length: 0` and not chunked?\nAfter all even curl does not handle it.\n",
"Not for HEAD requests. The RFC is clear, HEAD requests never have a body, we shouldn't wait for one.\n",
"Are you sure curl doesn't handle it? By default curl won't follow redirects, it needs the -L flag.\n",
"@Lukasa ofc you are right :-)\n\n``` sh\n$ curl -XHEAD -L google.com\n```\n\nIt gets another redirect with a content-length and then seems to wait for the body\n\n``` sh\ncurl -XHEAD www.google.de -Lv\n```\n\nYields no redirect for me and also hangs.\n\ncc @bagder\n",
"I once had a chat with @bagder about the -X flag, and in particular about how it doesn't actually change curl's logic. The correct flag to pass curl is -I, and when you do that your first example works:\n\n``` bash\n$ curl -I -L google.com\n```\n",
"Should have read the curl docs :-(\nSo we are back to shazow/urllib3#601\n",
"@t-8ch I'm sure @bagder will tell you you're not the first person to make this mistake, and you won't be the last. ;)\n\nYeah, that's the bug.\n",
"Yeps. The \"misuse\" of curl -X is widespread, even if I try to educate and document as much as I can...\n"
] |
https://api.github.com/repos/psf/requests/issues/2574
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2574/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2574/comments
|
https://api.github.com/repos/psf/requests/issues/2574/events
|
https://github.com/psf/requests/issues/2574
| 71,598,917 |
MDU6SXNzdWU3MTU5ODkxNw==
| 2,574 |
requests 2.6.1 and 2.6.2 causes ResponseNotReady error for 303 answers
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/10611832?v=4",
"events_url": "https://api.github.com/users/obormotov/events{/privacy}",
"followers_url": "https://api.github.com/users/obormotov/followers",
"following_url": "https://api.github.com/users/obormotov/following{/other_user}",
"gists_url": "https://api.github.com/users/obormotov/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/obormotov",
"id": 10611832,
"login": "obormotov",
"node_id": "MDQ6VXNlcjEwNjExODMy",
"organizations_url": "https://api.github.com/users/obormotov/orgs",
"received_events_url": "https://api.github.com/users/obormotov/received_events",
"repos_url": "https://api.github.com/users/obormotov/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/obormotov/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/obormotov/subscriptions",
"type": "User",
"url": "https://api.github.com/users/obormotov",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-04-28T14:05:41Z
|
2021-09-08T23:04:57Z
|
2015-04-28T14:23:07Z
|
NONE
|
resolved
|
now I've got for redirections:
```
File "bin/eggs/requests-2.6.2-py2.7.egg/requests/sessions.py", line 573, in send
r = adapter.send(request, **kwargs)
File "bin/eggs/requests-2.6.2-py2.7.egg/requests/adapters.py", line 415, in send
raise ConnectionError(err, request=request)
ConnectionError: ('Connection aborted.', ResponseNotReady())
```
requests 2.6 works fine.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2574/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2574/timeline
| null |
completed
| null | null | false |
[
"This is a duplicate of #2568.\n"
] |
https://api.github.com/repos/psf/requests/issues/2573
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2573/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2573/comments
|
https://api.github.com/repos/psf/requests/issues/2573/events
|
https://github.com/psf/requests/issues/2573
| 71,057,069 |
MDU6SXNzdWU3MTA1NzA2OQ==
| 2,573 |
SSLV3_ALERT_HANDSHAKE_FAILURE in 2.6.2
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/2545428?v=4",
"events_url": "https://api.github.com/users/Nelluk/events{/privacy}",
"followers_url": "https://api.github.com/users/Nelluk/followers",
"following_url": "https://api.github.com/users/Nelluk/following{/other_user}",
"gists_url": "https://api.github.com/users/Nelluk/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Nelluk",
"id": 2545428,
"login": "Nelluk",
"node_id": "MDQ6VXNlcjI1NDU0Mjg=",
"organizations_url": "https://api.github.com/users/Nelluk/orgs",
"received_events_url": "https://api.github.com/users/Nelluk/received_events",
"repos_url": "https://api.github.com/users/Nelluk/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Nelluk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Nelluk/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Nelluk",
"user_view_type": "public"
}
|
[
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
},
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"name": "Contributor Friendly",
"node_id": "MDU6TGFiZWwxOTEyNzQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Contributor%20Friendly"
},
{
"color": "fad8c7",
"default": false,
"description": null,
"id": 136616769,
"name": "Documentation",
"node_id": "MDU6TGFiZWwxMzY2MTY3Njk=",
"url": "https://api.github.com/repos/psf/requests/labels/Documentation"
}
] |
closed
| true | null |
[] | null | 18 |
2015-04-26T11:56:17Z
|
2022-02-26T04:00:40Z
|
2021-11-28T03:01:25Z
|
NONE
|
resolved
|
```
raise SSLError(e, request=request)
requests.exceptions.SSLError: [SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:600)
```
Started happening consistently after upgrading to Requests 2.6.2. Tested in both Yosemite and Ubuntu 14.04. Python 3.4.3.
Downgrading to Requests 2.6.0 solves the issue.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4",
"events_url": "https://api.github.com/users/sethmlarson/events{/privacy}",
"followers_url": "https://api.github.com/users/sethmlarson/followers",
"following_url": "https://api.github.com/users/sethmlarson/following{/other_user}",
"gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sethmlarson",
"id": 18519037,
"login": "sethmlarson",
"node_id": "MDQ6VXNlcjE4NTE5MDM3",
"organizations_url": "https://api.github.com/users/sethmlarson/orgs",
"received_events_url": "https://api.github.com/users/sethmlarson/received_events",
"repos_url": "https://api.github.com/users/sethmlarson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sethmlarson",
"user_view_type": "public"
}
|
{
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/2573/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2573/timeline
| null |
completed
| null | null | false |
[
"@Nelluk Can you provide more information on what causes this? Which server are you accessing, etc?\n\nAt the moment, the most likely change in that delta is the fact that we slightly changed our default SSL cipher list:\n\n```\n- ECDH+AESGCM:DH+AESGCM:ECDH+AES256:DH+AES256:ECDH+AES128:DH+AES:ECDH+3DES:DH+3DES:RSA+AESGCM:RSA+AES:RSA+3DES:!aNULL:!MD5:!DSS\n+ ECDH+AESGCM:DH+AESGCM:ECDH+AES256:DH+AES256:ECDH+AES128:DH+AES:ECDH+HIGH:DH+HIGH:ECDH+3DES:DH+3DES:RSA+AESGCM:RSA+AES:RSA+HIGH:RSA+3DES:!aNULL:!eNULL:!MD5\n```\n\nIt's possible this is causing a problem, though it's tricky to see how: knowing what server you're contacting would help me diagnose in that regard.\n",
"Some experimentation in IRC shows this to be transient: sometimes it works, sometimes it doesn't, but it only ever fails to work in 2.6.2: it always works in 2.6.0.\n\nThis suggests one of the two servers at this host has a bad cipher configuration that we don't like. Looking at the successful handshake, from 2.6.0 we negotiate TLS_RSA_WITH_RC4_128_SHA (a truly terrible cipher), whereas from 2.6.2 we negotiate TLS_RSA_WITH_3DES_EDE_CBC_SHA (still not great, but a bit better).\n\nLooks like the change to make is to pass a custom cipher set.\n",
"That said, it looks like RC4 should have been forbidden in the old codebase: I assume I'm missing a change where we now always override the stdlib cipher suite.\n",
"Before we conditionally used our own cipher suite. Now we unconditionally use it.\n",
"Right, that'll do it. So, we probably broke some stuff there: we should at the very least blog about how to change the cipher suite.\n\nCory\n\n> On 26 Apr 2015, at 14:48, Ian Cordasco [email protected] wrote:\n> \n> Before we conditionally used our own cipher suite. Now we unconditionally use it.\n> \n> —\n> Reply to this email directly or view it on GitHub.\n",
"Any follow up on that blog? Im hitting this issue in Python 2.7.9. How do we go about putting in a custom cipher suite?\n\n[Edit] Im using requests 2.7.0 and downgrading to 2.6.0 also works for me.\n",
"For the moment, setting a custom cipher suite is done by changing `requests.packages.urllib3.util.ssl_.DEFAULT_CIPHERS` (or `requests.packages.urllib3.contrib.pyopenssl.DEFAULT_CIPHER_LIST` if you're using PyOpenSSL: best to change both).\n\nI'm holding off on a more formal bit of documentation for now because ideally we'll land a 'custom SSL context' patch into urllib3 that will make this API way better.\n",
"If I am writing an update for this issue, should I use Python 2.7.8 or should I use Python 3?\n",
"Ideally, both. =)\n",
"Does the above PR fix this issue or are does it fix something else related to this issue?\n",
"I have no idea: I strongly suggest that you ask in the PR itself. It was never opened against the requests project. \n",
"Hah, sorry, I read too fast, should have looked at the proejct it was referenced in, I thought it was this one. My bad.\n",
"I'm getting this with v2.12.4, only the line number is different:\r\n`requests.exceptions.SSLError: [SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:749)`\r\n\r\nEDIT\r\nChanging the value `requests.packages.urllib3.util.ssl_.DEFAULT_CIPHERS` to the old value fixes the issue for me.\r\n\r\nIn 2.12.4 there is no `requests.packages.urllib3.contrib.pyopenssl.DEFAULT_CIPHER_LIST` - do you mean ` requests.packages.urllib3.contrib.pyopenssl.ssl._DEFAULT_CIPHERS`?\r\n\r\n> Lukasa commented on 14 May 2015\r\n> \r\n> For the moment, setting a custom cipher suite is done by changing \r\n> requests.packages.urllib3.util.ssl_.DEFAULT_CIPHERS (or \r\n> requests.packages.urllib3.contrib.pyopenssl.DEFAULT_CIPHER_LIST if\r\n> you're using PyOpenSSL: best to change both).\r\n>\r\n",
"No, there is now only one cipher list in urllib3: no need to change both.",
"Same problem here with versions `2.12.1` and `2.13.0`.\r\n\r\nHotfixed with this:\r\n\r\n import requests\r\n requests.packages.urllib3.util.ssl_.DEFAULT_CIPHERS = \\\r\n requests.packages.urllib3.contrib.pyopenssl.ssl._DEFAULT_CIPHERS\r\n response = requests.get(...)",
"I could get this to work only with:\r\n\r\n```\r\nrequests[security]==2.7.0 # not 2.18.x\r\ncryptography==1.9 # not 2.0\r\n```",
"@michi88 Please open a new bug report with a complete description of your problem. ",
"The versions in this issue are all ancient, if this issue is still occurring please reopen a new issue with supported versions of Requests+Python."
] |
https://api.github.com/repos/psf/requests/issues/2572
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2572/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2572/comments
|
https://api.github.com/repos/psf/requests/issues/2572/events
|
https://github.com/psf/requests/pull/2572
| 70,964,869 |
MDExOlB1bGxSZXF1ZXN0MzQxMTI3MTA=
| 2,572 |
Add basic contributing guide
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-04-25T20:39:52Z
|
2021-09-08T08:00:48Z
|
2015-04-25T21:34:45Z
|
MEMBER
|
resolved
|
For #2560.
This is adapted from hyper's contributing guide.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2572/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2572/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2572.diff",
"html_url": "https://github.com/psf/requests/pull/2572",
"merged_at": "2015-04-25T21:34:45Z",
"patch_url": "https://github.com/psf/requests/pull/2572.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2572"
}
| true |
[
"Requests should always be capitalized. \n",
"cleaned this up a bit, removed some things i found a bit too serious :)\n"
] |
https://api.github.com/repos/psf/requests/issues/2571
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2571/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2571/comments
|
https://api.github.com/repos/psf/requests/issues/2571/events
|
https://github.com/psf/requests/issues/2571
| 70,886,124 |
MDU6SXNzdWU3MDg4NjEyNA==
| 2,571 |
Post vs Get
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1729141?v=4",
"events_url": "https://api.github.com/users/bmutinda/events{/privacy}",
"followers_url": "https://api.github.com/users/bmutinda/followers",
"following_url": "https://api.github.com/users/bmutinda/following{/other_user}",
"gists_url": "https://api.github.com/users/bmutinda/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bmutinda",
"id": 1729141,
"login": "bmutinda",
"node_id": "MDQ6VXNlcjE3MjkxNDE=",
"organizations_url": "https://api.github.com/users/bmutinda/orgs",
"received_events_url": "https://api.github.com/users/bmutinda/received_events",
"repos_url": "https://api.github.com/users/bmutinda/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bmutinda/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bmutinda/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bmutinda",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 9 |
2015-04-25T09:59:07Z
|
2021-09-08T23:04:58Z
|
2015-04-25T10:11:00Z
|
NONE
|
resolved
|
Why is this that if I make a post request without a "/" at the end of the url I can't access the params with $_POST[] in php but the param is available in the $_REQUEST. Is there something that I am doing wrong?
Here is my code
``` python
import requests
# version1 - POST params are accessible
payload = {"message": "my message here"}
r = requests.post("http://localhost/apps/myapp/", data=payload)
print r.text
# version2 - POST params not available
r = requests.post("http://localhost/apps/myapp", data=payload)
print r.text
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2571/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2571/timeline
| null |
completed
| null | null | false |
[
"My guess is that your PHP app redirects from the URL that doesn't have a `/` to the one that does, and when it does so it uses a status code that causes us to convert our POST to a GET.\n\nYou should check what your PHP application is up to.\n",
"@Lukasa - there is no redirection in my php code. this is what the myapp index.php file looks like \n\n``` php\n<?php \necho \"dasdasd\";\necho json_encode( $_POST );\nexit();\n?>\n```\n",
"In both cases can you `print r.history` from your Python code?\n",
"sorry! with the / , the history response is \n\n``` python\n[]\n```\n\nwhile the other one the response is \n\n``` python\n<Response [301]>\n```\n",
"So as you can see, the second request _is_ being redirected. Your PHP application may not be doing it on purpose, but it's definitely happening.\n",
"@Lukasa realized the same thing too. Just seen a note from this link http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html that \n\n```\nNote: When automatically redirecting a POST request after\nreceiving a 301 status code, some existing HTTP/1.0 user agents\nwill erroneously change it into a GET request.\n```\n\nThe redirection might be in the server configuration if the fallback is not done in the requests lib..\n",
"Yeah, 'erroneously' is an out-of-date note. From the more recent RFC 7231:\n\n> Note: For historical reasons, a user agent MAY change the request method from POST to GET for the subsequent request. If this behavior is undesired, the 307 (Temporary Redirect) status code can be used instead.\n",
"@Lukasa do you have an alternative fix for this that would force the post request to be treated as a post no matter what?? Its an app that I am building that would require developers to put their urls so that I can ping their url with post params only. \n",
"@mutindaz so you _might_ be able to do something like\n\n``` py\nis_redirect = True\nwhile is_redirect:\n r = requests.head(url)\n is_redirect = r.is_redirect\n url = r.headers.get('Location', url)\nrequests.post(url, data=payload)\n```\n\nBut there are some issues with doing that.\n1. The site may not react well to a `HEAD` request at that resource\n2. The URI in the `Location` header may not be a URL of the form `{scheme}://{host}/{path}` but could be only parts of that and so requests will barf\n3. That could loop forever if there's a redirect loop.\n\nThat would be a \"simple\" way of doing it (although there are things wrong with it).\n\nThe more difficult thing to do would be to handle the request/redirect cycle yourself. For that, you'll need to begin using a session object and the `Request` objects. I don't use those frequently so I can't just hammer out a rough example for you but it would look something like (this is very much pseudo-code):\n\n``` py\nsession = requests.Session()\nrequest = requests.Request(method='POST', url=url, data=payload)\nprepped = session.prepare_request(request)\nresponse = session.send(prepped)\nwhile response.is_redirect:\n prepped, old_prepped = prepped.copy(), prepped\n # Lift some of https://github.com/kennethreitz/requests/blob/ca66267d2cf8adc67ed8857f3f57b45ffde21e01/requests/sessions.py#L119..L139\n prepped.url = to_native_string(url)\n response = session.send(prepped)\n```\n\nThat assumes a few things:\n1. That you have no concern for exposing data to a server that shouldn't see it (which is why on certain redirects we change the method and remove the body)\n2. That you are certain that handling these redirects is what you want to do\n3. That you don't care about preserving the history\n4. That you're willing to follow an arbitrary and unknown (and potentially infinite) number of redirects\n\nPersonally, I think we could factor the url handling in [this section of code](https://github.com/kennethreitz/requests/blob/ca66267d2cf8adc67ed8857f3f57b45ffde21e01/requests/sessions.py#L119..L139) out into its own method like we have `prepare_request` but this is such a 2% use-case that I'm not confident it will be a worthwhile refactor.\n"
] |
https://api.github.com/repos/psf/requests/issues/2570
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2570/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2570/comments
|
https://api.github.com/repos/psf/requests/issues/2570/events
|
https://github.com/psf/requests/pull/2570
| 70,830,165 |
MDExOlB1bGxSZXF1ZXN0MzQwOTY3MjE=
| 2,570 |
Add new release process to docs
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-04-25T00:29:09Z
|
2021-09-08T08:00:48Z
|
2015-04-25T21:46:31Z
|
CONTRIBUTOR
|
resolved
|
Closes #2569
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2570/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2570/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2570.diff",
"html_url": "https://github.com/psf/requests/pull/2570",
"merged_at": "2015-04-25T21:46:31Z",
"patch_url": "https://github.com/psf/requests/pull/2570.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2570"
}
| true |
[
"Looks good, some small notes.\n"
] |
https://api.github.com/repos/psf/requests/issues/2569
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2569/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2569/comments
|
https://api.github.com/repos/psf/requests/issues/2569/events
|
https://github.com/psf/requests/issues/2569
| 70,694,577 |
MDU6SXNzdWU3MDY5NDU3Nw==
| 2,569 |
[Proposal] New Release Management Process
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-04-24T13:43:18Z
|
2021-09-08T23:04:58Z
|
2015-04-25T21:46:31Z
|
CONTRIBUTOR
|
resolved
|
In v2.6.1 we pulled in a new copy of urllib3. Typically this doesn't negatively affect us but in this case we've seen a bunch of new issues from the chunked encoding refactor in urllib3. Because that kind of stuff _should_ not break in a `.x` release I'm proposing we follow this process when preparing releases (and that we document it for the future):
For an `v*.*.x` release, e.g., `v2.6.1`, `v2.6.2`, `v2.6.3`, etc. we _only_ include changes to requests itself. This means anything that does not live in `requests/packages/{urllib3,chardet}/*`.
For a `v*.x.0` release, e.g., `v2.6.0`, `v2.7.0`, etc. we include changes to requests _and_ update the vendored libraries. The same goes for a `vx.0.0` release, but of course those have other implications as well.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2569/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2569/timeline
| null |
completed
| null | null | false |
[
"+1. Write it down in the docs, let's make it so.\n",
":cake: Will do tonight or tomorrow morning\n"
] |
https://api.github.com/repos/psf/requests/issues/2568
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2568/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2568/comments
|
https://api.github.com/repos/psf/requests/issues/2568/events
|
https://github.com/psf/requests/issues/2568
| 70,680,582 |
MDU6SXNzdWU3MDY4MDU4Mg==
| 2,568 |
Keep-alive broken in 2.6.1 and 2.6.2 with chunked transfer-encoding
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/6117199?v=4",
"events_url": "https://api.github.com/users/lmikkelsen/events{/privacy}",
"followers_url": "https://api.github.com/users/lmikkelsen/followers",
"following_url": "https://api.github.com/users/lmikkelsen/following{/other_user}",
"gists_url": "https://api.github.com/users/lmikkelsen/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lmikkelsen",
"id": 6117199,
"login": "lmikkelsen",
"node_id": "MDQ6VXNlcjYxMTcxOTk=",
"organizations_url": "https://api.github.com/users/lmikkelsen/orgs",
"received_events_url": "https://api.github.com/users/lmikkelsen/received_events",
"repos_url": "https://api.github.com/users/lmikkelsen/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lmikkelsen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lmikkelsen/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lmikkelsen",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] |
{
"closed_at": "2015-06-09T19:04:55Z",
"closed_issues": 1,
"created_at": "2015-01-18T20:07:07Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
},
"description": "",
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/24",
"id": 940766,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/24/labels",
"node_id": "MDk6TWlsZXN0b25lOTQwNzY2",
"number": 24,
"open_issues": 0,
"state": "closed",
"title": "2.7.0",
"updated_at": "2015-06-09T19:04:55Z",
"url": "https://api.github.com/repos/psf/requests/milestones/24"
}
| 8 |
2015-04-24T12:41:40Z
|
2021-09-08T23:04:53Z
|
2015-05-03T15:03:10Z
|
NONE
|
resolved
|
Starting in 2.6.1 an exception is thrown if a connection with chunked transfer-encoding is reused. I suspect that the bug is in the bundled urllib3 which was upgraded from 1.10.2 to 1.10.3.
``` python
#!/usr/bin/env python
import requests
s = requests.Session()
r = s.get('http://httpbin.org/stream/1')
r.json()
r = s.get('http://httpbin.org/stream/1')
r.json()
```
```
$ ./test.py
Traceback (most recent call last):
File "./test.py", line 10, in <module>
r = s.get('http://httpbin.org/stream/1')
File "[...]/requests/requests/sessions.py", line 477, in get
return self.request('GET', url, **kwargs)
File "[...]/requests/requests/sessions.py", line 465, in request
resp = self.send(prep, **send_kwargs)
File "[...]/requests/requests/sessions.py", line 573, in send
r = adapter.send(request, **kwargs)
File "[...]/requests/requests/adapters.py", line 415, in send
raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', ResponseNotReady())
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2568/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2568/timeline
| null |
completed
| null | null | false |
[
"> I suspect that the bug is in the bundled urllib3 which was upgraded from 1.10.2 to 1.10.3.\n\nAs do I: can you open this bug over there, please? We'll fix it in that repository.\n",
"We should start preparing requests 2.7.0 with the fix for shazow/urllib3#598\n",
"Is there any workaround for this? I've gone back to 2.6.0 for now.\n",
"@rfortress I'm afraid not. We're working on this, there are a number of other problems with the chunked change and we'd like to land them at all once if we possibly can.\n\nI'm genuinely sorry for how long this is taking. =(\n",
"Version 2.5.1 is latest version now? Isn't this version affected by: http://www.cve.mitre.org/cgi-bin/cvename.cgi?name=2015-2296\n",
"The latest and affected by the bug in question, is 2.6.2. The latest that is **not** affected by the bug in question, seems to be 2.6.0 -- and it works well for me.\n",
"Correct, 2.6.0 is the version to use to avoid this bug.\n",
"I have just cut requests 2.7.0, which I believe resolves this problem (and several related ones). Thank you all for your patience!\n"
] |
https://api.github.com/repos/psf/requests/issues/2567
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2567/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2567/comments
|
https://api.github.com/repos/psf/requests/issues/2567/events
|
https://github.com/psf/requests/pull/2567
| 70,647,200 |
MDExOlB1bGxSZXF1ZXN0MzQwMzQ4MDk=
| 2,567 |
Import aliases for Debian
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/837573?v=4",
"events_url": "https://api.github.com/users/untitaker/events{/privacy}",
"followers_url": "https://api.github.com/users/untitaker/followers",
"following_url": "https://api.github.com/users/untitaker/following{/other_user}",
"gists_url": "https://api.github.com/users/untitaker/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/untitaker",
"id": 837573,
"login": "untitaker",
"node_id": "MDQ6VXNlcjgzNzU3Mw==",
"organizations_url": "https://api.github.com/users/untitaker/orgs",
"received_events_url": "https://api.github.com/users/untitaker/received_events",
"repos_url": "https://api.github.com/users/untitaker/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/untitaker/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/untitaker/subscriptions",
"type": "User",
"url": "https://api.github.com/users/untitaker",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] |
{
"closed_at": "2015-10-12T10:32:06Z",
"closed_issues": 7,
"created_at": "2015-04-29T13:03:39Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
},
"description": "",
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/25",
"id": 1089203,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/25/labels",
"node_id": "MDk6TWlsZXN0b25lMTA4OTIwMw==",
"number": 25,
"open_issues": 0,
"state": "closed",
"title": "2.8.0",
"updated_at": "2015-10-12T10:32:06Z",
"url": "https://api.github.com/repos/psf/requests/milestones/25"
}
| 63 |
2015-04-24T10:05:43Z
|
2021-09-08T06:00:57Z
|
2015-10-05T14:09:46Z
|
CONTRIBUTOR
|
resolved
|
Alternative to #2375, on the risk of being naive...
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2567/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2567/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2567.diff",
"html_url": "https://github.com/psf/requests/pull/2567",
"merged_at": "2015-10-05T14:09:46Z",
"patch_url": "https://github.com/psf/requests/pull/2567.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2567"
}
| true |
[
"@sigmavirus24 You own this logic for the most part: how does this look?\n",
"Also I suppose it'd be nice if @dcramer tries this (because of https://github.com/kennethreitz/requests/issues/2558)\n",
"It _looks_ okay but I want to toy with it a bit before we merge it.\n",
"If you're fine with this, I'd like to add a module docstring (or comment) that explains the whole situation before merging.\n",
"@untitaker why not just add it while I'm testing it?\n",
"I just meant to say that so you don't merge this too soon.\n",
"From my POV this seems safe. @mitsuhiko might have better feedback\n",
"@untitaker thanks for working on this. Just for reference, here is what it's used in Debian at the moment:\nhttps://anonscm.debian.org/viewvc/python-modules/packages/requests/trunk/debian/patches/04_make-requests.packages.urllib3-same-as-urllib3.patch?revision=32576&view=markup\n\nYes, I'm exporting only urllib3 since importing chardet from requests.packages seems not used, at least no one complained about this.\n\nI choosed to not cherry pick #2375 due the problems emerged: I don't want Debian and Ubuntu users to have a system version of requests not in the best shape: it will give only more problems.\n",
"Seems good @eriol. Would you adopt a solution offered by requests though, to avoid Distro-specific breakage?\n\nBTW @sigmavirus24 this is ready for review.\n",
"@untitaker of course I will like to drop a custom patch! :smile:\nI had to write more to explain better my opinion, sorry for this. My opinion is that less divergence from upstream is the better, and it's for this reason that I forward all modification non Distro-specific to upstream.\nFurthermore the Debian patch is not perfect, see [Debian Bug #771349](https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=771349).\nSo to recap I will be extremely happy to drop 04_make-requests.packages.urllib3-same-as-urllib3.patch in favor of an upstream solution.\nThanks!\n",
"This works well for me. Objections to merging @Lukasa?\n",
"@sigmavirus24 I'm super reluctant to rush this out, given the way stuff previously went. Can we try to tap people who've had problems/objections in the past and get them to confirm that this works better for them?\n",
"I'll try to reach mitsuhiko\n",
"@untitaker did you mean @mitsuhiko? I would hope a direct ping would suffice.\n\n---\n\n@Lukasa I would argue this is probably, on the whole, better than our previous meta_path hackery for several reasons:\n1. It provides the same functionality\n2. It's significantly simpler (simple is better than complex)\n3. It allows for all of this to work in the case where requests is vendored without its vendored dependencies (see @untitaker's use of `__name__` when adding the alias to `sys.modules`)\n4. It doesn't mess with other meta_path plugins (e.g., PyInstaller, the hack that @dcramer and @mitsuhiko are using, etc.)\n5. It falls back in the correct order\n6. It's far easier to explain to someone\n7. When urllib3 is not vendored, the following works as we'd like it to:\n \n ``` py\n import urllib3\n from requests.packages import urllib3 as rurllib3\n urllib3 is rurllib3\n ```\n\nI have yet to test this with PyInstaller, but the root of the problem there was the fact that our meta_path plugin was in the wrong place relative to the multiple plugins that PyInstaller uses. So with that removed, this should just work. I'm also confident that if @mitsuhiko and @dcramer test this with their code that hacks the meta_path, then they'll not see any problems.\n",
"@sigmavirus24\n\n> @untitaker did you mean @mitsuhiko? I would hope a direct ping would suffice.\n\nUnfortunately I don't think so. I haven't heard back from him either, perhaps\n@dcramer can ping him about that?\n\n---\n\n@eriol BTW this should also remove the need to rewrite every import statement\ninside requests itself.\n",
"@sigmavirus24 I'm not disputing better at all. =) What I'd like to do is to take all reasonable precautions to reduce the risk of deploying this fix. For example, can @eriol and @ralphbean confirm that their package building functions correctly with this patch?\n\nBasically, rushing helps nobody, and I'd like to try to begin a run of stable requests releases if at all possible. The last run of four-or-five broken releases in a row is bad, and we need to not get in the habit of doing that.\n",
"@Lukasa Note that I'm not arguing for this to be merged with a release to follow immediately after. We could even defer this to 3.0 if you want to not rush it (which I don't think we're doing frankly). The current state of affairs only makes end users' lives more difficult at this point.\n",
"@Lukasa if is it possible I would like to have a bit more of time: right now I'm checking reverse dependencies of requests in Debian to not break stuff, see: https://lists.debian.org/debian-python/2015/05/msg00021.html (@sigmavirus24 thanks for details, I did not have time to reply on the list, but your mail was appreciated :smile:).\nI should finish during this week, so should be able to cherry pick and test this immediately after.\n",
"@eriol always happy to help. We don't have a release planned so we don't have a timeline for when this would be merged. Take your time. Don't stress out. We'll be here and so will the patch. =D\n",
"How to down the the code?\n",
"@wangshaochen you can just add \".patch\" to PR URL:\nhttps://github.com/kennethreitz/requests/pull/2567.patch\n\nHTH!\n",
"@eriol Ths! I yet don't know. with command_line? \n",
"It's not clear what you want to do. Could you tell us more?\n",
"i'm sorry. this is my first-time see it.\n",
"@Lukasa @sigmavirus24 any updates on this?\n",
"We're still hoping to have @eriol and/or @ralphbean take a swing at this code and confirm it's working for them.\n",
"I waited to upload requests 2.7.0 in unstable (I uploaded into experimental first) to give httpie maintainer the time to update Debian package (we had httpie 0.8).\nUnfortunately this week I'm too busy, so I can cherry pick and test only starting from next week.\n",
"Looks good here!\n",
"Sorry for the delay! I have tested it and all seem fine! Many thanks @untitaker!\n",
"\\o/ Alright, I'm happy to cautiously wave this through.\n"
] |
https://api.github.com/repos/psf/requests/issues/2566
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2566/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2566/comments
|
https://api.github.com/repos/psf/requests/issues/2566/events
|
https://github.com/psf/requests/issues/2566
| 70,638,217 |
MDU6SXNzdWU3MDYzODIxNw==
| 2,566 |
Runtime Error
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/2977844?v=4",
"events_url": "https://api.github.com/users/caimaoy/events{/privacy}",
"followers_url": "https://api.github.com/users/caimaoy/followers",
"following_url": "https://api.github.com/users/caimaoy/following{/other_user}",
"gists_url": "https://api.github.com/users/caimaoy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/caimaoy",
"id": 2977844,
"login": "caimaoy",
"node_id": "MDQ6VXNlcjI5Nzc4NDQ=",
"organizations_url": "https://api.github.com/users/caimaoy/orgs",
"received_events_url": "https://api.github.com/users/caimaoy/received_events",
"repos_url": "https://api.github.com/users/caimaoy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/caimaoy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/caimaoy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/caimaoy",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2015-04-24T09:26:44Z
|
2021-09-08T23:04:52Z
|
2015-05-03T15:04:33Z
|
NONE
|
resolved
|
just requests.post()
.py file is ok, but I packaged .py file to .exe file with pyinstaller in win7 32bits, and then when I ran the .exe file in a win7 64bits matchine, It was like this.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2566/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2566/timeline
| null |
completed
| null | null | false |
[
"This does not like it could possibly be our problem. Do you see this if you replace the requests import with an import of any other third party library?\n",
"```\n# -*- coding: UTF-8 -*-\n\n'''\nLast modified time: 2015-04-24 17:16:47\nEdit time: 2015-04-24 17:17:16\nFile name: text.py\nEdit by caimaoy\n'''\n\nimport requests\n\nif __name__ == '__main__':\n print 'aaa'\n requests.post(r'http://172.17.201.21:5000/upload', data={'test':'test'})\n```\n\nthis is my code ...\n",
"Do you see this if you replace the requests import with an import of any other third party library?\n",
"Closing for inactivity.\n"
] |
https://api.github.com/repos/psf/requests/issues/2565
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2565/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2565/comments
|
https://api.github.com/repos/psf/requests/issues/2565/events
|
https://github.com/psf/requests/issues/2565
| 70,570,132 |
MDU6SXNzdWU3MDU3MDEzMg==
| 2,565 |
regression over 2.6.0 with session behind proxy
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/12093095?v=4",
"events_url": "https://api.github.com/users/AlphaScorpii-dev/events{/privacy}",
"followers_url": "https://api.github.com/users/AlphaScorpii-dev/followers",
"following_url": "https://api.github.com/users/AlphaScorpii-dev/following{/other_user}",
"gists_url": "https://api.github.com/users/AlphaScorpii-dev/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/AlphaScorpii-dev",
"id": 12093095,
"login": "AlphaScorpii-dev",
"node_id": "MDQ6VXNlcjEyMDkzMDk1",
"organizations_url": "https://api.github.com/users/AlphaScorpii-dev/orgs",
"received_events_url": "https://api.github.com/users/AlphaScorpii-dev/received_events",
"repos_url": "https://api.github.com/users/AlphaScorpii-dev/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/AlphaScorpii-dev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AlphaScorpii-dev/subscriptions",
"type": "User",
"url": "https://api.github.com/users/AlphaScorpii-dev",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 13 |
2015-04-24T02:58:22Z
|
2021-09-08T23:04:54Z
|
2015-04-25T18:32:27Z
|
NONE
|
resolved
|
Hello everyone
Here is a piece of code that used to work until Requests 2.6.0
``` python
def __init__(self, proxy=None):
super(Model, self).__init__()
self.br = requests.Session()
if proxy is not None:
self.br.proxies = {"http": proxy, "https": proxy}
def __open_http(self, encoding, root_url):
if codecs.lookup(encoding).name == "shift_jis":
encoding = "cp932"
def open_http(method, url, values):
val = {x: y.encode(encoding) for (x, y) in values if y}
url = urljoin(root_url, url)
if method == "GET":
return self.br.get(url=url, params=val)
elif method == "POST":
return self.br.post(url=url, params=val)
return open_http
def login(self, user, password):
url = "http://mysite.html"
data = {"aACTION": "mailbox"}
reply = self.br.get(url=url, params=data)
doc = lxml.html.fromstring(reply.text)
form = doc.forms[1]
form.fields["aEMAIL"] = user
form.fields["aPASSWORD"] = password
response = lxml.html.submit_form(form, open_http=self.__open_http(encoding=reply.encoding, root_url=reply.url))
```
Since I upgraded to 2.6.1, I noticed that this login function would fail when I'm behind a proxy.
I did some debugging in the console, with 2.6.2, and could get the following.
1) the code works just fine with no proxy
2) when calling self.br.post(url=url, params=val), I always need to call it twice before having a valid reply. The first time results in a ResponseNotReady exception
3) when calling directly from requests.post instead of session.post, it works from the first time, even behind a proxy
Here is also the stacktrace I get
``` python
Traceback (most recent call last):
File "C:\Python34\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 544, in urlopen
body=body, headers=headers)
File "C:\Python34\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 374, in _make_request
httplib_response = conn.getresponse()
File "C:\Python34\lib\http\client.py", line 1164, in getresponse
raise ResponseNotReady(self.__state)
http.client.ResponseNotReady: Request-sent
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Python34\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 544, in urlopen
body=body, headers=headers)
File "C:\Python34\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 374, in _make_request
httplib_response = conn.getresponse()
File "C:\Python34\lib\http\client.py", line 1164, in getresponse
raise ResponseNotReady(self.__state)
http.client.ResponseNotReady: Request-sent
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Python34\lib\site-packages\requests\adapters.py", line 370, in send
timeout=timeout
File "C:\Python34\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 597, in urlopen
_stacktrace=sys.exc_info()[2])
File "C:\Python34\lib\site-packages\requests\packages\urllib3\util\retry.py",line 245, in increment
raise six.reraise(type(error), error, _stacktrace)
File "C:\Python34\lib\site-packages\requests\packages\urllib3\packages\six.py", line 309, in reraise
raise value.with_traceback(tb)
File "C:\Python34\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 544, in urlopen
body=body, headers=headers)
File "C:\Python34\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 374, in _make_request
httplib_response = conn.getresponse()
File "C:\Python34\lib\http\client.py", line 1164, in getresponse
raise ResponseNotReady(self.__state)
requests.packages.urllib3.exceptions.ProtocolError: ('Connection aborted.', ResponseNotReady('Request-sent',))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "F:\MyApp\MyApp.py", line 148, in updateModel
data_model.login(myaddress, mypassword)
File "F:\MyApp\model.py", line 108, in login
response = lxml.html.submit_form(form, open_http=self.__open_http(encoding=reply.encoding, root_url=reply.url))
File "C:\Python34\lib\site-packages\lxml\html\__init__.py", line 953, in submit_form
return open_http(form.method, url, values)
File "F:\MyApp\model.py", line 97, in open_http
return self.br.post(url=url, params=val)
File "C:\Python34\lib\site-packages\requests\sessions.py", line 508, in post
return self.request('POST', url, data=data, json=json, **kwargs)
File "C:\Python34\lib\site-packages\requests\sessions.py", line 465, in request
resp = self.send(prep, **send_kwargs)
File "C:\Python34\lib\site-packages\requests\sessions.py", line 573, in send
r = adapter.send(request, **kwargs)
File "C:\Python34\lib\site-packages\requests\adapters.py", line 415, in send
raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', ResponseNotReady('Request-sent',))
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2565/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2565/timeline
| null |
completed
| null | null | false |
[
"Are you sure that it doesn't work the _first_ time in your sample code, and fail thereafter?\n",
"Indeed you are right... Sorry for the confusion.\nIn my case the first get is indeed sucessful, then the post fails, and i\nneed to send it a second time to make things work correctly.\n",
"Ok, so the problem we have is that the httplib state machine believes there's an outstanding web response that we haven't consumed. Most likely this occurs because `HTTPResponse.isclosed()` on the old response is returning `False`.\n\nWorking out exactly why is going to be tricky. Can I see the response headers, please?\n",
"Which ones would you want ?\nThe ones after the first successful response ?\n",
"I doubt you can get the headers for those, I want the first one.\n",
"ok here we go\nthis is what I get after the first GET request\n\n{'transfer-encoding': 'chunked', 'x-powered-by': 'PleskLin', 'server':\n'Apache',\n 'set-cookie': 'jgid_ip=91.103.42.50; path=/, jgid_time=1429857762; path=/,\ngeo_c=0; path=/, geo_country_c=FR; path=/, jg_test=set; expires=Sun,\n24-May-2015 06:42:42 GMT; path=/',\n'content-type':'text/html;charset=shift-jis', 'date': 'Fri, 24 Apr 2015\n06:42:42 GMT', 'ms-author-via': 'DAV', 'connection': 'Keep-Alive'}\n",
"Chunked is exactly what I expected.\n\nCan you try hitting any URL that does not return chunked data and check whether you still see this problem? @sigmavirus24 @shazow Looks like the chunked-encoding logic has a problem with proxy connections.\n",
"I'm starting to expect that https://github.com/kennethreitz/requests/issues/2568 and this are related and it's because Tomas, while using internal attributes and methods on the httplib response, did not try to catch all the exceptions that can be raised by them. Looks like my re-factor will need to be a lot more thorough than we thought.\n\nProposal: 2.6.3 is released reverting the changes to urllib3 and only including the changes to `requests/packages/__init__.py` since this otherwise was working fine.\n",
"Sadly, I think we may have to do that.\n\nUgh.\n",
"I believe this is the same as #2568, so I'm closing to focus conversation there.\n",
"Fwiw, it seems to me that if the first response doesn't include a content-length this could cripple the state of the client connection.\n",
"@wbolster All responses must do one of the following: have a content-length, have a chunked transfer encoding, or close the connection when they're done. We know we have a bug with chunked, but when that's resolved there should be no problems. =)\n",
"Yeah, I was hit by that bug. Omitting a Content-Type header from the response (on a server within my control) caused the wsgi server to go with chunked encoding... which triggered the `requests` bug.\n"
] |
https://api.github.com/repos/psf/requests/issues/2564
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2564/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2564/comments
|
https://api.github.com/repos/psf/requests/issues/2564/events
|
https://github.com/psf/requests/issues/2564
| 70,462,809 |
MDU6SXNzdWU3MDQ2MjgwOQ==
| 2,564 |
requests (2.6.1) sometimes does not decompress gzip-encoded content
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1677933?v=4",
"events_url": "https://api.github.com/users/convexset/events{/privacy}",
"followers_url": "https://api.github.com/users/convexset/followers",
"following_url": "https://api.github.com/users/convexset/following{/other_user}",
"gists_url": "https://api.github.com/users/convexset/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/convexset",
"id": 1677933,
"login": "convexset",
"node_id": "MDQ6VXNlcjE2Nzc5MzM=",
"organizations_url": "https://api.github.com/users/convexset/orgs",
"received_events_url": "https://api.github.com/users/convexset/received_events",
"repos_url": "https://api.github.com/users/convexset/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/convexset/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/convexset/subscriptions",
"type": "User",
"url": "https://api.github.com/users/convexset",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-04-23T17:08:46Z
|
2021-09-08T23:04:59Z
|
2015-04-23T17:30:51Z
|
NONE
|
resolved
|
I've been trying out the DigitalOcean API when I encountered the following "problem" with requests (2.6.1):
```
token = "xxxxxxxxxxxxxx"
api = "/account/keys"
headers = {"Content-Type": "application/json", "Authorization": "Bearer "+token}
r = requests.get("https://api.digitalocean.com/v2/"+api, headers=headers, data=data)
```
... results in output for r.content and r.text like...
```
'\x1f\x8b\x08\x00\x00\x00\x00\x00\x00\x03mR\xd9\xae\xa2@\x14\xfc\x95\x9b~\xd5\x19\x96\x06\x81Nn2(^\x14\x95\xc5\x05\xc5\xc9d\xd2t\xb7\n\xb2\xc9\xa6h\xfc\xf7a\xe6y\xce\xc3IUN\xaa\xea\xa1\xce\x0bT\xd5\xe5\xf7\x95u\x15@?_ \xa2\x00)P\x82<\x1c\x82S\x94\x9dYY\x94QV\x03\x04h\x88\xa0\x8c DPA#\x01\x11\x19i<\x12\t\xc2\x1aR%D)\x12\x05D\x05\xa4\xa9(<!\x85\x81!(\x9a0\x89\xc8_\xef^\xde\xa7|++\xfc\xa1\xf73\x86\xf6\x13O\x84\x8e\x88\xd3\x7ft~\xef\xb77\xd5\x85\x8b\x95^\x07\x83\xbd(\xd3\xb9f\xc0\xe7(\xd0\x06\xd0\x89oYP\xe4\xb9\xc2\xf9\xfb\xfc\x10\xedR\xe8u#\xb8.EM.}>\xc6\xce$\x9c\x8d\x0e\xc1\xed:\xad5\xee\xacz!\x9d\xc8d\x99\x19\xb9{\xbc1ek\x8a\xc6\x05\xe3\xb83w\xd3\x91_\xeb{\xb1c\xa4\x11f>]\x96\xf1ym\xca\xde\xf3\xde\x92\xb0\xb1\xa5\xa7\x15\xef\x14\x87\x97\xdb\x96O\x9d\x9d/rT\xa2\xf1\xa2\x13\x85\xbcQ7\xb6\xd9|\xe9\x87|\x99\xa8\xae\xa4\xb1\x95\xd4\x9et%\x0e\xd2\xc3\x02{\xa2\xdb\xf8\xb2\xe9\x06\xe3k\x97\x10\xb9*\x83\x88\x8ef\x92\x15\x84\xba\x91Y\xedT\xf8:[c\xc1\xa5\x0bC\x80\xcb\xbd2\xd8\x13\xc3\xa8!\x966\xdc\xa5\xd8\x1232\xb9\xc5\xca\xa0\xeb\xc6\x9e\x901~\xda\xa9\xee5\xbc\xbcN\xac\xbbAg~\xd6\xb9\xf3\xa2VI\xf2\x9c\x04\x85\xe2\xac\x8e\xcc\x91\xac\xf95\xc8}u\x93\\v\xb6Wp\x0f\x9a?,\x0f\x87\xcb4\x0e\xdc\xaea\x99\xfe\xb5=\xcd\x99S\xb5j\xa9\xdc;\xeex\xff\xfc\xfc y\xd6\xb2G\xc5\xea\x1f\xe7\x14G\xc9w\x92\xa7}?\x19NY\xdf\xcc\xff\x8e\xef_C\x90D\xd9\xb5\x7f\x8a\xd7{\x08RV\xe3\x1e\x81:\xafq\x02\x90\xf0~\xff\x01T\xdb#\x867\x02\x00\x00'
```
... which has to be ameliorated with...
```
import zlib
data = zlib.decompress(r.content, 16+zlib.MAX_WBITS)
```
... because `r.headers['content-encoding']` happens to be `'gzip'`.
It may be good to detect gzip and other compressive encodings and proactively decompress it. Or have a default option to decompress (because in some applications, premature decompression is undesirable).
But all this seems a bit unusual because the documentation says that "_Requests automatically decompresses gzip-encoded responses, and does its best to decode response content to unicode when possible._"
Same thing happens on CentOS Linux release 7.0.1406 (Core) (Python Python 2.7.5 via yum; requests 2.6.1) and OS X Yosemite 10.10.2 (Python 2.7.9 via Brew; requests 2.6.1).
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2564/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2564/timeline
| null |
completed
| null | null | false |
[
"This is a duplicate of #2561 (or #2562 - I'm on my phone and can't check). Upgrading to v2.6.2 will fix this.\n"
] |
https://api.github.com/repos/psf/requests/issues/2563
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2563/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2563/comments
|
https://api.github.com/repos/psf/requests/issues/2563/events
|
https://github.com/psf/requests/issues/2563
| 70,459,058 |
MDU6SXNzdWU3MDQ1OTA1OA==
| 2,563 |
Specify local port
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3183355?v=4",
"events_url": "https://api.github.com/users/vishalwy/events{/privacy}",
"followers_url": "https://api.github.com/users/vishalwy/followers",
"following_url": "https://api.github.com/users/vishalwy/following{/other_user}",
"gists_url": "https://api.github.com/users/vishalwy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/vishalwy",
"id": 3183355,
"login": "vishalwy",
"node_id": "MDQ6VXNlcjMxODMzNTU=",
"organizations_url": "https://api.github.com/users/vishalwy/orgs",
"received_events_url": "https://api.github.com/users/vishalwy/received_events",
"repos_url": "https://api.github.com/users/vishalwy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/vishalwy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vishalwy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/vishalwy",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-04-23T16:46:36Z
|
2021-09-08T23:04:59Z
|
2015-04-23T17:53:44Z
|
NONE
|
resolved
|
How do I specify the local port for the socket rather than picking up a random free port?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2563/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2563/timeline
| null |
completed
| null | null | false |
[
"You can do this using the [requests toolbelt](https://toolbelt.readthedocs.org/en/latest/). Get it by running `pip install requests-toolbelt`.\n\n``` python\n>>> import requests\n>>> from requests_toolbelt.adapters.source import SourceAddressAdapter\n>>> s = requests.Session()\n>>> s.mount('https://google.com', SourceAddressAdapter(('', 6666)))\n```\n"
] |
https://api.github.com/repos/psf/requests/issues/2562
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2562/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2562/comments
|
https://api.github.com/repos/psf/requests/issues/2562/events
|
https://github.com/psf/requests/issues/2562
| 70,417,288 |
MDU6SXNzdWU3MDQxNzI4OA==
| 2,562 |
Merge with requesocks
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/921251?v=4",
"events_url": "https://api.github.com/users/ikus060/events{/privacy}",
"followers_url": "https://api.github.com/users/ikus060/followers",
"following_url": "https://api.github.com/users/ikus060/following{/other_user}",
"gists_url": "https://api.github.com/users/ikus060/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ikus060",
"id": 921251,
"login": "ikus060",
"node_id": "MDQ6VXNlcjkyMTI1MQ==",
"organizations_url": "https://api.github.com/users/ikus060/orgs",
"received_events_url": "https://api.github.com/users/ikus060/received_events",
"repos_url": "https://api.github.com/users/ikus060/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ikus060/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ikus060/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ikus060",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 3 |
2015-04-23T13:50:36Z
|
2021-09-08T23:04:59Z
|
2015-04-23T14:13:47Z
|
NONE
|
resolved
|
Any plan to merge modification made to requests to support SOCKS proxy ?
See https://github.com/dvska/requesocks
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2562/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2562/timeline
| null |
completed
| null | null | false |
[
"It doesn't seem likely that we'll merge with requesocks as that hasn't been updated in over 2 years. Also that author never propsed a merge on their own.\n",
"May I propose to add this feature to requests ?\n",
"@ikus060 Many people have proposed it and even begun work: see #2425, #2156, #1982, shazow/urllib3#486, shazow/urllib3#284, shazow/urllib3#68, and shazow/urllib3#44.\n\nYou are welcome to attempt to do the work. The initial implementation should be over in urllib3: I recommend that you start work there.\n\nIf you were simply _requesting_ the feature, the core team does not believe it's an important enough priority to justify our development time. In practice, the absence of SOCKS support does not appear to be limiting the success of the library. For that reason, unless someone does the work for the implementation themselves, I do not believe we'll be implementing it ourselves.\n"
] |
https://api.github.com/repos/psf/requests/issues/2561
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2561/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2561/comments
|
https://api.github.com/repos/psf/requests/issues/2561/events
|
https://github.com/psf/requests/issues/2561
| 70,304,433 |
MDU6SXNzdWU3MDMwNDQzMw==
| 2,561 |
Content-Encoding: Gzip not automatically decoded in 2.6.1
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1538550?v=4",
"events_url": "https://api.github.com/users/elsimir/events{/privacy}",
"followers_url": "https://api.github.com/users/elsimir/followers",
"following_url": "https://api.github.com/users/elsimir/following{/other_user}",
"gists_url": "https://api.github.com/users/elsimir/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/elsimir",
"id": 1538550,
"login": "elsimir",
"node_id": "MDQ6VXNlcjE1Mzg1NTA=",
"organizations_url": "https://api.github.com/users/elsimir/orgs",
"received_events_url": "https://api.github.com/users/elsimir/received_events",
"repos_url": "https://api.github.com/users/elsimir/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/elsimir/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/elsimir/subscriptions",
"type": "User",
"url": "https://api.github.com/users/elsimir",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 7 |
2015-04-23T04:28:58Z
|
2021-09-08T23:04:58Z
|
2015-04-23T16:29:38Z
|
NONE
|
resolved
|
When using requests on python 2.7.8 ubuntu 14.10 from pypi, the current version 2.6.1 exhibits different behaviour from 2.6.0. Response.content is a gzipped binary string, instead of a decoded unicode string in 2.6.0. Is this change in behaviour intended? Running this script in both 2.6.0 and 2.6.1 shows the difference.
```
import requests
import gzip
import json
from StringIO import StringIO
resp = requests.get('https://liquidstate.atlassian.net/rest/api/2/serverInfo')
try:
print 'Reading as JSON'
print resp.json()
except Exception:
print 'Failed to load JSON, reading as Gzip'
print 'Reading as Gzip'
content = StringIO()
content.write(resp.content)
content.seek(0)
gz = gzip.GzipFile(fileobj=content)
print json.loads(gz.read())
```
Under version 2.6.0:
Reading as JSON
{u'versionNumbers': [6, 5, 0], u'serverTitle': u'JIRA', u'buildDate': u'2015-04-08T00:00:00.000+1000', u'scmInfo': u'0dc1796b325ae7e85b1dca228885a3417f39097a', u'baseUrl': u'https://liquidstate.atlassian.net', u'buildNumber': 65000, u'version': u'6.5-OD-01-120'}
And under version 2.6.1:
Reading as JSON
Failed to load JSON, reading as Gzip
Reading as Gzip
{u'versionNumbers': [6, 5, 0], u'serverTitle': u'JIRA', u'buildDate': u'2015-04-08T00:00:00.000+1000', u'scmInfo': u'0dc1796b325ae7e85b1dca228885a3417f39097a', u'baseUrl': u'https://liquidstate.atlassian.net', u'buildNumber': 65000, u'version': u'6.5-OD-01-120'}
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2561/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2561/timeline
| null |
completed
| null | null | false |
[
"Thanks for this!\n\nThis is actually a regression in urllib3, so I've raised an issue there (shazow/urllib3#593). We'll fix it up and release a fix shortly. =)\n",
"This is likely to be an issue for many people. Thanks for fixing!\n",
"Was broken for us as well this morning (used by our product's CI tests), workaround was to revert to 2.6.0. Thanks for prompt fixing!\n",
":+1: GitHub really needs a silent +1 button, so people can acknowledge that we've seen a bug, without polluting the comment space. \n",
"@JonathonReinhart no joke. Feel free to [Contact](https://github.com/contact) them though and tell them that. I know I have in the past and the more people who ask for it, the better our chances of getting it (I would hope).\n",
"I just released 2.6.2 to PyPI with the fix for this issue. Please upgrade as appropriate.\n",
"Thanks for the quick fix!\n"
] |
https://api.github.com/repos/psf/requests/issues/2560
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2560/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2560/comments
|
https://api.github.com/repos/psf/requests/issues/2560/events
|
https://github.com/psf/requests/issues/2560
| 70,248,207 |
MDU6SXNzdWU3MDI0ODIwNw==
| 2,560 |
Add contribution guidelines
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 9 |
2015-04-22T22:10:45Z
|
2021-09-08T23:04:56Z
|
2015-04-29T13:04:27Z
|
CONTRIBUTOR
|
resolved
|
https://github.com/benoitc/gunicorn/blob/master/CONTRIBUTING.md
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2560/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2560/timeline
| null |
completed
| null | null | false |
[
"Presumably this document will be pretty similar to the content of [these](http://docs.python-requests.org/en/latest/dev/philosophy/) [two](http://docs.python-requests.org/en/latest/dev/todo/) pages.\n",
"Thoughts on adding something akin to [this](https://github.com/sigmavirus24/requests-toolbelt/blob/master/CODE_OF_CONDUCT.rst) as well?\n",
"Also the bit in the [Standard Library](http://docs.python-requests.org/en/latest/dev/philosophy/#standard-library) section about having just reached v1.0.0 is a bit ... dated.\n",
"Oh also our [Runtime Environments](http://docs.python-requests.org/en/latest/dev/todo/#runtime-environments) list is very wrong. PyPy 1.9 is very old and dated. We don't actually test against it either and I don't think we support 3.1 or 3.2 either. =(\n",
"simpler than pledging, i think\n\n\"be cordial, or be on your way\", \"adhere to our philosophy\", etc.\n",
"@kennethreitz In that case, what do you think of [this doc](https://hyper.readthedocs.org/en/latest/contributing.html).\n",
"@Lukasa wonderful!\n",
"Alright, basic proposal is in #2572.\n",
"With #2572 merged, I'm closing this. :cake: \n"
] |
https://api.github.com/repos/psf/requests/issues/2559
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2559/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2559/comments
|
https://api.github.com/repos/psf/requests/issues/2559/events
|
https://github.com/psf/requests/issues/2559
| 70,222,691 |
MDU6SXNzdWU3MDIyMjY5MQ==
| 2,559 |
Make an official logo and stickers for it
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 14 |
2015-04-22T20:07:01Z
|
2021-09-08T18:00:53Z
|
2016-04-16T04:14:01Z
|
CONTRIBUTOR
|
resolved
|
Proposed logo:
:sparkles: :cake: :sparkles:
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2559/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2559/timeline
| null |
completed
| null | null | false |
[
"If we could get a designer to render it in a way that wasn't just emoji, this'd be perfect.\n",
"/cc @kennethreitz \n",
"This would be the second emoji logo stick I have!\n\n:muscle: :computer: :us: \n",
"YES!\n",
"`>>> import requests`\n:sparkles: :cake: :sparkles:\n",
"the github3.py stickers are some of my favorites. \n",
"Yeah the Digital Services stickers are the reason why I thought of :sparkles: :cake: :sparkles: stickers as a real good idea. I still know the designer who did the github3.py stickers. I can see if she's available for hire to do this. I'll happily handle paying for the logo.\n",
"When are you looking for this to be done?\n",
"`¯\\_(ツ)_/¯`\n",
"@missingdink whenevs :)\n",
":+1: :hankey: :muscle: \n",
"@missingdink :cake: \n",
"Does James Halliday take commissions? I adore his readmes http://substack.net/art\n",
"@missingdink actually came through @hickford. We just need to revamp our stuff with the new logo.\n"
] |
https://api.github.com/repos/psf/requests/issues/2558
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2558/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2558/comments
|
https://api.github.com/repos/psf/requests/issues/2558/events
|
https://github.com/psf/requests/issues/2558
| 70,200,961 |
MDU6SXNzdWU3MDIwMDk2MQ==
| 2,558 |
Import issues in 2.5.2+
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/23610?v=4",
"events_url": "https://api.github.com/users/dcramer/events{/privacy}",
"followers_url": "https://api.github.com/users/dcramer/followers",
"following_url": "https://api.github.com/users/dcramer/following{/other_user}",
"gists_url": "https://api.github.com/users/dcramer/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dcramer",
"id": 23610,
"login": "dcramer",
"node_id": "MDQ6VXNlcjIzNjEw",
"organizations_url": "https://api.github.com/users/dcramer/orgs",
"received_events_url": "https://api.github.com/users/dcramer/received_events",
"repos_url": "https://api.github.com/users/dcramer/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dcramer/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dcramer/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dcramer",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 9 |
2015-04-22T18:27:52Z
|
2021-09-08T23:05:00Z
|
2015-04-22T21:27:35Z
|
NONE
|
resolved
|
While I'm not entirely certain of the problem, this reproduces in our environment with an obscure (unrelated to requests) import error.
I've confirmed this was introduced in 2.5.2 and exists in 2.6.0, as well as 1f0e5775f28d6c2db3430fdc16a095762816bf87
If I had to guess, I'd say its related to this:
- Copy pip's import machinery. When downstream redistributors remove requests.packages.urllib3 the import machinery will continue to let those same symbols work. Example usage in requests' documentation and 3rd-party libraries relying on the vendored copies of urllib3 will work without having to fallback to the system urllib3.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2558/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2558/timeline
| null |
completed
| null | null | false |
[
"If i end up with some spare time I will try to dig into this more. Unfortunately the codebase that this reproduces on is not public. That said, here's the error (though all I can say is it happens somewhere in the import cycle after some initial things load):\n\n```\n./bin/sentry upgrade --noinput\n/Users/dcramer/Development/getsentry/getsentry/conf/settings/defaults.py:408: UserWarning: Unable to fetch package version: [Errno 2] No such file or directory: path(u'/Users/dcramer/Development/getsentry/VERSION')\n warnings.warn(u'Unable to fetch package version: %s' % unicode(e))\nUsing configuration 'getsentry.conf.settings.dev'\nTraceback (most recent call last):\n File \"/Users/dcramer/.virtualenvs/getsentry/bin/sentry\", line 9, in <module>\n load_entry_point('sentry==7.5.0.dev0', 'console_scripts', 'sentry')()\n File \"/Users/dcramer/.virtualenvs/getsentry/src/sentry/src/sentry/utils/runner.py\", line 410, in main\n initializer=initialize_app,\n File \"/Users/dcramer/.virtualenvs/getsentry/lib/python2.7/site-packages/logan/runner.py\", line 169, in run_app\n management.execute_from_command_line([runner_name, command] + command_args)\n File \"/Users/dcramer/.virtualenvs/getsentry/lib/python2.7/site-packages/django/core/management/__init__.py\", line 399, in execute_from_command_line\n utility.execute()\n File \"/Users/dcramer/.virtualenvs/getsentry/lib/python2.7/site-packages/django/core/management/__init__.py\", line 392, in execute\n self.fetch_command(subcommand).run_from_argv(self.argv)\n File \"/Users/dcramer/.virtualenvs/getsentry/lib/python2.7/site-packages/django/core/management/__init__.py\", line 261, in fetch_command\n commands = get_commands()\n File \"/Users/dcramer/.virtualenvs/getsentry/lib/python2.7/site-packages/django/core/management/__init__.py\", line 107, in get_commands\n apps = settings.INSTALLED_APPS\n File \"/Users/dcramer/.virtualenvs/getsentry/lib/python2.7/site-packages/django/conf/__init__.py\", line 54, in __getattr__\n self._setup(name)\n File \"/Users/dcramer/.virtualenvs/getsentry/lib/python2.7/site-packages/django/conf/__init__.py\", line 49, in _setup\n self._wrapped = Settings(settings_module)\n File \"/Users/dcramer/.virtualenvs/getsentry/lib/python2.7/site-packages/django/conf/__init__.py\", line 132, in __init__\n % (self.SETTINGS_MODULE, e)\nImportError: Could not import settings 'sentry_config' (Is it on sys.path? Is there an import error in the settings file?): No module named sentry_config\n```\n\nIn this case 'sentry_config' is a virtual module managed by https://github.com/dcramer/logan via an import hook.\n",
"@dcramer This is interesting timing, as we're about to release 2.6.1. We believe 2.6.1 contains some fixes in this area. Do you mind trying the current master to see if that solves your problems?\n",
"@Lukasa I did try the referenced sha (which was master an hour or so ago) and it still exhibited the same issue. It's possible this is an issue in Logan, but the code there isn't very hacky (and I'm mostly certain its correct).\n",
"@dcramer The easiest way to verify that this is the source of the problem is to replace `requests/packages/__init__.py` with an empty file and see if the problem still appears. (I'm assuming you've already verified that the problem doesn't appear with some earlier version of Python.)\n",
"Confirmed it's the import hook present in requests.packages (via the above).\n",
"Does Logan play well with other tools that register meta_path hooks? Have you tested it with any of them?\n",
"Also what version of Logan are you using to get that traceback? The line numbers are wrong compared to master on Logan. Is it possible this is fixed in Logan already?\n",
"We're using the previous major version, but I tested (and actually tried to debug/throw random fixes in) on the latest logan.\n\nSeemingly both packages are doing similar things, barring that requests tries to replace meta_path at one point.\n\nIdeally Python would document some of this so people wouldn't have to guess so much as to the \"right way\" to do these things.\n",
"> Seemingly both packages are doing similar things, barring that requests tries to replace meta_path at one point.\n\n@dstufft can speak best to why we replace it, but I believe we only filter out instances of our own hook to prevent infinite recursion when first attempting to import the name given to us.\n\nThat shouldn't be a big problem here though because the import error looks like it's probably coming directly out of Django.\n\nEither way this will be fixed by 3e3fc76 in 2.6.1\n"
] |
https://api.github.com/repos/psf/requests/issues/2557
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2557/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2557/comments
|
https://api.github.com/repos/psf/requests/issues/2557/events
|
https://github.com/psf/requests/issues/2557
| 70,194,424 |
MDU6SXNzdWU3MDE5NDQyNA==
| 2,557 |
Make chardet an optional dependency
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/23610?v=4",
"events_url": "https://api.github.com/users/dcramer/events{/privacy}",
"followers_url": "https://api.github.com/users/dcramer/followers",
"following_url": "https://api.github.com/users/dcramer/following{/other_user}",
"gists_url": "https://api.github.com/users/dcramer/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dcramer",
"id": 23610,
"login": "dcramer",
"node_id": "MDQ6VXNlcjIzNjEw",
"organizations_url": "https://api.github.com/users/dcramer/orgs",
"received_events_url": "https://api.github.com/users/dcramer/received_events",
"repos_url": "https://api.github.com/users/dcramer/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dcramer/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dcramer/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dcramer",
"user_view_type": "public"
}
|
[
{
"color": "eb6420",
"default": false,
"description": null,
"id": 44501256,
"name": "Breaking API Change",
"node_id": "MDU6TGFiZWw0NDUwMTI1Ng==",
"url": "https://api.github.com/repos/psf/requests/labels/Breaking%20API%20Change"
},
{
"color": "f7c6c7",
"default": false,
"description": null,
"id": 167537670,
"name": "Propose Close",
"node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=",
"url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close"
}
] |
closed
| true | null |
[] | null | 7 |
2015-04-22T17:59:41Z
|
2021-09-08T21:00:48Z
|
2015-11-05T18:03:33Z
|
NONE
|
resolved
|
It has a serious performance hit and it'd be nice if it was easier to disable than:
```
if not response.encoding:
response.encoding = 'utf-8'
```
I can't stress "serious" enough in the performance hit here. It was enough to cripple the entirety of Sentry's worker cluster which is way under utilization most of the time.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2557/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2557/timeline
| null |
completed
| null | null | false |
[
"The easiest way to disable it would be to disable the package entirely in your infrastructure. This could be done by monkeying about with `sys.modules`, monkeypatching directly, or by providing another package called chardet that is just a no-op.\n\nThe best we're likely to get to an 'official' API for this is to adjust the `Response` factory in the `HTTPAdapter` to allow the user to specify a `Response` subclass. We're not going to want to have chardet need to be explicitly enabled, because that feature is optimised for the unaware user, not the aware one.\n\nI take it you _do_ want to take advantage of our parsing of the headers to determine a text encoding, which is why you aren't unconditional here.\n\nI think what I'm interested in knowing is whether you have a proposal API for allowing chardet to stay enabled in the default use case, but give you a nice hook to disable it.\n",
"Definitely having a simply way to override the Response would be helpful. I dont know about others, but as our use cases are generally more optimized and less care-free, we're generally willing to go a little bit farther in implementation.\n\nFeel free to close this if it makes sense.\n\nThat said, it might still be worth noting the performance implications of chardet:\n\nhttps://www.dropbox.com/s/mwb4z795a50ugfz/Screenshot%202015-04-22%2012.51.20.png?dl=0\n",
"So we should be clear about what requests' priorities are. Speed is great, but we will always put in more helpful features at the cost of speed. Always.\n\nI am totally up for having a way to disabling chardet, but the API really does need to be clean. Otherwise, I feel like the patch above is really the nicest way to do it. Two lines isn't so costly!\n",
"No one should ever be patching sys.modules like you're suggesting. That's the reason most Ruby code is so unmaintainable. It also would completely prevent using chardet in any other library that may actually 100% require it. It'd be much safer to monkey patch Requests, which is also something you wouldn't want people doing.\n\nAnyways, if this were something like \"its 20% slower with chardet\" I wouldn't care. This is more like \"its 1000%+ slower with chardet\" and that has some pretty legitimate consequences for the unaware.\n",
"To be clear, I didn't mean the monkeypatch, I meant these two lines:\n\n``` python\nif not response.encoding:\n response.encoding = 'utf-8'\n```\n\nThere's another way to avoid this cost: don't use `Response.text`.\n\nI don't deny that the use of chardet can, in some cases, be much slower than not using chardet. If it was hard to disable chardet I'd be more worried. However, it's not a difficult feature to disable, and you've clearly discovered how to do exactly that.\n\nLike I said: if there's an obvious easier API I'm open to having it enabled. I'd also be open to extending the API documentation around `Response.text` to include an admonition that `chardet` can be very slow. However, I continue to believe that there's more value in leaving chardet in place than there would be removing it by default.\n",
"So if you're using a session, then you can use that two line fix with a session hook that will get registered for each response, e.g., \n\n``` py\ndef force_utf8(response, *args, **kwargs):\n if not response.encoding:\n response.encoding = 'utf-8'\n\ns = requests.Session()\ns.hooks['response'].append(force_utf8)\n```\n",
"Also, chardet is working on fixing these issues. If you'd like to see them fixed faster you too can help @dcramer \n"
] |
https://api.github.com/repos/psf/requests/issues/2556
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2556/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2556/comments
|
https://api.github.com/repos/psf/requests/issues/2556/events
|
https://github.com/psf/requests/pull/2556
| 70,123,697 |
MDExOlB1bGxSZXF1ZXN0MzM4NTcwMzU=
| 2,556 |
Prepare v2.6.1
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
[] |
closed
| true |
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
] | null | 22 |
2015-04-22T13:19:47Z
|
2021-09-08T07:01:00Z
|
2015-04-22T22:12:26Z
|
CONTRIBUTOR
|
resolved
|
I'll probably update the history and such in this branch too.
/cc @aanand
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2556/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2556/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2556.diff",
"html_url": "https://github.com/psf/requests/pull/2556",
"merged_at": "2015-04-22T22:12:26Z",
"patch_url": "https://github.com/psf/requests/pull/2556.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2556"
}
| true |
[
"LGTM, but it updates urllib3, so we need to co-ordinate with @shazow to make sure he's comfortable with pushing a new release of urllib3 as well.\n\nThoughts @shazow?\n",
"Courtesy nod to @shazow that we'd like to release soon so you might get bugged by downstream redistributors\n",
"Also, a head's up to @eriol and @ralphbean that we're planning a release in the event they would like to prepare for that.\n",
"I _just_ published the latest master as 1.10.3. Is this something different?\n",
"So I pulled in https://github.com/shazow/urllib3/commit/10b7a0fefa6596f47a9a6afc80f1f4d1ae950b66 and https://github.com/shazow/urllib3/commit/0b744993bbe30fe6e3e4e0c93416412d8e598301 is the commit tagged for 1.10.3 which is _not_ in master but on a branch called \"release\". If those two are merged, I'll make another pull and everything should be fine since the only differing change is 10b7a0fefa which is a modification to the Makefile which we do not include.\n",
"Yup, release is a different branch than master, their hashes will never converge (as master has dev-specific stuff, like `__version__ = 'dev'` and release does not). See https://github.com/shazow/urllib3/blob/master/release.sh for details.\n",
"Ah okay. I think we need to update our release process then to pull from the release branch unless we specifically need to pull from master. @Lukasa I think you have write access to my fork, would you mind updating our vendored copy of requests to use urllib3 from the \"release\" branch? If not, I'll do it over lunch or after work today.\n",
"Keep in mind that the release branch is only updated when a release happens. If you want to pull things ahead of a urllib3 release, you'll need to get it from master as usual.\n",
":cake: \n",
":eggplant: \n",
"Sadly, I'm not a collab on your repo @sigmavirus24. =( I opened a pull request instead: sigmavirus24/requests#3.\n",
"This is really an overcomplicated thing to do, but ah well.\n",
"@ralphbean @eriol after a discussion today, we've decided that the VendorAlias work we had in requests was causing too many problems. If you'd like to include it as a patch for Fedora/Debian we're :+1: on that, but we won't be shipping it. If you find problems with it in the future, I'll be happy to hack on it with y'all to make sure it's robust, thread-safe, etc. and will continue to work for you and for our (people using requests on Fedora/Debian) users.\n",
"I also want to find a sustainable long-term solution to this problem. I want to grab some of @dstufft's time (or anyone who really understands python's import machinery) to work out how we can do this long term.\n",
"Alright @sigmavirus24, this all LGTM except that the changelog probably needs an update to say that we aren't fixing the machinery, we're just removing it wholesale.\n",
"> Alright @sigmavirus24, this all LGTM except that the changelog probably needs an update to say that we aren't fixing the machinery, we're just removing it wholesale.\n\n:heavy_check_mark: \n",
"Make it happen, @sigmavirus24. :shipit: \n",
"Many thanks for the update, I will include it as a patch, and I will be very happy to help on making it robust, thread-safe... I will also put a note on README.Debian explaining why in Debian VendorAlias patch is used, but I don't know how many users look at /usr/share/doc: I will try to monitor all issues here but please ping me on a issue related to Debian. @sigmavirus24 many thanks for your offer, it's highly appreciated! :smile:\n\nI will update requests for Debian during the weekend. Hopefully Debian Jessie will be released on saturday, so I will be able to backport 2.6.1 for Jessie as soon as it will migrate to Debian Testing.\n",
"I'll tag v2.6.1 and push it to PyPI.\n",
"And 2.6.1 is released\n",
"Thanks very much folks :heart: :cake: \n",
"At the end, I decided to not cherry pick this for Debian since Debian and Ubuntu users will suffer due the problems emerged.\n"
] |
https://api.github.com/repos/psf/requests/issues/2555
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2555/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2555/comments
|
https://api.github.com/repos/psf/requests/issues/2555/events
|
https://github.com/psf/requests/issues/2555
| 69,912,824 |
MDU6SXNzdWU2OTkxMjgyNA==
| 2,555 |
requests does not respect the timeout set by socket.setdefaultimeout
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/221386?v=4",
"events_url": "https://api.github.com/users/ikatson/events{/privacy}",
"followers_url": "https://api.github.com/users/ikatson/followers",
"following_url": "https://api.github.com/users/ikatson/following{/other_user}",
"gists_url": "https://api.github.com/users/ikatson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ikatson",
"id": 221386,
"login": "ikatson",
"node_id": "MDQ6VXNlcjIyMTM4Ng==",
"organizations_url": "https://api.github.com/users/ikatson/orgs",
"received_events_url": "https://api.github.com/users/ikatson/received_events",
"repos_url": "https://api.github.com/users/ikatson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ikatson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ikatson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ikatson",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-04-21T18:02:43Z
|
2021-09-08T23:05:01Z
|
2015-04-21T18:43:36Z
|
NONE
|
resolved
|
Steps to reproduce:
``` py
import socket
import requests
socket.setdefaultimeout(0.0001)
# Expected this to raise exception, but it does not.
requests.get('http://google.com')
# These 2 raise an exception
requests.get('http://google.com', timeout=socket.gettimeout())
requests.get('http://google.com', timeout=socket._GLOBAL_DEFAULT_TIMEOUT)
```
Looks like the default "None" value is propagated to urllib3, which has `socket._GLOBAL_DEFAULT_TIMEOUT` set as the default timeout.
Is this by-design or a bug?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2555/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2555/timeline
| null |
completed
| null | null | false |
[
"Duplicate of #2228. Please check open issues in the future for possible duplicates.\n"
] |
https://api.github.com/repos/psf/requests/issues/2554
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2554/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2554/comments
|
https://api.github.com/repos/psf/requests/issues/2554/events
|
https://github.com/psf/requests/issues/2554
| 69,869,660 |
MDU6SXNzdWU2OTg2OTY2MA==
| 2,554 |
Ability to prefix session URLs
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/651797?v=4",
"events_url": "https://api.github.com/users/foxx/events{/privacy}",
"followers_url": "https://api.github.com/users/foxx/followers",
"following_url": "https://api.github.com/users/foxx/following{/other_user}",
"gists_url": "https://api.github.com/users/foxx/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/foxx",
"id": 651797,
"login": "foxx",
"node_id": "MDQ6VXNlcjY1MTc5Nw==",
"organizations_url": "https://api.github.com/users/foxx/orgs",
"received_events_url": "https://api.github.com/users/foxx/received_events",
"repos_url": "https://api.github.com/users/foxx/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/foxx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/foxx/subscriptions",
"type": "User",
"url": "https://api.github.com/users/foxx",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 16 |
2015-04-21T14:57:39Z
|
2021-08-31T00:06:41Z
|
2015-04-21T15:23:33Z
|
NONE
|
resolved
|
It would be nice to be able to prefix session URLs to avoid repetitive code.
Consider the following code;
```
from requests import Session
class MyTestCase(LiveServerTestCase):
def test_url(self):
s = Session()
s.get("{}/api/people'.format(self.server_url))
s.get("{}/api/cats'.format(self.server_url))
```
This could look a lot prettier by doing;
```
from requests import Session
class MyTestCase(LiveServerTestCase):
def test_url(self):
s = Session(prefix_url='http://example.com')
s.get('/api/people')
s.get('/api/cats')
```
In the mean time, I was able to achieve this by using a subclass;
```
class Session(requests.Session):
"""Helpers for performing API queries"""
def __init__(self, *args, **kwargs):
self.prefix_url = kwargs.get('prefix_url', None)
super(Session, self).__init__(*args, **kwargs)
def request(self, method, url, *args, **kwargs):
if self.prefix_url:
url = "{}{}".format(self.prefix_url, url)
return super(Session, self).request(method, url, *args, **kwargs)
```
@kennethreitz would such a PR be accepted? Or does anyone know of a better way this could be done?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2554/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2554/timeline
| null |
completed
| null | null | false |
[
"As we've described in previous issues (https://github.com/kennethreitz/requests/issues/2445, https://github.com/kennethreitz/requests/issues/133) this is not something we feel belongs in requests itself. There are several libraries that do this in differing ways.\n\nThe easiest way to implement this yourself would be to use the `urljoin` function provided by `urllib`/`urlparse`/etc. (depending on your version of Python).\n",
"I agree that `prefix_url` is not the most flexible solution, and hooks/subclasses would be better suited, as suggested by @kennethreitz in #133.\n\nHowever it's not immediately clear from the docs how to do this, therefore I'd like to propose some sort of docs patch to make this clearer. Would such a patch be accepted?\n",
"#133 is extremely old in this case (but represents the decision to not include this). Most of the hooks that existed when Kenneth responded to #133 no longer exist. Currently the only supported hook is the `response` hook which happens after a `requests.Response` object has been constructed but before it's given to the user. This, is very late in the process though.\n",
"Again, I'd argue this is a common use case which genuinely improves code quality, and is at least worthy of a docs patch. However if @kennethreitz votes down on this, then so be it.\n",
"> and is at least worthy of a docs patch\n\nI'm not sure I understand what needs to be added to the docs. Would you mind expounding on that?\n",
"Apologies for the slow response on this. After trying several different approaches, it seems the most flexible and cleanest approach is subclassing.\n\nHere's an example that meets our particular needs of prepending a URL;\n\n``` py\nfrom requests import Session\nfrom urlparse import urljoin\n\nclass LiveServerSession(Session):\n def __init__(self, prefix_url):\n self.prefix_url = prefix_url\n super(LiveServerSession, self).__init__()\n\n def request(self, method, url, *args, **kwargs):\n url = urljoin(self.prefix_url, url)\n return super(LiveServerSession, self).request(method, url, *args, **kwargs)\n```\n\nAs for documentation, I'm thinking perhaps a \"recipes\" page of patterns and user contributed subclasses for achieving common goals, which aren't appropriate for inclusion into the core.\n\nThoughts @kennethreitz / @sigmavirus24 ?\n",
"So we have some recipes sprinkled through the documentation, but for the most part we haven't created one single recipes section. And the recipes that are in the docs are either minimal enough to just work or aren't used by anyone and so we haven't received any bug reports about them. The few really important ones have been abstracted into the [requests-toolbelt](/sigmavirus24/requests-toolbelt) which adds things as necessary.\n\nYou can open a PR there with tests to start a discussion about including this. There are a few things we'll probably want to change because I can already foresee some bug reports coming in if we did ship it in the toolbelt.\n",
"Ah, I didn't know about requests-toolbelt, I'll take a look and see about submitting a PR.\n",
"@foxx Did you ever end up submitting a PR with this implementation? I wanted this feature today.\n",
"@jaraco double checking the toolbelt, no it does not seem as if @foxx ever did.\n",
"It would be nice with a canonical implementation of this that doesn't require either losing or replicating all type hints of the `Session.request` method. In that respect the toolbelt solution really isn't satisfactory.",
"Given the typeshed type hints are pretty terrifically insufficient in the first place, I don't think that's a priority for the toolbelt. Python's type hints are awfully insufficient for a library like Requests and there's enough documented on that topic.",
"@sigmavirus24 Sorry, but that just comes off as \"because things aren't perfect they shouldn't be improved\". I've gained a lot of value out of using the typeshed stubs for requests and I doubt I'm the only one.",
"I'm not saying they're not valuable, but they're wrong. They may provide value while being insufficient, incorrect, and misleading without being the right thing. It's also plausible that type hints can be valuable most of the time, but are insufficient for any kind of complexity - just like Go's type system isn't sufficient for higher order types. Regardless, if you want type hints for the toolbelt, you can add them. As it stands your comments aren't productive and as the person who started the toolbelt I won't copy junk around and do that work when it's of misleading quality nor am I about to try to provide accurate type hints. Whining to 1,400 people won't make your desires realized and this library is maintained for security purposes so you either need to take your own action or stop spamming folks",
"@sigmavirus24 I haven't asked anyone to do any work, if work is required to implement something here I might be able to put time in, I do make small contributions infrequently to some of the libraries I use.\r\n\r\nI lifted this here because it seemed to me like the issue was closed because the toolbelt solution was deemed good enough. 5 years later and the Python landscape looks quite different today with static typing gaining a lot of support and becoming more of an important aspect for many. From that perspective I simply stated that the status quo isn't satisfactory.\r\n\r\nIn case I stepped on your toes, I'm sorry, perhaps I could have expressed myself differently.",
"@antonagestam I appreciate that. In short, 99% of people who make comments like yours are doing so to re-open an issue and get someone else to do whatever they want. It's given me a rather jaded perspective on comments like yours. The toolbelt probably meets the 99% use-case of people and this library has been in feature freeze for at leas 5 years (roughly since 2.0 was released). So the toolbelt is the best possible way forward for this for better or for worse."
] |
https://api.github.com/repos/psf/requests/issues/2553
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2553/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2553/comments
|
https://api.github.com/repos/psf/requests/issues/2553/events
|
https://github.com/psf/requests/pull/2553
| 69,715,867 |
MDExOlB1bGxSZXF1ZXN0MzM3MjEzMTc=
| 2,553 |
Simplify PreparedRequest.prepare API
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2015-04-21T01:14:53Z
|
2021-09-08T08:00:49Z
|
2015-04-21T05:59:55Z
|
CONTRIBUTOR
|
resolved
|
Do not require that hooks be passed as an empty list to
PreparedRequest.prepare. In the event hooks is None in prepare or
prepare_hooks, use an empty list as a default.
Related to #2552
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2553/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2553/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2553.diff",
"html_url": "https://github.com/psf/requests/pull/2553",
"merged_at": "2015-04-21T05:59:55Z",
"patch_url": "https://github.com/psf/requests/pull/2553.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2553"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/2552
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2552/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2552/comments
|
https://api.github.com/repos/psf/requests/issues/2552/events
|
https://github.com/psf/requests/issues/2552
| 69,663,441 |
MDU6SXNzdWU2OTY2MzQ0MQ==
| 2,552 |
Why does the PreparedRequest.prepare method provide None as the default parameter value for those who cannot be None?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/4114154?v=4",
"events_url": "https://api.github.com/users/zhaoguixu/events{/privacy}",
"followers_url": "https://api.github.com/users/zhaoguixu/followers",
"following_url": "https://api.github.com/users/zhaoguixu/following{/other_user}",
"gists_url": "https://api.github.com/users/zhaoguixu/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zhaoguixu",
"id": 4114154,
"login": "zhaoguixu",
"node_id": "MDQ6VXNlcjQxMTQxNTQ=",
"organizations_url": "https://api.github.com/users/zhaoguixu/orgs",
"received_events_url": "https://api.github.com/users/zhaoguixu/received_events",
"repos_url": "https://api.github.com/users/zhaoguixu/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zhaoguixu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zhaoguixu/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zhaoguixu",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-04-20T19:33:14Z
|
2021-09-08T23:04:53Z
|
2015-05-03T15:03:37Z
|
NONE
|
resolved
|
Hi,
I just inspect some test cases of your project, and find some test cases like
``` python
def test_prepare_unicode_url():
p = PreparedRequest()
p.prepare(
method='GET',
url=u('http://www.example.com/üniçø∂é'),
hooks=[]
)
assert_copy(p, p.copy())
```
When I remove some parameters for calling the prepare method, it will raise exceptions(with url being missed) or traceback(with hooks being missed).
Is it unreasonable to provide None default parameter for some arguments cannot be None?
(A related PR is #2301).
Thanks.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2552/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2552/timeline
| null |
completed
| null | null | false |
[
"I see no good reason to leave those as `None`-able defaults. I think we could get away with patching this in a minor release, because while it's _technically_ backward-incompatible, in practice I don't think anyone can be correctly relying on this behaviour. @sigmavirus24?\n",
"Personally, I like the idea of more or less _suggesting_ that users specify the arguments by keyword. If anything we should be documenting the fact that some of these parameters need to be provided. That said, I don't like that we have to pass hooks as an empty list so I'm sending a patch with a fix for that.\n"
] |
https://api.github.com/repos/psf/requests/issues/2551
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2551/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2551/comments
|
https://api.github.com/repos/psf/requests/issues/2551/events
|
https://github.com/psf/requests/pull/2551
| 68,199,299 |
MDExOlB1bGxSZXF1ZXN0MzMyMDU2NTg=
| 2,551 |
EditorConfig
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/285352?v=4",
"events_url": "https://api.github.com/users/treyhunner/events{/privacy}",
"followers_url": "https://api.github.com/users/treyhunner/followers",
"following_url": "https://api.github.com/users/treyhunner/following{/other_user}",
"gists_url": "https://api.github.com/users/treyhunner/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/treyhunner",
"id": 285352,
"login": "treyhunner",
"node_id": "MDQ6VXNlcjI4NTM1Mg==",
"organizations_url": "https://api.github.com/users/treyhunner/orgs",
"received_events_url": "https://api.github.com/users/treyhunner/received_events",
"repos_url": "https://api.github.com/users/treyhunner/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/treyhunner/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/treyhunner/subscriptions",
"type": "User",
"url": "https://api.github.com/users/treyhunner",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-04-13T21:30:47Z
|
2021-09-08T08:00:50Z
|
2015-04-13T21:45:23Z
|
MEMBER
|
resolved
|
Previously proposed and declined in #893.
I am opening this because I think it is time to reassess whether EditorConfig is appropriate for this project.
I did some GitHub diving and found the following Python projects which use EditorConfig:
- [flask-wtf](https://github.com/lepture/flask-wtf)
- [cookiecutter-django](https://github.com/pydanny/cookiecutter-django)
I also found the following Python-powered websites that use EditorConfig:
- [MDN](https://github.com/mozilla/kuma)
- [gratipay](https://github.com/gratipay/gratipay.com)
- [mozilla.org](https://github.com/mozilla/bedrock)
This file is a human-readable auto-enforced whitespace style guide for all files (_not just Python_).
For:
- **users of editors with built-in support** (e.g. PyCharm, Coda 2, SourceLair) this file will ensure the code style is enforced automatically.
- **users with a plugin installed** (available for most major editors) this file will also auto-enforce the code style
- **all other users** this simply serves as a white space style guide.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2551/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2551/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2551.diff",
"html_url": "https://github.com/psf/requests/pull/2551",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2551.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2551"
}
| true |
[
"Thanks for this!\n\nI do not believe that EditorConfig is appropriate at this time. In general, I resent the relentless expansion of dotfiles that various tools require people to add to the project root. I appreciate that these tools are close to many people's hearts, and that they provide value for plenty of people, but it's extremely difficult to justify any tool that is not actually considered 'enforced' by some form of automated tooling. The risk is that if we accept this it becomes difficult to reject it for other tools, and we rapidly end up with an expansion of dotfiles that have no love.\n\nFor this reason, I'm afraid I don't think I can accept this. =( Sorry!\n"
] |
https://api.github.com/repos/psf/requests/issues/2550
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2550/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2550/comments
|
https://api.github.com/repos/psf/requests/issues/2550/events
|
https://github.com/psf/requests/pull/2550
| 68,129,304 |
MDExOlB1bGxSZXF1ZXN0MzMxNzUzOTU=
| 2,550 |
Recommended packages.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 5 |
2015-04-13T15:40:17Z
|
2021-09-08T08:00:49Z
|
2015-04-17T12:44:38Z
|
MEMBER
|
resolved
|
Beginnings of work to have a list of recommended third-party (fourth-party?) packages.
@sigmavirus24 @kennethreitz feel free to push on top of this branch to add other things if you want.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2550/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2550/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2550.diff",
"html_url": "https://github.com/psf/requests/pull/2550",
"merged_at": "2015-04-17T12:44:38Z",
"patch_url": "https://github.com/psf/requests/pull/2550.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2550"
}
| true |
[
"@kennethreitz added the requests-toolbelt to the sidebar a while back. Would it be best to move it here?\n",
"Maybe have it here as well?\n",
"Let's replace the toolbar link to a link to this page. \n",
"`==kennethreitz`. I'll push an update for that tonight I think\n",
"@sigmavirus24 send another pr with that :)\n"
] |
https://api.github.com/repos/psf/requests/issues/2549
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2549/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2549/comments
|
https://api.github.com/repos/psf/requests/issues/2549/events
|
https://github.com/psf/requests/issues/2549
| 67,885,372 |
MDU6SXNzdWU2Nzg4NTM3Mg==
| 2,549 |
Cookies issue causing segfault still in 2.6?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/10351369?v=4",
"events_url": "https://api.github.com/users/11phc/events{/privacy}",
"followers_url": "https://api.github.com/users/11phc/followers",
"following_url": "https://api.github.com/users/11phc/following{/other_user}",
"gists_url": "https://api.github.com/users/11phc/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/11phc",
"id": 10351369,
"login": "11phc",
"node_id": "MDQ6VXNlcjEwMzUxMzY5",
"organizations_url": "https://api.github.com/users/11phc/orgs",
"received_events_url": "https://api.github.com/users/11phc/received_events",
"repos_url": "https://api.github.com/users/11phc/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/11phc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/11phc/subscriptions",
"type": "User",
"url": "https://api.github.com/users/11phc",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 5 |
2015-04-12T08:11:06Z
|
2021-09-08T23:05:42Z
|
2015-04-12T11:23:51Z
|
NONE
|
resolved
|
FYI I think there might still be a cookies related issue... I was having issues two weeks ago with cookies.py in 2.5.3 i think, but I have downloaded the new requests 2.6 running on raspberry pi for a datalogger every minute, and it's much better but now it segfaults every 24 hours or so in a slightly different place. (FYI I'm not very competent on python debugging yet)
Traceback show's it segfaulting on line 241 in python2.7/rfc822.py (it shows as line 243 in my screenshot but I had already added a couple of lines above for debugging - it is whatever line "for line in self.headers" is on in getAllMatchingHeaders), invoked ultimately from requests/cookies.py.
The process is just repeatedly loading a webserver.html page on a PLC we have on our intranet, to read it's variables, so it's not going over the internet.
When running, normally the 'lst' variable is always returned as [] so I dont even need this procedure and for now I've bypassed the "for line in self.headers" bit to keep it from segfaulting once a day.
If you want more info do please let me know what you need.
And of course, thanks for the great work.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2549/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2549/timeline
| null |
completed
| null | null | false |
[
"Or is this just a python2.7 bug?\n",
"@11phc it is just a python2.7 bug. I would check bugs.python.org to figure out which version number has the fix. If you can, I would update your version of python to 2.7.9 on your Pi.\n\nCheers,\nIan\n",
"ok thanks very much Ian. I was on version 2.7.3, but unfortunately going to Python 2.7.9 still doesn’t seem to fix it. I might have to go to Python 3.x I fear.\n\npiers\n\nOn 12 Apr 2015, at 12:21, Ian Cordasco [email protected] wrote:\n\n> @11phc it is just a python2.7 bug. I would check bugs.python.org to figure out which version number has the fix. If you can, I would update your version of python to 2.7.9 on your Pi.\n> \n> Cheers,\n> Ian\n> \n> —\n> Reply to this email directly or view it on GitHub.\n",
"Sorry…. I’ve got another segfault now in requests/api.py which I think probably is in requests, right? \n\npython 2.7.9\nrequests 2.6.0\n\nits a data logger program, so it just happens once every 24 hours or so, after doing a requests call every minute.\n\nanything useful I can do to isolate it?\nShall I open another issue in github?\n\nthanks\n\nOn 12 Apr 2015, at 12:21, Ian Cordasco [email protected] wrote:\n\n> @11phc it is just a python2.7 bug. I would check bugs.python.org to figure out which version number has the fix. If you can, I would update your version of python to 2.7.9 on your Pi.\n> \n> Cheers,\n> Ian\n> \n> —\n> Reply to this email directly or view it on GitHub.\n",
"Can you provide any extra information here first? A traceback? More details about how you're using requests? Anything that we could possibly use to help you.\n"
] |
https://api.github.com/repos/psf/requests/issues/2548
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2548/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2548/comments
|
https://api.github.com/repos/psf/requests/issues/2548/events
|
https://github.com/psf/requests/pull/2548
| 67,708,226 |
MDExOlB1bGxSZXF1ZXN0MzMwOTMyNTg=
| 2,548 |
Add a timeout to select(), otherwise we can block forever on a bad socket
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1581257?v=4",
"events_url": "https://api.github.com/users/natecode/events{/privacy}",
"followers_url": "https://api.github.com/users/natecode/followers",
"following_url": "https://api.github.com/users/natecode/following{/other_user}",
"gists_url": "https://api.github.com/users/natecode/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/natecode",
"id": 1581257,
"login": "natecode",
"node_id": "MDQ6VXNlcjE1ODEyNTc=",
"organizations_url": "https://api.github.com/users/natecode/orgs",
"received_events_url": "https://api.github.com/users/natecode/received_events",
"repos_url": "https://api.github.com/users/natecode/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/natecode/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/natecode/subscriptions",
"type": "User",
"url": "https://api.github.com/users/natecode",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 4 |
2015-04-11T00:08:31Z
|
2021-09-08T08:00:51Z
|
2015-04-11T00:12:53Z
|
NONE
|
resolved
|
All the other select.select() calls in this module use a timeout. Without this bugfix, a server that fails to complete the handshake will block forever. We've seen this in production.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2548/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2548/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2548.diff",
"html_url": "https://github.com/psf/requests/pull/2548",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2548.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2548"
}
| true |
[
"Can you open this pull request on urllib3? All your code changes are there.\n",
"Please re-open this issue. I just checked `urllib3` and it has this same fix in it so `requests` needs to update your code from urllib3.\n",
"It appears great minds think alike https://github.com/shazow/urllib3/commit/14d09fc8fd9df697e534e8e10cbe6f913289c748\n",
"Indeed. However, there's no need to re-open the issue, we'll bring a new urllib3 version before our next release. \n"
] |
https://api.github.com/repos/psf/requests/issues/2547
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2547/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2547/comments
|
https://api.github.com/repos/psf/requests/issues/2547/events
|
https://github.com/psf/requests/pull/2547
| 67,687,062 |
MDExOlB1bGxSZXF1ZXN0MzMwODUwNzM=
| 2,547 |
Fix MisssingSchema error message does not handle unicode input correctly #2540
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/11888277?v=4",
"events_url": "https://api.github.com/users/sh1buy/events{/privacy}",
"followers_url": "https://api.github.com/users/sh1buy/followers",
"following_url": "https://api.github.com/users/sh1buy/following{/other_user}",
"gists_url": "https://api.github.com/users/sh1buy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sh1buy",
"id": 11888277,
"login": "sh1buy",
"node_id": "MDQ6VXNlcjExODg4Mjc3",
"organizations_url": "https://api.github.com/users/sh1buy/orgs",
"received_events_url": "https://api.github.com/users/sh1buy/received_events",
"repos_url": "https://api.github.com/users/sh1buy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sh1buy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sh1buy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sh1buy",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 7 |
2015-04-10T21:27:24Z
|
2021-09-08T08:00:51Z
|
2015-04-11T02:59:13Z
|
CONTRIBUTOR
|
resolved
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2547/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2547/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2547.diff",
"html_url": "https://github.com/psf/requests/pull/2547",
"merged_at": "2015-04-11T02:59:13Z",
"patch_url": "https://github.com/psf/requests/pull/2547.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2547"
}
| true |
[
"I think this won't work on Python 3 with a binary URL, though I need to test that.\n",
"You rigth. This add 'b' to url. \n\n```\nrequests.exceptions.MissingSchema: Invalid URL b'example.com': \nNo schema supplied. Perhaps you meant http://b'example.com'?\n```\n",
"Whether it is necessary to display URL completely in error message?\nWill be enough only hostname?\nFor example, instead of the:\n\n```\nrequests.exceptions.MissingSchema: Invalid URL 'example.com/page?query=blabla&foo=23': \nNo schema supplied. Perhaps you meant 'http://example.com/page?query=blabla&foo=23'?\n```\n\nOutput this:\n\n```\nrequests.exceptions.MissingSchema: Invalid URL 'example.com/...': \nNo schema supplied. Perhaps you meant 'http://example.com/...'?\n```\n\nThen we can solve this bug with applying IDNA to the hostname.\n",
"The better thing to do might be to call `to_native_str`, from our utility package.\n",
"This work in both Python's versions.\n",
"Can you wrap the line at 79 characters?\n",
"Thanks @sh1buy! :sparkles: :cake: :sparkles:\n"
] |
|
https://api.github.com/repos/psf/requests/issues/2546
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2546/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2546/comments
|
https://api.github.com/repos/psf/requests/issues/2546/events
|
https://github.com/psf/requests/pull/2546
| 67,657,112 |
MDExOlB1bGxSZXF1ZXN0MzMwNzIzMzc=
| 2,546 |
Keepers of the Three Crystals.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[] |
closed
| true |
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
[
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
] | null | 1 |
2015-04-10T18:41:20Z
|
2021-09-08T08:00:50Z
|
2015-04-14T18:03:08Z
|
MEMBER
|
resolved
|
PyCon's weird.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2546/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2546/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2546.diff",
"html_url": "https://github.com/psf/requests/pull/2546",
"merged_at": "2015-04-14T18:03:08Z",
"patch_url": "https://github.com/psf/requests/pull/2546.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2546"
}
| true |
[
":sparkles: :sparkles: :sparkles:\n"
] |
https://api.github.com/repos/psf/requests/issues/2545
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2545/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2545/comments
|
https://api.github.com/repos/psf/requests/issues/2545/events
|
https://github.com/psf/requests/issues/2545
| 67,650,255 |
MDU6SXNzdWU2NzY1MDI1NQ==
| 2,545 |
Document filtering of 'None' values for url-encoded parameters
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/524596?v=4",
"events_url": "https://api.github.com/users/Varriount/events{/privacy}",
"followers_url": "https://api.github.com/users/Varriount/followers",
"following_url": "https://api.github.com/users/Varriount/following{/other_user}",
"gists_url": "https://api.github.com/users/Varriount/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Varriount",
"id": 524596,
"login": "Varriount",
"node_id": "MDQ6VXNlcjUyNDU5Ng==",
"organizations_url": "https://api.github.com/users/Varriount/orgs",
"received_events_url": "https://api.github.com/users/Varriount/received_events",
"repos_url": "https://api.github.com/users/Varriount/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Varriount/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Varriount/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Varriount",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-04-10T18:05:41Z
|
2021-09-08T23:05:44Z
|
2015-04-10T18:46:53Z
|
NONE
|
resolved
|
Currently, when passing a dictionary/list of pairs to the request constructor's `params` parameter, any 'None' values are filtered when encoding the request url. If this is intended behavior or not something that will change, then this should be documented (actually, even if it is subject to change, it should probably by documented anyway so that people don't rely on it)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2545/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2545/timeline
| null |
completed
| null | null | false |
[
"It already is documented. =) See [this block](http://docs.python-requests.org/en/latest/user/quickstart/#passing-parameters-in-urls).\n"
] |
https://api.github.com/repos/psf/requests/issues/2544
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2544/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2544/comments
|
https://api.github.com/repos/psf/requests/issues/2544/events
|
https://github.com/psf/requests/issues/2544
| 67,565,002 |
MDU6SXNzdWU2NzU2NTAwMg==
| 2,544 |
Fully disable cookie handling in Sessions
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1148150?v=4",
"events_url": "https://api.github.com/users/logc/events{/privacy}",
"followers_url": "https://api.github.com/users/logc/followers",
"following_url": "https://api.github.com/users/logc/following{/other_user}",
"gists_url": "https://api.github.com/users/logc/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/logc",
"id": 1148150,
"login": "logc",
"node_id": "MDQ6VXNlcjExNDgxNTA=",
"organizations_url": "https://api.github.com/users/logc/orgs",
"received_events_url": "https://api.github.com/users/logc/received_events",
"repos_url": "https://api.github.com/users/logc/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/logc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/logc/subscriptions",
"type": "User",
"url": "https://api.github.com/users/logc",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-04-10T10:36:29Z
|
2021-09-08T23:05:43Z
|
2015-04-10T11:03:59Z
|
NONE
|
resolved
|
This is a feature request, not a bug.
When creating a new `Session` in order to issue multiple requests, one can specify a `CookiePolicy` to reject all cookies (e.g. [this way](http://stackoverflow.com/a/21714597/2250036)). But for each new request, a new `RequestsCookieJar` is created, with a `DefaultCookiePolicy`, where previous cookies are merged.
Since there are no previous cookies, the behaviour is correct (no cookies are accepted), but the creation of those objects is costly and leads to a decreased performance. Working around this issue, with a subclass of Session that does not perform any cookie handling, gives a speedup of 1.32x or more, in our measurements.
Furthermore, it is a bit surprising that `Session` imposes this object creation to users, even if the user has specified that no cookie handling is needed (by setting the custom `CookiePolicy` after initialization), and even for a single request that does not create a `Session` (since a `Session` is created under the hood by all convenience methods like `requests.get`, `requests.post`).
Why is this behaviour so? Are there plans to create a variant of `Session` where cookies can be fully disabled? May we contribute our own workaround, if there is interest from other users?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2544/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2544/timeline
| null |
completed
| null | null | false |
[
"Thanks for this feature request!\n\nThe reality is that you haven't told the `Session` no cookie handling is needed, you've only told the cookiejar it owns. The `Session` has no way to be told that you don't want cookie handling, and it's simply not a feature requests possesses.\n\nThe reality is, vastly more users want cookie handling on and functioning than want to turn it off. For that reason we really have no plans to make it possible to fully disable cookie handling. If you're sufficiently worried about performance that you want to turn off one of requests' most important high-level features, I recommend investigating whether you can use `urllib3` just as easily. =)\n",
"Thanks to you for your swift answer! We will look into using directly `urllib3`…\n\n> El 10/4/2015, a las 13:04, Cory Benfield [email protected] escribió:\n> \n> Thanks for this feature request!\n> \n> The reality is that you haven't told the Session no cookie handling is needed, you've only told the cookiejar it owns. The Session has no way to be told that you don't want cookie handling, and it's simply not a feature requests possesses.\n> \n> The reality is, vastly more users want cookie handling on and functioning than want to turn it off. For that reason we really have no plans to make it possible to fully disable cookie handling. If you're sufficiently worried about performance that you want to turn off one of requests' most important high-level features, I recommend investigating whether you can use urllib3 just as easily. =)\n> \n> —\n> Reply to this email directly or view it on GitHub https://github.com/kennethreitz/requests/issues/2544#issuecomment-91518206.\n"
] |
https://api.github.com/repos/psf/requests/issues/2543
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2543/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2543/comments
|
https://api.github.com/repos/psf/requests/issues/2543/events
|
https://github.com/psf/requests/issues/2543
| 67,485,553 |
MDU6SXNzdWU2NzQ4NTU1Mw==
| 2,543 |
OpenSSL.SSL.SysCallError: (104, 'Connection reset by peer')
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3755338?v=4",
"events_url": "https://api.github.com/users/stamaimer/events{/privacy}",
"followers_url": "https://api.github.com/users/stamaimer/followers",
"following_url": "https://api.github.com/users/stamaimer/following{/other_user}",
"gists_url": "https://api.github.com/users/stamaimer/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/stamaimer",
"id": 3755338,
"login": "stamaimer",
"node_id": "MDQ6VXNlcjM3NTUzMzg=",
"organizations_url": "https://api.github.com/users/stamaimer/orgs",
"received_events_url": "https://api.github.com/users/stamaimer/received_events",
"repos_url": "https://api.github.com/users/stamaimer/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/stamaimer/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stamaimer/subscriptions",
"type": "User",
"url": "https://api.github.com/users/stamaimer",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 39 |
2015-04-10T01:31:08Z
|
2021-09-08T23:00:52Z
|
2015-04-21T05:58:54Z
|
NONE
|
resolved
|
I'm using the python package `requests` to send requests to https://mobile.twitter.com/username/following.
At first, I encounter the exception : requests.exceptions.SSLError: [Errno 8] _ssl.c:504: EOF occurred in violation of protocol. To solve that, I follow this solution to write a SSLAdapter to specify PROTOCOL_TLSv1.
After that, I encounter another exception : requests.exceptions.SSLError: [Errno bad handshake] (-1, 'Unexpected EOF’). And, I found this, but i send request and receive data in the same process.
And then, I use `requests` to send requests to https://api.twitter.com/1.1/friends/ids.json. The second exception is gone(still didn't understand why). But I encounter third exception : OpenSSL.SSL.SysCallError: (104, 'Connection reset by peer'). I found [this](http://stackoverflow.com/questions/383738/104-connection-reset-by-peer-socket-error-or-when-does-closing-a-socket-resu) in SO. And I add `time.sleep(10)` before send requests. But the third exception still happen.
So the second and the third exception still happen. Maybe the response content is too big too read? Or it's the problem of twitter server(some SO [solutions](http://stackoverflow.com/questions/23397460/error-handling-boto-error-104-connection-reset-by-peer) said about it ).
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2543/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2543/timeline
| null |
completed
| null | null | false |
[
"All of those exceptions indicate that Twitter is closing the connection on you. You should check whether your data is valid.\n",
"the data means the request header?\n",
"Could be the request headers, could be the request body. \n",
"the requests send to twitter need to be authorized. Maybe the bearer token is invalid. Thank for your reply.\n",
"the second exception is the problem of mine. because the program run out of the memory so the program wait for read data from the connection, but there is no space to store, so it seems dead lock. and the server wait till the time out, and the exception throws. but i still can not figure out why leads to the third exception.\n",
"I just had exactly the same error - but not with Twitter. In my case it's communication with the web interface of a local modem, which I interrogate for statistics. The request is exactly the same each time, and the program has been running for over 24 hours before the problem, so I suspect it is not an authorization problem. This is the complete backtrace:\n\n```\nTraceback (most recent call last):\n File \"/usr/local/bin/mon_quality.py\", line 255, in <module> main()\n File \"/usr/local/bin/mon_quality.py\", line 251, in main\n m.status_log(logfname, 15)\n File \"/usr/local/bin/mon_quality.py\", line 123, in status_log\n response = self.status_csv()\n File \"/usr/local/bin/mon_quality.py\", line 137, in status_csv\n stat = self.status()\n File \"/usr/local/bin/mon_quality.py\", line 190, in status\n data = payload, headers = self.hdrs)\n File \"/usr/lib64/python2.7/site-packages/requests-2.2.1-py2.7.egg/requests/sessions.py\", line 494, in post\n return self.request('POST', url, data=data, **kwargs)\n File \"/usr/lib64/python2.7/site-packages/requests-2.2.1-py2.7.egg/requests/sessions.py\", line 452, in request\n resp = self.send(prep, **send_kwargs)\n File \"/usr/lib64/python2.7/site-packages/requests-2.2.1-py2.7.egg/requests/sessions.py\", line 581, in send\n history = [resp for resp in gen] if allow_redirects else []\n File \"/usr/lib64/python2.7/site-packages/requests-2.2.1-py2.7.egg/requests/sessions.py\", line 175, in resolve_redirects\n allow_redirects=False,\n File \"/usr/lib64/python2.7/site-packages/requests-2.2.1-py2.7.egg/requests/sessions.py\", line 555, in send\n r = adapter.send(request, **kwargs)\n File \"/usr/lib64/python2.7/site-packages/requests-2.2.1-py2.7.egg/requests/adapters.py\", line 391, in send\n r.content\n File \"/usr/lib64/python2.7/site-packages/requests-2.2.1-py2.7.egg/requests/models.py\", line 690, in content\n self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes()\n File \"/usr/lib64/python2.7/site-packages/requests-2.2.1-py2.7.egg/requests/models.py\", line 628, in generate\n for chunk in self.raw.stream(chunk_size, decode_content=True):\n File \"/usr/lib64/python2.7/site-packages/requests-2.2.1-py2.7.egg/requests/packages/urllib3/response.py\", line 240, in stream\n data = self.read(amt=amt, decode_content=decode_content)\n File \"/usr/lib64/python2.7/site-packages/requests-2.2.1-py2.7.egg/requests/packages/urllib3/response.py\", line 187, in read\n data = self._fp.read(amt)\n File \"/usr/lib64/python2.7/httplib.py\", line 543, in read\n return self._read_chunked(amt)\n File \"/usr/lib64/python2.7/httplib.py\", line 612, in _read_chunked\n value.append(self._safe_read(chunk_left))\n File \"/usr/lib64/python2.7/httplib.py\", line 658, in _safe_read\n chunk = self.fp.read(min(amt, MAXAMOUNT))\n File \"/usr/lib64/python2.7/socket.py\", line 380, in read\n data = self._sock.recv(left)\n socket.error: [Errno 104] Connection reset by peer\n```\n",
"Again, to be clear, `Connection reset by peer` means that the remote end closed the connection while we were expecting to read data from it. In your case @JohnCC330, we're trying to read a chunked body and the chunk is not complete.\n\nYou should be trying to investigate why the modem closed the connection in a non-graceful manner.\n",
"> You should be trying to investigate why the modem closed the connection in a non-graceful manner.\n\nThese things can happen. Power can fall out, connections get broken. My question: is there a way to recuperate from such a situation in a graceful way? I have the impression that this is not solveable with a try...except - am I correct here? \n",
"It depends, because what 'recuperate' means depends on your use-case.\n\nIf this is a streaming API, then you should just reopen the connection and keep going. Try except is fine here.\n\nIf it's a whole request, you can retry the request, but don't retry forever because it may be that the request is malformed.\n\nI'd need to know your specific use case before I can be more helpful.\n",
"I am interrogating the modem stats each 15 seconds. Each time I log in, and download just one page. So, the requests are totally independent. And they are also identical, so there is no chance that they are malformed (except for hardware problems). The problem I'm investigating is that the modem switches speed because of poor line quality, so the connection may not be up all the time. \n\nThe problem has presented itself - until now - always when I send the login information with a POST.\n\nI've added a try...except around the POST and the following GET, hoping to catch the problem, but I have the impression that this error is not generating exceptions (from the error messages).\n",
"This error should absolutely be generating exceptions. What makes you think it isn't?\n",
"I was looking for an error message which said \"unhandled exception\"... which didn't appear, but I'm not quite sure where I got that idea... A try... except does seem to capture the problem, but I can't seem to re-enable the communication without actually exiting and re-entering the program. I do restart a new session, and try a new connection, but the program hangs. \n\nI've been quite occupied with more pressing issues, and the problem doesn't appear frequently (only after 3-5 hours of working normally). I tried cause the error by unplugging the phone line, but there the software recovers as expected.\n",
"If the software is hanging, it's possible we're re-using a broken socket. However, it's hard to know when you're using a version of requests that's so many versions behind the current release. Is it possible for you to test with a more recent version?\n",
"Wow... Installed requests.master from Github, and now the POST doesn't return any content. Only change was updating requests. I'll investigate the changelog.\n",
"With the new (2.6.1) version of requests, the communication ends with the POST (each time). The modem replies to the POST with a 303, which causes a ConnectionError exception, even though I have allow_redirects = True in the post request.\n\n```\n r = s.post(\"http://10.0.0.2/Forms/login_security_1\", # s is the session\n data = payload, headers = self.hdrs,\n allow_redirects = True)\n```\n\nIn wireshark:\n\n```\nHTTP/1.1 303 See Other\nLocation: http://10.0.0.2/rpSys.html\nContent-Length: 0\nServer: RomPager/4.07 UPnP/1.0\nSet-Cookie: C0=21232f297a57a5a743894a0e4a801fc3; path=/\nSet-Cookie: C1=21232f297a57a5a743894a0e4a801fc3; path=/\nEXT:\n```\n\nand I get the ConnectionError at this point. Strangely, the status_code of the POST is 200.\n",
"Do you see a TCP FIN in the wireshark output following the response?\n",
"Oh hang on, that appears to be an ill-formed header block. You can't have a name with no value.\n",
"Yep.... I noticed that, but had to leave for work. Back now, so I checked older captures I saved on disk, and the EXT name is always empty. Requests 2.2.1 seemed to be Ok with that though. I've checked through several specs and cannot find a requirement for this field to have anything. \n\nRFC 2616 http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2 seems to specify:\n\n```\n message-header = field-name \":\" [ field-value ]\n field-name = token\n field-value = *( field-content | LWS )\n field-content = <the OCTETs making up the field-value\n and consisting of either *TEXT or combinations\n of token, separators, and quoted-string>\n```\n\nSo, it seems that the LWS (linear white space) and CR/LF after the EXT: should be sufficient. Could it be that requests is generating the exception on that field? I suspect that is not the problem - the error reported is really ConnectionError.\n\nBTW, no FIN. I send the POST, get an ACK and the 303 in return. In case of requests 2.2.1, the communication redirected to the Location from the 303. In case of 2.6.1 the communication stopped. I'll test this tomorrow. It's 02:00 now...\n",
"Sorry, 7230 disagrees:\n\n```\n header-field = field-name \":\" OWS field-value OWS\n\n field-name = token\n field-value = *( field-content / obs-fold )\n field-content = field-vchar [ 1*( SP / HTAB ) field-vchar ]\n field-vchar = VCHAR / obs-text\n\n obs-fold = CRLF 1*( SP / HTAB )\n ; obsolete line folding\n ; see Section 3.2.4\n```\n\nCan I see the message in the ConnectionError?\n",
"Note that the '*' in\n\n```\nfield-value = *( field-content / obs-fold )\n```\n\nindicates, by default, 0 to infinite times. So empty is allowed (RFC5234 in http://tools.ietf.org/html/rfc5234, section 3.4)\n\nThere seems to be quite a bit of discussion around this... But the tendency is to allow empty values.\nIn IBM's http://www-01.ibm.com/support/docview.wss?uid=swg1PK96911 is a patch to allow empty values:\n\n> An empty Supported header is present in the message. This is a\n> valid message, specifying the client supports no\n> protocol extensions.\n\nAlso, Apache has this patch (https://issues.apache.org/jira/browse/TS-3495):\n\n> If I understand correctly, empty header value is allowed except pseudo-headers.\n\nThe message of the exception:\n\n> Error: `<class 'requests.exceptions.ConnectionError'>`\n> Message: ('Connection aborted.', ResponseNotReady())\n> Status: 200\n",
"Apologies, you are quite right.\n\nAre you sure the ConnectionError comes out of the original request? I suspect it comes out of the 303, and it would be caused by httplib not thinking the response was finished.\n",
"As I said earlier, the problem _is_ the 303:\n\n> I send the POST, get an ACK and the 303 in return. In case of requests 2.2.1, the communication redirected to the Location from the 303. In case of 2.6.1 the communication stopped. I'll test this tomorrow. It's 02:00 now...\n\nbut the httplib is the same in both cases (requests 2.2.1 and 2.6.1) I did not change the python version. So why do I have problems with requests 2.6.1? \n\n\"ResponseNotReady()\" comes from httplib though. Is there a difference in the calling of of httplib by r 2.2.1 and 2.6.1?\n",
"This is the validation of the header line in rfc822.py:\n\n```\ndef isheader(self, line):\n i = line.find(':')\n if i > 0:\n return line[:i].lower()\n return None\n```\n\nIt doesn't seem to check for empty values. \n\nCould this be an unchecked special situation, where an empty header is the _last_ header in the header section?\n",
"Let me be clear.\n\nI'm not pointing the finger of blame at httplib. My theory is that this is another manifestation of #2568. What's confusing me is why that would happen if chunked transfer encoding is not specified.\n",
"I have to correct something I said earlier: There _is_ a FIN just after the POST. When I said there wasn't, that was because I was relying (erronously) on a saved wireshark capture. I was re-testing all this, and I now see that a FIN is sent 1ms after the POST goes out. This is a similar situation as #2568. Mikkelsen does two GETs, I do a POST immediately followed by a GET. I suspect he might have a FIN in between the GETs too.\n\n$64,000 question: why the FIN?\n\n> My theory is that this is another manifestation of #2568\n\nIt would a hell of a coincidence if it wasn't related... Same exception... Same version...\n",
"@JohnCC330 How urgent is a fix for this? Are you ok to wait until we have a proposed fix for #2568?\n",
"Well, I switched back to 2.2.1 for now. So, I'm back to the original problem I reported, which was _not_ covered by that issue. There's no life-or-death situation here...\n",
"I am noticing OpenSSL.SSL.SysCallError errors when Twitter API server has closed the connection. I was surprised to get it and was expecting a requests.exceptions.ConnectionError instead. It would be nice if requests could hide some of these details. But my understanding of how all this is working is admittedly limited.\n",
"@edsu what version of Python is installed and what version of requests is in use?\n",
"Sorry, I'm actually the proxy for someone else (@remagio) who reported the exception getting thrown over at https://github.com/edsu/twarc/issues/72 From the stack trace it looks like he is using python 2.7, but it wasn't clear what the version of requests was at play. I've asked him to check. Perhaps it's an older version that is behaving this way?\n"
] |
https://api.github.com/repos/psf/requests/issues/2542
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2542/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2542/comments
|
https://api.github.com/repos/psf/requests/issues/2542/events
|
https://github.com/psf/requests/issues/2542
| 67,485,487 |
MDU6SXNzdWU2NzQ4NTQ4Nw==
| 2,542 |
Simple get request never returns
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1853442?v=4",
"events_url": "https://api.github.com/users/tomkcook/events{/privacy}",
"followers_url": "https://api.github.com/users/tomkcook/followers",
"following_url": "https://api.github.com/users/tomkcook/following{/other_user}",
"gists_url": "https://api.github.com/users/tomkcook/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/tomkcook",
"id": 1853442,
"login": "tomkcook",
"node_id": "MDQ6VXNlcjE4NTM0NDI=",
"organizations_url": "https://api.github.com/users/tomkcook/orgs",
"received_events_url": "https://api.github.com/users/tomkcook/received_events",
"repos_url": "https://api.github.com/users/tomkcook/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/tomkcook/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tomkcook/subscriptions",
"type": "User",
"url": "https://api.github.com/users/tomkcook",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-04-10T01:30:24Z
|
2021-09-08T23:05:44Z
|
2015-04-10T02:21:09Z
|
NONE
|
resolved
|
The following request never returns:
```
import requests
r = requests.get('http://en.wikipedia.org/w/api.php?rcprop=ids&format=json&action=query&rclimit=10&rctype=edit&list=recentchanges&rcnamespace=0', headers={'user-agent': 'api test'})
```
I've tried under both Python 2.7 and Python 3.
Adding a timeout (eg 5 seconds) causes the request to complete successfully - but adds 5s latency to every request. And, of course, makes the request fail if the API call takes longer than 5s to process. So I guess what is happening is that the server has finished sending the response but Requests is sat waiting for ... something ... to happen. What? Is it possible that the server is sending a wrong content-length?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2542/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2542/timeline
| null |
completed
| null | null | false |
[
"Sorry, this turned out to be because IPv6 claims to work on my network but doesn't work very well. Setting a timeout would then cause the IPv6 request to timeout and the request would fall back to IPv4, which succeeds.\n"
] |
https://api.github.com/repos/psf/requests/issues/2541
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2541/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2541/comments
|
https://api.github.com/repos/psf/requests/issues/2541/events
|
https://github.com/psf/requests/issues/2541
| 67,095,121 |
MDU6SXNzdWU2NzA5NTEyMQ==
| 2,541 |
Bundled cacert.pem with too much certificate?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/297578?v=4",
"events_url": "https://api.github.com/users/Glandos/events{/privacy}",
"followers_url": "https://api.github.com/users/Glandos/followers",
"following_url": "https://api.github.com/users/Glandos/following{/other_user}",
"gists_url": "https://api.github.com/users/Glandos/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Glandos",
"id": 297578,
"login": "Glandos",
"node_id": "MDQ6VXNlcjI5NzU3OA==",
"organizations_url": "https://api.github.com/users/Glandos/orgs",
"received_events_url": "https://api.github.com/users/Glandos/received_events",
"repos_url": "https://api.github.com/users/Glandos/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Glandos/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Glandos/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Glandos",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 6 |
2015-04-08T10:06:01Z
|
2021-09-08T23:05:44Z
|
2015-04-10T09:30:30Z
|
NONE
|
resolved
|
I am currently using pip and requests on SLES11SP3, which has the following software installed:
- python-2.6.8 (but I got the same behavior with a self-compiled 2.7.9)
- openssl-0.9.8j
- curl-7.19.7
- python-pip-6.0.8
I am experiencing really strange issues. With the bundled cacert.pem from requests-2.6.0, I have an SSL exception:
```
>>> import requests
>>> requests.get('https://pypi.python.org')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/root/test/lib/python2.6/site-packages/requests/api.py", line 65, in get
return request('get', url, **kwargs)
File "/root/test/lib/python2.6/site-packages/requests/api.py", line 49, in request
response = session.request(method=method, url=url, **kwargs)
File "/root/test/lib/python2.6/site-packages/requests/sessions.py", line 461, in request
resp = self.send(prep, **send_kwargs)
File "/root/test/lib/python2.6/site-packages/requests/sessions.py", line 573, in send
r = adapter.send(request, **kwargs)
File "/root/test/lib/python2.6/site-packages/requests/adapters.py", line 431, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: [Errno 1] _ssl.c:491: error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed
```
This behavior is confirmed with curl:
```
# curl --capath /dev/null --cacert cacert.pem.requests https://pypi.python.org
curl: (60) SSL certificate problem, verify that the CA cert is OK. Details:
error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed
```
However, if I remove any of the last 4 certificates in the bundle, everything works as expected. Currently, the last 4 issuers are:
```
# Issuer: CN=CA Disig Root R1 O=Disig a.s.
# Issuer: CN=CA Disig Root R2 O=Disig a.s.
# Issuer: CN=ACCVRAIZ1 O=ACCV OU=PKIACCV
# Issuer: CN=TWCA Global Root CA O=TAIWAN-CA OU=Root CA
```
Do you have any idea why? Is it linked to openssl being too old? Unfortunately, I can't upgrade it, it is a system library. But modifying every virtualenv I create on this machine to change the bundle will be a pain…
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/297578?v=4",
"events_url": "https://api.github.com/users/Glandos/events{/privacy}",
"followers_url": "https://api.github.com/users/Glandos/followers",
"following_url": "https://api.github.com/users/Glandos/following{/other_user}",
"gists_url": "https://api.github.com/users/Glandos/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Glandos",
"id": 297578,
"login": "Glandos",
"node_id": "MDQ6VXNlcjI5NzU3OA==",
"organizations_url": "https://api.github.com/users/Glandos/orgs",
"received_events_url": "https://api.github.com/users/Glandos/received_events",
"repos_url": "https://api.github.com/users/Glandos/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Glandos/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Glandos/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Glandos",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2541/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2541/timeline
| null |
completed
| null | null | false |
[
"I'm not finding any problem on my ubuntu machine. I also find it particularly hard to understand this problem because none of those four certificates have anything to do with the trust path:\n\n```\n---\nCertificate chain\n 0 s:/businessCategory=Private Organization/1.3.6.1.4.1.311.60.2.1.3=US/1.3.6.1.4.1.311.60.2.1.2=Delaware/serialNumber=3359300/street=16 Allen Rd/postalCode=03894-4801/C=US/ST=NH/L=Wolfeboro,/O=Python Software\nFoundation/CN=www.python.org\n i:/C=US/O=DigiCert Inc/OU=www.digicert.com/CN=DigiCert SHA2 Extended Validation Server CA\n 1 s:/C=US/O=DigiCert Inc/OU=www.digicert.com/CN=DigiCert SHA2 Extended Validation Server CA\n i:/C=US/O=DigiCert Inc/OU=www.digicert.com/CN=DigiCert High Assurance EV Root CA\n---\n```\n\nThat makes me tempted to say the problem is that OpenSSL is too old.\n",
"That's why I'm just asking for expertise here. I know there is nothing related with those certificates. It also works on my openSuse 13.2, but on SLES 11 SP3 (and it was also the case on the very old SLES 10), I need this **ugly** workaround…\nIt might be related to openssl, but in which way the number, or the type of certificates in a PEM file changes its behavior?\n",
"I've definitely seen this problem before and it's definitely a bug in openssl.\n",
"Stupid question, what architecture are you using on 13.2, SLES11SP3, and SLES10. I can't find where I've seen this before, but I'm still looking.\n",
"Architecture? Do you mean x86_64?\n\nBy the way, I'm recompiling openssl, and it _seems_ to work. However, I think that overriding system libraries is not a good idea :cry: \n",
"I'm closing this issue, since it is not related to requests. However, for anyone looking for help using Suse Linux Enterprise, don't be surprised: you'll have to recompile openssl, and it's not hassle-free at all.\n"
] |
https://api.github.com/repos/psf/requests/issues/2540
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2540/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2540/comments
|
https://api.github.com/repos/psf/requests/issues/2540/events
|
https://github.com/psf/requests/issues/2540
| 67,022,847 |
MDU6SXNzdWU2NzAyMjg0Nw==
| 2,540 |
MisssingSchema error message does not handle unicode input correctly
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/928271?v=4",
"events_url": "https://api.github.com/users/ma2rten/events{/privacy}",
"followers_url": "https://api.github.com/users/ma2rten/followers",
"following_url": "https://api.github.com/users/ma2rten/following{/other_user}",
"gists_url": "https://api.github.com/users/ma2rten/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ma2rten",
"id": 928271,
"login": "ma2rten",
"node_id": "MDQ6VXNlcjkyODI3MQ==",
"organizations_url": "https://api.github.com/users/ma2rten/orgs",
"received_events_url": "https://api.github.com/users/ma2rten/received_events",
"repos_url": "https://api.github.com/users/ma2rten/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ma2rten/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ma2rten/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ma2rten",
"user_view_type": "public"
}
|
[
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
},
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"name": "Contributor Friendly",
"node_id": "MDU6TGFiZWwxOTEyNzQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Contributor%20Friendly"
}
] |
closed
| true | null |
[] | null | 3 |
2015-04-08T00:56:52Z
|
2021-09-08T23:05:43Z
|
2015-04-11T19:11:01Z
|
NONE
|
resolved
|
using requests 2.6.0, Python 2.7.6
```
import requests
requests.get(u"hällo world")
```
```
---------------------------------------------------------------------------
UnicodeEncodeError Traceback (most recent call last)
<ipython-input-3-bf1281984b3a> in <module>()
----> 1 requests.get(url)
/Library/Python/2.7/site-packages/requests-2.6.0-py2.7.egg/requests/api.pyc in get(url, **kwargs)
66
67 kwargs.setdefault('allow_redirects', True)
---> 68 return request('get', url, **kwargs)
69
70
/Library/Python/2.7/site-packages/requests-2.6.0-py2.7.egg/requests/api.pyc in request(method, url, **kwargs)
48
49 session = sessions.Session()
---> 50 response = session.request(method=method, url=url, **kwargs)
51 # By explicitly closing the session, we avoid leaving sockets open which
52 # can trigger a ResourceWarning in some cases, and look like a memory leak
/Library/Python/2.7/site-packages/requests-2.6.0-py2.7.egg/requests/sessions.pyc in request(self, method, url, params, data, headers, cookies, files, auth, timeout, allow_redirects, proxies, hooks, stream, verify, cert, json)
448 hooks = hooks,
449 )
--> 450 prep = self.prepare_request(req)
451
452 proxies = proxies or {}
/Library/Python/2.7/site-packages/requests-2.6.0-py2.7.egg/requests/sessions.pyc in prepare_request(self, request)
379 auth=merge_setting(auth, self.auth),
380 cookies=merged_cookies,
--> 381 hooks=merge_hooks(request.hooks, self.hooks),
382 )
383 return p
/Library/Python/2.7/site-packages/requests-2.6.0-py2.7.egg/requests/models.pyc in prepare(self, method, url, headers, files, data, params, auth, cookies, hooks, json)
302
303 self.prepare_method(method)
--> 304 self.prepare_url(url, params)
305 self.prepare_headers(headers)
306 self.prepare_cookies(cookies)
/Library/Python/2.7/site-packages/requests-2.6.0-py2.7.egg/requests/models.pyc in prepare_url(self, url, params)
359 if not scheme:
360 raise MissingSchema("Invalid URL {0!r}: No schema supplied. "
--> 361 "Perhaps you meant http://{0}?".format(url))
362
363 if not host:
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe4' in position 1: ordinal not in range(128)
```
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2540/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2540/timeline
| null |
completed
| null | null | false |
[
"Ugh, Python 2, why do you suck so much?\n\nI don't consider this a highly urgent bug because to hit it requires that you be using not just a unicode URL but an invalid one. It's also impossible to hit in Python 3, which further limits its scope. That said, it's definitely a real bug and if anyone wants to fix it they should consider taking a shot.\n",
"Thanks for your quick reply.\n",
"This is now fixed. =)\n"
] |
https://api.github.com/repos/psf/requests/issues/2539
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2539/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2539/comments
|
https://api.github.com/repos/psf/requests/issues/2539/events
|
https://github.com/psf/requests/issues/2539
| 66,985,855 |
MDU6SXNzdWU2Njk4NTg1NQ==
| 2,539 |
Noisy SSL warnings
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/7684843?v=4",
"events_url": "https://api.github.com/users/tonyennis/events{/privacy}",
"followers_url": "https://api.github.com/users/tonyennis/followers",
"following_url": "https://api.github.com/users/tonyennis/following{/other_user}",
"gists_url": "https://api.github.com/users/tonyennis/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/tonyennis",
"id": 7684843,
"login": "tonyennis",
"node_id": "MDQ6VXNlcjc2ODQ4NDM=",
"organizations_url": "https://api.github.com/users/tonyennis/orgs",
"received_events_url": "https://api.github.com/users/tonyennis/received_events",
"repos_url": "https://api.github.com/users/tonyennis/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/tonyennis/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tonyennis/subscriptions",
"type": "User",
"url": "https://api.github.com/users/tonyennis",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 2 |
2015-04-07T20:43:18Z
|
2021-09-08T23:05:45Z
|
2015-04-08T00:34:40Z
|
NONE
|
resolved
|
Is there a way to suppress these noisy SSL warnings? I got them by specifying requests.get(..., verify=False) when I was trying to use some self-signed web services.
/usr/lib/python2.7/site-packages/requests/packages/urllib3/util/ssl_.py:79: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
InsecurePlatformWarning
/usr/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py:769: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.org/en/latest/security.html
InsecureRequestWarning)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2539/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2539/timeline
| null |
completed
| null | null | false |
[
"`requests.packages.urllib3.disable_warnings()`.\n",
"Thank you!\n"
] |
https://api.github.com/repos/psf/requests/issues/2538
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2538/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2538/comments
|
https://api.github.com/repos/psf/requests/issues/2538/events
|
https://github.com/psf/requests/issues/2538
| 66,858,705 |
MDU6SXNzdWU2Njg1ODcwNQ==
| 2,538 |
Dependency is not satisfiable: python (>= 2.7.5-5~)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/3397477?v=4",
"events_url": "https://api.github.com/users/francesco1119/events{/privacy}",
"followers_url": "https://api.github.com/users/francesco1119/followers",
"following_url": "https://api.github.com/users/francesco1119/following{/other_user}",
"gists_url": "https://api.github.com/users/francesco1119/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/francesco1119",
"id": 3397477,
"login": "francesco1119",
"node_id": "MDQ6VXNlcjMzOTc0Nzc=",
"organizations_url": "https://api.github.com/users/francesco1119/orgs",
"received_events_url": "https://api.github.com/users/francesco1119/received_events",
"repos_url": "https://api.github.com/users/francesco1119/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/francesco1119/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/francesco1119/subscriptions",
"type": "User",
"url": "https://api.github.com/users/francesco1119",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 9 |
2015-04-07T11:26:36Z
|
2021-09-08T23:05:45Z
|
2015-04-07T13:40:08Z
|
NONE
|
resolved
|
hello,
I'm trying to install python-requests on my Debian Wheezy from the .deb:
# gdebi python-requests_2.4.3-6_all.deb
Reading package lists... Done
Building dependency tree
Reading state information... Done
Building data structures... Done
Building data structures... Done
This package is uninstallable
Dependency is not satisfiable: python (>= 2.7.5-5~)
Well, is quite strange as with a "python -V" the output is: Python 2.7.7.
And I have already tried all of those chances: http://docs.python-requests.org/en/latest/user/install/#install
Any idea?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2538/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2538/timeline
| null |
completed
| null | null | false |
[
"I'm afraid we can't support you with the `.deb`, because we don't build or maintain that package, @ralphbean does. I recommend raising a bug with debian if you're having trouble.\n\nWhen you say you've tried the install methods on our website, which methods have you actually tried and how did they fail?\n",
"Thank you, I will contact Debian for that. \nI've trued to download the tar.gz from GitHub: nothing\nThen:\n\n# pip install requests\n\nRequirement already satisfied (use --upgrade to upgrade): requests in /usr/local/lib/python2.7/dist-packages\n\n# easy_install requests\n\nSearching for requests\nBest match: requests 2.6.0\nAdding requests 2.6.0 to easy-install.pth file\n\nUsing /usr/local/lib/python2.7/dist-packages\nProcessing dependencies for requests\nFinished processing dependencies for requests\n\nWith git clone and the tar.gz there is apparently no problem, but then it doesn't work:\n\npython setup.py install\n/root/.pythonbrew/pythons/Python-2.7.7/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'extras_require'\n warnings.warn(msg)\n/root/.pythonbrew/pythons/Python-2.7.7/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'zip_safe'\n warnings.warn(msg)\n/root/.pythonbrew/pythons/Python-2.7.7/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'include_package_data'\n warnings.warn(msg)\n/root/.pythonbrew/pythons/Python-2.7.7/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'install_requires'\n warnings.warn(msg)\nrunning install\nrunning build\nrunning build_py\ncreating build\ncreating build/lib\ncreating build/lib/requests\ncopying requests/sessions.py -> build/lib/requests\ncopying requests/certs.py -> build/lib/requests\ncopying requests/api.py -> build/lib/requests\ncopying requests/structures.py -> build/lib/requests\ncopying requests/cookies.py -> build/lib/requests\ncopying requests/utils.py -> build/lib/requests\ncopying requests/status_codes.py -> build/lib/requests\ncopying requests/**init**.py -> build/lib/requests\ncopying requests/hooks.py -> build/lib/requests\ncopying requests/models.py -> build/lib/requests\ncopying requests/adapters.py -> build/lib/requests\ncopying requests/compat.py -> build/lib/requests\ncopying requests/exceptions.py -> build/lib/requests\ncopying requests/auth.py -> build/lib/requests\ncreating build/lib/requests/packages\ncopying requests/packages/**init**.py -> build/lib/requests/packages\ncreating build/lib/requests/packages/chardet\ncopying requests/packages/chardet/universaldetector.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/mbcharsetprober.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/langthaimodel.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/sjisprober.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/constants.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/gb2312prober.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/latin1prober.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/charsetgroupprober.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/mbcssm.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/**init**.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/euckrfreq.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/euctwprober.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/big5prober.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/sbcharsetprober.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/langbulgarianmodel.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/escprober.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/jisfreq.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/eucjpprober.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/mbcsgroupprober.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/sbcsgroupprober.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/chardistribution.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/codingstatemachine.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/langhungarianmodel.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/gb2312freq.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/big5freq.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/euctwfreq.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/hebrewprober.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/jpcntx.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/compat.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/charsetprober.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/euckrprober.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/escsm.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/langgreekmodel.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/chardetect.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/langcyrillicmodel.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/utf8prober.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/cp949prober.py -> build/lib/requests/packages/chardet\ncopying requests/packages/chardet/langhebrewmodel.py -> build/lib/requests/packages/chardet\ncreating build/lib/requests/packages/urllib3\ncopying requests/packages/urllib3/request.py -> build/lib/requests/packages/urllib3\ncopying requests/packages/urllib3/**init**.py -> build/lib/requests/packages/urllib3\ncopying requests/packages/urllib3/_collections.py -> build/lib/requests/packages/urllib3\ncopying requests/packages/urllib3/filepost.py -> build/lib/requests/packages/urllib3\ncopying requests/packages/urllib3/poolmanager.py -> build/lib/requests/packages/urllib3\ncopying requests/packages/urllib3/connectionpool.py -> build/lib/requests/packages/urllib3\ncopying requests/packages/urllib3/response.py -> build/lib/requests/packages/urllib3\ncopying requests/packages/urllib3/fields.py -> build/lib/requests/packages/urllib3\ncopying requests/packages/urllib3/exceptions.py -> build/lib/requests/packages/urllib3\ncopying requests/packages/urllib3/connection.py -> build/lib/requests/packages/urllib3\ncreating build/lib/requests/packages/urllib3/packages\ncopying requests/packages/urllib3/packages/six.py -> build/lib/requests/packages/urllib3/packages\ncopying requests/packages/urllib3/packages/__init__.py -> build/lib/requests/packages/urllib3/packages\ncopying requests/packages/urllib3/packages/ordered_dict.py -> build/lib/requests/packages/urllib3/packages\ncreating build/lib/requests/packages/urllib3/contrib\ncopying requests/packages/urllib3/contrib/**init**.py -> build/lib/requests/packages/urllib3/contrib\ncopying requests/packages/urllib3/contrib/pyopenssl.py -> build/lib/requests/packages/urllib3/contrib\ncopying requests/packages/urllib3/contrib/ntlmpool.py -> build/lib/requests/packages/urllib3/contrib\ncreating build/lib/requests/packages/urllib3/util\ncopying requests/packages/urllib3/util/ssl_.py -> build/lib/requests/packages/urllib3/util\ncopying requests/packages/urllib3/util/request.py -> build/lib/requests/packages/urllib3/util\ncopying requests/packages/urllib3/util/**init**.py -> build/lib/requests/packages/urllib3/util\ncopying requests/packages/urllib3/util/timeout.py -> build/lib/requests/packages/urllib3/util\ncopying requests/packages/urllib3/util/response.py -> build/lib/requests/packages/urllib3/util\ncopying requests/packages/urllib3/util/retry.py -> build/lib/requests/packages/urllib3/util\ncopying requests/packages/urllib3/util/url.py -> build/lib/requests/packages/urllib3/util\ncopying requests/packages/urllib3/util/connection.py -> build/lib/requests/packages/urllib3/util\ncreating build/lib/requests/packages/urllib3/packages/ssl_match_hostname\ncopying requests/packages/urllib3/packages/ssl_match_hostname/**init**.py -> build/lib/requests/packages/urllib3/packages/ssl_match_hostname\ncopying requests/packages/urllib3/packages/ssl_match_hostname/_implementation.py -> build/lib/requests/packages/urllib3/packages/ssl_match_hostname\ncopying requests/cacert.pem -> build/lib/requests\nrunning install_lib\nrunning install_egg_info\nRemoving /root/.pythonbrew/pythons/Python-2.7.7/lib/python2.7/site-packages/requests-2.6.0-py2.7.egg-info\nWriting /root/.pythonbrew/pythons/Python-2.7.7/lib/python2.7/site-packages/requests-2.6.0-py2.7.egg-info\n\nThank you\n",
"> I'm afraid we can't support you with the .deb, because we don't build or maintain that package, @ralphbean does.\n\nJust a correction: I do not support the debian redistribution, @eriol does. I work on the `.rpm` packaging for Fedora and EPEL. Regardless, thanks for the ping!\n",
"I think @lukasa meant to ping @eriol\n",
"Additionally, it's worth noting that the install appears to have gone just fine.\n",
"So actually this looks like @francesco1119 is using python brew to install things, which does not work (I would guess) with aptitude/dpkg. That would be your problem @francesco1119. You can't mix python brew with system packages. You should look for `/usr/bin/python` (or something like that) to determine:\n1. If you have Python installed\n2. What version of Python _is_ installed.\n",
"Python is at the version 2.7.7. \nSo let's say I don't want to use .deb but \"pip install requests\". I launch the command the the terminal replay:\n\nRequirement already satisfied (use --upgrade to upgrade): requests in /usr/local/lib/python2.7/dist-packages\n\nApparently looks ok, so I try to install pulseaudio-dlna_0.3.4_all.deb (that needs python-request) and the terminal says:\n\nReading package lists... Done\nBuilding dependency tree \nReading state information... Done\nBuilding data structures... Done \nBuilding data structures... Done \nThis package is uninstallable\nDependency is not satisfiable: python-requests (>= 2.2.1)\n\nSo it means that python-requests is installed but not the version I need. How to upgrade it?\n",
"@francesco1119 You're clearly in a whole world of dependency pain.\n\nThe reason pulseaudio can't satisfy its requests requirement is because there is no requests package installed, because apt-get ignores anything installed by pip. Your inability to install requests is a much bigger problem, and clearly your system requires real work to get into a good state again.\n",
"Hello, thanks for the ping for the Debian related stuff!\n\n@francesco1119 I don't know python brew but it does not create a _Debian package_ (for this you can use [stdeb](https://github.com/astraw/stdeb)) so this is why when installing pulseaudio-dlna_0.3.4_all.deb you get that dependency is not satisfiable.\nIf you want to use pulseaudio-dlna_0.3.4_all.deb (it's not an official Debian package, did you package it by yourself?) the best thing to do is to backport requests from Jessie. Keep in mind that you have to backport python-urllib3 before backporting requests since, in Debian, requests uses the system-wide urllib3.\nTo backporting a package you can follow https://wiki.debian.org/SimpleBackportCreation\n\nOtherwise you can use stdeb and package requests from PyPI (you don't need to follow Debian Policy for a package builded by yourself), and then install pulseaudio-dlna_0.3.4_all.deb. Or since you seems at ease with python brew, you can see if you can install pulseaudio-dlna using it.\n\nHTH\n"
] |
https://api.github.com/repos/psf/requests/issues/2537
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2537/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2537/comments
|
https://api.github.com/repos/psf/requests/issues/2537/events
|
https://github.com/psf/requests/issues/2537
| 66,774,224 |
MDU6SXNzdWU2Njc3NDIyNA==
| 2,537 |
Support DNS roundrobin with failure detection
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/905538?v=4",
"events_url": "https://api.github.com/users/twiggy/events{/privacy}",
"followers_url": "https://api.github.com/users/twiggy/followers",
"following_url": "https://api.github.com/users/twiggy/following{/other_user}",
"gists_url": "https://api.github.com/users/twiggy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/twiggy",
"id": 905538,
"login": "twiggy",
"node_id": "MDQ6VXNlcjkwNTUzOA==",
"organizations_url": "https://api.github.com/users/twiggy/orgs",
"received_events_url": "https://api.github.com/users/twiggy/received_events",
"repos_url": "https://api.github.com/users/twiggy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/twiggy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/twiggy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/twiggy",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 5 |
2015-04-07T04:46:49Z
|
2021-09-08T23:05:45Z
|
2015-04-07T11:30:50Z
|
NONE
|
resolved
|
As we move into the cloud world with multiple subnets failing over transparently is becoming more and more of a pain.
Many database systems for instance support the DNS entry for the server having multiple IP addresses in a set. The client is smart enough to know which IP is up and listening and failover to the other quickly.
HTTP doesn't come with such facilities, but Requests is a perfect place to add it.
Imagine website.com having a record set of 10.10.10.5/24 and 10.10.11.5/25. Imagine these are load balancers such as nginx or haproxy sitting in two distinct subnets perhaps even in two data centers.
The client is going to make web service requests of website.com. If 10.10.11.5/24 goes down the clients should make requests to 10.10.10.5/24 only.
This is more a request for peoples opinions on whether this should be added to the framework and where. Typically this kind of functionality is accomplished transparently to the web clients using a "smart" dns server with health checks among other things. IMHO I feel like that just creates complexities that could be done better and more importantly faster at the client level.
Thanks,
Eric
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2537/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2537/timeline
| null |
completed
| null | null | false |
[
"If you specify a connection timeout and Requests can't connect to the first host specified via a DNS lookup, it will try the next host. \n\nThis request will take 18 seconds for example: \n\n``` python\nstart = time.time()\ntry:\n requests.get('http://google.com:81', \n timeout=3)\nexcept ConnectTimeout: pass\nprint time.time() - start \n```\n\n(via [my slides](https://kev.inburke.com/slides/reliable-http/#server-unreachable))\n\nThis is because google.com has 6 IP addresses listed. Note, this functionality is super below Requests, it's at the OS level I am pretty sure.\n\nCaching the good DNS host is another matter; as you mentioned you might want to try something like requests talking to haproxy locally (this is what we used at Twilio for example). HAProxy will do health checks and stop sending traffic to a down host.\n",
"This functionality is not that far below requests, it's in urllib3, [here](https://github.com/shazow/urllib3/blob/master/urllib3/util/connection.py#L46-L90).\n\nWe effectively get this logic because we attempt to connect to each result returned by the DNS server, and once we do we do our best to continue to use that connection. If we can't, we'll attempt to reconnect, including trying other IP addresses. This is important because setting multiple A records for your domain name is commonly used to attempt to balance load.\n\nStepping further ahead, I don't know what this means:\n\n> Imagine website.com having a record set of 10.10.10.5/24 and 10.10.11.5/25.\n\nThat's just not how DNS works, unless the domain name actually has 384 A records (256 for the /24 and 128 for the /25). Additionally, your addresses are weird, given that they'd ordinarily be represented 10.10.10.0/24 and 10.10.11.0/25 (neither of the 5s have any high bits that would be frozen by their mask).\n\nRegardless, the summary is that we currently have this functionality. I can see some advantage in trying to short-circuit some of the DNS logic in userspace, but it's a fraught approach that can be easy to get wrong.\n",
"/25 should have been /24. Just denoting that I have boxes in 2 subnets. The point there being I'm trying to make my front end boxes use the \"closest(s)\" servers first. \n\nMaybe change this to a documentation request(or do it myself). I don't see anywhere in the docs that talk about A record sets with multiple IPs.\n\nJust to clarify is Requests looping through the list of IP addresses coming from DNS or is Urllib3 doing it, that urllib3 snippet above doesn't look like it is looping.\n\nThanks!!!!\n",
"@kevinburke thanks for your response too. I'm actually already using timeout in my code, but I think that also controls how long the request can take. We have some requests that take quite a while like 25 seconds (not great form) based on some app requirements we have.\n\nI'll see how hard it might be to add a connection_timeout option and maybe put in a request or pull request for that. \n\n:update looking at the code I immediately see something about connection timeout in a tuple of some sort.) So hopefully that works.\n\nThanks!!!!\n",
"urllib3 does it: the loop is `for res in socket.getaddrinfo(host, port, 0, socket.SOCK_STREAM)`\n"
] |
https://api.github.com/repos/psf/requests/issues/2536
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2536/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2536/comments
|
https://api.github.com/repos/psf/requests/issues/2536/events
|
https://github.com/psf/requests/pull/2536
| 66,668,496 |
MDExOlB1bGxSZXF1ZXN0MzI2OTcwNjU=
| 2,536 |
Document that "PreparedRequest.prepare_cookies" can only be called once
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/354181?v=4",
"events_url": "https://api.github.com/users/smiley/events{/privacy}",
"followers_url": "https://api.github.com/users/smiley/followers",
"following_url": "https://api.github.com/users/smiley/following{/other_user}",
"gists_url": "https://api.github.com/users/smiley/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/smiley",
"id": 354181,
"login": "smiley",
"node_id": "MDQ6VXNlcjM1NDE4MQ==",
"organizations_url": "https://api.github.com/users/smiley/orgs",
"received_events_url": "https://api.github.com/users/smiley/received_events",
"repos_url": "https://api.github.com/users/smiley/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/smiley/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/smiley/subscriptions",
"type": "User",
"url": "https://api.github.com/users/smiley",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 0 |
2015-04-06T18:10:05Z
|
2021-09-08T08:00:53Z
|
2015-04-06T22:29:17Z
|
CONTRIBUTOR
|
resolved
|
I've done the documentation changes suggested in #2532.
I also documented a way to work around this in the docstring, but I'm not sure if it'd be good to do so. (As it may lead to hacked-together solutions) Then again, other solutions like creating a brand new `Request` might lead to worse problems. (e.g.: loss of data)
@sigmavirus24, what do you think?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2536/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2536/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2536.diff",
"html_url": "https://github.com/psf/requests/pull/2536",
"merged_at": "2015-04-06T22:29:17Z",
"patch_url": "https://github.com/psf/requests/pull/2536.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2536"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/2535
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2535/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2535/comments
|
https://api.github.com/repos/psf/requests/issues/2535/events
|
https://github.com/psf/requests/pull/2535
| 66,612,642 |
MDExOlB1bGxSZXF1ZXN0MzI2ODAyMjk=
| 2,535 |
Fix build version number in metadata
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-04-06T14:02:45Z
|
2021-09-08T08:00:53Z
|
2015-04-06T21:54:22Z
|
CONTRIBUTOR
|
resolved
|
Closes #2530
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2535/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2535/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2535.diff",
"html_url": "https://github.com/psf/requests/pull/2535",
"merged_at": "2015-04-06T21:54:22Z",
"patch_url": "https://github.com/psf/requests/pull/2535.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2535"
}
| true |
[
"_/me forgot to make this last night_ Sorry @Lukasa \n"
] |
https://api.github.com/repos/psf/requests/issues/2534
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2534/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2534/comments
|
https://api.github.com/repos/psf/requests/issues/2534/events
|
https://github.com/psf/requests/pull/2534
| 66,508,792 |
MDExOlB1bGxSZXF1ZXN0MzI2NTkwMTA=
| 2,534 |
Copy a PreparedRequest's CookieJar reliably
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-04-06T02:29:14Z
|
2021-09-08T08:00:54Z
|
2015-04-06T11:15:55Z
|
CONTRIBUTOR
|
resolved
|
When a PreparedRequests's cookie jar is not a RequestsCookieJar instance, it
will not have a "copy" method. By adding _copy_cookie_jar we can reliably copy
cookie jars so that we have an actual copy instead of the same instance on
different prepared requests.
This also updates the RequestsCookieJar.update logic to create copies of
cookies from the other jar.
Closes #2527
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2534/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2534/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2534.diff",
"html_url": "https://github.com/psf/requests/pull/2534",
"merged_at": "2015-04-06T11:15:55Z",
"patch_url": "https://github.com/psf/requests/pull/2534.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2534"
}
| true |
[
"LGTM. :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/2533
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2533/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2533/comments
|
https://api.github.com/repos/psf/requests/issues/2533/events
|
https://github.com/psf/requests/pull/2533
| 66,505,832 |
MDExOlB1bGxSZXF1ZXN0MzI2NTgzOTA=
| 2,533 |
Place VendorAlias first in meta_path
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
[] |
closed
| true |
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
[
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
] | null | 0 |
2015-04-06T01:57:05Z
|
2021-09-08T08:00:54Z
|
2015-04-06T11:19:15Z
|
CONTRIBUTOR
|
resolved
|
When other libraries or tools add items to the meta_path, we need to preempt
some of their import hooks to be sure modules can be properly found. This also
prevents problems importing built-in modules on Python 2 where it will first
attempt to import something like:
```
requests.packages.chardet.sys
```
By placing our VendorAlias first, the above will fail and then it will fall
back to trying to import sys directly instead.
Closes #2465
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2533/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2533/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2533.diff",
"html_url": "https://github.com/psf/requests/pull/2533",
"merged_at": "2015-04-06T11:19:15Z",
"patch_url": "https://github.com/psf/requests/pull/2533.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2533"
}
| true |
[] |
https://api.github.com/repos/psf/requests/issues/2532
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2532/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2532/comments
|
https://api.github.com/repos/psf/requests/issues/2532/events
|
https://github.com/psf/requests/issues/2532
| 66,505,311 |
MDU6SXNzdWU2NjUwNTMxMQ==
| 2,532 |
"PreparedRequest.prepare_cookies" can only be called once (and "succeeds" silently if called again)
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/354181?v=4",
"events_url": "https://api.github.com/users/smiley/events{/privacy}",
"followers_url": "https://api.github.com/users/smiley/followers",
"following_url": "https://api.github.com/users/smiley/following{/other_user}",
"gists_url": "https://api.github.com/users/smiley/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/smiley",
"id": 354181,
"login": "smiley",
"node_id": "MDQ6VXNlcjM1NDE4MQ==",
"organizations_url": "https://api.github.com/users/smiley/orgs",
"received_events_url": "https://api.github.com/users/smiley/received_events",
"repos_url": "https://api.github.com/users/smiley/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/smiley/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/smiley/subscriptions",
"type": "User",
"url": "https://api.github.com/users/smiley",
"user_view_type": "public"
}
|
[
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"name": "Contributor Friendly",
"node_id": "MDU6TGFiZWwxOTEyNzQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Contributor%20Friendly"
},
{
"color": "fad8c7",
"default": false,
"description": null,
"id": 136616769,
"name": "Documentation",
"node_id": "MDU6TGFiZWwxMzY2MTY3Njk=",
"url": "https://api.github.com/repos/psf/requests/labels/Documentation"
}
] |
closed
| true | null |
[] | null | 8 |
2015-04-06T01:49:17Z
|
2021-09-08T23:05:47Z
|
2015-04-06T23:19:25Z
|
CONTRIBUTOR
|
resolved
|
I'm writing an adapter that interfaces with a CDN, and it requires that I "sign" my requests with a cookie, but it doesn't send the cookie back in `Set-Cookie`.
I manage to send it on the first request, but then the site behind the CDN _does_ send a `Set-Cookie` header (this is expected), and `prepare_cookies` called by the `Session` works its magic. The problem is, due to how `cookielib` is written, if a `Cookie` header was already composed, it won't be re-composed: (Even if cookies have changed between calls)
``` python
# cookielib.py:CookieJar.add_cookie_header (starts at 1312)
# ...
attrs = self._cookie_attrs(cookies)
if attrs:
if not request.has_header("Cookie"):
request.add_unredirected_header(
"Cookie", "; ".join(attrs))
#...
```
This causes a problem when any request past the first one on the same `Session` object renders my adapter worthless, as authentication fails and attempts to properly add cookies fail silently:
``` python
def _prepare_request(self, request):
"""
:type request: requests.PreparedRequest
"""
request.prepare_cookies({self.COOKIE_NAME: self._get_authorization_cookie(request.url)})
```
`request._cookies` is modified properly, but `request.headers['Cookie']` is still its former self.
If fixing this isn't possible (it _is_ a bundled library after all), maybe `requests` could delete the header before calling `CookieJar.add_cookie_header`?
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2532/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2532/timeline
| null |
completed
| null | null | false |
[
"> If fixing this isn't possible (it is a bundled library after all), maybe requests could delete the header before calling CookieJar.add_cookie_header?\n\nI assume this is happening because of [this line](https://github.com/kennethreitz/requests/blob/master/requests/models.py#L511). And that's why you quoted code from `cookielib` a standard library. You want us to somehow patch the standard library locally?\n\nHere's an alternative fix: Why aren't you constructing a new request, and preparing it with the new cookie header instead of trying to reuse an old prepared request?\n",
"No, I'm suggesting that you _can_ report the issue to the people developing `cookielib` (to get this fixed or documented in future Python releases), and do one of these things:\n1. Reject any future calls to `prepare_cookies` (have a local boolean for marking this was already called?)\n2. Merge an existing `self._cookies` value with the new one you're creating, clear `self.headers['Cookie']` and call the correct prepare function in `cookielib`, forcing it to re-generate the header\n3. Allow adapters to receive `Request` objects before they become `PreparedRequest` objects, so they could modify them correctly.\n\nIf you choose (1), you'll have to provide another way for an adapter to change cookies in a request.\n\nAnd I'm not constructing a new request, because as an adapter I get a `PreparedRequest` and (I think) am expected to pass it on.\n\n**EDIT:** I think (2) is the best option, since it's transparent and requires no public interface changes. I can make that change & open a PR if you agree.\n",
"> I'm suggesting that you can report the issue to the people developing cookielib (to get this fixed or documented in future Python releases)\n\nWhy aren't _you_ reporting it to them? bugs.python.org accepts reports from everyone, and you're the first person I've found to encounter this particular problem. As you're the person with the main interest in seeing it fixed, _you_ should be reporting it.\n\n> Reject any future calls to prepare_cookies (have a local boolean for marking this was already called?)\n\nI would rather document the fact of this behaviour than break a behaviour (by introducing an exception) that people may be expecting to just work.\n\n> Merge an existing self._cookies value with the new one you're creating, clear self.headers['Cookie'] and call the correct prepare function in cookielib, forcing it to re-generate the header\n\nAgain, this is backwards incompatible. I suspect it's potentially desirable, but given the fact that we follow SemVer, it isn't plausible until 3.0.0. That said, _you_ could just as easily do:\n\n``` py\nprepared_request.headers.pop('Cookie', None) # To delete it unconditionally\nprepared_request.prepare_cookies(...)\n```\n\nIn your adapter.\n\n> Allow adapters to receive Request objects before they become PreparedRequest objects, so they could modify them correctly.\n\nThat doesn't fit the workflow that we have had established for 2 major cycles and which no one else has had an issue with. The current flow fits the abstraction well. Adapters are not there to prepare requests but instead to handle requests which are ready to be made. If adapters decide to modify a prepared request, that's fine.\n\n> And I'm not constructing a new request, because as an adapter I get a PreparedRequest and (I think) am expected to pass it on.\n\nI don't quite fully understand your use case because, quite frankly, I've never seen someone use transport adapters this way. That said, since you're already toying with the prepared request, you may as well just do what I already described above (destroy the existing Cookie header, and regenerate it).\n\nNothing should blow up if you do that. It will also cover all the existing versions of Python that have the existing cookielib logic in it (and any future version that may potentially not have that logic).\n",
"> Why aren't _you_ reporting it to them? bugs.python.org accepts reports from everyone, and you're the first person I've found to encounter this particular problem. As you're the person with the main interest in seeing it fixed, _you_ should be reporting it.\n\nI didn't know bugs.python.org accepted bug reports for `cookielib`, and frankly, I was searching around for the main repository for it, but couldn't find it. Since requests is so widely-used & well-established, I assumed you found bugs before and reported them directly to the developer, so you might know who that is.\n\n> Again, this is backwards incompatible. [...]\n\nIt'd break a quirk that prevented a potential feature from ever working. (having more than one module -- not just adapters -- call `prepare_cookies` with required cookies)\n\n> [...] That said, _you_ could just as easily do: [...]\n\nThat would break any existing cookies, like a session ID used by the website served by the CDN.\n\n> I don't quite fully understand your use case because, quite frankly, I've never seen someone use transport adapters this way. That said, since you're already toying with the prepared request, you may as well just do what I already described above (destroy the existing Cookie header, and regenerate it).\n\nI'm essentially implementing [anorov/cloudflare-scrape](https://github.com/Anorov/cloudflare-scrape) for a different CDN. That said, he recreates a `Request` object from the given `PreparedRequest` semi-manually. Right now I'm working around this like so:\n\n``` python\ndef _add_auth_cookie(self, request):\n auth_cookie = self._get_authorization_cookie(request.url)\n\n if 'Cookie' in request.headers:\n old_cookies = request.headers['Cookie']\n all_cookies = '; '.join([old_cookies, \"{0}={1}\".format(self.COOKIE_NAME, auth_cookie)])\n request.headers['Cookie'] = all_cookies\n else:\n request.prepare_cookies({self.COOKIE_NAME: auth_cookie})\n```\n\nBut fine, I'll continue using my workaround. At the very least you should document this in `prepare_cookies`' docstring. It's the _only_ \"prepare_[...]\" method that can only be called _once_ and it's not clear at all.\n",
"I assume you're talking about [this method](https://github.com/Anorov/cloudflare-scrape/blob/master/cfscrape/__init__.py#L42) in @Anorov's project. If you're doing something similar to that, I'm confused as to why you're re-using the request. You're making an entirely new request and since you're taking control at the adapter level, this is a concession you have to make.\n\nThat said, any updates to the documentation are welcome.\n",
"I'm making a separate new request to the CDN itself to authenticate, and then I'm using that cookie on all of my future requests. The problem here is that at no point is the cookie set by an HTTP request, but by local JS.\n",
"I have no remarks about `prepare_cookies` specifically, however...\n\nGenerally speaking, I found the adapter API for sessions and cookie handling difficult to work with, as you can tell by some of the odd things I'm doing in my own code. Using the private-sounding `_cookies` attribute feels icky, and having to pass the cookie from the first response so I can artificially merge it into the headers of the second response (rather than a simple `self.cookies.set(...)` or the like) is irritating.\n\nThere seem to be some disconnects between the adapter API and the concept of a Requests session (or even just an HTTP session). It's very possible such a connection was never intended in the first place, but it is frustrating nonetheless. If there is a way of refactoring my code to make it more idiomatic I would greatly appreciate any suggestions and advice.\n\n@smiley I might be interested in merging this functionality into cloudflare-scrape. I assume this is for a competing CDN like Incapsula. Feel free to email me.\n",
"Yeah, I wasn't really going to bring up the fact that adapters aren't the right place for this logic. That said, I didn't take very much time to try to understand what you were doing with the code, so giving you a way to refactor it isn't quite possible for me at the moment. I would suspect that subclassing a session would be much cleaner and simpler for you, especially since I noticed that you're calling `requests.get` at one point inside an adapter method.\n\nThat aside, I'd be happy to discuss this on an issue on cloudflare-scrape or via email. This issue, I believe, can be closed.\n"
] |
https://api.github.com/repos/psf/requests/issues/2531
|
https://api.github.com/repos/psf/requests
|
https://api.github.com/repos/psf/requests/issues/2531/labels{/name}
|
https://api.github.com/repos/psf/requests/issues/2531/comments
|
https://api.github.com/repos/psf/requests/issues/2531/events
|
https://github.com/psf/requests/pull/2531
| 66,484,648 |
MDExOlB1bGxSZXF1ZXN0MzI2NTQ3ODY=
| 2,531 |
Issue 2062: Updated custom header precedence info with .netrc example
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/4780134?v=4",
"events_url": "https://api.github.com/users/benjaminran/events{/privacy}",
"followers_url": "https://api.github.com/users/benjaminran/followers",
"following_url": "https://api.github.com/users/benjaminran/following{/other_user}",
"gists_url": "https://api.github.com/users/benjaminran/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/benjaminran",
"id": 4780134,
"login": "benjaminran",
"node_id": "MDQ6VXNlcjQ3ODAxMzQ=",
"organizations_url": "https://api.github.com/users/benjaminran/orgs",
"received_events_url": "https://api.github.com/users/benjaminran/received_events",
"repos_url": "https://api.github.com/users/benjaminran/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/benjaminran/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/benjaminran/subscriptions",
"type": "User",
"url": "https://api.github.com/users/benjaminran",
"user_view_type": "public"
}
|
[] |
closed
| true | null |
[] | null | 1 |
2015-04-05T21:34:04Z
|
2021-09-08T08:00:52Z
|
2015-04-05T22:33:29Z
|
CONTRIBUTOR
|
resolved
|
I revised the custom header documentation to include .netrc authentication like Ian recommended.
|
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
}
|
{
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2531/reactions"
}
|
https://api.github.com/repos/psf/requests/issues/2531/timeline
| null | null | false |
{
"diff_url": "https://github.com/psf/requests/pull/2531.diff",
"html_url": "https://github.com/psf/requests/pull/2531",
"merged_at": "2015-04-05T22:33:29Z",
"patch_url": "https://github.com/psf/requests/pull/2531.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2531"
}
| true |
[
"\\o/ :sparkles:\n"
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.