input
stringlengths
205
73.3k
output
stringlengths
64
73.2k
instruction
stringclasses
1 value
#vulnerable code protected void checkProviderInfo(ProviderGroup providerGroup) { List<ProviderInfo> providerInfos = providerGroup == null ? null : providerGroup.getProviderInfos(); if (CommonUtils.isEmpty(providerInfos)) { return; } Iterator<ProviderInfo> iterator = providerInfos.iterator(); while (iterator.hasNext()) { ProviderInfo providerInfo = iterator.next(); if (!StringUtils.equals(providerInfo.getProtocolType(), consumerConfig.getProtocol())) { if (LOGGER.isWarnEnabled(consumerConfig.getAppName())) { LOGGER.warnWithApp(consumerConfig.getAppName(), "Unmatched protocol between consumer [{}] and provider [{}].", consumerConfig.getProtocol(), providerInfo.getProtocolType()); } } if (StringUtils.isEmpty(providerInfo.getSerializationType())) { providerInfo.setSerializationType(consumerConfig.getSerialization()); } } } #location 17 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code protected void checkProviderInfo(ProviderGroup providerGroup) { List<ProviderInfo> providerInfos = providerGroup == null ? null : providerGroup.getProviderInfos(); if (CommonUtils.isEmpty(providerInfos)) { return; } Iterator<ProviderInfo> iterator = providerInfos.iterator(); while (iterator.hasNext()) { ProviderInfo providerInfo = iterator.next(); if (!StringUtils.equals(providerInfo.getProtocolType(), consumerConfig.getProtocol())) { if (LOGGER.isWarnEnabled(consumerConfig.getAppName())) { LOGGER.warnWithApp(consumerConfig.getAppName(), "Unmatched protocol between consumer [{}] and provider [{}].", consumerConfig.getProtocol(), providerInfo.getProtocolType()); } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Test public void testAll() throws Exception { int timeoutPerSub = 1000; ServerConfig serverConfig = new ServerConfig() .setProtocol("bolt") .setHost("0.0.0.0") .setPort(12200); ProviderConfig<?> provider = new ProviderConfig(); provider.setInterfaceId("com.alipay.xxx.TestService") .setUniqueId("unique123Id") .setApplication(new ApplicationConfig().setAppName("test-server")) .setProxy("javassist") .setRegister(true) .setRegistry(registryConfig) .setSerialization("hessian2") .setServer(serverConfig) .setWeight(222) .setTimeout(3000); // 注册 registry.register(provider); ConsumerConfig<?> consumer = new ConsumerConfig(); consumer.setInterfaceId("com.alipay.xxx.TestService") .setUniqueId("unique123Id") .setApplication(new ApplicationConfig().setAppName("test-server")) .setProxy("javassist") .setSubscribe(true) .setSerialization("java") .setInvokeType("sync") .setTimeout(4444); String tag0 = MeshRegistryHelper.buildMeshKey(provider, serverConfig.getProtocol()); String tag1 = MeshRegistryHelper.buildMeshKey(consumer, consumer.getProtocol()); Assert.assertEquals(tag1, tag0); // 订阅 MeshRegistryTest.MockProviderInfoListener providerInfoListener = new MeshRegistryTest.MockProviderInfoListener(); consumer.setProviderInfoListener(providerInfoListener); List<ProviderGroup> groups = registry.subscribe(consumer); providerInfoListener.updateAllProviders(groups); Map<String, ProviderGroup> ps = providerInfoListener.getData(); Assert.assertTrue(ps.size() == 1); // 反注册 CountDownLatch latch = new CountDownLatch(1); providerInfoListener.setCountDownLatch(latch); registry.unRegister(provider); latch.await(timeoutPerSub, TimeUnit.MILLISECONDS); //mesh 并不直接感知. Assert.assertTrue(ps.size() == 1); // 一次发2个端口的再次注册 latch = new CountDownLatch(1); providerInfoListener.setCountDownLatch(latch); provider.getServer().add(new ServerConfig() .setProtocol("bolt") .setHost("0.0.0.0") .setPort(12201)); registry.register(provider); latch.await(timeoutPerSub * 2, TimeUnit.MILLISECONDS); // 重复订阅 ConsumerConfig<?> consumer2 = new ConsumerConfig(); consumer2.setInterfaceId("com.alipay.xxx.TestService") .setUniqueId("unique123Id") .setApplication(new ApplicationConfig().setAppName("test-server")) .setProxy("javassist") .setSubscribe(true) .setSerialization("java") .setInvokeType("sync") .setTimeout(4444); CountDownLatch latch2 = new CountDownLatch(1); MeshRegistryTest.MockProviderInfoListener providerInfoListener2 = new MeshRegistryTest.MockProviderInfoListener(); providerInfoListener2.setCountDownLatch(latch2); consumer2.setProviderInfoListener(providerInfoListener2); List<ProviderGroup> groups2 = registry.subscribe(consumer2); providerInfoListener2.updateAllProviders(groups2); Map<String, ProviderGroup> ps2 = providerInfoListener2.getData(); Assert.assertTrue(ps2.size() == 1); // 取消订阅者1 registry.unSubscribe(consumer); // 批量反注册,判断订阅者2的数据 latch = new CountDownLatch(1); providerInfoListener2.setCountDownLatch(latch); List<ProviderConfig> providerConfigList = new ArrayList<ProviderConfig>(); providerConfigList.add(provider); registry.batchUnRegister(providerConfigList); latch.await(timeoutPerSub, TimeUnit.MILLISECONDS); Assert.assertTrue(ps2.size() == 1); // 批量取消订阅 List<ConsumerConfig> consumerConfigList = new ArrayList<ConsumerConfig>(); consumerConfigList.add(consumer2); registry.batchUnSubscribe(consumerConfigList); } #location 44 #vulnerability type NULL_DEREFERENCE
#fixed code @Test public void testAll() throws Exception { int timeoutPerSub = 1000; ServerConfig serverConfig = new ServerConfig() .setProtocol("bolt") .setHost("0.0.0.0") .setPort(12200); ProviderConfig<?> provider = new ProviderConfig(); provider.setInterfaceId("com.alipay.xxx.TestService") .setUniqueId("unique123Id") .setApplication(new ApplicationConfig().setAppName("test-server")) .setProxy("javassist") .setRegister(true) .setRegistry(registryConfig) .setSerialization("hessian2") .setServer(serverConfig) .setWeight(222) .setTimeout(3000); // 注册 registry.register(provider); ConsumerConfig<?> consumer = new ConsumerConfig(); consumer.setInterfaceId("com.alipay.xxx.TestService") .setUniqueId("unique123Id") .setApplication(new ApplicationConfig().setAppName("test-server")) .setProxy("javassist") .setSubscribe(true) .setSerialization("java") .setInvokeType("sync") .setTimeout(4444); String tag0 = MeshRegistryHelper.buildMeshKey(provider, serverConfig.getProtocol()); String tag1 = MeshRegistryHelper.buildMeshKey(consumer, consumer.getProtocol()); Assert.assertEquals(tag1, tag0); // 订阅 MeshRegistryTest.MockProviderInfoListener providerInfoListener = new MeshRegistryTest.MockProviderInfoListener(); consumer.setProviderInfoListener(providerInfoListener); List<ProviderGroup> groups = registry.subscribe(consumer); Assert.assertNull(groups); Thread.sleep(3000); Map<String, ProviderGroup> ps = providerInfoListener.getData(); Assert.assertTrue(ps.size() == 1); // 反注册 CountDownLatch latch = new CountDownLatch(1); providerInfoListener.setCountDownLatch(latch); registry.unRegister(provider); latch.await(timeoutPerSub, TimeUnit.MILLISECONDS); //mesh 并不直接感知. Assert.assertTrue(ps.size() == 1); // 一次发2个端口的再次注册 latch = new CountDownLatch(1); providerInfoListener.setCountDownLatch(latch); provider.getServer().add(new ServerConfig() .setProtocol("bolt") .setHost("0.0.0.0") .setPort(12201)); registry.register(provider); latch.await(timeoutPerSub * 2, TimeUnit.MILLISECONDS); // 重复订阅 ConsumerConfig<?> consumer2 = new ConsumerConfig(); consumer2.setInterfaceId("com.alipay.xxx.TestService") .setUniqueId("unique123Id") .setApplication(new ApplicationConfig().setAppName("test-server")) .setProxy("javassist") .setSubscribe(true) .setSerialization("java") .setInvokeType("sync") .setTimeout(4444); CountDownLatch latch2 = new CountDownLatch(1); MeshRegistryTest.MockProviderInfoListener providerInfoListener2 = new MeshRegistryTest.MockProviderInfoListener(); providerInfoListener2.setCountDownLatch(latch2); consumer2.setProviderInfoListener(providerInfoListener2); List<ProviderGroup> groups2 = registry.subscribe(consumer2); Assert.assertNull(groups); Thread.sleep(3000); Map<String, ProviderGroup> ps2 = providerInfoListener2.getData(); Assert.assertTrue(ps2.size() == 1); // 取消订阅者1 registry.unSubscribe(consumer); // 批量反注册,判断订阅者2的数据 latch = new CountDownLatch(1); providerInfoListener2.setCountDownLatch(latch); List<ProviderConfig> providerConfigList = new ArrayList<ProviderConfig>(); providerConfigList.add(provider); registry.batchUnRegister(providerConfigList); latch.await(timeoutPerSub, TimeUnit.MILLISECONDS); Assert.assertTrue(ps2.size() == 1); // 批量取消订阅 List<ConsumerConfig> consumerConfigList = new ArrayList<ConsumerConfig>(); consumerConfigList.add(consumer2); registry.batchUnSubscribe(consumerConfigList); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void destroy() { stop(); } #location 3 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public void destroy() { stop(); httpServer = null; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override protected Object getFallback() { events.add(SofaAsyncHystrixEvent.FALLBACK_EMIT); if (lock.getCount() > 0) { // > 0 说明 run 方法没有执行,或是执行时立刻失败了 this.sofaResponse = buildEmptyResponse(request); lock.countDown(); events.add(SofaAsyncHystrixEvent.FALLBACK_UNLOCKED); } FallbackFactory fallbackFactory = SofaHystrixConfig.loadFallbackFactory((ConsumerConfig) invoker.getConfig()); if (fallbackFactory == null) { return super.getFallback(); } Object fallback = fallbackFactory.create(null, this.getExecutionException()); if (fallback == null) { return super.getFallback(); } try { return request.getMethod().invoke(fallback, request.getMethodArgs()); } catch (IllegalAccessException e) { throw new SofaRpcRuntimeException("Hystrix fallback method failed to execute.", e); } catch (InvocationTargetException e) { throw new SofaRpcRuntimeException("Hystrix fallback method failed to execute.", e.getTargetException()); } finally { events.add(SofaAsyncHystrixEvent.FALLBACK_SUCCESS); } } #location 19 #vulnerability type NULL_DEREFERENCE
#fixed code @Override protected Object getFallback() { events.add(SofaAsyncHystrixEvent.FALLBACK_EMIT); if (lock.getCount() > 0) { // > 0 说明 run 方法没有执行,或是执行时立刻失败了 this.sofaResponse = buildEmptyResponse(request); lock.countDown(); events.add(SofaAsyncHystrixEvent.FALLBACK_UNLOCKED); } FallbackFactory fallbackFactory = SofaHystrixConfig.loadFallbackFactory((ConsumerConfig) invoker.getConfig()); if (fallbackFactory == null) { return super.getFallback(); } Object fallback = fallbackFactory.create(new FallbackContext(invoker, request, this.sofaResponse, this .getExecutionException())); if (fallback == null) { return super.getFallback(); } try { return request.getMethod().invoke(fallback, request.getMethodArgs()); } catch (IllegalAccessException e) { throw new SofaRpcRuntimeException("Hystrix fallback method failed to execute.", e); } catch (InvocationTargetException e) { throw new SofaRpcRuntimeException("Hystrix fallback method failed to execute.", e.getTargetException()); } finally { events.add(SofaAsyncHystrixEvent.FALLBACK_SUCCESS); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void stop() { if (!started) { return; } try { // 关闭端口,不关闭线程池 if (LOGGER.isInfoEnabled()) { LOGGER.info("Stop the http rest server at port {}", serverConfig.getPort()); } httpServer.stop(); httpServer = null; } catch (Exception e) { LOGGER.error("Stop the http rest server at port " + serverConfig.getPort() + " error !", e); } started = false; } #location 12 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public void stop() { if (!started) { return; } try { // 关闭端口,不关闭线程池 if (LOGGER.isInfoEnabled()) { LOGGER.info("Stop the http rest server at port {}", serverConfig.getPort()); } httpServer.stop(); } catch (Exception e) { LOGGER.error("Stop the http rest server at port " + serverConfig.getPort() + " error !", e); } started = false; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public List<ProviderGroup> subscribe(final ConsumerConfig config) { String appName = config.getAppName(); if (!registryConfig.isSubscribe()) { // 注册中心不订阅 if (LOGGER.isInfoEnabled(appName)) { LOGGER.infoWithApp(appName, LogCodes.getLog(LogCodes.INFO_REGISTRY_IGNORE)); } return null; } // 注册Consumer节点 if (config.isRegister()) { try { String consumerPath = buildConsumerPath(rootPath, config); String url = ZookeeperRegistryHelper.convertConsumerToUrl(config); String encodeUrl = URLEncoder.encode(url, "UTF-8"); getAndCheckZkClient().create().creatingParentContainersIfNeeded() .withMode(CreateMode.EPHEMERAL) // Consumer临时节点 .forPath(consumerPath + CONTEXT_SEP + encodeUrl); consumerUrls.put(config, url); } catch (Exception e) { throw new SofaRpcRuntimeException("Failed to register consumer to zookeeperRegistry!", e); } } if (config.isSubscribe()) { // 订阅配置 if (!INTERFACE_CONFIG_CACHE.containsKey(buildConfigPath(rootPath, config))) { //订阅接口级配置 subscribeConfig(config, config.getConfigListener()); } if (!INTERFACE_OVERRIDE_CACHE.containsKey(buildOverridePath(rootPath, config))) { //订阅IP级配置 subscribeOverride(config, config.getConfigListener()); } // 订阅Providers节点 try { if (providerObserver == null) { // 初始化 providerObserver = new ZookeeperProviderObserver(); } final String providerPath = buildProviderPath(rootPath, config); if (LOGGER.isInfoEnabled(appName)) { LOGGER.infoWithApp(appName, LogCodes.getLog(LogCodes.INFO_ROUTE_REGISTRY_SUB, providerPath)); } // 监听配置节点下 子节点增加、子节点删除、子节点Data修改事件 ProviderInfoListener providerInfoListener = config.getProviderInfoListener(); providerObserver.addProviderListener(config, providerInfoListener); // TODO 换成监听父节点变化(只是监听变化了,而不通知变化了什么,然后客户端自己来拉数据的) PathChildrenCache pathChildrenCache = new PathChildrenCache(zkClient, providerPath, true); pathChildrenCache.getListenable().addListener(new PathChildrenCacheListener() { @Override public void childEvent(CuratorFramework client1, PathChildrenCacheEvent event) throws Exception { if (LOGGER.isDebugEnabled(config.getAppName())) { LOGGER.debugWithApp(config.getAppName(), "Receive zookeeper event: " + "type=[" + event.getType() + "]"); } switch (event.getType()) { case CHILD_ADDED: //加了一个provider providerObserver.addProvider(config, providerPath, event.getData()); break; case CHILD_REMOVED: //删了一个provider providerObserver.removeProvider(config, providerPath, event.getData()); break; case CHILD_UPDATED: // 更新一个Provider providerObserver.updateProvider(config, providerPath, event.getData()); break; default: break; } } }); pathChildrenCache.start(PathChildrenCache.StartMode.BUILD_INITIAL_CACHE); List<ProviderInfo> providerInfos = ZookeeperRegistryHelper.convertUrlsToProviders( providerPath, pathChildrenCache.getCurrentData()); List<ProviderInfo> matchProviders = ZookeeperRegistryHelper.matchProviderInfos(config, providerInfos); return Collections.singletonList(new ProviderGroup().addAll(matchProviders)); } catch (Exception e) { throw new SofaRpcRuntimeException("Failed to subscribe provider from zookeeperRegistry!", e); } } return null; } #location 74 #vulnerability type RESOURCE_LEAK
#fixed code @Override public List<ProviderGroup> subscribe(final ConsumerConfig config) { String appName = config.getAppName(); if (!registryConfig.isSubscribe()) { // 注册中心不订阅 if (LOGGER.isInfoEnabled(appName)) { LOGGER.infoWithApp(appName, LogCodes.getLog(LogCodes.INFO_REGISTRY_IGNORE)); } return null; } // 注册Consumer节点 if (config.isRegister()) { try { String consumerPath = buildConsumerPath(rootPath, config); String url = ZookeeperRegistryHelper.convertConsumerToUrl(config); String encodeUrl = URLEncoder.encode(url, "UTF-8"); getAndCheckZkClient().create().creatingParentContainersIfNeeded() .withMode(CreateMode.EPHEMERAL) // Consumer临时节点 .forPath(consumerPath + CONTEXT_SEP + encodeUrl); consumerUrls.put(config, url); } catch (Exception e) { throw new SofaRpcRuntimeException("Failed to register consumer to zookeeperRegistry!", e); } } if (config.isSubscribe()) { // 订阅配置 if (!INTERFACE_CONFIG_CACHE.containsKey(buildConfigPath(rootPath, config))) { //订阅接口级配置 subscribeConfig(config, config.getConfigListener()); } if (!INTERFACE_OVERRIDE_CACHE.containsKey(buildOverridePath(rootPath, config))) { //订阅IP级配置 subscribeOverride(config, config.getConfigListener()); } // 订阅Providers节点 try { if (providerObserver == null) { // 初始化 providerObserver = new ZookeeperProviderObserver(); } final String providerPath = buildProviderPath(rootPath, config); if (LOGGER.isInfoEnabled(appName)) { LOGGER.infoWithApp(appName, LogCodes.getLog(LogCodes.INFO_ROUTE_REGISTRY_SUB, providerPath)); } PathChildrenCache pathChildrenCache = INTERFACE_PROVIDER_CACHE.get(config); if (pathChildrenCache == null) { // 监听配置节点下 子节点增加、子节点删除、子节点Data修改事件 ProviderInfoListener providerInfoListener = config.getProviderInfoListener(); providerObserver.addProviderListener(config, providerInfoListener); // TODO 换成监听父节点变化(只是监听变化了,而不通知变化了什么,然后客户端自己来拉数据的) pathChildrenCache = new PathChildrenCache(zkClient, providerPath, true); final PathChildrenCache finalPathChildrenCache = pathChildrenCache; pathChildrenCache.getListenable().addListener(new PathChildrenCacheListener() { @Override public void childEvent(CuratorFramework client1, PathChildrenCacheEvent event) throws Exception { if (LOGGER.isDebugEnabled(config.getAppName())) { LOGGER.debugWithApp(config.getAppName(), "Receive zookeeper event: " + "type=[" + event.getType() + "]"); } switch (event.getType()) { case CHILD_ADDED: //加了一个provider providerObserver.addProvider(config, providerPath, event.getData(), finalPathChildrenCache.getCurrentData()); break; case CHILD_REMOVED: //删了一个provider providerObserver.removeProvider(config, providerPath, event.getData(), finalPathChildrenCache.getCurrentData()); break; case CHILD_UPDATED: // 更新一个Provider providerObserver.updateProvider(config, providerPath, event.getData(), finalPathChildrenCache.getCurrentData()); break; default: break; } } }); pathChildrenCache.start(PathChildrenCache.StartMode.BUILD_INITIAL_CACHE); INTERFACE_PROVIDER_CACHE.put(config, pathChildrenCache); } List<ProviderInfo> providerInfos = ZookeeperRegistryHelper.convertUrlsToProviders( providerPath, pathChildrenCache.getCurrentData()); List<ProviderInfo> matchProviders = ZookeeperRegistryHelper.matchProviderInfos(config, providerInfos); return Collections.singletonList(new ProviderGroup().addAll(matchProviders)); } catch (Exception e) { throw new SofaRpcRuntimeException("Failed to subscribe provider from zookeeperRegistry!", e); } } return null; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void updateProviders(ProviderGroup providerGroup) { checkProviderInfo(providerGroup); ProviderGroup oldProviderGroup = addressHolder.getProviderGroup(providerGroup.getName()); if (ProviderHelper.isEmpty(providerGroup)) { addressHolder.updateProviders(providerGroup); if (CommonUtils.isNotEmpty(oldProviderGroup.getProviderInfos())) { if (LOGGER.isWarnEnabled(consumerConfig.getAppName())) { LOGGER.warnWithApp(consumerConfig.getAppName(), "Provider list is emptied, may be all " + "providers has been closed, or this consumer has been add to blacklist"); closeTransports(); } } } else { addressHolder.updateProviders(providerGroup); connectionHolder.updateProviders(providerGroup); } if (EventBus.isEnable(ProviderInfoUpdateEvent.class)) { ProviderInfoUpdateEvent event = new ProviderInfoUpdateEvent(consumerConfig, oldProviderGroup, providerGroup); EventBus.post(event); } } #location 3 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public void updateProviders(ProviderGroup providerGroup) { checkProviderInfo(providerGroup); ProviderGroup oldProviderGroup = addressHolder.getProviderGroup(providerGroup.getName()); if (ProviderHelper.isEmpty(providerGroup)) { addressHolder.updateProviders(providerGroup); if (!ProviderHelper.isEmpty(oldProviderGroup)) { if (LOGGER.isWarnEnabled(consumerConfig.getAppName())) { LOGGER.warnWithApp(consumerConfig.getAppName(), "Provider list is emptied, may be all " + "providers has been closed, or this consumer has been add to blacklist"); closeTransports(); } } } else { addressHolder.updateProviders(providerGroup); connectionHolder.updateProviders(providerGroup); } if (EventBus.isEnable(ProviderInfoUpdateEvent.class)) { ProviderInfoUpdateEvent event = new ProviderInfoUpdateEvent(consumerConfig, oldProviderGroup, providerGroup); EventBus.post(event); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); if ((greatestTimestamp - minTimestamp) > k) { if ((greatestTimestamp - minTimestamp) < MAX_K) { k = greatestTimestamp - minTimestamp; } else { k = MAX_K; } } lock.lock(); Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } lock.unlock(); } } else { onTimerEvent(expiredEventTreeMap, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } catch (ArrayIndexOutOfBoundsException ec) { // This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } nextProcessor.process(complexEventChunk); } #location 35 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); lock.lock(); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); long timeDifference = greatestTimestamp - minTimestamp; if (timeDifference > k) { if (timeDifference < MAX_K) { k = timeDifference; } else { k = MAX_K; } } Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } } } else { if(expiredEventTreeMap.size() > 0) { TreeMap<Long, ArrayList<StreamEvent>> expiredEventTreeMapSnapShot = expiredEventTreeMap; expiredEventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); onTimerEvent(expiredEventTreeMapSnapShot, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } } catch (ArrayIndexOutOfBoundsException ec) { //This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } lock.unlock(); nextProcessor.process(complexEventChunk); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static QueryRuntime parse(Query query, ExecutionPlanContext executionPlanContext, Map<String, AbstractDefinition> streamDefinitionMap, Map<String, AbstractDefinition> tableDefinitionMap, Map<String, EventTable> eventTableMap) { List<VariableExpressionExecutor> executors = new ArrayList<VariableExpressionExecutor>(); QueryRuntime queryRuntime; Element element = null; LatencyTracker latencyTracker = null; try { element = AnnotationHelper.getAnnotationElement("info", "name", query.getAnnotations()); if (executionPlanContext.getStatisticsManager()!=null) { if (element != null) { String metricName = executionPlanContext.getSiddhiContext().getStatisticsConfiguration().getMatricPrefix() + ".executionplan." + executionPlanContext.getName() + "." + element.getValue(); latencyTracker = executionPlanContext.getSiddhiContext() .getStatisticsConfiguration() .getFactory() .createLatencyTracker(metricName, executionPlanContext.getStatisticsManager()); } } StreamRuntime streamRuntime = InputStreamParser.parse(query.getInputStream(), executionPlanContext, streamDefinitionMap, tableDefinitionMap, eventTableMap, executors, latencyTracker); QuerySelector selector = SelectorParser.parse(query.getSelector(), query.getOutputStream(), executionPlanContext, streamRuntime.getMetaComplexEvent(), eventTableMap, executors); boolean isWindow = query.getInputStream() instanceof JoinInputStream; if (!isWindow && query.getInputStream() instanceof SingleInputStream) { for (StreamHandler streamHandler : ((SingleInputStream) query.getInputStream()).getStreamHandlers()) { if (streamHandler instanceof Window) { isWindow = true; break; } } } OutputRateLimiter outputRateLimiter = OutputParser.constructOutputRateLimiter(query.getOutputStream().getId(), query.getOutputRate(), query.getSelector().getGroupByList().size() != 0, isWindow, executionPlanContext.getScheduledExecutorService()); outputRateLimiter.init(executionPlanContext, latencyTracker); executionPlanContext.addEternalReferencedHolder(outputRateLimiter); OutputCallback outputCallback = OutputParser.constructOutputCallback(query.getOutputStream(), streamRuntime.getMetaComplexEvent().getOutputStreamDefinition(), eventTableMap, executionPlanContext); QueryParserHelper.reduceMetaComplexEvent(streamRuntime.getMetaComplexEvent()); QueryParserHelper.updateVariablePosition(streamRuntime.getMetaComplexEvent(), executors); QueryParserHelper.initStreamRuntime(streamRuntime, streamRuntime.getMetaComplexEvent()); selector.setEventPopulator(StateEventPopulatorFactory.constructEventPopulator(streamRuntime.getMetaComplexEvent())); queryRuntime = new QueryRuntime(query, executionPlanContext, streamRuntime, selector, outputRateLimiter, outputCallback, streamRuntime.getMetaComplexEvent()); if (outputRateLimiter instanceof WrappedSnapshotOutputRateLimiter) { ((WrappedSnapshotOutputRateLimiter) outputRateLimiter).init(streamRuntime.getMetaComplexEvent().getOutputStreamDefinition().getAttributeList().size(), selector.getAttributeProcessorList(), streamRuntime.getMetaComplexEvent()); } } catch (DuplicateDefinitionException e) { if (element != null) { throw new DuplicateDefinitionException(e.getMessage() + ", when creating query " + element.getValue(), e); } else { throw new DuplicateDefinitionException(e.getMessage(), e); } } catch (RuntimeException e) { if (element != null) { throw new ExecutionPlanCreationException(e.getMessage() + ", when creating query " + element.getValue(), e); } else { throw new ExecutionPlanCreationException(e.getMessage(), e); } } return queryRuntime; } #location 39 #vulnerability type NULL_DEREFERENCE
#fixed code public static QueryRuntime parse(Query query, ExecutionPlanContext executionPlanContext, Map<String, AbstractDefinition> streamDefinitionMap, Map<String, AbstractDefinition> tableDefinitionMap, Map<String, EventTable> eventTableMap) { List<VariableExpressionExecutor> executors = new ArrayList<VariableExpressionExecutor>(); QueryRuntime queryRuntime; Element element = null; LatencyTracker latencyTracker = null; try { element = AnnotationHelper.getAnnotationElement("info", "name", query.getAnnotations()); if (executionPlanContext.getStatisticsManager() != null) { if (element != null) { String metricName = executionPlanContext.getSiddhiContext().getStatisticsConfiguration().getMatricPrefix() + SiddhiConstants.METRIC_DELIMITER + SiddhiConstants.METRIC_INFIX_EXECUTION_PLANS + SiddhiConstants.METRIC_DELIMITER + executionPlanContext.getName() + SiddhiConstants.METRIC_DELIMITER + SiddhiConstants.METRIC_INFIX_SIDDHI + SiddhiConstants.METRIC_DELIMITER + SiddhiConstants.METRIC_INFIX_QUERIES + SiddhiConstants.METRIC_DELIMITER + element.getValue(); latencyTracker = executionPlanContext.getSiddhiContext() .getStatisticsConfiguration() .getFactory() .createLatencyTracker(metricName, executionPlanContext.getStatisticsManager()); } } StreamRuntime streamRuntime = InputStreamParser.parse(query.getInputStream(), executionPlanContext, streamDefinitionMap, tableDefinitionMap, eventTableMap, executors, latencyTracker); QuerySelector selector = SelectorParser.parse(query.getSelector(), query.getOutputStream(), executionPlanContext, streamRuntime.getMetaComplexEvent(), eventTableMap, executors); boolean isWindow = query.getInputStream() instanceof JoinInputStream; if (!isWindow && query.getInputStream() instanceof SingleInputStream) { for (StreamHandler streamHandler : ((SingleInputStream) query.getInputStream()).getStreamHandlers()) { if (streamHandler instanceof Window) { isWindow = true; break; } } } OutputRateLimiter outputRateLimiter = OutputParser.constructOutputRateLimiter(query.getOutputStream().getId(), query.getOutputRate(), query.getSelector().getGroupByList().size() != 0, isWindow, executionPlanContext.getScheduledExecutorService()); if (outputRateLimiter != null) { outputRateLimiter.init(executionPlanContext, latencyTracker); } executionPlanContext.addEternalReferencedHolder(outputRateLimiter); OutputCallback outputCallback = OutputParser.constructOutputCallback(query.getOutputStream(), streamRuntime.getMetaComplexEvent().getOutputStreamDefinition(), eventTableMap, executionPlanContext); QueryParserHelper.reduceMetaComplexEvent(streamRuntime.getMetaComplexEvent()); QueryParserHelper.updateVariablePosition(streamRuntime.getMetaComplexEvent(), executors); QueryParserHelper.initStreamRuntime(streamRuntime, streamRuntime.getMetaComplexEvent()); selector.setEventPopulator(StateEventPopulatorFactory.constructEventPopulator(streamRuntime.getMetaComplexEvent())); queryRuntime = new QueryRuntime(query, executionPlanContext, streamRuntime, selector, outputRateLimiter, outputCallback, streamRuntime.getMetaComplexEvent()); if (outputRateLimiter instanceof WrappedSnapshotOutputRateLimiter) { ((WrappedSnapshotOutputRateLimiter) outputRateLimiter) .init(streamRuntime.getMetaComplexEvent().getOutputStreamDefinition().getAttributeList().size(), selector.getAttributeProcessorList(), streamRuntime.getMetaComplexEvent()); } } catch (DuplicateDefinitionException e) { if (element != null) { throw new DuplicateDefinitionException(e.getMessage() + ", when creating query " + element.getValue(), e); } else { throw new DuplicateDefinitionException(e.getMessage(), e); } } catch (RuntimeException e) { if (element != null) { throw new ExecutionPlanCreationException(e.getMessage() + ", when creating query " + element.getValue(), e); } else { throw new ExecutionPlanCreationException(e.getMessage(), e); } } return queryRuntime; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Test public void testCreatingHttpSubscriptionXmlMapping() { Subscription subscription = Subscription.Subscribe( Transport.transport("http"). option("context", "/test"). option("transport", "http,https")); subscription.map(Mapper.mapper("xml"). map("/h:time"). map("data", "//h:data"). option("xmlns:h", "http://www.w3.org/TR/html4/")); subscription.insertInto("FooStream"); ExecutionPlan.executionPlan("test").addSubscription(subscription); } #location 10 #vulnerability type NULL_DEREFERENCE
#fixed code @Test public void testCreatingHttpSubscriptionXmlMapping() { Subscription subscription = Subscription.Subscribe( Transport.transport("http"). option("context", "/test"). option("transport", "http,https")); subscription.map(Mapping.format("xml"). map("/h:time"). map("data", "//h:data"). option("xmlns:h", "http://www.w3.org/TR/html4/")); subscription.insertInto("FooStream"); ExecutionPlan.executionPlan("test").addSubscription(subscription); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public void add(StreamEvent streamEvent){ StreamEvent firstConvertedEvent =null; StreamEvent lastConvertedEvent = null; while (streamEvent!=null){ StreamEvent borrowedEvent = eventManager.borrowEvent(); eventManager.convertStreamEvent(streamEvent, borrowedEvent); if(firstConvertedEvent ==null){ firstConvertedEvent = borrowedEvent; lastConvertedEvent = borrowedEvent; } else { lastConvertedEvent.setNext(borrowedEvent); } streamEvent = streamEvent.getNext(); } if(first==null){ first = firstConvertedEvent; } else if (lastReturned != null){ StreamEvent nextToLastReturned = lastReturned.getNext(); lastConvertedEvent.setNext(nextToLastReturned); lastReturned.setNext(firstConvertedEvent); } else { //when first!=null lastConvertedEvent.setNext(first); first = firstConvertedEvent; } } #location 19 #vulnerability type NULL_DEREFERENCE
#fixed code public void add(StreamEvent streamEvent){ StreamEvent borrowedEvent = eventManager.borrowEvent(); eventManager.convertStreamEvent(streamEvent, borrowedEvent); if(lastReturned!=null){ StreamEvent lastEvent = lastReturned; StreamEvent even= null; while (lastEvent!=null){ even = lastEvent; lastEvent = lastEvent.getNext(); } even.setNext(borrowedEvent); }else if(previousToLastReturned!=null){ previousToLastReturned.setNext(borrowedEvent); } else if (first != null){ StreamEvent lastEvent = first; StreamEvent even= null; while (lastEvent!=null){ even = lastEvent; lastEvent = lastEvent.getNext(); } even.setNext(borrowedEvent); } else { assignEvent(borrowedEvent); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static OutputCallback constructOutputCallback(OutputStream outStream, StreamDefinition outputStreamDefinition, ExecutionPlanContext executionPlanContext) { String id = outStream.getId(); //Construct CallBack if (outStream instanceof InsertIntoStream) { EventTable eventTable = executionPlanContext.getEventTableMap().get(id); if (eventTable != null) { DefinitionParserHelper.validateOutputStream(outputStreamDefinition, eventTable.getTableDefinition()); return new InsertIntoTableCallback(eventTable, outputStreamDefinition); } else { return new InsertIntoStreamCallback(outputStreamDefinition); } } else if (outStream instanceof DeleteStream) { EventTable eventTable = executionPlanContext.getEventTableMap().get(id); if (eventTable != null) { DefinitionParserHelper.validateOutputStream(outputStreamDefinition, eventTable.getTableDefinition()); MetaStreamEvent matchingMetaStreamEvent = new MetaStreamEvent(); matchingMetaStreamEvent.setTableEvent(true); TableDefinition tableDefinition = TableDefinition.id(""); for (Attribute attribute : outputStreamDefinition.getAttributeList()) { matchingMetaStreamEvent.addOutputData(attribute); tableDefinition.attribute(attribute.getName(), attribute.getType()); } matchingMetaStreamEvent.setInputDefinition(tableDefinition); Finder finder = eventTable.constructFinder(((DeleteStream) outStream).getOnDeleteExpression(), matchingMetaStreamEvent, executionPlanContext, null, 0); return new DeleteTableCallback(eventTable, finder); } else { throw new DefinitionNotExistException("Event table with id :" + id + " does not exist"); } } else if (outStream instanceof UpdateStream) { EventTable eventTable = executionPlanContext.getEventTableMap().get(id); if (eventTable != null) { DefinitionParserHelper.validateOutputStream(outputStreamDefinition, eventTable.getTableDefinition()); MetaStateEvent metaStateEvent = createMetaStateEvent(outputStreamDefinition, eventTable); Finder finder = eventTable.constructFinder(((UpdateStream) outStream).getOnUpdateExpression(), metaStateEvent, executionPlanContext, null, 0); return new UpdateTableCallback(eventTable, finder, outputStreamDefinition); } else { throw new DefinitionNotExistException("Event table with id :" + id + " does not exist"); } } else { throw new ExecutionPlanCreationException(outStream.getClass().getName() + " not supported"); } } #location 21 #vulnerability type NULL_DEREFERENCE
#fixed code public static OutputCallback constructOutputCallback(OutputStream outStream, StreamDefinition outputStreamDefinition, ExecutionPlanContext executionPlanContext) { String id = outStream.getId(); //Construct CallBack if (outStream instanceof InsertIntoStream) { EventTable eventTable = executionPlanContext.getEventTableMap().get(id); if (eventTable != null) { DefinitionParserHelper.validateOutputStream(outputStreamDefinition, eventTable.getTableDefinition()); return new InsertIntoTableCallback(eventTable, outputStreamDefinition); } else { return new InsertIntoStreamCallback(outputStreamDefinition); } } else if (outStream instanceof DeleteStream || outStream instanceof UpdateStream) { EventTable eventTable = executionPlanContext.getEventTableMap().get(id); if (eventTable != null) { TableDefinition eventTableDefinition = eventTable.getTableDefinition(); for (Attribute attribute : outputStreamDefinition.getAttributeList()) { if (!eventTableDefinition.getAttributeList().contains(attribute)) { throw new ExecutionPlanCreationException("Attribute " + attribute + " does not exist on Event Table " + eventTableDefinition); } } MetaStreamEvent matchingMetaStreamEvent = new MetaStreamEvent(); matchingMetaStreamEvent.setTableEvent(true); TableDefinition matchingTableDefinition = TableDefinition.id(""); for (Attribute attribute : outputStreamDefinition.getAttributeList()) { matchingMetaStreamEvent.addOutputData(attribute); matchingTableDefinition.attribute(attribute.getName(), attribute.getType()); } matchingMetaStreamEvent.setInputDefinition(matchingTableDefinition); if (outStream instanceof DeleteStream) { Finder finder = eventTable.constructFinder(((DeleteStream) outStream).getOnDeleteExpression(), matchingMetaStreamEvent, executionPlanContext, null, 0); return new DeleteTableCallback(eventTable, finder); } else { Finder finder = eventTable.constructFinder(((UpdateStream) outStream).getOnUpdateExpression(), matchingMetaStreamEvent, executionPlanContext, null, 0); return new UpdateTableCallback(eventTable, finder, matchingTableDefinition); } } else { throw new DefinitionNotExistException("Event table with id :" + id + " does not exist"); } } else { throw new ExecutionPlanCreationException(outStream.getClass().getName() + " not supported"); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void process(StreamEvent event) { StreamEvent head = event; //head of in events StreamEvent expiredEventTail; StreamEvent expiredEventHead; while (event != null) { processEvent(event); event = event.getNext(); } //if window is expired if (count > length) { int diff = count - length; expiredEventTail = removeEventHead; for (int i = 1; i < diff; i++) { expiredEventTail = expiredEventTail.getNext(); } expiredEventHead = removeEventHead; removeEventHead = expiredEventTail.getNext(); expiredEventTail.setNext(null); head.addToLast(expiredEventHead); nextProcessor.process(head); //emit in events and remove events as expired events count = count - diff; } else { nextProcessor.process(head); //emit only in events as window is not expired } } #location 15 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void process(StreamEvent event) { StreamEvent head = event; //head of in events StreamEvent expiredEventTail; StreamEvent expiredEventHead; while (event != null) { processEvent(event); event = event.getNext(); } //if window is expired if (count > length) { int diff = count - length; expiredEventTail = removeEventHead; for (int i = 1; i < diff; i++) { expiredEventTail = expiredEventTail.getNext(); } expiredEventHead = removeEventHead; removeEventHead = expiredEventTail.getNext(); expiredEventTail.setNext(null); addToLast(head, expiredEventHead); nextProcessor.process(head); //emit in events and remove events as expired events count = count - diff; } else { nextProcessor.process(head); //emit only in events as window is not expired } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void restoreState(Object[] state) { eventChunk = (ComplexEventChunk<ComplexEvent>) state[0]; endOfChunk = (Boolean) state[1]; } #location 4 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public void restoreState(Object[] state) { eventChunk = (ComplexEventChunk<ComplexEvent>) state[0]; //endOfChunk = (Boolean) state[1]; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLock.lock(); try { if (streamEvent.getType() == ComplexEvent.Type.TIMER) { if (preJoinProcessor) { complexEventChunk.add(streamEvent); nextProcessor.process(complexEventChunk); complexEventChunk.clear(); } continue; } else if (streamEvent.getType() == ComplexEvent.Type.CURRENT) { if (!preJoinProcessor) { continue; } } else if (streamEvent.getType() == ComplexEvent.Type.EXPIRED) { if (preJoinProcessor) { continue; } } else if (streamEvent.getType() == ComplexEvent.Type.RESET) { continue; } joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent)); } foundStreamEvent = foundStreamEvent.getNext(); } } if (preJoinProcessor) { complexEventChunk.add(streamEvent); nextProcessor.process(complexEventChunk); complexEventChunk.clear(); } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } else { if (preJoinProcessor) { joinLock.lock(); try { nextProcessor.process(complexEventChunk); } finally { joinLock.unlock(); } } } } #location 17 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLock.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER || eventType == ComplexEvent.Type.RESET) { continue; } joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLock.lock(); try { if (streamEvent.getType() == ComplexEvent.Type.TIMER) { if (preJoinProcessor) { complexEventChunk.add(streamEvent); nextProcessor.process(complexEventChunk); complexEventChunk.clear(); } continue; } else if (streamEvent.getType() == ComplexEvent.Type.CURRENT) { if (!preJoinProcessor) { continue; } } else if (streamEvent.getType() == ComplexEvent.Type.EXPIRED) { if (preJoinProcessor) { continue; } } else if (streamEvent.getType() == ComplexEvent.Type.RESET) { continue; } joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent)); } foundStreamEvent = foundStreamEvent.getNext(); } } if (preJoinProcessor) { complexEventChunk.add(streamEvent); nextProcessor.process(complexEventChunk); complexEventChunk.clear(); } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } else { if (preJoinProcessor) { joinLock.lock(); try { nextProcessor.process(complexEventChunk); } finally { joinLock.unlock(); } } } } #location 17 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLock.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER || eventType == ComplexEvent.Type.RESET) { continue; } joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private void populateMarkovMatrix(String markovMatrixStorageLocation) { File file = new File(markovMatrixStorageLocation); FileInputStream fileInputStream = null; BufferedInputStream bufferedInputStream = null; BufferedReader bufferedReader = null; String[] statesNames = null; String key; String startState; String endState; Map<String, Double> transitionCount = new HashMap<String, Double>(); Map<String, Double> startStateCount = new HashMap<String, Double>(); try { fileInputStream = new FileInputStream(file); bufferedInputStream = new BufferedInputStream(fileInputStream); bufferedReader = new BufferedReader(new InputStreamReader(bufferedInputStream)); int rowNumber = 0; String row = bufferedReader.readLine(); if (row != null) { statesNames = row.split(","); } while ((row = bufferedReader.readLine()) != null) { if (rowNumber >= statesNames.length) { throw new OperationNotSupportedException( "Number of rows in the matrix should be equal to number of states. please provide a " + statesNames.length + " x " + statesNames.length + " matrix"); } startState = statesNames[rowNumber]; String[] values = row.split(","); double totalCount = 0.0; if (values.length != statesNames.length) { throw new OperationNotSupportedException( "Number of columns in the matrix should be equal to number of states. please provide a " + statesNames.length + " x " + statesNames.length + " matrix"); } for (String value : values) { try { totalCount = totalCount + Double.parseDouble(value); } catch (NumberFormatException e) { log.error("Exception occurred while reading the data file " + markovMatrixStorageLocation + ". All values in the matrix should be in double", e); } } startStateCount.put(startState, totalCount); for (int j = 0; j < statesNames.length; j++) { endState = statesNames[j]; key = markovMatrix.getKey(startState, endState); transitionCount.put(key, Double.parseDouble(values[j])); } rowNumber++; } } catch (IOException e) { log.error("Exception occurred while reading the data file " + markovMatrixStorageLocation, e); } finally { closeQuietly(bufferedReader, bufferedInputStream, fileInputStream); } markovMatrix.setStartStateCount(startStateCount); markovMatrix.setTransitionCount(transitionCount); } #location 65 #vulnerability type NULL_DEREFERENCE
#fixed code private void populateMarkovMatrix(String markovMatrixStorageLocation) { File file = new File(markovMatrixStorageLocation); FileInputStream fileInputStream = null; BufferedInputStream bufferedInputStream = null; BufferedReader bufferedReader = null; String[] statesNames = null; String key; String startState; String endState; Map<String, Double> transitionCount = new HashMap<String, Double>(); Map<String, Double> startStateCount = new HashMap<String, Double>(); try { fileInputStream = new FileInputStream(file); bufferedInputStream = new BufferedInputStream(fileInputStream); bufferedReader = new BufferedReader(new InputStreamReader(bufferedInputStream)); int rowNumber = 0; String row = bufferedReader.readLine(); if (row != null) { statesNames = row.split(","); } while ((row = bufferedReader.readLine()) != null) { if (rowNumber >= statesNames.length) { throw new OperationNotSupportedException( "Number of rows in the matrix should be equal to number of states. please provide a " + statesNames.length + " x " + statesNames.length + " matrix."); } startState = statesNames[rowNumber]; String[] values = row.split(","); double totalCount = 0.0; if (values.length != statesNames.length) { throw new OperationNotSupportedException( "Number of columns in the matrix should be equal to number of states. please provide a " + statesNames.length + " x " + statesNames.length + " matrix."); } for (String value : values) { try { totalCount = totalCount + Double.parseDouble(value); } catch (NumberFormatException e) { log.error("Exception occurred while reading the data file: " + markovMatrixStorageLocation + ". All values in the matrix should be in double.", e); } } startStateCount.put(startState, totalCount); for (int j = 0; j < statesNames.length; j++) { endState = statesNames[j]; key = markovMatrix.getKey(startState, endState); transitionCount.put(key, Double.parseDouble(values[j])); } rowNumber++; } } catch (IOException e) { log.error("Exception occurred while reading the data file: " + markovMatrixStorageLocation, e); } finally { closedQuietly(markovMatrixStorageLocation, bufferedReader, bufferedInputStream, fileInputStream); } markovMatrix.setStartStateCount(startStateCount); markovMatrix.setTransitionCount(transitionCount); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); if (streamEvent.getType() == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, streamEvent.getType())); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, streamEvent.getType())); } selector.process(returnEventChunk); returnEventChunk.clear(); continue; } joinLock.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } } #location 37 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLock.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } else if (eventType == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, eventType)); } } else { joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } else { if (preJoinProcessor) { joinLock.lock(); try { nextProcessor.process(complexEventChunk); } finally { joinLock.unlock(); } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public void add(StreamEvent streamEvent){ StreamEvent firstConvertedEvent =null; StreamEvent lastConvertedEvent = null; while (streamEvent!=null){ StreamEvent borrowedEvent = eventManager.borrowEvent(); eventManager.convertStreamEvent(streamEvent, borrowedEvent); if(firstConvertedEvent ==null){ firstConvertedEvent = borrowedEvent; lastConvertedEvent = borrowedEvent; } else { lastConvertedEvent.setNext(borrowedEvent); } streamEvent = streamEvent.getNext(); } if(first==null){ first = firstConvertedEvent; } else if (lastReturned != null){ StreamEvent nextToLastReturned = lastReturned.getNext(); lastConvertedEvent.setNext(nextToLastReturned); lastReturned.setNext(firstConvertedEvent); } else { //when first!=null lastConvertedEvent.setNext(first); first = firstConvertedEvent; } } #location 22 #vulnerability type NULL_DEREFERENCE
#fixed code public void add(StreamEvent streamEvent){ StreamEvent borrowedEvent = eventManager.borrowEvent(); eventManager.convertStreamEvent(streamEvent, borrowedEvent); if(lastReturned!=null){ StreamEvent lastEvent = lastReturned; StreamEvent even= null; while (lastEvent!=null){ even = lastEvent; lastEvent = lastEvent.getNext(); } even.setNext(borrowedEvent); }else if(previousToLastReturned!=null){ previousToLastReturned.setNext(borrowedEvent); } else if (first != null){ StreamEvent lastEvent = first; StreamEvent even= null; while (lastEvent!=null){ even = lastEvent; lastEvent = lastEvent.getNext(); } even.setNext(borrowedEvent); } else { assignEvent(borrowedEvent); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Test public void testCreatingHttpSubscriptionJsonMapping() { Subscription subscription = Subscription.Subscribe( Transport.transport("jms"). option("topic", "foo")); subscription.map( Mapper.mapper("json"). map("$.sensorData.time"). map("$.sensorData.data")); subscription.insertInto("FooStream"); ExecutionPlan.executionPlan("test").addSubscription(subscription); } #location 10 #vulnerability type NULL_DEREFERENCE
#fixed code @Test public void testCreatingHttpSubscriptionJsonMapping() { Subscription subscription = Subscription.Subscribe( Transport.transport("jms"). option("topic", "foo")); subscription.map( Mapping.format("json"). map("$.sensorData.time"). map("$.sensorData.data")); subscription.insertInto("FooStream"); ExecutionPlan.executionPlan("test").addSubscription(subscription); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public Object[] currentState() { return new Object[]{eventChunk, endOfChunk}; } #location 3 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public Object[] currentState() { return new Object[]{eventChunk}; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); if ((greatestTimestamp - minTimestamp) > k) { if ((greatestTimestamp - minTimestamp) < MAX_K) { k = greatestTimestamp - minTimestamp; } else { k = MAX_K; } } lock.lock(); Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } lock.unlock(); } } else { onTimerEvent(expiredEventTreeMap, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } catch (ArrayIndexOutOfBoundsException ec) { // This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } nextProcessor.process(complexEventChunk); } #location 17 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); lock.lock(); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); long timeDifference = greatestTimestamp - minTimestamp; if (timeDifference > k) { if (timeDifference < MAX_K) { k = timeDifference; } else { k = MAX_K; } } Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } } } else { if(expiredEventTreeMap.size() > 0) { TreeMap<Long, ArrayList<StreamEvent>> expiredEventTreeMapSnapShot = expiredEventTreeMap; expiredEventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); onTimerEvent(expiredEventTreeMapSnapShot, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } } catch (ArrayIndexOutOfBoundsException ec) { //This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } lock.unlock(); nextProcessor.process(complexEventChunk); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); if (streamEvent.getType() == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, streamEvent.getType())); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, streamEvent.getType())); } selector.process(returnEventChunk); returnEventChunk.clear(); continue; } joinLock.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } } #location 16 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLock.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } else if (eventType == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, eventType)); } } else { joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } else { if (preJoinProcessor) { joinLock.lock(); try { nextProcessor.process(complexEventChunk); } finally { joinLock.unlock(); } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void send(Event event, int streamIndex) { try { long sequenceNo = ringBuffer.next(); try { IndexedEventFactory.IndexedEvent existingEvent = ringBuffer.get(sequenceNo); existingEvent.setEvent(event); existingEvent.setStreamIndex(streamIndex); } finally { eventSizeInDisruptor.incrementAndGet(); ringBuffer.publish(sequenceNo); //Todo fix this for array of events } } catch (NullPointerException e) { throw new ExecutionPlanRuntimeException("Execution Plan:" + executionPlanContext.getName() + " not " + "initialised yet! Run executionPlanRuntime.start();", e); } } #location 11 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public void send(Event event, int streamIndex) { inputProcessor.send(event, streamIndex); // try { // long sequenceNo = ringBuffer.next(); // try { // IndexedEventFactory.IndexedEvent existingEvent = ringBuffer.get(sequenceNo); // existingEvent.setEvent(event); // existingEvent.setStreamIndex(streamIndex); // } finally { // eventSizeInDisruptor.incrementAndGet(); // ringBuffer.publish(sequenceNo); //Todo fix this for array of events // } // } catch (NullPointerException e) { // throw new ExecutionPlanRuntimeException("Execution Plan:" + executionPlanContext.getName() + " not " + // "initialised yet! Run executionPlanRuntime.start();", e); // } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLock.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } else if (eventType == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, eventType)); } } else { joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } else { if (preJoinProcessor) { joinLock.lock(); try { nextProcessor.process(complexEventChunk); } finally { joinLock.unlock(); } } } } #location 3 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLockWrapper.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } else if (eventType == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, eventType)); } } else { joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } } finally { joinLockWrapper.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); if ((greatestTimestamp - minTimestamp) > k) { if ((greatestTimestamp - minTimestamp) < MAX_K) { k = greatestTimestamp - minTimestamp; } else { k = MAX_K; } } lock.lock(); Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } lock.unlock(); } } else { onTimerEvent(expiredEventTreeMap, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } catch (ArrayIndexOutOfBoundsException ec) { // This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } nextProcessor.process(complexEventChunk); } #location 61 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); lock.lock(); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); long timeDifference = greatestTimestamp - minTimestamp; if (timeDifference > k) { if (timeDifference < MAX_K) { k = timeDifference; } else { k = MAX_K; } } Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } } } else { if(expiredEventTreeMap.size() > 0) { TreeMap<Long, ArrayList<StreamEvent>> expiredEventTreeMapSnapShot = expiredEventTreeMap; expiredEventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); onTimerEvent(expiredEventTreeMapSnapShot, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } } catch (ArrayIndexOutOfBoundsException ec) { //This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } lock.unlock(); nextProcessor.process(complexEventChunk); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); if ((greatestTimestamp - minTimestamp) > k) { if ((greatestTimestamp - minTimestamp) < MAX_K) { k = greatestTimestamp - minTimestamp; } else { k = MAX_K; } } lock.lock(); Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } lock.unlock(); } } else { onTimerEvent(expiredEventTreeMap, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } catch (ArrayIndexOutOfBoundsException ec) { // This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } nextProcessor.process(complexEventChunk); } #location 37 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); lock.lock(); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); long timeDifference = greatestTimestamp - minTimestamp; if (timeDifference > k) { if (timeDifference < MAX_K) { k = timeDifference; } else { k = MAX_K; } } Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } } } else { if(expiredEventTreeMap.size() > 0) { TreeMap<Long, ArrayList<StreamEvent>> expiredEventTreeMapSnapShot = expiredEventTreeMap; expiredEventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); onTimerEvent(expiredEventTreeMapSnapShot, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } } catch (ArrayIndexOutOfBoundsException ec) { //This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } lock.unlock(); nextProcessor.process(complexEventChunk); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Test public void testCreatingJmsSubscriptionTextMapping() { Subscription subscription = Subscription.Subscribe( Transport.transport("jms"). option("topic", "foo")); subscription.map(Mapper.mapper("text"). map("regex1[1]"). map("regex2[3]"). option("regex1", "(\\w+)\\s(\\w+)\\s(\\w+)\\s(\\w+)"). option("regex2", "(\\w+)\\s(\\w+)\\s(\\w+)\\s(\\w+)") ); subscription.insertInto("FooStream"); ExecutionPlan.executionPlan("test").addSubscription(subscription); } #location 9 #vulnerability type NULL_DEREFERENCE
#fixed code @Test public void testCreatingJmsSubscriptionTextMapping() { Subscription subscription = Subscription.Subscribe( Transport.transport("jms"). option("topic", "foo")); subscription.map(Mapping.format("text"). map("regex1[1]"). map("regex2[3]"). option("regex1", "(\\w+)\\s(\\w+)\\s(\\w+)\\s(\\w+)"). option("regex2", "(\\w+)\\s(\\w+)\\s(\\w+)\\s(\\w+)") ); subscription.insertInto("FooStream"); ExecutionPlan.executionPlan("test").addSubscription(subscription); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); if ((greatestTimestamp - minTimestamp) > k) { if ((greatestTimestamp - minTimestamp) < MAX_K) { k = greatestTimestamp - minTimestamp; } else { k = MAX_K; } } lock.lock(); Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } lock.unlock(); } } else { onTimerEvent(expiredEventTreeMap, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } catch (ArrayIndexOutOfBoundsException ec) { // This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } nextProcessor.process(complexEventChunk); } #location 13 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); lock.lock(); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); long timeDifference = greatestTimestamp - minTimestamp; if (timeDifference > k) { if (timeDifference < MAX_K) { k = timeDifference; } else { k = MAX_K; } } Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } } } else { if(expiredEventTreeMap.size() > 0) { TreeMap<Long, ArrayList<StreamEvent>> expiredEventTreeMapSnapShot = expiredEventTreeMap; expiredEventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); onTimerEvent(expiredEventTreeMapSnapShot, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } } catch (ArrayIndexOutOfBoundsException ec) { //This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } lock.unlock(); nextProcessor.process(complexEventChunk); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { while (streamEventChunk.hasNext()) { ComplexEvent complexEvent = streamEventChunk.next(); Object[] inputData = new Object[attributeExpressionLength-paramPosition]; double xDash = ((Number) attributeExpressionExecutors[paramPosition-1].execute(complexEvent)).doubleValue(); for (int i = paramPosition; i < attributeExpressionLength; i++) { inputData[i-paramPosition] = attributeExpressionExecutors[i].execute(complexEvent); } Object[] temp = regressionCalculator.calculateLinearRegression(inputData); Object[] outputData = new Object[temp.length+1]; System.arraycopy(temp, 0, outputData, 0, temp.length); outputData[temp.length] = ((Number) temp[temp.length-2]).doubleValue() + ((Number) temp[temp.length-1]).doubleValue() * xDash; if (outputData == null) { streamEventChunk.remove(); } else { complexEventPopulater.populateComplexEvent(complexEvent, outputData); } } nextProcessor.process(streamEventChunk); } #location 12 #vulnerability type NULL_DEREFERENCE
#fixed code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { while (streamEventChunk.hasNext()) { ComplexEvent complexEvent = streamEventChunk.next(); Object[] inputData = new Object[attributeExpressionLength-paramPosition]; // Obtain x value that user wants to use to forecast Y double xDash = ((Number) attributeExpressionExecutors[paramPosition-1].execute(complexEvent)).doubleValue(); for (int i = paramPosition; i < attributeExpressionLength; i++) { inputData[i-paramPosition] = attributeExpressionExecutors[i].execute(complexEvent); } Object[] coefficients = regressionCalculator.calculateLinearRegression(inputData); if (coefficients == null) { streamEventChunk.remove(); } else { Object[] outputData = new Object[coefficients.length+1]; System.arraycopy(coefficients, 0, outputData, 0, coefficients.length); // Calculating forecast Y based on regression equation and given x outputData[coefficients.length] = ((Number) coefficients[coefficients.length-2]).doubleValue() + ((Number) coefficients[coefficients.length-1]).doubleValue() * xDash; complexEventPopulater.populateComplexEvent(complexEvent, outputData); } } nextProcessor.process(streamEventChunk); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); if ((greatestTimestamp - minTimestamp) > k) { if ((greatestTimestamp - minTimestamp) < MAX_K) { k = greatestTimestamp - minTimestamp; } else { k = MAX_K; } } lock.lock(); Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } lock.unlock(); } } else { onTimerEvent(expiredEventTreeMap, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } catch (ArrayIndexOutOfBoundsException ec) { // This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } nextProcessor.process(complexEventChunk); } #location 75 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); lock.lock(); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); long timeDifference = greatestTimestamp - minTimestamp; if (timeDifference > k) { if (timeDifference < MAX_K) { k = timeDifference; } else { k = MAX_K; } } Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } } } else { if(expiredEventTreeMap.size() > 0) { TreeMap<Long, ArrayList<StreamEvent>> expiredEventTreeMapSnapShot = expiredEventTreeMap; expiredEventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); onTimerEvent(expiredEventTreeMapSnapShot, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } } catch (ArrayIndexOutOfBoundsException ec) { //This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } lock.unlock(); nextProcessor.process(complexEventChunk); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLock.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } else if (eventType == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, eventType)); } } else { joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } else { if (preJoinProcessor) { joinLock.lock(); try { nextProcessor.process(complexEventChunk); } finally { joinLock.unlock(); } } } } #location 11 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLockWrapper.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } else if (eventType == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, eventType)); } } else { joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } } finally { joinLockWrapper.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); if ((greatestTimestamp - minTimestamp) > k) { if ((greatestTimestamp - minTimestamp) < MAX_K) { k = greatestTimestamp - minTimestamp; } else { k = MAX_K; } } lock.lock(); Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } lock.unlock(); } } else { onTimerEvent(expiredEventTreeMap, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } catch (ArrayIndexOutOfBoundsException ec) { // This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } nextProcessor.process(complexEventChunk); } #location 33 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); lock.lock(); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); long timeDifference = greatestTimestamp - minTimestamp; if (timeDifference > k) { if (timeDifference < MAX_K) { k = timeDifference; } else { k = MAX_K; } } Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } } } else { if(expiredEventTreeMap.size() > 0) { TreeMap<Long, ArrayList<StreamEvent>> expiredEventTreeMapSnapShot = expiredEventTreeMap; expiredEventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); onTimerEvent(expiredEventTreeMapSnapShot, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } } catch (ArrayIndexOutOfBoundsException ec) { //This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } lock.unlock(); nextProcessor.process(complexEventChunk); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override protected void add(List<Object[]> records) { String insertQuery = this.resolveTableName(this.queryConfigurationEntry.getRecordInsertQuery()); StringBuilder params = new StringBuilder(); int fieldsLeft = this.attributes.size(); while (fieldsLeft > 0) { params.append(QUESTION_MARK); if (fieldsLeft > 1) { params.append(SEPARATOR); } fieldsLeft = fieldsLeft - 1; } insertQuery = insertQuery.replace(Q_PLACEHOLDER, params.toString()); try { this.batchExecuteQueriesWithRecords(insertQuery, records, false); } catch (SQLException e) { throw new RDBMSTableException("Error in adding events to '" + this.tableName + "' store: " + e.getMessage(), e); } } #location 13 #vulnerability type NULL_DEREFERENCE
#fixed code @Override protected void add(List<Object[]> records) { String sql = this.composeInsertQuery(); try { this.batchExecuteQueriesWithRecords(sql, records, false); } catch (SQLException e) { throw new RDBMSTableException("Error in adding events to '" + this.tableName + "' store: " + e.getMessage(), e); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); if ((greatestTimestamp - minTimestamp) > k) { if ((greatestTimestamp - minTimestamp) < MAX_K) { k = greatestTimestamp - minTimestamp; } else { k = MAX_K; } } lock.lock(); Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } lock.unlock(); } } else { onTimerEvent(expiredEventTreeMap, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } catch (ArrayIndexOutOfBoundsException ec) { // This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } nextProcessor.process(complexEventChunk); } #location 6 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); lock.lock(); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); long timeDifference = greatestTimestamp - minTimestamp; if (timeDifference > k) { if (timeDifference < MAX_K) { k = timeDifference; } else { k = MAX_K; } } Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } } } else { if(expiredEventTreeMap.size() > 0) { TreeMap<Long, ArrayList<StreamEvent>> expiredEventTreeMapSnapShot = expiredEventTreeMap; expiredEventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); onTimerEvent(expiredEventTreeMapSnapShot, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } } catch (ArrayIndexOutOfBoundsException ec) { //This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } lock.unlock(); nextProcessor.process(complexEventChunk); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code protected void processAndClear(int processIndex, StreamEvent streamEvent) { ComplexEventChunk<StateEvent> retEventChunk = new ComplexEventChunk<StateEvent>(false); ComplexEventChunk<StreamEvent> currentStreamEventChunk = new ComplexEventChunk<StreamEvent>(streamEvent, streamEvent, false); synchronized (lockKey) { ComplexEventChunk<StateEvent> eventChunk = ((StreamPreStateProcessor) nextProcessors[processIndex]).processAndReturn(currentStreamEventChunk); if(eventChunk.getFirst() != null){ retEventChunk.add(eventChunk.getFirst()); } eventChunk.clear(); } if(querySelector!= null) { while (retEventChunk.hasNext()) { StateEvent stateEvent = retEventChunk.next(); retEventChunk.remove(); querySelector.process(new ComplexEventChunk<StateEvent>(stateEvent,stateEvent, false)); } } } #location 16 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code protected void processAndClear(int processIndex, StreamEvent streamEvent) { ComplexEventChunk<StateEvent> retEventChunk = new ComplexEventChunk<StateEvent>(false); ComplexEventChunk<StreamEvent> currentStreamEventChunk = new ComplexEventChunk<StreamEvent>(streamEvent, streamEvent, false); ComplexEventChunk<StateEvent> eventChunk = ((StreamPreStateProcessor) nextProcessors[processIndex]).processAndReturn(currentStreamEventChunk); if(eventChunk.getFirst() != null){ retEventChunk.add(eventChunk.getFirst()); } eventChunk.clear(); if(querySelector!= null) { while (retEventChunk.hasNext()) { StateEvent stateEvent = retEventChunk.next(); retEventChunk.remove(); querySelector.process(new ComplexEventChunk<StateEvent>(stateEvent,stateEvent, false)); } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLock.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } else if (eventType == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, eventType)); } } else { joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } else { if (preJoinProcessor) { joinLock.lock(); try { nextProcessor.process(complexEventChunk); } finally { joinLock.unlock(); } } } } #location 6 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLockWrapper.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } else if (eventType == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, eventType)); } } else { joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } } finally { joinLockWrapper.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); if ((greatestTimestamp - minTimestamp) > k) { if ((greatestTimestamp - minTimestamp) < MAX_K) { k = greatestTimestamp - minTimestamp; } else { k = MAX_K; } } lock.lock(); Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } lock.unlock(); } } else { onTimerEvent(expiredEventTreeMap, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } catch (ArrayIndexOutOfBoundsException ec) { // This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } nextProcessor.process(complexEventChunk); } #location 15 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); lock.lock(); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); long timeDifference = greatestTimestamp - minTimestamp; if (timeDifference > k) { if (timeDifference < MAX_K) { k = timeDifference; } else { k = MAX_K; } } Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } } } else { if(expiredEventTreeMap.size() > 0) { TreeMap<Long, ArrayList<StreamEvent>> expiredEventTreeMapSnapShot = expiredEventTreeMap; expiredEventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); onTimerEvent(expiredEventTreeMapSnapShot, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } } catch (ArrayIndexOutOfBoundsException ec) { //This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } lock.unlock(); nextProcessor.process(complexEventChunk); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code protected ComplexEvent createSendEvent(ComplexEvent originalEvent, Map<Integer, Object> aggregateAttributeValueMap) { ComplexEvent copiedEvent = null; if (originalEvent instanceof StreamEvent) { copiedEvent = streamEventCloner.copyStreamEvent((StreamEvent) originalEvent); } else if (originalEvent instanceof StateEvent) { copiedEvent = stateEventCloner.copyStateEvent((StateEvent) originalEvent); } for (Integer position : aggregateAttributePositionList) { copiedEvent.getOutputData()[position] = aggregateAttributeValueMap.get(position); } return copiedEvent; } #location 10 #vulnerability type NULL_DEREFERENCE
#fixed code protected ComplexEvent createSendEvent(ComplexEvent originalEvent, Map<Integer, Object> aggregateAttributeValueMap) { ComplexEvent copiedEvent = cloneComplexEvent(originalEvent); for (Integer position : aggregateAttributePositionList) { copiedEvent.getOutputData()[position] = aggregateAttributeValueMap.get(position); } return copiedEvent; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void process(ComplexEventChunk complexEventChunk) { List<ComplexEventChunk<ComplexEvent>> outputEventChunks = new ArrayList<ComplexEventChunk<ComplexEvent>>(); complexEventChunk.reset(); synchronized (this) { complexEventChunk.reset(); while (complexEventChunk.hasNext()) { ComplexEvent event = complexEventChunk.next(); if (event.getType() == ComplexEvent.Type.TIMER) { if (event.getTimestamp() >= scheduledTime) { ComplexEventChunk<ComplexEvent> outputEventChunk = new ComplexEventChunk<ComplexEvent>(false); for (ComplexEvent complexEvent : groupByKeyEvents.values()) { outputEventChunk.add(cloneComplexEvent(complexEvent)); } outputEventChunks.add(outputEventChunk); scheduledTime += value; scheduler.notifyAt(scheduledTime); } } else if (event.getType() == ComplexEvent.Type.CURRENT) { complexEventChunk.remove(); GroupedComplexEvent groupedComplexEvent = ((GroupedComplexEvent) event); groupByKeyEvents.put(groupedComplexEvent.getGroupKey(), groupedComplexEvent.getComplexEvent()); } } } for (ComplexEventChunk eventChunk : outputEventChunks) { sendToCallBacks(eventChunk); } } #location 13 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void process(ComplexEventChunk complexEventChunk) { List<ComplexEventChunk<ComplexEvent>> outputEventChunks = new ArrayList<ComplexEventChunk<ComplexEvent>>(); complexEventChunk.reset(); synchronized (this) { complexEventChunk.reset(); while (complexEventChunk.hasNext()) { ComplexEvent event = complexEventChunk.next(); if (event.getType() == ComplexEvent.Type.TIMER) { tryFlushEvents(outputEventChunks, event); } else if (event.getType() == ComplexEvent.Type.CURRENT) { complexEventChunk.remove(); tryFlushEvents(outputEventChunks, event); GroupedComplexEvent groupedComplexEvent = ((GroupedComplexEvent) event); groupByKeyEvents.put(groupedComplexEvent.getGroupKey(), groupedComplexEvent.getComplexEvent()); } } } for (ComplexEventChunk eventChunk : outputEventChunks) { sendToCallBacks(eventChunk); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void run() { while (!inactive) { while (!paused) { // The time, in milliseconds, spent waiting in poll if data is not available. If 0, returns // immediately with any records that are available now. Must not be negative ConsumerRecords<byte[], byte[]> records = consumer.poll(200); for (ConsumerRecord record : records) { String event = record.value().toString(); if (log.isDebugEnabled()) { log.debug("Event received in Kafka Event Adaptor: " + event + ", offSet: " + record.offset() + ", key: " + record.key() + ", topic: " + record.topic() + ", partition: " + record .partition()); } topicOffsetMap.get(record.topic()).put(record.partition(), record.offset()); sourceEventListener.onEvent(event); } try { if (!records.isEmpty()) { consumer.commitAsync(); } } catch (CommitFailedException e) { log.error("Kafka commit failed for topic kafka_result_topic", e); } } try { Thread.sleep(1); } catch (InterruptedException ignore) { } } consumer.close(); } #location 15 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void run() { final Lock consumerLock = this.consumerLock; while (!inactive) { while (!paused) { // The time, in milliseconds, spent waiting in poll if data is not available. If 0, returns // immediately with any records that are available now. Must not be negative ConsumerRecords<byte[], byte[]> records; try { consumerLock.lock(); records = consumer.poll(100); } finally { consumerLock.unlock(); } for (ConsumerRecord record : records) { String event = record.value().toString(); if (log.isDebugEnabled()) { log.debug("Event received in Kafka Event Adaptor: " + event + ", offSet: " + record.offset() + ", key: " + record.key() + ", topic: " + record.topic() + ", partition: " + record .partition()); } topicOffsetMap.get(record.topic()).put(record.partition(), record.offset()); sourceEventListener.onEvent(event); } try { consumerLock.lock(); if (!records.isEmpty()) { consumer.commitAsync(); } } catch (CommitFailedException e) { log.error("Kafka commit failed for topic kafka_result_topic", e); } finally { consumerLock.unlock(); } } } consumerLock.lock(); consumer.close(); consumerLock.unlock(); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); if ((greatestTimestamp - minTimestamp) > k) { if ((greatestTimestamp - minTimestamp) < MAX_K) { k = greatestTimestamp - minTimestamp; } else { k = MAX_K; } } lock.lock(); Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } lock.unlock(); } } else { onTimerEvent(expiredEventTreeMap, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } catch (ArrayIndexOutOfBoundsException ec) { // This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } nextProcessor.process(complexEventChunk); } #location 74 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); lock.lock(); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); long timeDifference = greatestTimestamp - minTimestamp; if (timeDifference > k) { if (timeDifference < MAX_K) { k = timeDifference; } else { k = MAX_K; } } Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } } } else { if(expiredEventTreeMap.size() > 0) { TreeMap<Long, ArrayList<StreamEvent>> expiredEventTreeMapSnapShot = expiredEventTreeMap; expiredEventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); onTimerEvent(expiredEventTreeMapSnapShot, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } } catch (ArrayIndexOutOfBoundsException ec) { //This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } lock.unlock(); nextProcessor.process(complexEventChunk); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); if (streamEvent.getType() == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, streamEvent.getType())); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, streamEvent.getType())); } selector.process(returnEventChunk); returnEventChunk.clear(); continue; } joinLock.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } } #location 35 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLock.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } else if (eventType == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, eventType)); } } else { joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } else { if (preJoinProcessor) { joinLock.lock(); try { nextProcessor.process(complexEventChunk); } finally { joinLock.unlock(); } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner) { while (streamEventChunk.hasNext()) { StreamEvent streamEvent = streamEventChunk.next(); StreamEvent clonedEvent = streamEventCloner.copyStreamEvent(streamEvent); clonedEvent.setType(StreamEvent.Type.EXPIRED); if (count < length) { count++; this.expiredEventChunk.add(clonedEvent); } else { StreamEvent firstEvent = this.expiredEventChunk.poll(); streamEventChunk.insertBeforeCurrent(firstEvent); this.expiredEventChunk.add(clonedEvent); } } nextProcessor.process(streamEventChunk); } #location 12 #vulnerability type NULL_DEREFERENCE
#fixed code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner) { while (streamEventChunk.hasNext()) { StreamEvent streamEvent = streamEventChunk.next(); StreamEvent clonedEvent = streamEventCloner.copyStreamEvent(streamEvent); clonedEvent.setType(StreamEvent.Type.EXPIRED); if (count < length) { count++; this.expiredEventChunk.add(clonedEvent); } else { StreamEvent firstEvent = this.expiredEventChunk.poll(); if(firstEvent!=null) { streamEventChunk.insertBeforeCurrent(firstEvent); this.expiredEventChunk.add(clonedEvent); } else { streamEventChunk.insertBeforeCurrent(clonedEvent); } } } nextProcessor.process(streamEventChunk); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); if ((greatestTimestamp - minTimestamp) > k) { if ((greatestTimestamp - minTimestamp) < MAX_K) { k = greatestTimestamp - minTimestamp; } else { k = MAX_K; } } lock.lock(); Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } lock.unlock(); } } else { onTimerEvent(expiredEventTreeMap, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } catch (ArrayIndexOutOfBoundsException ec) { // This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } nextProcessor.process(complexEventChunk); } #location 32 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); lock.lock(); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); long timeDifference = greatestTimestamp - minTimestamp; if (timeDifference > k) { if (timeDifference < MAX_K) { k = timeDifference; } else { k = MAX_K; } } Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } } } else { if(expiredEventTreeMap.size() > 0) { TreeMap<Long, ArrayList<StreamEvent>> expiredEventTreeMapSnapShot = expiredEventTreeMap; expiredEventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); onTimerEvent(expiredEventTreeMapSnapShot, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } } catch (ArrayIndexOutOfBoundsException ec) { //This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } lock.unlock(); nextProcessor.process(complexEventChunk); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); if ((greatestTimestamp - minTimestamp) > k) { if ((greatestTimestamp - minTimestamp) < MAX_K) { k = greatestTimestamp - minTimestamp; } else { k = MAX_K; } } lock.lock(); Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } lock.unlock(); } } else { onTimerEvent(expiredEventTreeMap, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } catch (ArrayIndexOutOfBoundsException ec) { // This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } nextProcessor.process(complexEventChunk); } #location 9 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); lock.lock(); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); long timeDifference = greatestTimestamp - minTimestamp; if (timeDifference > k) { if (timeDifference < MAX_K) { k = timeDifference; } else { k = MAX_K; } } Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } } } else { if(expiredEventTreeMap.size() > 0) { TreeMap<Long, ArrayList<StreamEvent>> expiredEventTreeMapSnapShot = expiredEventTreeMap; expiredEventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); onTimerEvent(expiredEventTreeMapSnapShot, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } } catch (ArrayIndexOutOfBoundsException ec) { //This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } lock.unlock(); nextProcessor.process(complexEventChunk); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code protected ComplexEvent createSendEvent(ComplexEvent originalEvent, Map<Integer, Object> aggregateAttributeValueMap) { ComplexEvent copiedEvent = null; if (originalEvent instanceof StreamEvent) { copiedEvent = streamEventCloner.copyStreamEvent((StreamEvent) originalEvent); } else if (originalEvent instanceof StateEvent) { copiedEvent = stateEventCloner.copyStateEvent((StateEvent) originalEvent); } for (Integer position : aggregateAttributePositionList) { copiedEvent.getOutputData()[position] = aggregateAttributeValueMap.get(position); } return copiedEvent; } #location 4 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code protected ComplexEvent createSendEvent(ComplexEvent originalEvent, Map<Integer, Object> aggregateAttributeValueMap) { ComplexEvent copiedEvent = cloneComplexEvent(originalEvent); for (Integer position : aggregateAttributePositionList) { copiedEvent.getOutputData()[position] = aggregateAttributeValueMap.get(position); } return copiedEvent; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLock.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } else if (eventType == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, eventType)); } } else { joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } else { if (preJoinProcessor) { joinLock.lock(); try { nextProcessor.process(complexEventChunk); } finally { joinLock.unlock(); } } } } #location 12 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLockWrapper.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } else if (eventType == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, eventType)); } } else { joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } } finally { joinLockWrapper.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLock.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } else if (eventType == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, eventType)); } } else { joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } else { if (preJoinProcessor) { joinLock.lock(); try { nextProcessor.process(complexEventChunk); } finally { joinLock.unlock(); } } } } #location 13 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLockWrapper.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } else if (eventType == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, eventType)); } } else { joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } } finally { joinLockWrapper.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLock.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } else if (eventType == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, eventType)); } } else { joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } else { if (preJoinProcessor) { joinLock.lock(); try { nextProcessor.process(complexEventChunk); } finally { joinLock.unlock(); } } } } #location 49 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLockWrapper.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } else if (eventType == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, eventType)); } } else { joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } } finally { joinLockWrapper.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); if (streamEvent.getType() == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, streamEvent.getType())); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, streamEvent.getType())); } selector.process(returnEventChunk); returnEventChunk.clear(); continue; } joinLock.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } } #location 18 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLock.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } else if (eventType == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, eventType)); } } else { joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } else { if (preJoinProcessor) { joinLock.lock(); try { nextProcessor.process(complexEventChunk); } finally { joinLock.unlock(); } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLock.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } else if (eventType == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, eventType)); } } else { joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } else { if (preJoinProcessor) { joinLock.lock(); try { nextProcessor.process(complexEventChunk); } finally { joinLock.unlock(); } } } } #location 7 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLockWrapper.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } else if (eventType == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, eventType)); } } else { joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } } finally { joinLockWrapper.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); if ((greatestTimestamp - minTimestamp) > k) { if ((greatestTimestamp - minTimestamp) < MAX_K) { k = greatestTimestamp - minTimestamp; } else { k = MAX_K; } } lock.lock(); Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } lock.unlock(); } } else { onTimerEvent(expiredEventTreeMap, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } catch (ArrayIndexOutOfBoundsException ec) { // This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } nextProcessor.process(complexEventChunk); } #location 18 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); lock.lock(); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); long timeDifference = greatestTimestamp - minTimestamp; if (timeDifference > k) { if (timeDifference < MAX_K) { k = timeDifference; } else { k = MAX_K; } } Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } } } else { if(expiredEventTreeMap.size() > 0) { TreeMap<Long, ArrayList<StreamEvent>> expiredEventTreeMapSnapShot = expiredEventTreeMap; expiredEventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); onTimerEvent(expiredEventTreeMapSnapShot, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } } catch (ArrayIndexOutOfBoundsException ec) { //This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } lock.unlock(); nextProcessor.process(complexEventChunk); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); if ((greatestTimestamp - minTimestamp) > k) { if ((greatestTimestamp - minTimestamp) < MAX_K) { k = greatestTimestamp - minTimestamp; } else { k = MAX_K; } } lock.lock(); Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } lock.unlock(); } } else { onTimerEvent(expiredEventTreeMap, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } catch (ArrayIndexOutOfBoundsException ec) { // This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } nextProcessor.process(complexEventChunk); } #location 39 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); lock.lock(); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); long timeDifference = greatestTimestamp - minTimestamp; if (timeDifference > k) { if (timeDifference < MAX_K) { k = timeDifference; } else { k = MAX_K; } } Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } } } else { if(expiredEventTreeMap.size() > 0) { TreeMap<Long, ArrayList<StreamEvent>> expiredEventTreeMapSnapShot = expiredEventTreeMap; expiredEventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); onTimerEvent(expiredEventTreeMapSnapShot, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } } catch (ArrayIndexOutOfBoundsException ec) { //This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } lock.unlock(); nextProcessor.process(complexEventChunk); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void process(StreamEvent event) { StreamEvent head = event; //head of in events StreamEvent expiredEventTail; StreamEvent expiredEventHead; while (event != null) { processEvent(event); event = event.getNext(); } //if window is expired if (count > length) { int diff = count - length; expiredEventTail = removeEventHead; for (int i = 1; i < diff; i++) { expiredEventTail = expiredEventTail.getNext(); } expiredEventHead = removeEventHead; removeEventHead = expiredEventTail.getNext(); expiredEventTail.setNext(null); head.addToLast(expiredEventHead); nextProcessor.process(head); //emit in events and remove events as expired events count = count - diff; } else { nextProcessor.process(head); //emit only in events as window is not expired } } #location 18 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void process(StreamEvent event) { StreamEvent head = event; //head of in events StreamEvent expiredEventTail; StreamEvent expiredEventHead; while (event != null) { processEvent(event); event = event.getNext(); } //if window is expired if (count > length) { int diff = count - length; expiredEventTail = removeEventHead; for (int i = 1; i < diff; i++) { expiredEventTail = expiredEventTail.getNext(); } expiredEventHead = removeEventHead; removeEventHead = expiredEventTail.getNext(); expiredEventTail.setNext(null); addToLast(head, expiredEventHead); nextProcessor.process(head); //emit in events and remove events as expired events count = count - diff; } else { nextProcessor.process(head); //emit only in events as window is not expired } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); if ((greatestTimestamp - minTimestamp) > k) { if ((greatestTimestamp - minTimestamp) < MAX_K) { k = greatestTimestamp - minTimestamp; } else { k = MAX_K; } } lock.lock(); Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } lock.unlock(); } } else { onTimerEvent(expiredEventTreeMap, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } catch (ArrayIndexOutOfBoundsException ec) { // This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } nextProcessor.process(complexEventChunk); } #location 76 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override protected void process(ComplexEventChunk<StreamEvent> streamEventChunk, Processor nextProcessor, StreamEventCloner streamEventCloner, ComplexEventPopulater complexEventPopulater) { ComplexEventChunk<StreamEvent> complexEventChunk = new ComplexEventChunk<StreamEvent>(false); lock.lock(); try { while (streamEventChunk.hasNext()) { StreamEvent event = streamEventChunk.next(); if(event.getType() != ComplexEvent.Type.TIMER) { streamEventChunk.remove(); //We might have the rest of the events linked to this event forming a chain. long timestamp = (Long) timestampExecutor.execute(event); if (expireFlag) { if (timestamp < lastSentTimeStamp) { continue; } } ArrayList<StreamEvent> eventList = eventTreeMap.get(timestamp); if (eventList == null) { eventList = new ArrayList<StreamEvent>(); } eventList.add(event); eventTreeMap.put(timestamp, eventList); if (timestamp > greatestTimestamp) { greatestTimestamp = timestamp; long minTimestamp = eventTreeMap.firstKey(); long timeDifference = greatestTimestamp - minTimestamp; if (timeDifference > k) { if (timeDifference < MAX_K) { k = timeDifference; } else { k = MAX_K; } } Iterator<Map.Entry<Long, ArrayList<StreamEvent>>> entryIterator = eventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); ArrayList<StreamEvent> list = expiredEventTreeMap.get(entry.getKey()); if (list != null) { list.addAll(entry.getValue()); } else { expiredEventTreeMap.put(entry.getKey(), entry.getValue()); } } eventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); entryIterator = expiredEventTreeMap.entrySet().iterator(); while (entryIterator.hasNext()) { Map.Entry<Long, ArrayList<StreamEvent>> entry = entryIterator.next(); if (entry.getKey() + k <= greatestTimestamp) { entryIterator.remove(); ArrayList<StreamEvent> timeEventList = entry.getValue(); lastSentTimeStamp = entry.getKey(); for (StreamEvent aTimeEventList : timeEventList) { complexEventChunk.add(aTimeEventList); } } } } } else { if(expiredEventTreeMap.size() > 0) { TreeMap<Long, ArrayList<StreamEvent>> expiredEventTreeMapSnapShot = expiredEventTreeMap; expiredEventTreeMap = new TreeMap<Long, ArrayList<StreamEvent>>(); onTimerEvent(expiredEventTreeMapSnapShot, nextProcessor); lastScheduledTimestamp = lastScheduledTimestamp + TIMER_DURATION; scheduler.notifyAt(lastScheduledTimestamp); } } } } catch (ArrayIndexOutOfBoundsException ec) { //This happens due to user specifying an invalid field index. throw new ExecutionPlanCreationException("The very first parameter must be an Integer with a valid " + " field index (0 to (fieldsLength-1))."); } lock.unlock(); nextProcessor.process(complexEventChunk); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); if (streamEvent.getType() == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, streamEvent.getType())); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, streamEvent.getType())); } selector.process(returnEventChunk); returnEventChunk.clear(); continue; } joinLock.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } } #location 37 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code @Override public void process(ComplexEventChunk complexEventChunk) { if (trigger) { ComplexEventChunk<StateEvent> returnEventChunk = new ComplexEventChunk<StateEvent>(true); StateEvent joinStateEvent = new StateEvent(2, 0); StreamEvent nextEvent = (StreamEvent) complexEventChunk.getFirst(); complexEventChunk.clear(); while (nextEvent != null) { StreamEvent streamEvent = nextEvent; nextEvent = streamEvent.getNext(); streamEvent.setNext(null); joinLock.lock(); try { ComplexEvent.Type eventType = streamEvent.getType(); if (eventType == ComplexEvent.Type.TIMER) { continue; } else if (eventType == ComplexEvent.Type.RESET) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(null, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, null, eventType)); } } else { joinStateEvent.setEvent(matchingStreamIndex, streamEvent); StreamEvent foundStreamEvent = findableProcessor.find(joinStateEvent, finder); joinStateEvent.setEvent(matchingStreamIndex, null); if (foundStreamEvent == null) { if (outerJoinProcessor && !leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else if (outerJoinProcessor && leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } } else { while (foundStreamEvent != null) { if (!leftJoinProcessor) { returnEventChunk.add(joinEventBuilder(foundStreamEvent, streamEvent, eventType)); } else { returnEventChunk.add(joinEventBuilder(streamEvent, foundStreamEvent, eventType)); } foundStreamEvent = foundStreamEvent.getNext(); } } } } finally { joinLock.unlock(); } if (returnEventChunk.getFirst() != null) { selector.process(returnEventChunk); returnEventChunk.clear(); } } } else { if (preJoinProcessor) { joinLock.lock(); try { nextProcessor.process(complexEventChunk); } finally { joinLock.unlock(); } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException { LOGGER.info("CSP-Reporting-Servlet"); try { BufferedReader reader = new BufferedReader(new InputStreamReader(request.getInputStream())); StringBuilder responseBuilder = new StringBuilder(); String inputStr; while ((inputStr = reader.readLine()) != null) { responseBuilder.append(inputStr); } LOGGER.info("REPORT " + responseBuilder.toString()); JSONObject json = new JSONObject(responseBuilder.toString()); JSONObject cspReport = json.getJSONObject("csp-report"); LOGGER.info("document-uri: " + cspReport.getString("document-uri")); LOGGER.info("referrer: " + cspReport.getString("referrer")); LOGGER.info("blocked-uri: " + cspReport.getString("blocked-uri")); LOGGER.info("violated-directive: " + cspReport.getString("violated-directive")); LOGGER.info("source-file: " + cspReport.getString("source-file")); LOGGER.info("script-sample: " + cspReport.getString("script-sample")); LOGGER.info("line-number: " + cspReport.getString("line-number")); } catch (IOException | JSONException ex) { LOGGER.error(ex.getMessage(), ex); } } #location 24 #vulnerability type RESOURCE_LEAK
#fixed code protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException { LOGGER.info("CSP-Reporting-Servlet"); try (BufferedReader reader = new BufferedReader(new InputStreamReader(request.getInputStream()))) { StringBuilder responseBuilder = new StringBuilder(); String inputStr; while ((inputStr = reader.readLine()) != null) { responseBuilder.append(inputStr); } LOGGER.info("REPORT " + responseBuilder.toString()); JSONObject json = new JSONObject(responseBuilder.toString()); JSONObject cspReport = json.getJSONObject("csp-report"); LOGGER.info("document-uri: " + cspReport.getString("document-uri")); LOGGER.info("referrer: " + cspReport.getString("referrer")); LOGGER.info("blocked-uri: " + cspReport.getString("blocked-uri")); LOGGER.info("violated-directive: " + cspReport.getString("violated-directive")); LOGGER.info("source-file: " + cspReport.getString("source-file")); LOGGER.info("script-sample: " + cspReport.getString("script-sample")); LOGGER.info("line-number: " + cspReport.getString("line-number")); } catch (IOException | JSONException ex) { LOGGER.error(ex.getMessage(), ex); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code protected void registerWithLongPollingServer(AsyncBrowserSession bs) { JUnitSession.getInstance().getDependency(AsyncServerSession.class).registerBrowserSession(bs); } #location 2 #vulnerability type NULL_DEREFERENCE
#fixed code protected void registerWithLongPollingServer(AsyncBrowserSession bs) { JUnitSession.getInstance().getDependency(HttpLongPollingServer.class).registerBrowserSession(bs); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private void addCallToSuper(ClassScope classScope, GenerationContext context, Collection<Expression> args) { PreConditions.checkNotNull(classScope); if (classScope.getClazz().getSuperclass().isDefined() && !classScope.getClazz().getSuperclass().getOrThrow().getClazz().equals(Object.class)) { // avoid useless call to super() when the super class is Object printer.print(stJsName(classScope.getClazz().getSuperClass())).print(".call"); printArguments(Collections.singleton("this"), args, Collections.<String> emptyList(), context); printer.print(";"); } } #location 6 #vulnerability type NULL_DEREFERENCE
#fixed code private void addCallToSuper(ClassScope classScope, GenerationContext context, Collection<Expression> args) { PreConditions.checkNotNull(classScope); Option<ClassWrapper> superClass = classScope.getClazz().getSuperclass(); if (superClass.isDefined()) { if (ClassUtils.isSyntheticType(superClass.getOrThrow())) { // do not add call to super class is it's a synthetic return; } if (superClass.getOrThrow().getClazz().equals(Object.class)) { // avoid useless call to super() when the super class is Object return; } printer.print(stJsName(superClass.getOrThrow())).print(".call"); printArguments(Collections.singleton("this"), args, Collections.<String> emptyList(), context); printer.print(";"); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code protected void registerWithLongPollingServer(AsyncBrowserSession bs) { JUnitSession.getInstance().getDependency(AsyncServerSession.class).registerBrowserSession(bs); } #location 2 #vulnerability type NULL_DEREFERENCE
#fixed code protected void registerWithLongPollingServer(AsyncBrowserSession bs) { JUnitSession.getInstance().getDependency(HttpLongPollingServer.class).registerBrowserSession(bs); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void visit(ClassOrInterfaceDeclaration n, GenerationContext context) { printComments(n, context); ClassScope scope = (ClassScope) scope(n); if (resolvedType(n) == null) { // for anonymous object creation the type is set already resolvedType(n, scope.resolveType(n.getName()).getType()); } ClassWrapper type = (ClassWrapper)resolvedType(n); String namespace = null; if (ClassUtils.isRootType(type)) { namespace = ClassUtils.getNamespace(type); if (namespace != null) { printer.printLn("stjs.ns(\"" + namespace + "\");"); } } String className = null; if(!type.isAnonymousClass()){ if(!type.isInnerType() && !type.isAnonymousClass() && namespace == null){ printer.print("var "); } className = names.getTypeName(type); if(type.isInnerType()){ printer.print("constructor."); printer.print(type.getSimpleName()); } else { className = names.getTypeName(type); printer.print(className); } printer.print(" = "); printConstructorImplementation(n, context, scope, type.isAnonymousClass()); printer.printLn(";"); }else{ printer.print("("); } printer.print("stjs.extend("); if(type.isAnonymousClass()){ printConstructorImplementation(n, context, scope, type.isAnonymousClass()); }else{ printer.print(className); } printer.print(", "); // print the super class List<TypeWrapper> interfaces; if(n.isInterface()){ // interfaces do not have super classes. For interfaces, extends actually means implements printer.print("null, "); interfaces = getExtends(n); } else { List<TypeWrapper> superClass = getExtends(n); if(superClass.size() > 0){ printer.print(names.getTypeName(superClass.get(0))); }else{ printer.print("null"); } printer.print(", "); interfaces = getImplements(n); } // print the implemented interfaces printer.print("["); for (int i = 0; i < interfaces.size(); i ++) { if(i > 0){ printer.print(", "); } printer.print(names.getTypeName(interfaces.get(i))); } printer.print("], "); printMembers(n.getMembers(), context); printer.print(", "); printTypeDescription(n, context); printer.print(")"); if(!type.isAnonymousClass()){ printer.printLn(";"); if(!type.isInnerType()){ printGlobals(filterGlobals(n, type), context); printStaticInitializers(n, context); printMainMethodCall(n, type); } }else { printer.print(")"); } } #location 33 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void visit(ClassOrInterfaceDeclaration n, GenerationContext context) { printComments(n, context); ClassScope scope = (ClassScope) scope(n); if (resolvedType(n) == null) { // for anonymous object creation the type is set already resolvedType(n, scope.resolveType(n.getName()).getType()); } ClassWrapper type = (ClassWrapper)resolvedType(n); String namespace = null; if (ClassUtils.isRootType(type)) { namespace = ClassUtils.getNamespace(type); if (namespace != null) { printer.printLn("stjs.ns(\"" + namespace + "\");"); } } String className = null; if(!type.isAnonymousClass()){ if(!type.isInnerType() && !type.isAnonymousClass() && namespace == null){ printer.print("var "); } className = names.getTypeName(type); if(type.isInnerType()){ printer.print("constructor."); printer.print(type.getSimpleName()); } else { className = names.getTypeName(type); printer.print(className); } printer.print(" = "); if(!type.hasAnonymousDeclaringClass()){ printConstructorImplementation(n, context, scope, type.isAnonymousClass()); printer.printLn(";"); } }else{ printer.print("("); } printer.print("stjs.extend("); if(type.isAnonymousClass() || type.hasAnonymousDeclaringClass()){ printConstructorImplementation(n, context, scope, type.isAnonymousClass()); }else{ printer.print(className); } printer.print(", "); // print the super class List<TypeWrapper> interfaces; if(n.isInterface()){ // interfaces do not have super classes. For interfaces, extends actually means implements printer.print("null, "); interfaces = getExtends(n); } else { List<TypeWrapper> superClass = getExtends(n); if(superClass.size() > 0){ printer.print(names.getTypeName(superClass.get(0))); }else{ printer.print("null"); } printer.print(", "); interfaces = getImplements(n); } // print the implemented interfaces printer.print("["); for (int i = 0; i < interfaces.size(); i ++) { if(i > 0){ printer.print(", "); } printer.print(names.getTypeName(interfaces.get(i))); } printer.print("], "); printMembers(n.getMembers(), context); printer.print(", "); printTypeDescription(n, context); printer.print(")"); if(!type.isAnonymousClass()){ printer.printLn(";"); if(!type.isInnerType()){ printGlobals(filterGlobals(n, type), context); printStaticInitializers(n, context); printMainMethodCall(n, type); } }else { printer.print(")"); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private void fnStatement() { move(true); checkVariableName(); checkFunctionName(); getCodeGeneratorWithTimes().onConstant(this.lookhead); move(true); if (!expectChar('(')) { reportSyntaxError("expect '(' after function name"); } lambda(true); ensureFeatureEnabled(Feature.Assignment); getCodeGeneratorWithTimes().onAssignment(currentToken().withMeta(Constants.DEFINE_META, true)); } #location 5 #vulnerability type NULL_DEREFERENCE
#fixed code private void fnStatement() { move(true); checkVariableName(this.lookhead); checkFunctionName(this.lookhead, true); getCodeGeneratorWithTimes().onConstant(this.lookhead); move(true); if (!expectChar('(')) { reportSyntaxError("expect '(' after function name"); } lambda(true); ensureFeatureEnabled(Feature.Assignment); getCodeGeneratorWithTimes().onAssignment(currentToken().withMeta(Constants.DEFINE_META, true)); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static final boolean isTracedEval(Map<String, Object> env) { return (boolean) getInstance(env).getOption(Options.TRACE_EVAL); } #location 2 #vulnerability type NULL_DEREFERENCE
#fixed code public static final boolean isTracedEval(Map<String, Object> env) { return getInstance(env).getOption(Options.TRACE_EVAL) == Boolean.TRUE; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public CodeGenerator newCodeGenerator(AviatorClassLoader classLoader) { switch (getOptimizeLevel()) { case AviatorEvaluator.COMPILE: ASMCodeGenerator asmCodeGenerator = new ASMCodeGenerator(this, classLoader, traceOutputStream, (Boolean) getOption(Options.TRACE)); asmCodeGenerator.start(); return asmCodeGenerator; case AviatorEvaluator.EVAL: return new OptimizeCodeGenerator(this, classLoader, traceOutputStream, (Boolean) getOption(Options.TRACE)); default: throw new IllegalArgumentException("Unknow option " + getOptimizeLevel()); } } #location 5 #vulnerability type NULL_DEREFERENCE
#fixed code public CodeGenerator newCodeGenerator(AviatorClassLoader classLoader) { switch (getOptimizeLevel()) { case AviatorEvaluator.COMPILE: ASMCodeGenerator asmCodeGenerator = new ASMCodeGenerator(this, classLoader, traceOutputStream, getOptionValue(Options.TRACE).bool); asmCodeGenerator.start(); return asmCodeGenerator; case AviatorEvaluator.EVAL: return new OptimizeCodeGenerator(this, classLoader, traceOutputStream, getOptionValue(Options.TRACE).bool); default: throw new IllegalArgumentException("Unknow option " + getOptimizeLevel()); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public AviatorObject match(AviatorObject other, Map<String, Object> env) { switch (other.getAviatorType()) { case String: AviatorString aviatorString = (AviatorString) other; Matcher m = this.pattern.matcher(aviatorString.lexeme); if (m.matches()) { boolean captureGroups = AviatorEvaluator.getOption(Options.CAPTURING_GROUPS_IN_PATTERN_MATCHES); if (captureGroups && env != null && env != Collections.EMPTY_MAP) { int groupCount = m.groupCount(); for (int i = 0; i <= groupCount; i++) { env.put("$" + i, m.group(i)); } } return AviatorBoolean.TRUE; } else { return AviatorBoolean.FALSE; } case JavaType: AviatorJavaType javaType = (AviatorJavaType) other; final Object javaValue = javaType.getValue(env); if (TypeUtils.isString(javaValue)) { return this.match(new AviatorString(String.valueOf(javaValue)), env); } else { throw new ExpressionRuntimeException( this.desc(env) + " could not match " + other.desc(env)); } default: throw new ExpressionRuntimeException( this.desc(env) + " could not match " + other.desc(env)); } } #location 9 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public AviatorObject match(AviatorObject other, Map<String, Object> env) { switch (other.getAviatorType()) { case String: AviatorString aviatorString = (AviatorString) other; Matcher m = this.pattern.matcher(aviatorString.lexeme); if (m.matches()) { boolean captureGroups = AviatorEvaluator.getOption(Options.PUT_CAPTURING_GROUPS_INTO_ENV); if (captureGroups && env != null && env != Collections.EMPTY_MAP) { int groupCount = m.groupCount(); for (int i = 0; i <= groupCount; i++) { env.put("$" + i, m.group(i)); } } return AviatorBoolean.TRUE; } else { return AviatorBoolean.FALSE; } case JavaType: AviatorJavaType javaType = (AviatorJavaType) other; final Object javaValue = javaType.getValue(env); if (TypeUtils.isString(javaValue)) { return this.match(new AviatorString(String.valueOf(javaValue)), env); } else { throw new ExpressionRuntimeException( this.desc(env) + " could not match " + other.desc(env)); } default: throw new ExpressionRuntimeException( this.desc(env) + " could not match " + other.desc(env)); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public CodeGenerator newCodeGenerator(final AviatorClassLoader classLoader) { switch (getOptimizeLevel()) { case AviatorEvaluator.COMPILE: ASMCodeGenerator asmCodeGenerator = new ASMCodeGenerator(this, classLoader, this.traceOutputStream, getOptionValue(Options.TRACE).bool); asmCodeGenerator.start(); return asmCodeGenerator; case AviatorEvaluator.EVAL: return new OptimizeCodeGenerator(this, classLoader, this.traceOutputStream, getOptionValue(Options.TRACE).bool); default: throw new IllegalArgumentException("Unknow option " + getOptimizeLevel()); } } #location 10 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code public CodeGenerator newCodeGenerator(final AviatorClassLoader classLoader) { switch (getOptimizeLevel()) { case AviatorEvaluator.COMPILE: ASMCodeGenerator asmCodeGenerator = new ASMCodeGenerator(this, classLoader, this.traceOutputStream); asmCodeGenerator.start(); return asmCodeGenerator; case AviatorEvaluator.EVAL: return new OptimizeCodeGenerator(this, classLoader, this.traceOutputStream); default: throw new IllegalArgumentException("Unknow option " + getOptimizeLevel()); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private int getOptimizeLevel() { return getOption(Options.OPTIMIZE_LEVEL); } #location 2 #vulnerability type NULL_DEREFERENCE
#fixed code private int getOptimizeLevel() { return getOptionValue(Options.OPTIMIZE_LEVEL).level; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public CodeGenerator newCodeGenerator(final AviatorClassLoader classLoader) { switch (getOptimizeLevel()) { case AviatorEvaluator.COMPILE: ASMCodeGenerator asmCodeGenerator = new ASMCodeGenerator(this, classLoader, this.traceOutputStream, getOptionValue(Options.TRACE).bool); asmCodeGenerator.start(); return asmCodeGenerator; case AviatorEvaluator.EVAL: return new OptimizeCodeGenerator(this, classLoader, this.traceOutputStream, getOptionValue(Options.TRACE).bool); default: throw new IllegalArgumentException("Unknow option " + getOptimizeLevel()); } } #location 5 #vulnerability type THREAD_SAFETY_VIOLATION
#fixed code public CodeGenerator newCodeGenerator(final AviatorClassLoader classLoader) { switch (getOptimizeLevel()) { case AviatorEvaluator.COMPILE: ASMCodeGenerator asmCodeGenerator = new ASMCodeGenerator(this, classLoader, this.traceOutputStream); asmCodeGenerator.start(); return asmCodeGenerator; case AviatorEvaluator.EVAL: return new OptimizeCodeGenerator(this, classLoader, this.traceOutputStream); default: throw new IllegalArgumentException("Unknow option " + getOptimizeLevel()); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public void onMethodName(Token<?> lookhead) { String outtterMethodName = "lambda"; if (lookhead.getType() != TokenType.Delegate) { outtterMethodName = lookhead.getLexeme(); String innerMethodName = this.innerMethodMap.get(outtterMethodName); if (innerMethodName != null) { this.loadAviatorFunction(outtterMethodName, innerMethodName); } else { this.createAviatorFunctionObject(outtterMethodName); } } else { this.loadEnv(); this.mv.visitMethodInsn(INVOKESTATIC, "com/googlecode/aviator/runtime/RuntimeUtils", "getFunction", "(Ljava/lang/Object;Ljava/util/Map;)Lcom/googlecode/aviator/runtime/type/AviatorFunction;"); this.popOperand(); } if (this.instance.getOption(Options.TRACE_EVAL)) { this.mv.visitMethodInsn(INVOKESTATIC, "com/googlecode/aviator/runtime/function/TraceFunction", "wrapTrace", "(Lcom/googlecode/aviator/runtime/type/AviatorFunction;)Lcom/googlecode/aviator/runtime/type/AviatorFunction;"); } this.loadEnv(); this.methodMetaDataStack.push(new MethodMetaData(outtterMethodName)); } #location 19 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public void onMethodName(Token<?> lookhead) { String outtterMethodName = "lambda"; if (lookhead.getType() != TokenType.Delegate) { outtterMethodName = lookhead.getLexeme(); String innerMethodName = this.innerMethodMap.get(outtterMethodName); if (innerMethodName != null) { this.loadAviatorFunction(outtterMethodName, innerMethodName); } else { this.createAviatorFunctionObject(outtterMethodName); } } else { this.loadEnv(); this.mv.visitMethodInsn(INVOKESTATIC, "com/googlecode/aviator/runtime/RuntimeUtils", "getFunction", "(Ljava/lang/Object;Ljava/util/Map;)Lcom/googlecode/aviator/runtime/type/AviatorFunction;"); this.popOperand(); } if (this.instance.getOptionValue(Options.TRACE_EVAL).bool) { this.mv.visitMethodInsn(INVOKESTATIC, "com/googlecode/aviator/runtime/function/TraceFunction", "wrapTrace", "(Lcom/googlecode/aviator/runtime/type/AviatorFunction;)Lcom/googlecode/aviator/runtime/type/AviatorFunction;"); } this.loadEnv(); this.methodMetaDataStack.push(new MethodMetaData(outtterMethodName)); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public AviatorObject match(AviatorObject other, Map<String, Object> env) { switch (other.getAviatorType()) { case String: AviatorString aviatorString = (AviatorString) other; Matcher m = this.pattern.matcher(aviatorString.lexeme); if (m.matches()) { boolean captureGroups = RuntimeUtils.getInstance(env).getOption(Options.PUT_CAPTURING_GROUPS_INTO_ENV); if (captureGroups && env != null && env != Collections.EMPTY_MAP) { int groupCount = m.groupCount(); for (int i = 0; i <= groupCount; i++) { env.put("$" + i, m.group(i)); } } return AviatorBoolean.TRUE; } else { return AviatorBoolean.FALSE; } case JavaType: AviatorJavaType javaType = (AviatorJavaType) other; final Object javaValue = javaType.getValue(env); if (TypeUtils.isString(javaValue)) { return this.match(new AviatorString(String.valueOf(javaValue)), env); } else { throw new ExpressionRuntimeException( this.desc(env) + " could not match " + other.desc(env)); } default: throw new ExpressionRuntimeException( this.desc(env) + " could not match " + other.desc(env)); } } #location 9 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public AviatorObject match(AviatorObject other, Map<String, Object> env) { switch (other.getAviatorType()) { case String: AviatorString aviatorString = (AviatorString) other; Matcher m = this.pattern.matcher(aviatorString.lexeme); if (m.matches()) { boolean captureGroups = RuntimeUtils.getInstance(env) .getOptionValue(Options.PUT_CAPTURING_GROUPS_INTO_ENV).bool; if (captureGroups && env != null && env != Collections.EMPTY_MAP) { int groupCount = m.groupCount(); for (int i = 0; i <= groupCount; i++) { env.put("$" + i, m.group(i)); } } return AviatorBoolean.TRUE; } else { return AviatorBoolean.FALSE; } case JavaType: AviatorJavaType javaType = (AviatorJavaType) other; final Object javaValue = javaType.getValue(env); if (TypeUtils.isString(javaValue)) { return this.match(new AviatorString(String.valueOf(javaValue)), env); } else { throw new ExpressionRuntimeException( this.desc(env) + " could not match " + other.desc(env)); } default: throw new ExpressionRuntimeException( this.desc(env) + " could not match " + other.desc(env)); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public CodeGenerator newCodeGenerator(AviatorClassLoader classLoader) { switch (getOptimizeLevel()) { case AviatorEvaluator.COMPILE: ASMCodeGenerator asmCodeGenerator = new ASMCodeGenerator(this, classLoader, traceOutputStream, (Boolean) getOption(Options.TRACE)); asmCodeGenerator.start(); return asmCodeGenerator; case AviatorEvaluator.EVAL: return new OptimizeCodeGenerator(this, classLoader, traceOutputStream, (Boolean) getOption(Options.TRACE)); default: throw new IllegalArgumentException("Unknow option " + getOptimizeLevel()); } } #location 10 #vulnerability type NULL_DEREFERENCE
#fixed code public CodeGenerator newCodeGenerator(AviatorClassLoader classLoader) { switch (getOptimizeLevel()) { case AviatorEvaluator.COMPILE: ASMCodeGenerator asmCodeGenerator = new ASMCodeGenerator(this, classLoader, traceOutputStream, getOptionValue(Options.TRACE).bool); asmCodeGenerator.start(); return asmCodeGenerator; case AviatorEvaluator.EVAL: return new OptimizeCodeGenerator(this, classLoader, traceOutputStream, getOptionValue(Options.TRACE).bool); default: throw new IllegalArgumentException("Unknow option " + getOptimizeLevel()); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public Object getValue(Map<String, Object> env) { if (env != null) { if (this.name.contains(".") && RuntimeUtils.getInstance(env) .<Boolean>getOption(Options.ENABLE_PROPERTY_SYNTAX_SUGAR)) { return getProperty(env); } return env.get(this.name); } return null; } #location 6 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public Object getValue(Map<String, Object> env) { if (env != null) { if (this.name.contains(".") && RuntimeUtils.getInstance(env) .getOptionValue(Options.ENABLE_PROPERTY_SYNTAX_SUGAR).bool) { return getProperty(env); } return env.get(this.name); } return null; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code protected Env genTopEnv(Map<String, Object> map) { Env env = newEnv(map, (boolean) this.instance.getOption(Options.USE_USER_ENV_AS_TOP_ENV_DIRECTLY)); if (this.compileEnv != null && !this.compileEnv.isEmpty()) { env.putAll(this.compileEnv); } return env; } #location 3 #vulnerability type NULL_DEREFERENCE
#fixed code protected Env genTopEnv(Map<String, Object> map) { Env env = newEnv(map, this.instance.getOption(Options.USE_USER_ENV_AS_TOP_ENV_DIRECTLY) == Boolean.TRUE); if (this.compileEnv != null && !this.compileEnv.isEmpty()) { env.putAll(this.compileEnv); } return env; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private File copyToMergedCodebase(String filename, File destFile) { FileSystem fs = Injector.INSTANCE.fileSystem(); File mergedFile = mergedCodebase.getFile(filename); try { fs.makeDirsForFile(mergedFile); fs.copyFile(destFile, mergedFile); return mergedFile; } catch (IOException e) { throw new MoeProblem(e.getMessage()); } } #location 5 #vulnerability type NULL_DEREFERENCE
#fixed code private File copyToMergedCodebase(String filename, File destFile) { File mergedFile = mergedCodebase.getFile(filename); try { filesystem.makeDirsForFile(mergedFile); filesystem.copyFile(destFile, mergedFile); return mergedFile; } catch (IOException e) { throw new MoeProblem(e.getMessage()); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public void generateMergedFile(String filename) { FileSystem fs = Injector.INSTANCE.fileSystem(); File origFile = originalCodebase.getFile(filename); boolean origExists = fs.exists(origFile); File destFile = destinationCodebase.getFile(filename); boolean destExists = fs.exists(destFile); File modFile = modifiedCodebase.getFile(filename); boolean modExists = fs.exists(modFile); if (!destExists && !modExists) { // This should never be thrown since generateMergedFile(...) is only called on filesToMerge // from merge() which is the union of the files in the destination and modified codebases. throw new MoeProblem( "%s doesn't exist in either %s nor %s. This should not be possible.", filename, destinationCodebase, modifiedCodebase); } else if (origExists && modExists && !destExists) { if (areDifferent(filename, origFile, modFile)) { // Proceed and merge in /dev/null, which should produce a merge conflict (incoming edit on // delete). destFile = new File("/dev/null"); } else { // Defer to deletion in destination codebase. return; } } else if (origExists && !modExists && destExists) { // Blindly follow deletion of the original file by not copying it into the merged codebase. return; } else if (!origExists && !(modExists && destExists)) { // File exists only in modified or destination codebase, so just copy it over. File existingFile = (modExists ? modFile : destFile); copyToMergedCodebase(filename, existingFile); return; } else if (!origExists && modExists && destExists) { // Merge both new files (conflict expected). origFile = new File("/dev/null"); } File mergedFile = copyToMergedCodebase(filename, destFile); try { // Merges the changes that lead from origFile to modFile into mergedFile (which is a copy // of destFile). After, mergedFile will have the combined changes of modFile and destFile. Injector.INSTANCE .cmd() .runCommand( "merge", ImmutableList.of( mergedFile.getAbsolutePath(), origFile.getAbsolutePath(), modFile.getAbsolutePath()), this.mergedCodebase.getPath().getAbsolutePath()); // Return status was 0 and the merge was successful. Note it. mergedFiles.add(mergedFile.getAbsolutePath()); } catch (CommandException e) { // If merge fails with exit status 1, then a conflict occurred. Make a note of the filepath. if (e.returnStatus == 1) { failedToMergeFiles.add(mergedFile.getAbsolutePath()); } else { throw new MoeProblem( "Merge returned with unexpected status %d when trying to run \"merge -p %s %s %s\"", e.returnStatus, destFile.getAbsolutePath(), origFile.getAbsolutePath(), modFile.getAbsolutePath()); } } } #location 5 #vulnerability type NULL_DEREFERENCE
#fixed code public void generateMergedFile(String filename) { File origFile = originalCodebase.getFile(filename); boolean origExists = filesystem.exists(origFile); File destFile = destinationCodebase.getFile(filename); boolean destExists = filesystem.exists(destFile); File modFile = modifiedCodebase.getFile(filename); boolean modExists = filesystem.exists(modFile); if (!destExists && !modExists) { // This should never be thrown since generateMergedFile(...) is only called on filesToMerge // from merge() which is the union of the files in the destination and modified codebases. throw new MoeProblem( "%s doesn't exist in either %s nor %s. This should not be possible.", filename, destinationCodebase, modifiedCodebase); } else if (origExists && modExists && !destExists) { if (areDifferent(filename, origFile, modFile)) { // Proceed and merge in /dev/null, which should produce a merge conflict (incoming edit on // delete). destFile = new File("/dev/null"); } else { // Defer to deletion in destination codebase. return; } } else if (origExists && !modExists && destExists) { // Blindly follow deletion of the original file by not copying it into the merged codebase. return; } else if (!origExists && !(modExists && destExists)) { // File exists only in modified or destination codebase, so just copy it over. File existingFile = (modExists ? modFile : destFile); copyToMergedCodebase(filename, existingFile); return; } else if (!origExists && modExists && destExists) { // Merge both new files (conflict expected). origFile = new File("/dev/null"); } File mergedFile = copyToMergedCodebase(filename, destFile); try { // Merges the changes that lead from origFile to modFile into mergedFile (which is a copy // of destFile). After, mergedFile will have the combined changes of modFile and destFile. cmd.runCommand( "merge", ImmutableList.of( mergedFile.getAbsolutePath(), origFile.getAbsolutePath(), modFile.getAbsolutePath()), this.mergedCodebase.getPath().getAbsolutePath()); // Return status was 0 and the merge was successful. Note it. mergedFiles.add(mergedFile.getAbsolutePath()); } catch (CommandException e) { // If merge fails with exit status 1, then a conflict occurred. Make a note of the filepath. if (e.returnStatus == 1) { failedToMergeFiles.add(mergedFile.getAbsolutePath()); } else { throw new MoeProblem( "Merge returned with unexpected status %d when trying to run \"merge -p %s %s %s\"", e.returnStatus, destFile.getAbsolutePath(), origFile.getAbsolutePath(), modFile.getAbsolutePath()); } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Test public void testUpdate() { redisSessionDAO.doCreate(session1); doChangeSessionName(session1, name1); redisSessionDAO.update(session1); FakeSession actualSession = (FakeSession)redisSessionDAO.doReadSession(session1.getId()); assertEquals(actualSession.getName(), name1); } #location 7 #vulnerability type NULL_DEREFERENCE
#fixed code @Test public void testUpdate() { redisSessionDAO.doCreate(session1); redisSessionDAO.doReadSession(session1.getId()); doChangeSessionName(session1, name1); redisSessionDAO.update(session1); FakeSession actualSession = (FakeSession)redisSessionDAO.doReadSession(session1.getId()); assertEquals(actualSession.getName(), name1); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Test public void testRemove() { redisCache.remove(null); FakeSession actualValue = redisCache.remove(testKey); assertThat(actualValue.getId(), is(3)); assertThat(actualValue.getName(), is("jack")); } #location 5 #vulnerability type NULL_DEREFERENCE
#fixed code @Test public void testRemove() throws SerializationException { FakeAuth nullValue = redisCache.remove(null); assertThat(nullValue, is(nullValue())); String testKey = "billy"; byte[] testKeyBytes = keySerializer.serialize(testPrefix + testKey); FakeAuth testValue = new FakeAuth(3, "client"); byte[] testValueBytes = valueSerializer.serialize(testValue); when(redisManager.get(testKeyBytes)).thenReturn(testValueBytes); FakeAuth actualValue = redisCache.remove(testKey); assertThat(actualValue.getId(), is(3)); assertThat(actualValue.getRole(), is("client")); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Test public void testDoReadSession() { Session actualSession = redisSessionDAO.doReadSession(testKey); assertThat(actualSession.getId().toString(), is("3")); redisSessionDAO.doReadSession(null); } #location 4 #vulnerability type NULL_DEREFERENCE
#fixed code @Test public void testDoReadSession() throws NoSuchFieldException, IllegalAccessException { Session nullSession = redisSessionDAO.doReadSession(null); assertThat(nullSession, is(nullValue())); RedisSessionDAO redisSessionDAO2 = new RedisSessionDAO(); redisSessionDAO2.setRedisManager(redisManager); redisSessionDAO2.setKeyPrefix(testPrefix); redisSessionDAO2.setExpire(2); ThreadLocal sessionsInThread = mock(ThreadLocal.class); Map<Serializable, SessionInMemory> sessionMap = new HashMap<Serializable, SessionInMemory>(); SessionInMemory sessionInMemory = new SessionInMemory(); sessionInMemory.setSession(new FakeSession(1, "Billy")); sessionInMemory.setCreateTime(new Date()); sessionMap.put("1", sessionInMemory); when(sessionsInThread.get()).thenReturn(sessionMap); TestUtils.setPrivateField(redisSessionDAO2, "sessionsInThread", sessionsInThread); FakeSession actualSession = (FakeSession)redisSessionDAO2.doReadSession("1"); assertThat(actualSession.getId().toString(), is("1")); assertThat(actualSession.getName(), is("Billy")); verify(redisManager, times(0)).get(any((new byte[0]).getClass())); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static void writeFileTxt(String fileName, String[] totalFile){ FileWriter file = null; PrintWriter pw = null; try { file = new FileWriter(System.getProperty("user.dir")+"/"+fileName); pw = new PrintWriter(file); for (int i = 0; i < totalFile.length; i++) pw.println(totalFile[i]); } catch (Exception e) { e.printStackTrace(); } finally { try { // Execute the "finally" to make sure the file is closed if (null != file) file.close(); } catch (Exception e2) { e2.printStackTrace(); } } } #location 17 #vulnerability type RESOURCE_LEAK
#fixed code public static void writeFileTxt(String fileName, String[] totalFile){ FileWriter file = null; PrintWriter pw = null; try { file = new FileWriter(System.getProperty("user.dir")+"/"+fileName); pw = new PrintWriter(file); for (int i = 0; i < totalFile.length; i++) pw.println(totalFile[i]); } catch (Exception e) { e.printStackTrace(); } finally { try { // Execute the "finally" to make sure the file is closed if (null != file) file.close(); } catch (Exception e2) { e2.printStackTrace(); } try { if (pw != null) pw.close(); } catch (Exception e2) { e2.printStackTrace(); } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static void writeFileTxt(String fileName, String[] totalFile){ FileWriter file = null; PrintWriter pw = null; try { file = new FileWriter(System.getProperty("user.dir")+"/"+fileName); pw = new PrintWriter(file); for (int i = 0; i < totalFile.length; i++) pw.println(totalFile[i]); } catch (Exception e) { e.printStackTrace(); } finally { try { // Execute the "finally" to make sure the file is closed if (null != file) file.close(); } catch (Exception e2) { e2.printStackTrace(); } } } #location 18 #vulnerability type RESOURCE_LEAK
#fixed code public static void writeFileTxt(String fileName, String[] totalFile){ FileWriter file = null; PrintWriter pw = null; try { file = new FileWriter(System.getProperty("user.dir")+"/"+fileName); pw = new PrintWriter(file); for (int i = 0; i < totalFile.length; i++) pw.println(totalFile[i]); } catch (Exception e) { e.printStackTrace(); } finally { try { // Execute the "finally" to make sure the file is closed if (null != file) file.close(); } catch (Exception e2) { e2.printStackTrace(); } try { if (pw != null) pw.close(); } catch (Exception e2) { e2.printStackTrace(); } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public long start(String jobName, Properties params) throws JobStartException, JobSecurityException { final JsrXmlApplicationContext batchContext = new JsrXmlApplicationContext(params); batchContext.setValidating(false); Resource batchXml = new ClassPathResource("/META-INF/batch.xml"); String jobConfigurationLocation = "/META-INF/batch-jobs/" + jobName + ".xml"; Resource jobXml = new ClassPathResource(jobConfigurationLocation); if (batchXml.exists()) { batchContext.load(batchXml); } if (jobXml.exists()) { batchContext.load(jobXml); } AbstractBeanDefinition beanDefinition = BeanDefinitionBuilder .genericBeanDefinition("org.springframework.batch.core.jsr.JsrJobContextFactoryBean") .getBeanDefinition(); beanDefinition.setScope(BeanDefinition.SCOPE_SINGLETON); batchContext.registerBeanDefinition(JSR_JOB_CONTEXT_BEAN_NAME, beanDefinition); batchContext.setParent(parentContext); try { batchContext.refresh(); } catch (BeanCreationException e) { throw new JobStartException(e); } Assert.notNull(jobName, "The job name must not be null."); final org.springframework.batch.core.JobExecution jobExecution; try { JobParameters jobParameters = jobParametersConverter.getJobParameters(params); String[] jobNames = batchContext.getBeanNamesForType(Job.class); if (jobNames == null || jobNames.length <= 0) { throw new BatchRuntimeException("No Job defined in current context"); } org.springframework.batch.core.JobInstance jobInstance = jobRepository.createJobInstance(jobNames[0], jobParameters); jobExecution = jobRepository.createJobExecution(jobInstance, jobParameters, jobConfigurationLocation); } catch (Exception e) { throw new JobStartException(e); } try { final Semaphore semaphore = new Semaphore(1); final List<Exception> exceptionHolder = Collections.synchronizedList(new ArrayList<Exception>()); semaphore.acquire(); taskExecutor.execute(new Runnable() { @Override public void run() { JsrJobContextFactoryBean factoryBean = null; try { factoryBean = (JsrJobContextFactoryBean) batchContext.getBean("&" + JSR_JOB_CONTEXT_BEAN_NAME); factoryBean.setJobExecution(jobExecution); final AbstractJob job = batchContext.getBean(AbstractJob.class); addListenerToJobService.addListenerToJob(job); semaphore.release(); // Initialization of the JobExecution for job level dependencies jobRegistry.register(job, jobExecution); job.execute(jobExecution); jobRegistry.remove(jobExecution); } catch (Exception e) { exceptionHolder.add(e); } finally { if (factoryBean != null) { factoryBean.close(); } batchContext.close(); if (semaphore.availablePermits() == 0) { semaphore.release(); } } } }); semaphore.acquire(); if (exceptionHolder.size() > 0) { semaphore.release(); throw new JobStartException(exceptionHolder.get(0)); } } catch (Exception e) { if (jobRegistry.exists(jobExecution.getId())) { jobRegistry.remove(jobExecution); } jobExecution.upgradeStatus(BatchStatus.FAILED); if (jobExecution.getExitStatus().equals(ExitStatus.UNKNOWN)) { jobExecution.setExitStatus(ExitStatus.FAILED.addExitDescription(e)); } jobRepository.update(jobExecution); if (batchContext.isActive()) { batchContext.close(); } throw new JobStartException(e); } return jobExecution.getId(); } #location 102 #vulnerability type RESOURCE_LEAK
#fixed code @Override public long start(String jobName, Properties params) throws JobStartException, JobSecurityException { final JsrXmlApplicationContext batchContext = new JsrXmlApplicationContext(params); batchContext.setValidating(false); Resource batchXml = new ClassPathResource("/META-INF/batch.xml"); String jobConfigurationLocation = "/META-INF/batch-jobs/" + jobName + ".xml"; Resource jobXml = new ClassPathResource(jobConfigurationLocation); if (batchXml.exists()) { batchContext.load(batchXml); } if (jobXml.exists()) { batchContext.load(jobXml); } AbstractBeanDefinition beanDefinition = BeanDefinitionBuilder .genericBeanDefinition("org.springframework.batch.core.jsr.JsrJobContextFactoryBean") .getBeanDefinition(); beanDefinition.setScope(BeanDefinition.SCOPE_SINGLETON); batchContext.registerBeanDefinition(JSR_JOB_CONTEXT_BEAN_NAME, beanDefinition); batchContext.setParent(parentContext); try { batchContext.refresh(); } catch (BeanCreationException e) { throw new JobStartException(e); } Assert.notNull(jobName, "The job name must not be null."); final org.springframework.batch.core.JobExecution jobExecution; try { JobParameters jobParameters = jobParametersConverter.getJobParameters(params); String[] jobNames = batchContext.getBeanNamesForType(Job.class); if (jobNames == null || jobNames.length <= 0) { throw new BatchRuntimeException("No Job defined in current context"); } org.springframework.batch.core.JobInstance jobInstance = jobRepository.createJobInstance(jobNames[0], jobParameters); jobExecution = jobRepository.createJobExecution(jobInstance, jobParameters, jobConfigurationLocation); } catch (Exception e) { throw new JobStartException(e); } try { final Semaphore semaphore = new Semaphore(1); final List<Exception> exceptionHolder = Collections.synchronizedList(new ArrayList<Exception>()); semaphore.acquire(); taskExecutor.execute(() -> { JsrJobContextFactoryBean factoryBean = null; try { factoryBean = (JsrJobContextFactoryBean) batchContext.getBean("&" + JSR_JOB_CONTEXT_BEAN_NAME); factoryBean.setJobExecution(jobExecution); final AbstractJob job = batchContext.getBean(AbstractJob.class); addListenerToJobService.addListenerToJob(job); semaphore.release(); // Initialization of the JobExecution for job level dependencies jobRegistry.register(job, jobExecution); job.execute(jobExecution); jobRegistry.remove(jobExecution); } catch (Exception e) { exceptionHolder.add(e); } finally { if (factoryBean != null) { factoryBean.close(); } batchContext.close(); if (semaphore.availablePermits() == 0) { semaphore.release(); } } }); semaphore.acquire(); if (!exceptionHolder.isEmpty()) { semaphore.release(); throw new JobStartException(exceptionHolder.get(0)); } } catch (Exception e) { if (jobRegistry.exists(jobExecution.getId())) { jobRegistry.remove(jobExecution); } jobExecution.upgradeStatus(BatchStatus.FAILED); if (jobExecution.getExitStatus().equals(ExitStatus.UNKNOWN)) { jobExecution.setExitStatus(ExitStatus.FAILED.addExitDescription(e)); } jobRepository.update(jobExecution); if (batchContext.isActive()) { batchContext.close(); } throw new JobStartException(e); } return jobExecution.getId(); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private void recoveryFromLog() { MasterLogReader reader; synchronized (mDatasets) { File file = new File(Config.MASTER_CHECKPOINT_FILE); if (!file.exists()) { LOG.info("Master Checkpoint file " + Config.MASTER_CHECKPOINT_FILE + " does not exist."); } else { reader = new MasterLogReader(Config.MASTER_CHECKPOINT_FILE); while (reader.hasNext()) { DatasetInfo dataset = reader.getNextDatasetInfo(); mDatasets.put(dataset.mId, dataset); mDatasetPathToId.put(dataset.mPath, dataset.mId); } } file = new File(Config.MASTER_LOG_FILE); if (!file.exists()) { LOG.info("Master Log file " + Config.MASTER_LOG_FILE + " does not exist."); } else { reader = new MasterLogReader(Config.MASTER_LOG_FILE); while (reader.hasNext()) { DatasetInfo dataset = reader.getNextDatasetInfo(); if (dataset.mId > 0) { mDatasets.put(dataset.mId, dataset); mDatasetPathToId.put(dataset.mPath, dataset.mId); } else { mDatasets.remove(-dataset.mId); mDatasetPathToId.remove(dataset.mPath); } } } } } #location 13 #vulnerability type RESOURCE_LEAK
#fixed code private void recoveryFromLog() { synchronized (mDatasets) { recoveryFromFile(Config.MASTER_CHECKPOINT_FILE, "Master Checkpoint file "); recoveryFromFile(Config.MASTER_LOG_FILE, "Master Log file "); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private void evaluateStatement(Object target, TemporaryFolder temporaryFolder, Statement base) throws Throwable { container = null; setAndCheckIfWritable(temporaryFolder); try { LOGGER.info("Setting up {} in {}", getName(), temporaryFolder.getRoot().getAbsolutePath()); container = createHiveServerContainer(target, temporaryFolder); base.evaluate(); } finally { tearDown(); } } #location 3 #vulnerability type NULL_DEREFERENCE
#fixed code private void evaluateStatement(Object target, TemporaryFolder temporaryFolder, Statement base) throws Throwable { container = null; FileUtil.setPermission(temporaryFolder.getRoot(), FsPermission.getDirDefault()); try { LOGGER.info("Setting up {} in {}", getName(), temporaryFolder.getRoot().getAbsolutePath()); container = createHiveServerContainer(target, temporaryFolder); base.evaluate(); } finally { tearDown(); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public String serialize(String data) { try { AbiBin abiBin = new AbiBin(); JSONObject res = abiBin.request(RequestParams.of(netParams, () -> data)); return res.getString("binargs"); } catch (JSONException ex) { throw new IllegalArgumentException(String.format("Invalid json \"%s\" passed in.", data), ex); } catch (ApiResponseException ex) { throw new AbiSerialisationFailureException(ex.getRaw().toString(), ex); } } #location 10 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public String serialize(String data) { try { AbiBin abiBin = new AbiBin(); JSONObject res = abiBin.request(RequestParams.of(netParams, () -> data)); return res.getString("binargs"); } catch (JSONException ex) { throw new IllegalArgumentException(String.format("Invalid json \"%s\" passed in.", data), ex); } catch (ApiResponseException ex) { throw new AbiSerialisationFailureException("Failed to serialize via node", ex); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public JSONObject getInfo() throws EvtSdkException { Info info = new Info(); return info.get(netParams, null); } #location 3 #vulnerability type NULL_DEREFERENCE
#fixed code public JSONObject getInfo() throws EvtSdkException { Info info = new Info(); return info.get(RequestParams.of(netParams)); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public JSONObject getHeadBlockHeaderState() throws EvtSdkException { HeadBlockHeaderState headBlockHeaderState = new HeadBlockHeaderState(); return headBlockHeaderState.get(netParams, null); } #location 3 #vulnerability type NULL_DEREFERENCE
#fixed code public JSONObject getHeadBlockHeaderState() throws EvtSdkException { HeadBlockHeaderState headBlockHeaderState = new HeadBlockHeaderState(); return headBlockHeaderState.get(RequestParams.of(netParams)); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static float[] getMedianErrorRates(LangDescriptor language, int maxNumFiles, int trials) throws Exception { SubsetValidator validator = new SubsetValidator(language.corpusDir, language); List<InputDocument> documents = load(validator.allFiles, language); float[] medians = new float[maxNumFiles+1]; for (int i = 1; i<=Math.min(validator.allFiles.size(), maxNumFiles); i++) { // i is corpus subset size List<Float> errorRates = new ArrayList<>(); for (int trial = 1; trial<=trials; trial++) { // multiple trials per subset size Pair<InputDocument, List<InputDocument>> sample = validator.selectSample(documents, i); Triple<Formatter, Float, Float> results = validate(language, sample.b, sample.a, true, false); System.out.println(sample.a.fileName+" n="+i+": error="+results.c); // System.out.println("\tcorpus =\n\t\t"+Utils.join(sample.b.iterator(), "\n\t\t")); errorRates.add(results.c); } Collections.sort(errorRates); int n = errorRates.size(); float min = errorRates.get(0); float quart = errorRates.get((int)(0.27*n)); float median = errorRates.get(n/2); float quart3 = errorRates.get((int)(0.75*n)); float max = errorRates.get(n-1); System.out.println("median error rate for n="+i+" is "+median); medians[i] = median; } return medians; } #location 9 #vulnerability type NULL_DEREFERENCE
#fixed code public static float[] getMedianErrorRates(LangDescriptor language, int maxNumFiles, int trials) throws Exception { SubsetValidator validator = new SubsetValidator(language.corpusDir, language); List<InputDocument> documents = load(validator.allFiles, language); float[] medians = new float[maxNumFiles+1]; int ncpu = Runtime.getRuntime().availableProcessors(); ExecutorService pool = Executors.newFixedThreadPool(3); // works with 2 but not 3 threads. hmm... List<Callable<Void>> jobs = new ArrayList<>(); for (int i = 1; i<=Math.min(validator.allFiles.size(), maxNumFiles); i++) { // i is corpus subset size final int corpusSubsetSize = i; Callable<Void> job = () -> { try { List<Float> errorRates = new ArrayList<>(); for (int trial = 1; trial<=trials; trial++) { // multiple trials per subset size Pair<InputDocument, List<InputDocument>> sample = validator.selectSample(documents, corpusSubsetSize); Triple<Formatter, Float, Float> results = validate(language, sample.b, sample.a, true, false); // System.out.println(sample.a.fileName+" n="+corpusSubsetSize+": error="+results.c); // System.out.println("\tcorpus =\n\t\t"+Utils.join(sample.b.iterator(), "\n\t\t")); errorRates.add(results.c); } Collections.sort(errorRates); int n = errorRates.size(); float median = errorRates.get(n/2); System.out.println("median "+language.name+" error rate for n="+corpusSubsetSize+" is "+median); medians[corpusSubsetSize] = median; } catch (Throwable t) { t.printStackTrace(System.err); } return null; }; jobs.add(job); } pool.invokeAll(jobs); pool.shutdown(); boolean terminated = pool.awaitTermination(60, TimeUnit.MINUTES); System.err.println(language.name+" terminate properly = "+terminated); return medians; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static void main(String[] args) throws Exception { LangDescriptor[] languages = new LangDescriptor[] { JAVA_DESCR, // JAVA8_DESCR, ANTLR4_DESCR, // SQLITE_NOISY_DESCR, // SQLITE_CLEAN_DESCR, // TSQL_NOISY_DESCR, // TSQL_CLEAN_DESCR, }; Map<String,Map<String, Float>> langToFeatureMedians = new HashMap<>(); List<String> labels = new ArrayList<>(); labels.add("curated"); labels.add("all-in"); for (FeatureMetaData f : FEATURES_ALL) { labels.add(Utils.join(f.abbrevHeaderRows, " ")); } for (LangDescriptor language : languages) { System.out.println("###### "+language.name); Map<String, Float> featureToErrors = new LinkedHashMap<>(); FeatureMetaData[] injectWSFeatures = deepCopy(FEATURES_ALL); FeatureMetaData[] alignmentFeatures = deepCopy(FEATURES_ALIGN); // do it first to get answer with curated features List<Float> errors = getErrorRates(language, FEATURES_INJECT_WS, alignmentFeatures); Collections.sort(errors); int n = errors.size(); float quart = errors.get((int)(0.27*n)); float median = errors.get(n/2); float quart3 = errors.get((int)(0.75*n)); System.out.println("curated error median "+median); featureToErrors.put("curated", median); // do it again to get answer with all features errors = getErrorRates(language, FEATURES_ALL, alignmentFeatures); Collections.sort(errors); n = errors.size(); median = errors.get(n/2); System.out.println("all-in error median "+median); featureToErrors.put("all-in", median); for (FeatureMetaData feature : injectWSFeatures) { if ( feature==FeatureMetaData.UNUSED || feature.type.toString().startsWith("INFO_") ) continue; String name = Utils.join(feature.abbrevHeaderRows, " "); labels.add(name.trim()); System.out.println("wack "+name); double saveCost = feature.mismatchCost; feature.mismatchCost = 0; // wack this feature errors = getErrorRates(language, injectWSFeatures, alignmentFeatures); Collections.sort(errors); n = errors.size(); median = errors.get(n/2); featureToErrors.put(name, median); System.out.println("median error rates "+median); // reset feature feature.mismatchCost = saveCost; } System.out.println(featureToErrors); langToFeatureMedians.put(language.name, featureToErrors); } String python = "#\n"+ "# AUTO-GENERATED FILE. DO NOT EDIT\n" + "# CodeBuff <version> '<date>'\n" + "#\n"+ "import numpy as np\n"+ "import matplotlib.pyplot as plt\n\n" + "fig = plt.figure()\n"+ "ax = plt.subplot(111)\n"+ "N = <numFeatures>\n" + "featureIndexes = range(0,N)\n" + "<langToMedians:{r |\n" + "<r> = [<langToMedians.(r); separator={, }>]\n"+ "ax.plot(featureIndexes, <r>, label=\"<r>\")\n" + "}>\n" + "labels = [<labels:{l | '<l>'}; separator={, }>]\n" + "ax.set_xticklabels(labels, rotation=60, fontsize=8)\n"+ "plt.xticks(featureIndexes, labels, rotation=60)\n" + "ax.yaxis.grid(True, linestyle='-', which='major', color='lightgrey', alpha=0.5)\n\n" + "ax.set_xlabel(\"Inject Whitespace Feature\")\n"+ "ax.set_ylabel(\"Median Error rate\")\n" + "ax.set_title(\"Effect of Dropping One Feature on Whitespace Decision\\nMedian Leave-one-out Validation Error Rate\")\n"+ "plt.legend()\n" + "plt.tight_layout()\n" + "plt.show()\n"; ST pythonST = new ST(python); Map<String,Collection<Float>> langToMedians = new HashMap<>(); int numFeatures = 0; for (String s : langToFeatureMedians.keySet()) { Map<String, Float> featureToErrors = langToFeatureMedians.get(s); langToMedians.put(s, featureToErrors.values()); numFeatures = featureToErrors.values().size(); } pythonST.add("langToMedians", langToMedians); pythonST.add("version", version); pythonST.add("date", new Date()); pythonST.add("numFeatures", numFeatures); pythonST.add("labels", labels); String code = pythonST.render(); String fileName = "python/src/drop_one_feature.py"; Utils.writeFile(fileName, code); System.out.println("wrote python code to "+fileName); } #location 30 #vulnerability type NULL_DEREFERENCE
#fixed code public static void main(String[] args) throws Exception { LangDescriptor[] languages = new LangDescriptor[] { JAVA_DESCR, // JAVA8_DESCR, ANTLR4_DESCR, // SQLITE_NOISY_DESCR, // SQLITE_CLEAN_DESCR, // TSQL_NOISY_DESCR, // TSQL_CLEAN_DESCR, }; testFeatures(languages, false); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public void trainOnSampleDocs() throws Exception { documentsPerExemplar = new ArrayList<>(); featureVectors = new ArrayList<>(); injectWhitespace = new ArrayList<>(); hpos = new ArrayList<>(); for (InputDocument doc : documents) { if ( showFileNames ) System.out.println(doc); Triple<List<int[]>, List<Integer>, List<Integer>> results = process(doc); List<int[]> features = results.a; List<Integer> ws = results.b; List<Integer> al = results.c; for (int i=0; i<features.size(); i++) { documentsPerExemplar.add(doc); int[] featureVec = features.get(i); injectWhitespace.add(ws.get(i)); hpos.add(al.get(i)); featureVectors.add(featureVec); } } } #location 14 #vulnerability type NULL_DEREFERENCE
#fixed code public void trainOnSampleDocs() throws Exception { documentsPerExemplar = new ArrayList<>(); featureVectors = new ArrayList<>(); injectWhitespace = new ArrayList<>(); hpos = new ArrayList<>(); for (InputDocument doc : documents) { if ( showFileNames ) System.out.println(doc); // Parse document, save feature vectors to the doc Trainer trainer = new Trainer(this, doc, language.indentSize); trainer.computeFeatureVectors(); } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public PageResult<TokenVo> listTokens(Map<String, Object> params, String clientId) { Integer page = MapUtils.getInteger(params, "page"); Integer limit = MapUtils.getInteger(params, "limit"); int[] startEnds = PageUtil.transToStartEnd(page, limit); //根据请求参数生成redis的key String redisKey = getRedisKey(params, clientId); long size = redisRepository.length(redisKey); List<TokenVo> result = new ArrayList<>(limit); //查询token集合 List<Object> tokenObjs = redisRepository.getList(redisKey, startEnds[0], startEnds[1]-1); if (tokenObjs != null) { for (Object obj : tokenObjs) { DefaultOAuth2AccessToken accessToken = (DefaultOAuth2AccessToken)obj; //构造token对象 TokenVo tokenVo = new TokenVo(); tokenVo.setTokenValue(accessToken.getValue()); tokenVo.setExpiration(accessToken.getExpiration()); //获取用户信息 Object authObj = redisRepository.get(SecurityConstants.REDIS_TOKEN_AUTH + accessToken.getValue()); OAuth2Authentication authentication = (OAuth2Authentication)authObj; if (authentication != null) { OAuth2Request request = authentication.getOAuth2Request(); tokenVo.setUsername(authentication.getName()); tokenVo.setClientId(request.getClientId()); tokenVo.setGrantType(request.getGrantType()); } result.add(tokenVo); } } return PageResult.<TokenVo>builder().data(result).code(0).count(size).build(); } #location 8 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public PageResult<TokenVo> listTokens(Map<String, Object> params, String clientId) { Integer page = MapUtils.getInteger(params, "page"); Integer limit = MapUtils.getInteger(params, "limit"); int[] startEnds = PageUtil.transToStartEnd(page, limit); //根据请求参数生成redis的key String redisKey = getRedisKey(params, clientId); long size = redisRepository.length(redisKey); List<TokenVo> result = new ArrayList<>(limit); RedisSerializer<Object> valueSerializer = RedisSerializer.java(); //查询token集合 //redisRepository.getRedisTemplate().e List<Object> tokenObjs = redisRepository.getList(redisKey, startEnds[0], startEnds[1]-1, valueSerializer); if (tokenObjs != null) { for (Object obj : tokenObjs) { DefaultOAuth2AccessToken accessToken = (DefaultOAuth2AccessToken)obj; //构造token对象 TokenVo tokenVo = new TokenVo(); tokenVo.setTokenValue(accessToken.getValue()); tokenVo.setExpiration(accessToken.getExpiration()); //获取用户信息 Object authObj = redisRepository.get(SecurityConstants.REDIS_TOKEN_AUTH + accessToken.getValue(), valueSerializer); OAuth2Authentication authentication = (OAuth2Authentication)authObj; if (authentication != null) { OAuth2Request request = authentication.getOAuth2Request(); tokenVo.setUsername(authentication.getName()); tokenVo.setClientId(request.getClientId()); tokenVo.setGrantType(request.getGrantType()); } result.add(tokenVo); } } return PageResult.<TokenVo>builder().data(result).code(0).count(size).build(); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code private ObjectNode getDataNode(Object object, Map<String, ObjectNode> includedContainer, SerializationSettings settings) throws IllegalAccessException { ObjectNode dataNode = objectMapper.createObjectNode(); // Perform initial conversion ObjectNode attributesNode = objectMapper.valueToTree(object); // Handle id, meta and relationship fields Field idField = configuration.getIdField(object.getClass()); JsonNode id = attributesNode.remove(idField.getName()); // Handle meta Field metaField = configuration.getMetaField(object.getClass()); if (metaField != null) { JsonNode meta = attributesNode.remove(metaField.getName()); if (meta != null && shouldSerializeMeta(settings)) { dataNode.set(META, meta); } } // Handle links JsonNode jsonLinks = getResourceLinks(object, attributesNode, id.textValue(), settings); String selfHref = null; if (jsonLinks != null) { dataNode.set(LINKS, jsonLinks); if (jsonLinks.has(SELF)) { selfHref = jsonLinks.get(SELF).get(HREF).asText(); } } // Handle resource identifier dataNode.put(TYPE, configuration.getTypeName(object.getClass())); String resourceId = (String) idField.get(object); if (resourceId != null) { dataNode.put(ID, resourceId); // Cache the object for recursion breaking purposes resourceCache.cache(resourceId.concat(configuration.getTypeName(object.getClass())), null); } dataNode.set(ATTRIBUTES, attributesNode); // Handle relationships (remove from base type and add as relationships) List<Field> relationshipFields = configuration.getRelationshipFields(object.getClass()); if (relationshipFields != null) { ObjectNode relationshipsNode = objectMapper.createObjectNode(); for (Field relationshipField : relationshipFields) { Object relationshipObject = relationshipField.get(object); if (relationshipObject != null) { attributesNode.remove(relationshipField.getName()); Relationship relationship = configuration.getFieldRelationship(relationshipField); // In case serialisation is disabled for a given relationship, skip it if (!relationship.serialise()) { continue; } String relationshipName = relationship.value(); ObjectNode relationshipDataNode = objectMapper.createObjectNode(); relationshipsNode.set(relationshipName, relationshipDataNode); // Serialize relationship meta JsonNode relationshipMeta = getRelationshipMeta(object, relationshipName, settings); if (relationshipMeta != null) { relationshipDataNode.set(META, relationshipMeta); attributesNode.remove(configuration .getRelationshipMetaField(object.getClass(), relationshipName).getName()); } // Serialize relationship links JsonNode relationshipLinks = getRelationshipLinks(object, relationship, selfHref, settings); if (relationshipLinks != null) { relationshipDataNode.set(LINKS, relationshipLinks); // Remove link object from serialized JSON Field refField = configuration .getRelationshipLinksField(object.getClass(), relationshipName); if (refField != null) { attributesNode.remove(refField.getName()); } } if (relationshipObject instanceof Collection) { ArrayNode dataArrayNode = objectMapper.createArrayNode(); for (Object element : (Collection<?>) relationshipObject) { String relationshipType = configuration.getTypeName(element.getClass()); String idValue = (String) configuration.getIdField(element.getClass()).get(element); ObjectNode identifierNode = objectMapper.createObjectNode(); identifierNode.put(TYPE, relationshipType); identifierNode.put(ID, idValue); dataArrayNode.add(identifierNode); // Handle included data if (shouldSerializeRelationship(relationshipName, settings) && idValue != null) { String identifier = idValue.concat(relationshipType); if (!includedContainer.containsKey(identifier) && !resourceCache.contains(identifier)) { includedContainer.put(identifier, getDataNode(element, includedContainer, settings)); } } } relationshipDataNode.set(DATA, dataArrayNode); } else { String relationshipType = configuration.getTypeName(relationshipObject.getClass()); String idValue = (String) configuration.getIdField(relationshipObject.getClass()) .get(relationshipObject); ObjectNode identifierNode = objectMapper.createObjectNode(); identifierNode.put(TYPE, relationshipType); identifierNode.put(ID, idValue); relationshipDataNode.set(DATA, identifierNode); if (shouldSerializeRelationship(relationshipName, settings) && idValue != null) { String identifier = idValue.concat(relationshipType); if (!includedContainer.containsKey(identifier)) { includedContainer.put(identifier, getDataNode(relationshipObject, includedContainer, settings)); } } } } } if (relationshipsNode.size() > 0) { dataNode.set(RELATIONSHIPS, relationshipsNode); } } return dataNode; } #location 22 #vulnerability type NULL_DEREFERENCE
#fixed code private ObjectNode getDataNode(Object object, Map<String, ObjectNode> includedContainer, SerializationSettings settings) throws IllegalAccessException { ObjectNode dataNode = objectMapper.createObjectNode(); // Perform initial conversion ObjectNode attributesNode = objectMapper.valueToTree(object); // Handle id, meta and relationship fields Field idField = configuration.getIdField(object.getClass()); JsonNode id = attributesNode.remove(idField.getName()); // Handle meta Field metaField = configuration.getMetaField(object.getClass()); if (metaField != null) { JsonNode meta = attributesNode.remove(metaField.getName()); if (meta != null && shouldSerializeMeta(settings)) { dataNode.set(META, meta); } } // Handle links String selfHref = null; JsonNode jsonLinks = getResourceLinks(object, attributesNode, id, settings); if (jsonLinks != null) { dataNode.set(LINKS, jsonLinks); if (jsonLinks.has(SELF)) { selfHref = jsonLinks.get(SELF).get(HREF).asText(); } } // Handle resource identifier dataNode.put(TYPE, configuration.getTypeName(object.getClass())); String resourceId = (String) idField.get(object); if (resourceId != null) { dataNode.put(ID, resourceId); // Cache the object for recursion breaking purposes resourceCache.cache(resourceId.concat(configuration.getTypeName(object.getClass())), null); } dataNode.set(ATTRIBUTES, attributesNode); // Handle relationships (remove from base type and add as relationships) List<Field> relationshipFields = configuration.getRelationshipFields(object.getClass()); if (relationshipFields != null) { ObjectNode relationshipsNode = objectMapper.createObjectNode(); for (Field relationshipField : relationshipFields) { Object relationshipObject = relationshipField.get(object); if (relationshipObject != null) { attributesNode.remove(relationshipField.getName()); Relationship relationship = configuration.getFieldRelationship(relationshipField); // In case serialisation is disabled for a given relationship, skip it if (!relationship.serialise()) { continue; } String relationshipName = relationship.value(); ObjectNode relationshipDataNode = objectMapper.createObjectNode(); relationshipsNode.set(relationshipName, relationshipDataNode); // Serialize relationship meta JsonNode relationshipMeta = getRelationshipMeta(object, relationshipName, settings); if (relationshipMeta != null) { relationshipDataNode.set(META, relationshipMeta); attributesNode.remove(configuration .getRelationshipMetaField(object.getClass(), relationshipName).getName()); } // Serialize relationship links JsonNode relationshipLinks = getRelationshipLinks(object, relationship, selfHref, settings); if (relationshipLinks != null) { relationshipDataNode.set(LINKS, relationshipLinks); // Remove link object from serialized JSON Field refField = configuration .getRelationshipLinksField(object.getClass(), relationshipName); if (refField != null) { attributesNode.remove(refField.getName()); } } if (relationshipObject instanceof Collection) { ArrayNode dataArrayNode = objectMapper.createArrayNode(); for (Object element : (Collection<?>) relationshipObject) { String relationshipType = configuration.getTypeName(element.getClass()); String idValue = (String) configuration.getIdField(element.getClass()).get(element); ObjectNode identifierNode = objectMapper.createObjectNode(); identifierNode.put(TYPE, relationshipType); identifierNode.put(ID, idValue); dataArrayNode.add(identifierNode); // Handle included data if (shouldSerializeRelationship(relationshipName, settings) && idValue != null) { String identifier = idValue.concat(relationshipType); if (!includedContainer.containsKey(identifier) && !resourceCache.contains(identifier)) { includedContainer.put(identifier, getDataNode(element, includedContainer, settings)); } } } relationshipDataNode.set(DATA, dataArrayNode); } else { String relationshipType = configuration.getTypeName(relationshipObject.getClass()); String idValue = (String) configuration.getIdField(relationshipObject.getClass()) .get(relationshipObject); ObjectNode identifierNode = objectMapper.createObjectNode(); identifierNode.put(TYPE, relationshipType); identifierNode.put(ID, idValue); relationshipDataNode.set(DATA, identifierNode); if (shouldSerializeRelationship(relationshipName, settings) && idValue != null) { String identifier = idValue.concat(relationshipType); if (!includedContainer.containsKey(identifier)) { includedContainer.put(identifier, getDataNode(relationshipObject, includedContainer, settings)); } } } } } if (relationshipsNode.size() > 0) { dataNode.set(RELATIONSHIPS, relationshipsNode); } } return dataNode; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code protected void assertSuccessfulAuthentication(String providerId) { this.driver.navigate().to("http://localhost:8081/test-app/"); assertTrue(this.driver.getCurrentUrl().startsWith("http://localhost:8081/auth/realms/realm-with-broker/protocol/openid-connect/login")); // choose the identity provider this.loginPage.clickSocial(providerId); assertTrue(this.driver.getCurrentUrl().startsWith("http://localhost:8082/auth/realms/realm-with-saml-identity-provider/protocol/saml")); // log in to identity provider this.loginPage.login("saml.user", "password"); assertTrue(this.driver.getCurrentUrl().startsWith("http://localhost:8081/auth/broker/realm-with-broker/" + providerId)); // update profile this.updateProfilePage.assertCurrent(); String userEmail = "[email protected]"; String userFirstName = "New first"; String userLastName = "New last"; this.updateProfilePage.update(userFirstName, userLastName, userEmail); // authenticated and redirected to app assertTrue(this.driver.getCurrentUrl().startsWith("http://localhost:8081/test-app/")); KeycloakSession samlServerSession = brokerServerRule.startSession(); RealmModel brokerRealm = samlServerSession.realms().getRealm("realm-with-broker"); UserModel federatedUser = samlServerSession.users().getUserByEmail(userEmail, brokerRealm); // user created assertNotNull(federatedUser); assertEquals(userFirstName, federatedUser.getFirstName()); assertEquals(userLastName, federatedUser.getLastName()); driver.navigate().to("http://localhost:8081/test-app/logout"); driver.navigate().to("http://localhost:8081/test-app/"); assertTrue(this.driver.getCurrentUrl().startsWith("http://localhost:8081/auth/realms/realm-with-broker/protocol/openid-connect/login")); // choose the identity provider this.loginPage.clickSocial(providerId); // already authenticated in saml idp and redirected to app assertTrue(this.driver.getCurrentUrl().startsWith("http://localhost:8081/test-app/")); } #location 35 #vulnerability type NULL_DEREFERENCE
#fixed code protected void assertSuccessfulAuthentication(String providerId) { this.driver.navigate().to("http://localhost:8081/test-app/"); assertTrue(this.driver.getCurrentUrl().startsWith("http://localhost:8081/auth/realms/realm-with-broker/protocol/openid-connect/login")); // choose the identity provider this.loginPage.clickSocial(providerId); assertTrue(this.driver.getCurrentUrl().startsWith("http://localhost:8082/auth/")); // log in to identity provider this.loginPage.login("test-user", "password"); doAfterProviderAuthentication(providerId); doUpdateProfile(providerId); // authenticated and redirected to app assertTrue(this.driver.getCurrentUrl().startsWith("http://localhost:8081/test-app/")); assertNotNull(retrieveSessionStatus()); doAssertFederatedUser(providerId); driver.navigate().to("http://localhost:8081/test-app/logout"); driver.navigate().to("http://localhost:8081/test-app/"); assertTrue(this.driver.getCurrentUrl().startsWith("http://localhost:8081/auth/realms/realm-with-broker/protocol/openid-connect/login")); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public AuthenticationMechanismOutcome authenticate(HttpServerExchange exchange, SecurityContext securityContext) { BearerTokenAuthenticator bearer = createBearerTokenAuthenticator(); AuthenticationMechanismOutcome outcome = bearer.authenticate(exchange); if (outcome == AuthenticationMechanismOutcome.NOT_AUTHENTICATED) { exchange.putAttachment(KEYCLOAK_CHALLENGE_ATTACHMENT_KEY, bearer.getChallenge()); return AuthenticationMechanismOutcome.NOT_AUTHENTICATED; } else if (outcome == AuthenticationMechanismOutcome.AUTHENTICATED) { final AccessToken token = bearer.getToken(); String surrogate = bearer.getSurrogate(); KeycloakAuthenticatedSession session = new KeycloakAuthenticatedSession(bearer.getTokenString(), token, resourceMetadata); KeycloakPrincipal principal = completeAuthentication(securityContext, token, surrogate); propagateBearer(exchange, session, principal); return AuthenticationMechanismOutcome.AUTHENTICATED; } else if (adapterConfig.isBearerOnly()) { exchange.putAttachment(KEYCLOAK_CHALLENGE_ATTACHMENT_KEY, bearer.getChallenge()); return AuthenticationMechanismOutcome.NOT_ATTEMPTED; } OAuthAuthenticator oauth = createOAuthAuthenticator(exchange); outcome = oauth.authenticate(); if (outcome == AuthenticationMechanismOutcome.NOT_AUTHENTICATED) { exchange.putAttachment(KEYCLOAK_CHALLENGE_ATTACHMENT_KEY, oauth.getChallenge()); return AuthenticationMechanismOutcome.NOT_AUTHENTICATED; } else if (outcome == AuthenticationMechanismOutcome.NOT_ATTEMPTED) { exchange.putAttachment(KEYCLOAK_CHALLENGE_ATTACHMENT_KEY, oauth.getChallenge()); return AuthenticationMechanismOutcome.NOT_ATTEMPTED; } KeycloakAuthenticatedSession session = new KeycloakAuthenticatedSession(oauth.getTokenString(), oauth.getToken(), resourceMetadata); KeycloakPrincipal principal = completeAuthentication(securityContext, oauth.getToken(), null); propagateOauth(exchange, session, principal); log.info("AUTHENTICATED"); return AuthenticationMechanismOutcome.AUTHENTICATED; } #location 13 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public AuthenticationMechanismOutcome authenticate(HttpServerExchange exchange, SecurityContext securityContext) { BearerTokenAuthenticator bearer = createBearerTokenAuthenticator(); AuthenticationMechanismOutcome outcome = bearer.authenticate(exchange); if (outcome == AuthenticationMechanismOutcome.NOT_AUTHENTICATED) { exchange.putAttachment(KEYCLOAK_CHALLENGE_ATTACHMENT_KEY, bearer.getChallenge()); return AuthenticationMechanismOutcome.NOT_AUTHENTICATED; } else if (outcome == AuthenticationMechanismOutcome.AUTHENTICATED) { completeAuthentication(securityContext, bearer); return AuthenticationMechanismOutcome.AUTHENTICATED; } else if (adapterConfig.isBearerOnly()) { exchange.putAttachment(KEYCLOAK_CHALLENGE_ATTACHMENT_KEY, bearer.getChallenge()); return AuthenticationMechanismOutcome.NOT_ATTEMPTED; } OAuthAuthenticator oauth = createOAuthAuthenticator(exchange); outcome = oauth.authenticate(); if (outcome == AuthenticationMechanismOutcome.NOT_AUTHENTICATED) { exchange.putAttachment(KEYCLOAK_CHALLENGE_ATTACHMENT_KEY, oauth.getChallenge()); return AuthenticationMechanismOutcome.NOT_AUTHENTICATED; } else if (outcome == AuthenticationMechanismOutcome.NOT_ATTEMPTED) { exchange.putAttachment(KEYCLOAK_CHALLENGE_ATTACHMENT_KEY, oauth.getChallenge()); return AuthenticationMechanismOutcome.NOT_ATTEMPTED; } completeAuthentication(securityContext, oauth); log.info("AUTHENTICATED"); return AuthenticationMechanismOutcome.AUTHENTICATED; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Path("{username}/session-stats") @GET @NoCache @Produces(MediaType.APPLICATION_JSON) public Map<String, UserStats> getSessionStats(final @PathParam("username") String username) { logger.info("session-stats"); auth.requireView(); UserModel user = realm.getUser(username); if (user == null) { throw new NotFoundException("User not found"); } Map<String, UserStats> stats = new HashMap<String, UserStats>(); for (ApplicationModel applicationModel : realm.getApplications()) { if (applicationModel.getManagementUrl() == null) continue; UserStats appStats = new ResourceAdminManager().getUserStats(realm, applicationModel, user); if (appStats.isLoggedIn()) stats.put(applicationModel.getName(), appStats); } return stats; } #location 16 #vulnerability type NULL_DEREFERENCE
#fixed code @Path("{username}/session-stats") @GET @NoCache @Produces(MediaType.APPLICATION_JSON) public Map<String, UserStats> getSessionStats(final @PathParam("username") String username) { logger.info("session-stats"); auth.requireView(); UserModel user = realm.getUser(username); if (user == null) { throw new NotFoundException("User not found"); } Map<String, UserStats> stats = new HashMap<String, UserStats>(); for (ApplicationModel applicationModel : realm.getApplications()) { if (applicationModel.getManagementUrl() == null) continue; UserStats appStats = new ResourceAdminManager().getUserStats(realm, applicationModel, user); if (appStats == null) continue; if (appStats.isLoggedIn()) stats.put(applicationModel.getName(), appStats); } return stats; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public static void main(String[] args) throws Throwable { KeycloakServerConfig config = new KeycloakServerConfig(); for (int i = 0; i < args.length; i++) { if (args[i].equals("-b")) { config.setHost(args[++i]); } if (args[i].equals("-p")) { config.setPort(Integer.valueOf(args[++i])); } } if (System.getProperties().containsKey("resources")) { String resources = System.getProperty("resources"); if (resources == null || resources.equals("")) { for (String c : System.getProperty("java.class.path").split(File.pathSeparator)) { if (c.contains(File.separator + "testsuite" + File.separator + "integration")) { config.setResourcesHome(c.replaceFirst("testsuite.integration.*", "")); } } } else { config.setResourcesHome(resources); } } final KeycloakServer keycloak = new KeycloakServer(config); keycloak.sysout = true; keycloak.start(); for (int i = 0; i < args.length; i++) { if (args[i].equals("-import")) { keycloak.importRealm(new FileInputStream(args[++i])); } } if (System.getProperties().containsKey("import")) { keycloak.importRealm(new FileInputStream(System.getProperty("import"))); } Runtime.getRuntime().addShutdownHook(new Thread() { @Override public void run() { keycloak.stop(); } }); } #location 17 #vulnerability type NULL_DEREFERENCE
#fixed code public static void main(String[] args) throws Throwable { KeycloakServerConfig config = new KeycloakServerConfig(); for (int i = 0; i < args.length; i++) { if (args[i].equals("-b")) { config.setHost(args[++i]); } if (args[i].equals("-p")) { config.setPort(Integer.valueOf(args[++i])); } } if (System.getProperties().containsKey("resources")) { String resources = System.getProperty("resources"); if (resources == null || resources.equals("") || resources.equals("true")) { if (System.getProperties().containsKey("maven.home")) { resources = System.getProperty("user.dir").replaceFirst("testsuite.integration.*", ""); } else { for (String c : System.getProperty("java.class.path").split(File.pathSeparator)) { if (c.contains(File.separator + "testsuite" + File.separator + "integration")) { resources = c.replaceFirst("testsuite.integration.*", ""); } } } } File dir = new File(resources).getAbsoluteFile(); if (!dir.isDirectory() || !new File(dir, "admin-ui").isDirectory()) { throw new RuntimeException("Invalid resources directory"); } config.setResourcesHome(dir.getAbsolutePath()); } final KeycloakServer keycloak = new KeycloakServer(config); keycloak.sysout = true; keycloak.start(); for (int i = 0; i < args.length; i++) { if (args[i].equals("-import")) { keycloak.importRealm(new FileInputStream(args[++i])); } } if (System.getProperties().containsKey("import")) { keycloak.importRealm(new FileInputStream(System.getProperty("import"))); } Runtime.getRuntime().addShutdownHook(new Thread() { @Override public void run() { keycloak.stop(); } }); }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code public void verifyAccess(AccessToken token, RealmModel realm, ClientModel client, UserModel user) throws OAuthErrorException { ApplicationModel clientApp = (client instanceof ApplicationModel) ? (ApplicationModel)client : null; if (token.getRealmAccess() != null) { for (String roleName : token.getRealmAccess().getRoles()) { RoleModel role = realm.getRole(roleName); if (role == null) { throw new OAuthErrorException(OAuthErrorException.INVALID_GRANT, "Invalid realm role " + roleName); } if (!user.hasRole(role)) { throw new OAuthErrorException(OAuthErrorException.INVALID_SCOPE, "User no long has permission for realm role: " + roleName); } if (!client.hasScope(role)) { throw new OAuthErrorException(OAuthErrorException.INVALID_SCOPE, "Client no longer has realm scope: " + roleName); } } } if (token.getResourceAccess() != null) { for (Map.Entry<String, AccessToken.Access> entry : token.getResourceAccess().entrySet()) { ApplicationModel app = realm.getApplicationByName(entry.getKey()); if (app == null) { throw new OAuthErrorException(OAuthErrorException.INVALID_SCOPE, "Application no longer exists", "Application no longer exists: " + app.getName()); } for (String roleName : entry.getValue().getRoles()) { RoleModel role = app.getRole(roleName); if (role == null) { throw new OAuthErrorException(OAuthErrorException.INVALID_GRANT, "Invalid refresh token", "Unknown application role: " + roleName); } if (!user.hasRole(role)) { throw new OAuthErrorException(OAuthErrorException.INVALID_SCOPE, "User no long has permission for application role " + roleName); } if (clientApp != null && !clientApp.equals(app) && !client.hasScope(role)) { throw new OAuthErrorException(OAuthErrorException.INVALID_SCOPE, "Client no longer has application scope" + roleName); } } } } } #location 23 #vulnerability type NULL_DEREFERENCE
#fixed code public void verifyAccess(AccessToken token, RealmModel realm, ClientModel client, UserModel user) throws OAuthErrorException { ApplicationModel clientApp = (client instanceof ApplicationModel) ? (ApplicationModel)client : null; if (token.getRealmAccess() != null) { for (String roleName : token.getRealmAccess().getRoles()) { RoleModel role = realm.getRole(roleName); if (role == null) { throw new OAuthErrorException(OAuthErrorException.INVALID_GRANT, "Invalid realm role " + roleName); } if (!user.hasRole(role)) { throw new OAuthErrorException(OAuthErrorException.INVALID_SCOPE, "User no long has permission for realm role: " + roleName); } if (!client.hasScope(role)) { throw new OAuthErrorException(OAuthErrorException.INVALID_SCOPE, "Client no longer has realm scope: " + roleName); } } } if (token.getResourceAccess() != null) { for (Map.Entry<String, AccessToken.Access> entry : token.getResourceAccess().entrySet()) { ApplicationModel app = realm.getApplicationByName(entry.getKey()); if (app == null) { throw new OAuthErrorException(OAuthErrorException.INVALID_SCOPE, "Application no longer exists", "Application no longer exists: " + entry.getKey()); } for (String roleName : entry.getValue().getRoles()) { RoleModel role = app.getRole(roleName); if (role == null) { throw new OAuthErrorException(OAuthErrorException.INVALID_GRANT, "Invalid refresh token", "Unknown application role: " + roleName); } if (!user.hasRole(role)) { throw new OAuthErrorException(OAuthErrorException.INVALID_SCOPE, "User no long has permission for application role " + roleName); } if (clientApp != null && !clientApp.equals(app) && !client.hasScope(role)) { throw new OAuthErrorException(OAuthErrorException.INVALID_SCOPE, "Client no longer has application scope" + roleName); } } } } }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @Override public AuthenticationMechanismOutcome authenticate(HttpServerExchange exchange, SecurityContext securityContext) { BearerTokenAuthenticator bearer = createBearerTokenAuthenticator(); AuthenticationMechanismOutcome outcome = bearer.authenticate(exchange); if (outcome == AuthenticationMechanismOutcome.NOT_AUTHENTICATED) { exchange.putAttachment(KEYCLOAK_CHALLENGE_ATTACHMENT_KEY, bearer.getChallenge()); return AuthenticationMechanismOutcome.NOT_AUTHENTICATED; } else if (outcome == AuthenticationMechanismOutcome.AUTHENTICATED) { final AccessToken token = bearer.getToken(); String surrogate = bearer.getSurrogate(); KeycloakAuthenticatedSession session = new KeycloakAuthenticatedSession(bearer.getTokenString(), token, resourceMetadata); KeycloakPrincipal principal = completeAuthentication(securityContext, token, surrogate); propagateBearer(exchange, session, principal); return AuthenticationMechanismOutcome.AUTHENTICATED; } else if (adapterConfig.isBearerOnly()) { exchange.putAttachment(KEYCLOAK_CHALLENGE_ATTACHMENT_KEY, bearer.getChallenge()); return AuthenticationMechanismOutcome.NOT_ATTEMPTED; } OAuthAuthenticator oauth = createOAuthAuthenticator(exchange); outcome = oauth.authenticate(); if (outcome == AuthenticationMechanismOutcome.NOT_AUTHENTICATED) { exchange.putAttachment(KEYCLOAK_CHALLENGE_ATTACHMENT_KEY, oauth.getChallenge()); return AuthenticationMechanismOutcome.NOT_AUTHENTICATED; } else if (outcome == AuthenticationMechanismOutcome.NOT_ATTEMPTED) { exchange.putAttachment(KEYCLOAK_CHALLENGE_ATTACHMENT_KEY, oauth.getChallenge()); return AuthenticationMechanismOutcome.NOT_ATTEMPTED; } KeycloakAuthenticatedSession session = new KeycloakAuthenticatedSession(oauth.getTokenString(), oauth.getToken(), resourceMetadata); KeycloakPrincipal principal = completeAuthentication(securityContext, oauth.getToken(), null); propagateOauth(exchange, session, principal); log.info("AUTHENTICATED"); return AuthenticationMechanismOutcome.AUTHENTICATED; } #location 34 #vulnerability type NULL_DEREFERENCE
#fixed code @Override public AuthenticationMechanismOutcome authenticate(HttpServerExchange exchange, SecurityContext securityContext) { BearerTokenAuthenticator bearer = createBearerTokenAuthenticator(); AuthenticationMechanismOutcome outcome = bearer.authenticate(exchange); if (outcome == AuthenticationMechanismOutcome.NOT_AUTHENTICATED) { exchange.putAttachment(KEYCLOAK_CHALLENGE_ATTACHMENT_KEY, bearer.getChallenge()); return AuthenticationMechanismOutcome.NOT_AUTHENTICATED; } else if (outcome == AuthenticationMechanismOutcome.AUTHENTICATED) { completeAuthentication(securityContext, bearer); return AuthenticationMechanismOutcome.AUTHENTICATED; } else if (adapterConfig.isBearerOnly()) { exchange.putAttachment(KEYCLOAK_CHALLENGE_ATTACHMENT_KEY, bearer.getChallenge()); return AuthenticationMechanismOutcome.NOT_ATTEMPTED; } OAuthAuthenticator oauth = createOAuthAuthenticator(exchange); outcome = oauth.authenticate(); if (outcome == AuthenticationMechanismOutcome.NOT_AUTHENTICATED) { exchange.putAttachment(KEYCLOAK_CHALLENGE_ATTACHMENT_KEY, oauth.getChallenge()); return AuthenticationMechanismOutcome.NOT_AUTHENTICATED; } else if (outcome == AuthenticationMechanismOutcome.NOT_ATTEMPTED) { exchange.putAttachment(KEYCLOAK_CHALLENGE_ATTACHMENT_KEY, oauth.getChallenge()); return AuthenticationMechanismOutcome.NOT_ATTEMPTED; } completeAuthentication(securityContext, oauth); log.info("AUTHENTICATED"); return AuthenticationMechanismOutcome.AUTHENTICATED; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code protected void start() { if (started) { throw new IllegalStateException("Filter already started. Make sure to specify just keycloakConfigResolver or keycloakConfigFile but not both"); } if (keycloakConfigResolverClass != null) { Class<?> clazz; try { clazz = getClass().getClassLoader().loadClass(keycloakConfigResolverClass); } catch (ClassNotFoundException cnfe) { // Fallback to tccl try { clazz = Thread.currentThread().getContextClassLoader().loadClass(keycloakConfigResolverClass); } catch (ClassNotFoundException cnfe2) { throw new RuntimeException("Unable to find resolver class: " + keycloakConfigResolverClass); } } try { KeycloakConfigResolver resolver = (KeycloakConfigResolver) clazz.newInstance(); log.info("Using " + resolver + " to resolve Keycloak configuration on a per-request basis."); this.deploymentContext = new AdapterDeploymentContext(resolver); } catch (Exception e) { throw new RuntimeException("Unable to instantiate resolver " + clazz); } } else { if (keycloakConfigFile == null) { throw new IllegalArgumentException("You need to specify either keycloakConfigResolverClass or keycloakConfigFile in configuration"); } InputStream is = readConfigFile(); KeycloakDeployment kd = KeycloakDeploymentBuilder.build(is); deploymentContext = new AdapterDeploymentContext(kd); log.info("Keycloak is using a per-deployment configuration loaded from: " + keycloakConfigFile); } nodesRegistrationManagement = new NodesRegistrationManagement(); started = true; } #location 31 #vulnerability type RESOURCE_LEAK
#fixed code protected void start() { if (started) { throw new IllegalStateException("Filter already started. Make sure to specify just keycloakConfigResolver or keycloakConfigFile but not both"); } if (keycloakConfigResolverClass != null) { Class<? extends KeycloakConfigResolver> resolverClass = loadResolverClass(); try { KeycloakConfigResolver resolver = resolverClass.newInstance(); log.info("Using " + resolver + " to resolve Keycloak configuration on a per-request basis."); this.deploymentContext = new AdapterDeploymentContext(resolver); } catch (Exception e) { throw new RuntimeException("Unable to instantiate resolver " + resolverClass); } } else { if (keycloakConfigFile == null) { throw new IllegalArgumentException("You need to specify either keycloakConfigResolverClass or keycloakConfigFile in configuration"); } InputStream is = loadKeycloakConfigFile(); KeycloakDeployment kd = KeycloakDeploymentBuilder.build(is); deploymentContext = new AdapterDeploymentContext(kd); log.info("Keycloak is using a per-deployment configuration loaded from: " + keycloakConfigFile); } nodesRegistrationManagement = new NodesRegistrationManagement(); started = true; }
Below is the vulnerable code, please generate the patch based on the following information.
#vulnerable code @JsonIgnore public void setPublicKey(PublicKey publicKey) { this.publicKey = publicKey; StringWriter writer = new StringWriter(); PEMWriter pemWriter = new PEMWriter(writer); try { pemWriter.writeObject(publicKey); pemWriter.flush(); } catch (IOException e) { throw new RuntimeException(e); } String s = writer.toString(); this.publicKeyPem = PemUtils.removeBeginEnd(s); } #location 8 #vulnerability type RESOURCE_LEAK
#fixed code @JsonIgnore public void setPublicKey(PublicKey publicKey) { this.publicKey = publicKey; StringWriter writer = new StringWriter(); PEMWriter pemWriter = new PEMWriter(writer); try { pemWriter.writeObject(publicKey); pemWriter.flush(); pemWriter.close(); } catch (IOException e) { throw new RuntimeException(e); } String s = writer.toString(); this.publicKeyPem = PemUtils.removeBeginEnd(s); }
Below is the vulnerable code, please generate the patch based on the following information.