output
stringlengths 64
73.2k
| input
stringlengths 208
73.3k
| instruction
stringclasses 1
value |
|---|---|---|
#fixed code
public void install() throws InstallationException {
// use static lock object for a synchronized block
synchronized (LOCK) {
if(nodeDownloadRoot == null || nodeDownloadRoot.isEmpty()){
nodeDownloadRoot = DEFAULT_NODEJS_DOWNLOAD_ROOT;
}
if(npmDownloadRoot == null || npmDownloadRoot.isEmpty()){
npmDownloadRoot = DEFAULT_NPM_DOWNLOAD_ROOT;
}
if (!nodeIsAlreadyInstalled()) {
logger.info("Installing node version {}", nodeVersion);
if (!nodeVersion.startsWith("v")) {
logger.warn("Node version does not start with naming convention 'v'.");
}
if (config.getPlatform().isWindows()) {
installNodeForWindows();
} else {
installNodeDefault();
}
}
if (!npmIsAlreadyInstalled()) {
installNpm();
}
}
} | #vulnerable code
public void install() throws InstallationException {
if(nodeDownloadRoot == null || nodeDownloadRoot.isEmpty()){
nodeDownloadRoot = DEFAULT_NODEJS_DOWNLOAD_ROOT;
}
if(npmDownloadRoot == null || npmDownloadRoot.isEmpty()){
npmDownloadRoot = DEFAULT_NPM_DOWNLOAD_ROOT;
}
synchronized (lock) {
if (!nodeIsAlreadyInstalled()) {
logger.info("Installing node version {}", nodeVersion);
if (!nodeVersion.startsWith("v")) {
logger.warn("Node version does not start with naming convention 'v'.");
}
if (config.getPlatform().isWindows()) {
installNodeForWindows();
} else {
installNodeDefault();
}
}
if (!npmIsAlreadyInstalled()) {
installNpm();
}
}
}
#location 15
#vulnerability type THREAD_SAFETY_VIOLATION | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
static List<String> buildArguments(ProxyConfig proxyConfig, String npmRegistryURL) {
List<String> arguments = new ArrayList<String>();
if(npmRegistryURL != null && !npmRegistryURL.isEmpty()){
arguments.add ("--registry=" + npmRegistryURL);
}
if(!proxyConfig.isEmpty()){
Proxy proxy = null;
if(npmRegistryURL != null && !npmRegistryURL.isEmpty()){
proxy = proxyConfig.getProxyForUrl(npmRegistryURL);
}
if(proxy == null){
proxy = proxyConfig.getSecureProxy();
}
if(proxy == null){
proxy = proxyConfig.getInsecureProxy();
}
arguments.add("--https-proxy=" + proxy.getUri().toString());
arguments.add("--proxy=" + proxy.getUri().toString());
final String nonProxyHosts = proxy.getNonProxyHosts();
if (nonProxyHosts != null && !nonProxyHosts.isEmpty()) {
final String[] nonProxyHostList = nonProxyHosts.split("\\|");
for (String nonProxyHost: nonProxyHostList) {
arguments.add("--noproxy=" + nonProxyHost.replace("*", ""));
}
}
}
return arguments;
} | #vulnerable code
static List<String> buildArguments(ProxyConfig proxyConfig, String npmRegistryURL) {
List<String> arguments = new ArrayList<String>();
if(npmRegistryURL != null && !npmRegistryURL.isEmpty()){
arguments.add ("--registry=" + npmRegistryURL);
}
if(!proxyConfig.isEmpty()){
Proxy proxy = null;
if(npmRegistryURL != null && !npmRegistryURL.isEmpty()){
proxy = proxyConfig.getProxyForUrl(npmRegistryURL);
}
if(proxy == null){
proxy = proxyConfig.getSecureProxy();
}
if(proxy == null){
proxy = proxyConfig.getInsecureProxy();
}
arguments.add("--https-proxy=" + proxy.getUri().toString());
arguments.add("--proxy=" + proxy.getUri().toString());
final String nonProxyHosts = proxy.getNonProxyHosts();
if (nonProxyHosts != null && !nonProxyHosts.isEmpty()) {
arguments.add("--noproxy=" + nonProxyHosts.replace('|',','));
}
}
return arguments;
}
#location 22
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public void install() throws InstallationException {
// use static lock object for a synchronized block
synchronized (LOCK) {
if(nodeDownloadRoot == null || nodeDownloadRoot.isEmpty()){
nodeDownloadRoot = DEFAULT_NODEJS_DOWNLOAD_ROOT;
}
if(npmDownloadRoot == null || npmDownloadRoot.isEmpty()){
npmDownloadRoot = DEFAULT_NPM_DOWNLOAD_ROOT;
}
if (!nodeIsAlreadyInstalled()) {
logger.info("Installing node version {}", nodeVersion);
if (!nodeVersion.startsWith("v")) {
logger.warn("Node version does not start with naming convention 'v'.");
}
if (config.getPlatform().isWindows()) {
installNodeForWindows();
} else {
installNodeDefault();
}
}
if (!npmIsAlreadyInstalled()) {
installNpm();
}
}
} | #vulnerable code
public void install() throws InstallationException {
if(nodeDownloadRoot == null || nodeDownloadRoot.isEmpty()){
nodeDownloadRoot = DEFAULT_NODEJS_DOWNLOAD_ROOT;
}
if(npmDownloadRoot == null || npmDownloadRoot.isEmpty()){
npmDownloadRoot = DEFAULT_NPM_DOWNLOAD_ROOT;
}
synchronized (lock) {
if (!nodeIsAlreadyInstalled()) {
logger.info("Installing node version {}", nodeVersion);
if (!nodeVersion.startsWith("v")) {
logger.warn("Node version does not start with naming convention 'v'.");
}
if (config.getPlatform().isWindows()) {
installNodeForWindows();
} else {
installNodeDefault();
}
}
if (!npmIsAlreadyInstalled()) {
installNpm();
}
}
}
#location 3
#vulnerability type THREAD_SAFETY_VIOLATION | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public void install() throws InstallationException {
// use static lock object for a synchronized block
synchronized (LOCK) {
if(nodeDownloadRoot == null || nodeDownloadRoot.isEmpty()){
nodeDownloadRoot = DEFAULT_NODEJS_DOWNLOAD_ROOT;
}
if(npmDownloadRoot == null || npmDownloadRoot.isEmpty()){
npmDownloadRoot = DEFAULT_NPM_DOWNLOAD_ROOT;
}
if (!nodeIsAlreadyInstalled()) {
logger.info("Installing node version {}", nodeVersion);
if (!nodeVersion.startsWith("v")) {
logger.warn("Node version does not start with naming convention 'v'.");
}
if (config.getPlatform().isWindows()) {
installNodeForWindows();
} else {
installNodeDefault();
}
}
if (!npmIsAlreadyInstalled()) {
installNpm();
}
}
} | #vulnerable code
public void install() throws InstallationException {
if(nodeDownloadRoot == null || nodeDownloadRoot.isEmpty()){
nodeDownloadRoot = DEFAULT_NODEJS_DOWNLOAD_ROOT;
}
if(npmDownloadRoot == null || npmDownloadRoot.isEmpty()){
npmDownloadRoot = DEFAULT_NPM_DOWNLOAD_ROOT;
}
synchronized (lock) {
if (!nodeIsAlreadyInstalled()) {
logger.info("Installing node version {}", nodeVersion);
if (!nodeVersion.startsWith("v")) {
logger.warn("Node version does not start with naming convention 'v'.");
}
if (config.getPlatform().isWindows()) {
installNodeForWindows();
} else {
installNodeDefault();
}
}
if (!npmIsAlreadyInstalled()) {
installNpm();
}
}
}
#location 21
#vulnerability type THREAD_SAFETY_VIOLATION | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public void install() throws InstallationException {
// use static lock object for a synchronized block
synchronized (LOCK) {
if(nodeDownloadRoot == null || nodeDownloadRoot.isEmpty()){
nodeDownloadRoot = DEFAULT_NODEJS_DOWNLOAD_ROOT;
}
if(npmDownloadRoot == null || npmDownloadRoot.isEmpty()){
npmDownloadRoot = DEFAULT_NPM_DOWNLOAD_ROOT;
}
if (!nodeIsAlreadyInstalled()) {
logger.info("Installing node version {}", nodeVersion);
if (!nodeVersion.startsWith("v")) {
logger.warn("Node version does not start with naming convention 'v'.");
}
if (config.getPlatform().isWindows()) {
installNodeForWindows();
} else {
installNodeDefault();
}
}
if (!npmIsAlreadyInstalled()) {
installNpm();
}
}
} | #vulnerable code
public void install() throws InstallationException {
if(nodeDownloadRoot == null || nodeDownloadRoot.isEmpty()){
nodeDownloadRoot = DEFAULT_NODEJS_DOWNLOAD_ROOT;
}
if(npmDownloadRoot == null || npmDownloadRoot.isEmpty()){
npmDownloadRoot = DEFAULT_NPM_DOWNLOAD_ROOT;
}
synchronized (lock) {
if (!nodeIsAlreadyInstalled()) {
logger.info("Installing node version {}", nodeVersion);
if (!nodeVersion.startsWith("v")) {
logger.warn("Node version does not start with naming convention 'v'.");
}
if (config.getPlatform().isWindows()) {
installNodeForWindows();
} else {
installNodeDefault();
}
}
if (!npmIsAlreadyInstalled()) {
installNpm();
}
}
}
#location 6
#vulnerability type THREAD_SAFETY_VIOLATION | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
private void initialize(
final String methodName,
final AtomicReference<OperationArguments> operationArgumentsRef,
final AtomicReference<IAuthentication> authenticationRef
) throws IOException, URISyntaxException
{
// parse the operations arguments from stdin (this is how git sends commands)
// see: https://www.kernel.org/pub/software/scm/git/docs/technical/api-credentials.html
// see: https://www.kernel.org/pub/software/scm/git/docs/git-credential.html
final OperationArguments operationArguments;
final BufferedReader reader = new BufferedReader(new InputStreamReader(standardIn));
try
{
operationArguments = new OperationArguments(reader);
}
finally
{
IOHelper.closeQuietly(reader);
}
Debug.Assert(operationArguments.TargetUri != null, "The operationArguments.TargetUri is null");
final Configuration config = componentFactory.createConfiguration();
loadOperationArguments(operationArguments, config);
enableTraceLogging(operationArguments);
Trace.writeLine("Program::" + methodName);
Trace.writeLine(" targetUri = " + operationArguments.TargetUri);
final ISecureStore secureStore = componentFactory.createSecureStore();
final IAuthentication authentication = componentFactory.createAuthentication(operationArguments, secureStore);
operationArgumentsRef.set(operationArguments);
authenticationRef.set(authentication);
} | #vulnerable code
private void initialize(
final String methodName,
final AtomicReference<OperationArguments> operationArgumentsRef,
final AtomicReference<IAuthentication> authenticationRef
) throws IOException, URISyntaxException
{
// parse the operations arguments from stdin (this is how git sends commands)
// see: https://www.kernel.org/pub/software/scm/git/docs/technical/api-credentials.html
// see: https://www.kernel.org/pub/software/scm/git/docs/git-credential.html
final OperationArguments operationArguments;
final BufferedReader reader = new BufferedReader(new InputStreamReader(standardIn));
try
{
operationArguments = new OperationArguments(reader);
}
finally
{
IOUtils.closeQuietly(reader);
}
Debug.Assert(operationArguments.TargetUri != null, "The operationArguments.TargetUri is null");
final Configuration config = componentFactory.createConfiguration();
loadOperationArguments(operationArguments, config);
enableTraceLogging(operationArguments);
Trace.writeLine("Program::" + methodName);
Trace.writeLine(" targetUri = " + operationArguments.TargetUri);
final ISecureStore secureStore = componentFactory.createSecureStore();
final IAuthentication authentication = componentFactory.createAuthentication(operationArguments, secureStore);
operationArgumentsRef.set(operationArguments);
authenticationRef.set(authentication);
}
#location 18
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
static InsecureStore clone(InsecureStore inputStore)
{
ByteArrayOutputStream baos = null;
ByteArrayInputStream bais = null;
try
{
baos = new ByteArrayOutputStream();
inputStore.toXml(baos);
final String xmlString = baos.toString();
bais = new ByteArrayInputStream(xmlString.getBytes());
final InsecureStore result = InsecureStore.fromXml(bais);
return result;
}
finally
{
IOUtils.closeQuietly(baos);
IOUtils.closeQuietly(bais);
}
} | #vulnerable code
static InsecureStore clone(InsecureStore inputStore)
{
ByteArrayOutputStream baos = null;
ByteArrayInputStream bais = null;
try
{
baos = new ByteArrayOutputStream();
final PrintStream ps = new PrintStream(baos);
inputStore.toXml(ps);
ps.flush();
final String xmlString = baos.toString();
bais = new ByteArrayInputStream(xmlString.getBytes());
final InsecureStore result = InsecureStore.fromXml(bais);
return result;
}
finally
{
IOUtils.closeQuietly(baos);
IOUtils.closeQuietly(bais);
}
}
#location 11
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
private String doHttpGet(URL url) throws IOException, RestApiException {
System.out.println("GET " + url.toString());
HttpURLConnection connection = JdkHttpTransport.createConnection(config, url, headers, false);
connection.setInstanceFollowRedirects(true);
InputStream in;
System.out.println("HTTP " + connection.getResponseCode());
if(connection.getResponseCode() >= 400) {
in = connection.getErrorStream();
} else {
in = connection.getInputStream();
}
String encoding = connection.getHeaderField(CONTENT_HEADER);
StringBuilder responseBuilder = new StringBuilder();
if (encoding.startsWith(ContentType.JSON.toString())) {
BufferedInputStream bin = new BufferedInputStream(in);
//read the server response body
byte[] buffer = new byte[1024];
int bytesRead = 0;
while ((bytesRead = bin.read(buffer)) != -1) {
responseBuilder.append(new String(buffer, 0, bytesRead));
}
bin.close();
} else {
throw new IllegalStateException("Unknown content type on HTTP GET.");
}
in.close();
//send back the server response
return responseBuilder.toString();
} | #vulnerable code
private String doHttpGet(URL url) throws IOException, RestApiException {
System.out.println("GET " + url.toString());
HttpURLConnection connection = JdkHttpTransport.createConnection(config, url, headers, false);
connection.setInstanceFollowRedirects(true);
InputStream in;
System.out.println("HTTP " + connection.getResponseCode());
if(connection.getResponseCode() >= 400) {
in = connection.getErrorStream();
} else {
in = connection.getInputStream();
}
String encoding = connection.getHeaderField(CONTENT_HEADER);
StringBuilder responseBuilder = new StringBuilder();
if (encoding.startsWith(ContentType.JSON.toString())) {
BufferedInputStream bin = new BufferedInputStream(in);
//read the server response body
byte[] buffer = new byte[1024];
int bytesRead = 0;
while ((bytesRead = bin.read(buffer)) != -1) {
responseBuilder.append(new String(buffer, 0, bytesRead));
}
} else {
throw new IllegalStateException("Unknown content type on HTTP GET.");
}
in.close();
//send back the server response
return responseBuilder.toString();
}
#location 29
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
private String doHttpPost(URL url, String body) throws IOException {
System.out.println("POST " + url.toString() + " " + body);
HttpURLConnection connection = JdkHttpTransport.createConnection(config, url, headers, false);
connection.setInstanceFollowRedirects(true);
connection.setDoOutput(true);
connection.setRequestMethod("POST");
OutputStream out = connection.getOutputStream();
InputStream in;
out.write(body.getBytes());
out.flush();
out.close();
System.out.print("HTTP " + connection.getResponseCode());
if(connection.getResponseCode() >= 400) {
in = connection.getErrorStream();
} else {
in = connection.getInputStream();
}
BufferedInputStream bin = new BufferedInputStream(in);
StringBuilder responseBuilder = new StringBuilder();
//read the server response body
byte[] buffer = new byte[1024];
int bytesRead = 0;
while ((bytesRead = bin.read(buffer)) != -1) {
responseBuilder.append(new String(buffer, 0, bytesRead));
}
bin.close();
String serverResponse = responseBuilder.toString();
System.out.print(serverResponse + "\r\n");
if(connection.getResponseCode() >= 400) {
throw new IllegalStateException(serverResponse);
} else {
return serverResponse;
}
} | #vulnerable code
private String doHttpPost(URL url, String body) throws IOException {
System.out.println("POST " + url.toString() + " " + body);
HttpURLConnection connection = JdkHttpTransport.createConnection(config, url, headers, false);
connection.setInstanceFollowRedirects(true);
connection.setDoOutput(true);
connection.setRequestMethod("POST");
OutputStream out = connection.getOutputStream();
InputStream in;
out.write(body.getBytes());
out.flush();
out.close();
System.out.print("HTTP " + connection.getResponseCode());
if(connection.getResponseCode() >= 400) {
in = connection.getErrorStream();
} else {
in = connection.getInputStream();
}
BufferedInputStream bin = new BufferedInputStream(in);
StringBuilder responseBuilder = new StringBuilder();
//read the server response body
byte[] buffer = new byte[1024];
int bytesRead = 0;
while ((bytesRead = bin.read(buffer)) != -1) {
responseBuilder.append(new String(buffer, 0, bytesRead));
}
String serverResponse = responseBuilder.toString();
System.out.print(serverResponse + "\r\n");
if(connection.getResponseCode() >= 400) {
throw new IllegalStateException(serverResponse);
} else {
return serverResponse;
}
}
#location 32
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Override
public DataFrame<R, String> read(Consumer<DbSourceOptions<R>> configurator) throws DataFrameException {
final DbSourceOptions<R> options = initOptions(new DbSourceOptions<>(), configurator);
try (Connection conn = options.getConnection()) {
conn.setAutoCommit(options.isAutoCommit());
conn.setReadOnly(options.isReadOnly());
final int fetchSize = options.getFetchSize().orElse(1000);
final SQL sql = SQL.of(options.getSql(), options.getParameters().orElse(new Object[0]));
return sql.executeQuery(conn, fetchSize, rs -> read(rs, options));
} catch (Exception ex) {
throw new DataFrameException("Failed to create DataFrame from database request: " + options, ex);
}
} | #vulnerable code
@Override
public DataFrame<R, String> read(Consumer<DbSourceOptions<R>> configurator) throws DataFrameException {
final DbSourceOptions<R> options = initOptions(new DbSourceOptions<>(), configurator);
try (Connection conn = options.getConnection()) {
final SQL sql = SQL.of(options.getSql(), options.getParameters().orElse(new Object[0]));
return sql.executeQuery(conn, rs -> read(rs, options));
} catch (Exception ex) {
throw new DataFrameException("Failed to create DataFrame from database request: " + options, ex);
}
}
#location 6
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public void testParse() throws ParseException, IOException, Exception {
for (String inputString : getInputStrings()) {
JSONObject parsed = parser.parse(inputString.getBytes());
assertNotNull(parsed);
System.out.println(parsed);
JSONParser parser = new JSONParser();
Map<?, ?> json=null;
try {
json = (Map<?, ?>) parser.parse(parsed.toJSONString());
assertEquals(true, validateJsonData(super.getSchemaJsonString(), json.toString()));
} catch (ParseException e) {
e.printStackTrace();
}
}
} | #vulnerable code
public void testParse() throws ParseException, IOException, Exception {
// JSONObject parsed = iseParser.parse(getRawMessage().getBytes());
// assertNotNull(parsed);
URL log_url = getClass().getClassLoader().getResource("IseSample.log");
BufferedReader br = new BufferedReader(new FileReader(log_url.getFile()));
String line = "";
while ((line = br.readLine()) != null) {
System.out.println(line);
JSONObject parsed = iseParser.parse(line.getBytes());
System.out.println(parsed);
assertEquals(true, super.validateJsonData(super.getSchemaJsonString(), parsed.toString()));
}
br.close();
}
#location 16
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Override
public Map<String, JSONObject> alert(JSONObject raw_message) {
Map<String, JSONObject> alerts = new HashMap<String, JSONObject>();
JSONObject content = (JSONObject) raw_message.get("message");
JSONObject enrichment = null;
if (raw_message.containsKey("enrichment"))
enrichment = (JSONObject) raw_message.get("enrichment");
for (String keyword : keywordList) {
if (content.toString().contains(keyword)) {
//check it doesn't have an "exception" keyword in it
for (String exception : keywordExceptionList) {
if (content.toString().contains(exception)) {
return null;
}
}
JSONObject alert = new JSONObject();
String source = "unknown";
String dest = "unknown";
String host = "unknown";
if (content.containsKey("ip_src_addr"))
{
source = content.get("ip_src_addr").toString();
if(RangeChecker.checkRange(loaded_whitelist, source))
host = source;
}
if (content.containsKey("ip_dst_addr"))
{
dest = content.get("ip_dst_addr").toString();
if(RangeChecker.checkRange(loaded_whitelist, dest))
host = dest;
}
alert.put("designated_host", host);
alert.put("description", content.get("original_string").toString());
alert.put("priority", "MED");
String alert_id = generateAlertId(source, dest, 0);
alert.put("alert_id", alert_id);
alerts.put(alert_id, alert);
alert.put("enrichment", enrichment);
return alerts;
}
}
return null;
} | #vulnerable code
@Override
public Map<String, JSONObject> alert(JSONObject raw_message) {
Map<String, JSONObject> alerts = new HashMap<String, JSONObject>();
JSONObject content = (JSONObject) raw_message.get("message");
JSONObject enrichment = null;
if (raw_message.containsKey("enrichment"))
enrichment = (JSONObject) raw_message.get("enrichment");
for (String keyword : keywordList) {
if (content.toString().contains(keyword)) {
JSONObject alert = new JSONObject();
String source = "unknown";
String dest = "unknown";
String host = "unknown";
if (content.containsKey("ip_src_addr"))
{
source = content.get("ip_src_addr").toString();
if(RangeChecker.checkRange(loaded_whitelist, source))
host = source;
}
if (content.containsKey("ip_dst_addr"))
{
dest = content.get("ip_dst_addr").toString();
if(RangeChecker.checkRange(loaded_whitelist, dest))
host = dest;
}
alert.put("designated_host", host);
alert.put("description", content.get("original_string").toString());
alert.put("priority", "MED");
String alert_id = generateAlertId(source, dest, 0);
alert.put("alert_id", alert_id);
alerts.put(alert_id, alert);
alert.put("enrichment", enrichment);
return alerts;
}
}
return null;
}
#location 36
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Override
public boolean initializeAdapter() {
_LOG.info("Initializing MysqlAdapter....");
try {
Class.forName("com.mysql.jdbc.Driver");
connection = DriverManager.getConnection("jdbc:mysql://" + _ip
+ "/" + _tablename + "?user=" + _username + "&password="
+ _password);
connection.setReadOnly(true);
if (!connection.isValid(0))
throw new Exception("Invalid connection string....");
_LOG.info("Set JDBC connection....");
return true;
} catch (Exception e) {
e.printStackTrace();
_LOG.error("JDBC connection failed....");
return false;
}
} | #vulnerable code
@Override
public boolean initializeAdapter() {
_LOG.info("Initializing MysqlAdapter....");
try {
boolean reachable = (java.lang.Runtime.getRuntime()
.exec("ping -n 1 " + _ip).waitFor() == 0);
if (!reachable)
throw new Exception("Unable to reach IP....");
Class.forName("com.mysql.jdbc.Driver");
connection = DriverManager.getConnection("jdbc:mysql://" + _ip
+ "/" + _tablename + "?user=" + _username + "&password="
+ _password);
connection.setReadOnly(true);
if (!connection.isValid(0))
throw new Exception("Invalid connection string....");
_LOG.info("Set JDBC connection....");
return true;
} catch (Exception e) {
e.printStackTrace();
_LOG.error("JDBC connection failed....");
return false;
}
}
#location 9
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public void testParse() throws IOException, Exception {
for (String inputString : getInputStrings()) {
JSONObject parsed = parser.parse(inputString.getBytes());
assertNotNull(parsed);
System.out.println(parsed);
JSONParser parser = new JSONParser();
Map<?, ?> json=null;
try {
json = (Map<?, ?>) parser.parse(parsed.toJSONString());
assertEquals(true, validateJsonData(super.getSchemaJsonString(), json.toString()));
} catch (ParseException e) {
e.printStackTrace();
}
}
} | #vulnerable code
public void testParse() throws IOException, Exception {
URL log_url = getClass().getClassLoader().getResource("LancopeSample.log");
BufferedReader br;
try {
br = new BufferedReader(new FileReader(log_url.getFile()));
String line = "";
while ((line = br.readLine()) != null) {
System.out.println(line);
assertNotNull(line);
JSONObject parsed = lancopeParser.parse(line.getBytes());
System.out.println(parsed);
assertEquals(true, validateJsonData(super.getSchemaJsonString(), parsed.toString()));
}
br.close();
} catch (FileNotFoundException e) {
e.printStackTrace();
}
}
#location 16
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Override
public JSONObject parse(byte[] raw_message) {
String toParse = "";
JSONObject toReturn;
try {
toParse = new String(raw_message, "UTF-8");
//System.out.println("Received message: " + toParse);
//OpenSOCMatch gm = grok.match(toParse);
//gm.captures();
toReturn = new JSONObject();
String[] mTokens = toParse.split(" ");
//toReturn.putAll(gm.toMap());
String id = mTokens[0];
// We are not parsing the fedata for multi part message as we cannot determine how we can split the message and how many multi part messages can there be.
// The message itself will be stored in the response.
String[] tokens = id.split("\\.");
if(tokens.length == 2 ) {
String[] array = Arrays.copyOfRange(mTokens, 1, mTokens.length-1);
String syslog = Joiner.on(" ").join(array);
Multimap<String, String> multiMap = formatMain(syslog) ;
for(String key : multiMap.keySet()) {
String value =Joiner.on(",").join( multiMap.get(key));
toReturn.put(key, value);
}
}
String ip_src_addr = (String) toReturn.get("dvc");
String ip_src_port = (String) toReturn.get("src_port");
String ip_dst_addr = (String) toReturn.get("dst_ip");
String ip_dst_port = (String) toReturn.get("dst_port");
if(ip_src_addr != null)
toReturn.put("ip_src_addr", ip_src_addr);
if(ip_src_port != null)
toReturn.put("ip_src_port", ip_src_port);
if(ip_dst_addr != null)
toReturn.put("ip_dst_addr", ip_dst_addr);
if(ip_dst_port != null)
toReturn.put("ip_dst_port", ip_dst_port);
System.out.println(toReturn);
return toReturn;
} catch (Exception e) {
e.printStackTrace();
return null;
}
} | #vulnerable code
@Override
public JSONObject parse(byte[] raw_message) {
String toParse = "";
JSONObject toReturn;
try {
toParse = new String(raw_message, "UTF-8");
//System.out.println("Received message: " + toParse);
OpenSOCMatch gm = grok.match(toParse);
gm.captures();
toReturn = new JSONObject();
toReturn.putAll(gm.toMap());
String id = toReturn.get("uid").toString();
// We are not parsing the fedata for multi part message as we cannot determine how we can split the message and how many multi part messages can there be.
// The message itself will be stored in the response.
String[] tokens = id.split("\\.");
if(tokens.length == 1 ) {
String syslog = toReturn.get("syslog").toString();
Multimap<String, String> multiMap = formatMain(syslog) ;
for(String key : multiMap.keySet()) {
String value =Joiner.on(",").join( multiMap.get(key));
toReturn.put(key, value);
}
}
String ip_src_addr = (String) toReturn.get("dvc");
String ip_src_port = (String) toReturn.get("src_port");
String ip_dst_addr = (String) toReturn.get("dst_ip");
String ip_dst_port = (String) toReturn.get("dst_port");
if(ip_src_addr != null)
toReturn.put("ip_src_addr", ip_src_addr);
if(ip_src_port != null)
toReturn.put("ip_src_port", ip_src_port);
if(ip_dst_addr != null)
toReturn.put("ip_dst_addr", ip_dst_addr);
if(ip_dst_port != null)
toReturn.put("ip_dst_port", ip_dst_port);
return toReturn;
} catch (Exception e) {
e.printStackTrace();
return null;
}
}
#location 19
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Override
public JSONObject parse(byte[] raw_message) {
String toParse = "";
JSONObject toReturn;
try {
toParse = new String(raw_message, "UTF-8");
//System.out.println("Received message: " + toParse);
Match gm = grok.match(toParse);
gm.captures();
toReturn = new JSONObject();
toReturn.putAll(gm.toMap());
String id = toReturn.get("uid").toString();
// We are not parsing the fedata for multi part message as we cannot determine how we can split the message and how many multi part messages can there be.
// The message itself will be stored in the response.
String[] tokens = id.split("\\.");
if(tokens.length == 1 ) {
String syslog = toReturn.get("syslog").toString();
Multimap<String, String> multiMap = formatMain(syslog) ;
for(String key : multiMap.keySet()) {
String value =Joiner.on(",").join( multiMap.get(key));
toReturn.put(key, value);
}
}
String ip_src_addr = (String) toReturn.get("dvc");
String ip_src_port = (String) toReturn.get("src_port");
String ip_dst_addr = (String) toReturn.get("dst_ip");
String ip_dst_port = (String) toReturn.get("dst_port");
if(ip_src_addr != null)
toReturn.put("ip_src_addr", ip_src_addr);
if(ip_src_port != null)
toReturn.put("ip_src_port", ip_src_port);
if(ip_dst_addr != null)
toReturn.put("ip_dst_addr", ip_dst_addr);
if(ip_dst_port != null)
toReturn.put("ip_dst_port", ip_dst_port);
return toReturn;
} catch (Exception e) {
e.printStackTrace();
return null;
}
} | #vulnerable code
@Override
public JSONObject parse(byte[] raw_message) {
String toParse = "";
JSONObject toReturn;
try {
toParse = new String(raw_message, "UTF-8");
//System.out.println("Received message: " + toParse);
Match gm = grok.match(toParse);
gm.captures();
toReturn = new JSONObject();
toReturn.putAll(gm.toMap());
String id = toReturn.get("uid").toString();
// We are not parsing the fedata for multi part message as we cannot determine how we can split the message and how many multi part messages can there be.
// The message itself will be stored in the response.
String[] tokens = id.split("\\.");
if(tokens.length == 1 ) {
String syslog = toReturn.get("syslog").toString();
Multimap<String, String> multiMap = formatMain(syslog) ;
for(String key : multiMap.keySet()) {
toReturn.put(key, multiMap.get(key));
}
}
return toReturn;
} catch (Exception e) {
e.printStackTrace();
return null;
}
}
#location 28
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Override
protected Object createTest() throws Exception {
instances = createHierarchicalFixtures();
return instances.getLast();
} | #vulnerable code
@Override
protected Object createTest() throws Exception {
ensureHierarchicalFixturesAreValid();
return instances.getLast();
}
#location 4
#vulnerability type THREAD_SAFETY_VIOLATION | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Override
protected Statement withBefores(final FrameworkMethod method, final Object target, final Statement next) {
Statement statement = next;
for (int i = instances.size() - 1; i >= 0; i--) {
final Object instance = instances.get(i);
final TestClass tClass = TestClassPool.forClass(instance.getClass());
final List<FrameworkMethod> befores = tClass.getAnnotatedMethods(Before.class);
statement = befores.isEmpty() ? statement : new RunBefores(statement, befores, instance);
}
return statement;
} | #vulnerable code
@Override
protected Statement withBefores(final FrameworkMethod method, final Object target, final Statement next) {
Statement statement = next;
for (int i = instances.size() - 1; i >= 0; i--) {
final Object instance = instances.get(i);
final TestClass tClass = new TestClass(instance.getClass());
final List<FrameworkMethod> befores = tClass.getAnnotatedMethods(Before.class);
statement = befores.isEmpty() ? statement : new RunBefores(statement, befores, instance);
}
return statement;
}
#location 5
#vulnerability type THREAD_SAFETY_VIOLATION | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public static void register(Object generatorStrategy, Object classGenerator, byte[] bytes) {
try {
generatorParams.put(getClassName(bytes), new GeneratorParams(generatorStrategy, classGenerator));
} catch (Exception e) {
LOGGER.error("Error saving parameters of a creation of a Cglib proxy", e);
}
} | #vulnerable code
public static void register(Object generatorStrategy, Object classGenerator, byte[] bytes) {
try {
ClassPool classPool = ProxyTransformationUtils.getClassPool(generatorStrategy.getClass().getClassLoader());
CtClass cc = classPool.makeClass(new ByteArrayInputStream(bytes), false);
generatorParams.put(cc.getName(), new GeneratorParams(generatorStrategy, classGenerator));
cc.detach();
} catch (IOException | RuntimeException e) {
LOGGER.error("Error saving parameters of a creation of a Cglib proxy", e);
}
}
#location 4
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public static Object callPluginMethod(Class pluginClass, ClassLoader appClassLoader, String method, Class[] paramTypes, Object[] params) {
Object pluginInstance = PluginManager.getInstance().getPlugin(pluginClass.getName(), appClassLoader);
try {
Method m = pluginInstance.getClass().getDeclaredMethod(method, paramTypes);
return m.invoke(pluginInstance, params);
} catch (Exception e) {
throw new Error(String.format("Exception calling method %s on plugin class %s", method, pluginClass), e);
}
} | #vulnerable code
public static Object callPluginMethod(Class pluginClass, ClassLoader appClassLoader, String method, Class[] paramTypes, Object[] params) {
Object pluginInstance = PluginManager.getInstance().getPlugin(pluginClass.getName(), appClassLoader);
try {
Method m = pluginInstance.getClass().getDeclaredMethod(method, paramTypes);
return m.invoke(pluginInstance, params);
} catch (Exception e) {
throw new Error(String.format("Exception calling method {} on plugin class {}", method, pluginClass), e);
}
}
#location 5
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
private void scanJar(String urlFile, ScannerVisitor visitor) throws IOException {
LOGGER.trace("Scanning JAR file '{}'", urlFile);
int separatorIndex = urlFile.indexOf(JAR_URL_SEPARATOR);
JarFile jarFile = null;
String rootEntryPath;
try {
if (separatorIndex != -1) {
String jarFileUrl = urlFile.substring(0, separatorIndex);
rootEntryPath = urlFile.substring(separatorIndex + JAR_URL_SEPARATOR.length());
jarFile = getJarFile(jarFileUrl);
} else {
rootEntryPath = "";
jarFile = new JarFile(urlFile);
}
if (!"".equals(rootEntryPath) && !rootEntryPath.endsWith("/")) {
rootEntryPath = rootEntryPath + "/";
}
for (Enumeration<JarEntry> entries = jarFile.entries(); entries.hasMoreElements(); ) {
JarEntry entry = entries.nextElement();
String entryPath = entry.getName();
// class files inside entry
if (entryPath.startsWith(rootEntryPath) && entryPath.endsWith(".class")) {
LOGGER.trace("Visiting JAR entry {}", entryPath);
visitor.visit(jarFile.getInputStream(entry));
}
}
} finally {
if (jarFile != null) {
jarFile.close();
}
}
} | #vulnerable code
private void scanJar(String urlFile, ScannerVisitor visitor) throws IOException {
LOGGER.trace("Scanning JAR file '{}'", urlFile);
int separatorIndex = urlFile.indexOf(JAR_URL_SEPARATOR);
JarFile jarFile;
String rootEntryPath;
if (separatorIndex != -1) {
String jarFileUrl = urlFile.substring(0, separatorIndex);
rootEntryPath = urlFile.substring(separatorIndex + JAR_URL_SEPARATOR.length());
jarFile = getJarFile(jarFileUrl);
} else {
rootEntryPath = "";
jarFile = new JarFile(urlFile);
}
if (!"".equals(rootEntryPath) && !rootEntryPath.endsWith("/")) {
rootEntryPath = rootEntryPath + "/";
}
for (Enumeration<JarEntry> entries = jarFile.entries(); entries.hasMoreElements(); ) {
JarEntry entry = entries.nextElement();
String entryPath = entry.getName();
// class files inside entry
if (entryPath.startsWith(rootEntryPath) && entryPath.endsWith(".class")) {
LOGGER.trace("Visiting JAR entry {}", entryPath);
visitor.visit(jarFile.getInputStream(entry));
}
}
}
#location 15
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public void defineBean(BeanDefinition candidate) {
synchronized (getClass()) { // TODO sychronize on DefaultListableFactory.beanDefinitionMap?
ScopeMetadata scopeMetadata = this.scopeMetadataResolver.resolveScopeMetadata(candidate);
candidate.setScope(scopeMetadata.getScopeName());
String beanName = this.beanNameGenerator.generateBeanName(candidate, registry);
if (candidate instanceof AbstractBeanDefinition) {
postProcessBeanDefinition((AbstractBeanDefinition) candidate, beanName);
}
if (candidate instanceof AnnotatedBeanDefinition) {
processCommonDefinitionAnnotations((AnnotatedBeanDefinition) candidate);
}
removeIfExists(beanName);
BeanDefinitionHolder definitionHolder = new BeanDefinitionHolder(candidate, beanName);
definitionHolder = applyScopedProxyMode(scopeMetadata, definitionHolder, registry);
LOGGER.reload("Registering Spring bean '{}'", beanName);
LOGGER.debug("Bean definition '{}'", beanName, candidate);
registerBeanDefinition(definitionHolder, registry);
freezeConfiguration();
}
ProxyReplacer.clearAllProxies();
} | #vulnerable code
public void defineBean(BeanDefinition candidate) {
synchronized (getClass()) { // TODO sychronize on DefaultListableFactory.beanDefinitionMap?
ScopeMetadata scopeMetadata = this.scopeMetadataResolver.resolveScopeMetadata(candidate);
candidate.setScope(scopeMetadata.getScopeName());
String beanName = this.beanNameGenerator.generateBeanName(candidate, registry);
if (candidate instanceof AbstractBeanDefinition) {
postProcessBeanDefinition((AbstractBeanDefinition) candidate, beanName);
}
if (candidate instanceof AnnotatedBeanDefinition) {
processCommonDefinitionAnnotations((AnnotatedBeanDefinition) candidate);
}
clearCahceIfExists(beanName);
DefaultListableBeanFactory bf = maybeRegistryToBeanFactory();
// use previous singleton bean, if modified class is not bean, a exception will be throw
Object bean;
try {
bean = bf.getBean(beanName);
} catch (NoSuchBeanDefinitionException e) {
LOGGER.warning("{} is not managed by spring", beanName);
return;
}
BeanWrapper bw = new BeanWrapperImpl(bf.getBean(beanName));
RootBeanDefinition rootBeanDefinition = (RootBeanDefinition)ReflectionHelper.invoke(bf, AbstractBeanFactory.class,
"getMergedLocalBeanDefinition", new Class[]{String.class},
beanName);
ReflectionHelper.invoke(bf, AbstractAutowireCapableBeanFactory.class,
"populateBean", new Class[]{String.class, RootBeanDefinition.class, BeanWrapper.class},
beanName,rootBeanDefinition , bw);
freezeConfiguration();
ProxyReplacer.clearAllProxies();
}
}
#location 20
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public static void configureLog(Properties properties) {
for (String property : properties.stringPropertyNames()) {
if (property.startsWith(LOGGER_PREFIX)) {
String classPrefix = getClassPrefix(property);
AgentLogger.Level level = getLevel(property, properties.getProperty(property));
if (level != null) {
if (classPrefix == null)
AgentLogger.setLevel(level);
else
AgentLogger.setLevel(classPrefix, level);
}
} else if (property.equals(LOGFILE)) {
String logfile = properties.getProperty(LOGFILE);
boolean append = parseBoolean(properties.getProperty(LOGFILE_APPEND, "false"));
try {
PrintStream ps = new PrintStream(new FileOutputStream(new File(logfile), append));
AgentLogger.getHandler().setPrintStream(ps);
} catch (FileNotFoundException e) {
LOGGER.error("Invalid configuration property {} value '{}'. Unable to create/open the file.",
e, LOGFILE, logfile);
}
}
}
} | #vulnerable code
public static void configureLog(Properties properties) {
for (String property : properties.stringPropertyNames()) {
if (property.startsWith(LOGGER_PREFIX)) {
String classPrefix = getClassPrefix(property);
AgentLogger.Level level = getLevel(property, properties.getProperty(property));
if (level != null) {
if (classPrefix == null)
AgentLogger.setLevel(level);
else
AgentLogger.setLevel(classPrefix, level);
}
} else if (property.equals(LOGFILE)) {
String logfile = properties.getProperty(LOGFILE);
try {
AgentLogger.getHandler().setPrintStream(new PrintStream(new File(logfile)));
} catch (FileNotFoundException e) {
LOGGER.error("Invalid configuration property {} value '{}'. Unable to create/open the file.",
e, LOGFILE, logfile);
}
}
}
}
#location 16
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
private void scanJar(String urlFile, ScannerVisitor visitor) throws IOException {
LOGGER.trace("Scanning JAR file '{}'", urlFile);
int separatorIndex = urlFile.indexOf(JAR_URL_SEPARATOR);
JarFile jarFile = null;
String rootEntryPath;
try {
if (separatorIndex != -1) {
String jarFileUrl = urlFile.substring(0, separatorIndex);
rootEntryPath = urlFile.substring(separatorIndex + JAR_URL_SEPARATOR.length());
jarFile = getJarFile(jarFileUrl);
} else {
rootEntryPath = "";
jarFile = new JarFile(urlFile);
}
if (!"".equals(rootEntryPath) && !rootEntryPath.endsWith("/")) {
rootEntryPath = rootEntryPath + "/";
}
for (Enumeration<JarEntry> entries = jarFile.entries(); entries.hasMoreElements(); ) {
JarEntry entry = entries.nextElement();
String entryPath = entry.getName();
// class files inside entry
if (entryPath.startsWith(rootEntryPath) && entryPath.endsWith(".class")) {
LOGGER.trace("Visiting JAR entry {}", entryPath);
visitor.visit(jarFile.getInputStream(entry));
}
}
} finally {
if (jarFile != null) {
jarFile.close();
}
}
} | #vulnerable code
private void scanJar(String urlFile, ScannerVisitor visitor) throws IOException {
LOGGER.trace("Scanning JAR file '{}'", urlFile);
int separatorIndex = urlFile.indexOf(JAR_URL_SEPARATOR);
JarFile jarFile;
String rootEntryPath;
if (separatorIndex != -1) {
String jarFileUrl = urlFile.substring(0, separatorIndex);
rootEntryPath = urlFile.substring(separatorIndex + JAR_URL_SEPARATOR.length());
jarFile = getJarFile(jarFileUrl);
} else {
rootEntryPath = "";
jarFile = new JarFile(urlFile);
}
if (!"".equals(rootEntryPath) && !rootEntryPath.endsWith("/")) {
rootEntryPath = rootEntryPath + "/";
}
for (Enumeration<JarEntry> entries = jarFile.entries(); entries.hasMoreElements(); ) {
JarEntry entry = entries.nextElement();
String entryPath = entry.getName();
// class files inside entry
if (entryPath.startsWith(rootEntryPath) && entryPath.endsWith(".class")) {
LOGGER.trace("Visiting JAR entry {}", entryPath);
visitor.visit(jarFile.getInputStream(entry));
}
}
}
#location 15
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public void refreshProxiedFactory() throws NoSuchMethodException, InvocationTargetException, IllegalAccessException, NoSuchFieldException {
// refresh registry
try {
Class entityManagerFactoryRegistryClazz = loadClass("org.hibernate.ejb.internal.EntityManagerFactoryRegistry");
Object instance = ReflectionHelper.get(null, entityManagerFactoryRegistryClazz, "INSTANCE");
ReflectionHelper.invoke(instance, entityManagerFactoryRegistryClazz, "removeEntityManagerFactory",
new Class[] {String.class, EntityManagerFactory.class}, persistenceUnitName, currentInstance);
} catch (Exception e) {
LOGGER.error("Unable to clear previous instance of entity manager factory");
}
buildFreshEntityManagerFactory();
} | #vulnerable code
public void refreshProxiedFactory() throws NoSuchMethodException, InvocationTargetException, IllegalAccessException, NoSuchFieldException {
// refresh registry
EntityManagerFactoryRegistry.INSTANCE.removeEntityManagerFactory(persistenceUnitName, currentInstance);
// from HibernatePersistence.createContainerEntityManagerFactory()
buildFreshEntityManagerFactory();
}
#location 6
#vulnerability type THREAD_SAFETY_VIOLATION | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
private void savePolicyFile(String text) {
try (FileOutputStream fos = new FileOutputStream(filePath)) {
IOUtils.write(text, fos, Charset.forName("UTF-8"));
} catch (IOException e) {
e.printStackTrace();
throw new Error("Policy save error");
}
} | #vulnerable code
private void savePolicyFile(String text) {
try {
FileOutputStream fos = new FileOutputStream(filePath);
fos.write(text.getBytes());
fos.close();
} catch (IOException e) {
e.printStackTrace();
throw new Error("IO error occurred");
}
}
#location 6
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void testSpliter() throws IOException {
SharedBufferPool sharedPool = new SharedBufferPool(1024 * 1024 * 100, 10240);
ReactorBufferPool reactBufferPool = new ReactorBufferPool(sharedPool, Thread.currentThread(), 1000);
ByteBufferArray bufArray = reactBufferPool.allocate();
bufArray.addNewBuffer();
int readBufferOffset = 0;
// @todo 构造符合MYSQL报文的数据包，进行测试
ByteArrayInputStream mysqlPackgsStream = createMysgqlPackages();
while (mysqlPackgsStream.available() > 0) {
ByteBuffer curBuf = bufArray.getLastByteBuffer();
if (!curBuf.hasRemaining()) {
curBuf = bufArray.addNewBuffer();
}
byte[] data = new byte[curBuf.remaining()];
int readed = mysqlPackgsStream.read(data);
curBuf.put(data, 0, readed);
readBufferOffset = CommonPackageUtil.parsePackages(bufArray, curBuf, readBufferOffset);
}
Assert.assertEquals(PACKAGES_COUNT, bufArray.getCurPacageIndex());
} | #vulnerable code
@Test
public void testSpliter() throws IOException {
String testS = "test data only for ";
SharedBufferPool sharedPool = new SharedBufferPool(1024 * 1024 * 100, testS.length() + 4);
ReactorBufferPool reactBufferPool = new ReactorBufferPool(sharedPool, Thread.currentThread(), 1000);
ByteBufferArray bufArray = reactBufferPool.allocate();
bufArray.addNewBuffer();
int readBufferOffset = 0;
// @todo 构造符合MYSQL报文的数据包，进行测试
ByteArrayInputStream mysqlPackgsStream = createMysgqlPackages();
while (mysqlPackgsStream.available() > 0) {
ByteBuffer curBuf = bufArray.getLastByteBuffer();
if(!curBuf.hasRemaining())
{
curBuf=bufArray.addNewBuffer();
}
byte[] data = new byte[curBuf.remaining()];
int readed = mysqlPackgsStream.read(data);
curBuf.put(data, 0, readed);
readBufferOffset = CommonPackageUtil.parsePackages(bufArray, curBuf, readBufferOffset);
}
Assert.assertEquals(10, bufArray.getCurPacageIndex());
}
#location 12
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void testPostWithMultipartFormFieldsAndFile() throws IOException {
String fileName = "GrandCanyon.txt";
String fileContent = HttpPostRequestTest.VALUE;
String divider = UUID.randomUUID().toString();
String header = "POST " + HttpServerTest.URI + " HTTP/1.1\nContent-Type: " + "multipart/form-data; boundary=" + divider + "\n";
String content =
"--" + divider + "\r\n" + "Content-Disposition: form-data; name=\"" + HttpPostRequestTest.FIELD + "\"; filename=\"" + fileName + "\"\r\n"
+ "Content-Type: image/jpeg\r\n" + "\r\n" + fileContent + "\r\n" + "--" + divider + "\r\n" + "Content-Disposition: form-data; name=\""
+ HttpPostRequestTest.FIELD2 + "\"\r\n" + "\r\n" + HttpPostRequestTest.VALUE2 + "\r\n" + "--" + divider + "--\r\n";
int size = content.length() + header.length();
int contentLengthHeaderValueSize = String.valueOf(size).length();
int contentLength = size + contentLengthHeaderValueSize + HttpPostRequestTest.CONTENT_LENGTH.length();
String input = header + HttpPostRequestTest.CONTENT_LENGTH + (contentLength + 4) + "\r\n\r\n" + content;
invokeServer(input);
assertEquals("Parms count did not match.", 2, this.testServer.parms.size());
assertEquals("Parameters count did not match.", 2, this.testServer.parameters.size());
assertEquals("Param value did not match", HttpPostRequestTest.VALUE2, this.testServer.parms.get(HttpPostRequestTest.FIELD2));
assertEquals("Parameter value did not match", HttpPostRequestTest.VALUE2, this.testServer.parameters.get(HttpPostRequestTest.FIELD2).get(0));
BufferedReader reader = new BufferedReader(new FileReader(this.testServer.files.get(HttpPostRequestTest.FIELD)));
List<String> lines = readLinesFromFile(reader);
assertLinesOfText(new String[]{
fileContent
}, lines);
} | #vulnerable code
@Test
public void testPostWithMultipartFormFieldsAndFile() throws IOException {
String fileName = "GrandCanyon.txt";
String fileContent = HttpPostRequestTest.VALUE;
String divider = UUID.randomUUID().toString();
String header = "POST " + HttpServerTest.URI + " HTTP/1.1\nContent-Type: " + "multipart/form-data; boundary=" + divider + "\n";
String content =
"--" + divider + "\r\n" + "Content-Disposition: form-data; name=\"" + HttpPostRequestTest.FIELD + "\"; filename=\"" + fileName + "\"\r\n"
+ "Content-Type: image/jpeg\r\n" + "\r\n" + fileContent + "\r\n" + "--" + divider + "\r\n" + "Content-Disposition: form-data; name=\""
+ HttpPostRequestTest.FIELD2 + "\"\r\n" + "\r\n" + HttpPostRequestTest.VALUE2 + "\r\n" + "--" + divider + "--\r\n";
int size = content.length() + header.length();
int contentLengthHeaderValueSize = String.valueOf(size).length();
int contentLength = size + contentLengthHeaderValueSize + HttpPostRequestTest.CONTENT_LENGTH.length();
String input = header + HttpPostRequestTest.CONTENT_LENGTH + (contentLength + 4) + "\r\n\r\n" + content;
invokeServer(input);
assertEquals("Parameter count did not match.", 2, this.testServer.parms.size());
assertEquals("Parameter value did not match", HttpPostRequestTest.VALUE2, this.testServer.parms.get(HttpPostRequestTest.FIELD2));
BufferedReader reader = new BufferedReader(new FileReader(this.testServer.files.get(HttpPostRequestTest.FIELD)));
List<String> lines = readLinesFromFile(reader);
assertLinesOfText(new String[]{
fileContent
}, lines);
}
#location 21
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
private void sendBodyWithCorrectTransferAndEncoding(OutputStream outputStream, long pending) throws IOException {
if (this.requestMethod != Method.HEAD && this.chunkedTransfer) {
ChunkedOutputStream chunkedOutputStream = new ChunkedOutputStream(outputStream);
sendBodyWithCorrectEncoding(chunkedOutputStream, -1);
try {
chunkedOutputStream.finish();
} catch (Exception e) {
if(this.data != null) {
this.data.close();
}
}
} else {
sendBodyWithCorrectEncoding(outputStream, pending);
}
} | #vulnerable code
private void sendBodyWithCorrectTransferAndEncoding(OutputStream outputStream, long pending) throws IOException {
if (this.requestMethod != Method.HEAD && this.chunkedTransfer) {
ChunkedOutputStream chunkedOutputStream = new ChunkedOutputStream(outputStream);
sendBodyWithCorrectEncoding(chunkedOutputStream, -1);
chunkedOutputStream.finish();
} else {
sendBodyWithCorrectEncoding(outputStream, pending);
}
}
#location 5
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void shutdown() throws Exception {
Client client = TestGraphUtil.instance.createClient();
client.getDelegate().shutdown();
} | #vulnerable code
@Test
public void shutdown() throws Exception {
Client client = TestGraphUtil.instance.createClient();
client.delegate().shutdown();
}
#location 4
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public static void load(final JanusGraph graph, final int rowsToLoad, final boolean report)
throws IOException, InterruptedException {
final JanusGraphManagement mgmt = graph.openManagement();
if (mgmt.getGraphIndex(CHARACTER) == null) {
final PropertyKey characterKey = mgmt.makePropertyKey(CHARACTER).dataType(String.class).make();
mgmt.buildIndex(CHARACTER, Vertex.class).addKey(characterKey).unique().buildCompositeIndex();
}
if (mgmt.getGraphIndex(COMIC_BOOK) == null) {
final PropertyKey comicBookKey = mgmt.makePropertyKey(COMIC_BOOK).dataType(String.class).make();
mgmt.buildIndex(COMIC_BOOK, Vertex.class).addKey(comicBookKey).unique().buildCompositeIndex();
mgmt.makePropertyKey(WEAPON).dataType(String.class).make();
mgmt.makeEdgeLabel(APPEARED).multiplicity(Multiplicity.MULTI).make();
}
mgmt.commit();
final ClassLoader classLoader = MarvelGraphFactory.class.getClassLoader();
final URL resource = classLoader.getResource("META-INF/marvel.csv");
Preconditions.checkNotNull(resource);
final Map<String, Set<String>> comicToCharacter = new HashMap<>();
final Map<String, Set<String>> characterToComic = new HashMap<>();
final Set<String> characters = new HashSet<>();
final BlockingQueue<Runnable> creationQueue = new LinkedBlockingQueue<>();
try (CSVReader reader = new CSVReader(new InputStreamReader(resource.openStream(), Charset.forName("UTF-8")))) {
reader.readAll().subList(0, rowsToLoad).forEach(nextLine -> {
final String comicBook = nextLine[1];
final String[] characterNames = nextLine[0].split("/");
if (!comicToCharacter.containsKey(comicBook)) {
comicToCharacter.put(comicBook, new HashSet<>());
}
final List<String> comicCharacters = Arrays.asList(characterNames);
comicToCharacter.get(comicBook).addAll(comicCharacters);
characters.addAll(comicCharacters);
});
}
creationQueue.addAll(characters.stream().map(character -> new CharacterCreationCommand(character, graph))
.collect(Collectors.toList()));
final BlockingQueue<Runnable> appearedQueue = new LinkedBlockingQueue<>();
for (Map.Entry<String, Set<String>> entry : comicToCharacter.entrySet()) {
final String comicBook = entry.getKey();
final Set<String> comicCharacters = entry.getValue();
creationQueue.add(new ComicBookCreationCommand(comicBook, graph));
for (String character : comicCharacters) {
final AppearedCommand lineCommand = new AppearedCommand(graph, new Appeared(character, comicBook));
appearedQueue.add(lineCommand);
if (!characterToComic.containsKey(character)) {
characterToComic.put(character, new HashSet<String>());
}
characterToComic.get(character).add(comicBook);
}
REGISTRY.histogram("histogram.comic-to-character").update(comicCharacters.size());
}
int maxAppearances = 0;
String maxCharacter = "";
for (Map.Entry<String, Set<String>> entry : characterToComic.entrySet()) {
final String character = entry.getKey();
final Set<String> comicBookSet = entry.getValue();
final int numberOfAppearances = comicBookSet.size();
REGISTRY.histogram("histogram.character-to-comic").update(numberOfAppearances);
if (numberOfAppearances > maxAppearances) {
maxCharacter = character;
maxAppearances = numberOfAppearances;
}
}
log.info("Character {} has most appearances at {}", maxCharacter, maxAppearances);
ExecutorService executor = Executors.newFixedThreadPool(POOL_SIZE);
for (int i = 0; i < POOL_SIZE; i++) {
executor.execute(new BatchCommand(graph, creationQueue));
}
executor.shutdown();
while (!executor.awaitTermination(TIMEOUT_SIXTY_SECONDS, TimeUnit.SECONDS)) {
log.info("Awaiting:" + creationQueue.size());
if (report) {
REPORTER.report();
}
}
executor = Executors.newSingleThreadExecutor();
executor.execute(new BatchCommand(graph, appearedQueue));
executor.shutdown();
while (!executor.awaitTermination(TIMEOUT_SIXTY_SECONDS, TimeUnit.SECONDS)) {
log.info("Awaiting:" + appearedQueue.size());
if (report) {
REPORTER.report();
}
}
log.info("MarvelGraph.load complete");
} | #vulnerable code
public static void load(final JanusGraph graph, final int rowsToLoad, final boolean report)
throws IOException, InterruptedException {
final JanusGraphManagement mgmt = graph.openManagement();
if (mgmt.getGraphIndex(CHARACTER) == null) {
final PropertyKey characterKey = mgmt.makePropertyKey(CHARACTER).dataType(String.class).make();
mgmt.buildIndex(CHARACTER, Vertex.class).addKey(characterKey).unique().buildCompositeIndex();
}
if (mgmt.getGraphIndex(COMIC_BOOK) == null) {
final PropertyKey comicBookKey = mgmt.makePropertyKey(COMIC_BOOK).dataType(String.class).make();
mgmt.buildIndex(COMIC_BOOK, Vertex.class).addKey(comicBookKey).unique().buildCompositeIndex();
mgmt.makePropertyKey(WEAPON).dataType(String.class).make();
mgmt.makeEdgeLabel(APPEARED).multiplicity(Multiplicity.MULTI).make();
}
mgmt.commit();
final ClassLoader classLoader = MarvelGraphFactory.class.getClassLoader();
final URL resource = classLoader.getResource("META-INF/marvel.csv");
Preconditions.checkNotNull(resource);
final Map<String, Set<String>> comicToCharacter = new HashMap<>();
final Map<String, Set<String>> characterToComic = new HashMap<>();
final Set<String> characters = new HashSet<>();
final BlockingQueue<Runnable> creationQueue = new LinkedBlockingQueue<>();
try (CSVReader reader = new CSVReader(new InputStreamReader(resource.openStream()))) {
reader.readAll().subList(0, rowsToLoad).forEach(nextLine -> {
final String comicBook = nextLine[1];
final String[] characterNames = nextLine[0].split("/");
if (!comicToCharacter.containsKey(comicBook)) {
comicToCharacter.put(comicBook, new HashSet<>());
}
final List<String> comicCharacters = Arrays.asList(characterNames);
comicToCharacter.get(comicBook).addAll(comicCharacters);
characters.addAll(comicCharacters);
});
}
creationQueue.addAll(characters.stream().map(character -> new CharacterCreationCommand(character, graph))
.collect(Collectors.toList()));
final BlockingQueue<Runnable> appearedQueue = new LinkedBlockingQueue<>();
for (String comicBook : comicToCharacter.keySet()) {
creationQueue.add(new ComicBookCreationCommand(comicBook, graph));
final Set<String> comicCharacters = comicToCharacter.get(comicBook);
for (String character : comicCharacters) {
final AppearedCommand lineCommand = new AppearedCommand(graph, new Appeared(character, comicBook));
appearedQueue.add(lineCommand);
if (!characterToComic.containsKey(character)) {
characterToComic.put(character, new HashSet<String>());
}
characterToComic.get(character).add(comicBook);
}
REGISTRY.histogram("histogram.comic-to-character").update(comicCharacters.size());
}
int maxAppearances = 0;
String maxCharacter = "";
for (String character : characterToComic.keySet()) {
final Set<String> comicBookSet = characterToComic.get(character);
final int numberOfAppearances = comicBookSet.size();
REGISTRY.histogram("histogram.character-to-comic").update(numberOfAppearances);
if (numberOfAppearances > maxAppearances) {
maxCharacter = character;
maxAppearances = numberOfAppearances;
}
}
log.info("Character {} has most appearances at {}", maxCharacter, maxAppearances);
ExecutorService executor = Executors.newFixedThreadPool(POOL_SIZE);
for (int i = 0; i < POOL_SIZE; i++) {
executor.execute(new BatchCommand(graph, creationQueue));
}
executor.shutdown();
while (!executor.awaitTermination(TIMEOUT_SIXTY_SECONDS, TimeUnit.SECONDS)) {
log.info("Awaiting:" + creationQueue.size());
if (report) {
REPORTER.report();
}
}
executor = Executors.newSingleThreadExecutor();
executor.execute(new BatchCommand(graph, appearedQueue));
executor.shutdown();
while (!executor.awaitTermination(TIMEOUT_SIXTY_SECONDS, TimeUnit.SECONDS)) {
log.info("Awaiting:" + appearedQueue.size());
if (report) {
REPORTER.report();
}
}
log.info("MarvelGraph.load complete");
}
#location 43
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public List<Category> getFriendList() {
LOGGER.info("开始获取好友列表");
JSONObject r = new JSONObject();
r.put("vfwebqq", vfwebqq);
r.put("hash", hash());
try {
HttpPost post = defaultHttpPost(ApiUrl.GET_FRIEND_LIST, new BasicNameValuePair("r", r.toJSONString()));
try (CloseableHttpClient client = HttpClients.createDefault();
CloseableHttpResponse response = client.execute(post, context)) {
JSONObject responseJson = JSON.parseObject(getResponseText(response));
if (0 == responseJson.getIntValue("retcode")) {
JSONObject result = responseJson.getJSONObject("result");
//获得分组
JSONArray categories = result.getJSONArray("categories");
Map<Integer, Category> categoryMap = new HashMap<>();
categoryMap.put(0, Category.defaultCategory());
for (int i = 0; categories != null && i < categories.size(); i++) {
Category category = categories.getObject(i, Category.class);
categoryMap.put(category.getIndex(), category);
}
//获得好友信息
Map<Long, Friend> friendMap = new HashMap<>();
JSONArray friends = result.getJSONArray("friends");
for (int i = 0; friends != null && i < friends.size(); i++) {
JSONObject item = friends.getJSONObject(i);
Friend friend = new Friend();
friend.setUserId(item.getLongValue("uin"));
friendMap.put(friend.getUserId(), friend);
categoryMap.get(item.getIntValue("categories")).addFriend(friend);
}
JSONArray marknames = result.getJSONArray("marknames");
for (int i = 0; marknames != null && i < marknames.size(); i++) {
JSONObject item = marknames.getJSONObject(i);
friendMap.get(item.getLongValue("uin")).setMarkname(item.getString("markname"));
}
JSONArray info = result.getJSONArray("info");
for (int i = 0; info != null && i < info.size(); i++) {
JSONObject item = info.getJSONObject(i);
friendMap.get(item.getLongValue("uin")).setNickname(item.getString("nick"));
}
JSONArray vipinfo = result.getJSONArray("vipinfo");
for (int i = 0; vipinfo != null && i < vipinfo.size(); i++) {
JSONObject item = vipinfo.getJSONObject(i);
Friend friend = friendMap.get(item.getLongValue("u"));
friend.setVip(item.getIntValue("is_vip") == 1);
friend.setVipLevel(item.getIntValue("vip_level"));
}
return new ArrayList<>(categoryMap.values());
} else {
LOGGER.error("获取好友列表失败");
}
} catch (IOException e) {
LOGGER.error("获取好友列表失败");
}
} catch (UnsupportedEncodingException e) {
LOGGER.error("获取好友列表失败");
}
return Collections.EMPTY_LIST;
} | #vulnerable code
public List<Category> getFriendList() {
LOGGER.info("开始获取好友列表");
HttpPost post = defaultHttpPost(
"http://s.web2.qq.com/api/get_user_friends2",
"http://s.web2.qq.com/proxy.html?v=20130916001&callback=1&id=1");
JSONObject r = new JSONObject();
r.put("vfwebqq", vfwebqq);
r.put("hash", hash());
try {
post.setEntity(new UrlEncodedFormEntity(Arrays.asList(new BasicNameValuePair("r", r.toJSONString()))));
try (CloseableHttpResponse response = client.execute(post, context)) {
JSONObject responseJson = JSON.parseObject(getResponseText(response));
if (0 == responseJson.getIntValue("retcode")) {
JSONObject result = responseJson.getJSONObject("result");
//获得分组
JSONArray categories = result.getJSONArray("categories");
Map<Integer, Category> categoryMap = new HashMap<>();
categoryMap.put(0, Category.defaultCategory());
for (int i = 0; categories != null && i < categories.size(); i++) {
Category category = categories.getObject(i, Category.class);
categoryMap.put(category.getIndex(), category);
}
//获得好友信息
Map<Long, Friend> friendMap = new HashMap<>();
JSONArray friends = result.getJSONArray("friends");
for (int i = 0; friends != null && i < friends.size(); i++) {
JSONObject item = friends.getJSONObject(i);
Friend friend = new Friend();
friend.setUserId(item.getLongValue("uin"));
friendMap.put(friend.getUserId(), friend);
categoryMap.get(item.getIntValue("categories")).addFriend(friend);
}
JSONArray marknames = result.getJSONArray("marknames");
for (int i = 0; marknames != null && i < marknames.size(); i++) {
JSONObject item = marknames.getJSONObject(i);
friendMap.get(item.getLongValue("uin")).setMarkname(item.getString("markname"));
}
JSONArray info = result.getJSONArray("info");
for (int i = 0; info != null && i < info.size(); i++) {
JSONObject item = info.getJSONObject(i);
friendMap.get(item.getLongValue("uin")).setNickname(item.getString("nick"));
}
JSONArray vipinfo = result.getJSONArray("vipinfo");
for (int i = 0; vipinfo != null && i < vipinfo.size(); i++) {
JSONObject item = vipinfo.getJSONObject(i);
Friend friend = friendMap.get(item.getLongValue("u"));
friend.setVip(item.getIntValue("is_vip") == 1);
friend.setVipLevel(item.getIntValue("vip_level"));
}
return new ArrayList<>(categoryMap.values());
} else {
LOGGER.error("获取好友列表失败");
}
} catch (IOException e) {
LOGGER.error("获取好友列表失败");
}
} catch (UnsupportedEncodingException e) {
LOGGER.error("获取好友列表失败");
}
return Collections.EMPTY_LIST;
}
#location 31
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void shouldCreateConversationThenJoinAndSendOfferRequest() throws Exception {
// given
MessageMatcher s1Matcher = new MessageMatcher();
MessageMatcher s2Matcher = new MessageMatcher();
Session s1 = mockSession("s1", s1Matcher);
Session s2 = mockSession("s2", s2Matcher);
server.register(s1);
server.register(s2);
// when
server.handle(Message.create()//
.signal("create")//
.build(), s1);
String conversationKey = s1Matcher.getMessage().getContent();
s1Matcher.reset();
server.handle(Message.create()//
.signal("join")//
.content(conversationKey)//
.build(), s2);
// then
assertThat(s1Matcher.getMessages().size(), is(2));
assertMatch(s1Matcher, 0, "s2", "s1", "joined", EMPTY);
assertMatch(s1Matcher, 1, "s2", "s1", "offerRequest", EMPTY);
assertThat(s2Matcher.getMessages().size(), is(1));
assertMatch(s2Matcher, 0, EMPTY, "s2", "joined", conversationKey);
} | #vulnerable code
@Test
public void shouldCreateConversationThenJoinAndSendOfferRequest() throws Exception {
// given
MessageMatcher s1Matcher = new MessageMatcher();
MessageMatcher s2Matcher = new MessageMatcher();
Session s1 = mockSession("s1", s1Matcher);
Session s2 = mockSession("s2", s2Matcher);
server.register(s1);
server.register(s2);
// when
server.handle(Message.create()//
.signal("create")//
.build(), s1);
String conversationKey = s1Matcher.getMessage().getContent();
s1Matcher.reset();
server.handle(Message.create()//
.signal("join")//
.content(conversationKey)//
.build(), s2);
// then
assertThat(s1Matcher.getMessages().size(), is(2));
assertThat(s1Matcher.getMessage().getFrom(), is("s2"));
assertThat(s1Matcher.getMessage().getTo(), is("s1"));
assertThat(s1Matcher.getMessage().getSignal(), is("joined"));
assertThat(s1Matcher.getMessage(1).getFrom(), is("s2"));
assertThat(s1Matcher.getMessage(1).getTo(), is("s1"));
assertThat(s1Matcher.getMessage(1).getSignal(), is("offerRequest"));
assertThat(s2Matcher.getMessages().size(), is(1));
assertThat(s2Matcher.getMessage().getSignal(), is("joined"));
assertThat(s2Matcher.getMessage().getContent(), is(conversationKey));
}
#location 29
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public void handleError(Session s, Throwable exception) {
doSaveExecution(s, session -> {
members.unregister(session.getId());
eventBus.post(UNEXPECTED_SITUATION.occurFor(session, exception.getMessage()));
}
);
} | #vulnerable code
public void handleError(Session s, Throwable exception) {
doSaveExecution(new SessionWrapper(s), session -> {
members.unregister(session.getId());
eventBus.post(UNEXPECTED_SITUATION.occurFor(session, exception.getMessage()));
}
);
}
#location 2
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void shouldCreateConversation() throws Exception {
// given
MessageMatcher matcher = new MessageMatcher();
InternalMessage message = InternalMessage.create()//
.from(Member.create()//
.session(mockSession("sessionId", matcher))//
.build())//
.signal(create)//
.content("c1")//
.build();
// when
create.executeMessage(message);
// then
Optional<Conversation> conv = conversations.findBy("c1");
assertTrue(conv.isPresent());
Message send = matcher.getMessage();
assertNotNull(send);
assertThat(send.getFrom(), is(EMPTY));
assertThat(send.getTo(), is("sessionId"));
assertThat(send.getSignal(), is("created"));
assertThat(send.getContent(), is("c1"));
assertThat(send.getParameters(), notNullValue());
} | #vulnerable code
@Test
public void shouldCreateConversation() throws Exception {
// given
MessageMatcher matcher = new MessageMatcher();
InternalMessage message = InternalMessage.create()//
.from(Member.builder()//
.session(mockSession("sessionId", matcher))//
.build())//
.signal(create)//
.content("c1")//
.build();
// when
create.executeMessage(message);
// then
Optional<Conversation> conv = conversations.findBy("c1");
assertTrue(conv.isPresent());
Message send = matcher.getMessage();
assertNotNull(send);
assertThat(send.getFrom(), is(EMPTY));
assertThat(send.getTo(), is("sessionId"));
assertThat(send.getSignal(), is("created"));
assertThat(send.getContent(), is("c1"));
assertThat(send.getParameters(), notNullValue());
}
#location 21
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void shouldCreateConversationThenJoinAndSendOfferRequest() throws Exception {
// given
MessageMatcher s1Matcher = new MessageMatcher();
MessageMatcher s2Matcher = new MessageMatcher();
Session s1 = mockSession("s1", s1Matcher);
Session s2 = mockSession("s2", s2Matcher);
server.register(s1);
server.register(s2);
// when
server.handle(Message.create()//
.signal("create")//
.build(), s1);
String conversationKey = s1Matcher.getMessage().getContent();
s1Matcher.reset();
server.handle(Message.create()//
.signal("join")//
.content(conversationKey)//
.build(), s2);
// then
assertThat(s1Matcher.getMessages().size(), is(2));
assertMatch(s1Matcher, 0, "s2", "s1", "joined", EMPTY);
assertMatch(s1Matcher, 1, "s2", "s1", "offerRequest", EMPTY);
assertThat(s2Matcher.getMessages().size(), is(1));
assertMatch(s2Matcher, 0, EMPTY, "s2", "joined", conversationKey);
} | #vulnerable code
@Test
public void shouldCreateConversationThenJoinAndSendOfferRequest() throws Exception {
// given
MessageMatcher s1Matcher = new MessageMatcher();
MessageMatcher s2Matcher = new MessageMatcher();
Session s1 = mockSession("s1", s1Matcher);
Session s2 = mockSession("s2", s2Matcher);
server.register(s1);
server.register(s2);
// when
server.handle(Message.create()//
.signal("create")//
.build(), s1);
String conversationKey = s1Matcher.getMessage().getContent();
s1Matcher.reset();
server.handle(Message.create()//
.signal("join")//
.content(conversationKey)//
.build(), s2);
// then
assertThat(s1Matcher.getMessages().size(), is(2));
assertThat(s1Matcher.getMessage().getFrom(), is("s2"));
assertThat(s1Matcher.getMessage().getTo(), is("s1"));
assertThat(s1Matcher.getMessage().getSignal(), is("joined"));
assertThat(s1Matcher.getMessage(1).getFrom(), is("s2"));
assertThat(s1Matcher.getMessage(1).getTo(), is("s1"));
assertThat(s1Matcher.getMessage(1).getSignal(), is("offerRequest"));
assertThat(s2Matcher.getMessages().size(), is(1));
assertThat(s2Matcher.getMessage().getSignal(), is("joined"));
assertThat(s2Matcher.getMessage().getContent(), is(conversationKey));
}
#location 30
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
private void send(InternalMessage message, int retry) {
if (message.getSignal() != Signal.PING) {
log.debug("Outgoing: " + message.transformToExternalMessage());
}
if (message.getSignal() == Signal.ERROR) {
tryToSendErrorMessage(message);
return;
}
Member destination = message.getTo();
if (destination == null || !destination.getSession().isOpen()) {
log.warn("Destination member is not set or session is closed! Message will not be send: " + message.transformToExternalMessage());
return;
}
members.findBy(destination.getId()).ifPresent(member ->
lockAndRun(message, member, retry)
);
} | #vulnerable code
private void send(InternalMessage message, int retry) {
Message messageToSend = message.transformToExternalMessage();
if (message.getSignal() != Signal.PING) {
log.info("Outgoing: " + toString());
}
Session destSession = message.getTo().getSession();
if (!destSession.isOpen()) {
log.warn("Session is closed! Message will not be send: ");
return;
}
try {
RemoteEndpoint.Basic basic = destSession.getBasicRemote();
synchronized (basic) {
basic.sendObject(messageToSend);
}
} catch (Exception e) {
if (retry >= 0) {
log.info("Retrying... " + messageToSend);
send(message, --retry);
}
log.error("Unable to send message: " + messageToSend + " error during sending!");
throw new RuntimeException("Unable to send message: " + messageToSend, e);
}
}
#location 6
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void shouldCreateConversationThenJoinAndSendOfferRequest() throws Exception {
// given
MessageMatcher s1Matcher = new MessageMatcher();
MessageMatcher s2Matcher = new MessageMatcher();
Session s1 = mockSession("s1", s1Matcher);
Session s2 = mockSession("s2", s2Matcher);
server.register(s1);
server.register(s2);
// when
server.handle(Message.create()//
.signal("create")//
.build(), s1);
String conversationKey = s1Matcher.getMessage().getContent();
s1Matcher.reset();
server.handle(Message.create()//
.signal("join")//
.content(conversationKey)//
.build(), s2);
// then
assertThat(s1Matcher.getMessages().size(), is(2));
assertMatch(s1Matcher, 0, "s2", "s1", "joined", EMPTY);
assertMatch(s1Matcher, 1, "s2", "s1", "offerRequest", EMPTY);
assertThat(s2Matcher.getMessages().size(), is(1));
assertMatch(s2Matcher, 0, EMPTY, "s2", "joined", conversationKey);
} | #vulnerable code
@Test
public void shouldCreateConversationThenJoinAndSendOfferRequest() throws Exception {
// given
MessageMatcher s1Matcher = new MessageMatcher();
MessageMatcher s2Matcher = new MessageMatcher();
Session s1 = mockSession("s1", s1Matcher);
Session s2 = mockSession("s2", s2Matcher);
server.register(s1);
server.register(s2);
// when
server.handle(Message.create()//
.signal("create")//
.build(), s1);
String conversationKey = s1Matcher.getMessage().getContent();
s1Matcher.reset();
server.handle(Message.create()//
.signal("join")//
.content(conversationKey)//
.build(), s2);
// then
assertThat(s1Matcher.getMessages().size(), is(2));
assertThat(s1Matcher.getMessage().getFrom(), is("s2"));
assertThat(s1Matcher.getMessage().getTo(), is("s1"));
assertThat(s1Matcher.getMessage().getSignal(), is("joined"));
assertThat(s1Matcher.getMessage(1).getFrom(), is("s2"));
assertThat(s1Matcher.getMessage(1).getTo(), is("s1"));
assertThat(s1Matcher.getMessage(1).getSignal(), is("offerRequest"));
assertThat(s2Matcher.getMessages().size(), is(1));
assertThat(s2Matcher.getMessage().getSignal(), is("joined"));
assertThat(s2Matcher.getMessage().getContent(), is(conversationKey));
}
#location 28
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@SuppressWarnings("unchecked")
private Object getListArg(ManagedList<XmlManagedNode> values, Class<?> setterParamType) {
Collection<Object> collection = null;
if (VerifyUtils.isNotEmpty(values.getTypeName())) {
try {
collection = (Collection<Object>) XmlApplicationContext.class
.getClassLoader()
.loadClass(values.getTypeName())
.newInstance();
} catch (Throwable t) {
log.error("list inject error", t);
}
} else {
collection = (setterParamType == null ? new ArrayList<>()
: ConvertUtils.getCollectionObj(setterParamType));
}
if (collection != null) {
for (XmlManagedNode item : values) {
Object listValue = getInjectArg(item, null);
collection.add(listValue);
}
}
return collection;
} | #vulnerable code
@SuppressWarnings("unchecked")
private Object getListArg(ManagedList<XmlManagedNode> values, Class<?> setterParamType) {
Collection<Object> collection = null;
if (VerifyUtils.isNotEmpty(values.getTypeName())) {
try {
collection = (Collection<Object>) XmlApplicationContext.class
.getClassLoader().loadClass(values.getTypeName())
.newInstance();
} catch (Throwable t) {
log.error("list inject error", t);
}
} else {
collection = (setterParamType == null ? new ArrayList<Object>()
: ConvertUtils.getCollectionObj(setterParamType));
}
for (XmlManagedNode item : values) {
Object listValue = getInjectArg(item, null);
collection.add(listValue);
}
return collection;
}
#location 20
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
private void parseProperties(Properties properties) {
for (Entry<Object, Object> entry : properties.entrySet()) {
String name = (String) entry.getKey();
String value = (String) entry.getValue();
String[] strs = StringUtils.split(value, ',');
switch (strs.length) {
case 1:
createLog(name, strs[0], null, false);
break;
case 2:
if("console".equalsIgnoreCase(strs[1])) {
createLog(name, strs[0], null, true);
} else {
createLog(name, strs[0], strs[1], false);
}
break;
case 3:
createLog(name, strs[0], strs[1], "console".equalsIgnoreCase(strs[2]));
break;
default:
System.err.println("The log " + name + " configuration format is illegal. It will use default log configuration");
createLog(name, DEFAULT_LOG_LEVEL, null, false);
break;
}
}
} | #vulnerable code
private void parseProperties(Properties properties) {
for (Entry<Object, Object> entry : properties.entrySet()) {
String name = (String) entry.getKey();
String value = (String) entry.getValue();
// System.out.println(name + "|" + value);
String[] strs = StringUtils.split(value, ',');
if (strs.length < 2) {
System.err.println("the log configuration file format is illegal");
continue;
}
String path = strs[1];
FileLog fileLog = new FileLog();
fileLog.setName(name);
fileLog.setLevel(LogLevel.fromName(strs[0]));
if ("console".equalsIgnoreCase(path)) {
fileLog.setFileOutput(false);
fileLog.setConsoleOutput(true);
} else {
File file = new File(path);
if(file.exists() && file.isDirectory()) {
fileLog.setPath(path);
fileLog.setFileOutput(true);
} else {
boolean success = file.mkdirs();
if(success) {
fileLog.setPath(path);
fileLog.setFileOutput(true);
} else {
System.err.println("create directory " + path + " failure");
continue;
}
}
if (strs.length > 2)
fileLog.setConsoleOutput("console".equalsIgnoreCase(strs[2]));
}
logMap.put(name, fileLog);
System.out.println("initialize log " + fileLog.toString() + " success");
}
}
#location 32
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public static void main(String[] args) {
Calendar cal = Calendar.getInstance();
cal.set(2015, Calendar.JANUARY, 25, 14, 53, 12);
System.out.println(cal.get(Calendar.HOUR_OF_DAY));
DateFormatObject obj = new DateFormatObject();
System.out.println(obj);
obj.init(cal);
String json = Json.toJson(obj);
System.out.println(json);
DateFormatObject obj2 = Json.toObject(json, DateFormatObject.class);
System.out.println(obj2);
} | #vulnerable code
public static void main(String[] args) {
String json = "{ \"key1\":333, \"arrayKey\":[444, \"array\"], \"key2\" : {\"key3\" : \"hello\", \"key4\":\"world\" }, \"booleanKey\" : true } ";
JsonObject jsonObject = Json.toJsonObject(json);
System.out.println(jsonObject.getJsonArray("arrayKey"));
System.out.println(jsonObject.getJsonObject("key2").getString("key4"));
}
#location 5
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public static long copy(File src, File dest, long position, long count) throws IOException {
try(FileInputStream in = new FileInputStream(src);
FileOutputStream out = new FileOutputStream(dest);
FileChannel inChannel = in.getChannel();
FileChannel outChannel = out.getChannel();) {
return inChannel.transferTo(position, count, outChannel);
}
} | #vulnerable code
public static long copy(File src, File dest, long position, long count) throws IOException {
FileInputStream in = new FileInputStream(src);
FileOutputStream out = new FileOutputStream(dest);
FileChannel inChannel = in.getChannel();
FileChannel outChannel = out.getChannel();
try {
return inChannel.transferTo(position, count, outChannel);
} finally {
if (inChannel != null)
inChannel.close();
if (outChannel != null)
outChannel.close();
if (in != null)
in.close();
if (out != null)
out.close();
}
}
#location 17
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public void flush() {
if (fileOutput && buffer.size() > 0) {
try {
for (LogItem logItem = null; (logItem = buffer.poll()) != null;) {
Date d = new Date();
bufferedWriter = getBufferedWriter(LogFactory.dayDateFormat.format(d));
logItem.setDate(SafeSimpleDateFormat.defaultDateFormat.format(d));
bufferedWriter.append(logItem.toString() + CL);
}
bufferedWriter.flush();
} catch (IOException e) {
e.printStackTrace();
}
}
} | #vulnerable code
public void flush() {
if (fileOutput && buffer.size() > 0) {
BufferedWriter bufferedWriter = null;
try {
String date = LogFactory.dayDateFormat.format(new Date());
bufferedWriter = getBufferedWriter(date);
for (LogItem logItem = null; (logItem = buffer.poll()) != null;) {
Date d = new Date();
String newDate = LogFactory.dayDateFormat.format(d);
if(!newDate.equals(date)) {
if (bufferedWriter != null)
try {
bufferedWriter.close();
} catch (IOException e) {
e.printStackTrace();
}
date = newDate;
bufferedWriter = getBufferedWriter(date);
}
logItem.setDate(SafeSimpleDateFormat.defaultDateFormat.format(d));
bufferedWriter.append(logItem.toString() + CL);
}
} catch (IOException e) {
e.printStackTrace();
} finally {
if (bufferedWriter != null)
try {
bufferedWriter.close();
} catch (IOException e) {
e.printStackTrace();
}
}
}
}
#location 23
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void testHeaders() throws Throwable {
final HTTP2ServerDecoder decoder = new HTTP2ServerDecoder();
final HTTP2MockSession session = new HTTP2MockSession();
final HTTP2Configuration http2Configuration = new HTTP2Configuration();
final HTTP2ServerConnection http2ServerConnection = new HTTP2ServerConnection(http2Configuration, session, null,
new ServerSessionListener(){
@Override
public Map<Integer, Integer> onPreface(Session session) {
System.out.println("on preface: " + session.isClosed());
Assert.assertThat(session.isClosed(), is(false));
return null;
}
@Override
public Listener onNewStream(Stream stream, HeadersFrame frame) {
System.out.println("on new stream: " + stream.getId());
System.out.println("on new stread headers: " + frame.getMetaData().toString());
Assert.assertThat(stream.getId(), is(5));
Assert.assertThat(frame.getMetaData().getVersion(), is(HttpVersion.HTTP_2));
Assert.assertThat(frame.getMetaData().getFields().get("User-Agent"), is("Firefly Client 1.0"));
MetaData.Request request = (MetaData.Request) frame.getMetaData();
Assert.assertThat(request.getMethod(), is("GET"));
Assert.assertThat(request.getURI().getPath(), is("/index"));
Assert.assertThat(request.getURI().getPort(), is(8080));
Assert.assertThat(request.getURI().getHost(), is("localhost"));
return new Listener(){
@Override
public void onHeaders(Stream stream, HeadersFrame frame) {
System.out.println("on headers: " + frame.getMetaData());
}
@Override
public Listener onPush(Stream stream, PushPromiseFrame frame) {
return null;
}
@Override
public void onData(Stream stream, DataFrame frame, Callback callback) {
}
@Override
public void onReset(Stream stream, ResetFrame frame) {
}
@Override
public void onTimeout(Stream stream, Throwable x) {
}};
}
@Override
public void onSettings(Session session, SettingsFrame frame) {
System.out.println("on settings: " + frame.toString());
Assert.assertThat(frame.getSettings().get(SettingsFrame.INITIAL_WINDOW_SIZE), is(http2Configuration.getInitialStreamSendWindow()));
}
@Override
public void onPing(Session session, PingFrame frame) {
}
@Override
public void onReset(Session session, ResetFrame frame) {
}
@Override
public void onClose(Session session, GoAwayFrame frame) {
}
@Override
public void onFailure(Session session, Throwable failure) {
}
@Override
public void onAccept(Session session) {
}});
int streamId = 5;
HttpFields fields = new HttpFields();
fields.put("Accept", "text/html");
fields.put("User-Agent", "Firefly Client 1.0");
MetaData.Request metaData = new MetaData.Request("GET", HttpScheme.HTTP,
new HostPortHttpField("localhost:8080"), "/index", HttpVersion.HTTP_2, fields);
Map<Integer, Integer> settings = new HashMap<>();
settings.put(SettingsFrame.HEADER_TABLE_SIZE, http2Configuration.getMaxDynamicTableSize());
settings.put(SettingsFrame.INITIAL_WINDOW_SIZE, http2Configuration.getInitialStreamSendWindow());
Generator generator = new Generator(http2Configuration.getMaxDynamicTableSize(), http2Configuration.getMaxHeaderBlockFragment());
HeadersGenerator headersGenerator = generator.getControlGenerator(FrameType.HEADERS);
SettingsGenerator settingsGenerator = generator.getControlGenerator(FrameType.SETTINGS);
List<ByteBuffer> list = new LinkedList<>();
list.add(ByteBuffer.wrap(PrefaceFrame.PREFACE_BYTES));
list.add(settingsGenerator.generateSettings(settings, false));
list.addAll(headersGenerator.generateHeaders(streamId, metaData, null, true));
for(ByteBuffer buffer : list) {
decoder.decode(buffer, session);
}
Assert.assertThat(session.outboundData.size(), greaterThan(0));
System.out.println("out data: " + session.outboundData.size());
Assert.assertThat(session.outboundData.size(), greaterThan(1));
http2ServerConnection.close();
} | #vulnerable code
@Test
public void testHeaders() throws Throwable {
final HTTP2ServerDecoder decoder = new HTTP2ServerDecoder();
final HTTP2MockSession session = new HTTP2MockSession();
final HTTP2Configuration http2Configuration = new HTTP2Configuration();
final HTTP2ServerConnection http2ServerConnection = new HTTP2ServerConnection(http2Configuration, session, null,
new ServerSessionListener(){
@Override
public Map<Integer, Integer> onPreface(Session session) {
System.out.println("on preface: " + session.isClosed());
Assert.assertThat(session.isClosed(), is(false));
return null;
}
@Override
public Listener onNewStream(Stream stream, HeadersFrame frame) {
System.out.println("on new stream: " + stream.getId());
System.out.println("on new stread headers: " + frame.getMetaData().toString());
Assert.assertThat(stream.getId(), is(5));
Assert.assertThat(frame.getMetaData().getVersion(), is(HttpVersion.HTTP_2));
Assert.assertThat(frame.getMetaData().getFields().get("User-Agent"), is("Firefly Client 1.0"));
MetaData.Request request = (MetaData.Request) frame.getMetaData();
Assert.assertThat(request.getMethod(), is("GET"));
Assert.assertThat(request.getURI().getPath(), is("/index"));
Assert.assertThat(request.getURI().getPort(), is(8080));
Assert.assertThat(request.getURI().getHost(), is("localhost"));
return new Listener(){
@Override
public void onHeaders(Stream stream, HeadersFrame frame) {
System.out.println("on headers: " + frame.getMetaData());
}
@Override
public Listener onPush(Stream stream, PushPromiseFrame frame) {
return null;
}
@Override
public void onData(Stream stream, DataFrame frame, Callback callback) {
}
@Override
public void onReset(Stream stream, ResetFrame frame) {
}
@Override
public void onTimeout(Stream stream, Throwable x) {
}};
}
@Override
public void onSettings(Session session, SettingsFrame frame) {
System.out.println("on settings: " + frame.toString());
Assert.assertThat(frame.getSettings().get(SettingsFrame.INITIAL_WINDOW_SIZE), is(http2Configuration.getInitialStreamSendWindow()));
}
@Override
public void onPing(Session session, PingFrame frame) {
}
@Override
public void onReset(Session session, ResetFrame frame) {
}
@Override
public void onClose(Session session, GoAwayFrame frame) {
}
@Override
public void onFailure(Session session, Throwable failure) {
}
@Override
public void onAccept(Session session) {
}});
int streamId = 5;
HttpFields fields = new HttpFields();
fields.put("Accept", "text/html");
fields.put("User-Agent", "Firefly Client 1.0");
MetaData.Request metaData = new MetaData.Request("GET", HttpScheme.HTTP,
new HostPortHttpField("localhost:8080"), "/index", HttpVersion.HTTP_2, fields);
Map<Integer, Integer> settings = new HashMap<>();
settings.put(SettingsFrame.HEADER_TABLE_SIZE, http2Configuration.getMaxDynamicTableSize());
settings.put(SettingsFrame.INITIAL_WINDOW_SIZE, http2Configuration.getInitialStreamSendWindow());
HeadersGenerator headersGenerator = http2ServerConnection.getGenerator().getControlGenerator(FrameType.HEADERS);
SettingsGenerator settingsGenerator = http2ServerConnection.getGenerator().getControlGenerator(FrameType.SETTINGS);
List<ByteBuffer> list = new LinkedList<>();
list.add(ByteBuffer.wrap(PrefaceFrame.PREFACE_BYTES));
list.add(settingsGenerator.generateSettings(settings, false));
list.addAll(headersGenerator.generateHeaders(streamId, metaData, null, true));
for(ByteBuffer buffer : list) {
decoder.decode(buffer, session);
}
Assert.assertThat(session.outboundData.size(), greaterThan(0));
System.out.println("out data: " + session.outboundData.size());
Assert.assertThat(session.outboundData.size(), greaterThan(1));
http2ServerConnection.close();
}
#location 14
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public void render(RoutingContext ctx, int status, Throwable t) {
HttpStatus.Code code = Optional.ofNullable(HttpStatus.getCode(status)).orElse(HttpStatus.Code.INTERNAL_SERVER_ERROR);
String title = status + " " + code.getMessage();
String content;
switch (code) {
case NOT_FOUND: {
content = "The resource " + ctx.getURI().getPath() + " is not found";
}
break;
case INTERNAL_SERVER_ERROR: {
content = "The server internal error. <br/>" + (t != null ? t.getMessage() : "");
}
break;
default: {
content = title + "<br/>" + (t != null ? t.getMessage() : "");
}
break;
}
ctx.setStatus(status).put(HttpHeader.CONTENT_TYPE, "text/html")
.write("<!DOCTYPE html>")
.write("<html>")
.write("<head>")
.write("<title>")
.write(title)
.write("</title>")
.write("</head>")
.write("<body>")
.write("<h1> " + title + " </h1>")
.write("<p>" + content + "</p>")
.write("<hr/>")
.write("<footer><em>powered by Firefly " + Version.value + "</em></footer>")
.write("</body>")
.end("</html>");
} | #vulnerable code
public void render(RoutingContext ctx, int status, Throwable t) {
HttpStatus.Code code = HttpStatus.getCode(status);
String title = status + " " + (code != null ? code.getMessage() : "error");
String content;
switch (code) {
case NOT_FOUND: {
content = "The resource " + ctx.getURI().getPath() + " is not found";
}
break;
case INTERNAL_SERVER_ERROR: {
content = "The server internal error. <br/>" + (t != null ? t.getMessage() : "");
}
break;
default: {
content = title + "<br/>" + (t != null ? t.getMessage() : "");
}
break;
}
ctx.setStatus(status).put(HttpHeader.CONTENT_TYPE, "text/html")
.write("<!DOCTYPE html>")
.write("<html>")
.write("<head>")
.write("<title>")
.write(title)
.write("</title>")
.write("</head>")
.write("<body>")
.write("<h1> " + title + " </h1>")
.write("<p>" + content + "</p>")
.write("<hr/>")
.write("<footer><em>powered by Firefly " + Version.value + "</em></footer>")
.write("</body>")
.end("</html>");
}
#location 5
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void testMethodType() {
Map<String, MethodGenericTypeBind> getterMap = ReflectUtils.getGenericBeanGetterMethods(reqRef);
MethodGenericTypeBind extInfo = getterMap.get("extInfo");
ParameterizedType parameterizedType = (ParameterizedType) extInfo.getType();
System.out.println(parameterizedType.getTypeName());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.Map<java.lang.String, java.util.Map<java.lang.String, java.util.List<test.utils.lang.TestGenericTypeReference$Foo>>>"));
Assert.assertThat(extInfo.getMethodType(), is(MethodType.GETTER));
Map<String, MethodGenericTypeBind> setterMap = ReflectUtils.getGenericBeanSetterMethods(reqRef);
extInfo = setterMap.get("extInfo");
parameterizedType = (ParameterizedType) extInfo.getType();
System.out.println(parameterizedType.getTypeName());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.Map<java.lang.String, java.util.Map<java.lang.String, java.util.List<test.utils.lang.TestGenericTypeReference$Foo>>>"));
Assert.assertThat(extInfo.getMethodType(), is(MethodType.SETTER));
} | #vulnerable code
@Test
public void testMethodType() {
Map<String, MethodGenericTypeBind> getterMap = ReflectUtils.getGenericBeanGetterMethods(
new GenericTypeReference<Request<Map<String, Foo>, String, Map<String, List<Foo>>>>() {
}, null);
MethodGenericTypeBind extInfo = getterMap.get("extInfo");
ParameterizedType parameterizedType = (ParameterizedType) extInfo.getType();
System.out.println(parameterizedType.getTypeName());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.Map<java.lang.String, java.util.Map<java.lang.String, java.util.List<test.utils.lang.TestGenericTypeReference$Foo>>>"));
Assert.assertThat(extInfo.getMethodType(), is(MethodType.GETTER));
Map<String, MethodGenericTypeBind> setterMap = ReflectUtils.getGenericBeanSetterMethods(
new GenericTypeReference<Request<Map<String, Foo>, String, Map<String, List<Foo>>>>() {
}, null);
extInfo = setterMap.get("extInfo");
parameterizedType = (ParameterizedType) extInfo.getType();
System.out.println(parameterizedType.getTypeName());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.Map<java.lang.String, java.util.Map<java.lang.String, java.util.List<test.utils.lang.TestGenericTypeReference$Foo>>>"));
Assert.assertThat(extInfo.getMethodType(), is(MethodType.SETTER));
}
#location 16
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public static long copy(File src, File dest, long position, long count) throws IOException {
try(FileInputStream in = new FileInputStream(src);
FileOutputStream out = new FileOutputStream(dest);
FileChannel inChannel = in.getChannel();
FileChannel outChannel = out.getChannel();) {
return inChannel.transferTo(position, count, outChannel);
}
} | #vulnerable code
public static long copy(File src, File dest, long position, long count) throws IOException {
FileInputStream in = new FileInputStream(src);
FileOutputStream out = new FileOutputStream(dest);
FileChannel inChannel = in.getChannel();
FileChannel outChannel = out.getChannel();
try {
return inChannel.transferTo(position, count, outChannel);
} finally {
if (inChannel != null)
inChannel.close();
if (outChannel != null)
outChannel.close();
if (in != null)
in.close();
if (out != null)
out.close();
}
}
#location 17
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void testHeaders() throws Throwable {
final HTTP2Decoder decoder = new HTTP2Decoder();
final HTTP2MockSession session = new HTTP2MockSession();
final HTTP2Configuration http2Configuration = new HTTP2Configuration();
final HTTP2SessionAttachment attachment = new HTTP2SessionAttachment(http2Configuration, session,
new ServerSessionListener(){
@Override
public Map<Integer, Integer> onPreface(Session session) {
System.out.println("on preface: " + session.isClosed());
Assert.assertThat(session.isClosed(), is(false));
return null;
}
@Override
public Listener onNewStream(Stream stream, HeadersFrame frame) {
System.out.println("on new stream: " + stream.getId());
System.out.println("on new stread headers: " + frame.getMetaData().toString());
Assert.assertThat(stream.getId(), is(5));
Assert.assertThat(frame.getMetaData().getVersion(), is(HttpVersion.HTTP_2));
Assert.assertThat(frame.getMetaData().getFields().get("User-Agent"), is("Firefly Client 1.0"));
MetaData.Request request = (MetaData.Request) frame.getMetaData();
Assert.assertThat(request.getMethod(), is("GET"));
Assert.assertThat(request.getURI().getPath(), is("/index"));
Assert.assertThat(request.getURI().getPort(), is(8080));
Assert.assertThat(request.getURI().getHost(), is("localhost"));
return new Listener(){
@Override
public void onHeaders(Stream stream, HeadersFrame frame) {
System.out.println("on headers: " + frame.getMetaData());
}
@Override
public Listener onPush(Stream stream, PushPromiseFrame frame) {
return null;
}
@Override
public void onData(Stream stream, DataFrame frame, Callback callback) {
}
@Override
public void onReset(Stream stream, ResetFrame frame) {
}
@Override
public void onTimeout(Stream stream, Throwable x) {
}};
}
@Override
public void onSettings(Session session, SettingsFrame frame) {
System.out.println("on settings: " + frame.toString());
Assert.assertThat(frame.getSettings().get(SettingsFrame.INITIAL_WINDOW_SIZE), is(http2Configuration.getInitialStreamSendWindow()));
}
@Override
public void onPing(Session session, PingFrame frame) {
}
@Override
public void onReset(Session session, ResetFrame frame) {
}
@Override
public void onClose(Session session, GoAwayFrame frame) {
}
@Override
public void onFailure(Session session, Throwable failure) {
}
@Override
public void onAccept(Session session) {
}});
int streamId = 5;
HttpFields fields = new HttpFields();
fields.put("Accept", "text/html");
fields.put("User-Agent", "Firefly Client 1.0");
MetaData.Request metaData = new MetaData.Request("GET", HttpScheme.HTTP,
new HostPortHttpField("localhost:8080"), "/index", HttpVersion.HTTP_2, fields);
Map<Integer, Integer> settings = new HashMap<>();
settings.put(SettingsFrame.HEADER_TABLE_SIZE, http2Configuration.getMaxDynamicTableSize());
settings.put(SettingsFrame.INITIAL_WINDOW_SIZE, http2Configuration.getInitialStreamSendWindow());
HeadersGenerator headersGenerator = attachment.getGenerator().getControlGenerator(FrameType.HEADERS);
SettingsGenerator settingsGenerator = attachment.getGenerator().getControlGenerator(FrameType.SETTINGS);
List<ByteBuffer> list = new LinkedList<>();
list.add(ByteBuffer.wrap(PrefaceFrame.PREFACE_BYTES));
list.add(settingsGenerator.generateSettings(settings, false));
list.addAll(headersGenerator.generateHeaders(streamId, metaData, null, true));
for(ByteBuffer buffer : list) {
decoder.decode(buffer, session);
}
Assert.assertThat(session.outboundData.size(), greaterThan(0));
System.out.println("out data: " + session.outboundData.size());
attachment.close();
} | #vulnerable code
@Test
public void testHeaders() throws Throwable {
final HTTP2Decoder decoder = new HTTP2Decoder();
final HTTP2MockSession session = new HTTP2MockSession();
final HTTP2Configuration http2Configuration = new HTTP2Configuration();
final HTTP2SessionAttachment attachment = new HTTP2SessionAttachment(http2Configuration, session,
new ServerSessionListener(){
@Override
public Map<Integer, Integer> onPreface(Session session) {
System.out.println("on preface: " + session.isClosed());
Assert.assertThat(session.isClosed(), is(false));
return null;
}
@Override
public Listener onNewStream(Stream stream, HeadersFrame frame) {
System.out.println("on new stream: " + stream.getId());
System.out.println("on new stread headers: " + frame.getMetaData().toString());
Assert.assertThat(stream.getId(), is(5));
Assert.assertThat(frame.getMetaData().getVersion(), is(HttpVersion.HTTP_2));
Assert.assertThat(frame.getMetaData().getFields().get("User-Agent"), is("Firefly Client 1.0"));
MetaData.Request request = (MetaData.Request) frame.getMetaData();
Assert.assertThat(request.getMethod(), is("GET"));
Assert.assertThat(request.getURI().getPath(), is("/index"));
Assert.assertThat(request.getURI().getPort(), is(8080));
Assert.assertThat(request.getURI().getHost(), is("localhost"));
return new Listener(){
@Override
public void onHeaders(Stream stream, HeadersFrame frame) {
System.out.println("on headers: " + frame.getMetaData());
}
@Override
public Listener onPush(Stream stream, PushPromiseFrame frame) {
return null;
}
@Override
public void onData(Stream stream, DataFrame frame, Callback callback) {
}
@Override
public void onReset(Stream stream, ResetFrame frame) {
}
@Override
public void onTimeout(Stream stream, Throwable x) {
}};
}
@Override
public void onSettings(Session session, SettingsFrame frame) {
System.out.println("on settings: " + frame.toString());
Assert.assertThat(frame.getSettings().get(SettingsFrame.INITIAL_WINDOW_SIZE), is(http2Configuration.getInitialStreamSendWindow()));
}
@Override
public void onPing(Session session, PingFrame frame) {
}
@Override
public void onReset(Session session, ResetFrame frame) {
}
@Override
public void onClose(Session session, GoAwayFrame frame) {
}
@Override
public void onFailure(Session session, Throwable failure) {
}
@Override
public void onAccept(Session session) {
}});
int streamId = 5;
HttpFields fields = new HttpFields();
fields.put("Accept", "text/html");
fields.put("User-Agent", "Firefly Client 1.0");
MetaData.Request metaData = new MetaData.Request("GET", HttpScheme.HTTP,
new HostPortHttpField("localhost:8080"), "/index", HttpVersion.HTTP_2, fields);
Map<Integer, Integer> settings = new HashMap<>();
settings.put(SettingsFrame.HEADER_TABLE_SIZE, http2Configuration.getMaxDynamicTableSize());
settings.put(SettingsFrame.INITIAL_WINDOW_SIZE, http2Configuration.getInitialStreamSendWindow());
HeadersGenerator headersGenerator = attachment.getGenerator().getControlGenerator(FrameType.HEADERS);
SettingsGenerator settingsGenerator = attachment.getGenerator().getControlGenerator(FrameType.SETTINGS);
List<ByteBuffer> list = new LinkedList<>();
list.add(ByteBuffer.wrap(PrefaceFrame.PREFACE_BYTES));
list.add(settingsGenerator.generateSettings(settings, false));
list.addAll(headersGenerator.generateHeaders(streamId, metaData, null, true));
for(ByteBuffer buffer : list) {
decoder.decode(buffer, session);
}
Assert.assertThat(session.outboundData.size(), greaterThan(0));
System.out.println("out data: " + session.outboundData.size());
}
#location 93
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
HTTP1ServerConnection(HTTP2Configuration config, Session tcpSession, SecureSession secureSession,
HTTP1ServerRequestHandler requestHandler, ServerSessionListener serverSessionListener) {
super(config, secureSession, tcpSession, requestHandler, null);
requestHandler.connection = this;
this.serverSessionListener = serverSessionListener;
this.serverRequestHandler = requestHandler;
} | #vulnerable code
boolean directUpgradeHTTP2(MetaData.Request request) {
if (HttpMethod.PRI.is(request.getMethod())) {
HTTP2ServerConnection http2ServerConnection = new HTTP2ServerConnection(config, tcpSession, secureSession,
serverSessionListener);
tcpSession.attachObject(http2ServerConnection);
http2ServerConnection.getParser().directUpgrade();
upgradeHTTP2Successfully = true;
return true;
} else {
return false;
}
}
#location 3
#vulnerability type THREAD_SAFETY_VIOLATION | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
private void initializeHTTP2ClientConnection(final Session session, final HTTP2ClientContext context,
final SSLSession sslSession) {
HTTP2ClientConnection.initialize(config, session, context, sslSession);
} | #vulnerable code
private void initializeHTTP2ClientConnection(final Session session, final HTTP2ClientContext context,
final SSLSession sslSession) {
final HTTP2ClientConnection connection = new HTTP2ClientConnection(config, session, sslSession,
context.listener);
Map<Integer, Integer> settings = context.listener.onPreface(connection.getHttp2Session());
if (settings == null) {
settings = Collections.emptyMap();
}
PrefaceFrame prefaceFrame = new PrefaceFrame();
SettingsFrame settingsFrame = new SettingsFrame(settings, false);
SessionSPI sessionSPI = connection.getSessionSPI();
int windowDelta = config.getInitialSessionRecvWindow() - FlowControlStrategy.DEFAULT_WINDOW_SIZE;
Callback callback = new Callback() {
@Override
public void succeeded() {
context.promise.succeeded(connection);
}
@Override
public void failed(Throwable x) {
try {
connection.close();
} catch (IOException e) {
log.error("http2 connection initialization error", e);
}
context.promise.failed(x);
}
};
if (windowDelta > 0) {
sessionSPI.updateRecvWindow(windowDelta);
sessionSPI.frames(null, callback, prefaceFrame, settingsFrame, new WindowUpdateFrame(0, windowDelta));
} else {
sessionSPI.frames(null, callback, prefaceFrame, settingsFrame);
}
}
#location 34
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void testFieldType() throws Exception {
Map<String, FieldGenericTypeBind> map = ReflectUtils.getGenericBeanFields(reqRef);
FieldGenericTypeBind extInfo = map.get("attrs");
System.out.println(extInfo.getField().getName());
System.out.println(extInfo.getField().getGenericType().getTypeName() + "|" + extInfo.getField().getGenericType().getClass());
System.out.println(extInfo.getType().getTypeName() + "|" + extInfo.getType().getClass());
Assert.assertThat(extInfo.getType().getTypeName(), is("java.util.Map<java.lang.String, java.util.Map<java.lang.String, java.util.List<test.utils.lang.TestGenericTypeReference$Foo>>>"));
ParameterizedType parameterizedType = (ParameterizedType) extInfo.getType();
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
parameterizedType = (ParameterizedType) extInfo.getField().getGenericType();
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
} | #vulnerable code
@Test
public void testFieldType() throws Exception {
Map<String, FieldGenericTypeBind> map = ReflectUtils.getGenericBeanFields(
new GenericTypeReference<Request<Map<String, Foo>, String, Map<String, List<Foo>>>>() {
}, null);
FieldGenericTypeBind extInfo = map.get("attrs");
System.out.println(extInfo.getField().getName());
System.out.println(extInfo.getField().getGenericType().getTypeName() + "|" + extInfo.getField().getGenericType().getClass());
System.out.println(extInfo.getType().getTypeName() + "|" + extInfo.getType().getClass());
Assert.assertThat(extInfo.getType().getTypeName(), is("java.util.Map<java.lang.String, java.util.Map<java.lang.String, java.util.List<test.utils.lang.TestGenericTypeReference$Foo>>>"));
ParameterizedType parameterizedType = (ParameterizedType) extInfo.getType();
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
parameterizedType = (ParameterizedType) extInfo.getField().getGenericType();
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
}
#location 8
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@SuppressWarnings("unchecked")
private Object getMapArg(ManagedMap<XmlManagedNode, XmlManagedNode> values, Class<?> setterParamType) {
Map<Object, Object> m = null;
if (VerifyUtils.isNotEmpty(values.getTypeName())) {
try {
m = (Map<Object, Object>) XmlApplicationContext.class.getClassLoader()
.loadClass(values.getTypeName())
.newInstance();
} catch (Throwable t) {
log.error("map inject error", t);
}
} else {
m = (setterParamType == null ? new HashMap<>() : ConvertUtils.getMapObj(setterParamType));
if (m != null && log.isDebugEnabled()) {
log.debug("map ret [{}]", m.getClass().getName());
}
}
if (m != null) {
for (XmlManagedNode o : values.keySet()) {
Object k = getInjectArg(o, null);
Object v = getInjectArg(values.get(o), null);
m.put(k, v);
}
}
return m;
} | #vulnerable code
@SuppressWarnings("unchecked")
private Object getMapArg(ManagedMap<XmlManagedNode, XmlManagedNode> values, Class<?> setterParamType) {
Map<Object, Object> m = null;
if (VerifyUtils.isNotEmpty(values.getTypeName())) {
try {
m = (Map<Object, Object>) XmlApplicationContext.class.getClassLoader()
.loadClass(values.getTypeName())
.newInstance();
} catch (Throwable t) {
log.error("map inject error", t);
}
} else {
m = (setterParamType == null ? new HashMap<>() : ConvertUtils.getMapObj(setterParamType));
log.debug("map ret [{}]", m.getClass().getName());
}
for (XmlManagedNode o : values.keySet()) {
Object k = getInjectArg(o, null);
Object v = getInjectArg(values.get(o), null);
m.put(k, v);
}
return m;
}
#location 14
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void testResponseParse2() throws Exception {
ByteBuffer buffer = BufferUtils
.toBuffer("HTTP/1.1 204 No-Content\015\012" + "Header: value\015\012" + "\015\012"
+ "HTTP/1.1 200 Correct\015\012" + "Content-Length: 10\015\012"
+ "Content-Type: text/plain\015\012" + "\015\012" + "0123456789\015\012");
HttpParser.ResponseHandler handler = new Handler();
HttpParser parser = new HttpParser(handler);
parser.parseNext(buffer);
assertEquals("HTTP/1.1", _methodOrVersion);
assertEquals("204", _uriOrStatus);
assertEquals("No-Content", _versionOrReason);
assertTrue(_headerCompleted);
assertTrue(_messageCompleted);
parser.reset();
init();
parser.parseNext(buffer);
parser.atEOF();
assertEquals("HTTP/1.1", _methodOrVersion);
assertEquals("200", _uriOrStatus);
assertEquals("Correct", _versionOrReason);
assertEquals(_content.length(), 10);
assertTrue(_headerCompleted);
assertTrue(_messageCompleted);
} | #vulnerable code
@Test
public void testResponseParse2() throws Exception {
ByteBuffer buffer = BufferUtils
.toBuffer("HTTP/1.1 204 No-Content\015\012" + "Header: value\015\012" + "\015\012"
+ "HTTP/1.1 200 Correct\015\012" + "Content-Length: 10\015\012" + "Content-Type: text/plain\015\012"
+ "\015\012" + "0123456789\015\012");
HttpParser.ResponseHandler handler = new Handler();
HttpParser parser = new HttpParser(handler);
parser.parseNext(buffer);
assertEquals("HTTP/1.1", _methodOrVersion);
assertEquals("204", _uriOrStatus);
assertEquals("No-Content", _versionOrReason);
assertTrue(_headerCompleted);
assertTrue(_messageCompleted);
parser.reset();
init();
parser.parseNext(buffer);
parser.atEOF();
assertEquals("HTTP/1.1", _methodOrVersion);
assertEquals("200", _uriOrStatus);
assertEquals("Correct", _versionOrReason);
assertEquals(_content.length(), 10);
assertTrue(_headerCompleted);
assertTrue(_messageCompleted);
}
#location 26
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void testWindowUpdate() throws Throwable {
MockSession clientSession = new MockSession();
MockSession serverSession = new MockSession();
SpdySessionAttachment clientAttachment = new SpdySessionAttachment(new Connection(clientSession, true));
SpdySessionAttachment serverAttachment = new SpdySessionAttachment(new Connection(serverSession, false));
clientSession.attachObject(clientAttachment);
serverSession.attachObject(serverAttachment);
SpdyDecoder clientDecoder = new SpdyDecoder(new DefaultSpdyDecodingEventListener(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
}}, new SettingsManager(null, "localhost", 7777)));
SpdyDecoder serverDecoder = new SpdyDecoder(new DefaultSpdyDecodingEventListener(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
System.out.println("Server receives syn stream -> " + synStreamFrame);
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
System.out.println("Server receives data -> " + dataFrame);
if(dataFrame.getFlags() == DataFrame.FLAG_FIN) {
Fields headers = stream.createFields();
headers.put("response", "ok");
stream.reply(Version.V3, (byte)0, headers);
stream.sendLastData("the server has received messages".getBytes());
}
}}, null));
// Client creates a stream
Stream clientStream = clientAttachment.getConnection().createStream(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
System.out.println("Client receives reply frame -> " + synReplyFrame);
Assert.assertThat(synReplyFrame.getHeaders().get("response").getValue(), is("ok"));
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
System.out.println("Client receives data -> " + dataFrame);
if(dataFrame.getFlags() == DataFrame.FLAG_FIN) {
Assert.assertThat(new String(dataFrame.getData()), is("the server has received messages"));
}
}});
Assert.assertThat(clientStream.getId(), is(1));
Assert.assertThat(clientStream.getPriority(), is((byte)0));
Assert.assertThat(clientAttachment.getConnection().getStream(1) == clientStream, is(true));
// Client sends a SYN stream to server
Fields headers = clientStream.createFields();
headers.put("test1", "testValue1");
headers.put("test2", "testValue2");
headers.add("testM1", "testm1");
headers.add("testM2", "testm2");
clientStream.syn(Version.V3, (byte)0, 0, (byte)0, headers);
Assert.assertThat(clientStream.getWindowSize(), is(64 * 1024));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(64 * 1024));
// Server receives a SYN stream
serverDecoder.decode(clientSession.outboundData.poll(), serverSession);
// Client sends data frames
int currentWindowSize = 64 * 1024;
byte[] data = "hello world".getBytes();
clientStream.sendData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
data = "data2".getBytes();
clientStream.sendData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
data = "data3".getBytes();
clientStream.sendLastData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientStream.isOutboundClosed(), is(true));
Assert.assertThat(clientStream.isInboundClosed(), is(false));
// Server receives data
ByteBuffer buf = null;
while( (buf = clientSession.outboundData.poll()) != null ) {
serverDecoder.decode(buf, serverSession);
}
// Server sends window update and replies
while( (buf = serverSession.outboundData.poll()) != null ) {
clientDecoder.decode(buf, clientSession);
}
Assert.assertThat(clientStream.isOutboundClosed(), is(true));
Assert.assertThat(clientStream.isInboundClosed(), is(true));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(64 * 1024));
} | #vulnerable code
@Test
public void testWindowUpdate() throws Throwable {
MockSession clientSession = new MockSession();
MockSession serverSession = new MockSession();
SpdySessionAttachment clientAttachment = new SpdySessionAttachment(new Connection(clientSession, true));
SpdySessionAttachment serverAttachment = new SpdySessionAttachment(new Connection(serverSession, false));
clientSession.attachObject(clientAttachment);
serverSession.attachObject(serverAttachment);
SpdyDecoder clientDecoder = new SpdyDecoder(new DefaultSpdyDecodingEventListener(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
}}, new SettingsManager(null, "localhost", 7777)));
SpdyDecoder serverDecoder = new SpdyDecoder(new DefaultSpdyDecodingEventListener(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
System.out.println("Server receives syn stream -> " + synStreamFrame);
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
}}, null));
// Client creates a stream
Stream clientStream = clientAttachment.getConnection().createStream(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
}});
Assert.assertThat(clientStream.getId(), is(1));
Assert.assertThat(clientStream.getPriority(), is((byte)0));
Assert.assertThat(clientAttachment.getConnection().getStream(1) == clientStream, is(true));
// Client sends a SYN stream to server
Fields headers = clientStream.createFields();
headers.put("test1", "testValue1");
headers.put("test2", "testValue2");
headers.add("testM1", "testm1");
headers.add("testM2", "testm2");
clientStream.syn((short)3, (byte)0, 0, (byte)0, headers);
Assert.assertThat(clientStream.getWindowSize(), is(64 * 1024));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(64 * 1024));
// Server receives a SYN stream
serverDecoder.decode(clientSession.outboundData.poll(), serverSession);
int currentWindowSize = 64 * 1024;
byte[] data = "hello world".getBytes();
clientStream.sendData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
data = "data2".getBytes();
clientStream.sendData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
}
#location 17
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void testNestedClass() throws Exception {
Map<String, FieldGenericTypeBind> map = ReflectUtils.getGenericBeanFields(barRef);
FieldGenericTypeBind barMaps = map.get("maps");
ParameterizedType parameterizedType = (ParameterizedType) barMaps.getType();
System.out.println(parameterizedType.getTypeName());
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.Map<java.lang.String, java.util.Map<java.lang.String, java.util.List<test.utils.lang.TestGenericTypeReference$Foo>>>"));
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
FieldGenericTypeBind bar = map.get("bar");
parameterizedType = (ParameterizedType) bar.getType();
System.out.println(parameterizedType.getTypeName());
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.List<java.lang.String>"));
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
map = ReflectUtils.getGenericBeanFields(carRef);
FieldGenericTypeBind car = map.get("car");
parameterizedType = (ParameterizedType) car.getType();
System.out.println(parameterizedType.getTypeName());
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.List<java.lang.Integer>"));
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
map = ReflectUtils.getGenericBeanFields(parRef);
FieldGenericTypeBind par = map.get("par");
Class<?> clazz = (Class<?>) par.getType();
System.out.println(clazz.getTypeName());
Assert.assertThat(clazz.getTypeName(), is("java.lang.String"));
Map<String, MethodGenericTypeBind> getterMap = ReflectUtils.getGenericBeanGetterMethods(sarRef);
MethodGenericTypeBind list = getterMap.get("list");
System.out.println(list.getType().getTypeName());
Assert.assertThat(list.getType().getTypeName(), is("java.util.List<java.util.Map<java.lang.String, test.utils.lang.TestGenericTypeReference$Foo>>"));
MethodGenericTypeBind sar = getterMap.get("sar");
Assert.assertThat(sar.getType().getTypeName(), is("java.lang.Integer"));
} | #vulnerable code
@Test
public void testNestedClass() throws Exception {
Map<String, FieldGenericTypeBind> map = ReflectUtils.getGenericBeanFields(
new GenericTypeReference<Request<Map<String, Foo>, String, Map<String, List<Foo>>>.Bar<List<String>>>() {
}, null);
FieldGenericTypeBind barMaps = map.get("maps");
ParameterizedType parameterizedType = (ParameterizedType) barMaps.getType();
System.out.println(parameterizedType.getTypeName());
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.Map<java.lang.String, java.util.Map<java.lang.String, java.util.List<test.utils.lang.TestGenericTypeReference$Foo>>>"));
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
FieldGenericTypeBind bar = map.get("bar");
parameterizedType = (ParameterizedType) bar.getType();
System.out.println(parameterizedType.getTypeName());
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.List<java.lang.String>"));
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
map = ReflectUtils.getGenericBeanFields(
new GenericTypeReference<Request<Map<String, Foo>, String, Map<String, List<Foo>>>.Car<List<String>>>() {
}, null);
FieldGenericTypeBind car = map.get("car");
parameterizedType = (ParameterizedType) car.getType();
System.out.println(parameterizedType.getTypeName());
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.List<java.lang.String>"));
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
map = ReflectUtils.getGenericBeanFields(
new GenericTypeReference<Request<Map<String, Foo>, String, Map<String, List<Foo>>>.Par>() {
}, null);
FieldGenericTypeBind par = map.get("par");
Class<?> clazz = (Class<?>) par.getType();
System.out.println(clazz.getTypeName());
Assert.assertThat(clazz.getTypeName(), is("java.lang.String"));
}
#location 15
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public Config load(String file) {
Dom dom = new DefaultDom();
Document doc = dom.getDocument(file == null ? DEFAULT_CONFIG_FILE : file);
Element root = dom.getRoot(doc);
load(root, dom);
return config;
} | #vulnerable code
public Config load(String file) {
Dom dom = new DefaultDom();
// 获得Xml文档对象
Document doc = dom.getDocument(file == null ? DEFAULT_CONFIG_FILE : file);
// 得到根节点
Element root = dom.getRoot(doc);
load(root, dom);
return config;
}
#location 6
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
private void initializeHTTP2ClientConnection(final Session session, final HTTP2ClientContext context,
final SSLSession sslSession) {
HTTP2ClientConnection.initialize(config, session, context, sslSession);
} | #vulnerable code
private void initializeHTTP2ClientConnection(final Session session, final HTTP2ClientContext context,
final SSLSession sslSession) {
final HTTP2ClientConnection connection = new HTTP2ClientConnection(config, session, sslSession,
context.listener);
Map<Integer, Integer> settings = context.listener.onPreface(connection.getHttp2Session());
if (settings == null) {
settings = Collections.emptyMap();
}
PrefaceFrame prefaceFrame = new PrefaceFrame();
SettingsFrame settingsFrame = new SettingsFrame(settings, false);
SessionSPI sessionSPI = connection.getSessionSPI();
int windowDelta = config.getInitialSessionRecvWindow() - FlowControlStrategy.DEFAULT_WINDOW_SIZE;
Callback callback = new Callback() {
@Override
public void succeeded() {
context.promise.succeeded(connection);
}
@Override
public void failed(Throwable x) {
try {
connection.close();
} catch (IOException e) {
log.error("http2 connection initialization error", e);
}
context.promise.failed(x);
}
};
if (windowDelta > 0) {
sessionSPI.updateRecvWindow(windowDelta);
sessionSPI.frames(null, callback, prefaceFrame, settingsFrame, new WindowUpdateFrame(0, windowDelta));
} else {
sessionSPI.frames(null, callback, prefaceFrame, settingsFrame);
}
}
#location 36
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void test() {
MultiPartContentProvider multiPartProvider = new MultiPartContentProvider();
System.out.println(multiPartProvider.getContentType());
multiPartProvider.addFieldPart("test1", new StringContentProvider("hello multi part1"), null);
multiPartProvider.addFieldPart("test2", new StringContentProvider("hello multi part2"), null);
multiPartProvider.close();
multiPartProvider.setListener(() -> System.out.println("on content"));
List<ByteBuffer> list = new ArrayList<>();
for (ByteBuffer buf : multiPartProvider) {
list.add(buf);
}
String value = $.buffer.toString(list);
System.out.println(value);
System.out.println(multiPartProvider.getLength());
Assert.assertThat(multiPartProvider.getLength(), greaterThan(0L));
} | #vulnerable code
@Test
public void test() {
MultiPartContentProvider multiPartProvider = new MultiPartContentProvider();
System.out.println(multiPartProvider.getContentType());
multiPartProvider.addFieldPart("test1", new StringContentProvider("hello multi part1"), null);
multiPartProvider.addFieldPart("test2", new StringContentProvider("hello multi part2"), null);
multiPartProvider.close();
multiPartProvider.setListener(() -> System.out.println("on content"));
List<ByteBuffer> list = new ArrayList<>();
for (ByteBuffer buf : multiPartProvider) {
list.add(buf);
}
String value = BufferUtils.toString(list);
System.out.println(value);
System.out.println(multiPartProvider.getLength());
Assert.assertThat(multiPartProvider.getLength(), greaterThan(0L));
}
#location 14
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void testWindowUpdate() throws Throwable {
MockSession clientSession = new MockSession();
MockSession serverSession = new MockSession();
try(SpdySessionAttachment clientAttachment = new SpdySessionAttachment(new Connection(clientSession, true));
SpdySessionAttachment serverAttachment = new SpdySessionAttachment(new Connection(serverSession, false));) {
clientSession.attachObject(clientAttachment);
serverSession.attachObject(serverAttachment);
// Client creates a stream
Stream clientStream = clientAttachment.getConnection().createStream(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
System.out.println("Client receives reply frame -> " + synReplyFrame);
Assert.assertThat(synReplyFrame.getHeaders().get("response").getValue(), is("ok"));
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
System.out.println("Client receives data -> " + dataFrame);
if(dataFrame.getFlags() == DataFrame.FLAG_FIN) {
Assert.assertThat(new String(dataFrame.getData()), is("the server has received messages"));
}
}});
Assert.assertThat(clientStream.getId(), is(1));
Assert.assertThat(clientStream.getPriority(), is((byte)0));
Assert.assertThat(clientAttachment.getConnection().getStream(1) == clientStream, is(true));
// Client sends a SYN stream to server
Fields headers = clientStream.createFields();
headers.put("test1", "testValue1");
headers.put("test2", "testValue2");
headers.add("testM1", "testm1");
headers.add("testM2", "testm2");
clientStream.syn(Version.V3, (byte)0, 0, (byte)0, headers);
Assert.assertThat(clientStream.getWindowSize(), is(64 * 1024));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(64 * 1024));
// Server receives a SYN stream
serverDecoder.decode(clientSession.outboundData.poll(), serverSession);
// Client sends data frames
int currentWindowSize = 64 * 1024;
byte[] data = "hello world".getBytes();
clientStream.sendData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
data = "data2".getBytes();
clientStream.sendData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
data = "data3".getBytes();
clientStream.sendLastData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientStream.isOutboundClosed(), is(true));
Assert.assertThat(clientStream.isInboundClosed(), is(false));
// Server receives data
ByteBuffer buf = null;
while( (buf = clientSession.outboundData.poll()) != null ) {
serverDecoder.decode(buf, serverSession);
}
// Server sends window update and replies
while( (buf = serverSession.outboundData.poll()) != null ) {
clientDecoder.decode(buf, clientSession);
}
Assert.assertThat(clientStream.isOutboundClosed(), is(true));
Assert.assertThat(clientStream.isInboundClosed(), is(true));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(64 * 1024));
}
} | #vulnerable code
@Test
public void testWindowUpdate() throws Throwable {
MockSession clientSession = new MockSession();
MockSession serverSession = new MockSession();
SpdySessionAttachment clientAttachment = new SpdySessionAttachment(new Connection(clientSession, true));
SpdySessionAttachment serverAttachment = new SpdySessionAttachment(new Connection(serverSession, false));
clientSession.attachObject(clientAttachment);
serverSession.attachObject(serverAttachment);
SpdyDecoder clientDecoder = new SpdyDecoder(new DefaultSpdyDecodingEventListener(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
}}, new SettingsManager(null, "localhost", 7777)));
SpdyDecoder serverDecoder = new SpdyDecoder(new DefaultSpdyDecodingEventListener(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
System.out.println("Server receives syn stream -> " + synStreamFrame);
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
System.out.println("Server receives data -> " + dataFrame);
if(dataFrame.getFlags() == DataFrame.FLAG_FIN) {
Fields headers = stream.createFields();
headers.put("response", "ok");
stream.reply(Version.V3, (byte)0, headers);
stream.sendLastData("the server has received messages".getBytes());
}
}}, null));
// Client creates a stream
Stream clientStream = clientAttachment.getConnection().createStream(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
System.out.println("Client receives reply frame -> " + synReplyFrame);
Assert.assertThat(synReplyFrame.getHeaders().get("response").getValue(), is("ok"));
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
System.out.println("Client receives data -> " + dataFrame);
if(dataFrame.getFlags() == DataFrame.FLAG_FIN) {
Assert.assertThat(new String(dataFrame.getData()), is("the server has received messages"));
}
}});
Assert.assertThat(clientStream.getId(), is(1));
Assert.assertThat(clientStream.getPriority(), is((byte)0));
Assert.assertThat(clientAttachment.getConnection().getStream(1) == clientStream, is(true));
// Client sends a SYN stream to server
Fields headers = clientStream.createFields();
headers.put("test1", "testValue1");
headers.put("test2", "testValue2");
headers.add("testM1", "testm1");
headers.add("testM2", "testm2");
clientStream.syn(Version.V3, (byte)0, 0, (byte)0, headers);
Assert.assertThat(clientStream.getWindowSize(), is(64 * 1024));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(64 * 1024));
// Server receives a SYN stream
serverDecoder.decode(clientSession.outboundData.poll(), serverSession);
// Client sends data frames
int currentWindowSize = 64 * 1024;
byte[] data = "hello world".getBytes();
clientStream.sendData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
data = "data2".getBytes();
clientStream.sendData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
data = "data3".getBytes();
clientStream.sendLastData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientStream.isOutboundClosed(), is(true));
Assert.assertThat(clientStream.isInboundClosed(), is(false));
// Server receives data
ByteBuffer buf = null;
while( (buf = clientSession.outboundData.poll()) != null ) {
serverDecoder.decode(buf, serverSession);
}
// Server sends window update and replies
while( (buf = serverSession.outboundData.poll()) != null ) {
clientDecoder.decode(buf, clientSession);
}
Assert.assertThat(clientStream.isOutboundClosed(), is(true));
Assert.assertThat(clientStream.isInboundClosed(), is(true));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(64 * 1024));
}
#location 17
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void testMethodType() {
Map<String, MethodGenericTypeBind> getterMap = ReflectUtils.getGenericBeanGetterMethods(reqRef);
MethodGenericTypeBind extInfo = getterMap.get("extInfo");
ParameterizedType parameterizedType = (ParameterizedType) extInfo.getType();
System.out.println(parameterizedType.getTypeName());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.Map<java.lang.String, java.util.Map<java.lang.String, java.util.List<test.utils.lang.TestGenericTypeReference$Foo>>>"));
Assert.assertThat(extInfo.getMethodType(), is(MethodType.GETTER));
Map<String, MethodGenericTypeBind> setterMap = ReflectUtils.getGenericBeanSetterMethods(reqRef);
extInfo = setterMap.get("extInfo");
parameterizedType = (ParameterizedType) extInfo.getType();
System.out.println(parameterizedType.getTypeName());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.Map<java.lang.String, java.util.Map<java.lang.String, java.util.List<test.utils.lang.TestGenericTypeReference$Foo>>>"));
Assert.assertThat(extInfo.getMethodType(), is(MethodType.SETTER));
} | #vulnerable code
@Test
public void testMethodType() {
Map<String, MethodGenericTypeBind> getterMap = ReflectUtils.getGenericBeanGetterMethods(
new GenericTypeReference<Request<Map<String, Foo>, String, Map<String, List<Foo>>>>() {
}, null);
MethodGenericTypeBind extInfo = getterMap.get("extInfo");
ParameterizedType parameterizedType = (ParameterizedType) extInfo.getType();
System.out.println(parameterizedType.getTypeName());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.Map<java.lang.String, java.util.Map<java.lang.String, java.util.List<test.utils.lang.TestGenericTypeReference$Foo>>>"));
Assert.assertThat(extInfo.getMethodType(), is(MethodType.GETTER));
Map<String, MethodGenericTypeBind> setterMap = ReflectUtils.getGenericBeanSetterMethods(
new GenericTypeReference<Request<Map<String, Foo>, String, Map<String, List<Foo>>>>() {
}, null);
extInfo = setterMap.get("extInfo");
parameterizedType = (ParameterizedType) extInfo.getType();
System.out.println(parameterizedType.getTypeName());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.Map<java.lang.String, java.util.Map<java.lang.String, java.util.List<test.utils.lang.TestGenericTypeReference$Foo>>>"));
Assert.assertThat(extInfo.getMethodType(), is(MethodType.SETTER));
}
#location 7
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void testNestedClass() throws Exception {
Map<String, FieldGenericTypeBind> map = ReflectUtils.getGenericBeanFields(barRef);
FieldGenericTypeBind barMaps = map.get("maps");
ParameterizedType parameterizedType = (ParameterizedType) barMaps.getType();
System.out.println(parameterizedType.getTypeName());
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.Map<java.lang.String, java.util.Map<java.lang.String, java.util.List<test.utils.lang.TestGenericTypeReference$Foo>>>"));
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
FieldGenericTypeBind bar = map.get("bar");
parameterizedType = (ParameterizedType) bar.getType();
System.out.println(parameterizedType.getTypeName());
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.List<java.lang.String>"));
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
map = ReflectUtils.getGenericBeanFields(carRef);
FieldGenericTypeBind car = map.get("car");
parameterizedType = (ParameterizedType) car.getType();
System.out.println(parameterizedType.getTypeName());
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.List<java.lang.Integer>"));
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
map = ReflectUtils.getGenericBeanFields(parRef);
FieldGenericTypeBind par = map.get("par");
Class<?> clazz = (Class<?>) par.getType();
System.out.println(clazz.getTypeName());
Assert.assertThat(clazz.getTypeName(), is("java.lang.String"));
Map<String, MethodGenericTypeBind> getterMap = ReflectUtils.getGenericBeanGetterMethods(sarRef);
MethodGenericTypeBind list = getterMap.get("list");
System.out.println(list.getType().getTypeName());
Assert.assertThat(list.getType().getTypeName(), is("java.util.List<java.util.Map<java.lang.String, test.utils.lang.TestGenericTypeReference$Foo>>"));
MethodGenericTypeBind sar = getterMap.get("sar");
Assert.assertThat(sar.getType().getTypeName(), is("java.lang.Integer"));
} | #vulnerable code
@Test
public void testNestedClass() throws Exception {
Map<String, FieldGenericTypeBind> map = ReflectUtils.getGenericBeanFields(
new GenericTypeReference<Request<Map<String, Foo>, String, Map<String, List<Foo>>>.Bar<List<String>>>() {
}, null);
FieldGenericTypeBind barMaps = map.get("maps");
ParameterizedType parameterizedType = (ParameterizedType) barMaps.getType();
System.out.println(parameterizedType.getTypeName());
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.Map<java.lang.String, java.util.Map<java.lang.String, java.util.List<test.utils.lang.TestGenericTypeReference$Foo>>>"));
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
FieldGenericTypeBind bar = map.get("bar");
parameterizedType = (ParameterizedType) bar.getType();
System.out.println(parameterizedType.getTypeName());
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.List<java.lang.String>"));
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
map = ReflectUtils.getGenericBeanFields(
new GenericTypeReference<Request<Map<String, Foo>, String, Map<String, List<Foo>>>.Car<List<String>>>() {
}, null);
FieldGenericTypeBind car = map.get("car");
parameterizedType = (ParameterizedType) car.getType();
System.out.println(parameterizedType.getTypeName());
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.List<java.lang.String>"));
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
map = ReflectUtils.getGenericBeanFields(
new GenericTypeReference<Request<Map<String, Foo>, String, Map<String, List<Foo>>>.Par>() {
}, null);
FieldGenericTypeBind par = map.get("par");
Class<?> clazz = (Class<?>) par.getType();
System.out.println(clazz.getTypeName());
Assert.assertThat(clazz.getTypeName(), is("java.lang.String"));
}
#location 8
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void testWindowUpdate() throws Throwable {
MockSession clientSession = new MockSession();
MockSession serverSession = new MockSession();
SpdySessionAttachment clientAttachment = new SpdySessionAttachment(new Connection(clientSession, true));
SpdySessionAttachment serverAttachment = new SpdySessionAttachment(new Connection(serverSession, false));
clientSession.attachObject(clientAttachment);
serverSession.attachObject(serverAttachment);
SpdyDecoder clientDecoder = new SpdyDecoder(new DefaultSpdyDecodingEventListener(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
}}, new SettingsManager(null, "localhost", 7777)));
SpdyDecoder serverDecoder = new SpdyDecoder(new DefaultSpdyDecodingEventListener(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
System.out.println("Server receives syn stream -> " + synStreamFrame);
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
System.out.println("Server receives data -> " + dataFrame);
if(dataFrame.getFlags() == DataFrame.FLAG_FIN) {
Fields headers = stream.createFields();
headers.put("response", "ok");
stream.reply(Version.V3, (byte)0, headers);
stream.sendLastData("the server has received messages".getBytes());
}
}}, null));
// Client creates a stream
Stream clientStream = clientAttachment.getConnection().createStream(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
System.out.println("Client receives reply frame -> " + synReplyFrame);
Assert.assertThat(synReplyFrame.getHeaders().get("response").getValue(), is("ok"));
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
System.out.println("Client receives data -> " + dataFrame);
if(dataFrame.getFlags() == DataFrame.FLAG_FIN) {
Assert.assertThat(new String(dataFrame.getData()), is("the server has received messages"));
}
}});
Assert.assertThat(clientStream.getId(), is(1));
Assert.assertThat(clientStream.getPriority(), is((byte)0));
Assert.assertThat(clientAttachment.getConnection().getStream(1) == clientStream, is(true));
// Client sends a SYN stream to server
Fields headers = clientStream.createFields();
headers.put("test1", "testValue1");
headers.put("test2", "testValue2");
headers.add("testM1", "testm1");
headers.add("testM2", "testm2");
clientStream.syn(Version.V3, (byte)0, 0, (byte)0, headers);
Assert.assertThat(clientStream.getWindowSize(), is(64 * 1024));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(64 * 1024));
// Server receives a SYN stream
serverDecoder.decode(clientSession.outboundData.poll(), serverSession);
// Client sends data frames
int currentWindowSize = 64 * 1024;
byte[] data = "hello world".getBytes();
clientStream.sendData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
data = "data2".getBytes();
clientStream.sendData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
data = "data3".getBytes();
clientStream.sendLastData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientStream.isOutboundClosed(), is(true));
Assert.assertThat(clientStream.isInboundClosed(), is(false));
// Server receives data
ByteBuffer buf = null;
while( (buf = clientSession.outboundData.poll()) != null ) {
serverDecoder.decode(buf, serverSession);
}
// Server sends window update and replies
while( (buf = serverSession.outboundData.poll()) != null ) {
clientDecoder.decode(buf, clientSession);
}
Assert.assertThat(clientStream.isOutboundClosed(), is(true));
Assert.assertThat(clientStream.isInboundClosed(), is(true));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(64 * 1024));
} | #vulnerable code
@Test
public void testWindowUpdate() throws Throwable {
MockSession clientSession = new MockSession();
MockSession serverSession = new MockSession();
SpdySessionAttachment clientAttachment = new SpdySessionAttachment(new Connection(clientSession, true));
SpdySessionAttachment serverAttachment = new SpdySessionAttachment(new Connection(serverSession, false));
clientSession.attachObject(clientAttachment);
serverSession.attachObject(serverAttachment);
SpdyDecoder clientDecoder = new SpdyDecoder(new DefaultSpdyDecodingEventListener(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
}}, new SettingsManager(null, "localhost", 7777)));
SpdyDecoder serverDecoder = new SpdyDecoder(new DefaultSpdyDecodingEventListener(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
System.out.println("Server receives syn stream -> " + synStreamFrame);
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
}}, null));
// Client creates a stream
Stream clientStream = clientAttachment.getConnection().createStream(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
}});
Assert.assertThat(clientStream.getId(), is(1));
Assert.assertThat(clientStream.getPriority(), is((byte)0));
Assert.assertThat(clientAttachment.getConnection().getStream(1) == clientStream, is(true));
// Client sends a SYN stream to server
Fields headers = clientStream.createFields();
headers.put("test1", "testValue1");
headers.put("test2", "testValue2");
headers.add("testM1", "testm1");
headers.add("testM2", "testm2");
clientStream.syn((short)3, (byte)0, 0, (byte)0, headers);
Assert.assertThat(clientStream.getWindowSize(), is(64 * 1024));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(64 * 1024));
// Server receives a SYN stream
serverDecoder.decode(clientSession.outboundData.poll(), serverSession);
int currentWindowSize = 64 * 1024;
byte[] data = "hello world".getBytes();
clientStream.sendData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
data = "data2".getBytes();
clientStream.sendData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
}
#location 110
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void testPathContent() throws URISyntaxException, IOException {
Path path = Paths.get($.class.getResource("/poem.txt").toURI());
System.out.println(path.toAbsolutePath());
PathContentProvider pathContentProvider = new PathContentProvider(path);
MultiPartContentProvider multiPartProvider = new MultiPartContentProvider();
multiPartProvider.addFilePart("poetry", "poem.txt", pathContentProvider, null);
multiPartProvider.close();
multiPartProvider.setListener(() -> System.out.println("on content"));
List<ByteBuffer> list = new ArrayList<>();
for (ByteBuffer buf : multiPartProvider) {
list.add(buf);
}
System.out.println(multiPartProvider.getLength());
Assert.assertThat(multiPartProvider.getLength(), greaterThan(0L));
Assert.assertThat(multiPartProvider.getLength(), is($.buffer.remaining(list)));
} | #vulnerable code
@Test
public void testPathContent() throws URISyntaxException, IOException {
Path path = Paths.get($.class.getResource("/poem.txt").toURI());
System.out.println(path.toAbsolutePath());
PathContentProvider pathContentProvider = new PathContentProvider(path);
MultiPartContentProvider multiPartProvider = new MultiPartContentProvider();
multiPartProvider.addFilePart("poetry", "poem.txt", pathContentProvider, null);
multiPartProvider.close();
multiPartProvider.setListener(() -> System.out.println("on content"));
List<ByteBuffer> list = new ArrayList<>();
for (ByteBuffer buf : multiPartProvider) {
list.add(buf);
}
System.out.println(multiPartProvider.getLength());
Assert.assertThat(multiPartProvider.getLength(), greaterThan(0L));
Assert.assertThat(multiPartProvider.getLength(), is(BufferUtils.remaining(list)));
}
#location 16
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void testMultiParse() throws Exception {
ByteBuffer buffer = BufferUtils.toBuffer("GET /mp HTTP/1.0\015\012" + "Connection: Keep-Alive\015\012"
+ "Header1: value1\015\012" + "Transfer-Encoding: chunked\015\012" + "\015\012" + "a;\015\012"
+ "0123456789\015\012" + "1a\015\012" + "ABCDEFGHIJKLMNOPQRSTUVWXYZ\015\012" + "0\015\012"
+ "\015\012"
+ "POST /foo HTTP/1.0\015\012" + "Connection: Keep-Alive\015\012" + "Header2: value2\015\012"
+ "Content-Length: 0\015\012" + "\015\012"
+ "PUT /doodle HTTP/1.0\015\012" + "Connection: close\015\012" + "Header3: value3\015\012"
+ "Content-Length: 10\015\012" + "\015\012" + "0123456789\015\012");
HttpParser.RequestHandler handler = new Handler();
HttpParser parser = new HttpParser(handler);
parser.parseNext(buffer);
assertEquals("GET", _methodOrVersion);
assertEquals("/mp", _uriOrStatus);
assertEquals("HTTP/1.0", _versionOrReason);
assertEquals(2, _headers);
assertEquals("Header1", _hdr[1]);
assertEquals("value1", _val[1]);
assertEquals("0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ", _content);
parser.reset();
init();
parser.parseNext(buffer);
assertEquals("POST", _methodOrVersion);
assertEquals("/foo", _uriOrStatus);
assertEquals("HTTP/1.0", _versionOrReason);
assertEquals(2, _headers);
assertEquals("Header2", _hdr[1]);
assertEquals("value2", _val[1]);
assertEquals(null, _content);
parser.reset();
init();
parser.parseNext(buffer);
parser.atEOF();
assertEquals("PUT", _methodOrVersion);
assertEquals("/doodle", _uriOrStatus);
assertEquals("HTTP/1.0", _versionOrReason);
assertEquals(2, _headers);
assertEquals("Header3", _hdr[1]);
assertEquals("value3", _val[1]);
assertEquals("0123456789", _content);
} | #vulnerable code
@Test
public void testMultiParse() throws Exception {
ByteBuffer buffer = BufferUtils.toBuffer("GET /mp HTTP/1.0\015\012" + "Connection: Keep-Alive\015\012"
+ "Header1: value1\015\012" + "Transfer-Encoding: chunked\015\012" + "\015\012" + "a;\015\012"
+ "0123456789\015\012" + "1a\015\012" + "ABCDEFGHIJKLMNOPQRSTUVWXYZ\015\012" + "0\015\012"
+ "\015\012"
+ "POST /foo HTTP/1.0\015\012" + "Connection: Keep-Alive\015\012" + "Header2: value2\015\012"
+ "Content-Length: 0\015\012" + "\015\012"
+ "PUT /doodle HTTP/1.0\015\012" + "Connection: close\015\012" + "Header3: value3\015\012"
+ "Content-Length: 10\015\012" + "\015\012" + "0123456789\015\012");
HttpParser.RequestHandler handler = new Handler();
HttpParser parser = new HttpParser(handler);
parser.parseNext(buffer);
assertEquals("GET", _methodOrVersion);
assertEquals("/mp", _uriOrStatus);
assertEquals("HTTP/1.0", _versionOrReason);
assertEquals(2, _headers);
assertEquals("Header1", _hdr[1]);
assertEquals("value1", _val[1]);
assertEquals("0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ", _content);
parser.reset();
init();
parser.parseNext(buffer);
assertEquals("POST", _methodOrVersion);
assertEquals("/foo", _uriOrStatus);
assertEquals("HTTP/1.0", _versionOrReason);
assertEquals(2, _headers);
assertEquals("Header2", _hdr[1]);
assertEquals("value2", _val[1]);
assertEquals(null, _content);
parser.reset();
init();
parser.parseNext(buffer);
parser.atEOF();
assertEquals("PUT", _methodOrVersion);
assertEquals("/doodle", _uriOrStatus);
assertEquals("HTTP/1.0", _versionOrReason);
assertEquals(2, _headers);
assertEquals("Header3", _hdr[1]);
assertEquals("value3", _val[1]);
assertEquals("0123456789", _content);
}
#location 33
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void testWindowUpdate() throws Throwable {
MockSession clientSession = new MockSession();
MockSession serverSession = new MockSession();
try(SpdySessionAttachment clientAttachment = new SpdySessionAttachment(new Connection(clientSession, true));
SpdySessionAttachment serverAttachment = new SpdySessionAttachment(new Connection(serverSession, false));) {
clientSession.attachObject(clientAttachment);
serverSession.attachObject(serverAttachment);
// Client creates a stream
Stream clientStream = clientAttachment.getConnection().createStream(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
System.out.println("Client receives reply frame -> " + synReplyFrame);
Assert.assertThat(synReplyFrame.getHeaders().get("response").getValue(), is("ok"));
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
System.out.println("Client receives data -> " + dataFrame);
if(dataFrame.getFlags() == DataFrame.FLAG_FIN) {
Assert.assertThat(new String(dataFrame.getData()), is("the server has received messages"));
}
}});
Assert.assertThat(clientStream.getId(), is(1));
Assert.assertThat(clientStream.getPriority(), is((byte)0));
Assert.assertThat(clientAttachment.getConnection().getStream(1) == clientStream, is(true));
// Client sends a SYN stream to server
Fields headers = clientStream.createFields();
headers.put("test1", "testValue1");
headers.put("test2", "testValue2");
headers.add("testM1", "testm1");
headers.add("testM2", "testm2");
clientStream.syn(Version.V3, (byte)0, 0, (byte)0, headers);
Assert.assertThat(clientStream.getWindowSize(), is(64 * 1024));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(64 * 1024));
// Server receives a SYN stream
serverDecoder.decode(clientSession.outboundData.poll(), serverSession);
// Client sends data frames
int currentWindowSize = 64 * 1024;
byte[] data = "hello world".getBytes();
clientStream.sendData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
data = "data2".getBytes();
clientStream.sendData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
data = "data3".getBytes();
clientStream.sendLastData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientStream.isOutboundClosed(), is(true));
Assert.assertThat(clientStream.isInboundClosed(), is(false));
// Server receives data
ByteBuffer buf = null;
while( (buf = clientSession.outboundData.poll()) != null ) {
serverDecoder.decode(buf, serverSession);
}
// Server sends window update and replies
while( (buf = serverSession.outboundData.poll()) != null ) {
clientDecoder.decode(buf, clientSession);
}
Assert.assertThat(clientStream.isOutboundClosed(), is(true));
Assert.assertThat(clientStream.isInboundClosed(), is(true));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(64 * 1024));
}
} | #vulnerable code
@Test
public void testWindowUpdate() throws Throwable {
MockSession clientSession = new MockSession();
MockSession serverSession = new MockSession();
SpdySessionAttachment clientAttachment = new SpdySessionAttachment(new Connection(clientSession, true));
SpdySessionAttachment serverAttachment = new SpdySessionAttachment(new Connection(serverSession, false));
clientSession.attachObject(clientAttachment);
serverSession.attachObject(serverAttachment);
SpdyDecoder clientDecoder = new SpdyDecoder(new DefaultSpdyDecodingEventListener(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
}}, new SettingsManager(null, "localhost", 7777)));
SpdyDecoder serverDecoder = new SpdyDecoder(new DefaultSpdyDecodingEventListener(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
System.out.println("Server receives syn stream -> " + synStreamFrame);
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
System.out.println("Server receives data -> " + dataFrame);
if(dataFrame.getFlags() == DataFrame.FLAG_FIN) {
Fields headers = stream.createFields();
headers.put("response", "ok");
stream.reply(Version.V3, (byte)0, headers);
stream.sendLastData("the server has received messages".getBytes());
}
}}, null));
// Client creates a stream
Stream clientStream = clientAttachment.getConnection().createStream(new StreamEventListener(){
@Override
public void onSynStream(SynStreamFrame synStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onSynReply(SynReplyFrame synReplyFrame, Stream stream, Connection connection) {
System.out.println("Client receives reply frame -> " + synReplyFrame);
Assert.assertThat(synReplyFrame.getHeaders().get("response").getValue(), is("ok"));
}
@Override
public void onRstStream(RstStreamFrame rstStreamFrame, Stream stream, Connection connection) {
}
@Override
public void onHeaders(HeadersFrame headersFrame, Stream stream, Connection connection) {
}
@Override
public void onData(DataFrame dataFrame, Stream stream, Connection connection) {
System.out.println("Client receives data -> " + dataFrame);
if(dataFrame.getFlags() == DataFrame.FLAG_FIN) {
Assert.assertThat(new String(dataFrame.getData()), is("the server has received messages"));
}
}});
Assert.assertThat(clientStream.getId(), is(1));
Assert.assertThat(clientStream.getPriority(), is((byte)0));
Assert.assertThat(clientAttachment.getConnection().getStream(1) == clientStream, is(true));
// Client sends a SYN stream to server
Fields headers = clientStream.createFields();
headers.put("test1", "testValue1");
headers.put("test2", "testValue2");
headers.add("testM1", "testm1");
headers.add("testM2", "testm2");
clientStream.syn(Version.V3, (byte)0, 0, (byte)0, headers);
Assert.assertThat(clientStream.getWindowSize(), is(64 * 1024));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(64 * 1024));
// Server receives a SYN stream
serverDecoder.decode(clientSession.outboundData.poll(), serverSession);
// Client sends data frames
int currentWindowSize = 64 * 1024;
byte[] data = "hello world".getBytes();
clientStream.sendData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
data = "data2".getBytes();
clientStream.sendData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
data = "data3".getBytes();
clientStream.sendLastData(data);
currentWindowSize -= data.length;
Assert.assertThat(clientStream.getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(currentWindowSize));
Assert.assertThat(clientStream.isOutboundClosed(), is(true));
Assert.assertThat(clientStream.isInboundClosed(), is(false));
// Server receives data
ByteBuffer buf = null;
while( (buf = clientSession.outboundData.poll()) != null ) {
serverDecoder.decode(buf, serverSession);
}
// Server sends window update and replies
while( (buf = serverSession.outboundData.poll()) != null ) {
clientDecoder.decode(buf, clientSession);
}
Assert.assertThat(clientStream.isOutboundClosed(), is(true));
Assert.assertThat(clientStream.isInboundClosed(), is(true));
Assert.assertThat(clientAttachment.getConnection().getWindowSize(), is(64 * 1024));
}
#location 17
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
HTTP1ServerConnection(HTTP2Configuration config, Session tcpSession, SecureSession secureSession,
HTTP1ServerRequestHandler requestHandler, ServerSessionListener serverSessionListener) {
super(config, secureSession, tcpSession, requestHandler, null);
requestHandler.connection = this;
this.serverSessionListener = serverSessionListener;
this.serverRequestHandler = requestHandler;
} | #vulnerable code
boolean directUpgradeHTTP2(MetaData.Request request) {
if (HttpMethod.PRI.is(request.getMethod())) {
HTTP2ServerConnection http2ServerConnection = new HTTP2ServerConnection(config, tcpSession, secureSession,
serverSessionListener);
tcpSession.attachObject(http2ServerConnection);
http2ServerConnection.getParser().directUpgrade();
upgradeHTTP2Successfully = true;
return true;
} else {
return false;
}
}
#location 7
#vulnerability type THREAD_SAFETY_VIOLATION | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void testInputStreamContent() {
InputStream inputStream = $.class.getResourceAsStream("/poem.txt");
InputStreamContentProvider inputStreamContentProvider = new InputStreamContentProvider(inputStream);
MultiPartContentProvider multiPartProvider = new MultiPartContentProvider();
System.out.println(multiPartProvider.getContentType());
multiPartProvider.addFilePart("poetry", "poem.txt", inputStreamContentProvider, null);
multiPartProvider.close();
multiPartProvider.setListener(() -> System.out.println("on content"));
List<ByteBuffer> list = new ArrayList<>();
for (ByteBuffer buf : multiPartProvider) {
list.add(buf);
}
String value = $.buffer.toString(list);
Assert.assertThat(value.length(), greaterThan(0));
System.out.println(multiPartProvider.getLength());
Assert.assertThat(multiPartProvider.getLength(), lessThan(0L));
} | #vulnerable code
@Test
public void testInputStreamContent() {
InputStream inputStream = $.class.getResourceAsStream("/poem.txt");
InputStreamContentProvider inputStreamContentProvider = new InputStreamContentProvider(inputStream);
MultiPartContentProvider multiPartProvider = new MultiPartContentProvider();
System.out.println(multiPartProvider.getContentType());
multiPartProvider.addFilePart("poetry", "poem.txt", inputStreamContentProvider, null);
multiPartProvider.close();
multiPartProvider.setListener(() -> System.out.println("on content"));
List<ByteBuffer> list = new ArrayList<>();
for (ByteBuffer buf : multiPartProvider) {
list.add(buf);
}
String value = BufferUtils.toString(list);
Assert.assertThat(value.length(), greaterThan(0));
System.out.println(multiPartProvider.getLength());
Assert.assertThat(multiPartProvider.getLength(), lessThan(0L));
}
#location 16
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void testGetLocationOfClass() throws Exception {
// Class from project dependencies
Assert.assertThat(TypeUtils.getLocationOfClass(TypeUtils.class).toASCIIString(), Matchers.containsString("/classes/"));
// Class from JVM core
String expectedJavaBase = "/rt.jar";
if (JDK.IS_9)
expectedJavaBase = "/java.base/";
Assert.assertThat(TypeUtils.getLocationOfClass(String.class).toASCIIString(), Matchers.containsString(expectedJavaBase));
} | #vulnerable code
@Test
public void testGetLocationOfClass() throws Exception {
// Classes from maven dependencies
Assert.assertThat(TypeUtils.getLocationOfClass(Assert.class).toASCIIString(), Matchers.containsString("repository"));
// Class from project dependencies
Assert.assertThat(TypeUtils.getLocationOfClass(TypeUtils.class).toASCIIString(), Matchers.containsString("/classes/"));
// Class from JVM core
String expectedJavaBase = "/rt.jar";
if (JDK.IS_9)
expectedJavaBase = "/java.base/";
Assert.assertThat(TypeUtils.getLocationOfClass(String.class).toASCIIString(), Matchers.containsString(expectedJavaBase));
}
#location 4
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public static void main(String[] args) throws Throwable{
Certificate[] certificates = getCertificates("fireflySSLkeys.jks", "fireflySSLkeys");
for(Certificate certificate : certificates) {
System.out.println(certificate);
}
certificates = getCertificates("fireflykeys", "fireflysource");
for(Certificate certificate : certificates) {
System.out.println(certificate);
}
} | #vulnerable code
public static void main(String[] args) throws Throwable {
FileInputStream in = null;
ByteArrayOutputStream out = null;
try {
in = new FileInputStream(new File("/Users/qiupengtao", "fireflykeys"));
out = new ByteArrayOutputStream();
byte[] buf = new byte[1024];
for (int i = 0; (i = in.read(buf)) != -1;) {
byte[] temp = new byte[i];
System.arraycopy(buf, 0, temp, 0, i);
out.write(temp);
}
byte[] ret = out.toByteArray();
// System.out.println(ret.length);
System.out.println(Arrays.toString(ret));
} finally {
in.close();
out.close();
}
}
#location 21
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void testNestedClass() throws Exception {
Map<String, FieldGenericTypeBind> map = ReflectUtils.getGenericBeanFields(barRef);
FieldGenericTypeBind barMaps = map.get("maps");
ParameterizedType parameterizedType = (ParameterizedType) barMaps.getType();
System.out.println(parameterizedType.getTypeName());
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.Map<java.lang.String, java.util.Map<java.lang.String, java.util.List<test.utils.lang.TestGenericTypeReference$Foo>>>"));
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
FieldGenericTypeBind bar = map.get("bar");
parameterizedType = (ParameterizedType) bar.getType();
System.out.println(parameterizedType.getTypeName());
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.List<java.lang.String>"));
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
map = ReflectUtils.getGenericBeanFields(carRef);
FieldGenericTypeBind car = map.get("car");
parameterizedType = (ParameterizedType) car.getType();
System.out.println(parameterizedType.getTypeName());
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.List<java.lang.Integer>"));
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
map = ReflectUtils.getGenericBeanFields(parRef);
FieldGenericTypeBind par = map.get("par");
Class<?> clazz = (Class<?>) par.getType();
System.out.println(clazz.getTypeName());
Assert.assertThat(clazz.getTypeName(), is("java.lang.String"));
Map<String, MethodGenericTypeBind> getterMap = ReflectUtils.getGenericBeanGetterMethods(sarRef);
MethodGenericTypeBind list = getterMap.get("list");
System.out.println(list.getType().getTypeName());
Assert.assertThat(list.getType().getTypeName(), is("java.util.List<java.util.Map<java.lang.String, test.utils.lang.TestGenericTypeReference$Foo>>"));
MethodGenericTypeBind sar = getterMap.get("sar");
Assert.assertThat(sar.getType().getTypeName(), is("java.lang.Integer"));
} | #vulnerable code
@Test
public void testNestedClass() throws Exception {
Map<String, FieldGenericTypeBind> map = ReflectUtils.getGenericBeanFields(
new GenericTypeReference<Request<Map<String, Foo>, String, Map<String, List<Foo>>>.Bar<List<String>>>() {
}, null);
FieldGenericTypeBind barMaps = map.get("maps");
ParameterizedType parameterizedType = (ParameterizedType) barMaps.getType();
System.out.println(parameterizedType.getTypeName());
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.Map<java.lang.String, java.util.Map<java.lang.String, java.util.List<test.utils.lang.TestGenericTypeReference$Foo>>>"));
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
FieldGenericTypeBind bar = map.get("bar");
parameterizedType = (ParameterizedType) bar.getType();
System.out.println(parameterizedType.getTypeName());
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.List<java.lang.String>"));
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
map = ReflectUtils.getGenericBeanFields(
new GenericTypeReference<Request<Map<String, Foo>, String, Map<String, List<Foo>>>.Car<List<String>>>() {
}, null);
FieldGenericTypeBind car = map.get("car");
parameterizedType = (ParameterizedType) car.getType();
System.out.println(parameterizedType.getTypeName());
System.out.println(parameterizedType.getOwnerType());
Assert.assertThat(parameterizedType.getTypeName(), is("java.util.List<java.lang.String>"));
Assert.assertThat(parameterizedType.getOwnerType(), nullValue());
map = ReflectUtils.getGenericBeanFields(
new GenericTypeReference<Request<Map<String, Foo>, String, Map<String, List<Foo>>>.Par>() {
}, null);
FieldGenericTypeBind par = map.get("par");
Class<?> clazz = (Class<?>) par.getType();
System.out.println(clazz.getTypeName());
Assert.assertThat(clazz.getTypeName(), is("java.lang.String"));
}
#location 26
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public static Word2VecModel fromBinFile(File file, ByteOrder byteOrder)
throws IOException {
try (FileInputStream fis = new FileInputStream(file);) {
final FileChannel channel = fis.getChannel();
final long oneGB = 1024 * 1024 * 1024;
MappedByteBuffer buffer =
channel.map(
FileChannel.MapMode.READ_ONLY,
0,
Math.min(channel.size(), Integer.MAX_VALUE));
buffer.order(byteOrder);
int bufferCount = 1;
// Java's NIO only allows memory-mapping up to 2GB. To work around this problem, we re-map
// every gigabyte. To calculate offsets correctly, we have to keep track how many gigabytes
// we've already skipped. That's what this is for.
StringBuilder sb = new StringBuilder();
char c = (char)buffer.get();
while (c != '\n') {
sb.append(c);
c = (char)buffer.get();
}
String firstLine = sb.toString();
int index = firstLine.indexOf(' ');
Preconditions.checkState(index != -1,
"Expected a space in the first line of file '%s': '%s'",
file.getAbsolutePath(), firstLine);
final int vocabSize = Integer.parseInt(firstLine.substring(0, index));
final int layerSize = Integer.parseInt(firstLine.substring(index + 1));
logger.info(
String.format("Loading %d vectors with dimensionality %d", vocabSize, layerSize));
List<String> vocabs = new ArrayList<String>(vocabSize);
double vectors[] = new double[vocabSize * layerSize];
long lastLogMessage = System.currentTimeMillis();
final float[] floats = new float[layerSize];
for (int lineno = 0; lineno < vocabSize; lineno++) {
// read vocab
sb.setLength(0);
c = (char)buffer.get();
while (c != ' ') {
// ignore newlines in front of words (some binary files have newline,
// some don't)
if (c != '\n') {
sb.append(c);
}
c = (char)buffer.get();
}
vocabs.add(sb.toString());
// read vector
final FloatBuffer floatBuffer = buffer.asFloatBuffer();
floatBuffer.get(floats);
for(int i = 0; i < floats.length; ++i) {
vectors[lineno * layerSize + i] = floats[i];
}
buffer.position(buffer.position() + 4 * layerSize);
// print log
final long now = System.currentTimeMillis();
if(now - lastLogMessage > 1000) {
final double percentage = ((double)(lineno + 1) / (double)vocabSize) * 100.0;
logger.info(
String.format("Loaded %d/%d vectors (%f%%)", lineno + 1, vocabSize, percentage));
lastLogMessage = now;
}
// remap file
if(buffer.position() > oneGB) {
final int newPosition = (int)(buffer.position() - oneGB);
final long size = Math.min(channel.size() - oneGB * bufferCount, Integer.MAX_VALUE);
logger.debug(
String.format(
"Remapping for GB number %d. Start: %d, size: %d",
bufferCount,
oneGB * bufferCount,
size));
buffer = channel.map(
FileChannel.MapMode.READ_ONLY,
oneGB * bufferCount,
size);
buffer.order(byteOrder);
buffer.position(newPosition);
bufferCount += 1;
}
}
return new Word2VecModel(vocabs, layerSize, vectors);
}
} | #vulnerable code
public static Word2VecModel fromBinFile(File file, ByteOrder byteOrder)
throws IOException {
try (FileInputStream fis = new FileInputStream(file);) {
DataInput in = (byteOrder == ByteOrder.BIG_ENDIAN) ?
new DataInputStream(fis) : new SwappedDataInputStream(fis);
StringBuilder sb = new StringBuilder();
char c = (char) in.readByte();
while (c != '\n') {
sb.append(c);
c = (char) in.readByte();
}
String firstLine = sb.toString();
int index = firstLine.indexOf(' ');
Preconditions.checkState(index != -1,
"Expected a space in the first line of file '%s': '%s'",
file.getAbsolutePath(), firstLine);
int vocabSize = Integer.parseInt(firstLine.substring(0, index));
int layerSize = Integer.parseInt(firstLine.substring(index + 1));
List<String> vocabs = Lists.newArrayList();
List<Double> vectors = Lists.newArrayList();
for (int lineno = 0; lineno < vocabSize; lineno++) {
sb = new StringBuilder();
c = (char) in.readByte();
while (c != ' ') {
// ignore newlines in front of words (some binary files have newline,
// some don't)
if (c != '\n') {
sb.append(c);
}
c = (char) in.readByte();
}
vocabs.add(sb.toString());
for (int i = 0; i < layerSize; i++) {
vectors.add((double) in.readFloat());
}
}
return fromThrift(new Word2VecModelThrift()
.setLayerSize(layerSize)
.setVocab(vocabs)
.setVectors(vectors));
}
}
#location 44
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public static Word2VecModel fromBinFile(File file, ByteOrder byteOrder)
throws IOException {
try (FileInputStream fis = new FileInputStream(file);) {
final FileChannel channel = fis.getChannel();
final long oneGB = 1024 * 1024 * 1024;
MappedByteBuffer buffer =
channel.map(
FileChannel.MapMode.READ_ONLY,
0,
Math.min(channel.size(), Integer.MAX_VALUE));
buffer.order(byteOrder);
int bufferCount = 1;
// Java's NIO only allows memory-mapping up to 2GB. To work around this problem, we re-map
// every gigabyte. To calculate offsets correctly, we have to keep track how many gigabytes
// we've already skipped. That's what this is for.
StringBuilder sb = new StringBuilder();
char c = (char)buffer.get();
while (c != '\n') {
sb.append(c);
c = (char)buffer.get();
}
String firstLine = sb.toString();
int index = firstLine.indexOf(' ');
Preconditions.checkState(index != -1,
"Expected a space in the first line of file '%s': '%s'",
file.getAbsolutePath(), firstLine);
final int vocabSize = Integer.parseInt(firstLine.substring(0, index));
final int layerSize = Integer.parseInt(firstLine.substring(index + 1));
logger.info(
String.format("Loading %d vectors with dimensionality %d", vocabSize, layerSize));
List<String> vocabs = new ArrayList<String>(vocabSize);
double vectors[] = new double[vocabSize * layerSize];
long lastLogMessage = System.currentTimeMillis();
final float[] floats = new float[layerSize];
for (int lineno = 0; lineno < vocabSize; lineno++) {
// read vocab
sb.setLength(0);
c = (char)buffer.get();
while (c != ' ') {
// ignore newlines in front of words (some binary files have newline,
// some don't)
if (c != '\n') {
sb.append(c);
}
c = (char)buffer.get();
}
vocabs.add(sb.toString());
// read vector
final FloatBuffer floatBuffer = buffer.asFloatBuffer();
floatBuffer.get(floats);
for(int i = 0; i < floats.length; ++i) {
vectors[lineno * layerSize + i] = floats[i];
}
buffer.position(buffer.position() + 4 * layerSize);
// print log
final long now = System.currentTimeMillis();
if(now - lastLogMessage > 1000) {
final double percentage = ((double)(lineno + 1) / (double)vocabSize) * 100.0;
logger.info(
String.format("Loaded %d/%d vectors (%f%%)", lineno + 1, vocabSize, percentage));
lastLogMessage = now;
}
// remap file
if(buffer.position() > oneGB) {
final int newPosition = (int)(buffer.position() - oneGB);
final long size = Math.min(channel.size() - oneGB * bufferCount, Integer.MAX_VALUE);
logger.debug(
String.format(
"Remapping for GB number %d. Start: %d, size: %d",
bufferCount,
oneGB * bufferCount,
size));
buffer = channel.map(
FileChannel.MapMode.READ_ONLY,
oneGB * bufferCount,
size);
buffer.order(byteOrder);
buffer.position(newPosition);
bufferCount += 1;
}
}
return new Word2VecModel(vocabs, layerSize, vectors);
}
} | #vulnerable code
public static Word2VecModel fromBinFile(File file, ByteOrder byteOrder)
throws IOException {
try (FileInputStream fis = new FileInputStream(file);) {
DataInput in = (byteOrder == ByteOrder.BIG_ENDIAN) ?
new DataInputStream(fis) : new SwappedDataInputStream(fis);
StringBuilder sb = new StringBuilder();
char c = (char) in.readByte();
while (c != '\n') {
sb.append(c);
c = (char) in.readByte();
}
String firstLine = sb.toString();
int index = firstLine.indexOf(' ');
Preconditions.checkState(index != -1,
"Expected a space in the first line of file '%s': '%s'",
file.getAbsolutePath(), firstLine);
int vocabSize = Integer.parseInt(firstLine.substring(0, index));
int layerSize = Integer.parseInt(firstLine.substring(index + 1));
List<String> vocabs = Lists.newArrayList();
List<Double> vectors = Lists.newArrayList();
for (int lineno = 0; lineno < vocabSize; lineno++) {
sb = new StringBuilder();
c = (char) in.readByte();
while (c != ' ') {
// ignore newlines in front of words (some binary files have newline,
// some don't)
if (c != '\n') {
sb.append(c);
}
c = (char) in.readByte();
}
vocabs.add(sb.toString());
for (int i = 0; i < layerSize; i++) {
vectors.add((double) in.readFloat());
}
}
return fromThrift(new Word2VecModelThrift()
.setLayerSize(layerSize)
.setVocab(vocabs)
.setVectors(vectors));
}
}
#location 4
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public static Word2VecModel fromBinFile(File file, ByteOrder byteOrder)
throws IOException {
try (FileInputStream fis = new FileInputStream(file);) {
final FileChannel channel = fis.getChannel();
final long oneGB = 1024 * 1024 * 1024;
MappedByteBuffer buffer =
channel.map(
FileChannel.MapMode.READ_ONLY,
0,
Math.min(channel.size(), Integer.MAX_VALUE));
buffer.order(byteOrder);
int bufferCount = 1;
// Java's NIO only allows memory-mapping up to 2GB. To work around this problem, we re-map
// every gigabyte. To calculate offsets correctly, we have to keep track how many gigabytes
// we've already skipped. That's what this is for.
StringBuilder sb = new StringBuilder();
char c = (char)buffer.get();
while (c != '\n') {
sb.append(c);
c = (char)buffer.get();
}
String firstLine = sb.toString();
int index = firstLine.indexOf(' ');
Preconditions.checkState(index != -1,
"Expected a space in the first line of file '%s': '%s'",
file.getAbsolutePath(), firstLine);
final int vocabSize = Integer.parseInt(firstLine.substring(0, index));
final int layerSize = Integer.parseInt(firstLine.substring(index + 1));
logger.info(
String.format("Loading %d vectors with dimensionality %d", vocabSize, layerSize));
List<String> vocabs = new ArrayList<String>(vocabSize);
double vectors[] = new double[vocabSize * layerSize];
long lastLogMessage = System.currentTimeMillis();
final float[] floats = new float[layerSize];
for (int lineno = 0; lineno < vocabSize; lineno++) {
// read vocab
sb.setLength(0);
c = (char)buffer.get();
while (c != ' ') {
// ignore newlines in front of words (some binary files have newline,
// some don't)
if (c != '\n') {
sb.append(c);
}
c = (char)buffer.get();
}
vocabs.add(sb.toString());
// read vector
final FloatBuffer floatBuffer = buffer.asFloatBuffer();
floatBuffer.get(floats);
for(int i = 0; i < floats.length; ++i) {
vectors[lineno * layerSize + i] = floats[i];
}
buffer.position(buffer.position() + 4 * layerSize);
// print log
final long now = System.currentTimeMillis();
if(now - lastLogMessage > 1000) {
final double percentage = ((double)(lineno + 1) / (double)vocabSize) * 100.0;
logger.info(
String.format("Loaded %d/%d vectors (%f%%)", lineno + 1, vocabSize, percentage));
lastLogMessage = now;
}
// remap file
if(buffer.position() > oneGB) {
final int newPosition = (int)(buffer.position() - oneGB);
final long size = Math.min(channel.size() - oneGB * bufferCount, Integer.MAX_VALUE);
logger.debug(
String.format(
"Remapping for GB number %d. Start: %d, size: %d",
bufferCount,
oneGB * bufferCount,
size));
buffer = channel.map(
FileChannel.MapMode.READ_ONLY,
oneGB * bufferCount,
size);
buffer.order(byteOrder);
buffer.position(newPosition);
bufferCount += 1;
}
}
return new Word2VecModel(vocabs, layerSize, vectors);
}
} | #vulnerable code
public static Word2VecModel fromBinFile(File file, ByteOrder byteOrder)
throws IOException {
try (FileInputStream fis = new FileInputStream(file);) {
DataInput in = (byteOrder == ByteOrder.BIG_ENDIAN) ?
new DataInputStream(fis) : new SwappedDataInputStream(fis);
StringBuilder sb = new StringBuilder();
char c = (char) in.readByte();
while (c != '\n') {
sb.append(c);
c = (char) in.readByte();
}
String firstLine = sb.toString();
int index = firstLine.indexOf(' ');
Preconditions.checkState(index != -1,
"Expected a space in the first line of file '%s': '%s'",
file.getAbsolutePath(), firstLine);
int vocabSize = Integer.parseInt(firstLine.substring(0, index));
int layerSize = Integer.parseInt(firstLine.substring(index + 1));
List<String> vocabs = Lists.newArrayList();
List<Double> vectors = Lists.newArrayList();
for (int lineno = 0; lineno < vocabSize; lineno++) {
sb = new StringBuilder();
c = (char) in.readByte();
while (c != ' ') {
// ignore newlines in front of words (some binary files have newline,
// some don't)
if (c != '\n') {
sb.append(c);
}
c = (char) in.readByte();
}
vocabs.add(sb.toString());
for (int i = 0; i < layerSize; i++) {
vectors.add((double) in.readFloat());
}
}
return fromThrift(new Word2VecModelThrift()
.setLayerSize(layerSize)
.setVocab(vocabs)
.setVectors(vectors));
}
}
#location 44
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public static void main(final String... args) throws IOException, ExecutionException, InterruptedException {
final String project = Util.defaultProject();
GoogleCredential credential;
// Use credentials from file if available
try {
credential = GoogleCredential
.fromStream(new FileInputStream("credentials.json"))
.createScoped(PubsubScopes.all());
} catch (IOException e) {
credential = GoogleCredential.getApplicationDefault()
.createScoped(PubsubScopes.all());
}
final Pubsub pubsub = Pubsub.builder()
.credential(credential)
.compressionLevel(Deflater.BEST_SPEED)
.enabledCipherSuites(Util.nonGcmCiphers())
.build();
LoggingConfigurator.configureDefaults("benchmark", WARN);
System.setProperty("https.cipherSuites", Joiner.on(',').join(Util.nonGcmCiphers()));
final String subscription = System.getenv("GOOGLE_PUBSUB_SUBSCRIPTION");
if (subscription == null) {
System.err.println("Please specify a subscription using the GOOGLE_PUBSUB_SUBSCRIPTION environment variable.");
System.exit(1);
}
System.out.println("Consuming from GOOGLE_PUBSUB_SUBSCRIPTION='" + subscription + "'");
final ProgressMeter meter = new ProgressMeter();
final ProgressMeter.Metric receives = meter.group("operations").metric("receives", "messages");
final Puller puller = Puller.builder()
.pubsub(pubsub)
.batchSize(1000)
.concurrency(PULLER_CONCURRENCY)
.project(project)
.subscription(subscription)
.messageHandler(new Handler(receives))
.build();
while (true) {
Thread.sleep(1000);
System.out.println("outstanding messages: " + puller.outstandingMessages());
System.out.println("outstanding requests: " + puller.outstandingRequests());
}
} | #vulnerable code
public static void main(final String... args) throws IOException, ExecutionException, InterruptedException {
final String project = Util.defaultProject();
GoogleCredential credential;
// Use credentials from file if available
try {
credential = GoogleCredential
.fromStream(new FileInputStream("credentials.json"))
.createScoped(PubsubScopes.all());
} catch (IOException e) {
credential = GoogleCredential.getApplicationDefault()
.createScoped(PubsubScopes.all());
}
final Pubsub pubsub = Pubsub.builder()
.credential(credential)
.compressionLevel(Deflater.BEST_SPEED)
.enabledCipherSuites(Util.nonGcmCiphers())
.build();
LoggingConfigurator.configureDefaults("benchmark", WARN);
final String subscription = System.getenv("GOOGLE_PUBSUB_SUBSCRIPTION");
if (subscription == null) {
System.err.println("Please specify a subscription using the GOOGLE_PUBSUB_SUBSCRIPTION environment variable.");
System.exit(1);
}
System.out.println("Consuming from GOOGLE_PUBSUB_SUBSCRIPTION='" + subscription + "'");
final ProgressMeter meter = new ProgressMeter();
final ProgressMeter.Metric receives = meter.group("operations").metric("receives", "messages");
final Puller puller = Puller.builder()
.pubsub(pubsub)
.batchSize(1000)
.concurrency(PULLER_CONCURRENCY)
.project(project)
.subscription(subscription)
.messageHandler(new Handler(receives))
.build();
while (true) {
Thread.sleep(1000);
}
}
#location 21
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Override
public Mono<Payload> requestResponse(Payload payload) {
RSocket service = findRSocket(payload);
return service.requestResponse(payload);
} | #vulnerable code
@Override
public Mono<Payload> requestResponse(Payload payload) {
List<String> metadata = getRoutingMetadata(payload);
RSocket service = findRSocket(metadata);
if (service != null) {
return service.requestResponse(payload);
}
MonoProcessor<RSocket> processor = MonoProcessor.create();
this.registry.pendingRequest(metadata, processor);
return processor
.log("pending-request")
.flatMap(rSocket -> rSocket.requestResponse(payload));
}
#location 11
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Override
public Mono<RSocket> accept(ConnectionSetupPayload setup, RSocket sendingSocket) {
if (setup.hasMetadata()) { // and setup.metadataMimeType() is Announcement metadata
String annoucementMetadata = Metadata.decodeAnnouncement(setup.sliceMetadata());
List<String> tags = Collections.singletonList(annoucementMetadata);
registry.register(tags, sendingSocket);
}
return Mono.just(proxyRSocket);
} | #vulnerable code
@Override
public Mono<RSocket> accept(ConnectionSetupPayload setup, RSocket sendingSocket) {
if (setup.hasMetadata()) { // and setup.metadataMimeType() is Announcement metadata
String annoucementMetadata = Metadata.decodeAnnouncement(setup.sliceMetadata());
List<String> tags = Collections.singletonList(annoucementMetadata);
registry.register(tags, sendingSocket);
List<MonoProcessor<RSocket>> processors = this.registry.getPendingRequests(tags);
if (!CollectionUtils.isEmpty(processors)) {
processors.forEach(processor -> {
processor.log("resume-pending-request");
processor.onNext(sendingSocket);
processor.onComplete();
});
}
}
return Mono.just(proxyRSocket);
}
#location 11
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
private RSocket findRSocket(List<String> tags) {
if (tags == null) return null;
RSocket rsocket = registry.getRegistered(tags);
if (rsocket == null) {
log.debug("Unable to find destination RSocket for " + tags);
}
// TODO: deal with connecting to cluster?
return rsocket;
} | #vulnerable code
private RSocket findRSocket(List<String> tags) {
if (tags == null) return null;
List<RSocket> rsockets = registry.getRegistered(tags);
if (CollectionUtils.isEmpty(rsockets)) {
log.debug("Unable to find destination RSocket for " + tags);
return null;
}
// TODO: deal with connecting to cluster?
// TODO: load balancing
RSocket rsocket = rsockets.get(0);
// if not connected previously, initialize connection
return rsocket;
}
#location 13
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Override
public Flux<Payload> requestStream(Payload payload) {
RSocket service = findRSocket(payload);
return service.requestStream(payload);
} | #vulnerable code
@Override
public Flux<Payload> requestStream(Payload payload) {
List<String> metadata = getRoutingMetadata(payload);
RSocket service = findRSocket(metadata);
if (service != null) {
return service.requestStream(payload);
}
MonoProcessor<RSocket> processor = MonoProcessor.create();
this.registry.pendingRequest(metadata, processor);
return processor
.log("pending-request")
.flatMapMany(rSocket -> rSocket.requestStream(payload));
}
#location 11
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Override
public Mono<Void> filter(ServerWebExchange exchange, WebFilterChain chain) {
Map<String, String> weights = getWeights(exchange);
for (String group : groupWeights.keySet()) {
GroupWeightConfig config = groupWeights.get(group);
if (config == null) {
if (log.isDebugEnabled()) {
log.debug("No GroupWeightConfig found for group: " + group);
}
continue; // nothing we can do, but this is odd
}
double r = this.random.nextDouble();
List<Double> ranges = config.ranges;
if (log.isTraceEnabled()) {
log.trace("Weight for group: " + group + ", ranges: " + ranges + ", r: "
+ r);
}
for (int i = 0; i < ranges.size() - 1; i++) {
if (r >= ranges.get(i) && r < ranges.get(i + 1)) {
String routeId = config.rangeIndexes.get(i);
weights.put(group, routeId);
break;
}
}
}
if (log.isTraceEnabled()) {
log.trace("Weights attr: " + weights);
}
return chain.filter(exchange);
} | #vulnerable code
@Override
public Mono<Void> filter(ServerWebExchange exchange, WebFilterChain chain) {
Map<String, String> weights = getWeights(exchange);
for (String group : groupWeights.keySet()) {
GroupWeightConfig config = groupWeights.get(group);
if (config == null) {
if (log.isDebugEnabled()) {
log.debug("No GroupWeightConfig found for group: " + group);
}
continue; // nothing we can do, but this is odd
}
double r = this.random.nextDouble();
synchronized (config) {
List<Double> ranges = config.ranges;
if (log.isTraceEnabled()) {
log.trace("Weight for group: " + group + ", ranges: " + ranges
+ ", r: " + r);
}
for (int i = 0; i < ranges.size() - 1; i++) {
if (r >= ranges.get(i) && r < ranges.get(i + 1)) {
String routeId = config.rangeIndexes.get(i);
weights.put(group, routeId);
break;
}
}
}
}
if (log.isTraceEnabled()) {
log.trace("Weights attr: " + weights);
}
return chain.filter(exchange);
}
#location 15
#vulnerability type THREAD_SAFETY_VIOLATION | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Override
public Flux<Payload> requestChannel(Payload payload, Publisher<Payload> payloads) {
GatewayExchange exchange = createExchange(REQUEST_CHANNEL, payload);
Tags responderTags = Tags.of("source", "responder");
return findRSocketOrCreatePending(exchange)
.flatMapMany(rSocket -> {
Tags requesterTags = Tags.of("source", "requester");
Flux<Payload> flux = Flux.from(payloads)
.doOnNext(s -> count(exchange, "payload", requesterTags))
.doOnError(t -> count(exchange, "error", requesterTags))
.doFinally(s -> count(exchange, requesterTags));
if (rSocket instanceof ResponderRSocket) {
ResponderRSocket socket = (ResponderRSocket) rSocket;
return socket.requestChannel(payload, flux)
.log(GatewayRSocket.class.getName()+".request-channel", Level.FINE);
}
return rSocket.requestChannel(flux);
})
.doOnNext(s -> count(exchange, "payload", responderTags))
.doOnError(t -> count(exchange, "error", responderTags))
.doFinally(s -> count(exchange, responderTags));
} | #vulnerable code
@Override
public Flux<Payload> requestChannel(Payload payload, Publisher<Payload> payloads) {
GatewayExchange exchange = GatewayExchange.fromPayload(REQUEST_CHANNEL, payload);
Tags tags = getTags(exchange);
Tags responderTags = tags.and("source", "responder");
return findRSocketOrCreatePending(exchange)
.flatMapMany(rSocket -> {
Tags requesterTags = tags.and("source", "requester");
Flux<Payload> flux = Flux.from(payloads)
.doOnNext(s -> count("forward.request.channel.payload", requesterTags))
.doOnError(t -> count("forward.request.channel.error", requesterTags))
.doFinally(s -> count("forward.request.channel", requesterTags));
if (rSocket instanceof ResponderRSocket) {
ResponderRSocket socket = (ResponderRSocket) rSocket;
return socket.requestChannel(payload, flux)
.log(GatewayRSocket.class.getName()+".request-channel", Level.FINE);
}
return rSocket.requestChannel(flux);
})
.doOnNext(s -> count("forward.request.channel.payload", responderTags))
.doOnError(t -> count("forward.request.channel.error", responderTags))
.doFinally(s -> count("forward.request.channel", responderTags));
}
#location 4
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Override
public Flux<Payload> requestStream(Payload payload) {
GatewayExchange exchange = createExchange(REQUEST_STREAM, payload);
return findRSocketOrCreatePending(exchange)
.flatMapMany(rSocket -> rSocket.requestStream(payload))
// S N E F
.doOnNext(s -> count(exchange, "payload"))
.doOnError(t -> count(exchange, "error"))
.doFinally(s -> count(exchange, Tags.empty()));
} | #vulnerable code
@Override
public Flux<Payload> requestStream(Payload payload) {
GatewayExchange exchange = GatewayExchange.fromPayload(REQUEST_STREAM, payload);
Tags tags = getTags(exchange);
return findRSocketOrCreatePending(exchange)
.flatMapMany(rSocket -> rSocket.requestStream(payload))
// S N E F
//TODO: move tagnames to enum
.doOnNext(s -> count("forward.request.stream.payload", tags))
.doOnError(t -> count("forward.request.stream.error", tags))
.doFinally(s -> count("forward.request.stream", tags));
}
#location 4
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Override
public Mono<Void> fireAndForget(Payload payload) {
GatewayExchange exchange = createExchange(FIRE_AND_FORGET, payload);
return findRSocketOrCreatePending(exchange)
.flatMap(rSocket -> rSocket.fireAndForget(payload))
.doOnError(t -> count(exchange, "error"))
.doFinally(s -> count(exchange, ""));
} | #vulnerable code
@Override
public Mono<Void> fireAndForget(Payload payload) {
GatewayExchange exchange = GatewayExchange.fromPayload(FIRE_AND_FORGET, payload);
Tags tags = getTags(exchange);
return findRSocketOrCreatePending(exchange)
.flatMap(rSocket -> rSocket.fireAndForget(payload))
.doOnError(t -> count("forward.request.fnf.error", tags))
.doFinally(s -> count("forward.request.fnf", tags));
}
#location 4
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Override
public Mono<Payload> requestResponse(Payload payload) {
AtomicReference<Timer.Sample> timer = new AtomicReference<>();
GatewayExchange exchange = createExchange(REQUEST_RESPONSE, payload);
return findRSocketOrCreatePending(exchange)
.flatMap(rSocket -> rSocket.requestResponse(payload))
.doOnSubscribe(s -> timer.set(Timer.start(meterRegistry)))
.doOnError(t -> count(exchange, "error"))
.doFinally(s -> timer.get().stop(meterRegistry.timer(getMetricName(exchange), exchange.getTags())));
} | #vulnerable code
@Override
public Mono<Payload> requestResponse(Payload payload) {
AtomicReference<Timer.Sample> timer = new AtomicReference<>();
GatewayExchange exchange = GatewayExchange.fromPayload(REQUEST_RESPONSE, payload);
Tags tags = getTags(exchange);
return findRSocketOrCreatePending(exchange)
.flatMap(rSocket -> rSocket.requestResponse(payload))
.doOnSubscribe(s -> timer.set(Timer.start(meterRegistry)))
.doOnError(t -> count("forward.request.response.error", tags))
.doFinally(s -> timer.get().stop(meterRegistry.timer("forward.request.response", tags)));
}
#location 5
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Override
public Mono<Void> fireAndForget(Payload payload) {
RSocket service = findRSocket(payload);
return service.fireAndForget(payload);
} | #vulnerable code
@Override
public Mono<Void> fireAndForget(Payload payload) {
List<String> metadata = getRoutingMetadata(payload);
RSocket service = findRSocket(metadata);
if (service != null) {
return service.fireAndForget(payload);
}
//TODO: handle concurrency issues
MonoProcessor<RSocket> processor = MonoProcessor.create();
this.registry.pendingRequest(metadata, processor);
return processor
.log("pending-request")
.flatMap(rSocket -> rSocket.fireAndForget(payload));
}
#location 12
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
private void displayJSON (HttpServletRequest request, HttpServletResponse response)
{
response.setContentType("text/plain");
try
{
ServletOutputStream out = response.getOutputStream();
out.println("[");
for (JSONObject district : districts)
{
out.println(district.toString());
}
out.println("]");
out.flush();
}
catch (IOException e)
{
e.printStackTrace();
}
} | #vulnerable code
private void displayJSON (HttpServletRequest request, HttpServletResponse response)
{
response.setContentType("text/plain");
try
{
BufferedWriter writer = new BufferedWriter(new OutputStreamWriter(response.getOutputStream()));
JSONArray out = new JSONArray();
for (JSONObject district : districts)
{
out.put(district);
}
writer.write(out.toString());
}
catch (IOException e)
{
e.printStackTrace();
}
}
#location 15
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public static void main(String[] args) throws Exception {
SearchEngine2 engine = SearchEngine2.getInstance();
BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
String line = null;
System.out.print("openlegLuceneConsole> ");
while (!(line = reader.readLine()).equals("quit"))
{
if (line.startsWith("index "))
{
String cmd = line.substring(line.indexOf(" ")+1);
StringTokenizer st = new StringTokenizer(cmd);
String iType = st.nextToken();
int start = 1;
int max = 1000000;
int pageSize = 10;
if (st.hasMoreTokens())
start = Integer.parseInt(st.nextToken());
if (st.hasMoreTokens())
max = Integer.parseInt(st.nextToken());
if (st.hasMoreTokens())
pageSize = Integer.parseInt(st.nextToken());
engine.indexSenateData(iType, start, max, pageSize,
new LuceneSerializer[]{new XmlSerializer(), new JsonSerializer()});
}
else if (line.startsWith("optimize"))
engine.optimize();
else if (line.startsWith("delete"))
{
StringTokenizer cmd = new StringTokenizer(line.substring(line.indexOf(" ")+1)," ");
String type = cmd.nextToken();
String id = cmd.nextToken();
engine.deleteSenateObjectById(type, id);
}
else if (line.startsWith("create"))
engine.createIndex();
else
engine.search(line, "xml", 1, 10, null, false);
System.out.print("openleg search > ");
}
System.out.println("Exiting Search Engine");
} | #vulnerable code
public static void main(String[] args) throws Exception {
SearchEngine2 engine = new SearchEngine2();
BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
String line = null;
System.out.print("openlegLuceneConsole> ");
while (!(line = reader.readLine()).equals("quit"))
{
if (line.startsWith("index "))
{
String cmd = line.substring(line.indexOf(" ")+1);
StringTokenizer st = new StringTokenizer(cmd);
String iType = st.nextToken();
int start = 1;
int max = 1000000;
int pageSize = 10;
if (st.hasMoreTokens())
start = Integer.parseInt(st.nextToken());
if (st.hasMoreTokens())
max = Integer.parseInt(st.nextToken());
if (st.hasMoreTokens())
pageSize = Integer.parseInt(st.nextToken());
engine.indexSenateData(iType, start, max, pageSize,
new LuceneSerializer[]{new XmlSerializer(), new JsonSerializer()});
}
else if (line.startsWith("optimize"))
engine.optimize();
else if (line.startsWith("delete"))
{
StringTokenizer cmd = new StringTokenizer(line.substring(line.indexOf(" ")+1)," ");
String type = cmd.nextToken();
String id = cmd.nextToken();
engine.deleteSenateObjectById(type, id);
}
else if (line.startsWith("create"))
engine.createIndex();
else
engine.search(line, "xml", 1, 10, null, false);
System.out.print("openleg search > ");
}
System.out.println("Exiting Search Engine");
}
#location 30
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Override
public void init() throws ServletException {
super.init();
String rootPath = this.getServletContext().getRealPath("/");
String encoding = "latin1";//"UTF-8";
try
{
districts = new ArrayList<JSONObject>();
for (int i = 1; i <= 62; i++)
{
String jsonPath = DISTRICT_JSON_FOLDER_PATH + "sd" + i + ".json";
URL jsonUrl = getServletContext().getResource(jsonPath);
//jsonPath = rootPath + '/' + jsonPath;
StringBuilder jsonb = new StringBuilder();
BufferedReader reader = new BufferedReader(new InputStreamReader(jsonUrl.openStream(),encoding));
//BufferedReader reader = new BufferedReader(new InputStreamReader(new FileInputStream(jsonPath), encoding));
char[] buf = new char[1024];
int numRead=0;
while((numRead=reader.read(buf)) != -1){
jsonb.append(buf, 0, numRead);
buf = new char[1024];
}
reader.close();
JSONObject jsono = new JSONObject(jsonb.toString());
JSONObject jSenator = jsono.getJSONObject("senator");
String senatorName = jSenator.getString("name");
jSenator.put("name", senatorName);
String senatorKey = jSenator.getString("url");
senatorKey = senatorKey.substring(senatorKey.lastIndexOf('/')+1);
senatorKey = senatorKey.replace("-jr", "");
senatorKey = senatorKey.replace("-sr", "");
String[] senatorKeyParts =senatorKey.split("-");
if (senatorName.contains("-"))
{
senatorKey = senatorKeyParts[senatorKeyParts.length-2] + '-' + senatorKeyParts[senatorKeyParts.length-1];
}
else
{
senatorKey = senatorKeyParts[senatorKeyParts.length-1];
}
jSenator.put("key", senatorKey);
districts.add(jsono);
logger.info(jsono.get("district"));
logger.info(jsono.getJSONObject("senator").get("name"));
}
Collections.sort(districts, new byLastName());
}
catch (Exception e)
{
logger.error("error loading json district files",e);
}
} | #vulnerable code
@Override
public void init() throws ServletException {
super.init();
try
{
districts = new ArrayList<JSONObject>();
for (int i = 1; i <= 62; i++)
{
String jsonPath = DISTRICT_JSON_FOLDER_PATH + "sd" + i + ".json";
logger.info("loading: " + jsonPath);
InputStream is = getServletContext().getResourceAsStream(jsonPath);
// InputStream is = ClassLoader
//.getSystemResourceAsStream(DISTRICT_JSON_FOLDER_PATH + "sd" + i + ".json");
BufferedReader reader = new BufferedReader(new InputStreamReader(is));
String line = null;
StringBuffer jsonb = new StringBuffer();
while ((line = reader.readLine())!=null)
{
jsonb.append(line);
}
JSONObject jsono = new JSONObject(jsonb.toString());
JSONObject jSenator = jsono.getJSONObject("senator");
String senatorName = jSenator.getString("name");
senatorName = senatorName.replace("�","e");
jSenator.put("name", senatorName);
String senatorKey = jSenator.getString("url");
senatorKey = senatorKey.substring(senatorKey.lastIndexOf('/')+1);
senatorKey = senatorKey.replace("-jr", "");
senatorKey = senatorKey.replace("-sr", "");
String[] senatorKeyParts =senatorKey.split("-");
if (senatorName.contains("-"))
{
senatorKey = senatorKeyParts[senatorKeyParts.length-2] + '-' + senatorKeyParts[senatorKeyParts.length-1];
}
else
{
senatorKey = senatorKeyParts[senatorKeyParts.length-1];
}
jSenator.put("key", senatorKey);
districts.add(jsono);
logger.info(jsono.get("district"));
logger.info(jsono.getJSONObject("senator").get("name"));
}
Collections.sort(districts, new byLastName());
}
catch (Exception e)
{
logger.error("error loading json district files",e);
}
}
#location 69
#vulnerability type RESOURCE_LEAK | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public void handleAPIv1 (String format, String type, String key, int pageIdx, int pageSize, HttpServletRequest req, HttpServletResponse resp)
throws IOException, ServletException {
String urlPath = "/legislation/" + type + "/" + ((key != null && !key.matches("\\s*")) ? key + "/" :"");
if (type.equalsIgnoreCase("sponsor")) {
String filter = req.getParameter("filter");
key = "sponsor:\"" + key + "\"";
if(filter != null) {
req.setAttribute("filter", filter);
key += (filter != null ? " AND " + filter : "");
}
type = "bills";
}
else if (type.equalsIgnoreCase("committee")) {
key = "committee:\"" + key + "\"";
type = "bills";
}
String originalType = type;
String viewPath = "";
String searchString = "";
String sFormat = "json";
String sortField = "when";
boolean sortOrder = true;
if(type != null) {
if(type.contains("bill")) {
sortField = "sortindex";
sortOrder = false;
}
else if(type.contains("meeting")) {
sortField = "sortindex";
}
}
SenateResponse sr = null;
key = key.trim();
if (pageSize > MAX_PAGE_SIZE)
throw new ServletException ("The maximum page size is " + MAX_PAGE_SIZE);
//now calculate start, end idx based on pageIdx and pageSize
int start = (pageIdx - 1) * pageSize;
int end = start + pageSize;
logger.info("request: key=" + key + ";type=" + type + ";format=" + format + ";paging=" + start + "/" + end);
try {
/*
* construct query with "otype:<type>" if type present
*/
if (type != null) {
/*
* for searches
*
* applicable to: bills, calendars, meetings, transcripts, actions, votes
*/
if (type.endsWith("s")) {
type = type.substring(0,type.length()-1);
searchString = "otype:" + type;
if (key != null && key.length() > 0)
searchString += " AND " + key;
}
/*
* for individual documents
*
* applicable to: bill, calendar, meeting, transcript
*/
else {
searchString ="otype:" + type;
if (key != null && key.length() > 0) {
if (type.equals("bill") && key.indexOf("-") == -1)
key += "-" + DEFAULT_SESSION_YEAR;
key = key.replace(" ","+");
searchString += " AND oid:" + key;
}
}
}
else
{
searchString = key;
}
/*
* applicable to: bills
*
* only return bills with "year:<currentSessionYear>"
*/
if(originalType.equals("bills")) {
req.setAttribute("urlPath", urlPath);
searchString = ApiHelper.dateReplace(searchString)
+ " AND year:" + SessionYear.getSessionYear()
+ " AND active:true";
}
/*
* applicable to: calendars, meetings, transcripts
*
* only want current session documents as defined by the time
* frame between DATE_START and DATE_END
*/
else if(originalType.endsWith("s")) {
req.setAttribute("urlPath", urlPath);
searchString = ApiHelper.dateReplace(searchString)
+ " AND when:["
+ DATE_START
+ " TO "
+ DATE_END + "]"
+ " AND active:true";
}
/*
* applicable to: individual documents
*
* attempting to access a document by id doesn't
* doesn't require any special formatting
*/
else {
searchString = ApiHelper.dateReplace(searchString);
}
req.setAttribute("sortField", sortField);
req.setAttribute("sortOrder", Boolean.toString(sortOrder));
req.setAttribute("type", type);
req.setAttribute("term", searchString);
req.setAttribute("format", format);
req.setAttribute("key", key);
req.setAttribute(PAGE_IDX,pageIdx+"");
req.setAttribute(PAGE_SIZE,pageSize+"");
sr = searchEngine.search(searchString,sFormat,start,pageSize,sortField,sortOrder);
logger.info("got search results: " + sr.getResults().size());
if (sr.getResults().size()==0) {
resp.sendError(404);
return;
}
else if (sr.getResults().size()==1 && format.matches("(html(\\-print)?|mobile|lrs\\-print)")) {
Result result = sr.getResults().get(0);
/* if not an exact match on the oid it's likely
* the correct id, just the wrong case */
if (!result.getOid().equals(key)) {
if(format.equals("html"))
resp.sendRedirect("/legislation/"
+ result.getOtype()
+ "/"
+ result.getOid());
else
resp.sendRedirect("/legislation/api/1.0/"
+ format
+ "/"
+ result.getOtype()
+ "/"
+ result.getOid());
return;
}
String jsonData = result.getData();
req.setAttribute("active", result.getActive());
jsonData = jsonData.substring(jsonData.indexOf(":")+1);
jsonData = jsonData.substring(0,jsonData.lastIndexOf("}"));
/* Jackson ObjectMaper will deserialize our json in to an object,
* we need to know what sort of an object that is
*/
String className = "gov.nysenate.openleg.model.bill." + type.substring(0,1).toUpperCase() + type.substring(1);
/*
* for bills we populate other relevant data, such as
* votes, calendars, meetings, sameas bills, older versions, etc.
*/
if (type.equals("bill")) {
String billQueryId = key;
String sessionYear = DEFAULT_SESSION_YEAR;
/* default behavior to maintain previous permalinks
* is if key=S1234 to transform to S1234-2009
* in line with our new bill oid format <billno>-<sessYear> */
String[] billParts = billQueryId.split("-");
billQueryId = billParts[0];
if (billParts.length > 1)
sessionYear = billParts[1];
/* turns S1234A in to S1234 */
String billWildcard = billQueryId;
if (!Character.isDigit(billWildcard.charAt(billWildcard.length()-1)))
billWildcard = billWildcard.substring(0,billWildcard.length()-1);
//get BillEvents for this
//otype:action AND billno:((S1234-2011 OR [S1234A-2011 TO S1234Z-2011) AND S1234*-2011)
String rType = "action";
String rQuery = null;
rQuery = billWildcard + "-" + sessionYear;
logger.info(rQuery);
rQuery = "billno:(("
+ rQuery
+ " OR [" + billWildcard + "A-" + sessionYear
+ " TO " + billWildcard + "Z-" + sessionYear
+ "]) AND " + billWildcard + "*-" + sessionYear + ")";
ArrayList<SearchResult> relatedActions = ApiHelper.getRelatedSenateObjects(rType,rQuery);
Hashtable<String,SearchResult> uniqResults = new Hashtable<String,SearchResult>();
for (SearchResult rResult: relatedActions) {
BillEvent rAction = (BillEvent)rResult.getObject();
uniqResults.put(rAction.getEventDate().toGMTString()+'-'+rResult.getTitle().toUpperCase(), rResult);
}
ArrayList<SearchResult> list = Collections.list(uniqResults.elements());
Collections.sort(list);
req.setAttribute("related-" + rType, list);
//get older bills (e.g. for S1234A get S1234)
//otype:meeting AND oid:((S1234-2011 OR [S1234A-2011 TO S1234Z-2011) AND S1234*-2011)
rType = "bill";
rQuery = billWildcard + "-" + sessionYear;
logger.info(rQuery);
rQuery = "oid:(("
+ rQuery
+ " OR [" + billWildcard + "A-" + sessionYear
+ " TO " + billWildcard + "Z-" + sessionYear
+ "]) AND " + billWildcard + "*-" + sessionYear + ")";
req.setAttribute("related-" + rType, ApiHelper.getRelatedSenateObjects (rType,rQuery));
//get Meetings
//otype:meeting AND bills:"S67005-2011"
rType = "meeting";
rQuery = "bills:\"" + key + "\"";
req.setAttribute("related-" + rType, ApiHelper.getRelatedSenateObjects(rType,rQuery));
//get calendars
//otype:calendar AND bills:"S337A-2011"
rType = "calendar";
rQuery = "bills:\"" + key + "\"";
req.setAttribute("related-" + rType, ApiHelper.getRelatedSenateObjects(rType,rQuery));
//get votes
//otype:vote AND billno:"A11597-2011"
rType = "vote";
rQuery = "billno:\"" + key + "\"";
req.setAttribute("related-" + rType, ApiHelper.getRelatedSenateObjects(rType,rQuery));
}
else if (type.equals("calendar")) {
className = "gov.nysenate.openleg.model.calendar.Calendar";
}
else if (type.equals("meeting")) {
className = "gov.nysenate.openleg.model.committee.Meeting";
}
else if(type.equals("transcript")) {
className = "gov.nysenate.openleg.model.transcript.Transcript";
}
Object resultObj = null;
try {
resultObj = ApiHelper.getMapper().readValue(jsonData, Class.forName(className));
}
catch (Exception e) {
logger.warn("error binding className", e);
}
req.setAttribute(type, resultObj);
viewPath = "/views/" + type + "-" + format + ".jsp";
}
else {
/* all non html/print bill views go here */
if (type.equals("bill") && (!format.equals("html"))) {
viewPath = "/views/bills-" + format + ".jsp";
ArrayList<SearchResult> searchResults = ApiHelper.buildSearchResultList(sr);
ArrayList<Bill> bills = new ArrayList<Bill>();
for (SearchResult result : searchResults) {
bills.add((Bill)result.getObject());
}
req.setAttribute("bills", bills);
}
/* all calendar, meeting, transcript multi views go here */
else
{
viewPath = "/views/" + "search" + "-" + format + ".jsp";
SearchResultSet srs = new SearchResultSet();
srs.setTotalHitCount((Integer)sr.getMetadata().get("totalresults"));
srs.setResults(ApiHelper.buildSearchResultList(sr));
req.setAttribute("results", srs);
}
}
}
catch (Exception e) {
logger.warn("search controller didn't work for: " + req.getRequestURI(),e);
e.printStackTrace();
}
try {
logger.info("routing to search controller:" + viewPath);
getServletContext().getRequestDispatcher(viewPath).forward(req, resp);
}
catch (Exception e) {
logger.warn("search controller didn't work for: " + req.getRequestURI(),e);
}
} | #vulnerable code
public void handleAPIv1 (String format, String type, String key, int pageIdx, int pageSize, HttpServletRequest req, HttpServletResponse resp)
throws IOException, ServletException {
String viewPath = "";
String searchString = "";
String originalType = type;
String sFormat = "json";
String sortField = "when";
boolean sortOrder = true;
if(type != null) {
if(type.contains("bill")) {
sortField = "sortindex";
sortOrder = false;
}
else if(type.contains("meeting")) {
sortField = "sortindex";
}
}
SenateResponse sr = null;
if (type.equalsIgnoreCase("sponsor")) {
String filter = req.getParameter("filter");
key = "sponsor:\"" + key + (filter != null ? " AND " + filter : "");
type = "bills";
}
else if (type.equalsIgnoreCase("committee")) {
key = "committee:\"" + key + "\" AND oid:s*-" + SessionYear.getSessionYear();
type = "bills";
}
key = key.trim();
if (pageSize > MAX_PAGE_SIZE)
throw new ServletException ("The maximum page size is " + MAX_PAGE_SIZE);
//now calculate start, end idx based on pageIdx and pageSize
int start = (pageIdx - 1) * pageSize;
int end = start + pageSize;
logger.info("request: key=" + key + ";type=" + type + ";format=" + format + ";paging=" + start + "/" + end);
try {
/*
* construct query with "otype:<type>" if type present
*/
if (type != null) {
/*
* for searches
*
* applicable to: bills, calendars, meetings, transcripts, actions, votes
*/
if (type.endsWith("s")) {
type = type.substring(0,type.length()-1);
searchString = "otype:" + type;
if (key != null && key.length() > 0)
searchString += " AND " + key;
}
/*
* for individual documents
*
* applicable to: bill, calendar, meeting, transcript
*/
else {
searchString ="otype:" + type;
if (key != null && key.length() > 0) {
if (type.equals("bill") && key.indexOf("-") == -1)
key += "-" + DEFAULT_SESSION_YEAR;
key = key.replace(" ","+");
searchString += " AND oid:" + key;
}
}
}
else
{
searchString = key;
}
req.setAttribute("sortField", sortField);
req.setAttribute("sortOrder", Boolean.toString(sortOrder));
req.setAttribute("type", type);
req.setAttribute("term", searchString);
req.setAttribute("format", format);
req.setAttribute("key", key);
req.setAttribute(PAGE_IDX,pageIdx+"");
req.setAttribute(PAGE_SIZE,pageSize+"");
/*
* applicable to: bills
*
* only return bills with "year:<currentSessionYear>"
*/
if(originalType.equals("bills")) {
sr = searchEngine.search(ApiHelper.dateReplace(searchString)
+ " AND year:" + SessionYear.getSessionYear()
+ " AND active:true",
sFormat,start,pageSize,sortField,sortOrder);
}
/*
* applicable to: calendars, meetings, transcripts
*
* only want current session documents as defined by the time
* frame between DATE_START and DATE_END
*/
else if(originalType.endsWith("s")) {
sr = searchEngine.search(ApiHelper.dateReplace(searchString)
+ " AND when:["
+ DATE_START
+ " TO "
+ DATE_END + "]"
+ " AND active:true",
sFormat,start,pageSize,sortField,sortOrder);
}
/*
* applicable to: individual documents
*
* attempting to access a document by id doesn't
* doesn't require any special formatting
*/
else {
sr = searchEngine.search(ApiHelper.dateReplace(searchString),sFormat,start,pageSize,sortField,sortOrder);
}
logger.info("got search results: " + sr.getResults().size());
if (sr.getResults().size()==0) {
resp.sendError(404);
return;
}
else if (sr.getResults().size()==1 && format.matches("(html(\\-print)?|mobile|lrs\\-print)")) {
Result result = sr.getResults().get(0);
/* if not an exact match on the oid it's likely
* the correct id, just the wrong case */
if (!result.getOid().equals(key)) {
if(format.equals("html"))
resp.sendRedirect("/legislation/"
+ result.getOtype()
+ "/"
+ result.getOid());
else
resp.sendRedirect("/legislation/api/1.0/"
+ format
+ "/"
+ result.getOtype()
+ "/"
+ result.getOid());
return;
}
String jsonData = result.getData();
req.setAttribute("active", result.getActive());
jsonData = jsonData.substring(jsonData.indexOf(":")+1);
jsonData = jsonData.substring(0,jsonData.lastIndexOf("}"));
/* Jackson ObjectMaper will deserialize our json in to an object,
* we need to know what sort of an object that is
*/
String className = "gov.nysenate.openleg.model.bill." + type.substring(0,1).toUpperCase() + type.substring(1);
/*
* for bills we populate other relevant data, such as
* votes, calendars, meetings, sameas bills, older versions, etc.
*/
if (type.equals("bill")) {
String billQueryId = key;
String sessionYear = DEFAULT_SESSION_YEAR;
/* default behavior to maintain previous permalinks
* is if key=S1234 to transform to S1234-2009
* in line with our new bill oid format <billno>-<sessYear> */
String[] billParts = billQueryId.split("-");
billQueryId = billParts[0];
if (billParts.length > 1)
sessionYear = billParts[1];
/* turns S1234A in to S1234 */
String billWildcard = billQueryId;
if (!Character.isDigit(billWildcard.charAt(billWildcard.length()-1)))
billWildcard = billWildcard.substring(0,billWildcard.length()-1);
//get BillEvents for this
//otype:action AND billno:((S1234-2011 OR [S1234A-2011 TO S1234Z-2011) AND S1234*-2011)
String rType = "action";
String rQuery = null;
rQuery = billWildcard + "-" + sessionYear;
logger.info(rQuery);
rQuery = "billno:(("
+ rQuery
+ " OR [" + billWildcard + "A-" + sessionYear
+ " TO " + billWildcard + "Z-" + sessionYear
+ "]) AND " + billWildcard + "*-" + sessionYear + ")";
ArrayList<SearchResult> relatedActions = ApiHelper.getRelatedSenateObjects(rType,rQuery);
Hashtable<String,SearchResult> uniqResults = new Hashtable<String,SearchResult>();
for (SearchResult rResult: relatedActions) {
BillEvent rAction = (BillEvent)rResult.getObject();
uniqResults.put(rAction.getEventDate().toGMTString()+'-'+rResult.getTitle().toUpperCase(), rResult);
}
ArrayList<SearchResult> list = Collections.list(uniqResults.elements());
Collections.sort(list);
req.setAttribute("related-" + rType, list);
//get older bills (e.g. for S1234A get S1234)
//otype:meeting AND oid:((S1234-2011 OR [S1234A-2011 TO S1234Z-2011) AND S1234*-2011)
rType = "bill";
rQuery = billWildcard + "-" + sessionYear;
logger.info(rQuery);
rQuery = "oid:(("
+ rQuery
+ " OR [" + billWildcard + "A-" + sessionYear
+ " TO " + billWildcard + "Z-" + sessionYear
+ "]) AND " + billWildcard + "*-" + sessionYear + ")";
req.setAttribute("related-" + rType, ApiHelper.getRelatedSenateObjects (rType,rQuery));
//get Meetings
//otype:meeting AND bills:"S67005-2011"
rType = "meeting";
rQuery = "bills:\"" + key + "\"";
req.setAttribute("related-" + rType, ApiHelper.getRelatedSenateObjects(rType,rQuery));
//get calendars
//otype:calendar AND bills:"S337A-2011"
rType = "calendar";
rQuery = "bills:\"" + key + "\"";
req.setAttribute("related-" + rType, ApiHelper.getRelatedSenateObjects(rType,rQuery));
//get votes
//otype:vote AND billno:"A11597-2011"
rType = "vote";
rQuery = "billno:\"" + key + "\"";
req.setAttribute("related-" + rType, ApiHelper.getRelatedSenateObjects(rType,rQuery));
}
else if (type.equals("calendar")) {
className = "gov.nysenate.openleg.model.calendar.Calendar";
}
else if (type.equals("meeting")) {
className = "gov.nysenate.openleg.model.committee.Meeting";
}
else if(type.equals("transcript")) {
className = "gov.nysenate.openleg.model.transcript.Transcript";
}
Object resultObj = null;
try {
resultObj = ApiHelper.getMapper().readValue(jsonData, Class.forName(className));
}
catch (Exception e) {
logger.warn("error binding className", e);
}
req.setAttribute(type, resultObj);
viewPath = "/views/" + type + "-" + format + ".jsp";
}
else {
/* all non html/print bill views go here */
if (type.equals("bill") && (!format.equals("html"))) {
viewPath = "/views/bills-" + format + ".jsp";
ArrayList<SearchResult> searchResults = ApiHelper.buildSearchResultList(sr);
ArrayList<Bill> bills = new ArrayList<Bill>();
for (SearchResult result : searchResults) {
bills.add((Bill)result.getObject());
}
req.setAttribute("bills", bills);
}
/* all calendar, meeting, transcript multi views go here */
else
{
viewPath = "/views/" + "search" + "-" + format + ".jsp";
SearchResultSet srs = new SearchResultSet();
srs.setTotalHitCount((Integer)sr.getMetadata().get("totalresults"));
srs.setResults(ApiHelper.buildSearchResultList(sr));
req.setAttribute("results", srs);
}
}
}
catch (Exception e) {
logger.warn("search controller didn't work for: " + req.getRequestURI(),e);
e.printStackTrace();
}
try {
logger.info("routing to search controller:" + viewPath);
getServletContext().getRequestDispatcher(viewPath).forward(req, resp);
}
catch (Exception e) {
logger.warn("search controller didn't work for: " + req.getRequestURI(),e);
}
}
#location 293
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public void doPost(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {
if (request.getParameter("reset")!=null)
searchEngine.closeSearcher();
String search = request.getParameter("search");
String term = request.getParameter("term");
String type = request.getParameter("type");
String full = request.getParameter("full");
String memo = request.getParameter("memo");
String status = request.getParameter("status");
String sponsor = request.getParameter("sponsor");
String cosponsors = request.getParameter("cosponsors");
String sameas = request.getParameter("sameas");
String committee = request.getParameter("committee");
String location = request.getParameter("location");
String session = request.getParameter("session");
if(search != null) {
request.setAttribute("search", search);
term = search;
}
String tempTerm = null;
if((tempTerm = BillCleaner.getDesiredBillNumber(term)) != null) {
term = "oid:" + tempTerm;
type = "bill";
System.out.println("!! " + tempTerm);
}
String sortField = request.getParameter("sort");
boolean sortOrder = false;
if (request.getParameter("sortOrder")!=null)
sortOrder = Boolean.parseBoolean(request.getParameter("sortOrder"));
Date startDate = null;
Date endDate = null;
try {
if (request.getParameter("startdate")!=null && (!request.getParameter("startdate").equals("mm/dd/yyyy")))
startDate = OL_SEARCH_DATE_FORMAT.parse(request.getParameter("startdate"));
} catch (java.text.ParseException e1) {
logger.warn(e1);
}
try {
if (request.getParameter("enddate")!=null && (!request.getParameter("enddate").equals("mm/dd/yyyy"))) {
endDate = OL_SEARCH_DATE_FORMAT.parse(request.getParameter("enddate"));
Calendar cal = Calendar.getInstance();
cal.setTime(endDate);
cal.set(Calendar.HOUR, 11);
cal.set(Calendar.MINUTE, 59);
cal.set(Calendar.SECOND, 59);
endDate = cal.getTime();
}
} catch (java.text.ParseException e1) {
logger.warn(e1);
}
String format = "html";
if (request.getParameter("format")!=null)
format = request.getParameter("format");
int pageIdx = 1;
int pageSize = 20;
if (request.getParameter("pageIdx") != null)
pageIdx = Integer.parseInt(request.getParameter("pageIdx"));
if (request.getParameter("pageSize") != null)
pageSize = Integer.parseInt(request.getParameter("pageSize"));
//now calculate start, end idx based on pageIdx and pageSize
int start = (pageIdx - 1) * pageSize;
SearchResultSet srs;
StringBuilder searchText = new StringBuilder();
if (term != null)
searchText.append(term);
try {
if (type != null && type.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("otype:");
searchText.append(type.equals("res") ? "bill AND oid:r*":type);
}
if(session != null && session.length() > 0) {
if(searchText.length() > 0)
searchText.append(" AND ");
searchText.append("year:" + session);
}
if (full != null && full.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("(full:\"");
searchText.append(full);
searchText.append("\"");
searchText.append(" OR ");
searchText.append("osearch:\"");
searchText.append(full);
searchText.append("\")");
}
if (memo != null && memo.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("memo:\"");
searchText.append(memo);
searchText.append("\"");
}
if (status != null && status.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("status:\"");
searchText.append(status);
searchText.append("\"");
}
if (sponsor != null && sponsor.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("sponsor:\"");
searchText.append(sponsor);
searchText.append("\"");
}
if (cosponsors != null && cosponsors.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("cosponsors:\"");
searchText.append(cosponsors);
searchText.append("\"");
}
if (sameas != null && sameas.length() > 0)
{
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("sameas:");
searchText.append(sameas);
}
if (committee != null && committee.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("committee:\"");
searchText.append(committee);
searchText.append("\"");
}
if (location != null && location.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("location:\"");
searchText.append(location);
searchText.append("\"");
}
if (startDate != null && endDate != null) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("when:[");
searchText.append(startDate.getTime());
searchText.append(" TO ");
searchText.append(endDate.getTime());
searchText.append("]");
}
else if (startDate != null) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("when:[");
searchText.append(startDate.getTime());
searchText.append(" TO ");
Calendar cal = Calendar.getInstance();
cal.setTime(startDate);
cal.set(Calendar.HOUR, 23);
cal.set(Calendar.MINUTE, 59);
cal.set(Calendar.SECOND, 59);
startDate = cal.getTime();
searchText.append(startDate.getTime());
searchText.append("]");
}
term = searchText.toString();
term = BillCleaner.billFormat(term);
request.setAttribute("term", term);
request.setAttribute("type", type);
//default behavior is to return only active bills, so if a user searches
//s1234 and s1234a is available then s1234a should be returned
if(sortField == null && (((search != null && search.contains("otype:bill"))
|| (term != null && term.contains("otype:bill")))
|| (type != null && type.equals("bill")))) {
sortField = "sortindex";
sortOrder = false;
type = "bill";
}
if (sortField!=null && !sortField.equals("")) {
request.setAttribute("sortField", sortField);
request.setAttribute("sortOrder",Boolean.toString(sortOrder));
}
else {
sortField = "when";
sortOrder = true;
request.setAttribute("sortField", sortField);
request.setAttribute("sortOrder", Boolean.toString(sortOrder));
}
request.setAttribute(OpenLegConstants.PAGE_IDX,pageIdx+"");
request.setAttribute(OpenLegConstants.PAGE_SIZE,pageSize+"");
srs = null;
if (term.length() == 0) {
response.sendError(404);
return;
}
String searchFormat = "json";
SenateResponse sr = null;
if(term != null && !term.contains("year:") && !term.contains("when:") && !term.contains("oid:")) {
if(type != null && type.equals("bill")) {
sr = searchEngine.search(term + " AND year:" + SessionYear.getSessionYear(),searchFormat,start,pageSize,sortField,sortOrder);
}
else {
sr = searchEngine.search(term + " AND when:[" + DATE_START + " TO " + DATE_END + "]",searchFormat,start,pageSize,sortField,sortOrder);
if(sr.getResults().isEmpty()) {
sr = searchEngine.search(term + " AND year:" + SessionYear.getSessionYear(),searchFormat,start,pageSize,sortField,sortOrder);
}
}
}
else {
System.out.println("!!! " + term);
sr = searchEngine.search(term,searchFormat,start,pageSize,sortField,sortOrder);
}
srs = new SearchResultSet();
srs.setTotalHitCount((Integer)sr.getMetadata().get("totalresults"));
srs.setResults(ApiHelper.buildSearchResultList(sr));
if (srs != null) {
if (srs.getResults().size() == 0) {
response.sendError(404);
}
else {
request.setAttribute("results", srs);
String viewPath = "/views/search-" + format + DOT_JSP;
getServletContext().getRequestDispatcher(viewPath).forward(request, response);
}
}
else {
logger.error("Search Error: " + request.getRequestURI());
response.sendError(500);
}
} catch (Exception e) {
logger.error("Search Error: " + request.getRequestURI(),e);
e.printStackTrace();
response.sendError(500);
}
} | #vulnerable code
public void doPost(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {
if (request.getParameter("reset")!=null)
searchEngine.closeSearcher();
String search = request.getParameter("search");
String term = request.getParameter("term");
String type = request.getParameter("type");
String full = request.getParameter("full");
String memo = request.getParameter("memo");
String status = request.getParameter("status");
String sponsor = request.getParameter("sponsor");
String cosponsors = request.getParameter("cosponsors");
String sameas = request.getParameter("sameas");
String committee = request.getParameter("committee");
String location = request.getParameter("location");
String session = request.getParameter("session");
if(search != null) {
request.setAttribute("search", search);
term = search;
}
String tempTerm = null;
if((tempTerm = BillCleaner.getDesiredBillNumber(term)) != null) {
term = "oid:" + tempTerm;
type = "bill";
}
String sortField = request.getParameter("sort");
boolean sortOrder = false;
if (request.getParameter("sortOrder")!=null)
sortOrder = Boolean.parseBoolean(request.getParameter("sortOrder"));
Date startDate = null;
Date endDate = null;
try {
if (request.getParameter("startdate")!=null && (!request.getParameter("startdate").equals("mm/dd/yyyy")))
startDate = OL_SEARCH_DATE_FORMAT.parse(request.getParameter("startdate"));
} catch (java.text.ParseException e1) {
logger.warn(e1);
}
try {
if (request.getParameter("enddate")!=null && (!request.getParameter("enddate").equals("mm/dd/yyyy"))) {
endDate = OL_SEARCH_DATE_FORMAT.parse(request.getParameter("enddate"));
Calendar cal = Calendar.getInstance();
cal.setTime(endDate);
cal.set(Calendar.HOUR, 11);
cal.set(Calendar.MINUTE, 59);
cal.set(Calendar.SECOND, 59);
endDate = cal.getTime();
}
} catch (java.text.ParseException e1) {
logger.warn(e1);
}
String format = "html";
if (request.getParameter("format")!=null)
format = request.getParameter("format");
int pageIdx = 1;
int pageSize = 20;
if (request.getParameter("pageIdx") != null)
pageIdx = Integer.parseInt(request.getParameter("pageIdx"));
if (request.getParameter("pageSize") != null)
pageSize = Integer.parseInt(request.getParameter("pageSize"));
//now calculate start, end idx based on pageIdx and pageSize
int start = (pageIdx - 1) * pageSize;
SearchResultSet srs;
StringBuilder searchText = new StringBuilder();
if (term != null)
searchText.append(term);
try {
if (type != null && type.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("otype:");
searchText.append(type.equals("res") ? "bill AND oid:r*":type);
}
if(session != null && session.length() > 0) {
if(searchText.length() > 0)
searchText.append(" AND ");
searchText.append("year:" + session);
}
if (full != null && full.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("(full:\"");
searchText.append(full);
searchText.append("\"");
searchText.append(" OR ");
searchText.append("osearch:\"");
searchText.append(full);
searchText.append("\")");
}
if (memo != null && memo.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("memo:\"");
searchText.append(memo);
searchText.append("\"");
}
if (status != null && status.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("status:\"");
searchText.append(status);
searchText.append("\"");
}
if (sponsor != null && sponsor.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("sponsor:\"");
searchText.append(sponsor);
searchText.append("\"");
}
if (cosponsors != null && cosponsors.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("cosponsors:\"");
searchText.append(cosponsors);
searchText.append("\"");
}
if (sameas != null && sameas.length() > 0)
{
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("sameas:");
searchText.append(sameas);
}
if (committee != null && committee.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("committee:\"");
searchText.append(committee);
searchText.append("\"");
}
if (location != null && location.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("location:\"");
searchText.append(location);
searchText.append("\"");
}
if (startDate != null && endDate != null) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("when:[");
searchText.append(startDate.getTime());
searchText.append(" TO ");
searchText.append(endDate.getTime());
searchText.append("]");
}
else if (startDate != null) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("when:[");
searchText.append(startDate.getTime());
searchText.append(" TO ");
Calendar cal = Calendar.getInstance();
cal.setTime(startDate);
cal.set(Calendar.HOUR, 23);
cal.set(Calendar.MINUTE, 59);
cal.set(Calendar.SECOND, 59);
startDate = cal.getTime();
searchText.append(startDate.getTime());
searchText.append("]");
}
term = searchText.toString();
term = BillCleaner.billFormat(term);
request.setAttribute("term", term);
request.setAttribute("type", type);
//default behavior is to return only active bills, so if a user searches
//s1234 and s1234a is available then s1234a should be returned
if(sortField == null && (((search != null && search.contains("otype:bill"))
|| (term != null && term.contains("otype:bill")))
|| (type != null && type.equals("bill")))) {
sortField = "sortindex";
sortOrder = false;
type = "bill";
}
if (sortField!=null && !sortField.equals("")) {
request.setAttribute("sortField", sortField);
request.setAttribute("sortOrder",Boolean.toString(sortOrder));
}
else {
sortField = "when";
sortOrder = true;
request.setAttribute("sortField", sortField);
request.setAttribute("sortOrder", Boolean.toString(sortOrder));
}
request.setAttribute(OpenLegConstants.PAGE_IDX,pageIdx+"");
request.setAttribute(OpenLegConstants.PAGE_SIZE,pageSize+"");
srs = null;
if (term.length() == 0) {
response.sendError(404);
return;
}
String searchFormat = "json";
SenateResponse sr = null;
if(term != null && !term.contains("year:") && !term.contains("when:") && !term.contains("oid:")) {
if(type != null && type.equals("bill")) {
sr = searchEngine.search(term + " AND year:" + SessionYear.getSessionYear(),searchFormat,start,pageSize,sortField,sortOrder);
}
else {
sr = searchEngine.search(term + " AND when:[" + DATE_START + " TO " + DATE_END + "]",searchFormat,start,pageSize,sortField,sortOrder);
if(sr.getResults().isEmpty()) {
sr = searchEngine.search(term + " AND year:" + SessionYear.getSessionYear(),searchFormat,start,pageSize,sortField,sortOrder);
}
}
}
else {
sr = searchEngine.search(term,searchFormat,start,pageSize,sortField,sortOrder);
}
srs = new SearchResultSet();
srs.setTotalHitCount((Integer)sr.getMetadata().get("totalresults"));
srs.setResults(ApiHelper.buildSearchResultList(sr));
if (srs != null) {
if (srs.getResults().size() == 0) {
response.sendError(404);
}
else {
request.setAttribute("results", srs);
String viewPath = "/views/search-" + format + DOT_JSP;
getServletContext().getRequestDispatcher(viewPath).forward(request, response);
}
}
else {
logger.error("Search Error: " + request.getRequestURI());
response.sendError(500);
}
} catch (Exception e) {
logger.error("Search Error: " + request.getRequestURI(),e);
e.printStackTrace();
response.sendError(500);
}
}
#location 270
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public void doPost(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {
if (request.getParameter("reset")!=null)
searchEngine.closeSearcher();
String search = request.getParameter("search");
String term = request.getParameter("term");
String type = request.getParameter("type");
String full = request.getParameter("full");
String memo = request.getParameter("memo");
String status = request.getParameter("status");
String sponsor = request.getParameter("sponsor");
String cosponsors = request.getParameter("cosponsors");
String sameas = request.getParameter("sameas");
String committee = request.getParameter("committee");
String location = request.getParameter("location");
String session = request.getParameter("session");
if(search != null) {
request.setAttribute("search", search);
term = search;
}
String tempTerm = null;
if((tempTerm = BillCleaner.getDesiredBillNumber(term)) != null) {
term = "oid:" + tempTerm;
type = "bill";
}
String sortField = request.getParameter("sort");
boolean sortOrder = false;
if (request.getParameter("sortOrder")!=null)
sortOrder = Boolean.parseBoolean(request.getParameter("sortOrder"));
Date startDate = null;
Date endDate = null;
try {
if (request.getParameter("startdate")!=null && (!request.getParameter("startdate").equals("mm/dd/yyyy")))
startDate = OL_SEARCH_DATE_FORMAT.parse(request.getParameter("startdate"));
} catch (java.text.ParseException e1) {
logger.warn(e1);
}
try {
if (request.getParameter("enddate")!=null && (!request.getParameter("enddate").equals("mm/dd/yyyy"))) {
endDate = OL_SEARCH_DATE_FORMAT.parse(request.getParameter("enddate"));
Calendar cal = Calendar.getInstance();
cal.setTime(endDate);
cal.set(Calendar.HOUR, 11);
cal.set(Calendar.MINUTE, 59);
cal.set(Calendar.SECOND, 59);
endDate = cal.getTime();
}
} catch (java.text.ParseException e1) {
logger.warn(e1);
}
String format = "html";
if (request.getParameter("format")!=null)
format = request.getParameter("format");
int pageIdx = 1;
int pageSize = 20;
if (request.getParameter("pageIdx") != null)
pageIdx = Integer.parseInt(request.getParameter("pageIdx"));
if (request.getParameter("pageSize") != null)
pageSize = Integer.parseInt(request.getParameter("pageSize"));
//now calculate start, end idx based on pageIdx and pageSize
int start = (pageIdx - 1) * pageSize;
SearchResultSet srs;
StringBuilder searchText = new StringBuilder();
if (term != null)
searchText.append(term);
try {
if (type != null && type.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("otype:");
searchText.append(type.equals("res") ? "bill AND oid:r*":type);
}
if(session != null && session.length() > 0) {
if(searchText.length() > 0)
searchText.append(" AND ");
searchText.append("year:" + session);
}
if (full != null && full.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("(full:\"");
searchText.append(full);
searchText.append("\"");
searchText.append(" OR ");
searchText.append("osearch:\"");
searchText.append(full);
searchText.append("\")");
}
if (memo != null && memo.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("memo:\"");
searchText.append(memo);
searchText.append("\"");
}
if (status != null && status.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("status:\"");
searchText.append(status);
searchText.append("\"");
}
if (sponsor != null && sponsor.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("sponsor:\"");
searchText.append(sponsor);
searchText.append("\"");
}
if (cosponsors != null && cosponsors.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("cosponsors:\"");
searchText.append(cosponsors);
searchText.append("\"");
}
if (sameas != null && sameas.length() > 0)
{
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("sameas:");
searchText.append(sameas);
}
if (committee != null && committee.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("committee:\"");
searchText.append(committee);
searchText.append("\"");
}
if (location != null && location.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("location:\"");
searchText.append(location);
searchText.append("\"");
}
if (startDate != null && endDate != null) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("when:[");
searchText.append(startDate.getTime());
searchText.append(" TO ");
searchText.append(endDate.getTime());
searchText.append("]");
}
else if (startDate != null) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("when:[");
searchText.append(startDate.getTime());
searchText.append(" TO ");
Calendar cal = Calendar.getInstance();
cal.setTime(startDate);
cal.set(Calendar.HOUR, 23);
cal.set(Calendar.MINUTE, 59);
cal.set(Calendar.SECOND, 59);
startDate = cal.getTime();
searchText.append(startDate.getTime());
searchText.append("]");
}
if (sortField!=null && !sortField.equals("")) {
request.setAttribute("sortField", sortField);
request.setAttribute("sortOrder",Boolean.toString(sortOrder));
}
else {
sortField = "when";
sortOrder = true;
request.setAttribute("sortField", sortField);
request.setAttribute("sortOrder", Boolean.toString(sortOrder));
}
term = searchText.toString();
term = BillCleaner.billFormat(term);
request.setAttribute("term", term);
request.setAttribute("type", type);
//default behavior is to return only active bills, so if a user searches
//s1234 and s1234a is available then s1234a should be returned
if((search == null &&
(term != null && term.contains("otype:bill")))
|| (type != null && type.equals("bill"))) {
if(sortField == null) {
sortField = "sortindex";
sortOrder = false;
term += " AND active:true";
type = "bill";
}
}
request.setAttribute(OpenLegConstants.PAGE_IDX,pageIdx+"");
request.setAttribute(OpenLegConstants.PAGE_SIZE,pageSize+"");
srs = null;
if (term.length() == 0) {
response.sendError(404);
return;
}
String searchFormat = "json";
SenateResponse sr = null;
if(term != null && !term.contains("year:") && !term.contains("when:") && !term.contains("oid:")) {
if(type != null && type.equals("bill")) {
sr = searchEngine.search(term + " AND year:" + SessionYear.getSessionYear(),searchFormat,start,pageSize,sortField,sortOrder);
}
else {
sr = searchEngine.search(term + " AND when:[" + DATE_START + " TO " + DATE_END + "]",searchFormat,start,pageSize,sortField,sortOrder);
if(sr.getResults().isEmpty()) {
sr = searchEngine.search(term + " AND year:" + SessionYear.getSessionYear(),searchFormat,start,pageSize,sortField,sortOrder);
}
}
}
else {
sr = searchEngine.search(term,searchFormat,start,pageSize,sortField,sortOrder);
}
srs = new SearchResultSet();
srs.setTotalHitCount((Integer)sr.getMetadata().get("totalresults"));
srs.setResults(ApiHelper.buildSearchResultList(sr));
if (srs != null) {
if (srs.getResults().size() == 0) {
response.sendError(404);
}
else {
request.setAttribute("results", srs);
String viewPath = "/views/search-" + format + DOT_JSP;
getServletContext().getRequestDispatcher(viewPath).forward(request, response);
}
}
else {
logger.error("Search Error: " + request.getRequestURI());
response.sendError(500);
}
} catch (Exception e) {
logger.error("Search Error: " + request.getRequestURI(),e);
e.printStackTrace();
response.sendError(500);
}
} | #vulnerable code
public void doPost(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {
if (request.getParameter("reset")!=null)
searchEngine.closeSearcher();
String search = request.getParameter("search");
String term = request.getParameter("term");
String type = request.getParameter("type");
String full = request.getParameter("full");
String memo = request.getParameter("memo");
String status = request.getParameter("status");
String sponsor = request.getParameter("sponsor");
String cosponsors = request.getParameter("cosponsors");
String sameas = request.getParameter("sameas");
String committee = request.getParameter("committee");
String location = request.getParameter("location");
String session = request.getParameter("session");
if(search != null) {
request.setAttribute("search", search);
term = search;
}
String tempTerm = null;
if((tempTerm = BillCleaner.getDesiredBillNumber(term)) != null) {
term = "oid:" + tempTerm;
type = "bill";
}
String sortField = request.getParameter("sort");
boolean sortOrder = false;
if (request.getParameter("sortOrder")!=null)
sortOrder = Boolean.parseBoolean(request.getParameter("sortOrder"));
Date startDate = null;
Date endDate = null;
try {
if (request.getParameter("startdate")!=null && (!request.getParameter("startdate").equals("mm/dd/yyyy")))
startDate = OL_SEARCH_DATE_FORMAT.parse(request.getParameter("startdate"));
} catch (java.text.ParseException e1) {
logger.warn(e1);
}
try {
if (request.getParameter("enddate")!=null && (!request.getParameter("enddate").equals("mm/dd/yyyy"))) {
endDate = OL_SEARCH_DATE_FORMAT.parse(request.getParameter("enddate"));
Calendar cal = Calendar.getInstance();
cal.setTime(endDate);
cal.set(Calendar.HOUR, 11);
cal.set(Calendar.MINUTE, 59);
cal.set(Calendar.SECOND, 59);
endDate = cal.getTime();
}
} catch (java.text.ParseException e1) {
logger.warn(e1);
}
String format = "html";
if (request.getParameter("format")!=null)
format = request.getParameter("format");
int pageIdx = 1;
int pageSize = 20;
if (request.getParameter("pageIdx") != null)
pageIdx = Integer.parseInt(request.getParameter("pageIdx"));
if (request.getParameter("pageSize") != null)
pageSize = Integer.parseInt(request.getParameter("pageSize"));
//now calculate start, end idx based on pageIdx and pageSize
int start = (pageIdx - 1) * pageSize;
SearchResultSet srs;
StringBuilder searchText = new StringBuilder();
if (term != null)
searchText.append(term);
try {
if (type != null && type.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("otype:");
searchText.append(type.equals("res") ? "bill AND oid:r*":type);
}
if(session != null && session.length() > 0) {
if(searchText.length() > 0)
searchText.append(" AND ");
searchText.append("year:" + session);
}
if (full != null && full.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("(full:\"");
searchText.append(full);
searchText.append("\"");
searchText.append(" OR ");
searchText.append("osearch:\"");
searchText.append(full);
searchText.append("\")");
}
if (memo != null && memo.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("memo:\"");
searchText.append(memo);
searchText.append("\"");
}
if (status != null && status.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("status:\"");
searchText.append(status);
searchText.append("\"");
}
if (sponsor != null && sponsor.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("sponsor:\"");
searchText.append(sponsor);
searchText.append("\"");
}
if (cosponsors != null && cosponsors.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("cosponsors:\"");
searchText.append(cosponsors);
searchText.append("\"");
}
if (sameas != null && sameas.length() > 0)
{
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("sameas:");
searchText.append(sameas);
}
if (committee != null && committee.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("committee:\"");
searchText.append(committee);
searchText.append("\"");
}
if (location != null && location.length() > 0) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("location:\"");
searchText.append(location);
searchText.append("\"");
}
if (startDate != null && endDate != null) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("when:[");
searchText.append(startDate.getTime());
searchText.append(" TO ");
searchText.append(endDate.getTime());
searchText.append("]");
}
else if (startDate != null) {
if (searchText.length()>0)
searchText.append(" AND ");
searchText.append("when:[");
searchText.append(startDate.getTime());
searchText.append(" TO ");
Calendar cal = Calendar.getInstance();
cal.setTime(startDate);
cal.set(Calendar.HOUR, 23);
cal.set(Calendar.MINUTE, 59);
cal.set(Calendar.SECOND, 59);
startDate = cal.getTime();
searchText.append(startDate.getTime());
searchText.append("]");
}
if (sortField!=null && !sortField.equals("")) {
request.setAttribute("sortField", sortField);
request.setAttribute("sortOrder",Boolean.toString(sortOrder));
}
else {
sortField = type != null && type.equals("bill") ? "sortindex":"when";
sortOrder = type != null && type.equals("bill") ? false:true;
request.setAttribute("sortField", sortField);
request.setAttribute("sortOrder", Boolean.toString(sortOrder));
}
term = searchText.toString();
term = BillCleaner.billFormat(term);
request.setAttribute("term", term);
request.setAttribute("type", type);
request.setAttribute(OpenLegConstants.PAGE_IDX,pageIdx+"");
request.setAttribute(OpenLegConstants.PAGE_SIZE,pageSize+"");
//default behavior is to return only active bills, so if a user searches
//s1234 and s1234a is available then s1234a should be returned
if(search == null && term != null && term.contains("otype:bill")) {
term += " AND active:true";
type = "bill";
}
srs = null;
if (term.length() == 0) {
response.sendError(404);
return;
}
String searchFormat = "json";
SenateResponse sr = null;
if(term != null && !term.contains("year:") && !term.contains("when:") && !term.contains("oid:")) {
if(type != null && type.equals("bill")) {
sr = searchEngine.search(term + " AND year:" + SessionYear.getSessionYear(),searchFormat,start,pageSize,sortField,sortOrder);
}
else {
sr = searchEngine.search(term + " AND when:[" + DATE_START + " TO " + DATE_END + "]",searchFormat,start,pageSize,sortField,sortOrder);
if(sr.getResults().isEmpty()) {
sr = searchEngine.search(term + " AND year:" + SessionYear.getSessionYear(),searchFormat,start,pageSize,sortField,sortOrder);
}
}
}
else {
sr = searchEngine.search(term,searchFormat,start,pageSize,sortField,sortOrder);
}
srs = new SearchResultSet();
srs.setTotalHitCount((Integer)sr.getMetadata().get("totalresults"));
srs.setResults(ApiHelper.buildSearchResultList(sr));
if (srs != null) {
if (srs.getResults().size() == 0) {
response.sendError(404);
}
else {
request.setAttribute("results", srs);
String viewPath = "/views/search-" + format + DOT_JSP;
getServletContext().getRequestDispatcher(viewPath).forward(request, response);
}
}
else {
logger.error("Search Error: " + request.getRequestURI());
response.sendError(500);
}
} catch (Exception e) {
logger.error("Search Error: " + request.getRequestURI(),e);
response.sendError(500);
}
}
#location 29
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public static void main(String[] args) throws IOException, org.apache.lucene.queryParser.ParseException, InterruptedException {
TreeSet<String> set = new TreeSet<String>();
set.addAll(Arrays.asList("summary","billno","year","sponsor","cosponsors","when","sameas","committee","status","location","session-type","chair"));
for(String s:set) {
System.out.print("\"" + s + "\", ");
}
//
// ReportBuilder reportBuilder = new ReportBuilder();
// TreeSet<ReportBill> bills = reportBuilder.getBillReportSet("2011");
//
// LRSConnect l = LRSConnect.getInstance();
//
// for(ReportBill bill:bills) {
// if(bill.getHeat() < 7)
// break;
//
// System.out.print("testing bill " + bill.getBill());
//
// if(l.getBillFromLbdc(bill.getBill()) == null)
// System.out.println(" -- delete " + bill.getMissingFields());
// else
// System.out.println(" -- keep " + bill.getMissingFields());
//
//
// Thread.currentThread().sleep(3600);
// }
} | #vulnerable code
public static void main(String[] args) throws IOException {
LRSConnect l = LRSConnect.getInstance();
System.out.println(l.getLbdcBill("s1234-2011").getSummary());
System.out.println(l.getLbdcBill("s2008-2011").getSummary());
System.out.println(l.getLbdcBill("s1-2011"));
}
#location 4
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
public void doParsing (String filePath) throws Exception
{
engine = SearchEngine2.getInstance();
XMLSENATEDATA senateData = parseStream(new FileReader(new File(filePath)));
Iterator<Object> it = senateData.getSencalendarOrSencalendaractive().iterator();
Object nextItem = null;
String action = null;
Calendar calendar = null;
Supplemental supplemental = null;
ArrayList<LuceneObject> objectsToUpdate = new ArrayList<LuceneObject>();
PersistenceManager pm = PMF.getPersistenceManager();
while (it.hasNext())
{
nextItem = it.next();
Transaction currentTx = pm.currentTransaction();
currentTx.begin();
if (nextItem instanceof XMLSencalendar)
{
XMLSencalendar xmlCalendar = (XMLSencalendar)nextItem;
action = xmlCalendar.getAction();
calendar = getCalendar(pm, Calendar.TYPE_FLOOR,xmlCalendar.getNo(),xmlCalendar.getYear(),xmlCalendar.getSessyr());
supplemental = parseSupplemental(pm, calendar,xmlCalendar.getSupplemental());
supplemental.setCalendar(calendar);
objectsToUpdate.add(calendar);
}
else if (nextItem instanceof XMLSencalendaractive)
{
XMLSencalendaractive xmlActiveList = (XMLSencalendaractive)nextItem;
action = xmlActiveList.getAction();
calendar = getCalendar(pm, Calendar.TYPE_ACTIVE,xmlActiveList.getNo(),xmlActiveList.getYear(),xmlActiveList.getSessyr());
supplemental = parseSupplemental(pm, calendar,xmlActiveList.getSupplemental());
supplemental.setCalendar(calendar);
objectsToUpdate.add(calendar);
}
if (action.equals("remove") && removeObject != null)
{
logger.info("REMOVING: " + removeObject.getClass() + "=" + removeObjectId);
PMF.removePersistedObject(pm, removeObject.getClass(), removeObjectId);
}
currentTx.commit();
}
Transaction currentTx = pm.currentTransaction();
try
{
currentTx.begin();
engine.indexSenateObjects(objectsToUpdate, new LuceneSerializer[]{new XmlSerializer(), new JsonSerializer()});
currentTx.commit();
}
catch (Exception e)
{
currentTx.rollback();
}
engine.optimize();
} | #vulnerable code
public void doParsing (String filePath) throws Exception
{
engine = new SearchEngine2();
XMLSENATEDATA senateData = parseStream(new FileReader(new File(filePath)));
Iterator<Object> it = senateData.getSencalendarOrSencalendaractive().iterator();
Object nextItem = null;
String action = null;
Calendar calendar = null;
Supplemental supplemental = null;
ArrayList<LuceneObject> objectsToUpdate = new ArrayList<LuceneObject>();
PersistenceManager pm = PMF.getPersistenceManager();
while (it.hasNext())
{
nextItem = it.next();
Transaction currentTx = pm.currentTransaction();
currentTx.begin();
if (nextItem instanceof XMLSencalendar)
{
XMLSencalendar xmlCalendar = (XMLSencalendar)nextItem;
action = xmlCalendar.getAction();
calendar = getCalendar(pm, Calendar.TYPE_FLOOR,xmlCalendar.getNo(),xmlCalendar.getYear(),xmlCalendar.getSessyr());
supplemental = parseSupplemental(pm, calendar,xmlCalendar.getSupplemental());
supplemental.setCalendar(calendar);
objectsToUpdate.add(calendar);
}
else if (nextItem instanceof XMLSencalendaractive)
{
XMLSencalendaractive xmlActiveList = (XMLSencalendaractive)nextItem;
action = xmlActiveList.getAction();
calendar = getCalendar(pm, Calendar.TYPE_ACTIVE,xmlActiveList.getNo(),xmlActiveList.getYear(),xmlActiveList.getSessyr());
supplemental = parseSupplemental(pm, calendar,xmlActiveList.getSupplemental());
supplemental.setCalendar(calendar);
objectsToUpdate.add(calendar);
}
if (action.equals("remove") && removeObject != null)
{
logger.info("REMOVING: " + removeObject.getClass() + "=" + removeObjectId);
PMF.removePersistedObject(pm, removeObject.getClass(), removeObjectId);
}
currentTx.commit();
}
Transaction currentTx = pm.currentTransaction();
try
{
currentTx.begin();
engine.indexSenateObjects(objectsToUpdate, new LuceneSerializer[]{new XmlSerializer(), new JsonSerializer()});
currentTx.commit();
}
catch (Exception e)
{
currentTx.rollback();
}
engine.optimize();
}
#location 57
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@SuppressWarnings("unchecked")
@Override
protected void init() {
super.init();
// Clear array content
directMemoryService.setMemory(arrayIndexStartAddress, arrayIndexScale * length, (byte) 0);
primitiveArray = (A) directMemoryService.getObject(arrayStartAddress);
} | #vulnerable code
@SuppressWarnings("unchecked")
@Override
protected void init() {
super.init();
int arrayHeaderSize = JvmUtil.getArrayHeaderSize();
arrayIndexScale = JvmUtil.arrayIndexScale(elementType);
arrayIndexStartAddress = allocationStartAddress + JvmUtil.arrayBaseOffset(elementType);
// Copy sample array header to object pool array header
for (int i = 0; i < arrayHeaderSize; i++) {
directMemoryService.putByte(allocationStartAddress + i, directMemoryService.getByte(sampleArray, i));
}
// Set length of array object pool array
JvmUtil.setArrayLength(allocationStartAddress, elementType, length);
this.primitiveArray = (A) directMemoryService.getObject(allocationStartAddress);
}
#location 12
#vulnerability type THREAD_SAFETY_VIOLATION | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@SuppressWarnings("unchecked")
@Override
protected void init() {
super.init();
if (initializeElements) {
// All index is object pool array header point to allocated objects
for (long l = 0; l < length; l++) {
directMemoryService.putLong(arrayIndexStartAddress + (l * arrayIndexScale),
JvmUtil.toJvmAddress((objStartAddress + (l * objectSize))));
}
long sourceAddress = sampleObjectAddress + 4;
long copySize = objectSize - 4;
// Copy sample object to allocated memory region for each object
for (long l = 0; l < length; l++) {
long targetAddress = objStartAddress + (l * objectSize);
directMemoryService.putInt(targetAddress, 0);
directMemoryService.copyMemory(sourceAddress, targetAddress + 4, copySize);
}
}
else {
// All index is object pool array header point to allocated objects
for (long l = 0; l < length; l++) {
directMemoryService.putLong(arrayIndexStartAddress + (l * arrayIndexScale), 0);
}
}
this.objectArray = (A) directMemoryService.getObject(arrayStartAddress);
} | #vulnerable code
@SuppressWarnings("unchecked")
@Override
protected void init() {
super.init();
int arrayHeaderSize = JvmUtil.getArrayHeaderSize();
arrayIndexScale = JvmUtil.arrayIndexScale(elementType);
arrayIndexStartAddress = allocationStartAddress + JvmUtil.arrayBaseOffset(elementType);
objStartAddress = allocationStartAddress + JvmUtil.sizeOfArray(elementType, length);
// Allocated objects must start aligned as address size from start address of allocated address
long diffBetweenArrayAndObjectStartAddresses = objStartAddress - allocationStartAddress;
long addressMod = diffBetweenArrayAndObjectStartAddresses % JvmUtil.getAddressSize();
if (addressMod != 0) {
objStartAddress += (JvmUtil.getAddressSize() - addressMod);
}
// Copy sample array header to object pool array header
for (int i = 0; i < arrayHeaderSize; i++) {
directMemoryService.putByte(allocationStartAddress + i, directMemoryService.getByte(sampleArray, i));
}
// Set length of array object pool array
JvmUtil.setArrayLength(allocationStartAddress, elementType, length);
if (initializeElements) {
// All index is object pool array header point to allocated objects
for (long l = 0; l < length; l++) {
directMemoryService.putLong(arrayIndexStartAddress + (l * arrayIndexScale),
JvmUtil.toJvmAddress((objStartAddress + (l * objectSize))));
}
long sourceAddress = sampleObjectAddress + 4;
long copySize = objectSize - 4;
// Copy sample object to allocated memory region for each object
for (long l = 0; l < length; l++) {
long targetAddress = objStartAddress + (l * objectSize);
directMemoryService.putInt(targetAddress, 0);
directMemoryService.copyMemory(sourceAddress, targetAddress + 4, copySize);
}
}
else {
// All index is object pool array header point to allocated objects
for (long l = 0; l < length; l++) {
directMemoryService.putLong(arrayIndexStartAddress + (l * arrayIndexScale), 0);
}
}
this.objectArray = (A) directMemoryService.getObject(allocationStartAddress);
switch (JvmUtil.getAddressSize()) {
case JvmUtil.SIZE_32_BIT:
jvmAwareArrayElementAddressFinder = new Address32BitJvmAwareArrayElementAddressFinder();
break;
case JvmUtil.SIZE_64_BIT:
int referenceSize = JvmUtil.getReferenceSize();
switch (referenceSize) {
case JvmUtil.ADDRESSING_4_BYTE:
jvmAwareArrayElementAddressFinder = new Address64BitWithCompressedOopsJvmAwareArrayElementAddressFinder();
break;
case JvmUtil.ADDRESSING_8_BYTE:
jvmAwareArrayElementAddressFinder = new Address64BitWithCompressedOopsJvmAwareArrayElementAddressFinder();
break;
default:
throw new AssertionError("Unsupported reference size: " + referenceSize);
}
break;
default:
throw new AssertionError("Unsupported address size: " + JvmUtil.getAddressSize());
}
}
#location 59
#vulnerability type THREAD_SAFETY_VIOLATION | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
protected void init(Class<T> elementType, long objectCount,
NonPrimitiveFieldAllocationConfigType allocateNonPrimitiveFieldsAtOffHeapConfigType,
DirectMemoryService directMemoryService) {
super.init(elementType, allocateNonPrimitiveFieldsAtOffHeapConfigType, directMemoryService);
if (elementType.isAnnotation()) {
throw new IllegalArgumentException("Annotation class " + "(" + elementType.getName() + ")" +
" is not supported !");
}
if (elementType.isInterface()) {
throw new IllegalArgumentException("Interface class " + "(" + elementType.getName() + ")" +
" is not supported !");
}
if (elementType.isAnonymousClass()) {
throw new IllegalArgumentException("Anonymous class " + "(" + elementType.getName() + ")" +
" is not supported !");
}
this.elementType = elementType;
this.objectCount = objectCount;
this.usedObjectCount = 0;
this.directMemoryService = directMemoryService;
inUseBlockCount = objectCount;
inUseBlockAddress = directMemoryService.allocateMemory(inUseBlockCount);
sampleObject = JvmUtil.getSampleInstance(elementType);
if (sampleObject == null) {
throw new IllegalStateException("Unable to create a sample object for class " + elementType.getName());
}
sampleHeader = directMemoryService.getLong(sampleObject, 0L);
objectSize = directMemoryService.sizeOfObject(sampleObject);
offHeapSampleObjectAddress = directMemoryService.allocateMemory(objectSize);
directMemoryService.copyMemory(sampleObject, 0L, null, offHeapSampleObjectAddress, objectSize);
/*
for (int i = 0; i < objectSize; i += JvmUtil.LONG_SIZE) {
directMemoryService.putLong(offHeapSampleObjectAddress + i, directMemoryService.getLong(sampleObject, i));
}
*/
/*
for (int i = 0; i < objectSize; i++) {
directMemoryService.putByte(offHeapSampleObjectAddress + i, directMemoryService.getByte(sampleObject, i));
}
*/
// directMemoryService.copyMemory(directMemoryService.addressOf(sampleObject), offHeapSampleObjectAddress, objectSize);
} | #vulnerable code
protected void init(Class<T> elementType, long objectCount,
NonPrimitiveFieldAllocationConfigType allocateNonPrimitiveFieldsAtOffHeapConfigType,
DirectMemoryService directMemoryService) {
super.init(elementType, allocateNonPrimitiveFieldsAtOffHeapConfigType, directMemoryService);
if (elementType.isAnnotation()) {
throw new IllegalArgumentException("Annotation class " + "(" + elementType.getName() + ")" +
" is not supported !");
}
if (elementType.isInterface()) {
throw new IllegalArgumentException("Interface class " + "(" + elementType.getName() + ")" +
" is not supported !");
}
if (elementType.isAnonymousClass()) {
throw new IllegalArgumentException("Anonymous class " + "(" + elementType.getName() + ")" +
" is not supported !");
}
this.elementType = elementType;
this.objectCount = objectCount;
this.usedObjectCount = 0;
this.directMemoryService = directMemoryService;
inUseBlockCount = objectCount;
inUseBlockAddress = directMemoryService.allocateMemory(inUseBlockCount);
sampleObject = JvmUtil.getSampleInstance(elementType);
if (sampleObject == null) {
throw new IllegalStateException("Unable to create a sample object for class " + elementType.getName());
}
synchronized (sampleObject) {
sampleHeader = directMemoryService.getLong(sampleObject, 0L);
}
objectSize = directMemoryService.sizeOfObject(sampleObject);
offHeapSampleObjectAddress = directMemoryService.allocateMemory(objectSize);
directMemoryService.copyMemory(sampleObject, 0L, null, offHeapSampleObjectAddress, objectSize);
/*
for (int i = 0; i < objectSize; i += JvmUtil.LONG_SIZE) {
directMemoryService.putLong(offHeapSampleObjectAddress + i, directMemoryService.getLong(sampleObject, i));
}
*/
/*
for (int i = 0; i < objectSize; i++) {
directMemoryService.putByte(offHeapSampleObjectAddress + i, directMemoryService.getByte(sampleObject, i));
}
*/
// directMemoryService.copyMemory(directMemoryService.addressOf(sampleObject), offHeapSampleObjectAddress, objectSize);
}
#location 18
#vulnerability type THREAD_SAFETY_VIOLATION | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@SuppressWarnings("unchecked")
@Override
protected void init() {
super.init();
int arrayHeaderSize = JvmUtil.getArrayHeaderSize();
int arrayIndexScale = JvmUtil.arrayIndexScale(elementType);
long arrayIndexStartAddress = allocationStartAddress + JvmUtil.arrayBaseOffset(elementType);
objectsStartAddress = allocationStartAddress + JvmUtil.sizeOfArray(elementType, objectCount);
// Allocated objects must start aligned as address size from start address of allocated address
long diffBetweenArrayAndObjectStartAddresses = objectsStartAddress - allocationStartAddress;
long addressMod = diffBetweenArrayAndObjectStartAddresses % JvmUtil.OBJECT_ADDRESS_SENSIVITY;
if (addressMod != 0) {
objectsStartAddress += (JvmUtil.OBJECT_ADDRESS_SENSIVITY - addressMod);
}
objectsEndAddress = objectsStartAddress + (objectCount * objectSize);
// Copy sample array header to object pool array header
for (int i = 0; i < arrayHeaderSize; i++) {
directMemoryService.putByte(
allocationStartAddress + i,
directMemoryService.getByte(sampleArray, i));
}
// Set length of array object pool array
JvmUtil.setArrayLength(allocationStartAddress, elementType, (int) objectCount);
// All index is object pool array header point to allocated objects
for (long l = 0; l < objectCount; l++) {
directMemoryService.putLong(
arrayIndexStartAddress + (l * arrayIndexScale),
JvmUtil.toJvmAddress((objectsStartAddress + (l * objectSize))));
}
long sourceAddress = offHeapSampleObjectAddress + 4;
long copySize = objectSize - 4;
// Copy sample object to allocated memory region for each object
for (long l = 0; l < objectCount; l++) {
long targetAddress = objectsStartAddress + (l * objectSize);
directMemoryService.putInt(targetAddress, 0);
directMemoryService.copyMemory(sourceAddress, targetAddress + 4, copySize);
}
this.objectArray = (T[]) directMemoryService.getObject(allocationStartAddress);
} | #vulnerable code
@SuppressWarnings("unchecked")
@Override
protected void init() {
super.init();
this.currentIndex = 0;
int arrayHeaderSize = JvmUtil.getArrayHeaderSize();
int arrayIndexScale = JvmUtil.arrayIndexScale(elementType);
long arrayIndexStartAddress = allocationStartAddress + JvmUtil.arrayBaseOffset(elementType);
objectsStartAddress = allocationStartAddress + JvmUtil.sizeOfArray(elementType, objectCount);
// Allocated objects must start aligned as address size from start address of allocated address
long diffBetweenArrayAndObjectStartAddresses = objectsStartAddress - allocationStartAddress;
long addressMod = diffBetweenArrayAndObjectStartAddresses % JvmUtil.getAddressSize();
if (addressMod != 0) {
objectsStartAddress += (JvmUtil.getAddressSize() - addressMod);
}
objectsEndAddress = objectsStartAddress + (objectCount * objectSize);
// Copy sample array header to object pool array header
for (int i = 0; i < arrayHeaderSize; i++) {
directMemoryService.putByte(
allocationStartAddress + i,
directMemoryService.getByte(sampleArray, i));
}
// Set length of array object pool array
JvmUtil.setArrayLength(allocationStartAddress, elementType, (int) objectCount);
// All index is object pool array header point to allocated objects
for (long l = 0; l < objectCount; l++) {
directMemoryService.putLong(
arrayIndexStartAddress + (l * arrayIndexScale),
JvmUtil.toJvmAddress((objectsStartAddress + (l * objectSize))));
}
long sourceAddress = offHeapSampleObjectAddress + 4;
long copySize = objectSize - 4;
// Copy sample object to allocated memory region for each object
for (long l = 0; l < objectCount; l++) {
long targetAddress = objectsStartAddress + (l * objectSize);
directMemoryService.putInt(targetAddress, 0);
directMemoryService.copyMemory(sourceAddress, targetAddress + 4, copySize);
}
this.objectArray = (T[]) directMemoryService.getObject(allocationStartAddress);
}
#location 6
#vulnerability type THREAD_SAFETY_VIOLATION | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@Test
public void objectRetrievedSuccessfullyFromExtendableObjectOffHeapPoolWithDefaultObjectOffHeapPool() {
ExtendableObjectOffHeapPool<SampleOffHeapClass> extendableObjectPool =
offHeapService.createOffHeapPool(
new DefaultExtendableObjectOffHeapPoolCreateParameterBuilder<SampleOffHeapClass>().
elementType(SampleOffHeapClass.class).
build());
List<SampleOffHeapClass> objList = new ArrayList<SampleOffHeapClass>();
for (int i = 0; i < TOTAL_ELEMENT_COUNT; i++) {
SampleOffHeapClass obj = extendableObjectPool.get();
Assert.assertEquals(0, obj.getOrder());
obj.setOrder(i);
Assert.assertEquals(i, obj.getOrder());
objList.add(obj);
}
for (int i = 0; i < TOTAL_ELEMENT_COUNT; i++) {
SampleOffHeapClass obj = objList.get(i);
Assert.assertEquals(i, obj.getOrder());
}
} | #vulnerable code
@Test
public void objectRetrievedSuccessfullyFromExtendableObjectOffHeapPoolWithDefaultObjectOffHeapPool() {
ExtendableObjectOffHeapPool<SampleOffHeapClass> extendableObjectPool =
offHeapService.createOffHeapPool(
new DefaultExtendableObjectOffHeapPoolCreateParameterBuilder<SampleOffHeapClass>().
elementType(SampleOffHeapClass.class).
build());
List<SampleOffHeapClass> objList = new ArrayList<SampleOffHeapClass>();
for (int i = 0; i < TOTAL_ELEMENT_COUNT; i++) {
SampleOffHeapClass obj = extendableObjectPool.get();
obj.setOrder(i);
objList.add(obj);
}
for (int i = 0; i < TOTAL_ELEMENT_COUNT; i++) {
SampleOffHeapClass obj = objList.get(i);
Assert.assertEquals(i, obj.getOrder());
}
}
#location 13
#vulnerability type NULL_DEREFERENCE | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@SuppressWarnings("unchecked")
@Override
public T getAt(int index) {
checkAvailability();
if (index < 0 || index > length) {
throw new IllegalArgumentException("Invalid index: " + index);
}
processObject(
jvmAwareArrayElementAddressFinder.findAddress(
arrayIndexStartAddress, arrayIndexScale, index));
T obj = ((T[])(getObjectArray()))[index];
if (obj instanceof OffHeapAwareObject) {
((OffHeapAwareObject) obj).onGet(offHeapService, directMemoryService);
}
return obj;
} | #vulnerable code
@SuppressWarnings("unchecked")
@Override
public T getAt(int index) {
checkAvailability();
if (index < 0 || index > length) {
throw new IllegalArgumentException("Invalid index: " + index);
}
processObject(
jvmAwareArrayElementAddressFinder.findAddress(
arrayIndexStartAddress, arrayIndexScale, index));
T obj = ((T[])(objectArray))[index];
if (obj instanceof OffHeapAwareObject) {
((OffHeapAwareObject) obj).onGet(offHeapService, directMemoryService);
}
return obj;
}
#location 11
#vulnerability type THREAD_SAFETY_VIOLATION | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@SuppressWarnings("unchecked")
@Override
protected void init() {
super.init();
this.currentIndex = 0;
int arrayHeaderSize = JvmUtil.getArrayHeaderSize();
int arrayIndexScale = JvmUtil.arrayIndexScale(elementType);
long arrayIndexStartAddress = allocationStartAddress + JvmUtil.arrayBaseOffset(elementType);
objectsStartAddress = allocationStartAddress + JvmUtil.sizeOfArray(elementType, objectCount);
// Allocated objects must start aligned as address size from start address of allocated address
long diffBetweenArrayAndObjectStartAddresses = objectsStartAddress - allocationStartAddress;
long addressMod = diffBetweenArrayAndObjectStartAddresses % JvmUtil.getAddressSize();
if (addressMod != 0) {
objectsStartAddress += (JvmUtil.getAddressSize() - addressMod);
}
objectsEndAddress = objectsStartAddress + (objectCount * objectSize);
// Copy sample array header to object pool array header
for (int i = 0; i < arrayHeaderSize; i++) {
directMemoryService.putByte(
allocationStartAddress + i,
directMemoryService.getByte(sampleArray, i));
}
// Set length of array object pool array
JvmUtil.setArrayLength(allocationStartAddress, elementType, objectCount);
// All index is object pool array header point to allocated objects
for (long l = 0; l < objectCount; l++) {
directMemoryService.putLong(
arrayIndexStartAddress + (l * arrayIndexScale),
JvmUtil.toJvmAddress((objectsStartAddress + (l * objectSize))));
}
long sourceAddress = offHeapSampleObjectAddress + 4;
long copySize = objectSize - 4;
// Copy sample object to allocated memory region for each object
for (long l = 0; l < objectCount; l++) {
long targetAddress = objectsStartAddress + (l * objectSize);
directMemoryService.putInt(targetAddress, 0);
directMemoryService.copyMemory(sourceAddress, targetAddress + 4, copySize);
}
this.objectArray = (T[]) directMemoryService.getObject(allocationStartAddress);
} | #vulnerable code
@SuppressWarnings("unchecked")
@Override
protected void init() {
super.init();
this.currentIndex = 0;
int arrayHeaderSize = JvmUtil.getArrayHeaderSize();
int arrayIndexScale = JvmUtil.arrayIndexScale(elementType);
long arrayIndexStartAddress = allocationStartAddress + JvmUtil.arrayBaseOffset(elementType);
objStartAddress = allocationStartAddress + JvmUtil.sizeOfArray(elementType, objectCount);
// Allocated objects must start aligned as address size from start address of allocated address
long diffBetweenArrayAndObjectStartAddresses = objStartAddress - allocationStartAddress;
long addressMod = diffBetweenArrayAndObjectStartAddresses % JvmUtil.getAddressSize();
if (addressMod != 0) {
objStartAddress += (JvmUtil.getAddressSize() - addressMod);
}
// Copy sample array header to object pool array header
for (int i = 0; i < arrayHeaderSize; i++) {
directMemoryService.putByte(allocationStartAddress + i, directMemoryService.getByte(sampleArray, i));
}
// Set length of array object pool array
JvmUtil.setArrayLength(allocationStartAddress, elementType, objectCount);
// All index is object pool array header point to allocated objects
for (long l = 0; l < objectCount; l++) {
directMemoryService.putLong(arrayIndexStartAddress + (l * arrayIndexScale),
JvmUtil.toJvmAddress((objStartAddress + (l * objectSize))));
}
long sourceAddress = offHeapSampleObjectAddress + 4;
long copySize = objectSize - 4;
// Copy sample object to allocated memory region for each object
for (long l = 0; l < objectCount; l++) {
long targetAddress = objStartAddress + (l * objectSize);
directMemoryService.putInt(targetAddress, 0);
directMemoryService.copyMemory(sourceAddress, targetAddress + 4, copySize);
}
this.objectArray = (T[]) directMemoryService.getObject(allocationStartAddress);
}
#location 17
#vulnerability type THREAD_SAFETY_VIOLATION | Below is the vulnerable code, please generate the patch based on the following information. |
#fixed code
@SuppressWarnings("unchecked")
@Override
protected void init() {
super.init();
if (initializeElements) {
// All index is object pool array header point to allocated objects
for (long l = 0; l < length; l++) {
directMemoryService.putLong(arrayIndexStartAddress + (l * arrayIndexScale),
JvmUtil.toJvmAddress((objStartAddress + (l * objectSize))));
}
long sourceAddress = sampleObjectAddress + 4;
long copySize = objectSize - 4;
// Copy sample object to allocated memory region for each object
for (long l = 0; l < length; l++) {
long targetAddress = objStartAddress + (l * objectSize);
directMemoryService.putInt(targetAddress, 0);
directMemoryService.copyMemory(sourceAddress, targetAddress + 4, copySize);
}
}
else {
// All index is object pool array header point to allocated objects
for (long l = 0; l < length; l++) {
directMemoryService.putLong(arrayIndexStartAddress + (l * arrayIndexScale), 0);
}
}
this.objectArray = (A) directMemoryService.getObject(arrayStartAddress);
} | #vulnerable code
@SuppressWarnings("unchecked")
@Override
protected void init() {
super.init();
int arrayHeaderSize = JvmUtil.getArrayHeaderSize();
arrayIndexScale = JvmUtil.arrayIndexScale(elementType);
arrayIndexStartAddress = allocationStartAddress + JvmUtil.arrayBaseOffset(elementType);
objStartAddress = allocationStartAddress + JvmUtil.sizeOfArray(elementType, length);
// Allocated objects must start aligned as address size from start address of allocated address
long diffBetweenArrayAndObjectStartAddresses = objStartAddress - allocationStartAddress;
long addressMod = diffBetweenArrayAndObjectStartAddresses % JvmUtil.getAddressSize();
if (addressMod != 0) {
objStartAddress += (JvmUtil.getAddressSize() - addressMod);
}
// Copy sample array header to object pool array header
for (int i = 0; i < arrayHeaderSize; i++) {
directMemoryService.putByte(allocationStartAddress + i, directMemoryService.getByte(sampleArray, i));
}
// Set length of array object pool array
JvmUtil.setArrayLength(allocationStartAddress, elementType, length);
if (initializeElements) {
// All index is object pool array header point to allocated objects
for (long l = 0; l < length; l++) {
directMemoryService.putLong(arrayIndexStartAddress + (l * arrayIndexScale),
JvmUtil.toJvmAddress((objStartAddress + (l * objectSize))));
}
long sourceAddress = sampleObjectAddress + 4;
long copySize = objectSize - 4;
// Copy sample object to allocated memory region for each object
for (long l = 0; l < length; l++) {
long targetAddress = objStartAddress + (l * objectSize);
directMemoryService.putInt(targetAddress, 0);
directMemoryService.copyMemory(sourceAddress, targetAddress + 4, copySize);
}
}
else {
// All index is object pool array header point to allocated objects
for (long l = 0; l < length; l++) {
directMemoryService.putLong(arrayIndexStartAddress + (l * arrayIndexScale), 0);
}
}
this.objectArray = (A) directMemoryService.getObject(allocationStartAddress);
switch (JvmUtil.getAddressSize()) {
case JvmUtil.SIZE_32_BIT:
jvmAwareArrayElementAddressFinder = new Address32BitJvmAwareArrayElementAddressFinder();
break;
case JvmUtil.SIZE_64_BIT:
int referenceSize = JvmUtil.getReferenceSize();
switch (referenceSize) {
case JvmUtil.ADDRESSING_4_BYTE:
jvmAwareArrayElementAddressFinder = new Address64BitWithCompressedOopsJvmAwareArrayElementAddressFinder();
break;
case JvmUtil.ADDRESSING_8_BYTE:
jvmAwareArrayElementAddressFinder = new Address64BitWithCompressedOopsJvmAwareArrayElementAddressFinder();
break;
default:
throw new AssertionError("Unsupported reference size: " + referenceSize);
}
break;
default:
throw new AssertionError("Unsupported address size: " + JvmUtil.getAddressSize());
}
}
#location 45
#vulnerability type THREAD_SAFETY_VIOLATION | Below is the vulnerable code, please generate the patch based on the following information. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.