type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
334k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cwmyers/monet.js/pulls/comments/94330240","pull_request_review_id":14857382,"id":94330240,"diff_hunk":"@@ -627,6 +633,16 @@\n return fn(a) ? self : None()\n })\n },\n+ forEach: function (fn) {\n+ if (this.isSome()) {\n+ fn(this.val);\n+ }\n+ },\n+ orElseRun: function (fn) {\n+ if (!this.isSome()) {\n+ fn();","path":"src/monet.js","position":55,"original_position":55,"commit_id":"e3368b95367d89650ad321b4b8c661bd0e06a5f5","original_commit_id":"e3368b95367d89650ad321b4b8c661bd0e06a5f5","user":{"login":"ulfryk","id":1754948,"avatar_url":"https://avatars.githubusercontent.com/u/1754948?v=3","gravatar_id":"","url":"https://api.github.com/users/ulfryk","html_url":"https://github.com/ulfryk","followers_url":"https://api.github.com/users/ulfryk/followers","following_url":"https://api.github.com/users/ulfryk/following{/other_user}","gists_url":"https://api.github.com/users/ulfryk/gists{/gist_id}","starred_url":"https://api.github.com/users/ulfryk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulfryk/subscriptions","organizations_url":"https://api.github.com/users/ulfryk/orgs","repos_url":"https://api.github.com/users/ulfryk/repos","events_url":"https://api.github.com/users/ulfryk/events{/privacy}","received_events_url":"https://api.github.com/users/ulfryk/received_events","type":"User","site_admin":false},"body":"as above.. \r\n\r\nand in all other","created_at":"2017-01-02T16:07:14Z","updated_at":"2017-01-02T16:11:12Z","html_url":"https://github.com/cwmyers/monet.js/pull/95#discussion_r94330240","pull_request_url":"https://api.github.com/repos/cwmyers/monet.js/pulls/95","_links":{"self":{"href":"https://api.github.com/repos/cwmyers/monet.js/pulls/comments/94330240"},"html":{"href":"https://github.com/cwmyers/monet.js/pull/95#discussion_r94330240"},"pull_request":{"href":"https://api.github.com/repos/cwmyers/monet.js/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/cwmyers/monet.js/pulls/95","id":99874106,"html_url":"https://github.com/cwmyers/monet.js/pull/95","diff_url":"https://github.com/cwmyers/monet.js/pull/95.diff","patch_url":"https://github.com/cwmyers/monet.js/pull/95.patch","issue_url":"https://api.github.com/repos/cwmyers/monet.js/issues/95","number":95,"state":"open","locked":false,"title":"add forEach & variants, fixes #92","user":{"login":"emmanueltouzery","id":339433,"avatar_url":"https://avatars.githubusercontent.com/u/339433?v=3","gravatar_id":"","url":"https://api.github.com/users/emmanueltouzery","html_url":"https://github.com/emmanueltouzery","followers_url":"https://api.github.com/users/emmanueltouzery/followers","following_url":"https://api.github.com/users/emmanueltouzery/following{/other_user}","gists_url":"https://api.github.com/users/emmanueltouzery/gists{/gist_id}","starred_url":"https://api.github.com/users/emmanueltouzery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmanueltouzery/subscriptions","organizations_url":"https://api.github.com/users/emmanueltouzery/orgs","repos_url":"https://api.github.com/users/emmanueltouzery/repos","events_url":"https://api.github.com/users/emmanueltouzery/events{/privacy}","received_events_url":"https://api.github.com/users/emmanueltouzery/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-02T15:44:08Z","updated_at":"2017-01-02T16:11:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8f7377fc0c19453442a70fb33e999957d0139bf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cwmyers/monet.js/pulls/95/commits","review_comments_url":"https://api.github.com/repos/cwmyers/monet.js/pulls/95/comments","review_comment_url":"https://api.github.com/repos/cwmyers/monet.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cwmyers/monet.js/issues/95/comments","statuses_url":"https://api.github.com/repos/cwmyers/monet.js/statuses/e3368b95367d89650ad321b4b8c661bd0e06a5f5","head":{"label":"emmanueltouzery:foreach","ref":"foreach","sha":"e3368b95367d89650ad321b4b8c661bd0e06a5f5","user":{"login":"emmanueltouzery","id":339433,"avatar_url":"https://avatars.githubusercontent.com/u/339433?v=3","gravatar_id":"","url":"https://api.github.com/users/emmanueltouzery","html_url":"https://github.com/emmanueltouzery","followers_url":"https://api.github.com/users/emmanueltouzery/followers","following_url":"https://api.github.com/users/emmanueltouzery/following{/other_user}","gists_url":"https://api.github.com/users/emmanueltouzery/gists{/gist_id}","starred_url":"https://api.github.com/users/emmanueltouzery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmanueltouzery/subscriptions","organizations_url":"https://api.github.com/users/emmanueltouzery/orgs","repos_url":"https://api.github.com/users/emmanueltouzery/repos","events_url":"https://api.github.com/users/emmanueltouzery/events{/privacy}","received_events_url":"https://api.github.com/users/emmanueltouzery/received_events","type":"User","site_admin":false},"repo":{"id":76297114,"name":"monet.js","full_name":"emmanueltouzery/monet.js","owner":{"login":"emmanueltouzery","id":339433,"avatar_url":"https://avatars.githubusercontent.com/u/339433?v=3","gravatar_id":"","url":"https://api.github.com/users/emmanueltouzery","html_url":"https://github.com/emmanueltouzery","followers_url":"https://api.github.com/users/emmanueltouzery/followers","following_url":"https://api.github.com/users/emmanueltouzery/following{/other_user}","gists_url":"https://api.github.com/users/emmanueltouzery/gists{/gist_id}","starred_url":"https://api.github.com/users/emmanueltouzery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmanueltouzery/subscriptions","organizations_url":"https://api.github.com/users/emmanueltouzery/orgs","repos_url":"https://api.github.com/users/emmanueltouzery/repos","events_url":"https://api.github.com/users/emmanueltouzery/events{/privacy}","received_events_url":"https://api.github.com/users/emmanueltouzery/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emmanueltouzery/monet.js","description":"monet.js - Monadic types library for JavaScript","fork":true,"url":"https://api.github.com/repos/emmanueltouzery/monet.js","forks_url":"https://api.github.com/repos/emmanueltouzery/monet.js/forks","keys_url":"https://api.github.com/repos/emmanueltouzery/monet.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emmanueltouzery/monet.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emmanueltouzery/monet.js/teams","hooks_url":"https://api.github.com/repos/emmanueltouzery/monet.js/hooks","issue_events_url":"https://api.github.com/repos/emmanueltouzery/monet.js/issues/events{/number}","events_url":"https://api.github.com/repos/emmanueltouzery/monet.js/events","assignees_url":"https://api.github.com/repos/emmanueltouzery/monet.js/assignees{/user}","branches_url":"https://api.github.com/repos/emmanueltouzery/monet.js/branches{/branch}","tags_url":"https://api.github.com/repos/emmanueltouzery/monet.js/tags","blobs_url":"https://api.github.com/repos/emmanueltouzery/monet.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emmanueltouzery/monet.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emmanueltouzery/monet.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emmanueltouzery/monet.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emmanueltouzery/monet.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emmanueltouzery/monet.js/languages","stargazers_url":"https://api.github.com/repos/emmanueltouzery/monet.js/stargazers","contributors_url":"https://api.github.com/repos/emmanueltouzery/monet.js/contributors","subscribers_url":"https://api.github.com/repos/emmanueltouzery/monet.js/subscribers","subscription_url":"https://api.github.com/repos/emmanueltouzery/monet.js/subscription","commits_url":"https://api.github.com/repos/emmanueltouzery/monet.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emmanueltouzery/monet.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emmanueltouzery/monet.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emmanueltouzery/monet.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emmanueltouzery/monet.js/contents/{+path}","compare_url":"https://api.github.com/repos/emmanueltouzery/monet.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emmanueltouzery/monet.js/merges","archive_url":"https://api.github.com/repos/emmanueltouzery/monet.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emmanueltouzery/monet.js/downloads","issues_url":"https://api.github.com/repos/emmanueltouzery/monet.js/issues{/number}","pulls_url":"https://api.github.com/repos/emmanueltouzery/monet.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emmanueltouzery/monet.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emmanueltouzery/monet.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emmanueltouzery/monet.js/labels{/name}","releases_url":"https://api.github.com/repos/emmanueltouzery/monet.js/releases{/id}","deployments_url":"https://api.github.com/repos/emmanueltouzery/monet.js/deployments","created_at":"2016-12-12T21:29:26Z","updated_at":"2016-12-12T21:29:27Z","pushed_at":"2017-01-02T15:53:13Z","git_url":"git://github.com/emmanueltouzery/monet.js.git","ssh_url":"[email protected]:emmanueltouzery/monet.js.git","clone_url":"https://github.com/emmanueltouzery/monet.js.git","svn_url":"https://github.com/emmanueltouzery/monet.js","homepage":"http://cwmyers.github.com/monet.js/","size":1443,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cwmyers:develop","ref":"develop","sha":"400494963ae78d0b0085dba42a42e1416ab219ea","user":{"login":"cwmyers","id":356775,"avatar_url":"https://avatars.githubusercontent.com/u/356775?v=3","gravatar_id":"","url":"https://api.github.com/users/cwmyers","html_url":"https://github.com/cwmyers","followers_url":"https://api.github.com/users/cwmyers/followers","following_url":"https://api.github.com/users/cwmyers/following{/other_user}","gists_url":"https://api.github.com/users/cwmyers/gists{/gist_id}","starred_url":"https://api.github.com/users/cwmyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwmyers/subscriptions","organizations_url":"https://api.github.com/users/cwmyers/orgs","repos_url":"https://api.github.com/users/cwmyers/repos","events_url":"https://api.github.com/users/cwmyers/events{/privacy}","received_events_url":"https://api.github.com/users/cwmyers/received_events","type":"User","site_admin":false},"repo":{"id":13453177,"name":"monet.js","full_name":"cwmyers/monet.js","owner":{"login":"cwmyers","id":356775,"avatar_url":"https://avatars.githubusercontent.com/u/356775?v=3","gravatar_id":"","url":"https://api.github.com/users/cwmyers","html_url":"https://github.com/cwmyers","followers_url":"https://api.github.com/users/cwmyers/followers","following_url":"https://api.github.com/users/cwmyers/following{/other_user}","gists_url":"https://api.github.com/users/cwmyers/gists{/gist_id}","starred_url":"https://api.github.com/users/cwmyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwmyers/subscriptions","organizations_url":"https://api.github.com/users/cwmyers/orgs","repos_url":"https://api.github.com/users/cwmyers/repos","events_url":"https://api.github.com/users/cwmyers/events{/privacy}","received_events_url":"https://api.github.com/users/cwmyers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cwmyers/monet.js","description":"monet.js - Monadic types library for JavaScript","fork":false,"url":"https://api.github.com/repos/cwmyers/monet.js","forks_url":"https://api.github.com/repos/cwmyers/monet.js/forks","keys_url":"https://api.github.com/repos/cwmyers/monet.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cwmyers/monet.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cwmyers/monet.js/teams","hooks_url":"https://api.github.com/repos/cwmyers/monet.js/hooks","issue_events_url":"https://api.github.com/repos/cwmyers/monet.js/issues/events{/number}","events_url":"https://api.github.com/repos/cwmyers/monet.js/events","assignees_url":"https://api.github.com/repos/cwmyers/monet.js/assignees{/user}","branches_url":"https://api.github.com/repos/cwmyers/monet.js/branches{/branch}","tags_url":"https://api.github.com/repos/cwmyers/monet.js/tags","blobs_url":"https://api.github.com/repos/cwmyers/monet.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cwmyers/monet.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cwmyers/monet.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/cwmyers/monet.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cwmyers/monet.js/statuses/{sha}","languages_url":"https://api.github.com/repos/cwmyers/monet.js/languages","stargazers_url":"https://api.github.com/repos/cwmyers/monet.js/stargazers","contributors_url":"https://api.github.com/repos/cwmyers/monet.js/contributors","subscribers_url":"https://api.github.com/repos/cwmyers/monet.js/subscribers","subscription_url":"https://api.github.com/repos/cwmyers/monet.js/subscription","commits_url":"https://api.github.com/repos/cwmyers/monet.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/cwmyers/monet.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/cwmyers/monet.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/cwmyers/monet.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/cwmyers/monet.js/contents/{+path}","compare_url":"https://api.github.com/repos/cwmyers/monet.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cwmyers/monet.js/merges","archive_url":"https://api.github.com/repos/cwmyers/monet.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cwmyers/monet.js/downloads","issues_url":"https://api.github.com/repos/cwmyers/monet.js/issues{/number}","pulls_url":"https://api.github.com/repos/cwmyers/monet.js/pulls{/number}","milestones_url":"https://api.github.com/repos/cwmyers/monet.js/milestones{/number}","notifications_url":"https://api.github.com/repos/cwmyers/monet.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cwmyers/monet.js/labels{/name}","releases_url":"https://api.github.com/repos/cwmyers/monet.js/releases{/id}","deployments_url":"https://api.github.com/repos/cwmyers/monet.js/deployments","created_at":"2013-10-09T20:21:53Z","updated_at":"2016-12-27T16:28:52Z","pushed_at":"2017-01-02T15:53:14Z","git_url":"git://github.com/cwmyers/monet.js.git","ssh_url":"[email protected]:cwmyers/monet.js.git","clone_url":"https://github.com/cwmyers/monet.js.git","svn_url":"https://github.com/cwmyers/monet.js","homepage":"http://cwmyers.github.com/monet.js/","size":1443,"stargazers_count":448,"watchers_count":448,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"open_issues_count":21,"forks":39,"open_issues":21,"watchers":448,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cwmyers/monet.js/pulls/95"},"html":{"href":"https://github.com/cwmyers/monet.js/pull/95"},"issue":{"href":"https://api.github.com/repos/cwmyers/monet.js/issues/95"},"comments":{"href":"https://api.github.com/repos/cwmyers/monet.js/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/cwmyers/monet.js/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/cwmyers/monet.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cwmyers/monet.js/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/cwmyers/monet.js/statuses/e3368b95367d89650ad321b4b8c661bd0e06a5f5"}}}} | {
"id": 13453177,
"name": "cwmyers/monet.js",
"url": "https://api.github.com/repos/cwmyers/monet.js"
} | {
"id": 1754948,
"login": "ulfryk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1754948?",
"url": "https://api.github.com/users/ulfryk"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-01-02T16:07:14 | 5091778415 | {"actor":{"display_login":"ulfryk"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/pulls/comments/159024452","pull_request_review_id":85911444,"id":159024452,"diff_hunk":"@@ -0,0 +1,29 @@\n+package ru.spbau.gbarto;\r\n+\r\n+import java.io.ByteArrayInputStream;\r\n+import java.io.ByteArrayOutputStream;\r","path":"lab03_Trie/src/main/java/ru/spbau/gbarto/Main.java","position":4,"original_position":4,"commit_id":"3ed746f2e76a72c5fb07835e7687007020b1fc1d","original_commit_id":"3ed746f2e76a72c5fb07835e7687007020b1fc1d","user":{"login":"yurii-litvinov","id":706768,"avatar_url":"https://avatars3.githubusercontent.com/u/706768?v=4","gravatar_id":"","url":"https://api.github.com/users/yurii-litvinov","html_url":"https://github.com/yurii-litvinov","followers_url":"https://api.github.com/users/yurii-litvinov/followers","following_url":"https://api.github.com/users/yurii-litvinov/following{/other_user}","gists_url":"https://api.github.com/users/yurii-litvinov/gists{/gist_id}","starred_url":"https://api.github.com/users/yurii-litvinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurii-litvinov/subscriptions","organizations_url":"https://api.github.com/users/yurii-litvinov/orgs","repos_url":"https://api.github.com/users/yurii-litvinov/repos","events_url":"https://api.github.com/users/yurii-litvinov/events{/privacy}","received_events_url":"https://api.github.com/users/yurii-litvinov/received_events","type":"User","site_admin":false},"body":"Эти import-ы не нужны","created_at":"2017-12-29T04:34:24Z","updated_at":"2017-12-29T05:01:44Z","html_url":"https://github.com/GrigoryBartosh/JavaHW/pull/18#discussion_r159024452","pull_request_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/pulls/18","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/GrigoryBartosh/JavaHW/pulls/comments/159024452"},"html":{"href":"https://github.com/GrigoryBartosh/JavaHW/pull/18#discussion_r159024452"},"pull_request":{"href":"https://api.github.com/repos/GrigoryBartosh/JavaHW/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/pulls/18","id":160271153,"html_url":"https://github.com/GrigoryBartosh/JavaHW/pull/18","diff_url":"https://github.com/GrigoryBartosh/JavaHW/pull/18.diff","patch_url":"https://github.com/GrigoryBartosh/JavaHW/pull/18.patch","issue_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/issues/18","number":18,"state":"open","locked":false,"title":"lab #03 Trie fix","user":{"login":"GrigoryBartosh","id":16509368,"avatar_url":"https://avatars2.githubusercontent.com/u/16509368?v=4","gravatar_id":"","url":"https://api.github.com/users/GrigoryBartosh","html_url":"https://github.com/GrigoryBartosh","followers_url":"https://api.github.com/users/GrigoryBartosh/followers","following_url":"https://api.github.com/users/GrigoryBartosh/following{/other_user}","gists_url":"https://api.github.com/users/GrigoryBartosh/gists{/gist_id}","starred_url":"https://api.github.com/users/GrigoryBartosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrigoryBartosh/subscriptions","organizations_url":"https://api.github.com/users/GrigoryBartosh/orgs","repos_url":"https://api.github.com/users/GrigoryBartosh/repos","events_url":"https://api.github.com/users/GrigoryBartosh/events{/privacy}","received_events_url":"https://api.github.com/users/GrigoryBartosh/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-27T16:18:29Z","updated_at":"2017-12-29T05:01:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09b0910aa2be9abf4fabecb02962c7c6b8ce7f2e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/pulls/18/commits","review_comments_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/pulls/18/comments","review_comment_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/issues/18/comments","statuses_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/statuses/3ed746f2e76a72c5fb07835e7687007020b1fc1d","head":{"label":"GrigoryBartosh:lab03_Trie_fix","ref":"lab03_Trie_fix","sha":"3ed746f2e76a72c5fb07835e7687007020b1fc1d","user":{"login":"GrigoryBartosh","id":16509368,"avatar_url":"https://avatars2.githubusercontent.com/u/16509368?v=4","gravatar_id":"","url":"https://api.github.com/users/GrigoryBartosh","html_url":"https://github.com/GrigoryBartosh","followers_url":"https://api.github.com/users/GrigoryBartosh/followers","following_url":"https://api.github.com/users/GrigoryBartosh/following{/other_user}","gists_url":"https://api.github.com/users/GrigoryBartosh/gists{/gist_id}","starred_url":"https://api.github.com/users/GrigoryBartosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrigoryBartosh/subscriptions","organizations_url":"https://api.github.com/users/GrigoryBartosh/orgs","repos_url":"https://api.github.com/users/GrigoryBartosh/repos","events_url":"https://api.github.com/users/GrigoryBartosh/events{/privacy}","received_events_url":"https://api.github.com/users/GrigoryBartosh/received_events","type":"User","site_admin":false},"repo":{"id":104132555,"name":"JavaHW","full_name":"GrigoryBartosh/JavaHW","owner":{"login":"GrigoryBartosh","id":16509368,"avatar_url":"https://avatars2.githubusercontent.com/u/16509368?v=4","gravatar_id":"","url":"https://api.github.com/users/GrigoryBartosh","html_url":"https://github.com/GrigoryBartosh","followers_url":"https://api.github.com/users/GrigoryBartosh/followers","following_url":"https://api.github.com/users/GrigoryBartosh/following{/other_user}","gists_url":"https://api.github.com/users/GrigoryBartosh/gists{/gist_id}","starred_url":"https://api.github.com/users/GrigoryBartosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrigoryBartosh/subscriptions","organizations_url":"https://api.github.com/users/GrigoryBartosh/orgs","repos_url":"https://api.github.com/users/GrigoryBartosh/repos","events_url":"https://api.github.com/users/GrigoryBartosh/events{/privacy}","received_events_url":"https://api.github.com/users/GrigoryBartosh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GrigoryBartosh/JavaHW","description":null,"fork":false,"url":"https://api.github.com/repos/GrigoryBartosh/JavaHW","forks_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/forks","keys_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/teams","hooks_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/hooks","issue_events_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/issues/events{/number}","events_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/events","assignees_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/assignees{/user}","branches_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/branches{/branch}","tags_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/tags","blobs_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/git/refs{/sha}","trees_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/statuses/{sha}","languages_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/languages","stargazers_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/stargazers","contributors_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/contributors","subscribers_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/subscribers","subscription_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/subscription","commits_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/commits{/sha}","git_commits_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/git/commits{/sha}","comments_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/comments{/number}","issue_comment_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/issues/comments{/number}","contents_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/contents/{+path}","compare_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/merges","archive_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/downloads","issues_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/issues{/number}","pulls_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/pulls{/number}","milestones_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/milestones{/number}","notifications_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/labels{/name}","releases_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/releases{/id}","deployments_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/deployments","created_at":"2017-09-19T21:48:05Z","updated_at":"2017-09-19T21:48:05Z","pushed_at":"2017-12-28T19:49:25Z","git_url":"git://github.com/GrigoryBartosh/JavaHW.git","ssh_url":"[email protected]:GrigoryBartosh/JavaHW.git","clone_url":"https://github.com/GrigoryBartosh/JavaHW.git","svn_url":"https://github.com/GrigoryBartosh/JavaHW","homepage":null,"size":366,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":25,"license":null,"forks":0,"open_issues":25,"watchers":0,"default_branch":"master"}},"base":{"label":"GrigoryBartosh:master","ref":"master","sha":"78da69afe5df07d6bacdc2c56a59fdc74c6c5073","user":{"login":"GrigoryBartosh","id":16509368,"avatar_url":"https://avatars2.githubusercontent.com/u/16509368?v=4","gravatar_id":"","url":"https://api.github.com/users/GrigoryBartosh","html_url":"https://github.com/GrigoryBartosh","followers_url":"https://api.github.com/users/GrigoryBartosh/followers","following_url":"https://api.github.com/users/GrigoryBartosh/following{/other_user}","gists_url":"https://api.github.com/users/GrigoryBartosh/gists{/gist_id}","starred_url":"https://api.github.com/users/GrigoryBartosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrigoryBartosh/subscriptions","organizations_url":"https://api.github.com/users/GrigoryBartosh/orgs","repos_url":"https://api.github.com/users/GrigoryBartosh/repos","events_url":"https://api.github.com/users/GrigoryBartosh/events{/privacy}","received_events_url":"https://api.github.com/users/GrigoryBartosh/received_events","type":"User","site_admin":false},"repo":{"id":104132555,"name":"JavaHW","full_name":"GrigoryBartosh/JavaHW","owner":{"login":"GrigoryBartosh","id":16509368,"avatar_url":"https://avatars2.githubusercontent.com/u/16509368?v=4","gravatar_id":"","url":"https://api.github.com/users/GrigoryBartosh","html_url":"https://github.com/GrigoryBartosh","followers_url":"https://api.github.com/users/GrigoryBartosh/followers","following_url":"https://api.github.com/users/GrigoryBartosh/following{/other_user}","gists_url":"https://api.github.com/users/GrigoryBartosh/gists{/gist_id}","starred_url":"https://api.github.com/users/GrigoryBartosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrigoryBartosh/subscriptions","organizations_url":"https://api.github.com/users/GrigoryBartosh/orgs","repos_url":"https://api.github.com/users/GrigoryBartosh/repos","events_url":"https://api.github.com/users/GrigoryBartosh/events{/privacy}","received_events_url":"https://api.github.com/users/GrigoryBartosh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GrigoryBartosh/JavaHW","description":null,"fork":false,"url":"https://api.github.com/repos/GrigoryBartosh/JavaHW","forks_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/forks","keys_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/teams","hooks_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/hooks","issue_events_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/issues/events{/number}","events_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/events","assignees_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/assignees{/user}","branches_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/branches{/branch}","tags_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/tags","blobs_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/git/refs{/sha}","trees_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/statuses/{sha}","languages_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/languages","stargazers_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/stargazers","contributors_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/contributors","subscribers_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/subscribers","subscription_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/subscription","commits_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/commits{/sha}","git_commits_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/git/commits{/sha}","comments_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/comments{/number}","issue_comment_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/issues/comments{/number}","contents_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/contents/{+path}","compare_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/merges","archive_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/downloads","issues_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/issues{/number}","pulls_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/pulls{/number}","milestones_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/milestones{/number}","notifications_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/labels{/name}","releases_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/releases{/id}","deployments_url":"https://api.github.com/repos/GrigoryBartosh/JavaHW/deployments","created_at":"2017-09-19T21:48:05Z","updated_at":"2017-09-19T21:48:05Z","pushed_at":"2017-12-28T19:49:25Z","git_url":"git://github.com/GrigoryBartosh/JavaHW.git","ssh_url":"[email protected]:GrigoryBartosh/JavaHW.git","clone_url":"https://github.com/GrigoryBartosh/JavaHW.git","svn_url":"https://github.com/GrigoryBartosh/JavaHW","homepage":null,"size":366,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":25,"license":null,"forks":0,"open_issues":25,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GrigoryBartosh/JavaHW/pulls/18"},"html":{"href":"https://github.com/GrigoryBartosh/JavaHW/pull/18"},"issue":{"href":"https://api.github.com/repos/GrigoryBartosh/JavaHW/issues/18"},"comments":{"href":"https://api.github.com/repos/GrigoryBartosh/JavaHW/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/GrigoryBartosh/JavaHW/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/GrigoryBartosh/JavaHW/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GrigoryBartosh/JavaHW/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/GrigoryBartosh/JavaHW/statuses/3ed746f2e76a72c5fb07835e7687007020b1fc1d"}},"author_association":"OWNER"}} | {
"id": 104132555,
"name": "GrigoryBartosh/JavaHW",
"url": "https://api.github.com/repos/GrigoryBartosh/JavaHW"
} | {
"id": 706768,
"login": "yurii-litvinov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/706768?",
"url": "https://api.github.com/users/yurii-litvinov"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-12-29T04:34:24 | 7039290822 | {"actor":{"display_login":"yurii-litvinov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/d-staehler/snc-backend-rails/pulls/comments/114041026","pull_request_review_id":35484381,"id":114041026,"diff_hunk":"@@ -0,0 +1,20 @@\n+class Scraper","path":"app/services/scraper.rb","position":1,"original_position":1,"commit_id":"6f3f2f7b94006abe7dbba30e48ba2b607a36db5f","original_commit_id":"6f3f2f7b94006abe7dbba30e48ba2b607a36db5f","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars3.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Missing top-level class documentation comment.<br>Missing frozen string literal comment.","created_at":"2017-04-29T00:42:43Z","updated_at":"2017-04-29T00:42:43Z","html_url":"https://github.com/d-staehler/snc-backend-rails/pull/22#discussion_r114041026","pull_request_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/d-staehler/snc-backend-rails/pulls/comments/114041026"},"html":{"href":"https://github.com/d-staehler/snc-backend-rails/pull/22#discussion_r114041026"},"pull_request":{"href":"https://api.github.com/repos/d-staehler/snc-backend-rails/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/d-staehler/snc-backend-rails/pulls/22","id":118255791,"html_url":"https://github.com/d-staehler/snc-backend-rails/pull/22","diff_url":"https://github.com/d-staehler/snc-backend-rails/pull/22.diff","patch_url":"https://github.com/d-staehler/snc-backend-rails/pull/22.patch","issue_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/issues/22","number":22,"state":"open","locked":false,"title":"Feature/scraper","user":{"login":"d-staehler","id":6433907,"avatar_url":"https://avatars0.githubusercontent.com/u/6433907?v=3","gravatar_id":"","url":"https://api.github.com/users/d-staehler","html_url":"https://github.com/d-staehler","followers_url":"https://api.github.com/users/d-staehler/followers","following_url":"https://api.github.com/users/d-staehler/following{/other_user}","gists_url":"https://api.github.com/users/d-staehler/gists{/gist_id}","starred_url":"https://api.github.com/users/d-staehler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-staehler/subscriptions","organizations_url":"https://api.github.com/users/d-staehler/orgs","repos_url":"https://api.github.com/users/d-staehler/repos","events_url":"https://api.github.com/users/d-staehler/events{/privacy}","received_events_url":"https://api.github.com/users/d-staehler/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-29T00:42:32Z","updated_at":"2017-04-29T00:42:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3e7c9f3414f09d47b6427e2df1d676a1c5dbf33","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/pulls/22/commits","review_comments_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/pulls/22/comments","review_comment_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/issues/22/comments","statuses_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/statuses/6f3f2f7b94006abe7dbba30e48ba2b607a36db5f","head":{"label":"d-staehler:feature/scraper","ref":"feature/scraper","sha":"6f3f2f7b94006abe7dbba30e48ba2b607a36db5f","user":{"login":"d-staehler","id":6433907,"avatar_url":"https://avatars0.githubusercontent.com/u/6433907?v=3","gravatar_id":"","url":"https://api.github.com/users/d-staehler","html_url":"https://github.com/d-staehler","followers_url":"https://api.github.com/users/d-staehler/followers","following_url":"https://api.github.com/users/d-staehler/following{/other_user}","gists_url":"https://api.github.com/users/d-staehler/gists{/gist_id}","starred_url":"https://api.github.com/users/d-staehler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-staehler/subscriptions","organizations_url":"https://api.github.com/users/d-staehler/orgs","repos_url":"https://api.github.com/users/d-staehler/repos","events_url":"https://api.github.com/users/d-staehler/events{/privacy}","received_events_url":"https://api.github.com/users/d-staehler/received_events","type":"User","site_admin":false},"repo":{"id":86550002,"name":"snc-backend-rails","full_name":"d-staehler/snc-backend-rails","owner":{"login":"d-staehler","id":6433907,"avatar_url":"https://avatars0.githubusercontent.com/u/6433907?v=3","gravatar_id":"","url":"https://api.github.com/users/d-staehler","html_url":"https://github.com/d-staehler","followers_url":"https://api.github.com/users/d-staehler/followers","following_url":"https://api.github.com/users/d-staehler/following{/other_user}","gists_url":"https://api.github.com/users/d-staehler/gists{/gist_id}","starred_url":"https://api.github.com/users/d-staehler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-staehler/subscriptions","organizations_url":"https://api.github.com/users/d-staehler/orgs","repos_url":"https://api.github.com/users/d-staehler/repos","events_url":"https://api.github.com/users/d-staehler/events{/privacy}","received_events_url":"https://api.github.com/users/d-staehler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d-staehler/snc-backend-rails","description":null,"fork":false,"url":"https://api.github.com/repos/d-staehler/snc-backend-rails","forks_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/forks","keys_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/teams","hooks_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/hooks","issue_events_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/issues/events{/number}","events_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/events","assignees_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/assignees{/user}","branches_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/branches{/branch}","tags_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/tags","blobs_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/languages","stargazers_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/stargazers","contributors_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/contributors","subscribers_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/subscribers","subscription_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/subscription","commits_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/contents/{+path}","compare_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/merges","archive_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/downloads","issues_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/issues{/number}","pulls_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/labels{/name}","releases_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/releases{/id}","deployments_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/deployments","created_at":"2017-03-29T07:11:55Z","updated_at":"2017-03-29T07:19:53Z","pushed_at":"2017-04-29T00:42:33Z","git_url":"git://github.com/d-staehler/snc-backend-rails.git","ssh_url":"[email protected]:d-staehler/snc-backend-rails.git","clone_url":"https://github.com/d-staehler/snc-backend-rails.git","svn_url":"https://github.com/d-staehler/snc-backend-rails","homepage":null,"size":62,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":0,"default_branch":"develop"}},"base":{"label":"d-staehler:develop","ref":"develop","sha":"f9dfeecce605af0ca6523a62af9360dfc1be085b","user":{"login":"d-staehler","id":6433907,"avatar_url":"https://avatars0.githubusercontent.com/u/6433907?v=3","gravatar_id":"","url":"https://api.github.com/users/d-staehler","html_url":"https://github.com/d-staehler","followers_url":"https://api.github.com/users/d-staehler/followers","following_url":"https://api.github.com/users/d-staehler/following{/other_user}","gists_url":"https://api.github.com/users/d-staehler/gists{/gist_id}","starred_url":"https://api.github.com/users/d-staehler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-staehler/subscriptions","organizations_url":"https://api.github.com/users/d-staehler/orgs","repos_url":"https://api.github.com/users/d-staehler/repos","events_url":"https://api.github.com/users/d-staehler/events{/privacy}","received_events_url":"https://api.github.com/users/d-staehler/received_events","type":"User","site_admin":false},"repo":{"id":86550002,"name":"snc-backend-rails","full_name":"d-staehler/snc-backend-rails","owner":{"login":"d-staehler","id":6433907,"avatar_url":"https://avatars0.githubusercontent.com/u/6433907?v=3","gravatar_id":"","url":"https://api.github.com/users/d-staehler","html_url":"https://github.com/d-staehler","followers_url":"https://api.github.com/users/d-staehler/followers","following_url":"https://api.github.com/users/d-staehler/following{/other_user}","gists_url":"https://api.github.com/users/d-staehler/gists{/gist_id}","starred_url":"https://api.github.com/users/d-staehler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-staehler/subscriptions","organizations_url":"https://api.github.com/users/d-staehler/orgs","repos_url":"https://api.github.com/users/d-staehler/repos","events_url":"https://api.github.com/users/d-staehler/events{/privacy}","received_events_url":"https://api.github.com/users/d-staehler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d-staehler/snc-backend-rails","description":null,"fork":false,"url":"https://api.github.com/repos/d-staehler/snc-backend-rails","forks_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/forks","keys_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/teams","hooks_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/hooks","issue_events_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/issues/events{/number}","events_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/events","assignees_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/assignees{/user}","branches_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/branches{/branch}","tags_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/tags","blobs_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/languages","stargazers_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/stargazers","contributors_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/contributors","subscribers_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/subscribers","subscription_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/subscription","commits_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/contents/{+path}","compare_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/merges","archive_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/downloads","issues_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/issues{/number}","pulls_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/labels{/name}","releases_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/releases{/id}","deployments_url":"https://api.github.com/repos/d-staehler/snc-backend-rails/deployments","created_at":"2017-03-29T07:11:55Z","updated_at":"2017-03-29T07:19:53Z","pushed_at":"2017-04-29T00:42:33Z","git_url":"git://github.com/d-staehler/snc-backend-rails.git","ssh_url":"[email protected]:d-staehler/snc-backend-rails.git","clone_url":"https://github.com/d-staehler/snc-backend-rails.git","svn_url":"https://github.com/d-staehler/snc-backend-rails","homepage":null,"size":62,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/d-staehler/snc-backend-rails/pulls/22"},"html":{"href":"https://github.com/d-staehler/snc-backend-rails/pull/22"},"issue":{"href":"https://api.github.com/repos/d-staehler/snc-backend-rails/issues/22"},"comments":{"href":"https://api.github.com/repos/d-staehler/snc-backend-rails/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/d-staehler/snc-backend-rails/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/d-staehler/snc-backend-rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d-staehler/snc-backend-rails/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/d-staehler/snc-backend-rails/statuses/6f3f2f7b94006abe7dbba30e48ba2b607a36db5f"}}}} | {
"id": 86550002,
"name": "d-staehler/snc-backend-rails",
"url": "https://api.github.com/repos/d-staehler/snc-backend-rails"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-04-29T00:42:43 | 5780457663 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/fxfactorial/silicondzor/pulls/comments/96126067","pull_request_review_id":16703741,"id":96126067,"diff_hunk":"@@ -100,26 +155,29 @@ setInterval(() => {\n console.log(res.error);\n return;\n }\n-\n res.data.forEach(each => {\n const start = (new Date(each.start_time)).getTime();\n- db_promises\n- .run(`\n- insert or replace into event values \n- ($title, $all_day, $start, $end, $description, $creator, $url, $id)`, {\n- $title: each.name,\n- $all_day: !each.end_time || each.start_time === each.end_time,\n- $start: start,\n- $end: each.end_time ? (new Date(each.end_time)).getTime() : start,\n- $description: each.description,\n- $creator: group_name,\n- $url: `https://facebook.com/events/${each.id}`,\n- $id: `fb-${each.id}`\n- });\n+ let title = translateAll(each.name);\n+ title.then((title) => {\n+ console.log(title);\n+ db_promises\n+ .run(`\n+ insert or replace into event values\n+ ($title, $all_day, $start, $end, $description, $creator, $url, $id)`, {\n+ $title: title,\n+ $all_day: !each.end_time || each.start_time === each.end_time,\n+ $start: start,\n+ $end: each.end_time ? (new Date(each.end_time)).getTime() : start,\n+ $description: each.description,\n+ $creator: group_name,\n+ $url: `https://facebook.com/events/${each.id}`,\n+ $id: `fb-${each.id}`\n+ });\n+ })\n });\n });\n }\n-}, 60 * 1000 * 60 * 48);\n+}, 5 * 1000);","path":"backend/server.js","position":129,"original_position":129,"commit_id":"47ebe4924a4e374c0013bec7b58b8b85160ba286","original_commit_id":"47ebe4924a4e374c0013bec7b58b8b85160ba286","user":{"login":"fxfactorial","id":3036816,"avatar_url":"https://avatars.githubusercontent.com/u/3036816?v=3","gravatar_id":"","url":"https://api.github.com/users/fxfactorial","html_url":"https://github.com/fxfactorial","followers_url":"https://api.github.com/users/fxfactorial/followers","following_url":"https://api.github.com/users/fxfactorial/following{/other_user}","gists_url":"https://api.github.com/users/fxfactorial/gists{/gist_id}","starred_url":"https://api.github.com/users/fxfactorial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxfactorial/subscriptions","organizations_url":"https://api.github.com/users/fxfactorial/orgs","repos_url":"https://api.github.com/users/fxfactorial/repos","events_url":"https://api.github.com/users/fxfactorial/events{/privacy}","received_events_url":"https://api.github.com/users/fxfactorial/received_events","type":"User","site_admin":false},"body":"Now running every 5 seconds, be careful not to leave debug code in commits :) ","created_at":"2017-01-14T22:40:45Z","updated_at":"2017-01-14T22:40:45Z","html_url":"https://github.com/fxfactorial/silicondzor/pull/29#discussion_r96126067","pull_request_url":"https://api.github.com/repos/fxfactorial/silicondzor/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/fxfactorial/silicondzor/pulls/comments/96126067"},"html":{"href":"https://github.com/fxfactorial/silicondzor/pull/29#discussion_r96126067"},"pull_request":{"href":"https://api.github.com/repos/fxfactorial/silicondzor/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/fxfactorial/silicondzor/pulls/29","id":101577104,"html_url":"https://github.com/fxfactorial/silicondzor/pull/29","diff_url":"https://github.com/fxfactorial/silicondzor/pull/29.diff","patch_url":"https://github.com/fxfactorial/silicondzor/pull/29.patch","issue_url":"https://api.github.com/repos/fxfactorial/silicondzor/issues/29","number":29,"state":"open","locked":false,"title":"adding YandexAPI to server for translating event titles","user":{"login":"edgarkhanzadyan","id":22010816,"avatar_url":"https://avatars.githubusercontent.com/u/22010816?v=3","gravatar_id":"","url":"https://api.github.com/users/edgarkhanzadyan","html_url":"https://github.com/edgarkhanzadyan","followers_url":"https://api.github.com/users/edgarkhanzadyan/followers","following_url":"https://api.github.com/users/edgarkhanzadyan/following{/other_user}","gists_url":"https://api.github.com/users/edgarkhanzadyan/gists{/gist_id}","starred_url":"https://api.github.com/users/edgarkhanzadyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgarkhanzadyan/subscriptions","organizations_url":"https://api.github.com/users/edgarkhanzadyan/orgs","repos_url":"https://api.github.com/users/edgarkhanzadyan/repos","events_url":"https://api.github.com/users/edgarkhanzadyan/events{/privacy}","received_events_url":"https://api.github.com/users/edgarkhanzadyan/received_events","type":"User","site_admin":false},"body":"Added Yandex translator API, s.t. now silicondzor will translate all event titles which were fetched from FB groups. Still have to add that feature to the situations when a person manually add new event.","created_at":"2017-01-14T22:31:05Z","updated_at":"2017-01-14T22:40:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"765537b897f707415b94d9d4f9429f8559530a31","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fxfactorial/silicondzor/pulls/29/commits","review_comments_url":"https://api.github.com/repos/fxfactorial/silicondzor/pulls/29/comments","review_comment_url":"https://api.github.com/repos/fxfactorial/silicondzor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fxfactorial/silicondzor/issues/29/comments","statuses_url":"https://api.github.com/repos/fxfactorial/silicondzor/statuses/47ebe4924a4e374c0013bec7b58b8b85160ba286","head":{"label":"edgarkhanzadyan:master","ref":"master","sha":"47ebe4924a4e374c0013bec7b58b8b85160ba286","user":{"login":"edgarkhanzadyan","id":22010816,"avatar_url":"https://avatars.githubusercontent.com/u/22010816?v=3","gravatar_id":"","url":"https://api.github.com/users/edgarkhanzadyan","html_url":"https://github.com/edgarkhanzadyan","followers_url":"https://api.github.com/users/edgarkhanzadyan/followers","following_url":"https://api.github.com/users/edgarkhanzadyan/following{/other_user}","gists_url":"https://api.github.com/users/edgarkhanzadyan/gists{/gist_id}","starred_url":"https://api.github.com/users/edgarkhanzadyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgarkhanzadyan/subscriptions","organizations_url":"https://api.github.com/users/edgarkhanzadyan/orgs","repos_url":"https://api.github.com/users/edgarkhanzadyan/repos","events_url":"https://api.github.com/users/edgarkhanzadyan/events{/privacy}","received_events_url":"https://api.github.com/users/edgarkhanzadyan/received_events","type":"User","site_admin":false},"repo":{"id":78970345,"name":"silicondzor","full_name":"edgarkhanzadyan/silicondzor","owner":{"login":"edgarkhanzadyan","id":22010816,"avatar_url":"https://avatars.githubusercontent.com/u/22010816?v=3","gravatar_id":"","url":"https://api.github.com/users/edgarkhanzadyan","html_url":"https://github.com/edgarkhanzadyan","followers_url":"https://api.github.com/users/edgarkhanzadyan/followers","following_url":"https://api.github.com/users/edgarkhanzadyan/following{/other_user}","gists_url":"https://api.github.com/users/edgarkhanzadyan/gists{/gist_id}","starred_url":"https://api.github.com/users/edgarkhanzadyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgarkhanzadyan/subscriptions","organizations_url":"https://api.github.com/users/edgarkhanzadyan/orgs","repos_url":"https://api.github.com/users/edgarkhanzadyan/repos","events_url":"https://api.github.com/users/edgarkhanzadyan/events{/privacy}","received_events_url":"https://api.github.com/users/edgarkhanzadyan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edgarkhanzadyan/silicondzor","description":"See all the tech events for Armenia in one central place!","fork":true,"url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor","forks_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/forks","keys_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/teams","hooks_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/hooks","issue_events_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/issues/events{/number}","events_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/events","assignees_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/assignees{/user}","branches_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/branches{/branch}","tags_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/tags","blobs_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/git/refs{/sha}","trees_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/statuses/{sha}","languages_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/languages","stargazers_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/stargazers","contributors_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/contributors","subscribers_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/subscribers","subscription_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/subscription","commits_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/commits{/sha}","git_commits_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/git/commits{/sha}","comments_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/comments{/number}","issue_comment_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/issues/comments{/number}","contents_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/contents/{+path}","compare_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/merges","archive_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/downloads","issues_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/issues{/number}","pulls_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/pulls{/number}","milestones_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/milestones{/number}","notifications_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/labels{/name}","releases_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/releases{/id}","deployments_url":"https://api.github.com/repos/edgarkhanzadyan/silicondzor/deployments","created_at":"2017-01-14T22:25:52Z","updated_at":"2017-01-14T22:25:55Z","pushed_at":"2017-01-14T22:28:18Z","git_url":"git://github.com/edgarkhanzadyan/silicondzor.git","ssh_url":"[email protected]:edgarkhanzadyan/silicondzor.git","clone_url":"https://github.com/edgarkhanzadyan/silicondzor.git","svn_url":"https://github.com/edgarkhanzadyan/silicondzor","homepage":"https://silicondzor.com","size":91,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fxfactorial:master","ref":"master","sha":"0e6bca186e737a56ba253e923655e837ce0a9616","user":{"login":"fxfactorial","id":3036816,"avatar_url":"https://avatars.githubusercontent.com/u/3036816?v=3","gravatar_id":"","url":"https://api.github.com/users/fxfactorial","html_url":"https://github.com/fxfactorial","followers_url":"https://api.github.com/users/fxfactorial/followers","following_url":"https://api.github.com/users/fxfactorial/following{/other_user}","gists_url":"https://api.github.com/users/fxfactorial/gists{/gist_id}","starred_url":"https://api.github.com/users/fxfactorial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxfactorial/subscriptions","organizations_url":"https://api.github.com/users/fxfactorial/orgs","repos_url":"https://api.github.com/users/fxfactorial/repos","events_url":"https://api.github.com/users/fxfactorial/events{/privacy}","received_events_url":"https://api.github.com/users/fxfactorial/received_events","type":"User","site_admin":false},"repo":{"id":75319558,"name":"silicondzor","full_name":"fxfactorial/silicondzor","owner":{"login":"fxfactorial","id":3036816,"avatar_url":"https://avatars.githubusercontent.com/u/3036816?v=3","gravatar_id":"","url":"https://api.github.com/users/fxfactorial","html_url":"https://github.com/fxfactorial","followers_url":"https://api.github.com/users/fxfactorial/followers","following_url":"https://api.github.com/users/fxfactorial/following{/other_user}","gists_url":"https://api.github.com/users/fxfactorial/gists{/gist_id}","starred_url":"https://api.github.com/users/fxfactorial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxfactorial/subscriptions","organizations_url":"https://api.github.com/users/fxfactorial/orgs","repos_url":"https://api.github.com/users/fxfactorial/repos","events_url":"https://api.github.com/users/fxfactorial/events{/privacy}","received_events_url":"https://api.github.com/users/fxfactorial/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fxfactorial/silicondzor","description":"See all the tech events for Armenia in one central place!","fork":false,"url":"https://api.github.com/repos/fxfactorial/silicondzor","forks_url":"https://api.github.com/repos/fxfactorial/silicondzor/forks","keys_url":"https://api.github.com/repos/fxfactorial/silicondzor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fxfactorial/silicondzor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fxfactorial/silicondzor/teams","hooks_url":"https://api.github.com/repos/fxfactorial/silicondzor/hooks","issue_events_url":"https://api.github.com/repos/fxfactorial/silicondzor/issues/events{/number}","events_url":"https://api.github.com/repos/fxfactorial/silicondzor/events","assignees_url":"https://api.github.com/repos/fxfactorial/silicondzor/assignees{/user}","branches_url":"https://api.github.com/repos/fxfactorial/silicondzor/branches{/branch}","tags_url":"https://api.github.com/repos/fxfactorial/silicondzor/tags","blobs_url":"https://api.github.com/repos/fxfactorial/silicondzor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fxfactorial/silicondzor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fxfactorial/silicondzor/git/refs{/sha}","trees_url":"https://api.github.com/repos/fxfactorial/silicondzor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fxfactorial/silicondzor/statuses/{sha}","languages_url":"https://api.github.com/repos/fxfactorial/silicondzor/languages","stargazers_url":"https://api.github.com/repos/fxfactorial/silicondzor/stargazers","contributors_url":"https://api.github.com/repos/fxfactorial/silicondzor/contributors","subscribers_url":"https://api.github.com/repos/fxfactorial/silicondzor/subscribers","subscription_url":"https://api.github.com/repos/fxfactorial/silicondzor/subscription","commits_url":"https://api.github.com/repos/fxfactorial/silicondzor/commits{/sha}","git_commits_url":"https://api.github.com/repos/fxfactorial/silicondzor/git/commits{/sha}","comments_url":"https://api.github.com/repos/fxfactorial/silicondzor/comments{/number}","issue_comment_url":"https://api.github.com/repos/fxfactorial/silicondzor/issues/comments{/number}","contents_url":"https://api.github.com/repos/fxfactorial/silicondzor/contents/{+path}","compare_url":"https://api.github.com/repos/fxfactorial/silicondzor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fxfactorial/silicondzor/merges","archive_url":"https://api.github.com/repos/fxfactorial/silicondzor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fxfactorial/silicondzor/downloads","issues_url":"https://api.github.com/repos/fxfactorial/silicondzor/issues{/number}","pulls_url":"https://api.github.com/repos/fxfactorial/silicondzor/pulls{/number}","milestones_url":"https://api.github.com/repos/fxfactorial/silicondzor/milestones{/number}","notifications_url":"https://api.github.com/repos/fxfactorial/silicondzor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fxfactorial/silicondzor/labels{/name}","releases_url":"https://api.github.com/repos/fxfactorial/silicondzor/releases{/id}","deployments_url":"https://api.github.com/repos/fxfactorial/silicondzor/deployments","created_at":"2016-12-01T18:14:12Z","updated_at":"2017-01-12T19:35:58Z","pushed_at":"2017-01-14T22:31:05Z","git_url":"git://github.com/fxfactorial/silicondzor.git","ssh_url":"[email protected]:fxfactorial/silicondzor.git","clone_url":"https://github.com/fxfactorial/silicondzor.git","svn_url":"https://github.com/fxfactorial/silicondzor","homepage":"https://silicondzor.com","size":91,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":17,"forks":5,"open_issues":17,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fxfactorial/silicondzor/pulls/29"},"html":{"href":"https://github.com/fxfactorial/silicondzor/pull/29"},"issue":{"href":"https://api.github.com/repos/fxfactorial/silicondzor/issues/29"},"comments":{"href":"https://api.github.com/repos/fxfactorial/silicondzor/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/fxfactorial/silicondzor/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/fxfactorial/silicondzor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fxfactorial/silicondzor/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/fxfactorial/silicondzor/statuses/47ebe4924a4e374c0013bec7b58b8b85160ba286"}}}} | {
"id": 75319558,
"name": "fxfactorial/silicondzor",
"url": "https://api.github.com/repos/fxfactorial/silicondzor"
} | {
"id": 3036816,
"login": "fxfactorial",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3036816?",
"url": "https://api.github.com/users/fxfactorial"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-01-14T22:40:45 | 5154419815 | {"actor":{"display_login":"fxfactorial"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tunya/react-mp17/pulls/comments/139887660","pull_request_review_id":63880757,"id":139887660,"diff_hunk":"@@ -0,0 +1,60 @@\n+import React from 'react';\n+import PropTypes from 'prop-types';\n+import Search from './../Search/Search';\n+import Movie from './../Movie/Movie';\n+import styles from './Header.scss';\n+\n+function Header(props) {\n+ let content = '';","path":"app/src/components/Header/Header.jsx","position":null,"original_position":8,"commit_id":"2f9930323e860e1eaf8b28d55bce3fe044092a13","original_commit_id":"b693e5b0b399f8a86c3541dc3a96641dd58b20f9","user":{"login":"tunya","id":13644147,"avatar_url":"https://avatars1.githubusercontent.com/u/13644147?v=4","gravatar_id":"","url":"https://api.github.com/users/tunya","html_url":"https://github.com/tunya","followers_url":"https://api.github.com/users/tunya/followers","following_url":"https://api.github.com/users/tunya/following{/other_user}","gists_url":"https://api.github.com/users/tunya/gists{/gist_id}","starred_url":"https://api.github.com/users/tunya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tunya/subscriptions","organizations_url":"https://api.github.com/users/tunya/orgs","repos_url":"https://api.github.com/users/tunya/repos","events_url":"https://api.github.com/users/tunya/events{/privacy}","received_events_url":"https://api.github.com/users/tunya/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2017-09-20T06:52:16Z","updated_at":"2017-09-20T06:52:17Z","html_url":"https://github.com/tunya/react-mp17/pull/2#discussion_r139887660","pull_request_url":"https://api.github.com/repos/tunya/react-mp17/pulls/2","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/tunya/react-mp17/pulls/comments/139887660"},"html":{"href":"https://github.com/tunya/react-mp17/pull/2#discussion_r139887660"},"pull_request":{"href":"https://api.github.com/repos/tunya/react-mp17/pulls/2"}},"in_reply_to_id":139845736},"pull_request":{"url":"https://api.github.com/repos/tunya/react-mp17/pulls/2","id":141768788,"html_url":"https://github.com/tunya/react-mp17/pull/2","diff_url":"https://github.com/tunya/react-mp17/pull/2.diff","patch_url":"https://github.com/tunya/react-mp17/pull/2.patch","issue_url":"https://api.github.com/repos/tunya/react-mp17/issues/2","number":2,"state":"open","locked":false,"title":"Hw 02/layout","user":{"login":"tunya","id":13644147,"avatar_url":"https://avatars1.githubusercontent.com/u/13644147?v=4","gravatar_id":"","url":"https://api.github.com/users/tunya","html_url":"https://github.com/tunya","followers_url":"https://api.github.com/users/tunya/followers","following_url":"https://api.github.com/users/tunya/following{/other_user}","gists_url":"https://api.github.com/users/tunya/gists{/gist_id}","starred_url":"https://api.github.com/users/tunya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tunya/subscriptions","organizations_url":"https://api.github.com/users/tunya/orgs","repos_url":"https://api.github.com/users/tunya/repos","events_url":"https://api.github.com/users/tunya/events{/privacy}","received_events_url":"https://api.github.com/users/tunya/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-19T06:43:16Z","updated_at":"2017-09-20T06:52:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aefcd443772a6d0c639e54946066379f301c54fb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tunya/react-mp17/pulls/2/commits","review_comments_url":"https://api.github.com/repos/tunya/react-mp17/pulls/2/comments","review_comment_url":"https://api.github.com/repos/tunya/react-mp17/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tunya/react-mp17/issues/2/comments","statuses_url":"https://api.github.com/repos/tunya/react-mp17/statuses/2f9930323e860e1eaf8b28d55bce3fe044092a13","head":{"label":"tunya:HW-02/layout","ref":"HW-02/layout","sha":"2f9930323e860e1eaf8b28d55bce3fe044092a13","user":{"login":"tunya","id":13644147,"avatar_url":"https://avatars1.githubusercontent.com/u/13644147?v=4","gravatar_id":"","url":"https://api.github.com/users/tunya","html_url":"https://github.com/tunya","followers_url":"https://api.github.com/users/tunya/followers","following_url":"https://api.github.com/users/tunya/following{/other_user}","gists_url":"https://api.github.com/users/tunya/gists{/gist_id}","starred_url":"https://api.github.com/users/tunya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tunya/subscriptions","organizations_url":"https://api.github.com/users/tunya/orgs","repos_url":"https://api.github.com/users/tunya/repos","events_url":"https://api.github.com/users/tunya/events{/privacy}","received_events_url":"https://api.github.com/users/tunya/received_events","type":"User","site_admin":false},"repo":{"id":102988443,"name":"react-mp17","full_name":"tunya/react-mp17","owner":{"login":"tunya","id":13644147,"avatar_url":"https://avatars1.githubusercontent.com/u/13644147?v=4","gravatar_id":"","url":"https://api.github.com/users/tunya","html_url":"https://github.com/tunya","followers_url":"https://api.github.com/users/tunya/followers","following_url":"https://api.github.com/users/tunya/following{/other_user}","gists_url":"https://api.github.com/users/tunya/gists{/gist_id}","starred_url":"https://api.github.com/users/tunya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tunya/subscriptions","organizations_url":"https://api.github.com/users/tunya/orgs","repos_url":"https://api.github.com/users/tunya/repos","events_url":"https://api.github.com/users/tunya/events{/privacy}","received_events_url":"https://api.github.com/users/tunya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tunya/react-mp17","description":"Repository for React Mentoring program 2017","fork":false,"url":"https://api.github.com/repos/tunya/react-mp17","forks_url":"https://api.github.com/repos/tunya/react-mp17/forks","keys_url":"https://api.github.com/repos/tunya/react-mp17/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tunya/react-mp17/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tunya/react-mp17/teams","hooks_url":"https://api.github.com/repos/tunya/react-mp17/hooks","issue_events_url":"https://api.github.com/repos/tunya/react-mp17/issues/events{/number}","events_url":"https://api.github.com/repos/tunya/react-mp17/events","assignees_url":"https://api.github.com/repos/tunya/react-mp17/assignees{/user}","branches_url":"https://api.github.com/repos/tunya/react-mp17/branches{/branch}","tags_url":"https://api.github.com/repos/tunya/react-mp17/tags","blobs_url":"https://api.github.com/repos/tunya/react-mp17/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tunya/react-mp17/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tunya/react-mp17/git/refs{/sha}","trees_url":"https://api.github.com/repos/tunya/react-mp17/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tunya/react-mp17/statuses/{sha}","languages_url":"https://api.github.com/repos/tunya/react-mp17/languages","stargazers_url":"https://api.github.com/repos/tunya/react-mp17/stargazers","contributors_url":"https://api.github.com/repos/tunya/react-mp17/contributors","subscribers_url":"https://api.github.com/repos/tunya/react-mp17/subscribers","subscription_url":"https://api.github.com/repos/tunya/react-mp17/subscription","commits_url":"https://api.github.com/repos/tunya/react-mp17/commits{/sha}","git_commits_url":"https://api.github.com/repos/tunya/react-mp17/git/commits{/sha}","comments_url":"https://api.github.com/repos/tunya/react-mp17/comments{/number}","issue_comment_url":"https://api.github.com/repos/tunya/react-mp17/issues/comments{/number}","contents_url":"https://api.github.com/repos/tunya/react-mp17/contents/{+path}","compare_url":"https://api.github.com/repos/tunya/react-mp17/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tunya/react-mp17/merges","archive_url":"https://api.github.com/repos/tunya/react-mp17/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tunya/react-mp17/downloads","issues_url":"https://api.github.com/repos/tunya/react-mp17/issues{/number}","pulls_url":"https://api.github.com/repos/tunya/react-mp17/pulls{/number}","milestones_url":"https://api.github.com/repos/tunya/react-mp17/milestones{/number}","notifications_url":"https://api.github.com/repos/tunya/react-mp17/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tunya/react-mp17/labels{/name}","releases_url":"https://api.github.com/repos/tunya/react-mp17/releases{/id}","deployments_url":"https://api.github.com/repos/tunya/react-mp17/deployments","created_at":"2017-09-09T22:22:56Z","updated_at":"2017-09-12T04:14:23Z","pushed_at":"2017-09-20T06:49:44Z","git_url":"git://github.com/tunya/react-mp17.git","ssh_url":"[email protected]:tunya/react-mp17.git","clone_url":"https://github.com/tunya/react-mp17.git","svn_url":"https://github.com/tunya/react-mp17","homepage":null,"size":318,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"tunya:master","ref":"master","sha":"fc6ae28f5c9a2ac7181908ea3e4d33fc92787865","user":{"login":"tunya","id":13644147,"avatar_url":"https://avatars1.githubusercontent.com/u/13644147?v=4","gravatar_id":"","url":"https://api.github.com/users/tunya","html_url":"https://github.com/tunya","followers_url":"https://api.github.com/users/tunya/followers","following_url":"https://api.github.com/users/tunya/following{/other_user}","gists_url":"https://api.github.com/users/tunya/gists{/gist_id}","starred_url":"https://api.github.com/users/tunya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tunya/subscriptions","organizations_url":"https://api.github.com/users/tunya/orgs","repos_url":"https://api.github.com/users/tunya/repos","events_url":"https://api.github.com/users/tunya/events{/privacy}","received_events_url":"https://api.github.com/users/tunya/received_events","type":"User","site_admin":false},"repo":{"id":102988443,"name":"react-mp17","full_name":"tunya/react-mp17","owner":{"login":"tunya","id":13644147,"avatar_url":"https://avatars1.githubusercontent.com/u/13644147?v=4","gravatar_id":"","url":"https://api.github.com/users/tunya","html_url":"https://github.com/tunya","followers_url":"https://api.github.com/users/tunya/followers","following_url":"https://api.github.com/users/tunya/following{/other_user}","gists_url":"https://api.github.com/users/tunya/gists{/gist_id}","starred_url":"https://api.github.com/users/tunya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tunya/subscriptions","organizations_url":"https://api.github.com/users/tunya/orgs","repos_url":"https://api.github.com/users/tunya/repos","events_url":"https://api.github.com/users/tunya/events{/privacy}","received_events_url":"https://api.github.com/users/tunya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tunya/react-mp17","description":"Repository for React Mentoring program 2017","fork":false,"url":"https://api.github.com/repos/tunya/react-mp17","forks_url":"https://api.github.com/repos/tunya/react-mp17/forks","keys_url":"https://api.github.com/repos/tunya/react-mp17/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tunya/react-mp17/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tunya/react-mp17/teams","hooks_url":"https://api.github.com/repos/tunya/react-mp17/hooks","issue_events_url":"https://api.github.com/repos/tunya/react-mp17/issues/events{/number}","events_url":"https://api.github.com/repos/tunya/react-mp17/events","assignees_url":"https://api.github.com/repos/tunya/react-mp17/assignees{/user}","branches_url":"https://api.github.com/repos/tunya/react-mp17/branches{/branch}","tags_url":"https://api.github.com/repos/tunya/react-mp17/tags","blobs_url":"https://api.github.com/repos/tunya/react-mp17/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tunya/react-mp17/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tunya/react-mp17/git/refs{/sha}","trees_url":"https://api.github.com/repos/tunya/react-mp17/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tunya/react-mp17/statuses/{sha}","languages_url":"https://api.github.com/repos/tunya/react-mp17/languages","stargazers_url":"https://api.github.com/repos/tunya/react-mp17/stargazers","contributors_url":"https://api.github.com/repos/tunya/react-mp17/contributors","subscribers_url":"https://api.github.com/repos/tunya/react-mp17/subscribers","subscription_url":"https://api.github.com/repos/tunya/react-mp17/subscription","commits_url":"https://api.github.com/repos/tunya/react-mp17/commits{/sha}","git_commits_url":"https://api.github.com/repos/tunya/react-mp17/git/commits{/sha}","comments_url":"https://api.github.com/repos/tunya/react-mp17/comments{/number}","issue_comment_url":"https://api.github.com/repos/tunya/react-mp17/issues/comments{/number}","contents_url":"https://api.github.com/repos/tunya/react-mp17/contents/{+path}","compare_url":"https://api.github.com/repos/tunya/react-mp17/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tunya/react-mp17/merges","archive_url":"https://api.github.com/repos/tunya/react-mp17/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tunya/react-mp17/downloads","issues_url":"https://api.github.com/repos/tunya/react-mp17/issues{/number}","pulls_url":"https://api.github.com/repos/tunya/react-mp17/pulls{/number}","milestones_url":"https://api.github.com/repos/tunya/react-mp17/milestones{/number}","notifications_url":"https://api.github.com/repos/tunya/react-mp17/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tunya/react-mp17/labels{/name}","releases_url":"https://api.github.com/repos/tunya/react-mp17/releases{/id}","deployments_url":"https://api.github.com/repos/tunya/react-mp17/deployments","created_at":"2017-09-09T22:22:56Z","updated_at":"2017-09-12T04:14:23Z","pushed_at":"2017-09-20T06:49:44Z","git_url":"git://github.com/tunya/react-mp17.git","ssh_url":"[email protected]:tunya/react-mp17.git","clone_url":"https://github.com/tunya/react-mp17.git","svn_url":"https://github.com/tunya/react-mp17","homepage":null,"size":318,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tunya/react-mp17/pulls/2"},"html":{"href":"https://github.com/tunya/react-mp17/pull/2"},"issue":{"href":"https://api.github.com/repos/tunya/react-mp17/issues/2"},"comments":{"href":"https://api.github.com/repos/tunya/react-mp17/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/tunya/react-mp17/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/tunya/react-mp17/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tunya/react-mp17/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/tunya/react-mp17/statuses/2f9930323e860e1eaf8b28d55bce3fe044092a13"}},"author_association":"OWNER"}} | {
"id": 102988443,
"name": "tunya/react-mp17",
"url": "https://api.github.com/repos/tunya/react-mp17"
} | {
"id": 13644147,
"login": "tunya",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13644147?",
"url": "https://api.github.com/users/tunya"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-09-20T06:52:16 | 6612869292 | {"actor":{"display_login":"tunya"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/pulls/comments/136926294","pull_request_review_id":60530139,"id":136926294,"diff_hunk":"@@ -204,12 +205,31 @@ def _set_attribute(self, attribute, name, value):\n attribute = self._attribute_file_open( name )\n else:\n attribute.seek(0)\n- attribute.write(value.encode())\n- attribute.flush()\n+\n+ try:\n+ attribute.write(value.encode())\n+ attribute.flush()\n+ except Exception as ex:\n+ self._raise_friendly_access_error(ex, name)\n return attribute\n else:\n raise Exception('Device is not connected')\n \n+ def _raise_friendly_access_error(self, driver_error, attribute):\n+ if not isinstance(driver_error, OSError):\n+ raise driver_error\n+\n+ if driver_error.errno == errno.EINVAL:\n+ if attribute == \"speed_sp\":\n+ try:\n+ max_speed = self.max_speed\n+ except (AttributeError, Exception):\n+ raise ValueError(\"The given speed value was out of range\") from driver_error\n+ else:\n+ raise ValueError(\"The given speed value was out of range. Max speed: +/-\" + str(max_speed)) from driver_error\n+ raise ValueError(\"One or more arguments were out of range or invalid\") from driver_error","path":"ev3dev/core.py","position":36,"original_position":36,"commit_id":"a0f77d44f7890f82c1636919f9f90927ab7af5d7","original_commit_id":"a0f77d44f7890f82c1636919f9f90927ab7af5d7","user":{"login":"ddemidov","id":270503,"avatar_url":"https://avatars0.githubusercontent.com/u/270503?v=4","gravatar_id":"","url":"https://api.github.com/users/ddemidov","html_url":"https://github.com/ddemidov","followers_url":"https://api.github.com/users/ddemidov/followers","following_url":"https://api.github.com/users/ddemidov/following{/other_user}","gists_url":"https://api.github.com/users/ddemidov/gists{/gist_id}","starred_url":"https://api.github.com/users/ddemidov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddemidov/subscriptions","organizations_url":"https://api.github.com/users/ddemidov/orgs","repos_url":"https://api.github.com/users/ddemidov/repos","events_url":"https://api.github.com/users/ddemidov/events{/privacy}","received_events_url":"https://api.github.com/users/ddemidov/received_events","type":"User","site_admin":false},"body":"I mean, what would make the debugging easier?","created_at":"2017-09-05T08:41:23Z","updated_at":"2017-09-05T08:41:23Z","html_url":"https://github.com/rhempel/ev3dev-lang-python/pull/342#discussion_r136926294","pull_request_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/pulls/342","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rhempel/ev3dev-lang-python/pulls/comments/136926294"},"html":{"href":"https://github.com/rhempel/ev3dev-lang-python/pull/342#discussion_r136926294"},"pull_request":{"href":"https://api.github.com/repos/rhempel/ev3dev-lang-python/pulls/342"}},"in_reply_to_id":136926133},"pull_request":{"url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/pulls/342","id":139223992,"html_url":"https://github.com/rhempel/ev3dev-lang-python/pull/342","diff_url":"https://github.com/rhempel/ev3dev-lang-python/pull/342.diff","patch_url":"https://github.com/rhempel/ev3dev-lang-python/pull/342.patch","issue_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/issues/342","number":342,"state":"open","locked":false,"title":"Throw friendly errors","user":{"login":"WasabiFan","id":3310349,"avatar_url":"https://avatars0.githubusercontent.com/u/3310349?v=4","gravatar_id":"","url":"https://api.github.com/users/WasabiFan","html_url":"https://github.com/WasabiFan","followers_url":"https://api.github.com/users/WasabiFan/followers","following_url":"https://api.github.com/users/WasabiFan/following{/other_user}","gists_url":"https://api.github.com/users/WasabiFan/gists{/gist_id}","starred_url":"https://api.github.com/users/WasabiFan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WasabiFan/subscriptions","organizations_url":"https://api.github.com/users/WasabiFan/orgs","repos_url":"https://api.github.com/users/WasabiFan/repos","events_url":"https://api.github.com/users/WasabiFan/events{/privacy}","received_events_url":"https://api.github.com/users/WasabiFan/received_events","type":"User","site_admin":false},"body":"Fixes #331 \r\n\r\nIt would be nice if we were able to adapt the message when you attempt to run for distance with a negative sign, but commands are read-only and I didn't see an easy way to pipe that through. Any suggestions for other properties?\r\n\r\n```\r\nrobot@ev3dev:~$ python3\r\nPython 3.5.3 (default, Jan 19 2017, 14:11:04)\r\n[GCC 6.3.0 20170118] on linux\r\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\r\n>>> import ev3dev.ev3 as ev3\r\n>>> m = ev3.Motor()\r\n>>> m.connected\r\nTrue\r\n>>> m.speed_sp = -100000\r\nTraceback (most recent call last):\r\n File \"/usr/lib/python3/dist-packages/ev3dev/core.py\", line 210, in _set_attribute\r\n attribute.write(value.encode())\r\nOSError: [Errno 22] Invalid argument\r\n\r\nThe above exception was the direct cause of the following exception:\r\n\r\nTraceback (most recent call last):\r\n File \"<stdin>\", line 1, in <module>\r\n File \"/usr/lib/python3/dist-packages/ev3dev/core.py\", line 604, in speed_sp\r\n self._speed_sp = self.set_attr_int(self._speed_sp, 'speed_sp', value)\r\n File \"/usr/lib/python3/dist-packages/ev3dev/core.py\", line 238, in set_attr_int\r\n return self._set_attribute(attribute, name, str(int(value)))\r\n File \"/usr/lib/python3/dist-packages/ev3dev/core.py\", line 213, in _set_attribute\r\n self._raise_friendly_access_error(ex, name)\r\n File \"/usr/lib/python3/dist-packages/ev3dev/core.py\", line 229, in _raise_friendly_access_error\r\n raise ValueError(\"The given speed value was out of range. Max speed: +/-\" + str(max_speed)) from driver_error\r\nValueError: The given speed value was out of range. Max speed: +/-1050\r\n>>> m.speed_sp = 1000000\r\nTraceback (most recent call last):\r\n File \"/usr/lib/python3/dist-packages/ev3dev/core.py\", line 210, in _set_attribute\r\n attribute.write(value.encode())\r\nOSError: [Errno 22] Invalid argument\r\n\r\nThe above exception was the direct cause of the following exception:\r\n\r\nTraceback (most recent call last):\r\n File \"<stdin>\", line 1, in <module>\r\n File \"/usr/lib/python3/dist-packages/ev3dev/core.py\", line 604, in speed_sp\r\n self._speed_sp = self.set_attr_int(self._speed_sp, 'speed_sp', value)\r\n File \"/usr/lib/python3/dist-packages/ev3dev/core.py\", line 238, in set_attr_int\r\n return self._set_attribute(attribute, name, str(int(value)))\r\n File \"/usr/lib/python3/dist-packages/ev3dev/core.py\", line 213, in _set_attribute\r\n self._raise_friendly_access_error(ex, name)\r\n File \"/usr/lib/python3/dist-packages/ev3dev/core.py\", line 229, in _raise_friendly_access_error\r\n raise ValueError(\"The given speed value was out of range. Max speed: +/-\" + str(max_speed)) from driver_error\r\nValueError: The given speed value was out of range. Max speed: +/-1050\r\n```","created_at":"2017-09-05T01:46:22Z","updated_at":"2017-09-05T08:41:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"430aac13ccc858c8df40aa2024c29745a477c1c7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dwalton76","id":468309,"avatar_url":"https://avatars2.githubusercontent.com/u/468309?v=4","gravatar_id":"","url":"https://api.github.com/users/dwalton76","html_url":"https://github.com/dwalton76","followers_url":"https://api.github.com/users/dwalton76/followers","following_url":"https://api.github.com/users/dwalton76/following{/other_user}","gists_url":"https://api.github.com/users/dwalton76/gists{/gist_id}","starred_url":"https://api.github.com/users/dwalton76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwalton76/subscriptions","organizations_url":"https://api.github.com/users/dwalton76/orgs","repos_url":"https://api.github.com/users/dwalton76/repos","events_url":"https://api.github.com/users/dwalton76/events{/privacy}","received_events_url":"https://api.github.com/users/dwalton76/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/pulls/342/commits","review_comments_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/pulls/342/comments","review_comment_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/issues/342/comments","statuses_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/statuses/a0f77d44f7890f82c1636919f9f90927ab7af5d7","head":{"label":"rhempel:throw-friendly-errors","ref":"throw-friendly-errors","sha":"a0f77d44f7890f82c1636919f9f90927ab7af5d7","user":{"login":"rhempel","id":5571620,"avatar_url":"https://avatars3.githubusercontent.com/u/5571620?v=4","gravatar_id":"","url":"https://api.github.com/users/rhempel","html_url":"https://github.com/rhempel","followers_url":"https://api.github.com/users/rhempel/followers","following_url":"https://api.github.com/users/rhempel/following{/other_user}","gists_url":"https://api.github.com/users/rhempel/gists{/gist_id}","starred_url":"https://api.github.com/users/rhempel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhempel/subscriptions","organizations_url":"https://api.github.com/users/rhempel/orgs","repos_url":"https://api.github.com/users/rhempel/repos","events_url":"https://api.github.com/users/rhempel/events{/privacy}","received_events_url":"https://api.github.com/users/rhempel/received_events","type":"User","site_admin":false},"repo":{"id":43603757,"name":"ev3dev-lang-python","full_name":"rhempel/ev3dev-lang-python","owner":{"login":"rhempel","id":5571620,"avatar_url":"https://avatars3.githubusercontent.com/u/5571620?v=4","gravatar_id":"","url":"https://api.github.com/users/rhempel","html_url":"https://github.com/rhempel","followers_url":"https://api.github.com/users/rhempel/followers","following_url":"https://api.github.com/users/rhempel/following{/other_user}","gists_url":"https://api.github.com/users/rhempel/gists{/gist_id}","starred_url":"https://api.github.com/users/rhempel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhempel/subscriptions","organizations_url":"https://api.github.com/users/rhempel/orgs","repos_url":"https://api.github.com/users/rhempel/repos","events_url":"https://api.github.com/users/rhempel/events{/privacy}","received_events_url":"https://api.github.com/users/rhempel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhempel/ev3dev-lang-python","description":"Pure python bindings for ev3dev","fork":false,"url":"https://api.github.com/repos/rhempel/ev3dev-lang-python","forks_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/forks","keys_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/teams","hooks_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/hooks","issue_events_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/issues/events{/number}","events_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/events","assignees_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/assignees{/user}","branches_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/branches{/branch}","tags_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/tags","blobs_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/statuses/{sha}","languages_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/languages","stargazers_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/stargazers","contributors_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/contributors","subscribers_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/subscribers","subscription_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/subscription","commits_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/contents/{+path}","compare_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/merges","archive_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/downloads","issues_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/issues{/number}","pulls_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/pulls{/number}","milestones_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/milestones{/number}","notifications_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/labels{/name}","releases_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/releases{/id}","deployments_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/deployments","created_at":"2015-10-03T15:32:20Z","updated_at":"2017-09-01T07:12:49Z","pushed_at":"2017-09-05T08:41:12Z","git_url":"git://github.com/rhempel/ev3dev-lang-python.git","ssh_url":"[email protected]:rhempel/ev3dev-lang-python.git","clone_url":"https://github.com/rhempel/ev3dev-lang-python.git","svn_url":"https://github.com/rhempel/ev3dev-lang-python","homepage":null,"size":9472,"stargazers_count":109,"watchers_count":109,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":27,"forks":54,"open_issues":27,"watchers":109,"default_branch":"develop"}},"base":{"label":"rhempel:develop","ref":"develop","sha":"00366370765af0c1df7a46aa74417aa9616d018f","user":{"login":"rhempel","id":5571620,"avatar_url":"https://avatars3.githubusercontent.com/u/5571620?v=4","gravatar_id":"","url":"https://api.github.com/users/rhempel","html_url":"https://github.com/rhempel","followers_url":"https://api.github.com/users/rhempel/followers","following_url":"https://api.github.com/users/rhempel/following{/other_user}","gists_url":"https://api.github.com/users/rhempel/gists{/gist_id}","starred_url":"https://api.github.com/users/rhempel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhempel/subscriptions","organizations_url":"https://api.github.com/users/rhempel/orgs","repos_url":"https://api.github.com/users/rhempel/repos","events_url":"https://api.github.com/users/rhempel/events{/privacy}","received_events_url":"https://api.github.com/users/rhempel/received_events","type":"User","site_admin":false},"repo":{"id":43603757,"name":"ev3dev-lang-python","full_name":"rhempel/ev3dev-lang-python","owner":{"login":"rhempel","id":5571620,"avatar_url":"https://avatars3.githubusercontent.com/u/5571620?v=4","gravatar_id":"","url":"https://api.github.com/users/rhempel","html_url":"https://github.com/rhempel","followers_url":"https://api.github.com/users/rhempel/followers","following_url":"https://api.github.com/users/rhempel/following{/other_user}","gists_url":"https://api.github.com/users/rhempel/gists{/gist_id}","starred_url":"https://api.github.com/users/rhempel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhempel/subscriptions","organizations_url":"https://api.github.com/users/rhempel/orgs","repos_url":"https://api.github.com/users/rhempel/repos","events_url":"https://api.github.com/users/rhempel/events{/privacy}","received_events_url":"https://api.github.com/users/rhempel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhempel/ev3dev-lang-python","description":"Pure python bindings for ev3dev","fork":false,"url":"https://api.github.com/repos/rhempel/ev3dev-lang-python","forks_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/forks","keys_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/teams","hooks_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/hooks","issue_events_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/issues/events{/number}","events_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/events","assignees_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/assignees{/user}","branches_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/branches{/branch}","tags_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/tags","blobs_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/statuses/{sha}","languages_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/languages","stargazers_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/stargazers","contributors_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/contributors","subscribers_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/subscribers","subscription_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/subscription","commits_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/contents/{+path}","compare_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/merges","archive_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/downloads","issues_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/issues{/number}","pulls_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/pulls{/number}","milestones_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/milestones{/number}","notifications_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/labels{/name}","releases_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/releases{/id}","deployments_url":"https://api.github.com/repos/rhempel/ev3dev-lang-python/deployments","created_at":"2015-10-03T15:32:20Z","updated_at":"2017-09-01T07:12:49Z","pushed_at":"2017-09-05T08:41:12Z","git_url":"git://github.com/rhempel/ev3dev-lang-python.git","ssh_url":"[email protected]:rhempel/ev3dev-lang-python.git","clone_url":"https://github.com/rhempel/ev3dev-lang-python.git","svn_url":"https://github.com/rhempel/ev3dev-lang-python","homepage":null,"size":9472,"stargazers_count":109,"watchers_count":109,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":27,"forks":54,"open_issues":27,"watchers":109,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/rhempel/ev3dev-lang-python/pulls/342"},"html":{"href":"https://github.com/rhempel/ev3dev-lang-python/pull/342"},"issue":{"href":"https://api.github.com/repos/rhempel/ev3dev-lang-python/issues/342"},"comments":{"href":"https://api.github.com/repos/rhempel/ev3dev-lang-python/issues/342/comments"},"review_comments":{"href":"https://api.github.com/repos/rhempel/ev3dev-lang-python/pulls/342/comments"},"review_comment":{"href":"https://api.github.com/repos/rhempel/ev3dev-lang-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rhempel/ev3dev-lang-python/pulls/342/commits"},"statuses":{"href":"https://api.github.com/repos/rhempel/ev3dev-lang-python/statuses/a0f77d44f7890f82c1636919f9f90927ab7af5d7"}},"author_association":"COLLABORATOR"}} | {
"id": 43603757,
"name": "rhempel/ev3dev-lang-python",
"url": "https://api.github.com/repos/rhempel/ev3dev-lang-python"
} | {
"id": 270503,
"login": "ddemidov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/270503?",
"url": "https://api.github.com/users/ddemidov"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-09-05T08:41:23 | 6549837987 | {"actor":{"display_login":"ddemidov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ravimeda/corefx/pulls/comments/110978212","pull_request_review_id":32188760,"id":110978212,"diff_hunk":"@@ -0,0 +1,101 @@\n+#!/usr/bin/env bash\n+\n+usage()\n+{\n+ echo \"usage: $0 <repository-root> <tool-name> <override-scripts-folder-path> [strict-tool-version-match]\"\n+ echo \" repository-root: Path to repository root.\"\n+ echo \" tool-name: Name of the tool to search.\"\n+ echo \" override-scripts-folder-path: This argument is ignored.\"\n+ echo \" (Optional) strict-tool-version-match: If equals to \\\"strict\\\" then, search will ensure that the version of the tool searched is the declared version.\"\n+ echo \" Otherwise, search will attempt to find a version of the tool, which may not be the declared version.\"\n+ echo \"\"\n+ echo \"Searches for the tool in the environment path, and a path specified for the tool in the .toolversions file.\"\n+ echo \"If search is successful then, returns the path to the tool.\"\n+ echo \"Exit 1 if search fails to find the tool.\"\n+}\n+\n+if [ $# -lt 3 ]; then\n+ usage\n+ exit 1\n+fi\n+\n+if [ -z \"$1\" ]; then\n+ echo \"Argument passed as repository-root is empty. Please provide a non-empty string.\"\n+ usage\n+ exit 1\n+fi\n+\n+if [ -z \"$2\" ]; then\n+ echo \"Argument passed as toolname is empty. Please provide a non-empty string.\"\n+ usage\n+ exit 1\n+fi\n+\n+repoRoot=\"$1\"\n+toolName=\"$2\"\n+strictToolVersionMatch=\"$(echo $4 | awk '{print tolower($0)}')\"\n+\n+scriptPath=\"$(cd \"$(dirname \"$0\")\"; pwd -P)\"\n+. \"$scriptPath/tool-helper.sh\"\n+declaredVersion=\"$(get_tool_config_value \"$repoRoot\" \"$toolName\" \"DeclaredVersion\")\"\n+\n+\n+# Displays the tool path.\n+display_tool_path()\n+{\n+ echo \"$toolPath\"\n+ log_message \"$toolName is available at $toolPath. Version is $toolVersion.\"\n+}\n+\n+# Searches the tool in environment path.\n+search_environment()\n+{\n+ log_message \"Searching for $toolName in environment path.\"\n+ hash \"$toolName\" 2>/dev/null\n+\n+ if [ $? -eq 0 ]; then\n+ toolPath=\"$(which $toolName)\"\n+\n+ if [ \"$strictToolVersionMatch\" != \"strict\" ] && [ -f \"$toolPath\" ]; then\n+ # No strictToolVersionMatch. Hence, return the path found without version check.\n+ display_tool_path\n+ exit\n+ else\n+ # If strictToolVersionMatch is required then, ensure the version in environment path is same as declared version.\n+ # If version matches then, return the path.\n+ toolVersion=\"$(\"$scriptPath/invoke-extension.sh\" \"get-version.sh\" \"$repoRoot\" \"$toolName\" \"\" \"\" \"$toolPath\")\"\n+\n+ if [ \"$toolVersion\" == \"$declaredVersion\" ]; then\n+ # Version available in environment path is the declared version.\n+ display_tool_path\n+ exit\n+ fi\n+ fi\n+\n+ log_message \"Version of $toolName at $toolPath is $toolVersion. This version does not match the declared version $declaredVersion.\"\n+ fi\n+}\n+\n+# Searches the tool within the repository.\n+search_repository()\n+{\n+ log_message \"Searching for $toolName within the repository.\"\n+ toolPath=\"$(get_repository_tool_search_path \"$repoRoot\" \"$toolName\")\"","path":"tools-local/unix/search-tool.sh","position":83,"original_position":83,"commit_id":"00bfb4115280a7868ff3529abd8efeed96c8c130","original_commit_id":"00bfb4115280a7868ff3529abd8efeed96c8c130","user":{"login":"ravimeda","id":12752450,"avatar_url":"https://avatars2.githubusercontent.com/u/12752450?v=3","gravatar_id":"","url":"https://api.github.com/users/ravimeda","html_url":"https://github.com/ravimeda","followers_url":"https://api.github.com/users/ravimeda/followers","following_url":"https://api.github.com/users/ravimeda/following{/other_user}","gists_url":"https://api.github.com/users/ravimeda/gists{/gist_id}","starred_url":"https://api.github.com/users/ravimeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravimeda/subscriptions","organizations_url":"https://api.github.com/users/ravimeda/orgs","repos_url":"https://api.github.com/users/ravimeda/repos","events_url":"https://api.github.com/users/ravimeda/events{/privacy}","received_events_url":"https://api.github.com/users/ravimeda/received_events","type":"User","site_admin":false},"body":"Updated as toolPath=\"$(get_local_search_path \"$repoRoot\" \"$toolName\")\"\r\n\r\n---\r\nIn reply to: [110417852](https://github.com/ravimeda/corefx/pull/9#discussion_r110417852) [](ancestors = 110417852)","created_at":"2017-04-11T18:23:30Z","updated_at":"2017-04-11T18:23:30Z","html_url":"https://github.com/ravimeda/corefx/pull/9#discussion_r110978212","pull_request_url":"https://api.github.com/repos/ravimeda/corefx/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/ravimeda/corefx/pulls/comments/110978212"},"html":{"href":"https://github.com/ravimeda/corefx/pull/9#discussion_r110978212"},"pull_request":{"href":"https://api.github.com/repos/ravimeda/corefx/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/ravimeda/corefx/pulls/9","id":114732751,"html_url":"https://github.com/ravimeda/corefx/pull/9","diff_url":"https://github.com/ravimeda/corefx/pull/9.diff","patch_url":"https://github.com/ravimeda/corefx/pull/9.patch","issue_url":"https://api.github.com/repos/ravimeda/corefx/issues/9","number":9,"state":"open","locked":false,"title":"Addressed comments from PR (#7) Search and acquire build tools.","user":{"login":"ravimeda","id":12752450,"avatar_url":"https://avatars2.githubusercontent.com/u/12752450?v=3","gravatar_id":"","url":"https://api.github.com/users/ravimeda","html_url":"https://github.com/ravimeda","followers_url":"https://api.github.com/users/ravimeda/followers","following_url":"https://api.github.com/users/ravimeda/following{/other_user}","gists_url":"https://api.github.com/users/ravimeda/gists{/gist_id}","starred_url":"https://api.github.com/users/ravimeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravimeda/subscriptions","organizations_url":"https://api.github.com/users/ravimeda/orgs","repos_url":"https://api.github.com/users/ravimeda/repos","events_url":"https://api.github.com/users/ravimeda/events{/privacy}","received_events_url":"https://api.github.com/users/ravimeda/received_events","type":"User","site_admin":false},"body":"This PR addresses the comments in PR https://github.com/ravimeda/corefx/pull/7\r\nSince there were significant changes, I am sending out a fresh PR. Summary of changes:\r\n1. Removed named arguments\r\n2. Repository root is the new argument passed to scripts\r\n\r\nA concern I have with these changes is a few arguments passed to scripts are not used anywhere within the script. These unused arguments are being passed due to the contract `invoke-extensions` maintains. Any suggestions for improvement is greatly appreciated.\r\n\r\n@MichaelSimons two comments from PR https://github.com/ravimeda/corefx/pull/7 on .toolversions file have not been addressed since I'll need some clarification.\r\n\r\n @dagood PTAL.\r\n","created_at":"2017-04-07T02:32:14Z","updated_at":"2017-04-11T18:23:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00734c9ccbe03aedd7f0998ecbaafb0a385f6f9d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ravimeda/corefx/pulls/9/commits","review_comments_url":"https://api.github.com/repos/ravimeda/corefx/pulls/9/comments","review_comment_url":"https://api.github.com/repos/ravimeda/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ravimeda/corefx/issues/9/comments","statuses_url":"https://api.github.com/repos/ravimeda/corefx/statuses/00bfb4115280a7868ff3529abd8efeed96c8c130","head":{"label":"ravimeda:PR7_Comments","ref":"PR7_Comments","sha":"00bfb4115280a7868ff3529abd8efeed96c8c130","user":{"login":"ravimeda","id":12752450,"avatar_url":"https://avatars2.githubusercontent.com/u/12752450?v=3","gravatar_id":"","url":"https://api.github.com/users/ravimeda","html_url":"https://github.com/ravimeda","followers_url":"https://api.github.com/users/ravimeda/followers","following_url":"https://api.github.com/users/ravimeda/following{/other_user}","gists_url":"https://api.github.com/users/ravimeda/gists{/gist_id}","starred_url":"https://api.github.com/users/ravimeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravimeda/subscriptions","organizations_url":"https://api.github.com/users/ravimeda/orgs","repos_url":"https://api.github.com/users/ravimeda/repos","events_url":"https://api.github.com/users/ravimeda/events{/privacy}","received_events_url":"https://api.github.com/users/ravimeda/received_events","type":"User","site_admin":false},"repo":{"id":42665934,"name":"corefx","full_name":"ravimeda/corefx","owner":{"login":"ravimeda","id":12752450,"avatar_url":"https://avatars2.githubusercontent.com/u/12752450?v=3","gravatar_id":"","url":"https://api.github.com/users/ravimeda","html_url":"https://github.com/ravimeda","followers_url":"https://api.github.com/users/ravimeda/followers","following_url":"https://api.github.com/users/ravimeda/following{/other_user}","gists_url":"https://api.github.com/users/ravimeda/gists{/gist_id}","starred_url":"https://api.github.com/users/ravimeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravimeda/subscriptions","organizations_url":"https://api.github.com/users/ravimeda/orgs","repos_url":"https://api.github.com/users/ravimeda/repos","events_url":"https://api.github.com/users/ravimeda/events{/privacy}","received_events_url":"https://api.github.com/users/ravimeda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ravimeda/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/ravimeda/corefx","forks_url":"https://api.github.com/repos/ravimeda/corefx/forks","keys_url":"https://api.github.com/repos/ravimeda/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravimeda/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravimeda/corefx/teams","hooks_url":"https://api.github.com/repos/ravimeda/corefx/hooks","issue_events_url":"https://api.github.com/repos/ravimeda/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/ravimeda/corefx/events","assignees_url":"https://api.github.com/repos/ravimeda/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/ravimeda/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/ravimeda/corefx/tags","blobs_url":"https://api.github.com/repos/ravimeda/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravimeda/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravimeda/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravimeda/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravimeda/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/ravimeda/corefx/languages","stargazers_url":"https://api.github.com/repos/ravimeda/corefx/stargazers","contributors_url":"https://api.github.com/repos/ravimeda/corefx/contributors","subscribers_url":"https://api.github.com/repos/ravimeda/corefx/subscribers","subscription_url":"https://api.github.com/repos/ravimeda/corefx/subscription","commits_url":"https://api.github.com/repos/ravimeda/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravimeda/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravimeda/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravimeda/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravimeda/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/ravimeda/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravimeda/corefx/merges","archive_url":"https://api.github.com/repos/ravimeda/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravimeda/corefx/downloads","issues_url":"https://api.github.com/repos/ravimeda/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/ravimeda/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/ravimeda/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/ravimeda/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravimeda/corefx/labels{/name}","releases_url":"https://api.github.com/repos/ravimeda/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/ravimeda/corefx/deployments","created_at":"2015-09-17T15:55:47Z","updated_at":"2016-11-29T01:42:43Z","pushed_at":"2017-04-11T16:40:49Z","git_url":"git://github.com/ravimeda/corefx.git","ssh_url":"[email protected]:ravimeda/corefx.git","clone_url":"https://github.com/ravimeda/corefx.git","svn_url":"https://github.com/ravimeda/corefx","homepage":"http://dotnet.github.io/core/","size":134799,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ravimeda:master","ref":"master","sha":"a2013ceb6dc595d5dc49accf2a57ab5dd7e2b144","user":{"login":"ravimeda","id":12752450,"avatar_url":"https://avatars2.githubusercontent.com/u/12752450?v=3","gravatar_id":"","url":"https://api.github.com/users/ravimeda","html_url":"https://github.com/ravimeda","followers_url":"https://api.github.com/users/ravimeda/followers","following_url":"https://api.github.com/users/ravimeda/following{/other_user}","gists_url":"https://api.github.com/users/ravimeda/gists{/gist_id}","starred_url":"https://api.github.com/users/ravimeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravimeda/subscriptions","organizations_url":"https://api.github.com/users/ravimeda/orgs","repos_url":"https://api.github.com/users/ravimeda/repos","events_url":"https://api.github.com/users/ravimeda/events{/privacy}","received_events_url":"https://api.github.com/users/ravimeda/received_events","type":"User","site_admin":false},"repo":{"id":42665934,"name":"corefx","full_name":"ravimeda/corefx","owner":{"login":"ravimeda","id":12752450,"avatar_url":"https://avatars2.githubusercontent.com/u/12752450?v=3","gravatar_id":"","url":"https://api.github.com/users/ravimeda","html_url":"https://github.com/ravimeda","followers_url":"https://api.github.com/users/ravimeda/followers","following_url":"https://api.github.com/users/ravimeda/following{/other_user}","gists_url":"https://api.github.com/users/ravimeda/gists{/gist_id}","starred_url":"https://api.github.com/users/ravimeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravimeda/subscriptions","organizations_url":"https://api.github.com/users/ravimeda/orgs","repos_url":"https://api.github.com/users/ravimeda/repos","events_url":"https://api.github.com/users/ravimeda/events{/privacy}","received_events_url":"https://api.github.com/users/ravimeda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ravimeda/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/ravimeda/corefx","forks_url":"https://api.github.com/repos/ravimeda/corefx/forks","keys_url":"https://api.github.com/repos/ravimeda/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravimeda/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravimeda/corefx/teams","hooks_url":"https://api.github.com/repos/ravimeda/corefx/hooks","issue_events_url":"https://api.github.com/repos/ravimeda/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/ravimeda/corefx/events","assignees_url":"https://api.github.com/repos/ravimeda/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/ravimeda/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/ravimeda/corefx/tags","blobs_url":"https://api.github.com/repos/ravimeda/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravimeda/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravimeda/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravimeda/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravimeda/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/ravimeda/corefx/languages","stargazers_url":"https://api.github.com/repos/ravimeda/corefx/stargazers","contributors_url":"https://api.github.com/repos/ravimeda/corefx/contributors","subscribers_url":"https://api.github.com/repos/ravimeda/corefx/subscribers","subscription_url":"https://api.github.com/repos/ravimeda/corefx/subscription","commits_url":"https://api.github.com/repos/ravimeda/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravimeda/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravimeda/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravimeda/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravimeda/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/ravimeda/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravimeda/corefx/merges","archive_url":"https://api.github.com/repos/ravimeda/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravimeda/corefx/downloads","issues_url":"https://api.github.com/repos/ravimeda/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/ravimeda/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/ravimeda/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/ravimeda/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravimeda/corefx/labels{/name}","releases_url":"https://api.github.com/repos/ravimeda/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/ravimeda/corefx/deployments","created_at":"2015-09-17T15:55:47Z","updated_at":"2016-11-29T01:42:43Z","pushed_at":"2017-04-11T16:40:49Z","git_url":"git://github.com/ravimeda/corefx.git","ssh_url":"[email protected]:ravimeda/corefx.git","clone_url":"https://github.com/ravimeda/corefx.git","svn_url":"https://github.com/ravimeda/corefx","homepage":"http://dotnet.github.io/core/","size":134799,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ravimeda/corefx/pulls/9"},"html":{"href":"https://github.com/ravimeda/corefx/pull/9"},"issue":{"href":"https://api.github.com/repos/ravimeda/corefx/issues/9"},"comments":{"href":"https://api.github.com/repos/ravimeda/corefx/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/ravimeda/corefx/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/ravimeda/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ravimeda/corefx/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/ravimeda/corefx/statuses/00bfb4115280a7868ff3529abd8efeed96c8c130"}}}} | {
"id": 42665934,
"name": "ravimeda/corefx",
"url": "https://api.github.com/repos/ravimeda/corefx"
} | {
"id": 12752450,
"login": "ravimeda",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12752450?",
"url": "https://api.github.com/users/ravimeda"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-04-11T18:23:30 | 5670061484 | {"actor":{"display_login":"ravimeda"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Keito1024/practice-front-end/pulls/comments/127132805","pull_request_review_id":49684063,"id":127132805,"diff_hunk":"@@ -0,0 +1,78 @@\n+:css\n+ ul.tab{\n+ margin-bottom:0;\n+ }\n+ ul.content{\n+ margin-top:0;\n+ }\n+ li{\n+ list-style:none;\n+ }\n+ .tab{\n+ overflow:hidden;","path":"source/js_training.html.haml","position":null,"original_position":12,"commit_id":"240f4a720bf3846b47b69d10d13fce04ff8148cf","original_commit_id":"a36062c280a5e860318a3948bde333ff02bb3038","user":{"login":"es335ab","id":3098852,"avatar_url":"https://avatars3.githubusercontent.com/u/3098852?v=3","gravatar_id":"","url":"https://api.github.com/users/es335ab","html_url":"https://github.com/es335ab","followers_url":"https://api.github.com/users/es335ab/followers","following_url":"https://api.github.com/users/es335ab/following{/other_user}","gists_url":"https://api.github.com/users/es335ab/gists{/gist_id}","starred_url":"https://api.github.com/users/es335ab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/es335ab/subscriptions","organizations_url":"https://api.github.com/users/es335ab/orgs","repos_url":"https://api.github.com/users/es335ab/repos","events_url":"https://api.github.com/users/es335ab/events{/privacy}","received_events_url":"https://api.github.com/users/es335ab/received_events","type":"User","site_admin":false},"body":"floatの親にはclearfixしておかないと高さがおかしなことになります。\r\n\r\n参考:http://kojika17.com/2013/06/clearfix-2013.html\r\n","created_at":"2017-07-13T05:47:32Z","updated_at":"2017-07-13T05:47:32Z","html_url":"https://github.com/Keito1024/practice-front-end/pull/5#discussion_r127132805","pull_request_url":"https://api.github.com/repos/Keito1024/practice-front-end/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/Keito1024/practice-front-end/pulls/comments/127132805"},"html":{"href":"https://github.com/Keito1024/practice-front-end/pull/5#discussion_r127132805"},"pull_request":{"href":"https://api.github.com/repos/Keito1024/practice-front-end/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/Keito1024/practice-front-end/pulls/5","id":130069464,"html_url":"https://github.com/Keito1024/practice-front-end/pull/5","diff_url":"https://github.com/Keito1024/practice-front-end/pull/5.diff","patch_url":"https://github.com/Keito1024/practice-front-end/pull/5.patch","issue_url":"https://api.github.com/repos/Keito1024/practice-front-end/issues/5","number":5,"state":"open","locked":false,"title":"タブ切り替え機能","user":{"login":"Keito1024","id":25076377,"avatar_url":"https://avatars1.githubusercontent.com/u/25076377?v=3","gravatar_id":"","url":"https://api.github.com/users/Keito1024","html_url":"https://github.com/Keito1024","followers_url":"https://api.github.com/users/Keito1024/followers","following_url":"https://api.github.com/users/Keito1024/following{/other_user}","gists_url":"https://api.github.com/users/Keito1024/gists{/gist_id}","starred_url":"https://api.github.com/users/Keito1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keito1024/subscriptions","organizations_url":"https://api.github.com/users/Keito1024/orgs","repos_url":"https://api.github.com/users/Keito1024/repos","events_url":"https://api.github.com/users/Keito1024/events{/privacy}","received_events_url":"https://api.github.com/users/Keito1024/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-12T07:13:16Z","updated_at":"2017-07-13T05:47:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00aee75a45b337cd98c487fd0926b9b36d986b5a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Keito1024/practice-front-end/pulls/5/commits","review_comments_url":"https://api.github.com/repos/Keito1024/practice-front-end/pulls/5/comments","review_comment_url":"https://api.github.com/repos/Keito1024/practice-front-end/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Keito1024/practice-front-end/issues/5/comments","statuses_url":"https://api.github.com/repos/Keito1024/practice-front-end/statuses/240f4a720bf3846b47b69d10d13fce04ff8148cf","head":{"label":"Keito1024:tab","ref":"tab","sha":"240f4a720bf3846b47b69d10d13fce04ff8148cf","user":{"login":"Keito1024","id":25076377,"avatar_url":"https://avatars1.githubusercontent.com/u/25076377?v=3","gravatar_id":"","url":"https://api.github.com/users/Keito1024","html_url":"https://github.com/Keito1024","followers_url":"https://api.github.com/users/Keito1024/followers","following_url":"https://api.github.com/users/Keito1024/following{/other_user}","gists_url":"https://api.github.com/users/Keito1024/gists{/gist_id}","starred_url":"https://api.github.com/users/Keito1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keito1024/subscriptions","organizations_url":"https://api.github.com/users/Keito1024/orgs","repos_url":"https://api.github.com/users/Keito1024/repos","events_url":"https://api.github.com/users/Keito1024/events{/privacy}","received_events_url":"https://api.github.com/users/Keito1024/received_events","type":"User","site_admin":false},"repo":{"id":96075126,"name":"practice-front-end","full_name":"Keito1024/practice-front-end","owner":{"login":"Keito1024","id":25076377,"avatar_url":"https://avatars1.githubusercontent.com/u/25076377?v=3","gravatar_id":"","url":"https://api.github.com/users/Keito1024","html_url":"https://github.com/Keito1024","followers_url":"https://api.github.com/users/Keito1024/followers","following_url":"https://api.github.com/users/Keito1024/following{/other_user}","gists_url":"https://api.github.com/users/Keito1024/gists{/gist_id}","starred_url":"https://api.github.com/users/Keito1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keito1024/subscriptions","organizations_url":"https://api.github.com/users/Keito1024/orgs","repos_url":"https://api.github.com/users/Keito1024/repos","events_url":"https://api.github.com/users/Keito1024/events{/privacy}","received_events_url":"https://api.github.com/users/Keito1024/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Keito1024/practice-front-end","description":null,"fork":true,"url":"https://api.github.com/repos/Keito1024/practice-front-end","forks_url":"https://api.github.com/repos/Keito1024/practice-front-end/forks","keys_url":"https://api.github.com/repos/Keito1024/practice-front-end/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Keito1024/practice-front-end/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Keito1024/practice-front-end/teams","hooks_url":"https://api.github.com/repos/Keito1024/practice-front-end/hooks","issue_events_url":"https://api.github.com/repos/Keito1024/practice-front-end/issues/events{/number}","events_url":"https://api.github.com/repos/Keito1024/practice-front-end/events","assignees_url":"https://api.github.com/repos/Keito1024/practice-front-end/assignees{/user}","branches_url":"https://api.github.com/repos/Keito1024/practice-front-end/branches{/branch}","tags_url":"https://api.github.com/repos/Keito1024/practice-front-end/tags","blobs_url":"https://api.github.com/repos/Keito1024/practice-front-end/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Keito1024/practice-front-end/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Keito1024/practice-front-end/git/refs{/sha}","trees_url":"https://api.github.com/repos/Keito1024/practice-front-end/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Keito1024/practice-front-end/statuses/{sha}","languages_url":"https://api.github.com/repos/Keito1024/practice-front-end/languages","stargazers_url":"https://api.github.com/repos/Keito1024/practice-front-end/stargazers","contributors_url":"https://api.github.com/repos/Keito1024/practice-front-end/contributors","subscribers_url":"https://api.github.com/repos/Keito1024/practice-front-end/subscribers","subscription_url":"https://api.github.com/repos/Keito1024/practice-front-end/subscription","commits_url":"https://api.github.com/repos/Keito1024/practice-front-end/commits{/sha}","git_commits_url":"https://api.github.com/repos/Keito1024/practice-front-end/git/commits{/sha}","comments_url":"https://api.github.com/repos/Keito1024/practice-front-end/comments{/number}","issue_comment_url":"https://api.github.com/repos/Keito1024/practice-front-end/issues/comments{/number}","contents_url":"https://api.github.com/repos/Keito1024/practice-front-end/contents/{+path}","compare_url":"https://api.github.com/repos/Keito1024/practice-front-end/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Keito1024/practice-front-end/merges","archive_url":"https://api.github.com/repos/Keito1024/practice-front-end/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Keito1024/practice-front-end/downloads","issues_url":"https://api.github.com/repos/Keito1024/practice-front-end/issues{/number}","pulls_url":"https://api.github.com/repos/Keito1024/practice-front-end/pulls{/number}","milestones_url":"https://api.github.com/repos/Keito1024/practice-front-end/milestones{/number}","notifications_url":"https://api.github.com/repos/Keito1024/practice-front-end/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Keito1024/practice-front-end/labels{/name}","releases_url":"https://api.github.com/repos/Keito1024/practice-front-end/releases{/id}","deployments_url":"https://api.github.com/repos/Keito1024/practice-front-end/deployments","created_at":"2017-07-03T05:58:12Z","updated_at":"2017-07-03T05:58:13Z","pushed_at":"2017-07-13T05:45:49Z","git_url":"git://github.com/Keito1024/practice-front-end.git","ssh_url":"[email protected]:Keito1024/practice-front-end.git","clone_url":"https://github.com/Keito1024/practice-front-end.git","svn_url":"https://github.com/Keito1024/practice-front-end","homepage":null,"size":133,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Keito1024:master","ref":"master","sha":"14d9cf4882f90fa2e0fa24c8491fb961b7a248ee","user":{"login":"Keito1024","id":25076377,"avatar_url":"https://avatars1.githubusercontent.com/u/25076377?v=3","gravatar_id":"","url":"https://api.github.com/users/Keito1024","html_url":"https://github.com/Keito1024","followers_url":"https://api.github.com/users/Keito1024/followers","following_url":"https://api.github.com/users/Keito1024/following{/other_user}","gists_url":"https://api.github.com/users/Keito1024/gists{/gist_id}","starred_url":"https://api.github.com/users/Keito1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keito1024/subscriptions","organizations_url":"https://api.github.com/users/Keito1024/orgs","repos_url":"https://api.github.com/users/Keito1024/repos","events_url":"https://api.github.com/users/Keito1024/events{/privacy}","received_events_url":"https://api.github.com/users/Keito1024/received_events","type":"User","site_admin":false},"repo":{"id":96075126,"name":"practice-front-end","full_name":"Keito1024/practice-front-end","owner":{"login":"Keito1024","id":25076377,"avatar_url":"https://avatars1.githubusercontent.com/u/25076377?v=3","gravatar_id":"","url":"https://api.github.com/users/Keito1024","html_url":"https://github.com/Keito1024","followers_url":"https://api.github.com/users/Keito1024/followers","following_url":"https://api.github.com/users/Keito1024/following{/other_user}","gists_url":"https://api.github.com/users/Keito1024/gists{/gist_id}","starred_url":"https://api.github.com/users/Keito1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keito1024/subscriptions","organizations_url":"https://api.github.com/users/Keito1024/orgs","repos_url":"https://api.github.com/users/Keito1024/repos","events_url":"https://api.github.com/users/Keito1024/events{/privacy}","received_events_url":"https://api.github.com/users/Keito1024/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Keito1024/practice-front-end","description":null,"fork":true,"url":"https://api.github.com/repos/Keito1024/practice-front-end","forks_url":"https://api.github.com/repos/Keito1024/practice-front-end/forks","keys_url":"https://api.github.com/repos/Keito1024/practice-front-end/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Keito1024/practice-front-end/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Keito1024/practice-front-end/teams","hooks_url":"https://api.github.com/repos/Keito1024/practice-front-end/hooks","issue_events_url":"https://api.github.com/repos/Keito1024/practice-front-end/issues/events{/number}","events_url":"https://api.github.com/repos/Keito1024/practice-front-end/events","assignees_url":"https://api.github.com/repos/Keito1024/practice-front-end/assignees{/user}","branches_url":"https://api.github.com/repos/Keito1024/practice-front-end/branches{/branch}","tags_url":"https://api.github.com/repos/Keito1024/practice-front-end/tags","blobs_url":"https://api.github.com/repos/Keito1024/practice-front-end/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Keito1024/practice-front-end/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Keito1024/practice-front-end/git/refs{/sha}","trees_url":"https://api.github.com/repos/Keito1024/practice-front-end/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Keito1024/practice-front-end/statuses/{sha}","languages_url":"https://api.github.com/repos/Keito1024/practice-front-end/languages","stargazers_url":"https://api.github.com/repos/Keito1024/practice-front-end/stargazers","contributors_url":"https://api.github.com/repos/Keito1024/practice-front-end/contributors","subscribers_url":"https://api.github.com/repos/Keito1024/practice-front-end/subscribers","subscription_url":"https://api.github.com/repos/Keito1024/practice-front-end/subscription","commits_url":"https://api.github.com/repos/Keito1024/practice-front-end/commits{/sha}","git_commits_url":"https://api.github.com/repos/Keito1024/practice-front-end/git/commits{/sha}","comments_url":"https://api.github.com/repos/Keito1024/practice-front-end/comments{/number}","issue_comment_url":"https://api.github.com/repos/Keito1024/practice-front-end/issues/comments{/number}","contents_url":"https://api.github.com/repos/Keito1024/practice-front-end/contents/{+path}","compare_url":"https://api.github.com/repos/Keito1024/practice-front-end/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Keito1024/practice-front-end/merges","archive_url":"https://api.github.com/repos/Keito1024/practice-front-end/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Keito1024/practice-front-end/downloads","issues_url":"https://api.github.com/repos/Keito1024/practice-front-end/issues{/number}","pulls_url":"https://api.github.com/repos/Keito1024/practice-front-end/pulls{/number}","milestones_url":"https://api.github.com/repos/Keito1024/practice-front-end/milestones{/number}","notifications_url":"https://api.github.com/repos/Keito1024/practice-front-end/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Keito1024/practice-front-end/labels{/name}","releases_url":"https://api.github.com/repos/Keito1024/practice-front-end/releases{/id}","deployments_url":"https://api.github.com/repos/Keito1024/practice-front-end/deployments","created_at":"2017-07-03T05:58:12Z","updated_at":"2017-07-03T05:58:13Z","pushed_at":"2017-07-13T05:45:49Z","git_url":"git://github.com/Keito1024/practice-front-end.git","ssh_url":"[email protected]:Keito1024/practice-front-end.git","clone_url":"https://github.com/Keito1024/practice-front-end.git","svn_url":"https://github.com/Keito1024/practice-front-end","homepage":null,"size":133,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Keito1024/practice-front-end/pulls/5"},"html":{"href":"https://github.com/Keito1024/practice-front-end/pull/5"},"issue":{"href":"https://api.github.com/repos/Keito1024/practice-front-end/issues/5"},"comments":{"href":"https://api.github.com/repos/Keito1024/practice-front-end/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/Keito1024/practice-front-end/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/Keito1024/practice-front-end/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Keito1024/practice-front-end/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/Keito1024/practice-front-end/statuses/240f4a720bf3846b47b69d10d13fce04ff8148cf"}}}} | {
"id": 96075126,
"name": "Keito1024/practice-front-end",
"url": "https://api.github.com/repos/Keito1024/practice-front-end"
} | {
"id": 3098852,
"login": "es335ab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3098852?",
"url": "https://api.github.com/users/es335ab"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-07-13T05:47:32 | 6246750336 | {"actor":{"display_login":"es335ab"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/colorbox/bento/pulls/comments/112700976","pull_request_review_id":34034679,"id":112700976,"diff_hunk":"@@ -1,8 +1,17 @@\n+require 'idobata'\n+\n class Admin::OrdersController < Admin::ApplicationController\n def close\n order = Order.find(params[:id])\n \n if order.close\n+\n+ if order.item_count_satisfied?","path":"app/controllers/admin/orders_controller.rb","position":9,"original_position":9,"commit_id":"8f0372744a5e86c3172916529632b6bce92d5db9","original_commit_id":"8f0372744a5e86c3172916529632b6bce92d5db9","user":{"login":"yucao24hours","id":1979779,"avatar_url":"https://avatars3.githubusercontent.com/u/1979779?v=3","gravatar_id":"","url":"https://api.github.com/users/yucao24hours","html_url":"https://github.com/yucao24hours","followers_url":"https://api.github.com/users/yucao24hours/followers","following_url":"https://api.github.com/users/yucao24hours/following{/other_user}","gists_url":"https://api.github.com/users/yucao24hours/gists{/gist_id}","starred_url":"https://api.github.com/users/yucao24hours/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yucao24hours/subscriptions","organizations_url":"https://api.github.com/users/yucao24hours/orgs","repos_url":"https://api.github.com/users/yucao24hours/repos","events_url":"https://api.github.com/users/yucao24hours/events{/privacy}","received_events_url":"https://api.github.com/users/yucao24hours/received_events","type":"User","site_admin":false},"body":"この分岐(post する部分)は、コントローラでやるべきことなのかなあ?Order モデルの close メソッドに書くとかの方がいいような気もしました。","created_at":"2017-04-21T14:32:13Z","updated_at":"2017-04-21T14:33:09Z","html_url":"https://github.com/colorbox/bento/pull/118#discussion_r112700976","pull_request_url":"https://api.github.com/repos/colorbox/bento/pulls/118","_links":{"self":{"href":"https://api.github.com/repos/colorbox/bento/pulls/comments/112700976"},"html":{"href":"https://github.com/colorbox/bento/pull/118#discussion_r112700976"},"pull_request":{"href":"https://api.github.com/repos/colorbox/bento/pulls/118"}}},"pull_request":{"url":"https://api.github.com/repos/colorbox/bento/pulls/118","id":116056190,"html_url":"https://github.com/colorbox/bento/pull/118","diff_url":"https://github.com/colorbox/bento/pull/118.diff","patch_url":"https://github.com/colorbox/bento/pull/118.patch","issue_url":"https://api.github.com/repos/colorbox/bento/issues/118","number":118,"state":"closed","locked":false,"title":"締め切り時に予約の成否をidobataへ通知する。","user":{"login":"colorbox","id":731436,"avatar_url":"https://avatars3.githubusercontent.com/u/731436?v=3","gravatar_id":"","url":"https://api.github.com/users/colorbox","html_url":"https://github.com/colorbox","followers_url":"https://api.github.com/users/colorbox/followers","following_url":"https://api.github.com/users/colorbox/following{/other_user}","gists_url":"https://api.github.com/users/colorbox/gists{/gist_id}","starred_url":"https://api.github.com/users/colorbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colorbox/subscriptions","organizations_url":"https://api.github.com/users/colorbox/orgs","repos_url":"https://api.github.com/users/colorbox/repos","events_url":"https://api.github.com/users/colorbox/events{/privacy}","received_events_url":"https://api.github.com/users/colorbox/received_events","type":"User","site_admin":false},"body":"## 概要\r\n#103 の実装です。\r\n\r\n## 実施事項\r\n\r\n### Idobataモジュールの修正\r\n - idobataの通知先の追加\r\n - 通知用メソッドの修正\r\n\r\n### 環境変数の修正\r\n通知先の追加に合わせてそれ用の環境変数を追加しました。\r\nまた、追加された環境変数に合わせる形で既存の環境変数名を変更しました。\r\n\r\n## その他\r\n通知先となるidobataのroomのhook-urlを`IDOBATA_USER_HOOK_URL`という名前で環境変数に追加する必要があります。\r\n本番環境では実施済みです。\r\n","created_at":"2017-04-16T11:20:15Z","updated_at":"2017-04-21T14:33:09Z","closed_at":"2017-04-20T07:03:28Z","merged_at":"2017-04-20T07:03:28Z","merge_commit_sha":"29a28820fa41047cffc70b92d42eed01df4bf4e2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/colorbox/bento/pulls/118/commits","review_comments_url":"https://api.github.com/repos/colorbox/bento/pulls/118/comments","review_comment_url":"https://api.github.com/repos/colorbox/bento/pulls/comments{/number}","comments_url":"https://api.github.com/repos/colorbox/bento/issues/118/comments","statuses_url":"https://api.github.com/repos/colorbox/bento/statuses/8f0372744a5e86c3172916529632b6bce92d5db9","head":{"label":"colorbox:notify-invalid-order","ref":"notify-invalid-order","sha":"8f0372744a5e86c3172916529632b6bce92d5db9","user":{"login":"colorbox","id":731436,"avatar_url":"https://avatars3.githubusercontent.com/u/731436?v=3","gravatar_id":"","url":"https://api.github.com/users/colorbox","html_url":"https://github.com/colorbox","followers_url":"https://api.github.com/users/colorbox/followers","following_url":"https://api.github.com/users/colorbox/following{/other_user}","gists_url":"https://api.github.com/users/colorbox/gists{/gist_id}","starred_url":"https://api.github.com/users/colorbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colorbox/subscriptions","organizations_url":"https://api.github.com/users/colorbox/orgs","repos_url":"https://api.github.com/users/colorbox/repos","events_url":"https://api.github.com/users/colorbox/events{/privacy}","received_events_url":"https://api.github.com/users/colorbox/received_events","type":"User","site_admin":false},"repo":{"id":82447804,"name":"bento","full_name":"colorbox/bento","owner":{"login":"colorbox","id":731436,"avatar_url":"https://avatars3.githubusercontent.com/u/731436?v=3","gravatar_id":"","url":"https://api.github.com/users/colorbox","html_url":"https://github.com/colorbox","followers_url":"https://api.github.com/users/colorbox/followers","following_url":"https://api.github.com/users/colorbox/following{/other_user}","gists_url":"https://api.github.com/users/colorbox/gists{/gist_id}","starred_url":"https://api.github.com/users/colorbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colorbox/subscriptions","organizations_url":"https://api.github.com/users/colorbox/orgs","repos_url":"https://api.github.com/users/colorbox/repos","events_url":"https://api.github.com/users/colorbox/events{/privacy}","received_events_url":"https://api.github.com/users/colorbox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colorbox/bento","description":"bento","fork":false,"url":"https://api.github.com/repos/colorbox/bento","forks_url":"https://api.github.com/repos/colorbox/bento/forks","keys_url":"https://api.github.com/repos/colorbox/bento/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colorbox/bento/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colorbox/bento/teams","hooks_url":"https://api.github.com/repos/colorbox/bento/hooks","issue_events_url":"https://api.github.com/repos/colorbox/bento/issues/events{/number}","events_url":"https://api.github.com/repos/colorbox/bento/events","assignees_url":"https://api.github.com/repos/colorbox/bento/assignees{/user}","branches_url":"https://api.github.com/repos/colorbox/bento/branches{/branch}","tags_url":"https://api.github.com/repos/colorbox/bento/tags","blobs_url":"https://api.github.com/repos/colorbox/bento/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colorbox/bento/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colorbox/bento/git/refs{/sha}","trees_url":"https://api.github.com/repos/colorbox/bento/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colorbox/bento/statuses/{sha}","languages_url":"https://api.github.com/repos/colorbox/bento/languages","stargazers_url":"https://api.github.com/repos/colorbox/bento/stargazers","contributors_url":"https://api.github.com/repos/colorbox/bento/contributors","subscribers_url":"https://api.github.com/repos/colorbox/bento/subscribers","subscription_url":"https://api.github.com/repos/colorbox/bento/subscription","commits_url":"https://api.github.com/repos/colorbox/bento/commits{/sha}","git_commits_url":"https://api.github.com/repos/colorbox/bento/git/commits{/sha}","comments_url":"https://api.github.com/repos/colorbox/bento/comments{/number}","issue_comment_url":"https://api.github.com/repos/colorbox/bento/issues/comments{/number}","contents_url":"https://api.github.com/repos/colorbox/bento/contents/{+path}","compare_url":"https://api.github.com/repos/colorbox/bento/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colorbox/bento/merges","archive_url":"https://api.github.com/repos/colorbox/bento/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colorbox/bento/downloads","issues_url":"https://api.github.com/repos/colorbox/bento/issues{/number}","pulls_url":"https://api.github.com/repos/colorbox/bento/pulls{/number}","milestones_url":"https://api.github.com/repos/colorbox/bento/milestones{/number}","notifications_url":"https://api.github.com/repos/colorbox/bento/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colorbox/bento/labels{/name}","releases_url":"https://api.github.com/repos/colorbox/bento/releases{/id}","deployments_url":"https://api.github.com/repos/colorbox/bento/deployments","created_at":"2017-02-19T09:19:11Z","updated_at":"2017-03-21T12:43:10Z","pushed_at":"2017-04-20T07:12:10Z","git_url":"git://github.com/colorbox/bento.git","ssh_url":"[email protected]:colorbox/bento.git","clone_url":"https://github.com/colorbox/bento.git","svn_url":"https://github.com/colorbox/bento","homepage":null,"size":214,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":2,"default_branch":"master"}},"base":{"label":"colorbox:master","ref":"master","sha":"64e1f7eb9432e7bd747c2f9fb6d6ef385c269cec","user":{"login":"colorbox","id":731436,"avatar_url":"https://avatars3.githubusercontent.com/u/731436?v=3","gravatar_id":"","url":"https://api.github.com/users/colorbox","html_url":"https://github.com/colorbox","followers_url":"https://api.github.com/users/colorbox/followers","following_url":"https://api.github.com/users/colorbox/following{/other_user}","gists_url":"https://api.github.com/users/colorbox/gists{/gist_id}","starred_url":"https://api.github.com/users/colorbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colorbox/subscriptions","organizations_url":"https://api.github.com/users/colorbox/orgs","repos_url":"https://api.github.com/users/colorbox/repos","events_url":"https://api.github.com/users/colorbox/events{/privacy}","received_events_url":"https://api.github.com/users/colorbox/received_events","type":"User","site_admin":false},"repo":{"id":82447804,"name":"bento","full_name":"colorbox/bento","owner":{"login":"colorbox","id":731436,"avatar_url":"https://avatars3.githubusercontent.com/u/731436?v=3","gravatar_id":"","url":"https://api.github.com/users/colorbox","html_url":"https://github.com/colorbox","followers_url":"https://api.github.com/users/colorbox/followers","following_url":"https://api.github.com/users/colorbox/following{/other_user}","gists_url":"https://api.github.com/users/colorbox/gists{/gist_id}","starred_url":"https://api.github.com/users/colorbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colorbox/subscriptions","organizations_url":"https://api.github.com/users/colorbox/orgs","repos_url":"https://api.github.com/users/colorbox/repos","events_url":"https://api.github.com/users/colorbox/events{/privacy}","received_events_url":"https://api.github.com/users/colorbox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colorbox/bento","description":"bento","fork":false,"url":"https://api.github.com/repos/colorbox/bento","forks_url":"https://api.github.com/repos/colorbox/bento/forks","keys_url":"https://api.github.com/repos/colorbox/bento/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colorbox/bento/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colorbox/bento/teams","hooks_url":"https://api.github.com/repos/colorbox/bento/hooks","issue_events_url":"https://api.github.com/repos/colorbox/bento/issues/events{/number}","events_url":"https://api.github.com/repos/colorbox/bento/events","assignees_url":"https://api.github.com/repos/colorbox/bento/assignees{/user}","branches_url":"https://api.github.com/repos/colorbox/bento/branches{/branch}","tags_url":"https://api.github.com/repos/colorbox/bento/tags","blobs_url":"https://api.github.com/repos/colorbox/bento/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colorbox/bento/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colorbox/bento/git/refs{/sha}","trees_url":"https://api.github.com/repos/colorbox/bento/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colorbox/bento/statuses/{sha}","languages_url":"https://api.github.com/repos/colorbox/bento/languages","stargazers_url":"https://api.github.com/repos/colorbox/bento/stargazers","contributors_url":"https://api.github.com/repos/colorbox/bento/contributors","subscribers_url":"https://api.github.com/repos/colorbox/bento/subscribers","subscription_url":"https://api.github.com/repos/colorbox/bento/subscription","commits_url":"https://api.github.com/repos/colorbox/bento/commits{/sha}","git_commits_url":"https://api.github.com/repos/colorbox/bento/git/commits{/sha}","comments_url":"https://api.github.com/repos/colorbox/bento/comments{/number}","issue_comment_url":"https://api.github.com/repos/colorbox/bento/issues/comments{/number}","contents_url":"https://api.github.com/repos/colorbox/bento/contents/{+path}","compare_url":"https://api.github.com/repos/colorbox/bento/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colorbox/bento/merges","archive_url":"https://api.github.com/repos/colorbox/bento/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colorbox/bento/downloads","issues_url":"https://api.github.com/repos/colorbox/bento/issues{/number}","pulls_url":"https://api.github.com/repos/colorbox/bento/pulls{/number}","milestones_url":"https://api.github.com/repos/colorbox/bento/milestones{/number}","notifications_url":"https://api.github.com/repos/colorbox/bento/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colorbox/bento/labels{/name}","releases_url":"https://api.github.com/repos/colorbox/bento/releases{/id}","deployments_url":"https://api.github.com/repos/colorbox/bento/deployments","created_at":"2017-02-19T09:19:11Z","updated_at":"2017-03-21T12:43:10Z","pushed_at":"2017-04-20T07:12:10Z","git_url":"git://github.com/colorbox/bento.git","ssh_url":"[email protected]:colorbox/bento.git","clone_url":"https://github.com/colorbox/bento.git","svn_url":"https://github.com/colorbox/bento","homepage":null,"size":214,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/colorbox/bento/pulls/118"},"html":{"href":"https://github.com/colorbox/bento/pull/118"},"issue":{"href":"https://api.github.com/repos/colorbox/bento/issues/118"},"comments":{"href":"https://api.github.com/repos/colorbox/bento/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/colorbox/bento/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/colorbox/bento/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/colorbox/bento/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/colorbox/bento/statuses/8f0372744a5e86c3172916529632b6bce92d5db9"}}}} | {
"id": 82447804,
"name": "colorbox/bento",
"url": "https://api.github.com/repos/colorbox/bento"
} | {
"id": 1979779,
"login": "yucao24hours",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1979779?",
"url": "https://api.github.com/users/yucao24hours"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-04-21T14:32:13 | 5732300457 | {"actor":{"display_login":"yucao24hours"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/pulls/comments/148436082","pull_request_review_id":73677505,"id":148436082,"diff_hunk":"@@ -23,6 +23,8 @@ my $ret;\n my $elem;\n \n LINK: {\n+ no warnings 'redefine';\n+ local *Selenium::Remote::WebElement::click = sub { return; };","path":"t/02-webelement.t","position":5,"original_position":5,"commit_id":"a4fa22a022ed08c89c4dfa274c866a781e321922","original_commit_id":"a4fa22a022ed08c89c4dfa274c866a781e321922","user":{"login":"teodesian","id":8262579,"avatar_url":"https://avatars2.githubusercontent.com/u/8262579?v=4","gravatar_id":"","url":"https://api.github.com/users/teodesian","html_url":"https://github.com/teodesian","followers_url":"https://api.github.com/users/teodesian/followers","following_url":"https://api.github.com/users/teodesian/following{/other_user}","gists_url":"https://api.github.com/users/teodesian/gists{/gist_id}","starred_url":"https://api.github.com/users/teodesian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teodesian/subscriptions","organizations_url":"https://api.github.com/users/teodesian/orgs","repos_url":"https://api.github.com/users/teodesian/repos","events_url":"https://api.github.com/users/teodesian/events{/privacy}","received_events_url":"https://api.github.com/users/teodesian/received_events","type":"User","site_admin":false},"body":"same as above","created_at":"2017-11-02T03:25:23Z","updated_at":"2017-11-02T03:28:35Z","html_url":"https://github.com/teodesian/Selenium-Remote-Driver/pull/332#discussion_r148436082","pull_request_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/pulls/332","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/pulls/comments/148436082"},"html":{"href":"https://github.com/teodesian/Selenium-Remote-Driver/pull/332#discussion_r148436082"},"pull_request":{"href":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/pulls/332"}}},"pull_request":{"url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/pulls/332","id":135033505,"html_url":"https://github.com/teodesian/Selenium-Remote-Driver/pull/332","diff_url":"https://github.com/teodesian/Selenium-Remote-Driver/pull/332.diff","patch_url":"https://github.com/teodesian/Selenium-Remote-Driver/pull/332.patch","issue_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/issues/332","number":332,"state":"open","locked":false,"title":"Fix #329 -- Uninitialized value warnings in S::R::Commands","user":{"login":"troglodyne","id":20960409,"avatar_url":"https://avatars1.githubusercontent.com/u/20960409?v=4","gravatar_id":"","url":"https://api.github.com/users/troglodyne","html_url":"https://github.com/troglodyne","followers_url":"https://api.github.com/users/troglodyne/followers","following_url":"https://api.github.com/users/troglodyne/following{/other_user}","gists_url":"https://api.github.com/users/troglodyne/gists{/gist_id}","starred_url":"https://api.github.com/users/troglodyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troglodyne/subscriptions","organizations_url":"https://api.github.com/users/troglodyne/orgs","repos_url":"https://api.github.com/users/troglodyne/repos","events_url":"https://api.github.com/users/troglodyne/events{/privacy}","received_events_url":"https://api.github.com/users/troglodyne/received_events","type":"User","site_admin":false},"body":"It just wasn't setting sane defaults before running regex replace.\r\nThis commit additionally adds test coverage for the modified\r\nsubroutine, hopefully in the correct place.\r\n\r\nI also added a block to properly include the libdir when running\r\nthe affected test via prove (so that you don't have to use -Ilib\r\nor something like that) whenever we're not running the test via\r\n'dzil test' or anything else where we've plopped the libs and\r\ntests in a temporary '.build' directory.","created_at":"2017-08-10T03:18:28Z","updated_at":"2017-11-02T03:28:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"055b23d76378c9c668b076ae1d6c4003f87c055e","assignee":{"login":"teodesian","id":8262579,"avatar_url":"https://avatars2.githubusercontent.com/u/8262579?v=4","gravatar_id":"","url":"https://api.github.com/users/teodesian","html_url":"https://github.com/teodesian","followers_url":"https://api.github.com/users/teodesian/followers","following_url":"https://api.github.com/users/teodesian/following{/other_user}","gists_url":"https://api.github.com/users/teodesian/gists{/gist_id}","starred_url":"https://api.github.com/users/teodesian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teodesian/subscriptions","organizations_url":"https://api.github.com/users/teodesian/orgs","repos_url":"https://api.github.com/users/teodesian/repos","events_url":"https://api.github.com/users/teodesian/events{/privacy}","received_events_url":"https://api.github.com/users/teodesian/received_events","type":"User","site_admin":false},"assignees":[{"login":"teodesian","id":8262579,"avatar_url":"https://avatars2.githubusercontent.com/u/8262579?v=4","gravatar_id":"","url":"https://api.github.com/users/teodesian","html_url":"https://github.com/teodesian","followers_url":"https://api.github.com/users/teodesian/followers","following_url":"https://api.github.com/users/teodesian/following{/other_user}","gists_url":"https://api.github.com/users/teodesian/gists{/gist_id}","starred_url":"https://api.github.com/users/teodesian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teodesian/subscriptions","organizations_url":"https://api.github.com/users/teodesian/orgs","repos_url":"https://api.github.com/users/teodesian/repos","events_url":"https://api.github.com/users/teodesian/events{/privacy}","received_events_url":"https://api.github.com/users/teodesian/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/pulls/332/commits","review_comments_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/pulls/332/comments","review_comment_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/issues/332/comments","statuses_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/statuses/a4fa22a022ed08c89c4dfa274c866a781e321922","head":{"label":"troglodyne:SRD-329","ref":"SRD-329","sha":"a4fa22a022ed08c89c4dfa274c866a781e321922","user":{"login":"troglodyne","id":20960409,"avatar_url":"https://avatars1.githubusercontent.com/u/20960409?v=4","gravatar_id":"","url":"https://api.github.com/users/troglodyne","html_url":"https://github.com/troglodyne","followers_url":"https://api.github.com/users/troglodyne/followers","following_url":"https://api.github.com/users/troglodyne/following{/other_user}","gists_url":"https://api.github.com/users/troglodyne/gists{/gist_id}","starred_url":"https://api.github.com/users/troglodyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troglodyne/subscriptions","organizations_url":"https://api.github.com/users/troglodyne/orgs","repos_url":"https://api.github.com/users/troglodyne/repos","events_url":"https://api.github.com/users/troglodyne/events{/privacy}","received_events_url":"https://api.github.com/users/troglodyne/received_events","type":"User","site_admin":false},"repo":{"id":99636609,"name":"Selenium-Remote-Driver","full_name":"troglodyne/Selenium-Remote-Driver","owner":{"login":"troglodyne","id":20960409,"avatar_url":"https://avatars1.githubusercontent.com/u/20960409?v=4","gravatar_id":"","url":"https://api.github.com/users/troglodyne","html_url":"https://github.com/troglodyne","followers_url":"https://api.github.com/users/troglodyne/followers","following_url":"https://api.github.com/users/troglodyne/following{/other_user}","gists_url":"https://api.github.com/users/troglodyne/gists{/gist_id}","starred_url":"https://api.github.com/users/troglodyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troglodyne/subscriptions","organizations_url":"https://api.github.com/users/troglodyne/orgs","repos_url":"https://api.github.com/users/troglodyne/repos","events_url":"https://api.github.com/users/troglodyne/events{/privacy}","received_events_url":"https://api.github.com/users/troglodyne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/troglodyne/Selenium-Remote-Driver","description":"Perl Bindings to the Selenium Webdriver server","fork":true,"url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver","forks_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/forks","keys_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/teams","hooks_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/hooks","issue_events_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/issues/events{/number}","events_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/events","assignees_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/assignees{/user}","branches_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/branches{/branch}","tags_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/tags","blobs_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/statuses/{sha}","languages_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/languages","stargazers_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/stargazers","contributors_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/contributors","subscribers_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/subscribers","subscription_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/subscription","commits_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/contents/{+path}","compare_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/merges","archive_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/downloads","issues_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/issues{/number}","pulls_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/pulls{/number}","milestones_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/milestones{/number}","notifications_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/labels{/name}","releases_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/releases{/id}","deployments_url":"https://api.github.com/repos/troglodyne/Selenium-Remote-Driver/deployments","created_at":"2017-08-08T01:32:20Z","updated_at":"2017-08-08T01:32:21Z","pushed_at":"2017-11-02T02:05:40Z","git_url":"git://github.com/troglodyne/Selenium-Remote-Driver.git","ssh_url":"[email protected]:troglodyne/Selenium-Remote-Driver.git","clone_url":"https://github.com/troglodyne/Selenium-Remote-Driver.git","svn_url":"https://github.com/troglodyne/Selenium-Remote-Driver","homepage":"","size":39487,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"teodesian:master","ref":"master","sha":"f9f6d9469e09d593f48c483883d0540069748dd5","user":{"login":"teodesian","id":8262579,"avatar_url":"https://avatars2.githubusercontent.com/u/8262579?v=4","gravatar_id":"","url":"https://api.github.com/users/teodesian","html_url":"https://github.com/teodesian","followers_url":"https://api.github.com/users/teodesian/followers","following_url":"https://api.github.com/users/teodesian/following{/other_user}","gists_url":"https://api.github.com/users/teodesian/gists{/gist_id}","starred_url":"https://api.github.com/users/teodesian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teodesian/subscriptions","organizations_url":"https://api.github.com/users/teodesian/orgs","repos_url":"https://api.github.com/users/teodesian/repos","events_url":"https://api.github.com/users/teodesian/events{/privacy}","received_events_url":"https://api.github.com/users/teodesian/received_events","type":"User","site_admin":false},"repo":{"id":529448,"name":"Selenium-Remote-Driver","full_name":"teodesian/Selenium-Remote-Driver","owner":{"login":"teodesian","id":8262579,"avatar_url":"https://avatars2.githubusercontent.com/u/8262579?v=4","gravatar_id":"","url":"https://api.github.com/users/teodesian","html_url":"https://github.com/teodesian","followers_url":"https://api.github.com/users/teodesian/followers","following_url":"https://api.github.com/users/teodesian/following{/other_user}","gists_url":"https://api.github.com/users/teodesian/gists{/gist_id}","starred_url":"https://api.github.com/users/teodesian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teodesian/subscriptions","organizations_url":"https://api.github.com/users/teodesian/orgs","repos_url":"https://api.github.com/users/teodesian/repos","events_url":"https://api.github.com/users/teodesian/events{/privacy}","received_events_url":"https://api.github.com/users/teodesian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/teodesian/Selenium-Remote-Driver","description":"Perl Bindings to the Selenium Webdriver server","fork":false,"url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver","forks_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/forks","keys_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/teams","hooks_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/hooks","issue_events_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/issues/events{/number}","events_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/events","assignees_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/assignees{/user}","branches_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/branches{/branch}","tags_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/tags","blobs_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/statuses/{sha}","languages_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/languages","stargazers_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/stargazers","contributors_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/contributors","subscribers_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/subscribers","subscription_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/subscription","commits_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/contents/{+path}","compare_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/merges","archive_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/downloads","issues_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/issues{/number}","pulls_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/pulls{/number}","milestones_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/milestones{/number}","notifications_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/labels{/name}","releases_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/releases{/id}","deployments_url":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/deployments","created_at":"2010-02-22T01:14:33Z","updated_at":"2017-10-20T09:47:50Z","pushed_at":"2017-11-02T01:44:40Z","git_url":"git://github.com/teodesian/Selenium-Remote-Driver.git","ssh_url":"[email protected]:teodesian/Selenium-Remote-Driver.git","clone_url":"https://github.com/teodesian/Selenium-Remote-Driver.git","svn_url":"https://github.com/teodesian/Selenium-Remote-Driver","homepage":"","size":39516,"stargazers_count":136,"watchers_count":136,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":26,"forks":75,"open_issues":26,"watchers":136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/pulls/332"},"html":{"href":"https://github.com/teodesian/Selenium-Remote-Driver/pull/332"},"issue":{"href":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/issues/332"},"comments":{"href":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/issues/332/comments"},"review_comments":{"href":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/pulls/332/comments"},"review_comment":{"href":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/pulls/332/commits"},"statuses":{"href":"https://api.github.com/repos/teodesian/Selenium-Remote-Driver/statuses/a4fa22a022ed08c89c4dfa274c866a781e321922"}},"author_association":"NONE"}} | {
"id": 529448,
"name": "teodesian/Selenium-Remote-Driver",
"url": "https://api.github.com/repos/teodesian/Selenium-Remote-Driver"
} | {
"id": 8262579,
"login": "teodesian",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8262579?",
"url": "https://api.github.com/users/teodesian"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-11-02T03:25:23 | 6798156935 | {"actor":{"display_login":"teodesian"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/pulls/comments/135711715","pull_request_review_id":59146850,"id":135711715,"diff_hunk":"@@ -0,0 +1,51 @@\n+using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Net;\n+using System.Threading.Tasks;\n+using System.Web.Http;\n+using TodoList.Api.Models;\n+\n+namespace TodoList.Api.Controllers\n+{\n+ public class NodesController : ApiController\n+ {\n+ private NodeModel[] Nodes { get; }\n+\n+ public NodesController()\n+ {\n+ Nodes = InitializeData().ToArray();\n+ }\n+\n+ [Route(\"api/v1/nodes\")]","path":"TodoList/TodoList.Api/Controllers/NodesController.cs","position":20,"original_position":20,"commit_id":"e8d405236c96b6d4e4de387eec692a670ccd5cec","original_commit_id":"e8d405236c96b6d4e4de387eec692a670ccd5cec","user":{"login":"Suzii","id":8047248,"avatar_url":"https://avatars1.githubusercontent.com/u/8047248?v=4","gravatar_id":"","url":"https://api.github.com/users/Suzii","html_url":"https://github.com/Suzii","followers_url":"https://api.github.com/users/Suzii/followers","following_url":"https://api.github.com/users/Suzii/following{/other_user}","gists_url":"https://api.github.com/users/Suzii/gists{/gist_id}","starred_url":"https://api.github.com/users/Suzii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Suzii/subscriptions","organizations_url":"https://api.github.com/users/Suzii/orgs","repos_url":"https://api.github.com/users/Suzii/repos","events_url":"https://api.github.com/users/Suzii/events{/privacy}","received_events_url":"https://api.github.com/users/Suzii/received_events","type":"User","site_admin":false},"body":"There is too much duplicity when you define routes. Either define route in `RoutesConfig.cs` or define one route for whole controller, not per method. (Something like `[Route(\"api/v{version:apiVersion}/Todos/{id:int?}\", Name = \"Todos\")]`)","created_at":"2017-08-29T07:23:54Z","updated_at":"2017-08-29T07:26:56Z","html_url":"https://github.com/Neytus/kentico-onboarding-cs/pull/2#discussion_r135711715","pull_request_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/pulls/comments/135711715"},"html":{"href":"https://github.com/Neytus/kentico-onboarding-cs/pull/2#discussion_r135711715"},"pull_request":{"href":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/pulls/2","id":134902551,"html_url":"https://github.com/Neytus/kentico-onboarding-cs/pull/2","diff_url":"https://github.com/Neytus/kentico-onboarding-cs/pull/2.diff","patch_url":"https://github.com/Neytus/kentico-onboarding-cs/pull/2.patch","issue_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/issues/2","number":2,"state":"open","locked":false,"title":"Features/task 1","user":{"login":"Neytus","id":11269013,"avatar_url":"https://avatars2.githubusercontent.com/u/11269013?v=4","gravatar_id":"","url":"https://api.github.com/users/Neytus","html_url":"https://github.com/Neytus","followers_url":"https://api.github.com/users/Neytus/followers","following_url":"https://api.github.com/users/Neytus/following{/other_user}","gists_url":"https://api.github.com/users/Neytus/gists{/gist_id}","starred_url":"https://api.github.com/users/Neytus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neytus/subscriptions","organizations_url":"https://api.github.com/users/Neytus/orgs","repos_url":"https://api.github.com/users/Neytus/repos","events_url":"https://api.github.com/users/Neytus/events{/privacy}","received_events_url":"https://api.github.com/users/Neytus/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-09T14:10:10Z","updated_at":"2017-08-29T07:26:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a1a6872d9f86fea711b8fb3a5dcd7049e685e4c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/pulls/2/commits","review_comments_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/pulls/2/comments","review_comment_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/issues/2/comments","statuses_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/statuses/e8d405236c96b6d4e4de387eec692a670ccd5cec","head":{"label":"Neytus:features/task-1","ref":"features/task-1","sha":"e8d405236c96b6d4e4de387eec692a670ccd5cec","user":{"login":"Neytus","id":11269013,"avatar_url":"https://avatars2.githubusercontent.com/u/11269013?v=4","gravatar_id":"","url":"https://api.github.com/users/Neytus","html_url":"https://github.com/Neytus","followers_url":"https://api.github.com/users/Neytus/followers","following_url":"https://api.github.com/users/Neytus/following{/other_user}","gists_url":"https://api.github.com/users/Neytus/gists{/gist_id}","starred_url":"https://api.github.com/users/Neytus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neytus/subscriptions","organizations_url":"https://api.github.com/users/Neytus/orgs","repos_url":"https://api.github.com/users/Neytus/repos","events_url":"https://api.github.com/users/Neytus/events{/privacy}","received_events_url":"https://api.github.com/users/Neytus/received_events","type":"User","site_admin":false},"repo":{"id":98990400,"name":"kentico-onboarding-cs","full_name":"Neytus/kentico-onboarding-cs","owner":{"login":"Neytus","id":11269013,"avatar_url":"https://avatars2.githubusercontent.com/u/11269013?v=4","gravatar_id":"","url":"https://api.github.com/users/Neytus","html_url":"https://github.com/Neytus","followers_url":"https://api.github.com/users/Neytus/followers","following_url":"https://api.github.com/users/Neytus/following{/other_user}","gists_url":"https://api.github.com/users/Neytus/gists{/gist_id}","starred_url":"https://api.github.com/users/Neytus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neytus/subscriptions","organizations_url":"https://api.github.com/users/Neytus/orgs","repos_url":"https://api.github.com/users/Neytus/repos","events_url":"https://api.github.com/users/Neytus/events{/privacy}","received_events_url":"https://api.github.com/users/Neytus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Neytus/kentico-onboarding-cs","description":null,"fork":false,"url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs","forks_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/forks","keys_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/teams","hooks_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/hooks","issue_events_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/issues/events{/number}","events_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/events","assignees_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/assignees{/user}","branches_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/branches{/branch}","tags_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/tags","blobs_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/statuses/{sha}","languages_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/languages","stargazers_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/stargazers","contributors_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/contributors","subscribers_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/subscribers","subscription_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/subscription","commits_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/contents/{+path}","compare_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/merges","archive_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/downloads","issues_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/issues{/number}","pulls_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/pulls{/number}","milestones_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/milestones{/number}","notifications_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/labels{/name}","releases_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/releases{/id}","deployments_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/deployments","created_at":"2017-08-01T10:41:41Z","updated_at":"2017-08-02T09:11:12Z","pushed_at":"2017-08-28T13:55:42Z","git_url":"git://github.com/Neytus/kentico-onboarding-cs.git","ssh_url":"[email protected]:Neytus/kentico-onboarding-cs.git","clone_url":"https://github.com/Neytus/kentico-onboarding-cs.git","svn_url":"https://github.com/Neytus/kentico-onboarding-cs","homepage":null,"size":78,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Neytus:master","ref":"master","sha":"77da0ad8c47ab6d423e4d224b5eafa9b227fece7","user":{"login":"Neytus","id":11269013,"avatar_url":"https://avatars2.githubusercontent.com/u/11269013?v=4","gravatar_id":"","url":"https://api.github.com/users/Neytus","html_url":"https://github.com/Neytus","followers_url":"https://api.github.com/users/Neytus/followers","following_url":"https://api.github.com/users/Neytus/following{/other_user}","gists_url":"https://api.github.com/users/Neytus/gists{/gist_id}","starred_url":"https://api.github.com/users/Neytus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neytus/subscriptions","organizations_url":"https://api.github.com/users/Neytus/orgs","repos_url":"https://api.github.com/users/Neytus/repos","events_url":"https://api.github.com/users/Neytus/events{/privacy}","received_events_url":"https://api.github.com/users/Neytus/received_events","type":"User","site_admin":false},"repo":{"id":98990400,"name":"kentico-onboarding-cs","full_name":"Neytus/kentico-onboarding-cs","owner":{"login":"Neytus","id":11269013,"avatar_url":"https://avatars2.githubusercontent.com/u/11269013?v=4","gravatar_id":"","url":"https://api.github.com/users/Neytus","html_url":"https://github.com/Neytus","followers_url":"https://api.github.com/users/Neytus/followers","following_url":"https://api.github.com/users/Neytus/following{/other_user}","gists_url":"https://api.github.com/users/Neytus/gists{/gist_id}","starred_url":"https://api.github.com/users/Neytus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neytus/subscriptions","organizations_url":"https://api.github.com/users/Neytus/orgs","repos_url":"https://api.github.com/users/Neytus/repos","events_url":"https://api.github.com/users/Neytus/events{/privacy}","received_events_url":"https://api.github.com/users/Neytus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Neytus/kentico-onboarding-cs","description":null,"fork":false,"url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs","forks_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/forks","keys_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/teams","hooks_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/hooks","issue_events_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/issues/events{/number}","events_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/events","assignees_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/assignees{/user}","branches_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/branches{/branch}","tags_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/tags","blobs_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/statuses/{sha}","languages_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/languages","stargazers_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/stargazers","contributors_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/contributors","subscribers_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/subscribers","subscription_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/subscription","commits_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/contents/{+path}","compare_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/merges","archive_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/downloads","issues_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/issues{/number}","pulls_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/pulls{/number}","milestones_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/milestones{/number}","notifications_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/labels{/name}","releases_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/releases{/id}","deployments_url":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/deployments","created_at":"2017-08-01T10:41:41Z","updated_at":"2017-08-02T09:11:12Z","pushed_at":"2017-08-28T13:55:42Z","git_url":"git://github.com/Neytus/kentico-onboarding-cs.git","ssh_url":"[email protected]:Neytus/kentico-onboarding-cs.git","clone_url":"https://github.com/Neytus/kentico-onboarding-cs.git","svn_url":"https://github.com/Neytus/kentico-onboarding-cs","homepage":null,"size":78,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/pulls/2"},"html":{"href":"https://github.com/Neytus/kentico-onboarding-cs/pull/2"},"issue":{"href":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/issues/2"},"comments":{"href":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/Neytus/kentico-onboarding-cs/statuses/e8d405236c96b6d4e4de387eec692a670ccd5cec"}}}} | {
"id": 98990400,
"name": "Neytus/kentico-onboarding-cs",
"url": "https://api.github.com/repos/Neytus/kentico-onboarding-cs"
} | {
"id": 8047248,
"login": "Suzii",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8047248?",
"url": "https://api.github.com/users/Suzii"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-08-29T07:23:54 | 6523147785 | {"actor":{"display_login":"Suzii"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rg3/youtube-dl/pulls/comments/121263787","pull_request_review_id":43303620,"id":121263787,"diff_hunk":"@@ -0,0 +1,57 @@\n+# coding: utf-8\n+from __future__ import unicode_literals\n+\n+from .common import InfoExtractor\n+from ..utils import urljoin\n+\n+\n+class PicosongIE(InfoExtractor):\n+ _VALID_URL = r'https?://(?:www\\.)?picosong\\.com/(?P<id>[0-9A-Za-z]{4})'\n+ _TESTS = [{\n+ 'url': 'http://picosong.com/7uer/',\n+ 'md5': '7f2ee011ba3ca2ac180a35deb10feabf',\n+ 'info_dict': {\n+ 'id': '7uer',\n+ 'ext': 'mp3',\n+ 'artist': 'Xarlable',\n+ 'title': 'Rock My Forum',\n+ 'album': 'Epic',\n+ 'genre': 'Howto & Style',\n+ },\n+ }, {\n+ 'url': 'http://picosong.com/i3gs/',\n+ 'md5': 'd4ec5d64d97e28b45d2710c096c29f70',\n+ 'info_dict': {\n+ 'id': 'i3gs',\n+ 'ext': 'mp3',\n+ 'title': 'Rick.mp3',\n+ },\n+ }]\n+\n+ def _real_extract(self, url):\n+ def extract_info_td(key, fatal=True):\n+ return self._html_search_regex(\n+ r'%s:</td>\\s*<td class=\"value\">([^<]*)</td>' % (key.capitalize(), ),\n+ page, key, fatal=fatal)\n+\n+ video_id = self._match_id(url)\n+\n+ page = self._download_webpage(url, video_id)\n+ # <param name=\"movie\" value=\"/static/swf/picoplayer.swf?file=/cdn/085a4492f79c0c487bb656afa902213e.mp3\"/>\n+ download_path = self._search_regex(\n+ r'value=\"/static/swf/picoplayer.swf\\?file=([^\"]+)\"',\n+ page, 'url')\n+ download_url = urljoin(url, download_path)\n+\n+ title = extract_info_td('title')\n+ if not title:\n+ title = extract_info_td('filename')","path":"youtube_dl/extractor/picosong.py","position":48,"original_position":48,"commit_id":"1b94e71dbc5b0eec311f1b969fc5b4b836145f17","original_commit_id":"1b94e71dbc5b0eec311f1b969fc5b4b836145f17","user":{"login":"magcius","id":40890,"avatar_url":"https://avatars2.githubusercontent.com/u/40890?v=3","gravatar_id":"","url":"https://api.github.com/users/magcius","html_url":"https://github.com/magcius","followers_url":"https://api.github.com/users/magcius/followers","following_url":"https://api.github.com/users/magcius/following{/other_user}","gists_url":"https://api.github.com/users/magcius/gists{/gist_id}","starred_url":"https://api.github.com/users/magcius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magcius/subscriptions","organizations_url":"https://api.github.com/users/magcius/orgs","repos_url":"https://api.github.com/users/magcius/repos","events_url":"https://api.github.com/users/magcius/events{/privacy}","received_events_url":"https://api.github.com/users/magcius/received_events","type":"User","site_admin":false},"body":"Confirmed that this is reachable in the case of the second test, Rick.mp3","created_at":"2017-06-10T18:47:15Z","updated_at":"2017-06-10T18:47:15Z","html_url":"https://github.com/rg3/youtube-dl/pull/13315#discussion_r121263787","pull_request_url":"https://api.github.com/repos/rg3/youtube-dl/pulls/13315","_links":{"self":{"href":"https://api.github.com/repos/rg3/youtube-dl/pulls/comments/121263787"},"html":{"href":"https://github.com/rg3/youtube-dl/pull/13315#discussion_r121263787"},"pull_request":{"href":"https://api.github.com/repos/rg3/youtube-dl/pulls/13315"}}},"pull_request":{"url":"https://api.github.com/repos/rg3/youtube-dl/pulls/13315","id":124558094,"html_url":"https://github.com/rg3/youtube-dl/pull/13315","diff_url":"https://github.com/rg3/youtube-dl/pull/13315.diff","patch_url":"https://github.com/rg3/youtube-dl/pull/13315.patch","issue_url":"https://api.github.com/repos/rg3/youtube-dl/issues/13315","number":13315,"state":"open","locked":false,"title":"[picosong] Add new extractor","user":{"login":"magcius","id":40890,"avatar_url":"https://avatars2.githubusercontent.com/u/40890?v=3","gravatar_id":"","url":"https://api.github.com/users/magcius","html_url":"https://github.com/magcius","followers_url":"https://api.github.com/users/magcius/followers","following_url":"https://api.github.com/users/magcius/following{/other_user}","gists_url":"https://api.github.com/users/magcius/gists{/gist_id}","starred_url":"https://api.github.com/users/magcius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magcius/subscriptions","organizations_url":"https://api.github.com/users/magcius/orgs","repos_url":"https://api.github.com/users/magcius/repos","events_url":"https://api.github.com/users/magcius/events{/privacy}","received_events_url":"https://api.github.com/users/magcius/received_events","type":"User","site_admin":false},"body":"## Please follow the guide below\r\n\r\n- You will be asked some questions, please read them **carefully** and answer honestly\r\n- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])\r\n- Use *Preview* tab to see how your *pull request* will actually look like\r\n\r\n---\r\n\r\n### Before submitting a *pull request* make sure you have:\r\n- [x] At least skimmed through [adding new extractor tutorial](https://github.com/rg3/youtube-dl#adding-support-for-a-new-site) and [youtube-dl coding conventions](https://github.com/rg3/youtube-dl#youtube-dl-coding-conventions) sections\r\n- [x] [Searched](https://github.com/rg3/youtube-dl/search?q=is%3Apr&type=Issues) the bugtracker for similar pull requests\r\n\r\n### In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under [Unlicense](http://unlicense.org/). Check one of the following options:\r\n- [x] I am the original author of this code and I am willing to release it under [Unlicense](http://unlicense.org/)\r\n- [ ] I am not the original author of this code but it is in public domain or released under [Unlicense](http://unlicense.org/) (provide reliable evidence)\r\n\r\n### What is the purpose of your *pull request*?\r\n- [ ] Bug fix\r\n- [ ] Improvement\r\n- [x] New extractor\r\n- [ ] New feature\r\n\r\n---\r\n\r\n### Description of your *pull request* and other information\r\n\r\nAdded an extractor for a popular music sharing website, picosong. A team of a project I work on often uses this site to share mp3 files and I wanted to automate a large part of the work we currently do manually. YouTube-DL seemed like a good fit for the job.","created_at":"2017-06-08T02:57:27Z","updated_at":"2017-06-10T18:47:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aae20ede872206c2bb0bdff60d17c51882fd1fb9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rg3/youtube-dl/pulls/13315/commits","review_comments_url":"https://api.github.com/repos/rg3/youtube-dl/pulls/13315/comments","review_comment_url":"https://api.github.com/repos/rg3/youtube-dl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rg3/youtube-dl/issues/13315/comments","statuses_url":"https://api.github.com/repos/rg3/youtube-dl/statuses/1b94e71dbc5b0eec311f1b969fc5b4b836145f17","head":{"label":"magcius:picosong","ref":"picosong","sha":"1b94e71dbc5b0eec311f1b969fc5b4b836145f17","user":{"login":"magcius","id":40890,"avatar_url":"https://avatars2.githubusercontent.com/u/40890?v=3","gravatar_id":"","url":"https://api.github.com/users/magcius","html_url":"https://github.com/magcius","followers_url":"https://api.github.com/users/magcius/followers","following_url":"https://api.github.com/users/magcius/following{/other_user}","gists_url":"https://api.github.com/users/magcius/gists{/gist_id}","starred_url":"https://api.github.com/users/magcius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magcius/subscriptions","organizations_url":"https://api.github.com/users/magcius/orgs","repos_url":"https://api.github.com/users/magcius/repos","events_url":"https://api.github.com/users/magcius/events{/privacy}","received_events_url":"https://api.github.com/users/magcius/received_events","type":"User","site_admin":false},"repo":{"id":93654346,"name":"youtube-dl","full_name":"magcius/youtube-dl","owner":{"login":"magcius","id":40890,"avatar_url":"https://avatars2.githubusercontent.com/u/40890?v=3","gravatar_id":"","url":"https://api.github.com/users/magcius","html_url":"https://github.com/magcius","followers_url":"https://api.github.com/users/magcius/followers","following_url":"https://api.github.com/users/magcius/following{/other_user}","gists_url":"https://api.github.com/users/magcius/gists{/gist_id}","starred_url":"https://api.github.com/users/magcius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magcius/subscriptions","organizations_url":"https://api.github.com/users/magcius/orgs","repos_url":"https://api.github.com/users/magcius/repos","events_url":"https://api.github.com/users/magcius/events{/privacy}","received_events_url":"https://api.github.com/users/magcius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/magcius/youtube-dl","description":"Command-line program to download videos from YouTube.com and other video sites","fork":true,"url":"https://api.github.com/repos/magcius/youtube-dl","forks_url":"https://api.github.com/repos/magcius/youtube-dl/forks","keys_url":"https://api.github.com/repos/magcius/youtube-dl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magcius/youtube-dl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magcius/youtube-dl/teams","hooks_url":"https://api.github.com/repos/magcius/youtube-dl/hooks","issue_events_url":"https://api.github.com/repos/magcius/youtube-dl/issues/events{/number}","events_url":"https://api.github.com/repos/magcius/youtube-dl/events","assignees_url":"https://api.github.com/repos/magcius/youtube-dl/assignees{/user}","branches_url":"https://api.github.com/repos/magcius/youtube-dl/branches{/branch}","tags_url":"https://api.github.com/repos/magcius/youtube-dl/tags","blobs_url":"https://api.github.com/repos/magcius/youtube-dl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magcius/youtube-dl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magcius/youtube-dl/git/refs{/sha}","trees_url":"https://api.github.com/repos/magcius/youtube-dl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magcius/youtube-dl/statuses/{sha}","languages_url":"https://api.github.com/repos/magcius/youtube-dl/languages","stargazers_url":"https://api.github.com/repos/magcius/youtube-dl/stargazers","contributors_url":"https://api.github.com/repos/magcius/youtube-dl/contributors","subscribers_url":"https://api.github.com/repos/magcius/youtube-dl/subscribers","subscription_url":"https://api.github.com/repos/magcius/youtube-dl/subscription","commits_url":"https://api.github.com/repos/magcius/youtube-dl/commits{/sha}","git_commits_url":"https://api.github.com/repos/magcius/youtube-dl/git/commits{/sha}","comments_url":"https://api.github.com/repos/magcius/youtube-dl/comments{/number}","issue_comment_url":"https://api.github.com/repos/magcius/youtube-dl/issues/comments{/number}","contents_url":"https://api.github.com/repos/magcius/youtube-dl/contents/{+path}","compare_url":"https://api.github.com/repos/magcius/youtube-dl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magcius/youtube-dl/merges","archive_url":"https://api.github.com/repos/magcius/youtube-dl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magcius/youtube-dl/downloads","issues_url":"https://api.github.com/repos/magcius/youtube-dl/issues{/number}","pulls_url":"https://api.github.com/repos/magcius/youtube-dl/pulls{/number}","milestones_url":"https://api.github.com/repos/magcius/youtube-dl/milestones{/number}","notifications_url":"https://api.github.com/repos/magcius/youtube-dl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magcius/youtube-dl/labels{/name}","releases_url":"https://api.github.com/repos/magcius/youtube-dl/releases{/id}","deployments_url":"https://api.github.com/repos/magcius/youtube-dl/deployments","created_at":"2017-06-07T16:04:57Z","updated_at":"2017-06-07T16:05:28Z","pushed_at":"2017-06-10T18:15:51Z","git_url":"git://github.com/magcius/youtube-dl.git","ssh_url":"[email protected]:magcius/youtube-dl.git","clone_url":"https://github.com/magcius/youtube-dl.git","svn_url":"https://github.com/magcius/youtube-dl","homepage":"http://rg3.github.io/youtube-dl/","size":47377,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rg3:master","ref":"master","sha":"4e3637034cf2b3630e6f9c6d34aa0177a8c83950","user":{"login":"rg3","id":53487,"avatar_url":"https://avatars3.githubusercontent.com/u/53487?v=3","gravatar_id":"","url":"https://api.github.com/users/rg3","html_url":"https://github.com/rg3","followers_url":"https://api.github.com/users/rg3/followers","following_url":"https://api.github.com/users/rg3/following{/other_user}","gists_url":"https://api.github.com/users/rg3/gists{/gist_id}","starred_url":"https://api.github.com/users/rg3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rg3/subscriptions","organizations_url":"https://api.github.com/users/rg3/orgs","repos_url":"https://api.github.com/users/rg3/repos","events_url":"https://api.github.com/users/rg3/events{/privacy}","received_events_url":"https://api.github.com/users/rg3/received_events","type":"User","site_admin":false},"repo":{"id":1039520,"name":"youtube-dl","full_name":"rg3/youtube-dl","owner":{"login":"rg3","id":53487,"avatar_url":"https://avatars3.githubusercontent.com/u/53487?v=3","gravatar_id":"","url":"https://api.github.com/users/rg3","html_url":"https://github.com/rg3","followers_url":"https://api.github.com/users/rg3/followers","following_url":"https://api.github.com/users/rg3/following{/other_user}","gists_url":"https://api.github.com/users/rg3/gists{/gist_id}","starred_url":"https://api.github.com/users/rg3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rg3/subscriptions","organizations_url":"https://api.github.com/users/rg3/orgs","repos_url":"https://api.github.com/users/rg3/repos","events_url":"https://api.github.com/users/rg3/events{/privacy}","received_events_url":"https://api.github.com/users/rg3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rg3/youtube-dl","description":"Command-line program to download videos from YouTube.com and other video sites","fork":false,"url":"https://api.github.com/repos/rg3/youtube-dl","forks_url":"https://api.github.com/repos/rg3/youtube-dl/forks","keys_url":"https://api.github.com/repos/rg3/youtube-dl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rg3/youtube-dl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rg3/youtube-dl/teams","hooks_url":"https://api.github.com/repos/rg3/youtube-dl/hooks","issue_events_url":"https://api.github.com/repos/rg3/youtube-dl/issues/events{/number}","events_url":"https://api.github.com/repos/rg3/youtube-dl/events","assignees_url":"https://api.github.com/repos/rg3/youtube-dl/assignees{/user}","branches_url":"https://api.github.com/repos/rg3/youtube-dl/branches{/branch}","tags_url":"https://api.github.com/repos/rg3/youtube-dl/tags","blobs_url":"https://api.github.com/repos/rg3/youtube-dl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rg3/youtube-dl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rg3/youtube-dl/git/refs{/sha}","trees_url":"https://api.github.com/repos/rg3/youtube-dl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rg3/youtube-dl/statuses/{sha}","languages_url":"https://api.github.com/repos/rg3/youtube-dl/languages","stargazers_url":"https://api.github.com/repos/rg3/youtube-dl/stargazers","contributors_url":"https://api.github.com/repos/rg3/youtube-dl/contributors","subscribers_url":"https://api.github.com/repos/rg3/youtube-dl/subscribers","subscription_url":"https://api.github.com/repos/rg3/youtube-dl/subscription","commits_url":"https://api.github.com/repos/rg3/youtube-dl/commits{/sha}","git_commits_url":"https://api.github.com/repos/rg3/youtube-dl/git/commits{/sha}","comments_url":"https://api.github.com/repos/rg3/youtube-dl/comments{/number}","issue_comment_url":"https://api.github.com/repos/rg3/youtube-dl/issues/comments{/number}","contents_url":"https://api.github.com/repos/rg3/youtube-dl/contents/{+path}","compare_url":"https://api.github.com/repos/rg3/youtube-dl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rg3/youtube-dl/merges","archive_url":"https://api.github.com/repos/rg3/youtube-dl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rg3/youtube-dl/downloads","issues_url":"https://api.github.com/repos/rg3/youtube-dl/issues{/number}","pulls_url":"https://api.github.com/repos/rg3/youtube-dl/pulls{/number}","milestones_url":"https://api.github.com/repos/rg3/youtube-dl/milestones{/number}","notifications_url":"https://api.github.com/repos/rg3/youtube-dl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rg3/youtube-dl/labels{/name}","releases_url":"https://api.github.com/repos/rg3/youtube-dl/releases{/id}","deployments_url":"https://api.github.com/repos/rg3/youtube-dl/deployments","created_at":"2010-10-31T14:35:07Z","updated_at":"2017-06-10T18:37:59Z","pushed_at":"2017-06-10T18:15:54Z","git_url":"git://github.com/rg3/youtube-dl.git","ssh_url":"[email protected]:rg3/youtube-dl.git","clone_url":"https://github.com/rg3/youtube-dl.git","svn_url":"https://github.com/rg3/youtube-dl","homepage":"http://rg3.github.io/youtube-dl/","size":47552,"stargazers_count":26541,"watchers_count":26541,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5029,"mirror_url":null,"open_issues_count":1693,"forks":5029,"open_issues":1693,"watchers":26541,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rg3/youtube-dl/pulls/13315"},"html":{"href":"https://github.com/rg3/youtube-dl/pull/13315"},"issue":{"href":"https://api.github.com/repos/rg3/youtube-dl/issues/13315"},"comments":{"href":"https://api.github.com/repos/rg3/youtube-dl/issues/13315/comments"},"review_comments":{"href":"https://api.github.com/repos/rg3/youtube-dl/pulls/13315/comments"},"review_comment":{"href":"https://api.github.com/repos/rg3/youtube-dl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rg3/youtube-dl/pulls/13315/commits"},"statuses":{"href":"https://api.github.com/repos/rg3/youtube-dl/statuses/1b94e71dbc5b0eec311f1b969fc5b4b836145f17"}}}} | {
"id": 1039520,
"name": "rg3/youtube-dl",
"url": "https://api.github.com/repos/rg3/youtube-dl"
} | {
"id": 40890,
"login": "magcius",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/40890?",
"url": "https://api.github.com/users/magcius"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-06-10T18:47:15 | 6040908529 | {"actor":{"display_login":"magcius"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/alexvis/park-planner/pulls/comments/129906247","pull_request_review_id":52728352,"id":129906247,"diff_hunk":"@@ -0,0 +1,17 @@\n+import React from 'react'\n+\n+class NewReviewForm extends React.Component {\n+ constructor(props) {\n+ super(props)\n+ this.state = {\n+ }\n+ }\n+\n+ render() {\n+ return(\n+ \n+ )","path":"react/src/components/NewReviewForm.js","position":13,"original_position":13,"commit_id":"ff72ccb5c73fe839f0d0c953fb3eaa38a7dd7fe0","original_commit_id":"ff72ccb5c73fe839f0d0c953fb3eaa38a7dd7fe0","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Missing semicolon.","created_at":"2017-07-27T17:29:54Z","updated_at":"2017-07-27T17:29:55Z","html_url":"https://github.com/alexvis/park-planner/pull/26#discussion_r129906247","pull_request_url":"https://api.github.com/repos/alexvis/park-planner/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/alexvis/park-planner/pulls/comments/129906247"},"html":{"href":"https://github.com/alexvis/park-planner/pull/26#discussion_r129906247"},"pull_request":{"href":"https://api.github.com/repos/alexvis/park-planner/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/alexvis/park-planner/pulls/26","id":132803457,"html_url":"https://github.com/alexvis/park-planner/pull/26","diff_url":"https://github.com/alexvis/park-planner/pull/26.diff","patch_url":"https://github.com/alexvis/park-planner/pull/26.patch","issue_url":"https://api.github.com/repos/alexvis/park-planner/issues/26","number":26,"state":"open","locked":false,"title":"Serch park","user":{"login":"JesseChamberlain","id":22745225,"avatar_url":"https://avatars1.githubusercontent.com/u/22745225?v=4","gravatar_id":"","url":"https://api.github.com/users/JesseChamberlain","html_url":"https://github.com/JesseChamberlain","followers_url":"https://api.github.com/users/JesseChamberlain/followers","following_url":"https://api.github.com/users/JesseChamberlain/following{/other_user}","gists_url":"https://api.github.com/users/JesseChamberlain/gists{/gist_id}","starred_url":"https://api.github.com/users/JesseChamberlain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JesseChamberlain/subscriptions","organizations_url":"https://api.github.com/users/JesseChamberlain/orgs","repos_url":"https://api.github.com/users/JesseChamberlain/repos","events_url":"https://api.github.com/users/JesseChamberlain/events{/privacy}","received_events_url":"https://api.github.com/users/JesseChamberlain/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-27T17:29:47Z","updated_at":"2017-07-27T17:29:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/alexvis/park-planner/pulls/26/commits","review_comments_url":"https://api.github.com/repos/alexvis/park-planner/pulls/26/comments","review_comment_url":"https://api.github.com/repos/alexvis/park-planner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alexvis/park-planner/issues/26/comments","statuses_url":"https://api.github.com/repos/alexvis/park-planner/statuses/ff72ccb5c73fe839f0d0c953fb3eaa38a7dd7fe0","head":{"label":"alexvis:serch-park","ref":"serch-park","sha":"ff72ccb5c73fe839f0d0c953fb3eaa38a7dd7fe0","user":{"login":"alexvis","id":27140656,"avatar_url":"https://avatars3.githubusercontent.com/u/27140656?v=4","gravatar_id":"","url":"https://api.github.com/users/alexvis","html_url":"https://github.com/alexvis","followers_url":"https://api.github.com/users/alexvis/followers","following_url":"https://api.github.com/users/alexvis/following{/other_user}","gists_url":"https://api.github.com/users/alexvis/gists{/gist_id}","starred_url":"https://api.github.com/users/alexvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexvis/subscriptions","organizations_url":"https://api.github.com/users/alexvis/orgs","repos_url":"https://api.github.com/users/alexvis/repos","events_url":"https://api.github.com/users/alexvis/events{/privacy}","received_events_url":"https://api.github.com/users/alexvis/received_events","type":"User","site_admin":false},"repo":{"id":97501432,"name":"park-planner","full_name":"alexvis/park-planner","owner":{"login":"alexvis","id":27140656,"avatar_url":"https://avatars3.githubusercontent.com/u/27140656?v=4","gravatar_id":"","url":"https://api.github.com/users/alexvis","html_url":"https://github.com/alexvis","followers_url":"https://api.github.com/users/alexvis/followers","following_url":"https://api.github.com/users/alexvis/following{/other_user}","gists_url":"https://api.github.com/users/alexvis/gists{/gist_id}","starred_url":"https://api.github.com/users/alexvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexvis/subscriptions","organizations_url":"https://api.github.com/users/alexvis/orgs","repos_url":"https://api.github.com/users/alexvis/repos","events_url":"https://api.github.com/users/alexvis/events{/privacy}","received_events_url":"https://api.github.com/users/alexvis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexvis/park-planner","description":null,"fork":false,"url":"https://api.github.com/repos/alexvis/park-planner","forks_url":"https://api.github.com/repos/alexvis/park-planner/forks","keys_url":"https://api.github.com/repos/alexvis/park-planner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexvis/park-planner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexvis/park-planner/teams","hooks_url":"https://api.github.com/repos/alexvis/park-planner/hooks","issue_events_url":"https://api.github.com/repos/alexvis/park-planner/issues/events{/number}","events_url":"https://api.github.com/repos/alexvis/park-planner/events","assignees_url":"https://api.github.com/repos/alexvis/park-planner/assignees{/user}","branches_url":"https://api.github.com/repos/alexvis/park-planner/branches{/branch}","tags_url":"https://api.github.com/repos/alexvis/park-planner/tags","blobs_url":"https://api.github.com/repos/alexvis/park-planner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexvis/park-planner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexvis/park-planner/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexvis/park-planner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexvis/park-planner/statuses/{sha}","languages_url":"https://api.github.com/repos/alexvis/park-planner/languages","stargazers_url":"https://api.github.com/repos/alexvis/park-planner/stargazers","contributors_url":"https://api.github.com/repos/alexvis/park-planner/contributors","subscribers_url":"https://api.github.com/repos/alexvis/park-planner/subscribers","subscription_url":"https://api.github.com/repos/alexvis/park-planner/subscription","commits_url":"https://api.github.com/repos/alexvis/park-planner/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexvis/park-planner/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexvis/park-planner/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexvis/park-planner/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexvis/park-planner/contents/{+path}","compare_url":"https://api.github.com/repos/alexvis/park-planner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexvis/park-planner/merges","archive_url":"https://api.github.com/repos/alexvis/park-planner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexvis/park-planner/downloads","issues_url":"https://api.github.com/repos/alexvis/park-planner/issues{/number}","pulls_url":"https://api.github.com/repos/alexvis/park-planner/pulls{/number}","milestones_url":"https://api.github.com/repos/alexvis/park-planner/milestones{/number}","notifications_url":"https://api.github.com/repos/alexvis/park-planner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexvis/park-planner/labels{/name}","releases_url":"https://api.github.com/repos/alexvis/park-planner/releases{/id}","deployments_url":"https://api.github.com/repos/alexvis/park-planner/deployments","created_at":"2017-07-17T17:03:06Z","updated_at":"2017-07-17T17:04:00Z","pushed_at":"2017-07-27T17:29:47Z","git_url":"git://github.com/alexvis/park-planner.git","ssh_url":"[email protected]:alexvis/park-planner.git","clone_url":"https://github.com/alexvis/park-planner.git","svn_url":"https://github.com/alexvis/park-planner","homepage":null,"size":2380,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"alexvis:master","ref":"master","sha":"3f9bae6121aceb166d7bc7cca32d3262e0f4df48","user":{"login":"alexvis","id":27140656,"avatar_url":"https://avatars3.githubusercontent.com/u/27140656?v=4","gravatar_id":"","url":"https://api.github.com/users/alexvis","html_url":"https://github.com/alexvis","followers_url":"https://api.github.com/users/alexvis/followers","following_url":"https://api.github.com/users/alexvis/following{/other_user}","gists_url":"https://api.github.com/users/alexvis/gists{/gist_id}","starred_url":"https://api.github.com/users/alexvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexvis/subscriptions","organizations_url":"https://api.github.com/users/alexvis/orgs","repos_url":"https://api.github.com/users/alexvis/repos","events_url":"https://api.github.com/users/alexvis/events{/privacy}","received_events_url":"https://api.github.com/users/alexvis/received_events","type":"User","site_admin":false},"repo":{"id":97501432,"name":"park-planner","full_name":"alexvis/park-planner","owner":{"login":"alexvis","id":27140656,"avatar_url":"https://avatars3.githubusercontent.com/u/27140656?v=4","gravatar_id":"","url":"https://api.github.com/users/alexvis","html_url":"https://github.com/alexvis","followers_url":"https://api.github.com/users/alexvis/followers","following_url":"https://api.github.com/users/alexvis/following{/other_user}","gists_url":"https://api.github.com/users/alexvis/gists{/gist_id}","starred_url":"https://api.github.com/users/alexvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexvis/subscriptions","organizations_url":"https://api.github.com/users/alexvis/orgs","repos_url":"https://api.github.com/users/alexvis/repos","events_url":"https://api.github.com/users/alexvis/events{/privacy}","received_events_url":"https://api.github.com/users/alexvis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexvis/park-planner","description":null,"fork":false,"url":"https://api.github.com/repos/alexvis/park-planner","forks_url":"https://api.github.com/repos/alexvis/park-planner/forks","keys_url":"https://api.github.com/repos/alexvis/park-planner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexvis/park-planner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexvis/park-planner/teams","hooks_url":"https://api.github.com/repos/alexvis/park-planner/hooks","issue_events_url":"https://api.github.com/repos/alexvis/park-planner/issues/events{/number}","events_url":"https://api.github.com/repos/alexvis/park-planner/events","assignees_url":"https://api.github.com/repos/alexvis/park-planner/assignees{/user}","branches_url":"https://api.github.com/repos/alexvis/park-planner/branches{/branch}","tags_url":"https://api.github.com/repos/alexvis/park-planner/tags","blobs_url":"https://api.github.com/repos/alexvis/park-planner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexvis/park-planner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexvis/park-planner/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexvis/park-planner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexvis/park-planner/statuses/{sha}","languages_url":"https://api.github.com/repos/alexvis/park-planner/languages","stargazers_url":"https://api.github.com/repos/alexvis/park-planner/stargazers","contributors_url":"https://api.github.com/repos/alexvis/park-planner/contributors","subscribers_url":"https://api.github.com/repos/alexvis/park-planner/subscribers","subscription_url":"https://api.github.com/repos/alexvis/park-planner/subscription","commits_url":"https://api.github.com/repos/alexvis/park-planner/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexvis/park-planner/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexvis/park-planner/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexvis/park-planner/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexvis/park-planner/contents/{+path}","compare_url":"https://api.github.com/repos/alexvis/park-planner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexvis/park-planner/merges","archive_url":"https://api.github.com/repos/alexvis/park-planner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexvis/park-planner/downloads","issues_url":"https://api.github.com/repos/alexvis/park-planner/issues{/number}","pulls_url":"https://api.github.com/repos/alexvis/park-planner/pulls{/number}","milestones_url":"https://api.github.com/repos/alexvis/park-planner/milestones{/number}","notifications_url":"https://api.github.com/repos/alexvis/park-planner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexvis/park-planner/labels{/name}","releases_url":"https://api.github.com/repos/alexvis/park-planner/releases{/id}","deployments_url":"https://api.github.com/repos/alexvis/park-planner/deployments","created_at":"2017-07-17T17:03:06Z","updated_at":"2017-07-17T17:04:00Z","pushed_at":"2017-07-27T17:29:47Z","git_url":"git://github.com/alexvis/park-planner.git","ssh_url":"[email protected]:alexvis/park-planner.git","clone_url":"https://github.com/alexvis/park-planner.git","svn_url":"https://github.com/alexvis/park-planner","homepage":null,"size":2380,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alexvis/park-planner/pulls/26"},"html":{"href":"https://github.com/alexvis/park-planner/pull/26"},"issue":{"href":"https://api.github.com/repos/alexvis/park-planner/issues/26"},"comments":{"href":"https://api.github.com/repos/alexvis/park-planner/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/alexvis/park-planner/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/alexvis/park-planner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alexvis/park-planner/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/alexvis/park-planner/statuses/ff72ccb5c73fe839f0d0c953fb3eaa38a7dd7fe0"}}}} | {
"id": 97501432,
"name": "alexvis/park-planner",
"url": "https://api.github.com/repos/alexvis/park-planner"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-07-27T17:29:54 | 6343377637 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments/110570267","pull_request_review_id":31752160,"id":110570267,"diff_hunk":"@@ -4676,7 +4676,7 @@ exports.BattleSide = BattleSide;\n exports.Battle = Battle;\n \n let battleProtoCache = new Map();\n-exports.construct = function (format, rated, send) {\n+exports.construct = function (format, rated, supplementaryRuleset, send) {","path":"battle-engine.js","position":34,"original_position":34,"commit_id":"08106f0b064260be1fa6fa90b06c30147a441386","original_commit_id":"08106f0b064260be1fa6fa90b06c30147a441386","user":{"login":"Zarel","id":551184,"avatar_url":"https://avatars0.githubusercontent.com/u/551184?v=3","gravatar_id":"","url":"https://api.github.com/users/Zarel","html_url":"https://github.com/Zarel","followers_url":"https://api.github.com/users/Zarel/followers","following_url":"https://api.github.com/users/Zarel/following{/other_user}","gists_url":"https://api.github.com/users/Zarel/gists{/gist_id}","starred_url":"https://api.github.com/users/Zarel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zarel/subscriptions","organizations_url":"https://api.github.com/users/Zarel/orgs","repos_url":"https://api.github.com/users/Zarel/repos","events_url":"https://api.github.com/users/Zarel/events{/privacy}","received_events_url":"https://api.github.com/users/Zarel/received_events","type":"User","site_admin":false},"body":"A `send` function is so passé though...\r\n\r\nI think maybe the format should be constructed outside of this function, so this function's signature stays unchanged.","created_at":"2017-04-10T04:30:14Z","updated_at":"2017-04-10T04:30:14Z","html_url":"https://github.com/Zarel/Pokemon-Showdown/pull/3330#discussion_r110570267","pull_request_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/3330","_links":{"self":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments/110570267"},"html":{"href":"https://github.com/Zarel/Pokemon-Showdown/pull/3330#discussion_r110570267"},"pull_request":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/3330"}}},"pull_request":{"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/3330","id":109096162,"html_url":"https://github.com/Zarel/Pokemon-Showdown/pull/3330","diff_url":"https://github.com/Zarel/Pokemon-Showdown/pull/3330.diff","patch_url":"https://github.com/Zarel/Pokemon-Showdown/pull/3330.patch","issue_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/3330","number":3330,"state":"open","locked":false,"title":"Support supplementary rulesets in battles","user":{"login":"sirDonovan","id":6309262,"avatar_url":"https://avatars3.githubusercontent.com/u/6309262?v=3","gravatar_id":"","url":"https://api.github.com/users/sirDonovan","html_url":"https://github.com/sirDonovan","followers_url":"https://api.github.com/users/sirDonovan/followers","following_url":"https://api.github.com/users/sirDonovan/following{/other_user}","gists_url":"https://api.github.com/users/sirDonovan/gists{/gist_id}","starred_url":"https://api.github.com/users/sirDonovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirDonovan/subscriptions","organizations_url":"https://api.github.com/users/sirDonovan/orgs","repos_url":"https://api.github.com/users/sirDonovan/repos","events_url":"https://api.github.com/users/sirDonovan/events{/privacy}","received_events_url":"https://api.github.com/users/sirDonovan/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-04T06:09:39Z","updated_at":"2017-04-10T04:30:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3b5ad38573ba4ae40fad587b95cc1e3411249d7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/3330/commits","review_comments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/3330/comments","review_comment_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/3330/comments","statuses_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/statuses/08106f0b064260be1fa6fa90b06c30147a441386","head":{"label":"sirDonovan:battle-rulesets","ref":"battle-rulesets","sha":"08106f0b064260be1fa6fa90b06c30147a441386","user":{"login":"sirDonovan","id":6309262,"avatar_url":"https://avatars3.githubusercontent.com/u/6309262?v=3","gravatar_id":"","url":"https://api.github.com/users/sirDonovan","html_url":"https://github.com/sirDonovan","followers_url":"https://api.github.com/users/sirDonovan/followers","following_url":"https://api.github.com/users/sirDonovan/following{/other_user}","gists_url":"https://api.github.com/users/sirDonovan/gists{/gist_id}","starred_url":"https://api.github.com/users/sirDonovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirDonovan/subscriptions","organizations_url":"https://api.github.com/users/sirDonovan/orgs","repos_url":"https://api.github.com/users/sirDonovan/repos","events_url":"https://api.github.com/users/sirDonovan/events{/privacy}","received_events_url":"https://api.github.com/users/sirDonovan/received_events","type":"User","site_admin":false},"repo":{"id":18902706,"name":"Pokemon-Showdown","full_name":"sirDonovan/Pokemon-Showdown","owner":{"login":"sirDonovan","id":6309262,"avatar_url":"https://avatars3.githubusercontent.com/u/6309262?v=3","gravatar_id":"","url":"https://api.github.com/users/sirDonovan","html_url":"https://github.com/sirDonovan","followers_url":"https://api.github.com/users/sirDonovan/followers","following_url":"https://api.github.com/users/sirDonovan/following{/other_user}","gists_url":"https://api.github.com/users/sirDonovan/gists{/gist_id}","starred_url":"https://api.github.com/users/sirDonovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirDonovan/subscriptions","organizations_url":"https://api.github.com/users/sirDonovan/orgs","repos_url":"https://api.github.com/users/sirDonovan/repos","events_url":"https://api.github.com/users/sirDonovan/events{/privacy}","received_events_url":"https://api.github.com/users/sirDonovan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sirDonovan/Pokemon-Showdown","description":"Pokémon battle simulator.","fork":true,"url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown","forks_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/forks","keys_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/teams","hooks_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/hooks","issue_events_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/issues/events{/number}","events_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/events","assignees_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/assignees{/user}","branches_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/branches{/branch}","tags_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/tags","blobs_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/statuses/{sha}","languages_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/languages","stargazers_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/stargazers","contributors_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/contributors","subscribers_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/subscribers","subscription_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/subscription","commits_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/issues/comments{/number}","contents_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/contents/{+path}","compare_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/merges","archive_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/downloads","issues_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/issues{/number}","pulls_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/pulls{/number}","milestones_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/milestones{/number}","notifications_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/labels{/name}","releases_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/releases{/id}","deployments_url":"https://api.github.com/repos/sirDonovan/Pokemon-Showdown/deployments","created_at":"2014-04-18T04:37:46Z","updated_at":"2016-01-12T21:02:26Z","pushed_at":"2017-04-09T06:46:00Z","git_url":"git://github.com/sirDonovan/Pokemon-Showdown.git","ssh_url":"[email protected]:sirDonovan/Pokemon-Showdown.git","clone_url":"https://github.com/sirDonovan/Pokemon-Showdown.git","svn_url":"https://github.com/sirDonovan/Pokemon-Showdown","homepage":"http://pokemonshowdown.com","size":47302,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Zarel:master","ref":"master","sha":"ecc769bfda986e781af2591e3d8ada40f44b3f35","user":{"login":"Zarel","id":551184,"avatar_url":"https://avatars0.githubusercontent.com/u/551184?v=3","gravatar_id":"","url":"https://api.github.com/users/Zarel","html_url":"https://github.com/Zarel","followers_url":"https://api.github.com/users/Zarel/followers","following_url":"https://api.github.com/users/Zarel/following{/other_user}","gists_url":"https://api.github.com/users/Zarel/gists{/gist_id}","starred_url":"https://api.github.com/users/Zarel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zarel/subscriptions","organizations_url":"https://api.github.com/users/Zarel/orgs","repos_url":"https://api.github.com/users/Zarel/repos","events_url":"https://api.github.com/users/Zarel/events{/privacy}","received_events_url":"https://api.github.com/users/Zarel/received_events","type":"User","site_admin":false},"repo":{"id":3038446,"name":"Pokemon-Showdown","full_name":"Zarel/Pokemon-Showdown","owner":{"login":"Zarel","id":551184,"avatar_url":"https://avatars0.githubusercontent.com/u/551184?v=3","gravatar_id":"","url":"https://api.github.com/users/Zarel","html_url":"https://github.com/Zarel","followers_url":"https://api.github.com/users/Zarel/followers","following_url":"https://api.github.com/users/Zarel/following{/other_user}","gists_url":"https://api.github.com/users/Zarel/gists{/gist_id}","starred_url":"https://api.github.com/users/Zarel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zarel/subscriptions","organizations_url":"https://api.github.com/users/Zarel/orgs","repos_url":"https://api.github.com/users/Zarel/repos","events_url":"https://api.github.com/users/Zarel/events{/privacy}","received_events_url":"https://api.github.com/users/Zarel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zarel/Pokemon-Showdown","description":"Pokémon battle simulator.","fork":false,"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown","forks_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/forks","keys_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/teams","hooks_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/hooks","issue_events_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/events{/number}","events_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/events","assignees_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/assignees{/user}","branches_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/branches{/branch}","tags_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/tags","blobs_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/statuses/{sha}","languages_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/languages","stargazers_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/stargazers","contributors_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/contributors","subscribers_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/subscribers","subscription_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/subscription","commits_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/contents/{+path}","compare_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/merges","archive_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/downloads","issues_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues{/number}","pulls_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls{/number}","milestones_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/milestones{/number}","notifications_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/labels{/name}","releases_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/releases{/id}","deployments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/deployments","created_at":"2011-12-23T04:52:33Z","updated_at":"2017-04-10T04:17:12Z","pushed_at":"2017-04-10T04:10:37Z","git_url":"git://github.com/Zarel/Pokemon-Showdown.git","ssh_url":"[email protected]:Zarel/Pokemon-Showdown.git","clone_url":"https://github.com/Zarel/Pokemon-Showdown.git","svn_url":"https://github.com/Zarel/Pokemon-Showdown","homepage":"http://pokemonshowdown.com","size":47419,"stargazers_count":1129,"watchers_count":1129,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1141,"mirror_url":null,"open_issues_count":58,"forks":1141,"open_issues":58,"watchers":1129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/3330"},"html":{"href":"https://github.com/Zarel/Pokemon-Showdown/pull/3330"},"issue":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/3330"},"comments":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/3330/comments"},"review_comments":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/3330/comments"},"review_comment":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/3330/commits"},"statuses":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/statuses/08106f0b064260be1fa6fa90b06c30147a441386"}}}} | {
"id": 3038446,
"name": "Zarel/Pokemon-Showdown",
"url": "https://api.github.com/repos/Zarel/Pokemon-Showdown"
} | {
"id": 551184,
"login": "Zarel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/551184?",
"url": "https://api.github.com/users/Zarel"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-04-10T04:30:14 | 5656928896 | {"actor":{"display_login":"Zarel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cbeust/testng/pulls/comments/150471276","pull_request_review_id":76023416,"id":150471276,"diff_hunk":"@@ -0,0 +1,69 @@\n+package org.testng;\n+\n+import com.google.inject.Injector;\n+import com.google.inject.Module;\n+import org.testng.annotations.Guice;\n+import org.testng.collections.Lists;\n+import org.testng.internal.ClassImpl;\n+import org.testng.internal.annotations.AnnotationHelper;\n+\n+import java.lang.annotation.Annotation;\n+import java.util.List;\n+\n+class GuiceHelper {\n+ private ITestContext context;\n+ GuiceHelper(ITestContext context) {\n+ this.context = context;\n+ }\n+\n+ public Injector getInjector(IClass iClass) {\n+ Annotation annotation = AnnotationHelper.findAnnotationSuperClasses(Guice.class, iClass.getRealClass());","path":"src/main/java/org/testng/GuiceHelper.java","position":null,"original_position":20,"commit_id":"a01c40d5ad59b42eb9116a9c31ec731a56ffcb3e","original_commit_id":"71589d708485e0be721f742fce4142635c2cbcd9","user":{"login":"juherr","id":254697,"avatar_url":"https://avatars1.githubusercontent.com/u/254697?v=4","gravatar_id":"","url":"https://api.github.com/users/juherr","html_url":"https://github.com/juherr","followers_url":"https://api.github.com/users/juherr/followers","following_url":"https://api.github.com/users/juherr/following{/other_user}","gists_url":"https://api.github.com/users/juherr/gists{/gist_id}","starred_url":"https://api.github.com/users/juherr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juherr/subscriptions","organizations_url":"https://api.github.com/users/juherr/orgs","repos_url":"https://api.github.com/users/juherr/repos","events_url":"https://api.github.com/users/juherr/events{/privacy}","received_events_url":"https://api.github.com/users/juherr/received_events","type":"User","site_admin":false},"body":"Maybe we can add something like:\r\n\r\n```java\r\n<A extends Annotation> A findAnnotationSuperClasses(Class<A> clazz, IClass iClass) {\r\n return AnnotationHelper.findAnnotationSuperClasses(clazz, iClass.getRealClass());\r\n}\r\n```","created_at":"2017-11-13T08:30:41Z","updated_at":"2017-11-13T08:30:41Z","html_url":"https://github.com/cbeust/testng/pull/1604#discussion_r150471276","pull_request_url":"https://api.github.com/repos/cbeust/testng/pulls/1604","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/cbeust/testng/pulls/comments/150471276"},"html":{"href":"https://github.com/cbeust/testng/pull/1604#discussion_r150471276"},"pull_request":{"href":"https://api.github.com/repos/cbeust/testng/pulls/1604"}},"in_reply_to_id":150421963},"pull_request":{"url":"https://api.github.com/repos/cbeust/testng/pulls/1604","id":152065534,"html_url":"https://github.com/cbeust/testng/pull/1604","diff_url":"https://github.com/cbeust/testng/pull/1604.diff","patch_url":"https://github.com/cbeust/testng/pull/1604.patch","issue_url":"https://api.github.com/repos/cbeust/testng/issues/1604","number":1604,"state":"open","locked":false,"title":"Refactoring TestRunner class","user":{"login":"krmahadevan","id":909773,"avatar_url":"https://avatars0.githubusercontent.com/u/909773?v=4","gravatar_id":"","url":"https://api.github.com/users/krmahadevan","html_url":"https://github.com/krmahadevan","followers_url":"https://api.github.com/users/krmahadevan/followers","following_url":"https://api.github.com/users/krmahadevan/following{/other_user}","gists_url":"https://api.github.com/users/krmahadevan/gists{/gist_id}","starred_url":"https://api.github.com/users/krmahadevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krmahadevan/subscriptions","organizations_url":"https://api.github.com/users/krmahadevan/orgs","repos_url":"https://api.github.com/users/krmahadevan/repos","events_url":"https://api.github.com/users/krmahadevan/events{/privacy}","received_events_url":"https://api.github.com/users/krmahadevan/received_events","type":"User","site_admin":false},"body":"* Extracted out un-related methods to their \r\nown utility classes.\r\n* Removed deprecated TestRunner constructors\r\n* Added unit tests.\r\n\r\nFixes # .\r\n\r\n### Did you remember to?\r\n\r\n- [ ] Add test case(s)\r\n- [ ] Update `CHANGES.txt`\r\n\r\nWe encourage pull requests that:\r\n\r\n* Add new features to TestNG (or)\r\n* Fix bugs in TestNG\r\n\r\nIf your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the \r\n[TestNG-dev](https://groups.google.com/forum/#!forum/testng-dev) before you spend time working on it.\r\n","created_at":"2017-11-11T17:11:41Z","updated_at":"2017-11-13T08:30:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cec6991d521beca24bd781da9346e3cca8b4a7c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cbeust/testng/pulls/1604/commits","review_comments_url":"https://api.github.com/repos/cbeust/testng/pulls/1604/comments","review_comment_url":"https://api.github.com/repos/cbeust/testng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cbeust/testng/issues/1604/comments","statuses_url":"https://api.github.com/repos/cbeust/testng/statuses/a01c40d5ad59b42eb9116a9c31ec731a56ffcb3e","head":{"label":"krmahadevan:krmahadevan-refactor-TestRunner","ref":"krmahadevan-refactor-TestRunner","sha":"a01c40d5ad59b42eb9116a9c31ec731a56ffcb3e","user":{"login":"krmahadevan","id":909773,"avatar_url":"https://avatars0.githubusercontent.com/u/909773?v=4","gravatar_id":"","url":"https://api.github.com/users/krmahadevan","html_url":"https://github.com/krmahadevan","followers_url":"https://api.github.com/users/krmahadevan/followers","following_url":"https://api.github.com/users/krmahadevan/following{/other_user}","gists_url":"https://api.github.com/users/krmahadevan/gists{/gist_id}","starred_url":"https://api.github.com/users/krmahadevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krmahadevan/subscriptions","organizations_url":"https://api.github.com/users/krmahadevan/orgs","repos_url":"https://api.github.com/users/krmahadevan/repos","events_url":"https://api.github.com/users/krmahadevan/events{/privacy}","received_events_url":"https://api.github.com/users/krmahadevan/received_events","type":"User","site_admin":false},"repo":{"id":35460849,"name":"testng","full_name":"krmahadevan/testng","owner":{"login":"krmahadevan","id":909773,"avatar_url":"https://avatars0.githubusercontent.com/u/909773?v=4","gravatar_id":"","url":"https://api.github.com/users/krmahadevan","html_url":"https://github.com/krmahadevan","followers_url":"https://api.github.com/users/krmahadevan/followers","following_url":"https://api.github.com/users/krmahadevan/following{/other_user}","gists_url":"https://api.github.com/users/krmahadevan/gists{/gist_id}","starred_url":"https://api.github.com/users/krmahadevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krmahadevan/subscriptions","organizations_url":"https://api.github.com/users/krmahadevan/orgs","repos_url":"https://api.github.com/users/krmahadevan/repos","events_url":"https://api.github.com/users/krmahadevan/events{/privacy}","received_events_url":"https://api.github.com/users/krmahadevan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krmahadevan/testng","description":"TestNG testing framework","fork":true,"url":"https://api.github.com/repos/krmahadevan/testng","forks_url":"https://api.github.com/repos/krmahadevan/testng/forks","keys_url":"https://api.github.com/repos/krmahadevan/testng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krmahadevan/testng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krmahadevan/testng/teams","hooks_url":"https://api.github.com/repos/krmahadevan/testng/hooks","issue_events_url":"https://api.github.com/repos/krmahadevan/testng/issues/events{/number}","events_url":"https://api.github.com/repos/krmahadevan/testng/events","assignees_url":"https://api.github.com/repos/krmahadevan/testng/assignees{/user}","branches_url":"https://api.github.com/repos/krmahadevan/testng/branches{/branch}","tags_url":"https://api.github.com/repos/krmahadevan/testng/tags","blobs_url":"https://api.github.com/repos/krmahadevan/testng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krmahadevan/testng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krmahadevan/testng/git/refs{/sha}","trees_url":"https://api.github.com/repos/krmahadevan/testng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krmahadevan/testng/statuses/{sha}","languages_url":"https://api.github.com/repos/krmahadevan/testng/languages","stargazers_url":"https://api.github.com/repos/krmahadevan/testng/stargazers","contributors_url":"https://api.github.com/repos/krmahadevan/testng/contributors","subscribers_url":"https://api.github.com/repos/krmahadevan/testng/subscribers","subscription_url":"https://api.github.com/repos/krmahadevan/testng/subscription","commits_url":"https://api.github.com/repos/krmahadevan/testng/commits{/sha}","git_commits_url":"https://api.github.com/repos/krmahadevan/testng/git/commits{/sha}","comments_url":"https://api.github.com/repos/krmahadevan/testng/comments{/number}","issue_comment_url":"https://api.github.com/repos/krmahadevan/testng/issues/comments{/number}","contents_url":"https://api.github.com/repos/krmahadevan/testng/contents/{+path}","compare_url":"https://api.github.com/repos/krmahadevan/testng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krmahadevan/testng/merges","archive_url":"https://api.github.com/repos/krmahadevan/testng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krmahadevan/testng/downloads","issues_url":"https://api.github.com/repos/krmahadevan/testng/issues{/number}","pulls_url":"https://api.github.com/repos/krmahadevan/testng/pulls{/number}","milestones_url":"https://api.github.com/repos/krmahadevan/testng/milestones{/number}","notifications_url":"https://api.github.com/repos/krmahadevan/testng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krmahadevan/testng/labels{/name}","releases_url":"https://api.github.com/repos/krmahadevan/testng/releases{/id}","deployments_url":"https://api.github.com/repos/krmahadevan/testng/deployments","created_at":"2015-05-12T02:00:29Z","updated_at":"2016-01-21T03:27:54Z","pushed_at":"2017-11-13T04:28:44Z","git_url":"git://github.com/krmahadevan/testng.git","ssh_url":"[email protected]:krmahadevan/testng.git","clone_url":"https://github.com/krmahadevan/testng.git","svn_url":"https://github.com/krmahadevan/testng","homepage":"http://testng.org","size":26968,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cbeust:master","ref":"master","sha":"f77788ef458711c5e97d92489adc47404a44932b","user":{"login":"cbeust","id":92322,"avatar_url":"https://avatars2.githubusercontent.com/u/92322?v=4","gravatar_id":"","url":"https://api.github.com/users/cbeust","html_url":"https://github.com/cbeust","followers_url":"https://api.github.com/users/cbeust/followers","following_url":"https://api.github.com/users/cbeust/following{/other_user}","gists_url":"https://api.github.com/users/cbeust/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeust/subscriptions","organizations_url":"https://api.github.com/users/cbeust/orgs","repos_url":"https://api.github.com/users/cbeust/repos","events_url":"https://api.github.com/users/cbeust/events{/privacy}","received_events_url":"https://api.github.com/users/cbeust/received_events","type":"User","site_admin":false},"repo":{"id":745749,"name":"testng","full_name":"cbeust/testng","owner":{"login":"cbeust","id":92322,"avatar_url":"https://avatars2.githubusercontent.com/u/92322?v=4","gravatar_id":"","url":"https://api.github.com/users/cbeust","html_url":"https://github.com/cbeust","followers_url":"https://api.github.com/users/cbeust/followers","following_url":"https://api.github.com/users/cbeust/following{/other_user}","gists_url":"https://api.github.com/users/cbeust/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeust/subscriptions","organizations_url":"https://api.github.com/users/cbeust/orgs","repos_url":"https://api.github.com/users/cbeust/repos","events_url":"https://api.github.com/users/cbeust/events{/privacy}","received_events_url":"https://api.github.com/users/cbeust/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cbeust/testng","description":"TestNG testing framework","fork":false,"url":"https://api.github.com/repos/cbeust/testng","forks_url":"https://api.github.com/repos/cbeust/testng/forks","keys_url":"https://api.github.com/repos/cbeust/testng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbeust/testng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbeust/testng/teams","hooks_url":"https://api.github.com/repos/cbeust/testng/hooks","issue_events_url":"https://api.github.com/repos/cbeust/testng/issues/events{/number}","events_url":"https://api.github.com/repos/cbeust/testng/events","assignees_url":"https://api.github.com/repos/cbeust/testng/assignees{/user}","branches_url":"https://api.github.com/repos/cbeust/testng/branches{/branch}","tags_url":"https://api.github.com/repos/cbeust/testng/tags","blobs_url":"https://api.github.com/repos/cbeust/testng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbeust/testng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbeust/testng/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbeust/testng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbeust/testng/statuses/{sha}","languages_url":"https://api.github.com/repos/cbeust/testng/languages","stargazers_url":"https://api.github.com/repos/cbeust/testng/stargazers","contributors_url":"https://api.github.com/repos/cbeust/testng/contributors","subscribers_url":"https://api.github.com/repos/cbeust/testng/subscribers","subscription_url":"https://api.github.com/repos/cbeust/testng/subscription","commits_url":"https://api.github.com/repos/cbeust/testng/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbeust/testng/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbeust/testng/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbeust/testng/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbeust/testng/contents/{+path}","compare_url":"https://api.github.com/repos/cbeust/testng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbeust/testng/merges","archive_url":"https://api.github.com/repos/cbeust/testng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbeust/testng/downloads","issues_url":"https://api.github.com/repos/cbeust/testng/issues{/number}","pulls_url":"https://api.github.com/repos/cbeust/testng/pulls{/number}","milestones_url":"https://api.github.com/repos/cbeust/testng/milestones{/number}","notifications_url":"https://api.github.com/repos/cbeust/testng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbeust/testng/labels{/name}","releases_url":"https://api.github.com/repos/cbeust/testng/releases{/id}","deployments_url":"https://api.github.com/repos/cbeust/testng/deployments","created_at":"2010-06-28T23:10:17Z","updated_at":"2017-11-13T07:13:17Z","pushed_at":"2017-11-13T04:28:46Z","git_url":"git://github.com/cbeust/testng.git","ssh_url":"[email protected]:cbeust/testng.git","clone_url":"https://github.com/cbeust/testng.git","svn_url":"https://github.com/cbeust/testng","homepage":"http://testng.org","size":27001,"stargazers_count":939,"watchers_count":939,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":633,"mirror_url":null,"archived":false,"open_issues_count":308,"forks":633,"open_issues":308,"watchers":939,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cbeust/testng/pulls/1604"},"html":{"href":"https://github.com/cbeust/testng/pull/1604"},"issue":{"href":"https://api.github.com/repos/cbeust/testng/issues/1604"},"comments":{"href":"https://api.github.com/repos/cbeust/testng/issues/1604/comments"},"review_comments":{"href":"https://api.github.com/repos/cbeust/testng/pulls/1604/comments"},"review_comment":{"href":"https://api.github.com/repos/cbeust/testng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cbeust/testng/pulls/1604/commits"},"statuses":{"href":"https://api.github.com/repos/cbeust/testng/statuses/a01c40d5ad59b42eb9116a9c31ec731a56ffcb3e"}},"author_association":"COLLABORATOR"}} | {
"id": 745749,
"name": "cbeust/testng",
"url": "https://api.github.com/repos/cbeust/testng"
} | {
"id": 254697,
"login": "juherr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/254697?",
"url": "https://api.github.com/users/juherr"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-11-13T08:30:41 | 6845495679 | {"actor":{"display_login":"juherr"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/95423497","pull_request_review_id":15977529,"id":95423497,"diff_hunk":"@@ -266,6 +268,34 @@ def test_apply_settings(self):\n \t\tself.assertEqual(s.get_settings()['num_want'], 66)\n \t\tself.assertEqual(s.get_settings()['user_agent'], 'test123')\n \n+class test_example_client(unittest.TestCase):\n+\n+\tdef test_execute_client(self):\n+\t\twith open(os.devnull, \"w\") as DEVNULL:\n+\t\t\tprocess = subprocess.Popen([sys.executable,\"client.py\",\"url_seed_multi.torrent\"], stdout=DEVNULL, stderr=subprocess.STDOUT)\n+\t\t# python2 has no Popen.wait() timeout\n+\t\ttime.sleep(10)\n+\t\treturncode = process.poll()\n+\t\tif returncode == None:\n+\t\t\tprocess.kill()","path":"bindings/python/test.py","position":22,"original_position":22,"commit_id":"898d70f7e5df1a96aa3a4e980e1b5649eca177f5","original_commit_id":"898d70f7e5df1a96aa3a4e980e1b5649eca177f5","user":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"body":"in this case, you skip the assert. shouldn't this fail the test?","created_at":"2017-01-10T18:12:41Z","updated_at":"2017-01-10T18:12:41Z","html_url":"https://github.com/arvidn/libtorrent/pull/1512#discussion_r95423497","pull_request_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1512","_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/95423497"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/1512#discussion_r95423497"},"pull_request":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1512"}}},"pull_request":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1512","id":100712697,"html_url":"https://github.com/arvidn/libtorrent/pull/1512","diff_url":"https://github.com/arvidn/libtorrent/pull/1512.diff","patch_url":"https://github.com/arvidn/libtorrent/pull/1512.patch","issue_url":"https://api.github.com/repos/arvidn/libtorrent/issues/1512","number":1512,"state":"open","locked":false,"title":"Fix python client","user":{"login":"Falcosc","id":8665625,"avatar_url":"https://avatars.githubusercontent.com/u/8665625?v=3","gravatar_id":"","url":"https://api.github.com/users/Falcosc","html_url":"https://github.com/Falcosc","followers_url":"https://api.github.com/users/Falcosc/followers","following_url":"https://api.github.com/users/Falcosc/following{/other_user}","gists_url":"https://api.github.com/users/Falcosc/gists{/gist_id}","starred_url":"https://api.github.com/users/Falcosc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Falcosc/subscriptions","organizations_url":"https://api.github.com/users/Falcosc/orgs","repos_url":"https://api.github.com/users/Falcosc/repos","events_url":"https://api.github.com/users/Falcosc/events{/privacy}","received_events_url":"https://api.github.com/users/Falcosc/received_events","type":"User","site_admin":false},"body":"for https://github.com/arvidn/libtorrent/issues/1510","created_at":"2017-01-09T16:13:27Z","updated_at":"2017-01-10T18:12:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ade4c448607dab0dfbe8864257da192606aaf976","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1512/commits","review_comments_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1512/comments","review_comment_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/issues/1512/comments","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/898d70f7e5df1a96aa3a4e980e1b5649eca177f5","head":{"label":"Falcosc:fix_python_client","ref":"fix_python_client","sha":"898d70f7e5df1a96aa3a4e980e1b5649eca177f5","user":{"login":"Falcosc","id":8665625,"avatar_url":"https://avatars.githubusercontent.com/u/8665625?v=3","gravatar_id":"","url":"https://api.github.com/users/Falcosc","html_url":"https://github.com/Falcosc","followers_url":"https://api.github.com/users/Falcosc/followers","following_url":"https://api.github.com/users/Falcosc/following{/other_user}","gists_url":"https://api.github.com/users/Falcosc/gists{/gist_id}","starred_url":"https://api.github.com/users/Falcosc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Falcosc/subscriptions","organizations_url":"https://api.github.com/users/Falcosc/orgs","repos_url":"https://api.github.com/users/Falcosc/repos","events_url":"https://api.github.com/users/Falcosc/events{/privacy}","received_events_url":"https://api.github.com/users/Falcosc/received_events","type":"User","site_admin":false},"repo":{"id":76501489,"name":"libtorrent","full_name":"Falcosc/libtorrent","owner":{"login":"Falcosc","id":8665625,"avatar_url":"https://avatars.githubusercontent.com/u/8665625?v=3","gravatar_id":"","url":"https://api.github.com/users/Falcosc","html_url":"https://github.com/Falcosc","followers_url":"https://api.github.com/users/Falcosc/followers","following_url":"https://api.github.com/users/Falcosc/following{/other_user}","gists_url":"https://api.github.com/users/Falcosc/gists{/gist_id}","starred_url":"https://api.github.com/users/Falcosc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Falcosc/subscriptions","organizations_url":"https://api.github.com/users/Falcosc/orgs","repos_url":"https://api.github.com/users/Falcosc/repos","events_url":"https://api.github.com/users/Falcosc/events{/privacy}","received_events_url":"https://api.github.com/users/Falcosc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Falcosc/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":true,"url":"https://api.github.com/repos/Falcosc/libtorrent","forks_url":"https://api.github.com/repos/Falcosc/libtorrent/forks","keys_url":"https://api.github.com/repos/Falcosc/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Falcosc/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Falcosc/libtorrent/teams","hooks_url":"https://api.github.com/repos/Falcosc/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/Falcosc/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/Falcosc/libtorrent/events","assignees_url":"https://api.github.com/repos/Falcosc/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/Falcosc/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/Falcosc/libtorrent/tags","blobs_url":"https://api.github.com/repos/Falcosc/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Falcosc/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Falcosc/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/Falcosc/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Falcosc/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/Falcosc/libtorrent/languages","stargazers_url":"https://api.github.com/repos/Falcosc/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/Falcosc/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/Falcosc/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/Falcosc/libtorrent/subscription","commits_url":"https://api.github.com/repos/Falcosc/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/Falcosc/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/Falcosc/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/Falcosc/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/Falcosc/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/Falcosc/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Falcosc/libtorrent/merges","archive_url":"https://api.github.com/repos/Falcosc/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Falcosc/libtorrent/downloads","issues_url":"https://api.github.com/repos/Falcosc/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/Falcosc/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/Falcosc/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/Falcosc/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Falcosc/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/Falcosc/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/Falcosc/libtorrent/deployments","created_at":"2016-12-14T22:15:04Z","updated_at":"2016-12-14T22:15:16Z","pushed_at":"2017-01-10T14:53:14Z","git_url":"git://github.com/Falcosc/libtorrent.git","ssh_url":"[email protected]:Falcosc/libtorrent.git","clone_url":"https://github.com/Falcosc/libtorrent.git","svn_url":"https://github.com/Falcosc/libtorrent","homepage":"http://libtorrent.org","size":54261,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arvidn:master","ref":"master","sha":"d1ea80c2c337625e5aad2f0e1c7ef389a45af6a4","user":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"repo":{"id":36781769,"name":"libtorrent","full_name":"arvidn/libtorrent","owner":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arvidn/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":false,"url":"https://api.github.com/repos/arvidn/libtorrent","forks_url":"https://api.github.com/repos/arvidn/libtorrent/forks","keys_url":"https://api.github.com/repos/arvidn/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arvidn/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arvidn/libtorrent/teams","hooks_url":"https://api.github.com/repos/arvidn/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/arvidn/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/arvidn/libtorrent/events","assignees_url":"https://api.github.com/repos/arvidn/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/arvidn/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/arvidn/libtorrent/tags","blobs_url":"https://api.github.com/repos/arvidn/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arvidn/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arvidn/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/arvidn/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/arvidn/libtorrent/languages","stargazers_url":"https://api.github.com/repos/arvidn/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/arvidn/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/arvidn/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/arvidn/libtorrent/subscription","commits_url":"https://api.github.com/repos/arvidn/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/arvidn/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/arvidn/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/arvidn/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/arvidn/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arvidn/libtorrent/merges","archive_url":"https://api.github.com/repos/arvidn/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arvidn/libtorrent/downloads","issues_url":"https://api.github.com/repos/arvidn/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/arvidn/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/arvidn/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/arvidn/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arvidn/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/arvidn/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/arvidn/libtorrent/deployments","created_at":"2015-06-03T05:22:03Z","updated_at":"2017-01-10T14:05:06Z","pushed_at":"2017-01-10T15:52:03Z","git_url":"git://github.com/arvidn/libtorrent.git","ssh_url":"[email protected]:arvidn/libtorrent.git","clone_url":"https://github.com/arvidn/libtorrent.git","svn_url":"https://github.com/arvidn/libtorrent","homepage":"http://libtorrent.org","size":66445,"stargazers_count":637,"watchers_count":637,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":210,"mirror_url":null,"open_issues_count":91,"forks":210,"open_issues":91,"watchers":637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1512"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/1512"},"issue":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/1512"},"comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/1512/comments"},"review_comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1512/comments"},"review_comment":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1512/commits"},"statuses":{"href":"https://api.github.com/repos/arvidn/libtorrent/statuses/898d70f7e5df1a96aa3a4e980e1b5649eca177f5"}}}} | {
"id": 36781769,
"name": "arvidn/libtorrent",
"url": "https://api.github.com/repos/arvidn/libtorrent"
} | {
"id": 661450,
"login": "arvidn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/661450?",
"url": "https://api.github.com/users/arvidn"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-01-10T18:12:41 | 5130809187 | {"actor":{"display_login":"arvidn"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ryoji3535/chat-space/pulls/comments/114045140","pull_request_review_id":35488399,"id":114045140,"diff_hunk":"@@ -11,12 +11,12 @@ def edit\n def update\n @group = Group.find(params[:id])\n @group.update(group_params)\n- redirect_to \"/\"\n+ redirect_to \"/groups/#{@group.id}/messages\"","path":"app/controllers/groups_controller.rb","position":5,"original_position":5,"commit_id":"27adf59ecc3d7d2e1fa75ea4bcd0e1bdf6154b65","original_commit_id":"27adf59ecc3d7d2e1fa75ea4bcd0e1bdf6154b65","user":{"login":"tetsu8dayo","id":22935512,"avatar_url":"https://avatars0.githubusercontent.com/u/22935512?v=3","gravatar_id":"","url":"https://api.github.com/users/tetsu8dayo","html_url":"https://github.com/tetsu8dayo","followers_url":"https://api.github.com/users/tetsu8dayo/followers","following_url":"https://api.github.com/users/tetsu8dayo/following{/other_user}","gists_url":"https://api.github.com/users/tetsu8dayo/gists{/gist_id}","starred_url":"https://api.github.com/users/tetsu8dayo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tetsu8dayo/subscriptions","organizations_url":"https://api.github.com/users/tetsu8dayo/orgs","repos_url":"https://api.github.com/users/tetsu8dayo/repos","events_url":"https://api.github.com/users/tetsu8dayo/events{/privacy}","received_events_url":"https://api.github.com/users/tetsu8dayo/received_events","type":"User","site_admin":false},"body":"prefix_url って書き方になおそ","created_at":"2017-04-29T03:34:43Z","updated_at":"2017-04-29T03:38:01Z","html_url":"https://github.com/ryoji3535/chat-space/pull/7#discussion_r114045140","pull_request_url":"https://api.github.com/repos/ryoji3535/chat-space/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/ryoji3535/chat-space/pulls/comments/114045140"},"html":{"href":"https://github.com/ryoji3535/chat-space/pull/7#discussion_r114045140"},"pull_request":{"href":"https://api.github.com/repos/ryoji3535/chat-space/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/ryoji3535/chat-space/pulls/7","id":118258312,"html_url":"https://github.com/ryoji3535/chat-space/pull/7","diff_url":"https://github.com/ryoji3535/chat-space/pull/7.diff","patch_url":"https://github.com/ryoji3535/chat-space/pull/7.patch","issue_url":"https://api.github.com/repos/ryoji3535/chat-space/issues/7","number":7,"state":"open","locked":false,"title":"Message","user":{"login":"ryoji3535","id":26176965,"avatar_url":"https://avatars1.githubusercontent.com/u/26176965?v=3","gravatar_id":"","url":"https://api.github.com/users/ryoji3535","html_url":"https://github.com/ryoji3535","followers_url":"https://api.github.com/users/ryoji3535/followers","following_url":"https://api.github.com/users/ryoji3535/following{/other_user}","gists_url":"https://api.github.com/users/ryoji3535/gists{/gist_id}","starred_url":"https://api.github.com/users/ryoji3535/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryoji3535/subscriptions","organizations_url":"https://api.github.com/users/ryoji3535/orgs","repos_url":"https://api.github.com/users/ryoji3535/repos","events_url":"https://api.github.com/users/ryoji3535/events{/privacy}","received_events_url":"https://api.github.com/users/ryoji3535/received_events","type":"User","site_admin":false},"body":"# What\r\nメッセージ投稿機能の作成\r\n# Why\r\nアプリケーション作成に必須のため","created_at":"2017-04-29T01:51:46Z","updated_at":"2017-04-29T03:38:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b473e36fe0e4d7f6f22d6bc9230560b6232545af","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ryoji3535/chat-space/pulls/7/commits","review_comments_url":"https://api.github.com/repos/ryoji3535/chat-space/pulls/7/comments","review_comment_url":"https://api.github.com/repos/ryoji3535/chat-space/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ryoji3535/chat-space/issues/7/comments","statuses_url":"https://api.github.com/repos/ryoji3535/chat-space/statuses/27adf59ecc3d7d2e1fa75ea4bcd0e1bdf6154b65","head":{"label":"ryoji3535:message投稿機能","ref":"message投稿機能","sha":"27adf59ecc3d7d2e1fa75ea4bcd0e1bdf6154b65","user":{"login":"ryoji3535","id":26176965,"avatar_url":"https://avatars1.githubusercontent.com/u/26176965?v=3","gravatar_id":"","url":"https://api.github.com/users/ryoji3535","html_url":"https://github.com/ryoji3535","followers_url":"https://api.github.com/users/ryoji3535/followers","following_url":"https://api.github.com/users/ryoji3535/following{/other_user}","gists_url":"https://api.github.com/users/ryoji3535/gists{/gist_id}","starred_url":"https://api.github.com/users/ryoji3535/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryoji3535/subscriptions","organizations_url":"https://api.github.com/users/ryoji3535/orgs","repos_url":"https://api.github.com/users/ryoji3535/repos","events_url":"https://api.github.com/users/ryoji3535/events{/privacy}","received_events_url":"https://api.github.com/users/ryoji3535/received_events","type":"User","site_admin":false},"repo":{"id":83859825,"name":"chat-space","full_name":"ryoji3535/chat-space","owner":{"login":"ryoji3535","id":26176965,"avatar_url":"https://avatars1.githubusercontent.com/u/26176965?v=3","gravatar_id":"","url":"https://api.github.com/users/ryoji3535","html_url":"https://github.com/ryoji3535","followers_url":"https://api.github.com/users/ryoji3535/followers","following_url":"https://api.github.com/users/ryoji3535/following{/other_user}","gists_url":"https://api.github.com/users/ryoji3535/gists{/gist_id}","starred_url":"https://api.github.com/users/ryoji3535/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryoji3535/subscriptions","organizations_url":"https://api.github.com/users/ryoji3535/orgs","repos_url":"https://api.github.com/users/ryoji3535/repos","events_url":"https://api.github.com/users/ryoji3535/events{/privacy}","received_events_url":"https://api.github.com/users/ryoji3535/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryoji3535/chat-space","description":null,"fork":false,"url":"https://api.github.com/repos/ryoji3535/chat-space","forks_url":"https://api.github.com/repos/ryoji3535/chat-space/forks","keys_url":"https://api.github.com/repos/ryoji3535/chat-space/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryoji3535/chat-space/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryoji3535/chat-space/teams","hooks_url":"https://api.github.com/repos/ryoji3535/chat-space/hooks","issue_events_url":"https://api.github.com/repos/ryoji3535/chat-space/issues/events{/number}","events_url":"https://api.github.com/repos/ryoji3535/chat-space/events","assignees_url":"https://api.github.com/repos/ryoji3535/chat-space/assignees{/user}","branches_url":"https://api.github.com/repos/ryoji3535/chat-space/branches{/branch}","tags_url":"https://api.github.com/repos/ryoji3535/chat-space/tags","blobs_url":"https://api.github.com/repos/ryoji3535/chat-space/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryoji3535/chat-space/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryoji3535/chat-space/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryoji3535/chat-space/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryoji3535/chat-space/statuses/{sha}","languages_url":"https://api.github.com/repos/ryoji3535/chat-space/languages","stargazers_url":"https://api.github.com/repos/ryoji3535/chat-space/stargazers","contributors_url":"https://api.github.com/repos/ryoji3535/chat-space/contributors","subscribers_url":"https://api.github.com/repos/ryoji3535/chat-space/subscribers","subscription_url":"https://api.github.com/repos/ryoji3535/chat-space/subscription","commits_url":"https://api.github.com/repos/ryoji3535/chat-space/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryoji3535/chat-space/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryoji3535/chat-space/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryoji3535/chat-space/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryoji3535/chat-space/contents/{+path}","compare_url":"https://api.github.com/repos/ryoji3535/chat-space/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryoji3535/chat-space/merges","archive_url":"https://api.github.com/repos/ryoji3535/chat-space/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryoji3535/chat-space/downloads","issues_url":"https://api.github.com/repos/ryoji3535/chat-space/issues{/number}","pulls_url":"https://api.github.com/repos/ryoji3535/chat-space/pulls{/number}","milestones_url":"https://api.github.com/repos/ryoji3535/chat-space/milestones{/number}","notifications_url":"https://api.github.com/repos/ryoji3535/chat-space/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryoji3535/chat-space/labels{/name}","releases_url":"https://api.github.com/repos/ryoji3535/chat-space/releases{/id}","deployments_url":"https://api.github.com/repos/ryoji3535/chat-space/deployments","created_at":"2017-03-04T02:44:00Z","updated_at":"2017-04-04T13:59:20Z","pushed_at":"2017-04-29T01:51:47Z","git_url":"git://github.com/ryoji3535/chat-space.git","ssh_url":"[email protected]:ryoji3535/chat-space.git","clone_url":"https://github.com/ryoji3535/chat-space.git","svn_url":"https://github.com/ryoji3535/chat-space","homepage":null,"size":700,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ryoji3535:master","ref":"master","sha":"e25805b7efd538118819b3210303836ffcd6eef7","user":{"login":"ryoji3535","id":26176965,"avatar_url":"https://avatars1.githubusercontent.com/u/26176965?v=3","gravatar_id":"","url":"https://api.github.com/users/ryoji3535","html_url":"https://github.com/ryoji3535","followers_url":"https://api.github.com/users/ryoji3535/followers","following_url":"https://api.github.com/users/ryoji3535/following{/other_user}","gists_url":"https://api.github.com/users/ryoji3535/gists{/gist_id}","starred_url":"https://api.github.com/users/ryoji3535/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryoji3535/subscriptions","organizations_url":"https://api.github.com/users/ryoji3535/orgs","repos_url":"https://api.github.com/users/ryoji3535/repos","events_url":"https://api.github.com/users/ryoji3535/events{/privacy}","received_events_url":"https://api.github.com/users/ryoji3535/received_events","type":"User","site_admin":false},"repo":{"id":83859825,"name":"chat-space","full_name":"ryoji3535/chat-space","owner":{"login":"ryoji3535","id":26176965,"avatar_url":"https://avatars1.githubusercontent.com/u/26176965?v=3","gravatar_id":"","url":"https://api.github.com/users/ryoji3535","html_url":"https://github.com/ryoji3535","followers_url":"https://api.github.com/users/ryoji3535/followers","following_url":"https://api.github.com/users/ryoji3535/following{/other_user}","gists_url":"https://api.github.com/users/ryoji3535/gists{/gist_id}","starred_url":"https://api.github.com/users/ryoji3535/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryoji3535/subscriptions","organizations_url":"https://api.github.com/users/ryoji3535/orgs","repos_url":"https://api.github.com/users/ryoji3535/repos","events_url":"https://api.github.com/users/ryoji3535/events{/privacy}","received_events_url":"https://api.github.com/users/ryoji3535/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryoji3535/chat-space","description":null,"fork":false,"url":"https://api.github.com/repos/ryoji3535/chat-space","forks_url":"https://api.github.com/repos/ryoji3535/chat-space/forks","keys_url":"https://api.github.com/repos/ryoji3535/chat-space/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryoji3535/chat-space/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryoji3535/chat-space/teams","hooks_url":"https://api.github.com/repos/ryoji3535/chat-space/hooks","issue_events_url":"https://api.github.com/repos/ryoji3535/chat-space/issues/events{/number}","events_url":"https://api.github.com/repos/ryoji3535/chat-space/events","assignees_url":"https://api.github.com/repos/ryoji3535/chat-space/assignees{/user}","branches_url":"https://api.github.com/repos/ryoji3535/chat-space/branches{/branch}","tags_url":"https://api.github.com/repos/ryoji3535/chat-space/tags","blobs_url":"https://api.github.com/repos/ryoji3535/chat-space/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryoji3535/chat-space/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryoji3535/chat-space/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryoji3535/chat-space/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryoji3535/chat-space/statuses/{sha}","languages_url":"https://api.github.com/repos/ryoji3535/chat-space/languages","stargazers_url":"https://api.github.com/repos/ryoji3535/chat-space/stargazers","contributors_url":"https://api.github.com/repos/ryoji3535/chat-space/contributors","subscribers_url":"https://api.github.com/repos/ryoji3535/chat-space/subscribers","subscription_url":"https://api.github.com/repos/ryoji3535/chat-space/subscription","commits_url":"https://api.github.com/repos/ryoji3535/chat-space/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryoji3535/chat-space/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryoji3535/chat-space/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryoji3535/chat-space/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryoji3535/chat-space/contents/{+path}","compare_url":"https://api.github.com/repos/ryoji3535/chat-space/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryoji3535/chat-space/merges","archive_url":"https://api.github.com/repos/ryoji3535/chat-space/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryoji3535/chat-space/downloads","issues_url":"https://api.github.com/repos/ryoji3535/chat-space/issues{/number}","pulls_url":"https://api.github.com/repos/ryoji3535/chat-space/pulls{/number}","milestones_url":"https://api.github.com/repos/ryoji3535/chat-space/milestones{/number}","notifications_url":"https://api.github.com/repos/ryoji3535/chat-space/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryoji3535/chat-space/labels{/name}","releases_url":"https://api.github.com/repos/ryoji3535/chat-space/releases{/id}","deployments_url":"https://api.github.com/repos/ryoji3535/chat-space/deployments","created_at":"2017-03-04T02:44:00Z","updated_at":"2017-04-04T13:59:20Z","pushed_at":"2017-04-29T01:51:47Z","git_url":"git://github.com/ryoji3535/chat-space.git","ssh_url":"[email protected]:ryoji3535/chat-space.git","clone_url":"https://github.com/ryoji3535/chat-space.git","svn_url":"https://github.com/ryoji3535/chat-space","homepage":null,"size":700,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ryoji3535/chat-space/pulls/7"},"html":{"href":"https://github.com/ryoji3535/chat-space/pull/7"},"issue":{"href":"https://api.github.com/repos/ryoji3535/chat-space/issues/7"},"comments":{"href":"https://api.github.com/repos/ryoji3535/chat-space/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/ryoji3535/chat-space/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/ryoji3535/chat-space/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ryoji3535/chat-space/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/ryoji3535/chat-space/statuses/27adf59ecc3d7d2e1fa75ea4bcd0e1bdf6154b65"}}}} | {
"id": 83859825,
"name": "ryoji3535/chat-space",
"url": "https://api.github.com/repos/ryoji3535/chat-space"
} | {
"id": 22935512,
"login": "tetsu8dayo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22935512?",
"url": "https://api.github.com/users/tetsu8dayo"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-04-29T03:34:43 | 5780744091 | {"actor":{"display_login":"tetsu8dayo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/sylgas/YearbookSales/pulls/comments/119300483","pull_request_review_id":41164471,"id":119300483,"diff_hunk":"@@ -12,7 +8,7 @@ td {\n }","path":"src/components/App/app.less","position":11,"original_position":11,"commit_id":"caed97b4b997287bbec7438d2f14f00021d88f32","original_commit_id":"caed97b4b997287bbec7438d2f14f00021d88f32","user":{"login":"bigsoon","id":20669245,"avatar_url":"https://avatars1.githubusercontent.com/u/20669245?v=3","gravatar_id":"","url":"https://api.github.com/users/bigsoon","html_url":"https://github.com/bigsoon","followers_url":"https://api.github.com/users/bigsoon/followers","following_url":"https://api.github.com/users/bigsoon/following{/other_user}","gists_url":"https://api.github.com/users/bigsoon/gists{/gist_id}","starred_url":"https://api.github.com/users/bigsoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigsoon/subscriptions","organizations_url":"https://api.github.com/users/bigsoon/orgs","repos_url":"https://api.github.com/users/bigsoon/repos","events_url":"https://api.github.com/users/bigsoon/events{/privacy}","received_events_url":"https://api.github.com/users/bigsoon/received_events","type":"User","site_admin":false},"body":"You can use > selector for a bit better performance (which is almost not noticable, but still worth...)","created_at":"2017-05-31T08:34:44Z","updated_at":"2017-05-31T08:47:08Z","html_url":"https://github.com/sylgas/YearbookSales/pull/8#discussion_r119300483","pull_request_url":"https://api.github.com/repos/sylgas/YearbookSales/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/sylgas/YearbookSales/pulls/comments/119300483"},"html":{"href":"https://github.com/sylgas/YearbookSales/pull/8#discussion_r119300483"},"pull_request":{"href":"https://api.github.com/repos/sylgas/YearbookSales/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/sylgas/YearbookSales/pulls/8","id":123074671,"html_url":"https://github.com/sylgas/YearbookSales/pull/8","diff_url":"https://github.com/sylgas/YearbookSales/pull/8.diff","patch_url":"https://github.com/sylgas/YearbookSales/pull/8.patch","issue_url":"https://api.github.com/repos/sylgas/YearbookSales/issues/8","number":8,"state":"open","locked":false,"title":"Feature/merge duplicates","user":{"login":"sylgas","id":2964111,"avatar_url":"https://avatars2.githubusercontent.com/u/2964111?v=3","gravatar_id":"","url":"https://api.github.com/users/sylgas","html_url":"https://github.com/sylgas","followers_url":"https://api.github.com/users/sylgas/followers","following_url":"https://api.github.com/users/sylgas/following{/other_user}","gists_url":"https://api.github.com/users/sylgas/gists{/gist_id}","starred_url":"https://api.github.com/users/sylgas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylgas/subscriptions","organizations_url":"https://api.github.com/users/sylgas/orgs","repos_url":"https://api.github.com/users/sylgas/repos","events_url":"https://api.github.com/users/sylgas/events{/privacy}","received_events_url":"https://api.github.com/users/sylgas/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-30T15:13:12Z","updated_at":"2017-05-31T08:47:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0fad7cd51a7e78d729f5dcc2e4e00d6f143659b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sylgas/YearbookSales/pulls/8/commits","review_comments_url":"https://api.github.com/repos/sylgas/YearbookSales/pulls/8/comments","review_comment_url":"https://api.github.com/repos/sylgas/YearbookSales/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sylgas/YearbookSales/issues/8/comments","statuses_url":"https://api.github.com/repos/sylgas/YearbookSales/statuses/caed97b4b997287bbec7438d2f14f00021d88f32","head":{"label":"sylgas:feature/merge_duplicates","ref":"feature/merge_duplicates","sha":"caed97b4b997287bbec7438d2f14f00021d88f32","user":{"login":"sylgas","id":2964111,"avatar_url":"https://avatars2.githubusercontent.com/u/2964111?v=3","gravatar_id":"","url":"https://api.github.com/users/sylgas","html_url":"https://github.com/sylgas","followers_url":"https://api.github.com/users/sylgas/followers","following_url":"https://api.github.com/users/sylgas/following{/other_user}","gists_url":"https://api.github.com/users/sylgas/gists{/gist_id}","starred_url":"https://api.github.com/users/sylgas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylgas/subscriptions","organizations_url":"https://api.github.com/users/sylgas/orgs","repos_url":"https://api.github.com/users/sylgas/repos","events_url":"https://api.github.com/users/sylgas/events{/privacy}","received_events_url":"https://api.github.com/users/sylgas/received_events","type":"User","site_admin":false},"repo":{"id":91113261,"name":"YearbookSales","full_name":"sylgas/YearbookSales","owner":{"login":"sylgas","id":2964111,"avatar_url":"https://avatars2.githubusercontent.com/u/2964111?v=3","gravatar_id":"","url":"https://api.github.com/users/sylgas","html_url":"https://github.com/sylgas","followers_url":"https://api.github.com/users/sylgas/followers","following_url":"https://api.github.com/users/sylgas/following{/other_user}","gists_url":"https://api.github.com/users/sylgas/gists{/gist_id}","starred_url":"https://api.github.com/users/sylgas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylgas/subscriptions","organizations_url":"https://api.github.com/users/sylgas/orgs","repos_url":"https://api.github.com/users/sylgas/repos","events_url":"https://api.github.com/users/sylgas/events{/privacy}","received_events_url":"https://api.github.com/users/sylgas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sylgas/YearbookSales","description":null,"fork":false,"url":"https://api.github.com/repos/sylgas/YearbookSales","forks_url":"https://api.github.com/repos/sylgas/YearbookSales/forks","keys_url":"https://api.github.com/repos/sylgas/YearbookSales/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sylgas/YearbookSales/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sylgas/YearbookSales/teams","hooks_url":"https://api.github.com/repos/sylgas/YearbookSales/hooks","issue_events_url":"https://api.github.com/repos/sylgas/YearbookSales/issues/events{/number}","events_url":"https://api.github.com/repos/sylgas/YearbookSales/events","assignees_url":"https://api.github.com/repos/sylgas/YearbookSales/assignees{/user}","branches_url":"https://api.github.com/repos/sylgas/YearbookSales/branches{/branch}","tags_url":"https://api.github.com/repos/sylgas/YearbookSales/tags","blobs_url":"https://api.github.com/repos/sylgas/YearbookSales/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sylgas/YearbookSales/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sylgas/YearbookSales/git/refs{/sha}","trees_url":"https://api.github.com/repos/sylgas/YearbookSales/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sylgas/YearbookSales/statuses/{sha}","languages_url":"https://api.github.com/repos/sylgas/YearbookSales/languages","stargazers_url":"https://api.github.com/repos/sylgas/YearbookSales/stargazers","contributors_url":"https://api.github.com/repos/sylgas/YearbookSales/contributors","subscribers_url":"https://api.github.com/repos/sylgas/YearbookSales/subscribers","subscription_url":"https://api.github.com/repos/sylgas/YearbookSales/subscription","commits_url":"https://api.github.com/repos/sylgas/YearbookSales/commits{/sha}","git_commits_url":"https://api.github.com/repos/sylgas/YearbookSales/git/commits{/sha}","comments_url":"https://api.github.com/repos/sylgas/YearbookSales/comments{/number}","issue_comment_url":"https://api.github.com/repos/sylgas/YearbookSales/issues/comments{/number}","contents_url":"https://api.github.com/repos/sylgas/YearbookSales/contents/{+path}","compare_url":"https://api.github.com/repos/sylgas/YearbookSales/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sylgas/YearbookSales/merges","archive_url":"https://api.github.com/repos/sylgas/YearbookSales/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sylgas/YearbookSales/downloads","issues_url":"https://api.github.com/repos/sylgas/YearbookSales/issues{/number}","pulls_url":"https://api.github.com/repos/sylgas/YearbookSales/pulls{/number}","milestones_url":"https://api.github.com/repos/sylgas/YearbookSales/milestones{/number}","notifications_url":"https://api.github.com/repos/sylgas/YearbookSales/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sylgas/YearbookSales/labels{/name}","releases_url":"https://api.github.com/repos/sylgas/YearbookSales/releases{/id}","deployments_url":"https://api.github.com/repos/sylgas/YearbookSales/deployments","created_at":"2017-05-12T17:09:38Z","updated_at":"2017-05-23T14:54:21Z","pushed_at":"2017-05-30T15:13:13Z","git_url":"git://github.com/sylgas/YearbookSales.git","ssh_url":"[email protected]:sylgas/YearbookSales.git","clone_url":"https://github.com/sylgas/YearbookSales.git","svn_url":"https://github.com/sylgas/YearbookSales","homepage":null,"size":818,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"sylgas:master","ref":"master","sha":"7b3ccd5bd14f7dd8d395dae3b2bdea5fe29bb596","user":{"login":"sylgas","id":2964111,"avatar_url":"https://avatars2.githubusercontent.com/u/2964111?v=3","gravatar_id":"","url":"https://api.github.com/users/sylgas","html_url":"https://github.com/sylgas","followers_url":"https://api.github.com/users/sylgas/followers","following_url":"https://api.github.com/users/sylgas/following{/other_user}","gists_url":"https://api.github.com/users/sylgas/gists{/gist_id}","starred_url":"https://api.github.com/users/sylgas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylgas/subscriptions","organizations_url":"https://api.github.com/users/sylgas/orgs","repos_url":"https://api.github.com/users/sylgas/repos","events_url":"https://api.github.com/users/sylgas/events{/privacy}","received_events_url":"https://api.github.com/users/sylgas/received_events","type":"User","site_admin":false},"repo":{"id":91113261,"name":"YearbookSales","full_name":"sylgas/YearbookSales","owner":{"login":"sylgas","id":2964111,"avatar_url":"https://avatars2.githubusercontent.com/u/2964111?v=3","gravatar_id":"","url":"https://api.github.com/users/sylgas","html_url":"https://github.com/sylgas","followers_url":"https://api.github.com/users/sylgas/followers","following_url":"https://api.github.com/users/sylgas/following{/other_user}","gists_url":"https://api.github.com/users/sylgas/gists{/gist_id}","starred_url":"https://api.github.com/users/sylgas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylgas/subscriptions","organizations_url":"https://api.github.com/users/sylgas/orgs","repos_url":"https://api.github.com/users/sylgas/repos","events_url":"https://api.github.com/users/sylgas/events{/privacy}","received_events_url":"https://api.github.com/users/sylgas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sylgas/YearbookSales","description":null,"fork":false,"url":"https://api.github.com/repos/sylgas/YearbookSales","forks_url":"https://api.github.com/repos/sylgas/YearbookSales/forks","keys_url":"https://api.github.com/repos/sylgas/YearbookSales/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sylgas/YearbookSales/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sylgas/YearbookSales/teams","hooks_url":"https://api.github.com/repos/sylgas/YearbookSales/hooks","issue_events_url":"https://api.github.com/repos/sylgas/YearbookSales/issues/events{/number}","events_url":"https://api.github.com/repos/sylgas/YearbookSales/events","assignees_url":"https://api.github.com/repos/sylgas/YearbookSales/assignees{/user}","branches_url":"https://api.github.com/repos/sylgas/YearbookSales/branches{/branch}","tags_url":"https://api.github.com/repos/sylgas/YearbookSales/tags","blobs_url":"https://api.github.com/repos/sylgas/YearbookSales/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sylgas/YearbookSales/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sylgas/YearbookSales/git/refs{/sha}","trees_url":"https://api.github.com/repos/sylgas/YearbookSales/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sylgas/YearbookSales/statuses/{sha}","languages_url":"https://api.github.com/repos/sylgas/YearbookSales/languages","stargazers_url":"https://api.github.com/repos/sylgas/YearbookSales/stargazers","contributors_url":"https://api.github.com/repos/sylgas/YearbookSales/contributors","subscribers_url":"https://api.github.com/repos/sylgas/YearbookSales/subscribers","subscription_url":"https://api.github.com/repos/sylgas/YearbookSales/subscription","commits_url":"https://api.github.com/repos/sylgas/YearbookSales/commits{/sha}","git_commits_url":"https://api.github.com/repos/sylgas/YearbookSales/git/commits{/sha}","comments_url":"https://api.github.com/repos/sylgas/YearbookSales/comments{/number}","issue_comment_url":"https://api.github.com/repos/sylgas/YearbookSales/issues/comments{/number}","contents_url":"https://api.github.com/repos/sylgas/YearbookSales/contents/{+path}","compare_url":"https://api.github.com/repos/sylgas/YearbookSales/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sylgas/YearbookSales/merges","archive_url":"https://api.github.com/repos/sylgas/YearbookSales/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sylgas/YearbookSales/downloads","issues_url":"https://api.github.com/repos/sylgas/YearbookSales/issues{/number}","pulls_url":"https://api.github.com/repos/sylgas/YearbookSales/pulls{/number}","milestones_url":"https://api.github.com/repos/sylgas/YearbookSales/milestones{/number}","notifications_url":"https://api.github.com/repos/sylgas/YearbookSales/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sylgas/YearbookSales/labels{/name}","releases_url":"https://api.github.com/repos/sylgas/YearbookSales/releases{/id}","deployments_url":"https://api.github.com/repos/sylgas/YearbookSales/deployments","created_at":"2017-05-12T17:09:38Z","updated_at":"2017-05-23T14:54:21Z","pushed_at":"2017-05-30T15:13:13Z","git_url":"git://github.com/sylgas/YearbookSales.git","ssh_url":"[email protected]:sylgas/YearbookSales.git","clone_url":"https://github.com/sylgas/YearbookSales.git","svn_url":"https://github.com/sylgas/YearbookSales","homepage":null,"size":818,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sylgas/YearbookSales/pulls/8"},"html":{"href":"https://github.com/sylgas/YearbookSales/pull/8"},"issue":{"href":"https://api.github.com/repos/sylgas/YearbookSales/issues/8"},"comments":{"href":"https://api.github.com/repos/sylgas/YearbookSales/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/sylgas/YearbookSales/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/sylgas/YearbookSales/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sylgas/YearbookSales/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/sylgas/YearbookSales/statuses/caed97b4b997287bbec7438d2f14f00021d88f32"}}}} | {
"id": 91113261,
"name": "sylgas/YearbookSales",
"url": "https://api.github.com/repos/sylgas/YearbookSales"
} | {
"id": 20669245,
"login": "bigsoon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20669245?",
"url": "https://api.github.com/users/bigsoon"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-05-31T08:34:44 | 5972991699 | {"actor":{"display_login":"bigsoon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/pulls/comments/116252486","pull_request_review_id":37863441,"id":116252486,"diff_hunk":"@@ -63,8 +63,9 @@ def snap_to_roads(path, interpolate: false)\n # by the snap_to_roads function. You can pass up to 100 Place IDs.\n #\n # @return [Array] Array of speed limits.\n- def speed_limits(place_ids)\n+ def speed_limits(place_ids, speed_unit='KPH')\n params = GoogleMapsService::Convert.as_list(place_ids).map { |place_id| ['placeId', place_id] }\n+ params << ['units', speed_unit] if speed_unit == 'MPH'","path":"lib/google_maps_service/apis/roads.rb","position":7,"original_position":7,"commit_id":"3a75f1076eae0bca9da7ce02b157bc8038df60c5","original_commit_id":"3a75f1076eae0bca9da7ce02b157bc8038df60c5","user":{"login":"edwardsamuel","id":3603637,"avatar_url":"https://avatars1.githubusercontent.com/u/3603637?v=3","gravatar_id":"","url":"https://api.github.com/users/edwardsamuel","html_url":"https://github.com/edwardsamuel","followers_url":"https://api.github.com/users/edwardsamuel/followers","following_url":"https://api.github.com/users/edwardsamuel/following{/other_user}","gists_url":"https://api.github.com/users/edwardsamuel/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardsamuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardsamuel/subscriptions","organizations_url":"https://api.github.com/users/edwardsamuel/orgs","repos_url":"https://api.github.com/users/edwardsamuel/repos","events_url":"https://api.github.com/users/edwardsamuel/events{/privacy}","received_events_url":"https://api.github.com/users/edwardsamuel/received_events","type":"User","site_admin":false},"body":"Same as before, to keep it similar to other methods\r\nCould you please change to: `params[:units] = ...`?","created_at":"2017-05-12T15:02:50Z","updated_at":"2017-05-12T15:06:17Z","html_url":"https://github.com/edwardsamuel/google-maps-services-ruby/pull/7#discussion_r116252486","pull_request_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/pulls/comments/116252486"},"html":{"href":"https://github.com/edwardsamuel/google-maps-services-ruby/pull/7#discussion_r116252486"},"pull_request":{"href":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/pulls/7","id":119977559,"html_url":"https://github.com/edwardsamuel/google-maps-services-ruby/pull/7","diff_url":"https://github.com/edwardsamuel/google-maps-services-ruby/pull/7.diff","patch_url":"https://github.com/edwardsamuel/google-maps-services-ruby/pull/7.patch","issue_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/issues/7","number":7,"state":"open","locked":false,"title":"Allow speed_unit to be passed to request","user":{"login":"netuoso","id":7006965,"avatar_url":"https://avatars2.githubusercontent.com/u/7006965?v=3","gravatar_id":"","url":"https://api.github.com/users/netuoso","html_url":"https://github.com/netuoso","followers_url":"https://api.github.com/users/netuoso/followers","following_url":"https://api.github.com/users/netuoso/following{/other_user}","gists_url":"https://api.github.com/users/netuoso/gists{/gist_id}","starred_url":"https://api.github.com/users/netuoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netuoso/subscriptions","organizations_url":"https://api.github.com/users/netuoso/orgs","repos_url":"https://api.github.com/users/netuoso/repos","events_url":"https://api.github.com/users/netuoso/events{/privacy}","received_events_url":"https://api.github.com/users/netuoso/received_events","type":"User","site_admin":false},"body":"#### Explanation:\r\nThis change leaves KPH as the default while adding the ability to send 'MPH' to the roads.rb\r\n\r\n#### Example request:\r\n\r\n```\r\ngoogle_client = GoogleMapsService::Client.new\r\ngoogle_client.speed_limits('ChIJaw1TDuC22YgRf6hEN94cT58', 'MPH')\r\n=> [{:placeId=>\"ChIJaw1TDuC22YgRf6hEN94cT58\", :speedLimit=>88.51392, :units=>\"KPH\"}]\r\n\r\ngoogle_client = GoogleMapsService::Client.new\r\ngoogle_client.speed_limits('ChIJaw1TDuC22YgRf6hEN94cT58', 'MPH')\r\n=> [{:placeId=>\"ChIJaw1TDuC22YgRf6hEN94cT58\", :speedLimit=>55, :units=>\"MPH\"}]\r\n```","created_at":"2017-05-10T21:00:45Z","updated_at":"2017-05-12T15:06:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ca05a54151586a0c5d772d9a9380edc7a63fc3d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/pulls/7/commits","review_comments_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/pulls/7/comments","review_comment_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/issues/7/comments","statuses_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/statuses/3a75f1076eae0bca9da7ce02b157bc8038df60c5","head":{"label":"netuoso:master","ref":"master","sha":"3a75f1076eae0bca9da7ce02b157bc8038df60c5","user":{"login":"netuoso","id":7006965,"avatar_url":"https://avatars2.githubusercontent.com/u/7006965?v=3","gravatar_id":"","url":"https://api.github.com/users/netuoso","html_url":"https://github.com/netuoso","followers_url":"https://api.github.com/users/netuoso/followers","following_url":"https://api.github.com/users/netuoso/following{/other_user}","gists_url":"https://api.github.com/users/netuoso/gists{/gist_id}","starred_url":"https://api.github.com/users/netuoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netuoso/subscriptions","organizations_url":"https://api.github.com/users/netuoso/orgs","repos_url":"https://api.github.com/users/netuoso/repos","events_url":"https://api.github.com/users/netuoso/events{/privacy}","received_events_url":"https://api.github.com/users/netuoso/received_events","type":"User","site_admin":false},"repo":{"id":90906503,"name":"google-maps-services-ruby","full_name":"netuoso/google-maps-services-ruby","owner":{"login":"netuoso","id":7006965,"avatar_url":"https://avatars2.githubusercontent.com/u/7006965?v=3","gravatar_id":"","url":"https://api.github.com/users/netuoso","html_url":"https://github.com/netuoso","followers_url":"https://api.github.com/users/netuoso/followers","following_url":"https://api.github.com/users/netuoso/following{/other_user}","gists_url":"https://api.github.com/users/netuoso/gists{/gist_id}","starred_url":"https://api.github.com/users/netuoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netuoso/subscriptions","organizations_url":"https://api.github.com/users/netuoso/orgs","repos_url":"https://api.github.com/users/netuoso/repos","events_url":"https://api.github.com/users/netuoso/events{/privacy}","received_events_url":"https://api.github.com/users/netuoso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/netuoso/google-maps-services-ruby","description":"Ruby gem for Google Maps Web Service APIs","fork":true,"url":"https://api.github.com/repos/netuoso/google-maps-services-ruby","forks_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/forks","keys_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/teams","hooks_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/hooks","issue_events_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/events","assignees_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/tags","blobs_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/languages","stargazers_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/stargazers","contributors_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/contributors","subscribers_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/subscribers","subscription_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/subscription","commits_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/merges","archive_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/downloads","issues_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/labels{/name}","releases_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/netuoso/google-maps-services-ruby/deployments","created_at":"2017-05-10T20:42:27Z","updated_at":"2017-05-10T20:42:28Z","pushed_at":"2017-05-11T16:11:36Z","git_url":"git://github.com/netuoso/google-maps-services-ruby.git","ssh_url":"[email protected]:netuoso/google-maps-services-ruby.git","clone_url":"https://github.com/netuoso/google-maps-services-ruby.git","svn_url":"https://github.com/netuoso/google-maps-services-ruby","homepage":"","size":141,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"edwardsamuel:master","ref":"master","sha":"46746fd72e90c75855baa88aee04e41c84ff32c9","user":{"login":"edwardsamuel","id":3603637,"avatar_url":"https://avatars1.githubusercontent.com/u/3603637?v=3","gravatar_id":"","url":"https://api.github.com/users/edwardsamuel","html_url":"https://github.com/edwardsamuel","followers_url":"https://api.github.com/users/edwardsamuel/followers","following_url":"https://api.github.com/users/edwardsamuel/following{/other_user}","gists_url":"https://api.github.com/users/edwardsamuel/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardsamuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardsamuel/subscriptions","organizations_url":"https://api.github.com/users/edwardsamuel/orgs","repos_url":"https://api.github.com/users/edwardsamuel/repos","events_url":"https://api.github.com/users/edwardsamuel/events{/privacy}","received_events_url":"https://api.github.com/users/edwardsamuel/received_events","type":"User","site_admin":false},"repo":{"id":41620032,"name":"google-maps-services-ruby","full_name":"edwardsamuel/google-maps-services-ruby","owner":{"login":"edwardsamuel","id":3603637,"avatar_url":"https://avatars1.githubusercontent.com/u/3603637?v=3","gravatar_id":"","url":"https://api.github.com/users/edwardsamuel","html_url":"https://github.com/edwardsamuel","followers_url":"https://api.github.com/users/edwardsamuel/followers","following_url":"https://api.github.com/users/edwardsamuel/following{/other_user}","gists_url":"https://api.github.com/users/edwardsamuel/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardsamuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardsamuel/subscriptions","organizations_url":"https://api.github.com/users/edwardsamuel/orgs","repos_url":"https://api.github.com/users/edwardsamuel/repos","events_url":"https://api.github.com/users/edwardsamuel/events{/privacy}","received_events_url":"https://api.github.com/users/edwardsamuel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edwardsamuel/google-maps-services-ruby","description":"Ruby gem for Google Maps Web Service APIs","fork":false,"url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby","forks_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/forks","keys_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/teams","hooks_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/hooks","issue_events_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/events","assignees_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/tags","blobs_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/languages","stargazers_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/stargazers","contributors_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/contributors","subscribers_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/subscribers","subscription_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/subscription","commits_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/merges","archive_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/downloads","issues_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/labels{/name}","releases_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/deployments","created_at":"2015-08-30T07:14:03Z","updated_at":"2017-05-02T16:28:08Z","pushed_at":"2017-05-11T16:11:37Z","git_url":"git://github.com/edwardsamuel/google-maps-services-ruby.git","ssh_url":"[email protected]:edwardsamuel/google-maps-services-ruby.git","clone_url":"https://github.com/edwardsamuel/google-maps-services-ruby.git","svn_url":"https://github.com/edwardsamuel/google-maps-services-ruby","homepage":"","size":139,"stargazers_count":37,"watchers_count":37,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":5,"forks":14,"open_issues":5,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/pulls/7"},"html":{"href":"https://github.com/edwardsamuel/google-maps-services-ruby/pull/7"},"issue":{"href":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/issues/7"},"comments":{"href":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/edwardsamuel/google-maps-services-ruby/statuses/3a75f1076eae0bca9da7ce02b157bc8038df60c5"}}}} | {
"id": 41620032,
"name": "edwardsamuel/google-maps-services-ruby",
"url": "https://api.github.com/repos/edwardsamuel/google-maps-services-ruby"
} | {
"id": 3603637,
"login": "edwardsamuel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3603637?",
"url": "https://api.github.com/users/edwardsamuel"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-05-12T15:02:50 | 5861910680 | {"actor":{"display_login":"edwardsamuel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/missating/More-Recipes/pulls/comments/157407129","pull_request_review_id":84042412,"id":157407129,"diff_hunk":"@@ -0,0 +1,31 @@\n+import axios from 'axios';\n+import { setFetching, unsetFetching } from './fetching';\n+import { RECEIVE_USER_PROFILE } from './actionTypes';\n+\n+// action creators to get user profile\n+export const receiveUserProfile = userDetails => ({\n+ type: RECEIVE_USER_PROFILE,\n+ userDetails\n+});\n+\n+const receiveUserProfileRequest = () => (dispatch) => {\n+ dispatch(setFetching());\n+ const token = localStorage.getItem('token');\n+ return axios({\n+ method: 'GET',\n+ url: 'http://localhost:3000/api/v1/users/profile',\n+ headers: {\n+ token\n+ }\n+ })\n+ .then((response) => {\n+ const userProfile = response.data.user;\n+ dispatch(receiveUserProfile(userProfile));\n+ dispatch(unsetFetching());\n+ }).catch((error) => {","path":"clients/src/actions/userProfile.js","position":25,"original_position":25,"commit_id":"678fff2a05ff8fe52abc07223a92b6c480450898","original_commit_id":"678fff2a05ff8fe52abc07223a92b6c480450898","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').","created_at":"2017-12-18T06:19:33Z","updated_at":"2017-12-18T06:19:34Z","html_url":"https://github.com/missating/More-Recipes/pull/40#discussion_r157407129","pull_request_url":"https://api.github.com/repos/missating/More-Recipes/pulls/40","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/missating/More-Recipes/pulls/comments/157407129"},"html":{"href":"https://github.com/missating/More-Recipes/pull/40#discussion_r157407129"},"pull_request":{"href":"https://api.github.com/repos/missating/More-Recipes/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/missating/More-Recipes/pulls/40","id":158837263,"html_url":"https://github.com/missating/More-Recipes/pull/40","diff_url":"https://github.com/missating/More-Recipes/pull/40.diff","patch_url":"https://github.com/missating/More-Recipes/pull/40.patch","issue_url":"https://api.github.com/repos/missating/More-Recipes/issues/40","number":40,"state":"closed","locked":false,"title":"Ft user profile 153704217","user":{"login":"missating","id":29452947,"avatar_url":"https://avatars3.githubusercontent.com/u/29452947?v=4","gravatar_id":"","url":"https://api.github.com/users/missating","html_url":"https://github.com/missating","followers_url":"https://api.github.com/users/missating/followers","following_url":"https://api.github.com/users/missating/following{/other_user}","gists_url":"https://api.github.com/users/missating/gists{/gist_id}","starred_url":"https://api.github.com/users/missating/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/missating/subscriptions","organizations_url":"https://api.github.com/users/missating/orgs","repos_url":"https://api.github.com/users/missating/repos","events_url":"https://api.github.com/users/missating/events{/privacy}","received_events_url":"https://api.github.com/users/missating/received_events","type":"User","site_admin":false},"body":"## What does this PR do?\r\nAdds successful auth user profile component \r\nAdds auth user details from redux store to the user profile\r\n\r\n## Relevant Pivotal tracker stories?\r\n153704217","created_at":"2017-12-18T06:19:25Z","updated_at":"2017-12-18T06:19:34Z","closed_at":"2017-12-18T06:19:32Z","merged_at":"2017-12-18T06:19:32Z","merge_commit_sha":"cca51ed10547c3a47bc424a4a7f3170ca030840d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/missating/More-Recipes/pulls/40/commits","review_comments_url":"https://api.github.com/repos/missating/More-Recipes/pulls/40/comments","review_comment_url":"https://api.github.com/repos/missating/More-Recipes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/missating/More-Recipes/issues/40/comments","statuses_url":"https://api.github.com/repos/missating/More-Recipes/statuses/678fff2a05ff8fe52abc07223a92b6c480450898","head":{"label":"missating:ft-user-profile-153704217","ref":"ft-user-profile-153704217","sha":"678fff2a05ff8fe52abc07223a92b6c480450898","user":{"login":"missating","id":29452947,"avatar_url":"https://avatars3.githubusercontent.com/u/29452947?v=4","gravatar_id":"","url":"https://api.github.com/users/missating","html_url":"https://github.com/missating","followers_url":"https://api.github.com/users/missating/followers","following_url":"https://api.github.com/users/missating/following{/other_user}","gists_url":"https://api.github.com/users/missating/gists{/gist_id}","starred_url":"https://api.github.com/users/missating/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/missating/subscriptions","organizations_url":"https://api.github.com/users/missating/orgs","repos_url":"https://api.github.com/users/missating/repos","events_url":"https://api.github.com/users/missating/events{/privacy}","received_events_url":"https://api.github.com/users/missating/received_events","type":"User","site_admin":false},"repo":{"id":107739634,"name":"More-Recipes","full_name":"missating/More-Recipes","owner":{"login":"missating","id":29452947,"avatar_url":"https://avatars3.githubusercontent.com/u/29452947?v=4","gravatar_id":"","url":"https://api.github.com/users/missating","html_url":"https://github.com/missating","followers_url":"https://api.github.com/users/missating/followers","following_url":"https://api.github.com/users/missating/following{/other_user}","gists_url":"https://api.github.com/users/missating/gists{/gist_id}","starred_url":"https://api.github.com/users/missating/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/missating/subscriptions","organizations_url":"https://api.github.com/users/missating/orgs","repos_url":"https://api.github.com/users/missating/repos","events_url":"https://api.github.com/users/missating/events{/privacy}","received_events_url":"https://api.github.com/users/missating/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/missating/More-Recipes","description":"More-Recipes provides a platform for users to share awesome and exciting recipe ideas","fork":false,"url":"https://api.github.com/repos/missating/More-Recipes","forks_url":"https://api.github.com/repos/missating/More-Recipes/forks","keys_url":"https://api.github.com/repos/missating/More-Recipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/missating/More-Recipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/missating/More-Recipes/teams","hooks_url":"https://api.github.com/repos/missating/More-Recipes/hooks","issue_events_url":"https://api.github.com/repos/missating/More-Recipes/issues/events{/number}","events_url":"https://api.github.com/repos/missating/More-Recipes/events","assignees_url":"https://api.github.com/repos/missating/More-Recipes/assignees{/user}","branches_url":"https://api.github.com/repos/missating/More-Recipes/branches{/branch}","tags_url":"https://api.github.com/repos/missating/More-Recipes/tags","blobs_url":"https://api.github.com/repos/missating/More-Recipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/missating/More-Recipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/missating/More-Recipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/missating/More-Recipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/missating/More-Recipes/statuses/{sha}","languages_url":"https://api.github.com/repos/missating/More-Recipes/languages","stargazers_url":"https://api.github.com/repos/missating/More-Recipes/stargazers","contributors_url":"https://api.github.com/repos/missating/More-Recipes/contributors","subscribers_url":"https://api.github.com/repos/missating/More-Recipes/subscribers","subscription_url":"https://api.github.com/repos/missating/More-Recipes/subscription","commits_url":"https://api.github.com/repos/missating/More-Recipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/missating/More-Recipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/missating/More-Recipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/missating/More-Recipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/missating/More-Recipes/contents/{+path}","compare_url":"https://api.github.com/repos/missating/More-Recipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/missating/More-Recipes/merges","archive_url":"https://api.github.com/repos/missating/More-Recipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/missating/More-Recipes/downloads","issues_url":"https://api.github.com/repos/missating/More-Recipes/issues{/number}","pulls_url":"https://api.github.com/repos/missating/More-Recipes/pulls{/number}","milestones_url":"https://api.github.com/repos/missating/More-Recipes/milestones{/number}","notifications_url":"https://api.github.com/repos/missating/More-Recipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/missating/More-Recipes/labels{/name}","releases_url":"https://api.github.com/repos/missating/More-Recipes/releases{/id}","deployments_url":"https://api.github.com/repos/missating/More-Recipes/deployments","created_at":"2017-10-21T00:43:24Z","updated_at":"2017-11-19T04:31:43Z","pushed_at":"2017-12-18T06:19:32Z","git_url":"git://github.com/missating/More-Recipes.git","ssh_url":"[email protected]:missating/More-Recipes.git","clone_url":"https://github.com/missating/More-Recipes.git","svn_url":"https://github.com/missating/More-Recipes","homepage":"https://missating.github.io/More-Recipes/template/index.html","size":3290,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"missating:develop","ref":"develop","sha":"c14fefe5e6c20ae823a1125158030b4ed677b9db","user":{"login":"missating","id":29452947,"avatar_url":"https://avatars3.githubusercontent.com/u/29452947?v=4","gravatar_id":"","url":"https://api.github.com/users/missating","html_url":"https://github.com/missating","followers_url":"https://api.github.com/users/missating/followers","following_url":"https://api.github.com/users/missating/following{/other_user}","gists_url":"https://api.github.com/users/missating/gists{/gist_id}","starred_url":"https://api.github.com/users/missating/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/missating/subscriptions","organizations_url":"https://api.github.com/users/missating/orgs","repos_url":"https://api.github.com/users/missating/repos","events_url":"https://api.github.com/users/missating/events{/privacy}","received_events_url":"https://api.github.com/users/missating/received_events","type":"User","site_admin":false},"repo":{"id":107739634,"name":"More-Recipes","full_name":"missating/More-Recipes","owner":{"login":"missating","id":29452947,"avatar_url":"https://avatars3.githubusercontent.com/u/29452947?v=4","gravatar_id":"","url":"https://api.github.com/users/missating","html_url":"https://github.com/missating","followers_url":"https://api.github.com/users/missating/followers","following_url":"https://api.github.com/users/missating/following{/other_user}","gists_url":"https://api.github.com/users/missating/gists{/gist_id}","starred_url":"https://api.github.com/users/missating/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/missating/subscriptions","organizations_url":"https://api.github.com/users/missating/orgs","repos_url":"https://api.github.com/users/missating/repos","events_url":"https://api.github.com/users/missating/events{/privacy}","received_events_url":"https://api.github.com/users/missating/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/missating/More-Recipes","description":"More-Recipes provides a platform for users to share awesome and exciting recipe ideas","fork":false,"url":"https://api.github.com/repos/missating/More-Recipes","forks_url":"https://api.github.com/repos/missating/More-Recipes/forks","keys_url":"https://api.github.com/repos/missating/More-Recipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/missating/More-Recipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/missating/More-Recipes/teams","hooks_url":"https://api.github.com/repos/missating/More-Recipes/hooks","issue_events_url":"https://api.github.com/repos/missating/More-Recipes/issues/events{/number}","events_url":"https://api.github.com/repos/missating/More-Recipes/events","assignees_url":"https://api.github.com/repos/missating/More-Recipes/assignees{/user}","branches_url":"https://api.github.com/repos/missating/More-Recipes/branches{/branch}","tags_url":"https://api.github.com/repos/missating/More-Recipes/tags","blobs_url":"https://api.github.com/repos/missating/More-Recipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/missating/More-Recipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/missating/More-Recipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/missating/More-Recipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/missating/More-Recipes/statuses/{sha}","languages_url":"https://api.github.com/repos/missating/More-Recipes/languages","stargazers_url":"https://api.github.com/repos/missating/More-Recipes/stargazers","contributors_url":"https://api.github.com/repos/missating/More-Recipes/contributors","subscribers_url":"https://api.github.com/repos/missating/More-Recipes/subscribers","subscription_url":"https://api.github.com/repos/missating/More-Recipes/subscription","commits_url":"https://api.github.com/repos/missating/More-Recipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/missating/More-Recipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/missating/More-Recipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/missating/More-Recipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/missating/More-Recipes/contents/{+path}","compare_url":"https://api.github.com/repos/missating/More-Recipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/missating/More-Recipes/merges","archive_url":"https://api.github.com/repos/missating/More-Recipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/missating/More-Recipes/downloads","issues_url":"https://api.github.com/repos/missating/More-Recipes/issues{/number}","pulls_url":"https://api.github.com/repos/missating/More-Recipes/pulls{/number}","milestones_url":"https://api.github.com/repos/missating/More-Recipes/milestones{/number}","notifications_url":"https://api.github.com/repos/missating/More-Recipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/missating/More-Recipes/labels{/name}","releases_url":"https://api.github.com/repos/missating/More-Recipes/releases{/id}","deployments_url":"https://api.github.com/repos/missating/More-Recipes/deployments","created_at":"2017-10-21T00:43:24Z","updated_at":"2017-11-19T04:31:43Z","pushed_at":"2017-12-18T06:19:32Z","git_url":"git://github.com/missating/More-Recipes.git","ssh_url":"[email protected]:missating/More-Recipes.git","clone_url":"https://github.com/missating/More-Recipes.git","svn_url":"https://github.com/missating/More-Recipes","homepage":"https://missating.github.io/More-Recipes/template/index.html","size":3290,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/missating/More-Recipes/pulls/40"},"html":{"href":"https://github.com/missating/More-Recipes/pull/40"},"issue":{"href":"https://api.github.com/repos/missating/More-Recipes/issues/40"},"comments":{"href":"https://api.github.com/repos/missating/More-Recipes/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/missating/More-Recipes/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/missating/More-Recipes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/missating/More-Recipes/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/missating/More-Recipes/statuses/678fff2a05ff8fe52abc07223a92b6c480450898"}},"author_association":"OWNER"}} | {
"id": 107739634,
"name": "missating/More-Recipes",
"url": "https://api.github.com/repos/missating/More-Recipes"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-12-18T06:19:33 | 7000617214 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/faheel/Algos/pulls/comments/128314791","pull_request_review_id":50983074,"id":128314791,"diff_hunk":"@@ -0,0 +1,28 @@\n+#define FAST_POWER_TEST\n+#define CATCH_CONFIG_MAIN\n+\n+#include \"../catch.hpp\"\n+#include \"../../NumberTheory/FastPower.cpp\"\n+\n+\n+TEST_CASE(\"Base cases\", \"[fast_power]\") {\n+ //REQUIRE(fast_power(0,0) == undefined);\n+ REQUIRE(fast_power(0,1) == 0);\n+ REQUIRE(fast_power(1,0) == 1);\n+ REQUIRE(fast_power(1,1) == 1);\n+}\n+\n+TEST_CASE(\"Normal cases\", \"[fast_power]\") {\n+ REQUIRE(fast_power(2,2) == 4);\n+ REQUIRE(fast_power(2,4) == 16);\n+ REQUIRE(fast_power(3,4) == 81);\n+ REQUIRE(fast_power(7,9) == 40353607);\n+ REQUIRE(fast_power(15,10) == 576650390625);\n+}\n+\n+TEST_CASE(\"Overflow cases\", \"[fast_power]\") {\n+ REQUIRE(fast_power(2,100) == 68719476736);\n+ REQUIRE(fast_power(10,99) == 4440381706574496940U);","path":"Test/NumberTheory/FastPower.test.cpp","position":25,"original_position":25,"commit_id":"ea182d52e24f942ffd802b6a779f7c5e3ff0baa0","original_commit_id":"ea182d52e24f942ffd802b6a779f7c5e3ff0baa0","user":{"login":"faheel","id":11466676,"avatar_url":"https://avatars2.githubusercontent.com/u/11466676?v=4","gravatar_id":"","url":"https://api.github.com/users/faheel","html_url":"https://github.com/faheel","followers_url":"https://api.github.com/users/faheel/followers","following_url":"https://api.github.com/users/faheel/following{/other_user}","gists_url":"https://api.github.com/users/faheel/gists{/gist_id}","starred_url":"https://api.github.com/users/faheel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faheel/subscriptions","organizations_url":"https://api.github.com/users/faheel/orgs","repos_url":"https://api.github.com/users/faheel/repos","events_url":"https://api.github.com/users/faheel/events{/privacy}","received_events_url":"https://api.github.com/users/faheel/received_events","type":"User","site_admin":false},"body":"10<sup>12</sup>+7 is not prime! So the modulo may be 0 in some cases. Use 10<sup>9</sup>+7 instead.","created_at":"2017-07-19T17:35:53Z","updated_at":"2017-07-19T17:35:53Z","html_url":"https://github.com/faheel/Algos/pull/76#discussion_r128314791","pull_request_url":"https://api.github.com/repos/faheel/Algos/pulls/76","_links":{"self":{"href":"https://api.github.com/repos/faheel/Algos/pulls/comments/128314791"},"html":{"href":"https://github.com/faheel/Algos/pull/76#discussion_r128314791"},"pull_request":{"href":"https://api.github.com/repos/faheel/Algos/pulls/76"}}},"pull_request":{"url":"https://api.github.com/repos/faheel/Algos/pulls/76","id":129074934,"html_url":"https://github.com/faheel/Algos/pull/76","diff_url":"https://github.com/faheel/Algos/pull/76.diff","patch_url":"https://github.com/faheel/Algos/pull/76.patch","issue_url":"https://api.github.com/repos/faheel/Algos/issues/76","number":76,"state":"open","locked":false,"title":"Added Fast Power in Number Theory","user":{"login":"ahmad307","id":25267569,"avatar_url":"https://avatars0.githubusercontent.com/u/25267569?v=4","gravatar_id":"","url":"https://api.github.com/users/ahmad307","html_url":"https://github.com/ahmad307","followers_url":"https://api.github.com/users/ahmad307/followers","following_url":"https://api.github.com/users/ahmad307/following{/other_user}","gists_url":"https://api.github.com/users/ahmad307/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmad307/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmad307/subscriptions","organizations_url":"https://api.github.com/users/ahmad307/orgs","repos_url":"https://api.github.com/users/ahmad307/repos","events_url":"https://api.github.com/users/ahmad307/events{/privacy}","received_events_url":"https://api.github.com/users/ahmad307/received_events","type":"User","site_admin":false},"body":"This is my first PR, please tell me if there are any issues to be fixed.\r\nRelates to issue #75.","created_at":"2017-07-05T23:22:11Z","updated_at":"2017-07-19T17:35:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e38122f304a4133a7999283588f68ef8a85c38c7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/faheel/Algos/pulls/76/commits","review_comments_url":"https://api.github.com/repos/faheel/Algos/pulls/76/comments","review_comment_url":"https://api.github.com/repos/faheel/Algos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/faheel/Algos/issues/76/comments","statuses_url":"https://api.github.com/repos/faheel/Algos/statuses/ea182d52e24f942ffd802b6a779f7c5e3ff0baa0","head":{"label":"ahmad307:master","ref":"master","sha":"ea182d52e24f942ffd802b6a779f7c5e3ff0baa0","user":{"login":"ahmad307","id":25267569,"avatar_url":"https://avatars0.githubusercontent.com/u/25267569?v=4","gravatar_id":"","url":"https://api.github.com/users/ahmad307","html_url":"https://github.com/ahmad307","followers_url":"https://api.github.com/users/ahmad307/followers","following_url":"https://api.github.com/users/ahmad307/following{/other_user}","gists_url":"https://api.github.com/users/ahmad307/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmad307/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmad307/subscriptions","organizations_url":"https://api.github.com/users/ahmad307/orgs","repos_url":"https://api.github.com/users/ahmad307/repos","events_url":"https://api.github.com/users/ahmad307/events{/privacy}","received_events_url":"https://api.github.com/users/ahmad307/received_events","type":"User","site_admin":false},"repo":{"id":96366124,"name":"Algos","full_name":"ahmad307/Algos","owner":{"login":"ahmad307","id":25267569,"avatar_url":"https://avatars0.githubusercontent.com/u/25267569?v=4","gravatar_id":"","url":"https://api.github.com/users/ahmad307","html_url":"https://github.com/ahmad307","followers_url":"https://api.github.com/users/ahmad307/followers","following_url":"https://api.github.com/users/ahmad307/following{/other_user}","gists_url":"https://api.github.com/users/ahmad307/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmad307/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmad307/subscriptions","organizations_url":"https://api.github.com/users/ahmad307/orgs","repos_url":"https://api.github.com/users/ahmad307/repos","events_url":"https://api.github.com/users/ahmad307/events{/privacy}","received_events_url":"https://api.github.com/users/ahmad307/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahmad307/Algos","description":"Implementation of well-known (and some rare) algorithms, mostly in C++","fork":true,"url":"https://api.github.com/repos/ahmad307/Algos","forks_url":"https://api.github.com/repos/ahmad307/Algos/forks","keys_url":"https://api.github.com/repos/ahmad307/Algos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahmad307/Algos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahmad307/Algos/teams","hooks_url":"https://api.github.com/repos/ahmad307/Algos/hooks","issue_events_url":"https://api.github.com/repos/ahmad307/Algos/issues/events{/number}","events_url":"https://api.github.com/repos/ahmad307/Algos/events","assignees_url":"https://api.github.com/repos/ahmad307/Algos/assignees{/user}","branches_url":"https://api.github.com/repos/ahmad307/Algos/branches{/branch}","tags_url":"https://api.github.com/repos/ahmad307/Algos/tags","blobs_url":"https://api.github.com/repos/ahmad307/Algos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahmad307/Algos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahmad307/Algos/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahmad307/Algos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahmad307/Algos/statuses/{sha}","languages_url":"https://api.github.com/repos/ahmad307/Algos/languages","stargazers_url":"https://api.github.com/repos/ahmad307/Algos/stargazers","contributors_url":"https://api.github.com/repos/ahmad307/Algos/contributors","subscribers_url":"https://api.github.com/repos/ahmad307/Algos/subscribers","subscription_url":"https://api.github.com/repos/ahmad307/Algos/subscription","commits_url":"https://api.github.com/repos/ahmad307/Algos/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahmad307/Algos/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahmad307/Algos/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahmad307/Algos/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahmad307/Algos/contents/{+path}","compare_url":"https://api.github.com/repos/ahmad307/Algos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahmad307/Algos/merges","archive_url":"https://api.github.com/repos/ahmad307/Algos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahmad307/Algos/downloads","issues_url":"https://api.github.com/repos/ahmad307/Algos/issues{/number}","pulls_url":"https://api.github.com/repos/ahmad307/Algos/pulls{/number}","milestones_url":"https://api.github.com/repos/ahmad307/Algos/milestones{/number}","notifications_url":"https://api.github.com/repos/ahmad307/Algos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahmad307/Algos/labels{/name}","releases_url":"https://api.github.com/repos/ahmad307/Algos/releases{/id}","deployments_url":"https://api.github.com/repos/ahmad307/Algos/deployments","created_at":"2017-07-05T22:27:02Z","updated_at":"2017-07-05T22:27:03Z","pushed_at":"2017-07-08T13:31:35Z","git_url":"git://github.com/ahmad307/Algos.git","ssh_url":"[email protected]:ahmad307/Algos.git","clone_url":"https://github.com/ahmad307/Algos.git","svn_url":"https://github.com/ahmad307/Algos","homepage":null,"size":240,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"faheel:master","ref":"master","sha":"711de5a2f3aa8fa2f479e966654cb73c5ea53149","user":{"login":"faheel","id":11466676,"avatar_url":"https://avatars2.githubusercontent.com/u/11466676?v=4","gravatar_id":"","url":"https://api.github.com/users/faheel","html_url":"https://github.com/faheel","followers_url":"https://api.github.com/users/faheel/followers","following_url":"https://api.github.com/users/faheel/following{/other_user}","gists_url":"https://api.github.com/users/faheel/gists{/gist_id}","starred_url":"https://api.github.com/users/faheel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faheel/subscriptions","organizations_url":"https://api.github.com/users/faheel/orgs","repos_url":"https://api.github.com/users/faheel/repos","events_url":"https://api.github.com/users/faheel/events{/privacy}","received_events_url":"https://api.github.com/users/faheel/received_events","type":"User","site_admin":false},"repo":{"id":76900154,"name":"Algos","full_name":"faheel/Algos","owner":{"login":"faheel","id":11466676,"avatar_url":"https://avatars2.githubusercontent.com/u/11466676?v=4","gravatar_id":"","url":"https://api.github.com/users/faheel","html_url":"https://github.com/faheel","followers_url":"https://api.github.com/users/faheel/followers","following_url":"https://api.github.com/users/faheel/following{/other_user}","gists_url":"https://api.github.com/users/faheel/gists{/gist_id}","starred_url":"https://api.github.com/users/faheel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faheel/subscriptions","organizations_url":"https://api.github.com/users/faheel/orgs","repos_url":"https://api.github.com/users/faheel/repos","events_url":"https://api.github.com/users/faheel/events{/privacy}","received_events_url":"https://api.github.com/users/faheel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/faheel/Algos","description":"Implementation of well-known (and some rare) algorithms, mostly in C++","fork":false,"url":"https://api.github.com/repos/faheel/Algos","forks_url":"https://api.github.com/repos/faheel/Algos/forks","keys_url":"https://api.github.com/repos/faheel/Algos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/faheel/Algos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/faheel/Algos/teams","hooks_url":"https://api.github.com/repos/faheel/Algos/hooks","issue_events_url":"https://api.github.com/repos/faheel/Algos/issues/events{/number}","events_url":"https://api.github.com/repos/faheel/Algos/events","assignees_url":"https://api.github.com/repos/faheel/Algos/assignees{/user}","branches_url":"https://api.github.com/repos/faheel/Algos/branches{/branch}","tags_url":"https://api.github.com/repos/faheel/Algos/tags","blobs_url":"https://api.github.com/repos/faheel/Algos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/faheel/Algos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/faheel/Algos/git/refs{/sha}","trees_url":"https://api.github.com/repos/faheel/Algos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/faheel/Algos/statuses/{sha}","languages_url":"https://api.github.com/repos/faheel/Algos/languages","stargazers_url":"https://api.github.com/repos/faheel/Algos/stargazers","contributors_url":"https://api.github.com/repos/faheel/Algos/contributors","subscribers_url":"https://api.github.com/repos/faheel/Algos/subscribers","subscription_url":"https://api.github.com/repos/faheel/Algos/subscription","commits_url":"https://api.github.com/repos/faheel/Algos/commits{/sha}","git_commits_url":"https://api.github.com/repos/faheel/Algos/git/commits{/sha}","comments_url":"https://api.github.com/repos/faheel/Algos/comments{/number}","issue_comment_url":"https://api.github.com/repos/faheel/Algos/issues/comments{/number}","contents_url":"https://api.github.com/repos/faheel/Algos/contents/{+path}","compare_url":"https://api.github.com/repos/faheel/Algos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/faheel/Algos/merges","archive_url":"https://api.github.com/repos/faheel/Algos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/faheel/Algos/downloads","issues_url":"https://api.github.com/repos/faheel/Algos/issues{/number}","pulls_url":"https://api.github.com/repos/faheel/Algos/pulls{/number}","milestones_url":"https://api.github.com/repos/faheel/Algos/milestones{/number}","notifications_url":"https://api.github.com/repos/faheel/Algos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/faheel/Algos/labels{/name}","releases_url":"https://api.github.com/repos/faheel/Algos/releases{/id}","deployments_url":"https://api.github.com/repos/faheel/Algos/deployments","created_at":"2016-12-19T21:51:27Z","updated_at":"2017-07-12T19:36:40Z","pushed_at":"2017-07-14T09:32:16Z","git_url":"git://github.com/faheel/Algos.git","ssh_url":"[email protected]:faheel/Algos.git","clone_url":"https://github.com/faheel/Algos.git","svn_url":"https://github.com/faheel/Algos","homepage":null,"size":234,"stargazers_count":63,"watchers_count":63,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":77,"mirror_url":null,"open_issues_count":46,"forks":77,"open_issues":46,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/faheel/Algos/pulls/76"},"html":{"href":"https://github.com/faheel/Algos/pull/76"},"issue":{"href":"https://api.github.com/repos/faheel/Algos/issues/76"},"comments":{"href":"https://api.github.com/repos/faheel/Algos/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/faheel/Algos/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/faheel/Algos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/faheel/Algos/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/faheel/Algos/statuses/ea182d52e24f942ffd802b6a779f7c5e3ff0baa0"}}}} | {
"id": 76900154,
"name": "faheel/Algos",
"url": "https://api.github.com/repos/faheel/Algos"
} | {
"id": 11466676,
"login": "faheel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11466676?",
"url": "https://api.github.com/users/faheel"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-07-19T17:35:53 | 6288710852 | {"actor":{"display_login":"faheel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/NikAshanin/HomeTasks/pulls/comments/153250308","pull_request_review_id":79229217,"id":153250308,"diff_hunk":"@@ -0,0 +1,127 @@\n+//\n+// CircleGestureRecognizer.swift\n+// Circle_Gesture\n+//\n+// Created by Artem Orlov on 08/11/2017.\n+//\n+\n+import UIKit.UIGestureRecognizerSubclass\n+\n+class CircleGestureRecognizer: UIGestureRecognizer {\n+\n+ var innerRadius: CGFloat?\n+ var outerRadius: CGFloat?\n+ let midPoint: CGPoint\n+\n+ // Distance between touch and middle point\n+ private var distance: CGFloat? {\n+\n+ if let newPoint = currentPoint {\n+ return distanceBetween(pointA: midPoint, and: newPoint)\n+ }\n+ return nil\n+ }\n+\n+ init(midPoint: CGPoint, innerRadius: CGFloat?, outerRadius: CGFloat?, target: AnyObject?, action: Selector) {\n+ self.midPoint = midPoint","path":"CustomGesture/CustomGesture/CircleGestureRecognizer.swift","position":16,"original_position":26,"commit_id":"440f0b98efe503d0d71aaf6494f2f75a480959e7","original_commit_id":"387de8dee981960e43772d531ac33153a99cb653","user":{"login":"CasualEagle","id":29330555,"avatar_url":"https://avatars0.githubusercontent.com/u/29330555?v=4","gravatar_id":"","url":"https://api.github.com/users/CasualEagle","html_url":"https://github.com/CasualEagle","followers_url":"https://api.github.com/users/CasualEagle/followers","following_url":"https://api.github.com/users/CasualEagle/following{/other_user}","gists_url":"https://api.github.com/users/CasualEagle/gists{/gist_id}","starred_url":"https://api.github.com/users/CasualEagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CasualEagle/subscriptions","organizations_url":"https://api.github.com/users/CasualEagle/orgs","repos_url":"https://api.github.com/users/CasualEagle/repos","events_url":"https://api.github.com/users/CasualEagle/events{/privacy}","received_events_url":"https://api.github.com/users/CasualEagle/received_events","type":"User","site_admin":false},"body":"Если вызывать после супер, то выдает такие две ошибки \r\nProperty 'self.midPoint' not initialized at super.init call\r\nImmutable value 'self.midPoint' may only be initialized once\r\n\r\nА, понял, у меня раньше было var midPoint: CGPoint = .zero , но теперь private let midPoint: CGPoint , поэтому нужно инициализировать до супер","created_at":"2017-11-27T16:35:12Z","updated_at":"2017-11-27T16:35:12Z","html_url":"https://github.com/NikAshanin/HomeTasks/pull/2#discussion_r153250308","pull_request_url":"https://api.github.com/repos/NikAshanin/HomeTasks/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/NikAshanin/HomeTasks/pulls/comments/153250308"},"html":{"href":"https://github.com/NikAshanin/HomeTasks/pull/2#discussion_r153250308"},"pull_request":{"href":"https://api.github.com/repos/NikAshanin/HomeTasks/pulls/2"}},"in_reply_to_id":152000392},"pull_request":{"url":"https://api.github.com/repos/NikAshanin/HomeTasks/pulls/2","id":153340243,"html_url":"https://github.com/NikAshanin/HomeTasks/pull/2","diff_url":"https://github.com/NikAshanin/HomeTasks/pull/2.diff","patch_url":"https://github.com/NikAshanin/HomeTasks/pull/2.patch","issue_url":"https://api.github.com/repos/NikAshanin/HomeTasks/issues/2","number":2,"state":"open","locked":false,"title":"orlov_artem/gesture","user":{"login":"CasualEagle","id":29330555,"avatar_url":"https://avatars0.githubusercontent.com/u/29330555?v=4","gravatar_id":"","url":"https://api.github.com/users/CasualEagle","html_url":"https://github.com/CasualEagle","followers_url":"https://api.github.com/users/CasualEagle/followers","following_url":"https://api.github.com/users/CasualEagle/following{/other_user}","gists_url":"https://api.github.com/users/CasualEagle/gists{/gist_id}","starred_url":"https://api.github.com/users/CasualEagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CasualEagle/subscriptions","organizations_url":"https://api.github.com/users/CasualEagle/orgs","repos_url":"https://api.github.com/users/CasualEagle/repos","events_url":"https://api.github.com/users/CasualEagle/events{/privacy}","received_events_url":"https://api.github.com/users/CasualEagle/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-17T16:32:26Z","updated_at":"2017-11-27T16:35:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76c77a1bd2f9cef7cbf66e445dda5aebba4cd28b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/NikAshanin/HomeTasks/pulls/2/commits","review_comments_url":"https://api.github.com/repos/NikAshanin/HomeTasks/pulls/2/comments","review_comment_url":"https://api.github.com/repos/NikAshanin/HomeTasks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NikAshanin/HomeTasks/issues/2/comments","statuses_url":"https://api.github.com/repos/NikAshanin/HomeTasks/statuses/440f0b98efe503d0d71aaf6494f2f75a480959e7","head":{"label":"CasualEagle:orlov_artem/gesture","ref":"orlov_artem/gesture","sha":"440f0b98efe503d0d71aaf6494f2f75a480959e7","user":{"login":"CasualEagle","id":29330555,"avatar_url":"https://avatars0.githubusercontent.com/u/29330555?v=4","gravatar_id":"","url":"https://api.github.com/users/CasualEagle","html_url":"https://github.com/CasualEagle","followers_url":"https://api.github.com/users/CasualEagle/followers","following_url":"https://api.github.com/users/CasualEagle/following{/other_user}","gists_url":"https://api.github.com/users/CasualEagle/gists{/gist_id}","starred_url":"https://api.github.com/users/CasualEagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CasualEagle/subscriptions","organizations_url":"https://api.github.com/users/CasualEagle/orgs","repos_url":"https://api.github.com/users/CasualEagle/repos","events_url":"https://api.github.com/users/CasualEagle/events{/privacy}","received_events_url":"https://api.github.com/users/CasualEagle/received_events","type":"User","site_admin":false},"repo":{"id":111016315,"name":"HomeTasks","full_name":"CasualEagle/HomeTasks","owner":{"login":"CasualEagle","id":29330555,"avatar_url":"https://avatars0.githubusercontent.com/u/29330555?v=4","gravatar_id":"","url":"https://api.github.com/users/CasualEagle","html_url":"https://github.com/CasualEagle","followers_url":"https://api.github.com/users/CasualEagle/followers","following_url":"https://api.github.com/users/CasualEagle/following{/other_user}","gists_url":"https://api.github.com/users/CasualEagle/gists{/gist_id}","starred_url":"https://api.github.com/users/CasualEagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CasualEagle/subscriptions","organizations_url":"https://api.github.com/users/CasualEagle/orgs","repos_url":"https://api.github.com/users/CasualEagle/repos","events_url":"https://api.github.com/users/CasualEagle/events{/privacy}","received_events_url":"https://api.github.com/users/CasualEagle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CasualEagle/HomeTasks","description":null,"fork":true,"url":"https://api.github.com/repos/CasualEagle/HomeTasks","forks_url":"https://api.github.com/repos/CasualEagle/HomeTasks/forks","keys_url":"https://api.github.com/repos/CasualEagle/HomeTasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CasualEagle/HomeTasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CasualEagle/HomeTasks/teams","hooks_url":"https://api.github.com/repos/CasualEagle/HomeTasks/hooks","issue_events_url":"https://api.github.com/repos/CasualEagle/HomeTasks/issues/events{/number}","events_url":"https://api.github.com/repos/CasualEagle/HomeTasks/events","assignees_url":"https://api.github.com/repos/CasualEagle/HomeTasks/assignees{/user}","branches_url":"https://api.github.com/repos/CasualEagle/HomeTasks/branches{/branch}","tags_url":"https://api.github.com/repos/CasualEagle/HomeTasks/tags","blobs_url":"https://api.github.com/repos/CasualEagle/HomeTasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CasualEagle/HomeTasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CasualEagle/HomeTasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/CasualEagle/HomeTasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CasualEagle/HomeTasks/statuses/{sha}","languages_url":"https://api.github.com/repos/CasualEagle/HomeTasks/languages","stargazers_url":"https://api.github.com/repos/CasualEagle/HomeTasks/stargazers","contributors_url":"https://api.github.com/repos/CasualEagle/HomeTasks/contributors","subscribers_url":"https://api.github.com/repos/CasualEagle/HomeTasks/subscribers","subscription_url":"https://api.github.com/repos/CasualEagle/HomeTasks/subscription","commits_url":"https://api.github.com/repos/CasualEagle/HomeTasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/CasualEagle/HomeTasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/CasualEagle/HomeTasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/CasualEagle/HomeTasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/CasualEagle/HomeTasks/contents/{+path}","compare_url":"https://api.github.com/repos/CasualEagle/HomeTasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CasualEagle/HomeTasks/merges","archive_url":"https://api.github.com/repos/CasualEagle/HomeTasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CasualEagle/HomeTasks/downloads","issues_url":"https://api.github.com/repos/CasualEagle/HomeTasks/issues{/number}","pulls_url":"https://api.github.com/repos/CasualEagle/HomeTasks/pulls{/number}","milestones_url":"https://api.github.com/repos/CasualEagle/HomeTasks/milestones{/number}","notifications_url":"https://api.github.com/repos/CasualEagle/HomeTasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CasualEagle/HomeTasks/labels{/name}","releases_url":"https://api.github.com/repos/CasualEagle/HomeTasks/releases{/id}","deployments_url":"https://api.github.com/repos/CasualEagle/HomeTasks/deployments","created_at":"2017-11-16T20:01:34Z","updated_at":"2017-11-16T20:01:36Z","pushed_at":"2017-11-27T15:10:57Z","git_url":"git://github.com/CasualEagle/HomeTasks.git","ssh_url":"[email protected]:CasualEagle/HomeTasks.git","clone_url":"https://github.com/CasualEagle/HomeTasks.git","svn_url":"https://github.com/CasualEagle/HomeTasks","homepage":null,"size":1095,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NikAshanin:master","ref":"master","sha":"2990a327e2c72503b965567d085780b98d9209ba","user":{"login":"NikAshanin","id":9415847,"avatar_url":"https://avatars2.githubusercontent.com/u/9415847?v=4","gravatar_id":"","url":"https://api.github.com/users/NikAshanin","html_url":"https://github.com/NikAshanin","followers_url":"https://api.github.com/users/NikAshanin/followers","following_url":"https://api.github.com/users/NikAshanin/following{/other_user}","gists_url":"https://api.github.com/users/NikAshanin/gists{/gist_id}","starred_url":"https://api.github.com/users/NikAshanin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NikAshanin/subscriptions","organizations_url":"https://api.github.com/users/NikAshanin/orgs","repos_url":"https://api.github.com/users/NikAshanin/repos","events_url":"https://api.github.com/users/NikAshanin/events{/privacy}","received_events_url":"https://api.github.com/users/NikAshanin/received_events","type":"User","site_admin":false},"repo":{"id":110700101,"name":"HomeTasks","full_name":"NikAshanin/HomeTasks","owner":{"login":"NikAshanin","id":9415847,"avatar_url":"https://avatars2.githubusercontent.com/u/9415847?v=4","gravatar_id":"","url":"https://api.github.com/users/NikAshanin","html_url":"https://github.com/NikAshanin","followers_url":"https://api.github.com/users/NikAshanin/followers","following_url":"https://api.github.com/users/NikAshanin/following{/other_user}","gists_url":"https://api.github.com/users/NikAshanin/gists{/gist_id}","starred_url":"https://api.github.com/users/NikAshanin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NikAshanin/subscriptions","organizations_url":"https://api.github.com/users/NikAshanin/orgs","repos_url":"https://api.github.com/users/NikAshanin/repos","events_url":"https://api.github.com/users/NikAshanin/events{/privacy}","received_events_url":"https://api.github.com/users/NikAshanin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NikAshanin/HomeTasks","description":null,"fork":false,"url":"https://api.github.com/repos/NikAshanin/HomeTasks","forks_url":"https://api.github.com/repos/NikAshanin/HomeTasks/forks","keys_url":"https://api.github.com/repos/NikAshanin/HomeTasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NikAshanin/HomeTasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NikAshanin/HomeTasks/teams","hooks_url":"https://api.github.com/repos/NikAshanin/HomeTasks/hooks","issue_events_url":"https://api.github.com/repos/NikAshanin/HomeTasks/issues/events{/number}","events_url":"https://api.github.com/repos/NikAshanin/HomeTasks/events","assignees_url":"https://api.github.com/repos/NikAshanin/HomeTasks/assignees{/user}","branches_url":"https://api.github.com/repos/NikAshanin/HomeTasks/branches{/branch}","tags_url":"https://api.github.com/repos/NikAshanin/HomeTasks/tags","blobs_url":"https://api.github.com/repos/NikAshanin/HomeTasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NikAshanin/HomeTasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NikAshanin/HomeTasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/NikAshanin/HomeTasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NikAshanin/HomeTasks/statuses/{sha}","languages_url":"https://api.github.com/repos/NikAshanin/HomeTasks/languages","stargazers_url":"https://api.github.com/repos/NikAshanin/HomeTasks/stargazers","contributors_url":"https://api.github.com/repos/NikAshanin/HomeTasks/contributors","subscribers_url":"https://api.github.com/repos/NikAshanin/HomeTasks/subscribers","subscription_url":"https://api.github.com/repos/NikAshanin/HomeTasks/subscription","commits_url":"https://api.github.com/repos/NikAshanin/HomeTasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/NikAshanin/HomeTasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/NikAshanin/HomeTasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/NikAshanin/HomeTasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/NikAshanin/HomeTasks/contents/{+path}","compare_url":"https://api.github.com/repos/NikAshanin/HomeTasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NikAshanin/HomeTasks/merges","archive_url":"https://api.github.com/repos/NikAshanin/HomeTasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NikAshanin/HomeTasks/downloads","issues_url":"https://api.github.com/repos/NikAshanin/HomeTasks/issues{/number}","pulls_url":"https://api.github.com/repos/NikAshanin/HomeTasks/pulls{/number}","milestones_url":"https://api.github.com/repos/NikAshanin/HomeTasks/milestones{/number}","notifications_url":"https://api.github.com/repos/NikAshanin/HomeTasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NikAshanin/HomeTasks/labels{/name}","releases_url":"https://api.github.com/repos/NikAshanin/HomeTasks/releases{/id}","deployments_url":"https://api.github.com/repos/NikAshanin/HomeTasks/deployments","created_at":"2017-11-14T14:23:35Z","updated_at":"2017-11-16T12:54:08Z","pushed_at":"2017-11-27T15:43:26Z","git_url":"git://github.com/NikAshanin/HomeTasks.git","ssh_url":"[email protected]:NikAshanin/HomeTasks.git","clone_url":"https://github.com/NikAshanin/HomeTasks.git","svn_url":"https://github.com/NikAshanin/HomeTasks","homepage":null,"size":35,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":31,"forks":13,"open_issues":31,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NikAshanin/HomeTasks/pulls/2"},"html":{"href":"https://github.com/NikAshanin/HomeTasks/pull/2"},"issue":{"href":"https://api.github.com/repos/NikAshanin/HomeTasks/issues/2"},"comments":{"href":"https://api.github.com/repos/NikAshanin/HomeTasks/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/NikAshanin/HomeTasks/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/NikAshanin/HomeTasks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NikAshanin/HomeTasks/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/NikAshanin/HomeTasks/statuses/440f0b98efe503d0d71aaf6494f2f75a480959e7"}},"author_association":"NONE"}} | {
"id": 110700101,
"name": "NikAshanin/HomeTasks",
"url": "https://api.github.com/repos/NikAshanin/HomeTasks"
} | {
"id": 29330555,
"login": "CasualEagle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29330555?",
"url": "https://api.github.com/users/CasualEagle"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-11-27T16:35:12 | 6908037665 | {"actor":{"display_login":"CasualEagle"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/craffel/pretty-midi/pulls/comments/115777751","pull_request_review_id":37346189,"id":115777751,"diff_hunk":"@@ -0,0 +1,93 @@\n+from __future__ import division\n+\"\"\"\n+Utility function for converting a piano roll (integer matrix of shape\n+(n_notes, n_frames)) to a pretty_midi.PrettyMIDI object. Note that this is a\n+lossy process because certain information in a MIDI file (such as different\n+instruments, pitch bends, overlapping notes, control changes, etc) cannot\n+be stored in the piano roll matrix. To demonstrate the lossiness, this script\n+includes a demonstration of parsing a MIDI file, constructing a piano roll\n+matrix, and then creating a new MIDI from the piano roll.\n+\n+Most of this code is from @carlthome. @jsleep Adapted that code from mido\n+ to pretty_midi.\n+\"\"\"\n+import pretty_midi\n+import numpy as np\n+import sys\n+import argparse\n+\n+\n+def piano_roll_to_pretty_midi(piano_roll, fs=100, program=1):\n+ '''Convert a Piano Roll array into a PrettyMidi object\n+ with a single instrument.\n+\n+ Parameters\n+ ----------\n+ piano_roll : np.ndarray, shape=(128,time), dtype=int\n+ Piano roll of one instrument\n+ fs : int\n+ Sampling frequency of the columns, i.e. each column is spaced apart\n+ by ``1./fs`` seconds.\n+ program : int\n+ The program number of the instrument.\n+\n+ Returns\n+ -------\n+ midi_object : pretty_midi.PrettyMIDI\n+ A pretty_midi.PrettyMIDI class instance describing\n+ the piano roll.\n+\n+ '''\n+ notes, frames = piano_roll.shape\n+ pm = pretty_midi.PrettyMIDI()\n+ instrument = pretty_midi.Instrument(program=program)\n+\n+ # pad 1 column of zeros so we can acknowledge inital and ending events\n+ piano_roll = np.pad(piano_roll, [(0, 0), (1, 1)], 'constant')\n+\n+ # use changes in velocities to find note on / note off events\n+ velocity_changes = np.nonzero(np.diff(piano_roll).T)\n+\n+ # keep track on velocities and note on times\n+ prev_velocities = np.zeros(notes, dtype=int)\n+ note_on_time = np.zeros(notes)\n+\n+ for time, note in zip(*velocity_changes):\n+ velocity = piano_roll[note, time + 1]\n+ time = time / fs\n+ if velocity > 0:\n+ if prev_velocities[note] == 0:\n+ note_on_time[note] = time\n+ prev_velocities[note] = velocity\n+ else:\n+ pm_note = pretty_midi.Note(\n+ velocity=prev_velocities[note],\n+ pitch=note,\n+ start=note_on_time[note],\n+ end=time)\n+ instrument.notes.append(pm_note)\n+ prev_velocities[note] = 0\n+ pm.instruments.append(instrument)\n+ return pm\n+\n+if __name__ == '__main__':","path":"examples/reverse_pianoroll.py","position":73,"original_position":73,"commit_id":"130dc341c7a816d6c18771b9c049ae26e9429ec4","original_commit_id":"130dc341c7a816d6c18771b9c049ae26e9429ec4","user":{"login":"carlthome","id":1595907,"avatar_url":"https://avatars0.githubusercontent.com/u/1595907?v=3","gravatar_id":"","url":"https://api.github.com/users/carlthome","html_url":"https://github.com/carlthome","followers_url":"https://api.github.com/users/carlthome/followers","following_url":"https://api.github.com/users/carlthome/following{/other_user}","gists_url":"https://api.github.com/users/carlthome/gists{/gist_id}","starred_url":"https://api.github.com/users/carlthome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlthome/subscriptions","organizations_url":"https://api.github.com/users/carlthome/orgs","repos_url":"https://api.github.com/users/carlthome/repos","events_url":"https://api.github.com/users/carlthome/events{/privacy}","received_events_url":"https://api.github.com/users/carlthome/received_events","type":"User","site_admin":false},"body":"Alright. Anyway, adding the examples to Travis should be a separate pull request.\r\n\r\nE.g. something like:\r\n`- python examples/reverse_pianoroll.py example.mid /tmp/example.mid` after [this](https://github.com/craffel/pretty-midi/blob/db1c3c3da98b4fa9bc8044d1e4e7566811cda1a3/.travis.yml#L20\r\n).\r\n\r\nI get how one would like to avoid running computationally expensive stuff in this manner though, but for these particular scripts it should be fine IMHO. :pancakes: ","created_at":"2017-05-10T15:45:33Z","updated_at":"2017-05-10T15:45:33Z","html_url":"https://github.com/craffel/pretty-midi/pull/129#discussion_r115777751","pull_request_url":"https://api.github.com/repos/craffel/pretty-midi/pulls/129","_links":{"self":{"href":"https://api.github.com/repos/craffel/pretty-midi/pulls/comments/115777751"},"html":{"href":"https://github.com/craffel/pretty-midi/pull/129#discussion_r115777751"},"pull_request":{"href":"https://api.github.com/repos/craffel/pretty-midi/pulls/129"}}},"pull_request":{"url":"https://api.github.com/repos/craffel/pretty-midi/pulls/129","id":119276604,"html_url":"https://github.com/craffel/pretty-midi/pull/129","diff_url":"https://github.com/craffel/pretty-midi/pull/129.diff","patch_url":"https://github.com/craffel/pretty-midi/pull/129.patch","issue_url":"https://api.github.com/repos/craffel/pretty-midi/issues/129","number":129,"state":"open","locked":false,"title":"piano roll to pretty_midi object util","user":{"login":"jsleep","id":6540938,"avatar_url":"https://avatars3.githubusercontent.com/u/6540938?v=3","gravatar_id":"","url":"https://api.github.com/users/jsleep","html_url":"https://github.com/jsleep","followers_url":"https://api.github.com/users/jsleep/followers","following_url":"https://api.github.com/users/jsleep/following{/other_user}","gists_url":"https://api.github.com/users/jsleep/gists{/gist_id}","starred_url":"https://api.github.com/users/jsleep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsleep/subscriptions","organizations_url":"https://api.github.com/users/jsleep/orgs","repos_url":"https://api.github.com/users/jsleep/repos","events_url":"https://api.github.com/users/jsleep/events{/privacy}","received_events_url":"https://api.github.com/users/jsleep/received_events","type":"User","site_admin":false},"body":"Created a basic utility function for myself and saw that it might be useful in the examples directory here. It doesn't do much but could be adapted for anyone's use.","created_at":"2017-05-05T23:48:27Z","updated_at":"2017-05-10T15:45:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6de99ec67b4616f02abadfbe2ea5a4c0417baf6c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/craffel/pretty-midi/pulls/129/commits","review_comments_url":"https://api.github.com/repos/craffel/pretty-midi/pulls/129/comments","review_comment_url":"https://api.github.com/repos/craffel/pretty-midi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/craffel/pretty-midi/issues/129/comments","statuses_url":"https://api.github.com/repos/craffel/pretty-midi/statuses/130dc341c7a816d6c18771b9c049ae26e9429ec4","head":{"label":"jsleep:master","ref":"master","sha":"130dc341c7a816d6c18771b9c049ae26e9429ec4","user":{"login":"jsleep","id":6540938,"avatar_url":"https://avatars3.githubusercontent.com/u/6540938?v=3","gravatar_id":"","url":"https://api.github.com/users/jsleep","html_url":"https://github.com/jsleep","followers_url":"https://api.github.com/users/jsleep/followers","following_url":"https://api.github.com/users/jsleep/following{/other_user}","gists_url":"https://api.github.com/users/jsleep/gists{/gist_id}","starred_url":"https://api.github.com/users/jsleep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsleep/subscriptions","organizations_url":"https://api.github.com/users/jsleep/orgs","repos_url":"https://api.github.com/users/jsleep/repos","events_url":"https://api.github.com/users/jsleep/events{/privacy}","received_events_url":"https://api.github.com/users/jsleep/received_events","type":"User","site_admin":false},"repo":{"id":90423680,"name":"pretty-midi","full_name":"jsleep/pretty-midi","owner":{"login":"jsleep","id":6540938,"avatar_url":"https://avatars3.githubusercontent.com/u/6540938?v=3","gravatar_id":"","url":"https://api.github.com/users/jsleep","html_url":"https://github.com/jsleep","followers_url":"https://api.github.com/users/jsleep/followers","following_url":"https://api.github.com/users/jsleep/following{/other_user}","gists_url":"https://api.github.com/users/jsleep/gists{/gist_id}","starred_url":"https://api.github.com/users/jsleep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsleep/subscriptions","organizations_url":"https://api.github.com/users/jsleep/orgs","repos_url":"https://api.github.com/users/jsleep/repos","events_url":"https://api.github.com/users/jsleep/events{/privacy}","received_events_url":"https://api.github.com/users/jsleep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsleep/pretty-midi","description":"Utility functions for handling MIDI data in a nice/intuitive way.","fork":true,"url":"https://api.github.com/repos/jsleep/pretty-midi","forks_url":"https://api.github.com/repos/jsleep/pretty-midi/forks","keys_url":"https://api.github.com/repos/jsleep/pretty-midi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsleep/pretty-midi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsleep/pretty-midi/teams","hooks_url":"https://api.github.com/repos/jsleep/pretty-midi/hooks","issue_events_url":"https://api.github.com/repos/jsleep/pretty-midi/issues/events{/number}","events_url":"https://api.github.com/repos/jsleep/pretty-midi/events","assignees_url":"https://api.github.com/repos/jsleep/pretty-midi/assignees{/user}","branches_url":"https://api.github.com/repos/jsleep/pretty-midi/branches{/branch}","tags_url":"https://api.github.com/repos/jsleep/pretty-midi/tags","blobs_url":"https://api.github.com/repos/jsleep/pretty-midi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsleep/pretty-midi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsleep/pretty-midi/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsleep/pretty-midi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsleep/pretty-midi/statuses/{sha}","languages_url":"https://api.github.com/repos/jsleep/pretty-midi/languages","stargazers_url":"https://api.github.com/repos/jsleep/pretty-midi/stargazers","contributors_url":"https://api.github.com/repos/jsleep/pretty-midi/contributors","subscribers_url":"https://api.github.com/repos/jsleep/pretty-midi/subscribers","subscription_url":"https://api.github.com/repos/jsleep/pretty-midi/subscription","commits_url":"https://api.github.com/repos/jsleep/pretty-midi/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsleep/pretty-midi/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsleep/pretty-midi/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsleep/pretty-midi/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsleep/pretty-midi/contents/{+path}","compare_url":"https://api.github.com/repos/jsleep/pretty-midi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsleep/pretty-midi/merges","archive_url":"https://api.github.com/repos/jsleep/pretty-midi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsleep/pretty-midi/downloads","issues_url":"https://api.github.com/repos/jsleep/pretty-midi/issues{/number}","pulls_url":"https://api.github.com/repos/jsleep/pretty-midi/pulls{/number}","milestones_url":"https://api.github.com/repos/jsleep/pretty-midi/milestones{/number}","notifications_url":"https://api.github.com/repos/jsleep/pretty-midi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsleep/pretty-midi/labels{/name}","releases_url":"https://api.github.com/repos/jsleep/pretty-midi/releases{/id}","deployments_url":"https://api.github.com/repos/jsleep/pretty-midi/deployments","created_at":"2017-05-05T23:13:12Z","updated_at":"2017-05-05T23:13:14Z","pushed_at":"2017-05-08T21:23:41Z","git_url":"git://github.com/jsleep/pretty-midi.git","ssh_url":"[email protected]:jsleep/pretty-midi.git","clone_url":"https://github.com/jsleep/pretty-midi.git","svn_url":"https://github.com/jsleep/pretty-midi","homepage":null,"size":6929,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"craffel:master","ref":"master","sha":"c8ae1fae96bb3e2eec6f3ad360c691e43eb32247","user":{"login":"craffel","id":417568,"avatar_url":"https://avatars3.githubusercontent.com/u/417568?v=3","gravatar_id":"","url":"https://api.github.com/users/craffel","html_url":"https://github.com/craffel","followers_url":"https://api.github.com/users/craffel/followers","following_url":"https://api.github.com/users/craffel/following{/other_user}","gists_url":"https://api.github.com/users/craffel/gists{/gist_id}","starred_url":"https://api.github.com/users/craffel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craffel/subscriptions","organizations_url":"https://api.github.com/users/craffel/orgs","repos_url":"https://api.github.com/users/craffel/repos","events_url":"https://api.github.com/users/craffel/events{/privacy}","received_events_url":"https://api.github.com/users/craffel/received_events","type":"User","site_admin":false},"repo":{"id":11820959,"name":"pretty-midi","full_name":"craffel/pretty-midi","owner":{"login":"craffel","id":417568,"avatar_url":"https://avatars3.githubusercontent.com/u/417568?v=3","gravatar_id":"","url":"https://api.github.com/users/craffel","html_url":"https://github.com/craffel","followers_url":"https://api.github.com/users/craffel/followers","following_url":"https://api.github.com/users/craffel/following{/other_user}","gists_url":"https://api.github.com/users/craffel/gists{/gist_id}","starred_url":"https://api.github.com/users/craffel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craffel/subscriptions","organizations_url":"https://api.github.com/users/craffel/orgs","repos_url":"https://api.github.com/users/craffel/repos","events_url":"https://api.github.com/users/craffel/events{/privacy}","received_events_url":"https://api.github.com/users/craffel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/craffel/pretty-midi","description":"Utility functions for handling MIDI data in a nice/intuitive way.","fork":false,"url":"https://api.github.com/repos/craffel/pretty-midi","forks_url":"https://api.github.com/repos/craffel/pretty-midi/forks","keys_url":"https://api.github.com/repos/craffel/pretty-midi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/craffel/pretty-midi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/craffel/pretty-midi/teams","hooks_url":"https://api.github.com/repos/craffel/pretty-midi/hooks","issue_events_url":"https://api.github.com/repos/craffel/pretty-midi/issues/events{/number}","events_url":"https://api.github.com/repos/craffel/pretty-midi/events","assignees_url":"https://api.github.com/repos/craffel/pretty-midi/assignees{/user}","branches_url":"https://api.github.com/repos/craffel/pretty-midi/branches{/branch}","tags_url":"https://api.github.com/repos/craffel/pretty-midi/tags","blobs_url":"https://api.github.com/repos/craffel/pretty-midi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/craffel/pretty-midi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/craffel/pretty-midi/git/refs{/sha}","trees_url":"https://api.github.com/repos/craffel/pretty-midi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/craffel/pretty-midi/statuses/{sha}","languages_url":"https://api.github.com/repos/craffel/pretty-midi/languages","stargazers_url":"https://api.github.com/repos/craffel/pretty-midi/stargazers","contributors_url":"https://api.github.com/repos/craffel/pretty-midi/contributors","subscribers_url":"https://api.github.com/repos/craffel/pretty-midi/subscribers","subscription_url":"https://api.github.com/repos/craffel/pretty-midi/subscription","commits_url":"https://api.github.com/repos/craffel/pretty-midi/commits{/sha}","git_commits_url":"https://api.github.com/repos/craffel/pretty-midi/git/commits{/sha}","comments_url":"https://api.github.com/repos/craffel/pretty-midi/comments{/number}","issue_comment_url":"https://api.github.com/repos/craffel/pretty-midi/issues/comments{/number}","contents_url":"https://api.github.com/repos/craffel/pretty-midi/contents/{+path}","compare_url":"https://api.github.com/repos/craffel/pretty-midi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/craffel/pretty-midi/merges","archive_url":"https://api.github.com/repos/craffel/pretty-midi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/craffel/pretty-midi/downloads","issues_url":"https://api.github.com/repos/craffel/pretty-midi/issues{/number}","pulls_url":"https://api.github.com/repos/craffel/pretty-midi/pulls{/number}","milestones_url":"https://api.github.com/repos/craffel/pretty-midi/milestones{/number}","notifications_url":"https://api.github.com/repos/craffel/pretty-midi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/craffel/pretty-midi/labels{/name}","releases_url":"https://api.github.com/repos/craffel/pretty-midi/releases{/id}","deployments_url":"https://api.github.com/repos/craffel/pretty-midi/deployments","created_at":"2013-08-01T15:50:19Z","updated_at":"2017-04-27T05:16:06Z","pushed_at":"2017-05-08T21:23:43Z","git_url":"git://github.com/craffel/pretty-midi.git","ssh_url":"[email protected]:craffel/pretty-midi.git","clone_url":"https://github.com/craffel/pretty-midi.git","svn_url":"https://github.com/craffel/pretty-midi","homepage":null,"size":6920,"stargazers_count":101,"watchers_count":101,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"open_issues_count":16,"forks":21,"open_issues":16,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/craffel/pretty-midi/pulls/129"},"html":{"href":"https://github.com/craffel/pretty-midi/pull/129"},"issue":{"href":"https://api.github.com/repos/craffel/pretty-midi/issues/129"},"comments":{"href":"https://api.github.com/repos/craffel/pretty-midi/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/craffel/pretty-midi/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/craffel/pretty-midi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/craffel/pretty-midi/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/craffel/pretty-midi/statuses/130dc341c7a816d6c18771b9c049ae26e9429ec4"}}}} | {
"id": 11820959,
"name": "craffel/pretty-midi",
"url": "https://api.github.com/repos/craffel/pretty-midi"
} | {
"id": 1595907,
"login": "carlthome",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1595907?",
"url": "https://api.github.com/users/carlthome"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-05-10T15:45:33 | 5846232115 | {"actor":{"display_login":"carlthome"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/JFreegman/toxic/pulls/comments/117554717","pull_request_review_id":39277080,"id":117554717,"diff_hunk":"@@ -104,9 +104,16 @@ static struct user_password {\n int len;\n } user_password;\n \n+static unsigned int last_signal_time;\n+\n static void catch_SIGINT(int sig)\n {\n- Winthread.sig_exit_toxic = 1;\n+ unsigned int cur_time = time(NULL);","path":"src/toxic.c","position":9,"original_position":9,"commit_id":"4908f62426db19ed19db71289a391f87e4be7ccb","original_commit_id":"4908f62426db19ed19db71289a391f87e4be7ccb","user":{"login":"JFreegman","id":1646057,"avatar_url":"https://avatars3.githubusercontent.com/u/1646057?v=3","gravatar_id":"","url":"https://api.github.com/users/JFreegman","html_url":"https://github.com/JFreegman","followers_url":"https://api.github.com/users/JFreegman/followers","following_url":"https://api.github.com/users/JFreegman/following{/other_user}","gists_url":"https://api.github.com/users/JFreegman/gists{/gist_id}","starred_url":"https://api.github.com/users/JFreegman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JFreegman/subscriptions","organizations_url":"https://api.github.com/users/JFreegman/orgs","repos_url":"https://api.github.com/users/JFreegman/repos","events_url":"https://api.github.com/users/JFreegman/events{/privacy}","received_events_url":"https://api.github.com/users/JFreegman/received_events","type":"User","site_admin":false},"body":"You should use the get_unix_time() function here and use time_t variable types.","created_at":"2017-05-19T19:08:26Z","updated_at":"2017-05-19T19:08:26Z","html_url":"https://github.com/JFreegman/toxic/pull/449#discussion_r117554717","pull_request_url":"https://api.github.com/repos/JFreegman/toxic/pulls/449","_links":{"self":{"href":"https://api.github.com/repos/JFreegman/toxic/pulls/comments/117554717"},"html":{"href":"https://github.com/JFreegman/toxic/pull/449#discussion_r117554717"},"pull_request":{"href":"https://api.github.com/repos/JFreegman/toxic/pulls/449"}}},"pull_request":{"url":"https://api.github.com/repos/JFreegman/toxic/pulls/449","id":121559262,"html_url":"https://github.com/JFreegman/toxic/pull/449","diff_url":"https://github.com/JFreegman/toxic/pull/449.diff","patch_url":"https://github.com/JFreegman/toxic/pull/449.patch","issue_url":"https://api.github.com/repos/JFreegman/toxic/issues/449","number":449,"state":"open","locked":false,"title":"double signal handler prevents accidental closes","user":{"login":"Dako300","id":7883002,"avatar_url":"https://avatars0.githubusercontent.com/u/7883002?v=3","gravatar_id":"","url":"https://api.github.com/users/Dako300","html_url":"https://github.com/Dako300","followers_url":"https://api.github.com/users/Dako300/followers","following_url":"https://api.github.com/users/Dako300/following{/other_user}","gists_url":"https://api.github.com/users/Dako300/gists{/gist_id}","starred_url":"https://api.github.com/users/Dako300/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dako300/subscriptions","organizations_url":"https://api.github.com/users/Dako300/orgs","repos_url":"https://api.github.com/users/Dako300/repos","events_url":"https://api.github.com/users/Dako300/events{/privacy}","received_events_url":"https://api.github.com/users/Dako300/received_events","type":"User","site_admin":false},"body":"I keep pressing Ctrl-C by accident and closing Toxic. I made this for myself, and I can't be the only one having this problem.","created_at":"2017-05-19T18:40:45Z","updated_at":"2017-05-19T19:08:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d78db8b1b5eaafe34c88c3179363e8cd93f9ca9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/JFreegman/toxic/pulls/449/commits","review_comments_url":"https://api.github.com/repos/JFreegman/toxic/pulls/449/comments","review_comment_url":"https://api.github.com/repos/JFreegman/toxic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JFreegman/toxic/issues/449/comments","statuses_url":"https://api.github.com/repos/JFreegman/toxic/statuses/4908f62426db19ed19db71289a391f87e4be7ccb","head":{"label":"Dako300:master","ref":"master","sha":"4908f62426db19ed19db71289a391f87e4be7ccb","user":{"login":"Dako300","id":7883002,"avatar_url":"https://avatars0.githubusercontent.com/u/7883002?v=3","gravatar_id":"","url":"https://api.github.com/users/Dako300","html_url":"https://github.com/Dako300","followers_url":"https://api.github.com/users/Dako300/followers","following_url":"https://api.github.com/users/Dako300/following{/other_user}","gists_url":"https://api.github.com/users/Dako300/gists{/gist_id}","starred_url":"https://api.github.com/users/Dako300/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dako300/subscriptions","organizations_url":"https://api.github.com/users/Dako300/orgs","repos_url":"https://api.github.com/users/Dako300/repos","events_url":"https://api.github.com/users/Dako300/events{/privacy}","received_events_url":"https://api.github.com/users/Dako300/received_events","type":"User","site_admin":false},"repo":{"id":91834382,"name":"toxic","full_name":"Dako300/toxic","owner":{"login":"Dako300","id":7883002,"avatar_url":"https://avatars0.githubusercontent.com/u/7883002?v=3","gravatar_id":"","url":"https://api.github.com/users/Dako300","html_url":"https://github.com/Dako300","followers_url":"https://api.github.com/users/Dako300/followers","following_url":"https://api.github.com/users/Dako300/following{/other_user}","gists_url":"https://api.github.com/users/Dako300/gists{/gist_id}","starred_url":"https://api.github.com/users/Dako300/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dako300/subscriptions","organizations_url":"https://api.github.com/users/Dako300/orgs","repos_url":"https://api.github.com/users/Dako300/repos","events_url":"https://api.github.com/users/Dako300/events{/privacy}","received_events_url":"https://api.github.com/users/Dako300/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dako300/toxic","description":"An ncurses-based Tox client","fork":true,"url":"https://api.github.com/repos/Dako300/toxic","forks_url":"https://api.github.com/repos/Dako300/toxic/forks","keys_url":"https://api.github.com/repos/Dako300/toxic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dako300/toxic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dako300/toxic/teams","hooks_url":"https://api.github.com/repos/Dako300/toxic/hooks","issue_events_url":"https://api.github.com/repos/Dako300/toxic/issues/events{/number}","events_url":"https://api.github.com/repos/Dako300/toxic/events","assignees_url":"https://api.github.com/repos/Dako300/toxic/assignees{/user}","branches_url":"https://api.github.com/repos/Dako300/toxic/branches{/branch}","tags_url":"https://api.github.com/repos/Dako300/toxic/tags","blobs_url":"https://api.github.com/repos/Dako300/toxic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dako300/toxic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dako300/toxic/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dako300/toxic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dako300/toxic/statuses/{sha}","languages_url":"https://api.github.com/repos/Dako300/toxic/languages","stargazers_url":"https://api.github.com/repos/Dako300/toxic/stargazers","contributors_url":"https://api.github.com/repos/Dako300/toxic/contributors","subscribers_url":"https://api.github.com/repos/Dako300/toxic/subscribers","subscription_url":"https://api.github.com/repos/Dako300/toxic/subscription","commits_url":"https://api.github.com/repos/Dako300/toxic/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dako300/toxic/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dako300/toxic/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dako300/toxic/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dako300/toxic/contents/{+path}","compare_url":"https://api.github.com/repos/Dako300/toxic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dako300/toxic/merges","archive_url":"https://api.github.com/repos/Dako300/toxic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dako300/toxic/downloads","issues_url":"https://api.github.com/repos/Dako300/toxic/issues{/number}","pulls_url":"https://api.github.com/repos/Dako300/toxic/pulls{/number}","milestones_url":"https://api.github.com/repos/Dako300/toxic/milestones{/number}","notifications_url":"https://api.github.com/repos/Dako300/toxic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dako300/toxic/labels{/name}","releases_url":"https://api.github.com/repos/Dako300/toxic/releases{/id}","deployments_url":"https://api.github.com/repos/Dako300/toxic/deployments","created_at":"2017-05-19T18:27:42Z","updated_at":"2017-05-19T18:27:44Z","pushed_at":"2017-05-19T18:36:53Z","git_url":"git://github.com/Dako300/toxic.git","ssh_url":"[email protected]:Dako300/toxic.git","clone_url":"https://github.com/Dako300/toxic.git","svn_url":"https://github.com/Dako300/toxic","homepage":"","size":15979,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JFreegman:master","ref":"master","sha":"09e26902111851611b99c4951f5379f606045a97","user":{"login":"JFreegman","id":1646057,"avatar_url":"https://avatars3.githubusercontent.com/u/1646057?v=3","gravatar_id":"","url":"https://api.github.com/users/JFreegman","html_url":"https://github.com/JFreegman","followers_url":"https://api.github.com/users/JFreegman/followers","following_url":"https://api.github.com/users/JFreegman/following{/other_user}","gists_url":"https://api.github.com/users/JFreegman/gists{/gist_id}","starred_url":"https://api.github.com/users/JFreegman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JFreegman/subscriptions","organizations_url":"https://api.github.com/users/JFreegman/orgs","repos_url":"https://api.github.com/users/JFreegman/repos","events_url":"https://api.github.com/users/JFreegman/events{/privacy}","received_events_url":"https://api.github.com/users/JFreegman/received_events","type":"User","site_admin":false},"repo":{"id":12306800,"name":"toxic","full_name":"JFreegman/toxic","owner":{"login":"JFreegman","id":1646057,"avatar_url":"https://avatars3.githubusercontent.com/u/1646057?v=3","gravatar_id":"","url":"https://api.github.com/users/JFreegman","html_url":"https://github.com/JFreegman","followers_url":"https://api.github.com/users/JFreegman/followers","following_url":"https://api.github.com/users/JFreegman/following{/other_user}","gists_url":"https://api.github.com/users/JFreegman/gists{/gist_id}","starred_url":"https://api.github.com/users/JFreegman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JFreegman/subscriptions","organizations_url":"https://api.github.com/users/JFreegman/orgs","repos_url":"https://api.github.com/users/JFreegman/repos","events_url":"https://api.github.com/users/JFreegman/events{/privacy}","received_events_url":"https://api.github.com/users/JFreegman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JFreegman/toxic","description":"An ncurses-based Tox client","fork":false,"url":"https://api.github.com/repos/JFreegman/toxic","forks_url":"https://api.github.com/repos/JFreegman/toxic/forks","keys_url":"https://api.github.com/repos/JFreegman/toxic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JFreegman/toxic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JFreegman/toxic/teams","hooks_url":"https://api.github.com/repos/JFreegman/toxic/hooks","issue_events_url":"https://api.github.com/repos/JFreegman/toxic/issues/events{/number}","events_url":"https://api.github.com/repos/JFreegman/toxic/events","assignees_url":"https://api.github.com/repos/JFreegman/toxic/assignees{/user}","branches_url":"https://api.github.com/repos/JFreegman/toxic/branches{/branch}","tags_url":"https://api.github.com/repos/JFreegman/toxic/tags","blobs_url":"https://api.github.com/repos/JFreegman/toxic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JFreegman/toxic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JFreegman/toxic/git/refs{/sha}","trees_url":"https://api.github.com/repos/JFreegman/toxic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JFreegman/toxic/statuses/{sha}","languages_url":"https://api.github.com/repos/JFreegman/toxic/languages","stargazers_url":"https://api.github.com/repos/JFreegman/toxic/stargazers","contributors_url":"https://api.github.com/repos/JFreegman/toxic/contributors","subscribers_url":"https://api.github.com/repos/JFreegman/toxic/subscribers","subscription_url":"https://api.github.com/repos/JFreegman/toxic/subscription","commits_url":"https://api.github.com/repos/JFreegman/toxic/commits{/sha}","git_commits_url":"https://api.github.com/repos/JFreegman/toxic/git/commits{/sha}","comments_url":"https://api.github.com/repos/JFreegman/toxic/comments{/number}","issue_comment_url":"https://api.github.com/repos/JFreegman/toxic/issues/comments{/number}","contents_url":"https://api.github.com/repos/JFreegman/toxic/contents/{+path}","compare_url":"https://api.github.com/repos/JFreegman/toxic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JFreegman/toxic/merges","archive_url":"https://api.github.com/repos/JFreegman/toxic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JFreegman/toxic/downloads","issues_url":"https://api.github.com/repos/JFreegman/toxic/issues{/number}","pulls_url":"https://api.github.com/repos/JFreegman/toxic/pulls{/number}","milestones_url":"https://api.github.com/repos/JFreegman/toxic/milestones{/number}","notifications_url":"https://api.github.com/repos/JFreegman/toxic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JFreegman/toxic/labels{/name}","releases_url":"https://api.github.com/repos/JFreegman/toxic/releases{/id}","deployments_url":"https://api.github.com/repos/JFreegman/toxic/deployments","created_at":"2013-08-22T20:10:19Z","updated_at":"2017-05-17T15:38:34Z","pushed_at":"2017-05-19T18:40:46Z","git_url":"git://github.com/JFreegman/toxic.git","ssh_url":"[email protected]:JFreegman/toxic.git","clone_url":"https://github.com/JFreegman/toxic.git","svn_url":"https://github.com/JFreegman/toxic","homepage":"","size":15979,"stargazers_count":766,"watchers_count":766,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"open_issues_count":39,"forks":112,"open_issues":39,"watchers":766,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JFreegman/toxic/pulls/449"},"html":{"href":"https://github.com/JFreegman/toxic/pull/449"},"issue":{"href":"https://api.github.com/repos/JFreegman/toxic/issues/449"},"comments":{"href":"https://api.github.com/repos/JFreegman/toxic/issues/449/comments"},"review_comments":{"href":"https://api.github.com/repos/JFreegman/toxic/pulls/449/comments"},"review_comment":{"href":"https://api.github.com/repos/JFreegman/toxic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JFreegman/toxic/pulls/449/commits"},"statuses":{"href":"https://api.github.com/repos/JFreegman/toxic/statuses/4908f62426db19ed19db71289a391f87e4be7ccb"}}}} | {
"id": 12306800,
"name": "JFreegman/toxic",
"url": "https://api.github.com/repos/JFreegman/toxic"
} | {
"id": 1646057,
"login": "JFreegman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1646057?",
"url": "https://api.github.com/users/JFreegman"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-05-19T19:08:26 | 5907994855 | {"actor":{"display_login":"JFreegman"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dsenta00/star_lang_src/pulls/comments/143229893","pull_request_review_id":67715988,"id":143229893,"diff_hunk":"@@ -15,9 +15,9 @@ box_data_test_float()\n {\n ASSERT_VIRTUAL_MEMORY(*virtual_memory, 0);\n \n- float fnum = 65.0f;\n+ float64_t fnum = 65.0f;","path":"tests/box_data_test.cpp","position":null,"original_position":5,"commit_id":"0c902399af12d3475780bce1e0b1954d66d6ac61","original_commit_id":"5c0c622fe08b2cc24642a8af3e1e47eb84ef95c9","user":{"login":"TommyRadan","id":8278883,"avatar_url":"https://avatars1.githubusercontent.com/u/8278883?v=4","gravatar_id":"","url":"https://api.github.com/users/TommyRadan","html_url":"https://github.com/TommyRadan","followers_url":"https://api.github.com/users/TommyRadan/followers","following_url":"https://api.github.com/users/TommyRadan/following{/other_user}","gists_url":"https://api.github.com/users/TommyRadan/gists{/gist_id}","starred_url":"https://api.github.com/users/TommyRadan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TommyRadan/subscriptions","organizations_url":"https://api.github.com/users/TommyRadan/orgs","repos_url":"https://api.github.com/users/TommyRadan/repos","events_url":"https://api.github.com/users/TommyRadan/events{/privacy}","received_events_url":"https://api.github.com/users/TommyRadan/received_events","type":"User","site_admin":false},"body":"change 65.0f to 65.0 because literal 65.0f spawns float literal which is then turned to double. That is avoided by omitting \"f\".","created_at":"2017-10-06T16:04:31Z","updated_at":"2017-10-06T16:04:31Z","html_url":"https://github.com/dsenta00/star_lang_src/pull/1#discussion_r143229893","pull_request_url":"https://api.github.com/repos/dsenta00/star_lang_src/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dsenta00/star_lang_src/pulls/comments/143229893"},"html":{"href":"https://github.com/dsenta00/star_lang_src/pull/1#discussion_r143229893"},"pull_request":{"href":"https://api.github.com/repos/dsenta00/star_lang_src/pulls/1"}},"in_reply_to_id":142811037},"pull_request":{"url":"https://api.github.com/repos/dsenta00/star_lang_src/pulls/1","id":144419363,"html_url":"https://github.com/dsenta00/star_lang_src/pull/1","diff_url":"https://github.com/dsenta00/star_lang_src/pull/1.diff","patch_url":"https://github.com/dsenta00/star_lang_src/pull/1.patch","issue_url":"https://api.github.com/repos/dsenta00/star_lang_src/issues/1","number":1,"state":"open","locked":false,"title":"Removed all double, short and long references.","user":{"login":"dsenta00","id":11404561,"avatar_url":"https://avatars1.githubusercontent.com/u/11404561?v=4","gravatar_id":"","url":"https://api.github.com/users/dsenta00","html_url":"https://github.com/dsenta00","followers_url":"https://api.github.com/users/dsenta00/followers","following_url":"https://api.github.com/users/dsenta00/following{/other_user}","gists_url":"https://api.github.com/users/dsenta00/gists{/gist_id}","starred_url":"https://api.github.com/users/dsenta00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsenta00/subscriptions","organizations_url":"https://api.github.com/users/dsenta00/orgs","repos_url":"https://api.github.com/users/dsenta00/repos","events_url":"https://api.github.com/users/dsenta00/events{/privacy}","received_events_url":"https://api.github.com/users/dsenta00/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-03T13:18:00Z","updated_at":"2017-10-06T16:04:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f76c273dc6c67293b87dec5418ca923d1827e652","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dsenta00/star_lang_src/pulls/1/commits","review_comments_url":"https://api.github.com/repos/dsenta00/star_lang_src/pulls/1/comments","review_comment_url":"https://api.github.com/repos/dsenta00/star_lang_src/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dsenta00/star_lang_src/issues/1/comments","statuses_url":"https://api.github.com/repos/dsenta00/star_lang_src/statuses/0c902399af12d3475780bce1e0b1954d66d6ac61","head":{"label":"dsenta00:remove-short-long-double","ref":"remove-short-long-double","sha":"0c902399af12d3475780bce1e0b1954d66d6ac61","user":{"login":"dsenta00","id":11404561,"avatar_url":"https://avatars1.githubusercontent.com/u/11404561?v=4","gravatar_id":"","url":"https://api.github.com/users/dsenta00","html_url":"https://github.com/dsenta00","followers_url":"https://api.github.com/users/dsenta00/followers","following_url":"https://api.github.com/users/dsenta00/following{/other_user}","gists_url":"https://api.github.com/users/dsenta00/gists{/gist_id}","starred_url":"https://api.github.com/users/dsenta00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsenta00/subscriptions","organizations_url":"https://api.github.com/users/dsenta00/orgs","repos_url":"https://api.github.com/users/dsenta00/repos","events_url":"https://api.github.com/users/dsenta00/events{/privacy}","received_events_url":"https://api.github.com/users/dsenta00/received_events","type":"User","site_admin":false},"repo":{"id":90974101,"name":"star_lang_src","full_name":"dsenta00/star_lang_src","owner":{"login":"dsenta00","id":11404561,"avatar_url":"https://avatars1.githubusercontent.com/u/11404561?v=4","gravatar_id":"","url":"https://api.github.com/users/dsenta00","html_url":"https://github.com/dsenta00","followers_url":"https://api.github.com/users/dsenta00/followers","following_url":"https://api.github.com/users/dsenta00/following{/other_user}","gists_url":"https://api.github.com/users/dsenta00/gists{/gist_id}","starred_url":"https://api.github.com/users/dsenta00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsenta00/subscriptions","organizations_url":"https://api.github.com/users/dsenta00/orgs","repos_url":"https://api.github.com/users/dsenta00/repos","events_url":"https://api.github.com/users/dsenta00/events{/privacy}","received_events_url":"https://api.github.com/users/dsenta00/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dsenta00/star_lang_src","description":"The new generation programming language","fork":false,"url":"https://api.github.com/repos/dsenta00/star_lang_src","forks_url":"https://api.github.com/repos/dsenta00/star_lang_src/forks","keys_url":"https://api.github.com/repos/dsenta00/star_lang_src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dsenta00/star_lang_src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dsenta00/star_lang_src/teams","hooks_url":"https://api.github.com/repos/dsenta00/star_lang_src/hooks","issue_events_url":"https://api.github.com/repos/dsenta00/star_lang_src/issues/events{/number}","events_url":"https://api.github.com/repos/dsenta00/star_lang_src/events","assignees_url":"https://api.github.com/repos/dsenta00/star_lang_src/assignees{/user}","branches_url":"https://api.github.com/repos/dsenta00/star_lang_src/branches{/branch}","tags_url":"https://api.github.com/repos/dsenta00/star_lang_src/tags","blobs_url":"https://api.github.com/repos/dsenta00/star_lang_src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dsenta00/star_lang_src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dsenta00/star_lang_src/git/refs{/sha}","trees_url":"https://api.github.com/repos/dsenta00/star_lang_src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dsenta00/star_lang_src/statuses/{sha}","languages_url":"https://api.github.com/repos/dsenta00/star_lang_src/languages","stargazers_url":"https://api.github.com/repos/dsenta00/star_lang_src/stargazers","contributors_url":"https://api.github.com/repos/dsenta00/star_lang_src/contributors","subscribers_url":"https://api.github.com/repos/dsenta00/star_lang_src/subscribers","subscription_url":"https://api.github.com/repos/dsenta00/star_lang_src/subscription","commits_url":"https://api.github.com/repos/dsenta00/star_lang_src/commits{/sha}","git_commits_url":"https://api.github.com/repos/dsenta00/star_lang_src/git/commits{/sha}","comments_url":"https://api.github.com/repos/dsenta00/star_lang_src/comments{/number}","issue_comment_url":"https://api.github.com/repos/dsenta00/star_lang_src/issues/comments{/number}","contents_url":"https://api.github.com/repos/dsenta00/star_lang_src/contents/{+path}","compare_url":"https://api.github.com/repos/dsenta00/star_lang_src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dsenta00/star_lang_src/merges","archive_url":"https://api.github.com/repos/dsenta00/star_lang_src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dsenta00/star_lang_src/downloads","issues_url":"https://api.github.com/repos/dsenta00/star_lang_src/issues{/number}","pulls_url":"https://api.github.com/repos/dsenta00/star_lang_src/pulls{/number}","milestones_url":"https://api.github.com/repos/dsenta00/star_lang_src/milestones{/number}","notifications_url":"https://api.github.com/repos/dsenta00/star_lang_src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dsenta00/star_lang_src/labels{/name}","releases_url":"https://api.github.com/repos/dsenta00/star_lang_src/releases{/id}","deployments_url":"https://api.github.com/repos/dsenta00/star_lang_src/deployments","created_at":"2017-05-11T11:57:53Z","updated_at":"2017-10-05T09:27:29Z","pushed_at":"2017-10-05T09:44:18Z","git_url":"git://github.com/dsenta00/star_lang_src.git","ssh_url":"[email protected]:dsenta00/star_lang_src.git","clone_url":"https://github.com/dsenta00/star_lang_src.git","svn_url":"https://github.com/dsenta00/star_lang_src","homepage":"","size":574,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dsenta00:master","ref":"master","sha":"476e5fc006d2303e496b109305c41a5d1f3ef1d4","user":{"login":"dsenta00","id":11404561,"avatar_url":"https://avatars1.githubusercontent.com/u/11404561?v=4","gravatar_id":"","url":"https://api.github.com/users/dsenta00","html_url":"https://github.com/dsenta00","followers_url":"https://api.github.com/users/dsenta00/followers","following_url":"https://api.github.com/users/dsenta00/following{/other_user}","gists_url":"https://api.github.com/users/dsenta00/gists{/gist_id}","starred_url":"https://api.github.com/users/dsenta00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsenta00/subscriptions","organizations_url":"https://api.github.com/users/dsenta00/orgs","repos_url":"https://api.github.com/users/dsenta00/repos","events_url":"https://api.github.com/users/dsenta00/events{/privacy}","received_events_url":"https://api.github.com/users/dsenta00/received_events","type":"User","site_admin":false},"repo":{"id":90974101,"name":"star_lang_src","full_name":"dsenta00/star_lang_src","owner":{"login":"dsenta00","id":11404561,"avatar_url":"https://avatars1.githubusercontent.com/u/11404561?v=4","gravatar_id":"","url":"https://api.github.com/users/dsenta00","html_url":"https://github.com/dsenta00","followers_url":"https://api.github.com/users/dsenta00/followers","following_url":"https://api.github.com/users/dsenta00/following{/other_user}","gists_url":"https://api.github.com/users/dsenta00/gists{/gist_id}","starred_url":"https://api.github.com/users/dsenta00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsenta00/subscriptions","organizations_url":"https://api.github.com/users/dsenta00/orgs","repos_url":"https://api.github.com/users/dsenta00/repos","events_url":"https://api.github.com/users/dsenta00/events{/privacy}","received_events_url":"https://api.github.com/users/dsenta00/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dsenta00/star_lang_src","description":"The new generation programming language","fork":false,"url":"https://api.github.com/repos/dsenta00/star_lang_src","forks_url":"https://api.github.com/repos/dsenta00/star_lang_src/forks","keys_url":"https://api.github.com/repos/dsenta00/star_lang_src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dsenta00/star_lang_src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dsenta00/star_lang_src/teams","hooks_url":"https://api.github.com/repos/dsenta00/star_lang_src/hooks","issue_events_url":"https://api.github.com/repos/dsenta00/star_lang_src/issues/events{/number}","events_url":"https://api.github.com/repos/dsenta00/star_lang_src/events","assignees_url":"https://api.github.com/repos/dsenta00/star_lang_src/assignees{/user}","branches_url":"https://api.github.com/repos/dsenta00/star_lang_src/branches{/branch}","tags_url":"https://api.github.com/repos/dsenta00/star_lang_src/tags","blobs_url":"https://api.github.com/repos/dsenta00/star_lang_src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dsenta00/star_lang_src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dsenta00/star_lang_src/git/refs{/sha}","trees_url":"https://api.github.com/repos/dsenta00/star_lang_src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dsenta00/star_lang_src/statuses/{sha}","languages_url":"https://api.github.com/repos/dsenta00/star_lang_src/languages","stargazers_url":"https://api.github.com/repos/dsenta00/star_lang_src/stargazers","contributors_url":"https://api.github.com/repos/dsenta00/star_lang_src/contributors","subscribers_url":"https://api.github.com/repos/dsenta00/star_lang_src/subscribers","subscription_url":"https://api.github.com/repos/dsenta00/star_lang_src/subscription","commits_url":"https://api.github.com/repos/dsenta00/star_lang_src/commits{/sha}","git_commits_url":"https://api.github.com/repos/dsenta00/star_lang_src/git/commits{/sha}","comments_url":"https://api.github.com/repos/dsenta00/star_lang_src/comments{/number}","issue_comment_url":"https://api.github.com/repos/dsenta00/star_lang_src/issues/comments{/number}","contents_url":"https://api.github.com/repos/dsenta00/star_lang_src/contents/{+path}","compare_url":"https://api.github.com/repos/dsenta00/star_lang_src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dsenta00/star_lang_src/merges","archive_url":"https://api.github.com/repos/dsenta00/star_lang_src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dsenta00/star_lang_src/downloads","issues_url":"https://api.github.com/repos/dsenta00/star_lang_src/issues{/number}","pulls_url":"https://api.github.com/repos/dsenta00/star_lang_src/pulls{/number}","milestones_url":"https://api.github.com/repos/dsenta00/star_lang_src/milestones{/number}","notifications_url":"https://api.github.com/repos/dsenta00/star_lang_src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dsenta00/star_lang_src/labels{/name}","releases_url":"https://api.github.com/repos/dsenta00/star_lang_src/releases{/id}","deployments_url":"https://api.github.com/repos/dsenta00/star_lang_src/deployments","created_at":"2017-05-11T11:57:53Z","updated_at":"2017-10-05T09:27:29Z","pushed_at":"2017-10-05T09:44:18Z","git_url":"git://github.com/dsenta00/star_lang_src.git","ssh_url":"[email protected]:dsenta00/star_lang_src.git","clone_url":"https://github.com/dsenta00/star_lang_src.git","svn_url":"https://github.com/dsenta00/star_lang_src","homepage":"","size":574,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dsenta00/star_lang_src/pulls/1"},"html":{"href":"https://github.com/dsenta00/star_lang_src/pull/1"},"issue":{"href":"https://api.github.com/repos/dsenta00/star_lang_src/issues/1"},"comments":{"href":"https://api.github.com/repos/dsenta00/star_lang_src/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/dsenta00/star_lang_src/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/dsenta00/star_lang_src/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dsenta00/star_lang_src/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/dsenta00/star_lang_src/statuses/0c902399af12d3475780bce1e0b1954d66d6ac61"}},"author_association":"OWNER"}} | {
"id": 90974101,
"name": "dsenta00/star_lang_src",
"url": "https://api.github.com/repos/dsenta00/star_lang_src"
} | {
"id": 8278883,
"login": "TommyRadan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8278883?",
"url": "https://api.github.com/users/TommyRadan"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-10-06T16:04:31 | 6684041870 | {"actor":{"display_login":"TommyRadan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/pulls/comments/136286543","pull_request_review_id":59801221,"id":136286543,"diff_hunk":"@@ -0,0 +1,54 @@\n+function FormData(){\n+ btn.addEventListener('click',function(){\n+ function User(username,password,date,radio,textarea,select){\n+ this.username = username;\n+ this.password = password;\n+ this.date = date;\n+ this.radio = radio;\n+ this.textarea = textarea;\n+ this.select = select.forEach(element=>{\n+ this[element.name] = element.value;\n+ })\n+ }\n+\n+ const username = document.getElementById('username-id').value;\n+ const password = document.getElementById('password-id').value;\n+ const calendar = document.getElementById('calendar-id').value;\n+ const checkbox = document.querySelectorAll('.input-checkbox');\n+ const textarea = document.querySelectorAll('textarea');\n+ const legend = document.querySelectorAll('legend');\n+ const select = document.querySelectorAll('select');\n+ \n+ const textareaArr = [];","path":"start-from-zero/Javascript/src/api/storeData.js","position":22,"original_position":22,"commit_id":"b337af6ac1a0a18c741fb5c86a4b18453a1bd1fc","original_commit_id":"b337af6ac1a0a18c741fb5c86a4b18453a1bd1fc","user":{"login":"s-timofte","id":4193822,"avatar_url":"https://avatars3.githubusercontent.com/u/4193822?v=4","gravatar_id":"","url":"https://api.github.com/users/s-timofte","html_url":"https://github.com/s-timofte","followers_url":"https://api.github.com/users/s-timofte/followers","following_url":"https://api.github.com/users/s-timofte/following{/other_user}","gists_url":"https://api.github.com/users/s-timofte/gists{/gist_id}","starred_url":"https://api.github.com/users/s-timofte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-timofte/subscriptions","organizations_url":"https://api.github.com/users/s-timofte/orgs","repos_url":"https://api.github.com/users/s-timofte/repos","events_url":"https://api.github.com/users/s-timofte/events{/privacy}","received_events_url":"https://api.github.com/users/s-timofte/received_events","type":"User","site_admin":false},"body":"I would much rather that we don't couple content with the element index; if I add another textarea you will have to change the whole data grabber process; any better way you can think of?","created_at":"2017-08-31T09:23:47Z","updated_at":"2017-08-31T09:23:47Z","html_url":"https://github.com/aircraft721/cluj-pre-js-2017/pull/10#discussion_r136286543","pull_request_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/pulls/10","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/pulls/comments/136286543"},"html":{"href":"https://github.com/aircraft721/cluj-pre-js-2017/pull/10#discussion_r136286543"},"pull_request":{"href":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/pulls/10","id":138516166,"html_url":"https://github.com/aircraft721/cluj-pre-js-2017/pull/10","diff_url":"https://github.com/aircraft721/cluj-pre-js-2017/pull/10.diff","patch_url":"https://github.com/aircraft721/cluj-pre-js-2017/pull/10.patch","issue_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/issues/10","number":10,"state":"open","locked":false,"title":"Dan.constantinescu.day11","user":{"login":"aircraft721","id":20306755,"avatar_url":"https://avatars2.githubusercontent.com/u/20306755?v=4","gravatar_id":"","url":"https://api.github.com/users/aircraft721","html_url":"https://github.com/aircraft721","followers_url":"https://api.github.com/users/aircraft721/followers","following_url":"https://api.github.com/users/aircraft721/following{/other_user}","gists_url":"https://api.github.com/users/aircraft721/gists{/gist_id}","starred_url":"https://api.github.com/users/aircraft721/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aircraft721/subscriptions","organizations_url":"https://api.github.com/users/aircraft721/orgs","repos_url":"https://api.github.com/users/aircraft721/repos","events_url":"https://api.github.com/users/aircraft721/events{/privacy}","received_events_url":"https://api.github.com/users/aircraft721/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-30T20:06:41Z","updated_at":"2017-08-31T09:23:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f32aa7fb651925d69456840059e937651607cea2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/pulls/10/commits","review_comments_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/pulls/10/comments","review_comment_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/issues/10/comments","statuses_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/statuses/b337af6ac1a0a18c741fb5c86a4b18453a1bd1fc","head":{"label":"aircraft721:dan.constantinescu.day11","ref":"dan.constantinescu.day11","sha":"b337af6ac1a0a18c741fb5c86a4b18453a1bd1fc","user":{"login":"aircraft721","id":20306755,"avatar_url":"https://avatars2.githubusercontent.com/u/20306755?v=4","gravatar_id":"","url":"https://api.github.com/users/aircraft721","html_url":"https://github.com/aircraft721","followers_url":"https://api.github.com/users/aircraft721/followers","following_url":"https://api.github.com/users/aircraft721/following{/other_user}","gists_url":"https://api.github.com/users/aircraft721/gists{/gist_id}","starred_url":"https://api.github.com/users/aircraft721/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aircraft721/subscriptions","organizations_url":"https://api.github.com/users/aircraft721/orgs","repos_url":"https://api.github.com/users/aircraft721/repos","events_url":"https://api.github.com/users/aircraft721/events{/privacy}","received_events_url":"https://api.github.com/users/aircraft721/received_events","type":"User","site_admin":false},"repo":{"id":100458071,"name":"cluj-pre-js-2017","full_name":"aircraft721/cluj-pre-js-2017","owner":{"login":"aircraft721","id":20306755,"avatar_url":"https://avatars2.githubusercontent.com/u/20306755?v=4","gravatar_id":"","url":"https://api.github.com/users/aircraft721","html_url":"https://github.com/aircraft721","followers_url":"https://api.github.com/users/aircraft721/followers","following_url":"https://api.github.com/users/aircraft721/following{/other_user}","gists_url":"https://api.github.com/users/aircraft721/gists{/gist_id}","starred_url":"https://api.github.com/users/aircraft721/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aircraft721/subscriptions","organizations_url":"https://api.github.com/users/aircraft721/orgs","repos_url":"https://api.github.com/users/aircraft721/repos","events_url":"https://api.github.com/users/aircraft721/events{/privacy}","received_events_url":"https://api.github.com/users/aircraft721/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aircraft721/cluj-pre-js-2017","description":"Cluj pre-employment Javascript training 2017","fork":true,"url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017","forks_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/forks","keys_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/teams","hooks_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/hooks","issue_events_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/issues/events{/number}","events_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/events","assignees_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/assignees{/user}","branches_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/branches{/branch}","tags_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/tags","blobs_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/git/refs{/sha}","trees_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/statuses/{sha}","languages_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/languages","stargazers_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/stargazers","contributors_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/contributors","subscribers_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/subscribers","subscription_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/subscription","commits_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/commits{/sha}","git_commits_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/git/commits{/sha}","comments_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/comments{/number}","issue_comment_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/issues/comments{/number}","contents_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/contents/{+path}","compare_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/merges","archive_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/downloads","issues_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/issues{/number}","pulls_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/pulls{/number}","milestones_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/milestones{/number}","notifications_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/labels{/name}","releases_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/releases{/id}","deployments_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/deployments","created_at":"2017-08-16T06:56:17Z","updated_at":"2017-08-17T09:44:18Z","pushed_at":"2017-08-30T20:06:41Z","git_url":"git://github.com/aircraft721/cluj-pre-js-2017.git","ssh_url":"[email protected]:aircraft721/cluj-pre-js-2017.git","clone_url":"https://github.com/aircraft721/cluj-pre-js-2017.git","svn_url":"https://github.com/aircraft721/cluj-pre-js-2017","homepage":null,"size":750,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"aircraft721:master","ref":"master","sha":"84d431ea11466eaa1bef291bb89624a000282b29","user":{"login":"aircraft721","id":20306755,"avatar_url":"https://avatars2.githubusercontent.com/u/20306755?v=4","gravatar_id":"","url":"https://api.github.com/users/aircraft721","html_url":"https://github.com/aircraft721","followers_url":"https://api.github.com/users/aircraft721/followers","following_url":"https://api.github.com/users/aircraft721/following{/other_user}","gists_url":"https://api.github.com/users/aircraft721/gists{/gist_id}","starred_url":"https://api.github.com/users/aircraft721/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aircraft721/subscriptions","organizations_url":"https://api.github.com/users/aircraft721/orgs","repos_url":"https://api.github.com/users/aircraft721/repos","events_url":"https://api.github.com/users/aircraft721/events{/privacy}","received_events_url":"https://api.github.com/users/aircraft721/received_events","type":"User","site_admin":false},"repo":{"id":100458071,"name":"cluj-pre-js-2017","full_name":"aircraft721/cluj-pre-js-2017","owner":{"login":"aircraft721","id":20306755,"avatar_url":"https://avatars2.githubusercontent.com/u/20306755?v=4","gravatar_id":"","url":"https://api.github.com/users/aircraft721","html_url":"https://github.com/aircraft721","followers_url":"https://api.github.com/users/aircraft721/followers","following_url":"https://api.github.com/users/aircraft721/following{/other_user}","gists_url":"https://api.github.com/users/aircraft721/gists{/gist_id}","starred_url":"https://api.github.com/users/aircraft721/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aircraft721/subscriptions","organizations_url":"https://api.github.com/users/aircraft721/orgs","repos_url":"https://api.github.com/users/aircraft721/repos","events_url":"https://api.github.com/users/aircraft721/events{/privacy}","received_events_url":"https://api.github.com/users/aircraft721/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aircraft721/cluj-pre-js-2017","description":"Cluj pre-employment Javascript training 2017","fork":true,"url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017","forks_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/forks","keys_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/teams","hooks_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/hooks","issue_events_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/issues/events{/number}","events_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/events","assignees_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/assignees{/user}","branches_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/branches{/branch}","tags_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/tags","blobs_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/git/refs{/sha}","trees_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/statuses/{sha}","languages_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/languages","stargazers_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/stargazers","contributors_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/contributors","subscribers_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/subscribers","subscription_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/subscription","commits_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/commits{/sha}","git_commits_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/git/commits{/sha}","comments_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/comments{/number}","issue_comment_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/issues/comments{/number}","contents_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/contents/{+path}","compare_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/merges","archive_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/downloads","issues_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/issues{/number}","pulls_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/pulls{/number}","milestones_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/milestones{/number}","notifications_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/labels{/name}","releases_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/releases{/id}","deployments_url":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/deployments","created_at":"2017-08-16T06:56:17Z","updated_at":"2017-08-17T09:44:18Z","pushed_at":"2017-08-30T20:06:41Z","git_url":"git://github.com/aircraft721/cluj-pre-js-2017.git","ssh_url":"[email protected]:aircraft721/cluj-pre-js-2017.git","clone_url":"https://github.com/aircraft721/cluj-pre-js-2017.git","svn_url":"https://github.com/aircraft721/cluj-pre-js-2017","homepage":null,"size":750,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/pulls/10"},"html":{"href":"https://github.com/aircraft721/cluj-pre-js-2017/pull/10"},"issue":{"href":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/issues/10"},"comments":{"href":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/aircraft721/cluj-pre-js-2017/statuses/b337af6ac1a0a18c741fb5c86a4b18453a1bd1fc"}},"author_association":"OWNER"}} | {
"id": 100458071,
"name": "aircraft721/cluj-pre-js-2017",
"url": "https://api.github.com/repos/aircraft721/cluj-pre-js-2017"
} | {
"id": 4193822,
"login": "s-timofte",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4193822?",
"url": "https://api.github.com/users/s-timofte"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-08-31T09:23:47 | 6534104362 | {"actor":{"display_login":"s-timofte"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/pulls/comments/152777874","pull_request_review_id":78689923,"id":152777874,"diff_hunk":"@@ -18,9 +19,27 @@\n })\n ->bind('login');\n \n+$app->post('/login', function (Request $request) use ($app) {\n+ $name = $request->get('name');\n+ $password = $request->get('password');\n+ $user = $app['db']->fetchAssoc('SELECT * FROM users WHERE name = ?', [$name]);\n+\n+ if (password_verify($password, $user['password'])) {\n+ if ($app['session']->get('is_logged') != 1) {\n+ $app['session']->set('is_logged', 1);\n+ $app['session']->set('user', ['name' => $name]);\n+ $app['session']->start();","path":"src/controllers.php","position":null,"original_position":34,"commit_id":"10a4b5d0b5d730f186522f7bcb17b5b4644be1ca","original_commit_id":"e9d1709a83ff442d0723f628675fafccec5762ef","user":{"login":"Drunken-Dragon","id":23655532,"avatar_url":"https://avatars3.githubusercontent.com/u/23655532?v=4","gravatar_id":"","url":"https://api.github.com/users/Drunken-Dragon","html_url":"https://github.com/Drunken-Dragon","followers_url":"https://api.github.com/users/Drunken-Dragon/followers","following_url":"https://api.github.com/users/Drunken-Dragon/following{/other_user}","gists_url":"https://api.github.com/users/Drunken-Dragon/gists{/gist_id}","starred_url":"https://api.github.com/users/Drunken-Dragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drunken-Dragon/subscriptions","organizations_url":"https://api.github.com/users/Drunken-Dragon/orgs","repos_url":"https://api.github.com/users/Drunken-Dragon/repos","events_url":"https://api.github.com/users/Drunken-Dragon/events{/privacy}","received_events_url":"https://api.github.com/users/Drunken-Dragon/received_events","type":"User","site_admin":false},"body":"zrobione bis","created_at":"2017-11-23T11:29:51Z","updated_at":"2017-11-23T11:29:52Z","html_url":"https://github.com/Drunken-Dragon/silex-lp/pull/2#discussion_r152777874","pull_request_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/pulls/2","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Drunken-Dragon/silex-lp/pulls/comments/152777874"},"html":{"href":"https://github.com/Drunken-Dragon/silex-lp/pull/2#discussion_r152777874"},"pull_request":{"href":"https://api.github.com/repos/Drunken-Dragon/silex-lp/pulls/2"}},"in_reply_to_id":152738776},"pull_request":{"url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/pulls/2","id":153911436,"html_url":"https://github.com/Drunken-Dragon/silex-lp/pull/2","diff_url":"https://github.com/Drunken-Dragon/silex-lp/pull/2.diff","patch_url":"https://github.com/Drunken-Dragon/silex-lp/pull/2.patch","issue_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/issues/2","number":2,"state":"open","locked":false,"title":"Created a login and session mechanisms. ","user":{"login":"Drunken-Dragon","id":23655532,"avatar_url":"https://avatars3.githubusercontent.com/u/23655532?v=4","gravatar_id":"","url":"https://api.github.com/users/Drunken-Dragon","html_url":"https://github.com/Drunken-Dragon","followers_url":"https://api.github.com/users/Drunken-Dragon/followers","following_url":"https://api.github.com/users/Drunken-Dragon/following{/other_user}","gists_url":"https://api.github.com/users/Drunken-Dragon/gists{/gist_id}","starred_url":"https://api.github.com/users/Drunken-Dragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drunken-Dragon/subscriptions","organizations_url":"https://api.github.com/users/Drunken-Dragon/orgs","repos_url":"https://api.github.com/users/Drunken-Dragon/repos","events_url":"https://api.github.com/users/Drunken-Dragon/events{/privacy}","received_events_url":"https://api.github.com/users/Drunken-Dragon/received_events","type":"User","site_admin":false},"body":"However, problems occur upon a login form submit, after being redirected from the main page.","created_at":"2017-11-21T14:52:56Z","updated_at":"2017-11-23T11:29:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31831613b0f23526d218669962d5ef37f36510f3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/pulls/2/commits","review_comments_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/pulls/2/comments","review_comment_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/issues/2/comments","statuses_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/statuses/10a4b5d0b5d730f186522f7bcb17b5b4644be1ca","head":{"label":"Drunken-Dragon:login-session","ref":"login-session","sha":"10a4b5d0b5d730f186522f7bcb17b5b4644be1ca","user":{"login":"Drunken-Dragon","id":23655532,"avatar_url":"https://avatars3.githubusercontent.com/u/23655532?v=4","gravatar_id":"","url":"https://api.github.com/users/Drunken-Dragon","html_url":"https://github.com/Drunken-Dragon","followers_url":"https://api.github.com/users/Drunken-Dragon/followers","following_url":"https://api.github.com/users/Drunken-Dragon/following{/other_user}","gists_url":"https://api.github.com/users/Drunken-Dragon/gists{/gist_id}","starred_url":"https://api.github.com/users/Drunken-Dragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drunken-Dragon/subscriptions","organizations_url":"https://api.github.com/users/Drunken-Dragon/orgs","repos_url":"https://api.github.com/users/Drunken-Dragon/repos","events_url":"https://api.github.com/users/Drunken-Dragon/events{/privacy}","received_events_url":"https://api.github.com/users/Drunken-Dragon/received_events","type":"User","site_admin":false},"repo":{"id":110536093,"name":"silex-lp","full_name":"Drunken-Dragon/silex-lp","owner":{"login":"Drunken-Dragon","id":23655532,"avatar_url":"https://avatars3.githubusercontent.com/u/23655532?v=4","gravatar_id":"","url":"https://api.github.com/users/Drunken-Dragon","html_url":"https://github.com/Drunken-Dragon","followers_url":"https://api.github.com/users/Drunken-Dragon/followers","following_url":"https://api.github.com/users/Drunken-Dragon/following{/other_user}","gists_url":"https://api.github.com/users/Drunken-Dragon/gists{/gist_id}","starred_url":"https://api.github.com/users/Drunken-Dragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drunken-Dragon/subscriptions","organizations_url":"https://api.github.com/users/Drunken-Dragon/orgs","repos_url":"https://api.github.com/users/Drunken-Dragon/repos","events_url":"https://api.github.com/users/Drunken-Dragon/events{/privacy}","received_events_url":"https://api.github.com/users/Drunken-Dragon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Drunken-Dragon/silex-lp","description":"My previous lp project, rewritten using Silex","fork":false,"url":"https://api.github.com/repos/Drunken-Dragon/silex-lp","forks_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/forks","keys_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/teams","hooks_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/hooks","issue_events_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/issues/events{/number}","events_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/events","assignees_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/assignees{/user}","branches_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/branches{/branch}","tags_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/tags","blobs_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/statuses/{sha}","languages_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/languages","stargazers_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/stargazers","contributors_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/contributors","subscribers_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/subscribers","subscription_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/subscription","commits_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/contents/{+path}","compare_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/merges","archive_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/downloads","issues_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/issues{/number}","pulls_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/pulls{/number}","milestones_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/milestones{/number}","notifications_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/labels{/name}","releases_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/releases{/id}","deployments_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/deployments","created_at":"2017-11-13T10:49:24Z","updated_at":"2017-11-13T22:16:51Z","pushed_at":"2017-11-23T11:28:48Z","git_url":"git://github.com/Drunken-Dragon/silex-lp.git","ssh_url":"[email protected]:Drunken-Dragon/silex-lp.git","clone_url":"https://github.com/Drunken-Dragon/silex-lp.git","svn_url":"https://github.com/Drunken-Dragon/silex-lp","homepage":null,"size":30,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Drunken-Dragon:master","ref":"master","sha":"d6e1b65a341e4433ea63cbcc23065034a007cbd1","user":{"login":"Drunken-Dragon","id":23655532,"avatar_url":"https://avatars3.githubusercontent.com/u/23655532?v=4","gravatar_id":"","url":"https://api.github.com/users/Drunken-Dragon","html_url":"https://github.com/Drunken-Dragon","followers_url":"https://api.github.com/users/Drunken-Dragon/followers","following_url":"https://api.github.com/users/Drunken-Dragon/following{/other_user}","gists_url":"https://api.github.com/users/Drunken-Dragon/gists{/gist_id}","starred_url":"https://api.github.com/users/Drunken-Dragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drunken-Dragon/subscriptions","organizations_url":"https://api.github.com/users/Drunken-Dragon/orgs","repos_url":"https://api.github.com/users/Drunken-Dragon/repos","events_url":"https://api.github.com/users/Drunken-Dragon/events{/privacy}","received_events_url":"https://api.github.com/users/Drunken-Dragon/received_events","type":"User","site_admin":false},"repo":{"id":110536093,"name":"silex-lp","full_name":"Drunken-Dragon/silex-lp","owner":{"login":"Drunken-Dragon","id":23655532,"avatar_url":"https://avatars3.githubusercontent.com/u/23655532?v=4","gravatar_id":"","url":"https://api.github.com/users/Drunken-Dragon","html_url":"https://github.com/Drunken-Dragon","followers_url":"https://api.github.com/users/Drunken-Dragon/followers","following_url":"https://api.github.com/users/Drunken-Dragon/following{/other_user}","gists_url":"https://api.github.com/users/Drunken-Dragon/gists{/gist_id}","starred_url":"https://api.github.com/users/Drunken-Dragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drunken-Dragon/subscriptions","organizations_url":"https://api.github.com/users/Drunken-Dragon/orgs","repos_url":"https://api.github.com/users/Drunken-Dragon/repos","events_url":"https://api.github.com/users/Drunken-Dragon/events{/privacy}","received_events_url":"https://api.github.com/users/Drunken-Dragon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Drunken-Dragon/silex-lp","description":"My previous lp project, rewritten using Silex","fork":false,"url":"https://api.github.com/repos/Drunken-Dragon/silex-lp","forks_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/forks","keys_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/teams","hooks_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/hooks","issue_events_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/issues/events{/number}","events_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/events","assignees_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/assignees{/user}","branches_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/branches{/branch}","tags_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/tags","blobs_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/statuses/{sha}","languages_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/languages","stargazers_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/stargazers","contributors_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/contributors","subscribers_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/subscribers","subscription_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/subscription","commits_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/contents/{+path}","compare_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/merges","archive_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/downloads","issues_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/issues{/number}","pulls_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/pulls{/number}","milestones_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/milestones{/number}","notifications_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/labels{/name}","releases_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/releases{/id}","deployments_url":"https://api.github.com/repos/Drunken-Dragon/silex-lp/deployments","created_at":"2017-11-13T10:49:24Z","updated_at":"2017-11-13T22:16:51Z","pushed_at":"2017-11-23T11:28:48Z","git_url":"git://github.com/Drunken-Dragon/silex-lp.git","ssh_url":"[email protected]:Drunken-Dragon/silex-lp.git","clone_url":"https://github.com/Drunken-Dragon/silex-lp.git","svn_url":"https://github.com/Drunken-Dragon/silex-lp","homepage":null,"size":30,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Drunken-Dragon/silex-lp/pulls/2"},"html":{"href":"https://github.com/Drunken-Dragon/silex-lp/pull/2"},"issue":{"href":"https://api.github.com/repos/Drunken-Dragon/silex-lp/issues/2"},"comments":{"href":"https://api.github.com/repos/Drunken-Dragon/silex-lp/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/Drunken-Dragon/silex-lp/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/Drunken-Dragon/silex-lp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Drunken-Dragon/silex-lp/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/Drunken-Dragon/silex-lp/statuses/10a4b5d0b5d730f186522f7bcb17b5b4644be1ca"}},"author_association":"OWNER"}} | {
"id": 110536093,
"name": "Drunken-Dragon/silex-lp",
"url": "https://api.github.com/repos/Drunken-Dragon/silex-lp"
} | {
"id": 23655532,
"login": "Drunken-Dragon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23655532?",
"url": "https://api.github.com/users/Drunken-Dragon"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-11-23T11:29:51 | 6894830101 | {"actor":{"display_login":"Drunken-Dragon"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/comments/116350995","pull_request_review_id":37972417,"id":116350995,"diff_hunk":"@@ -202,7 +191,11 @@ var ASSIGNMENTS = [\n '<<=',\n '>>=',\n '>>>=',\n- '%=' ];\n+ '%=',\n+];\n+ASSIGNMENTS = ASSIGNMENTS.concat(ASSIGNMENTS.map(function() {\n+ return '=';","path":"test/ufuzz.js","position":52,"original_position":26,"commit_id":"ffd3a9ade1fa8a95f0d3ed126d321a6f1eaca91f","original_commit_id":"ffd3a9ade1fa8a95f0d3ed126d321a6f1eaca91f","user":{"login":"kzc","id":11593452,"avatar_url":"https://avatars0.githubusercontent.com/u/11593452?v=3","gravatar_id":"","url":"https://api.github.com/users/kzc","html_url":"https://github.com/kzc","followers_url":"https://api.github.com/users/kzc/followers","following_url":"https://api.github.com/users/kzc/following{/other_user}","gists_url":"https://api.github.com/users/kzc/gists{/gist_id}","starred_url":"https://api.github.com/users/kzc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzc/subscriptions","organizations_url":"https://api.github.com/users/kzc/orgs","repos_url":"https://api.github.com/users/kzc/repos","events_url":"https://api.github.com/users/kzc/events{/privacy}","received_events_url":"https://api.github.com/users/kzc/received_events","type":"User","site_admin":false},"body":"You're killing me here - this is needlessly complicated.","created_at":"2017-05-13T05:08:30Z","updated_at":"2017-05-13T05:08:30Z","html_url":"https://github.com/mishoo/UglifyJS2/pull/1926#discussion_r116350995","pull_request_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1926","_links":{"self":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/comments/116350995"},"html":{"href":"https://github.com/mishoo/UglifyJS2/pull/1926#discussion_r116350995"},"pull_request":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1926"}}},"pull_request":{"url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1926","id":120254542,"html_url":"https://github.com/mishoo/UglifyJS2/pull/1926","diff_url":"https://github.com/mishoo/UglifyJS2/pull/1926.diff","patch_url":"https://github.com/mishoo/UglifyJS2/pull/1926.patch","issue_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/1926","number":1926,"state":"open","locked":false,"title":"fix `side_effects` on getter/setter","user":{"login":"alexlamsl","id":1898413,"avatar_url":"https://avatars0.githubusercontent.com/u/1898413?v=3","gravatar_id":"","url":"https://api.github.com/users/alexlamsl","html_url":"https://github.com/alexlamsl","followers_url":"https://api.github.com/users/alexlamsl/followers","following_url":"https://api.github.com/users/alexlamsl/following{/other_user}","gists_url":"https://api.github.com/users/alexlamsl/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlamsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlamsl/subscriptions","organizations_url":"https://api.github.com/users/alexlamsl/orgs","repos_url":"https://api.github.com/users/alexlamsl/repos","events_url":"https://api.github.com/users/alexlamsl/events{/privacy}","received_events_url":"https://api.github.com/users/alexlamsl/received_events","type":"User","site_admin":false},"body":"enhance `test/ufuzz.js`\r\n- object getter & setter\r\n- deprecate `-E`, always report runtime errors\r\n\r\nhttps://github.com/mishoo/UglifyJS2/issues/1914#issuecomment-300987221","created_at":"2017-05-12T06:10:37Z","updated_at":"2017-05-13T05:08:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0768be8a271ff1cbbeeb06c9bd8e029d06884518","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1926/commits","review_comments_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1926/comments","review_comment_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/1926/comments","statuses_url":"https://api.github.com/repos/mishoo/UglifyJS2/statuses/ffd3a9ade1fa8a95f0d3ed126d321a6f1eaca91f","head":{"label":"alexlamsl:ufuzz","ref":"ufuzz","sha":"ffd3a9ade1fa8a95f0d3ed126d321a6f1eaca91f","user":{"login":"alexlamsl","id":1898413,"avatar_url":"https://avatars0.githubusercontent.com/u/1898413?v=3","gravatar_id":"","url":"https://api.github.com/users/alexlamsl","html_url":"https://github.com/alexlamsl","followers_url":"https://api.github.com/users/alexlamsl/followers","following_url":"https://api.github.com/users/alexlamsl/following{/other_user}","gists_url":"https://api.github.com/users/alexlamsl/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlamsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlamsl/subscriptions","organizations_url":"https://api.github.com/users/alexlamsl/orgs","repos_url":"https://api.github.com/users/alexlamsl/repos","events_url":"https://api.github.com/users/alexlamsl/events{/privacy}","received_events_url":"https://api.github.com/users/alexlamsl/received_events","type":"User","site_admin":false},"repo":{"id":79024614,"name":"UglifyJS2","full_name":"alexlamsl/UglifyJS2","owner":{"login":"alexlamsl","id":1898413,"avatar_url":"https://avatars0.githubusercontent.com/u/1898413?v=3","gravatar_id":"","url":"https://api.github.com/users/alexlamsl","html_url":"https://github.com/alexlamsl","followers_url":"https://api.github.com/users/alexlamsl/followers","following_url":"https://api.github.com/users/alexlamsl/following{/other_user}","gists_url":"https://api.github.com/users/alexlamsl/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlamsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlamsl/subscriptions","organizations_url":"https://api.github.com/users/alexlamsl/orgs","repos_url":"https://api.github.com/users/alexlamsl/repos","events_url":"https://api.github.com/users/alexlamsl/events{/privacy}","received_events_url":"https://api.github.com/users/alexlamsl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexlamsl/UglifyJS2","description":" JavaScript parser / mangler / compressor / beautifier toolkit","fork":true,"url":"https://api.github.com/repos/alexlamsl/UglifyJS2","forks_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/forks","keys_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/teams","hooks_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/hooks","issue_events_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/issues/events{/number}","events_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/events","assignees_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/assignees{/user}","branches_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/branches{/branch}","tags_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/tags","blobs_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/statuses/{sha}","languages_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/languages","stargazers_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/stargazers","contributors_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/contributors","subscribers_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/subscribers","subscription_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/subscription","commits_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/contents/{+path}","compare_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/merges","archive_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/downloads","issues_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/issues{/number}","pulls_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/pulls{/number}","milestones_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/milestones{/number}","notifications_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/labels{/name}","releases_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/releases{/id}","deployments_url":"https://api.github.com/repos/alexlamsl/UglifyJS2/deployments","created_at":"2017-01-15T10:31:17Z","updated_at":"2017-01-15T10:31:20Z","pushed_at":"2017-05-13T05:05:49Z","git_url":"git://github.com/alexlamsl/UglifyJS2.git","ssh_url":"[email protected]:alexlamsl/UglifyJS2.git","clone_url":"https://github.com/alexlamsl/UglifyJS2.git","svn_url":"https://github.com/alexlamsl/UglifyJS2","homepage":"http://lisperator.net/uglifyjs/","size":3729,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mishoo:master","ref":"master","sha":"c391576d52852322a7fcfbaeabc9d5626e628c8b","user":{"login":"mishoo","id":334725,"avatar_url":"https://avatars1.githubusercontent.com/u/334725?v=3","gravatar_id":"","url":"https://api.github.com/users/mishoo","html_url":"https://github.com/mishoo","followers_url":"https://api.github.com/users/mishoo/followers","following_url":"https://api.github.com/users/mishoo/following{/other_user}","gists_url":"https://api.github.com/users/mishoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mishoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishoo/subscriptions","organizations_url":"https://api.github.com/users/mishoo/orgs","repos_url":"https://api.github.com/users/mishoo/repos","events_url":"https://api.github.com/users/mishoo/events{/privacy}","received_events_url":"https://api.github.com/users/mishoo/received_events","type":"User","site_admin":false},"repo":{"id":5569059,"name":"UglifyJS2","full_name":"mishoo/UglifyJS2","owner":{"login":"mishoo","id":334725,"avatar_url":"https://avatars1.githubusercontent.com/u/334725?v=3","gravatar_id":"","url":"https://api.github.com/users/mishoo","html_url":"https://github.com/mishoo","followers_url":"https://api.github.com/users/mishoo/followers","following_url":"https://api.github.com/users/mishoo/following{/other_user}","gists_url":"https://api.github.com/users/mishoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mishoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishoo/subscriptions","organizations_url":"https://api.github.com/users/mishoo/orgs","repos_url":"https://api.github.com/users/mishoo/repos","events_url":"https://api.github.com/users/mishoo/events{/privacy}","received_events_url":"https://api.github.com/users/mishoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mishoo/UglifyJS2","description":" JavaScript parser / mangler / compressor / beautifier toolkit","fork":false,"url":"https://api.github.com/repos/mishoo/UglifyJS2","forks_url":"https://api.github.com/repos/mishoo/UglifyJS2/forks","keys_url":"https://api.github.com/repos/mishoo/UglifyJS2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mishoo/UglifyJS2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mishoo/UglifyJS2/teams","hooks_url":"https://api.github.com/repos/mishoo/UglifyJS2/hooks","issue_events_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/events{/number}","events_url":"https://api.github.com/repos/mishoo/UglifyJS2/events","assignees_url":"https://api.github.com/repos/mishoo/UglifyJS2/assignees{/user}","branches_url":"https://api.github.com/repos/mishoo/UglifyJS2/branches{/branch}","tags_url":"https://api.github.com/repos/mishoo/UglifyJS2/tags","blobs_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/refs{/sha}","trees_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mishoo/UglifyJS2/statuses/{sha}","languages_url":"https://api.github.com/repos/mishoo/UglifyJS2/languages","stargazers_url":"https://api.github.com/repos/mishoo/UglifyJS2/stargazers","contributors_url":"https://api.github.com/repos/mishoo/UglifyJS2/contributors","subscribers_url":"https://api.github.com/repos/mishoo/UglifyJS2/subscribers","subscription_url":"https://api.github.com/repos/mishoo/UglifyJS2/subscription","commits_url":"https://api.github.com/repos/mishoo/UglifyJS2/commits{/sha}","git_commits_url":"https://api.github.com/repos/mishoo/UglifyJS2/git/commits{/sha}","comments_url":"https://api.github.com/repos/mishoo/UglifyJS2/comments{/number}","issue_comment_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues/comments{/number}","contents_url":"https://api.github.com/repos/mishoo/UglifyJS2/contents/{+path}","compare_url":"https://api.github.com/repos/mishoo/UglifyJS2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mishoo/UglifyJS2/merges","archive_url":"https://api.github.com/repos/mishoo/UglifyJS2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mishoo/UglifyJS2/downloads","issues_url":"https://api.github.com/repos/mishoo/UglifyJS2/issues{/number}","pulls_url":"https://api.github.com/repos/mishoo/UglifyJS2/pulls{/number}","milestones_url":"https://api.github.com/repos/mishoo/UglifyJS2/milestones{/number}","notifications_url":"https://api.github.com/repos/mishoo/UglifyJS2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mishoo/UglifyJS2/labels{/name}","releases_url":"https://api.github.com/repos/mishoo/UglifyJS2/releases{/id}","deployments_url":"https://api.github.com/repos/mishoo/UglifyJS2/deployments","created_at":"2012-08-27T09:31:03Z","updated_at":"2017-05-13T05:00:18Z","pushed_at":"2017-05-13T05:05:50Z","git_url":"git://github.com/mishoo/UglifyJS2.git","ssh_url":"[email protected]:mishoo/UglifyJS2.git","clone_url":"https://github.com/mishoo/UglifyJS2.git","svn_url":"https://github.com/mishoo/UglifyJS2","homepage":"http://lisperator.net/uglifyjs/","size":3837,"stargazers_count":6594,"watchers_count":6594,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":746,"mirror_url":null,"open_issues_count":85,"forks":746,"open_issues":85,"watchers":6594,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1926"},"html":{"href":"https://github.com/mishoo/UglifyJS2/pull/1926"},"issue":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/issues/1926"},"comments":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/issues/1926/comments"},"review_comments":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1926/comments"},"review_comment":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/pulls/1926/commits"},"statuses":{"href":"https://api.github.com/repos/mishoo/UglifyJS2/statuses/ffd3a9ade1fa8a95f0d3ed126d321a6f1eaca91f"}}}} | {
"id": 5569059,
"name": "mishoo/UglifyJS2",
"url": "https://api.github.com/repos/mishoo/UglifyJS2"
} | {
"id": 11593452,
"login": "kzc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11593452?",
"url": "https://api.github.com/users/kzc"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-05-13T05:08:30 | 5865523847 | {"actor":{"display_login":"kzc"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/realvictorprm/visualfsharp/pulls/comments/146858277","pull_request_review_id":71862202,"id":146858277,"diff_hunk":"@@ -350,10 +350,29 @@ type internal FSharpCodeLensService\n let! taggedText, navigation = lens.TaggedText\n let textBox = new TextBlock(Width = 500., Background = Brushes.Transparent, Opacity = 0.0, TextTrimming = TextTrimming.None)\n DependencyObjectExtensions.SetDefaultTextProperties(textBox, formatMap.Value)\n- textBox.Inlines.Add (Documents.Run Settings.CodeLens.Prefix)\n+\n+ let prefix = Documents.Run Settings.CodeLens.Prefix\n+ prefix.Foreground <- SolidColorBrush(Color.FromRgb(153uy, 153uy, 153uy))\n+ textBox.Inlines.Add (prefix)\n+\n for text in taggedText do\n+\n+ let properties = layoutTagToFormatting text.Tag\n+ let properties =\n+ if Settings.CodeLens.UseColors\n+ then\n+ match properties.ForegroundBrush with\n+ | :? SolidColorBrush as b ->\n+ let c = b.Color\n+ // Change to correct gray color\n+ if c.R = c.G && c.R = c.B then properties.SetForeground(Color.FromRgb(153uy, 153uy, 153uy)) else properties","path":"vsintegration/src/FSharp.Editor/CodeLens/LineLens.fs","position":20,"original_position":20,"commit_id":"de4e6bb10e4fa4fd56557850caef8e722e4729b0","original_commit_id":"de4e6bb10e4fa4fd56557850caef8e722e4729b0","user":{"login":"realvictorprm","id":25414896,"avatar_url":"https://avatars1.githubusercontent.com/u/25414896?v=4","gravatar_id":"","url":"https://api.github.com/users/realvictorprm","html_url":"https://github.com/realvictorprm","followers_url":"https://api.github.com/users/realvictorprm/followers","following_url":"https://api.github.com/users/realvictorprm/following{/other_user}","gists_url":"https://api.github.com/users/realvictorprm/gists{/gist_id}","starred_url":"https://api.github.com/users/realvictorprm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realvictorprm/subscriptions","organizations_url":"https://api.github.com/users/realvictorprm/orgs","repos_url":"https://api.github.com/users/realvictorprm/repos","events_url":"https://api.github.com/users/realvictorprm/events{/privacy}","received_events_url":"https://api.github.com/users/realvictorprm/received_events","type":"User","site_admin":false},"body":"We should make this customizable.","created_at":"2017-10-25T13:36:38Z","updated_at":"2017-10-25T13:37:52Z","html_url":"https://github.com/realvictorprm/visualfsharp/pull/16#discussion_r146858277","pull_request_url":"https://api.github.com/repos/realvictorprm/visualfsharp/pulls/16","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/realvictorprm/visualfsharp/pulls/comments/146858277"},"html":{"href":"https://github.com/realvictorprm/visualfsharp/pull/16#discussion_r146858277"},"pull_request":{"href":"https://api.github.com/repos/realvictorprm/visualfsharp/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/realvictorprm/visualfsharp/pulls/16","id":148325075,"html_url":"https://github.com/realvictorprm/visualfsharp/pull/16","diff_url":"https://github.com/realvictorprm/visualfsharp/pull/16.diff","patch_url":"https://github.com/realvictorprm/visualfsharp/pull/16.patch","issue_url":"https://api.github.com/repos/realvictorprm/visualfsharp/issues/16","number":16,"state":"open","locked":false,"title":"Implement color option","user":{"login":"cmeeren","id":7766733,"avatar_url":"https://avatars0.githubusercontent.com/u/7766733?v=4","gravatar_id":"","url":"https://api.github.com/users/cmeeren","html_url":"https://github.com/cmeeren","followers_url":"https://api.github.com/users/cmeeren/followers","following_url":"https://api.github.com/users/cmeeren/following{/other_user}","gists_url":"https://api.github.com/users/cmeeren/gists{/gist_id}","starred_url":"https://api.github.com/users/cmeeren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmeeren/subscriptions","organizations_url":"https://api.github.com/users/cmeeren/orgs","repos_url":"https://api.github.com/users/cmeeren/repos","events_url":"https://api.github.com/users/cmeeren/events{/privacy}","received_events_url":"https://api.github.com/users/cmeeren/received_events","type":"User","site_admin":false},"body":"Use of colors should be optional, and grey should be the default, as mentioned in https://github.com/Microsoft/visualfsharp/pull/3608#issuecomment-331988205.\r\n\r\nProgress:\r\n\r\n- [x] Implement color option\r\n- [x] Change default color to what VS uses for its normal CodeLens (#999999 / 153, 153, 153)\r\n- [x] Make sure the hyperlinks also follow the color above.","created_at":"2017-10-24T08:11:20Z","updated_at":"2017-10-25T13:37:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4463756d00e5a1990c133222ea140338273181d9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/realvictorprm/visualfsharp/pulls/16/commits","review_comments_url":"https://api.github.com/repos/realvictorprm/visualfsharp/pulls/16/comments","review_comment_url":"https://api.github.com/repos/realvictorprm/visualfsharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/realvictorprm/visualfsharp/issues/16/comments","statuses_url":"https://api.github.com/repos/realvictorprm/visualfsharp/statuses/de4e6bb10e4fa4fd56557850caef8e722e4729b0","head":{"label":"cmeeren:codelens-coloroption","ref":"codelens-coloroption","sha":"de4e6bb10e4fa4fd56557850caef8e722e4729b0","user":{"login":"cmeeren","id":7766733,"avatar_url":"https://avatars0.githubusercontent.com/u/7766733?v=4","gravatar_id":"","url":"https://api.github.com/users/cmeeren","html_url":"https://github.com/cmeeren","followers_url":"https://api.github.com/users/cmeeren/followers","following_url":"https://api.github.com/users/cmeeren/following{/other_user}","gists_url":"https://api.github.com/users/cmeeren/gists{/gist_id}","starred_url":"https://api.github.com/users/cmeeren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmeeren/subscriptions","organizations_url":"https://api.github.com/users/cmeeren/orgs","repos_url":"https://api.github.com/users/cmeeren/repos","events_url":"https://api.github.com/users/cmeeren/events{/privacy}","received_events_url":"https://api.github.com/users/cmeeren/received_events","type":"User","site_admin":false},"repo":{"id":108083148,"name":"visualfsharp","full_name":"cmeeren/visualfsharp","owner":{"login":"cmeeren","id":7766733,"avatar_url":"https://avatars0.githubusercontent.com/u/7766733?v=4","gravatar_id":"","url":"https://api.github.com/users/cmeeren","html_url":"https://github.com/cmeeren","followers_url":"https://api.github.com/users/cmeeren/followers","following_url":"https://api.github.com/users/cmeeren/following{/other_user}","gists_url":"https://api.github.com/users/cmeeren/gists{/gist_id}","starred_url":"https://api.github.com/users/cmeeren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmeeren/subscriptions","organizations_url":"https://api.github.com/users/cmeeren/orgs","repos_url":"https://api.github.com/users/cmeeren/repos","events_url":"https://api.github.com/users/cmeeren/events{/privacy}","received_events_url":"https://api.github.com/users/cmeeren/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmeeren/visualfsharp","description":"The Visual F# compiler and tools","fork":true,"url":"https://api.github.com/repos/cmeeren/visualfsharp","forks_url":"https://api.github.com/repos/cmeeren/visualfsharp/forks","keys_url":"https://api.github.com/repos/cmeeren/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmeeren/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmeeren/visualfsharp/teams","hooks_url":"https://api.github.com/repos/cmeeren/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/cmeeren/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/cmeeren/visualfsharp/events","assignees_url":"https://api.github.com/repos/cmeeren/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/cmeeren/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/cmeeren/visualfsharp/tags","blobs_url":"https://api.github.com/repos/cmeeren/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmeeren/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmeeren/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmeeren/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmeeren/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/cmeeren/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/cmeeren/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/cmeeren/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/cmeeren/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/cmeeren/visualfsharp/subscription","commits_url":"https://api.github.com/repos/cmeeren/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmeeren/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmeeren/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmeeren/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmeeren/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/cmeeren/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmeeren/visualfsharp/merges","archive_url":"https://api.github.com/repos/cmeeren/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmeeren/visualfsharp/downloads","issues_url":"https://api.github.com/repos/cmeeren/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/cmeeren/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/cmeeren/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/cmeeren/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmeeren/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/cmeeren/visualfsharp/releases{/id}","deployments_url":"https://api.github.com/repos/cmeeren/visualfsharp/deployments","created_at":"2017-10-24T05:56:10Z","updated_at":"2017-10-24T05:56:25Z","pushed_at":"2017-10-25T07:28:56Z","git_url":"git://github.com/cmeeren/visualfsharp.git","ssh_url":"[email protected]:cmeeren/visualfsharp.git","clone_url":"https://github.com/cmeeren/visualfsharp.git","svn_url":"https://github.com/cmeeren/visualfsharp","homepage":null,"size":100931,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"realvictorprm:codelens","ref":"codelens","sha":"9b97e2425c6e8130644f250348679c2235548368","user":{"login":"realvictorprm","id":25414896,"avatar_url":"https://avatars1.githubusercontent.com/u/25414896?v=4","gravatar_id":"","url":"https://api.github.com/users/realvictorprm","html_url":"https://github.com/realvictorprm","followers_url":"https://api.github.com/users/realvictorprm/followers","following_url":"https://api.github.com/users/realvictorprm/following{/other_user}","gists_url":"https://api.github.com/users/realvictorprm/gists{/gist_id}","starred_url":"https://api.github.com/users/realvictorprm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realvictorprm/subscriptions","organizations_url":"https://api.github.com/users/realvictorprm/orgs","repos_url":"https://api.github.com/users/realvictorprm/repos","events_url":"https://api.github.com/users/realvictorprm/events{/privacy}","received_events_url":"https://api.github.com/users/realvictorprm/received_events","type":"User","site_admin":false},"repo":{"id":89282909,"name":"visualfsharp","full_name":"realvictorprm/visualfsharp","owner":{"login":"realvictorprm","id":25414896,"avatar_url":"https://avatars1.githubusercontent.com/u/25414896?v=4","gravatar_id":"","url":"https://api.github.com/users/realvictorprm","html_url":"https://github.com/realvictorprm","followers_url":"https://api.github.com/users/realvictorprm/followers","following_url":"https://api.github.com/users/realvictorprm/following{/other_user}","gists_url":"https://api.github.com/users/realvictorprm/gists{/gist_id}","starred_url":"https://api.github.com/users/realvictorprm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realvictorprm/subscriptions","organizations_url":"https://api.github.com/users/realvictorprm/orgs","repos_url":"https://api.github.com/users/realvictorprm/repos","events_url":"https://api.github.com/users/realvictorprm/events{/privacy}","received_events_url":"https://api.github.com/users/realvictorprm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/realvictorprm/visualfsharp","description":"The Visual F# compiler and tools","fork":true,"url":"https://api.github.com/repos/realvictorprm/visualfsharp","forks_url":"https://api.github.com/repos/realvictorprm/visualfsharp/forks","keys_url":"https://api.github.com/repos/realvictorprm/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realvictorprm/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realvictorprm/visualfsharp/teams","hooks_url":"https://api.github.com/repos/realvictorprm/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/realvictorprm/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/realvictorprm/visualfsharp/events","assignees_url":"https://api.github.com/repos/realvictorprm/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/realvictorprm/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/realvictorprm/visualfsharp/tags","blobs_url":"https://api.github.com/repos/realvictorprm/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realvictorprm/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realvictorprm/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/realvictorprm/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realvictorprm/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/realvictorprm/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/realvictorprm/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/realvictorprm/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/realvictorprm/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/realvictorprm/visualfsharp/subscription","commits_url":"https://api.github.com/repos/realvictorprm/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/realvictorprm/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/realvictorprm/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/realvictorprm/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/realvictorprm/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/realvictorprm/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realvictorprm/visualfsharp/merges","archive_url":"https://api.github.com/repos/realvictorprm/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realvictorprm/visualfsharp/downloads","issues_url":"https://api.github.com/repos/realvictorprm/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/realvictorprm/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/realvictorprm/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/realvictorprm/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realvictorprm/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/realvictorprm/visualfsharp/releases{/id}","deployments_url":"https://api.github.com/repos/realvictorprm/visualfsharp/deployments","created_at":"2017-04-24T20:13:08Z","updated_at":"2017-04-24T20:13:19Z","pushed_at":"2017-10-24T11:50:40Z","git_url":"git://github.com/realvictorprm/visualfsharp.git","ssh_url":"[email protected]:realvictorprm/visualfsharp.git","clone_url":"https://github.com/realvictorprm/visualfsharp.git","svn_url":"https://github.com/realvictorprm/visualfsharp","homepage":null,"size":100902,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/realvictorprm/visualfsharp/pulls/16"},"html":{"href":"https://github.com/realvictorprm/visualfsharp/pull/16"},"issue":{"href":"https://api.github.com/repos/realvictorprm/visualfsharp/issues/16"},"comments":{"href":"https://api.github.com/repos/realvictorprm/visualfsharp/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/realvictorprm/visualfsharp/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/realvictorprm/visualfsharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/realvictorprm/visualfsharp/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/realvictorprm/visualfsharp/statuses/de4e6bb10e4fa4fd56557850caef8e722e4729b0"}},"author_association":"NONE"}} | {
"id": 89282909,
"name": "realvictorprm/visualfsharp",
"url": "https://api.github.com/repos/realvictorprm/visualfsharp"
} | {
"id": 25414896,
"login": "realvictorprm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25414896?",
"url": "https://api.github.com/users/realvictorprm"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-10-25T13:36:38 | 6764023648 | {"actor":{"display_login":"realvictorprm"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/danliris/dl-ui/pulls/comments/100747934","pull_request_review_id":21461169,"id":100747934,"diff_hunk":"@@ -19,6 +19,12 @@ export class List {\n var result = await this.service.search(this.info);\n this.data = result.data;\n this.info = result.info;\n+ this.data.forEach((product) => {\n+ product.price = parseFloat(product.price).toLocaleString(undefined, {","path":"src/modules/master/product/list.js","position":5,"original_position":5,"commit_id":"4e3ee994c67b5b329e3e6deb898fbaf78775e5b6","original_commit_id":"4e3ee994c67b5b329e3e6deb898fbaf78775e5b6","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Class properties must be methods. Expected '(' but instead saw '.'.<br>Expected ')' to match '(' from line 23 and instead saw '.'.<br>'function closure expressions' is only available in Mozilla JavaScript extensions (use moz option).<br>Unexpected ')'.<br>Unexpected '.'.<br>'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).","created_at":"2017-02-13T09:00:25Z","updated_at":"2017-02-13T09:00:26Z","html_url":"https://github.com/danliris/dl-ui/pull/257#discussion_r100747934","pull_request_url":"https://api.github.com/repos/danliris/dl-ui/pulls/257","_links":{"self":{"href":"https://api.github.com/repos/danliris/dl-ui/pulls/comments/100747934"},"html":{"href":"https://github.com/danliris/dl-ui/pull/257#discussion_r100747934"},"pull_request":{"href":"https://api.github.com/repos/danliris/dl-ui/pulls/257"}}},"pull_request":{"url":"https://api.github.com/repos/danliris/dl-ui/pulls/257","id":105851770,"html_url":"https://github.com/danliris/dl-ui/pull/257","diff_url":"https://github.com/danliris/dl-ui/pull/257.diff","patch_url":"https://github.com/danliris/dl-ui/pull/257.patch","issue_url":"https://api.github.com/repos/danliris/dl-ui/issues/257","number":257,"state":"open","locked":false,"title":"add menu product","user":{"login":"indriHutabalian","id":20896254,"avatar_url":"https://avatars.githubusercontent.com/u/20896254?v=3","gravatar_id":"","url":"https://api.github.com/users/indriHutabalian","html_url":"https://github.com/indriHutabalian","followers_url":"https://api.github.com/users/indriHutabalian/followers","following_url":"https://api.github.com/users/indriHutabalian/following{/other_user}","gists_url":"https://api.github.com/users/indriHutabalian/gists{/gist_id}","starred_url":"https://api.github.com/users/indriHutabalian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indriHutabalian/subscriptions","organizations_url":"https://api.github.com/users/indriHutabalian/orgs","repos_url":"https://api.github.com/users/indriHutabalian/repos","events_url":"https://api.github.com/users/indriHutabalian/events{/privacy}","received_events_url":"https://api.github.com/users/indriHutabalian/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-13T09:00:14Z","updated_at":"2017-02-13T09:00:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93851687a144c17f9053f57db204409e702f2608","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/danliris/dl-ui/pulls/257/commits","review_comments_url":"https://api.github.com/repos/danliris/dl-ui/pulls/257/comments","review_comment_url":"https://api.github.com/repos/danliris/dl-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danliris/dl-ui/issues/257/comments","statuses_url":"https://api.github.com/repos/danliris/dl-ui/statuses/4e3ee994c67b5b329e3e6deb898fbaf78775e5b6","head":{"label":"indriHutabalian:dev","ref":"dev","sha":"4e3ee994c67b5b329e3e6deb898fbaf78775e5b6","user":{"login":"indriHutabalian","id":20896254,"avatar_url":"https://avatars.githubusercontent.com/u/20896254?v=3","gravatar_id":"","url":"https://api.github.com/users/indriHutabalian","html_url":"https://github.com/indriHutabalian","followers_url":"https://api.github.com/users/indriHutabalian/followers","following_url":"https://api.github.com/users/indriHutabalian/following{/other_user}","gists_url":"https://api.github.com/users/indriHutabalian/gists{/gist_id}","starred_url":"https://api.github.com/users/indriHutabalian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indriHutabalian/subscriptions","organizations_url":"https://api.github.com/users/indriHutabalian/orgs","repos_url":"https://api.github.com/users/indriHutabalian/repos","events_url":"https://api.github.com/users/indriHutabalian/events{/privacy}","received_events_url":"https://api.github.com/users/indriHutabalian/received_events","type":"User","site_admin":false},"repo":{"id":71859963,"name":"dl-ui","full_name":"indriHutabalian/dl-ui","owner":{"login":"indriHutabalian","id":20896254,"avatar_url":"https://avatars.githubusercontent.com/u/20896254?v=3","gravatar_id":"","url":"https://api.github.com/users/indriHutabalian","html_url":"https://github.com/indriHutabalian","followers_url":"https://api.github.com/users/indriHutabalian/followers","following_url":"https://api.github.com/users/indriHutabalian/following{/other_user}","gists_url":"https://api.github.com/users/indriHutabalian/gists{/gist_id}","starred_url":"https://api.github.com/users/indriHutabalian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indriHutabalian/subscriptions","organizations_url":"https://api.github.com/users/indriHutabalian/orgs","repos_url":"https://api.github.com/users/indriHutabalian/repos","events_url":"https://api.github.com/users/indriHutabalian/events{/privacy}","received_events_url":"https://api.github.com/users/indriHutabalian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/indriHutabalian/dl-ui","description":"Dan Liris ui with Aurelia","fork":true,"url":"https://api.github.com/repos/indriHutabalian/dl-ui","forks_url":"https://api.github.com/repos/indriHutabalian/dl-ui/forks","keys_url":"https://api.github.com/repos/indriHutabalian/dl-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indriHutabalian/dl-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indriHutabalian/dl-ui/teams","hooks_url":"https://api.github.com/repos/indriHutabalian/dl-ui/hooks","issue_events_url":"https://api.github.com/repos/indriHutabalian/dl-ui/issues/events{/number}","events_url":"https://api.github.com/repos/indriHutabalian/dl-ui/events","assignees_url":"https://api.github.com/repos/indriHutabalian/dl-ui/assignees{/user}","branches_url":"https://api.github.com/repos/indriHutabalian/dl-ui/branches{/branch}","tags_url":"https://api.github.com/repos/indriHutabalian/dl-ui/tags","blobs_url":"https://api.github.com/repos/indriHutabalian/dl-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indriHutabalian/dl-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indriHutabalian/dl-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/indriHutabalian/dl-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indriHutabalian/dl-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/indriHutabalian/dl-ui/languages","stargazers_url":"https://api.github.com/repos/indriHutabalian/dl-ui/stargazers","contributors_url":"https://api.github.com/repos/indriHutabalian/dl-ui/contributors","subscribers_url":"https://api.github.com/repos/indriHutabalian/dl-ui/subscribers","subscription_url":"https://api.github.com/repos/indriHutabalian/dl-ui/subscription","commits_url":"https://api.github.com/repos/indriHutabalian/dl-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/indriHutabalian/dl-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/indriHutabalian/dl-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/indriHutabalian/dl-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/indriHutabalian/dl-ui/contents/{+path}","compare_url":"https://api.github.com/repos/indriHutabalian/dl-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indriHutabalian/dl-ui/merges","archive_url":"https://api.github.com/repos/indriHutabalian/dl-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indriHutabalian/dl-ui/downloads","issues_url":"https://api.github.com/repos/indriHutabalian/dl-ui/issues{/number}","pulls_url":"https://api.github.com/repos/indriHutabalian/dl-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/indriHutabalian/dl-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/indriHutabalian/dl-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indriHutabalian/dl-ui/labels{/name}","releases_url":"https://api.github.com/repos/indriHutabalian/dl-ui/releases{/id}","deployments_url":"https://api.github.com/repos/indriHutabalian/dl-ui/deployments","created_at":"2016-10-25T04:38:17Z","updated_at":"2016-10-25T04:38:19Z","pushed_at":"2017-02-13T08:43:30Z","git_url":"git://github.com/indriHutabalian/dl-ui.git","ssh_url":"[email protected]:indriHutabalian/dl-ui.git","clone_url":"https://github.com/indriHutabalian/dl-ui.git","svn_url":"https://github.com/indriHutabalian/dl-ui","homepage":null,"size":2382,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"danliris:dev","ref":"dev","sha":"397333956a36e0e45ac3026d89594c7f990a6965","user":{"login":"danliris","id":20855729,"avatar_url":"https://avatars.githubusercontent.com/u/20855729?v=3","gravatar_id":"","url":"https://api.github.com/users/danliris","html_url":"https://github.com/danliris","followers_url":"https://api.github.com/users/danliris/followers","following_url":"https://api.github.com/users/danliris/following{/other_user}","gists_url":"https://api.github.com/users/danliris/gists{/gist_id}","starred_url":"https://api.github.com/users/danliris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danliris/subscriptions","organizations_url":"https://api.github.com/users/danliris/orgs","repos_url":"https://api.github.com/users/danliris/repos","events_url":"https://api.github.com/users/danliris/events{/privacy}","received_events_url":"https://api.github.com/users/danliris/received_events","type":"User","site_admin":false},"repo":{"id":64897822,"name":"dl-ui","full_name":"danliris/dl-ui","owner":{"login":"danliris","id":20855729,"avatar_url":"https://avatars.githubusercontent.com/u/20855729?v=3","gravatar_id":"","url":"https://api.github.com/users/danliris","html_url":"https://github.com/danliris","followers_url":"https://api.github.com/users/danliris/followers","following_url":"https://api.github.com/users/danliris/following{/other_user}","gists_url":"https://api.github.com/users/danliris/gists{/gist_id}","starred_url":"https://api.github.com/users/danliris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danliris/subscriptions","organizations_url":"https://api.github.com/users/danliris/orgs","repos_url":"https://api.github.com/users/danliris/repos","events_url":"https://api.github.com/users/danliris/events{/privacy}","received_events_url":"https://api.github.com/users/danliris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danliris/dl-ui","description":"Dan Liris ui with Aurelia","fork":false,"url":"https://api.github.com/repos/danliris/dl-ui","forks_url":"https://api.github.com/repos/danliris/dl-ui/forks","keys_url":"https://api.github.com/repos/danliris/dl-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danliris/dl-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danliris/dl-ui/teams","hooks_url":"https://api.github.com/repos/danliris/dl-ui/hooks","issue_events_url":"https://api.github.com/repos/danliris/dl-ui/issues/events{/number}","events_url":"https://api.github.com/repos/danliris/dl-ui/events","assignees_url":"https://api.github.com/repos/danliris/dl-ui/assignees{/user}","branches_url":"https://api.github.com/repos/danliris/dl-ui/branches{/branch}","tags_url":"https://api.github.com/repos/danliris/dl-ui/tags","blobs_url":"https://api.github.com/repos/danliris/dl-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danliris/dl-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danliris/dl-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/danliris/dl-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danliris/dl-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/danliris/dl-ui/languages","stargazers_url":"https://api.github.com/repos/danliris/dl-ui/stargazers","contributors_url":"https://api.github.com/repos/danliris/dl-ui/contributors","subscribers_url":"https://api.github.com/repos/danliris/dl-ui/subscribers","subscription_url":"https://api.github.com/repos/danliris/dl-ui/subscription","commits_url":"https://api.github.com/repos/danliris/dl-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/danliris/dl-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/danliris/dl-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/danliris/dl-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/danliris/dl-ui/contents/{+path}","compare_url":"https://api.github.com/repos/danliris/dl-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danliris/dl-ui/merges","archive_url":"https://api.github.com/repos/danliris/dl-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danliris/dl-ui/downloads","issues_url":"https://api.github.com/repos/danliris/dl-ui/issues{/number}","pulls_url":"https://api.github.com/repos/danliris/dl-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/danliris/dl-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/danliris/dl-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danliris/dl-ui/labels{/name}","releases_url":"https://api.github.com/repos/danliris/dl-ui/releases{/id}","deployments_url":"https://api.github.com/repos/danliris/dl-ui/deployments","created_at":"2016-08-04T03:06:28Z","updated_at":"2016-09-22T05:03:51Z","pushed_at":"2017-02-13T09:00:15Z","git_url":"git://github.com/danliris/dl-ui.git","ssh_url":"[email protected]:danliris/dl-ui.git","clone_url":"https://github.com/danliris/dl-ui.git","svn_url":"https://github.com/danliris/dl-ui","homepage":null,"size":2405,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":15,"forks":14,"open_issues":15,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danliris/dl-ui/pulls/257"},"html":{"href":"https://github.com/danliris/dl-ui/pull/257"},"issue":{"href":"https://api.github.com/repos/danliris/dl-ui/issues/257"},"comments":{"href":"https://api.github.com/repos/danliris/dl-ui/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/danliris/dl-ui/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/danliris/dl-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danliris/dl-ui/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/danliris/dl-ui/statuses/4e3ee994c67b5b329e3e6deb898fbaf78775e5b6"}}}} | {
"id": 64897822,
"name": "danliris/dl-ui",
"url": "https://api.github.com/repos/danliris/dl-ui"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-02-13T09:00:25 | 5312422532 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/pulls/comments/150401361","pull_request_review_id":75950339,"id":150401361,"diff_hunk":"@@ -9,13 +11,28 @@ import Group from './Group';\n * \n * @returns {JSX} list of groups a user belongs\n */\n+class GroupList extends React.Component {\n+ constructor(props) {\n+ super(props);\n+ this.state = {\n+ showCreateGroup: false,\n+ }\n+ this.closeGroup = this.closeGroup.bind(this);\n+ this.openGroup = this.openGroup.bind(this);\n+ }\n \n-const GroupList = () => {\n+ closeGroup() {\n+ this.setState({ showCreateGroup: false });\n+ }\n+ openGroup() {\n+ this.setState({ showCreateGroup: true });\n+ }\n+ render() {\n let header = null;\n if (PostItStore.getGroupsUser().length < 1) {\n- header = (<h4> No Group yet </h4>);\n+ header = (<div> <h4 className='card-header'> No Group yet </h4> </div>);","path":"client/components/protected/GroupList.jsx","position":34,"original_position":34,"commit_id":"6b41f28323a71c787568ab9233954b251b071646","original_commit_id":"6b41f28323a71c787568ab9233954b251b071646","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Parsing error: Unexpected token <","created_at":"2017-11-12T06:15:53Z","updated_at":"2017-11-12T06:15:54Z","html_url":"https://github.com/sasili-adetunji/post-it-app-2/pull/35#discussion_r150401361","pull_request_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/pulls/35","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/pulls/comments/150401361"},"html":{"href":"https://github.com/sasili-adetunji/post-it-app-2/pull/35#discussion_r150401361"},"pull_request":{"href":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/pulls/35","id":152090817,"html_url":"https://github.com/sasili-adetunji/post-it-app-2/pull/35","diff_url":"https://github.com/sasili-adetunji/post-it-app-2/pull/35.diff","patch_url":"https://github.com/sasili-adetunji/post-it-app-2/pull/35.patch","issue_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/issues/35","number":35,"state":"closed","locked":false,"title":"feature(UI-Redesign)","user":{"login":"sasili-adetunji","id":28709038,"avatar_url":"https://avatars3.githubusercontent.com/u/28709038?v=4","gravatar_id":"","url":"https://api.github.com/users/sasili-adetunji","html_url":"https://github.com/sasili-adetunji","followers_url":"https://api.github.com/users/sasili-adetunji/followers","following_url":"https://api.github.com/users/sasili-adetunji/following{/other_user}","gists_url":"https://api.github.com/users/sasili-adetunji/gists{/gist_id}","starred_url":"https://api.github.com/users/sasili-adetunji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sasili-adetunji/subscriptions","organizations_url":"https://api.github.com/users/sasili-adetunji/orgs","repos_url":"https://api.github.com/users/sasili-adetunji/repos","events_url":"https://api.github.com/users/sasili-adetunji/events{/privacy}","received_events_url":"https://api.github.com/users/sasili-adetunji/received_events","type":"User","site_admin":false},"body":"The description should contain the following headings and the related content:\r\n\r\n#### What does this PR do?\r\nIts refactors the UI of the app\r\n\r\n#### Description of Task to be completed?\r\n- Redesign the UI of the app\r\n- Adds forgot password page\r\n\r\n#### How should this be manually tested?\r\n- Navigate to the app and explore it\r\n\r\n#### Any background context you want to provide?\r\n- The UI of the app needs to well styled and easily navigated through to improve user's experience\r\n\r\n#### Screenshots\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2017-11-12T06:15:38Z","updated_at":"2017-11-12T06:15:55Z","closed_at":"2017-11-12T06:15:54Z","merged_at":"2017-11-12T06:15:54Z","merge_commit_sha":"03057ee03001cc1d21f9ed5d6f4e0f9333a19e74","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/pulls/35/commits","review_comments_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/pulls/35/comments","review_comment_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/issues/35/comments","statuses_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/statuses/6b41f28323a71c787568ab9233954b251b071646","head":{"label":"sasili-adetunji:feature/UI-refactor","ref":"feature/UI-refactor","sha":"6b41f28323a71c787568ab9233954b251b071646","user":{"login":"sasili-adetunji","id":28709038,"avatar_url":"https://avatars3.githubusercontent.com/u/28709038?v=4","gravatar_id":"","url":"https://api.github.com/users/sasili-adetunji","html_url":"https://github.com/sasili-adetunji","followers_url":"https://api.github.com/users/sasili-adetunji/followers","following_url":"https://api.github.com/users/sasili-adetunji/following{/other_user}","gists_url":"https://api.github.com/users/sasili-adetunji/gists{/gist_id}","starred_url":"https://api.github.com/users/sasili-adetunji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sasili-adetunji/subscriptions","organizations_url":"https://api.github.com/users/sasili-adetunji/orgs","repos_url":"https://api.github.com/users/sasili-adetunji/repos","events_url":"https://api.github.com/users/sasili-adetunji/events{/privacy}","received_events_url":"https://api.github.com/users/sasili-adetunji/received_events","type":"User","site_admin":false},"repo":{"id":92286091,"name":"post-it-app-2","full_name":"sasili-adetunji/post-it-app-2","owner":{"login":"sasili-adetunji","id":28709038,"avatar_url":"https://avatars3.githubusercontent.com/u/28709038?v=4","gravatar_id":"","url":"https://api.github.com/users/sasili-adetunji","html_url":"https://github.com/sasili-adetunji","followers_url":"https://api.github.com/users/sasili-adetunji/followers","following_url":"https://api.github.com/users/sasili-adetunji/following{/other_user}","gists_url":"https://api.github.com/users/sasili-adetunji/gists{/gist_id}","starred_url":"https://api.github.com/users/sasili-adetunji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sasili-adetunji/subscriptions","organizations_url":"https://api.github.com/users/sasili-adetunji/orgs","repos_url":"https://api.github.com/users/sasili-adetunji/repos","events_url":"https://api.github.com/users/sasili-adetunji/events{/privacy}","received_events_url":"https://api.github.com/users/sasili-adetunji/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sasili-adetunji/post-it-app-2","description":"PostIt is an application that allows friends to create groups for notification","fork":false,"url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2","forks_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/forks","keys_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/teams","hooks_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/hooks","issue_events_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/issues/events{/number}","events_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/events","assignees_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/assignees{/user}","branches_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/branches{/branch}","tags_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/tags","blobs_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/statuses/{sha}","languages_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/languages","stargazers_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/stargazers","contributors_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/contributors","subscribers_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/subscribers","subscription_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/subscription","commits_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/contents/{+path}","compare_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/merges","archive_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/downloads","issues_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/issues{/number}","pulls_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/pulls{/number}","milestones_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/milestones{/number}","notifications_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/labels{/name}","releases_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/releases{/id}","deployments_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/deployments","created_at":"2017-05-24T11:43:39Z","updated_at":"2017-10-30T14:05:58Z","pushed_at":"2017-11-12T06:15:54Z","git_url":"git://github.com/sasili-adetunji/post-it-app-2.git","ssh_url":"[email protected]:sasili-adetunji/post-it-app-2.git","clone_url":"https://github.com/sasili-adetunji/post-it-app-2.git","svn_url":"https://github.com/sasili-adetunji/post-it-app-2","homepage":"https://post-it-app-2.herokuapp.com","size":12996,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"defense-feedback"}},"base":{"label":"sasili-adetunji:chore/second-feedback","ref":"chore/second-feedback","sha":"5d8c3cf25c90808024859ee35ab7aa7c78cd300f","user":{"login":"sasili-adetunji","id":28709038,"avatar_url":"https://avatars3.githubusercontent.com/u/28709038?v=4","gravatar_id":"","url":"https://api.github.com/users/sasili-adetunji","html_url":"https://github.com/sasili-adetunji","followers_url":"https://api.github.com/users/sasili-adetunji/followers","following_url":"https://api.github.com/users/sasili-adetunji/following{/other_user}","gists_url":"https://api.github.com/users/sasili-adetunji/gists{/gist_id}","starred_url":"https://api.github.com/users/sasili-adetunji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sasili-adetunji/subscriptions","organizations_url":"https://api.github.com/users/sasili-adetunji/orgs","repos_url":"https://api.github.com/users/sasili-adetunji/repos","events_url":"https://api.github.com/users/sasili-adetunji/events{/privacy}","received_events_url":"https://api.github.com/users/sasili-adetunji/received_events","type":"User","site_admin":false},"repo":{"id":92286091,"name":"post-it-app-2","full_name":"sasili-adetunji/post-it-app-2","owner":{"login":"sasili-adetunji","id":28709038,"avatar_url":"https://avatars3.githubusercontent.com/u/28709038?v=4","gravatar_id":"","url":"https://api.github.com/users/sasili-adetunji","html_url":"https://github.com/sasili-adetunji","followers_url":"https://api.github.com/users/sasili-adetunji/followers","following_url":"https://api.github.com/users/sasili-adetunji/following{/other_user}","gists_url":"https://api.github.com/users/sasili-adetunji/gists{/gist_id}","starred_url":"https://api.github.com/users/sasili-adetunji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sasili-adetunji/subscriptions","organizations_url":"https://api.github.com/users/sasili-adetunji/orgs","repos_url":"https://api.github.com/users/sasili-adetunji/repos","events_url":"https://api.github.com/users/sasili-adetunji/events{/privacy}","received_events_url":"https://api.github.com/users/sasili-adetunji/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sasili-adetunji/post-it-app-2","description":"PostIt is an application that allows friends to create groups for notification","fork":false,"url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2","forks_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/forks","keys_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/teams","hooks_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/hooks","issue_events_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/issues/events{/number}","events_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/events","assignees_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/assignees{/user}","branches_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/branches{/branch}","tags_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/tags","blobs_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/statuses/{sha}","languages_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/languages","stargazers_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/stargazers","contributors_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/contributors","subscribers_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/subscribers","subscription_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/subscription","commits_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/contents/{+path}","compare_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/merges","archive_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/downloads","issues_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/issues{/number}","pulls_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/pulls{/number}","milestones_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/milestones{/number}","notifications_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/labels{/name}","releases_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/releases{/id}","deployments_url":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/deployments","created_at":"2017-05-24T11:43:39Z","updated_at":"2017-10-30T14:05:58Z","pushed_at":"2017-11-12T06:15:54Z","git_url":"git://github.com/sasili-adetunji/post-it-app-2.git","ssh_url":"[email protected]:sasili-adetunji/post-it-app-2.git","clone_url":"https://github.com/sasili-adetunji/post-it-app-2.git","svn_url":"https://github.com/sasili-adetunji/post-it-app-2","homepage":"https://post-it-app-2.herokuapp.com","size":12996,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"defense-feedback"}},"_links":{"self":{"href":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/pulls/35"},"html":{"href":"https://github.com/sasili-adetunji/post-it-app-2/pull/35"},"issue":{"href":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/issues/35"},"comments":{"href":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/sasili-adetunji/post-it-app-2/statuses/6b41f28323a71c787568ab9233954b251b071646"}},"author_association":"OWNER"}} | {
"id": 92286091,
"name": "sasili-adetunji/post-it-app-2",
"url": "https://api.github.com/repos/sasili-adetunji/post-it-app-2"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-11-12T06:15:53 | 6842738046 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/at-tienhoang/project-way/pulls/comments/145658889","pull_request_review_id":70488736,"id":145658889,"diff_hunk":"@@ -0,0 +1,149 @@\n+package vn.asiantech.way.ui.confirm_location\n+\n+import android.graphics.Bitmap\n+import android.graphics.Canvas\n+import android.graphics.drawable.GradientDrawable\n+import android.location.Address\n+import android.location.Geocoder\n+import android.location.Location\n+import android.os.Bundle\n+import android.support.v4.content.ContextCompat\n+import android.view.LayoutInflater\n+import android.view.View\n+import android.view.ViewGroup\n+import android.view.animation.Animation\n+import com.google.android.gms.maps.*\n+import com.google.android.gms.maps.model.BitmapDescriptorFactory\n+import com.google.android.gms.maps.model.GroundOverlayOptions\n+import com.google.android.gms.maps.model.LatLng\n+import com.google.android.gms.maps.model.MarkerOptions\n+import kotlinx.android.synthetic.main.fragment_confirm_location.*\n+import kotlinx.android.synthetic.main.view_confirm_location_layout.*\n+import kotlinx.android.synthetic.main.view_confirm_location_layout.view.*\n+import vn.asiantech.way.R\n+import vn.asiantech.way.ui.base.BaseFragment\n+import vn.asiantech.way.ui.custom.RadiusAnimation\n+import vn.asiantech.way.utils.LocationUtil\n+import java.util.*\n+\n+/**\n+ * Fragment confirm location\n+ * Created by haingoq on 10/10/2017.\n+ */\n+class ConfirmLocationFragment : BaseFragment(), OnMapReadyCallback,\n+ LocationSource.OnLocationChangedListener,\n+ GoogleMap.OnCameraIdleListener, View.OnClickListener {\n+ var mGoogleMap: GoogleMap? = null\n+ private var mapFragment: SupportMapFragment? = null\n+ private var mLatLng: LatLng? = null\n+ private var mDestinationName: String? = null\n+\n+ override fun onCreateView(inflater: LayoutInflater?, container: ViewGroup?, savedInstanceState: Bundle?): View? {\n+ val view = inflater!!.inflate(R.layout.fragment_confirm_location, container, false)","path":"app/src/main/java/vn/asiantech/way/ui/confirm_location/ConfirmLocationFragment.kt","position":42,"original_position":42,"commit_id":"4830457a95881c7a907b08349d918501b010e271","original_commit_id":"79e61b35e4614b8f45781f1b6c07ddc83335e9de","user":{"login":"at-dev-support-01","id":15151284,"avatar_url":"https://avatars2.githubusercontent.com/u/15151284?v=4","gravatar_id":"","url":"https://api.github.com/users/at-dev-support-01","html_url":"https://github.com/at-dev-support-01","followers_url":"https://api.github.com/users/at-dev-support-01/followers","following_url":"https://api.github.com/users/at-dev-support-01/following{/other_user}","gists_url":"https://api.github.com/users/at-dev-support-01/gists{/gist_id}","starred_url":"https://api.github.com/users/at-dev-support-01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/at-dev-support-01/subscriptions","organizations_url":"https://api.github.com/users/at-dev-support-01/orgs","repos_url":"https://api.github.com/users/at-dev-support-01/repos","events_url":"https://api.github.com/users/at-dev-support-01/events{/privacy}","received_events_url":"https://api.github.com/users/at-dev-support-01/received_events","type":"User","site_admin":false},"body":"ERROR: It will throw NullPointerException at runtime if your nullable value is null.","created_at":"2017-10-19T10:20:13Z","updated_at":"2017-10-19T10:20:13Z","html_url":"https://github.com/at-tienhoang/project-way/pull/25#discussion_r145658889","pull_request_url":"https://api.github.com/repos/at-tienhoang/project-way/pulls/25","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/at-tienhoang/project-way/pulls/comments/145658889"},"html":{"href":"https://github.com/at-tienhoang/project-way/pull/25#discussion_r145658889"},"pull_request":{"href":"https://api.github.com/repos/at-tienhoang/project-way/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/at-tienhoang/project-way/pulls/25","id":145064008,"html_url":"https://github.com/at-tienhoang/project-way/pull/25","diff_url":"https://github.com/at-tienhoang/project-way/pull/25.diff","patch_url":"https://github.com/at-tienhoang/project-way/pull/25.patch","issue_url":"https://api.github.com/repos/at-tienhoang/project-way/issues/25","number":25,"state":"open","locked":false,"title":"Feature - Confirm location layout","user":{"login":"at-haingo","id":29221097,"avatar_url":"https://avatars3.githubusercontent.com/u/29221097?v=4","gravatar_id":"","url":"https://api.github.com/users/at-haingo","html_url":"https://github.com/at-haingo","followers_url":"https://api.github.com/users/at-haingo/followers","following_url":"https://api.github.com/users/at-haingo/following{/other_user}","gists_url":"https://api.github.com/users/at-haingo/gists{/gist_id}","starred_url":"https://api.github.com/users/at-haingo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/at-haingo/subscriptions","organizations_url":"https://api.github.com/users/at-haingo/orgs","repos_url":"https://api.github.com/users/at-haingo/repos","events_url":"https://api.github.com/users/at-haingo/events{/privacy}","received_events_url":"https://api.github.com/users/at-haingo/received_events","type":"User","site_admin":false},"body":"#### Related issues (Optional)\r\nTask #5 \r\n\r\n#### Description (Required)\r\n- [x] Create layout\r\n- [ ] Confirm location\r\n\r\n#### Reference (Optional)\r\n","created_at":"2017-10-06T03:09:01Z","updated_at":"2017-10-19T10:20:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09bec82ac24176f78f8ec5f2ee34f72b31c19ee0","assignee":{"login":"at-haingo","id":29221097,"avatar_url":"https://avatars3.githubusercontent.com/u/29221097?v=4","gravatar_id":"","url":"https://api.github.com/users/at-haingo","html_url":"https://github.com/at-haingo","followers_url":"https://api.github.com/users/at-haingo/followers","following_url":"https://api.github.com/users/at-haingo/following{/other_user}","gists_url":"https://api.github.com/users/at-haingo/gists{/gist_id}","starred_url":"https://api.github.com/users/at-haingo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/at-haingo/subscriptions","organizations_url":"https://api.github.com/users/at-haingo/orgs","repos_url":"https://api.github.com/users/at-haingo/repos","events_url":"https://api.github.com/users/at-haingo/events{/privacy}","received_events_url":"https://api.github.com/users/at-haingo/received_events","type":"User","site_admin":false},"assignees":[{"login":"at-haingo","id":29221097,"avatar_url":"https://avatars3.githubusercontent.com/u/29221097?v=4","gravatar_id":"","url":"https://api.github.com/users/at-haingo","html_url":"https://github.com/at-haingo","followers_url":"https://api.github.com/users/at-haingo/followers","following_url":"https://api.github.com/users/at-haingo/following{/other_user}","gists_url":"https://api.github.com/users/at-haingo/gists{/gist_id}","starred_url":"https://api.github.com/users/at-haingo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/at-haingo/subscriptions","organizations_url":"https://api.github.com/users/at-haingo/orgs","repos_url":"https://api.github.com/users/at-haingo/repos","events_url":"https://api.github.com/users/at-haingo/events{/privacy}","received_events_url":"https://api.github.com/users/at-haingo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/at-tienhoang/project-way/pulls/25/commits","review_comments_url":"https://api.github.com/repos/at-tienhoang/project-way/pulls/25/comments","review_comment_url":"https://api.github.com/repos/at-tienhoang/project-way/pulls/comments{/number}","comments_url":"https://api.github.com/repos/at-tienhoang/project-way/issues/25/comments","statuses_url":"https://api.github.com/repos/at-tienhoang/project-way/statuses/4830457a95881c7a907b08349d918501b010e271","head":{"label":"at-tienhoang:feature/add-confirm-location","ref":"feature/add-confirm-location","sha":"4830457a95881c7a907b08349d918501b010e271","user":{"login":"at-tienhoang","id":16132900,"avatar_url":"https://avatars1.githubusercontent.com/u/16132900?v=4","gravatar_id":"","url":"https://api.github.com/users/at-tienhoang","html_url":"https://github.com/at-tienhoang","followers_url":"https://api.github.com/users/at-tienhoang/followers","following_url":"https://api.github.com/users/at-tienhoang/following{/other_user}","gists_url":"https://api.github.com/users/at-tienhoang/gists{/gist_id}","starred_url":"https://api.github.com/users/at-tienhoang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/at-tienhoang/subscriptions","organizations_url":"https://api.github.com/users/at-tienhoang/orgs","repos_url":"https://api.github.com/users/at-tienhoang/repos","events_url":"https://api.github.com/users/at-tienhoang/events{/privacy}","received_events_url":"https://api.github.com/users/at-tienhoang/received_events","type":"User","site_admin":false},"repo":{"id":104166142,"name":"project-way","full_name":"at-tienhoang/project-way","owner":{"login":"at-tienhoang","id":16132900,"avatar_url":"https://avatars1.githubusercontent.com/u/16132900?v=4","gravatar_id":"","url":"https://api.github.com/users/at-tienhoang","html_url":"https://github.com/at-tienhoang","followers_url":"https://api.github.com/users/at-tienhoang/followers","following_url":"https://api.github.com/users/at-tienhoang/following{/other_user}","gists_url":"https://api.github.com/users/at-tienhoang/gists{/gist_id}","starred_url":"https://api.github.com/users/at-tienhoang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/at-tienhoang/subscriptions","organizations_url":"https://api.github.com/users/at-tienhoang/orgs","repos_url":"https://api.github.com/users/at-tienhoang/repos","events_url":"https://api.github.com/users/at-tienhoang/events{/privacy}","received_events_url":"https://api.github.com/users/at-tienhoang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/at-tienhoang/project-way","description":"Training project","fork":false,"url":"https://api.github.com/repos/at-tienhoang/project-way","forks_url":"https://api.github.com/repos/at-tienhoang/project-way/forks","keys_url":"https://api.github.com/repos/at-tienhoang/project-way/keys{/key_id}","collaborators_url":"https://api.github.com/repos/at-tienhoang/project-way/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/at-tienhoang/project-way/teams","hooks_url":"https://api.github.com/repos/at-tienhoang/project-way/hooks","issue_events_url":"https://api.github.com/repos/at-tienhoang/project-way/issues/events{/number}","events_url":"https://api.github.com/repos/at-tienhoang/project-way/events","assignees_url":"https://api.github.com/repos/at-tienhoang/project-way/assignees{/user}","branches_url":"https://api.github.com/repos/at-tienhoang/project-way/branches{/branch}","tags_url":"https://api.github.com/repos/at-tienhoang/project-way/tags","blobs_url":"https://api.github.com/repos/at-tienhoang/project-way/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/at-tienhoang/project-way/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/at-tienhoang/project-way/git/refs{/sha}","trees_url":"https://api.github.com/repos/at-tienhoang/project-way/git/trees{/sha}","statuses_url":"https://api.github.com/repos/at-tienhoang/project-way/statuses/{sha}","languages_url":"https://api.github.com/repos/at-tienhoang/project-way/languages","stargazers_url":"https://api.github.com/repos/at-tienhoang/project-way/stargazers","contributors_url":"https://api.github.com/repos/at-tienhoang/project-way/contributors","subscribers_url":"https://api.github.com/repos/at-tienhoang/project-way/subscribers","subscription_url":"https://api.github.com/repos/at-tienhoang/project-way/subscription","commits_url":"https://api.github.com/repos/at-tienhoang/project-way/commits{/sha}","git_commits_url":"https://api.github.com/repos/at-tienhoang/project-way/git/commits{/sha}","comments_url":"https://api.github.com/repos/at-tienhoang/project-way/comments{/number}","issue_comment_url":"https://api.github.com/repos/at-tienhoang/project-way/issues/comments{/number}","contents_url":"https://api.github.com/repos/at-tienhoang/project-way/contents/{+path}","compare_url":"https://api.github.com/repos/at-tienhoang/project-way/compare/{base}...{head}","merges_url":"https://api.github.com/repos/at-tienhoang/project-way/merges","archive_url":"https://api.github.com/repos/at-tienhoang/project-way/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/at-tienhoang/project-way/downloads","issues_url":"https://api.github.com/repos/at-tienhoang/project-way/issues{/number}","pulls_url":"https://api.github.com/repos/at-tienhoang/project-way/pulls{/number}","milestones_url":"https://api.github.com/repos/at-tienhoang/project-way/milestones{/number}","notifications_url":"https://api.github.com/repos/at-tienhoang/project-way/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/at-tienhoang/project-way/labels{/name}","releases_url":"https://api.github.com/repos/at-tienhoang/project-way/releases{/id}","deployments_url":"https://api.github.com/repos/at-tienhoang/project-way/deployments","created_at":"2017-09-20T04:36:23Z","updated_at":"2017-09-21T02:42:06Z","pushed_at":"2017-10-19T10:19:16Z","git_url":"git://github.com/at-tienhoang/project-way.git","ssh_url":"[email protected]:at-tienhoang/project-way.git","clone_url":"https://github.com/at-tienhoang/project-way.git","svn_url":"https://github.com/at-tienhoang/project-way","homepage":null,"size":1622,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":0,"default_branch":"master"}},"base":{"label":"at-tienhoang:master","ref":"master","sha":"704f634275efa4ea40b4d70e3c70edd5144be357","user":{"login":"at-tienhoang","id":16132900,"avatar_url":"https://avatars1.githubusercontent.com/u/16132900?v=4","gravatar_id":"","url":"https://api.github.com/users/at-tienhoang","html_url":"https://github.com/at-tienhoang","followers_url":"https://api.github.com/users/at-tienhoang/followers","following_url":"https://api.github.com/users/at-tienhoang/following{/other_user}","gists_url":"https://api.github.com/users/at-tienhoang/gists{/gist_id}","starred_url":"https://api.github.com/users/at-tienhoang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/at-tienhoang/subscriptions","organizations_url":"https://api.github.com/users/at-tienhoang/orgs","repos_url":"https://api.github.com/users/at-tienhoang/repos","events_url":"https://api.github.com/users/at-tienhoang/events{/privacy}","received_events_url":"https://api.github.com/users/at-tienhoang/received_events","type":"User","site_admin":false},"repo":{"id":104166142,"name":"project-way","full_name":"at-tienhoang/project-way","owner":{"login":"at-tienhoang","id":16132900,"avatar_url":"https://avatars1.githubusercontent.com/u/16132900?v=4","gravatar_id":"","url":"https://api.github.com/users/at-tienhoang","html_url":"https://github.com/at-tienhoang","followers_url":"https://api.github.com/users/at-tienhoang/followers","following_url":"https://api.github.com/users/at-tienhoang/following{/other_user}","gists_url":"https://api.github.com/users/at-tienhoang/gists{/gist_id}","starred_url":"https://api.github.com/users/at-tienhoang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/at-tienhoang/subscriptions","organizations_url":"https://api.github.com/users/at-tienhoang/orgs","repos_url":"https://api.github.com/users/at-tienhoang/repos","events_url":"https://api.github.com/users/at-tienhoang/events{/privacy}","received_events_url":"https://api.github.com/users/at-tienhoang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/at-tienhoang/project-way","description":"Training project","fork":false,"url":"https://api.github.com/repos/at-tienhoang/project-way","forks_url":"https://api.github.com/repos/at-tienhoang/project-way/forks","keys_url":"https://api.github.com/repos/at-tienhoang/project-way/keys{/key_id}","collaborators_url":"https://api.github.com/repos/at-tienhoang/project-way/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/at-tienhoang/project-way/teams","hooks_url":"https://api.github.com/repos/at-tienhoang/project-way/hooks","issue_events_url":"https://api.github.com/repos/at-tienhoang/project-way/issues/events{/number}","events_url":"https://api.github.com/repos/at-tienhoang/project-way/events","assignees_url":"https://api.github.com/repos/at-tienhoang/project-way/assignees{/user}","branches_url":"https://api.github.com/repos/at-tienhoang/project-way/branches{/branch}","tags_url":"https://api.github.com/repos/at-tienhoang/project-way/tags","blobs_url":"https://api.github.com/repos/at-tienhoang/project-way/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/at-tienhoang/project-way/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/at-tienhoang/project-way/git/refs{/sha}","trees_url":"https://api.github.com/repos/at-tienhoang/project-way/git/trees{/sha}","statuses_url":"https://api.github.com/repos/at-tienhoang/project-way/statuses/{sha}","languages_url":"https://api.github.com/repos/at-tienhoang/project-way/languages","stargazers_url":"https://api.github.com/repos/at-tienhoang/project-way/stargazers","contributors_url":"https://api.github.com/repos/at-tienhoang/project-way/contributors","subscribers_url":"https://api.github.com/repos/at-tienhoang/project-way/subscribers","subscription_url":"https://api.github.com/repos/at-tienhoang/project-way/subscription","commits_url":"https://api.github.com/repos/at-tienhoang/project-way/commits{/sha}","git_commits_url":"https://api.github.com/repos/at-tienhoang/project-way/git/commits{/sha}","comments_url":"https://api.github.com/repos/at-tienhoang/project-way/comments{/number}","issue_comment_url":"https://api.github.com/repos/at-tienhoang/project-way/issues/comments{/number}","contents_url":"https://api.github.com/repos/at-tienhoang/project-way/contents/{+path}","compare_url":"https://api.github.com/repos/at-tienhoang/project-way/compare/{base}...{head}","merges_url":"https://api.github.com/repos/at-tienhoang/project-way/merges","archive_url":"https://api.github.com/repos/at-tienhoang/project-way/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/at-tienhoang/project-way/downloads","issues_url":"https://api.github.com/repos/at-tienhoang/project-way/issues{/number}","pulls_url":"https://api.github.com/repos/at-tienhoang/project-way/pulls{/number}","milestones_url":"https://api.github.com/repos/at-tienhoang/project-way/milestones{/number}","notifications_url":"https://api.github.com/repos/at-tienhoang/project-way/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/at-tienhoang/project-way/labels{/name}","releases_url":"https://api.github.com/repos/at-tienhoang/project-way/releases{/id}","deployments_url":"https://api.github.com/repos/at-tienhoang/project-way/deployments","created_at":"2017-09-20T04:36:23Z","updated_at":"2017-09-21T02:42:06Z","pushed_at":"2017-10-19T10:19:16Z","git_url":"git://github.com/at-tienhoang/project-way.git","ssh_url":"[email protected]:at-tienhoang/project-way.git","clone_url":"https://github.com/at-tienhoang/project-way.git","svn_url":"https://github.com/at-tienhoang/project-way","homepage":null,"size":1622,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/at-tienhoang/project-way/pulls/25"},"html":{"href":"https://github.com/at-tienhoang/project-way/pull/25"},"issue":{"href":"https://api.github.com/repos/at-tienhoang/project-way/issues/25"},"comments":{"href":"https://api.github.com/repos/at-tienhoang/project-way/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/at-tienhoang/project-way/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/at-tienhoang/project-way/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/at-tienhoang/project-way/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/at-tienhoang/project-way/statuses/4830457a95881c7a907b08349d918501b010e271"}},"author_association":"COLLABORATOR"}} | {
"id": 104166142,
"name": "at-tienhoang/project-way",
"url": "https://api.github.com/repos/at-tienhoang/project-way"
} | {
"id": 15151284,
"login": "at-dev-support-01",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15151284?",
"url": "https://api.github.com/users/at-dev-support-01"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-10-19T10:20:13 | 6737689218 | {"actor":{"display_login":"at-dev-support-01"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/margocramer/commutes_group_project/pulls/comments/128370151","pull_request_review_id":51044500,"id":128370151,"diff_hunk":"@@ -0,0 +1,31 @@\n+import { shallow, mount } from 'enzyme';\n+import jasmineEnzyme from 'jasmine-enzyme';\n+import React from 'react';\n+import $ from 'jquery';\n+import 'jasmine-ajax';\n+\n+Object.assign(global, {\n+ jasmineEnzyme,","path":"react/test/testHelper.js","position":8,"original_position":8,"commit_id":"75a29bd48a3b3c061c1134c654865af5952e3c87","original_commit_id":"75a29bd48a3b3c061c1134c654865af5952e3c87","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).","created_at":"2017-07-19T21:19:43Z","updated_at":"2017-07-19T21:19:43Z","html_url":"https://github.com/margocramer/commutes_group_project/pull/5#discussion_r128370151","pull_request_url":"https://api.github.com/repos/margocramer/commutes_group_project/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/margocramer/commutes_group_project/pulls/comments/128370151"},"html":{"href":"https://github.com/margocramer/commutes_group_project/pull/5#discussion_r128370151"},"pull_request":{"href":"https://api.github.com/repos/margocramer/commutes_group_project/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/margocramer/commutes_group_project/pulls/5","id":131422479,"html_url":"https://github.com/margocramer/commutes_group_project/pull/5","diff_url":"https://github.com/margocramer/commutes_group_project/pull/5.diff","patch_url":"https://github.com/margocramer/commutes_group_project/pull/5.patch","issue_url":"https://api.github.com/repos/margocramer/commutes_group_project/issues/5","number":5,"state":"open","locked":false,"title":"Integrate react","user":{"login":"margocramer","id":29312466,"avatar_url":"https://avatars1.githubusercontent.com/u/29312466?v=4","gravatar_id":"","url":"https://api.github.com/users/margocramer","html_url":"https://github.com/margocramer","followers_url":"https://api.github.com/users/margocramer/followers","following_url":"https://api.github.com/users/margocramer/following{/other_user}","gists_url":"https://api.github.com/users/margocramer/gists{/gist_id}","starred_url":"https://api.github.com/users/margocramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/margocramer/subscriptions","organizations_url":"https://api.github.com/users/margocramer/orgs","repos_url":"https://api.github.com/users/margocramer/repos","events_url":"https://api.github.com/users/margocramer/events{/privacy}","received_events_url":"https://api.github.com/users/margocramer/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-19T21:19:34Z","updated_at":"2017-07-19T21:19:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d94feb0472b61917bb2eabb272396f6e34782eb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/margocramer/commutes_group_project/pulls/5/commits","review_comments_url":"https://api.github.com/repos/margocramer/commutes_group_project/pulls/5/comments","review_comment_url":"https://api.github.com/repos/margocramer/commutes_group_project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/margocramer/commutes_group_project/issues/5/comments","statuses_url":"https://api.github.com/repos/margocramer/commutes_group_project/statuses/75a29bd48a3b3c061c1134c654865af5952e3c87","head":{"label":"margocramer:integrateReact","ref":"integrateReact","sha":"75a29bd48a3b3c061c1134c654865af5952e3c87","user":{"login":"margocramer","id":29312466,"avatar_url":"https://avatars1.githubusercontent.com/u/29312466?v=4","gravatar_id":"","url":"https://api.github.com/users/margocramer","html_url":"https://github.com/margocramer","followers_url":"https://api.github.com/users/margocramer/followers","following_url":"https://api.github.com/users/margocramer/following{/other_user}","gists_url":"https://api.github.com/users/margocramer/gists{/gist_id}","starred_url":"https://api.github.com/users/margocramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/margocramer/subscriptions","organizations_url":"https://api.github.com/users/margocramer/orgs","repos_url":"https://api.github.com/users/margocramer/repos","events_url":"https://api.github.com/users/margocramer/events{/privacy}","received_events_url":"https://api.github.com/users/margocramer/received_events","type":"User","site_admin":false},"repo":{"id":97502471,"name":"commutes_group_project","full_name":"margocramer/commutes_group_project","owner":{"login":"margocramer","id":29312466,"avatar_url":"https://avatars1.githubusercontent.com/u/29312466?v=4","gravatar_id":"","url":"https://api.github.com/users/margocramer","html_url":"https://github.com/margocramer","followers_url":"https://api.github.com/users/margocramer/followers","following_url":"https://api.github.com/users/margocramer/following{/other_user}","gists_url":"https://api.github.com/users/margocramer/gists{/gist_id}","starred_url":"https://api.github.com/users/margocramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/margocramer/subscriptions","organizations_url":"https://api.github.com/users/margocramer/orgs","repos_url":"https://api.github.com/users/margocramer/repos","events_url":"https://api.github.com/users/margocramer/events{/privacy}","received_events_url":"https://api.github.com/users/margocramer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/margocramer/commutes_group_project","description":null,"fork":false,"url":"https://api.github.com/repos/margocramer/commutes_group_project","forks_url":"https://api.github.com/repos/margocramer/commutes_group_project/forks","keys_url":"https://api.github.com/repos/margocramer/commutes_group_project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/margocramer/commutes_group_project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/margocramer/commutes_group_project/teams","hooks_url":"https://api.github.com/repos/margocramer/commutes_group_project/hooks","issue_events_url":"https://api.github.com/repos/margocramer/commutes_group_project/issues/events{/number}","events_url":"https://api.github.com/repos/margocramer/commutes_group_project/events","assignees_url":"https://api.github.com/repos/margocramer/commutes_group_project/assignees{/user}","branches_url":"https://api.github.com/repos/margocramer/commutes_group_project/branches{/branch}","tags_url":"https://api.github.com/repos/margocramer/commutes_group_project/tags","blobs_url":"https://api.github.com/repos/margocramer/commutes_group_project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/margocramer/commutes_group_project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/margocramer/commutes_group_project/git/refs{/sha}","trees_url":"https://api.github.com/repos/margocramer/commutes_group_project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/margocramer/commutes_group_project/statuses/{sha}","languages_url":"https://api.github.com/repos/margocramer/commutes_group_project/languages","stargazers_url":"https://api.github.com/repos/margocramer/commutes_group_project/stargazers","contributors_url":"https://api.github.com/repos/margocramer/commutes_group_project/contributors","subscribers_url":"https://api.github.com/repos/margocramer/commutes_group_project/subscribers","subscription_url":"https://api.github.com/repos/margocramer/commutes_group_project/subscription","commits_url":"https://api.github.com/repos/margocramer/commutes_group_project/commits{/sha}","git_commits_url":"https://api.github.com/repos/margocramer/commutes_group_project/git/commits{/sha}","comments_url":"https://api.github.com/repos/margocramer/commutes_group_project/comments{/number}","issue_comment_url":"https://api.github.com/repos/margocramer/commutes_group_project/issues/comments{/number}","contents_url":"https://api.github.com/repos/margocramer/commutes_group_project/contents/{+path}","compare_url":"https://api.github.com/repos/margocramer/commutes_group_project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/margocramer/commutes_group_project/merges","archive_url":"https://api.github.com/repos/margocramer/commutes_group_project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/margocramer/commutes_group_project/downloads","issues_url":"https://api.github.com/repos/margocramer/commutes_group_project/issues{/number}","pulls_url":"https://api.github.com/repos/margocramer/commutes_group_project/pulls{/number}","milestones_url":"https://api.github.com/repos/margocramer/commutes_group_project/milestones{/number}","notifications_url":"https://api.github.com/repos/margocramer/commutes_group_project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/margocramer/commutes_group_project/labels{/name}","releases_url":"https://api.github.com/repos/margocramer/commutes_group_project/releases{/id}","deployments_url":"https://api.github.com/repos/margocramer/commutes_group_project/deployments","created_at":"2017-07-17T17:14:50Z","updated_at":"2017-07-17T17:16:28Z","pushed_at":"2017-07-19T21:19:34Z","git_url":"git://github.com/margocramer/commutes_group_project.git","ssh_url":"[email protected]:margocramer/commutes_group_project.git","clone_url":"https://github.com/margocramer/commutes_group_project.git","svn_url":"https://github.com/margocramer/commutes_group_project","homepage":null,"size":53,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"margocramer:master","ref":"master","sha":"f683b32cb1badce2ae3990136d10fbf943c9223b","user":{"login":"margocramer","id":29312466,"avatar_url":"https://avatars1.githubusercontent.com/u/29312466?v=4","gravatar_id":"","url":"https://api.github.com/users/margocramer","html_url":"https://github.com/margocramer","followers_url":"https://api.github.com/users/margocramer/followers","following_url":"https://api.github.com/users/margocramer/following{/other_user}","gists_url":"https://api.github.com/users/margocramer/gists{/gist_id}","starred_url":"https://api.github.com/users/margocramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/margocramer/subscriptions","organizations_url":"https://api.github.com/users/margocramer/orgs","repos_url":"https://api.github.com/users/margocramer/repos","events_url":"https://api.github.com/users/margocramer/events{/privacy}","received_events_url":"https://api.github.com/users/margocramer/received_events","type":"User","site_admin":false},"repo":{"id":97502471,"name":"commutes_group_project","full_name":"margocramer/commutes_group_project","owner":{"login":"margocramer","id":29312466,"avatar_url":"https://avatars1.githubusercontent.com/u/29312466?v=4","gravatar_id":"","url":"https://api.github.com/users/margocramer","html_url":"https://github.com/margocramer","followers_url":"https://api.github.com/users/margocramer/followers","following_url":"https://api.github.com/users/margocramer/following{/other_user}","gists_url":"https://api.github.com/users/margocramer/gists{/gist_id}","starred_url":"https://api.github.com/users/margocramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/margocramer/subscriptions","organizations_url":"https://api.github.com/users/margocramer/orgs","repos_url":"https://api.github.com/users/margocramer/repos","events_url":"https://api.github.com/users/margocramer/events{/privacy}","received_events_url":"https://api.github.com/users/margocramer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/margocramer/commutes_group_project","description":null,"fork":false,"url":"https://api.github.com/repos/margocramer/commutes_group_project","forks_url":"https://api.github.com/repos/margocramer/commutes_group_project/forks","keys_url":"https://api.github.com/repos/margocramer/commutes_group_project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/margocramer/commutes_group_project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/margocramer/commutes_group_project/teams","hooks_url":"https://api.github.com/repos/margocramer/commutes_group_project/hooks","issue_events_url":"https://api.github.com/repos/margocramer/commutes_group_project/issues/events{/number}","events_url":"https://api.github.com/repos/margocramer/commutes_group_project/events","assignees_url":"https://api.github.com/repos/margocramer/commutes_group_project/assignees{/user}","branches_url":"https://api.github.com/repos/margocramer/commutes_group_project/branches{/branch}","tags_url":"https://api.github.com/repos/margocramer/commutes_group_project/tags","blobs_url":"https://api.github.com/repos/margocramer/commutes_group_project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/margocramer/commutes_group_project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/margocramer/commutes_group_project/git/refs{/sha}","trees_url":"https://api.github.com/repos/margocramer/commutes_group_project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/margocramer/commutes_group_project/statuses/{sha}","languages_url":"https://api.github.com/repos/margocramer/commutes_group_project/languages","stargazers_url":"https://api.github.com/repos/margocramer/commutes_group_project/stargazers","contributors_url":"https://api.github.com/repos/margocramer/commutes_group_project/contributors","subscribers_url":"https://api.github.com/repos/margocramer/commutes_group_project/subscribers","subscription_url":"https://api.github.com/repos/margocramer/commutes_group_project/subscription","commits_url":"https://api.github.com/repos/margocramer/commutes_group_project/commits{/sha}","git_commits_url":"https://api.github.com/repos/margocramer/commutes_group_project/git/commits{/sha}","comments_url":"https://api.github.com/repos/margocramer/commutes_group_project/comments{/number}","issue_comment_url":"https://api.github.com/repos/margocramer/commutes_group_project/issues/comments{/number}","contents_url":"https://api.github.com/repos/margocramer/commutes_group_project/contents/{+path}","compare_url":"https://api.github.com/repos/margocramer/commutes_group_project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/margocramer/commutes_group_project/merges","archive_url":"https://api.github.com/repos/margocramer/commutes_group_project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/margocramer/commutes_group_project/downloads","issues_url":"https://api.github.com/repos/margocramer/commutes_group_project/issues{/number}","pulls_url":"https://api.github.com/repos/margocramer/commutes_group_project/pulls{/number}","milestones_url":"https://api.github.com/repos/margocramer/commutes_group_project/milestones{/number}","notifications_url":"https://api.github.com/repos/margocramer/commutes_group_project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/margocramer/commutes_group_project/labels{/name}","releases_url":"https://api.github.com/repos/margocramer/commutes_group_project/releases{/id}","deployments_url":"https://api.github.com/repos/margocramer/commutes_group_project/deployments","created_at":"2017-07-17T17:14:50Z","updated_at":"2017-07-17T17:16:28Z","pushed_at":"2017-07-19T21:19:34Z","git_url":"git://github.com/margocramer/commutes_group_project.git","ssh_url":"[email protected]:margocramer/commutes_group_project.git","clone_url":"https://github.com/margocramer/commutes_group_project.git","svn_url":"https://github.com/margocramer/commutes_group_project","homepage":null,"size":53,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/margocramer/commutes_group_project/pulls/5"},"html":{"href":"https://github.com/margocramer/commutes_group_project/pull/5"},"issue":{"href":"https://api.github.com/repos/margocramer/commutes_group_project/issues/5"},"comments":{"href":"https://api.github.com/repos/margocramer/commutes_group_project/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/margocramer/commutes_group_project/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/margocramer/commutes_group_project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/margocramer/commutes_group_project/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/margocramer/commutes_group_project/statuses/75a29bd48a3b3c061c1134c654865af5952e3c87"}}}} | {
"id": 97502471,
"name": "margocramer/commutes_group_project",
"url": "https://api.github.com/repos/margocramer/commutes_group_project"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-07-19T21:19:43 | 6290359108 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/danliris/bateeq-pos-ui/pulls/comments/95508158","pull_request_review_id":16064119,"id":95508158,"diff_hunk":"@@ -0,0 +1,121 @@\n+/**\n+ * To learn more about how to use Easy Webpack\n+ * Take a look at the README here: https://github.com/easy-webpack/core\n+ **/\n+import { generateConfig, get, stripMetadata, EasyWebpackConfig } from '@easy-webpack/core'\n+import path from 'path'\n+\n+import envProd from '@easy-webpack/config-env-production'\n+import envDev from '@easy-webpack/config-env-development'\n+import aurelia from '@easy-webpack/config-aurelia'\n+import babel from '@easy-webpack/config-babel'\n+import html from '@easy-webpack/config-html'\n+import css from '@easy-webpack/config-css'\n+import fontAndImages from '@easy-webpack/config-fonts-and-images'\n+import globalBluebird from '@easy-webpack/config-global-bluebird'\n+import globalJquery from '@easy-webpack/config-global-jquery'\n+import globalRegenerator from '@easy-webpack/config-global-regenerator'\n+import generateIndexHtml from '@easy-webpack/config-generate-index-html'\n+import commonChunksOptimize from '@easy-webpack/config-common-chunks-simple'\n+import copyFiles from '@easy-webpack/config-copy-files'\n+import uglify from '@easy-webpack/config-uglify'\n+import generateCoverage from '@easy-webpack/config-test-coverage-istanbul'\n+\n+process.env.BABEL_ENV = 'webpack'\n+const ENV = process.env.NODE_ENV && process.env.NODE_ENV.toLowerCase() || (process.env.NODE_ENV = 'development')\n+\n+// basic configuration:\n+const title = 'Bateeq POS System'","path":"webpack.config.babel.js","position":28,"original_position":28,"commit_id":"7ea818e4b4353ae6463b3cf6b1ef1945f110b479","original_commit_id":"7ea818e4b4353ae6463b3cf6b1ef1945f110b479","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).<br>Missing semicolon.","created_at":"2017-01-11T03:54:51Z","updated_at":"2017-01-11T03:54:51Z","html_url":"https://github.com/danliris/bateeq-pos-ui/pull/54#discussion_r95508158","pull_request_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/danliris/bateeq-pos-ui/pulls/comments/95508158"},"html":{"href":"https://github.com/danliris/bateeq-pos-ui/pull/54#discussion_r95508158"},"pull_request":{"href":"https://api.github.com/repos/danliris/bateeq-pos-ui/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/danliris/bateeq-pos-ui/pulls/54","id":100999428,"html_url":"https://github.com/danliris/bateeq-pos-ui/pull/54","diff_url":"https://github.com/danliris/bateeq-pos-ui/pull/54.diff","patch_url":"https://github.com/danliris/bateeq-pos-ui/pull/54.patch","issue_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/issues/54","number":54,"state":"open","locked":false,"title":"implement react","user":{"login":"danielmoonlay","id":13761378,"avatar_url":"https://avatars.githubusercontent.com/u/13761378?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmoonlay","html_url":"https://github.com/danielmoonlay","followers_url":"https://api.github.com/users/danielmoonlay/followers","following_url":"https://api.github.com/users/danielmoonlay/following{/other_user}","gists_url":"https://api.github.com/users/danielmoonlay/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmoonlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmoonlay/subscriptions","organizations_url":"https://api.github.com/users/danielmoonlay/orgs","repos_url":"https://api.github.com/users/danielmoonlay/repos","events_url":"https://api.github.com/users/danielmoonlay/events{/privacy}","received_events_url":"https://api.github.com/users/danielmoonlay/received_events","type":"User","site_admin":false},"body":null,"created_at":"2017-01-11T03:54:38Z","updated_at":"2017-01-11T03:54:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23efd8866b3c78bf6cf79042df1ba94a47bb897d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/pulls/54/commits","review_comments_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/pulls/54/comments","review_comment_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/issues/54/comments","statuses_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/statuses/7ea818e4b4353ae6463b3cf6b1ef1945f110b479","head":{"label":"danielmoonlay:dev","ref":"dev","sha":"7ea818e4b4353ae6463b3cf6b1ef1945f110b479","user":{"login":"danielmoonlay","id":13761378,"avatar_url":"https://avatars.githubusercontent.com/u/13761378?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmoonlay","html_url":"https://github.com/danielmoonlay","followers_url":"https://api.github.com/users/danielmoonlay/followers","following_url":"https://api.github.com/users/danielmoonlay/following{/other_user}","gists_url":"https://api.github.com/users/danielmoonlay/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmoonlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmoonlay/subscriptions","organizations_url":"https://api.github.com/users/danielmoonlay/orgs","repos_url":"https://api.github.com/users/danielmoonlay/repos","events_url":"https://api.github.com/users/danielmoonlay/events{/privacy}","received_events_url":"https://api.github.com/users/danielmoonlay/received_events","type":"User","site_admin":false},"repo":{"id":77191065,"name":"bateeq-pos-ui","full_name":"danielmoonlay/bateeq-pos-ui","owner":{"login":"danielmoonlay","id":13761378,"avatar_url":"https://avatars.githubusercontent.com/u/13761378?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmoonlay","html_url":"https://github.com/danielmoonlay","followers_url":"https://api.github.com/users/danielmoonlay/followers","following_url":"https://api.github.com/users/danielmoonlay/following{/other_user}","gists_url":"https://api.github.com/users/danielmoonlay/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmoonlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmoonlay/subscriptions","organizations_url":"https://api.github.com/users/danielmoonlay/orgs","repos_url":"https://api.github.com/users/danielmoonlay/repos","events_url":"https://api.github.com/users/danielmoonlay/events{/privacy}","received_events_url":"https://api.github.com/users/danielmoonlay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielmoonlay/bateeq-pos-ui","description":"Bateeq POS ui","fork":true,"url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui","forks_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/forks","keys_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/teams","hooks_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/hooks","issue_events_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/issues/events{/number}","events_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/events","assignees_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/assignees{/user}","branches_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/branches{/branch}","tags_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/tags","blobs_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/languages","stargazers_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/stargazers","contributors_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/contributors","subscribers_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/subscribers","subscription_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/subscription","commits_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/contents/{+path}","compare_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/merges","archive_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/downloads","issues_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/issues{/number}","pulls_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/labels{/name}","releases_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/releases{/id}","deployments_url":"https://api.github.com/repos/danielmoonlay/bateeq-pos-ui/deployments","created_at":"2016-12-23T02:25:10Z","updated_at":"2016-12-23T02:25:13Z","pushed_at":"2017-01-11T03:54:02Z","git_url":"git://github.com/danielmoonlay/bateeq-pos-ui.git","ssh_url":"[email protected]:danielmoonlay/bateeq-pos-ui.git","clone_url":"https://github.com/danielmoonlay/bateeq-pos-ui.git","svn_url":"https://github.com/danielmoonlay/bateeq-pos-ui","homepage":null,"size":323,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"danliris:dev","ref":"dev","sha":"605147530481af149ffa39c9f4d83dbe569075e0","user":{"login":"danliris","id":20855729,"avatar_url":"https://avatars.githubusercontent.com/u/20855729?v=3","gravatar_id":"","url":"https://api.github.com/users/danliris","html_url":"https://github.com/danliris","followers_url":"https://api.github.com/users/danliris/followers","following_url":"https://api.github.com/users/danliris/following{/other_user}","gists_url":"https://api.github.com/users/danliris/gists{/gist_id}","starred_url":"https://api.github.com/users/danliris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danliris/subscriptions","organizations_url":"https://api.github.com/users/danliris/orgs","repos_url":"https://api.github.com/users/danliris/repos","events_url":"https://api.github.com/users/danliris/events{/privacy}","received_events_url":"https://api.github.com/users/danliris/received_events","type":"User","site_admin":false},"repo":{"id":72504733,"name":"bateeq-pos-ui","full_name":"danliris/bateeq-pos-ui","owner":{"login":"danliris","id":20855729,"avatar_url":"https://avatars.githubusercontent.com/u/20855729?v=3","gravatar_id":"","url":"https://api.github.com/users/danliris","html_url":"https://github.com/danliris","followers_url":"https://api.github.com/users/danliris/followers","following_url":"https://api.github.com/users/danliris/following{/other_user}","gists_url":"https://api.github.com/users/danliris/gists{/gist_id}","starred_url":"https://api.github.com/users/danliris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danliris/subscriptions","organizations_url":"https://api.github.com/users/danliris/orgs","repos_url":"https://api.github.com/users/danliris/repos","events_url":"https://api.github.com/users/danliris/events{/privacy}","received_events_url":"https://api.github.com/users/danliris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danliris/bateeq-pos-ui","description":"Bateeq POS ui","fork":false,"url":"https://api.github.com/repos/danliris/bateeq-pos-ui","forks_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/forks","keys_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/teams","hooks_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/hooks","issue_events_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/issues/events{/number}","events_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/events","assignees_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/assignees{/user}","branches_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/branches{/branch}","tags_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/tags","blobs_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/languages","stargazers_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/stargazers","contributors_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/contributors","subscribers_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/subscribers","subscription_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/subscription","commits_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/contents/{+path}","compare_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/merges","archive_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/downloads","issues_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/issues{/number}","pulls_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/labels{/name}","releases_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/releases{/id}","deployments_url":"https://api.github.com/repos/danliris/bateeq-pos-ui/deployments","created_at":"2016-11-01T04:46:53Z","updated_at":"2016-12-20T11:38:47Z","pushed_at":"2017-01-11T03:54:39Z","git_url":"git://github.com/danliris/bateeq-pos-ui.git","ssh_url":"[email protected]:danliris/bateeq-pos-ui.git","clone_url":"https://github.com/danliris/bateeq-pos-ui.git","svn_url":"https://github.com/danliris/bateeq-pos-ui","homepage":null,"size":326,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danliris/bateeq-pos-ui/pulls/54"},"html":{"href":"https://github.com/danliris/bateeq-pos-ui/pull/54"},"issue":{"href":"https://api.github.com/repos/danliris/bateeq-pos-ui/issues/54"},"comments":{"href":"https://api.github.com/repos/danliris/bateeq-pos-ui/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/danliris/bateeq-pos-ui/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/danliris/bateeq-pos-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danliris/bateeq-pos-ui/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/danliris/bateeq-pos-ui/statuses/7ea818e4b4353ae6463b3cf6b1ef1945f110b479"}}}} | {
"id": 72504733,
"name": "danliris/bateeq-pos-ui",
"url": "https://api.github.com/repos/danliris/bateeq-pos-ui"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-01-11T03:54:51 | 5133480776 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/majakudlicka/BEEVR/pulls/comments/125875246","pull_request_review_id":48304603,"id":125875246,"diff_hunk":"@@ -0,0 +1,71 @@\n+import request from './fakeRequest';","path":"src/utils/auth.js","position":1,"original_position":1,"commit_id":"90bbbb35867db8a7bbc4d044b30dce82e3219970","original_commit_id":"90bbbb35867db8a7bbc4d044b30dce82e3219970","user":{"login":"des-des","id":12845233,"avatar_url":"https://avatars2.githubusercontent.com/u/12845233?v=3","gravatar_id":"","url":"https://api.github.com/users/des-des","html_url":"https://github.com/des-des","followers_url":"https://api.github.com/users/des-des/followers","following_url":"https://api.github.com/users/des-des/following{/other_user}","gists_url":"https://api.github.com/users/des-des/gists{/gist_id}","starred_url":"https://api.github.com/users/des-des/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/des-des/subscriptions","organizations_url":"https://api.github.com/users/des-des/orgs","repos_url":"https://api.github.com/users/des-des/repos","events_url":"https://api.github.com/users/des-des/events{/privacy}","received_events_url":"https://api.github.com/users/des-des/received_events","type":"User","site_admin":false},"body":"Dont use this fake request!","created_at":"2017-07-06T11:36:00Z","updated_at":"2017-07-06T11:39:00Z","html_url":"https://github.com/majakudlicka/BEEVR/pull/28#discussion_r125875246","pull_request_url":"https://api.github.com/repos/majakudlicka/BEEVR/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/majakudlicka/BEEVR/pulls/comments/125875246"},"html":{"href":"https://github.com/majakudlicka/BEEVR/pull/28#discussion_r125875246"},"pull_request":{"href":"https://api.github.com/repos/majakudlicka/BEEVR/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/majakudlicka/BEEVR/pulls/28","id":128989357,"html_url":"https://github.com/majakudlicka/BEEVR/pull/28","diff_url":"https://github.com/majakudlicka/BEEVR/pull/28.diff","patch_url":"https://github.com/majakudlicka/BEEVR/pull/28.patch","issue_url":"https://api.github.com/repos/majakudlicka/BEEVR/issues/28","number":28,"state":"open","locked":false,"title":"Server","user":{"login":"antoniotrkdz","id":18493541,"avatar_url":"https://avatars2.githubusercontent.com/u/18493541?v=3","gravatar_id":"","url":"https://api.github.com/users/antoniotrkdz","html_url":"https://github.com/antoniotrkdz","followers_url":"https://api.github.com/users/antoniotrkdz/followers","following_url":"https://api.github.com/users/antoniotrkdz/following{/other_user}","gists_url":"https://api.github.com/users/antoniotrkdz/gists{/gist_id}","starred_url":"https://api.github.com/users/antoniotrkdz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoniotrkdz/subscriptions","organizations_url":"https://api.github.com/users/antoniotrkdz/orgs","repos_url":"https://api.github.com/users/antoniotrkdz/repos","events_url":"https://api.github.com/users/antoniotrkdz/events{/privacy}","received_events_url":"https://api.github.com/users/antoniotrkdz/received_events","type":"User","site_admin":false},"body":"Also added a calendar react component.\r\nPlease see commit for relevant modifications.\r\nThere are a lot of files that I didn't touch....(not only logs!) \r\nrelates #28","created_at":"2017-07-05T15:19:59Z","updated_at":"2017-07-06T11:39:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1863880cd45d33a00522244f8294425536ed2d8e","assignee":{"login":"des-des","id":12845233,"avatar_url":"https://avatars2.githubusercontent.com/u/12845233?v=3","gravatar_id":"","url":"https://api.github.com/users/des-des","html_url":"https://github.com/des-des","followers_url":"https://api.github.com/users/des-des/followers","following_url":"https://api.github.com/users/des-des/following{/other_user}","gists_url":"https://api.github.com/users/des-des/gists{/gist_id}","starred_url":"https://api.github.com/users/des-des/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/des-des/subscriptions","organizations_url":"https://api.github.com/users/des-des/orgs","repos_url":"https://api.github.com/users/des-des/repos","events_url":"https://api.github.com/users/des-des/events{/privacy}","received_events_url":"https://api.github.com/users/des-des/received_events","type":"User","site_admin":false},"assignees":[{"login":"des-des","id":12845233,"avatar_url":"https://avatars2.githubusercontent.com/u/12845233?v=3","gravatar_id":"","url":"https://api.github.com/users/des-des","html_url":"https://github.com/des-des","followers_url":"https://api.github.com/users/des-des/followers","following_url":"https://api.github.com/users/des-des/following{/other_user}","gists_url":"https://api.github.com/users/des-des/gists{/gist_id}","starred_url":"https://api.github.com/users/des-des/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/des-des/subscriptions","organizations_url":"https://api.github.com/users/des-des/orgs","repos_url":"https://api.github.com/users/des-des/repos","events_url":"https://api.github.com/users/des-des/events{/privacy}","received_events_url":"https://api.github.com/users/des-des/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/majakudlicka/BEEVR/pulls/28/commits","review_comments_url":"https://api.github.com/repos/majakudlicka/BEEVR/pulls/28/comments","review_comment_url":"https://api.github.com/repos/majakudlicka/BEEVR/pulls/comments{/number}","comments_url":"https://api.github.com/repos/majakudlicka/BEEVR/issues/28/comments","statuses_url":"https://api.github.com/repos/majakudlicka/BEEVR/statuses/90bbbb35867db8a7bbc4d044b30dce82e3219970","head":{"label":"majakudlicka:server","ref":"server","sha":"90bbbb35867db8a7bbc4d044b30dce82e3219970","user":{"login":"majakudlicka","id":23139974,"avatar_url":"https://avatars2.githubusercontent.com/u/23139974?v=3","gravatar_id":"","url":"https://api.github.com/users/majakudlicka","html_url":"https://github.com/majakudlicka","followers_url":"https://api.github.com/users/majakudlicka/followers","following_url":"https://api.github.com/users/majakudlicka/following{/other_user}","gists_url":"https://api.github.com/users/majakudlicka/gists{/gist_id}","starred_url":"https://api.github.com/users/majakudlicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majakudlicka/subscriptions","organizations_url":"https://api.github.com/users/majakudlicka/orgs","repos_url":"https://api.github.com/users/majakudlicka/repos","events_url":"https://api.github.com/users/majakudlicka/events{/privacy}","received_events_url":"https://api.github.com/users/majakudlicka/received_events","type":"User","site_admin":false},"repo":{"id":95685950,"name":"BEEVR","full_name":"majakudlicka/BEEVR","owner":{"login":"majakudlicka","id":23139974,"avatar_url":"https://avatars2.githubusercontent.com/u/23139974?v=3","gravatar_id":"","url":"https://api.github.com/users/majakudlicka","html_url":"https://github.com/majakudlicka","followers_url":"https://api.github.com/users/majakudlicka/followers","following_url":"https://api.github.com/users/majakudlicka/following{/other_user}","gists_url":"https://api.github.com/users/majakudlicka/gists{/gist_id}","starred_url":"https://api.github.com/users/majakudlicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majakudlicka/subscriptions","organizations_url":"https://api.github.com/users/majakudlicka/orgs","repos_url":"https://api.github.com/users/majakudlicka/repos","events_url":"https://api.github.com/users/majakudlicka/events{/privacy}","received_events_url":"https://api.github.com/users/majakudlicka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/majakudlicka/BEEVR","description":null,"fork":false,"url":"https://api.github.com/repos/majakudlicka/BEEVR","forks_url":"https://api.github.com/repos/majakudlicka/BEEVR/forks","keys_url":"https://api.github.com/repos/majakudlicka/BEEVR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/majakudlicka/BEEVR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/majakudlicka/BEEVR/teams","hooks_url":"https://api.github.com/repos/majakudlicka/BEEVR/hooks","issue_events_url":"https://api.github.com/repos/majakudlicka/BEEVR/issues/events{/number}","events_url":"https://api.github.com/repos/majakudlicka/BEEVR/events","assignees_url":"https://api.github.com/repos/majakudlicka/BEEVR/assignees{/user}","branches_url":"https://api.github.com/repos/majakudlicka/BEEVR/branches{/branch}","tags_url":"https://api.github.com/repos/majakudlicka/BEEVR/tags","blobs_url":"https://api.github.com/repos/majakudlicka/BEEVR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/majakudlicka/BEEVR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/majakudlicka/BEEVR/git/refs{/sha}","trees_url":"https://api.github.com/repos/majakudlicka/BEEVR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/majakudlicka/BEEVR/statuses/{sha}","languages_url":"https://api.github.com/repos/majakudlicka/BEEVR/languages","stargazers_url":"https://api.github.com/repos/majakudlicka/BEEVR/stargazers","contributors_url":"https://api.github.com/repos/majakudlicka/BEEVR/contributors","subscribers_url":"https://api.github.com/repos/majakudlicka/BEEVR/subscribers","subscription_url":"https://api.github.com/repos/majakudlicka/BEEVR/subscription","commits_url":"https://api.github.com/repos/majakudlicka/BEEVR/commits{/sha}","git_commits_url":"https://api.github.com/repos/majakudlicka/BEEVR/git/commits{/sha}","comments_url":"https://api.github.com/repos/majakudlicka/BEEVR/comments{/number}","issue_comment_url":"https://api.github.com/repos/majakudlicka/BEEVR/issues/comments{/number}","contents_url":"https://api.github.com/repos/majakudlicka/BEEVR/contents/{+path}","compare_url":"https://api.github.com/repos/majakudlicka/BEEVR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/majakudlicka/BEEVR/merges","archive_url":"https://api.github.com/repos/majakudlicka/BEEVR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/majakudlicka/BEEVR/downloads","issues_url":"https://api.github.com/repos/majakudlicka/BEEVR/issues{/number}","pulls_url":"https://api.github.com/repos/majakudlicka/BEEVR/pulls{/number}","milestones_url":"https://api.github.com/repos/majakudlicka/BEEVR/milestones{/number}","notifications_url":"https://api.github.com/repos/majakudlicka/BEEVR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/majakudlicka/BEEVR/labels{/name}","releases_url":"https://api.github.com/repos/majakudlicka/BEEVR/releases{/id}","deployments_url":"https://api.github.com/repos/majakudlicka/BEEVR/deployments","created_at":"2017-06-28T15:44:20Z","updated_at":"2017-07-05T11:57:12Z","pushed_at":"2017-07-06T09:32:06Z","git_url":"git://github.com/majakudlicka/BEEVR.git","ssh_url":"[email protected]:majakudlicka/BEEVR.git","clone_url":"https://github.com/majakudlicka/BEEVR.git","svn_url":"https://github.com/majakudlicka/BEEVR","homepage":null,"size":3316,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":25,"forks":0,"open_issues":25,"watchers":3,"default_branch":"master"}},"base":{"label":"majakudlicka:master","ref":"master","sha":"a78c41678a518b6ed948d106acd2843b9e5a4a3c","user":{"login":"majakudlicka","id":23139974,"avatar_url":"https://avatars2.githubusercontent.com/u/23139974?v=3","gravatar_id":"","url":"https://api.github.com/users/majakudlicka","html_url":"https://github.com/majakudlicka","followers_url":"https://api.github.com/users/majakudlicka/followers","following_url":"https://api.github.com/users/majakudlicka/following{/other_user}","gists_url":"https://api.github.com/users/majakudlicka/gists{/gist_id}","starred_url":"https://api.github.com/users/majakudlicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majakudlicka/subscriptions","organizations_url":"https://api.github.com/users/majakudlicka/orgs","repos_url":"https://api.github.com/users/majakudlicka/repos","events_url":"https://api.github.com/users/majakudlicka/events{/privacy}","received_events_url":"https://api.github.com/users/majakudlicka/received_events","type":"User","site_admin":false},"repo":{"id":95685950,"name":"BEEVR","full_name":"majakudlicka/BEEVR","owner":{"login":"majakudlicka","id":23139974,"avatar_url":"https://avatars2.githubusercontent.com/u/23139974?v=3","gravatar_id":"","url":"https://api.github.com/users/majakudlicka","html_url":"https://github.com/majakudlicka","followers_url":"https://api.github.com/users/majakudlicka/followers","following_url":"https://api.github.com/users/majakudlicka/following{/other_user}","gists_url":"https://api.github.com/users/majakudlicka/gists{/gist_id}","starred_url":"https://api.github.com/users/majakudlicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majakudlicka/subscriptions","organizations_url":"https://api.github.com/users/majakudlicka/orgs","repos_url":"https://api.github.com/users/majakudlicka/repos","events_url":"https://api.github.com/users/majakudlicka/events{/privacy}","received_events_url":"https://api.github.com/users/majakudlicka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/majakudlicka/BEEVR","description":null,"fork":false,"url":"https://api.github.com/repos/majakudlicka/BEEVR","forks_url":"https://api.github.com/repos/majakudlicka/BEEVR/forks","keys_url":"https://api.github.com/repos/majakudlicka/BEEVR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/majakudlicka/BEEVR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/majakudlicka/BEEVR/teams","hooks_url":"https://api.github.com/repos/majakudlicka/BEEVR/hooks","issue_events_url":"https://api.github.com/repos/majakudlicka/BEEVR/issues/events{/number}","events_url":"https://api.github.com/repos/majakudlicka/BEEVR/events","assignees_url":"https://api.github.com/repos/majakudlicka/BEEVR/assignees{/user}","branches_url":"https://api.github.com/repos/majakudlicka/BEEVR/branches{/branch}","tags_url":"https://api.github.com/repos/majakudlicka/BEEVR/tags","blobs_url":"https://api.github.com/repos/majakudlicka/BEEVR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/majakudlicka/BEEVR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/majakudlicka/BEEVR/git/refs{/sha}","trees_url":"https://api.github.com/repos/majakudlicka/BEEVR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/majakudlicka/BEEVR/statuses/{sha}","languages_url":"https://api.github.com/repos/majakudlicka/BEEVR/languages","stargazers_url":"https://api.github.com/repos/majakudlicka/BEEVR/stargazers","contributors_url":"https://api.github.com/repos/majakudlicka/BEEVR/contributors","subscribers_url":"https://api.github.com/repos/majakudlicka/BEEVR/subscribers","subscription_url":"https://api.github.com/repos/majakudlicka/BEEVR/subscription","commits_url":"https://api.github.com/repos/majakudlicka/BEEVR/commits{/sha}","git_commits_url":"https://api.github.com/repos/majakudlicka/BEEVR/git/commits{/sha}","comments_url":"https://api.github.com/repos/majakudlicka/BEEVR/comments{/number}","issue_comment_url":"https://api.github.com/repos/majakudlicka/BEEVR/issues/comments{/number}","contents_url":"https://api.github.com/repos/majakudlicka/BEEVR/contents/{+path}","compare_url":"https://api.github.com/repos/majakudlicka/BEEVR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/majakudlicka/BEEVR/merges","archive_url":"https://api.github.com/repos/majakudlicka/BEEVR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/majakudlicka/BEEVR/downloads","issues_url":"https://api.github.com/repos/majakudlicka/BEEVR/issues{/number}","pulls_url":"https://api.github.com/repos/majakudlicka/BEEVR/pulls{/number}","milestones_url":"https://api.github.com/repos/majakudlicka/BEEVR/milestones{/number}","notifications_url":"https://api.github.com/repos/majakudlicka/BEEVR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/majakudlicka/BEEVR/labels{/name}","releases_url":"https://api.github.com/repos/majakudlicka/BEEVR/releases{/id}","deployments_url":"https://api.github.com/repos/majakudlicka/BEEVR/deployments","created_at":"2017-06-28T15:44:20Z","updated_at":"2017-07-05T11:57:12Z","pushed_at":"2017-07-06T09:32:06Z","git_url":"git://github.com/majakudlicka/BEEVR.git","ssh_url":"[email protected]:majakudlicka/BEEVR.git","clone_url":"https://github.com/majakudlicka/BEEVR.git","svn_url":"https://github.com/majakudlicka/BEEVR","homepage":null,"size":3316,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":25,"forks":0,"open_issues":25,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/majakudlicka/BEEVR/pulls/28"},"html":{"href":"https://github.com/majakudlicka/BEEVR/pull/28"},"issue":{"href":"https://api.github.com/repos/majakudlicka/BEEVR/issues/28"},"comments":{"href":"https://api.github.com/repos/majakudlicka/BEEVR/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/majakudlicka/BEEVR/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/majakudlicka/BEEVR/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/majakudlicka/BEEVR/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/majakudlicka/BEEVR/statuses/90bbbb35867db8a7bbc4d044b30dce82e3219970"}}}} | {
"id": 95685950,
"name": "majakudlicka/BEEVR",
"url": "https://api.github.com/repos/majakudlicka/BEEVR"
} | {
"id": 12845233,
"login": "des-des",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12845233?",
"url": "https://api.github.com/users/des-des"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-07-06T11:36:00 | 6203352816 | {"actor":{"display_login":"des-des"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/pulls/comments/144714076","pull_request_review_id":69412590,"id":144714076,"diff_hunk":"@@ -0,0 +1,47 @@\n+const supportLanguage = [ \"zh-cn\", \"en\" ];\n+\n+export default {\n+ getLanguage() {\n+ // Chrome and Firefox 32+\n+ return navigator.languages || [\n+ navigator.language ||\n+ navigator.browserLanguage\n+ ]\n+ },\n+ getSplitedLanguage(language) {\n+ if (language.indexOf(\"-\") != -1) {\n+ const splitedLang = lang.substring(0, lang.indexOf(\"-\"))\n+ return splitedLang.toLowerCase();\n+ }\n+ return language\n+ },\n+ getLocale() {\n+ const supportLanguage = [ \"zh-cn\", \"en\" ];","path":"_src/src/i18n.js","position":19,"original_position":19,"commit_id":"f4765d68303e51b2eef41ecfc70d0ae078bb47ea","original_commit_id":"f4765d68303e51b2eef41ecfc70d0ae078bb47ea","user":{"login":"JustArchi","id":1069029,"avatar_url":"https://avatars0.githubusercontent.com/u/1069029?v=4","gravatar_id":"","url":"https://api.github.com/users/JustArchi","html_url":"https://github.com/JustArchi","followers_url":"https://api.github.com/users/JustArchi/followers","following_url":"https://api.github.com/users/JustArchi/following{/other_user}","gists_url":"https://api.github.com/users/JustArchi/gists{/gist_id}","starred_url":"https://api.github.com/users/JustArchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustArchi/subscriptions","organizations_url":"https://api.github.com/users/JustArchi/orgs","repos_url":"https://api.github.com/users/JustArchi/repos","events_url":"https://api.github.com/users/JustArchi/events{/privacy}","received_events_url":"https://api.github.com/users/JustArchi/received_events","type":"User","site_admin":false},"body":"This is defined twice.","created_at":"2017-10-15T09:17:25Z","updated_at":"2017-10-15T09:17:58Z","html_url":"https://github.com/JustArchi/ArchiSteamFarm/pull/674#discussion_r144714076","pull_request_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/pulls/674","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/pulls/comments/144714076"},"html":{"href":"https://github.com/JustArchi/ArchiSteamFarm/pull/674#discussion_r144714076"},"pull_request":{"href":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/pulls/674"}}},"pull_request":{"url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/pulls/674","id":146612191,"html_url":"https://github.com/JustArchi/ArchiSteamFarm/pull/674","diff_url":"https://github.com/JustArchi/ArchiSteamFarm/pull/674.diff","patch_url":"https://github.com/JustArchi/ArchiSteamFarm/pull/674.patch","issue_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/issues/674","number":674,"state":"open","locked":false,"title":"Translate Web-based ConfigGenerator","user":{"login":"Indexyz","id":7685264,"avatar_url":"https://avatars3.githubusercontent.com/u/7685264?v=4","gravatar_id":"","url":"https://api.github.com/users/Indexyz","html_url":"https://github.com/Indexyz","followers_url":"https://api.github.com/users/Indexyz/followers","following_url":"https://api.github.com/users/Indexyz/following{/other_user}","gists_url":"https://api.github.com/users/Indexyz/gists{/gist_id}","starred_url":"https://api.github.com/users/Indexyz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Indexyz/subscriptions","organizations_url":"https://api.github.com/users/Indexyz/orgs","repos_url":"https://api.github.com/users/Indexyz/repos","events_url":"https://api.github.com/users/Indexyz/events{/privacy}","received_events_url":"https://api.github.com/users/Indexyz/received_events","type":"User","site_admin":false},"body":"Add [vue-i18n](https://github.com/kazupon/vue-i18n) to translate strings\r\nI was translate it to zh-CN","created_at":"2017-10-14T17:18:04Z","updated_at":"2017-10-15T09:17:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a681a701c1a2ef163bba053ddc9fc40f83950f7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/pulls/674/commits","review_comments_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/pulls/674/comments","review_comment_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/issues/674/comments","statuses_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/statuses/f4765d68303e51b2eef41ecfc70d0ae078bb47ea","head":{"label":"Indexyz:gh-pages","ref":"gh-pages","sha":"f4765d68303e51b2eef41ecfc70d0ae078bb47ea","user":{"login":"Indexyz","id":7685264,"avatar_url":"https://avatars3.githubusercontent.com/u/7685264?v=4","gravatar_id":"","url":"https://api.github.com/users/Indexyz","html_url":"https://github.com/Indexyz","followers_url":"https://api.github.com/users/Indexyz/followers","following_url":"https://api.github.com/users/Indexyz/following{/other_user}","gists_url":"https://api.github.com/users/Indexyz/gists{/gist_id}","starred_url":"https://api.github.com/users/Indexyz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Indexyz/subscriptions","organizations_url":"https://api.github.com/users/Indexyz/orgs","repos_url":"https://api.github.com/users/Indexyz/repos","events_url":"https://api.github.com/users/Indexyz/events{/privacy}","received_events_url":"https://api.github.com/users/Indexyz/received_events","type":"User","site_admin":false},"repo":{"id":106918929,"name":"ArchiSteamFarm","full_name":"Indexyz/ArchiSteamFarm","owner":{"login":"Indexyz","id":7685264,"avatar_url":"https://avatars3.githubusercontent.com/u/7685264?v=4","gravatar_id":"","url":"https://api.github.com/users/Indexyz","html_url":"https://github.com/Indexyz","followers_url":"https://api.github.com/users/Indexyz/followers","following_url":"https://api.github.com/users/Indexyz/following{/other_user}","gists_url":"https://api.github.com/users/Indexyz/gists{/gist_id}","starred_url":"https://api.github.com/users/Indexyz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Indexyz/subscriptions","organizations_url":"https://api.github.com/users/Indexyz/orgs","repos_url":"https://api.github.com/users/Indexyz/repos","events_url":"https://api.github.com/users/Indexyz/events{/privacy}","received_events_url":"https://api.github.com/users/Indexyz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Indexyz/ArchiSteamFarm","description":"C# application that allows you to farm steam cards using multiple steam accounts simultaneously.","fork":true,"url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm","forks_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/forks","keys_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/teams","hooks_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/hooks","issue_events_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/issues/events{/number}","events_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/events","assignees_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/assignees{/user}","branches_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/branches{/branch}","tags_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/tags","blobs_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/statuses/{sha}","languages_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/languages","stargazers_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/stargazers","contributors_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/contributors","subscribers_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/subscribers","subscription_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/subscription","commits_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/issues/comments{/number}","contents_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/contents/{+path}","compare_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/merges","archive_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/downloads","issues_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/issues{/number}","pulls_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/pulls{/number}","milestones_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/milestones{/number}","notifications_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/labels{/name}","releases_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/releases{/id}","deployments_url":"https://api.github.com/repos/Indexyz/ArchiSteamFarm/deployments","created_at":"2017-10-14T10:28:31Z","updated_at":"2017-10-14T10:28:34Z","pushed_at":"2017-10-15T02:35:03Z","git_url":"git://github.com/Indexyz/ArchiSteamFarm.git","ssh_url":"[email protected]:Indexyz/ArchiSteamFarm.git","clone_url":"https://github.com/Indexyz/ArchiSteamFarm.git","svn_url":"https://github.com/Indexyz/ArchiSteamFarm","homepage":"","size":159723,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JustArchi:gh-pages","ref":"gh-pages","sha":"5588616ce257b2c908de77b11b981dc7d21656b3","user":{"login":"JustArchi","id":1069029,"avatar_url":"https://avatars0.githubusercontent.com/u/1069029?v=4","gravatar_id":"","url":"https://api.github.com/users/JustArchi","html_url":"https://github.com/JustArchi","followers_url":"https://api.github.com/users/JustArchi/followers","following_url":"https://api.github.com/users/JustArchi/following{/other_user}","gists_url":"https://api.github.com/users/JustArchi/gists{/gist_id}","starred_url":"https://api.github.com/users/JustArchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustArchi/subscriptions","organizations_url":"https://api.github.com/users/JustArchi/orgs","repos_url":"https://api.github.com/users/JustArchi/repos","events_url":"https://api.github.com/users/JustArchi/events{/privacy}","received_events_url":"https://api.github.com/users/JustArchi/received_events","type":"User","site_admin":false},"repo":{"id":44897462,"name":"ArchiSteamFarm","full_name":"JustArchi/ArchiSteamFarm","owner":{"login":"JustArchi","id":1069029,"avatar_url":"https://avatars0.githubusercontent.com/u/1069029?v=4","gravatar_id":"","url":"https://api.github.com/users/JustArchi","html_url":"https://github.com/JustArchi","followers_url":"https://api.github.com/users/JustArchi/followers","following_url":"https://api.github.com/users/JustArchi/following{/other_user}","gists_url":"https://api.github.com/users/JustArchi/gists{/gist_id}","starred_url":"https://api.github.com/users/JustArchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustArchi/subscriptions","organizations_url":"https://api.github.com/users/JustArchi/orgs","repos_url":"https://api.github.com/users/JustArchi/repos","events_url":"https://api.github.com/users/JustArchi/events{/privacy}","received_events_url":"https://api.github.com/users/JustArchi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JustArchi/ArchiSteamFarm","description":"C# application that allows you to farm steam cards using multiple steam accounts simultaneously.","fork":false,"url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm","forks_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/forks","keys_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/teams","hooks_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/hooks","issue_events_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/issues/events{/number}","events_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/events","assignees_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/assignees{/user}","branches_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/branches{/branch}","tags_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/tags","blobs_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/statuses/{sha}","languages_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/languages","stargazers_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/stargazers","contributors_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/contributors","subscribers_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/subscribers","subscription_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/subscription","commits_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/issues/comments{/number}","contents_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/contents/{+path}","compare_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/merges","archive_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/downloads","issues_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/issues{/number}","pulls_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/pulls{/number}","milestones_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/milestones{/number}","notifications_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/labels{/name}","releases_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/releases{/id}","deployments_url":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/deployments","created_at":"2015-10-25T05:12:33Z","updated_at":"2017-10-15T06:57:32Z","pushed_at":"2017-10-15T09:15:40Z","git_url":"git://github.com/JustArchi/ArchiSteamFarm.git","ssh_url":"[email protected]:JustArchi/ArchiSteamFarm.git","clone_url":"https://github.com/JustArchi/ArchiSteamFarm.git","svn_url":"https://github.com/JustArchi/ArchiSteamFarm","homepage":"","size":159736,"stargazers_count":1835,"watchers_count":1835,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":271,"mirror_url":null,"open_issues_count":8,"forks":271,"open_issues":8,"watchers":1835,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/pulls/674"},"html":{"href":"https://github.com/JustArchi/ArchiSteamFarm/pull/674"},"issue":{"href":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/issues/674"},"comments":{"href":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/issues/674/comments"},"review_comments":{"href":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/pulls/674/comments"},"review_comment":{"href":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/pulls/674/commits"},"statuses":{"href":"https://api.github.com/repos/JustArchi/ArchiSteamFarm/statuses/f4765d68303e51b2eef41ecfc70d0ae078bb47ea"}},"author_association":"NONE"}} | {
"id": 44897462,
"name": "JustArchi/ArchiSteamFarm",
"url": "https://api.github.com/repos/JustArchi/ArchiSteamFarm"
} | {
"id": 1069029,
"login": "JustArchi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1069029?",
"url": "https://api.github.com/users/JustArchi"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-10-15T09:17:25 | 6718180690 | {"actor":{"display_login":"JustArchi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/BadChoice/XMLDictionary/pulls/comments/151979037","pull_request_review_id":77769470,"id":151979037,"diff_hunk":"@@ -1,13 +1,13 @@\n Pod::Spec.new do |s|\n s.name = \"XMLDictionary\"","path":"XMLDictionary.podspec","position":2,"original_position":2,"commit_id":"3bd66d881028bad316aa15475009fd765becdedc","original_commit_id":"3bd66d881028bad316aa15475009fd765becdedc","user":{"login":"BadChoice","id":93900,"avatar_url":"https://avatars1.githubusercontent.com/u/93900?v=4","gravatar_id":"","url":"https://api.github.com/users/BadChoice","html_url":"https://github.com/BadChoice","followers_url":"https://api.github.com/users/BadChoice/followers","following_url":"https://api.github.com/users/BadChoice/following{/other_user}","gists_url":"https://api.github.com/users/BadChoice/gists{/gist_id}","starred_url":"https://api.github.com/users/BadChoice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BadChoice/subscriptions","organizations_url":"https://api.github.com/users/BadChoice/orgs","repos_url":"https://api.github.com/users/BadChoice/repos","events_url":"https://api.github.com/users/BadChoice/events{/privacy}","received_events_url":"https://api.github.com/users/BadChoice/received_events","type":"User","site_admin":false},"body":"Hauriem de canviar el nom, pq no faci confilice amb l'altre,\r\n`RVXMLDictionary` \r\nper exmple","created_at":"2017-11-20T12:36:23Z","updated_at":"2017-11-20T12:36:30Z","html_url":"https://github.com/BadChoice/XMLDictionary/pull/1#discussion_r151979037","pull_request_url":"https://api.github.com/repos/BadChoice/XMLDictionary/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/BadChoice/XMLDictionary/pulls/comments/151979037"},"html":{"href":"https://github.com/BadChoice/XMLDictionary/pull/1#discussion_r151979037"},"pull_request":{"href":"https://api.github.com/repos/BadChoice/XMLDictionary/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/BadChoice/XMLDictionary/pulls/1","id":153592630,"html_url":"https://github.com/BadChoice/XMLDictionary/pull/1","diff_url":"https://github.com/BadChoice/XMLDictionary/pull/1.diff","patch_url":"https://github.com/BadChoice/XMLDictionary/pull/1.patch","issue_url":"https://api.github.com/repos/BadChoice/XMLDictionary/issues/1","number":1,"state":"open","locked":false,"title":"fixed podspec","user":{"login":"draude","id":2104167,"avatar_url":"https://avatars3.githubusercontent.com/u/2104167?v=4","gravatar_id":"","url":"https://api.github.com/users/draude","html_url":"https://github.com/draude","followers_url":"https://api.github.com/users/draude/followers","following_url":"https://api.github.com/users/draude/following{/other_user}","gists_url":"https://api.github.com/users/draude/gists{/gist_id}","starred_url":"https://api.github.com/users/draude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/draude/subscriptions","organizations_url":"https://api.github.com/users/draude/orgs","repos_url":"https://api.github.com/users/draude/repos","events_url":"https://api.github.com/users/draude/events{/privacy}","received_events_url":"https://api.github.com/users/draude/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-20T10:28:12Z","updated_at":"2017-11-20T12:36:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9ceab3d03aa36f4f822df26115e43895c15ecca","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/BadChoice/XMLDictionary/pulls/1/commits","review_comments_url":"https://api.github.com/repos/BadChoice/XMLDictionary/pulls/1/comments","review_comment_url":"https://api.github.com/repos/BadChoice/XMLDictionary/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BadChoice/XMLDictionary/issues/1/comments","statuses_url":"https://api.github.com/repos/BadChoice/XMLDictionary/statuses/3bd66d881028bad316aa15475009fd765becdedc","head":{"label":"draude:master","ref":"master","sha":"3bd66d881028bad316aa15475009fd765becdedc","user":{"login":"draude","id":2104167,"avatar_url":"https://avatars3.githubusercontent.com/u/2104167?v=4","gravatar_id":"","url":"https://api.github.com/users/draude","html_url":"https://github.com/draude","followers_url":"https://api.github.com/users/draude/followers","following_url":"https://api.github.com/users/draude/following{/other_user}","gists_url":"https://api.github.com/users/draude/gists{/gist_id}","starred_url":"https://api.github.com/users/draude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/draude/subscriptions","organizations_url":"https://api.github.com/users/draude/orgs","repos_url":"https://api.github.com/users/draude/repos","events_url":"https://api.github.com/users/draude/events{/privacy}","received_events_url":"https://api.github.com/users/draude/received_events","type":"User","site_admin":false},"repo":{"id":105262751,"name":"XMLDictionary","full_name":"draude/XMLDictionary","owner":{"login":"draude","id":2104167,"avatar_url":"https://avatars3.githubusercontent.com/u/2104167?v=4","gravatar_id":"","url":"https://api.github.com/users/draude","html_url":"https://github.com/draude","followers_url":"https://api.github.com/users/draude/followers","following_url":"https://api.github.com/users/draude/following{/other_user}","gists_url":"https://api.github.com/users/draude/gists{/gist_id}","starred_url":"https://api.github.com/users/draude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/draude/subscriptions","organizations_url":"https://api.github.com/users/draude/orgs","repos_url":"https://api.github.com/users/draude/repos","events_url":"https://api.github.com/users/draude/events{/privacy}","received_events_url":"https://api.github.com/users/draude/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/draude/XMLDictionary","description":"A simple way to parse and generate XML on iOS and Mac OS. Converts an XML file to an NSDictionary which can then be easily traversed using the standard Cocoa keyPath mechanism. Can also output the contents of any dictionary as XML.","fork":true,"url":"https://api.github.com/repos/draude/XMLDictionary","forks_url":"https://api.github.com/repos/draude/XMLDictionary/forks","keys_url":"https://api.github.com/repos/draude/XMLDictionary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/draude/XMLDictionary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/draude/XMLDictionary/teams","hooks_url":"https://api.github.com/repos/draude/XMLDictionary/hooks","issue_events_url":"https://api.github.com/repos/draude/XMLDictionary/issues/events{/number}","events_url":"https://api.github.com/repos/draude/XMLDictionary/events","assignees_url":"https://api.github.com/repos/draude/XMLDictionary/assignees{/user}","branches_url":"https://api.github.com/repos/draude/XMLDictionary/branches{/branch}","tags_url":"https://api.github.com/repos/draude/XMLDictionary/tags","blobs_url":"https://api.github.com/repos/draude/XMLDictionary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/draude/XMLDictionary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/draude/XMLDictionary/git/refs{/sha}","trees_url":"https://api.github.com/repos/draude/XMLDictionary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/draude/XMLDictionary/statuses/{sha}","languages_url":"https://api.github.com/repos/draude/XMLDictionary/languages","stargazers_url":"https://api.github.com/repos/draude/XMLDictionary/stargazers","contributors_url":"https://api.github.com/repos/draude/XMLDictionary/contributors","subscribers_url":"https://api.github.com/repos/draude/XMLDictionary/subscribers","subscription_url":"https://api.github.com/repos/draude/XMLDictionary/subscription","commits_url":"https://api.github.com/repos/draude/XMLDictionary/commits{/sha}","git_commits_url":"https://api.github.com/repos/draude/XMLDictionary/git/commits{/sha}","comments_url":"https://api.github.com/repos/draude/XMLDictionary/comments{/number}","issue_comment_url":"https://api.github.com/repos/draude/XMLDictionary/issues/comments{/number}","contents_url":"https://api.github.com/repos/draude/XMLDictionary/contents/{+path}","compare_url":"https://api.github.com/repos/draude/XMLDictionary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/draude/XMLDictionary/merges","archive_url":"https://api.github.com/repos/draude/XMLDictionary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/draude/XMLDictionary/downloads","issues_url":"https://api.github.com/repos/draude/XMLDictionary/issues{/number}","pulls_url":"https://api.github.com/repos/draude/XMLDictionary/pulls{/number}","milestones_url":"https://api.github.com/repos/draude/XMLDictionary/milestones{/number}","notifications_url":"https://api.github.com/repos/draude/XMLDictionary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/draude/XMLDictionary/labels{/name}","releases_url":"https://api.github.com/repos/draude/XMLDictionary/releases{/id}","deployments_url":"https://api.github.com/repos/draude/XMLDictionary/deployments","created_at":"2017-09-29T10:59:44Z","updated_at":"2017-09-29T10:59:46Z","pushed_at":"2017-11-20T10:28:02Z","git_url":"git://github.com/draude/XMLDictionary.git","ssh_url":"[email protected]:draude/XMLDictionary.git","clone_url":"https://github.com/draude/XMLDictionary.git","svn_url":"https://github.com/draude/XMLDictionary","homepage":"http://charcoaldesign.co.uk/source/cocoa#xml-dictionary","size":52,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BadChoice:master","ref":"master","sha":"d7ddabd3cea1698489de071600629aa16efe8b0e","user":{"login":"BadChoice","id":93900,"avatar_url":"https://avatars1.githubusercontent.com/u/93900?v=4","gravatar_id":"","url":"https://api.github.com/users/BadChoice","html_url":"https://github.com/BadChoice","followers_url":"https://api.github.com/users/BadChoice/followers","following_url":"https://api.github.com/users/BadChoice/following{/other_user}","gists_url":"https://api.github.com/users/BadChoice/gists{/gist_id}","starred_url":"https://api.github.com/users/BadChoice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BadChoice/subscriptions","organizations_url":"https://api.github.com/users/BadChoice/orgs","repos_url":"https://api.github.com/users/BadChoice/repos","events_url":"https://api.github.com/users/BadChoice/events{/privacy}","received_events_url":"https://api.github.com/users/BadChoice/received_events","type":"User","site_admin":false},"repo":{"id":40191054,"name":"XMLDictionary","full_name":"BadChoice/XMLDictionary","owner":{"login":"BadChoice","id":93900,"avatar_url":"https://avatars1.githubusercontent.com/u/93900?v=4","gravatar_id":"","url":"https://api.github.com/users/BadChoice","html_url":"https://github.com/BadChoice","followers_url":"https://api.github.com/users/BadChoice/followers","following_url":"https://api.github.com/users/BadChoice/following{/other_user}","gists_url":"https://api.github.com/users/BadChoice/gists{/gist_id}","starred_url":"https://api.github.com/users/BadChoice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BadChoice/subscriptions","organizations_url":"https://api.github.com/users/BadChoice/orgs","repos_url":"https://api.github.com/users/BadChoice/repos","events_url":"https://api.github.com/users/BadChoice/events{/privacy}","received_events_url":"https://api.github.com/users/BadChoice/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BadChoice/XMLDictionary","description":"A simple way to parse and generate XML on iOS and Mac OS. Converts an XML file to an NSDictionary which can then be easily traversed using the standard Cocoa keyPath mechanism. Can also output the contents of any dictionary as XML.","fork":true,"url":"https://api.github.com/repos/BadChoice/XMLDictionary","forks_url":"https://api.github.com/repos/BadChoice/XMLDictionary/forks","keys_url":"https://api.github.com/repos/BadChoice/XMLDictionary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BadChoice/XMLDictionary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BadChoice/XMLDictionary/teams","hooks_url":"https://api.github.com/repos/BadChoice/XMLDictionary/hooks","issue_events_url":"https://api.github.com/repos/BadChoice/XMLDictionary/issues/events{/number}","events_url":"https://api.github.com/repos/BadChoice/XMLDictionary/events","assignees_url":"https://api.github.com/repos/BadChoice/XMLDictionary/assignees{/user}","branches_url":"https://api.github.com/repos/BadChoice/XMLDictionary/branches{/branch}","tags_url":"https://api.github.com/repos/BadChoice/XMLDictionary/tags","blobs_url":"https://api.github.com/repos/BadChoice/XMLDictionary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BadChoice/XMLDictionary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BadChoice/XMLDictionary/git/refs{/sha}","trees_url":"https://api.github.com/repos/BadChoice/XMLDictionary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BadChoice/XMLDictionary/statuses/{sha}","languages_url":"https://api.github.com/repos/BadChoice/XMLDictionary/languages","stargazers_url":"https://api.github.com/repos/BadChoice/XMLDictionary/stargazers","contributors_url":"https://api.github.com/repos/BadChoice/XMLDictionary/contributors","subscribers_url":"https://api.github.com/repos/BadChoice/XMLDictionary/subscribers","subscription_url":"https://api.github.com/repos/BadChoice/XMLDictionary/subscription","commits_url":"https://api.github.com/repos/BadChoice/XMLDictionary/commits{/sha}","git_commits_url":"https://api.github.com/repos/BadChoice/XMLDictionary/git/commits{/sha}","comments_url":"https://api.github.com/repos/BadChoice/XMLDictionary/comments{/number}","issue_comment_url":"https://api.github.com/repos/BadChoice/XMLDictionary/issues/comments{/number}","contents_url":"https://api.github.com/repos/BadChoice/XMLDictionary/contents/{+path}","compare_url":"https://api.github.com/repos/BadChoice/XMLDictionary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BadChoice/XMLDictionary/merges","archive_url":"https://api.github.com/repos/BadChoice/XMLDictionary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BadChoice/XMLDictionary/downloads","issues_url":"https://api.github.com/repos/BadChoice/XMLDictionary/issues{/number}","pulls_url":"https://api.github.com/repos/BadChoice/XMLDictionary/pulls{/number}","milestones_url":"https://api.github.com/repos/BadChoice/XMLDictionary/milestones{/number}","notifications_url":"https://api.github.com/repos/BadChoice/XMLDictionary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BadChoice/XMLDictionary/labels{/name}","releases_url":"https://api.github.com/repos/BadChoice/XMLDictionary/releases{/id}","deployments_url":"https://api.github.com/repos/BadChoice/XMLDictionary/deployments","created_at":"2015-08-04T14:54:10Z","updated_at":"2017-11-20T12:36:23Z","pushed_at":"2017-11-20T10:28:13Z","git_url":"git://github.com/BadChoice/XMLDictionary.git","ssh_url":"[email protected]:BadChoice/XMLDictionary.git","clone_url":"https://github.com/BadChoice/XMLDictionary.git","svn_url":"https://github.com/BadChoice/XMLDictionary","homepage":"http://charcoaldesign.co.uk/source/cocoa#xml-dictionary","size":129,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BadChoice/XMLDictionary/pulls/1"},"html":{"href":"https://github.com/BadChoice/XMLDictionary/pull/1"},"issue":{"href":"https://api.github.com/repos/BadChoice/XMLDictionary/issues/1"},"comments":{"href":"https://api.github.com/repos/BadChoice/XMLDictionary/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/BadChoice/XMLDictionary/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/BadChoice/XMLDictionary/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BadChoice/XMLDictionary/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/BadChoice/XMLDictionary/statuses/3bd66d881028bad316aa15475009fd765becdedc"}},"author_association":"NONE"}} | {
"id": 40191054,
"name": "BadChoice/XMLDictionary",
"url": "https://api.github.com/repos/BadChoice/XMLDictionary"
} | {
"id": 93900,
"login": "BadChoice",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/93900?",
"url": "https://api.github.com/users/BadChoice"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-11-20T12:36:23 | 6878608956 | {"actor":{"display_login":"BadChoice"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/101604864","pull_request_review_id":22339809,"id":101604864,"diff_hunk":"@@ -44,16 +46,27 @@ TORRENT_TEST(dht_get_peers_reply_alert)\n \tTEST_EQUAL(mgr.should_post<dht_get_peers_reply_alert>(), true);\n \n \tsha1_hash const ih = rand_hash();\n-\ttcp::endpoint const ep1 = rand_tcp_ep();\n-\ttcp::endpoint const ep2 = rand_tcp_ep();\n-\tstd::vector<tcp::endpoint> const v = {ep1, ep2};\n+\ttcp::endpoint const ep1 = rand_tcp_ep(rand_v4);\n+\ttcp::endpoint const ep2 = rand_tcp_ep(rand_v4);\n+\ttcp::endpoint const ep3 = rand_tcp_ep(rand_v4);\n+#if TORRENT_USE_IPV6\n+\ttcp::endpoint const ep4 = rand_tcp_ep(rand_v6);\n+\ttcp::endpoint const ep5 = rand_tcp_ep(rand_v6);\n+#else\n+\ttcp::endpoint const ep4 = rand_tcp_ep(rand_v4);\n+\ttcp::endpoint const ep5 = rand_tcp_ep(rand_v4);\n+#endif\n+\tstd::vector<tcp::endpoint> const v = {ep1, ep2, ep3, ep4, ep5};\n \n \tmgr.emplace_alert<dht_get_peers_reply_alert>(ih, v);\n \n \tauto const* a = alert_cast<dht_get_peers_reply_alert>(mgr.wait_for_alert(seconds(0)));\n \tTEST_CHECK(a != nullptr);\n \n \tTEST_EQUAL(a->info_hash, ih);\n-\tTEST_EQUAL(a->num_peers(), 2);\n-\tTEST_CHECK(a->peers() == v);\n+\tTEST_EQUAL(a->num_peers(), 5);\n+\n+\tstd::vector<tcp::endpoint> const peers = a->peers();\n+\tTEST_EQUAL(peers.size(), 5);\n+\tTEST_CHECK(std::includes(peers.begin(), peers.end(), v.begin(), v.end()));","path":"test/test_alert_types.cpp","position":71,"original_position":40,"commit_id":"229d8d699d57a9ad45c1ce521249c625ab461c87","original_commit_id":"229d8d699d57a9ad45c1ce521249c625ab461c87","user":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"body":"my understanding is that ``std::includes()`` requires the ranges to be sorted","created_at":"2017-02-16T19:24:41Z","updated_at":"2017-02-16T19:24:41Z","html_url":"https://github.com/arvidn/libtorrent/pull/1714#discussion_r101604864","pull_request_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1714","_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/101604864"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/1714#discussion_r101604864"},"pull_request":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1714"}}},"pull_request":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1714","id":106350593,"html_url":"https://github.com/arvidn/libtorrent/pull/1714","diff_url":"https://github.com/arvidn/libtorrent/pull/1714.diff","patch_url":"https://github.com/arvidn/libtorrent/pull/1714.patch","issue_url":"https://api.github.com/repos/arvidn/libtorrent/issues/1714","number":1714,"state":"open","locked":false,"title":"optimized dht_get_peers_reply_alert storage and created alerts unit test","user":{"login":"aldenml","id":143813,"avatar_url":"https://avatars.githubusercontent.com/u/143813?v=3","gravatar_id":"","url":"https://api.github.com/users/aldenml","html_url":"https://github.com/aldenml","followers_url":"https://api.github.com/users/aldenml/followers","following_url":"https://api.github.com/users/aldenml/following{/other_user}","gists_url":"https://api.github.com/users/aldenml/gists{/gist_id}","starred_url":"https://api.github.com/users/aldenml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldenml/subscriptions","organizations_url":"https://api.github.com/users/aldenml/orgs","repos_url":"https://api.github.com/users/aldenml/repos","events_url":"https://api.github.com/users/aldenml/events{/privacy}","received_events_url":"https://api.github.com/users/aldenml/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-15T16:45:23Z","updated_at":"2017-02-16T19:24:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6d4ccc8f28a90e3fcb3ce07a251a5b538a9ddda","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1714/commits","review_comments_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1714/comments","review_comment_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/issues/1714/comments","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/229d8d699d57a9ad45c1ce521249c625ab461c87","head":{"label":"aldenml:test-alerts-1.2","ref":"test-alerts-1.2","sha":"229d8d699d57a9ad45c1ce521249c625ab461c87","user":{"login":"aldenml","id":143813,"avatar_url":"https://avatars.githubusercontent.com/u/143813?v=3","gravatar_id":"","url":"https://api.github.com/users/aldenml","html_url":"https://github.com/aldenml","followers_url":"https://api.github.com/users/aldenml/followers","following_url":"https://api.github.com/users/aldenml/following{/other_user}","gists_url":"https://api.github.com/users/aldenml/gists{/gist_id}","starred_url":"https://api.github.com/users/aldenml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldenml/subscriptions","organizations_url":"https://api.github.com/users/aldenml/orgs","repos_url":"https://api.github.com/users/aldenml/repos","events_url":"https://api.github.com/users/aldenml/events{/privacy}","received_events_url":"https://api.github.com/users/aldenml/received_events","type":"User","site_admin":false},"repo":{"id":37677407,"name":"libtorrent","full_name":"aldenml/libtorrent","owner":{"login":"aldenml","id":143813,"avatar_url":"https://avatars.githubusercontent.com/u/143813?v=3","gravatar_id":"","url":"https://api.github.com/users/aldenml","html_url":"https://github.com/aldenml","followers_url":"https://api.github.com/users/aldenml/followers","following_url":"https://api.github.com/users/aldenml/following{/other_user}","gists_url":"https://api.github.com/users/aldenml/gists{/gist_id}","starred_url":"https://api.github.com/users/aldenml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldenml/subscriptions","organizations_url":"https://api.github.com/users/aldenml/orgs","repos_url":"https://api.github.com/users/aldenml/repos","events_url":"https://api.github.com/users/aldenml/events{/privacy}","received_events_url":"https://api.github.com/users/aldenml/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aldenml/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":true,"url":"https://api.github.com/repos/aldenml/libtorrent","forks_url":"https://api.github.com/repos/aldenml/libtorrent/forks","keys_url":"https://api.github.com/repos/aldenml/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aldenml/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aldenml/libtorrent/teams","hooks_url":"https://api.github.com/repos/aldenml/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/aldenml/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/aldenml/libtorrent/events","assignees_url":"https://api.github.com/repos/aldenml/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/aldenml/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/aldenml/libtorrent/tags","blobs_url":"https://api.github.com/repos/aldenml/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aldenml/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aldenml/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/aldenml/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aldenml/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/aldenml/libtorrent/languages","stargazers_url":"https://api.github.com/repos/aldenml/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/aldenml/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/aldenml/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/aldenml/libtorrent/subscription","commits_url":"https://api.github.com/repos/aldenml/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/aldenml/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/aldenml/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/aldenml/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/aldenml/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/aldenml/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aldenml/libtorrent/merges","archive_url":"https://api.github.com/repos/aldenml/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aldenml/libtorrent/downloads","issues_url":"https://api.github.com/repos/aldenml/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/aldenml/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/aldenml/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/aldenml/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aldenml/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/aldenml/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/aldenml/libtorrent/deployments","created_at":"2015-06-18T18:31:58Z","updated_at":"2016-01-11T13:58:25Z","pushed_at":"2017-02-16T16:29:28Z","git_url":"git://github.com/aldenml/libtorrent.git","ssh_url":"[email protected]:aldenml/libtorrent.git","clone_url":"https://github.com/aldenml/libtorrent.git","svn_url":"https://github.com/aldenml/libtorrent","homepage":"http://libtorrent.org","size":45718,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arvidn:master","ref":"master","sha":"f407d85349c69303d37bfabffe3ccf7fbc4caa44","user":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"repo":{"id":36781769,"name":"libtorrent","full_name":"arvidn/libtorrent","owner":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arvidn/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":false,"url":"https://api.github.com/repos/arvidn/libtorrent","forks_url":"https://api.github.com/repos/arvidn/libtorrent/forks","keys_url":"https://api.github.com/repos/arvidn/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arvidn/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arvidn/libtorrent/teams","hooks_url":"https://api.github.com/repos/arvidn/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/arvidn/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/arvidn/libtorrent/events","assignees_url":"https://api.github.com/repos/arvidn/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/arvidn/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/arvidn/libtorrent/tags","blobs_url":"https://api.github.com/repos/arvidn/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arvidn/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arvidn/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/arvidn/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/arvidn/libtorrent/languages","stargazers_url":"https://api.github.com/repos/arvidn/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/arvidn/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/arvidn/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/arvidn/libtorrent/subscription","commits_url":"https://api.github.com/repos/arvidn/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/arvidn/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/arvidn/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/arvidn/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/arvidn/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arvidn/libtorrent/merges","archive_url":"https://api.github.com/repos/arvidn/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arvidn/libtorrent/downloads","issues_url":"https://api.github.com/repos/arvidn/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/arvidn/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/arvidn/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/arvidn/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arvidn/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/arvidn/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/arvidn/libtorrent/deployments","created_at":"2015-06-03T05:22:03Z","updated_at":"2017-02-16T03:30:20Z","pushed_at":"2017-02-16T16:29:30Z","git_url":"git://github.com/arvidn/libtorrent.git","ssh_url":"[email protected]:arvidn/libtorrent.git","clone_url":"https://github.com/arvidn/libtorrent.git","svn_url":"https://github.com/arvidn/libtorrent","homepage":"http://libtorrent.org","size":67433,"stargazers_count":686,"watchers_count":686,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":223,"mirror_url":null,"open_issues_count":98,"forks":223,"open_issues":98,"watchers":686,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1714"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/1714"},"issue":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/1714"},"comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/1714/comments"},"review_comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1714/comments"},"review_comment":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1714/commits"},"statuses":{"href":"https://api.github.com/repos/arvidn/libtorrent/statuses/229d8d699d57a9ad45c1ce521249c625ab461c87"}}}} | {
"id": 36781769,
"name": "arvidn/libtorrent",
"url": "https://api.github.com/repos/arvidn/libtorrent"
} | {
"id": 661450,
"login": "arvidn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/661450?",
"url": "https://api.github.com/users/arvidn"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-02-16T19:24:41 | 5339069078 | {"actor":{"display_login":"arvidn"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/pulls/comments/112179125","pull_request_review_id":33472268,"id":112179125,"diff_hunk":"@@ -18,10 +26,47 @@ def create\n end\n end\n \n+ def edit\n+ @user = User.find params[:id]\n+ end\n+\n+ def update\n+ @user = User.find params[:id]","path":"app/controllers/users_controller.rb","position":26,"original_position":26,"commit_id":"28a95ef35f50a39aa604aea64f31b207331fe31a","original_commit_id":"28a95ef35f50a39aa604aea64f31b207331fe31a","user":{"login":"dat-hedspi","id":14577773,"avatar_url":"https://avatars0.githubusercontent.com/u/14577773?v=3","gravatar_id":"","url":"https://api.github.com/users/dat-hedspi","html_url":"https://github.com/dat-hedspi","followers_url":"https://api.github.com/users/dat-hedspi/followers","following_url":"https://api.github.com/users/dat-hedspi/following{/other_user}","gists_url":"https://api.github.com/users/dat-hedspi/gists{/gist_id}","starred_url":"https://api.github.com/users/dat-hedspi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dat-hedspi/subscriptions","organizations_url":"https://api.github.com/users/dat-hedspi/orgs","repos_url":"https://api.github.com/users/dat-hedspi/repos","events_url":"https://api.github.com/users/dat-hedspi/events{/privacy}","received_events_url":"https://api.github.com/users/dat-hedspi/received_events","type":"User","site_admin":false},"body":"tương tự nhé, tìm kiếm bằng filter và trả ra lỗi nếu không tìm thấy nhé","created_at":"2017-04-19T11:41:29Z","updated_at":"2017-04-19T11:43:05Z","html_url":"https://github.com/hellovietnam93/Try_hard_59/pull/121#discussion_r112179125","pull_request_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/pulls/121","_links":{"self":{"href":"https://api.github.com/repos/hellovietnam93/Try_hard_59/pulls/comments/112179125"},"html":{"href":"https://github.com/hellovietnam93/Try_hard_59/pull/121#discussion_r112179125"},"pull_request":{"href":"https://api.github.com/repos/hellovietnam93/Try_hard_59/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/pulls/121","id":116527277,"html_url":"https://github.com/hellovietnam93/Try_hard_59/pull/121","diff_url":"https://github.com/hellovietnam93/Try_hard_59/pull/121.diff","patch_url":"https://github.com/hellovietnam93/Try_hard_59/pull/121.patch","issue_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/issues/121","number":121,"state":"open","locked":false,"title":"Finish user edit, update, index, and destroy actions","user":{"login":"tardigrades2","id":22081048,"avatar_url":"https://avatars0.githubusercontent.com/u/22081048?v=3","gravatar_id":"","url":"https://api.github.com/users/tardigrades2","html_url":"https://github.com/tardigrades2","followers_url":"https://api.github.com/users/tardigrades2/followers","following_url":"https://api.github.com/users/tardigrades2/following{/other_user}","gists_url":"https://api.github.com/users/tardigrades2/gists{/gist_id}","starred_url":"https://api.github.com/users/tardigrades2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardigrades2/subscriptions","organizations_url":"https://api.github.com/users/tardigrades2/orgs","repos_url":"https://api.github.com/users/tardigrades2/repos","events_url":"https://api.github.com/users/tardigrades2/events{/privacy}","received_events_url":"https://api.github.com/users/tardigrades2/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-19T11:36:46Z","updated_at":"2017-04-19T11:43:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9fd2163fc4fa14c57cb3bf853f2fb8c73f3f3aa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/pulls/121/commits","review_comments_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/pulls/121/comments","review_comment_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/issues/121/comments","statuses_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/statuses/28a95ef35f50a39aa604aea64f31b207331fe31a","head":{"label":"tardigrades2:updating-users","ref":"updating-users","sha":"28a95ef35f50a39aa604aea64f31b207331fe31a","user":{"login":"tardigrades2","id":22081048,"avatar_url":"https://avatars0.githubusercontent.com/u/22081048?v=3","gravatar_id":"","url":"https://api.github.com/users/tardigrades2","html_url":"https://github.com/tardigrades2","followers_url":"https://api.github.com/users/tardigrades2/followers","following_url":"https://api.github.com/users/tardigrades2/following{/other_user}","gists_url":"https://api.github.com/users/tardigrades2/gists{/gist_id}","starred_url":"https://api.github.com/users/tardigrades2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardigrades2/subscriptions","organizations_url":"https://api.github.com/users/tardigrades2/orgs","repos_url":"https://api.github.com/users/tardigrades2/repos","events_url":"https://api.github.com/users/tardigrades2/events{/privacy}","received_events_url":"https://api.github.com/users/tardigrades2/received_events","type":"User","site_admin":false},"repo":{"id":85818265,"name":"Try_hard_59","full_name":"tardigrades2/Try_hard_59","owner":{"login":"tardigrades2","id":22081048,"avatar_url":"https://avatars0.githubusercontent.com/u/22081048?v=3","gravatar_id":"","url":"https://api.github.com/users/tardigrades2","html_url":"https://github.com/tardigrades2","followers_url":"https://api.github.com/users/tardigrades2/followers","following_url":"https://api.github.com/users/tardigrades2/following{/other_user}","gists_url":"https://api.github.com/users/tardigrades2/gists{/gist_id}","starred_url":"https://api.github.com/users/tardigrades2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardigrades2/subscriptions","organizations_url":"https://api.github.com/users/tardigrades2/orgs","repos_url":"https://api.github.com/users/tardigrades2/repos","events_url":"https://api.github.com/users/tardigrades2/events{/privacy}","received_events_url":"https://api.github.com/users/tardigrades2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tardigrades2/Try_hard_59","description":null,"fork":true,"url":"https://api.github.com/repos/tardigrades2/Try_hard_59","forks_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/forks","keys_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/teams","hooks_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/hooks","issue_events_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/issues/events{/number}","events_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/events","assignees_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/assignees{/user}","branches_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/branches{/branch}","tags_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/tags","blobs_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/git/refs{/sha}","trees_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/statuses/{sha}","languages_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/languages","stargazers_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/stargazers","contributors_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/contributors","subscribers_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/subscribers","subscription_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/subscription","commits_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/commits{/sha}","git_commits_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/git/commits{/sha}","comments_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/comments{/number}","issue_comment_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/issues/comments{/number}","contents_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/contents/{+path}","compare_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/merges","archive_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/downloads","issues_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/issues{/number}","pulls_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/pulls{/number}","milestones_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/milestones{/number}","notifications_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/labels{/name}","releases_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/releases{/id}","deployments_url":"https://api.github.com/repos/tardigrades2/Try_hard_59/deployments","created_at":"2017-03-22T11:08:30Z","updated_at":"2017-03-22T10:51:11Z","pushed_at":"2017-04-19T10:46:02Z","git_url":"git://github.com/tardigrades2/Try_hard_59.git","ssh_url":"[email protected]:tardigrades2/Try_hard_59.git","clone_url":"https://github.com/tardigrades2/Try_hard_59.git","svn_url":"https://github.com/tardigrades2/Try_hard_59","homepage":null,"size":300,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hellovietnam93:20142349_Hoang_Viet_Khoa","ref":"20142349_Hoang_Viet_Khoa","sha":"1dca31199da0441dedbb4edf287c0c608225f538","user":{"login":"hellovietnam93","id":8023606,"avatar_url":"https://avatars2.githubusercontent.com/u/8023606?v=3","gravatar_id":"","url":"https://api.github.com/users/hellovietnam93","html_url":"https://github.com/hellovietnam93","followers_url":"https://api.github.com/users/hellovietnam93/followers","following_url":"https://api.github.com/users/hellovietnam93/following{/other_user}","gists_url":"https://api.github.com/users/hellovietnam93/gists{/gist_id}","starred_url":"https://api.github.com/users/hellovietnam93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellovietnam93/subscriptions","organizations_url":"https://api.github.com/users/hellovietnam93/orgs","repos_url":"https://api.github.com/users/hellovietnam93/repos","events_url":"https://api.github.com/users/hellovietnam93/events{/privacy}","received_events_url":"https://api.github.com/users/hellovietnam93/received_events","type":"User","site_admin":false},"repo":{"id":85816771,"name":"Try_hard_59","full_name":"hellovietnam93/Try_hard_59","owner":{"login":"hellovietnam93","id":8023606,"avatar_url":"https://avatars2.githubusercontent.com/u/8023606?v=3","gravatar_id":"","url":"https://api.github.com/users/hellovietnam93","html_url":"https://github.com/hellovietnam93","followers_url":"https://api.github.com/users/hellovietnam93/followers","following_url":"https://api.github.com/users/hellovietnam93/following{/other_user}","gists_url":"https://api.github.com/users/hellovietnam93/gists{/gist_id}","starred_url":"https://api.github.com/users/hellovietnam93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellovietnam93/subscriptions","organizations_url":"https://api.github.com/users/hellovietnam93/orgs","repos_url":"https://api.github.com/users/hellovietnam93/repos","events_url":"https://api.github.com/users/hellovietnam93/events{/privacy}","received_events_url":"https://api.github.com/users/hellovietnam93/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hellovietnam93/Try_hard_59","description":null,"fork":false,"url":"https://api.github.com/repos/hellovietnam93/Try_hard_59","forks_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/forks","keys_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/teams","hooks_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/hooks","issue_events_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/issues/events{/number}","events_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/events","assignees_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/assignees{/user}","branches_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/branches{/branch}","tags_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/tags","blobs_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/git/refs{/sha}","trees_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/statuses/{sha}","languages_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/languages","stargazers_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/stargazers","contributors_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/contributors","subscribers_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/subscribers","subscription_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/subscription","commits_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/commits{/sha}","git_commits_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/git/commits{/sha}","comments_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/comments{/number}","issue_comment_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/issues/comments{/number}","contents_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/contents/{+path}","compare_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/merges","archive_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/downloads","issues_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/issues{/number}","pulls_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/pulls{/number}","milestones_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/milestones{/number}","notifications_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/labels{/name}","releases_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/releases{/id}","deployments_url":"https://api.github.com/repos/hellovietnam93/Try_hard_59/deployments","created_at":"2017-03-22T10:51:11Z","updated_at":"2017-04-18T14:20:45Z","pushed_at":"2017-04-19T11:42:45Z","git_url":"git://github.com/hellovietnam93/Try_hard_59.git","ssh_url":"[email protected]:hellovietnam93/Try_hard_59.git","clone_url":"https://github.com/hellovietnam93/Try_hard_59.git","svn_url":"https://github.com/hellovietnam93/Try_hard_59","homepage":null,"size":785,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":15,"forks":21,"open_issues":15,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hellovietnam93/Try_hard_59/pulls/121"},"html":{"href":"https://github.com/hellovietnam93/Try_hard_59/pull/121"},"issue":{"href":"https://api.github.com/repos/hellovietnam93/Try_hard_59/issues/121"},"comments":{"href":"https://api.github.com/repos/hellovietnam93/Try_hard_59/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/hellovietnam93/Try_hard_59/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/hellovietnam93/Try_hard_59/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hellovietnam93/Try_hard_59/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/hellovietnam93/Try_hard_59/statuses/28a95ef35f50a39aa604aea64f31b207331fe31a"}}}} | {
"id": 85816771,
"name": "hellovietnam93/Try_hard_59",
"url": "https://api.github.com/repos/hellovietnam93/Try_hard_59"
} | {
"id": 14577773,
"login": "dat-hedspi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14577773?",
"url": "https://api.github.com/users/dat-hedspi"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-04-19T11:41:29 | 5714896691 | {"actor":{"display_login":"dat-hedspi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/pulls/comments/148405952","pull_request_review_id":73643650,"id":148405952,"diff_hunk":"@@ -0,0 +1,89 @@\n+<?php\n+\n+$root = realpath($_SERVER[\"DOCUMENT_ROOT\"]);\n+\n+require_once \"$root/server/user.class.php\";\n+$USER = new User();\n+if (!$USER->hasPermission('edit_user_permission')) {\n+\theader(\"Location: /unauthorized\");\n+\tdie();\n+}\n+\n+?>\n+\n+<!DOCTYPE html>\n+<html class=\"no-js\" lang=\"\">\n+<head>\n+\t<title>Queue Test</title>\n+\t<?php require_once \"$root/server/header.php\" ?>\n+\t<link rel=\"stylesheet\" href=\"https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css\" />\n+\t<link rel=\"stylesheet\" href=\"https://cdnjs.cloudflare.com/ajax/libs/bootstrap-select/1.12.4/css/bootstrap-select.min.css\" />\n+\t<link rel=\"stylesheet\" href=\"user.css\" />\n+</head>\n+<body>\n+\t<?php require_once \"$root/components/nav.php\"; ?>\n+\t<div class=\"container\">\n+\t\t<div class=\"row\">\n+\t\t\t<div class=\"col-md-9\">\n+\t\t\t\t<h1>User Management</h1>\n+\t\t\t</div>\n+\t\t\t<div class=\"col-md-3\">\n+\t\t\t\t<button class=\"btn btn-default pull-right\" id=\"btn-add-user\">Add User</button>\n+\t\t\t</div>\n+\t\t</div>\n+\t\t<div class=\"row\">","path":"manage/user/index.php","position":null,"original_position":34,"commit_id":"13ef47956b4443490eadaa7b05c314f40a23923c","original_commit_id":"7aa52aac9f63af962d75572ec57df3c2553b4f77","user":{"login":"2mnyzs","id":6033112,"avatar_url":"https://avatars3.githubusercontent.com/u/6033112?v=4","gravatar_id":"","url":"https://api.github.com/users/2mnyzs","html_url":"https://github.com/2mnyzs","followers_url":"https://api.github.com/users/2mnyzs/followers","following_url":"https://api.github.com/users/2mnyzs/following{/other_user}","gists_url":"https://api.github.com/users/2mnyzs/gists{/gist_id}","starred_url":"https://api.github.com/users/2mnyzs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2mnyzs/subscriptions","organizations_url":"https://api.github.com/users/2mnyzs/orgs","repos_url":"https://api.github.com/users/2mnyzs/repos","events_url":"https://api.github.com/users/2mnyzs/events{/privacy}","received_events_url":"https://api.github.com/users/2mnyzs/received_events","type":"User","site_admin":false},"body":"Done\r\n","created_at":"2017-11-01T22:51:00Z","updated_at":"2017-11-01T22:51:00Z","html_url":"https://github.com/UNL-CSE-AMBASSADORS/VITA/pull/104#discussion_r148405952","pull_request_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/pulls/104","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/pulls/comments/148405952"},"html":{"href":"https://github.com/UNL-CSE-AMBASSADORS/VITA/pull/104#discussion_r148405952"},"pull_request":{"href":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/pulls/104"}},"in_reply_to_id":147043701},"pull_request":{"url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/pulls/104","id":148257200,"html_url":"https://github.com/UNL-CSE-AMBASSADORS/VITA/pull/104","diff_url":"https://github.com/UNL-CSE-AMBASSADORS/VITA/pull/104.diff","patch_url":"https://github.com/UNL-CSE-AMBASSADORS/VITA/pull/104.patch","issue_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/issues/104","number":104,"state":"open","locked":false,"title":"Permission(s) Control and Adding Users","user":{"login":"2mnyzs","id":6033112,"avatar_url":"https://avatars3.githubusercontent.com/u/6033112?v=4","gravatar_id":"","url":"https://api.github.com/users/2mnyzs","html_url":"https://github.com/2mnyzs","followers_url":"https://api.github.com/users/2mnyzs/followers","following_url":"https://api.github.com/users/2mnyzs/following{/other_user}","gists_url":"https://api.github.com/users/2mnyzs/gists{/gist_id}","starred_url":"https://api.github.com/users/2mnyzs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2mnyzs/subscriptions","organizations_url":"https://api.github.com/users/2mnyzs/orgs","repos_url":"https://api.github.com/users/2mnyzs/repos","events_url":"https://api.github.com/users/2mnyzs/events{/privacy}","received_events_url":"https://api.github.com/users/2mnyzs/received_events","type":"User","site_admin":false},"body":"Added a page: /manage/user that lets people with Edit_User_Permission to edit permissions as well as add new users to the system.\r\n\r\nTo test: a constraint was added to the permission table that prevents a permission for one user to appear more than once. Please add this constraint before testing, Then simply log in with the [email protected]:test user account and go to the manage user page. On the page simply click on a dropdown and then click a permission to add or remove it. Also try adding a user in the top right and then giving it some permissions.\r\n\r\nA note on the css: the majority of it comes from the linked place to make the pretty bootstrap-select work with V4. I've noticed no issues with it but something to keep in mind.","created_at":"2017-10-23T22:37:47Z","updated_at":"2017-11-01T22:51:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc825b8f2140486838010a53ddb3ef51aabaccf7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/pulls/104/commits","review_comments_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/pulls/104/comments","review_comment_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/issues/104/comments","statuses_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/statuses/13ef47956b4443490eadaa7b05c314f40a23923c","head":{"label":"UNL-CSE-AMBASSADORS:User_Test_Page","ref":"User_Test_Page","sha":"13ef47956b4443490eadaa7b05c314f40a23923c","user":{"login":"UNL-CSE-AMBASSADORS","id":23513331,"avatar_url":"https://avatars1.githubusercontent.com/u/23513331?v=4","gravatar_id":"","url":"https://api.github.com/users/UNL-CSE-AMBASSADORS","html_url":"https://github.com/UNL-CSE-AMBASSADORS","followers_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/followers","following_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/following{/other_user}","gists_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/gists{/gist_id}","starred_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/subscriptions","organizations_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/orgs","repos_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/repos","events_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/events{/privacy}","received_events_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/received_events","type":"User","site_admin":false},"repo":{"id":79863911,"name":"VITA","full_name":"UNL-CSE-AMBASSADORS/VITA","owner":{"login":"UNL-CSE-AMBASSADORS","id":23513331,"avatar_url":"https://avatars1.githubusercontent.com/u/23513331?v=4","gravatar_id":"","url":"https://api.github.com/users/UNL-CSE-AMBASSADORS","html_url":"https://github.com/UNL-CSE-AMBASSADORS","followers_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/followers","following_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/following{/other_user}","gists_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/gists{/gist_id}","starred_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/subscriptions","organizations_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/orgs","repos_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/repos","events_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/events{/privacy}","received_events_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/UNL-CSE-AMBASSADORS/VITA","description":null,"fork":false,"url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA","forks_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/forks","keys_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/teams","hooks_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/hooks","issue_events_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/issues/events{/number}","events_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/events","assignees_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/assignees{/user}","branches_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/branches{/branch}","tags_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/tags","blobs_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/git/refs{/sha}","trees_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/statuses/{sha}","languages_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/languages","stargazers_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/stargazers","contributors_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/contributors","subscribers_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/subscribers","subscription_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/subscription","commits_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/commits{/sha}","git_commits_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/git/commits{/sha}","comments_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/comments{/number}","issue_comment_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/issues/comments{/number}","contents_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/contents/{+path}","compare_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/merges","archive_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/downloads","issues_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/issues{/number}","pulls_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/pulls{/number}","milestones_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/milestones{/number}","notifications_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/labels{/name}","releases_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/releases{/id}","deployments_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/deployments","created_at":"2017-01-24T00:35:16Z","updated_at":"2017-07-30T23:23:42Z","pushed_at":"2017-11-01T22:50:45Z","git_url":"git://github.com/UNL-CSE-AMBASSADORS/VITA.git","ssh_url":"[email protected]:UNL-CSE-AMBASSADORS/VITA.git","clone_url":"https://github.com/UNL-CSE-AMBASSADORS/VITA.git","svn_url":"https://github.com/UNL-CSE-AMBASSADORS/VITA","homepage":null,"size":787,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":31,"forks":0,"open_issues":31,"watchers":2,"default_branch":"dev"}},"base":{"label":"UNL-CSE-AMBASSADORS:dev","ref":"dev","sha":"4b261d745fb49402a6ff232eb2b9e9c74e1cb435","user":{"login":"UNL-CSE-AMBASSADORS","id":23513331,"avatar_url":"https://avatars1.githubusercontent.com/u/23513331?v=4","gravatar_id":"","url":"https://api.github.com/users/UNL-CSE-AMBASSADORS","html_url":"https://github.com/UNL-CSE-AMBASSADORS","followers_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/followers","following_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/following{/other_user}","gists_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/gists{/gist_id}","starred_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/subscriptions","organizations_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/orgs","repos_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/repos","events_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/events{/privacy}","received_events_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/received_events","type":"User","site_admin":false},"repo":{"id":79863911,"name":"VITA","full_name":"UNL-CSE-AMBASSADORS/VITA","owner":{"login":"UNL-CSE-AMBASSADORS","id":23513331,"avatar_url":"https://avatars1.githubusercontent.com/u/23513331?v=4","gravatar_id":"","url":"https://api.github.com/users/UNL-CSE-AMBASSADORS","html_url":"https://github.com/UNL-CSE-AMBASSADORS","followers_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/followers","following_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/following{/other_user}","gists_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/gists{/gist_id}","starred_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/subscriptions","organizations_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/orgs","repos_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/repos","events_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/events{/privacy}","received_events_url":"https://api.github.com/users/UNL-CSE-AMBASSADORS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/UNL-CSE-AMBASSADORS/VITA","description":null,"fork":false,"url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA","forks_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/forks","keys_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/teams","hooks_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/hooks","issue_events_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/issues/events{/number}","events_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/events","assignees_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/assignees{/user}","branches_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/branches{/branch}","tags_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/tags","blobs_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/git/refs{/sha}","trees_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/statuses/{sha}","languages_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/languages","stargazers_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/stargazers","contributors_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/contributors","subscribers_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/subscribers","subscription_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/subscription","commits_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/commits{/sha}","git_commits_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/git/commits{/sha}","comments_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/comments{/number}","issue_comment_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/issues/comments{/number}","contents_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/contents/{+path}","compare_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/merges","archive_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/downloads","issues_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/issues{/number}","pulls_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/pulls{/number}","milestones_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/milestones{/number}","notifications_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/labels{/name}","releases_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/releases{/id}","deployments_url":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/deployments","created_at":"2017-01-24T00:35:16Z","updated_at":"2017-07-30T23:23:42Z","pushed_at":"2017-11-01T22:50:45Z","git_url":"git://github.com/UNL-CSE-AMBASSADORS/VITA.git","ssh_url":"[email protected]:UNL-CSE-AMBASSADORS/VITA.git","clone_url":"https://github.com/UNL-CSE-AMBASSADORS/VITA.git","svn_url":"https://github.com/UNL-CSE-AMBASSADORS/VITA","homepage":null,"size":787,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":31,"forks":0,"open_issues":31,"watchers":2,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/pulls/104"},"html":{"href":"https://github.com/UNL-CSE-AMBASSADORS/VITA/pull/104"},"issue":{"href":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/issues/104"},"comments":{"href":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA/statuses/13ef47956b4443490eadaa7b05c314f40a23923c"}},"author_association":"COLLABORATOR"}} | {
"id": 79863911,
"name": "UNL-CSE-AMBASSADORS/VITA",
"url": "https://api.github.com/repos/UNL-CSE-AMBASSADORS/VITA"
} | {
"id": 6033112,
"login": "2mnyzs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6033112?",
"url": "https://api.github.com/users/2mnyzs"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-11-01T22:51:00 | 6797426162 | {"actor":{"display_login":"2mnyzs"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/koraktor/braumeister.org/pulls/comments/135397632","pull_request_review_id":58809496,"id":135397632,"diff_hunk":"@@ -372,65 +283,59 @@ div#home {\n }\n \n & + h2 {\n- color: $orange;\n+ color: $color_peach_orange_approx;\n font-size: 1.3em;\n margin-top: 0.5em;\n text-align: center;\n }\n }\n \n-div#social {\n- float: left;\n- font-size: 10pt;\n- line-height: 1em;\n-}\n-\n-div#header div#social {\n- margin: 5em 0 0 2em;\n+div#status {\n+ text-align: center;\n+ padding-bottom: 2em;\n }\n \n div#timestamps {\n- color: $sand;\n- font-family: 'Helvetica', sans-serif;\n- font-size: 9pt;\n- padding-bottom: 2em !important;\n+ color: $color_peach_orange_approx;\n+ text-align: center;\n }\n \n div.listing {\n- @include border-radius(4px);\n+ margin: 0.5em 1em;\n+ text-align: center;\n+}\n \n- margin: 0.5em !important;\n- padding: 0 !important;\n+div.listing.browse {\n+ margin-top: 1em;\n+ margin-bottom: 2em;\n+ margin-left: 5.5em;\n }\n \n-div.recently-added h3 {\n- color: #44cc44;\n+.browse .desc {\n+ margin-left: 0.5em;","path":"app/assets/stylesheets/application.scss","position":472,"original_position":472,"commit_id":"b14c27849d084a1a59cc8b02c0d73be5ecef5dba","original_commit_id":"b14c27849d084a1a59cc8b02c0d73be5ecef5dba","user":{"login":"koraktor","id":66112,"avatar_url":"https://avatars2.githubusercontent.com/u/66112?v=4","gravatar_id":"","url":"https://api.github.com/users/koraktor","html_url":"https://github.com/koraktor","followers_url":"https://api.github.com/users/koraktor/followers","following_url":"https://api.github.com/users/koraktor/following{/other_user}","gists_url":"https://api.github.com/users/koraktor/gists{/gist_id}","starred_url":"https://api.github.com/users/koraktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koraktor/subscriptions","organizations_url":"https://api.github.com/users/koraktor/orgs","repos_url":"https://api.github.com/users/koraktor/repos","events_url":"https://api.github.com/users/koraktor/events{/privacy}","received_events_url":"https://api.github.com/users/koraktor/received_events","type":"User","site_admin":false},"body":"```patch\r\n+ color: $color_di_serria_approx;\r\n```\r\n\r\nWhat do you think? IMHO this reduces noise on the lists a lot without trying to align and restructure everything.\r\nThe latter would require two columns (most probably 50%/50%) which would add a lot of whitespace for most formulae because a few with really long names. I don’t like that idea a lot, either.","created_at":"2017-08-26T21:01:18Z","updated_at":"2017-08-26T21:01:18Z","html_url":"https://github.com/koraktor/braumeister.org/pull/48#discussion_r135397632","pull_request_url":"https://api.github.com/repos/koraktor/braumeister.org/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/koraktor/braumeister.org/pulls/comments/135397632"},"html":{"href":"https://github.com/koraktor/braumeister.org/pull/48#discussion_r135397632"},"pull_request":{"href":"https://api.github.com/repos/koraktor/braumeister.org/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/koraktor/braumeister.org/pulls/48","id":119783085,"html_url":"https://github.com/koraktor/braumeister.org/pull/48","diff_url":"https://github.com/koraktor/braumeister.org/pull/48.diff","patch_url":"https://github.com/koraktor/braumeister.org/pull/48.patch","issue_url":"https://api.github.com/repos/koraktor/braumeister.org/issues/48","number":48,"state":"open","locked":false,"title":"Match Homebrew's site's theme","user":{"login":"MikeMcQuaid","id":125011,"avatar_url":"https://avatars2.githubusercontent.com/u/125011?v=4","gravatar_id":"","url":"https://api.github.com/users/MikeMcQuaid","html_url":"https://github.com/MikeMcQuaid","followers_url":"https://api.github.com/users/MikeMcQuaid/followers","following_url":"https://api.github.com/users/MikeMcQuaid/following{/other_user}","gists_url":"https://api.github.com/users/MikeMcQuaid/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeMcQuaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeMcQuaid/subscriptions","organizations_url":"https://api.github.com/users/MikeMcQuaid/orgs","repos_url":"https://api.github.com/users/MikeMcQuaid/repos","events_url":"https://api.github.com/users/MikeMcQuaid/events{/privacy}","received_events_url":"https://api.github.com/users/MikeMcQuaid/received_events","type":"User","site_admin":true},"body":"More closely match Homebrew's theme. This involves mostly just CSS changes but a few minor HTML structural changes are required too.\n\n@koraktor I realise these changes are pretty dramatic and not looking great yet but I just wanted to push something WIP early so you could give some thoughts before I go to deep down the rabbit hole.","created_at":"2017-05-10T00:48:15Z","updated_at":"2017-08-26T21:01:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"276358111af57318a7696e9a36b54722cc8cead1","assignee":{"login":"koraktor","id":66112,"avatar_url":"https://avatars2.githubusercontent.com/u/66112?v=4","gravatar_id":"","url":"https://api.github.com/users/koraktor","html_url":"https://github.com/koraktor","followers_url":"https://api.github.com/users/koraktor/followers","following_url":"https://api.github.com/users/koraktor/following{/other_user}","gists_url":"https://api.github.com/users/koraktor/gists{/gist_id}","starred_url":"https://api.github.com/users/koraktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koraktor/subscriptions","organizations_url":"https://api.github.com/users/koraktor/orgs","repos_url":"https://api.github.com/users/koraktor/repos","events_url":"https://api.github.com/users/koraktor/events{/privacy}","received_events_url":"https://api.github.com/users/koraktor/received_events","type":"User","site_admin":false},"assignees":[{"login":"koraktor","id":66112,"avatar_url":"https://avatars2.githubusercontent.com/u/66112?v=4","gravatar_id":"","url":"https://api.github.com/users/koraktor","html_url":"https://github.com/koraktor","followers_url":"https://api.github.com/users/koraktor/followers","following_url":"https://api.github.com/users/koraktor/following{/other_user}","gists_url":"https://api.github.com/users/koraktor/gists{/gist_id}","starred_url":"https://api.github.com/users/koraktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koraktor/subscriptions","organizations_url":"https://api.github.com/users/koraktor/orgs","repos_url":"https://api.github.com/users/koraktor/repos","events_url":"https://api.github.com/users/koraktor/events{/privacy}","received_events_url":"https://api.github.com/users/koraktor/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/koraktor/braumeister.org/pulls/48/commits","review_comments_url":"https://api.github.com/repos/koraktor/braumeister.org/pulls/48/comments","review_comment_url":"https://api.github.com/repos/koraktor/braumeister.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/koraktor/braumeister.org/issues/48/comments","statuses_url":"https://api.github.com/repos/koraktor/braumeister.org/statuses/b14c27849d084a1a59cc8b02c0d73be5ecef5dba","head":{"label":"MikeMcQuaid:brew-css","ref":"brew-css","sha":"b14c27849d084a1a59cc8b02c0d73be5ecef5dba","user":{"login":"MikeMcQuaid","id":125011,"avatar_url":"https://avatars2.githubusercontent.com/u/125011?v=4","gravatar_id":"","url":"https://api.github.com/users/MikeMcQuaid","html_url":"https://github.com/MikeMcQuaid","followers_url":"https://api.github.com/users/MikeMcQuaid/followers","following_url":"https://api.github.com/users/MikeMcQuaid/following{/other_user}","gists_url":"https://api.github.com/users/MikeMcQuaid/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeMcQuaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeMcQuaid/subscriptions","organizations_url":"https://api.github.com/users/MikeMcQuaid/orgs","repos_url":"https://api.github.com/users/MikeMcQuaid/repos","events_url":"https://api.github.com/users/MikeMcQuaid/events{/privacy}","received_events_url":"https://api.github.com/users/MikeMcQuaid/received_events","type":"User","site_admin":true},"repo":{"id":89472706,"name":"braumeister.org","full_name":"MikeMcQuaid/braumeister.org","owner":{"login":"MikeMcQuaid","id":125011,"avatar_url":"https://avatars2.githubusercontent.com/u/125011?v=4","gravatar_id":"","url":"https://api.github.com/users/MikeMcQuaid","html_url":"https://github.com/MikeMcQuaid","followers_url":"https://api.github.com/users/MikeMcQuaid/followers","following_url":"https://api.github.com/users/MikeMcQuaid/following{/other_user}","gists_url":"https://api.github.com/users/MikeMcQuaid/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeMcQuaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeMcQuaid/subscriptions","organizations_url":"https://api.github.com/users/MikeMcQuaid/orgs","repos_url":"https://api.github.com/users/MikeMcQuaid/repos","events_url":"https://api.github.com/users/MikeMcQuaid/events{/privacy}","received_events_url":"https://api.github.com/users/MikeMcQuaid/received_events","type":"User","site_admin":true},"private":false,"html_url":"https://github.com/MikeMcQuaid/braumeister.org","description":"An online package browser for Homebrew, the OS X package manager.","fork":true,"url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org","forks_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/forks","keys_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/teams","hooks_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/hooks","issue_events_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/issues/events{/number}","events_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/events","assignees_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/assignees{/user}","branches_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/branches{/branch}","tags_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/tags","blobs_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/statuses/{sha}","languages_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/languages","stargazers_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/stargazers","contributors_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/contributors","subscribers_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/subscribers","subscription_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/subscription","commits_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/contents/{+path}","compare_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/merges","archive_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/downloads","issues_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/issues{/number}","pulls_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/pulls{/number}","milestones_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/milestones{/number}","notifications_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/labels{/name}","releases_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/releases{/id}","deployments_url":"https://api.github.com/repos/MikeMcQuaid/braumeister.org/deployments","created_at":"2017-04-26T11:21:08Z","updated_at":"2017-04-26T11:21:10Z","pushed_at":"2017-08-22T21:39:00Z","git_url":"git://github.com/MikeMcQuaid/braumeister.org.git","ssh_url":"[email protected]:MikeMcQuaid/braumeister.org.git","clone_url":"https://github.com/MikeMcQuaid/braumeister.org.git","svn_url":"https://github.com/MikeMcQuaid/braumeister.org","homepage":"http://braumeister.org","size":852,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"koraktor:master","ref":"master","sha":"cf3b270db0b175452310eb909f1bfcdb21f458d8","user":{"login":"koraktor","id":66112,"avatar_url":"https://avatars2.githubusercontent.com/u/66112?v=4","gravatar_id":"","url":"https://api.github.com/users/koraktor","html_url":"https://github.com/koraktor","followers_url":"https://api.github.com/users/koraktor/followers","following_url":"https://api.github.com/users/koraktor/following{/other_user}","gists_url":"https://api.github.com/users/koraktor/gists{/gist_id}","starred_url":"https://api.github.com/users/koraktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koraktor/subscriptions","organizations_url":"https://api.github.com/users/koraktor/orgs","repos_url":"https://api.github.com/users/koraktor/repos","events_url":"https://api.github.com/users/koraktor/events{/privacy}","received_events_url":"https://api.github.com/users/koraktor/received_events","type":"User","site_admin":false},"repo":{"id":3121853,"name":"braumeister.org","full_name":"koraktor/braumeister.org","owner":{"login":"koraktor","id":66112,"avatar_url":"https://avatars2.githubusercontent.com/u/66112?v=4","gravatar_id":"","url":"https://api.github.com/users/koraktor","html_url":"https://github.com/koraktor","followers_url":"https://api.github.com/users/koraktor/followers","following_url":"https://api.github.com/users/koraktor/following{/other_user}","gists_url":"https://api.github.com/users/koraktor/gists{/gist_id}","starred_url":"https://api.github.com/users/koraktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koraktor/subscriptions","organizations_url":"https://api.github.com/users/koraktor/orgs","repos_url":"https://api.github.com/users/koraktor/repos","events_url":"https://api.github.com/users/koraktor/events{/privacy}","received_events_url":"https://api.github.com/users/koraktor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/koraktor/braumeister.org","description":"An online package browser for Homebrew, the OS X package manager.","fork":false,"url":"https://api.github.com/repos/koraktor/braumeister.org","forks_url":"https://api.github.com/repos/koraktor/braumeister.org/forks","keys_url":"https://api.github.com/repos/koraktor/braumeister.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koraktor/braumeister.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koraktor/braumeister.org/teams","hooks_url":"https://api.github.com/repos/koraktor/braumeister.org/hooks","issue_events_url":"https://api.github.com/repos/koraktor/braumeister.org/issues/events{/number}","events_url":"https://api.github.com/repos/koraktor/braumeister.org/events","assignees_url":"https://api.github.com/repos/koraktor/braumeister.org/assignees{/user}","branches_url":"https://api.github.com/repos/koraktor/braumeister.org/branches{/branch}","tags_url":"https://api.github.com/repos/koraktor/braumeister.org/tags","blobs_url":"https://api.github.com/repos/koraktor/braumeister.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koraktor/braumeister.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koraktor/braumeister.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/koraktor/braumeister.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koraktor/braumeister.org/statuses/{sha}","languages_url":"https://api.github.com/repos/koraktor/braumeister.org/languages","stargazers_url":"https://api.github.com/repos/koraktor/braumeister.org/stargazers","contributors_url":"https://api.github.com/repos/koraktor/braumeister.org/contributors","subscribers_url":"https://api.github.com/repos/koraktor/braumeister.org/subscribers","subscription_url":"https://api.github.com/repos/koraktor/braumeister.org/subscription","commits_url":"https://api.github.com/repos/koraktor/braumeister.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/koraktor/braumeister.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/koraktor/braumeister.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/koraktor/braumeister.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/koraktor/braumeister.org/contents/{+path}","compare_url":"https://api.github.com/repos/koraktor/braumeister.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koraktor/braumeister.org/merges","archive_url":"https://api.github.com/repos/koraktor/braumeister.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koraktor/braumeister.org/downloads","issues_url":"https://api.github.com/repos/koraktor/braumeister.org/issues{/number}","pulls_url":"https://api.github.com/repos/koraktor/braumeister.org/pulls{/number}","milestones_url":"https://api.github.com/repos/koraktor/braumeister.org/milestones{/number}","notifications_url":"https://api.github.com/repos/koraktor/braumeister.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koraktor/braumeister.org/labels{/name}","releases_url":"https://api.github.com/repos/koraktor/braumeister.org/releases{/id}","deployments_url":"https://api.github.com/repos/koraktor/braumeister.org/deployments","created_at":"2012-01-06T23:20:57Z","updated_at":"2017-08-25T13:32:22Z","pushed_at":"2017-08-26T20:10:51Z","git_url":"git://github.com/koraktor/braumeister.org.git","ssh_url":"[email protected]:koraktor/braumeister.org.git","clone_url":"https://github.com/koraktor/braumeister.org.git","svn_url":"https://github.com/koraktor/braumeister.org","homepage":"http://braumeister.org","size":846,"stargazers_count":190,"watchers_count":190,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":6,"forks":34,"open_issues":6,"watchers":190,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/koraktor/braumeister.org/pulls/48"},"html":{"href":"https://github.com/koraktor/braumeister.org/pull/48"},"issue":{"href":"https://api.github.com/repos/koraktor/braumeister.org/issues/48"},"comments":{"href":"https://api.github.com/repos/koraktor/braumeister.org/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/koraktor/braumeister.org/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/koraktor/braumeister.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/koraktor/braumeister.org/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/koraktor/braumeister.org/statuses/b14c27849d084a1a59cc8b02c0d73be5ecef5dba"}}}} | {
"id": 3121853,
"name": "koraktor/braumeister.org",
"url": "https://api.github.com/repos/koraktor/braumeister.org"
} | {
"id": 66112,
"login": "koraktor",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/66112?",
"url": "https://api.github.com/users/koraktor"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-08-26T21:01:18 | 6515817779 | {"actor":{"display_login":"koraktor"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/daisuke13/chat-space/pulls/comments/116898905","pull_request_review_id":38557637,"id":116898905,"diff_hunk":"@@ -10,7 +10,10 @@ def index\n def create\n @message = Message.new(message_params)\n if @message.save\n- redirect_to group_messages_path\n+ respond_to do |format|\n+ format.html { redirect_to group_messages_path, notice: \"メッセージが送信されました\" }\n+ format.json { render 'create.json.jbuilder' }","path":"app/controllers/messages_controller.rb","position":7,"original_position":7,"commit_id":"aac61f6119ad2f427ca269347fe8f2e1d04c010e","original_commit_id":"aac61f6119ad2f427ca269347fe8f2e1d04c010e","user":{"login":"hiroki5123","id":23256513,"avatar_url":"https://avatars2.githubusercontent.com/u/23256513?v=3","gravatar_id":"","url":"https://api.github.com/users/hiroki5123","html_url":"https://github.com/hiroki5123","followers_url":"https://api.github.com/users/hiroki5123/followers","following_url":"https://api.github.com/users/hiroki5123/following{/other_user}","gists_url":"https://api.github.com/users/hiroki5123/gists{/gist_id}","starred_url":"https://api.github.com/users/hiroki5123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiroki5123/subscriptions","organizations_url":"https://api.github.com/users/hiroki5123/orgs","repos_url":"https://api.github.com/users/hiroki5123/repos","events_url":"https://api.github.com/users/hiroki5123/events{/privacy}","received_events_url":"https://api.github.com/users/hiroki5123/received_events","type":"User","site_admin":false},"body":"今回jbuilderを使用しているのでformat.jsonの引数はいらないような気がしますが、なくてもいけませんでしょうか?","created_at":"2017-05-17T02:32:48Z","updated_at":"2017-05-17T02:33:59Z","html_url":"https://github.com/daisuke13/chat-space/pull/20#discussion_r116898905","pull_request_url":"https://api.github.com/repos/daisuke13/chat-space/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/daisuke13/chat-space/pulls/comments/116898905"},"html":{"href":"https://github.com/daisuke13/chat-space/pull/20#discussion_r116898905"},"pull_request":{"href":"https://api.github.com/repos/daisuke13/chat-space/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/daisuke13/chat-space/pulls/20","id":120828955,"html_url":"https://github.com/daisuke13/chat-space/pull/20","diff_url":"https://github.com/daisuke13/chat-space/pull/20.diff","patch_url":"https://github.com/daisuke13/chat-space/pull/20.patch","issue_url":"https://api.github.com/repos/daisuke13/chat-space/issues/20","number":20,"state":"open","locked":false,"title":"message送信機能のAPIの実装","user":{"login":"daisuke13","id":21375060,"avatar_url":"https://avatars3.githubusercontent.com/u/21375060?v=3","gravatar_id":"","url":"https://api.github.com/users/daisuke13","html_url":"https://github.com/daisuke13","followers_url":"https://api.github.com/users/daisuke13/followers","following_url":"https://api.github.com/users/daisuke13/following{/other_user}","gists_url":"https://api.github.com/users/daisuke13/gists{/gist_id}","starred_url":"https://api.github.com/users/daisuke13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daisuke13/subscriptions","organizations_url":"https://api.github.com/users/daisuke13/orgs","repos_url":"https://api.github.com/users/daisuke13/repos","events_url":"https://api.github.com/users/daisuke13/events{/privacy}","received_events_url":"https://api.github.com/users/daisuke13/received_events","type":"User","site_admin":false},"body":"# What\nmessage送信機能のAPIの実装\n\n# Why\n非同期通信化するため。","created_at":"2017-05-16T13:35:49Z","updated_at":"2017-05-17T02:33:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"844f20709288e6e1a6254eba2e037f74c92dfd1f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/daisuke13/chat-space/pulls/20/commits","review_comments_url":"https://api.github.com/repos/daisuke13/chat-space/pulls/20/comments","review_comment_url":"https://api.github.com/repos/daisuke13/chat-space/pulls/comments{/number}","comments_url":"https://api.github.com/repos/daisuke13/chat-space/issues/20/comments","statuses_url":"https://api.github.com/repos/daisuke13/chat-space/statuses/aac61f6119ad2f427ca269347fe8f2e1d04c010e","head":{"label":"daisuke13:message-API","ref":"message-API","sha":"aac61f6119ad2f427ca269347fe8f2e1d04c010e","user":{"login":"daisuke13","id":21375060,"avatar_url":"https://avatars3.githubusercontent.com/u/21375060?v=3","gravatar_id":"","url":"https://api.github.com/users/daisuke13","html_url":"https://github.com/daisuke13","followers_url":"https://api.github.com/users/daisuke13/followers","following_url":"https://api.github.com/users/daisuke13/following{/other_user}","gists_url":"https://api.github.com/users/daisuke13/gists{/gist_id}","starred_url":"https://api.github.com/users/daisuke13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daisuke13/subscriptions","organizations_url":"https://api.github.com/users/daisuke13/orgs","repos_url":"https://api.github.com/users/daisuke13/repos","events_url":"https://api.github.com/users/daisuke13/events{/privacy}","received_events_url":"https://api.github.com/users/daisuke13/received_events","type":"User","site_admin":false},"repo":{"id":89481780,"name":"chat-space","full_name":"daisuke13/chat-space","owner":{"login":"daisuke13","id":21375060,"avatar_url":"https://avatars3.githubusercontent.com/u/21375060?v=3","gravatar_id":"","url":"https://api.github.com/users/daisuke13","html_url":"https://github.com/daisuke13","followers_url":"https://api.github.com/users/daisuke13/followers","following_url":"https://api.github.com/users/daisuke13/following{/other_user}","gists_url":"https://api.github.com/users/daisuke13/gists{/gist_id}","starred_url":"https://api.github.com/users/daisuke13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daisuke13/subscriptions","organizations_url":"https://api.github.com/users/daisuke13/orgs","repos_url":"https://api.github.com/users/daisuke13/repos","events_url":"https://api.github.com/users/daisuke13/events{/privacy}","received_events_url":"https://api.github.com/users/daisuke13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daisuke13/chat-space","description":null,"fork":false,"url":"https://api.github.com/repos/daisuke13/chat-space","forks_url":"https://api.github.com/repos/daisuke13/chat-space/forks","keys_url":"https://api.github.com/repos/daisuke13/chat-space/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daisuke13/chat-space/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daisuke13/chat-space/teams","hooks_url":"https://api.github.com/repos/daisuke13/chat-space/hooks","issue_events_url":"https://api.github.com/repos/daisuke13/chat-space/issues/events{/number}","events_url":"https://api.github.com/repos/daisuke13/chat-space/events","assignees_url":"https://api.github.com/repos/daisuke13/chat-space/assignees{/user}","branches_url":"https://api.github.com/repos/daisuke13/chat-space/branches{/branch}","tags_url":"https://api.github.com/repos/daisuke13/chat-space/tags","blobs_url":"https://api.github.com/repos/daisuke13/chat-space/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daisuke13/chat-space/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daisuke13/chat-space/git/refs{/sha}","trees_url":"https://api.github.com/repos/daisuke13/chat-space/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daisuke13/chat-space/statuses/{sha}","languages_url":"https://api.github.com/repos/daisuke13/chat-space/languages","stargazers_url":"https://api.github.com/repos/daisuke13/chat-space/stargazers","contributors_url":"https://api.github.com/repos/daisuke13/chat-space/contributors","subscribers_url":"https://api.github.com/repos/daisuke13/chat-space/subscribers","subscription_url":"https://api.github.com/repos/daisuke13/chat-space/subscription","commits_url":"https://api.github.com/repos/daisuke13/chat-space/commits{/sha}","git_commits_url":"https://api.github.com/repos/daisuke13/chat-space/git/commits{/sha}","comments_url":"https://api.github.com/repos/daisuke13/chat-space/comments{/number}","issue_comment_url":"https://api.github.com/repos/daisuke13/chat-space/issues/comments{/number}","contents_url":"https://api.github.com/repos/daisuke13/chat-space/contents/{+path}","compare_url":"https://api.github.com/repos/daisuke13/chat-space/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daisuke13/chat-space/merges","archive_url":"https://api.github.com/repos/daisuke13/chat-space/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daisuke13/chat-space/downloads","issues_url":"https://api.github.com/repos/daisuke13/chat-space/issues{/number}","pulls_url":"https://api.github.com/repos/daisuke13/chat-space/pulls{/number}","milestones_url":"https://api.github.com/repos/daisuke13/chat-space/milestones{/number}","notifications_url":"https://api.github.com/repos/daisuke13/chat-space/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daisuke13/chat-space/labels{/name}","releases_url":"https://api.github.com/repos/daisuke13/chat-space/releases{/id}","deployments_url":"https://api.github.com/repos/daisuke13/chat-space/deployments","created_at":"2017-04-26T13:07:06Z","updated_at":"2017-04-26T13:07:14Z","pushed_at":"2017-05-16T13:35:49Z","git_url":"git://github.com/daisuke13/chat-space.git","ssh_url":"[email protected]:daisuke13/chat-space.git","clone_url":"https://github.com/daisuke13/chat-space.git","svn_url":"https://github.com/daisuke13/chat-space","homepage":null,"size":93,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"daisuke13:master","ref":"master","sha":"9fe050d36778b4b8d074e8e962bcf7be595fc35a","user":{"login":"daisuke13","id":21375060,"avatar_url":"https://avatars3.githubusercontent.com/u/21375060?v=3","gravatar_id":"","url":"https://api.github.com/users/daisuke13","html_url":"https://github.com/daisuke13","followers_url":"https://api.github.com/users/daisuke13/followers","following_url":"https://api.github.com/users/daisuke13/following{/other_user}","gists_url":"https://api.github.com/users/daisuke13/gists{/gist_id}","starred_url":"https://api.github.com/users/daisuke13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daisuke13/subscriptions","organizations_url":"https://api.github.com/users/daisuke13/orgs","repos_url":"https://api.github.com/users/daisuke13/repos","events_url":"https://api.github.com/users/daisuke13/events{/privacy}","received_events_url":"https://api.github.com/users/daisuke13/received_events","type":"User","site_admin":false},"repo":{"id":89481780,"name":"chat-space","full_name":"daisuke13/chat-space","owner":{"login":"daisuke13","id":21375060,"avatar_url":"https://avatars3.githubusercontent.com/u/21375060?v=3","gravatar_id":"","url":"https://api.github.com/users/daisuke13","html_url":"https://github.com/daisuke13","followers_url":"https://api.github.com/users/daisuke13/followers","following_url":"https://api.github.com/users/daisuke13/following{/other_user}","gists_url":"https://api.github.com/users/daisuke13/gists{/gist_id}","starred_url":"https://api.github.com/users/daisuke13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daisuke13/subscriptions","organizations_url":"https://api.github.com/users/daisuke13/orgs","repos_url":"https://api.github.com/users/daisuke13/repos","events_url":"https://api.github.com/users/daisuke13/events{/privacy}","received_events_url":"https://api.github.com/users/daisuke13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daisuke13/chat-space","description":null,"fork":false,"url":"https://api.github.com/repos/daisuke13/chat-space","forks_url":"https://api.github.com/repos/daisuke13/chat-space/forks","keys_url":"https://api.github.com/repos/daisuke13/chat-space/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daisuke13/chat-space/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daisuke13/chat-space/teams","hooks_url":"https://api.github.com/repos/daisuke13/chat-space/hooks","issue_events_url":"https://api.github.com/repos/daisuke13/chat-space/issues/events{/number}","events_url":"https://api.github.com/repos/daisuke13/chat-space/events","assignees_url":"https://api.github.com/repos/daisuke13/chat-space/assignees{/user}","branches_url":"https://api.github.com/repos/daisuke13/chat-space/branches{/branch}","tags_url":"https://api.github.com/repos/daisuke13/chat-space/tags","blobs_url":"https://api.github.com/repos/daisuke13/chat-space/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daisuke13/chat-space/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daisuke13/chat-space/git/refs{/sha}","trees_url":"https://api.github.com/repos/daisuke13/chat-space/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daisuke13/chat-space/statuses/{sha}","languages_url":"https://api.github.com/repos/daisuke13/chat-space/languages","stargazers_url":"https://api.github.com/repos/daisuke13/chat-space/stargazers","contributors_url":"https://api.github.com/repos/daisuke13/chat-space/contributors","subscribers_url":"https://api.github.com/repos/daisuke13/chat-space/subscribers","subscription_url":"https://api.github.com/repos/daisuke13/chat-space/subscription","commits_url":"https://api.github.com/repos/daisuke13/chat-space/commits{/sha}","git_commits_url":"https://api.github.com/repos/daisuke13/chat-space/git/commits{/sha}","comments_url":"https://api.github.com/repos/daisuke13/chat-space/comments{/number}","issue_comment_url":"https://api.github.com/repos/daisuke13/chat-space/issues/comments{/number}","contents_url":"https://api.github.com/repos/daisuke13/chat-space/contents/{+path}","compare_url":"https://api.github.com/repos/daisuke13/chat-space/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daisuke13/chat-space/merges","archive_url":"https://api.github.com/repos/daisuke13/chat-space/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daisuke13/chat-space/downloads","issues_url":"https://api.github.com/repos/daisuke13/chat-space/issues{/number}","pulls_url":"https://api.github.com/repos/daisuke13/chat-space/pulls{/number}","milestones_url":"https://api.github.com/repos/daisuke13/chat-space/milestones{/number}","notifications_url":"https://api.github.com/repos/daisuke13/chat-space/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daisuke13/chat-space/labels{/name}","releases_url":"https://api.github.com/repos/daisuke13/chat-space/releases{/id}","deployments_url":"https://api.github.com/repos/daisuke13/chat-space/deployments","created_at":"2017-04-26T13:07:06Z","updated_at":"2017-04-26T13:07:14Z","pushed_at":"2017-05-16T13:35:49Z","git_url":"git://github.com/daisuke13/chat-space.git","ssh_url":"[email protected]:daisuke13/chat-space.git","clone_url":"https://github.com/daisuke13/chat-space.git","svn_url":"https://github.com/daisuke13/chat-space","homepage":null,"size":93,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/daisuke13/chat-space/pulls/20"},"html":{"href":"https://github.com/daisuke13/chat-space/pull/20"},"issue":{"href":"https://api.github.com/repos/daisuke13/chat-space/issues/20"},"comments":{"href":"https://api.github.com/repos/daisuke13/chat-space/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/daisuke13/chat-space/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/daisuke13/chat-space/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/daisuke13/chat-space/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/daisuke13/chat-space/statuses/aac61f6119ad2f427ca269347fe8f2e1d04c010e"}}}} | {
"id": 89481780,
"name": "daisuke13/chat-space",
"url": "https://api.github.com/repos/daisuke13/chat-space"
} | {
"id": 23256513,
"login": "hiroki5123",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23256513?",
"url": "https://api.github.com/users/hiroki5123"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-05-17T02:32:48 | 5886404996 | {"actor":{"display_login":"hiroki5123"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/pulls/comments/113538181","pull_request_review_id":34935784,"id":113538181,"diff_hunk":"@@ -41,6 +41,6 @@ config :real_world, RealWorld.Repo,\n adapter: Ecto.Adapters.Postgres,\n username: \"postgres\",\n password: \"postgres\",\n- database: \"real_world_dev\",","path":"config/dev.exs","position":4,"original_position":4,"commit_id":"83c7536d05c35c92265deaaf89b54dc2a5cc765d","original_commit_id":"83c7536d05c35c92265deaaf89b54dc2a5cc765d","user":{"login":"BrainMaestro","id":1738373,"avatar_url":"https://avatars0.githubusercontent.com/u/1738373?v=3","gravatar_id":"","url":"https://api.github.com/users/BrainMaestro","html_url":"https://github.com/BrainMaestro","followers_url":"https://api.github.com/users/BrainMaestro/followers","following_url":"https://api.github.com/users/BrainMaestro/following{/other_user}","gists_url":"https://api.github.com/users/BrainMaestro/gists{/gist_id}","starred_url":"https://api.github.com/users/BrainMaestro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrainMaestro/subscriptions","organizations_url":"https://api.github.com/users/BrainMaestro/orgs","repos_url":"https://api.github.com/users/BrainMaestro/repos","events_url":"https://api.github.com/users/BrainMaestro/events{/privacy}","received_events_url":"https://api.github.com/users/BrainMaestro/received_events","type":"User","site_admin":false},"body":"Any reason why this changed?","created_at":"2017-04-26T19:11:37Z","updated_at":"2017-04-26T19:11:38Z","html_url":"https://github.com/BrainMaestro/elixir-phoenix-realworld/pull/6#discussion_r113538181","pull_request_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/pulls/comments/113538181"},"html":{"href":"https://github.com/BrainMaestro/elixir-phoenix-realworld/pull/6#discussion_r113538181"},"pull_request":{"href":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/pulls/6","id":117734706,"html_url":"https://github.com/BrainMaestro/elixir-phoenix-realworld/pull/6","diff_url":"https://github.com/BrainMaestro/elixir-phoenix-realworld/pull/6.diff","patch_url":"https://github.com/BrainMaestro/elixir-phoenix-realworld/pull/6.patch","issue_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/issues/6","number":6,"state":"open","locked":false,"title":"Added a user model","user":{"login":"mattdharmon","id":3542342,"avatar_url":"https://avatars3.githubusercontent.com/u/3542342?v=3","gravatar_id":"","url":"https://api.github.com/users/mattdharmon","html_url":"https://github.com/mattdharmon","followers_url":"https://api.github.com/users/mattdharmon/followers","following_url":"https://api.github.com/users/mattdharmon/following{/other_user}","gists_url":"https://api.github.com/users/mattdharmon/gists{/gist_id}","starred_url":"https://api.github.com/users/mattdharmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattdharmon/subscriptions","organizations_url":"https://api.github.com/users/mattdharmon/orgs","repos_url":"https://api.github.com/users/mattdharmon/repos","events_url":"https://api.github.com/users/mattdharmon/events{/privacy}","received_events_url":"https://api.github.com/users/mattdharmon/received_events","type":"User","site_admin":false},"body":"As well as test with factories, added a bcrypt lib for password hashing, and a nanobox (boxfile.yml) for consistent dev env.","created_at":"2017-04-26T14:53:07Z","updated_at":"2017-04-26T19:11:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"932813345e58e388241ab1431e2747221c241556","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/pulls/6/commits","review_comments_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/pulls/6/comments","review_comment_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/issues/6/comments","statuses_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/statuses/83c7536d05c35c92265deaaf89b54dc2a5cc765d","head":{"label":"mattdharmon:feature/add-user-model","ref":"feature/add-user-model","sha":"83c7536d05c35c92265deaaf89b54dc2a5cc765d","user":{"login":"mattdharmon","id":3542342,"avatar_url":"https://avatars3.githubusercontent.com/u/3542342?v=3","gravatar_id":"","url":"https://api.github.com/users/mattdharmon","html_url":"https://github.com/mattdharmon","followers_url":"https://api.github.com/users/mattdharmon/followers","following_url":"https://api.github.com/users/mattdharmon/following{/other_user}","gists_url":"https://api.github.com/users/mattdharmon/gists{/gist_id}","starred_url":"https://api.github.com/users/mattdharmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattdharmon/subscriptions","organizations_url":"https://api.github.com/users/mattdharmon/orgs","repos_url":"https://api.github.com/users/mattdharmon/repos","events_url":"https://api.github.com/users/mattdharmon/events{/privacy}","received_events_url":"https://api.github.com/users/mattdharmon/received_events","type":"User","site_admin":false},"repo":{"id":89486580,"name":"elixir-phoenix-realworld","full_name":"mattdharmon/elixir-phoenix-realworld","owner":{"login":"mattdharmon","id":3542342,"avatar_url":"https://avatars3.githubusercontent.com/u/3542342?v=3","gravatar_id":"","url":"https://api.github.com/users/mattdharmon","html_url":"https://github.com/mattdharmon","followers_url":"https://api.github.com/users/mattdharmon/followers","following_url":"https://api.github.com/users/mattdharmon/following{/other_user}","gists_url":"https://api.github.com/users/mattdharmon/gists{/gist_id}","starred_url":"https://api.github.com/users/mattdharmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattdharmon/subscriptions","organizations_url":"https://api.github.com/users/mattdharmon/orgs","repos_url":"https://api.github.com/users/mattdharmon/repos","events_url":"https://api.github.com/users/mattdharmon/events{/privacy}","received_events_url":"https://api.github.com/users/mattdharmon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattdharmon/elixir-phoenix-realworld","description":"Elixir + Phoenix implementation of realworld backend api","fork":true,"url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld","forks_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/forks","keys_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/teams","hooks_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/hooks","issue_events_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/issues/events{/number}","events_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/events","assignees_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/assignees{/user}","branches_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/branches{/branch}","tags_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/tags","blobs_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/statuses/{sha}","languages_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/languages","stargazers_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/stargazers","contributors_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/contributors","subscribers_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/subscribers","subscription_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/subscription","commits_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/contents/{+path}","compare_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/merges","archive_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/downloads","issues_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/issues{/number}","pulls_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/pulls{/number}","milestones_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/milestones{/number}","notifications_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/labels{/name}","releases_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/releases{/id}","deployments_url":"https://api.github.com/repos/mattdharmon/elixir-phoenix-realworld/deployments","created_at":"2017-04-26T13:52:54Z","updated_at":"2017-04-26T13:52:56Z","pushed_at":"2017-04-26T15:46:59Z","git_url":"git://github.com/mattdharmon/elixir-phoenix-realworld.git","ssh_url":"[email protected]:mattdharmon/elixir-phoenix-realworld.git","clone_url":"https://github.com/mattdharmon/elixir-phoenix-realworld.git","svn_url":"https://github.com/mattdharmon/elixir-phoenix-realworld","homepage":null,"size":154,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BrainMaestro:master","ref":"master","sha":"485bb35802bbf46306d4c5dd1885262bf9948c0e","user":{"login":"BrainMaestro","id":1738373,"avatar_url":"https://avatars0.githubusercontent.com/u/1738373?v=3","gravatar_id":"","url":"https://api.github.com/users/BrainMaestro","html_url":"https://github.com/BrainMaestro","followers_url":"https://api.github.com/users/BrainMaestro/followers","following_url":"https://api.github.com/users/BrainMaestro/following{/other_user}","gists_url":"https://api.github.com/users/BrainMaestro/gists{/gist_id}","starred_url":"https://api.github.com/users/BrainMaestro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrainMaestro/subscriptions","organizations_url":"https://api.github.com/users/BrainMaestro/orgs","repos_url":"https://api.github.com/users/BrainMaestro/repos","events_url":"https://api.github.com/users/BrainMaestro/events{/privacy}","received_events_url":"https://api.github.com/users/BrainMaestro/received_events","type":"User","site_admin":false},"repo":{"id":89102503,"name":"elixir-phoenix-realworld","full_name":"BrainMaestro/elixir-phoenix-realworld","owner":{"login":"BrainMaestro","id":1738373,"avatar_url":"https://avatars0.githubusercontent.com/u/1738373?v=3","gravatar_id":"","url":"https://api.github.com/users/BrainMaestro","html_url":"https://github.com/BrainMaestro","followers_url":"https://api.github.com/users/BrainMaestro/followers","following_url":"https://api.github.com/users/BrainMaestro/following{/other_user}","gists_url":"https://api.github.com/users/BrainMaestro/gists{/gist_id}","starred_url":"https://api.github.com/users/BrainMaestro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrainMaestro/subscriptions","organizations_url":"https://api.github.com/users/BrainMaestro/orgs","repos_url":"https://api.github.com/users/BrainMaestro/repos","events_url":"https://api.github.com/users/BrainMaestro/events{/privacy}","received_events_url":"https://api.github.com/users/BrainMaestro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BrainMaestro/elixir-phoenix-realworld","description":"Elixir + Phoenix implementation of realworld backend api","fork":false,"url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld","forks_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/forks","keys_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/teams","hooks_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/hooks","issue_events_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/issues/events{/number}","events_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/events","assignees_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/assignees{/user}","branches_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/branches{/branch}","tags_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/tags","blobs_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/statuses/{sha}","languages_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/languages","stargazers_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/stargazers","contributors_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/contributors","subscribers_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/subscribers","subscription_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/subscription","commits_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/contents/{+path}","compare_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/merges","archive_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/downloads","issues_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/issues{/number}","pulls_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/pulls{/number}","milestones_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/milestones{/number}","notifications_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/labels{/name}","releases_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/releases{/id}","deployments_url":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/deployments","created_at":"2017-04-22T22:19:52Z","updated_at":"2017-04-26T16:40:01Z","pushed_at":"2017-04-26T17:20:38Z","git_url":"git://github.com/BrainMaestro/elixir-phoenix-realworld.git","ssh_url":"[email protected]:BrainMaestro/elixir-phoenix-realworld.git","clone_url":"https://github.com/BrainMaestro/elixir-phoenix-realworld.git","svn_url":"https://github.com/BrainMaestro/elixir-phoenix-realworld","homepage":null,"size":147,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/pulls/6"},"html":{"href":"https://github.com/BrainMaestro/elixir-phoenix-realworld/pull/6"},"issue":{"href":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/issues/6"},"comments":{"href":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld/statuses/83c7536d05c35c92265deaaf89b54dc2a5cc765d"}}}} | {
"id": 89102503,
"name": "BrainMaestro/elixir-phoenix-realworld",
"url": "https://api.github.com/repos/BrainMaestro/elixir-phoenix-realworld"
} | {
"id": 1738373,
"login": "BrainMaestro",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1738373?",
"url": "https://api.github.com/users/BrainMaestro"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-04-26T19:11:37 | 5763170889 | {"actor":{"display_login":"BrainMaestro"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Wilfred/remacs/pulls/comments/149170753","pull_request_review_id":74523502,"id":149170753,"diff_hunk":"@@ -0,0 +1,73 @@\n+//! keyboard\n+\n+use remacs_macros::lisp_fn;\n+use remacs_sys::{Fpos_visible_in_window_p, Fposn_at_x_y};\n+use remacs_sys::{Qnil, Qt};\n+\n+use lisp::LispObject;\n+use lisp::defsubr;\n+use windows::window_or_selected_unchecked;\n+\n+/// Return position information for buffer position POS in WINDOW.\n+/// POS defaults to point in WINDOW; WINDOW defaults to the selected window.\n+///\n+/// Return nil if POS is not visible in WINDOW. Otherwise,\n+/// the return value is similar to that returned by `event-start' for\n+/// a mouse click at the upper left corner of the glyph corresponding\n+/// to POS:\n+/// (WINDOW AREA-OR-POS (X . Y) TIMESTAMP OBJECT POS (COL . ROW)\n+/// IMAGE (DX . DY) (WIDTH . HEIGHT))\n+/// The `posn-' functions access elements of such lists.\n+#[lisp_fn(min = \"0\")]\n+pub fn posn_at_point(pos: LispObject, window: LispObject) -> LispObject {\n+ let window = window_or_selected_unchecked(window);\n+\n+ let tem = LispObject::from(unsafe {\n+ Fpos_visible_in_window_p(pos.to_raw(), window.to_raw(), Qt)\n+ });\n+ if tem.is_nil() {\n+ return LispObject::constant_nil();\n+ }\n+\n+ let x = tem.as_cons()\n+ .and_then(|c| Some(c.car()))\n+ .unwrap_or_else(|| LispObject::from_fixnum(0));\n+ let y = tem.as_cons()\n+ .and_then(|c| Some(c.cdr()))\n+ .and_then(|c| c.as_cons())\n+ .and_then(|c| Some(c.car()))\n+ .unwrap_or_else(|| LispObject::from_fixnum(0));\n+ let aux_info = tem.as_cons()\n+ .and_then(|c| Some(c.cdr()))\n+ .and_then(|c| c.as_cons())\n+ .and_then(|c| Some(c.cdr()))\n+ .unwrap_or_else(|| LispObject::from_fixnum(0));\n+ let mut y_coord = y.as_fixnum_or_error();\n+ let x_coord = x.as_fixnum_or_error();\n+\n+ /* Point invisible due to hscrolling? X can be -1 when a\n+ newline in a R2L line overflows into the left fringe. */\n+ if x_coord < -1 {","path":"rust_src/src/keyboard.rs","position":50,"original_position":50,"commit_id":"f182d397e1f4d7f8b6c4502d62a7e59102cb00c6","original_commit_id":"f182d397e1f4d7f8b6c4502d62a7e59102cb00c6","user":{"login":"brotzeit","id":25367303,"avatar_url":"https://avatars0.githubusercontent.com/u/25367303?v=4","gravatar_id":"","url":"https://api.github.com/users/brotzeit","html_url":"https://github.com/brotzeit","followers_url":"https://api.github.com/users/brotzeit/followers","following_url":"https://api.github.com/users/brotzeit/following{/other_user}","gists_url":"https://api.github.com/users/brotzeit/gists{/gist_id}","starred_url":"https://api.github.com/users/brotzeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brotzeit/subscriptions","organizations_url":"https://api.github.com/users/brotzeit/orgs","repos_url":"https://api.github.com/users/brotzeit/repos","events_url":"https://api.github.com/users/brotzeit/events{/privacy}","received_events_url":"https://api.github.com/users/brotzeit/received_events","type":"User","site_admin":false},"body":"Comment needs to be fixed.","created_at":"2017-11-06T19:00:05Z","updated_at":"2017-11-06T19:00:05Z","html_url":"https://github.com/Wilfred/remacs/pull/457#discussion_r149170753","pull_request_url":"https://api.github.com/repos/Wilfred/remacs/pulls/457","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/comments/149170753"},"html":{"href":"https://github.com/Wilfred/remacs/pull/457#discussion_r149170753"},"pull_request":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/457"}}},"pull_request":{"url":"https://api.github.com/repos/Wilfred/remacs/pulls/457","id":150464901,"html_url":"https://github.com/Wilfred/remacs/pull/457","diff_url":"https://github.com/Wilfred/remacs/pull/457.diff","patch_url":"https://github.com/Wilfred/remacs/pull/457.patch","issue_url":"https://api.github.com/repos/Wilfred/remacs/issues/457","number":457,"state":"closed","locked":false,"title":"Port posn-at-point","user":{"login":"shaleh","id":1377996,"avatar_url":"https://avatars3.githubusercontent.com/u/1377996?v=4","gravatar_id":"","url":"https://api.github.com/users/shaleh","html_url":"https://github.com/shaleh","followers_url":"https://api.github.com/users/shaleh/followers","following_url":"https://api.github.com/users/shaleh/following{/other_user}","gists_url":"https://api.github.com/users/shaleh/gists{/gist_id}","starred_url":"https://api.github.com/users/shaleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaleh/subscriptions","organizations_url":"https://api.github.com/users/shaleh/orgs","repos_url":"https://api.github.com/users/shaleh/repos","events_url":"https://api.github.com/users/shaleh/events{/privacy}","received_events_url":"https://api.github.com/users/shaleh/received_events","type":"User","site_admin":false},"body":"This port shows how little changes are needed to add a new file.","created_at":"2017-11-03T07:03:03Z","updated_at":"2017-11-06T19:00:05Z","closed_at":"2017-11-06T18:55:09Z","merged_at":"2017-11-06T18:55:09Z","merge_commit_sha":"5bcabeae6845ffebcd343da9034f17f00f8200ff","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Wilfred/remacs/pulls/457/commits","review_comments_url":"https://api.github.com/repos/Wilfred/remacs/pulls/457/comments","review_comment_url":"https://api.github.com/repos/Wilfred/remacs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wilfred/remacs/issues/457/comments","statuses_url":"https://api.github.com/repos/Wilfred/remacs/statuses/f182d397e1f4d7f8b6c4502d62a7e59102cb00c6","head":{"label":"shaleh:port-posn-at-point","ref":"port-posn-at-point","sha":"f182d397e1f4d7f8b6c4502d62a7e59102cb00c6","user":{"login":"shaleh","id":1377996,"avatar_url":"https://avatars3.githubusercontent.com/u/1377996?v=4","gravatar_id":"","url":"https://api.github.com/users/shaleh","html_url":"https://github.com/shaleh","followers_url":"https://api.github.com/users/shaleh/followers","following_url":"https://api.github.com/users/shaleh/following{/other_user}","gists_url":"https://api.github.com/users/shaleh/gists{/gist_id}","starred_url":"https://api.github.com/users/shaleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaleh/subscriptions","organizations_url":"https://api.github.com/users/shaleh/orgs","repos_url":"https://api.github.com/users/shaleh/repos","events_url":"https://api.github.com/users/shaleh/events{/privacy}","received_events_url":"https://api.github.com/users/shaleh/received_events","type":"User","site_admin":false},"repo":{"id":107508596,"name":"remacs","full_name":"shaleh/remacs","owner":{"login":"shaleh","id":1377996,"avatar_url":"https://avatars3.githubusercontent.com/u/1377996?v=4","gravatar_id":"","url":"https://api.github.com/users/shaleh","html_url":"https://github.com/shaleh","followers_url":"https://api.github.com/users/shaleh/followers","following_url":"https://api.github.com/users/shaleh/following{/other_user}","gists_url":"https://api.github.com/users/shaleh/gists{/gist_id}","starred_url":"https://api.github.com/users/shaleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaleh/subscriptions","organizations_url":"https://api.github.com/users/shaleh/orgs","repos_url":"https://api.github.com/users/shaleh/repos","events_url":"https://api.github.com/users/shaleh/events{/privacy}","received_events_url":"https://api.github.com/users/shaleh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shaleh/remacs","description":"Rust :heart: Emacs","fork":true,"url":"https://api.github.com/repos/shaleh/remacs","forks_url":"https://api.github.com/repos/shaleh/remacs/forks","keys_url":"https://api.github.com/repos/shaleh/remacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shaleh/remacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shaleh/remacs/teams","hooks_url":"https://api.github.com/repos/shaleh/remacs/hooks","issue_events_url":"https://api.github.com/repos/shaleh/remacs/issues/events{/number}","events_url":"https://api.github.com/repos/shaleh/remacs/events","assignees_url":"https://api.github.com/repos/shaleh/remacs/assignees{/user}","branches_url":"https://api.github.com/repos/shaleh/remacs/branches{/branch}","tags_url":"https://api.github.com/repos/shaleh/remacs/tags","blobs_url":"https://api.github.com/repos/shaleh/remacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shaleh/remacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shaleh/remacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/shaleh/remacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shaleh/remacs/statuses/{sha}","languages_url":"https://api.github.com/repos/shaleh/remacs/languages","stargazers_url":"https://api.github.com/repos/shaleh/remacs/stargazers","contributors_url":"https://api.github.com/repos/shaleh/remacs/contributors","subscribers_url":"https://api.github.com/repos/shaleh/remacs/subscribers","subscription_url":"https://api.github.com/repos/shaleh/remacs/subscription","commits_url":"https://api.github.com/repos/shaleh/remacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/shaleh/remacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/shaleh/remacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/shaleh/remacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/shaleh/remacs/contents/{+path}","compare_url":"https://api.github.com/repos/shaleh/remacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shaleh/remacs/merges","archive_url":"https://api.github.com/repos/shaleh/remacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shaleh/remacs/downloads","issues_url":"https://api.github.com/repos/shaleh/remacs/issues{/number}","pulls_url":"https://api.github.com/repos/shaleh/remacs/pulls{/number}","milestones_url":"https://api.github.com/repos/shaleh/remacs/milestones{/number}","notifications_url":"https://api.github.com/repos/shaleh/remacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shaleh/remacs/labels{/name}","releases_url":"https://api.github.com/repos/shaleh/remacs/releases{/id}","deployments_url":"https://api.github.com/repos/shaleh/remacs/deployments","created_at":"2017-10-19T06:48:22Z","updated_at":"2017-10-19T06:48:45Z","pushed_at":"2017-11-06T18:55:21Z","git_url":"git://github.com/shaleh/remacs.git","ssh_url":"[email protected]:shaleh/remacs.git","clone_url":"https://github.com/shaleh/remacs.git","svn_url":"https://github.com/shaleh/remacs","homepage":"","size":260265,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Wilfred:master","ref":"master","sha":"1db480cf7f94c28854a3755f551806495b5e0c72","user":{"login":"Wilfred","id":70800,"avatar_url":"https://avatars0.githubusercontent.com/u/70800?v=4","gravatar_id":"","url":"https://api.github.com/users/Wilfred","html_url":"https://github.com/Wilfred","followers_url":"https://api.github.com/users/Wilfred/followers","following_url":"https://api.github.com/users/Wilfred/following{/other_user}","gists_url":"https://api.github.com/users/Wilfred/gists{/gist_id}","starred_url":"https://api.github.com/users/Wilfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wilfred/subscriptions","organizations_url":"https://api.github.com/users/Wilfred/orgs","repos_url":"https://api.github.com/users/Wilfred/repos","events_url":"https://api.github.com/users/Wilfred/events{/privacy}","received_events_url":"https://api.github.com/users/Wilfred/received_events","type":"User","site_admin":false},"repo":{"id":74522337,"name":"remacs","full_name":"Wilfred/remacs","owner":{"login":"Wilfred","id":70800,"avatar_url":"https://avatars0.githubusercontent.com/u/70800?v=4","gravatar_id":"","url":"https://api.github.com/users/Wilfred","html_url":"https://github.com/Wilfred","followers_url":"https://api.github.com/users/Wilfred/followers","following_url":"https://api.github.com/users/Wilfred/following{/other_user}","gists_url":"https://api.github.com/users/Wilfred/gists{/gist_id}","starred_url":"https://api.github.com/users/Wilfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wilfred/subscriptions","organizations_url":"https://api.github.com/users/Wilfred/orgs","repos_url":"https://api.github.com/users/Wilfred/repos","events_url":"https://api.github.com/users/Wilfred/events{/privacy}","received_events_url":"https://api.github.com/users/Wilfred/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Wilfred/remacs","description":"Rust :heart: Emacs","fork":false,"url":"https://api.github.com/repos/Wilfred/remacs","forks_url":"https://api.github.com/repos/Wilfred/remacs/forks","keys_url":"https://api.github.com/repos/Wilfred/remacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wilfred/remacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wilfred/remacs/teams","hooks_url":"https://api.github.com/repos/Wilfred/remacs/hooks","issue_events_url":"https://api.github.com/repos/Wilfred/remacs/issues/events{/number}","events_url":"https://api.github.com/repos/Wilfred/remacs/events","assignees_url":"https://api.github.com/repos/Wilfred/remacs/assignees{/user}","branches_url":"https://api.github.com/repos/Wilfred/remacs/branches{/branch}","tags_url":"https://api.github.com/repos/Wilfred/remacs/tags","blobs_url":"https://api.github.com/repos/Wilfred/remacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wilfred/remacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wilfred/remacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wilfred/remacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wilfred/remacs/statuses/{sha}","languages_url":"https://api.github.com/repos/Wilfred/remacs/languages","stargazers_url":"https://api.github.com/repos/Wilfred/remacs/stargazers","contributors_url":"https://api.github.com/repos/Wilfred/remacs/contributors","subscribers_url":"https://api.github.com/repos/Wilfred/remacs/subscribers","subscription_url":"https://api.github.com/repos/Wilfred/remacs/subscription","commits_url":"https://api.github.com/repos/Wilfred/remacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wilfred/remacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wilfred/remacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wilfred/remacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wilfred/remacs/contents/{+path}","compare_url":"https://api.github.com/repos/Wilfred/remacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wilfred/remacs/merges","archive_url":"https://api.github.com/repos/Wilfred/remacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wilfred/remacs/downloads","issues_url":"https://api.github.com/repos/Wilfred/remacs/issues{/number}","pulls_url":"https://api.github.com/repos/Wilfred/remacs/pulls{/number}","milestones_url":"https://api.github.com/repos/Wilfred/remacs/milestones{/number}","notifications_url":"https://api.github.com/repos/Wilfred/remacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wilfred/remacs/labels{/name}","releases_url":"https://api.github.com/repos/Wilfred/remacs/releases{/id}","deployments_url":"https://api.github.com/repos/Wilfred/remacs/deployments","created_at":"2016-11-22T23:29:21Z","updated_at":"2017-11-06T08:41:23Z","pushed_at":"2017-11-06T18:55:09Z","git_url":"git://github.com/Wilfred/remacs.git","ssh_url":"[email protected]:Wilfred/remacs.git","clone_url":"https://github.com/Wilfred/remacs.git","svn_url":"https://github.com/Wilfred/remacs","homepage":"","size":260159,"stargazers_count":1967,"watchers_count":1967,"language":"Emacs Lisp","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":151,"mirror_url":null,"archived":false,"open_issues_count":64,"forks":151,"open_issues":64,"watchers":1967,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/457"},"html":{"href":"https://github.com/Wilfred/remacs/pull/457"},"issue":{"href":"https://api.github.com/repos/Wilfred/remacs/issues/457"},"comments":{"href":"https://api.github.com/repos/Wilfred/remacs/issues/457/comments"},"review_comments":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/457/comments"},"review_comment":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/457/commits"},"statuses":{"href":"https://api.github.com/repos/Wilfred/remacs/statuses/f182d397e1f4d7f8b6c4502d62a7e59102cb00c6"}},"author_association":"COLLABORATOR"}} | {
"id": 74522337,
"name": "Wilfred/remacs",
"url": "https://api.github.com/repos/Wilfred/remacs"
} | {
"id": 25367303,
"login": "brotzeit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25367303?",
"url": "https://api.github.com/users/brotzeit"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-11-06T19:00:05 | 6816256470 | {"actor":{"display_login":"brotzeit"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/nickmccurdy/password-entropy/pulls/comments/137240827","pull_request_review_id":60878837,"id":137240827,"diff_hunk":"@@ -1,16 +1,20 @@\n+import { MuiThemeProvider } from 'material-ui'","path":"src/index.js","position":1,"original_position":1,"commit_id":"d3458e6fe2afc282136c5b82407e882aa9ec6a93","original_commit_id":"d3458e6fe2afc282136c5b82407e882aa9ec6a93","user":{"login":"nickmccurdy","id":927220,"avatar_url":"https://avatars0.githubusercontent.com/u/927220?v=4","gravatar_id":"","url":"https://api.github.com/users/nickmccurdy","html_url":"https://github.com/nickmccurdy","followers_url":"https://api.github.com/users/nickmccurdy/followers","following_url":"https://api.github.com/users/nickmccurdy/following{/other_user}","gists_url":"https://api.github.com/users/nickmccurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/nickmccurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickmccurdy/subscriptions","organizations_url":"https://api.github.com/users/nickmccurdy/orgs","repos_url":"https://api.github.com/users/nickmccurdy/repos","events_url":"https://api.github.com/users/nickmccurdy/events{/privacy}","received_events_url":"https://api.github.com/users/nickmccurdy/received_events","type":"User","site_admin":false},"body":"Optimize imports","created_at":"2017-09-06T11:29:46Z","updated_at":"2017-09-06T11:30:56Z","html_url":"https://github.com/nickmccurdy/password-entropy/pull/21#discussion_r137240827","pull_request_url":"https://api.github.com/repos/nickmccurdy/password-entropy/pulls/21","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/nickmccurdy/password-entropy/pulls/comments/137240827"},"html":{"href":"https://github.com/nickmccurdy/password-entropy/pull/21#discussion_r137240827"},"pull_request":{"href":"https://api.github.com/repos/nickmccurdy/password-entropy/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/nickmccurdy/password-entropy/pulls/21","id":139535988,"html_url":"https://github.com/nickmccurdy/password-entropy/pull/21","diff_url":"https://github.com/nickmccurdy/password-entropy/pull/21.diff","patch_url":"https://github.com/nickmccurdy/password-entropy/pull/21.patch","issue_url":"https://api.github.com/repos/nickmccurdy/password-entropy/issues/21","number":21,"state":"open","locked":false,"title":"Material-UI","user":{"login":"nickmccurdy","id":927220,"avatar_url":"https://avatars0.githubusercontent.com/u/927220?v=4","gravatar_id":"","url":"https://api.github.com/users/nickmccurdy","html_url":"https://github.com/nickmccurdy","followers_url":"https://api.github.com/users/nickmccurdy/followers","following_url":"https://api.github.com/users/nickmccurdy/following{/other_user}","gists_url":"https://api.github.com/users/nickmccurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/nickmccurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickmccurdy/subscriptions","organizations_url":"https://api.github.com/users/nickmccurdy/orgs","repos_url":"https://api.github.com/users/nickmccurdy/repos","events_url":"https://api.github.com/users/nickmccurdy/events{/privacy}","received_events_url":"https://api.github.com/users/nickmccurdy/received_events","type":"User","site_admin":false},"body":"Fixes #13.","created_at":"2017-09-06T11:21:20Z","updated_at":"2017-09-06T11:30:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92c81f28bef6e5be0dde87d5e84532ee99c1d3b8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nickmccurdy/password-entropy/pulls/21/commits","review_comments_url":"https://api.github.com/repos/nickmccurdy/password-entropy/pulls/21/comments","review_comment_url":"https://api.github.com/repos/nickmccurdy/password-entropy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nickmccurdy/password-entropy/issues/21/comments","statuses_url":"https://api.github.com/repos/nickmccurdy/password-entropy/statuses/d3458e6fe2afc282136c5b82407e882aa9ec6a93","head":{"label":"nickmccurdy:material-ui","ref":"material-ui","sha":"d3458e6fe2afc282136c5b82407e882aa9ec6a93","user":{"login":"nickmccurdy","id":927220,"avatar_url":"https://avatars0.githubusercontent.com/u/927220?v=4","gravatar_id":"","url":"https://api.github.com/users/nickmccurdy","html_url":"https://github.com/nickmccurdy","followers_url":"https://api.github.com/users/nickmccurdy/followers","following_url":"https://api.github.com/users/nickmccurdy/following{/other_user}","gists_url":"https://api.github.com/users/nickmccurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/nickmccurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickmccurdy/subscriptions","organizations_url":"https://api.github.com/users/nickmccurdy/orgs","repos_url":"https://api.github.com/users/nickmccurdy/repos","events_url":"https://api.github.com/users/nickmccurdy/events{/privacy}","received_events_url":"https://api.github.com/users/nickmccurdy/received_events","type":"User","site_admin":false},"repo":{"id":96635553,"name":"password-entropy","full_name":"nickmccurdy/password-entropy","owner":{"login":"nickmccurdy","id":927220,"avatar_url":"https://avatars0.githubusercontent.com/u/927220?v=4","gravatar_id":"","url":"https://api.github.com/users/nickmccurdy","html_url":"https://github.com/nickmccurdy","followers_url":"https://api.github.com/users/nickmccurdy/followers","following_url":"https://api.github.com/users/nickmccurdy/following{/other_user}","gists_url":"https://api.github.com/users/nickmccurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/nickmccurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickmccurdy/subscriptions","organizations_url":"https://api.github.com/users/nickmccurdy/orgs","repos_url":"https://api.github.com/users/nickmccurdy/repos","events_url":"https://api.github.com/users/nickmccurdy/events{/privacy}","received_events_url":"https://api.github.com/users/nickmccurdy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nickmccurdy/password-entropy","description":"A simple entropy calculator for evaluating password security.","fork":false,"url":"https://api.github.com/repos/nickmccurdy/password-entropy","forks_url":"https://api.github.com/repos/nickmccurdy/password-entropy/forks","keys_url":"https://api.github.com/repos/nickmccurdy/password-entropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nickmccurdy/password-entropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nickmccurdy/password-entropy/teams","hooks_url":"https://api.github.com/repos/nickmccurdy/password-entropy/hooks","issue_events_url":"https://api.github.com/repos/nickmccurdy/password-entropy/issues/events{/number}","events_url":"https://api.github.com/repos/nickmccurdy/password-entropy/events","assignees_url":"https://api.github.com/repos/nickmccurdy/password-entropy/assignees{/user}","branches_url":"https://api.github.com/repos/nickmccurdy/password-entropy/branches{/branch}","tags_url":"https://api.github.com/repos/nickmccurdy/password-entropy/tags","blobs_url":"https://api.github.com/repos/nickmccurdy/password-entropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nickmccurdy/password-entropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nickmccurdy/password-entropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/nickmccurdy/password-entropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nickmccurdy/password-entropy/statuses/{sha}","languages_url":"https://api.github.com/repos/nickmccurdy/password-entropy/languages","stargazers_url":"https://api.github.com/repos/nickmccurdy/password-entropy/stargazers","contributors_url":"https://api.github.com/repos/nickmccurdy/password-entropy/contributors","subscribers_url":"https://api.github.com/repos/nickmccurdy/password-entropy/subscribers","subscription_url":"https://api.github.com/repos/nickmccurdy/password-entropy/subscription","commits_url":"https://api.github.com/repos/nickmccurdy/password-entropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/nickmccurdy/password-entropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/nickmccurdy/password-entropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/nickmccurdy/password-entropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/nickmccurdy/password-entropy/contents/{+path}","compare_url":"https://api.github.com/repos/nickmccurdy/password-entropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nickmccurdy/password-entropy/merges","archive_url":"https://api.github.com/repos/nickmccurdy/password-entropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nickmccurdy/password-entropy/downloads","issues_url":"https://api.github.com/repos/nickmccurdy/password-entropy/issues{/number}","pulls_url":"https://api.github.com/repos/nickmccurdy/password-entropy/pulls{/number}","milestones_url":"https://api.github.com/repos/nickmccurdy/password-entropy/milestones{/number}","notifications_url":"https://api.github.com/repos/nickmccurdy/password-entropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nickmccurdy/password-entropy/labels{/name}","releases_url":"https://api.github.com/repos/nickmccurdy/password-entropy/releases{/id}","deployments_url":"https://api.github.com/repos/nickmccurdy/password-entropy/deployments","created_at":"2017-07-08T18:01:02Z","updated_at":"2017-07-24T01:53:17Z","pushed_at":"2017-09-06T11:21:21Z","git_url":"git://github.com/nickmccurdy/password-entropy.git","ssh_url":"[email protected]:nickmccurdy/password-entropy.git","clone_url":"https://github.com/nickmccurdy/password-entropy.git","svn_url":"https://github.com/nickmccurdy/password-entropy","homepage":"http://nickmccurdy.com/password-entropy/","size":2446,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"nickmccurdy:master","ref":"master","sha":"eae4f00b73ac727bcd2088324bef760280ed81bc","user":{"login":"nickmccurdy","id":927220,"avatar_url":"https://avatars0.githubusercontent.com/u/927220?v=4","gravatar_id":"","url":"https://api.github.com/users/nickmccurdy","html_url":"https://github.com/nickmccurdy","followers_url":"https://api.github.com/users/nickmccurdy/followers","following_url":"https://api.github.com/users/nickmccurdy/following{/other_user}","gists_url":"https://api.github.com/users/nickmccurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/nickmccurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickmccurdy/subscriptions","organizations_url":"https://api.github.com/users/nickmccurdy/orgs","repos_url":"https://api.github.com/users/nickmccurdy/repos","events_url":"https://api.github.com/users/nickmccurdy/events{/privacy}","received_events_url":"https://api.github.com/users/nickmccurdy/received_events","type":"User","site_admin":false},"repo":{"id":96635553,"name":"password-entropy","full_name":"nickmccurdy/password-entropy","owner":{"login":"nickmccurdy","id":927220,"avatar_url":"https://avatars0.githubusercontent.com/u/927220?v=4","gravatar_id":"","url":"https://api.github.com/users/nickmccurdy","html_url":"https://github.com/nickmccurdy","followers_url":"https://api.github.com/users/nickmccurdy/followers","following_url":"https://api.github.com/users/nickmccurdy/following{/other_user}","gists_url":"https://api.github.com/users/nickmccurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/nickmccurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickmccurdy/subscriptions","organizations_url":"https://api.github.com/users/nickmccurdy/orgs","repos_url":"https://api.github.com/users/nickmccurdy/repos","events_url":"https://api.github.com/users/nickmccurdy/events{/privacy}","received_events_url":"https://api.github.com/users/nickmccurdy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nickmccurdy/password-entropy","description":"A simple entropy calculator for evaluating password security.","fork":false,"url":"https://api.github.com/repos/nickmccurdy/password-entropy","forks_url":"https://api.github.com/repos/nickmccurdy/password-entropy/forks","keys_url":"https://api.github.com/repos/nickmccurdy/password-entropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nickmccurdy/password-entropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nickmccurdy/password-entropy/teams","hooks_url":"https://api.github.com/repos/nickmccurdy/password-entropy/hooks","issue_events_url":"https://api.github.com/repos/nickmccurdy/password-entropy/issues/events{/number}","events_url":"https://api.github.com/repos/nickmccurdy/password-entropy/events","assignees_url":"https://api.github.com/repos/nickmccurdy/password-entropy/assignees{/user}","branches_url":"https://api.github.com/repos/nickmccurdy/password-entropy/branches{/branch}","tags_url":"https://api.github.com/repos/nickmccurdy/password-entropy/tags","blobs_url":"https://api.github.com/repos/nickmccurdy/password-entropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nickmccurdy/password-entropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nickmccurdy/password-entropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/nickmccurdy/password-entropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nickmccurdy/password-entropy/statuses/{sha}","languages_url":"https://api.github.com/repos/nickmccurdy/password-entropy/languages","stargazers_url":"https://api.github.com/repos/nickmccurdy/password-entropy/stargazers","contributors_url":"https://api.github.com/repos/nickmccurdy/password-entropy/contributors","subscribers_url":"https://api.github.com/repos/nickmccurdy/password-entropy/subscribers","subscription_url":"https://api.github.com/repos/nickmccurdy/password-entropy/subscription","commits_url":"https://api.github.com/repos/nickmccurdy/password-entropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/nickmccurdy/password-entropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/nickmccurdy/password-entropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/nickmccurdy/password-entropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/nickmccurdy/password-entropy/contents/{+path}","compare_url":"https://api.github.com/repos/nickmccurdy/password-entropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nickmccurdy/password-entropy/merges","archive_url":"https://api.github.com/repos/nickmccurdy/password-entropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nickmccurdy/password-entropy/downloads","issues_url":"https://api.github.com/repos/nickmccurdy/password-entropy/issues{/number}","pulls_url":"https://api.github.com/repos/nickmccurdy/password-entropy/pulls{/number}","milestones_url":"https://api.github.com/repos/nickmccurdy/password-entropy/milestones{/number}","notifications_url":"https://api.github.com/repos/nickmccurdy/password-entropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nickmccurdy/password-entropy/labels{/name}","releases_url":"https://api.github.com/repos/nickmccurdy/password-entropy/releases{/id}","deployments_url":"https://api.github.com/repos/nickmccurdy/password-entropy/deployments","created_at":"2017-07-08T18:01:02Z","updated_at":"2017-07-24T01:53:17Z","pushed_at":"2017-09-06T11:21:21Z","git_url":"git://github.com/nickmccurdy/password-entropy.git","ssh_url":"[email protected]:nickmccurdy/password-entropy.git","clone_url":"https://github.com/nickmccurdy/password-entropy.git","svn_url":"https://github.com/nickmccurdy/password-entropy","homepage":"http://nickmccurdy.com/password-entropy/","size":2446,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nickmccurdy/password-entropy/pulls/21"},"html":{"href":"https://github.com/nickmccurdy/password-entropy/pull/21"},"issue":{"href":"https://api.github.com/repos/nickmccurdy/password-entropy/issues/21"},"comments":{"href":"https://api.github.com/repos/nickmccurdy/password-entropy/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/nickmccurdy/password-entropy/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/nickmccurdy/password-entropy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nickmccurdy/password-entropy/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/nickmccurdy/password-entropy/statuses/d3458e6fe2afc282136c5b82407e882aa9ec6a93"}},"author_association":"OWNER"}} | {
"id": 96635553,
"name": "nickmccurdy/password-entropy",
"url": "https://api.github.com/repos/nickmccurdy/password-entropy"
} | {
"id": 927220,
"login": "nickmccurdy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/927220?",
"url": "https://api.github.com/users/nickmccurdy"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-09-06T11:29:46 | 6555727021 | {"actor":{"display_login":"nickmccurdy"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/pulls/comments/110540550","pull_request_review_id":31722834,"id":110540550,"diff_hunk":"@@ -0,0 +1,29 @@\n+module MailerLite\n+ module Utils\n+ BLANK_RE = /\\A[[:space:]]*\\z/\n+\n+ class << self\n+ def underscore(string)\n+ string.gsub(/::/, '/')\n+ .gsub(/([A-Z]+)([A-Z][a-z])/, '\\1_\\2')\n+ .gsub(/([a-z\\d])([A-Z])/, '\\1_\\2')\n+ .tr('-', '_')\n+ .downcase\n+ end\n+\n+ def blank?(obj)\n+ return !!BLANK_RE.match(obj) if obj.is_a?(String)\n+\n+ obj.respond_to?(:empty?) ? !!obj.empty? : !obj","path":"lib/mailerlite/utils.rb","position":17,"original_position":17,"commit_id":"b5f881d03085f88a8f7fe5c79c8f847a653f8f2d","original_commit_id":"b5f881d03085f88a8f7fe5c79c8f847a653f8f2d","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars3.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Avoid the use of double negation (!!).","created_at":"2017-04-09T12:48:50Z","updated_at":"2017-04-09T12:48:50Z","html_url":"https://github.com/jpalumickas/mailerlite-ruby/pull/8#discussion_r110540550","pull_request_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/pulls/comments/110540550"},"html":{"href":"https://github.com/jpalumickas/mailerlite-ruby/pull/8#discussion_r110540550"},"pull_request":{"href":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/pulls/8","id":114984770,"html_url":"https://github.com/jpalumickas/mailerlite-ruby/pull/8","diff_url":"https://github.com/jpalumickas/mailerlite-ruby/pull/8.diff","patch_url":"https://github.com/jpalumickas/mailerlite-ruby/pull/8.patch","issue_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/issues/8","number":8,"state":"open","locked":false,"title":"Error message from response","user":{"login":"jpalumickas","id":2738630,"avatar_url":"https://avatars0.githubusercontent.com/u/2738630?v=3","gravatar_id":"","url":"https://api.github.com/users/jpalumickas","html_url":"https://github.com/jpalumickas","followers_url":"https://api.github.com/users/jpalumickas/followers","following_url":"https://api.github.com/users/jpalumickas/following{/other_user}","gists_url":"https://api.github.com/users/jpalumickas/gists{/gist_id}","starred_url":"https://api.github.com/users/jpalumickas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpalumickas/subscriptions","organizations_url":"https://api.github.com/users/jpalumickas/orgs","repos_url":"https://api.github.com/users/jpalumickas/repos","events_url":"https://api.github.com/users/jpalumickas/events{/privacy}","received_events_url":"https://api.github.com/users/jpalumickas/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-09T12:48:37Z","updated_at":"2017-04-09T12:48:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efb266797a8f05e462e0c85858961f09938358e6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/pulls/8/commits","review_comments_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/pulls/8/comments","review_comment_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/issues/8/comments","statuses_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/statuses/b5f881d03085f88a8f7fe5c79c8f847a653f8f2d","head":{"label":"jpalumickas:feature/error-message-from-response","ref":"feature/error-message-from-response","sha":"b5f881d03085f88a8f7fe5c79c8f847a653f8f2d","user":{"login":"jpalumickas","id":2738630,"avatar_url":"https://avatars0.githubusercontent.com/u/2738630?v=3","gravatar_id":"","url":"https://api.github.com/users/jpalumickas","html_url":"https://github.com/jpalumickas","followers_url":"https://api.github.com/users/jpalumickas/followers","following_url":"https://api.github.com/users/jpalumickas/following{/other_user}","gists_url":"https://api.github.com/users/jpalumickas/gists{/gist_id}","starred_url":"https://api.github.com/users/jpalumickas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpalumickas/subscriptions","organizations_url":"https://api.github.com/users/jpalumickas/orgs","repos_url":"https://api.github.com/users/jpalumickas/repos","events_url":"https://api.github.com/users/jpalumickas/events{/privacy}","received_events_url":"https://api.github.com/users/jpalumickas/received_events","type":"User","site_admin":false},"repo":{"id":56453403,"name":"mailerlite-ruby","full_name":"jpalumickas/mailerlite-ruby","owner":{"login":"jpalumickas","id":2738630,"avatar_url":"https://avatars0.githubusercontent.com/u/2738630?v=3","gravatar_id":"","url":"https://api.github.com/users/jpalumickas","html_url":"https://github.com/jpalumickas","followers_url":"https://api.github.com/users/jpalumickas/followers","following_url":"https://api.github.com/users/jpalumickas/following{/other_user}","gists_url":"https://api.github.com/users/jpalumickas/gists{/gist_id}","starred_url":"https://api.github.com/users/jpalumickas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpalumickas/subscriptions","organizations_url":"https://api.github.com/users/jpalumickas/orgs","repos_url":"https://api.github.com/users/jpalumickas/repos","events_url":"https://api.github.com/users/jpalumickas/events{/privacy}","received_events_url":"https://api.github.com/users/jpalumickas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpalumickas/mailerlite-ruby","description":"Ruby wrapper for MailerLite API v2","fork":false,"url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby","forks_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/forks","keys_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/teams","hooks_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/hooks","issue_events_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/events","assignees_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/tags","blobs_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/languages","stargazers_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/stargazers","contributors_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/contributors","subscribers_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/subscribers","subscription_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/subscription","commits_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/merges","archive_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/downloads","issues_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/labels{/name}","releases_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/deployments","created_at":"2016-04-17T19:06:43Z","updated_at":"2017-01-26T13:39:36Z","pushed_at":"2017-04-09T12:48:38Z","git_url":"git://github.com/jpalumickas/mailerlite-ruby.git","ssh_url":"[email protected]:jpalumickas/mailerlite-ruby.git","clone_url":"https://github.com/jpalumickas/mailerlite-ruby.git","svn_url":"https://github.com/jpalumickas/mailerlite-ruby","homepage":"","size":69,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"jpalumickas:master","ref":"master","sha":"62ab464d24af8b1b8a677694e16d20de9b1bfe08","user":{"login":"jpalumickas","id":2738630,"avatar_url":"https://avatars0.githubusercontent.com/u/2738630?v=3","gravatar_id":"","url":"https://api.github.com/users/jpalumickas","html_url":"https://github.com/jpalumickas","followers_url":"https://api.github.com/users/jpalumickas/followers","following_url":"https://api.github.com/users/jpalumickas/following{/other_user}","gists_url":"https://api.github.com/users/jpalumickas/gists{/gist_id}","starred_url":"https://api.github.com/users/jpalumickas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpalumickas/subscriptions","organizations_url":"https://api.github.com/users/jpalumickas/orgs","repos_url":"https://api.github.com/users/jpalumickas/repos","events_url":"https://api.github.com/users/jpalumickas/events{/privacy}","received_events_url":"https://api.github.com/users/jpalumickas/received_events","type":"User","site_admin":false},"repo":{"id":56453403,"name":"mailerlite-ruby","full_name":"jpalumickas/mailerlite-ruby","owner":{"login":"jpalumickas","id":2738630,"avatar_url":"https://avatars0.githubusercontent.com/u/2738630?v=3","gravatar_id":"","url":"https://api.github.com/users/jpalumickas","html_url":"https://github.com/jpalumickas","followers_url":"https://api.github.com/users/jpalumickas/followers","following_url":"https://api.github.com/users/jpalumickas/following{/other_user}","gists_url":"https://api.github.com/users/jpalumickas/gists{/gist_id}","starred_url":"https://api.github.com/users/jpalumickas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpalumickas/subscriptions","organizations_url":"https://api.github.com/users/jpalumickas/orgs","repos_url":"https://api.github.com/users/jpalumickas/repos","events_url":"https://api.github.com/users/jpalumickas/events{/privacy}","received_events_url":"https://api.github.com/users/jpalumickas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpalumickas/mailerlite-ruby","description":"Ruby wrapper for MailerLite API v2","fork":false,"url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby","forks_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/forks","keys_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/teams","hooks_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/hooks","issue_events_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/events","assignees_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/tags","blobs_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/languages","stargazers_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/stargazers","contributors_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/contributors","subscribers_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/subscribers","subscription_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/subscription","commits_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/merges","archive_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/downloads","issues_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/labels{/name}","releases_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/deployments","created_at":"2016-04-17T19:06:43Z","updated_at":"2017-01-26T13:39:36Z","pushed_at":"2017-04-09T12:48:38Z","git_url":"git://github.com/jpalumickas/mailerlite-ruby.git","ssh_url":"[email protected]:jpalumickas/mailerlite-ruby.git","clone_url":"https://github.com/jpalumickas/mailerlite-ruby.git","svn_url":"https://github.com/jpalumickas/mailerlite-ruby","homepage":"","size":69,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/pulls/8"},"html":{"href":"https://github.com/jpalumickas/mailerlite-ruby/pull/8"},"issue":{"href":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/issues/8"},"comments":{"href":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/jpalumickas/mailerlite-ruby/statuses/b5f881d03085f88a8f7fe5c79c8f847a653f8f2d"}}}} | {
"id": 56453403,
"name": "jpalumickas/mailerlite-ruby",
"url": "https://api.github.com/repos/jpalumickas/mailerlite-ruby"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-04-09T12:48:50 | 5654851581 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/saadyousafarbi/week1/pulls/comments/128479029","pull_request_review_id":51160019,"id":128479029,"diff_hunk":"@@ -1,85 +1,85 @@\n import requests\n \n-API_KEY = '9104e0a25f676b56ac31901d10c5cf0a'\n-\n-\n-def verify_city(json_response):\n- \"\"\"\n- Takes in response from OWM and checks if city exists\n \n- Arguments:\n- json_response (json): contains response of a request from OWM\n- \"\"\"\n-\n- if json_response['cod'] == '404':\n- print 'City could not be found, please retry'\n-\treturn False\n- else:\n-\tprint 'City found'\n-\treturn True\n+API_KEY = '9104e0a25f676b56ac31901d10c5cf0a'","path":"weather_finder/weather_finder.py","position":20,"original_position":20,"commit_id":"451c187726d3d39302f1bbab3ae07b743a4120b6","original_commit_id":"451c187726d3d39302f1bbab3ae07b743a4120b6","user":{"login":"zubair-arbi","id":5072991,"avatar_url":"https://avatars2.githubusercontent.com/u/5072991?v=4","gravatar_id":"","url":"https://api.github.com/users/zubair-arbi","html_url":"https://github.com/zubair-arbi","followers_url":"https://api.github.com/users/zubair-arbi/followers","following_url":"https://api.github.com/users/zubair-arbi/following{/other_user}","gists_url":"https://api.github.com/users/zubair-arbi/gists{/gist_id}","starred_url":"https://api.github.com/users/zubair-arbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zubair-arbi/subscriptions","organizations_url":"https://api.github.com/users/zubair-arbi/orgs","repos_url":"https://api.github.com/users/zubair-arbi/repos","events_url":"https://api.github.com/users/zubair-arbi/events{/privacy}","received_events_url":"https://api.github.com/users/zubair-arbi/received_events","type":"User","site_admin":false},"body":"please make sure there are two new line before and after file variables section","created_at":"2017-07-20T10:27:30Z","updated_at":"2017-07-20T10:31:21Z","html_url":"https://github.com/saadyousafarbi/week1/pull/1#discussion_r128479029","pull_request_url":"https://api.github.com/repos/saadyousafarbi/week1/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/saadyousafarbi/week1/pulls/comments/128479029"},"html":{"href":"https://github.com/saadyousafarbi/week1/pull/1#discussion_r128479029"},"pull_request":{"href":"https://api.github.com/repos/saadyousafarbi/week1/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/saadyousafarbi/week1/pulls/1","id":131510087,"html_url":"https://github.com/saadyousafarbi/week1/pull/1","diff_url":"https://github.com/saadyousafarbi/week1/pull/1.diff","patch_url":"https://github.com/saadyousafarbi/week1/pull/1.patch","issue_url":"https://api.github.com/repos/saadyousafarbi/week1/issues/1","number":1,"state":"open","locked":false,"title":"following good coding practises, modifying weather_finder.py script","user":{"login":"saadyousafarbi","id":30112155,"avatar_url":"https://avatars3.githubusercontent.com/u/30112155?v=4","gravatar_id":"","url":"https://api.github.com/users/saadyousafarbi","html_url":"https://github.com/saadyousafarbi","followers_url":"https://api.github.com/users/saadyousafarbi/followers","following_url":"https://api.github.com/users/saadyousafarbi/following{/other_user}","gists_url":"https://api.github.com/users/saadyousafarbi/gists{/gist_id}","starred_url":"https://api.github.com/users/saadyousafarbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saadyousafarbi/subscriptions","organizations_url":"https://api.github.com/users/saadyousafarbi/orgs","repos_url":"https://api.github.com/users/saadyousafarbi/repos","events_url":"https://api.github.com/users/saadyousafarbi/events{/privacy}","received_events_url":"https://api.github.com/users/saadyousafarbi/received_events","type":"User","site_admin":false},"body":"@zubair-arbi\r\nModified code as instructed by mentor to follow good coding practice.\r\n\r\n","created_at":"2017-07-20T09:37:56Z","updated_at":"2017-07-20T10:31:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fd8d7a6f6b2a33863afeedcaef077a441ef2d7c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/saadyousafarbi/week1/pulls/1/commits","review_comments_url":"https://api.github.com/repos/saadyousafarbi/week1/pulls/1/comments","review_comment_url":"https://api.github.com/repos/saadyousafarbi/week1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saadyousafarbi/week1/issues/1/comments","statuses_url":"https://api.github.com/repos/saadyousafarbi/week1/statuses/451c187726d3d39302f1bbab3ae07b743a4120b6","head":{"label":"saadyousafarbi:sy/fix-code-quality","ref":"sy/fix-code-quality","sha":"451c187726d3d39302f1bbab3ae07b743a4120b6","user":{"login":"saadyousafarbi","id":30112155,"avatar_url":"https://avatars3.githubusercontent.com/u/30112155?v=4","gravatar_id":"","url":"https://api.github.com/users/saadyousafarbi","html_url":"https://github.com/saadyousafarbi","followers_url":"https://api.github.com/users/saadyousafarbi/followers","following_url":"https://api.github.com/users/saadyousafarbi/following{/other_user}","gists_url":"https://api.github.com/users/saadyousafarbi/gists{/gist_id}","starred_url":"https://api.github.com/users/saadyousafarbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saadyousafarbi/subscriptions","organizations_url":"https://api.github.com/users/saadyousafarbi/orgs","repos_url":"https://api.github.com/users/saadyousafarbi/repos","events_url":"https://api.github.com/users/saadyousafarbi/events{/privacy}","received_events_url":"https://api.github.com/users/saadyousafarbi/received_events","type":"User","site_admin":false},"repo":{"id":97456571,"name":"week1","full_name":"saadyousafarbi/week1","owner":{"login":"saadyousafarbi","id":30112155,"avatar_url":"https://avatars3.githubusercontent.com/u/30112155?v=4","gravatar_id":"","url":"https://api.github.com/users/saadyousafarbi","html_url":"https://github.com/saadyousafarbi","followers_url":"https://api.github.com/users/saadyousafarbi/followers","following_url":"https://api.github.com/users/saadyousafarbi/following{/other_user}","gists_url":"https://api.github.com/users/saadyousafarbi/gists{/gist_id}","starred_url":"https://api.github.com/users/saadyousafarbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saadyousafarbi/subscriptions","organizations_url":"https://api.github.com/users/saadyousafarbi/orgs","repos_url":"https://api.github.com/users/saadyousafarbi/repos","events_url":"https://api.github.com/users/saadyousafarbi/events{/privacy}","received_events_url":"https://api.github.com/users/saadyousafarbi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saadyousafarbi/week1","description":null,"fork":false,"url":"https://api.github.com/repos/saadyousafarbi/week1","forks_url":"https://api.github.com/repos/saadyousafarbi/week1/forks","keys_url":"https://api.github.com/repos/saadyousafarbi/week1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saadyousafarbi/week1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saadyousafarbi/week1/teams","hooks_url":"https://api.github.com/repos/saadyousafarbi/week1/hooks","issue_events_url":"https://api.github.com/repos/saadyousafarbi/week1/issues/events{/number}","events_url":"https://api.github.com/repos/saadyousafarbi/week1/events","assignees_url":"https://api.github.com/repos/saadyousafarbi/week1/assignees{/user}","branches_url":"https://api.github.com/repos/saadyousafarbi/week1/branches{/branch}","tags_url":"https://api.github.com/repos/saadyousafarbi/week1/tags","blobs_url":"https://api.github.com/repos/saadyousafarbi/week1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saadyousafarbi/week1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saadyousafarbi/week1/git/refs{/sha}","trees_url":"https://api.github.com/repos/saadyousafarbi/week1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saadyousafarbi/week1/statuses/{sha}","languages_url":"https://api.github.com/repos/saadyousafarbi/week1/languages","stargazers_url":"https://api.github.com/repos/saadyousafarbi/week1/stargazers","contributors_url":"https://api.github.com/repos/saadyousafarbi/week1/contributors","subscribers_url":"https://api.github.com/repos/saadyousafarbi/week1/subscribers","subscription_url":"https://api.github.com/repos/saadyousafarbi/week1/subscription","commits_url":"https://api.github.com/repos/saadyousafarbi/week1/commits{/sha}","git_commits_url":"https://api.github.com/repos/saadyousafarbi/week1/git/commits{/sha}","comments_url":"https://api.github.com/repos/saadyousafarbi/week1/comments{/number}","issue_comment_url":"https://api.github.com/repos/saadyousafarbi/week1/issues/comments{/number}","contents_url":"https://api.github.com/repos/saadyousafarbi/week1/contents/{+path}","compare_url":"https://api.github.com/repos/saadyousafarbi/week1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saadyousafarbi/week1/merges","archive_url":"https://api.github.com/repos/saadyousafarbi/week1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saadyousafarbi/week1/downloads","issues_url":"https://api.github.com/repos/saadyousafarbi/week1/issues{/number}","pulls_url":"https://api.github.com/repos/saadyousafarbi/week1/pulls{/number}","milestones_url":"https://api.github.com/repos/saadyousafarbi/week1/milestones{/number}","notifications_url":"https://api.github.com/repos/saadyousafarbi/week1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saadyousafarbi/week1/labels{/name}","releases_url":"https://api.github.com/repos/saadyousafarbi/week1/releases{/id}","deployments_url":"https://api.github.com/repos/saadyousafarbi/week1/deployments","created_at":"2017-07-17T09:03:48Z","updated_at":"2017-07-17T09:06:13Z","pushed_at":"2017-07-20T10:14:15Z","git_url":"git://github.com/saadyousafarbi/week1.git","ssh_url":"[email protected]:saadyousafarbi/week1.git","clone_url":"https://github.com/saadyousafarbi/week1.git","svn_url":"https://github.com/saadyousafarbi/week1","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"saadyousafarbi:master","ref":"master","sha":"ad72da9c5c5bb4b518774087f0609aaeea165969","user":{"login":"saadyousafarbi","id":30112155,"avatar_url":"https://avatars3.githubusercontent.com/u/30112155?v=4","gravatar_id":"","url":"https://api.github.com/users/saadyousafarbi","html_url":"https://github.com/saadyousafarbi","followers_url":"https://api.github.com/users/saadyousafarbi/followers","following_url":"https://api.github.com/users/saadyousafarbi/following{/other_user}","gists_url":"https://api.github.com/users/saadyousafarbi/gists{/gist_id}","starred_url":"https://api.github.com/users/saadyousafarbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saadyousafarbi/subscriptions","organizations_url":"https://api.github.com/users/saadyousafarbi/orgs","repos_url":"https://api.github.com/users/saadyousafarbi/repos","events_url":"https://api.github.com/users/saadyousafarbi/events{/privacy}","received_events_url":"https://api.github.com/users/saadyousafarbi/received_events","type":"User","site_admin":false},"repo":{"id":97456571,"name":"week1","full_name":"saadyousafarbi/week1","owner":{"login":"saadyousafarbi","id":30112155,"avatar_url":"https://avatars3.githubusercontent.com/u/30112155?v=4","gravatar_id":"","url":"https://api.github.com/users/saadyousafarbi","html_url":"https://github.com/saadyousafarbi","followers_url":"https://api.github.com/users/saadyousafarbi/followers","following_url":"https://api.github.com/users/saadyousafarbi/following{/other_user}","gists_url":"https://api.github.com/users/saadyousafarbi/gists{/gist_id}","starred_url":"https://api.github.com/users/saadyousafarbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saadyousafarbi/subscriptions","organizations_url":"https://api.github.com/users/saadyousafarbi/orgs","repos_url":"https://api.github.com/users/saadyousafarbi/repos","events_url":"https://api.github.com/users/saadyousafarbi/events{/privacy}","received_events_url":"https://api.github.com/users/saadyousafarbi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saadyousafarbi/week1","description":null,"fork":false,"url":"https://api.github.com/repos/saadyousafarbi/week1","forks_url":"https://api.github.com/repos/saadyousafarbi/week1/forks","keys_url":"https://api.github.com/repos/saadyousafarbi/week1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saadyousafarbi/week1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saadyousafarbi/week1/teams","hooks_url":"https://api.github.com/repos/saadyousafarbi/week1/hooks","issue_events_url":"https://api.github.com/repos/saadyousafarbi/week1/issues/events{/number}","events_url":"https://api.github.com/repos/saadyousafarbi/week1/events","assignees_url":"https://api.github.com/repos/saadyousafarbi/week1/assignees{/user}","branches_url":"https://api.github.com/repos/saadyousafarbi/week1/branches{/branch}","tags_url":"https://api.github.com/repos/saadyousafarbi/week1/tags","blobs_url":"https://api.github.com/repos/saadyousafarbi/week1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saadyousafarbi/week1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saadyousafarbi/week1/git/refs{/sha}","trees_url":"https://api.github.com/repos/saadyousafarbi/week1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saadyousafarbi/week1/statuses/{sha}","languages_url":"https://api.github.com/repos/saadyousafarbi/week1/languages","stargazers_url":"https://api.github.com/repos/saadyousafarbi/week1/stargazers","contributors_url":"https://api.github.com/repos/saadyousafarbi/week1/contributors","subscribers_url":"https://api.github.com/repos/saadyousafarbi/week1/subscribers","subscription_url":"https://api.github.com/repos/saadyousafarbi/week1/subscription","commits_url":"https://api.github.com/repos/saadyousafarbi/week1/commits{/sha}","git_commits_url":"https://api.github.com/repos/saadyousafarbi/week1/git/commits{/sha}","comments_url":"https://api.github.com/repos/saadyousafarbi/week1/comments{/number}","issue_comment_url":"https://api.github.com/repos/saadyousafarbi/week1/issues/comments{/number}","contents_url":"https://api.github.com/repos/saadyousafarbi/week1/contents/{+path}","compare_url":"https://api.github.com/repos/saadyousafarbi/week1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saadyousafarbi/week1/merges","archive_url":"https://api.github.com/repos/saadyousafarbi/week1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saadyousafarbi/week1/downloads","issues_url":"https://api.github.com/repos/saadyousafarbi/week1/issues{/number}","pulls_url":"https://api.github.com/repos/saadyousafarbi/week1/pulls{/number}","milestones_url":"https://api.github.com/repos/saadyousafarbi/week1/milestones{/number}","notifications_url":"https://api.github.com/repos/saadyousafarbi/week1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saadyousafarbi/week1/labels{/name}","releases_url":"https://api.github.com/repos/saadyousafarbi/week1/releases{/id}","deployments_url":"https://api.github.com/repos/saadyousafarbi/week1/deployments","created_at":"2017-07-17T09:03:48Z","updated_at":"2017-07-17T09:06:13Z","pushed_at":"2017-07-20T10:14:15Z","git_url":"git://github.com/saadyousafarbi/week1.git","ssh_url":"[email protected]:saadyousafarbi/week1.git","clone_url":"https://github.com/saadyousafarbi/week1.git","svn_url":"https://github.com/saadyousafarbi/week1","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/saadyousafarbi/week1/pulls/1"},"html":{"href":"https://github.com/saadyousafarbi/week1/pull/1"},"issue":{"href":"https://api.github.com/repos/saadyousafarbi/week1/issues/1"},"comments":{"href":"https://api.github.com/repos/saadyousafarbi/week1/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/saadyousafarbi/week1/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/saadyousafarbi/week1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saadyousafarbi/week1/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/saadyousafarbi/week1/statuses/451c187726d3d39302f1bbab3ae07b743a4120b6"}}}} | {
"id": 97456571,
"name": "saadyousafarbi/week1",
"url": "https://api.github.com/repos/saadyousafarbi/week1"
} | {
"id": 5072991,
"login": "zubair-arbi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5072991?",
"url": "https://api.github.com/users/zubair-arbi"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-07-20T10:27:30 | 6294093927 | {"actor":{"display_login":"zubair-arbi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hironoriohashi/JavaQuest/pulls/comments/118898776","pull_request_review_id":40733245,"id":118898776,"diff_hunk":"@@ -0,0 +1,52 @@\n+\n+/**\n+ * (JUnit実践入門より)\n+ * 処理をバックグラウンドのスレッドで非同期に実行したい。\n+ * バックグラウンドスレッドで処理するBackgroundTaskクラスを作成し、\n+ * タスクがバックグラウンドのスレッドで実行されることを検証するテストを作成せよ。\n+ * なお、タスクはRunnableオブジェクトに実装する。\n+ *\n+ * ヒント\n+ *\n+ * 設計\n+ * BackgroundTaskは、コンストラクタでRunnableオブジェクトを引数に持つ\n+ * BackgroundTaskクラスに、invokeメソッドを定義する\n+ * invokeメソッドは、引数を持たず、戻り値をvoid型とする\n+ * invokeメソッドでは、バックグラウンドスレッドでタスクを実行し、すぐに制御を呼び出し元に返す\n+ *\n+ * テストケース\n+ * invokeメソッドによりRunnableオブジェクトのrunメソッドが別スレッドで実行される\n+*/\n+\n+import static org.hamcrest.CoreMatchers.*;\n+import static org.junit.Assert.*;\n+\n+import java.util.concurrent.Callable;\n+import java.util.concurrent.ExecutionException;\n+import java.util.concurrent.ExecutorService;\n+import java.util.concurrent.Executors;\n+import java.util.concurrent.Future;\n+\n+import org.junit.Test;\n+\n+public class BackgroundTaskTest {\n+\n+ @Test\n+ public void Runnableオブジェクトを渡すとバックグラウンドでrunが実行されること() throws InterruptedException, ExecutionException {\n+\n+ Callable<Integer> rn = () -> {//スレッドに行わせる処理\n+ Integer a = 0;\n+ a++;\n+ return a;\n+ };\n+\n+ ExecutorService executor = Executors.newSingleThreadExecutor();\n+ Future<Integer> retian = executor.submit(rn);\n+ BackgroundTask backgroundTask = new BackgroundTask((Runnable) retian);\n+ backgroundTask.invoke();\n+\n+ //スレッドでaのインクリメントが行われたかを確認する\n+ assertThat(retian.get(), is(1));","path":"Issues6/BackgroundTaskTest.java","position":49,"original_position":49,"commit_id":"7a8eab55550f25807ee0ed4a6a7b1fd71ee4d59f","original_commit_id":"7a8eab55550f25807ee0ed4a6a7b1fd71ee4d59f","user":{"login":"hironoriohashi","id":27398594,"avatar_url":"https://avatars1.githubusercontent.com/u/27398594?v=3","gravatar_id":"","url":"https://api.github.com/users/hironoriohashi","html_url":"https://github.com/hironoriohashi","followers_url":"https://api.github.com/users/hironoriohashi/followers","following_url":"https://api.github.com/users/hironoriohashi/following{/other_user}","gists_url":"https://api.github.com/users/hironoriohashi/gists{/gist_id}","starred_url":"https://api.github.com/users/hironoriohashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hironoriohashi/subscriptions","organizations_url":"https://api.github.com/users/hironoriohashi/orgs","repos_url":"https://api.github.com/users/hironoriohashi/repos","events_url":"https://api.github.com/users/hironoriohashi/events{/privacy}","received_events_url":"https://api.github.com/users/hironoriohashi/received_events","type":"User","site_admin":false},"body":"> これ本当に`BackgroundTask`によってバックグラウンドで実行されたんでしょうか?\r\n`ExecutorService`かも知れませんよ?\r\n\r\n`ExecutorService`で動いていました。\r\n`ExecutorService`は受け取った`Runnable`実装クラスを実行するインターフェースだと認識しましたが、合っていますか。また、`Callable`は実装したら`Executor`に渡し、実行した結果を`Future`に結果を保持させるといった認識で合っていますか。","created_at":"2017-05-29T09:21:57Z","updated_at":"2017-05-29T09:21:57Z","html_url":"https://github.com/hironoriohashi/JavaQuest/pull/30#discussion_r118898776","pull_request_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/hironoriohashi/JavaQuest/pulls/comments/118898776"},"html":{"href":"https://github.com/hironoriohashi/JavaQuest/pull/30#discussion_r118898776"},"pull_request":{"href":"https://api.github.com/repos/hironoriohashi/JavaQuest/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/hironoriohashi/JavaQuest/pulls/30","id":122600149,"html_url":"https://github.com/hironoriohashi/JavaQuest/pull/30","diff_url":"https://github.com/hironoriohashi/JavaQuest/pull/30.diff","patch_url":"https://github.com/hironoriohashi/JavaQuest/pull/30.patch","issue_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/issues/30","number":30,"state":"open","locked":false,"title":"Issues6の課題","user":{"login":"hironoriohashi","id":27398594,"avatar_url":"https://avatars1.githubusercontent.com/u/27398594?v=3","gravatar_id":"","url":"https://api.github.com/users/hironoriohashi","html_url":"https://github.com/hironoriohashi","followers_url":"https://api.github.com/users/hironoriohashi/followers","following_url":"https://api.github.com/users/hironoriohashi/following{/other_user}","gists_url":"https://api.github.com/users/hironoriohashi/gists{/gist_id}","starred_url":"https://api.github.com/users/hironoriohashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hironoriohashi/subscriptions","organizations_url":"https://api.github.com/users/hironoriohashi/orgs","repos_url":"https://api.github.com/users/hironoriohashi/repos","events_url":"https://api.github.com/users/hironoriohashi/events{/privacy}","received_events_url":"https://api.github.com/users/hironoriohashi/received_events","type":"User","site_admin":false},"body":"Issues6の課題、BackgroundTask.javaとBackgroundTaskTest.javaを作成しました。\r\nレビューお願いします。\r\nclose #21","created_at":"2017-05-26T09:00:11Z","updated_at":"2017-05-29T09:21:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"598c23ba0bd797f9426393c115180f3ace81b5fa","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/pulls/30/commits","review_comments_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/pulls/30/comments","review_comment_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/issues/30/comments","statuses_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/statuses/7a8eab55550f25807ee0ed4a6a7b1fd71ee4d59f","head":{"label":"hironoriohashi:Issues6","ref":"Issues6","sha":"7a8eab55550f25807ee0ed4a6a7b1fd71ee4d59f","user":{"login":"hironoriohashi","id":27398594,"avatar_url":"https://avatars1.githubusercontent.com/u/27398594?v=3","gravatar_id":"","url":"https://api.github.com/users/hironoriohashi","html_url":"https://github.com/hironoriohashi","followers_url":"https://api.github.com/users/hironoriohashi/followers","following_url":"https://api.github.com/users/hironoriohashi/following{/other_user}","gists_url":"https://api.github.com/users/hironoriohashi/gists{/gist_id}","starred_url":"https://api.github.com/users/hironoriohashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hironoriohashi/subscriptions","organizations_url":"https://api.github.com/users/hironoriohashi/orgs","repos_url":"https://api.github.com/users/hironoriohashi/repos","events_url":"https://api.github.com/users/hironoriohashi/events{/privacy}","received_events_url":"https://api.github.com/users/hironoriohashi/received_events","type":"User","site_admin":false},"repo":{"id":88687381,"name":"JavaQuest","full_name":"hironoriohashi/JavaQuest","owner":{"login":"hironoriohashi","id":27398594,"avatar_url":"https://avatars1.githubusercontent.com/u/27398594?v=3","gravatar_id":"","url":"https://api.github.com/users/hironoriohashi","html_url":"https://github.com/hironoriohashi","followers_url":"https://api.github.com/users/hironoriohashi/followers","following_url":"https://api.github.com/users/hironoriohashi/following{/other_user}","gists_url":"https://api.github.com/users/hironoriohashi/gists{/gist_id}","starred_url":"https://api.github.com/users/hironoriohashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hironoriohashi/subscriptions","organizations_url":"https://api.github.com/users/hironoriohashi/orgs","repos_url":"https://api.github.com/users/hironoriohashi/repos","events_url":"https://api.github.com/users/hironoriohashi/events{/privacy}","received_events_url":"https://api.github.com/users/hironoriohashi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hironoriohashi/JavaQuest","description":"ProgrammingLesson","fork":false,"url":"https://api.github.com/repos/hironoriohashi/JavaQuest","forks_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/forks","keys_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/teams","hooks_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/hooks","issue_events_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/issues/events{/number}","events_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/events","assignees_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/assignees{/user}","branches_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/branches{/branch}","tags_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/tags","blobs_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/git/refs{/sha}","trees_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/statuses/{sha}","languages_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/languages","stargazers_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/stargazers","contributors_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/contributors","subscribers_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/subscribers","subscription_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/subscription","commits_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/commits{/sha}","git_commits_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/git/commits{/sha}","comments_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/comments{/number}","issue_comment_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/issues/comments{/number}","contents_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/contents/{+path}","compare_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/merges","archive_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/downloads","issues_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/issues{/number}","pulls_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/pulls{/number}","milestones_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/milestones{/number}","notifications_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/labels{/name}","releases_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/releases{/id}","deployments_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/deployments","created_at":"2017-04-19T01:39:41Z","updated_at":"2017-04-21T01:49:40Z","pushed_at":"2017-05-26T09:00:11Z","git_url":"git://github.com/hironoriohashi/JavaQuest.git","ssh_url":"[email protected]:hironoriohashi/JavaQuest.git","clone_url":"https://github.com/hironoriohashi/JavaQuest.git","svn_url":"https://github.com/hironoriohashi/JavaQuest","homepage":null,"size":130,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"hironoriohashi:master","ref":"master","sha":"372958800ed63d60d9bfa4a361c05a4e315f8c5e","user":{"login":"hironoriohashi","id":27398594,"avatar_url":"https://avatars1.githubusercontent.com/u/27398594?v=3","gravatar_id":"","url":"https://api.github.com/users/hironoriohashi","html_url":"https://github.com/hironoriohashi","followers_url":"https://api.github.com/users/hironoriohashi/followers","following_url":"https://api.github.com/users/hironoriohashi/following{/other_user}","gists_url":"https://api.github.com/users/hironoriohashi/gists{/gist_id}","starred_url":"https://api.github.com/users/hironoriohashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hironoriohashi/subscriptions","organizations_url":"https://api.github.com/users/hironoriohashi/orgs","repos_url":"https://api.github.com/users/hironoriohashi/repos","events_url":"https://api.github.com/users/hironoriohashi/events{/privacy}","received_events_url":"https://api.github.com/users/hironoriohashi/received_events","type":"User","site_admin":false},"repo":{"id":88687381,"name":"JavaQuest","full_name":"hironoriohashi/JavaQuest","owner":{"login":"hironoriohashi","id":27398594,"avatar_url":"https://avatars1.githubusercontent.com/u/27398594?v=3","gravatar_id":"","url":"https://api.github.com/users/hironoriohashi","html_url":"https://github.com/hironoriohashi","followers_url":"https://api.github.com/users/hironoriohashi/followers","following_url":"https://api.github.com/users/hironoriohashi/following{/other_user}","gists_url":"https://api.github.com/users/hironoriohashi/gists{/gist_id}","starred_url":"https://api.github.com/users/hironoriohashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hironoriohashi/subscriptions","organizations_url":"https://api.github.com/users/hironoriohashi/orgs","repos_url":"https://api.github.com/users/hironoriohashi/repos","events_url":"https://api.github.com/users/hironoriohashi/events{/privacy}","received_events_url":"https://api.github.com/users/hironoriohashi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hironoriohashi/JavaQuest","description":"ProgrammingLesson","fork":false,"url":"https://api.github.com/repos/hironoriohashi/JavaQuest","forks_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/forks","keys_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/teams","hooks_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/hooks","issue_events_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/issues/events{/number}","events_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/events","assignees_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/assignees{/user}","branches_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/branches{/branch}","tags_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/tags","blobs_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/git/refs{/sha}","trees_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/statuses/{sha}","languages_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/languages","stargazers_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/stargazers","contributors_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/contributors","subscribers_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/subscribers","subscription_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/subscription","commits_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/commits{/sha}","git_commits_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/git/commits{/sha}","comments_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/comments{/number}","issue_comment_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/issues/comments{/number}","contents_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/contents/{+path}","compare_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/merges","archive_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/downloads","issues_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/issues{/number}","pulls_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/pulls{/number}","milestones_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/milestones{/number}","notifications_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/labels{/name}","releases_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/releases{/id}","deployments_url":"https://api.github.com/repos/hironoriohashi/JavaQuest/deployments","created_at":"2017-04-19T01:39:41Z","updated_at":"2017-04-21T01:49:40Z","pushed_at":"2017-05-26T09:00:11Z","git_url":"git://github.com/hironoriohashi/JavaQuest.git","ssh_url":"[email protected]:hironoriohashi/JavaQuest.git","clone_url":"https://github.com/hironoriohashi/JavaQuest.git","svn_url":"https://github.com/hironoriohashi/JavaQuest","homepage":null,"size":130,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hironoriohashi/JavaQuest/pulls/30"},"html":{"href":"https://github.com/hironoriohashi/JavaQuest/pull/30"},"issue":{"href":"https://api.github.com/repos/hironoriohashi/JavaQuest/issues/30"},"comments":{"href":"https://api.github.com/repos/hironoriohashi/JavaQuest/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/hironoriohashi/JavaQuest/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/hironoriohashi/JavaQuest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hironoriohashi/JavaQuest/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/hironoriohashi/JavaQuest/statuses/7a8eab55550f25807ee0ed4a6a7b1fd71ee4d59f"}}}} | {
"id": 88687381,
"name": "hironoriohashi/JavaQuest",
"url": "https://api.github.com/repos/hironoriohashi/JavaQuest"
} | {
"id": 27398594,
"login": "hironoriohashi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/27398594?",
"url": "https://api.github.com/users/hironoriohashi"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-05-29T09:21:57 | 5958897067 | {"actor":{"display_login":"hironoriohashi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/devinivy/haute-couture/pulls/comments/99402307","pull_request_review_id":20082010,"id":99402307,"diff_hunk":"@@ -227,6 +227,12 @@ Here's the complete rundown of how files and directories are mapped to API calls\n - **`models/index.js`** - export an array of `models`.\n - **`models/model-identity.js`** - export `models`. If `models` is a single model definition, the model's `identity` will be assigned `'model-identity'` from the filename if it isn't already specified. The filename could just as easily represent a group of models (rather than an identity) and the file could export an array of model configs.\n \n+### Model definitions (for [schwifty](https://github.com/BigRoomStudios/schwifty))\n+ > [`server.schwifty(config)`](https://github.com/BigRoomStudios/schwifty/blob/master/API.md#serverschwiftyconfig)\n+\n+ - **`models/index.js`** - export an object containing `model` objects.\n+ - **`models/model-identity.js`** - export `model` obejct.","path":"README.md","position":17,"original_position":17,"commit_id":"a04f1d61ba97aac2ebcedbf4097f6a2e5d2b1ea3","original_commit_id":"a04f1d61ba97aac2ebcedbf4097f6a2e5d2b1ea3","user":{"login":"devinivy","id":3150233,"avatar_url":"https://avatars.githubusercontent.com/u/3150233?v=3","gravatar_id":"","url":"https://api.github.com/users/devinivy","html_url":"https://github.com/devinivy","followers_url":"https://api.github.com/users/devinivy/followers","following_url":"https://api.github.com/users/devinivy/following{/other_user}","gists_url":"https://api.github.com/users/devinivy/gists{/gist_id}","starred_url":"https://api.github.com/users/devinivy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devinivy/subscriptions","organizations_url":"https://api.github.com/users/devinivy/orgs","repos_url":"https://api.github.com/users/devinivy/repos","events_url":"https://api.github.com/users/devinivy/events{/privacy}","received_events_url":"https://api.github.com/users/devinivy/received_events","type":"User","site_admin":false},"body":"Almost \"obekt\"","created_at":"2017-02-03T19:09:57Z","updated_at":"2017-02-03T19:09:57Z","html_url":"https://github.com/devinivy/haute-couture/pull/18#discussion_r99402307","pull_request_url":"https://api.github.com/repos/devinivy/haute-couture/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/devinivy/haute-couture/pulls/comments/99402307"},"html":{"href":"https://github.com/devinivy/haute-couture/pull/18#discussion_r99402307"},"pull_request":{"href":"https://api.github.com/repos/devinivy/haute-couture/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/devinivy/haute-couture/pulls/18","id":104558268,"html_url":"https://github.com/devinivy/haute-couture/pull/18","diff_url":"https://github.com/devinivy/haute-couture/pull/18.diff","patch_url":"https://github.com/devinivy/haute-couture/pull/18.patch","issue_url":"https://api.github.com/repos/devinivy/haute-couture/issues/18","number":18,"state":"open","locked":false,"title":"Add schwifty","user":{"login":"mattboutet","id":1681861,"avatar_url":"https://avatars.githubusercontent.com/u/1681861?v=3","gravatar_id":"","url":"https://api.github.com/users/mattboutet","html_url":"https://github.com/mattboutet","followers_url":"https://api.github.com/users/mattboutet/followers","following_url":"https://api.github.com/users/mattboutet/following{/other_user}","gists_url":"https://api.github.com/users/mattboutet/gists{/gist_id}","starred_url":"https://api.github.com/users/mattboutet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattboutet/subscriptions","organizations_url":"https://api.github.com/users/mattboutet/orgs","repos_url":"https://api.github.com/users/mattboutet/repos","events_url":"https://api.github.com/users/mattboutet/events{/privacy}","received_events_url":"https://api.github.com/users/mattboutet/received_events","type":"User","site_admin":false},"body":"This is a first pass at adding support for Schwifty models.","created_at":"2017-02-03T15:48:13Z","updated_at":"2017-02-03T19:09:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01044fe4b41b322712a9938f80daeaab2fa1ec9c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/devinivy/haute-couture/pulls/18/commits","review_comments_url":"https://api.github.com/repos/devinivy/haute-couture/pulls/18/comments","review_comment_url":"https://api.github.com/repos/devinivy/haute-couture/pulls/comments{/number}","comments_url":"https://api.github.com/repos/devinivy/haute-couture/issues/18/comments","statuses_url":"https://api.github.com/repos/devinivy/haute-couture/statuses/a04f1d61ba97aac2ebcedbf4097f6a2e5d2b1ea3","head":{"label":"mattboutet:add-schwifty","ref":"add-schwifty","sha":"a04f1d61ba97aac2ebcedbf4097f6a2e5d2b1ea3","user":{"login":"mattboutet","id":1681861,"avatar_url":"https://avatars.githubusercontent.com/u/1681861?v=3","gravatar_id":"","url":"https://api.github.com/users/mattboutet","html_url":"https://github.com/mattboutet","followers_url":"https://api.github.com/users/mattboutet/followers","following_url":"https://api.github.com/users/mattboutet/following{/other_user}","gists_url":"https://api.github.com/users/mattboutet/gists{/gist_id}","starred_url":"https://api.github.com/users/mattboutet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattboutet/subscriptions","organizations_url":"https://api.github.com/users/mattboutet/orgs","repos_url":"https://api.github.com/users/mattboutet/repos","events_url":"https://api.github.com/users/mattboutet/events{/privacy}","received_events_url":"https://api.github.com/users/mattboutet/received_events","type":"User","site_admin":false},"repo":{"id":80839079,"name":"haute-couture","full_name":"mattboutet/haute-couture","owner":{"login":"mattboutet","id":1681861,"avatar_url":"https://avatars.githubusercontent.com/u/1681861?v=3","gravatar_id":"","url":"https://api.github.com/users/mattboutet","html_url":"https://github.com/mattboutet","followers_url":"https://api.github.com/users/mattboutet/followers","following_url":"https://api.github.com/users/mattboutet/following{/other_user}","gists_url":"https://api.github.com/users/mattboutet/gists{/gist_id}","starred_url":"https://api.github.com/users/mattboutet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattboutet/subscriptions","organizations_url":"https://api.github.com/users/mattboutet/orgs","repos_url":"https://api.github.com/users/mattboutet/repos","events_url":"https://api.github.com/users/mattboutet/events{/privacy}","received_events_url":"https://api.github.com/users/mattboutet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattboutet/haute-couture","description":"File-based hapi plugin composer","fork":true,"url":"https://api.github.com/repos/mattboutet/haute-couture","forks_url":"https://api.github.com/repos/mattboutet/haute-couture/forks","keys_url":"https://api.github.com/repos/mattboutet/haute-couture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattboutet/haute-couture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattboutet/haute-couture/teams","hooks_url":"https://api.github.com/repos/mattboutet/haute-couture/hooks","issue_events_url":"https://api.github.com/repos/mattboutet/haute-couture/issues/events{/number}","events_url":"https://api.github.com/repos/mattboutet/haute-couture/events","assignees_url":"https://api.github.com/repos/mattboutet/haute-couture/assignees{/user}","branches_url":"https://api.github.com/repos/mattboutet/haute-couture/branches{/branch}","tags_url":"https://api.github.com/repos/mattboutet/haute-couture/tags","blobs_url":"https://api.github.com/repos/mattboutet/haute-couture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattboutet/haute-couture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattboutet/haute-couture/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattboutet/haute-couture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattboutet/haute-couture/statuses/{sha}","languages_url":"https://api.github.com/repos/mattboutet/haute-couture/languages","stargazers_url":"https://api.github.com/repos/mattboutet/haute-couture/stargazers","contributors_url":"https://api.github.com/repos/mattboutet/haute-couture/contributors","subscribers_url":"https://api.github.com/repos/mattboutet/haute-couture/subscribers","subscription_url":"https://api.github.com/repos/mattboutet/haute-couture/subscription","commits_url":"https://api.github.com/repos/mattboutet/haute-couture/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattboutet/haute-couture/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattboutet/haute-couture/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattboutet/haute-couture/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattboutet/haute-couture/contents/{+path}","compare_url":"https://api.github.com/repos/mattboutet/haute-couture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattboutet/haute-couture/merges","archive_url":"https://api.github.com/repos/mattboutet/haute-couture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattboutet/haute-couture/downloads","issues_url":"https://api.github.com/repos/mattboutet/haute-couture/issues{/number}","pulls_url":"https://api.github.com/repos/mattboutet/haute-couture/pulls{/number}","milestones_url":"https://api.github.com/repos/mattboutet/haute-couture/milestones{/number}","notifications_url":"https://api.github.com/repos/mattboutet/haute-couture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattboutet/haute-couture/labels{/name}","releases_url":"https://api.github.com/repos/mattboutet/haute-couture/releases{/id}","deployments_url":"https://api.github.com/repos/mattboutet/haute-couture/deployments","created_at":"2017-02-03T15:01:05Z","updated_at":"2017-02-03T15:01:07Z","pushed_at":"2017-02-03T15:47:17Z","git_url":"git://github.com/mattboutet/haute-couture.git","ssh_url":"[email protected]:mattboutet/haute-couture.git","clone_url":"https://github.com/mattboutet/haute-couture.git","svn_url":"https://github.com/mattboutet/haute-couture","homepage":"","size":49,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"devinivy:master","ref":"master","sha":"a705ac51229f8959a1506434140a100001fe157c","user":{"login":"devinivy","id":3150233,"avatar_url":"https://avatars.githubusercontent.com/u/3150233?v=3","gravatar_id":"","url":"https://api.github.com/users/devinivy","html_url":"https://github.com/devinivy","followers_url":"https://api.github.com/users/devinivy/followers","following_url":"https://api.github.com/users/devinivy/following{/other_user}","gists_url":"https://api.github.com/users/devinivy/gists{/gist_id}","starred_url":"https://api.github.com/users/devinivy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devinivy/subscriptions","organizations_url":"https://api.github.com/users/devinivy/orgs","repos_url":"https://api.github.com/users/devinivy/repos","events_url":"https://api.github.com/users/devinivy/events{/privacy}","received_events_url":"https://api.github.com/users/devinivy/received_events","type":"User","site_admin":false},"repo":{"id":59060143,"name":"haute-couture","full_name":"devinivy/haute-couture","owner":{"login":"devinivy","id":3150233,"avatar_url":"https://avatars.githubusercontent.com/u/3150233?v=3","gravatar_id":"","url":"https://api.github.com/users/devinivy","html_url":"https://github.com/devinivy","followers_url":"https://api.github.com/users/devinivy/followers","following_url":"https://api.github.com/users/devinivy/following{/other_user}","gists_url":"https://api.github.com/users/devinivy/gists{/gist_id}","starred_url":"https://api.github.com/users/devinivy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devinivy/subscriptions","organizations_url":"https://api.github.com/users/devinivy/orgs","repos_url":"https://api.github.com/users/devinivy/repos","events_url":"https://api.github.com/users/devinivy/events{/privacy}","received_events_url":"https://api.github.com/users/devinivy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/devinivy/haute-couture","description":"File-based hapi plugin composer","fork":false,"url":"https://api.github.com/repos/devinivy/haute-couture","forks_url":"https://api.github.com/repos/devinivy/haute-couture/forks","keys_url":"https://api.github.com/repos/devinivy/haute-couture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devinivy/haute-couture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devinivy/haute-couture/teams","hooks_url":"https://api.github.com/repos/devinivy/haute-couture/hooks","issue_events_url":"https://api.github.com/repos/devinivy/haute-couture/issues/events{/number}","events_url":"https://api.github.com/repos/devinivy/haute-couture/events","assignees_url":"https://api.github.com/repos/devinivy/haute-couture/assignees{/user}","branches_url":"https://api.github.com/repos/devinivy/haute-couture/branches{/branch}","tags_url":"https://api.github.com/repos/devinivy/haute-couture/tags","blobs_url":"https://api.github.com/repos/devinivy/haute-couture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devinivy/haute-couture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devinivy/haute-couture/git/refs{/sha}","trees_url":"https://api.github.com/repos/devinivy/haute-couture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devinivy/haute-couture/statuses/{sha}","languages_url":"https://api.github.com/repos/devinivy/haute-couture/languages","stargazers_url":"https://api.github.com/repos/devinivy/haute-couture/stargazers","contributors_url":"https://api.github.com/repos/devinivy/haute-couture/contributors","subscribers_url":"https://api.github.com/repos/devinivy/haute-couture/subscribers","subscription_url":"https://api.github.com/repos/devinivy/haute-couture/subscription","commits_url":"https://api.github.com/repos/devinivy/haute-couture/commits{/sha}","git_commits_url":"https://api.github.com/repos/devinivy/haute-couture/git/commits{/sha}","comments_url":"https://api.github.com/repos/devinivy/haute-couture/comments{/number}","issue_comment_url":"https://api.github.com/repos/devinivy/haute-couture/issues/comments{/number}","contents_url":"https://api.github.com/repos/devinivy/haute-couture/contents/{+path}","compare_url":"https://api.github.com/repos/devinivy/haute-couture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devinivy/haute-couture/merges","archive_url":"https://api.github.com/repos/devinivy/haute-couture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devinivy/haute-couture/downloads","issues_url":"https://api.github.com/repos/devinivy/haute-couture/issues{/number}","pulls_url":"https://api.github.com/repos/devinivy/haute-couture/pulls{/number}","milestones_url":"https://api.github.com/repos/devinivy/haute-couture/milestones{/number}","notifications_url":"https://api.github.com/repos/devinivy/haute-couture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devinivy/haute-couture/labels{/name}","releases_url":"https://api.github.com/repos/devinivy/haute-couture/releases{/id}","deployments_url":"https://api.github.com/repos/devinivy/haute-couture/deployments","created_at":"2016-05-17T21:23:54Z","updated_at":"2016-11-14T08:31:37Z","pushed_at":"2017-02-03T15:48:14Z","git_url":"git://github.com/devinivy/haute-couture.git","ssh_url":"[email protected]:devinivy/haute-couture.git","clone_url":"https://github.com/devinivy/haute-couture.git","svn_url":"https://github.com/devinivy/haute-couture","homepage":"","size":50,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/devinivy/haute-couture/pulls/18"},"html":{"href":"https://github.com/devinivy/haute-couture/pull/18"},"issue":{"href":"https://api.github.com/repos/devinivy/haute-couture/issues/18"},"comments":{"href":"https://api.github.com/repos/devinivy/haute-couture/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/devinivy/haute-couture/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/devinivy/haute-couture/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/devinivy/haute-couture/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/devinivy/haute-couture/statuses/a04f1d61ba97aac2ebcedbf4097f6a2e5d2b1ea3"}}}} | {
"id": 59060143,
"name": "devinivy/haute-couture",
"url": "https://api.github.com/repos/devinivy/haute-couture"
} | {
"id": 3150233,
"login": "devinivy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3150233?",
"url": "https://api.github.com/users/devinivy"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-02-03T19:09:57 | 5263681103 | {"actor":{"display_login":"devinivy"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/pulls/comments/154277843","pull_request_review_id":80416469,"id":154277843,"diff_hunk":"@@ -0,0 +1,98 @@\n+<?php\n+\n+namespace App\\Http\\Controllers;\n+\n+use Illuminate\\Http\\Request;\n+use Validator, Input, Redirect;\n+use App\\Task;\n+use App\\Http\\Requests\\TaskRequest;\n+\n+class TaskController extends Controller\n+{\n+ /**\n+ * Display a listing of the resource.\n+ *\n+ * @return \\Illuminate\\Http\\Response\n+ */\n+ public function index()\n+ {\n+ return view('tasks', [\n+ 'tasks' => Task::orderBy('created_at', 'asc')->get()\n+ ]);\n+ }\n+\n+ /**\n+ * Show the form for creating a new resource.\n+ *\n+ * @return \\Illuminate\\Http\\Response\n+ */\n+ public function create()\n+ {\n+ //\n+ }\n+\n+ /**\n+ * Store a newly created resource in storage.\n+ *\n+ * @param \\Illuminate\\Http\\Request $request\n+ * @return \\Illuminate\\Http\\Response\n+ */\n+ public function store(TaskRequest $request)\n+ {\n+ $task = new Task;\n+ $task->name = $request->name;\n+ $task->save();\n+\n+ return redirect()->back()->with('task_insert',$task['name']);","path":"app/Http/Controllers/TaskController.php","position":46,"original_position":46,"commit_id":"ece5da8082bde3f003ba59357c8a005fa86f1d47","original_commit_id":"ece5da8082bde3f003ba59357c8a005fa86f1d47","user":{"login":"trangkarol","id":19767833,"avatar_url":"https://avatars1.githubusercontent.com/u/19767833?v=4","gravatar_id":"","url":"https://api.github.com/users/trangkarol","html_url":"https://github.com/trangkarol","followers_url":"https://api.github.com/users/trangkarol/followers","following_url":"https://api.github.com/users/trangkarol/following{/other_user}","gists_url":"https://api.github.com/users/trangkarol/gists{/gist_id}","starred_url":"https://api.github.com/users/trangkarol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trangkarol/subscriptions","organizations_url":"https://api.github.com/users/trangkarol/orgs","repos_url":"https://api.github.com/users/trangkarol/repos","events_url":"https://api.github.com/users/trangkarol/events{/privacy}","received_events_url":"https://api.github.com/users/trangkarol/received_events","type":"User","site_admin":false},"body":"Convention: Sau dấu `,` là 1 space","created_at":"2017-12-01T06:49:41Z","updated_at":"2017-12-01T06:58:40Z","html_url":"https://github.com/kingtruong79/laravel_quickstart/pull/4#discussion_r154277843","pull_request_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/pulls/4","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kingtruong79/laravel_quickstart/pulls/comments/154277843"},"html":{"href":"https://github.com/kingtruong79/laravel_quickstart/pull/4#discussion_r154277843"},"pull_request":{"href":"https://api.github.com/repos/kingtruong79/laravel_quickstart/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/pulls/4","id":155782587,"html_url":"https://github.com/kingtruong79/laravel_quickstart/pull/4","diff_url":"https://github.com/kingtruong79/laravel_quickstart/pull/4.diff","patch_url":"https://github.com/kingtruong79/laravel_quickstart/pull/4.patch","issue_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/issues/4","number":4,"state":"open","locked":false,"title":"finish task","user":{"login":"kingtruong79","id":30968020,"avatar_url":"https://avatars2.githubusercontent.com/u/30968020?v=4","gravatar_id":"","url":"https://api.github.com/users/kingtruong79","html_url":"https://github.com/kingtruong79","followers_url":"https://api.github.com/users/kingtruong79/followers","following_url":"https://api.github.com/users/kingtruong79/following{/other_user}","gists_url":"https://api.github.com/users/kingtruong79/gists{/gist_id}","starred_url":"https://api.github.com/users/kingtruong79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingtruong79/subscriptions","organizations_url":"https://api.github.com/users/kingtruong79/orgs","repos_url":"https://api.github.com/users/kingtruong79/repos","events_url":"https://api.github.com/users/kingtruong79/events{/privacy}","received_events_url":"https://api.github.com/users/kingtruong79/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-01T04:52:24Z","updated_at":"2017-12-01T06:58:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68bdf33520458c8cf12fd264fafdf4509ad68774","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/pulls/4/commits","review_comments_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/pulls/4/comments","review_comment_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/issues/4/comments","statuses_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/statuses/ece5da8082bde3f003ba59357c8a005fa86f1d47","head":{"label":"kingtruong79:dev","ref":"dev","sha":"ece5da8082bde3f003ba59357c8a005fa86f1d47","user":{"login":"kingtruong79","id":30968020,"avatar_url":"https://avatars2.githubusercontent.com/u/30968020?v=4","gravatar_id":"","url":"https://api.github.com/users/kingtruong79","html_url":"https://github.com/kingtruong79","followers_url":"https://api.github.com/users/kingtruong79/followers","following_url":"https://api.github.com/users/kingtruong79/following{/other_user}","gists_url":"https://api.github.com/users/kingtruong79/gists{/gist_id}","starred_url":"https://api.github.com/users/kingtruong79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingtruong79/subscriptions","organizations_url":"https://api.github.com/users/kingtruong79/orgs","repos_url":"https://api.github.com/users/kingtruong79/repos","events_url":"https://api.github.com/users/kingtruong79/events{/privacy}","received_events_url":"https://api.github.com/users/kingtruong79/received_events","type":"User","site_admin":false},"repo":{"id":111754170,"name":"laravel_quickstart","full_name":"kingtruong79/laravel_quickstart","owner":{"login":"kingtruong79","id":30968020,"avatar_url":"https://avatars2.githubusercontent.com/u/30968020?v=4","gravatar_id":"","url":"https://api.github.com/users/kingtruong79","html_url":"https://github.com/kingtruong79","followers_url":"https://api.github.com/users/kingtruong79/followers","following_url":"https://api.github.com/users/kingtruong79/following{/other_user}","gists_url":"https://api.github.com/users/kingtruong79/gists{/gist_id}","starred_url":"https://api.github.com/users/kingtruong79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingtruong79/subscriptions","organizations_url":"https://api.github.com/users/kingtruong79/orgs","repos_url":"https://api.github.com/users/kingtruong79/repos","events_url":"https://api.github.com/users/kingtruong79/events{/privacy}","received_events_url":"https://api.github.com/users/kingtruong79/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kingtruong79/laravel_quickstart","description":null,"fork":false,"url":"https://api.github.com/repos/kingtruong79/laravel_quickstart","forks_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/forks","keys_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/teams","hooks_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/hooks","issue_events_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/issues/events{/number}","events_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/events","assignees_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/assignees{/user}","branches_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/branches{/branch}","tags_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/tags","blobs_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/git/refs{/sha}","trees_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/statuses/{sha}","languages_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/languages","stargazers_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/stargazers","contributors_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/contributors","subscribers_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/subscribers","subscription_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/subscription","commits_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/commits{/sha}","git_commits_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/git/commits{/sha}","comments_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/comments{/number}","issue_comment_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/issues/comments{/number}","contents_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/contents/{+path}","compare_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/merges","archive_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/downloads","issues_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/issues{/number}","pulls_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/pulls{/number}","milestones_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/milestones{/number}","notifications_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/labels{/name}","releases_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/releases{/id}","deployments_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/deployments","created_at":"2017-11-23T02:31:14Z","updated_at":"2017-12-01T00:51:34Z","pushed_at":"2017-12-01T04:52:24Z","git_url":"git://github.com/kingtruong79/laravel_quickstart.git","ssh_url":"[email protected]:kingtruong79/laravel_quickstart.git","clone_url":"https://github.com/kingtruong79/laravel_quickstart.git","svn_url":"https://github.com/kingtruong79/laravel_quickstart","homepage":null,"size":7160,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"kingtruong79:master","ref":"master","sha":"2f6dc13cb69bd3e7b31bc714bc76f5e66f822f7e","user":{"login":"kingtruong79","id":30968020,"avatar_url":"https://avatars2.githubusercontent.com/u/30968020?v=4","gravatar_id":"","url":"https://api.github.com/users/kingtruong79","html_url":"https://github.com/kingtruong79","followers_url":"https://api.github.com/users/kingtruong79/followers","following_url":"https://api.github.com/users/kingtruong79/following{/other_user}","gists_url":"https://api.github.com/users/kingtruong79/gists{/gist_id}","starred_url":"https://api.github.com/users/kingtruong79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingtruong79/subscriptions","organizations_url":"https://api.github.com/users/kingtruong79/orgs","repos_url":"https://api.github.com/users/kingtruong79/repos","events_url":"https://api.github.com/users/kingtruong79/events{/privacy}","received_events_url":"https://api.github.com/users/kingtruong79/received_events","type":"User","site_admin":false},"repo":{"id":111754170,"name":"laravel_quickstart","full_name":"kingtruong79/laravel_quickstart","owner":{"login":"kingtruong79","id":30968020,"avatar_url":"https://avatars2.githubusercontent.com/u/30968020?v=4","gravatar_id":"","url":"https://api.github.com/users/kingtruong79","html_url":"https://github.com/kingtruong79","followers_url":"https://api.github.com/users/kingtruong79/followers","following_url":"https://api.github.com/users/kingtruong79/following{/other_user}","gists_url":"https://api.github.com/users/kingtruong79/gists{/gist_id}","starred_url":"https://api.github.com/users/kingtruong79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingtruong79/subscriptions","organizations_url":"https://api.github.com/users/kingtruong79/orgs","repos_url":"https://api.github.com/users/kingtruong79/repos","events_url":"https://api.github.com/users/kingtruong79/events{/privacy}","received_events_url":"https://api.github.com/users/kingtruong79/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kingtruong79/laravel_quickstart","description":null,"fork":false,"url":"https://api.github.com/repos/kingtruong79/laravel_quickstart","forks_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/forks","keys_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/teams","hooks_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/hooks","issue_events_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/issues/events{/number}","events_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/events","assignees_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/assignees{/user}","branches_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/branches{/branch}","tags_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/tags","blobs_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/git/refs{/sha}","trees_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/statuses/{sha}","languages_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/languages","stargazers_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/stargazers","contributors_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/contributors","subscribers_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/subscribers","subscription_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/subscription","commits_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/commits{/sha}","git_commits_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/git/commits{/sha}","comments_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/comments{/number}","issue_comment_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/issues/comments{/number}","contents_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/contents/{+path}","compare_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/merges","archive_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/downloads","issues_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/issues{/number}","pulls_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/pulls{/number}","milestones_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/milestones{/number}","notifications_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/labels{/name}","releases_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/releases{/id}","deployments_url":"https://api.github.com/repos/kingtruong79/laravel_quickstart/deployments","created_at":"2017-11-23T02:31:14Z","updated_at":"2017-12-01T00:51:34Z","pushed_at":"2017-12-01T04:52:24Z","git_url":"git://github.com/kingtruong79/laravel_quickstart.git","ssh_url":"[email protected]:kingtruong79/laravel_quickstart.git","clone_url":"https://github.com/kingtruong79/laravel_quickstart.git","svn_url":"https://github.com/kingtruong79/laravel_quickstart","homepage":null,"size":7160,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kingtruong79/laravel_quickstart/pulls/4"},"html":{"href":"https://github.com/kingtruong79/laravel_quickstart/pull/4"},"issue":{"href":"https://api.github.com/repos/kingtruong79/laravel_quickstart/issues/4"},"comments":{"href":"https://api.github.com/repos/kingtruong79/laravel_quickstart/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/kingtruong79/laravel_quickstart/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/kingtruong79/laravel_quickstart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kingtruong79/laravel_quickstart/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/kingtruong79/laravel_quickstart/statuses/ece5da8082bde3f003ba59357c8a005fa86f1d47"}},"author_association":"OWNER"}} | {
"id": 111754170,
"name": "kingtruong79/laravel_quickstart",
"url": "https://api.github.com/repos/kingtruong79/laravel_quickstart"
} | {
"id": 19767833,
"login": "trangkarol",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19767833?",
"url": "https://api.github.com/users/trangkarol"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-12-01T06:49:41 | 6928740349 | {"actor":{"display_login":"trangkarol"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/pulls/comments/123552997","pull_request_review_id":45768748,"id":123552997,"diff_hunk":"@@ -0,0 +1 @@\n+Hello from the fork!","path":"CONTRIBUTING.md","position":1,"original_position":1,"commit_id":"8c824bd04630a4b78e8f95da5cde54f36e6c4a04","original_commit_id":"8c824bd04630a4b78e8f95da5cde54f36e6c4a04","user":{"login":"ryangribble-test2","id":25132668,"avatar_url":"https://avatars2.githubusercontent.com/u/25132668?v=3","gravatar_id":"","url":"https://api.github.com/users/ryangribble-test2","html_url":"https://github.com/ryangribble-test2","followers_url":"https://api.github.com/users/ryangribble-test2/followers","following_url":"https://api.github.com/users/ryangribble-test2/following{/other_user}","gists_url":"https://api.github.com/users/ryangribble-test2/gists{/gist_id}","starred_url":"https://api.github.com/users/ryangribble-test2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryangribble-test2/subscriptions","organizations_url":"https://api.github.com/users/ryangribble-test2/orgs","repos_url":"https://api.github.com/users/ryangribble-test2/repos","events_url":"https://api.github.com/users/ryangribble-test2/events{/privacy}","received_events_url":"https://api.github.com/users/ryangribble-test2/received_events","type":"User","site_admin":false},"body":"Comment 1","created_at":"2017-06-22T16:03:37Z","updated_at":"2017-06-22T16:03:37Z","html_url":"https://github.com/ryangribble-test2/test-repo-20170622040329453/pull/1#discussion_r123552997","pull_request_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/pulls/comments/123552997"},"html":{"href":"https://github.com/ryangribble-test2/test-repo-20170622040329453/pull/1#discussion_r123552997"},"pull_request":{"href":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/pulls/1","id":127029552,"html_url":"https://github.com/ryangribble-test2/test-repo-20170622040329453/pull/1","diff_url":"https://github.com/ryangribble-test2/test-repo-20170622040329453/pull/1.diff","patch_url":"https://github.com/ryangribble-test2/test-repo-20170622040329453/pull/1.patch","issue_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/issues/1","number":1,"state":"open","locked":false,"title":"Nice title for the pull request","user":{"login":"ryangribble-test2","id":25132668,"avatar_url":"https://avatars2.githubusercontent.com/u/25132668?v=3","gravatar_id":"","url":"https://api.github.com/users/ryangribble-test2","html_url":"https://github.com/ryangribble-test2","followers_url":"https://api.github.com/users/ryangribble-test2/followers","following_url":"https://api.github.com/users/ryangribble-test2/following{/other_user}","gists_url":"https://api.github.com/users/ryangribble-test2/gists{/gist_id}","starred_url":"https://api.github.com/users/ryangribble-test2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryangribble-test2/subscriptions","organizations_url":"https://api.github.com/users/ryangribble-test2/orgs","repos_url":"https://api.github.com/users/ryangribble-test2/repos","events_url":"https://api.github.com/users/ryangribble-test2/events{/privacy}","received_events_url":"https://api.github.com/users/ryangribble-test2/received_events","type":"User","site_admin":false},"body":null,"created_at":"2017-06-22T16:03:36Z","updated_at":"2017-06-22T16:03:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/issues/1/comments","statuses_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/statuses/8c824bd04630a4b78e8f95da5cde54f36e6c4a04","head":{"label":"ryangribble-test2:new-branch","ref":"new-branch","sha":"8c824bd04630a4b78e8f95da5cde54f36e6c4a04","user":{"login":"ryangribble-test2","id":25132668,"avatar_url":"https://avatars2.githubusercontent.com/u/25132668?v=3","gravatar_id":"","url":"https://api.github.com/users/ryangribble-test2","html_url":"https://github.com/ryangribble-test2","followers_url":"https://api.github.com/users/ryangribble-test2/followers","following_url":"https://api.github.com/users/ryangribble-test2/following{/other_user}","gists_url":"https://api.github.com/users/ryangribble-test2/gists{/gist_id}","starred_url":"https://api.github.com/users/ryangribble-test2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryangribble-test2/subscriptions","organizations_url":"https://api.github.com/users/ryangribble-test2/orgs","repos_url":"https://api.github.com/users/ryangribble-test2/repos","events_url":"https://api.github.com/users/ryangribble-test2/events{/privacy}","received_events_url":"https://api.github.com/users/ryangribble-test2/received_events","type":"User","site_admin":false},"repo":{"id":95133112,"name":"test-repo-20170622040329453","full_name":"ryangribble-test2/test-repo-20170622040329453","owner":{"login":"ryangribble-test2","id":25132668,"avatar_url":"https://avatars2.githubusercontent.com/u/25132668?v=3","gravatar_id":"","url":"https://api.github.com/users/ryangribble-test2","html_url":"https://github.com/ryangribble-test2","followers_url":"https://api.github.com/users/ryangribble-test2/followers","following_url":"https://api.github.com/users/ryangribble-test2/following{/other_user}","gists_url":"https://api.github.com/users/ryangribble-test2/gists{/gist_id}","starred_url":"https://api.github.com/users/ryangribble-test2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryangribble-test2/subscriptions","organizations_url":"https://api.github.com/users/ryangribble-test2/orgs","repos_url":"https://api.github.com/users/ryangribble-test2/repos","events_url":"https://api.github.com/users/ryangribble-test2/events{/privacy}","received_events_url":"https://api.github.com/users/ryangribble-test2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryangribble-test2/test-repo-20170622040329453","description":null,"fork":false,"url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453","forks_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/forks","keys_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/teams","hooks_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/hooks","issue_events_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/issues/events{/number}","events_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/events","assignees_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/assignees{/user}","branches_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/branches{/branch}","tags_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/tags","blobs_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/statuses/{sha}","languages_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/languages","stargazers_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/stargazers","contributors_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/contributors","subscribers_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/subscribers","subscription_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/subscription","commits_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/contents/{+path}","compare_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/merges","archive_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/downloads","issues_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/issues{/number}","pulls_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/pulls{/number}","milestones_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/milestones{/number}","notifications_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/labels{/name}","releases_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/releases{/id}","deployments_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/deployments","created_at":"2017-06-22T16:03:30Z","updated_at":"2017-06-22T16:03:30Z","pushed_at":"2017-06-22T16:03:37Z","git_url":"git://github.com/ryangribble-test2/test-repo-20170622040329453.git","ssh_url":"[email protected]:ryangribble-test2/test-repo-20170622040329453.git","clone_url":"https://github.com/ryangribble-test2/test-repo-20170622040329453.git","svn_url":"https://github.com/ryangribble-test2/test-repo-20170622040329453","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ryangribble-test2:master","ref":"master","sha":"990eb11566dc89caf866fa4551388874f65475a9","user":{"login":"ryangribble-test2","id":25132668,"avatar_url":"https://avatars2.githubusercontent.com/u/25132668?v=3","gravatar_id":"","url":"https://api.github.com/users/ryangribble-test2","html_url":"https://github.com/ryangribble-test2","followers_url":"https://api.github.com/users/ryangribble-test2/followers","following_url":"https://api.github.com/users/ryangribble-test2/following{/other_user}","gists_url":"https://api.github.com/users/ryangribble-test2/gists{/gist_id}","starred_url":"https://api.github.com/users/ryangribble-test2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryangribble-test2/subscriptions","organizations_url":"https://api.github.com/users/ryangribble-test2/orgs","repos_url":"https://api.github.com/users/ryangribble-test2/repos","events_url":"https://api.github.com/users/ryangribble-test2/events{/privacy}","received_events_url":"https://api.github.com/users/ryangribble-test2/received_events","type":"User","site_admin":false},"repo":{"id":95133112,"name":"test-repo-20170622040329453","full_name":"ryangribble-test2/test-repo-20170622040329453","owner":{"login":"ryangribble-test2","id":25132668,"avatar_url":"https://avatars2.githubusercontent.com/u/25132668?v=3","gravatar_id":"","url":"https://api.github.com/users/ryangribble-test2","html_url":"https://github.com/ryangribble-test2","followers_url":"https://api.github.com/users/ryangribble-test2/followers","following_url":"https://api.github.com/users/ryangribble-test2/following{/other_user}","gists_url":"https://api.github.com/users/ryangribble-test2/gists{/gist_id}","starred_url":"https://api.github.com/users/ryangribble-test2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryangribble-test2/subscriptions","organizations_url":"https://api.github.com/users/ryangribble-test2/orgs","repos_url":"https://api.github.com/users/ryangribble-test2/repos","events_url":"https://api.github.com/users/ryangribble-test2/events{/privacy}","received_events_url":"https://api.github.com/users/ryangribble-test2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryangribble-test2/test-repo-20170622040329453","description":null,"fork":false,"url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453","forks_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/forks","keys_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/teams","hooks_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/hooks","issue_events_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/issues/events{/number}","events_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/events","assignees_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/assignees{/user}","branches_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/branches{/branch}","tags_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/tags","blobs_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/statuses/{sha}","languages_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/languages","stargazers_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/stargazers","contributors_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/contributors","subscribers_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/subscribers","subscription_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/subscription","commits_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/contents/{+path}","compare_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/merges","archive_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/downloads","issues_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/issues{/number}","pulls_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/pulls{/number}","milestones_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/milestones{/number}","notifications_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/labels{/name}","releases_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/releases{/id}","deployments_url":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/deployments","created_at":"2017-06-22T16:03:30Z","updated_at":"2017-06-22T16:03:30Z","pushed_at":"2017-06-22T16:03:37Z","git_url":"git://github.com/ryangribble-test2/test-repo-20170622040329453.git","ssh_url":"[email protected]:ryangribble-test2/test-repo-20170622040329453.git","clone_url":"https://github.com/ryangribble-test2/test-repo-20170622040329453.git","svn_url":"https://github.com/ryangribble-test2/test-repo-20170622040329453","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/pulls/1"},"html":{"href":"https://github.com/ryangribble-test2/test-repo-20170622040329453/pull/1"},"issue":{"href":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/issues/1"},"comments":{"href":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453/statuses/8c824bd04630a4b78e8f95da5cde54f36e6c4a04"}}}} | {
"id": 95133112,
"name": "ryangribble-test2/test-repo-20170622040329453",
"url": "https://api.github.com/repos/ryangribble-test2/test-repo-20170622040329453"
} | {
"id": 25132668,
"login": "ryangribble-test2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25132668?",
"url": "https://api.github.com/users/ryangribble-test2"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-06-22T16:03:37 | 6119396295 | {"actor":{"display_login":"ryangribble-test2"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/jessesrsmith/ecom_app/pulls/comments/98098616","pull_request_review_id":18731006,"id":98098616,"diff_hunk":"@@ -0,0 +1,107 @@\n+class OrdersController < ApplicationController\n+ include CurrentCart\n+ before_action :set_cart, only: [:new, :create]\n+ before_action :set_order, only: [:show, :edit, :update, :destroy]\n+\n+ # GET /orders\n+ # GET /orders.json\n+ def index\n+ @orders = Order.all\n+ end\n+\n+ # GET /orders/1\n+ # GET /orders/1.json\n+ def show\n+ end\n+\n+ # GET /orders/new\n+ def new\n+ if @cart.line_items.empty?\n+ redirect_to products_url, warning: \"Your cart is empty\"\n+ return\n+ end\n+ end\n+\n+ # GET /orders/1/edit\n+ def edit\n+ end\n+\n+ # POST /orders\n+ # POST /orders.json\n+ def create\n+ # Amount in cents\n+ @amount = (@cart.total_price * 100).to_i\n+\n+ # Stripe\n+ begin\n+ customer = Stripe::Customer.create(\n+ :email => params[:stripeEmail],\n+ :source => params[:stripeToken]\n+ )\n+ charge = Stripe::Charge.create(\n+ :customer => customer.id,\n+ :amount => @amount,\n+ :description => 'Rails Stripe customer',\n+ :currency => 'usd'\n+ )\n+ rescue Stripe::CardError => e\n+ flash[:error] = e.message\n+ end\n+\n+ # DB Order\n+ @order = Order.new do |o|\n+ o.name = params[:stripeBillingName]\n+ o.total = @cart.total_price\n+ end\n+ @order.add_line_items_from_cart(@cart)\n+\n+ respond_to do |format|\n+ if @order.save\n+ Cart.destroy(session[:cart_id])\n+ session[:cart_id] = nil\n+\n+ format.html { redirect_to products_url, success: 'Thanks for your order.' }\n+ format.json { render :show, status: :created, location: @order }\n+ else\n+ format.html { render :new }\n+ format.json { render json: @order.errors, status: :unprocessable_entity }\n+ end\n+ end\n+ end\n+\n+ # PATCH/PUT /orders/1\n+ # PATCH/PUT /orders/1.json\n+ def update\n+ respond_to do |format|\n+ if @order.update(order_params)\n+ format.html { redirect_to @order, notice: 'Order was successfully updated.' }\n+ format.json { render :show, status: :ok, location: @order }\n+ else\n+ format.html { render :edit }\n+ format.json { render json: @order.errors, status: :unprocessable_entity }\n+ end\n+ end\n+ end\n+\n+ # DELETE /orders/1\n+ # DELETE /orders/1.json\n+ def destroy\n+ @order.destroy\n+ respond_to do |format|\n+ format.html { redirect_to orders_url, notice: 'Order was successfully destroyed.' }\n+ format.json { head :no_content }\n+ end\n+ end\n+\n+ private\n+\n+ # Use callbacks to share common setup or constraints between actions.\n+ def set_order","path":"app/controllers/orders_controller.rb","position":99,"original_position":99,"commit_id":"1730cc8aa934e004463d78eea200cc819a823d0c","original_commit_id":"1730cc8aa934e004463d78eea200cc819a823d0c","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Inconsistent indentation detected.","created_at":"2017-01-26T21:42:46Z","updated_at":"2017-01-26T21:42:46Z","html_url":"https://github.com/jessesrsmith/ecom_app/pull/46#discussion_r98098616","pull_request_url":"https://api.github.com/repos/jessesrsmith/ecom_app/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/jessesrsmith/ecom_app/pulls/comments/98098616"},"html":{"href":"https://github.com/jessesrsmith/ecom_app/pull/46#discussion_r98098616"},"pull_request":{"href":"https://api.github.com/repos/jessesrsmith/ecom_app/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/jessesrsmith/ecom_app/pulls/46","id":103395472,"html_url":"https://github.com/jessesrsmith/ecom_app/pull/46","diff_url":"https://github.com/jessesrsmith/ecom_app/pull/46.diff","patch_url":"https://github.com/jessesrsmith/ecom_app/pull/46.patch","issue_url":"https://api.github.com/repos/jessesrsmith/ecom_app/issues/46","number":46,"state":"open","locked":false,"title":"Orders","user":{"login":"jessesrsmith","id":1389832,"avatar_url":"https://avatars.githubusercontent.com/u/1389832?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesrsmith","html_url":"https://github.com/jessesrsmith","followers_url":"https://api.github.com/users/jessesrsmith/followers","following_url":"https://api.github.com/users/jessesrsmith/following{/other_user}","gists_url":"https://api.github.com/users/jessesrsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesrsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesrsmith/subscriptions","organizations_url":"https://api.github.com/users/jessesrsmith/orgs","repos_url":"https://api.github.com/users/jessesrsmith/repos","events_url":"https://api.github.com/users/jessesrsmith/events{/privacy}","received_events_url":"https://api.github.com/users/jessesrsmith/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-26T21:42:27Z","updated_at":"2017-01-26T21:42:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d654f1fc9d56783ab29c769c8c504dfc705e0058","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jessesrsmith/ecom_app/pulls/46/commits","review_comments_url":"https://api.github.com/repos/jessesrsmith/ecom_app/pulls/46/comments","review_comment_url":"https://api.github.com/repos/jessesrsmith/ecom_app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jessesrsmith/ecom_app/issues/46/comments","statuses_url":"https://api.github.com/repos/jessesrsmith/ecom_app/statuses/1730cc8aa934e004463d78eea200cc819a823d0c","head":{"label":"jessesrsmith:orders","ref":"orders","sha":"1730cc8aa934e004463d78eea200cc819a823d0c","user":{"login":"jessesrsmith","id":1389832,"avatar_url":"https://avatars.githubusercontent.com/u/1389832?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesrsmith","html_url":"https://github.com/jessesrsmith","followers_url":"https://api.github.com/users/jessesrsmith/followers","following_url":"https://api.github.com/users/jessesrsmith/following{/other_user}","gists_url":"https://api.github.com/users/jessesrsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesrsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesrsmith/subscriptions","organizations_url":"https://api.github.com/users/jessesrsmith/orgs","repos_url":"https://api.github.com/users/jessesrsmith/repos","events_url":"https://api.github.com/users/jessesrsmith/events{/privacy}","received_events_url":"https://api.github.com/users/jessesrsmith/received_events","type":"User","site_admin":false},"repo":{"id":44257752,"name":"ecom_app","full_name":"jessesrsmith/ecom_app","owner":{"login":"jessesrsmith","id":1389832,"avatar_url":"https://avatars.githubusercontent.com/u/1389832?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesrsmith","html_url":"https://github.com/jessesrsmith","followers_url":"https://api.github.com/users/jessesrsmith/followers","following_url":"https://api.github.com/users/jessesrsmith/following{/other_user}","gists_url":"https://api.github.com/users/jessesrsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesrsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesrsmith/subscriptions","organizations_url":"https://api.github.com/users/jessesrsmith/orgs","repos_url":"https://api.github.com/users/jessesrsmith/repos","events_url":"https://api.github.com/users/jessesrsmith/events{/privacy}","received_events_url":"https://api.github.com/users/jessesrsmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jessesrsmith/ecom_app","description":"A sample e-commerace app in Rails.","fork":false,"url":"https://api.github.com/repos/jessesrsmith/ecom_app","forks_url":"https://api.github.com/repos/jessesrsmith/ecom_app/forks","keys_url":"https://api.github.com/repos/jessesrsmith/ecom_app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jessesrsmith/ecom_app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jessesrsmith/ecom_app/teams","hooks_url":"https://api.github.com/repos/jessesrsmith/ecom_app/hooks","issue_events_url":"https://api.github.com/repos/jessesrsmith/ecom_app/issues/events{/number}","events_url":"https://api.github.com/repos/jessesrsmith/ecom_app/events","assignees_url":"https://api.github.com/repos/jessesrsmith/ecom_app/assignees{/user}","branches_url":"https://api.github.com/repos/jessesrsmith/ecom_app/branches{/branch}","tags_url":"https://api.github.com/repos/jessesrsmith/ecom_app/tags","blobs_url":"https://api.github.com/repos/jessesrsmith/ecom_app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jessesrsmith/ecom_app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jessesrsmith/ecom_app/git/refs{/sha}","trees_url":"https://api.github.com/repos/jessesrsmith/ecom_app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jessesrsmith/ecom_app/statuses/{sha}","languages_url":"https://api.github.com/repos/jessesrsmith/ecom_app/languages","stargazers_url":"https://api.github.com/repos/jessesrsmith/ecom_app/stargazers","contributors_url":"https://api.github.com/repos/jessesrsmith/ecom_app/contributors","subscribers_url":"https://api.github.com/repos/jessesrsmith/ecom_app/subscribers","subscription_url":"https://api.github.com/repos/jessesrsmith/ecom_app/subscription","commits_url":"https://api.github.com/repos/jessesrsmith/ecom_app/commits{/sha}","git_commits_url":"https://api.github.com/repos/jessesrsmith/ecom_app/git/commits{/sha}","comments_url":"https://api.github.com/repos/jessesrsmith/ecom_app/comments{/number}","issue_comment_url":"https://api.github.com/repos/jessesrsmith/ecom_app/issues/comments{/number}","contents_url":"https://api.github.com/repos/jessesrsmith/ecom_app/contents/{+path}","compare_url":"https://api.github.com/repos/jessesrsmith/ecom_app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jessesrsmith/ecom_app/merges","archive_url":"https://api.github.com/repos/jessesrsmith/ecom_app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jessesrsmith/ecom_app/downloads","issues_url":"https://api.github.com/repos/jessesrsmith/ecom_app/issues{/number}","pulls_url":"https://api.github.com/repos/jessesrsmith/ecom_app/pulls{/number}","milestones_url":"https://api.github.com/repos/jessesrsmith/ecom_app/milestones{/number}","notifications_url":"https://api.github.com/repos/jessesrsmith/ecom_app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jessesrsmith/ecom_app/labels{/name}","releases_url":"https://api.github.com/repos/jessesrsmith/ecom_app/releases{/id}","deployments_url":"https://api.github.com/repos/jessesrsmith/ecom_app/deployments","created_at":"2015-10-14T15:37:11Z","updated_at":"2017-01-26T21:40:16Z","pushed_at":"2017-01-26T21:42:27Z","git_url":"git://github.com/jessesrsmith/ecom_app.git","ssh_url":"[email protected]:jessesrsmith/ecom_app.git","clone_url":"https://github.com/jessesrsmith/ecom_app.git","svn_url":"https://github.com/jessesrsmith/ecom_app","homepage":"","size":148,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"base":{"label":"jessesrsmith:master","ref":"master","sha":"9f63f4af95d0fca3593200808f74e8a8fd120757","user":{"login":"jessesrsmith","id":1389832,"avatar_url":"https://avatars.githubusercontent.com/u/1389832?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesrsmith","html_url":"https://github.com/jessesrsmith","followers_url":"https://api.github.com/users/jessesrsmith/followers","following_url":"https://api.github.com/users/jessesrsmith/following{/other_user}","gists_url":"https://api.github.com/users/jessesrsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesrsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesrsmith/subscriptions","organizations_url":"https://api.github.com/users/jessesrsmith/orgs","repos_url":"https://api.github.com/users/jessesrsmith/repos","events_url":"https://api.github.com/users/jessesrsmith/events{/privacy}","received_events_url":"https://api.github.com/users/jessesrsmith/received_events","type":"User","site_admin":false},"repo":{"id":44257752,"name":"ecom_app","full_name":"jessesrsmith/ecom_app","owner":{"login":"jessesrsmith","id":1389832,"avatar_url":"https://avatars.githubusercontent.com/u/1389832?v=3","gravatar_id":"","url":"https://api.github.com/users/jessesrsmith","html_url":"https://github.com/jessesrsmith","followers_url":"https://api.github.com/users/jessesrsmith/followers","following_url":"https://api.github.com/users/jessesrsmith/following{/other_user}","gists_url":"https://api.github.com/users/jessesrsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesrsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesrsmith/subscriptions","organizations_url":"https://api.github.com/users/jessesrsmith/orgs","repos_url":"https://api.github.com/users/jessesrsmith/repos","events_url":"https://api.github.com/users/jessesrsmith/events{/privacy}","received_events_url":"https://api.github.com/users/jessesrsmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jessesrsmith/ecom_app","description":"A sample e-commerace app in Rails.","fork":false,"url":"https://api.github.com/repos/jessesrsmith/ecom_app","forks_url":"https://api.github.com/repos/jessesrsmith/ecom_app/forks","keys_url":"https://api.github.com/repos/jessesrsmith/ecom_app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jessesrsmith/ecom_app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jessesrsmith/ecom_app/teams","hooks_url":"https://api.github.com/repos/jessesrsmith/ecom_app/hooks","issue_events_url":"https://api.github.com/repos/jessesrsmith/ecom_app/issues/events{/number}","events_url":"https://api.github.com/repos/jessesrsmith/ecom_app/events","assignees_url":"https://api.github.com/repos/jessesrsmith/ecom_app/assignees{/user}","branches_url":"https://api.github.com/repos/jessesrsmith/ecom_app/branches{/branch}","tags_url":"https://api.github.com/repos/jessesrsmith/ecom_app/tags","blobs_url":"https://api.github.com/repos/jessesrsmith/ecom_app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jessesrsmith/ecom_app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jessesrsmith/ecom_app/git/refs{/sha}","trees_url":"https://api.github.com/repos/jessesrsmith/ecom_app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jessesrsmith/ecom_app/statuses/{sha}","languages_url":"https://api.github.com/repos/jessesrsmith/ecom_app/languages","stargazers_url":"https://api.github.com/repos/jessesrsmith/ecom_app/stargazers","contributors_url":"https://api.github.com/repos/jessesrsmith/ecom_app/contributors","subscribers_url":"https://api.github.com/repos/jessesrsmith/ecom_app/subscribers","subscription_url":"https://api.github.com/repos/jessesrsmith/ecom_app/subscription","commits_url":"https://api.github.com/repos/jessesrsmith/ecom_app/commits{/sha}","git_commits_url":"https://api.github.com/repos/jessesrsmith/ecom_app/git/commits{/sha}","comments_url":"https://api.github.com/repos/jessesrsmith/ecom_app/comments{/number}","issue_comment_url":"https://api.github.com/repos/jessesrsmith/ecom_app/issues/comments{/number}","contents_url":"https://api.github.com/repos/jessesrsmith/ecom_app/contents/{+path}","compare_url":"https://api.github.com/repos/jessesrsmith/ecom_app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jessesrsmith/ecom_app/merges","archive_url":"https://api.github.com/repos/jessesrsmith/ecom_app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jessesrsmith/ecom_app/downloads","issues_url":"https://api.github.com/repos/jessesrsmith/ecom_app/issues{/number}","pulls_url":"https://api.github.com/repos/jessesrsmith/ecom_app/pulls{/number}","milestones_url":"https://api.github.com/repos/jessesrsmith/ecom_app/milestones{/number}","notifications_url":"https://api.github.com/repos/jessesrsmith/ecom_app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jessesrsmith/ecom_app/labels{/name}","releases_url":"https://api.github.com/repos/jessesrsmith/ecom_app/releases{/id}","deployments_url":"https://api.github.com/repos/jessesrsmith/ecom_app/deployments","created_at":"2015-10-14T15:37:11Z","updated_at":"2017-01-26T21:40:16Z","pushed_at":"2017-01-26T21:42:27Z","git_url":"git://github.com/jessesrsmith/ecom_app.git","ssh_url":"[email protected]:jessesrsmith/ecom_app.git","clone_url":"https://github.com/jessesrsmith/ecom_app.git","svn_url":"https://github.com/jessesrsmith/ecom_app","homepage":"","size":148,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jessesrsmith/ecom_app/pulls/46"},"html":{"href":"https://github.com/jessesrsmith/ecom_app/pull/46"},"issue":{"href":"https://api.github.com/repos/jessesrsmith/ecom_app/issues/46"},"comments":{"href":"https://api.github.com/repos/jessesrsmith/ecom_app/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/jessesrsmith/ecom_app/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/jessesrsmith/ecom_app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jessesrsmith/ecom_app/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/jessesrsmith/ecom_app/statuses/1730cc8aa934e004463d78eea200cc819a823d0c"}}}} | {
"id": 44257752,
"name": "jessesrsmith/ecom_app",
"url": "https://api.github.com/repos/jessesrsmith/ecom_app"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-01-26T21:42:46 | 5220381633 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/pulls/comments/107875259","pull_request_review_id":28871812,"id":107875259,"diff_hunk":"@@ -173,5 +179,76 @@ public Attendee(User user, String review, int rating) {\n this.rating = rating;\n }\n }\n+ /**\n+ * this method is called when a user of Type at least Upper Board wants to delte a meeting in the Database\n+ * @param {String} accessToken [token of the requesting user]\n+ * @param {HTTPResponse} HTTP_RESPONSE [HTTPResponse interface instance]\n+ * @return {void}\n+ */\n+ public void delete(String accessToken, final HTTPResponse HTTP_RESPONSE){\n+\n+ OkHttpClient client = new OkHttpClient();\n+ final Meeting meeting = this;\n+ Request request=new Request.Builder()","path":"app/src/main/java/org/ieeeguc/ieeeguc/models/Meeting.java","position":39,"original_position":39,"commit_id":"1be1a1185b8c7cc5fd8b244df29cee80b67f1b30","original_commit_id":"1be1a1185b8c7cc5fd8b244df29cee80b67f1b30","user":{"login":"KEMDAK","id":16259349,"avatar_url":"https://avatars0.githubusercontent.com/u/16259349?v=3","gravatar_id":"","url":"https://api.github.com/users/KEMDAK","html_url":"https://github.com/KEMDAK","followers_url":"https://api.github.com/users/KEMDAK/followers","following_url":"https://api.github.com/users/KEMDAK/following{/other_user}","gists_url":"https://api.github.com/users/KEMDAK/gists{/gist_id}","starred_url":"https://api.github.com/users/KEMDAK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KEMDAK/subscriptions","organizations_url":"https://api.github.com/users/KEMDAK/orgs","repos_url":"https://api.github.com/users/KEMDAK/repos","events_url":"https://api.github.com/users/KEMDAK/events{/privacy}","received_events_url":"https://api.github.com/users/KEMDAK/received_events","type":"User","site_admin":false},"body":"are you sure that this is a delete request?!!!","created_at":"2017-03-24T10:39:05Z","updated_at":"2017-03-24T10:40:31Z","html_url":"https://github.com/KEMDAK/IEEEGUCSB-System_Andriod/pull/19#discussion_r107875259","pull_request_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/pulls/comments/107875259"},"html":{"href":"https://github.com/KEMDAK/IEEEGUCSB-System_Andriod/pull/19#discussion_r107875259"},"pull_request":{"href":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/pulls/19","id":107821162,"html_url":"https://github.com/KEMDAK/IEEEGUCSB-System_Andriod/pull/19","diff_url":"https://github.com/KEMDAK/IEEEGUCSB-System_Andriod/pull/19.diff","patch_url":"https://github.com/KEMDAK/IEEEGUCSB-System_Andriod/pull/19.patch","issue_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/issues/19","number":19,"state":"open","locked":false,"title":"edit committee method","user":{"login":"SallyHabib","id":25287494,"avatar_url":"https://avatars1.githubusercontent.com/u/25287494?v=3","gravatar_id":"","url":"https://api.github.com/users/SallyHabib","html_url":"https://github.com/SallyHabib","followers_url":"https://api.github.com/users/SallyHabib/followers","following_url":"https://api.github.com/users/SallyHabib/following{/other_user}","gists_url":"https://api.github.com/users/SallyHabib/gists{/gist_id}","starred_url":"https://api.github.com/users/SallyHabib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SallyHabib/subscriptions","organizations_url":"https://api.github.com/users/SallyHabib/orgs","repos_url":"https://api.github.com/users/SallyHabib/repos","events_url":"https://api.github.com/users/SallyHabib/events{/privacy}","received_events_url":"https://api.github.com/users/SallyHabib/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-24T12:30:41Z","updated_at":"2017-03-24T10:40:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"661705ded9554678e3cf2c8a36c6eacbccdbb266","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/pulls/19/commits","review_comments_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/pulls/19/comments","review_comment_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/issues/19/comments","statuses_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/statuses/1be1a1185b8c7cc5fd8b244df29cee80b67f1b30","head":{"label":"KEMDAK:sally","ref":"sally","sha":"1be1a1185b8c7cc5fd8b244df29cee80b67f1b30","user":{"login":"KEMDAK","id":16259349,"avatar_url":"https://avatars0.githubusercontent.com/u/16259349?v=3","gravatar_id":"","url":"https://api.github.com/users/KEMDAK","html_url":"https://github.com/KEMDAK","followers_url":"https://api.github.com/users/KEMDAK/followers","following_url":"https://api.github.com/users/KEMDAK/following{/other_user}","gists_url":"https://api.github.com/users/KEMDAK/gists{/gist_id}","starred_url":"https://api.github.com/users/KEMDAK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KEMDAK/subscriptions","organizations_url":"https://api.github.com/users/KEMDAK/orgs","repos_url":"https://api.github.com/users/KEMDAK/repos","events_url":"https://api.github.com/users/KEMDAK/events{/privacy}","received_events_url":"https://api.github.com/users/KEMDAK/received_events","type":"User","site_admin":false},"repo":{"id":79852713,"name":"IEEEGUCSB-System_Andriod","full_name":"KEMDAK/IEEEGUCSB-System_Andriod","owner":{"login":"KEMDAK","id":16259349,"avatar_url":"https://avatars0.githubusercontent.com/u/16259349?v=3","gravatar_id":"","url":"https://api.github.com/users/KEMDAK","html_url":"https://github.com/KEMDAK","followers_url":"https://api.github.com/users/KEMDAK/followers","following_url":"https://api.github.com/users/KEMDAK/following{/other_user}","gists_url":"https://api.github.com/users/KEMDAK/gists{/gist_id}","starred_url":"https://api.github.com/users/KEMDAK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KEMDAK/subscriptions","organizations_url":"https://api.github.com/users/KEMDAK/orgs","repos_url":"https://api.github.com/users/KEMDAK/repos","events_url":"https://api.github.com/users/KEMDAK/events{/privacy}","received_events_url":"https://api.github.com/users/KEMDAK/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KEMDAK/IEEEGUCSB-System_Andriod","description":"This is a front end Android application that serves as a client for IEEE GUC System","fork":false,"url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod","forks_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/forks","keys_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/teams","hooks_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/hooks","issue_events_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/issues/events{/number}","events_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/events","assignees_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/assignees{/user}","branches_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/branches{/branch}","tags_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/tags","blobs_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/git/refs{/sha}","trees_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/statuses/{sha}","languages_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/languages","stargazers_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/stargazers","contributors_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/contributors","subscribers_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/subscribers","subscription_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/subscription","commits_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/commits{/sha}","git_commits_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/git/commits{/sha}","comments_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/comments{/number}","issue_comment_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/issues/comments{/number}","contents_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/contents/{+path}","compare_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/merges","archive_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/downloads","issues_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/issues{/number}","pulls_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/pulls{/number}","milestones_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/milestones{/number}","notifications_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/labels{/name}","releases_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/releases{/id}","deployments_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/deployments","created_at":"2017-01-23T22:01:01Z","updated_at":"2017-01-23T22:18:40Z","pushed_at":"2017-03-24T10:30:40Z","git_url":"git://github.com/KEMDAK/IEEEGUCSB-System_Andriod.git","ssh_url":"[email protected]:KEMDAK/IEEEGUCSB-System_Andriod.git","clone_url":"https://github.com/KEMDAK/IEEEGUCSB-System_Andriod.git","svn_url":"https://github.com/KEMDAK/IEEEGUCSB-System_Andriod","homepage":null,"size":511,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"KEMDAK:dev","ref":"dev","sha":"c5addcec2f20ce18e115d3e34c660d4d40a3c721","user":{"login":"KEMDAK","id":16259349,"avatar_url":"https://avatars0.githubusercontent.com/u/16259349?v=3","gravatar_id":"","url":"https://api.github.com/users/KEMDAK","html_url":"https://github.com/KEMDAK","followers_url":"https://api.github.com/users/KEMDAK/followers","following_url":"https://api.github.com/users/KEMDAK/following{/other_user}","gists_url":"https://api.github.com/users/KEMDAK/gists{/gist_id}","starred_url":"https://api.github.com/users/KEMDAK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KEMDAK/subscriptions","organizations_url":"https://api.github.com/users/KEMDAK/orgs","repos_url":"https://api.github.com/users/KEMDAK/repos","events_url":"https://api.github.com/users/KEMDAK/events{/privacy}","received_events_url":"https://api.github.com/users/KEMDAK/received_events","type":"User","site_admin":false},"repo":{"id":79852713,"name":"IEEEGUCSB-System_Andriod","full_name":"KEMDAK/IEEEGUCSB-System_Andriod","owner":{"login":"KEMDAK","id":16259349,"avatar_url":"https://avatars0.githubusercontent.com/u/16259349?v=3","gravatar_id":"","url":"https://api.github.com/users/KEMDAK","html_url":"https://github.com/KEMDAK","followers_url":"https://api.github.com/users/KEMDAK/followers","following_url":"https://api.github.com/users/KEMDAK/following{/other_user}","gists_url":"https://api.github.com/users/KEMDAK/gists{/gist_id}","starred_url":"https://api.github.com/users/KEMDAK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KEMDAK/subscriptions","organizations_url":"https://api.github.com/users/KEMDAK/orgs","repos_url":"https://api.github.com/users/KEMDAK/repos","events_url":"https://api.github.com/users/KEMDAK/events{/privacy}","received_events_url":"https://api.github.com/users/KEMDAK/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KEMDAK/IEEEGUCSB-System_Andriod","description":"This is a front end Android application that serves as a client for IEEE GUC System","fork":false,"url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod","forks_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/forks","keys_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/teams","hooks_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/hooks","issue_events_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/issues/events{/number}","events_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/events","assignees_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/assignees{/user}","branches_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/branches{/branch}","tags_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/tags","blobs_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/git/refs{/sha}","trees_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/statuses/{sha}","languages_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/languages","stargazers_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/stargazers","contributors_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/contributors","subscribers_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/subscribers","subscription_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/subscription","commits_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/commits{/sha}","git_commits_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/git/commits{/sha}","comments_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/comments{/number}","issue_comment_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/issues/comments{/number}","contents_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/contents/{+path}","compare_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/merges","archive_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/downloads","issues_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/issues{/number}","pulls_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/pulls{/number}","milestones_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/milestones{/number}","notifications_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/labels{/name}","releases_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/releases{/id}","deployments_url":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/deployments","created_at":"2017-01-23T22:01:01Z","updated_at":"2017-01-23T22:18:40Z","pushed_at":"2017-03-24T10:30:40Z","git_url":"git://github.com/KEMDAK/IEEEGUCSB-System_Andriod.git","ssh_url":"[email protected]:KEMDAK/IEEEGUCSB-System_Andriod.git","clone_url":"https://github.com/KEMDAK/IEEEGUCSB-System_Andriod.git","svn_url":"https://github.com/KEMDAK/IEEEGUCSB-System_Andriod","homepage":null,"size":511,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/pulls/19"},"html":{"href":"https://github.com/KEMDAK/IEEEGUCSB-System_Andriod/pull/19"},"issue":{"href":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/issues/19"},"comments":{"href":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod/statuses/1be1a1185b8c7cc5fd8b244df29cee80b67f1b30"}}}} | {
"id": 79852713,
"name": "KEMDAK/IEEEGUCSB-System_Andriod",
"url": "https://api.github.com/repos/KEMDAK/IEEEGUCSB-System_Andriod"
} | {
"id": 16259349,
"login": "KEMDAK",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16259349?",
"url": "https://api.github.com/users/KEMDAK"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-03-24T10:39:05 | 5556971001 | {"actor":{"display_login":"KEMDAK"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/pulls/comments/100589136","pull_request_review_id":21305050,"id":100589136,"diff_hunk":"@@ -0,0 +1,47 @@\n+require 'rails_helper'\n+\n+RSpec.describe \"Logged in user\" do\n+ context 'creates a new project' do\n+ it 'and sees the new project' do\n+ create_list(:category, 6)\n+\n+ category = Category.first\n+\n+ user = create(:user)\n+\n+ page.set_rack_session(user_id: user.id)\n+\n+ visit start_path\n+ \n+ expect(page).to have_content(\"Choose a category:\")","path":"spec/features/projects/user_creates_new_project_spec.rb","position":16,"original_position":16,"commit_id":"953f115c37dce46db0d762c8bbcd1e57120e09dc","original_commit_id":"953f115c37dce46db0d762c8bbcd1e57120e09dc","user":{"login":"Dpalazzari","id":19585280,"avatar_url":"https://avatars.githubusercontent.com/u/19585280?v=3","gravatar_id":"","url":"https://api.github.com/users/Dpalazzari","html_url":"https://github.com/Dpalazzari","followers_url":"https://api.github.com/users/Dpalazzari/followers","following_url":"https://api.github.com/users/Dpalazzari/following{/other_user}","gists_url":"https://api.github.com/users/Dpalazzari/gists{/gist_id}","starred_url":"https://api.github.com/users/Dpalazzari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dpalazzari/subscriptions","organizations_url":"https://api.github.com/users/Dpalazzari/orgs","repos_url":"https://api.github.com/users/Dpalazzari/repos","events_url":"https://api.github.com/users/Dpalazzari/events{/privacy}","received_events_url":"https://api.github.com/users/Dpalazzari/received_events","type":"User","site_admin":false},"body":"Removed!","created_at":"2017-02-10T18:00:44Z","updated_at":"2017-02-10T18:00:44Z","html_url":"https://github.com/Robbie-Smith/kickstarter_clone/pull/59#discussion_r100589136","pull_request_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/pulls/59","_links":{"self":{"href":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/pulls/comments/100589136"},"html":{"href":"https://github.com/Robbie-Smith/kickstarter_clone/pull/59#discussion_r100589136"},"pull_request":{"href":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/pulls/59","id":105562860,"html_url":"https://github.com/Robbie-Smith/kickstarter_clone/pull/59","diff_url":"https://github.com/Robbie-Smith/kickstarter_clone/pull/59.diff","patch_url":"https://github.com/Robbie-Smith/kickstarter_clone/pull/59.patch","issue_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/issues/59","number":59,"state":"open","locked":false,"title":"Dp/create project","user":{"login":"Dpalazzari","id":19585280,"avatar_url":"https://avatars.githubusercontent.com/u/19585280?v=3","gravatar_id":"","url":"https://api.github.com/users/Dpalazzari","html_url":"https://github.com/Dpalazzari","followers_url":"https://api.github.com/users/Dpalazzari/followers","following_url":"https://api.github.com/users/Dpalazzari/following{/other_user}","gists_url":"https://api.github.com/users/Dpalazzari/gists{/gist_id}","starred_url":"https://api.github.com/users/Dpalazzari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dpalazzari/subscriptions","organizations_url":"https://api.github.com/users/Dpalazzari/orgs","repos_url":"https://api.github.com/users/Dpalazzari/repos","events_url":"https://api.github.com/users/Dpalazzari/events{/privacy}","received_events_url":"https://api.github.com/users/Dpalazzari/received_events","type":"User","site_admin":false},"body":"In this PR: \r\n\r\n- Adds project creation functionality.\r\n- Tests project creation functionality.\r\n\r\nWith Daniel's branch, Closes #21 \r\n\r\nThis is a work in progress, but you guys should check it out and tell me if you see something I should do differently. \r\n\r\n@Robbie-Smith @kheppenstall @jdconrad89 @drod1000 ","created_at":"2017-02-10T04:03:17Z","updated_at":"2017-02-10T18:00:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bc5f062eb1d6f2c4a96d46244492c4e953296bc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/pulls/59/commits","review_comments_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/pulls/59/comments","review_comment_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/issues/59/comments","statuses_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/statuses/953f115c37dce46db0d762c8bbcd1e57120e09dc","head":{"label":"Robbie-Smith:dp/create_project","ref":"dp/create_project","sha":"953f115c37dce46db0d762c8bbcd1e57120e09dc","user":{"login":"Robbie-Smith","id":15495167,"avatar_url":"https://avatars.githubusercontent.com/u/15495167?v=3","gravatar_id":"","url":"https://api.github.com/users/Robbie-Smith","html_url":"https://github.com/Robbie-Smith","followers_url":"https://api.github.com/users/Robbie-Smith/followers","following_url":"https://api.github.com/users/Robbie-Smith/following{/other_user}","gists_url":"https://api.github.com/users/Robbie-Smith/gists{/gist_id}","starred_url":"https://api.github.com/users/Robbie-Smith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robbie-Smith/subscriptions","organizations_url":"https://api.github.com/users/Robbie-Smith/orgs","repos_url":"https://api.github.com/users/Robbie-Smith/repos","events_url":"https://api.github.com/users/Robbie-Smith/events{/privacy}","received_events_url":"https://api.github.com/users/Robbie-Smith/received_events","type":"User","site_admin":false},"repo":{"id":81138788,"name":"kickstarter_clone","full_name":"Robbie-Smith/kickstarter_clone","owner":{"login":"Robbie-Smith","id":15495167,"avatar_url":"https://avatars.githubusercontent.com/u/15495167?v=3","gravatar_id":"","url":"https://api.github.com/users/Robbie-Smith","html_url":"https://github.com/Robbie-Smith","followers_url":"https://api.github.com/users/Robbie-Smith/followers","following_url":"https://api.github.com/users/Robbie-Smith/following{/other_user}","gists_url":"https://api.github.com/users/Robbie-Smith/gists{/gist_id}","starred_url":"https://api.github.com/users/Robbie-Smith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robbie-Smith/subscriptions","organizations_url":"https://api.github.com/users/Robbie-Smith/orgs","repos_url":"https://api.github.com/users/Robbie-Smith/repos","events_url":"https://api.github.com/users/Robbie-Smith/events{/privacy}","received_events_url":"https://api.github.com/users/Robbie-Smith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Robbie-Smith/kickstarter_clone","description":null,"fork":false,"url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone","forks_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/forks","keys_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/teams","hooks_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/hooks","issue_events_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/issues/events{/number}","events_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/events","assignees_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/assignees{/user}","branches_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/branches{/branch}","tags_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/tags","blobs_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/git/refs{/sha}","trees_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/statuses/{sha}","languages_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/languages","stargazers_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/stargazers","contributors_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/contributors","subscribers_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/subscribers","subscription_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/subscription","commits_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/commits{/sha}","git_commits_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/git/commits{/sha}","comments_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/comments{/number}","issue_comment_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/issues/comments{/number}","contents_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/contents/{+path}","compare_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/merges","archive_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/downloads","issues_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/issues{/number}","pulls_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/pulls{/number}","milestones_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/milestones{/number}","notifications_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/labels{/name}","releases_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/releases{/id}","deployments_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/deployments","created_at":"2017-02-06T22:08:59Z","updated_at":"2017-02-06T22:14:25Z","pushed_at":"2017-02-10T17:57:40Z","git_url":"git://github.com/Robbie-Smith/kickstarter_clone.git","ssh_url":"[email protected]:Robbie-Smith/kickstarter_clone.git","clone_url":"https://github.com/Robbie-Smith/kickstarter_clone.git","svn_url":"https://github.com/Robbie-Smith/kickstarter_clone","homepage":null,"size":4869,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":1,"default_branch":"master"}},"base":{"label":"Robbie-Smith:master","ref":"master","sha":"c43c64c4ed45948e58b38d5f880240ddab90ec24","user":{"login":"Robbie-Smith","id":15495167,"avatar_url":"https://avatars.githubusercontent.com/u/15495167?v=3","gravatar_id":"","url":"https://api.github.com/users/Robbie-Smith","html_url":"https://github.com/Robbie-Smith","followers_url":"https://api.github.com/users/Robbie-Smith/followers","following_url":"https://api.github.com/users/Robbie-Smith/following{/other_user}","gists_url":"https://api.github.com/users/Robbie-Smith/gists{/gist_id}","starred_url":"https://api.github.com/users/Robbie-Smith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robbie-Smith/subscriptions","organizations_url":"https://api.github.com/users/Robbie-Smith/orgs","repos_url":"https://api.github.com/users/Robbie-Smith/repos","events_url":"https://api.github.com/users/Robbie-Smith/events{/privacy}","received_events_url":"https://api.github.com/users/Robbie-Smith/received_events","type":"User","site_admin":false},"repo":{"id":81138788,"name":"kickstarter_clone","full_name":"Robbie-Smith/kickstarter_clone","owner":{"login":"Robbie-Smith","id":15495167,"avatar_url":"https://avatars.githubusercontent.com/u/15495167?v=3","gravatar_id":"","url":"https://api.github.com/users/Robbie-Smith","html_url":"https://github.com/Robbie-Smith","followers_url":"https://api.github.com/users/Robbie-Smith/followers","following_url":"https://api.github.com/users/Robbie-Smith/following{/other_user}","gists_url":"https://api.github.com/users/Robbie-Smith/gists{/gist_id}","starred_url":"https://api.github.com/users/Robbie-Smith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robbie-Smith/subscriptions","organizations_url":"https://api.github.com/users/Robbie-Smith/orgs","repos_url":"https://api.github.com/users/Robbie-Smith/repos","events_url":"https://api.github.com/users/Robbie-Smith/events{/privacy}","received_events_url":"https://api.github.com/users/Robbie-Smith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Robbie-Smith/kickstarter_clone","description":null,"fork":false,"url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone","forks_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/forks","keys_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/teams","hooks_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/hooks","issue_events_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/issues/events{/number}","events_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/events","assignees_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/assignees{/user}","branches_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/branches{/branch}","tags_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/tags","blobs_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/git/refs{/sha}","trees_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/statuses/{sha}","languages_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/languages","stargazers_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/stargazers","contributors_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/contributors","subscribers_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/subscribers","subscription_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/subscription","commits_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/commits{/sha}","git_commits_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/git/commits{/sha}","comments_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/comments{/number}","issue_comment_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/issues/comments{/number}","contents_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/contents/{+path}","compare_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/merges","archive_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/downloads","issues_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/issues{/number}","pulls_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/pulls{/number}","milestones_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/milestones{/number}","notifications_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/labels{/name}","releases_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/releases{/id}","deployments_url":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/deployments","created_at":"2017-02-06T22:08:59Z","updated_at":"2017-02-06T22:14:25Z","pushed_at":"2017-02-10T17:57:40Z","git_url":"git://github.com/Robbie-Smith/kickstarter_clone.git","ssh_url":"[email protected]:Robbie-Smith/kickstarter_clone.git","clone_url":"https://github.com/Robbie-Smith/kickstarter_clone.git","svn_url":"https://github.com/Robbie-Smith/kickstarter_clone","homepage":null,"size":4869,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/pulls/59"},"html":{"href":"https://github.com/Robbie-Smith/kickstarter_clone/pull/59"},"issue":{"href":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/issues/59"},"comments":{"href":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/Robbie-Smith/kickstarter_clone/statuses/953f115c37dce46db0d762c8bbcd1e57120e09dc"}}}} | {
"id": 81138788,
"name": "Robbie-Smith/kickstarter_clone",
"url": "https://api.github.com/repos/Robbie-Smith/kickstarter_clone"
} | {
"id": 19585280,
"login": "Dpalazzari",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19585280?",
"url": "https://api.github.com/users/Dpalazzari"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-02-10T18:00:44 | 5304312046 | {"actor":{"display_login":"Dpalazzari"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/qgrid/ng/pulls/comments/121626015","pull_request_review_id":43664588,"id":121626015,"diff_hunk":"@@ -0,0 +1 @@\n+export declare function merge(settings): any;","path":"src/core/services/merge.d.ts","position":1,"original_position":1,"commit_id":"7bf316da05af966cd724710aa35f019ae32eddd2","original_commit_id":"7bf316da05af966cd724710aa35f019ae32eddd2","user":{"login":"klumba12","id":6254382,"avatar_url":"https://avatars3.githubusercontent.com/u/6254382?v=3","gravatar_id":"","url":"https://api.github.com/users/klumba12","html_url":"https://github.com/klumba12","followers_url":"https://api.github.com/users/klumba12/followers","following_url":"https://api.github.com/users/klumba12/following{/other_user}","gists_url":"https://api.github.com/users/klumba12/gists{/gist_id}","starred_url":"https://api.github.com/users/klumba12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klumba12/subscriptions","organizations_url":"https://api.github.com/users/klumba12/orgs","repos_url":"https://api.github.com/users/klumba12/repos","events_url":"https://api.github.com/users/klumba12/events{/privacy}","received_events_url":"https://api.github.com/users/klumba12/received_events","type":"User","site_admin":false},"body":"make definition for settings too can be done in the same file","created_at":"2017-06-13T09:23:02Z","updated_at":"2017-06-13T09:25:53Z","html_url":"https://github.com/qgrid/ng/pull/283#discussion_r121626015","pull_request_url":"https://api.github.com/repos/qgrid/ng/pulls/283","_links":{"self":{"href":"https://api.github.com/repos/qgrid/ng/pulls/comments/121626015"},"html":{"href":"https://github.com/qgrid/ng/pull/283#discussion_r121626015"},"pull_request":{"href":"https://api.github.com/repos/qgrid/ng/pulls/283"}}},"pull_request":{"url":"https://api.github.com/repos/qgrid/ng/pulls/283","id":124610502,"html_url":"https://github.com/qgrid/ng/pull/283","diff_url":"https://github.com/qgrid/ng/pull/283.diff","patch_url":"https://github.com/qgrid/ng/pull/283.patch","issue_url":"https://api.github.com/repos/qgrid/ng/issues/283","number":283,"state":"open","locked":false,"title":"implemented d.ts for actions","user":{"login":"munkk","id":13670003,"avatar_url":"https://avatars3.githubusercontent.com/u/13670003?v=3","gravatar_id":"","url":"https://api.github.com/users/munkk","html_url":"https://github.com/munkk","followers_url":"https://api.github.com/users/munkk/followers","following_url":"https://api.github.com/users/munkk/following{/other_user}","gists_url":"https://api.github.com/users/munkk/gists{/gist_id}","starred_url":"https://api.github.com/users/munkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munkk/subscriptions","organizations_url":"https://api.github.com/users/munkk/orgs","repos_url":"https://api.github.com/users/munkk/repos","events_url":"https://api.github.com/users/munkk/events{/privacy}","received_events_url":"https://api.github.com/users/munkk/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-08T09:53:46Z","updated_at":"2017-06-13T09:25:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47edd137ff4b0655430d47c77ea70532c3b60701","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/qgrid/ng/pulls/283/commits","review_comments_url":"https://api.github.com/repos/qgrid/ng/pulls/283/comments","review_comment_url":"https://api.github.com/repos/qgrid/ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgrid/ng/issues/283/comments","statuses_url":"https://api.github.com/repos/qgrid/ng/statuses/7bf316da05af966cd724710aa35f019ae32eddd2","head":{"label":"munkk:ts-declarations","ref":"ts-declarations","sha":"7bf316da05af966cd724710aa35f019ae32eddd2","user":{"login":"munkk","id":13670003,"avatar_url":"https://avatars3.githubusercontent.com/u/13670003?v=3","gravatar_id":"","url":"https://api.github.com/users/munkk","html_url":"https://github.com/munkk","followers_url":"https://api.github.com/users/munkk/followers","following_url":"https://api.github.com/users/munkk/following{/other_user}","gists_url":"https://api.github.com/users/munkk/gists{/gist_id}","starred_url":"https://api.github.com/users/munkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munkk/subscriptions","organizations_url":"https://api.github.com/users/munkk/orgs","repos_url":"https://api.github.com/users/munkk/repos","events_url":"https://api.github.com/users/munkk/events{/privacy}","received_events_url":"https://api.github.com/users/munkk/received_events","type":"User","site_admin":false},"repo":{"id":93733936,"name":"ng","full_name":"munkk/ng","owner":{"login":"munkk","id":13670003,"avatar_url":"https://avatars3.githubusercontent.com/u/13670003?v=3","gravatar_id":"","url":"https://api.github.com/users/munkk","html_url":"https://github.com/munkk","followers_url":"https://api.github.com/users/munkk/followers","following_url":"https://api.github.com/users/munkk/following{/other_user}","gists_url":"https://api.github.com/users/munkk/gists{/gist_id}","starred_url":"https://api.github.com/users/munkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munkk/subscriptions","organizations_url":"https://api.github.com/users/munkk/orgs","repos_url":"https://api.github.com/users/munkk/repos","events_url":"https://api.github.com/users/munkk/events{/privacy}","received_events_url":"https://api.github.com/users/munkk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/munkk/ng","description":"Angular grid","fork":true,"url":"https://api.github.com/repos/munkk/ng","forks_url":"https://api.github.com/repos/munkk/ng/forks","keys_url":"https://api.github.com/repos/munkk/ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/munkk/ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/munkk/ng/teams","hooks_url":"https://api.github.com/repos/munkk/ng/hooks","issue_events_url":"https://api.github.com/repos/munkk/ng/issues/events{/number}","events_url":"https://api.github.com/repos/munkk/ng/events","assignees_url":"https://api.github.com/repos/munkk/ng/assignees{/user}","branches_url":"https://api.github.com/repos/munkk/ng/branches{/branch}","tags_url":"https://api.github.com/repos/munkk/ng/tags","blobs_url":"https://api.github.com/repos/munkk/ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/munkk/ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/munkk/ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/munkk/ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/munkk/ng/statuses/{sha}","languages_url":"https://api.github.com/repos/munkk/ng/languages","stargazers_url":"https://api.github.com/repos/munkk/ng/stargazers","contributors_url":"https://api.github.com/repos/munkk/ng/contributors","subscribers_url":"https://api.github.com/repos/munkk/ng/subscribers","subscription_url":"https://api.github.com/repos/munkk/ng/subscription","commits_url":"https://api.github.com/repos/munkk/ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/munkk/ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/munkk/ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/munkk/ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/munkk/ng/contents/{+path}","compare_url":"https://api.github.com/repos/munkk/ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/munkk/ng/merges","archive_url":"https://api.github.com/repos/munkk/ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/munkk/ng/downloads","issues_url":"https://api.github.com/repos/munkk/ng/issues{/number}","pulls_url":"https://api.github.com/repos/munkk/ng/pulls{/number}","milestones_url":"https://api.github.com/repos/munkk/ng/milestones{/number}","notifications_url":"https://api.github.com/repos/munkk/ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/munkk/ng/labels{/name}","releases_url":"https://api.github.com/repos/munkk/ng/releases{/id}","deployments_url":"https://api.github.com/repos/munkk/ng/deployments","created_at":"2017-06-08T09:52:02Z","updated_at":"2017-06-08T09:52:04Z","pushed_at":"2017-06-09T15:10:33Z","git_url":"git://github.com/munkk/ng.git","ssh_url":"[email protected]:munkk/ng.git","clone_url":"https://github.com/munkk/ng.git","svn_url":"https://github.com/munkk/ng","homepage":null,"size":25513,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qgrid:master","ref":"master","sha":"5e87ca20aac6e7088f5d1842f533497d9ce0777b","user":{"login":"qgrid","id":25244882,"avatar_url":"https://avatars3.githubusercontent.com/u/25244882?v=3","gravatar_id":"","url":"https://api.github.com/users/qgrid","html_url":"https://github.com/qgrid","followers_url":"https://api.github.com/users/qgrid/followers","following_url":"https://api.github.com/users/qgrid/following{/other_user}","gists_url":"https://api.github.com/users/qgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/qgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgrid/subscriptions","organizations_url":"https://api.github.com/users/qgrid/orgs","repos_url":"https://api.github.com/users/qgrid/repos","events_url":"https://api.github.com/users/qgrid/events{/privacy}","received_events_url":"https://api.github.com/users/qgrid/received_events","type":"User","site_admin":false},"repo":{"id":77054728,"name":"ng","full_name":"qgrid/ng","owner":{"login":"qgrid","id":25244882,"avatar_url":"https://avatars3.githubusercontent.com/u/25244882?v=3","gravatar_id":"","url":"https://api.github.com/users/qgrid","html_url":"https://github.com/qgrid","followers_url":"https://api.github.com/users/qgrid/followers","following_url":"https://api.github.com/users/qgrid/following{/other_user}","gists_url":"https://api.github.com/users/qgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/qgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgrid/subscriptions","organizations_url":"https://api.github.com/users/qgrid/orgs","repos_url":"https://api.github.com/users/qgrid/repos","events_url":"https://api.github.com/users/qgrid/events{/privacy}","received_events_url":"https://api.github.com/users/qgrid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qgrid/ng","description":"Angular grid","fork":false,"url":"https://api.github.com/repos/qgrid/ng","forks_url":"https://api.github.com/repos/qgrid/ng/forks","keys_url":"https://api.github.com/repos/qgrid/ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgrid/ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgrid/ng/teams","hooks_url":"https://api.github.com/repos/qgrid/ng/hooks","issue_events_url":"https://api.github.com/repos/qgrid/ng/issues/events{/number}","events_url":"https://api.github.com/repos/qgrid/ng/events","assignees_url":"https://api.github.com/repos/qgrid/ng/assignees{/user}","branches_url":"https://api.github.com/repos/qgrid/ng/branches{/branch}","tags_url":"https://api.github.com/repos/qgrid/ng/tags","blobs_url":"https://api.github.com/repos/qgrid/ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgrid/ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgrid/ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgrid/ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgrid/ng/statuses/{sha}","languages_url":"https://api.github.com/repos/qgrid/ng/languages","stargazers_url":"https://api.github.com/repos/qgrid/ng/stargazers","contributors_url":"https://api.github.com/repos/qgrid/ng/contributors","subscribers_url":"https://api.github.com/repos/qgrid/ng/subscribers","subscription_url":"https://api.github.com/repos/qgrid/ng/subscription","commits_url":"https://api.github.com/repos/qgrid/ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgrid/ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgrid/ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgrid/ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgrid/ng/contents/{+path}","compare_url":"https://api.github.com/repos/qgrid/ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgrid/ng/merges","archive_url":"https://api.github.com/repos/qgrid/ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgrid/ng/downloads","issues_url":"https://api.github.com/repos/qgrid/ng/issues{/number}","pulls_url":"https://api.github.com/repos/qgrid/ng/pulls{/number}","milestones_url":"https://api.github.com/repos/qgrid/ng/milestones{/number}","notifications_url":"https://api.github.com/repos/qgrid/ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgrid/ng/labels{/name}","releases_url":"https://api.github.com/repos/qgrid/ng/releases{/id}","deployments_url":"https://api.github.com/repos/qgrid/ng/deployments","created_at":"2016-12-21T13:39:53Z","updated_at":"2017-05-22T09:51:05Z","pushed_at":"2017-06-09T17:36:45Z","git_url":"git://github.com/qgrid/ng.git","ssh_url":"[email protected]:qgrid/ng.git","clone_url":"https://github.com/qgrid/ng.git","svn_url":"https://github.com/qgrid/ng","homepage":null,"size":25521,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgrid/ng/pulls/283"},"html":{"href":"https://github.com/qgrid/ng/pull/283"},"issue":{"href":"https://api.github.com/repos/qgrid/ng/issues/283"},"comments":{"href":"https://api.github.com/repos/qgrid/ng/issues/283/comments"},"review_comments":{"href":"https://api.github.com/repos/qgrid/ng/pulls/283/comments"},"review_comment":{"href":"https://api.github.com/repos/qgrid/ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgrid/ng/pulls/283/commits"},"statuses":{"href":"https://api.github.com/repos/qgrid/ng/statuses/7bf316da05af966cd724710aa35f019ae32eddd2"}}}} | {
"id": 77054728,
"name": "qgrid/ng",
"url": "https://api.github.com/repos/qgrid/ng"
} | {
"id": 6254382,
"login": "klumba12",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6254382?",
"url": "https://api.github.com/users/klumba12"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-06-13T09:23:02 | 6053823436 | {"actor":{"display_login":"klumba12"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/badoet/meltingpot/pulls/comments/115162327","pull_request_review_id":36681454,"id":115162327,"diff_hunk":"@@ -1,26 +1,126 @@\n .git-repo-areas {\n- margin: auto;\n+ margin: auto;\n }\n \n .git-repo {\n- .repo-name {\n- font-size: 1.2rem;\n- }\n- .link-out {\n- position: relative;\n- padding: 0.3rem 0.8rem;\n- display: inline-block;\n- vertical-align: top;\n- height: 1rem;\n- &:before {\n- position: absolute;\n- content: \"\";\n- border-right: 0.5rem solid $red;\n- border-bottom: 0.5rem solid transparent;\n- width: 0.5rem;\n- height: 0.5rem;\n- display: inline-block;\n- vertical-align: top;\n+ border-bottom: 1px solid #dbdbdb;\n+ margin-bottom: 2rem;\n+ color: #565555;\n+\n+ .repo {\n+ &__name {\n+ font-size: 1.3rem;\n+ font-weight: bold;\n+ margin-bottom: 1rem;\n+\n+ a {\n+ text-decoration: none;\n+ color: #0980e8;\n+ }\n+\n+ span {\n+ font-size: 0.5rem;\n+ cursor: pointer;\n+ }\n+\n+ }\n+\n+ &__notifications {\n+ margin: 0 0 1.325rem 0;\n+ padding: 0 0 0 15px;\n+\n+ .close {\n+ position: absolute;\n+ margin: 3px 0 0 -15px;\n+ color: #DB5A51;\n+ font-size: 0.75rem;\n+ cursor: pointer;\n+ }\n+\n+ li {\n+ padding: 0;\n+ margin: 0;\n+ list-style: none;\n+\n+ .type {\n+ width: 100%;\n+ display: inline-block;\n+ color: #DB5A51;\n+ font-size: 0.525rem;\n+ }\n+\n+ .title {\n+ width: 100%;\n+ display: inline-block;\n+ font-size: 0.75rem;\n+ }\n+\n+ }\n+\n+ }\n+\n+ &__description {\n+ font-size: 1rem;\n+ margin-bottom: 1rem;\n+ }\n+\n+ &__info {\n+ font-size: 0.8rem;\n+ margin-bottom: 1rem;\n+\n+ &--spacer {","path":"scss/_git_repo.scss","position":90,"original_position":90,"commit_id":"2bf31414ec3edaf9cfdf1faca7d68a9f8e905c6b","original_commit_id":"2bf31414ec3edaf9cfdf1faca7d68a9f8e905c6b","user":{"login":"badoet","id":527102,"avatar_url":"https://avatars3.githubusercontent.com/u/527102?v=3","gravatar_id":"","url":"https://api.github.com/users/badoet","html_url":"https://github.com/badoet","followers_url":"https://api.github.com/users/badoet/followers","following_url":"https://api.github.com/users/badoet/following{/other_user}","gists_url":"https://api.github.com/users/badoet/gists{/gist_id}","starred_url":"https://api.github.com/users/badoet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badoet/subscriptions","organizations_url":"https://api.github.com/users/badoet/orgs","repos_url":"https://api.github.com/users/badoet/repos","events_url":"https://api.github.com/users/badoet/events{/privacy}","received_events_url":"https://api.github.com/users/badoet/received_events","type":"User","site_admin":false},"body":"interesting naming convention for the css classes.\r\nbut i want to know why there are some prefixed with `__` and the other `--`?","created_at":"2017-05-08T01:45:55Z","updated_at":"2017-05-08T01:49:08Z","html_url":"https://github.com/badoet/meltingpot/pull/7#discussion_r115162327","pull_request_url":"https://api.github.com/repos/badoet/meltingpot/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/badoet/meltingpot/pulls/comments/115162327"},"html":{"href":"https://github.com/badoet/meltingpot/pull/7#discussion_r115162327"},"pull_request":{"href":"https://api.github.com/repos/badoet/meltingpot/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/badoet/meltingpot/pulls/7","id":119283919,"html_url":"https://github.com/badoet/meltingpot/pull/7","diff_url":"https://github.com/badoet/meltingpot/pull/7.diff","patch_url":"https://github.com/badoet/meltingpot/pull/7.patch","issue_url":"https://api.github.com/repos/badoet/meltingpot/issues/7","number":7,"state":"open","locked":false,"title":"Exercise","user":{"login":"iamquirkee","id":5411332,"avatar_url":"https://avatars2.githubusercontent.com/u/5411332?v=3","gravatar_id":"","url":"https://api.github.com/users/iamquirkee","html_url":"https://github.com/iamquirkee","followers_url":"https://api.github.com/users/iamquirkee/followers","following_url":"https://api.github.com/users/iamquirkee/following{/other_user}","gists_url":"https://api.github.com/users/iamquirkee/gists{/gist_id}","starred_url":"https://api.github.com/users/iamquirkee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamquirkee/subscriptions","organizations_url":"https://api.github.com/users/iamquirkee/orgs","repos_url":"https://api.github.com/users/iamquirkee/repos","events_url":"https://api.github.com/users/iamquirkee/events{/privacy}","received_events_url":"https://api.github.com/users/iamquirkee/received_events","type":"User","site_admin":false},"body":"Submitted exercise","created_at":"2017-05-06T02:30:23Z","updated_at":"2017-05-08T01:49:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ab180bd4fa746eebd9813ae0ecd36ba4cff8ddd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/badoet/meltingpot/pulls/7/commits","review_comments_url":"https://api.github.com/repos/badoet/meltingpot/pulls/7/comments","review_comment_url":"https://api.github.com/repos/badoet/meltingpot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/badoet/meltingpot/issues/7/comments","statuses_url":"https://api.github.com/repos/badoet/meltingpot/statuses/2bf31414ec3edaf9cfdf1faca7d68a9f8e905c6b","head":{"label":"iamquirkee:master","ref":"master","sha":"2bf31414ec3edaf9cfdf1faca7d68a9f8e905c6b","user":{"login":"iamquirkee","id":5411332,"avatar_url":"https://avatars2.githubusercontent.com/u/5411332?v=3","gravatar_id":"","url":"https://api.github.com/users/iamquirkee","html_url":"https://github.com/iamquirkee","followers_url":"https://api.github.com/users/iamquirkee/followers","following_url":"https://api.github.com/users/iamquirkee/following{/other_user}","gists_url":"https://api.github.com/users/iamquirkee/gists{/gist_id}","starred_url":"https://api.github.com/users/iamquirkee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamquirkee/subscriptions","organizations_url":"https://api.github.com/users/iamquirkee/orgs","repos_url":"https://api.github.com/users/iamquirkee/repos","events_url":"https://api.github.com/users/iamquirkee/events{/privacy}","received_events_url":"https://api.github.com/users/iamquirkee/received_events","type":"User","site_admin":false},"repo":{"id":90394346,"name":"meltingpot","full_name":"iamquirkee/meltingpot","owner":{"login":"iamquirkee","id":5411332,"avatar_url":"https://avatars2.githubusercontent.com/u/5411332?v=3","gravatar_id":"","url":"https://api.github.com/users/iamquirkee","html_url":"https://github.com/iamquirkee","followers_url":"https://api.github.com/users/iamquirkee/followers","following_url":"https://api.github.com/users/iamquirkee/following{/other_user}","gists_url":"https://api.github.com/users/iamquirkee/gists{/gist_id}","starred_url":"https://api.github.com/users/iamquirkee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamquirkee/subscriptions","organizations_url":"https://api.github.com/users/iamquirkee/orgs","repos_url":"https://api.github.com/users/iamquirkee/repos","events_url":"https://api.github.com/users/iamquirkee/events{/privacy}","received_events_url":"https://api.github.com/users/iamquirkee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iamquirkee/meltingpot","description":"Testing around Github API","fork":true,"url":"https://api.github.com/repos/iamquirkee/meltingpot","forks_url":"https://api.github.com/repos/iamquirkee/meltingpot/forks","keys_url":"https://api.github.com/repos/iamquirkee/meltingpot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iamquirkee/meltingpot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iamquirkee/meltingpot/teams","hooks_url":"https://api.github.com/repos/iamquirkee/meltingpot/hooks","issue_events_url":"https://api.github.com/repos/iamquirkee/meltingpot/issues/events{/number}","events_url":"https://api.github.com/repos/iamquirkee/meltingpot/events","assignees_url":"https://api.github.com/repos/iamquirkee/meltingpot/assignees{/user}","branches_url":"https://api.github.com/repos/iamquirkee/meltingpot/branches{/branch}","tags_url":"https://api.github.com/repos/iamquirkee/meltingpot/tags","blobs_url":"https://api.github.com/repos/iamquirkee/meltingpot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iamquirkee/meltingpot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iamquirkee/meltingpot/git/refs{/sha}","trees_url":"https://api.github.com/repos/iamquirkee/meltingpot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iamquirkee/meltingpot/statuses/{sha}","languages_url":"https://api.github.com/repos/iamquirkee/meltingpot/languages","stargazers_url":"https://api.github.com/repos/iamquirkee/meltingpot/stargazers","contributors_url":"https://api.github.com/repos/iamquirkee/meltingpot/contributors","subscribers_url":"https://api.github.com/repos/iamquirkee/meltingpot/subscribers","subscription_url":"https://api.github.com/repos/iamquirkee/meltingpot/subscription","commits_url":"https://api.github.com/repos/iamquirkee/meltingpot/commits{/sha}","git_commits_url":"https://api.github.com/repos/iamquirkee/meltingpot/git/commits{/sha}","comments_url":"https://api.github.com/repos/iamquirkee/meltingpot/comments{/number}","issue_comment_url":"https://api.github.com/repos/iamquirkee/meltingpot/issues/comments{/number}","contents_url":"https://api.github.com/repos/iamquirkee/meltingpot/contents/{+path}","compare_url":"https://api.github.com/repos/iamquirkee/meltingpot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iamquirkee/meltingpot/merges","archive_url":"https://api.github.com/repos/iamquirkee/meltingpot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iamquirkee/meltingpot/downloads","issues_url":"https://api.github.com/repos/iamquirkee/meltingpot/issues{/number}","pulls_url":"https://api.github.com/repos/iamquirkee/meltingpot/pulls{/number}","milestones_url":"https://api.github.com/repos/iamquirkee/meltingpot/milestones{/number}","notifications_url":"https://api.github.com/repos/iamquirkee/meltingpot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iamquirkee/meltingpot/labels{/name}","releases_url":"https://api.github.com/repos/iamquirkee/meltingpot/releases{/id}","deployments_url":"https://api.github.com/repos/iamquirkee/meltingpot/deployments","created_at":"2017-05-05T16:10:03Z","updated_at":"2017-05-05T17:43:24Z","pushed_at":"2017-05-06T02:27:44Z","git_url":"git://github.com/iamquirkee/meltingpot.git","ssh_url":"[email protected]:iamquirkee/meltingpot.git","clone_url":"https://github.com/iamquirkee/meltingpot.git","svn_url":"https://github.com/iamquirkee/meltingpot","homepage":"","size":75,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"badoet:master","ref":"master","sha":"31daa823541e3539e065f720cb4945f2fbb81cb1","user":{"login":"badoet","id":527102,"avatar_url":"https://avatars3.githubusercontent.com/u/527102?v=3","gravatar_id":"","url":"https://api.github.com/users/badoet","html_url":"https://github.com/badoet","followers_url":"https://api.github.com/users/badoet/followers","following_url":"https://api.github.com/users/badoet/following{/other_user}","gists_url":"https://api.github.com/users/badoet/gists{/gist_id}","starred_url":"https://api.github.com/users/badoet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badoet/subscriptions","organizations_url":"https://api.github.com/users/badoet/orgs","repos_url":"https://api.github.com/users/badoet/repos","events_url":"https://api.github.com/users/badoet/events{/privacy}","received_events_url":"https://api.github.com/users/badoet/received_events","type":"User","site_admin":false},"repo":{"id":64070233,"name":"meltingpot","full_name":"badoet/meltingpot","owner":{"login":"badoet","id":527102,"avatar_url":"https://avatars3.githubusercontent.com/u/527102?v=3","gravatar_id":"","url":"https://api.github.com/users/badoet","html_url":"https://github.com/badoet","followers_url":"https://api.github.com/users/badoet/followers","following_url":"https://api.github.com/users/badoet/following{/other_user}","gists_url":"https://api.github.com/users/badoet/gists{/gist_id}","starred_url":"https://api.github.com/users/badoet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badoet/subscriptions","organizations_url":"https://api.github.com/users/badoet/orgs","repos_url":"https://api.github.com/users/badoet/repos","events_url":"https://api.github.com/users/badoet/events{/privacy}","received_events_url":"https://api.github.com/users/badoet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/badoet/meltingpot","description":"Testing around Github API","fork":false,"url":"https://api.github.com/repos/badoet/meltingpot","forks_url":"https://api.github.com/repos/badoet/meltingpot/forks","keys_url":"https://api.github.com/repos/badoet/meltingpot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/badoet/meltingpot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/badoet/meltingpot/teams","hooks_url":"https://api.github.com/repos/badoet/meltingpot/hooks","issue_events_url":"https://api.github.com/repos/badoet/meltingpot/issues/events{/number}","events_url":"https://api.github.com/repos/badoet/meltingpot/events","assignees_url":"https://api.github.com/repos/badoet/meltingpot/assignees{/user}","branches_url":"https://api.github.com/repos/badoet/meltingpot/branches{/branch}","tags_url":"https://api.github.com/repos/badoet/meltingpot/tags","blobs_url":"https://api.github.com/repos/badoet/meltingpot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/badoet/meltingpot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/badoet/meltingpot/git/refs{/sha}","trees_url":"https://api.github.com/repos/badoet/meltingpot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/badoet/meltingpot/statuses/{sha}","languages_url":"https://api.github.com/repos/badoet/meltingpot/languages","stargazers_url":"https://api.github.com/repos/badoet/meltingpot/stargazers","contributors_url":"https://api.github.com/repos/badoet/meltingpot/contributors","subscribers_url":"https://api.github.com/repos/badoet/meltingpot/subscribers","subscription_url":"https://api.github.com/repos/badoet/meltingpot/subscription","commits_url":"https://api.github.com/repos/badoet/meltingpot/commits{/sha}","git_commits_url":"https://api.github.com/repos/badoet/meltingpot/git/commits{/sha}","comments_url":"https://api.github.com/repos/badoet/meltingpot/comments{/number}","issue_comment_url":"https://api.github.com/repos/badoet/meltingpot/issues/comments{/number}","contents_url":"https://api.github.com/repos/badoet/meltingpot/contents/{+path}","compare_url":"https://api.github.com/repos/badoet/meltingpot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/badoet/meltingpot/merges","archive_url":"https://api.github.com/repos/badoet/meltingpot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/badoet/meltingpot/downloads","issues_url":"https://api.github.com/repos/badoet/meltingpot/issues{/number}","pulls_url":"https://api.github.com/repos/badoet/meltingpot/pulls{/number}","milestones_url":"https://api.github.com/repos/badoet/meltingpot/milestones{/number}","notifications_url":"https://api.github.com/repos/badoet/meltingpot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/badoet/meltingpot/labels{/name}","releases_url":"https://api.github.com/repos/badoet/meltingpot/releases{/id}","deployments_url":"https://api.github.com/repos/badoet/meltingpot/deployments","created_at":"2016-07-24T14:49:18Z","updated_at":"2017-03-30T15:17:24Z","pushed_at":"2017-05-06T02:30:24Z","git_url":"git://github.com/badoet/meltingpot.git","ssh_url":"[email protected]:badoet/meltingpot.git","clone_url":"https://github.com/badoet/meltingpot.git","svn_url":"https://github.com/badoet/meltingpot","homepage":"","size":68,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":2,"forks":10,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/badoet/meltingpot/pulls/7"},"html":{"href":"https://github.com/badoet/meltingpot/pull/7"},"issue":{"href":"https://api.github.com/repos/badoet/meltingpot/issues/7"},"comments":{"href":"https://api.github.com/repos/badoet/meltingpot/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/badoet/meltingpot/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/badoet/meltingpot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/badoet/meltingpot/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/badoet/meltingpot/statuses/2bf31414ec3edaf9cfdf1faca7d68a9f8e905c6b"}}}} | {
"id": 64070233,
"name": "badoet/meltingpot",
"url": "https://api.github.com/repos/badoet/meltingpot"
} | {
"id": 527102,
"login": "badoet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/527102?",
"url": "https://api.github.com/users/badoet"
} | {
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2017-05-08T01:45:55 | 5825961839 | {"actor":{"display_login":"badoet"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/18F/methods/pulls/comments/100371202","pull_request_review_id":21077623,"id":100371202,"diff_hunk":"@@ -6,27 +6,31 @@ redirect_from: /task-flow-analysis/\n \n ## What it is\n \n-A step-by-step analysis of a common task a user must perform that diagrams the various touch points and decision points a user goes through to accomplish the task. The touch points should be represented as steps taken by the user, as well as steps taken by the system.\n+A step-by-step analysis of how a user will interact with a system in order to reach a goal. This analysis is documented in a diagram that traces a user's possible paths through sequences of tasks and decision points in pursuit of their goal. The tasks and decision points should represent steps taken by the user, as well as steps taken by the system.\n \n ## Reasons to use it\n \n-To illustrate in a solution-agnostic way the overall flow that a user progresses through to accomplish a single task. Task flow analysis also demonstrates the relationship between tasks, and how they interconnect across a site.\n+To validate a design team's understanding of users' goals, common scenarios, and tasks, and to illustrate in a solution-agnostic way the overall flow of tasks through which a user progresses to accomplish a goal. Task flow diagrams also help surface obstacles in the way of users achieving their goal. \n+\n+## Prerequisites\n+\n+**User research.** Task flow analysis requires that you have a baseline understanding of your users' knowledge, goals, and behaviors. \n \n ## Time required\n \n-**Medium:** 1-2 hours per task\n+**Medium:** 2-3 hours per user goal\n \n ## How to do it\n \n-1. Identify the task(s) that need to be analyzed.\n+1. Based on user research, identify target users' goals that need to be analyzed.\n \n-2. Break each high-level task down into the subtasks and decisions that the user or system must perform. Specify the subtask in terms of objectives. Across all subtasks, you should cover the whole area of interest. Don’t make assumptions about which steps are understood.\n+2. For each goal, identify common scenarios and the tasks and decisions that the user or system will perform in each scenario. Don’t make assumptions about which steps are understood.","path":"_pages/decide/task-flow-analysis.md","position":27,"original_position":27,"commit_id":"88f65b46d2d06ef6ecb4381825de455fe471656d","original_commit_id":"f34f5be703ecba5af18f4f7daec57a6b9e51e053","user":{"login":"MelissaBraxton","id":20651166,"avatar_url":"https://avatars.githubusercontent.com/u/20651166?v=3","gravatar_id":"","url":"https://api.github.com/users/MelissaBraxton","html_url":"https://github.com/MelissaBraxton","followers_url":"https://api.github.com/users/MelissaBraxton/followers","following_url":"https://api.github.com/users/MelissaBraxton/following{/other_user}","gists_url":"https://api.github.com/users/MelissaBraxton/gists{/gist_id}","starred_url":"https://api.github.com/users/MelissaBraxton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MelissaBraxton/subscriptions","organizations_url":"https://api.github.com/users/MelissaBraxton/orgs","repos_url":"https://api.github.com/users/MelissaBraxton/repos","events_url":"https://api.github.com/users/MelissaBraxton/events{/privacy}","received_events_url":"https://api.github.com/users/MelissaBraxton/received_events","type":"User","site_admin":false},"body":"Good catch. I think the initial intent may have been to discourage the design team from just including tasks in the flow without breaking them down into component sub tasks, or asking users exactly what the tasks entail. We could either delete the sentence, or change it to something like this, but shorter: \"Avoid assuming you and your stakeholders share a common understanding of the tasks. The idea with task flow diagrams is to make the flow of tasks explicit and then use the diagrams to check your understanding with users and subject matter experts.\" ","created_at":"2017-02-09T18:07:12Z","updated_at":"2017-02-09T18:07:12Z","html_url":"https://github.com/18F/methods/pull/175#discussion_r100371202","pull_request_url":"https://api.github.com/repos/18F/methods/pulls/175","_links":{"self":{"href":"https://api.github.com/repos/18F/methods/pulls/comments/100371202"},"html":{"href":"https://github.com/18F/methods/pull/175#discussion_r100371202"},"pull_request":{"href":"https://api.github.com/repos/18F/methods/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/18F/methods/pulls/175","id":105336291,"html_url":"https://github.com/18F/methods/pull/175","diff_url":"https://github.com/18F/methods/pull/175.diff","patch_url":"https://github.com/18F/methods/pull/175.patch","issue_url":"https://api.github.com/repos/18F/methods/issues/175","number":175,"state":"open","locked":false,"title":"Task flow analysis edits","user":{"login":"MelissaBraxton","id":20651166,"avatar_url":"https://avatars.githubusercontent.com/u/20651166?v=3","gravatar_id":"","url":"https://api.github.com/users/MelissaBraxton","html_url":"https://github.com/MelissaBraxton","followers_url":"https://api.github.com/users/MelissaBraxton/followers","following_url":"https://api.github.com/users/MelissaBraxton/following{/other_user}","gists_url":"https://api.github.com/users/MelissaBraxton/gists{/gist_id}","starred_url":"https://api.github.com/users/MelissaBraxton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MelissaBraxton/subscriptions","organizations_url":"https://api.github.com/users/MelissaBraxton/orgs","repos_url":"https://api.github.com/users/MelissaBraxton/repos","events_url":"https://api.github.com/users/MelissaBraxton/events{/privacy}","received_events_url":"https://api.github.com/users/MelissaBraxton/received_events","type":"User","site_admin":false},"body":"Here is a first take. Trying to thread the needle by not referring to use cases (although, wondering if that use case ever come up as a card folks want? It is a bit engineery, and I know some designers are biased against the term, but as I see it, it is really the highest tier in the three part hierarchy of use case, user scenario, and task)...","created_at":"2017-02-09T00:26:04Z","updated_at":"2017-02-09T18:07:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"097fd1ca6c0d2cbf6b2c08a67d0b21e51d0094dc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/methods/pulls/175/commits","review_comments_url":"https://api.github.com/repos/18F/methods/pulls/175/comments","review_comment_url":"https://api.github.com/repos/18F/methods/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/methods/issues/175/comments","statuses_url":"https://api.github.com/repos/18F/methods/statuses/88f65b46d2d06ef6ecb4381825de455fe471656d","head":{"label":"18F:Task-flow-analysis-edits","ref":"Task-flow-analysis-edits","sha":"88f65b46d2d06ef6ecb4381825de455fe471656d","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":34354859,"name":"methods","full_name":"18F/methods","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/methods","description":"The design methods practiced at 18F. This repository includes general descriptions of our methods, how-tos, as well as information for applying these methods on government projects.","fork":false,"url":"https://api.github.com/repos/18F/methods","forks_url":"https://api.github.com/repos/18F/methods/forks","keys_url":"https://api.github.com/repos/18F/methods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/methods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/methods/teams","hooks_url":"https://api.github.com/repos/18F/methods/hooks","issue_events_url":"https://api.github.com/repos/18F/methods/issues/events{/number}","events_url":"https://api.github.com/repos/18F/methods/events","assignees_url":"https://api.github.com/repos/18F/methods/assignees{/user}","branches_url":"https://api.github.com/repos/18F/methods/branches{/branch}","tags_url":"https://api.github.com/repos/18F/methods/tags","blobs_url":"https://api.github.com/repos/18F/methods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/methods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/methods/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/methods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/methods/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/methods/languages","stargazers_url":"https://api.github.com/repos/18F/methods/stargazers","contributors_url":"https://api.github.com/repos/18F/methods/contributors","subscribers_url":"https://api.github.com/repos/18F/methods/subscribers","subscription_url":"https://api.github.com/repos/18F/methods/subscription","commits_url":"https://api.github.com/repos/18F/methods/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/methods/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/methods/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/methods/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/methods/contents/{+path}","compare_url":"https://api.github.com/repos/18F/methods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/methods/merges","archive_url":"https://api.github.com/repos/18F/methods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/methods/downloads","issues_url":"https://api.github.com/repos/18F/methods/issues{/number}","pulls_url":"https://api.github.com/repos/18F/methods/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/methods/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/methods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/methods/labels{/name}","releases_url":"https://api.github.com/repos/18F/methods/releases{/id}","deployments_url":"https://api.github.com/repos/18F/methods/deployments","created_at":"2015-04-21T22:12:13Z","updated_at":"2017-01-22T02:34:16Z","pushed_at":"2017-02-09T18:06:51Z","git_url":"git://github.com/18F/methods.git","ssh_url":"[email protected]:18F/methods.git","clone_url":"https://github.com/18F/methods.git","svn_url":"https://github.com/18F/methods","homepage":"https://methods.18f.gov/","size":22281,"stargazers_count":64,"watchers_count":64,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":9,"forks":11,"open_issues":9,"watchers":64,"default_branch":"staging"}},"base":{"label":"18F:staging","ref":"staging","sha":"74971d112ce3f74ae2bda2024bb4dcbea33990a9","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":34354859,"name":"methods","full_name":"18F/methods","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/methods","description":"The design methods practiced at 18F. This repository includes general descriptions of our methods, how-tos, as well as information for applying these methods on government projects.","fork":false,"url":"https://api.github.com/repos/18F/methods","forks_url":"https://api.github.com/repos/18F/methods/forks","keys_url":"https://api.github.com/repos/18F/methods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/methods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/methods/teams","hooks_url":"https://api.github.com/repos/18F/methods/hooks","issue_events_url":"https://api.github.com/repos/18F/methods/issues/events{/number}","events_url":"https://api.github.com/repos/18F/methods/events","assignees_url":"https://api.github.com/repos/18F/methods/assignees{/user}","branches_url":"https://api.github.com/repos/18F/methods/branches{/branch}","tags_url":"https://api.github.com/repos/18F/methods/tags","blobs_url":"https://api.github.com/repos/18F/methods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/methods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/methods/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/methods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/methods/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/methods/languages","stargazers_url":"https://api.github.com/repos/18F/methods/stargazers","contributors_url":"https://api.github.com/repos/18F/methods/contributors","subscribers_url":"https://api.github.com/repos/18F/methods/subscribers","subscription_url":"https://api.github.com/repos/18F/methods/subscription","commits_url":"https://api.github.com/repos/18F/methods/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/methods/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/methods/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/methods/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/methods/contents/{+path}","compare_url":"https://api.github.com/repos/18F/methods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/methods/merges","archive_url":"https://api.github.com/repos/18F/methods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/methods/downloads","issues_url":"https://api.github.com/repos/18F/methods/issues{/number}","pulls_url":"https://api.github.com/repos/18F/methods/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/methods/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/methods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/methods/labels{/name}","releases_url":"https://api.github.com/repos/18F/methods/releases{/id}","deployments_url":"https://api.github.com/repos/18F/methods/deployments","created_at":"2015-04-21T22:12:13Z","updated_at":"2017-01-22T02:34:16Z","pushed_at":"2017-02-09T18:06:51Z","git_url":"git://github.com/18F/methods.git","ssh_url":"[email protected]:18F/methods.git","clone_url":"https://github.com/18F/methods.git","svn_url":"https://github.com/18F/methods","homepage":"https://methods.18f.gov/","size":22281,"stargazers_count":64,"watchers_count":64,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":9,"forks":11,"open_issues":9,"watchers":64,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/methods/pulls/175"},"html":{"href":"https://github.com/18F/methods/pull/175"},"issue":{"href":"https://api.github.com/repos/18F/methods/issues/175"},"comments":{"href":"https://api.github.com/repos/18F/methods/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/methods/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/methods/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/methods/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/18F/methods/statuses/88f65b46d2d06ef6ecb4381825de455fe471656d"}}}} | {
"id": 34354859,
"name": "18F/methods",
"url": "https://api.github.com/repos/18F/methods"
} | {
"id": 20651166,
"login": "MelissaBraxton",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20651166?",
"url": "https://api.github.com/users/MelissaBraxton"
} | {
"id": 6233994,
"login": "18F",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6233994?",
"url": "https://api.github.com/orgs/18F"
} | 2017-02-09T18:07:12 | 5297254772 | {"actor":{"display_login":"MelissaBraxton"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/18F/identity-idp/pulls/comments/102773230","pull_request_review_id":23540615,"id":102773230,"diff_hunk":"@@ -30,6 +30,14 @@ class Application < Rails::Application\n allow do\n origins '*'\n resource '/.well-known/openid-configuration', headers: :any, methods: [:get]\n+ resource '/api/openid_connect/certs', headers: :any, methods: [:get]\n+ resource '/api/openid_connect/token',\n+ credentials: true,\n+ headers: :any,\n+ methods: [:post, :options]\n+ resource '/api/openid_connect/userinfo', headers: :any, methods: [:get]\n+\n+ # legacy URLs\n resource '/openid_connect/certs', headers: :any, methods: [:get]\n resource '/openid_connect/token',","path":"config/application.rb","position":13,"original_position":13,"commit_id":"3c499de55f1672f3b08e3e2015a79b5f3dcab289","original_commit_id":"3c499de55f1672f3b08e3e2015a79b5f3dcab289","user":{"login":"monfresh","id":811150,"avatar_url":"https://avatars.githubusercontent.com/u/811150?v=3","gravatar_id":"","url":"https://api.github.com/users/monfresh","html_url":"https://github.com/monfresh","followers_url":"https://api.github.com/users/monfresh/followers","following_url":"https://api.github.com/users/monfresh/following{/other_user}","gists_url":"https://api.github.com/users/monfresh/gists{/gist_id}","starred_url":"https://api.github.com/users/monfresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monfresh/subscriptions","organizations_url":"https://api.github.com/users/monfresh/orgs","repos_url":"https://api.github.com/users/monfresh/repos","events_url":"https://api.github.com/users/monfresh/events{/privacy}","received_events_url":"https://api.github.com/users/monfresh/received_events","type":"User","site_admin":false},"body":"Should these endpoints without the `api` prefix be removed?","created_at":"2017-02-23T17:45:57Z","updated_at":"2017-02-23T17:45:57Z","html_url":"https://github.com/18F/identity-idp/pull/1139#discussion_r102773230","pull_request_url":"https://api.github.com/repos/18F/identity-idp/pulls/1139","_links":{"self":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/comments/102773230"},"html":{"href":"https://github.com/18F/identity-idp/pull/1139#discussion_r102773230"},"pull_request":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/1139"}}},"pull_request":{"url":"https://api.github.com/repos/18F/identity-idp/pulls/1139","id":107646412,"html_url":"https://github.com/18F/identity-idp/pull/1139","diff_url":"https://github.com/18F/identity-idp/pull/1139.diff","patch_url":"https://github.com/18F/identity-idp/pull/1139.patch","issue_url":"https://api.github.com/repos/18F/identity-idp/issues/1139","number":1139,"state":"open","locked":false,"title":"Rename OpenID Connect API urls to be under /api","user":{"login":"zachmargolis","id":458784,"avatar_url":"https://avatars.githubusercontent.com/u/458784?v=3","gravatar_id":"","url":"https://api.github.com/users/zachmargolis","html_url":"https://github.com/zachmargolis","followers_url":"https://api.github.com/users/zachmargolis/followers","following_url":"https://api.github.com/users/zachmargolis/following{/other_user}","gists_url":"https://api.github.com/users/zachmargolis/gists{/gist_id}","starred_url":"https://api.github.com/users/zachmargolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachmargolis/subscriptions","organizations_url":"https://api.github.com/users/zachmargolis/orgs","repos_url":"https://api.github.com/users/zachmargolis/repos","events_url":"https://api.github.com/users/zachmargolis/events{/privacy}","received_events_url":"https://api.github.com/users/zachmargolis/received_events","type":"User","site_admin":false},"body":"**Why**: For consistency with other API urls, like /api/saml\r\n\r\n---\r\n\r\nThis is a proposal in the form of a PR, that we move the canonical API URLs for OpenID connect under the `/api` namespace.\r\n\r\nClients that use auto-discovery will not have to change, and if we merged this, I would follow up with the developers we know about and ask them to migrate their clients. Then, we could consider removing the old URLs completely.","created_at":"2017-02-23T15:23:01Z","updated_at":"2017-02-23T17:45:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11f03785831649b7165113d916d76ace2fe5932d","assignee":{"login":"zachmargolis","id":458784,"avatar_url":"https://avatars.githubusercontent.com/u/458784?v=3","gravatar_id":"","url":"https://api.github.com/users/zachmargolis","html_url":"https://github.com/zachmargolis","followers_url":"https://api.github.com/users/zachmargolis/followers","following_url":"https://api.github.com/users/zachmargolis/following{/other_user}","gists_url":"https://api.github.com/users/zachmargolis/gists{/gist_id}","starred_url":"https://api.github.com/users/zachmargolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachmargolis/subscriptions","organizations_url":"https://api.github.com/users/zachmargolis/orgs","repos_url":"https://api.github.com/users/zachmargolis/repos","events_url":"https://api.github.com/users/zachmargolis/events{/privacy}","received_events_url":"https://api.github.com/users/zachmargolis/received_events","type":"User","site_admin":false},"assignees":[{"login":"zachmargolis","id":458784,"avatar_url":"https://avatars.githubusercontent.com/u/458784?v=3","gravatar_id":"","url":"https://api.github.com/users/zachmargolis","html_url":"https://github.com/zachmargolis","followers_url":"https://api.github.com/users/zachmargolis/followers","following_url":"https://api.github.com/users/zachmargolis/following{/other_user}","gists_url":"https://api.github.com/users/zachmargolis/gists{/gist_id}","starred_url":"https://api.github.com/users/zachmargolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachmargolis/subscriptions","organizations_url":"https://api.github.com/users/zachmargolis/orgs","repos_url":"https://api.github.com/users/zachmargolis/repos","events_url":"https://api.github.com/users/zachmargolis/events{/privacy}","received_events_url":"https://api.github.com/users/zachmargolis/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/18F/identity-idp/pulls/1139/commits","review_comments_url":"https://api.github.com/repos/18F/identity-idp/pulls/1139/comments","review_comment_url":"https://api.github.com/repos/18F/identity-idp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/identity-idp/issues/1139/comments","statuses_url":"https://api.github.com/repos/18F/identity-idp/statuses/3c499de55f1672f3b08e3e2015a79b5f3dcab289","head":{"label":"18F:margolis-oidc-urls","ref":"margolis-oidc-urls","sha":"3c499de55f1672f3b08e3e2015a79b5f3dcab289","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":50386243,"name":"identity-idp","full_name":"18F/identity-idp","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/identity-idp","description":"18F Identity Provider (IdP)","fork":false,"url":"https://api.github.com/repos/18F/identity-idp","forks_url":"https://api.github.com/repos/18F/identity-idp/forks","keys_url":"https://api.github.com/repos/18F/identity-idp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/identity-idp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/identity-idp/teams","hooks_url":"https://api.github.com/repos/18F/identity-idp/hooks","issue_events_url":"https://api.github.com/repos/18F/identity-idp/issues/events{/number}","events_url":"https://api.github.com/repos/18F/identity-idp/events","assignees_url":"https://api.github.com/repos/18F/identity-idp/assignees{/user}","branches_url":"https://api.github.com/repos/18F/identity-idp/branches{/branch}","tags_url":"https://api.github.com/repos/18F/identity-idp/tags","blobs_url":"https://api.github.com/repos/18F/identity-idp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/identity-idp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/identity-idp/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/identity-idp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/identity-idp/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/identity-idp/languages","stargazers_url":"https://api.github.com/repos/18F/identity-idp/stargazers","contributors_url":"https://api.github.com/repos/18F/identity-idp/contributors","subscribers_url":"https://api.github.com/repos/18F/identity-idp/subscribers","subscription_url":"https://api.github.com/repos/18F/identity-idp/subscription","commits_url":"https://api.github.com/repos/18F/identity-idp/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/identity-idp/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/identity-idp/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/identity-idp/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/identity-idp/contents/{+path}","compare_url":"https://api.github.com/repos/18F/identity-idp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/identity-idp/merges","archive_url":"https://api.github.com/repos/18F/identity-idp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/identity-idp/downloads","issues_url":"https://api.github.com/repos/18F/identity-idp/issues{/number}","pulls_url":"https://api.github.com/repos/18F/identity-idp/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/identity-idp/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/identity-idp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/identity-idp/labels{/name}","releases_url":"https://api.github.com/repos/18F/identity-idp/releases{/id}","deployments_url":"https://api.github.com/repos/18F/identity-idp/deployments","created_at":"2016-01-25T22:40:59Z","updated_at":"2017-02-22T17:54:40Z","pushed_at":"2017-02-23T16:11:27Z","git_url":"git://github.com/18F/identity-idp.git","ssh_url":"[email protected]:18F/identity-idp.git","clone_url":"https://github.com/18F/identity-idp.git","svn_url":"https://github.com/18F/identity-idp","homepage":"https://idp.demo.login.gov/","size":7600,"stargazers_count":30,"watchers_count":30,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":12,"forks":13,"open_issues":12,"watchers":30,"default_branch":"master"}},"base":{"label":"18F:master","ref":"master","sha":"da47fd8966422851dca86bf76db3e1f5c28a0fa8","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":50386243,"name":"identity-idp","full_name":"18F/identity-idp","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/identity-idp","description":"18F Identity Provider (IdP)","fork":false,"url":"https://api.github.com/repos/18F/identity-idp","forks_url":"https://api.github.com/repos/18F/identity-idp/forks","keys_url":"https://api.github.com/repos/18F/identity-idp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/identity-idp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/identity-idp/teams","hooks_url":"https://api.github.com/repos/18F/identity-idp/hooks","issue_events_url":"https://api.github.com/repos/18F/identity-idp/issues/events{/number}","events_url":"https://api.github.com/repos/18F/identity-idp/events","assignees_url":"https://api.github.com/repos/18F/identity-idp/assignees{/user}","branches_url":"https://api.github.com/repos/18F/identity-idp/branches{/branch}","tags_url":"https://api.github.com/repos/18F/identity-idp/tags","blobs_url":"https://api.github.com/repos/18F/identity-idp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/identity-idp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/identity-idp/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/identity-idp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/identity-idp/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/identity-idp/languages","stargazers_url":"https://api.github.com/repos/18F/identity-idp/stargazers","contributors_url":"https://api.github.com/repos/18F/identity-idp/contributors","subscribers_url":"https://api.github.com/repos/18F/identity-idp/subscribers","subscription_url":"https://api.github.com/repos/18F/identity-idp/subscription","commits_url":"https://api.github.com/repos/18F/identity-idp/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/identity-idp/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/identity-idp/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/identity-idp/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/identity-idp/contents/{+path}","compare_url":"https://api.github.com/repos/18F/identity-idp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/identity-idp/merges","archive_url":"https://api.github.com/repos/18F/identity-idp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/identity-idp/downloads","issues_url":"https://api.github.com/repos/18F/identity-idp/issues{/number}","pulls_url":"https://api.github.com/repos/18F/identity-idp/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/identity-idp/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/identity-idp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/identity-idp/labels{/name}","releases_url":"https://api.github.com/repos/18F/identity-idp/releases{/id}","deployments_url":"https://api.github.com/repos/18F/identity-idp/deployments","created_at":"2016-01-25T22:40:59Z","updated_at":"2017-02-22T17:54:40Z","pushed_at":"2017-02-23T16:11:27Z","git_url":"git://github.com/18F/identity-idp.git","ssh_url":"[email protected]:18F/identity-idp.git","clone_url":"https://github.com/18F/identity-idp.git","svn_url":"https://github.com/18F/identity-idp","homepage":"https://idp.demo.login.gov/","size":7600,"stargazers_count":30,"watchers_count":30,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":12,"forks":13,"open_issues":12,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/1139"},"html":{"href":"https://github.com/18F/identity-idp/pull/1139"},"issue":{"href":"https://api.github.com/repos/18F/identity-idp/issues/1139"},"comments":{"href":"https://api.github.com/repos/18F/identity-idp/issues/1139/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/1139/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/identity-idp/pulls/1139/commits"},"statuses":{"href":"https://api.github.com/repos/18F/identity-idp/statuses/3c499de55f1672f3b08e3e2015a79b5f3dcab289"}}}} | {
"id": 50386243,
"name": "18F/identity-idp",
"url": "https://api.github.com/repos/18F/identity-idp"
} | {
"id": 811150,
"login": "monfresh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/811150?",
"url": "https://api.github.com/users/monfresh"
} | {
"id": 6233994,
"login": "18F",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6233994?",
"url": "https://api.github.com/orgs/18F"
} | 2017-02-23T17:45:57 | 5379688123 | {"actor":{"display_login":"monfresh"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/18F/federalist-uswds-template/pulls/comments/157266394","pull_request_review_id":83886456,"id":157266394,"diff_hunk":"@@ -1,3 +1,7 @@\n source \"https://rubygems.org\"\n \n gem 'uswds-jekyll', :git => 'https://github.com/18F/uswds-jekyll.git'\n+\n+group :jekyll_plugins do\n+ gem 'jekyll_pages_api_search'","path":"Gemfile","position":6,"original_position":6,"commit_id":"c29988cafde5da7452a9ef4a838d2cabe152429f","original_commit_id":"c29988cafde5da7452a9ef4a838d2cabe152429f","user":{"login":"line47","id":1449852,"avatar_url":"https://avatars2.githubusercontent.com/u/1449852?v=4","gravatar_id":"","url":"https://api.github.com/users/line47","html_url":"https://github.com/line47","followers_url":"https://api.github.com/users/line47/followers","following_url":"https://api.github.com/users/line47/following{/other_user}","gists_url":"https://api.github.com/users/line47/gists{/gist_id}","starred_url":"https://api.github.com/users/line47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line47/subscriptions","organizations_url":"https://api.github.com/users/line47/orgs","repos_url":"https://api.github.com/users/line47/repos","events_url":"https://api.github.com/users/line47/events{/privacy}","received_events_url":"https://api.github.com/users/line47/received_events","type":"User","site_admin":false},"body":"The `Jekyll_pages_api_search` is part of the USWDS-Jekyll theme and removing the gem from the `gemfile` and `gemfile.lock` throws errors. So maybe we can leave it in for now and remove once we remove `Jekyll_pages_api_search` from USWDS-Jekyll.","created_at":"2017-12-15T18:20:50Z","updated_at":"2017-12-15T18:20:50Z","html_url":"https://github.com/18F/federalist-uswds-template/pull/5#discussion_r157266394","pull_request_url":"https://api.github.com/repos/18F/federalist-uswds-template/pulls/5","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/18F/federalist-uswds-template/pulls/comments/157266394"},"html":{"href":"https://github.com/18F/federalist-uswds-template/pull/5#discussion_r157266394"},"pull_request":{"href":"https://api.github.com/repos/18F/federalist-uswds-template/pulls/5"}},"in_reply_to_id":157264313},"pull_request":{"url":"https://api.github.com/repos/18F/federalist-uswds-template/pulls/5","id":156580194,"html_url":"https://github.com/18F/federalist-uswds-template/pull/5","diff_url":"https://github.com/18F/federalist-uswds-template/pull/5.diff","patch_url":"https://github.com/18F/federalist-uswds-template/pull/5.patch","issue_url":"https://api.github.com/repos/18F/federalist-uswds-template/issues/5","number":5,"state":"open","locked":false,"title":"Update template to the latest version of the USWDS-Jekyll ","user":{"login":"line47","id":1449852,"avatar_url":"https://avatars2.githubusercontent.com/u/1449852?v=4","gravatar_id":"","url":"https://api.github.com/users/line47","html_url":"https://github.com/line47","followers_url":"https://api.github.com/users/line47/followers","following_url":"https://api.github.com/users/line47/following{/other_user}","gists_url":"https://api.github.com/users/line47/gists{/gist_id}","starred_url":"https://api.github.com/users/line47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line47/subscriptions","organizations_url":"https://api.github.com/users/line47/orgs","repos_url":"https://api.github.com/users/line47/repos","events_url":"https://api.github.com/users/line47/events{/privacy}","received_events_url":"https://api.github.com/users/line47/received_events","type":"User","site_admin":false},"body":"Preview: https://federalist-proxy.app.cloud.gov/preview/18f/federalist-uswds-template/update-uswds/docs/\r\n\r\nThis update includes\r\n- [Jekyll pages API search](https://github.com/18F/jekyll_pages_api_search) is now available \r\n- USWDS version 1.3.1\r\n- modification of page layout names to work with `Jekyll new` commands\r\n\r\nMore info here: https://github.com/18F/uswds-jekyll","created_at":"2017-12-05T21:33:54Z","updated_at":"2017-12-15T18:20:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"462066fff8df9322ed4a51cb585dfa9814af02cc","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/federalist-uswds-template/pulls/5/commits","review_comments_url":"https://api.github.com/repos/18F/federalist-uswds-template/pulls/5/comments","review_comment_url":"https://api.github.com/repos/18F/federalist-uswds-template/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/federalist-uswds-template/issues/5/comments","statuses_url":"https://api.github.com/repos/18F/federalist-uswds-template/statuses/c29988cafde5da7452a9ef4a838d2cabe152429f","head":{"label":"18F:update-uswds","ref":"update-uswds","sha":"c29988cafde5da7452a9ef4a838d2cabe152429f","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":84131199,"name":"federalist-uswds-template","full_name":"18F/federalist-uswds-template","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/federalist-uswds-template","description":"A Federalist template that uses the U.S. Web Design Standards Jekyll theme","fork":false,"url":"https://api.github.com/repos/18F/federalist-uswds-template","forks_url":"https://api.github.com/repos/18F/federalist-uswds-template/forks","keys_url":"https://api.github.com/repos/18F/federalist-uswds-template/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/federalist-uswds-template/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/federalist-uswds-template/teams","hooks_url":"https://api.github.com/repos/18F/federalist-uswds-template/hooks","issue_events_url":"https://api.github.com/repos/18F/federalist-uswds-template/issues/events{/number}","events_url":"https://api.github.com/repos/18F/federalist-uswds-template/events","assignees_url":"https://api.github.com/repos/18F/federalist-uswds-template/assignees{/user}","branches_url":"https://api.github.com/repos/18F/federalist-uswds-template/branches{/branch}","tags_url":"https://api.github.com/repos/18F/federalist-uswds-template/tags","blobs_url":"https://api.github.com/repos/18F/federalist-uswds-template/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/federalist-uswds-template/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/federalist-uswds-template/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/federalist-uswds-template/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/federalist-uswds-template/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/federalist-uswds-template/languages","stargazers_url":"https://api.github.com/repos/18F/federalist-uswds-template/stargazers","contributors_url":"https://api.github.com/repos/18F/federalist-uswds-template/contributors","subscribers_url":"https://api.github.com/repos/18F/federalist-uswds-template/subscribers","subscription_url":"https://api.github.com/repos/18F/federalist-uswds-template/subscription","commits_url":"https://api.github.com/repos/18F/federalist-uswds-template/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/federalist-uswds-template/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/federalist-uswds-template/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/federalist-uswds-template/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/federalist-uswds-template/contents/{+path}","compare_url":"https://api.github.com/repos/18F/federalist-uswds-template/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/federalist-uswds-template/merges","archive_url":"https://api.github.com/repos/18F/federalist-uswds-template/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/federalist-uswds-template/downloads","issues_url":"https://api.github.com/repos/18F/federalist-uswds-template/issues{/number}","pulls_url":"https://api.github.com/repos/18F/federalist-uswds-template/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/federalist-uswds-template/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/federalist-uswds-template/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/federalist-uswds-template/labels{/name}","releases_url":"https://api.github.com/repos/18F/federalist-uswds-template/releases{/id}","deployments_url":"https://api.github.com/repos/18F/federalist-uswds-template/deployments","created_at":"2017-03-06T23:21:17Z","updated_at":"2017-11-08T19:06:27Z","pushed_at":"2017-12-15T17:56:13Z","git_url":"git://github.com/18F/federalist-uswds-template.git","ssh_url":"[email protected]:18F/federalist-uswds-template.git","clone_url":"https://github.com/18F/federalist-uswds-template.git","svn_url":"https://github.com/18F/federalist-uswds-template","homepage":"https://federalist-uswds-template.18f.gov/","size":57,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"18F:master","ref":"master","sha":"4c436472cc3af98cb3f4d0b986a1d4c523a20ba9","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":84131199,"name":"federalist-uswds-template","full_name":"18F/federalist-uswds-template","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/federalist-uswds-template","description":"A Federalist template that uses the U.S. Web Design Standards Jekyll theme","fork":false,"url":"https://api.github.com/repos/18F/federalist-uswds-template","forks_url":"https://api.github.com/repos/18F/federalist-uswds-template/forks","keys_url":"https://api.github.com/repos/18F/federalist-uswds-template/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/federalist-uswds-template/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/federalist-uswds-template/teams","hooks_url":"https://api.github.com/repos/18F/federalist-uswds-template/hooks","issue_events_url":"https://api.github.com/repos/18F/federalist-uswds-template/issues/events{/number}","events_url":"https://api.github.com/repos/18F/federalist-uswds-template/events","assignees_url":"https://api.github.com/repos/18F/federalist-uswds-template/assignees{/user}","branches_url":"https://api.github.com/repos/18F/federalist-uswds-template/branches{/branch}","tags_url":"https://api.github.com/repos/18F/federalist-uswds-template/tags","blobs_url":"https://api.github.com/repos/18F/federalist-uswds-template/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/federalist-uswds-template/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/federalist-uswds-template/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/federalist-uswds-template/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/federalist-uswds-template/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/federalist-uswds-template/languages","stargazers_url":"https://api.github.com/repos/18F/federalist-uswds-template/stargazers","contributors_url":"https://api.github.com/repos/18F/federalist-uswds-template/contributors","subscribers_url":"https://api.github.com/repos/18F/federalist-uswds-template/subscribers","subscription_url":"https://api.github.com/repos/18F/federalist-uswds-template/subscription","commits_url":"https://api.github.com/repos/18F/federalist-uswds-template/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/federalist-uswds-template/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/federalist-uswds-template/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/federalist-uswds-template/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/federalist-uswds-template/contents/{+path}","compare_url":"https://api.github.com/repos/18F/federalist-uswds-template/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/federalist-uswds-template/merges","archive_url":"https://api.github.com/repos/18F/federalist-uswds-template/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/federalist-uswds-template/downloads","issues_url":"https://api.github.com/repos/18F/federalist-uswds-template/issues{/number}","pulls_url":"https://api.github.com/repos/18F/federalist-uswds-template/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/federalist-uswds-template/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/federalist-uswds-template/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/federalist-uswds-template/labels{/name}","releases_url":"https://api.github.com/repos/18F/federalist-uswds-template/releases{/id}","deployments_url":"https://api.github.com/repos/18F/federalist-uswds-template/deployments","created_at":"2017-03-06T23:21:17Z","updated_at":"2017-11-08T19:06:27Z","pushed_at":"2017-12-15T17:56:13Z","git_url":"git://github.com/18F/federalist-uswds-template.git","ssh_url":"[email protected]:18F/federalist-uswds-template.git","clone_url":"https://github.com/18F/federalist-uswds-template.git","svn_url":"https://github.com/18F/federalist-uswds-template","homepage":"https://federalist-uswds-template.18f.gov/","size":57,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/federalist-uswds-template/pulls/5"},"html":{"href":"https://github.com/18F/federalist-uswds-template/pull/5"},"issue":{"href":"https://api.github.com/repos/18F/federalist-uswds-template/issues/5"},"comments":{"href":"https://api.github.com/repos/18F/federalist-uswds-template/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/federalist-uswds-template/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/federalist-uswds-template/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/federalist-uswds-template/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/18F/federalist-uswds-template/statuses/c29988cafde5da7452a9ef4a838d2cabe152429f"}},"author_association":"MEMBER"}} | {
"id": 84131199,
"name": "18F/federalist-uswds-template",
"url": "https://api.github.com/repos/18F/federalist-uswds-template"
} | {
"id": 1449852,
"login": "line47",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1449852?",
"url": "https://api.github.com/users/line47"
} | {
"id": 6233994,
"login": "18F",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6233994?",
"url": "https://api.github.com/orgs/18F"
} | 2017-12-15T18:20:50 | 6995220704 | {"actor":{"display_login":"line47"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OCA/vertical-medical/pulls/comments/132596581","pull_request_review_id":55695573,"id":132596581,"diff_hunk":"@@ -0,0 +1,67 @@\n+# -*- coding: utf-8 -*-\n+# Copyright 2016 LasLabs Inc.\n+# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html).\n+\n+from openerp import _, api, fields, models\n+from openerp.exceptions import ValidationError\n+\n+\n+class MedicalPathology(models.Model):\n+ _name = 'medical.pathology'\n+ _description = 'Medical Pathology'\n+\n+ name = fields.Char(\n+ required=True,\n+ translate=True,\n+ )\n+ code = fields.Char(\n+ required=True,\n+ )\n+ code_type_id = fields.Many2one(\n+ string='Code Type',\n+ comodel_name='medical.pathology.code.type',\n+ index=True,\n+ )\n+ notes = fields.Text(\n+ translate=True,\n+ )\n+ category_id = fields.Many2one(\n+ string='Category of Pathology',\n+ comodel_name='medical.pathology.category',\n+ domain=\"[('code_type_id', '=', code_type_id)]\",\n+ index=True,\n+ )\n+ medical_pathology_group_ids = fields.Many2many(\n+ string='Medical Pathology Groups',\n+ comodel_name='medical.pathology.group',\n+ column1='pathology_id',\n+ colmun2='pathology_group_id',\n+ relation=\"pathology_id_pathology_group_id_rel\",\n+ )\n+ child_ids = fields.One2many(\n+ string='Children Pathologies',\n+ comodel_name='medical.pathology',\n+ inverse_name='parent_id',\n+ domain=\"[('code_type_id', '=', code_type_id)]\",\n+ )\n+ parent_id = fields.Many2one(\n+ string='Parent Pathology',\n+ comodel_name='medical.pathology',\n+ domain=\"[('code_type_id', '=', code_type_id)]\",\n+ index=True,\n+ )\n+\n+ _sql_constraints = [\n+ ('code_and_type_uniq',\n+ 'UNIQUE(code, code_type_id)',\n+ 'Pathology codes must be unique per code type.'),\n+ ]\n+\n+ @api.multi\n+ @api.constrains('parent_id')\n+ def _check_parent_id(self):\n+ if not self._check_recursion():\n+ raise ValidationError(_(\n+ 'You cannot create a pathology that is both an ancestor '","path":"medical_pathology/models/medical_pathology.py","position":65,"original_position":65,"commit_id":"3e9b30f929cdbc8c5d994616e3b43d180180ae87","original_commit_id":"3e9b30f929cdbc8c5d994616e3b43d180180ae87","user":{"login":"lasley","id":7397578,"avatar_url":"https://avatars3.githubusercontent.com/u/7397578?v=4","gravatar_id":"","url":"https://api.github.com/users/lasley","html_url":"https://github.com/lasley","followers_url":"https://api.github.com/users/lasley/followers","following_url":"https://api.github.com/users/lasley/following{/other_user}","gists_url":"https://api.github.com/users/lasley/gists{/gist_id}","starred_url":"https://api.github.com/users/lasley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasley/subscriptions","organizations_url":"https://api.github.com/users/lasley/orgs","repos_url":"https://api.github.com/users/lasley/repos","events_url":"https://api.github.com/users/lasley/events{/privacy}","received_events_url":"https://api.github.com/users/lasley/received_events","type":"User","site_admin":false},"body":"Oh I see - we're not actually testing for that. Ok yeah I'd rather just keep the tortoise/hair here instead of a custom implementation. Changing verbiage","created_at":"2017-08-10T23:53:33Z","updated_at":"2017-08-10T23:53:33Z","html_url":"https://github.com/OCA/vertical-medical/pull/190#discussion_r132596581","pull_request_url":"https://api.github.com/repos/OCA/vertical-medical/pulls/190","_links":{"self":{"href":"https://api.github.com/repos/OCA/vertical-medical/pulls/comments/132596581"},"html":{"href":"https://github.com/OCA/vertical-medical/pull/190#discussion_r132596581"},"pull_request":{"href":"https://api.github.com/repos/OCA/vertical-medical/pulls/190"}}},"pull_request":{"url":"https://api.github.com/repos/OCA/vertical-medical/pulls/190","id":134998501,"html_url":"https://github.com/OCA/vertical-medical/pull/190","diff_url":"https://github.com/OCA/vertical-medical/pull/190.diff","patch_url":"https://github.com/OCA/vertical-medical/pull/190.patch","issue_url":"https://api.github.com/repos/OCA/vertical-medical/issues/190","number":190,"state":"open","locked":false,"title":"[MIG] medical_pathology: Upgrade to v10","user":{"login":"lasley","id":7397578,"avatar_url":"https://avatars3.githubusercontent.com/u/7397578?v=4","gravatar_id":"","url":"https://api.github.com/users/lasley","html_url":"https://github.com/lasley","followers_url":"https://api.github.com/users/lasley/followers","following_url":"https://api.github.com/users/lasley/following{/other_user}","gists_url":"https://api.github.com/users/lasley/gists{/gist_id}","starred_url":"https://api.github.com/users/lasley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasley/subscriptions","organizations_url":"https://api.github.com/users/lasley/orgs","repos_url":"https://api.github.com/users/lasley/repos","events_url":"https://api.github.com/users/lasley/events{/privacy}","received_events_url":"https://api.github.com/users/lasley/received_events","type":"User","site_admin":false},"body":"Migrate `medical_pathology` to v10. \r\n\r\nThis also includes the license audit for #183 ","created_at":"2017-08-09T21:50:27Z","updated_at":"2017-08-10T23:53:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb3125d9b5c4b1e5aac3cf5c9914e67008ccff17","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/OCA/vertical-medical/milestones/3","html_url":"https://github.com/OCA/vertical-medical/milestone/3","labels_url":"https://api.github.com/repos/OCA/vertical-medical/milestones/3/labels","id":2052410,"number":3,"title":"10.0","description":null,"creator":{"login":"pedrobaeza","id":7165771,"avatar_url":"https://avatars2.githubusercontent.com/u/7165771?v=4","gravatar_id":"","url":"https://api.github.com/users/pedrobaeza","html_url":"https://github.com/pedrobaeza","followers_url":"https://api.github.com/users/pedrobaeza/followers","following_url":"https://api.github.com/users/pedrobaeza/following{/other_user}","gists_url":"https://api.github.com/users/pedrobaeza/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrobaeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrobaeza/subscriptions","organizations_url":"https://api.github.com/users/pedrobaeza/orgs","repos_url":"https://api.github.com/users/pedrobaeza/repos","events_url":"https://api.github.com/users/pedrobaeza/events{/privacy}","received_events_url":"https://api.github.com/users/pedrobaeza/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":13,"state":"open","created_at":"2016-10-06T14:11:58Z","updated_at":"2017-08-10T23:25:35Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/OCA/vertical-medical/pulls/190/commits","review_comments_url":"https://api.github.com/repos/OCA/vertical-medical/pulls/190/comments","review_comment_url":"https://api.github.com/repos/OCA/vertical-medical/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/vertical-medical/issues/190/comments","statuses_url":"https://api.github.com/repos/OCA/vertical-medical/statuses/3e9b30f929cdbc8c5d994616e3b43d180180ae87","head":{"label":"LasLabs:feature/10.0/oca-medical_pathology","ref":"feature/10.0/oca-medical_pathology","sha":"3e9b30f929cdbc8c5d994616e3b43d180180ae87","user":{"login":"LasLabs","id":13024740,"avatar_url":"https://avatars2.githubusercontent.com/u/13024740?v=4","gravatar_id":"","url":"https://api.github.com/users/LasLabs","html_url":"https://github.com/LasLabs","followers_url":"https://api.github.com/users/LasLabs/followers","following_url":"https://api.github.com/users/LasLabs/following{/other_user}","gists_url":"https://api.github.com/users/LasLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/LasLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LasLabs/subscriptions","organizations_url":"https://api.github.com/users/LasLabs/orgs","repos_url":"https://api.github.com/users/LasLabs/repos","events_url":"https://api.github.com/users/LasLabs/events{/privacy}","received_events_url":"https://api.github.com/users/LasLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":38130117,"name":"vertical-medical","full_name":"LasLabs/vertical-medical","owner":{"login":"LasLabs","id":13024740,"avatar_url":"https://avatars2.githubusercontent.com/u/13024740?v=4","gravatar_id":"","url":"https://api.github.com/users/LasLabs","html_url":"https://github.com/LasLabs","followers_url":"https://api.github.com/users/LasLabs/followers","following_url":"https://api.github.com/users/LasLabs/following{/other_user}","gists_url":"https://api.github.com/users/LasLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/LasLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LasLabs/subscriptions","organizations_url":"https://api.github.com/users/LasLabs/orgs","repos_url":"https://api.github.com/users/LasLabs/repos","events_url":"https://api.github.com/users/LasLabs/events{/privacy}","received_events_url":"https://api.github.com/users/LasLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LasLabs/vertical-medical","description":"Open Source Health care system","fork":true,"url":"https://api.github.com/repos/LasLabs/vertical-medical","forks_url":"https://api.github.com/repos/LasLabs/vertical-medical/forks","keys_url":"https://api.github.com/repos/LasLabs/vertical-medical/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LasLabs/vertical-medical/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LasLabs/vertical-medical/teams","hooks_url":"https://api.github.com/repos/LasLabs/vertical-medical/hooks","issue_events_url":"https://api.github.com/repos/LasLabs/vertical-medical/issues/events{/number}","events_url":"https://api.github.com/repos/LasLabs/vertical-medical/events","assignees_url":"https://api.github.com/repos/LasLabs/vertical-medical/assignees{/user}","branches_url":"https://api.github.com/repos/LasLabs/vertical-medical/branches{/branch}","tags_url":"https://api.github.com/repos/LasLabs/vertical-medical/tags","blobs_url":"https://api.github.com/repos/LasLabs/vertical-medical/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LasLabs/vertical-medical/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LasLabs/vertical-medical/git/refs{/sha}","trees_url":"https://api.github.com/repos/LasLabs/vertical-medical/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LasLabs/vertical-medical/statuses/{sha}","languages_url":"https://api.github.com/repos/LasLabs/vertical-medical/languages","stargazers_url":"https://api.github.com/repos/LasLabs/vertical-medical/stargazers","contributors_url":"https://api.github.com/repos/LasLabs/vertical-medical/contributors","subscribers_url":"https://api.github.com/repos/LasLabs/vertical-medical/subscribers","subscription_url":"https://api.github.com/repos/LasLabs/vertical-medical/subscription","commits_url":"https://api.github.com/repos/LasLabs/vertical-medical/commits{/sha}","git_commits_url":"https://api.github.com/repos/LasLabs/vertical-medical/git/commits{/sha}","comments_url":"https://api.github.com/repos/LasLabs/vertical-medical/comments{/number}","issue_comment_url":"https://api.github.com/repos/LasLabs/vertical-medical/issues/comments{/number}","contents_url":"https://api.github.com/repos/LasLabs/vertical-medical/contents/{+path}","compare_url":"https://api.github.com/repos/LasLabs/vertical-medical/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LasLabs/vertical-medical/merges","archive_url":"https://api.github.com/repos/LasLabs/vertical-medical/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LasLabs/vertical-medical/downloads","issues_url":"https://api.github.com/repos/LasLabs/vertical-medical/issues{/number}","pulls_url":"https://api.github.com/repos/LasLabs/vertical-medical/pulls{/number}","milestones_url":"https://api.github.com/repos/LasLabs/vertical-medical/milestones{/number}","notifications_url":"https://api.github.com/repos/LasLabs/vertical-medical/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LasLabs/vertical-medical/labels{/name}","releases_url":"https://api.github.com/repos/LasLabs/vertical-medical/releases{/id}","deployments_url":"https://api.github.com/repos/LasLabs/vertical-medical/deployments","created_at":"2015-06-26T19:38:41Z","updated_at":"2017-03-03T06:05:56Z","pushed_at":"2017-08-10T23:24:41Z","git_url":"git://github.com/LasLabs/vertical-medical.git","ssh_url":"[email protected]:LasLabs/vertical-medical.git","clone_url":"https://github.com/LasLabs/vertical-medical.git","svn_url":"https://github.com/LasLabs/vertical-medical","homepage":"","size":10304,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":17,"forks":6,"open_issues":17,"watchers":8,"default_branch":"release/10.0"}},"base":{"label":"OCA:10.0","ref":"10.0","sha":"3666c63dcc512e77a08a8574b37c81df65265e39","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":21203152,"name":"vertical-medical","full_name":"OCA/vertical-medical","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/vertical-medical","description":"Open Source Healthcare System for Odoo","fork":false,"url":"https://api.github.com/repos/OCA/vertical-medical","forks_url":"https://api.github.com/repos/OCA/vertical-medical/forks","keys_url":"https://api.github.com/repos/OCA/vertical-medical/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/vertical-medical/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/vertical-medical/teams","hooks_url":"https://api.github.com/repos/OCA/vertical-medical/hooks","issue_events_url":"https://api.github.com/repos/OCA/vertical-medical/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/vertical-medical/events","assignees_url":"https://api.github.com/repos/OCA/vertical-medical/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/vertical-medical/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/vertical-medical/tags","blobs_url":"https://api.github.com/repos/OCA/vertical-medical/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/vertical-medical/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/vertical-medical/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/vertical-medical/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/vertical-medical/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/vertical-medical/languages","stargazers_url":"https://api.github.com/repos/OCA/vertical-medical/stargazers","contributors_url":"https://api.github.com/repos/OCA/vertical-medical/contributors","subscribers_url":"https://api.github.com/repos/OCA/vertical-medical/subscribers","subscription_url":"https://api.github.com/repos/OCA/vertical-medical/subscription","commits_url":"https://api.github.com/repos/OCA/vertical-medical/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/vertical-medical/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/vertical-medical/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/vertical-medical/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/vertical-medical/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/vertical-medical/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/vertical-medical/merges","archive_url":"https://api.github.com/repos/OCA/vertical-medical/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/vertical-medical/downloads","issues_url":"https://api.github.com/repos/OCA/vertical-medical/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/vertical-medical/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/vertical-medical/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/vertical-medical/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/vertical-medical/labels{/name}","releases_url":"https://api.github.com/repos/OCA/vertical-medical/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/vertical-medical/deployments","created_at":"2014-06-25T12:57:22Z","updated_at":"2017-08-10T18:03:20Z","pushed_at":"2017-08-10T23:25:36Z","git_url":"git://github.com/OCA/vertical-medical.git","ssh_url":"[email protected]:OCA/vertical-medical.git","clone_url":"https://github.com/OCA/vertical-medical.git","svn_url":"https://github.com/OCA/vertical-medical","homepage":"","size":7008,"stargazers_count":127,"watchers_count":127,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":170,"mirror_url":null,"open_issues_count":24,"forks":170,"open_issues":24,"watchers":127,"default_branch":"10.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/vertical-medical/pulls/190"},"html":{"href":"https://github.com/OCA/vertical-medical/pull/190"},"issue":{"href":"https://api.github.com/repos/OCA/vertical-medical/issues/190"},"comments":{"href":"https://api.github.com/repos/OCA/vertical-medical/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/vertical-medical/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/vertical-medical/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/vertical-medical/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/vertical-medical/statuses/3e9b30f929cdbc8c5d994616e3b43d180180ae87"}}}} | {
"id": 21203152,
"name": "OCA/vertical-medical",
"url": "https://api.github.com/repos/OCA/vertical-medical"
} | {
"id": 7397578,
"login": "lasley",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7397578?",
"url": "https://api.github.com/users/lasley"
} | {
"id": 7600578,
"login": "OCA",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7600578?",
"url": "https://api.github.com/orgs/OCA"
} | 2017-08-10T23:53:33 | 6437588620 | {"actor":{"display_login":"lasley"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OCA/partner-contact/pulls/comments/154077941","pull_request_review_id":80185379,"id":154077941,"diff_hunk":"@@ -0,0 +1,20 @@\n+# -*- coding: utf-8 -*-\n+# Copyright 2017 Grant Thornton Spain - Ismael Calvo <[email protected]>\n+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).\n+{\n+ \"name\": \"Partner VAT Unique\",\n+ \"version\": \"10.0.1.0.0\",\n+ \"category\": \"Customer Relationship Management\",\n+ \"website\": \"https://odoo-community.org/\",\n+ \"author\": \"Grant Thornton S.L.P, Odoo Community Association (OCA)\",\n+ \"contributors\": [","path":"partner_vat_unique/__manifest__.py","position":10,"original_position":10,"commit_id":"e26a6c058f4a161b89a4f32248e71f48cd2357b9","original_commit_id":"e26a6c058f4a161b89a4f32248e71f48cd2357b9","user":{"login":"Yajo","id":973709,"avatar_url":"https://avatars0.githubusercontent.com/u/973709?v=4","gravatar_id":"","url":"https://api.github.com/users/Yajo","html_url":"https://github.com/Yajo","followers_url":"https://api.github.com/users/Yajo/followers","following_url":"https://api.github.com/users/Yajo/following{/other_user}","gists_url":"https://api.github.com/users/Yajo/gists{/gist_id}","starred_url":"https://api.github.com/users/Yajo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yajo/subscriptions","organizations_url":"https://api.github.com/users/Yajo/orgs","repos_url":"https://api.github.com/users/Yajo/repos","events_url":"https://api.github.com/users/Yajo/events{/privacy}","received_events_url":"https://api.github.com/users/Yajo/received_events","type":"User","site_admin":false},"body":"🔥 delete this key","created_at":"2017-11-30T13:46:51Z","updated_at":"2017-11-30T14:01:23Z","html_url":"https://github.com/OCA/partner-contact/pull/525#discussion_r154077941","pull_request_url":"https://api.github.com/repos/OCA/partner-contact/pulls/525","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OCA/partner-contact/pulls/comments/154077941"},"html":{"href":"https://github.com/OCA/partner-contact/pull/525#discussion_r154077941"},"pull_request":{"href":"https://api.github.com/repos/OCA/partner-contact/pulls/525"}}},"pull_request":{"url":"https://api.github.com/repos/OCA/partner-contact/pulls/525","id":155321701,"html_url":"https://github.com/OCA/partner-contact/pull/525","diff_url":"https://github.com/OCA/partner-contact/pull/525.diff","patch_url":"https://github.com/OCA/partner-contact/pull/525.patch","issue_url":"https://api.github.com/repos/OCA/partner-contact/issues/525","number":525,"state":"open","locked":false,"title":"[ADD] partner_vat_unique, check unique VAT number","user":{"login":"ismaelcj","id":4852443,"avatar_url":"https://avatars2.githubusercontent.com/u/4852443?v=4","gravatar_id":"","url":"https://api.github.com/users/ismaelcj","html_url":"https://github.com/ismaelcj","followers_url":"https://api.github.com/users/ismaelcj/followers","following_url":"https://api.github.com/users/ismaelcj/following{/other_user}","gists_url":"https://api.github.com/users/ismaelcj/gists{/gist_id}","starred_url":"https://api.github.com/users/ismaelcj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ismaelcj/subscriptions","organizations_url":"https://api.github.com/users/ismaelcj/orgs","repos_url":"https://api.github.com/users/ismaelcj/repos","events_url":"https://api.github.com/users/ismaelcj/events{/privacy}","received_events_url":"https://api.github.com/users/ismaelcj/received_events","type":"User","site_admin":false},"body":"Module to avoid duplicate VAT number.","created_at":"2017-11-29T12:02:59Z","updated_at":"2017-11-30T14:01:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ecca94d0ce46ba9775ca00576f15e381ce2f311","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OCA/partner-contact/pulls/525/commits","review_comments_url":"https://api.github.com/repos/OCA/partner-contact/pulls/525/comments","review_comment_url":"https://api.github.com/repos/OCA/partner-contact/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/partner-contact/issues/525/comments","statuses_url":"https://api.github.com/repos/OCA/partner-contact/statuses/e26a6c058f4a161b89a4f32248e71f48cd2357b9","head":{"label":"grant-thornton:10.0-partner_vat_unique","ref":"10.0-partner_vat_unique","sha":"e26a6c058f4a161b89a4f32248e71f48cd2357b9","user":{"login":"grant-thornton","id":28630971,"avatar_url":"https://avatars3.githubusercontent.com/u/28630971?v=4","gravatar_id":"","url":"https://api.github.com/users/grant-thornton","html_url":"https://github.com/grant-thornton","followers_url":"https://api.github.com/users/grant-thornton/followers","following_url":"https://api.github.com/users/grant-thornton/following{/other_user}","gists_url":"https://api.github.com/users/grant-thornton/gists{/gist_id}","starred_url":"https://api.github.com/users/grant-thornton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grant-thornton/subscriptions","organizations_url":"https://api.github.com/users/grant-thornton/orgs","repos_url":"https://api.github.com/users/grant-thornton/repos","events_url":"https://api.github.com/users/grant-thornton/events{/privacy}","received_events_url":"https://api.github.com/users/grant-thornton/received_events","type":"Organization","site_admin":false},"repo":{"id":112191227,"name":"partner-contact","full_name":"grant-thornton/partner-contact","owner":{"login":"grant-thornton","id":28630971,"avatar_url":"https://avatars3.githubusercontent.com/u/28630971?v=4","gravatar_id":"","url":"https://api.github.com/users/grant-thornton","html_url":"https://github.com/grant-thornton","followers_url":"https://api.github.com/users/grant-thornton/followers","following_url":"https://api.github.com/users/grant-thornton/following{/other_user}","gists_url":"https://api.github.com/users/grant-thornton/gists{/gist_id}","starred_url":"https://api.github.com/users/grant-thornton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grant-thornton/subscriptions","organizations_url":"https://api.github.com/users/grant-thornton/orgs","repos_url":"https://api.github.com/users/grant-thornton/repos","events_url":"https://api.github.com/users/grant-thornton/events{/privacy}","received_events_url":"https://api.github.com/users/grant-thornton/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grant-thornton/partner-contact","description":"Odoo Partner and Contact related addons","fork":true,"url":"https://api.github.com/repos/grant-thornton/partner-contact","forks_url":"https://api.github.com/repos/grant-thornton/partner-contact/forks","keys_url":"https://api.github.com/repos/grant-thornton/partner-contact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grant-thornton/partner-contact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grant-thornton/partner-contact/teams","hooks_url":"https://api.github.com/repos/grant-thornton/partner-contact/hooks","issue_events_url":"https://api.github.com/repos/grant-thornton/partner-contact/issues/events{/number}","events_url":"https://api.github.com/repos/grant-thornton/partner-contact/events","assignees_url":"https://api.github.com/repos/grant-thornton/partner-contact/assignees{/user}","branches_url":"https://api.github.com/repos/grant-thornton/partner-contact/branches{/branch}","tags_url":"https://api.github.com/repos/grant-thornton/partner-contact/tags","blobs_url":"https://api.github.com/repos/grant-thornton/partner-contact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grant-thornton/partner-contact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grant-thornton/partner-contact/git/refs{/sha}","trees_url":"https://api.github.com/repos/grant-thornton/partner-contact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grant-thornton/partner-contact/statuses/{sha}","languages_url":"https://api.github.com/repos/grant-thornton/partner-contact/languages","stargazers_url":"https://api.github.com/repos/grant-thornton/partner-contact/stargazers","contributors_url":"https://api.github.com/repos/grant-thornton/partner-contact/contributors","subscribers_url":"https://api.github.com/repos/grant-thornton/partner-contact/subscribers","subscription_url":"https://api.github.com/repos/grant-thornton/partner-contact/subscription","commits_url":"https://api.github.com/repos/grant-thornton/partner-contact/commits{/sha}","git_commits_url":"https://api.github.com/repos/grant-thornton/partner-contact/git/commits{/sha}","comments_url":"https://api.github.com/repos/grant-thornton/partner-contact/comments{/number}","issue_comment_url":"https://api.github.com/repos/grant-thornton/partner-contact/issues/comments{/number}","contents_url":"https://api.github.com/repos/grant-thornton/partner-contact/contents/{+path}","compare_url":"https://api.github.com/repos/grant-thornton/partner-contact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grant-thornton/partner-contact/merges","archive_url":"https://api.github.com/repos/grant-thornton/partner-contact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grant-thornton/partner-contact/downloads","issues_url":"https://api.github.com/repos/grant-thornton/partner-contact/issues{/number}","pulls_url":"https://api.github.com/repos/grant-thornton/partner-contact/pulls{/number}","milestones_url":"https://api.github.com/repos/grant-thornton/partner-contact/milestones{/number}","notifications_url":"https://api.github.com/repos/grant-thornton/partner-contact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grant-thornton/partner-contact/labels{/name}","releases_url":"https://api.github.com/repos/grant-thornton/partner-contact/releases{/id}","deployments_url":"https://api.github.com/repos/grant-thornton/partner-contact/deployments","created_at":"2017-11-27T12:04:03Z","updated_at":"2017-11-27T12:04:05Z","pushed_at":"2017-11-30T11:04:15Z","git_url":"git://github.com/grant-thornton/partner-contact.git","ssh_url":"[email protected]:grant-thornton/partner-contact.git","clone_url":"https://github.com/grant-thornton/partner-contact.git","svn_url":"https://github.com/grant-thornton/partner-contact","homepage":"","size":6484,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"11.0"}},"base":{"label":"OCA:10.0","ref":"10.0","sha":"6bb4a3227f1306d0cbeaf625e17657488a8b4f78","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":20922147,"name":"partner-contact","full_name":"OCA/partner-contact","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/partner-contact","description":"Odoo Partner and Contact related addons","fork":false,"url":"https://api.github.com/repos/OCA/partner-contact","forks_url":"https://api.github.com/repos/OCA/partner-contact/forks","keys_url":"https://api.github.com/repos/OCA/partner-contact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/partner-contact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/partner-contact/teams","hooks_url":"https://api.github.com/repos/OCA/partner-contact/hooks","issue_events_url":"https://api.github.com/repos/OCA/partner-contact/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/partner-contact/events","assignees_url":"https://api.github.com/repos/OCA/partner-contact/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/partner-contact/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/partner-contact/tags","blobs_url":"https://api.github.com/repos/OCA/partner-contact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/partner-contact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/partner-contact/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/partner-contact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/partner-contact/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/partner-contact/languages","stargazers_url":"https://api.github.com/repos/OCA/partner-contact/stargazers","contributors_url":"https://api.github.com/repos/OCA/partner-contact/contributors","subscribers_url":"https://api.github.com/repos/OCA/partner-contact/subscribers","subscription_url":"https://api.github.com/repos/OCA/partner-contact/subscription","commits_url":"https://api.github.com/repos/OCA/partner-contact/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/partner-contact/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/partner-contact/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/partner-contact/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/partner-contact/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/partner-contact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/partner-contact/merges","archive_url":"https://api.github.com/repos/OCA/partner-contact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/partner-contact/downloads","issues_url":"https://api.github.com/repos/OCA/partner-contact/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/partner-contact/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/partner-contact/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/partner-contact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/partner-contact/labels{/name}","releases_url":"https://api.github.com/repos/OCA/partner-contact/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/partner-contact/deployments","created_at":"2014-06-17T12:19:26Z","updated_at":"2017-10-27T15:02:54Z","pushed_at":"2017-11-30T12:55:30Z","git_url":"git://github.com/OCA/partner-contact.git","ssh_url":"[email protected]:OCA/partner-contact.git","clone_url":"https://github.com/OCA/partner-contact.git","svn_url":"https://github.com/OCA/partner-contact","homepage":"","size":7336,"stargazers_count":65,"watchers_count":65,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":281,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":281,"open_issues":85,"watchers":65,"default_branch":"11.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/partner-contact/pulls/525"},"html":{"href":"https://github.com/OCA/partner-contact/pull/525"},"issue":{"href":"https://api.github.com/repos/OCA/partner-contact/issues/525"},"comments":{"href":"https://api.github.com/repos/OCA/partner-contact/issues/525/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/partner-contact/pulls/525/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/partner-contact/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/partner-contact/pulls/525/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/partner-contact/statuses/e26a6c058f4a161b89a4f32248e71f48cd2357b9"}},"author_association":"MEMBER"}} | {
"id": 20922147,
"name": "OCA/partner-contact",
"url": "https://api.github.com/repos/OCA/partner-contact"
} | {
"id": 973709,
"login": "Yajo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/973709?",
"url": "https://api.github.com/users/Yajo"
} | {
"id": 7600578,
"login": "OCA",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7600578?",
"url": "https://api.github.com/orgs/OCA"
} | 2017-11-30T13:46:51 | 6924786737 | {"actor":{"display_login":"Yajo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/PRX/cms.prx.org/pulls/comments/101397706","pull_request_review_id":22125652,"id":101397706,"diff_hunk":"@@ -0,0 +1,58 @@\n+class ITunesCategoryValidator < ActiveModel::Validator\n+ CATEGORIES = {","path":"lib/itunes_category_validator.rb","position":2,"original_position":2,"commit_id":"14fdef7250b144c43d941684862be4b39cabdd36","original_commit_id":"14fdef7250b144c43d941684862be4b39cabdd36","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Freeze mutable objects assigned to constants.","created_at":"2017-02-15T22:18:21Z","updated_at":"2017-02-15T22:18:21Z","html_url":"https://github.com/PRX/cms.prx.org/pull/239#discussion_r101397706","pull_request_url":"https://api.github.com/repos/PRX/cms.prx.org/pulls/239","_links":{"self":{"href":"https://api.github.com/repos/PRX/cms.prx.org/pulls/comments/101397706"},"html":{"href":"https://github.com/PRX/cms.prx.org/pull/239#discussion_r101397706"},"pull_request":{"href":"https://api.github.com/repos/PRX/cms.prx.org/pulls/239"}}},"pull_request":{"url":"https://api.github.com/repos/PRX/cms.prx.org/pulls/239","id":103747114,"html_url":"https://github.com/PRX/cms.prx.org/pull/239","diff_url":"https://github.com/PRX/cms.prx.org/pull/239.diff","patch_url":"https://github.com/PRX/cms.prx.org/pull/239.patch","issue_url":"https://api.github.com/repos/PRX/cms.prx.org/issues/239","number":239,"state":"open","locked":false,"title":"WIP - podcast import","user":{"login":"kookster","id":46439,"avatar_url":"https://avatars.githubusercontent.com/u/46439?v=3","gravatar_id":"","url":"https://api.github.com/users/kookster","html_url":"https://github.com/kookster","followers_url":"https://api.github.com/users/kookster/followers","following_url":"https://api.github.com/users/kookster/following{/other_user}","gists_url":"https://api.github.com/users/kookster/gists{/gist_id}","starred_url":"https://api.github.com/users/kookster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kookster/subscriptions","organizations_url":"https://api.github.com/users/kookster/orgs","repos_url":"https://api.github.com/users/kookster/repos","events_url":"https://api.github.com/users/kookster/events{/privacy}","received_events_url":"https://api.github.com/users/kookster/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-30T14:35:40Z","updated_at":"2017-02-15T22:18:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14ae50f52c0b821db86155a4f5c5c8206cd7d053","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PRX/cms.prx.org/pulls/239/commits","review_comments_url":"https://api.github.com/repos/PRX/cms.prx.org/pulls/239/comments","review_comment_url":"https://api.github.com/repos/PRX/cms.prx.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PRX/cms.prx.org/issues/239/comments","statuses_url":"https://api.github.com/repos/PRX/cms.prx.org/statuses/14fdef7250b144c43d941684862be4b39cabdd36","head":{"label":"PRX:feat/podcast_import","ref":"feat/podcast_import","sha":"14fdef7250b144c43d941684862be4b39cabdd36","user":{"login":"PRX","id":160453,"avatar_url":"https://avatars.githubusercontent.com/u/160453?v=3","gravatar_id":"","url":"https://api.github.com/users/PRX","html_url":"https://github.com/PRX","followers_url":"https://api.github.com/users/PRX/followers","following_url":"https://api.github.com/users/PRX/following{/other_user}","gists_url":"https://api.github.com/users/PRX/gists{/gist_id}","starred_url":"https://api.github.com/users/PRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRX/subscriptions","organizations_url":"https://api.github.com/users/PRX/orgs","repos_url":"https://api.github.com/users/PRX/repos","events_url":"https://api.github.com/users/PRX/events{/privacy}","received_events_url":"https://api.github.com/users/PRX/received_events","type":"Organization","site_admin":false},"repo":{"id":14878369,"name":"cms.prx.org","full_name":"PRX/cms.prx.org","owner":{"login":"PRX","id":160453,"avatar_url":"https://avatars.githubusercontent.com/u/160453?v=3","gravatar_id":"","url":"https://api.github.com/users/PRX","html_url":"https://github.com/PRX","followers_url":"https://api.github.com/users/PRX/followers","following_url":"https://api.github.com/users/PRX/following{/other_user}","gists_url":"https://api.github.com/users/PRX/gists{/gist_id}","starred_url":"https://api.github.com/users/PRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRX/subscriptions","organizations_url":"https://api.github.com/users/PRX/orgs","repos_url":"https://api.github.com/users/PRX/repos","events_url":"https://api.github.com/users/PRX/events{/privacy}","received_events_url":"https://api.github.com/users/PRX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PRX/cms.prx.org","description":"CMS API for PRX (under development)","fork":false,"url":"https://api.github.com/repos/PRX/cms.prx.org","forks_url":"https://api.github.com/repos/PRX/cms.prx.org/forks","keys_url":"https://api.github.com/repos/PRX/cms.prx.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PRX/cms.prx.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PRX/cms.prx.org/teams","hooks_url":"https://api.github.com/repos/PRX/cms.prx.org/hooks","issue_events_url":"https://api.github.com/repos/PRX/cms.prx.org/issues/events{/number}","events_url":"https://api.github.com/repos/PRX/cms.prx.org/events","assignees_url":"https://api.github.com/repos/PRX/cms.prx.org/assignees{/user}","branches_url":"https://api.github.com/repos/PRX/cms.prx.org/branches{/branch}","tags_url":"https://api.github.com/repos/PRX/cms.prx.org/tags","blobs_url":"https://api.github.com/repos/PRX/cms.prx.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PRX/cms.prx.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PRX/cms.prx.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/PRX/cms.prx.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PRX/cms.prx.org/statuses/{sha}","languages_url":"https://api.github.com/repos/PRX/cms.prx.org/languages","stargazers_url":"https://api.github.com/repos/PRX/cms.prx.org/stargazers","contributors_url":"https://api.github.com/repos/PRX/cms.prx.org/contributors","subscribers_url":"https://api.github.com/repos/PRX/cms.prx.org/subscribers","subscription_url":"https://api.github.com/repos/PRX/cms.prx.org/subscription","commits_url":"https://api.github.com/repos/PRX/cms.prx.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/PRX/cms.prx.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/PRX/cms.prx.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/PRX/cms.prx.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/PRX/cms.prx.org/contents/{+path}","compare_url":"https://api.github.com/repos/PRX/cms.prx.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PRX/cms.prx.org/merges","archive_url":"https://api.github.com/repos/PRX/cms.prx.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PRX/cms.prx.org/downloads","issues_url":"https://api.github.com/repos/PRX/cms.prx.org/issues{/number}","pulls_url":"https://api.github.com/repos/PRX/cms.prx.org/pulls{/number}","milestones_url":"https://api.github.com/repos/PRX/cms.prx.org/milestones{/number}","notifications_url":"https://api.github.com/repos/PRX/cms.prx.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PRX/cms.prx.org/labels{/name}","releases_url":"https://api.github.com/repos/PRX/cms.prx.org/releases{/id}","deployments_url":"https://api.github.com/repos/PRX/cms.prx.org/deployments","created_at":"2013-12-02T23:48:10Z","updated_at":"2016-11-01T19:14:27Z","pushed_at":"2017-02-15T22:17:57Z","git_url":"git://github.com/PRX/cms.prx.org.git","ssh_url":"[email protected]:PRX/cms.prx.org.git","clone_url":"https://github.com/PRX/cms.prx.org.git","svn_url":"https://github.com/PRX/cms.prx.org","homepage":"http://www.prx.org","size":1810,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":29,"forks":2,"open_issues":29,"watchers":2,"default_branch":"master"}},"base":{"label":"PRX:master","ref":"master","sha":"64bc8a876f1a04cc450e30cf00d6f1d3ba5db937","user":{"login":"PRX","id":160453,"avatar_url":"https://avatars.githubusercontent.com/u/160453?v=3","gravatar_id":"","url":"https://api.github.com/users/PRX","html_url":"https://github.com/PRX","followers_url":"https://api.github.com/users/PRX/followers","following_url":"https://api.github.com/users/PRX/following{/other_user}","gists_url":"https://api.github.com/users/PRX/gists{/gist_id}","starred_url":"https://api.github.com/users/PRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRX/subscriptions","organizations_url":"https://api.github.com/users/PRX/orgs","repos_url":"https://api.github.com/users/PRX/repos","events_url":"https://api.github.com/users/PRX/events{/privacy}","received_events_url":"https://api.github.com/users/PRX/received_events","type":"Organization","site_admin":false},"repo":{"id":14878369,"name":"cms.prx.org","full_name":"PRX/cms.prx.org","owner":{"login":"PRX","id":160453,"avatar_url":"https://avatars.githubusercontent.com/u/160453?v=3","gravatar_id":"","url":"https://api.github.com/users/PRX","html_url":"https://github.com/PRX","followers_url":"https://api.github.com/users/PRX/followers","following_url":"https://api.github.com/users/PRX/following{/other_user}","gists_url":"https://api.github.com/users/PRX/gists{/gist_id}","starred_url":"https://api.github.com/users/PRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRX/subscriptions","organizations_url":"https://api.github.com/users/PRX/orgs","repos_url":"https://api.github.com/users/PRX/repos","events_url":"https://api.github.com/users/PRX/events{/privacy}","received_events_url":"https://api.github.com/users/PRX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PRX/cms.prx.org","description":"CMS API for PRX (under development)","fork":false,"url":"https://api.github.com/repos/PRX/cms.prx.org","forks_url":"https://api.github.com/repos/PRX/cms.prx.org/forks","keys_url":"https://api.github.com/repos/PRX/cms.prx.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PRX/cms.prx.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PRX/cms.prx.org/teams","hooks_url":"https://api.github.com/repos/PRX/cms.prx.org/hooks","issue_events_url":"https://api.github.com/repos/PRX/cms.prx.org/issues/events{/number}","events_url":"https://api.github.com/repos/PRX/cms.prx.org/events","assignees_url":"https://api.github.com/repos/PRX/cms.prx.org/assignees{/user}","branches_url":"https://api.github.com/repos/PRX/cms.prx.org/branches{/branch}","tags_url":"https://api.github.com/repos/PRX/cms.prx.org/tags","blobs_url":"https://api.github.com/repos/PRX/cms.prx.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PRX/cms.prx.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PRX/cms.prx.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/PRX/cms.prx.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PRX/cms.prx.org/statuses/{sha}","languages_url":"https://api.github.com/repos/PRX/cms.prx.org/languages","stargazers_url":"https://api.github.com/repos/PRX/cms.prx.org/stargazers","contributors_url":"https://api.github.com/repos/PRX/cms.prx.org/contributors","subscribers_url":"https://api.github.com/repos/PRX/cms.prx.org/subscribers","subscription_url":"https://api.github.com/repos/PRX/cms.prx.org/subscription","commits_url":"https://api.github.com/repos/PRX/cms.prx.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/PRX/cms.prx.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/PRX/cms.prx.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/PRX/cms.prx.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/PRX/cms.prx.org/contents/{+path}","compare_url":"https://api.github.com/repos/PRX/cms.prx.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PRX/cms.prx.org/merges","archive_url":"https://api.github.com/repos/PRX/cms.prx.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PRX/cms.prx.org/downloads","issues_url":"https://api.github.com/repos/PRX/cms.prx.org/issues{/number}","pulls_url":"https://api.github.com/repos/PRX/cms.prx.org/pulls{/number}","milestones_url":"https://api.github.com/repos/PRX/cms.prx.org/milestones{/number}","notifications_url":"https://api.github.com/repos/PRX/cms.prx.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PRX/cms.prx.org/labels{/name}","releases_url":"https://api.github.com/repos/PRX/cms.prx.org/releases{/id}","deployments_url":"https://api.github.com/repos/PRX/cms.prx.org/deployments","created_at":"2013-12-02T23:48:10Z","updated_at":"2016-11-01T19:14:27Z","pushed_at":"2017-02-15T22:17:57Z","git_url":"git://github.com/PRX/cms.prx.org.git","ssh_url":"[email protected]:PRX/cms.prx.org.git","clone_url":"https://github.com/PRX/cms.prx.org.git","svn_url":"https://github.com/PRX/cms.prx.org","homepage":"http://www.prx.org","size":1810,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":29,"forks":2,"open_issues":29,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PRX/cms.prx.org/pulls/239"},"html":{"href":"https://github.com/PRX/cms.prx.org/pull/239"},"issue":{"href":"https://api.github.com/repos/PRX/cms.prx.org/issues/239"},"comments":{"href":"https://api.github.com/repos/PRX/cms.prx.org/issues/239/comments"},"review_comments":{"href":"https://api.github.com/repos/PRX/cms.prx.org/pulls/239/comments"},"review_comment":{"href":"https://api.github.com/repos/PRX/cms.prx.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PRX/cms.prx.org/pulls/239/commits"},"statuses":{"href":"https://api.github.com/repos/PRX/cms.prx.org/statuses/14fdef7250b144c43d941684862be4b39cabdd36"}}}} | {
"id": 14878369,
"name": "PRX/cms.prx.org",
"url": "https://api.github.com/repos/PRX/cms.prx.org"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 160453,
"login": "PRX",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/160453?",
"url": "https://api.github.com/orgs/PRX"
} | 2017-02-15T22:18:21 | 5332521906 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/PRX/publish.prx.org/pulls/comments/139999973","pull_request_review_id":64010784,"id":139999973,"diff_hunk":"@@ -100,11 +114,72 @@ export class BasicComponent implements OnDestroy, DoCheck {\n return (this.story && this.story.publishedAt) ? true : false;\n }\n \n+ get undeletedVersions(): AudioVersionModel[] {\n+ if (this.story && this.story.versions) {\n+ return this.story.versions.filter(v => !v.isDestroy);\n+ } else {\n+ return null;\n+ }\n+ }\n+\n+ get versionsChanged(): boolean {\n+ return this.story && this.story.changed('versions', true);\n+ }\n+\n+ get versionsInvalid(): boolean {\n+ return this.story && !!this.story.invalid('versions', this.strict);\n+ }\n+\n+ updateVersions(templateIds: number[]) {\n+ let used = {};\n+ this.story.versions.forEach(v => {\n+ if (v.template) {\n+ used[v.template.id] = true;\n+ if (templateIds.indexOf(v.template.id) > -1) {\n+ v.isDestroy = false;\n+ } else if (v.isNew) {\n+ this.story.removeRelated(v);\n+ } else {\n+ v.isDestroy = true;\n+ }\n+ }\n+ });\n+ templateIds.forEach(id => {\n+ if (!used[id]) {\n+ this.story.versions.push(new AudioVersionModel({\n+ series: this.story.parent,\n+ template: this.versionTemplates[id]\n+ }));\n+ }\n+ });\n+ }\n+\n toggleShowReleaseAt() {\n this.showReleasedAt = !this.showReleasedAt;\n if (this.story.releasedAt) {\n this.story.releasedAt = null;\n }\n }\n \n+ loadVersionTemplates() {\n+ this.story.getSeriesTemplates().subscribe(tdocs => {","path":"src/app/story/directives/basic.component.ts","position":106,"original_position":106,"commit_id":"0873231d4887751a809a94cfea68d26d8af4256f","original_commit_id":"c16b9d879f10e25bb226890b8170b15d5f84b0a9","user":{"login":"cavis","id":1410587,"avatar_url":"https://avatars0.githubusercontent.com/u/1410587?v=4","gravatar_id":"","url":"https://api.github.com/users/cavis","html_url":"https://github.com/cavis","followers_url":"https://api.github.com/users/cavis/followers","following_url":"https://api.github.com/users/cavis/following{/other_user}","gists_url":"https://api.github.com/users/cavis/gists{/gist_id}","starred_url":"https://api.github.com/users/cavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cavis/subscriptions","organizations_url":"https://api.github.com/users/cavis/orgs","repos_url":"https://api.github.com/users/cavis/repos","events_url":"https://api.github.com/users/cavis/events{/privacy}","received_events_url":"https://api.github.com/users/cavis/received_events","type":"User","site_admin":false},"body":"Update: fixed by providing the TabService at the component level, instead of the shared-module.","created_at":"2017-09-20T15:12:36Z","updated_at":"2017-09-20T15:12:36Z","html_url":"https://github.com/PRX/publish.prx.org/pull/456#discussion_r139999973","pull_request_url":"https://api.github.com/repos/PRX/publish.prx.org/pulls/456","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/PRX/publish.prx.org/pulls/comments/139999973"},"html":{"href":"https://github.com/PRX/publish.prx.org/pull/456#discussion_r139999973"},"pull_request":{"href":"https://api.github.com/repos/PRX/publish.prx.org/pulls/456"}},"in_reply_to_id":139838106},"pull_request":{"url":"https://api.github.com/repos/PRX/publish.prx.org/pulls/456","id":139864725,"html_url":"https://github.com/PRX/publish.prx.org/pull/456","diff_url":"https://github.com/PRX/publish.prx.org/pull/456.diff","patch_url":"https://github.com/PRX/publish.prx.org/pull/456.patch","issue_url":"https://api.github.com/repos/PRX/publish.prx.org/issues/456","number":456,"state":"open","locked":false,"title":"Multiple series templates","user":{"login":"cavis","id":1410587,"avatar_url":"https://avatars0.githubusercontent.com/u/1410587?v=4","gravatar_id":"","url":"https://api.github.com/users/cavis","html_url":"https://github.com/cavis","followers_url":"https://api.github.com/users/cavis/followers","following_url":"https://api.github.com/users/cavis/following{/other_user}","gists_url":"https://api.github.com/users/cavis/gists{/gist_id}","starred_url":"https://api.github.com/users/cavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cavis/subscriptions","organizations_url":"https://api.github.com/users/cavis/orgs","repos_url":"https://api.github.com/users/cavis/repos","events_url":"https://api.github.com/users/cavis/events{/privacy}","received_events_url":"https://api.github.com/users/cavis/received_events","type":"User","site_admin":false},"body":"See #448.\r\n\r\n- [x] Allow adding multiple templates to a series (new or existing)\r\n- [x] Allow adding \"video file\" templates to a series\r\n- [x] Don't allow setting duration or multiple-segments for video templates (hardcoded 1-segment, but it only shows up on the story pages)\r\n\r\nAlso made sense to build in #450:\r\n\r\n- [x] Allow uploading other mime types for a video-file-version. (Uses `<input accept=\"video/*\"/>`)\r\n- [x] Don't validate video uploads on the frontend\r\n\r\nAnd #449:\r\n\r\n- [x] Allow selecting multiple templates associated with your Series Podcast Distribution\r\n - Force at least 1 selection\r\n- [x] Allow selecting/unselecting the audio-versions for a story\r\n - Force at least 1 version per story\r\n - NOTE: this makes **no attempt** to enforce picking a version associated with your podcast (selected above on the series page). This is fine for now, since there's only 1 kind of distribution. But later may allow users to shoot themselves in the foot. Which is also fine.\r\n - ALSO NOTE: this doesn't warn users that changing around your story-audio-versions can impact what audio is in your feed. I assume if you changed a story from \"Version w/3 segments\" to \"Version w/4 segments\" ... it's fairly self explanatory of the consequences.\r\n","created_at":"2017-09-07T17:39:58Z","updated_at":"2017-09-20T15:12:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"920d49680728ae7a28cb8fd017a96191aea875f4","assignee":{"login":"cavis","id":1410587,"avatar_url":"https://avatars0.githubusercontent.com/u/1410587?v=4","gravatar_id":"","url":"https://api.github.com/users/cavis","html_url":"https://github.com/cavis","followers_url":"https://api.github.com/users/cavis/followers","following_url":"https://api.github.com/users/cavis/following{/other_user}","gists_url":"https://api.github.com/users/cavis/gists{/gist_id}","starred_url":"https://api.github.com/users/cavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cavis/subscriptions","organizations_url":"https://api.github.com/users/cavis/orgs","repos_url":"https://api.github.com/users/cavis/repos","events_url":"https://api.github.com/users/cavis/events{/privacy}","received_events_url":"https://api.github.com/users/cavis/received_events","type":"User","site_admin":false},"assignees":[{"login":"cavis","id":1410587,"avatar_url":"https://avatars0.githubusercontent.com/u/1410587?v=4","gravatar_id":"","url":"https://api.github.com/users/cavis","html_url":"https://github.com/cavis","followers_url":"https://api.github.com/users/cavis/followers","following_url":"https://api.github.com/users/cavis/following{/other_user}","gists_url":"https://api.github.com/users/cavis/gists{/gist_id}","starred_url":"https://api.github.com/users/cavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cavis/subscriptions","organizations_url":"https://api.github.com/users/cavis/orgs","repos_url":"https://api.github.com/users/cavis/repos","events_url":"https://api.github.com/users/cavis/events{/privacy}","received_events_url":"https://api.github.com/users/cavis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/PRX/publish.prx.org/milestones/3","html_url":"https://github.com/PRX/publish.prx.org/milestone/3","labels_url":"https://api.github.com/repos/PRX/publish.prx.org/milestones/3/labels","id":2746275,"number":3,"title":"Sprint Sam","description":"","creator":{"login":"pkarman","id":1205061,"avatar_url":"https://avatars3.githubusercontent.com/u/1205061?v=4","gravatar_id":"","url":"https://api.github.com/users/pkarman","html_url":"https://github.com/pkarman","followers_url":"https://api.github.com/users/pkarman/followers","following_url":"https://api.github.com/users/pkarman/following{/other_user}","gists_url":"https://api.github.com/users/pkarman/gists{/gist_id}","starred_url":"https://api.github.com/users/pkarman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkarman/subscriptions","organizations_url":"https://api.github.com/users/pkarman/orgs","repos_url":"https://api.github.com/users/pkarman/repos","events_url":"https://api.github.com/users/pkarman/events{/privacy}","received_events_url":"https://api.github.com/users/pkarman/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":2,"state":"open","created_at":"2017-09-05T19:14:19Z","updated_at":"2017-09-19T18:19:23Z","due_on":"2017-09-26T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/PRX/publish.prx.org/pulls/456/commits","review_comments_url":"https://api.github.com/repos/PRX/publish.prx.org/pulls/456/comments","review_comment_url":"https://api.github.com/repos/PRX/publish.prx.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PRX/publish.prx.org/issues/456/comments","statuses_url":"https://api.github.com/repos/PRX/publish.prx.org/statuses/0873231d4887751a809a94cfea68d26d8af4256f","head":{"label":"PRX:feat/multi_templates","ref":"feat/multi_templates","sha":"0873231d4887751a809a94cfea68d26d8af4256f","user":{"login":"PRX","id":160453,"avatar_url":"https://avatars3.githubusercontent.com/u/160453?v=4","gravatar_id":"","url":"https://api.github.com/users/PRX","html_url":"https://github.com/PRX","followers_url":"https://api.github.com/users/PRX/followers","following_url":"https://api.github.com/users/PRX/following{/other_user}","gists_url":"https://api.github.com/users/PRX/gists{/gist_id}","starred_url":"https://api.github.com/users/PRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRX/subscriptions","organizations_url":"https://api.github.com/users/PRX/orgs","repos_url":"https://api.github.com/users/PRX/repos","events_url":"https://api.github.com/users/PRX/events{/privacy}","received_events_url":"https://api.github.com/users/PRX/received_events","type":"Organization","site_admin":false},"repo":{"id":53075022,"name":"publish.prx.org","full_name":"PRX/publish.prx.org","owner":{"login":"PRX","id":160453,"avatar_url":"https://avatars3.githubusercontent.com/u/160453?v=4","gravatar_id":"","url":"https://api.github.com/users/PRX","html_url":"https://github.com/PRX","followers_url":"https://api.github.com/users/PRX/followers","following_url":"https://api.github.com/users/PRX/following{/other_user}","gists_url":"https://api.github.com/users/PRX/gists{/gist_id}","starred_url":"https://api.github.com/users/PRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRX/subscriptions","organizations_url":"https://api.github.com/users/PRX/orgs","repos_url":"https://api.github.com/users/PRX/repos","events_url":"https://api.github.com/users/PRX/events{/privacy}","received_events_url":"https://api.github.com/users/PRX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PRX/publish.prx.org","description":"Publishing app","fork":false,"url":"https://api.github.com/repos/PRX/publish.prx.org","forks_url":"https://api.github.com/repos/PRX/publish.prx.org/forks","keys_url":"https://api.github.com/repos/PRX/publish.prx.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PRX/publish.prx.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PRX/publish.prx.org/teams","hooks_url":"https://api.github.com/repos/PRX/publish.prx.org/hooks","issue_events_url":"https://api.github.com/repos/PRX/publish.prx.org/issues/events{/number}","events_url":"https://api.github.com/repos/PRX/publish.prx.org/events","assignees_url":"https://api.github.com/repos/PRX/publish.prx.org/assignees{/user}","branches_url":"https://api.github.com/repos/PRX/publish.prx.org/branches{/branch}","tags_url":"https://api.github.com/repos/PRX/publish.prx.org/tags","blobs_url":"https://api.github.com/repos/PRX/publish.prx.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PRX/publish.prx.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PRX/publish.prx.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/PRX/publish.prx.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PRX/publish.prx.org/statuses/{sha}","languages_url":"https://api.github.com/repos/PRX/publish.prx.org/languages","stargazers_url":"https://api.github.com/repos/PRX/publish.prx.org/stargazers","contributors_url":"https://api.github.com/repos/PRX/publish.prx.org/contributors","subscribers_url":"https://api.github.com/repos/PRX/publish.prx.org/subscribers","subscription_url":"https://api.github.com/repos/PRX/publish.prx.org/subscription","commits_url":"https://api.github.com/repos/PRX/publish.prx.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/PRX/publish.prx.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/PRX/publish.prx.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/PRX/publish.prx.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/PRX/publish.prx.org/contents/{+path}","compare_url":"https://api.github.com/repos/PRX/publish.prx.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PRX/publish.prx.org/merges","archive_url":"https://api.github.com/repos/PRX/publish.prx.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PRX/publish.prx.org/downloads","issues_url":"https://api.github.com/repos/PRX/publish.prx.org/issues{/number}","pulls_url":"https://api.github.com/repos/PRX/publish.prx.org/pulls{/number}","milestones_url":"https://api.github.com/repos/PRX/publish.prx.org/milestones{/number}","notifications_url":"https://api.github.com/repos/PRX/publish.prx.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PRX/publish.prx.org/labels{/name}","releases_url":"https://api.github.com/repos/PRX/publish.prx.org/releases{/id}","deployments_url":"https://api.github.com/repos/PRX/publish.prx.org/deployments","created_at":"2016-03-03T18:55:16Z","updated_at":"2016-03-31T16:34:56Z","pushed_at":"2017-09-20T15:01:48Z","git_url":"git://github.com/PRX/publish.prx.org.git","ssh_url":"[email protected]:PRX/publish.prx.org.git","clone_url":"https://github.com/PRX/publish.prx.org.git","svn_url":"https://github.com/PRX/publish.prx.org","homepage":null,"size":11014,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":81,"forks":1,"open_issues":81,"watchers":0,"default_branch":"master"}},"base":{"label":"PRX:master","ref":"master","sha":"c1ad491c0e47cb24c15160c9a32a8a1d98b5fd77","user":{"login":"PRX","id":160453,"avatar_url":"https://avatars3.githubusercontent.com/u/160453?v=4","gravatar_id":"","url":"https://api.github.com/users/PRX","html_url":"https://github.com/PRX","followers_url":"https://api.github.com/users/PRX/followers","following_url":"https://api.github.com/users/PRX/following{/other_user}","gists_url":"https://api.github.com/users/PRX/gists{/gist_id}","starred_url":"https://api.github.com/users/PRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRX/subscriptions","organizations_url":"https://api.github.com/users/PRX/orgs","repos_url":"https://api.github.com/users/PRX/repos","events_url":"https://api.github.com/users/PRX/events{/privacy}","received_events_url":"https://api.github.com/users/PRX/received_events","type":"Organization","site_admin":false},"repo":{"id":53075022,"name":"publish.prx.org","full_name":"PRX/publish.prx.org","owner":{"login":"PRX","id":160453,"avatar_url":"https://avatars3.githubusercontent.com/u/160453?v=4","gravatar_id":"","url":"https://api.github.com/users/PRX","html_url":"https://github.com/PRX","followers_url":"https://api.github.com/users/PRX/followers","following_url":"https://api.github.com/users/PRX/following{/other_user}","gists_url":"https://api.github.com/users/PRX/gists{/gist_id}","starred_url":"https://api.github.com/users/PRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRX/subscriptions","organizations_url":"https://api.github.com/users/PRX/orgs","repos_url":"https://api.github.com/users/PRX/repos","events_url":"https://api.github.com/users/PRX/events{/privacy}","received_events_url":"https://api.github.com/users/PRX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PRX/publish.prx.org","description":"Publishing app","fork":false,"url":"https://api.github.com/repos/PRX/publish.prx.org","forks_url":"https://api.github.com/repos/PRX/publish.prx.org/forks","keys_url":"https://api.github.com/repos/PRX/publish.prx.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PRX/publish.prx.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PRX/publish.prx.org/teams","hooks_url":"https://api.github.com/repos/PRX/publish.prx.org/hooks","issue_events_url":"https://api.github.com/repos/PRX/publish.prx.org/issues/events{/number}","events_url":"https://api.github.com/repos/PRX/publish.prx.org/events","assignees_url":"https://api.github.com/repos/PRX/publish.prx.org/assignees{/user}","branches_url":"https://api.github.com/repos/PRX/publish.prx.org/branches{/branch}","tags_url":"https://api.github.com/repos/PRX/publish.prx.org/tags","blobs_url":"https://api.github.com/repos/PRX/publish.prx.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PRX/publish.prx.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PRX/publish.prx.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/PRX/publish.prx.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PRX/publish.prx.org/statuses/{sha}","languages_url":"https://api.github.com/repos/PRX/publish.prx.org/languages","stargazers_url":"https://api.github.com/repos/PRX/publish.prx.org/stargazers","contributors_url":"https://api.github.com/repos/PRX/publish.prx.org/contributors","subscribers_url":"https://api.github.com/repos/PRX/publish.prx.org/subscribers","subscription_url":"https://api.github.com/repos/PRX/publish.prx.org/subscription","commits_url":"https://api.github.com/repos/PRX/publish.prx.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/PRX/publish.prx.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/PRX/publish.prx.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/PRX/publish.prx.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/PRX/publish.prx.org/contents/{+path}","compare_url":"https://api.github.com/repos/PRX/publish.prx.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PRX/publish.prx.org/merges","archive_url":"https://api.github.com/repos/PRX/publish.prx.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PRX/publish.prx.org/downloads","issues_url":"https://api.github.com/repos/PRX/publish.prx.org/issues{/number}","pulls_url":"https://api.github.com/repos/PRX/publish.prx.org/pulls{/number}","milestones_url":"https://api.github.com/repos/PRX/publish.prx.org/milestones{/number}","notifications_url":"https://api.github.com/repos/PRX/publish.prx.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PRX/publish.prx.org/labels{/name}","releases_url":"https://api.github.com/repos/PRX/publish.prx.org/releases{/id}","deployments_url":"https://api.github.com/repos/PRX/publish.prx.org/deployments","created_at":"2016-03-03T18:55:16Z","updated_at":"2016-03-31T16:34:56Z","pushed_at":"2017-09-20T15:01:48Z","git_url":"git://github.com/PRX/publish.prx.org.git","ssh_url":"[email protected]:PRX/publish.prx.org.git","clone_url":"https://github.com/PRX/publish.prx.org.git","svn_url":"https://github.com/PRX/publish.prx.org","homepage":null,"size":11014,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":81,"forks":1,"open_issues":81,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PRX/publish.prx.org/pulls/456"},"html":{"href":"https://github.com/PRX/publish.prx.org/pull/456"},"issue":{"href":"https://api.github.com/repos/PRX/publish.prx.org/issues/456"},"comments":{"href":"https://api.github.com/repos/PRX/publish.prx.org/issues/456/comments"},"review_comments":{"href":"https://api.github.com/repos/PRX/publish.prx.org/pulls/456/comments"},"review_comment":{"href":"https://api.github.com/repos/PRX/publish.prx.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PRX/publish.prx.org/pulls/456/commits"},"statuses":{"href":"https://api.github.com/repos/PRX/publish.prx.org/statuses/0873231d4887751a809a94cfea68d26d8af4256f"}},"author_association":"OWNER"}} | {
"id": 53075022,
"name": "PRX/publish.prx.org",
"url": "https://api.github.com/repos/PRX/publish.prx.org"
} | {
"id": 1410587,
"login": "cavis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1410587?",
"url": "https://api.github.com/users/cavis"
} | {
"id": 160453,
"login": "PRX",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/160453?",
"url": "https://api.github.com/orgs/PRX"
} | 2017-09-20T15:12:36 | 6615066560 | {"actor":{"display_login":"cavis"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/PRX/jingle.prx.org/pulls/comments/158293674","pull_request_review_id":85081117,"id":158293674,"diff_hunk":"@@ -15,17 +15,36 @@ defmodule Jingle.Campaign do\n belongs_to :sponsor, Jingle.Sponsor\n belongs_to :podcast, Jingle.Podcast\n has_many :creatives, Jingle.Creative\n- timestamps()\n+ timestamps(type: :utc_datetime)\n end\n \n @doc \"\"\"\n Builds a changeset based on the `struct` and `params`.\n \"\"\"\n def changeset(struct, params \\\\ %{}) do\n struct\n- |> cast(params, [:sponsor_id, :podcast_id, :start_date, :end_date, :due_date, :original_copy, :edited_copy, :must_say, :notes, :approved, :zone])\n- |> validate_required([:start_date, :end_date, :original_copy, :zone])\n+ |> cast(utc_compatible_dates(params), [:sponsor_id, :podcast_id, :start_date, :end_date, :due_date, :original_copy, :edited_copy, :must_say, :notes, :approved, :zone])\n+ |> validate_required([:start_date, :end_date, :due_date, :original_copy, :zone])\n |> assoc_constraint(:sponsor)\n |> assoc_constraint(:podcast)\n end\n+\n+ defp utc_compatible_dates(params) do\n+ params = atomize_map(params)\n+ date_params = Map.take(params, [:start_date, :end_date, :due_date])\n+ parsed_date_params = for { k, v } <- date_params, into: %{}, do: { k, parse_dtim(v) }","path":"web/models/campaign.ex","position":37,"original_position":37,"commit_id":"460f79681b8000c353825d47a365a2f4d726dda9","original_commit_id":"460f79681b8000c353825d47a365a2f4d726dda9","user":{"login":"gcampo88","id":16007382,"avatar_url":"https://avatars1.githubusercontent.com/u/16007382?v=4","gravatar_id":"","url":"https://api.github.com/users/gcampo88","html_url":"https://github.com/gcampo88","followers_url":"https://api.github.com/users/gcampo88/followers","following_url":"https://api.github.com/users/gcampo88/following{/other_user}","gists_url":"https://api.github.com/users/gcampo88/gists{/gist_id}","starred_url":"https://api.github.com/users/gcampo88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcampo88/subscriptions","organizations_url":"https://api.github.com/users/gcampo88/orgs","repos_url":"https://api.github.com/users/gcampo88/repos","events_url":"https://api.github.com/users/gcampo88/events{/privacy}","received_events_url":"https://api.github.com/users/gcampo88/received_events","type":"User","site_admin":false},"body":"exactly -- if that happens, we want the validation to catch it, not an error here ","created_at":"2017-12-21T14:45:11Z","updated_at":"2017-12-21T14:45:11Z","html_url":"https://github.com/PRX/jingle.prx.org/pull/74#discussion_r158293674","pull_request_url":"https://api.github.com/repos/PRX/jingle.prx.org/pulls/74","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PRX/jingle.prx.org/pulls/comments/158293674"},"html":{"href":"https://github.com/PRX/jingle.prx.org/pull/74#discussion_r158293674"},"pull_request":{"href":"https://api.github.com/repos/PRX/jingle.prx.org/pulls/74"}},"in_reply_to_id":158142879},"pull_request":{"url":"https://api.github.com/repos/PRX/jingle.prx.org/pulls/74","id":158667224,"html_url":"https://github.com/PRX/jingle.prx.org/pull/74","diff_url":"https://github.com/PRX/jingle.prx.org/pull/74.diff","patch_url":"https://github.com/PRX/jingle.prx.org/pull/74.patch","issue_url":"https://api.github.com/repos/PRX/jingle.prx.org/issues/74","number":74,"state":"open","locked":false,"title":"More UTC","user":{"login":"gcampo88","id":16007382,"avatar_url":"https://avatars1.githubusercontent.com/u/16007382?v=4","gravatar_id":"","url":"https://api.github.com/users/gcampo88","html_url":"https://github.com/gcampo88","followers_url":"https://api.github.com/users/gcampo88/followers","following_url":"https://api.github.com/users/gcampo88/following{/other_user}","gists_url":"https://api.github.com/users/gcampo88/gists{/gist_id}","starred_url":"https://api.github.com/users/gcampo88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcampo88/subscriptions","organizations_url":"https://api.github.com/users/gcampo88/orgs","repos_url":"https://api.github.com/users/gcampo88/repos","events_url":"https://api.github.com/users/gcampo88/events{/privacy}","received_events_url":"https://api.github.com/users/gcampo88/received_events","type":"User","site_admin":false},"body":"- updates the timestamps in schema for all models to reflect utc datetime nature\r\n- adds a pre-validation Timex helper to ensure that all date field params in a Campaign are utc-able (ie, have hours and minutes defined on the datetime) before they're cast into a Campaign changeset\r\n- removes docker-compose installation from buildspec ","created_at":"2017-12-15T18:38:10Z","updated_at":"2017-12-21T14:45:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e597918c5b776dc51df5ebe7e889d8fa1f5e8a73","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/PRX/jingle.prx.org/pulls/74/commits","review_comments_url":"https://api.github.com/repos/PRX/jingle.prx.org/pulls/74/comments","review_comment_url":"https://api.github.com/repos/PRX/jingle.prx.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PRX/jingle.prx.org/issues/74/comments","statuses_url":"https://api.github.com/repos/PRX/jingle.prx.org/statuses/460f79681b8000c353825d47a365a2f4d726dda9","head":{"label":"PRX:fix/more-utc","ref":"fix/more-utc","sha":"460f79681b8000c353825d47a365a2f4d726dda9","user":{"login":"PRX","id":160453,"avatar_url":"https://avatars3.githubusercontent.com/u/160453?v=4","gravatar_id":"","url":"https://api.github.com/users/PRX","html_url":"https://github.com/PRX","followers_url":"https://api.github.com/users/PRX/followers","following_url":"https://api.github.com/users/PRX/following{/other_user}","gists_url":"https://api.github.com/users/PRX/gists{/gist_id}","starred_url":"https://api.github.com/users/PRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRX/subscriptions","organizations_url":"https://api.github.com/users/PRX/orgs","repos_url":"https://api.github.com/users/PRX/repos","events_url":"https://api.github.com/users/PRX/events{/privacy}","received_events_url":"https://api.github.com/users/PRX/received_events","type":"Organization","site_admin":false},"repo":{"id":85605691,"name":"jingle.prx.org","full_name":"PRX/jingle.prx.org","owner":{"login":"PRX","id":160453,"avatar_url":"https://avatars3.githubusercontent.com/u/160453?v=4","gravatar_id":"","url":"https://api.github.com/users/PRX","html_url":"https://github.com/PRX","followers_url":"https://api.github.com/users/PRX/followers","following_url":"https://api.github.com/users/PRX/following{/other_user}","gists_url":"https://api.github.com/users/PRX/gists{/gist_id}","starred_url":"https://api.github.com/users/PRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRX/subscriptions","organizations_url":"https://api.github.com/users/PRX/orgs","repos_url":"https://api.github.com/users/PRX/repos","events_url":"https://api.github.com/users/PRX/events{/privacy}","received_events_url":"https://api.github.com/users/PRX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PRX/jingle.prx.org","description":"Phoenix app serving as the backend for TBD ads workflow app","fork":false,"url":"https://api.github.com/repos/PRX/jingle.prx.org","forks_url":"https://api.github.com/repos/PRX/jingle.prx.org/forks","keys_url":"https://api.github.com/repos/PRX/jingle.prx.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PRX/jingle.prx.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PRX/jingle.prx.org/teams","hooks_url":"https://api.github.com/repos/PRX/jingle.prx.org/hooks","issue_events_url":"https://api.github.com/repos/PRX/jingle.prx.org/issues/events{/number}","events_url":"https://api.github.com/repos/PRX/jingle.prx.org/events","assignees_url":"https://api.github.com/repos/PRX/jingle.prx.org/assignees{/user}","branches_url":"https://api.github.com/repos/PRX/jingle.prx.org/branches{/branch}","tags_url":"https://api.github.com/repos/PRX/jingle.prx.org/tags","blobs_url":"https://api.github.com/repos/PRX/jingle.prx.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PRX/jingle.prx.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PRX/jingle.prx.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/PRX/jingle.prx.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PRX/jingle.prx.org/statuses/{sha}","languages_url":"https://api.github.com/repos/PRX/jingle.prx.org/languages","stargazers_url":"https://api.github.com/repos/PRX/jingle.prx.org/stargazers","contributors_url":"https://api.github.com/repos/PRX/jingle.prx.org/contributors","subscribers_url":"https://api.github.com/repos/PRX/jingle.prx.org/subscribers","subscription_url":"https://api.github.com/repos/PRX/jingle.prx.org/subscription","commits_url":"https://api.github.com/repos/PRX/jingle.prx.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/PRX/jingle.prx.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/PRX/jingle.prx.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/PRX/jingle.prx.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/PRX/jingle.prx.org/contents/{+path}","compare_url":"https://api.github.com/repos/PRX/jingle.prx.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PRX/jingle.prx.org/merges","archive_url":"https://api.github.com/repos/PRX/jingle.prx.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PRX/jingle.prx.org/downloads","issues_url":"https://api.github.com/repos/PRX/jingle.prx.org/issues{/number}","pulls_url":"https://api.github.com/repos/PRX/jingle.prx.org/pulls{/number}","milestones_url":"https://api.github.com/repos/PRX/jingle.prx.org/milestones{/number}","notifications_url":"https://api.github.com/repos/PRX/jingle.prx.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PRX/jingle.prx.org/labels{/name}","releases_url":"https://api.github.com/repos/PRX/jingle.prx.org/releases{/id}","deployments_url":"https://api.github.com/repos/PRX/jingle.prx.org/deployments","created_at":"2017-03-20T17:23:24Z","updated_at":"2017-08-31T20:26:03Z","pushed_at":"2017-12-20T20:10:03Z","git_url":"git://github.com/PRX/jingle.prx.org.git","ssh_url":"[email protected]:PRX/jingle.prx.org.git","clone_url":"https://github.com/PRX/jingle.prx.org.git","svn_url":"https://github.com/PRX/jingle.prx.org","homepage":"http://jingle.prx.org","size":181,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":21,"watchers":0,"default_branch":"master"}},"base":{"label":"PRX:master","ref":"master","sha":"7e724de663755f39381384be62794a3c5516a04a","user":{"login":"PRX","id":160453,"avatar_url":"https://avatars3.githubusercontent.com/u/160453?v=4","gravatar_id":"","url":"https://api.github.com/users/PRX","html_url":"https://github.com/PRX","followers_url":"https://api.github.com/users/PRX/followers","following_url":"https://api.github.com/users/PRX/following{/other_user}","gists_url":"https://api.github.com/users/PRX/gists{/gist_id}","starred_url":"https://api.github.com/users/PRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRX/subscriptions","organizations_url":"https://api.github.com/users/PRX/orgs","repos_url":"https://api.github.com/users/PRX/repos","events_url":"https://api.github.com/users/PRX/events{/privacy}","received_events_url":"https://api.github.com/users/PRX/received_events","type":"Organization","site_admin":false},"repo":{"id":85605691,"name":"jingle.prx.org","full_name":"PRX/jingle.prx.org","owner":{"login":"PRX","id":160453,"avatar_url":"https://avatars3.githubusercontent.com/u/160453?v=4","gravatar_id":"","url":"https://api.github.com/users/PRX","html_url":"https://github.com/PRX","followers_url":"https://api.github.com/users/PRX/followers","following_url":"https://api.github.com/users/PRX/following{/other_user}","gists_url":"https://api.github.com/users/PRX/gists{/gist_id}","starred_url":"https://api.github.com/users/PRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRX/subscriptions","organizations_url":"https://api.github.com/users/PRX/orgs","repos_url":"https://api.github.com/users/PRX/repos","events_url":"https://api.github.com/users/PRX/events{/privacy}","received_events_url":"https://api.github.com/users/PRX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PRX/jingle.prx.org","description":"Phoenix app serving as the backend for TBD ads workflow app","fork":false,"url":"https://api.github.com/repos/PRX/jingle.prx.org","forks_url":"https://api.github.com/repos/PRX/jingle.prx.org/forks","keys_url":"https://api.github.com/repos/PRX/jingle.prx.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PRX/jingle.prx.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PRX/jingle.prx.org/teams","hooks_url":"https://api.github.com/repos/PRX/jingle.prx.org/hooks","issue_events_url":"https://api.github.com/repos/PRX/jingle.prx.org/issues/events{/number}","events_url":"https://api.github.com/repos/PRX/jingle.prx.org/events","assignees_url":"https://api.github.com/repos/PRX/jingle.prx.org/assignees{/user}","branches_url":"https://api.github.com/repos/PRX/jingle.prx.org/branches{/branch}","tags_url":"https://api.github.com/repos/PRX/jingle.prx.org/tags","blobs_url":"https://api.github.com/repos/PRX/jingle.prx.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PRX/jingle.prx.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PRX/jingle.prx.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/PRX/jingle.prx.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PRX/jingle.prx.org/statuses/{sha}","languages_url":"https://api.github.com/repos/PRX/jingle.prx.org/languages","stargazers_url":"https://api.github.com/repos/PRX/jingle.prx.org/stargazers","contributors_url":"https://api.github.com/repos/PRX/jingle.prx.org/contributors","subscribers_url":"https://api.github.com/repos/PRX/jingle.prx.org/subscribers","subscription_url":"https://api.github.com/repos/PRX/jingle.prx.org/subscription","commits_url":"https://api.github.com/repos/PRX/jingle.prx.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/PRX/jingle.prx.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/PRX/jingle.prx.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/PRX/jingle.prx.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/PRX/jingle.prx.org/contents/{+path}","compare_url":"https://api.github.com/repos/PRX/jingle.prx.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PRX/jingle.prx.org/merges","archive_url":"https://api.github.com/repos/PRX/jingle.prx.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PRX/jingle.prx.org/downloads","issues_url":"https://api.github.com/repos/PRX/jingle.prx.org/issues{/number}","pulls_url":"https://api.github.com/repos/PRX/jingle.prx.org/pulls{/number}","milestones_url":"https://api.github.com/repos/PRX/jingle.prx.org/milestones{/number}","notifications_url":"https://api.github.com/repos/PRX/jingle.prx.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PRX/jingle.prx.org/labels{/name}","releases_url":"https://api.github.com/repos/PRX/jingle.prx.org/releases{/id}","deployments_url":"https://api.github.com/repos/PRX/jingle.prx.org/deployments","created_at":"2017-03-20T17:23:24Z","updated_at":"2017-08-31T20:26:03Z","pushed_at":"2017-12-20T20:10:03Z","git_url":"git://github.com/PRX/jingle.prx.org.git","ssh_url":"[email protected]:PRX/jingle.prx.org.git","clone_url":"https://github.com/PRX/jingle.prx.org.git","svn_url":"https://github.com/PRX/jingle.prx.org","homepage":"http://jingle.prx.org","size":181,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":21,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PRX/jingle.prx.org/pulls/74"},"html":{"href":"https://github.com/PRX/jingle.prx.org/pull/74"},"issue":{"href":"https://api.github.com/repos/PRX/jingle.prx.org/issues/74"},"comments":{"href":"https://api.github.com/repos/PRX/jingle.prx.org/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/PRX/jingle.prx.org/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/PRX/jingle.prx.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PRX/jingle.prx.org/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/PRX/jingle.prx.org/statuses/460f79681b8000c353825d47a365a2f4d726dda9"}},"author_association":"CONTRIBUTOR"}} | {
"id": 85605691,
"name": "PRX/jingle.prx.org",
"url": "https://api.github.com/repos/PRX/jingle.prx.org"
} | {
"id": 16007382,
"login": "gcampo88",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16007382?",
"url": "https://api.github.com/users/gcampo88"
} | {
"id": 160453,
"login": "PRX",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/160453?",
"url": "https://api.github.com/orgs/PRX"
} | 2017-12-21T14:45:11 | 7018718834 | {"actor":{"display_login":"gcampo88"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/PX4/DriverFramework/pulls/comments/124779471","pull_request_review_id":47100681,"id":124779471,"diff_hunk":"@@ -180,14 +181,26 @@ namespace DriverFramework\n #endif\n \n #if defined(__DF_EDISON)\n-// update frequency 250 Hz\n #define MPU9250_MEASURE_INTERVAL_US 4000\n+#define MPU9250_PACKETS_PER_CYCLE 1\n+#define MPU9250_SPI_FIFO_FREQ SPI_FREQUENCY_5MHZ\n #elif defined(__DF_RPI_SINGLE)\n-// update frequency 1000 Hz,if using rpi1,rpi zero,1000hz may be to higher,please reduce the frequency\n #define MPU9250_MEASURE_INTERVAL_US 1000","path":"drivers/mpu9250/MPU9250.hpp","position":20,"original_position":20,"commit_id":"f319bb5480fdf6c00ee17c79e766c42c25f9e20d","original_commit_id":"f319bb5480fdf6c00ee17c79e766c42c25f9e20d","user":{"login":"nicolaerosia","id":4127983,"avatar_url":"https://avatars1.githubusercontent.com/u/4127983?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolaerosia","html_url":"https://github.com/nicolaerosia","followers_url":"https://api.github.com/users/nicolaerosia/followers","following_url":"https://api.github.com/users/nicolaerosia/following{/other_user}","gists_url":"https://api.github.com/users/nicolaerosia/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaerosia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaerosia/subscriptions","organizations_url":"https://api.github.com/users/nicolaerosia/orgs","repos_url":"https://api.github.com/users/nicolaerosia/repos","events_url":"https://api.github.com/users/nicolaerosia/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaerosia/received_events","type":"User","site_admin":false},"body":"Needs to be fixed, I only cared about RPI3 + Navio2 at this point","created_at":"2017-06-29T11:56:15Z","updated_at":"2017-06-29T11:56:15Z","html_url":"https://github.com/PX4/DriverFramework/pull/212#discussion_r124779471","pull_request_url":"https://api.github.com/repos/PX4/DriverFramework/pulls/212","_links":{"self":{"href":"https://api.github.com/repos/PX4/DriverFramework/pulls/comments/124779471"},"html":{"href":"https://github.com/PX4/DriverFramework/pull/212#discussion_r124779471"},"pull_request":{"href":"https://api.github.com/repos/PX4/DriverFramework/pulls/212"}}},"pull_request":{"url":"https://api.github.com/repos/PX4/DriverFramework/pulls/212","id":128081077,"html_url":"https://github.com/PX4/DriverFramework/pull/212","diff_url":"https://github.com/PX4/DriverFramework/pull/212.diff","patch_url":"https://github.com/PX4/DriverFramework/pull/212.patch","issue_url":"https://api.github.com/repos/PX4/DriverFramework/issues/212","number":212,"state":"open","locked":false,"title":"WIP: mpu9250 rework","user":{"login":"nicolaerosia","id":4127983,"avatar_url":"https://avatars1.githubusercontent.com/u/4127983?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolaerosia","html_url":"https://github.com/nicolaerosia","followers_url":"https://api.github.com/users/nicolaerosia/followers","following_url":"https://api.github.com/users/nicolaerosia/following{/other_user}","gists_url":"https://api.github.com/users/nicolaerosia/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaerosia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaerosia/subscriptions","organizations_url":"https://api.github.com/users/nicolaerosia/orgs","repos_url":"https://api.github.com/users/nicolaerosia/repos","events_url":"https://api.github.com/users/nicolaerosia/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaerosia/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nThis is an attempt to optimize the existing driver. After cleaning it up a bit (make compatible with other Linux platforms), I plan to move it in PX4/Firmware in order to remove data members duplication and inability to use perf counters.\r\n\r\nHighlights:\r\n* stop using WorkQueues. Start a high priority thread for only this task.\r\n* ability to pin the thread to a CPU Core. Together with pinning the SPIDev kernel workthread, this reduces the latency and jitter.\r\n* separate accel/gyro/mag publishing. This will allow for different sampling rates for each.\r\n* Sample FIFO at 18 MHz, the datasheet specifies the limit at 20 MHz +- 10%\r\n\r\nI've tested sampling FIFO at 8 KHz, with gyro running at 8 KHz, accel at 4 KHz and mag at 100 Hz.\r\nUnfortunately I couldn't achieve 8 KHz because the FIFO was too slow to sample the mag, this needs investigation/tuning the I2C delay registers. If I disable the mag, it runs at 8 KHz.","created_at":"2017-06-29T06:57:04Z","updated_at":"2017-06-29T11:56:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b673861acfabf19032c214c009c26873eb44b32","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/PX4/DriverFramework/pulls/212/commits","review_comments_url":"https://api.github.com/repos/PX4/DriverFramework/pulls/212/comments","review_comment_url":"https://api.github.com/repos/PX4/DriverFramework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PX4/DriverFramework/issues/212/comments","statuses_url":"https://api.github.com/repos/PX4/DriverFramework/statuses/f319bb5480fdf6c00ee17c79e766c42c25f9e20d","head":{"label":"nicolaerosia:mpu9250-rework","ref":"mpu9250-rework","sha":"f319bb5480fdf6c00ee17c79e766c42c25f9e20d","user":{"login":"nicolaerosia","id":4127983,"avatar_url":"https://avatars1.githubusercontent.com/u/4127983?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolaerosia","html_url":"https://github.com/nicolaerosia","followers_url":"https://api.github.com/users/nicolaerosia/followers","following_url":"https://api.github.com/users/nicolaerosia/following{/other_user}","gists_url":"https://api.github.com/users/nicolaerosia/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaerosia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaerosia/subscriptions","organizations_url":"https://api.github.com/users/nicolaerosia/orgs","repos_url":"https://api.github.com/users/nicolaerosia/repos","events_url":"https://api.github.com/users/nicolaerosia/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaerosia/received_events","type":"User","site_admin":false},"repo":{"id":92775486,"name":"DriverFramework","full_name":"nicolaerosia/DriverFramework","owner":{"login":"nicolaerosia","id":4127983,"avatar_url":"https://avatars1.githubusercontent.com/u/4127983?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolaerosia","html_url":"https://github.com/nicolaerosia","followers_url":"https://api.github.com/users/nicolaerosia/followers","following_url":"https://api.github.com/users/nicolaerosia/following{/other_user}","gists_url":"https://api.github.com/users/nicolaerosia/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaerosia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaerosia/subscriptions","organizations_url":"https://api.github.com/users/nicolaerosia/orgs","repos_url":"https://api.github.com/users/nicolaerosia/repos","events_url":"https://api.github.com/users/nicolaerosia/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaerosia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nicolaerosia/DriverFramework","description":"Operating system and flight stack agnostic driver framework for POSIX (Linux, NuttX, Mac OS, QNX, VxWorks).","fork":true,"url":"https://api.github.com/repos/nicolaerosia/DriverFramework","forks_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/forks","keys_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/teams","hooks_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/hooks","issue_events_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/issues/events{/number}","events_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/events","assignees_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/assignees{/user}","branches_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/branches{/branch}","tags_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/tags","blobs_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/statuses/{sha}","languages_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/languages","stargazers_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/stargazers","contributors_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/contributors","subscribers_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/subscribers","subscription_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/subscription","commits_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/issues/comments{/number}","contents_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/contents/{+path}","compare_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/merges","archive_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/downloads","issues_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/issues{/number}","pulls_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/pulls{/number}","milestones_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/milestones{/number}","notifications_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/labels{/name}","releases_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/releases{/id}","deployments_url":"https://api.github.com/repos/nicolaerosia/DriverFramework/deployments","created_at":"2017-05-29T21:07:32Z","updated_at":"2017-05-29T21:07:34Z","pushed_at":"2017-06-29T06:52:54Z","git_url":"git://github.com/nicolaerosia/DriverFramework.git","ssh_url":"[email protected]:nicolaerosia/DriverFramework.git","clone_url":"https://github.com/nicolaerosia/DriverFramework.git","svn_url":"https://github.com/nicolaerosia/DriverFramework","homepage":"","size":907,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PX4:master","ref":"master","sha":"3b537ba890bd3776f21cae196e8e388732864fd6","user":{"login":"PX4","id":2096014,"avatar_url":"https://avatars0.githubusercontent.com/u/2096014?v=3","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"repo":{"id":45463028,"name":"DriverFramework","full_name":"PX4/DriverFramework","owner":{"login":"PX4","id":2096014,"avatar_url":"https://avatars0.githubusercontent.com/u/2096014?v=3","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PX4/DriverFramework","description":"Operating system and flight stack agnostic driver framework for POSIX (Linux, NuttX, Mac OS, QNX, VxWorks).","fork":false,"url":"https://api.github.com/repos/PX4/DriverFramework","forks_url":"https://api.github.com/repos/PX4/DriverFramework/forks","keys_url":"https://api.github.com/repos/PX4/DriverFramework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PX4/DriverFramework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PX4/DriverFramework/teams","hooks_url":"https://api.github.com/repos/PX4/DriverFramework/hooks","issue_events_url":"https://api.github.com/repos/PX4/DriverFramework/issues/events{/number}","events_url":"https://api.github.com/repos/PX4/DriverFramework/events","assignees_url":"https://api.github.com/repos/PX4/DriverFramework/assignees{/user}","branches_url":"https://api.github.com/repos/PX4/DriverFramework/branches{/branch}","tags_url":"https://api.github.com/repos/PX4/DriverFramework/tags","blobs_url":"https://api.github.com/repos/PX4/DriverFramework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PX4/DriverFramework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PX4/DriverFramework/git/refs{/sha}","trees_url":"https://api.github.com/repos/PX4/DriverFramework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PX4/DriverFramework/statuses/{sha}","languages_url":"https://api.github.com/repos/PX4/DriverFramework/languages","stargazers_url":"https://api.github.com/repos/PX4/DriverFramework/stargazers","contributors_url":"https://api.github.com/repos/PX4/DriverFramework/contributors","subscribers_url":"https://api.github.com/repos/PX4/DriverFramework/subscribers","subscription_url":"https://api.github.com/repos/PX4/DriverFramework/subscription","commits_url":"https://api.github.com/repos/PX4/DriverFramework/commits{/sha}","git_commits_url":"https://api.github.com/repos/PX4/DriverFramework/git/commits{/sha}","comments_url":"https://api.github.com/repos/PX4/DriverFramework/comments{/number}","issue_comment_url":"https://api.github.com/repos/PX4/DriverFramework/issues/comments{/number}","contents_url":"https://api.github.com/repos/PX4/DriverFramework/contents/{+path}","compare_url":"https://api.github.com/repos/PX4/DriverFramework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PX4/DriverFramework/merges","archive_url":"https://api.github.com/repos/PX4/DriverFramework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PX4/DriverFramework/downloads","issues_url":"https://api.github.com/repos/PX4/DriverFramework/issues{/number}","pulls_url":"https://api.github.com/repos/PX4/DriverFramework/pulls{/number}","milestones_url":"https://api.github.com/repos/PX4/DriverFramework/milestones{/number}","notifications_url":"https://api.github.com/repos/PX4/DriverFramework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PX4/DriverFramework/labels{/name}","releases_url":"https://api.github.com/repos/PX4/DriverFramework/releases{/id}","deployments_url":"https://api.github.com/repos/PX4/DriverFramework/deployments","created_at":"2015-11-03T11:49:29Z","updated_at":"2017-06-07T08:24:39Z","pushed_at":"2017-06-29T06:57:05Z","git_url":"git://github.com/PX4/DriverFramework.git","ssh_url":"[email protected]:PX4/DriverFramework.git","clone_url":"https://github.com/PX4/DriverFramework.git","svn_url":"https://github.com/PX4/DriverFramework","homepage":"","size":869,"stargazers_count":29,"watchers_count":29,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":23,"forks":70,"open_issues":23,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PX4/DriverFramework/pulls/212"},"html":{"href":"https://github.com/PX4/DriverFramework/pull/212"},"issue":{"href":"https://api.github.com/repos/PX4/DriverFramework/issues/212"},"comments":{"href":"https://api.github.com/repos/PX4/DriverFramework/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/PX4/DriverFramework/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/PX4/DriverFramework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PX4/DriverFramework/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/PX4/DriverFramework/statuses/f319bb5480fdf6c00ee17c79e766c42c25f9e20d"}}}} | {
"id": 45463028,
"name": "PX4/DriverFramework",
"url": "https://api.github.com/repos/PX4/DriverFramework"
} | {
"id": 4127983,
"login": "nicolaerosia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4127983?",
"url": "https://api.github.com/users/nicolaerosia"
} | {
"id": 2096014,
"login": "PX4",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2096014?",
"url": "https://api.github.com/orgs/PX4"
} | 2017-06-29T11:56:15 | 6162657240 | {"actor":{"display_login":"nicolaerosia"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments/132042159","pull_request_review_id":55082196,"id":132042159,"diff_hunk":"@@ -0,0 +1,151 @@\n+// Copyright 2017 Amazon.com, Inc. or its affiliates. All Rights Reserved.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\"). You may\n+// not use this file except in compliance with the License. A copy of the\n+// License is located at\n+//\n+//\thttp://aws.amazon.com/apache2.0/\n+//\n+// or in the \"license\" file accompanying this file. This file is distributed\n+// on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either\n+// express or implied. See the License for the specific language governing\n+// permissions and limitations under the License.\n+\n+package containermetadata\n+\n+import (\n+\t\"encoding/json\"\n+\t\"fmt\"\n+\t\"os\"\n+\t\"time\"\n+\n+\t\"github.com/aws/amazon-ecs-agent/agent/api\"\n+\t\"github.com/aws/amazon-ecs-agent/agent/config\"\n+\n+\tdocker \"github.com/fsouza/go-dockerclient\"\n+)\n+\n+const (\n+\tmetadataEnvironmentVariable = \"ECS_CONTAINER_METADATA_FILE\"\n+\tinspectContainerTimeout = 30 * time.Second\n+)\n+\n+type MetadataStatus string\n+\n+const (\n+\tMetadata_NOT_READY = \"NOT_READY\"","path":"agent/containermetadata/metadata_manager.go","position":35,"original_position":36,"commit_id":"499dbe31dcd18bee5a9f4aef1eae7f33496f7d95","original_commit_id":"e624da2ffd54fc6ff5666295b62b591312f502ce","user":{"login":"huerdong","id":9068089,"avatar_url":"https://avatars1.githubusercontent.com/u/9068089?v=4","gravatar_id":"","url":"https://api.github.com/users/huerdong","html_url":"https://github.com/huerdong","followers_url":"https://api.github.com/users/huerdong/followers","following_url":"https://api.github.com/users/huerdong/following{/other_user}","gists_url":"https://api.github.com/users/huerdong/gists{/gist_id}","starred_url":"https://api.github.com/users/huerdong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huerdong/subscriptions","organizations_url":"https://api.github.com/users/huerdong/orgs","repos_url":"https://api.github.com/users/huerdong/repos","events_url":"https://api.github.com/users/huerdong/events{/privacy}","received_events_url":"https://api.github.com/users/huerdong/received_events","type":"User","site_admin":false},"body":"I understand what you are saying and certainly we do not need the states stuff if we perform a single metadata file write after the container starts and we have all the data. The problem is for users to check that this file is ready in this case, they would either need a delay after container start or a file exist check after the container starts to ensure the file is valid. This puts unnecessary burden on the user to address the race condition when we can simply provide the availability of the metadata as a metadata field as well. ","created_at":"2017-08-08T21:48:34Z","updated_at":"2017-08-08T21:48:34Z","html_url":"https://github.com/aws/amazon-ecs-agent/pull/913#discussion_r132042159","pull_request_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/913","_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments/132042159"},"html":{"href":"https://github.com/aws/amazon-ecs-agent/pull/913#discussion_r132042159"},"pull_request":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/913"}}},"pull_request":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/913","id":134175368,"html_url":"https://github.com/aws/amazon-ecs-agent/pull/913","diff_url":"https://github.com/aws/amazon-ecs-agent/pull/913.diff","patch_url":"https://github.com/aws/amazon-ecs-agent/pull/913.patch","issue_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/913","number":913,"state":"open","locked":false,"title":"Container Metadata","user":{"login":"huerdong","id":9068089,"avatar_url":"https://avatars1.githubusercontent.com/u/9068089?v=4","gravatar_id":"","url":"https://api.github.com/users/huerdong","html_url":"https://github.com/huerdong","followers_url":"https://api.github.com/users/huerdong/followers","following_url":"https://api.github.com/users/huerdong/following{/other_user}","gists_url":"https://api.github.com/users/huerdong/gists{/gist_id}","starred_url":"https://api.github.com/users/huerdong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huerdong/subscriptions","organizations_url":"https://api.github.com/users/huerdong/orgs","repos_url":"https://api.github.com/users/huerdong/repos","events_url":"https://api.github.com/users/huerdong/events{/privacy}","received_events_url":"https://api.github.com/users/huerdong/received_events","type":"User","site_admin":false},"body":"<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/aws/amazon-ecs-agent/blob/master/CONTRIBUTING.md\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n### Summary\r\n<!-- What does this pull request do? -->\r\nThis is the same pull request as #848. Since that PR is unusable for review because of its 400 comments causing page load latency and 500 errors, I have decided to open a second PR and closed the old one. \r\n\r\n### Implementation details\r\n<!-- How are the changes implemented? -->\r\nSee #848 \r\n\r\n### Testing\r\n<!-- How was this tested? -->\r\n<!--\r\nNote for external contributors:\r\n`make test` and `make run-integ-tests` can run in a Linux development\r\nenvironment like your laptop. `go test -timeout=25s ./agent/...` and\r\n`.\\scripts\\run-integ.tests.ps1` can run in a Windows development environment\r\nlike your laptop. Please ensure unit and integration tests pass (on at least\r\none platform) before opening the pull request. `make run-functional-tests` and\r\n`.\\scripts\\run-functional-tests.ps1` must be run on an EC2 instance with an\r\ninstance profile allowing it access to AWS resources. Running\r\n`make run-functional-tests` and `.\\scripts\\run-functional-tests.ps1` may incur\r\ncharges to your AWS account; if you're unable or unwilling to run these tests\r\nin your own account, we can run the tests and provide test results.\r\n-->\r\n- [x] Builds on Linux (`make release`)\r\n- [x] Builds on Windows (`go build -out amazon-ecs-agent.exe ./agent`)\r\n- [x] Unit tests on Linux (`make test`) pass\r\n- [x] Unit tests on Windows (`go test -timeout=25s ./agent/...`) pass\r\n- [x] Integration tests on Linux (`make run-integ-tests`) pass\r\n- [x] Integration tests on Windows (`.\\scripts\\run-integ-tests.ps1`) pass\r\n- [x] Functional tests on Linux (`make run-functional-tests`) pass\r\n- [x] Functional tests on Windows (`.\\scripts\\run-functional-tests.ps1`) pass\r\n\r\nNew tests cover the changes: <!-- yes|no -->\r\n\r\n### Description for the changelog\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog.\r\nYou can see our changelog entry style here:\r\nhttps://github.com/aws/amazon-ecs-agent/commit/c9aefebc2b3007f09468f651f6308136bd7b384f\r\n-->\r\n\r\n### Licensing\r\n<!--\r\nPlease confirm that this contribution is under the terms of the Apache 2.0\r\nLicense.\r\n-->\r\nThis contribution is under the terms of the Apache 2.0 License: <!-- yes --> Yes\r\n","created_at":"2017-08-04T14:06:57Z","updated_at":"2017-08-08T21:48:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"959f65fdd53edfd94b07012720b0d5647b7d70ad","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/913/commits","review_comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/913/comments","review_comment_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/913/comments","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/499dbe31dcd18bee5a9f4aef1eae7f33496f7d95","head":{"label":"huerdong:mdservice","ref":"mdservice","sha":"499dbe31dcd18bee5a9f4aef1eae7f33496f7d95","user":{"login":"huerdong","id":9068089,"avatar_url":"https://avatars1.githubusercontent.com/u/9068089?v=4","gravatar_id":"","url":"https://api.github.com/users/huerdong","html_url":"https://github.com/huerdong","followers_url":"https://api.github.com/users/huerdong/followers","following_url":"https://api.github.com/users/huerdong/following{/other_user}","gists_url":"https://api.github.com/users/huerdong/gists{/gist_id}","starred_url":"https://api.github.com/users/huerdong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huerdong/subscriptions","organizations_url":"https://api.github.com/users/huerdong/orgs","repos_url":"https://api.github.com/users/huerdong/repos","events_url":"https://api.github.com/users/huerdong/events{/privacy}","received_events_url":"https://api.github.com/users/huerdong/received_events","type":"User","site_admin":false},"repo":{"id":93096480,"name":"amazon-ecs-agent","full_name":"huerdong/amazon-ecs-agent","owner":{"login":"huerdong","id":9068089,"avatar_url":"https://avatars1.githubusercontent.com/u/9068089?v=4","gravatar_id":"","url":"https://api.github.com/users/huerdong","html_url":"https://github.com/huerdong","followers_url":"https://api.github.com/users/huerdong/followers","following_url":"https://api.github.com/users/huerdong/following{/other_user}","gists_url":"https://api.github.com/users/huerdong/gists{/gist_id}","starred_url":"https://api.github.com/users/huerdong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huerdong/subscriptions","organizations_url":"https://api.github.com/users/huerdong/orgs","repos_url":"https://api.github.com/users/huerdong/repos","events_url":"https://api.github.com/users/huerdong/events{/privacy}","received_events_url":"https://api.github.com/users/huerdong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huerdong/amazon-ecs-agent","description":"Amazon EC2 Container Service Agent","fork":true,"url":"https://api.github.com/repos/huerdong/amazon-ecs-agent","forks_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/forks","keys_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/teams","hooks_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/hooks","issue_events_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/issues/events{/number}","events_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/events","assignees_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/assignees{/user}","branches_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/branches{/branch}","tags_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/tags","blobs_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/languages","stargazers_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/stargazers","contributors_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/contributors","subscribers_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/subscribers","subscription_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/subscription","commits_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/contents/{+path}","compare_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/merges","archive_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/downloads","issues_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/issues{/number}","pulls_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/labels{/name}","releases_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/releases{/id}","deployments_url":"https://api.github.com/repos/huerdong/amazon-ecs-agent/deployments","created_at":"2017-06-01T20:24:48Z","updated_at":"2017-06-01T20:24:50Z","pushed_at":"2017-08-07T23:16:09Z","git_url":"git://github.com/huerdong/amazon-ecs-agent.git","ssh_url":"[email protected]:huerdong/amazon-ecs-agent.git","clone_url":"https://github.com/huerdong/amazon-ecs-agent.git","svn_url":"https://github.com/huerdong/amazon-ecs-agent","homepage":"http://aws.amazon.com/ecs/","size":6185,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"mdservice"}},"base":{"label":"aws:dev","ref":"dev","sha":"1bc9d688413a65c6993cc6646dffd7c6704a2a9e","user":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":27551774,"name":"amazon-ecs-agent","full_name":"aws/amazon-ecs-agent","owner":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws/amazon-ecs-agent","description":"Amazon EC2 Container Service Agent","fork":false,"url":"https://api.github.com/repos/aws/amazon-ecs-agent","forks_url":"https://api.github.com/repos/aws/amazon-ecs-agent/forks","keys_url":"https://api.github.com/repos/aws/amazon-ecs-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/amazon-ecs-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/amazon-ecs-agent/teams","hooks_url":"https://api.github.com/repos/aws/amazon-ecs-agent/hooks","issue_events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/events{/number}","events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/events","assignees_url":"https://api.github.com/repos/aws/amazon-ecs-agent/assignees{/user}","branches_url":"https://api.github.com/repos/aws/amazon-ecs-agent/branches{/branch}","tags_url":"https://api.github.com/repos/aws/amazon-ecs-agent/tags","blobs_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/amazon-ecs-agent/languages","stargazers_url":"https://api.github.com/repos/aws/amazon-ecs-agent/stargazers","contributors_url":"https://api.github.com/repos/aws/amazon-ecs-agent/contributors","subscribers_url":"https://api.github.com/repos/aws/amazon-ecs-agent/subscribers","subscription_url":"https://api.github.com/repos/aws/amazon-ecs-agent/subscription","commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/amazon-ecs-agent/contents/{+path}","compare_url":"https://api.github.com/repos/aws/amazon-ecs-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/amazon-ecs-agent/merges","archive_url":"https://api.github.com/repos/aws/amazon-ecs-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/amazon-ecs-agent/downloads","issues_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues{/number}","pulls_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/amazon-ecs-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/amazon-ecs-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/amazon-ecs-agent/labels{/name}","releases_url":"https://api.github.com/repos/aws/amazon-ecs-agent/releases{/id}","deployments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/deployments","created_at":"2014-12-04T17:31:49Z","updated_at":"2017-08-08T06:34:15Z","pushed_at":"2017-08-08T18:40:59Z","git_url":"git://github.com/aws/amazon-ecs-agent.git","ssh_url":"[email protected]:aws/amazon-ecs-agent.git","clone_url":"https://github.com/aws/amazon-ecs-agent.git","svn_url":"https://github.com/aws/amazon-ecs-agent","homepage":"http://aws.amazon.com/ecs/","size":6318,"stargazers_count":952,"watchers_count":952,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":251,"mirror_url":null,"open_issues_count":131,"forks":251,"open_issues":131,"watchers":952,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/913"},"html":{"href":"https://github.com/aws/amazon-ecs-agent/pull/913"},"issue":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/913"},"comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/913/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/913/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/913/commits"},"statuses":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/499dbe31dcd18bee5a9f4aef1eae7f33496f7d95"}}}} | {
"id": 27551774,
"name": "aws/amazon-ecs-agent",
"url": "https://api.github.com/repos/aws/amazon-ecs-agent"
} | {
"id": 9068089,
"login": "huerdong",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9068089?",
"url": "https://api.github.com/users/huerdong"
} | {
"id": 2232217,
"login": "aws",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2232217?",
"url": "https://api.github.com/orgs/aws"
} | 2017-08-08T21:48:34 | 6419682657 | {"actor":{"display_login":"huerdong"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/aws/aws-sdk-php/pulls/comments/131283916","pull_request_review_id":54249947,"id":131283916,"diff_hunk":"@@ -285,22 +287,22 @@ private function getCanonicalizedQuery(array $query)\n return substr($qs, 0, -1);\n }\n \n- private function convertToTimestamp($dateValue)\n+ private function convertToTimestamp($dateValue, $relativeTimeBase = null)\n {\n if ($dateValue instanceof \\DateTime) {\n $timestamp = $dateValue->getTimestamp();\n } elseif (!is_numeric($dateValue)) {\n- $timestamp = strtotime($dateValue);\n+ $timestamp = strtotime($dateValue, $relativeTimeBase === null ? time() : $relativeTimeBase );","path":"src/Signature/SignatureV4.php","position":31,"original_position":31,"commit_id":"6cd12a2744b9da9813faf1f7d6bf3f52d336c67a","original_commit_id":"6cd12a2744b9da9813faf1f7d6bf3f52d336c67a","user":{"login":"kstich","id":26905335,"avatar_url":"https://avatars1.githubusercontent.com/u/26905335?v=4","gravatar_id":"","url":"https://api.github.com/users/kstich","html_url":"https://github.com/kstich","followers_url":"https://api.github.com/users/kstich/followers","following_url":"https://api.github.com/users/kstich/following{/other_user}","gists_url":"https://api.github.com/users/kstich/gists{/gist_id}","starred_url":"https://api.github.com/users/kstich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kstich/subscriptions","organizations_url":"https://api.github.com/users/kstich/orgs","repos_url":"https://api.github.com/users/kstich/repos","events_url":"https://api.github.com/users/kstich/events{/privacy}","received_events_url":"https://api.github.com/users/kstich/received_events","type":"User","site_admin":false},"body":"For this case, the ternary can be one line but the arguments would be separated.\r\n```php\r\nstrtotime(\r\n $dateValue,\r\n $relativeTimeBase === null ? time() : $relativeTimeBase\r\n);\r\n```","created_at":"2017-08-03T23:32:27Z","updated_at":"2017-08-03T23:32:27Z","html_url":"https://github.com/aws/aws-sdk-php/pull/1325#discussion_r131283916","pull_request_url":"https://api.github.com/repos/aws/aws-sdk-php/pulls/1325","_links":{"self":{"href":"https://api.github.com/repos/aws/aws-sdk-php/pulls/comments/131283916"},"html":{"href":"https://github.com/aws/aws-sdk-php/pull/1325#discussion_r131283916"},"pull_request":{"href":"https://api.github.com/repos/aws/aws-sdk-php/pulls/1325"}}},"pull_request":{"url":"https://api.github.com/repos/aws/aws-sdk-php/pulls/1325","id":129300969,"html_url":"https://github.com/aws/aws-sdk-php/pull/1325","diff_url":"https://github.com/aws/aws-sdk-php/pull/1325.diff","patch_url":"https://github.com/aws/aws-sdk-php/pull/1325.patch","issue_url":"https://api.github.com/repos/aws/aws-sdk-php/issues/1325","number":1325,"state":"open","locked":false,"title":"Move expires timestamp in SignatureV4 to be generated before startTimestamp","user":{"login":"daum","id":52372,"avatar_url":"https://avatars1.githubusercontent.com/u/52372?v=4","gravatar_id":"","url":"https://api.github.com/users/daum","html_url":"https://github.com/daum","followers_url":"https://api.github.com/users/daum/followers","following_url":"https://api.github.com/users/daum/following{/other_user}","gists_url":"https://api.github.com/users/daum/gists{/gist_id}","starred_url":"https://api.github.com/users/daum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daum/subscriptions","organizations_url":"https://api.github.com/users/daum/orgs","repos_url":"https://api.github.com/users/daum/repos","events_url":"https://api.github.com/users/daum/events{/privacy}","received_events_url":"https://api.github.com/users/daum/received_events","type":"User","site_admin":false},"body":"As described in issue #1322 an edge case of using exactly 1 week expiration when a second rolls between\r\nthe startTimestamp calculation via time() and the expires timestamp can cause incorrect exceptions. This\r\noccurs when the second rolls over (ie 12:01:01.9999999 to 12:02:02.00000) between the startTime (time())\r\nand endTime conversion from strtotime(). This causes the exception of the expiration must be less than a week\r\nto be thrown. By moving the endTime to be converted before startTime this guarantees that will never occur.","created_at":"2017-07-06T23:18:51Z","updated_at":"2017-08-03T23:32:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c93d062dad9232fc39655b0887782e08c568e22","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/aws-sdk-php/pulls/1325/commits","review_comments_url":"https://api.github.com/repos/aws/aws-sdk-php/pulls/1325/comments","review_comment_url":"https://api.github.com/repos/aws/aws-sdk-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/aws-sdk-php/issues/1325/comments","statuses_url":"https://api.github.com/repos/aws/aws-sdk-php/statuses/6cd12a2744b9da9813faf1f7d6bf3f52d336c67a","head":{"label":"daum:bugfix-signature-expiration-second-break","ref":"bugfix-signature-expiration-second-break","sha":"6cd12a2744b9da9813faf1f7d6bf3f52d336c67a","user":{"login":"daum","id":52372,"avatar_url":"https://avatars1.githubusercontent.com/u/52372?v=4","gravatar_id":"","url":"https://api.github.com/users/daum","html_url":"https://github.com/daum","followers_url":"https://api.github.com/users/daum/followers","following_url":"https://api.github.com/users/daum/following{/other_user}","gists_url":"https://api.github.com/users/daum/gists{/gist_id}","starred_url":"https://api.github.com/users/daum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daum/subscriptions","organizations_url":"https://api.github.com/users/daum/orgs","repos_url":"https://api.github.com/users/daum/repos","events_url":"https://api.github.com/users/daum/events{/privacy}","received_events_url":"https://api.github.com/users/daum/received_events","type":"User","site_admin":false},"repo":{"id":96479019,"name":"aws-sdk-php","full_name":"daum/aws-sdk-php","owner":{"login":"daum","id":52372,"avatar_url":"https://avatars1.githubusercontent.com/u/52372?v=4","gravatar_id":"","url":"https://api.github.com/users/daum","html_url":"https://github.com/daum","followers_url":"https://api.github.com/users/daum/followers","following_url":"https://api.github.com/users/daum/following{/other_user}","gists_url":"https://api.github.com/users/daum/gists{/gist_id}","starred_url":"https://api.github.com/users/daum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daum/subscriptions","organizations_url":"https://api.github.com/users/daum/orgs","repos_url":"https://api.github.com/users/daum/repos","events_url":"https://api.github.com/users/daum/events{/privacy}","received_events_url":"https://api.github.com/users/daum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daum/aws-sdk-php","description":"Official repository of the AWS SDK for PHP (@awsforphp)","fork":true,"url":"https://api.github.com/repos/daum/aws-sdk-php","forks_url":"https://api.github.com/repos/daum/aws-sdk-php/forks","keys_url":"https://api.github.com/repos/daum/aws-sdk-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daum/aws-sdk-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daum/aws-sdk-php/teams","hooks_url":"https://api.github.com/repos/daum/aws-sdk-php/hooks","issue_events_url":"https://api.github.com/repos/daum/aws-sdk-php/issues/events{/number}","events_url":"https://api.github.com/repos/daum/aws-sdk-php/events","assignees_url":"https://api.github.com/repos/daum/aws-sdk-php/assignees{/user}","branches_url":"https://api.github.com/repos/daum/aws-sdk-php/branches{/branch}","tags_url":"https://api.github.com/repos/daum/aws-sdk-php/tags","blobs_url":"https://api.github.com/repos/daum/aws-sdk-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daum/aws-sdk-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daum/aws-sdk-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/daum/aws-sdk-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daum/aws-sdk-php/statuses/{sha}","languages_url":"https://api.github.com/repos/daum/aws-sdk-php/languages","stargazers_url":"https://api.github.com/repos/daum/aws-sdk-php/stargazers","contributors_url":"https://api.github.com/repos/daum/aws-sdk-php/contributors","subscribers_url":"https://api.github.com/repos/daum/aws-sdk-php/subscribers","subscription_url":"https://api.github.com/repos/daum/aws-sdk-php/subscription","commits_url":"https://api.github.com/repos/daum/aws-sdk-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/daum/aws-sdk-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/daum/aws-sdk-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/daum/aws-sdk-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/daum/aws-sdk-php/contents/{+path}","compare_url":"https://api.github.com/repos/daum/aws-sdk-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daum/aws-sdk-php/merges","archive_url":"https://api.github.com/repos/daum/aws-sdk-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daum/aws-sdk-php/downloads","issues_url":"https://api.github.com/repos/daum/aws-sdk-php/issues{/number}","pulls_url":"https://api.github.com/repos/daum/aws-sdk-php/pulls{/number}","milestones_url":"https://api.github.com/repos/daum/aws-sdk-php/milestones{/number}","notifications_url":"https://api.github.com/repos/daum/aws-sdk-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daum/aws-sdk-php/labels{/name}","releases_url":"https://api.github.com/repos/daum/aws-sdk-php/releases{/id}","deployments_url":"https://api.github.com/repos/daum/aws-sdk-php/deployments","created_at":"2017-07-06T23:06:51Z","updated_at":"2017-07-06T23:06:58Z","pushed_at":"2017-08-03T22:28:55Z","git_url":"git://github.com/daum/aws-sdk-php.git","ssh_url":"[email protected]:daum/aws-sdk-php.git","clone_url":"https://github.com/daum/aws-sdk-php.git","svn_url":"https://github.com/daum/aws-sdk-php","homepage":"http://aws.amazon.com/sdkforphp","size":34161,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aws:master","ref":"master","sha":"7c34cf04cc03046c8a20e74e72e1a1b5d8f3b8f2","user":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":6269013,"name":"aws-sdk-php","full_name":"aws/aws-sdk-php","owner":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws/aws-sdk-php","description":"Official repository of the AWS SDK for PHP (@awsforphp)","fork":false,"url":"https://api.github.com/repos/aws/aws-sdk-php","forks_url":"https://api.github.com/repos/aws/aws-sdk-php/forks","keys_url":"https://api.github.com/repos/aws/aws-sdk-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/aws-sdk-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/aws-sdk-php/teams","hooks_url":"https://api.github.com/repos/aws/aws-sdk-php/hooks","issue_events_url":"https://api.github.com/repos/aws/aws-sdk-php/issues/events{/number}","events_url":"https://api.github.com/repos/aws/aws-sdk-php/events","assignees_url":"https://api.github.com/repos/aws/aws-sdk-php/assignees{/user}","branches_url":"https://api.github.com/repos/aws/aws-sdk-php/branches{/branch}","tags_url":"https://api.github.com/repos/aws/aws-sdk-php/tags","blobs_url":"https://api.github.com/repos/aws/aws-sdk-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/aws-sdk-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/aws-sdk-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/aws-sdk-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/aws-sdk-php/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/aws-sdk-php/languages","stargazers_url":"https://api.github.com/repos/aws/aws-sdk-php/stargazers","contributors_url":"https://api.github.com/repos/aws/aws-sdk-php/contributors","subscribers_url":"https://api.github.com/repos/aws/aws-sdk-php/subscribers","subscription_url":"https://api.github.com/repos/aws/aws-sdk-php/subscription","commits_url":"https://api.github.com/repos/aws/aws-sdk-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/aws-sdk-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/aws-sdk-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/aws-sdk-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/aws-sdk-php/contents/{+path}","compare_url":"https://api.github.com/repos/aws/aws-sdk-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/aws-sdk-php/merges","archive_url":"https://api.github.com/repos/aws/aws-sdk-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/aws-sdk-php/downloads","issues_url":"https://api.github.com/repos/aws/aws-sdk-php/issues{/number}","pulls_url":"https://api.github.com/repos/aws/aws-sdk-php/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/aws-sdk-php/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/aws-sdk-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/aws-sdk-php/labels{/name}","releases_url":"https://api.github.com/repos/aws/aws-sdk-php/releases{/id}","deployments_url":"https://api.github.com/repos/aws/aws-sdk-php/deployments","created_at":"2012-10-17T21:28:32Z","updated_at":"2017-08-03T14:08:27Z","pushed_at":"2017-08-03T23:18:32Z","git_url":"git://github.com/aws/aws-sdk-php.git","ssh_url":"[email protected]:aws/aws-sdk-php.git","clone_url":"https://github.com/aws/aws-sdk-php.git","svn_url":"https://github.com/aws/aws-sdk-php","homepage":"http://aws.amazon.com/sdkforphp","size":34191,"stargazers_count":2558,"watchers_count":2558,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":696,"mirror_url":null,"open_issues_count":20,"forks":696,"open_issues":20,"watchers":2558,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/aws-sdk-php/pulls/1325"},"html":{"href":"https://github.com/aws/aws-sdk-php/pull/1325"},"issue":{"href":"https://api.github.com/repos/aws/aws-sdk-php/issues/1325"},"comments":{"href":"https://api.github.com/repos/aws/aws-sdk-php/issues/1325/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/aws-sdk-php/pulls/1325/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/aws-sdk-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/aws-sdk-php/pulls/1325/commits"},"statuses":{"href":"https://api.github.com/repos/aws/aws-sdk-php/statuses/6cd12a2744b9da9813faf1f7d6bf3f52d336c67a"}}}} | {
"id": 6269013,
"name": "aws/aws-sdk-php",
"url": "https://api.github.com/repos/aws/aws-sdk-php"
} | {
"id": 26905335,
"login": "kstich",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26905335?",
"url": "https://api.github.com/users/kstich"
} | {
"id": 2232217,
"login": "aws",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2232217?",
"url": "https://api.github.com/orgs/aws"
} | 2017-08-03T23:32:27 | 6391750987 | {"actor":{"display_login":"kstich"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/112193314","pull_request_review_id":33488181,"id":112193314,"diff_hunk":"@@ -343,27 +343,32 @@ def get_user_orders(user):\n )\n \n for order in commerce_user_orders:\n- if order['status'].lower() == 'complete':\n- for line in order['lines']:\n- product = line.get('product')\n- if product:\n- for attribute in product['attribute_values']:\n- if attribute['name'] == 'certificate_type' and attribute['value'] in allowed_course_modes:\n- try:\n- date_placed = datetime.strptime(order['date_placed'], \"%Y-%m-%dT%H:%M:%SZ\")\n- order_data = {\n- 'number': order['number'],\n- 'price': order['total_excl_tax'],\n- 'title': order['lines'][0]['title'],\n- 'order_date': strftime_localized(\n- date_placed.replace(tzinfo=pytz.UTC), 'SHORT_DATE'\n- ),\n- 'receipt_url': EcommerceService().get_receipt_page_url(order['number'])\n- }\n+ try:\n+ if order['status'].lower() == 'complete':\n+ order_lines = order['lines']\n+ date_placed = datetime.strptime(order['date_placed'], \"%Y-%m-%dT%H:%M:%SZ\")\n+ order_data = {\n+ 'number': order['number'],\n+ 'price': order['total_excl_tax'],\n+ 'order_date': strftime_localized(\n+ date_placed.replace(tzinfo=pytz.UTC), 'SHORT_DATE'\n+ ),\n+ 'receipt_url': EcommerceService().get_receipt_page_url(order['number']),\n+ 'lines': order_lines\n+ }\n+\n+ if len(order_lines) == 1:\n+ product = order_lines[0].get('product')\n+\n+ if product:\n+ for attribute in product['attribute_values']:\n+ if attribute['name'] == 'certificate_type' and attribute['value'] in allowed_course_modes:","path":"lms/djangoapps/student_account/views.py","position":40,"original_position":40,"commit_id":"68c053d9faca8ca299d777405d47dd4fd8ff2288","original_commit_id":"68c053d9faca8ca299d777405d47dd4fd8ff2288","user":{"login":"clintonb","id":910510,"avatar_url":"https://avatars3.githubusercontent.com/u/910510?v=3","gravatar_id":"","url":"https://api.github.com/users/clintonb","html_url":"https://github.com/clintonb","followers_url":"https://api.github.com/users/clintonb/followers","following_url":"https://api.github.com/users/clintonb/following{/other_user}","gists_url":"https://api.github.com/users/clintonb/gists{/gist_id}","starred_url":"https://api.github.com/users/clintonb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clintonb/subscriptions","organizations_url":"https://api.github.com/users/clintonb/orgs","repos_url":"https://api.github.com/users/clintonb/repos","events_url":"https://api.github.com/users/clintonb/events{/privacy}","received_events_url":"https://api.github.com/users/clintonb/received_events","type":"User","site_admin":false},"body":"If that's the case we need to:\r\n\r\n1. Add a comment to this effect.\r\n2. Filter based on product_class.\r\n3. Filter _all_ orders, not just those with a single item.","created_at":"2017-04-19T12:56:47Z","updated_at":"2017-04-19T12:56:47Z","html_url":"https://github.com/edx/edx-platform/pull/14906#discussion_r112193314","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/14906","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/112193314"},"html":{"href":"https://github.com/edx/edx-platform/pull/14906#discussion_r112193314"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/14906"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/14906","id":116295030,"html_url":"https://github.com/edx/edx-platform/pull/14906","diff_url":"https://github.com/edx/edx-platform/pull/14906.diff","patch_url":"https://github.com/edx/edx-platform/pull/14906.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/14906","number":14906,"state":"open","locked":false,"title":"Update Order History page to reflect bundled purchase","user":{"login":"iivic","id":16685686,"avatar_url":"https://avatars3.githubusercontent.com/u/16685686?v=3","gravatar_id":"","url":"https://api.github.com/users/iivic","html_url":"https://github.com/iivic","followers_url":"https://api.github.com/users/iivic/followers","following_url":"https://api.github.com/users/iivic/following{/other_user}","gists_url":"https://api.github.com/users/iivic/gists{/gist_id}","starred_url":"https://api.github.com/users/iivic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iivic/subscriptions","organizations_url":"https://api.github.com/users/iivic/orgs","repos_url":"https://api.github.com/users/iivic/repos","events_url":"https://api.github.com/users/iivic/events{/privacy}","received_events_url":"https://api.github.com/users/iivic/received_events","type":"User","site_admin":false},"body":"LEARNER-381\r\nScreen shot updated\r\n\r\n@mjfrey ","created_at":"2017-04-18T10:17:31Z","updated_at":"2017-04-19T12:56:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe6dcfedac476267b499a13e25bca21499e94fcb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/14906/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/14906/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/14906/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/68c053d9faca8ca299d777405d47dd4fd8ff2288","head":{"label":"edx:iivic/LEARNER-381","ref":"iivic/LEARNER-381","sha":"68c053d9faca8ca299d777405d47dd4fd8ff2288","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2017-04-18T08:13:26Z","pushed_at":"2017-04-19T12:20:14Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"[email protected]:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":811227,"stargazers_count":3094,"watchers_count":3094,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1796,"mirror_url":null,"open_issues_count":182,"forks":1796,"open_issues":182,"watchers":3094,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"2d4a564a4ad2e1ba4117778e4684ab0149445126","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2017-04-18T08:13:26Z","pushed_at":"2017-04-19T12:20:14Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"[email protected]:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":811227,"stargazers_count":3094,"watchers_count":3094,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1796,"mirror_url":null,"open_issues_count":182,"forks":1796,"open_issues":182,"watchers":3094,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/14906"},"html":{"href":"https://github.com/edx/edx-platform/pull/14906"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/14906"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/14906/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/14906/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/14906/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/68c053d9faca8ca299d777405d47dd4fd8ff2288"}}}} | {
"id": 10391073,
"name": "edx/edx-platform",
"url": "https://api.github.com/repos/edx/edx-platform"
} | {
"id": 910510,
"login": "clintonb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/910510?",
"url": "https://api.github.com/users/clintonb"
} | {
"id": 3179841,
"login": "edx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3179841?",
"url": "https://api.github.com/orgs/edx"
} | 2017-04-19T12:56:47 | 5715362475 | {"actor":{"display_login":"clintonb"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/edx/credentials/pulls/comments/95807162","pull_request_review_id":16373425,"id":95807162,"diff_hunk":"@@ -0,0 +1,121 @@\n+\"\"\"\n+Serializers for data manipulated by the credentials service APIs.\n+\"\"\"\n+import logging\n+\n+from django.core.exceptions import ObjectDoesNotExist\n+from rest_framework import serializers\n+from rest_framework.exceptions import ValidationError\n+from rest_framework.reverse import reverse\n+\n+from credentials.apps.api.accreditors import Accreditor\n+from credentials.apps.credentials.models import ProgramCertificate, UserCredential, UserCredentialAttribute\n+\n+logger = logging.getLogger(__name__)\n+\n+\n+class CredentialField(serializers.Field):\n+ \"\"\" Field identifying the credential type and identifiers.\"\"\"\n+\n+ def to_internal_value(self, data):\n+ program_uuid = data.get('program_uuid')\n+\n+ if not program_uuid:\n+ raise ValidationError('Credential ID is missing.')","path":"credentials/apps/api/v2/serializers.py","position":24,"original_position":24,"commit_id":"3b774e49f2ebceaad501716fc167407fb751975d","original_commit_id":"3b774e49f2ebceaad501716fc167407fb751975d","user":{"login":"rlucioni","id":969289,"avatar_url":"https://avatars.githubusercontent.com/u/969289?v=3","gravatar_id":"","url":"https://api.github.com/users/rlucioni","html_url":"https://github.com/rlucioni","followers_url":"https://api.github.com/users/rlucioni/followers","following_url":"https://api.github.com/users/rlucioni/following{/other_user}","gists_url":"https://api.github.com/users/rlucioni/gists{/gist_id}","starred_url":"https://api.github.com/users/rlucioni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlucioni/subscriptions","organizations_url":"https://api.github.com/users/rlucioni/orgs","repos_url":"https://api.github.com/users/rlucioni/repos","events_url":"https://api.github.com/users/rlucioni/events{/privacy}","received_events_url":"https://api.github.com/users/rlucioni/received_events","type":"User","site_admin":false},"body":"For clarity, should this refer to the UUID?","created_at":"2017-01-12T14:55:00Z","updated_at":"2017-01-12T15:02:46Z","html_url":"https://github.com/edx/credentials/pull/151#discussion_r95807162","pull_request_url":"https://api.github.com/repos/edx/credentials/pulls/151","_links":{"self":{"href":"https://api.github.com/repos/edx/credentials/pulls/comments/95807162"},"html":{"href":"https://github.com/edx/credentials/pull/151#discussion_r95807162"},"pull_request":{"href":"https://api.github.com/repos/edx/credentials/pulls/151"}}},"pull_request":{"url":"https://api.github.com/repos/edx/credentials/pulls/151","id":101144823,"html_url":"https://github.com/edx/credentials/pull/151","diff_url":"https://github.com/edx/credentials/pull/151.diff","patch_url":"https://github.com/edx/credentials/pull/151.patch","issue_url":"https://api.github.com/repos/edx/credentials/issues/151","number":151,"state":"open","locked":false,"title":"Removed unnecessary endpoints from API v2","user":{"login":"clintonb","id":910510,"avatar_url":"https://avatars.githubusercontent.com/u/910510?v=3","gravatar_id":"","url":"https://api.github.com/users/clintonb","html_url":"https://github.com/clintonb","followers_url":"https://api.github.com/users/clintonb/followers","following_url":"https://api.github.com/users/clintonb/following{/other_user}","gists_url":"https://api.github.com/users/clintonb/gists{/gist_id}","starred_url":"https://api.github.com/users/clintonb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clintonb/subscriptions","organizations_url":"https://api.github.com/users/clintonb/orgs","repos_url":"https://api.github.com/users/clintonb/repos","events_url":"https://api.github.com/users/clintonb/events{/privacy}","received_events_url":"https://api.github.com/users/clintonb/received_events","type":"User","site_admin":false},"body":"Two of the three endpoints are solely used to filter UserCredentials, for which an endpoint already exists. It makes more sense to add filtering to the existing user_credentials endpoint rather than continue supporting extra endpoints that essentially duplicate existing behavior.\n\nECOM-6808","created_at":"2017-01-11T20:55:55Z","updated_at":"2017-01-12T15:02:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ba982e4ad183718e73804653e866ae3888aeec1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/credentials/pulls/151/commits","review_comments_url":"https://api.github.com/repos/edx/credentials/pulls/151/comments","review_comment_url":"https://api.github.com/repos/edx/credentials/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/credentials/issues/151/comments","statuses_url":"https://api.github.com/repos/edx/credentials/statuses/3b774e49f2ebceaad501716fc167407fb751975d","head":{"label":"edx:clintonb/api-v2-redux","ref":"clintonb/api-v2-redux","sha":"3b774e49f2ebceaad501716fc167407fb751975d","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":47830104,"name":"credentials","full_name":"edx/credentials","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/credentials","description":"Django application used as the backend to support Course or Program based credentials.","fork":false,"url":"https://api.github.com/repos/edx/credentials","forks_url":"https://api.github.com/repos/edx/credentials/forks","keys_url":"https://api.github.com/repos/edx/credentials/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/credentials/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/credentials/teams","hooks_url":"https://api.github.com/repos/edx/credentials/hooks","issue_events_url":"https://api.github.com/repos/edx/credentials/issues/events{/number}","events_url":"https://api.github.com/repos/edx/credentials/events","assignees_url":"https://api.github.com/repos/edx/credentials/assignees{/user}","branches_url":"https://api.github.com/repos/edx/credentials/branches{/branch}","tags_url":"https://api.github.com/repos/edx/credentials/tags","blobs_url":"https://api.github.com/repos/edx/credentials/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/credentials/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/credentials/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/credentials/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/credentials/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/credentials/languages","stargazers_url":"https://api.github.com/repos/edx/credentials/stargazers","contributors_url":"https://api.github.com/repos/edx/credentials/contributors","subscribers_url":"https://api.github.com/repos/edx/credentials/subscribers","subscription_url":"https://api.github.com/repos/edx/credentials/subscription","commits_url":"https://api.github.com/repos/edx/credentials/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/credentials/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/credentials/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/credentials/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/credentials/contents/{+path}","compare_url":"https://api.github.com/repos/edx/credentials/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/credentials/merges","archive_url":"https://api.github.com/repos/edx/credentials/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/credentials/downloads","issues_url":"https://api.github.com/repos/edx/credentials/issues{/number}","pulls_url":"https://api.github.com/repos/edx/credentials/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/credentials/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/credentials/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/credentials/labels{/name}","releases_url":"https://api.github.com/repos/edx/credentials/releases{/id}","deployments_url":"https://api.github.com/repos/edx/credentials/deployments","created_at":"2015-12-11T14:09:03Z","updated_at":"2016-11-01T21:52:04Z","pushed_at":"2017-01-12T14:53:27Z","git_url":"git://github.com/edx/credentials.git","ssh_url":"[email protected]:edx/credentials.git","clone_url":"https://github.com/edx/credentials.git","svn_url":"https://github.com/edx/credentials","homepage":"http://open-edx-credentials-guide.readthedocs.org/en/latest/ ","size":2771,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"32773892674a60caf88c50bc31a83800e8ab8f1a","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":47830104,"name":"credentials","full_name":"edx/credentials","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/credentials","description":"Django application used as the backend to support Course or Program based credentials.","fork":false,"url":"https://api.github.com/repos/edx/credentials","forks_url":"https://api.github.com/repos/edx/credentials/forks","keys_url":"https://api.github.com/repos/edx/credentials/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/credentials/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/credentials/teams","hooks_url":"https://api.github.com/repos/edx/credentials/hooks","issue_events_url":"https://api.github.com/repos/edx/credentials/issues/events{/number}","events_url":"https://api.github.com/repos/edx/credentials/events","assignees_url":"https://api.github.com/repos/edx/credentials/assignees{/user}","branches_url":"https://api.github.com/repos/edx/credentials/branches{/branch}","tags_url":"https://api.github.com/repos/edx/credentials/tags","blobs_url":"https://api.github.com/repos/edx/credentials/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/credentials/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/credentials/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/credentials/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/credentials/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/credentials/languages","stargazers_url":"https://api.github.com/repos/edx/credentials/stargazers","contributors_url":"https://api.github.com/repos/edx/credentials/contributors","subscribers_url":"https://api.github.com/repos/edx/credentials/subscribers","subscription_url":"https://api.github.com/repos/edx/credentials/subscription","commits_url":"https://api.github.com/repos/edx/credentials/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/credentials/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/credentials/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/credentials/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/credentials/contents/{+path}","compare_url":"https://api.github.com/repos/edx/credentials/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/credentials/merges","archive_url":"https://api.github.com/repos/edx/credentials/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/credentials/downloads","issues_url":"https://api.github.com/repos/edx/credentials/issues{/number}","pulls_url":"https://api.github.com/repos/edx/credentials/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/credentials/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/credentials/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/credentials/labels{/name}","releases_url":"https://api.github.com/repos/edx/credentials/releases{/id}","deployments_url":"https://api.github.com/repos/edx/credentials/deployments","created_at":"2015-12-11T14:09:03Z","updated_at":"2016-11-01T21:52:04Z","pushed_at":"2017-01-12T14:53:27Z","git_url":"git://github.com/edx/credentials.git","ssh_url":"[email protected]:edx/credentials.git","clone_url":"https://github.com/edx/credentials.git","svn_url":"https://github.com/edx/credentials","homepage":"http://open-edx-credentials-guide.readthedocs.org/en/latest/ ","size":2771,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/credentials/pulls/151"},"html":{"href":"https://github.com/edx/credentials/pull/151"},"issue":{"href":"https://api.github.com/repos/edx/credentials/issues/151"},"comments":{"href":"https://api.github.com/repos/edx/credentials/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/credentials/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/credentials/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/credentials/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/edx/credentials/statuses/3b774e49f2ebceaad501716fc167407fb751975d"}}}} | {
"id": 47830104,
"name": "edx/credentials",
"url": "https://api.github.com/repos/edx/credentials"
} | {
"id": 969289,
"login": "rlucioni",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/969289?",
"url": "https://api.github.com/users/rlucioni"
} | {
"id": 3179841,
"login": "edx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3179841?",
"url": "https://api.github.com/orgs/edx"
} | 2017-01-12T14:55:00 | 5143047493 | {"actor":{"display_login":"rlucioni"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/edx/credentials/pulls/comments/104410939","pull_request_review_id":25243773,"id":104410939,"diff_hunk":"@@ -225,39 +234,46 @@ def assert_list_username_filter_request_succeeds(self, username, expected):\n def test_list_username_filtering(self):\n \"\"\" Verify the endpoint returns data for all UserCredentials awarded to the user matching the username. \"\"\"\n \n- UserCredentialFactory.create_batch(3)\n+ UserCredentialFactory.create_batch(3, credential=self.current_site_program_certificate)\n \n self.authenticate_user(self.user)\n \n # Users should be able to view their own credentials without additional permissions\n username = self.user.username\n- expected = UserCredentialFactory.create_batch(3, username=username)\n+ expected = UserCredentialFactory.create_site_aware_batch(3, username=username)\n self.assert_list_username_filter_request_succeeds(username, expected)\n \n # Privileged users should be able to view all credentials\n username = 'test_user' # pylint: disable=redefined-variable-type\n- expected = UserCredentialFactory.create_batch(3, username=username)\n+ expected = UserCredentialFactory.create_site_aware_batch(3, username=username)\n self.add_user_permission(self.user, 'view_usercredential')\n \n self.assert_list_username_filter_request_succeeds(username, expected)\n \n def test_list_program_uuid_filtering(self):\n \"\"\" Verify the endpoint returns data for all UserCredentials awarded for the given program. \"\"\"\n UserCredentialFactory.create_batch(3)\n- program_certificate = ProgramCertificateFactory()\n- expected = UserCredentialFactory.create_batch(3, credential=program_certificate)\n+ expected = UserCredentialFactory.create_batch(3, credential=self.current_site_program_certificate)","path":"credentials/apps/api/v2/tests/test_views.py","position":87,"original_position":87,"commit_id":"a583cc76b8e438f5ff24c2f2e41484066ce7428f","original_commit_id":"a583cc76b8e438f5ff24c2f2e41484066ce7428f","user":{"login":"clintonb","id":910510,"avatar_url":"https://avatars3.githubusercontent.com/u/910510?v=3","gravatar_id":"","url":"https://api.github.com/users/clintonb","html_url":"https://github.com/clintonb","followers_url":"https://api.github.com/users/clintonb/followers","following_url":"https://api.github.com/users/clintonb/following{/other_user}","gists_url":"https://api.github.com/users/clintonb/gists{/gist_id}","starred_url":"https://api.github.com/users/clintonb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clintonb/subscriptions","organizations_url":"https://api.github.com/users/clintonb/orgs","repos_url":"https://api.github.com/users/clintonb/repos","events_url":"https://api.github.com/users/clintonb/events{/privacy}","received_events_url":"https://api.github.com/users/clintonb/received_events","type":"User","site_admin":false},"body":"Revert, and modify `program_certificate`.","created_at":"2017-03-06T13:19:17Z","updated_at":"2017-03-06T13:29:07Z","html_url":"https://github.com/edx/credentials/pull/179#discussion_r104410939","pull_request_url":"https://api.github.com/repos/edx/credentials/pulls/179","_links":{"self":{"href":"https://api.github.com/repos/edx/credentials/pulls/comments/104410939"},"html":{"href":"https://github.com/edx/credentials/pull/179#discussion_r104410939"},"pull_request":{"href":"https://api.github.com/repos/edx/credentials/pulls/179"}}},"pull_request":{"url":"https://api.github.com/repos/edx/credentials/pulls/179","id":109221175,"html_url":"https://github.com/edx/credentials/pull/179","diff_url":"https://github.com/edx/credentials/pull/179.diff","patch_url":"https://github.com/edx/credentials/pull/179.patch","issue_url":"https://api.github.com/repos/edx/credentials/issues/179","number":179,"state":"open","locked":false,"title":"[WIP] [ECOM-7345] User Credential API endpoint should be site aware","user":{"login":"marjev","id":6833568,"avatar_url":"https://avatars2.githubusercontent.com/u/6833568?v=3","gravatar_id":"","url":"https://api.github.com/users/marjev","html_url":"https://github.com/marjev","followers_url":"https://api.github.com/users/marjev/followers","following_url":"https://api.github.com/users/marjev/following{/other_user}","gists_url":"https://api.github.com/users/marjev/gists{/gist_id}","starred_url":"https://api.github.com/users/marjev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marjev/subscriptions","organizations_url":"https://api.github.com/users/marjev/orgs","repos_url":"https://api.github.com/users/marjev/repos","events_url":"https://api.github.com/users/marjev/events{/privacy}","received_events_url":"https://api.github.com/users/marjev/received_events","type":"User","site_admin":false},"body":"@mjfrey @vkaracic @iivic This is the PR for making the User Credential API endpoint (WL) site aware.\r\n\r\nThe only reason this is marked as WIP is the fact that we still don't know to what extent should the endpoint be site-aware. I made it absolutely site-aware, which means that it doesn't matter which user sends the request to the endpoint, but from which Site the request is being sent from.\r\nIf we decide to remove the Site awareness for a specific use case, this PR can easily be modified.\r\n\r\nJIRA ticket: https://openedx.atlassian.net/browse/ECOM-7345","created_at":"2017-03-06T09:45:42Z","updated_at":"2017-03-06T13:29:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a256572d65f374d986db6ba06042376c283852bb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/credentials/pulls/179/commits","review_comments_url":"https://api.github.com/repos/edx/credentials/pulls/179/comments","review_comment_url":"https://api.github.com/repos/edx/credentials/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/credentials/issues/179/comments","statuses_url":"https://api.github.com/repos/edx/credentials/statuses/a583cc76b8e438f5ff24c2f2e41484066ce7428f","head":{"label":"edx:mjevtic/ECOM-7345","ref":"mjevtic/ECOM-7345","sha":"a583cc76b8e438f5ff24c2f2e41484066ce7428f","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":47830104,"name":"credentials","full_name":"edx/credentials","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/credentials","description":"Django application used as the backend to support Course or Program based credentials.","fork":false,"url":"https://api.github.com/repos/edx/credentials","forks_url":"https://api.github.com/repos/edx/credentials/forks","keys_url":"https://api.github.com/repos/edx/credentials/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/credentials/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/credentials/teams","hooks_url":"https://api.github.com/repos/edx/credentials/hooks","issue_events_url":"https://api.github.com/repos/edx/credentials/issues/events{/number}","events_url":"https://api.github.com/repos/edx/credentials/events","assignees_url":"https://api.github.com/repos/edx/credentials/assignees{/user}","branches_url":"https://api.github.com/repos/edx/credentials/branches{/branch}","tags_url":"https://api.github.com/repos/edx/credentials/tags","blobs_url":"https://api.github.com/repos/edx/credentials/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/credentials/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/credentials/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/credentials/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/credentials/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/credentials/languages","stargazers_url":"https://api.github.com/repos/edx/credentials/stargazers","contributors_url":"https://api.github.com/repos/edx/credentials/contributors","subscribers_url":"https://api.github.com/repos/edx/credentials/subscribers","subscription_url":"https://api.github.com/repos/edx/credentials/subscription","commits_url":"https://api.github.com/repos/edx/credentials/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/credentials/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/credentials/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/credentials/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/credentials/contents/{+path}","compare_url":"https://api.github.com/repos/edx/credentials/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/credentials/merges","archive_url":"https://api.github.com/repos/edx/credentials/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/credentials/downloads","issues_url":"https://api.github.com/repos/edx/credentials/issues{/number}","pulls_url":"https://api.github.com/repos/edx/credentials/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/credentials/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/credentials/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/credentials/labels{/name}","releases_url":"https://api.github.com/repos/edx/credentials/releases{/id}","deployments_url":"https://api.github.com/repos/edx/credentials/deployments","created_at":"2015-12-11T14:09:03Z","updated_at":"2017-02-21T18:00:45Z","pushed_at":"2017-03-06T12:29:43Z","git_url":"git://github.com/edx/credentials.git","ssh_url":"[email protected]:edx/credentials.git","clone_url":"https://github.com/edx/credentials.git","svn_url":"https://github.com/edx/credentials","homepage":"http://open-edx-credentials-guide.readthedocs.org/en/latest/ ","size":3016,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"db2e32f7a972ae72284e5fee5c6f4cd16009995e","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":47830104,"name":"credentials","full_name":"edx/credentials","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/credentials","description":"Django application used as the backend to support Course or Program based credentials.","fork":false,"url":"https://api.github.com/repos/edx/credentials","forks_url":"https://api.github.com/repos/edx/credentials/forks","keys_url":"https://api.github.com/repos/edx/credentials/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/credentials/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/credentials/teams","hooks_url":"https://api.github.com/repos/edx/credentials/hooks","issue_events_url":"https://api.github.com/repos/edx/credentials/issues/events{/number}","events_url":"https://api.github.com/repos/edx/credentials/events","assignees_url":"https://api.github.com/repos/edx/credentials/assignees{/user}","branches_url":"https://api.github.com/repos/edx/credentials/branches{/branch}","tags_url":"https://api.github.com/repos/edx/credentials/tags","blobs_url":"https://api.github.com/repos/edx/credentials/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/credentials/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/credentials/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/credentials/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/credentials/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/credentials/languages","stargazers_url":"https://api.github.com/repos/edx/credentials/stargazers","contributors_url":"https://api.github.com/repos/edx/credentials/contributors","subscribers_url":"https://api.github.com/repos/edx/credentials/subscribers","subscription_url":"https://api.github.com/repos/edx/credentials/subscription","commits_url":"https://api.github.com/repos/edx/credentials/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/credentials/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/credentials/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/credentials/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/credentials/contents/{+path}","compare_url":"https://api.github.com/repos/edx/credentials/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/credentials/merges","archive_url":"https://api.github.com/repos/edx/credentials/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/credentials/downloads","issues_url":"https://api.github.com/repos/edx/credentials/issues{/number}","pulls_url":"https://api.github.com/repos/edx/credentials/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/credentials/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/credentials/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/credentials/labels{/name}","releases_url":"https://api.github.com/repos/edx/credentials/releases{/id}","deployments_url":"https://api.github.com/repos/edx/credentials/deployments","created_at":"2015-12-11T14:09:03Z","updated_at":"2017-02-21T18:00:45Z","pushed_at":"2017-03-06T12:29:43Z","git_url":"git://github.com/edx/credentials.git","ssh_url":"[email protected]:edx/credentials.git","clone_url":"https://github.com/edx/credentials.git","svn_url":"https://github.com/edx/credentials","homepage":"http://open-edx-credentials-guide.readthedocs.org/en/latest/ ","size":3016,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/credentials/pulls/179"},"html":{"href":"https://github.com/edx/credentials/pull/179"},"issue":{"href":"https://api.github.com/repos/edx/credentials/issues/179"},"comments":{"href":"https://api.github.com/repos/edx/credentials/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/credentials/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/credentials/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/credentials/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/edx/credentials/statuses/a583cc76b8e438f5ff24c2f2e41484066ce7428f"}}}} | {
"id": 47830104,
"name": "edx/credentials",
"url": "https://api.github.com/repos/edx/credentials"
} | {
"id": 910510,
"login": "clintonb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/910510?",
"url": "https://api.github.com/users/clintonb"
} | {
"id": 3179841,
"login": "edx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3179841?",
"url": "https://api.github.com/orgs/edx"
} | 2017-03-06T13:19:17 | 5439444054 | {"actor":{"display_login":"clintonb"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/125738083","pull_request_review_id":48157107,"id":125738083,"diff_hunk":"@@ -293,7 +293,10 @@ class CourseFields(object):\n '{\"id\": \"i4x-InstitutionName-CourseNumber-course-CourseRun\"}. For example, one discussion '\n 'category may be \"Lydian Mode\": {\"id\": \"i4x-UniversityX-MUS101-course-2015_T1\"}. The \"id\" '\n 'value for each category must be unique. In \"id\" values, the only special characters that are '\n- 'supported are underscore, hyphen, and period.'\n+ 'supported are underscore, hyphen, and period. You can also specify a CategoryName as the default '","path":"common/lib/xmodule/xmodule/course_module.py","position":5,"original_position":5,"commit_id":"bd5e89466a3640aca1e6db80c26d7b742c2c263c","original_commit_id":"bd5e89466a3640aca1e6db80c26d7b742c2c263c","user":{"login":"cahrens","id":484484,"avatar_url":"https://avatars2.githubusercontent.com/u/484484?v=3","gravatar_id":"","url":"https://api.github.com/users/cahrens","html_url":"https://github.com/cahrens","followers_url":"https://api.github.com/users/cahrens/followers","following_url":"https://api.github.com/users/cahrens/following{/other_user}","gists_url":"https://api.github.com/users/cahrens/gists{/gist_id}","starred_url":"https://api.github.com/users/cahrens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cahrens/subscriptions","organizations_url":"https://api.github.com/users/cahrens/orgs","repos_url":"https://api.github.com/users/cahrens/repos","events_url":"https://api.github.com/users/cahrens/events{/privacy}","received_events_url":"https://api.github.com/users/cahrens/received_events","type":"User","site_admin":false},"body":"@srpearce Are you OK with the usage of \"CategoryName\" here? I think it might read better as \"You can also specify a category as the default...\".","created_at":"2017-07-05T19:39:32Z","updated_at":"2017-07-05T19:39:32Z","html_url":"https://github.com/edx/edx-platform/pull/14862#discussion_r125738083","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/14862","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/125738083"},"html":{"href":"https://github.com/edx/edx-platform/pull/14862#discussion_r125738083"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/14862"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/14862","id":115416400,"html_url":"https://github.com/edx/edx-platform/pull/14862","diff_url":"https://github.com/edx/edx-platform/pull/14862.diff","patch_url":"https://github.com/edx/edx-platform/pull/14862.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/14862","number":14862,"state":"open","locked":false,"title":"Default discussion topic","user":{"login":"replaceafill","id":560781,"avatar_url":"https://avatars1.githubusercontent.com/u/560781?v=3","gravatar_id":"","url":"https://api.github.com/users/replaceafill","html_url":"https://github.com/replaceafill","followers_url":"https://api.github.com/users/replaceafill/followers","following_url":"https://api.github.com/users/replaceafill/following{/other_user}","gists_url":"https://api.github.com/users/replaceafill/gists{/gist_id}","starred_url":"https://api.github.com/users/replaceafill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/replaceafill/subscriptions","organizations_url":"https://api.github.com/users/replaceafill/orgs","repos_url":"https://api.github.com/users/replaceafill/repos","events_url":"https://api.github.com/users/replaceafill/events{/privacy}","received_events_url":"https://api.github.com/users/replaceafill/received_events","type":"User","site_admin":false},"body":"This PR adds the ability to configure the default topic for new posts in the Discussion tab by setting a new attribute in the Discussion Topic Mapping field.\r\n\r\n[Corresponding documentation PR](https://github.com/edx/edx-documentation/pull/1488)\r\n\r\n**Dependencies**: None\r\n\r\n**Screenshots**:\r\n\r\n\r\n\r\n\r\n**Sandbox URL**:\r\n\r\nLMS: https://oc2476.sandbox.opencraft.hosting/\r\nStudio: https://studio-oc2476.sandbox.opencraft.hosting/\r\n\r\n**Partner information**: 3rd party-hosted open edX instance\r\n\r\n**Deployment targets**: edx.org and edge.edx.org\r\n\r\n**Merge deadline**: None\r\n\r\n**Testing instructions**:\r\n\r\n1. In Studio go to the demo course advanced settings.\r\n2. Add a new category to the Discussion Topic Mapping with a \"default\" attribute set to true. For example:\r\n\r\n```json\r\n\"Custom\": {\r\n \"id\": \"custom\",\r\n \"default\": true\r\n}\r\n```\r\n\r\n3. Save the changes\r\n4. In the LMS go to the demo course Discussion tab.\r\n5. Add a new post and check that the Topic area default value matches the setting.\r\n\r\n**Author notes and concerns**:\r\n\r\nWe tried to add a JS spec test for the DiscussionBoardFactory change, but the DiscussionRouter interferes with the history of other spec tests. That's the reason why [the current test for the factory is disabled](https://github.com/replaceafill/edx-platform/blob/bfbc3241b396ec9591674983c176839cb6f46aeb/lms/djangoapps/discussion/static/discussion/js/spec/discussion_board_factory_spec.js#L66). \r\n\r\n**Reviewers**\r\n- [ ] @pomegranited \r\n- [ ] @bdero ","created_at":"2017-04-11T21:14:21Z","updated_at":"2017-07-05T19:39:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9806a03f762073d2e33598f5b48311f104c7c805","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/14862/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/14862/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/14862/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/bd5e89466a3640aca1e6db80c26d7b742c2c263c","head":{"label":"replaceafill:default_discussion_topic","ref":"default_discussion_topic","sha":"bd5e89466a3640aca1e6db80c26d7b742c2c263c","user":{"login":"replaceafill","id":560781,"avatar_url":"https://avatars1.githubusercontent.com/u/560781?v=3","gravatar_id":"","url":"https://api.github.com/users/replaceafill","html_url":"https://github.com/replaceafill","followers_url":"https://api.github.com/users/replaceafill/followers","following_url":"https://api.github.com/users/replaceafill/following{/other_user}","gists_url":"https://api.github.com/users/replaceafill/gists{/gist_id}","starred_url":"https://api.github.com/users/replaceafill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/replaceafill/subscriptions","organizations_url":"https://api.github.com/users/replaceafill/orgs","repos_url":"https://api.github.com/users/replaceafill/repos","events_url":"https://api.github.com/users/replaceafill/events{/privacy}","received_events_url":"https://api.github.com/users/replaceafill/received_events","type":"User","site_admin":false},"repo":{"id":87763829,"name":"edx-platform","full_name":"replaceafill/edx-platform","owner":{"login":"replaceafill","id":560781,"avatar_url":"https://avatars1.githubusercontent.com/u/560781?v=3","gravatar_id":"","url":"https://api.github.com/users/replaceafill","html_url":"https://github.com/replaceafill","followers_url":"https://api.github.com/users/replaceafill/followers","following_url":"https://api.github.com/users/replaceafill/following{/other_user}","gists_url":"https://api.github.com/users/replaceafill/gists{/gist_id}","starred_url":"https://api.github.com/users/replaceafill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/replaceafill/subscriptions","organizations_url":"https://api.github.com/users/replaceafill/orgs","repos_url":"https://api.github.com/users/replaceafill/repos","events_url":"https://api.github.com/users/replaceafill/events{/privacy}","received_events_url":"https://api.github.com/users/replaceafill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/replaceafill/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":true,"url":"https://api.github.com/repos/replaceafill/edx-platform","forks_url":"https://api.github.com/repos/replaceafill/edx-platform/forks","keys_url":"https://api.github.com/repos/replaceafill/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/replaceafill/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/replaceafill/edx-platform/teams","hooks_url":"https://api.github.com/repos/replaceafill/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/replaceafill/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/replaceafill/edx-platform/events","assignees_url":"https://api.github.com/repos/replaceafill/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/replaceafill/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/replaceafill/edx-platform/tags","blobs_url":"https://api.github.com/repos/replaceafill/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/replaceafill/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/replaceafill/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/replaceafill/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/replaceafill/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/replaceafill/edx-platform/languages","stargazers_url":"https://api.github.com/repos/replaceafill/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/replaceafill/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/replaceafill/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/replaceafill/edx-platform/subscription","commits_url":"https://api.github.com/repos/replaceafill/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/replaceafill/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/replaceafill/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/replaceafill/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/replaceafill/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/replaceafill/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/replaceafill/edx-platform/merges","archive_url":"https://api.github.com/repos/replaceafill/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/replaceafill/edx-platform/downloads","issues_url":"https://api.github.com/repos/replaceafill/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/replaceafill/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/replaceafill/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/replaceafill/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/replaceafill/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/replaceafill/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/replaceafill/edx-platform/deployments","created_at":"2017-04-10T03:45:15Z","updated_at":"2017-04-10T03:45:51Z","pushed_at":"2017-06-19T01:58:08Z","git_url":"git://github.com/replaceafill/edx-platform.git","ssh_url":"[email protected]:replaceafill/edx-platform.git","clone_url":"https://github.com/replaceafill/edx-platform.git","svn_url":"https://github.com/replaceafill/edx-platform","homepage":"http://open.edx.org/","size":817842,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"1592ee2b152dc226039fa2665374702cb7e01508","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2017-07-05T17:23:48Z","pushed_at":"2017-07-05T19:39:02Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"[email protected]:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":822200,"stargazers_count":3200,"watchers_count":3200,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1853,"mirror_url":null,"open_issues_count":178,"forks":1853,"open_issues":178,"watchers":3200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/14862"},"html":{"href":"https://github.com/edx/edx-platform/pull/14862"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/14862"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/14862/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/14862/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/14862/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/bd5e89466a3640aca1e6db80c26d7b742c2c263c"}}}} | {
"id": 10391073,
"name": "edx/edx-platform",
"url": "https://api.github.com/repos/edx/edx-platform"
} | {
"id": 484484,
"login": "cahrens",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/484484?",
"url": "https://api.github.com/users/cahrens"
} | {
"id": 3179841,
"login": "edx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3179841?",
"url": "https://api.github.com/orgs/edx"
} | 2017-07-05T19:39:32 | 6198642607 | {"actor":{"display_login":"cahrens"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/117831738","pull_request_review_id":39571098,"id":117831738,"diff_hunk":"@@ -155,11 +155,31 @@\n </div>\n % endif\n <section class=\"course-content\" id=\"course-content\">\n+ <header class=\"page-header has-secondary\">\n+ <div class=\"page-header-main\">\n+ <nav aria-label=\"${_('Course navigation')}\" class=\"sr-is-focusable\" tabindex=\"-1\">\n+ <div class=\"has-breadcrumbs\">\n+ <div class=\"breadcrumbs\">\n+ <span class=\"nav-item\">\n+ <a href=\"${course_url}\">${_('Course')}</a>\n+ </span>\n+ % if chapter:\n+ <span class=\"icon fa fa-angle-right\" aria-hidden=\"true\"></span>\n+ <span class=\"nav-item\">\n+ <a href=\"/courses/course-v1:edX+DemoX+Demo_Course/course/#${unicode(chapter.location)}\">${chapter.display_name}</a>\n+ </span>\n+ % endif\n+ % if section:\n+ <span class=\"icon fa fa-angle-right\" aria-hidden=\"true\"></span>\n+ <span class=\"nav-item nav-item-unit\">${section.display_name}</span>\n+ % endif\n+ </div>\n+ </div>\n+ </nav>\n+ </div>\n+ </header>\n+\n <main id=\"main\" tabindex=\"-1\" aria-label=\"Content\">\n- <div\n- class=\"path\"\n- data-unified-course-view=\"${'true' if waffle.flag_is_active(request, UNIFIED_COURSE_VIEW_FLAG) else 'false'}\"","path":"lms/templates/courseware/courseware.html","position":40,"original_position":40,"commit_id":"034091609d0ca29ae12ff91144c27eb33b2dce46","original_commit_id":"94970fa872bf90a397f7108039e46fb0be0a04a3","user":{"login":"andy-armstrong","id":5985072,"avatar_url":"https://avatars0.githubusercontent.com/u/5985072?v=3","gravatar_id":"","url":"https://api.github.com/users/andy-armstrong","html_url":"https://github.com/andy-armstrong","followers_url":"https://api.github.com/users/andy-armstrong/followers","following_url":"https://api.github.com/users/andy-armstrong/following{/other_user}","gists_url":"https://api.github.com/users/andy-armstrong/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-armstrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-armstrong/subscriptions","organizations_url":"https://api.github.com/users/andy-armstrong/orgs","repos_url":"https://api.github.com/users/andy-armstrong/repos","events_url":"https://api.github.com/users/andy-armstrong/events{/privacy}","received_events_url":"https://api.github.com/users/andy-armstrong/received_events","type":"User","site_admin":false},"body":"Nice catch. I've added this back.","created_at":"2017-05-22T19:56:36Z","updated_at":"2017-05-22T19:56:36Z","html_url":"https://github.com/edx/edx-platform/pull/15143#discussion_r117831738","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/15143","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/117831738"},"html":{"href":"https://github.com/edx/edx-platform/pull/15143#discussion_r117831738"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/15143"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/15143","id":121197027,"html_url":"https://github.com/edx/edx-platform/pull/15143","diff_url":"https://github.com/edx/edx-platform/pull/15143.diff","patch_url":"https://github.com/edx/edx-platform/pull/15143.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/15143","number":15143,"state":"open","locked":false,"title":"Improve course breadcrumbs","user":{"login":"andy-armstrong","id":5985072,"avatar_url":"https://avatars0.githubusercontent.com/u/5985072?v=3","gravatar_id":"","url":"https://api.github.com/users/andy-armstrong","html_url":"https://github.com/andy-armstrong","followers_url":"https://api.github.com/users/andy-armstrong/followers","following_url":"https://api.github.com/users/andy-armstrong/following{/other_user}","gists_url":"https://api.github.com/users/andy-armstrong/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-armstrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-armstrong/subscriptions","organizations_url":"https://api.github.com/users/andy-armstrong/orgs","repos_url":"https://api.github.com/users/andy-armstrong/repos","events_url":"https://api.github.com/users/andy-armstrong/events{/privacy}","received_events_url":"https://api.github.com/users/andy-armstrong/received_events","type":"User","site_admin":false},"body":"## [LEARNER-877](https://openedx.atlassian.net/browse/LEARNER-877)\r\n\r\n### Description\r\n\r\nhttps://openedx.atlassian.net/browse/LEARNER-877\r\n\r\nThis change improves the breadcrumbs shown at the top of a course. Now each individual breadcrumb item is a link (except for the last one) as shown in this screenshot:\r\n\r\n\r\n\r\n### Sandbox\r\n- [ ] https://andy-armstrong.sandbox.edx.org/courses/course-v1:edX+DemoX+Demo_Course/course/\r\n\r\nNote: staff has the unified course/home experience, non-staff do not.\r\n\r\n### Testing\r\n- [ ] i18n\r\n- [ ] RTL\r\n- [ ] safecommit violation code review process\r\n- [ ] Unit, integration, acceptance tests as appropriate\r\n\r\nFYI: @lizcohen @marcotuts @catong \r\n\r\n### Post-review\r\n- [ ] Rebase and squash commits","created_at":"2017-05-18T04:03:45Z","updated_at":"2017-05-22T19:56:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cec2e102c83dbc4b4feca44d6d4afee94a06c933","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/15143/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/15143/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/15143/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/034091609d0ca29ae12ff91144c27eb33b2dce46","head":{"label":"edx:andya/breadcrumb-improvements","ref":"andya/breadcrumb-improvements","sha":"034091609d0ca29ae12ff91144c27eb33b2dce46","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2017-05-22T14:48:03Z","pushed_at":"2017-05-22T19:54:48Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"[email protected]:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":816478,"stargazers_count":3143,"watchers_count":3143,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1825,"mirror_url":null,"open_issues_count":185,"forks":1825,"open_issues":185,"watchers":3143,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"78d889588003458d40050ec5228d553a6be83861","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2017-05-22T14:48:03Z","pushed_at":"2017-05-22T19:54:48Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"[email protected]:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":816478,"stargazers_count":3143,"watchers_count":3143,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1825,"mirror_url":null,"open_issues_count":185,"forks":1825,"open_issues":185,"watchers":3143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/15143"},"html":{"href":"https://github.com/edx/edx-platform/pull/15143"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/15143"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/15143/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/15143/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/15143/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/034091609d0ca29ae12ff91144c27eb33b2dce46"}}}} | {
"id": 10391073,
"name": "edx/edx-platform",
"url": "https://api.github.com/repos/edx/edx-platform"
} | {
"id": 5985072,
"login": "andy-armstrong",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5985072?",
"url": "https://api.github.com/users/andy-armstrong"
} | {
"id": 3179841,
"login": "edx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3179841?",
"url": "https://api.github.com/orgs/edx"
} | 2017-05-22T19:56:36 | 5920302026 | {"actor":{"display_login":"andy-armstrong"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/edx/ecommerce/pulls/comments/125310446","pull_request_review_id":47686310,"id":125310446,"diff_hunk":"@@ -113,3 +111,15 @@ def test_create_basket(self):\n basket = Basket.create_basket(self.site1, user)\n self.assertEqual(basket.site, self.site1)\n self.assertEqual(basket.owner, user)\n+\n+ def test_add_product(self):\n+ \"\"\" Verify the method fires Product Added analytic event when a product\n+ is added to the basket \"\"\"","path":"ecommerce/extensions/basket/tests/test_models.py","position":82,"original_position":82,"commit_id":"60d18046939fcf94fcb0251cd1d826585d4900d1","original_commit_id":"60d18046939fcf94fcb0251cd1d826585d4900d1","user":{"login":"marjev","id":6833568,"avatar_url":"https://avatars2.githubusercontent.com/u/6833568?v=3","gravatar_id":"","url":"https://api.github.com/users/marjev","html_url":"https://github.com/marjev","followers_url":"https://api.github.com/users/marjev/followers","following_url":"https://api.github.com/users/marjev/following{/other_user}","gists_url":"https://api.github.com/users/marjev/gists{/gist_id}","starred_url":"https://api.github.com/users/marjev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marjev/subscriptions","organizations_url":"https://api.github.com/users/marjev/orgs","repos_url":"https://api.github.com/users/marjev/repos","events_url":"https://api.github.com/users/marjev/events{/privacy}","received_events_url":"https://api.github.com/users/marjev/received_events","type":"User","site_admin":false},"body":"I think this docstring can fit in a single line. I think we allow 120 characters per line.","created_at":"2017-07-03T15:07:39Z","updated_at":"2017-07-03T15:09:06Z","html_url":"https://github.com/edx/ecommerce/pull/1369#discussion_r125310446","pull_request_url":"https://api.github.com/repos/edx/ecommerce/pulls/1369","_links":{"self":{"href":"https://api.github.com/repos/edx/ecommerce/pulls/comments/125310446"},"html":{"href":"https://github.com/edx/ecommerce/pull/1369#discussion_r125310446"},"pull_request":{"href":"https://api.github.com/repos/edx/ecommerce/pulls/1369"}}},"pull_request":{"url":"https://api.github.com/repos/edx/ecommerce/pulls/1369","id":128639622,"html_url":"https://github.com/edx/ecommerce/pull/1369","diff_url":"https://github.com/edx/ecommerce/pull/1369.diff","patch_url":"https://github.com/edx/ecommerce/pull/1369.patch","issue_url":"https://api.github.com/repos/edx/ecommerce/issues/1369","number":1369,"state":"open","locked":false,"title":"Fire Product Added event when item added to basket","user":{"login":"McKenzieW","id":10751012,"avatar_url":"https://avatars1.githubusercontent.com/u/10751012?v=3","gravatar_id":"","url":"https://api.github.com/users/McKenzieW","html_url":"https://github.com/McKenzieW","followers_url":"https://api.github.com/users/McKenzieW/followers","following_url":"https://api.github.com/users/McKenzieW/following{/other_user}","gists_url":"https://api.github.com/users/McKenzieW/gists{/gist_id}","starred_url":"https://api.github.com/users/McKenzieW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McKenzieW/subscriptions","organizations_url":"https://api.github.com/users/McKenzieW/orgs","repos_url":"https://api.github.com/users/McKenzieW/repos","events_url":"https://api.github.com/users/McKenzieW/events{/privacy}","received_events_url":"https://api.github.com/users/McKenzieW/received_events","type":"User","site_admin":false},"body":"Updated Basket model add_product method to include a call to the Google Analytics \"Product Added\" event.\r\n\r\nLEARNER-1566","created_at":"2017-07-03T14:22:39Z","updated_at":"2017-07-03T15:09:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bfe95e9976e90b82aa620b741a28cd311ac747b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/ecommerce/pulls/1369/commits","review_comments_url":"https://api.github.com/repos/edx/ecommerce/pulls/1369/comments","review_comment_url":"https://api.github.com/repos/edx/ecommerce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/ecommerce/issues/1369/comments","statuses_url":"https://api.github.com/repos/edx/ecommerce/statuses/60d18046939fcf94fcb0251cd1d826585d4900d1","head":{"label":"edx:McKenzieW/LEARNER-1566","ref":"McKenzieW/LEARNER-1566","sha":"60d18046939fcf94fcb0251cd1d826585d4900d1","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":30175039,"name":"ecommerce","full_name":"edx/ecommerce","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/ecommerce","description":"Service for managing edX's product catalog and handling orders for those products","fork":false,"url":"https://api.github.com/repos/edx/ecommerce","forks_url":"https://api.github.com/repos/edx/ecommerce/forks","keys_url":"https://api.github.com/repos/edx/ecommerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/ecommerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/ecommerce/teams","hooks_url":"https://api.github.com/repos/edx/ecommerce/hooks","issue_events_url":"https://api.github.com/repos/edx/ecommerce/issues/events{/number}","events_url":"https://api.github.com/repos/edx/ecommerce/events","assignees_url":"https://api.github.com/repos/edx/ecommerce/assignees{/user}","branches_url":"https://api.github.com/repos/edx/ecommerce/branches{/branch}","tags_url":"https://api.github.com/repos/edx/ecommerce/tags","blobs_url":"https://api.github.com/repos/edx/ecommerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/ecommerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/ecommerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/ecommerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/ecommerce/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/ecommerce/languages","stargazers_url":"https://api.github.com/repos/edx/ecommerce/stargazers","contributors_url":"https://api.github.com/repos/edx/ecommerce/contributors","subscribers_url":"https://api.github.com/repos/edx/ecommerce/subscribers","subscription_url":"https://api.github.com/repos/edx/ecommerce/subscription","commits_url":"https://api.github.com/repos/edx/ecommerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/ecommerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/ecommerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/ecommerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/ecommerce/contents/{+path}","compare_url":"https://api.github.com/repos/edx/ecommerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/ecommerce/merges","archive_url":"https://api.github.com/repos/edx/ecommerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/ecommerce/downloads","issues_url":"https://api.github.com/repos/edx/ecommerce/issues{/number}","pulls_url":"https://api.github.com/repos/edx/ecommerce/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/ecommerce/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/ecommerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/ecommerce/labels{/name}","releases_url":"https://api.github.com/repos/edx/ecommerce/releases{/id}","deployments_url":"https://api.github.com/repos/edx/ecommerce/deployments","created_at":"2015-02-02T06:55:15Z","updated_at":"2017-05-30T14:16:44Z","pushed_at":"2017-07-03T14:26:15Z","git_url":"git://github.com/edx/ecommerce.git","ssh_url":"[email protected]:edx/ecommerce.git","clone_url":"https://github.com/edx/ecommerce.git","svn_url":"https://github.com/edx/ecommerce","homepage":"","size":9048,"stargazers_count":56,"watchers_count":56,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":9,"forks":58,"open_issues":9,"watchers":56,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"07e8c50b6933d1abcdc4840671a21a934335a9fd","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":30175039,"name":"ecommerce","full_name":"edx/ecommerce","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/ecommerce","description":"Service for managing edX's product catalog and handling orders for those products","fork":false,"url":"https://api.github.com/repos/edx/ecommerce","forks_url":"https://api.github.com/repos/edx/ecommerce/forks","keys_url":"https://api.github.com/repos/edx/ecommerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/ecommerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/ecommerce/teams","hooks_url":"https://api.github.com/repos/edx/ecommerce/hooks","issue_events_url":"https://api.github.com/repos/edx/ecommerce/issues/events{/number}","events_url":"https://api.github.com/repos/edx/ecommerce/events","assignees_url":"https://api.github.com/repos/edx/ecommerce/assignees{/user}","branches_url":"https://api.github.com/repos/edx/ecommerce/branches{/branch}","tags_url":"https://api.github.com/repos/edx/ecommerce/tags","blobs_url":"https://api.github.com/repos/edx/ecommerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/ecommerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/ecommerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/ecommerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/ecommerce/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/ecommerce/languages","stargazers_url":"https://api.github.com/repos/edx/ecommerce/stargazers","contributors_url":"https://api.github.com/repos/edx/ecommerce/contributors","subscribers_url":"https://api.github.com/repos/edx/ecommerce/subscribers","subscription_url":"https://api.github.com/repos/edx/ecommerce/subscription","commits_url":"https://api.github.com/repos/edx/ecommerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/ecommerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/ecommerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/ecommerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/ecommerce/contents/{+path}","compare_url":"https://api.github.com/repos/edx/ecommerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/ecommerce/merges","archive_url":"https://api.github.com/repos/edx/ecommerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/ecommerce/downloads","issues_url":"https://api.github.com/repos/edx/ecommerce/issues{/number}","pulls_url":"https://api.github.com/repos/edx/ecommerce/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/ecommerce/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/ecommerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/ecommerce/labels{/name}","releases_url":"https://api.github.com/repos/edx/ecommerce/releases{/id}","deployments_url":"https://api.github.com/repos/edx/ecommerce/deployments","created_at":"2015-02-02T06:55:15Z","updated_at":"2017-05-30T14:16:44Z","pushed_at":"2017-07-03T14:26:15Z","git_url":"git://github.com/edx/ecommerce.git","ssh_url":"[email protected]:edx/ecommerce.git","clone_url":"https://github.com/edx/ecommerce.git","svn_url":"https://github.com/edx/ecommerce","homepage":"","size":9048,"stargazers_count":56,"watchers_count":56,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":9,"forks":58,"open_issues":9,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/ecommerce/pulls/1369"},"html":{"href":"https://github.com/edx/ecommerce/pull/1369"},"issue":{"href":"https://api.github.com/repos/edx/ecommerce/issues/1369"},"comments":{"href":"https://api.github.com/repos/edx/ecommerce/issues/1369/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/ecommerce/pulls/1369/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/ecommerce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/ecommerce/pulls/1369/commits"},"statuses":{"href":"https://api.github.com/repos/edx/ecommerce/statuses/60d18046939fcf94fcb0251cd1d826585d4900d1"}}}} | {
"id": 30175039,
"name": "edx/ecommerce",
"url": "https://api.github.com/repos/edx/ecommerce"
} | {
"id": 6833568,
"login": "marjev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6833568?",
"url": "https://api.github.com/users/marjev"
} | {
"id": 3179841,
"login": "edx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3179841?",
"url": "https://api.github.com/orgs/edx"
} | 2017-07-03T15:07:39 | 6183701242 | {"actor":{"display_login":"marjev"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/g0v/itaigi/pulls/comments/158930745","pull_request_review_id":85805118,"id":158930745,"diff_hunk":"@@ -0,0 +1,54 @@\n+import React from 'react';\n+import Debug from 'debug';\n+import { browserHistory } from 'react-router';\n+\n+var debug = Debug('itaigi:複製連結鍵');\n+\n+export default class 複製連結鍵 extends React.Component {\n+ constructor(props) {\n+ super(props);\n+ }\n+\n+ getCurrentLocation() {\n+ let routerPathname = browserHistory.getCurrentLocation().pathname;\n+ let { pathname } = this.props;\n+\n+ pathname = pathname || routerPathname || '';\n+\n+ if (pathname[0] === '/') {\n+ pathname = pathname.substr(1);\n+ }\n+\n+ pathname = encodeURIComponent(decodeURIComponent(pathname));\n+\n+ return pathname;\n+ }\n+\n+ handleClick() {\n+ var textField = document.createElement('textarea');\n+ textField.innerText = decodeURIComponent(window.location.href);\n+ document.body.appendChild(textField);\n+ textField.select();\n+ document.execCommand('copy');\n+ textField.remove();\n+ alert('連結已複製,趕緊轉貼分享吧!');\n+ }\n+\n+ render() {\n+ let { size } = this.props;\n+ let pathname = this.getCurrentLocation();","path":"src/GuanKiann/複製連結鍵/複製連結鍵.jsx","position":39,"original_position":39,"commit_id":"aa8b22abfc046fc335c5954b471bc6622ef16a76","original_commit_id":"aa8b22abfc046fc335c5954b471bc6622ef16a76","user":{"login":"sih4sing5hong5","id":5996555,"avatar_url":"https://avatars3.githubusercontent.com/u/5996555?v=4","gravatar_id":"","url":"https://api.github.com/users/sih4sing5hong5","html_url":"https://github.com/sih4sing5hong5","followers_url":"https://api.github.com/users/sih4sing5hong5/followers","following_url":"https://api.github.com/users/sih4sing5hong5/following{/other_user}","gists_url":"https://api.github.com/users/sih4sing5hong5/gists{/gist_id}","starred_url":"https://api.github.com/users/sih4sing5hong5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sih4sing5hong5/subscriptions","organizations_url":"https://api.github.com/users/sih4sing5hong5/orgs","repos_url":"https://api.github.com/users/sih4sing5hong5/repos","events_url":"https://api.github.com/users/sih4sing5hong5/events{/privacy}","received_events_url":"https://api.github.com/users/sih4sing5hong5/received_events","type":"User","site_admin":false},"body":"pathname上尾無用著?","created_at":"2017-12-28T11:22:00Z","updated_at":"2017-12-28T11:23:26Z","html_url":"https://github.com/g0v/itaigi/pull/456#discussion_r158930745","pull_request_url":"https://api.github.com/repos/g0v/itaigi/pulls/456","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/g0v/itaigi/pulls/comments/158930745"},"html":{"href":"https://github.com/g0v/itaigi/pull/456#discussion_r158930745"},"pull_request":{"href":"https://api.github.com/repos/g0v/itaigi/pulls/456"}}},"pull_request":{"url":"https://api.github.com/repos/g0v/itaigi/pulls/456","id":160345658,"html_url":"https://github.com/g0v/itaigi/pull/456","diff_url":"https://github.com/g0v/itaigi/pull/456.diff","patch_url":"https://github.com/g0v/itaigi/pull/456.patch","issue_url":"https://api.github.com/repos/g0v/itaigi/issues/456","number":456,"state":"open","locked":false,"title":"新增按鈕完整複製中文網址利於轉貼辨識","user":{"login":"leo424y","id":1384394,"avatar_url":"https://avatars3.githubusercontent.com/u/1384394?v=4","gravatar_id":"","url":"https://api.github.com/users/leo424y","html_url":"https://github.com/leo424y","followers_url":"https://api.github.com/users/leo424y/followers","following_url":"https://api.github.com/users/leo424y/following{/other_user}","gists_url":"https://api.github.com/users/leo424y/gists{/gist_id}","starred_url":"https://api.github.com/users/leo424y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leo424y/subscriptions","organizations_url":"https://api.github.com/users/leo424y/orgs","repos_url":"https://api.github.com/users/leo424y/repos","events_url":"https://api.github.com/users/leo424y/events{/privacy}","received_events_url":"https://api.github.com/users/leo424y/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-28T07:25:47Z","updated_at":"2017-12-28T11:23:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e895ae78528f1d2d5150cce53379f6edfccc60e3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/g0v/itaigi/pulls/456/commits","review_comments_url":"https://api.github.com/repos/g0v/itaigi/pulls/456/comments","review_comment_url":"https://api.github.com/repos/g0v/itaigi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/g0v/itaigi/issues/456/comments","statuses_url":"https://api.github.com/repos/g0v/itaigi/statuses/aa8b22abfc046fc335c5954b471bc6622ef16a76","head":{"label":"leo424y:master","ref":"master","sha":"aa8b22abfc046fc335c5954b471bc6622ef16a76","user":{"login":"leo424y","id":1384394,"avatar_url":"https://avatars3.githubusercontent.com/u/1384394?v=4","gravatar_id":"","url":"https://api.github.com/users/leo424y","html_url":"https://github.com/leo424y","followers_url":"https://api.github.com/users/leo424y/followers","following_url":"https://api.github.com/users/leo424y/following{/other_user}","gists_url":"https://api.github.com/users/leo424y/gists{/gist_id}","starred_url":"https://api.github.com/users/leo424y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leo424y/subscriptions","organizations_url":"https://api.github.com/users/leo424y/orgs","repos_url":"https://api.github.com/users/leo424y/repos","events_url":"https://api.github.com/users/leo424y/events{/privacy}","received_events_url":"https://api.github.com/users/leo424y/received_events","type":"User","site_admin":false},"repo":{"id":61978298,"name":"itaigi","full_name":"leo424y/itaigi","owner":{"login":"leo424y","id":1384394,"avatar_url":"https://avatars3.githubusercontent.com/u/1384394?v=4","gravatar_id":"","url":"https://api.github.com/users/leo424y","html_url":"https://github.com/leo424y","followers_url":"https://api.github.com/users/leo424y/followers","following_url":"https://api.github.com/users/leo424y/following{/other_user}","gists_url":"https://api.github.com/users/leo424y/gists{/gist_id}","starred_url":"https://api.github.com/users/leo424y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leo424y/subscriptions","organizations_url":"https://api.github.com/users/leo424y/orgs","repos_url":"https://api.github.com/users/leo424y/repos","events_url":"https://api.github.com/users/leo424y/events{/privacy}","received_events_url":"https://api.github.com/users/leo424y/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leo424y/itaigi","description":"新台語·運動","fork":true,"url":"https://api.github.com/repos/leo424y/itaigi","forks_url":"https://api.github.com/repos/leo424y/itaigi/forks","keys_url":"https://api.github.com/repos/leo424y/itaigi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leo424y/itaigi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leo424y/itaigi/teams","hooks_url":"https://api.github.com/repos/leo424y/itaigi/hooks","issue_events_url":"https://api.github.com/repos/leo424y/itaigi/issues/events{/number}","events_url":"https://api.github.com/repos/leo424y/itaigi/events","assignees_url":"https://api.github.com/repos/leo424y/itaigi/assignees{/user}","branches_url":"https://api.github.com/repos/leo424y/itaigi/branches{/branch}","tags_url":"https://api.github.com/repos/leo424y/itaigi/tags","blobs_url":"https://api.github.com/repos/leo424y/itaigi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leo424y/itaigi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leo424y/itaigi/git/refs{/sha}","trees_url":"https://api.github.com/repos/leo424y/itaigi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leo424y/itaigi/statuses/{sha}","languages_url":"https://api.github.com/repos/leo424y/itaigi/languages","stargazers_url":"https://api.github.com/repos/leo424y/itaigi/stargazers","contributors_url":"https://api.github.com/repos/leo424y/itaigi/contributors","subscribers_url":"https://api.github.com/repos/leo424y/itaigi/subscribers","subscription_url":"https://api.github.com/repos/leo424y/itaigi/subscription","commits_url":"https://api.github.com/repos/leo424y/itaigi/commits{/sha}","git_commits_url":"https://api.github.com/repos/leo424y/itaigi/git/commits{/sha}","comments_url":"https://api.github.com/repos/leo424y/itaigi/comments{/number}","issue_comment_url":"https://api.github.com/repos/leo424y/itaigi/issues/comments{/number}","contents_url":"https://api.github.com/repos/leo424y/itaigi/contents/{+path}","compare_url":"https://api.github.com/repos/leo424y/itaigi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leo424y/itaigi/merges","archive_url":"https://api.github.com/repos/leo424y/itaigi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leo424y/itaigi/downloads","issues_url":"https://api.github.com/repos/leo424y/itaigi/issues{/number}","pulls_url":"https://api.github.com/repos/leo424y/itaigi/pulls{/number}","milestones_url":"https://api.github.com/repos/leo424y/itaigi/milestones{/number}","notifications_url":"https://api.github.com/repos/leo424y/itaigi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leo424y/itaigi/labels{/name}","releases_url":"https://api.github.com/repos/leo424y/itaigi/releases{/id}","deployments_url":"https://api.github.com/repos/leo424y/itaigi/deployments","created_at":"2016-06-26T07:17:39Z","updated_at":"2016-06-26T07:17:40Z","pushed_at":"2017-12-28T07:39:23Z","git_url":"git://github.com/leo424y/itaigi.git","ssh_url":"[email protected]:leo424y/itaigi.git","clone_url":"https://github.com/leo424y/itaigi.git","svn_url":"https://github.com/leo424y/itaigi","homepage":"http://itaigi.tw/","size":10211,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"g0v:master","ref":"master","sha":"58d0bb9ba2ea7f0bc9542daa7efdc4c1f6b1c87e","user":{"login":"g0v","id":2668086,"avatar_url":"https://avatars3.githubusercontent.com/u/2668086?v=4","gravatar_id":"","url":"https://api.github.com/users/g0v","html_url":"https://github.com/g0v","followers_url":"https://api.github.com/users/g0v/followers","following_url":"https://api.github.com/users/g0v/following{/other_user}","gists_url":"https://api.github.com/users/g0v/gists{/gist_id}","starred_url":"https://api.github.com/users/g0v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g0v/subscriptions","organizations_url":"https://api.github.com/users/g0v/orgs","repos_url":"https://api.github.com/users/g0v/repos","events_url":"https://api.github.com/users/g0v/events{/privacy}","received_events_url":"https://api.github.com/users/g0v/received_events","type":"Organization","site_admin":false},"repo":{"id":29418863,"name":"itaigi","full_name":"g0v/itaigi","owner":{"login":"g0v","id":2668086,"avatar_url":"https://avatars3.githubusercontent.com/u/2668086?v=4","gravatar_id":"","url":"https://api.github.com/users/g0v","html_url":"https://github.com/g0v","followers_url":"https://api.github.com/users/g0v/followers","following_url":"https://api.github.com/users/g0v/following{/other_user}","gists_url":"https://api.github.com/users/g0v/gists{/gist_id}","starred_url":"https://api.github.com/users/g0v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g0v/subscriptions","organizations_url":"https://api.github.com/users/g0v/orgs","repos_url":"https://api.github.com/users/g0v/repos","events_url":"https://api.github.com/users/g0v/events{/privacy}","received_events_url":"https://api.github.com/users/g0v/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/g0v/itaigi","description":"新台語·運動","fork":false,"url":"https://api.github.com/repos/g0v/itaigi","forks_url":"https://api.github.com/repos/g0v/itaigi/forks","keys_url":"https://api.github.com/repos/g0v/itaigi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/g0v/itaigi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/g0v/itaigi/teams","hooks_url":"https://api.github.com/repos/g0v/itaigi/hooks","issue_events_url":"https://api.github.com/repos/g0v/itaigi/issues/events{/number}","events_url":"https://api.github.com/repos/g0v/itaigi/events","assignees_url":"https://api.github.com/repos/g0v/itaigi/assignees{/user}","branches_url":"https://api.github.com/repos/g0v/itaigi/branches{/branch}","tags_url":"https://api.github.com/repos/g0v/itaigi/tags","blobs_url":"https://api.github.com/repos/g0v/itaigi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/g0v/itaigi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/g0v/itaigi/git/refs{/sha}","trees_url":"https://api.github.com/repos/g0v/itaigi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/g0v/itaigi/statuses/{sha}","languages_url":"https://api.github.com/repos/g0v/itaigi/languages","stargazers_url":"https://api.github.com/repos/g0v/itaigi/stargazers","contributors_url":"https://api.github.com/repos/g0v/itaigi/contributors","subscribers_url":"https://api.github.com/repos/g0v/itaigi/subscribers","subscription_url":"https://api.github.com/repos/g0v/itaigi/subscription","commits_url":"https://api.github.com/repos/g0v/itaigi/commits{/sha}","git_commits_url":"https://api.github.com/repos/g0v/itaigi/git/commits{/sha}","comments_url":"https://api.github.com/repos/g0v/itaigi/comments{/number}","issue_comment_url":"https://api.github.com/repos/g0v/itaigi/issues/comments{/number}","contents_url":"https://api.github.com/repos/g0v/itaigi/contents/{+path}","compare_url":"https://api.github.com/repos/g0v/itaigi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/g0v/itaigi/merges","archive_url":"https://api.github.com/repos/g0v/itaigi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/g0v/itaigi/downloads","issues_url":"https://api.github.com/repos/g0v/itaigi/issues{/number}","pulls_url":"https://api.github.com/repos/g0v/itaigi/pulls{/number}","milestones_url":"https://api.github.com/repos/g0v/itaigi/milestones{/number}","notifications_url":"https://api.github.com/repos/g0v/itaigi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/g0v/itaigi/labels{/name}","releases_url":"https://api.github.com/repos/g0v/itaigi/releases{/id}","deployments_url":"https://api.github.com/repos/g0v/itaigi/deployments","created_at":"2015-01-18T07:15:46Z","updated_at":"2017-12-25T04:31:25Z","pushed_at":"2017-12-28T07:39:24Z","git_url":"git://github.com/g0v/itaigi.git","ssh_url":"[email protected]:g0v/itaigi.git","clone_url":"https://github.com/g0v/itaigi.git","svn_url":"https://github.com/g0v/itaigi","homepage":"https://itaigi.tw/","size":7628,"stargazers_count":60,"watchers_count":60,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":60,"license":null,"forks":26,"open_issues":60,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/g0v/itaigi/pulls/456"},"html":{"href":"https://github.com/g0v/itaigi/pull/456"},"issue":{"href":"https://api.github.com/repos/g0v/itaigi/issues/456"},"comments":{"href":"https://api.github.com/repos/g0v/itaigi/issues/456/comments"},"review_comments":{"href":"https://api.github.com/repos/g0v/itaigi/pulls/456/comments"},"review_comment":{"href":"https://api.github.com/repos/g0v/itaigi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/g0v/itaigi/pulls/456/commits"},"statuses":{"href":"https://api.github.com/repos/g0v/itaigi/statuses/aa8b22abfc046fc335c5954b471bc6622ef16a76"}},"author_association":"COLLABORATOR"}} | {
"id": 29418863,
"name": "g0v/itaigi",
"url": "https://api.github.com/repos/g0v/itaigi"
} | {
"id": 5996555,
"login": "sih4sing5hong5",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5996555?",
"url": "https://api.github.com/users/sih4sing5hong5"
} | {
"id": 2668086,
"login": "g0v",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2668086?",
"url": "https://api.github.com/orgs/g0v"
} | 2017-12-28T11:22:00 | 7036874788 | {"actor":{"display_login":"sih4sing5hong5"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hbz/lobid-resources/pulls/comments/113639536","pull_request_review_id":35043076,"id":113639536,"diff_hunk":"@@ -74,13 +74,6 @@\n } ],\n \"hbzId\" : \"HT015891797\",\n \"id\" : \"http://lobid.org/resources/HT015891797#!\",\n- \"isPartOf\" : [ {\n- \"id\" : \"http://lobid.org/resources/HT015845132#!\",\n- \"label\" : \"lobid Ressource\"\n- }, {\n- \"id\" : \"http://lobid.org/resources/HT002786685#!\",\n- \"label\" : \"lobid Ressource\"\n- } ],","path":"src/test/resources/jsonld/HT015891797","position":10,"original_position":10,"commit_id":"7db86886954115e76f9c490717952fb2da880894","original_commit_id":"7db86886954115e76f9c490717952fb2da880894","user":{"login":"dr0i","id":944023,"avatar_url":"https://avatars3.githubusercontent.com/u/944023?v=3","gravatar_id":"","url":"https://api.github.com/users/dr0i","html_url":"https://github.com/dr0i","followers_url":"https://api.github.com/users/dr0i/followers","following_url":"https://api.github.com/users/dr0i/following{/other_user}","gists_url":"https://api.github.com/users/dr0i/gists{/gist_id}","starred_url":"https://api.github.com/users/dr0i/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dr0i/subscriptions","organizations_url":"https://api.github.com/users/dr0i/orgs","repos_url":"https://api.github.com/users/dr0i/repos","events_url":"https://api.github.com/users/dr0i/events{/privacy}","received_events_url":"https://api.github.com/users/dr0i/received_events","type":"User","site_admin":false},"body":"Is it correct to loose the link to HT002786685 ? Can't find it redundantly residing in an other field.","created_at":"2017-04-27T08:21:03Z","updated_at":"2017-04-27T08:42:29Z","html_url":"https://github.com/hbz/lobid-resources/pull/401#discussion_r113639536","pull_request_url":"https://api.github.com/repos/hbz/lobid-resources/pulls/401","_links":{"self":{"href":"https://api.github.com/repos/hbz/lobid-resources/pulls/comments/113639536"},"html":{"href":"https://github.com/hbz/lobid-resources/pull/401#discussion_r113639536"},"pull_request":{"href":"https://api.github.com/repos/hbz/lobid-resources/pulls/401"}}},"pull_request":{"url":"https://api.github.com/repos/hbz/lobid-resources/pulls/401","id":116584755,"html_url":"https://github.com/hbz/lobid-resources/pull/401","diff_url":"https://github.com/hbz/lobid-resources/pull/401.diff","patch_url":"https://github.com/hbz/lobid-resources/pull/401.patch","issue_url":"https://api.github.com/repos/hbz/lobid-resources/issues/401","number":401,"state":"open","locked":false,"title":"382 remove redundant isPartOf statements","user":{"login":"ChristophEwertowski","id":24875432,"avatar_url":"https://avatars2.githubusercontent.com/u/24875432?v=3","gravatar_id":"","url":"https://api.github.com/users/ChristophEwertowski","html_url":"https://github.com/ChristophEwertowski","followers_url":"https://api.github.com/users/ChristophEwertowski/followers","following_url":"https://api.github.com/users/ChristophEwertowski/following{/other_user}","gists_url":"https://api.github.com/users/ChristophEwertowski/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristophEwertowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristophEwertowski/subscriptions","organizations_url":"https://api.github.com/users/ChristophEwertowski/orgs","repos_url":"https://api.github.com/users/ChristophEwertowski/repos","events_url":"https://api.github.com/users/ChristophEwertowski/events{/privacy}","received_events_url":"https://api.github.com/users/ChristophEwertowski/received_events","type":"User","site_admin":false},"body":"Resolves #382 ","created_at":"2017-04-19T16:06:12Z","updated_at":"2017-04-27T08:42:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2591ec40eeeb193c0e9141e72338ca1bb3aa6d8e","assignee":{"login":"dr0i","id":944023,"avatar_url":"https://avatars3.githubusercontent.com/u/944023?v=3","gravatar_id":"","url":"https://api.github.com/users/dr0i","html_url":"https://github.com/dr0i","followers_url":"https://api.github.com/users/dr0i/followers","following_url":"https://api.github.com/users/dr0i/following{/other_user}","gists_url":"https://api.github.com/users/dr0i/gists{/gist_id}","starred_url":"https://api.github.com/users/dr0i/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dr0i/subscriptions","organizations_url":"https://api.github.com/users/dr0i/orgs","repos_url":"https://api.github.com/users/dr0i/repos","events_url":"https://api.github.com/users/dr0i/events{/privacy}","received_events_url":"https://api.github.com/users/dr0i/received_events","type":"User","site_admin":false},"assignees":[{"login":"dr0i","id":944023,"avatar_url":"https://avatars3.githubusercontent.com/u/944023?v=3","gravatar_id":"","url":"https://api.github.com/users/dr0i","html_url":"https://github.com/dr0i","followers_url":"https://api.github.com/users/dr0i/followers","following_url":"https://api.github.com/users/dr0i/following{/other_user}","gists_url":"https://api.github.com/users/dr0i/gists{/gist_id}","starred_url":"https://api.github.com/users/dr0i/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dr0i/subscriptions","organizations_url":"https://api.github.com/users/dr0i/orgs","repos_url":"https://api.github.com/users/dr0i/repos","events_url":"https://api.github.com/users/dr0i/events{/privacy}","received_events_url":"https://api.github.com/users/dr0i/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hbz/lobid-resources/pulls/401/commits","review_comments_url":"https://api.github.com/repos/hbz/lobid-resources/pulls/401/comments","review_comment_url":"https://api.github.com/repos/hbz/lobid-resources/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hbz/lobid-resources/issues/401/comments","statuses_url":"https://api.github.com/repos/hbz/lobid-resources/statuses/7db86886954115e76f9c490717952fb2da880894","head":{"label":"hbz:382-removeRedundantIsPartOfStatements","ref":"382-removeRedundantIsPartOfStatements","sha":"7db86886954115e76f9c490717952fb2da880894","user":{"login":"hbz","id":6557108,"avatar_url":"https://avatars0.githubusercontent.com/u/6557108?v=3","gravatar_id":"","url":"https://api.github.com/users/hbz","html_url":"https://github.com/hbz","followers_url":"https://api.github.com/users/hbz/followers","following_url":"https://api.github.com/users/hbz/following{/other_user}","gists_url":"https://api.github.com/users/hbz/gists{/gist_id}","starred_url":"https://api.github.com/users/hbz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbz/subscriptions","organizations_url":"https://api.github.com/users/hbz/orgs","repos_url":"https://api.github.com/users/hbz/repos","events_url":"https://api.github.com/users/hbz/events{/privacy}","received_events_url":"https://api.github.com/users/hbz/received_events","type":"Organization","site_admin":false},"repo":{"id":41291958,"name":"lobid-resources","full_name":"hbz/lobid-resources","owner":{"login":"hbz","id":6557108,"avatar_url":"https://avatars0.githubusercontent.com/u/6557108?v=3","gravatar_id":"","url":"https://api.github.com/users/hbz","html_url":"https://github.com/hbz","followers_url":"https://api.github.com/users/hbz/followers","following_url":"https://api.github.com/users/hbz/following{/other_user}","gists_url":"https://api.github.com/users/hbz/gists{/gist_id}","starred_url":"https://api.github.com/users/hbz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbz/subscriptions","organizations_url":"https://api.github.com/users/hbz/orgs","repos_url":"https://api.github.com/users/hbz/repos","events_url":"https://api.github.com/users/hbz/events{/privacy}","received_events_url":"https://api.github.com/users/hbz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hbz/lobid-resources","description":"Transformation, web frontend, and API for the hbz catalog as LOD","fork":false,"url":"https://api.github.com/repos/hbz/lobid-resources","forks_url":"https://api.github.com/repos/hbz/lobid-resources/forks","keys_url":"https://api.github.com/repos/hbz/lobid-resources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hbz/lobid-resources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hbz/lobid-resources/teams","hooks_url":"https://api.github.com/repos/hbz/lobid-resources/hooks","issue_events_url":"https://api.github.com/repos/hbz/lobid-resources/issues/events{/number}","events_url":"https://api.github.com/repos/hbz/lobid-resources/events","assignees_url":"https://api.github.com/repos/hbz/lobid-resources/assignees{/user}","branches_url":"https://api.github.com/repos/hbz/lobid-resources/branches{/branch}","tags_url":"https://api.github.com/repos/hbz/lobid-resources/tags","blobs_url":"https://api.github.com/repos/hbz/lobid-resources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hbz/lobid-resources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hbz/lobid-resources/git/refs{/sha}","trees_url":"https://api.github.com/repos/hbz/lobid-resources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hbz/lobid-resources/statuses/{sha}","languages_url":"https://api.github.com/repos/hbz/lobid-resources/languages","stargazers_url":"https://api.github.com/repos/hbz/lobid-resources/stargazers","contributors_url":"https://api.github.com/repos/hbz/lobid-resources/contributors","subscribers_url":"https://api.github.com/repos/hbz/lobid-resources/subscribers","subscription_url":"https://api.github.com/repos/hbz/lobid-resources/subscription","commits_url":"https://api.github.com/repos/hbz/lobid-resources/commits{/sha}","git_commits_url":"https://api.github.com/repos/hbz/lobid-resources/git/commits{/sha}","comments_url":"https://api.github.com/repos/hbz/lobid-resources/comments{/number}","issue_comment_url":"https://api.github.com/repos/hbz/lobid-resources/issues/comments{/number}","contents_url":"https://api.github.com/repos/hbz/lobid-resources/contents/{+path}","compare_url":"https://api.github.com/repos/hbz/lobid-resources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hbz/lobid-resources/merges","archive_url":"https://api.github.com/repos/hbz/lobid-resources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hbz/lobid-resources/downloads","issues_url":"https://api.github.com/repos/hbz/lobid-resources/issues{/number}","pulls_url":"https://api.github.com/repos/hbz/lobid-resources/pulls{/number}","milestones_url":"https://api.github.com/repos/hbz/lobid-resources/milestones{/number}","notifications_url":"https://api.github.com/repos/hbz/lobid-resources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hbz/lobid-resources/labels{/name}","releases_url":"https://api.github.com/repos/hbz/lobid-resources/releases{/id}","deployments_url":"https://api.github.com/repos/hbz/lobid-resources/deployments","created_at":"2015-08-24T08:39:45Z","updated_at":"2017-04-25T11:29:06Z","pushed_at":"2017-04-27T08:19:17Z","git_url":"git://github.com/hbz/lobid-resources.git","ssh_url":"[email protected]:hbz/lobid-resources.git","clone_url":"https://github.com/hbz/lobid-resources.git","svn_url":"https://github.com/hbz/lobid-resources","homepage":"http://lobid.org/resources","size":11478,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":49,"forks":2,"open_issues":49,"watchers":1,"default_branch":"master"}},"base":{"label":"hbz:master","ref":"master","sha":"eda1bb4df61b1d7c21f70c5e096981f5b1906ae9","user":{"login":"hbz","id":6557108,"avatar_url":"https://avatars0.githubusercontent.com/u/6557108?v=3","gravatar_id":"","url":"https://api.github.com/users/hbz","html_url":"https://github.com/hbz","followers_url":"https://api.github.com/users/hbz/followers","following_url":"https://api.github.com/users/hbz/following{/other_user}","gists_url":"https://api.github.com/users/hbz/gists{/gist_id}","starred_url":"https://api.github.com/users/hbz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbz/subscriptions","organizations_url":"https://api.github.com/users/hbz/orgs","repos_url":"https://api.github.com/users/hbz/repos","events_url":"https://api.github.com/users/hbz/events{/privacy}","received_events_url":"https://api.github.com/users/hbz/received_events","type":"Organization","site_admin":false},"repo":{"id":41291958,"name":"lobid-resources","full_name":"hbz/lobid-resources","owner":{"login":"hbz","id":6557108,"avatar_url":"https://avatars0.githubusercontent.com/u/6557108?v=3","gravatar_id":"","url":"https://api.github.com/users/hbz","html_url":"https://github.com/hbz","followers_url":"https://api.github.com/users/hbz/followers","following_url":"https://api.github.com/users/hbz/following{/other_user}","gists_url":"https://api.github.com/users/hbz/gists{/gist_id}","starred_url":"https://api.github.com/users/hbz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbz/subscriptions","organizations_url":"https://api.github.com/users/hbz/orgs","repos_url":"https://api.github.com/users/hbz/repos","events_url":"https://api.github.com/users/hbz/events{/privacy}","received_events_url":"https://api.github.com/users/hbz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hbz/lobid-resources","description":"Transformation, web frontend, and API for the hbz catalog as LOD","fork":false,"url":"https://api.github.com/repos/hbz/lobid-resources","forks_url":"https://api.github.com/repos/hbz/lobid-resources/forks","keys_url":"https://api.github.com/repos/hbz/lobid-resources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hbz/lobid-resources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hbz/lobid-resources/teams","hooks_url":"https://api.github.com/repos/hbz/lobid-resources/hooks","issue_events_url":"https://api.github.com/repos/hbz/lobid-resources/issues/events{/number}","events_url":"https://api.github.com/repos/hbz/lobid-resources/events","assignees_url":"https://api.github.com/repos/hbz/lobid-resources/assignees{/user}","branches_url":"https://api.github.com/repos/hbz/lobid-resources/branches{/branch}","tags_url":"https://api.github.com/repos/hbz/lobid-resources/tags","blobs_url":"https://api.github.com/repos/hbz/lobid-resources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hbz/lobid-resources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hbz/lobid-resources/git/refs{/sha}","trees_url":"https://api.github.com/repos/hbz/lobid-resources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hbz/lobid-resources/statuses/{sha}","languages_url":"https://api.github.com/repos/hbz/lobid-resources/languages","stargazers_url":"https://api.github.com/repos/hbz/lobid-resources/stargazers","contributors_url":"https://api.github.com/repos/hbz/lobid-resources/contributors","subscribers_url":"https://api.github.com/repos/hbz/lobid-resources/subscribers","subscription_url":"https://api.github.com/repos/hbz/lobid-resources/subscription","commits_url":"https://api.github.com/repos/hbz/lobid-resources/commits{/sha}","git_commits_url":"https://api.github.com/repos/hbz/lobid-resources/git/commits{/sha}","comments_url":"https://api.github.com/repos/hbz/lobid-resources/comments{/number}","issue_comment_url":"https://api.github.com/repos/hbz/lobid-resources/issues/comments{/number}","contents_url":"https://api.github.com/repos/hbz/lobid-resources/contents/{+path}","compare_url":"https://api.github.com/repos/hbz/lobid-resources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hbz/lobid-resources/merges","archive_url":"https://api.github.com/repos/hbz/lobid-resources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hbz/lobid-resources/downloads","issues_url":"https://api.github.com/repos/hbz/lobid-resources/issues{/number}","pulls_url":"https://api.github.com/repos/hbz/lobid-resources/pulls{/number}","milestones_url":"https://api.github.com/repos/hbz/lobid-resources/milestones{/number}","notifications_url":"https://api.github.com/repos/hbz/lobid-resources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hbz/lobid-resources/labels{/name}","releases_url":"https://api.github.com/repos/hbz/lobid-resources/releases{/id}","deployments_url":"https://api.github.com/repos/hbz/lobid-resources/deployments","created_at":"2015-08-24T08:39:45Z","updated_at":"2017-04-25T11:29:06Z","pushed_at":"2017-04-27T08:19:17Z","git_url":"git://github.com/hbz/lobid-resources.git","ssh_url":"[email protected]:hbz/lobid-resources.git","clone_url":"https://github.com/hbz/lobid-resources.git","svn_url":"https://github.com/hbz/lobid-resources","homepage":"http://lobid.org/resources","size":11478,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":49,"forks":2,"open_issues":49,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hbz/lobid-resources/pulls/401"},"html":{"href":"https://github.com/hbz/lobid-resources/pull/401"},"issue":{"href":"https://api.github.com/repos/hbz/lobid-resources/issues/401"},"comments":{"href":"https://api.github.com/repos/hbz/lobid-resources/issues/401/comments"},"review_comments":{"href":"https://api.github.com/repos/hbz/lobid-resources/pulls/401/comments"},"review_comment":{"href":"https://api.github.com/repos/hbz/lobid-resources/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hbz/lobid-resources/pulls/401/commits"},"statuses":{"href":"https://api.github.com/repos/hbz/lobid-resources/statuses/7db86886954115e76f9c490717952fb2da880894"}}}} | {
"id": 41291958,
"name": "hbz/lobid-resources",
"url": "https://api.github.com/repos/hbz/lobid-resources"
} | {
"id": 944023,
"login": "dr0i",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/944023?",
"url": "https://api.github.com/users/dr0i"
} | {
"id": 6557108,
"login": "hbz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6557108?",
"url": "https://api.github.com/orgs/hbz"
} | 2017-04-27T08:21:03 | 5766944298 | {"actor":{"display_login":"dr0i"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ocf/ocfweb/pulls/comments/133841003","pull_request_review_id":57028343,"id":133841003,"diff_hunk":"@@ -0,0 +1,104 @@\n+from collections import namedtuple\n+from datetime import date\n+from datetime import datetime\n+from datetime import time\n+from datetime import timedelta\n+\n+import requests\n+from django.http import JsonResponse\n+\n+from ocfweb.caching import periodic\n+\n+HOURS_SPREADSHEET = 'https://docs.google.com/spreadsheet/ccc?key=1WgczUrxqey63fmPRmdkCDMCbsfaTyCJrixiCeJj35UI&output=csv' # noqa: E501\n+SHIFT_LENGTH = timedelta(hours=0.5)\n+\n+\n+class Hour(namedtuple('Hours', ['open', 'close', 'staffer'])):\n+\n+ def __contains__(self, when):\n+ if not isinstance(when, time):\n+ when = when.time()\n+\n+ return self.open <= when < self.close\n+\n+\n+def _get_hours():\n+ \"\"\"pull hours from the Google spreadsheet\"\"\"\n+\n+ response = requests.get(HOURS_SPREADSHEET)\n+ response.raise_for_status()\n+\n+ matrix = response.content.decode('utf-8').splitlines()\n+ matrix = [row.split(',') for row in matrix]\n+\n+ # [1:] because the first box in the matrix is empty\n+ # matrix[0] = ['', 'Monday', 'Tuesday', ...]\n+ # row[0] = ['13:30PM', 'name1', 'name2', ...]\n+ shifts = [row[0] for row in matrix][1:]\n+\n+ all_shifts = {}\n+\n+ # instead of e.g. enumerate(['Monday', 'Tuesday', ... 'Sunday'])\n+ for day in range(7):\n+ # matrix[sidx + 1][day + 1] = person on shift on that shift index\n+ all_shifts[day] = {shift: matrix[sidx + 1][day + 1] for sidx, shift in enumerate(shifts)}\n+\n+ # this will get cached downstream\n+ return all_shifts\n+\n+\n+def _combine_shifts(shifts):\n+ \"\"\"combined a day's worht of shifts into a list of Hour() objects\n+ shifts = {'09:00AM': 'name1', ...}\"\"\"\n+\n+ raw_shifts = []\n+ for shift, staffer in shifts.items():\n+ if not staffer: # skip unstaffed shifts\n+ continue\n+\n+ open = datetime.strptime(shift, '%H:%M%p') # 16:00PM","path":"ocfweb/api/hours.py","position":59,"original_position":59,"commit_id":"ec3b8725e9f3fb8255d592ef8eda5ec219263b6b","original_commit_id":"ec3b8725e9f3fb8255d592ef8eda5ec219263b6b","user":{"login":"chriskuehl","id":665269,"avatar_url":"https://avatars3.githubusercontent.com/u/665269?v=4","gravatar_id":"","url":"https://api.github.com/users/chriskuehl","html_url":"https://github.com/chriskuehl","followers_url":"https://api.github.com/users/chriskuehl/followers","following_url":"https://api.github.com/users/chriskuehl/following{/other_user}","gists_url":"https://api.github.com/users/chriskuehl/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskuehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskuehl/subscriptions","organizations_url":"https://api.github.com/users/chriskuehl/orgs","repos_url":"https://api.github.com/users/chriskuehl/repos","events_url":"https://api.github.com/users/chriskuehl/events{/privacy}","received_events_url":"https://api.github.com/users/chriskuehl/received_events","type":"User","site_admin":false},"body":"16:00PM????","created_at":"2017-08-17T22:04:57Z","updated_at":"2017-08-17T22:06:50Z","html_url":"https://github.com/ocf/ocfweb/pull/300#discussion_r133841003","pull_request_url":"https://api.github.com/repos/ocf/ocfweb/pulls/300","_links":{"self":{"href":"https://api.github.com/repos/ocf/ocfweb/pulls/comments/133841003"},"html":{"href":"https://github.com/ocf/ocfweb/pull/300#discussion_r133841003"},"pull_request":{"href":"https://api.github.com/repos/ocf/ocfweb/pulls/300"}}},"pull_request":{"url":"https://api.github.com/repos/ocf/ocfweb/pulls/300","id":136218792,"html_url":"https://github.com/ocf/ocfweb/pull/300","diff_url":"https://github.com/ocf/ocfweb/pull/300.diff","patch_url":"https://github.com/ocf/ocfweb/pull/300.patch","issue_url":"https://api.github.com/repos/ocf/ocfweb/issues/300","number":300,"state":"open","locked":false,"title":"api: move hours to ocfweb","user":{"login":"tahabi","id":1916822,"avatar_url":"https://avatars1.githubusercontent.com/u/1916822?v=4","gravatar_id":"","url":"https://api.github.com/users/tahabi","html_url":"https://github.com/tahabi","followers_url":"https://api.github.com/users/tahabi/followers","following_url":"https://api.github.com/users/tahabi/following{/other_user}","gists_url":"https://api.github.com/users/tahabi/gists{/gist_id}","starred_url":"https://api.github.com/users/tahabi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tahabi/subscriptions","organizations_url":"https://api.github.com/users/tahabi/orgs","repos_url":"https://api.github.com/users/tahabi/repos","events_url":"https://api.github.com/users/tahabi/events{/privacy}","received_events_url":"https://api.github.com/users/tahabi/received_events","type":"User","site_admin":false},"body":"the ocfweb counterpart to ocf/ocflib#75\r\n","created_at":"2017-08-17T10:06:03Z","updated_at":"2017-08-17T22:06:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdc9f976692ff640be4921fcd4daa12d69104b3f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocf/ocfweb/pulls/300/commits","review_comments_url":"https://api.github.com/repos/ocf/ocfweb/pulls/300/comments","review_comment_url":"https://api.github.com/repos/ocf/ocfweb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocf/ocfweb/issues/300/comments","statuses_url":"https://api.github.com/repos/ocf/ocfweb/statuses/ec3b8725e9f3fb8255d592ef8eda5ec219263b6b","head":{"label":"tahabi:bigbrother","ref":"bigbrother","sha":"ec3b8725e9f3fb8255d592ef8eda5ec219263b6b","user":{"login":"tahabi","id":1916822,"avatar_url":"https://avatars1.githubusercontent.com/u/1916822?v=4","gravatar_id":"","url":"https://api.github.com/users/tahabi","html_url":"https://github.com/tahabi","followers_url":"https://api.github.com/users/tahabi/followers","following_url":"https://api.github.com/users/tahabi/following{/other_user}","gists_url":"https://api.github.com/users/tahabi/gists{/gist_id}","starred_url":"https://api.github.com/users/tahabi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tahabi/subscriptions","organizations_url":"https://api.github.com/users/tahabi/orgs","repos_url":"https://api.github.com/users/tahabi/repos","events_url":"https://api.github.com/users/tahabi/events{/privacy}","received_events_url":"https://api.github.com/users/tahabi/received_events","type":"User","site_admin":false},"repo":{"id":74505388,"name":"ocfweb","full_name":"tahabi/ocfweb","owner":{"login":"tahabi","id":1916822,"avatar_url":"https://avatars1.githubusercontent.com/u/1916822?v=4","gravatar_id":"","url":"https://api.github.com/users/tahabi","html_url":"https://github.com/tahabi","followers_url":"https://api.github.com/users/tahabi/followers","following_url":"https://api.github.com/users/tahabi/following{/other_user}","gists_url":"https://api.github.com/users/tahabi/gists{/gist_id}","starred_url":"https://api.github.com/users/tahabi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tahabi/subscriptions","organizations_url":"https://api.github.com/users/tahabi/orgs","repos_url":"https://api.github.com/users/tahabi/repos","events_url":"https://api.github.com/users/tahabi/events{/privacy}","received_events_url":"https://api.github.com/users/tahabi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tahabi/ocfweb","description":"The main ocf website","fork":true,"url":"https://api.github.com/repos/tahabi/ocfweb","forks_url":"https://api.github.com/repos/tahabi/ocfweb/forks","keys_url":"https://api.github.com/repos/tahabi/ocfweb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tahabi/ocfweb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tahabi/ocfweb/teams","hooks_url":"https://api.github.com/repos/tahabi/ocfweb/hooks","issue_events_url":"https://api.github.com/repos/tahabi/ocfweb/issues/events{/number}","events_url":"https://api.github.com/repos/tahabi/ocfweb/events","assignees_url":"https://api.github.com/repos/tahabi/ocfweb/assignees{/user}","branches_url":"https://api.github.com/repos/tahabi/ocfweb/branches{/branch}","tags_url":"https://api.github.com/repos/tahabi/ocfweb/tags","blobs_url":"https://api.github.com/repos/tahabi/ocfweb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tahabi/ocfweb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tahabi/ocfweb/git/refs{/sha}","trees_url":"https://api.github.com/repos/tahabi/ocfweb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tahabi/ocfweb/statuses/{sha}","languages_url":"https://api.github.com/repos/tahabi/ocfweb/languages","stargazers_url":"https://api.github.com/repos/tahabi/ocfweb/stargazers","contributors_url":"https://api.github.com/repos/tahabi/ocfweb/contributors","subscribers_url":"https://api.github.com/repos/tahabi/ocfweb/subscribers","subscription_url":"https://api.github.com/repos/tahabi/ocfweb/subscription","commits_url":"https://api.github.com/repos/tahabi/ocfweb/commits{/sha}","git_commits_url":"https://api.github.com/repos/tahabi/ocfweb/git/commits{/sha}","comments_url":"https://api.github.com/repos/tahabi/ocfweb/comments{/number}","issue_comment_url":"https://api.github.com/repos/tahabi/ocfweb/issues/comments{/number}","contents_url":"https://api.github.com/repos/tahabi/ocfweb/contents/{+path}","compare_url":"https://api.github.com/repos/tahabi/ocfweb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tahabi/ocfweb/merges","archive_url":"https://api.github.com/repos/tahabi/ocfweb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tahabi/ocfweb/downloads","issues_url":"https://api.github.com/repos/tahabi/ocfweb/issues{/number}","pulls_url":"https://api.github.com/repos/tahabi/ocfweb/pulls{/number}","milestones_url":"https://api.github.com/repos/tahabi/ocfweb/milestones{/number}","notifications_url":"https://api.github.com/repos/tahabi/ocfweb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tahabi/ocfweb/labels{/name}","releases_url":"https://api.github.com/repos/tahabi/ocfweb/releases{/id}","deployments_url":"https://api.github.com/repos/tahabi/ocfweb/deployments","created_at":"2016-11-22T19:18:39Z","updated_at":"2016-11-22T19:18:41Z","pushed_at":"2017-08-17T09:50:36Z","git_url":"git://github.com/tahabi/ocfweb.git","ssh_url":"[email protected]:tahabi/ocfweb.git","clone_url":"https://github.com/tahabi/ocfweb.git","svn_url":"https://github.com/tahabi/ocfweb","homepage":"https://www.ocf.berkeley.edu","size":3059,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ocf:master","ref":"master","sha":"53f07a0db08bf82589f656d9239e96270fe06aeb","user":{"login":"ocf","id":1504667,"avatar_url":"https://avatars2.githubusercontent.com/u/1504667?v=4","gravatar_id":"","url":"https://api.github.com/users/ocf","html_url":"https://github.com/ocf","followers_url":"https://api.github.com/users/ocf/followers","following_url":"https://api.github.com/users/ocf/following{/other_user}","gists_url":"https://api.github.com/users/ocf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocf/subscriptions","organizations_url":"https://api.github.com/users/ocf/orgs","repos_url":"https://api.github.com/users/ocf/repos","events_url":"https://api.github.com/users/ocf/events{/privacy}","received_events_url":"https://api.github.com/users/ocf/received_events","type":"Organization","site_admin":false},"repo":{"id":41186799,"name":"ocfweb","full_name":"ocf/ocfweb","owner":{"login":"ocf","id":1504667,"avatar_url":"https://avatars2.githubusercontent.com/u/1504667?v=4","gravatar_id":"","url":"https://api.github.com/users/ocf","html_url":"https://github.com/ocf","followers_url":"https://api.github.com/users/ocf/followers","following_url":"https://api.github.com/users/ocf/following{/other_user}","gists_url":"https://api.github.com/users/ocf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocf/subscriptions","organizations_url":"https://api.github.com/users/ocf/orgs","repos_url":"https://api.github.com/users/ocf/repos","events_url":"https://api.github.com/users/ocf/events{/privacy}","received_events_url":"https://api.github.com/users/ocf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocf/ocfweb","description":"The main ocf website","fork":false,"url":"https://api.github.com/repos/ocf/ocfweb","forks_url":"https://api.github.com/repos/ocf/ocfweb/forks","keys_url":"https://api.github.com/repos/ocf/ocfweb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocf/ocfweb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocf/ocfweb/teams","hooks_url":"https://api.github.com/repos/ocf/ocfweb/hooks","issue_events_url":"https://api.github.com/repos/ocf/ocfweb/issues/events{/number}","events_url":"https://api.github.com/repos/ocf/ocfweb/events","assignees_url":"https://api.github.com/repos/ocf/ocfweb/assignees{/user}","branches_url":"https://api.github.com/repos/ocf/ocfweb/branches{/branch}","tags_url":"https://api.github.com/repos/ocf/ocfweb/tags","blobs_url":"https://api.github.com/repos/ocf/ocfweb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocf/ocfweb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocf/ocfweb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocf/ocfweb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocf/ocfweb/statuses/{sha}","languages_url":"https://api.github.com/repos/ocf/ocfweb/languages","stargazers_url":"https://api.github.com/repos/ocf/ocfweb/stargazers","contributors_url":"https://api.github.com/repos/ocf/ocfweb/contributors","subscribers_url":"https://api.github.com/repos/ocf/ocfweb/subscribers","subscription_url":"https://api.github.com/repos/ocf/ocfweb/subscription","commits_url":"https://api.github.com/repos/ocf/ocfweb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocf/ocfweb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocf/ocfweb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocf/ocfweb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocf/ocfweb/contents/{+path}","compare_url":"https://api.github.com/repos/ocf/ocfweb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocf/ocfweb/merges","archive_url":"https://api.github.com/repos/ocf/ocfweb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocf/ocfweb/downloads","issues_url":"https://api.github.com/repos/ocf/ocfweb/issues{/number}","pulls_url":"https://api.github.com/repos/ocf/ocfweb/pulls{/number}","milestones_url":"https://api.github.com/repos/ocf/ocfweb/milestones{/number}","notifications_url":"https://api.github.com/repos/ocf/ocfweb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocf/ocfweb/labels{/name}","releases_url":"https://api.github.com/repos/ocf/ocfweb/releases{/id}","deployments_url":"https://api.github.com/repos/ocf/ocfweb/deployments","created_at":"2015-08-22T02:43:14Z","updated_at":"2017-05-04T20:34:00Z","pushed_at":"2017-08-17T10:06:04Z","git_url":"git://github.com/ocf/ocfweb.git","ssh_url":"[email protected]:ocf/ocfweb.git","clone_url":"https://github.com/ocf/ocfweb.git","svn_url":"https://github.com/ocf/ocfweb","homepage":"https://www.ocf.berkeley.edu","size":3036,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":24,"forks":23,"open_issues":24,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocf/ocfweb/pulls/300"},"html":{"href":"https://github.com/ocf/ocfweb/pull/300"},"issue":{"href":"https://api.github.com/repos/ocf/ocfweb/issues/300"},"comments":{"href":"https://api.github.com/repos/ocf/ocfweb/issues/300/comments"},"review_comments":{"href":"https://api.github.com/repos/ocf/ocfweb/pulls/300/comments"},"review_comment":{"href":"https://api.github.com/repos/ocf/ocfweb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocf/ocfweb/pulls/300/commits"},"statuses":{"href":"https://api.github.com/repos/ocf/ocfweb/statuses/ec3b8725e9f3fb8255d592ef8eda5ec219263b6b"}}}} | {
"id": 41186799,
"name": "ocf/ocfweb",
"url": "https://api.github.com/repos/ocf/ocfweb"
} | {
"id": 665269,
"login": "chriskuehl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/665269?",
"url": "https://api.github.com/users/chriskuehl"
} | {
"id": 1504667,
"login": "ocf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1504667?",
"url": "https://api.github.com/orgs/ocf"
} | 2017-08-17T22:04:57 | 6476162559 | {"actor":{"display_login":"chriskuehl"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ocf/puppet/pulls/comments/148139676","pull_request_review_id":73337962,"id":148139676,"diff_hunk":"@@ -11,6 +11,11 @@\n $broker = \"redis://:${redis_password}@admin.ocf.berkeley.edu:6378\"\n $backend = $broker\n \n+\n+ # installed in extrapackages but this is an dependency\n+ # of the crypto libraries used in ocfweb as well\n+ package { 'libcrack2-dev':; }","path":"modules/ocf_ocfweb/manifests/dev_config.pp","position":7,"original_position":7,"commit_id":"0e93266698661d8a6874ba8348b485b098e607a9","original_commit_id":"0e93266698661d8a6874ba8348b485b098e607a9","user":{"login":"chriskuehl","id":665269,"avatar_url":"https://avatars3.githubusercontent.com/u/665269?v=4","gravatar_id":"","url":"https://api.github.com/users/chriskuehl","html_url":"https://github.com/chriskuehl","followers_url":"https://api.github.com/users/chriskuehl/followers","following_url":"https://api.github.com/users/chriskuehl/following{/other_user}","gists_url":"https://api.github.com/users/chriskuehl/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskuehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskuehl/subscriptions","organizations_url":"https://api.github.com/users/chriskuehl/orgs","repos_url":"https://api.github.com/users/chriskuehl/repos","events_url":"https://api.github.com/users/chriskuehl/events{/privacy}","received_events_url":"https://api.github.com/users/chriskuehl/received_events","type":"User","site_admin":false},"body":"you can just use ensure_packages instead: https://github.com/puppetlabs/puppetlabs-stdlib#ensure_packages","created_at":"2017-10-31T22:03:15Z","updated_at":"2017-10-31T22:03:15Z","html_url":"https://github.com/ocf/puppet/pull/225#discussion_r148139676","pull_request_url":"https://api.github.com/repos/ocf/puppet/pulls/225","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ocf/puppet/pulls/comments/148139676"},"html":{"href":"https://github.com/ocf/puppet/pull/225#discussion_r148139676"},"pull_request":{"href":"https://api.github.com/repos/ocf/puppet/pulls/225"}},"in_reply_to_id":148130098},"pull_request":{"url":"https://api.github.com/repos/ocf/puppet/pulls/225","id":149910193,"html_url":"https://github.com/ocf/puppet/pull/225","diff_url":"https://github.com/ocf/puppet/pull/225.diff","patch_url":"https://github.com/ocf/puppet/pull/225.patch","issue_url":"https://api.github.com/repos/ocf/puppet/issues/225","number":225,"state":"open","locked":false,"title":"add libcrack2-dev to ocfweb::dev_config","user":{"login":"abizer","id":1916822,"avatar_url":"https://avatars1.githubusercontent.com/u/1916822?v=4","gravatar_id":"","url":"https://api.github.com/users/abizer","html_url":"https://github.com/abizer","followers_url":"https://api.github.com/users/abizer/followers","following_url":"https://api.github.com/users/abizer/following{/other_user}","gists_url":"https://api.github.com/users/abizer/gists{/gist_id}","starred_url":"https://api.github.com/users/abizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abizer/subscriptions","organizations_url":"https://api.github.com/users/abizer/orgs","repos_url":"https://api.github.com/users/abizer/repos","events_url":"https://api.github.com/users/abizer/events{/privacy}","received_events_url":"https://api.github.com/users/abizer/received_events","type":"User","site_admin":false},"body":"we ran into this problem recently with @tanx16's staffvm, where running `make venv` would fail when compiling the python crypto libraries because of a missing header file. Making it an explicit dependency for the dev config should fix that issue.","created_at":"2017-10-31T21:16:41Z","updated_at":"2017-10-31T22:03:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20748243f56dca230168f08711c744b2b5cb8a3c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocf/puppet/pulls/225/commits","review_comments_url":"https://api.github.com/repos/ocf/puppet/pulls/225/comments","review_comment_url":"https://api.github.com/repos/ocf/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocf/puppet/issues/225/comments","statuses_url":"https://api.github.com/repos/ocf/puppet/statuses/0e93266698661d8a6874ba8348b485b098e607a9","head":{"label":"abizer:libcrack2-dev","ref":"libcrack2-dev","sha":"0e93266698661d8a6874ba8348b485b098e607a9","user":{"login":"abizer","id":1916822,"avatar_url":"https://avatars1.githubusercontent.com/u/1916822?v=4","gravatar_id":"","url":"https://api.github.com/users/abizer","html_url":"https://github.com/abizer","followers_url":"https://api.github.com/users/abizer/followers","following_url":"https://api.github.com/users/abizer/following{/other_user}","gists_url":"https://api.github.com/users/abizer/gists{/gist_id}","starred_url":"https://api.github.com/users/abizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abizer/subscriptions","organizations_url":"https://api.github.com/users/abizer/orgs","repos_url":"https://api.github.com/users/abizer/repos","events_url":"https://api.github.com/users/abizer/events{/privacy}","received_events_url":"https://api.github.com/users/abizer/received_events","type":"User","site_admin":false},"repo":{"id":76016282,"name":"puppet","full_name":"abizer/puppet","owner":{"login":"abizer","id":1916822,"avatar_url":"https://avatars1.githubusercontent.com/u/1916822?v=4","gravatar_id":"","url":"https://api.github.com/users/abizer","html_url":"https://github.com/abizer","followers_url":"https://api.github.com/users/abizer/followers","following_url":"https://api.github.com/users/abizer/following{/other_user}","gists_url":"https://api.github.com/users/abizer/gists{/gist_id}","starred_url":"https://api.github.com/users/abizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abizer/subscriptions","organizations_url":"https://api.github.com/users/abizer/orgs","repos_url":"https://api.github.com/users/abizer/repos","events_url":"https://api.github.com/users/abizer/events{/privacy}","received_events_url":"https://api.github.com/users/abizer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abizer/puppet","description":"Puppet config for OCF servers and lab machines","fork":true,"url":"https://api.github.com/repos/abizer/puppet","forks_url":"https://api.github.com/repos/abizer/puppet/forks","keys_url":"https://api.github.com/repos/abizer/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abizer/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abizer/puppet/teams","hooks_url":"https://api.github.com/repos/abizer/puppet/hooks","issue_events_url":"https://api.github.com/repos/abizer/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/abizer/puppet/events","assignees_url":"https://api.github.com/repos/abizer/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/abizer/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/abizer/puppet/tags","blobs_url":"https://api.github.com/repos/abizer/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abizer/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abizer/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/abizer/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abizer/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/abizer/puppet/languages","stargazers_url":"https://api.github.com/repos/abizer/puppet/stargazers","contributors_url":"https://api.github.com/repos/abizer/puppet/contributors","subscribers_url":"https://api.github.com/repos/abizer/puppet/subscribers","subscription_url":"https://api.github.com/repos/abizer/puppet/subscription","commits_url":"https://api.github.com/repos/abizer/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/abizer/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/abizer/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/abizer/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/abizer/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/abizer/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abizer/puppet/merges","archive_url":"https://api.github.com/repos/abizer/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abizer/puppet/downloads","issues_url":"https://api.github.com/repos/abizer/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/abizer/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/abizer/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/abizer/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abizer/puppet/labels{/name}","releases_url":"https://api.github.com/repos/abizer/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/abizer/puppet/deployments","created_at":"2016-12-09T08:23:16Z","updated_at":"2016-12-09T08:23:17Z","pushed_at":"2017-10-31T21:13:05Z","git_url":"git://github.com/abizer/puppet.git","ssh_url":"[email protected]:abizer/puppet.git","clone_url":"https://github.com/abizer/puppet.git","svn_url":"https://github.com/abizer/puppet","homepage":"https://www.ocf.berkeley.edu/","size":4484,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ocf:master","ref":"master","sha":"1c554c46940c5b08120037097ce63b2b298072af","user":{"login":"ocf","id":1504667,"avatar_url":"https://avatars2.githubusercontent.com/u/1504667?v=4","gravatar_id":"","url":"https://api.github.com/users/ocf","html_url":"https://github.com/ocf","followers_url":"https://api.github.com/users/ocf/followers","following_url":"https://api.github.com/users/ocf/following{/other_user}","gists_url":"https://api.github.com/users/ocf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocf/subscriptions","organizations_url":"https://api.github.com/users/ocf/orgs","repos_url":"https://api.github.com/users/ocf/repos","events_url":"https://api.github.com/users/ocf/events{/privacy}","received_events_url":"https://api.github.com/users/ocf/received_events","type":"Organization","site_admin":false},"repo":{"id":7022222,"name":"puppet","full_name":"ocf/puppet","owner":{"login":"ocf","id":1504667,"avatar_url":"https://avatars2.githubusercontent.com/u/1504667?v=4","gravatar_id":"","url":"https://api.github.com/users/ocf","html_url":"https://github.com/ocf","followers_url":"https://api.github.com/users/ocf/followers","following_url":"https://api.github.com/users/ocf/following{/other_user}","gists_url":"https://api.github.com/users/ocf/gists{/gist_id}","starred_url":"https://api.github.com/users/ocf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocf/subscriptions","organizations_url":"https://api.github.com/users/ocf/orgs","repos_url":"https://api.github.com/users/ocf/repos","events_url":"https://api.github.com/users/ocf/events{/privacy}","received_events_url":"https://api.github.com/users/ocf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocf/puppet","description":"Puppet config for OCF servers and lab machines","fork":false,"url":"https://api.github.com/repos/ocf/puppet","forks_url":"https://api.github.com/repos/ocf/puppet/forks","keys_url":"https://api.github.com/repos/ocf/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocf/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocf/puppet/teams","hooks_url":"https://api.github.com/repos/ocf/puppet/hooks","issue_events_url":"https://api.github.com/repos/ocf/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/ocf/puppet/events","assignees_url":"https://api.github.com/repos/ocf/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/ocf/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/ocf/puppet/tags","blobs_url":"https://api.github.com/repos/ocf/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocf/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocf/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocf/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocf/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/ocf/puppet/languages","stargazers_url":"https://api.github.com/repos/ocf/puppet/stargazers","contributors_url":"https://api.github.com/repos/ocf/puppet/contributors","subscribers_url":"https://api.github.com/repos/ocf/puppet/subscribers","subscription_url":"https://api.github.com/repos/ocf/puppet/subscription","commits_url":"https://api.github.com/repos/ocf/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocf/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocf/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocf/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocf/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/ocf/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocf/puppet/merges","archive_url":"https://api.github.com/repos/ocf/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocf/puppet/downloads","issues_url":"https://api.github.com/repos/ocf/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/ocf/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/ocf/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/ocf/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocf/puppet/labels{/name}","releases_url":"https://api.github.com/repos/ocf/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/ocf/puppet/deployments","created_at":"2012-12-05T18:16:15Z","updated_at":"2017-06-26T15:59:05Z","pushed_at":"2017-10-31T21:16:42Z","git_url":"git://github.com/ocf/puppet.git","ssh_url":"[email protected]:ocf/puppet.git","clone_url":"https://github.com/ocf/puppet.git","svn_url":"https://github.com/ocf/puppet","homepage":"https://www.ocf.berkeley.edu/","size":4491,"stargazers_count":10,"watchers_count":10,"language":"Puppet","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":12,"forks":21,"open_issues":12,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocf/puppet/pulls/225"},"html":{"href":"https://github.com/ocf/puppet/pull/225"},"issue":{"href":"https://api.github.com/repos/ocf/puppet/issues/225"},"comments":{"href":"https://api.github.com/repos/ocf/puppet/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/ocf/puppet/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/ocf/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocf/puppet/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/ocf/puppet/statuses/0e93266698661d8a6874ba8348b485b098e607a9"}},"author_association":"OWNER"}} | {
"id": 7022222,
"name": "ocf/puppet",
"url": "https://api.github.com/repos/ocf/puppet"
} | {
"id": 665269,
"login": "chriskuehl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/665269?",
"url": "https://api.github.com/users/chriskuehl"
} | {
"id": 1504667,
"login": "ocf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1504667?",
"url": "https://api.github.com/orgs/ocf"
} | 2017-10-31T22:03:15 | 6792047622 | {"actor":{"display_login":"chriskuehl"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/php/php-src/pulls/comments/136701162","pull_request_review_id":60280850,"id":136701162,"diff_hunk":"@@ -0,0 +1,163 @@\n+/*\n+ +----------------------------------------------------------------------+\n+ | PHP Version 7 |\n+ +----------------------------------------------------------------------+\n+ | Copyright (c) 1997-2017 The PHP Group |\n+ +----------------------------------------------------------------------+\n+ | This source file is subject to version 3.01 of the PHP license, |\n+ | that is bundled with this package in the file LICENSE, and is |\n+ | available through the world-wide-web at the following url: |\n+ | http://www.php.net/license/3_01.txt |\n+ | If you did not receive a copy of the PHP license and are unable to |\n+ | obtain it through the world-wide-web, please send a note to |\n+ | [email protected] so we can mail you a copy immediately. |\n+ +----------------------------------------------------------------------+\n+ | Author: Richard Fussenegger <[email protected]> |\n+ +----------------------------------------------------------------------+\n+*/\n+\n+/* $Id$ */\n+\n+#ifndef PHP_UUID_H\n+#define PHP_UUID_H\n+\n+#include \"zend_types.h\"\n+#include \"php.h\"\n+\n+PHPAPI extern zend_class_entry *php_ce_UUID;\n+PHPAPI extern zend_class_entry *php_ce_UUIDParseException;\n+\n+#define PHP_UUID_LEN 16\n+typedef struct php_uuid {\n+\tuint8_t bytes[PHP_UUID_LEN];\n+} php_uuid;\n+\n+#define PHP_UUID_HEX_LEN 33\n+typedef struct php_uuid_hex {\n+\tchar str[PHP_UUID_HEX_LEN];\n+} php_uuid_hex;\n+\n+#define PHP_UUID_STRING_LEN 37\n+typedef struct php_uuid_string {\n+\tchar str[PHP_UUID_STRING_LEN];\n+} php_uuid_string;\n+\n+typedef enum php_uuid_variant {\n+\tPHP_UUID_VARIANT_NCS = 0,\n+\tPHP_UUID_VARIANT_RFC4122 = 1,\n+\tPHP_UUID_VARIANT_MICROSOFT = 2,\n+\tPHP_UUID_VARIANT_FUTURE_RESERVED = 3,\n+} php_uuid_variant;\n+\n+static const uint8_t PHP_UUID_VERSION_1_TIME_BASED = 1;\n+static const uint8_t PHP_UUID_VERSION_2_DCE_SECURITY = 2;\n+static const uint8_t PHP_UUID_VERSION_3_NAME_BASED_MD5 = 3;\n+static const uint8_t PHP_UUID_VERSION_4_RANDOM = 4;\n+static const uint8_t PHP_UUID_VERSION_5_NAME_BASED_SHA1 = 5;\n+\n+BEGIN_EXTERN_C()\n+\n+PHPAPI void php_uuid_create_v3(php_uuid *uuid, const php_uuid *namespace, const char *name, const size_t name_len);\n+\n+PHPAPI int php_uuid_create_v4(php_uuid *uuid, const zend_bool throw);\n+\n+static zend_always_inline int php_uuid_create_v4_silent(php_uuid *uuid)","path":"ext/standard/php_uuid.h","position":64,"original_position":64,"commit_id":"3dc104e0dc13257ec78e51ce4637e737002da7d3","original_commit_id":"3dc104e0dc13257ec78e51ce4637e737002da7d3","user":{"login":"nikic","id":216080,"avatar_url":"https://avatars3.githubusercontent.com/u/216080?v=4","gravatar_id":"","url":"https://api.github.com/users/nikic","html_url":"https://github.com/nikic","followers_url":"https://api.github.com/users/nikic/followers","following_url":"https://api.github.com/users/nikic/following{/other_user}","gists_url":"https://api.github.com/users/nikic/gists{/gist_id}","starred_url":"https://api.github.com/users/nikic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikic/subscriptions","organizations_url":"https://api.github.com/users/nikic/orgs","repos_url":"https://api.github.com/users/nikic/repos","events_url":"https://api.github.com/users/nikic/events{/privacy}","received_events_url":"https://api.github.com/users/nikic/received_events","type":"User","site_admin":false},"body":"Do we really need the non-throwing variation of this? random_bytes has it because it's also used in some places which are historically non-throwing, but this is a new API.","created_at":"2017-09-02T18:29:43Z","updated_at":"2017-09-02T18:29:43Z","html_url":"https://github.com/php/php-src/pull/2535#discussion_r136701162","pull_request_url":"https://api.github.com/repos/php/php-src/pulls/2535","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/comments/136701162"},"html":{"href":"https://github.com/php/php-src/pull/2535#discussion_r136701162"},"pull_request":{"href":"https://api.github.com/repos/php/php-src/pulls/2535"}}},"pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/2535","id":122122237,"html_url":"https://github.com/php/php-src/pull/2535","diff_url":"https://github.com/php/php-src/pull/2535.diff","patch_url":"https://github.com/php/php-src/pull/2535.patch","issue_url":"https://api.github.com/repos/php/php-src/issues/2535","number":2535,"state":"open","locked":false,"title":"[RFC] UUID","user":{"login":"Fleshgrinder","id":1059453,"avatar_url":"https://avatars3.githubusercontent.com/u/1059453?v=4","gravatar_id":"","url":"https://api.github.com/users/Fleshgrinder","html_url":"https://github.com/Fleshgrinder","followers_url":"https://api.github.com/users/Fleshgrinder/followers","following_url":"https://api.github.com/users/Fleshgrinder/following{/other_user}","gists_url":"https://api.github.com/users/Fleshgrinder/gists{/gist_id}","starred_url":"https://api.github.com/users/Fleshgrinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fleshgrinder/subscriptions","organizations_url":"https://api.github.com/users/Fleshgrinder/orgs","repos_url":"https://api.github.com/users/Fleshgrinder/repos","events_url":"https://api.github.com/users/Fleshgrinder/events{/privacy}","received_events_url":"https://api.github.com/users/Fleshgrinder/received_events","type":"User","site_admin":false},"body":"Native [RFC 4122](https://tools.ietf.org/html/rfc4122) compliant [UUID](https://en.wikipedia.org/wiki/Universally_unique_identifier) implementation as part of the PHP standard module. This topic [was discussed in the past](http://markmail.org/thread/ca7xh2uq54uhvlkc), and I took the liberty to implement it.\r\n\r\n- [PHP 5 Polyfill](https://github.com/Fleshgrinder/php-uuid/tree/php-5)\r\n- [PHP 7.0 Polyfill](https://github.com/Fleshgrinder/php-uuid/tree/php-7.0)\r\n- [PHP 7.1 Polyfill](https://github.com/Fleshgrinder/php-uuid/tree/php-7.1)\r\n- [RFC](https://wiki.php.net/rfc/uuid)\r\n- [php-internals thread](http://news.php.net/php.internals/99136)\r\n- [Reddit](https://www.reddit.com/r/PHP/comments/6cyqtd/rfc_uuid/)\r\n- [Twitter discussion](https://twitter.com/AmbassadorAwsum/status/868097123627171842)\r\n\r\nI would love to get an in-depth review on the implementation. It has zero dependencies and works across all operating systems by relying on pure PHP code everywhere.\r\n\r\n~Note that this PR requires #2523.~\r\n\r\n~#2547 contains the same change set but within the `PHP\\Std` namespace, [see _Open Issues_ in the RFC](https://wiki.php.net/rfc/uuid#namespace).~","created_at":"2017-05-24T00:23:49Z","updated_at":"2017-09-02T18:29:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7f66075082c74afe49e65e85a1ac9c8ab4e7136","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/php/php-src/pulls/2535/commits","review_comments_url":"https://api.github.com/repos/php/php-src/pulls/2535/comments","review_comment_url":"https://api.github.com/repos/php/php-src/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php/php-src/issues/2535/comments","statuses_url":"https://api.github.com/repos/php/php-src/statuses/3dc104e0dc13257ec78e51ce4637e737002da7d3","head":{"label":"Fleshgrinder:rfc/uuid","ref":"rfc/uuid","sha":"3dc104e0dc13257ec78e51ce4637e737002da7d3","user":{"login":"Fleshgrinder","id":1059453,"avatar_url":"https://avatars3.githubusercontent.com/u/1059453?v=4","gravatar_id":"","url":"https://api.github.com/users/Fleshgrinder","html_url":"https://github.com/Fleshgrinder","followers_url":"https://api.github.com/users/Fleshgrinder/followers","following_url":"https://api.github.com/users/Fleshgrinder/following{/other_user}","gists_url":"https://api.github.com/users/Fleshgrinder/gists{/gist_id}","starred_url":"https://api.github.com/users/Fleshgrinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fleshgrinder/subscriptions","organizations_url":"https://api.github.com/users/Fleshgrinder/orgs","repos_url":"https://api.github.com/users/Fleshgrinder/repos","events_url":"https://api.github.com/users/Fleshgrinder/events{/privacy}","received_events_url":"https://api.github.com/users/Fleshgrinder/received_events","type":"User","site_admin":false},"repo":{"id":59404606,"name":"php-src","full_name":"Fleshgrinder/php-src","owner":{"login":"Fleshgrinder","id":1059453,"avatar_url":"https://avatars3.githubusercontent.com/u/1059453?v=4","gravatar_id":"","url":"https://api.github.com/users/Fleshgrinder","html_url":"https://github.com/Fleshgrinder","followers_url":"https://api.github.com/users/Fleshgrinder/followers","following_url":"https://api.github.com/users/Fleshgrinder/following{/other_user}","gists_url":"https://api.github.com/users/Fleshgrinder/gists{/gist_id}","starred_url":"https://api.github.com/users/Fleshgrinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fleshgrinder/subscriptions","organizations_url":"https://api.github.com/users/Fleshgrinder/orgs","repos_url":"https://api.github.com/users/Fleshgrinder/repos","events_url":"https://api.github.com/users/Fleshgrinder/events{/privacy}","received_events_url":"https://api.github.com/users/Fleshgrinder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fleshgrinder/php-src","description":"The PHP Interpreter","fork":true,"url":"https://api.github.com/repos/Fleshgrinder/php-src","forks_url":"https://api.github.com/repos/Fleshgrinder/php-src/forks","keys_url":"https://api.github.com/repos/Fleshgrinder/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fleshgrinder/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fleshgrinder/php-src/teams","hooks_url":"https://api.github.com/repos/Fleshgrinder/php-src/hooks","issue_events_url":"https://api.github.com/repos/Fleshgrinder/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/Fleshgrinder/php-src/events","assignees_url":"https://api.github.com/repos/Fleshgrinder/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/Fleshgrinder/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/Fleshgrinder/php-src/tags","blobs_url":"https://api.github.com/repos/Fleshgrinder/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fleshgrinder/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fleshgrinder/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fleshgrinder/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fleshgrinder/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/Fleshgrinder/php-src/languages","stargazers_url":"https://api.github.com/repos/Fleshgrinder/php-src/stargazers","contributors_url":"https://api.github.com/repos/Fleshgrinder/php-src/contributors","subscribers_url":"https://api.github.com/repos/Fleshgrinder/php-src/subscribers","subscription_url":"https://api.github.com/repos/Fleshgrinder/php-src/subscription","commits_url":"https://api.github.com/repos/Fleshgrinder/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fleshgrinder/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fleshgrinder/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fleshgrinder/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fleshgrinder/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/Fleshgrinder/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fleshgrinder/php-src/merges","archive_url":"https://api.github.com/repos/Fleshgrinder/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fleshgrinder/php-src/downloads","issues_url":"https://api.github.com/repos/Fleshgrinder/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/Fleshgrinder/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/Fleshgrinder/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/Fleshgrinder/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fleshgrinder/php-src/labels{/name}","releases_url":"https://api.github.com/repos/Fleshgrinder/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/Fleshgrinder/php-src/deployments","created_at":"2016-05-22T09:32:46Z","updated_at":"2016-05-22T09:33:43Z","pushed_at":"2017-08-20T10:35:10Z","git_url":"git://github.com/Fleshgrinder/php-src.git","ssh_url":"[email protected]:Fleshgrinder/php-src.git","clone_url":"https://github.com/Fleshgrinder/php-src.git","svn_url":"https://github.com/Fleshgrinder/php-src","homepage":"http://www.php.net","size":291514,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php:master","ref":"master","sha":"46ef3e237c1c51a558b2f892ad526016614aff00","user":{"login":"php","id":25158,"avatar_url":"https://avatars2.githubusercontent.com/u/25158?v=4","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"repo":{"id":1903522,"name":"php-src","full_name":"php/php-src","owner":{"login":"php","id":25158,"avatar_url":"https://avatars2.githubusercontent.com/u/25158?v=4","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php/php-src","description":"The PHP Interpreter","fork":false,"url":"https://api.github.com/repos/php/php-src","forks_url":"https://api.github.com/repos/php/php-src/forks","keys_url":"https://api.github.com/repos/php/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php/php-src/teams","hooks_url":"https://api.github.com/repos/php/php-src/hooks","issue_events_url":"https://api.github.com/repos/php/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/php/php-src/events","assignees_url":"https://api.github.com/repos/php/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/php/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/php/php-src/tags","blobs_url":"https://api.github.com/repos/php/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/php/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/php/php-src/languages","stargazers_url":"https://api.github.com/repos/php/php-src/stargazers","contributors_url":"https://api.github.com/repos/php/php-src/contributors","subscribers_url":"https://api.github.com/repos/php/php-src/subscribers","subscription_url":"https://api.github.com/repos/php/php-src/subscription","commits_url":"https://api.github.com/repos/php/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/php/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/php/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/php/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/php/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/php/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php/php-src/merges","archive_url":"https://api.github.com/repos/php/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php/php-src/downloads","issues_url":"https://api.github.com/repos/php/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/php/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/php/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/php/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php/php-src/labels{/name}","releases_url":"https://api.github.com/repos/php/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/php/php-src/deployments","created_at":"2011-06-16T01:52:25Z","updated_at":"2017-09-02T17:54:56Z","pushed_at":"2017-09-02T14:59:54Z","git_url":"git://github.com/php/php-src.git","ssh_url":"[email protected]:php/php-src.git","clone_url":"https://github.com/php/php-src.git","svn_url":"https://github.com/php/php-src","homepage":"http://www.php.net","size":297142,"stargazers_count":12755,"watchers_count":12755,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4319,"mirror_url":null,"open_issues_count":114,"forks":4319,"open_issues":114,"watchers":12755,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/2535"},"html":{"href":"https://github.com/php/php-src/pull/2535"},"issue":{"href":"https://api.github.com/repos/php/php-src/issues/2535"},"comments":{"href":"https://api.github.com/repos/php/php-src/issues/2535/comments"},"review_comments":{"href":"https://api.github.com/repos/php/php-src/pulls/2535/comments"},"review_comment":{"href":"https://api.github.com/repos/php/php-src/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php/php-src/pulls/2535/commits"},"statuses":{"href":"https://api.github.com/repos/php/php-src/statuses/3dc104e0dc13257ec78e51ce4637e737002da7d3"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1903522,
"name": "php/php-src",
"url": "https://api.github.com/repos/php/php-src"
} | {
"id": 216080,
"login": "nikic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/216080?",
"url": "https://api.github.com/users/nikic"
} | {
"id": 25158,
"login": "php",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25158?",
"url": "https://api.github.com/orgs/php"
} | 2017-09-02T18:29:43 | 6543181792 | {"actor":{"display_login":"nikic"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pmd/pmd/pulls/comments/135422169","pull_request_review_id":58832517,"id":135422169,"diff_hunk":"@@ -52,8 +52,10 @@ public Object visit(ASTMethodDeclaration method, Object data) {\n The same goes for class metrics: you select one among `JavaClassMetricKey`'s constants and pass it along with the node\n to `JavaMetrics.get`.\n \n- {%include tip.html content=\"A new visitor adapter (`JavaParserVisitorReducedAdapter`) exists to e.g. check \n- constructors and method nodes completely alike. This comes in handy for metrics, as they usually don't make the distinction\" %}\n+ {%include tip.html\n+ content=\"A specific base rule class (`AbstractJavaMetricsRule`) exists","path":"docs/pages/pmd/devdocs/metrics_howto.md","position":27,"original_position":27,"commit_id":"c1459ab4f90a7253147292181e0a96b68568971b","original_commit_id":"c1459ab4f90a7253147292181e0a96b68568971b","user":{"login":"oowekyala","id":24524930,"avatar_url":"https://avatars0.githubusercontent.com/u/24524930?v=4","gravatar_id":"","url":"https://api.github.com/users/oowekyala","html_url":"https://github.com/oowekyala","followers_url":"https://api.github.com/users/oowekyala/followers","following_url":"https://api.github.com/users/oowekyala/following{/other_user}","gists_url":"https://api.github.com/users/oowekyala/gists{/gist_id}","starred_url":"https://api.github.com/users/oowekyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oowekyala/subscriptions","organizations_url":"https://api.github.com/users/oowekyala/orgs","repos_url":"https://api.github.com/users/oowekyala/repos","events_url":"https://api.github.com/users/oowekyala/events{/privacy}","received_events_url":"https://api.github.com/users/oowekyala/received_events","type":"User","site_admin":false},"body":"Same thing as above, in fine the `usesMetrics` method will be removed from the Rule interface","created_at":"2017-08-27T21:51:31Z","updated_at":"2017-08-27T21:51:31Z","html_url":"https://github.com/pmd/pmd/pull/583#discussion_r135422169","pull_request_url":"https://api.github.com/repos/pmd/pmd/pulls/583","_links":{"self":{"href":"https://api.github.com/repos/pmd/pmd/pulls/comments/135422169"},"html":{"href":"https://github.com/pmd/pmd/pull/583#discussion_r135422169"},"pull_request":{"href":"https://api.github.com/repos/pmd/pmd/pulls/583"}},"in_reply_to_id":135417197},"pull_request":{"url":"https://api.github.com/repos/pmd/pmd/pulls/583","id":137810271,"html_url":"https://github.com/pmd/pmd/pull/583","diff_url":"https://github.com/pmd/pmd/pull/583.diff","patch_url":"https://github.com/pmd/pmd/pull/583.patch","issue_url":"https://api.github.com/repos/pmd/pmd/issues/583","number":583,"state":"open","locked":false,"title":"[java] Documentation about writing metrics","user":{"login":"oowekyala","id":24524930,"avatar_url":"https://avatars0.githubusercontent.com/u/24524930?v=4","gravatar_id":"","url":"https://api.github.com/users/oowekyala","html_url":"https://github.com/oowekyala","followers_url":"https://api.github.com/users/oowekyala/followers","following_url":"https://api.github.com/users/oowekyala/following{/other_user}","gists_url":"https://api.github.com/users/oowekyala/gists{/gist_id}","starred_url":"https://api.github.com/users/oowekyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oowekyala/subscriptions","organizations_url":"https://api.github.com/users/oowekyala/orgs","repos_url":"https://api.github.com/users/oowekyala/repos","events_url":"https://api.github.com/users/oowekyala/events{/privacy}","received_events_url":"https://api.github.com/users/oowekyala/received_events","type":"User","site_admin":false},"body":"Hey,\r\nThis is the documentation about writing metrics. Not sure it's the clearest it could be, feel free to give your opinion","created_at":"2017-08-26T20:02:21Z","updated_at":"2017-08-27T21:51:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbb05389414305a1eab17528805f4df3aeb386f2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/pmd/pmd/milestones/12","html_url":"https://github.com/pmd/pmd/milestone/12","labels_url":"https://api.github.com/repos/pmd/pmd/milestones/12/labels","id":2508081,"number":12,"title":"6.0.0","description":"","creator":{"login":"adangel","id":1573684,"avatar_url":"https://avatars2.githubusercontent.com/u/1573684?v=4","gravatar_id":"","url":"https://api.github.com/users/adangel","html_url":"https://github.com/adangel","followers_url":"https://api.github.com/users/adangel/followers","following_url":"https://api.github.com/users/adangel/following{/other_user}","gists_url":"https://api.github.com/users/adangel/gists{/gist_id}","starred_url":"https://api.github.com/users/adangel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adangel/subscriptions","organizations_url":"https://api.github.com/users/adangel/orgs","repos_url":"https://api.github.com/users/adangel/repos","events_url":"https://api.github.com/users/adangel/events{/privacy}","received_events_url":"https://api.github.com/users/adangel/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":77,"state":"open","created_at":"2017-05-08T18:30:49Z","updated_at":"2017-08-27T17:40:51Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/pmd/pmd/pulls/583/commits","review_comments_url":"https://api.github.com/repos/pmd/pmd/pulls/583/comments","review_comment_url":"https://api.github.com/repos/pmd/pmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pmd/pmd/issues/583/comments","statuses_url":"https://api.github.com/repos/pmd/pmd/statuses/c1459ab4f90a7253147292181e0a96b68568971b","head":{"label":"oowekyala:docs-metrics","ref":"docs-metrics","sha":"c1459ab4f90a7253147292181e0a96b68568971b","user":{"login":"oowekyala","id":24524930,"avatar_url":"https://avatars0.githubusercontent.com/u/24524930?v=4","gravatar_id":"","url":"https://api.github.com/users/oowekyala","html_url":"https://github.com/oowekyala","followers_url":"https://api.github.com/users/oowekyala/followers","following_url":"https://api.github.com/users/oowekyala/following{/other_user}","gists_url":"https://api.github.com/users/oowekyala/gists{/gist_id}","starred_url":"https://api.github.com/users/oowekyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oowekyala/subscriptions","organizations_url":"https://api.github.com/users/oowekyala/orgs","repos_url":"https://api.github.com/users/oowekyala/repos","events_url":"https://api.github.com/users/oowekyala/events{/privacy}","received_events_url":"https://api.github.com/users/oowekyala/received_events","type":"User","site_admin":false},"repo":{"id":84992686,"name":"pmd","full_name":"oowekyala/pmd","owner":{"login":"oowekyala","id":24524930,"avatar_url":"https://avatars0.githubusercontent.com/u/24524930?v=4","gravatar_id":"","url":"https://api.github.com/users/oowekyala","html_url":"https://github.com/oowekyala","followers_url":"https://api.github.com/users/oowekyala/followers","following_url":"https://api.github.com/users/oowekyala/following{/other_user}","gists_url":"https://api.github.com/users/oowekyala/gists{/gist_id}","starred_url":"https://api.github.com/users/oowekyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oowekyala/subscriptions","organizations_url":"https://api.github.com/users/oowekyala/orgs","repos_url":"https://api.github.com/users/oowekyala/repos","events_url":"https://api.github.com/users/oowekyala/events{/privacy}","received_events_url":"https://api.github.com/users/oowekyala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oowekyala/pmd","description":null,"fork":true,"url":"https://api.github.com/repos/oowekyala/pmd","forks_url":"https://api.github.com/repos/oowekyala/pmd/forks","keys_url":"https://api.github.com/repos/oowekyala/pmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oowekyala/pmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oowekyala/pmd/teams","hooks_url":"https://api.github.com/repos/oowekyala/pmd/hooks","issue_events_url":"https://api.github.com/repos/oowekyala/pmd/issues/events{/number}","events_url":"https://api.github.com/repos/oowekyala/pmd/events","assignees_url":"https://api.github.com/repos/oowekyala/pmd/assignees{/user}","branches_url":"https://api.github.com/repos/oowekyala/pmd/branches{/branch}","tags_url":"https://api.github.com/repos/oowekyala/pmd/tags","blobs_url":"https://api.github.com/repos/oowekyala/pmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oowekyala/pmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oowekyala/pmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/oowekyala/pmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oowekyala/pmd/statuses/{sha}","languages_url":"https://api.github.com/repos/oowekyala/pmd/languages","stargazers_url":"https://api.github.com/repos/oowekyala/pmd/stargazers","contributors_url":"https://api.github.com/repos/oowekyala/pmd/contributors","subscribers_url":"https://api.github.com/repos/oowekyala/pmd/subscribers","subscription_url":"https://api.github.com/repos/oowekyala/pmd/subscription","commits_url":"https://api.github.com/repos/oowekyala/pmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/oowekyala/pmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/oowekyala/pmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/oowekyala/pmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/oowekyala/pmd/contents/{+path}","compare_url":"https://api.github.com/repos/oowekyala/pmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oowekyala/pmd/merges","archive_url":"https://api.github.com/repos/oowekyala/pmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oowekyala/pmd/downloads","issues_url":"https://api.github.com/repos/oowekyala/pmd/issues{/number}","pulls_url":"https://api.github.com/repos/oowekyala/pmd/pulls{/number}","milestones_url":"https://api.github.com/repos/oowekyala/pmd/milestones{/number}","notifications_url":"https://api.github.com/repos/oowekyala/pmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oowekyala/pmd/labels{/name}","releases_url":"https://api.github.com/repos/oowekyala/pmd/releases{/id}","deployments_url":"https://api.github.com/repos/oowekyala/pmd/deployments","created_at":"2017-03-14T20:11:44Z","updated_at":"2017-05-06T21:02:10Z","pushed_at":"2017-08-27T21:45:10Z","git_url":"git://github.com/oowekyala/pmd.git","ssh_url":"[email protected]:oowekyala/pmd.git","clone_url":"https://github.com/oowekyala/pmd.git","svn_url":"https://github.com/oowekyala/pmd","homepage":"https://pmd.github.io","size":234948,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"pmd:master","ref":"master","sha":"23a936e6548b228410c7c402265b578aaa1d3bf3","user":{"login":"pmd","id":1958157,"avatar_url":"https://avatars0.githubusercontent.com/u/1958157?v=4","gravatar_id":"","url":"https://api.github.com/users/pmd","html_url":"https://github.com/pmd","followers_url":"https://api.github.com/users/pmd/followers","following_url":"https://api.github.com/users/pmd/following{/other_user}","gists_url":"https://api.github.com/users/pmd/gists{/gist_id}","starred_url":"https://api.github.com/users/pmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmd/subscriptions","organizations_url":"https://api.github.com/users/pmd/orgs","repos_url":"https://api.github.com/users/pmd/repos","events_url":"https://api.github.com/users/pmd/events{/privacy}","received_events_url":"https://api.github.com/users/pmd/received_events","type":"Organization","site_admin":false},"repo":{"id":4992906,"name":"pmd","full_name":"pmd/pmd","owner":{"login":"pmd","id":1958157,"avatar_url":"https://avatars0.githubusercontent.com/u/1958157?v=4","gravatar_id":"","url":"https://api.github.com/users/pmd","html_url":"https://github.com/pmd","followers_url":"https://api.github.com/users/pmd/followers","following_url":"https://api.github.com/users/pmd/following{/other_user}","gists_url":"https://api.github.com/users/pmd/gists{/gist_id}","starred_url":"https://api.github.com/users/pmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmd/subscriptions","organizations_url":"https://api.github.com/users/pmd/orgs","repos_url":"https://api.github.com/users/pmd/repos","events_url":"https://api.github.com/users/pmd/events{/privacy}","received_events_url":"https://api.github.com/users/pmd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pmd/pmd","description":"An extensible cross-language static code analyzer.","fork":false,"url":"https://api.github.com/repos/pmd/pmd","forks_url":"https://api.github.com/repos/pmd/pmd/forks","keys_url":"https://api.github.com/repos/pmd/pmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmd/pmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmd/pmd/teams","hooks_url":"https://api.github.com/repos/pmd/pmd/hooks","issue_events_url":"https://api.github.com/repos/pmd/pmd/issues/events{/number}","events_url":"https://api.github.com/repos/pmd/pmd/events","assignees_url":"https://api.github.com/repos/pmd/pmd/assignees{/user}","branches_url":"https://api.github.com/repos/pmd/pmd/branches{/branch}","tags_url":"https://api.github.com/repos/pmd/pmd/tags","blobs_url":"https://api.github.com/repos/pmd/pmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmd/pmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmd/pmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmd/pmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmd/pmd/statuses/{sha}","languages_url":"https://api.github.com/repos/pmd/pmd/languages","stargazers_url":"https://api.github.com/repos/pmd/pmd/stargazers","contributors_url":"https://api.github.com/repos/pmd/pmd/contributors","subscribers_url":"https://api.github.com/repos/pmd/pmd/subscribers","subscription_url":"https://api.github.com/repos/pmd/pmd/subscription","commits_url":"https://api.github.com/repos/pmd/pmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmd/pmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmd/pmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmd/pmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmd/pmd/contents/{+path}","compare_url":"https://api.github.com/repos/pmd/pmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmd/pmd/merges","archive_url":"https://api.github.com/repos/pmd/pmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmd/pmd/downloads","issues_url":"https://api.github.com/repos/pmd/pmd/issues{/number}","pulls_url":"https://api.github.com/repos/pmd/pmd/pulls{/number}","milestones_url":"https://api.github.com/repos/pmd/pmd/milestones{/number}","notifications_url":"https://api.github.com/repos/pmd/pmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmd/pmd/labels{/name}","releases_url":"https://api.github.com/repos/pmd/pmd/releases{/id}","deployments_url":"https://api.github.com/repos/pmd/pmd/deployments","created_at":"2012-07-11T18:03:00Z","updated_at":"2017-08-27T09:47:50Z","pushed_at":"2017-08-26T20:02:22Z","git_url":"git://github.com/pmd/pmd.git","ssh_url":"[email protected]:pmd/pmd.git","clone_url":"https://github.com/pmd/pmd.git","svn_url":"https://github.com/pmd/pmd","homepage":"https://pmd.github.io","size":234845,"stargazers_count":1100,"watchers_count":1100,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":393,"mirror_url":null,"open_issues_count":72,"forks":393,"open_issues":72,"watchers":1100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pmd/pmd/pulls/583"},"html":{"href":"https://github.com/pmd/pmd/pull/583"},"issue":{"href":"https://api.github.com/repos/pmd/pmd/issues/583"},"comments":{"href":"https://api.github.com/repos/pmd/pmd/issues/583/comments"},"review_comments":{"href":"https://api.github.com/repos/pmd/pmd/pulls/583/comments"},"review_comment":{"href":"https://api.github.com/repos/pmd/pmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pmd/pmd/pulls/583/commits"},"statuses":{"href":"https://api.github.com/repos/pmd/pmd/statuses/c1459ab4f90a7253147292181e0a96b68568971b"}}}} | {
"id": 4992906,
"name": "pmd/pmd",
"url": "https://api.github.com/repos/pmd/pmd"
} | {
"id": 24524930,
"login": "oowekyala",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24524930?",
"url": "https://api.github.com/users/oowekyala"
} | {
"id": 1958157,
"login": "pmd",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1958157?",
"url": "https://api.github.com/orgs/pmd"
} | 2017-08-27T21:51:31 | 6517329759 | {"actor":{"display_login":"oowekyala"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ppy/osu-web/pulls/comments/108562948","pull_request_review_id":29602007,"id":108562948,"diff_hunk":"@@ -20,10 +20,37 @@\n \n namespace App\\Models;\n \n+use Cache;\n+\n class BanchoStats extends Model\n {\n protected $table = 'osu_banchostats';\n protected $primaryKey = 'banchostats_id';\n \n public $timestamps = false;\n+\n+ public static function cachedStats()\n+ {\n+ return Cache::remember('banchostats', 60, function () {\n+ return self::whereRaw('banchostats_id mod 10 = 0')\n+ ->select(['users_irc', 'users_osu', 'multiplayer_games', 'date'])\n+ ->orderBy('banchostats_id', 'DESC')\n+ ->limit(144) // aka 24 * 60 / 10\n+ ->get();\n+ });\n+ }\n+\n+ public static function userGraphData()\n+ {\n+ $stats = self::cachedStats()->toArray();","path":"app/Models/BanchoStats.php","position":26,"original_position":26,"commit_id":"119c3fbad316cfe30c27f744ae99b2fa2088bba2","original_commit_id":"119c3fbad316cfe30c27f744ae99b2fa2088bba2","user":{"login":"nekodex","id":272140,"avatar_url":"https://avatars3.githubusercontent.com/u/272140?v=3","gravatar_id":"","url":"https://api.github.com/users/nekodex","html_url":"https://github.com/nekodex","followers_url":"https://api.github.com/users/nekodex/followers","following_url":"https://api.github.com/users/nekodex/following{/other_user}","gists_url":"https://api.github.com/users/nekodex/gists{/gist_id}","starred_url":"https://api.github.com/users/nekodex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nekodex/subscriptions","organizations_url":"https://api.github.com/users/nekodex/orgs","repos_url":"https://api.github.com/users/nekodex/repos","events_url":"https://api.github.com/users/nekodex/events{/privacy}","received_events_url":"https://api.github.com/users/nekodex/received_events","type":"User","site_admin":false},"body":"hrm worth memoising? or maybe just make a transformer or something...","created_at":"2017-03-28T23:35:26Z","updated_at":"2017-03-28T23:35:26Z","html_url":"https://github.com/ppy/osu-web/pull/1054#discussion_r108562948","pull_request_url":"https://api.github.com/repos/ppy/osu-web/pulls/1054","_links":{"self":{"href":"https://api.github.com/repos/ppy/osu-web/pulls/comments/108562948"},"html":{"href":"https://github.com/ppy/osu-web/pull/1054#discussion_r108562948"},"pull_request":{"href":"https://api.github.com/repos/ppy/osu-web/pulls/1054"}}},"pull_request":{"url":"https://api.github.com/repos/ppy/osu-web/pulls/1054","id":112884027,"html_url":"https://github.com/ppy/osu-web/pull/1054","diff_url":"https://github.com/ppy/osu-web/pull/1054.diff","patch_url":"https://github.com/ppy/osu-web/pull/1054.patch","issue_url":"https://api.github.com/repos/ppy/osu-web/issues/1054","number":1054,"state":"open","locked":false,"title":"Home page for logged-in users","user":{"login":"nekodex","id":272140,"avatar_url":"https://avatars3.githubusercontent.com/u/272140?v=3","gravatar_id":"","url":"https://api.github.com/users/nekodex","html_url":"https://github.com/nekodex","followers_url":"https://api.github.com/users/nekodex/followers","following_url":"https://api.github.com/users/nekodex/following{/other_user}","gists_url":"https://api.github.com/users/nekodex/gists{/gist_id}","starred_url":"https://api.github.com/users/nekodex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nekodex/subscriptions","organizations_url":"https://api.github.com/users/nekodex/orgs","repos_url":"https://api.github.com/users/nekodex/repos","events_url":"https://api.github.com/users/nekodex/events{/privacy}","received_events_url":"https://api.github.com/users/nekodex/received_events","type":"User","site_admin":false},"body":"This was started a while ago, so I may have missed some silly things... 🙄\r\n\r\n","created_at":"2017-03-28T03:40:27Z","updated_at":"2017-03-28T23:35:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99bec454db39465b681a3103d6eaa54e0ee2a767","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ppy/osu-web/pulls/1054/commits","review_comments_url":"https://api.github.com/repos/ppy/osu-web/pulls/1054/comments","review_comment_url":"https://api.github.com/repos/ppy/osu-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ppy/osu-web/issues/1054/comments","statuses_url":"https://api.github.com/repos/ppy/osu-web/statuses/119c3fbad316cfe30c27f744ae99b2fa2088bba2","head":{"label":"ppy:nekodex/user-home","ref":"nekodex/user-home","sha":"119c3fbad316cfe30c27f744ae99b2fa2088bba2","user":{"login":"ppy","id":995763,"avatar_url":"https://avatars2.githubusercontent.com/u/995763?v=3","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"repo":{"id":41410580,"name":"osu-web","full_name":"ppy/osu-web","owner":{"login":"ppy","id":995763,"avatar_url":"https://avatars2.githubusercontent.com/u/995763?v=3","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ppy/osu-web","description":"the future face of osu!","fork":false,"url":"https://api.github.com/repos/ppy/osu-web","forks_url":"https://api.github.com/repos/ppy/osu-web/forks","keys_url":"https://api.github.com/repos/ppy/osu-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppy/osu-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppy/osu-web/teams","hooks_url":"https://api.github.com/repos/ppy/osu-web/hooks","issue_events_url":"https://api.github.com/repos/ppy/osu-web/issues/events{/number}","events_url":"https://api.github.com/repos/ppy/osu-web/events","assignees_url":"https://api.github.com/repos/ppy/osu-web/assignees{/user}","branches_url":"https://api.github.com/repos/ppy/osu-web/branches{/branch}","tags_url":"https://api.github.com/repos/ppy/osu-web/tags","blobs_url":"https://api.github.com/repos/ppy/osu-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppy/osu-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppy/osu-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppy/osu-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppy/osu-web/statuses/{sha}","languages_url":"https://api.github.com/repos/ppy/osu-web/languages","stargazers_url":"https://api.github.com/repos/ppy/osu-web/stargazers","contributors_url":"https://api.github.com/repos/ppy/osu-web/contributors","subscribers_url":"https://api.github.com/repos/ppy/osu-web/subscribers","subscription_url":"https://api.github.com/repos/ppy/osu-web/subscription","commits_url":"https://api.github.com/repos/ppy/osu-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppy/osu-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppy/osu-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppy/osu-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppy/osu-web/contents/{+path}","compare_url":"https://api.github.com/repos/ppy/osu-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppy/osu-web/merges","archive_url":"https://api.github.com/repos/ppy/osu-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppy/osu-web/downloads","issues_url":"https://api.github.com/repos/ppy/osu-web/issues{/number}","pulls_url":"https://api.github.com/repos/ppy/osu-web/pulls{/number}","milestones_url":"https://api.github.com/repos/ppy/osu-web/milestones{/number}","notifications_url":"https://api.github.com/repos/ppy/osu-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppy/osu-web/labels{/name}","releases_url":"https://api.github.com/repos/ppy/osu-web/releases{/id}","deployments_url":"https://api.github.com/repos/ppy/osu-web/deployments","created_at":"2015-08-26T07:14:32Z","updated_at":"2017-03-11T20:57:56Z","pushed_at":"2017-03-28T07:11:03Z","git_url":"git://github.com/ppy/osu-web.git","ssh_url":"[email protected]:ppy/osu-web.git","clone_url":"https://github.com/ppy/osu-web.git","svn_url":"https://github.com/ppy/osu-web","homepage":null,"size":32881,"stargazers_count":256,"watchers_count":256,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":70,"forks":120,"open_issues":70,"watchers":256,"default_branch":"master"}},"base":{"label":"ppy:master","ref":"master","sha":"0fd3b1fe0d55f82a0b1a516e5f99ff495ae648eb","user":{"login":"ppy","id":995763,"avatar_url":"https://avatars2.githubusercontent.com/u/995763?v=3","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"repo":{"id":41410580,"name":"osu-web","full_name":"ppy/osu-web","owner":{"login":"ppy","id":995763,"avatar_url":"https://avatars2.githubusercontent.com/u/995763?v=3","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ppy/osu-web","description":"the future face of osu!","fork":false,"url":"https://api.github.com/repos/ppy/osu-web","forks_url":"https://api.github.com/repos/ppy/osu-web/forks","keys_url":"https://api.github.com/repos/ppy/osu-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppy/osu-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppy/osu-web/teams","hooks_url":"https://api.github.com/repos/ppy/osu-web/hooks","issue_events_url":"https://api.github.com/repos/ppy/osu-web/issues/events{/number}","events_url":"https://api.github.com/repos/ppy/osu-web/events","assignees_url":"https://api.github.com/repos/ppy/osu-web/assignees{/user}","branches_url":"https://api.github.com/repos/ppy/osu-web/branches{/branch}","tags_url":"https://api.github.com/repos/ppy/osu-web/tags","blobs_url":"https://api.github.com/repos/ppy/osu-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppy/osu-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppy/osu-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppy/osu-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppy/osu-web/statuses/{sha}","languages_url":"https://api.github.com/repos/ppy/osu-web/languages","stargazers_url":"https://api.github.com/repos/ppy/osu-web/stargazers","contributors_url":"https://api.github.com/repos/ppy/osu-web/contributors","subscribers_url":"https://api.github.com/repos/ppy/osu-web/subscribers","subscription_url":"https://api.github.com/repos/ppy/osu-web/subscription","commits_url":"https://api.github.com/repos/ppy/osu-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppy/osu-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppy/osu-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppy/osu-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppy/osu-web/contents/{+path}","compare_url":"https://api.github.com/repos/ppy/osu-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppy/osu-web/merges","archive_url":"https://api.github.com/repos/ppy/osu-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppy/osu-web/downloads","issues_url":"https://api.github.com/repos/ppy/osu-web/issues{/number}","pulls_url":"https://api.github.com/repos/ppy/osu-web/pulls{/number}","milestones_url":"https://api.github.com/repos/ppy/osu-web/milestones{/number}","notifications_url":"https://api.github.com/repos/ppy/osu-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppy/osu-web/labels{/name}","releases_url":"https://api.github.com/repos/ppy/osu-web/releases{/id}","deployments_url":"https://api.github.com/repos/ppy/osu-web/deployments","created_at":"2015-08-26T07:14:32Z","updated_at":"2017-03-11T20:57:56Z","pushed_at":"2017-03-28T07:11:03Z","git_url":"git://github.com/ppy/osu-web.git","ssh_url":"[email protected]:ppy/osu-web.git","clone_url":"https://github.com/ppy/osu-web.git","svn_url":"https://github.com/ppy/osu-web","homepage":null,"size":32881,"stargazers_count":256,"watchers_count":256,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":70,"forks":120,"open_issues":70,"watchers":256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ppy/osu-web/pulls/1054"},"html":{"href":"https://github.com/ppy/osu-web/pull/1054"},"issue":{"href":"https://api.github.com/repos/ppy/osu-web/issues/1054"},"comments":{"href":"https://api.github.com/repos/ppy/osu-web/issues/1054/comments"},"review_comments":{"href":"https://api.github.com/repos/ppy/osu-web/pulls/1054/comments"},"review_comment":{"href":"https://api.github.com/repos/ppy/osu-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ppy/osu-web/pulls/1054/commits"},"statuses":{"href":"https://api.github.com/repos/ppy/osu-web/statuses/119c3fbad316cfe30c27f744ae99b2fa2088bba2"}}}} | {
"id": 41410580,
"name": "ppy/osu-web",
"url": "https://api.github.com/repos/ppy/osu-web"
} | {
"id": 272140,
"login": "nekodex",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/272140?",
"url": "https://api.github.com/users/nekodex"
} | {
"id": 995763,
"login": "ppy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/995763?",
"url": "https://api.github.com/orgs/ppy"
} | 2017-03-28T23:35:26 | 5583234405 | {"actor":{"display_login":"nekodex"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ppy/osu-wiki/pulls/comments/127578180","pull_request_review_id":50183388,"id":127578180,"diff_hunk":"@@ -0,0 +1,81 @@\n+Правила\n+============\n+\n+Данные правила - основы для osu! сообщества, которые поддерживают игру весёлой и приятной для всех.\n+\n+Правила сообщества\n+-------------------\n+\n+1. **Каждый игрок может зарегистрировать и использовать для игры только один *один* аккаунт.** Этот аккаунт - Ваше лицо. И ничейное более - не Вашего брата, матери, сестры или друга - это Ваш аккаунт. Не делитесь своим аккаунтом с кем-либо.","path":"wiki/Rules/ru.md","position":9,"original_position":9,"commit_id":"d5a85cbbddd049fd3ac6a76a02037c2ff076a59b","original_commit_id":"d5a85cbbddd049fd3ac6a76a02037c2ff076a59b","user":{"login":"SkiLeN","id":30177915,"avatar_url":"https://avatars4.githubusercontent.com/u/30177915?v=4","gravatar_id":"","url":"https://api.github.com/users/SkiLeN","html_url":"https://github.com/SkiLeN","followers_url":"https://api.github.com/users/SkiLeN/followers","following_url":"https://api.github.com/users/SkiLeN/following{/other_user}","gists_url":"https://api.github.com/users/SkiLeN/gists{/gist_id}","starred_url":"https://api.github.com/users/SkiLeN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkiLeN/subscriptions","organizations_url":"https://api.github.com/users/SkiLeN/orgs","repos_url":"https://api.github.com/users/SkiLeN/repos","events_url":"https://api.github.com/users/SkiLeN/events{/privacy}","received_events_url":"https://api.github.com/users/SkiLeN/received_events","type":"User","site_admin":false},"body":"Somehow didn't notice that","created_at":"2017-07-15T06:32:42Z","updated_at":"2017-07-15T06:32:42Z","html_url":"https://github.com/ppy/osu-wiki/pull/494#discussion_r127578180","pull_request_url":"https://api.github.com/repos/ppy/osu-wiki/pulls/494","_links":{"self":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/comments/127578180"},"html":{"href":"https://github.com/ppy/osu-wiki/pull/494#discussion_r127578180"},"pull_request":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/494"}}},"pull_request":{"url":"https://api.github.com/repos/ppy/osu-wiki/pulls/494","id":130641308,"html_url":"https://github.com/ppy/osu-wiki/pull/494","diff_url":"https://github.com/ppy/osu-wiki/pull/494.diff","patch_url":"https://github.com/ppy/osu-wiki/pull/494.patch","issue_url":"https://api.github.com/repos/ppy/osu-wiki/issues/494","number":494,"state":"open","locked":false,"title":"SkiLeN's translated version of english rules on Russian.","user":{"login":"SkiLeN","id":30177915,"avatar_url":"https://avatars4.githubusercontent.com/u/30177915?v=4","gravatar_id":"","url":"https://api.github.com/users/SkiLeN","html_url":"https://github.com/SkiLeN","followers_url":"https://api.github.com/users/SkiLeN/followers","following_url":"https://api.github.com/users/SkiLeN/following{/other_user}","gists_url":"https://api.github.com/users/SkiLeN/gists{/gist_id}","starred_url":"https://api.github.com/users/SkiLeN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkiLeN/subscriptions","organizations_url":"https://api.github.com/users/SkiLeN/orgs","repos_url":"https://api.github.com/users/SkiLeN/repos","events_url":"https://api.github.com/users/SkiLeN/events{/privacy}","received_events_url":"https://api.github.com/users/SkiLeN/received_events","type":"User","site_admin":false},"body":"I have done the translation of rules in the osu! Wiki","created_at":"2017-07-14T17:57:07Z","updated_at":"2017-07-15T06:32:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4632a78f17d522003046d29454f5a2c83741e44","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ppy/osu-wiki/pulls/494/commits","review_comments_url":"https://api.github.com/repos/ppy/osu-wiki/pulls/494/comments","review_comment_url":"https://api.github.com/repos/ppy/osu-wiki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ppy/osu-wiki/issues/494/comments","statuses_url":"https://api.github.com/repos/ppy/osu-wiki/statuses/d5a85cbbddd049fd3ac6a76a02037c2ff076a59b","head":{"label":"SkiLeN:master","ref":"master","sha":"d5a85cbbddd049fd3ac6a76a02037c2ff076a59b","user":{"login":"SkiLeN","id":30177915,"avatar_url":"https://avatars4.githubusercontent.com/u/30177915?v=4","gravatar_id":"","url":"https://api.github.com/users/SkiLeN","html_url":"https://github.com/SkiLeN","followers_url":"https://api.github.com/users/SkiLeN/followers","following_url":"https://api.github.com/users/SkiLeN/following{/other_user}","gists_url":"https://api.github.com/users/SkiLeN/gists{/gist_id}","starred_url":"https://api.github.com/users/SkiLeN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkiLeN/subscriptions","organizations_url":"https://api.github.com/users/SkiLeN/orgs","repos_url":"https://api.github.com/users/SkiLeN/repos","events_url":"https://api.github.com/users/SkiLeN/events{/privacy}","received_events_url":"https://api.github.com/users/SkiLeN/received_events","type":"User","site_admin":false},"repo":{"id":97235983,"name":"osu-wiki","full_name":"SkiLeN/osu-wiki","owner":{"login":"SkiLeN","id":30177915,"avatar_url":"https://avatars4.githubusercontent.com/u/30177915?v=4","gravatar_id":"","url":"https://api.github.com/users/SkiLeN","html_url":"https://github.com/SkiLeN","followers_url":"https://api.github.com/users/SkiLeN/followers","following_url":"https://api.github.com/users/SkiLeN/following{/other_user}","gists_url":"https://api.github.com/users/SkiLeN/gists{/gist_id}","starred_url":"https://api.github.com/users/SkiLeN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkiLeN/subscriptions","organizations_url":"https://api.github.com/users/SkiLeN/orgs","repos_url":"https://api.github.com/users/SkiLeN/repos","events_url":"https://api.github.com/users/SkiLeN/events{/privacy}","received_events_url":"https://api.github.com/users/SkiLeN/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SkiLeN/osu-wiki","description":"future home of osu! wiki","fork":true,"url":"https://api.github.com/repos/SkiLeN/osu-wiki","forks_url":"https://api.github.com/repos/SkiLeN/osu-wiki/forks","keys_url":"https://api.github.com/repos/SkiLeN/osu-wiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SkiLeN/osu-wiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SkiLeN/osu-wiki/teams","hooks_url":"https://api.github.com/repos/SkiLeN/osu-wiki/hooks","issue_events_url":"https://api.github.com/repos/SkiLeN/osu-wiki/issues/events{/number}","events_url":"https://api.github.com/repos/SkiLeN/osu-wiki/events","assignees_url":"https://api.github.com/repos/SkiLeN/osu-wiki/assignees{/user}","branches_url":"https://api.github.com/repos/SkiLeN/osu-wiki/branches{/branch}","tags_url":"https://api.github.com/repos/SkiLeN/osu-wiki/tags","blobs_url":"https://api.github.com/repos/SkiLeN/osu-wiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SkiLeN/osu-wiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SkiLeN/osu-wiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/SkiLeN/osu-wiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SkiLeN/osu-wiki/statuses/{sha}","languages_url":"https://api.github.com/repos/SkiLeN/osu-wiki/languages","stargazers_url":"https://api.github.com/repos/SkiLeN/osu-wiki/stargazers","contributors_url":"https://api.github.com/repos/SkiLeN/osu-wiki/contributors","subscribers_url":"https://api.github.com/repos/SkiLeN/osu-wiki/subscribers","subscription_url":"https://api.github.com/repos/SkiLeN/osu-wiki/subscription","commits_url":"https://api.github.com/repos/SkiLeN/osu-wiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/SkiLeN/osu-wiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/SkiLeN/osu-wiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/SkiLeN/osu-wiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/SkiLeN/osu-wiki/contents/{+path}","compare_url":"https://api.github.com/repos/SkiLeN/osu-wiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SkiLeN/osu-wiki/merges","archive_url":"https://api.github.com/repos/SkiLeN/osu-wiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SkiLeN/osu-wiki/downloads","issues_url":"https://api.github.com/repos/SkiLeN/osu-wiki/issues{/number}","pulls_url":"https://api.github.com/repos/SkiLeN/osu-wiki/pulls{/number}","milestones_url":"https://api.github.com/repos/SkiLeN/osu-wiki/milestones{/number}","notifications_url":"https://api.github.com/repos/SkiLeN/osu-wiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SkiLeN/osu-wiki/labels{/name}","releases_url":"https://api.github.com/repos/SkiLeN/osu-wiki/releases{/id}","deployments_url":"https://api.github.com/repos/SkiLeN/osu-wiki/deployments","created_at":"2017-07-14T13:21:38Z","updated_at":"2017-07-12T16:04:39Z","pushed_at":"2017-07-15T06:20:35Z","git_url":"git://github.com/SkiLeN/osu-wiki.git","ssh_url":"[email protected]:SkiLeN/osu-wiki.git","clone_url":"https://github.com/SkiLeN/osu-wiki.git","svn_url":"https://github.com/SkiLeN/osu-wiki","homepage":null,"size":393111,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ppy:master","ref":"master","sha":"5541270e5d271b0a622b3aa80f77c738495b5d5d","user":{"login":"ppy","id":995763,"avatar_url":"https://avatars5.githubusercontent.com/u/995763?v=4","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"repo":{"id":66639319,"name":"osu-wiki","full_name":"ppy/osu-wiki","owner":{"login":"ppy","id":995763,"avatar_url":"https://avatars5.githubusercontent.com/u/995763?v=4","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ppy/osu-wiki","description":"future home of osu! wiki","fork":false,"url":"https://api.github.com/repos/ppy/osu-wiki","forks_url":"https://api.github.com/repos/ppy/osu-wiki/forks","keys_url":"https://api.github.com/repos/ppy/osu-wiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppy/osu-wiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppy/osu-wiki/teams","hooks_url":"https://api.github.com/repos/ppy/osu-wiki/hooks","issue_events_url":"https://api.github.com/repos/ppy/osu-wiki/issues/events{/number}","events_url":"https://api.github.com/repos/ppy/osu-wiki/events","assignees_url":"https://api.github.com/repos/ppy/osu-wiki/assignees{/user}","branches_url":"https://api.github.com/repos/ppy/osu-wiki/branches{/branch}","tags_url":"https://api.github.com/repos/ppy/osu-wiki/tags","blobs_url":"https://api.github.com/repos/ppy/osu-wiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppy/osu-wiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppy/osu-wiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppy/osu-wiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppy/osu-wiki/statuses/{sha}","languages_url":"https://api.github.com/repos/ppy/osu-wiki/languages","stargazers_url":"https://api.github.com/repos/ppy/osu-wiki/stargazers","contributors_url":"https://api.github.com/repos/ppy/osu-wiki/contributors","subscribers_url":"https://api.github.com/repos/ppy/osu-wiki/subscribers","subscription_url":"https://api.github.com/repos/ppy/osu-wiki/subscription","commits_url":"https://api.github.com/repos/ppy/osu-wiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppy/osu-wiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppy/osu-wiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppy/osu-wiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppy/osu-wiki/contents/{+path}","compare_url":"https://api.github.com/repos/ppy/osu-wiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppy/osu-wiki/merges","archive_url":"https://api.github.com/repos/ppy/osu-wiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppy/osu-wiki/downloads","issues_url":"https://api.github.com/repos/ppy/osu-wiki/issues{/number}","pulls_url":"https://api.github.com/repos/ppy/osu-wiki/pulls{/number}","milestones_url":"https://api.github.com/repos/ppy/osu-wiki/milestones{/number}","notifications_url":"https://api.github.com/repos/ppy/osu-wiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppy/osu-wiki/labels{/name}","releases_url":"https://api.github.com/repos/ppy/osu-wiki/releases{/id}","deployments_url":"https://api.github.com/repos/ppy/osu-wiki/deployments","created_at":"2016-08-26T10:27:36Z","updated_at":"2017-07-12T16:04:39Z","pushed_at":"2017-07-15T06:20:36Z","git_url":"git://github.com/ppy/osu-wiki.git","ssh_url":"[email protected]:ppy/osu-wiki.git","clone_url":"https://github.com/ppy/osu-wiki.git","svn_url":"https://github.com/ppy/osu-wiki","homepage":null,"size":393100,"stargazers_count":68,"watchers_count":68,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":109,"mirror_url":null,"open_issues_count":68,"forks":109,"open_issues":68,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/494"},"html":{"href":"https://github.com/ppy/osu-wiki/pull/494"},"issue":{"href":"https://api.github.com/repos/ppy/osu-wiki/issues/494"},"comments":{"href":"https://api.github.com/repos/ppy/osu-wiki/issues/494/comments"},"review_comments":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/494/comments"},"review_comment":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/494/commits"},"statuses":{"href":"https://api.github.com/repos/ppy/osu-wiki/statuses/d5a85cbbddd049fd3ac6a76a02037c2ff076a59b"}}}} | {
"id": 66639319,
"name": "ppy/osu-wiki",
"url": "https://api.github.com/repos/ppy/osu-wiki"
} | {
"id": 30177915,
"login": "SkiLeN",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30177915?",
"url": "https://api.github.com/users/SkiLeN"
} | {
"id": 995763,
"login": "ppy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/995763?",
"url": "https://api.github.com/orgs/ppy"
} | 2017-07-15T06:32:42 | 6262066876 | {"actor":{"display_login":"SkiLeN"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ppy/osu-wiki/pulls/comments/137925465","pull_request_review_id":61659028,"id":137925465,"diff_hunk":"@@ -0,0 +1,939 @@\n+# Centre d'Aide\n+\n+Vous avez un problème avec quelque chose ? Nous sommes ici pour aider ! Consultez les solutions aux problèmes communs dans la barre latérale à gauche de votre écran.\n+\n+## Compte\n+\n+### J'ai payé pour être supporter, mais je ne l'ai toujours pas reçu !\n+\n+Ce problème dépend du service que vous utilisez (Paypal ou Xsolla), il peut y avoir un léger délai pour traiter votre paiement avant qu'il ne nous arrive.\n+\n+Habituellement, ces problèmes se résolvent par eux-même en quelques heures, et nos systèmes appliqueront automatiquement votre tag à votre compte.\n+\n+Si cela fait 24 heures et que vous n'avez toujours pas reçu votre tag de supporter, veuillez nous envoyer un e-mail à [[email protected]](mailto:[email protected]) et faites-nous part de votre problème.\n+\n+Soyez sûrs d'avoir inclus le reçu que vous avez reçu durant le traitement (identifiant de transaction paypal, reçu Xsolla, etc) - cela nous aidera beaucoup à trouver ce qui est arrivé à votre paiement !\n+\n+### Qu'est-ce que le mode \"restricted\" (restreint), exactement ?\n+\n+**Une personne avec un compte restreint est temporairement empêché d'intéragir avec la communauté par n'importe quel moyen, ce qui inclut chatter, participer au multijoueur, et avoir ses scores sur les tableaux de classement.**\n+\n+Il peut continuer à définir des scores localement et en ligne (mais ses scores ne seront pas montrés jsuqu'à ce qu'il ne soit plus restreint) et jouer au jeu comme d'habitude, exception faite du mutlijoueur.\n+\n+Les restrictions sont relativement rares, et sont seulement appliquées quand nous pensons que les Règles de la Communauté ou nos Conditions d'Utilisation n'ont pas été respectées, ou qu'un compte a été remarqué pour ne pas agir normalement.\n+\n+Dans la plupart des cas, ce statut sera supprimé automatiquement après 24 heures. Si ce temps est passé et que vous êtes toujours restreint, vous pourrez interroger l'équipe du support à propos de votre statut via un e-mail à [[email protected]](mailto:[email protected]).\n+\n+Si vous êtes restreint, n'essayer surtout pas de faire un nouveau compte pour contourner votre statut, à la place essayez de vous arranger avec le support ! Faire plusieurs comptes pour éviter les restrictions poseront des problèmes à tout le monde - à nous, et à vous.\n+\n+### Le drapeau sur mon profil est le mauvais !\n+\n+**Nous pouvons le changer pour vous, mais seulement si vous vivez activement dans le pays vers lequel vous voulez changer votre assignation.**\n+\n+Nous déterminons votre pays depuis l'endroit où vous vous êtes enregistré pour la première fois.\n+\n+Si vous créez un compte durant vos vacances aux États-Unis, votre compte sera assigné aux États-Unis - vous apparaîtrez également dans le classement par pays des États-Unis.\n+\n+L'équipe du support peut changer le pays de votre compte sur requête, **mais seulement si vous vivez activement dans ce pays.**\n+\n+Pour confirmer cela, l'équipe vous demandera une preuve de votre résidence - cela peut être un passeport, votre permis de conduire, ou autres formes d'identification. Il doit y avoir sur l'image votre écran avec le client *osu!* d'ouvert et authentifié avec votre compte.\n+\n+Nous ne diffuserons jamais ces informations à d'autres personnes, et nous vous encourageons à supprimer toutes informations personnelles (cela ne nous empêchera pas de déterminer le pays pour lequel le document est destiné !) si vous souhaitez absolument conserver votre vie privée.\n+\n+### J'ai oublié mon nom d'utilisateur et mon mot de passe !\n+\n+**Veuillez utiliser [la page de récupération de mot de passe](https://osu.ppy.sh/p/forgot) pour réclamer votre compte automatiquement, ce qui part du principe que vous avez toujours accès à l'adresse e-mail avec laquelle vous vous êtes enregistré.**\n+\n+Si cela ne fonctionne pas pour vous (ou que vous n'avez pas accès à votre adresse e-mail d'enregistration), veuillez envoyer un e-mail à l'[équipe du support](mailto:[email protected]) avec autant d'informations que vous pensez utiles et qui nous aideraient à déterminer que vous êtes le propriétaire du compte.\n+\n+Les bonnes informations à inclure dans votre e-mail seraient:\n+\n+* L'adresse e-mail avec laquelle vous avez enregistré votre compte, ou n'importe quel e-mail associé à votre compte depuis le début\n+* N'importe quel reçu pour avoir acheté des tags osu!supporter ou d'autres objets du osu!store\n+* La dernière date à laquelle vous vous êtes connecté à votre compte normalement\n+* N'importe quelles informations vous identifiant et que vous pensez utiles (excluant des scores ou des replays, ça ne nous aiderait pas beaucoup !)\n+\n+### Mon compte a été banni/désactivé/restreint de manière permanente !\n+\n+**Les comptes sont généralement désactivés quand il est confirmé qu'ils ont le même propriétaire.**\n+\n+Si c'est votre cas, le compte qui a été banni n'est pas le premier que vous avez créé, vous pouvez donc vous connecter sans problèmes à votre premier compte. En général, les comptes désactivés ne sont pas réactivés dans la très grande majorité des cas.\n+\n+Si votre compte a été restreint, vous le saurez après une brève discussion avec l'équipe du support.\n+\n+Dans le cas où nous sommes absolument sûrs qu'un jeu irrégulier ou un méfait a pris place, nous vous demanderons d'attendre une période de **trois (3) mois** à partir de la date de votre dernière infraction avant de faire appel.\n+\n+### Mon compte a été volé !\n+\n+**Essayez d'utiliser la [page de récupération de mot de passe](https://osu.ppy.sh/p/forgot) pour voir si votre e-mail est toujours valide.**\n+\n+Si c'est le cas, vous pourrez réinitialiser votre mot de passe sans l'aide de l'équipe du support.\n+\n+Sinon, envoyez un ticket immédiatement à [[email protected]](mailto:[email protected]) avec autant d'informations nous permettant de vous identifier en tant que propriétaire du compte que possible.\n+\n+Nous envoyer l'e-mail depuis votre e-mail d'enregistration est un gros bonus ici, ainsi que toutes informations que vous pouvez nous fournir que seul le propriétaire du compte pourrait savoir.\n+\n+Veuillez ne pas inclure de replays ou de scores dans votre ticket - nous ne pouvons pas vérifier que vous êtes le propriétaire du compte avec ces informations.\n+\n+### Puis-je faire plus d'un compte ?\n+\n+**Malheureusement, non, vous ne pouvez pas.**\n+\n+Si tout le monde pouvait faire et jouer avec plusieurs comptes, les classements n'auraient aucune valeur !\n+\n+Les autres jeux rencontrent ce problème à cause de ce qui est communément connu sous le nom de \"smurfs\" - des comptes avec peu de temps de jeu qui font gonfler les classements et empêchent les autres utilisateurs de jouer de manière compétitive.\n+\n+Dans osu!, nous sommes vraiment contre les comptes multiples, et nous forçons la règle stricte d'un seul compte par utilisateur.\n+\n+Vous ne jouerez que sur le premier compte que vous avez enregistré, et c'est tout !\n+\n+### Est-il possible de redémarrer ou supprimer mes statistiques ?\n+\n+**Pas pour le moment.**\n+\n+Nous autorisons l'achat de 'score reset' depuis le osu!store pour les joueurs vraiment hardcore qui ne veulent que la perfection dans leurs statistiques, mais pour le moment, nous ne pouvons pas supprimer toutes les statistiques de votre compte pour vous.\n+\n+Ça ne veut pas dire que vous pouvez faire un nouveau compte pour en revenir au même ! Avoir plusieurs comptes est très mal vu dans notre communauté et nous désactiverons de tels comptes dès que nous serons au courant qu'ils existent.\n+\n+### Puis-je changer de nom d'utilisateur ?\n+\n+**Oui, absolument !**\n+\n+Les osu!supporters obtiennent **un** changement de nom gratuit la première fois qu'il achètent ou offrent un tag de supporter, il peut être réclamé dans le [osu!store](https://store.ppy.sh/store/product/32).\n+\n+À n'importe quel moment après l'achat, vous pouvez changer votre nom d'utilisateur vers tout ce que vous voulez. Cependant, le prix des changements augmente à chaque fois - le second coûtera 8$ USD, le troisième 16$ USD, et ainsi de suite. Nous avons pris cette mesure afin d'éviter que certains n'abusent de ce système pour changer de nom sans interruption.\n+\n+Si vous ne souhaitez changer que la casse ou corriger une faute de frappe, vous pouvez envoyer un e-mail à [[email protected]](mailto:[email protected]) pour demander un changement de nom gratuit pour corriger le problème. Nous ne vous ferons pas payer pour ces types de changements, mais vous **devez** faire ces requêtes par un e-mail au support.\n+\n+### Puis-je prendre le nom d'utilisateur de quelqu'un d'autre ?\n+\n+**Oui, mais sous certaines cisrconstances.**\n+\n+Si le joueur ne s'est pas connecté depuis au moins 6 mois et n'a pas de partie, son nom d'utilisateur peut être réclamé via la [page de changement de nom du osu!store](https://store.ppy.sh/store/product/32) pour les frais standards associés au changement de nom d'utilisateur.\n+\n+Pour chaque 500 parties pour tous les modes de jeu réunis, un an de plus (365 jours) sera ajouté au temps avant que le nom de ce joueur soit disponible. Cette précaution est prise afin d'éviter que des gens ne volent les nom d'utilisateurs de joueurs récemment inactifs.\n+\n+### Est-il possible de retrouver mon ancien nom d'utilisateur?\n+\n+**Oui, mais sous certaines conditions.**\n+\n+Nous ne faisons de retour de nom que pour le dernier nom d'utilisateur (celui montré en survolant leur nom dans leur profil). Les changements vers n'importe quel autre nom précédent doivent être [achetés dans la boutique](https://store.ppy.sh/store/product/32). Contactez simplement [email protected] et demandez à ce que votre changement de nom soit annulé.\n+\n+Nous ne permettons cela qu'une fois par comptes, choisissez donc bien votre moment !\n+\n+### Puis-je jouer sur un ordinateur sur lequel un autre utilisateur a déjà joué ?\n+\n+**Oui, absolument. Ceci inclut les ordinateurs partagés tels que les cybercafés et les PC bangs.**\n+\n+Tant que vous jouez sur votre compte, vous pouvez jouer à _osu!_ n'importe où.\n+\n+Si vous jouez depuis une place publique, gardez un œil sur la sécurité de votre compte. Les ordinateurs partagés sont souvent une proie de choix pour les logiciels malintentionnés.\n+\n+### Le site me dit que j'ai tenté de me connecter trop de fois !\n+\n+**C'est une mesure de protection temporaire après de mutiples tentatives ratées de connexion à votre compte. Essayez de vous connecter dans 10-20 minutes.**\n+\n+Si ça vous arrive, attendez simplement un moment et réessayez plus tard.\n+\n+Une poignée d'heures est requise au maximum afin de réinitialiser ce statut pour la plupart des gens avant qu'ils ne puissent se reconnecter.\n+\n+----------------------------------------------------------------------------\n+\n+## Client\n+\n+### osu! gèle quand je clique sur un lien ou une map en multijouer !\n+\n+**Assurez-vous qu'osu! ne tourne pas en mode compatibilité Windows, et qu'un navigateur internet par défaut est définit.**\n+\n+Ce problème est quelques fois causé par une intéraction avec le mode compatibilité, et peut aussi être causé par le jeu, ne trouvant pas le navigateur par défaut pour ouvrir la page vers laquelle mène le lien.\n+\n+#### Votre jeu tourne-t-il en mode compatibilité Windows ?\n+\n+Pour vérifier ou changer le fait que le jeu se trouve en mode compatibilité Windows, suivez les étapes qui suivent:\n+\n+1. Ouvrez le dossier où est installé osu! et trouvez le fichier `osu!.exe`.\n+2. Cliquez-droit sur `osu!.exe` et sélectionnez `Propriétés` dans le menu.\n+3. Sélectionnez l'onglet `Compatibilité`.\n+4. Cherchez la case à cocher `Exécuter ce programme en mode compatibilité` dans la section intitulée `Mode de compatibilité`.\n+5. Si la case est cochée, cliquez dessus pour désactiver cette fonctionnalité.\n+6. Si votre jeu est déjà ouvert, fermez-le et réouvrez-le.\n+\n+#### Avez-vous un navigateur par défaut ?\n+\n+**Dans la majorité des cas, les installaions Windows ont un navigateur par défaut.**\n+\n+Pour vérifier cela, suivez les étapes suivantes (pour Windows 8 et supérieur):\n+\n+1. Ouvrez le menu Démarrer.\n+2. Écrivez `défaut` dans la barre de recherche.\n+3. Si vous voyez `Programmes par défaut`, cliquez dessus. Si vous ne le voyez pas, étendez votre recherche en écrivant `Programmes par défaut`.\n+4. Descendez jusqu'à `Navigateur Web` et vérifiez qu'un navigateur est définit.\n+\n+### Je ne peut pas me connecter au jeu !\n+\n+**Assurez-vous qu'osu! a accès à Internet malgrès vos pare-feu ou antivirus que vous avez installé sur votre ordinateur.**\n+\n+Voilà quelques manières de permettre à une application d'accéder à Internet par divers pare-feu ou antivirus:\n+\n+#### Autoriser un programme dans le Pare-feu Windows\n+\n+**Sur la plupart des installations Windows, le Pare-feu Windows sera le pare-feu par défaut.**\n+\n+Pour s'assurer qu'osu! peut accéder à Internet, nous devrons le dire au Pare-feu Windows. Voilà comment vérifier et autoriser osu! dans la liste des programmes:\n+\n+1. Ouvrez le menu Démarrer.\n+2. Écrivez `autoriser une application` dans la barre de recherche.\n+3. Vous devriez voir `Autoriser une application via le pare-feu Windows`. Cliquez dessus.\n+4. Un panneau avec une grande liste d'application s'affichera, avec deux cases à cocher après elle. Cliquez sur n'importe quelle application, puis appuyez sur la touche `o`. La liste défilera jusqu'aux applications commençants par 'o'.\n+5. Recherchez `osu!` ou `osu!.exe`.\n+6. Si aucun de ces deux mots ne sont présents, cliquez sur `Autoriser une autre application` en bas du panneau et cherchez le dossier d'installation d'osu!, puis choisissez `osu!.exe`.\n+7. Assurez-vous que les cases `Privé` et `Public` sont cochées. Cliquez sur OK pour sauvegarder les paramètres et réessayez.\n+\n+#### Autoriser une application dans le Pare-feu AVG\n+\n+Veuillez consulter la [base de connaissances officielle d'AVG sur le sujet](https://support.avg.com/SupportArticleView?l=fr&urlName=Allow-application-in-AVG-Firewall) pour savoir comment s'y prendres.\n+\n+#### Autoriser un programme dans le Kaspersky Security Center\n+\n+Veuillez consulter l'[article d'aide officiel de Kaspersky](https://support.kaspersky.com/7834) pour ajouter une application dans la Trusted Zone.\n+\n+#### Autoriser un programme dans McAfee\n+\n+Veuillez consulter la [base de connaissances officielle de McAfee sur le sujet](https://service.mcafee.com/webcenter/portal/cp/home/articleview?articleId=TS100813).\n+\n+#### J'ai ajouté osu! dans mon pare-feu mais je ne peut toujours pas me connecter dans le jeu !\n+\n+**Nous aurons besoin d'informations supplémentaires pour vous aier à vous en sortir.**\n+\n+Si vous avez toujours des problèmes de connexion à nos serveurs, vous pouvez soumettre un ticket au support en envoyant un email à [[email protected]](mailto:[email protected]). Les informations suivantes nous aiderons à résoudre votre problème rapidement:\n+\n+* Le journal de sortie de la commande `tracert` pour les serveurs `cho.ppy.sh`, `osu.ppy.sh` and `m1.ppy.sh` (voir les instructions ci-dessous)\n+* Le fichier `network.log` du dossier `Logs` situé dans le dossier d'installation d'osu!\n+\n+##### Faire un suivi pour trouver les problèmes de connexion\n+\n+**Un suivi nous aidera à savoir si le problème vient de vous ou de nos serveurs.**\n+\n+Vous pouvez effectuer un suivi en ouvrant l'invite de commande et en exécutant la commande `tracert`.\n+\n+Pour ouvrir l'invite de commande, appuyez sur la touche `Windows` et `R` en même temps, puis écrivez `cmd`, ensuite cliquez sur `OK`. [Pour plus d'informations, voir la base de connaissance Windows.](https://support.microsoft.com/fr-fr/help/314868).\n+\n+Vous pouvez désormais écrire la commande dans la console. Par exemple, la commande `tracert cho.ppy.sh` tracera toutes les addresses visitées par votre connexion pour finir par se connecter au serveurs de jeu. Le suivi prends quelques temps à se faire, des fois plus d'une minute, tout cela dépend de votre connexion.\n+\n+Nous aurons besoin des résultats de cette commande pour les addresses suivantes: `cho.ppy.sh`, `osu.ppy,sh` et `m1.ppy.sh`.\n+\n+Pour copier les résultats de la commande, faites simplement un clic droit maintenu tout ou descendant jusqu'à la fin de la sortie, puis cliquez-droit pour copier instantanément le contenu de la sélection dans votre presse-papier.\n+\n+### Mon PC redémarre quand je joue à osu!\n+\n+**La plupart du temps, c'est dû à une surchauffe d'un des composants de votre ordinateur, généralement votre carte graphique ou votre processeur.**\n+\n+Pour savoir quel composant pose problème, nous recommandons d'utiliser un moniteur de température de GPU/CPU pour y garder un œil quand vous jouez à osu! Un bon programme, que nous vous conseillons, est [Speccy de Piriform](https://www.piriform.com/speccy).\n+\n+Si vous remarquez qu'un de vos composants dépasse les 90°C ou 194°F, votre ordinateur et très chaud et est très proche de la limite de température avant un arrêt forcé automatique.\n+\n+#### Comment éviter que mon PC surchauffe quand je joue à osu! ?\n+\n+**la manière la plus simple est de changer la limite d'images par seconde dans le jeu.**\n+\n+Pour voir quelle est la limite actuelle, suivez les étapes suivantes:\n+\n+1. Ouvrez *osu!*.\n+2. Ouvrez le menu `Options` ou faite la combinaison `Control` + `O` par défaut.\n+3. Écrivez `frame` pour ramener l'option de limite d'images par seconde.\n+\n+Si votre limite est à Illimité, vous devriez remarquer un changement en le changeant en une des autres options.\n+\n+Avec `VSync`, le jeu tournera au temps de rafraîchissement égal à celui de votre moniteur principal, alors que `120fps` et `240fps` feront tourner le jeu respectivement au double et au quadruple du taux de rafraîchissement moyen.\n+\n+Nous recommandons d'utiliser `VSync` si le problème vient de la température.\n+\n+Vous pourriez aussi être intéressé par des programmes permettant de modifier la vitesse de vos ventilateurs d'ordinateur.\n+\n+#### Mon ordinateur ne surchauffe pas et le jeu continue à faire redémarrer mon PC\n+\n+**La cause la plus commune de redémarrage forcé après la surchauffe est un problème de carte son, suivi par des périphériques défectueux connectés à votre ordinateur.**\n+\n+De vieux pilotes de carte son peuvent poser des problèmes avec osu!, mais ce n'est pas le cas pour la plupart des gens. Essayez de mettre à jour les pilotes de votre carte son et carte mère.\n+\n+Vous devriez aussi essayez de retirer certains des périphériques attachés via USB à votre ordinateur, surtout s'ils intéragissent avec le son de n'importe quelle manière. Les casques ou cartes son USB peuvent causer des problèmes si leur port ou eux mêmes sont défectueux.\n+\n+#### Ça continue d'arriver !\n+\n+Si tout ce que nous vous avons proposé précédemment ne vous a pas aidé, envoyez un ticket au support à [[email protected]](mailto:[email protected]) avec le plus d'informations que vous puissiez nous fournir - ce qui inclut les spécifications de votre ordinateur, le modèle ainsi que toutes informations que vous pensez utiles pour que nous puissions vous aider au mieux.\n+\n+### J'ai changé mes paramètres, et maintenant je ne peut plus démarrer osu! ou il gèle.\n+\n+**Réinitialiser les paramètres d'osu! corrigera ce problème la plupart du temps.**\n+\n+Suivez ces étapes pour réinitialiser les paramètres d'osu! :\n+\n+1. Maintenez `Shift` appuyé.\n+2. Double-cliquez sur l'icône d'osu!, tout en maintenant `Shift`.\n+3. Maintenez `Shift` jusqu'à ce que vous voyez le dialogue de configuration d'osu!.\n+4. Lorsque le dialogue `osu! configuration` s'ouvre, cliquez sur le bouton `reset settings`.\n+5. Si vous n'avez vraiment pas de chance, rouvrez le dialogue et cliquez sur `repair osu!`.\n+\n+\n+### Je ne peut maintenir que quelques touches à la fois quand je joue à osu!mania.\n+\n+**C'est dû à un problème venant du clavier nommé *ghosting*.**\n+\n+Le ghosting est un sujet un peu complexe, mais pour faire simple, c'est un problème qui vient de la façon dont votre clavier a été fait et qui vous empêche de faire certaines combinaisons de touches.\n+\n+Les nouveaux claviers permettent des combinaisons allant jusqu'à **6** touches, mais dans des combinaisons aléatoires.\n+\n+Vous pouvez tester les limites de votre clavier en utilisant l'[utilitaire Anti-Ghosting de Microsoft](http://www.microsoft.com/appliedsciences/content/projects/AntiGhostingExplained.aspx).\n+\n+Alors que les Critères de Classement pour osu!mania essaye d'éviter ces problèmes en n'autorisant pas les combinaisons dépassant 6 notes, vous pouvez rencontrer ce problème si votre clavier est ancien.\n+\n+la seule vraie solution est d'acheter un clavier qui supporte plusieurs touches à la fois. Vous seriez intéressé par une fonction nommée *n-key rollover* (ou *NKRO*). Les claviers NKRO n'ont pas de problèmes de ghosting pour la plus grande partie, mais sont généralement chers.\n+\n+### Mon curseur devient fou !\n+\n+**Très souvent, c'est à cause d'une trop grande sensibilité dans vos options.**\n+\n+Un exemple de ce phénomène est de grands sauts, paticulièrement avec une tablette.\n+\n+Changer la sensibilité en jeu à 1.0x (qui est la valeur par défaut) devrait régler le problème, mais peut ralentir votre curseur. Nous suggérons le *contournage du pilote du dispositif de pointage* dans les options du jeu et utiliser les pilote spour changer la sensibilité.\n+\n+Vous pouvez aussi ajuster le *DPI* de votre souris, si vous en utilisez une. Un haut DPI permet une meilleure précision de la position du curseur en jeu et peut réduire tout mouvement non voulu.\n+\n+Nous vous suggérons aussi de nettoyer vos périphériques. Un cheveu ou une poussière au niveau du détecteur de la souris peut vraiment faire d'étranges mouvements.\n+\n+#### Qu'est-ce que le contournage du pilote du dispositif de pointage, et comment l'activer ?\n+\n+**Le contournage du pilote du dispositif de pointage force le jeu à utiliser un moyen plus propre et direct d'accéder aux information de votre périphérique. Généralement utilisé pour augmenter la précision de votre périphérique.**\n+\n+Pour l'activer, suivez les étapes suivantes:\n+\n+1. Ouvrez *osu!*.\n+2. Entrez dans le menu `Options` ou appuyez sur `Control` + `O` par défaut.\n+3. Écrivez `raw` dans la recherche rapide pour vous retrouver tout de suite dans l'option.\n+4. Cliquez sur le bouton radio `Contourner le pilot du dispositif de pointage`.\n+\n+### Je joue sur tablette et mon curseur est trop lent !\n+\n+**Vous pouvez régler ce problème en définissant une plus petite zone sur votre appareil.**\n+\n+Sur la plupart des tablettes Wacom, cela peut être fait via l'onglet `Mapping` de l'application `Wacom Tablet Properties`. Un exemple peut être vu [ici](https://w.ppy.sh/d/dc/Tabarea.png).\n+\n+Vous devrez consulter le constructeur de votre tablette pour savoir comment le faire.\n+\n+Toutes les tablettes osu! supportent le contournage du pilote du dispositif de pointage par défaut, et leur sensibilité peut être plus facilement ajustée en utilisant cette option et le glissoire de la sensibilité.\n+\n+### L'écran de sélection des musiques continuer de bouger !\n+\n+**C'est généralement dû à un appareil connecté à votre ordinateur. essayez de débrancher toutes manettes et joysticks.**\n+\n+Les applications émulant ou changeant les affectations comme *Xpadder* ou *X-Mouse Button Control* peuvent aussi en être la cause. Essayez de les désactiver si vous les utilisez pour d'autres jeux.\n+\n+Le pad numérique peut aussi être fautif, puisqu'il peut être utilisé pour se déplacer dans la sélection des musiques. Appuyez sur la touche `NumLock` pour le désactiver et appuyez soit sur `9` soit sur `3` sur le pad numérique pour corriger cela.\n+\n+Vous devriez aussi vérifier qu'un bouton ne soit endommagé sur vos périphériques.\n+\n+### J'ai téléchargé un pack de beatmap mais osu! essaye toujours de \"réparer\" le fichier !\n+\n+**Vous devez extraire le packs dans votre dossier Songs.**\n+\n+La plupart des packs sont des `.rar`, ce qui signifie que c'est une archive compressée de fichiers de beatmaps. Vous devrez les extraire en utilisant le programme de votre choix (nous recommandons [7-Zip](http://www.7-zip.org/)) dans votre dossier Songs.\n+\n+Une fois que tous les fichiers `.osz` sont dans le dossier Songs, Appuyez sur `F5` dans l'écran de sélection des musiques, ce qui va rafraîchir le cache des beatmaps et charger les nouvelles beatmaps.\n+\n+### Mon jeu ne se met pas bien à jour !\n+\n+**C'est généralement un problème avec votre PC, et rarement causé par une mise à jour.**\n+\n+osu! se garde à jour tout seul, mais parfois ça peut mal se passer.\n+\n+Nous vous recommandons tout d'abord de redémarrer votre PC. Cela va corriger la plus grande partie des problèmes que vous êtes susceptibles de rencontrer.\n+\n+Assurez-vous que la chaîne de mise à jour est réglé sur Stable.\n+\n+Vous pouvez aussi forcer le jeu à se mettre à jour.\n+\n+#### Comment vérifier la chaîne de mise à jour ?\n+\n+**Ce peut être changé dans le menu Options du jeu.**\n+\n+1. Ouvrez *osu!*.\n+2. Entre dans le menu `Options` ou appuyez sur `Control` + `O` par défaut.\n+3. Écrivez `release` dans la recherche rapide.\n+4. Assurez-vous que le menu déroulant indique `Stable (Latest)` pour recevoir les dernières versions stables du jeu.\n+\n+#### Comment forcer le jeu à se mettre à jour ?\n+\n+**Vous pouvez forcer le jeu à se mettre à jour via le menu d'options.**\n+\n+1. Ouvrez *osu!*.\n+2. Entrez dans le menu `Options` ou appuyez sur `Control` + `O` par défaut.\n+3. Écrivez `update` dans la recherche rapide.\n+4. Cliquez sur le bouton `Lancer le logiciel de mise à jour`.\n+\n+Vous pouvez forcer le jeu à se mettre à jour en créant un fichier nommé `help.txt` dans le dossier d'osu!. Ce fichier n'a pas besoin de contenir quelque chose - il a juste besoin d'exister, et le jeu se forcera à se mettre à jour.\n+\n+### J'ai une erreur à propos des \"polices\" quand j'ouvre le jeu !\n+\n+**Vous avez supprimé ou perdu d'importantes polices d'écritures système fournies avec l'installation Windows. Ce n'est probablement pas le seul problème que vous devriez recontrer !**\n+\n+Si vous avez cette erreur en ouvrant *osu!* ou son logiciel de mise à jour, cela signifie que vous avez supprimé ou perdu d'importantes polices d'écriture système fournies avec Windows. Ces polices sont utilisées par Windows, vous devriez donc aussi rencontrer des problèmes comme de mauvaises polices, des textes manquants, et autres crashs d'applications dans votre système.\n+\n+Voici une collection de polices communément utilisées dans différentes versions de Windows:\n+\n+- [Microsoft core web fonts](http://web.nickshanks.com/fonts/microsoft-core-web-fonts) (spécialement Arial, Times New Roman, Trebuchet MS, et Verdana)\n+- [Tahoma](http://www.boldfonts.com/fonts/Tahoma/)\n+- [Windows Live Essentials](http://explore.live.com/windows-live-essentials?os=other) (Segoe UI)\n+- [Powerpoint 2007 Viewer](http://www.microsoft.com/downloads/en/details.aspx?FamilyID=048dc840-14e1-467d-8dca-19d2a8fd7485&displaylang=en&pf=true) (Cleartype family--Calibri, Consolas, Corbel, ... Rien dans osu! ou votre système ne dépend d'elles, mais ces polices sont superbes ! téléchargez-les maintenant gogo !)\n+- [Microsoft JhengHei](http://www.microsoft.com/download/en/details.aspx?DisplayLang=en&id=12072) (微軟正黑體) (Police du Chinois Traditionnel UI)\n+\n+Voir [ce sujet](http://answers.microsoft.com/en-us/windows/forum/windows_vista-windows_programs/font-tahoma-does-not-support-style-regular/80ad7a97-230f-41d4-9101-107a0bfa986a) dans Microsoft Answers pour plus d'informations, et d'autres options pour les retrouver.\n+\n+### Je suis devenu supporter mais mon nom n'est pas jaune dans le chat !\n+\n+**Vous apparaîtrez toujours blanc pour vous-même. Les autres vous verront dans un glorieux jaune !**\n+\n+Cela aide à s'identifier et à séparer ses messages des autres. Il n'y a pas d'option pour désactiver ce comportement pour l'instant.\n+\n+### Certaines beatmaps manquent !\n+\n+**Soyez sûrs de ne pas rechercher de beatmaps avec certains critères (comme les nombre d'étoiles, l'approach rate, et ainsi de suite).**\n+\n+Si vous venez de télécharger une map, vous devriez essayer de rafraîchir votre liste en appuyant sur `F5` dans l'écran de sélection des musiques.\n+\n+### J'ai reçu des erreurs de serveur en essayant de jouer en ligne !\n+\n+**Cela peut arriver si vous utilisez une connexion internet partagée, un proxy, ou un VPN.**\n+\n+Essayez un autre proxy ou VPN - s'ils ratent tous, envoyez un ticket au support via un email à [[email protected]](mailto:[email protected]).\n+\n+Si vous n'en utilisez pas, vous devriez envoyer un ticket au support, puisqu'il semble que votre connextion a été blacklistée par erreur.\n+\n+Tor ou tout ce qui y est lié ne permet pas de se connecter à nos serveurs pour la plupart. Afin d'empêcher un mauvais usage de ces outils.\n+\n+----------------------------------------------------------------------------\n+\n+## Site Web\n+\n+### Je n'ai pas reçu de réponse à mon ticket au support depuis 2 semaines !\n+\n+**Pour la plupart du temps, c'est dû à un grand nombre de tickets venant dans notre sytème à la fois.**\n+\n+Vous pouvez toujours envoyer un seule réponse à votre ticket ouvert pour demander l'état de votre cas, mais ne le faites pas plus d'une ou deux fois par semaines.\n+\n+Dans de rares circonstances, les tickets envoyés par des joueurs incriminés peuvent être volontairement ignorés, cependant l'équipe vous dira **toujours** quand elle ne répondra plus à vos tickets. Si vous n'avez pas été notifié de cela, vous ne devrez pas vous en faire !\n+\n+### Ma page utilisateur a été bloquée et je ne peux plus l'éditer !\n+\n+**Cela arrivera si votre page a eu du contenu inapproprié, comme définit dans nos [règles de la communité](/wiki/Rules).**\n+\n+Dans de tels cas, vous pouvez ouvrir un ticket à l'équipe de support en envoyant un email à [[email protected]](mailto:[email protected]) et discuter de votre situation ave eux.\n+\n+La plupart du temps, vous serez réautorisé à éditer votre page, mais les utilisateurs abusant de cette autorisation peuvent se voir bloqué à tout jamais, soyez prudent !\n+\n+Si à n'importe quel moment vous avez un doute sur un contenu, vous pouvez envoyer un message à l'[Équipe Globale de Modération](/wiki/People/Global_Moderation_Team) avec ce que vous pensiez y mettre et ils vous feront savoir si c'est correct.\n+\n+\n+### Puis-je totalement bloquer quelqu'un?\n+\n+**Oui, absolument.**\n+\n+Dans le cas où un autre utilisateur vous harcèle via messages privés, forums ou via le jeu lui-même, il y a quelques étapes à suivre vous permettant de filtrer ses messages.\n+\n+#### Empêcher un utilisateur de vous contacter en jeu\n+\n+**Pour empêcher un utilisateur de vous contacter en jeu, ajoutez-le simplement à la liste d'utilisateurs ignorés.**\n+\n+1. Cliquez sur le bouton d'options en jeu\n+2. Écrivez 'ignore' pour rechercher l'option dans la section \"Chat Ignore List\".\n+3. Ajoutez l'utilisateur souhaité dans la liste, chacun séparé par un espace, et remplacez chaque espace edans son nom par un underscore (Un utilisateur nommé _The Gatekeeper_ devient _The\\_Gatekeeper_ par example).\n+4. C'est bon ! \n+\n+Vous ne recevrez ni messages publiques, ni messages privés venant des utilisateurs de cette liste.\n+\n+#### Bloquer tous les utilisateurs qui ne sont pas en amis\n+\n+Si vous voulez empêcher tous ceux qui ne sont pas vos amis de vous envoyer des messages privés, suivez les étapes suivantes. **Sachez que les modérateurs ne sont pas affectés pas cette fonctionnalité et pourront toujours vous envoyer des messages privés. Si un modérateur vous dérange beaucoup, vous devriez contacter l'[équipe du support](mailto:[email protected]).**\n+\n+1. Cliquez sur le bouton `Options` en jeu ou appuyez sur `Control` + O sur votre clavier\n+2. Écrivez \"block\" pour trouver l'option dans la section \"Chat\".\n+3. Activer l'option en cliquant dessus.\n+4. C'est bon ! Les utilisateurs qui ne sont pas dans votre liste d'amis (/addfriend \"utilisateur\") ne peuvent plus vous contacter.\n+\n+#### Bloquer les posts de forum d'un utilisateur\n+\n+**Pour cacher la plupart des posts de forum d'un utilisateur, ajoutez-le à votre liste d'ennemis via le UCP.**\n+\n+1. Dirigez-vous vers la [liste de vos ennemis dans l'UCP](https://osu.ppy.sh/forum/ucp.php?i=zebra&mode=foes) et ajoutez simplement leur nom d'utilisateur à cette liste.\n+2. Cliquez sur Submit.\n+3. C'est fait ! La plupart des posts de forum de cet utilisateur ne seront plus visibles pour vous - comme s'ils n'ont jamais existé. Notez que les posts citant ses posts seront toujours visibles.\n+\n+#### Empêcher les messages privés du forum de vous atteindre\n+\n+**Pour supprimer tous les messages privés du forum avant qu'ils n'arrivent, faites une [règle de filtrage automatique dans les paramètres d'UCP](https://osu.ppy.sh/forum/ucp.php?i=pm&mode=options).**\n+\n+1. Dirigez-vous vers la section de filtrage des PM dans l'[UCP](https://osu.ppy.sh/forum/ucp.php?i=pm&mode=options).\n+2. Au tout début de la page, cherchez la colonne intitulée `Add new Rule`.\n+3. Cliquez sur la première boîte déroulante (la valeur par défaut est Subject) et changez-la en `Sender`, puis cliquez sur Next.\n+4. Cliquez sur la première boîte déroulante et changez la valeur de \"is like\" à \"is\" (troisième option dans la liste), puis cliquez sur Next.\n+5. Entrez le nom de l'utilisateur que vous souhaitez bloquer dans la boîte de texte qui ets apparue, puis cliquez sur Next.\n+6. Cliquez sur la première boîte déroulante et changez sa valeur sur \"Delete message\", puis cliquez sur \"Add Rule\".\n+7. C'est bon ! Toutes tentatives de l'utilsateur de vous contacter via les messages privés du forum seront automatiquement supprimés sans vous avertir.\n+\n+#### Que faire si j'ai toujours des problèmes avec un utilisateur que j'ai bloqué ?\n+\n+**N'ayez crainte, notre équipe de modération vous aidera.**\n+\n+Si un utilisateur vous harcèle toujours, ou utilise ses amis ou quelqu'un d'autre pour contourner ces blocages, veuillez nous contacter via email à [[email protected]](mailto:[email protected]).\n+\n+N'oubliez pas d'inclure des logs ou autres preuves dans l'email, et notre équipe du support se penchera sur votre cas et vous aidera.\n+\n+### Qu'est-ce que sont ces \"user pages\" que je peux voir sur le profil des autres joueurs ?\n+\n+**Les user pages sont des éléments spéciaux auquels tous les joueurs avec le [supporter tag](https://osu.ppy.sh/home/support) ont accès. Ils peuvent contenir ce que vous voulez - des images de vos succès, vos beatmaps, basiquement tout !**\n+\n+Les joueurs avec un [supporter tag](https://osu.ppy.sh/home/support) ont le privilège d'éditer leur propre page. Les user pages peuvent contenir ce que vous souhaitez - tant que le contenu suit les [règles de communauté](/wiki/Rules)!\n+\n+Si votre [supporter tag](https://osu.ppy.sh/home/support) arrive en fin de vie, votre user page **restera visible** et vous serez toujours capable d'éditer son contenu.\n+\n+### Ai-je besoin d'une adresse email pour m'enregistrer ?\n+\n+**Non, vous n'en avez pas besoin. Nous vous authentifions via le jeu, un email n'est donc pas nécessaire pour s'enregistrer.**\n+\n+Si vous avez des problèmes pour vous connecter en jeu, veuillez vérifier votre pare-feu et votre antivirus pour vous assurer qu'osu! n'est pas bloqué.\n+\n+Bien qu'un email n'est pas requis, nous vous recommandons d'en associer un à votre compte, puisque di vous perdez votre mot de passe ou ne pouvez pas accéder à votre compte, votre email est notre premier point de contact avec vous.\n+\n+### Pourquoi je ne peux pas rechercher de beatmaps d'un artiste dont le nom est composé de moins de 3 caractères ?\n+\n+**Notre moteur de recherche ne peut pas gérer ces cas dû à des limitations techniques, mais vous pouvez toujours utiliser la barre Google Custom Search en haut de la plus grande partie des pages du site.**\n+\n+Entrez simplement le nom de l'artiste que vous souhaitez et Google fera le reste.\n+\n+### Pourquoi les statistiques sur ma page de profil sont mauvaises ?\n+\n+**Vous regardez probablement le mauvais mode de jeu ! Le site montre par défaut les scores pour le dernier mode de jeu auquel vous avez joué.**\n+\n+Si vous avez été inactif pour une longue période de temps et que vos statistiques sont mauvaises, jouez quelques maps pour les actualiser. Les utilisateurs inactifs peuvent voir leur scores cachés pour garder les classements propres.\n+\n+----------------------------------------------------------------------------\n+\n+## Gameplay\n+\n+### Mon compteur de combo, mon score ou ma précision ne s'affiche pas !\n+\n+**Appuyer sur `Shift` + `Tab` par défaut va montrer ou cacher l'interface de jeu et vous permettra de revoir ces éléments.**\n+\n+Si vous avez changé la configuration des touches pour montrer ou cacher le scoreboard, ça ne fonctionnera pas. Vous pouvez vérifier quelles touches sont définies dans `Options` -> `Configurer les touches` -> `In-Game` -> `Toggle Scoreboard`.\n+\n+### Mes scores locaux ne sont pas là !\n+\n+Il y a quelques raisons pour que cela arrive. Lisez la suite !\n+\n+#### Avez-vous récemment réinstallé le jeu ?\n+\n+**Réinstaller le jeu va automatiquement supprimer tous vos scores locaux.**\n+\n+Ils sont malheureusement partis, pour toujours.\n+\n+Les scores que vous avez soumis en ligne seront toujours là cependant - il suffit de retélécharger n'importe quelle musique que vous avez déjà joué et votre score réapparaîtra.\n+\n+Astuce utile - si vous êtes un osu!supporter, vous pouvez utiliser le filtre `Ranked (Played)` dans le panneau osu!direct en jeu ou via la [liste de beatmaps du site](https://osu.ppy.sh/p/beatmaplist?m=-1&r=7&g=0&la=0&ra=) pour trouver toutes les maps pour lesquelles vous avez un score.\n+\n+#### Avez-vous sélectionné le bon mode de jeu ?\n+\n+**Jouer avec un autre mode de jeu (osu!taiko, osu!catch ou osu!mania) cachera tous les scores en jeu pour ne montrer que ceux du mode de jeu sélectionné.**\n+\n+C'est souvent en jouant sur des maps d'un autre mod de jeu, ce qui dit automatiquement à la sélection des musiques d'afficher les scores associé au mode actuel jusqu'à ce qu'il change. \n+\n+Vous pouvez changer de mode de jeu en utilisant le bouton `Mode` en bas à gauche de l'écran de sélection des musiques, puis en choisissant le mode que vous souhaitez.\n+\n+#### Jouez-vous hors-ligne ?\n+\n+**Malheureusement, les scores faits hors-ligne ne peuvent pas être ajoutés au classement en ligne.**\n+\n+Si vous jouez en ligne et que vous souffrez de déconnexions brèves pour n'importe quelle raison, le jeu essayera automatiquement d'envoyer les scores tant que le client est ouvert.\n+\n+#### Avez-vous récemment téléchargé beaucoup de beatmaps ? (comme un beatmap pack)\n+\n+**Les scores peuvent mettre du temps à être téléchargé si vous chargez beaucoup de beatmaps d'un coup.**\n+\n+Jouer ou faites autre chose permet au jeu de se rattraper.\n+\n+### Quel est ce trait blanc ressemblant à de la fumée derrière mon curseur ?\n+\n+**C'est une fonctionnalité spéciale appelée _smoke_, elle peut être utilisée pour dessiner sur votre aire de jeu pour le fun. Tous les spectateurs peuvent voir ce que vous dessinez.**\n+\n+La touche par défaut pour cette fonctionnalité est `C`, et ça fonctionnera tant que vous tenez la touche enfoncé. Vous pouvez la changer dès que vous voulez dans la section `osu! Standard Mode` dans le dialogue d'option `Changer les touches`.\n+\n+### Comment sauvegarder le replay du score que je viens de faire ?\n+\n+**Entrez dans l'écran du score souhaité en cliquant dessus, et appuyez sur le touche `F2`.**\n+\n+Ça sauvegardera votre brillant score dans un fichier `.osr` dans le dossier /Replays/ du dossier d'installation d'osu!\n+\n+*osu!* sauvegarde aussi automatiquement tous les replays après que vous complétez une musique se situant sous le dossier `/Data/r/`, lui aussi dans le dossier d'installation d'osu!.\n+\n+Sachez que si aucun replay n'a été sauvegardé pour le score, vous ne serez pas capables d'en avoir un.\n+\n+### osu! me dit que mon client est trop ancien !\n+\n+**C'est l'heure de la mise à jour ! Les très vieilles versions du jeu ne sont pas autorisées à soumettre de nouveaux scores, vous devez donc forcer la mise à jour en allant dans `Options` -> `General` -> `Lancer le logiciel de mise à jour`.**\n+\n+Si ça ne fonctionne pas, vous pouvez fermer osu! et redémarrer osu.exe tout en tenant la touche `Shift`. Cela va vous offrire quelques options de mise à jour et de réparation, une de celles-là vous permet de mettre à jour votre jeu.\n+\n+### Mes scores ne se soumettent pas !\n+\n+Oops ! Il peut y avoir plusieurs raisons pour que cela arrive:\n+\n+#### Êtes vous connecté à Internet en jouant ?\n+\n+**Si vous ne pouvez pas accéder à Internet après avoir fait un score, il peut ne pas être soumis.**\n+\n+Ce peut être frustrant si jouez avec un mauvaise connexion, mais le jeu essayera de soumettre votre score tant que le jeu reste ouvert.\n+\n+#### osu! est-il autorisé dans votre pare-feu et/ou antivirus ?\n+\n+**Quelques pare-feu et antivirus peuvent empêcher osu! d'accéder à Internet, ce qui empêche le jeu d'envoyer les scores.**\n+\n+Vérifiez ces programmes pour vous assurer qu'`osu!.exe` dans le dossier d'installation du jeu est autorisé à accéder à Internet.\n+\n+#### Est-ce que beaucoup de programmes tournent en fond ?\n+\n+**Certains d'entre eux peuvent bloquer l'envoi des scores.**\n+\n+Essayez de fermer tous les autres programmes avant de jouer à osu! si vous rencontrez des problèmes pour soumettre vos scores et que vous n'avez aucun problème de connexion.\n+\n+#### Est-ce que le serveurs de scores sont disponibles ?\n+\n+**La réponse est très souvent oui, mais vérifiez [stat.ppy.sh](https://stat.ppy.sh) ou le [twitter @osustatus](https://twitter.com/osustatus) pour vous assurer que tout tourne parfaitement de notre côté.**\n+\n+Si les serveurs sont hors-ligne, ne fermez pas _osu!_ jusqu'à ce que nous corrigions les problèmes et que les serveurs ne reviennent, et le jeu tentera de soumettre les score jusqu'à une heure après avoir été faits avant d'abandonner.\n+\n+#### Pouvez-vous poster un score que j'ai fait pour moi ?\n+\n+**Malheureusement, nous ne postons pas de score sur requête.**\n+\n+Si vous n'avez pas pu poster un score à cause de raisons techniques ou autre, la seule chose que vous pouvez faire est espérer le refaire. Désolé !\n+\n+### Les notes semblent être désynchronisées avec la musique !\n+\n+**Ce peut être dû à un logiciel de traitement de son, comme _Razer Surround Audio_. Ce peut être aussi dû à votre `Décalage Audio` mal configuré.**\n+\n+Fermez tous les logiciels qui peuvent altérer ou influencer le son provenant de votre ordinateur. Si ça n'aide pas, vous pouvez essayer d'ajuster votre `Décalage Audio`.\n+\n+Chaque configuration matérielle a un `Décalage Audio` qui détermine si vous entendez l'audio du jeu un peu avant ou un peu après.\n+\n+Les valeurs par défaut fonctionnent pour la plupart des gens, mais si ce n'est pas votre cas, vous pouvez le changer en suivant les étapes suivantes:\n+\n+- Allez dans le menu `Options`, et trouvez le glissoire `Décalage Audio` sous l'en-tête `Décalage Audio`. La valeur par défaut est 0, et vous devriez la changer si besoin.\n+- Si la valeur par défaut (0) ne vous convient pas, essayez le bouton `Démarrer l'assistant` pour en définir une nouvelle.\n+- Si ça ne vous convient toujours pas, vous devriez mettre à jour vos pilotes audio.\n+\n+### J'ai des pics de lag en jouant !\n+\n+**Il y a beaucoup de raisons pour lesquelles il peut y avoir des problèmes de performance, des programmes sur votre ordinateur, aux pilotes non mis à jour, ou simplement de trop hauts paramètres.**\n+\n+#### Y a-t-il beaucoup de programmes ouverts avec osu!?\n+\n+**Certaines tâches de fond se battent avec osu! pour avoir des ressources, ce qui rend le jeu très déplaisant à jouer.**\n+\n+Fermez les programmes dont vous n'avez pas besoin pour jouer à osu!.\n+\n+#### Votre ordinateur est-il sécurisé ?\n+\n+**Les virus, spyware, malware ou autres programmes non-voulus peuvent causer des problèmes de performance même pour de très bon ordinateurs.**\n+\n+Gardez votre ordinateur propre et protégé et vous devriez apercevoir des améliorations.\n+\n+#### Quel âge à vote ordinateur ?\n+\n+**De très vieux ordinateurs, même ceux utilisant des chipsets graphiques Intel intégrés peuvent ne pas être assez puissants pour gérer osu!, même avec les plus bas réglages.**\n+\n+Le seul moyen de régler ce problème est d'acheter un nouvel ordinateur !\n+\n+#### Est-ce que vos pilotes sont à jour ? \n+\n+**D'anciens pilots peuvent aussi causer des problèmes. Assurez-vous de garder à jour vos pilotes.**\n+\n+Les pilotes de carte graphique sont très importants pour osu!, tout comme les pilotes de carte son.\n+\n+#### Utilisez-vous un hub USB pour connecter un grand nombre d'appareils USB à votre ordinateur avec un seul cable USB ?\n+\n+**Connecter trop d'appareils sur un seul port via un splitter peut causer de la latence difficile à détecter mais qui peut vraiment vous empêcher de jouer proprement.**\n+\n+La solution est simple: débrancher votre hub USB. Si la latence disparaît, vous savez d'où ça vient !\n+\n+#### Est-ce qu'osu! tourne en mode fenêtré ou sans bordures ?\n+\n+**Ces deux modes introduisent un délai _considérable_. Les plein écran est optimal pour la meilleure expérience de jeu.**\n+\n+#### Est-ce que votre jeu gèle ou quelque chose dans le genre?\n+\n+**Quelques fois, une tâche de fond ou une application sur votre ordinateur peut envoyer de grandes requêtes demandant beaucoup de ressources d'un coup, ce qui fera agoniser votre machine.**\n+\n+C'est généralement réglé en fermant tout ce qui n'est pas essentiel à osu!. Les logiciels de torrent sont des gouffres à ressources, spécialement s'ils partagent le même espace disque que celui sur lequel osu! est installé.\n+\n+#### Le jeu a-t-il été récemment mis à jour ?\n+\n+**Il arrive qu'après une mise à jour, le jeu ait du mal sans raison.**\n+\n+Si vous avez beaucoup de beatmaps, attendez au moins 10-15 minutes avant de blâmer la mise à jour. Le jeu peut recalculer toutes les difficultés de chaque beatmapset.\n+\n+Si le problème ne se corrige pas tout seul, un redémarrage ne serait pas de trop.\n+\n+### Mon jeu ne semble pas stable, comme les graphiques qui semblent déchirés !\n+\n+**C'est dû à un effet nommé [screen tearing](https://en.wikipedia.org/wiki/Screen_tearing), ce peut être corrigé en définissant l'option `Images par secondes` sur `VSync`.**\n+\n+Ne vous inquiétez pas, ça ne fait rien de mal (même si c'est pas beau !). Ça arrive quand le taux de rafraîchissement du jeu n'est pas synchronisé avec celui de votre moniteur. \n+\n+Vous pouvez aussi jouer en mode fenêtré ou sans bordure, ce qui utilisera le VSync de votre système d'exploitation.\n+ \n+Activer le VSync ou jouer en mode fenêtré ou sans bordure introduira une _légère_ latence, malheureusement. Pour la plupart des gens, cela ne causera pas de gros problèmes.\n+\n+Les cartes graphiques NVidia récentes ont une option globale dans le Panneau de Contrôle NVidia pour définir le taux de refraîchissement global, vous pouvez le mettre sur 'Fast', ce qui corrigera aussi ce problème.\n+\n+----------------------------------------------------------------------------\n+\n+## Installation et Enregistration\n+\n+### Comment télécharger osu!?\n+\n+**Cliquez simplement sur le bouton **`Download`** dans la barre en haut de la page du [site officiel d'osu!](https://osu.ppy.sh/).**\n+\n+Autrement, [cliquez ici](https://osu.ppy.sh/p/download) pour un lien direct vers la page de téléchargements.\n+\n+### Où m'enregistrer sur osu!?\n+\n+**Cliquez simplement sur **`I'm new!`** situé en haut à droite de n'importe quelle page du site d'osu!, ou visitez la page directement via [ce lien](https://osu.ppy.sh/p/register).**\n+\n+Nous ne demmandons pas d'email pour enregistrer un compte osu!, mais nous suggérons grandement d'en associer un à votre compte pour le protéger de la purge journalière et pour le sécuriser le plus possible.\n+\n+Si vous créez votre compte et que vous ne vous authentifiez pas en jeu une fois, le compte sera supprimé de notre base de données d'ici un jour.\n+\n+Authentifiez-vous dès que vous l'avez créé !\n+\n+### L'installateur du jeu lance une erreur et ne fonctionne pas quand je l'utilise !\n+\n+**Si l'installateur lance des erreurs lorsque vous installez osu!, vous pouvez essayer de:**\n+\n+- nettoyer votre PC - Lancez un scan antivirus, nettoyez le registre. Un bon programme pour ce type de nettoyage est CCleaner. Nettoyez à la fois les fichiers et votre registre. L'installateur peut ne pas réussir s'il y a des entrées d'une copie précédente d'osu! encore présente sur votre ordinateur.\n+- réinstaller le Framework .NET 3.5. [Vous pouvez le trouver ici](https://web.archive.org/web/20160317051200/http://www.microsoft.com/en-au/download/details.aspx?id=21).\n+\n+### J'ai la version 64-bit de Windows et je ne peux pas installer osu! correctement !\n+\n+**Essayez d'installer la version 64-bit du Framework .NET de Microsoft.**\n+\n+Ça pourrait venir de l'installateur d'osu!, mais dans certains cas ça ne pourrait pas, [téléchargez le ici](http://download.microsoft.com/download/2/0/e/20e90413-712f-438c-988e-fdaa79a8ac3d/dotnetfx35.exe).\n+\n+----------------------------------------------------------------------------\n+\n+## Beatmapping et Éditeur\n+\n+### Comment mettre en ligne/mettre à jour ma map ?\n+\n+**Vous pouvez faire ça via l'éditeur en jeu.**\n+\n+Pour mettre en ligne votre beatmap, allez dans l'éditeur et allez dans `File` > `Upload Beatmap`.\n+\n+Ça rendra votre beatmap disponible aux autres sur le site et créera un sujet dédié sur le forum. Pour mettre à jour votre beatmap, c'est la même chose.\n+\n+Chaque utilisateur a une nombre limité de beatmaps qu'il peut mettre en ligne simultanément. Laisser une map inactive pendant un mois (en ne la mettant pas à jour ou en ne postant pas sur son sujet) l'enverra au Cimetière des Beatmaps. Pour mettre à jour une beatmaps au cimetière, vous devrez d'abord la ressusciter.\n+\n+#### L'éditeur me dit que la beatmap que j'essaye de soumettre n'est pas la mienne !\n+\n+**Ça peut arriver si le créateur de la beatmap n'est pas proprement défini dans les fichiers de la beatmap.**\n+\n+Dans l'éditeur, cliquez sur `File` dans le menu, puis `Open .osu file in Notepad`. Cochez la ligne `Creator:` et assurez-vous que votre nom exact est marqué dessus, casse comprise. \n+\n+Si ce n'est pas le cas, changez le manuellement pour chaque difficulté de votre set, rechargez la map, et vous pouvez enfin la soumettre.\n+\n+### Je suis un osu!supporter, mais je n'ai pas 10 slots en attente !\n+\n+**Le nombre de slots disponibles dépend du nombre de maps classées que vous avez.**\n+\n+Par défaut, chaque utilisateur a 2 slots en attente. Un slot est ajouté pour chaque map classée que le joueur possède, jusqu'à 8 slots. Être un supporter vous permet d'avoir 2 slots en plus, de 4 (sans maps classées) jusqu'à un total de 10.\n+\n+### Comment puis-je supprimer ma map ?\n+\n+**L'équipe ne répond pas aux requêtes de suppression de beatmaps.**\n+\n+Vous pouvez la supprimer vous-même en attendant qu'elle se retrouve dans le Cimetière, ce qui se fera après un mois sans mises à jour.\n+\n+Une fois dans le Cimetière, vous pouvez la supprimer vous-même en cliquant sur le bouton `Delete` qui apparaît à côté du lien de la beatmap.\n+\n+----------------------------------------------------------------------------\n+\n+## osu!store et marchandises\n+\n+### Comment configurer le osu!keyboard ?\n+\n+**Vous pouvez le faire via le programme de configuration du osu!keyboard, disponible à [ce lien](http://puu.sh/l6urN/4b6bc800f2.zip).**\n+\n+Simplement l'extraire quelque part sur votre ordinateur suffit, et lancez l'exécutable !\n+\n+La suite est simple à deviner.\n+\n+Si vous avez des problèmes, vous pouvez envoyer un ticket à [[email protected]](mailto:[email protected]) en détaillant votre problème.\n+\n+### Les LEDs de mon osu! nono keyboard ne fonctionnent pas !\n+\n+**Il peut y avoir plusieurs causes - de la corrosion entre les LEDs et le mainboard, ou pour d'anciens modèes, des LEDs défectueuses.**\n+\n+Pour déterminer si les LEDs de votre votre osu! nono keyboard sont défectueuses, suivez les étapes suivantes:\n+\n+#### Mes LEDs sont-elles défectueuses ?\n+\n+**Pour le savoir, suivez les étapes suivantes:**\n+\n+1. Identifiez quelle LED ne fonctionne pas comme elle le devrait.\n+2. Retirez doucement les LEDs en-dessous de la touche avec une paire de pinces ou par un autre moyen, en vous souvenant de quelle LED va à quel slot.\n+3. Échangez les LEDs et faites les retourner dans leur emplacement. Par exemple, placez la LED de la touche de gauche à la touche de droite, et ainsi de suite.\n+\n+Si une LED qui fonctionnait d'un côté fonctionne de l'autre côté, alors la LED **n'est pas défectueuse** et devrait fonctionner correctement.\n+\n+Si une LED ne fonctionne ni d'un côté, ni de l'autre, **elle est prbablement défecteuse.** Nous pouvons vous fournir des LEDs de remplacement pour réparation, gratuitement. Envoyez-nous un email à [[email protected]](mailto:[email protected]).\n+\n+Si une LED qui fonctionnait d'un côté de fonctionne pas de l'autre, **cela peut bien être le mainboard de votre clavier qui est fautif**. Faites-le nous savoir en envoyant un email à [[email protected]](mailto:[email protected]) et nous feront de notre mieux pour trouver un remplacement.\n+\n+Si vos deux LEDs ne fonctionnent pas, elles peuvent petre toutes les deux défectueuses, ou même votre mainboard peut l'être. Vérifier s'il n'y a pas de corrosion avant de nous contacter.\n+\n+#### Comment savoir s'il y a de la corrosion sur mes LEDs ?\n+\n+**Enrober la base des connecteurs de la LED avec un petit carré de papier d'aluminium retirera la plupart des résidus causés par la corrosion.**\n+\n+Les résidus de corrosion sont de couleur gris noirci, ou ont des teintes de métal étranges.\n+\n+Supprimer ces résidus peut faire fonctionner à nouveau votre LED. Si c'est le cas, vous saurez corriger ça la prochaine fois !\n+\n+### Ma osu!tablet a cessé de fonctionner ou ne fonctionne pas du tout!\n+\n+**Ce peut être compliqué de savoir pourquoi puisque la osu!tablet est un ensemble de deux éléments (la tablette et le stylet).**\n+\n+En sachant cela osu!tablet, il peut être difficile de dire d'où vient le problème. \n+\n+Pour le savoir, suivez les étapes suivantes:\n+\n+#### Vérifier les problèmes avec votre tablette\n+\n+**Suivez les étapes suivantes pour savoir si votre tablette fonctionne normalement:**\n+\n+1. Retirez avec précaution la tablette de votre système, et débranchez le cable.\n+2. Rebranchez doucement le cable dans le slot USB de votre système.\n+3. Si la tablette fonctionne, le slot lumineux sur votre tablette devrait faire des flashs verts puis s'éteindre. C'est ce qui devrait se passer.\n+\n+Si la lumière de la tablette ne fait pas de flashs, essayez d'utiliser un autre cable USB - celui fournit avec la tablette peut être usé par le transport ou par un usage intensif. \n+\n+Si le problème persiste et que votre produit est assez récent (environ un mois), veuillez envoyer un email à [[email protected]](mailto:[email protected]) pour de l'assistance.\n+\n+Nous pouvons essayer de vous aider à résoudre votre problème avec d'anciennes tablettes, mais l'usure naturelle ou d'usage réfulier n'est pas une raison pour un remplacement.\n+\n+#### Vérifier les problèmes avec votre stylet\n+\n+**Suivez les étpaes suivantes pour vérifier si votre stylet fonctionne normalement:**\n+\n+- Dévissez la plaque du stylet, exposant la batterie.\n+- Retirez la batterie AAA du stylet.\n+- Remplacez-la avec une nouvelle batterie AAA. **Vérifiez que la nouvelle batterie fonctionne dans un autre appareil avant.**\n+- Assurez-vous que les contacts positifs et négatifs sont bien placés dans le stylet. Il y a des marques indiquant quel endroit va où.\n+- Revissez la plaque.\n+- Appuyez sur le bouton à l'arrière (extrémité de la gomme) du stylet jusqu'à ce qu'il clique.\n+\n+Si la tablette fonctionne correctement, rapprocher le stylet de la tablette déplacera le curseur sur votre écran. \n+\n+Si ça n'arrive pas et que vous avez suivi les étpaes de vérification de la tablette précédent cette section, alors il est possible que votre stylet est cassé ou défectueux. \n+\n+Si votre stylet a été endommagé par l'usure ou par un accident (comme une chute), nous ne pouvons pas vous offrir de remplacement.\n+\n+Sinon, contactez [[email protected]](mailto:[email protected]) pour plus d'assistance, nous ferons tout ce que nous pourrons pour vous aider.\n+\n+### Mon ordinateur de détecte pas osu!go quand je le branche !\n+\n+**C'est un problème connu des tout premiers arrivages des clés USB _osu!go_, cela vient de l'appareil n'étant pas formaté de manière à ce qu'il fonctionne sur tous les PCs.**\n+\n+Même si ça peut sembler complexe, c'est assez facile à corriger.\n+\n+Tout d'abord, [téléchargez l'archive contenant les fichiers par défaut d'osu!go](https://assets.ppy.sh/store/utilities/osu!go.zip) et sauvegardez-le quelque part sur votre ordinateur.\n+\n+#### Formatter osu!go sous Windows\n+\n+**Suivez les étapes suivantes pour préparer votre _osu!go_ sous Windows:**\n+\n+1. Ouvrez le menu `Démarrer`.\n+2. Écrivez `gestion des disques` dans la barre de recherche. Cela vos mèera à la section `Créer et formatter des partitions de disque dur` du Panneau de Contrôle.\n+3. **Quand vous êtes dans la fenêtre Gestion des Disques, suivez ces instruction _à la lettre_ et n'appliquez les changements qu'à osu!go.** Vous pourrez perdre des données si vous jouez dans cette partie là.\n+4. Regardez dans quel état votre système reconnait osu!go.\n+\n+##### osu!go est présent, mais dans l'état \"RAW\".\n+\n+**Cet état ressemble à [ceci](https://puu.sh/nktuJ/05791b6fc1.png) dans la fenêtre de Gestion des disques.**\n+\n+Pour corriger cela, assurez-vous d'avoir sélectionné votre clé USB osu!go, cliquez-droit sur la partition RAW et sélectionnez l'option `Formater`. Choisissez soit `NTFS` soit `exFAT` sous la liste déroulante `\n+Système de Fichiers` dropdown.\n+\n+`exFAT` fonctionnera sous la plupart des appareils, mais est plus lent.\n+\n+##### osu!go n'est pas du tout présent dans la liste.\n+\n+**Vous devrez partitionner de zéro.**\n+\n+Veuillez suivre [ce guide](https://tails.boum.org/doc/first_steps/reset/windows/index.en.html) pour savoir comment faire.\n+\n+\n+##### J'ai reformaté ma clé osu!go et elle n'est plus dans la liste.\n+\n+**C'est presque fini !**\n+\n+Dézippez l'archive que nous vous avons demandé de télécharger plus tôt (osu!go.zip) dans votre _osu!go_ et c'est bon !\n+\n+##### Rien ne fonctionne !\n+\n+Si vous rencontrez des problèmes avec ces procédés,veuillez envoyer un email à [[email protected]](mailto:[email protected]) et nous vous aiderons.\n+\n+\n+----------------------------------------------------------------------------\n+\n+## Diagnostic\n+\n+### Que sont les 'journaux' et comment en faire ?\n+\n+**Les journaux sont des enregistrement de ce que le jeu fait à un certain moment. Nous pouvons les utiliser pour déterminer ce qui pose problème.**\n+\n+Ces fichiers sont extrêmement utiles et peuevtn aider à résoudre des problèmes complexes. \n+\n+Si un membre du support vous en demande, voici comment les obtenir:\n+\n+1. Ouvrez *osu*.\n+2. Allez dans le menu `Options` en cliquant sur le bouton dans le menu principal, ou en appuyant sur `CTRL+O`.\n+3. Écrivez `release` dans la barre de recherche, ce qui vous mènera à la version que votre client utilise.\n+4. Assurez-vous d'être en `Beta` ou `Cutting Edge (Experimental)`. Nous recommandons `Beta` pour de plus grandes chances de stabilité dans cette situation.\n+5. Redémarrez le jeu si vous avez modifié le type de version.\n+6. Entrez dans `Options`, et cliquez sur `Ouvrir le dossier d'osu!`.\n+7. Trouvez le dossier `Logs` dans la febêtre qui s'est ouverte.\n+8. Sélectionnez le journal demandé (le membre du support vous dira lequel), et attachez-le à votre ticket ou envoyez-le dans un service de partage de fichiers public.\n+\n+### Quelle est cet 'Bancho authentication error' que je n'arrête pas de reçevoir ?\n+\n+**Cela arrive quand il y a un problème de connxion entre vous et nos serveurs.**\n+\n+Il y a quelques choses que vous pouvez tenter de faire pour corriger ce problème.\n+\n+#### Avez-vous entré votre mot de passe correctement ?\n+\n+**C'est le plus évident.**\n+\n+Si vous avez oublié votre mot de passe, vous pouvez utiliser la [page de récupération de mot de passe](https://osu.ppy.sh/p/forgot) pour retrouver l'accès à votre compte.\n+\n+#### Utilisez-vous un proxy ou des VPNs?\n+\n+**Les désactiver avant de tenter de vous connecter pourrait résoudre votre problème.**\n+\n+Quelques fournisseurs de VPN et de serveurs proxy ne fonctionne pas pour certaines raisons.\n+\n+#### J'obtiens toujours cette erreur !\n+\n+**Nous aurons besoin du fichier `network.log` pour savoir ce qui se passe si aucune des solution ne fonctionne.**","path":"wiki/Help_Center/fr.md","position":935,"original_position":935,"commit_id":"006931c18756975ad14503efe521c05bd65b6da7","original_commit_id":"006931c18756975ad14503efe521c05bd65b6da7","user":{"login":"SpartanPlume","id":10873659,"avatar_url":"https://avatars1.githubusercontent.com/u/10873659?v=4","gravatar_id":"","url":"https://api.github.com/users/SpartanPlume","html_url":"https://github.com/SpartanPlume","followers_url":"https://api.github.com/users/SpartanPlume/followers","following_url":"https://api.github.com/users/SpartanPlume/following{/other_user}","gists_url":"https://api.github.com/users/SpartanPlume/gists{/gist_id}","starred_url":"https://api.github.com/users/SpartanPlume/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpartanPlume/subscriptions","organizations_url":"https://api.github.com/users/SpartanPlume/orgs","repos_url":"https://api.github.com/users/SpartanPlume/repos","events_url":"https://api.github.com/users/SpartanPlume/events{/privacy}","received_events_url":"https://api.github.com/users/SpartanPlume/received_events","type":"User","site_admin":false},"body":"solution -> solutions","created_at":"2017-09-09T12:32:03Z","updated_at":"2017-09-09T12:35:40Z","html_url":"https://github.com/ppy/osu-wiki/pull/492#discussion_r137925465","pull_request_url":"https://api.github.com/repos/ppy/osu-wiki/pulls/492","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/comments/137925465"},"html":{"href":"https://github.com/ppy/osu-wiki/pull/492#discussion_r137925465"},"pull_request":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/492"}}},"pull_request":{"url":"https://api.github.com/repos/ppy/osu-wiki/pulls/492","id":130579741,"html_url":"https://github.com/ppy/osu-wiki/pull/492","diff_url":"https://github.com/ppy/osu-wiki/pull/492.diff","patch_url":"https://github.com/ppy/osu-wiki/pull/492.patch","issue_url":"https://api.github.com/repos/ppy/osu-wiki/issues/492","number":492,"state":"open","locked":false,"title":"[FR] Translation of Help Center Part 8 / 8","user":{"login":"RedNesto","id":13600250,"avatar_url":"https://avatars3.githubusercontent.com/u/13600250?v=4","gravatar_id":"","url":"https://api.github.com/users/RedNesto","html_url":"https://github.com/RedNesto","followers_url":"https://api.github.com/users/RedNesto/followers","following_url":"https://api.github.com/users/RedNesto/following{/other_user}","gists_url":"https://api.github.com/users/RedNesto/gists{/gist_id}","starred_url":"https://api.github.com/users/RedNesto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedNesto/subscriptions","organizations_url":"https://api.github.com/users/RedNesto/orgs","repos_url":"https://api.github.com/users/RedNesto/repos","events_url":"https://api.github.com/users/RedNesto/events{/privacy}","received_events_url":"https://api.github.com/users/RedNesto/received_events","type":"User","site_admin":false},"body":"Don't know if you want to merge only this part or if we wait the complete translation after the rewrite","created_at":"2017-07-14T12:34:32Z","updated_at":"2017-09-09T12:35:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0a523fdc05bd5cd078d85c8f56defb0e397f0d2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ppy/osu-wiki/pulls/492/commits","review_comments_url":"https://api.github.com/repos/ppy/osu-wiki/pulls/492/comments","review_comment_url":"https://api.github.com/repos/ppy/osu-wiki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ppy/osu-wiki/issues/492/comments","statuses_url":"https://api.github.com/repos/ppy/osu-wiki/statuses/006931c18756975ad14503efe521c05bd65b6da7","head":{"label":"RedNesto:fr-help-center","ref":"fr-help-center","sha":"006931c18756975ad14503efe521c05bd65b6da7","user":{"login":"RedNesto","id":13600250,"avatar_url":"https://avatars3.githubusercontent.com/u/13600250?v=4","gravatar_id":"","url":"https://api.github.com/users/RedNesto","html_url":"https://github.com/RedNesto","followers_url":"https://api.github.com/users/RedNesto/followers","following_url":"https://api.github.com/users/RedNesto/following{/other_user}","gists_url":"https://api.github.com/users/RedNesto/gists{/gist_id}","starred_url":"https://api.github.com/users/RedNesto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedNesto/subscriptions","organizations_url":"https://api.github.com/users/RedNesto/orgs","repos_url":"https://api.github.com/users/RedNesto/repos","events_url":"https://api.github.com/users/RedNesto/events{/privacy}","received_events_url":"https://api.github.com/users/RedNesto/received_events","type":"User","site_admin":false},"repo":{"id":91887684,"name":"osu-wiki","full_name":"RedNesto/osu-wiki","owner":{"login":"RedNesto","id":13600250,"avatar_url":"https://avatars3.githubusercontent.com/u/13600250?v=4","gravatar_id":"","url":"https://api.github.com/users/RedNesto","html_url":"https://github.com/RedNesto","followers_url":"https://api.github.com/users/RedNesto/followers","following_url":"https://api.github.com/users/RedNesto/following{/other_user}","gists_url":"https://api.github.com/users/RedNesto/gists{/gist_id}","starred_url":"https://api.github.com/users/RedNesto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedNesto/subscriptions","organizations_url":"https://api.github.com/users/RedNesto/orgs","repos_url":"https://api.github.com/users/RedNesto/repos","events_url":"https://api.github.com/users/RedNesto/events{/privacy}","received_events_url":"https://api.github.com/users/RedNesto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RedNesto/osu-wiki","description":"future home of osu! wiki","fork":true,"url":"https://api.github.com/repos/RedNesto/osu-wiki","forks_url":"https://api.github.com/repos/RedNesto/osu-wiki/forks","keys_url":"https://api.github.com/repos/RedNesto/osu-wiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RedNesto/osu-wiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RedNesto/osu-wiki/teams","hooks_url":"https://api.github.com/repos/RedNesto/osu-wiki/hooks","issue_events_url":"https://api.github.com/repos/RedNesto/osu-wiki/issues/events{/number}","events_url":"https://api.github.com/repos/RedNesto/osu-wiki/events","assignees_url":"https://api.github.com/repos/RedNesto/osu-wiki/assignees{/user}","branches_url":"https://api.github.com/repos/RedNesto/osu-wiki/branches{/branch}","tags_url":"https://api.github.com/repos/RedNesto/osu-wiki/tags","blobs_url":"https://api.github.com/repos/RedNesto/osu-wiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RedNesto/osu-wiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RedNesto/osu-wiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/RedNesto/osu-wiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RedNesto/osu-wiki/statuses/{sha}","languages_url":"https://api.github.com/repos/RedNesto/osu-wiki/languages","stargazers_url":"https://api.github.com/repos/RedNesto/osu-wiki/stargazers","contributors_url":"https://api.github.com/repos/RedNesto/osu-wiki/contributors","subscribers_url":"https://api.github.com/repos/RedNesto/osu-wiki/subscribers","subscription_url":"https://api.github.com/repos/RedNesto/osu-wiki/subscription","commits_url":"https://api.github.com/repos/RedNesto/osu-wiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/RedNesto/osu-wiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/RedNesto/osu-wiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/RedNesto/osu-wiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/RedNesto/osu-wiki/contents/{+path}","compare_url":"https://api.github.com/repos/RedNesto/osu-wiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RedNesto/osu-wiki/merges","archive_url":"https://api.github.com/repos/RedNesto/osu-wiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RedNesto/osu-wiki/downloads","issues_url":"https://api.github.com/repos/RedNesto/osu-wiki/issues{/number}","pulls_url":"https://api.github.com/repos/RedNesto/osu-wiki/pulls{/number}","milestones_url":"https://api.github.com/repos/RedNesto/osu-wiki/milestones{/number}","notifications_url":"https://api.github.com/repos/RedNesto/osu-wiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RedNesto/osu-wiki/labels{/name}","releases_url":"https://api.github.com/repos/RedNesto/osu-wiki/releases{/id}","deployments_url":"https://api.github.com/repos/RedNesto/osu-wiki/deployments","created_at":"2017-05-20T12:29:37Z","updated_at":"2017-05-11T03:23:22Z","pushed_at":"2017-08-29T15:42:12Z","git_url":"git://github.com/RedNesto/osu-wiki.git","ssh_url":"[email protected]:RedNesto/osu-wiki.git","clone_url":"https://github.com/RedNesto/osu-wiki.git","svn_url":"https://github.com/RedNesto/osu-wiki","homepage":null,"size":417185,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ppy:master","ref":"master","sha":"23724cc668f8f8506b2190f5dae220881bf975b0","user":{"login":"ppy","id":995763,"avatar_url":"https://avatars1.githubusercontent.com/u/995763?v=4","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"repo":{"id":66639319,"name":"osu-wiki","full_name":"ppy/osu-wiki","owner":{"login":"ppy","id":995763,"avatar_url":"https://avatars1.githubusercontent.com/u/995763?v=4","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ppy/osu-wiki","description":"future home of osu! wiki","fork":false,"url":"https://api.github.com/repos/ppy/osu-wiki","forks_url":"https://api.github.com/repos/ppy/osu-wiki/forks","keys_url":"https://api.github.com/repos/ppy/osu-wiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppy/osu-wiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppy/osu-wiki/teams","hooks_url":"https://api.github.com/repos/ppy/osu-wiki/hooks","issue_events_url":"https://api.github.com/repos/ppy/osu-wiki/issues/events{/number}","events_url":"https://api.github.com/repos/ppy/osu-wiki/events","assignees_url":"https://api.github.com/repos/ppy/osu-wiki/assignees{/user}","branches_url":"https://api.github.com/repos/ppy/osu-wiki/branches{/branch}","tags_url":"https://api.github.com/repos/ppy/osu-wiki/tags","blobs_url":"https://api.github.com/repos/ppy/osu-wiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppy/osu-wiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppy/osu-wiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppy/osu-wiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppy/osu-wiki/statuses/{sha}","languages_url":"https://api.github.com/repos/ppy/osu-wiki/languages","stargazers_url":"https://api.github.com/repos/ppy/osu-wiki/stargazers","contributors_url":"https://api.github.com/repos/ppy/osu-wiki/contributors","subscribers_url":"https://api.github.com/repos/ppy/osu-wiki/subscribers","subscription_url":"https://api.github.com/repos/ppy/osu-wiki/subscription","commits_url":"https://api.github.com/repos/ppy/osu-wiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppy/osu-wiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppy/osu-wiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppy/osu-wiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppy/osu-wiki/contents/{+path}","compare_url":"https://api.github.com/repos/ppy/osu-wiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppy/osu-wiki/merges","archive_url":"https://api.github.com/repos/ppy/osu-wiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppy/osu-wiki/downloads","issues_url":"https://api.github.com/repos/ppy/osu-wiki/issues{/number}","pulls_url":"https://api.github.com/repos/ppy/osu-wiki/pulls{/number}","milestones_url":"https://api.github.com/repos/ppy/osu-wiki/milestones{/number}","notifications_url":"https://api.github.com/repos/ppy/osu-wiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppy/osu-wiki/labels{/name}","releases_url":"https://api.github.com/repos/ppy/osu-wiki/releases{/id}","deployments_url":"https://api.github.com/repos/ppy/osu-wiki/deployments","created_at":"2016-08-26T10:27:36Z","updated_at":"2017-09-09T10:16:31Z","pushed_at":"2017-09-09T09:55:26Z","git_url":"git://github.com/ppy/osu-wiki.git","ssh_url":"[email protected]:ppy/osu-wiki.git","clone_url":"https://github.com/ppy/osu-wiki.git","svn_url":"https://github.com/ppy/osu-wiki","homepage":null,"size":422101,"stargazers_count":75,"watchers_count":75,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":162,"mirror_url":null,"open_issues_count":48,"forks":162,"open_issues":48,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/492"},"html":{"href":"https://github.com/ppy/osu-wiki/pull/492"},"issue":{"href":"https://api.github.com/repos/ppy/osu-wiki/issues/492"},"comments":{"href":"https://api.github.com/repos/ppy/osu-wiki/issues/492/comments"},"review_comments":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/492/comments"},"review_comment":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/492/commits"},"statuses":{"href":"https://api.github.com/repos/ppy/osu-wiki/statuses/006931c18756975ad14503efe521c05bd65b6da7"}},"author_association":"CONTRIBUTOR"}} | {
"id": 66639319,
"name": "ppy/osu-wiki",
"url": "https://api.github.com/repos/ppy/osu-wiki"
} | {
"id": 10873659,
"login": "SpartanPlume",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10873659?",
"url": "https://api.github.com/users/SpartanPlume"
} | {
"id": 995763,
"login": "ppy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/995763?",
"url": "https://api.github.com/orgs/ppy"
} | 2017-09-09T12:32:03 | 6569727068 | {"actor":{"display_login":"SpartanPlume"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ppy/osu-wiki/pulls/comments/153113330","pull_request_review_id":79071305,"id":153113330,"diff_hunk":"@@ -0,0 +1,106 @@\n+---\n+layout: post\n+title: \"Beatmap Spotlights October 2017\"\n+date: 2017-11-28 16:00:00 +0000\n+---\n+\n+Halloween may be over, but with that comes a selection of the best maps from the spooky month of October. It’s time to look at this month’s Spotlights, and maybe get a medal while you’re at it!\n+\n+\n+\n+The beatmap charts for the October Spotlights can be found [here](https://osu.ppy.sh/p/chart?ch=MONTH1711). Their respective packs are available at the [Beatmap Pack Listing](https://osu.ppy.sh/p/packlist?t=r) for easier access.\n+\n+## Past Spotlights results\n+\n+Congratulations to the winners of the September 2017 Spotlights. They receive one month of supporter status for their efforts!\n+\n++ **osu!:** [Toy](https://osu.ppy.sh/u/2757689)\n++ **osu!taiko:** [asuasu_yura](https://osu.ppy.sh/u/2875968)\n++ **osu!catch:** [Motion](https://osu.ppy.sh/u/3885626)\n++ **osu!mania:** [Lindyes](https://osu.ppy.sh/u/7462804)\n+\n+\n+## osu!\n+\n+[](https://osu.ppy.sh/s/666566)\n+\n+[IceBeam](https://osu.ppy.sh/u/208440) has risen from the grave to bring us \"Like A Man\" by Korean rapper \"Outsider\". The mapper shows us that even after a long hiatus, they still know how to amaze with great flow all throughout the map. Additionally, the map offers great pattern variety while fitting everything nicely together, expressing the song well. That's why \"Like A Man\" is a map not to miss out on this month!\n+\n+[](http://osu.ppy.sh/s/326608)\n+\n+You don't usually see rhythm game songs mapped in this fashion, but it's exactly why [Nyquill](https://osu.ppy.sh/u/682935)'s rendition of Lilieze to Enryuu Laevateinn is so interesting. A style reminiscent of the old 2014 days, it still manages to hold up to this day. Despite not conforming to modern visual standards, the movements and feelings evoked from the map are still refined for the player, giving it a natural and smooth experience. Similarly, [Giralda](https://osu.ppy.sh/u/1823446)'s and [captin1](https://osu.ppy.sh/u/689997)'s guest difficulties are a fantastic complement to the set, with their styles being similar to one another. All in all, a deserving candidate for this month's Spotlights.\n+\n+[](http://osu.ppy.sh/s/622780)\n+\n+[Crystal](https://osu.ppy.sh/u/1646397) brings us yet another top tier mapset this month for KOTOKO's Koi Kou Enishi. A wide selection of Insane and Expert difficulties are available here, but don't let the star ratings confuse you - while the highest difficulty by [yf_bmp](https://osu.ppy.sh/u/1243669) may be below five stars, it features quite a few spaced streams and patterns that you wouldn't find on the average map!\n+\n+[](https://osu.ppy.sh/s/577394)\n+\n+[Milan](https://osu.ppy.sh/u/1152994)'s latest mapset of Punk Rock Girl brings us an exhilarating experience suitable for all ranks! You won't be seeing any jumps here, but rather a constant barrage of sliders and circles all mapped in an orthodox alternating fashion, all intended to keep you on your toes in this short song. Guest Difficulties from both [Pho](https://osu.ppy.sh/u/3624692) and Streetlight Manifesto enthusiast [pishifat](https://osu.ppy.sh/u/3178418) bring extra zest into the set, with interesting rhythms and patterns not usually seen in their respective difficulties.\n+\n+## osu!taiko\n+\n+[](https://osu.ppy.sh/s/458476)\n+\n+Leading this month's osu!taiko Spotlights we have ZADAMGA, a one-time masterpiece that you would not see normally in the depths of the Ranked Beatmaps category. Consisting of a total of six difficulties mapped by [agu](https://osu.ppy.sh/u/1119122) himself, not only does it demonstrate an exemplary skill in spread management in lower difficulties, but also an outstanding mastery in different rhythm and beat snap usage by the mapper.\n+\n+While simple 1/4 and 1/6 patterns are most common in modern osu!taiko mapping, the highest difficulty “Fatale Oni” employs a beautifully mixed repertoire of simple and compound rhythms, having an almost equalized usage of 1/3 rhythms in comparison to regular 1/2 or 1/4 rhythms. In short, a very complete mapset that has its well deserved spot on the top of this month's Spotlights!\n+\n+[](https://osu.ppy.sh/s/672802)\n+\n+[TKS](https://osu.ppy.sh/u/940878) has recently returned and brought us a decent set consisting of five difficulties. The mapper showed their expertise about spread management which could be reflected by the smooth transitions of level of difficulty from Kantan to Inner Oni, helping players to advance seamlessly.\n+\n+Inner Oni is undoubtedly the highlight of the set by the veteran mapper. Arranged with interesting 1/4 and 1/6 combinations that cohere with the catchy rhythm appropriately, the difficulty flows smoothly in a consistent way, considerably enhancing the overall gameplay experience.\n+\n+Let's enjoy this piece of music mapped by an AsiaN with the non-distracting oriental antiquity atmosphere!\n+\n+[](https://osu.ppy.sh/s/665911)\n+\n+Eliciting powerful feelings of determination, [Raiden](https://osu.ppy.sh/u/2239480)'s map of \"Yumeshoushitsu ~ Lost Dream\" is a vivid exploration into improvisation-based taiko mapping.\n+\n+Clocking in at just under 6 minutes, this marathon leaves surprisingly little to the imagination. Employing a diverse range of rhythms and patterning throughout, this map will prove to be an exciting and fun challenge for high level players!\n+\n+## osu!catch\n+\n+[](https://osu.ppy.sh/s/609679)\n+\n+Thanks to [Ascendance](https://osu.ppy.sh/u/2931883), together with [ZiRoX](https://osu.ppy.sh/u/200768), [Spectator](https://osu.ppy.sh/u/702598), [Hareimu](https://osu.ppy.sh/u/4138746), [Sorcerer](https://osu.ppy.sh/u/1913190), and [Emiru](https://osu.ppy.sh/u/3306180), we can get shaking somehow with On the FM this month. Covering a full spread, this mapset successfully gives out colorful presentation of \"shaking\" for every level. Repetitive zig-zag walks, connected shaking sliders, consecutive 1/8 doubles, or even constant crazy 1/4 Hyperdashes, all these wonderful patterns help us step into a different world of catching fruits. I can promise that from newbie players to top players, everyone can enjoy this mapset with \"shaking\".\n+\n+[](https://osu.ppy.sh/s/665562)\n+\n+Love it or hate it, however you might feel about this song, it cannot be denied that [Ascendance](https://osu.ppy.sh/u/2931883) and [Spectator](https://osu.ppy.sh/u/702598) have created a fantastic pair of osu!catch difficulties. Weaving between the strong drums and energetic vocals, both difficulties capture the song’s essence wonderfully. Ascendance’s Rain makes great use of big hyperdashes whilst Spectator’s Overdose turns things up a notch with quicker snaps for faster hyperdashes and more direction changes to deliver all the challenge this song has to offer. So even if you’ve heard this song a thousand times already, try giving it just a couple more for these great difficulties.\n+\n+[](https://osu.ppy.sh/s/522132)\n+\n+Do you still remember the utopia we've seen in the CWC 2017 semifinals? This time we can share the Utopiosphere -Platonism- created by [Benny-](https://osu.ppy.sh/u/4023183), [Tyrell](https://osu.ppy.sh/u/4598862), and [Nelly](https://osu.ppy.sh/u/4741164) in the ranked section!\n+\n+The spread of this mapset is pretty balanced, and you can enjoy some interesting challenges in the higher difficulties. With general patterns in convenient flow, gimmicky long sliders, and sudden direction changes alongside speed up curves, there really is a lot of variety. With such diverse talent, this mapset will not disappoint you!\n+\n+## osu!mania\n+\n+[](https://osu.ppy.sh/s/643857)\n+\n+Topping this month’s mania spotlights is none other than [Parachor](https://osu.ppy.sh/u/5241655) with his newest addition to the ranked section, The Impulsive State. Staying true to his signature unconventional style, the chart sports an impressive variety of slider velocity changes ranging from stutters and reverse bumps to fast jams and waves. With a high HP of 8.8, coupled with some very tight long note releases and overlapped timings, passing is no easy feat despite its low Star Rating and is a refreshing challenge for players of many levels.\n+\n+[](https://osu.ppy.sh/s/512408)\n+\n+Here comes [juankristal](https://osu.ppy.sh/u/443656) bringing us fresh noodles, with a guest appearance from [Jinjin](https://osu.ppy.sh/u/3360737)! This map is notable for its use of long notes, which can get very complex and heavy at times, but its usage provides a good variety of patterns that are rarely seen in the ranked section. Most notably, the MX difficulty has sections where the player has to hold all the available keys and try to hold their combo as more long notes come after the long note releases, thus putting their skill and knowledge of long notes to the test.","path":"news/2017-11-28-beatmap-spotlights-october-2017.md","position":87,"original_position":87,"commit_id":"050624a83ee7fb5b5874dabc57d1f009247b3575","original_commit_id":"050624a83ee7fb5b5874dabc57d1f009247b3575","user":{"login":"Ephemeralis","id":966289,"avatar_url":"https://avatars1.githubusercontent.com/u/966289?v=4","gravatar_id":"","url":"https://api.github.com/users/Ephemeralis","html_url":"https://github.com/Ephemeralis","followers_url":"https://api.github.com/users/Ephemeralis/followers","following_url":"https://api.github.com/users/Ephemeralis/following{/other_user}","gists_url":"https://api.github.com/users/Ephemeralis/gists{/gist_id}","starred_url":"https://api.github.com/users/Ephemeralis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ephemeralis/subscriptions","organizations_url":"https://api.github.com/users/Ephemeralis/orgs","repos_url":"https://api.github.com/users/Ephemeralis/repos","events_url":"https://api.github.com/users/Ephemeralis/events{/privacy}","received_events_url":"https://api.github.com/users/Ephemeralis/received_events","type":"User","site_admin":false},"body":"New paragraph at most notably","created_at":"2017-11-27T06:19:13Z","updated_at":"2017-11-27T06:20:16Z","html_url":"https://github.com/ppy/osu-wiki/pull/856#discussion_r153113330","pull_request_url":"https://api.github.com/repos/ppy/osu-wiki/pulls/856","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/comments/153113330"},"html":{"href":"https://github.com/ppy/osu-wiki/pull/856#discussion_r153113330"},"pull_request":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/856"}}},"pull_request":{"url":"https://api.github.com/repos/ppy/osu-wiki/pulls/856","id":154504648,"html_url":"https://github.com/ppy/osu-wiki/pull/856","diff_url":"https://github.com/ppy/osu-wiki/pull/856.diff","patch_url":"https://github.com/ppy/osu-wiki/pull/856.patch","issue_url":"https://api.github.com/repos/ppy/osu-wiki/issues/856","number":856,"state":"open","locked":false,"title":"October Spotlights 2017","user":{"login":"Shadowthegod","id":1615758,"avatar_url":"https://avatars3.githubusercontent.com/u/1615758?v=4","gravatar_id":"","url":"https://api.github.com/users/Shadowthegod","html_url":"https://github.com/Shadowthegod","followers_url":"https://api.github.com/users/Shadowthegod/followers","following_url":"https://api.github.com/users/Shadowthegod/following{/other_user}","gists_url":"https://api.github.com/users/Shadowthegod/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadowthegod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadowthegod/subscriptions","organizations_url":"https://api.github.com/users/Shadowthegod/orgs","repos_url":"https://api.github.com/users/Shadowthegod/repos","events_url":"https://api.github.com/users/Shadowthegod/events{/privacy}","received_events_url":"https://api.github.com/users/Shadowthegod/received_events","type":"User","site_admin":false},"body":"### Description\r\nAdded images and article for the Spotlights of October\r\n### Status\r\nFinished; Pending Review \r\n","created_at":"2017-11-24T09:28:22Z","updated_at":"2017-11-27T06:20:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28f2d8ba36010dbe9faef744cca7d215662b2070","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ppy/osu-wiki/pulls/856/commits","review_comments_url":"https://api.github.com/repos/ppy/osu-wiki/pulls/856/comments","review_comment_url":"https://api.github.com/repos/ppy/osu-wiki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ppy/osu-wiki/issues/856/comments","statuses_url":"https://api.github.com/repos/ppy/osu-wiki/statuses/050624a83ee7fb5b5874dabc57d1f009247b3575","head":{"label":"Shadowthegod:Spotlights","ref":"Spotlights","sha":"050624a83ee7fb5b5874dabc57d1f009247b3575","user":{"login":"Shadowthegod","id":1615758,"avatar_url":"https://avatars3.githubusercontent.com/u/1615758?v=4","gravatar_id":"","url":"https://api.github.com/users/Shadowthegod","html_url":"https://github.com/Shadowthegod","followers_url":"https://api.github.com/users/Shadowthegod/followers","following_url":"https://api.github.com/users/Shadowthegod/following{/other_user}","gists_url":"https://api.github.com/users/Shadowthegod/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadowthegod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadowthegod/subscriptions","organizations_url":"https://api.github.com/users/Shadowthegod/orgs","repos_url":"https://api.github.com/users/Shadowthegod/repos","events_url":"https://api.github.com/users/Shadowthegod/events{/privacy}","received_events_url":"https://api.github.com/users/Shadowthegod/received_events","type":"User","site_admin":false},"repo":{"id":98024639,"name":"osu-wiki","full_name":"Shadowthegod/osu-wiki","owner":{"login":"Shadowthegod","id":1615758,"avatar_url":"https://avatars3.githubusercontent.com/u/1615758?v=4","gravatar_id":"","url":"https://api.github.com/users/Shadowthegod","html_url":"https://github.com/Shadowthegod","followers_url":"https://api.github.com/users/Shadowthegod/followers","following_url":"https://api.github.com/users/Shadowthegod/following{/other_user}","gists_url":"https://api.github.com/users/Shadowthegod/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadowthegod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadowthegod/subscriptions","organizations_url":"https://api.github.com/users/Shadowthegod/orgs","repos_url":"https://api.github.com/users/Shadowthegod/repos","events_url":"https://api.github.com/users/Shadowthegod/events{/privacy}","received_events_url":"https://api.github.com/users/Shadowthegod/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Shadowthegod/osu-wiki","description":"future home of osu! wiki","fork":true,"url":"https://api.github.com/repos/Shadowthegod/osu-wiki","forks_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/forks","keys_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/teams","hooks_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/hooks","issue_events_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/issues/events{/number}","events_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/events","assignees_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/assignees{/user}","branches_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/branches{/branch}","tags_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/tags","blobs_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/statuses/{sha}","languages_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/languages","stargazers_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/stargazers","contributors_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/contributors","subscribers_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/subscribers","subscription_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/subscription","commits_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/contents/{+path}","compare_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/merges","archive_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/downloads","issues_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/issues{/number}","pulls_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/pulls{/number}","milestones_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/milestones{/number}","notifications_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/labels{/name}","releases_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/releases{/id}","deployments_url":"https://api.github.com/repos/Shadowthegod/osu-wiki/deployments","created_at":"2017-07-22T10:36:09Z","updated_at":"2017-07-18T06:18:41Z","pushed_at":"2017-11-24T09:25:30Z","git_url":"git://github.com/Shadowthegod/osu-wiki.git","ssh_url":"[email protected]:Shadowthegod/osu-wiki.git","clone_url":"https://github.com/Shadowthegod/osu-wiki.git","svn_url":"https://github.com/Shadowthegod/osu-wiki","homepage":null,"size":441894,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ppy:master","ref":"master","sha":"517b061688e2d1a10cb53d195abf6e8063935dfb","user":{"login":"ppy","id":995763,"avatar_url":"https://avatars1.githubusercontent.com/u/995763?v=4","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"repo":{"id":66639319,"name":"osu-wiki","full_name":"ppy/osu-wiki","owner":{"login":"ppy","id":995763,"avatar_url":"https://avatars1.githubusercontent.com/u/995763?v=4","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ppy/osu-wiki","description":"future home of osu! wiki","fork":false,"url":"https://api.github.com/repos/ppy/osu-wiki","forks_url":"https://api.github.com/repos/ppy/osu-wiki/forks","keys_url":"https://api.github.com/repos/ppy/osu-wiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppy/osu-wiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppy/osu-wiki/teams","hooks_url":"https://api.github.com/repos/ppy/osu-wiki/hooks","issue_events_url":"https://api.github.com/repos/ppy/osu-wiki/issues/events{/number}","events_url":"https://api.github.com/repos/ppy/osu-wiki/events","assignees_url":"https://api.github.com/repos/ppy/osu-wiki/assignees{/user}","branches_url":"https://api.github.com/repos/ppy/osu-wiki/branches{/branch}","tags_url":"https://api.github.com/repos/ppy/osu-wiki/tags","blobs_url":"https://api.github.com/repos/ppy/osu-wiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppy/osu-wiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppy/osu-wiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppy/osu-wiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppy/osu-wiki/statuses/{sha}","languages_url":"https://api.github.com/repos/ppy/osu-wiki/languages","stargazers_url":"https://api.github.com/repos/ppy/osu-wiki/stargazers","contributors_url":"https://api.github.com/repos/ppy/osu-wiki/contributors","subscribers_url":"https://api.github.com/repos/ppy/osu-wiki/subscribers","subscription_url":"https://api.github.com/repos/ppy/osu-wiki/subscription","commits_url":"https://api.github.com/repos/ppy/osu-wiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppy/osu-wiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppy/osu-wiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppy/osu-wiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppy/osu-wiki/contents/{+path}","compare_url":"https://api.github.com/repos/ppy/osu-wiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppy/osu-wiki/merges","archive_url":"https://api.github.com/repos/ppy/osu-wiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppy/osu-wiki/downloads","issues_url":"https://api.github.com/repos/ppy/osu-wiki/issues{/number}","pulls_url":"https://api.github.com/repos/ppy/osu-wiki/pulls{/number}","milestones_url":"https://api.github.com/repos/ppy/osu-wiki/milestones{/number}","notifications_url":"https://api.github.com/repos/ppy/osu-wiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppy/osu-wiki/labels{/name}","releases_url":"https://api.github.com/repos/ppy/osu-wiki/releases{/id}","deployments_url":"https://api.github.com/repos/ppy/osu-wiki/deployments","created_at":"2016-08-26T10:27:36Z","updated_at":"2017-11-15T08:45:51Z","pushed_at":"2017-11-27T03:06:33Z","git_url":"git://github.com/ppy/osu-wiki.git","ssh_url":"[email protected]:ppy/osu-wiki.git","clone_url":"https://github.com/ppy/osu-wiki.git","svn_url":"https://github.com/ppy/osu-wiki","homepage":null,"size":442646,"stargazers_count":78,"watchers_count":78,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":189,"mirror_url":null,"archived":false,"open_issues_count":56,"forks":189,"open_issues":56,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/856"},"html":{"href":"https://github.com/ppy/osu-wiki/pull/856"},"issue":{"href":"https://api.github.com/repos/ppy/osu-wiki/issues/856"},"comments":{"href":"https://api.github.com/repos/ppy/osu-wiki/issues/856/comments"},"review_comments":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/856/comments"},"review_comment":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ppy/osu-wiki/pulls/856/commits"},"statuses":{"href":"https://api.github.com/repos/ppy/osu-wiki/statuses/050624a83ee7fb5b5874dabc57d1f009247b3575"}},"author_association":"CONTRIBUTOR"}} | {
"id": 66639319,
"name": "ppy/osu-wiki",
"url": "https://api.github.com/repos/ppy/osu-wiki"
} | {
"id": 966289,
"login": "Ephemeralis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/966289?",
"url": "https://api.github.com/users/Ephemeralis"
} | {
"id": 995763,
"login": "ppy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/995763?",
"url": "https://api.github.com/orgs/ppy"
} | 2017-11-27T06:19:13 | 6905315768 | {"actor":{"display_login":"Ephemeralis"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/sbt/zinc/pulls/comments/126536102","pull_request_review_id":49030322,"id":126536102,"diff_hunk":"@@ -58,10 +59,9 @@ trait WithPattern { protected def Pattern: Regex }\n import java.lang.{ Long => BoxedLong }\n \n /** Define the hash of the file contents. It's a typical stamp for compilation sources. */\n-final class Hash(val value: Array[Byte]) extends StampBase {\n- val hexHash = IOHash.toHex(value)\n+final class Hash(val hexHash: String) extends StampBase {","path":"internal/zinc-core/src/main/scala/sbt/internal/inc/Stamp.scala","position":14,"original_position":14,"commit_id":"f825fc7b7a8b5f12f19576e66ced9ac83df2d38a","original_commit_id":"f825fc7b7a8b5f12f19576e66ced9ac83df2d38a","user":{"login":"jvican","id":2462974,"avatar_url":"https://avatars3.githubusercontent.com/u/2462974?v=3","gravatar_id":"","url":"https://api.github.com/users/jvican","html_url":"https://github.com/jvican","followers_url":"https://api.github.com/users/jvican/followers","following_url":"https://api.github.com/users/jvican/following{/other_user}","gists_url":"https://api.github.com/users/jvican/gists{/gist_id}","starred_url":"https://api.github.com/users/jvican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvican/subscriptions","organizations_url":"https://api.github.com/users/jvican/orgs","repos_url":"https://api.github.com/users/jvican/repos","events_url":"https://api.github.com/users/jvican/events{/privacy}","received_events_url":"https://api.github.com/users/jvican/received_events","type":"User","site_admin":false},"body":"See commit message. It removes an unnecessary transformation when reading/writing.","created_at":"2017-07-10T21:02:38Z","updated_at":"2017-07-10T21:02:39Z","html_url":"https://github.com/sbt/zinc/pull/351#discussion_r126536102","pull_request_url":"https://api.github.com/repos/sbt/zinc/pulls/351","_links":{"self":{"href":"https://api.github.com/repos/sbt/zinc/pulls/comments/126536102"},"html":{"href":"https://github.com/sbt/zinc/pull/351#discussion_r126536102"},"pull_request":{"href":"https://api.github.com/repos/sbt/zinc/pulls/351"}}},"pull_request":{"url":"https://api.github.com/repos/sbt/zinc/pulls/351","id":129743660,"html_url":"https://github.com/sbt/zinc/pull/351","diff_url":"https://github.com/sbt/zinc/pull/351.diff","patch_url":"https://github.com/sbt/zinc/pull/351.patch","issue_url":"https://api.github.com/repos/sbt/zinc/issues/351","number":351,"state":"open","locked":false,"title":"Add protobuf-based analysis binary store","user":{"login":"jvican","id":2462974,"avatar_url":"https://avatars3.githubusercontent.com/u/2462974?v=3","gravatar_id":"","url":"https://api.github.com/users/jvican","html_url":"https://github.com/jvican","followers_url":"https://api.github.com/users/jvican/followers","following_url":"https://api.github.com/users/jvican/following{/other_user}","gists_url":"https://api.github.com/users/jvican/gists{/gist_id}","starred_url":"https://api.github.com/users/jvican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvican/subscriptions","organizations_url":"https://api.github.com/users/jvican/orgs","repos_url":"https://api.github.com/users/jvican/repos","events_url":"https://api.github.com/users/jvican/events{/privacy}","received_events_url":"https://api.github.com/users/jvican/received_events","type":"User","site_admin":false},"body":"This pull request replaces the text-based analysis format by a binary format\npowered by Protobuf. The new format provides us with two main advantages:\n\n1. Backwards and forwards binary compatibility at the analysis format level.\n2. Faster serialization/deserialization of the analysis file.\n3. Provides a much better way to make the analysis file machine-independent.\n\nThe purpose of this pull request was to add the benefits of a\nbackwards/forwards binary compatible analysis file without impacting the speed\nof the text-based analysis format. In my local experiments, this goal has been\nmet. The new format is on par performance-wise with the text-based analysis\nformat for small analysis files, and it's much faster (~1.5-2x) when increasing\nthe Scalacheck generators (`maxSources` and `maxRelatives`) from 10 to 40, and\neven more if the number increases.\n\nWith regards to the public API, the PR defines the public API in zinc persist,\nwhich was all internal. This API is required by every piece of software that\nintegrates with Zinc and needs to modify the read/write steps in a sane way.\n\nThe API adds the following interfaces:\n\n1. `ReadMappers`. To allow customisation before reading the analysis files.\n2. `WriteMappers`. To allow customisation before writing the analysis files.\n3. `ReadWriteMappers`. To wrap the read and write mappers.\n4. `AnalysisStore`. To allow users to implement their own way to back analysis\n files.\n5. `AnalysisContents`. To allow API evolution of the return type of `set` in\n `AnalysisStore`. It replaces the previous tuple.\n\nThese APIs all provide ways to get the default implementations from Java.\n\nThe most relevant implementations to discuss are the ones for `ReadMappers` and\n`WriteMappers`. These implementations expose a way to relativize (make\nmachine-independent) an analysis file. Why would someone want to do that? To\nship analysis files to clusters and associate them with commits to avoid first\ncompilations when checking out a concrete commit.\n\nThese implementations, however, are not meant to cover all the possible use\ncases for all build tools, they only provide a simple implementation for those\nusers that can ensure that all paths in the analysis file start with a concrete\nprefix. This is usually not the case (read docs in the interfaces), and\ntherefore build tools will need to implement their own, taking into account all\nthe paths that can be present: ivy cache, coursier cache, binary dirs, product\ndirs, et cetera. This approach was taken because it's impossible to produce an\nelegant implementation that satisfies all build tools' requirements.\n\nI've shipped today a release that @stuhood is using to integrate with these\nchanges and the ones I made to the loggers interface. It is accessible\n[here](https://bintray.com/scalacenter/releases/zinc/1.0.0-X19-M1).\n\nThe implementation has been done iteratively so that every commit compiles,\nmaking the final switch in the last commits.\n\nI recommend that the people with most experience in this part of the codebase\n(@eed3si9n and @Duhemm) review this PR. Also a ping for @stuhood. @dwijnand\nPlease feel free to have a view on it, too, if you'd like.\n\nThe way I recommend to review this PR is to have a look at the resulting diff.\nIt may look like huge, but it's actually conceptually really simple:\n\n* Changes that affect `zincPersist` basically add:\n * Converters from the Zinc API => protobuf and viceversa.\n * Mappers implementations.\n * `FileAnalysisStore` implementation.\n* Changes that don't affect the `zincPersist` module have been done to adjust\n the use sites of the new introduced APIs. `AnalysisStore` and `AnalysisFile`\n are defined in the Java sources of the `zinc` module.\n* Remove all the tools used in the previous implementation.\n* Remove sbinary dependency and add protobuf dependency.\n\nTherefore, I suggest you have pay attention to the following parts:\n* Public binary API.\n* Protobuf converters.\n\nPerformance-wise, note that the implementation can be much faster in the future\nby streaming instead of converting first to the protobuf IR (or the other way\naround) and then reading/writing. However, this is not worth it for now, in my\nopinion, because of two reasons:\n\n1. We don't want complexity in this part of the codebase. The dumber, the better.\n2. The time spent on reading/writing analysis files account for 1-3% of the\n whole compile time. This, of course, may be significant for some *big*\n projects but we should not introduce complexity until that's proven with\n data. And it seems that no one complained about the text-based format; so\n being the binary format faster than that one as it currently, I don't\n consider it's worth it do streaming.\n\nWhen it comes to readability, the new format provides ways to read the code via\nScalaPB's CLI tool and also javapb. From within the code, doing `toString` in\nany class of the Protobuf API suffices to show the JSON code of the protos. I\nwill add instructions on how to run this to the CONTRIBUTING guide in a bit.\n\nI'm adding two commits very shortly, but they won't affect the contents of this\nPR. The pull request is up for review. Let me know if there's something I haven't covered yet.","created_at":"2017-07-10T18:28:36Z","updated_at":"2017-07-10T21:02:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"946cf442086b795f9df73e224306a53796a085cc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"eed3si9n","id":184683,"avatar_url":"https://avatars3.githubusercontent.com/u/184683?v=3","gravatar_id":"","url":"https://api.github.com/users/eed3si9n","html_url":"https://github.com/eed3si9n","followers_url":"https://api.github.com/users/eed3si9n/followers","following_url":"https://api.github.com/users/eed3si9n/following{/other_user}","gists_url":"https://api.github.com/users/eed3si9n/gists{/gist_id}","starred_url":"https://api.github.com/users/eed3si9n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eed3si9n/subscriptions","organizations_url":"https://api.github.com/users/eed3si9n/orgs","repos_url":"https://api.github.com/users/eed3si9n/repos","events_url":"https://api.github.com/users/eed3si9n/events{/privacy}","received_events_url":"https://api.github.com/users/eed3si9n/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sbt/zinc/pulls/351/commits","review_comments_url":"https://api.github.com/repos/sbt/zinc/pulls/351/comments","review_comment_url":"https://api.github.com/repos/sbt/zinc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sbt/zinc/issues/351/comments","statuses_url":"https://api.github.com/repos/sbt/zinc/statuses/f825fc7b7a8b5f12f19576e66ced9ac83df2d38a","head":{"label":"scalacenter:protobuf","ref":"protobuf","sha":"f825fc7b7a8b5f12f19576e66ced9ac83df2d38a","user":{"login":"scalacenter","id":16118980,"avatar_url":"https://avatars1.githubusercontent.com/u/16118980?v=3","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"repo":{"id":80068441,"name":"zinc","full_name":"scalacenter/zinc","owner":{"login":"scalacenter","id":16118980,"avatar_url":"https://avatars1.githubusercontent.com/u/16118980?v=3","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalacenter/zinc","description":"Scala incremental compiler library, originally part of sbt","fork":true,"url":"https://api.github.com/repos/scalacenter/zinc","forks_url":"https://api.github.com/repos/scalacenter/zinc/forks","keys_url":"https://api.github.com/repos/scalacenter/zinc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalacenter/zinc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalacenter/zinc/teams","hooks_url":"https://api.github.com/repos/scalacenter/zinc/hooks","issue_events_url":"https://api.github.com/repos/scalacenter/zinc/issues/events{/number}","events_url":"https://api.github.com/repos/scalacenter/zinc/events","assignees_url":"https://api.github.com/repos/scalacenter/zinc/assignees{/user}","branches_url":"https://api.github.com/repos/scalacenter/zinc/branches{/branch}","tags_url":"https://api.github.com/repos/scalacenter/zinc/tags","blobs_url":"https://api.github.com/repos/scalacenter/zinc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalacenter/zinc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalacenter/zinc/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalacenter/zinc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalacenter/zinc/statuses/{sha}","languages_url":"https://api.github.com/repos/scalacenter/zinc/languages","stargazers_url":"https://api.github.com/repos/scalacenter/zinc/stargazers","contributors_url":"https://api.github.com/repos/scalacenter/zinc/contributors","subscribers_url":"https://api.github.com/repos/scalacenter/zinc/subscribers","subscription_url":"https://api.github.com/repos/scalacenter/zinc/subscription","commits_url":"https://api.github.com/repos/scalacenter/zinc/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalacenter/zinc/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalacenter/zinc/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalacenter/zinc/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalacenter/zinc/contents/{+path}","compare_url":"https://api.github.com/repos/scalacenter/zinc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalacenter/zinc/merges","archive_url":"https://api.github.com/repos/scalacenter/zinc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalacenter/zinc/downloads","issues_url":"https://api.github.com/repos/scalacenter/zinc/issues{/number}","pulls_url":"https://api.github.com/repos/scalacenter/zinc/pulls{/number}","milestones_url":"https://api.github.com/repos/scalacenter/zinc/milestones{/number}","notifications_url":"https://api.github.com/repos/scalacenter/zinc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalacenter/zinc/labels{/name}","releases_url":"https://api.github.com/repos/scalacenter/zinc/releases{/id}","deployments_url":"https://api.github.com/repos/scalacenter/zinc/deployments","created_at":"2017-01-25T23:28:29Z","updated_at":"2017-04-13T04:35:09Z","pushed_at":"2017-07-10T18:44:55Z","git_url":"git://github.com/scalacenter/zinc.git","ssh_url":"[email protected]:scalacenter/zinc.git","clone_url":"https://github.com/scalacenter/zinc.git","svn_url":"https://github.com/scalacenter/zinc","homepage":"","size":10839,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"scala-center"}},"base":{"label":"sbt:1.0","ref":"1.0","sha":"26f11d213a4c4214e725d53be08e042e52e70692","user":{"login":"sbt","id":1158012,"avatar_url":"https://avatars1.githubusercontent.com/u/1158012?v=3","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"repo":{"id":40210247,"name":"zinc","full_name":"sbt/zinc","owner":{"login":"sbt","id":1158012,"avatar_url":"https://avatars1.githubusercontent.com/u/1158012?v=3","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sbt/zinc","description":"Scala incremental compiler library, originally part of sbt","fork":false,"url":"https://api.github.com/repos/sbt/zinc","forks_url":"https://api.github.com/repos/sbt/zinc/forks","keys_url":"https://api.github.com/repos/sbt/zinc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbt/zinc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbt/zinc/teams","hooks_url":"https://api.github.com/repos/sbt/zinc/hooks","issue_events_url":"https://api.github.com/repos/sbt/zinc/issues/events{/number}","events_url":"https://api.github.com/repos/sbt/zinc/events","assignees_url":"https://api.github.com/repos/sbt/zinc/assignees{/user}","branches_url":"https://api.github.com/repos/sbt/zinc/branches{/branch}","tags_url":"https://api.github.com/repos/sbt/zinc/tags","blobs_url":"https://api.github.com/repos/sbt/zinc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbt/zinc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbt/zinc/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbt/zinc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbt/zinc/statuses/{sha}","languages_url":"https://api.github.com/repos/sbt/zinc/languages","stargazers_url":"https://api.github.com/repos/sbt/zinc/stargazers","contributors_url":"https://api.github.com/repos/sbt/zinc/contributors","subscribers_url":"https://api.github.com/repos/sbt/zinc/subscribers","subscription_url":"https://api.github.com/repos/sbt/zinc/subscription","commits_url":"https://api.github.com/repos/sbt/zinc/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbt/zinc/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbt/zinc/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbt/zinc/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbt/zinc/contents/{+path}","compare_url":"https://api.github.com/repos/sbt/zinc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbt/zinc/merges","archive_url":"https://api.github.com/repos/sbt/zinc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbt/zinc/downloads","issues_url":"https://api.github.com/repos/sbt/zinc/issues{/number}","pulls_url":"https://api.github.com/repos/sbt/zinc/pulls{/number}","milestones_url":"https://api.github.com/repos/sbt/zinc/milestones{/number}","notifications_url":"https://api.github.com/repos/sbt/zinc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbt/zinc/labels{/name}","releases_url":"https://api.github.com/repos/sbt/zinc/releases{/id}","deployments_url":"https://api.github.com/repos/sbt/zinc/deployments","created_at":"2015-08-04T21:32:58Z","updated_at":"2017-07-09T20:36:46Z","pushed_at":"2017-07-10T19:09:29Z","git_url":"git://github.com/sbt/zinc.git","ssh_url":"[email protected]:sbt/zinc.git","clone_url":"https://github.com/sbt/zinc.git","svn_url":"https://github.com/sbt/zinc","homepage":"","size":10445,"stargazers_count":79,"watchers_count":79,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":68,"forks":37,"open_issues":68,"watchers":79,"default_branch":"1.0"}},"_links":{"self":{"href":"https://api.github.com/repos/sbt/zinc/pulls/351"},"html":{"href":"https://github.com/sbt/zinc/pull/351"},"issue":{"href":"https://api.github.com/repos/sbt/zinc/issues/351"},"comments":{"href":"https://api.github.com/repos/sbt/zinc/issues/351/comments"},"review_comments":{"href":"https://api.github.com/repos/sbt/zinc/pulls/351/comments"},"review_comment":{"href":"https://api.github.com/repos/sbt/zinc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sbt/zinc/pulls/351/commits"},"statuses":{"href":"https://api.github.com/repos/sbt/zinc/statuses/f825fc7b7a8b5f12f19576e66ced9ac83df2d38a"}}}} | {
"id": 40210247,
"name": "sbt/zinc",
"url": "https://api.github.com/repos/sbt/zinc"
} | {
"id": 2462974,
"login": "jvican",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2462974?",
"url": "https://api.github.com/users/jvican"
} | {
"id": 1158012,
"login": "sbt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1158012?",
"url": "https://api.github.com/orgs/sbt"
} | 2017-07-10T21:02:38 | 6227563512 | {"actor":{"display_login":"jvican"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/w3c/csswg-test/pulls/comments/104862053","pull_request_review_id":25715206,"id":104862053,"diff_hunk":"@@ -0,0 +1,15 @@\n+<!DOCTYPE html>\n+<title>CSS Box Alignment: place-content shorthand - single values specified</title>\n+<link rel=\"author\" title=\"Javier Fernandez\" href=\"mailto:[email protected]\" />\n+<link rel=\"help\" href=\"http://www.w3.org/TR/css3-align/#propdef-place-content\" />\n+<meta name=\"assert\" content=\"Check that setting a single value to place-content expands to such value set in both 'align-content' and 'justify-content'.\" />\n+<script src=\"/resources/testharness.js\"></script>\n+<script src=\"/resources/testharnessreport.js\"></script>\n+<script src=\"/css-align-3/resources/alignment-parsing-utils.js\"></script>\n+<div id=\"log\"></div>\n+<script>\n+ var values = [\"normal\"].concat(contentPositionValues, distributionValues, baselineValues);\n+ values.forEach(function(value) {\n+ test(function() { checkPlaceContent(value, \"\") }, \"Checking place-content: \" + value);\n+ });","path":"css-align-3/content-distribution/place-content-shorthand-001.html","position":14,"original_position":14,"commit_id":"dad485fefc297980b98ac3995d5918b975f65d25","original_commit_id":"dad485fefc297980b98ac3995d5918b975f65d25","user":{"login":"mrego","id":11602,"avatar_url":"https://avatars2.githubusercontent.com/u/11602?v=3","gravatar_id":"","url":"https://api.github.com/users/mrego","html_url":"https://github.com/mrego","followers_url":"https://api.github.com/users/mrego/followers","following_url":"https://api.github.com/users/mrego/following{/other_user}","gists_url":"https://api.github.com/users/mrego/gists{/gist_id}","starred_url":"https://api.github.com/users/mrego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrego/subscriptions","organizations_url":"https://api.github.com/users/mrego/orgs","repos_url":"https://api.github.com/users/mrego/repos","events_url":"https://api.github.com/users/mrego/events{/privacy}","received_events_url":"https://api.github.com/users/mrego/received_events","type":"User","site_admin":false},"body":"Nit: Quite long initial indentation compared to other tests.","created_at":"2017-03-08T08:00:00Z","updated_at":"2017-03-08T08:01:28Z","html_url":"https://github.com/w3c/csswg-test/pull/1228#discussion_r104862053","pull_request_url":"https://api.github.com/repos/w3c/csswg-test/pulls/1228","_links":{"self":{"href":"https://api.github.com/repos/w3c/csswg-test/pulls/comments/104862053"},"html":{"href":"https://github.com/w3c/csswg-test/pull/1228#discussion_r104862053"},"pull_request":{"href":"https://api.github.com/repos/w3c/csswg-test/pulls/1228"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/csswg-test/pulls/1228","id":109001411,"html_url":"https://github.com/w3c/csswg-test/pull/1228","diff_url":"https://github.com/w3c/csswg-test/pull/1228.diff","patch_url":"https://github.com/w3c/csswg-test/pull/1228.patch","issue_url":"https://api.github.com/repos/w3c/csswg-test/issues/1228","number":1228,"state":"open","locked":false,"title":"[css-align] Added tests to check the 'place-content' shorthand.","user":{"login":"javifernandez","id":2230241,"avatar_url":"https://avatars2.githubusercontent.com/u/2230241?v=3","gravatar_id":"","url":"https://api.github.com/users/javifernandez","html_url":"https://github.com/javifernandez","followers_url":"https://api.github.com/users/javifernandez/followers","following_url":"https://api.github.com/users/javifernandez/following{/other_user}","gists_url":"https://api.github.com/users/javifernandez/gists{/gist_id}","starred_url":"https://api.github.com/users/javifernandez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javifernandez/subscriptions","organizations_url":"https://api.github.com/users/javifernandez/orgs","repos_url":"https://api.github.com/users/javifernandez/repos","events_url":"https://api.github.com/users/javifernandez/events{/privacy}","received_events_url":"https://api.github.com/users/javifernandez/received_events","type":"User","site_admin":false},"body":"Added several tests to verify that the 'place-content' shorthand is parsed correctly and it sets the corresponding longhand's values.\r\n\r\nPlease @mrego and @svillar could you take a look ?\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/w3c/csswg-test/1228)\n<!-- Reviewable:end -->\n","created_at":"2017-03-03T15:59:35Z","updated_at":"2017-03-08T08:01:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21813a8977b585737f6dde0e54835cb532d1fe36","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/csswg-test/pulls/1228/commits","review_comments_url":"https://api.github.com/repos/w3c/csswg-test/pulls/1228/comments","review_comment_url":"https://api.github.com/repos/w3c/csswg-test/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/csswg-test/issues/1228/comments","statuses_url":"https://api.github.com/repos/w3c/csswg-test/statuses/dad485fefc297980b98ac3995d5918b975f65d25","head":{"label":"javifernandez:place-content-tests","ref":"place-content-tests","sha":"dad485fefc297980b98ac3995d5918b975f65d25","user":{"login":"javifernandez","id":2230241,"avatar_url":"https://avatars2.githubusercontent.com/u/2230241?v=3","gravatar_id":"","url":"https://api.github.com/users/javifernandez","html_url":"https://github.com/javifernandez","followers_url":"https://api.github.com/users/javifernandez/followers","following_url":"https://api.github.com/users/javifernandez/following{/other_user}","gists_url":"https://api.github.com/users/javifernandez/gists{/gist_id}","starred_url":"https://api.github.com/users/javifernandez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javifernandez/subscriptions","organizations_url":"https://api.github.com/users/javifernandez/orgs","repos_url":"https://api.github.com/users/javifernandez/repos","events_url":"https://api.github.com/users/javifernandez/events{/privacy}","received_events_url":"https://api.github.com/users/javifernandez/received_events","type":"User","site_admin":false},"repo":{"id":83805292,"name":"csswg-test","full_name":"javifernandez/csswg-test","owner":{"login":"javifernandez","id":2230241,"avatar_url":"https://avatars2.githubusercontent.com/u/2230241?v=3","gravatar_id":"","url":"https://api.github.com/users/javifernandez","html_url":"https://github.com/javifernandez","followers_url":"https://api.github.com/users/javifernandez/followers","following_url":"https://api.github.com/users/javifernandez/following{/other_user}","gists_url":"https://api.github.com/users/javifernandez/gists{/gist_id}","starred_url":"https://api.github.com/users/javifernandez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javifernandez/subscriptions","organizations_url":"https://api.github.com/users/javifernandez/orgs","repos_url":"https://api.github.com/users/javifernandez/repos","events_url":"https://api.github.com/users/javifernandez/events{/privacy}","received_events_url":"https://api.github.com/users/javifernandez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/javifernandez/csswg-test","description":"CSS WG test repository (mirrored at https://hg.csswg.org/test/)","fork":true,"url":"https://api.github.com/repos/javifernandez/csswg-test","forks_url":"https://api.github.com/repos/javifernandez/csswg-test/forks","keys_url":"https://api.github.com/repos/javifernandez/csswg-test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javifernandez/csswg-test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javifernandez/csswg-test/teams","hooks_url":"https://api.github.com/repos/javifernandez/csswg-test/hooks","issue_events_url":"https://api.github.com/repos/javifernandez/csswg-test/issues/events{/number}","events_url":"https://api.github.com/repos/javifernandez/csswg-test/events","assignees_url":"https://api.github.com/repos/javifernandez/csswg-test/assignees{/user}","branches_url":"https://api.github.com/repos/javifernandez/csswg-test/branches{/branch}","tags_url":"https://api.github.com/repos/javifernandez/csswg-test/tags","blobs_url":"https://api.github.com/repos/javifernandez/csswg-test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javifernandez/csswg-test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javifernandez/csswg-test/git/refs{/sha}","trees_url":"https://api.github.com/repos/javifernandez/csswg-test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javifernandez/csswg-test/statuses/{sha}","languages_url":"https://api.github.com/repos/javifernandez/csswg-test/languages","stargazers_url":"https://api.github.com/repos/javifernandez/csswg-test/stargazers","contributors_url":"https://api.github.com/repos/javifernandez/csswg-test/contributors","subscribers_url":"https://api.github.com/repos/javifernandez/csswg-test/subscribers","subscription_url":"https://api.github.com/repos/javifernandez/csswg-test/subscription","commits_url":"https://api.github.com/repos/javifernandez/csswg-test/commits{/sha}","git_commits_url":"https://api.github.com/repos/javifernandez/csswg-test/git/commits{/sha}","comments_url":"https://api.github.com/repos/javifernandez/csswg-test/comments{/number}","issue_comment_url":"https://api.github.com/repos/javifernandez/csswg-test/issues/comments{/number}","contents_url":"https://api.github.com/repos/javifernandez/csswg-test/contents/{+path}","compare_url":"https://api.github.com/repos/javifernandez/csswg-test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javifernandez/csswg-test/merges","archive_url":"https://api.github.com/repos/javifernandez/csswg-test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javifernandez/csswg-test/downloads","issues_url":"https://api.github.com/repos/javifernandez/csswg-test/issues{/number}","pulls_url":"https://api.github.com/repos/javifernandez/csswg-test/pulls{/number}","milestones_url":"https://api.github.com/repos/javifernandez/csswg-test/milestones{/number}","notifications_url":"https://api.github.com/repos/javifernandez/csswg-test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javifernandez/csswg-test/labels{/name}","releases_url":"https://api.github.com/repos/javifernandez/csswg-test/releases{/id}","deployments_url":"https://api.github.com/repos/javifernandez/csswg-test/deployments","created_at":"2017-03-03T14:15:50Z","updated_at":"2017-03-03T14:16:28Z","pushed_at":"2017-03-07T15:48:46Z","git_url":"git://github.com/javifernandez/csswg-test.git","ssh_url":"[email protected]:javifernandez/csswg-test.git","clone_url":"https://github.com/javifernandez/csswg-test.git","svn_url":"https://github.com/javifernandez/csswg-test","homepage":"","size":82700,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"7095dede98a4bbaa55123cdbdb77486cca7900fe","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars1.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":9252013,"name":"csswg-test","full_name":"w3c/csswg-test","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars1.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/csswg-test","description":"CSS WG test repository (mirrored at https://hg.csswg.org/test/)","fork":false,"url":"https://api.github.com/repos/w3c/csswg-test","forks_url":"https://api.github.com/repos/w3c/csswg-test/forks","keys_url":"https://api.github.com/repos/w3c/csswg-test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/csswg-test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/csswg-test/teams","hooks_url":"https://api.github.com/repos/w3c/csswg-test/hooks","issue_events_url":"https://api.github.com/repos/w3c/csswg-test/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/csswg-test/events","assignees_url":"https://api.github.com/repos/w3c/csswg-test/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/csswg-test/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/csswg-test/tags","blobs_url":"https://api.github.com/repos/w3c/csswg-test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/csswg-test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/csswg-test/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/csswg-test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/csswg-test/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/csswg-test/languages","stargazers_url":"https://api.github.com/repos/w3c/csswg-test/stargazers","contributors_url":"https://api.github.com/repos/w3c/csswg-test/contributors","subscribers_url":"https://api.github.com/repos/w3c/csswg-test/subscribers","subscription_url":"https://api.github.com/repos/w3c/csswg-test/subscription","commits_url":"https://api.github.com/repos/w3c/csswg-test/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/csswg-test/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/csswg-test/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/csswg-test/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/csswg-test/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/csswg-test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/csswg-test/merges","archive_url":"https://api.github.com/repos/w3c/csswg-test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/csswg-test/downloads","issues_url":"https://api.github.com/repos/w3c/csswg-test/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/csswg-test/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/csswg-test/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/csswg-test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/csswg-test/labels{/name}","releases_url":"https://api.github.com/repos/w3c/csswg-test/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/csswg-test/deployments","created_at":"2013-04-05T22:33:09Z","updated_at":"2017-03-04T05:02:03Z","pushed_at":"2017-03-07T15:48:59Z","git_url":"git://github.com/w3c/csswg-test.git","ssh_url":"[email protected]:w3c/csswg-test.git","clone_url":"https://github.com/w3c/csswg-test.git","svn_url":"https://github.com/w3c/csswg-test","homepage":"","size":85357,"stargazers_count":112,"watchers_count":112,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":369,"mirror_url":null,"open_issues_count":254,"forks":369,"open_issues":254,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/csswg-test/pulls/1228"},"html":{"href":"https://github.com/w3c/csswg-test/pull/1228"},"issue":{"href":"https://api.github.com/repos/w3c/csswg-test/issues/1228"},"comments":{"href":"https://api.github.com/repos/w3c/csswg-test/issues/1228/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/csswg-test/pulls/1228/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/csswg-test/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/csswg-test/pulls/1228/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/csswg-test/statuses/dad485fefc297980b98ac3995d5918b975f65d25"}}}} | {
"id": 9252013,
"name": "w3c/csswg-test",
"url": "https://api.github.com/repos/w3c/csswg-test"
} | {
"id": 11602,
"login": "mrego",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11602?",
"url": "https://api.github.com/users/mrego"
} | {
"id": 379216,
"login": "w3c",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/379216?",
"url": "https://api.github.com/orgs/w3c"
} | 2017-03-08T08:00:00 | 5453439071 | {"actor":{"display_login":"mrego"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/xwp/wp-core-media-widgets/pulls/comments/109715291","pull_request_review_id":30835479,"id":109715291,"diff_hunk":"@@ -106,7 +106,7 @@\n \t\t\t\t\timage_title: '',\n \t\t\t\t\tlink_classes: '',\n \t\t\t\t\tlink_rel: '',\n-\t\t\t\t\tlink_url: attachment.linkUrl ? attachment.linkUrl : attachment.link,\n+\t\t\t\t\tlink_url: attachment.linkUrl,","path":"wp-admin/js/widgets/media-image-widget.js","position":null,"original_position":5,"commit_id":"4e22228fd319c211126c59b97fcdbb618ee7091f","original_commit_id":"a3b5a690cee41f1f12c443c7aaa927de3bd03baf","user":{"login":"obenland","id":1398304,"avatar_url":"https://avatars0.githubusercontent.com/u/1398304?v=3","gravatar_id":"","url":"https://api.github.com/users/obenland","html_url":"https://github.com/obenland","followers_url":"https://api.github.com/users/obenland/followers","following_url":"https://api.github.com/users/obenland/following{/other_user}","gists_url":"https://api.github.com/users/obenland/gists{/gist_id}","starred_url":"https://api.github.com/users/obenland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obenland/subscriptions","organizations_url":"https://api.github.com/users/obenland/orgs","repos_url":"https://api.github.com/users/obenland/repos","events_url":"https://api.github.com/users/obenland/events{/privacy}","received_events_url":"https://api.github.com/users/obenland/received_events","type":"User","site_admin":false},"body":"I currently have \r\n```javascript\r\nif ( 'custom' === attachment.link ) {\r\n\tlinkUrl = attachment.linkUrl;\r\n} else if ( 'file' === attachment.link ) {\r\n\tlinkUrl = attachment.url;\r\n}\r\n```\r\non my sandbox.","created_at":"2017-04-04T16:42:17Z","updated_at":"2017-04-04T16:42:17Z","html_url":"https://github.com/xwp/wp-core-media-widgets/pull/46#discussion_r109715291","pull_request_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/xwp/wp-core-media-widgets/pulls/comments/109715291"},"html":{"href":"https://github.com/xwp/wp-core-media-widgets/pull/46#discussion_r109715291"},"pull_request":{"href":"https://api.github.com/repos/xwp/wp-core-media-widgets/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/xwp/wp-core-media-widgets/pulls/46","id":112612065,"html_url":"https://github.com/xwp/wp-core-media-widgets/pull/46","diff_url":"https://github.com/xwp/wp-core-media-widgets/pull/46.diff","patch_url":"https://github.com/xwp/wp-core-media-widgets/pull/46.patch","issue_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/issues/46","number":46,"state":"open","locked":false,"title":"Enable embedding images by URL","user":{"login":"adamsilverstein","id":2676022,"avatar_url":"https://avatars3.githubusercontent.com/u/2676022?v=3","gravatar_id":"","url":"https://api.github.com/users/adamsilverstein","html_url":"https://github.com/adamsilverstein","followers_url":"https://api.github.com/users/adamsilverstein/followers","following_url":"https://api.github.com/users/adamsilverstein/following{/other_user}","gists_url":"https://api.github.com/users/adamsilverstein/gists{/gist_id}","starred_url":"https://api.github.com/users/adamsilverstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamsilverstein/subscriptions","organizations_url":"https://api.github.com/users/adamsilverstein/orgs","repos_url":"https://api.github.com/users/adamsilverstein/repos","events_url":"https://api.github.com/users/adamsilverstein/events{/privacy}","received_events_url":"https://api.github.com/users/adamsilverstein/received_events","type":"User","site_admin":false},"body":"Addresses https://github.com/xwp/wp-core-media-widgets/issues/9\r\n\r\n* Add a custom Post modal state to handle our specific needs (select/embed)\r\n* Modify the insert button language temporarily - cleanest approach for insert button. I tried overriding the setup methods and that was messier. \r\n* restore standard post state and language on close\r\n* handle embed data on close\r\n* Extend the template to handle embedded images\r\n\r\nQ: Not sure about the edit dialog - or the edit details sidebar in the media select mode: do we really want all of these attributes editable? Maybe the widget itself has a title and description and the media part is only image selection? I'm confused about how these would be used - related: https://core.trac.wordpress.org/ticket/32417#comment:132\r\n\r\n","created_at":"2017-03-26T02:52:40Z","updated_at":"2017-04-04T16:42:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f20647afd4466bf3276a3d3e45c6a537fa898fb9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/pulls/46/commits","review_comments_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/pulls/46/comments","review_comment_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/issues/46/comments","statuses_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/statuses/4e22228fd319c211126c59b97fcdbb618ee7091f","head":{"label":"xwp:issue-9","ref":"issue-9","sha":"4e22228fd319c211126c59b97fcdbb618ee7091f","user":{"login":"xwp","id":9003139,"avatar_url":"https://avatars1.githubusercontent.com/u/9003139?v=3","gravatar_id":"","url":"https://api.github.com/users/xwp","html_url":"https://github.com/xwp","followers_url":"https://api.github.com/users/xwp/followers","following_url":"https://api.github.com/users/xwp/following{/other_user}","gists_url":"https://api.github.com/users/xwp/gists{/gist_id}","starred_url":"https://api.github.com/users/xwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwp/subscriptions","organizations_url":"https://api.github.com/users/xwp/orgs","repos_url":"https://api.github.com/users/xwp/repos","events_url":"https://api.github.com/users/xwp/events{/privacy}","received_events_url":"https://api.github.com/users/xwp/received_events","type":"Organization","site_admin":false},"repo":{"id":83485730,"name":"wp-core-media-widgets","full_name":"xwp/wp-core-media-widgets","owner":{"login":"xwp","id":9003139,"avatar_url":"https://avatars1.githubusercontent.com/u/9003139?v=3","gravatar_id":"","url":"https://api.github.com/users/xwp","html_url":"https://github.com/xwp","followers_url":"https://api.github.com/users/xwp/followers","following_url":"https://api.github.com/users/xwp/following{/other_user}","gists_url":"https://api.github.com/users/xwp/gists{/gist_id}","starred_url":"https://api.github.com/users/xwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwp/subscriptions","organizations_url":"https://api.github.com/users/xwp/orgs","repos_url":"https://api.github.com/users/xwp/repos","events_url":"https://api.github.com/users/xwp/events{/privacy}","received_events_url":"https://api.github.com/users/xwp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xwp/wp-core-media-widgets","description":"Feature plugin for development of new core media widgets for image, video, and audio (and others)","fork":false,"url":"https://api.github.com/repos/xwp/wp-core-media-widgets","forks_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/forks","keys_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/teams","hooks_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/hooks","issue_events_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/issues/events{/number}","events_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/events","assignees_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/assignees{/user}","branches_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/branches{/branch}","tags_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/tags","blobs_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/languages","stargazers_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/stargazers","contributors_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/contributors","subscribers_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/subscribers","subscription_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/subscription","commits_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/contents/{+path}","compare_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/merges","archive_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/downloads","issues_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/issues{/number}","pulls_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/labels{/name}","releases_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/releases{/id}","deployments_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/deployments","created_at":"2017-02-28T22:28:52Z","updated_at":"2017-04-04T10:33:26Z","pushed_at":"2017-04-04T13:23:34Z","git_url":"git://github.com/xwp/wp-core-media-widgets.git","ssh_url":"[email protected]:xwp/wp-core-media-widgets.git","clone_url":"https://github.com/xwp/wp-core-media-widgets.git","svn_url":"https://github.com/xwp/wp-core-media-widgets","homepage":"https://wordpress.org/plugins/wp-core-media-widgets/","size":261,"stargazers_count":19,"watchers_count":19,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":10,"forks":5,"open_issues":10,"watchers":19,"default_branch":"master"}},"base":{"label":"xwp:master","ref":"master","sha":"38664a52f48350f0947ade7560e16846692c5ec6","user":{"login":"xwp","id":9003139,"avatar_url":"https://avatars1.githubusercontent.com/u/9003139?v=3","gravatar_id":"","url":"https://api.github.com/users/xwp","html_url":"https://github.com/xwp","followers_url":"https://api.github.com/users/xwp/followers","following_url":"https://api.github.com/users/xwp/following{/other_user}","gists_url":"https://api.github.com/users/xwp/gists{/gist_id}","starred_url":"https://api.github.com/users/xwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwp/subscriptions","organizations_url":"https://api.github.com/users/xwp/orgs","repos_url":"https://api.github.com/users/xwp/repos","events_url":"https://api.github.com/users/xwp/events{/privacy}","received_events_url":"https://api.github.com/users/xwp/received_events","type":"Organization","site_admin":false},"repo":{"id":83485730,"name":"wp-core-media-widgets","full_name":"xwp/wp-core-media-widgets","owner":{"login":"xwp","id":9003139,"avatar_url":"https://avatars1.githubusercontent.com/u/9003139?v=3","gravatar_id":"","url":"https://api.github.com/users/xwp","html_url":"https://github.com/xwp","followers_url":"https://api.github.com/users/xwp/followers","following_url":"https://api.github.com/users/xwp/following{/other_user}","gists_url":"https://api.github.com/users/xwp/gists{/gist_id}","starred_url":"https://api.github.com/users/xwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwp/subscriptions","organizations_url":"https://api.github.com/users/xwp/orgs","repos_url":"https://api.github.com/users/xwp/repos","events_url":"https://api.github.com/users/xwp/events{/privacy}","received_events_url":"https://api.github.com/users/xwp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xwp/wp-core-media-widgets","description":"Feature plugin for development of new core media widgets for image, video, and audio (and others)","fork":false,"url":"https://api.github.com/repos/xwp/wp-core-media-widgets","forks_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/forks","keys_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/teams","hooks_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/hooks","issue_events_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/issues/events{/number}","events_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/events","assignees_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/assignees{/user}","branches_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/branches{/branch}","tags_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/tags","blobs_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/languages","stargazers_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/stargazers","contributors_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/contributors","subscribers_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/subscribers","subscription_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/subscription","commits_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/contents/{+path}","compare_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/merges","archive_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/downloads","issues_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/issues{/number}","pulls_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/labels{/name}","releases_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/releases{/id}","deployments_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/deployments","created_at":"2017-02-28T22:28:52Z","updated_at":"2017-04-04T10:33:26Z","pushed_at":"2017-04-04T13:23:34Z","git_url":"git://github.com/xwp/wp-core-media-widgets.git","ssh_url":"[email protected]:xwp/wp-core-media-widgets.git","clone_url":"https://github.com/xwp/wp-core-media-widgets.git","svn_url":"https://github.com/xwp/wp-core-media-widgets","homepage":"https://wordpress.org/plugins/wp-core-media-widgets/","size":261,"stargazers_count":19,"watchers_count":19,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":10,"forks":5,"open_issues":10,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xwp/wp-core-media-widgets/pulls/46"},"html":{"href":"https://github.com/xwp/wp-core-media-widgets/pull/46"},"issue":{"href":"https://api.github.com/repos/xwp/wp-core-media-widgets/issues/46"},"comments":{"href":"https://api.github.com/repos/xwp/wp-core-media-widgets/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/xwp/wp-core-media-widgets/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/xwp/wp-core-media-widgets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xwp/wp-core-media-widgets/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/xwp/wp-core-media-widgets/statuses/4e22228fd319c211126c59b97fcdbb618ee7091f"}}}} | {
"id": 83485730,
"name": "xwp/wp-core-media-widgets",
"url": "https://api.github.com/repos/xwp/wp-core-media-widgets"
} | {
"id": 1398304,
"login": "obenland",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1398304?",
"url": "https://api.github.com/users/obenland"
} | {
"id": 9003139,
"login": "xwp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9003139?",
"url": "https://api.github.com/orgs/xwp"
} | 2017-04-04T16:42:17 | 5624289865 | {"actor":{"display_login":"obenland"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Appr/Appr/pulls/comments/154849967","pull_request_review_id":81073085,"id":154849967,"diff_hunk":"@@ -0,0 +1,4 @@\n+UPDATE project_schema\n+ SET project_id = $2, table_name_id = $3, column_name = $4, schema_type_id = $5, size_data = $6, is_primary_key = $7, is_foreign_key = $8, is_serial = $9, is_not_null = $10, is_unique = $11","path":"db/update_project_schema.sql","position":2,"original_position":2,"commit_id":"9071a936074732049f7f606edb55e161459adeff","original_commit_id":"9071a936074732049f7f606edb55e161459adeff","user":{"login":"mjburtenshaw","id":31086089,"avatar_url":"https://avatars3.githubusercontent.com/u/31086089?v=4","gravatar_id":"","url":"https://api.github.com/users/mjburtenshaw","html_url":"https://github.com/mjburtenshaw","followers_url":"https://api.github.com/users/mjburtenshaw/followers","following_url":"https://api.github.com/users/mjburtenshaw/following{/other_user}","gists_url":"https://api.github.com/users/mjburtenshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/mjburtenshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjburtenshaw/subscriptions","organizations_url":"https://api.github.com/users/mjburtenshaw/orgs","repos_url":"https://api.github.com/users/mjburtenshaw/repos","events_url":"https://api.github.com/users/mjburtenshaw/events{/privacy}","received_events_url":"https://api.github.com/users/mjburtenshaw/received_events","type":"User","site_admin":false},"body":"I don't believe we need to reset the project_id, that is static once the row is initially created","created_at":"2017-12-05T05:27:24Z","updated_at":"2017-12-05T05:27:53Z","html_url":"https://github.com/Appr/Appr/pull/39#discussion_r154849967","pull_request_url":"https://api.github.com/repos/Appr/Appr/pulls/39","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Appr/Appr/pulls/comments/154849967"},"html":{"href":"https://github.com/Appr/Appr/pull/39#discussion_r154849967"},"pull_request":{"href":"https://api.github.com/repos/Appr/Appr/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/Appr/Appr/pulls/39","id":156030855,"html_url":"https://github.com/Appr/Appr/pull/39","diff_url":"https://github.com/Appr/Appr/pull/39.diff","patch_url":"https://github.com/Appr/Appr/pull/39.patch","issue_url":"https://api.github.com/repos/Appr/Appr/issues/39","number":39,"state":"open","locked":false,"title":"Added multiple sql files","user":{"login":"gobornG","id":29578988,"avatar_url":"https://avatars1.githubusercontent.com/u/29578988?v=4","gravatar_id":"","url":"https://api.github.com/users/gobornG","html_url":"https://github.com/gobornG","followers_url":"https://api.github.com/users/gobornG/followers","following_url":"https://api.github.com/users/gobornG/following{/other_user}","gists_url":"https://api.github.com/users/gobornG/gists{/gist_id}","starred_url":"https://api.github.com/users/gobornG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gobornG/subscriptions","organizations_url":"https://api.github.com/users/gobornG/orgs","repos_url":"https://api.github.com/users/gobornG/repos","events_url":"https://api.github.com/users/gobornG/events{/privacy}","received_events_url":"https://api.github.com/users/gobornG/received_events","type":"User","site_admin":false},"body":"created multiple sql files.","created_at":"2017-12-02T20:53:09Z","updated_at":"2017-12-05T05:27:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fed85cab9be8da0e0c344a5b8d9f82bf372a40c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Appr/Appr/pulls/39/commits","review_comments_url":"https://api.github.com/repos/Appr/Appr/pulls/39/comments","review_comment_url":"https://api.github.com/repos/Appr/Appr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Appr/Appr/issues/39/comments","statuses_url":"https://api.github.com/repos/Appr/Appr/statuses/9071a936074732049f7f606edb55e161459adeff","head":{"label":"gobornG:gto-dev","ref":"gto-dev","sha":"9071a936074732049f7f606edb55e161459adeff","user":{"login":"gobornG","id":29578988,"avatar_url":"https://avatars1.githubusercontent.com/u/29578988?v=4","gravatar_id":"","url":"https://api.github.com/users/gobornG","html_url":"https://github.com/gobornG","followers_url":"https://api.github.com/users/gobornG/followers","following_url":"https://api.github.com/users/gobornG/following{/other_user}","gists_url":"https://api.github.com/users/gobornG/gists{/gist_id}","starred_url":"https://api.github.com/users/gobornG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gobornG/subscriptions","organizations_url":"https://api.github.com/users/gobornG/orgs","repos_url":"https://api.github.com/users/gobornG/repos","events_url":"https://api.github.com/users/gobornG/events{/privacy}","received_events_url":"https://api.github.com/users/gobornG/received_events","type":"User","site_admin":false},"repo":{"id":111149359,"name":"Appr","full_name":"gobornG/Appr","owner":{"login":"gobornG","id":29578988,"avatar_url":"https://avatars1.githubusercontent.com/u/29578988?v=4","gravatar_id":"","url":"https://api.github.com/users/gobornG","html_url":"https://github.com/gobornG","followers_url":"https://api.github.com/users/gobornG/followers","following_url":"https://api.github.com/users/gobornG/following{/other_user}","gists_url":"https://api.github.com/users/gobornG/gists{/gist_id}","starred_url":"https://api.github.com/users/gobornG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gobornG/subscriptions","organizations_url":"https://api.github.com/users/gobornG/orgs","repos_url":"https://api.github.com/users/gobornG/repos","events_url":"https://api.github.com/users/gobornG/events{/privacy}","received_events_url":"https://api.github.com/users/gobornG/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gobornG/Appr","description":"Master Appr Repo","fork":true,"url":"https://api.github.com/repos/gobornG/Appr","forks_url":"https://api.github.com/repos/gobornG/Appr/forks","keys_url":"https://api.github.com/repos/gobornG/Appr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gobornG/Appr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gobornG/Appr/teams","hooks_url":"https://api.github.com/repos/gobornG/Appr/hooks","issue_events_url":"https://api.github.com/repos/gobornG/Appr/issues/events{/number}","events_url":"https://api.github.com/repos/gobornG/Appr/events","assignees_url":"https://api.github.com/repos/gobornG/Appr/assignees{/user}","branches_url":"https://api.github.com/repos/gobornG/Appr/branches{/branch}","tags_url":"https://api.github.com/repos/gobornG/Appr/tags","blobs_url":"https://api.github.com/repos/gobornG/Appr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gobornG/Appr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gobornG/Appr/git/refs{/sha}","trees_url":"https://api.github.com/repos/gobornG/Appr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gobornG/Appr/statuses/{sha}","languages_url":"https://api.github.com/repos/gobornG/Appr/languages","stargazers_url":"https://api.github.com/repos/gobornG/Appr/stargazers","contributors_url":"https://api.github.com/repos/gobornG/Appr/contributors","subscribers_url":"https://api.github.com/repos/gobornG/Appr/subscribers","subscription_url":"https://api.github.com/repos/gobornG/Appr/subscription","commits_url":"https://api.github.com/repos/gobornG/Appr/commits{/sha}","git_commits_url":"https://api.github.com/repos/gobornG/Appr/git/commits{/sha}","comments_url":"https://api.github.com/repos/gobornG/Appr/comments{/number}","issue_comment_url":"https://api.github.com/repos/gobornG/Appr/issues/comments{/number}","contents_url":"https://api.github.com/repos/gobornG/Appr/contents/{+path}","compare_url":"https://api.github.com/repos/gobornG/Appr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gobornG/Appr/merges","archive_url":"https://api.github.com/repos/gobornG/Appr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gobornG/Appr/downloads","issues_url":"https://api.github.com/repos/gobornG/Appr/issues{/number}","pulls_url":"https://api.github.com/repos/gobornG/Appr/pulls{/number}","milestones_url":"https://api.github.com/repos/gobornG/Appr/milestones{/number}","notifications_url":"https://api.github.com/repos/gobornG/Appr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gobornG/Appr/labels{/name}","releases_url":"https://api.github.com/repos/gobornG/Appr/releases{/id}","deployments_url":"https://api.github.com/repos/gobornG/Appr/deployments","created_at":"2017-11-17T20:49:50Z","updated_at":"2017-11-17T20:49:52Z","pushed_at":"2017-12-02T20:51:59Z","git_url":"git://github.com/gobornG/Appr.git","ssh_url":"[email protected]:gobornG/Appr.git","clone_url":"https://github.com/gobornG/Appr.git","svn_url":"https://github.com/gobornG/Appr","homepage":null,"size":29717,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Appr:master","ref":"master","sha":"e2ad71797ba48e4cfffd174736417a655ad1ad5a","user":{"login":"Appr","id":33677860,"avatar_url":"https://avatars0.githubusercontent.com/u/33677860?v=4","gravatar_id":"","url":"https://api.github.com/users/Appr","html_url":"https://github.com/Appr","followers_url":"https://api.github.com/users/Appr/followers","following_url":"https://api.github.com/users/Appr/following{/other_user}","gists_url":"https://api.github.com/users/Appr/gists{/gist_id}","starred_url":"https://api.github.com/users/Appr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Appr/subscriptions","organizations_url":"https://api.github.com/users/Appr/orgs","repos_url":"https://api.github.com/users/Appr/repos","events_url":"https://api.github.com/users/Appr/events{/privacy}","received_events_url":"https://api.github.com/users/Appr/received_events","type":"Organization","site_admin":false},"repo":{"id":110779244,"name":"Appr","full_name":"Appr/Appr","owner":{"login":"Appr","id":33677860,"avatar_url":"https://avatars0.githubusercontent.com/u/33677860?v=4","gravatar_id":"","url":"https://api.github.com/users/Appr","html_url":"https://github.com/Appr","followers_url":"https://api.github.com/users/Appr/followers","following_url":"https://api.github.com/users/Appr/following{/other_user}","gists_url":"https://api.github.com/users/Appr/gists{/gist_id}","starred_url":"https://api.github.com/users/Appr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Appr/subscriptions","organizations_url":"https://api.github.com/users/Appr/orgs","repos_url":"https://api.github.com/users/Appr/repos","events_url":"https://api.github.com/users/Appr/events{/privacy}","received_events_url":"https://api.github.com/users/Appr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Appr/Appr","description":"Master Appr Repo","fork":false,"url":"https://api.github.com/repos/Appr/Appr","forks_url":"https://api.github.com/repos/Appr/Appr/forks","keys_url":"https://api.github.com/repos/Appr/Appr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Appr/Appr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Appr/Appr/teams","hooks_url":"https://api.github.com/repos/Appr/Appr/hooks","issue_events_url":"https://api.github.com/repos/Appr/Appr/issues/events{/number}","events_url":"https://api.github.com/repos/Appr/Appr/events","assignees_url":"https://api.github.com/repos/Appr/Appr/assignees{/user}","branches_url":"https://api.github.com/repos/Appr/Appr/branches{/branch}","tags_url":"https://api.github.com/repos/Appr/Appr/tags","blobs_url":"https://api.github.com/repos/Appr/Appr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Appr/Appr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Appr/Appr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Appr/Appr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Appr/Appr/statuses/{sha}","languages_url":"https://api.github.com/repos/Appr/Appr/languages","stargazers_url":"https://api.github.com/repos/Appr/Appr/stargazers","contributors_url":"https://api.github.com/repos/Appr/Appr/contributors","subscribers_url":"https://api.github.com/repos/Appr/Appr/subscribers","subscription_url":"https://api.github.com/repos/Appr/Appr/subscription","commits_url":"https://api.github.com/repos/Appr/Appr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Appr/Appr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Appr/Appr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Appr/Appr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Appr/Appr/contents/{+path}","compare_url":"https://api.github.com/repos/Appr/Appr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Appr/Appr/merges","archive_url":"https://api.github.com/repos/Appr/Appr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Appr/Appr/downloads","issues_url":"https://api.github.com/repos/Appr/Appr/issues{/number}","pulls_url":"https://api.github.com/repos/Appr/Appr/pulls{/number}","milestones_url":"https://api.github.com/repos/Appr/Appr/milestones{/number}","notifications_url":"https://api.github.com/repos/Appr/Appr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Appr/Appr/labels{/name}","releases_url":"https://api.github.com/repos/Appr/Appr/releases{/id}","deployments_url":"https://api.github.com/repos/Appr/Appr/deployments","created_at":"2017-11-15T03:33:22Z","updated_at":"2017-11-18T20:48:50Z","pushed_at":"2017-12-05T05:08:32Z","git_url":"git://github.com/Appr/Appr.git","ssh_url":"[email protected]:Appr/Appr.git","clone_url":"https://github.com/Appr/Appr.git","svn_url":"https://github.com/Appr/Appr","homepage":null,"size":29711,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":5,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Appr/Appr/pulls/39"},"html":{"href":"https://github.com/Appr/Appr/pull/39"},"issue":{"href":"https://api.github.com/repos/Appr/Appr/issues/39"},"comments":{"href":"https://api.github.com/repos/Appr/Appr/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/Appr/Appr/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/Appr/Appr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Appr/Appr/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/Appr/Appr/statuses/9071a936074732049f7f606edb55e161459adeff"}},"author_association":"CONTRIBUTOR"}} | {
"id": 110779244,
"name": "Appr/Appr",
"url": "https://api.github.com/repos/Appr/Appr"
} | {
"id": 31086089,
"login": "mjburtenshaw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31086089?",
"url": "https://api.github.com/users/mjburtenshaw"
} | {
"id": 33677860,
"login": "Appr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/33677860?",
"url": "https://api.github.com/orgs/Appr"
} | 2017-12-05T05:27:24 | 6943350345 | {"actor":{"display_login":"mjburtenshaw"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Esri/developer-support/pulls/comments/94629727","pull_request_review_id":15160382,"id":94629727,"diff_hunk":"@@ -0,0 +1,85 @@\n+#Add Attachments To FeatureService with JavaScript 4.2\n+\n+##About\n+FeatureServices can be configured to allow files to be attached to individual features in the service. In the 3.x JavaScript API methods to retrieve, add and delete attachments were provided as part of the FeatureLayer class. Additionally widgets such as the attachment and attribute inspector allowed attachments to be viewed and edited. In the 4.x API no widgets or methods have been provided to work with attachments at this time. However it is still possible to directly query and edit attachments using the ArcGIS REST API. This sample shows how to work with attachments within a 4.x application.\n+\n+\n+\n+[Live Sample](https://nhaney90.github.io/add-attachments-with-42/index.html)\n+\n+##Usage Notes\n+This sample allows the user to click on a feature in the map to view a popup. At the bottom of the popup is a button called \"Add Attachments\". Clicking this button allows attachments to be added using a file picker dialog. Attachments currently attached to the feature will be shown in the popup. These attachments can be downloaded or deleted by clicking the buttons beside them.\n+\n+##How It Works\n+When a new feature is shown in the popup a request is sent to get any attachments associated with that feature. This is a GET request made with jQuery.\n+```javascript\n+var url = feature.layer.url + \"/\" + feature.layer.layerId + \"/\" + feature.attributes.objectid;\n+$.get(url + \"/attachments?f=json\", function(data, status) {\n+\taddAttachmentsToPopup(data, status, url);\n+});\n+```\n+\n+Using a for loop the attachments returned by the above GET request are iterated and added to an HTML string. This string is then appended to the end of the popup's HTML. As the number of attachments is unknown this cannot be configured with a popup template and must be added programatically each time a new feature is loaded.\n+```javascript\n+var html = \"<div class='attachment-header'>Attachments:\";\n+for(var i = 0; i < json.attachmentInfos.length; i++) {\n+\thtml += \"<div class='attachment-item'><div class='attachment-name'>\" + json.attachmentInfos[i].name + \"</div><div class='download-attachment' value='\" + url + \"/attachments/\" + json.attachmentInfos[i].id + \"'></div><div class='delete-attachment' value='\" + url + \"/deleteAttachments?f=json&attachmentIds=\" + json.attachmentInfos[i].id + \"'></div></div>\";\n+}\n+html += \"</div>\";\n+view.popup.content.innerHTML += html;\n+```\n+\n+To download an attachment I use a bit of trick. First I create a hyperlink element. The reference of this hyperlink is the url of the attachment on the ArcGIS Server. The hyperlink is then appended to the body of the document. The hyperlink is unseen by the user. The \"click\" event of the hyperlink is then triggered causing the file to be downloaded. The link is then removed from the body and deleted.","path":"web-js/4.x/add-attachments-with-42/README.md","position":32,"original_position":32,"commit_id":"f18a1330a4fef260faf42cf56bf77929cf4a1629","original_commit_id":"f18a1330a4fef260faf42cf56bf77929cf4a1629","user":{"login":"jgravois","id":3011734,"avatar_url":"https://avatars.githubusercontent.com/u/3011734?v=3","gravatar_id":"","url":"https://api.github.com/users/jgravois","html_url":"https://github.com/jgravois","followers_url":"https://api.github.com/users/jgravois/followers","following_url":"https://api.github.com/users/jgravois/following{/other_user}","gists_url":"https://api.github.com/users/jgravois/gists{/gist_id}","starred_url":"https://api.github.com/users/jgravois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgravois/subscriptions","organizations_url":"https://api.github.com/users/jgravois/orgs","repos_url":"https://api.github.com/users/jgravois/repos","events_url":"https://api.github.com/users/jgravois/events{/privacy}","received_events_url":"https://api.github.com/users/jgravois/received_events","type":"User","site_admin":false},"body":"> To download an attachment I use a bit of trick.\r\n\r\nits a bit weird that you switch to first person tense here.","created_at":"2017-01-04T17:48:30Z","updated_at":"2017-01-04T17:51:21Z","html_url":"https://github.com/Esri/developer-support/pull/286#discussion_r94629727","pull_request_url":"https://api.github.com/repos/Esri/developer-support/pulls/286","_links":{"self":{"href":"https://api.github.com/repos/Esri/developer-support/pulls/comments/94629727"},"html":{"href":"https://github.com/Esri/developer-support/pull/286#discussion_r94629727"},"pull_request":{"href":"https://api.github.com/repos/Esri/developer-support/pulls/286"}}},"pull_request":{"url":"https://api.github.com/repos/Esri/developer-support/pulls/286","id":100129149,"html_url":"https://github.com/Esri/developer-support/pull/286","diff_url":"https://github.com/Esri/developer-support/pull/286.diff","patch_url":"https://github.com/Esri/developer-support/pull/286.patch","issue_url":"https://api.github.com/repos/Esri/developer-support/issues/286","number":286,"state":"open","locked":false,"title":"Add attachments to FeatureService using 4.x","user":{"login":"nhaney90","id":7852338,"avatar_url":"https://avatars.githubusercontent.com/u/7852338?v=3","gravatar_id":"","url":"https://api.github.com/users/nhaney90","html_url":"https://github.com/nhaney90","followers_url":"https://api.github.com/users/nhaney90/followers","following_url":"https://api.github.com/users/nhaney90/following{/other_user}","gists_url":"https://api.github.com/users/nhaney90/gists{/gist_id}","starred_url":"https://api.github.com/users/nhaney90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhaney90/subscriptions","organizations_url":"https://api.github.com/users/nhaney90/orgs","repos_url":"https://api.github.com/users/nhaney90/repos","events_url":"https://api.github.com/users/nhaney90/events{/privacy}","received_events_url":"https://api.github.com/users/nhaney90/received_events","type":"User","site_admin":false},"body":"Version 4.x of the JavaScript API does not currently offer any tools to work with attachments. However using JavaScript and the REST API we can recreate the look and functionality of the 3.x Attachment Editor.","created_at":"2017-01-04T15:02:08Z","updated_at":"2017-01-04T17:51:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91aaa58effc47531f687ad767c7a513691f963b0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Esri/developer-support/pulls/286/commits","review_comments_url":"https://api.github.com/repos/Esri/developer-support/pulls/286/comments","review_comment_url":"https://api.github.com/repos/Esri/developer-support/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Esri/developer-support/issues/286/comments","statuses_url":"https://api.github.com/repos/Esri/developer-support/statuses/f18a1330a4fef260faf42cf56bf77929cf4a1629","head":{"label":"nhaney90:master","ref":"master","sha":"f18a1330a4fef260faf42cf56bf77929cf4a1629","user":{"login":"nhaney90","id":7852338,"avatar_url":"https://avatars.githubusercontent.com/u/7852338?v=3","gravatar_id":"","url":"https://api.github.com/users/nhaney90","html_url":"https://github.com/nhaney90","followers_url":"https://api.github.com/users/nhaney90/followers","following_url":"https://api.github.com/users/nhaney90/following{/other_user}","gists_url":"https://api.github.com/users/nhaney90/gists{/gist_id}","starred_url":"https://api.github.com/users/nhaney90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhaney90/subscriptions","organizations_url":"https://api.github.com/users/nhaney90/orgs","repos_url":"https://api.github.com/users/nhaney90/repos","events_url":"https://api.github.com/users/nhaney90/events{/privacy}","received_events_url":"https://api.github.com/users/nhaney90/received_events","type":"User","site_admin":false},"repo":{"id":43373255,"name":"developer-support","full_name":"nhaney90/developer-support","owner":{"login":"nhaney90","id":7852338,"avatar_url":"https://avatars.githubusercontent.com/u/7852338?v=3","gravatar_id":"","url":"https://api.github.com/users/nhaney90","html_url":"https://github.com/nhaney90","followers_url":"https://api.github.com/users/nhaney90/followers","following_url":"https://api.github.com/users/nhaney90/following{/other_user}","gists_url":"https://api.github.com/users/nhaney90/gists{/gist_id}","starred_url":"https://api.github.com/users/nhaney90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhaney90/subscriptions","organizations_url":"https://api.github.com/users/nhaney90/orgs","repos_url":"https://api.github.com/users/nhaney90/repos","events_url":"https://api.github.com/users/nhaney90/events{/privacy}","received_events_url":"https://api.github.com/users/nhaney90/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nhaney90/developer-support","description":"Proof of concept developer code and samples to help be successful with all ArcGIS developer products (Python, NET, JavaScript, Android…). The repository is designed to be an exchange for sharing coding conventions and wisdom to developers at all skill levels. ","fork":true,"url":"https://api.github.com/repos/nhaney90/developer-support","forks_url":"https://api.github.com/repos/nhaney90/developer-support/forks","keys_url":"https://api.github.com/repos/nhaney90/developer-support/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhaney90/developer-support/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhaney90/developer-support/teams","hooks_url":"https://api.github.com/repos/nhaney90/developer-support/hooks","issue_events_url":"https://api.github.com/repos/nhaney90/developer-support/issues/events{/number}","events_url":"https://api.github.com/repos/nhaney90/developer-support/events","assignees_url":"https://api.github.com/repos/nhaney90/developer-support/assignees{/user}","branches_url":"https://api.github.com/repos/nhaney90/developer-support/branches{/branch}","tags_url":"https://api.github.com/repos/nhaney90/developer-support/tags","blobs_url":"https://api.github.com/repos/nhaney90/developer-support/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhaney90/developer-support/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhaney90/developer-support/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhaney90/developer-support/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhaney90/developer-support/statuses/{sha}","languages_url":"https://api.github.com/repos/nhaney90/developer-support/languages","stargazers_url":"https://api.github.com/repos/nhaney90/developer-support/stargazers","contributors_url":"https://api.github.com/repos/nhaney90/developer-support/contributors","subscribers_url":"https://api.github.com/repos/nhaney90/developer-support/subscribers","subscription_url":"https://api.github.com/repos/nhaney90/developer-support/subscription","commits_url":"https://api.github.com/repos/nhaney90/developer-support/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhaney90/developer-support/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhaney90/developer-support/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhaney90/developer-support/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhaney90/developer-support/contents/{+path}","compare_url":"https://api.github.com/repos/nhaney90/developer-support/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhaney90/developer-support/merges","archive_url":"https://api.github.com/repos/nhaney90/developer-support/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhaney90/developer-support/downloads","issues_url":"https://api.github.com/repos/nhaney90/developer-support/issues{/number}","pulls_url":"https://api.github.com/repos/nhaney90/developer-support/pulls{/number}","milestones_url":"https://api.github.com/repos/nhaney90/developer-support/milestones{/number}","notifications_url":"https://api.github.com/repos/nhaney90/developer-support/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhaney90/developer-support/labels{/name}","releases_url":"https://api.github.com/repos/nhaney90/developer-support/releases{/id}","deployments_url":"https://api.github.com/repos/nhaney90/developer-support/deployments","created_at":"2015-09-29T14:36:54Z","updated_at":"2017-01-04T14:55:18Z","pushed_at":"2017-01-04T15:00:20Z","git_url":"git://github.com/nhaney90/developer-support.git","ssh_url":"[email protected]:nhaney90/developer-support.git","clone_url":"https://github.com/nhaney90/developer-support.git","svn_url":"https://github.com/nhaney90/developer-support","homepage":"","size":120207,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Esri:master","ref":"master","sha":"333edae1011aa514aebd7c7e1ba550aae0a71679","user":{"login":"Esri","id":628795,"avatar_url":"https://avatars.githubusercontent.com/u/628795?v=3","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"repo":{"id":19163372,"name":"developer-support","full_name":"Esri/developer-support","owner":{"login":"Esri","id":628795,"avatar_url":"https://avatars.githubusercontent.com/u/628795?v=3","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Esri/developer-support","description":"Proof of concept developer code and samples to help be successful with all ArcGIS developer products (Python, NET, JavaScript, Android…). The repository is designed to be an exchange for sharing coding conventions and wisdom to developers at all skill levels. ","fork":false,"url":"https://api.github.com/repos/Esri/developer-support","forks_url":"https://api.github.com/repos/Esri/developer-support/forks","keys_url":"https://api.github.com/repos/Esri/developer-support/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Esri/developer-support/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Esri/developer-support/teams","hooks_url":"https://api.github.com/repos/Esri/developer-support/hooks","issue_events_url":"https://api.github.com/repos/Esri/developer-support/issues/events{/number}","events_url":"https://api.github.com/repos/Esri/developer-support/events","assignees_url":"https://api.github.com/repos/Esri/developer-support/assignees{/user}","branches_url":"https://api.github.com/repos/Esri/developer-support/branches{/branch}","tags_url":"https://api.github.com/repos/Esri/developer-support/tags","blobs_url":"https://api.github.com/repos/Esri/developer-support/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Esri/developer-support/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Esri/developer-support/git/refs{/sha}","trees_url":"https://api.github.com/repos/Esri/developer-support/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Esri/developer-support/statuses/{sha}","languages_url":"https://api.github.com/repos/Esri/developer-support/languages","stargazers_url":"https://api.github.com/repos/Esri/developer-support/stargazers","contributors_url":"https://api.github.com/repos/Esri/developer-support/contributors","subscribers_url":"https://api.github.com/repos/Esri/developer-support/subscribers","subscription_url":"https://api.github.com/repos/Esri/developer-support/subscription","commits_url":"https://api.github.com/repos/Esri/developer-support/commits{/sha}","git_commits_url":"https://api.github.com/repos/Esri/developer-support/git/commits{/sha}","comments_url":"https://api.github.com/repos/Esri/developer-support/comments{/number}","issue_comment_url":"https://api.github.com/repos/Esri/developer-support/issues/comments{/number}","contents_url":"https://api.github.com/repos/Esri/developer-support/contents/{+path}","compare_url":"https://api.github.com/repos/Esri/developer-support/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Esri/developer-support/merges","archive_url":"https://api.github.com/repos/Esri/developer-support/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Esri/developer-support/downloads","issues_url":"https://api.github.com/repos/Esri/developer-support/issues{/number}","pulls_url":"https://api.github.com/repos/Esri/developer-support/pulls{/number}","milestones_url":"https://api.github.com/repos/Esri/developer-support/milestones{/number}","notifications_url":"https://api.github.com/repos/Esri/developer-support/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Esri/developer-support/labels{/name}","releases_url":"https://api.github.com/repos/Esri/developer-support/releases{/id}","deployments_url":"https://api.github.com/repos/Esri/developer-support/deployments","created_at":"2014-04-25T23:05:13Z","updated_at":"2017-01-04T05:20:48Z","pushed_at":"2017-01-04T15:02:08Z","git_url":"git://github.com/Esri/developer-support.git","ssh_url":"[email protected]:Esri/developer-support.git","clone_url":"https://github.com/Esri/developer-support.git","svn_url":"https://github.com/Esri/developer-support","homepage":"","size":124536,"stargazers_count":126,"watchers_count":126,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":99,"mirror_url":null,"open_issues_count":6,"forks":99,"open_issues":6,"watchers":126,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/Esri/developer-support/pulls/286"},"html":{"href":"https://github.com/Esri/developer-support/pull/286"},"issue":{"href":"https://api.github.com/repos/Esri/developer-support/issues/286"},"comments":{"href":"https://api.github.com/repos/Esri/developer-support/issues/286/comments"},"review_comments":{"href":"https://api.github.com/repos/Esri/developer-support/pulls/286/comments"},"review_comment":{"href":"https://api.github.com/repos/Esri/developer-support/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Esri/developer-support/pulls/286/commits"},"statuses":{"href":"https://api.github.com/repos/Esri/developer-support/statuses/f18a1330a4fef260faf42cf56bf77929cf4a1629"}}}} | {
"id": 19163372,
"name": "Esri/developer-support",
"url": "https://api.github.com/repos/Esri/developer-support"
} | {
"id": 3011734,
"login": "jgravois",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3011734?",
"url": "https://api.github.com/users/jgravois"
} | {
"id": 628795,
"login": "Esri",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/628795?",
"url": "https://api.github.com/orgs/Esri"
} | 2017-01-04T17:48:30 | 5102291156 | {"actor":{"display_login":"jgravois"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/pulls/comments/102944336","pull_request_review_id":23710363,"id":102944336,"diff_hunk":"@@ -0,0 +1,9 @@\n+package me.id.webverifylib.listener;\n+\n+/**\n+ * Listener to get the auth token\n+ */\n+public interface IDmeGetAuthCodeListener {","path":"me.id.webverify/webverifylib/src/main/java/me/id/webverifylib/listener/IDmeGetAuthCodeListener.java","position":6,"original_position":6,"commit_id":"c28298d2c77093c7faea4274a4fa25aebc75c267","original_commit_id":"c28298d2c77093c7faea4274a4fa25aebc75c267","user":{"login":"bryant1410","id":3905501,"avatar_url":"https://avatars.githubusercontent.com/u/3905501?v=3","gravatar_id":"","url":"https://api.github.com/users/bryant1410","html_url":"https://github.com/bryant1410","followers_url":"https://api.github.com/users/bryant1410/followers","following_url":"https://api.github.com/users/bryant1410/following{/other_user}","gists_url":"https://api.github.com/users/bryant1410/gists{/gist_id}","starred_url":"https://api.github.com/users/bryant1410/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryant1410/subscriptions","organizations_url":"https://api.github.com/users/bryant1410/orgs","repos_url":"https://api.github.com/users/bryant1410/repos","events_url":"https://api.github.com/users/bryant1410/events{/privacy}","received_events_url":"https://api.github.com/users/bryant1410/received_events","type":"User","site_admin":false},"body":"I think you should consider adding generic classes for this, as RxJava, Retrofit and other libraries does with `Action`, `Function`, `Callback` and the like.","created_at":"2017-02-24T13:53:22Z","updated_at":"2017-02-24T13:55:48Z","html_url":"https://github.com/IDme/ID.me-WebVerify-SDK-Android/pull/24#discussion_r102944336","pull_request_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/pulls/comments/102944336"},"html":{"href":"https://github.com/IDme/ID.me-WebVerify-SDK-Android/pull/24#discussion_r102944336"},"pull_request":{"href":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/pulls/24","id":107723366,"html_url":"https://github.com/IDme/ID.me-WebVerify-SDK-Android/pull/24","diff_url":"https://github.com/IDme/ID.me-WebVerify-SDK-Android/pull/24.diff","patch_url":"https://github.com/IDme/ID.me-WebVerify-SDK-Android/pull/24.patch","issue_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/issues/24","number":24,"state":"open","locked":false,"title":"MOB-463: Access token refreshing","user":{"login":"matir91","id":8472881,"avatar_url":"https://avatars.githubusercontent.com/u/8472881?v=3","gravatar_id":"","url":"https://api.github.com/users/matir91","html_url":"https://github.com/matir91","followers_url":"https://api.github.com/users/matir91/followers","following_url":"https://api.github.com/users/matir91/following{/other_user}","gists_url":"https://api.github.com/users/matir91/gists{/gist_id}","starred_url":"https://api.github.com/users/matir91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matir91/subscriptions","organizations_url":"https://api.github.com/users/matir91/orgs","repos_url":"https://api.github.com/users/matir91/repos","events_url":"https://api.github.com/users/matir91/events{/privacy}","received_events_url":"https://api.github.com/users/matir91/received_events","type":"User","site_admin":false},"body":"Fixed #9\r\n\r\n## Description\r\nAccess token refreshing implemented using the OAuth flow.\r\nThe expiration date of the refresh token is also saved so that if the refresh token is expired then the SDK can return an error immediately\r\n","created_at":"2017-02-23T22:04:31Z","updated_at":"2017-02-24T13:55:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8051677e133b1c600172086c2c0459c3bd79f927","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/pulls/24/commits","review_comments_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/pulls/24/comments","review_comment_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/issues/24/comments","statuses_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/statuses/c28298d2c77093c7faea4274a4fa25aebc75c267","head":{"label":"IDme:MOB-463","ref":"MOB-463","sha":"c28298d2c77093c7faea4274a4fa25aebc75c267","user":{"login":"IDme","id":295660,"avatar_url":"https://avatars.githubusercontent.com/u/295660?v=3","gravatar_id":"","url":"https://api.github.com/users/IDme","html_url":"https://github.com/IDme","followers_url":"https://api.github.com/users/IDme/followers","following_url":"https://api.github.com/users/IDme/following{/other_user}","gists_url":"https://api.github.com/users/IDme/gists{/gist_id}","starred_url":"https://api.github.com/users/IDme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IDme/subscriptions","organizations_url":"https://api.github.com/users/IDme/orgs","repos_url":"https://api.github.com/users/IDme/repos","events_url":"https://api.github.com/users/IDme/events{/privacy}","received_events_url":"https://api.github.com/users/IDme/received_events","type":"Organization","site_admin":false},"repo":{"id":29610888,"name":"ID.me-WebVerify-SDK-Android","full_name":"IDme/ID.me-WebVerify-SDK-Android","owner":{"login":"IDme","id":295660,"avatar_url":"https://avatars.githubusercontent.com/u/295660?v=3","gravatar_id":"","url":"https://api.github.com/users/IDme","html_url":"https://github.com/IDme","followers_url":"https://api.github.com/users/IDme/followers","following_url":"https://api.github.com/users/IDme/following{/other_user}","gists_url":"https://api.github.com/users/IDme/gists{/gist_id}","starred_url":"https://api.github.com/users/IDme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IDme/subscriptions","organizations_url":"https://api.github.com/users/IDme/orgs","repos_url":"https://api.github.com/users/IDme/repos","events_url":"https://api.github.com/users/IDme/events{/privacy}","received_events_url":"https://api.github.com/users/IDme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IDme/ID.me-WebVerify-SDK-Android","description":"An Android library that verifies a user's group affiliation through a WebView.","fork":false,"url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android","forks_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/forks","keys_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/teams","hooks_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/hooks","issue_events_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/issues/events{/number}","events_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/events","assignees_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/assignees{/user}","branches_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/branches{/branch}","tags_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/tags","blobs_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/languages","stargazers_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/stargazers","contributors_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/contributors","subscribers_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/subscribers","subscription_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/subscription","commits_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/contents/{+path}","compare_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/merges","archive_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/downloads","issues_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/issues{/number}","pulls_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/labels{/name}","releases_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/releases{/id}","deployments_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/deployments","created_at":"2015-01-21T20:30:51Z","updated_at":"2016-12-08T19:00:52Z","pushed_at":"2017-02-23T22:07:20Z","git_url":"git://github.com/IDme/ID.me-WebVerify-SDK-Android.git","ssh_url":"[email protected]:IDme/ID.me-WebVerify-SDK-Android.git","clone_url":"https://github.com/IDme/ID.me-WebVerify-SDK-Android.git","svn_url":"https://github.com/IDme/ID.me-WebVerify-SDK-Android","homepage":null,"size":136,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":2,"default_branch":"master"}},"base":{"label":"IDme:MOB-444","ref":"MOB-444","sha":"7f616c5749a5e334bbdb38a781fd0866071d3798","user":{"login":"IDme","id":295660,"avatar_url":"https://avatars.githubusercontent.com/u/295660?v=3","gravatar_id":"","url":"https://api.github.com/users/IDme","html_url":"https://github.com/IDme","followers_url":"https://api.github.com/users/IDme/followers","following_url":"https://api.github.com/users/IDme/following{/other_user}","gists_url":"https://api.github.com/users/IDme/gists{/gist_id}","starred_url":"https://api.github.com/users/IDme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IDme/subscriptions","organizations_url":"https://api.github.com/users/IDme/orgs","repos_url":"https://api.github.com/users/IDme/repos","events_url":"https://api.github.com/users/IDme/events{/privacy}","received_events_url":"https://api.github.com/users/IDme/received_events","type":"Organization","site_admin":false},"repo":{"id":29610888,"name":"ID.me-WebVerify-SDK-Android","full_name":"IDme/ID.me-WebVerify-SDK-Android","owner":{"login":"IDme","id":295660,"avatar_url":"https://avatars.githubusercontent.com/u/295660?v=3","gravatar_id":"","url":"https://api.github.com/users/IDme","html_url":"https://github.com/IDme","followers_url":"https://api.github.com/users/IDme/followers","following_url":"https://api.github.com/users/IDme/following{/other_user}","gists_url":"https://api.github.com/users/IDme/gists{/gist_id}","starred_url":"https://api.github.com/users/IDme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IDme/subscriptions","organizations_url":"https://api.github.com/users/IDme/orgs","repos_url":"https://api.github.com/users/IDme/repos","events_url":"https://api.github.com/users/IDme/events{/privacy}","received_events_url":"https://api.github.com/users/IDme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IDme/ID.me-WebVerify-SDK-Android","description":"An Android library that verifies a user's group affiliation through a WebView.","fork":false,"url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android","forks_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/forks","keys_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/teams","hooks_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/hooks","issue_events_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/issues/events{/number}","events_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/events","assignees_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/assignees{/user}","branches_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/branches{/branch}","tags_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/tags","blobs_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/languages","stargazers_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/stargazers","contributors_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/contributors","subscribers_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/subscribers","subscription_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/subscription","commits_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/contents/{+path}","compare_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/merges","archive_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/downloads","issues_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/issues{/number}","pulls_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/labels{/name}","releases_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/releases{/id}","deployments_url":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/deployments","created_at":"2015-01-21T20:30:51Z","updated_at":"2016-12-08T19:00:52Z","pushed_at":"2017-02-23T22:07:20Z","git_url":"git://github.com/IDme/ID.me-WebVerify-SDK-Android.git","ssh_url":"[email protected]:IDme/ID.me-WebVerify-SDK-Android.git","clone_url":"https://github.com/IDme/ID.me-WebVerify-SDK-Android.git","svn_url":"https://github.com/IDme/ID.me-WebVerify-SDK-Android","homepage":null,"size":136,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/pulls/24"},"html":{"href":"https://github.com/IDme/ID.me-WebVerify-SDK-Android/pull/24"},"issue":{"href":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/issues/24"},"comments":{"href":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android/statuses/c28298d2c77093c7faea4274a4fa25aebc75c267"}}}} | {
"id": 29610888,
"name": "IDme/ID.me-WebVerify-SDK-Android",
"url": "https://api.github.com/repos/IDme/ID.me-WebVerify-SDK-Android"
} | {
"id": 3905501,
"login": "bryant1410",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3905501?",
"url": "https://api.github.com/users/bryant1410"
} | {
"id": 295660,
"login": "IDme",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/295660?",
"url": "https://api.github.com/orgs/IDme"
} | 2017-02-24T13:53:22 | 5385433415 | {"actor":{"display_login":"bryant1410"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/pulls/comments/159124686","pull_request_review_id":86032613,"id":159124686,"diff_hunk":"@@ -0,0 +1,55 @@\n+# Not So Regex\n+Votre collègue aimerait pouvoir télécharger l'Internet et être capable d'y\n+trouver toutes les numéros de cartes de crédits contenus. Pour ce faire il vous","path":"NotSoRegex/README.md","position":3,"original_position":3,"commit_id":"ba4d2f76679ac794f0dbb9717e1fb4128d5eb68d","original_commit_id":"a03babed4bf834c20876d8b63f48059885edabd0","user":{"login":"FelixMartel","id":7853917,"avatar_url":"https://avatars2.githubusercontent.com/u/7853917?v=4","gravatar_id":"","url":"https://api.github.com/users/FelixMartel","html_url":"https://github.com/FelixMartel","followers_url":"https://api.github.com/users/FelixMartel/followers","following_url":"https://api.github.com/users/FelixMartel/following{/other_user}","gists_url":"https://api.github.com/users/FelixMartel/gists{/gist_id}","starred_url":"https://api.github.com/users/FelixMartel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FelixMartel/subscriptions","organizations_url":"https://api.github.com/users/FelixMartel/orgs","repos_url":"https://api.github.com/users/FelixMartel/repos","events_url":"https://api.github.com/users/FelixMartel/events{/privacy}","received_events_url":"https://api.github.com/users/FelixMartel/received_events","type":"User","site_admin":false},"body":"J'irais soit pour\r\nVotre collègue aimerait pouvoir télécharger l'Internet et être capable d'y trouver tous les numéros de carte de crédit contenus.","created_at":"2017-12-30T16:11:21Z","updated_at":"2017-12-30T16:11:21Z","html_url":"https://github.com/JDIS/CSGamesSelectionPublic/pull/1#discussion_r159124686","pull_request_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/pulls/comments/159124686"},"html":{"href":"https://github.com/JDIS/CSGamesSelectionPublic/pull/1#discussion_r159124686"},"pull_request":{"href":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/pulls/1"}},"in_reply_to_id":159124340},"pull_request":{"url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/pulls/1","id":160552903,"html_url":"https://github.com/JDIS/CSGamesSelectionPublic/pull/1","diff_url":"https://github.com/JDIS/CSGamesSelectionPublic/pull/1.diff","patch_url":"https://github.com/JDIS/CSGamesSelectionPublic/pull/1.patch","issue_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/issues/1","number":1,"state":"open","locked":false,"title":"Ajout du defi regex","user":{"login":"DrPandemic","id":3250155,"avatar_url":"https://avatars3.githubusercontent.com/u/3250155?v=4","gravatar_id":"","url":"https://api.github.com/users/DrPandemic","html_url":"https://github.com/DrPandemic","followers_url":"https://api.github.com/users/DrPandemic/followers","following_url":"https://api.github.com/users/DrPandemic/following{/other_user}","gists_url":"https://api.github.com/users/DrPandemic/gists{/gist_id}","starred_url":"https://api.github.com/users/DrPandemic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrPandemic/subscriptions","organizations_url":"https://api.github.com/users/DrPandemic/orgs","repos_url":"https://api.github.com/users/DrPandemic/repos","events_url":"https://api.github.com/users/DrPandemic/events{/privacy}","received_events_url":"https://api.github.com/users/DrPandemic/received_events","type":"User","site_admin":false},"body":"Si la description n'est pas assez bonne dites moi le. Je commence à le coder pour évaluer la difficulté","created_at":"2017-12-29T19:32:45Z","updated_at":"2017-12-30T16:11:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"520db89000189f9c62c336396b8eff5fa9597b6d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Sytten","id":2366731,"avatar_url":"https://avatars0.githubusercontent.com/u/2366731?v=4","gravatar_id":"","url":"https://api.github.com/users/Sytten","html_url":"https://github.com/Sytten","followers_url":"https://api.github.com/users/Sytten/followers","following_url":"https://api.github.com/users/Sytten/following{/other_user}","gists_url":"https://api.github.com/users/Sytten/gists{/gist_id}","starred_url":"https://api.github.com/users/Sytten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sytten/subscriptions","organizations_url":"https://api.github.com/users/Sytten/orgs","repos_url":"https://api.github.com/users/Sytten/repos","events_url":"https://api.github.com/users/Sytten/events{/privacy}","received_events_url":"https://api.github.com/users/Sytten/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/pulls/1/commits","review_comments_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/pulls/1/comments","review_comment_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/issues/1/comments","statuses_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/statuses/ba4d2f76679ac794f0dbb9717e1fb4128d5eb68d","head":{"label":"JDIS:regex-challenge","ref":"regex-challenge","sha":"ba4d2f76679ac794f0dbb9717e1fb4128d5eb68d","user":{"login":"JDIS","id":15794364,"avatar_url":"https://avatars1.githubusercontent.com/u/15794364?v=4","gravatar_id":"","url":"https://api.github.com/users/JDIS","html_url":"https://github.com/JDIS","followers_url":"https://api.github.com/users/JDIS/followers","following_url":"https://api.github.com/users/JDIS/following{/other_user}","gists_url":"https://api.github.com/users/JDIS/gists{/gist_id}","starred_url":"https://api.github.com/users/JDIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDIS/subscriptions","organizations_url":"https://api.github.com/users/JDIS/orgs","repos_url":"https://api.github.com/users/JDIS/repos","events_url":"https://api.github.com/users/JDIS/events{/privacy}","received_events_url":"https://api.github.com/users/JDIS/received_events","type":"Organization","site_admin":false},"repo":{"id":115286906,"name":"CSGamesSelectionPublic","full_name":"JDIS/CSGamesSelectionPublic","owner":{"login":"JDIS","id":15794364,"avatar_url":"https://avatars1.githubusercontent.com/u/15794364?v=4","gravatar_id":"","url":"https://api.github.com/users/JDIS","html_url":"https://github.com/JDIS","followers_url":"https://api.github.com/users/JDIS/followers","following_url":"https://api.github.com/users/JDIS/following{/other_user}","gists_url":"https://api.github.com/users/JDIS/gists{/gist_id}","starred_url":"https://api.github.com/users/JDIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDIS/subscriptions","organizations_url":"https://api.github.com/users/JDIS/orgs","repos_url":"https://api.github.com/users/JDIS/repos","events_url":"https://api.github.com/users/JDIS/events{/privacy}","received_events_url":"https://api.github.com/users/JDIS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JDIS/CSGamesSelectionPublic","description":null,"fork":false,"url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic","forks_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/forks","keys_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/teams","hooks_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/hooks","issue_events_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/issues/events{/number}","events_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/events","assignees_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/assignees{/user}","branches_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/branches{/branch}","tags_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/tags","blobs_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/git/refs{/sha}","trees_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/statuses/{sha}","languages_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/languages","stargazers_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/stargazers","contributors_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/contributors","subscribers_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/subscribers","subscription_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/subscription","commits_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/commits{/sha}","git_commits_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/git/commits{/sha}","comments_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/comments{/number}","issue_comment_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/issues/comments{/number}","contents_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/contents/{+path}","compare_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/merges","archive_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/downloads","issues_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/issues{/number}","pulls_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/pulls{/number}","milestones_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/milestones{/number}","notifications_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/labels{/name}","releases_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/releases{/id}","deployments_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/deployments","created_at":"2017-12-24T21:01:52Z","updated_at":"2017-12-27T16:51:32Z","pushed_at":"2017-12-30T15:53:25Z","git_url":"git://github.com/JDIS/CSGamesSelectionPublic.git","ssh_url":"[email protected]:JDIS/CSGamesSelectionPublic.git","clone_url":"https://github.com/JDIS/CSGamesSelectionPublic.git","svn_url":"https://github.com/JDIS/CSGamesSelectionPublic","homepage":null,"size":3232,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"JDIS:master","ref":"master","sha":"ad6a7ce2afcb6d6e5dc033e1410faf7c9b1a50c1","user":{"login":"JDIS","id":15794364,"avatar_url":"https://avatars1.githubusercontent.com/u/15794364?v=4","gravatar_id":"","url":"https://api.github.com/users/JDIS","html_url":"https://github.com/JDIS","followers_url":"https://api.github.com/users/JDIS/followers","following_url":"https://api.github.com/users/JDIS/following{/other_user}","gists_url":"https://api.github.com/users/JDIS/gists{/gist_id}","starred_url":"https://api.github.com/users/JDIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDIS/subscriptions","organizations_url":"https://api.github.com/users/JDIS/orgs","repos_url":"https://api.github.com/users/JDIS/repos","events_url":"https://api.github.com/users/JDIS/events{/privacy}","received_events_url":"https://api.github.com/users/JDIS/received_events","type":"Organization","site_admin":false},"repo":{"id":115286906,"name":"CSGamesSelectionPublic","full_name":"JDIS/CSGamesSelectionPublic","owner":{"login":"JDIS","id":15794364,"avatar_url":"https://avatars1.githubusercontent.com/u/15794364?v=4","gravatar_id":"","url":"https://api.github.com/users/JDIS","html_url":"https://github.com/JDIS","followers_url":"https://api.github.com/users/JDIS/followers","following_url":"https://api.github.com/users/JDIS/following{/other_user}","gists_url":"https://api.github.com/users/JDIS/gists{/gist_id}","starred_url":"https://api.github.com/users/JDIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDIS/subscriptions","organizations_url":"https://api.github.com/users/JDIS/orgs","repos_url":"https://api.github.com/users/JDIS/repos","events_url":"https://api.github.com/users/JDIS/events{/privacy}","received_events_url":"https://api.github.com/users/JDIS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JDIS/CSGamesSelectionPublic","description":null,"fork":false,"url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic","forks_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/forks","keys_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/teams","hooks_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/hooks","issue_events_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/issues/events{/number}","events_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/events","assignees_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/assignees{/user}","branches_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/branches{/branch}","tags_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/tags","blobs_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/git/refs{/sha}","trees_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/statuses/{sha}","languages_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/languages","stargazers_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/stargazers","contributors_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/contributors","subscribers_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/subscribers","subscription_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/subscription","commits_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/commits{/sha}","git_commits_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/git/commits{/sha}","comments_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/comments{/number}","issue_comment_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/issues/comments{/number}","contents_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/contents/{+path}","compare_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/merges","archive_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/downloads","issues_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/issues{/number}","pulls_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/pulls{/number}","milestones_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/milestones{/number}","notifications_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/labels{/name}","releases_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/releases{/id}","deployments_url":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/deployments","created_at":"2017-12-24T21:01:52Z","updated_at":"2017-12-27T16:51:32Z","pushed_at":"2017-12-30T15:53:25Z","git_url":"git://github.com/JDIS/CSGamesSelectionPublic.git","ssh_url":"[email protected]:JDIS/CSGamesSelectionPublic.git","clone_url":"https://github.com/JDIS/CSGamesSelectionPublic.git","svn_url":"https://github.com/JDIS/CSGamesSelectionPublic","homepage":null,"size":3232,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/pulls/1"},"html":{"href":"https://github.com/JDIS/CSGamesSelectionPublic/pull/1"},"issue":{"href":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/issues/1"},"comments":{"href":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/JDIS/CSGamesSelectionPublic/statuses/ba4d2f76679ac794f0dbb9717e1fb4128d5eb68d"}},"author_association":"NONE"}} | {
"id": 115286906,
"name": "JDIS/CSGamesSelectionPublic",
"url": "https://api.github.com/repos/JDIS/CSGamesSelectionPublic"
} | {
"id": 7853917,
"login": "FelixMartel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7853917?",
"url": "https://api.github.com/users/FelixMartel"
} | {
"id": 15794364,
"login": "JDIS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15794364?",
"url": "https://api.github.com/orgs/JDIS"
} | 2017-12-30T16:11:21 | 7042650318 | {"actor":{"display_login":"FelixMartel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/spack/pulls/comments/96658180","pull_request_review_id":17244508,"id":96658180,"diff_hunk":"@@ -40,12 +42,6 @@ class Hdf5(AutotoolsPackage):\n \n version('1.10.0-patch1', '9180ff0ef8dc2ef3f61bd37a7404f295')\n version('1.10.0', 'bdc935337ee8282579cd6bc4270ad199')\n- version('1.8.18', 'dd2148b740713ca0295442ec683d7b1c',","path":"var/spack/repos/builtin/packages/hdf5/package.py","position":23,"original_position":23,"commit_id":"24c261fe255023c94e973a3935f2866208e8dabe","original_commit_id":"24c261fe255023c94e973a3935f2866208e8dabe","user":{"login":"davydden","id":8023934,"avatar_url":"https://avatars.githubusercontent.com/u/8023934?v=3","gravatar_id":"","url":"https://api.github.com/users/davydden","html_url":"https://github.com/davydden","followers_url":"https://api.github.com/users/davydden/followers","following_url":"https://api.github.com/users/davydden/following{/other_user}","gists_url":"https://api.github.com/users/davydden/gists{/gist_id}","starred_url":"https://api.github.com/users/davydden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davydden/subscriptions","organizations_url":"https://api.github.com/users/davydden/orgs","repos_url":"https://api.github.com/users/davydden/repos","events_url":"https://api.github.com/users/davydden/events{/privacy}","received_events_url":"https://api.github.com/users/davydden/received_events","type":"User","site_admin":false},"body":"again, why removing?","created_at":"2017-01-18T15:22:37Z","updated_at":"2017-01-18T15:27:27Z","html_url":"https://github.com/LLNL/spack/pull/2861#discussion_r96658180","pull_request_url":"https://api.github.com/repos/LLNL/spack/pulls/2861","_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments/96658180"},"html":{"href":"https://github.com/LLNL/spack/pull/2861#discussion_r96658180"},"pull_request":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2861"}}},"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/2861","id":102083723,"html_url":"https://github.com/LLNL/spack/pull/2861","diff_url":"https://github.com/LLNL/spack/pull/2861.diff","patch_url":"https://github.com/LLNL/spack/pull/2861.patch","issue_url":"https://api.github.com/repos/LLNL/spack/issues/2861","number":2861,"state":"open","locked":false,"title":"IBM xl_r compiler build for Trilinos, ","user":{"login":"eklee15","id":24843172,"avatar_url":"https://avatars.githubusercontent.com/u/24843172?v=3","gravatar_id":"","url":"https://api.github.com/users/eklee15","html_url":"https://github.com/eklee15","followers_url":"https://api.github.com/users/eklee15/followers","following_url":"https://api.github.com/users/eklee15/following{/other_user}","gists_url":"https://api.github.com/users/eklee15/gists{/gist_id}","starred_url":"https://api.github.com/users/eklee15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eklee15/subscriptions","organizations_url":"https://api.github.com/users/eklee15/orgs","repos_url":"https://api.github.com/users/eklee15/repos","events_url":"https://api.github.com/users/eklee15/events{/privacy}","received_events_url":"https://api.github.com/users/eklee15/received_events","type":"User","site_admin":false},"body":"We have successfully compiled the following packages with xl_r\r\n\r\nnetlib-lapack\r\nnetlib-scalapack\r\nfftw\r\nmatio\r\nboost\r\nhdf5\r\nmetis\r\nparmetis\r\nnetcdf\r\ncuite-sparse\r\nsuperlu-dist\r\nmumps\r\nhypre\r\ntrilinos\r\npetsc\r\nmagma\r\n","created_at":"2017-01-18T15:09:29Z","updated_at":"2017-01-18T15:27:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/spack/pulls/2861/commits","review_comments_url":"https://api.github.com/repos/LLNL/spack/pulls/2861/comments","review_comment_url":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/2861/comments","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/24c261fe255023c94e973a3935f2866208e8dabe","head":{"label":"eklee15:develop","ref":"develop","sha":"24c261fe255023c94e973a3935f2866208e8dabe","user":{"login":"eklee15","id":24843172,"avatar_url":"https://avatars.githubusercontent.com/u/24843172?v=3","gravatar_id":"","url":"https://api.github.com/users/eklee15","html_url":"https://github.com/eklee15","followers_url":"https://api.github.com/users/eklee15/followers","following_url":"https://api.github.com/users/eklee15/following{/other_user}","gists_url":"https://api.github.com/users/eklee15/gists{/gist_id}","starred_url":"https://api.github.com/users/eklee15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eklee15/subscriptions","organizations_url":"https://api.github.com/users/eklee15/orgs","repos_url":"https://api.github.com/users/eklee15/repos","events_url":"https://api.github.com/users/eklee15/events{/privacy}","received_events_url":"https://api.github.com/users/eklee15/received_events","type":"User","site_admin":false},"repo":{"id":77692113,"name":"spack","full_name":"eklee15/spack","owner":{"login":"eklee15","id":24843172,"avatar_url":"https://avatars.githubusercontent.com/u/24843172?v=3","gravatar_id":"","url":"https://api.github.com/users/eklee15","html_url":"https://github.com/eklee15","followers_url":"https://api.github.com/users/eklee15/followers","following_url":"https://api.github.com/users/eklee15/following{/other_user}","gists_url":"https://api.github.com/users/eklee15/gists{/gist_id}","starred_url":"https://api.github.com/users/eklee15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eklee15/subscriptions","organizations_url":"https://api.github.com/users/eklee15/orgs","repos_url":"https://api.github.com/users/eklee15/repos","events_url":"https://api.github.com/users/eklee15/events{/privacy}","received_events_url":"https://api.github.com/users/eklee15/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eklee15/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/eklee15/spack","forks_url":"https://api.github.com/repos/eklee15/spack/forks","keys_url":"https://api.github.com/repos/eklee15/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eklee15/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eklee15/spack/teams","hooks_url":"https://api.github.com/repos/eklee15/spack/hooks","issue_events_url":"https://api.github.com/repos/eklee15/spack/issues/events{/number}","events_url":"https://api.github.com/repos/eklee15/spack/events","assignees_url":"https://api.github.com/repos/eklee15/spack/assignees{/user}","branches_url":"https://api.github.com/repos/eklee15/spack/branches{/branch}","tags_url":"https://api.github.com/repos/eklee15/spack/tags","blobs_url":"https://api.github.com/repos/eklee15/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eklee15/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eklee15/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/eklee15/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eklee15/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/eklee15/spack/languages","stargazers_url":"https://api.github.com/repos/eklee15/spack/stargazers","contributors_url":"https://api.github.com/repos/eklee15/spack/contributors","subscribers_url":"https://api.github.com/repos/eklee15/spack/subscribers","subscription_url":"https://api.github.com/repos/eklee15/spack/subscription","commits_url":"https://api.github.com/repos/eklee15/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/eklee15/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/eklee15/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/eklee15/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/eklee15/spack/contents/{+path}","compare_url":"https://api.github.com/repos/eklee15/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eklee15/spack/merges","archive_url":"https://api.github.com/repos/eklee15/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eklee15/spack/downloads","issues_url":"https://api.github.com/repos/eklee15/spack/issues{/number}","pulls_url":"https://api.github.com/repos/eklee15/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/eklee15/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/eklee15/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eklee15/spack/labels{/name}","releases_url":"https://api.github.com/repos/eklee15/spack/releases{/id}","deployments_url":"https://api.github.com/repos/eklee15/spack/deployments","created_at":"2016-12-30T14:50:08Z","updated_at":"2016-12-30T14:50:13Z","pushed_at":"2017-01-16T20:29:42Z","git_url":"git://github.com/eklee15/spack.git","ssh_url":"[email protected]:eklee15/spack.git","clone_url":"https://github.com/eklee15/spack.git","svn_url":"https://github.com/eklee15/spack","homepage":"http://llnl.github.io/spack","size":19116,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"f0f230d480004161c8f052d2ccf334a4f5ce25f8","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2017-01-18T14:05:56Z","pushed_at":"2017-01-18T15:12:28Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"[email protected]:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"http://spack.io","size":19600,"stargazers_count":200,"watchers_count":200,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":175,"mirror_url":null,"open_issues_count":478,"forks":175,"open_issues":478,"watchers":200,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2861"},"html":{"href":"https://github.com/LLNL/spack/pull/2861"},"issue":{"href":"https://api.github.com/repos/LLNL/spack/issues/2861"},"comments":{"href":"https://api.github.com/repos/LLNL/spack/issues/2861/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2861/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2861/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/spack/statuses/24c261fe255023c94e973a3935f2866208e8dabe"}}}} | {
"id": 15730865,
"name": "LLNL/spack",
"url": "https://api.github.com/repos/LLNL/spack"
} | {
"id": 8023934,
"login": "davydden",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8023934?",
"url": "https://api.github.com/users/davydden"
} | {
"id": 5921419,
"login": "LLNL",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5921419?",
"url": "https://api.github.com/orgs/LLNL"
} | 2017-01-18T15:22:37 | 5173162931 | {"actor":{"display_login":"davydden"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments/134900435","pull_request_review_id":58248367,"id":134900435,"diff_hunk":"@@ -1212,8 +1245,19 @@ namespace ReportSizingManager {\n \t\t\t\t\t\trho = GetDensityGlycol( PlantLoop( DataWaterLoopNum ).FluidName, DataGlobals::HWInitConvTemp, PlantLoop( DataWaterLoopNum ).FluidIndex, CallingRoutine );\n \t\t\t\t\t\tAutosizeDes = DataWaterFlowUsedForSizing * DataWaterCoilSizHeatDeltaT * Cp * rho;\n \t\t\t\t\t} else {\n-\t\t\t\t\t\tDesMassFlow = FinalZoneSizing( CurZoneEqNum ).DesHeatMassFlow;\n-\t\t\t\t\t\tCoilInTemp = FinalZoneSizing( CurZoneEqNum ).DesHeatCoilInTemp;\n+\t\t\t\t\t\tif ( ZoneEqSizing( CurZoneEqNum ).SystemAirFlow ) {\n+\t\t\t\t\t\t\tDesMassFlow = ZoneEqSizing( CurZoneEqNum ).AirVolFlow * StdRhoAir;\n+\t\t\t\t\t\t} else if ( ZoneEqSizing( CurZoneEqNum ).HeatingAirFlow ) {\n+\t\t\t\t\t\t\tDesMassFlow = ZoneEqSizing( CurZoneEqNum ).HeatingAirVolFlow * StdRhoAir;\n+\t\t\t\t\t\t} else {\n+\t\t\t\t\t\t\tDesMassFlow = FinalZoneSizing( CurZoneEqNum ).DesHeatMassFlow;\n+\t\t\t\t\t\t}\n+\t\t\t\t\t\tif ( DesMassFlow > 0.0 ) {\n+\t\t\t\t\t\t\tOutAirFrac = min( StdRhoAir * ZoneEqSizing( CurZoneEqNum ).OAVolFlow / DesMassFlow, 1.0 );\n+\t\t\t\t\t\t} else {\n+\t\t\t\t\t\t\tOutAirFrac = 0.0;\n+\t\t\t\t\t\t}\n+\t\t\t\t\t\tCoilInTemp = ( 1.0 - OutAirFrac ) * FinalZoneSizing( CurZoneEqNum ).ZoneTempAtHeatPeak + OutAirFrac * FinalZoneSizing( CurZoneEqNum ).OutTempAtHeatPeak;\n \t\t\t\t\t\tCoilInHumRat = FinalZoneSizing( CurZoneEqNum ).DesHeatCoilInHumRat;","path":"src/EnergyPlus/ReportSizingManager.cc","position":129,"original_position":129,"commit_id":"e3b346e142e86369a2642d2fc0608c7fc4555839","original_commit_id":"e3b346e142e86369a2642d2fc0608c7fc4555839","user":{"login":"mjwitte","id":4991075,"avatar_url":"https://avatars2.githubusercontent.com/u/4991075?v=4","gravatar_id":"","url":"https://api.github.com/users/mjwitte","html_url":"https://github.com/mjwitte","followers_url":"https://api.github.com/users/mjwitte/followers","following_url":"https://api.github.com/users/mjwitte/following{/other_user}","gists_url":"https://api.github.com/users/mjwitte/gists{/gist_id}","starred_url":"https://api.github.com/users/mjwitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjwitte/subscriptions","organizations_url":"https://api.github.com/users/mjwitte/orgs","repos_url":"https://api.github.com/users/mjwitte/repos","events_url":"https://api.github.com/users/mjwitte/events{/privacy}","received_events_url":"https://api.github.com/users/mjwitte/received_events","type":"User","site_admin":false},"body":"Doesn't CoilInHumRat also need to be calculated as a combination of OA and Zone conditions?\r\nAlso, more general comment, not following why essentially the same code needs to be inserted in this function multiple times. This is the 4th or 5th place now.","created_at":"2017-08-24T00:05:14Z","updated_at":"2017-08-24T01:01:41Z","html_url":"https://github.com/NREL/EnergyPlus/pull/6079#discussion_r134900435","pull_request_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6079","_links":{"self":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments/134900435"},"html":{"href":"https://github.com/NREL/EnergyPlus/pull/6079#discussion_r134900435"},"pull_request":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6079"}}},"pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6079","id":112151869,"html_url":"https://github.com/NREL/EnergyPlus/pull/6079","diff_url":"https://github.com/NREL/EnergyPlus/pull/6079.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/6079.patch","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6079","number":6079,"state":"open","locked":false,"title":"PTAC hot water heating coil undersized for ventilation load","user":{"login":"rraustad","id":5778156,"avatar_url":"https://avatars3.githubusercontent.com/u/5778156?v=4","gravatar_id":"","url":"https://api.github.com/users/rraustad","html_url":"https://github.com/rraustad","followers_url":"https://api.github.com/users/rraustad/followers","following_url":"https://api.github.com/users/rraustad/following{/other_user}","gists_url":"https://api.github.com/users/rraustad/gists{/gist_id}","starred_url":"https://api.github.com/users/rraustad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rraustad/subscriptions","organizations_url":"https://api.github.com/users/rraustad/orgs","repos_url":"https://api.github.com/users/rraustad/repos","events_url":"https://api.github.com/users/rraustad/events{/privacy}","received_events_url":"https://api.github.com/users/rraustad/received_events","type":"User","site_admin":false},"body":"Pull request overview\r\n---------------------\r\nUser file has PTACs with hot water heating coils. PTACs provide ventilation air. For zones with a zero design heating load, the PTAC heating coil is undersized and cannot temper the ventilation load. This change addresses #6028 and results in a 3 to 4 fold increase in water heating coil size in some cases. This change also results in component air flow sizing the same as the Packaged Terminal unit.\r\n\r\nWork around: adding a small negative other equipment load to those zones in order to force a non-zero design heating load fixes the coil sizing.\r\n\r\n### Work Checklist\r\nAdd to this list or remove from it as applicable. This is a simple templated set of guidelines.\r\n - [x] Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)\r\n - [x] At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:\r\n - Defect: This pull request repairs a github defect issue. The github issue should be referenced in the PR description\r\n - Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring\r\n - NewFeature: This pull request includes code to add a new feature to EnergyPlus\r\n - Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus\r\n - DoNoPublish: This pull request includes changes that shouldn't be included in the changelog\r\n\r\n### Review Checklist\r\nThis will not be exhaustively relevant to every PR.\r\n - [x] Code style (parentheses padding, variable names)\r\n - [x] Functional code review (it has to work!)\r\n - [x] If defect, results of running current develop vs this branch should exhibit the fix\r\n - [x] CI status: all green or justified\r\n - [x] Performance: CI Linux results include performance check -- verify this\r\n - [x] Unit Test(s)\r\n - C++ checks:\r\n - [ ] Argument types\r\n - [ ] If any virtual classes, ensure virtual destructor included, other things\r\n - IDD changes:\r\n - [ ] Verify naming conventions and styles, memos and notes and defaults\r\n - [ ] Open windows IDF Editor with modified IDD to check for errors\r\n - [ ] If transition, add rules to spreadsheet\r\n - [ ] If transition, add transition source\r\n - [ ] If transition, update idfs\r\n - [ ] If new idf included, locally check the err file and other outputs\r\n - [ ] Documentation changes in place\r\n - [ ] Changed docs build successfully\r\n - [ ] ExpandObjects changes?\r\n - [ ] If output changes, including tabular output structure, add to output rules file for interfaces\r\n","created_at":"2017-03-23T02:44:04Z","updated_at":"2017-08-24T01:01:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93fc6439fc6d8840912d980c94da00875ce19afd","assignee":{"login":"mjwitte","id":4991075,"avatar_url":"https://avatars2.githubusercontent.com/u/4991075?v=4","gravatar_id":"","url":"https://api.github.com/users/mjwitte","html_url":"https://github.com/mjwitte","followers_url":"https://api.github.com/users/mjwitte/followers","following_url":"https://api.github.com/users/mjwitte/following{/other_user}","gists_url":"https://api.github.com/users/mjwitte/gists{/gist_id}","starred_url":"https://api.github.com/users/mjwitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjwitte/subscriptions","organizations_url":"https://api.github.com/users/mjwitte/orgs","repos_url":"https://api.github.com/users/mjwitte/repos","events_url":"https://api.github.com/users/mjwitte/events{/privacy}","received_events_url":"https://api.github.com/users/mjwitte/received_events","type":"User","site_admin":false},"assignees":[{"login":"mjwitte","id":4991075,"avatar_url":"https://avatars2.githubusercontent.com/u/4991075?v=4","gravatar_id":"","url":"https://api.github.com/users/mjwitte","html_url":"https://github.com/mjwitte","followers_url":"https://api.github.com/users/mjwitte/followers","following_url":"https://api.github.com/users/mjwitte/following{/other_user}","gists_url":"https://api.github.com/users/mjwitte/gists{/gist_id}","starred_url":"https://api.github.com/users/mjwitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjwitte/subscriptions","organizations_url":"https://api.github.com/users/mjwitte/orgs","repos_url":"https://api.github.com/users/mjwitte/repos","events_url":"https://api.github.com/users/mjwitte/events{/privacy}","received_events_url":"https://api.github.com/users/mjwitte/received_events","type":"User","site_admin":false},{"login":"rraustad","id":5778156,"avatar_url":"https://avatars3.githubusercontent.com/u/5778156?v=4","gravatar_id":"","url":"https://api.github.com/users/rraustad","html_url":"https://github.com/rraustad","followers_url":"https://api.github.com/users/rraustad/followers","following_url":"https://api.github.com/users/rraustad/following{/other_user}","gists_url":"https://api.github.com/users/rraustad/gists{/gist_id}","starred_url":"https://api.github.com/users/rraustad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rraustad/subscriptions","organizations_url":"https://api.github.com/users/rraustad/orgs","repos_url":"https://api.github.com/users/rraustad/repos","events_url":"https://api.github.com/users/rraustad/events{/privacy}","received_events_url":"https://api.github.com/users/rraustad/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/6","html_url":"https://github.com/NREL/EnergyPlus/milestone/6","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/6/labels","id":2280311,"number":6,"title":"EnergyPlus 8.8.0","description":"The EnergyPlus 8.8.0 public release at the end of FY17Q4.","creator":{"login":"mjwitte","id":4991075,"avatar_url":"https://avatars2.githubusercontent.com/u/4991075?v=4","gravatar_id":"","url":"https://api.github.com/users/mjwitte","html_url":"https://github.com/mjwitte","followers_url":"https://api.github.com/users/mjwitte/followers","following_url":"https://api.github.com/users/mjwitte/following{/other_user}","gists_url":"https://api.github.com/users/mjwitte/gists{/gist_id}","starred_url":"https://api.github.com/users/mjwitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjwitte/subscriptions","organizations_url":"https://api.github.com/users/mjwitte/orgs","repos_url":"https://api.github.com/users/mjwitte/repos","events_url":"https://api.github.com/users/mjwitte/events{/privacy}","received_events_url":"https://api.github.com/users/mjwitte/received_events","type":"User","site_admin":false},"open_issues":47,"closed_issues":52,"state":"open","created_at":"2017-01-26T16:05:24Z","updated_at":"2017-08-23T23:16:09Z","due_on":"2017-09-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6079/commits","review_comments_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6079/comments","review_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6079/comments","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/e3b346e142e86369a2642d2fc0608c7fc4555839","head":{"label":"NREL:#6028-PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero","ref":"#6028-PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero","sha":"e3b346e142e86369a2642d2fc0608c7fc4555839","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/EnergyPlus/deployments","created_at":"2013-11-22T14:47:34Z","updated_at":"2017-08-20T10:04:05Z","pushed_at":"2017-08-23T23:15:04Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"[email protected]:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":"https://energyplus.net","size":328304,"stargazers_count":166,"watchers_count":166,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":109,"mirror_url":null,"open_issues_count":468,"forks":109,"open_issues":468,"watchers":166,"default_branch":"develop"}},"base":{"label":"NREL:develop","ref":"develop","sha":"463155660be973706fd12d9bad64276bec5694b9","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/EnergyPlus/deployments","created_at":"2013-11-22T14:47:34Z","updated_at":"2017-08-20T10:04:05Z","pushed_at":"2017-08-23T23:15:04Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"[email protected]:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":"https://energyplus.net","size":328304,"stargazers_count":166,"watchers_count":166,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":109,"mirror_url":null,"open_issues_count":468,"forks":109,"open_issues":468,"watchers":166,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6079"},"html":{"href":"https://github.com/NREL/EnergyPlus/pull/6079"},"issue":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/6079"},"comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/6079/comments"},"review_comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6079/comments"},"review_comment":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6079/commits"},"statuses":{"href":"https://api.github.com/repos/NREL/EnergyPlus/statuses/e3b346e142e86369a2642d2fc0608c7fc4555839"}}}} | {
"id": 14620185,
"name": "NREL/EnergyPlus",
"url": "https://api.github.com/repos/NREL/EnergyPlus"
} | {
"id": 4991075,
"login": "mjwitte",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4991075?",
"url": "https://api.github.com/users/mjwitte"
} | {
"id": 1906800,
"login": "NREL",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1906800?",
"url": "https://api.github.com/orgs/NREL"
} | 2017-08-24T00:05:14 | 6505175604 | {"actor":{"display_login":"mjwitte"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/pulls/comments/141489776","pull_request_review_id":65712384,"id":141489776,"diff_hunk":"@@ -544,12 +544,30 @@ def getPeople(self, ids=None, firstname=None, lastname=None):\n \n def getAffiliations(self, ids=None, personfirst=None, personlast=None, orgcode=None):\n \"\"\"\n- getAffiliations(self, ids=None, personfirst=None, personlast=None, orgcode=None)\n- * Pass nothing - returns a list of all Affiliation objects\n- * Pass a list of AffiliationID - returns a single Affiliation object\n- * Pass a First Name - returns a single Affiliation object\n- * Pass a Last Name - returns a single Affiliation object\n- * Pass an OrganizationCode - returns a Affiliation object\n+ Retrieve a list of ODM2 Affiliation objects.","path":"odm2api/ODM2/services/readService.py","position":10,"original_position":10,"commit_id":"bbfbd5fff9bc762076f940ea2c42cbc2a8d95f99","original_commit_id":"bbfbd5fff9bc762076f940ea2c42cbc2a8d95f99","user":{"login":"lsetiawan","id":17802172,"avatar_url":"https://avatars1.githubusercontent.com/u/17802172?v=4","gravatar_id":"","url":"https://api.github.com/users/lsetiawan","html_url":"https://github.com/lsetiawan","followers_url":"https://api.github.com/users/lsetiawan/followers","following_url":"https://api.github.com/users/lsetiawan/following{/other_user}","gists_url":"https://api.github.com/users/lsetiawan/gists{/gist_id}","starred_url":"https://api.github.com/users/lsetiawan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsetiawan/subscriptions","organizations_url":"https://api.github.com/users/lsetiawan/orgs","repos_url":"https://api.github.com/users/lsetiawan/repos","events_url":"https://api.github.com/users/lsetiawan/events{/privacy}","received_events_url":"https://api.github.com/users/lsetiawan/received_events","type":"User","site_admin":false},"body":"The previous docstring seems to be incorrect, the function always returns a list...","created_at":"2017-09-27T23:02:13Z","updated_at":"2017-09-27T23:02:13Z","html_url":"https://github.com/ODM2/ODM2PythonAPI/pull/98#discussion_r141489776","pull_request_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/pulls/98","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ODM2/ODM2PythonAPI/pulls/comments/141489776"},"html":{"href":"https://github.com/ODM2/ODM2PythonAPI/pull/98#discussion_r141489776"},"pull_request":{"href":"https://api.github.com/repos/ODM2/ODM2PythonAPI/pulls/98"}},"in_reply_to_id":141488706},"pull_request":{"url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/pulls/98","id":143518260,"html_url":"https://github.com/ODM2/ODM2PythonAPI/pull/98","diff_url":"https://github.com/ODM2/ODM2PythonAPI/pull/98.diff","patch_url":"https://github.com/ODM2/ODM2PythonAPI/pull/98.patch","issue_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/issues/98","number":98,"state":"open","locked":false,"title":"Improve getAffiliation docstring to follow numpy/scipy documentation","user":{"login":"lsetiawan","id":17802172,"avatar_url":"https://avatars1.githubusercontent.com/u/17802172?v=4","gravatar_id":"","url":"https://api.github.com/users/lsetiawan","html_url":"https://github.com/lsetiawan","followers_url":"https://api.github.com/users/lsetiawan/followers","following_url":"https://api.github.com/users/lsetiawan/following{/other_user}","gists_url":"https://api.github.com/users/lsetiawan/gists{/gist_id}","starred_url":"https://api.github.com/users/lsetiawan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsetiawan/subscriptions","organizations_url":"https://api.github.com/users/lsetiawan/orgs","repos_url":"https://api.github.com/users/lsetiawan/repos","events_url":"https://api.github.com/users/lsetiawan/events{/privacy}","received_events_url":"https://api.github.com/users/lsetiawan/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nThis PR improves the docstring for `getAffiliations` to follow the numpy/scipy documentation standard. If you have suggestions of better wordings, please let me know. This relates to #97.","created_at":"2017-09-27T22:48:00Z","updated_at":"2017-09-27T23:02:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1aa778be3aa2815ccc01efeffbe436de2cdb28a0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/pulls/98/commits","review_comments_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/pulls/98/comments","review_comment_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/issues/98/comments","statuses_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/statuses/bbfbd5fff9bc762076f940ea2c42cbc2a8d95f99","head":{"label":"lsetiawan:gaff_doc","ref":"gaff_doc","sha":"bbfbd5fff9bc762076f940ea2c42cbc2a8d95f99","user":{"login":"lsetiawan","id":17802172,"avatar_url":"https://avatars1.githubusercontent.com/u/17802172?v=4","gravatar_id":"","url":"https://api.github.com/users/lsetiawan","html_url":"https://github.com/lsetiawan","followers_url":"https://api.github.com/users/lsetiawan/followers","following_url":"https://api.github.com/users/lsetiawan/following{/other_user}","gists_url":"https://api.github.com/users/lsetiawan/gists{/gist_id}","starred_url":"https://api.github.com/users/lsetiawan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsetiawan/subscriptions","organizations_url":"https://api.github.com/users/lsetiawan/orgs","repos_url":"https://api.github.com/users/lsetiawan/repos","events_url":"https://api.github.com/users/lsetiawan/events{/privacy}","received_events_url":"https://api.github.com/users/lsetiawan/received_events","type":"User","site_admin":false},"repo":{"id":89534782,"name":"ODM2PythonAPI","full_name":"lsetiawan/ODM2PythonAPI","owner":{"login":"lsetiawan","id":17802172,"avatar_url":"https://avatars1.githubusercontent.com/u/17802172?v=4","gravatar_id":"","url":"https://api.github.com/users/lsetiawan","html_url":"https://github.com/lsetiawan","followers_url":"https://api.github.com/users/lsetiawan/followers","following_url":"https://api.github.com/users/lsetiawan/following{/other_user}","gists_url":"https://api.github.com/users/lsetiawan/gists{/gist_id}","starred_url":"https://api.github.com/users/lsetiawan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsetiawan/subscriptions","organizations_url":"https://api.github.com/users/lsetiawan/orgs","repos_url":"https://api.github.com/users/lsetiawan/repos","events_url":"https://api.github.com/users/lsetiawan/events{/privacy}","received_events_url":"https://api.github.com/users/lsetiawan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lsetiawan/ODM2PythonAPI","description":"A Python and SQL Alchemy-based data access layer for ODM2","fork":true,"url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI","forks_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/forks","keys_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/teams","hooks_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/hooks","issue_events_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/issues/events{/number}","events_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/events","assignees_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/assignees{/user}","branches_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/branches{/branch}","tags_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/tags","blobs_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/languages","stargazers_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/stargazers","contributors_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/contributors","subscribers_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/subscribers","subscription_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/subscription","commits_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/contents/{+path}","compare_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/merges","archive_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/downloads","issues_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/issues{/number}","pulls_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/labels{/name}","releases_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/releases{/id}","deployments_url":"https://api.github.com/repos/lsetiawan/ODM2PythonAPI/deployments","created_at":"2017-04-26T23:14:51Z","updated_at":"2017-04-26T23:14:54Z","pushed_at":"2017-09-27T22:33:37Z","git_url":"git://github.com/lsetiawan/ODM2PythonAPI.git","ssh_url":"[email protected]:lsetiawan/ODM2PythonAPI.git","clone_url":"https://github.com/lsetiawan/ODM2PythonAPI.git","svn_url":"https://github.com/lsetiawan/ODM2PythonAPI","homepage":null,"size":6876,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ODM2:master","ref":"master","sha":"feff5764f34a6756056e033c6c8d368c2fcce664","user":{"login":"ODM2","id":12091612,"avatar_url":"https://avatars0.githubusercontent.com/u/12091612?v=4","gravatar_id":"","url":"https://api.github.com/users/ODM2","html_url":"https://github.com/ODM2","followers_url":"https://api.github.com/users/ODM2/followers","following_url":"https://api.github.com/users/ODM2/following{/other_user}","gists_url":"https://api.github.com/users/ODM2/gists{/gist_id}","starred_url":"https://api.github.com/users/ODM2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ODM2/subscriptions","organizations_url":"https://api.github.com/users/ODM2/orgs","repos_url":"https://api.github.com/users/ODM2/repos","events_url":"https://api.github.com/users/ODM2/events{/privacy}","received_events_url":"https://api.github.com/users/ODM2/received_events","type":"Organization","site_admin":false},"repo":{"id":34542098,"name":"ODM2PythonAPI","full_name":"ODM2/ODM2PythonAPI","owner":{"login":"ODM2","id":12091612,"avatar_url":"https://avatars0.githubusercontent.com/u/12091612?v=4","gravatar_id":"","url":"https://api.github.com/users/ODM2","html_url":"https://github.com/ODM2","followers_url":"https://api.github.com/users/ODM2/followers","following_url":"https://api.github.com/users/ODM2/following{/other_user}","gists_url":"https://api.github.com/users/ODM2/gists{/gist_id}","starred_url":"https://api.github.com/users/ODM2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ODM2/subscriptions","organizations_url":"https://api.github.com/users/ODM2/orgs","repos_url":"https://api.github.com/users/ODM2/repos","events_url":"https://api.github.com/users/ODM2/events{/privacy}","received_events_url":"https://api.github.com/users/ODM2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ODM2/ODM2PythonAPI","description":"A Python and SQL Alchemy-based data access layer for ODM2","fork":false,"url":"https://api.github.com/repos/ODM2/ODM2PythonAPI","forks_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/forks","keys_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/teams","hooks_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/hooks","issue_events_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/issues/events{/number}","events_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/events","assignees_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/assignees{/user}","branches_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/branches{/branch}","tags_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/tags","blobs_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/languages","stargazers_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/stargazers","contributors_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/contributors","subscribers_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/subscribers","subscription_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/subscription","commits_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/contents/{+path}","compare_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/merges","archive_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/downloads","issues_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/issues{/number}","pulls_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/labels{/name}","releases_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/releases{/id}","deployments_url":"https://api.github.com/repos/ODM2/ODM2PythonAPI/deployments","created_at":"2015-04-24T21:11:46Z","updated_at":"2017-05-03T05:53:24Z","pushed_at":"2017-09-27T22:48:00Z","git_url":"git://github.com/ODM2/ODM2PythonAPI.git","ssh_url":"[email protected]:ODM2/ODM2PythonAPI.git","clone_url":"https://github.com/ODM2/ODM2PythonAPI.git","svn_url":"https://github.com/ODM2/ODM2PythonAPI","homepage":null,"size":6900,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":40,"forks":7,"open_issues":40,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ODM2/ODM2PythonAPI/pulls/98"},"html":{"href":"https://github.com/ODM2/ODM2PythonAPI/pull/98"},"issue":{"href":"https://api.github.com/repos/ODM2/ODM2PythonAPI/issues/98"},"comments":{"href":"https://api.github.com/repos/ODM2/ODM2PythonAPI/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/ODM2/ODM2PythonAPI/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/ODM2/ODM2PythonAPI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ODM2/ODM2PythonAPI/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/ODM2/ODM2PythonAPI/statuses/bbfbd5fff9bc762076f940ea2c42cbc2a8d95f99"}},"author_association":"MEMBER"}} | {
"id": 34542098,
"name": "ODM2/ODM2PythonAPI",
"url": "https://api.github.com/repos/ODM2/ODM2PythonAPI"
} | {
"id": 17802172,
"login": "lsetiawan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17802172?",
"url": "https://api.github.com/users/lsetiawan"
} | {
"id": 12091612,
"login": "ODM2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12091612?",
"url": "https://api.github.com/orgs/ODM2"
} | 2017-09-27T23:02:13 | 6646675659 | {"actor":{"display_login":"lsetiawan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/comments/119053124","pull_request_review_id":40896869,"id":119053124,"diff_hunk":"@@ -0,0 +1,33 @@\n+package org.osgp.adapter.protocol.dlms.domain.commands.utils;\n+\n+import com.alliander.osgp.dto.valueobjects.smartmetering.ChannelElementValues;\n+import com.alliander.osgp.dto.valueobjects.smartmetering.MbusChannelElementsDto;\n+\n+/**\n+ * because the logic how to match a channel to couple a gas-meter to an e-meter,\n+ * this dedicated class and a corresponding junit is created\n+ */\n+public class FindMatchingChannelHelper {\n+\n+ private FindMatchingChannelHelper() {\n+ // empty ctor because it onlu contains static method","path":"osgp-protocol-adapter-dlms/src/main/java/org/osgp/adapter/protocol/dlms/domain/commands/utils/FindMatchingChannelHelper.java","position":20,"original_position":13,"commit_id":"a712c7583419e80611f2caca5c0fff36e791f189","original_commit_id":"4b99812906007fd8b032882383e119986eaa8d80","user":{"login":"hannek24","id":6457709,"avatar_url":"https://avatars0.githubusercontent.com/u/6457709?v=3","gravatar_id":"","url":"https://api.github.com/users/hannek24","html_url":"https://github.com/hannek24","followers_url":"https://api.github.com/users/hannek24/followers","following_url":"https://api.github.com/users/hannek24/following{/other_user}","gists_url":"https://api.github.com/users/hannek24/gists{/gist_id}","starred_url":"https://api.github.com/users/hannek24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannek24/subscriptions","organizations_url":"https://api.github.com/users/hannek24/orgs","repos_url":"https://api.github.com/users/hannek24/repos","events_url":"https://api.github.com/users/hannek24/events{/privacy}","received_events_url":"https://api.github.com/users/hannek24/received_events","type":"User","site_admin":false},"body":"typo: onlu ","created_at":"2017-05-30T09:34:00Z","updated_at":"2017-05-30T09:34:00Z","html_url":"https://github.com/OSGP/Protocol-Adapter-DLMS/pull/201#discussion_r119053124","pull_request_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/201","_links":{"self":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/comments/119053124"},"html":{"href":"https://github.com/OSGP/Protocol-Adapter-DLMS/pull/201#discussion_r119053124"},"pull_request":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/201"}}},"pull_request":{"url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/201","id":121998984,"html_url":"https://github.com/OSGP/Protocol-Adapter-DLMS/pull/201","diff_url":"https://github.com/OSGP/Protocol-Adapter-DLMS/pull/201.diff","patch_url":"https://github.com/OSGP/Protocol-Adapter-DLMS/pull/201.patch","issue_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues/201","number":201,"state":"open","locked":false,"title":"Slim 975 modify couple mbus device for properly installed gasmeters","user":{"login":"robinbakkeruscgi","id":18286805,"avatar_url":"https://avatars0.githubusercontent.com/u/18286805?v=3","gravatar_id":"","url":"https://api.github.com/users/robinbakkeruscgi","html_url":"https://github.com/robinbakkeruscgi","followers_url":"https://api.github.com/users/robinbakkeruscgi/followers","following_url":"https://api.github.com/users/robinbakkeruscgi/following{/other_user}","gists_url":"https://api.github.com/users/robinbakkeruscgi/gists{/gist_id}","starred_url":"https://api.github.com/users/robinbakkeruscgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinbakkeruscgi/subscriptions","organizations_url":"https://api.github.com/users/robinbakkeruscgi/orgs","repos_url":"https://api.github.com/users/robinbakkeruscgi/repos","events_url":"https://api.github.com/users/robinbakkeruscgi/events{/privacy}","received_events_url":"https://api.github.com/users/robinbakkeruscgi/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-23T13:33:13Z","updated_at":"2017-05-30T09:34:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b514a260b690e165a9657d7946cbc715e38c820","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/201/commits","review_comments_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/201/comments","review_comment_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues/201/comments","statuses_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/statuses/a712c7583419e80611f2caca5c0fff36e791f189","head":{"label":"OSGP:SLIM-975-Modify_CoupleMbusDevice_for_properly_installed_gasmeters","ref":"SLIM-975-Modify_CoupleMbusDevice_for_properly_installed_gasmeters","sha":"a712c7583419e80611f2caca5c0fff36e791f189","user":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars3.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":33675294,"name":"Protocol-Adapter-DLMS","full_name":"OSGP/Protocol-Adapter-DLMS","owner":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars3.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Protocol-Adapter-DLMS","description":"Protocol adapter and device simulator for Device Language Message Specification protocol.","fork":false,"url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS","forks_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/forks","keys_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/teams","hooks_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/events","assignees_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/tags","blobs_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/languages","stargazers_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/subscription","commits_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/merges","archive_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/downloads","issues_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/releases{/id}","deployments_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/deployments","created_at":"2015-04-09T14:59:22Z","updated_at":"2017-04-14T14:38:09Z","pushed_at":"2017-05-30T09:33:34Z","git_url":"git://github.com/OSGP/Protocol-Adapter-DLMS.git","ssh_url":"[email protected]:OSGP/Protocol-Adapter-DLMS.git","clone_url":"https://github.com/OSGP/Protocol-Adapter-DLMS.git","svn_url":"https://github.com/OSGP/Protocol-Adapter-DLMS","homepage":"http://www.opensmartgridplatform.org/","size":9407,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"development"}},"base":{"label":"OSGP:development","ref":"development","sha":"9c5cdd84530ff081e438f9d18105f8e92849337b","user":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars3.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":33675294,"name":"Protocol-Adapter-DLMS","full_name":"OSGP/Protocol-Adapter-DLMS","owner":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars3.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Protocol-Adapter-DLMS","description":"Protocol adapter and device simulator for Device Language Message Specification protocol.","fork":false,"url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS","forks_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/forks","keys_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/teams","hooks_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/events","assignees_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/tags","blobs_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/languages","stargazers_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/subscription","commits_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/merges","archive_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/downloads","issues_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/releases{/id}","deployments_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/deployments","created_at":"2015-04-09T14:59:22Z","updated_at":"2017-04-14T14:38:09Z","pushed_at":"2017-05-30T09:33:34Z","git_url":"git://github.com/OSGP/Protocol-Adapter-DLMS.git","ssh_url":"[email protected]:OSGP/Protocol-Adapter-DLMS.git","clone_url":"https://github.com/OSGP/Protocol-Adapter-DLMS.git","svn_url":"https://github.com/OSGP/Protocol-Adapter-DLMS","homepage":"http://www.opensmartgridplatform.org/","size":9407,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/201"},"html":{"href":"https://github.com/OSGP/Protocol-Adapter-DLMS/pull/201"},"issue":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues/201"},"comments":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/statuses/a712c7583419e80611f2caca5c0fff36e791f189"}}}} | {
"id": 33675294,
"name": "OSGP/Protocol-Adapter-DLMS",
"url": "https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS"
} | {
"id": 6457709,
"login": "hannek24",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6457709?",
"url": "https://api.github.com/users/hannek24"
} | {
"id": 11352045,
"login": "OSGP",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11352045?",
"url": "https://api.github.com/orgs/OSGP"
} | 2017-05-30T09:34:00 | 5964699295 | {"actor":{"display_login":"hannek24"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/aces/Loris/pulls/comments/152830833","pull_request_review_id":78753498,"id":152830833,"diff_hunk":"@@ -669,62 +587,6 @@ class Utility\n return $arr;\n }\n \n- /**\n- * Now that Loris requires PHP >5.3 places that use this code should be\n- * updated to use a closure.\n- *\n- * Function (previously?) used by stats page(?) for map/reduce to extract\n- * the Test_name from all the rows returned from a database call and\n- * thereby convert from an array of the form\n- *\n- * array(0 => array('Test_name' => value))\n- *\n- * to\n- *\n- * array(0 => value)\n- *\n- *\n- * If this doesn't make sense, see note.\n- *\n- * @param array $Arr A row from an associative array based by array_map\n- *\n- * @return The name from the given array row.\n- * @note Function should be removed and code using it cleaned up.\n- * @cleanup\n- */","path":"php/libraries/Utility.class.inc","position":198,"original_position":198,"commit_id":"4271a29e124d1019d4a68d745930c69d724d800e","original_commit_id":"4271a29e124d1019d4a68d745930c69d724d800e","user":{"login":"ridz1208","id":15268287,"avatar_url":"https://avatars3.githubusercontent.com/u/15268287?v=4","gravatar_id":"","url":"https://api.github.com/users/ridz1208","html_url":"https://github.com/ridz1208","followers_url":"https://api.github.com/users/ridz1208/followers","following_url":"https://api.github.com/users/ridz1208/following{/other_user}","gists_url":"https://api.github.com/users/ridz1208/gists{/gist_id}","starred_url":"https://api.github.com/users/ridz1208/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ridz1208/subscriptions","organizations_url":"https://api.github.com/users/ridz1208/orgs","repos_url":"https://api.github.com/users/ridz1208/repos","events_url":"https://api.github.com/users/ridz1208/events{/privacy}","received_events_url":"https://api.github.com/users/ridz1208/received_events","type":"User","site_admin":false},"body":"confirmed not used","created_at":"2017-11-23T15:41:58Z","updated_at":"2017-11-23T15:41:58Z","html_url":"https://github.com/aces/Loris/pull/2913#discussion_r152830833","pull_request_url":"https://api.github.com/repos/aces/Loris/pulls/2913","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments/152830833"},"html":{"href":"https://github.com/aces/Loris/pull/2913#discussion_r152830833"},"pull_request":{"href":"https://api.github.com/repos/aces/Loris/pulls/2913"}}},"pull_request":{"url":"https://api.github.com/repos/aces/Loris/pulls/2913","id":127946289,"html_url":"https://github.com/aces/Loris/pull/2913","diff_url":"https://github.com/aces/Loris/pull/2913.diff","patch_url":"https://github.com/aces/Loris/pull/2913.patch","issue_url":"https://api.github.com/repos/aces/Loris/issues/2913","number":2913,"state":"open","locked":false,"title":"[Libraries] Remove unused functions from Utility and update cleanup comments","user":{"login":"johnsaigle","id":4022790,"avatar_url":"https://avatars0.githubusercontent.com/u/4022790?v=4","gravatar_id":"","url":"https://api.github.com/users/johnsaigle","html_url":"https://github.com/johnsaigle","followers_url":"https://api.github.com/users/johnsaigle/followers","following_url":"https://api.github.com/users/johnsaigle/following{/other_user}","gists_url":"https://api.github.com/users/johnsaigle/gists{/gist_id}","starred_url":"https://api.github.com/users/johnsaigle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnsaigle/subscriptions","organizations_url":"https://api.github.com/users/johnsaigle/orgs","repos_url":"https://api.github.com/users/johnsaigle/repos","events_url":"https://api.github.com/users/johnsaigle/events{/privacy}","received_events_url":"https://api.github.com/users/johnsaigle/received_events","type":"User","site_admin":false},"body":"- [x] Delete functions marked as unused in the function comments (and confirmed by a Github search).\r\n\r\n- [x] Update function comments to reflect some locations where they are used\r\n","created_at":"2017-06-28T15:06:38Z","updated_at":"2017-11-23T15:41:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d0a675a46169ae5008aff491b3fe63c954b7fce","assignee":null,"assignees":[],"requested_reviewers":[{"login":"driusan","id":498329,"avatar_url":"https://avatars0.githubusercontent.com/u/498329?v=4","gravatar_id":"","url":"https://api.github.com/users/driusan","html_url":"https://github.com/driusan","followers_url":"https://api.github.com/users/driusan/followers","following_url":"https://api.github.com/users/driusan/following{/other_user}","gists_url":"https://api.github.com/users/driusan/gists{/gist_id}","starred_url":"https://api.github.com/users/driusan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driusan/subscriptions","organizations_url":"https://api.github.com/users/driusan/orgs","repos_url":"https://api.github.com/users/driusan/repos","events_url":"https://api.github.com/users/driusan/events{/privacy}","received_events_url":"https://api.github.com/users/driusan/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/aces/Loris/milestones/21","html_url":"https://github.com/aces/Loris/milestone/21","labels_url":"https://api.github.com/repos/aces/Loris/milestones/21/labels","id":2855054,"number":21,"title":"20.0","description":"","creator":{"login":"ridz1208","id":15268287,"avatar_url":"https://avatars3.githubusercontent.com/u/15268287?v=4","gravatar_id":"","url":"https://api.github.com/users/ridz1208","html_url":"https://github.com/ridz1208","followers_url":"https://api.github.com/users/ridz1208/followers","following_url":"https://api.github.com/users/ridz1208/following{/other_user}","gists_url":"https://api.github.com/users/ridz1208/gists{/gist_id}","starred_url":"https://api.github.com/users/ridz1208/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ridz1208/subscriptions","organizations_url":"https://api.github.com/users/ridz1208/orgs","repos_url":"https://api.github.com/users/ridz1208/repos","events_url":"https://api.github.com/users/ridz1208/events{/privacy}","received_events_url":"https://api.github.com/users/ridz1208/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":2,"state":"open","created_at":"2017-10-20T19:10:53Z","updated_at":"2017-11-23T14:58:29Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/aces/Loris/pulls/2913/commits","review_comments_url":"https://api.github.com/repos/aces/Loris/pulls/2913/comments","review_comment_url":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aces/Loris/issues/2913/comments","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/4271a29e124d1019d4a68d745930c69d724d800e","head":{"label":"johnsaigle:170628-DeleteFromUtility","ref":"170628-DeleteFromUtility","sha":"4271a29e124d1019d4a68d745930c69d724d800e","user":{"login":"johnsaigle","id":4022790,"avatar_url":"https://avatars0.githubusercontent.com/u/4022790?v=4","gravatar_id":"","url":"https://api.github.com/users/johnsaigle","html_url":"https://github.com/johnsaigle","followers_url":"https://api.github.com/users/johnsaigle/followers","following_url":"https://api.github.com/users/johnsaigle/following{/other_user}","gists_url":"https://api.github.com/users/johnsaigle/gists{/gist_id}","starred_url":"https://api.github.com/users/johnsaigle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnsaigle/subscriptions","organizations_url":"https://api.github.com/users/johnsaigle/orgs","repos_url":"https://api.github.com/users/johnsaigle/repos","events_url":"https://api.github.com/users/johnsaigle/events{/privacy}","received_events_url":"https://api.github.com/users/johnsaigle/received_events","type":"User","site_admin":false},"repo":{"id":49739900,"name":"Loris","full_name":"johnsaigle/Loris","owner":{"login":"johnsaigle","id":4022790,"avatar_url":"https://avatars0.githubusercontent.com/u/4022790?v=4","gravatar_id":"","url":"https://api.github.com/users/johnsaigle","html_url":"https://github.com/johnsaigle","followers_url":"https://api.github.com/users/johnsaigle/followers","following_url":"https://api.github.com/users/johnsaigle/following{/other_user}","gists_url":"https://api.github.com/users/johnsaigle/gists{/gist_id}","starred_url":"https://api.github.com/users/johnsaigle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnsaigle/subscriptions","organizations_url":"https://api.github.com/users/johnsaigle/orgs","repos_url":"https://api.github.com/users/johnsaigle/repos","events_url":"https://api.github.com/users/johnsaigle/events{/privacy}","received_events_url":"https://api.github.com/users/johnsaigle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnsaigle/Loris","description":"LORIS is a web-accessible database solution for longitudinal multi-site studies.","fork":true,"url":"https://api.github.com/repos/johnsaigle/Loris","forks_url":"https://api.github.com/repos/johnsaigle/Loris/forks","keys_url":"https://api.github.com/repos/johnsaigle/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnsaigle/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnsaigle/Loris/teams","hooks_url":"https://api.github.com/repos/johnsaigle/Loris/hooks","issue_events_url":"https://api.github.com/repos/johnsaigle/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/johnsaigle/Loris/events","assignees_url":"https://api.github.com/repos/johnsaigle/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/johnsaigle/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/johnsaigle/Loris/tags","blobs_url":"https://api.github.com/repos/johnsaigle/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnsaigle/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnsaigle/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnsaigle/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnsaigle/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/johnsaigle/Loris/languages","stargazers_url":"https://api.github.com/repos/johnsaigle/Loris/stargazers","contributors_url":"https://api.github.com/repos/johnsaigle/Loris/contributors","subscribers_url":"https://api.github.com/repos/johnsaigle/Loris/subscribers","subscription_url":"https://api.github.com/repos/johnsaigle/Loris/subscription","commits_url":"https://api.github.com/repos/johnsaigle/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnsaigle/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnsaigle/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnsaigle/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnsaigle/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/johnsaigle/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnsaigle/Loris/merges","archive_url":"https://api.github.com/repos/johnsaigle/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnsaigle/Loris/downloads","issues_url":"https://api.github.com/repos/johnsaigle/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/johnsaigle/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/johnsaigle/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/johnsaigle/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnsaigle/Loris/labels{/name}","releases_url":"https://api.github.com/repos/johnsaigle/Loris/releases{/id}","deployments_url":"https://api.github.com/repos/johnsaigle/Loris/deployments","created_at":"2016-01-15T19:21:06Z","updated_at":"2016-01-15T19:21:09Z","pushed_at":"2017-11-12T03:19:28Z","git_url":"git://github.com/johnsaigle/Loris.git","ssh_url":"[email protected]:johnsaigle/Loris.git","clone_url":"https://github.com/johnsaigle/Loris.git","svn_url":"https://github.com/johnsaigle/Loris","homepage":"","size":70305,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"17.1-dev"}},"base":{"label":"aces:major","ref":"major","sha":"f1a5addf3c003ef86f934d7db493fc78bdc987bb","user":{"login":"aces","id":472868,"avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"repo":{"id":1125630,"name":"Loris","full_name":"aces/Loris","owner":{"login":"aces","id":472868,"avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aces/Loris","description":"LORIS is a web-accessible database solution for longitudinal multi-site studies.","fork":false,"url":"https://api.github.com/repos/aces/Loris","forks_url":"https://api.github.com/repos/aces/Loris/forks","keys_url":"https://api.github.com/repos/aces/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aces/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aces/Loris/teams","hooks_url":"https://api.github.com/repos/aces/Loris/hooks","issue_events_url":"https://api.github.com/repos/aces/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/aces/Loris/events","assignees_url":"https://api.github.com/repos/aces/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/aces/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/aces/Loris/tags","blobs_url":"https://api.github.com/repos/aces/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aces/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aces/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/aces/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/aces/Loris/languages","stargazers_url":"https://api.github.com/repos/aces/Loris/stargazers","contributors_url":"https://api.github.com/repos/aces/Loris/contributors","subscribers_url":"https://api.github.com/repos/aces/Loris/subscribers","subscription_url":"https://api.github.com/repos/aces/Loris/subscription","commits_url":"https://api.github.com/repos/aces/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/aces/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/aces/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/aces/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/aces/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/aces/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aces/Loris/merges","archive_url":"https://api.github.com/repos/aces/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aces/Loris/downloads","issues_url":"https://api.github.com/repos/aces/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/aces/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/aces/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/aces/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aces/Loris/labels{/name}","releases_url":"https://api.github.com/repos/aces/Loris/releases{/id}","deployments_url":"https://api.github.com/repos/aces/Loris/deployments","created_at":"2010-11-30T14:57:57Z","updated_at":"2017-11-22T08:42:17Z","pushed_at":"2017-11-23T15:02:04Z","git_url":"git://github.com/aces/Loris.git","ssh_url":"[email protected]:aces/Loris.git","clone_url":"https://github.com/aces/Loris.git","svn_url":"https://github.com/aces/Loris","homepage":"","size":72002,"stargazers_count":57,"watchers_count":57,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":89,"forks":81,"open_issues":89,"watchers":57,"default_branch":"minor"}},"_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/2913"},"html":{"href":"https://github.com/aces/Loris/pull/2913"},"issue":{"href":"https://api.github.com/repos/aces/Loris/issues/2913"},"comments":{"href":"https://api.github.com/repos/aces/Loris/issues/2913/comments"},"review_comments":{"href":"https://api.github.com/repos/aces/Loris/pulls/2913/comments"},"review_comment":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aces/Loris/pulls/2913/commits"},"statuses":{"href":"https://api.github.com/repos/aces/Loris/statuses/4271a29e124d1019d4a68d745930c69d724d800e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1125630,
"name": "aces/Loris",
"url": "https://api.github.com/repos/aces/Loris"
} | {
"id": 15268287,
"login": "ridz1208",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15268287?",
"url": "https://api.github.com/users/ridz1208"
} | {
"id": 472868,
"login": "aces",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/472868?",
"url": "https://api.github.com/orgs/aces"
} | 2017-11-23T15:41:58 | 6895947685 | {"actor":{"display_login":"ridz1208"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka-http/pulls/comments/118956896","pull_request_review_id":40796450,"id":118956896,"diff_hunk":"@@ -0,0 +1,52 @@\n+/*\n+ * Copyright 2015 Heiko Seeberger\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package akka.http\n+package scaladsl\n+package unmarshalling\n+\n+import akka.stream.scaladsl.{ Sink, Source }\n+import akka.util.ByteString\n+import org.scalatest.{ AsyncWordSpec, Matchers }\n+\n+final class LineParserSpec extends AsyncWordSpec with Matchers with BaseUnmarshallingSpec {\n+\n+ \"A LineParser\" should {","path":"akka-http-tests/src/test/scala/akka/http/scaladsl/unmarshalling/LineParserSpec.scala","position":27,"original_position":27,"commit_id":"15eaa792999c9bba9f19cc92c9cc738508f259e8","original_commit_id":"15eaa792999c9bba9f19cc92c9cc738508f259e8","user":{"login":"hseeberger","id":41911,"avatar_url":"https://avatars1.githubusercontent.com/u/41911?v=3","gravatar_id":"","url":"https://api.github.com/users/hseeberger","html_url":"https://github.com/hseeberger","followers_url":"https://api.github.com/users/hseeberger/followers","following_url":"https://api.github.com/users/hseeberger/following{/other_user}","gists_url":"https://api.github.com/users/hseeberger/gists{/gist_id}","starred_url":"https://api.github.com/users/hseeberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hseeberger/subscriptions","organizations_url":"https://api.github.com/users/hseeberger/orgs","repos_url":"https://api.github.com/users/hseeberger/repos","events_url":"https://api.github.com/users/hseeberger/events{/privacy}","received_events_url":"https://api.github.com/users/hseeberger/received_events","type":"User","site_admin":false},"body":"Ouch! Thanks for spotting!","created_at":"2017-05-29T15:33:58Z","updated_at":"2017-05-29T15:33:58Z","html_url":"https://github.com/akka/akka-http/pull/1116#discussion_r118956896","pull_request_url":"https://api.github.com/repos/akka/akka-http/pulls/1116","_links":{"self":{"href":"https://api.github.com/repos/akka/akka-http/pulls/comments/118956896"},"html":{"href":"https://github.com/akka/akka-http/pull/1116#discussion_r118956896"},"pull_request":{"href":"https://api.github.com/repos/akka/akka-http/pulls/1116"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka-http/pulls/1116","id":120048925,"html_url":"https://github.com/akka/akka-http/pull/1116","diff_url":"https://github.com/akka/akka-http/pull/1116.diff","patch_url":"https://github.com/akka/akka-http/pull/1116.patch","issue_url":"https://api.github.com/repos/akka/akka-http/issues/1116","number":1116,"state":"open","locked":false,"title":"Include Akka SSE","user":{"login":"hseeberger","id":41911,"avatar_url":"https://avatars1.githubusercontent.com/u/41911?v=3","gravatar_id":"","url":"https://api.github.com/users/hseeberger","html_url":"https://github.com/hseeberger","followers_url":"https://api.github.com/users/hseeberger/followers","following_url":"https://api.github.com/users/hseeberger/following{/other_user}","gists_url":"https://api.github.com/users/hseeberger/gists{/gist_id}","starred_url":"https://api.github.com/users/hseeberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hseeberger/subscriptions","organizations_url":"https://api.github.com/users/hseeberger/orgs","repos_url":"https://api.github.com/users/hseeberger/repos","events_url":"https://api.github.com/users/hseeberger/events{/privacy}","received_events_url":"https://api.github.com/users/hseeberger/received_events","type":"User","site_admin":false},"body":"Docs still need to be written, but before I'm going down that bumpy road I'd like to get the OK for the code.","created_at":"2017-05-11T08:15:33Z","updated_at":"2017-05-29T15:33:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82869e64542cd87383c9e3f98258447f7374cb39","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka-http/pulls/1116/commits","review_comments_url":"https://api.github.com/repos/akka/akka-http/pulls/1116/comments","review_comment_url":"https://api.github.com/repos/akka/akka-http/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka-http/issues/1116/comments","statuses_url":"https://api.github.com/repos/akka/akka-http/statuses/15eaa792999c9bba9f19cc92c9cc738508f259e8","head":{"label":"hseeberger:669-include-akka-sse","ref":"669-include-akka-sse","sha":"15eaa792999c9bba9f19cc92c9cc738508f259e8","user":{"login":"hseeberger","id":41911,"avatar_url":"https://avatars1.githubusercontent.com/u/41911?v=3","gravatar_id":"","url":"https://api.github.com/users/hseeberger","html_url":"https://github.com/hseeberger","followers_url":"https://api.github.com/users/hseeberger/followers","following_url":"https://api.github.com/users/hseeberger/following{/other_user}","gists_url":"https://api.github.com/users/hseeberger/gists{/gist_id}","starred_url":"https://api.github.com/users/hseeberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hseeberger/subscriptions","organizations_url":"https://api.github.com/users/hseeberger/orgs","repos_url":"https://api.github.com/users/hseeberger/repos","events_url":"https://api.github.com/users/hseeberger/events{/privacy}","received_events_url":"https://api.github.com/users/hseeberger/received_events","type":"User","site_admin":false},"repo":{"id":70709906,"name":"akka-http","full_name":"hseeberger/akka-http","owner":{"login":"hseeberger","id":41911,"avatar_url":"https://avatars1.githubusercontent.com/u/41911?v=3","gravatar_id":"","url":"https://api.github.com/users/hseeberger","html_url":"https://github.com/hseeberger","followers_url":"https://api.github.com/users/hseeberger/followers","following_url":"https://api.github.com/users/hseeberger/following{/other_user}","gists_url":"https://api.github.com/users/hseeberger/gists{/gist_id}","starred_url":"https://api.github.com/users/hseeberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hseeberger/subscriptions","organizations_url":"https://api.github.com/users/hseeberger/orgs","repos_url":"https://api.github.com/users/hseeberger/repos","events_url":"https://api.github.com/users/hseeberger/events{/privacy}","received_events_url":"https://api.github.com/users/hseeberger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hseeberger/akka-http","description":"The Streaming-first HTTP server/module of Akka","fork":true,"url":"https://api.github.com/repos/hseeberger/akka-http","forks_url":"https://api.github.com/repos/hseeberger/akka-http/forks","keys_url":"https://api.github.com/repos/hseeberger/akka-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hseeberger/akka-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hseeberger/akka-http/teams","hooks_url":"https://api.github.com/repos/hseeberger/akka-http/hooks","issue_events_url":"https://api.github.com/repos/hseeberger/akka-http/issues/events{/number}","events_url":"https://api.github.com/repos/hseeberger/akka-http/events","assignees_url":"https://api.github.com/repos/hseeberger/akka-http/assignees{/user}","branches_url":"https://api.github.com/repos/hseeberger/akka-http/branches{/branch}","tags_url":"https://api.github.com/repos/hseeberger/akka-http/tags","blobs_url":"https://api.github.com/repos/hseeberger/akka-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hseeberger/akka-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hseeberger/akka-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/hseeberger/akka-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hseeberger/akka-http/statuses/{sha}","languages_url":"https://api.github.com/repos/hseeberger/akka-http/languages","stargazers_url":"https://api.github.com/repos/hseeberger/akka-http/stargazers","contributors_url":"https://api.github.com/repos/hseeberger/akka-http/contributors","subscribers_url":"https://api.github.com/repos/hseeberger/akka-http/subscribers","subscription_url":"https://api.github.com/repos/hseeberger/akka-http/subscription","commits_url":"https://api.github.com/repos/hseeberger/akka-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/hseeberger/akka-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/hseeberger/akka-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/hseeberger/akka-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/hseeberger/akka-http/contents/{+path}","compare_url":"https://api.github.com/repos/hseeberger/akka-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hseeberger/akka-http/merges","archive_url":"https://api.github.com/repos/hseeberger/akka-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hseeberger/akka-http/downloads","issues_url":"https://api.github.com/repos/hseeberger/akka-http/issues{/number}","pulls_url":"https://api.github.com/repos/hseeberger/akka-http/pulls{/number}","milestones_url":"https://api.github.com/repos/hseeberger/akka-http/milestones{/number}","notifications_url":"https://api.github.com/repos/hseeberger/akka-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hseeberger/akka-http/labels{/name}","releases_url":"https://api.github.com/repos/hseeberger/akka-http/releases{/id}","deployments_url":"https://api.github.com/repos/hseeberger/akka-http/deployments","created_at":"2016-10-12T14:47:47Z","updated_at":"2016-10-12T14:47:51Z","pushed_at":"2017-05-13T11:56:27Z","git_url":"git://github.com/hseeberger/akka-http.git","ssh_url":"[email protected]:hseeberger/akka-http.git","clone_url":"https://github.com/hseeberger/akka-http.git","svn_url":"https://github.com/hseeberger/akka-http","homepage":"http://akka.io","size":9231,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"59919c69c2c711f61d6b50d8f3a712dac06db2d6","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars1.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":66077955,"name":"akka-http","full_name":"akka/akka-http","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars1.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka-http","description":"The Streaming-first HTTP server/module of Akka","fork":false,"url":"https://api.github.com/repos/akka/akka-http","forks_url":"https://api.github.com/repos/akka/akka-http/forks","keys_url":"https://api.github.com/repos/akka/akka-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka-http/teams","hooks_url":"https://api.github.com/repos/akka/akka-http/hooks","issue_events_url":"https://api.github.com/repos/akka/akka-http/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka-http/events","assignees_url":"https://api.github.com/repos/akka/akka-http/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka-http/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka-http/tags","blobs_url":"https://api.github.com/repos/akka/akka-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka-http/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka-http/languages","stargazers_url":"https://api.github.com/repos/akka/akka-http/stargazers","contributors_url":"https://api.github.com/repos/akka/akka-http/contributors","subscribers_url":"https://api.github.com/repos/akka/akka-http/subscribers","subscription_url":"https://api.github.com/repos/akka/akka-http/subscription","commits_url":"https://api.github.com/repos/akka/akka-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka-http/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka-http/merges","archive_url":"https://api.github.com/repos/akka/akka-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka-http/downloads","issues_url":"https://api.github.com/repos/akka/akka-http/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka-http/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka-http/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka-http/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka-http/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka-http/deployments","created_at":"2016-08-19T11:33:36Z","updated_at":"2017-05-28T23:34:59Z","pushed_at":"2017-05-29T15:08:26Z","git_url":"git://github.com/akka/akka-http.git","ssh_url":"[email protected]:akka/akka-http.git","clone_url":"https://github.com/akka/akka-http.git","svn_url":"https://github.com/akka/akka-http","homepage":"http://akka.io","size":7817,"stargazers_count":350,"watchers_count":350,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":151,"mirror_url":null,"open_issues_count":392,"forks":151,"open_issues":392,"watchers":350,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka-http/pulls/1116"},"html":{"href":"https://github.com/akka/akka-http/pull/1116"},"issue":{"href":"https://api.github.com/repos/akka/akka-http/issues/1116"},"comments":{"href":"https://api.github.com/repos/akka/akka-http/issues/1116/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka-http/pulls/1116/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka-http/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka-http/pulls/1116/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka-http/statuses/15eaa792999c9bba9f19cc92c9cc738508f259e8"}}}} | {
"id": 66077955,
"name": "akka/akka-http",
"url": "https://api.github.com/repos/akka/akka-http"
} | {
"id": 41911,
"login": "hseeberger",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/41911?",
"url": "https://api.github.com/users/hseeberger"
} | {
"id": 1496237,
"login": "akka",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1496237?",
"url": "https://api.github.com/orgs/akka"
} | 2017-05-29T15:33:58 | 5960956069 | {"actor":{"display_login":"hseeberger"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/101693289","pull_request_review_id":22429689,"id":101693289,"diff_hunk":"@@ -427,9 +427,6 @@ int Pipe::accept()\n goto fail_unlocked;\n }\n \n- // sanitize features\n- connect.features = connect.features;\n-","path":"src/msg/simple/Pipe.cc","position":6,"original_position":6,"commit_id":"aa7740770ba924dd43ff8ab5b22f5ca5c0ee9da7","original_commit_id":"f8a959306e9351b87b946d8672adc4ce26d9183b","user":{"login":"gregsfortytwo","id":908479,"avatar_url":"https://avatars.githubusercontent.com/u/908479?v=3","gravatar_id":"","url":"https://api.github.com/users/gregsfortytwo","html_url":"https://github.com/gregsfortytwo","followers_url":"https://api.github.com/users/gregsfortytwo/followers","following_url":"https://api.github.com/users/gregsfortytwo/following{/other_user}","gists_url":"https://api.github.com/users/gregsfortytwo/gists{/gist_id}","starred_url":"https://api.github.com/users/gregsfortytwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregsfortytwo/subscriptions","organizations_url":"https://api.github.com/users/gregsfortytwo/orgs","repos_url":"https://api.github.com/users/gregsfortytwo/repos","events_url":"https://api.github.com/users/gregsfortytwo/events{/privacy}","received_events_url":"https://api.github.com/users/gregsfortytwo/received_events","type":"User","site_admin":false},"body":"Did you check the history on these? I don't recognize them but the warning made me concerned they are meant to do something (say, sanitize the feature list into something we understand?) via C++ magic that has failed.","created_at":"2017-02-17T06:27:57Z","updated_at":"2017-02-17T06:27:57Z","html_url":"https://github.com/ceph/ceph/pull/13473#discussion_r101693289","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/13473","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/101693289"},"html":{"href":"https://github.com/ceph/ceph/pull/13473#discussion_r101693289"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/13473"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/13473","id":106669985,"html_url":"https://github.com/ceph/ceph/pull/13473","diff_url":"https://github.com/ceph/ceph/pull/13473.diff","patch_url":"https://github.com/ceph/ceph/pull/13473.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/13473","number":13473,"state":"open","locked":false,"title":"msg, rbd-nbd, messages: coverity fixes","user":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-17T05:15:44Z","updated_at":"2017-02-17T06:27:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c4e0ef5b033e0164b248c9ef97a51ef4922bd75","assignee":{"login":"badone","id":1331115,"avatar_url":"https://avatars.githubusercontent.com/u/1331115?v=3","gravatar_id":"","url":"https://api.github.com/users/badone","html_url":"https://github.com/badone","followers_url":"https://api.github.com/users/badone/followers","following_url":"https://api.github.com/users/badone/following{/other_user}","gists_url":"https://api.github.com/users/badone/gists{/gist_id}","starred_url":"https://api.github.com/users/badone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badone/subscriptions","organizations_url":"https://api.github.com/users/badone/orgs","repos_url":"https://api.github.com/users/badone/repos","events_url":"https://api.github.com/users/badone/events{/privacy}","received_events_url":"https://api.github.com/users/badone/received_events","type":"User","site_admin":false},"assignees":[{"login":"badone","id":1331115,"avatar_url":"https://avatars.githubusercontent.com/u/1331115?v=3","gravatar_id":"","url":"https://api.github.com/users/badone","html_url":"https://github.com/badone","followers_url":"https://api.github.com/users/badone/followers","following_url":"https://api.github.com/users/badone/following{/other_user}","gists_url":"https://api.github.com/users/badone/gists{/gist_id}","starred_url":"https://api.github.com/users/badone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badone/subscriptions","organizations_url":"https://api.github.com/users/badone/orgs","repos_url":"https://api.github.com/users/badone/repos","events_url":"https://api.github.com/users/badone/events{/privacy}","received_events_url":"https://api.github.com/users/badone/received_events","type":"User","site_admin":false},{"login":"dillaman","id":4739042,"avatar_url":"https://avatars.githubusercontent.com/u/4739042?v=3","gravatar_id":"","url":"https://api.github.com/users/dillaman","html_url":"https://github.com/dillaman","followers_url":"https://api.github.com/users/dillaman/followers","following_url":"https://api.github.com/users/dillaman/following{/other_user}","gists_url":"https://api.github.com/users/dillaman/gists{/gist_id}","starred_url":"https://api.github.com/users/dillaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dillaman/subscriptions","organizations_url":"https://api.github.com/users/dillaman/orgs","repos_url":"https://api.github.com/users/dillaman/repos","events_url":"https://api.github.com/users/dillaman/events{/privacy}","received_events_url":"https://api.github.com/users/dillaman/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/13473/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/13473/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/13473/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/aa7740770ba924dd43ff8ab5b22f5ca5c0ee9da7","head":{"label":"tchaikov:wip-coverity-fixes","ref":"wip-coverity-fixes","sha":"aa7740770ba924dd43ff8ab5b22f5ca5c0ee9da7","user":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"repo":{"id":26736928,"name":"ceph","full_name":"tchaikov/ceph","owner":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tchaikov/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/tchaikov/ceph","forks_url":"https://api.github.com/repos/tchaikov/ceph/forks","keys_url":"https://api.github.com/repos/tchaikov/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tchaikov/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tchaikov/ceph/teams","hooks_url":"https://api.github.com/repos/tchaikov/ceph/hooks","issue_events_url":"https://api.github.com/repos/tchaikov/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/tchaikov/ceph/events","assignees_url":"https://api.github.com/repos/tchaikov/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/tchaikov/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/tchaikov/ceph/tags","blobs_url":"https://api.github.com/repos/tchaikov/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tchaikov/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tchaikov/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/tchaikov/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tchaikov/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/tchaikov/ceph/languages","stargazers_url":"https://api.github.com/repos/tchaikov/ceph/stargazers","contributors_url":"https://api.github.com/repos/tchaikov/ceph/contributors","subscribers_url":"https://api.github.com/repos/tchaikov/ceph/subscribers","subscription_url":"https://api.github.com/repos/tchaikov/ceph/subscription","commits_url":"https://api.github.com/repos/tchaikov/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/tchaikov/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/tchaikov/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/tchaikov/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/tchaikov/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/tchaikov/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tchaikov/ceph/merges","archive_url":"https://api.github.com/repos/tchaikov/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tchaikov/ceph/downloads","issues_url":"https://api.github.com/repos/tchaikov/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/tchaikov/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/tchaikov/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/tchaikov/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tchaikov/ceph/labels{/name}","releases_url":"https://api.github.com/repos/tchaikov/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/tchaikov/ceph/deployments","created_at":"2014-11-17T02:40:21Z","updated_at":"2014-11-17T02:40:35Z","pushed_at":"2017-02-17T05:13:19Z","git_url":"git://github.com/tchaikov/ceph.git","ssh_url":"[email protected]:tchaikov/ceph.git","clone_url":"https://github.com/tchaikov/ceph.git","svn_url":"https://github.com/tchaikov/ceph","homepage":"http://ceph.com","size":197424,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"92e51fd9443bfadddf0f9f7ea8aebca74a104776","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2017-02-17T04:27:23Z","pushed_at":"2017-02-17T06:24:47Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"[email protected]:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":192817,"stargazers_count":2902,"watchers_count":2902,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1720,"mirror_url":null,"open_issues_count":429,"forks":1720,"open_issues":429,"watchers":2902,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/13473"},"html":{"href":"https://github.com/ceph/ceph/pull/13473"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/13473"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/13473/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/13473/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/13473/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/aa7740770ba924dd43ff8ab5b22f5ca5c0ee9da7"}}}} | {
"id": 2310495,
"name": "ceph/ceph",
"url": "https://api.github.com/repos/ceph/ceph"
} | {
"id": 908479,
"login": "gregsfortytwo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/908479?",
"url": "https://api.github.com/users/gregsfortytwo"
} | {
"id": 1015767,
"login": "ceph",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1015767?",
"url": "https://api.github.com/orgs/ceph"
} | 2017-02-17T06:27:57 | 5342086254 | {"actor":{"display_login":"gregsfortytwo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/chef/chef-server/pulls/comments/158336284","pull_request_review_id":85132806,"id":158336284,"diff_hunk":"@@ -8,6 +8,24 @@ This document contains release notes for the current major release and all patch\n For prior releases,\n see [PRIOR\\_RELEASE\\_NOTES.md](PRIOR_RELEASE_NOTES.md).\n \n+## 12.17.15 (2017-12-21)\n+\n+- Fix a regression in IPv6 address handling\n+- Allow disabling of reqeust logging\n+ - opscode-erchef['enable_request_logging'] defaults to true\n+ - oc_bifrost['enable_request_logging'] defaults to true\n+ - bookshelf['enable_request_logging'] defaults to false\n+ - bookshelf is a change from prior behavior as this logging is redundant with the existing nginx logs\n+- Fix permissions on gemfiles created with strict umask on reconfigure","path":"RELEASE_NOTES.md","position":12,"original_position":12,"commit_id":"767f94648f1027b952dc7bf78ae7be9011bb6094","original_commit_id":"767f94648f1027b952dc7bf78ae7be9011bb6094","user":{"login":"markan","id":253389,"avatar_url":"https://avatars3.githubusercontent.com/u/253389?v=4","gravatar_id":"","url":"https://api.github.com/users/markan","html_url":"https://github.com/markan","followers_url":"https://api.github.com/users/markan/followers","following_url":"https://api.github.com/users/markan/following{/other_user}","gists_url":"https://api.github.com/users/markan/gists{/gist_id}","starred_url":"https://api.github.com/users/markan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markan/subscriptions","organizations_url":"https://api.github.com/users/markan/orgs","repos_url":"https://api.github.com/users/markan/repos","events_url":"https://api.github.com/users/markan/events{/privacy}","received_events_url":"https://api.github.com/users/markan/received_events","type":"User","site_admin":false},"body":"Maybe \"Reconfigure fixes permissions on gems with overly restrictive umask\"","created_at":"2017-12-21T17:38:50Z","updated_at":"2017-12-21T17:39:05Z","html_url":"https://github.com/chef/chef-server/pull/1441#discussion_r158336284","pull_request_url":"https://api.github.com/repos/chef/chef-server/pulls/1441","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/chef/chef-server/pulls/comments/158336284"},"html":{"href":"https://github.com/chef/chef-server/pull/1441#discussion_r158336284"},"pull_request":{"href":"https://api.github.com/repos/chef/chef-server/pulls/1441"}}},"pull_request":{"url":"https://api.github.com/repos/chef/chef-server/pulls/1441","id":159712142,"html_url":"https://github.com/chef/chef-server/pull/1441","diff_url":"https://github.com/chef/chef-server/pull/1441.diff","patch_url":"https://github.com/chef/chef-server/pull/1441.patch","issue_url":"https://api.github.com/repos/chef/chef-server/issues/1441","number":1441,"state":"open","locked":false,"title":"Update RELEASE_NOTES.md for 12.17.15 release","user":{"login":"btm","id":4381,"avatar_url":"https://avatars3.githubusercontent.com/u/4381?v=4","gravatar_id":"","url":"https://api.github.com/users/btm","html_url":"https://github.com/btm","followers_url":"https://api.github.com/users/btm/followers","following_url":"https://api.github.com/users/btm/following{/other_user}","gists_url":"https://api.github.com/users/btm/gists{/gist_id}","starred_url":"https://api.github.com/users/btm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btm/subscriptions","organizations_url":"https://api.github.com/users/btm/orgs","repos_url":"https://api.github.com/users/btm/repos","events_url":"https://api.github.com/users/btm/events{/privacy}","received_events_url":"https://api.github.com/users/btm/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-21T17:34:27Z","updated_at":"2017-12-21T17:39:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e820738a7cfe8321388eb227e22a7cdff81d01d3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/chef/chef-server/pulls/1441/commits","review_comments_url":"https://api.github.com/repos/chef/chef-server/pulls/1441/comments","review_comment_url":"https://api.github.com/repos/chef/chef-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/chef-server/issues/1441/comments","statuses_url":"https://api.github.com/repos/chef/chef-server/statuses/767f94648f1027b952dc7bf78ae7be9011bb6094","head":{"label":"chef:release-121715","ref":"release-121715","sha":"767f94648f1027b952dc7bf78ae7be9011bb6094","user":{"login":"chef","id":29740,"avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":24732433,"name":"chef-server","full_name":"chef/chef-server","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef-server","description":"The Chef Server ","fork":false,"url":"https://api.github.com/repos/chef/chef-server","forks_url":"https://api.github.com/repos/chef/chef-server/forks","keys_url":"https://api.github.com/repos/chef/chef-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-server/teams","hooks_url":"https://api.github.com/repos/chef/chef-server/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-server/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-server/events","assignees_url":"https://api.github.com/repos/chef/chef-server/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-server/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-server/tags","blobs_url":"https://api.github.com/repos/chef/chef-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-server/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-server/languages","stargazers_url":"https://api.github.com/repos/chef/chef-server/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-server/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-server/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-server/subscription","commits_url":"https://api.github.com/repos/chef/chef-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-server/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-server/merges","archive_url":"https://api.github.com/repos/chef/chef-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-server/downloads","issues_url":"https://api.github.com/repos/chef/chef-server/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-server/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-server/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-server/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-server/releases{/id}","deployments_url":"https://api.github.com/repos/chef/chef-server/deployments","created_at":"2014-10-02T19:04:18Z","updated_at":"2017-12-16T18:41:22Z","pushed_at":"2017-12-21T17:34:28Z","git_url":"git://github.com/chef/chef-server.git","ssh_url":"[email protected]:chef/chef-server.git","clone_url":"https://github.com/chef/chef-server.git","svn_url":"https://github.com/chef/chef-server","homepage":"https://www.chef.io/chef/","size":30199,"stargazers_count":154,"watchers_count":154,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"archived":false,"open_issues_count":210,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":101,"open_issues":210,"watchers":154,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"15340a4c6093bc0a2030017fc152b19bb251e1db","user":{"login":"chef","id":29740,"avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":24732433,"name":"chef-server","full_name":"chef/chef-server","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef-server","description":"The Chef Server ","fork":false,"url":"https://api.github.com/repos/chef/chef-server","forks_url":"https://api.github.com/repos/chef/chef-server/forks","keys_url":"https://api.github.com/repos/chef/chef-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-server/teams","hooks_url":"https://api.github.com/repos/chef/chef-server/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-server/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-server/events","assignees_url":"https://api.github.com/repos/chef/chef-server/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-server/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-server/tags","blobs_url":"https://api.github.com/repos/chef/chef-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-server/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-server/languages","stargazers_url":"https://api.github.com/repos/chef/chef-server/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-server/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-server/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-server/subscription","commits_url":"https://api.github.com/repos/chef/chef-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-server/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-server/merges","archive_url":"https://api.github.com/repos/chef/chef-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-server/downloads","issues_url":"https://api.github.com/repos/chef/chef-server/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-server/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-server/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-server/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-server/releases{/id}","deployments_url":"https://api.github.com/repos/chef/chef-server/deployments","created_at":"2014-10-02T19:04:18Z","updated_at":"2017-12-16T18:41:22Z","pushed_at":"2017-12-21T17:34:28Z","git_url":"git://github.com/chef/chef-server.git","ssh_url":"[email protected]:chef/chef-server.git","clone_url":"https://github.com/chef/chef-server.git","svn_url":"https://github.com/chef/chef-server","homepage":"https://www.chef.io/chef/","size":30199,"stargazers_count":154,"watchers_count":154,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"archived":false,"open_issues_count":210,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":101,"open_issues":210,"watchers":154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/chef-server/pulls/1441"},"html":{"href":"https://github.com/chef/chef-server/pull/1441"},"issue":{"href":"https://api.github.com/repos/chef/chef-server/issues/1441"},"comments":{"href":"https://api.github.com/repos/chef/chef-server/issues/1441/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/chef-server/pulls/1441/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/chef-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/chef-server/pulls/1441/commits"},"statuses":{"href":"https://api.github.com/repos/chef/chef-server/statuses/767f94648f1027b952dc7bf78ae7be9011bb6094"}},"author_association":"OWNER"}} | {
"id": 24732433,
"name": "chef/chef-server",
"url": "https://api.github.com/repos/chef/chef-server"
} | {
"id": 253389,
"login": "markan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/253389?",
"url": "https://api.github.com/users/markan"
} | {
"id": 29740,
"login": "chef",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29740?",
"url": "https://api.github.com/orgs/chef"
} | 2017-12-21T17:38:50 | 7019541829 | {"actor":{"display_login":"markan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dadi/publish/pulls/comments/102494071","pull_request_review_id":23250164,"id":102494071,"diff_hunk":"@@ -0,0 +1,32 @@\n+'use strict'\n+\n+const fs = require('fs')\n+const convict = require('convict')\n+const path = require('path')\n+\n+const Watch = function () {\n+ this.root = process.cwd()\n+}\n+\n+Watch.prototype.getConfig = function (config) {\n+ let conf = convict(config.root())\n+ let env = config.get('env')\n+ try {\n+ conf.loadFile(path.resolve(`${this.root}/config/config.${env}.json`))\n+ } catch (e) {\n+ console.log('Failed to load config, dropping to app defaults.')\n+ return config\n+ }\n+ return conf.validate({})","path":"dadi/lib/watch/index.js","position":20,"original_position":20,"commit_id":"5cd57984f49cef6e004dada8c4ff4e04a79e09a6","original_commit_id":"5cd57984f49cef6e004dada8c4ff4e04a79e09a6","user":{"login":"eduardoboucas","id":4162329,"avatar_url":"https://avatars.githubusercontent.com/u/4162329?v=3","gravatar_id":"","url":"https://api.github.com/users/eduardoboucas","html_url":"https://github.com/eduardoboucas","followers_url":"https://api.github.com/users/eduardoboucas/followers","following_url":"https://api.github.com/users/eduardoboucas/following{/other_user}","gists_url":"https://api.github.com/users/eduardoboucas/gists{/gist_id}","starred_url":"https://api.github.com/users/eduardoboucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduardoboucas/subscriptions","organizations_url":"https://api.github.com/users/eduardoboucas/orgs","repos_url":"https://api.github.com/users/eduardoboucas/repos","events_url":"https://api.github.com/users/eduardoboucas/events{/privacy}","received_events_url":"https://api.github.com/users/eduardoboucas/received_events","type":"User","site_admin":false},"body":"Blank line here.","created_at":"2017-02-22T15:44:36Z","updated_at":"2017-02-22T15:45:10Z","html_url":"https://github.com/dadi/publish/pull/27#discussion_r102494071","pull_request_url":"https://api.github.com/repos/dadi/publish/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/dadi/publish/pulls/comments/102494071"},"html":{"href":"https://github.com/dadi/publish/pull/27#discussion_r102494071"},"pull_request":{"href":"https://api.github.com/repos/dadi/publish/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/dadi/publish/pulls/27","id":107390158,"html_url":"https://github.com/dadi/publish/pull/27","diff_url":"https://github.com/dadi/publish/pull/27.diff","patch_url":"https://github.com/dadi/publish/pull/27.patch","issue_url":"https://api.github.com/repos/dadi/publish/issues/27","number":27,"state":"open","locked":false,"title":"feat: Document filters","user":{"login":"mingard","id":1352469,"avatar_url":"https://avatars.githubusercontent.com/u/1352469?v=3","gravatar_id":"","url":"https://api.github.com/users/mingard","html_url":"https://github.com/mingard","followers_url":"https://api.github.com/users/mingard/followers","following_url":"https://api.github.com/users/mingard/following{/other_user}","gists_url":"https://api.github.com/users/mingard/gists{/gist_id}","starred_url":"https://api.github.com/users/mingard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingard/subscriptions","organizations_url":"https://api.github.com/users/mingard/orgs","repos_url":"https://api.github.com/users/mingard/repos","events_url":"https://api.github.com/users/mingard/events{/privacy}","received_events_url":"https://api.github.com/users/mingard/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-22T11:46:47Z","updated_at":"2017-02-22T15:45:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4cbb641f0d46fdf7eb9da99f71359bbd29678510","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dadi/publish/pulls/27/commits","review_comments_url":"https://api.github.com/repos/dadi/publish/pulls/27/comments","review_comment_url":"https://api.github.com/repos/dadi/publish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dadi/publish/issues/27/comments","statuses_url":"https://api.github.com/repos/dadi/publish/statuses/5cd57984f49cef6e004dada8c4ff4e04a79e09a6","head":{"label":"dadi:feat/doc-filters","ref":"feat/doc-filters","sha":"5cd57984f49cef6e004dada8c4ff4e04a79e09a6","user":{"login":"dadi","id":30811,"avatar_url":"https://avatars.githubusercontent.com/u/30811?v=3","gravatar_id":"","url":"https://api.github.com/users/dadi","html_url":"https://github.com/dadi","followers_url":"https://api.github.com/users/dadi/followers","following_url":"https://api.github.com/users/dadi/following{/other_user}","gists_url":"https://api.github.com/users/dadi/gists{/gist_id}","starred_url":"https://api.github.com/users/dadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadi/subscriptions","organizations_url":"https://api.github.com/users/dadi/orgs","repos_url":"https://api.github.com/users/dadi/repos","events_url":"https://api.github.com/users/dadi/events{/privacy}","received_events_url":"https://api.github.com/users/dadi/received_events","type":"Organization","site_admin":false},"repo":{"id":80906688,"name":"publish","full_name":"dadi/publish","owner":{"login":"dadi","id":30811,"avatar_url":"https://avatars.githubusercontent.com/u/30811?v=3","gravatar_id":"","url":"https://api.github.com/users/dadi","html_url":"https://github.com/dadi","followers_url":"https://api.github.com/users/dadi/followers","following_url":"https://api.github.com/users/dadi/following{/other_user}","gists_url":"https://api.github.com/users/dadi/gists{/gist_id}","starred_url":"https://api.github.com/users/dadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadi/subscriptions","organizations_url":"https://api.github.com/users/dadi/orgs","repos_url":"https://api.github.com/users/dadi/repos","events_url":"https://api.github.com/users/dadi/events{/privacy}","received_events_url":"https://api.github.com/users/dadi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dadi/publish","description":"Publish provides a headless interface for the management of content within DADI API","fork":false,"url":"https://api.github.com/repos/dadi/publish","forks_url":"https://api.github.com/repos/dadi/publish/forks","keys_url":"https://api.github.com/repos/dadi/publish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dadi/publish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dadi/publish/teams","hooks_url":"https://api.github.com/repos/dadi/publish/hooks","issue_events_url":"https://api.github.com/repos/dadi/publish/issues/events{/number}","events_url":"https://api.github.com/repos/dadi/publish/events","assignees_url":"https://api.github.com/repos/dadi/publish/assignees{/user}","branches_url":"https://api.github.com/repos/dadi/publish/branches{/branch}","tags_url":"https://api.github.com/repos/dadi/publish/tags","blobs_url":"https://api.github.com/repos/dadi/publish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dadi/publish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dadi/publish/git/refs{/sha}","trees_url":"https://api.github.com/repos/dadi/publish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dadi/publish/statuses/{sha}","languages_url":"https://api.github.com/repos/dadi/publish/languages","stargazers_url":"https://api.github.com/repos/dadi/publish/stargazers","contributors_url":"https://api.github.com/repos/dadi/publish/contributors","subscribers_url":"https://api.github.com/repos/dadi/publish/subscribers","subscription_url":"https://api.github.com/repos/dadi/publish/subscription","commits_url":"https://api.github.com/repos/dadi/publish/commits{/sha}","git_commits_url":"https://api.github.com/repos/dadi/publish/git/commits{/sha}","comments_url":"https://api.github.com/repos/dadi/publish/comments{/number}","issue_comment_url":"https://api.github.com/repos/dadi/publish/issues/comments{/number}","contents_url":"https://api.github.com/repos/dadi/publish/contents/{+path}","compare_url":"https://api.github.com/repos/dadi/publish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dadi/publish/merges","archive_url":"https://api.github.com/repos/dadi/publish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dadi/publish/downloads","issues_url":"https://api.github.com/repos/dadi/publish/issues{/number}","pulls_url":"https://api.github.com/repos/dadi/publish/pulls{/number}","milestones_url":"https://api.github.com/repos/dadi/publish/milestones{/number}","notifications_url":"https://api.github.com/repos/dadi/publish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dadi/publish/labels{/name}","releases_url":"https://api.github.com/repos/dadi/publish/releases{/id}","deployments_url":"https://api.github.com/repos/dadi/publish/deployments","created_at":"2017-02-04T08:46:07Z","updated_at":"2017-02-20T14:04:47Z","pushed_at":"2017-02-22T15:42:23Z","git_url":"git://github.com/dadi/publish.git","ssh_url":"[email protected]:dadi/publish.git","clone_url":"https://github.com/dadi/publish.git","svn_url":"https://github.com/dadi/publish","homepage":"","size":5591,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"dadi:master","ref":"master","sha":"53d00e610b7593d10f3e56c51d4606c4f75c065a","user":{"login":"dadi","id":30811,"avatar_url":"https://avatars.githubusercontent.com/u/30811?v=3","gravatar_id":"","url":"https://api.github.com/users/dadi","html_url":"https://github.com/dadi","followers_url":"https://api.github.com/users/dadi/followers","following_url":"https://api.github.com/users/dadi/following{/other_user}","gists_url":"https://api.github.com/users/dadi/gists{/gist_id}","starred_url":"https://api.github.com/users/dadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadi/subscriptions","organizations_url":"https://api.github.com/users/dadi/orgs","repos_url":"https://api.github.com/users/dadi/repos","events_url":"https://api.github.com/users/dadi/events{/privacy}","received_events_url":"https://api.github.com/users/dadi/received_events","type":"Organization","site_admin":false},"repo":{"id":80906688,"name":"publish","full_name":"dadi/publish","owner":{"login":"dadi","id":30811,"avatar_url":"https://avatars.githubusercontent.com/u/30811?v=3","gravatar_id":"","url":"https://api.github.com/users/dadi","html_url":"https://github.com/dadi","followers_url":"https://api.github.com/users/dadi/followers","following_url":"https://api.github.com/users/dadi/following{/other_user}","gists_url":"https://api.github.com/users/dadi/gists{/gist_id}","starred_url":"https://api.github.com/users/dadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadi/subscriptions","organizations_url":"https://api.github.com/users/dadi/orgs","repos_url":"https://api.github.com/users/dadi/repos","events_url":"https://api.github.com/users/dadi/events{/privacy}","received_events_url":"https://api.github.com/users/dadi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dadi/publish","description":"Publish provides a headless interface for the management of content within DADI API","fork":false,"url":"https://api.github.com/repos/dadi/publish","forks_url":"https://api.github.com/repos/dadi/publish/forks","keys_url":"https://api.github.com/repos/dadi/publish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dadi/publish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dadi/publish/teams","hooks_url":"https://api.github.com/repos/dadi/publish/hooks","issue_events_url":"https://api.github.com/repos/dadi/publish/issues/events{/number}","events_url":"https://api.github.com/repos/dadi/publish/events","assignees_url":"https://api.github.com/repos/dadi/publish/assignees{/user}","branches_url":"https://api.github.com/repos/dadi/publish/branches{/branch}","tags_url":"https://api.github.com/repos/dadi/publish/tags","blobs_url":"https://api.github.com/repos/dadi/publish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dadi/publish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dadi/publish/git/refs{/sha}","trees_url":"https://api.github.com/repos/dadi/publish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dadi/publish/statuses/{sha}","languages_url":"https://api.github.com/repos/dadi/publish/languages","stargazers_url":"https://api.github.com/repos/dadi/publish/stargazers","contributors_url":"https://api.github.com/repos/dadi/publish/contributors","subscribers_url":"https://api.github.com/repos/dadi/publish/subscribers","subscription_url":"https://api.github.com/repos/dadi/publish/subscription","commits_url":"https://api.github.com/repos/dadi/publish/commits{/sha}","git_commits_url":"https://api.github.com/repos/dadi/publish/git/commits{/sha}","comments_url":"https://api.github.com/repos/dadi/publish/comments{/number}","issue_comment_url":"https://api.github.com/repos/dadi/publish/issues/comments{/number}","contents_url":"https://api.github.com/repos/dadi/publish/contents/{+path}","compare_url":"https://api.github.com/repos/dadi/publish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dadi/publish/merges","archive_url":"https://api.github.com/repos/dadi/publish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dadi/publish/downloads","issues_url":"https://api.github.com/repos/dadi/publish/issues{/number}","pulls_url":"https://api.github.com/repos/dadi/publish/pulls{/number}","milestones_url":"https://api.github.com/repos/dadi/publish/milestones{/number}","notifications_url":"https://api.github.com/repos/dadi/publish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dadi/publish/labels{/name}","releases_url":"https://api.github.com/repos/dadi/publish/releases{/id}","deployments_url":"https://api.github.com/repos/dadi/publish/deployments","created_at":"2017-02-04T08:46:07Z","updated_at":"2017-02-20T14:04:47Z","pushed_at":"2017-02-22T15:42:23Z","git_url":"git://github.com/dadi/publish.git","ssh_url":"[email protected]:dadi/publish.git","clone_url":"https://github.com/dadi/publish.git","svn_url":"https://github.com/dadi/publish","homepage":"","size":5591,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dadi/publish/pulls/27"},"html":{"href":"https://github.com/dadi/publish/pull/27"},"issue":{"href":"https://api.github.com/repos/dadi/publish/issues/27"},"comments":{"href":"https://api.github.com/repos/dadi/publish/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/dadi/publish/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/dadi/publish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dadi/publish/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/dadi/publish/statuses/5cd57984f49cef6e004dada8c4ff4e04a79e09a6"}}}} | {
"id": 80906688,
"name": "dadi/publish",
"url": "https://api.github.com/repos/dadi/publish"
} | {
"id": 4162329,
"login": "eduardoboucas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4162329?",
"url": "https://api.github.com/users/eduardoboucas"
} | {
"id": 30811,
"login": "dadi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30811?",
"url": "https://api.github.com/orgs/dadi"
} | 2017-02-22T15:44:36 | 5371000728 | {"actor":{"display_login":"eduardoboucas"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dask/dask/pulls/comments/136991418","pull_request_review_id":60601642,"id":136991418,"diff_hunk":"@@ -2233,6 +2233,259 @@ def unpack_singleton(x):\n return x\n \n \n+class _Recurser(object):\n+ \"\"\"\n+ Utility class for recursing over nested iterables\n+ \"\"\"\n+ def __init__(self, recurse_if):\n+ self.recurse_if = recurse_if\n+\n+ def map_reduce(self,\n+ x,\n+ f_map=lambda x, **kwargs: x,\n+ f_reduce=lambda x, **kwargs: x,\n+ f_kwargs=lambda **kwargs: kwargs,\n+ **kwargs):\n+ \"\"\"\n+ Iterate over the nested list, applying:\n+ * ``f_map`` (T -> U) to items\n+ * ``f_reduce`` (Iterable[U] -> U) to mapped items\n+\n+ For instance, ``map_reduce([[1, 2], 3, 4])`` is::\n+\n+ f_reduce([\n+ f_reduce([\n+ f_map(1),\n+ f_map(2)\n+ ]),\n+ f_map(3),\n+ f_map(4)\n+ ]])\n+\n+\n+ State can be passed down through the calls with `f_kwargs`,\n+ to iterables of mapped items. When kwargs are passed, as in\n+ ``map_reduce([[1, 2], 3, 4], **kw)``, this becomes::\n+\n+ kw1 = f_kwargs(**kw)\n+ kw2 = f_kwargs(**kw1)\n+ f_reduce([\n+ f_reduce([\n+ f_map(1), **kw2)\n+ f_map(2, **kw2)\n+ ], **kw1),\n+ f_map(3, **kw1),\n+ f_map(4, **kw1)\n+ ]], **kw)\n+ \"\"\"\n+ def f(x, **kwargs):\n+ if not self.recurse_if(x):\n+ return f_map(x, **kwargs)\n+ else:\n+ next_kwargs = f_kwargs(**kwargs)\n+ return f_reduce((\n+ f(xi, **next_kwargs)\n+ for xi in x\n+ ), **kwargs)\n+ return f(x, **kwargs)\n+\n+ def walk(self, x, index=()):\n+ \"\"\"\n+ Iterate over x, yielding (index, value, entering), where\n+\n+ * ``index``: a tuple of indices up to this point\n+ * ``value``: equal to ``x[index[0]][...][index[-1]]``. On the first iteration, is\n+ ``x`` itself\n+ * ``entering``: bool. The result of ``recurse_if(value)``\n+ \"\"\"\n+ do_recurse = self.recurse_if(x)\n+ yield index, x, do_recurse\n+\n+ if not do_recurse:\n+ return\n+ for i, xi in enumerate(x):\n+ # yield from ...\n+ for v in self.walk(xi, index + (i,)):\n+ yield v\n+\n+\n+def block(arrays, allow_unknown_chunksizes=False):\n+ \"\"\"\n+ Assemble an nd-array from nested lists of blocks.\n+\n+ Blocks in the innermost lists are `concatenate`d along the last\n+ dimension (-1), then these are `concatenate`d along the second-last\n+ dimension (-2), and so on until the outermost list is reached\n+\n+ Blocks can be of any dimension, but will not be broadcasted using the normal\n+ rules. Instead, leading axes of size 1 are inserted, to make ``block.ndim``\n+ the same for all blocks. This is primarily useful for working with scalars,\n+ and means that code like ``block([v, 1])`` is valid, where\n+ ``v.ndim == 1``.\n+\n+ When the nested list is two levels deep, this allows block matrices to be\n+ constructed from their components.\n+\n+ Parameters\n+ ----------\n+ arrays : nested list of array_like or scalars (but not tuples)\n+ If passed a single ndarray or scalar (a nested list of depth 0), this\n+ is returned unmodified (and not copied).\n+\n+ Elements shapes must match along the appropriate axes (without\n+ broadcasting), but leading 1s will be prepended to the shape as\n+ necessary to make the dimensions match.\n+\n+ allow_unknown_chunksizes: bool\n+ Allow unknown chunksizes, such as come from converting from dask\n+ dataframes. Dask.array is unable to verify that chunks line up. If\n+ data comes from differently aligned sources then this can cause\n+ unexpected results.\n+\n+ Returns\n+ -------\n+ block_array : ndarray\n+ The array assembled from the given blocks.\n+\n+ The dimensionality of the output is equal to the greatest of:\n+ * the dimensionality of all the inputs\n+ * the depth to which the input list is nested\n+\n+ Raises\n+ ------\n+ ValueError\n+ * If list depths are mismatched - for instance, ``[[a, b], c]`` is\n+ illegal, and should be spelt ``[[a, b], [c]]``\n+ * If lists are empty - for instance, ``[[a, b], []]``\n+\n+ See Also\n+ --------\n+ concatenate : Join a sequence of arrays together.\n+ stack : Stack arrays in sequence along a new dimension.\n+ hstack : Stack arrays in sequence horizontally (column wise).\n+ vstack : Stack arrays in sequence vertically (row wise).\n+ dstack : Stack arrays in sequence depth wise (along third dimension).\n+ vsplit : Split array into a list of multiple sub-arrays vertically.\n+\n+ Notes\n+ -----\n+\n+ When called with only scalars, ``block`` is equivalent to an ndarray\n+ call. So ``block([[1, 2], [3, 4]])`` is equivalent to\n+ ``array([[1, 2], [3, 4]])``.\n+\n+ This function does not enforce that the blocks lie on a fixed grid.\n+ ``block([[a, b], [c, d]])`` is not restricted to arrays of the form::\n+\n+ AAAbb\n+ AAAbb\n+ cccDD\n+\n+ But is also allowed to produce, for some ``a, b, c, d``::\n+\n+ AAAbb\n+ AAAbb\n+ cDDDD\n+\n+ Since concatenation happens along the last axis first, `block` is _not_\n+ capable of producing the following directly::\n+\n+ AAAbb\n+ cccbb\n+ cccDD\n+\n+ Matlab's \"square bracket stacking\", ``[A, B, ...; p, q, ...]``, is\n+ equivalent to ``block([[A, B, ...], [p, q, ...]])``.\n+ \"\"\"\n+\n+ def atleast_nd(x, ndim):\n+ x = asanyarray(x)\n+ diff = max(ndim - x.ndim, 0)\n+ return x[(None,) * diff + (Ellipsis,)]\n+\n+ def format_index(index):\n+ return 'arrays' + ''.join('[{}]'.format(i) for i in index)\n+\n+ rec = _Recurser(recurse_if=lambda x: type(x) is list)\n+\n+ # ensure that the lists are all matched in depth\n+ list_ndim = None\n+ any_empty = False\n+ for index, value, entering in rec.walk(arrays):\n+ if type(value) is tuple:\n+ # not strictly necessary, but saves us from:\n+ # - more than one way to do things - no point treating tuples like\n+ # lists\n+ # - horribly confusing behaviour that results when tuples are\n+ # treated like ndarray\n+ raise TypeError(\n+ '{} is a tuple. '\n+ 'Only lists can be used to arrange blocks, and np.block does '\n+ 'not allow implicit conversion from tuple to ndarray.'.format(\n+ format_index(index)\n+ )\n+ )\n+ if not entering:\n+ curr_depth = len(index)\n+ elif len(value) == 0:\n+ curr_depth = len(index) + 1\n+ any_empty = True\n+ else:\n+ continue\n+\n+ if list_ndim is not None and list_ndim != curr_depth:\n+ raise ValueError(\n+ \"List depths are mismatched. First element was at depth {}, \"\n+ \"but there is an element at depth {} ({})\".format(\n+ list_ndim,\n+ curr_depth,\n+ format_index(index)\n+ )\n+ )\n+ list_ndim = curr_depth\n+\n+ # do this here so we catch depth mismatches first\n+ if any_empty:\n+ raise ValueError('Lists cannot be empty')\n+\n+ # convert all the arrays to ndarrays\n+ arrays = rec.map_reduce(\n+ arrays,\n+ f_map=asanyarray,\n+ f_reduce=list\n+ )\n+\n+ # determine the maximum dimension of the elements\n+ elem_ndim = rec.map_reduce(\n+ arrays,\n+ f_map=lambda xi: xi.ndim,\n+ f_reduce=max\n+ )\n+ ndim = max(list_ndim, elem_ndim)\n+\n+ # first axis to concatenate along\n+ first_axis = ndim - list_ndim\n+\n+ # Make all the elements the same dimension\n+ arrays = rec.map_reduce(\n+ arrays,\n+ f_map=lambda xi: atleast_nd(xi, ndim),\n+ f_reduce=list\n+ )\n+\n+ # concatenate innermost lists on the right, outermost on the left\n+ return rec.map_reduce(\n+ arrays,\n+ f_reduce=lambda xs, axis: concatenate(\n+ list(xs),\n+ axis=axis,\n+ allow_unknown_chunksizes=allow_unknown_chunksizes\n+ ),\n+ f_kwargs=lambda axis: dict(axis=(axis + 1)),\n+ axis=first_axis\n+ )","path":"dask/array/core.py","position":254,"original_position":254,"commit_id":"c6c7714f2a47a1f6bdf1a7c0253716b025df4c87","original_commit_id":"c6c7714f2a47a1f6bdf1a7c0253716b025df4c87","user":{"login":"mrocklin","id":306380,"avatar_url":"https://avatars3.githubusercontent.com/u/306380?v=4","gravatar_id":"","url":"https://api.github.com/users/mrocklin","html_url":"https://github.com/mrocklin","followers_url":"https://api.github.com/users/mrocklin/followers","following_url":"https://api.github.com/users/mrocklin/following{/other_user}","gists_url":"https://api.github.com/users/mrocklin/gists{/gist_id}","starred_url":"https://api.github.com/users/mrocklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrocklin/subscriptions","organizations_url":"https://api.github.com/users/mrocklin/orgs","repos_url":"https://api.github.com/users/mrocklin/repos","events_url":"https://api.github.com/users/mrocklin/events{/privacy}","received_events_url":"https://api.github.com/users/mrocklin/received_events","type":"User","site_admin":false},"body":"I take it that the only things to change here were things like `np.concatenate -> concatenate`?","created_at":"2017-09-05T13:43:13Z","updated_at":"2017-09-05T13:44:25Z","html_url":"https://github.com/dask/dask/pull/2650#discussion_r136991418","pull_request_url":"https://api.github.com/repos/dask/dask/pulls/2650","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/dask/dask/pulls/comments/136991418"},"html":{"href":"https://github.com/dask/dask/pull/2650#discussion_r136991418"},"pull_request":{"href":"https://api.github.com/repos/dask/dask/pulls/2650"}}},"pull_request":{"url":"https://api.github.com/repos/dask/dask/pulls/2650","id":138963525,"html_url":"https://github.com/dask/dask/pull/2650","diff_url":"https://github.com/dask/dask/pull/2650.diff","patch_url":"https://github.com/dask/dask/pull/2650.patch","issue_url":"https://api.github.com/repos/dask/dask/issues/2650","number":2650,"state":"open","locked":false,"title":"WIP: Add block","user":{"login":"jakirkham","id":3019665,"avatar_url":"https://avatars1.githubusercontent.com/u/3019665?v=4","gravatar_id":"","url":"https://api.github.com/users/jakirkham","html_url":"https://github.com/jakirkham","followers_url":"https://api.github.com/users/jakirkham/followers","following_url":"https://api.github.com/users/jakirkham/following{/other_user}","gists_url":"https://api.github.com/users/jakirkham/gists{/gist_id}","starred_url":"https://api.github.com/users/jakirkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakirkham/subscriptions","organizations_url":"https://api.github.com/users/jakirkham/orgs","repos_url":"https://api.github.com/users/jakirkham/repos","events_url":"https://api.github.com/users/jakirkham/events{/privacy}","received_events_url":"https://api.github.com/users/jakirkham/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/dask/dask/issues/2350\r\n\r\nThis basically rips out the content added to NumPy in PR ( https://github.com/numpy/numpy/pull/8886 ) and makes some tweaks to get it to work with Dask Arrays.","created_at":"2017-09-01T20:00:29Z","updated_at":"2017-09-05T13:44:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3f98c795fa3a7b6a2c8d4343017880beadbab31","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jcrist","id":2783717,"avatar_url":"https://avatars3.githubusercontent.com/u/2783717?v=4","gravatar_id":"","url":"https://api.github.com/users/jcrist","html_url":"https://github.com/jcrist","followers_url":"https://api.github.com/users/jcrist/followers","following_url":"https://api.github.com/users/jcrist/following{/other_user}","gists_url":"https://api.github.com/users/jcrist/gists{/gist_id}","starred_url":"https://api.github.com/users/jcrist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcrist/subscriptions","organizations_url":"https://api.github.com/users/jcrist/orgs","repos_url":"https://api.github.com/users/jcrist/repos","events_url":"https://api.github.com/users/jcrist/events{/privacy}","received_events_url":"https://api.github.com/users/jcrist/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dask/dask/pulls/2650/commits","review_comments_url":"https://api.github.com/repos/dask/dask/pulls/2650/comments","review_comment_url":"https://api.github.com/repos/dask/dask/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dask/dask/issues/2650/comments","statuses_url":"https://api.github.com/repos/dask/dask/statuses/c6c7714f2a47a1f6bdf1a7c0253716b025df4c87","head":{"label":"jakirkham:add_block","ref":"add_block","sha":"c6c7714f2a47a1f6bdf1a7c0253716b025df4c87","user":{"login":"jakirkham","id":3019665,"avatar_url":"https://avatars1.githubusercontent.com/u/3019665?v=4","gravatar_id":"","url":"https://api.github.com/users/jakirkham","html_url":"https://github.com/jakirkham","followers_url":"https://api.github.com/users/jakirkham/followers","following_url":"https://api.github.com/users/jakirkham/following{/other_user}","gists_url":"https://api.github.com/users/jakirkham/gists{/gist_id}","starred_url":"https://api.github.com/users/jakirkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakirkham/subscriptions","organizations_url":"https://api.github.com/users/jakirkham/orgs","repos_url":"https://api.github.com/users/jakirkham/repos","events_url":"https://api.github.com/users/jakirkham/events{/privacy}","received_events_url":"https://api.github.com/users/jakirkham/received_events","type":"User","site_admin":false},"repo":{"id":31235042,"name":"dask","full_name":"jakirkham/dask","owner":{"login":"jakirkham","id":3019665,"avatar_url":"https://avatars1.githubusercontent.com/u/3019665?v=4","gravatar_id":"","url":"https://api.github.com/users/jakirkham","html_url":"https://github.com/jakirkham","followers_url":"https://api.github.com/users/jakirkham/followers","following_url":"https://api.github.com/users/jakirkham/following{/other_user}","gists_url":"https://api.github.com/users/jakirkham/gists{/gist_id}","starred_url":"https://api.github.com/users/jakirkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakirkham/subscriptions","organizations_url":"https://api.github.com/users/jakirkham/orgs","repos_url":"https://api.github.com/users/jakirkham/repos","events_url":"https://api.github.com/users/jakirkham/events{/privacy}","received_events_url":"https://api.github.com/users/jakirkham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jakirkham/dask","description":"Minimal task scheduling abstraction","fork":true,"url":"https://api.github.com/repos/jakirkham/dask","forks_url":"https://api.github.com/repos/jakirkham/dask/forks","keys_url":"https://api.github.com/repos/jakirkham/dask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jakirkham/dask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jakirkham/dask/teams","hooks_url":"https://api.github.com/repos/jakirkham/dask/hooks","issue_events_url":"https://api.github.com/repos/jakirkham/dask/issues/events{/number}","events_url":"https://api.github.com/repos/jakirkham/dask/events","assignees_url":"https://api.github.com/repos/jakirkham/dask/assignees{/user}","branches_url":"https://api.github.com/repos/jakirkham/dask/branches{/branch}","tags_url":"https://api.github.com/repos/jakirkham/dask/tags","blobs_url":"https://api.github.com/repos/jakirkham/dask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jakirkham/dask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jakirkham/dask/git/refs{/sha}","trees_url":"https://api.github.com/repos/jakirkham/dask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jakirkham/dask/statuses/{sha}","languages_url":"https://api.github.com/repos/jakirkham/dask/languages","stargazers_url":"https://api.github.com/repos/jakirkham/dask/stargazers","contributors_url":"https://api.github.com/repos/jakirkham/dask/contributors","subscribers_url":"https://api.github.com/repos/jakirkham/dask/subscribers","subscription_url":"https://api.github.com/repos/jakirkham/dask/subscription","commits_url":"https://api.github.com/repos/jakirkham/dask/commits{/sha}","git_commits_url":"https://api.github.com/repos/jakirkham/dask/git/commits{/sha}","comments_url":"https://api.github.com/repos/jakirkham/dask/comments{/number}","issue_comment_url":"https://api.github.com/repos/jakirkham/dask/issues/comments{/number}","contents_url":"https://api.github.com/repos/jakirkham/dask/contents/{+path}","compare_url":"https://api.github.com/repos/jakirkham/dask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jakirkham/dask/merges","archive_url":"https://api.github.com/repos/jakirkham/dask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jakirkham/dask/downloads","issues_url":"https://api.github.com/repos/jakirkham/dask/issues{/number}","pulls_url":"https://api.github.com/repos/jakirkham/dask/pulls{/number}","milestones_url":"https://api.github.com/repos/jakirkham/dask/milestones{/number}","notifications_url":"https://api.github.com/repos/jakirkham/dask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jakirkham/dask/labels{/name}","releases_url":"https://api.github.com/repos/jakirkham/dask/releases{/id}","deployments_url":"https://api.github.com/repos/jakirkham/dask/deployments","created_at":"2015-02-23T23:11:16Z","updated_at":"2016-02-11T18:22:48Z","pushed_at":"2017-09-02T18:15:40Z","git_url":"git://github.com/jakirkham/dask.git","ssh_url":"[email protected]:jakirkham/dask.git","clone_url":"https://github.com/jakirkham/dask.git","svn_url":"https://github.com/jakirkham/dask","homepage":"","size":14825,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dask:master","ref":"master","sha":"b1c5f1b24057e2af89422e93f4ffea82b0b56861","user":{"login":"dask","id":17131925,"avatar_url":"https://avatars1.githubusercontent.com/u/17131925?v=4","gravatar_id":"","url":"https://api.github.com/users/dask","html_url":"https://github.com/dask","followers_url":"https://api.github.com/users/dask/followers","following_url":"https://api.github.com/users/dask/following{/other_user}","gists_url":"https://api.github.com/users/dask/gists{/gist_id}","starred_url":"https://api.github.com/users/dask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dask/subscriptions","organizations_url":"https://api.github.com/users/dask/orgs","repos_url":"https://api.github.com/users/dask/repos","events_url":"https://api.github.com/users/dask/events{/privacy}","received_events_url":"https://api.github.com/users/dask/received_events","type":"Organization","site_admin":false},"repo":{"id":28782747,"name":"dask","full_name":"dask/dask","owner":{"login":"dask","id":17131925,"avatar_url":"https://avatars1.githubusercontent.com/u/17131925?v=4","gravatar_id":"","url":"https://api.github.com/users/dask","html_url":"https://github.com/dask","followers_url":"https://api.github.com/users/dask/followers","following_url":"https://api.github.com/users/dask/following{/other_user}","gists_url":"https://api.github.com/users/dask/gists{/gist_id}","starred_url":"https://api.github.com/users/dask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dask/subscriptions","organizations_url":"https://api.github.com/users/dask/orgs","repos_url":"https://api.github.com/users/dask/repos","events_url":"https://api.github.com/users/dask/events{/privacy}","received_events_url":"https://api.github.com/users/dask/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dask/dask","description":"Parallel computing with task scheduling","fork":false,"url":"https://api.github.com/repos/dask/dask","forks_url":"https://api.github.com/repos/dask/dask/forks","keys_url":"https://api.github.com/repos/dask/dask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dask/dask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dask/dask/teams","hooks_url":"https://api.github.com/repos/dask/dask/hooks","issue_events_url":"https://api.github.com/repos/dask/dask/issues/events{/number}","events_url":"https://api.github.com/repos/dask/dask/events","assignees_url":"https://api.github.com/repos/dask/dask/assignees{/user}","branches_url":"https://api.github.com/repos/dask/dask/branches{/branch}","tags_url":"https://api.github.com/repos/dask/dask/tags","blobs_url":"https://api.github.com/repos/dask/dask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dask/dask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dask/dask/git/refs{/sha}","trees_url":"https://api.github.com/repos/dask/dask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dask/dask/statuses/{sha}","languages_url":"https://api.github.com/repos/dask/dask/languages","stargazers_url":"https://api.github.com/repos/dask/dask/stargazers","contributors_url":"https://api.github.com/repos/dask/dask/contributors","subscribers_url":"https://api.github.com/repos/dask/dask/subscribers","subscription_url":"https://api.github.com/repos/dask/dask/subscription","commits_url":"https://api.github.com/repos/dask/dask/commits{/sha}","git_commits_url":"https://api.github.com/repos/dask/dask/git/commits{/sha}","comments_url":"https://api.github.com/repos/dask/dask/comments{/number}","issue_comment_url":"https://api.github.com/repos/dask/dask/issues/comments{/number}","contents_url":"https://api.github.com/repos/dask/dask/contents/{+path}","compare_url":"https://api.github.com/repos/dask/dask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dask/dask/merges","archive_url":"https://api.github.com/repos/dask/dask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dask/dask/downloads","issues_url":"https://api.github.com/repos/dask/dask/issues{/number}","pulls_url":"https://api.github.com/repos/dask/dask/pulls{/number}","milestones_url":"https://api.github.com/repos/dask/dask/milestones{/number}","notifications_url":"https://api.github.com/repos/dask/dask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dask/dask/labels{/name}","releases_url":"https://api.github.com/repos/dask/dask/releases{/id}","deployments_url":"https://api.github.com/repos/dask/dask/deployments","created_at":"2015-01-04T18:50:00Z","updated_at":"2017-09-05T13:22:40Z","pushed_at":"2017-09-05T13:30:55Z","git_url":"git://github.com/dask/dask.git","ssh_url":"[email protected]:dask/dask.git","clone_url":"https://github.com/dask/dask.git","svn_url":"https://github.com/dask/dask","homepage":"http://dask.pydata.org","size":14995,"stargazers_count":1887,"watchers_count":1887,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":326,"mirror_url":null,"open_issues_count":241,"forks":326,"open_issues":241,"watchers":1887,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dask/dask/pulls/2650"},"html":{"href":"https://github.com/dask/dask/pull/2650"},"issue":{"href":"https://api.github.com/repos/dask/dask/issues/2650"},"comments":{"href":"https://api.github.com/repos/dask/dask/issues/2650/comments"},"review_comments":{"href":"https://api.github.com/repos/dask/dask/pulls/2650/comments"},"review_comment":{"href":"https://api.github.com/repos/dask/dask/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dask/dask/pulls/2650/commits"},"statuses":{"href":"https://api.github.com/repos/dask/dask/statuses/c6c7714f2a47a1f6bdf1a7c0253716b025df4c87"}},"author_association":"MEMBER"}} | {
"id": 28782747,
"name": "dask/dask",
"url": "https://api.github.com/repos/dask/dask"
} | {
"id": 306380,
"login": "mrocklin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/306380?",
"url": "https://api.github.com/users/mrocklin"
} | {
"id": 17131925,
"login": "dask",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17131925?",
"url": "https://api.github.com/orgs/dask"
} | 2017-09-05T13:43:13 | 6551113203 | {"actor":{"display_login":"mrocklin"}} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.