type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
334k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Kinvey/angular2-sdk/pulls/comments/140313424","pull_request_review_id":64368203,"id":140313424,"diff_hunk":"@@ -26,13 +26,14 @@ export namespace Kinvey {\n \n // ClientConfig interface\n interface ClientConfig {\n- apiHostname?: string,\n- micHostname?: string,\n- appKey: string,\n- appSecret?: string,\n- masterSecret?: string,\n- encryptionKey?: string,\n- defaultTimeout?: number\n+ apiHostname?: string;\n+ micHostname?: string;\n+ liveServiceHostname?: string;","path":"src/kinvey.d.ts","position":34,"original_position":34,"commit_id":"10e9043914609a0ac6f4d4f389672194cac85ad3","original_commit_id":"10e9043914609a0ac6f4d4f389672194cac85ad3","user":{"login":"thomasconner","id":950052,"avatar_url":"https://avatars1.githubusercontent.com/u/950052?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasconner","html_url":"https://github.com/thomasconner","followers_url":"https://api.github.com/users/thomasconner/followers","following_url":"https://api.github.com/users/thomasconner/following{/other_user}","gists_url":"https://api.github.com/users/thomasconner/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasconner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasconner/subscriptions","organizations_url":"https://api.github.com/users/thomasconner/orgs","repos_url":"https://api.github.com/users/thomasconner/repos","events_url":"https://api.github.com/users/thomasconner/events{/privacy}","received_events_url":"https://api.github.com/users/thomasconner/received_events","type":"User","site_admin":false},"body":"Probably best to document in the descanter.","created_at":"2017-09-21T17:50:17Z","updated_at":"2017-09-21T17:50:17Z","html_url":"https://github.com/Kinvey/angular2-sdk/pull/8#discussion_r140313424","pull_request_url":"https://api.github.com/repos/Kinvey/angular2-sdk/pulls/8","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Kinvey/angular2-sdk/pulls/comments/140313424"},"html":{"href":"https://github.com/Kinvey/angular2-sdk/pull/8#discussion_r140313424"},"pull_request":{"href":"https://api.github.com/repos/Kinvey/angular2-sdk/pulls/8"}},"in_reply_to_id":140309943},"pull_request":{"url":"https://api.github.com/repos/Kinvey/angular2-sdk/pulls/8","id":142101065,"html_url":"https://github.com/Kinvey/angular2-sdk/pull/8","diff_url":"https://github.com/Kinvey/angular2-sdk/pull/8.diff","patch_url":"https://github.com/Kinvey/angular2-sdk/pull/8.patch","issue_url":"https://api.github.com/repos/Kinvey/angular2-sdk/issues/8","number":8,"state":"open","locked":false,"title":"MLIBZ-1948: Depend on kinvey-phonegap-sdk","user":{"login":"thomasconner","id":950052,"avatar_url":"https://avatars1.githubusercontent.com/u/950052?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasconner","html_url":"https://github.com/thomasconner","followers_url":"https://api.github.com/users/thomasconner/followers","following_url":"https://api.github.com/users/thomasconner/following{/other_user}","gists_url":"https://api.github.com/users/thomasconner/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasconner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasconner/subscriptions","organizations_url":"https://api.github.com/users/thomasconner/orgs","repos_url":"https://api.github.com/users/thomasconner/repos","events_url":"https://api.github.com/users/thomasconner/events{/privacy}","received_events_url":"https://api.github.com/users/thomasconner/received_events","type":"User","site_admin":false},"body":"#### Changes\r\n- Depends on [kinvey-phonegap-sdk](https://github.com/Kinvey/phonegap-sdk).\r\n- Builds the sdk with Webpack 2.\r\n- Uses tslint instead of eslint.\r\n- Add push to type definitions.","created_at":"2017-09-20T13:35:24Z","updated_at":"2017-09-21T17:50:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cce0c9a76728e52910f8d81bd9f7a26c182cf723","assignee":{"login":"thomasconner","id":950052,"avatar_url":"https://avatars1.githubusercontent.com/u/950052?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasconner","html_url":"https://github.com/thomasconner","followers_url":"https://api.github.com/users/thomasconner/followers","following_url":"https://api.github.com/users/thomasconner/following{/other_user}","gists_url":"https://api.github.com/users/thomasconner/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasconner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasconner/subscriptions","organizations_url":"https://api.github.com/users/thomasconner/orgs","repos_url":"https://api.github.com/users/thomasconner/repos","events_url":"https://api.github.com/users/thomasconner/events{/privacy}","received_events_url":"https://api.github.com/users/thomasconner/received_events","type":"User","site_admin":false},"assignees":[{"login":"thomasconner","id":950052,"avatar_url":"https://avatars1.githubusercontent.com/u/950052?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasconner","html_url":"https://github.com/thomasconner","followers_url":"https://api.github.com/users/thomasconner/followers","following_url":"https://api.github.com/users/thomasconner/following{/other_user}","gists_url":"https://api.github.com/users/thomasconner/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasconner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasconner/subscriptions","organizations_url":"https://api.github.com/users/thomasconner/orgs","repos_url":"https://api.github.com/users/thomasconner/repos","events_url":"https://api.github.com/users/thomasconner/events{/privacy}","received_events_url":"https://api.github.com/users/thomasconner/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Kinvey/angular2-sdk/pulls/8/commits","review_comments_url":"https://api.github.com/repos/Kinvey/angular2-sdk/pulls/8/comments","review_comment_url":"https://api.github.com/repos/Kinvey/angular2-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kinvey/angular2-sdk/issues/8/comments","statuses_url":"https://api.github.com/repos/Kinvey/angular2-sdk/statuses/10e9043914609a0ac6f4d4f389672194cac85ad3","head":{"label":"Kinvey:MLIBZ-1948_Support_Push_Notifications","ref":"MLIBZ-1948_Support_Push_Notifications","sha":"10e9043914609a0ac6f4d4f389672194cac85ad3","user":{"login":"Kinvey","id":1276480,"avatar_url":"https://avatars2.githubusercontent.com/u/1276480?v=4","gravatar_id":"","url":"https://api.github.com/users/Kinvey","html_url":"https://github.com/Kinvey","followers_url":"https://api.github.com/users/Kinvey/followers","following_url":"https://api.github.com/users/Kinvey/following{/other_user}","gists_url":"https://api.github.com/users/Kinvey/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinvey/subscriptions","organizations_url":"https://api.github.com/users/Kinvey/orgs","repos_url":"https://api.github.com/users/Kinvey/repos","events_url":"https://api.github.com/users/Kinvey/events{/privacy}","received_events_url":"https://api.github.com/users/Kinvey/received_events","type":"Organization","site_admin":false},"repo":{"id":62341694,"name":"angular2-sdk","full_name":"Kinvey/angular2-sdk","owner":{"login":"Kinvey","id":1276480,"avatar_url":"https://avatars2.githubusercontent.com/u/1276480?v=4","gravatar_id":"","url":"https://api.github.com/users/Kinvey","html_url":"https://github.com/Kinvey","followers_url":"https://api.github.com/users/Kinvey/followers","following_url":"https://api.github.com/users/Kinvey/following{/other_user}","gists_url":"https://api.github.com/users/Kinvey/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinvey/subscriptions","organizations_url":"https://api.github.com/users/Kinvey/orgs","repos_url":"https://api.github.com/users/Kinvey/repos","events_url":"https://api.github.com/users/Kinvey/events{/privacy}","received_events_url":"https://api.github.com/users/Kinvey/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kinvey/angular2-sdk","description":"Kinvey Javascript SDK for Angular 2","fork":false,"url":"https://api.github.com/repos/Kinvey/angular2-sdk","forks_url":"https://api.github.com/repos/Kinvey/angular2-sdk/forks","keys_url":"https://api.github.com/repos/Kinvey/angular2-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kinvey/angular2-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kinvey/angular2-sdk/teams","hooks_url":"https://api.github.com/repos/Kinvey/angular2-sdk/hooks","issue_events_url":"https://api.github.com/repos/Kinvey/angular2-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/Kinvey/angular2-sdk/events","assignees_url":"https://api.github.com/repos/Kinvey/angular2-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/Kinvey/angular2-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/Kinvey/angular2-sdk/tags","blobs_url":"https://api.github.com/repos/Kinvey/angular2-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kinvey/angular2-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kinvey/angular2-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kinvey/angular2-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kinvey/angular2-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/Kinvey/angular2-sdk/languages","stargazers_url":"https://api.github.com/repos/Kinvey/angular2-sdk/stargazers","contributors_url":"https://api.github.com/repos/Kinvey/angular2-sdk/contributors","subscribers_url":"https://api.github.com/repos/Kinvey/angular2-sdk/subscribers","subscription_url":"https://api.github.com/repos/Kinvey/angular2-sdk/subscription","commits_url":"https://api.github.com/repos/Kinvey/angular2-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kinvey/angular2-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kinvey/angular2-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kinvey/angular2-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kinvey/angular2-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/Kinvey/angular2-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kinvey/angular2-sdk/merges","archive_url":"https://api.github.com/repos/Kinvey/angular2-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kinvey/angular2-sdk/downloads","issues_url":"https://api.github.com/repos/Kinvey/angular2-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/Kinvey/angular2-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/Kinvey/angular2-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/Kinvey/angular2-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kinvey/angular2-sdk/labels{/name}","releases_url":"https://api.github.com/repos/Kinvey/angular2-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/Kinvey/angular2-sdk/deployments","created_at":"2016-06-30T20:55:00Z","updated_at":"2017-05-04T02:18:39Z","pushed_at":"2017-09-21T16:02:54Z","git_url":"git://github.com/Kinvey/angular2-sdk.git","ssh_url":"[email protected]:Kinvey/angular2-sdk.git","clone_url":"https://github.com/Kinvey/angular2-sdk.git","svn_url":"https://github.com/Kinvey/angular2-sdk","homepage":"","size":635,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"Kinvey:master","ref":"master","sha":"77bec08f0a3f7f22b35815493e8283e9b91a33da","user":{"login":"Kinvey","id":1276480,"avatar_url":"https://avatars2.githubusercontent.com/u/1276480?v=4","gravatar_id":"","url":"https://api.github.com/users/Kinvey","html_url":"https://github.com/Kinvey","followers_url":"https://api.github.com/users/Kinvey/followers","following_url":"https://api.github.com/users/Kinvey/following{/other_user}","gists_url":"https://api.github.com/users/Kinvey/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinvey/subscriptions","organizations_url":"https://api.github.com/users/Kinvey/orgs","repos_url":"https://api.github.com/users/Kinvey/repos","events_url":"https://api.github.com/users/Kinvey/events{/privacy}","received_events_url":"https://api.github.com/users/Kinvey/received_events","type":"Organization","site_admin":false},"repo":{"id":62341694,"name":"angular2-sdk","full_name":"Kinvey/angular2-sdk","owner":{"login":"Kinvey","id":1276480,"avatar_url":"https://avatars2.githubusercontent.com/u/1276480?v=4","gravatar_id":"","url":"https://api.github.com/users/Kinvey","html_url":"https://github.com/Kinvey","followers_url":"https://api.github.com/users/Kinvey/followers","following_url":"https://api.github.com/users/Kinvey/following{/other_user}","gists_url":"https://api.github.com/users/Kinvey/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinvey/subscriptions","organizations_url":"https://api.github.com/users/Kinvey/orgs","repos_url":"https://api.github.com/users/Kinvey/repos","events_url":"https://api.github.com/users/Kinvey/events{/privacy}","received_events_url":"https://api.github.com/users/Kinvey/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kinvey/angular2-sdk","description":"Kinvey Javascript SDK for Angular 2","fork":false,"url":"https://api.github.com/repos/Kinvey/angular2-sdk","forks_url":"https://api.github.com/repos/Kinvey/angular2-sdk/forks","keys_url":"https://api.github.com/repos/Kinvey/angular2-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kinvey/angular2-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kinvey/angular2-sdk/teams","hooks_url":"https://api.github.com/repos/Kinvey/angular2-sdk/hooks","issue_events_url":"https://api.github.com/repos/Kinvey/angular2-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/Kinvey/angular2-sdk/events","assignees_url":"https://api.github.com/repos/Kinvey/angular2-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/Kinvey/angular2-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/Kinvey/angular2-sdk/tags","blobs_url":"https://api.github.com/repos/Kinvey/angular2-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kinvey/angular2-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kinvey/angular2-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kinvey/angular2-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kinvey/angular2-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/Kinvey/angular2-sdk/languages","stargazers_url":"https://api.github.com/repos/Kinvey/angular2-sdk/stargazers","contributors_url":"https://api.github.com/repos/Kinvey/angular2-sdk/contributors","subscribers_url":"https://api.github.com/repos/Kinvey/angular2-sdk/subscribers","subscription_url":"https://api.github.com/repos/Kinvey/angular2-sdk/subscription","commits_url":"https://api.github.com/repos/Kinvey/angular2-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kinvey/angular2-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kinvey/angular2-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kinvey/angular2-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kinvey/angular2-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/Kinvey/angular2-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kinvey/angular2-sdk/merges","archive_url":"https://api.github.com/repos/Kinvey/angular2-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kinvey/angular2-sdk/downloads","issues_url":"https://api.github.com/repos/Kinvey/angular2-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/Kinvey/angular2-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/Kinvey/angular2-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/Kinvey/angular2-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kinvey/angular2-sdk/labels{/name}","releases_url":"https://api.github.com/repos/Kinvey/angular2-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/Kinvey/angular2-sdk/deployments","created_at":"2016-06-30T20:55:00Z","updated_at":"2017-05-04T02:18:39Z","pushed_at":"2017-09-21T16:02:54Z","git_url":"git://github.com/Kinvey/angular2-sdk.git","ssh_url":"[email protected]:Kinvey/angular2-sdk.git","clone_url":"https://github.com/Kinvey/angular2-sdk.git","svn_url":"https://github.com/Kinvey/angular2-sdk","homepage":"","size":635,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kinvey/angular2-sdk/pulls/8"},"html":{"href":"https://github.com/Kinvey/angular2-sdk/pull/8"},"issue":{"href":"https://api.github.com/repos/Kinvey/angular2-sdk/issues/8"},"comments":{"href":"https://api.github.com/repos/Kinvey/angular2-sdk/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/Kinvey/angular2-sdk/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/Kinvey/angular2-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kinvey/angular2-sdk/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/Kinvey/angular2-sdk/statuses/10e9043914609a0ac6f4d4f389672194cac85ad3"}},"author_association":"CONTRIBUTOR"}} | {
"id": 62341694,
"name": "Kinvey/angular2-sdk",
"url": "https://api.github.com/repos/Kinvey/angular2-sdk"
} | {
"id": 950052,
"login": "thomasconner",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/950052?",
"url": "https://api.github.com/users/thomasconner"
} | {
"id": 1276480,
"login": "Kinvey",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1276480?",
"url": "https://api.github.com/orgs/Kinvey"
} | 2017-09-21T17:50:17 | 6621089760 | {"actor":{"display_login":"thomasconner"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Kotlin/KEEP/pulls/comments/121114234","pull_request_review_id":43140661,"id":121114234,"diff_hunk":"@@ -0,0 +1,254 @@\n+# Compiler Extension to Support `android.os.Parcelable`\n+\n+* **Type**: Design proposal\n+* **Status**: Under consideration\n+* **Prototype**: In progress\n+\n+## Overview\n+\n+The `android.os.Parcelable` API requires substantial boilerplate for each parcelable class. In this document, we investigate the possible ways of mitigating this in Kotlin via a compiler extension.\n+\n+### General difficulties with `Parcelable`\n+\n+The `android.os.Parcelable` API requires some boilerplate code to be implemented (see [here](https://developer.android.com/reference/android/os/Parcelable.html)):\n+\n+```java\n+ public class MyParcelable implements Parcelable {\n+ private int mData;\n+\n+ public int describeContents() {\n+ return 0;\n+ }\n+\n+ public void writeToParcel(Parcel out, int flags) {\n+ out.writeInt(mData);\n+ }\n+\n+ public static final Parcelable.Creator<MyParcelable> CREATOR\n+ = new Parcelable.Creator<MyParcelable>() {\n+ public MyParcelable createFromParcel(Parcel in) {\n+ return new MyParcelable(in);\n+ }\n+\n+ public MyParcelable[] newArray(int size) {\n+ return new MyParcelable[size];\n+ }\n+ };\n+ \n+ private MyParcelable(Parcel in) {\n+ mData = in.readInt();\n+ }\n+ }\n+```\n+ \n+For many simple cases users want to do something like\n+\n+```kotlin\n+@Parcelize\n+class MyParcelable(val data: Int): Parcelable\n+``` \n+\n+> The name of the annotation is just an example here. Note: we can't use `Parcelable` for the annotation name as it clashes with the base interface name.\n+ \n+There's a number of annotation processing libraries that mitigate this:\n+ - A comparison is available [here](http://blog.bradcampbell.nz/a-comparison-of-parcelable-boilerplate-libraries/)\n+ - [Parceler](https://github.com/johncarl81/parceler)\n+ - [AutoParcel](https://github.com/frankiesardo/auto-parcel)\n+ - [AutoValue Parcelable Extension](https://github.com/rharter/auto-value-parcel)\n+ - [PaperParcel](https://github.com/grandstaish/paperparcel)\n+ \n+ \n+### Difficulties specific to Kotlin\n+\n+To implement `Parcelable` manually in Kotlin, one has to create a companion object and use `@JvmField`:\n+\n+```kotlin\n+data class MyParcelable(var data: Int): Parcelable {\n+\n+ override fun describeContents() = 1\n+\n+ override fun writeToParcel(dest: Parcel, flags: Int) {\n+ dest.writeInt(data)\n+ }\n+\n+ companion object {\n+ @JvmField \n+ val CREATOR = object : Parcelable.Creator<MyParcelable> {\n+ override fun createFromParcel(source: Parcel): MyParcelable {\n+ val data = source.readInt()\n+ return MyParcelable(data)\n+ }\n+\n+ override fun newArray(size: Int) = arrayOfNulls<MyParcelable>(size)\n+ }\n+ }\n+}\n+```\n+\n+This creates even more nesting and requires even more details to be memorized. There's a community [plugin](https://github.com/nekocode/android-parcelable-intellij-plugin-kotlin) for IntelliJ IDEA/Android Studio that generates this boilerplate. The [PaperParcel] library seems to work with Kotlin too, but requires manual creation of `CREATOR` fields:\n+\n+```kotlin\n+@PaperParcel\n+data class User(\n+ val id: Long,\n+ val firstName: String,\n+ val lastName: String\n+) : PaperParcelable {\n+ companion object {\n+ @JvmField val CREATOR = PaperParcelUser.CREATOR\n+ }\n+}\n+```\n+\n+## Proposal\n+\n+We can have a compiler extension to generate all the required boilerplate behind the scenes. This is similar to what (some) annotation processors do, but \n+1. Java annotation processors can't alter Kotlin code, \n+2. Normally, annotation processors can't add methods to existing classes (this is possible though a private API only),\n+3. A compiler extension can be potentially more flexible in terms of suppressing errors and providing syntactic means to the user. \n+\n+### Simple case: completely automatic Parcelable\n+\n+A compiler extension can generate serialization/deserialization logic for all properties in a primary constructor of a class marked with a special annotation:\n+\n+```kotlin\n+@Parcelize\n+class MyParcelable(val data: Int): Parcelable\n+``` \n+\n+Note that the class is not required to be a data class.\n+\n+The following requirements apply here:\n+- The class annotated with `@Parcelize` must implement `Parcelable` (directly or through a chain of supertypes)\n+ - Otherwise it's a compiler error\n+- All parameters of the primary constructor must be properties, otherwise they can not be (de)serialized\n+ - If there is a non-property parameter, it is a compilation error\n+- Properties with initializers declared in the class body are also difficult to deserialize correctly: we'd have to generate an alternative constructor that does not execute initializers (including `init` blocks) at all and only uses the serialized data, but this has all the issues that `java.io.Serializable` has wrt \"magic\" object creation.\n+ - Properties in the class body must be marked with a `@Transient` annotation, otherwise it's a compiler warning (or error?) \n+- If some properties are not parcelable (i.e. do not implement `Parcelable`, are not supported by the `Parcel` interface, and are not customized (see below)), it's a compilation error\n+- The user is not allowed to manually override methods of `Parcelable` or create the `CREATOR` field\n+ - it results in a compilation error \n+ - Question: maybe overriding `describeContents()` is OK?\n+\n+The annotations for Parcelable classes, transient fields, etc. should sit in a complimentary runtime library that ships together with the compiler extension. \n+\n+TODO: Check interactions with inheritance by delegation.\n+ \n+Some syntactic options: \n+- The names `Parcelize` and `Transient` are just placeholders for now.\n+- We could allow the user to omit teh supertype `Parcelable`, to be more DRY and have only the annotation to signify that the class is Parcelable, btu this would be more challenging wrt the tooling support.","path":"proposals/extensions/android-parcelable.md","position":139,"original_position":139,"commit_id":"336a57c792b092e3ff8f4559955f84123ae76e78","original_commit_id":"336a57c792b092e3ff8f4559955f84123ae76e78","user":{"login":"JakeWharton","id":66577,"avatar_url":"https://avatars3.githubusercontent.com/u/66577?v=3","gravatar_id":"","url":"https://api.github.com/users/JakeWharton","html_url":"https://github.com/JakeWharton","followers_url":"https://api.github.com/users/JakeWharton/followers","following_url":"https://api.github.com/users/JakeWharton/following{/other_user}","gists_url":"https://api.github.com/users/JakeWharton/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeWharton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeWharton/subscriptions","organizations_url":"https://api.github.com/users/JakeWharton/orgs","repos_url":"https://api.github.com/users/JakeWharton/repos","events_url":"https://api.github.com/users/JakeWharton/events{/privacy}","received_events_url":"https://api.github.com/users/JakeWharton/received_events","type":"User","site_admin":false},"body":"nit: teh --> the","created_at":"2017-06-09T12:30:57Z","updated_at":"2017-06-09T12:35:08Z","html_url":"https://github.com/Kotlin/KEEP/pull/71#discussion_r121114234","pull_request_url":"https://api.github.com/repos/Kotlin/KEEP/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/Kotlin/KEEP/pulls/comments/121114234"},"html":{"href":"https://github.com/Kotlin/KEEP/pull/71#discussion_r121114234"},"pull_request":{"href":"https://api.github.com/repos/Kotlin/KEEP/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/Kotlin/KEEP/pulls/71","id":124838481,"html_url":"https://github.com/Kotlin/KEEP/pull/71","diff_url":"https://github.com/Kotlin/KEEP/pull/71.diff","patch_url":"https://github.com/Kotlin/KEEP/pull/71.patch","issue_url":"https://api.github.com/repos/Kotlin/KEEP/issues/71","number":71,"state":"open","locked":false,"title":"Initial proposal for Parcelable support","user":{"login":"abreslav","id":888318,"avatar_url":"https://avatars0.githubusercontent.com/u/888318?v=3","gravatar_id":"","url":"https://api.github.com/users/abreslav","html_url":"https://github.com/abreslav","followers_url":"https://api.github.com/users/abreslav/followers","following_url":"https://api.github.com/users/abreslav/following{/other_user}","gists_url":"https://api.github.com/users/abreslav/gists{/gist_id}","starred_url":"https://api.github.com/users/abreslav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abreslav/subscriptions","organizations_url":"https://api.github.com/users/abreslav/orgs","repos_url":"https://api.github.com/users/abreslav/repos","events_url":"https://api.github.com/users/abreslav/events{/privacy}","received_events_url":"https://api.github.com/users/abreslav/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-09T10:36:49Z","updated_at":"2017-06-09T12:35:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24d2af589e01907d5a9dfb19bfe723ef4457c03f","assignee":{"login":"yanex","id":95996,"avatar_url":"https://avatars1.githubusercontent.com/u/95996?v=3","gravatar_id":"","url":"https://api.github.com/users/yanex","html_url":"https://github.com/yanex","followers_url":"https://api.github.com/users/yanex/followers","following_url":"https://api.github.com/users/yanex/following{/other_user}","gists_url":"https://api.github.com/users/yanex/gists{/gist_id}","starred_url":"https://api.github.com/users/yanex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanex/subscriptions","organizations_url":"https://api.github.com/users/yanex/orgs","repos_url":"https://api.github.com/users/yanex/repos","events_url":"https://api.github.com/users/yanex/events{/privacy}","received_events_url":"https://api.github.com/users/yanex/received_events","type":"User","site_admin":false},"assignees":[{"login":"yanex","id":95996,"avatar_url":"https://avatars1.githubusercontent.com/u/95996?v=3","gravatar_id":"","url":"https://api.github.com/users/yanex","html_url":"https://github.com/yanex","followers_url":"https://api.github.com/users/yanex/followers","following_url":"https://api.github.com/users/yanex/following{/other_user}","gists_url":"https://api.github.com/users/yanex/gists{/gist_id}","starred_url":"https://api.github.com/users/yanex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanex/subscriptions","organizations_url":"https://api.github.com/users/yanex/orgs","repos_url":"https://api.github.com/users/yanex/repos","events_url":"https://api.github.com/users/yanex/events{/privacy}","received_events_url":"https://api.github.com/users/yanex/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"yanex","id":95996,"avatar_url":"https://avatars1.githubusercontent.com/u/95996?v=3","gravatar_id":"","url":"https://api.github.com/users/yanex","html_url":"https://github.com/yanex","followers_url":"https://api.github.com/users/yanex/followers","following_url":"https://api.github.com/users/yanex/following{/other_user}","gists_url":"https://api.github.com/users/yanex/gists{/gist_id}","starred_url":"https://api.github.com/users/yanex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanex/subscriptions","organizations_url":"https://api.github.com/users/yanex/orgs","repos_url":"https://api.github.com/users/yanex/repos","events_url":"https://api.github.com/users/yanex/events{/privacy}","received_events_url":"https://api.github.com/users/yanex/received_events","type":"User","site_admin":false},{"login":"elizarov","id":478679,"avatar_url":"https://avatars1.githubusercontent.com/u/478679?v=3","gravatar_id":"","url":"https://api.github.com/users/elizarov","html_url":"https://github.com/elizarov","followers_url":"https://api.github.com/users/elizarov/followers","following_url":"https://api.github.com/users/elizarov/following{/other_user}","gists_url":"https://api.github.com/users/elizarov/gists{/gist_id}","starred_url":"https://api.github.com/users/elizarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elizarov/subscriptions","organizations_url":"https://api.github.com/users/elizarov/orgs","repos_url":"https://api.github.com/users/elizarov/repos","events_url":"https://api.github.com/users/elizarov/events{/privacy}","received_events_url":"https://api.github.com/users/elizarov/received_events","type":"User","site_admin":false},{"login":"orangy","id":616841,"avatar_url":"https://avatars2.githubusercontent.com/u/616841?v=3","gravatar_id":"","url":"https://api.github.com/users/orangy","html_url":"https://github.com/orangy","followers_url":"https://api.github.com/users/orangy/followers","following_url":"https://api.github.com/users/orangy/following{/other_user}","gists_url":"https://api.github.com/users/orangy/gists{/gist_id}","starred_url":"https://api.github.com/users/orangy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orangy/subscriptions","organizations_url":"https://api.github.com/users/orangy/orgs","repos_url":"https://api.github.com/users/orangy/repos","events_url":"https://api.github.com/users/orangy/events{/privacy}","received_events_url":"https://api.github.com/users/orangy/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Kotlin/KEEP/pulls/71/commits","review_comments_url":"https://api.github.com/repos/Kotlin/KEEP/pulls/71/comments","review_comment_url":"https://api.github.com/repos/Kotlin/KEEP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kotlin/KEEP/issues/71/comments","statuses_url":"https://api.github.com/repos/Kotlin/KEEP/statuses/336a57c792b092e3ff8f4559955f84123ae76e78","head":{"label":"Kotlin:parcelable","ref":"parcelable","sha":"336a57c792b092e3ff8f4559955f84123ae76e78","user":{"login":"Kotlin","id":1446536,"avatar_url":"https://avatars0.githubusercontent.com/u/1446536?v=3","gravatar_id":"","url":"https://api.github.com/users/Kotlin","html_url":"https://github.com/Kotlin","followers_url":"https://api.github.com/users/Kotlin/followers","following_url":"https://api.github.com/users/Kotlin/following{/other_user}","gists_url":"https://api.github.com/users/Kotlin/gists{/gist_id}","starred_url":"https://api.github.com/users/Kotlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kotlin/subscriptions","organizations_url":"https://api.github.com/users/Kotlin/orgs","repos_url":"https://api.github.com/users/Kotlin/repos","events_url":"https://api.github.com/users/Kotlin/events{/privacy}","received_events_url":"https://api.github.com/users/Kotlin/received_events","type":"Organization","site_admin":false},"repo":{"id":54388526,"name":"KEEP","full_name":"Kotlin/KEEP","owner":{"login":"Kotlin","id":1446536,"avatar_url":"https://avatars0.githubusercontent.com/u/1446536?v=3","gravatar_id":"","url":"https://api.github.com/users/Kotlin","html_url":"https://github.com/Kotlin","followers_url":"https://api.github.com/users/Kotlin/followers","following_url":"https://api.github.com/users/Kotlin/following{/other_user}","gists_url":"https://api.github.com/users/Kotlin/gists{/gist_id}","starred_url":"https://api.github.com/users/Kotlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kotlin/subscriptions","organizations_url":"https://api.github.com/users/Kotlin/orgs","repos_url":"https://api.github.com/users/Kotlin/repos","events_url":"https://api.github.com/users/Kotlin/events{/privacy}","received_events_url":"https://api.github.com/users/Kotlin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kotlin/KEEP","description":"Kotlin Evolution and Enhancement Process","fork":false,"url":"https://api.github.com/repos/Kotlin/KEEP","forks_url":"https://api.github.com/repos/Kotlin/KEEP/forks","keys_url":"https://api.github.com/repos/Kotlin/KEEP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kotlin/KEEP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kotlin/KEEP/teams","hooks_url":"https://api.github.com/repos/Kotlin/KEEP/hooks","issue_events_url":"https://api.github.com/repos/Kotlin/KEEP/issues/events{/number}","events_url":"https://api.github.com/repos/Kotlin/KEEP/events","assignees_url":"https://api.github.com/repos/Kotlin/KEEP/assignees{/user}","branches_url":"https://api.github.com/repos/Kotlin/KEEP/branches{/branch}","tags_url":"https://api.github.com/repos/Kotlin/KEEP/tags","blobs_url":"https://api.github.com/repos/Kotlin/KEEP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kotlin/KEEP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kotlin/KEEP/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kotlin/KEEP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kotlin/KEEP/statuses/{sha}","languages_url":"https://api.github.com/repos/Kotlin/KEEP/languages","stargazers_url":"https://api.github.com/repos/Kotlin/KEEP/stargazers","contributors_url":"https://api.github.com/repos/Kotlin/KEEP/contributors","subscribers_url":"https://api.github.com/repos/Kotlin/KEEP/subscribers","subscription_url":"https://api.github.com/repos/Kotlin/KEEP/subscription","commits_url":"https://api.github.com/repos/Kotlin/KEEP/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kotlin/KEEP/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kotlin/KEEP/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kotlin/KEEP/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kotlin/KEEP/contents/{+path}","compare_url":"https://api.github.com/repos/Kotlin/KEEP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kotlin/KEEP/merges","archive_url":"https://api.github.com/repos/Kotlin/KEEP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kotlin/KEEP/downloads","issues_url":"https://api.github.com/repos/Kotlin/KEEP/issues{/number}","pulls_url":"https://api.github.com/repos/Kotlin/KEEP/pulls{/number}","milestones_url":"https://api.github.com/repos/Kotlin/KEEP/milestones{/number}","notifications_url":"https://api.github.com/repos/Kotlin/KEEP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kotlin/KEEP/labels{/name}","releases_url":"https://api.github.com/repos/Kotlin/KEEP/releases{/id}","deployments_url":"https://api.github.com/repos/Kotlin/KEEP/deployments","created_at":"2016-03-21T12:54:23Z","updated_at":"2017-06-06T14:22:41Z","pushed_at":"2017-06-09T10:36:50Z","git_url":"git://github.com/Kotlin/KEEP.git","ssh_url":"[email protected]:Kotlin/KEEP.git","clone_url":"https://github.com/Kotlin/KEEP.git","svn_url":"https://github.com/Kotlin/KEEP","homepage":null,"size":187,"stargazers_count":377,"watchers_count":377,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":30,"forks":26,"open_issues":30,"watchers":377,"default_branch":"master"}},"base":{"label":"Kotlin:master","ref":"master","sha":"b20511cc5d9c0336207fdacb8436c07684407b9c","user":{"login":"Kotlin","id":1446536,"avatar_url":"https://avatars0.githubusercontent.com/u/1446536?v=3","gravatar_id":"","url":"https://api.github.com/users/Kotlin","html_url":"https://github.com/Kotlin","followers_url":"https://api.github.com/users/Kotlin/followers","following_url":"https://api.github.com/users/Kotlin/following{/other_user}","gists_url":"https://api.github.com/users/Kotlin/gists{/gist_id}","starred_url":"https://api.github.com/users/Kotlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kotlin/subscriptions","organizations_url":"https://api.github.com/users/Kotlin/orgs","repos_url":"https://api.github.com/users/Kotlin/repos","events_url":"https://api.github.com/users/Kotlin/events{/privacy}","received_events_url":"https://api.github.com/users/Kotlin/received_events","type":"Organization","site_admin":false},"repo":{"id":54388526,"name":"KEEP","full_name":"Kotlin/KEEP","owner":{"login":"Kotlin","id":1446536,"avatar_url":"https://avatars0.githubusercontent.com/u/1446536?v=3","gravatar_id":"","url":"https://api.github.com/users/Kotlin","html_url":"https://github.com/Kotlin","followers_url":"https://api.github.com/users/Kotlin/followers","following_url":"https://api.github.com/users/Kotlin/following{/other_user}","gists_url":"https://api.github.com/users/Kotlin/gists{/gist_id}","starred_url":"https://api.github.com/users/Kotlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kotlin/subscriptions","organizations_url":"https://api.github.com/users/Kotlin/orgs","repos_url":"https://api.github.com/users/Kotlin/repos","events_url":"https://api.github.com/users/Kotlin/events{/privacy}","received_events_url":"https://api.github.com/users/Kotlin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kotlin/KEEP","description":"Kotlin Evolution and Enhancement Process","fork":false,"url":"https://api.github.com/repos/Kotlin/KEEP","forks_url":"https://api.github.com/repos/Kotlin/KEEP/forks","keys_url":"https://api.github.com/repos/Kotlin/KEEP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kotlin/KEEP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kotlin/KEEP/teams","hooks_url":"https://api.github.com/repos/Kotlin/KEEP/hooks","issue_events_url":"https://api.github.com/repos/Kotlin/KEEP/issues/events{/number}","events_url":"https://api.github.com/repos/Kotlin/KEEP/events","assignees_url":"https://api.github.com/repos/Kotlin/KEEP/assignees{/user}","branches_url":"https://api.github.com/repos/Kotlin/KEEP/branches{/branch}","tags_url":"https://api.github.com/repos/Kotlin/KEEP/tags","blobs_url":"https://api.github.com/repos/Kotlin/KEEP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kotlin/KEEP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kotlin/KEEP/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kotlin/KEEP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kotlin/KEEP/statuses/{sha}","languages_url":"https://api.github.com/repos/Kotlin/KEEP/languages","stargazers_url":"https://api.github.com/repos/Kotlin/KEEP/stargazers","contributors_url":"https://api.github.com/repos/Kotlin/KEEP/contributors","subscribers_url":"https://api.github.com/repos/Kotlin/KEEP/subscribers","subscription_url":"https://api.github.com/repos/Kotlin/KEEP/subscription","commits_url":"https://api.github.com/repos/Kotlin/KEEP/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kotlin/KEEP/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kotlin/KEEP/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kotlin/KEEP/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kotlin/KEEP/contents/{+path}","compare_url":"https://api.github.com/repos/Kotlin/KEEP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kotlin/KEEP/merges","archive_url":"https://api.github.com/repos/Kotlin/KEEP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kotlin/KEEP/downloads","issues_url":"https://api.github.com/repos/Kotlin/KEEP/issues{/number}","pulls_url":"https://api.github.com/repos/Kotlin/KEEP/pulls{/number}","milestones_url":"https://api.github.com/repos/Kotlin/KEEP/milestones{/number}","notifications_url":"https://api.github.com/repos/Kotlin/KEEP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kotlin/KEEP/labels{/name}","releases_url":"https://api.github.com/repos/Kotlin/KEEP/releases{/id}","deployments_url":"https://api.github.com/repos/Kotlin/KEEP/deployments","created_at":"2016-03-21T12:54:23Z","updated_at":"2017-06-06T14:22:41Z","pushed_at":"2017-06-09T10:36:50Z","git_url":"git://github.com/Kotlin/KEEP.git","ssh_url":"[email protected]:Kotlin/KEEP.git","clone_url":"https://github.com/Kotlin/KEEP.git","svn_url":"https://github.com/Kotlin/KEEP","homepage":null,"size":187,"stargazers_count":377,"watchers_count":377,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":30,"forks":26,"open_issues":30,"watchers":377,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kotlin/KEEP/pulls/71"},"html":{"href":"https://github.com/Kotlin/KEEP/pull/71"},"issue":{"href":"https://api.github.com/repos/Kotlin/KEEP/issues/71"},"comments":{"href":"https://api.github.com/repos/Kotlin/KEEP/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/Kotlin/KEEP/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/Kotlin/KEEP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kotlin/KEEP/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/Kotlin/KEEP/statuses/336a57c792b092e3ff8f4559955f84123ae76e78"}}}} | {
"id": 54388526,
"name": "Kotlin/KEEP",
"url": "https://api.github.com/repos/Kotlin/KEEP"
} | {
"id": 66577,
"login": "JakeWharton",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/66577?",
"url": "https://api.github.com/users/JakeWharton"
} | {
"id": 1446536,
"login": "Kotlin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1446536?",
"url": "https://api.github.com/orgs/Kotlin"
} | 2017-06-09T12:30:57 | 6034914282 | {"actor":{"display_login":"JakeWharton"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Ludeon/RimWorld-ru/pulls/comments/157071016","pull_request_review_id":83655989,"id":157071016,"diff_hunk":"@@ -1785,78 +1785,75 @@ He was exploited by the local gang as a drug mule to traffic \"substance F\" acros\n \t\t<desc>NAME записался на научное исследование, которое должно было сделать HIS умнее. К сожалению, побочные эффекты сильно отличались от ожидаемых. HECAP лишился рассудка, убил несколько человек, а затем сбежал из своего родного мира.</desc>\n \t</TestSubject82>\n \n-<!--\n-\n \t<?solid Pete Holiday (Male) ?>\n \t<ArtisanFarmer56>\n-\t\t<title>Artisan farmer</title>\n-\t\t<titleShort>Farmer</titleShort>\n-\t\t<desc>NAME grew up on a HIS family's glitterworld farm. They were one of the last farms on the planet that preferred traditional farming methods to glitterworld technology.</desc>\n+\t\t<title>Фермер-кустарь</title>\n+\t\t<titleShort>Фермер</titleShort>\n+\t\t<desc>NAME вырос на семейной ферме в утопическом мире. Это была одна из последних ферм на планете, где современным технологиям предпочитали традиционные методы ведения сельского хозяйства.</desc>\n \t</ArtisanFarmer56>\n \n \t<?solid Pete Holiday (Male) ?>\n \t<GeneticEngineer63>\n-\t\t<title>Genetic engineer</title>\n-\t\t<titleShort>Geneticist</titleShort>\n-\t\t<desc>NAME carried out HIS first genetic experiments on farm animals. HECAP soon grew to become quite skilled in all forms of genetic engineering.\n+\t\t<title>Генный инженер</title>\n+\t\t<titleShort>Генетик</titleShort>\n+\t\t<desc>NAME проводил свои первые генетические эксперименты на животных на ферме. Вскоре у нHIS стало достаточно опыта во всех видах генной инженерии.\n \n-A horrifying lab accident left him with a mortal fear of rodents.</desc>\n+После несчастного случая в лабораторнии HE ужасно боится грызунов.</desc>\n \t</GeneticEngineer63>\n \n \t<?solid Miesha \"Mie\" Aldemar (Female) ?>\n \t<Pampered62>\n-\t\t<title>Pampered</title>\n-\t\t<titleShort>Pampered</titleShort>\n-\t\t<desc>Born on a decadent glitterworld, NAME was given every expensive toy.\n+\t\t<title>Изнеженный ребёнок</title>\n+\t\t<titleShort>Неженка</titleShort>\n+\t\t<desc>Родившись в приходящем в упадок утопическом мире, NAME получала любую дорогую игрушку, какую пожелает.\n \n-This pampered lifestyle caused HIM to miss many basic life lessons. HECAP developed a special aversion to cooking, and always ordered the staff to do the kitchen work.</desc>\n+Такой избалованный образ жизни заставил HIS пропустить многие основные жизненные уроки. Это развило у нHIS особое отвращение к кулинарии, а все работы по кухне выполнял персонал.</desc>\n \t</Pampered62>\n \n \t<?solid Miesha \"Mie\" Aldemar (Female) ?>\n \t<NinjaAssassin4>\n-\t\t<title>Ninja assassin</title>\n-\t\t<titleShort>Ninja</titleShort>\n-\t\t<desc>NAME performed stiletto-precise assassinations for an interplanetary conglomerate. HECAP was assigned the most complex missions involving disguise, deception, subterfuge, and efficient violence.\n+\t\t<title>Ниндзя-убийца</title>\n+\t\t<titleShort>Ниндзя</titleShort>\n+\t\t<desc>NAME выполняла безупречные заказные убийства для межпланетного конгломерата. HIMCAP давали самые сложные миссии, связанные с маскировкой, хитростью, уловками и эффективной расправой.\n \n-A nasty incident with a potted plant and an assassination gone wrong left HIM with an aversion to plant life.</desc>\n+Из-за неприятного происшествия с растением в горшке убийство пошло не так, что оставило у нHIS отвращение к любым растениям.</desc>\n \t</NinjaAssassin4>\n \n \t<?solid Steve \"Thunder\" Rahja (Male) ?>\n \t<MilitaryChild84>\n-\t\t<title>Military child</title>\n-\t\t<titleShort>Military</titleShort>\n-\t\t<desc>NAME grew up in a family with a rich military background. HISCAP teenage years were spent traveling system to system wherever HIS parents were deployed.\n+\t\t<title>Ребёнок военослужащего</title>\n+\t\t<titleShort>Военный</titleShort>\n+\t\t<desc>NAME вырос в семье с богатым военным прошлым. В подростковом возрасте HIM вместе с родители приходилось переезжать из системы в систему.\n \n-HECAP enlisted at age 18, following the tradition of HIS family.</desc>\n+Следуя традициям своей семьи, в 18 лет HE поступил на военную службу .</desc>\n \t</MilitaryChild84>\n \n \t<?solid Steve \"Thunder\" Rahja (Male) ?>\n \t<LazyProgrammer84>\n-\t\t<title>Lazy programmer</title>\n-\t\t<titleShort>Programmer</titleShort>\n-\t\t<desc>NAME independently developed software that had a competitive edge against local urbworld corporations.\n+\t\t<title>Ленивый программист</title>\n+\t\t<titleShort>Программист</titleShort>\n+\t\t<desc>NAME самостоятельно разработал программное обеспечение, имеющее конкурентное преимущество перед местными корпорациями в этом урбанизированном мире.","path":"Backstories/Backstories.xml","position":75,"original_position":75,"commit_id":"b5dcee936e499f0dd2bfd32fc552ae4917f4b404","original_commit_id":"b5dcee936e499f0dd2bfd32fc552ae4917f4b404","user":{"login":"Elevator89","id":21694533,"avatar_url":"https://avatars0.githubusercontent.com/u/21694533?v=4","gravatar_id":"","url":"https://api.github.com/users/Elevator89","html_url":"https://github.com/Elevator89","followers_url":"https://api.github.com/users/Elevator89/followers","following_url":"https://api.github.com/users/Elevator89/following{/other_user}","gists_url":"https://api.github.com/users/Elevator89/gists{/gist_id}","starred_url":"https://api.github.com/users/Elevator89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elevator89/subscriptions","organizations_url":"https://api.github.com/users/Elevator89/orgs","repos_url":"https://api.github.com/users/Elevator89/repos","events_url":"https://api.github.com/users/Elevator89/events{/privacy}","received_events_url":"https://api.github.com/users/Elevator89/received_events","type":"User","site_admin":false},"body":"перед продуктами корпораций HIS урбанизированного мира.","created_at":"2017-12-14T21:48:05Z","updated_at":"2017-12-14T21:48:05Z","html_url":"https://github.com/Ludeon/RimWorld-ru/pull/670#discussion_r157071016","pull_request_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/pulls/670","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Ludeon/RimWorld-ru/pulls/comments/157071016"},"html":{"href":"https://github.com/Ludeon/RimWorld-ru/pull/670#discussion_r157071016"},"pull_request":{"href":"https://api.github.com/repos/Ludeon/RimWorld-ru/pulls/670"}}},"pull_request":{"url":"https://api.github.com/repos/Ludeon/RimWorld-ru/pulls/670","id":158053711,"html_url":"https://github.com/Ludeon/RimWorld-ru/pull/670","diff_url":"https://github.com/Ludeon/RimWorld-ru/pull/670.diff","patch_url":"https://github.com/Ludeon/RimWorld-ru/pull/670.patch","issue_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/issues/670","number":670,"state":"open","locked":false,"title":"Close #660, Close #671, Backstories","user":{"login":"Arex-rus","id":9884648,"avatar_url":"https://avatars1.githubusercontent.com/u/9884648?v=4","gravatar_id":"","url":"https://api.github.com/users/Arex-rus","html_url":"https://github.com/Arex-rus","followers_url":"https://api.github.com/users/Arex-rus/followers","following_url":"https://api.github.com/users/Arex-rus/following{/other_user}","gists_url":"https://api.github.com/users/Arex-rus/gists{/gist_id}","starred_url":"https://api.github.com/users/Arex-rus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arex-rus/subscriptions","organizations_url":"https://api.github.com/users/Arex-rus/orgs","repos_url":"https://api.github.com/users/Arex-rus/repos","events_url":"https://api.github.com/users/Arex-rus/events{/privacy}","received_events_url":"https://api.github.com/users/Arex-rus/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-13T10:23:24Z","updated_at":"2017-12-14T21:48:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40240d56535c154b34728cab61a28ee7cbf05387","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/pulls/670/commits","review_comments_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/pulls/670/comments","review_comment_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/issues/670/comments","statuses_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/statuses/b5dcee936e499f0dd2bfd32fc552ae4917f4b404","head":{"label":"Arex-rus:master","ref":"master","sha":"b5dcee936e499f0dd2bfd32fc552ae4917f4b404","user":{"login":"Arex-rus","id":9884648,"avatar_url":"https://avatars1.githubusercontent.com/u/9884648?v=4","gravatar_id":"","url":"https://api.github.com/users/Arex-rus","html_url":"https://github.com/Arex-rus","followers_url":"https://api.github.com/users/Arex-rus/followers","following_url":"https://api.github.com/users/Arex-rus/following{/other_user}","gists_url":"https://api.github.com/users/Arex-rus/gists{/gist_id}","starred_url":"https://api.github.com/users/Arex-rus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arex-rus/subscriptions","organizations_url":"https://api.github.com/users/Arex-rus/orgs","repos_url":"https://api.github.com/users/Arex-rus/repos","events_url":"https://api.github.com/users/Arex-rus/events{/privacy}","received_events_url":"https://api.github.com/users/Arex-rus/received_events","type":"User","site_admin":false},"repo":{"id":114036010,"name":"RimWorld-ru","full_name":"Arex-rus/RimWorld-ru","owner":{"login":"Arex-rus","id":9884648,"avatar_url":"https://avatars1.githubusercontent.com/u/9884648?v=4","gravatar_id":"","url":"https://api.github.com/users/Arex-rus","html_url":"https://github.com/Arex-rus","followers_url":"https://api.github.com/users/Arex-rus/followers","following_url":"https://api.github.com/users/Arex-rus/following{/other_user}","gists_url":"https://api.github.com/users/Arex-rus/gists{/gist_id}","starred_url":"https://api.github.com/users/Arex-rus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arex-rus/subscriptions","organizations_url":"https://api.github.com/users/Arex-rus/orgs","repos_url":"https://api.github.com/users/Arex-rus/repos","events_url":"https://api.github.com/users/Arex-rus/events{/privacy}","received_events_url":"https://api.github.com/users/Arex-rus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Arex-rus/RimWorld-ru","description":"Russian Localization for RimWorld","fork":true,"url":"https://api.github.com/repos/Arex-rus/RimWorld-ru","forks_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/forks","keys_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/teams","hooks_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/hooks","issue_events_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/issues/events{/number}","events_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/events","assignees_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/assignees{/user}","branches_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/branches{/branch}","tags_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/tags","blobs_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/git/refs{/sha}","trees_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/statuses/{sha}","languages_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/languages","stargazers_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/stargazers","contributors_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/contributors","subscribers_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/subscribers","subscription_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/subscription","commits_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/commits{/sha}","git_commits_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/git/commits{/sha}","comments_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/comments{/number}","issue_comment_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/issues/comments{/number}","contents_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/contents/{+path}","compare_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/merges","archive_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/downloads","issues_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/issues{/number}","pulls_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/pulls{/number}","milestones_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/milestones{/number}","notifications_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/labels{/name}","releases_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/releases{/id}","deployments_url":"https://api.github.com/repos/Arex-rus/RimWorld-ru/deployments","created_at":"2017-12-12T20:29:06Z","updated_at":"2017-11-30T20:09:11Z","pushed_at":"2017-12-14T09:00:18Z","git_url":"git://github.com/Arex-rus/RimWorld-ru.git","ssh_url":"[email protected]:Arex-rus/RimWorld-ru.git","clone_url":"https://github.com/Arex-rus/RimWorld-ru.git","svn_url":"https://github.com/Arex-rus/RimWorld-ru","homepage":"http://ludeon.com/forums/index.php?topic=2933.0","size":3758,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ludeon:master","ref":"master","sha":"162da9783019b1999072603cfc9b15ae0cb3667c","user":{"login":"Ludeon","id":7375880,"avatar_url":"https://avatars0.githubusercontent.com/u/7375880?v=4","gravatar_id":"","url":"https://api.github.com/users/Ludeon","html_url":"https://github.com/Ludeon","followers_url":"https://api.github.com/users/Ludeon/followers","following_url":"https://api.github.com/users/Ludeon/following{/other_user}","gists_url":"https://api.github.com/users/Ludeon/gists{/gist_id}","starred_url":"https://api.github.com/users/Ludeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ludeon/subscriptions","organizations_url":"https://api.github.com/users/Ludeon/orgs","repos_url":"https://api.github.com/users/Ludeon/repos","events_url":"https://api.github.com/users/Ludeon/events{/privacy}","received_events_url":"https://api.github.com/users/Ludeon/received_events","type":"Organization","site_admin":false},"repo":{"id":18721954,"name":"RimWorld-ru","full_name":"Ludeon/RimWorld-ru","owner":{"login":"Ludeon","id":7375880,"avatar_url":"https://avatars0.githubusercontent.com/u/7375880?v=4","gravatar_id":"","url":"https://api.github.com/users/Ludeon","html_url":"https://github.com/Ludeon","followers_url":"https://api.github.com/users/Ludeon/followers","following_url":"https://api.github.com/users/Ludeon/following{/other_user}","gists_url":"https://api.github.com/users/Ludeon/gists{/gist_id}","starred_url":"https://api.github.com/users/Ludeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ludeon/subscriptions","organizations_url":"https://api.github.com/users/Ludeon/orgs","repos_url":"https://api.github.com/users/Ludeon/repos","events_url":"https://api.github.com/users/Ludeon/events{/privacy}","received_events_url":"https://api.github.com/users/Ludeon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ludeon/RimWorld-ru","description":"Russian Localization for RimWorld","fork":false,"url":"https://api.github.com/repos/Ludeon/RimWorld-ru","forks_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/forks","keys_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/teams","hooks_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/hooks","issue_events_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/issues/events{/number}","events_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/events","assignees_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/assignees{/user}","branches_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/branches{/branch}","tags_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/tags","blobs_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/statuses/{sha}","languages_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/languages","stargazers_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/stargazers","contributors_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/contributors","subscribers_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/subscribers","subscription_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/subscription","commits_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/contents/{+path}","compare_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/merges","archive_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/downloads","issues_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/issues{/number}","pulls_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/pulls{/number}","milestones_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/milestones{/number}","notifications_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/labels{/name}","releases_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/releases{/id}","deployments_url":"https://api.github.com/repos/Ludeon/RimWorld-ru/deployments","created_at":"2014-04-13T05:03:46Z","updated_at":"2017-11-30T20:09:11Z","pushed_at":"2017-12-14T18:43:33Z","git_url":"git://github.com/Ludeon/RimWorld-ru.git","ssh_url":"[email protected]:Ludeon/RimWorld-ru.git","clone_url":"https://github.com/Ludeon/RimWorld-ru.git","svn_url":"https://github.com/Ludeon/RimWorld-ru","homepage":"http://ludeon.com/forums/index.php?topic=2933.0","size":3751,"stargazers_count":43,"watchers_count":43,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":42,"license":null,"forks":53,"open_issues":42,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ludeon/RimWorld-ru/pulls/670"},"html":{"href":"https://github.com/Ludeon/RimWorld-ru/pull/670"},"issue":{"href":"https://api.github.com/repos/Ludeon/RimWorld-ru/issues/670"},"comments":{"href":"https://api.github.com/repos/Ludeon/RimWorld-ru/issues/670/comments"},"review_comments":{"href":"https://api.github.com/repos/Ludeon/RimWorld-ru/pulls/670/comments"},"review_comment":{"href":"https://api.github.com/repos/Ludeon/RimWorld-ru/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ludeon/RimWorld-ru/pulls/670/commits"},"statuses":{"href":"https://api.github.com/repos/Ludeon/RimWorld-ru/statuses/b5dcee936e499f0dd2bfd32fc552ae4917f4b404"}},"author_association":"CONTRIBUTOR"}} | {
"id": 18721954,
"name": "Ludeon/RimWorld-ru",
"url": "https://api.github.com/repos/Ludeon/RimWorld-ru"
} | {
"id": 21694533,
"login": "Elevator89",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21694533?",
"url": "https://api.github.com/users/Elevator89"
} | {
"id": 7375880,
"login": "Ludeon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7375880?",
"url": "https://api.github.com/orgs/Ludeon"
} | 2017-12-14T21:48:05 | 6990984711 | {"actor":{"display_login":"Elevator89"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/141453391","pull_request_review_id":65669894,"id":141453391,"diff_hunk":"@@ -1003,7 +1001,14 @@ response_data_start(ud_t *d, const XML_Char *el, const XML_Char **atts)\n \t\t\t\tbrp->data.release.claims = 0;\n \t\t\t} else if (strcmp(BASIL_VAL_QUERY, *vp) == 0) {\n \t\t\t\tbrp->method = basil_method_query;\n-\t\t\t\tbrp->data.query.type = basil_query_none;\n+\t\t\t\t/*\n+\t\t\t\t * Set type to status, for the switch status\n+\t\t\t\t * response. The other types can get set in\n+\t\t\t\t * inventory_start and engine_start.\n+\t\t\t\t */\n+\t\t\t\tbrp->data.query.type = basil_query_status;","path":"src/resmom/linux/alps.c","position":28,"original_position":27,"commit_id":"eda46ddbe22f5ba55a844015b532f06577c07ac0","original_commit_id":"db39ac99d561ecc5b593fc1c5e82e0c7c0391c32","user":{"login":"arungrover","id":17924134,"avatar_url":"https://avatars0.githubusercontent.com/u/17924134?v=4","gravatar_id":"","url":"https://api.github.com/users/arungrover","html_url":"https://github.com/arungrover","followers_url":"https://api.github.com/users/arungrover/followers","following_url":"https://api.github.com/users/arungrover/following{/other_user}","gists_url":"https://api.github.com/users/arungrover/gists{/gist_id}","starred_url":"https://api.github.com/users/arungrover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arungrover/subscriptions","organizations_url":"https://api.github.com/users/arungrover/orgs","repos_url":"https://api.github.com/users/arungrover/repos","events_url":"https://api.github.com/users/arungrover/events{/privacy}","received_events_url":"https://api.github.com/users/arungrover/received_events","type":"User","site_admin":false},"body":"@mike0042 Since there is no other way for us to identify that the query type as status, this seems to be the only viable option for now. I'd request you to please consider it again","created_at":"2017-09-27T20:07:11Z","updated_at":"2017-09-27T20:07:11Z","html_url":"https://github.com/PBSPro/pbspro/pull/378#discussion_r141453391","pull_request_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/378","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/141453391"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/378#discussion_r141453391"},"pull_request":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/378"}},"in_reply_to_id":140920912},"pull_request":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/378","id":138992689,"html_url":"https://github.com/PBSPro/pbspro/pull/378","diff_url":"https://github.com/PBSPro/pbspro/pull/378.diff","patch_url":"https://github.com/PBSPro/pbspro/pull/378.patch","issue_url":"https://api.github.com/repos/PBSPro/pbspro/issues/378","number":378,"state":"open","locked":false,"title":"PP-864: Ability to suspend jobs on Cray","user":{"login":"arungrover","id":17924134,"avatar_url":"https://avatars0.githubusercontent.com/u/17924134?v=4","gravatar_id":"","url":"https://api.github.com/users/arungrover","html_url":"https://github.com/arungrover","followers_url":"https://api.github.com/users/arungrover/followers","following_url":"https://api.github.com/users/arungrover/following{/other_user}","gists_url":"https://api.github.com/users/arungrover/gists{/gist_id}","starred_url":"https://api.github.com/users/arungrover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arungrover/subscriptions","organizations_url":"https://api.github.com/users/arungrover/orgs","repos_url":"https://api.github.com/users/arungrover/repos","events_url":"https://api.github.com/users/arungrover/events{/privacy}","received_events_url":"https://api.github.com/users/arungrover/received_events","type":"User","site_admin":false},"body":"<!--- Please review your changes in preview mode -->\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n#### Issue-ID\r\n<!--- Replace XXXX below (2 places) with the actual JIRA id -->\r\n* **[PP-864](https://pbspro.atlassian.net/browse/PP-864)**\r\n* **[PP-948](https://pbspro.atlassian.net/browse/PP-948)**\r\n\r\n#### Problem description\r\nSupport for suspend/resume of jobs on Cray X* series systems\r\n\r\n#### Cause / Analysis\r\nNew feature for Cray X* series platform. \r\n\r\n#### Solution description\r\nChanges are mostly related to switching IN/OUT ALPS reservations.\r\n\r\n#### Checklist:\r\n<!--- Use the preview button to see the checkboxes/links properly. -->\r\n<!--- Go over the following points, and put an `x` (without spaces around it) in the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have joined the **[pbspro community forum](http://community.pbspro.org/)**.\r\n- [x] My pull request contains a **single, signed** commit. See **[setting up gpg signature](https://pbspro.atlassian.net/wiki/display/DG/Signing+Your+Git+Commits)**.\r\n- [x] My code follows the **[coding style](https://pbspro.atlassian.net/wiki/display/DG/Coding+Standards)** of this project.\r\n- [x] My change requires project documentation. See **[required documentation checklist](https://pbspro.atlassian.net/wiki/display/DG/Checklist+for+Developing+Features+and+Bug+Fixes)** for details.\r\n- [x] I have added documentation in the **[project documentation area](https://pbspro.atlassian.net/wiki/display/PD)**.\r\n- [x] I have added new **PTL test(s) to my commit**. (See **[using PTL for testing](https://pbspro.atlassian.net/wiki/display/DG/Using+PTL+for+Testing)**) *(or)*\r\n- [ ] I have added **manual test(s) to the Jira ticket and explained why PTL is not appropriate** for this case.\r\n- [ ] All new and existing automated tests have passed. (See **[running automated PTL tests](https://pbspro.atlassian.net/wiki/display/DG/PTL+Quick+Start+Guide)**).\r\n- [x] I have attached **test logs to the Jira ticket** as evidence of testing/verification.\r\n\r\n####NOTE\r\n- This change also consists of a bug fix for **[PP-948](https://pbspro.atlassian.net/browse/PP-948)** . Change is in node_manager.c where we were dereferencing an invalid memory location.\r\n\r\n__***For further information please visit the [Developer Guide Home](https://pbspro.atlassian.net/wiki/display/DG/Developer+Guide+Home).***__\r\n","created_at":"2017-09-02T00:30:30Z","updated_at":"2017-09-27T20:07:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e395b1f046ec4180d4f84946c4021067dfb87d77","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/378/commits","review_comments_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/378/comments","review_comment_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/issues/378/comments","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/eda46ddbe22f5ba55a844015b532f06577c07ac0","head":{"label":"arungrover:PP-864","ref":"PP-864","sha":"eda46ddbe22f5ba55a844015b532f06577c07ac0","user":{"login":"arungrover","id":17924134,"avatar_url":"https://avatars0.githubusercontent.com/u/17924134?v=4","gravatar_id":"","url":"https://api.github.com/users/arungrover","html_url":"https://github.com/arungrover","followers_url":"https://api.github.com/users/arungrover/followers","following_url":"https://api.github.com/users/arungrover/following{/other_user}","gists_url":"https://api.github.com/users/arungrover/gists{/gist_id}","starred_url":"https://api.github.com/users/arungrover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arungrover/subscriptions","organizations_url":"https://api.github.com/users/arungrover/orgs","repos_url":"https://api.github.com/users/arungrover/repos","events_url":"https://api.github.com/users/arungrover/events{/privacy}","received_events_url":"https://api.github.com/users/arungrover/received_events","type":"User","site_admin":false},"repo":{"id":60597655,"name":"pbspro","full_name":"arungrover/pbspro","owner":{"login":"arungrover","id":17924134,"avatar_url":"https://avatars0.githubusercontent.com/u/17924134?v=4","gravatar_id":"","url":"https://api.github.com/users/arungrover","html_url":"https://github.com/arungrover","followers_url":"https://api.github.com/users/arungrover/followers","following_url":"https://api.github.com/users/arungrover/following{/other_user}","gists_url":"https://api.github.com/users/arungrover/gists{/gist_id}","starred_url":"https://api.github.com/users/arungrover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arungrover/subscriptions","organizations_url":"https://api.github.com/users/arungrover/orgs","repos_url":"https://api.github.com/users/arungrover/repos","events_url":"https://api.github.com/users/arungrover/events{/privacy}","received_events_url":"https://api.github.com/users/arungrover/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arungrover/pbspro","description":null,"fork":true,"url":"https://api.github.com/repos/arungrover/pbspro","forks_url":"https://api.github.com/repos/arungrover/pbspro/forks","keys_url":"https://api.github.com/repos/arungrover/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arungrover/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arungrover/pbspro/teams","hooks_url":"https://api.github.com/repos/arungrover/pbspro/hooks","issue_events_url":"https://api.github.com/repos/arungrover/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/arungrover/pbspro/events","assignees_url":"https://api.github.com/repos/arungrover/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/arungrover/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/arungrover/pbspro/tags","blobs_url":"https://api.github.com/repos/arungrover/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arungrover/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arungrover/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/arungrover/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arungrover/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/arungrover/pbspro/languages","stargazers_url":"https://api.github.com/repos/arungrover/pbspro/stargazers","contributors_url":"https://api.github.com/repos/arungrover/pbspro/contributors","subscribers_url":"https://api.github.com/repos/arungrover/pbspro/subscribers","subscription_url":"https://api.github.com/repos/arungrover/pbspro/subscription","commits_url":"https://api.github.com/repos/arungrover/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/arungrover/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/arungrover/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/arungrover/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/arungrover/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/arungrover/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arungrover/pbspro/merges","archive_url":"https://api.github.com/repos/arungrover/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arungrover/pbspro/downloads","issues_url":"https://api.github.com/repos/arungrover/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/arungrover/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/arungrover/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/arungrover/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arungrover/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/arungrover/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/arungrover/pbspro/deployments","created_at":"2016-06-07T08:51:21Z","updated_at":"2016-11-03T18:04:32Z","pushed_at":"2017-09-27T16:13:22Z","git_url":"git://github.com/arungrover/pbspro.git","ssh_url":"[email protected]:arungrover/pbspro.git","clone_url":"https://github.com/arungrover/pbspro.git","svn_url":"https://github.com/arungrover/pbspro","homepage":null,"size":8526,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PBSPro:master","ref":"master","sha":"4f1a84f2ac7def165513470d12581b497cdfdc1c","user":{"login":"PBSPro","id":19280436,"avatar_url":"https://avatars2.githubusercontent.com/u/19280436?v=4","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"repo":{"id":59082072,"name":"pbspro","full_name":"PBSPro/pbspro","owner":{"login":"PBSPro","id":19280436,"avatar_url":"https://avatars2.githubusercontent.com/u/19280436?v=4","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PBSPro/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":false,"url":"https://api.github.com/repos/PBSPro/pbspro","forks_url":"https://api.github.com/repos/PBSPro/pbspro/forks","keys_url":"https://api.github.com/repos/PBSPro/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PBSPro/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PBSPro/pbspro/teams","hooks_url":"https://api.github.com/repos/PBSPro/pbspro/hooks","issue_events_url":"https://api.github.com/repos/PBSPro/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/PBSPro/pbspro/events","assignees_url":"https://api.github.com/repos/PBSPro/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/PBSPro/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/PBSPro/pbspro/tags","blobs_url":"https://api.github.com/repos/PBSPro/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PBSPro/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PBSPro/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/PBSPro/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/PBSPro/pbspro/languages","stargazers_url":"https://api.github.com/repos/PBSPro/pbspro/stargazers","contributors_url":"https://api.github.com/repos/PBSPro/pbspro/contributors","subscribers_url":"https://api.github.com/repos/PBSPro/pbspro/subscribers","subscription_url":"https://api.github.com/repos/PBSPro/pbspro/subscription","commits_url":"https://api.github.com/repos/PBSPro/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/PBSPro/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/PBSPro/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/PBSPro/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/PBSPro/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PBSPro/pbspro/merges","archive_url":"https://api.github.com/repos/PBSPro/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PBSPro/pbspro/downloads","issues_url":"https://api.github.com/repos/PBSPro/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/PBSPro/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/PBSPro/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/PBSPro/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PBSPro/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/PBSPro/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/PBSPro/pbspro/deployments","created_at":"2016-05-18T04:31:29Z","updated_at":"2017-09-26T20:50:36Z","pushed_at":"2017-09-27T17:13:36Z","git_url":"git://github.com/PBSPro/pbspro.git","ssh_url":"[email protected]:PBSPro/pbspro.git","clone_url":"https://github.com/PBSPro/pbspro.git","svn_url":"https://github.com/PBSPro/pbspro","homepage":"www.pbspro.org","size":8430,"stargazers_count":113,"watchers_count":113,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":107,"mirror_url":null,"open_issues_count":15,"forks":107,"open_issues":15,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/378"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/378"},"issue":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/378"},"comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/378/comments"},"review_comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/378/comments"},"review_comment":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/378/commits"},"statuses":{"href":"https://api.github.com/repos/PBSPro/pbspro/statuses/eda46ddbe22f5ba55a844015b532f06577c07ac0"}},"author_association":"CONTRIBUTOR"}} | {
"id": 59082072,
"name": "PBSPro/pbspro",
"url": "https://api.github.com/repos/PBSPro/pbspro"
} | {
"id": 17924134,
"login": "arungrover",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17924134?",
"url": "https://api.github.com/users/arungrover"
} | {
"id": 19280436,
"login": "PBSPro",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19280436?",
"url": "https://api.github.com/orgs/PBSPro"
} | 2017-09-27T20:07:11 | 6645998340 | {"actor":{"display_login":"arungrover"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Pylons/pyramid/pulls/comments/113466652","pull_request_review_id":34857453,"id":113466652,"diff_hunk":"@@ -0,0 +1,283 @@\n+import uuid\n+\n+from webob.cookies import CookieProfile\n+from zope.interface import implementer\n+\n+\n+from pyramid.authentication import _SimpleSerializer\n+\n+from pyramid.compat import (\n+ urlparse,\n+ bytes_\n+)\n+from pyramid.exceptions import (\n+ BadCSRFOrigin,\n+ BadCSRFToken,\n+)\n+from pyramid.interfaces import ICSRFStoragePolicy\n+from pyramid.settings import aslist\n+from pyramid.util import (\n+ is_same_domain,\n+ strings_differ\n+)\n+\n+\n+@implementer(ICSRFStoragePolicy)\n+class SessionCSRFStoragePolicy(object):\n+ \"\"\" The default CSRF implementation, which mimics the behavior from older\n+ versions of Pyramid. The ``new_csrf_token`` and ``get_csrf_token`` methods\n+ are indirected to the underlying session implementation.\n+\n+ Note that using this CSRF implementation requires that\n+ a :term:`session factory` is configured.\n+\n+ .. versionadded :: 1.8a1\n+ \"\"\"\n+ def new_csrf_token(self, request):\n+ \"\"\" Sets a new CSRF token into the session and returns it. \"\"\"\n+ return request.session.new_csrf_token()\n+\n+ def get_csrf_token(self, request):\n+ \"\"\" Returns the currently active CSRF token from the session, generating\n+ a new one if needed.\"\"\"\n+ return request.session.get_csrf_token()\n+\n+ def check_csrf_token(self, request, supplied_token):\n+ \"\"\" Returns True if supplied_token is the same value as get_csrf_token\n+ returns for this request. \"\"\"\n+ expected = self.get_csrf_token(request)\n+ return not strings_differ(\n+ bytes_(expected, 'ascii'),\n+ bytes_(supplied_token, 'ascii'),\n+ )\n+\n+@implementer(ICSRFStoragePolicy)\n+class CookieCSRFStoragePolicy(object):\n+ \"\"\" An alternative CSRF implementation that stores its information in\n+ unauthenticated cookies, known as the 'Double Submit Cookie' method in the\n+ OWASP CSRF guidelines. This gives some additional flexibility with regards\n+ to scaling as the tokens can be generated and verified by a front-end\n+ server.\n+\n+ .. versionadded :: 1.8a1\n+ \"\"\"\n+\n+ def __init__(self, cookie_name='csrf_token', secure=False, httponly=False,\n+ domain=None, max_age=None, path='/'):\n+ serializer = _SimpleSerializer()\n+ self.cookie_profile = CookieProfile(\n+ cookie_name=cookie_name,\n+ secure=secure,\n+ max_age=max_age,\n+ httponly=httponly,\n+ path=path,\n+ serializer=serializer\n+ )\n+ self.domain = domain\n+\n+ def new_csrf_token(self, request):\n+ \"\"\" Sets a new CSRF token into the request and returns it. \"\"\"\n+ token = uuid.uuid4().hex\n+ def set_cookie(request, response):\n+ self.cookie_profile.set_cookies(\n+ response,\n+ token,\n+ )\n+ request.add_response_callback(set_cookie)\n+ return token\n+\n+ def get_csrf_token(self, request):\n+ \"\"\" Returns the currently active CSRF token by checking the cookies\n+ sent with the current request.\"\"\"\n+ bound_cookies = self.cookie_profile.bind(request)\n+ token = bound_cookies.get_value()\n+ if not token:\n+ token = self.new_csrf_token(request)\n+ return token\n+\n+ def check_csrf_token(self, request, supplied_token):\n+ \"\"\" Returns True if supplied_token is the same value as get_csrf_token\n+ returns for this request. \"\"\"\n+ expected = self.get_csrf_token(request)\n+ return not strings_differ(\n+ bytes_(expected, 'ascii'),\n+ bytes_(supplied_token, 'ascii'),\n+ )\n+\n+def get_csrf_token(request):\n+ \"\"\" Get the currently active CSRF token for the request passed, generating\n+ a new one using ``new_csrf_token(request)`` if one does not exist. This\n+ calls the equivalent method in the chosen CSRF protection implementation.\n+\n+ .. versionadded :: 1.8a1\n+ \"\"\"\n+ registry = request.registry\n+ csrf = registry.getUtility(ICSRFStoragePolicy)\n+ return csrf.get_csrf_token(request)\n+\n+\n+def new_csrf_token(request):\n+ \"\"\" Generate a new CSRF token for the request passed and persist it in an\n+ implementation defined manner. This calls the equivalent method in the\n+ chosen CSRF protection implementation.\n+\n+ .. versionadded :: 1.8a1\n+ \"\"\"\n+ registry = request.registry\n+ csrf = registry.getUtility(ICSRFStoragePolicy)\n+ return csrf.new_csrf_token(request)\n+\n+\n+def check_csrf_token(request,\n+ token='csrf_token',\n+ header='X-CSRF-Token',\n+ raises=True):\n+ \"\"\" Check the CSRF token returned by the\n+ :class:`pyramid.interfaces.ICSRFStoragePolicy` implementation against the value in\n+ ``request.POST.get(token)`` (if a POST request) or\n+ ``request.headers.get(header)``. If a ``token`` keyword is not supplied to\n+ this function, the string ``csrf_token`` will be used to look up the token\n+ in ``request.POST``. If a ``header`` keyword is not supplied to this\n+ function, the string ``X-CSRF-Token`` will be used to look up the token in\n+ ``request.headers``.\n+\n+ If the value supplied by post or by header doesn't match the value supplied\n+ by ``policy.get_csrf_token()`` (where ``policy`` is an implementation of\n+ :class:`pyramid.interfaces.ICSRFStoragePolicy`), and ``raises`` is ``True``, this\n+ function will raise an :exc:`pyramid.exceptions.BadCSRFToken` exception. If\n+ the values differ and ``raises`` is ``False``, this function will return\n+ ``False``. If the CSRF check is successful, this function will return\n+ ``True`` unconditionally.\n+\n+ See :ref:`auto_csrf_checking` for information about how to secure your\n+ application automatically against CSRF attacks.\n+\n+ .. versionadded:: 1.4a2\n+\n+ .. versionchanged:: 1.7a1\n+ A CSRF token passed in the query string of the request is no longer\n+ considered valid. It must be passed in either the request body or\n+ a header.\n+\n+ .. versionchanged:: 1.8a1\n+ Moved from pyramid.session to pyramid.csrf\n+ \"\"\"\n+ supplied_token = \"\"\n+ # We first check the headers for a csrf token, as that is significantly\n+ # cheaper than checking the POST body\n+ if header is not None:\n+ supplied_token = request.headers.get(header, \"\")\n+\n+ # If this is a POST/PUT/etc request, then we'll check the body to see if it\n+ # has a token. We explicitly use request.POST here because CSRF tokens\n+ # should never appear in an URL as doing so is a security issue. We also\n+ # explicitly check for request.POST here as we do not support sending form\n+ # encoded data over anything but a request.POST.\n+ if supplied_token == \"\" and token is not None:\n+ supplied_token = request.POST.get(token, \"\")\n+\n+ policy = request.registry.queryUtility(ICSRFStoragePolicy)\n+ if policy is None:\n+ # There is no policy set, but we are trying to validate a CSRF token\n+ # This means explicit validation has been asked for without configuring\n+ # the CSRF implementation. Fall back to SessionCSRFStoragePolicy as that is the\n+ # default\n+ policy = SessionCSRFStoragePolicy()\n+ if not policy.check_csrf_token(request, supplied_token):\n+ if raises:\n+ raise BadCSRFToken('check_csrf_token(): Invalid token')\n+ return False\n+ return True\n+\n+\n+def check_csrf_origin(request, trusted_origins=None, raises=True):\n+ \"\"\"\n+ Check the Origin of the request to see if it is a cross site request or\n+ not.\n+\n+ If the value supplied by the Origin or Referer header isn't one of the\n+ trusted origins and ``raises`` is ``True``, this function will raise a\n+ :exc:`pyramid.exceptions.BadCSRFOrigin` exception but if ``raises`` is\n+ ``False`` this function will return ``False`` instead. If the CSRF origin\n+ checks are successful this function will return ``True`` unconditionally.\n+\n+ Additional trusted origins may be added by passing a list of domain (and\n+ ports if nonstandard like `['example.com', 'dev.example.com:8080']`) in","path":"pyramid/csrf.py","position":205,"original_position":205,"commit_id":"7c0f098641fda4207ea6fa50c58b289926038697","original_commit_id":"7c0f098641fda4207ea6fa50c58b289926038697","user":{"login":"MatthewWilkes","id":98908,"avatar_url":"https://avatars1.githubusercontent.com/u/98908?v=3","gravatar_id":"","url":"https://api.github.com/users/MatthewWilkes","html_url":"https://github.com/MatthewWilkes","followers_url":"https://api.github.com/users/MatthewWilkes/followers","following_url":"https://api.github.com/users/MatthewWilkes/following{/other_user}","gists_url":"https://api.github.com/users/MatthewWilkes/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewWilkes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewWilkes/subscriptions","organizations_url":"https://api.github.com/users/MatthewWilkes/orgs","repos_url":"https://api.github.com/users/MatthewWilkes/repos","events_url":"https://api.github.com/users/MatthewWilkes/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewWilkes/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2017-04-26T14:27:33Z","updated_at":"2017-04-26T14:27:33Z","html_url":"https://github.com/Pylons/pyramid/pull/2854#discussion_r113466652","pull_request_url":"https://api.github.com/repos/Pylons/pyramid/pulls/2854","_links":{"self":{"href":"https://api.github.com/repos/Pylons/pyramid/pulls/comments/113466652"},"html":{"href":"https://github.com/Pylons/pyramid/pull/2854#discussion_r113466652"},"pull_request":{"href":"https://api.github.com/repos/Pylons/pyramid/pulls/2854"}}},"pull_request":{"url":"https://api.github.com/repos/Pylons/pyramid/pulls/2854","id":96893136,"html_url":"https://github.com/Pylons/pyramid/pull/2854","diff_url":"https://github.com/Pylons/pyramid/pull/2854.diff","patch_url":"https://github.com/Pylons/pyramid/pull/2854.patch","issue_url":"https://api.github.com/repos/Pylons/pyramid/issues/2854","number":2854,"state":"open","locked":false,"title":"Decouple CSRF protection from the session machinery","user":{"login":"MatthewWilkes","id":98908,"avatar_url":"https://avatars1.githubusercontent.com/u/98908?v=3","gravatar_id":"","url":"https://api.github.com/users/MatthewWilkes","html_url":"https://github.com/MatthewWilkes","followers_url":"https://api.github.com/users/MatthewWilkes/followers","following_url":"https://api.github.com/users/MatthewWilkes/following{/other_user}","gists_url":"https://api.github.com/users/MatthewWilkes/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewWilkes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewWilkes/subscriptions","organizations_url":"https://api.github.com/users/MatthewWilkes/orgs","repos_url":"https://api.github.com/users/MatthewWilkes/repos","events_url":"https://api.github.com/users/MatthewWilkes/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewWilkes/received_events","type":"User","site_admin":false},"body":"In #1573 @dstufft makes a number of feature requests about the CSRF implementation of Pyramid, most of which were added in 1.7.\r\n\r\nThis patch attempts to move the CSRF generation logic out of the session, so new CSRF implementations that do not depend on sessions can be added. It currently does not add any such implementations, the only one shipped is the default which falls back to an implementation of CSRF on the session.\r\n\r\nIt also introduces new utility functions for `get_csrf_token(request)` and `new_csrf_token(request)` in Python, as well as a `get_csrf_token()` in the template global scope, and repoints documentation to use these rather than explicitly calling the session machinery.\r\n\r\nThis was written at the DragonSprint by me and @jcerjak, a new contributor to Pyramid.","created_at":"2016-12-07T10:09:50Z","updated_at":"2017-04-26T14:27:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc237c07927dbbd990fa5325fd5a099e2db84097","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Pylons/pyramid/milestones/6","html_url":"https://github.com/Pylons/pyramid/milestone/6","labels_url":"https://api.github.com/repos/Pylons/pyramid/milestones/6/labels","id":2200173,"number":6,"title":"1.9","description":"","creator":{"login":"mmerickel","id":487237,"avatar_url":"https://avatars0.githubusercontent.com/u/487237?v=3","gravatar_id":"","url":"https://api.github.com/users/mmerickel","html_url":"https://github.com/mmerickel","followers_url":"https://api.github.com/users/mmerickel/followers","following_url":"https://api.github.com/users/mmerickel/following{/other_user}","gists_url":"https://api.github.com/users/mmerickel/gists{/gist_id}","starred_url":"https://api.github.com/users/mmerickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmerickel/subscriptions","organizations_url":"https://api.github.com/users/mmerickel/orgs","repos_url":"https://api.github.com/users/mmerickel/repos","events_url":"https://api.github.com/users/mmerickel/events{/privacy}","received_events_url":"https://api.github.com/users/mmerickel/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":2,"state":"open","created_at":"2016-12-16T06:49:54Z","updated_at":"2017-04-21T03:15:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Pylons/pyramid/pulls/2854/commits","review_comments_url":"https://api.github.com/repos/Pylons/pyramid/pulls/2854/comments","review_comment_url":"https://api.github.com/repos/Pylons/pyramid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Pylons/pyramid/issues/2854/comments","statuses_url":"https://api.github.com/repos/Pylons/pyramid/statuses/7c0f098641fda4207ea6fa50c58b289926038697","head":{"label":"MatthewWilkes:csrf_session_decouple","ref":"csrf_session_decouple","sha":"7c0f098641fda4207ea6fa50c58b289926038697","user":{"login":"MatthewWilkes","id":98908,"avatar_url":"https://avatars1.githubusercontent.com/u/98908?v=3","gravatar_id":"","url":"https://api.github.com/users/MatthewWilkes","html_url":"https://github.com/MatthewWilkes","followers_url":"https://api.github.com/users/MatthewWilkes/followers","following_url":"https://api.github.com/users/MatthewWilkes/following{/other_user}","gists_url":"https://api.github.com/users/MatthewWilkes/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewWilkes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewWilkes/subscriptions","organizations_url":"https://api.github.com/users/MatthewWilkes/orgs","repos_url":"https://api.github.com/users/MatthewWilkes/repos","events_url":"https://api.github.com/users/MatthewWilkes/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewWilkes/received_events","type":"User","site_admin":false},"repo":{"id":12321059,"name":"pyramid","full_name":"MatthewWilkes/pyramid","owner":{"login":"MatthewWilkes","id":98908,"avatar_url":"https://avatars1.githubusercontent.com/u/98908?v=3","gravatar_id":"","url":"https://api.github.com/users/MatthewWilkes","html_url":"https://github.com/MatthewWilkes","followers_url":"https://api.github.com/users/MatthewWilkes/followers","following_url":"https://api.github.com/users/MatthewWilkes/following{/other_user}","gists_url":"https://api.github.com/users/MatthewWilkes/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewWilkes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewWilkes/subscriptions","organizations_url":"https://api.github.com/users/MatthewWilkes/orgs","repos_url":"https://api.github.com/users/MatthewWilkes/repos","events_url":"https://api.github.com/users/MatthewWilkes/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewWilkes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MatthewWilkes/pyramid","description":"Pyramid web framework","fork":true,"url":"https://api.github.com/repos/MatthewWilkes/pyramid","forks_url":"https://api.github.com/repos/MatthewWilkes/pyramid/forks","keys_url":"https://api.github.com/repos/MatthewWilkes/pyramid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MatthewWilkes/pyramid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MatthewWilkes/pyramid/teams","hooks_url":"https://api.github.com/repos/MatthewWilkes/pyramid/hooks","issue_events_url":"https://api.github.com/repos/MatthewWilkes/pyramid/issues/events{/number}","events_url":"https://api.github.com/repos/MatthewWilkes/pyramid/events","assignees_url":"https://api.github.com/repos/MatthewWilkes/pyramid/assignees{/user}","branches_url":"https://api.github.com/repos/MatthewWilkes/pyramid/branches{/branch}","tags_url":"https://api.github.com/repos/MatthewWilkes/pyramid/tags","blobs_url":"https://api.github.com/repos/MatthewWilkes/pyramid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MatthewWilkes/pyramid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MatthewWilkes/pyramid/git/refs{/sha}","trees_url":"https://api.github.com/repos/MatthewWilkes/pyramid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MatthewWilkes/pyramid/statuses/{sha}","languages_url":"https://api.github.com/repos/MatthewWilkes/pyramid/languages","stargazers_url":"https://api.github.com/repos/MatthewWilkes/pyramid/stargazers","contributors_url":"https://api.github.com/repos/MatthewWilkes/pyramid/contributors","subscribers_url":"https://api.github.com/repos/MatthewWilkes/pyramid/subscribers","subscription_url":"https://api.github.com/repos/MatthewWilkes/pyramid/subscription","commits_url":"https://api.github.com/repos/MatthewWilkes/pyramid/commits{/sha}","git_commits_url":"https://api.github.com/repos/MatthewWilkes/pyramid/git/commits{/sha}","comments_url":"https://api.github.com/repos/MatthewWilkes/pyramid/comments{/number}","issue_comment_url":"https://api.github.com/repos/MatthewWilkes/pyramid/issues/comments{/number}","contents_url":"https://api.github.com/repos/MatthewWilkes/pyramid/contents/{+path}","compare_url":"https://api.github.com/repos/MatthewWilkes/pyramid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MatthewWilkes/pyramid/merges","archive_url":"https://api.github.com/repos/MatthewWilkes/pyramid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MatthewWilkes/pyramid/downloads","issues_url":"https://api.github.com/repos/MatthewWilkes/pyramid/issues{/number}","pulls_url":"https://api.github.com/repos/MatthewWilkes/pyramid/pulls{/number}","milestones_url":"https://api.github.com/repos/MatthewWilkes/pyramid/milestones{/number}","notifications_url":"https://api.github.com/repos/MatthewWilkes/pyramid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MatthewWilkes/pyramid/labels{/name}","releases_url":"https://api.github.com/repos/MatthewWilkes/pyramid/releases{/id}","deployments_url":"https://api.github.com/repos/MatthewWilkes/pyramid/deployments","created_at":"2013-08-23T11:09:54Z","updated_at":"2016-12-05T09:03:27Z","pushed_at":"2017-04-12T11:14:41Z","git_url":"git://github.com/MatthewWilkes/pyramid.git","ssh_url":"[email protected]:MatthewWilkes/pyramid.git","clone_url":"https://github.com/MatthewWilkes/pyramid.git","svn_url":"https://github.com/MatthewWilkes/pyramid","homepage":"http://pylonsproject.org","size":19885,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Pylons:master","ref":"master","sha":"387993115ee777784654c95d9f2f8d8ce7c4f5e4","user":{"login":"Pylons","id":452227,"avatar_url":"https://avatars2.githubusercontent.com/u/452227?v=3","gravatar_id":"","url":"https://api.github.com/users/Pylons","html_url":"https://github.com/Pylons","followers_url":"https://api.github.com/users/Pylons/followers","following_url":"https://api.github.com/users/Pylons/following{/other_user}","gists_url":"https://api.github.com/users/Pylons/gists{/gist_id}","starred_url":"https://api.github.com/users/Pylons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pylons/subscriptions","organizations_url":"https://api.github.com/users/Pylons/orgs","repos_url":"https://api.github.com/users/Pylons/repos","events_url":"https://api.github.com/users/Pylons/events{/privacy}","received_events_url":"https://api.github.com/users/Pylons/received_events","type":"Organization","site_admin":false},"repo":{"id":1020639,"name":"pyramid","full_name":"Pylons/pyramid","owner":{"login":"Pylons","id":452227,"avatar_url":"https://avatars2.githubusercontent.com/u/452227?v=3","gravatar_id":"","url":"https://api.github.com/users/Pylons","html_url":"https://github.com/Pylons","followers_url":"https://api.github.com/users/Pylons/followers","following_url":"https://api.github.com/users/Pylons/following{/other_user}","gists_url":"https://api.github.com/users/Pylons/gists{/gist_id}","starred_url":"https://api.github.com/users/Pylons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pylons/subscriptions","organizations_url":"https://api.github.com/users/Pylons/orgs","repos_url":"https://api.github.com/users/Pylons/repos","events_url":"https://api.github.com/users/Pylons/events{/privacy}","received_events_url":"https://api.github.com/users/Pylons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Pylons/pyramid","description":"Pyramid web framework","fork":false,"url":"https://api.github.com/repos/Pylons/pyramid","forks_url":"https://api.github.com/repos/Pylons/pyramid/forks","keys_url":"https://api.github.com/repos/Pylons/pyramid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pylons/pyramid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pylons/pyramid/teams","hooks_url":"https://api.github.com/repos/Pylons/pyramid/hooks","issue_events_url":"https://api.github.com/repos/Pylons/pyramid/issues/events{/number}","events_url":"https://api.github.com/repos/Pylons/pyramid/events","assignees_url":"https://api.github.com/repos/Pylons/pyramid/assignees{/user}","branches_url":"https://api.github.com/repos/Pylons/pyramid/branches{/branch}","tags_url":"https://api.github.com/repos/Pylons/pyramid/tags","blobs_url":"https://api.github.com/repos/Pylons/pyramid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pylons/pyramid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pylons/pyramid/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pylons/pyramid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pylons/pyramid/statuses/{sha}","languages_url":"https://api.github.com/repos/Pylons/pyramid/languages","stargazers_url":"https://api.github.com/repos/Pylons/pyramid/stargazers","contributors_url":"https://api.github.com/repos/Pylons/pyramid/contributors","subscribers_url":"https://api.github.com/repos/Pylons/pyramid/subscribers","subscription_url":"https://api.github.com/repos/Pylons/pyramid/subscription","commits_url":"https://api.github.com/repos/Pylons/pyramid/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pylons/pyramid/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pylons/pyramid/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pylons/pyramid/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pylons/pyramid/contents/{+path}","compare_url":"https://api.github.com/repos/Pylons/pyramid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pylons/pyramid/merges","archive_url":"https://api.github.com/repos/Pylons/pyramid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pylons/pyramid/downloads","issues_url":"https://api.github.com/repos/Pylons/pyramid/issues{/number}","pulls_url":"https://api.github.com/repos/Pylons/pyramid/pulls{/number}","milestones_url":"https://api.github.com/repos/Pylons/pyramid/milestones{/number}","notifications_url":"https://api.github.com/repos/Pylons/pyramid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pylons/pyramid/labels{/name}","releases_url":"https://api.github.com/repos/Pylons/pyramid/releases{/id}","deployments_url":"https://api.github.com/repos/Pylons/pyramid/deployments","created_at":"2010-10-24T22:00:35Z","updated_at":"2017-04-26T13:39:48Z","pushed_at":"2017-04-24T07:21:26Z","git_url":"git://github.com/Pylons/pyramid.git","ssh_url":"[email protected]:Pylons/pyramid.git","clone_url":"https://github.com/Pylons/pyramid.git","svn_url":"https://github.com/Pylons/pyramid","homepage":"https://trypyramid.com/","size":21135,"stargazers_count":2315,"watchers_count":2315,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":742,"mirror_url":null,"open_issues_count":97,"forks":742,"open_issues":97,"watchers":2315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Pylons/pyramid/pulls/2854"},"html":{"href":"https://github.com/Pylons/pyramid/pull/2854"},"issue":{"href":"https://api.github.com/repos/Pylons/pyramid/issues/2854"},"comments":{"href":"https://api.github.com/repos/Pylons/pyramid/issues/2854/comments"},"review_comments":{"href":"https://api.github.com/repos/Pylons/pyramid/pulls/2854/comments"},"review_comment":{"href":"https://api.github.com/repos/Pylons/pyramid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Pylons/pyramid/pulls/2854/commits"},"statuses":{"href":"https://api.github.com/repos/Pylons/pyramid/statuses/7c0f098641fda4207ea6fa50c58b289926038697"}}}} | {
"id": 1020639,
"name": "Pylons/pyramid",
"url": "https://api.github.com/repos/Pylons/pyramid"
} | {
"id": 98908,
"login": "MatthewWilkes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/98908?",
"url": "https://api.github.com/users/MatthewWilkes"
} | {
"id": 452227,
"login": "Pylons",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/452227?",
"url": "https://api.github.com/orgs/Pylons"
} | 2017-04-26T14:27:33 | 5760977234 | {"actor":{"display_login":"MatthewWilkes"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/RackHD/on-build-config/pulls/comments/134933357","pull_request_review_id":58283490,"id":134933357,"diff_hunk":"@@ -0,0 +1,41 @@\n+package pipeline.rackhd.docker\n+\n+def build(String manifest_path, String clone_dir, String workdir){\n+ def ret_dict=[:]\n+ node(build_docker_node){\n+ deleteDir()\n+ def current_workspace = pwd()\n+ String library_dir = \"./on-build-config\"\n+ def share_method = new pipeline.common.ShareMethod()\n+ share_method.checkoutOnBuildConfig(library_dir)\n+ withCredentials([\n+ usernamePassword(credentialsId: 'ff7ab8d2-e678-41ef-a46b-dd0e780030e1',\n+ passwordVariable: 'SUDO_PASSWORD',\n+ usernameVariable: 'SUDO_USER')]){\n+ timeout(90){\n+ withEnv([\"WORKSPACE=${current_workspace}\"]){\n+ sh \"\"\"#!/bin/bash -ex\n+ bash $library_dir/src/pipeline/rackhd/docker/build.sh \\\n+ --MANIFEST_FILE_URL ${manifest_path} \\\n+ --ARTIFACTORY_URL ${ARTIFACTORY_URL} \\\n+ --STAGE_REPO_NAME ${STAGE_REPO_NAME} \\\n+ --CLONE_DIR ${clone_dir} \\\n+ --IS_OFFICIAL_RELEASE ${IS_OFFICIAL_RELEASE} \\","path":"src/pipeline/rackhd/docker/Build.groovy","position":23,"original_position":23,"commit_id":"4baf07777409b7fff4bf055099ac1c333f44cf3a","original_commit_id":"4baf07777409b7fff4bf055099ac1c333f44cf3a","user":{"login":"PengTian0","id":19203416,"avatar_url":"https://avatars2.githubusercontent.com/u/19203416?v=4","gravatar_id":"","url":"https://api.github.com/users/PengTian0","html_url":"https://github.com/PengTian0","followers_url":"https://api.github.com/users/PengTian0/followers","following_url":"https://api.github.com/users/PengTian0/following{/other_user}","gists_url":"https://api.github.com/users/PengTian0/gists{/gist_id}","starred_url":"https://api.github.com/users/PengTian0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PengTian0/subscriptions","organizations_url":"https://api.github.com/users/PengTian0/orgs","repos_url":"https://api.github.com/users/PengTian0/repos","events_url":"https://api.github.com/users/PengTian0/events{/privacy}","received_events_url":"https://api.github.com/users/PengTian0/received_events","type":"User","site_admin":false},"body":"Please pass the parameter ```IS_OFFICIAL_RELEASE``` as argument of the function.","created_at":"2017-08-24T06:08:00Z","updated_at":"2017-08-24T06:08:00Z","html_url":"https://github.com/RackHD/on-build-config/pull/302#discussion_r134933357","pull_request_url":"https://api.github.com/repos/RackHD/on-build-config/pulls/302","_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-build-config/pulls/comments/134933357"},"html":{"href":"https://github.com/RackHD/on-build-config/pull/302#discussion_r134933357"},"pull_request":{"href":"https://api.github.com/repos/RackHD/on-build-config/pulls/302"}}},"pull_request":{"url":"https://api.github.com/repos/RackHD/on-build-config/pulls/302","id":136391056,"html_url":"https://github.com/RackHD/on-build-config/pull/302","diff_url":"https://github.com/RackHD/on-build-config/pull/302.diff","patch_url":"https://github.com/RackHD/on-build-config/pull/302.patch","issue_url":"https://api.github.com/repos/RackHD/on-build-config/issues/302","number":302,"state":"open","locked":false,"title":"RAC-5944: [refactor]Docker-Build: implement script build.sh,Build.groovy,deploy.sh,Deploy.groovy","user":{"login":"HQebupt","id":4970972,"avatar_url":"https://avatars1.githubusercontent.com/u/4970972?v=4","gravatar_id":"","url":"https://api.github.com/users/HQebupt","html_url":"https://github.com/HQebupt","followers_url":"https://api.github.com/users/HQebupt/followers","following_url":"https://api.github.com/users/HQebupt/following{/other_user}","gists_url":"https://api.github.com/users/HQebupt/gists{/gist_id}","starred_url":"https://api.github.com/users/HQebupt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HQebupt/subscriptions","organizations_url":"https://api.github.com/users/HQebupt/orgs","repos_url":"https://api.github.com/users/HQebupt/repos","events_url":"https://api.github.com/users/HQebupt/events{/privacy}","received_events_url":"https://api.github.com/users/HQebupt/received_events","type":"User","site_admin":false},"body":"motivation: to refactor docker build part in CI/CD pipeline ...\r\n\r\n## implementation:\r\n- a build.sh to provide a self-excutable script to build RackHD docker images and output a tar file with manifest file as input\r\n- a Build.Groovy to provide a groovy level function to build docker\r\n- a deploy.sh to deploy rackhd within docker\r\n- a Deploy.groovy to provide a groovy level function to deploy RackHD using docker-compose.yml.\r\n\r\n## test:\r\n- sandbox job: http://10.62.59.175:8080/blue/organizations/jenkins/qiang%2Fdocker-build/detail/docker-build/58/pipeline \r\n\r\nreviewer:\r\n\r\n@PengTian0 @panpan0000 ","created_at":"2017-08-18T02:35:25Z","updated_at":"2017-08-24T06:08:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c18346729ac04c2b964b58923bf6833781e415d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/RackHD/on-build-config/pulls/302/commits","review_comments_url":"https://api.github.com/repos/RackHD/on-build-config/pulls/302/comments","review_comment_url":"https://api.github.com/repos/RackHD/on-build-config/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RackHD/on-build-config/issues/302/comments","statuses_url":"https://api.github.com/repos/RackHD/on-build-config/statuses/4baf07777409b7fff4bf055099ac1c333f44cf3a","head":{"label":"HQebupt:pipeline_refactor","ref":"pipeline_refactor","sha":"4baf07777409b7fff4bf055099ac1c333f44cf3a","user":{"login":"HQebupt","id":4970972,"avatar_url":"https://avatars1.githubusercontent.com/u/4970972?v=4","gravatar_id":"","url":"https://api.github.com/users/HQebupt","html_url":"https://github.com/HQebupt","followers_url":"https://api.github.com/users/HQebupt/followers","following_url":"https://api.github.com/users/HQebupt/following{/other_user}","gists_url":"https://api.github.com/users/HQebupt/gists{/gist_id}","starred_url":"https://api.github.com/users/HQebupt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HQebupt/subscriptions","organizations_url":"https://api.github.com/users/HQebupt/orgs","repos_url":"https://api.github.com/users/HQebupt/repos","events_url":"https://api.github.com/users/HQebupt/events{/privacy}","received_events_url":"https://api.github.com/users/HQebupt/received_events","type":"User","site_admin":false},"repo":{"id":94182057,"name":"on-build-config","full_name":"HQebupt/on-build-config","owner":{"login":"HQebupt","id":4970972,"avatar_url":"https://avatars1.githubusercontent.com/u/4970972?v=4","gravatar_id":"","url":"https://api.github.com/users/HQebupt","html_url":"https://github.com/HQebupt","followers_url":"https://api.github.com/users/HQebupt/followers","following_url":"https://api.github.com/users/HQebupt/following{/other_user}","gists_url":"https://api.github.com/users/HQebupt/gists{/gist_id}","starred_url":"https://api.github.com/users/HQebupt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HQebupt/subscriptions","organizations_url":"https://api.github.com/users/HQebupt/orgs","repos_url":"https://api.github.com/users/HQebupt/repos","events_url":"https://api.github.com/users/HQebupt/events{/privacy}","received_events_url":"https://api.github.com/users/HQebupt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HQebupt/on-build-config","description":"Continuous Integration build tools","fork":true,"url":"https://api.github.com/repos/HQebupt/on-build-config","forks_url":"https://api.github.com/repos/HQebupt/on-build-config/forks","keys_url":"https://api.github.com/repos/HQebupt/on-build-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HQebupt/on-build-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HQebupt/on-build-config/teams","hooks_url":"https://api.github.com/repos/HQebupt/on-build-config/hooks","issue_events_url":"https://api.github.com/repos/HQebupt/on-build-config/issues/events{/number}","events_url":"https://api.github.com/repos/HQebupt/on-build-config/events","assignees_url":"https://api.github.com/repos/HQebupt/on-build-config/assignees{/user}","branches_url":"https://api.github.com/repos/HQebupt/on-build-config/branches{/branch}","tags_url":"https://api.github.com/repos/HQebupt/on-build-config/tags","blobs_url":"https://api.github.com/repos/HQebupt/on-build-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HQebupt/on-build-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HQebupt/on-build-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/HQebupt/on-build-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HQebupt/on-build-config/statuses/{sha}","languages_url":"https://api.github.com/repos/HQebupt/on-build-config/languages","stargazers_url":"https://api.github.com/repos/HQebupt/on-build-config/stargazers","contributors_url":"https://api.github.com/repos/HQebupt/on-build-config/contributors","subscribers_url":"https://api.github.com/repos/HQebupt/on-build-config/subscribers","subscription_url":"https://api.github.com/repos/HQebupt/on-build-config/subscription","commits_url":"https://api.github.com/repos/HQebupt/on-build-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/HQebupt/on-build-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/HQebupt/on-build-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/HQebupt/on-build-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/HQebupt/on-build-config/contents/{+path}","compare_url":"https://api.github.com/repos/HQebupt/on-build-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HQebupt/on-build-config/merges","archive_url":"https://api.github.com/repos/HQebupt/on-build-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HQebupt/on-build-config/downloads","issues_url":"https://api.github.com/repos/HQebupt/on-build-config/issues{/number}","pulls_url":"https://api.github.com/repos/HQebupt/on-build-config/pulls{/number}","milestones_url":"https://api.github.com/repos/HQebupt/on-build-config/milestones{/number}","notifications_url":"https://api.github.com/repos/HQebupt/on-build-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HQebupt/on-build-config/labels{/name}","releases_url":"https://api.github.com/repos/HQebupt/on-build-config/releases{/id}","deployments_url":"https://api.github.com/repos/HQebupt/on-build-config/deployments","created_at":"2017-06-13T07:13:58Z","updated_at":"2017-06-13T07:14:00Z","pushed_at":"2017-08-24T05:57:23Z","git_url":"git://github.com/HQebupt/on-build-config.git","ssh_url":"[email protected]:HQebupt/on-build-config.git","clone_url":"https://github.com/HQebupt/on-build-config.git","svn_url":"https://github.com/HQebupt/on-build-config","homepage":"","size":805,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RackHD:pipeline_refactor","ref":"pipeline_refactor","sha":"72722efd0a0ffbe85e0af7199f56c5c68ab53129","user":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars2.githubusercontent.com/u/13982662?v=4","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"repo":{"id":52533676,"name":"on-build-config","full_name":"RackHD/on-build-config","owner":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars2.githubusercontent.com/u/13982662?v=4","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RackHD/on-build-config","description":"Continuous Integration build tools","fork":true,"url":"https://api.github.com/repos/RackHD/on-build-config","forks_url":"https://api.github.com/repos/RackHD/on-build-config/forks","keys_url":"https://api.github.com/repos/RackHD/on-build-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RackHD/on-build-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RackHD/on-build-config/teams","hooks_url":"https://api.github.com/repos/RackHD/on-build-config/hooks","issue_events_url":"https://api.github.com/repos/RackHD/on-build-config/issues/events{/number}","events_url":"https://api.github.com/repos/RackHD/on-build-config/events","assignees_url":"https://api.github.com/repos/RackHD/on-build-config/assignees{/user}","branches_url":"https://api.github.com/repos/RackHD/on-build-config/branches{/branch}","tags_url":"https://api.github.com/repos/RackHD/on-build-config/tags","blobs_url":"https://api.github.com/repos/RackHD/on-build-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RackHD/on-build-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RackHD/on-build-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/RackHD/on-build-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RackHD/on-build-config/statuses/{sha}","languages_url":"https://api.github.com/repos/RackHD/on-build-config/languages","stargazers_url":"https://api.github.com/repos/RackHD/on-build-config/stargazers","contributors_url":"https://api.github.com/repos/RackHD/on-build-config/contributors","subscribers_url":"https://api.github.com/repos/RackHD/on-build-config/subscribers","subscription_url":"https://api.github.com/repos/RackHD/on-build-config/subscription","commits_url":"https://api.github.com/repos/RackHD/on-build-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/RackHD/on-build-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/RackHD/on-build-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/RackHD/on-build-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/RackHD/on-build-config/contents/{+path}","compare_url":"https://api.github.com/repos/RackHD/on-build-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RackHD/on-build-config/merges","archive_url":"https://api.github.com/repos/RackHD/on-build-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RackHD/on-build-config/downloads","issues_url":"https://api.github.com/repos/RackHD/on-build-config/issues{/number}","pulls_url":"https://api.github.com/repos/RackHD/on-build-config/pulls{/number}","milestones_url":"https://api.github.com/repos/RackHD/on-build-config/milestones{/number}","notifications_url":"https://api.github.com/repos/RackHD/on-build-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RackHD/on-build-config/labels{/name}","releases_url":"https://api.github.com/repos/RackHD/on-build-config/releases{/id}","deployments_url":"https://api.github.com/repos/RackHD/on-build-config/deployments","created_at":"2016-02-25T15:03:49Z","updated_at":"2017-07-06T06:31:07Z","pushed_at":"2017-08-24T05:59:20Z","git_url":"git://github.com/RackHD/on-build-config.git","ssh_url":"[email protected]:RackHD/on-build-config.git","clone_url":"https://github.com/RackHD/on-build-config.git","svn_url":"https://github.com/RackHD/on-build-config","homepage":"","size":768,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":11,"forks":29,"open_issues":11,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-build-config/pulls/302"},"html":{"href":"https://github.com/RackHD/on-build-config/pull/302"},"issue":{"href":"https://api.github.com/repos/RackHD/on-build-config/issues/302"},"comments":{"href":"https://api.github.com/repos/RackHD/on-build-config/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/RackHD/on-build-config/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/RackHD/on-build-config/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RackHD/on-build-config/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/RackHD/on-build-config/statuses/4baf07777409b7fff4bf055099ac1c333f44cf3a"}}}} | {
"id": 52533676,
"name": "RackHD/on-build-config",
"url": "https://api.github.com/repos/RackHD/on-build-config"
} | {
"id": 19203416,
"login": "PengTian0",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19203416?",
"url": "https://api.github.com/users/PengTian0"
} | {
"id": 13982662,
"login": "RackHD",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13982662?",
"url": "https://api.github.com/orgs/RackHD"
} | 2017-08-24T06:08:00 | 6505839441 | {"actor":{"display_login":"PengTian0"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/138562219","pull_request_review_id":62370305,"id":138562219,"diff_hunk":"@@ -238,8 +260,8 @@\n ### Shipping / ShippingBundle\n \n * `UnresolvedDefaultShippingMethodException` has been made final, use decoration instead of extending it.\n-* `setShippable(?ShippableInterface $shippable)` has been added to `ShipmentUnitInterface`.\n-* The following methods does not longer have a default null argument and requires one to be explicitly passed:\n+* `setShippable(?ShippableInterface $shippable)` method has been added to `ShipmentUnitInterface`.\n+* The following methods no have a default null argument and require one to be explicitly passed:","path":"UPGRADE.md","position":196,"original_position":196,"commit_id":"e271060a19f32454690b4c1fe1d3f4dbf0df4fb0","original_commit_id":"e271060a19f32454690b4c1fe1d3f4dbf0df4fb0","user":{"login":"venyii","id":502368,"avatar_url":"https://avatars3.githubusercontent.com/u/502368?v=4","gravatar_id":"","url":"https://api.github.com/users/venyii","html_url":"https://github.com/venyii","followers_url":"https://api.github.com/users/venyii/followers","following_url":"https://api.github.com/users/venyii/following{/other_user}","gists_url":"https://api.github.com/users/venyii/gists{/gist_id}","starred_url":"https://api.github.com/users/venyii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venyii/subscriptions","organizations_url":"https://api.github.com/users/venyii/orgs","repos_url":"https://api.github.com/users/venyii/repos","events_url":"https://api.github.com/users/venyii/events{/privacy}","received_events_url":"https://api.github.com/users/venyii/received_events","type":"User","site_admin":false},"body":"**don't** have\r\nor\r\nno **longer**","created_at":"2017-09-13T09:00:25Z","updated_at":"2017-09-13T09:02:23Z","html_url":"https://github.com/Sylius/Sylius/pull/8654#discussion_r138562219","pull_request_url":"https://api.github.com/repos/Sylius/Sylius/pulls/8654","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/138562219"},"html":{"href":"https://github.com/Sylius/Sylius/pull/8654#discussion_r138562219"},"pull_request":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/8654"}}},"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/8654","id":140763462,"html_url":"https://github.com/Sylius/Sylius/pull/8654","diff_url":"https://github.com/Sylius/Sylius/pull/8654.diff","patch_url":"https://github.com/Sylius/Sylius/pull/8654.patch","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/8654","number":8654,"state":"open","locked":false,"title":"UPGRADE file: Tips on 1.0.0 update","user":{"login":"CoderMaggie","id":13198869,"avatar_url":"https://avatars1.githubusercontent.com/u/13198869?v=4","gravatar_id":"","url":"https://api.github.com/users/CoderMaggie","html_url":"https://github.com/CoderMaggie","followers_url":"https://api.github.com/users/CoderMaggie/followers","following_url":"https://api.github.com/users/CoderMaggie/following{/other_user}","gists_url":"https://api.github.com/users/CoderMaggie/gists{/gist_id}","starred_url":"https://api.github.com/users/CoderMaggie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoderMaggie/subscriptions","organizations_url":"https://api.github.com/users/CoderMaggie/orgs","repos_url":"https://api.github.com/users/CoderMaggie/repos","events_url":"https://api.github.com/users/CoderMaggie/events{/privacy}","received_events_url":"https://api.github.com/users/CoderMaggie/received_events","type":"User","site_admin":false},"body":"| Q | A\r\n| --------------- | ---\r\n| Bug fix? | yes |\r\n| New feature? | no |\r\n| BC breaks? | no |\r\n| Related tickets | partially #8642 |\r\n| License | MIT |\r\n","created_at":"2017-09-13T08:30:08Z","updated_at":"2017-09-13T09:02:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2134801a2b55579ed5b38a8c7a19950f8a913008","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Sylius/Sylius/pulls/8654/commits","review_comments_url":"https://api.github.com/repos/Sylius/Sylius/pulls/8654/comments","review_comment_url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/8654/comments","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/e271060a19f32454690b4c1fe1d3f4dbf0df4fb0","head":{"label":"CoderMaggie:upgrade-to-one-zero","ref":"upgrade-to-one-zero","sha":"e271060a19f32454690b4c1fe1d3f4dbf0df4fb0","user":{"login":"CoderMaggie","id":13198869,"avatar_url":"https://avatars1.githubusercontent.com/u/13198869?v=4","gravatar_id":"","url":"https://api.github.com/users/CoderMaggie","html_url":"https://github.com/CoderMaggie","followers_url":"https://api.github.com/users/CoderMaggie/followers","following_url":"https://api.github.com/users/CoderMaggie/following{/other_user}","gists_url":"https://api.github.com/users/CoderMaggie/gists{/gist_id}","starred_url":"https://api.github.com/users/CoderMaggie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoderMaggie/subscriptions","organizations_url":"https://api.github.com/users/CoderMaggie/orgs","repos_url":"https://api.github.com/users/CoderMaggie/repos","events_url":"https://api.github.com/users/CoderMaggie/events{/privacy}","received_events_url":"https://api.github.com/users/CoderMaggie/received_events","type":"User","site_admin":false},"repo":{"id":42736498,"name":"Sylius","full_name":"CoderMaggie/Sylius","owner":{"login":"CoderMaggie","id":13198869,"avatar_url":"https://avatars1.githubusercontent.com/u/13198869?v=4","gravatar_id":"","url":"https://api.github.com/users/CoderMaggie","html_url":"https://github.com/CoderMaggie","followers_url":"https://api.github.com/users/CoderMaggie/followers","following_url":"https://api.github.com/users/CoderMaggie/following{/other_user}","gists_url":"https://api.github.com/users/CoderMaggie/gists{/gist_id}","starred_url":"https://api.github.com/users/CoderMaggie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoderMaggie/subscriptions","organizations_url":"https://api.github.com/users/CoderMaggie/orgs","repos_url":"https://api.github.com/users/CoderMaggie/repos","events_url":"https://api.github.com/users/CoderMaggie/events{/privacy}","received_events_url":"https://api.github.com/users/CoderMaggie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CoderMaggie/Sylius","description":"Modern e-commerce for PHP, based on the Symfony2 framework.","fork":true,"url":"https://api.github.com/repos/CoderMaggie/Sylius","forks_url":"https://api.github.com/repos/CoderMaggie/Sylius/forks","keys_url":"https://api.github.com/repos/CoderMaggie/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CoderMaggie/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CoderMaggie/Sylius/teams","hooks_url":"https://api.github.com/repos/CoderMaggie/Sylius/hooks","issue_events_url":"https://api.github.com/repos/CoderMaggie/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/CoderMaggie/Sylius/events","assignees_url":"https://api.github.com/repos/CoderMaggie/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/CoderMaggie/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/CoderMaggie/Sylius/tags","blobs_url":"https://api.github.com/repos/CoderMaggie/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CoderMaggie/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CoderMaggie/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/CoderMaggie/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CoderMaggie/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/CoderMaggie/Sylius/languages","stargazers_url":"https://api.github.com/repos/CoderMaggie/Sylius/stargazers","contributors_url":"https://api.github.com/repos/CoderMaggie/Sylius/contributors","subscribers_url":"https://api.github.com/repos/CoderMaggie/Sylius/subscribers","subscription_url":"https://api.github.com/repos/CoderMaggie/Sylius/subscription","commits_url":"https://api.github.com/repos/CoderMaggie/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/CoderMaggie/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/CoderMaggie/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/CoderMaggie/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/CoderMaggie/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/CoderMaggie/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CoderMaggie/Sylius/merges","archive_url":"https://api.github.com/repos/CoderMaggie/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CoderMaggie/Sylius/downloads","issues_url":"https://api.github.com/repos/CoderMaggie/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/CoderMaggie/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/CoderMaggie/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/CoderMaggie/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CoderMaggie/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/CoderMaggie/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/CoderMaggie/Sylius/deployments","created_at":"2015-09-18T17:21:15Z","updated_at":"2016-01-12T12:07:54Z","pushed_at":"2017-09-13T08:42:37Z","git_url":"git://github.com/CoderMaggie/Sylius.git","ssh_url":"[email protected]:CoderMaggie/Sylius.git","clone_url":"https://github.com/CoderMaggie/Sylius.git","svn_url":"https://github.com/CoderMaggie/Sylius","homepage":"Sylius.org","size":65017,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sylius:master","ref":"master","sha":"10710b39d7d51ad8d7fa99bef567354a0b65bd65","user":{"login":"Sylius","id":719423,"avatar_url":"https://avatars2.githubusercontent.com/u/719423?v=4","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":2717549,"name":"Sylius","full_name":"Sylius/Sylius","owner":{"login":"Sylius","id":719423,"avatar_url":"https://avatars2.githubusercontent.com/u/719423?v=4","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sylius/Sylius","description":"eCommerce PHP framework built on top of Symfony with component-based architecture and format-agnostic rendering. (HTML/JSON/XML)","fork":false,"url":"https://api.github.com/repos/Sylius/Sylius","forks_url":"https://api.github.com/repos/Sylius/Sylius/forks","keys_url":"https://api.github.com/repos/Sylius/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/Sylius/teams","hooks_url":"https://api.github.com/repos/Sylius/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Sylius/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/Sylius/events","assignees_url":"https://api.github.com/repos/Sylius/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/Sylius/tags","blobs_url":"https://api.github.com/repos/Sylius/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/Sylius/languages","stargazers_url":"https://api.github.com/repos/Sylius/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Sylius/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Sylius/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Sylius/Sylius/subscription","commits_url":"https://api.github.com/repos/Sylius/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sylius/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/Sylius/merges","archive_url":"https://api.github.com/repos/Sylius/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/Sylius/downloads","issues_url":"https://api.github.com/repos/Sylius/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/Sylius/Sylius/deployments","created_at":"2011-11-05T22:05:52Z","updated_at":"2017-09-13T08:07:33Z","pushed_at":"2017-09-13T08:54:51Z","git_url":"git://github.com/Sylius/Sylius.git","ssh_url":"[email protected]:Sylius/Sylius.git","clone_url":"https://github.com/Sylius/Sylius.git","svn_url":"https://github.com/Sylius/Sylius","homepage":"http://Sylius.org","size":62446,"stargazers_count":3382,"watchers_count":3382,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1188,"mirror_url":null,"open_issues_count":522,"forks":1188,"open_issues":522,"watchers":3382,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/8654"},"html":{"href":"https://github.com/Sylius/Sylius/pull/8654"},"issue":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/8654"},"comments":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/8654/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/8654/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/8654/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/Sylius/statuses/e271060a19f32454690b4c1fe1d3f4dbf0df4fb0"}},"author_association":"MEMBER"}} | {
"id": 2717549,
"name": "Sylius/Sylius",
"url": "https://api.github.com/repos/Sylius/Sylius"
} | {
"id": 502368,
"login": "venyii",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/502368?",
"url": "https://api.github.com/users/venyii"
} | {
"id": 719423,
"login": "Sylius",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/719423?",
"url": "https://api.github.com/orgs/Sylius"
} | 2017-09-13T09:00:25 | 6584123806 | {"actor":{"display_login":"venyii"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Talend/ui/pulls/comments/151345086","pull_request_review_id":77036668,"id":151345086,"diff_hunk":"@@ -0,0 +1,49 @@\n+import { take, put } from 'redux-saga/effects';\n+import { ACK_RECEIVE_MESSAGE } from '../constants';\n+\n+/**\n+ * this module define a high level API to handle ack in sagas\n+ * @module react-cmf-cqrs/lib/sagas/ack\n+ * @example\n+import { channel } from 'redux-saga';\n+import { fork, take, put, race, call, select } from 'redux-saga/effects';\n+import { sagas } from '@talend/react-cmf-cqrs';\n+function* onMyButtonClicked() {\n+ const requestId = objectID().toString();\n+ const chan = yield call(channel);\n+ yield fork(ack.listen, chan);\n+ const action = ... //action with ack and requestId\n+ yield put(action);\n+ yield call(ack.check, chan, requestId);\n+}\n+ */\n+\n+/**\n+ * this function let you listen a channel ACK_RECEIVE_MESSAGE\n+ * @param {Object} channel redux-saga channel\n+ */\n+function* listen(chan) {\n+\t// eslint-disable-next-line no-constant-condition\n+\twhile (true) {\n+\t\tconst action = yield take(ACK_RECEIVE_MESSAGE);\n+\t\tyield put(chan, action.requestId);\n+\t}\n+}\n+\n+/**\n+ * this function will wait for the ack to be filled.\n+ * @param {Object} channel redux-saga channel instance\n+ * @param {string} requestId the requestId to check in the channel\n+ */\n+function* check(chan, requestId) {","path":"packages/cmf-cqrs/src/sagas/ack.js","position":38,"original_position":38,"commit_id":"07a5078462844adc3fe2a82110efc3d12277c524","original_commit_id":"07a5078462844adc3fe2a82110efc3d12277c524","user":{"login":"acateland","id":19344650,"avatar_url":"https://avatars2.githubusercontent.com/u/19344650?v=4","gravatar_id":"","url":"https://api.github.com/users/acateland","html_url":"https://github.com/acateland","followers_url":"https://api.github.com/users/acateland/followers","following_url":"https://api.github.com/users/acateland/following{/other_user}","gists_url":"https://api.github.com/users/acateland/gists{/gist_id}","starred_url":"https://api.github.com/users/acateland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acateland/subscriptions","organizations_url":"https://api.github.com/users/acateland/orgs","repos_url":"https://api.github.com/users/acateland/repos","events_url":"https://api.github.com/users/acateland/events{/privacy}","received_events_url":"https://api.github.com/users/acateland/received_events","type":"User","site_admin":false},"body":"i vote in favor of the first proposition or what is actually available in code, for lisibility and understandability purpose","created_at":"2017-11-16T08:24:23Z","updated_at":"2017-11-16T08:25:20Z","html_url":"https://github.com/Talend/ui/pull/853#discussion_r151345086","pull_request_url":"https://api.github.com/repos/Talend/ui/pulls/853","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Talend/ui/pulls/comments/151345086"},"html":{"href":"https://github.com/Talend/ui/pull/853#discussion_r151345086"},"pull_request":{"href":"https://api.github.com/repos/Talend/ui/pulls/853"}},"in_reply_to_id":151341941},"pull_request":{"url":"https://api.github.com/repos/Talend/ui/pulls/853","id":152548079,"html_url":"https://github.com/Talend/ui/pull/853","diff_url":"https://github.com/Talend/ui/pull/853.diff","patch_url":"https://github.com/Talend/ui/pull/853.patch","issue_url":"https://api.github.com/repos/Talend/ui/issues/853","number":853,"state":"open","locked":false,"title":"feat(cmf-cqrs): add saga needed to do ack","user":{"login":"jmfrancois","id":19857479,"avatar_url":"https://avatars2.githubusercontent.com/u/19857479?v=4","gravatar_id":"","url":"https://api.github.com/users/jmfrancois","html_url":"https://github.com/jmfrancois","followers_url":"https://api.github.com/users/jmfrancois/followers","following_url":"https://api.github.com/users/jmfrancois/following{/other_user}","gists_url":"https://api.github.com/users/jmfrancois/gists{/gist_id}","starred_url":"https://api.github.com/users/jmfrancois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmfrancois/subscriptions","organizations_url":"https://api.github.com/users/jmfrancois/orgs","repos_url":"https://api.github.com/users/jmfrancois/repos","events_url":"https://api.github.com/users/jmfrancois/events{/privacy}","received_events_url":"https://api.github.com/users/jmfrancois/received_events","type":"User","site_admin":false},"body":"**What is the problem this PR is trying to solve?**\r\n\r\nwe are using saga and cqrs so we need to do ack inside saga\r\n\r\n**What is the chosen solution to this problem?**\r\n\r\nadd API to do so\r\n\r\n**Please check if the PR fulfills these requirements**\r\n- [x] The PR commit message follows our [guidelines](https://github.com/talend/tools/blob/master/tools-root-github/CONTRIBUTING.md)\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [x] Docs have been added / updated (for bug fixes / features)\r\n- [ ] Related design / discussions / pages (not in jira), if any, are all linked or available in the PR\r\n\r\n<!-- You can add more checkboxes here -->\r\n\r\n**[ ] This PR introduces a breaking change**\r\n\r\n<!-- **Original Template** -->\r\n<!-- https://github.com/Talend/tools/blob/master/tools-root-github/.github/PULL_REQUEST_TEMPLATE.md -->\r\n\r\n","created_at":"2017-11-14T16:12:19Z","updated_at":"2017-11-16T08:25:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b279d3356a592925f9cdca5c9f293ea0934a687","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/ui/pulls/853/commits","review_comments_url":"https://api.github.com/repos/Talend/ui/pulls/853/comments","review_comment_url":"https://api.github.com/repos/Talend/ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/ui/issues/853/comments","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/07a5078462844adc3fe2a82110efc3d12277c524","head":{"label":"Talend:jmfrancois/feat/cmf-cqrs/add-saga-ack","ref":"jmfrancois/feat/cmf-cqrs/add-saga-ack","sha":"07a5078462844adc3fe2a82110efc3d12277c524","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":79343946,"name":"ui","full_name":"Talend/ui","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/ui","description":"Talend's unified web UI repository.","fork":false,"url":"https://api.github.com/repos/Talend/ui","forks_url":"https://api.github.com/repos/Talend/ui/forks","keys_url":"https://api.github.com/repos/Talend/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/ui/teams","hooks_url":"https://api.github.com/repos/Talend/ui/hooks","issue_events_url":"https://api.github.com/repos/Talend/ui/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/ui/events","assignees_url":"https://api.github.com/repos/Talend/ui/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/ui/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/ui/tags","blobs_url":"https://api.github.com/repos/Talend/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/ui/languages","stargazers_url":"https://api.github.com/repos/Talend/ui/stargazers","contributors_url":"https://api.github.com/repos/Talend/ui/contributors","subscribers_url":"https://api.github.com/repos/Talend/ui/subscribers","subscription_url":"https://api.github.com/repos/Talend/ui/subscription","commits_url":"https://api.github.com/repos/Talend/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/ui/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/ui/merges","archive_url":"https://api.github.com/repos/Talend/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/ui/downloads","issues_url":"https://api.github.com/repos/Talend/ui/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/ui/labels{/name}","releases_url":"https://api.github.com/repos/Talend/ui/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/ui/deployments","created_at":"2017-01-18T13:45:58Z","updated_at":"2017-11-13T10:56:58Z","pushed_at":"2017-11-16T07:43:46Z","git_url":"git://github.com/Talend/ui.git","ssh_url":"[email protected]:Talend/ui.git","clone_url":"https://github.com/Talend/ui.git","svn_url":"https://github.com/Talend/ui","homepage":"http://talend.surge.sh","size":19715,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":42,"forks":14,"open_issues":42,"watchers":35,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"fd2e4865018f13348f9181ec899940cd7a3a3b93","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":79343946,"name":"ui","full_name":"Talend/ui","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/ui","description":"Talend's unified web UI repository.","fork":false,"url":"https://api.github.com/repos/Talend/ui","forks_url":"https://api.github.com/repos/Talend/ui/forks","keys_url":"https://api.github.com/repos/Talend/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/ui/teams","hooks_url":"https://api.github.com/repos/Talend/ui/hooks","issue_events_url":"https://api.github.com/repos/Talend/ui/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/ui/events","assignees_url":"https://api.github.com/repos/Talend/ui/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/ui/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/ui/tags","blobs_url":"https://api.github.com/repos/Talend/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/ui/languages","stargazers_url":"https://api.github.com/repos/Talend/ui/stargazers","contributors_url":"https://api.github.com/repos/Talend/ui/contributors","subscribers_url":"https://api.github.com/repos/Talend/ui/subscribers","subscription_url":"https://api.github.com/repos/Talend/ui/subscription","commits_url":"https://api.github.com/repos/Talend/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/ui/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/ui/merges","archive_url":"https://api.github.com/repos/Talend/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/ui/downloads","issues_url":"https://api.github.com/repos/Talend/ui/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/ui/labels{/name}","releases_url":"https://api.github.com/repos/Talend/ui/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/ui/deployments","created_at":"2017-01-18T13:45:58Z","updated_at":"2017-11-13T10:56:58Z","pushed_at":"2017-11-16T07:43:46Z","git_url":"git://github.com/Talend/ui.git","ssh_url":"[email protected]:Talend/ui.git","clone_url":"https://github.com/Talend/ui.git","svn_url":"https://github.com/Talend/ui","homepage":"http://talend.surge.sh","size":19715,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":42,"forks":14,"open_issues":42,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/ui/pulls/853"},"html":{"href":"https://github.com/Talend/ui/pull/853"},"issue":{"href":"https://api.github.com/repos/Talend/ui/issues/853"},"comments":{"href":"https://api.github.com/repos/Talend/ui/issues/853/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/ui/pulls/853/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/ui/pulls/853/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/ui/statuses/07a5078462844adc3fe2a82110efc3d12277c524"}},"author_association":"MEMBER"}} | {
"id": 79343946,
"name": "Talend/ui",
"url": "https://api.github.com/repos/Talend/ui"
} | {
"id": 19344650,
"login": "acateland",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19344650?",
"url": "https://api.github.com/users/acateland"
} | {
"id": 459687,
"login": "Talend",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/459687?",
"url": "https://api.github.com/orgs/Talend"
} | 2017-11-16T08:24:23 | 6862968998 | {"actor":{"display_login":"acateland"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ZeroCM/zcm/pulls/comments/149492504","pull_request_review_id":74893450,"id":149492504,"diff_hunk":"@@ -0,0 +1,334 @@\n+module ZCM\n+\n+# RRR / Note: Julia requires that the memory layout of the C structs is consistent\n+# between their definitions in zcm headers and this file\n+\n+# C ptr types for types that we don't need the internals of\n+module Native\n+\n+type Zcm\n+end\n+\n+type Sub\n+end\n+\n+type UvSub\n+end\n+\n+type RecvBuf\n+ recv_utime ::Int64;\n+ zcm ::Ptr{Native.Zcm};\n+ data ::Ptr{UInt8};\n+ data_size ::UInt32;\n+end\n+\n+type EventLog\n+end\n+\n+type EventLogEvent\n+ eventnum ::Int64;\n+ timestamp ::Int64;\n+ chanlen ::Int32;\n+ datalen ::Int32;\n+ channel ::Ptr{UInt8};\n+ data ::Ptr{UInt8};\n+end\n+\n+end\n+\n+# RRR: make variable naming consistent\n+# RRR: improve orgainzation and make header comments more visible\n+# Exported Objects and Methods\n+type RecvBuf\n+ rbuf ::Ptr{Native.RecvBuf};\n+ utime ::Int64;\n+ data ::Array{UInt8};\n+\n+ function RecvBuf(rbuf::Ptr{Native.RecvBuf})\n+ instance = new();\n+ instance.rbuf = rbuf;\n+\n+ if (rbuf != C_NULL)\n+ loadedRbuf = unsafe_load(rbuf);\n+\n+ instance.utime = loadedRbuf.recv_utime;\n+\n+ if (loadedRbuf.data != C_NULL)\n+ instance.data = unsafe_wrap(Array, loadedRbuf.data, loadedRbuf.data_size);\n+ else\n+ instance.data = [];\n+ end\n+ end\n+\n+ # destruction of the underlying Native.RecvBuf pointer is handled by the C lib internally\n+\n+ return instance;\n+ end\n+end\n+export RecvBuf;\n+\n+type __zcm_handler\n+ handler::Any;\n+ usr::Any;\n+\n+ # handler must have the function or functor prototype :\n+ # (rbuf::RecvBuf, channel::String, msg::MsgType, usr)\n+ __zcm_handler(handler, usr) = new(handler, usr);","path":"zcm/julia/ZCM.jl","position":76,"original_position":76,"commit_id":"4be6c9fa0cb84ea69af8fde81965e05a76398891","original_commit_id":"4be6c9fa0cb84ea69af8fde81965e05a76398891","user":{"login":"tkoolen","id":2585880,"avatar_url":"https://avatars0.githubusercontent.com/u/2585880?v=4","gravatar_id":"","url":"https://api.github.com/users/tkoolen","html_url":"https://github.com/tkoolen","followers_url":"https://api.github.com/users/tkoolen/followers","following_url":"https://api.github.com/users/tkoolen/following{/other_user}","gists_url":"https://api.github.com/users/tkoolen/gists{/gist_id}","starred_url":"https://api.github.com/users/tkoolen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkoolen/subscriptions","organizations_url":"https://api.github.com/users/tkoolen/orgs","repos_url":"https://api.github.com/users/tkoolen/repos","events_url":"https://api.github.com/users/tkoolen/events{/privacy}","received_events_url":"https://api.github.com/users/tkoolen/received_events","type":"User","site_admin":false},"body":"This constructor is already generated by default.","created_at":"2017-11-07T20:21:20Z","updated_at":"2017-11-07T20:48:48Z","html_url":"https://github.com/ZeroCM/zcm/pull/163#discussion_r149492504","pull_request_url":"https://api.github.com/repos/ZeroCM/zcm/pulls/163","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ZeroCM/zcm/pulls/comments/149492504"},"html":{"href":"https://github.com/ZeroCM/zcm/pull/163#discussion_r149492504"},"pull_request":{"href":"https://api.github.com/repos/ZeroCM/zcm/pulls/163"}}},"pull_request":{"url":"https://api.github.com/repos/ZeroCM/zcm/pulls/163","id":151023142,"html_url":"https://github.com/ZeroCM/zcm/pull/163","diff_url":"https://github.com/ZeroCM/zcm/pull/163.diff","patch_url":"https://github.com/ZeroCM/zcm/pull/163.patch","issue_url":"https://api.github.com/repos/ZeroCM/zcm/issues/163","number":163,"state":"open","locked":false,"title":"Core julia support","user":{"login":"jbendes","id":3058256,"avatar_url":"https://avatars2.githubusercontent.com/u/3058256?v=4","gravatar_id":"","url":"https://api.github.com/users/jbendes","html_url":"https://github.com/jbendes","followers_url":"https://api.github.com/users/jbendes/followers","following_url":"https://api.github.com/users/jbendes/following{/other_user}","gists_url":"https://api.github.com/users/jbendes/gists{/gist_id}","starred_url":"https://api.github.com/users/jbendes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbendes/subscriptions","organizations_url":"https://api.github.com/users/jbendes/orgs","repos_url":"https://api.github.com/users/jbendes/repos","events_url":"https://api.github.com/users/jbendes/events{/privacy}","received_events_url":"https://api.github.com/users/jbendes/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-07T04:32:41Z","updated_at":"2017-11-07T20:48:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c97e64aac32b3c6ea19792a58fe98a21ed265d7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"olsoni","id":13596028,"avatar_url":"https://avatars0.githubusercontent.com/u/13596028?v=4","gravatar_id":"","url":"https://api.github.com/users/olsoni","html_url":"https://github.com/olsoni","followers_url":"https://api.github.com/users/olsoni/followers","following_url":"https://api.github.com/users/olsoni/following{/other_user}","gists_url":"https://api.github.com/users/olsoni/gists{/gist_id}","starred_url":"https://api.github.com/users/olsoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olsoni/subscriptions","organizations_url":"https://api.github.com/users/olsoni/orgs","repos_url":"https://api.github.com/users/olsoni/repos","events_url":"https://api.github.com/users/olsoni/events{/privacy}","received_events_url":"https://api.github.com/users/olsoni/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ZeroCM/zcm/pulls/163/commits","review_comments_url":"https://api.github.com/repos/ZeroCM/zcm/pulls/163/comments","review_comment_url":"https://api.github.com/repos/ZeroCM/zcm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ZeroCM/zcm/issues/163/comments","statuses_url":"https://api.github.com/repos/ZeroCM/zcm/statuses/4be6c9fa0cb84ea69af8fde81965e05a76398891","head":{"label":"ZeroCM:core-julia_support","ref":"core-julia_support","sha":"4be6c9fa0cb84ea69af8fde81965e05a76398891","user":{"login":"ZeroCM","id":13577665,"avatar_url":"https://avatars1.githubusercontent.com/u/13577665?v=4","gravatar_id":"","url":"https://api.github.com/users/ZeroCM","html_url":"https://github.com/ZeroCM","followers_url":"https://api.github.com/users/ZeroCM/followers","following_url":"https://api.github.com/users/ZeroCM/following{/other_user}","gists_url":"https://api.github.com/users/ZeroCM/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeroCM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeroCM/subscriptions","organizations_url":"https://api.github.com/users/ZeroCM/orgs","repos_url":"https://api.github.com/users/ZeroCM/repos","events_url":"https://api.github.com/users/ZeroCM/events{/privacy}","received_events_url":"https://api.github.com/users/ZeroCM/received_events","type":"Organization","site_admin":false},"repo":{"id":39970218,"name":"zcm","full_name":"ZeroCM/zcm","owner":{"login":"ZeroCM","id":13577665,"avatar_url":"https://avatars1.githubusercontent.com/u/13577665?v=4","gravatar_id":"","url":"https://api.github.com/users/ZeroCM","html_url":"https://github.com/ZeroCM","followers_url":"https://api.github.com/users/ZeroCM/followers","following_url":"https://api.github.com/users/ZeroCM/following{/other_user}","gists_url":"https://api.github.com/users/ZeroCM/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeroCM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeroCM/subscriptions","organizations_url":"https://api.github.com/users/ZeroCM/orgs","repos_url":"https://api.github.com/users/ZeroCM/repos","events_url":"https://api.github.com/users/ZeroCM/events{/privacy}","received_events_url":"https://api.github.com/users/ZeroCM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ZeroCM/zcm","description":"Zero Communications and Marshalling","fork":false,"url":"https://api.github.com/repos/ZeroCM/zcm","forks_url":"https://api.github.com/repos/ZeroCM/zcm/forks","keys_url":"https://api.github.com/repos/ZeroCM/zcm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZeroCM/zcm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZeroCM/zcm/teams","hooks_url":"https://api.github.com/repos/ZeroCM/zcm/hooks","issue_events_url":"https://api.github.com/repos/ZeroCM/zcm/issues/events{/number}","events_url":"https://api.github.com/repos/ZeroCM/zcm/events","assignees_url":"https://api.github.com/repos/ZeroCM/zcm/assignees{/user}","branches_url":"https://api.github.com/repos/ZeroCM/zcm/branches{/branch}","tags_url":"https://api.github.com/repos/ZeroCM/zcm/tags","blobs_url":"https://api.github.com/repos/ZeroCM/zcm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZeroCM/zcm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZeroCM/zcm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZeroCM/zcm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZeroCM/zcm/statuses/{sha}","languages_url":"https://api.github.com/repos/ZeroCM/zcm/languages","stargazers_url":"https://api.github.com/repos/ZeroCM/zcm/stargazers","contributors_url":"https://api.github.com/repos/ZeroCM/zcm/contributors","subscribers_url":"https://api.github.com/repos/ZeroCM/zcm/subscribers","subscription_url":"https://api.github.com/repos/ZeroCM/zcm/subscription","commits_url":"https://api.github.com/repos/ZeroCM/zcm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZeroCM/zcm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZeroCM/zcm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZeroCM/zcm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZeroCM/zcm/contents/{+path}","compare_url":"https://api.github.com/repos/ZeroCM/zcm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZeroCM/zcm/merges","archive_url":"https://api.github.com/repos/ZeroCM/zcm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZeroCM/zcm/downloads","issues_url":"https://api.github.com/repos/ZeroCM/zcm/issues{/number}","pulls_url":"https://api.github.com/repos/ZeroCM/zcm/pulls{/number}","milestones_url":"https://api.github.com/repos/ZeroCM/zcm/milestones{/number}","notifications_url":"https://api.github.com/repos/ZeroCM/zcm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZeroCM/zcm/labels{/name}","releases_url":"https://api.github.com/repos/ZeroCM/zcm/releases{/id}","deployments_url":"https://api.github.com/repos/ZeroCM/zcm/deployments","created_at":"2015-07-30T20:09:31Z","updated_at":"2017-10-20T09:44:30Z","pushed_at":"2017-11-07T19:20:14Z","git_url":"git://github.com/ZeroCM/zcm.git","ssh_url":"[email protected]:ZeroCM/zcm.git","clone_url":"https://github.com/ZeroCM/zcm.git","svn_url":"https://github.com/ZeroCM/zcm","homepage":"http://zerocm.github.io/zcm/","size":2861,"stargazers_count":24,"watchers_count":24,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":53,"forks":11,"open_issues":53,"watchers":24,"default_branch":"master"}},"base":{"label":"ZeroCM:master","ref":"master","sha":"b33b0cec0e5cd37e59d1abfab1734936c89b6d77","user":{"login":"ZeroCM","id":13577665,"avatar_url":"https://avatars1.githubusercontent.com/u/13577665?v=4","gravatar_id":"","url":"https://api.github.com/users/ZeroCM","html_url":"https://github.com/ZeroCM","followers_url":"https://api.github.com/users/ZeroCM/followers","following_url":"https://api.github.com/users/ZeroCM/following{/other_user}","gists_url":"https://api.github.com/users/ZeroCM/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeroCM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeroCM/subscriptions","organizations_url":"https://api.github.com/users/ZeroCM/orgs","repos_url":"https://api.github.com/users/ZeroCM/repos","events_url":"https://api.github.com/users/ZeroCM/events{/privacy}","received_events_url":"https://api.github.com/users/ZeroCM/received_events","type":"Organization","site_admin":false},"repo":{"id":39970218,"name":"zcm","full_name":"ZeroCM/zcm","owner":{"login":"ZeroCM","id":13577665,"avatar_url":"https://avatars1.githubusercontent.com/u/13577665?v=4","gravatar_id":"","url":"https://api.github.com/users/ZeroCM","html_url":"https://github.com/ZeroCM","followers_url":"https://api.github.com/users/ZeroCM/followers","following_url":"https://api.github.com/users/ZeroCM/following{/other_user}","gists_url":"https://api.github.com/users/ZeroCM/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeroCM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeroCM/subscriptions","organizations_url":"https://api.github.com/users/ZeroCM/orgs","repos_url":"https://api.github.com/users/ZeroCM/repos","events_url":"https://api.github.com/users/ZeroCM/events{/privacy}","received_events_url":"https://api.github.com/users/ZeroCM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ZeroCM/zcm","description":"Zero Communications and Marshalling","fork":false,"url":"https://api.github.com/repos/ZeroCM/zcm","forks_url":"https://api.github.com/repos/ZeroCM/zcm/forks","keys_url":"https://api.github.com/repos/ZeroCM/zcm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZeroCM/zcm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZeroCM/zcm/teams","hooks_url":"https://api.github.com/repos/ZeroCM/zcm/hooks","issue_events_url":"https://api.github.com/repos/ZeroCM/zcm/issues/events{/number}","events_url":"https://api.github.com/repos/ZeroCM/zcm/events","assignees_url":"https://api.github.com/repos/ZeroCM/zcm/assignees{/user}","branches_url":"https://api.github.com/repos/ZeroCM/zcm/branches{/branch}","tags_url":"https://api.github.com/repos/ZeroCM/zcm/tags","blobs_url":"https://api.github.com/repos/ZeroCM/zcm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZeroCM/zcm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZeroCM/zcm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZeroCM/zcm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZeroCM/zcm/statuses/{sha}","languages_url":"https://api.github.com/repos/ZeroCM/zcm/languages","stargazers_url":"https://api.github.com/repos/ZeroCM/zcm/stargazers","contributors_url":"https://api.github.com/repos/ZeroCM/zcm/contributors","subscribers_url":"https://api.github.com/repos/ZeroCM/zcm/subscribers","subscription_url":"https://api.github.com/repos/ZeroCM/zcm/subscription","commits_url":"https://api.github.com/repos/ZeroCM/zcm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZeroCM/zcm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZeroCM/zcm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZeroCM/zcm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZeroCM/zcm/contents/{+path}","compare_url":"https://api.github.com/repos/ZeroCM/zcm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZeroCM/zcm/merges","archive_url":"https://api.github.com/repos/ZeroCM/zcm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZeroCM/zcm/downloads","issues_url":"https://api.github.com/repos/ZeroCM/zcm/issues{/number}","pulls_url":"https://api.github.com/repos/ZeroCM/zcm/pulls{/number}","milestones_url":"https://api.github.com/repos/ZeroCM/zcm/milestones{/number}","notifications_url":"https://api.github.com/repos/ZeroCM/zcm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZeroCM/zcm/labels{/name}","releases_url":"https://api.github.com/repos/ZeroCM/zcm/releases{/id}","deployments_url":"https://api.github.com/repos/ZeroCM/zcm/deployments","created_at":"2015-07-30T20:09:31Z","updated_at":"2017-10-20T09:44:30Z","pushed_at":"2017-11-07T19:20:14Z","git_url":"git://github.com/ZeroCM/zcm.git","ssh_url":"[email protected]:ZeroCM/zcm.git","clone_url":"https://github.com/ZeroCM/zcm.git","svn_url":"https://github.com/ZeroCM/zcm","homepage":"http://zerocm.github.io/zcm/","size":2861,"stargazers_count":24,"watchers_count":24,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":53,"forks":11,"open_issues":53,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ZeroCM/zcm/pulls/163"},"html":{"href":"https://github.com/ZeroCM/zcm/pull/163"},"issue":{"href":"https://api.github.com/repos/ZeroCM/zcm/issues/163"},"comments":{"href":"https://api.github.com/repos/ZeroCM/zcm/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/ZeroCM/zcm/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/ZeroCM/zcm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ZeroCM/zcm/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/ZeroCM/zcm/statuses/4be6c9fa0cb84ea69af8fde81965e05a76398891"}},"author_association":"OWNER"}} | {
"id": 39970218,
"name": "ZeroCM/zcm",
"url": "https://api.github.com/repos/ZeroCM/zcm"
} | {
"id": 2585880,
"login": "tkoolen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2585880?",
"url": "https://api.github.com/users/tkoolen"
} | {
"id": 13577665,
"login": "ZeroCM",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13577665?",
"url": "https://api.github.com/orgs/ZeroCM"
} | 2017-11-07T20:21:20 | 6822643676 | {"actor":{"display_login":"tkoolen"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments/130918525","pull_request_review_id":53843466,"id":130918525,"diff_hunk":"@@ -0,0 +1,124 @@\n+<?php\n+\n+namespace Pim\\Bundle\\CatalogBundle\\Elasticsearch\\Indexer;\n+\n+use Akeneo\\Bundle\\ElasticsearchBundle\\Client;\n+use Akeneo\\Bundle\\ElasticsearchBundle\\Refresh;\n+use Akeneo\\Component\\StorageUtils\\Indexer\\BulkIndexerInterface;\n+use Akeneo\\Component\\StorageUtils\\Indexer\\IndexerInterface;\n+use Akeneo\\Component\\StorageUtils\\Remover\\BulkRemoverInterface;\n+use Akeneo\\Component\\StorageUtils\\Remover\\RemoverInterface;\n+use Pim\\Component\\Catalog\\Normalizer\\Indexing\\ProductModelNormalizer;\n+use Symfony\\Component\\Serializer\\Normalizer\\NormalizerInterface;\n+\n+/**\n+ * Product model indexer, define custom logic and options for product model indexing in the search engine.\n+ *\n+ * @author Julien Janvier <[email protected]>\n+ * @copyright 2017 Akeneo SAS (http://www.akeneo.com)\n+ * @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)\n+ */\n+class ProductModelIndexer implements IndexerInterface, BulkIndexerInterface, RemoverInterface, BulkRemoverInterface\n+{\n+ /** @var NormalizerInterface */\n+ protected $normalizer;\n+\n+ /** @var Client */\n+ protected $productAndProductModelClient;\n+\n+ /** @var string */\n+ protected $indexType;\n+\n+ /**\n+ * @param NormalizerInterface $normalizer\n+ * @param Client $productAndProductModelClient\n+ * @param string $indexType\n+ */\n+ public function __construct(\n+ NormalizerInterface $normalizer,\n+ Client $productAndProductModelClient,\n+ string $indexType\n+ ) {\n+ $this->normalizer = $normalizer;\n+ $this->productAndProductModelClient = $productAndProductModelClient;\n+ $this->indexType = $indexType;\n+ }\n+\n+ /**\n+ * Indexes a product in both the product index and the product and product model index.\n+ *\n+ * {@inheritdoc}\n+ */\n+ public function index($object, array $options = [])\n+ {\n+ $normalizedObject = $this->normalizer->normalize(\n+ $object,\n+ ProductModelNormalizer::INDEXING_FORMAT_PRODUCT_AND_MODEL_INDEX\n+ );\n+ $this->validateObjectNormalization($normalizedObject);\n+ $this->productAndProductModelClient->index($this->indexType, $normalizedObject['id'], $normalizedObject);\n+ }\n+\n+ /**\n+ * Indexes a product in both the product index and the product and product model index.\n+ *\n+ * {@inheritdoc}\n+ */\n+ public function indexAll(array $objects, array $options = [])\n+ {\n+ if (empty($objects)) {\n+ return;\n+ }\n+\n+ $normalizedObjects = [];\n+\n+ foreach ($objects as $object) {\n+ $normalizedObject = $this->normalizer->normalize(\n+ $object,\n+ ProductModelNormalizer::INDEXING_FORMAT_PRODUCT_AND_MODEL_INDEX\n+ );\n+ $this->validateObjectNormalization($normalizedObject);\n+ $normalizedObjects[] = $normalizedObject;\n+ }\n+\n+ $this->productAndProductModelClient->bulkIndexes(\n+ $this->indexType,\n+ $normalizedObjects,\n+ 'id',\n+ Refresh::waitFor()\n+ );\n+ }\n+\n+ /**\n+ * Removes the product from both the product index and the product and product model index.\n+ *\n+ * {@inheritdoc}\n+ */\n+ public function remove($objectId, array $options = [])\n+ {\n+ $this->productAndProductModelClient->delete($this->indexType, $objectId);\n+ }\n+\n+ /**\n+ * Removes the products from both the product index and the product and product model index.\n+ *\n+ * {@inheritdoc}\n+ */\n+ public function removeAll(array $objects, array $options = [])\n+ {\n+ $this->productAndProductModelClient->bulkDelete($this->indexType, $objects);\n+ }\n+\n+ /**\n+ * {@inheritdoc}\n+ */\n+ protected function validateObjectNormalization(array $normalization)","path":"src/Pim/Bundle/CatalogBundle/Elasticsearch/Indexer/ProductModelIndexer.php","position":115,"original_position":115,"commit_id":"b1c17e95635a0aaef295d813210c634906ec3bf7","original_commit_id":"b1c17e95635a0aaef295d813210c634906ec3bf7","user":{"login":"aRn0D","id":3585922,"avatar_url":"https://avatars2.githubusercontent.com/u/3585922?v=4","gravatar_id":"","url":"https://api.github.com/users/aRn0D","html_url":"https://github.com/aRn0D","followers_url":"https://api.github.com/users/aRn0D/followers","following_url":"https://api.github.com/users/aRn0D/following{/other_user}","gists_url":"https://api.github.com/users/aRn0D/gists{/gist_id}","starred_url":"https://api.github.com/users/aRn0D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aRn0D/subscriptions","organizations_url":"https://api.github.com/users/aRn0D/orgs","repos_url":"https://api.github.com/users/aRn0D/repos","events_url":"https://api.github.com/users/aRn0D/events{/privacy}","received_events_url":"https://api.github.com/users/aRn0D/received_events","type":"User","site_admin":false},"body":"same question than the previous indexer?!","created_at":"2017-08-02T15:56:44Z","updated_at":"2017-08-02T16:03:55Z","html_url":"https://github.com/akeneo/pim-community-dev/pull/6475#discussion_r130918525","pull_request_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/6475","_links":{"self":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments/130918525"},"html":{"href":"https://github.com/akeneo/pim-community-dev/pull/6475#discussion_r130918525"},"pull_request":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/6475"}}},"pull_request":{"url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/6475","id":132557440,"html_url":"https://github.com/akeneo/pim-community-dev/pull/6475","diff_url":"https://github.com/akeneo/pim-community-dev/pull/6475.diff","patch_url":"https://github.com/akeneo/pim-community-dev/pull/6475.patch","issue_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/6475","number":6475,"state":"open","locked":false,"title":"[WIP] Index product models","user":{"login":"jjanvier","id":3691804,"avatar_url":"https://avatars3.githubusercontent.com/u/3691804?v=4","gravatar_id":"","url":"https://api.github.com/users/jjanvier","html_url":"https://github.com/jjanvier","followers_url":"https://api.github.com/users/jjanvier/followers","following_url":"https://api.github.com/users/jjanvier/following{/other_user}","gists_url":"https://api.github.com/users/jjanvier/gists{/gist_id}","starred_url":"https://api.github.com/users/jjanvier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjanvier/subscriptions","organizations_url":"https://api.github.com/users/jjanvier/orgs","repos_url":"https://api.github.com/users/jjanvier/repos","events_url":"https://api.github.com/users/jjanvier/events{/privacy}","received_events_url":"https://api.github.com/users/jjanvier/received_events","type":"User","site_admin":false},"body":"**Description (for Contributor and Core Developer)**\r\n\r\nThis PR introduces the strategy around indexing products and product models in ES.\r\n\r\nTo do so we have:\r\n- 1 ES index containing only products information (just like we have on master)\r\n- 1 ES index containing simple products, product variants and product models\r\n\r\nTo manipulate those index we introduced:\r\n- 1 ES client that manages the index of products only\r\n- 1 ES client that manages the index of products and product models\r\n\r\nTo index those entities we created multiple services:\r\n- One service that is responsible for indexing products <- the products will be indexed in both indexes.\r\n- One service that is responsible for indexing product model informations <- the product models will be indexed in the products and product models index.\r\n- One service that is responsible for indexing a product model descendance <- is composed of the two services above and recursively make sure the whole subtree of a model gets updated.\r\n\r\nWe also defined some new subscribers that triggers the indexing of products and of products models which uses the 3 above services.\r\n\r\n**And also**\r\n\r\nMoves the ProductIndexer from `Pim\\Bundle\\CatalogBundle\\Elasticsearch` to `Pim\\Bundle\\CatalogBundle\\Elasticsearch\\Indexer`.\r\n\r\n**Definition Of Done (for Core Developer only)**\r\n\r\n| Q | A\r\n| --------------------------------- | ---\r\n| Added Specs | Todo\r\n| Added Behats | Todo\r\n| Added integration tests | Todo\r\n| Changelog updated | Todo\r\n| Review and 2 GTM | Todo\r\n| Micro Demo to the PO (Story only) | Todo\r\n| Migration script | -\r\n| Tech Doc | -\r\n\r\n`Todo`: Pending / Work in progress\r\n`OK`: Done / Validated\r\n`-`: Not needed\r\n","created_at":"2017-07-26T16:20:45Z","updated_at":"2017-08-02T16:03:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c63c2753fd5358997ac6d0284a3c7b12256ba304","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/6475/commits","review_comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/6475/comments","review_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/6475/comments","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/b1c17e95635a0aaef295d813210c634906ec3bf7","head":{"label":"akeneo:PIM-6353-index-models","ref":"PIM-6353-index-models","sha":"b1c17e95635a0aaef295d813210c634906ec3bf7","user":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars0.githubusercontent.com/u/2510186?v=4","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"repo":{"id":5367323,"name":"pim-community-dev","full_name":"akeneo/pim-community-dev","owner":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars0.githubusercontent.com/u/2510186?v=4","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akeneo/pim-community-dev","description":"[Community Development Repository] The open source Product Information Management (PIM)","fork":false,"url":"https://api.github.com/repos/akeneo/pim-community-dev","forks_url":"https://api.github.com/repos/akeneo/pim-community-dev/forks","keys_url":"https://api.github.com/repos/akeneo/pim-community-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akeneo/pim-community-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akeneo/pim-community-dev/teams","hooks_url":"https://api.github.com/repos/akeneo/pim-community-dev/hooks","issue_events_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/events{/number}","events_url":"https://api.github.com/repos/akeneo/pim-community-dev/events","assignees_url":"https://api.github.com/repos/akeneo/pim-community-dev/assignees{/user}","branches_url":"https://api.github.com/repos/akeneo/pim-community-dev/branches{/branch}","tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/tags","blobs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/akeneo/pim-community-dev/languages","stargazers_url":"https://api.github.com/repos/akeneo/pim-community-dev/stargazers","contributors_url":"https://api.github.com/repos/akeneo/pim-community-dev/contributors","subscribers_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscribers","subscription_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscription","commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/akeneo/pim-community-dev/contents/{+path}","compare_url":"https://api.github.com/repos/akeneo/pim-community-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akeneo/pim-community-dev/merges","archive_url":"https://api.github.com/repos/akeneo/pim-community-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akeneo/pim-community-dev/downloads","issues_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues{/number}","pulls_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/akeneo/pim-community-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/akeneo/pim-community-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akeneo/pim-community-dev/labels{/name}","releases_url":"https://api.github.com/repos/akeneo/pim-community-dev/releases{/id}","deployments_url":"https://api.github.com/repos/akeneo/pim-community-dev/deployments","created_at":"2012-08-10T09:27:26Z","updated_at":"2017-07-31T18:06:03Z","pushed_at":"2017-08-02T15:56:09Z","git_url":"git://github.com/akeneo/pim-community-dev.git","ssh_url":"[email protected]:akeneo/pim-community-dev.git","clone_url":"https://github.com/akeneo/pim-community-dev.git","svn_url":"https://github.com/akeneo/pim-community-dev","homepage":"http://www.akeneo.com","size":115475,"stargazers_count":427,"watchers_count":427,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":250,"mirror_url":null,"open_issues_count":146,"forks":250,"open_issues":146,"watchers":427,"default_branch":"master"}},"base":{"label":"akeneo:catalog-modeling","ref":"catalog-modeling","sha":"f230e3265eb79bc88922392de0c36e7c31c8f30f","user":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars0.githubusercontent.com/u/2510186?v=4","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"repo":{"id":5367323,"name":"pim-community-dev","full_name":"akeneo/pim-community-dev","owner":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars0.githubusercontent.com/u/2510186?v=4","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akeneo/pim-community-dev","description":"[Community Development Repository] The open source Product Information Management (PIM)","fork":false,"url":"https://api.github.com/repos/akeneo/pim-community-dev","forks_url":"https://api.github.com/repos/akeneo/pim-community-dev/forks","keys_url":"https://api.github.com/repos/akeneo/pim-community-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akeneo/pim-community-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akeneo/pim-community-dev/teams","hooks_url":"https://api.github.com/repos/akeneo/pim-community-dev/hooks","issue_events_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/events{/number}","events_url":"https://api.github.com/repos/akeneo/pim-community-dev/events","assignees_url":"https://api.github.com/repos/akeneo/pim-community-dev/assignees{/user}","branches_url":"https://api.github.com/repos/akeneo/pim-community-dev/branches{/branch}","tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/tags","blobs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/akeneo/pim-community-dev/languages","stargazers_url":"https://api.github.com/repos/akeneo/pim-community-dev/stargazers","contributors_url":"https://api.github.com/repos/akeneo/pim-community-dev/contributors","subscribers_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscribers","subscription_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscription","commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/akeneo/pim-community-dev/contents/{+path}","compare_url":"https://api.github.com/repos/akeneo/pim-community-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akeneo/pim-community-dev/merges","archive_url":"https://api.github.com/repos/akeneo/pim-community-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akeneo/pim-community-dev/downloads","issues_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues{/number}","pulls_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/akeneo/pim-community-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/akeneo/pim-community-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akeneo/pim-community-dev/labels{/name}","releases_url":"https://api.github.com/repos/akeneo/pim-community-dev/releases{/id}","deployments_url":"https://api.github.com/repos/akeneo/pim-community-dev/deployments","created_at":"2012-08-10T09:27:26Z","updated_at":"2017-07-31T18:06:03Z","pushed_at":"2017-08-02T15:56:09Z","git_url":"git://github.com/akeneo/pim-community-dev.git","ssh_url":"[email protected]:akeneo/pim-community-dev.git","clone_url":"https://github.com/akeneo/pim-community-dev.git","svn_url":"https://github.com/akeneo/pim-community-dev","homepage":"http://www.akeneo.com","size":115475,"stargazers_count":427,"watchers_count":427,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":250,"mirror_url":null,"open_issues_count":146,"forks":250,"open_issues":146,"watchers":427,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/6475"},"html":{"href":"https://github.com/akeneo/pim-community-dev/pull/6475"},"issue":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/issues/6475"},"comments":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/issues/6475/comments"},"review_comments":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/6475/comments"},"review_comment":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/6475/commits"},"statuses":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/b1c17e95635a0aaef295d813210c634906ec3bf7"}}}} | {
"id": 5367323,
"name": "akeneo/pim-community-dev",
"url": "https://api.github.com/repos/akeneo/pim-community-dev"
} | {
"id": 3585922,
"login": "aRn0D",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3585922?",
"url": "https://api.github.com/users/aRn0D"
} | {
"id": 2510186,
"login": "akeneo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2510186?",
"url": "https://api.github.com/orgs/akeneo"
} | 2017-08-02T15:56:44 | 6380139468 | {"actor":{"display_login":"aRn0D"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/pulls/comments/113484626","pull_request_review_id":34877428,"id":113484626,"diff_hunk":"@@ -23,6 +22,8 @@\n // });\n \n // user.save(function(err) {\n+\n+// user.save(function(err) { ","path":"test/article/model.js","position":27,"original_position":27,"commit_id":"cc6aea16ee401137fcc9e20073060de5378abaed","original_commit_id":"cc6aea16ee401137fcc9e20073060de5378abaed","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars3.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Trailing spaces not allowed no-trailing-spaces","created_at":"2017-04-26T15:29:24Z","updated_at":"2017-04-26T15:29:25Z","html_url":"https://github.com/andela/reactors-cards-for-humanity/pull/21#discussion_r113484626","pull_request_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/andela/reactors-cards-for-humanity/pulls/comments/113484626"},"html":{"href":"https://github.com/andela/reactors-cards-for-humanity/pull/21#discussion_r113484626"},"pull_request":{"href":"https://api.github.com/repos/andela/reactors-cards-for-humanity/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/pulls/21","id":117743524,"html_url":"https://github.com/andela/reactors-cards-for-humanity/pull/21","diff_url":"https://github.com/andela/reactors-cards-for-humanity/pull/21.diff","patch_url":"https://github.com/andela/reactors-cards-for-humanity/pull/21.patch","issue_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/issues/21","number":21,"state":"open","locked":false,"title":"Chore/143412447/integrate coveralls","user":{"login":"Ewanjiru","id":27014080,"avatar_url":"https://avatars3.githubusercontent.com/u/27014080?v=3","gravatar_id":"","url":"https://api.github.com/users/Ewanjiru","html_url":"https://github.com/Ewanjiru","followers_url":"https://api.github.com/users/Ewanjiru/followers","following_url":"https://api.github.com/users/Ewanjiru/following{/other_user}","gists_url":"https://api.github.com/users/Ewanjiru/gists{/gist_id}","starred_url":"https://api.github.com/users/Ewanjiru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ewanjiru/subscriptions","organizations_url":"https://api.github.com/users/Ewanjiru/orgs","repos_url":"https://api.github.com/users/Ewanjiru/repos","events_url":"https://api.github.com/users/Ewanjiru/events{/privacy}","received_events_url":"https://api.github.com/users/Ewanjiru/received_events","type":"User","site_admin":false},"body":" #### What does this PR do?\r\nIt involves integration of coverall and will update the package.json scripts adding coveralls command, the travis.yml file by adding the npm run coveralls command and the readme file by adding the badge.\r\n #### Description of Task to be completed?\r\nIntegrating Coveralls to the project repo and adding a coveralls badge.\r\n #### How should this be manually tested?\r\nEdit any file then commit and make a push to repo.\r\nLogin into coveralls.io and locate your repo to see the coverage.\r\n #### What are the relevant pivotal tracker stories?\r\nhttps://www.pivotaltracker.com/story/show/143412447","created_at":"2017-04-26T15:29:16Z","updated_at":"2017-04-26T15:29:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cecd9f35f10ab3e9cd7ad70ba8741452e028ff6d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/pulls/21/commits","review_comments_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/pulls/21/comments","review_comment_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/issues/21/comments","statuses_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/statuses/cc6aea16ee401137fcc9e20073060de5378abaed","head":{"label":"andela:chore/143412447/integrate-coveralls","ref":"chore/143412447/integrate-coveralls","sha":"cc6aea16ee401137fcc9e20073060de5378abaed","user":{"login":"andela","id":4100206,"avatar_url":"https://avatars1.githubusercontent.com/u/4100206?v=3","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":87555575,"name":"reactors-cards-for-humanity","full_name":"andela/reactors-cards-for-humanity","owner":{"login":"andela","id":4100206,"avatar_url":"https://avatars1.githubusercontent.com/u/4100206?v=3","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/reactors-cards-for-humanity","description":null,"fork":false,"url":"https://api.github.com/repos/andela/reactors-cards-for-humanity","forks_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/forks","keys_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/teams","hooks_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/hooks","issue_events_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/issues/events{/number}","events_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/events","assignees_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/assignees{/user}","branches_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/branches{/branch}","tags_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/tags","blobs_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/languages","stargazers_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/stargazers","contributors_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/contributors","subscribers_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/subscribers","subscription_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/subscription","commits_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/contents/{+path}","compare_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/merges","archive_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/downloads","issues_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/issues{/number}","pulls_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/labels{/name}","releases_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/releases{/id}","deployments_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/deployments","created_at":"2017-04-07T14:35:59Z","updated_at":"2017-04-10T13:51:57Z","pushed_at":"2017-04-26T15:29:17Z","git_url":"git://github.com/andela/reactors-cards-for-humanity.git","ssh_url":"[email protected]:andela/reactors-cards-for-humanity.git","clone_url":"https://github.com/andela/reactors-cards-for-humanity.git","svn_url":"https://github.com/andela/reactors-cards-for-humanity","homepage":null,"size":11063,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"develop"}},"base":{"label":"andela:develop","ref":"develop","sha":"2f10a33d12c7548df5cd5458f0070f87119fa75e","user":{"login":"andela","id":4100206,"avatar_url":"https://avatars1.githubusercontent.com/u/4100206?v=3","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":87555575,"name":"reactors-cards-for-humanity","full_name":"andela/reactors-cards-for-humanity","owner":{"login":"andela","id":4100206,"avatar_url":"https://avatars1.githubusercontent.com/u/4100206?v=3","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/reactors-cards-for-humanity","description":null,"fork":false,"url":"https://api.github.com/repos/andela/reactors-cards-for-humanity","forks_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/forks","keys_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/teams","hooks_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/hooks","issue_events_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/issues/events{/number}","events_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/events","assignees_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/assignees{/user}","branches_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/branches{/branch}","tags_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/tags","blobs_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/languages","stargazers_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/stargazers","contributors_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/contributors","subscribers_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/subscribers","subscription_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/subscription","commits_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/contents/{+path}","compare_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/merges","archive_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/downloads","issues_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/issues{/number}","pulls_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/labels{/name}","releases_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/releases{/id}","deployments_url":"https://api.github.com/repos/andela/reactors-cards-for-humanity/deployments","created_at":"2017-04-07T14:35:59Z","updated_at":"2017-04-10T13:51:57Z","pushed_at":"2017-04-26T15:29:17Z","git_url":"git://github.com/andela/reactors-cards-for-humanity.git","ssh_url":"[email protected]:andela/reactors-cards-for-humanity.git","clone_url":"https://github.com/andela/reactors-cards-for-humanity.git","svn_url":"https://github.com/andela/reactors-cards-for-humanity","homepage":null,"size":11063,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/reactors-cards-for-humanity/pulls/21"},"html":{"href":"https://github.com/andela/reactors-cards-for-humanity/pull/21"},"issue":{"href":"https://api.github.com/repos/andela/reactors-cards-for-humanity/issues/21"},"comments":{"href":"https://api.github.com/repos/andela/reactors-cards-for-humanity/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/reactors-cards-for-humanity/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/reactors-cards-for-humanity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/reactors-cards-for-humanity/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/andela/reactors-cards-for-humanity/statuses/cc6aea16ee401137fcc9e20073060de5378abaed"}}}} | {
"id": 87555575,
"name": "andela/reactors-cards-for-humanity",
"url": "https://api.github.com/repos/andela/reactors-cards-for-humanity"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
} | 2017-04-26T15:29:24 | 5761516627 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/andela/isildur-cfh/pulls/comments/136035885","pull_request_review_id":59518112,"id":136035885,"diff_hunk":"@@ -0,0 +1,119 @@\n+import gulp from 'gulp';\n+import gulpLoadPlugins from 'gulp-load-plugins';\n+\n+const plugins = gulpLoadPlugins();\n+\n+gulp.task('lint', () => gulp.src(\n+ [\n+ 'gulpfile.babel.js', \n+ './config/**/*.js', ","path":"gulpfile.babel.js","position":9,"original_position":9,"commit_id":"77e60b267b73c3dac2661b6dd9068924a288c843","original_commit_id":"77e60b267b73c3dac2661b6dd9068924a288c843","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Trailing spaces not allowed no-trailing-spaces","created_at":"2017-08-30T10:56:22Z","updated_at":"2017-08-30T10:56:22Z","html_url":"https://github.com/andela/isildur-cfh/pull/9#discussion_r136035885","pull_request_url":"https://api.github.com/repos/andela/isildur-cfh/pulls/9","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/andela/isildur-cfh/pulls/comments/136035885"},"html":{"href":"https://github.com/andela/isildur-cfh/pull/9#discussion_r136035885"},"pull_request":{"href":"https://api.github.com/repos/andela/isildur-cfh/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/andela/isildur-cfh/pulls/9","id":138238121,"html_url":"https://github.com/andela/isildur-cfh/pull/9","diff_url":"https://github.com/andela/isildur-cfh/pull/9.diff","patch_url":"https://github.com/andela/isildur-cfh/pull/9.patch","issue_url":"https://api.github.com/repos/andela/isildur-cfh/issues/9","number":9,"state":"open","locked":false,"title":"chore(gulp) : convert grunt to gulp","user":{"login":"fob413","id":17882359,"avatar_url":"https://avatars2.githubusercontent.com/u/17882359?v=4","gravatar_id":"","url":"https://api.github.com/users/fob413","html_url":"https://github.com/fob413","followers_url":"https://api.github.com/users/fob413/followers","following_url":"https://api.github.com/users/fob413/following{/other_user}","gists_url":"https://api.github.com/users/fob413/gists{/gist_id}","starred_url":"https://api.github.com/users/fob413/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fob413/subscriptions","organizations_url":"https://api.github.com/users/fob413/orgs","repos_url":"https://api.github.com/users/fob413/repos","events_url":"https://api.github.com/users/fob413/events{/privacy}","received_events_url":"https://api.github.com/users/fob413/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n\r\nAdds gulpfile as a preferable task runner to grunt\r\n\r\n#### Description of Task to be completed?\r\n\r\nRun all scripts from gulpfile and integrate coveralls\r\n\r\n#### How should this be manually tested?\r\n\r\nRun **gulp** from command line\r\n\r\n#### Any background context you want to provide?\r\n\r\nThe app currently uses grunt as its task runner\r\n\r\n#### What are the relevant pivotal tracker stories?\r\n\r\nhttps://www.pivotaltracker.com/story/show/150398703","created_at":"2017-08-29T17:18:17Z","updated_at":"2017-08-30T10:56:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74bab72a9a6309cafbaa064d2009f90016bcb483","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela/isildur-cfh/pulls/9/commits","review_comments_url":"https://api.github.com/repos/andela/isildur-cfh/pulls/9/comments","review_comment_url":"https://api.github.com/repos/andela/isildur-cfh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/isildur-cfh/issues/9/comments","statuses_url":"https://api.github.com/repos/andela/isildur-cfh/statuses/77e60b267b73c3dac2661b6dd9068924a288c843","head":{"label":"andela:chore/150398703/convert-grunt-to-gulp","ref":"chore/150398703/convert-grunt-to-gulp","sha":"77e60b267b73c3dac2661b6dd9068924a288c843","user":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":100930956,"name":"isildur-cfh","full_name":"andela/isildur-cfh","owner":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/isildur-cfh","description":null,"fork":false,"url":"https://api.github.com/repos/andela/isildur-cfh","forks_url":"https://api.github.com/repos/andela/isildur-cfh/forks","keys_url":"https://api.github.com/repos/andela/isildur-cfh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/isildur-cfh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/isildur-cfh/teams","hooks_url":"https://api.github.com/repos/andela/isildur-cfh/hooks","issue_events_url":"https://api.github.com/repos/andela/isildur-cfh/issues/events{/number}","events_url":"https://api.github.com/repos/andela/isildur-cfh/events","assignees_url":"https://api.github.com/repos/andela/isildur-cfh/assignees{/user}","branches_url":"https://api.github.com/repos/andela/isildur-cfh/branches{/branch}","tags_url":"https://api.github.com/repos/andela/isildur-cfh/tags","blobs_url":"https://api.github.com/repos/andela/isildur-cfh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/isildur-cfh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/isildur-cfh/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/isildur-cfh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/isildur-cfh/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/isildur-cfh/languages","stargazers_url":"https://api.github.com/repos/andela/isildur-cfh/stargazers","contributors_url":"https://api.github.com/repos/andela/isildur-cfh/contributors","subscribers_url":"https://api.github.com/repos/andela/isildur-cfh/subscribers","subscription_url":"https://api.github.com/repos/andela/isildur-cfh/subscription","commits_url":"https://api.github.com/repos/andela/isildur-cfh/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/isildur-cfh/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/isildur-cfh/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/isildur-cfh/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/isildur-cfh/contents/{+path}","compare_url":"https://api.github.com/repos/andela/isildur-cfh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/isildur-cfh/merges","archive_url":"https://api.github.com/repos/andela/isildur-cfh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/isildur-cfh/downloads","issues_url":"https://api.github.com/repos/andela/isildur-cfh/issues{/number}","pulls_url":"https://api.github.com/repos/andela/isildur-cfh/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/isildur-cfh/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/isildur-cfh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/isildur-cfh/labels{/name}","releases_url":"https://api.github.com/repos/andela/isildur-cfh/releases{/id}","deployments_url":"https://api.github.com/repos/andela/isildur-cfh/deployments","created_at":"2017-08-21T08:33:57Z","updated_at":"2017-08-21T10:17:13Z","pushed_at":"2017-08-30T10:56:14Z","git_url":"git://github.com/andela/isildur-cfh.git","ssh_url":"[email protected]:andela/isildur-cfh.git","clone_url":"https://github.com/andela/isildur-cfh.git","svn_url":"https://github.com/andela/isildur-cfh","homepage":null,"size":9695,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"staging"}},"base":{"label":"andela:staging","ref":"staging","sha":"da186e63db5c4a971bf5786d005327d99e94f127","user":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":100930956,"name":"isildur-cfh","full_name":"andela/isildur-cfh","owner":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/isildur-cfh","description":null,"fork":false,"url":"https://api.github.com/repos/andela/isildur-cfh","forks_url":"https://api.github.com/repos/andela/isildur-cfh/forks","keys_url":"https://api.github.com/repos/andela/isildur-cfh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/isildur-cfh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/isildur-cfh/teams","hooks_url":"https://api.github.com/repos/andela/isildur-cfh/hooks","issue_events_url":"https://api.github.com/repos/andela/isildur-cfh/issues/events{/number}","events_url":"https://api.github.com/repos/andela/isildur-cfh/events","assignees_url":"https://api.github.com/repos/andela/isildur-cfh/assignees{/user}","branches_url":"https://api.github.com/repos/andela/isildur-cfh/branches{/branch}","tags_url":"https://api.github.com/repos/andela/isildur-cfh/tags","blobs_url":"https://api.github.com/repos/andela/isildur-cfh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/isildur-cfh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/isildur-cfh/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/isildur-cfh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/isildur-cfh/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/isildur-cfh/languages","stargazers_url":"https://api.github.com/repos/andela/isildur-cfh/stargazers","contributors_url":"https://api.github.com/repos/andela/isildur-cfh/contributors","subscribers_url":"https://api.github.com/repos/andela/isildur-cfh/subscribers","subscription_url":"https://api.github.com/repos/andela/isildur-cfh/subscription","commits_url":"https://api.github.com/repos/andela/isildur-cfh/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/isildur-cfh/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/isildur-cfh/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/isildur-cfh/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/isildur-cfh/contents/{+path}","compare_url":"https://api.github.com/repos/andela/isildur-cfh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/isildur-cfh/merges","archive_url":"https://api.github.com/repos/andela/isildur-cfh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/isildur-cfh/downloads","issues_url":"https://api.github.com/repos/andela/isildur-cfh/issues{/number}","pulls_url":"https://api.github.com/repos/andela/isildur-cfh/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/isildur-cfh/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/isildur-cfh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/isildur-cfh/labels{/name}","releases_url":"https://api.github.com/repos/andela/isildur-cfh/releases{/id}","deployments_url":"https://api.github.com/repos/andela/isildur-cfh/deployments","created_at":"2017-08-21T08:33:57Z","updated_at":"2017-08-21T10:17:13Z","pushed_at":"2017-08-30T10:56:14Z","git_url":"git://github.com/andela/isildur-cfh.git","ssh_url":"[email protected]:andela/isildur-cfh.git","clone_url":"https://github.com/andela/isildur-cfh.git","svn_url":"https://github.com/andela/isildur-cfh","homepage":null,"size":9695,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/isildur-cfh/pulls/9"},"html":{"href":"https://github.com/andela/isildur-cfh/pull/9"},"issue":{"href":"https://api.github.com/repos/andela/isildur-cfh/issues/9"},"comments":{"href":"https://api.github.com/repos/andela/isildur-cfh/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/isildur-cfh/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/isildur-cfh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/isildur-cfh/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/andela/isildur-cfh/statuses/77e60b267b73c3dac2661b6dd9068924a288c843"}},"author_association":"COLLABORATOR"}} | {
"id": 100930956,
"name": "andela/isildur-cfh",
"url": "https://api.github.com/repos/andela/isildur-cfh"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
} | 2017-08-30T10:56:22 | 6529282136 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/andela/project-arakari/pulls/comments/98930960","pull_request_review_id":19588775,"id":98930960,"diff_hunk":"@@ -424,13 +366,13 @@ body{\n }\n \n .navbar .nav>li>a.brand {\n- padding-left:20px;\n- margin-left:0\n+ padding-left: 20px;\n+ margin-left: 0;\n }\n \n .content {\n- margin-top:50px;\n- width:70%\n+ margin-top: 50px;","path":"public/css/common.scss","position":255,"original_position":255,"commit_id":"ed80fbdc52f0fa728f27e1ac5508eaed96abd432","original_commit_id":"ed80fbdc52f0fa728f27e1ac5508eaed96abd432","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Line should be indented 2 spaces, but was indented 4 spaces","created_at":"2017-02-01T16:18:55Z","updated_at":"2017-02-01T16:18:55Z","html_url":"https://github.com/andela/project-arakari/pull/52#discussion_r98930960","pull_request_url":"https://api.github.com/repos/andela/project-arakari/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/andela/project-arakari/pulls/comments/98930960"},"html":{"href":"https://github.com/andela/project-arakari/pull/52#discussion_r98930960"},"pull_request":{"href":"https://api.github.com/repos/andela/project-arakari/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/andela/project-arakari/pulls/52","id":104121246,"html_url":"https://github.com/andela/project-arakari/pull/52","diff_url":"https://github.com/andela/project-arakari/pull/52.diff","patch_url":"https://github.com/andela/project-arakari/pull/52.patch","issue_url":"https://api.github.com/repos/andela/project-arakari/issues/52","number":52,"state":"open","locked":false,"title":"#135842541 Game UI Revamp","user":{"login":"andela-jmacharia","id":16131515,"avatar_url":"https://avatars.githubusercontent.com/u/16131515?v=3","gravatar_id":"","url":"https://api.github.com/users/andela-jmacharia","html_url":"https://github.com/andela-jmacharia","followers_url":"https://api.github.com/users/andela-jmacharia/followers","following_url":"https://api.github.com/users/andela-jmacharia/following{/other_user}","gists_url":"https://api.github.com/users/andela-jmacharia/gists{/gist_id}","starred_url":"https://api.github.com/users/andela-jmacharia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela-jmacharia/subscriptions","organizations_url":"https://api.github.com/users/andela-jmacharia/orgs","repos_url":"https://api.github.com/users/andela-jmacharia/repos","events_url":"https://api.github.com/users/andela-jmacharia/events{/privacy}","received_events_url":"https://api.github.com/users/andela-jmacharia/received_events","type":"User","site_admin":false},"body":" #### What does this PR do?\r\n Changes the gaming user interface\r\n\r\n #### Description of Task to be completed?\r\n A user, after opting to start a new game, should see a redesigned interface of the game\r\n\r\n #### How should this be manually tested?\r\n Log in or play the game as guest\r\n\r\n #### What are the relevant pivotal tracker stories?\r\n #135842541\r\n\r\n #### Screenshots\r\n\r\n\r\n_**Share game link page**_\r\n\r\n<img width=\"1280\" alt=\"share-link-page\" src=\"https://cloud.githubusercontent.com/assets/16131515/22512133/09a78392-e8a9-11e6-9121-327d4c6a427e.png\">\r\n\r\n\r\n_**Waiting for players to join page**_\r\n\r\n<img width=\"1280\" alt=\"waiting-for-players-to-join-game\" src=\"https://cloud.githubusercontent.com/assets/16131515/22512159/1ac2f94a-e8a9-11e6-9770-05c23b2f9ce2.png\">\r\n\r\n\r\n_**Main game page**_\r\n\r\n<img width=\"1280\" alt=\"main-game-page\" src=\"https://cloud.githubusercontent.com/assets/16131515/22512164/21adcd5c-e8a9-11e6-9cd9-2e182843a5a5.png\">\r\n\r\n\r\n_**Czar page**_\r\n\r\n<img width=\"1280\" alt=\"czar-page\" src=\"https://cloud.githubusercontent.com/assets/16131515/22512183/2c051206-e8a9-11e6-891b-41155764b5a3.png\">\r\n\r\n\r\n_**Czar choosing page**_\r\n\r\n<img width=\"1280\" alt=\"czar-choosing\" src=\"https://cloud.githubusercontent.com/assets/16131515/22512213/406f8802-e8a9-11e6-8ec4-d820fa57b22a.png\">\r\n\r\n\r\n_**Game ends page**_\r\n\r\n<img width=\"1280\" alt=\"game-ends\" src=\"https://cloud.githubusercontent.com/assets/16131515/22512222/486b8128-e8a9-11e6-89c4-090c85a725dd.png\">\r\n","created_at":"2017-02-01T11:48:31Z","updated_at":"2017-02-01T16:18:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb2a35db8eec3c60b351503147a4254a9c6a900e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela/project-arakari/pulls/52/commits","review_comments_url":"https://api.github.com/repos/andela/project-arakari/pulls/52/comments","review_comment_url":"https://api.github.com/repos/andela/project-arakari/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/project-arakari/issues/52/comments","statuses_url":"https://api.github.com/repos/andela/project-arakari/statuses/ed80fbdc52f0fa728f27e1ac5508eaed96abd432","head":{"label":"andela:feature/135842541/game-UI-revamp","ref":"feature/135842541/game-UI-revamp","sha":"ed80fbdc52f0fa728f27e1ac5508eaed96abd432","user":{"login":"andela","id":4100206,"avatar_url":"https://avatars.githubusercontent.com/u/4100206?v=3","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":75959756,"name":"project-arakari","full_name":"andela/project-arakari","owner":{"login":"andela","id":4100206,"avatar_url":"https://avatars.githubusercontent.com/u/4100206?v=3","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/project-arakari","description":null,"fork":false,"url":"https://api.github.com/repos/andela/project-arakari","forks_url":"https://api.github.com/repos/andela/project-arakari/forks","keys_url":"https://api.github.com/repos/andela/project-arakari/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/project-arakari/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/project-arakari/teams","hooks_url":"https://api.github.com/repos/andela/project-arakari/hooks","issue_events_url":"https://api.github.com/repos/andela/project-arakari/issues/events{/number}","events_url":"https://api.github.com/repos/andela/project-arakari/events","assignees_url":"https://api.github.com/repos/andela/project-arakari/assignees{/user}","branches_url":"https://api.github.com/repos/andela/project-arakari/branches{/branch}","tags_url":"https://api.github.com/repos/andela/project-arakari/tags","blobs_url":"https://api.github.com/repos/andela/project-arakari/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/project-arakari/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/project-arakari/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/project-arakari/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/project-arakari/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/project-arakari/languages","stargazers_url":"https://api.github.com/repos/andela/project-arakari/stargazers","contributors_url":"https://api.github.com/repos/andela/project-arakari/contributors","subscribers_url":"https://api.github.com/repos/andela/project-arakari/subscribers","subscription_url":"https://api.github.com/repos/andela/project-arakari/subscription","commits_url":"https://api.github.com/repos/andela/project-arakari/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/project-arakari/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/project-arakari/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/project-arakari/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/project-arakari/contents/{+path}","compare_url":"https://api.github.com/repos/andela/project-arakari/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/project-arakari/merges","archive_url":"https://api.github.com/repos/andela/project-arakari/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/project-arakari/downloads","issues_url":"https://api.github.com/repos/andela/project-arakari/issues{/number}","pulls_url":"https://api.github.com/repos/andela/project-arakari/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/project-arakari/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/project-arakari/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/project-arakari/labels{/name}","releases_url":"https://api.github.com/repos/andela/project-arakari/releases{/id}","deployments_url":"https://api.github.com/repos/andela/project-arakari/deployments","created_at":"2016-12-08T17:26:33Z","updated_at":"2016-12-09T21:58:05Z","pushed_at":"2017-02-01T16:18:42Z","git_url":"git://github.com/andela/project-arakari.git","ssh_url":"[email protected]:andela/project-arakari.git","clone_url":"https://github.com/andela/project-arakari.git","svn_url":"https://github.com/andela/project-arakari","homepage":null,"size":11954,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"develop"}},"base":{"label":"andela:develop","ref":"develop","sha":"44d94cee162e8338df4a98f9eff5dd6ca1cb3f70","user":{"login":"andela","id":4100206,"avatar_url":"https://avatars.githubusercontent.com/u/4100206?v=3","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":75959756,"name":"project-arakari","full_name":"andela/project-arakari","owner":{"login":"andela","id":4100206,"avatar_url":"https://avatars.githubusercontent.com/u/4100206?v=3","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/project-arakari","description":null,"fork":false,"url":"https://api.github.com/repos/andela/project-arakari","forks_url":"https://api.github.com/repos/andela/project-arakari/forks","keys_url":"https://api.github.com/repos/andela/project-arakari/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/project-arakari/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/project-arakari/teams","hooks_url":"https://api.github.com/repos/andela/project-arakari/hooks","issue_events_url":"https://api.github.com/repos/andela/project-arakari/issues/events{/number}","events_url":"https://api.github.com/repos/andela/project-arakari/events","assignees_url":"https://api.github.com/repos/andela/project-arakari/assignees{/user}","branches_url":"https://api.github.com/repos/andela/project-arakari/branches{/branch}","tags_url":"https://api.github.com/repos/andela/project-arakari/tags","blobs_url":"https://api.github.com/repos/andela/project-arakari/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/project-arakari/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/project-arakari/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/project-arakari/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/project-arakari/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/project-arakari/languages","stargazers_url":"https://api.github.com/repos/andela/project-arakari/stargazers","contributors_url":"https://api.github.com/repos/andela/project-arakari/contributors","subscribers_url":"https://api.github.com/repos/andela/project-arakari/subscribers","subscription_url":"https://api.github.com/repos/andela/project-arakari/subscription","commits_url":"https://api.github.com/repos/andela/project-arakari/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/project-arakari/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/project-arakari/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/project-arakari/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/project-arakari/contents/{+path}","compare_url":"https://api.github.com/repos/andela/project-arakari/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/project-arakari/merges","archive_url":"https://api.github.com/repos/andela/project-arakari/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/project-arakari/downloads","issues_url":"https://api.github.com/repos/andela/project-arakari/issues{/number}","pulls_url":"https://api.github.com/repos/andela/project-arakari/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/project-arakari/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/project-arakari/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/project-arakari/labels{/name}","releases_url":"https://api.github.com/repos/andela/project-arakari/releases{/id}","deployments_url":"https://api.github.com/repos/andela/project-arakari/deployments","created_at":"2016-12-08T17:26:33Z","updated_at":"2016-12-09T21:58:05Z","pushed_at":"2017-02-01T16:18:42Z","git_url":"git://github.com/andela/project-arakari.git","ssh_url":"[email protected]:andela/project-arakari.git","clone_url":"https://github.com/andela/project-arakari.git","svn_url":"https://github.com/andela/project-arakari","homepage":null,"size":11954,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/project-arakari/pulls/52"},"html":{"href":"https://github.com/andela/project-arakari/pull/52"},"issue":{"href":"https://api.github.com/repos/andela/project-arakari/issues/52"},"comments":{"href":"https://api.github.com/repos/andela/project-arakari/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/project-arakari/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/project-arakari/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/project-arakari/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/andela/project-arakari/statuses/ed80fbdc52f0fa728f27e1ac5508eaed96abd432"}}}} | {
"id": 75959756,
"name": "andela/project-arakari",
"url": "https://api.github.com/repos/andela/project-arakari"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
} | 2017-02-01T16:18:55 | 5248689089 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/andela/gryffindor-cfh/pulls/comments/135235787","pull_request_review_id":58626831,"id":135235787,"diff_hunk":"@@ -0,0 +1,69 @@\n+// Karma configuration\n+// Generated on Fri Aug 25 2017 08:03:51 GMT+0100 (WAT)\n+\n+module.exports = function(config) {\n+ config.set({\n+\n+ // base path that will be used to resolve all patterns (eg. files, exclude)\n+ basePath: '',\n+\n+\n+ // frameworks to use\n+ // available frameworks: https://npmjs.org/browse/keyword/karma-adapter\n+ frameworks: ['jasmine'],\n+\n+\n+ // list of files / patterns to load in the browser\n+ files: [\n+ 'test/test.js'\n+ ],\n+\n+\n+ // list of files to exclude\n+ exclude: [\n+ ],\n+\n+\n+ // preprocess matching files before serving them to the browser\n+ // available preprocessors: https://npmjs.org/browse/keyword/karma-preprocessor\n+ preprocessors: {\n+ },\n+\n+\n+ // test results reporter to use\n+ // possible values: 'dots', 'progress'\n+ // available reporters: https://npmjs.org/browse/keyword/karma-reporter\n+ reporters: ['progress'],\n+\n+\n+ // web server port\n+ port: 9876,\n+\n+\n+ // enable / disable colors in the output (reporters and logs)\n+ colors: true,\n+\n+\n+ // level of logging\n+ // possible values: config.LOG_DISABLE || config.LOG_ERROR || config.LOG_WARN || config.LOG_INFO || config.LOG_DEBUG","path":"karma.conf.js","position":48,"original_position":48,"commit_id":"e762e0c7c928cba34d97ddff6a3c388782f42a48","original_commit_id":"e762e0c7c928cba34d97ddff6a3c388782f42a48","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Line 48 exceeds the maximum line length of 100 max-len","created_at":"2017-08-25T11:13:01Z","updated_at":"2017-08-25T11:13:01Z","html_url":"https://github.com/andela/gryffindor-cfh/pull/14#discussion_r135235787","pull_request_url":"https://api.github.com/repos/andela/gryffindor-cfh/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/andela/gryffindor-cfh/pulls/comments/135235787"},"html":{"href":"https://github.com/andela/gryffindor-cfh/pull/14#discussion_r135235787"},"pull_request":{"href":"https://api.github.com/repos/andela/gryffindor-cfh/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/andela/gryffindor-cfh/pulls/14","id":137651218,"html_url":"https://github.com/andela/gryffindor-cfh/pull/14","diff_url":"https://github.com/andela/gryffindor-cfh/pull/14.diff","patch_url":"https://github.com/andela/gryffindor-cfh/pull/14.patch","issue_url":"https://api.github.com/repos/andela/gryffindor-cfh/issues/14","number":14,"state":"open","locked":false,"title":"Chore/150438321/unit testing frontend","user":{"login":"Charpell","id":21138774,"avatar_url":"https://avatars3.githubusercontent.com/u/21138774?v=4","gravatar_id":"","url":"https://api.github.com/users/Charpell","html_url":"https://github.com/Charpell","followers_url":"https://api.github.com/users/Charpell/followers","following_url":"https://api.github.com/users/Charpell/following{/other_user}","gists_url":"https://api.github.com/users/Charpell/gists{/gist_id}","starred_url":"https://api.github.com/users/Charpell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Charpell/subscriptions","organizations_url":"https://api.github.com/users/Charpell/orgs","repos_url":"https://api.github.com/users/Charpell/repos","events_url":"https://api.github.com/users/Charpell/events{/privacy}","received_events_url":"https://api.github.com/users/Charpell/received_events","type":"User","site_admin":false},"body":"### What does this PR do\r\nThis ensures the front end has all functionality work the way it was intended. It uses Jasmine and Karma framework to setup front end testing environment.\r\n\r\n### Description of Task to be completed?\r\n\r\nInstall Karma and Jasmine framework.\r\n\r\n### What are the relevant pivotal tracker stories?\r\n\r\n#150438321\r\n\r\nScreenshots\r\n<img width=\"738\" alt=\"screen shot 2017-08-25 at 12 11 01 pm\" src=\"https://user-images.githubusercontent.com/21138774/29711791-933cef08-898e-11e7-8680-b607aa26b955.png\">\r\n\r\n<img width=\"1047\" alt=\"screen shot 2017-08-25 at 12 11 14 pm\" src=\"https://user-images.githubusercontent.com/21138774/29711825-b1051d76-898e-11e7-8e4b-6605475f8f84.png\">\r\n\r\n","created_at":"2017-08-25T11:12:48Z","updated_at":"2017-08-25T11:13:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40449eaedfa6ef368aa4a052c231151d185356f4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela/gryffindor-cfh/pulls/14/commits","review_comments_url":"https://api.github.com/repos/andela/gryffindor-cfh/pulls/14/comments","review_comment_url":"https://api.github.com/repos/andela/gryffindor-cfh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/gryffindor-cfh/issues/14/comments","statuses_url":"https://api.github.com/repos/andela/gryffindor-cfh/statuses/e762e0c7c928cba34d97ddff6a3c388782f42a48","head":{"label":"andela:chore/150438321/unit-testing-frontend","ref":"chore/150438321/unit-testing-frontend","sha":"e762e0c7c928cba34d97ddff6a3c388782f42a48","user":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":100931136,"name":"gryffindor-cfh","full_name":"andela/gryffindor-cfh","owner":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/gryffindor-cfh","description":null,"fork":false,"url":"https://api.github.com/repos/andela/gryffindor-cfh","forks_url":"https://api.github.com/repos/andela/gryffindor-cfh/forks","keys_url":"https://api.github.com/repos/andela/gryffindor-cfh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/gryffindor-cfh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/gryffindor-cfh/teams","hooks_url":"https://api.github.com/repos/andela/gryffindor-cfh/hooks","issue_events_url":"https://api.github.com/repos/andela/gryffindor-cfh/issues/events{/number}","events_url":"https://api.github.com/repos/andela/gryffindor-cfh/events","assignees_url":"https://api.github.com/repos/andela/gryffindor-cfh/assignees{/user}","branches_url":"https://api.github.com/repos/andela/gryffindor-cfh/branches{/branch}","tags_url":"https://api.github.com/repos/andela/gryffindor-cfh/tags","blobs_url":"https://api.github.com/repos/andela/gryffindor-cfh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/gryffindor-cfh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/gryffindor-cfh/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/gryffindor-cfh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/gryffindor-cfh/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/gryffindor-cfh/languages","stargazers_url":"https://api.github.com/repos/andela/gryffindor-cfh/stargazers","contributors_url":"https://api.github.com/repos/andela/gryffindor-cfh/contributors","subscribers_url":"https://api.github.com/repos/andela/gryffindor-cfh/subscribers","subscription_url":"https://api.github.com/repos/andela/gryffindor-cfh/subscription","commits_url":"https://api.github.com/repos/andela/gryffindor-cfh/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/gryffindor-cfh/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/gryffindor-cfh/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/gryffindor-cfh/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/gryffindor-cfh/contents/{+path}","compare_url":"https://api.github.com/repos/andela/gryffindor-cfh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/gryffindor-cfh/merges","archive_url":"https://api.github.com/repos/andela/gryffindor-cfh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/gryffindor-cfh/downloads","issues_url":"https://api.github.com/repos/andela/gryffindor-cfh/issues{/number}","pulls_url":"https://api.github.com/repos/andela/gryffindor-cfh/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/gryffindor-cfh/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/gryffindor-cfh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/gryffindor-cfh/labels{/name}","releases_url":"https://api.github.com/repos/andela/gryffindor-cfh/releases{/id}","deployments_url":"https://api.github.com/repos/andela/gryffindor-cfh/deployments","created_at":"2017-08-21T08:36:02Z","updated_at":"2017-08-21T09:24:58Z","pushed_at":"2017-08-25T11:12:49Z","git_url":"git://github.com/andela/gryffindor-cfh.git","ssh_url":"[email protected]:andela/gryffindor-cfh.git","clone_url":"https://github.com/andela/gryffindor-cfh.git","svn_url":"https://github.com/andela/gryffindor-cfh","homepage":null,"size":10339,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"staging"}},"base":{"label":"andela:staging","ref":"staging","sha":"2aaa28bcb7c2c42960dc5282d87e3bfe7bb82984","user":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":100931136,"name":"gryffindor-cfh","full_name":"andela/gryffindor-cfh","owner":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/gryffindor-cfh","description":null,"fork":false,"url":"https://api.github.com/repos/andela/gryffindor-cfh","forks_url":"https://api.github.com/repos/andela/gryffindor-cfh/forks","keys_url":"https://api.github.com/repos/andela/gryffindor-cfh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/gryffindor-cfh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/gryffindor-cfh/teams","hooks_url":"https://api.github.com/repos/andela/gryffindor-cfh/hooks","issue_events_url":"https://api.github.com/repos/andela/gryffindor-cfh/issues/events{/number}","events_url":"https://api.github.com/repos/andela/gryffindor-cfh/events","assignees_url":"https://api.github.com/repos/andela/gryffindor-cfh/assignees{/user}","branches_url":"https://api.github.com/repos/andela/gryffindor-cfh/branches{/branch}","tags_url":"https://api.github.com/repos/andela/gryffindor-cfh/tags","blobs_url":"https://api.github.com/repos/andela/gryffindor-cfh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/gryffindor-cfh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/gryffindor-cfh/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/gryffindor-cfh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/gryffindor-cfh/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/gryffindor-cfh/languages","stargazers_url":"https://api.github.com/repos/andela/gryffindor-cfh/stargazers","contributors_url":"https://api.github.com/repos/andela/gryffindor-cfh/contributors","subscribers_url":"https://api.github.com/repos/andela/gryffindor-cfh/subscribers","subscription_url":"https://api.github.com/repos/andela/gryffindor-cfh/subscription","commits_url":"https://api.github.com/repos/andela/gryffindor-cfh/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/gryffindor-cfh/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/gryffindor-cfh/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/gryffindor-cfh/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/gryffindor-cfh/contents/{+path}","compare_url":"https://api.github.com/repos/andela/gryffindor-cfh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/gryffindor-cfh/merges","archive_url":"https://api.github.com/repos/andela/gryffindor-cfh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/gryffindor-cfh/downloads","issues_url":"https://api.github.com/repos/andela/gryffindor-cfh/issues{/number}","pulls_url":"https://api.github.com/repos/andela/gryffindor-cfh/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/gryffindor-cfh/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/gryffindor-cfh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/gryffindor-cfh/labels{/name}","releases_url":"https://api.github.com/repos/andela/gryffindor-cfh/releases{/id}","deployments_url":"https://api.github.com/repos/andela/gryffindor-cfh/deployments","created_at":"2017-08-21T08:36:02Z","updated_at":"2017-08-21T09:24:58Z","pushed_at":"2017-08-25T11:12:49Z","git_url":"git://github.com/andela/gryffindor-cfh.git","ssh_url":"[email protected]:andela/gryffindor-cfh.git","clone_url":"https://github.com/andela/gryffindor-cfh.git","svn_url":"https://github.com/andela/gryffindor-cfh","homepage":null,"size":10339,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/gryffindor-cfh/pulls/14"},"html":{"href":"https://github.com/andela/gryffindor-cfh/pull/14"},"issue":{"href":"https://api.github.com/repos/andela/gryffindor-cfh/issues/14"},"comments":{"href":"https://api.github.com/repos/andela/gryffindor-cfh/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/gryffindor-cfh/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/gryffindor-cfh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/gryffindor-cfh/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/andela/gryffindor-cfh/statuses/e762e0c7c928cba34d97ddff6a3c388782f42a48"}}}} | {
"id": 100931136,
"name": "andela/gryffindor-cfh",
"url": "https://api.github.com/repos/andela/gryffindor-cfh"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
} | 2017-08-25T11:13:01 | 6511735983 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/andela/learning-map-front/pulls/comments/134795821","pull_request_review_id":58130513,"id":134795821,"diff_hunk":"@@ -0,0 +1,115 @@\n+import * as React from 'react';\n+import { render } from 'react-dom';\n+import { connect } from 'react-redux';\n+import { Snackbar } from 'react-toolbox';\n+import decode from '../../common/helpers/jwtDecode';\n+import { config } from '../../config';\n+\n+// interfaces\n+import * as interfaces from '../../interfaces/upvote.d';\n+\n+// styles\n+import './upvoteSection.scss';\n+\n+// axios\n+import http from '../../helpers/http.service';\n+\n+// import * as contributionsAction from '../../actions/ContributionsAction';\n+import * as voteAction from '../../actions/voteAction';\n+\n+/**\n+ *\n+ * @class UpvoteSection\n+ * @extends {React.Component<interfaces.IVotesComponentProps, interfaces.IVotesComponentState>}\n+ */\n+@connect((state) => {\n+ return {\n+ contributions: state.contributions,\n+ };\n+})\n+class UpvoteSection extends React.Component<interfaces.IVotesComponentProps, interfaces.IVotesComponentState> {","path":"src/components/upvoteSection/upvoteSection.component.tsx","position":30,"original_position":30,"commit_id":"2814b5840db0d1c16693afe03f9b27b22219a7ec","original_commit_id":"2814b5840db0d1c16693afe03f9b27b22219a7ec","user":{"login":"andela-cofor","id":25608370,"avatar_url":"https://avatars2.githubusercontent.com/u/25608370?v=4","gravatar_id":"","url":"https://api.github.com/users/andela-cofor","html_url":"https://github.com/andela-cofor","followers_url":"https://api.github.com/users/andela-cofor/followers","following_url":"https://api.github.com/users/andela-cofor/following{/other_user}","gists_url":"https://api.github.com/users/andela-cofor/gists{/gist_id}","starred_url":"https://api.github.com/users/andela-cofor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela-cofor/subscriptions","organizations_url":"https://api.github.com/users/andela-cofor/orgs","repos_url":"https://api.github.com/users/andela-cofor/repos","events_url":"https://api.github.com/users/andela-cofor/events{/privacy}","received_events_url":"https://api.github.com/users/andela-cofor/received_events","type":"User","site_admin":false},"body":"Yes we can...","created_at":"2017-08-23T16:00:52Z","updated_at":"2017-08-23T16:00:53Z","html_url":"https://github.com/andela/learning-map-front/pull/28#discussion_r134795821","pull_request_url":"https://api.github.com/repos/andela/learning-map-front/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/andela/learning-map-front/pulls/comments/134795821"},"html":{"href":"https://github.com/andela/learning-map-front/pull/28#discussion_r134795821"},"pull_request":{"href":"https://api.github.com/repos/andela/learning-map-front/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/andela/learning-map-front/pulls/28","id":135625879,"html_url":"https://github.com/andela/learning-map-front/pull/28","diff_url":"https://github.com/andela/learning-map-front/pull/28.diff","patch_url":"https://github.com/andela/learning-map-front/pull/28.patch","issue_url":"https://api.github.com/repos/andela/learning-map-front/issues/28","number":28,"state":"open","locked":false,"title":"#149954545 Upvote Contribution","user":{"login":"andela-uofoegbu","id":24937777,"avatar_url":"https://avatars1.githubusercontent.com/u/24937777?v=4","gravatar_id":"","url":"https://api.github.com/users/andela-uofoegbu","html_url":"https://github.com/andela-uofoegbu","followers_url":"https://api.github.com/users/andela-uofoegbu/followers","following_url":"https://api.github.com/users/andela-uofoegbu/following{/other_user}","gists_url":"https://api.github.com/users/andela-uofoegbu/gists{/gist_id}","starred_url":"https://api.github.com/users/andela-uofoegbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela-uofoegbu/subscriptions","organizations_url":"https://api.github.com/users/andela-uofoegbu/orgs","repos_url":"https://api.github.com/users/andela-uofoegbu/repos","events_url":"https://api.github.com/users/andela-uofoegbu/events{/privacy}","received_events_url":"https://api.github.com/users/andela-uofoegbu/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nAllows users toggle upvote for a contribution\r\n\r\n#### Description of Task to be completed?\r\nOn the contributions list page, a user should be able to toggle an upvote on a particular contribution\r\n\r\n#### How should this be manually tested?\r\nAfter cloning the repo\r\n\r\n- Run yarn install\r\n- Run yarn start\r\n- Access the landing page via `localhost:3000` and click on the `LOGIN TO CONTRIBUTE` button.\r\n- Navigate to contributions page \r\n- Upvote a contribution\r\n\r\n#### Any background context you want to provide?\r\nN/A\r\n\r\n#### What are the relevant pivotal tracker stories?\r\n[#149954545](https://www.pivotaltracker.com/story/show/149954545)\r\n\r\n#### Screenshot\r\n<img width=\"1275\" alt=\"screen shot 2017-08-16 at 10 18 21\" src=\"https://user-images.githubusercontent.com/24937777/29356986-eab5d1f0-826d-11e7-9154-594ef6761f44.png\">\r\n<img width=\"1270\" alt=\"screen shot 2017-08-16 at 10 14 12\" src=\"https://user-images.githubusercontent.com/24937777/29356988-eac1eabc-826d-11e7-93fe-cdf5a8931da4.png\">\r\n<img width=\"1271\" alt=\"screen shot 2017-08-16 at 10 14 20\" src=\"https://user-images.githubusercontent.com/24937777/29356987-eabb0bac-826d-11e7-8e60-6f6821710633.png\">\r\n\r\n#### Question\r\nN/A\r\n","created_at":"2017-08-14T15:41:42Z","updated_at":"2017-08-23T16:00:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"383538af32e099e9d128a5dbaad642b775688e42","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela/learning-map-front/pulls/28/commits","review_comments_url":"https://api.github.com/repos/andela/learning-map-front/pulls/28/comments","review_comment_url":"https://api.github.com/repos/andela/learning-map-front/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/learning-map-front/issues/28/comments","statuses_url":"https://api.github.com/repos/andela/learning-map-front/statuses/2814b5840db0d1c16693afe03f9b27b22219a7ec","head":{"label":"andela:ft-upvote-contribution-149954545","ref":"ft-upvote-contribution-149954545","sha":"2814b5840db0d1c16693afe03f9b27b22219a7ec","user":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":94885920,"name":"learning-map-front","full_name":"andela/learning-map-front","owner":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/learning-map-front","description":null,"fork":false,"url":"https://api.github.com/repos/andela/learning-map-front","forks_url":"https://api.github.com/repos/andela/learning-map-front/forks","keys_url":"https://api.github.com/repos/andela/learning-map-front/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/learning-map-front/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/learning-map-front/teams","hooks_url":"https://api.github.com/repos/andela/learning-map-front/hooks","issue_events_url":"https://api.github.com/repos/andela/learning-map-front/issues/events{/number}","events_url":"https://api.github.com/repos/andela/learning-map-front/events","assignees_url":"https://api.github.com/repos/andela/learning-map-front/assignees{/user}","branches_url":"https://api.github.com/repos/andela/learning-map-front/branches{/branch}","tags_url":"https://api.github.com/repos/andela/learning-map-front/tags","blobs_url":"https://api.github.com/repos/andela/learning-map-front/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/learning-map-front/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/learning-map-front/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/learning-map-front/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/learning-map-front/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/learning-map-front/languages","stargazers_url":"https://api.github.com/repos/andela/learning-map-front/stargazers","contributors_url":"https://api.github.com/repos/andela/learning-map-front/contributors","subscribers_url":"https://api.github.com/repos/andela/learning-map-front/subscribers","subscription_url":"https://api.github.com/repos/andela/learning-map-front/subscription","commits_url":"https://api.github.com/repos/andela/learning-map-front/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/learning-map-front/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/learning-map-front/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/learning-map-front/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/learning-map-front/contents/{+path}","compare_url":"https://api.github.com/repos/andela/learning-map-front/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/learning-map-front/merges","archive_url":"https://api.github.com/repos/andela/learning-map-front/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/learning-map-front/downloads","issues_url":"https://api.github.com/repos/andela/learning-map-front/issues{/number}","pulls_url":"https://api.github.com/repos/andela/learning-map-front/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/learning-map-front/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/learning-map-front/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/learning-map-front/labels{/name}","releases_url":"https://api.github.com/repos/andela/learning-map-front/releases{/id}","deployments_url":"https://api.github.com/repos/andela/learning-map-front/deployments","created_at":"2017-06-20T11:51:43Z","updated_at":"2017-07-27T14:47:36Z","pushed_at":"2017-08-23T13:33:51Z","git_url":"git://github.com/andela/learning-map-front.git","ssh_url":"[email protected]:andela/learning-map-front.git","clone_url":"https://github.com/andela/learning-map-front.git","svn_url":"https://github.com/andela/learning-map-front","homepage":null,"size":5177,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":0,"default_branch":"develop"}},"base":{"label":"andela:develop","ref":"develop","sha":"c72c85d159aead8ab53533e5c63da09719b26fd1","user":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":94885920,"name":"learning-map-front","full_name":"andela/learning-map-front","owner":{"login":"andela","id":4100206,"avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/learning-map-front","description":null,"fork":false,"url":"https://api.github.com/repos/andela/learning-map-front","forks_url":"https://api.github.com/repos/andela/learning-map-front/forks","keys_url":"https://api.github.com/repos/andela/learning-map-front/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/learning-map-front/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/learning-map-front/teams","hooks_url":"https://api.github.com/repos/andela/learning-map-front/hooks","issue_events_url":"https://api.github.com/repos/andela/learning-map-front/issues/events{/number}","events_url":"https://api.github.com/repos/andela/learning-map-front/events","assignees_url":"https://api.github.com/repos/andela/learning-map-front/assignees{/user}","branches_url":"https://api.github.com/repos/andela/learning-map-front/branches{/branch}","tags_url":"https://api.github.com/repos/andela/learning-map-front/tags","blobs_url":"https://api.github.com/repos/andela/learning-map-front/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/learning-map-front/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/learning-map-front/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/learning-map-front/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/learning-map-front/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/learning-map-front/languages","stargazers_url":"https://api.github.com/repos/andela/learning-map-front/stargazers","contributors_url":"https://api.github.com/repos/andela/learning-map-front/contributors","subscribers_url":"https://api.github.com/repos/andela/learning-map-front/subscribers","subscription_url":"https://api.github.com/repos/andela/learning-map-front/subscription","commits_url":"https://api.github.com/repos/andela/learning-map-front/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/learning-map-front/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/learning-map-front/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/learning-map-front/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/learning-map-front/contents/{+path}","compare_url":"https://api.github.com/repos/andela/learning-map-front/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/learning-map-front/merges","archive_url":"https://api.github.com/repos/andela/learning-map-front/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/learning-map-front/downloads","issues_url":"https://api.github.com/repos/andela/learning-map-front/issues{/number}","pulls_url":"https://api.github.com/repos/andela/learning-map-front/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/learning-map-front/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/learning-map-front/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/learning-map-front/labels{/name}","releases_url":"https://api.github.com/repos/andela/learning-map-front/releases{/id}","deployments_url":"https://api.github.com/repos/andela/learning-map-front/deployments","created_at":"2017-06-20T11:51:43Z","updated_at":"2017-07-27T14:47:36Z","pushed_at":"2017-08-23T13:33:51Z","git_url":"git://github.com/andela/learning-map-front.git","ssh_url":"[email protected]:andela/learning-map-front.git","clone_url":"https://github.com/andela/learning-map-front.git","svn_url":"https://github.com/andela/learning-map-front","homepage":null,"size":5177,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/learning-map-front/pulls/28"},"html":{"href":"https://github.com/andela/learning-map-front/pull/28"},"issue":{"href":"https://api.github.com/repos/andela/learning-map-front/issues/28"},"comments":{"href":"https://api.github.com/repos/andela/learning-map-front/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/learning-map-front/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/learning-map-front/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/learning-map-front/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/andela/learning-map-front/statuses/2814b5840db0d1c16693afe03f9b27b22219a7ec"}}}} | {
"id": 94885920,
"name": "andela/learning-map-front",
"url": "https://api.github.com/repos/andela/learning-map-front"
} | {
"id": 25608370,
"login": "andela-cofor",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25608370?",
"url": "https://api.github.com/users/andela-cofor"
} | {
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
} | 2017-08-23T16:00:52 | 6503201654 | {"actor":{"display_login":"andela-cofor"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/andela/temari-cfh/pulls/comments/102921760","pull_request_review_id":23693219,"id":102921760,"diff_hunk":"@@ -0,0 +1,112 @@\n+angular.module('mean.system')\n+ .factory('chat', function () {","path":"public/js/services/chat.js","position":2,"original_position":2,"commit_id":"c91c04b37626cd6017c249397eea7d893ac2ad4f","original_commit_id":"c91c04b37626cd6017c249397eea7d893ac2ad4f","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Unexpected function expression prefer-arrow-callback","created_at":"2017-02-24T11:06:55Z","updated_at":"2017-02-24T11:06:56Z","html_url":"https://github.com/andela/temari-cfh/pull/47#discussion_r102921760","pull_request_url":"https://api.github.com/repos/andela/temari-cfh/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/andela/temari-cfh/pulls/comments/102921760"},"html":{"href":"https://github.com/andela/temari-cfh/pull/47#discussion_r102921760"},"pull_request":{"href":"https://api.github.com/repos/andela/temari-cfh/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/andela/temari-cfh/pulls/47","id":107809802,"html_url":"https://github.com/andela/temari-cfh/pull/47","diff_url":"https://github.com/andela/temari-cfh/pull/47.diff","patch_url":"https://github.com/andela/temari-cfh/pull/47.patch","issue_url":"https://api.github.com/repos/andela/temari-cfh/issues/47","number":47,"state":"open","locked":false,"title":"Feature/137091027/add emoji to chat","user":{"login":"andela-vnwosu","id":24939135,"avatar_url":"https://avatars.githubusercontent.com/u/24939135?v=3","gravatar_id":"","url":"https://api.github.com/users/andela-vnwosu","html_url":"https://github.com/andela-vnwosu","followers_url":"https://api.github.com/users/andela-vnwosu/followers","following_url":"https://api.github.com/users/andela-vnwosu/following{/other_user}","gists_url":"https://api.github.com/users/andela-vnwosu/gists{/gist_id}","starred_url":"https://api.github.com/users/andela-vnwosu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela-vnwosu/subscriptions","organizations_url":"https://api.github.com/users/andela-vnwosu/orgs","repos_url":"https://api.github.com/users/andela-vnwosu/repos","events_url":"https://api.github.com/users/andela-vnwosu/events{/privacy}","received_events_url":"https://api.github.com/users/andela-vnwosu/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n\r\nThis PR adds the emoji functionality\r\n\r\n#### Description of Task to be completed?\r\n\r\nGIVEN I am a guest or registered user\r\nWHEN I am using the group chat feature\r\nTHEN I can send and receive chats using emojis\r\n\r\n<img width=\"1280\" alt=\"screen shot 2017-02-24 at 12 03 52 pm\" src=\"https://cloud.githubusercontent.com/assets/24939135/23301273/6d02a146-fa89-11e6-8b1c-6957f97ca230.png\">\r\n\r\n","created_at":"2017-02-24T11:06:42Z","updated_at":"2017-02-24T11:06:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela/temari-cfh/pulls/47/commits","review_comments_url":"https://api.github.com/repos/andela/temari-cfh/pulls/47/comments","review_comment_url":"https://api.github.com/repos/andela/temari-cfh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/temari-cfh/issues/47/comments","statuses_url":"https://api.github.com/repos/andela/temari-cfh/statuses/c91c04b37626cd6017c249397eea7d893ac2ad4f","head":{"label":"andela:feature/137091027/add-emoji-to-chat","ref":"feature/137091027/add-emoji-to-chat","sha":"c91c04b37626cd6017c249397eea7d893ac2ad4f","user":{"login":"andela","id":4100206,"avatar_url":"https://avatars.githubusercontent.com/u/4100206?v=3","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":78098385,"name":"temari-cfh","full_name":"andela/temari-cfh","owner":{"login":"andela","id":4100206,"avatar_url":"https://avatars.githubusercontent.com/u/4100206?v=3","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/temari-cfh","description":"A web-based gaming application that allows users donate to charity while enjoying themselves in hilarious rounds of the game.","fork":false,"url":"https://api.github.com/repos/andela/temari-cfh","forks_url":"https://api.github.com/repos/andela/temari-cfh/forks","keys_url":"https://api.github.com/repos/andela/temari-cfh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/temari-cfh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/temari-cfh/teams","hooks_url":"https://api.github.com/repos/andela/temari-cfh/hooks","issue_events_url":"https://api.github.com/repos/andela/temari-cfh/issues/events{/number}","events_url":"https://api.github.com/repos/andela/temari-cfh/events","assignees_url":"https://api.github.com/repos/andela/temari-cfh/assignees{/user}","branches_url":"https://api.github.com/repos/andela/temari-cfh/branches{/branch}","tags_url":"https://api.github.com/repos/andela/temari-cfh/tags","blobs_url":"https://api.github.com/repos/andela/temari-cfh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/temari-cfh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/temari-cfh/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/temari-cfh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/temari-cfh/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/temari-cfh/languages","stargazers_url":"https://api.github.com/repos/andela/temari-cfh/stargazers","contributors_url":"https://api.github.com/repos/andela/temari-cfh/contributors","subscribers_url":"https://api.github.com/repos/andela/temari-cfh/subscribers","subscription_url":"https://api.github.com/repos/andela/temari-cfh/subscription","commits_url":"https://api.github.com/repos/andela/temari-cfh/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/temari-cfh/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/temari-cfh/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/temari-cfh/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/temari-cfh/contents/{+path}","compare_url":"https://api.github.com/repos/andela/temari-cfh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/temari-cfh/merges","archive_url":"https://api.github.com/repos/andela/temari-cfh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/temari-cfh/downloads","issues_url":"https://api.github.com/repos/andela/temari-cfh/issues{/number}","pulls_url":"https://api.github.com/repos/andela/temari-cfh/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/temari-cfh/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/temari-cfh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/temari-cfh/labels{/name}","releases_url":"https://api.github.com/repos/andela/temari-cfh/releases{/id}","deployments_url":"https://api.github.com/repos/andela/temari-cfh/deployments","created_at":"2017-01-05T09:19:07Z","updated_at":"2017-02-17T08:19:05Z","pushed_at":"2017-02-24T11:06:42Z","git_url":"git://github.com/andela/temari-cfh.git","ssh_url":"[email protected]:andela/temari-cfh.git","clone_url":"https://github.com/andela/temari-cfh.git","svn_url":"https://github.com/andela/temari-cfh","homepage":"https://temari-cfh-test.herokuapp.com/#!/","size":14262,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"base":{"label":"andela:develop","ref":"develop","sha":"63ec247cb710c132d325eb69c1d4fa1346c95144","user":{"login":"andela","id":4100206,"avatar_url":"https://avatars.githubusercontent.com/u/4100206?v=3","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":78098385,"name":"temari-cfh","full_name":"andela/temari-cfh","owner":{"login":"andela","id":4100206,"avatar_url":"https://avatars.githubusercontent.com/u/4100206?v=3","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/temari-cfh","description":"A web-based gaming application that allows users donate to charity while enjoying themselves in hilarious rounds of the game.","fork":false,"url":"https://api.github.com/repos/andela/temari-cfh","forks_url":"https://api.github.com/repos/andela/temari-cfh/forks","keys_url":"https://api.github.com/repos/andela/temari-cfh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/temari-cfh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/temari-cfh/teams","hooks_url":"https://api.github.com/repos/andela/temari-cfh/hooks","issue_events_url":"https://api.github.com/repos/andela/temari-cfh/issues/events{/number}","events_url":"https://api.github.com/repos/andela/temari-cfh/events","assignees_url":"https://api.github.com/repos/andela/temari-cfh/assignees{/user}","branches_url":"https://api.github.com/repos/andela/temari-cfh/branches{/branch}","tags_url":"https://api.github.com/repos/andela/temari-cfh/tags","blobs_url":"https://api.github.com/repos/andela/temari-cfh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/temari-cfh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/temari-cfh/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/temari-cfh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/temari-cfh/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/temari-cfh/languages","stargazers_url":"https://api.github.com/repos/andela/temari-cfh/stargazers","contributors_url":"https://api.github.com/repos/andela/temari-cfh/contributors","subscribers_url":"https://api.github.com/repos/andela/temari-cfh/subscribers","subscription_url":"https://api.github.com/repos/andela/temari-cfh/subscription","commits_url":"https://api.github.com/repos/andela/temari-cfh/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/temari-cfh/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/temari-cfh/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/temari-cfh/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/temari-cfh/contents/{+path}","compare_url":"https://api.github.com/repos/andela/temari-cfh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/temari-cfh/merges","archive_url":"https://api.github.com/repos/andela/temari-cfh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/temari-cfh/downloads","issues_url":"https://api.github.com/repos/andela/temari-cfh/issues{/number}","pulls_url":"https://api.github.com/repos/andela/temari-cfh/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/temari-cfh/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/temari-cfh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/temari-cfh/labels{/name}","releases_url":"https://api.github.com/repos/andela/temari-cfh/releases{/id}","deployments_url":"https://api.github.com/repos/andela/temari-cfh/deployments","created_at":"2017-01-05T09:19:07Z","updated_at":"2017-02-17T08:19:05Z","pushed_at":"2017-02-24T11:06:42Z","git_url":"git://github.com/andela/temari-cfh.git","ssh_url":"[email protected]:andela/temari-cfh.git","clone_url":"https://github.com/andela/temari-cfh.git","svn_url":"https://github.com/andela/temari-cfh","homepage":"https://temari-cfh-test.herokuapp.com/#!/","size":14262,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/temari-cfh/pulls/47"},"html":{"href":"https://github.com/andela/temari-cfh/pull/47"},"issue":{"href":"https://api.github.com/repos/andela/temari-cfh/issues/47"},"comments":{"href":"https://api.github.com/repos/andela/temari-cfh/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/temari-cfh/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/temari-cfh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/temari-cfh/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/andela/temari-cfh/statuses/c91c04b37626cd6017c249397eea7d893ac2ad4f"}}}} | {
"id": 78098385,
"name": "andela/temari-cfh",
"url": "https://api.github.com/repos/andela/temari-cfh"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 4100206,
"login": "andela",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4100206?",
"url": "https://api.github.com/orgs/andela"
} | 2017-02-24T11:06:55 | 5384621946 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/arrow/pulls/comments/123878913","pull_request_review_id":46127607,"id":123878913,"diff_hunk":"@@ -367,12 +370,8 @@ if (ARROW_IPC)\n set(FLATBUFFERS_VENDORED 0)\n endif()\n \n- if(RAPIDJSON_VENDORED)\n- set(ARROW_DEPENDENCIES ${ARROW_DEPENDENCIES} rapidjson_ep)\n- endif()\n-\n if(FLATBUFFERS_VENDORED)\n- set(ARROW_DEPENDENCIES ${ARROW_DEPENDENCIES} flatbuffers_ep)","path":"cpp/cmake_modules/ThirdpartyToolchain.cmake","position":37,"original_position":37,"commit_id":"ca8ba32be5a04c1f60121cfc530cd228fd77f6db","original_commit_id":"ca8ba32be5a04c1f60121cfc530cd228fd77f6db","user":{"login":"wesm","id":329591,"avatar_url":"https://avatars1.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"body":"For future reference, this way of declaring dependencies as a list with EP's seems to not work with all versions of CMake. It works with library targets though for some reason","created_at":"2017-06-24T15:04:46Z","updated_at":"2017-06-24T15:04:46Z","html_url":"https://github.com/apache/arrow/pull/779#discussion_r123878913","pull_request_url":"https://api.github.com/repos/apache/arrow/pulls/779","_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments/123878913"},"html":{"href":"https://github.com/apache/arrow/pull/779#discussion_r123878913"},"pull_request":{"href":"https://api.github.com/repos/apache/arrow/pulls/779"}}},"pull_request":{"url":"https://api.github.com/repos/apache/arrow/pulls/779","id":127271599,"html_url":"https://github.com/apache/arrow/pull/779","diff_url":"https://github.com/apache/arrow/pull/779.diff","patch_url":"https://github.com/apache/arrow/pull/779.patch","issue_url":"https://api.github.com/repos/apache/arrow/issues/779","number":779,"state":"open","locked":false,"title":"ARROW-1135: [C++] Use clang 4.0 in one of the Linux builds","user":{"login":"wesm","id":329591,"avatar_url":"https://avatars1.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"body":"This will help us keep the Linux build clean on latest clang","created_at":"2017-06-23T19:16:34Z","updated_at":"2017-06-24T15:04:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2961ddf7163ce2adf4758335bd8c6f9079df54fd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/arrow/pulls/779/commits","review_comments_url":"https://api.github.com/repos/apache/arrow/pulls/779/comments","review_comment_url":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/arrow/issues/779/comments","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/ca8ba32be5a04c1f60121cfc530cd228fd77f6db","head":{"label":"wesm:ARROW-1135","ref":"ARROW-1135","sha":"ca8ba32be5a04c1f60121cfc530cd228fd77f6db","user":{"login":"wesm","id":329591,"avatar_url":"https://avatars1.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"repo":{"id":52022289,"name":"arrow","full_name":"wesm/arrow","owner":{"login":"wesm","id":329591,"avatar_url":"https://avatars1.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wesm/arrow","description":"Mirror of Apache Arrow","fork":true,"url":"https://api.github.com/repos/wesm/arrow","forks_url":"https://api.github.com/repos/wesm/arrow/forks","keys_url":"https://api.github.com/repos/wesm/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wesm/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wesm/arrow/teams","hooks_url":"https://api.github.com/repos/wesm/arrow/hooks","issue_events_url":"https://api.github.com/repos/wesm/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/wesm/arrow/events","assignees_url":"https://api.github.com/repos/wesm/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/wesm/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/wesm/arrow/tags","blobs_url":"https://api.github.com/repos/wesm/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wesm/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wesm/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/wesm/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wesm/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/wesm/arrow/languages","stargazers_url":"https://api.github.com/repos/wesm/arrow/stargazers","contributors_url":"https://api.github.com/repos/wesm/arrow/contributors","subscribers_url":"https://api.github.com/repos/wesm/arrow/subscribers","subscription_url":"https://api.github.com/repos/wesm/arrow/subscription","commits_url":"https://api.github.com/repos/wesm/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/wesm/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/wesm/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/wesm/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/wesm/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/wesm/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wesm/arrow/merges","archive_url":"https://api.github.com/repos/wesm/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wesm/arrow/downloads","issues_url":"https://api.github.com/repos/wesm/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/wesm/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/wesm/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/wesm/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wesm/arrow/labels{/name}","releases_url":"https://api.github.com/repos/wesm/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/wesm/arrow/deployments","created_at":"2016-02-18T16:41:50Z","updated_at":"2017-05-06T18:18:09Z","pushed_at":"2017-06-24T00:20:39Z","git_url":"git://github.com/wesm/arrow.git","ssh_url":"[email protected]:wesm/arrow.git","clone_url":"https://github.com/wesm/arrow.git","svn_url":"https://github.com/wesm/arrow","homepage":null,"size":5300,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"73007de727f07efdf91c4832b1284079fba59d77","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":51905353,"name":"arrow","full_name":"apache/arrow","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/arrow","description":"Apache Arrow is a columnar in-memory analytics layer designed to accelerate big data. It houses a set of canonical in-memory representations of flat and hierarchical data along with multiple language-bindings for structure manipulation. It also provides IPC and common algorithm implementations. ","fork":false,"url":"https://api.github.com/repos/apache/arrow","forks_url":"https://api.github.com/repos/apache/arrow/forks","keys_url":"https://api.github.com/repos/apache/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/arrow/teams","hooks_url":"https://api.github.com/repos/apache/arrow/hooks","issue_events_url":"https://api.github.com/repos/apache/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/arrow/events","assignees_url":"https://api.github.com/repos/apache/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/arrow/tags","blobs_url":"https://api.github.com/repos/apache/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/arrow/languages","stargazers_url":"https://api.github.com/repos/apache/arrow/stargazers","contributors_url":"https://api.github.com/repos/apache/arrow/contributors","subscribers_url":"https://api.github.com/repos/apache/arrow/subscribers","subscription_url":"https://api.github.com/repos/apache/arrow/subscription","commits_url":"https://api.github.com/repos/apache/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/arrow/merges","archive_url":"https://api.github.com/repos/apache/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/arrow/downloads","issues_url":"https://api.github.com/repos/apache/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/arrow/labels{/name}","releases_url":"https://api.github.com/repos/apache/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/arrow/deployments","created_at":"2016-02-17T08:00:23Z","updated_at":"2017-06-23T17:46:12Z","pushed_at":"2017-06-24T03:37:57Z","git_url":"git://github.com/apache/arrow.git","ssh_url":"[email protected]:apache/arrow.git","clone_url":"https://github.com/apache/arrow.git","svn_url":"https://github.com/apache/arrow","homepage":"https://arrow.apache.org","size":5199,"stargazers_count":959,"watchers_count":959,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":250,"mirror_url":"git://git.apache.org/arrow.git","open_issues_count":9,"forks":250,"open_issues":9,"watchers":959,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/779"},"html":{"href":"https://github.com/apache/arrow/pull/779"},"issue":{"href":"https://api.github.com/repos/apache/arrow/issues/779"},"comments":{"href":"https://api.github.com/repos/apache/arrow/issues/779/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/arrow/pulls/779/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/arrow/pulls/779/commits"},"statuses":{"href":"https://api.github.com/repos/apache/arrow/statuses/ca8ba32be5a04c1f60121cfc530cd228fd77f6db"}}}} | {
"id": 51905353,
"name": "apache/arrow",
"url": "https://api.github.com/repos/apache/arrow"
} | {
"id": 329591,
"login": "wesm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/329591?",
"url": "https://api.github.com/users/wesm"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-06-24T15:04:46 | 6131366231 | {"actor":{"display_login":"wesm"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments/131725811","pull_request_review_id":54732711,"id":131725811,"diff_hunk":"@@ -410,6 +487,98 @@ class WskBasicTests\n stdout should include regex (s\"(?i)action /$ns/$name: Action description\\\\s*\\\\(parameters: paramName1, paramName2\\\\)\")\n }\n \n+ it should \"create, and get an action summary without a description and/or defined parameters\" in withAssetCleaner(wskprops) {\n+ (wp, assetHelper) =>\n+ val actNameNoParams = \"actionNoParams\"\n+ val actNameNoDesc = \"actionNoDesc\"\n+ val actNameNoDescOrParams = \"actionNoDescOrParams\"\n+ val desc = \"Action description\"\n+ val descFromParamsResp = \"Returns a result based on parameters\"\n+ val annotsNoParams = Map(\n+ \"description\" -> JsString(desc)\n+ )\n+ val annotsNoDesc = Map(\n+ \"parameters\" -> JsArray(\n+ JsObject(\n+ \"name\" -> JsString(\"paramName1\"),\n+ \"description\" -> JsString(\"Parameter description 1\")),\n+ JsObject(\n+ \"name\" -> JsString(\"paramName2\"),\n+ \"description\" -> JsString(\"Parameter description 2\"))))\n+\n+ assetHelper.withCleaner(wsk.action, actNameNoDesc) {\n+ (action, _) =>\n+ action.create(actNameNoDesc, defaultAction, annotations = annotsNoDesc)\n+ }\n+ assetHelper.withCleaner(wsk.action, actNameNoParams) {\n+ (action, _) =>\n+ action.create(actNameNoParams, defaultAction, annotations = annotsNoParams)\n+ }\n+ assetHelper.withCleaner(wsk.action, actNameNoDescOrParams) {\n+ (action, _) =>\n+ action.create(actNameNoDescOrParams, defaultAction)\n+ }\n+\n+ val stdoutNoDesc = wsk.action.get(actNameNoDesc, summary = true).stdout\n+ val stdoutNoParams = wsk.action.get(actNameNoParams, summary = true).stdout\n+ val stdoutNoDescOrParams = wsk.action.get(actNameNoDescOrParams, summary = true).stdout\n+ val ns_regex_list = wsk.namespace.list().stdout.trim.replace('\\n', '|')\n+\n+ stdoutNoDesc should include regex (\n+ s\"(?i)action /${ns_regex_list}/${actNameNoDesc}: ${descFromParamsResp} paramName1 and paramName2\\\\s*\\\\(parameters: paramName1, paramName2\\\\)\")\n+ stdoutNoParams should include regex (\n+ s\"(?i)action /${ns_regex_list}/${actNameNoParams}: ${desc}\\\\s*\\\\(parameters: none defined\\\\)\")\n+ stdoutNoDescOrParams should include regex (\n+ s\"(?i)action /${ns_regex_list}/${actNameNoDescOrParams}\\\\s*\\\\(parameters: none defined\\\\)\")\n+ }\n+\n+ it should \"denote bound and finalized action parameters for action summaries\" in withAssetCleaner(wskprops) {\n+ (wp, assetHelper) =>\n+ val nameBoundParams = \"actionBoundParams\"\n+ val nameFinalParams = \"actionFinalParams\"\n+ val paramAnnot = \"paramAnnot\"\n+ val paramOverlap = \"paramOverlap\"\n+ val paramBound = \"paramBound\"\n+ val annots = Map(\n+ \"parameters\" -> JsArray(\n+ JsObject(\n+ \"name\" -> JsString(paramAnnot),\n+ \"description\" -> JsString(\"Annotated\")),\n+ JsObject(\n+ \"name\" -> JsString(paramOverlap),\n+ \"description\" -> JsString(\"Annotated And Bound\"))))\n+ val annotsFinal = Map(\n+ \"final\" -> JsBoolean(true),\n+ \"parameters\" -> JsArray(\n+ JsObject(\n+ \"name\" -> JsString(paramAnnot),\n+ \"description\" -> JsString(\"Annotated Parameter description\")),\n+ JsObject(\n+ \"name\" -> JsString(paramOverlap),\n+ \"description\" -> JsString(\"Annotated And Bound\"))))\n+ val paramsBound = Map(\n+ paramBound -> JsString(\"Bound\"),\n+ paramOverlap -> JsString(\"Bound And Annotated\"))\n+\n+ assetHelper.withCleaner(wsk.action, nameBoundParams) {\n+ (action, _) =>\n+ action.create(nameBoundParams, defaultAction, annotations = annots, parameters = paramsBound)\n+ }\n+ assetHelper.withCleaner(wsk.action, nameFinalParams) {\n+ (action, _) =>\n+ action.create(nameFinalParams, defaultAction, annotations = annotsFinal, parameters = paramsBound)\n+ }\n+\n+ val stdoutBound = wsk.action.get(nameBoundParams, summary = true).stdout\n+ val stdoutFinal = wsk.action.get(nameFinalParams, summary = true).stdout\n+ val ns_regex_list = wsk.namespace.list().stdout.trim.replace('\\n', '|')","path":"tests/src/test/scala/system/basic/WskBasicTests.scala","position":172,"original_position":172,"commit_id":"3579a5ed08f04a70fb81ce7080aac474452b27ea","original_commit_id":"3579a5ed08f04a70fb81ce7080aac474452b27ea","user":{"login":"dubeejw","id":11520887,"avatar_url":"https://avatars3.githubusercontent.com/u/11520887?v=4","gravatar_id":"","url":"https://api.github.com/users/dubeejw","html_url":"https://github.com/dubeejw","followers_url":"https://api.github.com/users/dubeejw/followers","following_url":"https://api.github.com/users/dubeejw/following{/other_user}","gists_url":"https://api.github.com/users/dubeejw/gists{/gist_id}","starred_url":"https://api.github.com/users/dubeejw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubeejw/subscriptions","organizations_url":"https://api.github.com/users/dubeejw/orgs","repos_url":"https://api.github.com/users/dubeejw/repos","events_url":"https://api.github.com/users/dubeejw/events{/privacy}","received_events_url":"https://api.github.com/users/dubeejw/received_events","type":"User","site_admin":false},"body":"`ns_regex_list` is not used.","created_at":"2017-08-07T18:12:46Z","updated_at":"2017-08-07T18:19:21Z","html_url":"https://github.com/apache/incubator-openwhisk/pull/2490#discussion_r131725811","pull_request_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/2490","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments/131725811"},"html":{"href":"https://github.com/apache/incubator-openwhisk/pull/2490#discussion_r131725811"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/2490"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/2490","id":130603266,"html_url":"https://github.com/apache/incubator-openwhisk/pull/2490","diff_url":"https://github.com/apache/incubator-openwhisk/pull/2490.diff","patch_url":"https://github.com/apache/incubator-openwhisk/pull/2490.patch","issue_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/2490","number":2490,"state":"open","locked":false,"title":"CLI summaries for actions without annotations","user":{"login":"underwoodb-sd-ibm","id":28906616,"avatar_url":"https://avatars0.githubusercontent.com/u/28906616?v=4","gravatar_id":"","url":"https://api.github.com/users/underwoodb-sd-ibm","html_url":"https://github.com/underwoodb-sd-ibm","followers_url":"https://api.github.com/users/underwoodb-sd-ibm/followers","following_url":"https://api.github.com/users/underwoodb-sd-ibm/following{/other_user}","gists_url":"https://api.github.com/users/underwoodb-sd-ibm/gists{/gist_id}","starred_url":"https://api.github.com/users/underwoodb-sd-ibm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/underwoodb-sd-ibm/subscriptions","organizations_url":"https://api.github.com/users/underwoodb-sd-ibm/orgs","repos_url":"https://api.github.com/users/underwoodb-sd-ibm/repos","events_url":"https://api.github.com/users/underwoodb-sd-ibm/events{/privacy}","received_events_url":"https://api.github.com/users/underwoodb-sd-ibm/received_events","type":"User","site_admin":false},"body":"This update is intended to clarify the printed summary when one uses `wsk [ENTITY] [ENTITY_NAME] get --summary`.\r\n\r\nHere is an example of what the output of this update should look like:\r\n\r\nFor entities with multiple parameters and no description:\r\n```\r\n$ wsk action get hola -s\r\naction /guest/hola: Returns a result based on parameters testA, testB and testC\r\n (parameters: testA, testB, testC)\r\n```\r\n\r\nFor entities with a single parameter and no description:\r\n```\r\n$ wsk action get hola -s\r\naction /guest/hola: Returns a result based on parameter testA\r\n (parameters: testA)\r\n```\r\n\r\nAnd entities with no parameters and no description:\r\n```\r\n$ wsk action get hello -s\r\naction /guest/hello\r\n (Warning: /guest/hello has no annotations)\r\n```\r\n\r\n Closes https://github.com/apache/incubator-openwhisk/issues/2270","created_at":"2017-07-14T14:36:55Z","updated_at":"2017-08-07T18:19:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f20462cc12fed2a784119696817320c433d64d5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/2490/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/2490/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/2490/comments","statuses_url":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/3579a5ed08f04a70fb81ce7080aac474452b27ea","head":{"label":"underwoodb-sd-ibm:summary2270","ref":"summary2270","sha":"3579a5ed08f04a70fb81ce7080aac474452b27ea","user":{"login":"underwoodb-sd-ibm","id":28906616,"avatar_url":"https://avatars0.githubusercontent.com/u/28906616?v=4","gravatar_id":"","url":"https://api.github.com/users/underwoodb-sd-ibm","html_url":"https://github.com/underwoodb-sd-ibm","followers_url":"https://api.github.com/users/underwoodb-sd-ibm/followers","following_url":"https://api.github.com/users/underwoodb-sd-ibm/following{/other_user}","gists_url":"https://api.github.com/users/underwoodb-sd-ibm/gists{/gist_id}","starred_url":"https://api.github.com/users/underwoodb-sd-ibm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/underwoodb-sd-ibm/subscriptions","organizations_url":"https://api.github.com/users/underwoodb-sd-ibm/orgs","repos_url":"https://api.github.com/users/underwoodb-sd-ibm/repos","events_url":"https://api.github.com/users/underwoodb-sd-ibm/events{/privacy}","received_events_url":"https://api.github.com/users/underwoodb-sd-ibm/received_events","type":"User","site_admin":false},"repo":{"id":92319705,"name":"incubator-openwhisk","full_name":"underwoodb-sd-ibm/incubator-openwhisk","owner":{"login":"underwoodb-sd-ibm","id":28906616,"avatar_url":"https://avatars0.githubusercontent.com/u/28906616?v=4","gravatar_id":"","url":"https://api.github.com/users/underwoodb-sd-ibm","html_url":"https://github.com/underwoodb-sd-ibm","followers_url":"https://api.github.com/users/underwoodb-sd-ibm/followers","following_url":"https://api.github.com/users/underwoodb-sd-ibm/following{/other_user}","gists_url":"https://api.github.com/users/underwoodb-sd-ibm/gists{/gist_id}","starred_url":"https://api.github.com/users/underwoodb-sd-ibm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/underwoodb-sd-ibm/subscriptions","organizations_url":"https://api.github.com/users/underwoodb-sd-ibm/orgs","repos_url":"https://api.github.com/users/underwoodb-sd-ibm/repos","events_url":"https://api.github.com/users/underwoodb-sd-ibm/events{/privacy}","received_events_url":"https://api.github.com/users/underwoodb-sd-ibm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/underwoodb-sd-ibm/incubator-openwhisk","description":"Apache OpenWhisk is a serverless event-based programming service and an Apache Incubator project.","fork":true,"url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk","forks_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/forks","keys_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/teams","hooks_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/hooks","issue_events_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/issues/events{/number}","events_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/events","assignees_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/assignees{/user}","branches_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/branches{/branch}","tags_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/tags","blobs_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/statuses/{sha}","languages_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/languages","stargazers_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/stargazers","contributors_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/contributors","subscribers_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/subscribers","subscription_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/subscription","commits_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/contents/{+path}","compare_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/merges","archive_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/downloads","issues_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/issues{/number}","pulls_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/pulls{/number}","milestones_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/milestones{/number}","notifications_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/labels{/name}","releases_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/releases{/id}","deployments_url":"https://api.github.com/repos/underwoodb-sd-ibm/incubator-openwhisk/deployments","created_at":"2017-05-24T17:42:34Z","updated_at":"2017-05-24T17:42:37Z","pushed_at":"2017-08-07T16:18:27Z","git_url":"git://github.com/underwoodb-sd-ibm/incubator-openwhisk.git","ssh_url":"[email protected]:underwoodb-sd-ibm/incubator-openwhisk.git","clone_url":"https://github.com/underwoodb-sd-ibm/incubator-openwhisk.git","svn_url":"https://github.com/underwoodb-sd-ibm/incubator-openwhisk","homepage":"http://openwhisk.org","size":56189,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8be4cdf6b2d3de67f46b5a1fb9e5911a62dca8f7","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":52039373,"name":"incubator-openwhisk","full_name":"apache/incubator-openwhisk","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-openwhisk","description":"Apache OpenWhisk is a serverless event-based programming service and an Apache Incubator project.","fork":false,"url":"https://api.github.com/repos/apache/incubator-openwhisk","forks_url":"https://api.github.com/repos/apache/incubator-openwhisk/forks","keys_url":"https://api.github.com/repos/apache/incubator-openwhisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-openwhisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-openwhisk/teams","hooks_url":"https://api.github.com/repos/apache/incubator-openwhisk/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-openwhisk/events","assignees_url":"https://api.github.com/repos/apache/incubator-openwhisk/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-openwhisk/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-openwhisk/tags","blobs_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-openwhisk/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-openwhisk/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-openwhisk/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-openwhisk/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-openwhisk/subscription","commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-openwhisk/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-openwhisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-openwhisk/merges","archive_url":"https://api.github.com/repos/apache/incubator-openwhisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-openwhisk/downloads","issues_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-openwhisk/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-openwhisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-openwhisk/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-openwhisk/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-openwhisk/deployments","created_at":"2016-02-18T21:16:19Z","updated_at":"2017-08-07T15:25:35Z","pushed_at":"2017-08-07T16:29:18Z","git_url":"git://github.com/apache/incubator-openwhisk.git","ssh_url":"[email protected]:apache/incubator-openwhisk.git","clone_url":"https://github.com/apache/incubator-openwhisk.git","svn_url":"https://github.com/apache/incubator-openwhisk","homepage":"http://openwhisk.org","size":56086,"stargazers_count":1788,"watchers_count":1788,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":393,"mirror_url":null,"open_issues_count":364,"forks":393,"open_issues":364,"watchers":1788,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/2490"},"html":{"href":"https://github.com/apache/incubator-openwhisk/pull/2490"},"issue":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/issues/2490"},"comments":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/issues/2490/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/2490/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/2490/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/3579a5ed08f04a70fb81ce7080aac474452b27ea"}}}} | {
"id": 52039373,
"name": "apache/incubator-openwhisk",
"url": "https://api.github.com/repos/apache/incubator-openwhisk"
} | {
"id": 11520887,
"login": "dubeejw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11520887?",
"url": "https://api.github.com/users/dubeejw"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-08-07T18:12:46 | 6409603296 | {"actor":{"display_login":"dubeejw"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/100682316","pull_request_review_id":21399083,"id":100682316,"diff_hunk":"@@ -425,7 +425,9 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder {\n \n logWarning(s\"CREATE TEMPORARY TABLE ... USING ... is deprecated, please use \" +\n \"CREATE TEMPORARY VIEW ... USING ... instead\")\n- CreateTempViewUsing(table, schema, replace = true, global = false, provider, options)\n+ // Since we don't support IF NOT EXISTS for temp table, we should not allow\n+ // replacing existing temp table, that may accidentally remove a temp view in use.","path":"sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala","position":6,"original_position":6,"commit_id":"133bd99b1158f08bf2fe5e278cd632efc39d7ddb","original_commit_id":"133bd99b1158f08bf2fe5e278cd632efc39d7ddb","user":{"login":"gatorsmile","id":11567269,"avatar_url":"https://avatars.githubusercontent.com/u/11567269?v=3","gravatar_id":"","url":"https://api.github.com/users/gatorsmile","html_url":"https://github.com/gatorsmile","followers_url":"https://api.github.com/users/gatorsmile/followers","following_url":"https://api.github.com/users/gatorsmile/following{/other_user}","gists_url":"https://api.github.com/users/gatorsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/gatorsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatorsmile/subscriptions","organizations_url":"https://api.github.com/users/gatorsmile/orgs","repos_url":"https://api.github.com/users/gatorsmile/repos","events_url":"https://api.github.com/users/gatorsmile/events{/privacy}","received_events_url":"https://api.github.com/users/gatorsmile/received_events","type":"User","site_admin":false},"body":"The same here.","created_at":"2017-02-12T03:14:27Z","updated_at":"2017-02-12T03:14:27Z","html_url":"https://github.com/apache/spark/pull/16878#discussion_r100682316","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/16878","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/100682316"},"html":{"href":"https://github.com/apache/spark/pull/16878#discussion_r100682316"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/16878"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/16878","id":105549997,"html_url":"https://github.com/apache/spark/pull/16878","diff_url":"https://github.com/apache/spark/pull/16878.diff","patch_url":"https://github.com/apache/spark/pull/16878.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/16878","number":16878,"state":"open","locked":false,"title":"[SPARK-19539][SQL] Block duplicate temp table during creation","user":{"login":"xwu0226","id":14225992,"avatar_url":"https://avatars.githubusercontent.com/u/14225992?v=3","gravatar_id":"","url":"https://api.github.com/users/xwu0226","html_url":"https://github.com/xwu0226","followers_url":"https://api.github.com/users/xwu0226/followers","following_url":"https://api.github.com/users/xwu0226/following{/other_user}","gists_url":"https://api.github.com/users/xwu0226/gists{/gist_id}","starred_url":"https://api.github.com/users/xwu0226/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwu0226/subscriptions","organizations_url":"https://api.github.com/users/xwu0226/orgs","repos_url":"https://api.github.com/users/xwu0226/repos","events_url":"https://api.github.com/users/xwu0226/events{/privacy}","received_events_url":"https://api.github.com/users/xwu0226/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\nCurrent `CREATE TEMPORARY TABLE ... ` is deprecated and recommend users to use `CREATE TEMPORARY VIEW ...` And it does not support `IF NOT EXISTS `clause. However, if there is an existing temporary view defined, it is possible to unintentionally replace this existing view by issuing `CREATE TEMPORARY TABLE ...` with the same table/view name.\r\n\r\nThis PR is to disallow `CREATE TEMPORARY TABLE ...` with an existing view name. \r\nUnder the cover, `CREATE TEMPORARY TABLE ...` will be changed to create temporary view, however, passing in a flag `replace=false`, instead of currently `true`. So when creating temporary view under the cover, if there is existing view with the same name, the operation will be blocked. \r\n\r\n## How was this patch tested?\r\nNew unit test case is added and updated some existing test cases to adapt the new behavior","created_at":"2017-02-10T01:29:30Z","updated_at":"2017-02-12T03:14:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"850bd05d12c56db1709123f178765039bc3ebd46","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/16878/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/16878/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/16878/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/133bd99b1158f08bf2fe5e278cd632efc39d7ddb","head":{"label":"xwu0226:block_duplicate_temp_table","ref":"block_duplicate_temp_table","sha":"133bd99b1158f08bf2fe5e278cd632efc39d7ddb","user":{"login":"xwu0226","id":14225992,"avatar_url":"https://avatars.githubusercontent.com/u/14225992?v=3","gravatar_id":"","url":"https://api.github.com/users/xwu0226","html_url":"https://github.com/xwu0226","followers_url":"https://api.github.com/users/xwu0226/followers","following_url":"https://api.github.com/users/xwu0226/following{/other_user}","gists_url":"https://api.github.com/users/xwu0226/gists{/gist_id}","starred_url":"https://api.github.com/users/xwu0226/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwu0226/subscriptions","organizations_url":"https://api.github.com/users/xwu0226/orgs","repos_url":"https://api.github.com/users/xwu0226/repos","events_url":"https://api.github.com/users/xwu0226/events{/privacy}","received_events_url":"https://api.github.com/users/xwu0226/received_events","type":"User","site_admin":false},"repo":{"id":42968936,"name":"spark","full_name":"xwu0226/spark","owner":{"login":"xwu0226","id":14225992,"avatar_url":"https://avatars.githubusercontent.com/u/14225992?v=3","gravatar_id":"","url":"https://api.github.com/users/xwu0226","html_url":"https://github.com/xwu0226","followers_url":"https://api.github.com/users/xwu0226/followers","following_url":"https://api.github.com/users/xwu0226/following{/other_user}","gists_url":"https://api.github.com/users/xwu0226/gists{/gist_id}","starred_url":"https://api.github.com/users/xwu0226/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwu0226/subscriptions","organizations_url":"https://api.github.com/users/xwu0226/orgs","repos_url":"https://api.github.com/users/xwu0226/repos","events_url":"https://api.github.com/users/xwu0226/events{/privacy}","received_events_url":"https://api.github.com/users/xwu0226/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xwu0226/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/xwu0226/spark","forks_url":"https://api.github.com/repos/xwu0226/spark/forks","keys_url":"https://api.github.com/repos/xwu0226/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xwu0226/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xwu0226/spark/teams","hooks_url":"https://api.github.com/repos/xwu0226/spark/hooks","issue_events_url":"https://api.github.com/repos/xwu0226/spark/issues/events{/number}","events_url":"https://api.github.com/repos/xwu0226/spark/events","assignees_url":"https://api.github.com/repos/xwu0226/spark/assignees{/user}","branches_url":"https://api.github.com/repos/xwu0226/spark/branches{/branch}","tags_url":"https://api.github.com/repos/xwu0226/spark/tags","blobs_url":"https://api.github.com/repos/xwu0226/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xwu0226/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xwu0226/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/xwu0226/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xwu0226/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/xwu0226/spark/languages","stargazers_url":"https://api.github.com/repos/xwu0226/spark/stargazers","contributors_url":"https://api.github.com/repos/xwu0226/spark/contributors","subscribers_url":"https://api.github.com/repos/xwu0226/spark/subscribers","subscription_url":"https://api.github.com/repos/xwu0226/spark/subscription","commits_url":"https://api.github.com/repos/xwu0226/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/xwu0226/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/xwu0226/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/xwu0226/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/xwu0226/spark/contents/{+path}","compare_url":"https://api.github.com/repos/xwu0226/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xwu0226/spark/merges","archive_url":"https://api.github.com/repos/xwu0226/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xwu0226/spark/downloads","issues_url":"https://api.github.com/repos/xwu0226/spark/issues{/number}","pulls_url":"https://api.github.com/repos/xwu0226/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/xwu0226/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/xwu0226/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xwu0226/spark/labels{/name}","releases_url":"https://api.github.com/repos/xwu0226/spark/releases{/id}","deployments_url":"https://api.github.com/repos/xwu0226/spark/deployments","created_at":"2015-09-23T00:30:54Z","updated_at":"2016-01-15T19:57:06Z","pushed_at":"2017-02-10T01:20:40Z","git_url":"git://github.com/xwu0226/spark.git","ssh_url":"[email protected]:xwu0226/spark.git","clone_url":"https://github.com/xwu0226/spark.git","svn_url":"https://github.com/xwu0226/spark","homepage":null,"size":253051,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"fd6c3a0b10ce43a56df845ba66d160b77f02e576","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2017-02-12T01:26:42Z","pushed_at":"2017-02-12T02:42:36Z","git_url":"git://github.com/apache/spark.git","ssh_url":"[email protected]:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":262647,"stargazers_count":11647,"watchers_count":11647,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10913,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":482,"forks":10913,"open_issues":482,"watchers":11647,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/16878"},"html":{"href":"https://github.com/apache/spark/pull/16878"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/16878"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/16878/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/16878/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/16878/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/133bd99b1158f08bf2fe5e278cd632efc39d7ddb"}}}} | {
"id": 17165658,
"name": "apache/spark",
"url": "https://api.github.com/repos/apache/spark"
} | {
"id": 11567269,
"login": "gatorsmile",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11567269?",
"url": "https://api.github.com/users/gatorsmile"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-02-12T03:14:27 | 5308919759 | {"actor":{"display_login":"gatorsmile"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/comments/158594624","pull_request_review_id":85434761,"id":158594624,"diff_hunk":"@@ -192,6 +194,10 @@\n + \" Example: dhcpoptionsnetworklist[0].dhcp:114=url&dhcpoptionsetworklist[0].networkid=networkid&dhcpoptionsetworklist[0].dhcp:66=www.test.com\")\n private Map dhcpOptionsNetworkList;\n \n+ @Parameter(name = ApiConstants.DATADISK_OFFERING_LIST, type = CommandType.MAP, since = \"4.10\", description = \"datadisk template to disk-offering mapping;\" +\n+ \" an optional parameter used to create additional data disks from datadisk templates; can't be specified with diskOfferingId parameter\")\n+ private Map dataDiskTemplateToDiskOfferingList;","path":"api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java","position":null,"original_position":15,"commit_id":"6ec34a1e6b7ccc40b7094a8746aead4c13383335","original_commit_id":"7e8385bea9ce36b186e36f580106580aaf9de100","user":{"login":"nvazquez","id":5295080,"avatar_url":"https://avatars2.githubusercontent.com/u/5295080?v=4","gravatar_id":"","url":"https://api.github.com/users/nvazquez","html_url":"https://github.com/nvazquez","followers_url":"https://api.github.com/users/nvazquez/followers","following_url":"https://api.github.com/users/nvazquez/following{/other_user}","gists_url":"https://api.github.com/users/nvazquez/gists{/gist_id}","starred_url":"https://api.github.com/users/nvazquez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvazquez/subscriptions","organizations_url":"https://api.github.com/users/nvazquez/orgs","repos_url":"https://api.github.com/users/nvazquez/repos","events_url":"https://api.github.com/users/nvazquez/events{/privacy}","received_events_url":"https://api.github.com/users/nvazquez/received_events","type":"User","site_admin":false},"body":"It is a map of maps indeed. I agree that its name is not the best, however I noticed the same situation on previous parameter dhcpOptionsNetworkList. I think this PR's author tried to follow that pattern. I hadn't changed its name yet, which name do you suggest for it?","created_at":"2017-12-24T06:25:26Z","updated_at":"2017-12-24T06:25:26Z","html_url":"https://github.com/apache/cloudstack/pull/2146#discussion_r158594624","pull_request_url":"https://api.github.com/repos/apache/cloudstack/pulls/2146","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments/158594624"},"html":{"href":"https://github.com/apache/cloudstack/pull/2146#discussion_r158594624"},"pull_request":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/2146"}},"in_reply_to_id":158580612},"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/2146","id":125347710,"html_url":"https://github.com/apache/cloudstack/pull/2146","diff_url":"https://github.com/apache/cloudstack/pull/2146.diff","patch_url":"https://github.com/apache/cloudstack/pull/2146.patch","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/2146","number":2146,"state":"open","locked":false,"title":"CLOUDSTACK-4757: Support OVA files with multiple disks for templates","user":{"login":"abhinandanprateek","id":12134381,"avatar_url":"https://avatars3.githubusercontent.com/u/12134381?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinandanprateek","html_url":"https://github.com/abhinandanprateek","followers_url":"https://api.github.com/users/abhinandanprateek/followers","following_url":"https://api.github.com/users/abhinandanprateek/following{/other_user}","gists_url":"https://api.github.com/users/abhinandanprateek/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinandanprateek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinandanprateek/subscriptions","organizations_url":"https://api.github.com/users/abhinandanprateek/orgs","repos_url":"https://api.github.com/users/abhinandanprateek/repos","events_url":"https://api.github.com/users/abhinandanprateek/events{/privacy}","received_events_url":"https://api.github.com/users/abhinandanprateek/received_events","type":"User","site_admin":false},"body":"JIRA Ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-4757\r\n\r\nUpdated FS here: \r\nhttps://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+OVA+files+containing+multiple+disks","created_at":"2017-06-13T12:11:02Z","updated_at":"2017-12-24T06:25:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3288b2df35386ddcedcf19a4ce5047b305467e8f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/apache/cloudstack/milestones/3","html_url":"https://github.com/apache/cloudstack/milestone/3","labels_url":"https://api.github.com/repos/apache/cloudstack/milestones/3/labels","id":2457915,"number":3,"title":"4.11","description":"This is milestone to track PRs towards the next 4.11/4.11.0.0 release.","creator":{"login":"wido","id":326786,"avatar_url":"https://avatars2.githubusercontent.com/u/326786?v=4","gravatar_id":"","url":"https://api.github.com/users/wido","html_url":"https://github.com/wido","followers_url":"https://api.github.com/users/wido/followers","following_url":"https://api.github.com/users/wido/following{/other_user}","gists_url":"https://api.github.com/users/wido/gists{/gist_id}","starred_url":"https://api.github.com/users/wido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wido/subscriptions","organizations_url":"https://api.github.com/users/wido/orgs","repos_url":"https://api.github.com/users/wido/repos","events_url":"https://api.github.com/users/wido/events{/privacy}","received_events_url":"https://api.github.com/users/wido/received_events","type":"User","site_admin":false},"open_issues":67,"closed_issues":54,"state":"open","created_at":"2017-04-14T20:03:46Z","updated_at":"2017-12-23T11:49:42Z","due_on":"2018-01-08T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/cloudstack/pulls/2146/commits","review_comments_url":"https://api.github.com/repos/apache/cloudstack/pulls/2146/comments","review_comment_url":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/2146/comments","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/6ec34a1e6b7ccc40b7094a8746aead4c13383335","head":{"label":"shapeblue:md-ova2","ref":"md-ova2","sha":"6ec34a1e6b7ccc40b7094a8746aead4c13383335","user":{"login":"shapeblue","id":6001764,"avatar_url":"https://avatars1.githubusercontent.com/u/6001764?v=4","gravatar_id":"","url":"https://api.github.com/users/shapeblue","html_url":"https://github.com/shapeblue","followers_url":"https://api.github.com/users/shapeblue/followers","following_url":"https://api.github.com/users/shapeblue/following{/other_user}","gists_url":"https://api.github.com/users/shapeblue/gists{/gist_id}","starred_url":"https://api.github.com/users/shapeblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shapeblue/subscriptions","organizations_url":"https://api.github.com/users/shapeblue/orgs","repos_url":"https://api.github.com/users/shapeblue/repos","events_url":"https://api.github.com/users/shapeblue/events{/privacy}","received_events_url":"https://api.github.com/users/shapeblue/received_events","type":"Organization","site_admin":false},"repo":{"id":35481491,"name":"cloudstack","full_name":"shapeblue/cloudstack","owner":{"login":"shapeblue","id":6001764,"avatar_url":"https://avatars1.githubusercontent.com/u/6001764?v=4","gravatar_id":"","url":"https://api.github.com/users/shapeblue","html_url":"https://github.com/shapeblue","followers_url":"https://api.github.com/users/shapeblue/followers","following_url":"https://api.github.com/users/shapeblue/following{/other_user}","gists_url":"https://api.github.com/users/shapeblue/gists{/gist_id}","starred_url":"https://api.github.com/users/shapeblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shapeblue/subscriptions","organizations_url":"https://api.github.com/users/shapeblue/orgs","repos_url":"https://api.github.com/users/shapeblue/repos","events_url":"https://api.github.com/users/shapeblue/events{/privacy}","received_events_url":"https://api.github.com/users/shapeblue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shapeblue/cloudstack","description":"The upstream repository is at http://github.com/apache/cloudstack. This is ShapeBlue's support/patch branches and Apache CloudStack™ backup","fork":true,"url":"https://api.github.com/repos/shapeblue/cloudstack","forks_url":"https://api.github.com/repos/shapeblue/cloudstack/forks","keys_url":"https://api.github.com/repos/shapeblue/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shapeblue/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shapeblue/cloudstack/teams","hooks_url":"https://api.github.com/repos/shapeblue/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/shapeblue/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/shapeblue/cloudstack/events","assignees_url":"https://api.github.com/repos/shapeblue/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/shapeblue/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/shapeblue/cloudstack/tags","blobs_url":"https://api.github.com/repos/shapeblue/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shapeblue/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shapeblue/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/shapeblue/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shapeblue/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/shapeblue/cloudstack/languages","stargazers_url":"https://api.github.com/repos/shapeblue/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/shapeblue/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/shapeblue/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/shapeblue/cloudstack/subscription","commits_url":"https://api.github.com/repos/shapeblue/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/shapeblue/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/shapeblue/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/shapeblue/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/shapeblue/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/shapeblue/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shapeblue/cloudstack/merges","archive_url":"https://api.github.com/repos/shapeblue/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shapeblue/cloudstack/downloads","issues_url":"https://api.github.com/repos/shapeblue/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/shapeblue/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/shapeblue/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/shapeblue/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shapeblue/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/shapeblue/cloudstack/releases{/id}","deployments_url":"https://api.github.com/repos/shapeblue/cloudstack/deployments","created_at":"2015-05-12T10:22:21Z","updated_at":"2016-12-08T09:26:57Z","pushed_at":"2017-12-24T06:11:48Z","git_url":"git://github.com/shapeblue/cloudstack.git","ssh_url":"[email protected]:shapeblue/cloudstack.git","clone_url":"https://github.com/shapeblue/cloudstack.git","svn_url":"https://github.com/shapeblue/cloudstack","homepage":"http://shapeblue.com/packages","size":532213,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"cd637fd05f7c893824319c3040288166c82d6371","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":9759448,"name":"cloudstack","full_name":"apache/cloudstack","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cloudstack","description":"Mirror of Apache Cloudstack","fork":false,"url":"https://api.github.com/repos/apache/cloudstack","forks_url":"https://api.github.com/repos/apache/cloudstack/forks","keys_url":"https://api.github.com/repos/apache/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cloudstack/teams","hooks_url":"https://api.github.com/repos/apache/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/apache/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cloudstack/events","assignees_url":"https://api.github.com/repos/apache/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cloudstack/tags","blobs_url":"https://api.github.com/repos/apache/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cloudstack/languages","stargazers_url":"https://api.github.com/repos/apache/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/apache/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/apache/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/apache/cloudstack/subscription","commits_url":"https://api.github.com/repos/apache/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cloudstack/merges","archive_url":"https://api.github.com/repos/apache/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cloudstack/downloads","issues_url":"https://api.github.com/repos/apache/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/apache/cloudstack/releases{/id}","deployments_url":"https://api.github.com/repos/apache/cloudstack/deployments","created_at":"2013-04-29T22:27:12Z","updated_at":"2017-12-22T03:08:29Z","pushed_at":"2017-12-24T06:11:50Z","git_url":"git://github.com/apache/cloudstack.git","ssh_url":"[email protected]:apache/cloudstack.git","clone_url":"https://github.com/apache/cloudstack.git","svn_url":"https://github.com/apache/cloudstack","homepage":null,"size":518558,"stargazers_count":514,"watchers_count":514,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":604,"mirror_url":null,"archived":false,"open_issues_count":133,"license":null,"forks":604,"open_issues":133,"watchers":514,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/2146"},"html":{"href":"https://github.com/apache/cloudstack/pull/2146"},"issue":{"href":"https://api.github.com/repos/apache/cloudstack/issues/2146"},"comments":{"href":"https://api.github.com/repos/apache/cloudstack/issues/2146/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/2146/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/2146/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cloudstack/statuses/6ec34a1e6b7ccc40b7094a8746aead4c13383335"}},"author_association":"CONTRIBUTOR"}} | {
"id": 9759448,
"name": "apache/cloudstack",
"url": "https://api.github.com/repos/apache/cloudstack"
} | {
"id": 5295080,
"login": "nvazquez",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5295080?",
"url": "https://api.github.com/users/nvazquez"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-12-24T06:25:26 | 7026587608 | {"actor":{"display_login":"nvazquez"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/126884475","pull_request_review_id":49410777,"id":126884475,"diff_hunk":"@@ -72,11 +72,6 @@ abstract class SparkPlan extends QueryPlan[SparkPlan] with Logging with Serializ\n }\n \n /**\n- * @return Metadata that describes more details of this SparkPlan.\n- */\n- def metadata: Map[String, String] = Map.empty","path":"sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala","position":6,"original_position":6,"commit_id":"2dc4ce1e439b4ad86c4ede14397e645d05a1555b","original_commit_id":"2dc4ce1e439b4ad86c4ede14397e645d05a1555b","user":{"login":"cloud-fan","id":3182036,"avatar_url":"https://avatars0.githubusercontent.com/u/3182036?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"body":"We introduced `metadata` to work around the equality issue of data source scan. Now it's fixed, and we can remove it.","created_at":"2017-07-12T07:44:59Z","updated_at":"2017-07-12T07:44:59Z","html_url":"https://github.com/apache/spark/pull/18600#discussion_r126884475","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/18600","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/126884475"},"html":{"href":"https://github.com/apache/spark/pull/18600#discussion_r126884475"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/18600"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/18600","id":129912892,"html_url":"https://github.com/apache/spark/pull/18600","diff_url":"https://github.com/apache/spark/pull/18600.diff","patch_url":"https://github.com/apache/spark/pull/18600.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/18600","number":18600,"state":"open","locked":false,"title":"[SPARK-17701][SQL] Refactor RowDataSourceScanExec so its sameResult call does not compare strings","user":{"login":"cloud-fan","id":3182036,"avatar_url":"https://avatars0.githubusercontent.com/u/3182036?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nCurrently, `RowDataSourceScanExec` and `FileSourceScanExec` rely on a \"metadata\" string map to implement equality comparison, since the RDDs they depend on cannot be directly compared. This has resulted in a number of correctness bugs around exchange reuse, e.g. SPARK-17673 and SPARK-16818.\r\n\r\nTo make these comparisons less brittle, we should refactor these classes to compare constructor parameters directly instead of relying on the metadata map.\r\n\r\nThis PR refactors `RowDataSourceScanExec`, `FileSourceScanExec` will be fixed in the follow-up PR.\r\n\r\n## How was this patch tested?\r\n\r\nexisting tests","created_at":"2017-07-11T13:50:43Z","updated_at":"2017-07-12T07:44:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46dcbda44cbcd95da8c3d161e4aede267ee405ef","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/18600/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/18600/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/18600/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/2dc4ce1e439b4ad86c4ede14397e645d05a1555b","head":{"label":"cloud-fan:minor","ref":"minor","sha":"2dc4ce1e439b4ad86c4ede14397e645d05a1555b","user":{"login":"cloud-fan","id":3182036,"avatar_url":"https://avatars0.githubusercontent.com/u/3182036?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"repo":{"id":19689699,"name":"spark","full_name":"cloud-fan/spark","owner":{"login":"cloud-fan","id":3182036,"avatar_url":"https://avatars0.githubusercontent.com/u/3182036?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cloud-fan/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/cloud-fan/spark","forks_url":"https://api.github.com/repos/cloud-fan/spark/forks","keys_url":"https://api.github.com/repos/cloud-fan/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloud-fan/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloud-fan/spark/teams","hooks_url":"https://api.github.com/repos/cloud-fan/spark/hooks","issue_events_url":"https://api.github.com/repos/cloud-fan/spark/issues/events{/number}","events_url":"https://api.github.com/repos/cloud-fan/spark/events","assignees_url":"https://api.github.com/repos/cloud-fan/spark/assignees{/user}","branches_url":"https://api.github.com/repos/cloud-fan/spark/branches{/branch}","tags_url":"https://api.github.com/repos/cloud-fan/spark/tags","blobs_url":"https://api.github.com/repos/cloud-fan/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloud-fan/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloud-fan/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloud-fan/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloud-fan/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/cloud-fan/spark/languages","stargazers_url":"https://api.github.com/repos/cloud-fan/spark/stargazers","contributors_url":"https://api.github.com/repos/cloud-fan/spark/contributors","subscribers_url":"https://api.github.com/repos/cloud-fan/spark/subscribers","subscription_url":"https://api.github.com/repos/cloud-fan/spark/subscription","commits_url":"https://api.github.com/repos/cloud-fan/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloud-fan/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloud-fan/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloud-fan/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloud-fan/spark/contents/{+path}","compare_url":"https://api.github.com/repos/cloud-fan/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloud-fan/spark/merges","archive_url":"https://api.github.com/repos/cloud-fan/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloud-fan/spark/downloads","issues_url":"https://api.github.com/repos/cloud-fan/spark/issues{/number}","pulls_url":"https://api.github.com/repos/cloud-fan/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/cloud-fan/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/cloud-fan/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloud-fan/spark/labels{/name}","releases_url":"https://api.github.com/repos/cloud-fan/spark/releases{/id}","deployments_url":"https://api.github.com/repos/cloud-fan/spark/deployments","created_at":"2014-05-12T07:32:26Z","updated_at":"2017-06-22T06:57:26Z","pushed_at":"2017-07-12T07:43:18Z","git_url":"git://github.com/cloud-fan/spark.git","ssh_url":"[email protected]:cloud-fan/spark.git","clone_url":"https://github.com/cloud-fan/spark.git","svn_url":"https://github.com/cloud-fan/spark","homepage":null,"size":250410,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7514db1deca22b44ce18e4c571275ce79addc100","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2017-07-12T06:35:12Z","pushed_at":"2017-07-12T07:43:24Z","git_url":"git://github.com/apache/spark.git","ssh_url":"[email protected]:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":256143,"stargazers_count":13479,"watchers_count":13479,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12718,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":386,"forks":12718,"open_issues":386,"watchers":13479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/18600"},"html":{"href":"https://github.com/apache/spark/pull/18600"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/18600"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/18600/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/18600/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/18600/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/2dc4ce1e439b4ad86c4ede14397e645d05a1555b"}}}} | {
"id": 17165658,
"name": "apache/spark",
"url": "https://api.github.com/repos/apache/spark"
} | {
"id": 3182036,
"login": "cloud-fan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3182036?",
"url": "https://api.github.com/users/cloud-fan"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-07-12T07:44:59 | 6238830464 | {"actor":{"display_login":"cloud-fan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments/117639019","pull_request_review_id":39362184,"id":117639019,"diff_hunk":"@@ -145,6 +145,9 @@ def set_state(task, execution_date, upstream=False, downstream=False,\n dr.state = state\n session.merge(dr)\n \n+ if drs and commit:","path":"airflow/api/common/experimental/mark_tasks.py","position":4,"original_position":4,"commit_id":"b7646d9b2fe586f5072f905856b85aba0f857f04","original_commit_id":"b7646d9b2fe586f5072f905856b85aba0f857f04","user":{"login":"bolkedebruin","id":4282712,"avatar_url":"https://avatars1.githubusercontent.com/u/4282712?v=3","gravatar_id":"","url":"https://api.github.com/users/bolkedebruin","html_url":"https://github.com/bolkedebruin","followers_url":"https://api.github.com/users/bolkedebruin/followers","following_url":"https://api.github.com/users/bolkedebruin/following{/other_user}","gists_url":"https://api.github.com/users/bolkedebruin/gists{/gist_id}","starred_url":"https://api.github.com/users/bolkedebruin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bolkedebruin/subscriptions","organizations_url":"https://api.github.com/users/bolkedebruin/orgs","repos_url":"https://api.github.com/users/bolkedebruin/repos","events_url":"https://api.github.com/users/bolkedebruin/events{/privacy}","received_events_url":"https://api.github.com/users/bolkedebruin/received_events","type":"User","site_admin":false},"body":"Why are you committing here? Commit happens below and makes sure it happens in one transaction.","created_at":"2017-05-21T18:24:29Z","updated_at":"2017-05-21T18:24:29Z","html_url":"https://github.com/apache/incubator-airflow/pull/2314#discussion_r117639019","pull_request_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/2314","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments/117639019"},"html":{"href":"https://github.com/apache/incubator-airflow/pull/2314#discussion_r117639019"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/2314"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/2314","id":121512744,"html_url":"https://github.com/apache/incubator-airflow/pull/2314","diff_url":"https://github.com/apache/incubator-airflow/pull/2314.diff","patch_url":"https://github.com/apache/incubator-airflow/pull/2314.patch","issue_url":"https://api.github.com/repos/apache/incubator-airflow/issues/2314","number":2314,"state":"open","locked":false,"title":"[AIRFLOW-1212] Enable api unit tests","user":{"login":"skudriashev","id":2817012,"avatar_url":"https://avatars2.githubusercontent.com/u/2817012?v=3","gravatar_id":"","url":"https://api.github.com/users/skudriashev","html_url":"https://github.com/skudriashev","followers_url":"https://api.github.com/users/skudriashev/followers","following_url":"https://api.github.com/users/skudriashev/following{/other_user}","gists_url":"https://api.github.com/users/skudriashev/gists{/gist_id}","starred_url":"https://api.github.com/users/skudriashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skudriashev/subscriptions","organizations_url":"https://api.github.com/users/skudriashev/orgs","repos_url":"https://api.github.com/users/skudriashev/repos","events_url":"https://api.github.com/users/skudriashev/events{/privacy}","received_events_url":"https://api.github.com/users/skudriashev/received_events","type":"User","site_admin":false},"body":"Dear Airflow maintainers,\r\n\r\nPlease accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!\r\n\r\n\r\n### JIRA\r\n- [x] My PR addresses the following\r\n - [AIRFLOW-1212](https://issues.apache.org/jira/browse/AIRFLOW-1212) Enable api unit tests\r\n\r\n\r\n### Description\r\n- [x] Enabled not running unit tests tests.api.*\r\n\r\n\r\n### Tests\r\n- [x] More unit tests enabled.\r\n\r\n\r\n### Commits\r\n- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from \"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)\":\r\n 1. Subject is separated from body by a blank line\r\n 2. Subject is limited to 50 characters\r\n 3. Subject does not end with a period\r\n 4. Subject uses the imperative mood (\"add\", not \"adding\")\r\n 5. Body wraps at 72 characters\r\n 6. Body explains \"what\" and \"why\", not \"how\"\r\n\r\n","created_at":"2017-05-19T14:27:14Z","updated_at":"2017-05-21T18:24:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c91dcfc398ba830e08baf64edde0586f673d3bd1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/2314/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/2314/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/issues/2314/comments","statuses_url":"https://api.github.com/repos/apache/incubator-airflow/statuses/b7646d9b2fe586f5072f905856b85aba0f857f04","head":{"label":"skudriashev:airflow-1212","ref":"airflow-1212","sha":"b7646d9b2fe586f5072f905856b85aba0f857f04","user":{"login":"skudriashev","id":2817012,"avatar_url":"https://avatars2.githubusercontent.com/u/2817012?v=3","gravatar_id":"","url":"https://api.github.com/users/skudriashev","html_url":"https://github.com/skudriashev","followers_url":"https://api.github.com/users/skudriashev/followers","following_url":"https://api.github.com/users/skudriashev/following{/other_user}","gists_url":"https://api.github.com/users/skudriashev/gists{/gist_id}","starred_url":"https://api.github.com/users/skudriashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skudriashev/subscriptions","organizations_url":"https://api.github.com/users/skudriashev/orgs","repos_url":"https://api.github.com/users/skudriashev/repos","events_url":"https://api.github.com/users/skudriashev/events{/privacy}","received_events_url":"https://api.github.com/users/skudriashev/received_events","type":"User","site_admin":false},"repo":{"id":60091973,"name":"incubator-airflow","full_name":"skudriashev/incubator-airflow","owner":{"login":"skudriashev","id":2817012,"avatar_url":"https://avatars2.githubusercontent.com/u/2817012?v=3","gravatar_id":"","url":"https://api.github.com/users/skudriashev","html_url":"https://github.com/skudriashev","followers_url":"https://api.github.com/users/skudriashev/followers","following_url":"https://api.github.com/users/skudriashev/following{/other_user}","gists_url":"https://api.github.com/users/skudriashev/gists{/gist_id}","starred_url":"https://api.github.com/users/skudriashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skudriashev/subscriptions","organizations_url":"https://api.github.com/users/skudriashev/orgs","repos_url":"https://api.github.com/users/skudriashev/repos","events_url":"https://api.github.com/users/skudriashev/events{/privacy}","received_events_url":"https://api.github.com/users/skudriashev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skudriashev/incubator-airflow","description":"Apache Airflow (Incubating)","fork":true,"url":"https://api.github.com/repos/skudriashev/incubator-airflow","forks_url":"https://api.github.com/repos/skudriashev/incubator-airflow/forks","keys_url":"https://api.github.com/repos/skudriashev/incubator-airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skudriashev/incubator-airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skudriashev/incubator-airflow/teams","hooks_url":"https://api.github.com/repos/skudriashev/incubator-airflow/hooks","issue_events_url":"https://api.github.com/repos/skudriashev/incubator-airflow/issues/events{/number}","events_url":"https://api.github.com/repos/skudriashev/incubator-airflow/events","assignees_url":"https://api.github.com/repos/skudriashev/incubator-airflow/assignees{/user}","branches_url":"https://api.github.com/repos/skudriashev/incubator-airflow/branches{/branch}","tags_url":"https://api.github.com/repos/skudriashev/incubator-airflow/tags","blobs_url":"https://api.github.com/repos/skudriashev/incubator-airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skudriashev/incubator-airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skudriashev/incubator-airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/skudriashev/incubator-airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skudriashev/incubator-airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/skudriashev/incubator-airflow/languages","stargazers_url":"https://api.github.com/repos/skudriashev/incubator-airflow/stargazers","contributors_url":"https://api.github.com/repos/skudriashev/incubator-airflow/contributors","subscribers_url":"https://api.github.com/repos/skudriashev/incubator-airflow/subscribers","subscription_url":"https://api.github.com/repos/skudriashev/incubator-airflow/subscription","commits_url":"https://api.github.com/repos/skudriashev/incubator-airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/skudriashev/incubator-airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/skudriashev/incubator-airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/skudriashev/incubator-airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/skudriashev/incubator-airflow/contents/{+path}","compare_url":"https://api.github.com/repos/skudriashev/incubator-airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skudriashev/incubator-airflow/merges","archive_url":"https://api.github.com/repos/skudriashev/incubator-airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skudriashev/incubator-airflow/downloads","issues_url":"https://api.github.com/repos/skudriashev/incubator-airflow/issues{/number}","pulls_url":"https://api.github.com/repos/skudriashev/incubator-airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/skudriashev/incubator-airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/skudriashev/incubator-airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skudriashev/incubator-airflow/labels{/name}","releases_url":"https://api.github.com/repos/skudriashev/incubator-airflow/releases{/id}","deployments_url":"https://api.github.com/repos/skudriashev/incubator-airflow/deployments","created_at":"2016-05-31T13:29:38Z","updated_at":"2017-05-15T09:29:12Z","pushed_at":"2017-05-21T11:21:06Z","git_url":"git://github.com/skudriashev/incubator-airflow.git","ssh_url":"[email protected]:skudriashev/incubator-airflow.git","clone_url":"https://github.com/skudriashev/incubator-airflow.git","svn_url":"https://github.com/skudriashev/incubator-airflow","homepage":"","size":12599,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"917adbdbadaa6bd30bc3ca5cd3bbc137db305f99","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":33884891,"name":"incubator-airflow","full_name":"apache/incubator-airflow","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-airflow","description":"Apache Airflow (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-airflow","forks_url":"https://api.github.com/repos/apache/incubator-airflow/forks","keys_url":"https://api.github.com/repos/apache/incubator-airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-airflow/teams","hooks_url":"https://api.github.com/repos/apache/incubator-airflow/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-airflow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-airflow/events","assignees_url":"https://api.github.com/repos/apache/incubator-airflow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-airflow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-airflow/tags","blobs_url":"https://api.github.com/repos/apache/incubator-airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-airflow/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-airflow/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-airflow/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-airflow/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-airflow/subscription","commits_url":"https://api.github.com/repos/apache/incubator-airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-airflow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-airflow/merges","archive_url":"https://api.github.com/repos/apache/incubator-airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-airflow/downloads","issues_url":"https://api.github.com/repos/apache/incubator-airflow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-airflow/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-airflow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-airflow/deployments","created_at":"2015-04-13T18:04:58Z","updated_at":"2017-05-21T14:04:00Z","pushed_at":"2017-05-21T18:22:05Z","git_url":"git://github.com/apache/incubator-airflow.git","ssh_url":"[email protected]:apache/incubator-airflow.git","clone_url":"https://github.com/apache/incubator-airflow.git","svn_url":"https://github.com/apache/incubator-airflow","homepage":"","size":12731,"stargazers_count":5165,"watchers_count":5165,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1382,"mirror_url":null,"open_issues_count":220,"forks":1382,"open_issues":220,"watchers":5165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/2314"},"html":{"href":"https://github.com/apache/incubator-airflow/pull/2314"},"issue":{"href":"https://api.github.com/repos/apache/incubator-airflow/issues/2314"},"comments":{"href":"https://api.github.com/repos/apache/incubator-airflow/issues/2314/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/2314/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/2314/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-airflow/statuses/b7646d9b2fe586f5072f905856b85aba0f857f04"}}}} | {
"id": 33884891,
"name": "apache/incubator-airflow",
"url": "https://api.github.com/repos/apache/incubator-airflow"
} | {
"id": 4282712,
"login": "bolkedebruin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4282712?",
"url": "https://api.github.com/users/bolkedebruin"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-05-21T18:24:29 | 5913429369 | {"actor":{"display_login":"bolkedebruin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/100593400","pull_request_review_id":21309595,"id":100593400,"diff_hunk":"@@ -624,6 +624,9 @@ class Analyzer(\n } catch {\n case _: NoSuchTableException =>\n u.failAnalysis(s\"Table or view not found: ${u.tableName}\")\n+ // If the database is not valid, also throw an AnalysisException.\n+ case _: NoSuchDatabaseException =>\n+ u.failAnalysis(s\"Table or view not found: ${u.tableName}\")","path":"sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala","position":6,"original_position":6,"commit_id":"664b53a86ceecf2e15808f01abde9ad88fd7c4fe","original_commit_id":"664b53a86ceecf2e15808f01abde9ad88fd7c4fe","user":{"login":"cloud-fan","id":3182036,"avatar_url":"https://avatars.githubusercontent.com/u/3182036?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"body":"shall we use the qualified name? or users are hard to find out that the database doesn't exist, given only the table name.","created_at":"2017-02-10T18:22:56Z","updated_at":"2017-02-10T18:22:56Z","html_url":"https://github.com/apache/spark/pull/16674#discussion_r100593400","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/16674","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/100593400"},"html":{"href":"https://github.com/apache/spark/pull/16674#discussion_r100593400"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/16674"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/16674","id":102618681,"html_url":"https://github.com/apache/spark/pull/16674","diff_url":"https://github.com/apache/spark/pull/16674.diff","patch_url":"https://github.com/apache/spark/pull/16674.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/16674","number":16674,"state":"open","locked":false,"title":"[SPARK-19331][SQL][TESTS] Improve the test coverage of SQLViewSuite","user":{"login":"jiangxb1987","id":4784782,"avatar_url":"https://avatars.githubusercontent.com/u/4784782?v=3","gravatar_id":"","url":"https://api.github.com/users/jiangxb1987","html_url":"https://github.com/jiangxb1987","followers_url":"https://api.github.com/users/jiangxb1987/followers","following_url":"https://api.github.com/users/jiangxb1987/following{/other_user}","gists_url":"https://api.github.com/users/jiangxb1987/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangxb1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangxb1987/subscriptions","organizations_url":"https://api.github.com/users/jiangxb1987/orgs","repos_url":"https://api.github.com/users/jiangxb1987/repos","events_url":"https://api.github.com/users/jiangxb1987/events{/privacy}","received_events_url":"https://api.github.com/users/jiangxb1987/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nMove `SQLViewSuite` from `sql/hive` to `sql/core`, so we can test the view supports without hive metastore. Also moved the test cases that specified to hive to `HiveSQLViewSuite`.\r\n\r\nImprove the test coverage of SQLViewSuite, cover the following cases:\r\n1. view resolution(possibly a referenced table/view have changed after the view creation);\r\n2. handle a view with user specified column names;\r\n3. improve the test cases for a nested view.\r\n\r\nAlso added a test case for cyclic view reference, which is a known issue that is not fixed yet.\r\n\r\n## How was this patch tested?\r\n\r\nN/A","created_at":"2017-01-22T12:13:08Z","updated_at":"2017-02-10T18:22:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec7d20249016819cf2250000694b44642c607f30","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/16674/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/16674/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/16674/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/664b53a86ceecf2e15808f01abde9ad88fd7c4fe","head":{"label":"jiangxb1987:view-test","ref":"view-test","sha":"664b53a86ceecf2e15808f01abde9ad88fd7c4fe","user":{"login":"jiangxb1987","id":4784782,"avatar_url":"https://avatars.githubusercontent.com/u/4784782?v=3","gravatar_id":"","url":"https://api.github.com/users/jiangxb1987","html_url":"https://github.com/jiangxb1987","followers_url":"https://api.github.com/users/jiangxb1987/followers","following_url":"https://api.github.com/users/jiangxb1987/following{/other_user}","gists_url":"https://api.github.com/users/jiangxb1987/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangxb1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangxb1987/subscriptions","organizations_url":"https://api.github.com/users/jiangxb1987/orgs","repos_url":"https://api.github.com/users/jiangxb1987/repos","events_url":"https://api.github.com/users/jiangxb1987/events{/privacy}","received_events_url":"https://api.github.com/users/jiangxb1987/received_events","type":"User","site_admin":false},"repo":{"id":35214686,"name":"spark","full_name":"jiangxb1987/spark","owner":{"login":"jiangxb1987","id":4784782,"avatar_url":"https://avatars.githubusercontent.com/u/4784782?v=3","gravatar_id":"","url":"https://api.github.com/users/jiangxb1987","html_url":"https://github.com/jiangxb1987","followers_url":"https://api.github.com/users/jiangxb1987/followers","following_url":"https://api.github.com/users/jiangxb1987/following{/other_user}","gists_url":"https://api.github.com/users/jiangxb1987/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangxb1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangxb1987/subscriptions","organizations_url":"https://api.github.com/users/jiangxb1987/orgs","repos_url":"https://api.github.com/users/jiangxb1987/repos","events_url":"https://api.github.com/users/jiangxb1987/events{/privacy}","received_events_url":"https://api.github.com/users/jiangxb1987/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jiangxb1987/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/jiangxb1987/spark","forks_url":"https://api.github.com/repos/jiangxb1987/spark/forks","keys_url":"https://api.github.com/repos/jiangxb1987/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jiangxb1987/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jiangxb1987/spark/teams","hooks_url":"https://api.github.com/repos/jiangxb1987/spark/hooks","issue_events_url":"https://api.github.com/repos/jiangxb1987/spark/issues/events{/number}","events_url":"https://api.github.com/repos/jiangxb1987/spark/events","assignees_url":"https://api.github.com/repos/jiangxb1987/spark/assignees{/user}","branches_url":"https://api.github.com/repos/jiangxb1987/spark/branches{/branch}","tags_url":"https://api.github.com/repos/jiangxb1987/spark/tags","blobs_url":"https://api.github.com/repos/jiangxb1987/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jiangxb1987/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jiangxb1987/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/jiangxb1987/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jiangxb1987/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/jiangxb1987/spark/languages","stargazers_url":"https://api.github.com/repos/jiangxb1987/spark/stargazers","contributors_url":"https://api.github.com/repos/jiangxb1987/spark/contributors","subscribers_url":"https://api.github.com/repos/jiangxb1987/spark/subscribers","subscription_url":"https://api.github.com/repos/jiangxb1987/spark/subscription","commits_url":"https://api.github.com/repos/jiangxb1987/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/jiangxb1987/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/jiangxb1987/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/jiangxb1987/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/jiangxb1987/spark/contents/{+path}","compare_url":"https://api.github.com/repos/jiangxb1987/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jiangxb1987/spark/merges","archive_url":"https://api.github.com/repos/jiangxb1987/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jiangxb1987/spark/downloads","issues_url":"https://api.github.com/repos/jiangxb1987/spark/issues{/number}","pulls_url":"https://api.github.com/repos/jiangxb1987/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/jiangxb1987/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/jiangxb1987/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jiangxb1987/spark/labels{/name}","releases_url":"https://api.github.com/repos/jiangxb1987/spark/releases{/id}","deployments_url":"https://api.github.com/repos/jiangxb1987/spark/deployments","created_at":"2015-05-07T10:48:35Z","updated_at":"2016-04-06T08:58:13Z","pushed_at":"2017-02-10T02:06:57Z","git_url":"git://github.com/jiangxb1987/spark.git","ssh_url":"[email protected]:jiangxb1987/spark.git","clone_url":"https://github.com/jiangxb1987/spark.git","svn_url":"https://github.com/jiangxb1987/spark","homepage":null,"size":249643,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d60dde26f98164ae146da1b5f409f4eb7c3621aa","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2017-02-10T13:31:02Z","pushed_at":"2017-02-10T17:30:05Z","git_url":"git://github.com/apache/spark.git","ssh_url":"[email protected]:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":262560,"stargazers_count":11635,"watchers_count":11635,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10909,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":480,"forks":10909,"open_issues":480,"watchers":11635,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/16674"},"html":{"href":"https://github.com/apache/spark/pull/16674"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/16674"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/16674/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/16674/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/16674/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/664b53a86ceecf2e15808f01abde9ad88fd7c4fe"}}}} | {
"id": 17165658,
"name": "apache/spark",
"url": "https://api.github.com/repos/apache/spark"
} | {
"id": 3182036,
"login": "cloud-fan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3182036?",
"url": "https://api.github.com/users/cloud-fan"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-02-10T18:22:56 | 5304438831 | {"actor":{"display_login":"cloud-fan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/156348973","pull_request_review_id":82809727,"id":156348973,"diff_hunk":"@@ -146,25 +147,18 @@ class CrossValidator @Since(\"1.2.0\") (@Since(\"1.4.0\") override val uid: String)\n val validationDataset = sparkSession.createDataFrame(validation, schema).cache()\n logDebug(s\"Train split $splitIndex with multiple sets of parameters.\")\n \n+ val completeFitCount = new AtomicInteger(0)","path":"mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala","position":12,"original_position":12,"commit_id":"2cc7c28f385009570536690d686f2843485942b2","original_commit_id":"2cc7c28f385009570536690d686f2843485942b2","user":{"login":"holdenk","id":59893,"avatar_url":"https://avatars1.githubusercontent.com/u/59893?v=4","gravatar_id":"","url":"https://api.github.com/users/holdenk","html_url":"https://github.com/holdenk","followers_url":"https://api.github.com/users/holdenk/followers","following_url":"https://api.github.com/users/holdenk/following{/other_user}","gists_url":"https://api.github.com/users/holdenk/gists{/gist_id}","starred_url":"https://api.github.com/users/holdenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holdenk/subscriptions","organizations_url":"https://api.github.com/users/holdenk/orgs","repos_url":"https://api.github.com/users/holdenk/repos","events_url":"https://api.github.com/users/holdenk/events{/privacy}","received_events_url":"https://api.github.com/users/holdenk/received_events","type":"User","site_admin":false},"body":"You can also turn a sequence of futures into a future then map on that single future and do the unpersist there.","created_at":"2017-12-12T12:13:15Z","updated_at":"2017-12-12T12:13:15Z","html_url":"https://github.com/apache/spark/pull/19904#discussion_r156348973","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/19904","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/156348973"},"html":{"href":"https://github.com/apache/spark/pull/19904#discussion_r156348973"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/19904"}},"in_reply_to_id":155710913},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/19904","id":156631161,"html_url":"https://github.com/apache/spark/pull/19904","diff_url":"https://github.com/apache/spark/pull/19904.diff","patch_url":"https://github.com/apache/spark/pull/19904.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/19904","number":19904,"state":"open","locked":false,"title":"[SPARK-22707][ML] Optimize CrossValidator memory occupation by models in fitting","user":{"login":"WeichenXu123","id":19235986,"avatar_url":"https://avatars0.githubusercontent.com/u/19235986?v=4","gravatar_id":"","url":"https://api.github.com/users/WeichenXu123","html_url":"https://github.com/WeichenXu123","followers_url":"https://api.github.com/users/WeichenXu123/followers","following_url":"https://api.github.com/users/WeichenXu123/following{/other_user}","gists_url":"https://api.github.com/users/WeichenXu123/gists{/gist_id}","starred_url":"https://api.github.com/users/WeichenXu123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WeichenXu123/subscriptions","organizations_url":"https://api.github.com/users/WeichenXu123/orgs","repos_url":"https://api.github.com/users/WeichenXu123/repos","events_url":"https://api.github.com/users/WeichenXu123/events{/privacy}","received_events_url":"https://api.github.com/users/WeichenXu123/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nVia some test I found CrossValidator still exists memory issue, it will still occupy `O(n*sizeof(model))` memory for holding models when fitting, if well optimized, it should be `O(parallelism*sizeof(model))`\r\n\r\nThis is because modelFutures will hold the reference to model object after future is complete (we can use `future.value.get.get` to fetch it), and the `Future.sequence` and the `modelFutures` array holds references to each model future. So all model object are keep referenced. So it will still occupy `O(n*sizeof(model))` memory.\r\n\r\nI fix this by merging the `modelFuture` and `foldMetricFuture` together, and use `atomicInteger` to statistic complete fitting tasks and when all done, trigger `trainingDataset.unpersist`.\r\n\r\nI ever commented this issue on the old PR [SPARK-19357]\r\nhttps://github.com/apache/spark/pull/16774#pullrequestreview-53674264\r\nunfortunately, at that time I do not realize that the issue still exists, but now I confirm it and create this PR to fix it.\r\n\r\n## How was this patch tested?\r\n\r\nN/A\r\n","created_at":"2017-12-06T03:17:26Z","updated_at":"2017-12-12T12:13:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb6358c8610b43fc6485863d1f2d49d2a0963d54","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/19904/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/19904/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/19904/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/2cc7c28f385009570536690d686f2843485942b2","head":{"label":"WeichenXu123:fix_cross_validator_memory_issue","ref":"fix_cross_validator_memory_issue","sha":"2cc7c28f385009570536690d686f2843485942b2","user":{"login":"WeichenXu123","id":19235986,"avatar_url":"https://avatars0.githubusercontent.com/u/19235986?v=4","gravatar_id":"","url":"https://api.github.com/users/WeichenXu123","html_url":"https://github.com/WeichenXu123","followers_url":"https://api.github.com/users/WeichenXu123/followers","following_url":"https://api.github.com/users/WeichenXu123/following{/other_user}","gists_url":"https://api.github.com/users/WeichenXu123/gists{/gist_id}","starred_url":"https://api.github.com/users/WeichenXu123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WeichenXu123/subscriptions","organizations_url":"https://api.github.com/users/WeichenXu123/orgs","repos_url":"https://api.github.com/users/WeichenXu123/repos","events_url":"https://api.github.com/users/WeichenXu123/events{/privacy}","received_events_url":"https://api.github.com/users/WeichenXu123/received_events","type":"User","site_admin":false},"repo":{"id":58255485,"name":"spark","full_name":"WeichenXu123/spark","owner":{"login":"WeichenXu123","id":19235986,"avatar_url":"https://avatars0.githubusercontent.com/u/19235986?v=4","gravatar_id":"","url":"https://api.github.com/users/WeichenXu123","html_url":"https://github.com/WeichenXu123","followers_url":"https://api.github.com/users/WeichenXu123/followers","following_url":"https://api.github.com/users/WeichenXu123/following{/other_user}","gists_url":"https://api.github.com/users/WeichenXu123/gists{/gist_id}","starred_url":"https://api.github.com/users/WeichenXu123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WeichenXu123/subscriptions","organizations_url":"https://api.github.com/users/WeichenXu123/orgs","repos_url":"https://api.github.com/users/WeichenXu123/repos","events_url":"https://api.github.com/users/WeichenXu123/events{/privacy}","received_events_url":"https://api.github.com/users/WeichenXu123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WeichenXu123/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/WeichenXu123/spark","forks_url":"https://api.github.com/repos/WeichenXu123/spark/forks","keys_url":"https://api.github.com/repos/WeichenXu123/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WeichenXu123/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WeichenXu123/spark/teams","hooks_url":"https://api.github.com/repos/WeichenXu123/spark/hooks","issue_events_url":"https://api.github.com/repos/WeichenXu123/spark/issues/events{/number}","events_url":"https://api.github.com/repos/WeichenXu123/spark/events","assignees_url":"https://api.github.com/repos/WeichenXu123/spark/assignees{/user}","branches_url":"https://api.github.com/repos/WeichenXu123/spark/branches{/branch}","tags_url":"https://api.github.com/repos/WeichenXu123/spark/tags","blobs_url":"https://api.github.com/repos/WeichenXu123/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WeichenXu123/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WeichenXu123/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/WeichenXu123/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WeichenXu123/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/WeichenXu123/spark/languages","stargazers_url":"https://api.github.com/repos/WeichenXu123/spark/stargazers","contributors_url":"https://api.github.com/repos/WeichenXu123/spark/contributors","subscribers_url":"https://api.github.com/repos/WeichenXu123/spark/subscribers","subscription_url":"https://api.github.com/repos/WeichenXu123/spark/subscription","commits_url":"https://api.github.com/repos/WeichenXu123/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/WeichenXu123/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/WeichenXu123/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/WeichenXu123/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/WeichenXu123/spark/contents/{+path}","compare_url":"https://api.github.com/repos/WeichenXu123/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WeichenXu123/spark/merges","archive_url":"https://api.github.com/repos/WeichenXu123/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WeichenXu123/spark/downloads","issues_url":"https://api.github.com/repos/WeichenXu123/spark/issues{/number}","pulls_url":"https://api.github.com/repos/WeichenXu123/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/WeichenXu123/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/WeichenXu123/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WeichenXu123/spark/labels{/name}","releases_url":"https://api.github.com/repos/WeichenXu123/spark/releases{/id}","deployments_url":"https://api.github.com/repos/WeichenXu123/spark/deployments","created_at":"2016-05-07T07:45:37Z","updated_at":"2016-05-07T07:45:59Z","pushed_at":"2017-12-09T02:04:04Z","git_url":"git://github.com/WeichenXu123/spark.git","ssh_url":"[email protected]:WeichenXu123/spark.git","clone_url":"https://github.com/WeichenXu123/spark.git","svn_url":"https://github.com/WeichenXu123/spark","homepage":null,"size":257946,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"0ba8f4b21167fe98a9f06036c4fc4ccd8e3287b4","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2017-12-12T10:41:11Z","pushed_at":"2017-12-12T11:45:01Z","git_url":"git://github.com/apache/spark.git","ssh_url":"[email protected]:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":265950,"stargazers_count":15438,"watchers_count":15438,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14323,"mirror_url":null,"archived":false,"open_issues_count":397,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":14323,"open_issues":397,"watchers":15438,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/19904"},"html":{"href":"https://github.com/apache/spark/pull/19904"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/19904"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/19904/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/19904/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/19904/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/2cc7c28f385009570536690d686f2843485942b2"}},"author_association":"CONTRIBUTOR"}} | {
"id": 17165658,
"name": "apache/spark",
"url": "https://api.github.com/repos/apache/spark"
} | {
"id": 59893,
"login": "holdenk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/59893?",
"url": "https://api.github.com/users/holdenk"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-12-12T12:13:15 | 6976738885 | {"actor":{"display_login":"holdenk"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/125250502","pull_request_review_id":47621119,"id":125250502,"diff_hunk":"@@ -1056,6 +1056,27 @@ class SessionCatalog(\n }\n \n /**\n+ * overwirte a metastore function in the database specified in `funcDefinition`..\n+ * If no database is specified, assume the function is in the current database.\n+ */\n+ def alterFunction(funcDefinition: CatalogFunction): Unit = {\n+ val db = formatDatabaseName(funcDefinition.identifier.database.getOrElse(getCurrentDatabase))\n+ requireDbExists(db)\n+ val identifier = FunctionIdentifier(funcDefinition.identifier.funcName, Some(db))\n+ val newFuncDefinition = funcDefinition.copy(identifier = identifier)\n+ if (functionExists(identifier)) {\n+ if (functionRegistry.functionExists(identifier)) {\n+ // If we have loaded this function into the FunctionRegistry,\n+ // also drop it from there.\n+ // For a permanent function, because we loaded it to the FunctionRegistry\n+ // when it's first used, we also need to drop it from the FunctionRegistry.\n+ functionRegistry.dropFunction(identifier)\n+ }\n+ externalCatalog.alterFunction(db, newFuncDefinition)\n+ }","path":"sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala","position":21,"original_position":21,"commit_id":"b49280aad51b1fbb44b992c03beb6c18325baa84","original_commit_id":"b49280aad51b1fbb44b992c03beb6c18325baa84","user":{"login":"ouyangxiaochen","id":22695134,"avatar_url":"https://avatars3.githubusercontent.com/u/22695134?v=3","gravatar_id":"","url":"https://api.github.com/users/ouyangxiaochen","html_url":"https://github.com/ouyangxiaochen","followers_url":"https://api.github.com/users/ouyangxiaochen/followers","following_url":"https://api.github.com/users/ouyangxiaochen/following{/other_user}","gists_url":"https://api.github.com/users/ouyangxiaochen/gists{/gist_id}","starred_url":"https://api.github.com/users/ouyangxiaochen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ouyangxiaochen/subscriptions","organizations_url":"https://api.github.com/users/ouyangxiaochen/orgs","repos_url":"https://api.github.com/users/ouyangxiaochen/repos","events_url":"https://api.github.com/users/ouyangxiaochen/events{/privacy}","received_events_url":"https://api.github.com/users/ouyangxiaochen/received_events","type":"User","site_admin":false},"body":"yes","created_at":"2017-07-03T09:50:56Z","updated_at":"2017-07-03T09:50:56Z","html_url":"https://github.com/apache/spark/pull/17681#discussion_r125250502","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/17681","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/125250502"},"html":{"href":"https://github.com/apache/spark/pull/17681#discussion_r125250502"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/17681"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/17681","id":116487812,"html_url":"https://github.com/apache/spark/pull/17681","diff_url":"https://github.com/apache/spark/pull/17681.diff","patch_url":"https://github.com/apache/spark/pull/17681.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/17681","number":17681,"state":"open","locked":false,"title":"[SPARK-20383][SQL] Supporting Create [temporary] Function with the keyword 'OR REPLACE' and 'IF NOT EXISTS' ","user":{"login":"ouyangxiaochen","id":22695134,"avatar_url":"https://avatars3.githubusercontent.com/u/22695134?v=3","gravatar_id":"","url":"https://api.github.com/users/ouyangxiaochen","html_url":"https://github.com/ouyangxiaochen","followers_url":"https://api.github.com/users/ouyangxiaochen/followers","following_url":"https://api.github.com/users/ouyangxiaochen/following{/other_user}","gists_url":"https://api.github.com/users/ouyangxiaochen/gists{/gist_id}","starred_url":"https://api.github.com/users/ouyangxiaochen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ouyangxiaochen/subscriptions","organizations_url":"https://api.github.com/users/ouyangxiaochen/orgs","repos_url":"https://api.github.com/users/ouyangxiaochen/repos","events_url":"https://api.github.com/users/ouyangxiaochen/events{/privacy}","received_events_url":"https://api.github.com/users/ouyangxiaochen/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nsupport to create [temporary] function with the keyword 'OR REPLACE' and 'IF NOT EXISTS'\r\n\r\n## How was this patch tested?\r\nmanual test and added test cases\r\n\r\nPlease review http://spark.apache.org/contributing.html before opening a pull request.\r\n","created_at":"2017-04-19T07:49:27Z","updated_at":"2017-07-03T09:50:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db70fe78d9766957951d6e3e835242865c4bed33","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/17681/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/17681/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/17681/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/b49280aad51b1fbb44b992c03beb6c18325baa84","head":{"label":"ouyangxiaochen:spark-419","ref":"spark-419","sha":"b49280aad51b1fbb44b992c03beb6c18325baa84","user":{"login":"ouyangxiaochen","id":22695134,"avatar_url":"https://avatars3.githubusercontent.com/u/22695134?v=3","gravatar_id":"","url":"https://api.github.com/users/ouyangxiaochen","html_url":"https://github.com/ouyangxiaochen","followers_url":"https://api.github.com/users/ouyangxiaochen/followers","following_url":"https://api.github.com/users/ouyangxiaochen/following{/other_user}","gists_url":"https://api.github.com/users/ouyangxiaochen/gists{/gist_id}","starred_url":"https://api.github.com/users/ouyangxiaochen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ouyangxiaochen/subscriptions","organizations_url":"https://api.github.com/users/ouyangxiaochen/orgs","repos_url":"https://api.github.com/users/ouyangxiaochen/repos","events_url":"https://api.github.com/users/ouyangxiaochen/events{/privacy}","received_events_url":"https://api.github.com/users/ouyangxiaochen/received_events","type":"User","site_admin":false},"repo":{"id":81409453,"name":"spark","full_name":"ouyangxiaochen/spark","owner":{"login":"ouyangxiaochen","id":22695134,"avatar_url":"https://avatars3.githubusercontent.com/u/22695134?v=3","gravatar_id":"","url":"https://api.github.com/users/ouyangxiaochen","html_url":"https://github.com/ouyangxiaochen","followers_url":"https://api.github.com/users/ouyangxiaochen/followers","following_url":"https://api.github.com/users/ouyangxiaochen/following{/other_user}","gists_url":"https://api.github.com/users/ouyangxiaochen/gists{/gist_id}","starred_url":"https://api.github.com/users/ouyangxiaochen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ouyangxiaochen/subscriptions","organizations_url":"https://api.github.com/users/ouyangxiaochen/orgs","repos_url":"https://api.github.com/users/ouyangxiaochen/repos","events_url":"https://api.github.com/users/ouyangxiaochen/events{/privacy}","received_events_url":"https://api.github.com/users/ouyangxiaochen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ouyangxiaochen/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/ouyangxiaochen/spark","forks_url":"https://api.github.com/repos/ouyangxiaochen/spark/forks","keys_url":"https://api.github.com/repos/ouyangxiaochen/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ouyangxiaochen/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ouyangxiaochen/spark/teams","hooks_url":"https://api.github.com/repos/ouyangxiaochen/spark/hooks","issue_events_url":"https://api.github.com/repos/ouyangxiaochen/spark/issues/events{/number}","events_url":"https://api.github.com/repos/ouyangxiaochen/spark/events","assignees_url":"https://api.github.com/repos/ouyangxiaochen/spark/assignees{/user}","branches_url":"https://api.github.com/repos/ouyangxiaochen/spark/branches{/branch}","tags_url":"https://api.github.com/repos/ouyangxiaochen/spark/tags","blobs_url":"https://api.github.com/repos/ouyangxiaochen/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ouyangxiaochen/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ouyangxiaochen/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/ouyangxiaochen/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ouyangxiaochen/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/ouyangxiaochen/spark/languages","stargazers_url":"https://api.github.com/repos/ouyangxiaochen/spark/stargazers","contributors_url":"https://api.github.com/repos/ouyangxiaochen/spark/contributors","subscribers_url":"https://api.github.com/repos/ouyangxiaochen/spark/subscribers","subscription_url":"https://api.github.com/repos/ouyangxiaochen/spark/subscription","commits_url":"https://api.github.com/repos/ouyangxiaochen/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/ouyangxiaochen/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/ouyangxiaochen/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/ouyangxiaochen/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/ouyangxiaochen/spark/contents/{+path}","compare_url":"https://api.github.com/repos/ouyangxiaochen/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ouyangxiaochen/spark/merges","archive_url":"https://api.github.com/repos/ouyangxiaochen/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ouyangxiaochen/spark/downloads","issues_url":"https://api.github.com/repos/ouyangxiaochen/spark/issues{/number}","pulls_url":"https://api.github.com/repos/ouyangxiaochen/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/ouyangxiaochen/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/ouyangxiaochen/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ouyangxiaochen/spark/labels{/name}","releases_url":"https://api.github.com/repos/ouyangxiaochen/spark/releases{/id}","deployments_url":"https://api.github.com/repos/ouyangxiaochen/spark/deployments","created_at":"2017-02-09T04:35:33Z","updated_at":"2017-02-09T04:35:57Z","pushed_at":"2017-06-28T10:00:47Z","git_url":"git://github.com/ouyangxiaochen/spark.git","ssh_url":"[email protected]:ouyangxiaochen/spark.git","clone_url":"https://github.com/ouyangxiaochen/spark.git","svn_url":"https://github.com/ouyangxiaochen/spark","homepage":null,"size":275434,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8b5b2e272f48f7ddf8aeece0205cb4a5853c364e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2017-07-03T09:25:50Z","pushed_at":"2017-07-03T09:50:16Z","git_url":"git://github.com/apache/spark.git","ssh_url":"[email protected]:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":254805,"stargazers_count":13361,"watchers_count":13361,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12626,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":405,"forks":12626,"open_issues":405,"watchers":13361,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/17681"},"html":{"href":"https://github.com/apache/spark/pull/17681"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/17681"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/17681/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/17681/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/17681/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/b49280aad51b1fbb44b992c03beb6c18325baa84"}}}} | {
"id": 17165658,
"name": "apache/spark",
"url": "https://api.github.com/repos/apache/spark"
} | {
"id": 22695134,
"login": "ouyangxiaochen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22695134?",
"url": "https://api.github.com/users/ouyangxiaochen"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-07-03T09:50:56 | 6181688354 | {"actor":{"display_login":"ouyangxiaochen"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/119493540","pull_request_review_id":41378809,"id":119493540,"diff_hunk":"@@ -86,8 +86,8 @@ public WriteResult expand(PCollection<KV<TableDestination, TableRow>> input) {\n // different unique ids, this implementation relies on \"checkpointing\", which is\n // achieved as a side effect of having StreamingWriteFn immediately follow a GBK,\n // performed by Reshuffle.\n- TupleTag<Void> mainOutput = new TupleTag<Void>() {};\n- TupleTag<TableRow> failedOutput = new TupleTag<TableRow>() {};\n+ TupleTag<Void> mainOutput = new TupleTag<Void>(\"mainOutput\") {};","path":"sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StreamingWriteTables.java","position":null,"original_position":6,"commit_id":"15faa8e6e02f67b76b8694ccda4fd27049e15f67","original_commit_id":"15faa8e6e02f67b76b8694ccda4fd27049e15f67","user":{"login":"jkff","id":343722,"avatar_url":"https://avatars1.githubusercontent.com/u/343722?v=3","gravatar_id":"","url":"https://api.github.com/users/jkff","html_url":"https://github.com/jkff","followers_url":"https://api.github.com/users/jkff/followers","following_url":"https://api.github.com/users/jkff/following{/other_user}","gists_url":"https://api.github.com/users/jkff/gists{/gist_id}","starred_url":"https://api.github.com/users/jkff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkff/subscriptions","organizations_url":"https://api.github.com/users/jkff/orgs","repos_url":"https://api.github.com/users/jkff/repos","events_url":"https://api.github.com/users/jkff/events{/privacy}","received_events_url":"https://api.github.com/users/jkff/received_events","type":"User","site_admin":false},"body":"These are still anonymous classes - please remove `{}`.","created_at":"2017-05-31T22:52:05Z","updated_at":"2017-05-31T22:58:25Z","html_url":"https://github.com/apache/beam/pull/1609#discussion_r119493540","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/1609","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/119493540"},"html":{"href":"https://github.com/apache/beam/pull/1609#discussion_r119493540"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/1609"}}},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/1609","id":97869452,"html_url":"https://github.com/apache/beam/pull/1609","diff_url":"https://github.com/apache/beam/pull/1609.diff","patch_url":"https://github.com/apache/beam/pull/1609.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/1609","number":1609,"state":"open","locked":false,"title":"BEAM-1151 Add failure handling to BigQueryIO.Write","user":{"login":"reuvenlax","id":21071061,"avatar_url":"https://avatars2.githubusercontent.com/u/21071061?v=3","gravatar_id":"","url":"https://api.github.com/users/reuvenlax","html_url":"https://github.com/reuvenlax","followers_url":"https://api.github.com/users/reuvenlax/followers","following_url":"https://api.github.com/users/reuvenlax/following{/other_user}","gists_url":"https://api.github.com/users/reuvenlax/gists{/gist_id}","starred_url":"https://api.github.com/users/reuvenlax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reuvenlax/subscriptions","organizations_url":"https://api.github.com/users/reuvenlax/orgs","repos_url":"https://api.github.com/users/reuvenlax/repos","events_url":"https://api.github.com/users/reuvenlax/events{/privacy}","received_events_url":"https://api.github.com/users/reuvenlax/received_events","type":"User","site_admin":false},"body":"Allow a pipeline to handle streaming insert failures when using BigQueryIO.Write in streaming mode. TableRow objects that fail to insert are returned to the user as a PCollection.\r\n\r\nR: @jkff ","created_at":"2016-12-14T01:12:03Z","updated_at":"2017-05-31T22:58:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d8ad31dbc2ed01a9ebf9bffaf4b0c4c15543dd7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/1609/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/1609/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/1609/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/15faa8e6e02f67b76b8694ccda4fd27049e15f67","head":{"label":"reuvenlax:bq_dead_letter","ref":"bq_dead_letter","sha":"15faa8e6e02f67b76b8694ccda4fd27049e15f67","user":{"login":"reuvenlax","id":21071061,"avatar_url":"https://avatars2.githubusercontent.com/u/21071061?v=3","gravatar_id":"","url":"https://api.github.com/users/reuvenlax","html_url":"https://github.com/reuvenlax","followers_url":"https://api.github.com/users/reuvenlax/followers","following_url":"https://api.github.com/users/reuvenlax/following{/other_user}","gists_url":"https://api.github.com/users/reuvenlax/gists{/gist_id}","starred_url":"https://api.github.com/users/reuvenlax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reuvenlax/subscriptions","organizations_url":"https://api.github.com/users/reuvenlax/orgs","repos_url":"https://api.github.com/users/reuvenlax/repos","events_url":"https://api.github.com/users/reuvenlax/events{/privacy}","received_events_url":"https://api.github.com/users/reuvenlax/received_events","type":"User","site_admin":false},"repo":{"id":72963016,"name":"incubator-beam","full_name":"reuvenlax/incubator-beam","owner":{"login":"reuvenlax","id":21071061,"avatar_url":"https://avatars2.githubusercontent.com/u/21071061?v=3","gravatar_id":"","url":"https://api.github.com/users/reuvenlax","html_url":"https://github.com/reuvenlax","followers_url":"https://api.github.com/users/reuvenlax/followers","following_url":"https://api.github.com/users/reuvenlax/following{/other_user}","gists_url":"https://api.github.com/users/reuvenlax/gists{/gist_id}","starred_url":"https://api.github.com/users/reuvenlax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reuvenlax/subscriptions","organizations_url":"https://api.github.com/users/reuvenlax/orgs","repos_url":"https://api.github.com/users/reuvenlax/repos","events_url":"https://api.github.com/users/reuvenlax/events{/privacy}","received_events_url":"https://api.github.com/users/reuvenlax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reuvenlax/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/reuvenlax/incubator-beam","forks_url":"https://api.github.com/repos/reuvenlax/incubator-beam/forks","keys_url":"https://api.github.com/repos/reuvenlax/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reuvenlax/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reuvenlax/incubator-beam/teams","hooks_url":"https://api.github.com/repos/reuvenlax/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/reuvenlax/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/reuvenlax/incubator-beam/events","assignees_url":"https://api.github.com/repos/reuvenlax/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/reuvenlax/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/reuvenlax/incubator-beam/tags","blobs_url":"https://api.github.com/repos/reuvenlax/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reuvenlax/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reuvenlax/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/reuvenlax/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reuvenlax/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/reuvenlax/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/reuvenlax/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/reuvenlax/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/reuvenlax/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/reuvenlax/incubator-beam/subscription","commits_url":"https://api.github.com/repos/reuvenlax/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/reuvenlax/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/reuvenlax/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/reuvenlax/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/reuvenlax/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/reuvenlax/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reuvenlax/incubator-beam/merges","archive_url":"https://api.github.com/repos/reuvenlax/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reuvenlax/incubator-beam/downloads","issues_url":"https://api.github.com/repos/reuvenlax/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/reuvenlax/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/reuvenlax/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/reuvenlax/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reuvenlax/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/reuvenlax/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/reuvenlax/incubator-beam/deployments","created_at":"2016-11-06T01:16:14Z","updated_at":"2016-11-06T01:16:20Z","pushed_at":"2017-05-31T22:36:27Z","git_url":"git://github.com/reuvenlax/incubator-beam.git","ssh_url":"[email protected]:reuvenlax/incubator-beam.git","clone_url":"https://github.com/reuvenlax/incubator-beam.git","svn_url":"https://github.com/reuvenlax/incubator-beam","homepage":null,"size":37790,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d6cc850a93eaec6103b5fc95d4c02653e945f2b4","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"beam","full_name":"apache/beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/beam","description":"Mirror of Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2017-05-31T09:36:05Z","pushed_at":"2017-05-31T22:57:41Z","git_url":"git://github.com/apache/beam.git","ssh_url":"[email protected]:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"","size":38359,"stargazers_count":1183,"watchers_count":1183,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":660,"mirror_url":"git://git.apache.org/beam.git","open_issues_count":72,"forks":660,"open_issues":72,"watchers":1183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/1609"},"html":{"href":"https://github.com/apache/beam/pull/1609"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/1609"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/1609/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/1609/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/1609/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/15faa8e6e02f67b76b8694ccda4fd27049e15f67"}}}} | {
"id": 50904245,
"name": "apache/beam",
"url": "https://api.github.com/repos/apache/beam"
} | {
"id": 343722,
"login": "jkff",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/343722?",
"url": "https://api.github.com/users/jkff"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-05-31T22:52:05 | 5978934421 | {"actor":{"display_login":"jkff"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/eagle/pulls/comments/119933968","pull_request_review_id":41863124,"id":119933968,"diff_hunk":"@@ -25,7 +25,7 @@\n import org.apache.velocity.runtime.resource.loader.ClasspathResourceLoader;\r\n import org.slf4j.Logger;\r\n import org.slf4j.LoggerFactory;\r\n-\r","path":"eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java","position":4,"original_position":4,"commit_id":"6caa21d79f169763b08fadc3f89ece6bb5809112","original_commit_id":"6caa21d79f169763b08fadc3f89ece6bb5809112","user":{"login":"jhsenjaliya","id":5017402,"avatar_url":"https://avatars3.githubusercontent.com/u/5017402?v=3","gravatar_id":"","url":"https://api.github.com/users/jhsenjaliya","html_url":"https://github.com/jhsenjaliya","followers_url":"https://api.github.com/users/jhsenjaliya/followers","following_url":"https://api.github.com/users/jhsenjaliya/following{/other_user}","gists_url":"https://api.github.com/users/jhsenjaliya/gists{/gist_id}","starred_url":"https://api.github.com/users/jhsenjaliya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhsenjaliya/subscriptions","organizations_url":"https://api.github.com/users/jhsenjaliya/orgs","repos_url":"https://api.github.com/users/jhsenjaliya/repos","events_url":"https://api.github.com/users/jhsenjaliya/events{/privacy}","received_events_url":"https://api.github.com/users/jhsenjaliya/received_events","type":"User","site_admin":false},"body":"remove this line","created_at":"2017-06-02T19:23:32Z","updated_at":"2017-06-02T19:23:32Z","html_url":"https://github.com/apache/eagle/pull/941#discussion_r119933968","pull_request_url":"https://api.github.com/repos/apache/eagle/pulls/941","_links":{"self":{"href":"https://api.github.com/repos/apache/eagle/pulls/comments/119933968"},"html":{"href":"https://github.com/apache/eagle/pull/941#discussion_r119933968"},"pull_request":{"href":"https://api.github.com/repos/apache/eagle/pulls/941"}}},"pull_request":{"url":"https://api.github.com/repos/apache/eagle/pulls/941","id":123222244,"html_url":"https://github.com/apache/eagle/pull/941","diff_url":"https://github.com/apache/eagle/pull/941.diff","patch_url":"https://github.com/apache/eagle/pull/941.patch","issue_url":"https://api.github.com/repos/apache/eagle/issues/941","number":941,"state":"open","locked":false,"title":"[EAGLE-968] Fix for email issue in 0.5 eagle version","user":{"login":"rushikesavareddy","id":29090091,"avatar_url":"https://avatars2.githubusercontent.com/u/29090091?v=3","gravatar_id":"","url":"https://api.github.com/users/rushikesavareddy","html_url":"https://github.com/rushikesavareddy","followers_url":"https://api.github.com/users/rushikesavareddy/followers","following_url":"https://api.github.com/users/rushikesavareddy/following{/other_user}","gists_url":"https://api.github.com/users/rushikesavareddy/gists{/gist_id}","starred_url":"https://api.github.com/users/rushikesavareddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushikesavareddy/subscriptions","organizations_url":"https://api.github.com/users/rushikesavareddy/orgs","repos_url":"https://api.github.com/users/rushikesavareddy/repos","events_url":"https://api.github.com/users/rushikesavareddy/events{/privacy}","received_events_url":"https://api.github.com/users/rushikesavareddy/received_events","type":"User","site_admin":false},"body":"<!--\r\n{% comment %}\r\nLicensed to the Apache Software Foundation (ASF) under one or more\r\ncontributor license agreements. See the NOTICE file distributed with\r\nthis work for additional information regarding copyright ownership.\r\nThe ASF licenses this file to you under the Apache License, Version 2.0\r\n(the \"License\"); you may not use this file except in compliance with\r\nthe License. You may obtain a copy of the License at\r\n\r\nhttp://www.apache.org/licenses/LICENSE-2.0\r\n\r\nUnless required by applicable law or agreed to in writing, software\r\ndistributed under the License is distributed on an \"AS IS\" BASIS,\r\nWITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\r\nSee the License for the specific language governing permissions and\r\nlimitations under the License.\r\n{% endcomment %}\r\n-->\r\n\r\nBe sure to do all of the following to help us incorporate your contribution\r\nquickly and easily:\r\n\r\n - [ ] Make sure the PR title is formatted like:\r\n `[EAGLE-<Jira issue #>] Description of pull request`\r\n - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable\r\n Travis-CI on your fork and ensure the whole test matrix passes).\r\n - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue\r\n number, if there is one.\r\n - [ ] If this contribution is large, please file an Apache\r\n [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).\r\n\r\n---","created_at":"2017-05-31T08:46:34Z","updated_at":"2017-06-02T19:23:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aed9fabd0227f28fc53399a31fcc2b6606aae063","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/eagle/pulls/941/commits","review_comments_url":"https://api.github.com/repos/apache/eagle/pulls/941/comments","review_comment_url":"https://api.github.com/repos/apache/eagle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/eagle/issues/941/comments","statuses_url":"https://api.github.com/repos/apache/eagle/statuses/6caa21d79f169763b08fadc3f89ece6bb5809112","head":{"label":"rushikesavareddy:branch-0.5","ref":"branch-0.5","sha":"6caa21d79f169763b08fadc3f89ece6bb5809112","user":{"login":"rushikesavareddy","id":29090091,"avatar_url":"https://avatars2.githubusercontent.com/u/29090091?v=3","gravatar_id":"","url":"https://api.github.com/users/rushikesavareddy","html_url":"https://github.com/rushikesavareddy","followers_url":"https://api.github.com/users/rushikesavareddy/followers","following_url":"https://api.github.com/users/rushikesavareddy/following{/other_user}","gists_url":"https://api.github.com/users/rushikesavareddy/gists{/gist_id}","starred_url":"https://api.github.com/users/rushikesavareddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushikesavareddy/subscriptions","organizations_url":"https://api.github.com/users/rushikesavareddy/orgs","repos_url":"https://api.github.com/users/rushikesavareddy/repos","events_url":"https://api.github.com/users/rushikesavareddy/events{/privacy}","received_events_url":"https://api.github.com/users/rushikesavareddy/received_events","type":"User","site_admin":false},"repo":{"id":92924063,"name":"eagle","full_name":"rushikesavareddy/eagle","owner":{"login":"rushikesavareddy","id":29090091,"avatar_url":"https://avatars2.githubusercontent.com/u/29090091?v=3","gravatar_id":"","url":"https://api.github.com/users/rushikesavareddy","html_url":"https://github.com/rushikesavareddy","followers_url":"https://api.github.com/users/rushikesavareddy/followers","following_url":"https://api.github.com/users/rushikesavareddy/following{/other_user}","gists_url":"https://api.github.com/users/rushikesavareddy/gists{/gist_id}","starred_url":"https://api.github.com/users/rushikesavareddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushikesavareddy/subscriptions","organizations_url":"https://api.github.com/users/rushikesavareddy/orgs","repos_url":"https://api.github.com/users/rushikesavareddy/repos","events_url":"https://api.github.com/users/rushikesavareddy/events{/privacy}","received_events_url":"https://api.github.com/users/rushikesavareddy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rushikesavareddy/eagle","description":"Mirror of Apache Eagle","fork":true,"url":"https://api.github.com/repos/rushikesavareddy/eagle","forks_url":"https://api.github.com/repos/rushikesavareddy/eagle/forks","keys_url":"https://api.github.com/repos/rushikesavareddy/eagle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rushikesavareddy/eagle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rushikesavareddy/eagle/teams","hooks_url":"https://api.github.com/repos/rushikesavareddy/eagle/hooks","issue_events_url":"https://api.github.com/repos/rushikesavareddy/eagle/issues/events{/number}","events_url":"https://api.github.com/repos/rushikesavareddy/eagle/events","assignees_url":"https://api.github.com/repos/rushikesavareddy/eagle/assignees{/user}","branches_url":"https://api.github.com/repos/rushikesavareddy/eagle/branches{/branch}","tags_url":"https://api.github.com/repos/rushikesavareddy/eagle/tags","blobs_url":"https://api.github.com/repos/rushikesavareddy/eagle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rushikesavareddy/eagle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rushikesavareddy/eagle/git/refs{/sha}","trees_url":"https://api.github.com/repos/rushikesavareddy/eagle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rushikesavareddy/eagle/statuses/{sha}","languages_url":"https://api.github.com/repos/rushikesavareddy/eagle/languages","stargazers_url":"https://api.github.com/repos/rushikesavareddy/eagle/stargazers","contributors_url":"https://api.github.com/repos/rushikesavareddy/eagle/contributors","subscribers_url":"https://api.github.com/repos/rushikesavareddy/eagle/subscribers","subscription_url":"https://api.github.com/repos/rushikesavareddy/eagle/subscription","commits_url":"https://api.github.com/repos/rushikesavareddy/eagle/commits{/sha}","git_commits_url":"https://api.github.com/repos/rushikesavareddy/eagle/git/commits{/sha}","comments_url":"https://api.github.com/repos/rushikesavareddy/eagle/comments{/number}","issue_comment_url":"https://api.github.com/repos/rushikesavareddy/eagle/issues/comments{/number}","contents_url":"https://api.github.com/repos/rushikesavareddy/eagle/contents/{+path}","compare_url":"https://api.github.com/repos/rushikesavareddy/eagle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rushikesavareddy/eagle/merges","archive_url":"https://api.github.com/repos/rushikesavareddy/eagle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rushikesavareddy/eagle/downloads","issues_url":"https://api.github.com/repos/rushikesavareddy/eagle/issues{/number}","pulls_url":"https://api.github.com/repos/rushikesavareddy/eagle/pulls{/number}","milestones_url":"https://api.github.com/repos/rushikesavareddy/eagle/milestones{/number}","notifications_url":"https://api.github.com/repos/rushikesavareddy/eagle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rushikesavareddy/eagle/labels{/name}","releases_url":"https://api.github.com/repos/rushikesavareddy/eagle/releases{/id}","deployments_url":"https://api.github.com/repos/rushikesavareddy/eagle/deployments","created_at":"2017-05-31T08:36:37Z","updated_at":"2017-05-31T08:36:44Z","pushed_at":"2017-06-02T05:29:11Z","git_url":"git://github.com/rushikesavareddy/eagle.git","ssh_url":"[email protected]:rushikesavareddy/eagle.git","clone_url":"https://github.com/rushikesavareddy/eagle.git","svn_url":"https://github.com/rushikesavareddy/eagle","homepage":"","size":34226,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:branch-0.5","ref":"branch-0.5","sha":"d6d859fbdbd8d3d86cd4595303a9101d0ae0dddd","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":46404009,"name":"eagle","full_name":"apache/eagle","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/eagle","description":"Mirror of Apache Eagle","fork":false,"url":"https://api.github.com/repos/apache/eagle","forks_url":"https://api.github.com/repos/apache/eagle/forks","keys_url":"https://api.github.com/repos/apache/eagle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/eagle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/eagle/teams","hooks_url":"https://api.github.com/repos/apache/eagle/hooks","issue_events_url":"https://api.github.com/repos/apache/eagle/issues/events{/number}","events_url":"https://api.github.com/repos/apache/eagle/events","assignees_url":"https://api.github.com/repos/apache/eagle/assignees{/user}","branches_url":"https://api.github.com/repos/apache/eagle/branches{/branch}","tags_url":"https://api.github.com/repos/apache/eagle/tags","blobs_url":"https://api.github.com/repos/apache/eagle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/eagle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/eagle/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/eagle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/eagle/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/eagle/languages","stargazers_url":"https://api.github.com/repos/apache/eagle/stargazers","contributors_url":"https://api.github.com/repos/apache/eagle/contributors","subscribers_url":"https://api.github.com/repos/apache/eagle/subscribers","subscription_url":"https://api.github.com/repos/apache/eagle/subscription","commits_url":"https://api.github.com/repos/apache/eagle/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/eagle/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/eagle/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/eagle/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/eagle/contents/{+path}","compare_url":"https://api.github.com/repos/apache/eagle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/eagle/merges","archive_url":"https://api.github.com/repos/apache/eagle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/eagle/downloads","issues_url":"https://api.github.com/repos/apache/eagle/issues{/number}","pulls_url":"https://api.github.com/repos/apache/eagle/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/eagle/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/eagle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/eagle/labels{/name}","releases_url":"https://api.github.com/repos/apache/eagle/releases{/id}","deployments_url":"https://api.github.com/repos/apache/eagle/deployments","created_at":"2015-11-18T08:00:06Z","updated_at":"2017-05-24T07:06:18Z","pushed_at":"2017-06-02T05:29:12Z","git_url":"git://github.com/apache/eagle.git","ssh_url":"[email protected]:apache/eagle.git","clone_url":"https://github.com/apache/eagle.git","svn_url":"https://github.com/apache/eagle","homepage":"","size":34216,"stargazers_count":230,"watchers_count":230,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":125,"mirror_url":"git://git.apache.org/eagle.git","open_issues_count":13,"forks":125,"open_issues":13,"watchers":230,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/eagle/pulls/941"},"html":{"href":"https://github.com/apache/eagle/pull/941"},"issue":{"href":"https://api.github.com/repos/apache/eagle/issues/941"},"comments":{"href":"https://api.github.com/repos/apache/eagle/issues/941/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/eagle/pulls/941/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/eagle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/eagle/pulls/941/commits"},"statuses":{"href":"https://api.github.com/repos/apache/eagle/statuses/6caa21d79f169763b08fadc3f89ece6bb5809112"}}}} | {
"id": 46404009,
"name": "apache/eagle",
"url": "https://api.github.com/repos/apache/eagle"
} | {
"id": 5017402,
"login": "jhsenjaliya",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5017402?",
"url": "https://api.github.com/users/jhsenjaliya"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-06-02T19:23:32 | 5993628527 | {"actor":{"display_login":"jhsenjaliya"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/96145383","pull_request_review_id":16721272,"id":96145383,"diff_hunk":"@@ -758,15 +758,17 @@ class DDLSuite extends QueryTest with SharedSQLContext with BeforeAndAfterEach {\n testUnsetProperties(isDatasourceTable = true)\n }\n \n- test(\"alter table: set serde\") {\n+ // TODO: move this test to HiveDDLSuite.scala\n+ ignore(\"alter table: set serde\") {\n testSetSerde(isDatasourceTable = false)\n }\n \n test(\"alter table: set serde (datasource table)\") {\n testSetSerde(isDatasourceTable = true)\n }\n \n- test(\"alter table: set serde partition\") {\n+ // TODO: move this test to HiveDDLSuite.scala\n+ ignore(\"alter table: set serde partition\") {","path":"sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala","position":25,"original_position":25,"commit_id":"0d2d9f282cd1895c113f594c771721e1de53ce73","original_commit_id":"0d2d9f282cd1895c113f594c771721e1de53ce73","user":{"login":"gatorsmile","id":11567269,"avatar_url":"https://avatars.githubusercontent.com/u/11567269?v=3","gravatar_id":"","url":"https://api.github.com/users/gatorsmile","html_url":"https://github.com/gatorsmile","followers_url":"https://api.github.com/users/gatorsmile/followers","following_url":"https://api.github.com/users/gatorsmile/following{/other_user}","gists_url":"https://api.github.com/users/gatorsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/gatorsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatorsmile/subscriptions","organizations_url":"https://api.github.com/users/gatorsmile/orgs","repos_url":"https://api.github.com/users/gatorsmile/repos","events_url":"https://api.github.com/users/gatorsmile/events{/privacy}","received_events_url":"https://api.github.com/users/gatorsmile/received_events","type":"User","site_admin":false},"body":"These two test cases should be moved to HiveDDLSuite. However, it is ugly to copy the codes. Thus, my next plan is to improve the DDLSuite and HiveDDLSuite by creating an abstract class.","created_at":"2017-01-15T19:19:13Z","updated_at":"2017-01-15T19:19:13Z","html_url":"https://github.com/apache/spark/pull/16587#discussion_r96145383","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/16587","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/96145383"},"html":{"href":"https://github.com/apache/spark/pull/16587#discussion_r96145383"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/16587"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/16587","id":101606034,"html_url":"https://github.com/apache/spark/pull/16587","diff_url":"https://github.com/apache/spark/pull/16587.diff","patch_url":"https://github.com/apache/spark/pull/16587.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/16587","number":16587,"state":"open","locked":false,"title":"[SPARK-19229] [SQL] Disallow Creating Hive Source Tables when Hive Support is Not Enabled","user":{"login":"gatorsmile","id":11567269,"avatar_url":"https://avatars.githubusercontent.com/u/11567269?v=3","gravatar_id":"","url":"https://api.github.com/users/gatorsmile","html_url":"https://github.com/gatorsmile","followers_url":"https://api.github.com/users/gatorsmile/followers","following_url":"https://api.github.com/users/gatorsmile/following{/other_user}","gists_url":"https://api.github.com/users/gatorsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/gatorsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatorsmile/subscriptions","organizations_url":"https://api.github.com/users/gatorsmile/orgs","repos_url":"https://api.github.com/users/gatorsmile/repos","events_url":"https://api.github.com/users/gatorsmile/events{/privacy}","received_events_url":"https://api.github.com/users/gatorsmile/received_events","type":"User","site_admin":false},"body":"### What changes were proposed in this pull request?\r\nIt is weird to create Hive source tables when using InMemoryCatalog. We are unable to operate it. This PR is to block users to create Hive source tables.\r\n\r\n### How was this patch tested?\r\nFixed the test cases","created_at":"2017-01-15T19:12:37Z","updated_at":"2017-01-15T19:19:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"487f8fdc8707080d1c5427a145b07a0aa06db7e6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/16587/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/16587/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/16587/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/0d2d9f282cd1895c113f594c771721e1de53ce73","head":{"label":"gatorsmile:blockHiveTable","ref":"blockHiveTable","sha":"0d2d9f282cd1895c113f594c771721e1de53ce73","user":{"login":"gatorsmile","id":11567269,"avatar_url":"https://avatars.githubusercontent.com/u/11567269?v=3","gravatar_id":"","url":"https://api.github.com/users/gatorsmile","html_url":"https://github.com/gatorsmile","followers_url":"https://api.github.com/users/gatorsmile/followers","following_url":"https://api.github.com/users/gatorsmile/following{/other_user}","gists_url":"https://api.github.com/users/gatorsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/gatorsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatorsmile/subscriptions","organizations_url":"https://api.github.com/users/gatorsmile/orgs","repos_url":"https://api.github.com/users/gatorsmile/repos","events_url":"https://api.github.com/users/gatorsmile/events{/privacy}","received_events_url":"https://api.github.com/users/gatorsmile/received_events","type":"User","site_admin":false},"repo":{"id":44710950,"name":"spark","full_name":"gatorsmile/spark","owner":{"login":"gatorsmile","id":11567269,"avatar_url":"https://avatars.githubusercontent.com/u/11567269?v=3","gravatar_id":"","url":"https://api.github.com/users/gatorsmile","html_url":"https://github.com/gatorsmile","followers_url":"https://api.github.com/users/gatorsmile/followers","following_url":"https://api.github.com/users/gatorsmile/following{/other_user}","gists_url":"https://api.github.com/users/gatorsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/gatorsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatorsmile/subscriptions","organizations_url":"https://api.github.com/users/gatorsmile/orgs","repos_url":"https://api.github.com/users/gatorsmile/repos","events_url":"https://api.github.com/users/gatorsmile/events{/privacy}","received_events_url":"https://api.github.com/users/gatorsmile/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gatorsmile/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/gatorsmile/spark","forks_url":"https://api.github.com/repos/gatorsmile/spark/forks","keys_url":"https://api.github.com/repos/gatorsmile/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gatorsmile/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gatorsmile/spark/teams","hooks_url":"https://api.github.com/repos/gatorsmile/spark/hooks","issue_events_url":"https://api.github.com/repos/gatorsmile/spark/issues/events{/number}","events_url":"https://api.github.com/repos/gatorsmile/spark/events","assignees_url":"https://api.github.com/repos/gatorsmile/spark/assignees{/user}","branches_url":"https://api.github.com/repos/gatorsmile/spark/branches{/branch}","tags_url":"https://api.github.com/repos/gatorsmile/spark/tags","blobs_url":"https://api.github.com/repos/gatorsmile/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gatorsmile/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gatorsmile/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/gatorsmile/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gatorsmile/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/gatorsmile/spark/languages","stargazers_url":"https://api.github.com/repos/gatorsmile/spark/stargazers","contributors_url":"https://api.github.com/repos/gatorsmile/spark/contributors","subscribers_url":"https://api.github.com/repos/gatorsmile/spark/subscribers","subscription_url":"https://api.github.com/repos/gatorsmile/spark/subscription","commits_url":"https://api.github.com/repos/gatorsmile/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/gatorsmile/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/gatorsmile/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/gatorsmile/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/gatorsmile/spark/contents/{+path}","compare_url":"https://api.github.com/repos/gatorsmile/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gatorsmile/spark/merges","archive_url":"https://api.github.com/repos/gatorsmile/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gatorsmile/spark/downloads","issues_url":"https://api.github.com/repos/gatorsmile/spark/issues{/number}","pulls_url":"https://api.github.com/repos/gatorsmile/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/gatorsmile/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/gatorsmile/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gatorsmile/spark/labels{/name}","releases_url":"https://api.github.com/repos/gatorsmile/spark/releases{/id}","deployments_url":"https://api.github.com/repos/gatorsmile/spark/deployments","created_at":"2015-10-21T23:48:23Z","updated_at":"2015-10-21T23:48:54Z","pushed_at":"2017-01-15T19:06:37Z","git_url":"git://github.com/gatorsmile/spark.git","ssh_url":"[email protected]:gatorsmile/spark.git","clone_url":"https://github.com/gatorsmile/spark.git","svn_url":"https://github.com/gatorsmile/spark","homepage":null,"size":263958,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"binaryOutput"}},"base":{"label":"apache:master","ref":"master","sha":"de62ddf7ff42bdc383da127e6b1155897565354c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2017-01-15T13:23:12Z","pushed_at":"2017-01-15T19:12:37Z","git_url":"git://github.com/apache/spark.git","ssh_url":"[email protected]:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":261549,"stargazers_count":11423,"watchers_count":11423,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10698,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":456,"forks":10698,"open_issues":456,"watchers":11423,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/16587"},"html":{"href":"https://github.com/apache/spark/pull/16587"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/16587"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/16587/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/16587/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/16587/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/0d2d9f282cd1895c113f594c771721e1de53ce73"}}}} | {
"id": 17165658,
"name": "apache/spark",
"url": "https://api.github.com/repos/apache/spark"
} | {
"id": 11567269,
"login": "gatorsmile",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11567269?",
"url": "https://api.github.com/users/gatorsmile"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-01-15T19:19:13 | 5156077072 | {"actor":{"display_login":"gatorsmile"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/144085314","pull_request_review_id":68693106,"id":144085314,"diff_hunk":"@@ -0,0 +1,287 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements. See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership. The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.bookkeeper.client;\n+\n+import com.google.common.collect.Iterators;\n+import java.util.Enumeration;\n+import java.util.concurrent.CompletableFuture;\n+import java.util.concurrent.ExecutionException;\n+import static org.apache.bookkeeper.client.LedgerHandle.LOG;\n+import org.apache.bookkeeper.client.api.Handle;\n+import org.apache.bookkeeper.client.api.ReadHandle;\n+\n+/**\n+ * Utility for callbacks\n+ *\n+ */\n+class SyncCallbackUtils {\n+\n+ /**\n+ * Wait for a result. This is convenience method to implement callbacks\n+ *\n+ * @param <T>\n+ * @param future\n+ * @return\n+ * @throws InterruptedException\n+ * @throws BKException\n+ */\n+ public static <T> T waitForResult(CompletableFuture<T> future) throws InterruptedException, BKException {\n+ try {\n+ return future.get();\n+ } catch (ExecutionException err) {\n+ if (err.getCause() instanceof BKException) {\n+ throw (BKException) err.getCause();\n+ } else {\n+ BKException unexpectedConditionException\n+ = BKException.create(BKException.Code.UnexpectedConditionException);\n+ unexpectedConditionException.initCause(err.getCause());\n+ throw unexpectedConditionException;\n+ }\n+\n+ }\n+ }\n+\n+ /**\n+ * Handle the Response Code and transform it to a BKException\n+ *\n+ * @param <T>\n+ * @param rc\n+ * @param result\n+ * @param future\n+ */\n+ public static <T> void finish(int rc, T result, CompletableFuture<T> future) {\n+ if (rc != BKException.Code.OK) {\n+ future.completeExceptionally(BKException.create(rc).fillInStackTrace());\n+ } else {\n+ future.complete(result);\n+ }\n+ }\n+\n+ static class SyncCreateCallback implements AsyncCallback.CreateCallback {\n+\n+ private final CompletableFuture future;","path":"bookkeeper-server/src/main/java/org/apache/bookkeeper/client/SyncCallbackUtils.java","position":null,"original_position":77,"commit_id":"3f6642dec42b32e75ba29a39b15357a812f83c41","original_commit_id":"3c6ef26820546a5cfc06a7ada0399e29df3b4a61","user":{"login":"eolivelli","id":9469110,"avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"body":"Good idea, I will do as you are suggesting","created_at":"2017-10-11T17:46:10Z","updated_at":"2017-10-11T17:46:10Z","html_url":"https://github.com/apache/bookkeeper/pull/549#discussion_r144085314","pull_request_url":"https://api.github.com/repos/apache/bookkeeper/pulls/549","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/144085314"},"html":{"href":"https://github.com/apache/bookkeeper/pull/549#discussion_r144085314"},"pull_request":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/549"}},"in_reply_to_id":143826354},"pull_request":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/549","id":145770042,"html_url":"https://github.com/apache/bookkeeper/pull/549","diff_url":"https://github.com/apache/bookkeeper/pull/549.diff","patch_url":"https://github.com/apache/bookkeeper/pull/549.patch","issue_url":"https://api.github.com/repos/apache/bookkeeper/issues/549","number":549,"state":"open","locked":false,"title":"Issue-506 BP-15 New CreateLedger API","user":{"login":"eolivelli","id":9469110,"avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"body":"This is a new PR for #506 as PR #510 is broken","created_at":"2017-10-10T18:41:38Z","updated_at":"2017-10-11T17:46:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bd5c611f4b9c4d66cf251a4da487f665c2e61ec","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/bookkeeper/pulls/549/commits","review_comments_url":"https://api.github.com/repos/apache/bookkeeper/pulls/549/comments","review_comment_url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/bookkeeper/issues/549/comments","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/3f6642dec42b32e75ba29a39b15357a812f83c41","head":{"label":"eolivelli:bp15-createledger-api-2","ref":"bp15-createledger-api-2","sha":"3f6642dec42b32e75ba29a39b15357a812f83c41","user":{"login":"eolivelli","id":9469110,"avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"repo":{"id":61374519,"name":"bookkeeper","full_name":"eolivelli/bookkeeper","owner":{"login":"eolivelli","id":9469110,"avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eolivelli/bookkeeper","description":"Mirror of Apache Bookkeeper","fork":true,"url":"https://api.github.com/repos/eolivelli/bookkeeper","forks_url":"https://api.github.com/repos/eolivelli/bookkeeper/forks","keys_url":"https://api.github.com/repos/eolivelli/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eolivelli/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eolivelli/bookkeeper/teams","hooks_url":"https://api.github.com/repos/eolivelli/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/eolivelli/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/eolivelli/bookkeeper/events","assignees_url":"https://api.github.com/repos/eolivelli/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/eolivelli/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/eolivelli/bookkeeper/tags","blobs_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eolivelli/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/eolivelli/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/eolivelli/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/eolivelli/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/eolivelli/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/eolivelli/bookkeeper/subscription","commits_url":"https://api.github.com/repos/eolivelli/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/eolivelli/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/eolivelli/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/eolivelli/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/eolivelli/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eolivelli/bookkeeper/merges","archive_url":"https://api.github.com/repos/eolivelli/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eolivelli/bookkeeper/downloads","issues_url":"https://api.github.com/repos/eolivelli/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/eolivelli/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/eolivelli/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/eolivelli/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eolivelli/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/eolivelli/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/eolivelli/bookkeeper/deployments","created_at":"2016-06-17T13:11:53Z","updated_at":"2016-06-17T13:11:55Z","pushed_at":"2017-10-11T07:03:20Z","git_url":"git://github.com/eolivelli/bookkeeper.git","ssh_url":"[email protected]:eolivelli/bookkeeper.git","clone_url":"https://github.com/eolivelli/bookkeeper.git","svn_url":"https://github.com/eolivelli/bookkeeper","homepage":null,"size":13023,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"95373234a273920fadc06742479ddcc4e603fa1b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":1575956,"name":"bookkeeper","full_name":"apache/bookkeeper","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/bookkeeper","description":"Apache Bookkeeper","fork":false,"url":"https://api.github.com/repos/apache/bookkeeper","forks_url":"https://api.github.com/repos/apache/bookkeeper/forks","keys_url":"https://api.github.com/repos/apache/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/bookkeeper/teams","hooks_url":"https://api.github.com/repos/apache/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/apache/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/apache/bookkeeper/events","assignees_url":"https://api.github.com/repos/apache/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/apache/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/apache/bookkeeper/tags","blobs_url":"https://api.github.com/repos/apache/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/apache/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/apache/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/apache/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/apache/bookkeeper/subscription","commits_url":"https://api.github.com/repos/apache/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/apache/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/bookkeeper/merges","archive_url":"https://api.github.com/repos/apache/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/bookkeeper/downloads","issues_url":"https://api.github.com/repos/apache/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/apache/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/apache/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/apache/bookkeeper/deployments","created_at":"2011-04-06T07:00:07Z","updated_at":"2017-10-08T20:09:03Z","pushed_at":"2017-10-11T07:03:22Z","git_url":"git://github.com/apache/bookkeeper.git","ssh_url":"[email protected]:apache/bookkeeper.git","clone_url":"https://github.com/apache/bookkeeper.git","svn_url":"https://github.com/apache/bookkeeper","homepage":"https://bookkeeper.apache.org","size":16648,"stargazers_count":194,"watchers_count":194,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":125,"mirror_url":null,"open_issues_count":70,"forks":125,"open_issues":70,"watchers":194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/549"},"html":{"href":"https://github.com/apache/bookkeeper/pull/549"},"issue":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/549"},"comments":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/549/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/549/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/549/commits"},"statuses":{"href":"https://api.github.com/repos/apache/bookkeeper/statuses/3f6642dec42b32e75ba29a39b15357a812f83c41"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1575956,
"name": "apache/bookkeeper",
"url": "https://api.github.com/repos/apache/bookkeeper"
} | {
"id": 9469110,
"login": "eolivelli",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9469110?",
"url": "https://api.github.com/users/eolivelli"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-10-11T17:46:10 | 6703887528 | {"actor":{"display_login":"eolivelli"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/135350158","pull_request_review_id":58760138,"id":135350158,"diff_hunk":"@@ -634,10 +634,6 @@ private static Query translateGqlQuery(String gql, Datastore datastore, String n\n public void validate(PipelineOptions options) {\n checkNotNull(getProjectId(), \"projectId\");\n \n- if (getProjectId().isAccessible() && getProjectId().get() == null) {","path":"sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1.java","position":null,"original_position":4,"commit_id":"12900bb383b9e8953dcef71c611b0c9ebe0804af","original_commit_id":"1819d4214d949a9bb46a12a2d1bf15ad98f6a303","user":{"login":"jkff","id":343722,"avatar_url":"https://avatars2.githubusercontent.com/u/343722?v=4","gravatar_id":"","url":"https://api.github.com/users/jkff","html_url":"https://github.com/jkff","followers_url":"https://api.github.com/users/jkff/followers","following_url":"https://api.github.com/users/jkff/following{/other_user}","gists_url":"https://api.github.com/users/jkff/gists{/gist_id}","starred_url":"https://api.github.com/users/jkff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkff/subscriptions","organizations_url":"https://api.github.com/users/jkff/orgs","repos_url":"https://api.github.com/users/jkff/repos","events_url":"https://api.github.com/users/jkff/events{/privacy}","received_events_url":"https://api.github.com/users/jkff/received_events","type":"User","site_admin":false},"body":"I'm not sure we need to be this diligent about nullness checking, but okay, reverted this part.","created_at":"2017-08-25T20:48:39Z","updated_at":"2017-08-25T20:48:39Z","html_url":"https://github.com/apache/beam/pull/3732#discussion_r135350158","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/3732","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/135350158"},"html":{"href":"https://github.com/apache/beam/pull/3732#discussion_r135350158"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/3732"}},"in_reply_to_id":133995181},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/3732","id":136392685,"html_url":"https://github.com/apache/beam/pull/3732","diff_url":"https://github.com/apache/beam/pull/3732.diff","patch_url":"https://github.com/apache/beam/pull/3732.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/3732","number":3732,"state":"open","locked":false,"title":"Removes unnecessary calls to ValueProvider.isAccessible","user":{"login":"jkff","id":343722,"avatar_url":"https://avatars2.githubusercontent.com/u/343722?v=4","gravatar_id":"","url":"https://api.github.com/users/jkff","html_url":"https://github.com/jkff","followers_url":"https://api.github.com/users/jkff/followers","following_url":"https://api.github.com/users/jkff/following{/other_user}","gists_url":"https://api.github.com/users/jkff/gists{/gist_id}","starred_url":"https://api.github.com/users/jkff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkff/subscriptions","organizations_url":"https://api.github.com/users/jkff/orgs","repos_url":"https://api.github.com/users/jkff/repos","events_url":"https://api.github.com/users/jkff/events{/privacy}","received_events_url":"https://api.github.com/users/jkff/received_events","type":"User","site_admin":false},"body":"Most of this cleanup is in DisplayData. DisplayData.item() already can take a ValueProvider and handles it properly.\r\n\r\nR: @lukecwik ","created_at":"2017-08-18T02:55:10Z","updated_at":"2017-08-25T20:48:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5b83dcd9a83ce96ee79cc7f3733f2b3aee2020d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/3732/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/3732/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/3732/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/12900bb383b9e8953dcef71c611b0c9ebe0804af","head":{"label":"jkff:value-provider-display-data","ref":"value-provider-display-data","sha":"12900bb383b9e8953dcef71c611b0c9ebe0804af","user":{"login":"jkff","id":343722,"avatar_url":"https://avatars2.githubusercontent.com/u/343722?v=4","gravatar_id":"","url":"https://api.github.com/users/jkff","html_url":"https://github.com/jkff","followers_url":"https://api.github.com/users/jkff/followers","following_url":"https://api.github.com/users/jkff/following{/other_user}","gists_url":"https://api.github.com/users/jkff/gists{/gist_id}","starred_url":"https://api.github.com/users/jkff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkff/subscriptions","organizations_url":"https://api.github.com/users/jkff/orgs","repos_url":"https://api.github.com/users/jkff/repos","events_url":"https://api.github.com/users/jkff/events{/privacy}","received_events_url":"https://api.github.com/users/jkff/received_events","type":"User","site_admin":false},"repo":{"id":53902119,"name":"incubator-beam","full_name":"jkff/incubator-beam","owner":{"login":"jkff","id":343722,"avatar_url":"https://avatars2.githubusercontent.com/u/343722?v=4","gravatar_id":"","url":"https://api.github.com/users/jkff","html_url":"https://github.com/jkff","followers_url":"https://api.github.com/users/jkff/followers","following_url":"https://api.github.com/users/jkff/following{/other_user}","gists_url":"https://api.github.com/users/jkff/gists{/gist_id}","starred_url":"https://api.github.com/users/jkff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkff/subscriptions","organizations_url":"https://api.github.com/users/jkff/orgs","repos_url":"https://api.github.com/users/jkff/repos","events_url":"https://api.github.com/users/jkff/events{/privacy}","received_events_url":"https://api.github.com/users/jkff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jkff/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/jkff/incubator-beam","forks_url":"https://api.github.com/repos/jkff/incubator-beam/forks","keys_url":"https://api.github.com/repos/jkff/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkff/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkff/incubator-beam/teams","hooks_url":"https://api.github.com/repos/jkff/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/jkff/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/jkff/incubator-beam/events","assignees_url":"https://api.github.com/repos/jkff/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/jkff/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/jkff/incubator-beam/tags","blobs_url":"https://api.github.com/repos/jkff/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkff/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkff/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkff/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkff/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/jkff/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/jkff/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/jkff/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/jkff/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/jkff/incubator-beam/subscription","commits_url":"https://api.github.com/repos/jkff/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkff/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkff/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkff/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkff/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/jkff/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkff/incubator-beam/merges","archive_url":"https://api.github.com/repos/jkff/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkff/incubator-beam/downloads","issues_url":"https://api.github.com/repos/jkff/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/jkff/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/jkff/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/jkff/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkff/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/jkff/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/jkff/incubator-beam/deployments","created_at":"2016-03-15T00:32:38Z","updated_at":"2016-03-15T00:32:41Z","pushed_at":"2017-08-25T20:46:13Z","git_url":"git://github.com/jkff/incubator-beam.git","ssh_url":"[email protected]:jkff/incubator-beam.git","clone_url":"https://github.com/jkff/incubator-beam.git","svn_url":"https://github.com/jkff/incubator-beam","homepage":null,"size":40836,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"cdf050c0d693206ebbcf47b4e396db26f7579f2a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"beam","full_name":"apache/beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/beam","description":"Mirror of Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2017-08-24T14:46:59Z","pushed_at":"2017-08-25T20:46:15Z","git_url":"git://github.com/apache/beam.git","ssh_url":"[email protected]:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"","size":42456,"stargazers_count":1350,"watchers_count":1350,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":781,"mirror_url":"git://git.apache.org/beam.git","open_issues_count":87,"forks":781,"open_issues":87,"watchers":1350,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/3732"},"html":{"href":"https://github.com/apache/beam/pull/3732"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/3732"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/3732/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/3732/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/3732/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/12900bb383b9e8953dcef71c611b0c9ebe0804af"}}}} | {
"id": 50904245,
"name": "apache/beam",
"url": "https://api.github.com/repos/apache/beam"
} | {
"id": 343722,
"login": "jkff",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/343722?",
"url": "https://api.github.com/users/jkff"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-08-25T20:48:39 | 6513916450 | {"actor":{"display_login":"jkff"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments/127131356","pull_request_review_id":49682521,"id":127131356,"diff_hunk":"@@ -71,6 +71,8 @@ import whisk.utils.retry\n \n case class WskProps(\n authKey: String = WhiskProperties.readAuthKey(WhiskProperties.getAuthFileForTesting),\n+ cert: String = WhiskProperties.getProperty(\"openwhisk.home\") + \"/ansible/roles/nginx/files/openwhisk-client-cert.pem\",\n+ key: String = WhiskProperties.getProperty(\"openwhisk.home\") + \"/ansible/roles/nginx/files/openwhisk-client-key.pem\",","path":"tests/src/test/scala/common/Wsk.scala","position":null,"original_position":5,"commit_id":"4fc59ff9be2eef9eabe2185dd56d37c9f816c9c8","original_commit_id":"7aa9bd66f4a864957dde5b0c18375f1c8f18f504","user":{"login":"ningyougang","id":11749867,"avatar_url":"https://avatars0.githubusercontent.com/u/11749867?v=3","gravatar_id":"","url":"https://api.github.com/users/ningyougang","html_url":"https://github.com/ningyougang","followers_url":"https://api.github.com/users/ningyougang/followers","following_url":"https://api.github.com/users/ningyougang/following{/other_user}","gists_url":"https://api.github.com/users/ningyougang/gists{/gist_id}","starred_url":"https://api.github.com/users/ningyougang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ningyougang/subscriptions","organizations_url":"https://api.github.com/users/ningyougang/orgs","repos_url":"https://api.github.com/users/ningyougang/repos","events_url":"https://api.github.com/users/ningyougang/events{/privacy}","received_events_url":"https://api.github.com/users/ningyougang/received_events","type":"User","site_admin":false},"body":"@rabbah ,thank you, i have modified.","created_at":"2017-07-13T05:32:45Z","updated_at":"2017-07-13T05:32:46Z","html_url":"https://github.com/apache/incubator-openwhisk/pull/2427#discussion_r127131356","pull_request_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/2427","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments/127131356"},"html":{"href":"https://github.com/apache/incubator-openwhisk/pull/2427#discussion_r127131356"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/2427"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/2427","id":127612564,"html_url":"https://github.com/apache/incubator-openwhisk/pull/2427","diff_url":"https://github.com/apache/incubator-openwhisk/pull/2427.diff","patch_url":"https://github.com/apache/incubator-openwhisk/pull/2427.patch","issue_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/2427","number":2427,"state":"open","locked":false,"title":"Support client certificate on cli and nginx","user":{"login":"ningyougang","id":11749867,"avatar_url":"https://avatars0.githubusercontent.com/u/11749867?v=3","gravatar_id":"","url":"https://api.github.com/users/ningyougang","html_url":"https://github.com/ningyougang","followers_url":"https://api.github.com/users/ningyougang/followers","following_url":"https://api.github.com/users/ningyougang/following{/other_user}","gists_url":"https://api.github.com/users/ningyougang/gists{/gist_id}","starred_url":"https://api.github.com/users/ningyougang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ningyougang/subscriptions","organizations_url":"https://api.github.com/users/ningyougang/orgs","repos_url":"https://api.github.com/users/ningyougang/repos","events_url":"https://api.github.com/users/ningyougang/events{/privacy}","received_events_url":"https://api.github.com/users/ningyougang/received_events","type":"User","site_admin":false},"body":"In order to increase the security of auth, it is necessary to add client\r\ncertificate on cli and nginx. So user can use wsk -i property set --cert\r\nopenwhisk-client-cert.pem --key openwhisk-client-key.pem to pass client\r\ncertificate to nginx. If you don't want to use default client certificate\r\nwhich system provides, you can create your own client certificate instead\r\nof them.","created_at":"2017-06-27T05:06:15Z","updated_at":"2017-07-13T05:32:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9ac357d22ca312102e0d9b2b93dba8ba69ea278","assignee":{"login":"jeremiaswerner","id":17203227,"avatar_url":"https://avatars3.githubusercontent.com/u/17203227?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremiaswerner","html_url":"https://github.com/jeremiaswerner","followers_url":"https://api.github.com/users/jeremiaswerner/followers","following_url":"https://api.github.com/users/jeremiaswerner/following{/other_user}","gists_url":"https://api.github.com/users/jeremiaswerner/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremiaswerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremiaswerner/subscriptions","organizations_url":"https://api.github.com/users/jeremiaswerner/orgs","repos_url":"https://api.github.com/users/jeremiaswerner/repos","events_url":"https://api.github.com/users/jeremiaswerner/events{/privacy}","received_events_url":"https://api.github.com/users/jeremiaswerner/received_events","type":"User","site_admin":false},"assignees":[{"login":"jeremiaswerner","id":17203227,"avatar_url":"https://avatars3.githubusercontent.com/u/17203227?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremiaswerner","html_url":"https://github.com/jeremiaswerner","followers_url":"https://api.github.com/users/jeremiaswerner/followers","following_url":"https://api.github.com/users/jeremiaswerner/following{/other_user}","gists_url":"https://api.github.com/users/jeremiaswerner/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremiaswerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremiaswerner/subscriptions","organizations_url":"https://api.github.com/users/jeremiaswerner/orgs","repos_url":"https://api.github.com/users/jeremiaswerner/repos","events_url":"https://api.github.com/users/jeremiaswerner/events{/privacy}","received_events_url":"https://api.github.com/users/jeremiaswerner/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"csantanapr","id":1094878,"avatar_url":"https://avatars3.githubusercontent.com/u/1094878?v=3","gravatar_id":"","url":"https://api.github.com/users/csantanapr","html_url":"https://github.com/csantanapr","followers_url":"https://api.github.com/users/csantanapr/followers","following_url":"https://api.github.com/users/csantanapr/following{/other_user}","gists_url":"https://api.github.com/users/csantanapr/gists{/gist_id}","starred_url":"https://api.github.com/users/csantanapr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csantanapr/subscriptions","organizations_url":"https://api.github.com/users/csantanapr/orgs","repos_url":"https://api.github.com/users/csantanapr/repos","events_url":"https://api.github.com/users/csantanapr/events{/privacy}","received_events_url":"https://api.github.com/users/csantanapr/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/2427/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/2427/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/2427/comments","statuses_url":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/4fc59ff9be2eef9eabe2185dd56d37c9f816c9c8","head":{"label":"ningyougang:support-client-certificate","ref":"support-client-certificate","sha":"4fc59ff9be2eef9eabe2185dd56d37c9f816c9c8","user":{"login":"ningyougang","id":11749867,"avatar_url":"https://avatars0.githubusercontent.com/u/11749867?v=3","gravatar_id":"","url":"https://api.github.com/users/ningyougang","html_url":"https://github.com/ningyougang","followers_url":"https://api.github.com/users/ningyougang/followers","following_url":"https://api.github.com/users/ningyougang/following{/other_user}","gists_url":"https://api.github.com/users/ningyougang/gists{/gist_id}","starred_url":"https://api.github.com/users/ningyougang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ningyougang/subscriptions","organizations_url":"https://api.github.com/users/ningyougang/orgs","repos_url":"https://api.github.com/users/ningyougang/repos","events_url":"https://api.github.com/users/ningyougang/events{/privacy}","received_events_url":"https://api.github.com/users/ningyougang/received_events","type":"User","site_admin":false},"repo":{"id":95518639,"name":"incubator-openwhisk","full_name":"ningyougang/incubator-openwhisk","owner":{"login":"ningyougang","id":11749867,"avatar_url":"https://avatars0.githubusercontent.com/u/11749867?v=3","gravatar_id":"","url":"https://api.github.com/users/ningyougang","html_url":"https://github.com/ningyougang","followers_url":"https://api.github.com/users/ningyougang/followers","following_url":"https://api.github.com/users/ningyougang/following{/other_user}","gists_url":"https://api.github.com/users/ningyougang/gists{/gist_id}","starred_url":"https://api.github.com/users/ningyougang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ningyougang/subscriptions","organizations_url":"https://api.github.com/users/ningyougang/orgs","repos_url":"https://api.github.com/users/ningyougang/repos","events_url":"https://api.github.com/users/ningyougang/events{/privacy}","received_events_url":"https://api.github.com/users/ningyougang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ningyougang/incubator-openwhisk","description":"Apache OpenWhisk is a serverless event-based programming service and an Apache Incubator project.","fork":true,"url":"https://api.github.com/repos/ningyougang/incubator-openwhisk","forks_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/forks","keys_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/teams","hooks_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/hooks","issue_events_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/issues/events{/number}","events_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/events","assignees_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/assignees{/user}","branches_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/branches{/branch}","tags_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/tags","blobs_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/statuses/{sha}","languages_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/languages","stargazers_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/stargazers","contributors_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/contributors","subscribers_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/subscribers","subscription_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/subscription","commits_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/contents/{+path}","compare_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/merges","archive_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/downloads","issues_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/issues{/number}","pulls_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/pulls{/number}","milestones_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/milestones{/number}","notifications_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/labels{/name}","releases_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/releases{/id}","deployments_url":"https://api.github.com/repos/ningyougang/incubator-openwhisk/deployments","created_at":"2017-06-27T04:49:24Z","updated_at":"2017-06-27T04:49:27Z","pushed_at":"2017-07-13T04:37:19Z","git_url":"git://github.com/ningyougang/incubator-openwhisk.git","ssh_url":"[email protected]:ningyougang/incubator-openwhisk.git","clone_url":"https://github.com/ningyougang/incubator-openwhisk.git","svn_url":"https://github.com/ningyougang/incubator-openwhisk","homepage":"http://openwhisk.org","size":55687,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b5b47d81638a821e930301628ca38afe909b7d71","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":52039373,"name":"incubator-openwhisk","full_name":"apache/incubator-openwhisk","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-openwhisk","description":"Apache OpenWhisk is a serverless event-based programming service and an Apache Incubator project.","fork":false,"url":"https://api.github.com/repos/apache/incubator-openwhisk","forks_url":"https://api.github.com/repos/apache/incubator-openwhisk/forks","keys_url":"https://api.github.com/repos/apache/incubator-openwhisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-openwhisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-openwhisk/teams","hooks_url":"https://api.github.com/repos/apache/incubator-openwhisk/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-openwhisk/events","assignees_url":"https://api.github.com/repos/apache/incubator-openwhisk/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-openwhisk/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-openwhisk/tags","blobs_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-openwhisk/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-openwhisk/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-openwhisk/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-openwhisk/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-openwhisk/subscription","commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-openwhisk/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-openwhisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-openwhisk/merges","archive_url":"https://api.github.com/repos/apache/incubator-openwhisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-openwhisk/downloads","issues_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-openwhisk/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-openwhisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-openwhisk/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-openwhisk/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-openwhisk/deployments","created_at":"2016-02-18T21:16:19Z","updated_at":"2017-07-12T20:09:14Z","pushed_at":"2017-07-13T05:09:56Z","git_url":"git://github.com/apache/incubator-openwhisk.git","ssh_url":"[email protected]:apache/incubator-openwhisk.git","clone_url":"https://github.com/apache/incubator-openwhisk.git","svn_url":"https://github.com/apache/incubator-openwhisk","homepage":"http://openwhisk.org","size":55708,"stargazers_count":1680,"watchers_count":1680,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":369,"mirror_url":null,"open_issues_count":354,"forks":369,"open_issues":354,"watchers":1680,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/2427"},"html":{"href":"https://github.com/apache/incubator-openwhisk/pull/2427"},"issue":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/issues/2427"},"comments":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/issues/2427/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/2427/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/2427/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/4fc59ff9be2eef9eabe2185dd56d37c9f816c9c8"}}}} | {
"id": 52039373,
"name": "apache/incubator-openwhisk",
"url": "https://api.github.com/repos/apache/incubator-openwhisk"
} | {
"id": 11749867,
"login": "ningyougang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11749867?",
"url": "https://api.github.com/users/ningyougang"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-07-13T05:32:45 | 6246699454 | {"actor":{"display_login":"ningyougang"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/147667457","pull_request_review_id":72793299,"id":147667457,"diff_hunk":"@@ -226,13 +228,19 @@ public int getTransactionCoordinatorId() {\n \n \tprivate void flushNewPartitions() {\n \t\tLOG.info(\"Flushing new partitions\");\n+\t\tenqueueNewPartitions().await();\n+\t}\n+\n+\tprivate TransactionalRequestResult enqueueNewPartitions() {\n \t\tObject transactionManager = getValue(kafkaProducer, \"transactionManager\");\n-\t\tObject txnRequestHandler = invoke(transactionManager, \"addPartitionsToTransactionHandler\");\n-\t\tinvoke(transactionManager, \"enqueueRequest\", new Class[]{txnRequestHandler.getClass().getSuperclass()}, new Object[]{txnRequestHandler});\n-\t\tTransactionalRequestResult result = (TransactionalRequestResult) getValue(txnRequestHandler, txnRequestHandler.getClass().getSuperclass(), \"result\");\n-\t\tObject sender = getValue(kafkaProducer, \"sender\");\n-\t\tinvoke(sender, \"wakeup\");\n-\t\tresult.await();\n+\t\tsynchronized (transactionManager) {\n+\t\t\tObject txnRequestHandler = invoke(transactionManager, \"addPartitionsToTransactionHandler\");\n+\t\t\tinvoke(transactionManager, \"enqueueRequest\", new Class[]{txnRequestHandler.getClass().getSuperclass()}, new Object[]{txnRequestHandler});\n+\t\t\tTransactionalRequestResult result = (TransactionalRequestResult) getValue(txnRequestHandler, txnRequestHandler.getClass().getSuperclass(), \"result\");\n+\t\t\tObject sender = getValue(kafkaProducer, \"sender\");\n+\t\t\tinvoke(sender, \"wakeup\");","path":"flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaProducer.java","position":51,"original_position":51,"commit_id":"6cf55ed8977135af01099452962962199e253348","original_commit_id":"6cf55ed8977135af01099452962962199e253348","user":{"login":"GJL","id":1681921,"avatar_url":"https://avatars2.githubusercontent.com/u/1681921?v=4","gravatar_id":"","url":"https://api.github.com/users/GJL","html_url":"https://github.com/GJL","followers_url":"https://api.github.com/users/GJL/followers","following_url":"https://api.github.com/users/GJL/following{/other_user}","gists_url":"https://api.github.com/users/GJL/gists{/gist_id}","starred_url":"https://api.github.com/users/GJL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GJL/subscriptions","organizations_url":"https://api.github.com/users/GJL/orgs","repos_url":"https://api.github.com/users/GJL/repos","events_url":"https://api.github.com/users/GJL/events{/privacy}","received_events_url":"https://api.github.com/users/GJL/received_events","type":"User","site_admin":false},"body":"`sender.wakeup` is outside of the lock in the original code. Do you think it makes a difference?","created_at":"2017-10-30T10:43:24Z","updated_at":"2017-10-30T10:43:24Z","html_url":"https://github.com/apache/flink/pull/4915#discussion_r147667457","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/4915","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/147667457"},"html":{"href":"https://github.com/apache/flink/pull/4915#discussion_r147667457"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/4915"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/4915","id":149202766,"html_url":"https://github.com/apache/flink/pull/4915","diff_url":"https://github.com/apache/flink/pull/4915.diff","patch_url":"https://github.com/apache/flink/pull/4915.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/4915","number":4915,"state":"open","locked":false,"title":"[FLINK-7838] Bunch of hotfixes and fix missing synchronization in FlinkKafkaProducer011","user":{"login":"pnowojski","id":8957547,"avatar_url":"https://avatars3.githubusercontent.com/u/8957547?v=4","gravatar_id":"","url":"https://api.github.com/users/pnowojski","html_url":"https://github.com/pnowojski","followers_url":"https://api.github.com/users/pnowojski/followers","following_url":"https://api.github.com/users/pnowojski/following{/other_user}","gists_url":"https://api.github.com/users/pnowojski/gists{/gist_id}","starred_url":"https://api.github.com/users/pnowojski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnowojski/subscriptions","organizations_url":"https://api.github.com/users/pnowojski/orgs","repos_url":"https://api.github.com/users/pnowojski/repos","events_url":"https://api.github.com/users/pnowojski/events{/privacy}","received_events_url":"https://api.github.com/users/pnowojski/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\n\r\nMost important is the commit adding missing synchronization, that might been the cause for some deadlocks on travis. Others are just non critical hotfixes.\r\n\r\n## Brief change log\r\n\r\nPlease check individual commit messages.\r\n\r\n## Verifying this change\r\n\r\nThis change is already covered by existing Kafka 0.11 connector tests.\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n - Dependencies (does it add or upgrade a dependency): (**yes** / no)\r\n - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)\r\n - The serializers: (yes / **no** / don't know)\r\n - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)\r\n - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)\r\n\r\n## Documentation\r\n\r\n - Does this pull request introduce a new feature? (yes / **no**)\r\n - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)\r\n\r\n","created_at":"2017-10-27T14:23:41Z","updated_at":"2017-10-30T10:43:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c446457466c578fe2855aa137d4bba932736c2e5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/4915/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/4915/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/4915/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/6cf55ed8977135af01099452962962199e253348","head":{"label":"pnowojski:f7838","ref":"f7838","sha":"6cf55ed8977135af01099452962962199e253348","user":{"login":"pnowojski","id":8957547,"avatar_url":"https://avatars3.githubusercontent.com/u/8957547?v=4","gravatar_id":"","url":"https://api.github.com/users/pnowojski","html_url":"https://github.com/pnowojski","followers_url":"https://api.github.com/users/pnowojski/followers","following_url":"https://api.github.com/users/pnowojski/following{/other_user}","gists_url":"https://api.github.com/users/pnowojski/gists{/gist_id}","starred_url":"https://api.github.com/users/pnowojski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnowojski/subscriptions","organizations_url":"https://api.github.com/users/pnowojski/orgs","repos_url":"https://api.github.com/users/pnowojski/repos","events_url":"https://api.github.com/users/pnowojski/events{/privacy}","received_events_url":"https://api.github.com/users/pnowojski/received_events","type":"User","site_admin":false},"repo":{"id":94091518,"name":"flink","full_name":"pnowojski/flink","owner":{"login":"pnowojski","id":8957547,"avatar_url":"https://avatars3.githubusercontent.com/u/8957547?v=4","gravatar_id":"","url":"https://api.github.com/users/pnowojski","html_url":"https://github.com/pnowojski","followers_url":"https://api.github.com/users/pnowojski/followers","following_url":"https://api.github.com/users/pnowojski/following{/other_user}","gists_url":"https://api.github.com/users/pnowojski/gists{/gist_id}","starred_url":"https://api.github.com/users/pnowojski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnowojski/subscriptions","organizations_url":"https://api.github.com/users/pnowojski/orgs","repos_url":"https://api.github.com/users/pnowojski/repos","events_url":"https://api.github.com/users/pnowojski/events{/privacy}","received_events_url":"https://api.github.com/users/pnowojski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pnowojski/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/pnowojski/flink","forks_url":"https://api.github.com/repos/pnowojski/flink/forks","keys_url":"https://api.github.com/repos/pnowojski/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pnowojski/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pnowojski/flink/teams","hooks_url":"https://api.github.com/repos/pnowojski/flink/hooks","issue_events_url":"https://api.github.com/repos/pnowojski/flink/issues/events{/number}","events_url":"https://api.github.com/repos/pnowojski/flink/events","assignees_url":"https://api.github.com/repos/pnowojski/flink/assignees{/user}","branches_url":"https://api.github.com/repos/pnowojski/flink/branches{/branch}","tags_url":"https://api.github.com/repos/pnowojski/flink/tags","blobs_url":"https://api.github.com/repos/pnowojski/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pnowojski/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pnowojski/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/pnowojski/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pnowojski/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/pnowojski/flink/languages","stargazers_url":"https://api.github.com/repos/pnowojski/flink/stargazers","contributors_url":"https://api.github.com/repos/pnowojski/flink/contributors","subscribers_url":"https://api.github.com/repos/pnowojski/flink/subscribers","subscription_url":"https://api.github.com/repos/pnowojski/flink/subscription","commits_url":"https://api.github.com/repos/pnowojski/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/pnowojski/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/pnowojski/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/pnowojski/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/pnowojski/flink/contents/{+path}","compare_url":"https://api.github.com/repos/pnowojski/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pnowojski/flink/merges","archive_url":"https://api.github.com/repos/pnowojski/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pnowojski/flink/downloads","issues_url":"https://api.github.com/repos/pnowojski/flink/issues{/number}","pulls_url":"https://api.github.com/repos/pnowojski/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/pnowojski/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/pnowojski/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pnowojski/flink/labels{/name}","releases_url":"https://api.github.com/repos/pnowojski/flink/releases{/id}","deployments_url":"https://api.github.com/repos/pnowojski/flink/deployments","created_at":"2017-06-12T12:03:15Z","updated_at":"2017-06-12T12:03:37Z","pushed_at":"2017-10-27T14:16:11Z","git_url":"git://github.com/pnowojski/flink.git","ssh_url":"[email protected]:pnowojski/flink.git","clone_url":"https://github.com/pnowojski/flink.git","svn_url":"https://github.com/pnowojski/flink","homepage":null,"size":136477,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"79977158a609dd112aec51174445bea933b1da87","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2017-10-30T08:44:45Z","pushed_at":"2017-10-30T10:34:51Z","git_url":"git://github.com/apache/flink.git","ssh_url":"[email protected]:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":136898,"stargazers_count":2845,"watchers_count":2845,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1966,"mirror_url":"git://git.apache.org/flink.git","archived":false,"open_issues_count":313,"forks":1966,"open_issues":313,"watchers":2845,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/4915"},"html":{"href":"https://github.com/apache/flink/pull/4915"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/4915"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/4915/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/4915/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/4915/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/6cf55ed8977135af01099452962962199e253348"}},"author_association":"CONTRIBUTOR"}} | {
"id": 20587599,
"name": "apache/flink",
"url": "https://api.github.com/repos/apache/flink"
} | {
"id": 1681921,
"login": "GJL",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1681921?",
"url": "https://api.github.com/users/GJL"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-10-30T10:43:24 | 6783099506 | {"actor":{"display_login":"GJL"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/98186441","pull_request_review_id":18656116,"id":98186441,"diff_hunk":"@@ -0,0 +1,128 @@\n+/*\r\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\r\n+ * contributor license agreements. See the NOTICE file distributed with\r\n+ * this work for additional information regarding copyright ownership.\r\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\r\n+ * (the \"License\"); you may not use this file except in compliance with\r\n+ * the License. You may obtain a copy of the License at\r\n+ *\r\n+ * http://www.apache.org/licenses/LICENSE-2.0\r\n+ *\r\n+ * Unless required by applicable law or agreed to in writing, software\r\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\r\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\r\n+ * See the License for the specific language governing permissions and\r\n+ * limitations under the License.\r\n+ */\r\n+\r\n+package org.apache.spark.sql.catalyst.optimizer\r\n+\r\n+import org.apache.spark.sql.catalyst.expressions._\r\n+import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan\r\n+import org.apache.spark.sql.catalyst.rules.Rule\r\n+\r\n+/**\r\n+* push down operations into [[CreateNamedStructLike]].\r\n+*/\r\n+object SimplifyCreateStructOps extends Rule[LogicalPlan] {\r\n+ override def apply(plan: LogicalPlan): LogicalPlan = {\r\n+ plan.transformExpressionsUp {\r\n+ // push down field extraction\r\n+ case GetStructField(createNamedStructLike: CreateNamedStructLike, ordinal, _) =>\r\n+ createNamedStructLike.valExprs(ordinal)\r\n+ }\r\n+ }\r\n+}\r\n+\r\n+/**\r\n+* push down operations into [[CreateArray]].\r\n+*/\r\n+object SimplifyCreateArrayOps extends Rule[LogicalPlan] {\r\n+ override def apply(plan: LogicalPlan): LogicalPlan = {\r\n+ plan.transformExpressionsUp {\r\n+ // push down field selection (array of structs)\r\n+ case GetArrayStructFields(CreateArray(elems), field, ordinal, numFields, containsNull) =>\r\n+ CreateArray(elems.map(GetStructField(_, ordinal, Some(field.name))))\r\n+ // push down item selection.\r\n+ case ga @ GetArrayItem(CreateArray(elems), IntegerLiteral(idx)) =>\r\n+ if (idx >= 0 && idx < elems.size) {\r\n+ elems(idx)\r\n+ } else {\r\n+ Cast(Literal(null), ga.dataType)\r\n+ }\r\n+ }\r\n+ }\r\n+}\r\n+\r\n+/**\r\n+* push down operations into [[CreateMap]].\r\n+*/\r\n+object SimplifyCreateMapOps extends Rule[LogicalPlan] {\r\n+ object ComparisonResult extends Enumeration {\r\n+ val PositiveMatch = Value\r\n+ val NegativeMatch = Value\r\n+ val UnDetermined = Value\r\n+ }\r\n+\r\n+ def compareKeys(k1 : Expression, k2 : Expression) : ComparisonResult.Value = {\r\n+ (k1, k2) match {\r\n+ case (x, y) if x.semanticEquals(y) => ComparisonResult.PositiveMatch\r\n+ // make surethis is null safe, especially when datatypes differ\r\n+ // is this even possible?\r\n+ case (_ : Literal, _ : Literal) => ComparisonResult.NegativeMatch\r\n+ case _ => ComparisonResult.UnDetermined\r\n+ }\r\n+ }\r\n+\r\n+ case class ClassifiedEntries(\r\n+ undetermined : Seq[Expression],\r\n+ nullable : Boolean,\r\n+ firstPositive : Option[Expression]) {\r\n+ def normalize(k : Expression) : ClassifiedEntries = this match {\r\n+ /**\r\n+ * when we have undetermined matches that might bproduce a null value,\r\n+ * we can't separate a positive match and use [[Coalesce]] to choose the final result.\r\n+ * so we 'hide' the positive match as an undetermined match.\r\n+ */\r\n+ case ClassifiedEntries(u, true, Some(p)) if u.nonEmpty =>\r\n+ ClassifiedEntries(u ++ Seq(k, p), true, None)\r\n+ case _ => this\r\n+ }\r\n+ }\r\n+\r\n+ def classifyEntries(mapEntries : Seq[(Expression, Expression)],\r\n+ requestedKey : Expression) : ClassifiedEntries = {\r\n+ val res1 = mapEntries.foldLeft(ClassifiedEntries(Seq.empty, nullable = false, None)) {\r\n+ case (prev @ ClassifiedEntries(_, _, Some(_)), _) => prev\r\n+ case (ClassifiedEntries(prev, nullable, None), (k, v)) =>\r\n+ compareKeys(k, requestedKey) match {\r\n+ case ComparisonResult.UnDetermined =>\r\n+ val vIsNullable = v.nullable\r\n+ val nextNullbale = nullable || vIsNullable\r\n+ ClassifiedEntries(prev ++ Seq(k, v), nullable = nextNullbale, None)\r\n+ case ComparisonResult.NegativeMatch => ClassifiedEntries(prev, nullable, None)\r\n+ case ComparisonResult.PositiveMatch => ClassifiedEntries(prev, nullable, Some(v))\r\n+ }\r\n+ }\r\n+ res1.normalize(requestedKey)\r\n+ }\r\n+\r\n+ override def apply(plan: LogicalPlan): LogicalPlan = {\r\n+ plan.transformExpressionsUp {\r\n+ // attempt to unfold 'constant' key extraction,\r\n+ // this enables other optimizations to take place.\r\n+ case gmv @ GetMapValue(cm @ CreateMap(elems), key) =>\r","path":"sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ComplexTypes.scala","position":114,"original_position":114,"commit_id":"1ba1b444bb9be4caca48294b5310d80821d67190","original_commit_id":"1ba1b444bb9be4caca48294b5310d80821d67190","user":{"login":"hvanhovell","id":9616802,"avatar_url":"https://avatars.githubusercontent.com/u/9616802?v=3","gravatar_id":"","url":"https://api.github.com/users/hvanhovell","html_url":"https://github.com/hvanhovell","followers_url":"https://api.github.com/users/hvanhovell/followers","following_url":"https://api.github.com/users/hvanhovell/following{/other_user}","gists_url":"https://api.github.com/users/hvanhovell/gists{/gist_id}","starred_url":"https://api.github.com/users/hvanhovell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hvanhovell/subscriptions","organizations_url":"https://api.github.com/users/hvanhovell/orgs","repos_url":"https://api.github.com/users/hvanhovell/repos","events_url":"https://api.github.com/users/hvanhovell/events{/privacy}","received_events_url":"https://api.github.com/users/hvanhovell/received_events","type":"User","site_admin":false},"body":"If I understand this correctly this does the following. The rule scans the map for potential matches, the following scenario's apply:\r\n\r\n1. No matches are found & no potential (undetermined) matches are found. We return a null value.\r\n2. An undetermined match is found first. We prune the map and add all undetermined and positive matches to the given map, and wrap this `CreateMap` with a `GetMapValue` expression.\r\n3. An positive match is found first. We return the positive match.\r\n\r\nSo why not write the following (I have not compiled this):\r\n```scala\r\ncase gmv @ GetMapValue(CreateMap(elems), key) =>\r\n // Tag each key/value pair with a potential match result.\r\n val taggedKvs = elems.grouped(2).map {\r\n case kv @ (k, _) => compareKeys(k, key) -> kv\r\n }\r\n // Filter out negative results.\r\n val prunedTaggedKvs = kvs.filterNot(_._1 == ComparisonResult.NegativeMatch)\r\n prunedKvs.headOption match {\r\n case Some((ComparisonResult.PositiveMatch, (_, v)) => v\r\n case Some((ComparisonResult.Undetermined, _)) =>\r\n val prunedKvs = prunedTaggedKvs.flatmap {\r\n case (_, (k, v)) => Seq(k, v)\r\n }\r\n GetMapValue(CreateMap(prunedKvs.map(_._2)), key)\r\n case None => Literal.create(null, gmv.dataType)\r\n }\r\n```\r\nThat could save a lot of code.","created_at":"2017-01-27T11:34:28Z","updated_at":"2017-01-27T11:41:06Z","html_url":"https://github.com/apache/spark/pull/16043#discussion_r98186441","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/16043","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/98186441"},"html":{"href":"https://github.com/apache/spark/pull/16043#discussion_r98186441"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/16043"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/16043","id":95570635,"html_url":"https://github.com/apache/spark/pull/16043","diff_url":"https://github.com/apache/spark/pull/16043.diff","patch_url":"https://github.com/apache/spark/pull/16043.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/16043","number":16043,"state":"open","locked":false,"title":"[SPARK-18601][SQL] Simplify Create/Get complex expression pairs in optimizer","user":{"login":"eyalfa","id":1131833,"avatar_url":"https://avatars.githubusercontent.com/u/1131833?v=3","gravatar_id":"","url":"https://api.github.com/users/eyalfa","html_url":"https://github.com/eyalfa","followers_url":"https://api.github.com/users/eyalfa/followers","following_url":"https://api.github.com/users/eyalfa/following{/other_user}","gists_url":"https://api.github.com/users/eyalfa/gists{/gist_id}","starred_url":"https://api.github.com/users/eyalfa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyalfa/subscriptions","organizations_url":"https://api.github.com/users/eyalfa/orgs","repos_url":"https://api.github.com/users/eyalfa/repos","events_url":"https://api.github.com/users/eyalfa/events{/privacy}","received_events_url":"https://api.github.com/users/eyalfa/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\nIt often happens that a complex object (struct/map/array) is created only to get elements from it in an subsequent expression. We can add an optimizer rule for this.\r\n\r\n## How was this patch tested?\r\nunit-tests\r\n\r\nPlease review http://spark.apache.org/contributing.html before opening a pull request.\r\n","created_at":"2016-11-28T20:28:11Z","updated_at":"2017-01-27T11:41:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"940b49647252c1b6048ee1423d5a23d9c87abe44","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/16043/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/16043/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/16043/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/1ba1b444bb9be4caca48294b5310d80821d67190","head":{"label":"eyalfa:SPARK-18601","ref":"SPARK-18601","sha":"1ba1b444bb9be4caca48294b5310d80821d67190","user":{"login":"eyalfa","id":1131833,"avatar_url":"https://avatars.githubusercontent.com/u/1131833?v=3","gravatar_id":"","url":"https://api.github.com/users/eyalfa","html_url":"https://github.com/eyalfa","followers_url":"https://api.github.com/users/eyalfa/followers","following_url":"https://api.github.com/users/eyalfa/following{/other_user}","gists_url":"https://api.github.com/users/eyalfa/gists{/gist_id}","starred_url":"https://api.github.com/users/eyalfa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyalfa/subscriptions","organizations_url":"https://api.github.com/users/eyalfa/orgs","repos_url":"https://api.github.com/users/eyalfa/repos","events_url":"https://api.github.com/users/eyalfa/events{/privacy}","received_events_url":"https://api.github.com/users/eyalfa/received_events","type":"User","site_admin":false},"repo":{"id":64462239,"name":"spark","full_name":"eyalfa/spark","owner":{"login":"eyalfa","id":1131833,"avatar_url":"https://avatars.githubusercontent.com/u/1131833?v=3","gravatar_id":"","url":"https://api.github.com/users/eyalfa","html_url":"https://github.com/eyalfa","followers_url":"https://api.github.com/users/eyalfa/followers","following_url":"https://api.github.com/users/eyalfa/following{/other_user}","gists_url":"https://api.github.com/users/eyalfa/gists{/gist_id}","starred_url":"https://api.github.com/users/eyalfa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyalfa/subscriptions","organizations_url":"https://api.github.com/users/eyalfa/orgs","repos_url":"https://api.github.com/users/eyalfa/repos","events_url":"https://api.github.com/users/eyalfa/events{/privacy}","received_events_url":"https://api.github.com/users/eyalfa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eyalfa/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/eyalfa/spark","forks_url":"https://api.github.com/repos/eyalfa/spark/forks","keys_url":"https://api.github.com/repos/eyalfa/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eyalfa/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eyalfa/spark/teams","hooks_url":"https://api.github.com/repos/eyalfa/spark/hooks","issue_events_url":"https://api.github.com/repos/eyalfa/spark/issues/events{/number}","events_url":"https://api.github.com/repos/eyalfa/spark/events","assignees_url":"https://api.github.com/repos/eyalfa/spark/assignees{/user}","branches_url":"https://api.github.com/repos/eyalfa/spark/branches{/branch}","tags_url":"https://api.github.com/repos/eyalfa/spark/tags","blobs_url":"https://api.github.com/repos/eyalfa/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eyalfa/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eyalfa/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/eyalfa/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eyalfa/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/eyalfa/spark/languages","stargazers_url":"https://api.github.com/repos/eyalfa/spark/stargazers","contributors_url":"https://api.github.com/repos/eyalfa/spark/contributors","subscribers_url":"https://api.github.com/repos/eyalfa/spark/subscribers","subscription_url":"https://api.github.com/repos/eyalfa/spark/subscription","commits_url":"https://api.github.com/repos/eyalfa/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/eyalfa/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/eyalfa/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/eyalfa/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/eyalfa/spark/contents/{+path}","compare_url":"https://api.github.com/repos/eyalfa/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eyalfa/spark/merges","archive_url":"https://api.github.com/repos/eyalfa/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eyalfa/spark/downloads","issues_url":"https://api.github.com/repos/eyalfa/spark/issues{/number}","pulls_url":"https://api.github.com/repos/eyalfa/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/eyalfa/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/eyalfa/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eyalfa/spark/labels{/name}","releases_url":"https://api.github.com/repos/eyalfa/spark/releases{/id}","deployments_url":"https://api.github.com/repos/eyalfa/spark/deployments","created_at":"2016-07-29T07:57:28Z","updated_at":"2016-07-29T07:57:54Z","pushed_at":"2017-01-26T19:08:16Z","git_url":"git://github.com/eyalfa/spark.git","ssh_url":"[email protected]:eyalfa/spark.git","clone_url":"https://github.com/eyalfa/spark.git","svn_url":"https://github.com/eyalfa/spark","homepage":null,"size":257006,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"9f523d3192c71a728fd8a2a64f52bbc337f2f026","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2017-01-27T08:50:08Z","pushed_at":"2017-01-27T10:07:12Z","git_url":"git://github.com/apache/spark.git","ssh_url":"[email protected]:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":262442,"stargazers_count":11526,"watchers_count":11526,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10802,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":449,"forks":10802,"open_issues":449,"watchers":11526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/16043"},"html":{"href":"https://github.com/apache/spark/pull/16043"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/16043"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/16043/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/16043/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/16043/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/1ba1b444bb9be4caca48294b5310d80821d67190"}}}} | {
"id": 17165658,
"name": "apache/spark",
"url": "https://api.github.com/repos/apache/spark"
} | {
"id": 9616802,
"login": "hvanhovell",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9616802?",
"url": "https://api.github.com/users/hvanhovell"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-01-27T11:34:28 | 5223300385 | {"actor":{"display_login":"hvanhovell"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/vxquery/pulls/comments/130418889","pull_request_review_id":53291206,"id":130418889,"diff_hunk":"@@ -0,0 +1,243 @@\n+/*","path":"vxquery-server/src/test/java/org/apache/vxquery/rest/SuccessResponseTest.java","position":1,"original_position":1,"commit_id":"2389756d456f42f7ccd566d51300ce9d7755be67","original_commit_id":"2389756d456f42f7ccd566d51300ce9d7755be67","user":{"login":"prestoncarman","id":3517157,"avatar_url":"https://avatars3.githubusercontent.com/u/3517157?v=4","gravatar_id":"","url":"https://api.github.com/users/prestoncarman","html_url":"https://github.com/prestoncarman","followers_url":"https://api.github.com/users/prestoncarman/followers","following_url":"https://api.github.com/users/prestoncarman/following{/other_user}","gists_url":"https://api.github.com/users/prestoncarman/gists{/gist_id}","starred_url":"https://api.github.com/users/prestoncarman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestoncarman/subscriptions","organizations_url":"https://api.github.com/users/prestoncarman/orgs","repos_url":"https://api.github.com/users/prestoncarman/repos","events_url":"https://api.github.com/users/prestoncarman/events{/privacy}","received_events_url":"https://api.github.com/users/prestoncarman/received_events","type":"User","site_admin":false},"body":"These test seems like REST only tests and should be in the REST project.","created_at":"2017-07-31T18:10:53Z","updated_at":"2017-07-31T18:43:45Z","html_url":"https://github.com/apache/vxquery/pull/172#discussion_r130418889","pull_request_url":"https://api.github.com/repos/apache/vxquery/pulls/172","_links":{"self":{"href":"https://api.github.com/repos/apache/vxquery/pulls/comments/130418889"},"html":{"href":"https://github.com/apache/vxquery/pull/172#discussion_r130418889"},"pull_request":{"href":"https://api.github.com/repos/apache/vxquery/pulls/172"}}},"pull_request":{"url":"https://api.github.com/repos/apache/vxquery/pulls/172","id":130057472,"html_url":"https://github.com/apache/vxquery/pull/172","diff_url":"https://github.com/apache/vxquery/pull/172.diff","patch_url":"https://github.com/apache/vxquery/pull/172.patch","issue_url":"https://api.github.com/repos/apache/vxquery/issues/172","number":172,"state":"open","locked":false,"title":"VXQuery-180 : RESTful API - Rest server implementation (GSoC 2017)","user":{"login":"erandiganepola","id":16080191,"avatar_url":"https://avatars0.githubusercontent.com/u/16080191?v=4","gravatar_id":"","url":"https://api.github.com/users/erandiganepola","html_url":"https://github.com/erandiganepola","followers_url":"https://api.github.com/users/erandiganepola/followers","following_url":"https://api.github.com/users/erandiganepola/following{/other_user}","gists_url":"https://api.github.com/users/erandiganepola/gists{/gist_id}","starred_url":"https://api.github.com/users/erandiganepola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erandiganepola/subscriptions","organizations_url":"https://api.github.com/users/erandiganepola/orgs","repos_url":"https://api.github.com/users/erandiganepola/repos","events_url":"https://api.github.com/users/erandiganepola/events{/privacy}","received_events_url":"https://api.github.com/users/erandiganepola/received_events","type":"User","site_admin":false},"body":"This PR contains the REST server implementation for [VXQuery-180](https://issues.apache.org/jira/browse/VXQUERY-180). It has been written on top of **hyracks-http**.\r\n\r\nI will be adding more test cases along with tests for complex queries in the coming week. Please review my code and provide me with your valuable feedback.\r\n\r\nThank you!","created_at":"2017-07-12T05:24:40Z","updated_at":"2017-07-31T18:43:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c61306fafd8193176cb7f18170f5170929635f60","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/vxquery/pulls/172/commits","review_comments_url":"https://api.github.com/repos/apache/vxquery/pulls/172/comments","review_comment_url":"https://api.github.com/repos/apache/vxquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/vxquery/issues/172/comments","statuses_url":"https://api.github.com/repos/apache/vxquery/statuses/2389756d456f42f7ccd566d51300ce9d7755be67","head":{"label":"erandiganepola:master","ref":"master","sha":"2389756d456f42f7ccd566d51300ce9d7755be67","user":{"login":"erandiganepola","id":16080191,"avatar_url":"https://avatars0.githubusercontent.com/u/16080191?v=4","gravatar_id":"","url":"https://api.github.com/users/erandiganepola","html_url":"https://github.com/erandiganepola","followers_url":"https://api.github.com/users/erandiganepola/followers","following_url":"https://api.github.com/users/erandiganepola/following{/other_user}","gists_url":"https://api.github.com/users/erandiganepola/gists{/gist_id}","starred_url":"https://api.github.com/users/erandiganepola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erandiganepola/subscriptions","organizations_url":"https://api.github.com/users/erandiganepola/orgs","repos_url":"https://api.github.com/users/erandiganepola/repos","events_url":"https://api.github.com/users/erandiganepola/events{/privacy}","received_events_url":"https://api.github.com/users/erandiganepola/received_events","type":"User","site_admin":false},"repo":{"id":86420357,"name":"vxquery","full_name":"erandiganepola/vxquery","owner":{"login":"erandiganepola","id":16080191,"avatar_url":"https://avatars0.githubusercontent.com/u/16080191?v=4","gravatar_id":"","url":"https://api.github.com/users/erandiganepola","html_url":"https://github.com/erandiganepola","followers_url":"https://api.github.com/users/erandiganepola/followers","following_url":"https://api.github.com/users/erandiganepola/following{/other_user}","gists_url":"https://api.github.com/users/erandiganepola/gists{/gist_id}","starred_url":"https://api.github.com/users/erandiganepola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erandiganepola/subscriptions","organizations_url":"https://api.github.com/users/erandiganepola/orgs","repos_url":"https://api.github.com/users/erandiganepola/repos","events_url":"https://api.github.com/users/erandiganepola/events{/privacy}","received_events_url":"https://api.github.com/users/erandiganepola/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erandiganepola/vxquery","description":"Mirror of Apache VXQuery","fork":true,"url":"https://api.github.com/repos/erandiganepola/vxquery","forks_url":"https://api.github.com/repos/erandiganepola/vxquery/forks","keys_url":"https://api.github.com/repos/erandiganepola/vxquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erandiganepola/vxquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erandiganepola/vxquery/teams","hooks_url":"https://api.github.com/repos/erandiganepola/vxquery/hooks","issue_events_url":"https://api.github.com/repos/erandiganepola/vxquery/issues/events{/number}","events_url":"https://api.github.com/repos/erandiganepola/vxquery/events","assignees_url":"https://api.github.com/repos/erandiganepola/vxquery/assignees{/user}","branches_url":"https://api.github.com/repos/erandiganepola/vxquery/branches{/branch}","tags_url":"https://api.github.com/repos/erandiganepola/vxquery/tags","blobs_url":"https://api.github.com/repos/erandiganepola/vxquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erandiganepola/vxquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erandiganepola/vxquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/erandiganepola/vxquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erandiganepola/vxquery/statuses/{sha}","languages_url":"https://api.github.com/repos/erandiganepola/vxquery/languages","stargazers_url":"https://api.github.com/repos/erandiganepola/vxquery/stargazers","contributors_url":"https://api.github.com/repos/erandiganepola/vxquery/contributors","subscribers_url":"https://api.github.com/repos/erandiganepola/vxquery/subscribers","subscription_url":"https://api.github.com/repos/erandiganepola/vxquery/subscription","commits_url":"https://api.github.com/repos/erandiganepola/vxquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/erandiganepola/vxquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/erandiganepola/vxquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/erandiganepola/vxquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/erandiganepola/vxquery/contents/{+path}","compare_url":"https://api.github.com/repos/erandiganepola/vxquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erandiganepola/vxquery/merges","archive_url":"https://api.github.com/repos/erandiganepola/vxquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erandiganepola/vxquery/downloads","issues_url":"https://api.github.com/repos/erandiganepola/vxquery/issues{/number}","pulls_url":"https://api.github.com/repos/erandiganepola/vxquery/pulls{/number}","milestones_url":"https://api.github.com/repos/erandiganepola/vxquery/milestones{/number}","notifications_url":"https://api.github.com/repos/erandiganepola/vxquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erandiganepola/vxquery/labels{/name}","releases_url":"https://api.github.com/repos/erandiganepola/vxquery/releases{/id}","deployments_url":"https://api.github.com/repos/erandiganepola/vxquery/deployments","created_at":"2017-03-28T05:53:57Z","updated_at":"2017-06-27T00:18:00Z","pushed_at":"2017-07-30T08:47:17Z","git_url":"git://github.com/erandiganepola/vxquery.git","ssh_url":"[email protected]:erandiganepola/vxquery.git","clone_url":"https://github.com/erandiganepola/vxquery.git","svn_url":"https://github.com/erandiganepola/vxquery","homepage":null,"size":13943,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"4a38f670cd11231bd18a321cbacdd4f4e109b50a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":32376873,"name":"vxquery","full_name":"apache/vxquery","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/vxquery","description":"Mirror of Apache VXQuery","fork":false,"url":"https://api.github.com/repos/apache/vxquery","forks_url":"https://api.github.com/repos/apache/vxquery/forks","keys_url":"https://api.github.com/repos/apache/vxquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/vxquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/vxquery/teams","hooks_url":"https://api.github.com/repos/apache/vxquery/hooks","issue_events_url":"https://api.github.com/repos/apache/vxquery/issues/events{/number}","events_url":"https://api.github.com/repos/apache/vxquery/events","assignees_url":"https://api.github.com/repos/apache/vxquery/assignees{/user}","branches_url":"https://api.github.com/repos/apache/vxquery/branches{/branch}","tags_url":"https://api.github.com/repos/apache/vxquery/tags","blobs_url":"https://api.github.com/repos/apache/vxquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/vxquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/vxquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/vxquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/vxquery/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/vxquery/languages","stargazers_url":"https://api.github.com/repos/apache/vxquery/stargazers","contributors_url":"https://api.github.com/repos/apache/vxquery/contributors","subscribers_url":"https://api.github.com/repos/apache/vxquery/subscribers","subscription_url":"https://api.github.com/repos/apache/vxquery/subscription","commits_url":"https://api.github.com/repos/apache/vxquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/vxquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/vxquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/vxquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/vxquery/contents/{+path}","compare_url":"https://api.github.com/repos/apache/vxquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/vxquery/merges","archive_url":"https://api.github.com/repos/apache/vxquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/vxquery/downloads","issues_url":"https://api.github.com/repos/apache/vxquery/issues{/number}","pulls_url":"https://api.github.com/repos/apache/vxquery/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/vxquery/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/vxquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/vxquery/labels{/name}","releases_url":"https://api.github.com/repos/apache/vxquery/releases{/id}","deployments_url":"https://api.github.com/repos/apache/vxquery/deployments","created_at":"2015-03-17T07:00:06Z","updated_at":"2017-05-29T13:29:02Z","pushed_at":"2017-07-30T08:42:11Z","git_url":"git://github.com/apache/vxquery.git","ssh_url":"[email protected]:apache/vxquery.git","clone_url":"https://github.com/apache/vxquery.git","svn_url":"https://github.com/apache/vxquery","homepage":null,"size":10085,"stargazers_count":15,"watchers_count":15,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":"git://git.apache.org/vxquery.git","open_issues_count":8,"forks":24,"open_issues":8,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/vxquery/pulls/172"},"html":{"href":"https://github.com/apache/vxquery/pull/172"},"issue":{"href":"https://api.github.com/repos/apache/vxquery/issues/172"},"comments":{"href":"https://api.github.com/repos/apache/vxquery/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/vxquery/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/vxquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/vxquery/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/apache/vxquery/statuses/2389756d456f42f7ccd566d51300ce9d7755be67"}}}} | {
"id": 32376873,
"name": "apache/vxquery",
"url": "https://api.github.com/repos/apache/vxquery"
} | {
"id": 3517157,
"login": "prestoncarman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3517157?",
"url": "https://api.github.com/users/prestoncarman"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-07-31T18:10:53 | 6364029662 | {"actor":{"display_login":"prestoncarman"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/133075802","pull_request_review_id":56219407,"id":133075802,"diff_hunk":"@@ -82,6 +83,49 @@ class MultilayerPerceptronClassifierSuite\n }\n }\n \n+ test(\"strong dataset test\") {\n+ val layers = Array[Int](4, 5, 5, 2)\n+\n+ val strongDataset = Seq(\n+ (Vectors.dense(1, 2, 3, 4), 0d, Vectors.dense(1d, 0d)),\n+ (Vectors.dense(4, 3, 2, 1), 1d, Vectors.dense(0d, 1d)),\n+ (Vectors.dense(1, 1, 1, 1), 0d, Vectors.dense(.5, .5)),\n+ (Vectors.dense(1, 1, 1, 1), 1d, Vectors.dense(.5, .5))\n+ ).toDF(\"features\", \"label\", \"expectedProbability\")\n+ val trainer = new MultilayerPerceptronClassifier()\n+ .setLayers(layers)\n+ .setBlockSize(1)\n+ .setSeed(123L)\n+ .setMaxIter(100)\n+ .setSolver(\"l-bfgs\")\n+ val model = trainer.fit(strongDataset)\n+ val result = model.transform(strongDataset)\n+ model.setProbabilityCol(\"probability\")\n+ MLTestingUtils.checkCopyAndUids(trainer, model)\n+ // result.select(\"probability\").show(false)","path":"mllib/src/test/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifierSuite.scala","position":31,"original_position":31,"commit_id":"df7439eae0f2786ae66831d9de26b1ef63f92dc3","original_commit_id":"df7439eae0f2786ae66831d9de26b1ef63f92dc3","user":{"login":"jkbradley","id":5084283,"avatar_url":"https://avatars3.githubusercontent.com/u/5084283?v=4","gravatar_id":"","url":"https://api.github.com/users/jkbradley","html_url":"https://github.com/jkbradley","followers_url":"https://api.github.com/users/jkbradley/followers","following_url":"https://api.github.com/users/jkbradley/following{/other_user}","gists_url":"https://api.github.com/users/jkbradley/gists{/gist_id}","starred_url":"https://api.github.com/users/jkbradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkbradley/subscriptions","organizations_url":"https://api.github.com/users/jkbradley/orgs","repos_url":"https://api.github.com/users/jkbradley/repos","events_url":"https://api.github.com/users/jkbradley/events{/privacy}","received_events_url":"https://api.github.com/users/jkbradley/received_events","type":"User","site_admin":false},"body":"remove old comment","created_at":"2017-08-14T22:15:56Z","updated_at":"2017-08-14T22:58:37Z","html_url":"https://github.com/apache/spark/pull/17373#discussion_r133075802","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/17373","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/133075802"},"html":{"href":"https://github.com/apache/spark/pull/17373#discussion_r133075802"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/17373"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/17373","id":111728491,"html_url":"https://github.com/apache/spark/pull/17373","diff_url":"https://github.com/apache/spark/pull/17373.diff","patch_url":"https://github.com/apache/spark/pull/17373.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/17373","number":17373,"state":"open","locked":false,"title":"[SPARK-12664][ML] Expose probability in mlp model","user":{"login":"WeichenXu123","id":19235986,"avatar_url":"https://avatars0.githubusercontent.com/u/19235986?v=4","gravatar_id":"","url":"https://api.github.com/users/WeichenXu123","html_url":"https://github.com/WeichenXu123","followers_url":"https://api.github.com/users/WeichenXu123/followers","following_url":"https://api.github.com/users/WeichenXu123/following{/other_user}","gists_url":"https://api.github.com/users/WeichenXu123/gists{/gist_id}","starred_url":"https://api.github.com/users/WeichenXu123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WeichenXu123/subscriptions","organizations_url":"https://api.github.com/users/WeichenXu123/orgs","repos_url":"https://api.github.com/users/WeichenXu123/repos","events_url":"https://api.github.com/users/WeichenXu123/events{/privacy}","received_events_url":"https://api.github.com/users/WeichenXu123/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nModify MLP model to inherit `ProbabilisticClassificationModel` and so that it can expose the probability column when transforming data.\r\n\r\n## How was this patch tested?\r\n\r\nTest added.\r\n","created_at":"2017-03-21T08:54:39Z","updated_at":"2017-08-14T22:58:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7ca2b3472d47ff1d9b76274856b6abeaf52fc3c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/17373/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/17373/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/17373/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/df7439eae0f2786ae66831d9de26b1ef63f92dc3","head":{"label":"WeichenXu123:expose_probability_in_mlp_model","ref":"expose_probability_in_mlp_model","sha":"df7439eae0f2786ae66831d9de26b1ef63f92dc3","user":{"login":"WeichenXu123","id":19235986,"avatar_url":"https://avatars0.githubusercontent.com/u/19235986?v=4","gravatar_id":"","url":"https://api.github.com/users/WeichenXu123","html_url":"https://github.com/WeichenXu123","followers_url":"https://api.github.com/users/WeichenXu123/followers","following_url":"https://api.github.com/users/WeichenXu123/following{/other_user}","gists_url":"https://api.github.com/users/WeichenXu123/gists{/gist_id}","starred_url":"https://api.github.com/users/WeichenXu123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WeichenXu123/subscriptions","organizations_url":"https://api.github.com/users/WeichenXu123/orgs","repos_url":"https://api.github.com/users/WeichenXu123/repos","events_url":"https://api.github.com/users/WeichenXu123/events{/privacy}","received_events_url":"https://api.github.com/users/WeichenXu123/received_events","type":"User","site_admin":false},"repo":{"id":58255485,"name":"spark","full_name":"WeichenXu123/spark","owner":{"login":"WeichenXu123","id":19235986,"avatar_url":"https://avatars0.githubusercontent.com/u/19235986?v=4","gravatar_id":"","url":"https://api.github.com/users/WeichenXu123","html_url":"https://github.com/WeichenXu123","followers_url":"https://api.github.com/users/WeichenXu123/followers","following_url":"https://api.github.com/users/WeichenXu123/following{/other_user}","gists_url":"https://api.github.com/users/WeichenXu123/gists{/gist_id}","starred_url":"https://api.github.com/users/WeichenXu123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WeichenXu123/subscriptions","organizations_url":"https://api.github.com/users/WeichenXu123/orgs","repos_url":"https://api.github.com/users/WeichenXu123/repos","events_url":"https://api.github.com/users/WeichenXu123/events{/privacy}","received_events_url":"https://api.github.com/users/WeichenXu123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WeichenXu123/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/WeichenXu123/spark","forks_url":"https://api.github.com/repos/WeichenXu123/spark/forks","keys_url":"https://api.github.com/repos/WeichenXu123/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WeichenXu123/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WeichenXu123/spark/teams","hooks_url":"https://api.github.com/repos/WeichenXu123/spark/hooks","issue_events_url":"https://api.github.com/repos/WeichenXu123/spark/issues/events{/number}","events_url":"https://api.github.com/repos/WeichenXu123/spark/events","assignees_url":"https://api.github.com/repos/WeichenXu123/spark/assignees{/user}","branches_url":"https://api.github.com/repos/WeichenXu123/spark/branches{/branch}","tags_url":"https://api.github.com/repos/WeichenXu123/spark/tags","blobs_url":"https://api.github.com/repos/WeichenXu123/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WeichenXu123/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WeichenXu123/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/WeichenXu123/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WeichenXu123/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/WeichenXu123/spark/languages","stargazers_url":"https://api.github.com/repos/WeichenXu123/spark/stargazers","contributors_url":"https://api.github.com/repos/WeichenXu123/spark/contributors","subscribers_url":"https://api.github.com/repos/WeichenXu123/spark/subscribers","subscription_url":"https://api.github.com/repos/WeichenXu123/spark/subscription","commits_url":"https://api.github.com/repos/WeichenXu123/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/WeichenXu123/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/WeichenXu123/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/WeichenXu123/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/WeichenXu123/spark/contents/{+path}","compare_url":"https://api.github.com/repos/WeichenXu123/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WeichenXu123/spark/merges","archive_url":"https://api.github.com/repos/WeichenXu123/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WeichenXu123/spark/downloads","issues_url":"https://api.github.com/repos/WeichenXu123/spark/issues{/number}","pulls_url":"https://api.github.com/repos/WeichenXu123/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/WeichenXu123/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/WeichenXu123/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WeichenXu123/spark/labels{/name}","releases_url":"https://api.github.com/repos/WeichenXu123/spark/releases{/id}","deployments_url":"https://api.github.com/repos/WeichenXu123/spark/deployments","created_at":"2016-05-07T07:45:37Z","updated_at":"2016-05-07T07:45:59Z","pushed_at":"2017-08-13T11:04:52Z","git_url":"git://github.com/WeichenXu123/spark.git","ssh_url":"[email protected]:WeichenXu123/spark.git","clone_url":"https://github.com/WeichenXu123/spark.git","svn_url":"https://github.com/WeichenXu123/spark","homepage":null,"size":249488,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"979bf946d5fc7c15c2fdaa2e6c4df07bbbb74d93","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2017-08-14T21:38:57Z","pushed_at":"2017-08-14T22:08:20Z","git_url":"git://github.com/apache/spark.git","ssh_url":"[email protected]:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":258407,"stargazers_count":13916,"watchers_count":13916,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13095,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":382,"forks":13095,"open_issues":382,"watchers":13916,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/17373"},"html":{"href":"https://github.com/apache/spark/pull/17373"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/17373"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/17373/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/17373/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/17373/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/df7439eae0f2786ae66831d9de26b1ef63f92dc3"}}}} | {
"id": 17165658,
"name": "apache/spark",
"url": "https://api.github.com/repos/apache/spark"
} | {
"id": 5084283,
"login": "jkbradley",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5084283?",
"url": "https://api.github.com/users/jkbradley"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-08-14T22:15:56 | 6451386164 | {"actor":{"display_login":"jkbradley"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/121249656","pull_request_review_id":43262154,"id":121249656,"diff_hunk":"@@ -546,6 +546,42 @@ class LogValidatorTest {\n checkOffsets(messageWithOffset, offset)\n }\n \n+ @Test(expected = classOf[InvalidRecordException])\n+ def testInvalidRecordCountTooManyNonCompressedV2() {","path":"core/src/test/scala/unit/kafka/log/LogValidatorTest.scala","position":5,"original_position":5,"commit_id":"afc5bbbd6a08db198361d1b6f676ce771a7266cd","original_commit_id":"afc5bbbd6a08db198361d1b6f676ce771a7266cd","user":{"login":"hachikuji","id":12502538,"avatar_url":"https://avatars0.githubusercontent.com/u/12502538?v=3","gravatar_id":"","url":"https://api.github.com/users/hachikuji","html_url":"https://github.com/hachikuji","followers_url":"https://api.github.com/users/hachikuji/followers","following_url":"https://api.github.com/users/hachikuji/following{/other_user}","gists_url":"https://api.github.com/users/hachikuji/gists{/gist_id}","starred_url":"https://api.github.com/users/hachikuji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hachikuji/subscriptions","organizations_url":"https://api.github.com/users/hachikuji/orgs","repos_url":"https://api.github.com/users/hachikuji/repos","events_url":"https://api.github.com/users/hachikuji/events{/privacy}","received_events_url":"https://api.github.com/users/hachikuji/received_events","type":"User","site_admin":false},"body":"There doesn't seem to be any particular need to put this here instead of DefaultRecordBatchTest. If we move them, then we can avoid the awkwardness of exposing a public static method on a test class.","created_at":"2017-06-10T04:54:42Z","updated_at":"2017-06-10T05:03:54Z","html_url":"https://github.com/apache/kafka/pull/3156#discussion_r121249656","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/3156","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/121249656"},"html":{"href":"https://github.com/apache/kafka/pull/3156#discussion_r121249656"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/3156"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/3156","id":122713563,"html_url":"https://github.com/apache/kafka/pull/3156","diff_url":"https://github.com/apache/kafka/pull/3156.diff","patch_url":"https://github.com/apache/kafka/pull/3156.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/3156","number":3156,"state":"open","locked":false,"title":"KAFKA-5031: validate count of records for DefaultRecordBatch in validateMessagesAndAssignOffsets","user":{"login":"gosubpl","id":7828991,"avatar_url":"https://avatars3.githubusercontent.com/u/7828991?v=3","gravatar_id":"","url":"https://api.github.com/users/gosubpl","html_url":"https://github.com/gosubpl","followers_url":"https://api.github.com/users/gosubpl/followers","following_url":"https://api.github.com/users/gosubpl/following{/other_user}","gists_url":"https://api.github.com/users/gosubpl/gists{/gist_id}","starred_url":"https://api.github.com/users/gosubpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gosubpl/subscriptions","organizations_url":"https://api.github.com/users/gosubpl/orgs","repos_url":"https://api.github.com/users/gosubpl/repos","events_url":"https://api.github.com/users/gosubpl/events{/privacy}","received_events_url":"https://api.github.com/users/gosubpl/received_events","type":"User","site_admin":false},"body":"https://issues.apache.org/jira/browse/KAFKA-5031\r\n\r\nImplements additional check for `DefaultRecordBatch` that compares number of records declared in the header with actual number of records.","created_at":"2017-05-26T20:20:23Z","updated_at":"2017-06-10T05:03:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52d636a2ffc6b402452b84d79bab53cd0f2d796f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/3156/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/3156/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/3156/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/afc5bbbd6a08db198361d1b6f676ce771a7266cd","head":{"label":"gosubpl:KAFKA-5031","ref":"KAFKA-5031","sha":"afc5bbbd6a08db198361d1b6f676ce771a7266cd","user":{"login":"gosubpl","id":7828991,"avatar_url":"https://avatars3.githubusercontent.com/u/7828991?v=3","gravatar_id":"","url":"https://api.github.com/users/gosubpl","html_url":"https://github.com/gosubpl","followers_url":"https://api.github.com/users/gosubpl/followers","following_url":"https://api.github.com/users/gosubpl/following{/other_user}","gists_url":"https://api.github.com/users/gosubpl/gists{/gist_id}","starred_url":"https://api.github.com/users/gosubpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gosubpl/subscriptions","organizations_url":"https://api.github.com/users/gosubpl/orgs","repos_url":"https://api.github.com/users/gosubpl/repos","events_url":"https://api.github.com/users/gosubpl/events{/privacy}","received_events_url":"https://api.github.com/users/gosubpl/received_events","type":"User","site_admin":false},"repo":{"id":91688918,"name":"kafka","full_name":"gosubpl/kafka","owner":{"login":"gosubpl","id":7828991,"avatar_url":"https://avatars3.githubusercontent.com/u/7828991?v=3","gravatar_id":"","url":"https://api.github.com/users/gosubpl","html_url":"https://github.com/gosubpl","followers_url":"https://api.github.com/users/gosubpl/followers","following_url":"https://api.github.com/users/gosubpl/following{/other_user}","gists_url":"https://api.github.com/users/gosubpl/gists{/gist_id}","starred_url":"https://api.github.com/users/gosubpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gosubpl/subscriptions","organizations_url":"https://api.github.com/users/gosubpl/orgs","repos_url":"https://api.github.com/users/gosubpl/repos","events_url":"https://api.github.com/users/gosubpl/events{/privacy}","received_events_url":"https://api.github.com/users/gosubpl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gosubpl/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/gosubpl/kafka","forks_url":"https://api.github.com/repos/gosubpl/kafka/forks","keys_url":"https://api.github.com/repos/gosubpl/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gosubpl/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gosubpl/kafka/teams","hooks_url":"https://api.github.com/repos/gosubpl/kafka/hooks","issue_events_url":"https://api.github.com/repos/gosubpl/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/gosubpl/kafka/events","assignees_url":"https://api.github.com/repos/gosubpl/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/gosubpl/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/gosubpl/kafka/tags","blobs_url":"https://api.github.com/repos/gosubpl/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gosubpl/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gosubpl/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/gosubpl/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gosubpl/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/gosubpl/kafka/languages","stargazers_url":"https://api.github.com/repos/gosubpl/kafka/stargazers","contributors_url":"https://api.github.com/repos/gosubpl/kafka/contributors","subscribers_url":"https://api.github.com/repos/gosubpl/kafka/subscribers","subscription_url":"https://api.github.com/repos/gosubpl/kafka/subscription","commits_url":"https://api.github.com/repos/gosubpl/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/gosubpl/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/gosubpl/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/gosubpl/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/gosubpl/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/gosubpl/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gosubpl/kafka/merges","archive_url":"https://api.github.com/repos/gosubpl/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gosubpl/kafka/downloads","issues_url":"https://api.github.com/repos/gosubpl/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/gosubpl/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/gosubpl/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/gosubpl/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gosubpl/kafka/labels{/name}","releases_url":"https://api.github.com/repos/gosubpl/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/gosubpl/kafka/deployments","created_at":"2017-05-18T12:08:19Z","updated_at":"2017-05-18T12:08:28Z","pushed_at":"2017-06-09T09:09:20Z","git_url":"git://github.com/gosubpl/kafka.git","ssh_url":"[email protected]:gosubpl/kafka.git","clone_url":"https://github.com/gosubpl/kafka.git","svn_url":"https://github.com/gosubpl/kafka","homepage":null,"size":50277,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"5d7c8cc81af6cd2f209f8e5f3df784b9272830b9","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2017-06-10T04:21:09Z","pushed_at":"2017-06-10T01:21:29Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"[email protected]:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":50571,"stargazers_count":5366,"watchers_count":5366,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3330,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":362,"forks":3330,"open_issues":362,"watchers":5366,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/3156"},"html":{"href":"https://github.com/apache/kafka/pull/3156"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/3156"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/3156/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/3156/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/3156/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/afc5bbbd6a08db198361d1b6f676ce771a7266cd"}}}} | {
"id": 2211243,
"name": "apache/kafka",
"url": "https://api.github.com/repos/apache/kafka"
} | {
"id": 12502538,
"login": "hachikuji",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12502538?",
"url": "https://api.github.com/users/hachikuji"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-06-10T04:54:42 | 6039598619 | {"actor":{"display_login":"hachikuji"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/134460855","pull_request_review_id":57536634,"id":134460855,"diff_hunk":"@@ -0,0 +1,103 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements. See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership. The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.flink.runtime.rest;\n+\n+import org.apache.flink.configuration.RestOptions;\n+import org.apache.flink.configuration.Configuration;\n+import org.apache.flink.configuration.SecurityOptions;\n+import org.apache.flink.runtime.net.SSLUtils;\n+import org.apache.flink.util.ConfigurationException;\n+import org.apache.flink.util.Preconditions;\n+\n+import javax.net.ssl.SSLContext;\n+import javax.net.ssl.SSLEngine;\n+\n+/**\n+ * A configuration object for {@link RestServerEndpoint}s.\n+ */\n+public final class RestServerEndpointConfiguration {\n+\n+\tprivate final String restBindAddress;\n+\tprivate final int restBindPort;\n+\tprivate final SSLEngine sslEngine;\n+\n+\tprivate RestServerEndpointConfiguration(String restBindAddress, int targetRestEndpointPort, SSLEngine sslEngine) {\n+\t\tthis.restBindAddress = restBindAddress;\n+\t\tthis.restBindPort = targetRestEndpointPort;\n+\t\tthis.sslEngine = sslEngine;","path":"flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestServerEndpointConfiguration.java","position":43,"original_position":43,"commit_id":"9763c95750a12810223f0ccaa0c7ca169a645d5c","original_commit_id":"61988d8060dab1084b29c61f40cee356783cb8b5","user":{"login":"tillrohrmann","id":5756858,"avatar_url":"https://avatars1.githubusercontent.com/u/5756858?v=4","gravatar_id":"","url":"https://api.github.com/users/tillrohrmann","html_url":"https://github.com/tillrohrmann","followers_url":"https://api.github.com/users/tillrohrmann/followers","following_url":"https://api.github.com/users/tillrohrmann/following{/other_user}","gists_url":"https://api.github.com/users/tillrohrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillrohrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillrohrmann/subscriptions","organizations_url":"https://api.github.com/users/tillrohrmann/orgs","repos_url":"https://api.github.com/users/tillrohrmann/repos","events_url":"https://api.github.com/users/tillrohrmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillrohrmann/received_events","type":"User","site_admin":false},"body":"`Preconditions.checkNotNull` missing","created_at":"2017-08-22T12:10:39Z","updated_at":"2017-08-22T12:42:35Z","html_url":"https://github.com/apache/flink/pull/4569#discussion_r134460855","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/4569","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/134460855"},"html":{"href":"https://github.com/apache/flink/pull/4569#discussion_r134460855"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/4569"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/4569","id":136772955,"html_url":"https://github.com/apache/flink/pull/4569","diff_url":"https://github.com/apache/flink/pull/4569.diff","patch_url":"https://github.com/apache/flink/pull/4569.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/4569","number":4569,"state":"open","locked":false,"title":"[FLINK-7040] [REST] Add basics for REST communication","user":{"login":"zentol","id":5725237,"avatar_url":"https://avatars1.githubusercontent.com/u/5725237?v=4","gravatar_id":"","url":"https://api.github.com/users/zentol","html_url":"https://github.com/zentol","followers_url":"https://api.github.com/users/zentol/followers","following_url":"https://api.github.com/users/zentol/following{/other_user}","gists_url":"https://api.github.com/users/zentol/gists{/gist_id}","starred_url":"https://api.github.com/users/zentol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zentol/subscriptions","organizations_url":"https://api.github.com/users/zentol/orgs","repos_url":"https://api.github.com/users/zentol/repos","events_url":"https://api.github.com/users/zentol/events{/privacy}","received_events_url":"https://api.github.com/users/zentol/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\n\r\nThis PR implements the fundamentals for generic Client/Server REST communication that will be used for the client/cluster communication, the WebRuntimeMonitor and queryable state.\r\n\r\n#### Endpoints\r\n\r\n`Endpoints` are the main runtime component that have to be started before any communication can happen. Their primary purpose is setting up the underlying netty stack.\r\n\r\nThe `RestClientEndpoint` is a fully-functional class that provides an asynchronous API for sending requests/receiving responses based around `CompleteFutures`. Requests are sent in a synchronous fashion; a new request is only sent out after a response was received for the previous request (for simplicity).\r\n\r\nThe `RestServerEndpoint` is an abstract class that is very similar to the `WebRuntimeMonitor`. Implementations have to implement a single method `abstract Collection<? extends AbstractRestHandler<?, ?>> initializeHandlers();` that returns a collection of handlers that should be registered.\r\n\r\n#### Messages\r\n\r\nTo send a request the client accepts 3 arguments:\r\n* a `MessageHeaders`\r\n* a `RequestBody`\r\n* a `ParameterMapper`\r\n\r\n`RequestBodies` represent the http message body, and will be converted to JSON using jackson-databind.\r\n\r\n`ParameterMappers` are used to assemble the final url, including query and path parameters\r\n\r\n`MessageHeaders` are stateless objects that define a link between requests and responses as well as provide meta-data about the communication for this particular pair. Headers have generic type arguments for requests and responses and provide some level of type-safeness; if the client and server use the same headers class the request/response type, url, http status codes etc. are all well-defined.\r\nEssentially, headers provide a tight coupling between handlers, clients, requests and responses (provided that implementations don't define arbitrary headers on the fly).\r\n\r\nFor example, to define the communication for submitting a job one would define a `JobSubmitRequestBody` that contains the serialized job graph, a `JobSubmitResponseBody` containing the URL to track the job status and a `JobSubmitHeaders` class that define the HTTP method (POST), the url (e.g `/submit`, the response http status code (ACCEPTED).\r\n\r\n#### Handlers\r\n\r\nSomeone has to deal with requests and send out responses, which is where the `AbstractRestHandler` comes into play. This is an abstract class that manages all the netty stuff, and, just like the `MessageHeaders`, has generic type arguments for a `RequestBody` and `ResponseBody`. Only a single method must be implemented, which accepts a request and returns a response: `abstract CompletableFuture<HandlerResponse<P>> handleRequest(@Nonnull HandlerRequest<R> request);`\r\n\r\nA `HandlerRequest` contains a `RequestBody` and maps for path/query parameters.\r\nA `HandlerResponse` contains either a `ResponseBody`, or an `ErrorResponse`.\r\n\r\n## Brief change log\r\n\r\n - Add `MessageHeaders`, `Request-/ResponseBody` for modeling messages\r\n - Add `AbstractRestHandler`, `HandlerRequest/-Response` for message processing\r\n - Add `RestClient-/-ServerEndpoint` that setup netty\r\n\r\n## Verifying this change\r\n\r\nThis change added tests.\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n - Dependencies (does it add or upgrade a dependency): (no)\r\n - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)\r\n - The serializers: no)\r\n - The runtime per-record code paths (performance sensitive): (no)\r\n - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)\r\n\r\n## Documentation\r\n\r\n - Does this pull request introduce a new feature? (no)\r\n - If yes, how is the feature documented? (not applicable)\r\n\r\n","created_at":"2017-08-21T14:35:08Z","updated_at":"2017-08-22T12:42:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4588bfbfdb063ecd67c2df848f801db6d35fb3c4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/4569/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/4569/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/4569/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/9763c95750a12810223f0ccaa0c7ca169a645d5c","head":{"label":"zentol:rest_client_final","ref":"rest_client_final","sha":"9763c95750a12810223f0ccaa0c7ca169a645d5c","user":{"login":"zentol","id":5725237,"avatar_url":"https://avatars1.githubusercontent.com/u/5725237?v=4","gravatar_id":"","url":"https://api.github.com/users/zentol","html_url":"https://github.com/zentol","followers_url":"https://api.github.com/users/zentol/followers","following_url":"https://api.github.com/users/zentol/following{/other_user}","gists_url":"https://api.github.com/users/zentol/gists{/gist_id}","starred_url":"https://api.github.com/users/zentol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zentol/subscriptions","organizations_url":"https://api.github.com/users/zentol/orgs","repos_url":"https://api.github.com/users/zentol/repos","events_url":"https://api.github.com/users/zentol/events{/privacy}","received_events_url":"https://api.github.com/users/zentol/received_events","type":"User","site_admin":false},"repo":{"id":20647396,"name":"flink","full_name":"zentol/flink","owner":{"login":"zentol","id":5725237,"avatar_url":"https://avatars1.githubusercontent.com/u/5725237?v=4","gravatar_id":"","url":"https://api.github.com/users/zentol","html_url":"https://github.com/zentol","followers_url":"https://api.github.com/users/zentol/followers","following_url":"https://api.github.com/users/zentol/following{/other_user}","gists_url":"https://api.github.com/users/zentol/gists{/gist_id}","starred_url":"https://api.github.com/users/zentol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zentol/subscriptions","organizations_url":"https://api.github.com/users/zentol/orgs","repos_url":"https://api.github.com/users/zentol/repos","events_url":"https://api.github.com/users/zentol/events{/privacy}","received_events_url":"https://api.github.com/users/zentol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zentol/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/zentol/flink","forks_url":"https://api.github.com/repos/zentol/flink/forks","keys_url":"https://api.github.com/repos/zentol/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zentol/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zentol/flink/teams","hooks_url":"https://api.github.com/repos/zentol/flink/hooks","issue_events_url":"https://api.github.com/repos/zentol/flink/issues/events{/number}","events_url":"https://api.github.com/repos/zentol/flink/events","assignees_url":"https://api.github.com/repos/zentol/flink/assignees{/user}","branches_url":"https://api.github.com/repos/zentol/flink/branches{/branch}","tags_url":"https://api.github.com/repos/zentol/flink/tags","blobs_url":"https://api.github.com/repos/zentol/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zentol/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zentol/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/zentol/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zentol/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/zentol/flink/languages","stargazers_url":"https://api.github.com/repos/zentol/flink/stargazers","contributors_url":"https://api.github.com/repos/zentol/flink/contributors","subscribers_url":"https://api.github.com/repos/zentol/flink/subscribers","subscription_url":"https://api.github.com/repos/zentol/flink/subscription","commits_url":"https://api.github.com/repos/zentol/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/zentol/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/zentol/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/zentol/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/zentol/flink/contents/{+path}","compare_url":"https://api.github.com/repos/zentol/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zentol/flink/merges","archive_url":"https://api.github.com/repos/zentol/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zentol/flink/downloads","issues_url":"https://api.github.com/repos/zentol/flink/issues{/number}","pulls_url":"https://api.github.com/repos/zentol/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/zentol/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/zentol/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zentol/flink/labels{/name}","releases_url":"https://api.github.com/repos/zentol/flink/releases{/id}","deployments_url":"https://api.github.com/repos/zentol/flink/deployments","created_at":"2014-06-09T13:27:33Z","updated_at":"2016-10-28T13:45:08Z","pushed_at":"2017-08-22T12:29:51Z","git_url":"git://github.com/zentol/flink.git","ssh_url":"[email protected]:zentol/flink.git","clone_url":"https://github.com/zentol/flink.git","svn_url":"https://github.com/zentol/flink","homepage":null,"size":127612,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"9077e5169d28efc701ca49cbc6a30df1e33b416b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2017-08-22T12:04:36Z","pushed_at":"2017-08-22T12:29:53Z","git_url":"git://github.com/apache/flink.git","ssh_url":"[email protected]:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":132090,"stargazers_count":2629,"watchers_count":2629,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1830,"mirror_url":"git://git.apache.org/flink.git","open_issues_count":276,"forks":1830,"open_issues":276,"watchers":2629,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/4569"},"html":{"href":"https://github.com/apache/flink/pull/4569"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/4569"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/4569/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/4569/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/4569/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/9763c95750a12810223f0ccaa0c7ca169a645d5c"}}}} | {
"id": 20587599,
"name": "apache/flink",
"url": "https://api.github.com/repos/apache/flink"
} | {
"id": 5756858,
"login": "tillrohrmann",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5756858?",
"url": "https://api.github.com/users/tillrohrmann"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-08-22T12:10:39 | 6497055636 | {"actor":{"display_login":"tillrohrmann"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/152410159","pull_request_review_id":78269126,"id":152410159,"diff_hunk":"@@ -63,87 +78,123 @@ public InternalTopicManager(final StreamsKafkaClient streamsKafkaClient,\n * If a topic with the correct number of partitions exists ignores it.\n * If a topic exists already but has different number of partitions we fail and throw exception requesting user to reset the app before restarting again.\n */\n- public void makeReady(final Map<InternalTopicConfig, Integer> topics) {\n- for (int i = 0; i < MAX_TOPIC_READY_TRY; i++) {\n- try {\n- final MetadataResponse metadata = streamsKafkaClient.fetchMetadata();\n- final Map<String, Integer> existingTopicPartitions = fetchExistingPartitionCountByTopic(metadata);\n- final Map<InternalTopicConfig, Integer> topicsToBeCreated = validateTopicPartitions(topics, existingTopicPartitions);\n- if (topicsToBeCreated.size() > 0) {\n- if (metadata.brokers().size() < replicationFactor) {\n- throw new StreamsException(\"Found only \" + metadata.brokers().size() + \" brokers, \" +\n- \" but replication factor is \" + replicationFactor + \".\" +\n- \" Decrease replication factor for internal topics via StreamsConfig parameter \\\"replication.factor\\\"\" +\n- \" or add more brokers to your cluster.\");\n- }\n- streamsKafkaClient.createTopics(topicsToBeCreated, replicationFactor, windowChangeLogAdditionalRetention, metadata);\n+ public void makeReady(final Map<String, InternalTopicConfig> topics) {\n+ final Map<String, Integer> existingTopicPartitions = getNumPartitions(topics.keySet(), true);\n+ final Set<InternalTopicConfig> topicsToBeCreated = validateTopicPartitions(topics.values(), existingTopicPartitions);\n+ if (topicsToBeCreated.size() > 0) {\n+ final Set<NewTopic> newTopics = new HashSet<>();\n+\n+ for (final InternalTopicConfig internalTopicConfig : topicsToBeCreated) {\n+ final Properties topicProperties = internalTopicConfig.toProperties(windowChangeLogAdditionalRetention);\n+ final Map<String, String> topicConfig = new HashMap<>(defaultTopicConfigs);\n+ for (final String key : topicProperties.stringPropertyNames()) {\n+ topicConfig.put(key, topicProperties.getProperty(key));\n }\n- return;\n- } catch (StreamsException ex) {\n- log.warn(\"Could not create internal topics: {} Retry #{}\", ex.getMessage(), i);\n+ newTopics.add(\n+ new NewTopic(\n+ internalTopicConfig.name(),\n+ internalTopicConfig.numberOfPartitions(),\n+ replicationFactor)\n+ .configs(topicConfig));\n }\n- // backoff\n- time.sleep(100L);\n+\n+ final CreateTopicsResult createTopicsResult = adminClient.createTopics(newTopics);\n+\n+ final Map<String, KafkaFuture<Void>> createTopicResults = createTopicsResult.values();\n+ for (final Map.Entry<String, KafkaFuture<Void>> createTopicResult : createTopicResults.entrySet()) {\n+ try {\n+ createTopicResult.getValue().get();\n+ } catch (final ExecutionException couldNotCreateTopic) {\n+ final String topicName = createTopicResult.getKey();\n+ verifyIfTopicExistsWithCorrectNumberOfPartitions(topicName, topics.get(topicName));\n+ } catch (final InterruptedException fatalException) {\n+ final String error = \"Could not create internal topics.\";\n+ log.error(error, fatalException);\n+ throw new StreamsException(error, fatalException);\n+ }\n+ }\n+ }\n+ }\n+\n+ private void verifyIfTopicExistsWithCorrectNumberOfPartitions(final String topic,\n+ final InternalTopicConfig expectedNumberOfPartitions) {\n+ final Map<String, Integer> existingTopicPartitions = getNumPartitions(Collections.singleton(topic));\n+ if (validateTopicPartitions(Collections.singleton(expectedNumberOfPartitions), existingTopicPartitions).size() != 0) {\n+ log.error(\"Could neither create topic {} nor receive any metadata about it.\", topic);\n+ throw new StreamsException(String.format(\"Could neither create topic %s nor receive any metadata about it.\", topic));\n }\n- throw new StreamsException(\"Could not create internal topics.\");\n }\n \n /**\n * Get the number of partitions for the given topics\n */\n public Map<String, Integer> getNumPartitions(final Set<String> topics) {\n- for (int i = 0; i < MAX_TOPIC_READY_TRY; i++) {\n- try {\n- final MetadataResponse metadata = streamsKafkaClient.fetchMetadata();\n- final Map<String, Integer> existingTopicPartitions = fetchExistingPartitionCountByTopic(metadata);\n- existingTopicPartitions.keySet().retainAll(topics);\n-\n- return existingTopicPartitions;\n- } catch (StreamsException ex) {\n- log.warn(\"Could not get number of partitions: {} Retry #{}\", ex.getMessage(), i);\n+ return getNumPartitions(topics, false);\n+ }\n+\n+ private Map<String, Integer> getNumPartitions(final Set<String> topics,\n+ final boolean bestEffort) {\n+ try {\n+ final DescribeTopicsResult describeTopicsResult = adminClient.describeTopics(topics);\n+ final Map<String, KafkaFuture<TopicDescription>> futures = describeTopicsResult.values();\n+\n+ final Map<String, Integer> existingTopicPartitions = new HashMap<>();\n+ for (final Map.Entry<String, KafkaFuture<TopicDescription>> topicFuture : futures.entrySet()) {\n+ try {\n+ final TopicDescription topicDescription = topicFuture.getValue().get();\n+ existingTopicPartitions.put(\n+ topicFuture.getKey(),\n+ topicDescription.partitions().size());\n+ } catch (final ExecutionException topicDoesNotExist) {\n+ if (bestEffort) {\n+ log.warn(\"Could not get number of partitions for topic {}. Topic might not exists: {}\",\n+ topicFuture.getKey(),\n+ topicDoesNotExist.getMessage());\n+ } else {\n+ throw topicDoesNotExist;\n+ }\n+ }\n }\n- // backoff\n- time.sleep(100L);\n+\n+ return existingTopicPartitions;\n+ } catch (final Exception fatalException) {\n+ final String error = \"Could not get number of partitions from brokers. \" +\n+ \"This can happen if the Kafka cluster is temporary not available. \" +\n+ \"You can increase admin client config `retries` to be resilient against this error.\";\n+ log.error(error, fatalException);\n+ throw new StreamsException(error, fatalException);\n }\n- throw new StreamsException(\"Could not get number of partitions.\");\n }\n \n public void close() {\n- streamsKafkaClient.close();\n+ adminClient.close();\n }\n \n /**\n * Check the existing topics to have correct number of partitions; and return the non existing topics to be created\n */\n- private Map<InternalTopicConfig, Integer> validateTopicPartitions(final Map<InternalTopicConfig, Integer> topicsPartitionsMap,\n- final Map<String, Integer> existingTopicNamesPartitions) {\n- final Map<InternalTopicConfig, Integer> topicsToBeCreated = new HashMap<>();\n- for (Map.Entry<InternalTopicConfig, Integer> entry : topicsPartitionsMap.entrySet()) {\n- InternalTopicConfig topic = entry.getKey();\n- Integer partition = entry.getValue();\n+ private Set<InternalTopicConfig> validateTopicPartitions(final Collection<InternalTopicConfig> topicsPartitionsMap,\n+ final Map<String, Integer> existingTopicNamesPartitions) {\n+ final Set<InternalTopicConfig> topicsToBeCreated = new HashSet<>();\n+ for (final InternalTopicConfig topic : topicsPartitionsMap) {\n+ final Integer numberOfPartitions = topic.numberOfPartitions();\n if (existingTopicNamesPartitions.containsKey(topic.name())) {\n- if (!existingTopicNamesPartitions.get(topic.name()).equals(partition)) {\n- throw new StreamsException(\"Existing internal topic \" + topic.name() + \" has invalid partitions.\" +\n- \" Expected: \" + partition + \" Actual: \" + existingTopicNamesPartitions.get(topic.name()) +\n- \". Use 'kafka.tools.StreamsResetter' tool to clean up invalid topics before processing.\");\n+ if (!existingTopicNamesPartitions.get(topic.name()).equals(numberOfPartitions)) {\n+ log.error(\"Existing internal topic {} has invalid partitions: expected: {}; actual: {}. \" +","path":"streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java","position":224,"original_position":224,"commit_id":"512627347895d4c19452001f40b63825acdf97dc","original_commit_id":"512627347895d4c19452001f40b63825acdf97dc","user":{"login":"bbejeck","id":199238,"avatar_url":"https://avatars3.githubusercontent.com/u/199238?v=4","gravatar_id":"","url":"https://api.github.com/users/bbejeck","html_url":"https://github.com/bbejeck","followers_url":"https://api.github.com/users/bbejeck/followers","following_url":"https://api.github.com/users/bbejeck/following{/other_user}","gists_url":"https://api.github.com/users/bbejeck/gists{/gist_id}","starred_url":"https://api.github.com/users/bbejeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbejeck/subscriptions","organizations_url":"https://api.github.com/users/bbejeck/orgs","repos_url":"https://api.github.com/users/bbejeck/repos","events_url":"https://api.github.com/users/bbejeck/events{/privacy}","received_events_url":"https://api.github.com/users/bbejeck/received_events","type":"User","site_admin":false},"body":"maybe use `String.format` first and use for both the `log.error` and the exception message","created_at":"2017-11-21T21:44:36Z","updated_at":"2017-11-21T21:44:36Z","html_url":"https://github.com/apache/kafka/pull/4242#discussion_r152410159","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/4242","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/152410159"},"html":{"href":"https://github.com/apache/kafka/pull/4242#discussion_r152410159"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/4242"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/4242","id":153781867,"html_url":"https://github.com/apache/kafka/pull/4242","diff_url":"https://github.com/apache/kafka/pull/4242.diff","patch_url":"https://github.com/apache/kafka/pull/4242.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/4242","number":4242,"state":"open","locked":false,"title":"KAFKA-4857: [WIP] Replace StreamsKafkaClient with AdminClient in Kafka Streams","user":{"login":"mjsax","id":8959638,"avatar_url":"https://avatars1.githubusercontent.com/u/8959638?v=4","gravatar_id":"","url":"https://api.github.com/users/mjsax","html_url":"https://github.com/mjsax","followers_url":"https://api.github.com/users/mjsax/followers","following_url":"https://api.github.com/users/mjsax/following{/other_user}","gists_url":"https://api.github.com/users/mjsax/gists{/gist_id}","starred_url":"https://api.github.com/users/mjsax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjsax/subscriptions","organizations_url":"https://api.github.com/users/mjsax/orgs","repos_url":"https://api.github.com/users/mjsax/repos","events_url":"https://api.github.com/users/mjsax/events{/privacy}","received_events_url":"https://api.github.com/users/mjsax/received_events","type":"User","site_admin":false},"body":"### Committer Checklist (excluded from commit message)\r\n- [ ] Verify design and implementation \r\n- [ ] Verify test coverage and CI build status\r\n- [ ] Verify documentation (including upgrade notes)\r\n","created_at":"2017-11-21T02:19:17Z","updated_at":"2017-11-21T21:44:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe146cc98eda42f6944fc403b3b1f0a4b69458a4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/4242/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/4242/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/4242/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/512627347895d4c19452001f40b63825acdf97dc","head":{"label":"mjsax:kafka-4857-admit-client","ref":"kafka-4857-admit-client","sha":"512627347895d4c19452001f40b63825acdf97dc","user":{"login":"mjsax","id":8959638,"avatar_url":"https://avatars1.githubusercontent.com/u/8959638?v=4","gravatar_id":"","url":"https://api.github.com/users/mjsax","html_url":"https://github.com/mjsax","followers_url":"https://api.github.com/users/mjsax/followers","following_url":"https://api.github.com/users/mjsax/following{/other_user}","gists_url":"https://api.github.com/users/mjsax/gists{/gist_id}","starred_url":"https://api.github.com/users/mjsax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjsax/subscriptions","organizations_url":"https://api.github.com/users/mjsax/orgs","repos_url":"https://api.github.com/users/mjsax/repos","events_url":"https://api.github.com/users/mjsax/events{/privacy}","received_events_url":"https://api.github.com/users/mjsax/received_events","type":"User","site_admin":false},"repo":{"id":50839421,"name":"kafka","full_name":"mjsax/kafka","owner":{"login":"mjsax","id":8959638,"avatar_url":"https://avatars1.githubusercontent.com/u/8959638?v=4","gravatar_id":"","url":"https://api.github.com/users/mjsax","html_url":"https://github.com/mjsax","followers_url":"https://api.github.com/users/mjsax/followers","following_url":"https://api.github.com/users/mjsax/following{/other_user}","gists_url":"https://api.github.com/users/mjsax/gists{/gist_id}","starred_url":"https://api.github.com/users/mjsax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjsax/subscriptions","organizations_url":"https://api.github.com/users/mjsax/orgs","repos_url":"https://api.github.com/users/mjsax/repos","events_url":"https://api.github.com/users/mjsax/events{/privacy}","received_events_url":"https://api.github.com/users/mjsax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjsax/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/mjsax/kafka","forks_url":"https://api.github.com/repos/mjsax/kafka/forks","keys_url":"https://api.github.com/repos/mjsax/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjsax/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjsax/kafka/teams","hooks_url":"https://api.github.com/repos/mjsax/kafka/hooks","issue_events_url":"https://api.github.com/repos/mjsax/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/mjsax/kafka/events","assignees_url":"https://api.github.com/repos/mjsax/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/mjsax/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/mjsax/kafka/tags","blobs_url":"https://api.github.com/repos/mjsax/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjsax/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjsax/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjsax/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjsax/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/mjsax/kafka/languages","stargazers_url":"https://api.github.com/repos/mjsax/kafka/stargazers","contributors_url":"https://api.github.com/repos/mjsax/kafka/contributors","subscribers_url":"https://api.github.com/repos/mjsax/kafka/subscribers","subscription_url":"https://api.github.com/repos/mjsax/kafka/subscription","commits_url":"https://api.github.com/repos/mjsax/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjsax/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjsax/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjsax/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjsax/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/mjsax/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjsax/kafka/merges","archive_url":"https://api.github.com/repos/mjsax/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjsax/kafka/downloads","issues_url":"https://api.github.com/repos/mjsax/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/mjsax/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/mjsax/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/mjsax/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjsax/kafka/labels{/name}","releases_url":"https://api.github.com/repos/mjsax/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/mjsax/kafka/deployments","created_at":"2016-02-01T12:57:30Z","updated_at":"2016-02-01T12:57:34Z","pushed_at":"2017-11-21T19:56:38Z","git_url":"git://github.com/mjsax/kafka.git","ssh_url":"[email protected]:mjsax/kafka.git","clone_url":"https://github.com/mjsax/kafka.git","svn_url":"https://github.com/mjsax/kafka","homepage":null,"size":57638,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"e3c32391f95d82a217295c7e4c1519981124bc3f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2017-11-21T16:57:14Z","pushed_at":"2017-11-21T19:56:39Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"[email protected]:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":59779,"stargazers_count":6720,"watchers_count":6720,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4079,"mirror_url":"git://git.apache.org/kafka.git","archived":false,"open_issues_count":489,"forks":4079,"open_issues":489,"watchers":6720,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/4242"},"html":{"href":"https://github.com/apache/kafka/pull/4242"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/4242"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/4242/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/4242/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/4242/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/512627347895d4c19452001f40b63825acdf97dc"}},"author_association":"CONTRIBUTOR"}} | {
"id": 2211243,
"name": "apache/kafka",
"url": "https://api.github.com/repos/apache/kafka"
} | {
"id": 199238,
"login": "bbejeck",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/199238?",
"url": "https://api.github.com/users/bbejeck"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-11-21T21:44:36 | 6887041262 | {"actor":{"display_login":"bbejeck"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/james-project/pulls/comments/125833884","pull_request_review_id":48259598,"id":125833884,"diff_hunk":"@@ -139,6 +139,12 @@ public void lookupDeleteMailboxShouldReturnEnumValue() {\n }\n \n @Test\n+ public void lookupImportEmlFileToMailboxShouldReturnEnumValue() {\n+ assertThat(CmdType.lookup(\"ImportEmlFileToMailbox\"))","path":"server/container/cli/src/test/java/org/apache/james/cli/type/CmdTypeTest.java","position":5,"original_position":5,"commit_id":"9db7fb984e2e3471e7eed40476a36b35e942889f","original_commit_id":"9db7fb984e2e3471e7eed40476a36b35e942889f","user":{"login":"ilkerceng","id":4923344,"avatar_url":"https://avatars2.githubusercontent.com/u/4923344?v=3","gravatar_id":"","url":"https://api.github.com/users/ilkerceng","html_url":"https://github.com/ilkerceng","followers_url":"https://api.github.com/users/ilkerceng/followers","following_url":"https://api.github.com/users/ilkerceng/following{/other_user}","gists_url":"https://api.github.com/users/ilkerceng/gists{/gist_id}","starred_url":"https://api.github.com/users/ilkerceng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilkerceng/subscriptions","organizations_url":"https://api.github.com/users/ilkerceng/orgs","repos_url":"https://api.github.com/users/ilkerceng/repos","events_url":"https://api.github.com/users/ilkerceng/events{/privacy}","received_events_url":"https://api.github.com/users/ilkerceng/received_events","type":"User","site_admin":false},"body":"hmm, what is your last decision for that :) should i change the name \"importEmlFileToMailbox\" as importEml for all occurences ","created_at":"2017-07-06T08:00:52Z","updated_at":"2017-07-06T08:00:52Z","html_url":"https://github.com/apache/james-project/pull/69#discussion_r125833884","pull_request_url":"https://api.github.com/repos/apache/james-project/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/apache/james-project/pulls/comments/125833884"},"html":{"href":"https://github.com/apache/james-project/pull/69#discussion_r125833884"},"pull_request":{"href":"https://api.github.com/repos/apache/james-project/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/apache/james-project/pulls/69","id":128897636,"html_url":"https://github.com/apache/james-project/pull/69","diff_url":"https://github.com/apache/james-project/pull/69.diff","patch_url":"https://github.com/apache/james-project/pull/69.patch","issue_url":"https://api.github.com/repos/apache/james-project/issues/69","number":69,"state":"open","locked":false,"title":"import a folder full of EML files to James","user":{"login":"ilkerceng","id":4923344,"avatar_url":"https://avatars2.githubusercontent.com/u/4923344?v=3","gravatar_id":"","url":"https://api.github.com/users/ilkerceng","html_url":"https://github.com/ilkerceng","followers_url":"https://api.github.com/users/ilkerceng/followers","following_url":"https://api.github.com/users/ilkerceng/following{/other_user}","gists_url":"https://api.github.com/users/ilkerceng/gists{/gist_id}","starred_url":"https://api.github.com/users/ilkerceng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilkerceng/subscriptions","organizations_url":"https://api.github.com/users/ilkerceng/orgs","repos_url":"https://api.github.com/users/ilkerceng/repos","events_url":"https://api.github.com/users/ilkerceng/events{/privacy}","received_events_url":"https://api.github.com/users/ilkerceng/received_events","type":"User","site_admin":false},"body":"[https://issues.apache.org/jira/browse/JAMES-2081](url)\r\nimplemented necessary codes, corrected indentations, added tests.","created_at":"2017-07-05T07:24:33Z","updated_at":"2017-07-06T08:00:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"358505dbbbf9bcd59b153f5584dddd196f4936f6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/james-project/pulls/69/commits","review_comments_url":"https://api.github.com/repos/apache/james-project/pulls/69/comments","review_comment_url":"https://api.github.com/repos/apache/james-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/james-project/issues/69/comments","statuses_url":"https://api.github.com/repos/apache/james-project/statuses/9db7fb984e2e3471e7eed40476a36b35e942889f","head":{"label":"ilkerceng:master","ref":"master","sha":"9db7fb984e2e3471e7eed40476a36b35e942889f","user":{"login":"ilkerceng","id":4923344,"avatar_url":"https://avatars2.githubusercontent.com/u/4923344?v=3","gravatar_id":"","url":"https://api.github.com/users/ilkerceng","html_url":"https://github.com/ilkerceng","followers_url":"https://api.github.com/users/ilkerceng/followers","following_url":"https://api.github.com/users/ilkerceng/following{/other_user}","gists_url":"https://api.github.com/users/ilkerceng/gists{/gist_id}","starred_url":"https://api.github.com/users/ilkerceng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilkerceng/subscriptions","organizations_url":"https://api.github.com/users/ilkerceng/orgs","repos_url":"https://api.github.com/users/ilkerceng/repos","events_url":"https://api.github.com/users/ilkerceng/events{/privacy}","received_events_url":"https://api.github.com/users/ilkerceng/received_events","type":"User","site_admin":false},"repo":{"id":96215468,"name":"james-project","full_name":"ilkerceng/james-project","owner":{"login":"ilkerceng","id":4923344,"avatar_url":"https://avatars2.githubusercontent.com/u/4923344?v=3","gravatar_id":"","url":"https://api.github.com/users/ilkerceng","html_url":"https://github.com/ilkerceng","followers_url":"https://api.github.com/users/ilkerceng/followers","following_url":"https://api.github.com/users/ilkerceng/following{/other_user}","gists_url":"https://api.github.com/users/ilkerceng/gists{/gist_id}","starred_url":"https://api.github.com/users/ilkerceng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilkerceng/subscriptions","organizations_url":"https://api.github.com/users/ilkerceng/orgs","repos_url":"https://api.github.com/users/ilkerceng/repos","events_url":"https://api.github.com/users/ilkerceng/events{/privacy}","received_events_url":"https://api.github.com/users/ilkerceng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilkerceng/james-project","description":"Mirror of Apache James Project","fork":true,"url":"https://api.github.com/repos/ilkerceng/james-project","forks_url":"https://api.github.com/repos/ilkerceng/james-project/forks","keys_url":"https://api.github.com/repos/ilkerceng/james-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilkerceng/james-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilkerceng/james-project/teams","hooks_url":"https://api.github.com/repos/ilkerceng/james-project/hooks","issue_events_url":"https://api.github.com/repos/ilkerceng/james-project/issues/events{/number}","events_url":"https://api.github.com/repos/ilkerceng/james-project/events","assignees_url":"https://api.github.com/repos/ilkerceng/james-project/assignees{/user}","branches_url":"https://api.github.com/repos/ilkerceng/james-project/branches{/branch}","tags_url":"https://api.github.com/repos/ilkerceng/james-project/tags","blobs_url":"https://api.github.com/repos/ilkerceng/james-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilkerceng/james-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilkerceng/james-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilkerceng/james-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilkerceng/james-project/statuses/{sha}","languages_url":"https://api.github.com/repos/ilkerceng/james-project/languages","stargazers_url":"https://api.github.com/repos/ilkerceng/james-project/stargazers","contributors_url":"https://api.github.com/repos/ilkerceng/james-project/contributors","subscribers_url":"https://api.github.com/repos/ilkerceng/james-project/subscribers","subscription_url":"https://api.github.com/repos/ilkerceng/james-project/subscription","commits_url":"https://api.github.com/repos/ilkerceng/james-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilkerceng/james-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilkerceng/james-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilkerceng/james-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/ilkerceng/james-project/contents/{+path}","compare_url":"https://api.github.com/repos/ilkerceng/james-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilkerceng/james-project/merges","archive_url":"https://api.github.com/repos/ilkerceng/james-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilkerceng/james-project/downloads","issues_url":"https://api.github.com/repos/ilkerceng/james-project/issues{/number}","pulls_url":"https://api.github.com/repos/ilkerceng/james-project/pulls{/number}","milestones_url":"https://api.github.com/repos/ilkerceng/james-project/milestones{/number}","notifications_url":"https://api.github.com/repos/ilkerceng/james-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilkerceng/james-project/labels{/name}","releases_url":"https://api.github.com/repos/ilkerceng/james-project/releases{/id}","deployments_url":"https://api.github.com/repos/ilkerceng/james-project/deployments","created_at":"2017-07-04T12:23:57Z","updated_at":"2017-07-04T12:24:10Z","pushed_at":"2017-07-05T17:59:55Z","git_url":"git://github.com/ilkerceng/james-project.git","ssh_url":"[email protected]:ilkerceng/james-project.git","clone_url":"https://github.com/ilkerceng/james-project.git","svn_url":"https://github.com/ilkerceng/james-project","homepage":null,"size":21397,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"1128983f434f6a4d5f470af6dd2a63b31ffa9e14","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":38917208,"name":"james-project","full_name":"apache/james-project","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/james-project","description":"Mirror of Apache James Project","fork":false,"url":"https://api.github.com/repos/apache/james-project","forks_url":"https://api.github.com/repos/apache/james-project/forks","keys_url":"https://api.github.com/repos/apache/james-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/james-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/james-project/teams","hooks_url":"https://api.github.com/repos/apache/james-project/hooks","issue_events_url":"https://api.github.com/repos/apache/james-project/issues/events{/number}","events_url":"https://api.github.com/repos/apache/james-project/events","assignees_url":"https://api.github.com/repos/apache/james-project/assignees{/user}","branches_url":"https://api.github.com/repos/apache/james-project/branches{/branch}","tags_url":"https://api.github.com/repos/apache/james-project/tags","blobs_url":"https://api.github.com/repos/apache/james-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/james-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/james-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/james-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/james-project/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/james-project/languages","stargazers_url":"https://api.github.com/repos/apache/james-project/stargazers","contributors_url":"https://api.github.com/repos/apache/james-project/contributors","subscribers_url":"https://api.github.com/repos/apache/james-project/subscribers","subscription_url":"https://api.github.com/repos/apache/james-project/subscription","commits_url":"https://api.github.com/repos/apache/james-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/james-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/james-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/james-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/james-project/contents/{+path}","compare_url":"https://api.github.com/repos/apache/james-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/james-project/merges","archive_url":"https://api.github.com/repos/apache/james-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/james-project/downloads","issues_url":"https://api.github.com/repos/apache/james-project/issues{/number}","pulls_url":"https://api.github.com/repos/apache/james-project/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/james-project/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/james-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/james-project/labels{/name}","releases_url":"https://api.github.com/repos/apache/james-project/releases{/id}","deployments_url":"https://api.github.com/repos/apache/james-project/deployments","created_at":"2015-07-11T07:00:06Z","updated_at":"2017-07-03T07:16:31Z","pushed_at":"2017-07-05T17:59:56Z","git_url":"git://github.com/apache/james-project.git","ssh_url":"[email protected]:apache/james-project.git","clone_url":"https://github.com/apache/james-project.git","svn_url":"https://github.com/apache/james-project","homepage":null,"size":21377,"stargazers_count":75,"watchers_count":75,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":103,"mirror_url":"git://git.apache.org/james-project.git","open_issues_count":5,"forks":103,"open_issues":5,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/james-project/pulls/69"},"html":{"href":"https://github.com/apache/james-project/pull/69"},"issue":{"href":"https://api.github.com/repos/apache/james-project/issues/69"},"comments":{"href":"https://api.github.com/repos/apache/james-project/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/james-project/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/james-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/james-project/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/apache/james-project/statuses/9db7fb984e2e3471e7eed40476a36b35e942889f"}}}} | {
"id": 38917208,
"name": "apache/james-project",
"url": "https://api.github.com/repos/apache/james-project"
} | {
"id": 4923344,
"login": "ilkerceng",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4923344?",
"url": "https://api.github.com/users/ilkerceng"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-07-06T08:00:52 | 6201982846 | {"actor":{"display_login":"ilkerceng"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/tinkerpop/pulls/comments/132149297","pull_request_review_id":55197214,"id":132149297,"diff_hunk":"@@ -0,0 +1,55 @@\n+#region License\n+\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements. See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership. The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied. See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+\n+#endregion\n+\n+using System;\n+using System.Runtime.ExceptionServices;\n+using System.Threading.Tasks;\n+\n+namespace Gremlin.Net.Structure","path":"gremlin-dotnet/src/Gremlin.Net/Structure/Utils.cs","position":28,"original_position":28,"commit_id":"a655e2649ab9a6ba1885dde317d81e845a7507b8","original_commit_id":"a655e2649ab9a6ba1885dde317d81e845a7507b8","user":{"login":"FlorianHockmann","id":21224336,"avatar_url":"https://avatars1.githubusercontent.com/u/21224336?v=4","gravatar_id":"","url":"https://api.github.com/users/FlorianHockmann","html_url":"https://github.com/FlorianHockmann","followers_url":"https://api.github.com/users/FlorianHockmann/followers","following_url":"https://api.github.com/users/FlorianHockmann/following{/other_user}","gists_url":"https://api.github.com/users/FlorianHockmann/gists{/gist_id}","starred_url":"https://api.github.com/users/FlorianHockmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlorianHockmann/subscriptions","organizations_url":"https://api.github.com/users/FlorianHockmann/orgs","repos_url":"https://api.github.com/users/FlorianHockmann/repos","events_url":"https://api.github.com/users/FlorianHockmann/events{/privacy}","received_events_url":"https://api.github.com/users/FlorianHockmann/received_events","type":"User","site_admin":false},"body":"Wouldn't it make more sense to put this in `Gremlin.Net.Process` as all users of this are in that namespace?","created_at":"2017-08-09T10:43:52Z","updated_at":"2017-08-09T10:56:00Z","html_url":"https://github.com/apache/tinkerpop/pull/690#discussion_r132149297","pull_request_url":"https://api.github.com/repos/apache/tinkerpop/pulls/690","_links":{"self":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/comments/132149297"},"html":{"href":"https://github.com/apache/tinkerpop/pull/690#discussion_r132149297"},"pull_request":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/690"}}},"pull_request":{"url":"https://api.github.com/repos/apache/tinkerpop/pulls/690","id":134855152,"html_url":"https://github.com/apache/tinkerpop/pull/690","diff_url":"https://github.com/apache/tinkerpop/pull/690.diff","patch_url":"https://github.com/apache/tinkerpop/pull/690.patch","issue_url":"https://api.github.com/repos/apache/tinkerpop/issues/690","number":690,"state":"open","locked":false,"title":"TINKERPOP-1744 Unwrap AggregateException for sync io operations","user":{"login":"jorgebay","id":2931196,"avatar_url":"https://avatars3.githubusercontent.com/u/2931196?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgebay","html_url":"https://github.com/jorgebay","followers_url":"https://api.github.com/users/jorgebay/followers","following_url":"https://api.github.com/users/jorgebay/following{/other_user}","gists_url":"https://api.github.com/users/jorgebay/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgebay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgebay/subscriptions","organizations_url":"https://api.github.com/users/jorgebay/orgs","repos_url":"https://api.github.com/users/jorgebay/repos","events_url":"https://api.github.com/users/jorgebay/events{/privacy}","received_events_url":"https://api.github.com/users/jorgebay/received_events","type":"User","site_admin":false},"body":"https://issues.apache.org/jira/browse/TINKERPOP-1744\r\n\r\nIncludes a test expecting the underlying exception (`ResponseException`) to be thrown.\r\n\r\nBuilds with `mvn clean install -P gremlin-dotnet`","created_at":"2017-08-09T10:04:57Z","updated_at":"2017-08-09T10:56:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"baeaaec18078e657f8fd2439e4a00365870a306f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/tinkerpop/pulls/690/commits","review_comments_url":"https://api.github.com/repos/apache/tinkerpop/pulls/690/comments","review_comment_url":"https://api.github.com/repos/apache/tinkerpop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/tinkerpop/issues/690/comments","statuses_url":"https://api.github.com/repos/apache/tinkerpop/statuses/a655e2649ab9a6ba1885dde317d81e845a7507b8","head":{"label":"apache:TINKERPOP-1744","ref":"TINKERPOP-1744","sha":"a655e2649ab9a6ba1885dde317d81e845a7507b8","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":30449481,"name":"tinkerpop","full_name":"apache/tinkerpop","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/tinkerpop","description":"Mirror of Apache TinkerPop","fork":false,"url":"https://api.github.com/repos/apache/tinkerpop","forks_url":"https://api.github.com/repos/apache/tinkerpop/forks","keys_url":"https://api.github.com/repos/apache/tinkerpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/tinkerpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/tinkerpop/teams","hooks_url":"https://api.github.com/repos/apache/tinkerpop/hooks","issue_events_url":"https://api.github.com/repos/apache/tinkerpop/issues/events{/number}","events_url":"https://api.github.com/repos/apache/tinkerpop/events","assignees_url":"https://api.github.com/repos/apache/tinkerpop/assignees{/user}","branches_url":"https://api.github.com/repos/apache/tinkerpop/branches{/branch}","tags_url":"https://api.github.com/repos/apache/tinkerpop/tags","blobs_url":"https://api.github.com/repos/apache/tinkerpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/tinkerpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/tinkerpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/tinkerpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/tinkerpop/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/tinkerpop/languages","stargazers_url":"https://api.github.com/repos/apache/tinkerpop/stargazers","contributors_url":"https://api.github.com/repos/apache/tinkerpop/contributors","subscribers_url":"https://api.github.com/repos/apache/tinkerpop/subscribers","subscription_url":"https://api.github.com/repos/apache/tinkerpop/subscription","commits_url":"https://api.github.com/repos/apache/tinkerpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/tinkerpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/tinkerpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/tinkerpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/tinkerpop/contents/{+path}","compare_url":"https://api.github.com/repos/apache/tinkerpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/tinkerpop/merges","archive_url":"https://api.github.com/repos/apache/tinkerpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/tinkerpop/downloads","issues_url":"https://api.github.com/repos/apache/tinkerpop/issues{/number}","pulls_url":"https://api.github.com/repos/apache/tinkerpop/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/tinkerpop/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/tinkerpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/tinkerpop/labels{/name}","releases_url":"https://api.github.com/repos/apache/tinkerpop/releases{/id}","deployments_url":"https://api.github.com/repos/apache/tinkerpop/deployments","created_at":"2015-02-07T08:00:05Z","updated_at":"2017-08-09T07:32:51Z","pushed_at":"2017-08-09T10:04:57Z","git_url":"git://github.com/apache/tinkerpop.git","ssh_url":"[email protected]:apache/tinkerpop.git","clone_url":"https://github.com/apache/tinkerpop.git","svn_url":"https://github.com/apache/tinkerpop","homepage":"http://tinkerpop.apache.org/","size":141157,"stargazers_count":385,"watchers_count":385,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":228,"mirror_url":"git://git.apache.org/tinkerpop.git","open_issues_count":10,"forks":228,"open_issues":10,"watchers":385,"default_branch":"master"}},"base":{"label":"apache:tp32","ref":"tp32","sha":"51caf77f654b3a71deb615450c15b02b95a87972","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":30449481,"name":"tinkerpop","full_name":"apache/tinkerpop","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/tinkerpop","description":"Mirror of Apache TinkerPop","fork":false,"url":"https://api.github.com/repos/apache/tinkerpop","forks_url":"https://api.github.com/repos/apache/tinkerpop/forks","keys_url":"https://api.github.com/repos/apache/tinkerpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/tinkerpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/tinkerpop/teams","hooks_url":"https://api.github.com/repos/apache/tinkerpop/hooks","issue_events_url":"https://api.github.com/repos/apache/tinkerpop/issues/events{/number}","events_url":"https://api.github.com/repos/apache/tinkerpop/events","assignees_url":"https://api.github.com/repos/apache/tinkerpop/assignees{/user}","branches_url":"https://api.github.com/repos/apache/tinkerpop/branches{/branch}","tags_url":"https://api.github.com/repos/apache/tinkerpop/tags","blobs_url":"https://api.github.com/repos/apache/tinkerpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/tinkerpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/tinkerpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/tinkerpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/tinkerpop/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/tinkerpop/languages","stargazers_url":"https://api.github.com/repos/apache/tinkerpop/stargazers","contributors_url":"https://api.github.com/repos/apache/tinkerpop/contributors","subscribers_url":"https://api.github.com/repos/apache/tinkerpop/subscribers","subscription_url":"https://api.github.com/repos/apache/tinkerpop/subscription","commits_url":"https://api.github.com/repos/apache/tinkerpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/tinkerpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/tinkerpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/tinkerpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/tinkerpop/contents/{+path}","compare_url":"https://api.github.com/repos/apache/tinkerpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/tinkerpop/merges","archive_url":"https://api.github.com/repos/apache/tinkerpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/tinkerpop/downloads","issues_url":"https://api.github.com/repos/apache/tinkerpop/issues{/number}","pulls_url":"https://api.github.com/repos/apache/tinkerpop/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/tinkerpop/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/tinkerpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/tinkerpop/labels{/name}","releases_url":"https://api.github.com/repos/apache/tinkerpop/releases{/id}","deployments_url":"https://api.github.com/repos/apache/tinkerpop/deployments","created_at":"2015-02-07T08:00:05Z","updated_at":"2017-08-09T07:32:51Z","pushed_at":"2017-08-09T10:04:57Z","git_url":"git://github.com/apache/tinkerpop.git","ssh_url":"[email protected]:apache/tinkerpop.git","clone_url":"https://github.com/apache/tinkerpop.git","svn_url":"https://github.com/apache/tinkerpop","homepage":"http://tinkerpop.apache.org/","size":141157,"stargazers_count":385,"watchers_count":385,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":228,"mirror_url":"git://git.apache.org/tinkerpop.git","open_issues_count":10,"forks":228,"open_issues":10,"watchers":385,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/690"},"html":{"href":"https://github.com/apache/tinkerpop/pull/690"},"issue":{"href":"https://api.github.com/repos/apache/tinkerpop/issues/690"},"comments":{"href":"https://api.github.com/repos/apache/tinkerpop/issues/690/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/690/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/690/commits"},"statuses":{"href":"https://api.github.com/repos/apache/tinkerpop/statuses/a655e2649ab9a6ba1885dde317d81e845a7507b8"}}}} | {
"id": 30449481,
"name": "apache/tinkerpop",
"url": "https://api.github.com/repos/apache/tinkerpop"
} | {
"id": 21224336,
"login": "FlorianHockmann",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21224336?",
"url": "https://api.github.com/users/FlorianHockmann"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-08-09T10:43:52 | 6423404562 | {"actor":{"display_login":"FlorianHockmann"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/152634018","pull_request_review_id":78526730,"id":152634018,"diff_hunk":"@@ -0,0 +1,429 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements. See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.spark.scheduler.cluster.k8s\n+\n+import java.io.Closeable\n+import java.net.InetAddress\n+import java.util.concurrent.{ConcurrentHashMap, ExecutorService, ScheduledExecutorService, TimeUnit}\n+import java.util.concurrent.atomic.{AtomicInteger, AtomicLong, AtomicReference}\n+import javax.annotation.concurrent.GuardedBy\n+\n+import io.fabric8.kubernetes.api.model._\n+import io.fabric8.kubernetes.client.{KubernetesClient, KubernetesClientException, Watcher}\n+import io.fabric8.kubernetes.client.Watcher.Action\n+import scala.collection.JavaConverters._\n+import scala.collection.mutable\n+import scala.concurrent.{ExecutionContext, Future}\n+\n+import org.apache.spark.SparkException\n+import org.apache.spark.deploy.k8s.Config._\n+import org.apache.spark.deploy.k8s.Constants._\n+import org.apache.spark.rpc.{RpcAddress, RpcEndpointAddress, RpcEnv}\n+import org.apache.spark.scheduler.{ExecutorExited, SlaveLost, TaskSchedulerImpl}\n+import org.apache.spark.scheduler.cluster.{CoarseGrainedSchedulerBackend, SchedulerBackendUtils}\n+import org.apache.spark.util.Utils\n+\n+private[spark] class KubernetesClusterSchedulerBackend(\n+ scheduler: TaskSchedulerImpl,\n+ rpcEnv: RpcEnv,\n+ executorPodFactory: ExecutorPodFactory,\n+ kubernetesClient: KubernetesClient,\n+ allocatorExecutor: ScheduledExecutorService,\n+ requestExecutorsService: ExecutorService)\n+ extends CoarseGrainedSchedulerBackend(scheduler, rpcEnv) {\n+\n+ import KubernetesClusterSchedulerBackend._\n+\n+ private val EXECUTOR_ID_COUNTER = new AtomicLong(0L)\n+ private val RUNNING_EXECUTOR_PODS_LOCK = new Object\n+ @GuardedBy(\"RUNNING_EXECUTOR_PODS_LOCK\")\n+ private val runningExecutorsToPods = new mutable.HashMap[String, Pod]\n+ private val executorPodsByIPs = new ConcurrentHashMap[String, Pod]()\n+ private val podsWithKnownExitReasons = new ConcurrentHashMap[String, ExecutorExited]()\n+ private val disconnectedPodsByExecutorIdPendingRemoval = new ConcurrentHashMap[String, Pod]()\n+\n+ private val kubernetesNamespace = conf.get(KUBERNETES_NAMESPACE)\n+\n+ private val kubernetesDriverPodName = conf\n+ .get(KUBERNETES_DRIVER_POD_NAME)\n+ .getOrElse(throw new SparkException(\"Must specify the driver pod name\"))\n+ private implicit val requestExecutorContext = ExecutionContext.fromExecutorService(\n+ requestExecutorsService)\n+\n+ private val driverPod = kubernetesClient.pods()\n+ .inNamespace(kubernetesNamespace)\n+ .withName(kubernetesDriverPodName)\n+ .get()\n+\n+ protected override val minRegisteredRatio =\n+ if (conf.getOption(\"spark.scheduler.minRegisteredResourcesRatio\").isEmpty) {\n+ 0.8\n+ } else {\n+ super.minRegisteredRatio\n+ }\n+\n+ private val executorWatchResource = new AtomicReference[Closeable]\n+ private val totalExpectedExecutors = new AtomicInteger(0)\n+\n+ private val driverUrl = RpcEndpointAddress(\n+ conf.get(\"spark.driver.host\"),\n+ conf.getInt(\"spark.driver.port\", DEFAULT_DRIVER_PORT),\n+ CoarseGrainedSchedulerBackend.ENDPOINT_NAME).toString\n+\n+ private val initialExecutors = SchedulerBackendUtils.getInitialTargetExecutorNumber(conf)\n+\n+ private val podAllocationInterval = conf.get(KUBERNETES_ALLOCATION_BATCH_DELAY)\n+\n+ private val podAllocationSize = conf.get(KUBERNETES_ALLOCATION_BATCH_SIZE)\n+\n+ private val allocatorRunnable = new Runnable {\n+\n+ // Maintains a map of executor id to count of checks performed to learn the loss reason\n+ // for an executor.\n+ private val executorReasonCheckAttemptCounts = new mutable.HashMap[String, Int]\n+\n+ override def run(): Unit = {\n+ handleDisconnectedExecutors()\n+\n+ val executorsToAllocate = mutable.Map[String, Pod]()\n+ val currentTotalRegisteredExecutors = totalRegisteredExecutors.get\n+ val currentTotalExpectedExecutors = totalExpectedExecutors.get\n+ val currentNodeToLocalTaskCount = getNodesWithLocalTaskCounts()\n+ if (currentTotalRegisteredExecutors < runningExecutorsToPods.size) {\n+ logDebug(\"Waiting for pending executors before scaling\")\n+ } else if (currentTotalExpectedExecutors <= runningExecutorsToPods.size) {\n+ logDebug(\"Maximum allowed executor limit reached. Not scaling up further.\")\n+ } else {\n+ for (i <- 0 until math.min(\n+ currentTotalExpectedExecutors - runningExecutorsToPods.size, podAllocationSize)) {\n+ val executorId = EXECUTOR_ID_COUNTER.incrementAndGet().toString\n+ val executorPod = executorPodFactory.createExecutorPod(\n+ executorId,\n+ applicationId(),\n+ driverUrl,\n+ conf.getExecutorEnv,\n+ driverPod,\n+ currentNodeToLocalTaskCount)\n+ executorsToAllocate(executorId) = executorPod\n+ logInfo(\n+ s\"Requesting a new executor, total executors is now ${runningExecutorsToPods.size}\")\n+ }\n+ }\n+\n+ val allocatedExecutors = executorsToAllocate.mapValues { pod =>\n+ Utils.tryLog {\n+ kubernetesClient.pods().create(pod)\n+ }\n+ }\n+\n+ RUNNING_EXECUTOR_PODS_LOCK.synchronized {\n+ allocatedExecutors.map {\n+ case (executorId, attemptedAllocatedExecutor) =>\n+ attemptedAllocatedExecutor.map { successfullyAllocatedExecutor =>\n+ runningExecutorsToPods.put(executorId, successfullyAllocatedExecutor)\n+ }\n+ }\n+ }\n+ }\n+\n+ def handleDisconnectedExecutors(): Unit = {\n+ // For each disconnected executor, synchronize with the loss reasons that may have been found\n+ // by the executor pod watcher. If the loss reason was discovered by the watcher,\n+ // inform the parent class with removeExecutor.\n+ disconnectedPodsByExecutorIdPendingRemoval.asScala.foreach {\n+ case (executorId, executorPod) =>\n+ val knownExitReason = Option(podsWithKnownExitReasons.remove(\n+ executorPod.getMetadata.getName))\n+ knownExitReason.fold {\n+ removeExecutorOrIncrementLossReasonCheckCount(executorId)\n+ } { executorExited =>\n+ logWarning(s\"Removing executor $executorId with loss reason \" + executorExited.message)\n+ removeExecutor(executorId, executorExited)\n+ // We don't delete the pod running the executor that has an exit condition caused by\n+ // the application from the Kubernetes API server. This allows users to debug later on\n+ // through commands such as \"kubectl logs <pod name>\" and\n+ // \"kubectl describe pod <pod name>\". Note that exited containers have terminated and\n+ // therefore won't take CPU and memory resources.\n+ // Otherwise, the executor pod is marked to be deleted from the API server.\n+ if (executorExited.exitCausedByApp) {\n+ logInfo(s\"Executor $executorId exited because of the application.\")\n+ deleteExecutorFromDataStructures(executorId)\n+ } else {\n+ logInfo(s\"Executor $executorId failed because of a framework error.\")\n+ deleteExecutorFromClusterAndDataStructures(executorId)\n+ }\n+ }\n+ }\n+ }\n+\n+ def removeExecutorOrIncrementLossReasonCheckCount(executorId: String): Unit = {\n+ val reasonCheckCount = executorReasonCheckAttemptCounts.getOrElse(executorId, 0)\n+ if (reasonCheckCount >= MAX_EXECUTOR_LOST_REASON_CHECKS) {\n+ removeExecutor(executorId, SlaveLost(\"Executor lost for unknown reasons.\"))\n+ deleteExecutorFromClusterAndDataStructures(executorId)\n+ } else {\n+ executorReasonCheckAttemptCounts.put(executorId, reasonCheckCount + 1)\n+ }\n+ }\n+\n+ def deleteExecutorFromClusterAndDataStructures(executorId: String): Unit = {\n+ deleteExecutorFromDataStructures(executorId).foreach { pod =>\n+ kubernetesClient.pods().delete(pod) }","path":"resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala","position":185,"original_position":185,"commit_id":"3b587b4b4362f184b148c22522821ef7b163717e","original_commit_id":"3b587b4b4362f184b148c22522821ef7b163717e","user":{"login":"liyinan926","id":3709137,"avatar_url":"https://avatars2.githubusercontent.com/u/3709137?v=4","gravatar_id":"","url":"https://api.github.com/users/liyinan926","html_url":"https://github.com/liyinan926","followers_url":"https://api.github.com/users/liyinan926/followers","following_url":"https://api.github.com/users/liyinan926/following{/other_user}","gists_url":"https://api.github.com/users/liyinan926/gists{/gist_id}","starred_url":"https://api.github.com/users/liyinan926/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liyinan926/subscriptions","organizations_url":"https://api.github.com/users/liyinan926/orgs","repos_url":"https://api.github.com/users/liyinan926/repos","events_url":"https://api.github.com/users/liyinan926/events{/privacy}","received_events_url":"https://api.github.com/users/liyinan926/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-11-22T17:35:36Z","updated_at":"2017-11-22T17:35:36Z","html_url":"https://github.com/apache/spark/pull/19468#discussion_r152634018","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/19468","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/152634018"},"html":{"href":"https://github.com/apache/spark/pull/19468#discussion_r152634018"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/19468"}},"in_reply_to_id":152522621},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/19468","id":145830508,"html_url":"https://github.com/apache/spark/pull/19468","diff_url":"https://github.com/apache/spark/pull/19468.diff","patch_url":"https://github.com/apache/spark/pull/19468.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/19468","number":19468,"state":"open","locked":false,"title":"[SPARK-18278] [Scheduler] Spark on Kubernetes - Basic Scheduler Backend","user":{"login":"foxish","id":906471,"avatar_url":"https://avatars1.githubusercontent.com/u/906471?v=4","gravatar_id":"","url":"https://api.github.com/users/foxish","html_url":"https://github.com/foxish","followers_url":"https://api.github.com/users/foxish/followers","following_url":"https://api.github.com/users/foxish/following{/other_user}","gists_url":"https://api.github.com/users/foxish/gists{/gist_id}","starred_url":"https://api.github.com/users/foxish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxish/subscriptions","organizations_url":"https://api.github.com/users/foxish/orgs","repos_url":"https://api.github.com/users/foxish/repos","events_url":"https://api.github.com/users/foxish/events{/privacy}","received_events_url":"https://api.github.com/users/foxish/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nThis is a stripped down version of the `KubernetesClusterSchedulerBackend` for Spark with the following components:\r\n- Static Allocation of Executors\r\n- Executor Pod Factory\r\n- Executor Recovery Semantics\r\n\r\nIt's step 1 from the step-wise plan documented [here](https://github.com/apache-spark-on-k8s/spark/issues/441#issuecomment-330802935).\r\nThis addition is covered by the [SPIP vote](http://apache-spark-developers-list.1001551.n3.nabble.com/SPIP-Spark-on-Kubernetes-td22147.html) which passed on Aug 31 .\r\n\r\n## How was this patch tested?\r\n\r\n- The patch contains unit tests which are passing.\r\n- Manual testing: `./build/mvn -Pkubernetes clean package` succeeded.\r\n- It is a **subset** of the entire changelist hosted in http://github.com/apache-spark-on-k8s/spark which is in active use in several organizations.\r\n- There is integration testing enabled in the fork currently [hosted by PepperData](spark-k8s-jenkins.pepperdata.org:8080) which is being moved over to RiseLAB CI.\r\n- Detailed documentation on trying out the patch in its entirety is in: https://apache-spark-on-k8s.github.io/userdocs/running-on-kubernetes.html\r\n\r\ncc @rxin @felixcheung @mateiz (shepherd)\r\nk8s-big-data SIG members & contributors: @mccheah @ash211 @ssuchter @varunkatta @kimoonkim @erikerlandson @liyinan926 @tnachen @ifilonenko","created_at":"2017-10-11T00:16:54Z","updated_at":"2017-11-22T17:35:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60547ef963ba8aa191541202e7c6d03cc99a9161","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/19468/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/19468/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/19468/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/3b587b4b4362f184b148c22522821ef7b163717e","head":{"label":"apache-spark-on-k8s:spark-kubernetes-3","ref":"spark-kubernetes-3","sha":"3b587b4b4362f184b148c22522821ef7b163717e","user":{"login":"apache-spark-on-k8s","id":24321138,"avatar_url":"https://avatars1.githubusercontent.com/u/24321138?v=4","gravatar_id":"","url":"https://api.github.com/users/apache-spark-on-k8s","html_url":"https://github.com/apache-spark-on-k8s","followers_url":"https://api.github.com/users/apache-spark-on-k8s/followers","following_url":"https://api.github.com/users/apache-spark-on-k8s/following{/other_user}","gists_url":"https://api.github.com/users/apache-spark-on-k8s/gists{/gist_id}","starred_url":"https://api.github.com/users/apache-spark-on-k8s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache-spark-on-k8s/subscriptions","organizations_url":"https://api.github.com/users/apache-spark-on-k8s/orgs","repos_url":"https://api.github.com/users/apache-spark-on-k8s/repos","events_url":"https://api.github.com/users/apache-spark-on-k8s/events{/privacy}","received_events_url":"https://api.github.com/users/apache-spark-on-k8s/received_events","type":"Organization","site_admin":false},"repo":{"id":75415639,"name":"spark","full_name":"apache-spark-on-k8s/spark","owner":{"login":"apache-spark-on-k8s","id":24321138,"avatar_url":"https://avatars1.githubusercontent.com/u/24321138?v=4","gravatar_id":"","url":"https://api.github.com/users/apache-spark-on-k8s","html_url":"https://github.com/apache-spark-on-k8s","followers_url":"https://api.github.com/users/apache-spark-on-k8s/followers","following_url":"https://api.github.com/users/apache-spark-on-k8s/following{/other_user}","gists_url":"https://api.github.com/users/apache-spark-on-k8s/gists{/gist_id}","starred_url":"https://api.github.com/users/apache-spark-on-k8s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache-spark-on-k8s/subscriptions","organizations_url":"https://api.github.com/users/apache-spark-on-k8s/orgs","repos_url":"https://api.github.com/users/apache-spark-on-k8s/repos","events_url":"https://api.github.com/users/apache-spark-on-k8s/events{/privacy}","received_events_url":"https://api.github.com/users/apache-spark-on-k8s/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache-spark-on-k8s/spark","description":"Apache Spark enhanced with native Kubernetes scheduler back-end","fork":true,"url":"https://api.github.com/repos/apache-spark-on-k8s/spark","forks_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/forks","keys_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/teams","hooks_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/hooks","issue_events_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/events","assignees_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/tags","blobs_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/languages","stargazers_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/stargazers","contributors_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/contributors","subscribers_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/subscribers","subscription_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/subscription","commits_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/merges","archive_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/downloads","issues_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache-spark-on-k8s/spark/deployments","created_at":"2016-12-02T17:15:19Z","updated_at":"2017-11-22T00:48:47Z","pushed_at":"2017-11-22T06:27:37Z","git_url":"git://github.com/apache-spark-on-k8s/spark.git","ssh_url":"[email protected]:apache-spark-on-k8s/spark.git","clone_url":"https://github.com/apache-spark-on-k8s/spark.git","svn_url":"https://github.com/apache-spark-on-k8s/spark","homepage":"","size":267149,"stargazers_count":288,"watchers_count":288,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":135,"forks":59,"open_issues":135,"watchers":288,"default_branch":"branch-2.2-kubernetes"}},"base":{"label":"apache:master","ref":"master","sha":"11b60af737a04d931356aa74ebf3c6cf4a6b08d6","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2017-11-22T14:53:40Z","pushed_at":"2017-11-22T17:21:47Z","git_url":"git://github.com/apache/spark.git","ssh_url":"[email protected]:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":266545,"stargazers_count":15177,"watchers_count":15177,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14112,"mirror_url":"git://git.apache.org/spark.git","archived":false,"open_issues_count":384,"forks":14112,"open_issues":384,"watchers":15177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/19468"},"html":{"href":"https://github.com/apache/spark/pull/19468"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/19468"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/19468/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/19468/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/19468/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/3b587b4b4362f184b148c22522821ef7b163717e"}},"author_association":"CONTRIBUTOR"}} | {
"id": 17165658,
"name": "apache/spark",
"url": "https://api.github.com/repos/apache/spark"
} | {
"id": 3709137,
"login": "liyinan926",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3709137?",
"url": "https://api.github.com/users/liyinan926"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-11-22T17:35:36 | 6891596636 | {"actor":{"display_login":"liyinan926"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/115908788","pull_request_review_id":37487309,"id":115908788,"diff_hunk":"@@ -239,6 +248,7 @@ class DataStreamOverAggregate(\n }\n \n def createBoundedAndCurrentRowOverWindow(","path":"flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala","position":138,"original_position":81,"commit_id":"a7ec50d880b488efeab40c7012e20b3f5385fd45","original_commit_id":"f8b2ef3d27ef73142679ab50882a46c895074947","user":{"login":"sunjincheng121","id":22488084,"avatar_url":"https://avatars3.githubusercontent.com/u/22488084?v=3","gravatar_id":"","url":"https://api.github.com/users/sunjincheng121","html_url":"https://github.com/sunjincheng121","followers_url":"https://api.github.com/users/sunjincheng121/followers","following_url":"https://api.github.com/users/sunjincheng121/following{/other_user}","gists_url":"https://api.github.com/users/sunjincheng121/gists{/gist_id}","starred_url":"https://api.github.com/users/sunjincheng121/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunjincheng121/subscriptions","organizations_url":"https://api.github.com/users/sunjincheng121/orgs","repos_url":"https://api.github.com/users/sunjincheng121/repos","events_url":"https://api.github.com/users/sunjincheng121/events{/privacy}","received_events_url":"https://api.github.com/users/sunjincheng121/received_events","type":"User","site_admin":false},"body":"I do not think we need add this check. Because both `row-base` and `time-base` will be able to meet the incorrect result due to state cleanup. an importation thing we need to do is let use know the function of the `cleanup config`. ","created_at":"2017-05-11T05:46:45Z","updated_at":"2017-05-11T05:46:45Z","html_url":"https://github.com/apache/flink/pull/3863#discussion_r115908788","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/3863","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/115908788"},"html":{"href":"https://github.com/apache/flink/pull/3863#discussion_r115908788"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/3863"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/3863","id":119874002,"html_url":"https://github.com/apache/flink/pull/3863","diff_url":"https://github.com/apache/flink/pull/3863.diff","patch_url":"https://github.com/apache/flink/pull/3863.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/3863","number":3863,"state":"open","locked":false,"title":"[FLINK-6491][talbe]Add QueryConfig to specify state retention time for streaming queries","user":{"login":"sunjincheng121","id":22488084,"avatar_url":"https://avatars3.githubusercontent.com/u/22488084?v=3","gravatar_id":"","url":"https://api.github.com/users/sunjincheng121","html_url":"https://github.com/sunjincheng121","followers_url":"https://api.github.com/users/sunjincheng121/followers","following_url":"https://api.github.com/users/sunjincheng121/following{/other_user}","gists_url":"https://api.github.com/users/sunjincheng121/gists{/gist_id}","starred_url":"https://api.github.com/users/sunjincheng121/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunjincheng121/subscriptions","organizations_url":"https://api.github.com/users/sunjincheng121/orgs","repos_url":"https://api.github.com/users/sunjincheng121/repos","events_url":"https://api.github.com/users/sunjincheng121/events{/privacy}","received_events_url":"https://api.github.com/users/sunjincheng121/received_events","type":"User","site_admin":false},"body":"In this PR we have the changes as follows:\r\n1. Add QueryConfig and state clean up for non-windowed aggregates.\r\n2. Add QueryConfig and state clean up for over-windowed aggregates.\r\n\r\n- [x] General\r\n - The pull request references the related JIRA issue (\"[FLINK-6491][talbe]Add QueryConfig to specify state retention time for streaming queries\")\r\n - The pull request addresses only one issue\r\n - Each commit in the PR has a meaningful commit message (including the JIRA id)\r\n\r\n- [ ] Documentation\r\n - Documentation has been added for new functionality\r\n - Old documentation affected by the pull request has been updated\r\n - JavaDoc for public methods has been added\r\n\r\n- [x] Tests & Build\r\n - Functionality added by the pull request is covered by tests\r\n - `mvn clean verify` has been executed successfully locally or a Travis build has passed\r\n","created_at":"2017-05-10T12:46:05Z","updated_at":"2017-05-11T05:46:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62d97ae9c18c58773dfcfb6cec70b2d19bf2917f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/3863/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/3863/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/3863/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/a7ec50d880b488efeab40c7012e20b3f5385fd45","head":{"label":"sunjincheng121:FLINK-6491-PR","ref":"FLINK-6491-PR","sha":"a7ec50d880b488efeab40c7012e20b3f5385fd45","user":{"login":"sunjincheng121","id":22488084,"avatar_url":"https://avatars3.githubusercontent.com/u/22488084?v=3","gravatar_id":"","url":"https://api.github.com/users/sunjincheng121","html_url":"https://github.com/sunjincheng121","followers_url":"https://api.github.com/users/sunjincheng121/followers","following_url":"https://api.github.com/users/sunjincheng121/following{/other_user}","gists_url":"https://api.github.com/users/sunjincheng121/gists{/gist_id}","starred_url":"https://api.github.com/users/sunjincheng121/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunjincheng121/subscriptions","organizations_url":"https://api.github.com/users/sunjincheng121/orgs","repos_url":"https://api.github.com/users/sunjincheng121/repos","events_url":"https://api.github.com/users/sunjincheng121/events{/privacy}","received_events_url":"https://api.github.com/users/sunjincheng121/received_events","type":"User","site_admin":false},"repo":{"id":70389886,"name":"flink","full_name":"sunjincheng121/flink","owner":{"login":"sunjincheng121","id":22488084,"avatar_url":"https://avatars3.githubusercontent.com/u/22488084?v=3","gravatar_id":"","url":"https://api.github.com/users/sunjincheng121","html_url":"https://github.com/sunjincheng121","followers_url":"https://api.github.com/users/sunjincheng121/followers","following_url":"https://api.github.com/users/sunjincheng121/following{/other_user}","gists_url":"https://api.github.com/users/sunjincheng121/gists{/gist_id}","starred_url":"https://api.github.com/users/sunjincheng121/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunjincheng121/subscriptions","organizations_url":"https://api.github.com/users/sunjincheng121/orgs","repos_url":"https://api.github.com/users/sunjincheng121/repos","events_url":"https://api.github.com/users/sunjincheng121/events{/privacy}","received_events_url":"https://api.github.com/users/sunjincheng121/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sunjincheng121/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/sunjincheng121/flink","forks_url":"https://api.github.com/repos/sunjincheng121/flink/forks","keys_url":"https://api.github.com/repos/sunjincheng121/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sunjincheng121/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sunjincheng121/flink/teams","hooks_url":"https://api.github.com/repos/sunjincheng121/flink/hooks","issue_events_url":"https://api.github.com/repos/sunjincheng121/flink/issues/events{/number}","events_url":"https://api.github.com/repos/sunjincheng121/flink/events","assignees_url":"https://api.github.com/repos/sunjincheng121/flink/assignees{/user}","branches_url":"https://api.github.com/repos/sunjincheng121/flink/branches{/branch}","tags_url":"https://api.github.com/repos/sunjincheng121/flink/tags","blobs_url":"https://api.github.com/repos/sunjincheng121/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sunjincheng121/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sunjincheng121/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/sunjincheng121/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sunjincheng121/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/sunjincheng121/flink/languages","stargazers_url":"https://api.github.com/repos/sunjincheng121/flink/stargazers","contributors_url":"https://api.github.com/repos/sunjincheng121/flink/contributors","subscribers_url":"https://api.github.com/repos/sunjincheng121/flink/subscribers","subscription_url":"https://api.github.com/repos/sunjincheng121/flink/subscription","commits_url":"https://api.github.com/repos/sunjincheng121/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/sunjincheng121/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/sunjincheng121/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/sunjincheng121/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/sunjincheng121/flink/contents/{+path}","compare_url":"https://api.github.com/repos/sunjincheng121/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sunjincheng121/flink/merges","archive_url":"https://api.github.com/repos/sunjincheng121/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sunjincheng121/flink/downloads","issues_url":"https://api.github.com/repos/sunjincheng121/flink/issues{/number}","pulls_url":"https://api.github.com/repos/sunjincheng121/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/sunjincheng121/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/sunjincheng121/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sunjincheng121/flink/labels{/name}","releases_url":"https://api.github.com/repos/sunjincheng121/flink/releases{/id}","deployments_url":"https://api.github.com/repos/sunjincheng121/flink/deployments","created_at":"2016-10-09T08:43:40Z","updated_at":"2016-10-09T08:44:02Z","pushed_at":"2017-05-11T05:29:45Z","git_url":"git://github.com/sunjincheng121/flink.git","ssh_url":"[email protected]:sunjincheng121/flink.git","clone_url":"https://github.com/sunjincheng121/flink.git","svn_url":"https://github.com/sunjincheng121/flink","homepage":null,"size":120403,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"71d76731dc6f611a6f8772cb06a59f5c642ec6cc","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2017-05-10T14:15:01Z","pushed_at":"2017-05-11T05:29:47Z","git_url":"git://github.com/apache/flink.git","ssh_url":"[email protected]:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":122144,"stargazers_count":2291,"watchers_count":2291,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1612,"mirror_url":"git://git.apache.org/flink.git","open_issues_count":218,"forks":1612,"open_issues":218,"watchers":2291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/3863"},"html":{"href":"https://github.com/apache/flink/pull/3863"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/3863"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/3863/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/3863/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/3863/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/a7ec50d880b488efeab40c7012e20b3f5385fd45"}}}} | {
"id": 20587599,
"name": "apache/flink",
"url": "https://api.github.com/repos/apache/flink"
} | {
"id": 22488084,
"login": "sunjincheng121",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22488084?",
"url": "https://api.github.com/users/sunjincheng121"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-05-11T05:46:45 | 5850614562 | {"actor":{"display_login":"sunjincheng121"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-quickstep/pulls/comments/112885190","pull_request_review_id":34227396,"id":112885190,"diff_hunk":"@@ -0,0 +1,230 @@\n+/**\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements. See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership. The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied. See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ **/\n+\n+#ifndef QUICKSTEP_STORAGE_THREAD_PRIVATE_COMPACT_KEY_HASH_TABLE_HPP_\n+#define QUICKSTEP_STORAGE_THREAD_PRIVATE_COMPACT_KEY_HASH_TABLE_HPP_\n+\n+#include <algorithm>\n+#include <cstddef>\n+#include <cstdint>\n+#include <unordered_map>\n+#include <vector>\n+\n+#include \"catalog/CatalogTypedefs.hpp\"\n+#include \"storage/HashTableBase.hpp\"\n+#include \"storage/StorageBlob.hpp\"\n+#include \"storage/StorageConstants.hpp\"\n+#include \"storage/ValueAccessorMultiplexer.hpp\"\n+#include \"storage/ValueAccessorUtil.hpp\"\n+#include \"types/containers/ColumnVector.hpp\"\n+#include \"utility/Macros.hpp\"\n+\n+namespace quickstep {\n+\n+class AggregationHandle;\n+class StorageManager;\n+class Type;\n+\n+/**\n+ * @brief Specialized aggregation hash table that is preferable for two-phase\n+ * aggregation with small-cardinality group-by keys. To use this hash\n+ * table, it also requires that the group-by keys have fixed-length types\n+ * with total byte size no greater than 8 (so that the keys can be packed\n+ * into a 64-bit QWORD).\n+ */\n+class ThreadPrivateCompactKeyHashTable : public AggregationStateHashTableBase {","path":"storage/ThreadPrivateCompactKeyHashTable.hpp","position":51,"original_position":51,"commit_id":"99af4690ae4462e7b6843bc92c4cb3ef31a1d75a","original_commit_id":"99af4690ae4462e7b6843bc92c4cb3ef31a1d75a","user":{"login":"zuyu","id":2245572,"avatar_url":"https://avatars3.githubusercontent.com/u/2245572?v=3","gravatar_id":"","url":"https://api.github.com/users/zuyu","html_url":"https://github.com/zuyu","followers_url":"https://api.github.com/users/zuyu/followers","following_url":"https://api.github.com/users/zuyu/following{/other_user}","gists_url":"https://api.github.com/users/zuyu/gists{/gist_id}","starred_url":"https://api.github.com/users/zuyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuyu/subscriptions","organizations_url":"https://api.github.com/users/zuyu/orgs","repos_url":"https://api.github.com/users/zuyu/repos","events_url":"https://api.github.com/users/zuyu/events{/privacy}","received_events_url":"https://api.github.com/users/zuyu/received_events","type":"User","site_admin":false},"body":"Could we mark `final` so that all `override` methods would have performance benefits?","created_at":"2017-04-24T08:02:54Z","updated_at":"2017-04-24T08:08:36Z","html_url":"https://github.com/apache/incubator-quickstep/pull/239#discussion_r112885190","pull_request_url":"https://api.github.com/repos/apache/incubator-quickstep/pulls/239","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-quickstep/pulls/comments/112885190"},"html":{"href":"https://github.com/apache/incubator-quickstep/pull/239#discussion_r112885190"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-quickstep/pulls/239"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-quickstep/pulls/239","id":117198932,"html_url":"https://github.com/apache/incubator-quickstep/pull/239","diff_url":"https://github.com/apache/incubator-quickstep/pull/239.diff","patch_url":"https://github.com/apache/incubator-quickstep/pull/239.patch","issue_url":"https://api.github.com/repos/apache/incubator-quickstep/issues/239","number":239,"state":"open","locked":false,"title":"Add ThreadPrivateCompactKeyHashTable for aggregation.","user":{"login":"jianqiao","id":2695519,"avatar_url":"https://avatars2.githubusercontent.com/u/2695519?v=3","gravatar_id":"","url":"https://api.github.com/users/jianqiao","html_url":"https://github.com/jianqiao","followers_url":"https://api.github.com/users/jianqiao/followers","following_url":"https://api.github.com/users/jianqiao/following{/other_user}","gists_url":"https://api.github.com/users/jianqiao/gists{/gist_id}","starred_url":"https://api.github.com/users/jianqiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianqiao/subscriptions","organizations_url":"https://api.github.com/users/jianqiao/orgs","repos_url":"https://api.github.com/users/jianqiao/repos","events_url":"https://api.github.com/users/jianqiao/events{/privacy}","received_events_url":"https://api.github.com/users/jianqiao/received_events","type":"User","site_admin":false},"body":"This PR implements a new specialized aggregation hash table that is preferable for two-phase (i.e. aggregate locally and then merge) aggregation with small-cardinality group-by keys. To use this hash table, it also requires that the group-by keys have fixed-length types with total byte size no greater than 8 (so that each composite key can be packed into a 64-bit QWORD).\r\n\r\nThis PR together with #237 can improve the performance TPC-H Q01 from ~11.5s to ~5.3s, with scale factor 100 on a cloud lab machine.","created_at":"2017-04-24T06:53:15Z","updated_at":"2017-04-24T08:08:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61eee26f437a58ff21246bbdf70fc82308ab85b2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-quickstep/pulls/239/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-quickstep/pulls/239/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-quickstep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-quickstep/issues/239/comments","statuses_url":"https://api.github.com/repos/apache/incubator-quickstep/statuses/99af4690ae4462e7b6843bc92c4cb3ef31a1d75a","head":{"label":"jianqiao:thread-private-compact-ht","ref":"thread-private-compact-ht","sha":"99af4690ae4462e7b6843bc92c4cb3ef31a1d75a","user":{"login":"jianqiao","id":2695519,"avatar_url":"https://avatars2.githubusercontent.com/u/2695519?v=3","gravatar_id":"","url":"https://api.github.com/users/jianqiao","html_url":"https://github.com/jianqiao","followers_url":"https://api.github.com/users/jianqiao/followers","following_url":"https://api.github.com/users/jianqiao/following{/other_user}","gists_url":"https://api.github.com/users/jianqiao/gists{/gist_id}","starred_url":"https://api.github.com/users/jianqiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianqiao/subscriptions","organizations_url":"https://api.github.com/users/jianqiao/orgs","repos_url":"https://api.github.com/users/jianqiao/repos","events_url":"https://api.github.com/users/jianqiao/events{/privacy}","received_events_url":"https://api.github.com/users/jianqiao/received_events","type":"User","site_admin":false},"repo":{"id":74168278,"name":"incubator-quickstep","full_name":"jianqiao/incubator-quickstep","owner":{"login":"jianqiao","id":2695519,"avatar_url":"https://avatars2.githubusercontent.com/u/2695519?v=3","gravatar_id":"","url":"https://api.github.com/users/jianqiao","html_url":"https://github.com/jianqiao","followers_url":"https://api.github.com/users/jianqiao/followers","following_url":"https://api.github.com/users/jianqiao/following{/other_user}","gists_url":"https://api.github.com/users/jianqiao/gists{/gist_id}","starred_url":"https://api.github.com/users/jianqiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianqiao/subscriptions","organizations_url":"https://api.github.com/users/jianqiao/orgs","repos_url":"https://api.github.com/users/jianqiao/repos","events_url":"https://api.github.com/users/jianqiao/events{/privacy}","received_events_url":"https://api.github.com/users/jianqiao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jianqiao/incubator-quickstep","description":"Mirror of Apache Quickstep Incubator","fork":true,"url":"https://api.github.com/repos/jianqiao/incubator-quickstep","forks_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/forks","keys_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/teams","hooks_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/hooks","issue_events_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/issues/events{/number}","events_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/events","assignees_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/assignees{/user}","branches_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/branches{/branch}","tags_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/tags","blobs_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/git/refs{/sha}","trees_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/statuses/{sha}","languages_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/languages","stargazers_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/stargazers","contributors_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/contributors","subscribers_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/subscribers","subscription_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/subscription","commits_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/commits{/sha}","git_commits_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/git/commits{/sha}","comments_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/comments{/number}","issue_comment_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/issues/comments{/number}","contents_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/contents/{+path}","compare_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/merges","archive_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/downloads","issues_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/issues{/number}","pulls_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/pulls{/number}","milestones_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/milestones{/number}","notifications_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/labels{/name}","releases_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/releases{/id}","deployments_url":"https://api.github.com/repos/jianqiao/incubator-quickstep/deployments","created_at":"2016-11-18T21:38:04Z","updated_at":"2016-11-19T04:33:43Z","pushed_at":"2017-04-24T06:41:38Z","git_url":"git://github.com/jianqiao/incubator-quickstep.git","ssh_url":"[email protected]:jianqiao/incubator-quickstep.git","clone_url":"https://github.com/jianqiao/incubator-quickstep.git","svn_url":"https://github.com/jianqiao/incubator-quickstep","homepage":null,"size":10617,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8169306c2923d68235ba3c0c8df4c53f5eee9a68","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":56214719,"name":"incubator-quickstep","full_name":"apache/incubator-quickstep","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-quickstep","description":"Mirror of Apache Quickstep Incubator","fork":false,"url":"https://api.github.com/repos/apache/incubator-quickstep","forks_url":"https://api.github.com/repos/apache/incubator-quickstep/forks","keys_url":"https://api.github.com/repos/apache/incubator-quickstep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-quickstep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-quickstep/teams","hooks_url":"https://api.github.com/repos/apache/incubator-quickstep/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-quickstep/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-quickstep/events","assignees_url":"https://api.github.com/repos/apache/incubator-quickstep/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-quickstep/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-quickstep/tags","blobs_url":"https://api.github.com/repos/apache/incubator-quickstep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-quickstep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-quickstep/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-quickstep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-quickstep/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-quickstep/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-quickstep/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-quickstep/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-quickstep/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-quickstep/subscription","commits_url":"https://api.github.com/repos/apache/incubator-quickstep/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-quickstep/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-quickstep/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-quickstep/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-quickstep/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-quickstep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-quickstep/merges","archive_url":"https://api.github.com/repos/apache/incubator-quickstep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-quickstep/downloads","issues_url":"https://api.github.com/repos/apache/incubator-quickstep/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-quickstep/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-quickstep/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-quickstep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-quickstep/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-quickstep/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-quickstep/deployments","created_at":"2016-04-14T07:00:07Z","updated_at":"2017-04-11T16:11:29Z","pushed_at":"2017-04-24T06:53:16Z","git_url":"git://github.com/apache/incubator-quickstep.git","ssh_url":"[email protected]:apache/incubator-quickstep.git","clone_url":"https://github.com/apache/incubator-quickstep.git","svn_url":"https://github.com/apache/incubator-quickstep","homepage":null,"size":10519,"stargazers_count":34,"watchers_count":34,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":28,"mirror_url":"git://git.apache.org/incubator-quickstep.git","open_issues_count":3,"forks":28,"open_issues":3,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-quickstep/pulls/239"},"html":{"href":"https://github.com/apache/incubator-quickstep/pull/239"},"issue":{"href":"https://api.github.com/repos/apache/incubator-quickstep/issues/239"},"comments":{"href":"https://api.github.com/repos/apache/incubator-quickstep/issues/239/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-quickstep/pulls/239/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-quickstep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-quickstep/pulls/239/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-quickstep/statuses/99af4690ae4462e7b6843bc92c4cb3ef31a1d75a"}}}} | {
"id": 56214719,
"name": "apache/incubator-quickstep",
"url": "https://api.github.com/repos/apache/incubator-quickstep"
} | {
"id": 2245572,
"login": "zuyu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2245572?",
"url": "https://api.github.com/users/zuyu"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-04-24T08:02:54 | 5742036909 | {"actor":{"display_login":"zuyu"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/98260190","pull_request_review_id":18899465,"id":98260190,"diff_hunk":"@@ -20,14 +20,13 @@\n \n /**\n * A container class for offset and timestamp.\n- *\n- * Offset must be non-negative.\n- *\n- * The timestamp should never be negative, unless it is invalid. This could happen when\n- * handling a response from a broker that doesn't support KIP-79.\n */\n public final class OffsetAndTimestamp {\n+ // The timestamp should never be negative, unless it is invalid. This could happen when","path":"clients/src/main/java/org/apache/kafka/clients/consumer/OffsetAndTimestamp.java","position":11,"original_position":11,"commit_id":"cac5c50d5d1bd25534536bfdde29181aa218d212","original_commit_id":"7c577511c38145e41de228f5f2d023e9f954c9c4","user":{"login":"cmccabe","id":1095624,"avatar_url":"https://avatars.githubusercontent.com/u/1095624?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccabe","html_url":"https://github.com/cmccabe","followers_url":"https://api.github.com/users/cmccabe/followers","following_url":"https://api.github.com/users/cmccabe/following{/other_user}","gists_url":"https://api.github.com/users/cmccabe/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccabe/subscriptions","organizations_url":"https://api.github.com/users/cmccabe/orgs","repos_url":"https://api.github.com/users/cmccabe/repos","events_url":"https://api.github.com/users/cmccabe/events{/privacy}","received_events_url":"https://api.github.com/users/cmccabe/received_events","type":"User","site_admin":false},"body":"I agree that allowing negatives here feels uncomfortable. Unfortunately, it reflects the fundamental fact that old servers are not sending back timestamps, and new servers are. I tried to create a totally separate code path for the old servers, but it was simply too much code duplication. Also unfortunately, because we need to read the offset from the structures, we cannot use static instances.\r\n\r\nProbably the best way around this problem is to stop using the public type internally. Then we can have an internal type where the timestamp is optional, and a public type where it is not. This also makes it less likely that we'll break the public API by making an internal change, so it shoudl be a good thing overall. The downside is that copying will be needed, but I don't think the amount of copying is significant for this use-case.","created_at":"2017-01-27T18:23:58Z","updated_at":"2017-01-27T18:23:58Z","html_url":"https://github.com/apache/kafka/pull/2414#discussion_r98260190","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/2414","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/98260190"},"html":{"href":"https://github.com/apache/kafka/pull/2414#discussion_r98260190"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/2414"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/2414","id":102555524,"html_url":"https://github.com/apache/kafka/pull/2414","diff_url":"https://github.com/apache/kafka/pull/2414.diff","patch_url":"https://github.com/apache/kafka/pull/2414.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/2414","number":2414,"state":"open","locked":false,"title":"KAFKA-4635: Client Compatibility follow-ups","user":{"login":"cmccabe","id":1095624,"avatar_url":"https://avatars.githubusercontent.com/u/1095624?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccabe","html_url":"https://github.com/cmccabe","followers_url":"https://api.github.com/users/cmccabe/followers","following_url":"https://api.github.com/users/cmccabe/following{/other_user}","gists_url":"https://api.github.com/users/cmccabe/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccabe/subscriptions","organizations_url":"https://api.github.com/users/cmccabe/orgs","repos_url":"https://api.github.com/users/cmccabe/repos","events_url":"https://api.github.com/users/cmccabe/events{/privacy}","received_events_url":"https://api.github.com/users/cmccabe/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-20T23:31:40Z","updated_at":"2017-01-27T18:23:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d01bc3ab2e8d8ffaf48e4b6737ce6797c38381a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/2414/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/2414/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/2414/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/cac5c50d5d1bd25534536bfdde29181aa218d212","head":{"label":"cmccabe:KAFKA-4635","ref":"KAFKA-4635","sha":"cac5c50d5d1bd25534536bfdde29181aa218d212","user":{"login":"cmccabe","id":1095624,"avatar_url":"https://avatars.githubusercontent.com/u/1095624?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccabe","html_url":"https://github.com/cmccabe","followers_url":"https://api.github.com/users/cmccabe/followers","following_url":"https://api.github.com/users/cmccabe/following{/other_user}","gists_url":"https://api.github.com/users/cmccabe/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccabe/subscriptions","organizations_url":"https://api.github.com/users/cmccabe/orgs","repos_url":"https://api.github.com/users/cmccabe/repos","events_url":"https://api.github.com/users/cmccabe/events{/privacy}","received_events_url":"https://api.github.com/users/cmccabe/received_events","type":"User","site_admin":false},"repo":{"id":74628042,"name":"kafka","full_name":"cmccabe/kafka","owner":{"login":"cmccabe","id":1095624,"avatar_url":"https://avatars.githubusercontent.com/u/1095624?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccabe","html_url":"https://github.com/cmccabe","followers_url":"https://api.github.com/users/cmccabe/followers","following_url":"https://api.github.com/users/cmccabe/following{/other_user}","gists_url":"https://api.github.com/users/cmccabe/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccabe/subscriptions","organizations_url":"https://api.github.com/users/cmccabe/orgs","repos_url":"https://api.github.com/users/cmccabe/repos","events_url":"https://api.github.com/users/cmccabe/events{/privacy}","received_events_url":"https://api.github.com/users/cmccabe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmccabe/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/cmccabe/kafka","forks_url":"https://api.github.com/repos/cmccabe/kafka/forks","keys_url":"https://api.github.com/repos/cmccabe/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmccabe/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmccabe/kafka/teams","hooks_url":"https://api.github.com/repos/cmccabe/kafka/hooks","issue_events_url":"https://api.github.com/repos/cmccabe/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/cmccabe/kafka/events","assignees_url":"https://api.github.com/repos/cmccabe/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/cmccabe/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/cmccabe/kafka/tags","blobs_url":"https://api.github.com/repos/cmccabe/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmccabe/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmccabe/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmccabe/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmccabe/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/cmccabe/kafka/languages","stargazers_url":"https://api.github.com/repos/cmccabe/kafka/stargazers","contributors_url":"https://api.github.com/repos/cmccabe/kafka/contributors","subscribers_url":"https://api.github.com/repos/cmccabe/kafka/subscribers","subscription_url":"https://api.github.com/repos/cmccabe/kafka/subscription","commits_url":"https://api.github.com/repos/cmccabe/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmccabe/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmccabe/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmccabe/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmccabe/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/cmccabe/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmccabe/kafka/merges","archive_url":"https://api.github.com/repos/cmccabe/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmccabe/kafka/downloads","issues_url":"https://api.github.com/repos/cmccabe/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/cmccabe/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/cmccabe/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/cmccabe/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmccabe/kafka/labels{/name}","releases_url":"https://api.github.com/repos/cmccabe/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/cmccabe/kafka/deployments","created_at":"2016-11-24T01:40:33Z","updated_at":"2016-11-24T01:40:38Z","pushed_at":"2017-01-27T18:11:27Z","git_url":"git://github.com/cmccabe/kafka.git","ssh_url":"[email protected]:cmccabe/kafka.git","clone_url":"https://github.com/cmccabe/kafka.git","svn_url":"https://github.com/cmccabe/kafka","homepage":null,"size":40326,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"254e3b77d656a610f19efd1124802e073dfda4b8","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2017-01-27T09:22:22Z","pushed_at":"2017-01-27T18:11:29Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"[email protected]:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":40320,"stargazers_count":4499,"watchers_count":4499,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2801,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":265,"forks":2801,"open_issues":265,"watchers":4499,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/2414"},"html":{"href":"https://github.com/apache/kafka/pull/2414"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/2414"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/2414/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/2414/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/2414/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/cac5c50d5d1bd25534536bfdde29181aa218d212"}}}} | {
"id": 2211243,
"name": "apache/kafka",
"url": "https://api.github.com/repos/apache/kafka"
} | {
"id": 1095624,
"login": "cmccabe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1095624?",
"url": "https://api.github.com/users/cmccabe"
} | {
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
} | 2017-01-27T18:23:58 | 5225472587 | {"actor":{"display_login":"cmccabe"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/appium/ruby_lib/pulls/comments/95620723","pull_request_review_id":16182105,"id":95620723,"diff_hunk":"@@ -29,7 +29,6 @@ def gray\n \n t 'buttons' do\n exp = ['Back', 'Back', 'Gray', 'Right pointing arrow']\n- exp.concat ['Add contact'] if UI::Inventory.xcuitest?","path":"ios_tests/lib/ios/specs/ios/element/button.rb","position":4,"original_position":4,"commit_id":"f2c95c401b23df6362110fd53968866ae3a1a210","original_commit_id":"f2c95c401b23df6362110fd53968866ae3a1a210","user":{"login":"KazuCocoa","id":5511591,"avatar_url":"https://avatars.githubusercontent.com/u/5511591?v=3","gravatar_id":"","url":"https://api.github.com/users/KazuCocoa","html_url":"https://github.com/KazuCocoa","followers_url":"https://api.github.com/users/KazuCocoa/followers","following_url":"https://api.github.com/users/KazuCocoa/following{/other_user}","gists_url":"https://api.github.com/users/KazuCocoa/gists{/gist_id}","starred_url":"https://api.github.com/users/KazuCocoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KazuCocoa/subscriptions","organizations_url":"https://api.github.com/users/KazuCocoa/orgs","repos_url":"https://api.github.com/users/KazuCocoa/repos","events_url":"https://api.github.com/users/KazuCocoa/events{/privacy}","received_events_url":"https://api.github.com/users/KazuCocoa/received_events","type":"User","site_admin":false},"body":"This element is hidden.","created_at":"2017-01-11T16:51:01Z","updated_at":"2017-01-11T16:54:39Z","html_url":"https://github.com/appium/ruby_lib/pull/465#discussion_r95620723","pull_request_url":"https://api.github.com/repos/appium/ruby_lib/pulls/465","_links":{"self":{"href":"https://api.github.com/repos/appium/ruby_lib/pulls/comments/95620723"},"html":{"href":"https://github.com/appium/ruby_lib/pull/465#discussion_r95620723"},"pull_request":{"href":"https://api.github.com/repos/appium/ruby_lib/pulls/465"}}},"pull_request":{"url":"https://api.github.com/repos/appium/ruby_lib/pulls/465","id":101104451,"html_url":"https://github.com/appium/ruby_lib/pull/465","diff_url":"https://github.com/appium/ruby_lib/pull/465.diff","patch_url":"https://github.com/appium/ruby_lib/pull/465.patch","issue_url":"https://api.github.com/repos/appium/ruby_lib/issues/465","number":465,"state":"open","locked":false,"title":"[WIP]fix returning only visible elements","user":{"login":"KazuCocoa","id":5511591,"avatar_url":"https://avatars.githubusercontent.com/u/5511591?v=3","gravatar_id":"","url":"https://api.github.com/users/KazuCocoa","html_url":"https://github.com/KazuCocoa","followers_url":"https://api.github.com/users/KazuCocoa/followers","following_url":"https://api.github.com/users/KazuCocoa/following{/other_user}","gists_url":"https://api.github.com/users/KazuCocoa/gists{/gist_id}","starred_url":"https://api.github.com/users/KazuCocoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KazuCocoa/subscriptions","organizations_url":"https://api.github.com/users/KazuCocoa/orgs","repos_url":"https://api.github.com/users/KazuCocoa/repos","events_url":"https://api.github.com/users/KazuCocoa/events{/privacy}","received_events_url":"https://api.github.com/users/KazuCocoa/received_events","type":"User","site_admin":false},"body":"ref: find elements except for name attributes in text/s, button/s #462\r\n\r\nThe problem current `text/s`, `button/s`, `textfield/s` return **ALL** elements **include hidden** elements. Previous implementation, UIAutomation based, return only **visible** elements, **Not ALL** elements.\r\n\r\nIn this PR, each methods start returning **visible(displayed)** elements. In addition, some methods also return visible elements same as previous behaviours.","created_at":"2017-01-11T16:49:51Z","updated_at":"2017-01-11T16:54:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6d8830ca49c30c375128198b9a4ef6f701d3153","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/appium/ruby_lib/milestones/11","html_url":"https://github.com/appium/ruby_lib/milestone/11","labels_url":"https://api.github.com/repos/appium/ruby_lib/milestones/11/labels","id":2236940,"number":11,"title":"v9.2.1","description":"","creator":{"login":"KazuCocoa","id":5511591,"avatar_url":"https://avatars.githubusercontent.com/u/5511591?v=3","gravatar_id":"","url":"https://api.github.com/users/KazuCocoa","html_url":"https://github.com/KazuCocoa","followers_url":"https://api.github.com/users/KazuCocoa/followers","following_url":"https://api.github.com/users/KazuCocoa/following{/other_user}","gists_url":"https://api.github.com/users/KazuCocoa/gists{/gist_id}","starred_url":"https://api.github.com/users/KazuCocoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KazuCocoa/subscriptions","organizations_url":"https://api.github.com/users/KazuCocoa/orgs","repos_url":"https://api.github.com/users/KazuCocoa/repos","events_url":"https://api.github.com/users/KazuCocoa/events{/privacy}","received_events_url":"https://api.github.com/users/KazuCocoa/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":2,"state":"open","created_at":"2017-01-09T13:13:45Z","updated_at":"2017-01-11T16:49:51Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/appium/ruby_lib/pulls/465/commits","review_comments_url":"https://api.github.com/repos/appium/ruby_lib/pulls/465/comments","review_comment_url":"https://api.github.com/repos/appium/ruby_lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appium/ruby_lib/issues/465/comments","statuses_url":"https://api.github.com/repos/appium/ruby_lib/statuses/f2c95c401b23df6362110fd53968866ae3a1a210","head":{"label":"KazuCocoa:return_visible_elements","ref":"return_visible_elements","sha":"f2c95c401b23df6362110fd53968866ae3a1a210","user":{"login":"KazuCocoa","id":5511591,"avatar_url":"https://avatars.githubusercontent.com/u/5511591?v=3","gravatar_id":"","url":"https://api.github.com/users/KazuCocoa","html_url":"https://github.com/KazuCocoa","followers_url":"https://api.github.com/users/KazuCocoa/followers","following_url":"https://api.github.com/users/KazuCocoa/following{/other_user}","gists_url":"https://api.github.com/users/KazuCocoa/gists{/gist_id}","starred_url":"https://api.github.com/users/KazuCocoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KazuCocoa/subscriptions","organizations_url":"https://api.github.com/users/KazuCocoa/orgs","repos_url":"https://api.github.com/users/KazuCocoa/repos","events_url":"https://api.github.com/users/KazuCocoa/events{/privacy}","received_events_url":"https://api.github.com/users/KazuCocoa/received_events","type":"User","site_admin":false},"repo":{"id":19422646,"name":"ruby_lib","full_name":"KazuCocoa/ruby_lib","owner":{"login":"KazuCocoa","id":5511591,"avatar_url":"https://avatars.githubusercontent.com/u/5511591?v=3","gravatar_id":"","url":"https://api.github.com/users/KazuCocoa","html_url":"https://github.com/KazuCocoa","followers_url":"https://api.github.com/users/KazuCocoa/followers","following_url":"https://api.github.com/users/KazuCocoa/following{/other_user}","gists_url":"https://api.github.com/users/KazuCocoa/gists{/gist_id}","starred_url":"https://api.github.com/users/KazuCocoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KazuCocoa/subscriptions","organizations_url":"https://api.github.com/users/KazuCocoa/orgs","repos_url":"https://api.github.com/users/KazuCocoa/repos","events_url":"https://api.github.com/users/KazuCocoa/events{/privacy}","received_events_url":"https://api.github.com/users/KazuCocoa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KazuCocoa/ruby_lib","description":"Ruby library for Appium","fork":true,"url":"https://api.github.com/repos/KazuCocoa/ruby_lib","forks_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/forks","keys_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/teams","hooks_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/hooks","issue_events_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/issues/events{/number}","events_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/events","assignees_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/assignees{/user}","branches_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/branches{/branch}","tags_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/tags","blobs_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/statuses/{sha}","languages_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/languages","stargazers_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/stargazers","contributors_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/contributors","subscribers_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/subscribers","subscription_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/subscription","commits_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/contents/{+path}","compare_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/merges","archive_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/downloads","issues_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/issues{/number}","pulls_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/pulls{/number}","milestones_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/milestones{/number}","notifications_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/labels{/name}","releases_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/releases{/id}","deployments_url":"https://api.github.com/repos/KazuCocoa/ruby_lib/deployments","created_at":"2014-05-04T08:56:15Z","updated_at":"2016-10-23T14:18:37Z","pushed_at":"2017-01-11T16:20:39Z","git_url":"git://github.com/KazuCocoa/ruby_lib.git","ssh_url":"[email protected]:KazuCocoa/ruby_lib.git","clone_url":"https://github.com/KazuCocoa/ruby_lib.git","svn_url":"https://github.com/KazuCocoa/ruby_lib","homepage":"http://rubygems.org/gems/appium_lib","size":5853,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appium:master","ref":"master","sha":"a1c2e9e815e9f85c929da857e26f419629d760df","user":{"login":"appium","id":3221291,"avatar_url":"https://avatars.githubusercontent.com/u/3221291?v=3","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":8938683,"name":"ruby_lib","full_name":"appium/ruby_lib","owner":{"login":"appium","id":3221291,"avatar_url":"https://avatars.githubusercontent.com/u/3221291?v=3","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appium/ruby_lib","description":":gem: Ruby library for Appium","fork":false,"url":"https://api.github.com/repos/appium/ruby_lib","forks_url":"https://api.github.com/repos/appium/ruby_lib/forks","keys_url":"https://api.github.com/repos/appium/ruby_lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/ruby_lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/ruby_lib/teams","hooks_url":"https://api.github.com/repos/appium/ruby_lib/hooks","issue_events_url":"https://api.github.com/repos/appium/ruby_lib/issues/events{/number}","events_url":"https://api.github.com/repos/appium/ruby_lib/events","assignees_url":"https://api.github.com/repos/appium/ruby_lib/assignees{/user}","branches_url":"https://api.github.com/repos/appium/ruby_lib/branches{/branch}","tags_url":"https://api.github.com/repos/appium/ruby_lib/tags","blobs_url":"https://api.github.com/repos/appium/ruby_lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/ruby_lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/ruby_lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/ruby_lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/ruby_lib/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/ruby_lib/languages","stargazers_url":"https://api.github.com/repos/appium/ruby_lib/stargazers","contributors_url":"https://api.github.com/repos/appium/ruby_lib/contributors","subscribers_url":"https://api.github.com/repos/appium/ruby_lib/subscribers","subscription_url":"https://api.github.com/repos/appium/ruby_lib/subscription","commits_url":"https://api.github.com/repos/appium/ruby_lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/ruby_lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/ruby_lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/ruby_lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/appium/ruby_lib/contents/{+path}","compare_url":"https://api.github.com/repos/appium/ruby_lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/ruby_lib/merges","archive_url":"https://api.github.com/repos/appium/ruby_lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/ruby_lib/downloads","issues_url":"https://api.github.com/repos/appium/ruby_lib/issues{/number}","pulls_url":"https://api.github.com/repos/appium/ruby_lib/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/ruby_lib/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/ruby_lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/ruby_lib/labels{/name}","releases_url":"https://api.github.com/repos/appium/ruby_lib/releases{/id}","deployments_url":"https://api.github.com/repos/appium/ruby_lib/deployments","created_at":"2013-03-21T21:07:32Z","updated_at":"2016-12-21T14:20:23Z","pushed_at":"2017-01-11T16:49:52Z","git_url":"git://github.com/appium/ruby_lib.git","ssh_url":"[email protected]:appium/ruby_lib.git","clone_url":"https://github.com/appium/ruby_lib.git","svn_url":"https://github.com/appium/ruby_lib","homepage":"http://rubygems.org/gems/appium_lib","size":5835,"stargazers_count":105,"watchers_count":105,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":126,"mirror_url":null,"open_issues_count":43,"forks":126,"open_issues":43,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appium/ruby_lib/pulls/465"},"html":{"href":"https://github.com/appium/ruby_lib/pull/465"},"issue":{"href":"https://api.github.com/repos/appium/ruby_lib/issues/465"},"comments":{"href":"https://api.github.com/repos/appium/ruby_lib/issues/465/comments"},"review_comments":{"href":"https://api.github.com/repos/appium/ruby_lib/pulls/465/comments"},"review_comment":{"href":"https://api.github.com/repos/appium/ruby_lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appium/ruby_lib/pulls/465/commits"},"statuses":{"href":"https://api.github.com/repos/appium/ruby_lib/statuses/f2c95c401b23df6362110fd53968866ae3a1a210"}}}} | {
"id": 8938683,
"name": "appium/ruby_lib",
"url": "https://api.github.com/repos/appium/ruby_lib"
} | {
"id": 5511591,
"login": "KazuCocoa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5511591?",
"url": "https://api.github.com/users/KazuCocoa"
} | {
"id": 3221291,
"login": "appium",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3221291?",
"url": "https://api.github.com/orgs/appium"
} | 2017-01-11T16:51:01 | 5137105578 | {"actor":{"display_login":"KazuCocoa"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/WebHooks/pulls/comments/150083698","pull_request_review_id":75583019,"id":150083698,"diff_hunk":"@@ -24,28 +24,12 @@ public abstract class WebHookAttribute : Attribute, IAllowAnonymous, IFilterFact\n {\n private string _id;\n \n- // TODO: Move attribute constructors' comments, especially the recommended action signatures, to class level.\n- // TODO: Do the same for all subclasses. As-is important information is hard to find.\n- /// <summary>\n- /// <para>\n- /// Instantiates a new <see cref=\"WebHookAttribute\"/> indicating the associated action is a WebHook\n- /// endpoint for all enabled receivers.\n- /// </para>\n- /// <para>The signature of the action should be:\n- /// <code>\n- /// Task{IActionResult} ActionName(string receiverName, string id, string[] events, TData data)\n- /// </code>\n- /// or the subset of parameters required. <c>TData</c> must be compatible with expected requests.\n- /// </para>\n- /// <para>This constructor should usually be used at most once in a WebHook application.</para>\n- /// <para>\n- /// The default route <see cref=\"Mvc.Routing.IRouteTemplateProvider.Name\"/> is <see langword=\"null\"/>.\n- /// </para>\n- /// </summary>\n- protected WebHookAttribute()\n+ internal WebHookAttribute()\n {\n }\n \n+ // TODO: Move attribute constructors' comments, especially the recommended action signatures, to class level.\n+ // TODO: Do the same for all subclasses. As-is important information is hard to find.","path":"src/Microsoft.AspNetCore.WebHooks.Receivers/WebHookAttribute.cs","position":28,"original_position":28,"commit_id":"3a50b95d546aafc36066c290fed9bed66670b571","original_commit_id":"3a50b95d546aafc36066c290fed9bed66670b571","user":{"login":"rynowak","id":1430011,"avatar_url":"https://avatars1.githubusercontent.com/u/1430011?v=4","gravatar_id":"","url":"https://api.github.com/users/rynowak","html_url":"https://github.com/rynowak","followers_url":"https://api.github.com/users/rynowak/followers","following_url":"https://api.github.com/users/rynowak/following{/other_user}","gists_url":"https://api.github.com/users/rynowak/gists{/gist_id}","starred_url":"https://api.github.com/users/rynowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynowak/subscriptions","organizations_url":"https://api.github.com/users/rynowak/orgs","repos_url":"https://api.github.com/users/rynowak/repos","events_url":"https://api.github.com/users/rynowak/events{/privacy}","received_events_url":"https://api.github.com/users/rynowak/received_events","type":"User","site_admin":false},"body":"Can we use issues for these things instead of comments?","created_at":"2017-11-09T20:53:58Z","updated_at":"2017-11-09T20:53:58Z","html_url":"https://github.com/aspnet/WebHooks/pull/172#discussion_r150083698","pull_request_url":"https://api.github.com/repos/aspnet/WebHooks/pulls/172","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aspnet/WebHooks/pulls/comments/150083698"},"html":{"href":"https://github.com/aspnet/WebHooks/pull/172#discussion_r150083698"},"pull_request":{"href":"https://api.github.com/repos/aspnet/WebHooks/pulls/172"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/WebHooks/pulls/172","id":149625194,"html_url":"https://github.com/aspnet/WebHooks/pull/172","diff_url":"https://github.com/aspnet/WebHooks/pull/172.diff","patch_url":"https://github.com/aspnet/WebHooks/pull/172.patch","issue_url":"https://api.github.com/repos/aspnet/WebHooks/issues/172","number":172,"state":"open","locked":false,"title":"Address some PR comments from #153","user":{"login":"dougbu","id":6431421,"avatar_url":"https://avatars1.githubusercontent.com/u/6431421?v=4","gravatar_id":"","url":"https://api.github.com/users/dougbu","html_url":"https://github.com/dougbu","followers_url":"https://api.github.com/users/dougbu/followers","following_url":"https://api.github.com/users/dougbu/following{/other_user}","gists_url":"https://api.github.com/users/dougbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dougbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougbu/subscriptions","organizations_url":"https://api.github.com/users/dougbu/orgs","repos_url":"https://api.github.com/users/dougbu/repos","events_url":"https://api.github.com/users/dougbu/events{/privacy}","received_events_url":"https://api.github.com/users/dougbu/received_events","type":"User","site_admin":false},"body":"- more for #5\r\n- grab some fixes from aspnet/AspNetWebStack repo\r\n- revamp `IConfiguration` use\r\n - remove `IWebHookReceiverConfig`, its implementation and extension methods\r\n - make methods synchronous if they were `async` only for configuration lookups\r\n - remove configuration value caching in `PusherVerifySignatureFilter`\r\n- remove `HttpRequest.IsLocal()` extension method\r\n - instead check for development environment\r\n- move JSON and XML dependencies into specific receiver projects\r\n- make default `WebHookAttribute` constructor `internal` and move its doc comments to `GeneralWebHookAttribute`\r\n- add `WebHookConstants.EventKeyNames`\r\n - add `RouteData.TryGetEventName(...)` extension method; `WebHookPingResponseFilter` does not need full array\r\n\r\nNote this PR does not close questions @rynowak and I had left unfinished in #153.","created_at":"2017-10-30T20:11:17Z","updated_at":"2017-11-09T20:53:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d245c2902f5efe70bc8e5ad9924130b5a4a4f9d","assignee":{"login":"rynowak","id":1430011,"avatar_url":"https://avatars1.githubusercontent.com/u/1430011?v=4","gravatar_id":"","url":"https://api.github.com/users/rynowak","html_url":"https://github.com/rynowak","followers_url":"https://api.github.com/users/rynowak/followers","following_url":"https://api.github.com/users/rynowak/following{/other_user}","gists_url":"https://api.github.com/users/rynowak/gists{/gist_id}","starred_url":"https://api.github.com/users/rynowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynowak/subscriptions","organizations_url":"https://api.github.com/users/rynowak/orgs","repos_url":"https://api.github.com/users/rynowak/repos","events_url":"https://api.github.com/users/rynowak/events{/privacy}","received_events_url":"https://api.github.com/users/rynowak/received_events","type":"User","site_admin":false},"assignees":[{"login":"rynowak","id":1430011,"avatar_url":"https://avatars1.githubusercontent.com/u/1430011?v=4","gravatar_id":"","url":"https://api.github.com/users/rynowak","html_url":"https://github.com/rynowak","followers_url":"https://api.github.com/users/rynowak/followers","following_url":"https://api.github.com/users/rynowak/following{/other_user}","gists_url":"https://api.github.com/users/rynowak/gists{/gist_id}","starred_url":"https://api.github.com/users/rynowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynowak/subscriptions","organizations_url":"https://api.github.com/users/rynowak/orgs","repos_url":"https://api.github.com/users/rynowak/repos","events_url":"https://api.github.com/users/rynowak/events{/privacy}","received_events_url":"https://api.github.com/users/rynowak/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"davidfowl","id":95136,"avatar_url":"https://avatars3.githubusercontent.com/u/95136?v=4","gravatar_id":"","url":"https://api.github.com/users/davidfowl","html_url":"https://github.com/davidfowl","followers_url":"https://api.github.com/users/davidfowl/followers","following_url":"https://api.github.com/users/davidfowl/following{/other_user}","gists_url":"https://api.github.com/users/davidfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfowl/subscriptions","organizations_url":"https://api.github.com/users/davidfowl/orgs","repos_url":"https://api.github.com/users/davidfowl/repos","events_url":"https://api.github.com/users/davidfowl/events{/privacy}","received_events_url":"https://api.github.com/users/davidfowl/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/WebHooks/pulls/172/commits","review_comments_url":"https://api.github.com/repos/aspnet/WebHooks/pulls/172/comments","review_comment_url":"https://api.github.com/repos/aspnet/WebHooks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/WebHooks/issues/172/comments","statuses_url":"https://api.github.com/repos/aspnet/WebHooks/statuses/3a50b95d546aafc36066c290fed9bed66670b571","head":{"label":"aspnet:dougbu/pr.153.comments","ref":"dougbu/pr.153.comments","sha":"3a50b95d546aafc36066c290fed9bed66670b571","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":39802789,"name":"WebHooks","full_name":"aspnet/WebHooks","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/WebHooks","description":"Libraries to create and consume web hooks","fork":false,"url":"https://api.github.com/repos/aspnet/WebHooks","forks_url":"https://api.github.com/repos/aspnet/WebHooks/forks","keys_url":"https://api.github.com/repos/aspnet/WebHooks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/WebHooks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/WebHooks/teams","hooks_url":"https://api.github.com/repos/aspnet/WebHooks/hooks","issue_events_url":"https://api.github.com/repos/aspnet/WebHooks/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/WebHooks/events","assignees_url":"https://api.github.com/repos/aspnet/WebHooks/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/WebHooks/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/WebHooks/tags","blobs_url":"https://api.github.com/repos/aspnet/WebHooks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/WebHooks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/WebHooks/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/WebHooks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/WebHooks/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/WebHooks/languages","stargazers_url":"https://api.github.com/repos/aspnet/WebHooks/stargazers","contributors_url":"https://api.github.com/repos/aspnet/WebHooks/contributors","subscribers_url":"https://api.github.com/repos/aspnet/WebHooks/subscribers","subscription_url":"https://api.github.com/repos/aspnet/WebHooks/subscription","commits_url":"https://api.github.com/repos/aspnet/WebHooks/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/WebHooks/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/WebHooks/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/WebHooks/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/WebHooks/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/WebHooks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/WebHooks/merges","archive_url":"https://api.github.com/repos/aspnet/WebHooks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/WebHooks/downloads","issues_url":"https://api.github.com/repos/aspnet/WebHooks/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/WebHooks/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/WebHooks/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/WebHooks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/WebHooks/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/WebHooks/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/WebHooks/deployments","created_at":"2015-07-27T23:27:08Z","updated_at":"2017-11-09T13:38:05Z","pushed_at":"2017-11-09T17:03:58Z","git_url":"git://github.com/aspnet/WebHooks.git","ssh_url":"[email protected]:aspnet/WebHooks.git","clone_url":"https://github.com/aspnet/WebHooks.git","svn_url":"https://github.com/aspnet/WebHooks","homepage":null,"size":1845,"stargazers_count":460,"watchers_count":460,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":255,"mirror_url":null,"archived":false,"open_issues_count":48,"forks":255,"open_issues":48,"watchers":460,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"5f62336e30c2d68d6ae3e348eaa57f84b5e7d439","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":39802789,"name":"WebHooks","full_name":"aspnet/WebHooks","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/WebHooks","description":"Libraries to create and consume web hooks","fork":false,"url":"https://api.github.com/repos/aspnet/WebHooks","forks_url":"https://api.github.com/repos/aspnet/WebHooks/forks","keys_url":"https://api.github.com/repos/aspnet/WebHooks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/WebHooks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/WebHooks/teams","hooks_url":"https://api.github.com/repos/aspnet/WebHooks/hooks","issue_events_url":"https://api.github.com/repos/aspnet/WebHooks/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/WebHooks/events","assignees_url":"https://api.github.com/repos/aspnet/WebHooks/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/WebHooks/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/WebHooks/tags","blobs_url":"https://api.github.com/repos/aspnet/WebHooks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/WebHooks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/WebHooks/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/WebHooks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/WebHooks/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/WebHooks/languages","stargazers_url":"https://api.github.com/repos/aspnet/WebHooks/stargazers","contributors_url":"https://api.github.com/repos/aspnet/WebHooks/contributors","subscribers_url":"https://api.github.com/repos/aspnet/WebHooks/subscribers","subscription_url":"https://api.github.com/repos/aspnet/WebHooks/subscription","commits_url":"https://api.github.com/repos/aspnet/WebHooks/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/WebHooks/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/WebHooks/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/WebHooks/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/WebHooks/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/WebHooks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/WebHooks/merges","archive_url":"https://api.github.com/repos/aspnet/WebHooks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/WebHooks/downloads","issues_url":"https://api.github.com/repos/aspnet/WebHooks/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/WebHooks/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/WebHooks/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/WebHooks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/WebHooks/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/WebHooks/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/WebHooks/deployments","created_at":"2015-07-27T23:27:08Z","updated_at":"2017-11-09T13:38:05Z","pushed_at":"2017-11-09T17:03:58Z","git_url":"git://github.com/aspnet/WebHooks.git","ssh_url":"[email protected]:aspnet/WebHooks.git","clone_url":"https://github.com/aspnet/WebHooks.git","svn_url":"https://github.com/aspnet/WebHooks","homepage":null,"size":1845,"stargazers_count":460,"watchers_count":460,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":255,"mirror_url":null,"archived":false,"open_issues_count":48,"forks":255,"open_issues":48,"watchers":460,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/WebHooks/pulls/172"},"html":{"href":"https://github.com/aspnet/WebHooks/pull/172"},"issue":{"href":"https://api.github.com/repos/aspnet/WebHooks/issues/172"},"comments":{"href":"https://api.github.com/repos/aspnet/WebHooks/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/WebHooks/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/WebHooks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/WebHooks/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/WebHooks/statuses/3a50b95d546aafc36066c290fed9bed66670b571"}},"author_association":"MEMBER"}} | {
"id": 39802789,
"name": "aspnet/WebHooks",
"url": "https://api.github.com/repos/aspnet/WebHooks"
} | {
"id": 1430011,
"login": "rynowak",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1430011?",
"url": "https://api.github.com/users/rynowak"
} | {
"id": 6476660,
"login": "aspnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6476660?",
"url": "https://api.github.com/orgs/aspnet"
} | 2017-11-09T20:53:58 | 6834446180 | {"actor":{"display_login":"rynowak"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Razor/pulls/comments/107562210","pull_request_review_id":28542686,"id":107562210,"diff_hunk":"@@ -60,6 +62,19 @@ public void AddLineMappingFor(RazorIRNode node)\n return;\n }\n \n+ var imports = CodeDocument.GetImportSyntaxTrees();\n+ if (imports != null)\n+ {\n+ foreach (var import in imports)\n+ {\n+ if (string.Equals(import.Source.FileName, node.Source.Value.FilePath, StringComparison.Ordinal))","path":"src/Microsoft.AspNetCore.Razor.Evolution/CodeGeneration/CSharpRenderingContext.cs","position":20,"original_position":20,"commit_id":"4d7fb5f8044d2665557ccf57fb370b7a10215ba6","original_commit_id":"4d7fb5f8044d2665557ccf57fb370b7a10215ba6","user":{"login":"NTaylorMullen","id":2008729,"avatar_url":"https://avatars0.githubusercontent.com/u/2008729?v=3","gravatar_id":"","url":"https://api.github.com/users/NTaylorMullen","html_url":"https://github.com/NTaylorMullen","followers_url":"https://api.github.com/users/NTaylorMullen/followers","following_url":"https://api.github.com/users/NTaylorMullen/following{/other_user}","gists_url":"https://api.github.com/users/NTaylorMullen/gists{/gist_id}","starred_url":"https://api.github.com/users/NTaylorMullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NTaylorMullen/subscriptions","organizations_url":"https://api.github.com/users/NTaylorMullen/orgs","repos_url":"https://api.github.com/users/NTaylorMullen/repos","events_url":"https://api.github.com/users/NTaylorMullen/events{/privacy}","received_events_url":"https://api.github.com/users/NTaylorMullen/received_events","type":"User","site_admin":false},"body":"Case insensitive","created_at":"2017-03-23T00:03:27Z","updated_at":"2017-03-23T00:10:36Z","html_url":"https://github.com/aspnet/Razor/pull/1112#discussion_r107562210","pull_request_url":"https://api.github.com/repos/aspnet/Razor/pulls/1112","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/comments/107562210"},"html":{"href":"https://github.com/aspnet/Razor/pull/1112#discussion_r107562210"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/1112"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Razor/pulls/1112","id":112135971,"html_url":"https://github.com/aspnet/Razor/pull/1112","diff_url":"https://github.com/aspnet/Razor/pull/1112.diff","patch_url":"https://github.com/aspnet/Razor/pull/1112.patch","issue_url":"https://api.github.com/repos/aspnet/Razor/issues/1112","number":1112,"state":"open","locked":false,"title":"Don't generate line mappings for imports","user":{"login":"ajaybhargavb","id":1579269,"avatar_url":"https://avatars3.githubusercontent.com/u/1579269?v=3","gravatar_id":"","url":"https://api.github.com/users/ajaybhargavb","html_url":"https://github.com/ajaybhargavb","followers_url":"https://api.github.com/users/ajaybhargavb/followers","following_url":"https://api.github.com/users/ajaybhargavb/following{/other_user}","gists_url":"https://api.github.com/users/ajaybhargavb/gists{/gist_id}","starred_url":"https://api.github.com/users/ajaybhargavb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajaybhargavb/subscriptions","organizations_url":"https://api.github.com/users/ajaybhargavb/orgs","repos_url":"https://api.github.com/users/ajaybhargavb/repos","events_url":"https://api.github.com/users/ajaybhargavb/events{/privacy}","received_events_url":"https://api.github.com/users/ajaybhargavb/received_events","type":"User","site_admin":false},"body":"Issue - #1079 \r\n\r\n@NTaylorMullen @rynowak ","created_at":"2017-03-22T23:53:15Z","updated_at":"2017-03-23T00:10:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c01044f020ddcd964d92ea774ee06d5b2b54da3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Razor/pulls/1112/commits","review_comments_url":"https://api.github.com/repos/aspnet/Razor/pulls/1112/comments","review_comment_url":"https://api.github.com/repos/aspnet/Razor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Razor/issues/1112/comments","statuses_url":"https://api.github.com/repos/aspnet/Razor/statuses/4d7fb5f8044d2665557ccf57fb370b7a10215ba6","head":{"label":"aspnet:ajbaaska/line-mapping","ref":"ajbaaska/line-mapping","sha":"4d7fb5f8044d2665557ccf57fb370b7a10215ba6","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars0.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15835991,"name":"Razor","full_name":"aspnet/Razor","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars0.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Razor","description":"Parser and code generator for CSHTML files used in view pages for MVC web apps.","fork":false,"url":"https://api.github.com/repos/aspnet/Razor","forks_url":"https://api.github.com/repos/aspnet/Razor/forks","keys_url":"https://api.github.com/repos/aspnet/Razor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Razor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Razor/teams","hooks_url":"https://api.github.com/repos/aspnet/Razor/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Razor/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Razor/events","assignees_url":"https://api.github.com/repos/aspnet/Razor/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Razor/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Razor/tags","blobs_url":"https://api.github.com/repos/aspnet/Razor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Razor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Razor/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Razor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Razor/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Razor/languages","stargazers_url":"https://api.github.com/repos/aspnet/Razor/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Razor/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Razor/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Razor/subscription","commits_url":"https://api.github.com/repos/aspnet/Razor/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Razor/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Razor/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Razor/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Razor/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Razor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Razor/merges","archive_url":"https://api.github.com/repos/aspnet/Razor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Razor/downloads","issues_url":"https://api.github.com/repos/aspnet/Razor/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Razor/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Razor/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Razor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Razor/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Razor/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Razor/deployments","created_at":"2014-01-12T03:52:46Z","updated_at":"2017-03-21T20:31:02Z","pushed_at":"2017-03-22T23:58:51Z","git_url":"git://github.com/aspnet/Razor.git","ssh_url":"[email protected]:aspnet/Razor.git","clone_url":"https://github.com/aspnet/Razor.git","svn_url":"https://github.com/aspnet/Razor","homepage":"","size":7100,"stargazers_count":632,"watchers_count":632,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":181,"mirror_url":null,"open_issues_count":124,"forks":181,"open_issues":124,"watchers":632,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"c07759996fae51563a07d8034d978583b030a410","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars0.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15835991,"name":"Razor","full_name":"aspnet/Razor","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars0.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Razor","description":"Parser and code generator for CSHTML files used in view pages for MVC web apps.","fork":false,"url":"https://api.github.com/repos/aspnet/Razor","forks_url":"https://api.github.com/repos/aspnet/Razor/forks","keys_url":"https://api.github.com/repos/aspnet/Razor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Razor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Razor/teams","hooks_url":"https://api.github.com/repos/aspnet/Razor/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Razor/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Razor/events","assignees_url":"https://api.github.com/repos/aspnet/Razor/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Razor/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Razor/tags","blobs_url":"https://api.github.com/repos/aspnet/Razor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Razor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Razor/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Razor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Razor/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Razor/languages","stargazers_url":"https://api.github.com/repos/aspnet/Razor/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Razor/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Razor/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Razor/subscription","commits_url":"https://api.github.com/repos/aspnet/Razor/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Razor/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Razor/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Razor/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Razor/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Razor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Razor/merges","archive_url":"https://api.github.com/repos/aspnet/Razor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Razor/downloads","issues_url":"https://api.github.com/repos/aspnet/Razor/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Razor/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Razor/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Razor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Razor/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Razor/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Razor/deployments","created_at":"2014-01-12T03:52:46Z","updated_at":"2017-03-21T20:31:02Z","pushed_at":"2017-03-22T23:58:51Z","git_url":"git://github.com/aspnet/Razor.git","ssh_url":"[email protected]:aspnet/Razor.git","clone_url":"https://github.com/aspnet/Razor.git","svn_url":"https://github.com/aspnet/Razor","homepage":"","size":7100,"stargazers_count":632,"watchers_count":632,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":181,"mirror_url":null,"open_issues_count":124,"forks":181,"open_issues":124,"watchers":632,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/1112"},"html":{"href":"https://github.com/aspnet/Razor/pull/1112"},"issue":{"href":"https://api.github.com/repos/aspnet/Razor/issues/1112"},"comments":{"href":"https://api.github.com/repos/aspnet/Razor/issues/1112/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/1112/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/1112/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Razor/statuses/4d7fb5f8044d2665557ccf57fb370b7a10215ba6"}}}} | {
"id": 15835991,
"name": "aspnet/Razor",
"url": "https://api.github.com/repos/aspnet/Razor"
} | {
"id": 2008729,
"login": "NTaylorMullen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2008729?",
"url": "https://api.github.com/users/NTaylorMullen"
} | {
"id": 6476660,
"login": "aspnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6476660?",
"url": "https://api.github.com/orgs/aspnet"
} | 2017-03-23T00:03:27 | 5546256908 | {"actor":{"display_login":"NTaylorMullen"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/comments/110308525","pull_request_review_id":31472972,"id":110308525,"diff_hunk":"@@ -0,0 +1,84 @@\n+// Copyright (c) .NET Foundation. All rights reserved.\n+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.\n+\n+using System;\n+using System.Collections.Generic;\n+using System.Diagnostics;\n+using Microsoft.AspNetCore.Http.Headers;\n+using Microsoft.Extensions.Primitives;\n+using Microsoft.Net.Http.Headers;\n+\n+namespace Microsoft.AspNetCore.Http.Extensions\n+{\n+ /// <summary>\n+ /// Provides a parser for the Range Header in an <see cref=\"HttpContext.Request\"/>.\n+ /// </summary>\n+ public class RangeParser\n+ {\n+ /// <summary>\n+ /// Returns the requested range if the Range Header in the <see cref=\"HttpContext.Request\"/> is valid.\n+ /// </summary>\n+ /// <param name=\"context\">The <see cref=\"HttpContext\"/> associated with the request.</param>\n+ /// <param name=\"requestHeaders\">The <see cref=\"RequestHeaders\"/> associated with the given <paramref name=\"context\"/>.</param>\n+ /// <param name=\"lastModified\">The <see cref=\"DateTimeOffset\"/> representation of the last modified date of the file.</param>\n+ /// <param name=\"etag\">The <see cref=\"EntityTagHeaderValue\"/> provided in the <see cref=\"HttpContext.Request\"/>.</param>\n+ /// <returns>A collection of <see cref=\"RangeItemHeaderValue\"/> containing the ranges parsed from the <paramref name=\"requestHeaders\"/>.</returns>\n+ public static ICollection<RangeItemHeaderValue> ParseRange(HttpContext context, RequestHeaders requestHeaders, DateTimeOffset? lastModified = null, EntityTagHeaderValue etag = null)\n+ {\n+ var rawRangeHeader = context.Request.Headers[HeaderNames.Range];\n+ if (StringValues.IsNullOrEmpty(rawRangeHeader))\n+ {\n+ return null;\n+ }\n+\n+ // Perf: Check for a single entry before parsing it\n+ if (rawRangeHeader.Count > 1 || rawRangeHeader[0].IndexOf(',') >= 0)\n+ {\n+ // The spec allows for multiple ranges but we choose not to support them because the client may request\n+ // very strange ranges (e.g. each byte separately, overlapping ranges, etc.) that could negatively\n+ // impact the server. Ignore the header and serve the response normally. \n+ return null;\n+ }\n+\n+ var rangeHeader = requestHeaders.Range;\n+ if (rangeHeader == null)\n+ {\n+ // Invalid\n+ return null;\n+ }\n+\n+ // Already verified above\n+ Debug.Assert(rangeHeader.Ranges.Count == 1);\n+\n+ // 14.27 If-Range\n+ var ifRangeHeader = requestHeaders.IfRange;\n+ if (ifRangeHeader != null)\n+ {\n+ // If the validator given in the If-Range header field matches the\n+ // current validator for the selected representation of the target\n+ // resource, then the server SHOULD process the Range header field as\n+ // requested. If the validator does not match, the server MUST ignore\n+ // the Range header field.\n+ bool ignoreRangeHeader = false;\n+ if (ifRangeHeader.LastModified.HasValue)\n+ {\n+ if (lastModified != null && lastModified > ifRangeHeader.LastModified)","path":"src/Microsoft.AspNetCore.Http.Extensions/RangeParser.cs","position":65,"original_position":65,"commit_id":"02ff081c688411e67506e905b5bc510de8dc1b9d","original_commit_id":"02ff081c688411e67506e905b5bc510de8dc1b9d","user":{"login":"Tratcher","id":1821173,"avatar_url":"https://avatars0.githubusercontent.com/u/1821173?v=3","gravatar_id":"","url":"https://api.github.com/users/Tratcher","html_url":"https://github.com/Tratcher","followers_url":"https://api.github.com/users/Tratcher/followers","following_url":"https://api.github.com/users/Tratcher/following{/other_user}","gists_url":"https://api.github.com/users/Tratcher/gists{/gist_id}","starred_url":"https://api.github.com/users/Tratcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tratcher/subscriptions","organizations_url":"https://api.github.com/users/Tratcher/orgs","repos_url":"https://api.github.com/users/Tratcher/repos","events_url":"https://api.github.com/users/Tratcher/events{/privacy}","received_events_url":"https://api.github.com/users/Tratcher/received_events","type":"User","site_admin":false},"body":"!lastModified.HasValue","created_at":"2017-04-07T02:54:54Z","updated_at":"2017-04-07T02:56:23Z","html_url":"https://github.com/aspnet/HttpAbstractions/pull/807#discussion_r110308525","pull_request_url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/807","_links":{"self":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/comments/110308525"},"html":{"href":"https://github.com/aspnet/HttpAbstractions/pull/807#discussion_r110308525"},"pull_request":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/807"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/807","id":113736798,"html_url":"https://github.com/aspnet/HttpAbstractions/pull/807","diff_url":"https://github.com/aspnet/HttpAbstractions/pull/807.diff","patch_url":"https://github.com/aspnet/HttpAbstractions/pull/807.patch","issue_url":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/807","number":807,"state":"open","locked":false,"title":"Add ByteRangeHelper","user":{"login":"jbagga","id":6234561,"avatar_url":"https://avatars3.githubusercontent.com/u/6234561?v=3","gravatar_id":"","url":"https://api.github.com/users/jbagga","html_url":"https://github.com/jbagga","followers_url":"https://api.github.com/users/jbagga/followers","following_url":"https://api.github.com/users/jbagga/following{/other_user}","gists_url":"https://api.github.com/users/jbagga/gists{/gist_id}","starred_url":"https://api.github.com/users/jbagga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbagga/subscriptions","organizations_url":"https://api.github.com/users/jbagga/orgs","repos_url":"https://api.github.com/users/jbagga/repos","events_url":"https://api.github.com/users/jbagga/events{/privacy}","received_events_url":"https://api.github.com/users/jbagga/received_events","type":"User","site_admin":false},"body":"Moved [RangeHelper](https://github.com/aspnet/StaticFiles/blob/dev/src/Microsoft.AspNetCore.StaticFiles/Infrastructure/RangeHelpers.cs) from StaticFiles and added tests\r\n\r\nSee aspnet/Mvc#3702\r\n\r\ncc @Tratcher @pranavkm ","created_at":"2017-03-31T21:31:46Z","updated_at":"2017-04-07T02:56:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bf0708fd89cd7acb480485c94f0c90f10e8fa7b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/807/commits","review_comments_url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/807/comments","review_comment_url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/807/comments","statuses_url":"https://api.github.com/repos/aspnet/HttpAbstractions/statuses/02ff081c688411e67506e905b5bc510de8dc1b9d","head":{"label":"aspnet:jbagga/ByteRangeHelper","ref":"jbagga/ByteRangeHelper","sha":"02ff081c688411e67506e905b5bc510de8dc1b9d","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars0.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15320915,"name":"HttpAbstractions","full_name":"aspnet/HttpAbstractions","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars0.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/HttpAbstractions","description":"HTTP abstractions such as HttpRequest, HttpResponse, and HttpContext, as well as common web utilities.","fork":false,"url":"https://api.github.com/repos/aspnet/HttpAbstractions","forks_url":"https://api.github.com/repos/aspnet/HttpAbstractions/forks","keys_url":"https://api.github.com/repos/aspnet/HttpAbstractions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/HttpAbstractions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/HttpAbstractions/teams","hooks_url":"https://api.github.com/repos/aspnet/HttpAbstractions/hooks","issue_events_url":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/HttpAbstractions/events","assignees_url":"https://api.github.com/repos/aspnet/HttpAbstractions/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/HttpAbstractions/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/HttpAbstractions/tags","blobs_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/HttpAbstractions/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/HttpAbstractions/languages","stargazers_url":"https://api.github.com/repos/aspnet/HttpAbstractions/stargazers","contributors_url":"https://api.github.com/repos/aspnet/HttpAbstractions/contributors","subscribers_url":"https://api.github.com/repos/aspnet/HttpAbstractions/subscribers","subscription_url":"https://api.github.com/repos/aspnet/HttpAbstractions/subscription","commits_url":"https://api.github.com/repos/aspnet/HttpAbstractions/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/HttpAbstractions/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/HttpAbstractions/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/HttpAbstractions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/HttpAbstractions/merges","archive_url":"https://api.github.com/repos/aspnet/HttpAbstractions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/HttpAbstractions/downloads","issues_url":"https://api.github.com/repos/aspnet/HttpAbstractions/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/HttpAbstractions/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/HttpAbstractions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/HttpAbstractions/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/HttpAbstractions/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/HttpAbstractions/deployments","created_at":"2013-12-19T19:38:45Z","updated_at":"2017-04-07T01:42:23Z","pushed_at":"2017-04-07T00:33:58Z","git_url":"git://github.com/aspnet/HttpAbstractions.git","ssh_url":"[email protected]:aspnet/HttpAbstractions.git","clone_url":"https://github.com/aspnet/HttpAbstractions.git","svn_url":"https://github.com/aspnet/HttpAbstractions","homepage":"","size":2811,"stargazers_count":207,"watchers_count":207,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"open_issues_count":64,"forks":117,"open_issues":64,"watchers":207,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"f264659c959a0fbaf98a1078c268929131b7b924","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars0.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15320915,"name":"HttpAbstractions","full_name":"aspnet/HttpAbstractions","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars0.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/HttpAbstractions","description":"HTTP abstractions such as HttpRequest, HttpResponse, and HttpContext, as well as common web utilities.","fork":false,"url":"https://api.github.com/repos/aspnet/HttpAbstractions","forks_url":"https://api.github.com/repos/aspnet/HttpAbstractions/forks","keys_url":"https://api.github.com/repos/aspnet/HttpAbstractions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/HttpAbstractions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/HttpAbstractions/teams","hooks_url":"https://api.github.com/repos/aspnet/HttpAbstractions/hooks","issue_events_url":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/HttpAbstractions/events","assignees_url":"https://api.github.com/repos/aspnet/HttpAbstractions/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/HttpAbstractions/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/HttpAbstractions/tags","blobs_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/HttpAbstractions/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/HttpAbstractions/languages","stargazers_url":"https://api.github.com/repos/aspnet/HttpAbstractions/stargazers","contributors_url":"https://api.github.com/repos/aspnet/HttpAbstractions/contributors","subscribers_url":"https://api.github.com/repos/aspnet/HttpAbstractions/subscribers","subscription_url":"https://api.github.com/repos/aspnet/HttpAbstractions/subscription","commits_url":"https://api.github.com/repos/aspnet/HttpAbstractions/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/HttpAbstractions/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/HttpAbstractions/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/HttpAbstractions/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/HttpAbstractions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/HttpAbstractions/merges","archive_url":"https://api.github.com/repos/aspnet/HttpAbstractions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/HttpAbstractions/downloads","issues_url":"https://api.github.com/repos/aspnet/HttpAbstractions/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/HttpAbstractions/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/HttpAbstractions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/HttpAbstractions/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/HttpAbstractions/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/HttpAbstractions/deployments","created_at":"2013-12-19T19:38:45Z","updated_at":"2017-04-07T01:42:23Z","pushed_at":"2017-04-07T00:33:58Z","git_url":"git://github.com/aspnet/HttpAbstractions.git","ssh_url":"[email protected]:aspnet/HttpAbstractions.git","clone_url":"https://github.com/aspnet/HttpAbstractions.git","svn_url":"https://github.com/aspnet/HttpAbstractions","homepage":"","size":2811,"stargazers_count":207,"watchers_count":207,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"open_issues_count":64,"forks":117,"open_issues":64,"watchers":207,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/807"},"html":{"href":"https://github.com/aspnet/HttpAbstractions/pull/807"},"issue":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/807"},"comments":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/issues/807/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/807/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/pulls/807/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/HttpAbstractions/statuses/02ff081c688411e67506e905b5bc510de8dc1b9d"}}}} | {
"id": 15320915,
"name": "aspnet/HttpAbstractions",
"url": "https://api.github.com/repos/aspnet/HttpAbstractions"
} | {
"id": 1821173,
"login": "Tratcher",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1821173?",
"url": "https://api.github.com/users/Tratcher"
} | {
"id": 6476660,
"login": "aspnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6476660?",
"url": "https://api.github.com/orgs/aspnet"
} | 2017-04-07T02:54:54 | 5643981422 | {"actor":{"display_login":"Tratcher"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Docs/pulls/comments/131779486","pull_request_review_id":54760419,"id":131779486,"diff_hunk":"@@ -27,37 +27,192 @@ Kestrel supports the following features:\n \n Kestrel is supported on all platforms and versions that .NET Core supports.\n \n+# [ASP.NET Core 1.x](#tab/aspnetcore1x)\n+\n [View or download sample code](https://github.com/aspnet/Docs/tree/master/aspnetcore/fundamentals/servers/kestrel/sample)\n \n+# [ASP.NET Core 2.x](#tab/aspnetcore2x)\n+\n+[View or download sample code](https://github.com/aspnet/Docs/tree/master/aspnetcore/fundamentals/servers/kestrel/sample2)\n+\n+---\n+\n ## When to use Kestrel with a reverse proxy\n \n+# [ASP.NET Core 1.x](#tab/aspnetcore1x)\n+\n If your application accepts requests only from an internal network, you can use Kestrel by itself.\n \n \n \n If you expose your application to the Internet, you must use IIS, Nginx, or Apache as a *reverse proxy server*. A reverse proxy server receives HTTP requests from the Internet and forwards them to Kestrel after some preliminary handling.\n \n-\n+\n \n A reverse proxy is required for edge deployments (exposed to traffic from the Internet) for security reasons. Kestrel is relatively new and does not yet have a full complement of defenses against attacks. This includes but isn't limited to appropriate timeouts, size limits, and concurrent connection limits.\n \n-Another scenario that requires a reverse proxy is when you have multiple applications that share the same port running on a single server. That doesn't work with Kestrel directly because Kestrel doesn't support sharing a port between multiple processes. When you configure Kestrel to listen on a port, it handles all traffic for that port regardless of host header. A reverse proxy that can share ports must then forward to Kestrel on a unique port.\n+# [ASP.NET Core 2.x](#tab/aspnetcore2x)\n+\n+If your application accepts requests only from an internal network, you can use Kestrel by itself.\n+\n+\n+\n+If you expose your application to the Internet, you can use Kestrel by itself or with a *reverse proxy server*, such as IIS, Nginx, or Apache. A reverse proxy server receives HTTP requests from the Internet and forwards them to Kestrel after some preliminary handling.\n+\n+\n+\n+\n+\n+---\n+\n+A scenario that requires a reverse proxy is when you have multiple applications that share the same port running on a single server. That doesn't work with Kestrel directly because Kestrel doesn't support sharing a port between multiple processes. When you configure Kestrel to listen on a port, it handles all traffic for that port regardless of host header. A reverse proxy that can share ports must then forward to Kestrel on a unique port.\n \n Even if a reverse proxy server isn't required, using one can simplify load balancing and SSL set-up -- only your reverse proxy server requires an SSL certificate, and that server can communicate with your application servers on the internal network using plain HTTP.\n \n ## How to use Kestrel in ASP.NET Core apps\n \n+# [ASP.NET Core 1.x](#tab/aspnetcore1x)\n+\n Install the [Microsoft.AspNetCore.Server.Kestrel](https://www.nuget.org/packages/Microsoft.AspNetCore.Server.Kestrel/) NuGet package.\n \n-Call the [`UseKestrel`](https://docs.microsoft.com/aspnet/core/api/microsoft.aspnetcore.hosting.webhostbuilderkestrelextensions#Microsoft_AspNetCore_Hosting_WebHostBuilderKestrelExtensions_UseKestrel_Microsoft_AspNetCore_Hosting_IWebHostBuilder_) extension method on `WebHostBuilder` in your `Main` method, specifying any [Kestrel options](https://docs.microsoft.com/aspnet/core/api/microsoft.aspnetcore.server.kestrel.kestrelserveroptions) that you need, as shown in the following example:\n+Call the [UseKestrel](https://docs.microsoft.com/aspnet/core/api/microsoft.aspnetcore.hosting.webhostbuilderkestrelextensions#Microsoft_AspNetCore_Hosting_WebHostBuilderKestrelExtensions_UseKestrel_Microsoft_AspNetCore_Hosting_IWebHostBuilder_) extension method on `WebHostBuilder` in your `Main` method, specifying any [Kestrel options](https://docs.microsoft.com/aspnet/core/api/microsoft.aspnetcore.server.kestrel.kestrelserveroptions) that you need, as shown in the next section.\n \n [!code-csharp[](kestrel/sample/Program.cs?name=snippet_Main&highlight=13-19)]\n \n-### URL prefixes\n+# [ASP.NET Core 2.x](#tab/aspnetcore2x)\n+\n+The [Microsoft.AspNetCore.Server.Kestrel](https://www.nuget.org/packages/Microsoft.AspNetCore.Server.Kestrel/) package is included in the [Microsoft.AspNetCore.All metapackage](xref:fundamentals/metapackage).\n+\n+ASP.NET Core project templates use Kestrel by default. In *Program.cs*, the template code calls `CreateDefaultBuilder`, which calls [UseKestrel](https://docs.microsoft.com/aspnet/core/api/microsoft.aspnetcore.hosting.webhostbuilderkestrelextensions#Microsoft_AspNetCore_Hosting_WebHostBuilderKestrelExtensions_UseKestrel_Microsoft_AspNetCore_Hosting_IWebHostBuilder_) behind the scenes.\n+\n+[!code-csharp[](kestrel/sample2/Program.cs?name=snippet_DefaultBuilder&highlight=7)]\n+\n+If you use the template code, configure Kestrel options in the `ConfigureServices` method of *Startup.cs*:\n+\n+[!code-csharp[](kestrel/sample2/Startup.cs?name=snippet_KestrelOptions&highlight=3-4)]\n+\n+If you don't use `CreateDefaultBuilder`, call `UseKestrel` in *Program.cs* and configure options at the same time:\n+\n+[!code-csharp[](kestrel/sample2/Program.cs?name=snippet_Main&highlight=13-20)]\n+\n+For more information about Kestrel settings, see the following classes:\n+\n+* [KestrelServerOptions](https://github.com/aspnet/KestrelHttpServer/blob/rel/2.0.0/src/Microsoft.AspNetCore.Server.Kestrel.Core/KestrelServerOptions.cs)\n+* [ListenOptions](https://github.com/aspnet/KestrelHttpServer/blob/rel/2.0.0/src/Microsoft.AspNetCore.Server.Kestrel.Core/ListenOptions.cs)\n+* [KestrelServerLimits](https://github.com/aspnet/KestrelHttpServer/blob/rel/2.0.0/src/Microsoft.AspNetCore.Server.Kestrel.Core/KestrelServerLimits.cs)\n+\n+\n+---\n+\n+### Kestrel options\n+\n+# [ASP.NET Core 1.x](#tab/aspnetcore1x)\n+\n+For information about Kestrel options, see [KestrelServerOptions class](https://docs.microsoft.com/aspnet/core/api/microsoft.aspnetcore.server.kestrel.kestrelserveroptions).\n+\n+# [ASP.NET Core 2.x](#tab/aspnetcore2x)\n+\n+The Kestrel web server has constraint configuration options that are especially useful in Internet-facing deployments. Here are some of the limits you can set:\n+\n+- Maximum client connections\n+- Maximum request body size\n+- Minimum request body data rate\n+\n+You set these constraints and others in the The `Limits` property of the [KestrelServerOptions](https://github.com/aspnet/KestrelHttpServer/blob/rel/2.0.0/src/Microsoft.AspNetCore.Server.Kestrel.Core/KestrelServerOptions.cs) class. The `Limits` property holds an instance of the [KestrelServerLimits](https://github.com/aspnet/KestrelHttpServer/blob/rel/2.0.0/src/Microsoft.AspNetCore.Server.Kestrel.Core/KestrelServerLimits.cs) class. \n+\n+**Maximum client connections**\n+\n+The maximum number of concurrent open HTTP/HTTPS connections can be set for the entire application with the following code:\n+\n+[!code-csharp[](kestrel/sample2/Program.cs?name=snippet_Limits&highlight=3-4)]\n+\n+There's a separate limit for connections that have been upgraded from HTTP or HTTPS to another protocol (for example, on a WebSockets request). After a connection is upgraded, it’s not counted against the `MaxConcurrentConnections` limit anymore.\n+\n+**Maximum request body size**\n+\n+The default maximum request body size is 30,000,000 bytes, which is approximately 28.6MB. Here's an example that shows how to configure the constraint for the entire application:\n+\n+[!code-csharp[](kestrel/sample2/Program.cs?name=snippet_Limits&highlight=5)]\n+\n+This will affect every request. The recommended way to override the limit in an ASP.NET Core MVC app is to use the [RequestSizeLimit](https://github.com/aspnet/Mvc/blob/rel/2.0.0/src/Microsoft.AspNetCore.Mvc.Core/RequestSizeLimitAttribute.cs) attribute on an action method:\n+\n+```csharp\n+[RequestSizeLimit(100000000)]\n+public IActionResult MyActionMethod()\n+```\n+\n+You can also override the setting on a specific request as shown here:\n+\n+[!code-csharp[](kestrel/sample2/Startup.cs?name=snippet_Limits&highlight=3-4)]\n+ \n+An exception is thrown if you try to configure the limit on a request after the application has started reading the request. There’s an `IsReadOnly` property that tells you if the request body is in read-only state, meaning it’s too late to configure the limit.\n+\n+**Minimum request body data rate**\n+\n+Here's an example that shows how to configure the minimum request rate:\n+\n+[!code-csharp[](kestrel/sample2/Program.cs?name=snippet_Limits&highlight=6-7)]\n+\n+You can configure the rate per request:\n+\n+[!code-csharp[](kestrel/sample2/Startup.cs?name=snippet_Limits&highlight=5-6)]\n+\n+Kestrel checks every second if data is coming in at the specified rate in bytes/second. If the rate drops below the minimum, the connection is timed out. The grace period is the amount of time that Kestrel gives the client to get its send rate up to the minimum; the rate is not checked during that time. The grace period is to avoid dropping connections that are initially sending data at a slow rate due to TCP slow-start.\n+\n+For information about other Kestrel options, see [KestrelServerOptions](https://github.com/aspnet/KestrelHttpServer/blob/rel/2.0.0/src/Microsoft.AspNetCore.Server.Kestrel.Core/KestrelServerOptions.cs) and [KestrelServerLimits](https://github.com/aspnet/KestrelHttpServer/blob/rel/2.0.0/src/Microsoft.AspNetCore.Server.Kestrel.Core/KestrelServerLimits.cs). \n+\n+---\n+\n+### Endpoint configuration\n+\n+# [ASP.NET Core 1.x](#tab/aspnetcore1x)\n \n By default ASP.NET Core binds to `http://localhost:5000`. You can configure URL prefixes and ports for Kestrel to listen on by using the `UseUrls` extension method, the `urls` command-line argument, or the ASP.NET Core configuration system. For more information about these methods, see [Hosting](../../fundamentals/hosting.md). For information about how URL binding works when you use IIS as a reverse proxy, see [ASP.NET Core Module](aspnet-core-module.md). \n \n-URL prefixes for Kestrel can be in any of the following formats. \n+# [ASP.NET Core 2.x](#tab/aspnetcore2x)\n+\n+By default ASP.NET Core binds to `http://localhost:5000`. You configure URL prefixes and ports for Kestrel to listen on by calling `Listen` or `ListenUnixSocket` methods on `KestrelServerOptions`. (`UseUrls` and the `urls` command-line argument also work, with limitations noted [later in this article](#useurls-limitations).)\n+\n+**Bind to a TCP socket**\n+\n+The `Listen` method binds to a TCP socket, and an options lambda lets you configure an SSL certificate:\n+\n+[!code-csharp[](kestrel/sample2/Program.cs?name=snippet_Main&highlight=13-20)]\n+\n+Notice how this example configures SSL for a particular endpoint by using [ListenOptions](https://github.com/aspnet/KestrelHttpServer/blob/rel/2.0.0/src/Microsoft.AspNetCore.Server.Kestrel.Core/ListenOptions.cs). You can use the same API to configure other Kestrel settings for particular endpoints. \n+\n+**Bind to a Unix socket**\n+\n+You can listen on a Unix socket for improved performance with Nginx, as shown in this example:\n+\n+[!code-csharp[](kestrel/sample2/Program.cs?name=snippet_UnixSocket)]\n+\n+**Port 0**\n+\n+If you specify port number 0, Kestrel dynamically binds to an available port. The following example shows how to determine which port Kestrel actually bound to at runtime:","path":"aspnetcore/fundamentals/servers/kestrel.md","position":189,"original_position":189,"commit_id":"25c7ce0c2ba60261dea02bdb7e86a7b831e782cc","original_commit_id":"57351660477fa4a4f79386f9265bee410622eccf","user":{"login":"GuardRex","id":1622880,"avatar_url":"https://avatars1.githubusercontent.com/u/1622880?v=4","gravatar_id":"","url":"https://api.github.com/users/GuardRex","html_url":"https://github.com/GuardRex","followers_url":"https://api.github.com/users/GuardRex/followers","following_url":"https://api.github.com/users/GuardRex/following{/other_user}","gists_url":"https://api.github.com/users/GuardRex/gists{/gist_id}","starred_url":"https://api.github.com/users/GuardRex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuardRex/subscriptions","organizations_url":"https://api.github.com/users/GuardRex/orgs","repos_url":"https://api.github.com/users/GuardRex/repos","events_url":"https://api.github.com/users/GuardRex/events{/privacy}","received_events_url":"https://api.github.com/users/GuardRex/received_events","type":"User","site_admin":false},"body":"Drop \"to\" ...\r\n\r\n> ... determine which port Kestrel actually bound at runtime:","created_at":"2017-08-07T22:24:39Z","updated_at":"2017-08-07T22:50:30Z","html_url":"https://github.com/aspnet/Docs/pull/3875#discussion_r131779486","pull_request_url":"https://api.github.com/repos/aspnet/Docs/pulls/3875","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Docs/pulls/comments/131779486"},"html":{"href":"https://github.com/aspnet/Docs/pull/3875#discussion_r131779486"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Docs/pulls/3875"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Docs/pulls/3875","id":134003587,"html_url":"https://github.com/aspnet/Docs/pull/3875","diff_url":"https://github.com/aspnet/Docs/pull/3875.diff","patch_url":"https://github.com/aspnet/Docs/pull/3875.patch","issue_url":"https://api.github.com/repos/aspnet/Docs/issues/3875","number":3875,"state":"open","locked":false,"title":"Kestrel and WebListener/HttpSys - 2.0 changes","user":{"login":"tdykstra","id":1569635,"avatar_url":"https://avatars2.githubusercontent.com/u/1569635?v=4","gravatar_id":"","url":"https://api.github.com/users/tdykstra","html_url":"https://github.com/tdykstra","followers_url":"https://api.github.com/users/tdykstra/followers","following_url":"https://api.github.com/users/tdykstra/following{/other_user}","gists_url":"https://api.github.com/users/tdykstra/gists{/gist_id}","starred_url":"https://api.github.com/users/tdykstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdykstra/subscriptions","organizations_url":"https://api.github.com/users/tdykstra/orgs","repos_url":"https://api.github.com/users/tdykstra/repos","events_url":"https://api.github.com/users/tdykstra/events{/privacy}","received_events_url":"https://api.github.com/users/tdykstra/received_events","type":"User","site_admin":false},"body":"Fixes #3385 Kestrel\r\nFixes #2648 WebListener/HttpSys\r\n\r\nReview URLs\r\n[Servers](https://review.docs.microsoft.com/en-us/aspnet/core/fundamentals/servers/?branch=td-kestrel&tabs=aspnetcore2x)\r\n[Kestrel](https://review.docs.microsoft.com/en-us/aspnet/core/fundamentals/servers/kestrel?branch=td-kestrel&tabs=aspnetcore2x)\r\n[ANCM](https://review.docs.microsoft.com/en-us/aspnet/core/fundamentals/servers/aspnet-core-module?branch=td-kestrel&tabs=aspnetcore2x)\r\n[HttpSys](https://review.docs.microsoft.com/en-us/aspnet/core/fundamentals/servers/httpsys?branch=td-kestrel)\r\n[WebListener](https://review.docs.microsoft.com/en-us/aspnet/core/fundamentals/servers/weblistener?branch=td-kestrel)\r\n[Hosting fundamentals](https://review.docs.microsoft.com/en-us/aspnet/core/fundamentals/servers/httpsys?branch=td-kestrel)\r\n[Hosting and deployment](https://review.docs.microsoft.com/en-us/aspnet/core/publishing/?branch=td-kestrel&tabs=aspnetcore2x)\r\n\r\n","created_at":"2017-08-03T17:49:42Z","updated_at":"2017-08-07T22:50:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47c7c7cf98d8bbc45bcf3576fdba6b7c5ac59a44","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Docs/pulls/3875/commits","review_comments_url":"https://api.github.com/repos/aspnet/Docs/pulls/3875/comments","review_comment_url":"https://api.github.com/repos/aspnet/Docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Docs/issues/3875/comments","statuses_url":"https://api.github.com/repos/aspnet/Docs/statuses/25c7ce0c2ba60261dea02bdb7e86a7b831e782cc","head":{"label":"aspnet:td-kestrel","ref":"td-kestrel","sha":"25c7ce0c2ba60261dea02bdb7e86a7b831e782cc","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":28239455,"name":"Docs","full_name":"aspnet/Docs","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Docs","description":"Documentation for ASP.NET and ASP.NET Core","fork":false,"url":"https://api.github.com/repos/aspnet/Docs","forks_url":"https://api.github.com/repos/aspnet/Docs/forks","keys_url":"https://api.github.com/repos/aspnet/Docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Docs/teams","hooks_url":"https://api.github.com/repos/aspnet/Docs/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Docs/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Docs/events","assignees_url":"https://api.github.com/repos/aspnet/Docs/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Docs/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Docs/tags","blobs_url":"https://api.github.com/repos/aspnet/Docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Docs/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Docs/languages","stargazers_url":"https://api.github.com/repos/aspnet/Docs/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Docs/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Docs/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Docs/subscription","commits_url":"https://api.github.com/repos/aspnet/Docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Docs/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Docs/merges","archive_url":"https://api.github.com/repos/aspnet/Docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Docs/downloads","issues_url":"https://api.github.com/repos/aspnet/Docs/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Docs/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Docs/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Docs/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Docs/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Docs/deployments","created_at":"2014-12-19T17:38:02Z","updated_at":"2017-08-07T14:38:58Z","pushed_at":"2017-08-07T21:35:24Z","git_url":"git://github.com/aspnet/Docs.git","ssh_url":"[email protected]:aspnet/Docs.git","clone_url":"https://github.com/aspnet/Docs.git","svn_url":"https://github.com/aspnet/Docs","homepage":"https://docs.microsoft.com/aspnet","size":508108,"stargazers_count":1473,"watchers_count":1473,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3590,"mirror_url":null,"open_issues_count":248,"forks":3590,"open_issues":248,"watchers":1473,"default_branch":"master"}},"base":{"label":"aspnet:master","ref":"master","sha":"d182d04934c2b35cc61de8ff00b212914965ad1c","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":28239455,"name":"Docs","full_name":"aspnet/Docs","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Docs","description":"Documentation for ASP.NET and ASP.NET Core","fork":false,"url":"https://api.github.com/repos/aspnet/Docs","forks_url":"https://api.github.com/repos/aspnet/Docs/forks","keys_url":"https://api.github.com/repos/aspnet/Docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Docs/teams","hooks_url":"https://api.github.com/repos/aspnet/Docs/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Docs/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Docs/events","assignees_url":"https://api.github.com/repos/aspnet/Docs/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Docs/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Docs/tags","blobs_url":"https://api.github.com/repos/aspnet/Docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Docs/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Docs/languages","stargazers_url":"https://api.github.com/repos/aspnet/Docs/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Docs/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Docs/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Docs/subscription","commits_url":"https://api.github.com/repos/aspnet/Docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Docs/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Docs/merges","archive_url":"https://api.github.com/repos/aspnet/Docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Docs/downloads","issues_url":"https://api.github.com/repos/aspnet/Docs/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Docs/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Docs/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Docs/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Docs/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Docs/deployments","created_at":"2014-12-19T17:38:02Z","updated_at":"2017-08-07T14:38:58Z","pushed_at":"2017-08-07T21:35:24Z","git_url":"git://github.com/aspnet/Docs.git","ssh_url":"[email protected]:aspnet/Docs.git","clone_url":"https://github.com/aspnet/Docs.git","svn_url":"https://github.com/aspnet/Docs","homepage":"https://docs.microsoft.com/aspnet","size":508108,"stargazers_count":1473,"watchers_count":1473,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3590,"mirror_url":null,"open_issues_count":248,"forks":3590,"open_issues":248,"watchers":1473,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Docs/pulls/3875"},"html":{"href":"https://github.com/aspnet/Docs/pull/3875"},"issue":{"href":"https://api.github.com/repos/aspnet/Docs/issues/3875"},"comments":{"href":"https://api.github.com/repos/aspnet/Docs/issues/3875/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Docs/pulls/3875/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Docs/pulls/3875/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Docs/statuses/25c7ce0c2ba60261dea02bdb7e86a7b831e782cc"}}}} | {
"id": 28239455,
"name": "aspnet/Docs",
"url": "https://api.github.com/repos/aspnet/Docs"
} | {
"id": 1622880,
"login": "GuardRex",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1622880?",
"url": "https://api.github.com/users/GuardRex"
} | {
"id": 6476660,
"login": "aspnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6476660?",
"url": "https://api.github.com/orgs/aspnet"
} | 2017-08-07T22:24:39 | 6411378338 | {"actor":{"display_login":"GuardRex"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/101374999","pull_request_review_id":22101771,"id":101374999,"diff_hunk":"@@ -562,5 +595,34 @@ System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator()\n return GetEnumerator();\n }\n }\n+\n+ // By default the ComplexTypeModelBinder fails to construct models for types with no parameterless constructor,\n+ // but a developer could change this behavior by overridng CreateModel","path":"test/Microsoft.AspNetCore.Mvc.IntegrationTests/ActionParametersIntegrationTest.cs","position":63,"original_position":63,"commit_id":"33e1e841526da220d2b92ffb1f3a3ee4c39f3ec9","original_commit_id":"33e1e841526da220d2b92ffb1f3a3ee4c39f3ec9","user":{"login":"rynowak","id":1430011,"avatar_url":"https://avatars.githubusercontent.com/u/1430011?v=3","gravatar_id":"","url":"https://api.github.com/users/rynowak","html_url":"https://github.com/rynowak","followers_url":"https://api.github.com/users/rynowak/followers","following_url":"https://api.github.com/users/rynowak/following{/other_user}","gists_url":"https://api.github.com/users/rynowak/gists{/gist_id}","starred_url":"https://api.github.com/users/rynowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynowak/subscriptions","organizations_url":"https://api.github.com/users/rynowak/orgs","repos_url":"https://api.github.com/users/rynowak/repos","events_url":"https://api.github.com/users/rynowak/events{/privacy}","received_events_url":"https://api.github.com/users/rynowak/received_events","type":"User","site_admin":false},"body":"typo 😆 ","created_at":"2017-02-15T20:27:16Z","updated_at":"2017-02-15T20:27:16Z","html_url":"https://github.com/aspnet/Mvc/pull/5805#discussion_r101374999","pull_request_url":"https://api.github.com/repos/aspnet/Mvc/pulls/5805","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/101374999"},"html":{"href":"https://github.com/aspnet/Mvc/pull/5805#discussion_r101374999"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/5805"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/5805","id":106183670,"html_url":"https://github.com/aspnet/Mvc/pull/5805","diff_url":"https://github.com/aspnet/Mvc/pull/5805.diff","patch_url":"https://github.com/aspnet/Mvc/pull/5805.patch","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/5805","number":5805,"state":"open","locked":false,"title":"[Fixes #5801] Move call to validate constructor in ComplexTypeModelBinder into CreateModel ","user":{"login":"kichalla","id":6559784,"avatar_url":"https://avatars.githubusercontent.com/u/6559784?v=3","gravatar_id":"","url":"https://api.github.com/users/kichalla","html_url":"https://github.com/kichalla","followers_url":"https://api.github.com/users/kichalla/followers","following_url":"https://api.github.com/users/kichalla/following{/other_user}","gists_url":"https://api.github.com/users/kichalla/gists{/gist_id}","starred_url":"https://api.github.com/users/kichalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kichalla/subscriptions","organizations_url":"https://api.github.com/users/kichalla/orgs","repos_url":"https://api.github.com/users/kichalla/repos","events_url":"https://api.github.com/users/kichalla/events{/privacy}","received_events_url":"https://api.github.com/users/kichalla/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-14T20:16:36Z","updated_at":"2017-02-15T20:27:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b4a2abcc40d41d769beb83fbb7072b2533e682a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Mvc/pulls/5805/commits","review_comments_url":"https://api.github.com/repos/aspnet/Mvc/pulls/5805/comments","review_comment_url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/5805/comments","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/33e1e841526da220d2b92ffb1f3a3ee4c39f3ec9","head":{"label":"aspnet:kichalla/ctmb-fix","ref":"kichalla/ctmb-fix","sha":"33e1e841526da220d2b92ffb1f3a3ee4c39f3ec9","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"ASP.NET Core MVC is a model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Mvc/deployments","created_at":"2013-12-12T03:54:00Z","updated_at":"2017-02-15T18:22:21Z","pushed_at":"2017-02-15T20:06:25Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"[email protected]:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":25021,"stargazers_count":3951,"watchers_count":3951,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1583,"mirror_url":null,"open_issues_count":345,"forks":1583,"open_issues":345,"watchers":3951,"default_branch":"dev"}},"base":{"label":"aspnet:rel/1.1.2","ref":"rel/1.1.2","sha":"531c11df2a1326f257a6d521b328937e8b11db88","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"ASP.NET Core MVC is a model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Mvc/deployments","created_at":"2013-12-12T03:54:00Z","updated_at":"2017-02-15T18:22:21Z","pushed_at":"2017-02-15T20:06:25Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"[email protected]:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":25021,"stargazers_count":3951,"watchers_count":3951,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1583,"mirror_url":null,"open_issues_count":345,"forks":1583,"open_issues":345,"watchers":3951,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/5805"},"html":{"href":"https://github.com/aspnet/Mvc/pull/5805"},"issue":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/5805"},"comments":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/5805/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/5805/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/5805/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Mvc/statuses/33e1e841526da220d2b92ffb1f3a3ee4c39f3ec9"}}}} | {
"id": 15126429,
"name": "aspnet/Mvc",
"url": "https://api.github.com/repos/aspnet/Mvc"
} | {
"id": 1430011,
"login": "rynowak",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1430011?",
"url": "https://api.github.com/users/rynowak"
} | {
"id": 6476660,
"login": "aspnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6476660?",
"url": "https://api.github.com/orgs/aspnet"
} | 2017-02-15T20:27:16 | 5331817890 | {"actor":{"display_login":"rynowak"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/bitpay/copay/pulls/comments/151120172","pull_request_review_id":76775161,"id":151120172,"diff_hunk":"@@ -85,19 +120,259 @@ export class ImportWalletPage implements OnInit {\n this.importForm.get('filePassword').updateValueAndValidity();\n }\n \n- setDerivationPath() {\n- this.formData.derivationPath = this.formData.testnet ? this.derivationPathForTestnet : this.derivationPathByDefault;\n- }\n-\n normalizeMnemonic(words: string) {\n if (!words || !words.indexOf) return words;\n var isJA = words.indexOf('\\u3000') > -1;\n var wordList = words.split(/[\\u3000\\s]+/);\n \n return wordList.join(isJA ? '\\u3000' : ' ');\n- };\n+ }\n+\n+ private processWalletInfo(code: string): void {\n+ if (!code) return;\n+\n+ this.importErr = false;\n+ let parsedCode = code.split('|');\n+\n+ if (parsedCode.length != 5) {\n+ /// Trying to import a malformed wallet export QR code\n+ this.popupProvider.ionicAlert('Error', 'Incorrect code format'); //TODO gettextcatalog\n+ return;\n+ }\n+\n+ let info = {\n+ type: parsedCode[0],\n+ data: parsedCode[1],\n+ network: parsedCode[2],\n+ derivationPath: parsedCode[3],\n+ hasPassphrase: parsedCode[4] == 'true' ? true : false\n+ };\n+\n+ if (info.type == '1' && info.hasPassphrase)\n+ this.popupProvider.ionicAlert('Error', 'Password required. Make sure to enter your password in advanced options'); //TODO gettextcatalog\n+\n+ this.formData.derivationPath = info.derivationPath;\n+ this.formData.testnetEnabled = info.network == 'testnet' ? true : false;\n+ this.formData.words = info.data;\n+ }\n+\n+ public switchTestnetOff(): void {","path":"src/pages/add/import-wallet/import-wallet.ts","position":143,"original_position":143,"commit_id":"b09abfbc815741609107679060de21f1514fdcbd","original_commit_id":"595971e907d1b75f14be31b1fc651323d7b3146b","user":{"login":"JDonadio","id":13851807,"avatar_url":"https://avatars0.githubusercontent.com/u/13851807?v=4","gravatar_id":"","url":"https://api.github.com/users/JDonadio","html_url":"https://github.com/JDonadio","followers_url":"https://api.github.com/users/JDonadio/followers","following_url":"https://api.github.com/users/JDonadio/following{/other_user}","gists_url":"https://api.github.com/users/JDonadio/gists{/gist_id}","starred_url":"https://api.github.com/users/JDonadio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDonadio/subscriptions","organizations_url":"https://api.github.com/users/JDonadio/orgs","repos_url":"https://api.github.com/users/JDonadio/repos","events_url":"https://api.github.com/users/JDonadio/events{/privacy}","received_events_url":"https://api.github.com/users/JDonadio/received_events","type":"User","site_admin":false},"body":"Then should be added with BCH","created_at":"2017-11-15T13:08:07Z","updated_at":"2017-11-15T13:08:07Z","html_url":"https://github.com/bitpay/copay/pull/7161#discussion_r151120172","pull_request_url":"https://api.github.com/repos/bitpay/copay/pulls/7161","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/bitpay/copay/pulls/comments/151120172"},"html":{"href":"https://github.com/bitpay/copay/pull/7161#discussion_r151120172"},"pull_request":{"href":"https://api.github.com/repos/bitpay/copay/pulls/7161"}},"in_reply_to_id":151112957},"pull_request":{"url":"https://api.github.com/repos/bitpay/copay/pulls/7161","id":152604837,"html_url":"https://github.com/bitpay/copay/pull/7161","diff_url":"https://github.com/bitpay/copay/pull/7161.diff","patch_url":"https://github.com/bitpay/copay/pull/7161.patch","issue_url":"https://api.github.com/repos/bitpay/copay/issues/7161","number":7161,"state":"open","locked":false,"title":"Feat: Import wallet V4","user":{"login":"Gamboster","id":10983458,"avatar_url":"https://avatars3.githubusercontent.com/u/10983458?v=4","gravatar_id":"","url":"https://api.github.com/users/Gamboster","html_url":"https://github.com/Gamboster","followers_url":"https://api.github.com/users/Gamboster/followers","following_url":"https://api.github.com/users/Gamboster/following{/other_user}","gists_url":"https://api.github.com/users/Gamboster/gists{/gist_id}","starred_url":"https://api.github.com/users/Gamboster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gamboster/subscriptions","organizations_url":"https://api.github.com/users/Gamboster/orgs","repos_url":"https://api.github.com/users/Gamboster/repos","events_url":"https://api.github.com/users/Gamboster/events{/privacy}","received_events_url":"https://api.github.com/users/Gamboster/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-14T20:07:27Z","updated_at":"2017-11-15T13:08:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97ff60b617013c0fd01c000ad12b07797329b72a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitpay/copay/pulls/7161/commits","review_comments_url":"https://api.github.com/repos/bitpay/copay/pulls/7161/comments","review_comment_url":"https://api.github.com/repos/bitpay/copay/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitpay/copay/issues/7161/comments","statuses_url":"https://api.github.com/repos/bitpay/copay/statuses/b09abfbc815741609107679060de21f1514fdcbd","head":{"label":"Gamboster:feat/importWalletV4","ref":"feat/importWalletV4","sha":"b09abfbc815741609107679060de21f1514fdcbd","user":{"login":"Gamboster","id":10983458,"avatar_url":"https://avatars3.githubusercontent.com/u/10983458?v=4","gravatar_id":"","url":"https://api.github.com/users/Gamboster","html_url":"https://github.com/Gamboster","followers_url":"https://api.github.com/users/Gamboster/followers","following_url":"https://api.github.com/users/Gamboster/following{/other_user}","gists_url":"https://api.github.com/users/Gamboster/gists{/gist_id}","starred_url":"https://api.github.com/users/Gamboster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gamboster/subscriptions","organizations_url":"https://api.github.com/users/Gamboster/orgs","repos_url":"https://api.github.com/users/Gamboster/repos","events_url":"https://api.github.com/users/Gamboster/events{/privacy}","received_events_url":"https://api.github.com/users/Gamboster/received_events","type":"User","site_admin":false},"repo":{"id":95455979,"name":"copay","full_name":"Gamboster/copay","owner":{"login":"Gamboster","id":10983458,"avatar_url":"https://avatars3.githubusercontent.com/u/10983458?v=4","gravatar_id":"","url":"https://api.github.com/users/Gamboster","html_url":"https://github.com/Gamboster","followers_url":"https://api.github.com/users/Gamboster/followers","following_url":"https://api.github.com/users/Gamboster/following{/other_user}","gists_url":"https://api.github.com/users/Gamboster/gists{/gist_id}","starred_url":"https://api.github.com/users/Gamboster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gamboster/subscriptions","organizations_url":"https://api.github.com/users/Gamboster/orgs","repos_url":"https://api.github.com/users/Gamboster/repos","events_url":"https://api.github.com/users/Gamboster/events{/privacy}","received_events_url":"https://api.github.com/users/Gamboster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gamboster/copay","description":"Copay is a secure bitcoin wallet platform for both desktop and mobile devices.","fork":true,"url":"https://api.github.com/repos/Gamboster/copay","forks_url":"https://api.github.com/repos/Gamboster/copay/forks","keys_url":"https://api.github.com/repos/Gamboster/copay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gamboster/copay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gamboster/copay/teams","hooks_url":"https://api.github.com/repos/Gamboster/copay/hooks","issue_events_url":"https://api.github.com/repos/Gamboster/copay/issues/events{/number}","events_url":"https://api.github.com/repos/Gamboster/copay/events","assignees_url":"https://api.github.com/repos/Gamboster/copay/assignees{/user}","branches_url":"https://api.github.com/repos/Gamboster/copay/branches{/branch}","tags_url":"https://api.github.com/repos/Gamboster/copay/tags","blobs_url":"https://api.github.com/repos/Gamboster/copay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gamboster/copay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gamboster/copay/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gamboster/copay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gamboster/copay/statuses/{sha}","languages_url":"https://api.github.com/repos/Gamboster/copay/languages","stargazers_url":"https://api.github.com/repos/Gamboster/copay/stargazers","contributors_url":"https://api.github.com/repos/Gamboster/copay/contributors","subscribers_url":"https://api.github.com/repos/Gamboster/copay/subscribers","subscription_url":"https://api.github.com/repos/Gamboster/copay/subscription","commits_url":"https://api.github.com/repos/Gamboster/copay/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gamboster/copay/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gamboster/copay/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gamboster/copay/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gamboster/copay/contents/{+path}","compare_url":"https://api.github.com/repos/Gamboster/copay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gamboster/copay/merges","archive_url":"https://api.github.com/repos/Gamboster/copay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gamboster/copay/downloads","issues_url":"https://api.github.com/repos/Gamboster/copay/issues{/number}","pulls_url":"https://api.github.com/repos/Gamboster/copay/pulls{/number}","milestones_url":"https://api.github.com/repos/Gamboster/copay/milestones{/number}","notifications_url":"https://api.github.com/repos/Gamboster/copay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gamboster/copay/labels{/name}","releases_url":"https://api.github.com/repos/Gamboster/copay/releases{/id}","deployments_url":"https://api.github.com/repos/Gamboster/copay/deployments","created_at":"2017-06-26T14:34:38Z","updated_at":"2017-08-30T12:46:25Z","pushed_at":"2017-11-15T13:06:09Z","git_url":"git://github.com/Gamboster/copay.git","ssh_url":"[email protected]:Gamboster/copay.git","clone_url":"https://github.com/Gamboster/copay.git","svn_url":"https://github.com/Gamboster/copay","homepage":"http://copay.io","size":86743,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"bitpay:v4","ref":"v4","sha":"07f06b22a72f46a59962ca733d8b8e0cac7582e9","user":{"login":"bitpay","id":2554930,"avatar_url":"https://avatars2.githubusercontent.com/u/2554930?v=4","gravatar_id":"","url":"https://api.github.com/users/bitpay","html_url":"https://github.com/bitpay","followers_url":"https://api.github.com/users/bitpay/followers","following_url":"https://api.github.com/users/bitpay/following{/other_user}","gists_url":"https://api.github.com/users/bitpay/gists{/gist_id}","starred_url":"https://api.github.com/users/bitpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitpay/subscriptions","organizations_url":"https://api.github.com/users/bitpay/orgs","repos_url":"https://api.github.com/users/bitpay/repos","events_url":"https://api.github.com/users/bitpay/events{/privacy}","received_events_url":"https://api.github.com/users/bitpay/received_events","type":"Organization","site_admin":false},"repo":{"id":18141084,"name":"copay","full_name":"bitpay/copay","owner":{"login":"bitpay","id":2554930,"avatar_url":"https://avatars2.githubusercontent.com/u/2554930?v=4","gravatar_id":"","url":"https://api.github.com/users/bitpay","html_url":"https://github.com/bitpay","followers_url":"https://api.github.com/users/bitpay/followers","following_url":"https://api.github.com/users/bitpay/following{/other_user}","gists_url":"https://api.github.com/users/bitpay/gists{/gist_id}","starred_url":"https://api.github.com/users/bitpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitpay/subscriptions","organizations_url":"https://api.github.com/users/bitpay/orgs","repos_url":"https://api.github.com/users/bitpay/repos","events_url":"https://api.github.com/users/bitpay/events{/privacy}","received_events_url":"https://api.github.com/users/bitpay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitpay/copay","description":"Copay is a secure bitcoin wallet platform for both desktop and mobile devices.","fork":false,"url":"https://api.github.com/repos/bitpay/copay","forks_url":"https://api.github.com/repos/bitpay/copay/forks","keys_url":"https://api.github.com/repos/bitpay/copay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitpay/copay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitpay/copay/teams","hooks_url":"https://api.github.com/repos/bitpay/copay/hooks","issue_events_url":"https://api.github.com/repos/bitpay/copay/issues/events{/number}","events_url":"https://api.github.com/repos/bitpay/copay/events","assignees_url":"https://api.github.com/repos/bitpay/copay/assignees{/user}","branches_url":"https://api.github.com/repos/bitpay/copay/branches{/branch}","tags_url":"https://api.github.com/repos/bitpay/copay/tags","blobs_url":"https://api.github.com/repos/bitpay/copay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitpay/copay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitpay/copay/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitpay/copay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitpay/copay/statuses/{sha}","languages_url":"https://api.github.com/repos/bitpay/copay/languages","stargazers_url":"https://api.github.com/repos/bitpay/copay/stargazers","contributors_url":"https://api.github.com/repos/bitpay/copay/contributors","subscribers_url":"https://api.github.com/repos/bitpay/copay/subscribers","subscription_url":"https://api.github.com/repos/bitpay/copay/subscription","commits_url":"https://api.github.com/repos/bitpay/copay/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitpay/copay/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitpay/copay/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitpay/copay/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitpay/copay/contents/{+path}","compare_url":"https://api.github.com/repos/bitpay/copay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitpay/copay/merges","archive_url":"https://api.github.com/repos/bitpay/copay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitpay/copay/downloads","issues_url":"https://api.github.com/repos/bitpay/copay/issues{/number}","pulls_url":"https://api.github.com/repos/bitpay/copay/pulls{/number}","milestones_url":"https://api.github.com/repos/bitpay/copay/milestones{/number}","notifications_url":"https://api.github.com/repos/bitpay/copay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitpay/copay/labels{/name}","releases_url":"https://api.github.com/repos/bitpay/copay/releases{/id}","deployments_url":"https://api.github.com/repos/bitpay/copay/deployments","created_at":"2014-03-26T14:33:07Z","updated_at":"2017-11-15T03:47:44Z","pushed_at":"2017-11-15T13:06:11Z","git_url":"git://github.com/bitpay/copay.git","ssh_url":"[email protected]:bitpay/copay.git","clone_url":"https://github.com/bitpay/copay.git","svn_url":"https://github.com/bitpay/copay","homepage":"http://copay.io","size":87347,"stargazers_count":1405,"watchers_count":1405,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":689,"mirror_url":null,"archived":false,"open_issues_count":334,"forks":689,"open_issues":334,"watchers":1405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitpay/copay/pulls/7161"},"html":{"href":"https://github.com/bitpay/copay/pull/7161"},"issue":{"href":"https://api.github.com/repos/bitpay/copay/issues/7161"},"comments":{"href":"https://api.github.com/repos/bitpay/copay/issues/7161/comments"},"review_comments":{"href":"https://api.github.com/repos/bitpay/copay/pulls/7161/comments"},"review_comment":{"href":"https://api.github.com/repos/bitpay/copay/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitpay/copay/pulls/7161/commits"},"statuses":{"href":"https://api.github.com/repos/bitpay/copay/statuses/b09abfbc815741609107679060de21f1514fdcbd"}},"author_association":"CONTRIBUTOR"}} | {
"id": 18141084,
"name": "bitpay/copay",
"url": "https://api.github.com/repos/bitpay/copay"
} | {
"id": 13851807,
"login": "JDonadio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13851807?",
"url": "https://api.github.com/users/JDonadio"
} | {
"id": 2554930,
"login": "bitpay",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2554930?",
"url": "https://api.github.com/orgs/bitpay"
} | 2017-11-15T13:08:07 | 6858435093 | {"actor":{"display_login":"JDonadio"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/button/button-client-node/pulls/comments/128292242","pull_request_review_id":50958456,"id":128292242,"diff_hunk":"@@ -66,8 +66,9 @@ function client(apiKey, config) {\n \n return {\n accounts: resources.accounts(requestOptions, maybePromiseRequest),\n+ customers: resources.customers(requestOptions, maybePromiseRequest),\n merchants: resources.merchants(requestOptions, maybePromiseRequest),\n- orders: resources.orders(requestOptions, maybePromiseRequest)\n+ orders: resources.orders(requestOptions, maybePromiseRequest),","path":"index.js","position":7,"original_position":7,"commit_id":"09605ce68cfd158ff068ca3536a524f4ab258a5b","original_commit_id":"09605ce68cfd158ff068ca3536a524f4ab258a5b","user":{"login":"griffinmyers","id":1980044,"avatar_url":"https://avatars3.githubusercontent.com/u/1980044?v=4","gravatar_id":"","url":"https://api.github.com/users/griffinmyers","html_url":"https://github.com/griffinmyers","followers_url":"https://api.github.com/users/griffinmyers/followers","following_url":"https://api.github.com/users/griffinmyers/following{/other_user}","gists_url":"https://api.github.com/users/griffinmyers/gists{/gist_id}","starred_url":"https://api.github.com/users/griffinmyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/griffinmyers/subscriptions","organizations_url":"https://api.github.com/users/griffinmyers/orgs","repos_url":"https://api.github.com/users/griffinmyers/repos","events_url":"https://api.github.com/users/griffinmyers/events{/privacy}","received_events_url":"https://api.github.com/users/griffinmyers/received_events","type":"User","site_admin":false},"body":"nit: this repo is currently formatted without trailing commas at the end of objects. It _is_ Button style now, but let's keep it consistent here and upgrade all instances at once in a separate change if we want. ","created_at":"2017-07-19T16:05:05Z","updated_at":"2017-07-19T16:21:42Z","html_url":"https://github.com/button/button-client-node/pull/22#discussion_r128292242","pull_request_url":"https://api.github.com/repos/button/button-client-node/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/button/button-client-node/pulls/comments/128292242"},"html":{"href":"https://github.com/button/button-client-node/pull/22#discussion_r128292242"},"pull_request":{"href":"https://api.github.com/repos/button/button-client-node/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/button/button-client-node/pulls/22","id":131137891,"html_url":"https://github.com/button/button-client-node/pull/22","diff_url":"https://github.com/button/button-client-node/pull/22.diff","patch_url":"https://github.com/button/button-client-node/pull/22.patch","issue_url":"https://api.github.com/repos/button/button-client-node/issues/22","number":22,"state":"open","locked":false,"title":"Ty/dlc 4403","user":{"login":"tylernappy","id":5566707,"avatar_url":"https://avatars2.githubusercontent.com/u/5566707?v=4","gravatar_id":"","url":"https://api.github.com/users/tylernappy","html_url":"https://github.com/tylernappy","followers_url":"https://api.github.com/users/tylernappy/followers","following_url":"https://api.github.com/users/tylernappy/following{/other_user}","gists_url":"https://api.github.com/users/tylernappy/gists{/gist_id}","starred_url":"https://api.github.com/users/tylernappy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylernappy/subscriptions","organizations_url":"https://api.github.com/users/tylernappy/orgs","repos_url":"https://api.github.com/users/tylernappy/repos","events_url":"https://api.github.com/users/tylernappy/events{/privacy}","received_events_url":"https://api.github.com/users/tylernappy/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-18T16:56:48Z","updated_at":"2017-07-19T16:21:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a85e1a544ccccb423ad8e8b7a1be0154ceb53c75","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/button/button-client-node/pulls/22/commits","review_comments_url":"https://api.github.com/repos/button/button-client-node/pulls/22/comments","review_comment_url":"https://api.github.com/repos/button/button-client-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/button/button-client-node/issues/22/comments","statuses_url":"https://api.github.com/repos/button/button-client-node/statuses/09605ce68cfd158ff068ca3536a524f4ab258a5b","head":{"label":"button:ty/DLC-4403","ref":"ty/DLC-4403","sha":"09605ce68cfd158ff068ca3536a524f4ab258a5b","user":{"login":"button","id":7770987,"avatar_url":"https://avatars2.githubusercontent.com/u/7770987?v=4","gravatar_id":"","url":"https://api.github.com/users/button","html_url":"https://github.com/button","followers_url":"https://api.github.com/users/button/followers","following_url":"https://api.github.com/users/button/following{/other_user}","gists_url":"https://api.github.com/users/button/gists{/gist_id}","starred_url":"https://api.github.com/users/button/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/button/subscriptions","organizations_url":"https://api.github.com/users/button/orgs","repos_url":"https://api.github.com/users/button/repos","events_url":"https://api.github.com/users/button/events{/privacy}","received_events_url":"https://api.github.com/users/button/received_events","type":"Organization","site_admin":false},"repo":{"id":65061909,"name":"button-client-node","full_name":"button/button-client-node","owner":{"login":"button","id":7770987,"avatar_url":"https://avatars2.githubusercontent.com/u/7770987?v=4","gravatar_id":"","url":"https://api.github.com/users/button","html_url":"https://github.com/button","followers_url":"https://api.github.com/users/button/followers","following_url":"https://api.github.com/users/button/following{/other_user}","gists_url":"https://api.github.com/users/button/gists{/gist_id}","starred_url":"https://api.github.com/users/button/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/button/subscriptions","organizations_url":"https://api.github.com/users/button/orgs","repos_url":"https://api.github.com/users/button/repos","events_url":"https://api.github.com/users/button/events{/privacy}","received_events_url":"https://api.github.com/users/button/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/button/button-client-node","description":"node.js client for the Button Order API ","fork":false,"url":"https://api.github.com/repos/button/button-client-node","forks_url":"https://api.github.com/repos/button/button-client-node/forks","keys_url":"https://api.github.com/repos/button/button-client-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/button/button-client-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/button/button-client-node/teams","hooks_url":"https://api.github.com/repos/button/button-client-node/hooks","issue_events_url":"https://api.github.com/repos/button/button-client-node/issues/events{/number}","events_url":"https://api.github.com/repos/button/button-client-node/events","assignees_url":"https://api.github.com/repos/button/button-client-node/assignees{/user}","branches_url":"https://api.github.com/repos/button/button-client-node/branches{/branch}","tags_url":"https://api.github.com/repos/button/button-client-node/tags","blobs_url":"https://api.github.com/repos/button/button-client-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/button/button-client-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/button/button-client-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/button/button-client-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/button/button-client-node/statuses/{sha}","languages_url":"https://api.github.com/repos/button/button-client-node/languages","stargazers_url":"https://api.github.com/repos/button/button-client-node/stargazers","contributors_url":"https://api.github.com/repos/button/button-client-node/contributors","subscribers_url":"https://api.github.com/repos/button/button-client-node/subscribers","subscription_url":"https://api.github.com/repos/button/button-client-node/subscription","commits_url":"https://api.github.com/repos/button/button-client-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/button/button-client-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/button/button-client-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/button/button-client-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/button/button-client-node/contents/{+path}","compare_url":"https://api.github.com/repos/button/button-client-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/button/button-client-node/merges","archive_url":"https://api.github.com/repos/button/button-client-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/button/button-client-node/downloads","issues_url":"https://api.github.com/repos/button/button-client-node/issues{/number}","pulls_url":"https://api.github.com/repos/button/button-client-node/pulls{/number}","milestones_url":"https://api.github.com/repos/button/button-client-node/milestones{/number}","notifications_url":"https://api.github.com/repos/button/button-client-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/button/button-client-node/labels{/name}","releases_url":"https://api.github.com/repos/button/button-client-node/releases{/id}","deployments_url":"https://api.github.com/repos/button/button-client-node/deployments","created_at":"2016-08-06T02:56:21Z","updated_at":"2017-01-04T19:43:37Z","pushed_at":"2017-07-19T15:41:31Z","git_url":"git://github.com/button/button-client-node.git","ssh_url":"[email protected]:button/button-client-node.git","clone_url":"https://github.com/button/button-client-node.git","svn_url":"https://github.com/button/button-client-node","homepage":null,"size":35,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"button:master","ref":"master","sha":"e14823fd1ea1312cc7da1c68bd3b8768ee0b4d7a","user":{"login":"button","id":7770987,"avatar_url":"https://avatars2.githubusercontent.com/u/7770987?v=4","gravatar_id":"","url":"https://api.github.com/users/button","html_url":"https://github.com/button","followers_url":"https://api.github.com/users/button/followers","following_url":"https://api.github.com/users/button/following{/other_user}","gists_url":"https://api.github.com/users/button/gists{/gist_id}","starred_url":"https://api.github.com/users/button/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/button/subscriptions","organizations_url":"https://api.github.com/users/button/orgs","repos_url":"https://api.github.com/users/button/repos","events_url":"https://api.github.com/users/button/events{/privacy}","received_events_url":"https://api.github.com/users/button/received_events","type":"Organization","site_admin":false},"repo":{"id":65061909,"name":"button-client-node","full_name":"button/button-client-node","owner":{"login":"button","id":7770987,"avatar_url":"https://avatars2.githubusercontent.com/u/7770987?v=4","gravatar_id":"","url":"https://api.github.com/users/button","html_url":"https://github.com/button","followers_url":"https://api.github.com/users/button/followers","following_url":"https://api.github.com/users/button/following{/other_user}","gists_url":"https://api.github.com/users/button/gists{/gist_id}","starred_url":"https://api.github.com/users/button/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/button/subscriptions","organizations_url":"https://api.github.com/users/button/orgs","repos_url":"https://api.github.com/users/button/repos","events_url":"https://api.github.com/users/button/events{/privacy}","received_events_url":"https://api.github.com/users/button/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/button/button-client-node","description":"node.js client for the Button Order API ","fork":false,"url":"https://api.github.com/repos/button/button-client-node","forks_url":"https://api.github.com/repos/button/button-client-node/forks","keys_url":"https://api.github.com/repos/button/button-client-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/button/button-client-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/button/button-client-node/teams","hooks_url":"https://api.github.com/repos/button/button-client-node/hooks","issue_events_url":"https://api.github.com/repos/button/button-client-node/issues/events{/number}","events_url":"https://api.github.com/repos/button/button-client-node/events","assignees_url":"https://api.github.com/repos/button/button-client-node/assignees{/user}","branches_url":"https://api.github.com/repos/button/button-client-node/branches{/branch}","tags_url":"https://api.github.com/repos/button/button-client-node/tags","blobs_url":"https://api.github.com/repos/button/button-client-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/button/button-client-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/button/button-client-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/button/button-client-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/button/button-client-node/statuses/{sha}","languages_url":"https://api.github.com/repos/button/button-client-node/languages","stargazers_url":"https://api.github.com/repos/button/button-client-node/stargazers","contributors_url":"https://api.github.com/repos/button/button-client-node/contributors","subscribers_url":"https://api.github.com/repos/button/button-client-node/subscribers","subscription_url":"https://api.github.com/repos/button/button-client-node/subscription","commits_url":"https://api.github.com/repos/button/button-client-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/button/button-client-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/button/button-client-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/button/button-client-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/button/button-client-node/contents/{+path}","compare_url":"https://api.github.com/repos/button/button-client-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/button/button-client-node/merges","archive_url":"https://api.github.com/repos/button/button-client-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/button/button-client-node/downloads","issues_url":"https://api.github.com/repos/button/button-client-node/issues{/number}","pulls_url":"https://api.github.com/repos/button/button-client-node/pulls{/number}","milestones_url":"https://api.github.com/repos/button/button-client-node/milestones{/number}","notifications_url":"https://api.github.com/repos/button/button-client-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/button/button-client-node/labels{/name}","releases_url":"https://api.github.com/repos/button/button-client-node/releases{/id}","deployments_url":"https://api.github.com/repos/button/button-client-node/deployments","created_at":"2016-08-06T02:56:21Z","updated_at":"2017-01-04T19:43:37Z","pushed_at":"2017-07-19T15:41:31Z","git_url":"git://github.com/button/button-client-node.git","ssh_url":"[email protected]:button/button-client-node.git","clone_url":"https://github.com/button/button-client-node.git","svn_url":"https://github.com/button/button-client-node","homepage":null,"size":35,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/button/button-client-node/pulls/22"},"html":{"href":"https://github.com/button/button-client-node/pull/22"},"issue":{"href":"https://api.github.com/repos/button/button-client-node/issues/22"},"comments":{"href":"https://api.github.com/repos/button/button-client-node/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/button/button-client-node/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/button/button-client-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/button/button-client-node/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/button/button-client-node/statuses/09605ce68cfd158ff068ca3536a524f4ab258a5b"}}}} | {
"id": 65061909,
"name": "button/button-client-node",
"url": "https://api.github.com/repos/button/button-client-node"
} | {
"id": 1980044,
"login": "griffinmyers",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1980044?",
"url": "https://api.github.com/users/griffinmyers"
} | {
"id": 7770987,
"login": "button",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7770987?",
"url": "https://api.github.com/orgs/button"
} | 2017-07-19T16:05:05 | 6288161805 | {"actor":{"display_login":"griffinmyers"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cerner/terra-core/pulls/comments/143772961","pull_request_review_id":68334011,"id":143772961,"diff_hunk":"@@ -0,0 +1,335 @@\n+import React from 'react';\n+import PropTypes from 'prop-types';\n+import Portal from 'react-portal';\n+import HookshotContent from './HookshotContent';\n+import HookshotUtils from './_HookshotUtils';\n+\n+const ATTACHMENT_POSITIONS = [\n+ 'top left',\n+ 'top center',\n+ 'top right',\n+ 'middle left',\n+ 'middle center',\n+ 'middle right',\n+ 'bottom left',\n+ 'bottom center',\n+ 'bottom right',\n+];\n+\n+const ATTACHMENT_BEHAVIORS = [\n+ 'auto',\n+ 'flip',\n+ 'none',\n+];\n+\n+const propTypes = {\n+ /**\n+ * How the content should be positioned when the primary attachment is not available.\n+ * Valid values: 'auto', 'flip', and 'none'.\n+ */\n+ attachmentBehavior: PropTypes.oneOf(ATTACHMENT_BEHAVIORS),\n+ /**\n+ * Value in px of the margin to place between the target and the content.\n+ */\n+ attachmentMargin: PropTypes.number,\n+ /**\n+ * Reference to the bounding container, will use window if nothing is provided.\n+ */\n+ boundingRef: PropTypes.func,\n+ /**\n+ * The HookshotContent to be attached.\n+ */\n+ children: PropTypes.element.isRequired,\n+ /**\n+ * String pair separated by a space using values of top, middle, bottom, and left, center, right. (ex: 'top middle')\n+ */\n+ contentAttachment: PropTypes.oneOf(ATTACHMENT_POSITIONS).isRequired,\n+ /**\n+ * String pair of top and left offset, ie \"10px -4px\".\n+ */\n+ contentOffset: PropTypes.string,\n+ /**\n+ * Determines whether the content should be actively positioned via hookshot.\n+ */\n+ isEnabled: PropTypes.bool,\n+ /**\n+ * Should the content be presented.\n+ */\n+ isOpen: PropTypes.bool,\n+ /**\n+ * Callback function when the content has been positioned.\n+ */\n+ onPosition: PropTypes.func,\n+ /**\n+ * Required element that the content will hookshot to.\n+ */\n+ targetRef: PropTypes.func.isRequired,\n+ /**\n+ * String pair of top, middle, bottom, and left, center, right. Will mirror content if none provided. (ex: 'bottom middle')\n+ */\n+ targetAttachment: PropTypes.oneOf(ATTACHMENT_POSITIONS),\n+ /**\n+ * String pair of top and left offset, ie \"10px -4px\".\n+ */\n+ targetOffset: PropTypes.string,\n+};\n+\n+const defaultProps = {\n+ attachmentMargin: 0,\n+ attachmentBehavior: 'auto',\n+ contentOffset: '0 0',\n+ isEnabled: false,\n+ isOpen: false,\n+ targetOffset: '0 0',\n+};\n+\n+class Hookshot extends React.Component {\n+ static now() {\n+ return performance.now();\n+ }\n+\n+ constructor(props) {\n+ super(props);\n+ this.setContentNode = this.setContentNode.bind(this);\n+ this.getNodeRects = this.getNodeRects.bind(this);\n+ this.update = this.update.bind(this);\n+ this.tick = this.tick.bind(this);\n+ this.state = { isEnabled: props.isEnabled && props.isOpen };\n+ this.listenersAdded = false;\n+ this.lastCall = null;\n+ this.lastDuration = null;\n+ this.pendingTimeout = null;\n+ }\n+\n+ componentDidMount() {\n+ if (this.state.isEnabled) {\n+ if (!this.listenersAdded) {\n+ this.enableListeners();\n+ }\n+ this.update();\n+ }\n+ }\n+\n+ componentWillReceiveProps(newProps) {\n+ if (newProps.isEnabled !== this.props.isEnabled || newProps.isOpen !== this.props.isOpen) {\n+ this.setState({ isEnabled: newProps.isEnabled && newProps.isOpen });\n+ }\n+ }\n+\n+ componentDidUpdate() {\n+ if (this.state.isEnabled) {\n+ if (!this.listenersAdded) {\n+ this.enableListeners();\n+ }\n+ this.update();\n+ } else {\n+ this.disableListeners();\n+ }\n+ }\n+\n+ componentWillUnmount() {\n+ this.destroy();\n+ }\n+\n+ setContentNode(node) {\n+ this.contentNode = node;\n+ }\n+\n+ getNodeRects() {\n+ const targetRect = HookshotUtils.getBounds(this.props.targetRef());\n+ const contentRect = HookshotUtils.getBounds(this.contentNode);\n+ const boundingRect = HookshotUtils.getBoundingRect(this.props.boundingRef ? this.props.boundingRef() : 'window');\n+ return { targetRect, contentRect, boundingRect };\n+ }\n+\n+ tick(event) {\n+ if (this.lastDuration && this.lastDuration > 16) {\n+ // Throttle to 60fps, in order to handle safari and mobile performance\n+ this.lastDuration = Math.min(this.lastDuration - 16, 100);\n+\n+ // Just in case this is the last event, remember to position just once more\n+ this.pendingTimeout = setTimeout(this.tick, 100);\n+ return;\n+ }\n+\n+ if (this.lastCall && (Hookshot.now() - this.lastCall) < 10) {\n+ // Some browsers call events a little too frequently, refuse to run more than is reasonable\n+ return;\n+ }\n+\n+ if (this.pendingTimeout != null) {\n+ clearTimeout(this.pendingTimeout);\n+ this.pendingTimeout = null;\n+ }\n+\n+ this.lastCall = Hookshot.now();\n+ this.update(event);\n+ this.lastDuration = Hookshot.now() - this.lastCall;\n+ }\n+\n+ enableListeners() {\n+ const target = this.props.targetRef();\n+ if (target) {\n+ ['resize', 'scroll', 'touchmove'].forEach(event => window.addEventListener(event, this.tick));\n+\n+ this.scrollParents = HookshotUtils.getScrollParents(target);\n+ this.scrollParents.forEach((parent) => {\n+ if (parent !== target.ownerDocument) {\n+ parent.addEventListener('scroll', this.tick);\n+ }\n+ });\n+\n+ this.listenersAdded = true;\n+ }\n+ }\n+\n+ disableListeners() {\n+ ['resize', 'scroll', 'touchmove'].forEach(event => window.removeEventListener(event, this.tick));\n+\n+ const target = this.props.targetRef();\n+ if (this.scrollParents) {\n+ this.scrollParents.forEach((parent) => {\n+ if (parent !== target.ownerDocument) {\n+ parent.removeEventListener('scroll', this.tick);\n+ }\n+ });\n+ }\n+ this.listenersAdded = false;\n+ }\n+\n+ position(event, resetCache) {\n+ if (resetCache) {\n+ this.cachedRects = this.getNodeRects();\n+ } else {\n+ if (this.props.boundingRef) {\n+ this.cachedRects.boundingRect = HookshotUtils.getBoundingRect(this.props.boundingRef());\n+ }\n+ this.cachedRects.targetRect = HookshotUtils.getBounds(this.props.targetRef());\n+ }\n+\n+ this.content.rect = this.cachedRects.contentRect;\n+ this.target.rect = this.cachedRects.targetRect;\n+\n+ const result = HookshotUtils.positionStyleFromBounds(\n+ this.cachedRects.boundingRect,\n+ this.content,\n+ this.target,\n+ this.props.attachmentMargin,\n+ this.props.attachmentBehavior,\n+ );\n+\n+ let styleUpdated = false;\n+ if (this.contentNode.style.position !== result.style.position) {\n+ this.contentNode.style.position = result.style.position;\n+ styleUpdated = true;\n+ }\n+ const newTransform = `translate3d(${result.style.left}, ${result.style.top}, 0px)`;\n+ if (this.contentNode.style.transform !== newTransform) {\n+ this.contentNode.style.transform = newTransform;\n+ styleUpdated = true;\n+ }\n+ if (this.contentNode.style.opacity !== '1') {\n+ this.contentNode.style.opacity = '1';\n+ styleUpdated = true;\n+ }\n+ if (styleUpdated) {\n+ this.cachedRects.contentRect = HookshotUtils.getBounds(this.contentNode);\n+ result.positions.content.rect = this.cachedRects.contentRect;\n+ }\n+\n+ if (this.props.onPosition) {\n+ this.props.onPosition(\n+ event,\n+ result.positions,\n+ );\n+ }\n+ }\n+\n+ destroy() {\n+ this.disableListeners();\n+ this.contentNode = null;\n+ }\n+\n+ update(event) {\n+ if (!this.props.targetRef() || !this.contentNode) {\n+ return;\n+ }\n+ this.updateHookshot(event);\n+ }\n+\n+ updateHookshot(event) {\n+ const resetCache = !event || (event.type !== 'scroll' && event.type !== 'touchmove');\n+ this.position(event, resetCache);\n+ }\n+\n+ cloneContent(content) {\n+ return React.cloneElement(content, { refCallback: this.wrappedRefCallback(content) });\n+ }\n+\n+ wrappedRefCallback(content) {\n+ const initialRefCallback = content.props.refCallback;\n+\n+ return (node) => {\n+ this.setContentNode(node);\n+\n+ if (initialRefCallback) {\n+ initialRefCallback(node);\n+ }\n+ };\n+ }\n+\n+ render() {\n+ /* eslint-disable no-unused-vars */\n+ const {\n+ attachmentBehavior,\n+ attachmentMargin,\n+ boundingRef,\n+ children,\n+ contentAttachment,\n+ contentOffset,\n+ isEnabled,\n+ isOpen,\n+ targetRef,\n+ targetAttachment,\n+ targetOffset,\n+ onPosition,\n+ } = this.props;\n+ /* eslint-enable no-unused-vars */\n+ if (!isOpen) {\n+ return null;\n+ }\n+\n+ this.content = {\n+ offset: HookshotUtils.parseOffset(contentOffset),\n+ attachment: HookshotUtils.parseAttachment(contentAttachment),\n+ };\n+ this.target = {\n+ offset: HookshotUtils.parseOffset(targetOffset),\n+ attachment: targetAttachment ? HookshotUtils.parseAttachment(targetAttachment) : HookshotUtils.mirrorAttachment(this.content.attachment),\n+ };\n+\n+ if (document.getElementsByTagName('html')[0].getAttribute('dir') === 'rtl') {","path":"packages/terra-hookshot/src/Hookshot.jsx","position":311,"original_position":311,"commit_id":"27ace3aad46fcb0bd77ee0fb305dc219efc0c542","original_commit_id":"27ace3aad46fcb0bd77ee0fb305dc219efc0c542","user":{"login":"tbiethman","id":1711637,"avatar_url":"https://avatars3.githubusercontent.com/u/1711637?v=4","gravatar_id":"","url":"https://api.github.com/users/tbiethman","html_url":"https://github.com/tbiethman","followers_url":"https://api.github.com/users/tbiethman/followers","following_url":"https://api.github.com/users/tbiethman/following{/other_user}","gists_url":"https://api.github.com/users/tbiethman/gists{/gist_id}","starred_url":"https://api.github.com/users/tbiethman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbiethman/subscriptions","organizations_url":"https://api.github.com/users/tbiethman/orgs","repos_url":"https://api.github.com/users/tbiethman/repos","events_url":"https://api.github.com/users/tbiethman/events{/privacy}","received_events_url":"https://api.github.com/users/tbiethman/received_events","type":"User","site_admin":false},"body":"Taking the directionality as a prop instead would make this more flexible (unnecessarily so?)","created_at":"2017-10-10T15:55:34Z","updated_at":"2017-10-10T15:55:35Z","html_url":"https://github.com/cerner/terra-core/pull/879#discussion_r143772961","pull_request_url":"https://api.github.com/repos/cerner/terra-core/pulls/879","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/comments/143772961"},"html":{"href":"https://github.com/cerner/terra-core/pull/879#discussion_r143772961"},"pull_request":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/879"}}},"pull_request":{"url":"https://api.github.com/repos/cerner/terra-core/pulls/879","id":144254705,"html_url":"https://github.com/cerner/terra-core/pull/879","diff_url":"https://github.com/cerner/terra-core/pull/879.diff","patch_url":"https://github.com/cerner/terra-core/pull/879.patch","issue_url":"https://api.github.com/repos/cerner/terra-core/issues/879","number":879,"state":"open","locked":false,"title":"Terra Hookshot","user":{"login":"jmsv6d","id":4084424,"avatar_url":"https://avatars3.githubusercontent.com/u/4084424?v=4","gravatar_id":"","url":"https://api.github.com/users/jmsv6d","html_url":"https://github.com/jmsv6d","followers_url":"https://api.github.com/users/jmsv6d/followers","following_url":"https://api.github.com/users/jmsv6d/following{/other_user}","gists_url":"https://api.github.com/users/jmsv6d/gists{/gist_id}","starred_url":"https://api.github.com/users/jmsv6d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmsv6d/subscriptions","organizations_url":"https://api.github.com/users/jmsv6d/orgs","repos_url":"https://api.github.com/users/jmsv6d/repos","events_url":"https://api.github.com/users/jmsv6d/events{/privacy}","received_events_url":"https://api.github.com/users/jmsv6d/received_events","type":"User","site_admin":false},"body":"### Summary\r\nResolves #739 Creates Tether alternative capable of handling arrow offsets, target positions, mobile zoom, and shrink package size.\r\n\r\n\r\n### Deployment\r\nhttps://terra-core-deployed-pr-879.herokuapp.com/","created_at":"2017-10-02T18:45:56Z","updated_at":"2017-10-10T15:55:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf27d35d985dd2dbfb44b27713b5d85a712e05df","assignee":{"login":"jmsv6d","id":4084424,"avatar_url":"https://avatars3.githubusercontent.com/u/4084424?v=4","gravatar_id":"","url":"https://api.github.com/users/jmsv6d","html_url":"https://github.com/jmsv6d","followers_url":"https://api.github.com/users/jmsv6d/followers","following_url":"https://api.github.com/users/jmsv6d/following{/other_user}","gists_url":"https://api.github.com/users/jmsv6d/gists{/gist_id}","starred_url":"https://api.github.com/users/jmsv6d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmsv6d/subscriptions","organizations_url":"https://api.github.com/users/jmsv6d/orgs","repos_url":"https://api.github.com/users/jmsv6d/repos","events_url":"https://api.github.com/users/jmsv6d/events{/privacy}","received_events_url":"https://api.github.com/users/jmsv6d/received_events","type":"User","site_admin":false},"assignees":[{"login":"jmsv6d","id":4084424,"avatar_url":"https://avatars3.githubusercontent.com/u/4084424?v=4","gravatar_id":"","url":"https://api.github.com/users/jmsv6d","html_url":"https://github.com/jmsv6d","followers_url":"https://api.github.com/users/jmsv6d/followers","following_url":"https://api.github.com/users/jmsv6d/following{/other_user}","gists_url":"https://api.github.com/users/jmsv6d/gists{/gist_id}","starred_url":"https://api.github.com/users/jmsv6d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmsv6d/subscriptions","organizations_url":"https://api.github.com/users/jmsv6d/orgs","repos_url":"https://api.github.com/users/jmsv6d/repos","events_url":"https://api.github.com/users/jmsv6d/events{/privacy}","received_events_url":"https://api.github.com/users/jmsv6d/received_events","type":"User","site_admin":false},{"login":"emilyrohrbough","id":14099737,"avatar_url":"https://avatars1.githubusercontent.com/u/14099737?v=4","gravatar_id":"","url":"https://api.github.com/users/emilyrohrbough","html_url":"https://github.com/emilyrohrbough","followers_url":"https://api.github.com/users/emilyrohrbough/followers","following_url":"https://api.github.com/users/emilyrohrbough/following{/other_user}","gists_url":"https://api.github.com/users/emilyrohrbough/gists{/gist_id}","starred_url":"https://api.github.com/users/emilyrohrbough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilyrohrbough/subscriptions","organizations_url":"https://api.github.com/users/emilyrohrbough/orgs","repos_url":"https://api.github.com/users/emilyrohrbough/repos","events_url":"https://api.github.com/users/emilyrohrbough/events{/privacy}","received_events_url":"https://api.github.com/users/emilyrohrbough/received_events","type":"User","site_admin":false},{"login":"dkasper-was-taken","id":22619500,"avatar_url":"https://avatars2.githubusercontent.com/u/22619500?v=4","gravatar_id":"","url":"https://api.github.com/users/dkasper-was-taken","html_url":"https://github.com/dkasper-was-taken","followers_url":"https://api.github.com/users/dkasper-was-taken/followers","following_url":"https://api.github.com/users/dkasper-was-taken/following{/other_user}","gists_url":"https://api.github.com/users/dkasper-was-taken/gists{/gist_id}","starred_url":"https://api.github.com/users/dkasper-was-taken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkasper-was-taken/subscriptions","organizations_url":"https://api.github.com/users/dkasper-was-taken/orgs","repos_url":"https://api.github.com/users/dkasper-was-taken/repos","events_url":"https://api.github.com/users/dkasper-was-taken/events{/privacy}","received_events_url":"https://api.github.com/users/dkasper-was-taken/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cerner/terra-core/pulls/879/commits","review_comments_url":"https://api.github.com/repos/cerner/terra-core/pulls/879/comments","review_comment_url":"https://api.github.com/repos/cerner/terra-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cerner/terra-core/issues/879/comments","statuses_url":"https://api.github.com/repos/cerner/terra-core/statuses/27ace3aad46fcb0bd77ee0fb305dc219efc0c542","head":{"label":"cerner:terra-hookshot","ref":"terra-hookshot","sha":"27ace3aad46fcb0bd77ee0fb305dc219efc0c542","user":{"login":"cerner","id":1873208,"avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":83073156,"name":"terra-core","full_name":"cerner/terra-core","owner":{"login":"cerner","id":1873208,"avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerner/terra-core","description":"Terra offers a set of configurable React components designed to help build scalable and modular application UIs. The library easily integrates with webpack-based workflows and was created to solve real-world issues in projects we work on day to day.","fork":false,"url":"https://api.github.com/repos/cerner/terra-core","forks_url":"https://api.github.com/repos/cerner/terra-core/forks","keys_url":"https://api.github.com/repos/cerner/terra-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-core/teams","hooks_url":"https://api.github.com/repos/cerner/terra-core/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-core/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-core/events","assignees_url":"https://api.github.com/repos/cerner/terra-core/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-core/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-core/tags","blobs_url":"https://api.github.com/repos/cerner/terra-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-core/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-core/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-core/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-core/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-core/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-core/subscription","commits_url":"https://api.github.com/repos/cerner/terra-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-core/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-core/merges","archive_url":"https://api.github.com/repos/cerner/terra-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-core/downloads","issues_url":"https://api.github.com/repos/cerner/terra-core/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-core/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-core/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-core/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-core/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-core/deployments","created_at":"2017-02-24T18:57:33Z","updated_at":"2017-10-03T14:59:48Z","pushed_at":"2017-10-10T15:15:30Z","git_url":"git://github.com/cerner/terra-core.git","ssh_url":"[email protected]:cerner/terra-core.git","clone_url":"https://github.com/cerner/terra-core.git","svn_url":"https://github.com/cerner/terra-core","homepage":"http://terra-ui.com","size":9429,"stargazers_count":54,"watchers_count":54,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"open_issues_count":115,"forks":26,"open_issues":115,"watchers":54,"default_branch":"master"}},"base":{"label":"cerner:master","ref":"master","sha":"7d8f0c0fd354669b4db1a2c0dee2f62f1156d6ba","user":{"login":"cerner","id":1873208,"avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":83073156,"name":"terra-core","full_name":"cerner/terra-core","owner":{"login":"cerner","id":1873208,"avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerner/terra-core","description":"Terra offers a set of configurable React components designed to help build scalable and modular application UIs. The library easily integrates with webpack-based workflows and was created to solve real-world issues in projects we work on day to day.","fork":false,"url":"https://api.github.com/repos/cerner/terra-core","forks_url":"https://api.github.com/repos/cerner/terra-core/forks","keys_url":"https://api.github.com/repos/cerner/terra-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-core/teams","hooks_url":"https://api.github.com/repos/cerner/terra-core/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-core/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-core/events","assignees_url":"https://api.github.com/repos/cerner/terra-core/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-core/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-core/tags","blobs_url":"https://api.github.com/repos/cerner/terra-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-core/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-core/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-core/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-core/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-core/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-core/subscription","commits_url":"https://api.github.com/repos/cerner/terra-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-core/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-core/merges","archive_url":"https://api.github.com/repos/cerner/terra-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-core/downloads","issues_url":"https://api.github.com/repos/cerner/terra-core/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-core/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-core/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-core/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-core/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-core/deployments","created_at":"2017-02-24T18:57:33Z","updated_at":"2017-10-03T14:59:48Z","pushed_at":"2017-10-10T15:15:30Z","git_url":"git://github.com/cerner/terra-core.git","ssh_url":"[email protected]:cerner/terra-core.git","clone_url":"https://github.com/cerner/terra-core.git","svn_url":"https://github.com/cerner/terra-core","homepage":"http://terra-ui.com","size":9429,"stargazers_count":54,"watchers_count":54,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"open_issues_count":115,"forks":26,"open_issues":115,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/879"},"html":{"href":"https://github.com/cerner/terra-core/pull/879"},"issue":{"href":"https://api.github.com/repos/cerner/terra-core/issues/879"},"comments":{"href":"https://api.github.com/repos/cerner/terra-core/issues/879/comments"},"review_comments":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/879/comments"},"review_comment":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/879/commits"},"statuses":{"href":"https://api.github.com/repos/cerner/terra-core/statuses/27ace3aad46fcb0bd77ee0fb305dc219efc0c542"}},"author_association":"CONTRIBUTOR"}} | {
"id": 83073156,
"name": "cerner/terra-core",
"url": "https://api.github.com/repos/cerner/terra-core"
} | {
"id": 1711637,
"login": "tbiethman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1711637?",
"url": "https://api.github.com/users/tbiethman"
} | {
"id": 1873208,
"login": "cerner",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1873208?",
"url": "https://api.github.com/orgs/cerner"
} | 2017-10-10T15:55:34 | 6697720024 | {"actor":{"display_login":"tbiethman"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cesium/atomic/pulls/comments/149334812","pull_request_review_id":74709894,"id":149334812,"diff_hunk":"@@ -9,6 +9,16 @@ def can_registrate?(activity)\n can?(:create, registration) && !activity.registered?(current_user)\n end\n \n+ def activity_link(activity)\n+ if current_user.nil?\n+\tsign_in_path\n+ elsif activity.external_link.empty?\n+\tactivity_registration_path(@activity)\n+ else\n+\[email protected]_link\n+ end\n+ end","path":"app/helpers/activities_helper.rb","position":12,"original_position":12,"commit_id":"884c5a020dd54f17453a28f66a2f020b68ae75de","original_commit_id":"884c5a020dd54f17453a28f66a2f020b68ae75de","user":{"login":"marcelo140","id":13511131,"avatar_url":"https://avatars1.githubusercontent.com/u/13511131?v=4","gravatar_id":"","url":"https://api.github.com/users/marcelo140","html_url":"https://github.com/marcelo140","followers_url":"https://api.github.com/users/marcelo140/followers","following_url":"https://api.github.com/users/marcelo140/following{/other_user}","gists_url":"https://api.github.com/users/marcelo140/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelo140/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelo140/subscriptions","organizations_url":"https://api.github.com/users/marcelo140/orgs","repos_url":"https://api.github.com/users/marcelo140/repos","events_url":"https://api.github.com/users/marcelo140/events{/privacy}","received_events_url":"https://api.github.com/users/marcelo140/received_events","type":"User","site_admin":false},"body":"Indentation is wrong","created_at":"2017-11-07T11:03:43Z","updated_at":"2017-11-07T11:03:52Z","html_url":"https://github.com/cesium/atomic/pull/120#discussion_r149334812","pull_request_url":"https://api.github.com/repos/cesium/atomic/pulls/120","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/cesium/atomic/pulls/comments/149334812"},"html":{"href":"https://github.com/cesium/atomic/pull/120#discussion_r149334812"},"pull_request":{"href":"https://api.github.com/repos/cesium/atomic/pulls/120"}}},"pull_request":{"url":"https://api.github.com/repos/cesium/atomic/pulls/120","id":149596229,"html_url":"https://github.com/cesium/atomic/pull/120","diff_url":"https://github.com/cesium/atomic/pull/120.diff","patch_url":"https://github.com/cesium/atomic/pull/120.patch","issue_url":"https://api.github.com/repos/cesium/atomic/issues/120","number":120,"state":"open","locked":false,"title":"Make login and activity registration more noticeable","user":{"login":"9thScientist","id":11543581,"avatar_url":"https://avatars2.githubusercontent.com/u/11543581?v=4","gravatar_id":"","url":"https://api.github.com/users/9thScientist","html_url":"https://github.com/9thScientist","followers_url":"https://api.github.com/users/9thScientist/followers","following_url":"https://api.github.com/users/9thScientist/following{/other_user}","gists_url":"https://api.github.com/users/9thScientist/gists{/gist_id}","starred_url":"https://api.github.com/users/9thScientist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9thScientist/subscriptions","organizations_url":"https://api.github.com/users/9thScientist/orgs","repos_url":"https://api.github.com/users/9thScientist/repos","events_url":"https://api.github.com/users/9thScientist/events{/privacy}","received_events_url":"https://api.github.com/users/9thScientist/received_events","type":"User","site_admin":false},"body":"This PR aims to enhance UI/UX by making the login button more noticeable and draw attention to the fact that is possible to register in activities. Since you need to be logged in to show the 'register' button, people were not noticing it.\r\n\r\nThis PR should:\r\n- [X] Make the 'login' button more noticeable\r\n- [X] Make the 'register' button always present\r\n- [ ] If the user isn't logged in, the 'register' button should redirect to the sign in page and, after a successful login, the user is redirected to the activity page.\r\n- [ ] The 'logout' button should be replaced with the user image.\r\n- [ ] The user image, once clicked, should present a dropdown menu with the option 'logout'\r\n","created_at":"2017-10-30T18:04:49Z","updated_at":"2017-11-07T11:03:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a353377eaa86a8fc79b73f5995c197e211d3bc1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cesium/atomic/pulls/120/commits","review_comments_url":"https://api.github.com/repos/cesium/atomic/pulls/120/comments","review_comment_url":"https://api.github.com/repos/cesium/atomic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cesium/atomic/issues/120/comments","statuses_url":"https://api.github.com/repos/cesium/atomic/statuses/884c5a020dd54f17453a28f66a2f020b68ae75de","head":{"label":"cesium:9c-better-login","ref":"9c-better-login","sha":"884c5a020dd54f17453a28f66a2f020b68ae75de","user":{"login":"cesium","id":2922568,"avatar_url":"https://avatars0.githubusercontent.com/u/2922568?v=4","gravatar_id":"","url":"https://api.github.com/users/cesium","html_url":"https://github.com/cesium","followers_url":"https://api.github.com/users/cesium/followers","following_url":"https://api.github.com/users/cesium/following{/other_user}","gists_url":"https://api.github.com/users/cesium/gists{/gist_id}","starred_url":"https://api.github.com/users/cesium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesium/subscriptions","organizations_url":"https://api.github.com/users/cesium/orgs","repos_url":"https://api.github.com/users/cesium/repos","events_url":"https://api.github.com/users/cesium/events{/privacy}","received_events_url":"https://api.github.com/users/cesium/received_events","type":"Organization","site_admin":false},"repo":{"id":40997862,"name":"atomic","full_name":"cesium/atomic","owner":{"login":"cesium","id":2922568,"avatar_url":"https://avatars0.githubusercontent.com/u/2922568?v=4","gravatar_id":"","url":"https://api.github.com/users/cesium","html_url":"https://github.com/cesium","followers_url":"https://api.github.com/users/cesium/followers","following_url":"https://api.github.com/users/cesium/following{/other_user}","gists_url":"https://api.github.com/users/cesium/gists{/gist_id}","starred_url":"https://api.github.com/users/cesium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesium/subscriptions","organizations_url":"https://api.github.com/users/cesium/orgs","repos_url":"https://api.github.com/users/cesium/repos","events_url":"https://api.github.com/users/cesium/events{/privacy}","received_events_url":"https://api.github.com/users/cesium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cesium/atomic","description":"De-engineered bifurcated intranet","fork":false,"url":"https://api.github.com/repos/cesium/atomic","forks_url":"https://api.github.com/repos/cesium/atomic/forks","keys_url":"https://api.github.com/repos/cesium/atomic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cesium/atomic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cesium/atomic/teams","hooks_url":"https://api.github.com/repos/cesium/atomic/hooks","issue_events_url":"https://api.github.com/repos/cesium/atomic/issues/events{/number}","events_url":"https://api.github.com/repos/cesium/atomic/events","assignees_url":"https://api.github.com/repos/cesium/atomic/assignees{/user}","branches_url":"https://api.github.com/repos/cesium/atomic/branches{/branch}","tags_url":"https://api.github.com/repos/cesium/atomic/tags","blobs_url":"https://api.github.com/repos/cesium/atomic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cesium/atomic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cesium/atomic/git/refs{/sha}","trees_url":"https://api.github.com/repos/cesium/atomic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cesium/atomic/statuses/{sha}","languages_url":"https://api.github.com/repos/cesium/atomic/languages","stargazers_url":"https://api.github.com/repos/cesium/atomic/stargazers","contributors_url":"https://api.github.com/repos/cesium/atomic/contributors","subscribers_url":"https://api.github.com/repos/cesium/atomic/subscribers","subscription_url":"https://api.github.com/repos/cesium/atomic/subscription","commits_url":"https://api.github.com/repos/cesium/atomic/commits{/sha}","git_commits_url":"https://api.github.com/repos/cesium/atomic/git/commits{/sha}","comments_url":"https://api.github.com/repos/cesium/atomic/comments{/number}","issue_comment_url":"https://api.github.com/repos/cesium/atomic/issues/comments{/number}","contents_url":"https://api.github.com/repos/cesium/atomic/contents/{+path}","compare_url":"https://api.github.com/repos/cesium/atomic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cesium/atomic/merges","archive_url":"https://api.github.com/repos/cesium/atomic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cesium/atomic/downloads","issues_url":"https://api.github.com/repos/cesium/atomic/issues{/number}","pulls_url":"https://api.github.com/repos/cesium/atomic/pulls{/number}","milestones_url":"https://api.github.com/repos/cesium/atomic/milestones{/number}","notifications_url":"https://api.github.com/repos/cesium/atomic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cesium/atomic/labels{/name}","releases_url":"https://api.github.com/repos/cesium/atomic/releases{/id}","deployments_url":"https://api.github.com/repos/cesium/atomic/deployments","created_at":"2015-08-18T21:14:14Z","updated_at":"2017-11-06T20:33:23Z","pushed_at":"2017-11-07T00:59:42Z","git_url":"git://github.com/cesium/atomic.git","ssh_url":"[email protected]:cesium/atomic.git","clone_url":"https://github.com/cesium/atomic.git","svn_url":"https://github.com/cesium/atomic","homepage":"http://cesium.di.uminho.pt","size":32993,"stargazers_count":16,"watchers_count":16,"language":"CSS","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":13,"forks":5,"open_issues":13,"watchers":16,"default_branch":"master"}},"base":{"label":"cesium:master","ref":"master","sha":"5ae20e34b940ee480fdf7c8d3d83963bb1ded6a8","user":{"login":"cesium","id":2922568,"avatar_url":"https://avatars0.githubusercontent.com/u/2922568?v=4","gravatar_id":"","url":"https://api.github.com/users/cesium","html_url":"https://github.com/cesium","followers_url":"https://api.github.com/users/cesium/followers","following_url":"https://api.github.com/users/cesium/following{/other_user}","gists_url":"https://api.github.com/users/cesium/gists{/gist_id}","starred_url":"https://api.github.com/users/cesium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesium/subscriptions","organizations_url":"https://api.github.com/users/cesium/orgs","repos_url":"https://api.github.com/users/cesium/repos","events_url":"https://api.github.com/users/cesium/events{/privacy}","received_events_url":"https://api.github.com/users/cesium/received_events","type":"Organization","site_admin":false},"repo":{"id":40997862,"name":"atomic","full_name":"cesium/atomic","owner":{"login":"cesium","id":2922568,"avatar_url":"https://avatars0.githubusercontent.com/u/2922568?v=4","gravatar_id":"","url":"https://api.github.com/users/cesium","html_url":"https://github.com/cesium","followers_url":"https://api.github.com/users/cesium/followers","following_url":"https://api.github.com/users/cesium/following{/other_user}","gists_url":"https://api.github.com/users/cesium/gists{/gist_id}","starred_url":"https://api.github.com/users/cesium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesium/subscriptions","organizations_url":"https://api.github.com/users/cesium/orgs","repos_url":"https://api.github.com/users/cesium/repos","events_url":"https://api.github.com/users/cesium/events{/privacy}","received_events_url":"https://api.github.com/users/cesium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cesium/atomic","description":"De-engineered bifurcated intranet","fork":false,"url":"https://api.github.com/repos/cesium/atomic","forks_url":"https://api.github.com/repos/cesium/atomic/forks","keys_url":"https://api.github.com/repos/cesium/atomic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cesium/atomic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cesium/atomic/teams","hooks_url":"https://api.github.com/repos/cesium/atomic/hooks","issue_events_url":"https://api.github.com/repos/cesium/atomic/issues/events{/number}","events_url":"https://api.github.com/repos/cesium/atomic/events","assignees_url":"https://api.github.com/repos/cesium/atomic/assignees{/user}","branches_url":"https://api.github.com/repos/cesium/atomic/branches{/branch}","tags_url":"https://api.github.com/repos/cesium/atomic/tags","blobs_url":"https://api.github.com/repos/cesium/atomic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cesium/atomic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cesium/atomic/git/refs{/sha}","trees_url":"https://api.github.com/repos/cesium/atomic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cesium/atomic/statuses/{sha}","languages_url":"https://api.github.com/repos/cesium/atomic/languages","stargazers_url":"https://api.github.com/repos/cesium/atomic/stargazers","contributors_url":"https://api.github.com/repos/cesium/atomic/contributors","subscribers_url":"https://api.github.com/repos/cesium/atomic/subscribers","subscription_url":"https://api.github.com/repos/cesium/atomic/subscription","commits_url":"https://api.github.com/repos/cesium/atomic/commits{/sha}","git_commits_url":"https://api.github.com/repos/cesium/atomic/git/commits{/sha}","comments_url":"https://api.github.com/repos/cesium/atomic/comments{/number}","issue_comment_url":"https://api.github.com/repos/cesium/atomic/issues/comments{/number}","contents_url":"https://api.github.com/repos/cesium/atomic/contents/{+path}","compare_url":"https://api.github.com/repos/cesium/atomic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cesium/atomic/merges","archive_url":"https://api.github.com/repos/cesium/atomic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cesium/atomic/downloads","issues_url":"https://api.github.com/repos/cesium/atomic/issues{/number}","pulls_url":"https://api.github.com/repos/cesium/atomic/pulls{/number}","milestones_url":"https://api.github.com/repos/cesium/atomic/milestones{/number}","notifications_url":"https://api.github.com/repos/cesium/atomic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cesium/atomic/labels{/name}","releases_url":"https://api.github.com/repos/cesium/atomic/releases{/id}","deployments_url":"https://api.github.com/repos/cesium/atomic/deployments","created_at":"2015-08-18T21:14:14Z","updated_at":"2017-11-06T20:33:23Z","pushed_at":"2017-11-07T00:59:42Z","git_url":"git://github.com/cesium/atomic.git","ssh_url":"[email protected]:cesium/atomic.git","clone_url":"https://github.com/cesium/atomic.git","svn_url":"https://github.com/cesium/atomic","homepage":"http://cesium.di.uminho.pt","size":32993,"stargazers_count":16,"watchers_count":16,"language":"CSS","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":13,"forks":5,"open_issues":13,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cesium/atomic/pulls/120"},"html":{"href":"https://github.com/cesium/atomic/pull/120"},"issue":{"href":"https://api.github.com/repos/cesium/atomic/issues/120"},"comments":{"href":"https://api.github.com/repos/cesium/atomic/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/cesium/atomic/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/cesium/atomic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cesium/atomic/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/cesium/atomic/statuses/884c5a020dd54f17453a28f66a2f020b68ae75de"}},"author_association":"MEMBER"}} | {
"id": 40997862,
"name": "cesium/atomic",
"url": "https://api.github.com/repos/cesium/atomic"
} | {
"id": 13511131,
"login": "marcelo140",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13511131?",
"url": "https://api.github.com/users/marcelo140"
} | {
"id": 2922568,
"login": "cesium",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2922568?",
"url": "https://api.github.com/orgs/cesium"
} | 2017-11-07T11:03:43 | 6819677478 | {"actor":{"display_login":"marcelo140"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/106791535","pull_request_review_id":27734551,"id":106791535,"diff_hunk":"@@ -236,39 +236,69 @@ func (e *Endpoint) GetModel() *models.Endpoint {\n \t}\n }\n \n-type statusLog struct {\n+// statusLogMsg represents a log message.\n+type statusLogMsg struct {\n \tStatus Status `json:\"status\"`\n \tTimestamp time.Time `json:\"timestamp\"`\n }\n \n-type EndpointStatus struct {\n-\tLog []*statusLog `json:\"log,omitempty\"`\n-\tIndex int `json:\"index\"`\n-\tindexMU sync.RWMutex\n+// statusLog represents a slice of statusLogMsg.\n+type statusLog []*statusLogMsg\n+\n+// priorityStatus represents a map of a single statusLogMsg by StatusPriority.\n+type priorityStatus map[StatusPriority]*statusLogMsg","path":"pkg/endpoint/endpoint.go","position":40,"original_position":19,"commit_id":"7ab72cc62e062c2f301910f3b819b56d5b473bec","original_commit_id":"62445d87a0664f2dd6fad0e0cf024481862f44d8","user":{"login":"aanm","id":5714066,"avatar_url":"https://avatars3.githubusercontent.com/u/5714066?v=3","gravatar_id":"","url":"https://api.github.com/users/aanm","html_url":"https://github.com/aanm","followers_url":"https://api.github.com/users/aanm/followers","following_url":"https://api.github.com/users/aanm/following{/other_user}","gists_url":"https://api.github.com/users/aanm/gists{/gist_id}","starred_url":"https://api.github.com/users/aanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanm/subscriptions","organizations_url":"https://api.github.com/users/aanm/orgs","repos_url":"https://api.github.com/users/aanm/repos","events_url":"https://api.github.com/users/aanm/events{/privacy}","received_events_url":"https://api.github.com/users/aanm/received_events","type":"User","site_admin":false},"body":"It needs to have a sense of a priority in the name. Suggestions?","created_at":"2017-03-18T21:27:59Z","updated_at":"2017-03-18T21:27:59Z","html_url":"https://github.com/cilium/cilium/pull/339#discussion_r106791535","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/339","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/106791535"},"html":{"href":"https://github.com/cilium/cilium/pull/339#discussion_r106791535"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/339"}}},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/339","id":111393634,"html_url":"https://github.com/cilium/cilium/pull/339","diff_url":"https://github.com/cilium/cilium/pull/339.diff","patch_url":"https://github.com/cilium/cilium/pull/339.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/339","number":339,"state":"open","locked":false,"title":"Fixing endpoint status","user":{"login":"aanm","id":5714066,"avatar_url":"https://avatars3.githubusercontent.com/u/5714066?v=3","gravatar_id":"","url":"https://api.github.com/users/aanm","html_url":"https://github.com/aanm","followers_url":"https://api.github.com/users/aanm/followers","following_url":"https://api.github.com/users/aanm/following{/other_user}","gists_url":"https://api.github.com/users/aanm/gists{/gist_id}","starred_url":"https://api.github.com/users/aanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanm/subscriptions","organizations_url":"https://api.github.com/users/aanm/orgs","repos_url":"https://api.github.com/users/aanm/repos","events_url":"https://api.github.com/users/aanm/events{/privacy}","received_events_url":"https://api.github.com/users/aanm/received_events","type":"User","site_admin":false},"body":"@tgraf I can squash the last 2 commits if you want.\r\n\r\nFixes #207 \r\nFixes #316\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/cilium/cilium/pull/339%23discussion_r106771024%22%2C%20%22https%3A//github.com/cilium/cilium/pull/339%23discussion_r106772091%22%2C%20%22https%3A//github.com/cilium/cilium/pull/339%23discussion_r106772158%22%2C%20%22https%3A//github.com/cilium/cilium/pull/339%23discussion_r106772592%22%2C%20%22https%3A//github.com/cilium/cilium/pull/339%23discussion_r106772927%22%2C%20%22https%3A//github.com/cilium/cilium/pull/339%23issuecomment-287516912%22%2C%20%22https%3A//github.com/cilium/cilium/pull/339%23discussion_r106791258%22%2C%20%22https%3A//github.com/cilium/cilium/pull/339%23discussion_r106791529%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/cilium/cilium/pull/339%23issuecomment-287516912%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22TODO%3A%20Implement%20map%20for%20%60CurrentStatus%60%20to%20keep%20low%20priority%20non-OK%20messages.%22%2C%20%22created_at%22%3A%20%222017-03-18T05%3A02%3A10Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars3.githubusercontent.com/u/5714066%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/aanm%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%2C%20%22Pull%2072fc17c736c247588d2f8090b3f7de6a4aa2ec50%20pkg/endpoint/endpoint.go%2069%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/cilium/cilium/pull/339%23discussion_r106772592%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%40tgraf%20Tell%20me%20if%20by%20only%20reading%20this%20explanation%20it%20makes%20sense%20to%20you%20or%20if%20you%20had%20any%20doubts.%22%2C%20%22created_at%22%3A%20%222017-03-18T04%3A15%3A23Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars3.githubusercontent.com/u/5714066%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/aanm%22%7D%7D%2C%20%7B%22body%22%3A%20%22I%27m%20not%20sure%20I%20fully%20understand%20the%20concept%20yet.%20The%20fundamental%20problem%20is%20that%20you%20have%20multiple%20causes%20for%20an%20endpoint%20to%20be%20considered%20in%20an%20failed%20state%3A%5Cr%5Cn%20-%20bpf%20generation%20or%20compilation%5Cr%5Cn%20-%20policy%20calculation%5Cr%5Cn%20-%20....%5Cr%5Cn%5Cr%5CnEach%20of%20these%20causes%20can%20be%20OK/warning/failure.%20You%20want%20to%20report%20an%20overall%20status.%20You%20also%20want%20to%20store%20a%20log%20of%20status%20changes%20for%20each.%20The%20priority%20seems%20to%20indicate%20that%20a%20BPF%20failure%20always%20overwrites%20a%20policy%20failure%20but%20that%20seems%20incomplete.%5Cr%5Cn%5Cr%5CnLet%27s%20assume%3A%5Cr%5Cn1.%20bpf%20fails%5Cr%5Cn2.%20policy%20fails%5Cr%5Cn3.%20bpf%20succeeds%5Cr%5Cn%5Cr%5CnYou%20still%20want%20the%20overall%20state%20to%20say%20failure.%5Cr%5Cn%5Cr%5CnI%20think%20instead%20of%20priority%2C%20what%20you%20want%20is%20this%3A%5Cr%5Cn%60%60%60map%5BStatusComponent%5DstatusLogMsg%60%60%60%5Cr%5Cn%5Cr%5CnBPF%20and%20priority%20are%20both%20%60StatusComponent%60%5Cr%5Cn%5Cr%5CnOverallStatus%20is%20Failure%20if%20any%20of%20the%20components%20failed%2C%20else%20warning%20if%20any%20component%20is%20warning%2C%20else%20OK.%5Cr%5Cn%5Cr%5CnThe%20log%20shows%20the%20latest%20n%20status%20changes%20of%20the%20endpoint.%5Cr%5Cn%5Cr%5Cn%5Cr%5Cn%5Cr%5Cn%5Cr%5Cn%5Cr%5Cn%5Cr%5Cn%22%2C%20%22created_at%22%3A%20%222017-03-18T04%3A38%3A39Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars2.githubusercontent.com/u/1417913%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/tgraf%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20pkg/endpoint/endpoint.go%3AL249-305%22%7D%2C%20%22Pull%20da8e17c03c66878fdc2294e84650cc94d7d37906%20pkg/endpoint/endpoint.go%2057%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/cilium/cilium/pull/339%23discussion_r106772158%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Can%20you%20explain%20this%20priority%20system%20a%20bit.%20I%20assume%20the%20point%20is%20to%20not%20undo%20failure%20state%20unless%20we%20know%20that%20the%20actual%20failure%20is%20gone.%20How%20does%20this%20priority%20actual%20fix%20it%3F%5Cr%5Cn%5Cr%5CnDon%27t%20we%20need%20a%20bitmask%20which%20indicates%20the%20status%20of%20each%20failure%20mode%20and%20if%20any%20of%20them%20is%20set%20to%20failure%20the%20entire%20endpoint%20is%20marked%20as%20failed%3F%22%2C%20%22created_at%22%3A%20%222017-03-18T03%3A45%3A51Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars2.githubusercontent.com/u/1417913%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/tgraf%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20pkg/endpoint/endpoint.go%3AL255-279%22%7D%2C%20%22Pull%207c7bc3cb5c93e33f6ed323a9ac5c39ce4f6e2227%20pkg/endpoint/endpoint.go%2017%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/cilium/cilium/pull/339%23discussion_r106771024%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22What%20kind%20of%20Validation%20you%20were%20talking%20about%3F%22%2C%20%22created_at%22%3A%20%222017-03-18T02%3A38%3A52Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars3.githubusercontent.com/u/5714066%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/aanm%22%7D%7D%2C%20%7B%22body%22%3A%20%22The%20case%20where%20the%20value%20of%20state%20is%20not%20one%20of%20the%20model%20enum.%22%2C%20%22created_at%22%3A%20%222017-03-18T03%3A40%3A56Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars2.githubusercontent.com/u/1417913%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/tgraf%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20pkg/endpoint/endpoint.go%3AL229-236%22%7D%2C%20%22Pull%2062445d87a0664f2dd6fad0e0cf024481862f44d8%20pkg/endpoint/endpoint.go%2019%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/cilium/cilium/pull/339%23discussion_r106791258%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Looks%20great.%20What%20does%20priority%20mean%20in%20this%20context%3F%20I%20would%20rename%20this%20to%20%60componentStatus%60%22%2C%20%22created_at%22%3A%20%222017-03-18T21%3A15%3A28Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars2.githubusercontent.com/u/1417913%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/tgraf%22%7D%7D%2C%20%7B%22body%22%3A%20%22Should%20I%20renamed%20the%20%60StatusPriority%60%20to%20%60StatusComponent%60%3F%22%2C%20%22created_at%22%3A%20%222017-03-18T21%3A27%3A28Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars3.githubusercontent.com/u/5714066%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/aanm%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20pkg/endpoint/endpoint.go%3AL236-305%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [x] <a href='#crh-comment-Pull 7c7bc3cb5c93e33f6ed323a9ac5c39ce4f6e2227 pkg/endpoint/endpoint.go 17'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60> <b><a href='https://github.com/cilium/cilium/pull/339#discussion_r106771024'>File: pkg/endpoint/endpoint.go:L229-236</a></b>\n- <a href='https://github.com/aanm'><img border=0 src='https://avatars3.githubusercontent.com/u/5714066?v=3' height=16 width=16></a> What kind of Validation you were talking about?\n- <a href='https://github.com/tgraf'><img border=0 src='https://avatars2.githubusercontent.com/u/1417913?v=3' height=16 width=16></a> The case where the value of state is not one of the model enum.\n- [x] <a href='#crh-comment-Pull da8e17c03c66878fdc2294e84650cc94d7d37906 pkg/endpoint/endpoint.go 57'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60> <b><a href='https://github.com/cilium/cilium/pull/339#discussion_r106772158'>File: pkg/endpoint/endpoint.go:L255-279</a></b>\n- <a href='https://github.com/tgraf'><img border=0 src='https://avatars2.githubusercontent.com/u/1417913?v=3' height=16 width=16></a> Can you explain this priority system a bit. I assume the point is to not undo failure state unless we know that the actual failure is gone. How does this priority actual fix it?\nDon't we need a bitmask which indicates the status of each failure mode and if any of them is set to failure the entire endpoint is marked as failed?\n- [x] <a href='#crh-comment-Pull 72fc17c736c247588d2f8090b3f7de6a4aa2ec50 pkg/endpoint/endpoint.go 69'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60> <b><a href='https://github.com/cilium/cilium/pull/339#discussion_r106772592'>File: pkg/endpoint/endpoint.go:L249-305</a></b>\n- <a href='https://github.com/aanm'><img border=0 src='https://avatars3.githubusercontent.com/u/5714066?v=3' height=16 width=16></a> @tgraf Tell me if by only reading this explanation it makes sense to you or if you had any doubts.\n- <a href='https://github.com/tgraf'><img border=0 src='https://avatars2.githubusercontent.com/u/1417913?v=3' height=16 width=16></a> I'm not sure I fully understand the concept yet. The fundamental problem is that you have multiple causes for an endpoint to be considered in an failed state:\n- bpf generation or compilation\n- policy calculation\n- ....\nEach of these causes can be OK/warning/failure. You want to report an overall status. You also want to store a log of status changes for each. The priority seems to indicate that a BPF failure always overwrites a policy failure but that seems incomplete.\nLet's assume:\n1. bpf fails\n2. policy fails\n3. bpf succeeds\nYou still want the overall state to say failure.\nI think instead of priority, what you want is this:\n```map[StatusComponent]statusLogMsg```\nBPF and priority are both `StatusComponent`\nOverallStatus is Failure if any of the components failed, else warning if any component is warning, else OK.\nThe log shows the latest n status changes of the endpoint.\n- [x] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60> <b><a href='https://github.com/cilium/cilium/pull/339#issuecomment-287516912'>General Comment</a></b>\n- <a href='https://github.com/aanm'><img border=0 src='https://avatars3.githubusercontent.com/u/5714066?v=3' height=16 width=16></a> TODO: Implement map for `CurrentStatus` to keep low priority non-OK messages.\n- [ ] <a href='#crh-comment-Pull 62445d87a0664f2dd6fad0e0cf024481862f44d8 pkg/endpoint/endpoint.go 19'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60> <b><a href='https://github.com/cilium/cilium/pull/339#discussion_r106791258'>File: pkg/endpoint/endpoint.go:L236-305</a></b>\n- <a href='https://github.com/tgraf'><img border=0 src='https://avatars2.githubusercontent.com/u/1417913?v=3' height=16 width=16></a> Looks great. What does priority mean in this context? I would rename this to `componentStatus`\n- <a href='https://github.com/aanm'><img border=0 src='https://avatars3.githubusercontent.com/u/5714066?v=3' height=16 width=16></a> Should I renamed the `StatusPriority` to `StatusComponent`?\n\n\n<a href='https://www.codereviewhub.com/cilium/cilium/pull/339?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a> <a href='https://www.codereviewhub.com/cilium/cilium/pull/339?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a> <a href='https://github.com/cilium/cilium/pull/339'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2017-03-18T02:38:26Z","updated_at":"2017-03-18T21:27:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"866decd269e72b6ddcc3237bc6c1886c4005f7a3","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cilium/cilium/milestones/1","html_url":"https://github.com/cilium/cilium/milestone/1","labels_url":"https://api.github.com/repos/cilium/cilium/milestones/1/labels","id":2392299,"number":1,"title":"0.8 release","description":"","creator":{"login":"tgraf","id":1417913,"avatar_url":"https://avatars2.githubusercontent.com/u/1417913?v=3","gravatar_id":"","url":"https://api.github.com/users/tgraf","html_url":"https://github.com/tgraf","followers_url":"https://api.github.com/users/tgraf/followers","following_url":"https://api.github.com/users/tgraf/following{/other_user}","gists_url":"https://api.github.com/users/tgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/tgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgraf/subscriptions","organizations_url":"https://api.github.com/users/tgraf/orgs","repos_url":"https://api.github.com/users/tgraf/repos","events_url":"https://api.github.com/users/tgraf/events{/privacy}","received_events_url":"https://api.github.com/users/tgraf/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":10,"state":"open","created_at":"2017-03-17T01:38:54Z","updated_at":"2017-03-18T20:14:47Z","due_on":"2017-03-24T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/339/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/339/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/339/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/7ab72cc62e062c2f301910f3b819b56d5b473bec","head":{"label":"cilium:fixing-endpoint-status","ref":"fixing-endpoint-status","sha":"7ab72cc62e062c2f301910f3b819b56d5b473bec","user":{"login":"cilium","id":21054566,"avatar_url":"https://avatars3.githubusercontent.com/u/21054566?v=3","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"avatar_url":"https://avatars3.githubusercontent.com/u/21054566?v=3","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"BPF & XDP for containers","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2017-03-16T04:11:36Z","pushed_at":"2017-03-18T21:02:23Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"[email protected]:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":16661,"stargazers_count":328,"watchers_count":328,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":32,"forks":31,"open_issues":32,"watchers":328,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"145cbdc07e0307ba2a58459bdc15d2f40d5c5fac","user":{"login":"cilium","id":21054566,"avatar_url":"https://avatars3.githubusercontent.com/u/21054566?v=3","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"avatar_url":"https://avatars3.githubusercontent.com/u/21054566?v=3","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"BPF & XDP for containers","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2017-03-16T04:11:36Z","pushed_at":"2017-03-18T21:02:23Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"[email protected]:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":16661,"stargazers_count":328,"watchers_count":328,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":32,"forks":31,"open_issues":32,"watchers":328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/339"},"html":{"href":"https://github.com/cilium/cilium/pull/339"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/339"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/339/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/339/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/339/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/7ab72cc62e062c2f301910f3b819b56d5b473bec"}}}} | {
"id": 48109239,
"name": "cilium/cilium",
"url": "https://api.github.com/repos/cilium/cilium"
} | {
"id": 5714066,
"login": "aanm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5714066?",
"url": "https://api.github.com/users/aanm"
} | {
"id": 21054566,
"login": "cilium",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21054566?",
"url": "https://api.github.com/orgs/cilium"
} | 2017-03-18T21:27:59 | 5519774478 | {"actor":{"display_login":"aanm"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cmu-db/peloton/pulls/comments/159159099","pull_request_review_id":86065426,"id":159159099,"diff_hunk":"@@ -0,0 +1,87 @@\n+//===----------------------------------------------------------------------===//\n+//\n+// Peloton\n+//\n+// network_handler_task.h","path":"src/include/network/connection_handler_task.h","position":5,"original_position":5,"commit_id":"9d42fa329edbac279fb55f5cb6eace3bb7e32a17","original_commit_id":"9d42fa329edbac279fb55f5cb6eace3bb7e32a17","user":{"login":"ChTimTsubasa","id":11426044,"avatar_url":"https://avatars2.githubusercontent.com/u/11426044?v=4","gravatar_id":"","url":"https://api.github.com/users/ChTimTsubasa","html_url":"https://github.com/ChTimTsubasa","followers_url":"https://api.github.com/users/ChTimTsubasa/followers","following_url":"https://api.github.com/users/ChTimTsubasa/following{/other_user}","gists_url":"https://api.github.com/users/ChTimTsubasa/gists{/gist_id}","starred_url":"https://api.github.com/users/ChTimTsubasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChTimTsubasa/subscriptions","organizations_url":"https://api.github.com/users/ChTimTsubasa/orgs","repos_url":"https://api.github.com/users/ChTimTsubasa/repos","events_url":"https://api.github.com/users/ChTimTsubasa/events{/privacy}","received_events_url":"https://api.github.com/users/ChTimTsubasa/received_events","type":"User","site_admin":false},"body":"Change the name to connection_handler_task.h here.","created_at":"2018-01-01T16:31:12Z","updated_at":"2018-01-01T17:02:32Z","html_url":"https://github.com/cmu-db/peloton/pull/1010#discussion_r159159099","pull_request_url":"https://api.github.com/repos/cmu-db/peloton/pulls/1010","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/comments/159159099"},"html":{"href":"https://github.com/cmu-db/peloton/pull/1010#discussion_r159159099"},"pull_request":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/1010"}}},"pull_request":{"url":"https://api.github.com/repos/cmu-db/peloton/pulls/1010","id":160291807,"html_url":"https://github.com/cmu-db/peloton/pull/1010","diff_url":"https://github.com/cmu-db/peloton/pull/1010.diff","patch_url":"https://github.com/cmu-db/peloton/pull/1010.patch","issue_url":"https://api.github.com/repos/cmu-db/peloton/issues/1010","number":1010,"state":"open","locked":false,"title":"[Cleanup] Network refactor","user":{"login":"tli2","id":12805799,"avatar_url":"https://avatars1.githubusercontent.com/u/12805799?v=4","gravatar_id":"","url":"https://api.github.com/users/tli2","html_url":"https://github.com/tli2","followers_url":"https://api.github.com/users/tli2/followers","following_url":"https://api.github.com/users/tli2/following{/other_user}","gists_url":"https://api.github.com/users/tli2/gists{/gist_id}","starred_url":"https://api.github.com/users/tli2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tli2/subscriptions","organizations_url":"https://api.github.com/users/tli2/orgs","repos_url":"https://api.github.com/users/tli2/repos","events_url":"https://api.github.com/users/tli2/events{/privacy}","received_events_url":"https://api.github.com/users/tli2/received_events","type":"User","site_admin":false},"body":"See #1002 ","created_at":"2017-12-27T19:19:11Z","updated_at":"2018-01-01T17:02:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b6ac2f9edd4c3be26acb95157ce3433002bf561","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cmu-db/peloton/pulls/1010/commits","review_comments_url":"https://api.github.com/repos/cmu-db/peloton/pulls/1010/comments","review_comment_url":"https://api.github.com/repos/cmu-db/peloton/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cmu-db/peloton/issues/1010/comments","statuses_url":"https://api.github.com/repos/cmu-db/peloton/statuses/9d42fa329edbac279fb55f5cb6eace3bb7e32a17","head":{"label":"cmu-db:network-refactor","ref":"network-refactor","sha":"9d42fa329edbac279fb55f5cb6eace3bb7e32a17","user":{"login":"cmu-db","id":6220241,"avatar_url":"https://avatars0.githubusercontent.com/u/6220241?v=4","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"repo":{"id":28202609,"name":"peloton","full_name":"cmu-db/peloton","owner":{"login":"cmu-db","id":6220241,"avatar_url":"https://avatars0.githubusercontent.com/u/6220241?v=4","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cmu-db/peloton","description":"The Self-Driving Database Management System","fork":false,"url":"https://api.github.com/repos/cmu-db/peloton","forks_url":"https://api.github.com/repos/cmu-db/peloton/forks","keys_url":"https://api.github.com/repos/cmu-db/peloton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmu-db/peloton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmu-db/peloton/teams","hooks_url":"https://api.github.com/repos/cmu-db/peloton/hooks","issue_events_url":"https://api.github.com/repos/cmu-db/peloton/issues/events{/number}","events_url":"https://api.github.com/repos/cmu-db/peloton/events","assignees_url":"https://api.github.com/repos/cmu-db/peloton/assignees{/user}","branches_url":"https://api.github.com/repos/cmu-db/peloton/branches{/branch}","tags_url":"https://api.github.com/repos/cmu-db/peloton/tags","blobs_url":"https://api.github.com/repos/cmu-db/peloton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmu-db/peloton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmu-db/peloton/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmu-db/peloton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmu-db/peloton/statuses/{sha}","languages_url":"https://api.github.com/repos/cmu-db/peloton/languages","stargazers_url":"https://api.github.com/repos/cmu-db/peloton/stargazers","contributors_url":"https://api.github.com/repos/cmu-db/peloton/contributors","subscribers_url":"https://api.github.com/repos/cmu-db/peloton/subscribers","subscription_url":"https://api.github.com/repos/cmu-db/peloton/subscription","commits_url":"https://api.github.com/repos/cmu-db/peloton/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmu-db/peloton/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmu-db/peloton/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmu-db/peloton/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmu-db/peloton/contents/{+path}","compare_url":"https://api.github.com/repos/cmu-db/peloton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmu-db/peloton/merges","archive_url":"https://api.github.com/repos/cmu-db/peloton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmu-db/peloton/downloads","issues_url":"https://api.github.com/repos/cmu-db/peloton/issues{/number}","pulls_url":"https://api.github.com/repos/cmu-db/peloton/pulls{/number}","milestones_url":"https://api.github.com/repos/cmu-db/peloton/milestones{/number}","notifications_url":"https://api.github.com/repos/cmu-db/peloton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmu-db/peloton/labels{/name}","releases_url":"https://api.github.com/repos/cmu-db/peloton/releases{/id}","deployments_url":"https://api.github.com/repos/cmu-db/peloton/deployments","created_at":"2014-12-18T21:35:23Z","updated_at":"2017-12-30T14:41:09Z","pushed_at":"2018-01-01T16:48:06Z","git_url":"git://github.com/cmu-db/peloton.git","ssh_url":"[email protected]:cmu-db/peloton.git","clone_url":"https://github.com/cmu-db/peloton.git","svn_url":"https://github.com/cmu-db/peloton","homepage":"http://pelotondb.io","size":62136,"stargazers_count":1024,"watchers_count":1024,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":344,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":344,"open_issues":100,"watchers":1024,"default_branch":"master"}},"base":{"label":"cmu-db:master","ref":"master","sha":"3f50689f545a96207407f999b135ad37045a2d1e","user":{"login":"cmu-db","id":6220241,"avatar_url":"https://avatars0.githubusercontent.com/u/6220241?v=4","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"repo":{"id":28202609,"name":"peloton","full_name":"cmu-db/peloton","owner":{"login":"cmu-db","id":6220241,"avatar_url":"https://avatars0.githubusercontent.com/u/6220241?v=4","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cmu-db/peloton","description":"The Self-Driving Database Management System","fork":false,"url":"https://api.github.com/repos/cmu-db/peloton","forks_url":"https://api.github.com/repos/cmu-db/peloton/forks","keys_url":"https://api.github.com/repos/cmu-db/peloton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmu-db/peloton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmu-db/peloton/teams","hooks_url":"https://api.github.com/repos/cmu-db/peloton/hooks","issue_events_url":"https://api.github.com/repos/cmu-db/peloton/issues/events{/number}","events_url":"https://api.github.com/repos/cmu-db/peloton/events","assignees_url":"https://api.github.com/repos/cmu-db/peloton/assignees{/user}","branches_url":"https://api.github.com/repos/cmu-db/peloton/branches{/branch}","tags_url":"https://api.github.com/repos/cmu-db/peloton/tags","blobs_url":"https://api.github.com/repos/cmu-db/peloton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmu-db/peloton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmu-db/peloton/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmu-db/peloton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmu-db/peloton/statuses/{sha}","languages_url":"https://api.github.com/repos/cmu-db/peloton/languages","stargazers_url":"https://api.github.com/repos/cmu-db/peloton/stargazers","contributors_url":"https://api.github.com/repos/cmu-db/peloton/contributors","subscribers_url":"https://api.github.com/repos/cmu-db/peloton/subscribers","subscription_url":"https://api.github.com/repos/cmu-db/peloton/subscription","commits_url":"https://api.github.com/repos/cmu-db/peloton/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmu-db/peloton/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmu-db/peloton/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmu-db/peloton/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmu-db/peloton/contents/{+path}","compare_url":"https://api.github.com/repos/cmu-db/peloton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmu-db/peloton/merges","archive_url":"https://api.github.com/repos/cmu-db/peloton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmu-db/peloton/downloads","issues_url":"https://api.github.com/repos/cmu-db/peloton/issues{/number}","pulls_url":"https://api.github.com/repos/cmu-db/peloton/pulls{/number}","milestones_url":"https://api.github.com/repos/cmu-db/peloton/milestones{/number}","notifications_url":"https://api.github.com/repos/cmu-db/peloton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmu-db/peloton/labels{/name}","releases_url":"https://api.github.com/repos/cmu-db/peloton/releases{/id}","deployments_url":"https://api.github.com/repos/cmu-db/peloton/deployments","created_at":"2014-12-18T21:35:23Z","updated_at":"2017-12-30T14:41:09Z","pushed_at":"2018-01-01T16:48:06Z","git_url":"git://github.com/cmu-db/peloton.git","ssh_url":"[email protected]:cmu-db/peloton.git","clone_url":"https://github.com/cmu-db/peloton.git","svn_url":"https://github.com/cmu-db/peloton","homepage":"http://pelotondb.io","size":62136,"stargazers_count":1024,"watchers_count":1024,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":344,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":344,"open_issues":100,"watchers":1024,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/1010"},"html":{"href":"https://github.com/cmu-db/peloton/pull/1010"},"issue":{"href":"https://api.github.com/repos/cmu-db/peloton/issues/1010"},"comments":{"href":"https://api.github.com/repos/cmu-db/peloton/issues/1010/comments"},"review_comments":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/1010/comments"},"review_comment":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/1010/commits"},"statuses":{"href":"https://api.github.com/repos/cmu-db/peloton/statuses/9d42fa329edbac279fb55f5cb6eace3bb7e32a17"}},"author_association":"CONTRIBUTOR"}} | {
"id": 28202609,
"name": "cmu-db/peloton",
"url": "https://api.github.com/repos/cmu-db/peloton"
} | {
"id": 11426044,
"login": "ChTimTsubasa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11426044?",
"url": "https://api.github.com/users/ChTimTsubasa"
} | {
"id": 6220241,
"login": "cmu-db",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6220241?",
"url": "https://api.github.com/orgs/cmu-db"
} | 2018-01-01T16:31:12 | 7045257400 | {"actor":{"display_login":"ChTimTsubasa"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cmu-db/peloton/pulls/comments/116136658","pull_request_review_id":37708445,"id":116136658,"diff_hunk":"@@ -0,0 +1,279 @@\n+//===----------------------------------------------------------------------===//\r\n+//\r\n+// Peloton\r\n+//\r\n+// stats_storage_test.cpp\r\n+//\r\n+// Identification: test/optimizer/stats_storage_test.cpp\r\n+//\r\n+// Copyright (c) 2015-16, Carnegie Mellon University Database Group\r\n+//\r\n+//===----------------------------------------------------------------------===//\r\n+\r\n+#include \"common/harness.h\"\r\n+\r\n+#define private public\r\n+#define protected public\r\n+\r\n+#include \"optimizer/stats/stats_storage.h\"\r\n+#include \"optimizer/stats/column_stats.h\"\r\n+#include \"optimizer/stats/table_stats.h\"\r\n+#include \"storage/data_table.h\"\r\n+#include \"storage/database.h\"\r\n+#include \"storage/tile.h\"\r\n+#include \"catalog/schema.h\"\r\n+#include \"catalog/catalog.h\"\r\n+#include \"catalog/column_stats_catalog.h\"\r\n+#include \"executor/testing_executor_util.h\"\r\n+#include \"concurrency/transaction_manager_factory.h\"\r\n+\r\n+namespace peloton {\r\n+namespace test {\r\n+\r\n+//===--------------------------------------------------------------------===//\r\n+// Binding Tests\r\n+//===--------------------------------------------------------------------===//\r\n+\r\n+using namespace optimizer;\r\n+\r\n+class StatsStorageTests : public PelotonTest {};\r\n+\r\n+const int tuple_count = 100;\r\n+const int tuple_per_tilegroup = 100;\r\n+\r\n+std::unique_ptr<storage::DataTable> InitializeTestTable() {\r\n+ auto &txn_manager = concurrency::TransactionManagerFactory::GetInstance();\r\n+ auto txn = txn_manager.BeginTransaction();\r\n+ std::unique_ptr<storage::DataTable> data_table(\r\n+ TestingExecutorUtil::CreateTable(tuple_per_tilegroup, false));\r\n+ TestingExecutorUtil::PopulateTable(data_table.get(), tuple_count, false,\r\n+ false, true, txn);\r\n+ txn_manager.CommitTransaction(txn);\r\n+ return std::move(data_table);\r\n+}\r\n+\r\n+storage::DataTable *CreateTestDBAndTable() {\r\n+ const std::string test_db_name = \"test_db\";\r\n+ auto database = TestingExecutorUtil::InitializeDatabase(test_db_name);\r\n+\r\n+ auto &txn_manager = concurrency::TransactionManagerFactory::GetInstance();\r\n+ auto txn = txn_manager.BeginTransaction();\r\n+ storage::DataTable *data_table =\r\n+ TestingExecutorUtil::CreateTable(tuple_per_tilegroup, false);\r\n+ TestingExecutorUtil::PopulateTable(data_table, tuple_count, false, false,\r\n+ true, txn);\r\n+ database->AddTable(data_table);\r\n+ txn_manager.CommitTransaction(txn);\r\n+ return data_table;\r\n+}\r\n+\r\n+/**\r\n+ * VerifyAndPrintColumnStats - Verify whether the stats of the test table are\r\n+ *correctly stored in catalog\r\n+ * and print them out.\r\n+ *\r\n+ * The column stats are retrieved by calling the\r\n+ *StatsStorage::GetColumnStatsByID function.\r\n+ * TODO:\r\n+ * 1. Verify the number of tuples in column_stats_catalog.\r\n+ * 2. Compare the column stats values with the ground truth.\r\n+ */\r\n+void VerifyAndPrintColumnStats(storage::DataTable *data_table,\r\n+ int expect_tuple_count) {\r\n+ // Check the tuple count in the 'pg_column_stats' catalog.\r\n+ // auto column_stats_catalog =\r\n+ // catalog::ColumnStatsCatalog::GetInstance(nullptr);\r\n+ StatsStorage *stats_storage = StatsStorage::GetInstance();\r\n+\r\n+ // Verify both the internal data and the stats got by interface.\r","path":"test/optimizer/stats_storage_test.cpp","position":88,"original_position":88,"commit_id":"88318cb38b3bb2a469664b6f353f835d03ab70a7","original_commit_id":"88318cb38b3bb2a469664b6f353f835d03ab70a7","user":{"login":"poojanilangekar","id":7558138,"avatar_url":"https://avatars2.githubusercontent.com/u/7558138?v=3","gravatar_id":"","url":"https://api.github.com/users/poojanilangekar","html_url":"https://github.com/poojanilangekar","followers_url":"https://api.github.com/users/poojanilangekar/followers","following_url":"https://api.github.com/users/poojanilangekar/following{/other_user}","gists_url":"https://api.github.com/users/poojanilangekar/gists{/gist_id}","starred_url":"https://api.github.com/users/poojanilangekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poojanilangekar/subscriptions","organizations_url":"https://api.github.com/users/poojanilangekar/orgs","repos_url":"https://api.github.com/users/poojanilangekar/repos","events_url":"https://api.github.com/users/poojanilangekar/events{/privacy}","received_events_url":"https://api.github.com/users/poojanilangekar/received_events","type":"User","site_admin":false},"body":"Dead code?","created_at":"2017-05-12T01:22:30Z","updated_at":"2017-05-12T01:28:33Z","html_url":"https://github.com/cmu-db/peloton/pull/619#discussion_r116136658","pull_request_url":"https://api.github.com/repos/cmu-db/peloton/pulls/619","_links":{"self":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/comments/116136658"},"html":{"href":"https://github.com/cmu-db/peloton/pull/619#discussion_r116136658"},"pull_request":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/619"}}},"pull_request":{"url":"https://api.github.com/repos/cmu-db/peloton/pulls/619","id":115459702,"html_url":"https://github.com/cmu-db/peloton/pull/619","diff_url":"https://github.com/cmu-db/peloton/pull/619.diff","patch_url":"https://github.com/cmu-db/peloton/pull/619.patch","issue_url":"https://api.github.com/repos/cmu-db/peloton/issues/619","number":619,"state":"open","locked":false,"title":"Stats and Cost Model","user":{"login":"AllisonWang","id":5182499,"avatar_url":"https://avatars3.githubusercontent.com/u/5182499?v=3","gravatar_id":"","url":"https://api.github.com/users/AllisonWang","html_url":"https://github.com/AllisonWang","followers_url":"https://api.github.com/users/AllisonWang/followers","following_url":"https://api.github.com/users/AllisonWang/following{/other_user}","gists_url":"https://api.github.com/users/AllisonWang/gists{/gist_id}","starred_url":"https://api.github.com/users/AllisonWang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AllisonWang/subscriptions","organizations_url":"https://api.github.com/users/AllisonWang/orgs","repos_url":"https://api.github.com/users/AllisonWang/repos","events_url":"https://api.github.com/users/AllisonWang/events{/privacy}","received_events_url":"https://api.github.com/users/AllisonWang/received_events","type":"User","site_admin":false},"body":"This PR adds basic statistics collection mechanism. It uses two ways to collect statistics: probabilistic data structure and sampling. All modified source files are located under `src/optimizer/stats` and corresponding tests are in `test/optimizer`. \r\n\r\n### Probabilistic data structure\r\n\r\n- Count-min sketch & Top_k - calculate most common values and their frequencies\r\n- HyperLogLog (included as a third library) - estimate number of distinct values\r\n- Online histogram building \r\n\r\nThose stats collectors are created by `ColumnStats` which represents all relevant statistics for the column. `TableStats` contains one or more `ColumnStats` and holds statistics for a table. \r\n\r\n### Sampling\r\n\r\nThe class `TupleSampler` can take in a `DataTable` pointer and perform random sampling to get the expected amount of tuple samples.\r\n\r\n### Store table in catalog \r\n\r\nThe class `StatsStorage` provides the following functionalities:\r\n1. Provide an interface for analyzing all tables' statistics: `CollectStatsForAllTables`\r\n2. Provide interfaces for adding stats into Catalog.\r\n3. Provide interfaces for adding samples tables into `samples_db`.\r\n4. Provide interfaces for retrieving stats and samples from Catalog and `samples_db`.\r\n\r\nThe stats table's schema is designed as:\r\n* `database_id`: INTEGER, NOT_NULL\r\n* `table_id`: INTEGER, NOT_NULL\r\n* `column_id`: INTEGER, NOT_NULL\r\n* `num_row`: INTEGER, NOT_NULL\r\n* `cardinality`: DECIMAL, NOT_NULL\r\n* `frac_null`: DECIMAL, NOT_NULL\r\n* `most_common_vals`: VARCHAR\r\n* `most_common_freqs`: DECIMAL\r\n* `histogram_bounds`: VARCHAR\r\n(Since peloton doesn't support ARRAY type now, we temporarily convert the double array to a string and store it as VARCHAR)\r\n\r\nCorresponding unit tests are added for `StatsStorage` and `TupleSampler` functions.\r\n\r\nSome interfaces in `StatsStorage` are not implemented for now. They are: `GetColumnStatsByID`, `GetTupleSamples`, `GetColumnSamples`.","created_at":"2017-04-12T03:59:45Z","updated_at":"2017-05-12T01:28:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a85d8a522b231844f40a85766600b1252cf439ee","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cmu-db/peloton/pulls/619/commits","review_comments_url":"https://api.github.com/repos/cmu-db/peloton/pulls/619/comments","review_comment_url":"https://api.github.com/repos/cmu-db/peloton/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cmu-db/peloton/issues/619/comments","statuses_url":"https://api.github.com/repos/cmu-db/peloton/statuses/88318cb38b3bb2a469664b6f353f835d03ab70a7","head":{"label":"AllisonWang:master","ref":"master","sha":"88318cb38b3bb2a469664b6f353f835d03ab70a7","user":{"login":"AllisonWang","id":5182499,"avatar_url":"https://avatars3.githubusercontent.com/u/5182499?v=3","gravatar_id":"","url":"https://api.github.com/users/AllisonWang","html_url":"https://github.com/AllisonWang","followers_url":"https://api.github.com/users/AllisonWang/followers","following_url":"https://api.github.com/users/AllisonWang/following{/other_user}","gists_url":"https://api.github.com/users/AllisonWang/gists{/gist_id}","starred_url":"https://api.github.com/users/AllisonWang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AllisonWang/subscriptions","organizations_url":"https://api.github.com/users/AllisonWang/orgs","repos_url":"https://api.github.com/users/AllisonWang/repos","events_url":"https://api.github.com/users/AllisonWang/events{/privacy}","received_events_url":"https://api.github.com/users/AllisonWang/received_events","type":"User","site_admin":false},"repo":{"id":79160816,"name":"peloton","full_name":"AllisonWang/peloton","owner":{"login":"AllisonWang","id":5182499,"avatar_url":"https://avatars3.githubusercontent.com/u/5182499?v=3","gravatar_id":"","url":"https://api.github.com/users/AllisonWang","html_url":"https://github.com/AllisonWang","followers_url":"https://api.github.com/users/AllisonWang/followers","following_url":"https://api.github.com/users/AllisonWang/following{/other_user}","gists_url":"https://api.github.com/users/AllisonWang/gists{/gist_id}","starred_url":"https://api.github.com/users/AllisonWang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AllisonWang/subscriptions","organizations_url":"https://api.github.com/users/AllisonWang/orgs","repos_url":"https://api.github.com/users/AllisonWang/repos","events_url":"https://api.github.com/users/AllisonWang/events{/privacy}","received_events_url":"https://api.github.com/users/AllisonWang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AllisonWang/peloton","description":"The Self-Driving Database Management System","fork":true,"url":"https://api.github.com/repos/AllisonWang/peloton","forks_url":"https://api.github.com/repos/AllisonWang/peloton/forks","keys_url":"https://api.github.com/repos/AllisonWang/peloton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AllisonWang/peloton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AllisonWang/peloton/teams","hooks_url":"https://api.github.com/repos/AllisonWang/peloton/hooks","issue_events_url":"https://api.github.com/repos/AllisonWang/peloton/issues/events{/number}","events_url":"https://api.github.com/repos/AllisonWang/peloton/events","assignees_url":"https://api.github.com/repos/AllisonWang/peloton/assignees{/user}","branches_url":"https://api.github.com/repos/AllisonWang/peloton/branches{/branch}","tags_url":"https://api.github.com/repos/AllisonWang/peloton/tags","blobs_url":"https://api.github.com/repos/AllisonWang/peloton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AllisonWang/peloton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AllisonWang/peloton/git/refs{/sha}","trees_url":"https://api.github.com/repos/AllisonWang/peloton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AllisonWang/peloton/statuses/{sha}","languages_url":"https://api.github.com/repos/AllisonWang/peloton/languages","stargazers_url":"https://api.github.com/repos/AllisonWang/peloton/stargazers","contributors_url":"https://api.github.com/repos/AllisonWang/peloton/contributors","subscribers_url":"https://api.github.com/repos/AllisonWang/peloton/subscribers","subscription_url":"https://api.github.com/repos/AllisonWang/peloton/subscription","commits_url":"https://api.github.com/repos/AllisonWang/peloton/commits{/sha}","git_commits_url":"https://api.github.com/repos/AllisonWang/peloton/git/commits{/sha}","comments_url":"https://api.github.com/repos/AllisonWang/peloton/comments{/number}","issue_comment_url":"https://api.github.com/repos/AllisonWang/peloton/issues/comments{/number}","contents_url":"https://api.github.com/repos/AllisonWang/peloton/contents/{+path}","compare_url":"https://api.github.com/repos/AllisonWang/peloton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AllisonWang/peloton/merges","archive_url":"https://api.github.com/repos/AllisonWang/peloton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AllisonWang/peloton/downloads","issues_url":"https://api.github.com/repos/AllisonWang/peloton/issues{/number}","pulls_url":"https://api.github.com/repos/AllisonWang/peloton/pulls{/number}","milestones_url":"https://api.github.com/repos/AllisonWang/peloton/milestones{/number}","notifications_url":"https://api.github.com/repos/AllisonWang/peloton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AllisonWang/peloton/labels{/name}","releases_url":"https://api.github.com/repos/AllisonWang/peloton/releases{/id}","deployments_url":"https://api.github.com/repos/AllisonWang/peloton/deployments","created_at":"2017-01-16T21:23:53Z","updated_at":"2017-04-13T16:14:51Z","pushed_at":"2017-05-09T19:07:32Z","git_url":"git://github.com/AllisonWang/peloton.git","ssh_url":"[email protected]:AllisonWang/peloton.git","clone_url":"https://github.com/AllisonWang/peloton.git","svn_url":"https://github.com/AllisonWang/peloton","homepage":"http://pelotondb.org","size":57621,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cmu-db:master","ref":"master","sha":"2c8c78412cdb9d865920f72e9a397a704d7d3c66","user":{"login":"cmu-db","id":6220241,"avatar_url":"https://avatars3.githubusercontent.com/u/6220241?v=3","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"repo":{"id":28202609,"name":"peloton","full_name":"cmu-db/peloton","owner":{"login":"cmu-db","id":6220241,"avatar_url":"https://avatars3.githubusercontent.com/u/6220241?v=3","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cmu-db/peloton","description":"The Self-Driving Database Management System","fork":false,"url":"https://api.github.com/repos/cmu-db/peloton","forks_url":"https://api.github.com/repos/cmu-db/peloton/forks","keys_url":"https://api.github.com/repos/cmu-db/peloton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmu-db/peloton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmu-db/peloton/teams","hooks_url":"https://api.github.com/repos/cmu-db/peloton/hooks","issue_events_url":"https://api.github.com/repos/cmu-db/peloton/issues/events{/number}","events_url":"https://api.github.com/repos/cmu-db/peloton/events","assignees_url":"https://api.github.com/repos/cmu-db/peloton/assignees{/user}","branches_url":"https://api.github.com/repos/cmu-db/peloton/branches{/branch}","tags_url":"https://api.github.com/repos/cmu-db/peloton/tags","blobs_url":"https://api.github.com/repos/cmu-db/peloton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmu-db/peloton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmu-db/peloton/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmu-db/peloton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmu-db/peloton/statuses/{sha}","languages_url":"https://api.github.com/repos/cmu-db/peloton/languages","stargazers_url":"https://api.github.com/repos/cmu-db/peloton/stargazers","contributors_url":"https://api.github.com/repos/cmu-db/peloton/contributors","subscribers_url":"https://api.github.com/repos/cmu-db/peloton/subscribers","subscription_url":"https://api.github.com/repos/cmu-db/peloton/subscription","commits_url":"https://api.github.com/repos/cmu-db/peloton/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmu-db/peloton/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmu-db/peloton/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmu-db/peloton/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmu-db/peloton/contents/{+path}","compare_url":"https://api.github.com/repos/cmu-db/peloton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmu-db/peloton/merges","archive_url":"https://api.github.com/repos/cmu-db/peloton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmu-db/peloton/downloads","issues_url":"https://api.github.com/repos/cmu-db/peloton/issues{/number}","pulls_url":"https://api.github.com/repos/cmu-db/peloton/pulls{/number}","milestones_url":"https://api.github.com/repos/cmu-db/peloton/milestones{/number}","notifications_url":"https://api.github.com/repos/cmu-db/peloton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmu-db/peloton/labels{/name}","releases_url":"https://api.github.com/repos/cmu-db/peloton/releases{/id}","deployments_url":"https://api.github.com/repos/cmu-db/peloton/deployments","created_at":"2014-12-18T21:35:23Z","updated_at":"2017-05-11T02:45:15Z","pushed_at":"2017-05-12T00:52:44Z","git_url":"git://github.com/cmu-db/peloton.git","ssh_url":"[email protected]:cmu-db/peloton.git","clone_url":"https://github.com/cmu-db/peloton.git","svn_url":"https://github.com/cmu-db/peloton","homepage":"http://pelotondb.io","size":58125,"stargazers_count":687,"watchers_count":687,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":235,"mirror_url":null,"open_issues_count":93,"forks":235,"open_issues":93,"watchers":687,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/619"},"html":{"href":"https://github.com/cmu-db/peloton/pull/619"},"issue":{"href":"https://api.github.com/repos/cmu-db/peloton/issues/619"},"comments":{"href":"https://api.github.com/repos/cmu-db/peloton/issues/619/comments"},"review_comments":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/619/comments"},"review_comment":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/619/commits"},"statuses":{"href":"https://api.github.com/repos/cmu-db/peloton/statuses/88318cb38b3bb2a469664b6f353f835d03ab70a7"}}}} | {
"id": 28202609,
"name": "cmu-db/peloton",
"url": "https://api.github.com/repos/cmu-db/peloton"
} | {
"id": 7558138,
"login": "poojanilangekar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7558138?",
"url": "https://api.github.com/users/poojanilangekar"
} | {
"id": 6220241,
"login": "cmu-db",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6220241?",
"url": "https://api.github.com/orgs/cmu-db"
} | 2017-05-12T01:22:30 | 5857932717 | {"actor":{"display_login":"poojanilangekar"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/107586499","pull_request_review_id":28566877,"id":107586499,"diff_hunk":"@@ -25,10 +26,13 @@\n <AD description=\"The HTTP X-XSS-Protection response header is a feature that stops pages from loading when they detect reflected cross-site scripting (XSS) attacks.\"\n name=\"X-XSS-Protection\" id=\"xXssProtection\" required=\"true\" type=\"String\"\n default=\"1; mode=block\"/>\n+ <AD description=\"The Cache-Control header specifies the behavior for browsers and proxies to cache web resources.\"","path":"platform/platform-filter-response/src/main/resources/OSGI-INF/metatype/metatype.xml","position":14,"original_position":14,"commit_id":"e8c9d44677776719e0851e8419457dfb70ab7bb0","original_commit_id":"e8c9d44677776719e0851e8419457dfb70ab7bb0","user":{"login":"pklinef","id":700518,"avatar_url":"https://avatars2.githubusercontent.com/u/700518?v=3","gravatar_id":"","url":"https://api.github.com/users/pklinef","html_url":"https://github.com/pklinef","followers_url":"https://api.github.com/users/pklinef/followers","following_url":"https://api.github.com/users/pklinef/following{/other_user}","gists_url":"https://api.github.com/users/pklinef/gists{/gist_id}","starred_url":"https://api.github.com/users/pklinef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pklinef/subscriptions","organizations_url":"https://api.github.com/users/pklinef/orgs","repos_url":"https://api.github.com/users/pklinef/repos","events_url":"https://api.github.com/users/pklinef/events{/privacy}","received_events_url":"https://api.github.com/users/pklinef/received_events","type":"User","site_admin":false},"body":"I thought this configuration would be more generic where it would be a list of `header=value` that should be injected into all responses.","created_at":"2017-03-23T04:34:08Z","updated_at":"2017-03-23T04:34:38Z","html_url":"https://github.com/codice/ddf/pull/1798#discussion_r107586499","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/1798","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/107586499"},"html":{"href":"https://github.com/codice/ddf/pull/1798#discussion_r107586499"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/1798"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/1798","id":111688876,"html_url":"https://github.com/codice/ddf/pull/1798","diff_url":"https://github.com/codice/ddf/pull/1798.diff","patch_url":"https://github.com/codice/ddf/pull/1798.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/1798","number":1798,"state":"open","locked":false,"title":"DDF-2893 Refactor response filter to support cache-control","user":{"login":"brendan-hofmann","id":8660335,"avatar_url":"https://avatars3.githubusercontent.com/u/8660335?v=3","gravatar_id":"","url":"https://api.github.com/users/brendan-hofmann","html_url":"https://github.com/brendan-hofmann","followers_url":"https://api.github.com/users/brendan-hofmann/followers","following_url":"https://api.github.com/users/brendan-hofmann/following{/other_user}","gists_url":"https://api.github.com/users/brendan-hofmann/gists{/gist_id}","starred_url":"https://api.github.com/users/brendan-hofmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendan-hofmann/subscriptions","organizations_url":"https://api.github.com/users/brendan-hofmann/orgs","repos_url":"https://api.github.com/users/brendan-hofmann/repos","events_url":"https://api.github.com/users/brendan-hofmann/events{/privacy}","received_events_url":"https://api.github.com/users/brendan-hofmann/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nAdds cache-control to the response filter to fix browser caching.\r\n#### Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged)?\r\n@mcalcote \r\n@AzGoalie \r\n#### Select at least one member from relevant component team(s) from below (at least one component team member needs to approve the PR).\r\n[UI](https://github.com/orgs/codice/teams/ui)\r\n#### Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).\r\n@andrewkfiedler\r\n@pklinef\r\n#### How should this be tested? (List steps with links to updated documentation)\r\nInstall with `?dev=true` so the cert hostname matches your machine. Trust the new demo-CA in your browser. In the admin ui, verify that the platform-response module has the new cache-control configuration. Go to various pages such as admin or the catalog ui and verify that resources are shown as `cached` or `loaded from disk` instead of being fetched each time. You can check this using the network tab of the browser developer tools. Test this in Chrome and Firefox. Note that Firefox has an unrelated bug with url fragments, so it may not cache unless the url navigated to does not have a blank fragment in it.\r\n#### What are the relevant tickets?\r\n[DDF-2893](https://codice.atlassian.net/browse/DDF-2893)\r\n#### Screenshots (if appropriate)\r\n\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Change Log Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n","created_at":"2017-03-21T02:08:24Z","updated_at":"2017-03-23T04:34:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb69846fe472fed03025f0f109cf294194b877f3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/1798/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/1798/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/1798/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/e8c9d44677776719e0851e8419457dfb70ab7bb0","head":{"label":"brendan-hofmann:DDF-2893","ref":"DDF-2893","sha":"e8c9d44677776719e0851e8419457dfb70ab7bb0","user":{"login":"brendan-hofmann","id":8660335,"avatar_url":"https://avatars3.githubusercontent.com/u/8660335?v=3","gravatar_id":"","url":"https://api.github.com/users/brendan-hofmann","html_url":"https://github.com/brendan-hofmann","followers_url":"https://api.github.com/users/brendan-hofmann/followers","following_url":"https://api.github.com/users/brendan-hofmann/following{/other_user}","gists_url":"https://api.github.com/users/brendan-hofmann/gists{/gist_id}","starred_url":"https://api.github.com/users/brendan-hofmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendan-hofmann/subscriptions","organizations_url":"https://api.github.com/users/brendan-hofmann/orgs","repos_url":"https://api.github.com/users/brendan-hofmann/repos","events_url":"https://api.github.com/users/brendan-hofmann/events{/privacy}","received_events_url":"https://api.github.com/users/brendan-hofmann/received_events","type":"User","site_admin":false},"repo":{"id":29319681,"name":"ddf","full_name":"brendan-hofmann/ddf","owner":{"login":"brendan-hofmann","id":8660335,"avatar_url":"https://avatars3.githubusercontent.com/u/8660335?v=3","gravatar_id":"","url":"https://api.github.com/users/brendan-hofmann","html_url":"https://github.com/brendan-hofmann","followers_url":"https://api.github.com/users/brendan-hofmann/followers","following_url":"https://api.github.com/users/brendan-hofmann/following{/other_user}","gists_url":"https://api.github.com/users/brendan-hofmann/gists{/gist_id}","starred_url":"https://api.github.com/users/brendan-hofmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendan-hofmann/subscriptions","organizations_url":"https://api.github.com/users/brendan-hofmann/orgs","repos_url":"https://api.github.com/users/brendan-hofmann/repos","events_url":"https://api.github.com/users/brendan-hofmann/events{/privacy}","received_events_url":"https://api.github.com/users/brendan-hofmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brendan-hofmann/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":true,"url":"https://api.github.com/repos/brendan-hofmann/ddf","forks_url":"https://api.github.com/repos/brendan-hofmann/ddf/forks","keys_url":"https://api.github.com/repos/brendan-hofmann/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brendan-hofmann/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brendan-hofmann/ddf/teams","hooks_url":"https://api.github.com/repos/brendan-hofmann/ddf/hooks","issue_events_url":"https://api.github.com/repos/brendan-hofmann/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/brendan-hofmann/ddf/events","assignees_url":"https://api.github.com/repos/brendan-hofmann/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/brendan-hofmann/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/brendan-hofmann/ddf/tags","blobs_url":"https://api.github.com/repos/brendan-hofmann/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brendan-hofmann/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brendan-hofmann/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/brendan-hofmann/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brendan-hofmann/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/brendan-hofmann/ddf/languages","stargazers_url":"https://api.github.com/repos/brendan-hofmann/ddf/stargazers","contributors_url":"https://api.github.com/repos/brendan-hofmann/ddf/contributors","subscribers_url":"https://api.github.com/repos/brendan-hofmann/ddf/subscribers","subscription_url":"https://api.github.com/repos/brendan-hofmann/ddf/subscription","commits_url":"https://api.github.com/repos/brendan-hofmann/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/brendan-hofmann/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/brendan-hofmann/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/brendan-hofmann/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/brendan-hofmann/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/brendan-hofmann/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brendan-hofmann/ddf/merges","archive_url":"https://api.github.com/repos/brendan-hofmann/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brendan-hofmann/ddf/downloads","issues_url":"https://api.github.com/repos/brendan-hofmann/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/brendan-hofmann/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/brendan-hofmann/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/brendan-hofmann/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brendan-hofmann/ddf/labels{/name}","releases_url":"https://api.github.com/repos/brendan-hofmann/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/brendan-hofmann/ddf/deployments","created_at":"2015-01-15T21:43:26Z","updated_at":"2016-03-23T21:30:16Z","pushed_at":"2017-03-22T23:03:49Z","git_url":"git://github.com/brendan-hofmann/ddf.git","ssh_url":"[email protected]:brendan-hofmann/ddf.git","clone_url":"https://github.com/brendan-hofmann/ddf.git","svn_url":"https://github.com/brendan-hofmann/ddf","homepage":"","size":156859,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:2.10.x","ref":"2.10.x","sha":"34393464da65f59c3e620d731ed7866a1e9a13cb","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars1.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars1.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2017-02-12T21:33:26Z","pushed_at":"2017-03-23T01:30:43Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"[email protected]:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":307496,"stargazers_count":57,"watchers_count":57,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":105,"mirror_url":null,"open_issues_count":24,"forks":105,"open_issues":24,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/1798"},"html":{"href":"https://github.com/codice/ddf/pull/1798"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/1798"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/1798/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/1798/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/1798/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/e8c9d44677776719e0851e8419457dfb70ab7bb0"}}}} | {
"id": 15173563,
"name": "codice/ddf",
"url": "https://api.github.com/repos/codice/ddf"
} | {
"id": 700518,
"login": "pklinef",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/700518?",
"url": "https://api.github.com/users/pklinef"
} | {
"id": 2386734,
"login": "codice",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2386734?",
"url": "https://api.github.com/orgs/codice"
} | 2017-03-23T04:34:08 | 5547232463 | {"actor":{"display_login":"pklinef"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/corcel/acf/pulls/comments/99171762","pull_request_review_id":19840114,"id":99171762,"diff_hunk":"@@ -60,11 +60,12 @@ public function process($field)\n {\n $attachmentId = $this->fetchValue($field);\n \n- $attachment = $this->post->attachment()->find(intval($attachmentId));\n+ $attachment = Post::find(intval($attachmentId));","path":"src/Field/Image.php","position":15,"original_position":15,"commit_id":"3faefd2df691b909e9f3e22123a52cd0c344fa40","original_commit_id":"3faefd2df691b909e9f3e22123a52cd0c344fa40","user":{"login":"tlaverdure","id":1731025,"avatar_url":"https://avatars.githubusercontent.com/u/1731025?v=3","gravatar_id":"","url":"https://api.github.com/users/tlaverdure","html_url":"https://github.com/tlaverdure","followers_url":"https://api.github.com/users/tlaverdure/followers","following_url":"https://api.github.com/users/tlaverdure/following{/other_user}","gists_url":"https://api.github.com/users/tlaverdure/gists{/gist_id}","starred_url":"https://api.github.com/users/tlaverdure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlaverdure/subscriptions","organizations_url":"https://api.github.com/users/tlaverdure/orgs","repos_url":"https://api.github.com/users/tlaverdure/repos","events_url":"https://api.github.com/users/tlaverdure/events{/privacy}","received_events_url":"https://api.github.com/users/tlaverdure/received_events","type":"User","site_admin":false},"body":"Gotcha, ok cool. I'll be standing by.","created_at":"2017-02-02T17:16:33Z","updated_at":"2017-02-02T17:16:33Z","html_url":"https://github.com/corcel/acf/pull/12#discussion_r99171762","pull_request_url":"https://api.github.com/repos/corcel/acf/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/corcel/acf/pulls/comments/99171762"},"html":{"href":"https://github.com/corcel/acf/pull/12#discussion_r99171762"},"pull_request":{"href":"https://api.github.com/repos/corcel/acf/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/corcel/acf/pulls/12","id":103540960,"html_url":"https://github.com/corcel/acf/pull/12","diff_url":"https://github.com/corcel/acf/pull/12.diff","patch_url":"https://github.com/corcel/acf/pull/12.patch","issue_url":"https://api.github.com/repos/corcel/acf/issues/12","number":12,"state":"open","locked":false,"title":"Fix to Image Field still returning null","user":{"login":"tlaverdure","id":1731025,"avatar_url":"https://avatars.githubusercontent.com/u/1731025?v=3","gravatar_id":"","url":"https://api.github.com/users/tlaverdure","html_url":"https://github.com/tlaverdure","followers_url":"https://api.github.com/users/tlaverdure/followers","following_url":"https://api.github.com/users/tlaverdure/following{/other_user}","gists_url":"https://api.github.com/users/tlaverdure/gists{/gist_id}","starred_url":"https://api.github.com/users/tlaverdure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlaverdure/subscriptions","organizations_url":"https://api.github.com/users/tlaverdure/orgs","repos_url":"https://api.github.com/users/tlaverdure/repos","events_url":"https://api.github.com/users/tlaverdure/events{/privacy}","received_events_url":"https://api.github.com/users/tlaverdure/received_events","type":"User","site_admin":false},"body":"@jgrossi I was playing around with this some more and re-discovered what the actual issue use. Using `$this->attachment()` actually only works if you uploaded the image to the post, but if you want to re-use an image on a different post `null` would still be returned.\r\n","created_at":"2017-01-27T18:21:16Z","updated_at":"2017-02-02T17:16:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91d9cfdabed79b18234b5ef3eb8d25c87afd09ec","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/corcel/acf/pulls/12/commits","review_comments_url":"https://api.github.com/repos/corcel/acf/pulls/12/comments","review_comment_url":"https://api.github.com/repos/corcel/acf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/corcel/acf/issues/12/comments","statuses_url":"https://api.github.com/repos/corcel/acf/statuses/3faefd2df691b909e9f3e22123a52cd0c344fa40","head":{"label":"tlaverdure:patch-4","ref":"patch-4","sha":"3faefd2df691b909e9f3e22123a52cd0c344fa40","user":{"login":"tlaverdure","id":1731025,"avatar_url":"https://avatars.githubusercontent.com/u/1731025?v=3","gravatar_id":"","url":"https://api.github.com/users/tlaverdure","html_url":"https://github.com/tlaverdure","followers_url":"https://api.github.com/users/tlaverdure/followers","following_url":"https://api.github.com/users/tlaverdure/following{/other_user}","gists_url":"https://api.github.com/users/tlaverdure/gists{/gist_id}","starred_url":"https://api.github.com/users/tlaverdure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlaverdure/subscriptions","organizations_url":"https://api.github.com/users/tlaverdure/orgs","repos_url":"https://api.github.com/users/tlaverdure/repos","events_url":"https://api.github.com/users/tlaverdure/events{/privacy}","received_events_url":"https://api.github.com/users/tlaverdure/received_events","type":"User","site_admin":false},"repo":{"id":80138890,"name":"acf","full_name":"tlaverdure/acf","owner":{"login":"tlaverdure","id":1731025,"avatar_url":"https://avatars.githubusercontent.com/u/1731025?v=3","gravatar_id":"","url":"https://api.github.com/users/tlaverdure","html_url":"https://github.com/tlaverdure","followers_url":"https://api.github.com/users/tlaverdure/followers","following_url":"https://api.github.com/users/tlaverdure/following{/other_user}","gists_url":"https://api.github.com/users/tlaverdure/gists{/gist_id}","starred_url":"https://api.github.com/users/tlaverdure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlaverdure/subscriptions","organizations_url":"https://api.github.com/users/tlaverdure/orgs","repos_url":"https://api.github.com/users/tlaverdure/repos","events_url":"https://api.github.com/users/tlaverdure/events{/privacy}","received_events_url":"https://api.github.com/users/tlaverdure/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tlaverdure/acf","description":"Advanced Custom Fields (ACF) plugin for Corcel","fork":true,"url":"https://api.github.com/repos/tlaverdure/acf","forks_url":"https://api.github.com/repos/tlaverdure/acf/forks","keys_url":"https://api.github.com/repos/tlaverdure/acf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tlaverdure/acf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tlaverdure/acf/teams","hooks_url":"https://api.github.com/repos/tlaverdure/acf/hooks","issue_events_url":"https://api.github.com/repos/tlaverdure/acf/issues/events{/number}","events_url":"https://api.github.com/repos/tlaverdure/acf/events","assignees_url":"https://api.github.com/repos/tlaverdure/acf/assignees{/user}","branches_url":"https://api.github.com/repos/tlaverdure/acf/branches{/branch}","tags_url":"https://api.github.com/repos/tlaverdure/acf/tags","blobs_url":"https://api.github.com/repos/tlaverdure/acf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tlaverdure/acf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tlaverdure/acf/git/refs{/sha}","trees_url":"https://api.github.com/repos/tlaverdure/acf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tlaverdure/acf/statuses/{sha}","languages_url":"https://api.github.com/repos/tlaverdure/acf/languages","stargazers_url":"https://api.github.com/repos/tlaverdure/acf/stargazers","contributors_url":"https://api.github.com/repos/tlaverdure/acf/contributors","subscribers_url":"https://api.github.com/repos/tlaverdure/acf/subscribers","subscription_url":"https://api.github.com/repos/tlaverdure/acf/subscription","commits_url":"https://api.github.com/repos/tlaverdure/acf/commits{/sha}","git_commits_url":"https://api.github.com/repos/tlaverdure/acf/git/commits{/sha}","comments_url":"https://api.github.com/repos/tlaverdure/acf/comments{/number}","issue_comment_url":"https://api.github.com/repos/tlaverdure/acf/issues/comments{/number}","contents_url":"https://api.github.com/repos/tlaverdure/acf/contents/{+path}","compare_url":"https://api.github.com/repos/tlaverdure/acf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tlaverdure/acf/merges","archive_url":"https://api.github.com/repos/tlaverdure/acf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tlaverdure/acf/downloads","issues_url":"https://api.github.com/repos/tlaverdure/acf/issues{/number}","pulls_url":"https://api.github.com/repos/tlaverdure/acf/pulls{/number}","milestones_url":"https://api.github.com/repos/tlaverdure/acf/milestones{/number}","notifications_url":"https://api.github.com/repos/tlaverdure/acf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tlaverdure/acf/labels{/name}","releases_url":"https://api.github.com/repos/tlaverdure/acf/releases{/id}","deployments_url":"https://api.github.com/repos/tlaverdure/acf/deployments","created_at":"2017-01-26T17:46:21Z","updated_at":"2017-01-26T17:46:23Z","pushed_at":"2017-01-27T18:16:33Z","git_url":"git://github.com/tlaverdure/acf.git","ssh_url":"[email protected]:tlaverdure/acf.git","clone_url":"https://github.com/tlaverdure/acf.git","svn_url":"https://github.com/tlaverdure/acf","homepage":"","size":637,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"corcel:develop","ref":"develop","sha":"c3c82af44d7d0f35c60ea668984a5007e77f1807","user":{"login":"corcel","id":20110961,"avatar_url":"https://avatars.githubusercontent.com/u/20110961?v=3","gravatar_id":"","url":"https://api.github.com/users/corcel","html_url":"https://github.com/corcel","followers_url":"https://api.github.com/users/corcel/followers","following_url":"https://api.github.com/users/corcel/following{/other_user}","gists_url":"https://api.github.com/users/corcel/gists{/gist_id}","starred_url":"https://api.github.com/users/corcel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corcel/subscriptions","organizations_url":"https://api.github.com/users/corcel/orgs","repos_url":"https://api.github.com/users/corcel/repos","events_url":"https://api.github.com/users/corcel/events{/privacy}","received_events_url":"https://api.github.com/users/corcel/received_events","type":"Organization","site_admin":false},"repo":{"id":70165503,"name":"acf","full_name":"corcel/acf","owner":{"login":"corcel","id":20110961,"avatar_url":"https://avatars.githubusercontent.com/u/20110961?v=3","gravatar_id":"","url":"https://api.github.com/users/corcel","html_url":"https://github.com/corcel","followers_url":"https://api.github.com/users/corcel/followers","following_url":"https://api.github.com/users/corcel/following{/other_user}","gists_url":"https://api.github.com/users/corcel/gists{/gist_id}","starred_url":"https://api.github.com/users/corcel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corcel/subscriptions","organizations_url":"https://api.github.com/users/corcel/orgs","repos_url":"https://api.github.com/users/corcel/repos","events_url":"https://api.github.com/users/corcel/events{/privacy}","received_events_url":"https://api.github.com/users/corcel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corcel/acf","description":"Advanced Custom Fields (ACF) plugin for Corcel","fork":false,"url":"https://api.github.com/repos/corcel/acf","forks_url":"https://api.github.com/repos/corcel/acf/forks","keys_url":"https://api.github.com/repos/corcel/acf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corcel/acf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corcel/acf/teams","hooks_url":"https://api.github.com/repos/corcel/acf/hooks","issue_events_url":"https://api.github.com/repos/corcel/acf/issues/events{/number}","events_url":"https://api.github.com/repos/corcel/acf/events","assignees_url":"https://api.github.com/repos/corcel/acf/assignees{/user}","branches_url":"https://api.github.com/repos/corcel/acf/branches{/branch}","tags_url":"https://api.github.com/repos/corcel/acf/tags","blobs_url":"https://api.github.com/repos/corcel/acf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corcel/acf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corcel/acf/git/refs{/sha}","trees_url":"https://api.github.com/repos/corcel/acf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corcel/acf/statuses/{sha}","languages_url":"https://api.github.com/repos/corcel/acf/languages","stargazers_url":"https://api.github.com/repos/corcel/acf/stargazers","contributors_url":"https://api.github.com/repos/corcel/acf/contributors","subscribers_url":"https://api.github.com/repos/corcel/acf/subscribers","subscription_url":"https://api.github.com/repos/corcel/acf/subscription","commits_url":"https://api.github.com/repos/corcel/acf/commits{/sha}","git_commits_url":"https://api.github.com/repos/corcel/acf/git/commits{/sha}","comments_url":"https://api.github.com/repos/corcel/acf/comments{/number}","issue_comment_url":"https://api.github.com/repos/corcel/acf/issues/comments{/number}","contents_url":"https://api.github.com/repos/corcel/acf/contents/{+path}","compare_url":"https://api.github.com/repos/corcel/acf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corcel/acf/merges","archive_url":"https://api.github.com/repos/corcel/acf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corcel/acf/downloads","issues_url":"https://api.github.com/repos/corcel/acf/issues{/number}","pulls_url":"https://api.github.com/repos/corcel/acf/pulls{/number}","milestones_url":"https://api.github.com/repos/corcel/acf/milestones{/number}","notifications_url":"https://api.github.com/repos/corcel/acf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corcel/acf/labels{/name}","releases_url":"https://api.github.com/repos/corcel/acf/releases{/id}","deployments_url":"https://api.github.com/repos/corcel/acf/deployments","created_at":"2016-10-06T15:09:48Z","updated_at":"2016-12-13T21:36:23Z","pushed_at":"2017-01-27T18:21:17Z","git_url":"git://github.com/corcel/acf.git","ssh_url":"[email protected]:corcel/acf.git","clone_url":"https://github.com/corcel/acf.git","svn_url":"https://github.com/corcel/acf","homepage":"","size":635,"stargazers_count":8,"watchers_count":8,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/corcel/acf/pulls/12"},"html":{"href":"https://github.com/corcel/acf/pull/12"},"issue":{"href":"https://api.github.com/repos/corcel/acf/issues/12"},"comments":{"href":"https://api.github.com/repos/corcel/acf/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/corcel/acf/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/corcel/acf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/corcel/acf/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/corcel/acf/statuses/3faefd2df691b909e9f3e22123a52cd0c344fa40"}}}} | {
"id": 70165503,
"name": "corcel/acf",
"url": "https://api.github.com/repos/corcel/acf"
} | {
"id": 1731025,
"login": "tlaverdure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1731025?",
"url": "https://api.github.com/users/tlaverdure"
} | {
"id": 20110961,
"login": "corcel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20110961?",
"url": "https://api.github.com/orgs/corcel"
} | 2017-02-02T17:16:33 | 5256187923 | {"actor":{"display_login":"tlaverdure"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/comments/128985323","pull_request_review_id":51711535,"id":128985323,"diff_hunk":"@@ -0,0 +1,17 @@\n+# Jenkins Jobs\n+\n+This folder contains Jenkins jobs which will be used to build, test and for support the Tectonic-Installer.","path":"tests/jenkins-jobs/README.md","position":3,"original_position":3,"commit_id":"92acd5430581e600d5a5007a358e07ca63bbee92","original_commit_id":"92acd5430581e600d5a5007a358e07ca63bbee92","user":{"login":"cpanato","id":4115580,"avatar_url":"https://avatars2.githubusercontent.com/u/4115580?v=4","gravatar_id":"","url":"https://api.github.com/users/cpanato","html_url":"https://github.com/cpanato","followers_url":"https://api.github.com/users/cpanato/followers","following_url":"https://api.github.com/users/cpanato/following{/other_user}","gists_url":"https://api.github.com/users/cpanato/gists{/gist_id}","starred_url":"https://api.github.com/users/cpanato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpanato/subscriptions","organizations_url":"https://api.github.com/users/cpanato/orgs","repos_url":"https://api.github.com/users/cpanato/repos","events_url":"https://api.github.com/users/cpanato/events{/privacy}","received_events_url":"https://api.github.com/users/cpanato/received_events","type":"User","site_admin":false},"body":"done","created_at":"2017-07-24T09:08:41Z","updated_at":"2017-07-24T09:08:41Z","html_url":"https://github.com/coreos/tectonic-installer/pull/1466#discussion_r128985323","pull_request_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1466","_links":{"self":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/comments/128985323"},"html":{"href":"https://github.com/coreos/tectonic-installer/pull/1466#discussion_r128985323"},"pull_request":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1466"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1466","id":131777848,"html_url":"https://github.com/coreos/tectonic-installer/pull/1466","diff_url":"https://github.com/coreos/tectonic-installer/pull/1466.diff","patch_url":"https://github.com/coreos/tectonic-installer/pull/1466.patch","issue_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/1466","number":1466,"state":"open","locked":false,"title":"ci/tests: add jenkins job to build tectonic-builder image","user":{"login":"cpanato","id":4115580,"avatar_url":"https://avatars2.githubusercontent.com/u/4115580?v=4","gravatar_id":"","url":"https://api.github.com/users/cpanato","html_url":"https://github.com/cpanato","followers_url":"https://api.github.com/users/cpanato/followers","following_url":"https://api.github.com/users/cpanato/following{/other_user}","gists_url":"https://api.github.com/users/cpanato/gists{/gist_id}","starred_url":"https://api.github.com/users/cpanato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpanato/subscriptions","organizations_url":"https://api.github.com/users/cpanato/orgs","repos_url":"https://api.github.com/users/cpanato/repos","events_url":"https://api.github.com/users/cpanato/events{/privacy}","received_events_url":"https://api.github.com/users/cpanato/received_events","type":"User","site_admin":false},"body":"This is a jenkins job that build the tectonic-builder.\r\nInstead of build manually this job can trigger the build and push to the repo.\r\n\r\nThere is a jenkins seed job that will read the /tests/jenkins-jobs and create all jobs in this folder. For now just this will be created.\r\n\r\n","created_at":"2017-07-21T13:46:38Z","updated_at":"2017-07-24T09:08:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1015f63ef0e4df14dbb9c314429547b69870a337","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1466/commits","review_comments_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1466/comments","review_comment_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/1466/comments","statuses_url":"https://api.github.com/repos/coreos/tectonic-installer/statuses/92acd5430581e600d5a5007a358e07ca63bbee92","head":{"label":"cpanato:seed-jobs","ref":"seed-jobs","sha":"92acd5430581e600d5a5007a358e07ca63bbee92","user":{"login":"cpanato","id":4115580,"avatar_url":"https://avatars2.githubusercontent.com/u/4115580?v=4","gravatar_id":"","url":"https://api.github.com/users/cpanato","html_url":"https://github.com/cpanato","followers_url":"https://api.github.com/users/cpanato/followers","following_url":"https://api.github.com/users/cpanato/following{/other_user}","gists_url":"https://api.github.com/users/cpanato/gists{/gist_id}","starred_url":"https://api.github.com/users/cpanato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpanato/subscriptions","organizations_url":"https://api.github.com/users/cpanato/orgs","repos_url":"https://api.github.com/users/cpanato/repos","events_url":"https://api.github.com/users/cpanato/events{/privacy}","received_events_url":"https://api.github.com/users/cpanato/received_events","type":"User","site_admin":false},"repo":{"id":97470375,"name":"tectonic-installer","full_name":"cpanato/tectonic-installer","owner":{"login":"cpanato","id":4115580,"avatar_url":"https://avatars2.githubusercontent.com/u/4115580?v=4","gravatar_id":"","url":"https://api.github.com/users/cpanato","html_url":"https://github.com/cpanato","followers_url":"https://api.github.com/users/cpanato/followers","following_url":"https://api.github.com/users/cpanato/following{/other_user}","gists_url":"https://api.github.com/users/cpanato/gists{/gist_id}","starred_url":"https://api.github.com/users/cpanato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpanato/subscriptions","organizations_url":"https://api.github.com/users/cpanato/orgs","repos_url":"https://api.github.com/users/cpanato/repos","events_url":"https://api.github.com/users/cpanato/events{/privacy}","received_events_url":"https://api.github.com/users/cpanato/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cpanato/tectonic-installer","description":"Install a Kubernetes cluster the CoreOS Tectonic Way: HA, self-hosted, RBAC, etcd Operator, and more","fork":true,"url":"https://api.github.com/repos/cpanato/tectonic-installer","forks_url":"https://api.github.com/repos/cpanato/tectonic-installer/forks","keys_url":"https://api.github.com/repos/cpanato/tectonic-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpanato/tectonic-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpanato/tectonic-installer/teams","hooks_url":"https://api.github.com/repos/cpanato/tectonic-installer/hooks","issue_events_url":"https://api.github.com/repos/cpanato/tectonic-installer/issues/events{/number}","events_url":"https://api.github.com/repos/cpanato/tectonic-installer/events","assignees_url":"https://api.github.com/repos/cpanato/tectonic-installer/assignees{/user}","branches_url":"https://api.github.com/repos/cpanato/tectonic-installer/branches{/branch}","tags_url":"https://api.github.com/repos/cpanato/tectonic-installer/tags","blobs_url":"https://api.github.com/repos/cpanato/tectonic-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpanato/tectonic-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpanato/tectonic-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpanato/tectonic-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpanato/tectonic-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/cpanato/tectonic-installer/languages","stargazers_url":"https://api.github.com/repos/cpanato/tectonic-installer/stargazers","contributors_url":"https://api.github.com/repos/cpanato/tectonic-installer/contributors","subscribers_url":"https://api.github.com/repos/cpanato/tectonic-installer/subscribers","subscription_url":"https://api.github.com/repos/cpanato/tectonic-installer/subscription","commits_url":"https://api.github.com/repos/cpanato/tectonic-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpanato/tectonic-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpanato/tectonic-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpanato/tectonic-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpanato/tectonic-installer/contents/{+path}","compare_url":"https://api.github.com/repos/cpanato/tectonic-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpanato/tectonic-installer/merges","archive_url":"https://api.github.com/repos/cpanato/tectonic-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpanato/tectonic-installer/downloads","issues_url":"https://api.github.com/repos/cpanato/tectonic-installer/issues{/number}","pulls_url":"https://api.github.com/repos/cpanato/tectonic-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/cpanato/tectonic-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/cpanato/tectonic-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpanato/tectonic-installer/labels{/name}","releases_url":"https://api.github.com/repos/cpanato/tectonic-installer/releases{/id}","deployments_url":"https://api.github.com/repos/cpanato/tectonic-installer/deployments","created_at":"2017-07-17T11:47:45Z","updated_at":"2017-07-17T11:47:48Z","pushed_at":"2017-07-24T08:55:45Z","git_url":"git://github.com/cpanato/tectonic-installer.git","ssh_url":"[email protected]:cpanato/tectonic-installer.git","clone_url":"https://github.com/cpanato/tectonic-installer.git","svn_url":"https://github.com/cpanato/tectonic-installer","homepage":"","size":25521,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"c93f055f374e27a441f93a05845ad44d72fd60ae","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":81620471,"name":"tectonic-installer","full_name":"coreos/tectonic-installer","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/tectonic-installer","description":"Install a Kubernetes cluster the CoreOS Tectonic Way: HA, self-hosted, RBAC, etcd Operator, and more","fork":false,"url":"https://api.github.com/repos/coreos/tectonic-installer","forks_url":"https://api.github.com/repos/coreos/tectonic-installer/forks","keys_url":"https://api.github.com/repos/coreos/tectonic-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/tectonic-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/tectonic-installer/teams","hooks_url":"https://api.github.com/repos/coreos/tectonic-installer/hooks","issue_events_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/tectonic-installer/events","assignees_url":"https://api.github.com/repos/coreos/tectonic-installer/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/tectonic-installer/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/tectonic-installer/tags","blobs_url":"https://api.github.com/repos/coreos/tectonic-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/tectonic-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/tectonic-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/tectonic-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/tectonic-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/tectonic-installer/languages","stargazers_url":"https://api.github.com/repos/coreos/tectonic-installer/stargazers","contributors_url":"https://api.github.com/repos/coreos/tectonic-installer/contributors","subscribers_url":"https://api.github.com/repos/coreos/tectonic-installer/subscribers","subscription_url":"https://api.github.com/repos/coreos/tectonic-installer/subscription","commits_url":"https://api.github.com/repos/coreos/tectonic-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/tectonic-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/tectonic-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/tectonic-installer/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/tectonic-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/tectonic-installer/merges","archive_url":"https://api.github.com/repos/coreos/tectonic-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/tectonic-installer/downloads","issues_url":"https://api.github.com/repos/coreos/tectonic-installer/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/tectonic-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/tectonic-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/tectonic-installer/labels{/name}","releases_url":"https://api.github.com/repos/coreos/tectonic-installer/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/tectonic-installer/deployments","created_at":"2017-02-11T00:52:23Z","updated_at":"2017-07-24T08:24:26Z","pushed_at":"2017-07-24T08:55:47Z","git_url":"git://github.com/coreos/tectonic-installer.git","ssh_url":"[email protected]:coreos/tectonic-installer.git","clone_url":"https://github.com/coreos/tectonic-installer.git","svn_url":"https://github.com/coreos/tectonic-installer","homepage":"","size":25517,"stargazers_count":241,"watchers_count":241,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":147,"mirror_url":null,"open_issues_count":286,"forks":147,"open_issues":286,"watchers":241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1466"},"html":{"href":"https://github.com/coreos/tectonic-installer/pull/1466"},"issue":{"href":"https://api.github.com/repos/coreos/tectonic-installer/issues/1466"},"comments":{"href":"https://api.github.com/repos/coreos/tectonic-installer/issues/1466/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1466/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1466/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/tectonic-installer/statuses/92acd5430581e600d5a5007a358e07ca63bbee92"}}}} | {
"id": 81620471,
"name": "coreos/tectonic-installer",
"url": "https://api.github.com/repos/coreos/tectonic-installer"
} | {
"id": 4115580,
"login": "cpanato",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4115580?",
"url": "https://api.github.com/users/cpanato"
} | {
"id": 3730757,
"login": "coreos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3730757?",
"url": "https://api.github.com/orgs/coreos"
} | 2017-07-24T09:08:41 | 6313797086 | {"actor":{"display_login":"cpanato"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/95558704","pull_request_review_id":16115993,"id":95558704,"diff_hunk":"@@ -107,7 +107,10 @@ func cleanupStage0(appName *types.ACName, enterCmd []string) error {\n \t// rely only on the output, since is-active returns non-zero for inactive units\n \tout, _ := cmd.Output()\n \n-\tif string(out) != \"inactive\\n\" {\n+\tswitch string(out) {\n+\tcase \"failed\\n\":","path":"stage1/app-rm/app-rm.go","position":6,"original_position":6,"commit_id":"a11d199ae0024a01de5c428531f683821efcbbfb","original_commit_id":"0282d80368711348ed7e49bbbbb0d3feabd3cd44","user":{"login":"lucab","id":98086,"avatar_url":"https://avatars.githubusercontent.com/u/98086?v=3","gravatar_id":"","url":"https://api.github.com/users/lucab","html_url":"https://github.com/lucab","followers_url":"https://api.github.com/users/lucab/followers","following_url":"https://api.github.com/users/lucab/following{/other_user}","gists_url":"https://api.github.com/users/lucab/gists{/gist_id}","starred_url":"https://api.github.com/users/lucab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucab/subscriptions","organizations_url":"https://api.github.com/users/lucab/orgs","repos_url":"https://api.github.com/users/lucab/repos","events_url":"https://api.github.com/users/lucab/events{/privacy}","received_events_url":"https://api.github.com/users/lucab/received_events","type":"User","site_admin":false},"body":"Can we `TrimRight` here?","created_at":"2017-01-11T11:15:32Z","updated_at":"2017-01-11T11:18:54Z","html_url":"https://github.com/coreos/rkt/pull/3478#discussion_r95558704","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/3478","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/95558704"},"html":{"href":"https://github.com/coreos/rkt/pull/3478#discussion_r95558704"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3478"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/3478","id":97976794,"html_url":"https://github.com/coreos/rkt/pull/3478","diff_url":"https://github.com/coreos/rkt/pull/3478.diff","patch_url":"https://github.com/coreos/rkt/pull/3478.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/3478","number":3478,"state":"open","locked":false,"title":"sandbox: don't exit if an app fails","user":{"login":"s-urbaniak","id":375856,"avatar_url":"https://avatars.githubusercontent.com/u/375856?v=3","gravatar_id":"","url":"https://api.github.com/users/s-urbaniak","html_url":"https://github.com/s-urbaniak","followers_url":"https://api.github.com/users/s-urbaniak/followers","following_url":"https://api.github.com/users/s-urbaniak/following{/other_user}","gists_url":"https://api.github.com/users/s-urbaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/s-urbaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-urbaniak/subscriptions","organizations_url":"https://api.github.com/users/s-urbaniak/orgs","repos_url":"https://api.github.com/users/s-urbaniak/repos","events_url":"https://api.github.com/users/s-urbaniak/events{/privacy}","received_events_url":"https://api.github.com/users/s-urbaniak/received_events","type":"User","site_admin":false},"body":"Currently the sandbox follows the same semantic rule as an immutable\r\npod. As soon as an app fails, it quits immediately.\r\n\r\nThis behavior does not hold for mutable sandboxes. As soon as an app\r\nfails the sandbox needs to stay alive but track the exit code of the\r\nfailed app appropriately.\r\n\r\nAlso in case of restarts the /rkt/status files need to be readjusted.\r\n\r\nThis fixes it.\r\n\r\nAlso fixes #3472\r\n\r\nTODOs:\r\n- [x] functional test which starts two apps\r\n- [x] functional test which starts a faulty app and an app\r\n- [x] functional test which starts only faulty apps","created_at":"2016-12-14T15:41:30Z","updated_at":"2017-01-11T11:18:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2f4f60f039dd2739044a3c35a2e1c99acb51bfd","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/57","html_url":"https://github.com/coreos/rkt/milestone/57","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/57/labels","id":2181652,"number":57,"title":"v1.23.0","description":"","creator":{"login":"lucab","id":98086,"avatar_url":"https://avatars.githubusercontent.com/u/98086?v=3","gravatar_id":"","url":"https://api.github.com/users/lucab","html_url":"https://github.com/lucab","followers_url":"https://api.github.com/users/lucab/followers","following_url":"https://api.github.com/users/lucab/following{/other_user}","gists_url":"https://api.github.com/users/lucab/gists{/gist_id}","starred_url":"https://api.github.com/users/lucab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucab/subscriptions","organizations_url":"https://api.github.com/users/lucab/orgs","repos_url":"https://api.github.com/users/lucab/repos","events_url":"https://api.github.com/users/lucab/events{/privacy}","received_events_url":"https://api.github.com/users/lucab/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":5,"state":"open","created_at":"2016-12-07T13:54:49Z","updated_at":"2017-01-11T10:59:24Z","due_on":"2017-01-19T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/3478/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/3478/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/3478/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/a11d199ae0024a01de5c428531f683821efcbbfb","head":{"label":"s-urbaniak:sandbox-stay-alive-3472","ref":"sandbox-stay-alive-3472","sha":"a11d199ae0024a01de5c428531f683821efcbbfb","user":{"login":"s-urbaniak","id":375856,"avatar_url":"https://avatars.githubusercontent.com/u/375856?v=3","gravatar_id":"","url":"https://api.github.com/users/s-urbaniak","html_url":"https://github.com/s-urbaniak","followers_url":"https://api.github.com/users/s-urbaniak/followers","following_url":"https://api.github.com/users/s-urbaniak/following{/other_user}","gists_url":"https://api.github.com/users/s-urbaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/s-urbaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-urbaniak/subscriptions","organizations_url":"https://api.github.com/users/s-urbaniak/orgs","repos_url":"https://api.github.com/users/s-urbaniak/repos","events_url":"https://api.github.com/users/s-urbaniak/events{/privacy}","received_events_url":"https://api.github.com/users/s-urbaniak/received_events","type":"User","site_admin":false},"repo":{"id":55501235,"name":"rkt","full_name":"s-urbaniak/rkt","owner":{"login":"s-urbaniak","id":375856,"avatar_url":"https://avatars.githubusercontent.com/u/375856?v=3","gravatar_id":"","url":"https://api.github.com/users/s-urbaniak","html_url":"https://github.com/s-urbaniak","followers_url":"https://api.github.com/users/s-urbaniak/followers","following_url":"https://api.github.com/users/s-urbaniak/following{/other_user}","gists_url":"https://api.github.com/users/s-urbaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/s-urbaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-urbaniak/subscriptions","organizations_url":"https://api.github.com/users/s-urbaniak/orgs","repos_url":"https://api.github.com/users/s-urbaniak/repos","events_url":"https://api.github.com/users/s-urbaniak/events{/privacy}","received_events_url":"https://api.github.com/users/s-urbaniak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/s-urbaniak/rkt","description":"rkt is an App Container runtime for Linux","fork":true,"url":"https://api.github.com/repos/s-urbaniak/rkt","forks_url":"https://api.github.com/repos/s-urbaniak/rkt/forks","keys_url":"https://api.github.com/repos/s-urbaniak/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/s-urbaniak/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/s-urbaniak/rkt/teams","hooks_url":"https://api.github.com/repos/s-urbaniak/rkt/hooks","issue_events_url":"https://api.github.com/repos/s-urbaniak/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/s-urbaniak/rkt/events","assignees_url":"https://api.github.com/repos/s-urbaniak/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/s-urbaniak/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/s-urbaniak/rkt/tags","blobs_url":"https://api.github.com/repos/s-urbaniak/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/s-urbaniak/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/s-urbaniak/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/s-urbaniak/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/s-urbaniak/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/s-urbaniak/rkt/languages","stargazers_url":"https://api.github.com/repos/s-urbaniak/rkt/stargazers","contributors_url":"https://api.github.com/repos/s-urbaniak/rkt/contributors","subscribers_url":"https://api.github.com/repos/s-urbaniak/rkt/subscribers","subscription_url":"https://api.github.com/repos/s-urbaniak/rkt/subscription","commits_url":"https://api.github.com/repos/s-urbaniak/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/s-urbaniak/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/s-urbaniak/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/s-urbaniak/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/s-urbaniak/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/s-urbaniak/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/s-urbaniak/rkt/merges","archive_url":"https://api.github.com/repos/s-urbaniak/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/s-urbaniak/rkt/downloads","issues_url":"https://api.github.com/repos/s-urbaniak/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/s-urbaniak/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/s-urbaniak/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/s-urbaniak/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/s-urbaniak/rkt/labels{/name}","releases_url":"https://api.github.com/repos/s-urbaniak/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/s-urbaniak/rkt/deployments","created_at":"2016-04-05T11:09:13Z","updated_at":"2016-04-05T11:09:14Z","pushed_at":"2017-01-10T15:22:46Z","git_url":"git://github.com/s-urbaniak/rkt.git","ssh_url":"[email protected]:s-urbaniak/rkt.git","clone_url":"https://github.com/s-urbaniak/rkt.git","svn_url":"https://github.com/s-urbaniak/rkt","homepage":"","size":24615,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"20b4815828ed504bf8ea5e42f94b0205db685cce","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is a pod-native container engine for Linux. It is composable, secure, and built on standards.","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/rkt/deployments","created_at":"2014-11-11T23:13:18Z","updated_at":"2017-01-11T09:58:23Z","pushed_at":"2017-01-11T10:58:42Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"[email protected]:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":24594,"stargazers_count":6599,"watchers_count":6599,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":643,"mirror_url":null,"open_issues_count":423,"forks":643,"open_issues":423,"watchers":6599,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3478"},"html":{"href":"https://github.com/coreos/rkt/pull/3478"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/3478"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/3478/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3478/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/3478/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/a11d199ae0024a01de5c428531f683821efcbbfb"}}}} | {
"id": 26509369,
"name": "coreos/rkt",
"url": "https://api.github.com/repos/coreos/rkt"
} | {
"id": 98086,
"login": "lucab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/98086?",
"url": "https://api.github.com/users/lucab"
} | {
"id": 3730757,
"login": "coreos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3730757?",
"url": "https://api.github.com/orgs/coreos"
} | 2017-01-11T11:15:32 | 5135145995 | {"actor":{"display_login":"lucab"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/coreos/etcd-operator/pulls/comments/135342412","pull_request_review_id":58749614,"id":135342412,"diff_hunk":"@@ -4,6 +4,7 @@ In etcd operator, we provide the following options to save cluster backups to:\n - Persistent Volume (PV) on GCE or AWS\n - Persistent Volume (PV) with custom StorageClasses\n - S3 bucket on AWS\n+- ABS container on Azure","path":"doc/user/backup_config.md","position":4,"original_position":4,"commit_id":"05c91cfcd0813b5893aa636fe9cce8418f7f91c4","original_commit_id":"05c91cfcd0813b5893aa636fe9cce8418f7f91c4","user":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars1.githubusercontent.com/u/920884?v=4","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"body":"Azure Blob Storage (ABS) container","created_at":"2017-08-25T20:04:56Z","updated_at":"2017-08-25T20:06:52Z","html_url":"https://github.com/coreos/etcd-operator/pull/1237#discussion_r135342412","pull_request_url":"https://api.github.com/repos/coreos/etcd-operator/pulls/1237","_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd-operator/pulls/comments/135342412"},"html":{"href":"https://github.com/coreos/etcd-operator/pull/1237#discussion_r135342412"},"pull_request":{"href":"https://api.github.com/repos/coreos/etcd-operator/pulls/1237"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/etcd-operator/pulls/1237","id":128236847,"html_url":"https://github.com/coreos/etcd-operator/pull/1237","diff_url":"https://github.com/coreos/etcd-operator/pull/1237.diff","patch_url":"https://github.com/coreos/etcd-operator/pull/1237.patch","issue_url":"https://api.github.com/repos/coreos/etcd-operator/issues/1237","number":1237,"state":"open","locked":false,"title":"backend: add Azure Blob Storage (ABS) backup support","user":{"login":"vdice","id":9322017,"avatar_url":"https://avatars3.githubusercontent.com/u/9322017?v=4","gravatar_id":"","url":"https://api.github.com/users/vdice","html_url":"https://github.com/vdice","followers_url":"https://api.github.com/users/vdice/followers","following_url":"https://api.github.com/users/vdice/following{/other_user}","gists_url":"https://api.github.com/users/vdice/gists{/gist_id}","starred_url":"https://api.github.com/users/vdice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdice/subscriptions","organizations_url":"https://api.github.com/users/vdice/orgs","repos_url":"https://api.github.com/users/vdice/repos","events_url":"https://api.github.com/users/vdice/events{/privacy}","received_events_url":"https://api.github.com/users/vdice/received_events","type":"User","site_admin":false},"body":"This PR adds Azure Blob Storage (ABS) backup support.\r\n\r\nAccomplishes part of https://github.com/coreos/etcd-operator/issues/1110","created_at":"2017-06-29T20:11:20Z","updated_at":"2017-08-25T20:06:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22e7cbb1a94b2bf5c69a6a2c7dec790948a7c58d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/etcd-operator/pulls/1237/commits","review_comments_url":"https://api.github.com/repos/coreos/etcd-operator/pulls/1237/comments","review_comment_url":"https://api.github.com/repos/coreos/etcd-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/etcd-operator/issues/1237/comments","statuses_url":"https://api.github.com/repos/coreos/etcd-operator/statuses/05c91cfcd0813b5893aa636fe9cce8418f7f91c4","head":{"label":"vdice:feat/add-abs-support","ref":"feat/add-abs-support","sha":"05c91cfcd0813b5893aa636fe9cce8418f7f91c4","user":{"login":"vdice","id":9322017,"avatar_url":"https://avatars3.githubusercontent.com/u/9322017?v=4","gravatar_id":"","url":"https://api.github.com/users/vdice","html_url":"https://github.com/vdice","followers_url":"https://api.github.com/users/vdice/followers","following_url":"https://api.github.com/users/vdice/following{/other_user}","gists_url":"https://api.github.com/users/vdice/gists{/gist_id}","starred_url":"https://api.github.com/users/vdice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdice/subscriptions","organizations_url":"https://api.github.com/users/vdice/orgs","repos_url":"https://api.github.com/users/vdice/repos","events_url":"https://api.github.com/users/vdice/events{/privacy}","received_events_url":"https://api.github.com/users/vdice/received_events","type":"User","site_admin":false},"repo":{"id":95467737,"name":"etcd-operator","full_name":"vdice/etcd-operator","owner":{"login":"vdice","id":9322017,"avatar_url":"https://avatars3.githubusercontent.com/u/9322017?v=4","gravatar_id":"","url":"https://api.github.com/users/vdice","html_url":"https://github.com/vdice","followers_url":"https://api.github.com/users/vdice/followers","following_url":"https://api.github.com/users/vdice/following{/other_user}","gists_url":"https://api.github.com/users/vdice/gists{/gist_id}","starred_url":"https://api.github.com/users/vdice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdice/subscriptions","organizations_url":"https://api.github.com/users/vdice/orgs","repos_url":"https://api.github.com/users/vdice/repos","events_url":"https://api.github.com/users/vdice/events{/privacy}","received_events_url":"https://api.github.com/users/vdice/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vdice/etcd-operator","description":"etcd operator creates/configures/manages etcd clusters atop Kubernetes","fork":true,"url":"https://api.github.com/repos/vdice/etcd-operator","forks_url":"https://api.github.com/repos/vdice/etcd-operator/forks","keys_url":"https://api.github.com/repos/vdice/etcd-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdice/etcd-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdice/etcd-operator/teams","hooks_url":"https://api.github.com/repos/vdice/etcd-operator/hooks","issue_events_url":"https://api.github.com/repos/vdice/etcd-operator/issues/events{/number}","events_url":"https://api.github.com/repos/vdice/etcd-operator/events","assignees_url":"https://api.github.com/repos/vdice/etcd-operator/assignees{/user}","branches_url":"https://api.github.com/repos/vdice/etcd-operator/branches{/branch}","tags_url":"https://api.github.com/repos/vdice/etcd-operator/tags","blobs_url":"https://api.github.com/repos/vdice/etcd-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdice/etcd-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdice/etcd-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdice/etcd-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdice/etcd-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/vdice/etcd-operator/languages","stargazers_url":"https://api.github.com/repos/vdice/etcd-operator/stargazers","contributors_url":"https://api.github.com/repos/vdice/etcd-operator/contributors","subscribers_url":"https://api.github.com/repos/vdice/etcd-operator/subscribers","subscription_url":"https://api.github.com/repos/vdice/etcd-operator/subscription","commits_url":"https://api.github.com/repos/vdice/etcd-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdice/etcd-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdice/etcd-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdice/etcd-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdice/etcd-operator/contents/{+path}","compare_url":"https://api.github.com/repos/vdice/etcd-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdice/etcd-operator/merges","archive_url":"https://api.github.com/repos/vdice/etcd-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdice/etcd-operator/downloads","issues_url":"https://api.github.com/repos/vdice/etcd-operator/issues{/number}","pulls_url":"https://api.github.com/repos/vdice/etcd-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/vdice/etcd-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/vdice/etcd-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdice/etcd-operator/labels{/name}","releases_url":"https://api.github.com/repos/vdice/etcd-operator/releases{/id}","deployments_url":"https://api.github.com/repos/vdice/etcd-operator/deployments","created_at":"2017-06-26T16:40:58Z","updated_at":"2017-06-26T16:41:00Z","pushed_at":"2017-08-25T20:03:15Z","git_url":"git://github.com/vdice/etcd-operator.git","ssh_url":"[email protected]:vdice/etcd-operator.git","clone_url":"https://github.com/vdice/etcd-operator.git","svn_url":"https://github.com/vdice/etcd-operator","homepage":"https://coreos.com/blog/introducing-the-etcd-operator.html","size":2217,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"e5bf1fa8acd61b6d869e24b5d4a9ced96a2dbaf0","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":64974719,"name":"etcd-operator","full_name":"coreos/etcd-operator","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcd-operator","description":"etcd operator creates/configures/manages etcd clusters atop Kubernetes","fork":false,"url":"https://api.github.com/repos/coreos/etcd-operator","forks_url":"https://api.github.com/repos/coreos/etcd-operator/forks","keys_url":"https://api.github.com/repos/coreos/etcd-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcd-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcd-operator/teams","hooks_url":"https://api.github.com/repos/coreos/etcd-operator/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcd-operator/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcd-operator/events","assignees_url":"https://api.github.com/repos/coreos/etcd-operator/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcd-operator/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcd-operator/tags","blobs_url":"https://api.github.com/repos/coreos/etcd-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcd-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcd-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcd-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcd-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcd-operator/languages","stargazers_url":"https://api.github.com/repos/coreos/etcd-operator/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcd-operator/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcd-operator/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcd-operator/subscription","commits_url":"https://api.github.com/repos/coreos/etcd-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcd-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcd-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcd-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/etcd-operator/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcd-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcd-operator/merges","archive_url":"https://api.github.com/repos/coreos/etcd-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcd-operator/downloads","issues_url":"https://api.github.com/repos/coreos/etcd-operator/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcd-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcd-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcd-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcd-operator/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcd-operator/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/etcd-operator/deployments","created_at":"2016-08-04T23:54:58Z","updated_at":"2017-08-23T02:32:42Z","pushed_at":"2017-08-25T20:03:17Z","git_url":"git://github.com/coreos/etcd-operator.git","ssh_url":"[email protected]:coreos/etcd-operator.git","clone_url":"https://github.com/coreos/etcd-operator.git","svn_url":"https://github.com/coreos/etcd-operator","homepage":"https://coreos.com/blog/introducing-the-etcd-operator.html","size":2186,"stargazers_count":375,"watchers_count":375,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":102,"mirror_url":null,"open_issues_count":80,"forks":102,"open_issues":80,"watchers":375,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd-operator/pulls/1237"},"html":{"href":"https://github.com/coreos/etcd-operator/pull/1237"},"issue":{"href":"https://api.github.com/repos/coreos/etcd-operator/issues/1237"},"comments":{"href":"https://api.github.com/repos/coreos/etcd-operator/issues/1237/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcd-operator/pulls/1237/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcd-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcd-operator/pulls/1237/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcd-operator/statuses/05c91cfcd0813b5893aa636fe9cce8418f7f91c4"}}}} | {
"id": 64974719,
"name": "coreos/etcd-operator",
"url": "https://api.github.com/repos/coreos/etcd-operator"
} | {
"id": 920884,
"login": "hongchaodeng",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/920884?",
"url": "https://api.github.com/users/hongchaodeng"
} | {
"id": 3730757,
"login": "coreos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3730757?",
"url": "https://api.github.com/orgs/coreos"
} | 2017-08-25T20:04:56 | 6513777316 | {"actor":{"display_login":"hongchaodeng"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/comments/100967472","pull_request_review_id":21684051,"id":100967472,"diff_hunk":"@@ -208,6 +208,45 @@ func waitForPodsReady(client v1client.CoreV1Interface, timeout time.Duration, ex\n \t}\n }\n \n+func (f *Framework) WaitForServiceReady(timeout time.Duration, serviceName string) error {","path":"test/e2e/framework/framework.go","position":4,"original_position":4,"commit_id":"119c7ae320e6a2f5aee256b133b0aad8e6f2f4d8","original_commit_id":"119c7ae320e6a2f5aee256b133b0aad8e6f2f4d8","user":{"login":"mxinden","id":7047859,"avatar_url":"https://avatars.githubusercontent.com/u/7047859?v=3","gravatar_id":"","url":"https://api.github.com/users/mxinden","html_url":"https://github.com/mxinden","followers_url":"https://api.github.com/users/mxinden/followers","following_url":"https://api.github.com/users/mxinden/following{/other_user}","gists_url":"https://api.github.com/users/mxinden/gists{/gist_id}","starred_url":"https://api.github.com/users/mxinden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxinden/subscriptions","organizations_url":"https://api.github.com/users/mxinden/orgs","repos_url":"https://api.github.com/users/mxinden/repos","events_url":"https://api.github.com/users/mxinden/events{/privacy}","received_events_url":"https://api.github.com/users/mxinden/received_events","type":"User","site_admin":false},"body":"@brancz You mean something like a function \"ticker\" that takes a function with the specific logic?","created_at":"2017-02-14T06:30:28Z","updated_at":"2017-02-14T06:30:28Z","html_url":"https://github.com/coreos/prometheus-operator/pull/138#discussion_r100967472","pull_request_url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/138","_links":{"self":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/comments/100967472"},"html":{"href":"https://github.com/coreos/prometheus-operator/pull/138#discussion_r100967472"},"pull_request":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/138"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/138","id":105378724,"html_url":"https://github.com/coreos/prometheus-operator/pull/138","diff_url":"https://github.com/coreos/prometheus-operator/pull/138.diff","patch_url":"https://github.com/coreos/prometheus-operator/pull/138.patch","issue_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/138","number":138,"state":"open","locked":false,"title":"test: Add e2e alertmanager & prometheus exposure tests","user":{"login":"mxinden","id":7047859,"avatar_url":"https://avatars.githubusercontent.com/u/7047859?v=3","gravatar_id":"","url":"https://api.github.com/users/mxinden","html_url":"https://github.com/mxinden","followers_url":"https://api.github.com/users/mxinden/followers","following_url":"https://api.github.com/users/mxinden/following{/other_user}","gists_url":"https://api.github.com/users/mxinden/gists{/gist_id}","starred_url":"https://api.github.com/users/mxinden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxinden/subscriptions","organizations_url":"https://api.github.com/users/mxinden/orgs","repos_url":"https://api.github.com/users/mxinden/repos","events_url":"https://api.github.com/users/mxinden/events{/privacy}","received_events_url":"https://api.github.com/users/mxinden/received_events","type":"User","site_admin":false},"body":"Ensuring functionality of the \"Exposing prometheus and alertmanaer\"\r\ntutorial. Testing exposure of alertmanager and prometheus via Nodeport,\r\nKubernetes API and Ingress controller.\r\n\r\nhttps://github.com/coreos/prometheus-operator/blob/master/Documentation/exposing-prometheus-and-alertmanager.md","created_at":"2017-02-09T08:18:14Z","updated_at":"2017-02-14T06:30:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0d04ca8f4dd3a3028d85c2f96d96ecb66a21054","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/138/commits","review_comments_url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/138/comments","review_comment_url":"https://api.github.com/repos/coreos/prometheus-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/138/comments","statuses_url":"https://api.github.com/repos/coreos/prometheus-operator/statuses/119c7ae320e6a2f5aee256b133b0aad8e6f2f4d8","head":{"label":"mxinden:test-exposing-prometheus-alertmanager","ref":"test-exposing-prometheus-alertmanager","sha":"119c7ae320e6a2f5aee256b133b0aad8e6f2f4d8","user":{"login":"mxinden","id":7047859,"avatar_url":"https://avatars.githubusercontent.com/u/7047859?v=3","gravatar_id":"","url":"https://api.github.com/users/mxinden","html_url":"https://github.com/mxinden","followers_url":"https://api.github.com/users/mxinden/followers","following_url":"https://api.github.com/users/mxinden/following{/other_user}","gists_url":"https://api.github.com/users/mxinden/gists{/gist_id}","starred_url":"https://api.github.com/users/mxinden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxinden/subscriptions","organizations_url":"https://api.github.com/users/mxinden/orgs","repos_url":"https://api.github.com/users/mxinden/repos","events_url":"https://api.github.com/users/mxinden/events{/privacy}","received_events_url":"https://api.github.com/users/mxinden/received_events","type":"User","site_admin":false},"repo":{"id":80440361,"name":"prometheus-operator","full_name":"mxinden/prometheus-operator","owner":{"login":"mxinden","id":7047859,"avatar_url":"https://avatars.githubusercontent.com/u/7047859?v=3","gravatar_id":"","url":"https://api.github.com/users/mxinden","html_url":"https://github.com/mxinden","followers_url":"https://api.github.com/users/mxinden/followers","following_url":"https://api.github.com/users/mxinden/following{/other_user}","gists_url":"https://api.github.com/users/mxinden/gists{/gist_id}","starred_url":"https://api.github.com/users/mxinden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxinden/subscriptions","organizations_url":"https://api.github.com/users/mxinden/orgs","repos_url":"https://api.github.com/users/mxinden/repos","events_url":"https://api.github.com/users/mxinden/events{/privacy}","received_events_url":"https://api.github.com/users/mxinden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mxinden/prometheus-operator","description":"Prometheus Operator creates/configures/manages Prometheus clusters atop Kubernetes","fork":true,"url":"https://api.github.com/repos/mxinden/prometheus-operator","forks_url":"https://api.github.com/repos/mxinden/prometheus-operator/forks","keys_url":"https://api.github.com/repos/mxinden/prometheus-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mxinden/prometheus-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mxinden/prometheus-operator/teams","hooks_url":"https://api.github.com/repos/mxinden/prometheus-operator/hooks","issue_events_url":"https://api.github.com/repos/mxinden/prometheus-operator/issues/events{/number}","events_url":"https://api.github.com/repos/mxinden/prometheus-operator/events","assignees_url":"https://api.github.com/repos/mxinden/prometheus-operator/assignees{/user}","branches_url":"https://api.github.com/repos/mxinden/prometheus-operator/branches{/branch}","tags_url":"https://api.github.com/repos/mxinden/prometheus-operator/tags","blobs_url":"https://api.github.com/repos/mxinden/prometheus-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mxinden/prometheus-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mxinden/prometheus-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/mxinden/prometheus-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mxinden/prometheus-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/mxinden/prometheus-operator/languages","stargazers_url":"https://api.github.com/repos/mxinden/prometheus-operator/stargazers","contributors_url":"https://api.github.com/repos/mxinden/prometheus-operator/contributors","subscribers_url":"https://api.github.com/repos/mxinden/prometheus-operator/subscribers","subscription_url":"https://api.github.com/repos/mxinden/prometheus-operator/subscription","commits_url":"https://api.github.com/repos/mxinden/prometheus-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/mxinden/prometheus-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/mxinden/prometheus-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/mxinden/prometheus-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/mxinden/prometheus-operator/contents/{+path}","compare_url":"https://api.github.com/repos/mxinden/prometheus-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mxinden/prometheus-operator/merges","archive_url":"https://api.github.com/repos/mxinden/prometheus-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mxinden/prometheus-operator/downloads","issues_url":"https://api.github.com/repos/mxinden/prometheus-operator/issues{/number}","pulls_url":"https://api.github.com/repos/mxinden/prometheus-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/mxinden/prometheus-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/mxinden/prometheus-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mxinden/prometheus-operator/labels{/name}","releases_url":"https://api.github.com/repos/mxinden/prometheus-operator/releases{/id}","deployments_url":"https://api.github.com/repos/mxinden/prometheus-operator/deployments","created_at":"2017-01-30T16:38:57Z","updated_at":"2017-01-30T16:38:59Z","pushed_at":"2017-02-09T08:15:30Z","git_url":"git://github.com/mxinden/prometheus-operator.git","ssh_url":"[email protected]:mxinden/prometheus-operator.git","clone_url":"https://github.com/mxinden/prometheus-operator.git","svn_url":"https://github.com/mxinden/prometheus-operator","homepage":"https://coreos.com/blog/the-prometheus-operator.html","size":4807,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"78d837f120a9b50c3c09fdf0ea42c358debd9269","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":68964263,"name":"prometheus-operator","full_name":"coreos/prometheus-operator","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/prometheus-operator","description":"Prometheus Operator creates/configures/manages Prometheus clusters atop Kubernetes","fork":false,"url":"https://api.github.com/repos/coreos/prometheus-operator","forks_url":"https://api.github.com/repos/coreos/prometheus-operator/forks","keys_url":"https://api.github.com/repos/coreos/prometheus-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/prometheus-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/prometheus-operator/teams","hooks_url":"https://api.github.com/repos/coreos/prometheus-operator/hooks","issue_events_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/prometheus-operator/events","assignees_url":"https://api.github.com/repos/coreos/prometheus-operator/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/prometheus-operator/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/prometheus-operator/tags","blobs_url":"https://api.github.com/repos/coreos/prometheus-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/prometheus-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/prometheus-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/prometheus-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/prometheus-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/prometheus-operator/languages","stargazers_url":"https://api.github.com/repos/coreos/prometheus-operator/stargazers","contributors_url":"https://api.github.com/repos/coreos/prometheus-operator/contributors","subscribers_url":"https://api.github.com/repos/coreos/prometheus-operator/subscribers","subscription_url":"https://api.github.com/repos/coreos/prometheus-operator/subscription","commits_url":"https://api.github.com/repos/coreos/prometheus-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/prometheus-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/prometheus-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/prometheus-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/prometheus-operator/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/prometheus-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/prometheus-operator/merges","archive_url":"https://api.github.com/repos/coreos/prometheus-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/prometheus-operator/downloads","issues_url":"https://api.github.com/repos/coreos/prometheus-operator/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/prometheus-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/prometheus-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/prometheus-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/prometheus-operator/labels{/name}","releases_url":"https://api.github.com/repos/coreos/prometheus-operator/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/prometheus-operator/deployments","created_at":"2016-09-22T21:38:06Z","updated_at":"2017-02-11T18:53:42Z","pushed_at":"2017-02-14T01:45:57Z","git_url":"git://github.com/coreos/prometheus-operator.git","ssh_url":"[email protected]:coreos/prometheus-operator.git","clone_url":"https://github.com/coreos/prometheus-operator.git","svn_url":"https://github.com/coreos/prometheus-operator","homepage":"https://coreos.com/blog/the-prometheus-operator.html","size":4805,"stargazers_count":140,"watchers_count":140,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":18,"forks":25,"open_issues":18,"watchers":140,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/138"},"html":{"href":"https://github.com/coreos/prometheus-operator/pull/138"},"issue":{"href":"https://api.github.com/repos/coreos/prometheus-operator/issues/138"},"comments":{"href":"https://api.github.com/repos/coreos/prometheus-operator/issues/138/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/138/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/prometheus-operator/pulls/138/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/prometheus-operator/statuses/119c7ae320e6a2f5aee256b133b0aad8e6f2f4d8"}}}} | {
"id": 68964263,
"name": "coreos/prometheus-operator",
"url": "https://api.github.com/repos/coreos/prometheus-operator"
} | {
"id": 7047859,
"login": "mxinden",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7047859?",
"url": "https://api.github.com/users/mxinden"
} | {
"id": 3730757,
"login": "coreos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3730757?",
"url": "https://api.github.com/orgs/coreos"
} | 2017-02-14T06:30:28 | 5319334251 | {"actor":{"display_login":"mxinden"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/151843896","pull_request_review_id":77622402,"id":151843896,"diff_hunk":"@@ -0,0 +1,1110 @@\n+// ---------------------------------------------------------------------\n+//\n+// Copyright (C) 2017 by the deal.II authors\n+//\n+// This file is part of the deal.II library.\n+//\n+// The deal.II library is free software; you can use it, redistribute\n+// it, and/or modify it under the terms of the GNU Lesser General\n+// Public License as published by the Free Software Foundation; either\n+// version 2.1 of the License, or (at your option) any later version.\n+// The full text of the license can be found in the file LICENSE at\n+// the top level of the deal.II distribution.\n+//\n+// ---------------------------------------------------------------------\n+\n+#ifndef dealii_differentiation_ad_ad_drivers_h\n+#define dealii_differentiation_ad_ad_drivers_h\n+\n+#include <deal.II/base/config.h>\n+\n+#include <deal.II/differentiation/ad/ad_number_types.h>\n+#include <deal.II/differentiation/ad/adolc_number_types.h>\n+#include <deal.II/differentiation/ad/sacado_number_types.h>\n+#include <deal.II/lac/full_matrix.h>\n+#include <deal.II/lac/vector.h>\n+\n+#ifdef DEAL_II_WITH_ADOLC\n+\n+DEAL_II_DISABLE_EXTRA_DIAGNOSTICS\n+#include <adolc/drivers/drivers.h>\n+#include <adolc/taping.h>\n+DEAL_II_ENABLE_EXTRA_DIAGNOSTICS\n+\n+#endif // DEAL_II_WITH_ADOLC\n+\n+#include <vector>\n+\n+\n+DEAL_II_NAMESPACE_OPEN\n+\n+\n+namespace Differentiation\n+{\n+ namespace AD\n+ {\n+\n+ /**\n+ * A driver class for taped auto-differentiable numbers.\n+ *\n+ * It is intended that this class be specialized for the valid\n+ * combinations of auto-differentiable numbers and output scalar\n+ * number types.\n+ *\n+ * @tparam ADNumberType A type corresponding to a supported\n+ * auto-differentiable number.\n+ * @tparam ScalarType A real or complex floating point number.\n+ * @tparam T An arbitrary type resulting from the application of\n+ * the SFINAE idiom to selectively specialize this class.\n+ *\n+ * @author Jean-Paul Pelteret, 2017\n+ */\n+ template<typename ADNumberType, typename ScalarType, typename T = void>\n+ struct TapedDrivers\n+ {\n+ // This dummy class definition safely supports compilation\n+ // against tapeless numbers or taped number types that have\n+ // not yet been implemented.\n+\n+ /**\n+ * @name Taping\n+ */\n+ //@{\n+\n+ /**\n+ * Enable the recording mode for a given tape.\n+ *\n+ * @param[in] tape_index The index of the tape to be written\n+ * @param[in] keep_independent_values Determines whether the numerical\n+ * values of all independent variables are recorded in the\n+ * tape buffer.\n+ */\n+ static void\n+ enable_taping(const unsigned int &tape_index,\n+ const bool &keep_independent_values);\n+\n+ /**\n+ * Disable the recording mode for a given tape.\n+ *\n+ * @param[in] active_tape_index The index of the (currently active) tape\n+ * to be finalized and potentially written to file.\n+ * @param[in] write_tapes_to_file A flag that specified whether the tape\n+ * should be written to file or kept in memory.\n+ */\n+ static void\n+ disable_taping(const unsigned int &active_tape_index,\n+ const bool &write_tapes_to_file);\n+\n+ //@}\n+\n+ /**\n+ * @name Drivers for scalar functions (one dependent variable)\n+ */\n+ //@{\n+\n+ /**\n+ * Computes the value of the scalar field.\n+ *\n+ * @param[in] active_tape_index The index of the tape on which the dependent\n+ * function is recorded.\n+ * @param[in] n_independent_variables The number of independent variables\n+ * whose sensitivities were tracked.\n+ * @param[in] independent_variables The scalar values of the independent\n+ * variables whose sensitivities were tracked.\n+ *\n+ * @return The scalar values of the function.\n+ */\n+ static ScalarType\n+ value (const unsigned int &active_tape_index,\n+ const unsigned int &n_independent_variables,\n+ const std::vector<ScalarType> &independent_variables);\n+\n+ /**\n+ * Computes the gradient of the scalar field with respect to all independent\n+ * variables.\n+ *\n+ * @param[in] active_tape_index The index of the tape on which the dependent\n+ * function is recorded.\n+ * @param[in] n_independent_variables The number of independent variables\n+ * whose sensitivities were tracked.\n+ * @param[in] independent_variables The scalar values of the independent\n+ * variables whose sensitivities were tracked.\n+ * @param[out] gradient The scalar values of the dependent function's gradients.\n+ */\n+ static void\n+ gradient (const unsigned int &active_tape_index,\n+ const unsigned int &n_independent_variables,\n+ const std::vector<ScalarType> &independent_variables,\n+ Vector<ScalarType> &gradient);\n+\n+ /**\n+ * Computes the hessian of the scalar field with respect to all independent\n+ * variables.\n+ *\n+ * @param[in] active_tape_index The index of the tape on which the dependent\n+ * function is recorded.\n+ * @param[in] n_independent_variables The number of independent variables\n+ * whose sensitivities were tracked.\n+ * @param[in] independent_variables The scalar values of the independent\n+ * variables whose sensitivities were tracked.\n+ * @param[out] hessian The scalar values of the dependent function's hessian.\n+ */\n+ static void\n+ hessian (const unsigned int &active_tape_index,\n+ const unsigned int &n_independent_variables,\n+ const std::vector<ScalarType> &independent_variables,\n+ FullMatrix<ScalarType> &hessian);\n+\n+ //@}\n+\n+ /**\n+ * @name Drivers for vector functions (multiple dependent variables)\n+ */\n+ //@{\n+\n+ /**\n+ * Computes the values of the vector field.\n+ *\n+ * @param[in] active_tape_index The index of the tape on which the dependent\n+ * function is recorded.\n+ * @param[in] n_dependent_variables The number of dependent variables.\n+ * @param[in] n_independent_variables The number of independent variables\n+ * whose sensitivities were tracked.\n+ * @param[in] independent_variables The scalar values of the independent\n+ * variables whose sensitivities were tracked.\n+ * @param[out] values The scalar values of the dependent functions.\n+ */\n+ static void\n+ values (const unsigned int &active_tape_index,\n+ const unsigned int &n_dependent_variables,\n+ const unsigned int &n_independent_variables,\n+ const std::vector<ScalarType> &independent_variables,\n+ Vector<ScalarType> &values);\n+\n+ /**\n+ * Computes the gradient of the vector field.\n+ *\n+ * @param[in] active_tape_index The index of the tape on which the dependent\n+ * function is recorded.\n+ * @param[in] n_dependent_variables The number of dependent variables.\n+ * @param[in] n_independent_variables The number of independent variables\n+ * whose sensitivities were tracked.\n+ * @param[in] independent_variables The scalar values of the independent\n+ * variables whose sensitivities were tracked.\n+ * @param[out] jacobian The scalar values of the dependent function's jacobian.\n+ */\n+ static void\n+ jacobian (const unsigned int &active_tape_index,\n+ const unsigned int &n_dependent_variables,\n+ const unsigned int &n_independent_variables,\n+ const std::vector<ScalarType> &independent_variables,\n+ FullMatrix<ScalarType> &jacobian);\n+\n+ //@}\n+\n+ };\n+\n+\n+\n+ /**\n+ * A prototype driver class for tapeless auto-differentiable numbers.\n+ *\n+ * It is intended that this class be specialized for the valid\n+ * combinations of auto-differentiable numbers and output scalar\n+ * number types.\n+ *\n+ * @tparam ADNumberType A type corresponding to a supported\n+ * auto-differentiable number.\n+ * @tparam ScalarType A real or complex floating point number.\n+ * @tparam T An arbitrary type resulting from the application of\n+ * the SFINAE idiom to selectively specialize this class.\n+ *\n+ * @author Jean-Paul Pelteret, 2017\n+ */\n+ template<typename ADNumberType, typename ScalarType, typename T = void>\n+ struct TapelessDrivers\n+ {\n+ // This dummy class definition safely supports compilation\n+ // against taped numbers or tapeless number types that have\n+ // not yet been implemented.\n+\n+ /**\n+ * @name Drivers for scalar functions\n+ */\n+ //@{\n+\n+ /**\n+ * Computes the value of the scalar field.\n+ *\n+ * @param[in] dependent_variables The dependent variables whose values are to\n+ * be extracted.\n+ *\n+ * @return The scalar values of the function.\n+ */\n+ static ScalarType\n+ value (const std::vector<ADNumberType> &dependent_variables);\n+\n+ /**\n+ * Computes the gradient of the scalar field with respect to all independent\n+ * variables.\n+ *\n+ * @param[in] independent_variables The independent variables whose sensitivities\n+ * were tracked.\n+ * @param[in] dependent_variables The (single) dependent variable whose gradients\n+ * are to be extracted.\n+ * @param[out] gradient The scalar values of the dependent function's gradients.\n+ */\n+ static void\n+ gradient (const std::vector<ADNumberType> &independent_variables,\n+ const std::vector<ADNumberType> &dependent_variables,\n+ Vector<ScalarType> &gradient);\n+\n+ /**\n+ * Computes the hessian of the scalar field with respect to all independent\n+ * variables.\n+ *\n+ * @param[in] independent_variables The independent variables whose sensitivities\n+ * were tracked.\n+ * @param[in] dependent_variables The (single) dependent variable whose hessians\n+ * are to be extracted.\n+ * @param[out] hessian The scalar values of the function's hessian.\n+ */\n+ static void\n+ hessian (const std::vector<ADNumberType> &independent_variables,\n+ const std::vector<ADNumberType> &dependent_variables,\n+ FullMatrix<ScalarType> &hessian);\n+\n+ //@}\n+\n+ /**\n+ * @name Drivers for vector functions\n+ */\n+ //@{\n+\n+ /**\n+ * Computes the values of the vector field.\n+ *\n+ * @param[in] dependent_variables The dependent variables whose hessians\n+ * are to be extracted.\n+ * @param[out] values The scalar values of the dependent functions.\n+ */\n+ static void\n+ values (const std::vector<ADNumberType> &dependent_variables,\n+ Vector<ScalarType> &values);\n+\n+ /**\n+ * Computes the gradient of the vector field.\n+ *\n+ * @param[in] independent_variables The independent variables whose sensitivities\n+ * were tracked.\n+ * @param[in] dependent_variables The dependent variables whose jacobian\n+ * are to be extracted.\n+ * @param[out] jacobian The scalar values of the function's jacobian.\n+ */\n+ static void\n+ jacobian (const std::vector<ADNumberType> &independent_variables,\n+ const std::vector<ADNumberType> &dependent_variables,\n+ FullMatrix<ScalarType> &jacobian);\n+\n+ //@}\n+\n+ };\n+\n+ }\n+}\n+\n+\n+\n+/* --------------------------- inline and template functions ------------------------- */\n+\n+\n+#ifndef DOXYGEN\n+\n+namespace Differentiation\n+{\n+ namespace AD\n+ {\n+\n+ // ------------- TapedDrivers -------------\n+\n+\n+ template<typename ADNumberType, typename ScalarType, typename T>\n+ void\n+ TapedDrivers<ADNumberType,ScalarType,T>::enable_taping(\n+ const unsigned int &,\n+ const bool &)\n+ {\n+ AssertThrow(false, ExcNotImplemented());\n+ }\n+\n+\n+ template<typename ADNumberType, typename ScalarType, typename T>\n+ void\n+ TapedDrivers<ADNumberType,ScalarType,T>::disable_taping(\n+ const unsigned int &,\n+ const bool &)\n+ {\n+ AssertThrow(false, ExcNotImplemented());\n+ }\n+\n+\n+ template<typename ADNumberType, typename ScalarType, typename T>\n+ ScalarType\n+ TapedDrivers<ADNumberType,ScalarType,T>::value (\n+ const unsigned int &,\n+ const unsigned int &,\n+ const std::vector<ScalarType> &)\n+ {\n+ AssertThrow(false, ExcNotImplemented());\n+ return ScalarType(0.0);\n+ }\n+\n+\n+ template<typename ADNumberType, typename ScalarType, typename T>\n+ void\n+ TapedDrivers<ADNumberType,ScalarType,T>::gradient (\n+ const unsigned int &,\n+ const unsigned int &,\n+ const std::vector<ScalarType> &,\n+ Vector<ScalarType> &)\n+ {\n+ AssertThrow(false, ExcNotImplemented());\n+ }\n+\n+\n+ template<typename ADNumberType, typename ScalarType, typename T>\n+ void\n+ TapedDrivers<ADNumberType,ScalarType,T>::hessian (\n+ const unsigned int &,\n+ const unsigned int &,\n+ const std::vector<ScalarType> &,\n+ FullMatrix<ScalarType> &)\n+ {\n+ AssertThrow(false, ExcNotImplemented());\n+ }\n+\n+\n+ template<typename ADNumberType, typename ScalarType, typename T>\n+ void\n+ TapedDrivers<ADNumberType,ScalarType,T>::values (\n+ const unsigned int &,\n+ const unsigned int &,\n+ const unsigned int &,\n+ const std::vector<ScalarType> &,\n+ Vector<ScalarType> &)\n+ {\n+ AssertThrow(false, ExcNotImplemented());\n+ }\n+\n+\n+ template<typename ADNumberType, typename ScalarType, typename T>\n+ void\n+ TapedDrivers<ADNumberType,ScalarType,T>::jacobian (\n+ const unsigned int &,\n+ const unsigned int &,\n+ const unsigned int &,\n+ const std::vector<ScalarType> &,\n+ FullMatrix<ScalarType> &)\n+ {\n+ AssertThrow(false, ExcNotImplemented());\n+ }\n+\n+\n+ // Specialization for taped Adol-C auto-differentiable numbers.\n+ //\n+ // Note: In the case of Adol-C taped numbers, the associated scalar\n+ // type is always expected to be a double. So we need to make a further\n+ // specialization when ScalarType is a float.\n+ template<typename ADNumberType>\n+ struct TapedDrivers<ADNumberType,double,typename std::enable_if<\n+ ADNumberTraits<ADNumberType>::type_code == NumberTypes::adolc_taped\n+ >::type>\n+ {\n+ typedef double scalar_type;\n+\n+ // === Taping ===\n+\n+ static void\n+ enable_taping(const unsigned int &tape_index,\n+ const bool &keep)\n+ {\n+ trace_on(tape_index,keep);\n+ }\n+\n+ static void\n+ disable_taping(const unsigned int &active_tape_index,\n+ const bool &write_tapes_to_file)\n+ {\n+ if (write_tapes_to_file)\n+ {\n+ trace_off(active_tape_index); // Slow\n+\n+ std::vector<std::size_t> counts (STAT_SIZE);\n+#ifdef DEAL_II_WITH_ADOLC\n+ ::tapestats(active_tape_index, counts.data());\n+#else\n+ AssertThrow(false, ExcNotImplemented());\n+#endif\n+ }\n+ else\n+ trace_off(); // Fast(er)\n+ }\n+\n+ // === Scalar drivers ===\n+\n+ static scalar_type\n+ value (const unsigned int &active_tape_index,\n+ const unsigned int &n_independent_variables,\n+ const std::vector<scalar_type> &independent_variables)\n+ {\n+ Assert(independent_variables.size() == n_independent_variables,\n+ ExcDimensionMismatch(independent_variables.size(),n_independent_variables));\n+\n+ scalar_type value = 0.0;\n+\n+#ifdef DEAL_II_WITH_ADOLC\n+ ::function(active_tape_index,\n+ 1, // Only one dependent variable\n+ n_independent_variables,\n+ const_cast<double *>(independent_variables.data()),\n+ &value);\n+#else\n+ AssertThrow(false, ExcNotImplemented());\n+#endif\n+\n+ return value;\n+ }\n+\n+ static void\n+ gradient (const unsigned int &active_tape_index,\n+ const unsigned int &n_independent_variables,\n+ const std::vector<scalar_type> &independent_variables,\n+ Vector<scalar_type> &gradient)\n+ {\n+ Assert(independent_variables.size() == n_independent_variables,\n+ ExcDimensionMismatch(independent_variables.size(),n_independent_variables));\n+ Assert(gradient.size() == n_independent_variables,\n+ ExcMessage(\"The length of the gradient vector must be equal \"\n+ \"to the number of independent variables.\"));\n+\n+#ifdef DEAL_II_WITH_ADOLC\n+ // Note: Adol-C's ::gradient function expects a *double as the last\n+ // parameter. Here we take advantage of the fact that the data in the\n+ // Vector class is aligned (e.g. stored as an Array)\n+ ::gradient(active_tape_index,\n+ n_independent_variables,\n+ const_cast<scalar_type *>(independent_variables.data()),\n+ &gradient[0]);\n+#else\n+ AssertThrow(false, ExcNotImplemented());\n+#endif\n+\n+ }\n+\n+ static void\n+ hessian (const unsigned int &active_tape_index,\n+ const unsigned int &n_independent_variables,\n+ const std::vector<scalar_type> &independent_variables,\n+ FullMatrix<scalar_type> &hessian)\n+ {\n+ Assert(independent_variables.size() == n_independent_variables,\n+ ExcDimensionMismatch(independent_variables.size(),n_independent_variables));\n+ Assert(hessian.m() == n_independent_variables,\n+ ExcMessage(\"The (symmetric) hessian row length must be equal \"\n+ \"to the number of independent variables.\"));\n+ Assert(hessian.n() == n_independent_variables,\n+ ExcMessage(\"The (symmetric) hessian column length must be equal \"\n+ \"to the number of independent variables.\"));\n+\n+ scalar_type **H = new scalar_type*[n_independent_variables];\n+ for (unsigned int i=0; i<n_independent_variables; ++i)\n+ H[i] = new scalar_type[i+1]; // Symmetry\n+\n+#ifdef DEAL_II_WITH_ADOLC\n+ ::hessian(active_tape_index,\n+ n_independent_variables,\n+ const_cast<scalar_type *>(independent_variables.data()),\n+ H);\n+#else\n+ AssertThrow(false, ExcNotImplemented());\n+#endif\n+\n+ for (unsigned int i=0; i<n_independent_variables; i++)\n+ for (unsigned int j=0; j<i+1; j++)\n+ {\n+ hessian[i][j] = H[i][j];\n+ if (i != j)\n+ hessian[j][i] = H[i][j]; // Symmetry\n+ }\n+\n+ // Cleanup :-/\n+ for (unsigned int i=0; i<n_independent_variables; i++)\n+ delete[] H[i];\n+ delete[] H;\n+ H = nullptr;\n+ }\n+\n+ // === Vector drivers ===\n+\n+ static void\n+ values (const unsigned int &active_tape_index,\n+ const unsigned int &n_dependent_variables,\n+ const unsigned int &n_independent_variables,\n+ const std::vector<scalar_type> &independent_variables,\n+ Vector<scalar_type> &values)\n+ {\n+ Assert(independent_variables.size() == n_independent_variables,\n+ ExcDimensionMismatch(independent_variables.size(),n_independent_variables));\n+ Assert(values.size() == n_dependent_variables,\n+ ExcMessage(\"The length of the dependent function vector must \"\n+ \" be equal to the number of dependent variables.\"));\n+\n+#ifdef DEAL_II_WITH_ADOLC\n+ // Note: Adol-C's ::function function expects a *double as the last\n+ // parameter. Here we take advantage of the fact that the data in the\n+ // Vector class is aligned (e.g. stored as an Array)\n+ ::function(active_tape_index,\n+ n_dependent_variables,\n+ n_independent_variables,\n+ const_cast<scalar_type *>(independent_variables.data()),\n+ &values[0]);\n+#else\n+ AssertThrow(false, ExcNotImplemented());\n+#endif\n+\n+ }\n+\n+ static void\n+ jacobian (const unsigned int &active_tape_index,\n+ const unsigned int &n_dependent_variables,\n+ const unsigned int &n_independent_variables,\n+ const std::vector<scalar_type> &independent_variables,\n+ FullMatrix<scalar_type> &jacobian)\n+ {\n+ Assert(independent_variables.size() == n_independent_variables,\n+ ExcDimensionMismatch(independent_variables.size(),n_independent_variables));\n+ Assert(jacobian.m() == n_dependent_variables,\n+ ExcMessage(\"The jacobian row length must be equal \"\n+ \"to the number of dependent variables.\"));\n+ Assert(jacobian.n() == n_independent_variables,\n+ ExcMessage(\"The hessian column length must be equal \"\n+ \"to the number of independent variables.\"));\n+\n+ scalar_type **J = new scalar_type*[n_dependent_variables];\n+ for (unsigned int i=0; i<n_dependent_variables; ++i)\n+ J[i] = new scalar_type[n_independent_variables];","path":"include/deal.II/differentiation/ad/ad_drivers.h","position":595,"original_position":595,"commit_id":"8afab24994db8030d6053939c811ed68ace1bbf0","original_commit_id":"8afab24994db8030d6053939c811ed68ace1bbf0","user":{"login":"davydden","id":8023934,"avatar_url":"https://avatars2.githubusercontent.com/u/8023934?v=4","gravatar_id":"","url":"https://api.github.com/users/davydden","html_url":"https://github.com/davydden","followers_url":"https://api.github.com/users/davydden/followers","following_url":"https://api.github.com/users/davydden/following{/other_user}","gists_url":"https://api.github.com/users/davydden/gists{/gist_id}","starred_url":"https://api.github.com/users/davydden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davydden/subscriptions","organizations_url":"https://api.github.com/users/davydden/orgs","repos_url":"https://api.github.com/users/davydden/repos","events_url":"https://api.github.com/users/davydden/events{/privacy}","received_events_url":"https://api.github.com/users/davydden/received_events","type":"User","site_admin":false},"body":"i mean `J[i] = &jacobian(i,0)` should work. `FullMatrix` is row-major so this should be equivalent to what you do here.","created_at":"2017-11-18T18:36:47Z","updated_at":"2017-11-18T18:36:47Z","html_url":"https://github.com/dealii/dealii/pull/5499#discussion_r151843896","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/5499","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/151843896"},"html":{"href":"https://github.com/dealii/dealii/pull/5499#discussion_r151843896"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/5499"}},"in_reply_to_id":151843769},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/5499","id":153446992,"html_url":"https://github.com/dealii/dealii/pull/5499","diff_url":"https://github.com/dealii/dealii/pull/5499.diff","patch_url":"https://github.com/dealii/dealii/pull/5499.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/5499","number":5499,"state":"open","locked":false,"title":"Implement driver interface for internally supported AD libraries.","user":{"login":"jppelteret","id":10460610,"avatar_url":"https://avatars0.githubusercontent.com/u/10460610?v=4","gravatar_id":"","url":"https://api.github.com/users/jppelteret","html_url":"https://github.com/jppelteret","followers_url":"https://api.github.com/users/jppelteret/followers","following_url":"https://api.github.com/users/jppelteret/following{/other_user}","gists_url":"https://api.github.com/users/jppelteret/gists{/gist_id}","starred_url":"https://api.github.com/users/jppelteret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jppelteret/subscriptions","organizations_url":"https://api.github.com/users/jppelteret/orgs","repos_url":"https://api.github.com/users/jppelteret/repos","events_url":"https://api.github.com/users/jppelteret/events{/privacy}","received_events_url":"https://api.github.com/users/jppelteret/received_events","type":"User","site_admin":false},"body":"This commit adds classes that act as an interface to the drivers of internally supported automatic\r\ndifferentiation libraries (Adol-C and Sacado). \r\n\r\nIn a quest to simplify the road to full integration of AD into our library, I have stripped the core of the functions required to interact this these libraries from the (to be submitted) helper functions. As a result, this is, effectively, the last major commit that requires knowledge of the inner mechanics of these libraries. These classes supplement and leverage the existing `Marking` and `ExtractData` classes where possible. Although there's no context for the use of these drivers yet, one may refer to the \"basic\" Adol-C and Sacado test cases that I added previously to see how they're used.\r\n\r\nAs an added bonus, with this addition I think that I have completely (or nearly completely) abstracted and safely defaulted the AD-related functions and classes. So it should be possible to move from the current situation where the selection of a `type_code` that references a library that deal.II is not built against results in a compiler error, to one that presents only a run-time error of sorts :-)","created_at":"2017-11-18T11:47:11Z","updated_at":"2017-11-18T18:36:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2dcfcbac194e3f3e4877e49caf6d4935f310c07d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/5499/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/5499/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/5499/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/8afab24994db8030d6053939c811ed68ace1bbf0","head":{"label":"jppelteret:ad-drivers","ref":"ad-drivers","sha":"8afab24994db8030d6053939c811ed68ace1bbf0","user":{"login":"jppelteret","id":10460610,"avatar_url":"https://avatars0.githubusercontent.com/u/10460610?v=4","gravatar_id":"","url":"https://api.github.com/users/jppelteret","html_url":"https://github.com/jppelteret","followers_url":"https://api.github.com/users/jppelteret/followers","following_url":"https://api.github.com/users/jppelteret/following{/other_user}","gists_url":"https://api.github.com/users/jppelteret/gists{/gist_id}","starred_url":"https://api.github.com/users/jppelteret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jppelteret/subscriptions","organizations_url":"https://api.github.com/users/jppelteret/orgs","repos_url":"https://api.github.com/users/jppelteret/repos","events_url":"https://api.github.com/users/jppelteret/events{/privacy}","received_events_url":"https://api.github.com/users/jppelteret/received_events","type":"User","site_admin":false},"repo":{"id":40106037,"name":"dealii","full_name":"jppelteret/dealii","owner":{"login":"jppelteret","id":10460610,"avatar_url":"https://avatars0.githubusercontent.com/u/10460610?v=4","gravatar_id":"","url":"https://api.github.com/users/jppelteret","html_url":"https://github.com/jppelteret","followers_url":"https://api.github.com/users/jppelteret/followers","following_url":"https://api.github.com/users/jppelteret/following{/other_user}","gists_url":"https://api.github.com/users/jppelteret/gists{/gist_id}","starred_url":"https://api.github.com/users/jppelteret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jppelteret/subscriptions","organizations_url":"https://api.github.com/users/jppelteret/orgs","repos_url":"https://api.github.com/users/jppelteret/repos","events_url":"https://api.github.com/users/jppelteret/events{/privacy}","received_events_url":"https://api.github.com/users/jppelteret/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jppelteret/dealii","description":"The development repository for the deal.II finite element library.","fork":true,"url":"https://api.github.com/repos/jppelteret/dealii","forks_url":"https://api.github.com/repos/jppelteret/dealii/forks","keys_url":"https://api.github.com/repos/jppelteret/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jppelteret/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jppelteret/dealii/teams","hooks_url":"https://api.github.com/repos/jppelteret/dealii/hooks","issue_events_url":"https://api.github.com/repos/jppelteret/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/jppelteret/dealii/events","assignees_url":"https://api.github.com/repos/jppelteret/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/jppelteret/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/jppelteret/dealii/tags","blobs_url":"https://api.github.com/repos/jppelteret/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jppelteret/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jppelteret/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/jppelteret/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jppelteret/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/jppelteret/dealii/languages","stargazers_url":"https://api.github.com/repos/jppelteret/dealii/stargazers","contributors_url":"https://api.github.com/repos/jppelteret/dealii/contributors","subscribers_url":"https://api.github.com/repos/jppelteret/dealii/subscribers","subscription_url":"https://api.github.com/repos/jppelteret/dealii/subscription","commits_url":"https://api.github.com/repos/jppelteret/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/jppelteret/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/jppelteret/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/jppelteret/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/jppelteret/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/jppelteret/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jppelteret/dealii/merges","archive_url":"https://api.github.com/repos/jppelteret/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jppelteret/dealii/downloads","issues_url":"https://api.github.com/repos/jppelteret/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/jppelteret/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/jppelteret/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/jppelteret/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jppelteret/dealii/labels{/name}","releases_url":"https://api.github.com/repos/jppelteret/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/jppelteret/dealii/deployments","created_at":"2015-08-03T05:08:52Z","updated_at":"2016-01-11T06:42:34Z","pushed_at":"2017-11-18T18:19:58Z","git_url":"git://github.com/jppelteret/dealii.git","ssh_url":"[email protected]:jppelteret/dealii.git","clone_url":"https://github.com/jppelteret/dealii.git","svn_url":"https://github.com/jppelteret/dealii","homepage":"http://www.dealii.org/","size":172806,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"7aa749c75572b2e5210c0d4e579fe37b1283aaa7","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars3.githubusercontent.com/u/7506070?v=4","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars3.githubusercontent.com/u/7506070?v=4","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/dealii/dealii/deployments","created_at":"2014-07-17T14:00:26Z","updated_at":"2017-11-17T00:54:28Z","pushed_at":"2017-11-18T18:20:01Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"[email protected]:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":172893,"stargazers_count":274,"watchers_count":274,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":259,"mirror_url":null,"archived":false,"open_issues_count":233,"forks":259,"open_issues":233,"watchers":274,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/5499"},"html":{"href":"https://github.com/dealii/dealii/pull/5499"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/5499"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/5499/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/5499/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/5499/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/8afab24994db8030d6053939c811ed68ace1bbf0"}},"author_association":"MEMBER"}} | {
"id": 21943980,
"name": "dealii/dealii",
"url": "https://api.github.com/repos/dealii/dealii"
} | {
"id": 8023934,
"login": "davydden",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8023934?",
"url": "https://api.github.com/users/davydden"
} | {
"id": 7506070,
"login": "dealii",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7506070?",
"url": "https://api.github.com/orgs/dealii"
} | 2017-11-18T18:36:47 | 6874072442 | {"actor":{"display_login":"davydden"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/106843035","pull_request_review_id":27782826,"id":106843035,"diff_hunk":"@@ -3621,82 +3623,70 @@ namespace\n * Boundary<dim,spacedim>.\n */\n template <int dim, int spacedim, class TriaIterator>\n- void get_intermediate_points_on_object(const Manifold<dim, spacedim> &manifold,\n- const QGaussLobatto<1> &line_support_points,\n- const TriaIterator &iter,\n- std::vector<Point<spacedim> > &points)\n+ void add_intermediate_points(const Manifold<dim, spacedim> &manifold,\n+ const Table<2,double> &weight_table,\n+ const TriaIterator &iter,\n+ std::vector<Point<spacedim> > &points)\n {\n const unsigned int structdim = TriaIterator::AccessorType::structure_dimension;\n \n // Try backward compatibility option.\n- if (const Boundary<dim,spacedim> *boundary\n- = dynamic_cast<const Boundary<dim,spacedim> *>(&manifold))\n+ const Boundary<dim,spacedim> *boundary\n+ = dynamic_cast<const Boundary<dim,spacedim> *>(&manifold);\n+ if (structdim < spacedim && boundary != NULL)\n // This is actually a boundary. Call old methods.\n {\n+ std::vector<Point<spacedim> > new_points(weight_table.size(0));\n switch (structdim)\n {\n case 1:\n {\n const typename Triangulation<dim,spacedim>::line_iterator line = iter;\n- boundary->get_intermediate_points_on_line(line, points);\n- return;\n+ boundary->get_intermediate_points_on_line(line, new_points);\n+ break;\n }\n case 2:\n {\n const typename Triangulation<dim,spacedim>::quad_iterator quad = iter;\n- boundary->get_intermediate_points_on_quad(quad, points);\n- return;\n+ boundary->get_intermediate_points_on_quad(quad, new_points);\n+ break;\n }\n default:\n Assert(false, ExcInternalError());\n- return;\n+ break;\n }\n+ for (unsigned int i=0; i<new_points.size(); ++i)\n+ points.push_back(new_points[i]);\n }\n else\n {\n std::vector<Point<spacedim> > sp(GeometryInfo<structdim>::vertices_per_cell);\n for (unsigned int i=0; i<sp.size(); ++i)\n sp[i] = iter->vertex(i);\n- get_intermediate_points(manifold, line_support_points, sp, points);\n+ manifold.add_new_points(sp, weight_table, points);\n }\n }\n \n \n- /**\n- * Take a <tt>support_point_weights_on_hex(quad)</tt> and apply it to the vector\n- * @p a to compute the inner support points as a linear combination of the\n- * exterior points.\n- *\n- * The vector @p a initially contains the locations of the @p n_outer\n- * points, the @p n_inner computed inner points are appended.\n- *\n- * See equation (7) of the `mapping' report.\n- */\n- template <int spacedim>\n- void add_weighted_interior_points(const Table<2,double> &lvs,\n- std::vector<Point<spacedim> > &a)\n+\n+ template <typename Iterator>\n+ bool check_identical_manifolds_of_quads(const Iterator &)\n {\n- const unsigned int n_inner_apply=lvs.n_rows();\n- const unsigned int n_outer_apply=lvs.n_cols();\n- Assert(a.size()==n_outer_apply,\n- ExcDimensionMismatch(a.size(), n_outer_apply));\n-\n- // compute each inner point as linear combination of the outer points. the\n- // weights are given by the lvs entries, the outer points are the first\n- // (existing) elements of a\n- for (unsigned int unit_point=0; unit_point<n_inner_apply; ++unit_point)\n- {\n- Assert(lvs.n_cols()==n_outer_apply, ExcInternalError());\n- Point<spacedim> p;\n- for (unsigned int k=0; k<n_outer_apply; ++k)\n- p+=lvs[unit_point][k]*a[k];\n+ Assert(false, ExcNotImplemented());\n+ return true;\n+ }\n \n- a.push_back(p);\n- }\n+ bool check_identical_manifolds_of_quads(const Triangulation<3,3>::cell_iterator &cell)\n+ {\n+ for (unsigned int f=0; f<GeometryInfo<3>::faces_per_cell; ++f)\n+ if (&cell->face(f)->get_manifold() != &cell->get_manifold())\n+ return false;\n+ return true;","path":"source/fe/mapping_q_generic.cc","position":433,"original_position":433,"commit_id":"3b105b7e6d40fab8c6e82a4712c53f12d0bf8a39","original_commit_id":"3b105b7e6d40fab8c6e82a4712c53f12d0bf8a39","user":{"login":"kronbichler","id":8276200,"avatar_url":"https://avatars3.githubusercontent.com/u/8276200?v=3","gravatar_id":"","url":"https://api.github.com/users/kronbichler","html_url":"https://github.com/kronbichler","followers_url":"https://api.github.com/users/kronbichler/followers","following_url":"https://api.github.com/users/kronbichler/following{/other_user}","gists_url":"https://api.github.com/users/kronbichler/gists{/gist_id}","starred_url":"https://api.github.com/users/kronbichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronbichler/subscriptions","organizations_url":"https://api.github.com/users/kronbichler/orgs","repos_url":"https://api.github.com/users/kronbichler/repos","events_url":"https://api.github.com/users/kronbichler/events{/privacy}","received_events_url":"https://api.github.com/users/kronbichler/received_events","type":"User","site_admin":false},"body":"The problem is that I can't call `get_manifold` on all iterators (like the ones for the vertices), therefore I needed to get a special case for 3D. I will add a comment.","created_at":"2017-03-20T07:18:57Z","updated_at":"2017-03-20T07:18:57Z","html_url":"https://github.com/dealii/dealii/pull/3886#discussion_r106843035","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/3886","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/106843035"},"html":{"href":"https://github.com/dealii/dealii/pull/3886#discussion_r106843035"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/3886"}}},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/3886","id":103990914,"html_url":"https://github.com/dealii/dealii/pull/3886","diff_url":"https://github.com/dealii/dealii/pull/3886.diff","patch_url":"https://github.com/dealii/dealii/pull/3886.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/3886","number":3886,"state":"open","locked":false,"title":"Fix support points on quad for MappingQGeneric and StraightBoundary.","user":{"login":"kronbichler","id":8276200,"avatar_url":"https://avatars3.githubusercontent.com/u/8276200?v=3","gravatar_id":"","url":"https://api.github.com/users/kronbichler","html_url":"https://github.com/kronbichler","followers_url":"https://api.github.com/users/kronbichler/followers","following_url":"https://api.github.com/users/kronbichler/following{/other_user}","gists_url":"https://api.github.com/users/kronbichler/gists{/gist_id}","starred_url":"https://api.github.com/users/kronbichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronbichler/subscriptions","organizations_url":"https://api.github.com/users/kronbichler/orgs","repos_url":"https://api.github.com/users/kronbichler/repos","events_url":"https://api.github.com/users/kronbichler/events{/privacy}","received_events_url":"https://api.github.com/users/kronbichler/received_events","type":"User","site_admin":false},"body":"When using `MappingQGeneric` on a grid that has been created by extrusion of a 2D mesh, the mapping support points on quads were previously always computed through the manifold. This is inconsistent to the support points on cells that only get computed through the manifold if the cast to `Boundary` returns `NULL`, i.e., it is a manifold not derived from the old boundary classes and in particular, not a straight boundary. In the else case, we should compute the interior points as an interpolation of the surrounding points (i.e., the 4 vertices and all points on the lines).\r\n\r\nWhile the mesh was perfectly fine in 2D, I got inverted cells for mapping degree 5 of the attached test case in 3D. Interestingly, the inversion only happened on the surface of the elements (quads), not in the inside where the `add_weighted_interior_points` method does something reasonable (even though two of the faces have bad points):\r\n\r\n\r\nWith the patch, the cells look as expected:\r\n\r\n\r\nThis is also the mesh I get in 2D. The test results compute the volume of the object and did run into an exception of a negative Jacobian determinant without this patch.","created_at":"2017-01-31T18:06:38Z","updated_at":"2017-03-20T07:18:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f84883bf3d144d87f01e99757a72357024de6670","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dealii/dealii/milestones/3","html_url":"https://github.com/dealii/dealii/milestone/3","labels_url":"https://api.github.com/repos/dealii/dealii/milestones/3/labels","id":1469496,"number":3,"title":"Release 8.5","description":null,"creator":{"login":"kronbichler","id":8276200,"avatar_url":"https://avatars3.githubusercontent.com/u/8276200?v=3","gravatar_id":"","url":"https://api.github.com/users/kronbichler","html_url":"https://github.com/kronbichler","followers_url":"https://api.github.com/users/kronbichler/followers","following_url":"https://api.github.com/users/kronbichler/following{/other_user}","gists_url":"https://api.github.com/users/kronbichler/gists{/gist_id}","starred_url":"https://api.github.com/users/kronbichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronbichler/subscriptions","organizations_url":"https://api.github.com/users/kronbichler/orgs","repos_url":"https://api.github.com/users/kronbichler/repos","events_url":"https://api.github.com/users/kronbichler/events{/privacy}","received_events_url":"https://api.github.com/users/kronbichler/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":70,"state":"open","created_at":"2015-12-21T12:40:53Z","updated_at":"2017-03-10T07:09:59Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/3886/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/3886/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/3886/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/3b105b7e6d40fab8c6e82a4712c53f12d0bf8a39","head":{"label":"kronbichler:master","ref":"master","sha":"3b105b7e6d40fab8c6e82a4712c53f12d0bf8a39","user":{"login":"kronbichler","id":8276200,"avatar_url":"https://avatars3.githubusercontent.com/u/8276200?v=3","gravatar_id":"","url":"https://api.github.com/users/kronbichler","html_url":"https://github.com/kronbichler","followers_url":"https://api.github.com/users/kronbichler/followers","following_url":"https://api.github.com/users/kronbichler/following{/other_user}","gists_url":"https://api.github.com/users/kronbichler/gists{/gist_id}","starred_url":"https://api.github.com/users/kronbichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronbichler/subscriptions","organizations_url":"https://api.github.com/users/kronbichler/orgs","repos_url":"https://api.github.com/users/kronbichler/repos","events_url":"https://api.github.com/users/kronbichler/events{/privacy}","received_events_url":"https://api.github.com/users/kronbichler/received_events","type":"User","site_admin":false},"repo":{"id":22549298,"name":"dealii","full_name":"kronbichler/dealii","owner":{"login":"kronbichler","id":8276200,"avatar_url":"https://avatars3.githubusercontent.com/u/8276200?v=3","gravatar_id":"","url":"https://api.github.com/users/kronbichler","html_url":"https://github.com/kronbichler","followers_url":"https://api.github.com/users/kronbichler/followers","following_url":"https://api.github.com/users/kronbichler/following{/other_user}","gists_url":"https://api.github.com/users/kronbichler/gists{/gist_id}","starred_url":"https://api.github.com/users/kronbichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronbichler/subscriptions","organizations_url":"https://api.github.com/users/kronbichler/orgs","repos_url":"https://api.github.com/users/kronbichler/repos","events_url":"https://api.github.com/users/kronbichler/events{/privacy}","received_events_url":"https://api.github.com/users/kronbichler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kronbichler/dealii","description":"The development repository for the deal.II finite element library.","fork":true,"url":"https://api.github.com/repos/kronbichler/dealii","forks_url":"https://api.github.com/repos/kronbichler/dealii/forks","keys_url":"https://api.github.com/repos/kronbichler/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kronbichler/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kronbichler/dealii/teams","hooks_url":"https://api.github.com/repos/kronbichler/dealii/hooks","issue_events_url":"https://api.github.com/repos/kronbichler/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/kronbichler/dealii/events","assignees_url":"https://api.github.com/repos/kronbichler/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/kronbichler/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/kronbichler/dealii/tags","blobs_url":"https://api.github.com/repos/kronbichler/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kronbichler/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kronbichler/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/kronbichler/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kronbichler/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/kronbichler/dealii/languages","stargazers_url":"https://api.github.com/repos/kronbichler/dealii/stargazers","contributors_url":"https://api.github.com/repos/kronbichler/dealii/contributors","subscribers_url":"https://api.github.com/repos/kronbichler/dealii/subscribers","subscription_url":"https://api.github.com/repos/kronbichler/dealii/subscription","commits_url":"https://api.github.com/repos/kronbichler/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/kronbichler/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/kronbichler/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/kronbichler/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/kronbichler/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/kronbichler/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kronbichler/dealii/merges","archive_url":"https://api.github.com/repos/kronbichler/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kronbichler/dealii/downloads","issues_url":"https://api.github.com/repos/kronbichler/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/kronbichler/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/kronbichler/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/kronbichler/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kronbichler/dealii/labels{/name}","releases_url":"https://api.github.com/repos/kronbichler/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/kronbichler/dealii/deployments","created_at":"2014-08-02T15:52:43Z","updated_at":"2016-01-11T13:12:43Z","pushed_at":"2017-03-19T09:17:53Z","git_url":"git://github.com/kronbichler/dealii.git","ssh_url":"[email protected]:kronbichler/dealii.git","clone_url":"https://github.com/kronbichler/dealii.git","svn_url":"https://github.com/kronbichler/dealii","homepage":"http://www.dealii.org/","size":155881,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"46e524936bed3f545e2ce4f2366b6dbfaa725a93","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars0.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars0.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/dealii/dealii/deployments","created_at":"2014-07-17T14:00:26Z","updated_at":"2017-03-20T05:37:24Z","pushed_at":"2017-03-19T21:39:26Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"[email protected]:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":156078,"stargazers_count":212,"watchers_count":212,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":211,"mirror_url":null,"open_issues_count":188,"forks":211,"open_issues":188,"watchers":212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/3886"},"html":{"href":"https://github.com/dealii/dealii/pull/3886"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/3886"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/3886/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/3886/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/3886/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/3b105b7e6d40fab8c6e82a4712c53f12d0bf8a39"}}}} | {
"id": 21943980,
"name": "dealii/dealii",
"url": "https://api.github.com/repos/dealii/dealii"
} | {
"id": 8276200,
"login": "kronbichler",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8276200?",
"url": "https://api.github.com/users/kronbichler"
} | {
"id": 7506070,
"login": "dealii",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7506070?",
"url": "https://api.github.com/orgs/dealii"
} | 2017-03-20T07:18:57 | 5523543784 | {"actor":{"display_login":"kronbichler"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/137484893","pull_request_review_id":61156722,"id":137484893,"diff_hunk":"@@ -0,0 +1,284 @@\n+from collections import defaultdict, OrderedDict\n+\n+from datetime import datetime\n+\n+from dateutil.relativedelta import relativedelta\n+from dateutil.rrule import rrule, MONTHLY\n+\n+from django.db.models.aggregates import Sum\n+from django.utils.translation import ugettext as _\n+\n+from custom.icds_reports.const import LocationTypes\n+from custom.icds_reports.models import AggCcsRecordMonthly\n+from custom.icds_reports.utils import apply_exclude\n+\n+\n+RED = '#de2d26'\n+ORANGE = '#fc9272'\n+BLUE = '#006fdf'\n+PINK = '#fee0d2'\n+GREY = '#9D9D9D'\n+\n+\n+\n+def get_institutional_deliveries_sector_data(domain, config, loc_level, show_test=False):","path":"custom/icds_reports/reports/institutional_deliveries_sector.py","position":24,"original_position":24,"commit_id":"23bef730b6b11170c2942931abaca1ca37376eff","original_commit_id":"23bef730b6b11170c2942931abaca1ca37376eff","user":{"login":"stickler-ci","id":16011037,"avatar_url":"https://avatars3.githubusercontent.com/u/16011037?v=4","gravatar_id":"","url":"https://api.github.com/users/stickler-ci","html_url":"https://github.com/stickler-ci","followers_url":"https://api.github.com/users/stickler-ci/followers","following_url":"https://api.github.com/users/stickler-ci/following{/other_user}","gists_url":"https://api.github.com/users/stickler-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/stickler-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stickler-ci/subscriptions","organizations_url":"https://api.github.com/users/stickler-ci/orgs","repos_url":"https://api.github.com/users/stickler-ci/repos","events_url":"https://api.github.com/users/stickler-ci/events{/privacy}","received_events_url":"https://api.github.com/users/stickler-ci/received_events","type":"User","site_admin":false},"body":"E303 too many blank lines (3)","created_at":"2017-09-07T09:06:30Z","updated_at":"2017-09-07T09:06:30Z","html_url":"https://github.com/dimagi/commcare-hq/pull/17735#discussion_r137484893","pull_request_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/17735","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/137484893"},"html":{"href":"https://github.com/dimagi/commcare-hq/pull/17735#discussion_r137484893"},"pull_request":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/17735"}}},"pull_request":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/17735","id":139752134,"html_url":"https://github.com/dimagi/commcare-hq/pull/17735","diff_url":"https://github.com/dimagi/commcare-hq/pull/17735.diff","patch_url":"https://github.com/dimagi/commcare-hq/pull/17735.patch","issue_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/17735","number":17735,"state":"open","locked":false,"title":"Moved report data functions into separate files","user":{"login":"kkrampa","id":5538370,"avatar_url":"https://avatars0.githubusercontent.com/u/5538370?v=4","gravatar_id":"","url":"https://api.github.com/users/kkrampa","html_url":"https://github.com/kkrampa","followers_url":"https://api.github.com/users/kkrampa/followers","following_url":"https://api.github.com/users/kkrampa/following{/other_user}","gists_url":"https://api.github.com/users/kkrampa/gists{/gist_id}","starred_url":"https://api.github.com/users/kkrampa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkrampa/subscriptions","organizations_url":"https://api.github.com/users/kkrampa/orgs","repos_url":"https://api.github.com/users/kkrampa/repos","events_url":"https://api.github.com/users/kkrampa/events{/privacy}","received_events_url":"https://api.github.com/users/kkrampa/received_events","type":"User","site_admin":false},"body":"@emord I moved all report data functions into separate files. I don't think ```utils.py``` was best place to keep main report logic","created_at":"2017-09-07T09:05:41Z","updated_at":"2017-09-07T09:06:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dd23dfa5e332478ccd42f0a35417abc12ecce20","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/17735/commits","review_comments_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/17735/comments","review_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/17735/comments","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/23bef730b6b11170c2942931abaca1ca37376eff","head":{"label":"lwyszomi:kk/icds-refactor","ref":"kk/icds-refactor","sha":"23bef730b6b11170c2942931abaca1ca37376eff","user":{"login":"lwyszomi","id":429541,"avatar_url":"https://avatars1.githubusercontent.com/u/429541?v=4","gravatar_id":"","url":"https://api.github.com/users/lwyszomi","html_url":"https://github.com/lwyszomi","followers_url":"https://api.github.com/users/lwyszomi/followers","following_url":"https://api.github.com/users/lwyszomi/following{/other_user}","gists_url":"https://api.github.com/users/lwyszomi/gists{/gist_id}","starred_url":"https://api.github.com/users/lwyszomi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwyszomi/subscriptions","organizations_url":"https://api.github.com/users/lwyszomi/orgs","repos_url":"https://api.github.com/users/lwyszomi/repos","events_url":"https://api.github.com/users/lwyszomi/events{/privacy}","received_events_url":"https://api.github.com/users/lwyszomi/received_events","type":"User","site_admin":false},"repo":{"id":12557346,"name":"commcare-hq","full_name":"lwyszomi/commcare-hq","owner":{"login":"lwyszomi","id":429541,"avatar_url":"https://avatars1.githubusercontent.com/u/429541?v=4","gravatar_id":"","url":"https://api.github.com/users/lwyszomi","html_url":"https://github.com/lwyszomi","followers_url":"https://api.github.com/users/lwyszomi/followers","following_url":"https://api.github.com/users/lwyszomi/following{/other_user}","gists_url":"https://api.github.com/users/lwyszomi/gists{/gist_id}","starred_url":"https://api.github.com/users/lwyszomi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwyszomi/subscriptions","organizations_url":"https://api.github.com/users/lwyszomi/orgs","repos_url":"https://api.github.com/users/lwyszomi/repos","events_url":"https://api.github.com/users/lwyszomi/events{/privacy}","received_events_url":"https://api.github.com/users/lwyszomi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lwyszomi/commcare-hq","description":"A server-side tool to help manage community health workers, written in Django","fork":true,"url":"https://api.github.com/repos/lwyszomi/commcare-hq","forks_url":"https://api.github.com/repos/lwyszomi/commcare-hq/forks","keys_url":"https://api.github.com/repos/lwyszomi/commcare-hq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lwyszomi/commcare-hq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lwyszomi/commcare-hq/teams","hooks_url":"https://api.github.com/repos/lwyszomi/commcare-hq/hooks","issue_events_url":"https://api.github.com/repos/lwyszomi/commcare-hq/issues/events{/number}","events_url":"https://api.github.com/repos/lwyszomi/commcare-hq/events","assignees_url":"https://api.github.com/repos/lwyszomi/commcare-hq/assignees{/user}","branches_url":"https://api.github.com/repos/lwyszomi/commcare-hq/branches{/branch}","tags_url":"https://api.github.com/repos/lwyszomi/commcare-hq/tags","blobs_url":"https://api.github.com/repos/lwyszomi/commcare-hq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lwyszomi/commcare-hq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lwyszomi/commcare-hq/git/refs{/sha}","trees_url":"https://api.github.com/repos/lwyszomi/commcare-hq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lwyszomi/commcare-hq/statuses/{sha}","languages_url":"https://api.github.com/repos/lwyszomi/commcare-hq/languages","stargazers_url":"https://api.github.com/repos/lwyszomi/commcare-hq/stargazers","contributors_url":"https://api.github.com/repos/lwyszomi/commcare-hq/contributors","subscribers_url":"https://api.github.com/repos/lwyszomi/commcare-hq/subscribers","subscription_url":"https://api.github.com/repos/lwyszomi/commcare-hq/subscription","commits_url":"https://api.github.com/repos/lwyszomi/commcare-hq/commits{/sha}","git_commits_url":"https://api.github.com/repos/lwyszomi/commcare-hq/git/commits{/sha}","comments_url":"https://api.github.com/repos/lwyszomi/commcare-hq/comments{/number}","issue_comment_url":"https://api.github.com/repos/lwyszomi/commcare-hq/issues/comments{/number}","contents_url":"https://api.github.com/repos/lwyszomi/commcare-hq/contents/{+path}","compare_url":"https://api.github.com/repos/lwyszomi/commcare-hq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lwyszomi/commcare-hq/merges","archive_url":"https://api.github.com/repos/lwyszomi/commcare-hq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lwyszomi/commcare-hq/downloads","issues_url":"https://api.github.com/repos/lwyszomi/commcare-hq/issues{/number}","pulls_url":"https://api.github.com/repos/lwyszomi/commcare-hq/pulls{/number}","milestones_url":"https://api.github.com/repos/lwyszomi/commcare-hq/milestones{/number}","notifications_url":"https://api.github.com/repos/lwyszomi/commcare-hq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lwyszomi/commcare-hq/labels{/name}","releases_url":"https://api.github.com/repos/lwyszomi/commcare-hq/releases{/id}","deployments_url":"https://api.github.com/repos/lwyszomi/commcare-hq/deployments","created_at":"2013-09-03T07:05:35Z","updated_at":"2015-03-13T12:55:20Z","pushed_at":"2017-09-07T09:02:08Z","git_url":"git://github.com/lwyszomi/commcare-hq.git","ssh_url":"[email protected]:lwyszomi/commcare-hq.git","clone_url":"https://github.com/lwyszomi/commcare-hq.git","svn_url":"https://github.com/lwyszomi/commcare-hq","homepage":"http://www.commcarehq.org","size":327152,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dimagi:master","ref":"master","sha":"ea9d96a31d8fd2dd85655edec20562a8789cecfc","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":247278,"name":"commcare-hq","full_name":"dimagi/commcare-hq","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/commcare-hq","description":"A server-side tool to help manage community health workers, written in Django","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-hq","forks_url":"https://api.github.com/repos/dimagi/commcare-hq/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-hq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-hq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-hq/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-hq/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-hq/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-hq/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-hq/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-hq/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-hq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-hq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-hq/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-hq/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-hq/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-hq/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-hq/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-hq/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-hq/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-hq/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-hq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-hq/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-hq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-hq/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-hq/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-hq/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-hq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-hq/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-hq/deployments","created_at":"2009-07-09T17:00:07Z","updated_at":"2017-08-26T09:47:50Z","pushed_at":"2017-09-07T09:05:42Z","git_url":"git://github.com/dimagi/commcare-hq.git","ssh_url":"[email protected]:dimagi/commcare-hq.git","clone_url":"https://github.com/dimagi/commcare-hq.git","svn_url":"https://github.com/dimagi/commcare-hq","homepage":"https://www.commcarehq.org","size":421309,"stargazers_count":79,"watchers_count":79,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":93,"mirror_url":null,"open_issues_count":58,"forks":93,"open_issues":58,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/17735"},"html":{"href":"https://github.com/dimagi/commcare-hq/pull/17735"},"issue":{"href":"https://api.github.com/repos/dimagi/commcare-hq/issues/17735"},"comments":{"href":"https://api.github.com/repos/dimagi/commcare-hq/issues/17735/comments"},"review_comments":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/17735/comments"},"review_comment":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/17735/commits"},"statuses":{"href":"https://api.github.com/repos/dimagi/commcare-hq/statuses/23bef730b6b11170c2942931abaca1ca37376eff"}},"author_association":"MEMBER"}} | {
"id": 247278,
"name": "dimagi/commcare-hq",
"url": "https://api.github.com/repos/dimagi/commcare-hq"
} | {
"id": 16011037,
"login": "stickler-ci",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16011037?",
"url": "https://api.github.com/users/stickler-ci"
} | {
"id": 94514,
"login": "dimagi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/94514?",
"url": "https://api.github.com/orgs/dimagi"
} | 2017-09-07T09:06:30 | 6560388196 | {"actor":{"display_login":"stickler-ci"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/127508515","pull_request_review_id":50105738,"id":127508515,"diff_hunk":"@@ -0,0 +1,726 @@\n+from django.db import models\n+\n+from dimagi.utils.decorators.memoized import memoized\n+\n+REPORTING_MECHANISM_MISSED_CALL = 83\n+REPORTING_MECHANISM_99_DOTS = 84\n+REPORTING_MECHANISM_FIELD_OFFICER = 85\n+REPORTING_MECHANISM_TREATMENT_SUPPORTER = 86\n+REPORTING_MECHANISM_TREATMENT_PROVIDER = 87\n+REPORTING_MECHANISM_PATIENT = 88\n+REPORTING_MECHANISM_MERM = 96\n+REPORTING_MECHANISM_AYUSH_OTHER_PROVIDER = 97\n+REPORTING_MECHANISM_NONE = 0\n+\n+DIRECTLY_OBSERVED_DOSE = 0\n+MISSED_DOSE = 1\n+SELF_ADMINISTERED_DOSE = 3\n+\n+\n+def get_agency_by_motech_user_name(motech_user_name):\n+ try:\n+ return Agency_Jul13.objects.get(\n+ agencyId=UserDetail_Jul13.objects.get(\n+ motechUserName=motech_user_name\n+ ).agencyId\n+ )\n+ except (Agency_Jul13.DoesNotExist, UserDetail_Jul13.DoesNotExist):\n+ return None\n+\n+\n+class Beneficiary_Jul13(models.Model):\n+ id = models.IntegerField(null=True)\n+ additionalDetails = models.CharField(max_length=500, null=True)\n+ addressLineOne = models.CharField(max_length=256, null=True)\n+ addressLineTwo = models.CharField(max_length=256, null=True)\n+ age = models.IntegerField(null=True)\n+ alertFrequency = models.CharField(max_length=60, null=True)\n+ associatedFOId = models.CharField(max_length=10, null=True)\n+ associatedQPId = models.CharField(max_length=10, null=True)\n+ blockOrHealthPostId = models.CharField(max_length=10, null=True)\n+ caseCreatedBy = models.CharField(max_length=10, null=True)\n+ caseId = models.CharField(max_length=18, primary_key=True)\n+ caseName = models.CharField(max_length=62, null=True)\n+ caseReferredBy = models.CharField(max_length=18, null=True)\n+ caseStatus = models.CharField(max_length=20, null=True)\n+ configureAlert = models.CharField(max_length=5, null=True)\n+ creationDate = models.DateTimeField()\n+ creator = models.CharField(max_length=255, null=True)\n+ dateOfIdentification = models.DateTimeField(null=True)\n+ dateOfRegn = models.DateTimeField()\n+ diagnosisBasisId = models.IntegerField(null=True)\n+ districtId = models.CharField(max_length=6, null=True)\n+ dob = models.DateTimeField(null=True)\n+ email = models.CharField(max_length=6, null=True)\n+ emergencyContactNo = models.CharField(max_length=10, null=True)\n+ extraPulmonarySiteId = models.IntegerField(null=True)\n+ fatherHusbandName = models.CharField(max_length=60, null=True)\n+ firstName = models.CharField(max_length=30)\n+ gender = models.CharField(max_length=10, null=True)\n+ identificationNumber = models.CharField(max_length=30, null=True)\n+ identificationTypeId = models.CharField(max_length=10, null=True)\n+ isActive = models.CharField(max_length=10, null=True)\n+ languagePreferences = models.CharField(max_length=30, null=True)\n+ lastName = models.CharField(max_length=30)\n+ mdrTBSuspected = models.CharField(max_length=30, null=True)\n+ middleName = models.CharField(max_length=30, null=True)\n+ modificationDate = models.DateTimeField(null=True)\n+ modifiedBy = models.CharField(max_length=255, null=True)\n+ nikshayId = models.CharField(max_length=10, null=True)\n+ occupation = models.CharField(max_length=30, null=True)\n+ onBehalfOf = models.CharField(max_length=10, null=True)\n+ organisationId = models.IntegerField()\n+ owner = models.CharField(max_length=255, null=True)\n+ patientCategoryId = models.IntegerField(null=True)\n+ phoneNumber = models.CharField(max_length=10)\n+ pincode = models.IntegerField(null=True)\n+ provisionalDiagnosis = models.CharField(max_length=255, null=True)\n+ qpReferralBy = models.CharField(max_length=10, null=True)\n+ qpReferralConfirmationStatus = models.CharField(max_length=20, null=True)\n+ referredQP = models.CharField(max_length=10, null=True)\n+ rifampicinResistanceId = models.IntegerField(null=True)\n+ rxPreferences = models.CharField(max_length=255, null=True)\n+ shiftedToCATIVMdr = models.CharField(max_length=5, null=True)\n+ siteOfDiseaseId = models.IntegerField(null=True)\n+ stateId = models.CharField(max_length=10, null=True)\n+ subOrganizationId = models.IntegerField(null=True)\n+ symptoms = models.CharField(max_length=255, null=True)\n+ tbCategoryId = models.IntegerField(null=True)\n+ testToBeConducted = models.CharField(max_length=255, null=True)\n+ tsAccountTypeId = models.CharField(max_length=6, null=True)\n+ tsBankAccNo = models.BigIntegerField(null=True)\n+ tsBankAccountName = models.CharField(max_length=100, null=True)\n+ tsBankBranch = models.CharField(max_length=100, null=True)\n+ tsBankIFSCCode = models.CharField(max_length=11, null=True)\n+ tsBankMicrCode = models.BigIntegerField(null=True)\n+ tsBankName = models.CharField(max_length=100, null=True)\n+ tsId = models.CharField(max_length=10, null=True)\n+ tsPhoneNo = models.CharField(max_length=10, null=True)\n+ tsType = models.CharField(max_length=20, null=True)\n+ tsprovidertype = models.CharField(max_length=30, null=True)\n+ villageTownCity = models.CharField(max_length=60, null=True)\n+ wardId = models.CharField(max_length=10, null=True)\n+ physicalCaseId = models.CharField(max_length=18, null=True)\n+\n+ @property\n+ def age_entered(self):\n+ return self.age\n+\n+ @property\n+ @memoized\n+ def creating_agency(self):\n+ return get_agency_by_motech_user_name(self.creator)\n+\n+ @property\n+ def current_address(self):\n+ if not self.addressLineOne:\n+ return self.addressLineTwo or ''\n+ if not self.addressLineTwo:\n+ return self.addressLineOne or ''\n+ return ', '.join([self.addressLineOne, self.addressLineTwo])\n+\n+ @property\n+ def current_episode_type(self):\n+ return {\n+ 'patient': 'confirmed_tb',\n+ 'suspect': 'presumptive_tb',\n+ }[self.caseStatus.strip()]\n+\n+ @property\n+ def episode_name(self):\n+ return {\n+ 'patient': 'Episode #1: Confirmed TB (Patient)',\n+ 'suspect': 'Episode #1: Suspected TB (Patient)',\n+ }[self.caseStatus.strip()]\n+\n+ @property\n+ def husband_father_name(self):\n+ return self.fatherHusbandName or ''\n+\n+ @property\n+ def language_preference(self):\n+ return {\n+ '131': 'en',\n+ '132': 'hin',\n+ '133': 'bho',\n+ '152': 'mar',\n+ '153': 'guj',\n+ None: '',\n+ }[self.languagePreferences]\n+\n+ @property\n+ def name(self):\n+ return ' '.join([self.firstName, self.lastName])\n+\n+ @property\n+ @memoized\n+ def referred_provider(self):\n+ return get_agency_by_motech_user_name(self.referredQP)\n+\n+ @property\n+ def send_alerts(self):\n+ return {\n+ 'Yes': 'yes',\n+ 'No': 'no',\n+ }[self.configureAlert]\n+\n+ @property\n+ def sex(self):\n+ return {\n+ '4': 'male',\n+ '5': 'female',\n+ '6': 'transgender',\n+ None: None,\n+ }[self.gender]\n+\n+ @property\n+ def has_aadhaar_number(self):\n+ return self.identificationTypeId == '16'\n+\n+ @property\n+ def other_id_type(self):\n+ return {\n+ '17': 'pan_card',\n+ '18': 'drivers_license',\n+ '19': 'ration_card',\n+ '20': 'voter_card',\n+ '21': 'none',\n+ None: 'none',\n+ }[self.identificationTypeId]\n+\n+\n+class Episode_Jul13(models.Model):\n+ id = models.IntegerField(null=True)\n+ accountName = models.CharField(max_length=255, null=True)\n+ accountType = models.CharField(max_length=255, null=True)\n+ adherenceScore = models.DecimalField(decimal_places=10, max_digits=14)\n+ alertFrequencyId = models.IntegerField()\n+ associatedFO = models.CharField(max_length=255, null=True)\n+ bankName = models.CharField(max_length=255, null=True)\n+ basisOfDiagnosis = models.CharField(max_length=255, null=True)\n+ beneficiaryID = models.CharField(max_length=18, db_index=True)\n+ branchName = models.CharField(max_length=255, null=True)\n+ creationDate = models.DateTimeField(null=True)\n+ creator = models.CharField(max_length=255, null=True)\n+ dateOfDiagnosis = models.DateTimeField()\n+ diabetes = models.CharField(max_length=255, null=True)\n+ dstStatus = models.CharField(max_length=255, null=True)\n+ episodeDisplayID = models.IntegerField(db_index=True)\n+ episodeID = models.CharField(max_length=8, primary_key=True)\n+ extraPulmonary = models.CharField(max_length=255, null=True)\n+ hiv = models.CharField(max_length=255, null=True)\n+ ifscCode = models.CharField(max_length=255, null=True)\n+ isNonSuperVisor = models.CharField(max_length=255, null=True)\n+ lastMonthAdherencePct = models.DecimalField(decimal_places=10, max_digits=14)\n+ lastTwoWeeksAdherencePct = models.DecimalField(decimal_places=10, max_digits=14)\n+ micr = models.CharField(max_length=255, null=True)\n+ missedDosesPct = models.DecimalField(decimal_places=10, max_digits=14)\n+ mobileNumber = models.CharField(max_length=255, null=True)\n+ modificationDate = models.DateTimeField(null=True)\n+ modifiedBy = models.CharField(max_length=255, null=True)\n+ name = models.CharField(max_length=255, null=True)\n+ newOrRetreatment = models.CharField(max_length=255, null=True)\n+ nikshayBy = models.CharField(max_length=255, null=True)\n+ nikshayID = models.CharField(max_length=18, null=True)\n+ nonRxSupervisorName = models.CharField(max_length=255, null=True)\n+ onBeHalfOf = models.CharField(max_length=10, null=True)\n+ organisationId = models.CharField(max_length=18, null=True)\n+ owner = models.CharField(max_length=255, null=True)\n+ patientWeight = models.DecimalField(decimal_places=10, max_digits=40)\n+ phoneNumber = models.CharField(max_length=255, null=True)\n+ retreatmentReason = models.CharField(max_length=255, null=True)\n+ rxArchivalDate = models.DateTimeField(null=True)\n+ rxAssignedBy = models.CharField(max_length=255, null=True)\n+ rxInitiationStatus = models.CharField(max_length=255, null=True)\n+ # [u'Died before treatment start',\n+ # u'Lost to follow up/ unable to capture',\n+ # u'On treatment (Program support)',\n+ # u'On treatment (public)',\n+ # u'On treatment (self)',\n+ # u'Patient missing',\n+ # u'Pending']\n+ rxOutcomeDate = models.DateTimeField(null=True)\n+ rxStartDate = models.DateTimeField()\n+ rxSupervisor = models.CharField(max_length=255, null=True)\n+ site = models.CharField(max_length=255)\n+ status = models.CharField(max_length=255, null=True)\n+ treatingQP = models.CharField(max_length=255, null=True)\n+ treatmentOutcomeId = models.CharField(max_length=255, null=True)\n+ treatmentPhase = models.CharField(max_length=255, null=True)\n+ tsProviderType = models.CharField(max_length=255, null=True)\n+ unknownAdherencePct = models.DecimalField(decimal_places=10, max_digits=14)\n+ unresolvedMissedDosesPct = models.DecimalField(decimal_places=10, max_digits=14)\n+ treatingHospital = models.CharField(max_length=10, null=True)\n+ treatmentCompletionInsentiveFlag = models.CharField(max_length=1, null=True)\n+ mermIMIEno = models.CharField(max_length=255, null=True)\n+ adherenceSupportAssigned = models.CharField(max_length=255, null=True)\n+\n+ @property\n+ def adherence_total_doses_taken(self):\n+ return Adherence_Jul13.objects.filter(\n+ episodeId=self.episodeID,\n+ dosageStatusId__in=[DIRECTLY_OBSERVED_DOSE, SELF_ADMINISTERED_DOSE],\n+ ).count()\n+\n+ @property\n+ @memoized\n+ def adherence_tracking_mechanism(self):\n+ reporting_mechanism_values = Adherence_Jul13.objects.filter(\n+ episodeId=self.episodeID,\n+ ).exclude(\n+ reportingMechanismId=REPORTING_MECHANISM_NONE,\n+ ).values('reportingMechanismId').distinct()\n+\n+ values = [field_to_value['reportingMechanismId'] for field_to_value in reporting_mechanism_values]\n+\n+ if reporting_mechanism_values:\n+ if REPORTING_MECHANISM_99_DOTS in values:\n+ return '99dots'\n+ elif REPORTING_MECHANISM_MERM in values:\n+ return 'merm'\n+ elif REPORTING_MECHANISM_FIELD_OFFICER in values:\n+ return 'field_officer'\n+ elif REPORTING_MECHANISM_TREATMENT_SUPPORTER in values:\n+ return 'treatment_supporter'\n+ else:\n+ return 'contact_centre'\n+ else:\n+ return ''\n+\n+ @property\n+ def basis_of_diagnosis(self):\n+ return {\n+ 'Clinical - Chest Xray': 'clinical_chest',\n+ 'Clinical - Other': 'clinical_other',\n+ 'Microbiologically Confirmed - Smear-positive': 'microbiological_smear',\n+ 'Microbiologically Confirmed - Xpert MTB/RIF TB-positive': 'microbiological_cbnaat',\n+ 'Microbiologically Confirmed - Xpert TB-positive': '', # TODO","path":"custom/enikshay/private_sector_datamigration/models/jul13.py","position":297,"original_position":297,"commit_id":"8fcd260736e3391775f8fc7564b2d52f8f04d2c5","original_commit_id":"8fcd260736e3391775f8fc7564b2d52f8f04d2c5","user":{"login":"stickler-ci","id":16011037,"avatar_url":"https://avatars7.githubusercontent.com/u/16011037?v=4","gravatar_id":"","url":"https://api.github.com/users/stickler-ci","html_url":"https://github.com/stickler-ci","followers_url":"https://api.github.com/users/stickler-ci/followers","following_url":"https://api.github.com/users/stickler-ci/following{/other_user}","gists_url":"https://api.github.com/users/stickler-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/stickler-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stickler-ci/subscriptions","organizations_url":"https://api.github.com/users/stickler-ci/orgs","repos_url":"https://api.github.com/users/stickler-ci/repos","events_url":"https://api.github.com/users/stickler-ci/events{/privacy}","received_events_url":"https://api.github.com/users/stickler-ci/received_events","type":"User","site_admin":false},"body":"E261 at least two spaces before inline comment","created_at":"2017-07-14T17:33:15Z","updated_at":"2017-07-14T17:33:15Z","html_url":"https://github.com/dimagi/commcare-hq/pull/17033#discussion_r127508515","pull_request_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/17033","_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/127508515"},"html":{"href":"https://github.com/dimagi/commcare-hq/pull/17033#discussion_r127508515"},"pull_request":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/17033"}}},"pull_request":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/17033","id":130636801,"html_url":"https://github.com/dimagi/commcare-hq/pull/17033","diff_url":"https://github.com/dimagi/commcare-hq/pull/17033.diff","patch_url":"https://github.com/dimagi/commcare-hq/pull/17033.patch","issue_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/17033","number":17033,"state":"open","locked":false,"title":"add extra models for july 13 data dump","user":{"login":"nickpell","id":1757035,"avatar_url":"https://avatars6.githubusercontent.com/u/1757035?v=4","gravatar_id":"","url":"https://api.github.com/users/nickpell","html_url":"https://github.com/nickpell","followers_url":"https://api.github.com/users/nickpell/followers","following_url":"https://api.github.com/users/nickpell/following{/other_user}","gists_url":"https://api.github.com/users/nickpell/gists{/gist_id}","starred_url":"https://api.github.com/users/nickpell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickpell/subscriptions","organizations_url":"https://api.github.com/users/nickpell/orgs","repos_url":"https://api.github.com/users/nickpell/repos","events_url":"https://api.github.com/users/nickpell/events{/privacy}","received_events_url":"https://api.github.com/users/nickpell/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-14T17:32:40Z","updated_at":"2017-07-14T17:33:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12793e1f9c70b860c3a997283200f410d0470ed1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/17033/commits","review_comments_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/17033/comments","review_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/17033/comments","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/8fcd260736e3391775f8fc7564b2d52f8f04d2c5","head":{"label":"dimagi:np/tb/jul13","ref":"np/tb/jul13","sha":"8fcd260736e3391775f8fc7564b2d52f8f04d2c5","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars5.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":247278,"name":"commcare-hq","full_name":"dimagi/commcare-hq","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars5.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/commcare-hq","description":"A server-side tool to help manage community health workers, written in Django","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-hq","forks_url":"https://api.github.com/repos/dimagi/commcare-hq/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-hq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-hq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-hq/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-hq/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-hq/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-hq/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-hq/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-hq/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-hq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-hq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-hq/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-hq/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-hq/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-hq/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-hq/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-hq/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-hq/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-hq/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-hq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-hq/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-hq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-hq/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-hq/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-hq/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-hq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-hq/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-hq/deployments","created_at":"2009-07-09T17:00:07Z","updated_at":"2017-06-28T10:44:15Z","pushed_at":"2017-07-14T17:32:41Z","git_url":"git://github.com/dimagi/commcare-hq.git","ssh_url":"[email protected]:dimagi/commcare-hq.git","clone_url":"https://github.com/dimagi/commcare-hq.git","svn_url":"https://github.com/dimagi/commcare-hq","homepage":"http://www.commcarehq.org","size":357257,"stargazers_count":79,"watchers_count":79,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":92,"mirror_url":null,"open_issues_count":63,"forks":92,"open_issues":63,"watchers":79,"default_branch":"master"}},"base":{"label":"dimagi:master","ref":"master","sha":"1d6c053dbb57b24e68b62352bf136a6587d2d655","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars5.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":247278,"name":"commcare-hq","full_name":"dimagi/commcare-hq","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars5.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/commcare-hq","description":"A server-side tool to help manage community health workers, written in Django","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-hq","forks_url":"https://api.github.com/repos/dimagi/commcare-hq/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-hq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-hq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-hq/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-hq/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-hq/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-hq/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-hq/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-hq/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-hq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-hq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-hq/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-hq/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-hq/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-hq/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-hq/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-hq/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-hq/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-hq/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-hq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-hq/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-hq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-hq/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-hq/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-hq/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-hq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-hq/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-hq/deployments","created_at":"2009-07-09T17:00:07Z","updated_at":"2017-06-28T10:44:15Z","pushed_at":"2017-07-14T17:32:41Z","git_url":"git://github.com/dimagi/commcare-hq.git","ssh_url":"[email protected]:dimagi/commcare-hq.git","clone_url":"https://github.com/dimagi/commcare-hq.git","svn_url":"https://github.com/dimagi/commcare-hq","homepage":"http://www.commcarehq.org","size":357257,"stargazers_count":79,"watchers_count":79,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":92,"mirror_url":null,"open_issues_count":63,"forks":92,"open_issues":63,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/17033"},"html":{"href":"https://github.com/dimagi/commcare-hq/pull/17033"},"issue":{"href":"https://api.github.com/repos/dimagi/commcare-hq/issues/17033"},"comments":{"href":"https://api.github.com/repos/dimagi/commcare-hq/issues/17033/comments"},"review_comments":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/17033/comments"},"review_comment":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/17033/commits"},"statuses":{"href":"https://api.github.com/repos/dimagi/commcare-hq/statuses/8fcd260736e3391775f8fc7564b2d52f8f04d2c5"}}}} | {
"id": 247278,
"name": "dimagi/commcare-hq",
"url": "https://api.github.com/repos/dimagi/commcare-hq"
} | {
"id": 16011037,
"login": "stickler-ci",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16011037?",
"url": "https://api.github.com/users/stickler-ci"
} | {
"id": 94514,
"login": "dimagi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/94514?",
"url": "https://api.github.com/orgs/dimagi"
} | 2017-07-14T17:33:15 | 6259225170 | {"actor":{"display_login":"stickler-ci"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/110887427","pull_request_review_id":32089935,"id":110887427,"diff_hunk":"@@ -28,5 +28,6 @@ func toContainerdResources(resources container.Resources) libcontainerd.Resource\n \t}\n \tr.MemoryReservation = uint64(resources.MemoryReservation)\n \tr.KernelMemoryLimit = uint64(resources.KernelMemory)\n+\tr.PidsLimit = uint64(resources.PidsLimit)","path":"daemon/update_linux.go","position":4,"original_position":4,"commit_id":"ec9a2fc44eb2df43736b8f3a1fc7d05f4f8c99b1","original_commit_id":"ec9a2fc44eb2df43736b8f3a1fc7d05f4f8c99b1","user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars1.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"body":"I think @mlaventure would be the best person to assist 👍 ","created_at":"2017-04-11T12:23:16Z","updated_at":"2017-04-11T12:23:16Z","html_url":"https://github.com/docker/docker/pull/32519#discussion_r110887427","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/32519","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/110887427"},"html":{"href":"https://github.com/docker/docker/pull/32519#discussion_r110887427"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/32519"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/32519","id":115302388,"html_url":"https://github.com/docker/docker/pull/32519","diff_url":"https://github.com/docker/docker/pull/32519.diff","patch_url":"https://github.com/docker/docker/pull/32519.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/32519","number":32519,"state":"open","locked":false,"title":"Add pids-limit support in docker update","user":{"login":"darkowlzz","id":614105,"avatar_url":"https://avatars2.githubusercontent.com/u/614105?v=3","gravatar_id":"","url":"https://api.github.com/users/darkowlzz","html_url":"https://github.com/darkowlzz","followers_url":"https://api.github.com/users/darkowlzz/followers","following_url":"https://api.github.com/users/darkowlzz/following{/other_user}","gists_url":"https://api.github.com/users/darkowlzz/gists{/gist_id}","starred_url":"https://api.github.com/users/darkowlzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkowlzz/subscriptions","organizations_url":"https://api.github.com/users/darkowlzz/orgs","repos_url":"https://api.github.com/users/darkowlzz/repos","events_url":"https://api.github.com/users/darkowlzz/events{/privacy}","received_events_url":"https://api.github.com/users/darkowlzz/received_events","type":"User","site_admin":false},"body":"- Added a new flag `--pids-limit` in `docker update` command.\r\n- Value of the `pidsLimit` flag variable is set as `PidsLimit` in\r\n`containertypes.Resources`, which is used to apply the update in\r\nhostConfig and the real world (running containers).\r\n- Added `TestUpdatePIDsLimit` integration test for the new flag.\r\n\r\nFixes #32443\r\n\r\nSigned-off-by: Sunny Gogoi <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/docker/docker/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\n\r\nAdded a new flag, `--pids-limit` , in the command `docker update`.\r\n\r\n**- How I did it**\r\n\r\nDetails are in commit body.\r\n\r\n**- How to verify it**\r\n\r\nVerify by starting a container with `--pids-limit=4` and then updating pids-limit of the container\r\nto a new value with `docker update --pids-limit=<newValue> <containerName>`.\r\nOnce updated, the result can be seen in `docker inspect <containerName>` and in the file\r\n`/sys/fs/cgroup/pids/pids.max` within the container.\r\n\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\n\r\nAdd pids-limit support in docker update\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\n","created_at":"2017-04-11T11:53:05Z","updated_at":"2017-04-11T12:23:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53ee5b111a808844219b287db4d1e0a797100c32","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/32519/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/32519/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/32519/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/ec9a2fc44eb2df43736b8f3a1fc7d05f4f8c99b1","head":{"label":"darkowlzz:32443-docker-update-pids-limit","ref":"32443-docker-update-pids-limit","sha":"ec9a2fc44eb2df43736b8f3a1fc7d05f4f8c99b1","user":{"login":"darkowlzz","id":614105,"avatar_url":"https://avatars2.githubusercontent.com/u/614105?v=3","gravatar_id":"","url":"https://api.github.com/users/darkowlzz","html_url":"https://github.com/darkowlzz","followers_url":"https://api.github.com/users/darkowlzz/followers","following_url":"https://api.github.com/users/darkowlzz/following{/other_user}","gists_url":"https://api.github.com/users/darkowlzz/gists{/gist_id}","starred_url":"https://api.github.com/users/darkowlzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkowlzz/subscriptions","organizations_url":"https://api.github.com/users/darkowlzz/orgs","repos_url":"https://api.github.com/users/darkowlzz/repos","events_url":"https://api.github.com/users/darkowlzz/events{/privacy}","received_events_url":"https://api.github.com/users/darkowlzz/received_events","type":"User","site_admin":false},"repo":{"id":87778034,"name":"docker","full_name":"darkowlzz/docker","owner":{"login":"darkowlzz","id":614105,"avatar_url":"https://avatars2.githubusercontent.com/u/614105?v=3","gravatar_id":"","url":"https://api.github.com/users/darkowlzz","html_url":"https://github.com/darkowlzz","followers_url":"https://api.github.com/users/darkowlzz/followers","following_url":"https://api.github.com/users/darkowlzz/following{/other_user}","gists_url":"https://api.github.com/users/darkowlzz/gists{/gist_id}","starred_url":"https://api.github.com/users/darkowlzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkowlzz/subscriptions","organizations_url":"https://api.github.com/users/darkowlzz/orgs","repos_url":"https://api.github.com/users/darkowlzz/repos","events_url":"https://api.github.com/users/darkowlzz/events{/privacy}","received_events_url":"https://api.github.com/users/darkowlzz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darkowlzz/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/darkowlzz/docker","forks_url":"https://api.github.com/repos/darkowlzz/docker/forks","keys_url":"https://api.github.com/repos/darkowlzz/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darkowlzz/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darkowlzz/docker/teams","hooks_url":"https://api.github.com/repos/darkowlzz/docker/hooks","issue_events_url":"https://api.github.com/repos/darkowlzz/docker/issues/events{/number}","events_url":"https://api.github.com/repos/darkowlzz/docker/events","assignees_url":"https://api.github.com/repos/darkowlzz/docker/assignees{/user}","branches_url":"https://api.github.com/repos/darkowlzz/docker/branches{/branch}","tags_url":"https://api.github.com/repos/darkowlzz/docker/tags","blobs_url":"https://api.github.com/repos/darkowlzz/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darkowlzz/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darkowlzz/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/darkowlzz/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darkowlzz/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/darkowlzz/docker/languages","stargazers_url":"https://api.github.com/repos/darkowlzz/docker/stargazers","contributors_url":"https://api.github.com/repos/darkowlzz/docker/contributors","subscribers_url":"https://api.github.com/repos/darkowlzz/docker/subscribers","subscription_url":"https://api.github.com/repos/darkowlzz/docker/subscription","commits_url":"https://api.github.com/repos/darkowlzz/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/darkowlzz/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/darkowlzz/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/darkowlzz/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/darkowlzz/docker/contents/{+path}","compare_url":"https://api.github.com/repos/darkowlzz/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darkowlzz/docker/merges","archive_url":"https://api.github.com/repos/darkowlzz/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darkowlzz/docker/downloads","issues_url":"https://api.github.com/repos/darkowlzz/docker/issues{/number}","pulls_url":"https://api.github.com/repos/darkowlzz/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/darkowlzz/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/darkowlzz/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darkowlzz/docker/labels{/name}","releases_url":"https://api.github.com/repos/darkowlzz/docker/releases{/id}","deployments_url":"https://api.github.com/repos/darkowlzz/docker/deployments","created_at":"2017-04-10T07:07:11Z","updated_at":"2017-04-10T07:07:35Z","pushed_at":"2017-04-11T11:43:09Z","git_url":"git://github.com/darkowlzz/docker.git","ssh_url":"[email protected]:darkowlzz/docker.git","clone_url":"https://github.com/darkowlzz/docker.git","svn_url":"https://github.com/darkowlzz/docker","homepage":"https://www.docker.com","size":128090,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"a258ef58d8a100467d5d948b026a884ebe58eaf4","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars2.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars2.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2017-04-11T11:53:42Z","pushed_at":"2017-04-11T12:17:11Z","git_url":"git://github.com/docker/docker.git","ssh_url":"[email protected]:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"https://www.docker.com","size":128135,"stargazers_count":41658,"watchers_count":41658,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12580,"mirror_url":null,"open_issues_count":2471,"forks":12580,"open_issues":2471,"watchers":41658,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/32519"},"html":{"href":"https://github.com/docker/docker/pull/32519"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/32519"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/32519/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/32519/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/32519/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/ec9a2fc44eb2df43736b8f3a1fc7d05f4f8c99b1"}}}} | {
"id": 7691631,
"name": "docker/docker",
"url": "https://api.github.com/repos/docker/docker"
} | {
"id": 1804568,
"login": "thaJeztah",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1804568?",
"url": "https://api.github.com/users/thaJeztah"
} | {
"id": 5429470,
"login": "docker",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5429470?",
"url": "https://api.github.com/orgs/docker"
} | 2017-04-11T12:23:16 | 5667296163 | {"actor":{"display_login":"thaJeztah"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/docker/swarm/pulls/comments/148152141","pull_request_review_id":73350785,"id":148152141,"diff_hunk":"@@ -14,20 +15,37 @@ type Replica struct {\n \thandler http.Handler\n \ttlsConfig *tls.Config\n \tprimary string\n+\taddr string // the address of this replica\n+\tmu sync.RWMutex","path":"api/replica.go","position":13,"original_position":13,"commit_id":"efbe7e32203a93e57c5b234664c2119c08545cbd","original_commit_id":"efbe7e32203a93e57c5b234664c2119c08545cbd","user":{"login":"wsong","id":616361,"avatar_url":"https://avatars0.githubusercontent.com/u/616361?v=4","gravatar_id":"","url":"https://api.github.com/users/wsong","html_url":"https://github.com/wsong","followers_url":"https://api.github.com/users/wsong/followers","following_url":"https://api.github.com/users/wsong/following{/other_user}","gists_url":"https://api.github.com/users/wsong/gists{/gist_id}","starred_url":"https://api.github.com/users/wsong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsong/subscriptions","organizations_url":"https://api.github.com/users/wsong/orgs","repos_url":"https://api.github.com/users/wsong/repos","events_url":"https://api.github.com/users/wsong/events{/privacy}","received_events_url":"https://api.github.com/users/wsong/received_events","type":"User","site_admin":false},"body":"We don't seem to be using the `RLock()` method anywhere; is there a reason we need the `RWMutex` instead of a regular mutex?","created_at":"2017-10-31T23:19:31Z","updated_at":"2017-10-31T23:20:49Z","html_url":"https://github.com/docker/swarm/pull/2812#discussion_r148152141","pull_request_url":"https://api.github.com/repos/docker/swarm/pulls/2812","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/docker/swarm/pulls/comments/148152141"},"html":{"href":"https://github.com/docker/swarm/pull/2812#discussion_r148152141"},"pull_request":{"href":"https://api.github.com/repos/docker/swarm/pulls/2812"}}},"pull_request":{"url":"https://api.github.com/repos/docker/swarm/pulls/2812","id":149919962,"html_url":"https://github.com/docker/swarm/pull/2812","diff_url":"https://github.com/docker/swarm/pull/2812.diff","patch_url":"https://github.com/docker/swarm/pull/2812.patch","issue_url":"https://api.github.com/repos/docker/swarm/issues/2812","number":2812,"state":"open","locked":false,"title":"Fix No Elected Primary Cluster Manager","user":{"login":"dperny","id":2367858,"avatar_url":"https://avatars3.githubusercontent.com/u/2367858?v=4","gravatar_id":"","url":"https://api.github.com/users/dperny","html_url":"https://github.com/dperny","followers_url":"https://api.github.com/users/dperny/followers","following_url":"https://api.github.com/users/dperny/following{/other_user}","gists_url":"https://api.github.com/users/dperny/gists{/gist_id}","starred_url":"https://api.github.com/users/dperny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dperny/subscriptions","organizations_url":"https://api.github.com/users/dperny/orgs","repos_url":"https://api.github.com/users/dperny/repos","events_url":"https://api.github.com/users/dperny/events{/privacy}","received_events_url":"https://api.github.com/users/dperny/received_events","type":"User","site_admin":false},"body":"Blocks calls to ServeHTTP until a primary cluster manager is selected.\r\n\r\nAdds logic to route request to ourself if we become the leader while blocking.\r\n\r\n/cc @wsong \r\n\r\nSigned-off-by: Drew Erny <[email protected]>","created_at":"2017-10-31T22:07:54Z","updated_at":"2017-10-31T23:20:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dc76d6403cec4af27a5f23fedd32ecc1a0a5634","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/swarm/pulls/2812/commits","review_comments_url":"https://api.github.com/repos/docker/swarm/pulls/2812/comments","review_comment_url":"https://api.github.com/repos/docker/swarm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/swarm/issues/2812/comments","statuses_url":"https://api.github.com/repos/docker/swarm/statuses/efbe7e32203a93e57c5b234664c2119c08545cbd","head":{"label":"dperny:fix-no-elected-manager","ref":"fix-no-elected-manager","sha":"efbe7e32203a93e57c5b234664c2119c08545cbd","user":{"login":"dperny","id":2367858,"avatar_url":"https://avatars3.githubusercontent.com/u/2367858?v=4","gravatar_id":"","url":"https://api.github.com/users/dperny","html_url":"https://github.com/dperny","followers_url":"https://api.github.com/users/dperny/followers","following_url":"https://api.github.com/users/dperny/following{/other_user}","gists_url":"https://api.github.com/users/dperny/gists{/gist_id}","starred_url":"https://api.github.com/users/dperny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dperny/subscriptions","organizations_url":"https://api.github.com/users/dperny/orgs","repos_url":"https://api.github.com/users/dperny/repos","events_url":"https://api.github.com/users/dperny/events{/privacy}","received_events_url":"https://api.github.com/users/dperny/received_events","type":"User","site_admin":false},"repo":{"id":59508562,"name":"swarm","full_name":"dperny/swarm","owner":{"login":"dperny","id":2367858,"avatar_url":"https://avatars3.githubusercontent.com/u/2367858?v=4","gravatar_id":"","url":"https://api.github.com/users/dperny","html_url":"https://github.com/dperny","followers_url":"https://api.github.com/users/dperny/followers","following_url":"https://api.github.com/users/dperny/following{/other_user}","gists_url":"https://api.github.com/users/dperny/gists{/gist_id}","starred_url":"https://api.github.com/users/dperny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dperny/subscriptions","organizations_url":"https://api.github.com/users/dperny/orgs","repos_url":"https://api.github.com/users/dperny/repos","events_url":"https://api.github.com/users/dperny/events{/privacy}","received_events_url":"https://api.github.com/users/dperny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dperny/swarm","description":"Swarm: a Docker-native clustering system","fork":true,"url":"https://api.github.com/repos/dperny/swarm","forks_url":"https://api.github.com/repos/dperny/swarm/forks","keys_url":"https://api.github.com/repos/dperny/swarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dperny/swarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dperny/swarm/teams","hooks_url":"https://api.github.com/repos/dperny/swarm/hooks","issue_events_url":"https://api.github.com/repos/dperny/swarm/issues/events{/number}","events_url":"https://api.github.com/repos/dperny/swarm/events","assignees_url":"https://api.github.com/repos/dperny/swarm/assignees{/user}","branches_url":"https://api.github.com/repos/dperny/swarm/branches{/branch}","tags_url":"https://api.github.com/repos/dperny/swarm/tags","blobs_url":"https://api.github.com/repos/dperny/swarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dperny/swarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dperny/swarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/dperny/swarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dperny/swarm/statuses/{sha}","languages_url":"https://api.github.com/repos/dperny/swarm/languages","stargazers_url":"https://api.github.com/repos/dperny/swarm/stargazers","contributors_url":"https://api.github.com/repos/dperny/swarm/contributors","subscribers_url":"https://api.github.com/repos/dperny/swarm/subscribers","subscription_url":"https://api.github.com/repos/dperny/swarm/subscription","commits_url":"https://api.github.com/repos/dperny/swarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/dperny/swarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/dperny/swarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/dperny/swarm/issues/comments{/number}","contents_url":"https://api.github.com/repos/dperny/swarm/contents/{+path}","compare_url":"https://api.github.com/repos/dperny/swarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dperny/swarm/merges","archive_url":"https://api.github.com/repos/dperny/swarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dperny/swarm/downloads","issues_url":"https://api.github.com/repos/dperny/swarm/issues{/number}","pulls_url":"https://api.github.com/repos/dperny/swarm/pulls{/number}","milestones_url":"https://api.github.com/repos/dperny/swarm/milestones{/number}","notifications_url":"https://api.github.com/repos/dperny/swarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dperny/swarm/labels{/name}","releases_url":"https://api.github.com/repos/dperny/swarm/releases{/id}","deployments_url":"https://api.github.com/repos/dperny/swarm/deployments","created_at":"2016-05-23T18:32:29Z","updated_at":"2016-05-23T18:32:30Z","pushed_at":"2017-10-31T22:07:13Z","git_url":"git://github.com/dperny/swarm.git","ssh_url":"[email protected]:dperny/swarm.git","clone_url":"https://github.com/dperny/swarm.git","svn_url":"https://github.com/dperny/swarm","homepage":"","size":20251,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"53734b4a21c58f848bfe5de617ad13457b56a86f","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars1.githubusercontent.com/u/5429470?v=4","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":19360616,"name":"swarm","full_name":"docker/swarm","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars1.githubusercontent.com/u/5429470?v=4","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/swarm","description":"Swarm: a Docker-native clustering system","fork":false,"url":"https://api.github.com/repos/docker/swarm","forks_url":"https://api.github.com/repos/docker/swarm/forks","keys_url":"https://api.github.com/repos/docker/swarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/swarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/swarm/teams","hooks_url":"https://api.github.com/repos/docker/swarm/hooks","issue_events_url":"https://api.github.com/repos/docker/swarm/issues/events{/number}","events_url":"https://api.github.com/repos/docker/swarm/events","assignees_url":"https://api.github.com/repos/docker/swarm/assignees{/user}","branches_url":"https://api.github.com/repos/docker/swarm/branches{/branch}","tags_url":"https://api.github.com/repos/docker/swarm/tags","blobs_url":"https://api.github.com/repos/docker/swarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/swarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/swarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/swarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/swarm/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/swarm/languages","stargazers_url":"https://api.github.com/repos/docker/swarm/stargazers","contributors_url":"https://api.github.com/repos/docker/swarm/contributors","subscribers_url":"https://api.github.com/repos/docker/swarm/subscribers","subscription_url":"https://api.github.com/repos/docker/swarm/subscription","commits_url":"https://api.github.com/repos/docker/swarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/swarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/swarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/swarm/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/swarm/contents/{+path}","compare_url":"https://api.github.com/repos/docker/swarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/swarm/merges","archive_url":"https://api.github.com/repos/docker/swarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/swarm/downloads","issues_url":"https://api.github.com/repos/docker/swarm/issues{/number}","pulls_url":"https://api.github.com/repos/docker/swarm/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/swarm/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/swarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/swarm/labels{/name}","releases_url":"https://api.github.com/repos/docker/swarm/releases{/id}","deployments_url":"https://api.github.com/repos/docker/swarm/deployments","created_at":"2014-05-01T23:15:17Z","updated_at":"2017-10-31T14:27:09Z","pushed_at":"2017-10-31T22:07:55Z","git_url":"git://github.com/docker/swarm.git","ssh_url":"[email protected]:docker/swarm.git","clone_url":"https://github.com/docker/swarm.git","svn_url":"https://github.com/docker/swarm","homepage":"","size":20252,"stargazers_count":4826,"watchers_count":4826,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":993,"mirror_url":null,"archived":false,"open_issues_count":359,"forks":993,"open_issues":359,"watchers":4826,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/swarm/pulls/2812"},"html":{"href":"https://github.com/docker/swarm/pull/2812"},"issue":{"href":"https://api.github.com/repos/docker/swarm/issues/2812"},"comments":{"href":"https://api.github.com/repos/docker/swarm/issues/2812/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/swarm/pulls/2812/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/swarm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/swarm/pulls/2812/commits"},"statuses":{"href":"https://api.github.com/repos/docker/swarm/statuses/efbe7e32203a93e57c5b234664c2119c08545cbd"}},"author_association":"MEMBER"}} | {
"id": 19360616,
"name": "docker/swarm",
"url": "https://api.github.com/repos/docker/swarm"
} | {
"id": 616361,
"login": "wsong",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/616361?",
"url": "https://api.github.com/users/wsong"
} | {
"id": 5429470,
"login": "docker",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5429470?",
"url": "https://api.github.com/orgs/docker"
} | 2017-10-31T23:19:31 | 6792293492 | {"actor":{"display_login":"wsong"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotCMS/core/pulls/comments/144137399","pull_request_review_id":68751734,"id":144137399,"diff_hunk":"@@ -72,9 +74,14 @@ public CollectionResource createCollection(String newName) throws DotRuntimeExce\n \t\t\t} catch (DotSecurityException e) {\n \t\t\t\tLogger.error(DotWebdavHelper.class, e.getMessage(), e);\n \t\t\t\tthrow new DotRuntimeException(e.getMessage(), e);\n-\t\t\t}\t\t\t\n-\t\t\t\n-\t\t\tdotDavHelper.createTempFolder(File.separator + host.getHostname() + folderPath + File.separator + newName);\n+\t\t\t}\n+\n+ String hostFolderPath = File.separator + host.getHostname() + folderPath;\n+\t\t\tif(!hostFolderPath.endsWith(File.separator)){\n+ hostFolderPath = hostFolderPath + File.separator;\n+ }\n+\n+ dotDavHelper.createTempFolder(hostFolderPath + newName);\n \t\t\tFile f = new File(File.separator + host.getHostname() + folderPath);","path":"dotCMS/src/main/java/com/dotmarketing/webdav/FolderResourceImpl.java","position":24,"original_position":24,"commit_id":"a54e9a126044602853987c3567c960fda32025db","original_commit_id":"a54e9a126044602853987c3567c960fda32025db","user":{"login":"jdotcms","id":19578350,"avatar_url":"https://avatars0.githubusercontent.com/u/19578350?v=4","gravatar_id":"","url":"https://api.github.com/users/jdotcms","html_url":"https://github.com/jdotcms","followers_url":"https://api.github.com/users/jdotcms/followers","following_url":"https://api.github.com/users/jdotcms/following{/other_user}","gists_url":"https://api.github.com/users/jdotcms/gists{/gist_id}","starred_url":"https://api.github.com/users/jdotcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdotcms/subscriptions","organizations_url":"https://api.github.com/users/jdotcms/orgs","repos_url":"https://api.github.com/users/jdotcms/repos","events_url":"https://api.github.com/users/jdotcms/events{/privacy}","received_events_url":"https://api.github.com/users/jdotcms/received_events","type":"User","site_admin":false},"body":"meaningful names :)","created_at":"2017-10-11T21:11:24Z","updated_at":"2017-10-11T21:12:19Z","html_url":"https://github.com/dotCMS/core/pull/12834#discussion_r144137399","pull_request_url":"https://api.github.com/repos/dotCMS/core/pulls/12834","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotCMS/core/pulls/comments/144137399"},"html":{"href":"https://github.com/dotCMS/core/pull/12834#discussion_r144137399"},"pull_request":{"href":"https://api.github.com/repos/dotCMS/core/pulls/12834"}}},"pull_request":{"url":"https://api.github.com/repos/dotCMS/core/pulls/12834","id":146045842,"html_url":"https://github.com/dotCMS/core/pull/12834","diff_url":"https://github.com/dotCMS/core/pull/12834.diff","patch_url":"https://github.com/dotCMS/core/pull/12834.patch","issue_url":"https://api.github.com/repos/dotCMS/core/issues/12834","number":12834,"state":"open","locked":false,"title":"Issue 12671 2","user":{"login":"erickgonzalez","id":5278970,"avatar_url":"https://avatars3.githubusercontent.com/u/5278970?v=4","gravatar_id":"","url":"https://api.github.com/users/erickgonzalez","html_url":"https://github.com/erickgonzalez","followers_url":"https://api.github.com/users/erickgonzalez/followers","following_url":"https://api.github.com/users/erickgonzalez/following{/other_user}","gists_url":"https://api.github.com/users/erickgonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/erickgonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erickgonzalez/subscriptions","organizations_url":"https://api.github.com/users/erickgonzalez/orgs","repos_url":"https://api.github.com/users/erickgonzalez/repos","events_url":"https://api.github.com/users/erickgonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/erickgonzalez/received_events","type":"User","site_admin":false},"body":"WebDAV changes, still having issues with Finder and folders with upper-case","created_at":"2017-10-11T19:53:36Z","updated_at":"2017-10-11T21:12:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a974cd83c542b03e3094e3eb90e377e502a94a9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotCMS/core/pulls/12834/commits","review_comments_url":"https://api.github.com/repos/dotCMS/core/pulls/12834/comments","review_comment_url":"https://api.github.com/repos/dotCMS/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotCMS/core/issues/12834/comments","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/a54e9a126044602853987c3567c960fda32025db","head":{"label":"dotCMS:issue-12671-2","ref":"issue-12671-2","sha":"a54e9a126044602853987c3567c960fda32025db","user":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":3729629,"name":"core","full_name":"dotCMS/core","owner":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotCMS/core","description":"Source Code for dotCMS Java Enterprise Content Management System","fork":false,"url":"https://api.github.com/repos/dotCMS/core","forks_url":"https://api.github.com/repos/dotCMS/core/forks","keys_url":"https://api.github.com/repos/dotCMS/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotCMS/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotCMS/core/teams","hooks_url":"https://api.github.com/repos/dotCMS/core/hooks","issue_events_url":"https://api.github.com/repos/dotCMS/core/issues/events{/number}","events_url":"https://api.github.com/repos/dotCMS/core/events","assignees_url":"https://api.github.com/repos/dotCMS/core/assignees{/user}","branches_url":"https://api.github.com/repos/dotCMS/core/branches{/branch}","tags_url":"https://api.github.com/repos/dotCMS/core/tags","blobs_url":"https://api.github.com/repos/dotCMS/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotCMS/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotCMS/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotCMS/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/{sha}","languages_url":"https://api.github.com/repos/dotCMS/core/languages","stargazers_url":"https://api.github.com/repos/dotCMS/core/stargazers","contributors_url":"https://api.github.com/repos/dotCMS/core/contributors","subscribers_url":"https://api.github.com/repos/dotCMS/core/subscribers","subscription_url":"https://api.github.com/repos/dotCMS/core/subscription","commits_url":"https://api.github.com/repos/dotCMS/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotCMS/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotCMS/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotCMS/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotCMS/core/contents/{+path}","compare_url":"https://api.github.com/repos/dotCMS/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotCMS/core/merges","archive_url":"https://api.github.com/repos/dotCMS/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotCMS/core/downloads","issues_url":"https://api.github.com/repos/dotCMS/core/issues{/number}","pulls_url":"https://api.github.com/repos/dotCMS/core/pulls{/number}","milestones_url":"https://api.github.com/repos/dotCMS/core/milestones{/number}","notifications_url":"https://api.github.com/repos/dotCMS/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotCMS/core/labels{/name}","releases_url":"https://api.github.com/repos/dotCMS/core/releases{/id}","deployments_url":"https://api.github.com/repos/dotCMS/core/deployments","created_at":"2012-03-15T15:24:14Z","updated_at":"2017-09-28T08:17:53Z","pushed_at":"2017-10-11T21:06:43Z","git_url":"git://github.com/dotCMS/core.git","ssh_url":"[email protected]:dotCMS/core.git","clone_url":"https://github.com/dotCMS/core.git","svn_url":"https://github.com/dotCMS/core","homepage":"http://dotcms.com","size":285923,"stargazers_count":326,"watchers_count":326,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":293,"mirror_url":null,"open_issues_count":1687,"forks":293,"open_issues":1687,"watchers":326,"default_branch":"master"}},"base":{"label":"dotCMS:master","ref":"master","sha":"aae67e25b27c4f12fd3507112d6cbf6a5606a7b9","user":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":3729629,"name":"core","full_name":"dotCMS/core","owner":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotCMS/core","description":"Source Code for dotCMS Java Enterprise Content Management System","fork":false,"url":"https://api.github.com/repos/dotCMS/core","forks_url":"https://api.github.com/repos/dotCMS/core/forks","keys_url":"https://api.github.com/repos/dotCMS/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotCMS/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotCMS/core/teams","hooks_url":"https://api.github.com/repos/dotCMS/core/hooks","issue_events_url":"https://api.github.com/repos/dotCMS/core/issues/events{/number}","events_url":"https://api.github.com/repos/dotCMS/core/events","assignees_url":"https://api.github.com/repos/dotCMS/core/assignees{/user}","branches_url":"https://api.github.com/repos/dotCMS/core/branches{/branch}","tags_url":"https://api.github.com/repos/dotCMS/core/tags","blobs_url":"https://api.github.com/repos/dotCMS/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotCMS/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotCMS/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotCMS/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/{sha}","languages_url":"https://api.github.com/repos/dotCMS/core/languages","stargazers_url":"https://api.github.com/repos/dotCMS/core/stargazers","contributors_url":"https://api.github.com/repos/dotCMS/core/contributors","subscribers_url":"https://api.github.com/repos/dotCMS/core/subscribers","subscription_url":"https://api.github.com/repos/dotCMS/core/subscription","commits_url":"https://api.github.com/repos/dotCMS/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotCMS/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotCMS/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotCMS/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotCMS/core/contents/{+path}","compare_url":"https://api.github.com/repos/dotCMS/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotCMS/core/merges","archive_url":"https://api.github.com/repos/dotCMS/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotCMS/core/downloads","issues_url":"https://api.github.com/repos/dotCMS/core/issues{/number}","pulls_url":"https://api.github.com/repos/dotCMS/core/pulls{/number}","milestones_url":"https://api.github.com/repos/dotCMS/core/milestones{/number}","notifications_url":"https://api.github.com/repos/dotCMS/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotCMS/core/labels{/name}","releases_url":"https://api.github.com/repos/dotCMS/core/releases{/id}","deployments_url":"https://api.github.com/repos/dotCMS/core/deployments","created_at":"2012-03-15T15:24:14Z","updated_at":"2017-09-28T08:17:53Z","pushed_at":"2017-10-11T21:06:43Z","git_url":"git://github.com/dotCMS/core.git","ssh_url":"[email protected]:dotCMS/core.git","clone_url":"https://github.com/dotCMS/core.git","svn_url":"https://github.com/dotCMS/core","homepage":"http://dotcms.com","size":285923,"stargazers_count":326,"watchers_count":326,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":293,"mirror_url":null,"open_issues_count":1687,"forks":293,"open_issues":1687,"watchers":326,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotCMS/core/pulls/12834"},"html":{"href":"https://github.com/dotCMS/core/pull/12834"},"issue":{"href":"https://api.github.com/repos/dotCMS/core/issues/12834"},"comments":{"href":"https://api.github.com/repos/dotCMS/core/issues/12834/comments"},"review_comments":{"href":"https://api.github.com/repos/dotCMS/core/pulls/12834/comments"},"review_comment":{"href":"https://api.github.com/repos/dotCMS/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotCMS/core/pulls/12834/commits"},"statuses":{"href":"https://api.github.com/repos/dotCMS/core/statuses/a54e9a126044602853987c3567c960fda32025db"}},"author_association":"CONTRIBUTOR"}} | {
"id": 3729629,
"name": "dotCMS/core",
"url": "https://api.github.com/repos/dotCMS/core"
} | {
"id": 19578350,
"login": "jdotcms",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19578350?",
"url": "https://api.github.com/users/jdotcms"
} | {
"id": 1005263,
"login": "dotCMS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1005263?",
"url": "https://api.github.com/orgs/dotCMS"
} | 2017-10-11T21:11:24 | 6704842372 | {"actor":{"display_login":"jdotcms"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotCMS/core/pulls/comments/125075974","pull_request_review_id":47433559,"id":125075974,"diff_hunk":"@@ -48,12 +22,15 @@\n import com.dotcms.repackage.org.glassfish.jersey.media.multipart.BodyPart;\n import com.dotcms.repackage.org.glassfish.jersey.media.multipart.ContentDisposition;\n import com.dotcms.repackage.org.glassfish.jersey.media.multipart.FormDataMultiPart;\n+import com.dotcms.rest.exception.mapper.ExceptionMapperUtil;\n+import com.dotcms.util.PaginationUtil;\n import com.dotmarketing.beans.Host;\n import com.dotmarketing.beans.Identifier;\n import com.dotmarketing.beans.Permission;\n import com.dotmarketing.business.APILocator;\n import com.dotmarketing.business.CacheLocator;\n import com.dotmarketing.business.FactoryLocator;\n+import com.dotmarketing.business.web.WebAPILocator;","path":"dotCMS/src/main/java/com/dotcms/rest/ContentResource.java","position":53,"original_position":53,"commit_id":"c89ec111b2150ab68223fa112f133228b9dcf7d3","original_commit_id":"c89ec111b2150ab68223fa112f133228b9dcf7d3","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars2.githubusercontent.com/u/19940114?v=3","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Avoid unused imports such as 'com.dotmarketing.business.web.WebAPILocator'](https://www.codacy.com/app/jgamba/core/pullRequest?prid=744743)","created_at":"2017-06-30T16:12:59Z","updated_at":"2017-06-30T16:12:59Z","html_url":"https://github.com/dotCMS/core/pull/12021#discussion_r125075974","pull_request_url":"https://api.github.com/repos/dotCMS/core/pulls/12021","_links":{"self":{"href":"https://api.github.com/repos/dotCMS/core/pulls/comments/125075974"},"html":{"href":"https://github.com/dotCMS/core/pull/12021#discussion_r125075974"},"pull_request":{"href":"https://api.github.com/repos/dotCMS/core/pulls/12021"}}},"pull_request":{"url":"https://api.github.com/repos/dotCMS/core/pulls/12021","id":128073901,"html_url":"https://github.com/dotCMS/core/pull/12021","diff_url":"https://github.com/dotCMS/core/pull/12021.diff","patch_url":"https://github.com/dotCMS/core/pull/12021.patch","issue_url":"https://api.github.com/repos/dotCMS/core/issues/12021","number":12021,"state":"open","locked":false,"title":"#12009 Added related methods to ContentResource","user":{"login":"jdotcms","id":19578350,"avatar_url":"https://avatars3.githubusercontent.com/u/19578350?v=3","gravatar_id":"","url":"https://api.github.com/users/jdotcms","html_url":"https://github.com/jdotcms","followers_url":"https://api.github.com/users/jdotcms/followers","following_url":"https://api.github.com/users/jdotcms/following{/other_user}","gists_url":"https://api.github.com/users/jdotcms/gists{/gist_id}","starred_url":"https://api.github.com/users/jdotcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdotcms/subscriptions","organizations_url":"https://api.github.com/users/jdotcms/orgs","repos_url":"https://api.github.com/users/jdotcms/repos","events_url":"https://api.github.com/users/jdotcms/events{/privacy}","received_events_url":"https://api.github.com/users/jdotcms/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-29T05:52:45Z","updated_at":"2017-06-30T16:12:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65b9f8a7625f97dc6b967c94f023764219fafbff","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotCMS/core/pulls/12021/commits","review_comments_url":"https://api.github.com/repos/dotCMS/core/pulls/12021/comments","review_comment_url":"https://api.github.com/repos/dotCMS/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotCMS/core/issues/12021/comments","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/c89ec111b2150ab68223fa112f133228b9dcf7d3","head":{"label":"dotCMS:issue-12009-content-related","ref":"issue-12009-content-related","sha":"c89ec111b2150ab68223fa112f133228b9dcf7d3","user":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars0.githubusercontent.com/u/1005263?v=3","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":3729629,"name":"core","full_name":"dotCMS/core","owner":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars0.githubusercontent.com/u/1005263?v=3","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotCMS/core","description":"Source Code for dotCMS Java Enterprise Content Management System","fork":false,"url":"https://api.github.com/repos/dotCMS/core","forks_url":"https://api.github.com/repos/dotCMS/core/forks","keys_url":"https://api.github.com/repos/dotCMS/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotCMS/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotCMS/core/teams","hooks_url":"https://api.github.com/repos/dotCMS/core/hooks","issue_events_url":"https://api.github.com/repos/dotCMS/core/issues/events{/number}","events_url":"https://api.github.com/repos/dotCMS/core/events","assignees_url":"https://api.github.com/repos/dotCMS/core/assignees{/user}","branches_url":"https://api.github.com/repos/dotCMS/core/branches{/branch}","tags_url":"https://api.github.com/repos/dotCMS/core/tags","blobs_url":"https://api.github.com/repos/dotCMS/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotCMS/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotCMS/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotCMS/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/{sha}","languages_url":"https://api.github.com/repos/dotCMS/core/languages","stargazers_url":"https://api.github.com/repos/dotCMS/core/stargazers","contributors_url":"https://api.github.com/repos/dotCMS/core/contributors","subscribers_url":"https://api.github.com/repos/dotCMS/core/subscribers","subscription_url":"https://api.github.com/repos/dotCMS/core/subscription","commits_url":"https://api.github.com/repos/dotCMS/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotCMS/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotCMS/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotCMS/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotCMS/core/contents/{+path}","compare_url":"https://api.github.com/repos/dotCMS/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotCMS/core/merges","archive_url":"https://api.github.com/repos/dotCMS/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotCMS/core/downloads","issues_url":"https://api.github.com/repos/dotCMS/core/issues{/number}","pulls_url":"https://api.github.com/repos/dotCMS/core/pulls{/number}","milestones_url":"https://api.github.com/repos/dotCMS/core/milestones{/number}","notifications_url":"https://api.github.com/repos/dotCMS/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotCMS/core/labels{/name}","releases_url":"https://api.github.com/repos/dotCMS/core/releases{/id}","deployments_url":"https://api.github.com/repos/dotCMS/core/deployments","created_at":"2012-03-15T15:24:14Z","updated_at":"2017-06-22T12:33:01Z","pushed_at":"2017-06-30T16:04:55Z","git_url":"git://github.com/dotCMS/core.git","ssh_url":"[email protected]:dotCMS/core.git","clone_url":"https://github.com/dotCMS/core.git","svn_url":"https://github.com/dotCMS/core","homepage":"http://dotcms.com","size":283847,"stargazers_count":310,"watchers_count":310,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":283,"mirror_url":null,"open_issues_count":1610,"forks":283,"open_issues":1610,"watchers":310,"default_branch":"master"}},"base":{"label":"dotCMS:master","ref":"master","sha":"e16ca6c0bcef969325e5102c1f9d6048b3825259","user":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars0.githubusercontent.com/u/1005263?v=3","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":3729629,"name":"core","full_name":"dotCMS/core","owner":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars0.githubusercontent.com/u/1005263?v=3","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotCMS/core","description":"Source Code for dotCMS Java Enterprise Content Management System","fork":false,"url":"https://api.github.com/repos/dotCMS/core","forks_url":"https://api.github.com/repos/dotCMS/core/forks","keys_url":"https://api.github.com/repos/dotCMS/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotCMS/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotCMS/core/teams","hooks_url":"https://api.github.com/repos/dotCMS/core/hooks","issue_events_url":"https://api.github.com/repos/dotCMS/core/issues/events{/number}","events_url":"https://api.github.com/repos/dotCMS/core/events","assignees_url":"https://api.github.com/repos/dotCMS/core/assignees{/user}","branches_url":"https://api.github.com/repos/dotCMS/core/branches{/branch}","tags_url":"https://api.github.com/repos/dotCMS/core/tags","blobs_url":"https://api.github.com/repos/dotCMS/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotCMS/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotCMS/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotCMS/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/{sha}","languages_url":"https://api.github.com/repos/dotCMS/core/languages","stargazers_url":"https://api.github.com/repos/dotCMS/core/stargazers","contributors_url":"https://api.github.com/repos/dotCMS/core/contributors","subscribers_url":"https://api.github.com/repos/dotCMS/core/subscribers","subscription_url":"https://api.github.com/repos/dotCMS/core/subscription","commits_url":"https://api.github.com/repos/dotCMS/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotCMS/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotCMS/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotCMS/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotCMS/core/contents/{+path}","compare_url":"https://api.github.com/repos/dotCMS/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotCMS/core/merges","archive_url":"https://api.github.com/repos/dotCMS/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotCMS/core/downloads","issues_url":"https://api.github.com/repos/dotCMS/core/issues{/number}","pulls_url":"https://api.github.com/repos/dotCMS/core/pulls{/number}","milestones_url":"https://api.github.com/repos/dotCMS/core/milestones{/number}","notifications_url":"https://api.github.com/repos/dotCMS/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotCMS/core/labels{/name}","releases_url":"https://api.github.com/repos/dotCMS/core/releases{/id}","deployments_url":"https://api.github.com/repos/dotCMS/core/deployments","created_at":"2012-03-15T15:24:14Z","updated_at":"2017-06-22T12:33:01Z","pushed_at":"2017-06-30T16:04:55Z","git_url":"git://github.com/dotCMS/core.git","ssh_url":"[email protected]:dotCMS/core.git","clone_url":"https://github.com/dotCMS/core.git","svn_url":"https://github.com/dotCMS/core","homepage":"http://dotcms.com","size":283847,"stargazers_count":310,"watchers_count":310,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":283,"mirror_url":null,"open_issues_count":1610,"forks":283,"open_issues":1610,"watchers":310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotCMS/core/pulls/12021"},"html":{"href":"https://github.com/dotCMS/core/pull/12021"},"issue":{"href":"https://api.github.com/repos/dotCMS/core/issues/12021"},"comments":{"href":"https://api.github.com/repos/dotCMS/core/issues/12021/comments"},"review_comments":{"href":"https://api.github.com/repos/dotCMS/core/pulls/12021/comments"},"review_comment":{"href":"https://api.github.com/repos/dotCMS/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotCMS/core/pulls/12021/commits"},"statuses":{"href":"https://api.github.com/repos/dotCMS/core/statuses/c89ec111b2150ab68223fa112f133228b9dcf7d3"}}}} | {
"id": 3729629,
"name": "dotCMS/core",
"url": "https://api.github.com/repos/dotCMS/core"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 1005263,
"login": "dotCMS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1005263?",
"url": "https://api.github.com/orgs/dotCMS"
} | 2017-06-30T16:12:59 | 6172625677 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotCMS/core/pulls/comments/129081953","pull_request_review_id":51819819,"id":129081953,"diff_hunk":"@@ -56,6 +63,24 @@ public void run() {\n \t\t\t\t\t}\n \t\t\t\t\tconnection.commit();\n \t\t\t\t}\n+\t\t\t\t \n+\t\t\t\tif(LicenseUtil.getLevel()==100 ){\n+\t\t\t\t if(noLicense==0){\n+\t\t\t\t noLicense=System.currentTimeMillis();","path":"dotCMS/src/main/java/com/dotcms/cluster/common/ClusterServerActionThread.java","position":32,"original_position":32,"commit_id":"c0b603d13f8138a747c4e2e4d521ee47437885a8","original_commit_id":"c0b603d13f8138a747c4e2e4d521ee47437885a8","user":{"login":"jenkins-dotcms","id":29232833,"avatar_url":"https://avatars2.githubusercontent.com/u/29232833?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkins-dotcms","html_url":"https://github.com/jenkins-dotcms","followers_url":"https://api.github.com/users/jenkins-dotcms/followers","following_url":"https://api.github.com/users/jenkins-dotcms/following{/other_user}","gists_url":"https://api.github.com/users/jenkins-dotcms/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins-dotcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins-dotcms/subscriptions","organizations_url":"https://api.github.com/users/jenkins-dotcms/orgs","repos_url":"https://api.github.com/users/jenkins-dotcms/repos","events_url":"https://api.github.com/users/jenkins-dotcms/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins-dotcms/received_events","type":"User","site_admin":false},"body":" Make the enclosing method \"static\" or remove this set. [](https://sonarcloud.io/coding_rules#rule_key=squid%3AS2696)\n","created_at":"2017-07-24T16:14:14Z","updated_at":"2017-07-24T16:14:15Z","html_url":"https://github.com/dotCMS/core/pull/12191#discussion_r129081953","pull_request_url":"https://api.github.com/repos/dotCMS/core/pulls/12191","_links":{"self":{"href":"https://api.github.com/repos/dotCMS/core/pulls/comments/129081953"},"html":{"href":"https://github.com/dotCMS/core/pull/12191#discussion_r129081953"},"pull_request":{"href":"https://api.github.com/repos/dotCMS/core/pulls/12191"}}},"pull_request":{"url":"https://api.github.com/repos/dotCMS/core/pulls/12191","id":132088325,"html_url":"https://github.com/dotCMS/core/pull/12191","diff_url":"https://github.com/dotCMS/core/pull/12191.diff","patch_url":"https://github.com/dotCMS/core/pull/12191.patch","issue_url":"https://api.github.com/repos/dotCMS/core/issues/12191","number":12191,"state":"open","locked":false,"title":"Issue 11938 simplify licensing","user":{"login":"wezell","id":934364,"avatar_url":"https://avatars2.githubusercontent.com/u/934364?v=4","gravatar_id":"","url":"https://api.github.com/users/wezell","html_url":"https://github.com/wezell","followers_url":"https://api.github.com/users/wezell/followers","following_url":"https://api.github.com/users/wezell/following{/other_user}","gists_url":"https://api.github.com/users/wezell/gists{/gist_id}","starred_url":"https://api.github.com/users/wezell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wezell/subscriptions","organizations_url":"https://api.github.com/users/wezell/orgs","repos_url":"https://api.github.com/users/wezell/repos","events_url":"https://api.github.com/users/wezell/events{/privacy}","received_events_url":"https://api.github.com/users/wezell/received_events","type":"User","site_admin":false},"body":"This is part of a pull to simplify our license code and has a ee counterpart.\r\n\r\nWhat this does:\r\n1. Updates the ServerAPI disallow writing new serverId except to create one create one if needed.\r\n\r\n2. Removes the legacy \"cache invalidations through db\" code of the DIST_JOURNAL of the legacy ClusterThread\r\n\r\n3.If a server goes unlicensed, it will pick a new license from the repo if one is available\r\n\r\n4. Config based license: Allows a license to be dropped into /dotSecure/license.dat and pickup up on startup.\r\n\r\n5. License packs: Maintains support for license packs as a means of distributed licensing distribution within a cluster.\r\n","created_at":"2017-07-24T16:12:23Z","updated_at":"2017-07-24T16:14:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b77ee7b3f70cfa8175ce9697272d0ef09680d975","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotCMS/core/pulls/12191/commits","review_comments_url":"https://api.github.com/repos/dotCMS/core/pulls/12191/comments","review_comment_url":"https://api.github.com/repos/dotCMS/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotCMS/core/issues/12191/comments","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/c0b603d13f8138a747c4e2e4d521ee47437885a8","head":{"label":"dotCMS:issue-11938-simplify-licening","ref":"issue-11938-simplify-licening","sha":"c0b603d13f8138a747c4e2e4d521ee47437885a8","user":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":3729629,"name":"core","full_name":"dotCMS/core","owner":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotCMS/core","description":"Source Code for dotCMS Java Enterprise Content Management System","fork":false,"url":"https://api.github.com/repos/dotCMS/core","forks_url":"https://api.github.com/repos/dotCMS/core/forks","keys_url":"https://api.github.com/repos/dotCMS/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotCMS/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotCMS/core/teams","hooks_url":"https://api.github.com/repos/dotCMS/core/hooks","issue_events_url":"https://api.github.com/repos/dotCMS/core/issues/events{/number}","events_url":"https://api.github.com/repos/dotCMS/core/events","assignees_url":"https://api.github.com/repos/dotCMS/core/assignees{/user}","branches_url":"https://api.github.com/repos/dotCMS/core/branches{/branch}","tags_url":"https://api.github.com/repos/dotCMS/core/tags","blobs_url":"https://api.github.com/repos/dotCMS/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotCMS/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotCMS/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotCMS/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/{sha}","languages_url":"https://api.github.com/repos/dotCMS/core/languages","stargazers_url":"https://api.github.com/repos/dotCMS/core/stargazers","contributors_url":"https://api.github.com/repos/dotCMS/core/contributors","subscribers_url":"https://api.github.com/repos/dotCMS/core/subscribers","subscription_url":"https://api.github.com/repos/dotCMS/core/subscription","commits_url":"https://api.github.com/repos/dotCMS/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotCMS/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotCMS/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotCMS/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotCMS/core/contents/{+path}","compare_url":"https://api.github.com/repos/dotCMS/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotCMS/core/merges","archive_url":"https://api.github.com/repos/dotCMS/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotCMS/core/downloads","issues_url":"https://api.github.com/repos/dotCMS/core/issues{/number}","pulls_url":"https://api.github.com/repos/dotCMS/core/pulls{/number}","milestones_url":"https://api.github.com/repos/dotCMS/core/milestones{/number}","notifications_url":"https://api.github.com/repos/dotCMS/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotCMS/core/labels{/name}","releases_url":"https://api.github.com/repos/dotCMS/core/releases{/id}","deployments_url":"https://api.github.com/repos/dotCMS/core/deployments","created_at":"2012-03-15T15:24:14Z","updated_at":"2017-07-23T21:19:11Z","pushed_at":"2017-07-24T16:12:23Z","git_url":"git://github.com/dotCMS/core.git","ssh_url":"[email protected]:dotCMS/core.git","clone_url":"https://github.com/dotCMS/core.git","svn_url":"https://github.com/dotCMS/core","homepage":"http://dotcms.com","size":283933,"stargazers_count":310,"watchers_count":310,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":288,"mirror_url":null,"open_issues_count":1653,"forks":288,"open_issues":1653,"watchers":310,"default_branch":"master"}},"base":{"label":"dotCMS:master","ref":"master","sha":"f49bdf82745833681f4d0a5e4a554dcd33d5f130","user":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":3729629,"name":"core","full_name":"dotCMS/core","owner":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotCMS/core","description":"Source Code for dotCMS Java Enterprise Content Management System","fork":false,"url":"https://api.github.com/repos/dotCMS/core","forks_url":"https://api.github.com/repos/dotCMS/core/forks","keys_url":"https://api.github.com/repos/dotCMS/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotCMS/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotCMS/core/teams","hooks_url":"https://api.github.com/repos/dotCMS/core/hooks","issue_events_url":"https://api.github.com/repos/dotCMS/core/issues/events{/number}","events_url":"https://api.github.com/repos/dotCMS/core/events","assignees_url":"https://api.github.com/repos/dotCMS/core/assignees{/user}","branches_url":"https://api.github.com/repos/dotCMS/core/branches{/branch}","tags_url":"https://api.github.com/repos/dotCMS/core/tags","blobs_url":"https://api.github.com/repos/dotCMS/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotCMS/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotCMS/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotCMS/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/{sha}","languages_url":"https://api.github.com/repos/dotCMS/core/languages","stargazers_url":"https://api.github.com/repos/dotCMS/core/stargazers","contributors_url":"https://api.github.com/repos/dotCMS/core/contributors","subscribers_url":"https://api.github.com/repos/dotCMS/core/subscribers","subscription_url":"https://api.github.com/repos/dotCMS/core/subscription","commits_url":"https://api.github.com/repos/dotCMS/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotCMS/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotCMS/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotCMS/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotCMS/core/contents/{+path}","compare_url":"https://api.github.com/repos/dotCMS/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotCMS/core/merges","archive_url":"https://api.github.com/repos/dotCMS/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotCMS/core/downloads","issues_url":"https://api.github.com/repos/dotCMS/core/issues{/number}","pulls_url":"https://api.github.com/repos/dotCMS/core/pulls{/number}","milestones_url":"https://api.github.com/repos/dotCMS/core/milestones{/number}","notifications_url":"https://api.github.com/repos/dotCMS/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotCMS/core/labels{/name}","releases_url":"https://api.github.com/repos/dotCMS/core/releases{/id}","deployments_url":"https://api.github.com/repos/dotCMS/core/deployments","created_at":"2012-03-15T15:24:14Z","updated_at":"2017-07-23T21:19:11Z","pushed_at":"2017-07-24T16:12:23Z","git_url":"git://github.com/dotCMS/core.git","ssh_url":"[email protected]:dotCMS/core.git","clone_url":"https://github.com/dotCMS/core.git","svn_url":"https://github.com/dotCMS/core","homepage":"http://dotcms.com","size":283933,"stargazers_count":310,"watchers_count":310,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":288,"mirror_url":null,"open_issues_count":1653,"forks":288,"open_issues":1653,"watchers":310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotCMS/core/pulls/12191"},"html":{"href":"https://github.com/dotCMS/core/pull/12191"},"issue":{"href":"https://api.github.com/repos/dotCMS/core/issues/12191"},"comments":{"href":"https://api.github.com/repos/dotCMS/core/issues/12191/comments"},"review_comments":{"href":"https://api.github.com/repos/dotCMS/core/pulls/12191/comments"},"review_comment":{"href":"https://api.github.com/repos/dotCMS/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotCMS/core/pulls/12191/commits"},"statuses":{"href":"https://api.github.com/repos/dotCMS/core/statuses/c0b603d13f8138a747c4e2e4d521ee47437885a8"}}}} | {
"id": 3729629,
"name": "dotCMS/core",
"url": "https://api.github.com/repos/dotCMS/core"
} | {
"id": 29232833,
"login": "jenkins-dotcms",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29232833?",
"url": "https://api.github.com/users/jenkins-dotcms"
} | {
"id": 1005263,
"login": "dotCMS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1005263?",
"url": "https://api.github.com/orgs/dotCMS"
} | 2017-07-24T16:14:14 | 6316803505 | {"actor":{"display_login":"jenkins-dotcms"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/101698700","pull_request_review_id":22435116,"id":101698700,"diff_hunk":"@@ -249,10 +249,51 @@ private void SetUrl()\n }\n \n EventSourceTrace(\"Url: {0}\", requestUri);\n- SetCurlOption(CURLoption.CURLOPT_URL, requestUri.AbsoluteUri);\n+ if (requestUri.Host != requestUri.IdnHost)\n+ {\n+ SetCurlOption(CURLoption.CURLOPT_URL, ReplaceHostWithIdnHost(requestUri.AbsoluteUri, requestUri.Host, requestUri.IdnHost));\n+ }\n+ else\n+ {\n+ SetCurlOption(CURLoption.CURLOPT_URL, requestUri.AbsoluteUri);\n+ }\n+\n SetCurlOption(CURLoption.CURLOPT_PROTOCOLS, (long)(CurlProtocols.CURLPROTO_HTTP | CurlProtocols.CURLPROTO_HTTPS));\n }\n \n+ private unsafe string ReplaceHostWithIdnHost(string absoluteUri, string host, string idnHost)\n+ {\n+ int start = absoluteUri.IndexOf(host);","path":"src/System.Net.Http/src/System/Net/Http/Unix/CurlHandler.EasyRequest.cs","position":19,"original_position":19,"commit_id":"52de4fdbd8dc87411800978099ab62fcdb9052b6","original_commit_id":"52de4fdbd8dc87411800978099ab62fcdb9052b6","user":{"login":"justinvp","id":710598,"avatar_url":"https://avatars.githubusercontent.com/u/710598?v=3","gravatar_id":"","url":"https://api.github.com/users/justinvp","html_url":"https://github.com/justinvp","followers_url":"https://api.github.com/users/justinvp/followers","following_url":"https://api.github.com/users/justinvp/following{/other_user}","gists_url":"https://api.github.com/users/justinvp/gists{/gist_id}","starred_url":"https://api.github.com/users/justinvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinvp/subscriptions","organizations_url":"https://api.github.com/users/justinvp/orgs","repos_url":"https://api.github.com/users/justinvp/repos","events_url":"https://api.github.com/users/justinvp/events{/privacy}","received_events_url":"https://api.github.com/users/justinvp/received_events","type":"User","site_admin":false},"body":"Can `requestUri` have a username or password component, and if so, what if one of those are equal to host (e.g. `\"http://host:pass@host/path\"`)? If that can happen, the code below will replace the first instance it finds, which would be the username/password instead of the host. I wonder if using `UriBuilder` to replace the host would work better (despite it likely allocating more). Something like (typing this on my phone; haven't actually tested it):\r\n\r\n```c#\r\nstring host = requestUri.Host;\r\nstring idnHost = requestUri.IdnHost;\r\nstring absoluteUri = host == idnHost ?\r\n requestUri.AbsoluteUri :\r\n new UriBuilder(requestUri) { Host = idnHost }.Uri.AbsoluteUri;\r\nSetCurlOption(CURLoption.CURLOPT_URL, absoluteUri);\r\n```","created_at":"2017-02-17T07:28:05Z","updated_at":"2017-02-17T07:28:05Z","html_url":"https://github.com/dotnet/corefx/pull/16253#discussion_r101698700","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/16253","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/101698700"},"html":{"href":"https://github.com/dotnet/corefx/pull/16253#discussion_r101698700"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/16253"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/16253","id":106662897,"html_url":"https://github.com/dotnet/corefx/pull/16253","diff_url":"https://github.com/dotnet/corefx/pull/16253.diff","patch_url":"https://github.com/dotnet/corefx/pull/16253.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/16253","number":16253,"state":"open","locked":false,"title":"Change host to idnhost on curlhandler.","user":{"login":"Priya91","id":7853870,"avatar_url":"https://avatars.githubusercontent.com/u/7853870?v=3","gravatar_id":"","url":"https://api.github.com/users/Priya91","html_url":"https://github.com/Priya91","followers_url":"https://api.github.com/users/Priya91/followers","following_url":"https://api.github.com/users/Priya91/following{/other_user}","gists_url":"https://api.github.com/users/Priya91/gists{/gist_id}","starred_url":"https://api.github.com/users/Priya91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Priya91/subscriptions","organizations_url":"https://api.github.com/users/Priya91/orgs","repos_url":"https://api.github.com/users/Priya91/repos","events_url":"https://api.github.com/users/Priya91/events{/privacy}","received_events_url":"https://api.github.com/users/Priya91/received_events","type":"User","site_admin":false},"body":"cc @stephentoub @davidsh @CIPop @geoffkizer @karelz \r\n\r\nVerified with the URL provided in the issue, and the request is successfully parsed by curl. May require setting up a unicode Url on azure for automated testing similar to the echo servers.\r\n\r\nThe other unicode chars in the IRI are percent-encoded while constructing the Uri in the Uri class, hence only handling the host part here.\r\n\r\nfixes #11213 ","created_at":"2017-02-17T03:37:43Z","updated_at":"2017-02-17T07:28:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dc10434b5e9fb855a401d55fadf6aad344bf751","assignee":{"login":"Priya91","id":7853870,"avatar_url":"https://avatars.githubusercontent.com/u/7853870?v=3","gravatar_id":"","url":"https://api.github.com/users/Priya91","html_url":"https://github.com/Priya91","followers_url":"https://api.github.com/users/Priya91/followers","following_url":"https://api.github.com/users/Priya91/following{/other_user}","gists_url":"https://api.github.com/users/Priya91/gists{/gist_id}","starred_url":"https://api.github.com/users/Priya91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Priya91/subscriptions","organizations_url":"https://api.github.com/users/Priya91/orgs","repos_url":"https://api.github.com/users/Priya91/repos","events_url":"https://api.github.com/users/Priya91/events{/privacy}","received_events_url":"https://api.github.com/users/Priya91/received_events","type":"User","site_admin":false},"assignees":[{"login":"Priya91","id":7853870,"avatar_url":"https://avatars.githubusercontent.com/u/7853870?v=3","gravatar_id":"","url":"https://api.github.com/users/Priya91","html_url":"https://github.com/Priya91","followers_url":"https://api.github.com/users/Priya91/followers","following_url":"https://api.github.com/users/Priya91/following{/other_user}","gists_url":"https://api.github.com/users/Priya91/gists{/gist_id}","starred_url":"https://api.github.com/users/Priya91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Priya91/subscriptions","organizations_url":"https://api.github.com/users/Priya91/orgs","repos_url":"https://api.github.com/users/Priya91/repos","events_url":"https://api.github.com/users/Priya91/events{/privacy}","received_events_url":"https://api.github.com/users/Priya91/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/16253/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/16253/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/16253/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/52de4fdbd8dc87411800978099ab62fcdb9052b6","head":{"label":"Priya91:curlhandler","ref":"curlhandler","sha":"52de4fdbd8dc87411800978099ab62fcdb9052b6","user":{"login":"Priya91","id":7853870,"avatar_url":"https://avatars.githubusercontent.com/u/7853870?v=3","gravatar_id":"","url":"https://api.github.com/users/Priya91","html_url":"https://github.com/Priya91","followers_url":"https://api.github.com/users/Priya91/followers","following_url":"https://api.github.com/users/Priya91/following{/other_user}","gists_url":"https://api.github.com/users/Priya91/gists{/gist_id}","starred_url":"https://api.github.com/users/Priya91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Priya91/subscriptions","organizations_url":"https://api.github.com/users/Priya91/orgs","repos_url":"https://api.github.com/users/Priya91/repos","events_url":"https://api.github.com/users/Priya91/events{/privacy}","received_events_url":"https://api.github.com/users/Priya91/received_events","type":"User","site_admin":false},"repo":{"id":27062349,"name":"corefx-1","full_name":"Priya91/corefx-1","owner":{"login":"Priya91","id":7853870,"avatar_url":"https://avatars.githubusercontent.com/u/7853870?v=3","gravatar_id":"","url":"https://api.github.com/users/Priya91","html_url":"https://github.com/Priya91","followers_url":"https://api.github.com/users/Priya91/followers","following_url":"https://api.github.com/users/Priya91/following{/other_user}","gists_url":"https://api.github.com/users/Priya91/gists{/gist_id}","starred_url":"https://api.github.com/users/Priya91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Priya91/subscriptions","organizations_url":"https://api.github.com/users/Priya91/orgs","repos_url":"https://api.github.com/users/Priya91/repos","events_url":"https://api.github.com/users/Priya91/events{/privacy}","received_events_url":"https://api.github.com/users/Priya91/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Priya91/corefx-1","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/Priya91/corefx-1","forks_url":"https://api.github.com/repos/Priya91/corefx-1/forks","keys_url":"https://api.github.com/repos/Priya91/corefx-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Priya91/corefx-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Priya91/corefx-1/teams","hooks_url":"https://api.github.com/repos/Priya91/corefx-1/hooks","issue_events_url":"https://api.github.com/repos/Priya91/corefx-1/issues/events{/number}","events_url":"https://api.github.com/repos/Priya91/corefx-1/events","assignees_url":"https://api.github.com/repos/Priya91/corefx-1/assignees{/user}","branches_url":"https://api.github.com/repos/Priya91/corefx-1/branches{/branch}","tags_url":"https://api.github.com/repos/Priya91/corefx-1/tags","blobs_url":"https://api.github.com/repos/Priya91/corefx-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Priya91/corefx-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Priya91/corefx-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/Priya91/corefx-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Priya91/corefx-1/statuses/{sha}","languages_url":"https://api.github.com/repos/Priya91/corefx-1/languages","stargazers_url":"https://api.github.com/repos/Priya91/corefx-1/stargazers","contributors_url":"https://api.github.com/repos/Priya91/corefx-1/contributors","subscribers_url":"https://api.github.com/repos/Priya91/corefx-1/subscribers","subscription_url":"https://api.github.com/repos/Priya91/corefx-1/subscription","commits_url":"https://api.github.com/repos/Priya91/corefx-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/Priya91/corefx-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/Priya91/corefx-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/Priya91/corefx-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/Priya91/corefx-1/contents/{+path}","compare_url":"https://api.github.com/repos/Priya91/corefx-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Priya91/corefx-1/merges","archive_url":"https://api.github.com/repos/Priya91/corefx-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Priya91/corefx-1/downloads","issues_url":"https://api.github.com/repos/Priya91/corefx-1/issues{/number}","pulls_url":"https://api.github.com/repos/Priya91/corefx-1/pulls{/number}","milestones_url":"https://api.github.com/repos/Priya91/corefx-1/milestones{/number}","notifications_url":"https://api.github.com/repos/Priya91/corefx-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Priya91/corefx-1/labels{/name}","releases_url":"https://api.github.com/repos/Priya91/corefx-1/releases{/id}","deployments_url":"https://api.github.com/repos/Priya91/corefx-1/deployments","created_at":"2014-11-24T05:35:16Z","updated_at":"2016-03-15T18:06:54Z","pushed_at":"2017-02-17T03:30:35Z","git_url":"git://github.com/Priya91/corefx-1.git","ssh_url":"[email protected]:Priya91/corefx-1.git","clone_url":"https://github.com/Priya91/corefx-1.git","svn_url":"https://github.com/Priya91/corefx-1","homepage":"","size":131147,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"b02fbd79fd4782f8fd92a45e0622a15dfd22aed2","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2017-02-17T03:27:35Z","pushed_at":"2017-02-17T05:34:21Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"[email protected]:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":133828,"stargazers_count":11264,"watchers_count":11264,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2924,"mirror_url":null,"open_issues_count":1404,"forks":2924,"open_issues":1404,"watchers":11264,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/16253"},"html":{"href":"https://github.com/dotnet/corefx/pull/16253"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/16253"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/16253/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/16253/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/16253/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/52de4fdbd8dc87411800978099ab62fcdb9052b6"}}}} | {
"id": 26295345,
"name": "dotnet/corefx",
"url": "https://api.github.com/repos/dotnet/corefx"
} | {
"id": 710598,
"login": "justinvp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/710598?",
"url": "https://api.github.com/users/justinvp"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2017-02-17T07:28:05 | 5342292829 | {"actor":{"display_login":"justinvp"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/106819754","pull_request_review_id":27759919,"id":106819754,"diff_hunk":"@@ -142,150 +140,186 @@ internal override bool IsInsertionTrigger(SourceText text, int characterPosition\n return items;\n }\n \n- private IEnumerable<CompletionItem> GetTopLevelSingleUseNames(DocumentationCommentTriviaSyntax parentTrivia)\n+ private bool IsAttributeNameContext(SyntaxToken token, int position, out string elementName, out ISet<string> attributeNames)\n {\n- var names = new HashSet<string>(new[] { SummaryTagName, RemarksTagName, ExampleTagName, CompletionListTagName });\n+ elementName = null;\n \n- RemoveExistingTags(parentTrivia, names, (x) => x.StartTag.Name.LocalName.ValueText);\n+ if (token.IsKind(SyntaxKind.XmlTextLiteralToken) && string.IsNullOrWhiteSpace(token.Text))\n+ {\n+ // Unlike VB, the C# lexer has a preference for leading trivia. In the following example...\n+ //\n+ // /// <exception $$\n+ //\n+ // ...the trailing whitespace will not be attached as trivia to any node. Instead it will\n+ // be treated as an independent XmlTextLiteralToken, so skip backwards by one token.\n+ token = token.GetPreviousToken();\n+ }\n \n- return names.Select(GetItem);\n- }\n+ // Handle the <elem$$ case by going back one token (the subsequent checks need to account for this)\n+ token = token.GetPreviousTokenIfTouchingWord(position);\n \n- private void RemoveExistingTags(DocumentationCommentTriviaSyntax parentTrivia, ISet<string> names, Func<XmlElementSyntax, string> selector)\n- {\n- if (parentTrivia != null)\n+ SyntaxList<XmlAttributeSyntax> attributes = default(SyntaxList<XmlAttributeSyntax>);\n+\n+ if (token.IsKind(SyntaxKind.IdentifierToken) && token.IsParentKind(SyntaxKind.XmlName))\n+ {\n+ // <elem $$\n+ // <elem attr$$\n+ elementName = GetElementNameAndAttributes(token.Parent.Parent, out attributes);\n+ }\n+ else if (token.IsParentKind(SyntaxKind.XmlCrefAttribute) ||\n+ token.IsParentKind(SyntaxKind.XmlNameAttribute) ||\n+ token.IsParentKind(SyntaxKind.XmlTextAttribute))\n {\n- foreach (var node in parentTrivia.Content)\n+ // <elem attr=\"\" $$\n+ // <elem attr=\"\" $$attr\t\n+ // <elem attr=\"\" attr$$\n+ var attributeSyntax = (XmlAttributeSyntax)token.Parent;\n+\n+ if (token == attributeSyntax.EndQuoteToken)\n {\n- var element = node as XmlElementSyntax;\n- if (element != null)\n- {\n- names.Remove(selector(element));\n- }\n+ elementName = GetElementNameAndAttributes(attributeSyntax.Parent, out attributes);\n }\n }\n+\n+ attributeNames = attributes.Select(GetAttributeName).ToSet();\n+ return elementName != null;\n }\n \n- private IEnumerable<CompletionItem> GetTagsForSymbol(ISymbol symbol, DocumentationCommentTriviaSyntax trivia)\n+ private string GetElementNameAndAttributes(SyntaxNode node, out SyntaxList<XmlAttributeSyntax> attributes)\n {\n- if (symbol is IMethodSymbol method)\n- {\n- return GetTagsForMethod(method, trivia);\n- }\n-\n- if (symbol is IPropertySymbol property)\n- {\n- return GetTagsForProperty(property, trivia);\n- }\n+ XmlNameSyntax nameSyntax;\n \n- if (symbol is INamedTypeSymbol namedType)\n+ switch (node.Kind())\n {\n- return GetTagsForType(namedType, trivia);\n+ case SyntaxKind.XmlEmptyElement:\n+ var emptyElementSyntax = (XmlEmptyElementSyntax)node;\n+ nameSyntax = emptyElementSyntax.Name;\n+ attributes = emptyElementSyntax.Attributes;\n+ break;\n+\n+ case SyntaxKind.XmlElement:\n+ node = ((XmlElementSyntax)node).StartTag;\n+ goto case SyntaxKind.XmlElementStartTag;\n+\n+ case SyntaxKind.XmlElementStartTag:\n+ var startTagSyntax = (XmlElementStartTagSyntax)node;\n+ nameSyntax = startTagSyntax.Name;\n+ attributes = startTagSyntax.Attributes;\n+ break;\n+\n+ default:\n+ nameSyntax = null;\n+ attributes = default(SyntaxList<XmlAttributeSyntax>);\n+ break;\n }\n \n- return SpecializedCollections.EmptyEnumerable<CompletionItem>();\n+ return nameSyntax?.LocalName.ValueText;\n }\n \n- private IEnumerable<CompletionItem> GetTagsForType(INamedTypeSymbol symbol, DocumentationCommentTriviaSyntax trivia)\n+ private bool IsAttributeValueContext(SyntaxToken token, out string tagName, out string attributeName)\n {\n- var items = new List<CompletionItem>();\n-\n- var typeParameters = symbol.TypeParameters.Select(p => p.Name).ToSet();\n+ XmlAttributeSyntax attributeSyntax = null;\n \n- RemoveExistingTags(trivia, typeParameters, x => AttributeSelector(x, TypeParamTagName));\n+ if (token.IsParentKind(SyntaxKind.IdentifierName) && token.Parent.IsParentKind(SyntaxKind.XmlNameAttribute))\n+ {\n+ // name=\"bar$$\n+ attributeSyntax = (XmlNameAttributeSyntax)token.Parent.Parent;\n+ }\n+ else if (token.IsKind(SyntaxKind.XmlTextLiteralToken) && token.IsParentKind(SyntaxKind.XmlTextAttribute))\n+ {\n+ // foo=\"bar$$","path":"src/Features/CSharp/Portable/Completion/CompletionProviders/XmlDocCommentCompletionProvider.cs","position":256,"original_position":256,"commit_id":"bd66c00a859cb36c5f2e83962a5ec34597c70a02","original_commit_id":"bd66c00a859cb36c5f2e83962a5ec34597c70a02","user":{"login":"CyrusNajmabadi","id":4564579,"avatar_url":"https://avatars0.githubusercontent.com/u/4564579?v=3","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"body":"i'm confused. This comment seems identical to the one above. How are you distinguishing these cases?","created_at":"2017-03-19T21:47:43Z","updated_at":"2017-03-19T21:47:43Z","html_url":"https://github.com/dotnet/roslyn/pull/17970#discussion_r106819754","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/17970","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/106819754"},"html":{"href":"https://github.com/dotnet/roslyn/pull/17970#discussion_r106819754"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/17970"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/17970","id":111457208,"html_url":"https://github.com/dotnet/roslyn/pull/17970","diff_url":"https://github.com/dotnet/roslyn/pull/17970.diff","patch_url":"https://github.com/dotnet/roslyn/pull/17970.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/17970","number":17970,"state":"open","locked":false,"title":"XML doc comment completion fixes","user":{"login":"lorcanmooney","id":13181165,"avatar_url":"https://avatars0.githubusercontent.com/u/13181165?v=3","gravatar_id":"","url":"https://api.github.com/users/lorcanmooney","html_url":"https://github.com/lorcanmooney","followers_url":"https://api.github.com/users/lorcanmooney/followers","following_url":"https://api.github.com/users/lorcanmooney/following{/other_user}","gists_url":"https://api.github.com/users/lorcanmooney/gists{/gist_id}","starred_url":"https://api.github.com/users/lorcanmooney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorcanmooney/subscriptions","organizations_url":"https://api.github.com/users/lorcanmooney/orgs","repos_url":"https://api.github.com/users/lorcanmooney/repos","events_url":"https://api.github.com/users/lorcanmooney/events{/privacy}","received_events_url":"https://api.github.com/users/lorcanmooney/received_events","type":"User","site_admin":false},"body":"A handful of fixes and features for XML doc completion. Also, where possible, I've factored out duplicated logic from the language-specific and into the base class.\r\n- Closes #11489, adding support for a more fluid completion experience around attributes and values. This changes the behaviour of `<space>` when committing items. See #11489 for the discussion, and a description of the new behaviour.\r\n- Closes #11490, adding support for the `see` `langword` attribute and suggesting keywords for the current language.\r\n- Fixes #8627, adding `returns` to the completion list for properties with getters.\r\n- Fixes a few issues that prevented suggestions for the `name` attribute in `[type]param[ref]` tags.\r\n- Adds support for suggesting the possible `list` `type` values.\r\n- Fixes some inconsistencies between C# and VB when suggesting top-level tags, and which tags are considered single-use vs. repeatable.\r\n- Fixes an issue in VB where `value` and `returns` would be suggested even if the tags are already present.\r\n- Fixes #17872, including all generic parameters in the symbol container hierarchy for `typeparamref` tags.\r\n\r\nThe commits are fairly logical and self-contained, so reading them one-by-one might make the review easier.","created_at":"2017-03-19T16:43:34Z","updated_at":"2017-03-19T21:47:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8204322eb19ca6fc972ee5194c8040ff941d361a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/17970/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/17970/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/17970/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/bd66c00a859cb36c5f2e83962a5ec34597c70a02","head":{"label":"lorcanmooney:xmldoc-attributes","ref":"xmldoc-attributes","sha":"bd66c00a859cb36c5f2e83962a5ec34597c70a02","user":{"login":"lorcanmooney","id":13181165,"avatar_url":"https://avatars0.githubusercontent.com/u/13181165?v=3","gravatar_id":"","url":"https://api.github.com/users/lorcanmooney","html_url":"https://github.com/lorcanmooney","followers_url":"https://api.github.com/users/lorcanmooney/followers","following_url":"https://api.github.com/users/lorcanmooney/following{/other_user}","gists_url":"https://api.github.com/users/lorcanmooney/gists{/gist_id}","starred_url":"https://api.github.com/users/lorcanmooney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorcanmooney/subscriptions","organizations_url":"https://api.github.com/users/lorcanmooney/orgs","repos_url":"https://api.github.com/users/lorcanmooney/repos","events_url":"https://api.github.com/users/lorcanmooney/events{/privacy}","received_events_url":"https://api.github.com/users/lorcanmooney/received_events","type":"User","site_admin":false},"repo":{"id":48291854,"name":"roslyn","full_name":"lorcanmooney/roslyn","owner":{"login":"lorcanmooney","id":13181165,"avatar_url":"https://avatars0.githubusercontent.com/u/13181165?v=3","gravatar_id":"","url":"https://api.github.com/users/lorcanmooney","html_url":"https://github.com/lorcanmooney","followers_url":"https://api.github.com/users/lorcanmooney/followers","following_url":"https://api.github.com/users/lorcanmooney/following{/other_user}","gists_url":"https://api.github.com/users/lorcanmooney/gists{/gist_id}","starred_url":"https://api.github.com/users/lorcanmooney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorcanmooney/subscriptions","organizations_url":"https://api.github.com/users/lorcanmooney/orgs","repos_url":"https://api.github.com/users/lorcanmooney/repos","events_url":"https://api.github.com/users/lorcanmooney/events{/privacy}","received_events_url":"https://api.github.com/users/lorcanmooney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lorcanmooney/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/lorcanmooney/roslyn","forks_url":"https://api.github.com/repos/lorcanmooney/roslyn/forks","keys_url":"https://api.github.com/repos/lorcanmooney/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lorcanmooney/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lorcanmooney/roslyn/teams","hooks_url":"https://api.github.com/repos/lorcanmooney/roslyn/hooks","issue_events_url":"https://api.github.com/repos/lorcanmooney/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/lorcanmooney/roslyn/events","assignees_url":"https://api.github.com/repos/lorcanmooney/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/lorcanmooney/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/lorcanmooney/roslyn/tags","blobs_url":"https://api.github.com/repos/lorcanmooney/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lorcanmooney/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lorcanmooney/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/lorcanmooney/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lorcanmooney/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/lorcanmooney/roslyn/languages","stargazers_url":"https://api.github.com/repos/lorcanmooney/roslyn/stargazers","contributors_url":"https://api.github.com/repos/lorcanmooney/roslyn/contributors","subscribers_url":"https://api.github.com/repos/lorcanmooney/roslyn/subscribers","subscription_url":"https://api.github.com/repos/lorcanmooney/roslyn/subscription","commits_url":"https://api.github.com/repos/lorcanmooney/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/lorcanmooney/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/lorcanmooney/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/lorcanmooney/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/lorcanmooney/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/lorcanmooney/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lorcanmooney/roslyn/merges","archive_url":"https://api.github.com/repos/lorcanmooney/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lorcanmooney/roslyn/downloads","issues_url":"https://api.github.com/repos/lorcanmooney/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/lorcanmooney/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/lorcanmooney/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/lorcanmooney/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lorcanmooney/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/lorcanmooney/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/lorcanmooney/roslyn/deployments","created_at":"2015-12-19T17:57:32Z","updated_at":"2017-03-19T16:34:34Z","pushed_at":"2017-03-19T20:55:48Z","git_url":"git://github.com/lorcanmooney/roslyn.git","ssh_url":"[email protected]:lorcanmooney/roslyn.git","clone_url":"https://github.com/lorcanmooney/roslyn.git","svn_url":"https://github.com/lorcanmooney/roslyn","homepage":"","size":201022,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"5f417ac355936b895446d623359441fdc5d2be1f","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2017-03-19T21:37:37Z","pushed_at":"2017-03-19T20:55:50Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"[email protected]:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":203132,"stargazers_count":7225,"watchers_count":7225,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1735,"mirror_url":null,"open_issues_count":3667,"forks":1735,"open_issues":3667,"watchers":7225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/17970"},"html":{"href":"https://github.com/dotnet/roslyn/pull/17970"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/17970"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/17970/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/17970/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/17970/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/bd66c00a859cb36c5f2e83962a5ec34597c70a02"}}}} | {
"id": 29078997,
"name": "dotnet/roslyn",
"url": "https://api.github.com/repos/dotnet/roslyn"
} | {
"id": 4564579,
"login": "CyrusNajmabadi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4564579?",
"url": "https://api.github.com/users/CyrusNajmabadi"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2017-03-19T21:47:43 | 5522230589 | {"actor":{"display_login":"CyrusNajmabadi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/111010916","pull_request_review_id":32225188,"id":111010916,"diff_hunk":"@@ -126,8 +126,14 @@ mdToken Assembler::ResolveClassRef(mdToken tkResScope, __in __nullterminated con\n }\n return tkRet;\n }\n- else // needs to be resolved\n- if(!m_fIsMscorlib) tkResScope = GetBaseAsmRef();\n+ else { // needs to be resolved","path":"src/ilasm/assembler.cpp","position":null,"original_position":6,"commit_id":"2bbeec193b892fdb7dbd2f2c3672db01d8b53be5","original_commit_id":"de5ce37dce2558bdf4e30f27ebb4eea3db521bc0","user":{"login":"rartemev","id":25832893,"avatar_url":"https://avatars1.githubusercontent.com/u/25832893?v=3","gravatar_id":"","url":"https://api.github.com/users/rartemev","html_url":"https://github.com/rartemev","followers_url":"https://api.github.com/users/rartemev/followers","following_url":"https://api.github.com/users/rartemev/following{/other_user}","gists_url":"https://api.github.com/users/rartemev/gists{/gist_id}","starred_url":"https://api.github.com/users/rartemev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rartemev/subscriptions","organizations_url":"https://api.github.com/users/rartemev/orgs","repos_url":"https://api.github.com/users/rartemev/repos","events_url":"https://api.github.com/users/rartemev/events{/privacy}","received_events_url":"https://api.github.com/users/rartemev/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2017-04-11T20:56:35Z","updated_at":"2017-04-11T20:56:35Z","html_url":"https://github.com/dotnet/coreclr/pull/10878#discussion_r111010916","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/10878","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/111010916"},"html":{"href":"https://github.com/dotnet/coreclr/pull/10878#discussion_r111010916"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/10878"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/10878","id":115217511,"html_url":"https://github.com/dotnet/coreclr/pull/10878","diff_url":"https://github.com/dotnet/coreclr/pull/10878.diff","patch_url":"https://github.com/dotnet/coreclr/pull/10878.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/10878","number":10878,"state":"open","locked":false,"title":"Changes for issue #10595. Handle assembly references through alias in the correct way.","user":{"login":"rartemev","id":25832893,"avatar_url":"https://avatars1.githubusercontent.com/u/25832893?v=3","gravatar_id":"","url":"https://api.github.com/users/rartemev","html_url":"https://github.com/rartemev","followers_url":"https://api.github.com/users/rartemev/followers","following_url":"https://api.github.com/users/rartemev/following{/other_user}","gists_url":"https://api.github.com/users/rartemev/gists{/gist_id}","starred_url":"https://api.github.com/users/rartemev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rartemev/subscriptions","organizations_url":"https://api.github.com/users/rartemev/orgs","repos_url":"https://api.github.com/users/rartemev/repos","events_url":"https://api.github.com/users/rartemev/events{/privacy}","received_events_url":"https://api.github.com/users/rartemev/received_events","type":"User","site_admin":false},"body":"Changes for issue #10595. Handle assembly references through alias in the correct way.\r\n\r\nildasm output for sample from issue description.\r\n\r\n\r\n```\r\n// Microsoft (R) .NET Framework IL Disassembler. Version 4.5.22220.0\r\n\r\n// Metadata version: v4.0.22220\r\n.assembly extern System.Runtime\r\n{\r\n .ver 0:0:0:0\r\n}\r\n.assembly TestAssembly\r\n{\r\n .ver 0:0:0:0\r\n}\r\n.module test1.dll\r\n// MVID: {FA8E4A92-EB5D-4875-9A46-218805862D57}\r\n.imagebase 0x00400000\r\n.file alignment 0x00000200\r\n.stackreserve 0x00100000\r\n.subsystem 0x0003 // WINDOWS_CUI\r\n.corflags 0x00000001 // ILONLY\r\n// Image base: 0x00000226F5820000\r\n\r\n// ================== GLOBAL METHODS =========================\r\n\r\n.method privatescope static void Main$PST06000001() cil managed\r\n{\r\n .entrypoint\r\n // Code size 7 (0x7)\r\n .maxstack 8\r\n IL_0000: newobj instance void [System.Runtime]System.Object::.ctor()\r\n IL_0005: pop\r\n IL_0006: ret\r\n} // end of global method Main\r\n\r\n\r\n// =============================================================\r\n\r\n// *********** DISASSEMBLY COMPLETE ***********************\r\n```","created_at":"2017-04-11T00:15:33Z","updated_at":"2017-04-11T20:56:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3b635fabc0114f8707ea5002d7e878f782496f8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/10878/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/10878/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/10878/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/2bbeec193b892fdb7dbd2f2c3672db01d8b53be5","head":{"label":"rartemev:ilasm_reference_aliasing_fix","ref":"ilasm_reference_aliasing_fix","sha":"2bbeec193b892fdb7dbd2f2c3672db01d8b53be5","user":{"login":"rartemev","id":25832893,"avatar_url":"https://avatars1.githubusercontent.com/u/25832893?v=3","gravatar_id":"","url":"https://api.github.com/users/rartemev","html_url":"https://github.com/rartemev","followers_url":"https://api.github.com/users/rartemev/followers","following_url":"https://api.github.com/users/rartemev/following{/other_user}","gists_url":"https://api.github.com/users/rartemev/gists{/gist_id}","starred_url":"https://api.github.com/users/rartemev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rartemev/subscriptions","organizations_url":"https://api.github.com/users/rartemev/orgs","repos_url":"https://api.github.com/users/rartemev/repos","events_url":"https://api.github.com/users/rartemev/events{/privacy}","received_events_url":"https://api.github.com/users/rartemev/received_events","type":"User","site_admin":false},"repo":{"id":82239785,"name":"coreclr","full_name":"rartemev/coreclr","owner":{"login":"rartemev","id":25832893,"avatar_url":"https://avatars1.githubusercontent.com/u/25832893?v=3","gravatar_id":"","url":"https://api.github.com/users/rartemev","html_url":"https://github.com/rartemev","followers_url":"https://api.github.com/users/rartemev/followers","following_url":"https://api.github.com/users/rartemev/following{/other_user}","gists_url":"https://api.github.com/users/rartemev/gists{/gist_id}","starred_url":"https://api.github.com/users/rartemev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rartemev/subscriptions","organizations_url":"https://api.github.com/users/rartemev/orgs","repos_url":"https://api.github.com/users/rartemev/repos","events_url":"https://api.github.com/users/rartemev/events{/privacy}","received_events_url":"https://api.github.com/users/rartemev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rartemev/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/rartemev/coreclr","forks_url":"https://api.github.com/repos/rartemev/coreclr/forks","keys_url":"https://api.github.com/repos/rartemev/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rartemev/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rartemev/coreclr/teams","hooks_url":"https://api.github.com/repos/rartemev/coreclr/hooks","issue_events_url":"https://api.github.com/repos/rartemev/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/rartemev/coreclr/events","assignees_url":"https://api.github.com/repos/rartemev/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/rartemev/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/rartemev/coreclr/tags","blobs_url":"https://api.github.com/repos/rartemev/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rartemev/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rartemev/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/rartemev/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rartemev/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/rartemev/coreclr/languages","stargazers_url":"https://api.github.com/repos/rartemev/coreclr/stargazers","contributors_url":"https://api.github.com/repos/rartemev/coreclr/contributors","subscribers_url":"https://api.github.com/repos/rartemev/coreclr/subscribers","subscription_url":"https://api.github.com/repos/rartemev/coreclr/subscription","commits_url":"https://api.github.com/repos/rartemev/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/rartemev/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/rartemev/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/rartemev/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/rartemev/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/rartemev/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rartemev/coreclr/merges","archive_url":"https://api.github.com/repos/rartemev/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rartemev/coreclr/downloads","issues_url":"https://api.github.com/repos/rartemev/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/rartemev/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/rartemev/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/rartemev/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rartemev/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/rartemev/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/rartemev/coreclr/deployments","created_at":"2017-02-17T00:29:34Z","updated_at":"2017-02-17T00:31:49Z","pushed_at":"2017-04-11T20:56:00Z","git_url":"git://github.com/rartemev/coreclr.git","ssh_url":"[email protected]:rartemev/coreclr.git","clone_url":"https://github.com/rartemev/coreclr.git","svn_url":"https://github.com/rartemev/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":150844,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"574803904f3dfb9afa0691c8c675c878c67d2e22","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2017-04-11T12:48:45Z","pushed_at":"2017-04-11T20:56:02Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"[email protected]:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":150928,"stargazers_count":7624,"watchers_count":7624,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1907,"mirror_url":null,"open_issues_count":1194,"forks":1907,"open_issues":1194,"watchers":7624,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/10878"},"html":{"href":"https://github.com/dotnet/coreclr/pull/10878"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/10878"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/10878/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/10878/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/10878/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/2bbeec193b892fdb7dbd2f2c3672db01d8b53be5"}}}} | {
"id": 30092893,
"name": "dotnet/coreclr",
"url": "https://api.github.com/repos/dotnet/coreclr"
} | {
"id": 25832893,
"login": "rartemev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25832893?",
"url": "https://api.github.com/users/rartemev"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2017-04-11T20:56:35 | 5671112958 | {"actor":{"display_login":"rartemev"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/116079177","pull_request_review_id":37674225,"id":116079177,"diff_hunk":"@@ -681,7 +681,7 @@ Namespace Microsoft.CodeAnalysis.Semantics\n Dim parameter As IParameterSymbol = boundParameterEqualsValue.Parameter\n Dim value As Lazy(Of IOperation) = New Lazy(Of IOperation)(Function() Create(boundParameterEqualsValue.Value))\n Dim kind As OperationKind = OperationKind.ParameterInitializerAtDeclaration\n- Dim isInvalid As Boolean = DirectCast(boundParameterEqualsValue.Value, IOperation).IsInvalid\n+ Dim isInvalid As Boolean = value.Value.IsInvalid","path":"src/Compilers/VisualBasic/Portable/Operations/VisualBasicOperationFactory.vb","position":5,"original_position":5,"commit_id":"cb7a4810d54e6b7c8fe21d6049f1bd334a13d228","original_commit_id":"cb7a4810d54e6b7c8fe21d6049f1bd334a13d228","user":{"login":"AlekseyTs","id":10522107,"avatar_url":"https://avatars3.githubusercontent.com/u/10522107?v=3","gravatar_id":"","url":"https://api.github.com/users/AlekseyTs","html_url":"https://github.com/AlekseyTs","followers_url":"https://api.github.com/users/AlekseyTs/followers","following_url":"https://api.github.com/users/AlekseyTs/following{/other_user}","gists_url":"https://api.github.com/users/AlekseyTs/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseyTs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseyTs/subscriptions","organizations_url":"https://api.github.com/users/AlekseyTs/orgs","repos_url":"https://api.github.com/users/AlekseyTs/repos","events_url":"https://api.github.com/users/AlekseyTs/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseyTs/received_events","type":"User","site_admin":false},"body":">value.Value.IsInvalid [](start = 39, length = 21)\r\n\r\nWhat is the point in creating Lazy(Of IOperation) if we get its value two lines later?","created_at":"2017-05-11T19:16:55Z","updated_at":"2017-05-11T19:16:55Z","html_url":"https://github.com/dotnet/roslyn/pull/19406#discussion_r116079177","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/19406","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/116079177"},"html":{"href":"https://github.com/dotnet/roslyn/pull/19406#discussion_r116079177"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/19406"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/19406","id":119973125,"html_url":"https://github.com/dotnet/roslyn/pull/19406","diff_url":"https://github.com/dotnet/roslyn/pull/19406.diff","patch_url":"https://github.com/dotnet/roslyn/pull/19406.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/19406","number":19406,"state":"open","locked":false,"title":"fixed issue caused by VBOperationFactory","user":{"login":"heejaechang","id":1333179,"avatar_url":"https://avatars0.githubusercontent.com/u/1333179?v=3","gravatar_id":"","url":"https://api.github.com/users/heejaechang","html_url":"https://github.com/heejaechang","followers_url":"https://api.github.com/users/heejaechang/followers","following_url":"https://api.github.com/users/heejaechang/following{/other_user}","gists_url":"https://api.github.com/users/heejaechang/gists{/gist_id}","starred_url":"https://api.github.com/users/heejaechang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heejaechang/subscriptions","organizations_url":"https://api.github.com/users/heejaechang/orgs","repos_url":"https://api.github.com/users/heejaechang/repos","events_url":"https://api.github.com/users/heejaechang/events{/privacy}","received_events_url":"https://api.github.com/users/heejaechang/received_events","type":"User","site_admin":false},"body":"@mavasani found issue caused by my VBOperationFactory work.\r\n\r\nthis fixes #19344","created_at":"2017-05-10T20:37:59Z","updated_at":"2017-05-11T19:16:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"134c6fb914a2811c731ca40066f948dcf1e37e4a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/19406/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/19406/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/19406/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/cb7a4810d54e6b7c8fe21d6049f1bd334a13d228","head":{"label":"heejaechang:fixVBOperation","ref":"fixVBOperation","sha":"cb7a4810d54e6b7c8fe21d6049f1bd334a13d228","user":{"login":"heejaechang","id":1333179,"avatar_url":"https://avatars0.githubusercontent.com/u/1333179?v=3","gravatar_id":"","url":"https://api.github.com/users/heejaechang","html_url":"https://github.com/heejaechang","followers_url":"https://api.github.com/users/heejaechang/followers","following_url":"https://api.github.com/users/heejaechang/following{/other_user}","gists_url":"https://api.github.com/users/heejaechang/gists{/gist_id}","starred_url":"https://api.github.com/users/heejaechang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heejaechang/subscriptions","organizations_url":"https://api.github.com/users/heejaechang/orgs","repos_url":"https://api.github.com/users/heejaechang/repos","events_url":"https://api.github.com/users/heejaechang/events{/privacy}","received_events_url":"https://api.github.com/users/heejaechang/received_events","type":"User","site_admin":false},"repo":{"id":30170221,"name":"roslyn","full_name":"heejaechang/roslyn","owner":{"login":"heejaechang","id":1333179,"avatar_url":"https://avatars0.githubusercontent.com/u/1333179?v=3","gravatar_id":"","url":"https://api.github.com/users/heejaechang","html_url":"https://github.com/heejaechang","followers_url":"https://api.github.com/users/heejaechang/followers","following_url":"https://api.github.com/users/heejaechang/following{/other_user}","gists_url":"https://api.github.com/users/heejaechang/gists{/gist_id}","starred_url":"https://api.github.com/users/heejaechang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heejaechang/subscriptions","organizations_url":"https://api.github.com/users/heejaechang/orgs","repos_url":"https://api.github.com/users/heejaechang/repos","events_url":"https://api.github.com/users/heejaechang/events{/privacy}","received_events_url":"https://api.github.com/users/heejaechang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/heejaechang/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/heejaechang/roslyn","forks_url":"https://api.github.com/repos/heejaechang/roslyn/forks","keys_url":"https://api.github.com/repos/heejaechang/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heejaechang/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heejaechang/roslyn/teams","hooks_url":"https://api.github.com/repos/heejaechang/roslyn/hooks","issue_events_url":"https://api.github.com/repos/heejaechang/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/heejaechang/roslyn/events","assignees_url":"https://api.github.com/repos/heejaechang/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/heejaechang/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/heejaechang/roslyn/tags","blobs_url":"https://api.github.com/repos/heejaechang/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heejaechang/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heejaechang/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/heejaechang/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heejaechang/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/heejaechang/roslyn/languages","stargazers_url":"https://api.github.com/repos/heejaechang/roslyn/stargazers","contributors_url":"https://api.github.com/repos/heejaechang/roslyn/contributors","subscribers_url":"https://api.github.com/repos/heejaechang/roslyn/subscribers","subscription_url":"https://api.github.com/repos/heejaechang/roslyn/subscription","commits_url":"https://api.github.com/repos/heejaechang/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/heejaechang/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/heejaechang/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/heejaechang/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/heejaechang/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/heejaechang/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heejaechang/roslyn/merges","archive_url":"https://api.github.com/repos/heejaechang/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heejaechang/roslyn/downloads","issues_url":"https://api.github.com/repos/heejaechang/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/heejaechang/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/heejaechang/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/heejaechang/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heejaechang/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/heejaechang/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/heejaechang/roslyn/deployments","created_at":"2015-02-02T03:54:43Z","updated_at":"2016-03-09T20:46:51Z","pushed_at":"2017-05-10T22:20:26Z","git_url":"git://github.com/heejaechang/roslyn.git","ssh_url":"[email protected]:heejaechang/roslyn.git","clone_url":"https://github.com/heejaechang/roslyn.git","svn_url":"https://github.com/heejaechang/roslyn","homepage":"","size":203990,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:features/ioperation","ref":"features/ioperation","sha":"bc1058904332ff0dcc8a776173c41f0c34e561aa","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2017-05-11T13:43:57Z","pushed_at":"2017-05-11T18:58:52Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"[email protected]:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":211822,"stargazers_count":7476,"watchers_count":7476,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1829,"mirror_url":null,"open_issues_count":3630,"forks":1829,"open_issues":3630,"watchers":7476,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/19406"},"html":{"href":"https://github.com/dotnet/roslyn/pull/19406"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/19406"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/19406/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/19406/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/19406/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/cb7a4810d54e6b7c8fe21d6049f1bd334a13d228"}}}} | {
"id": 29078997,
"name": "dotnet/roslyn",
"url": "https://api.github.com/repos/dotnet/roslyn"
} | {
"id": 10522107,
"login": "AlekseyTs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10522107?",
"url": "https://api.github.com/users/AlekseyTs"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2017-05-11T19:16:55 | 5855942523 | {"actor":{"display_login":"AlekseyTs"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/112303356","pull_request_review_id":33608370,"id":112303356,"diff_hunk":"@@ -274,16 +278,29 @@ where outSymbol.Equals(symbol)\n \n // Ensure we can track the references and the local variable as we make edits\n // to the tree.\n- var rootWithTrackedNodes = root.TrackNodes(references.Concat(localDeclarator).Concat(enclosingBlock));\n+ var rootWithTrackedNodes = root.TrackNodes(\n+ references.Concat(ImmutableArray.Create<SyntaxNode>(localDeclarator, localDeclaration, enclosingBlock)));\n \n // Now, take the local variable and remove it's initializer. Then go to all\n // the locations where we read from it. If they're definitely assigned, then\n // that means the out-var did it's work and assigned the variable across all\n // paths. If it's not definitely assigned, then we can't inline this variable.\n var currentLocalDeclarator = rootWithTrackedNodes.GetCurrentNode(localDeclarator);\n+ var currentLocalDeclaration = rootWithTrackedNodes.GetCurrentNode(localDeclaration);\n+ var updatedDeclaration = currentLocalDeclaration\n+ .ReplaceNode(currentLocalDeclarator, currentLocalDeclarator.WithInitializer(null));\n+\n+ // If the declaration was a \"var\" declaration, then replace \"var\" with the actual\n+ // type of the local. This way we don't get a \"'var v' requires an initializer\" which\n+ // will suppress the message about definite assignment later.\n+ if (updatedDeclaration.Type.IsVar)\n+ {\n+ updatedDeclaration = updatedDeclaration.WithType(\n+ outLocalSymbol.Type.GenerateTypeSyntax());\n+ }\n+\n var rootWithoutInitializer = rootWithTrackedNodes.ReplaceNode(\n- currentLocalDeclarator,\n- currentLocalDeclarator.WithInitializer(null));","path":"src/Features/CSharp/Portable/InlineDeclaration/CSharpInlineDeclarationDiagnosticAnalyzer.cs","position":107,"original_position":107,"commit_id":"28dc5966b04f9278fc25036d7f03a4183d8cd8cd","original_commit_id":"28dc5966b04f9278fc25036d7f03a4183d8cd8cd","user":{"login":"sharwell","id":1408396,"avatar_url":"https://avatars2.githubusercontent.com/u/1408396?v=3","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"body":"It was my mistake. I was picturing `WithInitializer(null)` producing a `null` value expression, like this:\r\n\r\n```csharp\r\nvar item = null;\r\n```\r\n\r\nIn reality, this call is removing the initializer expression altogether, like this:\r\n\r\n```csharp\r\nvar item;\r\n```\r\n\r\nMy question, which is now clear does not apply, was asking if you could do this:\r\n\r\n```csharp\r\nvar item = default(SomeType);\r\n```","created_at":"2017-04-19T20:18:14Z","updated_at":"2017-04-19T20:18:15Z","html_url":"https://github.com/dotnet/roslyn/pull/18830#discussion_r112303356","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/18830","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/112303356"},"html":{"href":"https://github.com/dotnet/roslyn/pull/18830#discussion_r112303356"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/18830"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/18830","id":116627416,"html_url":"https://github.com/dotnet/roslyn/pull/18830","diff_url":"https://github.com/dotnet/roslyn/pull/18830.diff","patch_url":"https://github.com/dotnet/roslyn/pull/18830.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/18830","number":18830,"state":"open","locked":false,"title":"Fix issue with definite-assignment checking in 'inline-decl' with 'var-typed' locals.","user":{"login":"CyrusNajmabadi","id":4564579,"avatar_url":"https://avatars0.githubusercontent.com/u/4564579?v=3","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/dotnet/roslyn/issues/18668\r\n\r\n**Customer scenario**\r\n\r\nWhat does the customer do to get into this situation, and why do we think this\r\nis common enough to address for this release. (Granted, sometimes this will be\r\nobvious \"Open project, VS crashes\" but in general, I need to understand how\r\ncommon a scenario is)\r\n\r\n**Bugs this fixes:**\r\n\r\n(either VSO or GitHub links)\r\n\r\n**Workarounds, if any**\r\n\r\nAlso, why we think they are insufficient for RC vs. RC2, RC3, or RTW\r\n\r\n**Risk**\r\n\r\nThis is generally a measure our how central the affected code is to adjacent\r\nscenarios and thus how likely your fix is to destabilize a broader area of code\r\n\r\n**Performance impact**\r\n\r\n(with a brief justification for that assessment (e.g. \"Low perf impact because no extra allocations/no complexity changes\" vs. \"Low\")\r\n\r\n**Is this a regression from a previous update?**\r\n\r\n**Root cause analysis:**\r\n\r\nHow did we miss it? What tests are we adding to guard against it in the future?\r\n\r\n**How was the bug found?**\r\n\r\n(E.g. customer reported it vs. ad hoc testing)\r\n","created_at":"2017-04-19T19:50:15Z","updated_at":"2017-04-19T20:18:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fdd142eca78ba44305de4f0e0c1f6fa9804ee56","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/18830/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/18830/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/18830/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/28dc5966b04f9278fc25036d7f03a4183d8cd8cd","head":{"label":"CyrusNajmabadi:inlineDeclDefAssignment","ref":"inlineDeclDefAssignment","sha":"28dc5966b04f9278fc25036d7f03a4183d8cd8cd","user":{"login":"CyrusNajmabadi","id":4564579,"avatar_url":"https://avatars0.githubusercontent.com/u/4564579?v=3","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"repo":{"id":30565155,"name":"roslyn","full_name":"CyrusNajmabadi/roslyn","owner":{"login":"CyrusNajmabadi","id":4564579,"avatar_url":"https://avatars0.githubusercontent.com/u/4564579?v=3","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CyrusNajmabadi/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/CyrusNajmabadi/roslyn","forks_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/forks","keys_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/teams","hooks_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/hooks","issue_events_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/events","assignees_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/tags","blobs_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/languages","stargazers_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/stargazers","contributors_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/contributors","subscribers_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/subscribers","subscription_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/subscription","commits_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/merges","archive_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/downloads","issues_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/deployments","created_at":"2015-02-09T23:45:22Z","updated_at":"2016-01-11T20:46:56Z","pushed_at":"2017-04-19T19:49:56Z","git_url":"git://github.com/CyrusNajmabadi/roslyn.git","ssh_url":"[email protected]:CyrusNajmabadi/roslyn.git","clone_url":"https://github.com/CyrusNajmabadi/roslyn.git","svn_url":"https://github.com/CyrusNajmabadi/roslyn","homepage":"","size":200058,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"d3e82424b2b7d1c12d94f6e791f9412e46a219f4","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2017-04-19T16:36:42Z","pushed_at":"2017-04-19T20:05:33Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"[email protected]:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":205833,"stargazers_count":7379,"watchers_count":7379,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1792,"mirror_url":null,"open_issues_count":3546,"forks":1792,"open_issues":3546,"watchers":7379,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/18830"},"html":{"href":"https://github.com/dotnet/roslyn/pull/18830"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/18830"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/18830/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/18830/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/18830/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/28dc5966b04f9278fc25036d7f03a4183d8cd8cd"}}}} | {
"id": 29078997,
"name": "dotnet/roslyn",
"url": "https://api.github.com/repos/dotnet/roslyn"
} | {
"id": 1408396,
"login": "sharwell",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1408396?",
"url": "https://api.github.com/users/sharwell"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2017-04-19T20:18:14 | 5718758634 | {"actor":{"display_login":"sharwell"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/154472063","pull_request_review_id":80648542,"id":154472063,"diff_hunk":"@@ -816,6 +816,15 @@ public static unsafe SocketError GetAvailable(SafeCloseSocket handle, out int av\n return err == Interop.Error.SUCCESS ? SocketError.Success : GetSocketErrorForErrorCode(err);\n }\n \n+ public static unsafe SocketError GetAtOutOfBandMark(SafeCloseSocket handle, out int available)","path":"src/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs","position":null,"original_position":4,"commit_id":"6a764c67d9b5301291c7883377a1fef4c9b35d58","original_commit_id":"0256095afa0739febfb757ca285d02a2c2b825f8","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars0.githubusercontent.com/u/2642209?v=4","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2017-12-01T23:22:34Z","updated_at":"2017-12-01T23:22:34Z","html_url":"https://github.com/dotnet/corefx/pull/25579#discussion_r154472063","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/25579","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/154472063"},"html":{"href":"https://github.com/dotnet/corefx/pull/25579#discussion_r154472063"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/25579"}},"in_reply_to_id":154169858},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/25579","id":155436634,"html_url":"https://github.com/dotnet/corefx/pull/25579","diff_url":"https://github.com/dotnet/corefx/pull/25579.diff","patch_url":"https://github.com/dotnet/corefx/pull/25579.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/25579","number":25579,"state":"open","locked":false,"title":"Add basic Socket.IOControl implementation on Unix","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars0.githubusercontent.com/u/2642209?v=4","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"Socket.IOControl uses Windows-specific code values, both in terms of the actual code numbers and in terms of lots of them being Windows-specific functionality. But a few of the codes do translate across OSes in terms of functionality, and we've heard from at least a few developers who were using these codes and expected them to work on Unix.\r\n\r\ncc: @geoffkizer, @tmds ","created_at":"2017-11-29T19:54:01Z","updated_at":"2017-12-01T23:22:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f979f3d06797b64eb03660d6bd7edf1b25ec9a4d","assignee":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars0.githubusercontent.com/u/2642209?v=4","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"assignees":[{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars0.githubusercontent.com/u/2642209?v=4","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/25579/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/25579/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/25579/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/6a764c67d9b5301291c7883377a1fef4c9b35d58","head":{"label":"stephentoub:ioctl_unix","ref":"ioctl_unix","sha":"6a764c67d9b5301291c7883377a1fef4c9b35d58","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars0.githubusercontent.com/u/2642209?v=4","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"repo":{"id":26551529,"name":"corefx","full_name":"stephentoub/corefx","owner":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars0.githubusercontent.com/u/2642209?v=4","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stephentoub/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/stephentoub/corefx","forks_url":"https://api.github.com/repos/stephentoub/corefx/forks","keys_url":"https://api.github.com/repos/stephentoub/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephentoub/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephentoub/corefx/teams","hooks_url":"https://api.github.com/repos/stephentoub/corefx/hooks","issue_events_url":"https://api.github.com/repos/stephentoub/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/stephentoub/corefx/events","assignees_url":"https://api.github.com/repos/stephentoub/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/stephentoub/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/stephentoub/corefx/tags","blobs_url":"https://api.github.com/repos/stephentoub/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephentoub/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephentoub/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephentoub/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephentoub/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/stephentoub/corefx/languages","stargazers_url":"https://api.github.com/repos/stephentoub/corefx/stargazers","contributors_url":"https://api.github.com/repos/stephentoub/corefx/contributors","subscribers_url":"https://api.github.com/repos/stephentoub/corefx/subscribers","subscription_url":"https://api.github.com/repos/stephentoub/corefx/subscription","commits_url":"https://api.github.com/repos/stephentoub/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephentoub/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephentoub/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephentoub/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephentoub/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/stephentoub/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephentoub/corefx/merges","archive_url":"https://api.github.com/repos/stephentoub/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephentoub/corefx/downloads","issues_url":"https://api.github.com/repos/stephentoub/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/stephentoub/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/stephentoub/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/stephentoub/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephentoub/corefx/labels{/name}","releases_url":"https://api.github.com/repos/stephentoub/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/stephentoub/corefx/deployments","created_at":"2014-11-12T19:06:24Z","updated_at":"2016-10-22T10:27:30Z","pushed_at":"2017-12-01T23:22:22Z","git_url":"git://github.com/stephentoub/corefx.git","ssh_url":"[email protected]:stephentoub/corefx.git","clone_url":"https://github.com/stephentoub/corefx.git","svn_url":"https://github.com/stephentoub/corefx","homepage":"","size":156023,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"9a2e5d8f0e7f816f983bce75f5bba22811df4994","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2017-12-01T20:46:40Z","pushed_at":"2017-12-01T23:22:24Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"[email protected]:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":162683,"stargazers_count":12965,"watchers_count":12965,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3630,"mirror_url":null,"archived":false,"open_issues_count":2161,"license":null,"forks":3630,"open_issues":2161,"watchers":12965,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/25579"},"html":{"href":"https://github.com/dotnet/corefx/pull/25579"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/25579"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/25579/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/25579/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/25579/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/6a764c67d9b5301291c7883377a1fef4c9b35d58"}},"author_association":"MEMBER"}} | {
"id": 26295345,
"name": "dotnet/corefx",
"url": "https://api.github.com/repos/dotnet/corefx"
} | {
"id": 2642209,
"login": "stephentoub",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2642209?",
"url": "https://api.github.com/users/stephentoub"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2017-12-01T23:22:34 | 6932754223 | {"actor":{"display_login":"stephentoub"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/127541951","pull_request_review_id":50144334,"id":127541951,"diff_hunk":"@@ -673,19 +683,56 @@ public override BoundNode VisitAssignmentOperator(BoundAssignmentOperator node)\n {\n BoundSpillSequenceBuilder builder = null;\n var right = VisitExpression(ref builder, node.Right);\n- BoundExpression left;\n- if (builder == null || node.Left.Kind == BoundKind.Local)\n+\n+ BoundExpression left = node.Left;\n+ if (builder == null)\n {\n- left = VisitExpression(ref builder, node.Left);\n+ left = VisitExpression(ref builder, left);\n }\n else\n {\n // if the right-hand-side has await, spill the left\n var leftBuilder = new BoundSpillSequenceBuilder();\n- left = VisitExpression(ref leftBuilder, node.Left);\n- if (left.Kind != BoundKind.Local)\n+\n+ switch (left.Kind)\n {\n- left = Spill(leftBuilder, left, RefKind.Ref);\n+ case BoundKind.Local:\n+ case BoundKind.Parameter:\n+ // locals and parameters are directly assignable, LHS is not on the stack so nothing to spill\n+ break;\n+\n+ case BoundKind.FieldAccess:\n+ var field = (BoundFieldAccess)left;\n+ // static fields are directly assignable, LHS is not on the stack, nothing to spill\n+ if (field.FieldSymbol.IsStatic) break;\n+\n+ // instance fields are directly assignable, but receiver is pushed, so need to spill that.\n+ var receiver = VisitExpression(ref leftBuilder, field.ReceiverOpt);\n+ receiver = Spill(builder, receiver, field.FieldSymbol.ContainingType.IsValueType ? RefKind.Ref : RefKind.None);\n+ left = field.Update(receiver, field.FieldSymbol, field.ConstantValueOpt, field.ResultKind, field.Type);\n+ break;\n+\n+ case BoundKind.ArrayAccess:\n+ var arrayAccess = (BoundArrayAccess)left;\n+ // array and indices are pushed on stack so need to spill that\n+ var expression = VisitExpression(ref leftBuilder, arrayAccess.Expression);\n+ expression = Spill(builder, expression, RefKind.None);\n+ var indices = this.VisitExpressionList(ref builder, arrayAccess.Indices, forceSpill: true);\n+ left = arrayAccess.Update(expression, indices, arrayAccess.Type);\n+ break;\n+\n+ default:\n+ // must be something indirectly assignable, just visit and spill as an ordinary Ref (not a RefReadOnly!!)\n+ //\n+ // NOTE: in some cases this will result in spiller producing an error.\n+ // For example if the LHS is a ref-returning method like\n+ //\n+ // obj.RefReturning(a, b, c) = await Something();\n+ //\n+ // the spiller would eventually have to spill the evaluation result of \"refReturning\" call as an ordinary Ref, \n+ // which it can't.","path":"src/Compilers/CSharp/Portable/Lowering/AsyncRewriter/AwaitExpressionSpiller.cs","position":129,"original_position":129,"commit_id":"c425a087cc5f4cbeccdca14c53ee2d4e4af93203","original_commit_id":"c425a087cc5f4cbeccdca14c53ee2d4e4af93203","user":{"login":"cston","id":10732005,"avatar_url":"https://avatars6.githubusercontent.com/u/10732005?v=4","gravatar_id":"","url":"https://api.github.com/users/cston","html_url":"https://github.com/cston","followers_url":"https://api.github.com/users/cston/followers","following_url":"https://api.github.com/users/cston/following{/other_user}","gists_url":"https://api.github.com/users/cston/gists{/gist_id}","starred_url":"https://api.github.com/users/cston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cston/subscriptions","organizations_url":"https://api.github.com/users/cston/orgs","repos_url":"https://api.github.com/users/cston/repos","events_url":"https://api.github.com/users/cston/events{/privacy}","received_events_url":"https://api.github.com/users/cston/received_events","type":"User","site_admin":false},"body":"Are we testing this case?","created_at":"2017-07-14T20:28:15Z","updated_at":"2017-07-14T20:28:15Z","html_url":"https://github.com/dotnet/roslyn/pull/20883#discussion_r127541951","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/20883","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/127541951"},"html":{"href":"https://github.com/dotnet/roslyn/pull/20883#discussion_r127541951"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/20883"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/20883","id":130617901,"html_url":"https://github.com/dotnet/roslyn/pull/20883","diff_url":"https://github.com/dotnet/roslyn/pull/20883.diff","patch_url":"https://github.com/dotnet/roslyn/pull/20883.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/20883","number":20883,"state":"open","locked":false,"title":"Making async stack spiller aware of \"readonly ref\"","user":{"login":"VSadov","id":8218165,"avatar_url":"https://avatars4.githubusercontent.com/u/8218165?v=4","gravatar_id":"","url":"https://api.github.com/users/VSadov","html_url":"https://github.com/VSadov","followers_url":"https://api.github.com/users/VSadov/followers","following_url":"https://api.github.com/users/VSadov/following{/other_user}","gists_url":"https://api.github.com/users/VSadov/gists{/gist_id}","starred_url":"https://api.github.com/users/VSadov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSadov/subscriptions","organizations_url":"https://api.github.com/users/VSadov/orgs","repos_url":"https://api.github.com/users/VSadov/repos","events_url":"https://api.github.com/users/VSadov/events{/privacy}","received_events_url":"https://api.github.com/users/VSadov/received_events","type":"User","site_admin":false},"body":"Making async stack spiller aware of \"readonly ref\"\r\n\r\n- changing stack spiller to not treat everything that is not RefKind.None as RefKind.Ref\r\n- making sure that \"ref readonly\" arguments and receivers of readonly structs are seen by the spiller as RefKind.RefReadOnly\r\n- implementing spilling strategy where RefReadOnly stack operands are spilled \"by-reference\" when possible, and ! spilled \"by-value\" via a copy otherwise. \r\n\r\n(the latter is an error for ordinary ref operands, but it is ok for RefReadOnly since in the case of \"ref readonly\" the actual by-ref aliasing is an opportunistic feature and not a requirement)","created_at":"2017-07-14T15:46:38Z","updated_at":"2017-07-14T20:28:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c865360943d53a948afdf10b4c92501f0ce790a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/20883/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/20883/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/20883/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/c425a087cc5f4cbeccdca14c53ee2d4e4af93203","head":{"label":"VSadov:asyncSpill","ref":"asyncSpill","sha":"c425a087cc5f4cbeccdca14c53ee2d4e4af93203","user":{"login":"VSadov","id":8218165,"avatar_url":"https://avatars4.githubusercontent.com/u/8218165?v=4","gravatar_id":"","url":"https://api.github.com/users/VSadov","html_url":"https://github.com/VSadov","followers_url":"https://api.github.com/users/VSadov/followers","following_url":"https://api.github.com/users/VSadov/following{/other_user}","gists_url":"https://api.github.com/users/VSadov/gists{/gist_id}","starred_url":"https://api.github.com/users/VSadov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSadov/subscriptions","organizations_url":"https://api.github.com/users/VSadov/orgs","repos_url":"https://api.github.com/users/VSadov/repos","events_url":"https://api.github.com/users/VSadov/events{/privacy}","received_events_url":"https://api.github.com/users/VSadov/received_events","type":"User","site_admin":false},"repo":{"id":30550950,"name":"roslyn","full_name":"VSadov/roslyn","owner":{"login":"VSadov","id":8218165,"avatar_url":"https://avatars4.githubusercontent.com/u/8218165?v=4","gravatar_id":"","url":"https://api.github.com/users/VSadov","html_url":"https://github.com/VSadov","followers_url":"https://api.github.com/users/VSadov/followers","following_url":"https://api.github.com/users/VSadov/following{/other_user}","gists_url":"https://api.github.com/users/VSadov/gists{/gist_id}","starred_url":"https://api.github.com/users/VSadov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSadov/subscriptions","organizations_url":"https://api.github.com/users/VSadov/orgs","repos_url":"https://api.github.com/users/VSadov/repos","events_url":"https://api.github.com/users/VSadov/events{/privacy}","received_events_url":"https://api.github.com/users/VSadov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VSadov/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/VSadov/roslyn","forks_url":"https://api.github.com/repos/VSadov/roslyn/forks","keys_url":"https://api.github.com/repos/VSadov/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VSadov/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VSadov/roslyn/teams","hooks_url":"https://api.github.com/repos/VSadov/roslyn/hooks","issue_events_url":"https://api.github.com/repos/VSadov/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/VSadov/roslyn/events","assignees_url":"https://api.github.com/repos/VSadov/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/VSadov/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/VSadov/roslyn/tags","blobs_url":"https://api.github.com/repos/VSadov/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VSadov/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VSadov/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/VSadov/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VSadov/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/VSadov/roslyn/languages","stargazers_url":"https://api.github.com/repos/VSadov/roslyn/stargazers","contributors_url":"https://api.github.com/repos/VSadov/roslyn/contributors","subscribers_url":"https://api.github.com/repos/VSadov/roslyn/subscribers","subscription_url":"https://api.github.com/repos/VSadov/roslyn/subscription","commits_url":"https://api.github.com/repos/VSadov/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/VSadov/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/VSadov/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/VSadov/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/VSadov/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/VSadov/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VSadov/roslyn/merges","archive_url":"https://api.github.com/repos/VSadov/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VSadov/roslyn/downloads","issues_url":"https://api.github.com/repos/VSadov/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/VSadov/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/VSadov/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/VSadov/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VSadov/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/VSadov/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/VSadov/roslyn/deployments","created_at":"2015-02-09T18:24:54Z","updated_at":"2016-02-12T19:18:20Z","pushed_at":"2017-07-14T20:15:53Z","git_url":"git://github.com/VSadov/roslyn.git","ssh_url":"[email protected]:VSadov/roslyn.git","clone_url":"https://github.com/VSadov/roslyn.git","svn_url":"https://github.com/VSadov/roslyn","homepage":"","size":217557,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:features/readonly-ref","ref":"features/readonly-ref","sha":"4185afd3767d0af45b9b5829f40e6f00b5cb9e7e","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars4.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars4.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2017-07-14T17:31:28Z","pushed_at":"2017-07-14T20:19:43Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"[email protected]:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":226486,"stargazers_count":7766,"watchers_count":7766,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1904,"mirror_url":null,"open_issues_count":3782,"forks":1904,"open_issues":3782,"watchers":7766,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/20883"},"html":{"href":"https://github.com/dotnet/roslyn/pull/20883"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/20883"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/20883/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/20883/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/20883/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/c425a087cc5f4cbeccdca14c53ee2d4e4af93203"}}}} | {
"id": 29078997,
"name": "dotnet/roslyn",
"url": "https://api.github.com/repos/dotnet/roslyn"
} | {
"id": 10732005,
"login": "cston",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10732005?",
"url": "https://api.github.com/users/cston"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2017-07-14T20:28:15 | 6260365827 | {"actor":{"display_login":"cston"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments/114188632","pull_request_review_id":35634764,"id":114188632,"diff_hunk":"@@ -78,6 +78,127 @@ public void EnumerateAndEnsureCodePointsOfTheSameUtf8AndUtf16StringsAreTheSame(s\n }\n }\n \n+ public static object[][] InvalidUtf8ToUtf16SequenceData = {","path":"tests/System.Text.Primitives.Tests/Encoding/Utf8Utf16ConversionTests.cs","position":4,"original_position":4,"commit_id":"7a3c1cc78dd0c40c823b6a970c8d86484e29e5fa","original_commit_id":"7a3c1cc78dd0c40c823b6a970c8d86484e29e5fa","user":{"login":"shiftylogic","id":11233697,"avatar_url":"https://avatars1.githubusercontent.com/u/11233697?v=3","gravatar_id":"","url":"https://api.github.com/users/shiftylogic","html_url":"https://github.com/shiftylogic","followers_url":"https://api.github.com/users/shiftylogic/followers","following_url":"https://api.github.com/users/shiftylogic/following{/other_user}","gists_url":"https://api.github.com/users/shiftylogic/gists{/gist_id}","starred_url":"https://api.github.com/users/shiftylogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiftylogic/subscriptions","organizations_url":"https://api.github.com/users/shiftylogic/orgs","repos_url":"https://api.github.com/users/shiftylogic/repos","events_url":"https://api.github.com/users/shiftylogic/events{/privacy}","received_events_url":"https://api.github.com/users/shiftylogic/received_events","type":"User","site_admin":false},"body":"These tests are specific to going from UTF-8 to UTF-16. You'd have to craft different tests for other conversions.\r\n\r\nMost of these tests are generic to benefit any implementation. However, the \"long\" versions know that the buffer needs to be greater than 13 bytes to get into the \"fast\" path. So, there are some tests specific to ensure we exercise all the code.","created_at":"2017-05-01T19:56:11Z","updated_at":"2017-05-01T19:56:11Z","html_url":"https://github.com/dotnet/corefxlab/pull/1511#discussion_r114188632","pull_request_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/1511","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments/114188632"},"html":{"href":"https://github.com/dotnet/corefxlab/pull/1511#discussion_r114188632"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/1511"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefxlab/pulls/1511","id":118407584,"html_url":"https://github.com/dotnet/corefxlab/pull/1511","diff_url":"https://github.com/dotnet/corefxlab/pull/1511.diff","patch_url":"https://github.com/dotnet/corefxlab/pull/1511.patch","issue_url":"https://api.github.com/repos/dotnet/corefxlab/issues/1511","number":1511,"state":"open","locked":false,"title":"Invalid sequence tests for UTF-8 to UTF-16; plus 2-byte long code bug fix.","user":{"login":"shiftylogic","id":11233697,"avatar_url":"https://avatars1.githubusercontent.com/u/11233697?v=3","gravatar_id":"","url":"https://api.github.com/users/shiftylogic","html_url":"https://github.com/shiftylogic","followers_url":"https://api.github.com/users/shiftylogic/followers","following_url":"https://api.github.com/users/shiftylogic/following{/other_user}","gists_url":"https://api.github.com/users/shiftylogic/gists{/gist_id}","starred_url":"https://api.github.com/users/shiftylogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiftylogic/subscriptions","organizations_url":"https://api.github.com/users/shiftylogic/orgs","repos_url":"https://api.github.com/users/shiftylogic/repos","events_url":"https://api.github.com/users/shiftylogic/events{/privacy}","received_events_url":"https://api.github.com/users/shiftylogic/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-01T17:40:45Z","updated_at":"2017-05-01T19:56:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"356efd0e38a40a8312597b8489035b69a841e6ef","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/1511/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/1511/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefxlab/issues/1511/comments","statuses_url":"https://api.github.com/repos/dotnet/corefxlab/statuses/7a3c1cc78dd0c40c823b6a970c8d86484e29e5fa","head":{"label":"shiftylogic:working/utf8_to_utf16","ref":"working/utf8_to_utf16","sha":"7a3c1cc78dd0c40c823b6a970c8d86484e29e5fa","user":{"login":"shiftylogic","id":11233697,"avatar_url":"https://avatars1.githubusercontent.com/u/11233697?v=3","gravatar_id":"","url":"https://api.github.com/users/shiftylogic","html_url":"https://github.com/shiftylogic","followers_url":"https://api.github.com/users/shiftylogic/followers","following_url":"https://api.github.com/users/shiftylogic/following{/other_user}","gists_url":"https://api.github.com/users/shiftylogic/gists{/gist_id}","starred_url":"https://api.github.com/users/shiftylogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiftylogic/subscriptions","organizations_url":"https://api.github.com/users/shiftylogic/orgs","repos_url":"https://api.github.com/users/shiftylogic/repos","events_url":"https://api.github.com/users/shiftylogic/events{/privacy}","received_events_url":"https://api.github.com/users/shiftylogic/received_events","type":"User","site_admin":false},"repo":{"id":77081499,"name":"corefxlab","full_name":"shiftylogic/corefxlab","owner":{"login":"shiftylogic","id":11233697,"avatar_url":"https://avatars1.githubusercontent.com/u/11233697?v=3","gravatar_id":"","url":"https://api.github.com/users/shiftylogic","html_url":"https://github.com/shiftylogic","followers_url":"https://api.github.com/users/shiftylogic/followers","following_url":"https://api.github.com/users/shiftylogic/following{/other_user}","gists_url":"https://api.github.com/users/shiftylogic/gists{/gist_id}","starred_url":"https://api.github.com/users/shiftylogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiftylogic/subscriptions","organizations_url":"https://api.github.com/users/shiftylogic/orgs","repos_url":"https://api.github.com/users/shiftylogic/repos","events_url":"https://api.github.com/users/shiftylogic/events{/privacy}","received_events_url":"https://api.github.com/users/shiftylogic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shiftylogic/corefxlab","description":"This repo is for experimentation and exploring new ideas that may or may not make it into the main corefx repo.","fork":true,"url":"https://api.github.com/repos/shiftylogic/corefxlab","forks_url":"https://api.github.com/repos/shiftylogic/corefxlab/forks","keys_url":"https://api.github.com/repos/shiftylogic/corefxlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shiftylogic/corefxlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shiftylogic/corefxlab/teams","hooks_url":"https://api.github.com/repos/shiftylogic/corefxlab/hooks","issue_events_url":"https://api.github.com/repos/shiftylogic/corefxlab/issues/events{/number}","events_url":"https://api.github.com/repos/shiftylogic/corefxlab/events","assignees_url":"https://api.github.com/repos/shiftylogic/corefxlab/assignees{/user}","branches_url":"https://api.github.com/repos/shiftylogic/corefxlab/branches{/branch}","tags_url":"https://api.github.com/repos/shiftylogic/corefxlab/tags","blobs_url":"https://api.github.com/repos/shiftylogic/corefxlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shiftylogic/corefxlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shiftylogic/corefxlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/shiftylogic/corefxlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shiftylogic/corefxlab/statuses/{sha}","languages_url":"https://api.github.com/repos/shiftylogic/corefxlab/languages","stargazers_url":"https://api.github.com/repos/shiftylogic/corefxlab/stargazers","contributors_url":"https://api.github.com/repos/shiftylogic/corefxlab/contributors","subscribers_url":"https://api.github.com/repos/shiftylogic/corefxlab/subscribers","subscription_url":"https://api.github.com/repos/shiftylogic/corefxlab/subscription","commits_url":"https://api.github.com/repos/shiftylogic/corefxlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/shiftylogic/corefxlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/shiftylogic/corefxlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/shiftylogic/corefxlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/shiftylogic/corefxlab/contents/{+path}","compare_url":"https://api.github.com/repos/shiftylogic/corefxlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shiftylogic/corefxlab/merges","archive_url":"https://api.github.com/repos/shiftylogic/corefxlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shiftylogic/corefxlab/downloads","issues_url":"https://api.github.com/repos/shiftylogic/corefxlab/issues{/number}","pulls_url":"https://api.github.com/repos/shiftylogic/corefxlab/pulls{/number}","milestones_url":"https://api.github.com/repos/shiftylogic/corefxlab/milestones{/number}","notifications_url":"https://api.github.com/repos/shiftylogic/corefxlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shiftylogic/corefxlab/labels{/name}","releases_url":"https://api.github.com/repos/shiftylogic/corefxlab/releases{/id}","deployments_url":"https://api.github.com/repos/shiftylogic/corefxlab/deployments","created_at":"2016-12-21T19:48:21Z","updated_at":"2016-12-21T19:48:25Z","pushed_at":"2017-05-01T17:39:50Z","git_url":"git://github.com/shiftylogic/corefxlab.git","ssh_url":"[email protected]:shiftylogic/corefxlab.git","clone_url":"https://github.com/shiftylogic/corefxlab.git","svn_url":"https://github.com/shiftylogic/corefxlab","homepage":"","size":32928,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"9fe10dfd09b7a248f28aaae3d1b3f8734dcac153","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29504192,"name":"corefxlab","full_name":"dotnet/corefxlab","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefxlab","description":"This repo is for experimentation and exploring new ideas that may or may not make it into the main corefx repo.","fork":false,"url":"https://api.github.com/repos/dotnet/corefxlab","forks_url":"https://api.github.com/repos/dotnet/corefxlab/forks","keys_url":"https://api.github.com/repos/dotnet/corefxlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefxlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefxlab/teams","hooks_url":"https://api.github.com/repos/dotnet/corefxlab/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefxlab/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefxlab/events","assignees_url":"https://api.github.com/repos/dotnet/corefxlab/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefxlab/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefxlab/tags","blobs_url":"https://api.github.com/repos/dotnet/corefxlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefxlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefxlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefxlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefxlab/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefxlab/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefxlab/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefxlab/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefxlab/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefxlab/subscription","commits_url":"https://api.github.com/repos/dotnet/corefxlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefxlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefxlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefxlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefxlab/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefxlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefxlab/merges","archive_url":"https://api.github.com/repos/dotnet/corefxlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefxlab/downloads","issues_url":"https://api.github.com/repos/dotnet/corefxlab/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefxlab/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefxlab/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefxlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefxlab/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefxlab/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefxlab/deployments","created_at":"2015-01-20T00:44:35Z","updated_at":"2017-04-27T14:39:03Z","pushed_at":"2017-05-01T17:40:46Z","git_url":"git://github.com/dotnet/corefxlab.git","ssh_url":"[email protected]:dotnet/corefxlab.git","clone_url":"https://github.com/dotnet/corefxlab.git","svn_url":"https://github.com/dotnet/corefxlab","homepage":"","size":32997,"stargazers_count":688,"watchers_count":688,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":192,"mirror_url":null,"open_issues_count":201,"forks":192,"open_issues":201,"watchers":688,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/1511"},"html":{"href":"https://github.com/dotnet/corefxlab/pull/1511"},"issue":{"href":"https://api.github.com/repos/dotnet/corefxlab/issues/1511"},"comments":{"href":"https://api.github.com/repos/dotnet/corefxlab/issues/1511/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/1511/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/1511/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefxlab/statuses/7a3c1cc78dd0c40c823b6a970c8d86484e29e5fa"}}}} | {
"id": 29504192,
"name": "dotnet/corefxlab",
"url": "https://api.github.com/repos/dotnet/corefxlab"
} | {
"id": 11233697,
"login": "shiftylogic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11233697?",
"url": "https://api.github.com/users/shiftylogic"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2017-05-01T19:56:11 | 5789000584 | {"actor":{"display_login":"shiftylogic"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/docs/pulls/comments/141992084","pull_request_review_id":66298519,"id":141992084,"diff_hunk":"@@ -5,14 +5,13 @@ ms.prod: \".net-framework\"\n ms.technology: \n - \"dotnet-clr\"\n ms.topic: \"article\"\n+ms.custom: \"updateeachrelease\"\n f1_keywords: \n - \"http://schemas.microsoft.com/.NetConfiguration/v2.0#supportedRuntime\"\n - \"http://schemas.microsoft.com/.NetConfiguration/v2.0#configuration/startup/supportedRuntime\"\n helpviewer_keywords: \n - \"supportedRuntime element\"\n - \"<supportedRuntime> element\"\n-ms.assetid: 1ae16e23-afbe-4de4-b413-bc457f37b69f","path":"docs/framework/configure-apps/file-schema/startup/supportedruntime-element.md","position":11,"original_position":11,"commit_id":"f5d3a3a0a38464e48f6f9b0da6289a3020994415","original_commit_id":"f5d3a3a0a38464e48f6f9b0da6289a3020994415","user":{"login":"mairaw","id":12971179,"avatar_url":"https://avatars2.githubusercontent.com/u/12971179?v=4","gravatar_id":"","url":"https://api.github.com/users/mairaw","html_url":"https://github.com/mairaw","followers_url":"https://api.github.com/users/mairaw/followers","following_url":"https://api.github.com/users/mairaw/following{/other_user}","gists_url":"https://api.github.com/users/mairaw/gists{/gist_id}","starred_url":"https://api.github.com/users/mairaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mairaw/subscriptions","organizations_url":"https://api.github.com/users/mairaw/orgs","repos_url":"https://api.github.com/users/mairaw/repos","events_url":"https://api.github.com/users/mairaw/events{/privacy}","received_events_url":"https://api.github.com/users/mairaw/received_events","type":"User","site_admin":false},"body":"for topics that were migrated from caps, I'm keeping this optional field (for now at least). It helps me find the old version of it more easily when there are issues (and unfortunately, we're still finding issues). I'm fine with removing the revision number from the topics though.","created_at":"2017-09-30T00:38:23Z","updated_at":"2017-09-30T00:39:13Z","html_url":"https://github.com/dotnet/docs/pull/3288#discussion_r141992084","pull_request_url":"https://api.github.com/repos/dotnet/docs/pulls/3288","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/docs/pulls/comments/141992084"},"html":{"href":"https://github.com/dotnet/docs/pull/3288#discussion_r141992084"},"pull_request":{"href":"https://api.github.com/repos/dotnet/docs/pulls/3288"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/docs/pulls/3288","id":144002721,"html_url":"https://github.com/dotnet/docs/pull/3288","diff_url":"https://github.com/dotnet/docs/pull/3288.diff","patch_url":"https://github.com/dotnet/docs/pull/3288.patch","issue_url":"https://api.github.com/repos/dotnet/docs/issues/3288","number":3288,"state":"open","locked":false,"title":"Added \"updateeachversion\" metadata","user":{"login":"rpetrusha","id":10886961,"avatar_url":"https://avatars2.githubusercontent.com/u/10886961?v=4","gravatar_id":"","url":"https://api.github.com/users/rpetrusha","html_url":"https://github.com/rpetrusha","followers_url":"https://api.github.com/users/rpetrusha/followers","following_url":"https://api.github.com/users/rpetrusha/following{/other_user}","gists_url":"https://api.github.com/users/rpetrusha/gists{/gist_id}","starred_url":"https://api.github.com/users/rpetrusha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpetrusha/subscriptions","organizations_url":"https://api.github.com/users/rpetrusha/orgs","repos_url":"https://api.github.com/users/rpetrusha/repos","events_url":"https://api.github.com/users/rpetrusha/events{/privacy}","received_events_url":"https://api.github.com/users/rpetrusha/received_events","type":"User","site_admin":false},"body":"# Added \"updateeachversion\" metadata\r\n\r\nThese are all topics that need to be updated for each new release of the .NET Framework.\r\n\r\n## Suggested Reviewers\r\n\r\n@mairaw \r\n","created_at":"2017-09-30T00:08:36Z","updated_at":"2017-09-30T00:39:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ab41d06256398f981ecb32ece1b49dca26e647c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/docs/pulls/3288/commits","review_comments_url":"https://api.github.com/repos/dotnet/docs/pulls/3288/comments","review_comment_url":"https://api.github.com/repos/dotnet/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/docs/issues/3288/comments","statuses_url":"https://api.github.com/repos/dotnet/docs/statuses/f5d3a3a0a38464e48f6f9b0da6289a3020994415","head":{"label":"rpetrusha:updateeachversion","ref":"updateeachversion","sha":"f5d3a3a0a38464e48f6f9b0da6289a3020994415","user":{"login":"rpetrusha","id":10886961,"avatar_url":"https://avatars2.githubusercontent.com/u/10886961?v=4","gravatar_id":"","url":"https://api.github.com/users/rpetrusha","html_url":"https://github.com/rpetrusha","followers_url":"https://api.github.com/users/rpetrusha/followers","following_url":"https://api.github.com/users/rpetrusha/following{/other_user}","gists_url":"https://api.github.com/users/rpetrusha/gists{/gist_id}","starred_url":"https://api.github.com/users/rpetrusha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpetrusha/subscriptions","organizations_url":"https://api.github.com/users/rpetrusha/orgs","repos_url":"https://api.github.com/users/rpetrusha/repos","events_url":"https://api.github.com/users/rpetrusha/events{/privacy}","received_events_url":"https://api.github.com/users/rpetrusha/received_events","type":"User","site_admin":false},"repo":{"id":73105712,"name":"docs","full_name":"rpetrusha/docs","owner":{"login":"rpetrusha","id":10886961,"avatar_url":"https://avatars2.githubusercontent.com/u/10886961?v=4","gravatar_id":"","url":"https://api.github.com/users/rpetrusha","html_url":"https://github.com/rpetrusha","followers_url":"https://api.github.com/users/rpetrusha/followers","following_url":"https://api.github.com/users/rpetrusha/following{/other_user}","gists_url":"https://api.github.com/users/rpetrusha/gists{/gist_id}","starred_url":"https://api.github.com/users/rpetrusha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpetrusha/subscriptions","organizations_url":"https://api.github.com/users/rpetrusha/orgs","repos_url":"https://api.github.com/users/rpetrusha/repos","events_url":"https://api.github.com/users/rpetrusha/events{/privacy}","received_events_url":"https://api.github.com/users/rpetrusha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rpetrusha/docs","description":"This repository contains .NET Documentation.","fork":true,"url":"https://api.github.com/repos/rpetrusha/docs","forks_url":"https://api.github.com/repos/rpetrusha/docs/forks","keys_url":"https://api.github.com/repos/rpetrusha/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpetrusha/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpetrusha/docs/teams","hooks_url":"https://api.github.com/repos/rpetrusha/docs/hooks","issue_events_url":"https://api.github.com/repos/rpetrusha/docs/issues/events{/number}","events_url":"https://api.github.com/repos/rpetrusha/docs/events","assignees_url":"https://api.github.com/repos/rpetrusha/docs/assignees{/user}","branches_url":"https://api.github.com/repos/rpetrusha/docs/branches{/branch}","tags_url":"https://api.github.com/repos/rpetrusha/docs/tags","blobs_url":"https://api.github.com/repos/rpetrusha/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpetrusha/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpetrusha/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpetrusha/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpetrusha/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/rpetrusha/docs/languages","stargazers_url":"https://api.github.com/repos/rpetrusha/docs/stargazers","contributors_url":"https://api.github.com/repos/rpetrusha/docs/contributors","subscribers_url":"https://api.github.com/repos/rpetrusha/docs/subscribers","subscription_url":"https://api.github.com/repos/rpetrusha/docs/subscription","commits_url":"https://api.github.com/repos/rpetrusha/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpetrusha/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpetrusha/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpetrusha/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpetrusha/docs/contents/{+path}","compare_url":"https://api.github.com/repos/rpetrusha/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpetrusha/docs/merges","archive_url":"https://api.github.com/repos/rpetrusha/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpetrusha/docs/downloads","issues_url":"https://api.github.com/repos/rpetrusha/docs/issues{/number}","pulls_url":"https://api.github.com/repos/rpetrusha/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/rpetrusha/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/rpetrusha/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpetrusha/docs/labels{/name}","releases_url":"https://api.github.com/repos/rpetrusha/docs/releases{/id}","deployments_url":"https://api.github.com/repos/rpetrusha/docs/deployments","created_at":"2016-11-07T17:56:06Z","updated_at":"2017-04-12T22:02:51Z","pushed_at":"2017-09-30T00:06:49Z","git_url":"git://github.com/rpetrusha/docs.git","ssh_url":"[email protected]:rpetrusha/docs.git","clone_url":"https://github.com/rpetrusha/docs.git","svn_url":"https://github.com/rpetrusha/docs","homepage":"https://docs.microsoft.com/dotnet","size":336807,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"8331fb6690af589d73cb3246f1fe9ab2050648c7","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":35890081,"name":"docs","full_name":"dotnet/docs","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/docs","description":"This repository contains .NET Documentation.","fork":false,"url":"https://api.github.com/repos/dotnet/docs","forks_url":"https://api.github.com/repos/dotnet/docs/forks","keys_url":"https://api.github.com/repos/dotnet/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/docs/teams","hooks_url":"https://api.github.com/repos/dotnet/docs/hooks","issue_events_url":"https://api.github.com/repos/dotnet/docs/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/docs/events","assignees_url":"https://api.github.com/repos/dotnet/docs/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/docs/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/docs/tags","blobs_url":"https://api.github.com/repos/dotnet/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/docs/languages","stargazers_url":"https://api.github.com/repos/dotnet/docs/stargazers","contributors_url":"https://api.github.com/repos/dotnet/docs/contributors","subscribers_url":"https://api.github.com/repos/dotnet/docs/subscribers","subscription_url":"https://api.github.com/repos/dotnet/docs/subscription","commits_url":"https://api.github.com/repos/dotnet/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/docs/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/docs/merges","archive_url":"https://api.github.com/repos/dotnet/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/docs/downloads","issues_url":"https://api.github.com/repos/dotnet/docs/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/docs/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/docs/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/docs/deployments","created_at":"2015-05-19T15:13:32Z","updated_at":"2017-09-29T13:53:38Z","pushed_at":"2017-09-30T00:30:41Z","git_url":"git://github.com/dotnet/docs.git","ssh_url":"[email protected]:dotnet/docs.git","clone_url":"https://github.com/dotnet/docs.git","svn_url":"https://github.com/dotnet/docs","homepage":"https://docs.microsoft.com/dotnet","size":439528,"stargazers_count":672,"watchers_count":672,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1340,"mirror_url":null,"open_issues_count":332,"forks":1340,"open_issues":332,"watchers":672,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/docs/pulls/3288"},"html":{"href":"https://github.com/dotnet/docs/pull/3288"},"issue":{"href":"https://api.github.com/repos/dotnet/docs/issues/3288"},"comments":{"href":"https://api.github.com/repos/dotnet/docs/issues/3288/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/docs/pulls/3288/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/docs/pulls/3288/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/docs/statuses/f5d3a3a0a38464e48f6f9b0da6289a3020994415"}},"author_association":"CONTRIBUTOR"}} | {
"id": 35890081,
"name": "dotnet/docs",
"url": "https://api.github.com/repos/dotnet/docs"
} | {
"id": 12971179,
"login": "mairaw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12971179?",
"url": "https://api.github.com/users/mairaw"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2017-09-30T00:38:23 | 6657081782 | {"actor":{"display_login":"mairaw"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/core-setup/pulls/comments/111606141","pull_request_review_id":32864709,"id":111606141,"diff_hunk":"@@ -15,22 +15,24 @@ if /i \"%1\" == \"-portable\" (set __PortableBuildArgs=true&shift&goto A\n \n :: Initialize the MSBuild Tools\n call \"%__ProjectDir%\\init-tools.cmd\"\n+if ERRORLEVEL 1 goto :Error\n \n :: Restore dependencies mainly to obtain runtime.json\n pushd \"%__ProjectDir%\\deps\"\n \"%__DotNet%\" restore --configfile \"%__ProjectDir%\\..\\NuGet.Config\" --packages \"%__ProjectDir%\\packages\"\n+if ERRORLEVEL 1 goto :Error\n popd\n \n :: Clean up existing nupkgs\n if exist \"%__ProjectDir%\\bin\" (rmdir /s /q \"%__ProjectDir%\\bin\")\n \n \"%__DotNet%\" \"%__MSBuild%\" \"%__ProjectDir%\\tasks\\core-setup.tasks.builds\" /verbosity:minimal /flp:logfile=tools.log;v=diag\n-if not ERRORLEVEL 0 goto :Error\n+if ERRORLEVEL 1 goto :Error","path":"pkg/pack.cmd","position":17,"original_position":17,"commit_id":"02e606623d2d8524ce35b618bd216dc5ce9cdef3","original_commit_id":"02e606623d2d8524ce35b618bd216dc5ce9cdef3","user":{"login":"dagood","id":12819531,"avatar_url":"https://avatars0.githubusercontent.com/u/12819531?v=3","gravatar_id":"","url":"https://api.github.com/users/dagood","html_url":"https://github.com/dagood","followers_url":"https://api.github.com/users/dagood/followers","following_url":"https://api.github.com/users/dagood/following{/other_user}","gists_url":"https://api.github.com/users/dagood/gists{/gist_id}","starred_url":"https://api.github.com/users/dagood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagood/subscriptions","organizations_url":"https://api.github.com/users/dagood/orgs","repos_url":"https://api.github.com/users/dagood/repos","events_url":"https://api.github.com/users/dagood/events{/privacy}","received_events_url":"https://api.github.com/users/dagood/received_events","type":"User","site_admin":false},"body":"I'm not actually able to find this documented for msbuild.exe. I'll change it to a != check.","created_at":"2017-04-14T17:29:50Z","updated_at":"2017-04-14T17:29:50Z","html_url":"https://github.com/dotnet/core-setup/pull/2067#discussion_r111606141","pull_request_url":"https://api.github.com/repos/dotnet/core-setup/pulls/2067","_links":{"self":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/comments/111606141"},"html":{"href":"https://github.com/dotnet/core-setup/pull/2067#discussion_r111606141"},"pull_request":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/2067"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/core-setup/pulls/2067","id":115960445,"html_url":"https://github.com/dotnet/core-setup/pull/2067","diff_url":"https://github.com/dotnet/core-setup/pull/2067.diff","patch_url":"https://github.com/dotnet/core-setup/pull/2067.patch","issue_url":"https://api.github.com/repos/dotnet/core-setup/issues/2067","number":2067,"state":"open","locked":false,"title":"Fix pack.cmd ERRORLEVEL early exits","user":{"login":"dagood","id":12819531,"avatar_url":"https://avatars0.githubusercontent.com/u/12819531?v=3","gravatar_id":"","url":"https://api.github.com/users/dagood","html_url":"https://github.com/dagood","followers_url":"https://api.github.com/users/dagood/followers","following_url":"https://api.github.com/users/dagood/following{/other_user}","gists_url":"https://api.github.com/users/dagood/gists{/gist_id}","starred_url":"https://api.github.com/users/dagood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagood/subscriptions","organizations_url":"https://api.github.com/users/dagood/orgs","repos_url":"https://api.github.com/users/dagood/repos","events_url":"https://api.github.com/users/dagood/events{/privacy}","received_events_url":"https://api.github.com/users/dagood/received_events","type":"User","site_admin":false},"body":"`if ERRORLEVEL x` runs if ERRORLEVEL >= x. `if not ERRORLEVEL 0` means ERRORLEVEL < 0, which doesn't detect the error we get. `if ERRORLEVEL 1` is idiomatic in cmd. Negative error levels aren't caught, but those aren't normal in cmd.\r\n\r\nAlso added early exits on steps that didn't have one.\r\n\r\nThis makes it so we can detect issues in pack.cmd rather than only seeing them when they break the build downstream. E.g. https://github.com/dotnet/core-setup/pull/2066","created_at":"2017-04-14T17:17:55Z","updated_at":"2017-04-14T17:29:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"005e2783ae1b06463116556236f4600b50f74cec","assignee":{"login":"dagood","id":12819531,"avatar_url":"https://avatars0.githubusercontent.com/u/12819531?v=3","gravatar_id":"","url":"https://api.github.com/users/dagood","html_url":"https://github.com/dagood","followers_url":"https://api.github.com/users/dagood/followers","following_url":"https://api.github.com/users/dagood/following{/other_user}","gists_url":"https://api.github.com/users/dagood/gists{/gist_id}","starred_url":"https://api.github.com/users/dagood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagood/subscriptions","organizations_url":"https://api.github.com/users/dagood/orgs","repos_url":"https://api.github.com/users/dagood/repos","events_url":"https://api.github.com/users/dagood/events{/privacy}","received_events_url":"https://api.github.com/users/dagood/received_events","type":"User","site_admin":false},"assignees":[{"login":"dagood","id":12819531,"avatar_url":"https://avatars0.githubusercontent.com/u/12819531?v=3","gravatar_id":"","url":"https://api.github.com/users/dagood","html_url":"https://github.com/dagood","followers_url":"https://api.github.com/users/dagood/followers","following_url":"https://api.github.com/users/dagood/following{/other_user}","gists_url":"https://api.github.com/users/dagood/gists{/gist_id}","starred_url":"https://api.github.com/users/dagood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagood/subscriptions","organizations_url":"https://api.github.com/users/dagood/orgs","repos_url":"https://api.github.com/users/dagood/repos","events_url":"https://api.github.com/users/dagood/events{/privacy}","received_events_url":"https://api.github.com/users/dagood/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/core-setup/pulls/2067/commits","review_comments_url":"https://api.github.com/repos/dotnet/core-setup/pulls/2067/comments","review_comment_url":"https://api.github.com/repos/dotnet/core-setup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/core-setup/issues/2067/comments","statuses_url":"https://api.github.com/repos/dotnet/core-setup/statuses/02e606623d2d8524ce35b618bd216dc5ce9cdef3","head":{"label":"dagood:pkg-fail","ref":"pkg-fail","sha":"02e606623d2d8524ce35b618bd216dc5ce9cdef3","user":{"login":"dagood","id":12819531,"avatar_url":"https://avatars0.githubusercontent.com/u/12819531?v=3","gravatar_id":"","url":"https://api.github.com/users/dagood","html_url":"https://github.com/dagood","followers_url":"https://api.github.com/users/dagood/followers","following_url":"https://api.github.com/users/dagood/following{/other_user}","gists_url":"https://api.github.com/users/dagood/gists{/gist_id}","starred_url":"https://api.github.com/users/dagood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagood/subscriptions","organizations_url":"https://api.github.com/users/dagood/orgs","repos_url":"https://api.github.com/users/dagood/repos","events_url":"https://api.github.com/users/dagood/events{/privacy}","received_events_url":"https://api.github.com/users/dagood/received_events","type":"User","site_admin":false},"repo":{"id":60734084,"name":"core-setup","full_name":"dagood/core-setup","owner":{"login":"dagood","id":12819531,"avatar_url":"https://avatars0.githubusercontent.com/u/12819531?v=3","gravatar_id":"","url":"https://api.github.com/users/dagood","html_url":"https://github.com/dagood","followers_url":"https://api.github.com/users/dagood/followers","following_url":"https://api.github.com/users/dagood/following{/other_user}","gists_url":"https://api.github.com/users/dagood/gists{/gist_id}","starred_url":"https://api.github.com/users/dagood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagood/subscriptions","organizations_url":"https://api.github.com/users/dagood/orgs","repos_url":"https://api.github.com/users/dagood/repos","events_url":"https://api.github.com/users/dagood/events{/privacy}","received_events_url":"https://api.github.com/users/dagood/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dagood/core-setup","description":"Installer packages for the .NET Core runtime and libraries","fork":true,"url":"https://api.github.com/repos/dagood/core-setup","forks_url":"https://api.github.com/repos/dagood/core-setup/forks","keys_url":"https://api.github.com/repos/dagood/core-setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dagood/core-setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dagood/core-setup/teams","hooks_url":"https://api.github.com/repos/dagood/core-setup/hooks","issue_events_url":"https://api.github.com/repos/dagood/core-setup/issues/events{/number}","events_url":"https://api.github.com/repos/dagood/core-setup/events","assignees_url":"https://api.github.com/repos/dagood/core-setup/assignees{/user}","branches_url":"https://api.github.com/repos/dagood/core-setup/branches{/branch}","tags_url":"https://api.github.com/repos/dagood/core-setup/tags","blobs_url":"https://api.github.com/repos/dagood/core-setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dagood/core-setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dagood/core-setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/dagood/core-setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dagood/core-setup/statuses/{sha}","languages_url":"https://api.github.com/repos/dagood/core-setup/languages","stargazers_url":"https://api.github.com/repos/dagood/core-setup/stargazers","contributors_url":"https://api.github.com/repos/dagood/core-setup/contributors","subscribers_url":"https://api.github.com/repos/dagood/core-setup/subscribers","subscription_url":"https://api.github.com/repos/dagood/core-setup/subscription","commits_url":"https://api.github.com/repos/dagood/core-setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/dagood/core-setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/dagood/core-setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/dagood/core-setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/dagood/core-setup/contents/{+path}","compare_url":"https://api.github.com/repos/dagood/core-setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dagood/core-setup/merges","archive_url":"https://api.github.com/repos/dagood/core-setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dagood/core-setup/downloads","issues_url":"https://api.github.com/repos/dagood/core-setup/issues{/number}","pulls_url":"https://api.github.com/repos/dagood/core-setup/pulls{/number}","milestones_url":"https://api.github.com/repos/dagood/core-setup/milestones{/number}","notifications_url":"https://api.github.com/repos/dagood/core-setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dagood/core-setup/labels{/name}","releases_url":"https://api.github.com/repos/dagood/core-setup/releases{/id}","deployments_url":"https://api.github.com/repos/dagood/core-setup/deployments","created_at":"2016-06-08T22:09:18Z","updated_at":"2016-06-08T22:09:19Z","pushed_at":"2017-04-14T17:15:40Z","git_url":"git://github.com/dagood/core-setup.git","ssh_url":"[email protected]:dagood/core-setup.git","clone_url":"https://github.com/dagood/core-setup.git","svn_url":"https://github.com/dagood/core-setup","homepage":"","size":1993,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"9c0b3992105157a4ce9e53f383392cf90350b053","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":59249196,"name":"core-setup","full_name":"dotnet/core-setup","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/core-setup","description":"Installer packages for the .NET Core runtime and libraries","fork":false,"url":"https://api.github.com/repos/dotnet/core-setup","forks_url":"https://api.github.com/repos/dotnet/core-setup/forks","keys_url":"https://api.github.com/repos/dotnet/core-setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/core-setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/core-setup/teams","hooks_url":"https://api.github.com/repos/dotnet/core-setup/hooks","issue_events_url":"https://api.github.com/repos/dotnet/core-setup/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/core-setup/events","assignees_url":"https://api.github.com/repos/dotnet/core-setup/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/core-setup/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/core-setup/tags","blobs_url":"https://api.github.com/repos/dotnet/core-setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/core-setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/core-setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/core-setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/core-setup/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/core-setup/languages","stargazers_url":"https://api.github.com/repos/dotnet/core-setup/stargazers","contributors_url":"https://api.github.com/repos/dotnet/core-setup/contributors","subscribers_url":"https://api.github.com/repos/dotnet/core-setup/subscribers","subscription_url":"https://api.github.com/repos/dotnet/core-setup/subscription","commits_url":"https://api.github.com/repos/dotnet/core-setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/core-setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/core-setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/core-setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/core-setup/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/core-setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/core-setup/merges","archive_url":"https://api.github.com/repos/dotnet/core-setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/core-setup/downloads","issues_url":"https://api.github.com/repos/dotnet/core-setup/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/core-setup/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/core-setup/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/core-setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/core-setup/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/core-setup/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/core-setup/deployments","created_at":"2016-05-19T23:07:13Z","updated_at":"2017-04-04T22:54:25Z","pushed_at":"2017-04-14T17:28:51Z","git_url":"git://github.com/dotnet/core-setup.git","ssh_url":"[email protected]:dotnet/core-setup.git","clone_url":"https://github.com/dotnet/core-setup.git","svn_url":"https://github.com/dotnet/core-setup","homepage":"","size":3140,"stargazers_count":61,"watchers_count":61,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":122,"forks":80,"open_issues":122,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/2067"},"html":{"href":"https://github.com/dotnet/core-setup/pull/2067"},"issue":{"href":"https://api.github.com/repos/dotnet/core-setup/issues/2067"},"comments":{"href":"https://api.github.com/repos/dotnet/core-setup/issues/2067/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/2067/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/core-setup/pulls/2067/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/core-setup/statuses/02e606623d2d8524ce35b618bd216dc5ce9cdef3"}}}} | {
"id": 59249196,
"name": "dotnet/core-setup",
"url": "https://api.github.com/repos/dotnet/core-setup"
} | {
"id": 12819531,
"login": "dagood",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12819531?",
"url": "https://api.github.com/users/dagood"
} | {
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
} | 2017-04-14T17:29:50 | 5691512883 | {"actor":{"display_login":"dagood"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/eslint/eslint/pulls/comments/139317323","pull_request_review_id":63233176,"id":139317323,"diff_hunk":"@@ -241,6 +241,26 @@ Map {\n */\n ```\n \n+### Linter#defineParser\n+\n+Each instance of `Linter` holds a map of custom parsers. If you want to define a parser programmaticaly you can add this function\n+with the name of the parser as first argument and the parser object (having either `parseForESLint` or `parse` as keys) as second argument.\n+\n+If during linting the parser is not found it will fallback to `require(parserId)`.\n+\n+```js\n+const Linter = require(\"eslint\").Linter;\n+const linter = new Linter();\n+\n+linter.defineParser(\"my-custom-parser\", {\n+ parse(code, options) {\n+ // ...\n+ }\n+});\n+\n+const results = linter.verify(\"// some source text\", { parser: 'my-custom-parser' });","path":"docs/developer-guide/nodejs-api.md","position":21,"original_position":21,"commit_id":"0601a243375ae69626da00cfebfbda8558bc9de7","original_commit_id":"0601a243375ae69626da00cfebfbda8558bc9de7","user":{"login":"not-an-aardvark","id":11638619,"avatar_url":"https://avatars2.githubusercontent.com/u/11638619?v=4","gravatar_id":"","url":"https://api.github.com/users/not-an-aardvark","html_url":"https://github.com/not-an-aardvark","followers_url":"https://api.github.com/users/not-an-aardvark/followers","following_url":"https://api.github.com/users/not-an-aardvark/following{/other_user}","gists_url":"https://api.github.com/users/not-an-aardvark/gists{/gist_id}","starred_url":"https://api.github.com/users/not-an-aardvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/not-an-aardvark/subscriptions","organizations_url":"https://api.github.com/users/not-an-aardvark/orgs","repos_url":"https://api.github.com/users/not-an-aardvark/repos","events_url":"https://api.github.com/users/not-an-aardvark/events{/privacy}","received_events_url":"https://api.github.com/users/not-an-aardvark/received_events","type":"User","site_admin":false},"body":"Nitpick: For consistency, can you use double quotes for `\"my-custom-parser\"`?","created_at":"2017-09-17T18:15:08Z","updated_at":"2017-09-17T18:27:09Z","html_url":"https://github.com/eslint/eslint/pull/9321#discussion_r139317323","pull_request_url":"https://api.github.com/repos/eslint/eslint/pulls/9321","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments/139317323"},"html":{"href":"https://github.com/eslint/eslint/pull/9321#discussion_r139317323"},"pull_request":{"href":"https://api.github.com/repos/eslint/eslint/pulls/9321"}}},"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/9321","id":141491058,"html_url":"https://github.com/eslint/eslint/pull/9321","diff_url":"https://github.com/eslint/eslint/pull/9321.diff","patch_url":"https://github.com/eslint/eslint/pull/9321.patch","issue_url":"https://api.github.com/repos/eslint/eslint/issues/9321","number":9321,"state":"open","locked":false,"title":"New: add a defineParser function","user":{"login":"CompuIves","id":587016,"avatar_url":"https://avatars3.githubusercontent.com/u/587016?v=4","gravatar_id":"","url":"https://api.github.com/users/CompuIves","html_url":"https://github.com/CompuIves","followers_url":"https://api.github.com/users/CompuIves/followers","following_url":"https://api.github.com/users/CompuIves/following{/other_user}","gists_url":"https://api.github.com/users/CompuIves/gists{/gist_id}","starred_url":"https://api.github.com/users/CompuIves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CompuIves/subscriptions","organizations_url":"https://api.github.com/users/CompuIves/orgs","repos_url":"https://api.github.com/users/CompuIves/repos","events_url":"https://api.github.com/users/CompuIves/events{/privacy}","received_events_url":"https://api.github.com/users/CompuIves/received_events","type":"User","site_admin":false},"body":"<!--\r\n ESLint adheres to the [JS Foundation Code of Conduct](https://js.foundation/community/code-of-conduct).\r\n-->\r\n\r\n**What is the purpose of this pull request? (put an \"X\" next to item)**\r\n\r\n[x] Documentation update\r\n[ ] Bug fix ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/bug-report.md))\r\n[ ] New rule ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/rule-proposal.md))\r\n[ ] Changes an existing rule ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/rule-change-proposal.md))\r\n[ ] Add autofixing to a rule\r\n[ ] Add a CLI option\r\n[x] Add something to the core\r\n[ ] Other, please explain:\r\n\r\n<!--\r\n If the item you've checked above has a template, please paste the template questions below and answer them. (If this pull request is addressing an issue, you can just paste a link to the issue here instead.)\r\n-->\r\n\r\n<!--\r\n Please ensure your pull request is ready:\r\n\r\n - Read the pull request guide (http://eslint.org/docs/developer-guide/contributing/pull-requests)\r\n - Include tests for this change\r\n - Update documentation for this change (if appropriate)\r\n-->\r\n\r\n<!--\r\n The following is required for all pull requests:\r\n-->\r\n\r\n**What changes did you make? (Give an overview)**\r\n\r\nI added an `defineParser` function to the Node API, which allows you to define a custom parser that `eslint` will use when defined in the config.\r\n\r\n**Is there anything you'd like reviewers to focus on?**\r\n\r\nI'm not sure if the implementation is desired, returning the error object for errors doesn't feel right. I'm also not sure if I added enough tests.\r\n","created_at":"2017-09-17T15:43:42Z","updated_at":"2017-09-17T18:27:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e205099f699dd58860059165edef84477abec236","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/eslint/eslint/pulls/9321/commits","review_comments_url":"https://api.github.com/repos/eslint/eslint/pulls/9321/comments","review_comment_url":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/9321/comments","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/0601a243375ae69626da00cfebfbda8558bc9de7","head":{"label":"CompuIves:add/define-parser","ref":"add/define-parser","sha":"0601a243375ae69626da00cfebfbda8558bc9de7","user":{"login":"CompuIves","id":587016,"avatar_url":"https://avatars3.githubusercontent.com/u/587016?v=4","gravatar_id":"","url":"https://api.github.com/users/CompuIves","html_url":"https://github.com/CompuIves","followers_url":"https://api.github.com/users/CompuIves/followers","following_url":"https://api.github.com/users/CompuIves/following{/other_user}","gists_url":"https://api.github.com/users/CompuIves/gists{/gist_id}","starred_url":"https://api.github.com/users/CompuIves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CompuIves/subscriptions","organizations_url":"https://api.github.com/users/CompuIves/orgs","repos_url":"https://api.github.com/users/CompuIves/repos","events_url":"https://api.github.com/users/CompuIves/events{/privacy}","received_events_url":"https://api.github.com/users/CompuIves/received_events","type":"User","site_admin":false},"repo":{"id":100545375,"name":"eslint","full_name":"CompuIves/eslint","owner":{"login":"CompuIves","id":587016,"avatar_url":"https://avatars3.githubusercontent.com/u/587016?v=4","gravatar_id":"","url":"https://api.github.com/users/CompuIves","html_url":"https://github.com/CompuIves","followers_url":"https://api.github.com/users/CompuIves/followers","following_url":"https://api.github.com/users/CompuIves/following{/other_user}","gists_url":"https://api.github.com/users/CompuIves/gists{/gist_id}","starred_url":"https://api.github.com/users/CompuIves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CompuIves/subscriptions","organizations_url":"https://api.github.com/users/CompuIves/orgs","repos_url":"https://api.github.com/users/CompuIves/repos","events_url":"https://api.github.com/users/CompuIves/events{/privacy}","received_events_url":"https://api.github.com/users/CompuIves/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CompuIves/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":true,"url":"https://api.github.com/repos/CompuIves/eslint","forks_url":"https://api.github.com/repos/CompuIves/eslint/forks","keys_url":"https://api.github.com/repos/CompuIves/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CompuIves/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CompuIves/eslint/teams","hooks_url":"https://api.github.com/repos/CompuIves/eslint/hooks","issue_events_url":"https://api.github.com/repos/CompuIves/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/CompuIves/eslint/events","assignees_url":"https://api.github.com/repos/CompuIves/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/CompuIves/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/CompuIves/eslint/tags","blobs_url":"https://api.github.com/repos/CompuIves/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CompuIves/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CompuIves/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/CompuIves/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CompuIves/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/CompuIves/eslint/languages","stargazers_url":"https://api.github.com/repos/CompuIves/eslint/stargazers","contributors_url":"https://api.github.com/repos/CompuIves/eslint/contributors","subscribers_url":"https://api.github.com/repos/CompuIves/eslint/subscribers","subscription_url":"https://api.github.com/repos/CompuIves/eslint/subscription","commits_url":"https://api.github.com/repos/CompuIves/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/CompuIves/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/CompuIves/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/CompuIves/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/CompuIves/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/CompuIves/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CompuIves/eslint/merges","archive_url":"https://api.github.com/repos/CompuIves/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CompuIves/eslint/downloads","issues_url":"https://api.github.com/repos/CompuIves/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/CompuIves/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/CompuIves/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/CompuIves/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CompuIves/eslint/labels{/name}","releases_url":"https://api.github.com/repos/CompuIves/eslint/releases{/id}","deployments_url":"https://api.github.com/repos/CompuIves/eslint/deployments","created_at":"2017-08-17T00:49:09Z","updated_at":"2017-08-17T00:49:15Z","pushed_at":"2017-09-17T15:42:00Z","git_url":"git://github.com/CompuIves/eslint.git","ssh_url":"[email protected]:CompuIves/eslint.git","clone_url":"https://github.com/CompuIves/eslint.git","svn_url":"https://github.com/CompuIves/eslint","homepage":"http://eslint.org","size":16355,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eslint:master","ref":"master","sha":"439e8e697f761bebeb3dab085ba85139829397b2","user":{"login":"eslint","id":6019716,"avatar_url":"https://avatars3.githubusercontent.com/u/6019716?v=4","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"repo":{"id":11061773,"name":"eslint","full_name":"eslint/eslint","owner":{"login":"eslint","id":6019716,"avatar_url":"https://avatars3.githubusercontent.com/u/6019716?v=4","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eslint/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":false,"url":"https://api.github.com/repos/eslint/eslint","forks_url":"https://api.github.com/repos/eslint/eslint/forks","keys_url":"https://api.github.com/repos/eslint/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eslint/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eslint/eslint/teams","hooks_url":"https://api.github.com/repos/eslint/eslint/hooks","issue_events_url":"https://api.github.com/repos/eslint/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/eslint/eslint/events","assignees_url":"https://api.github.com/repos/eslint/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/eslint/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/eslint/eslint/tags","blobs_url":"https://api.github.com/repos/eslint/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eslint/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eslint/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/eslint/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/eslint/eslint/languages","stargazers_url":"https://api.github.com/repos/eslint/eslint/stargazers","contributors_url":"https://api.github.com/repos/eslint/eslint/contributors","subscribers_url":"https://api.github.com/repos/eslint/eslint/subscribers","subscription_url":"https://api.github.com/repos/eslint/eslint/subscription","commits_url":"https://api.github.com/repos/eslint/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/eslint/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/eslint/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/eslint/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/eslint/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/eslint/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eslint/eslint/merges","archive_url":"https://api.github.com/repos/eslint/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eslint/eslint/downloads","issues_url":"https://api.github.com/repos/eslint/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/eslint/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/eslint/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/eslint/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eslint/eslint/labels{/name}","releases_url":"https://api.github.com/repos/eslint/eslint/releases{/id}","deployments_url":"https://api.github.com/repos/eslint/eslint/deployments","created_at":"2013-06-29T23:59:48Z","updated_at":"2017-09-17T10:18:14Z","pushed_at":"2017-09-17T17:42:33Z","git_url":"git://github.com/eslint/eslint.git","ssh_url":"[email protected]:eslint/eslint.git","clone_url":"https://github.com/eslint/eslint.git","svn_url":"https://github.com/eslint/eslint","homepage":"https://eslint.org","size":16359,"stargazers_count":8602,"watchers_count":8602,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1624,"mirror_url":null,"open_issues_count":218,"forks":1624,"open_issues":218,"watchers":8602,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/9321"},"html":{"href":"https://github.com/eslint/eslint/pull/9321"},"issue":{"href":"https://api.github.com/repos/eslint/eslint/issues/9321"},"comments":{"href":"https://api.github.com/repos/eslint/eslint/issues/9321/comments"},"review_comments":{"href":"https://api.github.com/repos/eslint/eslint/pulls/9321/comments"},"review_comment":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eslint/eslint/pulls/9321/commits"},"statuses":{"href":"https://api.github.com/repos/eslint/eslint/statuses/0601a243375ae69626da00cfebfbda8558bc9de7"}},"author_association":"NONE"}} | {
"id": 11061773,
"name": "eslint/eslint",
"url": "https://api.github.com/repos/eslint/eslint"
} | {
"id": 11638619,
"login": "not-an-aardvark",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11638619?",
"url": "https://api.github.com/users/not-an-aardvark"
} | {
"id": 6019716,
"login": "eslint",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6019716?",
"url": "https://api.github.com/orgs/eslint"
} | 2017-09-17T18:15:08 | 6600947031 | {"actor":{"display_login":"not-an-aardvark"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/fcrepo/fcrepo-specification/pulls/comments/107814456","pull_request_review_id":28809258,"id":107814456,"diff_hunk":"@@ -1002,6 +1002,39 @@ <h2 class='informative'>Implementation Patterns</h2>\n </section>\n </section>\n \n+ <section id=\"privacy\">\n+ <h2>Privacy Considerations</h2>\n+ <p>\n+ Fedora resources may contain personally identifiable information such as the identify of\n+ the agents who create and modify resources. As such, this information could be analyzed\n+ to generate profiles of the behavior of individuals or groups.\n+ </p>\n+ <p>\n+ As such, Fedora implementations that produce or consume personally identifiable\n+ information MUST clearly document the type and extent of personal information that\n+ is collected and published along with the reasons for doing so.","path":"index.html","position":14,"original_position":14,"commit_id":"f938fb8a9c947e4b8b05b11dea2b13401d719526","original_commit_id":"b703e476c594ec090575281ec707626e1820c53e","user":{"login":"awoods","id":149283,"avatar_url":"https://avatars1.githubusercontent.com/u/149283?v=3","gravatar_id":"","url":"https://api.github.com/users/awoods","html_url":"https://github.com/awoods","followers_url":"https://api.github.com/users/awoods/followers","following_url":"https://api.github.com/users/awoods/following{/other_user}","gists_url":"https://api.github.com/users/awoods/gists{/gist_id}","starred_url":"https://api.github.com/users/awoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awoods/subscriptions","organizations_url":"https://api.github.com/users/awoods/orgs","repos_url":"https://api.github.com/users/awoods/repos","events_url":"https://api.github.com/users/awoods/events{/privacy}","received_events_url":"https://api.github.com/users/awoods/received_events","type":"User","site_admin":false},"body":"Are we blocked on this?","created_at":"2017-03-24T00:27:25Z","updated_at":"2017-03-24T00:27:25Z","html_url":"https://github.com/fcrepo/fcrepo-specification/pull/72#discussion_r107814456","pull_request_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/fcrepo/fcrepo-specification/pulls/comments/107814456"},"html":{"href":"https://github.com/fcrepo/fcrepo-specification/pull/72#discussion_r107814456"},"pull_request":{"href":"https://api.github.com/repos/fcrepo/fcrepo-specification/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/fcrepo/fcrepo-specification/pulls/72","id":111345121,"html_url":"https://github.com/fcrepo/fcrepo-specification/pull/72","diff_url":"https://github.com/fcrepo/fcrepo-specification/pull/72.diff","patch_url":"https://github.com/fcrepo/fcrepo-specification/pull/72.patch","issue_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/issues/72","number":72,"state":"open","locked":false,"title":"Add security and privacy sections","user":{"login":"acoburn","id":1265883,"avatar_url":"https://avatars1.githubusercontent.com/u/1265883?v=3","gravatar_id":"","url":"https://api.github.com/users/acoburn","html_url":"https://github.com/acoburn","followers_url":"https://api.github.com/users/acoburn/followers","following_url":"https://api.github.com/users/acoburn/following{/other_user}","gists_url":"https://api.github.com/users/acoburn/gists{/gist_id}","starred_url":"https://api.github.com/users/acoburn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acoburn/subscriptions","organizations_url":"https://api.github.com/users/acoburn/orgs","repos_url":"https://api.github.com/users/acoburn/repos","events_url":"https://api.github.com/users/acoburn/events{/privacy}","received_events_url":"https://api.github.com/users/acoburn/received_events","type":"User","site_admin":false},"body":"Resolves #70 \r\n\r\nBoth sections are added as normative sections, but it would also be possible to make them non-normative.","created_at":"2017-03-17T18:58:52Z","updated_at":"2017-03-24T00:27:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdcc859b06a9fc9bb4b36fde5eab4ef66bb5e543","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/pulls/72/commits","review_comments_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/pulls/72/comments","review_comment_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/issues/72/comments","statuses_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/statuses/f938fb8a9c947e4b8b05b11dea2b13401d719526","head":{"label":"fcrepo:security","ref":"security","sha":"f938fb8a9c947e4b8b05b11dea2b13401d719526","user":{"login":"fcrepo","id":7585963,"avatar_url":"https://avatars1.githubusercontent.com/u/7585963?v=3","gravatar_id":"","url":"https://api.github.com/users/fcrepo","html_url":"https://github.com/fcrepo","followers_url":"https://api.github.com/users/fcrepo/followers","following_url":"https://api.github.com/users/fcrepo/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo/subscriptions","organizations_url":"https://api.github.com/users/fcrepo/orgs","repos_url":"https://api.github.com/users/fcrepo/repos","events_url":"https://api.github.com/users/fcrepo/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo/received_events","type":"Organization","site_admin":false},"repo":{"id":59212904,"name":"fcrepo-specification","full_name":"fcrepo/fcrepo-specification","owner":{"login":"fcrepo","id":7585963,"avatar_url":"https://avatars1.githubusercontent.com/u/7585963?v=3","gravatar_id":"","url":"https://api.github.com/users/fcrepo","html_url":"https://github.com/fcrepo","followers_url":"https://api.github.com/users/fcrepo/followers","following_url":"https://api.github.com/users/fcrepo/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo/subscriptions","organizations_url":"https://api.github.com/users/fcrepo/orgs","repos_url":"https://api.github.com/users/fcrepo/repos","events_url":"https://api.github.com/users/fcrepo/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fcrepo/fcrepo-specification","description":"Fedora Specification","fork":false,"url":"https://api.github.com/repos/fcrepo/fcrepo-specification","forks_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/forks","keys_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/teams","hooks_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/hooks","issue_events_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/issues/events{/number}","events_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/events","assignees_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/assignees{/user}","branches_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/branches{/branch}","tags_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/tags","blobs_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/git/refs{/sha}","trees_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/statuses/{sha}","languages_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/languages","stargazers_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/stargazers","contributors_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/contributors","subscribers_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/subscribers","subscription_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/subscription","commits_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/commits{/sha}","git_commits_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/git/commits{/sha}","comments_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/comments{/number}","issue_comment_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/issues/comments{/number}","contents_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/contents/{+path}","compare_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/merges","archive_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/downloads","issues_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/issues{/number}","pulls_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/pulls{/number}","milestones_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/milestones{/number}","notifications_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/labels{/name}","releases_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/releases{/id}","deployments_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/deployments","created_at":"2016-05-19T14:15:53Z","updated_at":"2017-02-09T20:22:02Z","pushed_at":"2017-03-23T19:29:42Z","git_url":"git://github.com/fcrepo/fcrepo-specification.git","ssh_url":"[email protected]:fcrepo/fcrepo-specification.git","clone_url":"https://github.com/fcrepo/fcrepo-specification.git","svn_url":"https://github.com/fcrepo/fcrepo-specification","homepage":null,"size":150,"stargazers_count":10,"watchers_count":10,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":12,"forks":12,"open_issues":12,"watchers":10,"default_branch":"master"}},"base":{"label":"fcrepo:master","ref":"master","sha":"c0348a2d056dd74837dd1c5ae72b2a6581039b71","user":{"login":"fcrepo","id":7585963,"avatar_url":"https://avatars1.githubusercontent.com/u/7585963?v=3","gravatar_id":"","url":"https://api.github.com/users/fcrepo","html_url":"https://github.com/fcrepo","followers_url":"https://api.github.com/users/fcrepo/followers","following_url":"https://api.github.com/users/fcrepo/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo/subscriptions","organizations_url":"https://api.github.com/users/fcrepo/orgs","repos_url":"https://api.github.com/users/fcrepo/repos","events_url":"https://api.github.com/users/fcrepo/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo/received_events","type":"Organization","site_admin":false},"repo":{"id":59212904,"name":"fcrepo-specification","full_name":"fcrepo/fcrepo-specification","owner":{"login":"fcrepo","id":7585963,"avatar_url":"https://avatars1.githubusercontent.com/u/7585963?v=3","gravatar_id":"","url":"https://api.github.com/users/fcrepo","html_url":"https://github.com/fcrepo","followers_url":"https://api.github.com/users/fcrepo/followers","following_url":"https://api.github.com/users/fcrepo/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo/subscriptions","organizations_url":"https://api.github.com/users/fcrepo/orgs","repos_url":"https://api.github.com/users/fcrepo/repos","events_url":"https://api.github.com/users/fcrepo/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fcrepo/fcrepo-specification","description":"Fedora Specification","fork":false,"url":"https://api.github.com/repos/fcrepo/fcrepo-specification","forks_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/forks","keys_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/teams","hooks_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/hooks","issue_events_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/issues/events{/number}","events_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/events","assignees_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/assignees{/user}","branches_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/branches{/branch}","tags_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/tags","blobs_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/git/refs{/sha}","trees_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/statuses/{sha}","languages_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/languages","stargazers_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/stargazers","contributors_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/contributors","subscribers_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/subscribers","subscription_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/subscription","commits_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/commits{/sha}","git_commits_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/git/commits{/sha}","comments_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/comments{/number}","issue_comment_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/issues/comments{/number}","contents_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/contents/{+path}","compare_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/merges","archive_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/downloads","issues_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/issues{/number}","pulls_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/pulls{/number}","milestones_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/milestones{/number}","notifications_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/labels{/name}","releases_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/releases{/id}","deployments_url":"https://api.github.com/repos/fcrepo/fcrepo-specification/deployments","created_at":"2016-05-19T14:15:53Z","updated_at":"2017-02-09T20:22:02Z","pushed_at":"2017-03-23T19:29:42Z","git_url":"git://github.com/fcrepo/fcrepo-specification.git","ssh_url":"[email protected]:fcrepo/fcrepo-specification.git","clone_url":"https://github.com/fcrepo/fcrepo-specification.git","svn_url":"https://github.com/fcrepo/fcrepo-specification","homepage":null,"size":150,"stargazers_count":10,"watchers_count":10,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":12,"forks":12,"open_issues":12,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fcrepo/fcrepo-specification/pulls/72"},"html":{"href":"https://github.com/fcrepo/fcrepo-specification/pull/72"},"issue":{"href":"https://api.github.com/repos/fcrepo/fcrepo-specification/issues/72"},"comments":{"href":"https://api.github.com/repos/fcrepo/fcrepo-specification/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/fcrepo/fcrepo-specification/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/fcrepo/fcrepo-specification/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fcrepo/fcrepo-specification/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/fcrepo/fcrepo-specification/statuses/f938fb8a9c947e4b8b05b11dea2b13401d719526"}}}} | {
"id": 59212904,
"name": "fcrepo/fcrepo-specification",
"url": "https://api.github.com/repos/fcrepo/fcrepo-specification"
} | {
"id": 149283,
"login": "awoods",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/149283?",
"url": "https://api.github.com/users/awoods"
} | {
"id": 7585963,
"login": "fcrepo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7585963?",
"url": "https://api.github.com/orgs/fcrepo"
} | 2017-03-24T00:27:25 | 5554528782 | {"actor":{"display_login":"awoods"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/fidals/stroyprombeton/pulls/comments/105532451","pull_request_review_id":26350667,"id":105532451,"diff_hunk":"@@ -69,27 +71,79 @@ def get_context_data(self, **kwargs):\n \n \n @set_csrf_cookie\n-class CategoryPage(catalog.CategoryPage):\n+class CategoryPage(catalog.CategoryPage, ListView):\n+ # for catalog.CategoryPage\n related_model_name = Category().related_model_name\n queryset = ModelPage.objects.prefetch_related(related_model_name)\n pk_url_kwarg = 'category_id'\n template_name = 'catalog/category.html'\n \n+ # for ListView\n+ page_kwarg = 'page_index'\n+ paginate_by = PRODUCTS_PER_PAGE\n+ paginator_max_links_per_page = 8\n+\n def get_object(self, queryset=None):\n category_pk = self.kwargs.get(self.pk_url_kwarg)\n lookup = '{}__id'.format(self.related_model_name)\n return self.queryset.filter(**{lookup: category_pk}).get()\n \n+ def get_queryset(self, **kwargs):\n+ return (Product.objects\n+ .get_by_category(self.object.model, ordering=PRODUCTS_ORDERING)\n+ .select_related('page')[PRODUCTS_PER_PAGE:])","path":"stroyprombeton/views/catalog.py","position":62,"original_position":62,"commit_id":"fb4982a1d60ce6f28dfba9ba385857eda4ffb288","original_commit_id":"fb4982a1d60ce6f28dfba9ba385857eda4ffb288","user":{"login":"duker33","id":3526796,"avatar_url":"https://avatars2.githubusercontent.com/u/3526796?v=3","gravatar_id":"","url":"https://api.github.com/users/duker33","html_url":"https://github.com/duker33","followers_url":"https://api.github.com/users/duker33/followers","following_url":"https://api.github.com/users/duker33/following{/other_user}","gists_url":"https://api.github.com/users/duker33/gists{/gist_id}","starred_url":"https://api.github.com/users/duker33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duker33/subscriptions","organizations_url":"https://api.github.com/users/duker33/orgs","repos_url":"https://api.github.com/users/duker33/repos","events_url":"https://api.github.com/users/duker33/events{/privacy}","received_events_url":"https://api.github.com/users/duker33/received_events","type":"User","site_admin":false},"body":"а зачем ограничивать query_set?\r\nПагинатор сам разберётся какую именно часть query set ему фетчить, я так думаю","created_at":"2017-03-11T12:31:38Z","updated_at":"2017-03-11T12:33:53Z","html_url":"https://github.com/fidals/stroyprombeton/pull/68#discussion_r105532451","pull_request_url":"https://api.github.com/repos/fidals/stroyprombeton/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/fidals/stroyprombeton/pulls/comments/105532451"},"html":{"href":"https://github.com/fidals/stroyprombeton/pull/68#discussion_r105532451"},"pull_request":{"href":"https://api.github.com/repos/fidals/stroyprombeton/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/fidals/stroyprombeton/pulls/68","id":110165439,"html_url":"https://github.com/fidals/stroyprombeton/pull/68","diff_url":"https://github.com/fidals/stroyprombeton/pull/68.diff","patch_url":"https://github.com/fidals/stroyprombeton/pull/68.patch","issue_url":"https://api.github.com/repos/fidals/stroyprombeton/issues/68","number":68,"state":"open","locked":false,"title":"Trello fixes 10.03.17","user":{"login":"YozhEzhi","id":2706062,"avatar_url":"https://avatars2.githubusercontent.com/u/2706062?v=3","gravatar_id":"","url":"https://api.github.com/users/YozhEzhi","html_url":"https://github.com/YozhEzhi","followers_url":"https://api.github.com/users/YozhEzhi/followers","following_url":"https://api.github.com/users/YozhEzhi/following{/other_user}","gists_url":"https://api.github.com/users/YozhEzhi/gists{/gist_id}","starred_url":"https://api.github.com/users/YozhEzhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YozhEzhi/subscriptions","organizations_url":"https://api.github.com/users/YozhEzhi/orgs","repos_url":"https://api.github.com/users/YozhEzhi/repos","events_url":"https://api.github.com/users/YozhEzhi/events{/privacy}","received_events_url":"https://api.github.com/users/YozhEzhi/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-10T16:45:14Z","updated_at":"2017-03-11T12:33:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b127d00f18c64b05da95c99251fc14deca44968","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fidals/stroyprombeton/pulls/68/commits","review_comments_url":"https://api.github.com/repos/fidals/stroyprombeton/pulls/68/comments","review_comment_url":"https://api.github.com/repos/fidals/stroyprombeton/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fidals/stroyprombeton/issues/68/comments","statuses_url":"https://api.github.com/repos/fidals/stroyprombeton/statuses/fb4982a1d60ce6f28dfba9ba385857eda4ffb288","head":{"label":"fidals:trello_fixes_10_03_17","ref":"trello_fixes_10_03_17","sha":"fb4982a1d60ce6f28dfba9ba385857eda4ffb288","user":{"login":"fidals","id":16228604,"avatar_url":"https://avatars3.githubusercontent.com/u/16228604?v=3","gravatar_id":"","url":"https://api.github.com/users/fidals","html_url":"https://github.com/fidals","followers_url":"https://api.github.com/users/fidals/followers","following_url":"https://api.github.com/users/fidals/following{/other_user}","gists_url":"https://api.github.com/users/fidals/gists{/gist_id}","starred_url":"https://api.github.com/users/fidals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fidals/subscriptions","organizations_url":"https://api.github.com/users/fidals/orgs","repos_url":"https://api.github.com/users/fidals/repos","events_url":"https://api.github.com/users/fidals/events{/privacy}","received_events_url":"https://api.github.com/users/fidals/received_events","type":"Organization","site_admin":false},"repo":{"id":62544799,"name":"stroyprombeton","full_name":"fidals/stroyprombeton","owner":{"login":"fidals","id":16228604,"avatar_url":"https://avatars3.githubusercontent.com/u/16228604?v=3","gravatar_id":"","url":"https://api.github.com/users/fidals","html_url":"https://github.com/fidals","followers_url":"https://api.github.com/users/fidals/followers","following_url":"https://api.github.com/users/fidals/following{/other_user}","gists_url":"https://api.github.com/users/fidals/gists{/gist_id}","starred_url":"https://api.github.com/users/fidals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fidals/subscriptions","organizations_url":"https://api.github.com/users/fidals/orgs","repos_url":"https://api.github.com/users/fidals/repos","events_url":"https://api.github.com/users/fidals/events{/privacy}","received_events_url":"https://api.github.com/users/fidals/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fidals/stroyprombeton","description":null,"fork":false,"url":"https://api.github.com/repos/fidals/stroyprombeton","forks_url":"https://api.github.com/repos/fidals/stroyprombeton/forks","keys_url":"https://api.github.com/repos/fidals/stroyprombeton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fidals/stroyprombeton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fidals/stroyprombeton/teams","hooks_url":"https://api.github.com/repos/fidals/stroyprombeton/hooks","issue_events_url":"https://api.github.com/repos/fidals/stroyprombeton/issues/events{/number}","events_url":"https://api.github.com/repos/fidals/stroyprombeton/events","assignees_url":"https://api.github.com/repos/fidals/stroyprombeton/assignees{/user}","branches_url":"https://api.github.com/repos/fidals/stroyprombeton/branches{/branch}","tags_url":"https://api.github.com/repos/fidals/stroyprombeton/tags","blobs_url":"https://api.github.com/repos/fidals/stroyprombeton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fidals/stroyprombeton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fidals/stroyprombeton/git/refs{/sha}","trees_url":"https://api.github.com/repos/fidals/stroyprombeton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fidals/stroyprombeton/statuses/{sha}","languages_url":"https://api.github.com/repos/fidals/stroyprombeton/languages","stargazers_url":"https://api.github.com/repos/fidals/stroyprombeton/stargazers","contributors_url":"https://api.github.com/repos/fidals/stroyprombeton/contributors","subscribers_url":"https://api.github.com/repos/fidals/stroyprombeton/subscribers","subscription_url":"https://api.github.com/repos/fidals/stroyprombeton/subscription","commits_url":"https://api.github.com/repos/fidals/stroyprombeton/commits{/sha}","git_commits_url":"https://api.github.com/repos/fidals/stroyprombeton/git/commits{/sha}","comments_url":"https://api.github.com/repos/fidals/stroyprombeton/comments{/number}","issue_comment_url":"https://api.github.com/repos/fidals/stroyprombeton/issues/comments{/number}","contents_url":"https://api.github.com/repos/fidals/stroyprombeton/contents/{+path}","compare_url":"https://api.github.com/repos/fidals/stroyprombeton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fidals/stroyprombeton/merges","archive_url":"https://api.github.com/repos/fidals/stroyprombeton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fidals/stroyprombeton/downloads","issues_url":"https://api.github.com/repos/fidals/stroyprombeton/issues{/number}","pulls_url":"https://api.github.com/repos/fidals/stroyprombeton/pulls{/number}","milestones_url":"https://api.github.com/repos/fidals/stroyprombeton/milestones{/number}","notifications_url":"https://api.github.com/repos/fidals/stroyprombeton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fidals/stroyprombeton/labels{/name}","releases_url":"https://api.github.com/repos/fidals/stroyprombeton/releases{/id}","deployments_url":"https://api.github.com/repos/fidals/stroyprombeton/deployments","created_at":"2016-07-04T08:24:41Z","updated_at":"2016-07-07T09:32:27Z","pushed_at":"2017-03-10T16:45:14Z","git_url":"git://github.com/fidals/stroyprombeton.git","ssh_url":"[email protected]:fidals/stroyprombeton.git","clone_url":"https://github.com/fidals/stroyprombeton.git","svn_url":"https://github.com/fidals/stroyprombeton","homepage":null,"size":6934,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"fidals:master","ref":"master","sha":"e78e59775c62ef58c23a8e0b198c26acf1ac4776","user":{"login":"fidals","id":16228604,"avatar_url":"https://avatars3.githubusercontent.com/u/16228604?v=3","gravatar_id":"","url":"https://api.github.com/users/fidals","html_url":"https://github.com/fidals","followers_url":"https://api.github.com/users/fidals/followers","following_url":"https://api.github.com/users/fidals/following{/other_user}","gists_url":"https://api.github.com/users/fidals/gists{/gist_id}","starred_url":"https://api.github.com/users/fidals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fidals/subscriptions","organizations_url":"https://api.github.com/users/fidals/orgs","repos_url":"https://api.github.com/users/fidals/repos","events_url":"https://api.github.com/users/fidals/events{/privacy}","received_events_url":"https://api.github.com/users/fidals/received_events","type":"Organization","site_admin":false},"repo":{"id":62544799,"name":"stroyprombeton","full_name":"fidals/stroyprombeton","owner":{"login":"fidals","id":16228604,"avatar_url":"https://avatars3.githubusercontent.com/u/16228604?v=3","gravatar_id":"","url":"https://api.github.com/users/fidals","html_url":"https://github.com/fidals","followers_url":"https://api.github.com/users/fidals/followers","following_url":"https://api.github.com/users/fidals/following{/other_user}","gists_url":"https://api.github.com/users/fidals/gists{/gist_id}","starred_url":"https://api.github.com/users/fidals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fidals/subscriptions","organizations_url":"https://api.github.com/users/fidals/orgs","repos_url":"https://api.github.com/users/fidals/repos","events_url":"https://api.github.com/users/fidals/events{/privacy}","received_events_url":"https://api.github.com/users/fidals/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fidals/stroyprombeton","description":null,"fork":false,"url":"https://api.github.com/repos/fidals/stroyprombeton","forks_url":"https://api.github.com/repos/fidals/stroyprombeton/forks","keys_url":"https://api.github.com/repos/fidals/stroyprombeton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fidals/stroyprombeton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fidals/stroyprombeton/teams","hooks_url":"https://api.github.com/repos/fidals/stroyprombeton/hooks","issue_events_url":"https://api.github.com/repos/fidals/stroyprombeton/issues/events{/number}","events_url":"https://api.github.com/repos/fidals/stroyprombeton/events","assignees_url":"https://api.github.com/repos/fidals/stroyprombeton/assignees{/user}","branches_url":"https://api.github.com/repos/fidals/stroyprombeton/branches{/branch}","tags_url":"https://api.github.com/repos/fidals/stroyprombeton/tags","blobs_url":"https://api.github.com/repos/fidals/stroyprombeton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fidals/stroyprombeton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fidals/stroyprombeton/git/refs{/sha}","trees_url":"https://api.github.com/repos/fidals/stroyprombeton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fidals/stroyprombeton/statuses/{sha}","languages_url":"https://api.github.com/repos/fidals/stroyprombeton/languages","stargazers_url":"https://api.github.com/repos/fidals/stroyprombeton/stargazers","contributors_url":"https://api.github.com/repos/fidals/stroyprombeton/contributors","subscribers_url":"https://api.github.com/repos/fidals/stroyprombeton/subscribers","subscription_url":"https://api.github.com/repos/fidals/stroyprombeton/subscription","commits_url":"https://api.github.com/repos/fidals/stroyprombeton/commits{/sha}","git_commits_url":"https://api.github.com/repos/fidals/stroyprombeton/git/commits{/sha}","comments_url":"https://api.github.com/repos/fidals/stroyprombeton/comments{/number}","issue_comment_url":"https://api.github.com/repos/fidals/stroyprombeton/issues/comments{/number}","contents_url":"https://api.github.com/repos/fidals/stroyprombeton/contents/{+path}","compare_url":"https://api.github.com/repos/fidals/stroyprombeton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fidals/stroyprombeton/merges","archive_url":"https://api.github.com/repos/fidals/stroyprombeton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fidals/stroyprombeton/downloads","issues_url":"https://api.github.com/repos/fidals/stroyprombeton/issues{/number}","pulls_url":"https://api.github.com/repos/fidals/stroyprombeton/pulls{/number}","milestones_url":"https://api.github.com/repos/fidals/stroyprombeton/milestones{/number}","notifications_url":"https://api.github.com/repos/fidals/stroyprombeton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fidals/stroyprombeton/labels{/name}","releases_url":"https://api.github.com/repos/fidals/stroyprombeton/releases{/id}","deployments_url":"https://api.github.com/repos/fidals/stroyprombeton/deployments","created_at":"2016-07-04T08:24:41Z","updated_at":"2016-07-07T09:32:27Z","pushed_at":"2017-03-10T16:45:14Z","git_url":"git://github.com/fidals/stroyprombeton.git","ssh_url":"[email protected]:fidals/stroyprombeton.git","clone_url":"https://github.com/fidals/stroyprombeton.git","svn_url":"https://github.com/fidals/stroyprombeton","homepage":null,"size":6934,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fidals/stroyprombeton/pulls/68"},"html":{"href":"https://github.com/fidals/stroyprombeton/pull/68"},"issue":{"href":"https://api.github.com/repos/fidals/stroyprombeton/issues/68"},"comments":{"href":"https://api.github.com/repos/fidals/stroyprombeton/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/fidals/stroyprombeton/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/fidals/stroyprombeton/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fidals/stroyprombeton/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/fidals/stroyprombeton/statuses/fb4982a1d60ce6f28dfba9ba385857eda4ffb288"}}}} | {
"id": 62544799,
"name": "fidals/stroyprombeton",
"url": "https://api.github.com/repos/fidals/stroyprombeton"
} | {
"id": 3526796,
"login": "duker33",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3526796?",
"url": "https://api.github.com/users/duker33"
} | {
"id": 16228604,
"login": "fidals",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16228604?",
"url": "https://api.github.com/orgs/fidals"
} | 2017-03-11T12:31:38 | 5475565354 | {"actor":{"display_login":"duker33"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/frappe/erpnext/pulls/comments/156013163","pull_request_review_id":82420698,"id":156013163,"diff_hunk":"@@ -479,3 +479,4 @@ erpnext.patches.v9_2.rename_net_weight_in_item_master\n erpnext.patches.v9_2.delete_process_payroll\n erpnext.patches.v10_0.add_agriculture_domain\n erpnext.patches.v10_0.add_non_profit_domain\n+erpnext.patches.v10_0item_barcode_childtable_migrate","path":"erpnext/patches.txt","position":4,"original_position":4,"commit_id":"dd37ceb70758e07e2591273a9c933e20ef4b4cc3","original_commit_id":"dd37ceb70758e07e2591273a9c933e20ef4b4cc3","user":{"login":"tundebabzy","id":818803,"avatar_url":"https://avatars2.githubusercontent.com/u/818803?v=4","gravatar_id":"","url":"https://api.github.com/users/tundebabzy","html_url":"https://github.com/tundebabzy","followers_url":"https://api.github.com/users/tundebabzy/followers","following_url":"https://api.github.com/users/tundebabzy/following{/other_user}","gists_url":"https://api.github.com/users/tundebabzy/gists{/gist_id}","starred_url":"https://api.github.com/users/tundebabzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tundebabzy/subscriptions","organizations_url":"https://api.github.com/users/tundebabzy/orgs","repos_url":"https://api.github.com/users/tundebabzy/repos","events_url":"https://api.github.com/users/tundebabzy/events{/privacy}","received_events_url":"https://api.github.com/users/tundebabzy/received_events","type":"User","site_admin":false},"body":"> erpnext.patches.v10_0item_barcode_childtable_migrate\r\n\r\nYou forgot the '.'","created_at":"2017-12-11T09:01:59Z","updated_at":"2017-12-11T09:02:03Z","html_url":"https://github.com/frappe/erpnext/pull/11917#discussion_r156013163","pull_request_url":"https://api.github.com/repos/frappe/erpnext/pulls/11917","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/comments/156013163"},"html":{"href":"https://github.com/frappe/erpnext/pull/11917#discussion_r156013163"},"pull_request":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/11917"}}},"pull_request":{"url":"https://api.github.com/repos/frappe/erpnext/pulls/11917","id":157443703,"html_url":"https://github.com/frappe/erpnext/pull/11917","diff_url":"https://github.com/frappe/erpnext/pull/11917.diff","patch_url":"https://github.com/frappe/erpnext/pull/11917.patch","issue_url":"https://api.github.com/repos/frappe/erpnext/issues/11917","number":11917,"state":"open","locked":false,"title":"[Enhancement] Multiple barcode per Item","user":{"login":"joezsweet","id":11652845,"avatar_url":"https://avatars3.githubusercontent.com/u/11652845?v=4","gravatar_id":"","url":"https://api.github.com/users/joezsweet","html_url":"https://github.com/joezsweet","followers_url":"https://api.github.com/users/joezsweet/followers","following_url":"https://api.github.com/users/joezsweet/following{/other_user}","gists_url":"https://api.github.com/users/joezsweet/gists{/gist_id}","starred_url":"https://api.github.com/users/joezsweet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joezsweet/subscriptions","organizations_url":"https://api.github.com/users/joezsweet/orgs","repos_url":"https://api.github.com/users/joezsweet/repos","events_url":"https://api.github.com/users/joezsweet/events{/privacy}","received_events_url":"https://api.github.com/users/joezsweet/received_events","type":"User","site_admin":false},"body":"- ability to add multiple barcode for an Item. \r\n- ability to validate UPC-A and EAN if barcode type is selected.\r\n\r\nSome GIFs:\r\n\r\nUPC-A Validation:\r\n\r\n\r\nFind duplicates:\r\n\r\n\r\nSearch on POS:\r\n\r\n\r\nSearch on Stock Entry:\r\n\r\n","created_at":"2017-12-10T18:38:27Z","updated_at":"2017-12-11T09:02:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53dd78464f14626f0fa2207e062ee1b67f1c77ce","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/frappe/erpnext/pulls/11917/commits","review_comments_url":"https://api.github.com/repos/frappe/erpnext/pulls/11917/comments","review_comment_url":"https://api.github.com/repos/frappe/erpnext/pulls/comments{/number}","comments_url":"https://api.github.com/repos/frappe/erpnext/issues/11917/comments","statuses_url":"https://api.github.com/repos/frappe/erpnext/statuses/dd37ceb70758e07e2591273a9c933e20ef4b4cc3","head":{"label":"joezsweet:multi-barcode","ref":"multi-barcode","sha":"dd37ceb70758e07e2591273a9c933e20ef4b4cc3","user":{"login":"joezsweet","id":11652845,"avatar_url":"https://avatars3.githubusercontent.com/u/11652845?v=4","gravatar_id":"","url":"https://api.github.com/users/joezsweet","html_url":"https://github.com/joezsweet","followers_url":"https://api.github.com/users/joezsweet/followers","following_url":"https://api.github.com/users/joezsweet/following{/other_user}","gists_url":"https://api.github.com/users/joezsweet/gists{/gist_id}","starred_url":"https://api.github.com/users/joezsweet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joezsweet/subscriptions","organizations_url":"https://api.github.com/users/joezsweet/orgs","repos_url":"https://api.github.com/users/joezsweet/repos","events_url":"https://api.github.com/users/joezsweet/events{/privacy}","received_events_url":"https://api.github.com/users/joezsweet/received_events","type":"User","site_admin":false},"repo":{"id":104386761,"name":"erpnext","full_name":"joezsweet/erpnext","owner":{"login":"joezsweet","id":11652845,"avatar_url":"https://avatars3.githubusercontent.com/u/11652845?v=4","gravatar_id":"","url":"https://api.github.com/users/joezsweet","html_url":"https://github.com/joezsweet","followers_url":"https://api.github.com/users/joezsweet/followers","following_url":"https://api.github.com/users/joezsweet/following{/other_user}","gists_url":"https://api.github.com/users/joezsweet/gists{/gist_id}","starred_url":"https://api.github.com/users/joezsweet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joezsweet/subscriptions","organizations_url":"https://api.github.com/users/joezsweet/orgs","repos_url":"https://api.github.com/users/joezsweet/repos","events_url":"https://api.github.com/users/joezsweet/events{/privacy}","received_events_url":"https://api.github.com/users/joezsweet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joezsweet/erpnext","description":"Open Source ERP","fork":true,"url":"https://api.github.com/repos/joezsweet/erpnext","forks_url":"https://api.github.com/repos/joezsweet/erpnext/forks","keys_url":"https://api.github.com/repos/joezsweet/erpnext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joezsweet/erpnext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joezsweet/erpnext/teams","hooks_url":"https://api.github.com/repos/joezsweet/erpnext/hooks","issue_events_url":"https://api.github.com/repos/joezsweet/erpnext/issues/events{/number}","events_url":"https://api.github.com/repos/joezsweet/erpnext/events","assignees_url":"https://api.github.com/repos/joezsweet/erpnext/assignees{/user}","branches_url":"https://api.github.com/repos/joezsweet/erpnext/branches{/branch}","tags_url":"https://api.github.com/repos/joezsweet/erpnext/tags","blobs_url":"https://api.github.com/repos/joezsweet/erpnext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joezsweet/erpnext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joezsweet/erpnext/git/refs{/sha}","trees_url":"https://api.github.com/repos/joezsweet/erpnext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joezsweet/erpnext/statuses/{sha}","languages_url":"https://api.github.com/repos/joezsweet/erpnext/languages","stargazers_url":"https://api.github.com/repos/joezsweet/erpnext/stargazers","contributors_url":"https://api.github.com/repos/joezsweet/erpnext/contributors","subscribers_url":"https://api.github.com/repos/joezsweet/erpnext/subscribers","subscription_url":"https://api.github.com/repos/joezsweet/erpnext/subscription","commits_url":"https://api.github.com/repos/joezsweet/erpnext/commits{/sha}","git_commits_url":"https://api.github.com/repos/joezsweet/erpnext/git/commits{/sha}","comments_url":"https://api.github.com/repos/joezsweet/erpnext/comments{/number}","issue_comment_url":"https://api.github.com/repos/joezsweet/erpnext/issues/comments{/number}","contents_url":"https://api.github.com/repos/joezsweet/erpnext/contents/{+path}","compare_url":"https://api.github.com/repos/joezsweet/erpnext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joezsweet/erpnext/merges","archive_url":"https://api.github.com/repos/joezsweet/erpnext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joezsweet/erpnext/downloads","issues_url":"https://api.github.com/repos/joezsweet/erpnext/issues{/number}","pulls_url":"https://api.github.com/repos/joezsweet/erpnext/pulls{/number}","milestones_url":"https://api.github.com/repos/joezsweet/erpnext/milestones{/number}","notifications_url":"https://api.github.com/repos/joezsweet/erpnext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joezsweet/erpnext/labels{/name}","releases_url":"https://api.github.com/repos/joezsweet/erpnext/releases{/id}","deployments_url":"https://api.github.com/repos/joezsweet/erpnext/deployments","created_at":"2017-09-21T18:55:47Z","updated_at":"2017-09-21T18:56:00Z","pushed_at":"2017-12-11T08:58:31Z","git_url":"git://github.com/joezsweet/erpnext.git","ssh_url":"[email protected]:joezsweet/erpnext.git","clone_url":"https://github.com/joezsweet/erpnext.git","svn_url":"https://github.com/joezsweet/erpnext","homepage":"http://erpnext.com","size":441958,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"frappe:develop","ref":"develop","sha":"d10014bdebc3df0a7000babb981882d6793ccdc2","user":{"login":"frappe","id":836974,"avatar_url":"https://avatars2.githubusercontent.com/u/836974?v=4","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"repo":{"id":1864233,"name":"erpnext","full_name":"frappe/erpnext","owner":{"login":"frappe","id":836974,"avatar_url":"https://avatars2.githubusercontent.com/u/836974?v=4","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/frappe/erpnext","description":"Open Source ERP","fork":false,"url":"https://api.github.com/repos/frappe/erpnext","forks_url":"https://api.github.com/repos/frappe/erpnext/forks","keys_url":"https://api.github.com/repos/frappe/erpnext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frappe/erpnext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frappe/erpnext/teams","hooks_url":"https://api.github.com/repos/frappe/erpnext/hooks","issue_events_url":"https://api.github.com/repos/frappe/erpnext/issues/events{/number}","events_url":"https://api.github.com/repos/frappe/erpnext/events","assignees_url":"https://api.github.com/repos/frappe/erpnext/assignees{/user}","branches_url":"https://api.github.com/repos/frappe/erpnext/branches{/branch}","tags_url":"https://api.github.com/repos/frappe/erpnext/tags","blobs_url":"https://api.github.com/repos/frappe/erpnext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frappe/erpnext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frappe/erpnext/git/refs{/sha}","trees_url":"https://api.github.com/repos/frappe/erpnext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frappe/erpnext/statuses/{sha}","languages_url":"https://api.github.com/repos/frappe/erpnext/languages","stargazers_url":"https://api.github.com/repos/frappe/erpnext/stargazers","contributors_url":"https://api.github.com/repos/frappe/erpnext/contributors","subscribers_url":"https://api.github.com/repos/frappe/erpnext/subscribers","subscription_url":"https://api.github.com/repos/frappe/erpnext/subscription","commits_url":"https://api.github.com/repos/frappe/erpnext/commits{/sha}","git_commits_url":"https://api.github.com/repos/frappe/erpnext/git/commits{/sha}","comments_url":"https://api.github.com/repos/frappe/erpnext/comments{/number}","issue_comment_url":"https://api.github.com/repos/frappe/erpnext/issues/comments{/number}","contents_url":"https://api.github.com/repos/frappe/erpnext/contents/{+path}","compare_url":"https://api.github.com/repos/frappe/erpnext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frappe/erpnext/merges","archive_url":"https://api.github.com/repos/frappe/erpnext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frappe/erpnext/downloads","issues_url":"https://api.github.com/repos/frappe/erpnext/issues{/number}","pulls_url":"https://api.github.com/repos/frappe/erpnext/pulls{/number}","milestones_url":"https://api.github.com/repos/frappe/erpnext/milestones{/number}","notifications_url":"https://api.github.com/repos/frappe/erpnext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frappe/erpnext/labels{/name}","releases_url":"https://api.github.com/repos/frappe/erpnext/releases{/id}","deployments_url":"https://api.github.com/repos/frappe/erpnext/deployments","created_at":"2011-06-08T08:20:56Z","updated_at":"2017-12-10T23:16:23Z","pushed_at":"2017-12-11T08:58:33Z","git_url":"git://github.com/frappe/erpnext.git","ssh_url":"[email protected]:frappe/erpnext.git","clone_url":"https://github.com/frappe/erpnext.git","svn_url":"https://github.com/frappe/erpnext","homepage":"http://erpnext.com","size":442178,"stargazers_count":2631,"watchers_count":2631,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1370,"mirror_url":null,"archived":false,"open_issues_count":1146,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1370,"open_issues":1146,"watchers":2631,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/11917"},"html":{"href":"https://github.com/frappe/erpnext/pull/11917"},"issue":{"href":"https://api.github.com/repos/frappe/erpnext/issues/11917"},"comments":{"href":"https://api.github.com/repos/frappe/erpnext/issues/11917/comments"},"review_comments":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/11917/comments"},"review_comment":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/11917/commits"},"statuses":{"href":"https://api.github.com/repos/frappe/erpnext/statuses/dd37ceb70758e07e2591273a9c933e20ef4b4cc3"}},"author_association":"CONTRIBUTOR"}} | {
"id": 1864233,
"name": "frappe/erpnext",
"url": "https://api.github.com/repos/frappe/erpnext"
} | {
"id": 818803,
"login": "tundebabzy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/818803?",
"url": "https://api.github.com/users/tundebabzy"
} | {
"id": 836974,
"login": "frappe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/836974?",
"url": "https://api.github.com/orgs/frappe"
} | 2017-12-11T09:01:59 | 6970091397 | {"actor":{"display_login":"tundebabzy"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/gallup/NGS2/pulls/comments/136959429","pull_request_review_id":60567015,"id":136959429,"diff_hunk":"@@ -0,0 +1,422 @@\n+# Created by Matt Hoover ([email protected]) for Gallup in September 2017\n+# determine system environment\n+if(Sys.info()['sysname'] == 'Darwin') {\n+ rm(list=ls())\n+\n+ # Install packages that are required for this file\n+ list.of.packages <- c(\"dplyr\", \"pacman\", \"reshape2\")\n+ new.packages <- list.of.packages[!(list.of.packages %in%\n+ installed.packages()[,\"Package\"])]\n+ if(length(new.packages)) install.packages(new.packages)\n+ lapply(list.of.packages, require, character.only = TRUE)\n+\n+ pacman::p_load(multiwayvcov, lmtest)\n+}\n+\n+# Define constants for use in programmatically working through new data\n+CYCLE <- 1 # should be numeric; the cycle number being processed\n+COOP_VAR_ORDER <- c(\n+ 'round',\n+ 'pid',\n+ 'action',\n+ 'group_size',\n+ 'previous_decision',\n+ 'num_neighbors',\n+ 'session',\n+ 'condition',\n+ 'empanel_id'\n+)\n+REWIRE_VAR_ORDER <- c(\n+ 'session',\n+ 'round',\n+ 'playerid',\n+ 'alterid',\n+ 'previouslytie',\n+ 'nowtie',\n+ 'playeraction',\n+ 'alteraction',\n+ 'other_d',\n+ 'action_num',\n+ 'break_tie',\n+ 'make_tie',\n+ 'state',\n+ 'CC',\n+ 'DD',\n+ 'player_empanel_id',\n+ 'alter_empanel_id'\n+)\n+\n+# Define functions\n+add_actions <- function(data, actions, focus = c('player', 'alter')) {\n+ # add respondent actions to `rewire` dataset\n+ res <- mapply(function(x, y) {\n+ if(nrow(x) > 0) {\n+ if(focus == 'player') {\n+ x <- merge(\n+ x,\n+ y[, c('pid', 'round', 'action')],\n+ by = c('round', 'pid')\n+ )\n+ x$action <- ifelse(x$action == 'cooperate', 'C', 'D')\n+ names(x)[grep('^action$', names(x))] <- 'playeraction'\n+ } else {\n+ x <- merge(\n+ x,\n+ y[, c('pid', 'round', 'action')],\n+ by.x = c('round', 'nid'),\n+ by.y = c('round', 'pid')\n+ )\n+ x$action <- ifelse(x$action == 'cooperate', 'C', 'D')\n+ names(x)[grep('^action$', names(x))] <- 'alteraction'\n+ }\n+ return(x)\n+ } else {\n+ return(data.frame())\n+ }\n+ }, data, actions, SIMPLIFY = FALSE)\n+ return(res)\n+}\n+\n+add_ties <- function(rewire, connections, rd_changes) {\n+ # add current and previous ties for actors\n+ res <- mapply(function(x, y, z) {\n+ if(nrow(x) > 0) {\n+ x$previouslytie <- NA\n+ x$nowtie <- NA\n+ for(i in 1:nrow(x)) {\n+ if(x$round[i] == 1) {\n+ id1 <- x[i, 'pid']\n+ id2 <- x[i, 'nid']\n+ conn_id <- which(\n+ (y$playerId1 == id1 & y$playerId2 == id2) |\n+ (y$playerId1 == id2 & y$playerId2 == id1)\n+ )\n+ x$previouslytie[i] <- ifelse(length(conn_id) == 0, 0, 1)\n+ x$nowtie[i] <- ifelse(\n+ (x$previouslytie[i] == 1 & x$break_tie[i] != 1) |\n+ (x$previouslytie[i] == 0 & x$make_tie[i] == 1), 1, 0\n+ )\n+ } else {\n+ rd <- x$round[i] - 1\n+ id1 <- x[i, 'pid']\n+ id2 <- x[i, 'nid']\n+ conn_id <- which(\n+ (z[[rd]]$playerId1 == id1 & z[[rd]]$playerId2 == id2) |\n+ (z[[rd]]$playerId1 == id2 & z[[rd]]$playerId2 == id1)\n+ )\n+ x$previouslytie[i] <- ifelse(length(conn_id) == 0, 0, 1)\n+ x$nowtie[i] <- ifelse(\n+ (x$previouslytie[i] == 1 & x$break_tie[i] != 1) |\n+ (x$previouslytie[i] == 0 & x$make_tie[i] == 1), 1, 0\n+ )\n+ }\n+ }\n+ names(x)[grep('pid', names(x))] <- 'playerid'\n+ names(x)[grep('nid', names(x))] <- 'alterid'\n+\n+ return(x)\n+ } else {\n+ return(data.frame())\n+ }\n+ }, rewire, connections, rd_changes, SIMPLIFY = FALSE)\n+ return(res)\n+}\n+\n+build_cooperation <- function(actions) {\n+ # start `cooperation` that will build on `actions` and `connections`\n+ return(lapply(actions, function(x) {\n+ tmp <- merge(\n+ x,\n+ aggregate(x$pid, by = list(x$round), length),\n+ by.x = 'round',\n+ by.y = 'Group.1'\n+ )\n+ names(tmp)[names(tmp) == 'x'] <- 'group_size'\n+\n+ tmp$previous_decision <- NA\n+ for(i in 1:nrow(tmp)) {\n+ if(tmp[i, 'round'] > 1) {\n+ id <- tmp$pid[i]\n+ rd <- tmp$round[i] - 1\n+ if(length(which(tmp$pid == id & tmp$round == rd)) == 1) {\n+ tmp$previous_decision[i] <- tmp$action[tmp$pid == id &\n+ tmp$round == rd]\n+ }\n+ }\n+ }\n+\n+ tmp[, c('action', 'previous_decision')] <- apply(\n+ tmp[, c('action', 'previous_decision')], 2, function(y) {\n+ ifelse(y == 'cooperate', 1, 0)\n+ }\n+ )\n+\n+ return(tmp[, -grep('^id', names(tmp))])\n+ }))\n+}\n+\n+build_empanelment_bb_xwalk <- function(file) {\n+ # reads in data to determine breadboard/empanelment crosswalk and outputs a\n+ # clean file\n+ bb_ids <- read.table(paste('data', file, sep = '/'), header = TRUE,\n+ sep = '\\t', stringsAsFactors = FALSE)\n+ bb_ids$bbid <- do.call(c, lapply(strsplit(bb_ids$ROUTER_URL, '/'), function(x) {\n+ return(x[length(x)])\n+ }))\n+ names(bb_ids)[grep('^EMPLOYEE', names(bb_ids))] <- 'empanel_id'\n+ return(bb_ids[, c('empanel_id', 'bbid')])\n+}\n+\n+build_rewire <- function(changes) {\n+ # start building the `rewire` output file\n+ res <- lapply(changes, function(x) {\n+ if(nrow(x) > 0) {\n+ tmp <- x[\n+ order(x$round, x$pid, x$nid),\n+ c('round', 'pid', 'nid', 'action_num')\n+ ]\n+\n+ tmp$break_tie <- ifelse(tmp$action_num == -1, 1, 0)\n+ tmp$make_tie <- ifelse(tmp$action_num == 1, 1, 0)\n+ tmp$action_num <- ifelse(tmp$action != 0, 1, tmp$action_num)\n+\n+ return(tmp)\n+ } else {\n+ return(data.frame())\n+ }\n+ })\n+ return(res)\n+}\n+\n+calculate_connections <- function(rounds) {\n+ # count up number of connections by id by round\n+ return(lapply(rounds, function(x) {\n+ if(length(x) > 0) {\n+ tmp <- do.call(rbind, mapply(function(y, rd) {\n+ tmp1 <- aggregate(y$playerId2, by = list(y$playerId1), length)\n+ tmp2 <- aggregate(y$playerId1, by = list(y$playerId2), length)\n+ tmp <- merge(tmp1, tmp2, by = 'Group.1', all = TRUE)\n+ tmp$num_neighbors <- apply(tmp[, grep('^x', names(tmp))], 1, function(z) {\n+ sum(z, na.rm = TRUE)\n+ })\n+ tmp$round <- rd\n+ tmp <- tmp[, c('round', 'Group.1', 'num_neighbors')]\n+ names(tmp)[2] <- 'pid'\n+ return(tmp)\n+ }, x, 1:length(x), SIMPLIFY = FALSE))\n+ return(tmp)\n+ } else {\n+ return(data.frame())\n+ }\n+ }))\n+}\n+\n+changes_by_round <- function(changes, connections) {\n+ # identify changes by id by round\n+ return(mapply(function(x, y) {\n+ round_changes <- list()\n+ if(nrow(x) > 0) {\n+ y$change_event <- 0\n+ for(j in 1:max(x$round)) {\n+ tmp <- subset(x, x$round == j)\n+ tmp <- tmp[order(tmp$id), ]\n+ for(i in 1:nrow(tmp)) {\n+ id1 <- tmp[i, 'nid']\n+ id2 <- tmp[i, 'pid']\n+ conn_id <- which((y$playerId1 == id1 & y$playerId2 == id2) |\n+ (y$playerId1 == id2 & y$playerId2 == id1))\n+ if(length(conn_id) == 0) {\n+ if(tmp[i, 'action'] == 'makeConnection') {\n+ y <- rbind(y,\n+ data.frame(id = tmp[i, 'id'],\n+ playerId1 = id1,\n+ playerId2 = id2,\n+ change_event = 1)\n+ )\n+ }\n+ } else {\n+ y$change_event[conn_id] <- ifelse(\n+ is.na(y$change_event[conn_id]),\n+ tmp[i, 'action_num'],\n+ y$change_event[conn_id] + tmp[i, 'action_num']\n+ )\n+ }\n+ }\n+ y <- y[y$change_event >= 0, ]\n+ y$change_event <- 0\n+ round_changes[[j]] <- y[, c('id', 'playerId1', 'playerId2')]\n+ names(round_changes)[j] <- paste0('r', j)\n+ }\n+ }\n+ return(round_changes)\n+ }, changes, connections, SIMPLIFY = FALSE))\n+}\n+\n+create_subsets <- function(data, action, scrubs, strip_practice=TRUE) {\n+ # create data subsets\n+ return(lapply(data, function(x) {\n+ if(action %in% x$event) {\n+ tmp <- dcast(subset(x, event == action), id ~ data.name,\n+ value.var = 'data.value')\n+ if(strip_practice) {\n+ tmp$round <- as.numeric(tmp$round)\n+ tmp <- subset(tmp, !is.na(round))\n+ }\n+ return(tmp[complete.cases(tmp), ])\n+ } else {\n+ return(data.frame())\n+ }\n+ }))\n+}\n+\n+get_neighbor_number <- function(d, cnx, rd) {\n+ ids <- d$pid[d$round == rd]\n+ tmp <- cnx[cnx$playerId1 %in% ids & cnx$playerId2 %in% ids, ]\n+ tmp_df <- merge(\n+ data.frame(table(tmp$playerId1)),\n+ data.frame(table(tmp$playerId2)),\n+ by = 'Var1',\n+ all = TRUE\n+ )\n+ tmp_df[is.na(tmp_df)] <- 0\n+ for(id in ids) {\n+ d$num_neighbors[d$round == rd & d$pid == id] <- sum(\n+ tmp_df$Freq.x[tmp_df$Var1 == id],\n+ tmp_df$Freq.y[tmp_df$Var1 == id]\n+ )\n+ }\n+ return(d)\n+}\n+\n+merge_with_empanelment <- function(data, empanel, merge_var, rename = FALSE,\n+ rename_var = NULL) {\n+ tmp <- merge(data, empanel, by.x = merge_var, by.y = 'bbid', all.x = TRUE)\n+ if(rename) {\n+ names(tmp)[which(names(tmp) %in% 'empanel_id')] <- rename_var\n+ }\n+ return(tmp)\n+}\n+\n+read_input_files <- function(dir) {\n+ # identifies all csv files in a directory, reads then into r, and appends them\n+ res <- list()\n+ files <- list.files(dir, pattern = '.csv$')\n+ sources <- strsplit(files, split = '_')\n+ for(i in 1:length(files)) {\n+ tmp <- read.csv(paste(dir, files[i], sep = '/'), header = TRUE,\n+ sep = ',', stringsAsFactors = FALSE)\n+ tmp$source <- paste(sources[[i]][1:2], collapse = '_')\n+ res[[i]] <- tmp\n+ names(res)[i] <- paste(sources[[i]][1:2], collapse = '_')\n+ }\n+ return(res)\n+}\n+\n+# Load raw breadboard data\n+exp1 <- read_input_files(paste0('NGS2-Cycle', CYCLE, '-Experiment1/data'))\n+\n+# gather empanelment/breadboard crosswalk information\n+empanel_bb_xwalk <- build_empanelment_bb_xwalk('oms_url_upload_20170821_1145.txt')\n+\n+# EXPERIMENT 1\n+# cooperation dataset\n+# create subsets for manipulation\n+conn <- create_subsets(exp1, 'Connected', 'player', strip_practice = FALSE)\n+act <- create_subsets(exp1, 'cooperationEvent', 'pid|round',\n+ strip_practice = TRUE)\n+chng <- create_subsets(exp1, 'rewiringEvent', 'pid|nid|round',\n+ strip_practice = TRUE)\n+chng <- lapply(chng, function(x) {\n+ if(nrow(x) > 0) {\n+ x$action_num <- ifelse(x$action == 'maintainConnection', 0,\n+ ifelse(x$action == 'breakConnection', -1, 1))\n+ }\n+ return(x)\n+})\n+\n+# start building the `cooperation` output file\n+coop <- build_cooperation(act)\n+\n+# calculate actor moves by round\n+round_changes <- changes_by_round(chng, conn)\n+nbr_connections_round <- calculate_connections(round_changes)\n+\n+# finish off the `cooperation` dataset\n+coop <- mapply(function(x, y, exp) {\n+ if(nrow(y) > 0) {\n+ return(merge(x, y, by = c('round', 'pid')))\n+ } else {\n+ conns <- dcast(subset(exp, event == 'Connected'), id ~ data.name,\n+ value.var = 'data.value')\n+ x$num_neighbors <- NA\n+ for(i in 1:max(x$round)) {\n+ x <- get_neighbor_number(x, conns, i)\n+ }\n+ return(x[, c('round', 'pid', 'action', 'group_size',\n+ 'previous_decision', 'num_neighbors')])\n+ }\n+}, coop, nbr_connections_round, exp1, SIMPLIFY = FALSE)\n+\n+# add in parameters from dataset for completeness\n+coop <- do.call(rbind, mapply(function(x, name, exp) {\n+ exp_cond <- as.numeric(exp$data.value[exp$event == 'initParameters' &\n+ exp$data.name == 'k'])\n+ x$session <- name\n+ x$condition <- ifelse(exp_cond == 0, 'Static',\n+ ifelse(exp_cond == .1, 'Viscous',\n+ ifelse(exp_cond == .3, 'Fluid',\n+ ifelse(exp_cond == 1, 'Random', 'Other'))))\n+ return(x)\n+}, coop, as.list(names(coop)), exp1, SIMPLIFY = FALSE))\n+\n+# add in empanelment id for non-bots\n+coop <- merge_with_empanelment(coop, empanel_bb_xwalk, 'pid')\n+\n+# output dataset to disk\n+write.csv(coop[order(coop$session, coop$round, coop$pid), COOP_VAR_ORDER],\n+ file = 'NGS2-Cycle1-Experiment1/cooperation_exp1.csv',\n+ row.names = FALSE, na='')\n+\n+# rewire dataset\n+# start building `rewire` output file\n+rewire <- build_rewire(chng)\n+\n+# add respondent actions to `rewire` dataset\n+rewire <- add_actions(rewire, act, focus = 'player')\n+rewire <- add_actions(rewire, act, focus = 'alter')\n+\n+rewire <- lapply(rewire, function(x) {\n+ if(nrow(x) > 0) {\n+ x$state <- apply(x[, grep('action$', names(x))], 1, function(y) {\n+ paste0(y, collapse = '')\n+ })\n+ x$CC <- ifelse(x$state == 'CC', 1, 0)\n+ x$DD <- ifelse(x$state == 'DD', 1, 0)\n+ x$other_d <- ifelse(x$alteraction == 'D', 1, 0)\n+ return(x)\n+ } else {\n+ return(data.frame())\n+ }\n+})\n+\n+# add in previous and current ties\n+rewire <- add_ties(rewire, conn, round_changes)\n+\n+# add oin parameters from dataset for completeness\n+rewire <- do.call(rbind, mapply(function(x, name) {\n+ if(nrow(x) > 0) {\n+ x$session <- name\n+ }\n+ return(x)\n+}, rewire, as.list(names(rewire)), SIMPLIFY = FALSE))\n+\n+# add in empanelment id for non-bots\n+rewire <- merge_with_empanelment(rewire, empanel_bb_xwalk, 'playerid',\n+ rename = TRUE, rename_var = 'player_empanel_id')\n+rewire <- merge_with_empanelment(rewire, empanel_bb_xwalk, 'alterid',\n+ rename = TRUE, rename_var = 'alter_empanel_id')\n+","path":"NGS2_WITNESS_Cycle1_experiment1_prep.R","position":418,"original_position":418,"commit_id":"0c8314917fb6ba11c4e66d8d4b5ac8c2366b7f15","original_commit_id":"0c8314917fb6ba11c4e66d8d4b5ac8c2366b7f15","user":{"login":"mhoover","id":9765304,"avatar_url":"https://avatars0.githubusercontent.com/u/9765304?v=4","gravatar_id":"","url":"https://api.github.com/users/mhoover","html_url":"https://github.com/mhoover","followers_url":"https://api.github.com/users/mhoover/followers","following_url":"https://api.github.com/users/mhoover/following{/other_user}","gists_url":"https://api.github.com/users/mhoover/gists{/gist_id}","starred_url":"https://api.github.com/users/mhoover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhoover/subscriptions","organizations_url":"https://api.github.com/users/mhoover/orgs","repos_url":"https://api.github.com/users/mhoover/repos","events_url":"https://api.github.com/users/mhoover/events{/privacy}","received_events_url":"https://api.github.com/users/mhoover/received_events","type":"User","site_admin":false},"body":"See comment above -- I'm okay with this, as long as we make it condition-based.","created_at":"2017-09-05T11:22:22Z","updated_at":"2017-09-05T11:22:22Z","html_url":"https://github.com/gallup/NGS2/pull/10#discussion_r136959429","pull_request_url":"https://api.github.com/repos/gallup/NGS2/pulls/10","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/gallup/NGS2/pulls/comments/136959429"},"html":{"href":"https://github.com/gallup/NGS2/pull/10#discussion_r136959429"},"pull_request":{"href":"https://api.github.com/repos/gallup/NGS2/pulls/10"}},"in_reply_to_id":136892079},"pull_request":{"url":"https://api.github.com/repos/gallup/NGS2/pulls/10","id":139015274,"html_url":"https://github.com/gallup/NGS2/pull/10","diff_url":"https://github.com/gallup/NGS2/pull/10.diff","patch_url":"https://github.com/gallup/NGS2/pull/10.patch","issue_url":"https://api.github.com/repos/gallup/NGS2/issues/10","number":10,"state":"open","locked":false,"title":"Cycle1 experiment refactor","user":{"login":"mhoover","id":9765304,"avatar_url":"https://avatars0.githubusercontent.com/u/9765304?v=4","gravatar_id":"","url":"https://api.github.com/users/mhoover","html_url":"https://github.com/mhoover","followers_url":"https://api.github.com/users/mhoover/followers","following_url":"https://api.github.com/users/mhoover/following{/other_user}","gists_url":"https://api.github.com/users/mhoover/gists{/gist_id}","starred_url":"https://api.github.com/users/mhoover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhoover/subscriptions","organizations_url":"https://api.github.com/users/mhoover/orgs","repos_url":"https://api.github.com/users/mhoover/repos","events_url":"https://api.github.com/users/mhoover/events{/privacy}","received_events_url":"https://api.github.com/users/mhoover/received_events","type":"User","site_admin":false},"body":"This PR refactors the `NGS2_WITNESS_Cycle1_experiment_prep.R` script in a number of ways:\r\n1. The script was refactored top-to-bottom to be able to process multiple experiment sessions. This involved refactoring code to automatically identify any raw input files in directories and process them (meaning people need to be careful what files are going into the input directories). \r\n2. It adds code and error-handling for experiment 1 when the network is static. Because ties don't change under a static configuration, there are no `rewiringEvents` which means part of the processing otherwise would break without some programming around it.\r\n3. The script became too big and was serving too many purposes, so it was broken out to two scripts, one for experiment 1 (`NGS2_WITNESS_Cycle1_experiment1_prep.R`) and another for experiment 2 (`NGS2_WITNESS_Cycle1_experiment2_prep.R`). \r\n\r\n**This PR will have merge conflicts with #9 and so we should coordinate on merging before moving ahead.**","created_at":"2017-09-02T15:05:44Z","updated_at":"2017-09-05T11:22:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c76c2bc46132c028a704afa9fdffae0124c365d3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/gallup/NGS2/pulls/10/commits","review_comments_url":"https://api.github.com/repos/gallup/NGS2/pulls/10/comments","review_comment_url":"https://api.github.com/repos/gallup/NGS2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gallup/NGS2/issues/10/comments","statuses_url":"https://api.github.com/repos/gallup/NGS2/statuses/0c8314917fb6ba11c4e66d8d4b5ac8c2366b7f15","head":{"label":"gallup:cycle1-refactor","ref":"cycle1-refactor","sha":"0c8314917fb6ba11c4e66d8d4b5ac8c2366b7f15","user":{"login":"gallup","id":28031146,"avatar_url":"https://avatars3.githubusercontent.com/u/28031146?v=4","gravatar_id":"","url":"https://api.github.com/users/gallup","html_url":"https://github.com/gallup","followers_url":"https://api.github.com/users/gallup/followers","following_url":"https://api.github.com/users/gallup/following{/other_user}","gists_url":"https://api.github.com/users/gallup/gists{/gist_id}","starred_url":"https://api.github.com/users/gallup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gallup/subscriptions","organizations_url":"https://api.github.com/users/gallup/orgs","repos_url":"https://api.github.com/users/gallup/repos","events_url":"https://api.github.com/users/gallup/events{/privacy}","received_events_url":"https://api.github.com/users/gallup/received_events","type":"Organization","site_admin":false},"repo":{"id":89427052,"name":"NGS2","full_name":"gallup/NGS2","owner":{"login":"gallup","id":28031146,"avatar_url":"https://avatars3.githubusercontent.com/u/28031146?v=4","gravatar_id":"","url":"https://api.github.com/users/gallup","html_url":"https://github.com/gallup","followers_url":"https://api.github.com/users/gallup/followers","following_url":"https://api.github.com/users/gallup/following{/other_user}","gists_url":"https://api.github.com/users/gallup/gists{/gist_id}","starred_url":"https://api.github.com/users/gallup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gallup/subscriptions","organizations_url":"https://api.github.com/users/gallup/orgs","repos_url":"https://api.github.com/users/gallup/repos","events_url":"https://api.github.com/users/gallup/events{/privacy}","received_events_url":"https://api.github.com/users/gallup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gallup/NGS2","description":"This Repository maintains code and scripts that are related to DARPA NGS2 project","fork":false,"url":"https://api.github.com/repos/gallup/NGS2","forks_url":"https://api.github.com/repos/gallup/NGS2/forks","keys_url":"https://api.github.com/repos/gallup/NGS2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gallup/NGS2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gallup/NGS2/teams","hooks_url":"https://api.github.com/repos/gallup/NGS2/hooks","issue_events_url":"https://api.github.com/repos/gallup/NGS2/issues/events{/number}","events_url":"https://api.github.com/repos/gallup/NGS2/events","assignees_url":"https://api.github.com/repos/gallup/NGS2/assignees{/user}","branches_url":"https://api.github.com/repos/gallup/NGS2/branches{/branch}","tags_url":"https://api.github.com/repos/gallup/NGS2/tags","blobs_url":"https://api.github.com/repos/gallup/NGS2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gallup/NGS2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gallup/NGS2/git/refs{/sha}","trees_url":"https://api.github.com/repos/gallup/NGS2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gallup/NGS2/statuses/{sha}","languages_url":"https://api.github.com/repos/gallup/NGS2/languages","stargazers_url":"https://api.github.com/repos/gallup/NGS2/stargazers","contributors_url":"https://api.github.com/repos/gallup/NGS2/contributors","subscribers_url":"https://api.github.com/repos/gallup/NGS2/subscribers","subscription_url":"https://api.github.com/repos/gallup/NGS2/subscription","commits_url":"https://api.github.com/repos/gallup/NGS2/commits{/sha}","git_commits_url":"https://api.github.com/repos/gallup/NGS2/git/commits{/sha}","comments_url":"https://api.github.com/repos/gallup/NGS2/comments{/number}","issue_comment_url":"https://api.github.com/repos/gallup/NGS2/issues/comments{/number}","contents_url":"https://api.github.com/repos/gallup/NGS2/contents/{+path}","compare_url":"https://api.github.com/repos/gallup/NGS2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gallup/NGS2/merges","archive_url":"https://api.github.com/repos/gallup/NGS2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gallup/NGS2/downloads","issues_url":"https://api.github.com/repos/gallup/NGS2/issues{/number}","pulls_url":"https://api.github.com/repos/gallup/NGS2/pulls{/number}","milestones_url":"https://api.github.com/repos/gallup/NGS2/milestones{/number}","notifications_url":"https://api.github.com/repos/gallup/NGS2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gallup/NGS2/labels{/name}","releases_url":"https://api.github.com/repos/gallup/NGS2/releases{/id}","deployments_url":"https://api.github.com/repos/gallup/NGS2/deployments","created_at":"2017-04-26T02:10:03Z","updated_at":"2017-08-31T17:15:57Z","pushed_at":"2017-09-05T05:48:29Z","git_url":"git://github.com/gallup/NGS2.git","ssh_url":"[email protected]:gallup/NGS2.git","clone_url":"https://github.com/gallup/NGS2.git","svn_url":"https://github.com/gallup/NGS2","homepage":null,"size":3400,"stargazers_count":2,"watchers_count":2,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"gallup:master","ref":"master","sha":"440efae5249fe504626ab07dddea54354f92956f","user":{"login":"gallup","id":28031146,"avatar_url":"https://avatars3.githubusercontent.com/u/28031146?v=4","gravatar_id":"","url":"https://api.github.com/users/gallup","html_url":"https://github.com/gallup","followers_url":"https://api.github.com/users/gallup/followers","following_url":"https://api.github.com/users/gallup/following{/other_user}","gists_url":"https://api.github.com/users/gallup/gists{/gist_id}","starred_url":"https://api.github.com/users/gallup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gallup/subscriptions","organizations_url":"https://api.github.com/users/gallup/orgs","repos_url":"https://api.github.com/users/gallup/repos","events_url":"https://api.github.com/users/gallup/events{/privacy}","received_events_url":"https://api.github.com/users/gallup/received_events","type":"Organization","site_admin":false},"repo":{"id":89427052,"name":"NGS2","full_name":"gallup/NGS2","owner":{"login":"gallup","id":28031146,"avatar_url":"https://avatars3.githubusercontent.com/u/28031146?v=4","gravatar_id":"","url":"https://api.github.com/users/gallup","html_url":"https://github.com/gallup","followers_url":"https://api.github.com/users/gallup/followers","following_url":"https://api.github.com/users/gallup/following{/other_user}","gists_url":"https://api.github.com/users/gallup/gists{/gist_id}","starred_url":"https://api.github.com/users/gallup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gallup/subscriptions","organizations_url":"https://api.github.com/users/gallup/orgs","repos_url":"https://api.github.com/users/gallup/repos","events_url":"https://api.github.com/users/gallup/events{/privacy}","received_events_url":"https://api.github.com/users/gallup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gallup/NGS2","description":"This Repository maintains code and scripts that are related to DARPA NGS2 project","fork":false,"url":"https://api.github.com/repos/gallup/NGS2","forks_url":"https://api.github.com/repos/gallup/NGS2/forks","keys_url":"https://api.github.com/repos/gallup/NGS2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gallup/NGS2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gallup/NGS2/teams","hooks_url":"https://api.github.com/repos/gallup/NGS2/hooks","issue_events_url":"https://api.github.com/repos/gallup/NGS2/issues/events{/number}","events_url":"https://api.github.com/repos/gallup/NGS2/events","assignees_url":"https://api.github.com/repos/gallup/NGS2/assignees{/user}","branches_url":"https://api.github.com/repos/gallup/NGS2/branches{/branch}","tags_url":"https://api.github.com/repos/gallup/NGS2/tags","blobs_url":"https://api.github.com/repos/gallup/NGS2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gallup/NGS2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gallup/NGS2/git/refs{/sha}","trees_url":"https://api.github.com/repos/gallup/NGS2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gallup/NGS2/statuses/{sha}","languages_url":"https://api.github.com/repos/gallup/NGS2/languages","stargazers_url":"https://api.github.com/repos/gallup/NGS2/stargazers","contributors_url":"https://api.github.com/repos/gallup/NGS2/contributors","subscribers_url":"https://api.github.com/repos/gallup/NGS2/subscribers","subscription_url":"https://api.github.com/repos/gallup/NGS2/subscription","commits_url":"https://api.github.com/repos/gallup/NGS2/commits{/sha}","git_commits_url":"https://api.github.com/repos/gallup/NGS2/git/commits{/sha}","comments_url":"https://api.github.com/repos/gallup/NGS2/comments{/number}","issue_comment_url":"https://api.github.com/repos/gallup/NGS2/issues/comments{/number}","contents_url":"https://api.github.com/repos/gallup/NGS2/contents/{+path}","compare_url":"https://api.github.com/repos/gallup/NGS2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gallup/NGS2/merges","archive_url":"https://api.github.com/repos/gallup/NGS2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gallup/NGS2/downloads","issues_url":"https://api.github.com/repos/gallup/NGS2/issues{/number}","pulls_url":"https://api.github.com/repos/gallup/NGS2/pulls{/number}","milestones_url":"https://api.github.com/repos/gallup/NGS2/milestones{/number}","notifications_url":"https://api.github.com/repos/gallup/NGS2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gallup/NGS2/labels{/name}","releases_url":"https://api.github.com/repos/gallup/NGS2/releases{/id}","deployments_url":"https://api.github.com/repos/gallup/NGS2/deployments","created_at":"2017-04-26T02:10:03Z","updated_at":"2017-08-31T17:15:57Z","pushed_at":"2017-09-05T05:48:29Z","git_url":"git://github.com/gallup/NGS2.git","ssh_url":"[email protected]:gallup/NGS2.git","clone_url":"https://github.com/gallup/NGS2.git","svn_url":"https://github.com/gallup/NGS2","homepage":null,"size":3400,"stargazers_count":2,"watchers_count":2,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gallup/NGS2/pulls/10"},"html":{"href":"https://github.com/gallup/NGS2/pull/10"},"issue":{"href":"https://api.github.com/repos/gallup/NGS2/issues/10"},"comments":{"href":"https://api.github.com/repos/gallup/NGS2/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/gallup/NGS2/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/gallup/NGS2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gallup/NGS2/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/gallup/NGS2/statuses/0c8314917fb6ba11c4e66d8d4b5ac8c2366b7f15"}},"author_association":"COLLABORATOR"}} | {
"id": 89427052,
"name": "gallup/NGS2",
"url": "https://api.github.com/repos/gallup/NGS2"
} | {
"id": 9765304,
"login": "mhoover",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9765304?",
"url": "https://api.github.com/users/mhoover"
} | {
"id": 28031146,
"login": "gallup",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28031146?",
"url": "https://api.github.com/orgs/gallup"
} | 2017-09-05T11:22:22 | 6550506089 | {"actor":{"display_login":"mhoover"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/google/haskell-indexer/pulls/comments/128503014","pull_request_review_id":51187990,"id":128503014,"diff_hunk":"@@ -33,6 +33,7 @@ import qualified Bag as GHC\n import qualified BasicTypes as GHC\n import qualified DataCon as GHC\n import qualified Name as GHC\n+import BooleanFormula","path":"haskell-indexer-backend-ghc/src/Language/Haskell/Indexer/Backend/Ghc.hs","position":4,"original_position":4,"commit_id":"5b130bade5371baf926cbe2270544c0775d20f8b","original_commit_id":"5b130bade5371baf926cbe2270544c0775d20f8b","user":{"login":"robinp","id":418830,"avatar_url":"https://avatars2.githubusercontent.com/u/418830?v=4","gravatar_id":"","url":"https://api.github.com/users/robinp","html_url":"https://github.com/robinp","followers_url":"https://api.github.com/users/robinp/followers","following_url":"https://api.github.com/users/robinp/following{/other_user}","gists_url":"https://api.github.com/users/robinp/gists{/gist_id}","starred_url":"https://api.github.com/users/robinp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinp/subscriptions","organizations_url":"https://api.github.com/users/robinp/orgs","repos_url":"https://api.github.com/users/robinp/repos","events_url":"https://api.github.com/users/robinp/events{/privacy}","received_events_url":"https://api.github.com/users/robinp/received_events","type":"User","site_admin":false},"body":"See outer comment about GHC 7.10 failing.","created_at":"2017-07-20T12:41:12Z","updated_at":"2017-07-20T12:52:33Z","html_url":"https://github.com/google/haskell-indexer/pull/50#discussion_r128503014","pull_request_url":"https://api.github.com/repos/google/haskell-indexer/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/google/haskell-indexer/pulls/comments/128503014"},"html":{"href":"https://github.com/google/haskell-indexer/pull/50#discussion_r128503014"},"pull_request":{"href":"https://api.github.com/repos/google/haskell-indexer/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/google/haskell-indexer/pulls/50","id":131343299,"html_url":"https://github.com/google/haskell-indexer/pull/50","diff_url":"https://github.com/google/haskell-indexer/pull/50.diff","patch_url":"https://github.com/google/haskell-indexer/pull/50.patch","issue_url":"https://api.github.com/repos/google/haskell-indexer/issues/50","number":50,"state":"open","locked":false,"title":"Add references for pragmas","user":{"login":"mpickering","id":1216657,"avatar_url":"https://avatars3.githubusercontent.com/u/1216657?v=4","gravatar_id":"","url":"https://api.github.com/users/mpickering","html_url":"https://github.com/mpickering","followers_url":"https://api.github.com/users/mpickering/followers","following_url":"https://api.github.com/users/mpickering/following{/other_user}","gists_url":"https://api.github.com/users/mpickering/gists{/gist_id}","starred_url":"https://api.github.com/users/mpickering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpickering/subscriptions","organizations_url":"https://api.github.com/users/mpickering/orgs","repos_url":"https://api.github.com/users/mpickering/repos","events_url":"https://api.github.com/users/mpickering/events{/privacy}","received_events_url":"https://api.github.com/users/mpickering/received_events","type":"User","site_admin":false},"body":"This patch adds reference for things like `INLINE` pragmas.\r\n\r\nI tested it by running the indexer on `lens` and observing that the `INLINE` pragmas are now linked as expected. ","created_at":"2017-07-19T14:57:16Z","updated_at":"2017-07-20T12:52:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f11c0bf3f9344c6862a9896e6eb439b72a18886","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/haskell-indexer/pulls/50/commits","review_comments_url":"https://api.github.com/repos/google/haskell-indexer/pulls/50/comments","review_comment_url":"https://api.github.com/repos/google/haskell-indexer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/haskell-indexer/issues/50/comments","statuses_url":"https://api.github.com/repos/google/haskell-indexer/statuses/5b130bade5371baf926cbe2270544c0775d20f8b","head":{"label":"mpickering:pragma-reference","ref":"pragma-reference","sha":"5b130bade5371baf926cbe2270544c0775d20f8b","user":{"login":"mpickering","id":1216657,"avatar_url":"https://avatars3.githubusercontent.com/u/1216657?v=4","gravatar_id":"","url":"https://api.github.com/users/mpickering","html_url":"https://github.com/mpickering","followers_url":"https://api.github.com/users/mpickering/followers","following_url":"https://api.github.com/users/mpickering/following{/other_user}","gists_url":"https://api.github.com/users/mpickering/gists{/gist_id}","starred_url":"https://api.github.com/users/mpickering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpickering/subscriptions","organizations_url":"https://api.github.com/users/mpickering/orgs","repos_url":"https://api.github.com/users/mpickering/repos","events_url":"https://api.github.com/users/mpickering/events{/privacy}","received_events_url":"https://api.github.com/users/mpickering/received_events","type":"User","site_admin":false},"repo":{"id":97728740,"name":"haskell-indexer","full_name":"mpickering/haskell-indexer","owner":{"login":"mpickering","id":1216657,"avatar_url":"https://avatars3.githubusercontent.com/u/1216657?v=4","gravatar_id":"","url":"https://api.github.com/users/mpickering","html_url":"https://github.com/mpickering","followers_url":"https://api.github.com/users/mpickering/followers","following_url":"https://api.github.com/users/mpickering/following{/other_user}","gists_url":"https://api.github.com/users/mpickering/gists{/gist_id}","starred_url":"https://api.github.com/users/mpickering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpickering/subscriptions","organizations_url":"https://api.github.com/users/mpickering/orgs","repos_url":"https://api.github.com/users/mpickering/repos","events_url":"https://api.github.com/users/mpickering/events{/privacy}","received_events_url":"https://api.github.com/users/mpickering/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpickering/haskell-indexer","description":"Emits code crossreference data for Haskell sources.","fork":true,"url":"https://api.github.com/repos/mpickering/haskell-indexer","forks_url":"https://api.github.com/repos/mpickering/haskell-indexer/forks","keys_url":"https://api.github.com/repos/mpickering/haskell-indexer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpickering/haskell-indexer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpickering/haskell-indexer/teams","hooks_url":"https://api.github.com/repos/mpickering/haskell-indexer/hooks","issue_events_url":"https://api.github.com/repos/mpickering/haskell-indexer/issues/events{/number}","events_url":"https://api.github.com/repos/mpickering/haskell-indexer/events","assignees_url":"https://api.github.com/repos/mpickering/haskell-indexer/assignees{/user}","branches_url":"https://api.github.com/repos/mpickering/haskell-indexer/branches{/branch}","tags_url":"https://api.github.com/repos/mpickering/haskell-indexer/tags","blobs_url":"https://api.github.com/repos/mpickering/haskell-indexer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpickering/haskell-indexer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpickering/haskell-indexer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpickering/haskell-indexer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpickering/haskell-indexer/statuses/{sha}","languages_url":"https://api.github.com/repos/mpickering/haskell-indexer/languages","stargazers_url":"https://api.github.com/repos/mpickering/haskell-indexer/stargazers","contributors_url":"https://api.github.com/repos/mpickering/haskell-indexer/contributors","subscribers_url":"https://api.github.com/repos/mpickering/haskell-indexer/subscribers","subscription_url":"https://api.github.com/repos/mpickering/haskell-indexer/subscription","commits_url":"https://api.github.com/repos/mpickering/haskell-indexer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpickering/haskell-indexer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpickering/haskell-indexer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpickering/haskell-indexer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpickering/haskell-indexer/contents/{+path}","compare_url":"https://api.github.com/repos/mpickering/haskell-indexer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpickering/haskell-indexer/merges","archive_url":"https://api.github.com/repos/mpickering/haskell-indexer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpickering/haskell-indexer/downloads","issues_url":"https://api.github.com/repos/mpickering/haskell-indexer/issues{/number}","pulls_url":"https://api.github.com/repos/mpickering/haskell-indexer/pulls{/number}","milestones_url":"https://api.github.com/repos/mpickering/haskell-indexer/milestones{/number}","notifications_url":"https://api.github.com/repos/mpickering/haskell-indexer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpickering/haskell-indexer/labels{/name}","releases_url":"https://api.github.com/repos/mpickering/haskell-indexer/releases{/id}","deployments_url":"https://api.github.com/repos/mpickering/haskell-indexer/deployments","created_at":"2017-07-19T14:53:04Z","updated_at":"2017-07-19T14:53:06Z","pushed_at":"2017-07-19T15:04:37Z","git_url":"git://github.com/mpickering/haskell-indexer.git","ssh_url":"[email protected]:mpickering/haskell-indexer.git","clone_url":"https://github.com/mpickering/haskell-indexer.git","svn_url":"https://github.com/mpickering/haskell-indexer","homepage":"","size":170,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"fffff008c47a649d0f33a4e09a4ee2e0196337f6","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":92573821,"name":"haskell-indexer","full_name":"google/haskell-indexer","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/haskell-indexer","description":"Emits code crossreference data for Haskell sources.","fork":false,"url":"https://api.github.com/repos/google/haskell-indexer","forks_url":"https://api.github.com/repos/google/haskell-indexer/forks","keys_url":"https://api.github.com/repos/google/haskell-indexer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/haskell-indexer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/haskell-indexer/teams","hooks_url":"https://api.github.com/repos/google/haskell-indexer/hooks","issue_events_url":"https://api.github.com/repos/google/haskell-indexer/issues/events{/number}","events_url":"https://api.github.com/repos/google/haskell-indexer/events","assignees_url":"https://api.github.com/repos/google/haskell-indexer/assignees{/user}","branches_url":"https://api.github.com/repos/google/haskell-indexer/branches{/branch}","tags_url":"https://api.github.com/repos/google/haskell-indexer/tags","blobs_url":"https://api.github.com/repos/google/haskell-indexer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/haskell-indexer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/haskell-indexer/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/haskell-indexer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/haskell-indexer/statuses/{sha}","languages_url":"https://api.github.com/repos/google/haskell-indexer/languages","stargazers_url":"https://api.github.com/repos/google/haskell-indexer/stargazers","contributors_url":"https://api.github.com/repos/google/haskell-indexer/contributors","subscribers_url":"https://api.github.com/repos/google/haskell-indexer/subscribers","subscription_url":"https://api.github.com/repos/google/haskell-indexer/subscription","commits_url":"https://api.github.com/repos/google/haskell-indexer/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/haskell-indexer/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/haskell-indexer/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/haskell-indexer/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/haskell-indexer/contents/{+path}","compare_url":"https://api.github.com/repos/google/haskell-indexer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/haskell-indexer/merges","archive_url":"https://api.github.com/repos/google/haskell-indexer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/haskell-indexer/downloads","issues_url":"https://api.github.com/repos/google/haskell-indexer/issues{/number}","pulls_url":"https://api.github.com/repos/google/haskell-indexer/pulls{/number}","milestones_url":"https://api.github.com/repos/google/haskell-indexer/milestones{/number}","notifications_url":"https://api.github.com/repos/google/haskell-indexer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/haskell-indexer/labels{/name}","releases_url":"https://api.github.com/repos/google/haskell-indexer/releases{/id}","deployments_url":"https://api.github.com/repos/google/haskell-indexer/deployments","created_at":"2017-05-27T05:39:45Z","updated_at":"2017-07-19T23:01:13Z","pushed_at":"2017-07-19T15:05:32Z","git_url":"git://github.com/google/haskell-indexer.git","ssh_url":"[email protected]:google/haskell-indexer.git","clone_url":"https://github.com/google/haskell-indexer.git","svn_url":"https://github.com/google/haskell-indexer","homepage":"","size":161,"stargazers_count":30,"watchers_count":30,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":30,"forks":11,"open_issues":30,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/haskell-indexer/pulls/50"},"html":{"href":"https://github.com/google/haskell-indexer/pull/50"},"issue":{"href":"https://api.github.com/repos/google/haskell-indexer/issues/50"},"comments":{"href":"https://api.github.com/repos/google/haskell-indexer/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/google/haskell-indexer/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/google/haskell-indexer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/haskell-indexer/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/google/haskell-indexer/statuses/5b130bade5371baf926cbe2270544c0775d20f8b"}}}} | {
"id": 92573821,
"name": "google/haskell-indexer",
"url": "https://api.github.com/repos/google/haskell-indexer"
} | {
"id": 418830,
"login": "robinp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/418830?",
"url": "https://api.github.com/users/robinp"
} | {
"id": 1342004,
"login": "google",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1342004?",
"url": "https://api.github.com/orgs/google"
} | 2017-07-20T12:41:12 | 6294953208 | {"actor":{"display_login":"robinp"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/google/earthenterprise/pulls/comments/122238582","pull_request_review_id":44338149,"id":122238582,"diff_hunk":"@@ -0,0 +1,108 @@\n+--- httpd-2.2.32.orig/docs/conf/extra/httpd-ssl.conf.in\t2015-05-27 11:59:59.000000000 -0700\n++++ httpd-2.2.32/docs/conf/extra/httpd-ssl.conf.in\t2017-06-14 17:33:47.846665091 -0700\n+@@ -56,7 +56,9 @@\n+ # ensure these follow appropriate best practices for this deployment.\n+ # httpd 2.2.30, 2.4.13 and later force-disable aNULL, eNULL and EXP ciphers,\n+ # while OpenSSL disabled these by default in 0.9.8zf/1.0.0r/1.0.1m/1.0.2a.\n+-SSLCipherSuite HIGH:MEDIUM:!MD5:!RC4\n++# Override SSL configuration to require more secure ciphers.\n++#SSLCipherSuite HIGH:MEDIUM:!MD5:!RC4\n++SSLCipherSuite ALL:!aNULL:!ADH:!eNULL:!LOW:!EXP:RC4+RSA:+HIGH:+MEDIUM\n+ SSLProxyCipherSuite HIGH:MEDIUM:!MD5:!RC4\n+ \n+ # By the end of 2016, only TLSv1.2 ciphers should remain in use.\n+@@ -83,7 +85,9 @@\n+ # Disable SSLv2 and SSLv3 by default (cf. RFC 7525 3.1.1). TLSv1 (1.0)\n+ # should be disabled as quickly as practical. By the end of 2016, only\n+ # the TLSv1.2 protocol or later should remain in use.\n+-SSLProtocol all -SSLv2 -SSLv3\n++# Limit SSL protocols.\n++#SSLProtocol all -SSLv2 -SSLv3\n++SSLProtocol -ALL +SSLv3 +TLSv1.2 +TLSv1\n+ SSLProxyProtocol all -SSLv2 -SSLv3\n+ \n+ # Pass Phrase Dialog:\n+@@ -108,18 +112,18 @@\n+ ## SSL Virtual Host Context\n+ ##\n+ \n+-<VirtualHost _default_:@@SSLPort@@>\n++#<VirtualHost _default_:@@SSLPort@@>","path":"earth_enterprise/src/third_party/apache2/apache-gee-httpd-ssl.conf.in.patch","position":30,"original_position":30,"commit_id":"dce1f5b422ba9cff2078ae07e066c07f397ae35b","original_commit_id":"dce1f5b422ba9cff2078ae07e066c07f397ae35b","user":{"login":"asmitaw","id":9653757,"avatar_url":"https://avatars3.githubusercontent.com/u/9653757?v=3","gravatar_id":"","url":"https://api.github.com/users/asmitaw","html_url":"https://github.com/asmitaw","followers_url":"https://api.github.com/users/asmitaw/followers","following_url":"https://api.github.com/users/asmitaw/following{/other_user}","gists_url":"https://api.github.com/users/asmitaw/gists{/gist_id}","starred_url":"https://api.github.com/users/asmitaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmitaw/subscriptions","organizations_url":"https://api.github.com/users/asmitaw/orgs","repos_url":"https://api.github.com/users/asmitaw/repos","events_url":"https://api.github.com/users/asmitaw/events{/privacy}","received_events_url":"https://api.github.com/users/asmitaw/received_events","type":"User","site_admin":false},"body":"Yes, I tested them with default file (httpd-ssl) adding SSLProtocol and cipher only and it does not work as is, for most part, I had to comment each setting one by one as they were SSL and virtual server thing.","created_at":"2017-06-15T15:46:40Z","updated_at":"2017-06-15T15:46:40Z","html_url":"https://github.com/google/earthenterprise/pull/242#discussion_r122238582","pull_request_url":"https://api.github.com/repos/google/earthenterprise/pulls/242","_links":{"self":{"href":"https://api.github.com/repos/google/earthenterprise/pulls/comments/122238582"},"html":{"href":"https://github.com/google/earthenterprise/pull/242#discussion_r122238582"},"pull_request":{"href":"https://api.github.com/repos/google/earthenterprise/pulls/242"}}},"pull_request":{"url":"https://api.github.com/repos/google/earthenterprise/pulls/242","id":125764558,"html_url":"https://github.com/google/earthenterprise/pull/242","diff_url":"https://github.com/google/earthenterprise/pull/242.diff","patch_url":"https://github.com/google/earthenterprise/pull/242.patch","issue_url":"https://api.github.com/repos/google/earthenterprise/issues/242","number":242,"state":"open","locked":false,"title":"Consolidate SSL Protocol Settings and Enable TLS v1.2 by Default","user":{"login":"asmitaw","id":9653757,"avatar_url":"https://avatars3.githubusercontent.com/u/9653757?v=3","gravatar_id":"","url":"https://api.github.com/users/asmitaw","html_url":"https://github.com/asmitaw","followers_url":"https://api.github.com/users/asmitaw/followers","following_url":"https://api.github.com/users/asmitaw/following{/other_user}","gists_url":"https://api.github.com/users/asmitaw/gists{/gist_id}","starred_url":"https://api.github.com/users/asmitaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmitaw/subscriptions","organizations_url":"https://api.github.com/users/asmitaw/orgs","repos_url":"https://api.github.com/users/asmitaw/repos","events_url":"https://api.github.com/users/asmitaw/events{/privacy}","received_events_url":"https://api.github.com/users/asmitaw/received_events","type":"User","site_admin":false},"body":"Consolidate SSL Protocol Settings and Enable TLS v1.2 by Default #196\r\n\r\n1) The SSL Settings from the security.conf file are commented\r\n2) httpd-ssl.conf is patched to exclude everything but only include the SSLProtocol and cipher settings.\r\nI tried cleaning minimal , but rest are mostly HTTPs and virtual host related settings and we never needed them by default \r\n3) doc/answer page is updated to reflect 2) above.","created_at":"2017-06-15T08:10:29Z","updated_at":"2017-06-15T15:46:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df77575392f88abe997e824e6a47731f942d91d3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/earthenterprise/pulls/242/commits","review_comments_url":"https://api.github.com/repos/google/earthenterprise/pulls/242/comments","review_comment_url":"https://api.github.com/repos/google/earthenterprise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/earthenterprise/issues/242/comments","statuses_url":"https://api.github.com/repos/google/earthenterprise/statuses/dce1f5b422ba9cff2078ae07e066c07f397ae35b","head":{"label":"google:SSLConsolidation","ref":"SSLConsolidation","sha":"dce1f5b422ba9cff2078ae07e066c07f397ae35b","user":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":85630134,"name":"earthenterprise","full_name":"google/earthenterprise","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/earthenterprise","description":"Google Earth Enterprise - Open Source","fork":false,"url":"https://api.github.com/repos/google/earthenterprise","forks_url":"https://api.github.com/repos/google/earthenterprise/forks","keys_url":"https://api.github.com/repos/google/earthenterprise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/earthenterprise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/earthenterprise/teams","hooks_url":"https://api.github.com/repos/google/earthenterprise/hooks","issue_events_url":"https://api.github.com/repos/google/earthenterprise/issues/events{/number}","events_url":"https://api.github.com/repos/google/earthenterprise/events","assignees_url":"https://api.github.com/repos/google/earthenterprise/assignees{/user}","branches_url":"https://api.github.com/repos/google/earthenterprise/branches{/branch}","tags_url":"https://api.github.com/repos/google/earthenterprise/tags","blobs_url":"https://api.github.com/repos/google/earthenterprise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/earthenterprise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/earthenterprise/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/earthenterprise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/earthenterprise/statuses/{sha}","languages_url":"https://api.github.com/repos/google/earthenterprise/languages","stargazers_url":"https://api.github.com/repos/google/earthenterprise/stargazers","contributors_url":"https://api.github.com/repos/google/earthenterprise/contributors","subscribers_url":"https://api.github.com/repos/google/earthenterprise/subscribers","subscription_url":"https://api.github.com/repos/google/earthenterprise/subscription","commits_url":"https://api.github.com/repos/google/earthenterprise/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/earthenterprise/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/earthenterprise/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/earthenterprise/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/earthenterprise/contents/{+path}","compare_url":"https://api.github.com/repos/google/earthenterprise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/earthenterprise/merges","archive_url":"https://api.github.com/repos/google/earthenterprise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/earthenterprise/downloads","issues_url":"https://api.github.com/repos/google/earthenterprise/issues{/number}","pulls_url":"https://api.github.com/repos/google/earthenterprise/pulls{/number}","milestones_url":"https://api.github.com/repos/google/earthenterprise/milestones{/number}","notifications_url":"https://api.github.com/repos/google/earthenterprise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/earthenterprise/labels{/name}","releases_url":"https://api.github.com/repos/google/earthenterprise/releases{/id}","deployments_url":"https://api.github.com/repos/google/earthenterprise/deployments","created_at":"2017-03-20T21:40:53Z","updated_at":"2017-06-15T07:54:08Z","pushed_at":"2017-06-15T14:39:54Z","git_url":"git://github.com/google/earthenterprise.git","ssh_url":"[email protected]:google/earthenterprise.git","clone_url":"https://github.com/google/earthenterprise.git","svn_url":"https://github.com/google/earthenterprise","homepage":"","size":305376,"stargazers_count":1134,"watchers_count":1134,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":312,"mirror_url":null,"open_issues_count":70,"forks":312,"open_issues":70,"watchers":1134,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"e723d1c91a00cd9d8898b404e9db160596284450","user":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":85630134,"name":"earthenterprise","full_name":"google/earthenterprise","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/earthenterprise","description":"Google Earth Enterprise - Open Source","fork":false,"url":"https://api.github.com/repos/google/earthenterprise","forks_url":"https://api.github.com/repos/google/earthenterprise/forks","keys_url":"https://api.github.com/repos/google/earthenterprise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/earthenterprise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/earthenterprise/teams","hooks_url":"https://api.github.com/repos/google/earthenterprise/hooks","issue_events_url":"https://api.github.com/repos/google/earthenterprise/issues/events{/number}","events_url":"https://api.github.com/repos/google/earthenterprise/events","assignees_url":"https://api.github.com/repos/google/earthenterprise/assignees{/user}","branches_url":"https://api.github.com/repos/google/earthenterprise/branches{/branch}","tags_url":"https://api.github.com/repos/google/earthenterprise/tags","blobs_url":"https://api.github.com/repos/google/earthenterprise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/earthenterprise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/earthenterprise/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/earthenterprise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/earthenterprise/statuses/{sha}","languages_url":"https://api.github.com/repos/google/earthenterprise/languages","stargazers_url":"https://api.github.com/repos/google/earthenterprise/stargazers","contributors_url":"https://api.github.com/repos/google/earthenterprise/contributors","subscribers_url":"https://api.github.com/repos/google/earthenterprise/subscribers","subscription_url":"https://api.github.com/repos/google/earthenterprise/subscription","commits_url":"https://api.github.com/repos/google/earthenterprise/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/earthenterprise/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/earthenterprise/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/earthenterprise/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/earthenterprise/contents/{+path}","compare_url":"https://api.github.com/repos/google/earthenterprise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/earthenterprise/merges","archive_url":"https://api.github.com/repos/google/earthenterprise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/earthenterprise/downloads","issues_url":"https://api.github.com/repos/google/earthenterprise/issues{/number}","pulls_url":"https://api.github.com/repos/google/earthenterprise/pulls{/number}","milestones_url":"https://api.github.com/repos/google/earthenterprise/milestones{/number}","notifications_url":"https://api.github.com/repos/google/earthenterprise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/earthenterprise/labels{/name}","releases_url":"https://api.github.com/repos/google/earthenterprise/releases{/id}","deployments_url":"https://api.github.com/repos/google/earthenterprise/deployments","created_at":"2017-03-20T21:40:53Z","updated_at":"2017-06-15T07:54:08Z","pushed_at":"2017-06-15T14:39:54Z","git_url":"git://github.com/google/earthenterprise.git","ssh_url":"[email protected]:google/earthenterprise.git","clone_url":"https://github.com/google/earthenterprise.git","svn_url":"https://github.com/google/earthenterprise","homepage":"","size":305376,"stargazers_count":1134,"watchers_count":1134,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":312,"mirror_url":null,"open_issues_count":70,"forks":312,"open_issues":70,"watchers":1134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/earthenterprise/pulls/242"},"html":{"href":"https://github.com/google/earthenterprise/pull/242"},"issue":{"href":"https://api.github.com/repos/google/earthenterprise/issues/242"},"comments":{"href":"https://api.github.com/repos/google/earthenterprise/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/google/earthenterprise/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/google/earthenterprise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/earthenterprise/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/google/earthenterprise/statuses/dce1f5b422ba9cff2078ae07e066c07f397ae35b"}}}} | {
"id": 85630134,
"name": "google/earthenterprise",
"url": "https://api.github.com/repos/google/earthenterprise"
} | {
"id": 9653757,
"login": "asmitaw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9653757?",
"url": "https://api.github.com/users/asmitaw"
} | {
"id": 1342004,
"login": "google",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1342004?",
"url": "https://api.github.com/orgs/google"
} | 2017-06-15T15:46:40 | 6073453726 | {"actor":{"display_login":"asmitaw"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/google/go-github/pulls/comments/133119010","pull_request_review_id":56264414,"id":133119010,"diff_hunk":"@@ -248,6 +248,52 @@ func TestNewRequest_emptyBody(t *testing.T) {\n \t}\n }\n \n+func TestNewRequest_errorForNoTrailingSlash(t *testing.T) {\n+\ttests := []struct {\n+\t\trawurl string\n+\t\tisError bool\n+\t}{\n+\t\t{\"https://example.com/api/v3\", true},\n+\t\t{\"https://example.com/api/v3/\", false},","path":"github/github_test.go","position":null,"original_position":19,"commit_id":"76bdf345bc07ea7260fd374a359d5880322c5f42","original_commit_id":"e68eb06b868cbdb8afbeb24018a3e32836eac9fa","user":{"login":"178inaba","id":12012186,"avatar_url":"https://avatars1.githubusercontent.com/u/12012186?v=4","gravatar_id":"","url":"https://api.github.com/users/178inaba","html_url":"https://github.com/178inaba","followers_url":"https://api.github.com/users/178inaba/followers","following_url":"https://api.github.com/users/178inaba/following{/other_user}","gists_url":"https://api.github.com/users/178inaba/gists{/gist_id}","starred_url":"https://api.github.com/users/178inaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/178inaba/subscriptions","organizations_url":"https://api.github.com/users/178inaba/orgs","repos_url":"https://api.github.com/users/178inaba/repos","events_url":"https://api.github.com/users/178inaba/events{/privacy}","received_events_url":"https://api.github.com/users/178inaba/received_events","type":"User","site_admin":false},"body":"Thank you so much for review!\r\nFixed the test.\r\nPTAL 🙇 ","created_at":"2017-08-15T05:29:00Z","updated_at":"2017-08-15T05:29:01Z","html_url":"https://github.com/google/go-github/pull/692#discussion_r133119010","pull_request_url":"https://api.github.com/repos/google/go-github/pulls/692","_links":{"self":{"href":"https://api.github.com/repos/google/go-github/pulls/comments/133119010"},"html":{"href":"https://github.com/google/go-github/pull/692#discussion_r133119010"},"pull_request":{"href":"https://api.github.com/repos/google/go-github/pulls/692"}}},"pull_request":{"url":"https://api.github.com/repos/google/go-github/pulls/692","id":135413080,"html_url":"https://github.com/google/go-github/pull/692","diff_url":"https://github.com/google/go-github/pull/692.diff","patch_url":"https://github.com/google/go-github/pull/692.patch","issue_url":"https://api.github.com/repos/google/go-github/issues/692","number":692,"state":"open","locked":false,"title":"Add error for no trailing slash","user":{"login":"178inaba","id":12012186,"avatar_url":"https://avatars1.githubusercontent.com/u/12012186?v=4","gravatar_id":"","url":"https://api.github.com/users/178inaba","html_url":"https://github.com/178inaba","followers_url":"https://api.github.com/users/178inaba/followers","following_url":"https://api.github.com/users/178inaba/following{/other_user}","gists_url":"https://api.github.com/users/178inaba/gists{/gist_id}","starred_url":"https://api.github.com/users/178inaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/178inaba/subscriptions","organizations_url":"https://api.github.com/users/178inaba/orgs","repos_url":"https://api.github.com/users/178inaba/repos","events_url":"https://api.github.com/users/178inaba/events{/privacy}","received_events_url":"https://api.github.com/users/178inaba/received_events","type":"User","site_admin":false},"body":"This pull request provides logic to return an error if there is no slash at the end of `BaseURL` or `UploadURL`.\r\n\r\nRelated comment:\r\nhttps://github.com/google/go-github/pull/690#issuecomment-321879628","created_at":"2017-08-11T20:29:10Z","updated_at":"2017-08-15T05:29:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a2737c9ac6e55d4376cd8b9674b846611199f9e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gmlewis","id":6598971,"avatar_url":"https://avatars1.githubusercontent.com/u/6598971?v=4","gravatar_id":"","url":"https://api.github.com/users/gmlewis","html_url":"https://github.com/gmlewis","followers_url":"https://api.github.com/users/gmlewis/followers","following_url":"https://api.github.com/users/gmlewis/following{/other_user}","gists_url":"https://api.github.com/users/gmlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/gmlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmlewis/subscriptions","organizations_url":"https://api.github.com/users/gmlewis/orgs","repos_url":"https://api.github.com/users/gmlewis/repos","events_url":"https://api.github.com/users/gmlewis/events{/privacy}","received_events_url":"https://api.github.com/users/gmlewis/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/go-github/pulls/692/commits","review_comments_url":"https://api.github.com/repos/google/go-github/pulls/692/comments","review_comment_url":"https://api.github.com/repos/google/go-github/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/go-github/issues/692/comments","statuses_url":"https://api.github.com/repos/google/go-github/statuses/76bdf345bc07ea7260fd374a359d5880322c5f42","head":{"label":"178inaba:error_for_no_trailing_slash","ref":"error_for_no_trailing_slash","sha":"76bdf345bc07ea7260fd374a359d5880322c5f42","user":{"login":"178inaba","id":12012186,"avatar_url":"https://avatars1.githubusercontent.com/u/12012186?v=4","gravatar_id":"","url":"https://api.github.com/users/178inaba","html_url":"https://github.com/178inaba","followers_url":"https://api.github.com/users/178inaba/followers","following_url":"https://api.github.com/users/178inaba/following{/other_user}","gists_url":"https://api.github.com/users/178inaba/gists{/gist_id}","starred_url":"https://api.github.com/users/178inaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/178inaba/subscriptions","organizations_url":"https://api.github.com/users/178inaba/orgs","repos_url":"https://api.github.com/users/178inaba/repos","events_url":"https://api.github.com/users/178inaba/events{/privacy}","received_events_url":"https://api.github.com/users/178inaba/received_events","type":"User","site_admin":false},"repo":{"id":100038676,"name":"go-github","full_name":"178inaba/go-github","owner":{"login":"178inaba","id":12012186,"avatar_url":"https://avatars1.githubusercontent.com/u/12012186?v=4","gravatar_id":"","url":"https://api.github.com/users/178inaba","html_url":"https://github.com/178inaba","followers_url":"https://api.github.com/users/178inaba/followers","following_url":"https://api.github.com/users/178inaba/following{/other_user}","gists_url":"https://api.github.com/users/178inaba/gists{/gist_id}","starred_url":"https://api.github.com/users/178inaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/178inaba/subscriptions","organizations_url":"https://api.github.com/users/178inaba/orgs","repos_url":"https://api.github.com/users/178inaba/repos","events_url":"https://api.github.com/users/178inaba/events{/privacy}","received_events_url":"https://api.github.com/users/178inaba/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/178inaba/go-github","description":"Go library for accessing the GitHub API","fork":true,"url":"https://api.github.com/repos/178inaba/go-github","forks_url":"https://api.github.com/repos/178inaba/go-github/forks","keys_url":"https://api.github.com/repos/178inaba/go-github/keys{/key_id}","collaborators_url":"https://api.github.com/repos/178inaba/go-github/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/178inaba/go-github/teams","hooks_url":"https://api.github.com/repos/178inaba/go-github/hooks","issue_events_url":"https://api.github.com/repos/178inaba/go-github/issues/events{/number}","events_url":"https://api.github.com/repos/178inaba/go-github/events","assignees_url":"https://api.github.com/repos/178inaba/go-github/assignees{/user}","branches_url":"https://api.github.com/repos/178inaba/go-github/branches{/branch}","tags_url":"https://api.github.com/repos/178inaba/go-github/tags","blobs_url":"https://api.github.com/repos/178inaba/go-github/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/178inaba/go-github/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/178inaba/go-github/git/refs{/sha}","trees_url":"https://api.github.com/repos/178inaba/go-github/git/trees{/sha}","statuses_url":"https://api.github.com/repos/178inaba/go-github/statuses/{sha}","languages_url":"https://api.github.com/repos/178inaba/go-github/languages","stargazers_url":"https://api.github.com/repos/178inaba/go-github/stargazers","contributors_url":"https://api.github.com/repos/178inaba/go-github/contributors","subscribers_url":"https://api.github.com/repos/178inaba/go-github/subscribers","subscription_url":"https://api.github.com/repos/178inaba/go-github/subscription","commits_url":"https://api.github.com/repos/178inaba/go-github/commits{/sha}","git_commits_url":"https://api.github.com/repos/178inaba/go-github/git/commits{/sha}","comments_url":"https://api.github.com/repos/178inaba/go-github/comments{/number}","issue_comment_url":"https://api.github.com/repos/178inaba/go-github/issues/comments{/number}","contents_url":"https://api.github.com/repos/178inaba/go-github/contents/{+path}","compare_url":"https://api.github.com/repos/178inaba/go-github/compare/{base}...{head}","merges_url":"https://api.github.com/repos/178inaba/go-github/merges","archive_url":"https://api.github.com/repos/178inaba/go-github/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/178inaba/go-github/downloads","issues_url":"https://api.github.com/repos/178inaba/go-github/issues{/number}","pulls_url":"https://api.github.com/repos/178inaba/go-github/pulls{/number}","milestones_url":"https://api.github.com/repos/178inaba/go-github/milestones{/number}","notifications_url":"https://api.github.com/repos/178inaba/go-github/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/178inaba/go-github/labels{/name}","releases_url":"https://api.github.com/repos/178inaba/go-github/releases{/id}","deployments_url":"https://api.github.com/repos/178inaba/go-github/deployments","created_at":"2017-08-11T14:13:18Z","updated_at":"2017-08-11T14:13:20Z","pushed_at":"2017-08-15T05:27:22Z","git_url":"git://github.com/178inaba/go-github.git","ssh_url":"[email protected]:178inaba/go-github.git","clone_url":"https://github.com/178inaba/go-github.git","svn_url":"https://github.com/178inaba/go-github","homepage":"http://godoc.org/github.com/google/go-github/github","size":1597,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"6afafa88c26eb51b33a8307c944bd2f0ef227af7","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":10270722,"name":"go-github","full_name":"google/go-github","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/go-github","description":"Go library for accessing the GitHub API","fork":false,"url":"https://api.github.com/repos/google/go-github","forks_url":"https://api.github.com/repos/google/go-github/forks","keys_url":"https://api.github.com/repos/google/go-github/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/go-github/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/go-github/teams","hooks_url":"https://api.github.com/repos/google/go-github/hooks","issue_events_url":"https://api.github.com/repos/google/go-github/issues/events{/number}","events_url":"https://api.github.com/repos/google/go-github/events","assignees_url":"https://api.github.com/repos/google/go-github/assignees{/user}","branches_url":"https://api.github.com/repos/google/go-github/branches{/branch}","tags_url":"https://api.github.com/repos/google/go-github/tags","blobs_url":"https://api.github.com/repos/google/go-github/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/go-github/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/go-github/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/go-github/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/go-github/statuses/{sha}","languages_url":"https://api.github.com/repos/google/go-github/languages","stargazers_url":"https://api.github.com/repos/google/go-github/stargazers","contributors_url":"https://api.github.com/repos/google/go-github/contributors","subscribers_url":"https://api.github.com/repos/google/go-github/subscribers","subscription_url":"https://api.github.com/repos/google/go-github/subscription","commits_url":"https://api.github.com/repos/google/go-github/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/go-github/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/go-github/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/go-github/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/go-github/contents/{+path}","compare_url":"https://api.github.com/repos/google/go-github/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/go-github/merges","archive_url":"https://api.github.com/repos/google/go-github/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/go-github/downloads","issues_url":"https://api.github.com/repos/google/go-github/issues{/number}","pulls_url":"https://api.github.com/repos/google/go-github/pulls{/number}","milestones_url":"https://api.github.com/repos/google/go-github/milestones{/number}","notifications_url":"https://api.github.com/repos/google/go-github/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/go-github/labels{/name}","releases_url":"https://api.github.com/repos/google/go-github/releases{/id}","deployments_url":"https://api.github.com/repos/google/go-github/deployments","created_at":"2013-05-24T16:42:58Z","updated_at":"2017-08-14T20:29:29Z","pushed_at":"2017-08-15T05:27:24Z","git_url":"git://github.com/google/go-github.git","ssh_url":"[email protected]:google/go-github.git","clone_url":"https://github.com/google/go-github.git","svn_url":"https://github.com/google/go-github","homepage":"http://godoc.org/github.com/google/go-github/github","size":1574,"stargazers_count":2804,"watchers_count":2804,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":659,"mirror_url":null,"open_issues_count":42,"forks":659,"open_issues":42,"watchers":2804,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/go-github/pulls/692"},"html":{"href":"https://github.com/google/go-github/pull/692"},"issue":{"href":"https://api.github.com/repos/google/go-github/issues/692"},"comments":{"href":"https://api.github.com/repos/google/go-github/issues/692/comments"},"review_comments":{"href":"https://api.github.com/repos/google/go-github/pulls/692/comments"},"review_comment":{"href":"https://api.github.com/repos/google/go-github/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/go-github/pulls/692/commits"},"statuses":{"href":"https://api.github.com/repos/google/go-github/statuses/76bdf345bc07ea7260fd374a359d5880322c5f42"}}}} | {
"id": 10270722,
"name": "google/go-github",
"url": "https://api.github.com/repos/google/go-github"
} | {
"id": 12012186,
"login": "178inaba",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12012186?",
"url": "https://api.github.com/users/178inaba"
} | {
"id": 1342004,
"login": "google",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1342004?",
"url": "https://api.github.com/orgs/google"
} | 2017-08-15T05:29:00 | 6452780282 | {"actor":{"display_login":"178inaba"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/google/tie/pulls/comments/104113864","pull_request_review_id":24929982,"id":104113864,"diff_hunk":"@@ -284,6 +368,14 @@ tie.directive('learnerView', [function() {\n }\n };\n \n+ $scope.navigateToQuestion = function(index) {\n+ if ($scope.unlockedQuestions[index]) {\n+ $scope.currentQuestionIndex = index;\n+ var questionId = $scope.questionIds[$scope.currentQuestionIndex];\n+ loadQuestion(questionId, questionSet.getIntroductionParagraphs());\n+ }\n+ }","path":"client/components/LearnerViewDirective.js","position":256,"original_position":256,"commit_id":"9584ff56967b6180f24a35e22987599e43a3bf14","original_commit_id":"9584ff56967b6180f24a35e22987599e43a3bf14","user":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars3.githubusercontent.com/u/10575562?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"body":"missing semicolon","created_at":"2017-03-03T09:14:08Z","updated_at":"2017-03-03T09:18:59Z","html_url":"https://github.com/google/tie/pull/27#discussion_r104113864","pull_request_url":"https://api.github.com/repos/google/tie/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/google/tie/pulls/comments/104113864"},"html":{"href":"https://github.com/google/tie/pull/27#discussion_r104113864"},"pull_request":{"href":"https://api.github.com/repos/google/tie/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/google/tie/pulls/27","id":108929526,"html_url":"https://github.com/google/tie/pull/27","diff_url":"https://github.com/google/tie/pull/27.diff","patch_url":"https://github.com/google/tie/pull/27.patch","issue_url":"https://api.github.com/repos/google/tie/issues/27","number":27,"state":"open","locked":false,"title":"Revised UI with navigation and new next button.","user":{"login":"rabidbit","id":25493966,"avatar_url":"https://avatars2.githubusercontent.com/u/25493966?v=3","gravatar_id":"","url":"https://api.github.com/users/rabidbit","html_url":"https://github.com/rabidbit","followers_url":"https://api.github.com/users/rabidbit/followers","following_url":"https://api.github.com/users/rabidbit/following{/other_user}","gists_url":"https://api.github.com/users/rabidbit/gists{/gist_id}","starred_url":"https://api.github.com/users/rabidbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabidbit/subscriptions","organizations_url":"https://api.github.com/users/rabidbit/orgs","repos_url":"https://api.github.com/users/rabidbit/repos","events_url":"https://api.github.com/users/rabidbit/events{/privacy}","received_events_url":"https://api.github.com/users/rabidbit/received_events","type":"User","site_admin":false},"body":"Error running local tests on my Mac. Away from office; so, cannot test on my workstation. Creating pull request.","created_at":"2017-03-03T08:46:33Z","updated_at":"2017-03-03T09:18:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85d93b7dac2a18a94bd216597bb56edb2deafbc5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/tie/pulls/27/commits","review_comments_url":"https://api.github.com/repos/google/tie/pulls/27/comments","review_comment_url":"https://api.github.com/repos/google/tie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/tie/issues/27/comments","statuses_url":"https://api.github.com/repos/google/tie/statuses/9584ff56967b6180f24a35e22987599e43a3bf14","head":{"label":"google:updated-ui-2017-03-03-a","ref":"updated-ui-2017-03-03-a","sha":"9584ff56967b6180f24a35e22987599e43a3bf14","user":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":81500046,"name":"tie","full_name":"google/tie","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/tie","description":null,"fork":false,"url":"https://api.github.com/repos/google/tie","forks_url":"https://api.github.com/repos/google/tie/forks","keys_url":"https://api.github.com/repos/google/tie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/tie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/tie/teams","hooks_url":"https://api.github.com/repos/google/tie/hooks","issue_events_url":"https://api.github.com/repos/google/tie/issues/events{/number}","events_url":"https://api.github.com/repos/google/tie/events","assignees_url":"https://api.github.com/repos/google/tie/assignees{/user}","branches_url":"https://api.github.com/repos/google/tie/branches{/branch}","tags_url":"https://api.github.com/repos/google/tie/tags","blobs_url":"https://api.github.com/repos/google/tie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/tie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/tie/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/tie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/tie/statuses/{sha}","languages_url":"https://api.github.com/repos/google/tie/languages","stargazers_url":"https://api.github.com/repos/google/tie/stargazers","contributors_url":"https://api.github.com/repos/google/tie/contributors","subscribers_url":"https://api.github.com/repos/google/tie/subscribers","subscription_url":"https://api.github.com/repos/google/tie/subscription","commits_url":"https://api.github.com/repos/google/tie/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/tie/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/tie/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/tie/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/tie/contents/{+path}","compare_url":"https://api.github.com/repos/google/tie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/tie/merges","archive_url":"https://api.github.com/repos/google/tie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/tie/downloads","issues_url":"https://api.github.com/repos/google/tie/issues{/number}","pulls_url":"https://api.github.com/repos/google/tie/pulls{/number}","milestones_url":"https://api.github.com/repos/google/tie/milestones{/number}","notifications_url":"https://api.github.com/repos/google/tie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/tie/labels{/name}","releases_url":"https://api.github.com/repos/google/tie/releases{/id}","deployments_url":"https://api.github.com/repos/google/tie/deployments","created_at":"2017-02-09T22:11:24Z","updated_at":"2017-03-03T08:49:28Z","pushed_at":"2017-03-03T08:46:34Z","git_url":"git://github.com/google/tie.git","ssh_url":"[email protected]:google/tie.git","clone_url":"https://github.com/google/tie.git","svn_url":"https://github.com/google/tie","homepage":null,"size":557,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":17,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"a0d7d7b4e5b5e560054363a20a1aacf337809373","user":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":81500046,"name":"tie","full_name":"google/tie","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/tie","description":null,"fork":false,"url":"https://api.github.com/repos/google/tie","forks_url":"https://api.github.com/repos/google/tie/forks","keys_url":"https://api.github.com/repos/google/tie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/tie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/tie/teams","hooks_url":"https://api.github.com/repos/google/tie/hooks","issue_events_url":"https://api.github.com/repos/google/tie/issues/events{/number}","events_url":"https://api.github.com/repos/google/tie/events","assignees_url":"https://api.github.com/repos/google/tie/assignees{/user}","branches_url":"https://api.github.com/repos/google/tie/branches{/branch}","tags_url":"https://api.github.com/repos/google/tie/tags","blobs_url":"https://api.github.com/repos/google/tie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/tie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/tie/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/tie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/tie/statuses/{sha}","languages_url":"https://api.github.com/repos/google/tie/languages","stargazers_url":"https://api.github.com/repos/google/tie/stargazers","contributors_url":"https://api.github.com/repos/google/tie/contributors","subscribers_url":"https://api.github.com/repos/google/tie/subscribers","subscription_url":"https://api.github.com/repos/google/tie/subscription","commits_url":"https://api.github.com/repos/google/tie/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/tie/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/tie/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/tie/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/tie/contents/{+path}","compare_url":"https://api.github.com/repos/google/tie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/tie/merges","archive_url":"https://api.github.com/repos/google/tie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/tie/downloads","issues_url":"https://api.github.com/repos/google/tie/issues{/number}","pulls_url":"https://api.github.com/repos/google/tie/pulls{/number}","milestones_url":"https://api.github.com/repos/google/tie/milestones{/number}","notifications_url":"https://api.github.com/repos/google/tie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/tie/labels{/name}","releases_url":"https://api.github.com/repos/google/tie/releases{/id}","deployments_url":"https://api.github.com/repos/google/tie/deployments","created_at":"2017-02-09T22:11:24Z","updated_at":"2017-03-03T08:49:28Z","pushed_at":"2017-03-03T08:46:34Z","git_url":"git://github.com/google/tie.git","ssh_url":"[email protected]:google/tie.git","clone_url":"https://github.com/google/tie.git","svn_url":"https://github.com/google/tie","homepage":null,"size":557,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/tie/pulls/27"},"html":{"href":"https://github.com/google/tie/pull/27"},"issue":{"href":"https://api.github.com/repos/google/tie/issues/27"},"comments":{"href":"https://api.github.com/repos/google/tie/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/google/tie/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/google/tie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/tie/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/google/tie/statuses/9584ff56967b6180f24a35e22987599e43a3bf14"}}}} | {
"id": 81500046,
"name": "google/tie",
"url": "https://api.github.com/repos/google/tie"
} | {
"id": 10575562,
"login": "seanlip",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10575562?",
"url": "https://api.github.com/users/seanlip"
} | {
"id": 1342004,
"login": "google",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1342004?",
"url": "https://api.github.com/orgs/google"
} | 2017-03-03T09:14:08 | 5426182480 | {"actor":{"display_login":"seanlip"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/google/earthenterprise/pulls/comments/118076825","pull_request_review_id":39835594,"id":118076825,"diff_hunk":"@@ -134,21 +119,54 @@ env = khEnvironment(ENV={'PATH' : '/bin:/bin:/usr/bin'},\n exportdirs=exportdirs,\n installdirs=installdirs,\n JAVA_HOME=\"/opt/google/java\")\n-env.Alias('install', installdirs['root'])\n+\n+def getArgumentVarsAsString():\n+ vars=''\n+ for var, value in ARGUMENTS.iteritems():\n+ if var != 'installdir':\n+ vars += var + '=' + str(value) + ' '\n+ return vars[:-1] # Remove the trailing space\n+\n+arg_vars = getArgumentVarsAsString()\n+num_jobs = GetOption('num_jobs')\n+\n+# Build Fusion and Server\n+build_cmds = {'build': [\n+ 'cd src; scons -j%d %s third_party' % (num_jobs, arg_vars),\n+ 'cd src; scons -j%d %s' % (num_jobs, arg_vars)\n+]}\n+run_build = env.PhonyTargets(**build_cmds)\n+\n+# Copy the binaries to the install staging directory\n+stage_bin_cmds = {'stage_bin': [\n+ 'cd src; scons -j%d installdir=%s %s install' % (num_jobs, installdir, arg_vars)\n+]}\n+stage_bin = env.PhonyTargets(**stage_bin_cmds)\n+\n+# Copy the data and docs to the install staging directory\n+stage_data = env.Alias('stage_data', installdirs['root'])\n+env.Depends(stage_data, stage_bin)\n+\n+# Copy the tutorial to the install staging directory if it exists.\n+stage_tutorial_cmds = {'stage_tutorial': [\n+ 'cd tutorial; if [ -d FusionTutorial ]; then scons -j%d installdir=%s; else echo \"Skipping tutorial; no tutorial files found.\"; fi' % (num_jobs, installdir)","path":"earth_enterprise/SConstruct","position":60,"original_position":60,"commit_id":"e2e539882ba9894417d07e3dd43d1fc6690466ab","original_commit_id":"e2e539882ba9894417d07e3dd43d1fc6690466ab","user":{"login":"tst-ppenev","id":17442305,"avatar_url":"https://avatars1.githubusercontent.com/u/17442305?v=3","gravatar_id":"","url":"https://api.github.com/users/tst-ppenev","html_url":"https://github.com/tst-ppenev","followers_url":"https://api.github.com/users/tst-ppenev/followers","following_url":"https://api.github.com/users/tst-ppenev/following{/other_user}","gists_url":"https://api.github.com/users/tst-ppenev/gists{/gist_id}","starred_url":"https://api.github.com/users/tst-ppenev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tst-ppenev/subscriptions","organizations_url":"https://api.github.com/users/tst-ppenev/orgs","repos_url":"https://api.github.com/users/tst-ppenev/repos","events_url":"https://api.github.com/users/tst-ppenev/events{/privacy}","received_events_url":"https://api.github.com/users/tst-ppenev/received_events","type":"User","site_admin":false},"body":"Same as above for `installdir`.","created_at":"2017-05-23T18:54:34Z","updated_at":"2017-05-23T18:57:50Z","html_url":"https://github.com/google/earthenterprise/pull/175#discussion_r118076825","pull_request_url":"https://api.github.com/repos/google/earthenterprise/pulls/175","_links":{"self":{"href":"https://api.github.com/repos/google/earthenterprise/pulls/comments/118076825"},"html":{"href":"https://github.com/google/earthenterprise/pull/175#discussion_r118076825"},"pull_request":{"href":"https://api.github.com/repos/google/earthenterprise/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/google/earthenterprise/pulls/175","id":121544959,"html_url":"https://github.com/google/earthenterprise/pull/175","diff_url":"https://github.com/google/earthenterprise/pull/175.diff","patch_url":"https://github.com/google/earthenterprise/pull/175.patch","issue_url":"https://api.github.com/repos/google/earthenterprise/issues/175","number":175,"state":"open","locked":false,"title":"Create build and install targets in top level SConstruct (#131, #123)","user":{"login":"tst-lsavoie","id":9662346,"avatar_url":"https://avatars2.githubusercontent.com/u/9662346?v=3","gravatar_id":"","url":"https://api.github.com/users/tst-lsavoie","html_url":"https://github.com/tst-lsavoie","followers_url":"https://api.github.com/users/tst-lsavoie/followers","following_url":"https://api.github.com/users/tst-lsavoie/following{/other_user}","gists_url":"https://api.github.com/users/tst-lsavoie/gists{/gist_id}","starred_url":"https://api.github.com/users/tst-lsavoie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tst-lsavoie/subscriptions","organizations_url":"https://api.github.com/users/tst-lsavoie/orgs","repos_url":"https://api.github.com/users/tst-lsavoie/repos","events_url":"https://api.github.com/users/tst-lsavoie/events{/privacy}","received_events_url":"https://api.github.com/users/tst-lsavoie/received_events","type":"User","site_admin":false},"body":"This change allows the user to run a complete build and to stage install files using a single command for each. The old method of building and installing is still available, but this method is simpler because it requires fewer commands and doesn't require changing directories. This also sets the default install directory to /tmp/fusion_os_installer.\r\n\r\nThe new instructions for building and creating install files are as follows:\r\n```\r\ncd earthenterprise/earth_enterprise\r\nscons -j8 optimize=1 build\r\nscons -j8 optimize=1 stage_install\r\n```\r\nThen go to `src/installer` and run the installers. I will update the wiki with these instructions when this PR is merged.\r\n\r\nTested on Ubuntu 14.04 and RHEL 7.\r\n\r\nFixes #131 \r\nFixes #123","created_at":"2017-05-19T17:14:09Z","updated_at":"2017-05-23T18:57:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c3e2dbd63e497e06ef4f431ca5bd3540be11fe6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tst-ccamp","id":5263337,"avatar_url":"https://avatars1.githubusercontent.com/u/5263337?v=3","gravatar_id":"","url":"https://api.github.com/users/tst-ccamp","html_url":"https://github.com/tst-ccamp","followers_url":"https://api.github.com/users/tst-ccamp/followers","following_url":"https://api.github.com/users/tst-ccamp/following{/other_user}","gists_url":"https://api.github.com/users/tst-ccamp/gists{/gist_id}","starred_url":"https://api.github.com/users/tst-ccamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tst-ccamp/subscriptions","organizations_url":"https://api.github.com/users/tst-ccamp/orgs","repos_url":"https://api.github.com/users/tst-ccamp/repos","events_url":"https://api.github.com/users/tst-ccamp/events{/privacy}","received_events_url":"https://api.github.com/users/tst-ccamp/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/earthenterprise/pulls/175/commits","review_comments_url":"https://api.github.com/repos/google/earthenterprise/pulls/175/comments","review_comment_url":"https://api.github.com/repos/google/earthenterprise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/earthenterprise/issues/175/comments","statuses_url":"https://api.github.com/repos/google/earthenterprise/statuses/e2e539882ba9894417d07e3dd43d1fc6690466ab","head":{"label":"tst-lsavoie:build-from-top-level","ref":"build-from-top-level","sha":"e2e539882ba9894417d07e3dd43d1fc6690466ab","user":{"login":"tst-lsavoie","id":9662346,"avatar_url":"https://avatars2.githubusercontent.com/u/9662346?v=3","gravatar_id":"","url":"https://api.github.com/users/tst-lsavoie","html_url":"https://github.com/tst-lsavoie","followers_url":"https://api.github.com/users/tst-lsavoie/followers","following_url":"https://api.github.com/users/tst-lsavoie/following{/other_user}","gists_url":"https://api.github.com/users/tst-lsavoie/gists{/gist_id}","starred_url":"https://api.github.com/users/tst-lsavoie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tst-lsavoie/subscriptions","organizations_url":"https://api.github.com/users/tst-lsavoie/orgs","repos_url":"https://api.github.com/users/tst-lsavoie/repos","events_url":"https://api.github.com/users/tst-lsavoie/events{/privacy}","received_events_url":"https://api.github.com/users/tst-lsavoie/received_events","type":"User","site_admin":false},"repo":{"id":87125546,"name":"earthenterprise","full_name":"tst-lsavoie/earthenterprise","owner":{"login":"tst-lsavoie","id":9662346,"avatar_url":"https://avatars2.githubusercontent.com/u/9662346?v=3","gravatar_id":"","url":"https://api.github.com/users/tst-lsavoie","html_url":"https://github.com/tst-lsavoie","followers_url":"https://api.github.com/users/tst-lsavoie/followers","following_url":"https://api.github.com/users/tst-lsavoie/following{/other_user}","gists_url":"https://api.github.com/users/tst-lsavoie/gists{/gist_id}","starred_url":"https://api.github.com/users/tst-lsavoie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tst-lsavoie/subscriptions","organizations_url":"https://api.github.com/users/tst-lsavoie/orgs","repos_url":"https://api.github.com/users/tst-lsavoie/repos","events_url":"https://api.github.com/users/tst-lsavoie/events{/privacy}","received_events_url":"https://api.github.com/users/tst-lsavoie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tst-lsavoie/earthenterprise","description":"Google Earth Enterprise - Open Source","fork":true,"url":"https://api.github.com/repos/tst-lsavoie/earthenterprise","forks_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/forks","keys_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/teams","hooks_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/hooks","issue_events_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/issues/events{/number}","events_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/events","assignees_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/assignees{/user}","branches_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/branches{/branch}","tags_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/tags","blobs_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/git/refs{/sha}","trees_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/statuses/{sha}","languages_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/languages","stargazers_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/stargazers","contributors_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/contributors","subscribers_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/subscribers","subscription_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/subscription","commits_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/commits{/sha}","git_commits_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/git/commits{/sha}","comments_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/comments{/number}","issue_comment_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/issues/comments{/number}","contents_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/contents/{+path}","compare_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/merges","archive_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/downloads","issues_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/issues{/number}","pulls_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/pulls{/number}","milestones_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/milestones{/number}","notifications_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/labels{/name}","releases_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/releases{/id}","deployments_url":"https://api.github.com/repos/tst-lsavoie/earthenterprise/deployments","created_at":"2017-04-03T22:09:13Z","updated_at":"2017-04-03T22:09:27Z","pushed_at":"2017-05-19T19:11:22Z","git_url":"git://github.com/tst-lsavoie/earthenterprise.git","ssh_url":"[email protected]:tst-lsavoie/earthenterprise.git","clone_url":"https://github.com/tst-lsavoie/earthenterprise.git","svn_url":"https://github.com/tst-lsavoie/earthenterprise","homepage":"","size":305395,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"b8fd4d760c7226eb8752c81bd676daad9b87db3c","user":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":85630134,"name":"earthenterprise","full_name":"google/earthenterprise","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/earthenterprise","description":"Google Earth Enterprise - Open Source","fork":false,"url":"https://api.github.com/repos/google/earthenterprise","forks_url":"https://api.github.com/repos/google/earthenterprise/forks","keys_url":"https://api.github.com/repos/google/earthenterprise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/earthenterprise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/earthenterprise/teams","hooks_url":"https://api.github.com/repos/google/earthenterprise/hooks","issue_events_url":"https://api.github.com/repos/google/earthenterprise/issues/events{/number}","events_url":"https://api.github.com/repos/google/earthenterprise/events","assignees_url":"https://api.github.com/repos/google/earthenterprise/assignees{/user}","branches_url":"https://api.github.com/repos/google/earthenterprise/branches{/branch}","tags_url":"https://api.github.com/repos/google/earthenterprise/tags","blobs_url":"https://api.github.com/repos/google/earthenterprise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/earthenterprise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/earthenterprise/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/earthenterprise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/earthenterprise/statuses/{sha}","languages_url":"https://api.github.com/repos/google/earthenterprise/languages","stargazers_url":"https://api.github.com/repos/google/earthenterprise/stargazers","contributors_url":"https://api.github.com/repos/google/earthenterprise/contributors","subscribers_url":"https://api.github.com/repos/google/earthenterprise/subscribers","subscription_url":"https://api.github.com/repos/google/earthenterprise/subscription","commits_url":"https://api.github.com/repos/google/earthenterprise/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/earthenterprise/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/earthenterprise/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/earthenterprise/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/earthenterprise/contents/{+path}","compare_url":"https://api.github.com/repos/google/earthenterprise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/earthenterprise/merges","archive_url":"https://api.github.com/repos/google/earthenterprise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/earthenterprise/downloads","issues_url":"https://api.github.com/repos/google/earthenterprise/issues{/number}","pulls_url":"https://api.github.com/repos/google/earthenterprise/pulls{/number}","milestones_url":"https://api.github.com/repos/google/earthenterprise/milestones{/number}","notifications_url":"https://api.github.com/repos/google/earthenterprise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/earthenterprise/labels{/name}","releases_url":"https://api.github.com/repos/google/earthenterprise/releases{/id}","deployments_url":"https://api.github.com/repos/google/earthenterprise/deployments","created_at":"2017-03-20T21:40:53Z","updated_at":"2017-05-23T13:37:04Z","pushed_at":"2017-05-23T11:28:42Z","git_url":"git://github.com/google/earthenterprise.git","ssh_url":"[email protected]:google/earthenterprise.git","clone_url":"https://github.com/google/earthenterprise.git","svn_url":"https://github.com/google/earthenterprise","homepage":"","size":305345,"stargazers_count":1113,"watchers_count":1113,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":300,"mirror_url":null,"open_issues_count":62,"forks":300,"open_issues":62,"watchers":1113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/earthenterprise/pulls/175"},"html":{"href":"https://github.com/google/earthenterprise/pull/175"},"issue":{"href":"https://api.github.com/repos/google/earthenterprise/issues/175"},"comments":{"href":"https://api.github.com/repos/google/earthenterprise/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/google/earthenterprise/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/google/earthenterprise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/earthenterprise/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/google/earthenterprise/statuses/e2e539882ba9894417d07e3dd43d1fc6690466ab"}}}} | {
"id": 85630134,
"name": "google/earthenterprise",
"url": "https://api.github.com/repos/google/earthenterprise"
} | {
"id": 17442305,
"login": "tst-ppenev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17442305?",
"url": "https://api.github.com/users/tst-ppenev"
} | {
"id": 1342004,
"login": "google",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1342004?",
"url": "https://api.github.com/orgs/google"
} | 2017-05-23T18:54:34 | 5928242187 | {"actor":{"display_login":"tst-ppenev"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/google/pprof/pulls/comments/141498537","pull_request_review_id":65722240,"id":141498537,"diff_hunk":"@@ -689,6 +811,122 @@ func locationHash(s *Sample) string {\n \treturn tb\n }\n \n+func TestInferUnits(t *testing.T) {\n+\tvar tagFilterTests = []struct {\n+\t\tname string\n+\t\ttagVals []map[string][]int64\n+\t\ttagUnits []map[string][]string\n+\t\twantUnits map[string]string\n+\t\twantIgnoredUnits map[string][]string\n+\t}{\n+\t\t{\n+\t\t\t\"One sample, multiple keys, different specified units\",\n+\t\t\t[]map[string][]int64{{\"key1\": {131072}, \"key2\": {128}}},\n+\t\t\t[]map[string][]string{{\"key1\": {\"bytes\"}, \"key2\": {\"kilobytes\"}}},\n+\t\t\tmap[string]string{\"key1\": \"bytes\", \"key2\": \"kilobytes\"},\n+\t\t\tmap[string][]string{},\n+\t\t},\n+\t\t{\n+\t\t\t\"One sample, one key with one value, unit specified\",\n+\t\t\t[]map[string][]int64{{\"key1\": {8}}},\n+\t\t\t[]map[string][]string{{\"key1\": {\"bytes\"}}},\n+\t\t\tmap[string]string{\"key1\": \"bytes\"},\n+\t\t\tmap[string][]string{},\n+\t\t},\n+\t\t{\n+\t\t\t\"bytes key, unit not specified\",","path":"profile/profile_test.go","position":170,"original_position":170,"commit_id":"3417c3c5726cf4d164d4661e5a9545488d28534c","original_commit_id":"3417c3c5726cf4d164d4661e5a9545488d28534c","user":{"login":"aalexand","id":1519040,"avatar_url":"https://avatars1.githubusercontent.com/u/1519040?v=4","gravatar_id":"","url":"https://api.github.com/users/aalexand","html_url":"https://github.com/aalexand","followers_url":"https://api.github.com/users/aalexand/followers","following_url":"https://api.github.com/users/aalexand/following{/other_user}","gists_url":"https://api.github.com/users/aalexand/gists{/gist_id}","starred_url":"https://api.github.com/users/aalexand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aalexand/subscriptions","organizations_url":"https://api.github.com/users/aalexand/orgs","repos_url":"https://api.github.com/users/aalexand/repos","events_url":"https://api.github.com/users/aalexand/events{/privacy}","received_events_url":"https://api.github.com/users/aalexand/received_events","type":"User","site_admin":false},"body":"Nit: you start the test name with lowercase here, but with uppercase for the two other cases above, let's be consistent and use the uppercase here and in others.","created_at":"2017-09-28T00:10:30Z","updated_at":"2017-09-28T00:18:05Z","html_url":"https://github.com/google/pprof/pull/213#discussion_r141498537","pull_request_url":"https://api.github.com/repos/google/pprof/pulls/213","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/pprof/pulls/comments/141498537"},"html":{"href":"https://github.com/google/pprof/pull/213#discussion_r141498537"},"pull_request":{"href":"https://api.github.com/repos/google/pprof/pulls/213"}}},"pull_request":{"url":"https://api.github.com/repos/google/pprof/pulls/213","id":138264171,"html_url":"https://github.com/google/pprof/pull/213","diff_url":"https://github.com/google/pprof/pull/213.diff","patch_url":"https://github.com/google/pprof/pull/213.patch","issue_url":"https://api.github.com/repos/google/pprof/issues/213","number":213,"state":"open","locked":false,"title":"Add support for units for numeric tags","user":{"login":"nolanmar511","id":14046562,"avatar_url":"https://avatars0.githubusercontent.com/u/14046562?v=4","gravatar_id":"","url":"https://api.github.com/users/nolanmar511","html_url":"https://github.com/nolanmar511","followers_url":"https://api.github.com/users/nolanmar511/followers","following_url":"https://api.github.com/users/nolanmar511/following{/other_user}","gists_url":"https://api.github.com/users/nolanmar511/gists{/gist_id}","starred_url":"https://api.github.com/users/nolanmar511/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolanmar511/subscriptions","organizations_url":"https://api.github.com/users/nolanmar511/orgs","repos_url":"https://api.github.com/users/nolanmar511/repos","events_url":"https://api.github.com/users/nolanmar511/events{/privacy}","received_events_url":"https://api.github.com/users/nolanmar511/received_events","type":"User","site_admin":false},"body":"Fixes #181, #153\r\n\r\nCurrently, a numeric tag's units are assumed to be given by the key of the tag. This is problematic, because we have numeric tags which represent different things but should have the same units (for example, the actual size of memory allocations is noted with the tag \"bytes\" and requested size of memory allocations with the tag \"request\").\r\n\r\nThis change adds a unit field to Label in profile.proto and enables this field to be used by pprof. Generally, if a numeric tag does not have a unit specified, the unit will still be assumed to be the key. There are two exceptions to this: if the key is \"request\" or \"alignment\", the units will be assumed to be \"bytes\".","created_at":"2017-08-29T19:28:16Z","updated_at":"2017-09-28T00:18:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"827e958c370da8dab183f7aaaede8298e538f87f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/pprof/pulls/213/commits","review_comments_url":"https://api.github.com/repos/google/pprof/pulls/213/comments","review_comment_url":"https://api.github.com/repos/google/pprof/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/pprof/issues/213/comments","statuses_url":"https://api.github.com/repos/google/pprof/statuses/3417c3c5726cf4d164d4661e5a9545488d28534c","head":{"label":"nolanmar511:tag_units","ref":"tag_units","sha":"3417c3c5726cf4d164d4661e5a9545488d28534c","user":{"login":"nolanmar511","id":14046562,"avatar_url":"https://avatars0.githubusercontent.com/u/14046562?v=4","gravatar_id":"","url":"https://api.github.com/users/nolanmar511","html_url":"https://github.com/nolanmar511","followers_url":"https://api.github.com/users/nolanmar511/followers","following_url":"https://api.github.com/users/nolanmar511/following{/other_user}","gists_url":"https://api.github.com/users/nolanmar511/gists{/gist_id}","starred_url":"https://api.github.com/users/nolanmar511/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolanmar511/subscriptions","organizations_url":"https://api.github.com/users/nolanmar511/orgs","repos_url":"https://api.github.com/users/nolanmar511/repos","events_url":"https://api.github.com/users/nolanmar511/events{/privacy}","received_events_url":"https://api.github.com/users/nolanmar511/received_events","type":"User","site_admin":false},"repo":{"id":96943070,"name":"pprof","full_name":"nolanmar511/pprof","owner":{"login":"nolanmar511","id":14046562,"avatar_url":"https://avatars0.githubusercontent.com/u/14046562?v=4","gravatar_id":"","url":"https://api.github.com/users/nolanmar511","html_url":"https://github.com/nolanmar511","followers_url":"https://api.github.com/users/nolanmar511/followers","following_url":"https://api.github.com/users/nolanmar511/following{/other_user}","gists_url":"https://api.github.com/users/nolanmar511/gists{/gist_id}","starred_url":"https://api.github.com/users/nolanmar511/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolanmar511/subscriptions","organizations_url":"https://api.github.com/users/nolanmar511/orgs","repos_url":"https://api.github.com/users/nolanmar511/repos","events_url":"https://api.github.com/users/nolanmar511/events{/privacy}","received_events_url":"https://api.github.com/users/nolanmar511/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nolanmar511/pprof","description":"pprof is a tool for visualization and analysis of profiling data","fork":true,"url":"https://api.github.com/repos/nolanmar511/pprof","forks_url":"https://api.github.com/repos/nolanmar511/pprof/forks","keys_url":"https://api.github.com/repos/nolanmar511/pprof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nolanmar511/pprof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nolanmar511/pprof/teams","hooks_url":"https://api.github.com/repos/nolanmar511/pprof/hooks","issue_events_url":"https://api.github.com/repos/nolanmar511/pprof/issues/events{/number}","events_url":"https://api.github.com/repos/nolanmar511/pprof/events","assignees_url":"https://api.github.com/repos/nolanmar511/pprof/assignees{/user}","branches_url":"https://api.github.com/repos/nolanmar511/pprof/branches{/branch}","tags_url":"https://api.github.com/repos/nolanmar511/pprof/tags","blobs_url":"https://api.github.com/repos/nolanmar511/pprof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nolanmar511/pprof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nolanmar511/pprof/git/refs{/sha}","trees_url":"https://api.github.com/repos/nolanmar511/pprof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nolanmar511/pprof/statuses/{sha}","languages_url":"https://api.github.com/repos/nolanmar511/pprof/languages","stargazers_url":"https://api.github.com/repos/nolanmar511/pprof/stargazers","contributors_url":"https://api.github.com/repos/nolanmar511/pprof/contributors","subscribers_url":"https://api.github.com/repos/nolanmar511/pprof/subscribers","subscription_url":"https://api.github.com/repos/nolanmar511/pprof/subscription","commits_url":"https://api.github.com/repos/nolanmar511/pprof/commits{/sha}","git_commits_url":"https://api.github.com/repos/nolanmar511/pprof/git/commits{/sha}","comments_url":"https://api.github.com/repos/nolanmar511/pprof/comments{/number}","issue_comment_url":"https://api.github.com/repos/nolanmar511/pprof/issues/comments{/number}","contents_url":"https://api.github.com/repos/nolanmar511/pprof/contents/{+path}","compare_url":"https://api.github.com/repos/nolanmar511/pprof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nolanmar511/pprof/merges","archive_url":"https://api.github.com/repos/nolanmar511/pprof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nolanmar511/pprof/downloads","issues_url":"https://api.github.com/repos/nolanmar511/pprof/issues{/number}","pulls_url":"https://api.github.com/repos/nolanmar511/pprof/pulls{/number}","milestones_url":"https://api.github.com/repos/nolanmar511/pprof/milestones{/number}","notifications_url":"https://api.github.com/repos/nolanmar511/pprof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nolanmar511/pprof/labels{/name}","releases_url":"https://api.github.com/repos/nolanmar511/pprof/releases{/id}","deployments_url":"https://api.github.com/repos/nolanmar511/pprof/deployments","created_at":"2017-07-11T22:40:25Z","updated_at":"2017-07-11T22:40:27Z","pushed_at":"2017-09-27T21:25:44Z","git_url":"git://github.com/nolanmar511/pprof.git","ssh_url":"[email protected]:nolanmar511/pprof.git","clone_url":"https://github.com/nolanmar511/pprof.git","svn_url":"https://github.com/nolanmar511/pprof","homepage":"","size":1046,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"f0300aaaf05b5fe9bec4a79ff111f9578c03e533","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":50629145,"name":"pprof","full_name":"google/pprof","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/pprof","description":"pprof is a tool for visualization and analysis of profiling data","fork":false,"url":"https://api.github.com/repos/google/pprof","forks_url":"https://api.github.com/repos/google/pprof/forks","keys_url":"https://api.github.com/repos/google/pprof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/pprof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/pprof/teams","hooks_url":"https://api.github.com/repos/google/pprof/hooks","issue_events_url":"https://api.github.com/repos/google/pprof/issues/events{/number}","events_url":"https://api.github.com/repos/google/pprof/events","assignees_url":"https://api.github.com/repos/google/pprof/assignees{/user}","branches_url":"https://api.github.com/repos/google/pprof/branches{/branch}","tags_url":"https://api.github.com/repos/google/pprof/tags","blobs_url":"https://api.github.com/repos/google/pprof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/pprof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/pprof/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/pprof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/pprof/statuses/{sha}","languages_url":"https://api.github.com/repos/google/pprof/languages","stargazers_url":"https://api.github.com/repos/google/pprof/stargazers","contributors_url":"https://api.github.com/repos/google/pprof/contributors","subscribers_url":"https://api.github.com/repos/google/pprof/subscribers","subscription_url":"https://api.github.com/repos/google/pprof/subscription","commits_url":"https://api.github.com/repos/google/pprof/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/pprof/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/pprof/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/pprof/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/pprof/contents/{+path}","compare_url":"https://api.github.com/repos/google/pprof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/pprof/merges","archive_url":"https://api.github.com/repos/google/pprof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/pprof/downloads","issues_url":"https://api.github.com/repos/google/pprof/issues{/number}","pulls_url":"https://api.github.com/repos/google/pprof/pulls{/number}","milestones_url":"https://api.github.com/repos/google/pprof/milestones{/number}","notifications_url":"https://api.github.com/repos/google/pprof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/pprof/labels{/name}","releases_url":"https://api.github.com/repos/google/pprof/releases{/id}","deployments_url":"https://api.github.com/repos/google/pprof/deployments","created_at":"2016-01-29T01:52:07Z","updated_at":"2017-09-27T11:09:43Z","pushed_at":"2017-09-27T21:25:46Z","git_url":"git://github.com/google/pprof.git","ssh_url":"[email protected]:google/pprof.git","clone_url":"https://github.com/google/pprof.git","svn_url":"https://github.com/google/pprof","homepage":"","size":702,"stargazers_count":813,"watchers_count":813,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":96,"mirror_url":null,"open_issues_count":14,"forks":96,"open_issues":14,"watchers":813,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/pprof/pulls/213"},"html":{"href":"https://github.com/google/pprof/pull/213"},"issue":{"href":"https://api.github.com/repos/google/pprof/issues/213"},"comments":{"href":"https://api.github.com/repos/google/pprof/issues/213/comments"},"review_comments":{"href":"https://api.github.com/repos/google/pprof/pulls/213/comments"},"review_comment":{"href":"https://api.github.com/repos/google/pprof/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/pprof/pulls/213/commits"},"statuses":{"href":"https://api.github.com/repos/google/pprof/statuses/3417c3c5726cf4d164d4661e5a9545488d28534c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 50629145,
"name": "google/pprof",
"url": "https://api.github.com/repos/google/pprof"
} | {
"id": 1519040,
"login": "aalexand",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1519040?",
"url": "https://api.github.com/users/aalexand"
} | {
"id": 1342004,
"login": "google",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1342004?",
"url": "https://api.github.com/orgs/google"
} | 2017-09-28T00:10:30 | 6646884040 | {"actor":{"display_login":"aalexand"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/gradle/gradle/pulls/comments/106060400","pull_request_review_id":26966348,"id":106060400,"diff_hunk":"@@ -6,7 +6,8 @@\n - [ ] [Review Contribution Guidelines](https://github.com/gradle/gradle/blob/master/.github/CONTRIBUTING.md)\n - [ ] [Sign Gradle CLA](http://gradle.org/contributor-license-agreement/)\n - [ ] [Link to Design Spec](https://github.com/gradle/gradle/tree/master/design-docs) for changes that affect more than 1 public API (that is, not in an `internal` package) or updates to > 20 files\n-- [ ] Integration tests (under `<subproject>/src/integTest`) to verify changes from a user perspective. Unit tests (under `<subproject>/src/test`) to verify logic\n+- [ ] Provide integration tests (under `<subproject>/src/integTest`) to verify changes from a user perspective. ","path":".github/PULL_REQUEST_TEMPLATE.md","position":null,"original_position":5,"commit_id":"e43ea29327dda13d2aaf46c782c43efc2e0be4a1","original_commit_id":"e43ea29327dda13d2aaf46c782c43efc2e0be4a1","user":{"login":"bmuschko","id":440872,"avatar_url":"https://avatars1.githubusercontent.com/u/440872?v=3","gravatar_id":"","url":"https://api.github.com/users/bmuschko","html_url":"https://github.com/bmuschko","followers_url":"https://api.github.com/users/bmuschko/followers","following_url":"https://api.github.com/users/bmuschko/following{/other_user}","gists_url":"https://api.github.com/users/bmuschko/gists{/gist_id}","starred_url":"https://api.github.com/users/bmuschko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmuschko/subscriptions","organizations_url":"https://api.github.com/users/bmuschko/orgs","repos_url":"https://api.github.com/users/bmuschko/repos","events_url":"https://api.github.com/users/bmuschko/events{/privacy}","received_events_url":"https://api.github.com/users/bmuschko/received_events","type":"User","site_admin":false},"body":"Minor nitpick. This sentence has a dot at the end whereas other sentences don't have it. We should standardize.","created_at":"2017-03-15T00:22:19Z","updated_at":"2017-03-15T00:22:23Z","html_url":"https://github.com/gradle/gradle/pull/1291#discussion_r106060400","pull_request_url":"https://api.github.com/repos/gradle/gradle/pulls/1291","_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments/106060400"},"html":{"href":"https://github.com/gradle/gradle/pull/1291#discussion_r106060400"},"pull_request":{"href":"https://api.github.com/repos/gradle/gradle/pulls/1291"}}},"pull_request":{"url":"https://api.github.com/repos/gradle/gradle/pulls/1291","id":104201198,"html_url":"https://github.com/gradle/gradle/pull/1291","diff_url":"https://github.com/gradle/gradle/pull/1291.diff","patch_url":"https://github.com/gradle/gradle/pull/1291.patch","issue_url":"https://api.github.com/repos/gradle/gradle/issues/1291","number":1291,"state":"open","locked":false,"title":"Reform PR template, adding a Context section and Member Checklist","user":{"login":"eriwen","id":51534,"avatar_url":"https://avatars1.githubusercontent.com/u/51534?v=3","gravatar_id":"","url":"https://api.github.com/users/eriwen","html_url":"https://github.com/eriwen","followers_url":"https://api.github.com/users/eriwen/followers","following_url":"https://api.github.com/users/eriwen/following{/other_user}","gists_url":"https://api.github.com/users/eriwen/gists{/gist_id}","starred_url":"https://api.github.com/users/eriwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eriwen/subscriptions","organizations_url":"https://api.github.com/users/eriwen/orgs","repos_url":"https://api.github.com/users/eriwen/repos","events_url":"https://api.github.com/users/eriwen/events{/privacy}","received_events_url":"https://api.github.com/users/eriwen/received_events","type":"User","site_admin":false},"body":"## Context\r\n<!--- Why do you believe many users will benefit from this change? -->\r\n<!--- Link to relevant issues or forum discussions here -->\r\n\r\n#### Contributor Checklist\r\n- [ ] [Review Contribution Guidelines](https://github.com/gradle/gradle/blob/master/.github/CONTRIBUTING.md)\r\n- [ ] [Sign Gradle CLA](http://gradle.org/contributor-license-agreement/)\r\n- [ ] [Link to Design Spec](https://github.com/gradle/gradle/tree/master/design-docs) for changes that affect more than 1 public API (that is, not in an `internal` package) or updates to > 20 files\r\n- [ ] Integration tests (under `<subproject>/src/integTest`) to verify changes from a user perspective. Unit tests (under `<subproject>/src/test`) to verify logic\r\n- [ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes\r\n- [ ] Ensure that tests pass locally: `./gradlew quickCheck <impacted-subproject>:check`\r\n\r\n#### Gradle Core Team Checklist\r\n- [ ] Verify design and implementation \r\n- [ ] Verify test coverage and CI build status\r\n- [ ] Verify documentation including proper use of `@since` and `@Incubating` annotations for public APIs\r\n- [ ] Recognize contributor in release notes\r\n","created_at":"2017-02-01T19:13:00Z","updated_at":"2017-03-15T00:22:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b280902be31c23a82c063704e926985ce6712a5","assignee":{"login":"eriwen","id":51534,"avatar_url":"https://avatars1.githubusercontent.com/u/51534?v=3","gravatar_id":"","url":"https://api.github.com/users/eriwen","html_url":"https://github.com/eriwen","followers_url":"https://api.github.com/users/eriwen/followers","following_url":"https://api.github.com/users/eriwen/following{/other_user}","gists_url":"https://api.github.com/users/eriwen/gists{/gist_id}","starred_url":"https://api.github.com/users/eriwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eriwen/subscriptions","organizations_url":"https://api.github.com/users/eriwen/orgs","repos_url":"https://api.github.com/users/eriwen/repos","events_url":"https://api.github.com/users/eriwen/events{/privacy}","received_events_url":"https://api.github.com/users/eriwen/received_events","type":"User","site_admin":false},"assignees":[{"login":"eriwen","id":51534,"avatar_url":"https://avatars1.githubusercontent.com/u/51534?v=3","gravatar_id":"","url":"https://api.github.com/users/eriwen","html_url":"https://github.com/eriwen","followers_url":"https://api.github.com/users/eriwen/followers","following_url":"https://api.github.com/users/eriwen/following{/other_user}","gists_url":"https://api.github.com/users/eriwen/gists{/gist_id}","starred_url":"https://api.github.com/users/eriwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eriwen/subscriptions","organizations_url":"https://api.github.com/users/eriwen/orgs","repos_url":"https://api.github.com/users/eriwen/repos","events_url":"https://api.github.com/users/eriwen/events{/privacy}","received_events_url":"https://api.github.com/users/eriwen/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/gradle/gradle/pulls/1291/commits","review_comments_url":"https://api.github.com/repos/gradle/gradle/pulls/1291/comments","review_comment_url":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gradle/gradle/issues/1291/comments","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/e43ea29327dda13d2aaf46c782c43efc2e0be4a1","head":{"label":"gradle:ew-updated-pr-template","ref":"ew-updated-pr-template","sha":"e43ea29327dda13d2aaf46c782c43efc2e0be4a1","user":{"login":"gradle","id":124156,"avatar_url":"https://avatars1.githubusercontent.com/u/124156?v=3","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"name":"gradle","full_name":"gradle/gradle","owner":{"login":"gradle","id":124156,"avatar_url":"https://avatars1.githubusercontent.com/u/124156?v=3","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gradle/gradle","description":"Adaptable, fast automation for all","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2017-03-14T14:41:23Z","pushed_at":"2017-03-14T21:53:50Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"[email protected]:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"https://gradle.org","size":159688,"stargazers_count":4580,"watchers_count":4580,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1681,"mirror_url":null,"open_issues_count":462,"forks":1681,"open_issues":462,"watchers":4580,"default_branch":"master"}},"base":{"label":"gradle:master","ref":"master","sha":"3baa99b6a55ad6dd7a61bdb84f8531f1584c313a","user":{"login":"gradle","id":124156,"avatar_url":"https://avatars1.githubusercontent.com/u/124156?v=3","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"name":"gradle","full_name":"gradle/gradle","owner":{"login":"gradle","id":124156,"avatar_url":"https://avatars1.githubusercontent.com/u/124156?v=3","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gradle/gradle","description":"Adaptable, fast automation for all","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2017-03-14T14:41:23Z","pushed_at":"2017-03-14T21:53:50Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"[email protected]:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"https://gradle.org","size":159688,"stargazers_count":4580,"watchers_count":4580,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1681,"mirror_url":null,"open_issues_count":462,"forks":1681,"open_issues":462,"watchers":4580,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/1291"},"html":{"href":"https://github.com/gradle/gradle/pull/1291"},"issue":{"href":"https://api.github.com/repos/gradle/gradle/issues/1291"},"comments":{"href":"https://api.github.com/repos/gradle/gradle/issues/1291/comments"},"review_comments":{"href":"https://api.github.com/repos/gradle/gradle/pulls/1291/comments"},"review_comment":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gradle/gradle/pulls/1291/commits"},"statuses":{"href":"https://api.github.com/repos/gradle/gradle/statuses/e43ea29327dda13d2aaf46c782c43efc2e0be4a1"}}}} | {
"id": 302322,
"name": "gradle/gradle",
"url": "https://api.github.com/repos/gradle/gradle"
} | {
"id": 440872,
"login": "bmuschko",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/440872?",
"url": "https://api.github.com/users/bmuschko"
} | {
"id": 124156,
"login": "gradle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/124156?",
"url": "https://api.github.com/orgs/gradle"
} | 2017-03-15T00:22:19 | 5494594328 | {"actor":{"display_login":"bmuschko"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/helium/api-examples/pulls/comments/100366654","pull_request_review_id":21071967,"id":100366654,"diff_hunk":"@@ -0,0 +1,128 @@\n+-- Development board on-board lps22hb sensor script\n+\n+i2c = he.i2c\n+\n+SAMPLE_INTERVAL = 5000 -- 1 minute\n+\n+lps22hb = {\n+ DEFAULT_ADDRESS = 0x5C,\n+ ID = 0x8F,\n+\n+ CTRL_REG2 = 0x11,\n+ CTRL_REG2_ONESHOT = 0x11,\n+\n+ PRESS_OUT_XL = 0x28,\n+ TEMP_OUT_L = 0xAB\n+}\n+\n+\n+function lps22hb:new(address)\n+ address = address or lps22hb.DEFAULT_ADDRESS\n+ local o = { address = address }\n+ setmetatable(o, self)\n+ self.__index = self\n+ -- Check that the sensor is connected\n+ status, reason = o:is_connected()\n+ if not status then\n+ return status, reason\n+ end\n+ return o\n+end\n+\n+\n+function lps22hb:is_connected()\n+ local status, result = self:_get(self.ID, \"B\")\n+ if not (status and result == 0xB1) then\n+ return false, \"could not locate device\"\n+ end\n+ return true\n+end\n+\n+\n+function lps22hb:read_temperature()\n+ return self:_oneshot_read(self._temp_get)\n+end\n+\n+\n+function lps22hb:read_pressure()\n+ return self:_oneshot_read(self._pressure_get)\n+end\n+\n+\n+function lps22hb:_get(reg, pack_fmt, convert)\n+ -- number of bytes to read based on the pack string\n+ local pack_size = string.packsize(pack_fmt)\n+ local status, buffer = i2c.txn(i2c.tx(self.address, reg),\n+ i2c.rx(self.address, pack_size))\n+ if not status then\n+ return false, \"failed to get value from device\"\n+ end\n+ -- get the values and capture them in a list\n+ values = {string.unpack(pack_fmt, buffer)}\n+ -- call conversion function if given\n+ if convert then\n+ values = {convert(table.unpack(values))}\n+ end\n+ -- return the values as an unpacked tuple\n+ return true, table.unpack(values)\n+end\n+\n+\n+function lps22hb:_pressure_get()\n+ local status, result = self:_get(self.PRESS_OUT_XL, \"i3\")","path":"script/lps22hb/lps22hb.lua","position":72,"original_position":72,"commit_id":"cced515bbcae992797e0b4cf29f45f01984e82f8","original_commit_id":"cced515bbcae992797e0b4cf29f45f01984e82f8","user":{"login":"Vagabond","id":86412,"avatar_url":"https://avatars.githubusercontent.com/u/86412?v=3","gravatar_id":"","url":"https://api.github.com/users/Vagabond","html_url":"https://github.com/Vagabond","followers_url":"https://api.github.com/users/Vagabond/followers","following_url":"https://api.github.com/users/Vagabond/following{/other_user}","gists_url":"https://api.github.com/users/Vagabond/gists{/gist_id}","starred_url":"https://api.github.com/users/Vagabond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vagabond/subscriptions","organizations_url":"https://api.github.com/users/Vagabond/orgs","repos_url":"https://api.github.com/users/Vagabond/repos","events_url":"https://api.github.com/users/Vagabond/events{/privacy}","received_events_url":"https://api.github.com/users/Vagabond/received_events","type":"User","site_admin":false},"body":"Should we consistently use the endianness marker?","created_at":"2017-02-09T17:47:24Z","updated_at":"2017-02-09T17:52:31Z","html_url":"https://github.com/helium/api-examples/pull/7#discussion_r100366654","pull_request_url":"https://api.github.com/repos/helium/api-examples/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/helium/api-examples/pulls/comments/100366654"},"html":{"href":"https://github.com/helium/api-examples/pull/7#discussion_r100366654"},"pull_request":{"href":"https://api.github.com/repos/helium/api-examples/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/helium/api-examples/pulls/7","id":105476903,"html_url":"https://github.com/helium/api-examples/pull/7","diff_url":"https://github.com/helium/api-examples/pull/7.diff","patch_url":"https://github.com/helium/api-examples/pull/7.patch","issue_url":"https://api.github.com/repos/helium/api-examples/issues/7","number":7,"state":"open","locked":false,"title":"Add lps22hb dev-board sensor","user":{"login":"madninja","id":11398,"avatar_url":"https://avatars.githubusercontent.com/u/11398?v=3","gravatar_id":"","url":"https://api.github.com/users/madninja","html_url":"https://github.com/madninja","followers_url":"https://api.github.com/users/madninja/followers","following_url":"https://api.github.com/users/madninja/following{/other_user}","gists_url":"https://api.github.com/users/madninja/gists{/gist_id}","starred_url":"https://api.github.com/users/madninja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madninja/subscriptions","organizations_url":"https://api.github.com/users/madninja/orgs","repos_url":"https://api.github.com/users/madninja/repos","events_url":"https://api.github.com/users/madninja/events{/privacy}","received_events_url":"https://api.github.com/users/madninja/received_events","type":"User","site_admin":false},"body":"Adds the lps22hb lua library and datasheet","created_at":"2017-02-09T17:38:15Z","updated_at":"2017-02-09T17:52:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8893bd91862bca1986c611e5fa11ee9ecfb903de","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/helium/api-examples/pulls/7/commits","review_comments_url":"https://api.github.com/repos/helium/api-examples/pulls/7/comments","review_comment_url":"https://api.github.com/repos/helium/api-examples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helium/api-examples/issues/7/comments","statuses_url":"https://api.github.com/repos/helium/api-examples/statuses/cced515bbcae992797e0b4cf29f45f01984e82f8","head":{"label":"helium:feature/lps22hb","ref":"feature/lps22hb","sha":"cced515bbcae992797e0b4cf29f45f01984e82f8","user":{"login":"helium","id":6635330,"avatar_url":"https://avatars.githubusercontent.com/u/6635330?v=3","gravatar_id":"","url":"https://api.github.com/users/helium","html_url":"https://github.com/helium","followers_url":"https://api.github.com/users/helium/followers","following_url":"https://api.github.com/users/helium/following{/other_user}","gists_url":"https://api.github.com/users/helium/gists{/gist_id}","starred_url":"https://api.github.com/users/helium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helium/subscriptions","organizations_url":"https://api.github.com/users/helium/orgs","repos_url":"https://api.github.com/users/helium/repos","events_url":"https://api.github.com/users/helium/events{/privacy}","received_events_url":"https://api.github.com/users/helium/received_events","type":"Organization","site_admin":false},"repo":{"id":56354277,"name":"api-examples","full_name":"helium/api-examples","owner":{"login":"helium","id":6635330,"avatar_url":"https://avatars.githubusercontent.com/u/6635330?v=3","gravatar_id":"","url":"https://api.github.com/users/helium","html_url":"https://github.com/helium","followers_url":"https://api.github.com/users/helium/followers","following_url":"https://api.github.com/users/helium/following{/other_user}","gists_url":"https://api.github.com/users/helium/gists{/gist_id}","starred_url":"https://api.github.com/users/helium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helium/subscriptions","organizations_url":"https://api.github.com/users/helium/orgs","repos_url":"https://api.github.com/users/helium/repos","events_url":"https://api.github.com/users/helium/events{/privacy}","received_events_url":"https://api.github.com/users/helium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/helium/api-examples","description":"Sample apps and services for the Helium API","fork":false,"url":"https://api.github.com/repos/helium/api-examples","forks_url":"https://api.github.com/repos/helium/api-examples/forks","keys_url":"https://api.github.com/repos/helium/api-examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helium/api-examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helium/api-examples/teams","hooks_url":"https://api.github.com/repos/helium/api-examples/hooks","issue_events_url":"https://api.github.com/repos/helium/api-examples/issues/events{/number}","events_url":"https://api.github.com/repos/helium/api-examples/events","assignees_url":"https://api.github.com/repos/helium/api-examples/assignees{/user}","branches_url":"https://api.github.com/repos/helium/api-examples/branches{/branch}","tags_url":"https://api.github.com/repos/helium/api-examples/tags","blobs_url":"https://api.github.com/repos/helium/api-examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helium/api-examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helium/api-examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/helium/api-examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helium/api-examples/statuses/{sha}","languages_url":"https://api.github.com/repos/helium/api-examples/languages","stargazers_url":"https://api.github.com/repos/helium/api-examples/stargazers","contributors_url":"https://api.github.com/repos/helium/api-examples/contributors","subscribers_url":"https://api.github.com/repos/helium/api-examples/subscribers","subscription_url":"https://api.github.com/repos/helium/api-examples/subscription","commits_url":"https://api.github.com/repos/helium/api-examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/helium/api-examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/helium/api-examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/helium/api-examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/helium/api-examples/contents/{+path}","compare_url":"https://api.github.com/repos/helium/api-examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helium/api-examples/merges","archive_url":"https://api.github.com/repos/helium/api-examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helium/api-examples/downloads","issues_url":"https://api.github.com/repos/helium/api-examples/issues{/number}","pulls_url":"https://api.github.com/repos/helium/api-examples/pulls{/number}","milestones_url":"https://api.github.com/repos/helium/api-examples/milestones{/number}","notifications_url":"https://api.github.com/repos/helium/api-examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helium/api-examples/labels{/name}","releases_url":"https://api.github.com/repos/helium/api-examples/releases{/id}","deployments_url":"https://api.github.com/repos/helium/api-examples/deployments","created_at":"2016-04-15T22:54:59Z","updated_at":"2017-02-03T22:32:51Z","pushed_at":"2017-02-09T17:38:16Z","git_url":"git://github.com/helium/api-examples.git","ssh_url":"[email protected]:helium/api-examples.git","clone_url":"https://github.com/helium/api-examples.git","svn_url":"https://github.com/helium/api-examples","homepage":"https://docs.helium.com","size":1702,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"helium:master","ref":"master","sha":"763631f72a50bcaf25c3239126ec2af99d358fd6","user":{"login":"helium","id":6635330,"avatar_url":"https://avatars.githubusercontent.com/u/6635330?v=3","gravatar_id":"","url":"https://api.github.com/users/helium","html_url":"https://github.com/helium","followers_url":"https://api.github.com/users/helium/followers","following_url":"https://api.github.com/users/helium/following{/other_user}","gists_url":"https://api.github.com/users/helium/gists{/gist_id}","starred_url":"https://api.github.com/users/helium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helium/subscriptions","organizations_url":"https://api.github.com/users/helium/orgs","repos_url":"https://api.github.com/users/helium/repos","events_url":"https://api.github.com/users/helium/events{/privacy}","received_events_url":"https://api.github.com/users/helium/received_events","type":"Organization","site_admin":false},"repo":{"id":56354277,"name":"api-examples","full_name":"helium/api-examples","owner":{"login":"helium","id":6635330,"avatar_url":"https://avatars.githubusercontent.com/u/6635330?v=3","gravatar_id":"","url":"https://api.github.com/users/helium","html_url":"https://github.com/helium","followers_url":"https://api.github.com/users/helium/followers","following_url":"https://api.github.com/users/helium/following{/other_user}","gists_url":"https://api.github.com/users/helium/gists{/gist_id}","starred_url":"https://api.github.com/users/helium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helium/subscriptions","organizations_url":"https://api.github.com/users/helium/orgs","repos_url":"https://api.github.com/users/helium/repos","events_url":"https://api.github.com/users/helium/events{/privacy}","received_events_url":"https://api.github.com/users/helium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/helium/api-examples","description":"Sample apps and services for the Helium API","fork":false,"url":"https://api.github.com/repos/helium/api-examples","forks_url":"https://api.github.com/repos/helium/api-examples/forks","keys_url":"https://api.github.com/repos/helium/api-examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helium/api-examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helium/api-examples/teams","hooks_url":"https://api.github.com/repos/helium/api-examples/hooks","issue_events_url":"https://api.github.com/repos/helium/api-examples/issues/events{/number}","events_url":"https://api.github.com/repos/helium/api-examples/events","assignees_url":"https://api.github.com/repos/helium/api-examples/assignees{/user}","branches_url":"https://api.github.com/repos/helium/api-examples/branches{/branch}","tags_url":"https://api.github.com/repos/helium/api-examples/tags","blobs_url":"https://api.github.com/repos/helium/api-examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helium/api-examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helium/api-examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/helium/api-examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helium/api-examples/statuses/{sha}","languages_url":"https://api.github.com/repos/helium/api-examples/languages","stargazers_url":"https://api.github.com/repos/helium/api-examples/stargazers","contributors_url":"https://api.github.com/repos/helium/api-examples/contributors","subscribers_url":"https://api.github.com/repos/helium/api-examples/subscribers","subscription_url":"https://api.github.com/repos/helium/api-examples/subscription","commits_url":"https://api.github.com/repos/helium/api-examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/helium/api-examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/helium/api-examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/helium/api-examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/helium/api-examples/contents/{+path}","compare_url":"https://api.github.com/repos/helium/api-examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helium/api-examples/merges","archive_url":"https://api.github.com/repos/helium/api-examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helium/api-examples/downloads","issues_url":"https://api.github.com/repos/helium/api-examples/issues{/number}","pulls_url":"https://api.github.com/repos/helium/api-examples/pulls{/number}","milestones_url":"https://api.github.com/repos/helium/api-examples/milestones{/number}","notifications_url":"https://api.github.com/repos/helium/api-examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helium/api-examples/labels{/name}","releases_url":"https://api.github.com/repos/helium/api-examples/releases{/id}","deployments_url":"https://api.github.com/repos/helium/api-examples/deployments","created_at":"2016-04-15T22:54:59Z","updated_at":"2017-02-03T22:32:51Z","pushed_at":"2017-02-09T17:38:16Z","git_url":"git://github.com/helium/api-examples.git","ssh_url":"[email protected]:helium/api-examples.git","clone_url":"https://github.com/helium/api-examples.git","svn_url":"https://github.com/helium/api-examples","homepage":"https://docs.helium.com","size":1702,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helium/api-examples/pulls/7"},"html":{"href":"https://github.com/helium/api-examples/pull/7"},"issue":{"href":"https://api.github.com/repos/helium/api-examples/issues/7"},"comments":{"href":"https://api.github.com/repos/helium/api-examples/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/helium/api-examples/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/helium/api-examples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helium/api-examples/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/helium/api-examples/statuses/cced515bbcae992797e0b4cf29f45f01984e82f8"}}}} | {
"id": 56354277,
"name": "helium/api-examples",
"url": "https://api.github.com/repos/helium/api-examples"
} | {
"id": 86412,
"login": "Vagabond",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/86412?",
"url": "https://api.github.com/users/Vagabond"
} | {
"id": 6635330,
"login": "helium",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6635330?",
"url": "https://api.github.com/orgs/helium"
} | 2017-02-09T17:47:24 | 5297157094 | {"actor":{"display_login":"Vagabond"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/indico/indico/pulls/comments/101731127","pull_request_review_id":22468648,"id":101731127,"diff_hunk":"@@ -244,7 +262,7 @@ def merge_person_info(self, other):\n if existing_event_link is None:\n event_link.person = self\n else:\n- db.session.delete(event_link)\n+ other.event_links.remove(event_link)","path":"indico/modules/events/models/persons.py","position":30,"original_position":30,"commit_id":"26691b3a9053be14f3f73aded949e7d2083ab7b2","original_commit_id":"26691b3a9053be14f3f73aded949e7d2083ab7b2","user":{"login":"pferreir","id":2699,"avatar_url":"https://avatars.githubusercontent.com/u/2699?v=3","gravatar_id":"","url":"https://api.github.com/users/pferreir","html_url":"https://github.com/pferreir","followers_url":"https://api.github.com/users/pferreir/followers","following_url":"https://api.github.com/users/pferreir/following{/other_user}","gists_url":"https://api.github.com/users/pferreir/gists{/gist_id}","starred_url":"https://api.github.com/users/pferreir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pferreir/subscriptions","organizations_url":"https://api.github.com/users/pferreir/orgs","repos_url":"https://api.github.com/users/pferreir/repos","events_url":"https://api.github.com/users/pferreir/events{/privacy}","received_events_url":"https://api.github.com/users/pferreir/received_events","type":"User","site_admin":false},"body":"Yeah. Anyway, what I meant is... what's the advantage of having `EventPersonLink` vis a vis a column in `EventPerson` telling us their role?","created_at":"2017-02-17T10:43:45Z","updated_at":"2017-02-17T10:43:45Z","html_url":"https://github.com/indico/indico/pull/2838#discussion_r101731127","pull_request_url":"https://api.github.com/repos/indico/indico/pulls/2838","_links":{"self":{"href":"https://api.github.com/repos/indico/indico/pulls/comments/101731127"},"html":{"href":"https://github.com/indico/indico/pull/2838#discussion_r101731127"},"pull_request":{"href":"https://api.github.com/repos/indico/indico/pulls/2838"}}},"pull_request":{"url":"https://api.github.com/repos/indico/indico/pulls/2838","id":106567408,"html_url":"https://github.com/indico/indico/pull/2838","diff_url":"https://github.com/indico/indico/pull/2838.diff","patch_url":"https://github.com/indico/indico/pull/2838.patch","issue_url":"https://api.github.com/repos/indico/indico/issues/2838","number":2838,"state":"open","locked":false,"title":"Keep event persons consistent on edit / merge","user":{"login":"ThiefMaster","id":179599,"avatar_url":"https://avatars.githubusercontent.com/u/179599?v=3","gravatar_id":"","url":"https://api.github.com/users/ThiefMaster","html_url":"https://github.com/ThiefMaster","followers_url":"https://api.github.com/users/ThiefMaster/followers","following_url":"https://api.github.com/users/ThiefMaster/following{/other_user}","gists_url":"https://api.github.com/users/ThiefMaster/gists{/gist_id}","starred_url":"https://api.github.com/users/ThiefMaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThiefMaster/subscriptions","organizations_url":"https://api.github.com/users/ThiefMaster/orgs","repos_url":"https://api.github.com/users/ThiefMaster/repos","events_url":"https://api.github.com/users/ThiefMaster/events{/privacy}","received_events_url":"https://api.github.com/users/ThiefMaster/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-16T16:51:16Z","updated_at":"2017-02-17T10:43:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cb279385c4cd5dfc3686240eaf3a8cee6ab1046","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/indico/indico/pulls/2838/commits","review_comments_url":"https://api.github.com/repos/indico/indico/pulls/2838/comments","review_comment_url":"https://api.github.com/repos/indico/indico/pulls/comments{/number}","comments_url":"https://api.github.com/repos/indico/indico/issues/2838/comments","statuses_url":"https://api.github.com/repos/indico/indico/statuses/26691b3a9053be14f3f73aded949e7d2083ab7b2","head":{"label":"ThiefMaster:event-persons-consistency","ref":"event-persons-consistency","sha":"26691b3a9053be14f3f73aded949e7d2083ab7b2","user":{"login":"ThiefMaster","id":179599,"avatar_url":"https://avatars.githubusercontent.com/u/179599?v=3","gravatar_id":"","url":"https://api.github.com/users/ThiefMaster","html_url":"https://github.com/ThiefMaster","followers_url":"https://api.github.com/users/ThiefMaster/followers","following_url":"https://api.github.com/users/ThiefMaster/following{/other_user}","gists_url":"https://api.github.com/users/ThiefMaster/gists{/gist_id}","starred_url":"https://api.github.com/users/ThiefMaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThiefMaster/subscriptions","organizations_url":"https://api.github.com/users/ThiefMaster/orgs","repos_url":"https://api.github.com/users/ThiefMaster/repos","events_url":"https://api.github.com/users/ThiefMaster/events{/privacy}","received_events_url":"https://api.github.com/users/ThiefMaster/received_events","type":"User","site_admin":false},"repo":{"id":10118908,"name":"indico","full_name":"ThiefMaster/indico","owner":{"login":"ThiefMaster","id":179599,"avatar_url":"https://avatars.githubusercontent.com/u/179599?v=3","gravatar_id":"","url":"https://api.github.com/users/ThiefMaster","html_url":"https://github.com/ThiefMaster","followers_url":"https://api.github.com/users/ThiefMaster/followers","following_url":"https://api.github.com/users/ThiefMaster/following{/other_user}","gists_url":"https://api.github.com/users/ThiefMaster/gists{/gist_id}","starred_url":"https://api.github.com/users/ThiefMaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThiefMaster/subscriptions","organizations_url":"https://api.github.com/users/ThiefMaster/orgs","repos_url":"https://api.github.com/users/ThiefMaster/repos","events_url":"https://api.github.com/users/ThiefMaster/events{/privacy}","received_events_url":"https://api.github.com/users/ThiefMaster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ThiefMaster/indico","description":"The Indico Project","fork":true,"url":"https://api.github.com/repos/ThiefMaster/indico","forks_url":"https://api.github.com/repos/ThiefMaster/indico/forks","keys_url":"https://api.github.com/repos/ThiefMaster/indico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThiefMaster/indico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThiefMaster/indico/teams","hooks_url":"https://api.github.com/repos/ThiefMaster/indico/hooks","issue_events_url":"https://api.github.com/repos/ThiefMaster/indico/issues/events{/number}","events_url":"https://api.github.com/repos/ThiefMaster/indico/events","assignees_url":"https://api.github.com/repos/ThiefMaster/indico/assignees{/user}","branches_url":"https://api.github.com/repos/ThiefMaster/indico/branches{/branch}","tags_url":"https://api.github.com/repos/ThiefMaster/indico/tags","blobs_url":"https://api.github.com/repos/ThiefMaster/indico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThiefMaster/indico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThiefMaster/indico/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThiefMaster/indico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThiefMaster/indico/statuses/{sha}","languages_url":"https://api.github.com/repos/ThiefMaster/indico/languages","stargazers_url":"https://api.github.com/repos/ThiefMaster/indico/stargazers","contributors_url":"https://api.github.com/repos/ThiefMaster/indico/contributors","subscribers_url":"https://api.github.com/repos/ThiefMaster/indico/subscribers","subscription_url":"https://api.github.com/repos/ThiefMaster/indico/subscription","commits_url":"https://api.github.com/repos/ThiefMaster/indico/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThiefMaster/indico/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThiefMaster/indico/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThiefMaster/indico/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThiefMaster/indico/contents/{+path}","compare_url":"https://api.github.com/repos/ThiefMaster/indico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThiefMaster/indico/merges","archive_url":"https://api.github.com/repos/ThiefMaster/indico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThiefMaster/indico/downloads","issues_url":"https://api.github.com/repos/ThiefMaster/indico/issues{/number}","pulls_url":"https://api.github.com/repos/ThiefMaster/indico/pulls{/number}","milestones_url":"https://api.github.com/repos/ThiefMaster/indico/milestones{/number}","notifications_url":"https://api.github.com/repos/ThiefMaster/indico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThiefMaster/indico/labels{/name}","releases_url":"https://api.github.com/repos/ThiefMaster/indico/releases{/id}","deployments_url":"https://api.github.com/repos/ThiefMaster/indico/deployments","created_at":"2013-05-17T08:09:24Z","updated_at":"2015-05-07T22:00:13Z","pushed_at":"2017-02-16T17:59:49Z","git_url":"git://github.com/ThiefMaster/indico.git","ssh_url":"[email protected]:ThiefMaster/indico.git","clone_url":"https://github.com/ThiefMaster/indico.git","svn_url":"https://github.com/ThiefMaster/indico","homepage":"http://indico-software.org","size":195424,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"indico:v1.9.9","ref":"v1.9.9","sha":"9c8f557efb2b83f61af640ceb56f466fe7197f08","user":{"login":"indico","id":715236,"avatar_url":"https://avatars.githubusercontent.com/u/715236?v=3","gravatar_id":"","url":"https://api.github.com/users/indico","html_url":"https://github.com/indico","followers_url":"https://api.github.com/users/indico/followers","following_url":"https://api.github.com/users/indico/following{/other_user}","gists_url":"https://api.github.com/users/indico/gists{/gist_id}","starred_url":"https://api.github.com/users/indico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indico/subscriptions","organizations_url":"https://api.github.com/users/indico/orgs","repos_url":"https://api.github.com/users/indico/repos","events_url":"https://api.github.com/users/indico/events{/privacy}","received_events_url":"https://api.github.com/users/indico/received_events","type":"Organization","site_admin":false},"repo":{"id":2113067,"name":"indico","full_name":"indico/indico","owner":{"login":"indico","id":715236,"avatar_url":"https://avatars.githubusercontent.com/u/715236?v=3","gravatar_id":"","url":"https://api.github.com/users/indico","html_url":"https://github.com/indico","followers_url":"https://api.github.com/users/indico/followers","following_url":"https://api.github.com/users/indico/following{/other_user}","gists_url":"https://api.github.com/users/indico/gists{/gist_id}","starred_url":"https://api.github.com/users/indico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indico/subscriptions","organizations_url":"https://api.github.com/users/indico/orgs","repos_url":"https://api.github.com/users/indico/repos","events_url":"https://api.github.com/users/indico/events{/privacy}","received_events_url":"https://api.github.com/users/indico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/indico/indico","description":"Indico - A complete event management system","fork":false,"url":"https://api.github.com/repos/indico/indico","forks_url":"https://api.github.com/repos/indico/indico/forks","keys_url":"https://api.github.com/repos/indico/indico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indico/indico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indico/indico/teams","hooks_url":"https://api.github.com/repos/indico/indico/hooks","issue_events_url":"https://api.github.com/repos/indico/indico/issues/events{/number}","events_url":"https://api.github.com/repos/indico/indico/events","assignees_url":"https://api.github.com/repos/indico/indico/assignees{/user}","branches_url":"https://api.github.com/repos/indico/indico/branches{/branch}","tags_url":"https://api.github.com/repos/indico/indico/tags","blobs_url":"https://api.github.com/repos/indico/indico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indico/indico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indico/indico/git/refs{/sha}","trees_url":"https://api.github.com/repos/indico/indico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indico/indico/statuses/{sha}","languages_url":"https://api.github.com/repos/indico/indico/languages","stargazers_url":"https://api.github.com/repos/indico/indico/stargazers","contributors_url":"https://api.github.com/repos/indico/indico/contributors","subscribers_url":"https://api.github.com/repos/indico/indico/subscribers","subscription_url":"https://api.github.com/repos/indico/indico/subscription","commits_url":"https://api.github.com/repos/indico/indico/commits{/sha}","git_commits_url":"https://api.github.com/repos/indico/indico/git/commits{/sha}","comments_url":"https://api.github.com/repos/indico/indico/comments{/number}","issue_comment_url":"https://api.github.com/repos/indico/indico/issues/comments{/number}","contents_url":"https://api.github.com/repos/indico/indico/contents/{+path}","compare_url":"https://api.github.com/repos/indico/indico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indico/indico/merges","archive_url":"https://api.github.com/repos/indico/indico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indico/indico/downloads","issues_url":"https://api.github.com/repos/indico/indico/issues{/number}","pulls_url":"https://api.github.com/repos/indico/indico/pulls{/number}","milestones_url":"https://api.github.com/repos/indico/indico/milestones{/number}","notifications_url":"https://api.github.com/repos/indico/indico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indico/indico/labels{/name}","releases_url":"https://api.github.com/repos/indico/indico/releases{/id}","deployments_url":"https://api.github.com/repos/indico/indico/deployments","created_at":"2011-07-27T13:56:30Z","updated_at":"2017-02-15T22:10:25Z","pushed_at":"2017-02-16T17:59:50Z","git_url":"git://github.com/indico/indico.git","ssh_url":"[email protected]:indico/indico.git","clone_url":"https://github.com/indico/indico.git","svn_url":"https://github.com/indico/indico","homepage":"http://indico-software.org","size":195844,"stargazers_count":195,"watchers_count":195,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":648,"forks":92,"open_issues":648,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/indico/indico/pulls/2838"},"html":{"href":"https://github.com/indico/indico/pull/2838"},"issue":{"href":"https://api.github.com/repos/indico/indico/issues/2838"},"comments":{"href":"https://api.github.com/repos/indico/indico/issues/2838/comments"},"review_comments":{"href":"https://api.github.com/repos/indico/indico/pulls/2838/comments"},"review_comment":{"href":"https://api.github.com/repos/indico/indico/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/indico/indico/pulls/2838/commits"},"statuses":{"href":"https://api.github.com/repos/indico/indico/statuses/26691b3a9053be14f3f73aded949e7d2083ab7b2"}}}} | {
"id": 2113067,
"name": "indico/indico",
"url": "https://api.github.com/repos/indico/indico"
} | {
"id": 2699,
"login": "pferreir",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2699?",
"url": "https://api.github.com/users/pferreir"
} | {
"id": 715236,
"login": "indico",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/715236?",
"url": "https://api.github.com/orgs/indico"
} | 2017-02-17T10:43:45 | 5343242124 | {"actor":{"display_login":"pferreir"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/indico/indico/pulls/comments/102039376","pull_request_review_id":22782733,"id":102039376,"diff_hunk":"@@ -0,0 +1,38 @@\n+{% macro render_cfp_infoline(event, cfp, show_icon=true, redirect_first=false) %}\n+ {% set can_submit_papers = cfp.is_open %}\n+ <div class=\"infoline announcement\">\n+ {% if show_icon %}\n+ <span class=\"icon icon-file-content\"></span>\n+ {% endif %}\n+ <div class=\"text\">\n+ {%- if can_submit_papers %}\n+ <div class=\"label\">\n+ {%- trans %}The call for papers is open{% endtrans -%}\n+ </div>\n+ <div>\n+ {%- trans %}You can submit a paper for reviewing.{% endtrans -%}\n+ </div>\n+ <div class=\"toolbar right\">\n+ {% if session.user and not redirect_first %}\n+ <a class=\"i-button highlight js-show-paper-form\"\n+ data-title=\"{% trans %}Submit new paper{% endtrans %}\"\n+{# TODO: Link to submit paper #}\n+{# data-href=\"{{ url_for('papers.submit', event) }}\"#}","path":"indico/modules/events/papers/templates/display/_common.html","position":20,"original_position":20,"commit_id":"e66ca2c1c5984b91b97d2a788fac5769e6822512","original_commit_id":"3bd21723d245886862a09215f809825b6d7146ff","user":{"login":"DavidAndreev","id":9071624,"avatar_url":"https://avatars.githubusercontent.com/u/9071624?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidAndreev","html_url":"https://github.com/DavidAndreev","followers_url":"https://api.github.com/users/DavidAndreev/followers","following_url":"https://api.github.com/users/DavidAndreev/following{/other_user}","gists_url":"https://api.github.com/users/DavidAndreev/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidAndreev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidAndreev/subscriptions","organizations_url":"https://api.github.com/users/DavidAndreev/orgs","repos_url":"https://api.github.com/users/DavidAndreev/repos","events_url":"https://api.github.com/users/DavidAndreev/events{/privacy}","received_events_url":"https://api.github.com/users/DavidAndreev/received_events","type":"User","site_admin":false},"body":"Good question, well we do that for abstracts..","created_at":"2017-02-20T15:18:41Z","updated_at":"2017-02-20T15:18:41Z","html_url":"https://github.com/indico/indico/pull/2782#discussion_r102039376","pull_request_url":"https://api.github.com/repos/indico/indico/pulls/2782","_links":{"self":{"href":"https://api.github.com/repos/indico/indico/pulls/comments/102039376"},"html":{"href":"https://github.com/indico/indico/pull/2782#discussion_r102039376"},"pull_request":{"href":"https://api.github.com/repos/indico/indico/pulls/2782"}}},"pull_request":{"url":"https://api.github.com/repos/indico/indico/pulls/2782","id":101240005,"html_url":"https://github.com/indico/indico/pull/2782","diff_url":"https://github.com/indico/indico/pull/2782.diff","patch_url":"https://github.com/indico/indico/pull/2782.patch","issue_url":"https://api.github.com/repos/indico/indico/issues/2782","number":2782,"state":"open","locked":false,"title":"Call for Papers display page","user":{"login":"DavidAndreev","id":9071624,"avatar_url":"https://avatars.githubusercontent.com/u/9071624?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidAndreev","html_url":"https://github.com/DavidAndreev","followers_url":"https://api.github.com/users/DavidAndreev/followers","following_url":"https://api.github.com/users/DavidAndreev/following{/other_user}","gists_url":"https://api.github.com/users/DavidAndreev/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidAndreev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidAndreev/subscriptions","organizations_url":"https://api.github.com/users/DavidAndreev/orgs","repos_url":"https://api.github.com/users/DavidAndreev/repos","events_url":"https://api.github.com/users/DavidAndreev/events{/privacy}","received_events_url":"https://api.github.com/users/DavidAndreev/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-12T11:17:44Z","updated_at":"2017-02-20T15:18:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46b4e52487e800e5cfdaf978390064216357cda4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/indico/indico/pulls/2782/commits","review_comments_url":"https://api.github.com/repos/indico/indico/pulls/2782/comments","review_comment_url":"https://api.github.com/repos/indico/indico/pulls/comments{/number}","comments_url":"https://api.github.com/repos/indico/indico/issues/2782/comments","statuses_url":"https://api.github.com/repos/indico/indico/statuses/e66ca2c1c5984b91b97d2a788fac5769e6822512","head":{"label":"DavidAndreev:call-for-papers-display-page","ref":"call-for-papers-display-page","sha":"e66ca2c1c5984b91b97d2a788fac5769e6822512","user":{"login":"DavidAndreev","id":9071624,"avatar_url":"https://avatars.githubusercontent.com/u/9071624?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidAndreev","html_url":"https://github.com/DavidAndreev","followers_url":"https://api.github.com/users/DavidAndreev/followers","following_url":"https://api.github.com/users/DavidAndreev/following{/other_user}","gists_url":"https://api.github.com/users/DavidAndreev/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidAndreev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidAndreev/subscriptions","organizations_url":"https://api.github.com/users/DavidAndreev/orgs","repos_url":"https://api.github.com/users/DavidAndreev/repos","events_url":"https://api.github.com/users/DavidAndreev/events{/privacy}","received_events_url":"https://api.github.com/users/DavidAndreev/received_events","type":"User","site_admin":false},"repo":{"id":67125805,"name":"indico","full_name":"DavidAndreev/indico","owner":{"login":"DavidAndreev","id":9071624,"avatar_url":"https://avatars.githubusercontent.com/u/9071624?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidAndreev","html_url":"https://github.com/DavidAndreev","followers_url":"https://api.github.com/users/DavidAndreev/followers","following_url":"https://api.github.com/users/DavidAndreev/following{/other_user}","gists_url":"https://api.github.com/users/DavidAndreev/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidAndreev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidAndreev/subscriptions","organizations_url":"https://api.github.com/users/DavidAndreev/orgs","repos_url":"https://api.github.com/users/DavidAndreev/repos","events_url":"https://api.github.com/users/DavidAndreev/events{/privacy}","received_events_url":"https://api.github.com/users/DavidAndreev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DavidAndreev/indico","description":"The Indico Project","fork":true,"url":"https://api.github.com/repos/DavidAndreev/indico","forks_url":"https://api.github.com/repos/DavidAndreev/indico/forks","keys_url":"https://api.github.com/repos/DavidAndreev/indico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DavidAndreev/indico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DavidAndreev/indico/teams","hooks_url":"https://api.github.com/repos/DavidAndreev/indico/hooks","issue_events_url":"https://api.github.com/repos/DavidAndreev/indico/issues/events{/number}","events_url":"https://api.github.com/repos/DavidAndreev/indico/events","assignees_url":"https://api.github.com/repos/DavidAndreev/indico/assignees{/user}","branches_url":"https://api.github.com/repos/DavidAndreev/indico/branches{/branch}","tags_url":"https://api.github.com/repos/DavidAndreev/indico/tags","blobs_url":"https://api.github.com/repos/DavidAndreev/indico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DavidAndreev/indico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DavidAndreev/indico/git/refs{/sha}","trees_url":"https://api.github.com/repos/DavidAndreev/indico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DavidAndreev/indico/statuses/{sha}","languages_url":"https://api.github.com/repos/DavidAndreev/indico/languages","stargazers_url":"https://api.github.com/repos/DavidAndreev/indico/stargazers","contributors_url":"https://api.github.com/repos/DavidAndreev/indico/contributors","subscribers_url":"https://api.github.com/repos/DavidAndreev/indico/subscribers","subscription_url":"https://api.github.com/repos/DavidAndreev/indico/subscription","commits_url":"https://api.github.com/repos/DavidAndreev/indico/commits{/sha}","git_commits_url":"https://api.github.com/repos/DavidAndreev/indico/git/commits{/sha}","comments_url":"https://api.github.com/repos/DavidAndreev/indico/comments{/number}","issue_comment_url":"https://api.github.com/repos/DavidAndreev/indico/issues/comments{/number}","contents_url":"https://api.github.com/repos/DavidAndreev/indico/contents/{+path}","compare_url":"https://api.github.com/repos/DavidAndreev/indico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DavidAndreev/indico/merges","archive_url":"https://api.github.com/repos/DavidAndreev/indico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DavidAndreev/indico/downloads","issues_url":"https://api.github.com/repos/DavidAndreev/indico/issues{/number}","pulls_url":"https://api.github.com/repos/DavidAndreev/indico/pulls{/number}","milestones_url":"https://api.github.com/repos/DavidAndreev/indico/milestones{/number}","notifications_url":"https://api.github.com/repos/DavidAndreev/indico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DavidAndreev/indico/labels{/name}","releases_url":"https://api.github.com/repos/DavidAndreev/indico/releases{/id}","deployments_url":"https://api.github.com/repos/DavidAndreev/indico/deployments","created_at":"2016-09-01T11:34:44Z","updated_at":"2016-09-01T11:34:50Z","pushed_at":"2017-02-20T14:16:47Z","git_url":"git://github.com/DavidAndreev/indico.git","ssh_url":"[email protected]:DavidAndreev/indico.git","clone_url":"https://github.com/DavidAndreev/indico.git","svn_url":"https://github.com/DavidAndreev/indico","homepage":"http://indico-software.org","size":195718,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"indico:devel","ref":"devel","sha":"cd94af1f2b0abe2548d88a2afd7ce72a3289fe7d","user":{"login":"indico","id":715236,"avatar_url":"https://avatars.githubusercontent.com/u/715236?v=3","gravatar_id":"","url":"https://api.github.com/users/indico","html_url":"https://github.com/indico","followers_url":"https://api.github.com/users/indico/followers","following_url":"https://api.github.com/users/indico/following{/other_user}","gists_url":"https://api.github.com/users/indico/gists{/gist_id}","starred_url":"https://api.github.com/users/indico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indico/subscriptions","organizations_url":"https://api.github.com/users/indico/orgs","repos_url":"https://api.github.com/users/indico/repos","events_url":"https://api.github.com/users/indico/events{/privacy}","received_events_url":"https://api.github.com/users/indico/received_events","type":"Organization","site_admin":false},"repo":{"id":2113067,"name":"indico","full_name":"indico/indico","owner":{"login":"indico","id":715236,"avatar_url":"https://avatars.githubusercontent.com/u/715236?v=3","gravatar_id":"","url":"https://api.github.com/users/indico","html_url":"https://github.com/indico","followers_url":"https://api.github.com/users/indico/followers","following_url":"https://api.github.com/users/indico/following{/other_user}","gists_url":"https://api.github.com/users/indico/gists{/gist_id}","starred_url":"https://api.github.com/users/indico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indico/subscriptions","organizations_url":"https://api.github.com/users/indico/orgs","repos_url":"https://api.github.com/users/indico/repos","events_url":"https://api.github.com/users/indico/events{/privacy}","received_events_url":"https://api.github.com/users/indico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/indico/indico","description":"Indico - A complete event management system","fork":false,"url":"https://api.github.com/repos/indico/indico","forks_url":"https://api.github.com/repos/indico/indico/forks","keys_url":"https://api.github.com/repos/indico/indico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indico/indico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indico/indico/teams","hooks_url":"https://api.github.com/repos/indico/indico/hooks","issue_events_url":"https://api.github.com/repos/indico/indico/issues/events{/number}","events_url":"https://api.github.com/repos/indico/indico/events","assignees_url":"https://api.github.com/repos/indico/indico/assignees{/user}","branches_url":"https://api.github.com/repos/indico/indico/branches{/branch}","tags_url":"https://api.github.com/repos/indico/indico/tags","blobs_url":"https://api.github.com/repos/indico/indico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indico/indico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indico/indico/git/refs{/sha}","trees_url":"https://api.github.com/repos/indico/indico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indico/indico/statuses/{sha}","languages_url":"https://api.github.com/repos/indico/indico/languages","stargazers_url":"https://api.github.com/repos/indico/indico/stargazers","contributors_url":"https://api.github.com/repos/indico/indico/contributors","subscribers_url":"https://api.github.com/repos/indico/indico/subscribers","subscription_url":"https://api.github.com/repos/indico/indico/subscription","commits_url":"https://api.github.com/repos/indico/indico/commits{/sha}","git_commits_url":"https://api.github.com/repos/indico/indico/git/commits{/sha}","comments_url":"https://api.github.com/repos/indico/indico/comments{/number}","issue_comment_url":"https://api.github.com/repos/indico/indico/issues/comments{/number}","contents_url":"https://api.github.com/repos/indico/indico/contents/{+path}","compare_url":"https://api.github.com/repos/indico/indico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indico/indico/merges","archive_url":"https://api.github.com/repos/indico/indico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indico/indico/downloads","issues_url":"https://api.github.com/repos/indico/indico/issues{/number}","pulls_url":"https://api.github.com/repos/indico/indico/pulls{/number}","milestones_url":"https://api.github.com/repos/indico/indico/milestones{/number}","notifications_url":"https://api.github.com/repos/indico/indico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indico/indico/labels{/name}","releases_url":"https://api.github.com/repos/indico/indico/releases{/id}","deployments_url":"https://api.github.com/repos/indico/indico/deployments","created_at":"2011-07-27T13:56:30Z","updated_at":"2017-02-15T22:10:25Z","pushed_at":"2017-02-20T15:11:46Z","git_url":"git://github.com/indico/indico.git","ssh_url":"[email protected]:indico/indico.git","clone_url":"https://github.com/indico/indico.git","svn_url":"https://github.com/indico/indico","homepage":"http://indico-software.org","size":195879,"stargazers_count":195,"watchers_count":195,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":647,"forks":92,"open_issues":647,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/indico/indico/pulls/2782"},"html":{"href":"https://github.com/indico/indico/pull/2782"},"issue":{"href":"https://api.github.com/repos/indico/indico/issues/2782"},"comments":{"href":"https://api.github.com/repos/indico/indico/issues/2782/comments"},"review_comments":{"href":"https://api.github.com/repos/indico/indico/pulls/2782/comments"},"review_comment":{"href":"https://api.github.com/repos/indico/indico/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/indico/indico/pulls/2782/commits"},"statuses":{"href":"https://api.github.com/repos/indico/indico/statuses/e66ca2c1c5984b91b97d2a788fac5769e6822512"}}}} | {
"id": 2113067,
"name": "indico/indico",
"url": "https://api.github.com/repos/indico/indico"
} | {
"id": 9071624,
"login": "DavidAndreev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9071624?",
"url": "https://api.github.com/users/DavidAndreev"
} | {
"id": 715236,
"login": "indico",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/715236?",
"url": "https://api.github.com/orgs/indico"
} | 2017-02-20T15:18:41 | 5356296741 | {"actor":{"display_login":"DavidAndreev"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/intuit/wasabi/pulls/comments/119228115","pull_request_review_id":41088721,"id":119228115,"diff_hunk":"@@ -247,7 +247,7 @@ public void setTags(Set<String> tags) {\n if (null != tags)\n this.tags = new TreeSet<>(tags);\n else\n- this.tags = new TreeSet<>();\n+ this.tags = tags;","path":"modules/experiment-objects/src/main/java/com/intuit/wasabi/experimentobjects/NewExperiment.java","position":null,"original_position":5,"commit_id":"246c2a764152b9bed480794d32f34ad2db17c76f","original_commit_id":"f694a896659f1816dc8c2a6c4e5af7c2c62a5b4d","user":{"login":"abhishekjain88","id":2101950,"avatar_url":"https://avatars1.githubusercontent.com/u/2101950?v=3","gravatar_id":"","url":"https://api.github.com/users/abhishekjain88","html_url":"https://github.com/abhishekjain88","followers_url":"https://api.github.com/users/abhishekjain88/followers","following_url":"https://api.github.com/users/abhishekjain88/following{/other_user}","gists_url":"https://api.github.com/users/abhishekjain88/gists{/gist_id}","starred_url":"https://api.github.com/users/abhishekjain88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhishekjain88/subscriptions","organizations_url":"https://api.github.com/users/abhishekjain88/orgs","repos_url":"https://api.github.com/users/abhishekjain88/repos","events_url":"https://api.github.com/users/abhishekjain88/events{/privacy}","received_events_url":"https://api.github.com/users/abhishekjain88/received_events","type":"User","site_admin":false},"body":"@AndreaSuckro Can we make the same change in `PrioritizedExperiment` too?","created_at":"2017-05-30T22:08:10Z","updated_at":"2017-05-30T22:08:10Z","html_url":"https://github.com/intuit/wasabi/pull/233#discussion_r119228115","pull_request_url":"https://api.github.com/repos/intuit/wasabi/pulls/233","_links":{"self":{"href":"https://api.github.com/repos/intuit/wasabi/pulls/comments/119228115"},"html":{"href":"https://github.com/intuit/wasabi/pull/233#discussion_r119228115"},"pull_request":{"href":"https://api.github.com/repos/intuit/wasabi/pulls/233"}}},"pull_request":{"url":"https://api.github.com/repos/intuit/wasabi/pulls/233","id":118200353,"html_url":"https://github.com/intuit/wasabi/pull/233","diff_url":"https://github.com/intuit/wasabi/pull/233.diff","patch_url":"https://github.com/intuit/wasabi/pull/233.patch","issue_url":"https://api.github.com/repos/intuit/wasabi/issues/233","number":233,"state":"open","locked":false,"title":"Feature/experiment tags","user":{"login":"longdogz","id":7725571,"avatar_url":"https://avatars3.githubusercontent.com/u/7725571?v=3","gravatar_id":"","url":"https://api.github.com/users/longdogz","html_url":"https://github.com/longdogz","followers_url":"https://api.github.com/users/longdogz/followers","following_url":"https://api.github.com/users/longdogz/following{/other_user}","gists_url":"https://api.github.com/users/longdogz/gists{/gist_id}","starred_url":"https://api.github.com/users/longdogz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/longdogz/subscriptions","organizations_url":"https://api.github.com/users/longdogz/orgs","repos_url":"https://api.github.com/users/longdogz/repos","events_url":"https://api.github.com/users/longdogz/events{/privacy}","received_events_url":"https://api.github.com/users/longdogz/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-28T17:39:16Z","updated_at":"2017-05-30T22:08:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9c14433834fb0662f899d39c0779615f599248a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/intuit/wasabi/pulls/233/commits","review_comments_url":"https://api.github.com/repos/intuit/wasabi/pulls/233/comments","review_comment_url":"https://api.github.com/repos/intuit/wasabi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intuit/wasabi/issues/233/comments","statuses_url":"https://api.github.com/repos/intuit/wasabi/statuses/246c2a764152b9bed480794d32f34ad2db17c76f","head":{"label":"intuit:feature/experiment-tags","ref":"feature/experiment-tags","sha":"246c2a764152b9bed480794d32f34ad2db17c76f","user":{"login":"intuit","id":2495066,"avatar_url":"https://avatars1.githubusercontent.com/u/2495066?v=3","gravatar_id":"","url":"https://api.github.com/users/intuit","html_url":"https://github.com/intuit","followers_url":"https://api.github.com/users/intuit/followers","following_url":"https://api.github.com/users/intuit/following{/other_user}","gists_url":"https://api.github.com/users/intuit/gists{/gist_id}","starred_url":"https://api.github.com/users/intuit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intuit/subscriptions","organizations_url":"https://api.github.com/users/intuit/orgs","repos_url":"https://api.github.com/users/intuit/repos","events_url":"https://api.github.com/users/intuit/events{/privacy}","received_events_url":"https://api.github.com/users/intuit/received_events","type":"Organization","site_admin":false},"repo":{"id":61667990,"name":"wasabi","full_name":"intuit/wasabi","owner":{"login":"intuit","id":2495066,"avatar_url":"https://avatars1.githubusercontent.com/u/2495066?v=3","gravatar_id":"","url":"https://api.github.com/users/intuit","html_url":"https://github.com/intuit","followers_url":"https://api.github.com/users/intuit/followers","following_url":"https://api.github.com/users/intuit/following{/other_user}","gists_url":"https://api.github.com/users/intuit/gists{/gist_id}","starred_url":"https://api.github.com/users/intuit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intuit/subscriptions","organizations_url":"https://api.github.com/users/intuit/orgs","repos_url":"https://api.github.com/users/intuit/repos","events_url":"https://api.github.com/users/intuit/events{/privacy}","received_events_url":"https://api.github.com/users/intuit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intuit/wasabi","description":"Wasabi A/B Testing Service is a real-time, enterprise-grade, 100% API driven project.","fork":false,"url":"https://api.github.com/repos/intuit/wasabi","forks_url":"https://api.github.com/repos/intuit/wasabi/forks","keys_url":"https://api.github.com/repos/intuit/wasabi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intuit/wasabi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intuit/wasabi/teams","hooks_url":"https://api.github.com/repos/intuit/wasabi/hooks","issue_events_url":"https://api.github.com/repos/intuit/wasabi/issues/events{/number}","events_url":"https://api.github.com/repos/intuit/wasabi/events","assignees_url":"https://api.github.com/repos/intuit/wasabi/assignees{/user}","branches_url":"https://api.github.com/repos/intuit/wasabi/branches{/branch}","tags_url":"https://api.github.com/repos/intuit/wasabi/tags","blobs_url":"https://api.github.com/repos/intuit/wasabi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intuit/wasabi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intuit/wasabi/git/refs{/sha}","trees_url":"https://api.github.com/repos/intuit/wasabi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intuit/wasabi/statuses/{sha}","languages_url":"https://api.github.com/repos/intuit/wasabi/languages","stargazers_url":"https://api.github.com/repos/intuit/wasabi/stargazers","contributors_url":"https://api.github.com/repos/intuit/wasabi/contributors","subscribers_url":"https://api.github.com/repos/intuit/wasabi/subscribers","subscription_url":"https://api.github.com/repos/intuit/wasabi/subscription","commits_url":"https://api.github.com/repos/intuit/wasabi/commits{/sha}","git_commits_url":"https://api.github.com/repos/intuit/wasabi/git/commits{/sha}","comments_url":"https://api.github.com/repos/intuit/wasabi/comments{/number}","issue_comment_url":"https://api.github.com/repos/intuit/wasabi/issues/comments{/number}","contents_url":"https://api.github.com/repos/intuit/wasabi/contents/{+path}","compare_url":"https://api.github.com/repos/intuit/wasabi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intuit/wasabi/merges","archive_url":"https://api.github.com/repos/intuit/wasabi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intuit/wasabi/downloads","issues_url":"https://api.github.com/repos/intuit/wasabi/issues{/number}","pulls_url":"https://api.github.com/repos/intuit/wasabi/pulls{/number}","milestones_url":"https://api.github.com/repos/intuit/wasabi/milestones{/number}","notifications_url":"https://api.github.com/repos/intuit/wasabi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intuit/wasabi/labels{/name}","releases_url":"https://api.github.com/repos/intuit/wasabi/releases{/id}","deployments_url":"https://api.github.com/repos/intuit/wasabi/deployments","created_at":"2016-06-21T21:21:06Z","updated_at":"2017-05-23T18:12:02Z","pushed_at":"2017-05-26T19:27:42Z","git_url":"git://github.com/intuit/wasabi.git","ssh_url":"[email protected]:intuit/wasabi.git","clone_url":"https://github.com/intuit/wasabi.git","svn_url":"https://github.com/intuit/wasabi","homepage":"","size":18689,"stargazers_count":243,"watchers_count":243,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":54,"mirror_url":null,"open_issues_count":49,"forks":54,"open_issues":49,"watchers":243,"default_branch":"develop"}},"base":{"label":"intuit:develop","ref":"develop","sha":"da9a100616a738bd4b32eeebe2c7f3934d5147e6","user":{"login":"intuit","id":2495066,"avatar_url":"https://avatars1.githubusercontent.com/u/2495066?v=3","gravatar_id":"","url":"https://api.github.com/users/intuit","html_url":"https://github.com/intuit","followers_url":"https://api.github.com/users/intuit/followers","following_url":"https://api.github.com/users/intuit/following{/other_user}","gists_url":"https://api.github.com/users/intuit/gists{/gist_id}","starred_url":"https://api.github.com/users/intuit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intuit/subscriptions","organizations_url":"https://api.github.com/users/intuit/orgs","repos_url":"https://api.github.com/users/intuit/repos","events_url":"https://api.github.com/users/intuit/events{/privacy}","received_events_url":"https://api.github.com/users/intuit/received_events","type":"Organization","site_admin":false},"repo":{"id":61667990,"name":"wasabi","full_name":"intuit/wasabi","owner":{"login":"intuit","id":2495066,"avatar_url":"https://avatars1.githubusercontent.com/u/2495066?v=3","gravatar_id":"","url":"https://api.github.com/users/intuit","html_url":"https://github.com/intuit","followers_url":"https://api.github.com/users/intuit/followers","following_url":"https://api.github.com/users/intuit/following{/other_user}","gists_url":"https://api.github.com/users/intuit/gists{/gist_id}","starred_url":"https://api.github.com/users/intuit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intuit/subscriptions","organizations_url":"https://api.github.com/users/intuit/orgs","repos_url":"https://api.github.com/users/intuit/repos","events_url":"https://api.github.com/users/intuit/events{/privacy}","received_events_url":"https://api.github.com/users/intuit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intuit/wasabi","description":"Wasabi A/B Testing Service is a real-time, enterprise-grade, 100% API driven project.","fork":false,"url":"https://api.github.com/repos/intuit/wasabi","forks_url":"https://api.github.com/repos/intuit/wasabi/forks","keys_url":"https://api.github.com/repos/intuit/wasabi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intuit/wasabi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intuit/wasabi/teams","hooks_url":"https://api.github.com/repos/intuit/wasabi/hooks","issue_events_url":"https://api.github.com/repos/intuit/wasabi/issues/events{/number}","events_url":"https://api.github.com/repos/intuit/wasabi/events","assignees_url":"https://api.github.com/repos/intuit/wasabi/assignees{/user}","branches_url":"https://api.github.com/repos/intuit/wasabi/branches{/branch}","tags_url":"https://api.github.com/repos/intuit/wasabi/tags","blobs_url":"https://api.github.com/repos/intuit/wasabi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intuit/wasabi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intuit/wasabi/git/refs{/sha}","trees_url":"https://api.github.com/repos/intuit/wasabi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intuit/wasabi/statuses/{sha}","languages_url":"https://api.github.com/repos/intuit/wasabi/languages","stargazers_url":"https://api.github.com/repos/intuit/wasabi/stargazers","contributors_url":"https://api.github.com/repos/intuit/wasabi/contributors","subscribers_url":"https://api.github.com/repos/intuit/wasabi/subscribers","subscription_url":"https://api.github.com/repos/intuit/wasabi/subscription","commits_url":"https://api.github.com/repos/intuit/wasabi/commits{/sha}","git_commits_url":"https://api.github.com/repos/intuit/wasabi/git/commits{/sha}","comments_url":"https://api.github.com/repos/intuit/wasabi/comments{/number}","issue_comment_url":"https://api.github.com/repos/intuit/wasabi/issues/comments{/number}","contents_url":"https://api.github.com/repos/intuit/wasabi/contents/{+path}","compare_url":"https://api.github.com/repos/intuit/wasabi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intuit/wasabi/merges","archive_url":"https://api.github.com/repos/intuit/wasabi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intuit/wasabi/downloads","issues_url":"https://api.github.com/repos/intuit/wasabi/issues{/number}","pulls_url":"https://api.github.com/repos/intuit/wasabi/pulls{/number}","milestones_url":"https://api.github.com/repos/intuit/wasabi/milestones{/number}","notifications_url":"https://api.github.com/repos/intuit/wasabi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intuit/wasabi/labels{/name}","releases_url":"https://api.github.com/repos/intuit/wasabi/releases{/id}","deployments_url":"https://api.github.com/repos/intuit/wasabi/deployments","created_at":"2016-06-21T21:21:06Z","updated_at":"2017-05-23T18:12:02Z","pushed_at":"2017-05-26T19:27:42Z","git_url":"git://github.com/intuit/wasabi.git","ssh_url":"[email protected]:intuit/wasabi.git","clone_url":"https://github.com/intuit/wasabi.git","svn_url":"https://github.com/intuit/wasabi","homepage":"","size":18689,"stargazers_count":243,"watchers_count":243,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":54,"mirror_url":null,"open_issues_count":49,"forks":54,"open_issues":49,"watchers":243,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/intuit/wasabi/pulls/233"},"html":{"href":"https://github.com/intuit/wasabi/pull/233"},"issue":{"href":"https://api.github.com/repos/intuit/wasabi/issues/233"},"comments":{"href":"https://api.github.com/repos/intuit/wasabi/issues/233/comments"},"review_comments":{"href":"https://api.github.com/repos/intuit/wasabi/pulls/233/comments"},"review_comment":{"href":"https://api.github.com/repos/intuit/wasabi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intuit/wasabi/pulls/233/commits"},"statuses":{"href":"https://api.github.com/repos/intuit/wasabi/statuses/246c2a764152b9bed480794d32f34ad2db17c76f"}}}} | {
"id": 61667990,
"name": "intuit/wasabi",
"url": "https://api.github.com/repos/intuit/wasabi"
} | {
"id": 2101950,
"login": "abhishekjain88",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2101950?",
"url": "https://api.github.com/users/abhishekjain88"
} | {
"id": 2495066,
"login": "intuit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2495066?",
"url": "https://api.github.com/orgs/intuit"
} | 2017-05-30T22:08:10 | 5970242295 | {"actor":{"display_login":"abhishekjain88"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/124772053","pull_request_review_id":47092566,"id":124772053,"diff_hunk":"@@ -31,35 +31,7 @@ class ContentHelper extends \\JHelperContent\n \t */\n \tpublic static function addSubmenu($vName)\n \t{\n-\t\t\\JHtmlSidebar::addEntry(\n-\t\t\t\\JText::_('JGLOBAL_ARTICLES'),\n-\t\t\t'index.php?option=com_content&view=articles',\n-\t\t\t$vName == 'articles'\n-\t\t);\n-\t\t\\JHtmlSidebar::addEntry(\n-\t\t\t\\JText::_('COM_CONTENT_SUBMENU_CATEGORIES'),\n-\t\t\t'index.php?option=com_categories&extension=com_content',\n-\t\t\t$vName == 'categories'\n-\t\t);\n-\t\t\\JHtmlSidebar::addEntry(\n-\t\t\t\\JText::_('COM_CONTENT_SUBMENU_FEATURED'),\n-\t\t\t'index.php?option=com_content&view=featured',\n-\t\t\t$vName == 'featured'\n-\t\t);\n \n-\t\tif (\\JComponentHelper::isEnabled('com_fields') && \\JComponentHelper::getParams('com_content')->get('custom_fields_enable', '1'))","path":"administrator/components/com_content/Helper/ContentHelper.php","position":20,"original_position":20,"commit_id":"428865077e42496d52619243752db3b85883cda8","original_commit_id":"428865077e42496d52619243752db3b85883cda8","user":{"login":"laoneo","id":251072,"avatar_url":"https://avatars0.githubusercontent.com/u/251072?v=3","gravatar_id":"","url":"https://api.github.com/users/laoneo","html_url":"https://github.com/laoneo","followers_url":"https://api.github.com/users/laoneo/followers","following_url":"https://api.github.com/users/laoneo/following{/other_user}","gists_url":"https://api.github.com/users/laoneo/gists{/gist_id}","starred_url":"https://api.github.com/users/laoneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laoneo/subscriptions","organizations_url":"https://api.github.com/users/laoneo/orgs","repos_url":"https://api.github.com/users/laoneo/repos","events_url":"https://api.github.com/users/laoneo/events{/privacy}","received_events_url":"https://api.github.com/users/laoneo/received_events","type":"User","site_admin":false},"body":"How is the menu actually built? Where is this logic now?","created_at":"2017-06-29T11:12:35Z","updated_at":"2017-06-29T11:12:35Z","html_url":"https://github.com/joomla/joomla-cms/pull/16909#discussion_r124772053","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/16909","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/124772053"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/16909#discussion_r124772053"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/16909"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/16909","id":128101378,"html_url":"https://github.com/joomla/joomla-cms/pull/16909","diff_url":"https://github.com/joomla/joomla-cms/pull/16909.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/16909.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/16909","number":16909,"state":"open","locked":false,"title":"[4.0] Extend removal of component sidebar","user":{"login":"ciar4n","id":2803503,"avatar_url":"https://avatars1.githubusercontent.com/u/2803503?v=3","gravatar_id":"","url":"https://api.github.com/users/ciar4n","html_url":"https://github.com/ciar4n","followers_url":"https://api.github.com/users/ciar4n/followers","following_url":"https://api.github.com/users/ciar4n/following{/other_user}","gists_url":"https://api.github.com/users/ciar4n/gists{/gist_id}","starred_url":"https://api.github.com/users/ciar4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciar4n/subscriptions","organizations_url":"https://api.github.com/users/ciar4n/orgs","repos_url":"https://api.github.com/users/ciar4n/repos","events_url":"https://api.github.com/users/ciar4n/events{/privacy}","received_events_url":"https://api.github.com/users/ciar4n/received_events","type":"User","site_admin":false},"body":"Pull Request for Issue # .\r\n\r\n### Summary of Changes\r\nThis PR extends the removal of the component sidebar menu to all components where the component menu matches the main navigation sub menu (see #16386) .\r\n\r\nApplies to the following...\r\n\r\n- com_checkin\r\n- com_cache\r\n- com_cache&view=purge\r\n- com_users&view=users\r\n- com_users&view=groups\r\n- com_users&view=levels\r\n- com_users&view=notes\r\n- com_menus&view=items\r\n- com_banners\r\n- com_banners&view=clients\r\n- com_banners&view=tracks\r\n- com_newsfeeds\r\n- com_installer\r\n- com_installer&view=update\r\n- com_installer&view=manage\r\n- com_installer&view=discover\r\n- com_installer&view=database\r\n- com_installer&view=warnings\r\n- com_installer&view=languages\r\n- com_installer&view=updatesites\r\n- com_templates&view=styles\r\n- com_templates&view=templates\r\n- com_languages&view=installed\r\n- com_languages&view=languages\r\n- com_languages&view=overrides (Removed menu however still sidebar containing filter)\r\n\r\n\r\nExcludes the following... \r\n- com_contact\r\n- com_finder\r\n\r\nComponents excluded contain items in the component menu not present in the main menu. \r\n\r\n### Testing Instructions\r\nApply patch and ensure the sidebar is removed and table is displaying correctly (full width) at each of the following or navigate through all list views ensuring the component menu is removed where applicable (see #16386)....\r\n\r\n/index.php?option=com_checkin\r\n/index.php?option=com_cache\r\n/index.php?option=com_cache&view=purge\r\n/index.php?option=com_users&view=users\r\n/index.php?option=com_users&view=groups\r\n/index.php?option=com_users&view=levels\r\n/index.php?option=com_users&view=notes\r\n/index.php?option=com_menus&view=items\r\n/index.php?option=com_banners\r\n/index.php?option=com_banners&view=clients\r\n/index.php?option=com_banners&view=tracks\r\n/index.php?option=com_newsfeeds\r\n/index.php?option=com_installer\r\n/index.php?option=com_installer&view=update\r\n/index.php?option=com_installer&view=manage\r\n/index.php?option=com_installer&view=discover\r\n/index.php?option=com_installer&view=database\r\n/index.php?option=com_installer&view=warnings\r\n/index.php?option=com_installer&view=languages\r\n/index.php?option=com_installer&view=updatesites\r\n/index.php?option=com_templates&view=styles\r\n/index.php?option=com_templates&view=templates\r\n/index.php?option=com_languages&view=installed\r\n/index.php?option=com_languages&view=languages\r\n/index.php?option=com_languages&view=overrides (Removed menu however still sidebar containing filter)\r\n\r\n### Documentation Changes Required\r\nYes \r\n","created_at":"2017-06-29T09:03:47Z","updated_at":"2017-06-29T11:12:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a85ebc8bf681625e7fa67de56761e36832b605de","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/16909/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/16909/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/16909/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/428865077e42496d52619243752db3b85883cda8","head":{"label":"ciar4n:com-sidebar","ref":"com-sidebar","sha":"428865077e42496d52619243752db3b85883cda8","user":{"login":"ciar4n","id":2803503,"avatar_url":"https://avatars1.githubusercontent.com/u/2803503?v=3","gravatar_id":"","url":"https://api.github.com/users/ciar4n","html_url":"https://github.com/ciar4n","followers_url":"https://api.github.com/users/ciar4n/followers","following_url":"https://api.github.com/users/ciar4n/following{/other_user}","gists_url":"https://api.github.com/users/ciar4n/gists{/gist_id}","starred_url":"https://api.github.com/users/ciar4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciar4n/subscriptions","organizations_url":"https://api.github.com/users/ciar4n/orgs","repos_url":"https://api.github.com/users/ciar4n/repos","events_url":"https://api.github.com/users/ciar4n/events{/privacy}","received_events_url":"https://api.github.com/users/ciar4n/received_events","type":"User","site_admin":false},"repo":{"id":76715573,"name":"joomla-cms","full_name":"ciar4n/joomla-cms","owner":{"login":"ciar4n","id":2803503,"avatar_url":"https://avatars1.githubusercontent.com/u/2803503?v=3","gravatar_id":"","url":"https://api.github.com/users/ciar4n","html_url":"https://github.com/ciar4n","followers_url":"https://api.github.com/users/ciar4n/followers","following_url":"https://api.github.com/users/ciar4n/following{/other_user}","gists_url":"https://api.github.com/users/ciar4n/gists{/gist_id}","starred_url":"https://api.github.com/users/ciar4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciar4n/subscriptions","organizations_url":"https://api.github.com/users/ciar4n/orgs","repos_url":"https://api.github.com/users/ciar4n/repos","events_url":"https://api.github.com/users/ciar4n/events{/privacy}","received_events_url":"https://api.github.com/users/ciar4n/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ciar4n/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/ciar4n/joomla-cms","forks_url":"https://api.github.com/repos/ciar4n/joomla-cms/forks","keys_url":"https://api.github.com/repos/ciar4n/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciar4n/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciar4n/joomla-cms/teams","hooks_url":"https://api.github.com/repos/ciar4n/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/ciar4n/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/ciar4n/joomla-cms/events","assignees_url":"https://api.github.com/repos/ciar4n/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/ciar4n/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/ciar4n/joomla-cms/tags","blobs_url":"https://api.github.com/repos/ciar4n/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciar4n/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciar4n/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciar4n/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciar4n/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/ciar4n/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/ciar4n/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/ciar4n/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/ciar4n/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/ciar4n/joomla-cms/subscription","commits_url":"https://api.github.com/repos/ciar4n/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciar4n/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciar4n/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciar4n/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciar4n/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/ciar4n/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciar4n/joomla-cms/merges","archive_url":"https://api.github.com/repos/ciar4n/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciar4n/joomla-cms/downloads","issues_url":"https://api.github.com/repos/ciar4n/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/ciar4n/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/ciar4n/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/ciar4n/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciar4n/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/ciar4n/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/ciar4n/joomla-cms/deployments","created_at":"2016-12-17T09:36:14Z","updated_at":"2016-12-17T09:36:30Z","pushed_at":"2017-06-29T10:48:25Z","git_url":"git://github.com/ciar4n/joomla-cms.git","ssh_url":"[email protected]:ciar4n/joomla-cms.git","clone_url":"https://github.com/ciar4n/joomla-cms.git","svn_url":"https://github.com/ciar4n/joomla-cms","homepage":"https://www.joomla.org","size":199108,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:4.0-dev","ref":"4.0-dev","sha":"674db8b5bea96ba4d3db732015055875d656d736","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars0.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars0.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2017-06-29T07:24:16Z","pushed_at":"2017-06-29T10:59:21Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"[email protected]:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":198592,"stargazers_count":2411,"watchers_count":2411,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2502,"mirror_url":null,"open_issues_count":812,"forks":2502,"open_issues":812,"watchers":2411,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/16909"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/16909"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/16909"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/16909/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/16909/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/16909/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/428865077e42496d52619243752db3b85883cda8"}}}} | {
"id": 2464908,
"name": "joomla/joomla-cms",
"url": "https://api.github.com/repos/joomla/joomla-cms"
} | {
"id": 251072,
"login": "laoneo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/251072?",
"url": "https://api.github.com/users/laoneo"
} | {
"id": 751633,
"login": "joomla",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/751633?",
"url": "https://api.github.com/orgs/joomla"
} | 2017-06-29T11:12:35 | 6162398366 | {"actor":{"display_login":"laoneo"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/122573150","pull_request_review_id":44704535,"id":122573150,"diff_hunk":"@@ -73,8 +77,21 @@\n JHtml::_('jquery.framework');\n JHtml::_('script', 'system/html5fallback.js', array('version' => 'auto', 'relative' => true));\n JHtml::_('script', 'jui/jquery.minicolors.min.js', array('version' => 'auto', 'relative' => true));\n-JHtml::_('stylesheet', 'jui/jquery.minicolors.css', array('version' => 'auto', 'relative' => true));\n+JHtml::_('stylesheet', 'jui/jquery.minicolors.min.css', array('version' => 'auto', 'relative' => true));\n+JHtml::_('stylesheet', 'system/fields/color.min.css', array('version' => 'auto', 'relative' => true));\n JHtml::_('script', 'system/color-field-adv-init.min.js', array('version' => 'auto', 'relative' => true));\n ?>\n-<input type=\"text\" name=\"<?php echo $name; ?>\" id=\"<?php echo $id; ?>\" value=\"<?php echo htmlspecialchars($color, ENT_COMPAT, 'UTF-8'); ?>\" <?php\n-echo $hint . $class . $position . $control . $readonly . $disabled . $required . $onchange . $autocomplete . $autofocus . $format . $keywords . $direction . $validate; ?>/>\n+<div class=\"color-picker-group\">\n+\t<input type=\"text\" name=\"<?php echo $name; ?>\" id=\"<?php echo $id; ?>\" value=\"<?php\n+\techo htmlspecialchars($color, ENT_COMPAT, 'UTF-8'); ?>\"<?php echo $hint . $class .\n+\t$position . $control . $readonly . $disabled .\n+\t$required . $onchange . $autocomplete . $autofocus .\n+\t$dataformat . $keywords . $direction . $validate; ?>/>\n+\t<?php if ($changeFormat) : ?>\n+\t\t<div class=\"color-format-group\">\n+\t\t\t<button class=\"color-format-btn <?php echo ($format == 'hex' ? 'active' : ''); ?>\" type=\"button\" data-format=\"hex\">HEX</button>","path":"layouts/joomla/form/field/color/advanced.php","position":56,"original_position":56,"commit_id":"cc572e1f52b1b51a9fedc669b1a2a5f7e683015d","original_commit_id":"cc572e1f52b1b51a9fedc669b1a2a5f7e683015d","user":{"login":"jjaracz","id":8504663,"avatar_url":"https://avatars0.githubusercontent.com/u/8504663?v=3","gravatar_id":"","url":"https://api.github.com/users/jjaracz","html_url":"https://github.com/jjaracz","followers_url":"https://api.github.com/users/jjaracz/followers","following_url":"https://api.github.com/users/jjaracz/following{/other_user}","gists_url":"https://api.github.com/users/jjaracz/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaracz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaracz/subscriptions","organizations_url":"https://api.github.com/users/jjaracz/orgs","repos_url":"https://api.github.com/users/jjaracz/repos","events_url":"https://api.github.com/users/jjaracz/events{/privacy}","received_events_url":"https://api.github.com/users/jjaracz/received_events","type":"User","site_admin":false},"body":"@Quy\r\n@laoneo \r\nDo you know what name has language file for that path? I couldn't find :/","created_at":"2017-06-17T17:28:26Z","updated_at":"2017-06-17T17:28:26Z","html_url":"https://github.com/joomla/joomla-cms/pull/14427#discussion_r122573150","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/14427","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/122573150"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/14427#discussion_r122573150"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/14427"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/14427","id":109827462,"html_url":"https://github.com/joomla/joomla-cms/pull/14427","diff_url":"https://github.com/joomla/joomla-cms/pull/14427.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/14427.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/14427","number":14427,"state":"open","locked":false,"title":"Extend the color picker to change between hex, rgb, rgba","user":{"login":"jjaracz","id":8504663,"avatar_url":"https://avatars0.githubusercontent.com/u/8504663?v=3","gravatar_id":"","url":"https://api.github.com/users/jjaracz","html_url":"https://github.com/jjaracz","followers_url":"https://api.github.com/users/jjaracz/followers","following_url":"https://api.github.com/users/jjaracz/following{/other_user}","gists_url":"https://api.github.com/users/jjaracz/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaracz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaracz/subscriptions","organizations_url":"https://api.github.com/users/jjaracz/orgs","repos_url":"https://api.github.com/users/jjaracz/repos","events_url":"https://api.github.com/users/jjaracz/events{/privacy}","received_events_url":"https://api.github.com/users/jjaracz/received_events","type":"User","site_admin":false},"body":"Pull Request for Issue #14353 .\r\n\r\n### Summary of Changes\r\n\r\nAdds buttons to change between hex, rgb, rgba.\r\n\r\n### Testing Instructions\r\n\r\nAdd to protostar templateDetails.xml in field of type colors attribute `changeformat=\"true\"` and go to settings of that template and then to the advanced tab. There should be new extended color picker.\r\n\r\nWhen you want to set format, just type for example `format=\"rgb\"`\r\nWhen you want to set keywords that will be injected to html just type for example `keywords=\"transparent,inherit,initial\"`\r\n\r\n### Documentation Changes Required\r\n\r\nYes on the page [https://docs.joomla.org/Color_form_field_type](https://docs.joomla.org/Color_form_field_type)\r\n\r\n- boolean attribute `changeformat=\"\"` is to show buttons to change format between hex, rgb, rgba.\r\n- format and keywords attribute from #10129\r\n\r\n\r\n","created_at":"2017-03-09T02:20:12Z","updated_at":"2017-06-17T17:28:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c096f71c52876a0b99a49acaf1079e8811c9b34","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/14427/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/14427/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/14427/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/cc572e1f52b1b51a9fedc669b1a2a5f7e683015d","head":{"label":"jjaracz:staging","ref":"staging","sha":"cc572e1f52b1b51a9fedc669b1a2a5f7e683015d","user":{"login":"jjaracz","id":8504663,"avatar_url":"https://avatars0.githubusercontent.com/u/8504663?v=3","gravatar_id":"","url":"https://api.github.com/users/jjaracz","html_url":"https://github.com/jjaracz","followers_url":"https://api.github.com/users/jjaracz/followers","following_url":"https://api.github.com/users/jjaracz/following{/other_user}","gists_url":"https://api.github.com/users/jjaracz/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaracz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaracz/subscriptions","organizations_url":"https://api.github.com/users/jjaracz/orgs","repos_url":"https://api.github.com/users/jjaracz/repos","events_url":"https://api.github.com/users/jjaracz/events{/privacy}","received_events_url":"https://api.github.com/users/jjaracz/received_events","type":"User","site_admin":false},"repo":{"id":83666582,"name":"joomla-cms","full_name":"jjaracz/joomla-cms","owner":{"login":"jjaracz","id":8504663,"avatar_url":"https://avatars0.githubusercontent.com/u/8504663?v=3","gravatar_id":"","url":"https://api.github.com/users/jjaracz","html_url":"https://github.com/jjaracz","followers_url":"https://api.github.com/users/jjaracz/followers","following_url":"https://api.github.com/users/jjaracz/following{/other_user}","gists_url":"https://api.github.com/users/jjaracz/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaracz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaracz/subscriptions","organizations_url":"https://api.github.com/users/jjaracz/orgs","repos_url":"https://api.github.com/users/jjaracz/repos","events_url":"https://api.github.com/users/jjaracz/events{/privacy}","received_events_url":"https://api.github.com/users/jjaracz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jjaracz/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/jjaracz/joomla-cms","forks_url":"https://api.github.com/repos/jjaracz/joomla-cms/forks","keys_url":"https://api.github.com/repos/jjaracz/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjaracz/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjaracz/joomla-cms/teams","hooks_url":"https://api.github.com/repos/jjaracz/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/jjaracz/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/jjaracz/joomla-cms/events","assignees_url":"https://api.github.com/repos/jjaracz/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/jjaracz/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/jjaracz/joomla-cms/tags","blobs_url":"https://api.github.com/repos/jjaracz/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjaracz/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjaracz/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjaracz/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjaracz/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/jjaracz/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/jjaracz/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/jjaracz/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/jjaracz/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/jjaracz/joomla-cms/subscription","commits_url":"https://api.github.com/repos/jjaracz/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjaracz/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjaracz/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjaracz/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjaracz/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/jjaracz/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjaracz/joomla-cms/merges","archive_url":"https://api.github.com/repos/jjaracz/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjaracz/joomla-cms/downloads","issues_url":"https://api.github.com/repos/jjaracz/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/jjaracz/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/jjaracz/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/jjaracz/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjaracz/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/jjaracz/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/jjaracz/joomla-cms/deployments","created_at":"2017-03-02T10:41:38Z","updated_at":"2017-05-08T19:12:23Z","pushed_at":"2017-06-14T08:10:30Z","git_url":"git://github.com/jjaracz/joomla-cms.git","ssh_url":"[email protected]:jjaracz/joomla-cms.git","clone_url":"https://github.com/jjaracz/joomla-cms.git","svn_url":"https://github.com/jjaracz/joomla-cms","homepage":"https://www.joomla.org","size":190458,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"094fd4761b90e391e5533017f91414db68479757","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars0.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars0.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2017-06-17T11:44:45Z","pushed_at":"2017-06-17T17:26:01Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"[email protected]:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":197375,"stargazers_count":2406,"watchers_count":2406,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2494,"mirror_url":null,"open_issues_count":805,"forks":2494,"open_issues":805,"watchers":2406,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/14427"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/14427"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/14427"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/14427/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/14427/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/14427/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/cc572e1f52b1b51a9fedc669b1a2a5f7e683015d"}}}} | {
"id": 2464908,
"name": "joomla/joomla-cms",
"url": "https://api.github.com/repos/joomla/joomla-cms"
} | {
"id": 8504663,
"login": "jjaracz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8504663?",
"url": "https://api.github.com/users/jjaracz"
} | {
"id": 751633,
"login": "joomla",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/751633?",
"url": "https://api.github.com/orgs/joomla"
} | 2017-06-17T17:28:26 | 6085731837 | {"actor":{"display_login":"jjaracz"}} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.