type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
334k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/132525378","pull_request_review_id":55616445,"id":132525378,"diff_hunk":"@@ -345,6 +345,9 @@ public boolean getShouldStoreResult() {\n * The number of slices this task should be divided into. Defaults to 1 meaning the task isn't sliced into subtasks.\n */\n public Self setSlices(int slices) {\n+ if (slices < 0) {\n+ throw new IllegalArgumentException(\"[slices] must be at least 0\");","path":"core/src/main/java/org/elasticsearch/index/reindex/AbstractBulkByScrollRequest.java","position":null,"original_position":14,"commit_id":"eeffd397fbc72041469ee4a36b286b93d52b8e83","original_commit_id":"14eb56ad0a56d5051ea5874b3791b97d7641080d","user":{"login":"nik9000","id":215970,"avatar_url":"https://avatars2.githubusercontent.com/u/215970?v=4","gravatar_id":"","url":"https://api.github.com/users/nik9000","html_url":"https://github.com/nik9000","followers_url":"https://api.github.com/users/nik9000/followers","following_url":"https://api.github.com/users/nik9000/following{/other_user}","gists_url":"https://api.github.com/users/nik9000/gists{/gist_id}","starred_url":"https://api.github.com/users/nik9000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nik9000/subscriptions","organizations_url":"https://api.github.com/users/nik9000/orgs","repos_url":"https://api.github.com/users/nik9000/repos","events_url":"https://api.github.com/users/nik9000/events{/privacy}","received_events_url":"https://api.github.com/users/nik9000/received_events","type":"User","site_admin":false},"body":"Just in case this is ever thrown it'd be nice to have the error message more like \"slices must be at least 0 but was [$value]\".","created_at":"2017-08-10T18:00:30Z","updated_at":"2017-08-10T18:11:59Z","html_url":"https://github.com/elastic/elasticsearch/pull/26030#discussion_r132525378","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/26030","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/132525378"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/26030#discussion_r132525378"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/26030"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/26030","id":133796980,"html_url":"https://github.com/elastic/elasticsearch/pull/26030","diff_url":"https://github.com/elastic/elasticsearch/pull/26030.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/26030.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/26030","number":26030,"state":"open","locked":false,"title":"reindex: automatically choose the number of slices","user":{"login":"andy-elastic","id":29205940,"avatar_url":"https://avatars2.githubusercontent.com/u/29205940?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-elastic","html_url":"https://github.com/andy-elastic","followers_url":"https://api.github.com/users/andy-elastic/followers","following_url":"https://api.github.com/users/andy-elastic/following{/other_user}","gists_url":"https://api.github.com/users/andy-elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-elastic/subscriptions","organizations_url":"https://api.github.com/users/andy-elastic/orgs","repos_url":"https://api.github.com/users/andy-elastic/repos","events_url":"https://api.github.com/users/andy-elastic/events{/privacy}","received_events_url":"https://api.github.com/users/andy-elastic/received_events","type":"User","site_admin":false},"body":"For #24547\r\n\r\nAdd an option to reindex, update by query, and delete by query to set `slices` to `auto` rather than a specific number. The number of slices it chooses will be the lowest number of shards among the source indices, up to a constant ceiling. \r\n\r\nI chose the ceiling arbitrarily as 20 here. Next I want to do some of the rally benchmarking mentioned in the original issue to find what value makes the most sense.\r\n\r\nIn the interest of maintaining the original behavior, when slices is set to auto and there is only one shard, it will handle the request as if it was not sliced (i.e. `slices` defaults to 1). \r\n\r\nThis also adds unit tests for these APIs with multiple source indices\r\n\r\nThis includes the language from #25582 so I'll close that when this is merged","created_at":"2017-08-02T20:08:58Z","updated_at":"2017-08-10T18:11:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21271b65185c72358b94f99e57d7ca5bee168221","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jimczi","id":15977469,"avatar_url":"https://avatars0.githubusercontent.com/u/15977469?v=4","gravatar_id":"","url":"https://api.github.com/users/jimczi","html_url":"https://github.com/jimczi","followers_url":"https://api.github.com/users/jimczi/followers","following_url":"https://api.github.com/users/jimczi/following{/other_user}","gists_url":"https://api.github.com/users/jimczi/gists{/gist_id}","starred_url":"https://api.github.com/users/jimczi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimczi/subscriptions","organizations_url":"https://api.github.com/users/jimczi/orgs","repos_url":"https://api.github.com/users/jimczi/repos","events_url":"https://api.github.com/users/jimczi/events{/privacy}","received_events_url":"https://api.github.com/users/jimczi/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/26030/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/26030/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/26030/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/eeffd397fbc72041469ee4a36b286b93d52b8e83","head":{"label":"andy-elastic:feature/slices-auto","ref":"feature/slices-auto","sha":"eeffd397fbc72041469ee4a36b286b93d52b8e83","user":{"login":"andy-elastic","id":29205940,"avatar_url":"https://avatars2.githubusercontent.com/u/29205940?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-elastic","html_url":"https://github.com/andy-elastic","followers_url":"https://api.github.com/users/andy-elastic/followers","following_url":"https://api.github.com/users/andy-elastic/following{/other_user}","gists_url":"https://api.github.com/users/andy-elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-elastic/subscriptions","organizations_url":"https://api.github.com/users/andy-elastic/orgs","repos_url":"https://api.github.com/users/andy-elastic/repos","events_url":"https://api.github.com/users/andy-elastic/events{/privacy}","received_events_url":"https://api.github.com/users/andy-elastic/received_events","type":"User","site_admin":false},"repo":{"id":93532009,"name":"elasticsearch","full_name":"andy-elastic/elasticsearch","owner":{"login":"andy-elastic","id":29205940,"avatar_url":"https://avatars2.githubusercontent.com/u/29205940?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-elastic","html_url":"https://github.com/andy-elastic","followers_url":"https://api.github.com/users/andy-elastic/followers","following_url":"https://api.github.com/users/andy-elastic/following{/other_user}","gists_url":"https://api.github.com/users/andy-elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-elastic/subscriptions","organizations_url":"https://api.github.com/users/andy-elastic/orgs","repos_url":"https://api.github.com/users/andy-elastic/repos","events_url":"https://api.github.com/users/andy-elastic/events{/privacy}","received_events_url":"https://api.github.com/users/andy-elastic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andy-elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/andy-elastic/elasticsearch","forks_url":"https://api.github.com/repos/andy-elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/andy-elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andy-elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andy-elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/andy-elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/andy-elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/andy-elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/andy-elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/andy-elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/andy-elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/andy-elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andy-elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andy-elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/andy-elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andy-elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/andy-elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/andy-elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/andy-elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/andy-elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/andy-elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/andy-elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/andy-elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/andy-elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/andy-elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/andy-elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/andy-elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andy-elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/andy-elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andy-elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/andy-elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/andy-elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/andy-elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/andy-elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andy-elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/andy-elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/andy-elastic/elasticsearch/deployments","created_at":"2017-06-06T15:08:50Z","updated_at":"2017-06-06T15:09:26Z","pushed_at":"2017-08-10T16:05:42Z","git_url":"git://github.com/andy-elastic/elasticsearch.git","ssh_url":"[email protected]:andy-elastic/elasticsearch.git","clone_url":"https://github.com/andy-elastic/elasticsearch.git","svn_url":"https://github.com/andy-elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":358032,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"8cb1391f40c911e0bc27f19d8d9d35e8b4d04296","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2017-08-10T17:02:19Z","pushed_at":"2017-08-10T18:09:52Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"[email protected]:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":363571,"stargazers_count":24327,"watchers_count":24327,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8601,"mirror_url":null,"open_issues_count":1319,"forks":8601,"open_issues":1319,"watchers":24327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/26030"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/26030"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/26030"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/26030/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/26030/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/26030/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/eeffd397fbc72041469ee4a36b286b93d52b8e83"}}}} | {
"id": 507775,
"name": "elastic/elasticsearch",
"url": "https://api.github.com/repos/elastic/elasticsearch"
} | {
"id": 215970,
"login": "nik9000",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/215970?",
"url": "https://api.github.com/users/nik9000"
} | {
"id": 6764390,
"login": "elastic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6764390?",
"url": "https://api.github.com/orgs/elastic"
} | 2017-08-10T18:00:30 | 6435387783 | {"actor":{"display_login":"nik9000"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/elastic/beats/pulls/comments/152676771","pull_request_review_id":78576355,"id":152676771,"diff_hunk":"@@ -40,6 +40,7 @@ func NewGenerator(indexName, beatName, beatDir, beatVersion string, version comm\n \n // Create the Index-Pattern for Kibana for 5.x and default.\n func (i *IndexPatternGenerator) Generate() (string, error) {\n+","path":"libbeat/kibana/index_pattern_generator.go","position":null,"original_position":4,"commit_id":"0e3532024d78668a9091dc127c702b881ae34384","original_commit_id":"071c8c591db6c6fd7d833bf14f6529c7a0236593","user":{"login":"andrewkroh","id":4565752,"avatar_url":"https://avatars2.githubusercontent.com/u/4565752?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkroh","html_url":"https://github.com/andrewkroh","followers_url":"https://api.github.com/users/andrewkroh/followers","following_url":"https://api.github.com/users/andrewkroh/following{/other_user}","gists_url":"https://api.github.com/users/andrewkroh/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkroh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkroh/subscriptions","organizations_url":"https://api.github.com/users/andrewkroh/orgs","repos_url":"https://api.github.com/users/andrewkroh/repos","events_url":"https://api.github.com/users/andrewkroh/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkroh/received_events","type":"User","site_admin":false},"body":"See what? 😉 ","created_at":"2017-11-22T20:54:42Z","updated_at":"2017-11-22T20:54:42Z","html_url":"https://github.com/elastic/beats/pull/5328#discussion_r152676771","pull_request_url":"https://api.github.com/repos/elastic/beats/pulls/5328","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments/152676771"},"html":{"href":"https://github.com/elastic/beats/pull/5328#discussion_r152676771"},"pull_request":{"href":"https://api.github.com/repos/elastic/beats/pulls/5328"}},"in_reply_to_id":152472166},"pull_request":{"url":"https://api.github.com/repos/elastic/beats/pulls/5328","id":144852234,"html_url":"https://github.com/elastic/beats/pull/5328","diff_url":"https://github.com/elastic/beats/pull/5328.diff","patch_url":"https://github.com/elastic/beats/pull/5328.patch","issue_url":"https://api.github.com/repos/elastic/beats/issues/5328","number":5328,"state":"open","locked":false,"title":"Rename Kibana dashboard directories","user":{"login":"ruflin","id":244900,"avatar_url":"https://avatars3.githubusercontent.com/u/244900?v=4","gravatar_id":"","url":"https://api.github.com/users/ruflin","html_url":"https://github.com/ruflin","followers_url":"https://api.github.com/users/ruflin/followers","following_url":"https://api.github.com/users/ruflin/following{/other_user}","gists_url":"https://api.github.com/users/ruflin/gists{/gist_id}","starred_url":"https://api.github.com/users/ruflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruflin/subscriptions","organizations_url":"https://api.github.com/users/ruflin/orgs","repos_url":"https://api.github.com/users/ruflin/repos","events_url":"https://api.github.com/users/ruflin/events{/privacy}","received_events_url":"https://api.github.com/users/ruflin/received_events","type":"User","site_admin":false},"body":"Currently the dashboard directories are called 5.x and default. The naming default is a bit confusing as it is not clear what it means. In the current context it means the dashboards for all 6.x and 7.x releases. Unfortunately already now there are breaking changes in 7.x which means default does not work for both: https://github.com/elastic/beats/issues/5278\r\n\r\nTo allow us more flexibility the directory 5.x is renamed to 5 and the directory default is renamed to 6. This allows as to add a directory for 7 dashboards in the future. The reason I switched away from the `.x` naming is as this naming scheme also allows us to introduce for example 6.2 dashboards, meaning dashboards which only work with 6.2 and upwards in parallel to the 6 dashboards which work with all 6 releases.\r\n\r\nTODO:\r\n* [ ] Rename all kibana directories in modules\r\n* [ ] Rename all kibana directories in all beats\r\n\r\n@monica As a test I applied the change only to filebeat. To fully work all directories in our beats would have to be renamed. If we agree to move on with this, will update the PR with these changes too.","created_at":"2017-10-05T08:11:55Z","updated_at":"2017-11-22T20:54:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eaf689a954c997661e5471e36d9b03945aa743ca","assignee":null,"assignees":[],"requested_reviewers":[{"login":"monicasarbu","id":11757159,"avatar_url":"https://avatars2.githubusercontent.com/u/11757159?v=4","gravatar_id":"","url":"https://api.github.com/users/monicasarbu","html_url":"https://github.com/monicasarbu","followers_url":"https://api.github.com/users/monicasarbu/followers","following_url":"https://api.github.com/users/monicasarbu/following{/other_user}","gists_url":"https://api.github.com/users/monicasarbu/gists{/gist_id}","starred_url":"https://api.github.com/users/monicasarbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monicasarbu/subscriptions","organizations_url":"https://api.github.com/users/monicasarbu/orgs","repos_url":"https://api.github.com/users/monicasarbu/repos","events_url":"https://api.github.com/users/monicasarbu/events{/privacy}","received_events_url":"https://api.github.com/users/monicasarbu/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/beats/pulls/5328/commits","review_comments_url":"https://api.github.com/repos/elastic/beats/pulls/5328/comments","review_comment_url":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/beats/issues/5328/comments","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/0e3532024d78668a9091dc127c702b881ae34384","head":{"label":"ruflin:kibana-dashboard-dir-renaming","ref":"kibana-dashboard-dir-renaming","sha":"0e3532024d78668a9091dc127c702b881ae34384","user":{"login":"ruflin","id":244900,"avatar_url":"https://avatars3.githubusercontent.com/u/244900?v=4","gravatar_id":"","url":"https://api.github.com/users/ruflin","html_url":"https://github.com/ruflin","followers_url":"https://api.github.com/users/ruflin/followers","following_url":"https://api.github.com/users/ruflin/following{/other_user}","gists_url":"https://api.github.com/users/ruflin/gists{/gist_id}","starred_url":"https://api.github.com/users/ruflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruflin/subscriptions","organizations_url":"https://api.github.com/users/ruflin/orgs","repos_url":"https://api.github.com/users/ruflin/repos","events_url":"https://api.github.com/users/ruflin/events{/privacy}","received_events_url":"https://api.github.com/users/ruflin/received_events","type":"User","site_admin":false},"repo":{"id":40544282,"name":"beats","full_name":"ruflin/beats","owner":{"login":"ruflin","id":244900,"avatar_url":"https://avatars3.githubusercontent.com/u/244900?v=4","gravatar_id":"","url":"https://api.github.com/users/ruflin","html_url":"https://github.com/ruflin","followers_url":"https://api.github.com/users/ruflin/followers","following_url":"https://api.github.com/users/ruflin/following{/other_user}","gists_url":"https://api.github.com/users/ruflin/gists{/gist_id}","starred_url":"https://api.github.com/users/ruflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruflin/subscriptions","organizations_url":"https://api.github.com/users/ruflin/orgs","repos_url":"https://api.github.com/users/ruflin/repos","events_url":"https://api.github.com/users/ruflin/events{/privacy}","received_events_url":"https://api.github.com/users/ruflin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ruflin/beats","description":"Beats - Lightweight shippers for Elasticsearch & Logstash","fork":true,"url":"https://api.github.com/repos/ruflin/beats","forks_url":"https://api.github.com/repos/ruflin/beats/forks","keys_url":"https://api.github.com/repos/ruflin/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruflin/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruflin/beats/teams","hooks_url":"https://api.github.com/repos/ruflin/beats/hooks","issue_events_url":"https://api.github.com/repos/ruflin/beats/issues/events{/number}","events_url":"https://api.github.com/repos/ruflin/beats/events","assignees_url":"https://api.github.com/repos/ruflin/beats/assignees{/user}","branches_url":"https://api.github.com/repos/ruflin/beats/branches{/branch}","tags_url":"https://api.github.com/repos/ruflin/beats/tags","blobs_url":"https://api.github.com/repos/ruflin/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruflin/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruflin/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruflin/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruflin/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/ruflin/beats/languages","stargazers_url":"https://api.github.com/repos/ruflin/beats/stargazers","contributors_url":"https://api.github.com/repos/ruflin/beats/contributors","subscribers_url":"https://api.github.com/repos/ruflin/beats/subscribers","subscription_url":"https://api.github.com/repos/ruflin/beats/subscription","commits_url":"https://api.github.com/repos/ruflin/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruflin/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruflin/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruflin/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruflin/beats/contents/{+path}","compare_url":"https://api.github.com/repos/ruflin/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruflin/beats/merges","archive_url":"https://api.github.com/repos/ruflin/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruflin/beats/downloads","issues_url":"https://api.github.com/repos/ruflin/beats/issues{/number}","pulls_url":"https://api.github.com/repos/ruflin/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/ruflin/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/ruflin/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruflin/beats/labels{/name}","releases_url":"https://api.github.com/repos/ruflin/beats/releases{/id}","deployments_url":"https://api.github.com/repos/ruflin/beats/deployments","created_at":"2015-08-11T13:49:02Z","updated_at":"2016-10-24T12:55:12Z","pushed_at":"2017-11-22T20:54:04Z","git_url":"git://github.com/ruflin/beats.git","ssh_url":"[email protected]:ruflin/beats.git","clone_url":"https://github.com/ruflin/beats.git","svn_url":"https://github.com/ruflin/beats","homepage":"https://www.elastic.co/products/beats","size":71644,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"84e2e0953a4983065c96f240f6e8a6212940565c","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":16554739,"name":"beats","full_name":"elastic/beats","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/beats","description":":tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":false,"url":"https://api.github.com/repos/elastic/beats","forks_url":"https://api.github.com/repos/elastic/beats/forks","keys_url":"https://api.github.com/repos/elastic/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/beats/teams","hooks_url":"https://api.github.com/repos/elastic/beats/hooks","issue_events_url":"https://api.github.com/repos/elastic/beats/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/beats/events","assignees_url":"https://api.github.com/repos/elastic/beats/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/beats/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/beats/tags","blobs_url":"https://api.github.com/repos/elastic/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/beats/languages","stargazers_url":"https://api.github.com/repos/elastic/beats/stargazers","contributors_url":"https://api.github.com/repos/elastic/beats/contributors","subscribers_url":"https://api.github.com/repos/elastic/beats/subscribers","subscription_url":"https://api.github.com/repos/elastic/beats/subscription","commits_url":"https://api.github.com/repos/elastic/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/beats/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/beats/merges","archive_url":"https://api.github.com/repos/elastic/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/beats/downloads","issues_url":"https://api.github.com/repos/elastic/beats/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/beats/labels{/name}","releases_url":"https://api.github.com/repos/elastic/beats/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/beats/deployments","created_at":"2014-02-05T19:01:02Z","updated_at":"2017-11-22T17:30:17Z","pushed_at":"2017-11-22T20:54:05Z","git_url":"git://github.com/elastic/beats.git","ssh_url":"[email protected]:elastic/beats.git","clone_url":"https://github.com/elastic/beats.git","svn_url":"https://github.com/elastic/beats","homepage":"https://www.elastic.co/products/beats","size":66369,"stargazers_count":4825,"watchers_count":4825,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1283,"mirror_url":null,"archived":false,"open_issues_count":636,"forks":1283,"open_issues":636,"watchers":4825,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/5328"},"html":{"href":"https://github.com/elastic/beats/pull/5328"},"issue":{"href":"https://api.github.com/repos/elastic/beats/issues/5328"},"comments":{"href":"https://api.github.com/repos/elastic/beats/issues/5328/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/beats/pulls/5328/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/beats/pulls/5328/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/beats/statuses/0e3532024d78668a9091dc127c702b881ae34384"}},"author_association":"CONTRIBUTOR"}} | {
"id": 16554739,
"name": "elastic/beats",
"url": "https://api.github.com/repos/elastic/beats"
} | {
"id": 4565752,
"login": "andrewkroh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4565752?",
"url": "https://api.github.com/users/andrewkroh"
} | {
"id": 6764390,
"login": "elastic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6764390?",
"url": "https://api.github.com/orgs/elastic"
} | 2017-11-22T20:54:42 | 6892404522 | {"actor":{"display_login":"andrewkroh"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments/140270025","pull_request_review_id":64318035,"id":140270025,"diff_hunk":"@@ -205,4 +228,19 @@ public static Session getJcrSession(final FedoraSession session) {\n public static Duration operationTimeout() {\n return ofMillis(parseLong(System.getProperty(TIMEOUT_SYSTEM_PROPERTY, DEFAULT_TIMEOUT)));\n }\n+\n+ /**\n+ * Build default URI with the configured base uri for agent\n+ * @param userId\n+ * @return\n+ */\n+ private URI buildDefaultURI(final String userId) {\n+ // Construct the default URI for the user ID that is not a URI.\n+ final String userAgentBaseUri = System.getProperty(USER_AGENT_BASE_URI_PROPERTY);\n+ if (isNullOrEmpty(userAgentBaseUri)) {\n+ throw new RepositoryConfigurationException(\"User agent base URI prioperty is missing.\"","path":"fcrepo-kernel-modeshape/src/main/java/org/fcrepo/kernel/modeshape/FedoraSessionImpl.java","position":84,"original_position":72,"commit_id":"7c9864f57b3c3fb806b7c223d6faf18e79d89324","original_commit_id":"4e0f2b3621ba760bb9674601fbb568a519246dff","user":{"login":"escowles","id":856924,"avatar_url":"https://avatars3.githubusercontent.com/u/856924?v=4","gravatar_id":"","url":"https://api.github.com/users/escowles","html_url":"https://github.com/escowles","followers_url":"https://api.github.com/users/escowles/followers","following_url":"https://api.github.com/users/escowles/following{/other_user}","gists_url":"https://api.github.com/users/escowles/gists{/gist_id}","starred_url":"https://api.github.com/users/escowles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escowles/subscriptions","organizations_url":"https://api.github.com/users/escowles/orgs","repos_url":"https://api.github.com/users/escowles/repos","events_url":"https://api.github.com/users/escowles/events{/privacy}","received_events_url":"https://api.github.com/users/escowles/received_events","type":"User","site_admin":false},"body":"@birkland Oh, I think that's being set by the oneclick profile in pom.xml: https://github.com/fcrepo4/fcrepo4/blob/master/fcrepo-webapp/pom.xml#L494","created_at":"2017-09-21T15:07:41Z","updated_at":"2017-09-21T15:07:41Z","html_url":"https://github.com/fcrepo4/fcrepo4/pull/1242#discussion_r140270025","pull_request_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1242","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments/140270025"},"html":{"href":"https://github.com/fcrepo4/fcrepo4/pull/1242#discussion_r140270025"},"pull_request":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1242"}},"in_reply_to_id":140050559},"pull_request":{"url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1242","id":142140220,"html_url":"https://github.com/fcrepo4/fcrepo4/pull/1242","diff_url":"https://github.com/fcrepo4/fcrepo4/pull/1242.diff","patch_url":"https://github.com/fcrepo4/fcrepo4/pull/1242.patch","issue_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1242","number":1242,"state":"open","locked":false,"title":"Make user identities available as URIs in kernel API.","user":{"login":"lsitu","id":2430784,"avatar_url":"https://avatars2.githubusercontent.com/u/2430784?v=4","gravatar_id":"","url":"https://api.github.com/users/lsitu","html_url":"https://github.com/lsitu","followers_url":"https://api.github.com/users/lsitu/followers","following_url":"https://api.github.com/users/lsitu/following{/other_user}","gists_url":"https://api.github.com/users/lsitu/gists{/gist_id}","starred_url":"https://api.github.com/users/lsitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsitu/subscriptions","organizations_url":"https://api.github.com/users/lsitu/orgs","repos_url":"https://api.github.com/users/lsitu/repos","events_url":"https://api.github.com/users/lsitu/events{/privacy}","received_events_url":"https://api.github.com/users/lsitu/received_events","type":"User","site_admin":false},"body":"Fixes #https://jira.duraspace.org/browse/FCREPO-2608\r\n\r\nMake user identities available as URIs in kernel API through method getUserAgent().","created_at":"2017-09-20T16:04:38Z","updated_at":"2017-09-21T15:07:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"070e1c4972060f852772ac8a5756ddb1af26f0bb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1242/commits","review_comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1242/comments","review_comment_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1242/comments","statuses_url":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/7c9864f57b3c3fb806b7c223d6faf18e79d89324","head":{"label":"lsitu:feature/user_uri","ref":"feature/user_uri","sha":"7c9864f57b3c3fb806b7c223d6faf18e79d89324","user":{"login":"lsitu","id":2430784,"avatar_url":"https://avatars2.githubusercontent.com/u/2430784?v=4","gravatar_id":"","url":"https://api.github.com/users/lsitu","html_url":"https://github.com/lsitu","followers_url":"https://api.github.com/users/lsitu/followers","following_url":"https://api.github.com/users/lsitu/following{/other_user}","gists_url":"https://api.github.com/users/lsitu/gists{/gist_id}","starred_url":"https://api.github.com/users/lsitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsitu/subscriptions","organizations_url":"https://api.github.com/users/lsitu/orgs","repos_url":"https://api.github.com/users/lsitu/repos","events_url":"https://api.github.com/users/lsitu/events{/privacy}","received_events_url":"https://api.github.com/users/lsitu/received_events","type":"User","site_admin":false},"repo":{"id":18497364,"name":"fcrepo4","full_name":"lsitu/fcrepo4","owner":{"login":"lsitu","id":2430784,"avatar_url":"https://avatars2.githubusercontent.com/u/2430784?v=4","gravatar_id":"","url":"https://api.github.com/users/lsitu","html_url":"https://github.com/lsitu","followers_url":"https://api.github.com/users/lsitu/followers","following_url":"https://api.github.com/users/lsitu/following{/other_user}","gists_url":"https://api.github.com/users/lsitu/gists{/gist_id}","starred_url":"https://api.github.com/users/lsitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsitu/subscriptions","organizations_url":"https://api.github.com/users/lsitu/orgs","repos_url":"https://api.github.com/users/lsitu/repos","events_url":"https://api.github.com/users/lsitu/events{/privacy}","received_events_url":"https://api.github.com/users/lsitu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lsitu/fcrepo4","description":"Fedora 4: \"Changing everything, two weeks at a time\"","fork":true,"url":"https://api.github.com/repos/lsitu/fcrepo4","forks_url":"https://api.github.com/repos/lsitu/fcrepo4/forks","keys_url":"https://api.github.com/repos/lsitu/fcrepo4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsitu/fcrepo4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsitu/fcrepo4/teams","hooks_url":"https://api.github.com/repos/lsitu/fcrepo4/hooks","issue_events_url":"https://api.github.com/repos/lsitu/fcrepo4/issues/events{/number}","events_url":"https://api.github.com/repos/lsitu/fcrepo4/events","assignees_url":"https://api.github.com/repos/lsitu/fcrepo4/assignees{/user}","branches_url":"https://api.github.com/repos/lsitu/fcrepo4/branches{/branch}","tags_url":"https://api.github.com/repos/lsitu/fcrepo4/tags","blobs_url":"https://api.github.com/repos/lsitu/fcrepo4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsitu/fcrepo4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsitu/fcrepo4/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsitu/fcrepo4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsitu/fcrepo4/statuses/{sha}","languages_url":"https://api.github.com/repos/lsitu/fcrepo4/languages","stargazers_url":"https://api.github.com/repos/lsitu/fcrepo4/stargazers","contributors_url":"https://api.github.com/repos/lsitu/fcrepo4/contributors","subscribers_url":"https://api.github.com/repos/lsitu/fcrepo4/subscribers","subscription_url":"https://api.github.com/repos/lsitu/fcrepo4/subscription","commits_url":"https://api.github.com/repos/lsitu/fcrepo4/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsitu/fcrepo4/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsitu/fcrepo4/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsitu/fcrepo4/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsitu/fcrepo4/contents/{+path}","compare_url":"https://api.github.com/repos/lsitu/fcrepo4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsitu/fcrepo4/merges","archive_url":"https://api.github.com/repos/lsitu/fcrepo4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsitu/fcrepo4/downloads","issues_url":"https://api.github.com/repos/lsitu/fcrepo4/issues{/number}","pulls_url":"https://api.github.com/repos/lsitu/fcrepo4/pulls{/number}","milestones_url":"https://api.github.com/repos/lsitu/fcrepo4/milestones{/number}","notifications_url":"https://api.github.com/repos/lsitu/fcrepo4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsitu/fcrepo4/labels{/name}","releases_url":"https://api.github.com/repos/lsitu/fcrepo4/releases{/id}","deployments_url":"https://api.github.com/repos/lsitu/fcrepo4/deployments","created_at":"2014-04-06T19:27:16Z","updated_at":"2016-06-16T18:25:40Z","pushed_at":"2017-09-20T23:22:32Z","git_url":"git://github.com/lsitu/fcrepo4.git","ssh_url":"[email protected]:lsitu/fcrepo4.git","clone_url":"https://github.com/lsitu/fcrepo4.git","svn_url":"https://github.com/lsitu/fcrepo4","homepage":"http://futures.github.com/fcrepo4/","size":51369,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"fcrepo4:master","ref":"master","sha":"5e7fff9e1b945588568cf0f72b2959058da884d2","user":{"login":"fcrepo4","id":3057565,"avatar_url":"https://avatars2.githubusercontent.com/u/3057565?v=4","gravatar_id":"","url":"https://api.github.com/users/fcrepo4","html_url":"https://github.com/fcrepo4","followers_url":"https://api.github.com/users/fcrepo4/followers","following_url":"https://api.github.com/users/fcrepo4/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo4/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo4/subscriptions","organizations_url":"https://api.github.com/users/fcrepo4/orgs","repos_url":"https://api.github.com/users/fcrepo4/repos","events_url":"https://api.github.com/users/fcrepo4/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo4/received_events","type":"Organization","site_admin":false},"repo":{"id":7992797,"name":"fcrepo4","full_name":"fcrepo4/fcrepo4","owner":{"login":"fcrepo4","id":3057565,"avatar_url":"https://avatars2.githubusercontent.com/u/3057565?v=4","gravatar_id":"","url":"https://api.github.com/users/fcrepo4","html_url":"https://github.com/fcrepo4","followers_url":"https://api.github.com/users/fcrepo4/followers","following_url":"https://api.github.com/users/fcrepo4/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo4/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo4/subscriptions","organizations_url":"https://api.github.com/users/fcrepo4/orgs","repos_url":"https://api.github.com/users/fcrepo4/repos","events_url":"https://api.github.com/users/fcrepo4/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fcrepo4/fcrepo4","description":"Fedora 4","fork":false,"url":"https://api.github.com/repos/fcrepo4/fcrepo4","forks_url":"https://api.github.com/repos/fcrepo4/fcrepo4/forks","keys_url":"https://api.github.com/repos/fcrepo4/fcrepo4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fcrepo4/fcrepo4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fcrepo4/fcrepo4/teams","hooks_url":"https://api.github.com/repos/fcrepo4/fcrepo4/hooks","issue_events_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/events{/number}","events_url":"https://api.github.com/repos/fcrepo4/fcrepo4/events","assignees_url":"https://api.github.com/repos/fcrepo4/fcrepo4/assignees{/user}","branches_url":"https://api.github.com/repos/fcrepo4/fcrepo4/branches{/branch}","tags_url":"https://api.github.com/repos/fcrepo4/fcrepo4/tags","blobs_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/refs{/sha}","trees_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/{sha}","languages_url":"https://api.github.com/repos/fcrepo4/fcrepo4/languages","stargazers_url":"https://api.github.com/repos/fcrepo4/fcrepo4/stargazers","contributors_url":"https://api.github.com/repos/fcrepo4/fcrepo4/contributors","subscribers_url":"https://api.github.com/repos/fcrepo4/fcrepo4/subscribers","subscription_url":"https://api.github.com/repos/fcrepo4/fcrepo4/subscription","commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/commits{/sha}","git_commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/commits{/sha}","comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/comments{/number}","issue_comment_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/comments{/number}","contents_url":"https://api.github.com/repos/fcrepo4/fcrepo4/contents/{+path}","compare_url":"https://api.github.com/repos/fcrepo4/fcrepo4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fcrepo4/fcrepo4/merges","archive_url":"https://api.github.com/repos/fcrepo4/fcrepo4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fcrepo4/fcrepo4/downloads","issues_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues{/number}","pulls_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls{/number}","milestones_url":"https://api.github.com/repos/fcrepo4/fcrepo4/milestones{/number}","notifications_url":"https://api.github.com/repos/fcrepo4/fcrepo4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fcrepo4/fcrepo4/labels{/name}","releases_url":"https://api.github.com/repos/fcrepo4/fcrepo4/releases{/id}","deployments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/deployments","created_at":"2013-02-03T16:18:55Z","updated_at":"2017-09-14T13:31:20Z","pushed_at":"2017-09-21T03:29:07Z","git_url":"git://github.com/fcrepo4/fcrepo4.git","ssh_url":"[email protected]:fcrepo4/fcrepo4.git","clone_url":"https://github.com/fcrepo4/fcrepo4.git","svn_url":"https://github.com/fcrepo4/fcrepo4","homepage":"https://wiki.duraspace.org/display/FF/Fedora+Repository+Home","size":99214,"stargazers_count":87,"watchers_count":87,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":95,"mirror_url":null,"open_issues_count":17,"forks":95,"open_issues":17,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1242"},"html":{"href":"https://github.com/fcrepo4/fcrepo4/pull/1242"},"issue":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1242"},"comments":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1242/comments"},"review_comments":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1242/comments"},"review_comment":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1242/commits"},"statuses":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/7c9864f57b3c3fb806b7c223d6faf18e79d89324"}},"author_association":"CONTRIBUTOR"}} | {
"id": 7992797,
"name": "fcrepo4/fcrepo4",
"url": "https://api.github.com/repos/fcrepo4/fcrepo4"
} | {
"id": 856924,
"login": "escowles",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/856924?",
"url": "https://api.github.com/users/escowles"
} | {
"id": 3057565,
"login": "fcrepo4",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3057565?",
"url": "https://api.github.com/orgs/fcrepo4"
} | 2017-09-21T15:07:41 | 6620302957 | {"actor":{"display_login":"escowles"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/finn-no/node-docker/pulls/comments/108127320","pull_request_review_id":29137906,"id":108127320,"diff_hunk":"@@ -71,7 +71,14 @@ then\n exit 1\n fi\n \n-echo Copying over base Dockerfiles\n+printf \"\\n\\nDeleting old container images\\n\\n\"\n+\n+until docker images | grep \"containers.schibsted.io/finntech/node\" | awk '{print $3}' | sort | uniq | xargs docker rmi -f\n+do\n+ true\n+done","path":"release.sh","position":10,"original_position":10,"commit_id":"0d1e07358b8ca5a176590e7cdc93eda46cdbeef7","original_commit_id":"0d1e07358b8ca5a176590e7cdc93eda46cdbeef7","user":{"login":"theneva","id":1404650,"avatar_url":"https://avatars1.githubusercontent.com/u/1404650?v=3","gravatar_id":"","url":"https://api.github.com/users/theneva","html_url":"https://github.com/theneva","followers_url":"https://api.github.com/users/theneva/followers","following_url":"https://api.github.com/users/theneva/following{/other_user}","gists_url":"https://api.github.com/users/theneva/gists{/gist_id}","starred_url":"https://api.github.com/users/theneva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theneva/subscriptions","organizations_url":"https://api.github.com/users/theneva/orgs","repos_url":"https://api.github.com/users/theneva/repos","events_url":"https://api.github.com/users/theneva/events{/privacy}","received_events_url":"https://api.github.com/users/theneva/received_events","type":"User","site_admin":false},"body":"that is sooo gooooood","created_at":"2017-03-27T09:35:34Z","updated_at":"2017-03-27T09:35:34Z","html_url":"https://github.com/finn-no/node-docker/pull/7#discussion_r108127320","pull_request_url":"https://api.github.com/repos/finn-no/node-docker/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/finn-no/node-docker/pulls/comments/108127320"},"html":{"href":"https://github.com/finn-no/node-docker/pull/7#discussion_r108127320"},"pull_request":{"href":"https://api.github.com/repos/finn-no/node-docker/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/finn-no/node-docker/pulls/7","id":112172552,"html_url":"https://github.com/finn-no/node-docker/pull/7","diff_url":"https://github.com/finn-no/node-docker/pull/7.diff","patch_url":"https://github.com/finn-no/node-docker/pull/7.patch","issue_url":"https://api.github.com/repos/finn-no/node-docker/issues/7","number":7,"state":"open","locked":false,"title":"Clean old images before tagging new ones","user":{"login":"SimenB","id":1404810,"avatar_url":"https://avatars2.githubusercontent.com/u/1404810?v=3","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"body":"This ensures that we don't push old tags later","created_at":"2017-03-23T06:49:36Z","updated_at":"2017-03-27T09:35:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"878ec83e595b7f5c0521a4b5b0c858856c16a55f","assignee":{"login":"stigkj","id":14671,"avatar_url":"https://avatars2.githubusercontent.com/u/14671?v=3","gravatar_id":"","url":"https://api.github.com/users/stigkj","html_url":"https://github.com/stigkj","followers_url":"https://api.github.com/users/stigkj/followers","following_url":"https://api.github.com/users/stigkj/following{/other_user}","gists_url":"https://api.github.com/users/stigkj/gists{/gist_id}","starred_url":"https://api.github.com/users/stigkj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stigkj/subscriptions","organizations_url":"https://api.github.com/users/stigkj/orgs","repos_url":"https://api.github.com/users/stigkj/repos","events_url":"https://api.github.com/users/stigkj/events{/privacy}","received_events_url":"https://api.github.com/users/stigkj/received_events","type":"User","site_admin":false},"assignees":[{"login":"stigkj","id":14671,"avatar_url":"https://avatars2.githubusercontent.com/u/14671?v=3","gravatar_id":"","url":"https://api.github.com/users/stigkj","html_url":"https://github.com/stigkj","followers_url":"https://api.github.com/users/stigkj/followers","following_url":"https://api.github.com/users/stigkj/following{/other_user}","gists_url":"https://api.github.com/users/stigkj/gists{/gist_id}","starred_url":"https://api.github.com/users/stigkj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stigkj/subscriptions","organizations_url":"https://api.github.com/users/stigkj/orgs","repos_url":"https://api.github.com/users/stigkj/repos","events_url":"https://api.github.com/users/stigkj/events{/privacy}","received_events_url":"https://api.github.com/users/stigkj/received_events","type":"User","site_admin":false},{"login":"ivarconr","id":158948,"avatar_url":"https://avatars0.githubusercontent.com/u/158948?v=3","gravatar_id":"","url":"https://api.github.com/users/ivarconr","html_url":"https://github.com/ivarconr","followers_url":"https://api.github.com/users/ivarconr/followers","following_url":"https://api.github.com/users/ivarconr/following{/other_user}","gists_url":"https://api.github.com/users/ivarconr/gists{/gist_id}","starred_url":"https://api.github.com/users/ivarconr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivarconr/subscriptions","organizations_url":"https://api.github.com/users/ivarconr/orgs","repos_url":"https://api.github.com/users/ivarconr/repos","events_url":"https://api.github.com/users/ivarconr/events{/privacy}","received_events_url":"https://api.github.com/users/ivarconr/received_events","type":"User","site_admin":false},{"login":"chriswk","id":177402,"avatar_url":"https://avatars1.githubusercontent.com/u/177402?v=3","gravatar_id":"","url":"https://api.github.com/users/chriswk","html_url":"https://github.com/chriswk","followers_url":"https://api.github.com/users/chriswk/followers","following_url":"https://api.github.com/users/chriswk/following{/other_user}","gists_url":"https://api.github.com/users/chriswk/gists{/gist_id}","starred_url":"https://api.github.com/users/chriswk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriswk/subscriptions","organizations_url":"https://api.github.com/users/chriswk/orgs","repos_url":"https://api.github.com/users/chriswk/repos","events_url":"https://api.github.com/users/chriswk/events{/privacy}","received_events_url":"https://api.github.com/users/chriswk/received_events","type":"User","site_admin":false},{"login":"theneva","id":1404650,"avatar_url":"https://avatars1.githubusercontent.com/u/1404650?v=3","gravatar_id":"","url":"https://api.github.com/users/theneva","html_url":"https://github.com/theneva","followers_url":"https://api.github.com/users/theneva/followers","following_url":"https://api.github.com/users/theneva/following{/other_user}","gists_url":"https://api.github.com/users/theneva/gists{/gist_id}","starred_url":"https://api.github.com/users/theneva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theneva/subscriptions","organizations_url":"https://api.github.com/users/theneva/orgs","repos_url":"https://api.github.com/users/theneva/repos","events_url":"https://api.github.com/users/theneva/events{/privacy}","received_events_url":"https://api.github.com/users/theneva/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/finn-no/node-docker/pulls/7/commits","review_comments_url":"https://api.github.com/repos/finn-no/node-docker/pulls/7/comments","review_comment_url":"https://api.github.com/repos/finn-no/node-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/finn-no/node-docker/issues/7/comments","statuses_url":"https://api.github.com/repos/finn-no/node-docker/statuses/0d1e07358b8ca5a176590e7cdc93eda46cdbeef7","head":{"label":"finn-no:clean-old-images","ref":"clean-old-images","sha":"0d1e07358b8ca5a176590e7cdc93eda46cdbeef7","user":{"login":"finn-no","id":124904,"avatar_url":"https://avatars1.githubusercontent.com/u/124904?v=3","gravatar_id":"","url":"https://api.github.com/users/finn-no","html_url":"https://github.com/finn-no","followers_url":"https://api.github.com/users/finn-no/followers","following_url":"https://api.github.com/users/finn-no/following{/other_user}","gists_url":"https://api.github.com/users/finn-no/gists{/gist_id}","starred_url":"https://api.github.com/users/finn-no/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finn-no/subscriptions","organizations_url":"https://api.github.com/users/finn-no/orgs","repos_url":"https://api.github.com/users/finn-no/repos","events_url":"https://api.github.com/users/finn-no/events{/privacy}","received_events_url":"https://api.github.com/users/finn-no/received_events","type":"Organization","site_admin":false},"repo":{"id":69665775,"name":"node-docker","full_name":"finn-no/node-docker","owner":{"login":"finn-no","id":124904,"avatar_url":"https://avatars1.githubusercontent.com/u/124904?v=3","gravatar_id":"","url":"https://api.github.com/users/finn-no","html_url":"https://github.com/finn-no","followers_url":"https://api.github.com/users/finn-no/followers","following_url":"https://api.github.com/users/finn-no/following{/other_user}","gists_url":"https://api.github.com/users/finn-no/gists{/gist_id}","starred_url":"https://api.github.com/users/finn-no/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finn-no/subscriptions","organizations_url":"https://api.github.com/users/finn-no/orgs","repos_url":"https://api.github.com/users/finn-no/repos","events_url":"https://api.github.com/users/finn-no/events{/privacy}","received_events_url":"https://api.github.com/users/finn-no/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/finn-no/node-docker","description":null,"fork":false,"url":"https://api.github.com/repos/finn-no/node-docker","forks_url":"https://api.github.com/repos/finn-no/node-docker/forks","keys_url":"https://api.github.com/repos/finn-no/node-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/finn-no/node-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/finn-no/node-docker/teams","hooks_url":"https://api.github.com/repos/finn-no/node-docker/hooks","issue_events_url":"https://api.github.com/repos/finn-no/node-docker/issues/events{/number}","events_url":"https://api.github.com/repos/finn-no/node-docker/events","assignees_url":"https://api.github.com/repos/finn-no/node-docker/assignees{/user}","branches_url":"https://api.github.com/repos/finn-no/node-docker/branches{/branch}","tags_url":"https://api.github.com/repos/finn-no/node-docker/tags","blobs_url":"https://api.github.com/repos/finn-no/node-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/finn-no/node-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/finn-no/node-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/finn-no/node-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/finn-no/node-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/finn-no/node-docker/languages","stargazers_url":"https://api.github.com/repos/finn-no/node-docker/stargazers","contributors_url":"https://api.github.com/repos/finn-no/node-docker/contributors","subscribers_url":"https://api.github.com/repos/finn-no/node-docker/subscribers","subscription_url":"https://api.github.com/repos/finn-no/node-docker/subscription","commits_url":"https://api.github.com/repos/finn-no/node-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/finn-no/node-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/finn-no/node-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/finn-no/node-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/finn-no/node-docker/contents/{+path}","compare_url":"https://api.github.com/repos/finn-no/node-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/finn-no/node-docker/merges","archive_url":"https://api.github.com/repos/finn-no/node-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/finn-no/node-docker/downloads","issues_url":"https://api.github.com/repos/finn-no/node-docker/issues{/number}","pulls_url":"https://api.github.com/repos/finn-no/node-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/finn-no/node-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/finn-no/node-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/finn-no/node-docker/labels{/name}","releases_url":"https://api.github.com/repos/finn-no/node-docker/releases{/id}","deployments_url":"https://api.github.com/repos/finn-no/node-docker/deployments","created_at":"2016-09-30T12:39:48Z","updated_at":"2017-03-02T19:16:50Z","pushed_at":"2017-03-25T12:25:21Z","git_url":"git://github.com/finn-no/node-docker.git","ssh_url":"[email protected]:finn-no/node-docker.git","clone_url":"https://github.com/finn-no/node-docker.git","svn_url":"https://github.com/finn-no/node-docker","homepage":null,"size":48,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"finn-no:master","ref":"master","sha":"9a97ea6f082bb9f662b975a59b7566d61bc8919a","user":{"login":"finn-no","id":124904,"avatar_url":"https://avatars1.githubusercontent.com/u/124904?v=3","gravatar_id":"","url":"https://api.github.com/users/finn-no","html_url":"https://github.com/finn-no","followers_url":"https://api.github.com/users/finn-no/followers","following_url":"https://api.github.com/users/finn-no/following{/other_user}","gists_url":"https://api.github.com/users/finn-no/gists{/gist_id}","starred_url":"https://api.github.com/users/finn-no/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finn-no/subscriptions","organizations_url":"https://api.github.com/users/finn-no/orgs","repos_url":"https://api.github.com/users/finn-no/repos","events_url":"https://api.github.com/users/finn-no/events{/privacy}","received_events_url":"https://api.github.com/users/finn-no/received_events","type":"Organization","site_admin":false},"repo":{"id":69665775,"name":"node-docker","full_name":"finn-no/node-docker","owner":{"login":"finn-no","id":124904,"avatar_url":"https://avatars1.githubusercontent.com/u/124904?v=3","gravatar_id":"","url":"https://api.github.com/users/finn-no","html_url":"https://github.com/finn-no","followers_url":"https://api.github.com/users/finn-no/followers","following_url":"https://api.github.com/users/finn-no/following{/other_user}","gists_url":"https://api.github.com/users/finn-no/gists{/gist_id}","starred_url":"https://api.github.com/users/finn-no/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finn-no/subscriptions","organizations_url":"https://api.github.com/users/finn-no/orgs","repos_url":"https://api.github.com/users/finn-no/repos","events_url":"https://api.github.com/users/finn-no/events{/privacy}","received_events_url":"https://api.github.com/users/finn-no/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/finn-no/node-docker","description":null,"fork":false,"url":"https://api.github.com/repos/finn-no/node-docker","forks_url":"https://api.github.com/repos/finn-no/node-docker/forks","keys_url":"https://api.github.com/repos/finn-no/node-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/finn-no/node-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/finn-no/node-docker/teams","hooks_url":"https://api.github.com/repos/finn-no/node-docker/hooks","issue_events_url":"https://api.github.com/repos/finn-no/node-docker/issues/events{/number}","events_url":"https://api.github.com/repos/finn-no/node-docker/events","assignees_url":"https://api.github.com/repos/finn-no/node-docker/assignees{/user}","branches_url":"https://api.github.com/repos/finn-no/node-docker/branches{/branch}","tags_url":"https://api.github.com/repos/finn-no/node-docker/tags","blobs_url":"https://api.github.com/repos/finn-no/node-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/finn-no/node-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/finn-no/node-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/finn-no/node-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/finn-no/node-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/finn-no/node-docker/languages","stargazers_url":"https://api.github.com/repos/finn-no/node-docker/stargazers","contributors_url":"https://api.github.com/repos/finn-no/node-docker/contributors","subscribers_url":"https://api.github.com/repos/finn-no/node-docker/subscribers","subscription_url":"https://api.github.com/repos/finn-no/node-docker/subscription","commits_url":"https://api.github.com/repos/finn-no/node-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/finn-no/node-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/finn-no/node-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/finn-no/node-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/finn-no/node-docker/contents/{+path}","compare_url":"https://api.github.com/repos/finn-no/node-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/finn-no/node-docker/merges","archive_url":"https://api.github.com/repos/finn-no/node-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/finn-no/node-docker/downloads","issues_url":"https://api.github.com/repos/finn-no/node-docker/issues{/number}","pulls_url":"https://api.github.com/repos/finn-no/node-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/finn-no/node-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/finn-no/node-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/finn-no/node-docker/labels{/name}","releases_url":"https://api.github.com/repos/finn-no/node-docker/releases{/id}","deployments_url":"https://api.github.com/repos/finn-no/node-docker/deployments","created_at":"2016-09-30T12:39:48Z","updated_at":"2017-03-02T19:16:50Z","pushed_at":"2017-03-25T12:25:21Z","git_url":"git://github.com/finn-no/node-docker.git","ssh_url":"[email protected]:finn-no/node-docker.git","clone_url":"https://github.com/finn-no/node-docker.git","svn_url":"https://github.com/finn-no/node-docker","homepage":null,"size":48,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/finn-no/node-docker/pulls/7"},"html":{"href":"https://github.com/finn-no/node-docker/pull/7"},"issue":{"href":"https://api.github.com/repos/finn-no/node-docker/issues/7"},"comments":{"href":"https://api.github.com/repos/finn-no/node-docker/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/finn-no/node-docker/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/finn-no/node-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/finn-no/node-docker/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/finn-no/node-docker/statuses/0d1e07358b8ca5a176590e7cdc93eda46cdbeef7"}}}} | {
"id": 69665775,
"name": "finn-no/node-docker",
"url": "https://api.github.com/repos/finn-no/node-docker"
} | {
"id": 1404650,
"login": "theneva",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1404650?",
"url": "https://api.github.com/users/theneva"
} | {
"id": 124904,
"login": "finn-no",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/124904?",
"url": "https://api.github.com/orgs/finn-no"
} | 2017-03-27T09:35:34 | 5569066925 | {"actor":{"display_login":"theneva"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/framgia/Feastival/pulls/comments/127681036","pull_request_review_id":50288924,"id":127681036,"diff_hunk":"@@ -0,0 +1,11 @@\n+var translate = require('counterpart');\n+\n+import Navbar from \"./navbar\";","path":"app/jsx/components/home_page.jsx","position":3,"original_position":3,"commit_id":"cc82c4a555b935100a69834b0f9b7ff83de81dc2","original_commit_id":"cc82c4a555b935100a69834b0f9b7ff83de81dc2","user":{"login":"sangnuce","id":12852873,"avatar_url":"https://avatars7.githubusercontent.com/u/12852873?v=4","gravatar_id":"","url":"https://api.github.com/users/sangnuce","html_url":"https://github.com/sangnuce","followers_url":"https://api.github.com/users/sangnuce/followers","following_url":"https://api.github.com/users/sangnuce/following{/other_user}","gists_url":"https://api.github.com/users/sangnuce/gists{/gist_id}","starred_url":"https://api.github.com/users/sangnuce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sangnuce/subscriptions","organizations_url":"https://api.github.com/users/sangnuce/orgs","repos_url":"https://api.github.com/users/sangnuce/repos","events_url":"https://api.github.com/users/sangnuce/events{/privacy}","received_events_url":"https://api.github.com/users/sangnuce/received_events","type":"User","site_admin":false},"body":"nháy đơn","created_at":"2017-07-17T11:08:28Z","updated_at":"2017-07-17T11:10:14Z","html_url":"https://github.com/framgia/Feastival/pull/47#discussion_r127681036","pull_request_url":"https://api.github.com/repos/framgia/Feastival/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/framgia/Feastival/pulls/comments/127681036"},"html":{"href":"https://github.com/framgia/Feastival/pull/47#discussion_r127681036"},"pull_request":{"href":"https://api.github.com/repos/framgia/Feastival/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/framgia/Feastival/pulls/47","id":130809324,"html_url":"https://github.com/framgia/Feastival/pull/47","diff_url":"https://github.com/framgia/Feastival/pull/47.diff","patch_url":"https://github.com/framgia/Feastival/pull/47.patch","issue_url":"https://api.github.com/repos/framgia/Feastival/issues/47","number":47,"state":"open","locked":false,"title":"Complete home static page","user":{"login":"tuananhhedspibk","id":15076665,"avatar_url":"https://avatars4.githubusercontent.com/u/15076665?v=4","gravatar_id":"","url":"https://api.github.com/users/tuananhhedspibk","html_url":"https://github.com/tuananhhedspibk","followers_url":"https://api.github.com/users/tuananhhedspibk/followers","following_url":"https://api.github.com/users/tuananhhedspibk/following{/other_user}","gists_url":"https://api.github.com/users/tuananhhedspibk/gists{/gist_id}","starred_url":"https://api.github.com/users/tuananhhedspibk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuananhhedspibk/subscriptions","organizations_url":"https://api.github.com/users/tuananhhedspibk/orgs","repos_url":"https://api.github.com/users/tuananhhedspibk/repos","events_url":"https://api.github.com/users/tuananhhedspibk/events{/privacy}","received_events_url":"https://api.github.com/users/tuananhhedspibk/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-17T08:59:56Z","updated_at":"2017-07-17T11:10:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0366c2e416feb6011ecd08454b45fbd0077987ed","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/framgia/Feastival/pulls/47/commits","review_comments_url":"https://api.github.com/repos/framgia/Feastival/pulls/47/comments","review_comment_url":"https://api.github.com/repos/framgia/Feastival/pulls/comments{/number}","comments_url":"https://api.github.com/repos/framgia/Feastival/issues/47/comments","statuses_url":"https://api.github.com/repos/framgia/Feastival/statuses/cc82c4a555b935100a69834b0f9b7ff83de81dc2","head":{"label":"tuananhhedspibk:working1","ref":"working1","sha":"cc82c4a555b935100a69834b0f9b7ff83de81dc2","user":{"login":"tuananhhedspibk","id":15076665,"avatar_url":"https://avatars4.githubusercontent.com/u/15076665?v=4","gravatar_id":"","url":"https://api.github.com/users/tuananhhedspibk","html_url":"https://github.com/tuananhhedspibk","followers_url":"https://api.github.com/users/tuananhhedspibk/followers","following_url":"https://api.github.com/users/tuananhhedspibk/following{/other_user}","gists_url":"https://api.github.com/users/tuananhhedspibk/gists{/gist_id}","starred_url":"https://api.github.com/users/tuananhhedspibk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuananhhedspibk/subscriptions","organizations_url":"https://api.github.com/users/tuananhhedspibk/orgs","repos_url":"https://api.github.com/users/tuananhhedspibk/repos","events_url":"https://api.github.com/users/tuananhhedspibk/events{/privacy}","received_events_url":"https://api.github.com/users/tuananhhedspibk/received_events","type":"User","site_admin":false},"repo":{"id":96851192,"name":"Feastival","full_name":"tuananhhedspibk/Feastival","owner":{"login":"tuananhhedspibk","id":15076665,"avatar_url":"https://avatars4.githubusercontent.com/u/15076665?v=4","gravatar_id":"","url":"https://api.github.com/users/tuananhhedspibk","html_url":"https://github.com/tuananhhedspibk","followers_url":"https://api.github.com/users/tuananhhedspibk/followers","following_url":"https://api.github.com/users/tuananhhedspibk/following{/other_user}","gists_url":"https://api.github.com/users/tuananhhedspibk/gists{/gist_id}","starred_url":"https://api.github.com/users/tuananhhedspibk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuananhhedspibk/subscriptions","organizations_url":"https://api.github.com/users/tuananhhedspibk/orgs","repos_url":"https://api.github.com/users/tuananhhedspibk/repos","events_url":"https://api.github.com/users/tuananhhedspibk/events{/privacy}","received_events_url":"https://api.github.com/users/tuananhhedspibk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tuananhhedspibk/Feastival","description":"Feastival (Training Project)","fork":true,"url":"https://api.github.com/repos/tuananhhedspibk/Feastival","forks_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/forks","keys_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/teams","hooks_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/hooks","issue_events_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/issues/events{/number}","events_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/events","assignees_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/assignees{/user}","branches_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/branches{/branch}","tags_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/tags","blobs_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/git/refs{/sha}","trees_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/statuses/{sha}","languages_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/languages","stargazers_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/stargazers","contributors_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/contributors","subscribers_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/subscribers","subscription_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/subscription","commits_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/commits{/sha}","git_commits_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/git/commits{/sha}","comments_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/comments{/number}","issue_comment_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/issues/comments{/number}","contents_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/contents/{+path}","compare_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/merges","archive_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/downloads","issues_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/issues{/number}","pulls_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/pulls{/number}","milestones_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/milestones{/number}","notifications_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/labels{/name}","releases_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/releases{/id}","deployments_url":"https://api.github.com/repos/tuananhhedspibk/Feastival/deployments","created_at":"2017-07-11T04:38:18Z","updated_at":"2017-06-12T03:18:22Z","pushed_at":"2017-07-17T10:08:09Z","git_url":"git://github.com/tuananhhedspibk/Feastival.git","ssh_url":"[email protected]:tuananhhedspibk/Feastival.git","clone_url":"https://github.com/tuananhhedspibk/Feastival.git","svn_url":"https://github.com/tuananhhedspibk/Feastival","homepage":null,"size":2919,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"framgia:rebuild","ref":"rebuild","sha":"ae4a08890d91f23fb5cac7d25745e277ef845c4c","user":{"login":"framgia","id":2322183,"avatar_url":"https://avatars7.githubusercontent.com/u/2322183?v=4","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"repo":{"id":90611630,"name":"Feastival","full_name":"framgia/Feastival","owner":{"login":"framgia","id":2322183,"avatar_url":"https://avatars7.githubusercontent.com/u/2322183?v=4","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/framgia/Feastival","description":"Feastival (Training Project)","fork":false,"url":"https://api.github.com/repos/framgia/Feastival","forks_url":"https://api.github.com/repos/framgia/Feastival/forks","keys_url":"https://api.github.com/repos/framgia/Feastival/keys{/key_id}","collaborators_url":"https://api.github.com/repos/framgia/Feastival/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/framgia/Feastival/teams","hooks_url":"https://api.github.com/repos/framgia/Feastival/hooks","issue_events_url":"https://api.github.com/repos/framgia/Feastival/issues/events{/number}","events_url":"https://api.github.com/repos/framgia/Feastival/events","assignees_url":"https://api.github.com/repos/framgia/Feastival/assignees{/user}","branches_url":"https://api.github.com/repos/framgia/Feastival/branches{/branch}","tags_url":"https://api.github.com/repos/framgia/Feastival/tags","blobs_url":"https://api.github.com/repos/framgia/Feastival/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/framgia/Feastival/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/framgia/Feastival/git/refs{/sha}","trees_url":"https://api.github.com/repos/framgia/Feastival/git/trees{/sha}","statuses_url":"https://api.github.com/repos/framgia/Feastival/statuses/{sha}","languages_url":"https://api.github.com/repos/framgia/Feastival/languages","stargazers_url":"https://api.github.com/repos/framgia/Feastival/stargazers","contributors_url":"https://api.github.com/repos/framgia/Feastival/contributors","subscribers_url":"https://api.github.com/repos/framgia/Feastival/subscribers","subscription_url":"https://api.github.com/repos/framgia/Feastival/subscription","commits_url":"https://api.github.com/repos/framgia/Feastival/commits{/sha}","git_commits_url":"https://api.github.com/repos/framgia/Feastival/git/commits{/sha}","comments_url":"https://api.github.com/repos/framgia/Feastival/comments{/number}","issue_comment_url":"https://api.github.com/repos/framgia/Feastival/issues/comments{/number}","contents_url":"https://api.github.com/repos/framgia/Feastival/contents/{+path}","compare_url":"https://api.github.com/repos/framgia/Feastival/compare/{base}...{head}","merges_url":"https://api.github.com/repos/framgia/Feastival/merges","archive_url":"https://api.github.com/repos/framgia/Feastival/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/framgia/Feastival/downloads","issues_url":"https://api.github.com/repos/framgia/Feastival/issues{/number}","pulls_url":"https://api.github.com/repos/framgia/Feastival/pulls{/number}","milestones_url":"https://api.github.com/repos/framgia/Feastival/milestones{/number}","notifications_url":"https://api.github.com/repos/framgia/Feastival/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/framgia/Feastival/labels{/name}","releases_url":"https://api.github.com/repos/framgia/Feastival/releases{/id}","deployments_url":"https://api.github.com/repos/framgia/Feastival/deployments","created_at":"2017-05-08T09:41:29Z","updated_at":"2017-06-12T03:18:22Z","pushed_at":"2017-07-17T10:08:11Z","git_url":"git://github.com/framgia/Feastival.git","ssh_url":"[email protected]:framgia/Feastival.git","clone_url":"https://github.com/framgia/Feastival.git","svn_url":"https://github.com/framgia/Feastival","homepage":null,"size":1330,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/framgia/Feastival/pulls/47"},"html":{"href":"https://github.com/framgia/Feastival/pull/47"},"issue":{"href":"https://api.github.com/repos/framgia/Feastival/issues/47"},"comments":{"href":"https://api.github.com/repos/framgia/Feastival/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/framgia/Feastival/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/framgia/Feastival/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/framgia/Feastival/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/framgia/Feastival/statuses/cc82c4a555b935100a69834b0f9b7ff83de81dc2"}}}} | {
"id": 90611630,
"name": "framgia/Feastival",
"url": "https://api.github.com/repos/framgia/Feastival"
} | {
"id": 12852873,
"login": "sangnuce",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12852873?",
"url": "https://api.github.com/users/sangnuce"
} | {
"id": 2322183,
"login": "framgia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2322183?",
"url": "https://api.github.com/orgs/framgia"
} | 2017-07-17T11:08:28 | 6268574012 | {"actor":{"display_login":"sangnuce"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/framgia/ecommerce_27/pulls/comments/113407731","pull_request_review_id":34791630,"id":113407731,"diff_hunk":"@@ -0,0 +1,56 @@\n+class CategoriesController < ApplicationController\n+\n+ before_action :find_category, except: [:index, :create, :new]\n+\n+ def index\n+ @categories = Category.paginate page: params[:page],\n+ per_page: Settings.per_page\n+ @all_category = Category.all","path":"app/controllers/categories_controller.rb","position":8,"original_position":8,"commit_id":"9113400bf2383d764d51e11bb35055bd8975b0a6","original_commit_id":"9113400bf2383d764d51e11bb35055bd8975b0a6","user":{"login":"phamvanbk11","id":10772245,"avatar_url":"https://avatars2.githubusercontent.com/u/10772245?v=3","gravatar_id":"","url":"https://api.github.com/users/phamvanbk11","html_url":"https://github.com/phamvanbk11","followers_url":"https://api.github.com/users/phamvanbk11/followers","following_url":"https://api.github.com/users/phamvanbk11/following{/other_user}","gists_url":"https://api.github.com/users/phamvanbk11/gists{/gist_id}","starred_url":"https://api.github.com/users/phamvanbk11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phamvanbk11/subscriptions","organizations_url":"https://api.github.com/users/phamvanbk11/orgs","repos_url":"https://api.github.com/users/phamvanbk11/repos","events_url":"https://api.github.com/users/phamvanbk11/events{/privacy}","received_events_url":"https://api.github.com/users/phamvanbk11/received_events","type":"User","site_admin":false},"body":"get all để làm gì đó phân trang rồi mà ","created_at":"2017-04-26T09:42:09Z","updated_at":"2017-04-26T09:42:58Z","html_url":"https://github.com/framgia/ecommerce_27/pull/17#discussion_r113407731","pull_request_url":"https://api.github.com/repos/framgia/ecommerce_27/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/framgia/ecommerce_27/pulls/comments/113407731"},"html":{"href":"https://github.com/framgia/ecommerce_27/pull/17#discussion_r113407731"},"pull_request":{"href":"https://api.github.com/repos/framgia/ecommerce_27/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/framgia/ecommerce_27/pulls/17","id":117643950,"html_url":"https://github.com/framgia/ecommerce_27/pull/17","diff_url":"https://github.com/framgia/ecommerce_27/pull/17.diff","patch_url":"https://github.com/framgia/ecommerce_27/pull/17.patch","issue_url":"https://api.github.com/repos/framgia/ecommerce_27/issues/17","number":17,"state":"open","locked":false,"title":"12. Category pages","user":{"login":"dangvanhieu2","id":26705854,"avatar_url":"https://avatars2.githubusercontent.com/u/26705854?v=3","gravatar_id":"","url":"https://api.github.com/users/dangvanhieu2","html_url":"https://github.com/dangvanhieu2","followers_url":"https://api.github.com/users/dangvanhieu2/followers","following_url":"https://api.github.com/users/dangvanhieu2/following{/other_user}","gists_url":"https://api.github.com/users/dangvanhieu2/gists{/gist_id}","starred_url":"https://api.github.com/users/dangvanhieu2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangvanhieu2/subscriptions","organizations_url":"https://api.github.com/users/dangvanhieu2/orgs","repos_url":"https://api.github.com/users/dangvanhieu2/repos","events_url":"https://api.github.com/users/dangvanhieu2/events{/privacy}","received_events_url":"https://api.github.com/users/dangvanhieu2/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-26T06:59:14Z","updated_at":"2017-04-26T09:42:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a8f5f5f9db398885c29091cd16b032ed419c704","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/framgia/ecommerce_27/pulls/17/commits","review_comments_url":"https://api.github.com/repos/framgia/ecommerce_27/pulls/17/comments","review_comment_url":"https://api.github.com/repos/framgia/ecommerce_27/pulls/comments{/number}","comments_url":"https://api.github.com/repos/framgia/ecommerce_27/issues/17/comments","statuses_url":"https://api.github.com/repos/framgia/ecommerce_27/statuses/9113400bf2383d764d51e11bb35055bd8975b0a6","head":{"label":"dangvanhieu2:rating","ref":"rating","sha":"9113400bf2383d764d51e11bb35055bd8975b0a6","user":{"login":"dangvanhieu2","id":26705854,"avatar_url":"https://avatars2.githubusercontent.com/u/26705854?v=3","gravatar_id":"","url":"https://api.github.com/users/dangvanhieu2","html_url":"https://github.com/dangvanhieu2","followers_url":"https://api.github.com/users/dangvanhieu2/followers","following_url":"https://api.github.com/users/dangvanhieu2/following{/other_user}","gists_url":"https://api.github.com/users/dangvanhieu2/gists{/gist_id}","starred_url":"https://api.github.com/users/dangvanhieu2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangvanhieu2/subscriptions","organizations_url":"https://api.github.com/users/dangvanhieu2/orgs","repos_url":"https://api.github.com/users/dangvanhieu2/repos","events_url":"https://api.github.com/users/dangvanhieu2/events{/privacy}","received_events_url":"https://api.github.com/users/dangvanhieu2/received_events","type":"User","site_admin":false},"repo":{"id":88808369,"name":"ecommerce_27","full_name":"dangvanhieu2/ecommerce_27","owner":{"login":"dangvanhieu2","id":26705854,"avatar_url":"https://avatars2.githubusercontent.com/u/26705854?v=3","gravatar_id":"","url":"https://api.github.com/users/dangvanhieu2","html_url":"https://github.com/dangvanhieu2","followers_url":"https://api.github.com/users/dangvanhieu2/followers","following_url":"https://api.github.com/users/dangvanhieu2/following{/other_user}","gists_url":"https://api.github.com/users/dangvanhieu2/gists{/gist_id}","starred_url":"https://api.github.com/users/dangvanhieu2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangvanhieu2/subscriptions","organizations_url":"https://api.github.com/users/dangvanhieu2/orgs","repos_url":"https://api.github.com/users/dangvanhieu2/repos","events_url":"https://api.github.com/users/dangvanhieu2/events{/privacy}","received_events_url":"https://api.github.com/users/dangvanhieu2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dangvanhieu2/ecommerce_27","description":null,"fork":true,"url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27","forks_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/forks","keys_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/teams","hooks_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/hooks","issue_events_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/issues/events{/number}","events_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/events","assignees_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/assignees{/user}","branches_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/branches{/branch}","tags_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/tags","blobs_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/git/refs{/sha}","trees_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/statuses/{sha}","languages_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/languages","stargazers_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/stargazers","contributors_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/contributors","subscribers_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/subscribers","subscription_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/subscription","commits_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/commits{/sha}","git_commits_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/git/commits{/sha}","comments_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/comments{/number}","issue_comment_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/issues/comments{/number}","contents_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/contents/{+path}","compare_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/merges","archive_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/downloads","issues_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/issues{/number}","pulls_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/pulls{/number}","milestones_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/milestones{/number}","notifications_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/labels{/name}","releases_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/releases{/id}","deployments_url":"https://api.github.com/repos/dangvanhieu2/ecommerce_27/deployments","created_at":"2017-04-20T01:44:36Z","updated_at":"2017-04-20T01:44:37Z","pushed_at":"2017-04-26T09:38:57Z","git_url":"git://github.com/dangvanhieu2/ecommerce_27.git","ssh_url":"[email protected]:dangvanhieu2/ecommerce_27.git","clone_url":"https://github.com/dangvanhieu2/ecommerce_27.git","svn_url":"https://github.com/dangvanhieu2/ecommerce_27","homepage":null,"size":101,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"framgia:develop","ref":"develop","sha":"89932105e42c241c75476498434b102c8be2cc23","user":{"login":"framgia","id":2322183,"avatar_url":"https://avatars0.githubusercontent.com/u/2322183?v=3","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"repo":{"id":88253729,"name":"ecommerce_27","full_name":"framgia/ecommerce_27","owner":{"login":"framgia","id":2322183,"avatar_url":"https://avatars0.githubusercontent.com/u/2322183?v=3","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/framgia/ecommerce_27","description":null,"fork":false,"url":"https://api.github.com/repos/framgia/ecommerce_27","forks_url":"https://api.github.com/repos/framgia/ecommerce_27/forks","keys_url":"https://api.github.com/repos/framgia/ecommerce_27/keys{/key_id}","collaborators_url":"https://api.github.com/repos/framgia/ecommerce_27/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/framgia/ecommerce_27/teams","hooks_url":"https://api.github.com/repos/framgia/ecommerce_27/hooks","issue_events_url":"https://api.github.com/repos/framgia/ecommerce_27/issues/events{/number}","events_url":"https://api.github.com/repos/framgia/ecommerce_27/events","assignees_url":"https://api.github.com/repos/framgia/ecommerce_27/assignees{/user}","branches_url":"https://api.github.com/repos/framgia/ecommerce_27/branches{/branch}","tags_url":"https://api.github.com/repos/framgia/ecommerce_27/tags","blobs_url":"https://api.github.com/repos/framgia/ecommerce_27/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/framgia/ecommerce_27/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/framgia/ecommerce_27/git/refs{/sha}","trees_url":"https://api.github.com/repos/framgia/ecommerce_27/git/trees{/sha}","statuses_url":"https://api.github.com/repos/framgia/ecommerce_27/statuses/{sha}","languages_url":"https://api.github.com/repos/framgia/ecommerce_27/languages","stargazers_url":"https://api.github.com/repos/framgia/ecommerce_27/stargazers","contributors_url":"https://api.github.com/repos/framgia/ecommerce_27/contributors","subscribers_url":"https://api.github.com/repos/framgia/ecommerce_27/subscribers","subscription_url":"https://api.github.com/repos/framgia/ecommerce_27/subscription","commits_url":"https://api.github.com/repos/framgia/ecommerce_27/commits{/sha}","git_commits_url":"https://api.github.com/repos/framgia/ecommerce_27/git/commits{/sha}","comments_url":"https://api.github.com/repos/framgia/ecommerce_27/comments{/number}","issue_comment_url":"https://api.github.com/repos/framgia/ecommerce_27/issues/comments{/number}","contents_url":"https://api.github.com/repos/framgia/ecommerce_27/contents/{+path}","compare_url":"https://api.github.com/repos/framgia/ecommerce_27/compare/{base}...{head}","merges_url":"https://api.github.com/repos/framgia/ecommerce_27/merges","archive_url":"https://api.github.com/repos/framgia/ecommerce_27/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/framgia/ecommerce_27/downloads","issues_url":"https://api.github.com/repos/framgia/ecommerce_27/issues{/number}","pulls_url":"https://api.github.com/repos/framgia/ecommerce_27/pulls{/number}","milestones_url":"https://api.github.com/repos/framgia/ecommerce_27/milestones{/number}","notifications_url":"https://api.github.com/repos/framgia/ecommerce_27/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/framgia/ecommerce_27/labels{/name}","releases_url":"https://api.github.com/repos/framgia/ecommerce_27/releases{/id}","deployments_url":"https://api.github.com/repos/framgia/ecommerce_27/deployments","created_at":"2017-04-14T09:24:27Z","updated_at":"2017-04-18T02:25:10Z","pushed_at":"2017-04-26T09:38:59Z","git_url":"git://github.com/framgia/ecommerce_27.git","ssh_url":"[email protected]:framgia/ecommerce_27.git","clone_url":"https://github.com/framgia/ecommerce_27.git","svn_url":"https://github.com/framgia/ecommerce_27","homepage":null,"size":95,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/framgia/ecommerce_27/pulls/17"},"html":{"href":"https://github.com/framgia/ecommerce_27/pull/17"},"issue":{"href":"https://api.github.com/repos/framgia/ecommerce_27/issues/17"},"comments":{"href":"https://api.github.com/repos/framgia/ecommerce_27/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/framgia/ecommerce_27/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/framgia/ecommerce_27/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/framgia/ecommerce_27/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/framgia/ecommerce_27/statuses/9113400bf2383d764d51e11bb35055bd8975b0a6"}}}} | {
"id": 88253729,
"name": "framgia/ecommerce_27",
"url": "https://api.github.com/repos/framgia/ecommerce_27"
} | {
"id": 10772245,
"login": "phamvanbk11",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10772245?",
"url": "https://api.github.com/users/phamvanbk11"
} | {
"id": 2322183,
"login": "framgia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2322183?",
"url": "https://api.github.com/orgs/framgia"
} | 2017-04-26T09:42:09 | 5759066103 | {"actor":{"display_login":"phamvanbk11"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/framgia/fask/pulls/comments/135692276","pull_request_review_id":59130008,"id":135692276,"diff_hunk":"@@ -175,3 +175,26 @@\n </div>\n </section>\n </div>\n+\n+<div class=\"modal fade\" id=\"modal-edit-comment\">\n+ <div class=\"modal-dialog\">\n+ <div class=\"modal-content\">\n+ <div class=\"modal-header\">\n+ <h4 class=\"modal-title\">Edit comment</h4>","path":"app/views/posts/show.html.erb","position":9,"original_position":9,"commit_id":"24e1dbd4f588db0ab2bdb81a39ee20d5bc182d92","original_commit_id":"24e1dbd4f588db0ab2bdb81a39ee20d5bc182d92","user":{"login":"tranducquoc","id":17246945,"avatar_url":"https://avatars3.githubusercontent.com/u/17246945?v=4","gravatar_id":"","url":"https://api.github.com/users/tranducquoc","html_url":"https://github.com/tranducquoc","followers_url":"https://api.github.com/users/tranducquoc/followers","following_url":"https://api.github.com/users/tranducquoc/following{/other_user}","gists_url":"https://api.github.com/users/tranducquoc/gists{/gist_id}","starred_url":"https://api.github.com/users/tranducquoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tranducquoc/subscriptions","organizations_url":"https://api.github.com/users/tranducquoc/orgs","repos_url":"https://api.github.com/users/tranducquoc/repos","events_url":"https://api.github.com/users/tranducquoc/events{/privacy}","received_events_url":"https://api.github.com/users/tranducquoc/received_events","type":"User","site_admin":false},"body":"I18n","created_at":"2017-08-29T04:50:11Z","updated_at":"2017-08-29T04:50:19Z","html_url":"https://github.com/framgia/fask/pull/63#discussion_r135692276","pull_request_url":"https://api.github.com/repos/framgia/fask/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/framgia/fask/pulls/comments/135692276"},"html":{"href":"https://github.com/framgia/fask/pull/63#discussion_r135692276"},"pull_request":{"href":"https://api.github.com/repos/framgia/fask/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/framgia/fask/pulls/63","id":138083935,"html_url":"https://github.com/framgia/fask/pull/63","diff_url":"https://github.com/framgia/fask/pull/63.diff","patch_url":"https://github.com/framgia/fask/pull/63.patch","issue_url":"https://api.github.com/repos/framgia/fask/issues/63","number":63,"state":"open","locked":false,"title":"function edit/delete comment","user":{"login":"phamthanhluan125","id":25578168,"avatar_url":"https://avatars1.githubusercontent.com/u/25578168?v=4","gravatar_id":"","url":"https://api.github.com/users/phamthanhluan125","html_url":"https://github.com/phamthanhluan125","followers_url":"https://api.github.com/users/phamthanhluan125/followers","following_url":"https://api.github.com/users/phamthanhluan125/following{/other_user}","gists_url":"https://api.github.com/users/phamthanhluan125/gists{/gist_id}","starred_url":"https://api.github.com/users/phamthanhluan125/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phamthanhluan125/subscriptions","organizations_url":"https://api.github.com/users/phamthanhluan125/orgs","repos_url":"https://api.github.com/users/phamthanhluan125/repos","events_url":"https://api.github.com/users/phamthanhluan125/events{/privacy}","received_events_url":"https://api.github.com/users/phamthanhluan125/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-29T03:37:34Z","updated_at":"2017-08-29T04:50:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44af8d0a5a6a4bc39ff6678be47ab95a4b2a2d85","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/framgia/fask/pulls/63/commits","review_comments_url":"https://api.github.com/repos/framgia/fask/pulls/63/comments","review_comment_url":"https://api.github.com/repos/framgia/fask/pulls/comments{/number}","comments_url":"https://api.github.com/repos/framgia/fask/issues/63/comments","statuses_url":"https://api.github.com/repos/framgia/fask/statuses/24e1dbd4f588db0ab2bdb81a39ee20d5bc182d92","head":{"label":"phamthanhluan125:function_edit_delete_comment","ref":"function_edit_delete_comment","sha":"24e1dbd4f588db0ab2bdb81a39ee20d5bc182d92","user":{"login":"phamthanhluan125","id":25578168,"avatar_url":"https://avatars1.githubusercontent.com/u/25578168?v=4","gravatar_id":"","url":"https://api.github.com/users/phamthanhluan125","html_url":"https://github.com/phamthanhluan125","followers_url":"https://api.github.com/users/phamthanhluan125/followers","following_url":"https://api.github.com/users/phamthanhluan125/following{/other_user}","gists_url":"https://api.github.com/users/phamthanhluan125/gists{/gist_id}","starred_url":"https://api.github.com/users/phamthanhluan125/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phamthanhluan125/subscriptions","organizations_url":"https://api.github.com/users/phamthanhluan125/orgs","repos_url":"https://api.github.com/users/phamthanhluan125/repos","events_url":"https://api.github.com/users/phamthanhluan125/events{/privacy}","received_events_url":"https://api.github.com/users/phamthanhluan125/received_events","type":"User","site_admin":false},"repo":{"id":97190928,"name":"fask","full_name":"phamthanhluan125/fask","owner":{"login":"phamthanhluan125","id":25578168,"avatar_url":"https://avatars1.githubusercontent.com/u/25578168?v=4","gravatar_id":"","url":"https://api.github.com/users/phamthanhluan125","html_url":"https://github.com/phamthanhluan125","followers_url":"https://api.github.com/users/phamthanhluan125/followers","following_url":"https://api.github.com/users/phamthanhluan125/following{/other_user}","gists_url":"https://api.github.com/users/phamthanhluan125/gists{/gist_id}","starred_url":"https://api.github.com/users/phamthanhluan125/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phamthanhluan125/subscriptions","organizations_url":"https://api.github.com/users/phamthanhluan125/orgs","repos_url":"https://api.github.com/users/phamthanhluan125/repos","events_url":"https://api.github.com/users/phamthanhluan125/events{/privacy}","received_events_url":"https://api.github.com/users/phamthanhluan125/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phamthanhluan125/fask","description":null,"fork":true,"url":"https://api.github.com/repos/phamthanhluan125/fask","forks_url":"https://api.github.com/repos/phamthanhluan125/fask/forks","keys_url":"https://api.github.com/repos/phamthanhluan125/fask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phamthanhluan125/fask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phamthanhluan125/fask/teams","hooks_url":"https://api.github.com/repos/phamthanhluan125/fask/hooks","issue_events_url":"https://api.github.com/repos/phamthanhluan125/fask/issues/events{/number}","events_url":"https://api.github.com/repos/phamthanhluan125/fask/events","assignees_url":"https://api.github.com/repos/phamthanhluan125/fask/assignees{/user}","branches_url":"https://api.github.com/repos/phamthanhluan125/fask/branches{/branch}","tags_url":"https://api.github.com/repos/phamthanhluan125/fask/tags","blobs_url":"https://api.github.com/repos/phamthanhluan125/fask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phamthanhluan125/fask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phamthanhluan125/fask/git/refs{/sha}","trees_url":"https://api.github.com/repos/phamthanhluan125/fask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phamthanhluan125/fask/statuses/{sha}","languages_url":"https://api.github.com/repos/phamthanhluan125/fask/languages","stargazers_url":"https://api.github.com/repos/phamthanhluan125/fask/stargazers","contributors_url":"https://api.github.com/repos/phamthanhluan125/fask/contributors","subscribers_url":"https://api.github.com/repos/phamthanhluan125/fask/subscribers","subscription_url":"https://api.github.com/repos/phamthanhluan125/fask/subscription","commits_url":"https://api.github.com/repos/phamthanhluan125/fask/commits{/sha}","git_commits_url":"https://api.github.com/repos/phamthanhluan125/fask/git/commits{/sha}","comments_url":"https://api.github.com/repos/phamthanhluan125/fask/comments{/number}","issue_comment_url":"https://api.github.com/repos/phamthanhluan125/fask/issues/comments{/number}","contents_url":"https://api.github.com/repos/phamthanhluan125/fask/contents/{+path}","compare_url":"https://api.github.com/repos/phamthanhluan125/fask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phamthanhluan125/fask/merges","archive_url":"https://api.github.com/repos/phamthanhluan125/fask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phamthanhluan125/fask/downloads","issues_url":"https://api.github.com/repos/phamthanhluan125/fask/issues{/number}","pulls_url":"https://api.github.com/repos/phamthanhluan125/fask/pulls{/number}","milestones_url":"https://api.github.com/repos/phamthanhluan125/fask/milestones{/number}","notifications_url":"https://api.github.com/repos/phamthanhluan125/fask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phamthanhluan125/fask/labels{/name}","releases_url":"https://api.github.com/repos/phamthanhluan125/fask/releases{/id}","deployments_url":"https://api.github.com/repos/phamthanhluan125/fask/deployments","created_at":"2017-07-14T03:53:26Z","updated_at":"2017-07-14T03:53:27Z","pushed_at":"2017-08-29T04:22:40Z","git_url":"git://github.com/phamthanhluan125/fask.git","ssh_url":"[email protected]:phamthanhluan125/fask.git","clone_url":"https://github.com/phamthanhluan125/fask.git","svn_url":"https://github.com/phamthanhluan125/fask","homepage":null,"size":4147,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"framgia:develop","ref":"develop","sha":"b4988bceb25ece4a537c7f70f87be2504125d2d8","user":{"login":"framgia","id":2322183,"avatar_url":"https://avatars3.githubusercontent.com/u/2322183?v=4","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"repo":{"id":97179403,"name":"fask","full_name":"framgia/fask","owner":{"login":"framgia","id":2322183,"avatar_url":"https://avatars3.githubusercontent.com/u/2322183?v=4","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/framgia/fask","description":null,"fork":false,"url":"https://api.github.com/repos/framgia/fask","forks_url":"https://api.github.com/repos/framgia/fask/forks","keys_url":"https://api.github.com/repos/framgia/fask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/framgia/fask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/framgia/fask/teams","hooks_url":"https://api.github.com/repos/framgia/fask/hooks","issue_events_url":"https://api.github.com/repos/framgia/fask/issues/events{/number}","events_url":"https://api.github.com/repos/framgia/fask/events","assignees_url":"https://api.github.com/repos/framgia/fask/assignees{/user}","branches_url":"https://api.github.com/repos/framgia/fask/branches{/branch}","tags_url":"https://api.github.com/repos/framgia/fask/tags","blobs_url":"https://api.github.com/repos/framgia/fask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/framgia/fask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/framgia/fask/git/refs{/sha}","trees_url":"https://api.github.com/repos/framgia/fask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/framgia/fask/statuses/{sha}","languages_url":"https://api.github.com/repos/framgia/fask/languages","stargazers_url":"https://api.github.com/repos/framgia/fask/stargazers","contributors_url":"https://api.github.com/repos/framgia/fask/contributors","subscribers_url":"https://api.github.com/repos/framgia/fask/subscribers","subscription_url":"https://api.github.com/repos/framgia/fask/subscription","commits_url":"https://api.github.com/repos/framgia/fask/commits{/sha}","git_commits_url":"https://api.github.com/repos/framgia/fask/git/commits{/sha}","comments_url":"https://api.github.com/repos/framgia/fask/comments{/number}","issue_comment_url":"https://api.github.com/repos/framgia/fask/issues/comments{/number}","contents_url":"https://api.github.com/repos/framgia/fask/contents/{+path}","compare_url":"https://api.github.com/repos/framgia/fask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/framgia/fask/merges","archive_url":"https://api.github.com/repos/framgia/fask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/framgia/fask/downloads","issues_url":"https://api.github.com/repos/framgia/fask/issues{/number}","pulls_url":"https://api.github.com/repos/framgia/fask/pulls{/number}","milestones_url":"https://api.github.com/repos/framgia/fask/milestones{/number}","notifications_url":"https://api.github.com/repos/framgia/fask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/framgia/fask/labels{/name}","releases_url":"https://api.github.com/repos/framgia/fask/releases{/id}","deployments_url":"https://api.github.com/repos/framgia/fask/deployments","created_at":"2017-07-14T01:24:15Z","updated_at":"2017-08-04T02:17:05Z","pushed_at":"2017-08-29T04:22:41Z","git_url":"git://github.com/framgia/fask.git","ssh_url":"[email protected]:framgia/fask.git","clone_url":"https://github.com/framgia/fask.git","svn_url":"https://github.com/framgia/fask","homepage":null,"size":4127,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/framgia/fask/pulls/63"},"html":{"href":"https://github.com/framgia/fask/pull/63"},"issue":{"href":"https://api.github.com/repos/framgia/fask/issues/63"},"comments":{"href":"https://api.github.com/repos/framgia/fask/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/framgia/fask/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/framgia/fask/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/framgia/fask/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/framgia/fask/statuses/24e1dbd4f588db0ab2bdb81a39ee20d5bc182d92"}}}} | {
"id": 97179403,
"name": "framgia/fask",
"url": "https://api.github.com/repos/framgia/fask"
} | {
"id": 17246945,
"login": "tranducquoc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17246945?",
"url": "https://api.github.com/users/tranducquoc"
} | {
"id": 2322183,
"login": "framgia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2322183?",
"url": "https://api.github.com/orgs/framgia"
} | 2017-08-29T04:50:11 | 6522742600 | {"actor":{"display_login":"tranducquoc"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/framgia/management_devise_01/pulls/comments/123285532","pull_request_review_id":45474036,"id":123285532,"diff_hunk":"@@ -39,31 +33,35 @@ def update\n render json: {status: 200, error: false, message: \"\",\n data: @device.load_structure}, status: 200","path":"app/controllers/api/v1/devices_controller.rb","position":52,"original_position":52,"commit_id":"178f96aec3ed9d241dfc04e477c81144459a1f25","original_commit_id":"178f96aec3ed9d241dfc04e477c81144459a1f25","user":{"login":"framgia-jenkins-ci","id":16641396,"avatar_url":"https://avatars3.githubusercontent.com/u/16641396?v=3","gravatar_id":"","url":"https://api.github.com/users/framgia-jenkins-ci","html_url":"https://github.com/framgia-jenkins-ci","followers_url":"https://api.github.com/users/framgia-jenkins-ci/followers","following_url":"https://api.github.com/users/framgia-jenkins-ci/following{/other_user}","gists_url":"https://api.github.com/users/framgia-jenkins-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia-jenkins-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia-jenkins-ci/subscriptions","organizations_url":"https://api.github.com/users/framgia-jenkins-ci/orgs","repos_url":"https://api.github.com/users/framgia-jenkins-ci/repos","events_url":"https://api.github.com/users/framgia-jenkins-ci/events{/privacy}","received_events_url":"https://api.github.com/users/framgia-jenkins-ci/received_events","type":"User","site_admin":false},"body":"**Reporter**: CHECKSTYLE\n**Rule**: com.puppycrawl.tools.checkstyle.Style/AlignHash\n**Severity**: INFO\n**File**: app/controllers/api/v1/devices_controller.rb L34\n\nAlign the elements of a hash literal if they span more than one line.\n\n*<this is a auto generated comment from violation-comments-lib F7F8ASD8123FSDF>*\n","created_at":"2017-06-21T15:37:45Z","updated_at":"2017-06-21T15:37:45Z","html_url":"https://github.com/framgia/management_devise_01/pull/208#discussion_r123285532","pull_request_url":"https://api.github.com/repos/framgia/management_devise_01/pulls/208","_links":{"self":{"href":"https://api.github.com/repos/framgia/management_devise_01/pulls/comments/123285532"},"html":{"href":"https://github.com/framgia/management_devise_01/pull/208#discussion_r123285532"},"pull_request":{"href":"https://api.github.com/repos/framgia/management_devise_01/pulls/208"}}},"pull_request":{"url":"https://api.github.com/repos/framgia/management_devise_01/pulls/208","id":126775784,"html_url":"https://github.com/framgia/management_devise_01/pull/208","diff_url":"https://github.com/framgia/management_devise_01/pull/208.diff","patch_url":"https://github.com/framgia/management_devise_01/pull/208.patch","issue_url":"https://api.github.com/repos/framgia/management_devise_01/issues/208","number":208,"state":"open","locked":false,"title":"Refactor api","user":{"login":"hellovietnam93","id":8023606,"avatar_url":"https://avatars2.githubusercontent.com/u/8023606?v=3","gravatar_id":"","url":"https://api.github.com/users/hellovietnam93","html_url":"https://github.com/hellovietnam93","followers_url":"https://api.github.com/users/hellovietnam93/followers","following_url":"https://api.github.com/users/hellovietnam93/following{/other_user}","gists_url":"https://api.github.com/users/hellovietnam93/gists{/gist_id}","starred_url":"https://api.github.com/users/hellovietnam93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellovietnam93/subscriptions","organizations_url":"https://api.github.com/users/hellovietnam93/orgs","repos_url":"https://api.github.com/users/hellovietnam93/repos","events_url":"https://api.github.com/users/hellovietnam93/events{/privacy}","received_events_url":"https://api.github.com/users/hellovietnam93/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-21T14:19:23Z","updated_at":"2017-06-21T15:37:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89ce1139f21dfb4af3a9ff23ba41d26e419c256c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/framgia/management_devise_01/pulls/208/commits","review_comments_url":"https://api.github.com/repos/framgia/management_devise_01/pulls/208/comments","review_comment_url":"https://api.github.com/repos/framgia/management_devise_01/pulls/comments{/number}","comments_url":"https://api.github.com/repos/framgia/management_devise_01/issues/208/comments","statuses_url":"https://api.github.com/repos/framgia/management_devise_01/statuses/178f96aec3ed9d241dfc04e477c81144459a1f25","head":{"label":"hellovietnam93:refactor-api","ref":"refactor-api","sha":"178f96aec3ed9d241dfc04e477c81144459a1f25","user":{"login":"hellovietnam93","id":8023606,"avatar_url":"https://avatars2.githubusercontent.com/u/8023606?v=3","gravatar_id":"","url":"https://api.github.com/users/hellovietnam93","html_url":"https://github.com/hellovietnam93","followers_url":"https://api.github.com/users/hellovietnam93/followers","following_url":"https://api.github.com/users/hellovietnam93/following{/other_user}","gists_url":"https://api.github.com/users/hellovietnam93/gists{/gist_id}","starred_url":"https://api.github.com/users/hellovietnam93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellovietnam93/subscriptions","organizations_url":"https://api.github.com/users/hellovietnam93/orgs","repos_url":"https://api.github.com/users/hellovietnam93/repos","events_url":"https://api.github.com/users/hellovietnam93/events{/privacy}","received_events_url":"https://api.github.com/users/hellovietnam93/received_events","type":"User","site_admin":false},"repo":{"id":95003060,"name":"management_devise_01","full_name":"hellovietnam93/management_devise_01","owner":{"login":"hellovietnam93","id":8023606,"avatar_url":"https://avatars2.githubusercontent.com/u/8023606?v=3","gravatar_id":"","url":"https://api.github.com/users/hellovietnam93","html_url":"https://github.com/hellovietnam93","followers_url":"https://api.github.com/users/hellovietnam93/followers","following_url":"https://api.github.com/users/hellovietnam93/following{/other_user}","gists_url":"https://api.github.com/users/hellovietnam93/gists{/gist_id}","starred_url":"https://api.github.com/users/hellovietnam93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellovietnam93/subscriptions","organizations_url":"https://api.github.com/users/hellovietnam93/orgs","repos_url":"https://api.github.com/users/hellovietnam93/repos","events_url":"https://api.github.com/users/hellovietnam93/events{/privacy}","received_events_url":"https://api.github.com/users/hellovietnam93/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hellovietnam93/management_devise_01","description":null,"fork":true,"url":"https://api.github.com/repos/hellovietnam93/management_devise_01","forks_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/forks","keys_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/teams","hooks_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/hooks","issue_events_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/issues/events{/number}","events_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/events","assignees_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/assignees{/user}","branches_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/branches{/branch}","tags_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/tags","blobs_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/git/refs{/sha}","trees_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/statuses/{sha}","languages_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/languages","stargazers_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/stargazers","contributors_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/contributors","subscribers_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/subscribers","subscription_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/subscription","commits_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/commits{/sha}","git_commits_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/git/commits{/sha}","comments_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/comments{/number}","issue_comment_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/issues/comments{/number}","contents_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/contents/{+path}","compare_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/merges","archive_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/downloads","issues_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/issues{/number}","pulls_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/pulls{/number}","milestones_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/milestones{/number}","notifications_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/labels{/name}","releases_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/releases{/id}","deployments_url":"https://api.github.com/repos/hellovietnam93/management_devise_01/deployments","created_at":"2017-06-21T12:44:39Z","updated_at":"2017-06-21T12:44:41Z","pushed_at":"2017-06-21T15:35:15Z","git_url":"git://github.com/hellovietnam93/management_devise_01.git","ssh_url":"[email protected]:hellovietnam93/management_devise_01.git","clone_url":"https://github.com/hellovietnam93/management_devise_01.git","svn_url":"https://github.com/hellovietnam93/management_devise_01","homepage":null,"size":2828,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"framgia:develop","ref":"develop","sha":"facf5729180e83e9105e53dd2620ee22dbf56703","user":{"login":"framgia","id":2322183,"avatar_url":"https://avatars0.githubusercontent.com/u/2322183?v=3","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"repo":{"id":78728423,"name":"management_devise_01","full_name":"framgia/management_devise_01","owner":{"login":"framgia","id":2322183,"avatar_url":"https://avatars0.githubusercontent.com/u/2322183?v=3","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/framgia/management_devise_01","description":null,"fork":false,"url":"https://api.github.com/repos/framgia/management_devise_01","forks_url":"https://api.github.com/repos/framgia/management_devise_01/forks","keys_url":"https://api.github.com/repos/framgia/management_devise_01/keys{/key_id}","collaborators_url":"https://api.github.com/repos/framgia/management_devise_01/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/framgia/management_devise_01/teams","hooks_url":"https://api.github.com/repos/framgia/management_devise_01/hooks","issue_events_url":"https://api.github.com/repos/framgia/management_devise_01/issues/events{/number}","events_url":"https://api.github.com/repos/framgia/management_devise_01/events","assignees_url":"https://api.github.com/repos/framgia/management_devise_01/assignees{/user}","branches_url":"https://api.github.com/repos/framgia/management_devise_01/branches{/branch}","tags_url":"https://api.github.com/repos/framgia/management_devise_01/tags","blobs_url":"https://api.github.com/repos/framgia/management_devise_01/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/framgia/management_devise_01/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/framgia/management_devise_01/git/refs{/sha}","trees_url":"https://api.github.com/repos/framgia/management_devise_01/git/trees{/sha}","statuses_url":"https://api.github.com/repos/framgia/management_devise_01/statuses/{sha}","languages_url":"https://api.github.com/repos/framgia/management_devise_01/languages","stargazers_url":"https://api.github.com/repos/framgia/management_devise_01/stargazers","contributors_url":"https://api.github.com/repos/framgia/management_devise_01/contributors","subscribers_url":"https://api.github.com/repos/framgia/management_devise_01/subscribers","subscription_url":"https://api.github.com/repos/framgia/management_devise_01/subscription","commits_url":"https://api.github.com/repos/framgia/management_devise_01/commits{/sha}","git_commits_url":"https://api.github.com/repos/framgia/management_devise_01/git/commits{/sha}","comments_url":"https://api.github.com/repos/framgia/management_devise_01/comments{/number}","issue_comment_url":"https://api.github.com/repos/framgia/management_devise_01/issues/comments{/number}","contents_url":"https://api.github.com/repos/framgia/management_devise_01/contents/{+path}","compare_url":"https://api.github.com/repos/framgia/management_devise_01/compare/{base}...{head}","merges_url":"https://api.github.com/repos/framgia/management_devise_01/merges","archive_url":"https://api.github.com/repos/framgia/management_devise_01/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/framgia/management_devise_01/downloads","issues_url":"https://api.github.com/repos/framgia/management_devise_01/issues{/number}","pulls_url":"https://api.github.com/repos/framgia/management_devise_01/pulls{/number}","milestones_url":"https://api.github.com/repos/framgia/management_devise_01/milestones{/number}","notifications_url":"https://api.github.com/repos/framgia/management_devise_01/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/framgia/management_devise_01/labels{/name}","releases_url":"https://api.github.com/repos/framgia/management_devise_01/releases{/id}","deployments_url":"https://api.github.com/repos/framgia/management_devise_01/deployments","created_at":"2017-01-12T09:24:48Z","updated_at":"2017-02-16T13:24:43Z","pushed_at":"2017-06-21T15:35:17Z","git_url":"git://github.com/framgia/management_devise_01.git","ssh_url":"[email protected]:framgia/management_devise_01.git","clone_url":"https://github.com/framgia/management_devise_01.git","svn_url":"https://github.com/framgia/management_devise_01","homepage":null,"size":2823,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":16,"forks":19,"open_issues":16,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/framgia/management_devise_01/pulls/208"},"html":{"href":"https://github.com/framgia/management_devise_01/pull/208"},"issue":{"href":"https://api.github.com/repos/framgia/management_devise_01/issues/208"},"comments":{"href":"https://api.github.com/repos/framgia/management_devise_01/issues/208/comments"},"review_comments":{"href":"https://api.github.com/repos/framgia/management_devise_01/pulls/208/comments"},"review_comment":{"href":"https://api.github.com/repos/framgia/management_devise_01/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/framgia/management_devise_01/pulls/208/commits"},"statuses":{"href":"https://api.github.com/repos/framgia/management_devise_01/statuses/178f96aec3ed9d241dfc04e477c81144459a1f25"}}}} | {
"id": 78728423,
"name": "framgia/management_devise_01",
"url": "https://api.github.com/repos/framgia/management_devise_01"
} | {
"id": 16641396,
"login": "framgia-jenkins-ci",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16641396?",
"url": "https://api.github.com/users/framgia-jenkins-ci"
} | {
"id": 2322183,
"login": "framgia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2322183?",
"url": "https://api.github.com/orgs/framgia"
} | 2017-06-21T15:37:45 | 6110767455 | {"actor":{"display_login":"framgia-jenkins-ci"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/framgia/fbt_13/pulls/comments/156256209","pull_request_review_id":82702650,"id":156256209,"diff_hunk":"@@ -1,39 +1,74 @@\n-<% provide :button_text, t(\".button\") %>\n-<header class=\"navbar navbar-fixed-top navbar-default\">\n+<% provide :button, t(\".button\") %>\n+<header class=\"navbar\">\n <div class=\"container\">\n <nav class=\"row\">\n- <div class=\"logo col-md-4\">\n- <%= link_to image_tag(\"logo.png\", alt: \"Booking Your Travel\"), \"http://localhost:3000/\" %>\n+ <div class=\"logo col-md-3\" data-toggle=\"tooltip\" data-placement=\"bottom\" >\n+ <%= link_to image_tag((t \".logo\"), alt: (t \".load_picture\")), (t \".url\") %>\n </div>\n- <div class=\"col-md-7\">\n- <ul class=\"nav navbar-nav navbar-right\">\n- <li><%= link_to t(\".home\"), \"#\" %></li>\n- <li><%= link_to t(\".help\"), \"#\" %></li>\n+ <div class=\"col-md-4\">\n+ <ul class=\"nav navbar-nav menu-main\">\n+ <li><%= link_to t(\".home\"), root_path, class: \"active a\" %></li>\n+ <li><%= link_to t(\".tours\"), tours_path, class: \"a\" %></li>\n+ <li><%= link_to t(\".help\"), \"#\", class: \"a\" %></li>\n+ <li><%= link_to t(\".contact\"), \"#\", class: \"a\" %></li>\n+ </ul>\n+ </div>\n+ <div class=\"col-md-4\">\n+ <div class=\"nav navbar-nav navbar-right\">\n <% if @current_user.present? %>\n- <li><h6><span><%=@current_user.name_user%></span></h6></li>\n- <li class=\"dropdown\">\n- <a class=\"dropdown-toggle\" data-toggle=\"dropdown\" href=\"#\">\n- <i class=\"fa fa-user icon-side-bar\"></i><i class=\"fa fa-angle-down\"></i>\n- </a>\n- <ul class=\"dropdown-menu dropdown-user\">\n- <li>\n- <i class=\"fa fa-user user-dropdown icon-side-bar\">\n- <%= link_to t(\".user\"), user_path(@current_user)%>\n- </i>\n- </li>\n- <li><i class=\"fa fa-cog user-dropdown icon-side-bar\"><%= link_to t(\".settings\"), edit_user_path(@current_user) %></i>\n- </li>\n- <li class=\"divider\"></li>\n- <li><i class=\"fa fa-sign-out user-dropdown icon-side-bar\"><%= link_to t(\".logout\"), logout_path %></i>\n- </li>\n- </ul>\n- </li>\n- <% else %>\n- <li><%= link_to t(\".login\"), login_path %></li>\n+ <ul>\n+ <li></li>\n+ <li class=\"dropdown\">\n+ <%= t \".hi\" %><span><%= @current_user.name_user %></span>\n+ <a class=\"dropdown-toggle\" data-toggle=\"dropdown\" href=\"#\">\n+ <i class=\"fa fa-user icon-side-bar\"></i><i class=\"fa fa-angle-down\"></i>\n+ </a>\n+ <ul class=\"dropdown-menu dropdown-user\">\n+ <li>\n+ <i class=\"fa fa-user user-dropdown icon-side-bar\"><%= link_to t(\".user\"), user_path(@current_user) %></i>\n+ </li>\n+ <li>\n+ <i class=\"fa fa-cog user-dropdown icon-side-bar\"><%= link_to t(\".settings\"), edit_user_path(@current_user) %></i>\n+ </li>\n+ <li class=\"divider\"></li>\n+ <li><i class=\"fa fa-sign-out user-dropdown icon-side-bar\"><%= link_to t(\".logout\"), logout_path %></i>\n+ </li>\n+ </ul>\n+ </li>\n+ </ul>\n+ <%else%>","path":"app/views/layouts/_header.html.erb","position":67,"original_position":67,"commit_id":"995671e92ae5ca06ba00bd51c0cde95814833388","original_commit_id":"070ffa9d663778e8421cc0bb0ec483a76ae6fca4","user":{"login":"dothidiemthao","id":21377118,"avatar_url":"https://avatars0.githubusercontent.com/u/21377118?v=4","gravatar_id":"","url":"https://api.github.com/users/dothidiemthao","html_url":"https://github.com/dothidiemthao","followers_url":"https://api.github.com/users/dothidiemthao/followers","following_url":"https://api.github.com/users/dothidiemthao/following{/other_user}","gists_url":"https://api.github.com/users/dothidiemthao/gists{/gist_id}","starred_url":"https://api.github.com/users/dothidiemthao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dothidiemthao/subscriptions","organizations_url":"https://api.github.com/users/dothidiemthao/orgs","repos_url":"https://api.github.com/users/dothidiemthao/repos","events_url":"https://api.github.com/users/dothidiemthao/events{/privacy}","received_events_url":"https://api.github.com/users/dothidiemthao/received_events","type":"User","site_admin":false},"body":"sai space","created_at":"2017-12-12T02:16:11Z","updated_at":"2017-12-12T02:24:11Z","html_url":"https://github.com/framgia/fbt_13/pull/18#discussion_r156256209","pull_request_url":"https://api.github.com/repos/framgia/fbt_13/pulls/18","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/framgia/fbt_13/pulls/comments/156256209"},"html":{"href":"https://github.com/framgia/fbt_13/pull/18#discussion_r156256209"},"pull_request":{"href":"https://api.github.com/repos/framgia/fbt_13/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/framgia/fbt_13/pulls/18","id":157610587,"html_url":"https://github.com/framgia/fbt_13/pull/18","diff_url":"https://github.com/framgia/fbt_13/pull/18.diff","patch_url":"https://github.com/framgia/fbt_13/pull/18.patch","issue_url":"https://api.github.com/repos/framgia/fbt_13/issues/18","number":18,"state":"open","locked":false,"title":"pull search tour main","user":{"login":"NuongNguyen1996","id":31896210,"avatar_url":"https://avatars0.githubusercontent.com/u/31896210?v=4","gravatar_id":"","url":"https://api.github.com/users/NuongNguyen1996","html_url":"https://github.com/NuongNguyen1996","followers_url":"https://api.github.com/users/NuongNguyen1996/followers","following_url":"https://api.github.com/users/NuongNguyen1996/following{/other_user}","gists_url":"https://api.github.com/users/NuongNguyen1996/gists{/gist_id}","starred_url":"https://api.github.com/users/NuongNguyen1996/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuongNguyen1996/subscriptions","organizations_url":"https://api.github.com/users/NuongNguyen1996/orgs","repos_url":"https://api.github.com/users/NuongNguyen1996/repos","events_url":"https://api.github.com/users/NuongNguyen1996/events{/privacy}","received_events_url":"https://api.github.com/users/NuongNguyen1996/received_events","type":"User","site_admin":false},"body":"\r\n","created_at":"2017-12-11T16:31:48Z","updated_at":"2017-12-12T02:24:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a93ecd97e66f1761efb404228cadb0a559670a88","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/framgia/fbt_13/pulls/18/commits","review_comments_url":"https://api.github.com/repos/framgia/fbt_13/pulls/18/comments","review_comment_url":"https://api.github.com/repos/framgia/fbt_13/pulls/comments{/number}","comments_url":"https://api.github.com/repos/framgia/fbt_13/issues/18/comments","statuses_url":"https://api.github.com/repos/framgia/fbt_13/statuses/995671e92ae5ca06ba00bd51c0cde95814833388","head":{"label":"NuongNguyen1996:fix-search-tours-controller","ref":"fix-search-tours-controller","sha":"995671e92ae5ca06ba00bd51c0cde95814833388","user":{"login":"NuongNguyen1996","id":31896210,"avatar_url":"https://avatars0.githubusercontent.com/u/31896210?v=4","gravatar_id":"","url":"https://api.github.com/users/NuongNguyen1996","html_url":"https://github.com/NuongNguyen1996","followers_url":"https://api.github.com/users/NuongNguyen1996/followers","following_url":"https://api.github.com/users/NuongNguyen1996/following{/other_user}","gists_url":"https://api.github.com/users/NuongNguyen1996/gists{/gist_id}","starred_url":"https://api.github.com/users/NuongNguyen1996/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuongNguyen1996/subscriptions","organizations_url":"https://api.github.com/users/NuongNguyen1996/orgs","repos_url":"https://api.github.com/users/NuongNguyen1996/repos","events_url":"https://api.github.com/users/NuongNguyen1996/events{/privacy}","received_events_url":"https://api.github.com/users/NuongNguyen1996/received_events","type":"User","site_admin":false},"repo":{"id":112547202,"name":"fbt_13","full_name":"NuongNguyen1996/fbt_13","owner":{"login":"NuongNguyen1996","id":31896210,"avatar_url":"https://avatars0.githubusercontent.com/u/31896210?v=4","gravatar_id":"","url":"https://api.github.com/users/NuongNguyen1996","html_url":"https://github.com/NuongNguyen1996","followers_url":"https://api.github.com/users/NuongNguyen1996/followers","following_url":"https://api.github.com/users/NuongNguyen1996/following{/other_user}","gists_url":"https://api.github.com/users/NuongNguyen1996/gists{/gist_id}","starred_url":"https://api.github.com/users/NuongNguyen1996/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuongNguyen1996/subscriptions","organizations_url":"https://api.github.com/users/NuongNguyen1996/orgs","repos_url":"https://api.github.com/users/NuongNguyen1996/repos","events_url":"https://api.github.com/users/NuongNguyen1996/events{/privacy}","received_events_url":"https://api.github.com/users/NuongNguyen1996/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NuongNguyen1996/fbt_13","description":null,"fork":true,"url":"https://api.github.com/repos/NuongNguyen1996/fbt_13","forks_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/forks","keys_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/teams","hooks_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/hooks","issue_events_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/issues/events{/number}","events_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/events","assignees_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/assignees{/user}","branches_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/branches{/branch}","tags_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/tags","blobs_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/statuses/{sha}","languages_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/languages","stargazers_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/stargazers","contributors_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/contributors","subscribers_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/subscribers","subscription_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/subscription","commits_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/contents/{+path}","compare_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/merges","archive_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/downloads","issues_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/issues{/number}","pulls_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/pulls{/number}","milestones_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/milestones{/number}","notifications_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/labels{/name}","releases_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/releases{/id}","deployments_url":"https://api.github.com/repos/NuongNguyen1996/fbt_13/deployments","created_at":"2017-11-30T01:13:03Z","updated_at":"2017-11-30T01:13:04Z","pushed_at":"2017-12-12T02:06:20Z","git_url":"git://github.com/NuongNguyen1996/fbt_13.git","ssh_url":"[email protected]:NuongNguyen1996/fbt_13.git","clone_url":"https://github.com/NuongNguyen1996/fbt_13.git","svn_url":"https://github.com/NuongNguyen1996/fbt_13","homepage":null,"size":394,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"framgia:develop","ref":"develop","sha":"4fd7730acb48b42dad2384e1d510a5d7b865119b","user":{"login":"framgia","id":2322183,"avatar_url":"https://avatars3.githubusercontent.com/u/2322183?v=4","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"repo":{"id":112408092,"name":"fbt_13","full_name":"framgia/fbt_13","owner":{"login":"framgia","id":2322183,"avatar_url":"https://avatars3.githubusercontent.com/u/2322183?v=4","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/framgia/fbt_13","description":null,"fork":false,"url":"https://api.github.com/repos/framgia/fbt_13","forks_url":"https://api.github.com/repos/framgia/fbt_13/forks","keys_url":"https://api.github.com/repos/framgia/fbt_13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/framgia/fbt_13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/framgia/fbt_13/teams","hooks_url":"https://api.github.com/repos/framgia/fbt_13/hooks","issue_events_url":"https://api.github.com/repos/framgia/fbt_13/issues/events{/number}","events_url":"https://api.github.com/repos/framgia/fbt_13/events","assignees_url":"https://api.github.com/repos/framgia/fbt_13/assignees{/user}","branches_url":"https://api.github.com/repos/framgia/fbt_13/branches{/branch}","tags_url":"https://api.github.com/repos/framgia/fbt_13/tags","blobs_url":"https://api.github.com/repos/framgia/fbt_13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/framgia/fbt_13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/framgia/fbt_13/git/refs{/sha}","trees_url":"https://api.github.com/repos/framgia/fbt_13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/framgia/fbt_13/statuses/{sha}","languages_url":"https://api.github.com/repos/framgia/fbt_13/languages","stargazers_url":"https://api.github.com/repos/framgia/fbt_13/stargazers","contributors_url":"https://api.github.com/repos/framgia/fbt_13/contributors","subscribers_url":"https://api.github.com/repos/framgia/fbt_13/subscribers","subscription_url":"https://api.github.com/repos/framgia/fbt_13/subscription","commits_url":"https://api.github.com/repos/framgia/fbt_13/commits{/sha}","git_commits_url":"https://api.github.com/repos/framgia/fbt_13/git/commits{/sha}","comments_url":"https://api.github.com/repos/framgia/fbt_13/comments{/number}","issue_comment_url":"https://api.github.com/repos/framgia/fbt_13/issues/comments{/number}","contents_url":"https://api.github.com/repos/framgia/fbt_13/contents/{+path}","compare_url":"https://api.github.com/repos/framgia/fbt_13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/framgia/fbt_13/merges","archive_url":"https://api.github.com/repos/framgia/fbt_13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/framgia/fbt_13/downloads","issues_url":"https://api.github.com/repos/framgia/fbt_13/issues{/number}","pulls_url":"https://api.github.com/repos/framgia/fbt_13/pulls{/number}","milestones_url":"https://api.github.com/repos/framgia/fbt_13/milestones{/number}","notifications_url":"https://api.github.com/repos/framgia/fbt_13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/framgia/fbt_13/labels{/name}","releases_url":"https://api.github.com/repos/framgia/fbt_13/releases{/id}","deployments_url":"https://api.github.com/repos/framgia/fbt_13/deployments","created_at":"2017-11-29T01:03:12Z","updated_at":"2017-11-29T06:53:51Z","pushed_at":"2017-12-12T02:06:22Z","git_url":"git://github.com/framgia/fbt_13.git","ssh_url":"[email protected]:framgia/fbt_13.git","clone_url":"https://github.com/framgia/fbt_13.git","svn_url":"https://github.com/framgia/fbt_13","homepage":null,"size":375,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":2,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/framgia/fbt_13/pulls/18"},"html":{"href":"https://github.com/framgia/fbt_13/pull/18"},"issue":{"href":"https://api.github.com/repos/framgia/fbt_13/issues/18"},"comments":{"href":"https://api.github.com/repos/framgia/fbt_13/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/framgia/fbt_13/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/framgia/fbt_13/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/framgia/fbt_13/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/framgia/fbt_13/statuses/995671e92ae5ca06ba00bd51c0cde95814833388"}},"author_association":"CONTRIBUTOR"}} | {
"id": 112408092,
"name": "framgia/fbt_13",
"url": "https://api.github.com/repos/framgia/fbt_13"
} | {
"id": 21377118,
"login": "dothidiemthao",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21377118?",
"url": "https://api.github.com/users/dothidiemthao"
} | {
"id": 2322183,
"login": "framgia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2322183?",
"url": "https://api.github.com/orgs/framgia"
} | 2017-12-12T02:16:11 | 6974721430 | {"actor":{"display_login":"dothidiemthao"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/framgia/rss_6/pulls/comments/96155373","pull_request_review_id":16730835,"id":96155373,"diff_hunk":"@@ -5,5 +5,13 @@\n <string name=\"menu_share\">Share</string>\n <string name=\"menu_print\">Print</string>\n <string name=\"date_published\">Published Date:</string>\n- <string name=\"author\">Author : </string>\n+ <string name=\"author\">Author : </string>\n+ <string name=\"action_no\">No</string>\n+ <string name=\"action_yes\">Yes</string>\n+ <string name=\"title_pdf_save_message\">Save as Pdf?</string>\n+ <string name=\"error_message\">Problem Creating File</string>\n+ <string name=\"title_pdf_create_message\">Create Successful</string>\n+ <string name=\"title_save\">Save</string>\n+ <string name=\"title_update_successful\">Update Successful</string>\n+ <string name=\"title_loading\">Loading...</string>","path":"rss_6/app/src/main/res/values/strings.xml","position":13,"original_position":13,"commit_id":"013e450a9f8da2a374c190024d77555e2c8cbe34","original_commit_id":"013e450a9f8da2a374c190024d77555e2c8cbe34","user":{"login":"DoanVanToan","id":21195010,"avatar_url":"https://avatars.githubusercontent.com/u/21195010?v=3","gravatar_id":"","url":"https://api.github.com/users/DoanVanToan","html_url":"https://github.com/DoanVanToan","followers_url":"https://api.github.com/users/DoanVanToan/followers","following_url":"https://api.github.com/users/DoanVanToan/following{/other_user}","gists_url":"https://api.github.com/users/DoanVanToan/gists{/gist_id}","starred_url":"https://api.github.com/users/DoanVanToan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoanVanToan/subscriptions","organizations_url":"https://api.github.com/users/DoanVanToan/orgs","repos_url":"https://api.github.com/users/DoanVanToan/repos","events_url":"https://api.github.com/users/DoanVanToan/events{/privacy}","received_events_url":"https://api.github.com/users/DoanVanToan/received_events","type":"User","site_admin":false},"body":"action loading","created_at":"2017-01-16T01:49:48Z","updated_at":"2017-01-16T01:49:51Z","html_url":"https://github.com/framgia/rss_6/pull/9#discussion_r96155373","pull_request_url":"https://api.github.com/repos/framgia/rss_6/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/framgia/rss_6/pulls/comments/96155373"},"html":{"href":"https://github.com/framgia/rss_6/pull/9#discussion_r96155373"},"pull_request":{"href":"https://api.github.com/repos/framgia/rss_6/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/framgia/rss_6/pulls/9","id":101403251,"html_url":"https://github.com/framgia/rss_6/pull/9","diff_url":"https://github.com/framgia/rss_6/pull/9.diff","patch_url":"https://github.com/framgia/rss_6/pull/9.patch","issue_url":"https://api.github.com/repos/framgia/rss_6/issues/9","number":9,"state":"open","locked":false,"title":"create_pdf","user":{"login":"tranminhtri911","id":21060436,"avatar_url":"https://avatars.githubusercontent.com/u/21060436?v=3","gravatar_id":"","url":"https://api.github.com/users/tranminhtri911","html_url":"https://github.com/tranminhtri911","followers_url":"https://api.github.com/users/tranminhtri911/followers","following_url":"https://api.github.com/users/tranminhtri911/following{/other_user}","gists_url":"https://api.github.com/users/tranminhtri911/gists{/gist_id}","starred_url":"https://api.github.com/users/tranminhtri911/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tranminhtri911/subscriptions","organizations_url":"https://api.github.com/users/tranminhtri911/orgs","repos_url":"https://api.github.com/users/tranminhtri911/repos","events_url":"https://api.github.com/users/tranminhtri911/events{/privacy}","received_events_url":"https://api.github.com/users/tranminhtri911/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-13T07:55:59Z","updated_at":"2017-01-16T01:49:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b28c987254693647c56cabad5d57f59b17e406b2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/framgia/rss_6/pulls/9/commits","review_comments_url":"https://api.github.com/repos/framgia/rss_6/pulls/9/comments","review_comment_url":"https://api.github.com/repos/framgia/rss_6/pulls/comments{/number}","comments_url":"https://api.github.com/repos/framgia/rss_6/issues/9/comments","statuses_url":"https://api.github.com/repos/framgia/rss_6/statuses/013e450a9f8da2a374c190024d77555e2c8cbe34","head":{"label":"tranminhtri911:create_pdf","ref":"create_pdf","sha":"013e450a9f8da2a374c190024d77555e2c8cbe34","user":{"login":"tranminhtri911","id":21060436,"avatar_url":"https://avatars.githubusercontent.com/u/21060436?v=3","gravatar_id":"","url":"https://api.github.com/users/tranminhtri911","html_url":"https://github.com/tranminhtri911","followers_url":"https://api.github.com/users/tranminhtri911/followers","following_url":"https://api.github.com/users/tranminhtri911/following{/other_user}","gists_url":"https://api.github.com/users/tranminhtri911/gists{/gist_id}","starred_url":"https://api.github.com/users/tranminhtri911/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tranminhtri911/subscriptions","organizations_url":"https://api.github.com/users/tranminhtri911/orgs","repos_url":"https://api.github.com/users/tranminhtri911/repos","events_url":"https://api.github.com/users/tranminhtri911/events{/privacy}","received_events_url":"https://api.github.com/users/tranminhtri911/received_events","type":"User","site_admin":false},"repo":{"id":78390282,"name":"rss_6","full_name":"tranminhtri911/rss_6","owner":{"login":"tranminhtri911","id":21060436,"avatar_url":"https://avatars.githubusercontent.com/u/21060436?v=3","gravatar_id":"","url":"https://api.github.com/users/tranminhtri911","html_url":"https://github.com/tranminhtri911","followers_url":"https://api.github.com/users/tranminhtri911/followers","following_url":"https://api.github.com/users/tranminhtri911/following{/other_user}","gists_url":"https://api.github.com/users/tranminhtri911/gists{/gist_id}","starred_url":"https://api.github.com/users/tranminhtri911/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tranminhtri911/subscriptions","organizations_url":"https://api.github.com/users/tranminhtri911/orgs","repos_url":"https://api.github.com/users/tranminhtri911/repos","events_url":"https://api.github.com/users/tranminhtri911/events{/privacy}","received_events_url":"https://api.github.com/users/tranminhtri911/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tranminhtri911/rss_6","description":null,"fork":true,"url":"https://api.github.com/repos/tranminhtri911/rss_6","forks_url":"https://api.github.com/repos/tranminhtri911/rss_6/forks","keys_url":"https://api.github.com/repos/tranminhtri911/rss_6/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tranminhtri911/rss_6/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tranminhtri911/rss_6/teams","hooks_url":"https://api.github.com/repos/tranminhtri911/rss_6/hooks","issue_events_url":"https://api.github.com/repos/tranminhtri911/rss_6/issues/events{/number}","events_url":"https://api.github.com/repos/tranminhtri911/rss_6/events","assignees_url":"https://api.github.com/repos/tranminhtri911/rss_6/assignees{/user}","branches_url":"https://api.github.com/repos/tranminhtri911/rss_6/branches{/branch}","tags_url":"https://api.github.com/repos/tranminhtri911/rss_6/tags","blobs_url":"https://api.github.com/repos/tranminhtri911/rss_6/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tranminhtri911/rss_6/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tranminhtri911/rss_6/git/refs{/sha}","trees_url":"https://api.github.com/repos/tranminhtri911/rss_6/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tranminhtri911/rss_6/statuses/{sha}","languages_url":"https://api.github.com/repos/tranminhtri911/rss_6/languages","stargazers_url":"https://api.github.com/repos/tranminhtri911/rss_6/stargazers","contributors_url":"https://api.github.com/repos/tranminhtri911/rss_6/contributors","subscribers_url":"https://api.github.com/repos/tranminhtri911/rss_6/subscribers","subscription_url":"https://api.github.com/repos/tranminhtri911/rss_6/subscription","commits_url":"https://api.github.com/repos/tranminhtri911/rss_6/commits{/sha}","git_commits_url":"https://api.github.com/repos/tranminhtri911/rss_6/git/commits{/sha}","comments_url":"https://api.github.com/repos/tranminhtri911/rss_6/comments{/number}","issue_comment_url":"https://api.github.com/repos/tranminhtri911/rss_6/issues/comments{/number}","contents_url":"https://api.github.com/repos/tranminhtri911/rss_6/contents/{+path}","compare_url":"https://api.github.com/repos/tranminhtri911/rss_6/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tranminhtri911/rss_6/merges","archive_url":"https://api.github.com/repos/tranminhtri911/rss_6/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tranminhtri911/rss_6/downloads","issues_url":"https://api.github.com/repos/tranminhtri911/rss_6/issues{/number}","pulls_url":"https://api.github.com/repos/tranminhtri911/rss_6/pulls{/number}","milestones_url":"https://api.github.com/repos/tranminhtri911/rss_6/milestones{/number}","notifications_url":"https://api.github.com/repos/tranminhtri911/rss_6/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tranminhtri911/rss_6/labels{/name}","releases_url":"https://api.github.com/repos/tranminhtri911/rss_6/releases{/id}","deployments_url":"https://api.github.com/repos/tranminhtri911/rss_6/deployments","created_at":"2017-01-09T03:26:57Z","updated_at":"2017-01-09T05:36:03Z","pushed_at":"2017-01-16T01:40:47Z","git_url":"git://github.com/tranminhtri911/rss_6.git","ssh_url":"[email protected]:tranminhtri911/rss_6.git","clone_url":"https://github.com/tranminhtri911/rss_6.git","svn_url":"https://github.com/tranminhtri911/rss_6","homepage":null,"size":186,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"framgia:develop","ref":"develop","sha":"e2792c12ab6d328880905c1a717e4aa2489844f8","user":{"login":"framgia","id":2322183,"avatar_url":"https://avatars.githubusercontent.com/u/2322183?v=3","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"repo":{"id":78386011,"name":"rss_6","full_name":"framgia/rss_6","owner":{"login":"framgia","id":2322183,"avatar_url":"https://avatars.githubusercontent.com/u/2322183?v=3","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/framgia/rss_6","description":null,"fork":false,"url":"https://api.github.com/repos/framgia/rss_6","forks_url":"https://api.github.com/repos/framgia/rss_6/forks","keys_url":"https://api.github.com/repos/framgia/rss_6/keys{/key_id}","collaborators_url":"https://api.github.com/repos/framgia/rss_6/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/framgia/rss_6/teams","hooks_url":"https://api.github.com/repos/framgia/rss_6/hooks","issue_events_url":"https://api.github.com/repos/framgia/rss_6/issues/events{/number}","events_url":"https://api.github.com/repos/framgia/rss_6/events","assignees_url":"https://api.github.com/repos/framgia/rss_6/assignees{/user}","branches_url":"https://api.github.com/repos/framgia/rss_6/branches{/branch}","tags_url":"https://api.github.com/repos/framgia/rss_6/tags","blobs_url":"https://api.github.com/repos/framgia/rss_6/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/framgia/rss_6/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/framgia/rss_6/git/refs{/sha}","trees_url":"https://api.github.com/repos/framgia/rss_6/git/trees{/sha}","statuses_url":"https://api.github.com/repos/framgia/rss_6/statuses/{sha}","languages_url":"https://api.github.com/repos/framgia/rss_6/languages","stargazers_url":"https://api.github.com/repos/framgia/rss_6/stargazers","contributors_url":"https://api.github.com/repos/framgia/rss_6/contributors","subscribers_url":"https://api.github.com/repos/framgia/rss_6/subscribers","subscription_url":"https://api.github.com/repos/framgia/rss_6/subscription","commits_url":"https://api.github.com/repos/framgia/rss_6/commits{/sha}","git_commits_url":"https://api.github.com/repos/framgia/rss_6/git/commits{/sha}","comments_url":"https://api.github.com/repos/framgia/rss_6/comments{/number}","issue_comment_url":"https://api.github.com/repos/framgia/rss_6/issues/comments{/number}","contents_url":"https://api.github.com/repos/framgia/rss_6/contents/{+path}","compare_url":"https://api.github.com/repos/framgia/rss_6/compare/{base}...{head}","merges_url":"https://api.github.com/repos/framgia/rss_6/merges","archive_url":"https://api.github.com/repos/framgia/rss_6/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/framgia/rss_6/downloads","issues_url":"https://api.github.com/repos/framgia/rss_6/issues{/number}","pulls_url":"https://api.github.com/repos/framgia/rss_6/pulls{/number}","milestones_url":"https://api.github.com/repos/framgia/rss_6/milestones{/number}","notifications_url":"https://api.github.com/repos/framgia/rss_6/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/framgia/rss_6/labels{/name}","releases_url":"https://api.github.com/repos/framgia/rss_6/releases{/id}","deployments_url":"https://api.github.com/repos/framgia/rss_6/deployments","created_at":"2017-01-09T02:21:23Z","updated_at":"2017-01-09T07:59:09Z","pushed_at":"2017-01-16T01:40:47Z","git_url":"git://github.com/framgia/rss_6.git","ssh_url":"[email protected]:framgia/rss_6.git","clone_url":"https://github.com/framgia/rss_6.git","svn_url":"https://github.com/framgia/rss_6","homepage":null,"size":147,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/framgia/rss_6/pulls/9"},"html":{"href":"https://github.com/framgia/rss_6/pull/9"},"issue":{"href":"https://api.github.com/repos/framgia/rss_6/issues/9"},"comments":{"href":"https://api.github.com/repos/framgia/rss_6/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/framgia/rss_6/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/framgia/rss_6/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/framgia/rss_6/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/framgia/rss_6/statuses/013e450a9f8da2a374c190024d77555e2c8cbe34"}}}} | {
"id": 78386011,
"name": "framgia/rss_6",
"url": "https://api.github.com/repos/framgia/rss_6"
} | {
"id": 21195010,
"login": "DoanVanToan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21195010?",
"url": "https://api.github.com/users/DoanVanToan"
} | {
"id": 2322183,
"login": "framgia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2322183?",
"url": "https://api.github.com/orgs/framgia"
} | 2017-01-16T01:49:48 | 5156756790 | {"actor":{"display_login":"DoanVanToan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/funcool/buddy-auth/pulls/comments/102300641","pull_request_review_id":23053696,"id":102300641,"diff_hunk":"@@ -43,6 +44,9 @@\n (def jws-backend (backends/jws {:secret jws-secret}))\n (def jws-backend-with-authfn (backends/jws {:secret jws-secret :authfn (constantly ::jws-authorized)}))\n (def jws-data {:userid 1})\n+(def rsa-privkey (keys/private-key \"test/_files/privkey.rsa.pem\"))\n+(def rsa-pubkey (keys/public-key \"test/_files/pubkey.rsa.pem\"))\n+(def jws-backend-rsa (backends/jws {:secret rsa-pubkey}))","path":"test/buddy/auth/backends/token_tests.clj","position":14,"original_position":14,"commit_id":"e3b51fd94e127709f12cf6ea0530047825a7dae5","original_commit_id":"e3b51fd94e127709f12cf6ea0530047825a7dae5","user":{"login":"niwinz","id":843689,"avatar_url":"https://avatars.githubusercontent.com/u/843689?v=3","gravatar_id":"","url":"https://api.github.com/users/niwinz","html_url":"https://github.com/niwinz","followers_url":"https://api.github.com/users/niwinz/followers","following_url":"https://api.github.com/users/niwinz/following{/other_user}","gists_url":"https://api.github.com/users/niwinz/gists{/gist_id}","starred_url":"https://api.github.com/users/niwinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niwinz/subscriptions","organizations_url":"https://api.github.com/users/niwinz/orgs","repos_url":"https://api.github.com/users/niwinz/repos","events_url":"https://api.github.com/users/niwinz/events{/privacy}","received_events_url":"https://api.github.com/users/niwinz/received_events","type":"User","site_admin":false},"body":"As I have explained in the issue, this line tries initialize the backend with `:hs256` algorithm but you are passing to it the rsa pubkey, that is wrong. If you want use rsa keys, you need pass an appropriate algorithm.","created_at":"2017-02-21T19:50:23Z","updated_at":"2017-02-21T19:50:23Z","html_url":"https://github.com/funcool/buddy-auth/pull/64#discussion_r102300641","pull_request_url":"https://api.github.com/repos/funcool/buddy-auth/pulls/64","_links":{"self":{"href":"https://api.github.com/repos/funcool/buddy-auth/pulls/comments/102300641"},"html":{"href":"https://github.com/funcool/buddy-auth/pull/64#discussion_r102300641"},"pull_request":{"href":"https://api.github.com/repos/funcool/buddy-auth/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/funcool/buddy-auth/pulls/64","id":107260112,"html_url":"https://github.com/funcool/buddy-auth/pull/64","diff_url":"https://github.com/funcool/buddy-auth/pull/64.diff","patch_url":"https://github.com/funcool/buddy-auth/pull/64.patch","issue_url":"https://api.github.com/repos/funcool/buddy-auth/issues/64","number":64,"state":"open","locked":false,"title":"added RSA tests for jws backend","user":{"login":"eoliphan","id":1065736,"avatar_url":"https://avatars.githubusercontent.com/u/1065736?v=3","gravatar_id":"","url":"https://api.github.com/users/eoliphan","html_url":"https://github.com/eoliphan","followers_url":"https://api.github.com/users/eoliphan/followers","following_url":"https://api.github.com/users/eoliphan/following{/other_user}","gists_url":"https://api.github.com/users/eoliphan/gists{/gist_id}","starred_url":"https://api.github.com/users/eoliphan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eoliphan/subscriptions","organizations_url":"https://api.github.com/users/eoliphan/orgs","repos_url":"https://api.github.com/users/eoliphan/repos","events_url":"https://api.github.com/users/eoliphan/events{/privacy}","received_events_url":"https://api.github.com/users/eoliphan/received_events","type":"User","site_admin":false},"body":"Added this to better illustrate #63, and validate fix","created_at":"2017-02-21T19:24:22Z","updated_at":"2017-02-21T19:50:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60e50d12a5be502be740616bd35631743e82cd21","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/funcool/buddy-auth/pulls/64/commits","review_comments_url":"https://api.github.com/repos/funcool/buddy-auth/pulls/64/comments","review_comment_url":"https://api.github.com/repos/funcool/buddy-auth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/funcool/buddy-auth/issues/64/comments","statuses_url":"https://api.github.com/repos/funcool/buddy-auth/statuses/e3b51fd94e127709f12cf6ea0530047825a7dae5","head":{"label":"eoliphan:master","ref":"master","sha":"e3b51fd94e127709f12cf6ea0530047825a7dae5","user":{"login":"eoliphan","id":1065736,"avatar_url":"https://avatars.githubusercontent.com/u/1065736?v=3","gravatar_id":"","url":"https://api.github.com/users/eoliphan","html_url":"https://github.com/eoliphan","followers_url":"https://api.github.com/users/eoliphan/followers","following_url":"https://api.github.com/users/eoliphan/following{/other_user}","gists_url":"https://api.github.com/users/eoliphan/gists{/gist_id}","starred_url":"https://api.github.com/users/eoliphan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eoliphan/subscriptions","organizations_url":"https://api.github.com/users/eoliphan/orgs","repos_url":"https://api.github.com/users/eoliphan/repos","events_url":"https://api.github.com/users/eoliphan/events{/privacy}","received_events_url":"https://api.github.com/users/eoliphan/received_events","type":"User","site_admin":false},"repo":{"id":82712410,"name":"buddy-auth","full_name":"eoliphan/buddy-auth","owner":{"login":"eoliphan","id":1065736,"avatar_url":"https://avatars.githubusercontent.com/u/1065736?v=3","gravatar_id":"","url":"https://api.github.com/users/eoliphan","html_url":"https://github.com/eoliphan","followers_url":"https://api.github.com/users/eoliphan/followers","following_url":"https://api.github.com/users/eoliphan/following{/other_user}","gists_url":"https://api.github.com/users/eoliphan/gists{/gist_id}","starred_url":"https://api.github.com/users/eoliphan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eoliphan/subscriptions","organizations_url":"https://api.github.com/users/eoliphan/orgs","repos_url":"https://api.github.com/users/eoliphan/repos","events_url":"https://api.github.com/users/eoliphan/events{/privacy}","received_events_url":"https://api.github.com/users/eoliphan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eoliphan/buddy-auth","description":"Authentication and Authorization facilities for ring and ring based web applications.","fork":true,"url":"https://api.github.com/repos/eoliphan/buddy-auth","forks_url":"https://api.github.com/repos/eoliphan/buddy-auth/forks","keys_url":"https://api.github.com/repos/eoliphan/buddy-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eoliphan/buddy-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eoliphan/buddy-auth/teams","hooks_url":"https://api.github.com/repos/eoliphan/buddy-auth/hooks","issue_events_url":"https://api.github.com/repos/eoliphan/buddy-auth/issues/events{/number}","events_url":"https://api.github.com/repos/eoliphan/buddy-auth/events","assignees_url":"https://api.github.com/repos/eoliphan/buddy-auth/assignees{/user}","branches_url":"https://api.github.com/repos/eoliphan/buddy-auth/branches{/branch}","tags_url":"https://api.github.com/repos/eoliphan/buddy-auth/tags","blobs_url":"https://api.github.com/repos/eoliphan/buddy-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eoliphan/buddy-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eoliphan/buddy-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/eoliphan/buddy-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eoliphan/buddy-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/eoliphan/buddy-auth/languages","stargazers_url":"https://api.github.com/repos/eoliphan/buddy-auth/stargazers","contributors_url":"https://api.github.com/repos/eoliphan/buddy-auth/contributors","subscribers_url":"https://api.github.com/repos/eoliphan/buddy-auth/subscribers","subscription_url":"https://api.github.com/repos/eoliphan/buddy-auth/subscription","commits_url":"https://api.github.com/repos/eoliphan/buddy-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/eoliphan/buddy-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/eoliphan/buddy-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/eoliphan/buddy-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/eoliphan/buddy-auth/contents/{+path}","compare_url":"https://api.github.com/repos/eoliphan/buddy-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eoliphan/buddy-auth/merges","archive_url":"https://api.github.com/repos/eoliphan/buddy-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eoliphan/buddy-auth/downloads","issues_url":"https://api.github.com/repos/eoliphan/buddy-auth/issues{/number}","pulls_url":"https://api.github.com/repos/eoliphan/buddy-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/eoliphan/buddy-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/eoliphan/buddy-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eoliphan/buddy-auth/labels{/name}","releases_url":"https://api.github.com/repos/eoliphan/buddy-auth/releases{/id}","deployments_url":"https://api.github.com/repos/eoliphan/buddy-auth/deployments","created_at":"2017-02-21T18:19:32Z","updated_at":"2017-02-21T18:19:34Z","pushed_at":"2017-02-21T19:22:32Z","git_url":"git://github.com/eoliphan/buddy-auth.git","ssh_url":"[email protected]:eoliphan/buddy-auth.git","clone_url":"https://github.com/eoliphan/buddy-auth.git","svn_url":"https://github.com/eoliphan/buddy-auth","homepage":"https://funcool.github.io/buddy-auth/latest/","size":627,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"funcool:master","ref":"master","sha":"b6babf922afa53fbed6ad1761298499f015ef721","user":{"login":"funcool","id":10117366,"avatar_url":"https://avatars.githubusercontent.com/u/10117366?v=3","gravatar_id":"","url":"https://api.github.com/users/funcool","html_url":"https://github.com/funcool","followers_url":"https://api.github.com/users/funcool/followers","following_url":"https://api.github.com/users/funcool/following{/other_user}","gists_url":"https://api.github.com/users/funcool/gists{/gist_id}","starred_url":"https://api.github.com/users/funcool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/funcool/subscriptions","organizations_url":"https://api.github.com/users/funcool/orgs","repos_url":"https://api.github.com/users/funcool/repos","events_url":"https://api.github.com/users/funcool/events{/privacy}","received_events_url":"https://api.github.com/users/funcool/received_events","type":"Organization","site_admin":false},"repo":{"id":28539436,"name":"buddy-auth","full_name":"funcool/buddy-auth","owner":{"login":"funcool","id":10117366,"avatar_url":"https://avatars.githubusercontent.com/u/10117366?v=3","gravatar_id":"","url":"https://api.github.com/users/funcool","html_url":"https://github.com/funcool","followers_url":"https://api.github.com/users/funcool/followers","following_url":"https://api.github.com/users/funcool/following{/other_user}","gists_url":"https://api.github.com/users/funcool/gists{/gist_id}","starred_url":"https://api.github.com/users/funcool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/funcool/subscriptions","organizations_url":"https://api.github.com/users/funcool/orgs","repos_url":"https://api.github.com/users/funcool/repos","events_url":"https://api.github.com/users/funcool/events{/privacy}","received_events_url":"https://api.github.com/users/funcool/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/funcool/buddy-auth","description":"Authentication and Authorization facilities for ring and ring based web applications.","fork":false,"url":"https://api.github.com/repos/funcool/buddy-auth","forks_url":"https://api.github.com/repos/funcool/buddy-auth/forks","keys_url":"https://api.github.com/repos/funcool/buddy-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/funcool/buddy-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/funcool/buddy-auth/teams","hooks_url":"https://api.github.com/repos/funcool/buddy-auth/hooks","issue_events_url":"https://api.github.com/repos/funcool/buddy-auth/issues/events{/number}","events_url":"https://api.github.com/repos/funcool/buddy-auth/events","assignees_url":"https://api.github.com/repos/funcool/buddy-auth/assignees{/user}","branches_url":"https://api.github.com/repos/funcool/buddy-auth/branches{/branch}","tags_url":"https://api.github.com/repos/funcool/buddy-auth/tags","blobs_url":"https://api.github.com/repos/funcool/buddy-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/funcool/buddy-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/funcool/buddy-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/funcool/buddy-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/funcool/buddy-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/funcool/buddy-auth/languages","stargazers_url":"https://api.github.com/repos/funcool/buddy-auth/stargazers","contributors_url":"https://api.github.com/repos/funcool/buddy-auth/contributors","subscribers_url":"https://api.github.com/repos/funcool/buddy-auth/subscribers","subscription_url":"https://api.github.com/repos/funcool/buddy-auth/subscription","commits_url":"https://api.github.com/repos/funcool/buddy-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/funcool/buddy-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/funcool/buddy-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/funcool/buddy-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/funcool/buddy-auth/contents/{+path}","compare_url":"https://api.github.com/repos/funcool/buddy-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/funcool/buddy-auth/merges","archive_url":"https://api.github.com/repos/funcool/buddy-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/funcool/buddy-auth/downloads","issues_url":"https://api.github.com/repos/funcool/buddy-auth/issues{/number}","pulls_url":"https://api.github.com/repos/funcool/buddy-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/funcool/buddy-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/funcool/buddy-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/funcool/buddy-auth/labels{/name}","releases_url":"https://api.github.com/repos/funcool/buddy-auth/releases{/id}","deployments_url":"https://api.github.com/repos/funcool/buddy-auth/deployments","created_at":"2014-12-27T15:13:24Z","updated_at":"2017-02-19T11:38:12Z","pushed_at":"2017-02-21T19:31:14Z","git_url":"git://github.com/funcool/buddy-auth.git","ssh_url":"[email protected]:funcool/buddy-auth.git","clone_url":"https://github.com/funcool/buddy-auth.git","svn_url":"https://github.com/funcool/buddy-auth","homepage":"https://funcool.github.io/buddy-auth/latest/","size":627,"stargazers_count":130,"watchers_count":130,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"open_issues_count":3,"forks":39,"open_issues":3,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/funcool/buddy-auth/pulls/64"},"html":{"href":"https://github.com/funcool/buddy-auth/pull/64"},"issue":{"href":"https://api.github.com/repos/funcool/buddy-auth/issues/64"},"comments":{"href":"https://api.github.com/repos/funcool/buddy-auth/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/funcool/buddy-auth/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/funcool/buddy-auth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/funcool/buddy-auth/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/funcool/buddy-auth/statuses/e3b51fd94e127709f12cf6ea0530047825a7dae5"}}}} | {
"id": 28539436,
"name": "funcool/buddy-auth",
"url": "https://api.github.com/repos/funcool/buddy-auth"
} | {
"id": 843689,
"login": "niwinz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/843689?",
"url": "https://api.github.com/users/niwinz"
} | {
"id": 10117366,
"login": "funcool",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10117366?",
"url": "https://api.github.com/orgs/funcool"
} | 2017-02-21T19:50:23 | 5364908472 | {"actor":{"display_login":"niwinz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/getamis/quorum-tools/pulls/comments/130004279","pull_request_review_id":52835093,"id":130004279,"diff_hunk":"@@ -265,6 +265,11 @@ data Privacy\n -- * abi\n data Contract = Contract Privacy [UnencodedMethod] Text Text\n \n+data IstanbulValidator = IstanbulValidator { nodeKey :: String\n+ , enode :: String\n+ , address :: String\n+ } deriving (Show, Eq)","path":"src/QuorumTools/Types.hs","position":7,"original_position":7,"commit_id":"95477455f526f35df1ee893f8708f91fc93a5531","original_commit_id":"95477455f526f35df1ee893f8708f91fc93a5531","user":{"login":"bailantaotao","id":5364396,"avatar_url":"https://avatars3.githubusercontent.com/u/5364396?v=4","gravatar_id":"","url":"https://api.github.com/users/bailantaotao","html_url":"https://github.com/bailantaotao","followers_url":"https://api.github.com/users/bailantaotao/followers","following_url":"https://api.github.com/users/bailantaotao/following{/other_user}","gists_url":"https://api.github.com/users/bailantaotao/gists{/gist_id}","starred_url":"https://api.github.com/users/bailantaotao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bailantaotao/subscriptions","organizations_url":"https://api.github.com/users/bailantaotao/orgs","repos_url":"https://api.github.com/users/bailantaotao/repos","events_url":"https://api.github.com/users/bailantaotao/events{/privacy}","received_events_url":"https://api.github.com/users/bailantaotao/received_events","type":"User","site_admin":false},"body":"remove show, eq","created_at":"2017-07-28T03:09:01Z","updated_at":"2017-07-28T03:09:01Z","html_url":"https://github.com/getamis/quorum-tools/pull/2#discussion_r130004279","pull_request_url":"https://api.github.com/repos/getamis/quorum-tools/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/getamis/quorum-tools/pulls/comments/130004279"},"html":{"href":"https://github.com/getamis/quorum-tools/pull/2#discussion_r130004279"},"pull_request":{"href":"https://api.github.com/repos/getamis/quorum-tools/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/getamis/quorum-tools/pulls/2","id":131266442,"html_url":"https://github.com/getamis/quorum-tools/pull/2","diff_url":"https://github.com/getamis/quorum-tools/pull/2.diff","patch_url":"https://github.com/getamis/quorum-tools/pull/2.patch","issue_url":"https://api.github.com/repos/getamis/quorum-tools/issues/2","number":2,"state":"open","locked":false,"title":"Support Istanbul consensus","user":{"login":"bailantaotao","id":5364396,"avatar_url":"https://avatars3.githubusercontent.com/u/5364396?v=4","gravatar_id":"","url":"https://api.github.com/users/bailantaotao","html_url":"https://github.com/bailantaotao","followers_url":"https://api.github.com/users/bailantaotao/followers","following_url":"https://api.github.com/users/bailantaotao/following{/other_user}","gists_url":"https://api.github.com/users/bailantaotao/gists{/gist_id}","starred_url":"https://api.github.com/users/bailantaotao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bailantaotao/subscriptions","organizations_url":"https://api.github.com/users/bailantaotao/orgs","repos_url":"https://api.github.com/users/bailantaotao/repos","events_url":"https://api.github.com/users/bailantaotao/events{/privacy}","received_events_url":"https://api.github.com/users/bailantaotao/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-19T08:43:01Z","updated_at":"2017-07-28T03:09:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09a338dab68932637dddbb269e4ec5aae43b6fc4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/getamis/quorum-tools/pulls/2/commits","review_comments_url":"https://api.github.com/repos/getamis/quorum-tools/pulls/2/comments","review_comment_url":"https://api.github.com/repos/getamis/quorum-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getamis/quorum-tools/issues/2/comments","statuses_url":"https://api.github.com/repos/getamis/quorum-tools/statuses/95477455f526f35df1ee893f8708f91fc93a5531","head":{"label":"getamis:support-istanbul-consensus","ref":"support-istanbul-consensus","sha":"95477455f526f35df1ee893f8708f91fc93a5531","user":{"login":"getamis","id":26534116,"avatar_url":"https://avatars2.githubusercontent.com/u/26534116?v=4","gravatar_id":"","url":"https://api.github.com/users/getamis","html_url":"https://github.com/getamis","followers_url":"https://api.github.com/users/getamis/followers","following_url":"https://api.github.com/users/getamis/following{/other_user}","gists_url":"https://api.github.com/users/getamis/gists{/gist_id}","starred_url":"https://api.github.com/users/getamis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getamis/subscriptions","organizations_url":"https://api.github.com/users/getamis/orgs","repos_url":"https://api.github.com/users/getamis/repos","events_url":"https://api.github.com/users/getamis/events{/privacy}","received_events_url":"https://api.github.com/users/getamis/received_events","type":"Organization","site_admin":false},"repo":{"id":95627868,"name":"quorum-tools","full_name":"getamis/quorum-tools","owner":{"login":"getamis","id":26534116,"avatar_url":"https://avatars2.githubusercontent.com/u/26534116?v=4","gravatar_id":"","url":"https://api.github.com/users/getamis","html_url":"https://github.com/getamis","followers_url":"https://api.github.com/users/getamis/followers","following_url":"https://api.github.com/users/getamis/following{/other_user}","gists_url":"https://api.github.com/users/getamis/gists{/gist_id}","starred_url":"https://api.github.com/users/getamis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getamis/subscriptions","organizations_url":"https://api.github.com/users/getamis/orgs","repos_url":"https://api.github.com/users/getamis/repos","events_url":"https://api.github.com/users/getamis/events{/privacy}","received_events_url":"https://api.github.com/users/getamis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getamis/quorum-tools","description":"Tools for running Quorum clusters and integration tests","fork":true,"url":"https://api.github.com/repos/getamis/quorum-tools","forks_url":"https://api.github.com/repos/getamis/quorum-tools/forks","keys_url":"https://api.github.com/repos/getamis/quorum-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getamis/quorum-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getamis/quorum-tools/teams","hooks_url":"https://api.github.com/repos/getamis/quorum-tools/hooks","issue_events_url":"https://api.github.com/repos/getamis/quorum-tools/issues/events{/number}","events_url":"https://api.github.com/repos/getamis/quorum-tools/events","assignees_url":"https://api.github.com/repos/getamis/quorum-tools/assignees{/user}","branches_url":"https://api.github.com/repos/getamis/quorum-tools/branches{/branch}","tags_url":"https://api.github.com/repos/getamis/quorum-tools/tags","blobs_url":"https://api.github.com/repos/getamis/quorum-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getamis/quorum-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getamis/quorum-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/getamis/quorum-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getamis/quorum-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/getamis/quorum-tools/languages","stargazers_url":"https://api.github.com/repos/getamis/quorum-tools/stargazers","contributors_url":"https://api.github.com/repos/getamis/quorum-tools/contributors","subscribers_url":"https://api.github.com/repos/getamis/quorum-tools/subscribers","subscription_url":"https://api.github.com/repos/getamis/quorum-tools/subscription","commits_url":"https://api.github.com/repos/getamis/quorum-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/getamis/quorum-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/getamis/quorum-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/getamis/quorum-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/getamis/quorum-tools/contents/{+path}","compare_url":"https://api.github.com/repos/getamis/quorum-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getamis/quorum-tools/merges","archive_url":"https://api.github.com/repos/getamis/quorum-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getamis/quorum-tools/downloads","issues_url":"https://api.github.com/repos/getamis/quorum-tools/issues{/number}","pulls_url":"https://api.github.com/repos/getamis/quorum-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/getamis/quorum-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/getamis/quorum-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getamis/quorum-tools/labels{/name}","releases_url":"https://api.github.com/repos/getamis/quorum-tools/releases{/id}","deployments_url":"https://api.github.com/repos/getamis/quorum-tools/deployments","created_at":"2017-06-28T04:14:25Z","updated_at":"2017-07-14T03:26:30Z","pushed_at":"2017-07-28T03:05:14Z","git_url":"git://github.com/getamis/quorum-tools.git","ssh_url":"[email protected]:getamis/quorum-tools.git","clone_url":"https://github.com/getamis/quorum-tools.git","svn_url":"https://github.com/getamis/quorum-tools","homepage":"","size":487,"stargazers_count":1,"watchers_count":1,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"getamis:istanbul/develop","ref":"istanbul/develop","sha":"ca3f1c113d912bad6149fdbe9e29d8918774d782","user":{"login":"getamis","id":26534116,"avatar_url":"https://avatars2.githubusercontent.com/u/26534116?v=4","gravatar_id":"","url":"https://api.github.com/users/getamis","html_url":"https://github.com/getamis","followers_url":"https://api.github.com/users/getamis/followers","following_url":"https://api.github.com/users/getamis/following{/other_user}","gists_url":"https://api.github.com/users/getamis/gists{/gist_id}","starred_url":"https://api.github.com/users/getamis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getamis/subscriptions","organizations_url":"https://api.github.com/users/getamis/orgs","repos_url":"https://api.github.com/users/getamis/repos","events_url":"https://api.github.com/users/getamis/events{/privacy}","received_events_url":"https://api.github.com/users/getamis/received_events","type":"Organization","site_admin":false},"repo":{"id":95627868,"name":"quorum-tools","full_name":"getamis/quorum-tools","owner":{"login":"getamis","id":26534116,"avatar_url":"https://avatars2.githubusercontent.com/u/26534116?v=4","gravatar_id":"","url":"https://api.github.com/users/getamis","html_url":"https://github.com/getamis","followers_url":"https://api.github.com/users/getamis/followers","following_url":"https://api.github.com/users/getamis/following{/other_user}","gists_url":"https://api.github.com/users/getamis/gists{/gist_id}","starred_url":"https://api.github.com/users/getamis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getamis/subscriptions","organizations_url":"https://api.github.com/users/getamis/orgs","repos_url":"https://api.github.com/users/getamis/repos","events_url":"https://api.github.com/users/getamis/events{/privacy}","received_events_url":"https://api.github.com/users/getamis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getamis/quorum-tools","description":"Tools for running Quorum clusters and integration tests","fork":true,"url":"https://api.github.com/repos/getamis/quorum-tools","forks_url":"https://api.github.com/repos/getamis/quorum-tools/forks","keys_url":"https://api.github.com/repos/getamis/quorum-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getamis/quorum-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getamis/quorum-tools/teams","hooks_url":"https://api.github.com/repos/getamis/quorum-tools/hooks","issue_events_url":"https://api.github.com/repos/getamis/quorum-tools/issues/events{/number}","events_url":"https://api.github.com/repos/getamis/quorum-tools/events","assignees_url":"https://api.github.com/repos/getamis/quorum-tools/assignees{/user}","branches_url":"https://api.github.com/repos/getamis/quorum-tools/branches{/branch}","tags_url":"https://api.github.com/repos/getamis/quorum-tools/tags","blobs_url":"https://api.github.com/repos/getamis/quorum-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getamis/quorum-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getamis/quorum-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/getamis/quorum-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getamis/quorum-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/getamis/quorum-tools/languages","stargazers_url":"https://api.github.com/repos/getamis/quorum-tools/stargazers","contributors_url":"https://api.github.com/repos/getamis/quorum-tools/contributors","subscribers_url":"https://api.github.com/repos/getamis/quorum-tools/subscribers","subscription_url":"https://api.github.com/repos/getamis/quorum-tools/subscription","commits_url":"https://api.github.com/repos/getamis/quorum-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/getamis/quorum-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/getamis/quorum-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/getamis/quorum-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/getamis/quorum-tools/contents/{+path}","compare_url":"https://api.github.com/repos/getamis/quorum-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getamis/quorum-tools/merges","archive_url":"https://api.github.com/repos/getamis/quorum-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getamis/quorum-tools/downloads","issues_url":"https://api.github.com/repos/getamis/quorum-tools/issues{/number}","pulls_url":"https://api.github.com/repos/getamis/quorum-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/getamis/quorum-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/getamis/quorum-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getamis/quorum-tools/labels{/name}","releases_url":"https://api.github.com/repos/getamis/quorum-tools/releases{/id}","deployments_url":"https://api.github.com/repos/getamis/quorum-tools/deployments","created_at":"2017-06-28T04:14:25Z","updated_at":"2017-07-14T03:26:30Z","pushed_at":"2017-07-28T03:05:14Z","git_url":"git://github.com/getamis/quorum-tools.git","ssh_url":"[email protected]:getamis/quorum-tools.git","clone_url":"https://github.com/getamis/quorum-tools.git","svn_url":"https://github.com/getamis/quorum-tools","homepage":"","size":487,"stargazers_count":1,"watchers_count":1,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getamis/quorum-tools/pulls/2"},"html":{"href":"https://github.com/getamis/quorum-tools/pull/2"},"issue":{"href":"https://api.github.com/repos/getamis/quorum-tools/issues/2"},"comments":{"href":"https://api.github.com/repos/getamis/quorum-tools/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/getamis/quorum-tools/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/getamis/quorum-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getamis/quorum-tools/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/getamis/quorum-tools/statuses/95477455f526f35df1ee893f8708f91fc93a5531"}}}} | {
"id": 95627868,
"name": "getamis/quorum-tools",
"url": "https://api.github.com/repos/getamis/quorum-tools"
} | {
"id": 5364396,
"login": "bailantaotao",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5364396?",
"url": "https://api.github.com/users/bailantaotao"
} | {
"id": 26534116,
"login": "getamis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26534116?",
"url": "https://api.github.com/orgs/getamis"
} | 2017-07-28T03:09:01 | 6346639852 | {"actor":{"display_login":"bailantaotao"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/herdphp/docker-phpqa/pulls/comments/149192453","pull_request_review_id":74546913,"id":149192453,"diff_hunk":"@@ -54,7 +54,7 @@ function parseRunArgs()\n \n if [ -z \"${_RUN_VERSION}\" ]; then\n _RUN_VERSION=${_PHPQA_PHP_VERSION};\n- elif [ \"${_RUN_VERSION}\" != \"72\" ] && [ \"${_RUN_VERSION}\" != \"71\" ] && [ \"${_RUN_VERSION}\" != \"70\" ] && [ \"${_RUN_VERSION}\" != \"56\" ] && [ \"${_RUN_VERSION}\" != \"55\" ]; then\n+ elif [ \"${_RUN_VERSION}\" != \"72\" ] && [ \"${_RUN_VERSION}\" != \"71\" ] && [ \"${_RUN_VERSION}\" != \"70\" ] && [ \"${_RUN_VERSION}\" != \"56\" ] && [ \"${_RUN_VERSION}\" != \"55\" ] && [ \"${_RUN_VERSION}\" != \"all\" ]; then","path":"bin/phpqa.sh","position":5,"original_position":5,"commit_id":"95498b199fd0998c7cbe1813429bae5eeeac054e","original_commit_id":"95498b199fd0998c7cbe1813429bae5eeeac054e","user":{"login":"brunoric","id":526125,"avatar_url":"https://avatars1.githubusercontent.com/u/526125?v=4","gravatar_id":"","url":"https://api.github.com/users/brunoric","html_url":"https://github.com/brunoric","followers_url":"https://api.github.com/users/brunoric/followers","following_url":"https://api.github.com/users/brunoric/following{/other_user}","gists_url":"https://api.github.com/users/brunoric/gists{/gist_id}","starred_url":"https://api.github.com/users/brunoric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunoric/subscriptions","organizations_url":"https://api.github.com/users/brunoric/orgs","repos_url":"https://api.github.com/users/brunoric/repos","events_url":"https://api.github.com/users/brunoric/events{/privacy}","received_events_url":"https://api.github.com/users/brunoric/received_events","type":"User","site_admin":false},"body":"Good catch. This was a regression introduced after the api refactoring.","created_at":"2017-11-06T20:22:23Z","updated_at":"2017-11-06T20:34:05Z","html_url":"https://github.com/herdphp/docker-phpqa/pull/55#discussion_r149192453","pull_request_url":"https://api.github.com/repos/herdphp/docker-phpqa/pulls/55","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/herdphp/docker-phpqa/pulls/comments/149192453"},"html":{"href":"https://github.com/herdphp/docker-phpqa/pull/55#discussion_r149192453"},"pull_request":{"href":"https://api.github.com/repos/herdphp/docker-phpqa/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/herdphp/docker-phpqa/pulls/55","id":147271472,"html_url":"https://github.com/herdphp/docker-phpqa/pull/55","diff_url":"https://github.com/herdphp/docker-phpqa/pull/55.diff","patch_url":"https://github.com/herdphp/docker-phpqa/pull/55.patch","issue_url":"https://api.github.com/repos/herdphp/docker-phpqa/issues/55","number":55,"state":"open","locked":false,"title":"Added 'all' parameter to the version condition, changed the git comma…","user":{"login":"gabrieldagama","id":3008360,"avatar_url":"https://avatars3.githubusercontent.com/u/3008360?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrieldagama","html_url":"https://github.com/gabrieldagama","followers_url":"https://api.github.com/users/gabrieldagama/followers","following_url":"https://api.github.com/users/gabrieldagama/following{/other_user}","gists_url":"https://api.github.com/users/gabrieldagama/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrieldagama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrieldagama/subscriptions","organizations_url":"https://api.github.com/users/gabrieldagama/orgs","repos_url":"https://api.github.com/users/gabrieldagama/repos","events_url":"https://api.github.com/users/gabrieldagama/events{/privacy}","received_events_url":"https://api.github.com/users/gabrieldagama/received_events","type":"User","site_admin":false},"body":"Hi, I've been testing your tool today and found few problems:\r\n\r\n1 - Using all parameter to run a test in all php versions it wasn't working, it was printing that the parameters was invalid.\r\n\r\n2 - The git command used to get the path to run the script wasn't working when tried to run the script from outside the git folder.\r\n\r\n3 - the Run command was been missed from the execution of phpqa for each version.\r\n\r\nI've tried to solve them but might not be the best approach, I didn't have time enough to understand everything there, but I think if it's not 100% good it would help anyway!\r\n\r\nThanks!","created_at":"2017-10-18T11:11:29Z","updated_at":"2017-11-06T20:34:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f964a082ffc447a4727bef6ba24241b30feb614d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/herdphp/docker-phpqa/pulls/55/commits","review_comments_url":"https://api.github.com/repos/herdphp/docker-phpqa/pulls/55/comments","review_comment_url":"https://api.github.com/repos/herdphp/docker-phpqa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/herdphp/docker-phpqa/issues/55/comments","statuses_url":"https://api.github.com/repos/herdphp/docker-phpqa/statuses/95498b199fd0998c7cbe1813429bae5eeeac054e","head":{"label":"gabrieldagama:runAllVersionFix","ref":"runAllVersionFix","sha":"95498b199fd0998c7cbe1813429bae5eeeac054e","user":{"login":"gabrieldagama","id":3008360,"avatar_url":"https://avatars3.githubusercontent.com/u/3008360?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrieldagama","html_url":"https://github.com/gabrieldagama","followers_url":"https://api.github.com/users/gabrieldagama/followers","following_url":"https://api.github.com/users/gabrieldagama/following{/other_user}","gists_url":"https://api.github.com/users/gabrieldagama/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrieldagama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrieldagama/subscriptions","organizations_url":"https://api.github.com/users/gabrieldagama/orgs","repos_url":"https://api.github.com/users/gabrieldagama/repos","events_url":"https://api.github.com/users/gabrieldagama/events{/privacy}","received_events_url":"https://api.github.com/users/gabrieldagama/received_events","type":"User","site_admin":false},"repo":{"id":107396344,"name":"docker-phpqa","full_name":"gabrieldagama/docker-phpqa","owner":{"login":"gabrieldagama","id":3008360,"avatar_url":"https://avatars3.githubusercontent.com/u/3008360?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrieldagama","html_url":"https://github.com/gabrieldagama","followers_url":"https://api.github.com/users/gabrieldagama/followers","following_url":"https://api.github.com/users/gabrieldagama/following{/other_user}","gists_url":"https://api.github.com/users/gabrieldagama/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrieldagama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrieldagama/subscriptions","organizations_url":"https://api.github.com/users/gabrieldagama/orgs","repos_url":"https://api.github.com/users/gabrieldagama/repos","events_url":"https://api.github.com/users/gabrieldagama/events{/privacy}","received_events_url":"https://api.github.com/users/gabrieldagama/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabrieldagama/docker-phpqa","description":"Docker tools to easily create and run tests for the PHP-SRC","fork":true,"url":"https://api.github.com/repos/gabrieldagama/docker-phpqa","forks_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/forks","keys_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/teams","hooks_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/hooks","issue_events_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/issues/events{/number}","events_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/events","assignees_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/assignees{/user}","branches_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/branches{/branch}","tags_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/tags","blobs_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/statuses/{sha}","languages_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/languages","stargazers_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/stargazers","contributors_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/contributors","subscribers_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/subscribers","subscription_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/subscription","commits_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/contents/{+path}","compare_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/merges","archive_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/downloads","issues_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/issues{/number}","pulls_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/pulls{/number}","milestones_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/milestones{/number}","notifications_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/labels{/name}","releases_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/releases{/id}","deployments_url":"https://api.github.com/repos/gabrieldagama/docker-phpqa/deployments","created_at":"2017-10-18T11:03:53Z","updated_at":"2017-10-18T11:03:55Z","pushed_at":"2017-10-18T12:37:24Z","git_url":"git://github.com/gabrieldagama/docker-phpqa.git","ssh_url":"[email protected]:gabrieldagama/docker-phpqa.git","clone_url":"https://github.com/gabrieldagama/docker-phpqa.git","svn_url":"https://github.com/gabrieldagama/docker-phpqa","homepage":null,"size":70,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"herdphp:master","ref":"master","sha":"e93032c0ccaf4ae2d5a804204a0df21fea4aab16","user":{"login":"herdphp","id":7861053,"avatar_url":"https://avatars3.githubusercontent.com/u/7861053?v=4","gravatar_id":"","url":"https://api.github.com/users/herdphp","html_url":"https://github.com/herdphp","followers_url":"https://api.github.com/users/herdphp/followers","following_url":"https://api.github.com/users/herdphp/following{/other_user}","gists_url":"https://api.github.com/users/herdphp/gists{/gist_id}","starred_url":"https://api.github.com/users/herdphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herdphp/subscriptions","organizations_url":"https://api.github.com/users/herdphp/orgs","repos_url":"https://api.github.com/users/herdphp/repos","events_url":"https://api.github.com/users/herdphp/events{/privacy}","received_events_url":"https://api.github.com/users/herdphp/received_events","type":"Organization","site_admin":false},"repo":{"id":95296165,"name":"docker-phpqa","full_name":"herdphp/docker-phpqa","owner":{"login":"herdphp","id":7861053,"avatar_url":"https://avatars3.githubusercontent.com/u/7861053?v=4","gravatar_id":"","url":"https://api.github.com/users/herdphp","html_url":"https://github.com/herdphp","followers_url":"https://api.github.com/users/herdphp/followers","following_url":"https://api.github.com/users/herdphp/following{/other_user}","gists_url":"https://api.github.com/users/herdphp/gists{/gist_id}","starred_url":"https://api.github.com/users/herdphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herdphp/subscriptions","organizations_url":"https://api.github.com/users/herdphp/orgs","repos_url":"https://api.github.com/users/herdphp/repos","events_url":"https://api.github.com/users/herdphp/events{/privacy}","received_events_url":"https://api.github.com/users/herdphp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/herdphp/docker-phpqa","description":"Docker tools to easily create and run tests for the PHP-SRC","fork":false,"url":"https://api.github.com/repos/herdphp/docker-phpqa","forks_url":"https://api.github.com/repos/herdphp/docker-phpqa/forks","keys_url":"https://api.github.com/repos/herdphp/docker-phpqa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/herdphp/docker-phpqa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/herdphp/docker-phpqa/teams","hooks_url":"https://api.github.com/repos/herdphp/docker-phpqa/hooks","issue_events_url":"https://api.github.com/repos/herdphp/docker-phpqa/issues/events{/number}","events_url":"https://api.github.com/repos/herdphp/docker-phpqa/events","assignees_url":"https://api.github.com/repos/herdphp/docker-phpqa/assignees{/user}","branches_url":"https://api.github.com/repos/herdphp/docker-phpqa/branches{/branch}","tags_url":"https://api.github.com/repos/herdphp/docker-phpqa/tags","blobs_url":"https://api.github.com/repos/herdphp/docker-phpqa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/herdphp/docker-phpqa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/herdphp/docker-phpqa/git/refs{/sha}","trees_url":"https://api.github.com/repos/herdphp/docker-phpqa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/herdphp/docker-phpqa/statuses/{sha}","languages_url":"https://api.github.com/repos/herdphp/docker-phpqa/languages","stargazers_url":"https://api.github.com/repos/herdphp/docker-phpqa/stargazers","contributors_url":"https://api.github.com/repos/herdphp/docker-phpqa/contributors","subscribers_url":"https://api.github.com/repos/herdphp/docker-phpqa/subscribers","subscription_url":"https://api.github.com/repos/herdphp/docker-phpqa/subscription","commits_url":"https://api.github.com/repos/herdphp/docker-phpqa/commits{/sha}","git_commits_url":"https://api.github.com/repos/herdphp/docker-phpqa/git/commits{/sha}","comments_url":"https://api.github.com/repos/herdphp/docker-phpqa/comments{/number}","issue_comment_url":"https://api.github.com/repos/herdphp/docker-phpqa/issues/comments{/number}","contents_url":"https://api.github.com/repos/herdphp/docker-phpqa/contents/{+path}","compare_url":"https://api.github.com/repos/herdphp/docker-phpqa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/herdphp/docker-phpqa/merges","archive_url":"https://api.github.com/repos/herdphp/docker-phpqa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/herdphp/docker-phpqa/downloads","issues_url":"https://api.github.com/repos/herdphp/docker-phpqa/issues{/number}","pulls_url":"https://api.github.com/repos/herdphp/docker-phpqa/pulls{/number}","milestones_url":"https://api.github.com/repos/herdphp/docker-phpqa/milestones{/number}","notifications_url":"https://api.github.com/repos/herdphp/docker-phpqa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/herdphp/docker-phpqa/labels{/name}","releases_url":"https://api.github.com/repos/herdphp/docker-phpqa/releases{/id}","deployments_url":"https://api.github.com/repos/herdphp/docker-phpqa/deployments","created_at":"2017-06-24T12:26:45Z","updated_at":"2017-10-11T13:41:29Z","pushed_at":"2017-11-01T01:02:08Z","git_url":"git://github.com/herdphp/docker-phpqa.git","ssh_url":"[email protected]:herdphp/docker-phpqa.git","clone_url":"https://github.com/herdphp/docker-phpqa.git","svn_url":"https://github.com/herdphp/docker-phpqa","homepage":null,"size":77,"stargazers_count":27,"watchers_count":27,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":13,"forks":19,"open_issues":13,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/herdphp/docker-phpqa/pulls/55"},"html":{"href":"https://github.com/herdphp/docker-phpqa/pull/55"},"issue":{"href":"https://api.github.com/repos/herdphp/docker-phpqa/issues/55"},"comments":{"href":"https://api.github.com/repos/herdphp/docker-phpqa/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/herdphp/docker-phpqa/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/herdphp/docker-phpqa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/herdphp/docker-phpqa/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/herdphp/docker-phpqa/statuses/95498b199fd0998c7cbe1813429bae5eeeac054e"}},"author_association":"NONE"}} | {
"id": 95296165,
"name": "herdphp/docker-phpqa",
"url": "https://api.github.com/repos/herdphp/docker-phpqa"
} | {
"id": 526125,
"login": "brunoric",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/526125?",
"url": "https://api.github.com/users/brunoric"
} | {
"id": 7861053,
"login": "herdphp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7861053?",
"url": "https://api.github.com/orgs/herdphp"
} | 2017-11-06T20:22:23 | 6816706005 | {"actor":{"display_login":"brunoric"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ia-toki/training-gate-id-book/pulls/comments/158609129","pull_request_review_id":85448076,"id":158609129,"diff_hunk":"@@ -177,50 +180,52 @@ \\section{Lingkaran}\n \\begin{figure}[H]\n \\centering\n \\includegraphics[width=6cm]{../topik/pemrograman-kompetitif-dasar/10-komputasi-geometri-dasar/asset/circle.pdf}\n- \\caption{Contoh lingkaran}\n+ \\caption{Contoh lingkaran dengan titik pusat di $\\coord{x_p, y_p}$ dan jari-jari $r$.}\n \\end{figure}\n \n-\\subsection{Komputasi Pi}\n+\\subsection{Komputasi $\\pi$}\n+\n+Konstanta $\\pi$ (pi) merupakan konstanta dalam matematika yang dapat digunakan dalam pencarian luas atau keliling lingkaran.\n \n-Pi merupakan konstanta dalam matematika, dan digunakan dalam pencarian luas atau keliling lingkaran.\n-Hati-hati! Nilai pi \\textbf{tidak sama dengan} \\(\\displaystyle \\frac{22}{7}\\).\n-Penggunaan \\(\\displaystyle \\frac{22}{7}\\) hanyalah aproksimasi dari nilai pi yang sesungguhnya.\n+Hati-hati! Nilai $\\pi$ \\textbf{tidak sama dengan} \\(\\displaystyle \\frac{22}{7}\\).","path":"topik/pemrograman-kompetitif-dasar/10-komputasi-geometri-dasar/pemrograman-kompetitif-dasar-10-komputasi-geometri-dasar-book.tex","position":184,"original_position":184,"commit_id":"fdff27c95b60ffcd3b4f702192f4c087728bfb13","original_commit_id":"fdff27c95b60ffcd3b4f702192f4c087728bfb13","user":{"login":"afaji","id":6201626,"avatar_url":"https://avatars2.githubusercontent.com/u/6201626?v=4","gravatar_id":"","url":"https://api.github.com/users/afaji","html_url":"https://github.com/afaji","followers_url":"https://api.github.com/users/afaji/followers","following_url":"https://api.github.com/users/afaji/following{/other_user}","gists_url":"https://api.github.com/users/afaji/gists{/gist_id}","starred_url":"https://api.github.com/users/afaji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afaji/subscriptions","organizations_url":"https://api.github.com/users/afaji/orgs","repos_url":"https://api.github.com/users/afaji/repos","events_url":"https://api.github.com/users/afaji/events{/privacy}","received_events_url":"https://api.github.com/users/afaji/received_events","type":"User","site_admin":false},"body":"lho ini masuk ke \"importantbox\" gitu goz.","created_at":"2017-12-24T20:18:50Z","updated_at":"2017-12-24T20:18:51Z","html_url":"https://github.com/ia-toki/training-gate-id-book/pull/87#discussion_r158609129","pull_request_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/pulls/87","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ia-toki/training-gate-id-book/pulls/comments/158609129"},"html":{"href":"https://github.com/ia-toki/training-gate-id-book/pull/87#discussion_r158609129"},"pull_request":{"href":"https://api.github.com/repos/ia-toki/training-gate-id-book/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/ia-toki/training-gate-id-book/pulls/87","id":160002571,"html_url":"https://github.com/ia-toki/training-gate-id-book/pull/87","diff_url":"https://github.com/ia-toki/training-gate-id-book/pull/87.diff","patch_url":"https://github.com/ia-toki/training-gate-id-book/pull/87.patch","issue_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/issues/87","number":87,"state":"open","locked":false,"title":"Smoothing geometry","user":{"login":"gyosh","id":3478896,"avatar_url":"https://avatars3.githubusercontent.com/u/3478896?v=4","gravatar_id":"","url":"https://api.github.com/users/gyosh","html_url":"https://github.com/gyosh","followers_url":"https://api.github.com/users/gyosh/followers","following_url":"https://api.github.com/users/gyosh/following{/other_user}","gists_url":"https://api.github.com/users/gyosh/gists{/gist_id}","starred_url":"https://api.github.com/users/gyosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyosh/subscriptions","organizations_url":"https://api.github.com/users/gyosh/orgs","repos_url":"https://api.github.com/users/gyosh/repos","events_url":"https://api.github.com/users/gyosh/events{/privacy}","received_events_url":"https://api.github.com/users/gyosh/received_events","type":"User","site_admin":false},"body":"[main-125-131-joined.pdf](https://github.com/ia-toki/training-gate-id-book/files/1584889/main-125-131-joined.pdf)\r\n\r\n@afaji mohon review","created_at":"2017-12-24T15:11:15Z","updated_at":"2017-12-24T20:18:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc1bd0a7bce8dc0d0f991da39f40ea59c3e9c35b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/pulls/87/commits","review_comments_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/pulls/87/comments","review_comment_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/issues/87/comments","statuses_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/statuses/fdff27c95b60ffcd3b4f702192f4c087728bfb13","head":{"label":"ia-toki:gyosh/backflow-10","ref":"gyosh/backflow-10","sha":"fdff27c95b60ffcd3b4f702192f4c087728bfb13","user":{"login":"ia-toki","id":11017218,"avatar_url":"https://avatars0.githubusercontent.com/u/11017218?v=4","gravatar_id":"","url":"https://api.github.com/users/ia-toki","html_url":"https://github.com/ia-toki","followers_url":"https://api.github.com/users/ia-toki/followers","following_url":"https://api.github.com/users/ia-toki/following{/other_user}","gists_url":"https://api.github.com/users/ia-toki/gists{/gist_id}","starred_url":"https://api.github.com/users/ia-toki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ia-toki/subscriptions","organizations_url":"https://api.github.com/users/ia-toki/orgs","repos_url":"https://api.github.com/users/ia-toki/repos","events_url":"https://api.github.com/users/ia-toki/events{/privacy}","received_events_url":"https://api.github.com/users/ia-toki/received_events","type":"Organization","site_admin":false},"repo":{"id":108266280,"name":"training-gate-id-book","full_name":"ia-toki/training-gate-id-book","owner":{"login":"ia-toki","id":11017218,"avatar_url":"https://avatars0.githubusercontent.com/u/11017218?v=4","gravatar_id":"","url":"https://api.github.com/users/ia-toki","html_url":"https://github.com/ia-toki","followers_url":"https://api.github.com/users/ia-toki/followers","following_url":"https://api.github.com/users/ia-toki/following{/other_user}","gists_url":"https://api.github.com/users/ia-toki/gists{/gist_id}","starred_url":"https://api.github.com/users/ia-toki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ia-toki/subscriptions","organizations_url":"https://api.github.com/users/ia-toki/orgs","repos_url":"https://api.github.com/users/ia-toki/repos","events_url":"https://api.github.com/users/ia-toki/events{/privacy}","received_events_url":"https://api.github.com/users/ia-toki/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ia-toki/training-gate-id-book","description":null,"fork":false,"url":"https://api.github.com/repos/ia-toki/training-gate-id-book","forks_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/forks","keys_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/teams","hooks_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/hooks","issue_events_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/issues/events{/number}","events_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/events","assignees_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/assignees{/user}","branches_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/branches{/branch}","tags_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/tags","blobs_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/git/refs{/sha}","trees_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/statuses/{sha}","languages_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/languages","stargazers_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/stargazers","contributors_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/contributors","subscribers_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/subscribers","subscription_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/subscription","commits_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/commits{/sha}","git_commits_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/git/commits{/sha}","comments_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/comments{/number}","issue_comment_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/issues/comments{/number}","contents_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/contents/{+path}","compare_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/merges","archive_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/downloads","issues_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/issues{/number}","pulls_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/pulls{/number}","milestones_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/milestones{/number}","notifications_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/labels{/name}","releases_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/releases{/id}","deployments_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/deployments","created_at":"2017-10-25T12:23:10Z","updated_at":"2017-12-20T20:16:03Z","pushed_at":"2017-12-24T20:09:56Z","git_url":"git://github.com/ia-toki/training-gate-id-book.git","ssh_url":"[email protected]:ia-toki/training-gate-id-book.git","clone_url":"https://github.com/ia-toki/training-gate-id-book.git","svn_url":"https://github.com/ia-toki/training-gate-id-book","homepage":null,"size":3366,"stargazers_count":3,"watchers_count":3,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":27,"license":null,"forks":0,"open_issues":27,"watchers":3,"default_branch":"master"}},"base":{"label":"ia-toki:master","ref":"master","sha":"043dad0a7d6c1834948cfdfdf494f88221c3e668","user":{"login":"ia-toki","id":11017218,"avatar_url":"https://avatars0.githubusercontent.com/u/11017218?v=4","gravatar_id":"","url":"https://api.github.com/users/ia-toki","html_url":"https://github.com/ia-toki","followers_url":"https://api.github.com/users/ia-toki/followers","following_url":"https://api.github.com/users/ia-toki/following{/other_user}","gists_url":"https://api.github.com/users/ia-toki/gists{/gist_id}","starred_url":"https://api.github.com/users/ia-toki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ia-toki/subscriptions","organizations_url":"https://api.github.com/users/ia-toki/orgs","repos_url":"https://api.github.com/users/ia-toki/repos","events_url":"https://api.github.com/users/ia-toki/events{/privacy}","received_events_url":"https://api.github.com/users/ia-toki/received_events","type":"Organization","site_admin":false},"repo":{"id":108266280,"name":"training-gate-id-book","full_name":"ia-toki/training-gate-id-book","owner":{"login":"ia-toki","id":11017218,"avatar_url":"https://avatars0.githubusercontent.com/u/11017218?v=4","gravatar_id":"","url":"https://api.github.com/users/ia-toki","html_url":"https://github.com/ia-toki","followers_url":"https://api.github.com/users/ia-toki/followers","following_url":"https://api.github.com/users/ia-toki/following{/other_user}","gists_url":"https://api.github.com/users/ia-toki/gists{/gist_id}","starred_url":"https://api.github.com/users/ia-toki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ia-toki/subscriptions","organizations_url":"https://api.github.com/users/ia-toki/orgs","repos_url":"https://api.github.com/users/ia-toki/repos","events_url":"https://api.github.com/users/ia-toki/events{/privacy}","received_events_url":"https://api.github.com/users/ia-toki/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ia-toki/training-gate-id-book","description":null,"fork":false,"url":"https://api.github.com/repos/ia-toki/training-gate-id-book","forks_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/forks","keys_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/teams","hooks_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/hooks","issue_events_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/issues/events{/number}","events_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/events","assignees_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/assignees{/user}","branches_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/branches{/branch}","tags_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/tags","blobs_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/git/refs{/sha}","trees_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/statuses/{sha}","languages_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/languages","stargazers_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/stargazers","contributors_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/contributors","subscribers_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/subscribers","subscription_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/subscription","commits_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/commits{/sha}","git_commits_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/git/commits{/sha}","comments_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/comments{/number}","issue_comment_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/issues/comments{/number}","contents_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/contents/{+path}","compare_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/merges","archive_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/downloads","issues_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/issues{/number}","pulls_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/pulls{/number}","milestones_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/milestones{/number}","notifications_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/labels{/name}","releases_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/releases{/id}","deployments_url":"https://api.github.com/repos/ia-toki/training-gate-id-book/deployments","created_at":"2017-10-25T12:23:10Z","updated_at":"2017-12-20T20:16:03Z","pushed_at":"2017-12-24T20:09:56Z","git_url":"git://github.com/ia-toki/training-gate-id-book.git","ssh_url":"[email protected]:ia-toki/training-gate-id-book.git","clone_url":"https://github.com/ia-toki/training-gate-id-book.git","svn_url":"https://github.com/ia-toki/training-gate-id-book","homepage":null,"size":3366,"stargazers_count":3,"watchers_count":3,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":27,"license":null,"forks":0,"open_issues":27,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ia-toki/training-gate-id-book/pulls/87"},"html":{"href":"https://github.com/ia-toki/training-gate-id-book/pull/87"},"issue":{"href":"https://api.github.com/repos/ia-toki/training-gate-id-book/issues/87"},"comments":{"href":"https://api.github.com/repos/ia-toki/training-gate-id-book/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/ia-toki/training-gate-id-book/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/ia-toki/training-gate-id-book/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ia-toki/training-gate-id-book/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/ia-toki/training-gate-id-book/statuses/fdff27c95b60ffcd3b4f702192f4c087728bfb13"}},"author_association":"CONTRIBUTOR"}} | {
"id": 108266280,
"name": "ia-toki/training-gate-id-book",
"url": "https://api.github.com/repos/ia-toki/training-gate-id-book"
} | {
"id": 6201626,
"login": "afaji",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6201626?",
"url": "https://api.github.com/users/afaji"
} | {
"id": 11017218,
"login": "ia-toki",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11017218?",
"url": "https://api.github.com/orgs/ia-toki"
} | 2017-12-24T20:18:50 | 7027422888 | {"actor":{"display_login":"afaji"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/keybase/client/pulls/comments/119350811","pull_request_review_id":41222172,"id":119350811,"diff_hunk":"@@ -0,0 +1,121 @@\n+package teams\n+\n+import (\n+\t\"encoding/base64\"\n+\t\"errors\"\n+\t\"fmt\"\n+\n+\t\"github.com/keybase/client/go/libkb\"\n+\t\"github.com/keybase/client/go/protocol/keybase1\"\n+)\n+\n+// TeamBox comes from api server team/get endpoint.\n+type TeamBox struct {\n+\tNonce string\n+\tSenderKID keybase1.KID `json:\"sender_kid\"`\n+\tGeneration int\n+\tCtext string\n+\tPerUserKeySeqno keybase1.Seqno `json:\"per_user_key_seqno\"`\n+\tReaderKeyMasks []ReaderKeyMask `json:\"reader_key_masks\"`\n+}\n+\n+type ReaderKeyMask struct {\n+\tApplication int\n+\tGeneration int\n+\tMask string\n+}\n+\n+func (r ReaderKeyMask) MaskBytes() ([]byte, error) {\n+\treturn base64.StdEncoding.DecodeString(r.Mask)\n+}\n+\n+// Open decrypts Ctext using encKey.\n+func (t *TeamBox) Open(encKey *libkb.NaclDHKeyPair) ([]byte, error) {\n+\tnonce, err := t.nonceBytes()\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\tctext, err := t.ctextBytes()\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\tnei := &libkb.NaclEncryptionInfo{\n+\t\tCiphertext: ctext,\n+\t\tEncryptionType: libkb.KIDNaclDH,\n+\t\tNonce: nonce,\n+\t\tReceiver: encKey.GetKID().ToBytes(),\n+\t\tSender: t.SenderKID.ToBytes(),\n+\t}\n+\n+\tplaintext, _, err := encKey.Decrypt(nei)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\n+\treturn plaintext, nil\n+}\n+\n+// ApplicationKey returns the most recent key for an application.\n+func (t *TeamBox) ApplicationKey(application keybase1.TeamApplication, secret []byte) (libkb.NaclDHKeyPair, error) {\n+\tvar max ReaderKeyMask\n+\tfor _, rkm := range t.ReaderKeyMasks {\n+\t\tif keybase1.TeamApplication(rkm.Application) != application {\n+\t\t\tcontinue\n+\t\t}\n+\t\tif rkm.Generation < max.Generation {\n+\t\t\tcontinue\n+\t\t}\n+\t\tmax = rkm\n+\t}\n+\n+\tif max.Application == 0 {\n+\t\treturn libkb.NaclDHKeyPair{}, libkb.NotFoundError{Msg: fmt.Sprintf(\"no mask found for application %d\", application)}\n+\t}\n+\n+\treturn t.applicationKeyForMask(max, secret)\n+}\n+\n+func (t *TeamBox) ApplicationKeyAtGeneration(application keybase1.TeamApplication, generation int, secret []byte) (libkb.NaclDHKeyPair, error) {\n+\tfor _, rkm := range t.ReaderKeyMasks {\n+\t\tif keybase1.TeamApplication(rkm.Application) != application {\n+\t\t\tcontinue\n+\t\t}\n+\t\tif rkm.Generation != generation {\n+\t\t\tcontinue\n+\t\t}\n+\t\treturn t.applicationKeyForMask(rkm, secret)\n+\t}\n+\n+\treturn libkb.NaclDHKeyPair{}, libkb.NotFoundError{Msg: fmt.Sprintf(\"no mask found for application %d, generation %d\", application, generation)}\n+}\n+\n+func (t *TeamBox) applicationKeyForMask(mask ReaderKeyMask, secret []byte) (libkb.NaclDHKeyPair, error) {\n+\tvar derivationString string\n+\tswitch keybase1.TeamApplication(mask.Application) {\n+\tcase keybase1.TeamApplication_KBFS:\n+\t\tderivationString = libkb.TeamKBFSDerivationString\n+\tcase keybase1.TeamApplication_CHAT:\n+\t\tderivationString = libkb.TeamChatDerivationString\n+\tcase keybase1.TeamApplication_SALTPACK:\n+\t\tderivationString = libkb.TeamSaltpackDerivationString\n+\t}\n+\n+\tmaskBytes, err := mask.MaskBytes()\n+\tif err != nil {\n+\t\treturn libkb.NaclDHKeyPair{}, err\n+\t}\n+\tvar secBytes []byte\n+\tn := libkb.XORBytes(secBytes, derivedSecret(secret, derivationString), maskBytes)","path":"go/teams/box.go","position":108,"original_position":108,"commit_id":"5b3d97d2f4d136e1f72e07c9569b2fe1613243df","original_commit_id":"5b3d97d2f4d136e1f72e07c9569b2fe1613243df","user":{"login":"maxtaco","id":866815,"avatar_url":"https://avatars3.githubusercontent.com/u/866815?v=3","gravatar_id":"","url":"https://api.github.com/users/maxtaco","html_url":"https://github.com/maxtaco","followers_url":"https://api.github.com/users/maxtaco/followers","following_url":"https://api.github.com/users/maxtaco/following{/other_user}","gists_url":"https://api.github.com/users/maxtaco/gists{/gist_id}","starred_url":"https://api.github.com/users/maxtaco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxtaco/subscriptions","organizations_url":"https://api.github.com/users/maxtaco/orgs","repos_url":"https://api.github.com/users/maxtaco/repos","events_url":"https://api.github.com/users/maxtaco/events{/privacy}","received_events_url":"https://api.github.com/users/maxtaco/received_events","type":"User","site_admin":false},"body":"Can you make a typesafe wrapper here? I'm thinking back to bug 3964 or whatever...","created_at":"2017-05-31T13:15:55Z","updated_at":"2017-05-31T13:16:00Z","html_url":"https://github.com/keybase/client/pull/7208#discussion_r119350811","pull_request_url":"https://api.github.com/repos/keybase/client/pulls/7208","_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/comments/119350811"},"html":{"href":"https://github.com/keybase/client/pull/7208#discussion_r119350811"},"pull_request":{"href":"https://api.github.com/repos/keybase/client/pulls/7208"}}},"pull_request":{"url":"https://api.github.com/repos/keybase/client/pulls/7208","id":123176295,"html_url":"https://github.com/keybase/client/pull/7208","diff_url":"https://github.com/keybase/client/pull/7208.diff","patch_url":"https://github.com/keybase/client/pull/7208.patch","issue_url":"https://api.github.com/repos/keybase/client/issues/7208","number":7208,"state":"open","locked":false,"title":"Add change membership to teams package","user":{"login":"patrickxb","id":2508,"avatar_url":"https://avatars1.githubusercontent.com/u/2508?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickxb","html_url":"https://github.com/patrickxb","followers_url":"https://api.github.com/users/patrickxb/followers","following_url":"https://api.github.com/users/patrickxb/following{/other_user}","gists_url":"https://api.github.com/users/patrickxb/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickxb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickxb/subscriptions","organizations_url":"https://api.github.com/users/patrickxb/orgs","repos_url":"https://api.github.com/users/patrickxb/repos","events_url":"https://api.github.com/users/patrickxb/events{/privacy}","received_events_url":"https://api.github.com/users/patrickxb/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-31T01:31:13Z","updated_at":"2017-05-31T13:16:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7669afb8cca6c82f780aeb0dbb8602596c39d089","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/keybase/client/pulls/7208/commits","review_comments_url":"https://api.github.com/repos/keybase/client/pulls/7208/comments","review_comment_url":"https://api.github.com/repos/keybase/client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keybase/client/issues/7208/comments","statuses_url":"https://api.github.com/repos/keybase/client/statuses/5b3d97d2f4d136e1f72e07c9569b2fe1613243df","head":{"label":"keybase:patrickxb/CORE-5008","ref":"patrickxb/CORE-5008","sha":"5b3d97d2f4d136e1f72e07c9569b2fe1613243df","user":{"login":"keybase","id":5400834,"avatar_url":"https://avatars1.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"name":"client","full_name":"keybase/client","owner":{"login":"keybase","id":5400834,"avatar_url":"https://avatars1.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2017-05-31T10:18:55Z","pushed_at":"2017-05-31T12:23:31Z","git_url":"git://github.com/keybase/client.git","ssh_url":"[email protected]:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":187302,"stargazers_count":1921,"watchers_count":1921,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":166,"mirror_url":null,"open_issues_count":1033,"forks":166,"open_issues":1033,"watchers":1921,"default_branch":"master"}},"base":{"label":"keybase:master","ref":"master","sha":"5d47b0dcfe5786fd6e109a44fde8a8e22ec95799","user":{"login":"keybase","id":5400834,"avatar_url":"https://avatars1.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"name":"client","full_name":"keybase/client","owner":{"login":"keybase","id":5400834,"avatar_url":"https://avatars1.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2017-05-31T10:18:55Z","pushed_at":"2017-05-31T12:23:31Z","git_url":"git://github.com/keybase/client.git","ssh_url":"[email protected]:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":187302,"stargazers_count":1921,"watchers_count":1921,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":166,"mirror_url":null,"open_issues_count":1033,"forks":166,"open_issues":1033,"watchers":1921,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/7208"},"html":{"href":"https://github.com/keybase/client/pull/7208"},"issue":{"href":"https://api.github.com/repos/keybase/client/issues/7208"},"comments":{"href":"https://api.github.com/repos/keybase/client/issues/7208/comments"},"review_comments":{"href":"https://api.github.com/repos/keybase/client/pulls/7208/comments"},"review_comment":{"href":"https://api.github.com/repos/keybase/client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keybase/client/pulls/7208/commits"},"statuses":{"href":"https://api.github.com/repos/keybase/client/statuses/5b3d97d2f4d136e1f72e07c9569b2fe1613243df"}}}} | {
"id": 29099181,
"name": "keybase/client",
"url": "https://api.github.com/repos/keybase/client"
} | {
"id": 866815,
"login": "maxtaco",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/866815?",
"url": "https://api.github.com/users/maxtaco"
} | {
"id": 5400834,
"login": "keybase",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5400834?",
"url": "https://api.github.com/orgs/keybase"
} | 2017-05-31T13:15:55 | 5974612126 | {"actor":{"display_login":"maxtaco"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/keybase/kbfs/pulls/comments/105296285","pull_request_review_id":26171323,"id":105296285,"diff_hunk":"@@ -0,0 +1,526 @@\n+// Copyright 2017 Keybase Inc. All rights reserved.\n+// Use of this source code is governed by a BSD\n+// license that can be found in the LICENSE file.\n+\n+package libkbfs\n+\n+import (\n+\t\"context\"\n+\t\"fmt\"\n+\t\"sync\"\n+\t\"sync/atomic\"\n+\t\"time\"\n+\n+\t\"github.com/keybase/client/go/logger\"\n+\t\"github.com/keybase/kbfs/tlf\"\n+)\n+\n+/*\n+\n+ This file defines a finite state machine (FSM) for rekey operation scheduling.\n+ The state chart is described in following dot graph:\n+\n+digraph rekeyFSM {\n+ graph [rankdir=LR]\n+ start [shape=plaintext]\n+\n+ Idle -> Idle [label=\"*\"]\n+ Scheduled -> Scheduled [label=\"*\"]\n+ Started -> Started [label=\"*\"]\n+\n+ start -> Idle\n+ Idle -> Scheduled [label=Request]\n+ Scheduled -> Scheduled [label=Request]\n+ Scheduled -> Started [label=Timeup]\n+ Started -> Scheduled [label=\"Finished(TTL valid && (rekey done || needs paper))\"]\n+ Started -> Idle [label=\"Finished (*)\"]\n+}\n+\n+*/\n+\n+// CtxRekeyTagKey is the type used for unique context tags within an\n+// enqueued Rekey.\n+type CtxRekeyTagKey int\n+\n+const (\n+\t// CtxRekeyIDKey is the type of the tag for unique operation IDs\n+\t// within an enqueued Rekey.\n+\tCtxRekeyIDKey CtxRekeyTagKey = iota\n+)\n+\n+// CtxRekeyOpID is the display name for the unique operation\n+// enqueued rekey ID tag.\n+const CtxRekeyOpID = \"REKEYID\"\n+\n+type rekeyEventType int\n+\n+const (\n+\t_ rekeyEventType = iota\n+\trekeyRequestEvent\n+\trekeyFinishedEvent\n+\trekeyTimeupEvent\n+\n+\trekeyShutdownEvent\n+\n+\trekeyKickoffEventForTest\n+\trekeyCancelEventForTest\n+)\n+\n+func (e rekeyEventType) String() string {\n+\tswitch e {\n+\tcase rekeyRequestEvent:\n+\t\treturn \"rekeyRequestEvent\"\n+\tcase rekeyFinishedEvent:\n+\t\treturn \"rekeyFinishedEvent\"\n+\tcase rekeyTimeupEvent:\n+\t\treturn \"rekeyTimeupEvent\"\n+\tcase rekeyShutdownEvent:\n+\t\treturn \"rekeyShutdownEvent\"\n+\tcase rekeyKickoffEventForTest:\n+\t\treturn \"rekeyKickoffEventForTest\"\n+\tcase rekeyCancelEventForTest:\n+\t\treturn \"rekeyCancelEventForTest\"\n+\tdefault:\n+\t\treturn \"unknown\"\n+\t}\n+}\n+\n+// rekeyTask describes a rekey task.\n+type rekeyTask struct {\n+\t// timeout, if non-nil, causes rekey to fail if it takes more than this\n+\t// duration since it enters rekeyStateStarted.\n+\ttimeout *time.Duration\n+\tttl int\n+\tpromptPaper bool\n+\n+\tctx *protectedContext\n+}\n+\n+// rekeyRequest describes a rekey request.\n+type rekeyRequest struct {\n+\t// delay is the duration to wait for since the request enters the FSM until\n+\t// starting the rekey.\n+\tdelay time.Duration\n+\trekeyTask\n+}\n+\n+// rekeyFinished describes a rekeyFinishedEvent. It contains results from an\n+// actual rekey operation.\n+type rekeyFinished struct {\n+\tRekeyResult\n+\terr error\n+}\n+\n+// RekeyEvent describes an event to send into the RekeyFSM. A function, e.g.,\n+// NewRekeyRequestEvent, should be used to construct one.\n+type RekeyEvent struct {\n+\teventType rekeyEventType\n+\trequest *rekeyRequest\n+\tfinished *rekeyFinished\n+}\n+\n+func (e RekeyEvent) String() string {\n+\tswitch e.eventType {\n+\tcase rekeyRequestEvent:\n+\t\treturn fmt.Sprintf(\"%s [%#+v]\", e.eventType, e.request)\n+\tcase rekeyFinishedEvent:\n+\t\treturn fmt.Sprintf(\"%s [%#+v]\", e.eventType, e.finished)\n+\tdefault:\n+\t\treturn e.eventType.String()\n+\t}\n+}\n+\n+func newRekeyRequestEvent(req rekeyRequest) RekeyEvent {\n+\treturn RekeyEvent{\n+\t\teventType: rekeyRequestEvent,\n+\t\trequest: &req,\n+\t}\n+}\n+\n+func newRekeyRequestEventWithContext(ctx context.Context) RekeyEvent {\n+\treturn newRekeyRequestEvent(rekeyRequest{\n+\t\tdelay: 0,\n+\t\trekeyTask: rekeyTask{\n+\t\t\ttimeout: nil,\n+\t\t\tpromptPaper: false,\n+\t\t\tttl: rekeyInitialTTL,\n+\t\t\tctx: newProtectedContext(ctx, nil),\n+\t\t},\n+\t})\n+}\n+\n+// NewRekeyRequestWithPaperPromptEvent creates a non-delayed rekey request\n+// Event that causes a paper prompt.\n+func NewRekeyRequestWithPaperPromptEvent() RekeyEvent {\n+\te := NewRekeyRequestEvent()\n+\td := rekeyWithPromptWaitTimeDefault\n+\te.request.promptPaper = true\n+\te.request.timeout = &d\n+\treturn e\n+}\n+\n+// NewRekeyRequestEvent creates a non-delayed rekey request Event.\n+func NewRekeyRequestEvent() RekeyEvent {\n+\treturn newRekeyRequestEventWithContext(ctxWithRandomIDReplayable(\n+\t\tcontext.Background(), CtxRekeyIDKey, CtxRekeyOpID, nil))\n+}\n+\n+func newRekeyFinishedEvent(res RekeyResult, err error) RekeyEvent {\n+\treturn RekeyEvent{\n+\t\teventType: rekeyFinishedEvent,\n+\t\tfinished: &rekeyFinished{\n+\t\t\tRekeyResult: res,\n+\t\t\terr: err,\n+\t\t},\n+\t}\n+}\n+\n+func newRekeyTimeupEvent() RekeyEvent {\n+\treturn RekeyEvent{\n+\t\teventType: rekeyTimeupEvent,\n+\t}\n+}\n+\n+func newRekeyShutdownEvent() RekeyEvent {\n+\treturn RekeyEvent{\n+\t\teventType: rekeyShutdownEvent,\n+\t}\n+}\n+\n+func newRekeyKickoffEventForTest() RekeyEvent {\n+\treturn RekeyEvent{\n+\t\teventType: rekeyKickoffEventForTest,\n+\t}\n+}\n+\n+func newRekeyCancelEventForTest() RekeyEvent {\n+\treturn RekeyEvent{\n+\t\teventType: rekeyCancelEventForTest,\n+\t}\n+}\n+\n+// rekeyState models a state in the FSM. rekeyFSM keeps exactly one instance of\n+// rekeyState at any given time.\n+type rekeyState interface {\n+\t// reactToEvent defines how this state reacts to an event. Implementations of\n+\t// rekeyState should handle necessary transition actions in reactToEvent(),\n+\t// and return a new rekeyState instance after transition is finished.\n+\t// rekeyFSM sends event to the rekeyState instance it holds whenever it\n+\t// receives an event, and use the returned rekeyState instance as new state.\n+\t// It's OK to return the receiver itself as \"new\" state.\n+\t//\n+\t// rekeyFSM runs an event loop in a dedicated goroutine that calls\n+\t// reactToEvent and updates states. In other words, it's safe to assume\n+\t// reactToEvent is only called within the same goroutine, and that it's\n+\t// impossible that multiple reactToEvent calls are issued concurrently.\n+\treactToEvent(event RekeyEvent) rekeyState\n+}\n+\n+type rekeyStateIdle struct {\n+\tfsm *rekeyFSM\n+}\n+\n+func newRekeyStateIdle(fsm *rekeyFSM) *rekeyStateIdle {\n+\treturn &rekeyStateIdle{fsm: fsm}\n+}\n+\n+func (r *rekeyStateIdle) reactToEvent(event RekeyEvent) rekeyState {\n+\tswitch event.eventType {\n+\tcase rekeyRequestEvent:\n+\t\treturn newRekeyStateScheduled(r.fsm,\n+\t\t\tevent.request.delay, event.request.rekeyTask)\n+\tdefault:\n+\t\treturn r\n+\t}\n+}\n+\n+type rekeyStateScheduled struct {\n+\tfsm *rekeyFSM\n+\n+\ttimer *time.Timer\n+\tdeadline time.Time\n+\n+\ttask rekeyTask\n+}\n+\n+func newRekeyStateScheduled(\n+\tfsm *rekeyFSM, delay time.Duration, task rekeyTask) *rekeyStateScheduled {\n+\ttask.ctx.setLogger(fsm.log)\n+\treturn &rekeyStateScheduled{\n+\t\tfsm: fsm,\n+\t\ttimer: time.AfterFunc(delay, func() {\n+\t\t\tfsm.Event(newRekeyTimeupEvent())\n+\t\t}),\n+\t\tdeadline: time.Now().Add(delay),\n+\t\ttask: task,\n+\t}\n+}\n+\n+func (r *rekeyStateScheduled) reactToEvent(event RekeyEvent) rekeyState {\n+\tswitch event.eventType {\n+\tcase rekeyTimeupEvent:\n+\t\treturn newRekeyStateStarted(r.fsm, r.task)\n+\tcase rekeyRequestEvent:\n+\t\ttask := r.task\n+\t\ttask.promptPaper = task.promptPaper || event.request.promptPaper\n+\t\tif task.timeout == nil {\n+\t\t\ttask.timeout = event.request.timeout\n+\t\t}\n+\t\ttask.ttl = event.request.ttl\n+\t\ttask.ctx.maybeReplaceContext(event.request.ctx.context())\n+\t\tif !r.deadline.After(time.Now().Add(event.request.delay)) {\n+\t\t\tr.fsm.log.CDebugf(task.ctx.context(), \"Reusing existing timer\")\n+\t\t\tr.task = task\n+\t\t\treturn r\n+\t\t}\n+\t\tr.timer.Stop()\n+\t\treturn newRekeyStateScheduled(r.fsm, event.request.delay, task)\n+\tcase rekeyKickoffEventForTest:\n+\t\tr.timer.Reset(time.Millisecond)\n+\t\treturn r\n+\tcase rekeyCancelEventForTest:\n+\t\tr.timer.Stop()\n+\t\treturn newRekeyStateIdle(r.fsm)\n+\tcase rekeyShutdownEvent:\n+\t\tr.timer.Stop()\n+\t\treturn r\n+\tdefault:\n+\t\treturn r\n+\t}\n+}\n+\n+type rekeyStateStarted struct {\n+\tfsm *rekeyFSM\n+\ttask rekeyTask\n+}\n+\n+func newRekeyStateStarted(fsm *rekeyFSM, task rekeyTask) *rekeyStateStarted {\n+\tctx := task.ctx.context()\n+\tvar cancel context.CancelFunc\n+\tif task.timeout != nil {\n+\t\tctx, cancel = context.WithTimeout(task.ctx.context(), *task.timeout)\n+\t}\n+\tgo func() {\n+\t\tif cancel != nil {\n+\t\t\tdefer cancel()\n+\t\t}\n+\t\tfsm.log.CDebugf(ctx, \"Processing rekey for %s\", fsm.fbo.folderBranch.Tlf)\n+\t\tvar res RekeyResult\n+\t\terr := fsm.fbo.doMDWriteWithRetryUnlessCanceled(ctx,\n+\t\t\tfunc(lState *lockState) (err error) {\n+\t\t\t\tres, err = fsm.fbo.rekeyLocked(ctx, lState, task.promptPaper)\n+\t\t\t\treturn err\n+\t\t\t})\n+\t\tfsm.log.CDebugf(ctx, \"Rekey finished with res=%#+v, error=%v\", res, err)\n+\t\tfsm.Event(newRekeyFinishedEvent(res, err))\n+\t}()\n+\treturn &rekeyStateStarted{\n+\t\tfsm: fsm,\n+\t\ttask: task,\n+\t}\n+}\n+\n+func (r *rekeyStateStarted) reactToEvent(event RekeyEvent) rekeyState {\n+\tswitch event.eventType {\n+\tcase rekeyFinishedEvent:\n+\t\tttl := r.task.ttl - 1\n+\t\tr.fsm.log.CDebugf(r.task.ctx.context(),\n+\t\t\t\"Rekey finished, ttl: %d -> %d\", r.task.ttl, ttl)\n+\n+\t\tif ttl <= 0 {\n+\t\t\tr.fsm.log.CDebugf(r.task.ctx.context(),\n+\t\t\t\t\"Not scheduling new rekey because TTL expired\")\n+\t\t\treturn newRekeyStateIdle(r.fsm)\n+\t\t}\n+\n+\t\tswitch event.finished.err {","path":"libkbfs/rekey_fsm.go","position":336,"original_position":336,"commit_id":"2988c9212c546c93666153db96984a07cd4c2269","original_commit_id":"2988c9212c546c93666153db96984a07cd4c2269","user":{"login":"strib","id":8516691,"avatar_url":"https://avatars3.githubusercontent.com/u/8516691?v=3","gravatar_id":"","url":"https://api.github.com/users/strib","html_url":"https://github.com/strib","followers_url":"https://api.github.com/users/strib/followers","following_url":"https://api.github.com/users/strib/following{/other_user}","gists_url":"https://api.github.com/users/strib/gists{/gist_id}","starred_url":"https://api.github.com/users/strib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strib/subscriptions","organizations_url":"https://api.github.com/users/strib/orgs","repos_url":"https://api.github.com/users/strib/repos","events_url":"https://api.github.com/users/strib/events{/privacy}","received_events_url":"https://api.github.com/users/strib/received_events","type":"User","site_admin":false},"body":"Ah thanks, I missed that.","created_at":"2017-03-09T23:24:05Z","updated_at":"2017-03-09T23:24:05Z","html_url":"https://github.com/keybase/kbfs/pull/805#discussion_r105296285","pull_request_url":"https://api.github.com/repos/keybase/kbfs/pulls/805","_links":{"self":{"href":"https://api.github.com/repos/keybase/kbfs/pulls/comments/105296285"},"html":{"href":"https://github.com/keybase/kbfs/pull/805#discussion_r105296285"},"pull_request":{"href":"https://api.github.com/repos/keybase/kbfs/pulls/805"}}},"pull_request":{"url":"https://api.github.com/repos/keybase/kbfs/pulls/805","id":108210377,"html_url":"https://github.com/keybase/kbfs/pull/805","diff_url":"https://github.com/keybase/kbfs/pull/805.diff","patch_url":"https://github.com/keybase/kbfs/pull/805.patch","issue_url":"https://api.github.com/repos/keybase/kbfs/issues/805","number":805,"state":"open","locked":false,"title":"refactor rekey scheduling and add a 30s recheck","user":{"login":"songgao","id":255797,"avatar_url":"https://avatars0.githubusercontent.com/u/255797?v=3","gravatar_id":"","url":"https://api.github.com/users/songgao","html_url":"https://github.com/songgao","followers_url":"https://api.github.com/users/songgao/followers","following_url":"https://api.github.com/users/songgao/following{/other_user}","gists_url":"https://api.github.com/users/songgao/gists{/gist_id}","starred_url":"https://api.github.com/users/songgao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/songgao/subscriptions","organizations_url":"https://api.github.com/users/songgao/orgs","repos_url":"https://api.github.com/users/songgao/repos","events_url":"https://api.github.com/users/songgao/events{/privacy}","received_events_url":"https://api.github.com/users/songgao/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-27T21:57:34Z","updated_at":"2017-03-09T23:24:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b879ec9a8ba701e5f893ec24608e66371c6e2816","assignee":{"login":"strib","id":8516691,"avatar_url":"https://avatars3.githubusercontent.com/u/8516691?v=3","gravatar_id":"","url":"https://api.github.com/users/strib","html_url":"https://github.com/strib","followers_url":"https://api.github.com/users/strib/followers","following_url":"https://api.github.com/users/strib/following{/other_user}","gists_url":"https://api.github.com/users/strib/gists{/gist_id}","starred_url":"https://api.github.com/users/strib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strib/subscriptions","organizations_url":"https://api.github.com/users/strib/orgs","repos_url":"https://api.github.com/users/strib/repos","events_url":"https://api.github.com/users/strib/events{/privacy}","received_events_url":"https://api.github.com/users/strib/received_events","type":"User","site_admin":false},"assignees":[{"login":"strib","id":8516691,"avatar_url":"https://avatars3.githubusercontent.com/u/8516691?v=3","gravatar_id":"","url":"https://api.github.com/users/strib","html_url":"https://github.com/strib","followers_url":"https://api.github.com/users/strib/followers","following_url":"https://api.github.com/users/strib/following{/other_user}","gists_url":"https://api.github.com/users/strib/gists{/gist_id}","starred_url":"https://api.github.com/users/strib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strib/subscriptions","organizations_url":"https://api.github.com/users/strib/orgs","repos_url":"https://api.github.com/users/strib/repos","events_url":"https://api.github.com/users/strib/events{/privacy}","received_events_url":"https://api.github.com/users/strib/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/keybase/kbfs/pulls/805/commits","review_comments_url":"https://api.github.com/repos/keybase/kbfs/pulls/805/comments","review_comment_url":"https://api.github.com/repos/keybase/kbfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keybase/kbfs/issues/805/comments","statuses_url":"https://api.github.com/repos/keybase/kbfs/statuses/2988c9212c546c93666153db96984a07cd4c2269","head":{"label":"keybase:songgao/KBFS-1964","ref":"songgao/KBFS-1964","sha":"2988c9212c546c93666153db96984a07cd4c2269","user":{"login":"keybase","id":5400834,"avatar_url":"https://avatars1.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":59787605,"name":"kbfs","full_name":"keybase/kbfs","owner":{"login":"keybase","id":5400834,"avatar_url":"https://avatars1.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keybase/kbfs","description":"Keybase Filesystem (KBFS)","fork":false,"url":"https://api.github.com/repos/keybase/kbfs","forks_url":"https://api.github.com/repos/keybase/kbfs/forks","keys_url":"https://api.github.com/repos/keybase/kbfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/kbfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/kbfs/teams","hooks_url":"https://api.github.com/repos/keybase/kbfs/hooks","issue_events_url":"https://api.github.com/repos/keybase/kbfs/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/kbfs/events","assignees_url":"https://api.github.com/repos/keybase/kbfs/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/kbfs/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/kbfs/tags","blobs_url":"https://api.github.com/repos/keybase/kbfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/kbfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/kbfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/kbfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/kbfs/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/kbfs/languages","stargazers_url":"https://api.github.com/repos/keybase/kbfs/stargazers","contributors_url":"https://api.github.com/repos/keybase/kbfs/contributors","subscribers_url":"https://api.github.com/repos/keybase/kbfs/subscribers","subscription_url":"https://api.github.com/repos/keybase/kbfs/subscription","commits_url":"https://api.github.com/repos/keybase/kbfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/kbfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/kbfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/kbfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/kbfs/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/kbfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/kbfs/merges","archive_url":"https://api.github.com/repos/keybase/kbfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/kbfs/downloads","issues_url":"https://api.github.com/repos/keybase/kbfs/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/kbfs/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/kbfs/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/kbfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/kbfs/labels{/name}","releases_url":"https://api.github.com/repos/keybase/kbfs/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/kbfs/deployments","created_at":"2016-05-26T22:37:42Z","updated_at":"2017-03-09T21:54:54Z","pushed_at":"2017-03-09T23:09:30Z","git_url":"git://github.com/keybase/kbfs.git","ssh_url":"[email protected]:keybase/kbfs.git","clone_url":"https://github.com/keybase/kbfs.git","svn_url":"https://github.com/keybase/kbfs","homepage":"https://keybase.io/docs/kbfs","size":52596,"stargazers_count":398,"watchers_count":398,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":32,"forks":41,"open_issues":32,"watchers":398,"default_branch":"master"}},"base":{"label":"keybase:master","ref":"master","sha":"6b38cf769ae6213993aa5bb31b1d80d50fdb3d94","user":{"login":"keybase","id":5400834,"avatar_url":"https://avatars1.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":59787605,"name":"kbfs","full_name":"keybase/kbfs","owner":{"login":"keybase","id":5400834,"avatar_url":"https://avatars1.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keybase/kbfs","description":"Keybase Filesystem (KBFS)","fork":false,"url":"https://api.github.com/repos/keybase/kbfs","forks_url":"https://api.github.com/repos/keybase/kbfs/forks","keys_url":"https://api.github.com/repos/keybase/kbfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/kbfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/kbfs/teams","hooks_url":"https://api.github.com/repos/keybase/kbfs/hooks","issue_events_url":"https://api.github.com/repos/keybase/kbfs/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/kbfs/events","assignees_url":"https://api.github.com/repos/keybase/kbfs/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/kbfs/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/kbfs/tags","blobs_url":"https://api.github.com/repos/keybase/kbfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/kbfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/kbfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/kbfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/kbfs/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/kbfs/languages","stargazers_url":"https://api.github.com/repos/keybase/kbfs/stargazers","contributors_url":"https://api.github.com/repos/keybase/kbfs/contributors","subscribers_url":"https://api.github.com/repos/keybase/kbfs/subscribers","subscription_url":"https://api.github.com/repos/keybase/kbfs/subscription","commits_url":"https://api.github.com/repos/keybase/kbfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/kbfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/kbfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/kbfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/kbfs/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/kbfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/kbfs/merges","archive_url":"https://api.github.com/repos/keybase/kbfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/kbfs/downloads","issues_url":"https://api.github.com/repos/keybase/kbfs/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/kbfs/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/kbfs/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/kbfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/kbfs/labels{/name}","releases_url":"https://api.github.com/repos/keybase/kbfs/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/kbfs/deployments","created_at":"2016-05-26T22:37:42Z","updated_at":"2017-03-09T21:54:54Z","pushed_at":"2017-03-09T23:09:30Z","git_url":"git://github.com/keybase/kbfs.git","ssh_url":"[email protected]:keybase/kbfs.git","clone_url":"https://github.com/keybase/kbfs.git","svn_url":"https://github.com/keybase/kbfs","homepage":"https://keybase.io/docs/kbfs","size":52596,"stargazers_count":398,"watchers_count":398,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":32,"forks":41,"open_issues":32,"watchers":398,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keybase/kbfs/pulls/805"},"html":{"href":"https://github.com/keybase/kbfs/pull/805"},"issue":{"href":"https://api.github.com/repos/keybase/kbfs/issues/805"},"comments":{"href":"https://api.github.com/repos/keybase/kbfs/issues/805/comments"},"review_comments":{"href":"https://api.github.com/repos/keybase/kbfs/pulls/805/comments"},"review_comment":{"href":"https://api.github.com/repos/keybase/kbfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keybase/kbfs/pulls/805/commits"},"statuses":{"href":"https://api.github.com/repos/keybase/kbfs/statuses/2988c9212c546c93666153db96984a07cd4c2269"}}}} | {
"id": 59787605,
"name": "keybase/kbfs",
"url": "https://api.github.com/repos/keybase/kbfs"
} | {
"id": 8516691,
"login": "strib",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8516691?",
"url": "https://api.github.com/users/strib"
} | {
"id": 5400834,
"login": "keybase",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5400834?",
"url": "https://api.github.com/orgs/keybase"
} | 2017-03-09T23:24:05 | 5466941180 | {"actor":{"display_login":"strib"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/labzero/hedwig_simple_responders/pulls/comments/106561394","pull_request_review_id":27490279,"id":106561394,"diff_hunk":"@@ -0,0 +1,78 @@\n+defmodule HedwigSimpleResponders.JonyIve do\n+ @moduledoc \"\"\"\n+ A random collection of Jony Ive words mashed together.\n+\n+ Credit to @bloodyowl for the Jony Ive bullshit generator ","path":"lib/hedwig_simple_responders/responders/jonyive.ex","position":5,"original_position":5,"commit_id":"9181483632c69b6b019b56ef295d973a6b9163bd","original_commit_id":"9181483632c69b6b019b56ef295d973a6b9163bd","user":{"login":"brienw","id":750692,"avatar_url":"https://avatars0.githubusercontent.com/u/750692?v=3","gravatar_id":"","url":"https://api.github.com/users/brienw","html_url":"https://github.com/brienw","followers_url":"https://api.github.com/users/brienw/followers","following_url":"https://api.github.com/users/brienw/following{/other_user}","gists_url":"https://api.github.com/users/brienw/gists{/gist_id}","starred_url":"https://api.github.com/users/brienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brienw/subscriptions","organizations_url":"https://api.github.com/users/brienw/orgs","repos_url":"https://api.github.com/users/brienw/repos","events_url":"https://api.github.com/users/brienw/events{/privacy}","received_events_url":"https://api.github.com/users/brienw/received_events","type":"User","site_admin":false},"body":"There should be no trailing white-space at the end of a line.","created_at":"2017-03-17T00:18:57Z","updated_at":"2017-03-17T00:18:57Z","html_url":"https://github.com/labzero/hedwig_simple_responders/pull/13#discussion_r106561394","pull_request_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/labzero/hedwig_simple_responders/pulls/comments/106561394"},"html":{"href":"https://github.com/labzero/hedwig_simple_responders/pull/13#discussion_r106561394"},"pull_request":{"href":"https://api.github.com/repos/labzero/hedwig_simple_responders/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/labzero/hedwig_simple_responders/pulls/13","id":111191800,"html_url":"https://github.com/labzero/hedwig_simple_responders/pull/13","diff_url":"https://github.com/labzero/hedwig_simple_responders/pull/13.diff","patch_url":"https://github.com/labzero/hedwig_simple_responders/pull/13.patch","issue_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/issues/13","number":13,"state":"open","locked":false,"title":"Add JonyIve responder","user":{"login":"rjanja","id":164802,"avatar_url":"https://avatars1.githubusercontent.com/u/164802?v=3","gravatar_id":"","url":"https://api.github.com/users/rjanja","html_url":"https://github.com/rjanja","followers_url":"https://api.github.com/users/rjanja/followers","following_url":"https://api.github.com/users/rjanja/following{/other_user}","gists_url":"https://api.github.com/users/rjanja/gists{/gist_id}","starred_url":"https://api.github.com/users/rjanja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjanja/subscriptions","organizations_url":"https://api.github.com/users/rjanja/orgs","repos_url":"https://api.github.com/users/rjanja/repos","events_url":"https://api.github.com/users/rjanja/events{/privacy}","received_events_url":"https://api.github.com/users/rjanja/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-17T00:18:22Z","updated_at":"2017-03-17T00:18:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cc21c65b9c77fb6b04c1a4616a0b4fead097219","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/pulls/13/commits","review_comments_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/pulls/13/comments","review_comment_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/pulls/comments{/number}","comments_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/issues/13/comments","statuses_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/statuses/9181483632c69b6b019b56ef295d973a6b9163bd","head":{"label":"labzero:jony-ive","ref":"jony-ive","sha":"9181483632c69b6b019b56ef295d973a6b9163bd","user":{"login":"labzero","id":62872,"avatar_url":"https://avatars1.githubusercontent.com/u/62872?v=3","gravatar_id":"","url":"https://api.github.com/users/labzero","html_url":"https://github.com/labzero","followers_url":"https://api.github.com/users/labzero/followers","following_url":"https://api.github.com/users/labzero/following{/other_user}","gists_url":"https://api.github.com/users/labzero/gists{/gist_id}","starred_url":"https://api.github.com/users/labzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labzero/subscriptions","organizations_url":"https://api.github.com/users/labzero/orgs","repos_url":"https://api.github.com/users/labzero/repos","events_url":"https://api.github.com/users/labzero/events{/privacy}","received_events_url":"https://api.github.com/users/labzero/received_events","type":"Organization","site_admin":false},"repo":{"id":75117660,"name":"hedwig_simple_responders","full_name":"labzero/hedwig_simple_responders","owner":{"login":"labzero","id":62872,"avatar_url":"https://avatars1.githubusercontent.com/u/62872?v=3","gravatar_id":"","url":"https://api.github.com/users/labzero","html_url":"https://github.com/labzero","followers_url":"https://api.github.com/users/labzero/followers","following_url":"https://api.github.com/users/labzero/following{/other_user}","gists_url":"https://api.github.com/users/labzero/gists{/gist_id}","starred_url":"https://api.github.com/users/labzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labzero/subscriptions","organizations_url":"https://api.github.com/users/labzero/orgs","repos_url":"https://api.github.com/users/labzero/repos","events_url":"https://api.github.com/users/labzero/events{/privacy}","received_events_url":"https://api.github.com/users/labzero/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/labzero/hedwig_simple_responders","description":"A collection of Responders for Hedwig","fork":false,"url":"https://api.github.com/repos/labzero/hedwig_simple_responders","forks_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/forks","keys_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/keys{/key_id}","collaborators_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/teams","hooks_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/hooks","issue_events_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/issues/events{/number}","events_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/events","assignees_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/assignees{/user}","branches_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/branches{/branch}","tags_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/tags","blobs_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/git/refs{/sha}","trees_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/git/trees{/sha}","statuses_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/statuses/{sha}","languages_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/languages","stargazers_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/stargazers","contributors_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/contributors","subscribers_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/subscribers","subscription_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/subscription","commits_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/commits{/sha}","git_commits_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/git/commits{/sha}","comments_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/comments{/number}","issue_comment_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/issues/comments{/number}","contents_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/contents/{+path}","compare_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/compare/{base}...{head}","merges_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/merges","archive_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/downloads","issues_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/issues{/number}","pulls_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/pulls{/number}","milestones_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/milestones{/number}","notifications_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/labels{/name}","releases_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/releases{/id}","deployments_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/deployments","created_at":"2016-11-29T20:08:45Z","updated_at":"2017-03-14T18:40:41Z","pushed_at":"2017-03-17T00:18:22Z","git_url":"git://github.com/labzero/hedwig_simple_responders.git","ssh_url":"[email protected]:labzero/hedwig_simple_responders.git","clone_url":"https://github.com/labzero/hedwig_simple_responders.git","svn_url":"https://github.com/labzero/hedwig_simple_responders","homepage":null,"size":60,"stargazers_count":2,"watchers_count":2,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"labzero:master","ref":"master","sha":"487c155d00da134810316cc5a4da806e8265e08a","user":{"login":"labzero","id":62872,"avatar_url":"https://avatars1.githubusercontent.com/u/62872?v=3","gravatar_id":"","url":"https://api.github.com/users/labzero","html_url":"https://github.com/labzero","followers_url":"https://api.github.com/users/labzero/followers","following_url":"https://api.github.com/users/labzero/following{/other_user}","gists_url":"https://api.github.com/users/labzero/gists{/gist_id}","starred_url":"https://api.github.com/users/labzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labzero/subscriptions","organizations_url":"https://api.github.com/users/labzero/orgs","repos_url":"https://api.github.com/users/labzero/repos","events_url":"https://api.github.com/users/labzero/events{/privacy}","received_events_url":"https://api.github.com/users/labzero/received_events","type":"Organization","site_admin":false},"repo":{"id":75117660,"name":"hedwig_simple_responders","full_name":"labzero/hedwig_simple_responders","owner":{"login":"labzero","id":62872,"avatar_url":"https://avatars1.githubusercontent.com/u/62872?v=3","gravatar_id":"","url":"https://api.github.com/users/labzero","html_url":"https://github.com/labzero","followers_url":"https://api.github.com/users/labzero/followers","following_url":"https://api.github.com/users/labzero/following{/other_user}","gists_url":"https://api.github.com/users/labzero/gists{/gist_id}","starred_url":"https://api.github.com/users/labzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labzero/subscriptions","organizations_url":"https://api.github.com/users/labzero/orgs","repos_url":"https://api.github.com/users/labzero/repos","events_url":"https://api.github.com/users/labzero/events{/privacy}","received_events_url":"https://api.github.com/users/labzero/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/labzero/hedwig_simple_responders","description":"A collection of Responders for Hedwig","fork":false,"url":"https://api.github.com/repos/labzero/hedwig_simple_responders","forks_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/forks","keys_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/keys{/key_id}","collaborators_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/teams","hooks_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/hooks","issue_events_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/issues/events{/number}","events_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/events","assignees_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/assignees{/user}","branches_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/branches{/branch}","tags_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/tags","blobs_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/git/refs{/sha}","trees_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/git/trees{/sha}","statuses_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/statuses/{sha}","languages_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/languages","stargazers_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/stargazers","contributors_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/contributors","subscribers_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/subscribers","subscription_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/subscription","commits_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/commits{/sha}","git_commits_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/git/commits{/sha}","comments_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/comments{/number}","issue_comment_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/issues/comments{/number}","contents_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/contents/{+path}","compare_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/compare/{base}...{head}","merges_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/merges","archive_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/downloads","issues_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/issues{/number}","pulls_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/pulls{/number}","milestones_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/milestones{/number}","notifications_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/labels{/name}","releases_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/releases{/id}","deployments_url":"https://api.github.com/repos/labzero/hedwig_simple_responders/deployments","created_at":"2016-11-29T20:08:45Z","updated_at":"2017-03-14T18:40:41Z","pushed_at":"2017-03-17T00:18:22Z","git_url":"git://github.com/labzero/hedwig_simple_responders.git","ssh_url":"[email protected]:labzero/hedwig_simple_responders.git","clone_url":"https://github.com/labzero/hedwig_simple_responders.git","svn_url":"https://github.com/labzero/hedwig_simple_responders","homepage":null,"size":60,"stargazers_count":2,"watchers_count":2,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/labzero/hedwig_simple_responders/pulls/13"},"html":{"href":"https://github.com/labzero/hedwig_simple_responders/pull/13"},"issue":{"href":"https://api.github.com/repos/labzero/hedwig_simple_responders/issues/13"},"comments":{"href":"https://api.github.com/repos/labzero/hedwig_simple_responders/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/labzero/hedwig_simple_responders/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/labzero/hedwig_simple_responders/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/labzero/hedwig_simple_responders/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/labzero/hedwig_simple_responders/statuses/9181483632c69b6b019b56ef295d973a6b9163bd"}}}} | {
"id": 75117660,
"name": "labzero/hedwig_simple_responders",
"url": "https://api.github.com/repos/labzero/hedwig_simple_responders"
} | {
"id": 750692,
"login": "brienw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/750692?",
"url": "https://api.github.com/users/brienw"
} | {
"id": 62872,
"login": "labzero",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/62872?",
"url": "https://api.github.com/orgs/labzero"
} | 2017-03-17T00:18:57 | 5510541337 | {"actor":{"display_login":"brienw"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/liferay/liferay-screens/pulls/comments/130565617","pull_request_review_id":53452621,"id":130565617,"diff_hunk":"@@ -0,0 +1,46 @@\n+function modifyItem() {\n+ \n+ var urlIcons = {\n+ pdf: \"/documents/33300/39232/pdf.png/8c743026-cc37-07c3-1681-d7c9f4083b59\",","path":"ios/Samples/WesterosEmployees-hybrid/App/WesterosEmployees-hybrid/Resources/js/docs.js","position":4,"original_position":4,"commit_id":"87538734bc7412c33e058dfbb3ee03a903754f24","original_commit_id":"87538734bc7412c33e058dfbb3ee03a903754f24","user":{"login":"nhpatt","id":340653,"avatar_url":"https://avatars1.githubusercontent.com/u/340653?v=4","gravatar_id":"","url":"https://api.github.com/users/nhpatt","html_url":"https://github.com/nhpatt","followers_url":"https://api.github.com/users/nhpatt/followers","following_url":"https://api.github.com/users/nhpatt/following{/other_user}","gists_url":"https://api.github.com/users/nhpatt/gists{/gist_id}","starred_url":"https://api.github.com/users/nhpatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhpatt/subscriptions","organizations_url":"https://api.github.com/users/nhpatt/orgs","repos_url":"https://api.github.com/users/nhpatt/repos","events_url":"https://api.github.com/users/nhpatt/events{/privacy}","received_events_url":"https://api.github.com/users/nhpatt/received_events","type":"User","site_admin":false},"body":"Can it be extracted to the app config?","created_at":"2017-08-01T09:53:05Z","updated_at":"2017-08-01T09:53:05Z","html_url":"https://github.com/liferay/liferay-screens/pull/434#discussion_r130565617","pull_request_url":"https://api.github.com/repos/liferay/liferay-screens/pulls/434","_links":{"self":{"href":"https://api.github.com/repos/liferay/liferay-screens/pulls/comments/130565617"},"html":{"href":"https://github.com/liferay/liferay-screens/pull/434#discussion_r130565617"},"pull_request":{"href":"https://api.github.com/repos/liferay/liferay-screens/pulls/434"}}},"pull_request":{"url":"https://api.github.com/repos/liferay/liferay-screens/pulls/434","id":132960583,"html_url":"https://github.com/liferay/liferay-screens/pull/434","diff_url":"https://github.com/liferay/liferay-screens/pull/434.diff","patch_url":"https://github.com/liferay/liferay-screens/pull/434.patch","issue_url":"https://api.github.com/repos/liferay/liferay-screens/issues/434","number":434,"state":"open","locked":false,"title":"LSR-1020 Westeros employees hybrid iOS","user":{"login":"fmicoInfo","id":17835771,"avatar_url":"https://avatars3.githubusercontent.com/u/17835771?v=4","gravatar_id":"","url":"https://api.github.com/users/fmicoInfo","html_url":"https://github.com/fmicoInfo","followers_url":"https://api.github.com/users/fmicoInfo/followers","following_url":"https://api.github.com/users/fmicoInfo/following{/other_user}","gists_url":"https://api.github.com/users/fmicoInfo/gists{/gist_id}","starred_url":"https://api.github.com/users/fmicoInfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmicoInfo/subscriptions","organizations_url":"https://api.github.com/users/fmicoInfo/orgs","repos_url":"https://api.github.com/users/fmicoInfo/repos","events_url":"https://api.github.com/users/fmicoInfo/events{/privacy}","received_events_url":"https://api.github.com/users/fmicoInfo/received_events","type":"User","site_admin":false},"body":"LSR-1020 Westeros employees hybrid iOS","created_at":"2017-07-28T12:43:00Z","updated_at":"2017-08-01T09:53:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc395d78c5cd48e413b04d457f7008d5917ffcf2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/liferay/liferay-screens/pulls/434/commits","review_comments_url":"https://api.github.com/repos/liferay/liferay-screens/pulls/434/comments","review_comment_url":"https://api.github.com/repos/liferay/liferay-screens/pulls/comments{/number}","comments_url":"https://api.github.com/repos/liferay/liferay-screens/issues/434/comments","statuses_url":"https://api.github.com/repos/liferay/liferay-screens/statuses/87538734bc7412c33e058dfbb3ee03a903754f24","head":{"label":"fmicoInfo:feature/LSR-1020","ref":"feature/LSR-1020","sha":"87538734bc7412c33e058dfbb3ee03a903754f24","user":{"login":"fmicoInfo","id":17835771,"avatar_url":"https://avatars3.githubusercontent.com/u/17835771?v=4","gravatar_id":"","url":"https://api.github.com/users/fmicoInfo","html_url":"https://github.com/fmicoInfo","followers_url":"https://api.github.com/users/fmicoInfo/followers","following_url":"https://api.github.com/users/fmicoInfo/following{/other_user}","gists_url":"https://api.github.com/users/fmicoInfo/gists{/gist_id}","starred_url":"https://api.github.com/users/fmicoInfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmicoInfo/subscriptions","organizations_url":"https://api.github.com/users/fmicoInfo/orgs","repos_url":"https://api.github.com/users/fmicoInfo/repos","events_url":"https://api.github.com/users/fmicoInfo/events{/privacy}","received_events_url":"https://api.github.com/users/fmicoInfo/received_events","type":"User","site_admin":false},"repo":{"id":96206615,"name":"liferay-screens","full_name":"fmicoInfo/liferay-screens","owner":{"login":"fmicoInfo","id":17835771,"avatar_url":"https://avatars3.githubusercontent.com/u/17835771?v=4","gravatar_id":"","url":"https://api.github.com/users/fmicoInfo","html_url":"https://github.com/fmicoInfo","followers_url":"https://api.github.com/users/fmicoInfo/followers","following_url":"https://api.github.com/users/fmicoInfo/following{/other_user}","gists_url":"https://api.github.com/users/fmicoInfo/gists{/gist_id}","starred_url":"https://api.github.com/users/fmicoInfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmicoInfo/subscriptions","organizations_url":"https://api.github.com/users/fmicoInfo/orgs","repos_url":"https://api.github.com/users/fmicoInfo/repos","events_url":"https://api.github.com/users/fmicoInfo/events{/privacy}","received_events_url":"https://api.github.com/users/fmicoInfo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fmicoInfo/liferay-screens","description":null,"fork":true,"url":"https://api.github.com/repos/fmicoInfo/liferay-screens","forks_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/forks","keys_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/teams","hooks_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/hooks","issue_events_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/issues/events{/number}","events_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/events","assignees_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/assignees{/user}","branches_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/branches{/branch}","tags_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/tags","blobs_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/git/refs{/sha}","trees_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/statuses/{sha}","languages_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/languages","stargazers_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/stargazers","contributors_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/contributors","subscribers_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/subscribers","subscription_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/subscription","commits_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/commits{/sha}","git_commits_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/git/commits{/sha}","comments_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/comments{/number}","issue_comment_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/issues/comments{/number}","contents_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/contents/{+path}","compare_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/merges","archive_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/downloads","issues_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/issues{/number}","pulls_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/pulls{/number}","milestones_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/milestones{/number}","notifications_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/labels{/name}","releases_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/releases{/id}","deployments_url":"https://api.github.com/repos/fmicoInfo/liferay-screens/deployments","created_at":"2017-07-04T10:34:04Z","updated_at":"2017-07-04T10:34:10Z","pushed_at":"2017-08-01T09:15:14Z","git_url":"git://github.com/fmicoInfo/liferay-screens.git","ssh_url":"[email protected]:fmicoInfo/liferay-screens.git","clone_url":"https://github.com/fmicoInfo/liferay-screens.git","svn_url":"https://github.com/fmicoInfo/liferay-screens","homepage":null,"size":37110,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"liferay:feature/LSR-1004","ref":"feature/LSR-1004","sha":"32344dd7cb53fca74788cf8ecd0b1b7f2846f16e","user":{"login":"liferay","id":131436,"avatar_url":"https://avatars3.githubusercontent.com/u/131436?v=4","gravatar_id":"","url":"https://api.github.com/users/liferay","html_url":"https://github.com/liferay","followers_url":"https://api.github.com/users/liferay/followers","following_url":"https://api.github.com/users/liferay/following{/other_user}","gists_url":"https://api.github.com/users/liferay/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay/subscriptions","organizations_url":"https://api.github.com/users/liferay/orgs","repos_url":"https://api.github.com/users/liferay/repos","events_url":"https://api.github.com/users/liferay/events{/privacy}","received_events_url":"https://api.github.com/users/liferay/received_events","type":"Organization","site_admin":false},"repo":{"id":21174850,"name":"liferay-screens","full_name":"liferay/liferay-screens","owner":{"login":"liferay","id":131436,"avatar_url":"https://avatars3.githubusercontent.com/u/131436?v=4","gravatar_id":"","url":"https://api.github.com/users/liferay","html_url":"https://github.com/liferay","followers_url":"https://api.github.com/users/liferay/followers","following_url":"https://api.github.com/users/liferay/following{/other_user}","gists_url":"https://api.github.com/users/liferay/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay/subscriptions","organizations_url":"https://api.github.com/users/liferay/orgs","repos_url":"https://api.github.com/users/liferay/repos","events_url":"https://api.github.com/users/liferay/events{/privacy}","received_events_url":"https://api.github.com/users/liferay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/liferay/liferay-screens","description":null,"fork":false,"url":"https://api.github.com/repos/liferay/liferay-screens","forks_url":"https://api.github.com/repos/liferay/liferay-screens/forks","keys_url":"https://api.github.com/repos/liferay/liferay-screens/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liferay/liferay-screens/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liferay/liferay-screens/teams","hooks_url":"https://api.github.com/repos/liferay/liferay-screens/hooks","issue_events_url":"https://api.github.com/repos/liferay/liferay-screens/issues/events{/number}","events_url":"https://api.github.com/repos/liferay/liferay-screens/events","assignees_url":"https://api.github.com/repos/liferay/liferay-screens/assignees{/user}","branches_url":"https://api.github.com/repos/liferay/liferay-screens/branches{/branch}","tags_url":"https://api.github.com/repos/liferay/liferay-screens/tags","blobs_url":"https://api.github.com/repos/liferay/liferay-screens/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liferay/liferay-screens/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liferay/liferay-screens/git/refs{/sha}","trees_url":"https://api.github.com/repos/liferay/liferay-screens/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liferay/liferay-screens/statuses/{sha}","languages_url":"https://api.github.com/repos/liferay/liferay-screens/languages","stargazers_url":"https://api.github.com/repos/liferay/liferay-screens/stargazers","contributors_url":"https://api.github.com/repos/liferay/liferay-screens/contributors","subscribers_url":"https://api.github.com/repos/liferay/liferay-screens/subscribers","subscription_url":"https://api.github.com/repos/liferay/liferay-screens/subscription","commits_url":"https://api.github.com/repos/liferay/liferay-screens/commits{/sha}","git_commits_url":"https://api.github.com/repos/liferay/liferay-screens/git/commits{/sha}","comments_url":"https://api.github.com/repos/liferay/liferay-screens/comments{/number}","issue_comment_url":"https://api.github.com/repos/liferay/liferay-screens/issues/comments{/number}","contents_url":"https://api.github.com/repos/liferay/liferay-screens/contents/{+path}","compare_url":"https://api.github.com/repos/liferay/liferay-screens/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liferay/liferay-screens/merges","archive_url":"https://api.github.com/repos/liferay/liferay-screens/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liferay/liferay-screens/downloads","issues_url":"https://api.github.com/repos/liferay/liferay-screens/issues{/number}","pulls_url":"https://api.github.com/repos/liferay/liferay-screens/pulls{/number}","milestones_url":"https://api.github.com/repos/liferay/liferay-screens/milestones{/number}","notifications_url":"https://api.github.com/repos/liferay/liferay-screens/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liferay/liferay-screens/labels{/name}","releases_url":"https://api.github.com/repos/liferay/liferay-screens/releases{/id}","deployments_url":"https://api.github.com/repos/liferay/liferay-screens/deployments","created_at":"2014-06-24T17:49:29Z","updated_at":"2017-07-03T21:00:55Z","pushed_at":"2017-08-01T09:15:16Z","git_url":"git://github.com/liferay/liferay-screens.git","ssh_url":"[email protected]:liferay/liferay-screens.git","clone_url":"https://github.com/liferay/liferay-screens.git","svn_url":"https://github.com/liferay/liferay-screens","homepage":null,"size":37173,"stargazers_count":52,"watchers_count":52,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":87,"mirror_url":null,"open_issues_count":4,"forks":87,"open_issues":4,"watchers":52,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/liferay/liferay-screens/pulls/434"},"html":{"href":"https://github.com/liferay/liferay-screens/pull/434"},"issue":{"href":"https://api.github.com/repos/liferay/liferay-screens/issues/434"},"comments":{"href":"https://api.github.com/repos/liferay/liferay-screens/issues/434/comments"},"review_comments":{"href":"https://api.github.com/repos/liferay/liferay-screens/pulls/434/comments"},"review_comment":{"href":"https://api.github.com/repos/liferay/liferay-screens/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/liferay/liferay-screens/pulls/434/commits"},"statuses":{"href":"https://api.github.com/repos/liferay/liferay-screens/statuses/87538734bc7412c33e058dfbb3ee03a903754f24"}}}} | {
"id": 21174850,
"name": "liferay/liferay-screens",
"url": "https://api.github.com/repos/liferay/liferay-screens"
} | {
"id": 340653,
"login": "nhpatt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/340653?",
"url": "https://api.github.com/users/nhpatt"
} | {
"id": 131436,
"login": "liferay",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/131436?",
"url": "https://api.github.com/orgs/liferay"
} | 2017-08-01T09:53:05 | 6368700917 | {"actor":{"display_login":"nhpatt"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/metoppv/improver/pulls/comments/133429583","pull_request_review_id":56607538,"id":133429583,"diff_hunk":"@@ -157,52 +159,111 @@ def process(self, cube, sites, neighbours, ancillary_data, additional_data,\n self.method, self.__class__.__name__))\n \n @staticmethod\n- def _build_coordinates(latitudes, longitudes, altitudes, utc_offsets,\n- wmo_sites):\n+ def _build_coordinate(data, coordinate, coord_type=DimCoord,\n+ data_type=float, units='1', bounds=None,\n+ coord_system=None, custom_function=None):","path":"lib/improver/spotdata/extract_data.py","position":20,"original_position":20,"commit_id":"45e7deb67041c463eb9c771b2d49f656ef95e937","original_commit_id":"45e7deb67041c463eb9c771b2d49f656ef95e937","user":{"login":"gavinevans","id":26933341,"avatar_url":"https://avatars3.githubusercontent.com/u/26933341?v=4","gravatar_id":"","url":"https://api.github.com/users/gavinevans","html_url":"https://github.com/gavinevans","followers_url":"https://api.github.com/users/gavinevans/followers","following_url":"https://api.github.com/users/gavinevans/following{/other_user}","gists_url":"https://api.github.com/users/gavinevans/gists{/gist_id}","starred_url":"https://api.github.com/users/gavinevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gavinevans/subscriptions","organizations_url":"https://api.github.com/users/gavinevans/orgs","repos_url":"https://api.github.com/users/gavinevans/repos","events_url":"https://api.github.com/users/gavinevans/events{/privacy}","received_events_url":"https://api.github.com/users/gavinevans/received_events","type":"User","site_admin":false},"body":"I completely agree with this. I think a technical debt issue is required to move a lot of utilities within spot data, so that they can be used by other parts of IMPROVER.","created_at":"2017-08-16T12:04:35Z","updated_at":"2017-08-16T12:04:35Z","html_url":"https://github.com/metoppv/improver/pull/236#discussion_r133429583","pull_request_url":"https://api.github.com/repos/metoppv/improver/pulls/236","_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments/133429583"},"html":{"href":"https://github.com/metoppv/improver/pull/236#discussion_r133429583"},"pull_request":{"href":"https://api.github.com/repos/metoppv/improver/pulls/236"}}},"pull_request":{"url":"https://api.github.com/repos/metoppv/improver/pulls/236","id":135163056,"html_url":"https://github.com/metoppv/improver/pull/236","diff_url":"https://github.com/metoppv/improver/pull/236.diff","patch_url":"https://github.com/metoppv/improver/pull/236.patch","issue_url":"https://api.github.com/repos/metoppv/improver/issues/236","number":236,"state":"open","locked":false,"title":"Metadata added into spotdata (plus rejigging).","user":{"login":"bayliffe","id":28042362,"avatar_url":"https://avatars3.githubusercontent.com/u/28042362?v=4","gravatar_id":"","url":"https://api.github.com/users/bayliffe","html_url":"https://github.com/bayliffe","followers_url":"https://api.github.com/users/bayliffe/followers","following_url":"https://api.github.com/users/bayliffe/following{/other_user}","gists_url":"https://api.github.com/users/bayliffe/gists{/gist_id}","starred_url":"https://api.github.com/users/bayliffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bayliffe/subscriptions","organizations_url":"https://api.github.com/users/bayliffe/orgs","repos_url":"https://api.github.com/users/bayliffe/repos","events_url":"https://api.github.com/users/bayliffe/events{/privacy}","received_events_url":"https://api.github.com/users/bayliffe/received_events","type":"User","site_admin":false},"body":"#235 \r\n\r\nAdding metadata to spotdata cubes, including forecast reference time and forecast period. Also somewhat rewriting cube construction in spotdata in the hope that it can all get factored out to common utilities in a future ticket.\r\n\r\nTesting:\r\n - [x] Tests need to be rewritten, don't currently work,\r\n - [x] CLI tests also fail.","created_at":"2017-08-10T16:03:21Z","updated_at":"2017-08-16T12:04:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c1559112fd9fc616de308d44950094c8deda2d6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"LaurenceBeard","id":14344798,"avatar_url":"https://avatars3.githubusercontent.com/u/14344798?v=4","gravatar_id":"","url":"https://api.github.com/users/LaurenceBeard","html_url":"https://github.com/LaurenceBeard","followers_url":"https://api.github.com/users/LaurenceBeard/followers","following_url":"https://api.github.com/users/LaurenceBeard/following{/other_user}","gists_url":"https://api.github.com/users/LaurenceBeard/gists{/gist_id}","starred_url":"https://api.github.com/users/LaurenceBeard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaurenceBeard/subscriptions","organizations_url":"https://api.github.com/users/LaurenceBeard/orgs","repos_url":"https://api.github.com/users/LaurenceBeard/repos","events_url":"https://api.github.com/users/LaurenceBeard/events{/privacy}","received_events_url":"https://api.github.com/users/LaurenceBeard/received_events","type":"User","site_admin":false},{"login":"wxtim","id":26465611,"avatar_url":"https://avatars3.githubusercontent.com/u/26465611?v=4","gravatar_id":"","url":"https://api.github.com/users/wxtim","html_url":"https://github.com/wxtim","followers_url":"https://api.github.com/users/wxtim/followers","following_url":"https://api.github.com/users/wxtim/following{/other_user}","gists_url":"https://api.github.com/users/wxtim/gists{/gist_id}","starred_url":"https://api.github.com/users/wxtim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxtim/subscriptions","organizations_url":"https://api.github.com/users/wxtim/orgs","repos_url":"https://api.github.com/users/wxtim/repos","events_url":"https://api.github.com/users/wxtim/events{/privacy}","received_events_url":"https://api.github.com/users/wxtim/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/metoppv/improver/milestones/7","html_url":"https://github.com/metoppv/improver/milestone/7","labels_url":"https://api.github.com/repos/metoppv/improver/milestones/7/labels","id":2657429,"number":7,"title":"2017-08","description":"","creator":{"login":"bayliffe","id":28042362,"avatar_url":"https://avatars3.githubusercontent.com/u/28042362?v=4","gravatar_id":"","url":"https://api.github.com/users/bayliffe","html_url":"https://github.com/bayliffe","followers_url":"https://api.github.com/users/bayliffe/followers","following_url":"https://api.github.com/users/bayliffe/following{/other_user}","gists_url":"https://api.github.com/users/bayliffe/gists{/gist_id}","starred_url":"https://api.github.com/users/bayliffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bayliffe/subscriptions","organizations_url":"https://api.github.com/users/bayliffe/orgs","repos_url":"https://api.github.com/users/bayliffe/repos","events_url":"https://api.github.com/users/bayliffe/events{/privacy}","received_events_url":"https://api.github.com/users/bayliffe/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":4,"state":"open","created_at":"2017-07-24T08:32:13Z","updated_at":"2017-08-15T15:47:28Z","due_on":"2017-09-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/metoppv/improver/pulls/236/commits","review_comments_url":"https://api.github.com/repos/metoppv/improver/pulls/236/comments","review_comment_url":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metoppv/improver/issues/236/comments","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/45e7deb67041c463eb9c771b2d49f656ef95e937","head":{"label":"bayliffe:SpotMetadata","ref":"SpotMetadata","sha":"45e7deb67041c463eb9c771b2d49f656ef95e937","user":{"login":"bayliffe","id":28042362,"avatar_url":"https://avatars3.githubusercontent.com/u/28042362?v=4","gravatar_id":"","url":"https://api.github.com/users/bayliffe","html_url":"https://github.com/bayliffe","followers_url":"https://api.github.com/users/bayliffe/followers","following_url":"https://api.github.com/users/bayliffe/following{/other_user}","gists_url":"https://api.github.com/users/bayliffe/gists{/gist_id}","starred_url":"https://api.github.com/users/bayliffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bayliffe/subscriptions","organizations_url":"https://api.github.com/users/bayliffe/orgs","repos_url":"https://api.github.com/users/bayliffe/repos","events_url":"https://api.github.com/users/bayliffe/events{/privacy}","received_events_url":"https://api.github.com/users/bayliffe/received_events","type":"User","site_admin":false},"repo":{"id":89453063,"name":"improver","full_name":"bayliffe/improver","owner":{"login":"bayliffe","id":28042362,"avatar_url":"https://avatars3.githubusercontent.com/u/28042362?v=4","gravatar_id":"","url":"https://api.github.com/users/bayliffe","html_url":"https://github.com/bayliffe","followers_url":"https://api.github.com/users/bayliffe/followers","following_url":"https://api.github.com/users/bayliffe/following{/other_user}","gists_url":"https://api.github.com/users/bayliffe/gists{/gist_id}","starred_url":"https://api.github.com/users/bayliffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bayliffe/subscriptions","organizations_url":"https://api.github.com/users/bayliffe/orgs","repos_url":"https://api.github.com/users/bayliffe/repos","events_url":"https://api.github.com/users/bayliffe/events{/privacy}","received_events_url":"https://api.github.com/users/bayliffe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bayliffe/improver","description":"IMPROVER","fork":true,"url":"https://api.github.com/repos/bayliffe/improver","forks_url":"https://api.github.com/repos/bayliffe/improver/forks","keys_url":"https://api.github.com/repos/bayliffe/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bayliffe/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bayliffe/improver/teams","hooks_url":"https://api.github.com/repos/bayliffe/improver/hooks","issue_events_url":"https://api.github.com/repos/bayliffe/improver/issues/events{/number}","events_url":"https://api.github.com/repos/bayliffe/improver/events","assignees_url":"https://api.github.com/repos/bayliffe/improver/assignees{/user}","branches_url":"https://api.github.com/repos/bayliffe/improver/branches{/branch}","tags_url":"https://api.github.com/repos/bayliffe/improver/tags","blobs_url":"https://api.github.com/repos/bayliffe/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bayliffe/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bayliffe/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/bayliffe/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bayliffe/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/bayliffe/improver/languages","stargazers_url":"https://api.github.com/repos/bayliffe/improver/stargazers","contributors_url":"https://api.github.com/repos/bayliffe/improver/contributors","subscribers_url":"https://api.github.com/repos/bayliffe/improver/subscribers","subscription_url":"https://api.github.com/repos/bayliffe/improver/subscription","commits_url":"https://api.github.com/repos/bayliffe/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/bayliffe/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/bayliffe/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/bayliffe/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/bayliffe/improver/contents/{+path}","compare_url":"https://api.github.com/repos/bayliffe/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bayliffe/improver/merges","archive_url":"https://api.github.com/repos/bayliffe/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bayliffe/improver/downloads","issues_url":"https://api.github.com/repos/bayliffe/improver/issues{/number}","pulls_url":"https://api.github.com/repos/bayliffe/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/bayliffe/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/bayliffe/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bayliffe/improver/labels{/name}","releases_url":"https://api.github.com/repos/bayliffe/improver/releases{/id}","deployments_url":"https://api.github.com/repos/bayliffe/improver/deployments","created_at":"2017-04-26T07:45:39Z","updated_at":"2017-04-26T07:47:12Z","pushed_at":"2017-08-16T09:29:06Z","git_url":"git://github.com/bayliffe/improver.git","ssh_url":"[email protected]:bayliffe/improver.git","clone_url":"https://github.com/bayliffe/improver.git","svn_url":"https://github.com/bayliffe/improver","homepage":null,"size":1453,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"metoppv:master","ref":"master","sha":"2568289b14b8a966cb90d4619c75d76d5a27c869","user":{"login":"metoppv","id":26465485,"avatar_url":"https://avatars2.githubusercontent.com/u/26465485?v=4","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"repo":{"id":85334761,"name":"improver","full_name":"metoppv/improver","owner":{"login":"metoppv","id":26465485,"avatar_url":"https://avatars2.githubusercontent.com/u/26465485?v=4","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metoppv/improver","description":"IMPROVER is a library of algorithms for meteorological post-processing and verification.","fork":false,"url":"https://api.github.com/repos/metoppv/improver","forks_url":"https://api.github.com/repos/metoppv/improver/forks","keys_url":"https://api.github.com/repos/metoppv/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metoppv/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metoppv/improver/teams","hooks_url":"https://api.github.com/repos/metoppv/improver/hooks","issue_events_url":"https://api.github.com/repos/metoppv/improver/issues/events{/number}","events_url":"https://api.github.com/repos/metoppv/improver/events","assignees_url":"https://api.github.com/repos/metoppv/improver/assignees{/user}","branches_url":"https://api.github.com/repos/metoppv/improver/branches{/branch}","tags_url":"https://api.github.com/repos/metoppv/improver/tags","blobs_url":"https://api.github.com/repos/metoppv/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metoppv/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metoppv/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/metoppv/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/metoppv/improver/languages","stargazers_url":"https://api.github.com/repos/metoppv/improver/stargazers","contributors_url":"https://api.github.com/repos/metoppv/improver/contributors","subscribers_url":"https://api.github.com/repos/metoppv/improver/subscribers","subscription_url":"https://api.github.com/repos/metoppv/improver/subscription","commits_url":"https://api.github.com/repos/metoppv/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/metoppv/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/metoppv/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/metoppv/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/metoppv/improver/contents/{+path}","compare_url":"https://api.github.com/repos/metoppv/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metoppv/improver/merges","archive_url":"https://api.github.com/repos/metoppv/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metoppv/improver/downloads","issues_url":"https://api.github.com/repos/metoppv/improver/issues{/number}","pulls_url":"https://api.github.com/repos/metoppv/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/metoppv/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/metoppv/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metoppv/improver/labels{/name}","releases_url":"https://api.github.com/repos/metoppv/improver/releases{/id}","deployments_url":"https://api.github.com/repos/metoppv/improver/deployments","created_at":"2017-03-17T16:51:29Z","updated_at":"2017-06-24T09:03:02Z","pushed_at":"2017-08-16T09:29:10Z","git_url":"git://github.com/metoppv/improver.git","ssh_url":"[email protected]:metoppv/improver.git","clone_url":"https://github.com/metoppv/improver.git","svn_url":"https://github.com/metoppv/improver","homepage":"","size":1422,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":91,"forks":16,"open_issues":91,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/236"},"html":{"href":"https://github.com/metoppv/improver/pull/236"},"issue":{"href":"https://api.github.com/repos/metoppv/improver/issues/236"},"comments":{"href":"https://api.github.com/repos/metoppv/improver/issues/236/comments"},"review_comments":{"href":"https://api.github.com/repos/metoppv/improver/pulls/236/comments"},"review_comment":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metoppv/improver/pulls/236/commits"},"statuses":{"href":"https://api.github.com/repos/metoppv/improver/statuses/45e7deb67041c463eb9c771b2d49f656ef95e937"}}}} | {
"id": 85334761,
"name": "metoppv/improver",
"url": "https://api.github.com/repos/metoppv/improver"
} | {
"id": 26933341,
"login": "gavinevans",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26933341?",
"url": "https://api.github.com/users/gavinevans"
} | {
"id": 26465485,
"login": "metoppv",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26465485?",
"url": "https://api.github.com/orgs/metoppv"
} | 2017-08-16T12:04:35 | 6462949086 | {"actor":{"display_login":"gavinevans"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/metoppv/improver/pulls/comments/118679609","pull_request_review_id":40464224,"id":118679609,"diff_hunk":"@@ -0,0 +1,445 @@\n+# -*- coding: utf-8 -*-\n+# -----------------------------------------------------------------------------\n+# (C) British Crown Copyright 2017 Met Office.\n+# All rights reserved.\n+#\n+# Redistribution and use in source and binary forms, with or without\n+# modification, are permitted provided that the following conditions are met:\n+#\n+# * Redistributions of source code must retain the above copyright notice, this\n+# list of conditions and the following disclaimer.\n+#\n+# * Redistributions in binary form must reproduce the above copyright notice,\n+# this list of conditions and the following disclaimer in the documentation\n+# and/or other materials provided with the distribution.\n+#\n+# * Neither the name of the copyright holder nor the names of its\n+# contributors may be used to endorse or promote products derived from\n+# this software without specific prior written permission.\n+#\n+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE\n+# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR\n+# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF\n+# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS\n+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN\n+# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)\n+# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE\n+# POSSIBILITY OF SUCH DAMAGE.\n+\n+\"\"\"Neighbour finding for the Improver site specific process chain.\"\"\"\n+\n+import numpy as np\n+import cartopy.crs as ccrs\n+# from iris.analysis.trajectory import interpolate\n+from improver.spotdata.ancillaries import data_from_ancillary\n+from improver.spotdata.common_functions import (ConditionalListExtract,\n+ nearest_n_neighbours,\n+ get_nearest_coords,\n+ index_of_minimum_difference,\n+ list_entry_from_index,\n+ node_edge_test)\n+\n+\n+class PointSelection(object):\n+ \"\"\"\n+ For the selection of source data from a grid for use in deriving\n+ conditions at an arbitrary coordinate.\n+\n+ \"\"\"\n+\n+ def __init__(self, method='default'):\n+ \"\"\"neighbour_list = find_nearest_neighbours(cube, spot_sites)\n+ The class is called with the desired method to be used in determining\n+ the grid point closest to sites of interest.\n+\n+ \"\"\"\n+ self.method = method\n+\n+ def process(self, cube, sites, **kwargs):\n+ \"\"\"\n+ Call the correct function to enact the method of PointSelection\n+ specified.\n+\n+ \"\"\"\n+ function = getattr(self, self.method)\n+ return function(cube, sites, **kwargs)\n+\n+ @staticmethod\n+ def fast_nearest_neighbour(cube, sites, ancillary_data=None):\n+ '''\n+ Use iris coord.nearest_neighbour_index function to locate the nearest\n+ grid point to the given latitude/longitude pair.\n+\n+ Performed on a 2D-surface; consider using the much slower\n+ iris.analysis.trajectory.interpolate method for a more correct nearest\n+ neighbour search with projection onto a spherical surface; this is\n+ typically much slower.\n+\n+ Args:\n+ -----\n+ cube : Iris cube of gridded data.\n+ sites : Dictionary of site data, including lat/lon and\n+ altitude information.\n+ e.g. {<site_id>: {'latitude': 50, 'longitude': 0,\n+ 'altitude': 10}}\n+ ancillary_data : A dictionary containing additional model data that\n+ is needed. e.g. {'orography': <cube of orography>}\n+\n+ Returns:\n+ --------\n+ neighbours: Numpy array of grid i,j coordinates that are nearest to\n+ each site coordinate given. Includes height difference\n+ between site and returned grid point if orography is\n+ provided.\n+\n+ '''\n+ if ancillary_data is not None and ancillary_data['orography']:\n+ calculate_dz = True\n+ orography = data_from_ancillary(ancillary_data, 'orography')\n+ else:\n+ calculate_dz = False\n+\n+ neighbours = np.empty(len(sites), dtype=[('i', 'i8'),\n+ ('j', 'i8'),\n+ ('dz', 'f8'),\n+ ('edge', 'bool_')])\n+\n+ # Check cube coords are lat/lon, else transform lookup coordinates.\n+ trg_crs = xy_test(cube)\n+\n+ imax = cube.coord(axis='y').shape[0]\n+ jmax = cube.coord(axis='x').shape[0]\n+\n+ for i_site, site in enumerate(sites.itervalues()):\n+ latitude, longitude, altitude = (site['latitude'],\n+ site['longitude'],\n+ site['altitude'])\n+\n+ longitude, latitude = xy_transform(trg_crs, latitude, longitude)\n+ i_latitude, j_longitude = get_nearest_coords(cube, latitude,\n+ longitude)\n+\n+ dz_site_grid = 0.\n+ if calculate_dz:\n+ dz_site_grid = altitude - orography[i_latitude, j_longitude]\n+\n+ neighbours[i_site] = (int(i_latitude), int(j_longitude),\n+ dz_site_grid,\n+ (i_latitude == imax or j_longitude == jmax))\n+\n+ return neighbours\n+\n+# @staticmethod\n+# def nearest_neighbour(cube, sites, ancillary_data=None):\n+# '''\n+# Uses the\n+# iris.analysis._interpolate_private._nearest_neighbour_indices_ndcoords\n+# function to locate the nearest grid point to the given latitude/\n+# longitude pair, taking into account the projection of the cube.\n+#\n+# Method is equivalent to extracting data directly with\n+# iris.analysis.trajectory.interpolate method, which calculates nearest\n+# neighbours using great arcs on a spherical surface. Using the private\n+# function we are able to get the list of indices for reuse by multiple\n+# diagnostics.\n+#\n+# Args:\n+# -----\n+# cube : Iris cube of gridded data.\n+# sites : Dictionary of site data, including lat/lon and\n+# altitude information.\n+# ancillary_data : A dictionary containing additional model data that\n+# is needed. e.g. {'orography': <cube of orography>}\n+#\n+# Returns:\n+# --------\n+# neighbours: Numpy array of grid i,j coordinates that are nearest to\n+# each site coordinate given. Includes height difference\n+# between site and returned grid point if orography is\n+# provided.\n+#\n+# '''\n+# if ancillary_data is not None and ancillary_data['orography']:\n+# calculate_dz = True\n+# orography = data_from_ancillary(ancillary_data, 'orography')\n+# else:\n+# calculate_dz = False\n+#\n+# neighbours = np.empty(len(sites), dtype=[('i', 'i8'),\n+# ('j', 'i8'),\n+# ('dz', 'f8')])\n+#\n+# # Check cube coords are lat/lon, else transform lookup coordinates.\n+# trg_crs = xy_test(cube)\n+#\n+# spot_sites = [('latitude',\n+# [sites[key]['latitude'] for key in sites.keys()]),\n+# ('longitude',\n+# [sites[key]['longitude'] for key in sites.keys()])]\n+#\n+# spot_orography = interpolate(cube, spot_sites, method='nearest')\n+#\n+# cube_lats = cube.coord(axis='y').points\n+# spot_lats = spot_orography.coord('latitude').points\n+#\n+# cube_lons = cube.coord(axis='x').points\n+# spot_lons = spot_orography.coord('longitude').points\n+#\n+# int_ind_i = []\n+# int_ind_j = []\n+# for point in spot_lats:\n+# indices_lat = (np.where(point == cube_lats)[0][0])\n+# int_ind_i.append(indices_lat)\n+# for point in spot_lons:\n+# indices_lon = (np.where(point == cube_lons)[0][0])\n+# int_ind_j.append(indices_lon)\n+# i_indices = int_ind_i\n+# j_indices = int_ind_j\n+#\n+# # i_indices, j_indices = zip(*[(i, j) for _, i, j in neighbour_list])\n+#\n+# dz = [0] * len(neighbour_list)\n+# if calculate_dz:\n+# altitudes = [sites[key]['altitude'] for key in sites.keys()]\n+# dz = altitudes - orography[i_indices, j_indices]\n+#\n+# neighbours['i'] = i_indices\n+# neighbours['j'] = j_indices\n+# neighbours['dz'] = dz\n+#\n+# return neighbours\n+\n+ def minimum_height_error_neighbour(self, cube, sites,\n+ default_neighbours=None,\n+ relative_z=None,\n+ land_constraint=False,\n+ ancillary_data=None):\n+\n+ '''\n+ Find the horizontally nearest neighbour, then relax the conditions\n+ to find the neighbouring point in the 9 nearest nodes to the input\n+ coordinate that minimises the height difference. This is typically\n+ used for temperature, where vertical displacement can be much more\n+ important that horizontal displacement in determining the conditions.\n+\n+ A vertical displacement bias may be applied with the relative_z\n+ keyword; whether to prefer grid points above or below the site, or\n+ neither.\n+\n+ A land constraint may be applied that requires a land grid point be\n+ selected for a site that is over land. Currently this is established\n+ by checking that the nearest grid point barring any other conditions\n+ is a land point. If a site is a sea point it will use the nearest\n+ neighbour as there should be no vertical displacement difference with\n+ other sea points.\n+\n+ Args:\n+ -----\n+ cube : Iris cube of gridded data.\n+ sites : Dictionary of site data, including lat/lon and\n+ altitude information.\n+ relative_z : Sets the preferred vertical displacement of the grid\n+ point relative to the site; above/below/None.\n+ land_constraint: A boolean that determines if land sites should only\n+ select from grid points also over land.\n+ ancillary_data : A dictionary containing additional model data that\n+ is needed.\n+ Must contain {'orography': <cube of orography>}.\n+ Needs {'land': <cube of land mask>} if using land\n+ constraint.\n+\n+ Returns:\n+ --------\n+ neighbours: Numpy array of grid i,j coordinates that are nearest to\n+ each site coordinate given. Includes height difference\n+ between site and returned grid point.\n+\n+ '''\n+ # Use the default nearest neighbour list as a starting point, and\n+ # if for some reason it is missing, recreate the list using the fast\n+ # method.\n+ if default_neighbours is None:\n+ neighbour_list = self.fast_nearest_neighbour(cube, sites,\n+ ancillary_data)\n+ else:\n+ neighbour_list = default_neighbours\n+\n+ orography = data_from_ancillary(ancillary_data, 'orography')\n+ if land_constraint:\n+ land = data_from_ancillary(ancillary_data, 'land')\n+\n+ for i_site, site in enumerate(sites.itervalues()):\n+ altitude = site['altitude']\n+\n+ i, j = neighbour_list['i'][i_site], neighbour_list['j'][i_site]\n+ edgecase = neighbour_list['edge'][i_site]\n+\n+ node_list = nearest_n_neighbours(i, j, 9)","path":"lib/improver/spotdata/neighbour_finding.py","position":280,"original_position":280,"commit_id":"6c12d8c275fdfd9a605621dc3e8620b6c71ad1ef","original_commit_id":"6c12d8c275fdfd9a605621dc3e8620b6c71ad1ef","user":{"login":"benfitzpatrick","id":1138333,"avatar_url":"https://avatars1.githubusercontent.com/u/1138333?v=3","gravatar_id":"","url":"https://api.github.com/users/benfitzpatrick","html_url":"https://github.com/benfitzpatrick","followers_url":"https://api.github.com/users/benfitzpatrick/followers","following_url":"https://api.github.com/users/benfitzpatrick/following{/other_user}","gists_url":"https://api.github.com/users/benfitzpatrick/gists{/gist_id}","starred_url":"https://api.github.com/users/benfitzpatrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfitzpatrick/subscriptions","organizations_url":"https://api.github.com/users/benfitzpatrick/orgs","repos_url":"https://api.github.com/users/benfitzpatrick/repos","events_url":"https://api.github.com/users/benfitzpatrick/events{/privacy}","received_events_url":"https://api.github.com/users/benfitzpatrick/received_events","type":"User","site_admin":false},"body":"9 hardcoded? Better as an option and then add a couple of tests for it?","created_at":"2017-05-26T10:59:29Z","updated_at":"2017-05-26T10:59:42Z","html_url":"https://github.com/metoppv/improver/pull/61#discussion_r118679609","pull_request_url":"https://api.github.com/repos/metoppv/improver/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments/118679609"},"html":{"href":"https://github.com/metoppv/improver/pull/61#discussion_r118679609"},"pull_request":{"href":"https://api.github.com/repos/metoppv/improver/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/metoppv/improver/pulls/61","id":122394475,"html_url":"https://github.com/metoppv/improver/pull/61","diff_url":"https://github.com/metoppv/improver/pull/61.diff","patch_url":"https://github.com/metoppv/improver/pull/61.patch","issue_url":"https://api.github.com/repos/metoppv/improver/issues/61","number":61,"state":"open","locked":false,"title":"SpotData Neighbour finding plugin + dependencies.","user":{"login":"bayliffe","id":28042362,"avatar_url":"https://avatars0.githubusercontent.com/u/28042362?v=3","gravatar_id":"","url":"https://api.github.com/users/bayliffe","html_url":"https://github.com/bayliffe","followers_url":"https://api.github.com/users/bayliffe/followers","following_url":"https://api.github.com/users/bayliffe/following{/other_user}","gists_url":"https://api.github.com/users/bayliffe/gists{/gist_id}","starred_url":"https://api.github.com/users/bayliffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bayliffe/subscriptions","organizations_url":"https://api.github.com/users/bayliffe/orgs","repos_url":"https://api.github.com/users/bayliffe/repos","events_url":"https://api.github.com/users/bayliffe/events{/privacy}","received_events_url":"https://api.github.com/users/bayliffe/received_events","type":"User","site_admin":false},"body":"The doc-strings describe what is required to run this plugin, but the following may be useful.\r\n\r\n```\r\n# Import the plugin\r\nfrom neighbour_finding import PointSelection\r\n# Format spotdata site details as a dictionary (the leading '100' is the site ID).\r\nsites = {'100': {'longitude': 0, 'latitude': 10, 'altitude': 0}}\r\n# Create a dictionary of required ancillary data, where what's needed depends on the selected method.\r\nancillary_data = {'orography': iris.load_cube('orography.nc'), 'land_mask': iris.load_cube('land_mask.nc')}\r\n# Run the point selection routine.\r\nPointSelection('fast_nearest_neighbour').process(cube, sites)\r\nPointSelection('min_dz_no_bias').process(cube, sites, ancillary_data=ancillary_data)\r\n```\r\n","created_at":"2017-05-25T08:29:08Z","updated_at":"2017-05-26T10:59:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99af52d5edccca8ecdbbe2aedbfc44e557483cfa","assignee":{"login":"bayliffe","id":28042362,"avatar_url":"https://avatars0.githubusercontent.com/u/28042362?v=3","gravatar_id":"","url":"https://api.github.com/users/bayliffe","html_url":"https://github.com/bayliffe","followers_url":"https://api.github.com/users/bayliffe/followers","following_url":"https://api.github.com/users/bayliffe/following{/other_user}","gists_url":"https://api.github.com/users/bayliffe/gists{/gist_id}","starred_url":"https://api.github.com/users/bayliffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bayliffe/subscriptions","organizations_url":"https://api.github.com/users/bayliffe/orgs","repos_url":"https://api.github.com/users/bayliffe/repos","events_url":"https://api.github.com/users/bayliffe/events{/privacy}","received_events_url":"https://api.github.com/users/bayliffe/received_events","type":"User","site_admin":false},"assignees":[{"login":"bayliffe","id":28042362,"avatar_url":"https://avatars0.githubusercontent.com/u/28042362?v=3","gravatar_id":"","url":"https://api.github.com/users/bayliffe","html_url":"https://github.com/bayliffe","followers_url":"https://api.github.com/users/bayliffe/followers","following_url":"https://api.github.com/users/bayliffe/following{/other_user}","gists_url":"https://api.github.com/users/bayliffe/gists{/gist_id}","starred_url":"https://api.github.com/users/bayliffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bayliffe/subscriptions","organizations_url":"https://api.github.com/users/bayliffe/orgs","repos_url":"https://api.github.com/users/bayliffe/repos","events_url":"https://api.github.com/users/bayliffe/events{/privacy}","received_events_url":"https://api.github.com/users/bayliffe/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"fionaRust","id":16209648,"avatar_url":"https://avatars0.githubusercontent.com/u/16209648?v=3","gravatar_id":"","url":"https://api.github.com/users/fionaRust","html_url":"https://github.com/fionaRust","followers_url":"https://api.github.com/users/fionaRust/followers","following_url":"https://api.github.com/users/fionaRust/following{/other_user}","gists_url":"https://api.github.com/users/fionaRust/gists{/gist_id}","starred_url":"https://api.github.com/users/fionaRust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fionaRust/subscriptions","organizations_url":"https://api.github.com/users/fionaRust/orgs","repos_url":"https://api.github.com/users/fionaRust/repos","events_url":"https://api.github.com/users/fionaRust/events{/privacy}","received_events_url":"https://api.github.com/users/fionaRust/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/metoppv/improver/pulls/61/commits","review_comments_url":"https://api.github.com/repos/metoppv/improver/pulls/61/comments","review_comment_url":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metoppv/improver/issues/61/comments","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/6c12d8c275fdfd9a605621dc3e8620b6c71ad1ef","head":{"label":"bayliffe:JustNeighbourFinding","ref":"JustNeighbourFinding","sha":"6c12d8c275fdfd9a605621dc3e8620b6c71ad1ef","user":{"login":"bayliffe","id":28042362,"avatar_url":"https://avatars0.githubusercontent.com/u/28042362?v=3","gravatar_id":"","url":"https://api.github.com/users/bayliffe","html_url":"https://github.com/bayliffe","followers_url":"https://api.github.com/users/bayliffe/followers","following_url":"https://api.github.com/users/bayliffe/following{/other_user}","gists_url":"https://api.github.com/users/bayliffe/gists{/gist_id}","starred_url":"https://api.github.com/users/bayliffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bayliffe/subscriptions","organizations_url":"https://api.github.com/users/bayliffe/orgs","repos_url":"https://api.github.com/users/bayliffe/repos","events_url":"https://api.github.com/users/bayliffe/events{/privacy}","received_events_url":"https://api.github.com/users/bayliffe/received_events","type":"User","site_admin":false},"repo":{"id":89453063,"name":"improver","full_name":"bayliffe/improver","owner":{"login":"bayliffe","id":28042362,"avatar_url":"https://avatars0.githubusercontent.com/u/28042362?v=3","gravatar_id":"","url":"https://api.github.com/users/bayliffe","html_url":"https://github.com/bayliffe","followers_url":"https://api.github.com/users/bayliffe/followers","following_url":"https://api.github.com/users/bayliffe/following{/other_user}","gists_url":"https://api.github.com/users/bayliffe/gists{/gist_id}","starred_url":"https://api.github.com/users/bayliffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bayliffe/subscriptions","organizations_url":"https://api.github.com/users/bayliffe/orgs","repos_url":"https://api.github.com/users/bayliffe/repos","events_url":"https://api.github.com/users/bayliffe/events{/privacy}","received_events_url":"https://api.github.com/users/bayliffe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bayliffe/improver","description":"IMPROVER","fork":true,"url":"https://api.github.com/repos/bayliffe/improver","forks_url":"https://api.github.com/repos/bayliffe/improver/forks","keys_url":"https://api.github.com/repos/bayliffe/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bayliffe/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bayliffe/improver/teams","hooks_url":"https://api.github.com/repos/bayliffe/improver/hooks","issue_events_url":"https://api.github.com/repos/bayliffe/improver/issues/events{/number}","events_url":"https://api.github.com/repos/bayliffe/improver/events","assignees_url":"https://api.github.com/repos/bayliffe/improver/assignees{/user}","branches_url":"https://api.github.com/repos/bayliffe/improver/branches{/branch}","tags_url":"https://api.github.com/repos/bayliffe/improver/tags","blobs_url":"https://api.github.com/repos/bayliffe/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bayliffe/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bayliffe/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/bayliffe/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bayliffe/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/bayliffe/improver/languages","stargazers_url":"https://api.github.com/repos/bayliffe/improver/stargazers","contributors_url":"https://api.github.com/repos/bayliffe/improver/contributors","subscribers_url":"https://api.github.com/repos/bayliffe/improver/subscribers","subscription_url":"https://api.github.com/repos/bayliffe/improver/subscription","commits_url":"https://api.github.com/repos/bayliffe/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/bayliffe/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/bayliffe/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/bayliffe/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/bayliffe/improver/contents/{+path}","compare_url":"https://api.github.com/repos/bayliffe/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bayliffe/improver/merges","archive_url":"https://api.github.com/repos/bayliffe/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bayliffe/improver/downloads","issues_url":"https://api.github.com/repos/bayliffe/improver/issues{/number}","pulls_url":"https://api.github.com/repos/bayliffe/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/bayliffe/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/bayliffe/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bayliffe/improver/labels{/name}","releases_url":"https://api.github.com/repos/bayliffe/improver/releases{/id}","deployments_url":"https://api.github.com/repos/bayliffe/improver/deployments","created_at":"2017-04-26T07:45:39Z","updated_at":"2017-04-26T07:47:12Z","pushed_at":"2017-05-25T09:36:09Z","git_url":"git://github.com/bayliffe/improver.git","ssh_url":"[email protected]:bayliffe/improver.git","clone_url":"https://github.com/bayliffe/improver.git","svn_url":"https://github.com/bayliffe/improver","homepage":null,"size":145,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"metoppv:master","ref":"master","sha":"8a47affd2a70321bcf41d5dd3b9363ee498bc1c2","user":{"login":"metoppv","id":26465485,"avatar_url":"https://avatars1.githubusercontent.com/u/26465485?v=3","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"repo":{"id":85334761,"name":"improver","full_name":"metoppv/improver","owner":{"login":"metoppv","id":26465485,"avatar_url":"https://avatars1.githubusercontent.com/u/26465485?v=3","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metoppv/improver","description":"IMPROVER","fork":false,"url":"https://api.github.com/repos/metoppv/improver","forks_url":"https://api.github.com/repos/metoppv/improver/forks","keys_url":"https://api.github.com/repos/metoppv/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metoppv/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metoppv/improver/teams","hooks_url":"https://api.github.com/repos/metoppv/improver/hooks","issue_events_url":"https://api.github.com/repos/metoppv/improver/issues/events{/number}","events_url":"https://api.github.com/repos/metoppv/improver/events","assignees_url":"https://api.github.com/repos/metoppv/improver/assignees{/user}","branches_url":"https://api.github.com/repos/metoppv/improver/branches{/branch}","tags_url":"https://api.github.com/repos/metoppv/improver/tags","blobs_url":"https://api.github.com/repos/metoppv/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metoppv/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metoppv/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/metoppv/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/metoppv/improver/languages","stargazers_url":"https://api.github.com/repos/metoppv/improver/stargazers","contributors_url":"https://api.github.com/repos/metoppv/improver/contributors","subscribers_url":"https://api.github.com/repos/metoppv/improver/subscribers","subscription_url":"https://api.github.com/repos/metoppv/improver/subscription","commits_url":"https://api.github.com/repos/metoppv/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/metoppv/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/metoppv/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/metoppv/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/metoppv/improver/contents/{+path}","compare_url":"https://api.github.com/repos/metoppv/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metoppv/improver/merges","archive_url":"https://api.github.com/repos/metoppv/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metoppv/improver/downloads","issues_url":"https://api.github.com/repos/metoppv/improver/issues{/number}","pulls_url":"https://api.github.com/repos/metoppv/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/metoppv/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/metoppv/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metoppv/improver/labels{/name}","releases_url":"https://api.github.com/repos/metoppv/improver/releases{/id}","deployments_url":"https://api.github.com/repos/metoppv/improver/deployments","created_at":"2017-03-17T16:51:29Z","updated_at":"2017-04-27T12:56:56Z","pushed_at":"2017-05-25T14:47:39Z","git_url":"git://github.com/metoppv/improver.git","ssh_url":"[email protected]:metoppv/improver.git","clone_url":"https://github.com/metoppv/improver.git","svn_url":"https://github.com/metoppv/improver","homepage":null,"size":138,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":52,"forks":11,"open_issues":52,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/61"},"html":{"href":"https://github.com/metoppv/improver/pull/61"},"issue":{"href":"https://api.github.com/repos/metoppv/improver/issues/61"},"comments":{"href":"https://api.github.com/repos/metoppv/improver/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/metoppv/improver/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metoppv/improver/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/metoppv/improver/statuses/6c12d8c275fdfd9a605621dc3e8620b6c71ad1ef"}}}} | {
"id": 85334761,
"name": "metoppv/improver",
"url": "https://api.github.com/repos/metoppv/improver"
} | {
"id": 1138333,
"login": "benfitzpatrick",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1138333?",
"url": "https://api.github.com/users/benfitzpatrick"
} | {
"id": 26465485,
"login": "metoppv",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26465485?",
"url": "https://api.github.com/orgs/metoppv"
} | 2017-05-26T10:59:29 | 5948321288 | {"actor":{"display_login":"benfitzpatrick"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/pulls/comments/125715192","pull_request_review_id":48131494,"id":125715192,"diff_hunk":"@@ -194,6 +175,41 @@ function hasUserSetPreference() {\n return false;\n }\n \n+// extracting the root certificate from the chain\n+function extractRootCert(cert) {\n+ let root_cert = cert;\n+\n+ while (getFieldValue(root_cert, 'issuer')) {\n+ root_cert = getFieldValue(root_cert, 'issuer');\n+ }\n+\n+ return root_cert;\n+}\n+\n+// returns true if there is at least one non-builtin root certificate is installed\n+function isNonBuiltInRootCertInstalled() {\n+ let certDB = Cc[\"@mozilla.org/security/x509certdb;1\"].getService(Ci.nsIX509CertDB);\n+\n+ var iter = certDB.getCerts().getEnumerator();\n+\n+ while (iter.hasMoreElements()) {\n+ let cert = iter.getNext().QueryInterface(Ci.nsIX509Cert);\n+\n+ // extract the root certificate for the current certificate\n+ let root_cert = extractRootCert(cert);","path":"addons/tls13-middlebox/bootstrap.js","position":null,"original_position":149,"commit_id":"8ec25ddc9127796b4f23898fc15a1cbafd5a3328","original_commit_id":"547607cb729c3d1a5ee97c9f24b67ac2f730ac84","user":{"login":"ekr","id":1111457,"avatar_url":"https://avatars3.githubusercontent.com/u/1111457?v=3","gravatar_id":"","url":"https://api.github.com/users/ekr","html_url":"https://github.com/ekr","followers_url":"https://api.github.com/users/ekr/followers","following_url":"https://api.github.com/users/ekr/following{/other_user}","gists_url":"https://api.github.com/users/ekr/gists{/gist_id}","starred_url":"https://api.github.com/users/ekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekr/subscriptions","organizations_url":"https://api.github.com/users/ekr/orgs","repos_url":"https://api.github.com/users/ekr/repos","events_url":"https://api.github.com/users/ekr/events{/privacy}","received_events_url":"https://api.github.com/users/ekr/received_events","type":"User","site_admin":false},"body":"This is kinda weird. What set of certs is this? You don't want a list of all the certs we know, but just all our roots.","created_at":"2017-07-05T17:59:58Z","updated_at":"2017-07-05T18:00:36Z","html_url":"https://github.com/mozilla/one-off-system-add-ons/pull/46#discussion_r125715192","pull_request_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/mozilla/one-off-system-add-ons/pulls/comments/125715192"},"html":{"href":"https://github.com/mozilla/one-off-system-add-ons/pull/46#discussion_r125715192"},"pull_request":{"href":"https://api.github.com/repos/mozilla/one-off-system-add-ons/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/pulls/46","id":128258708,"html_url":"https://github.com/mozilla/one-off-system-add-ons/pull/46","diff_url":"https://github.com/mozilla/one-off-system-add-ons/pull/46.diff","patch_url":"https://github.com/mozilla/one-off-system-add-ons/pull/46.patch","issue_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/issues/46","number":46,"state":"open","locked":false,"title":"draft version ready for review by Ekr","user":{"login":"sajjadium","id":22202721,"avatar_url":"https://avatars0.githubusercontent.com/u/22202721?v=3","gravatar_id":"","url":"https://api.github.com/users/sajjadium","html_url":"https://github.com/sajjadium","followers_url":"https://api.github.com/users/sajjadium/followers","following_url":"https://api.github.com/users/sajjadium/following{/other_user}","gists_url":"https://api.github.com/users/sajjadium/gists{/gist_id}","starred_url":"https://api.github.com/users/sajjadium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sajjadium/subscriptions","organizations_url":"https://api.github.com/users/sajjadium/orgs","repos_url":"https://api.github.com/users/sajjadium/repos","events_url":"https://api.github.com/users/sajjadium/events{/privacy}","received_events_url":"https://api.github.com/users/sajjadium/received_events","type":"User","site_admin":false},"body":"Please let me know what changes are required.\r\n","created_at":"2017-06-29T22:13:00Z","updated_at":"2017-07-05T18:00:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae8632203bd211cf19a9324d3db5ce56896fc1fd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/pulls/46/commits","review_comments_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/pulls/46/comments","review_comment_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/issues/46/comments","statuses_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/statuses/8ec25ddc9127796b4f23898fc15a1cbafd5a3328","head":{"label":"sajjadium:tls13-middlebox-ekr-review","ref":"tls13-middlebox-ekr-review","sha":"8ec25ddc9127796b4f23898fc15a1cbafd5a3328","user":{"login":"sajjadium","id":22202721,"avatar_url":"https://avatars0.githubusercontent.com/u/22202721?v=3","gravatar_id":"","url":"https://api.github.com/users/sajjadium","html_url":"https://github.com/sajjadium","followers_url":"https://api.github.com/users/sajjadium/followers","following_url":"https://api.github.com/users/sajjadium/following{/other_user}","gists_url":"https://api.github.com/users/sajjadium/gists{/gist_id}","starred_url":"https://api.github.com/users/sajjadium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sajjadium/subscriptions","organizations_url":"https://api.github.com/users/sajjadium/orgs","repos_url":"https://api.github.com/users/sajjadium/repos","events_url":"https://api.github.com/users/sajjadium/events{/privacy}","received_events_url":"https://api.github.com/users/sajjadium/received_events","type":"User","site_admin":false},"repo":{"id":95823681,"name":"one-off-system-add-ons","full_name":"sajjadium/one-off-system-add-ons","owner":{"login":"sajjadium","id":22202721,"avatar_url":"https://avatars0.githubusercontent.com/u/22202721?v=3","gravatar_id":"","url":"https://api.github.com/users/sajjadium","html_url":"https://github.com/sajjadium","followers_url":"https://api.github.com/users/sajjadium/followers","following_url":"https://api.github.com/users/sajjadium/following{/other_user}","gists_url":"https://api.github.com/users/sajjadium/gists{/gist_id}","starred_url":"https://api.github.com/users/sajjadium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sajjadium/subscriptions","organizations_url":"https://api.github.com/users/sajjadium/orgs","repos_url":"https://api.github.com/users/sajjadium/repos","events_url":"https://api.github.com/users/sajjadium/events{/privacy}","received_events_url":"https://api.github.com/users/sajjadium/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sajjadium/one-off-system-add-ons","description":"One off system add-ons ship fixes and updates to users of releases already shipped, without a dot release. ","fork":true,"url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons","forks_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/forks","keys_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/teams","hooks_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/hooks","issue_events_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/issues/events{/number}","events_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/events","assignees_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/assignees{/user}","branches_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/branches{/branch}","tags_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/tags","blobs_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/git/refs{/sha}","trees_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/statuses/{sha}","languages_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/languages","stargazers_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/stargazers","contributors_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/contributors","subscribers_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/subscribers","subscription_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/subscription","commits_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/commits{/sha}","git_commits_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/git/commits{/sha}","comments_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/comments{/number}","issue_comment_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/issues/comments{/number}","contents_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/contents/{+path}","compare_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/merges","archive_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/downloads","issues_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/issues{/number}","pulls_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/pulls{/number}","milestones_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/milestones{/number}","notifications_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/labels{/name}","releases_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/releases{/id}","deployments_url":"https://api.github.com/repos/sajjadium/one-off-system-add-ons/deployments","created_at":"2017-06-29T22:02:49Z","updated_at":"2017-06-29T22:02:51Z","pushed_at":"2017-07-05T17:57:33Z","git_url":"git://github.com/sajjadium/one-off-system-add-ons.git","ssh_url":"[email protected]:sajjadium/one-off-system-add-ons.git","clone_url":"https://github.com/sajjadium/one-off-system-add-ons.git","svn_url":"https://github.com/sajjadium/one-off-system-add-ons","homepage":null,"size":101,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"cacf300286e6565044e08c1ef452aabe4a2d43ad","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars1.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":73240711,"name":"one-off-system-add-ons","full_name":"mozilla/one-off-system-add-ons","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars1.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/one-off-system-add-ons","description":"One off system add-ons ship fixes and updates to users of releases already shipped, without a dot release. ","fork":false,"url":"https://api.github.com/repos/mozilla/one-off-system-add-ons","forks_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/forks","keys_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/teams","hooks_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/hooks","issue_events_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/events","assignees_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/tags","blobs_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/languages","stargazers_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/stargazers","contributors_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/contributors","subscribers_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/subscribers","subscription_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/subscription","commits_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/merges","archive_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/downloads","issues_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/one-off-system-add-ons/deployments","created_at":"2016-11-09T00:58:48Z","updated_at":"2017-04-11T16:22:24Z","pushed_at":"2017-07-05T17:57:35Z","git_url":"git://github.com/mozilla/one-off-system-add-ons.git","ssh_url":"[email protected]:mozilla/one-off-system-add-ons.git","clone_url":"https://github.com/mozilla/one-off-system-add-ons.git","svn_url":"https://github.com/mozilla/one-off-system-add-ons","homepage":null,"size":108,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":3,"forks":11,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/one-off-system-add-ons/pulls/46"},"html":{"href":"https://github.com/mozilla/one-off-system-add-ons/pull/46"},"issue":{"href":"https://api.github.com/repos/mozilla/one-off-system-add-ons/issues/46"},"comments":{"href":"https://api.github.com/repos/mozilla/one-off-system-add-ons/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/one-off-system-add-ons/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/one-off-system-add-ons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/one-off-system-add-ons/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/one-off-system-add-ons/statuses/8ec25ddc9127796b4f23898fc15a1cbafd5a3328"}}}} | {
"id": 73240711,
"name": "mozilla/one-off-system-add-ons",
"url": "https://api.github.com/repos/mozilla/one-off-system-add-ons"
} | {
"id": 1111457,
"login": "ekr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1111457?",
"url": "https://api.github.com/users/ekr"
} | {
"id": 131524,
"login": "mozilla",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/131524?",
"url": "https://api.github.com/orgs/mozilla"
} | 2017-07-05T17:59:58 | 6197942252 | {"actor":{"display_login":"ekr"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/balrog/pulls/comments/102828632","pull_request_review_id":23598078,"id":102828632,"diff_hunk":"@@ -58,7 +58,7 @@ <h3 class=\"panel-title\">\n <form role=\"form\" ng-submit=\"grantRole()\">\n <div class=\"form-group\" ng-class=\"{'has-error': errors.role}\">\n <label for=\"id_role\">Role</label>\n- <input type=\"text\" class=\"form-control\" id=\"id_role\" ng-model=\"role.role\"\n+ <input type=\"text\" class=\"form-control\" id=\"id_role\" ng-model=\"role.role\" autocomplete=\"off\"\n typeahead=\"role for role in roles_list | filter:$viewValue | limitTo:16\">\n <p class=\"help-block\" ng-show=\"errors.role\">{{ errors.role.join(', ') }}</p>\n </div>","path":"ui/app/templates/permissions_modal.html","position":8,"original_position":8,"commit_id":"5aa69637fd5becb2316f4cb86104fb25d4c9ae2f","original_commit_id":"5aa69637fd5becb2316f4cb86104fb25d4c9ae2f","user":{"login":"mozbhearsum","id":49649,"avatar_url":"https://avatars.githubusercontent.com/u/49649?v=3","gravatar_id":"","url":"https://api.github.com/users/mozbhearsum","html_url":"https://github.com/mozbhearsum","followers_url":"https://api.github.com/users/mozbhearsum/followers","following_url":"https://api.github.com/users/mozbhearsum/following{/other_user}","gists_url":"https://api.github.com/users/mozbhearsum/gists{/gist_id}","starred_url":"https://api.github.com/users/mozbhearsum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozbhearsum/subscriptions","organizations_url":"https://api.github.com/users/mozbhearsum/orgs","repos_url":"https://api.github.com/users/mozbhearsum/repos","events_url":"https://api.github.com/users/mozbhearsum/events{/privacy}","received_events_url":"https://api.github.com/users/mozbhearsum/received_events","type":"User","site_admin":false},"body":"I think the reason that the Save button is further up is because we have save/delete buttons for existing permissions in the bottom half of the modal. Maybe we should change the close button to red to make it more obvious? To be honest though, I think this UI could do with a bit of an overhaul. There's a lot of small issues with that might be fixed by rethinking it.","created_at":"2017-02-23T21:54:08Z","updated_at":"2017-02-23T21:54:08Z","html_url":"https://github.com/mozilla/balrog/pull/253#discussion_r102828632","pull_request_url":"https://api.github.com/repos/mozilla/balrog/pulls/253","_links":{"self":{"href":"https://api.github.com/repos/mozilla/balrog/pulls/comments/102828632"},"html":{"href":"https://github.com/mozilla/balrog/pull/253#discussion_r102828632"},"pull_request":{"href":"https://api.github.com/repos/mozilla/balrog/pulls/253"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/balrog/pulls/253","id":105980446,"html_url":"https://github.com/mozilla/balrog/pull/253","diff_url":"https://github.com/mozilla/balrog/pull/253.diff","patch_url":"https://github.com/mozilla/balrog/pull/253.patch","issue_url":"https://api.github.com/repos/mozilla/balrog/issues/253","number":253,"state":"open","locked":false,"title":"UI for Required Signoffs management","user":{"login":"mozbhearsum","id":49649,"avatar_url":"https://avatars.githubusercontent.com/u/49649?v=3","gravatar_id":"","url":"https://api.github.com/users/mozbhearsum","html_url":"https://github.com/mozbhearsum","followers_url":"https://api.github.com/users/mozbhearsum/followers","following_url":"https://api.github.com/users/mozbhearsum/following{/other_user}","gists_url":"https://api.github.com/users/mozbhearsum/gists{/gist_id}","starred_url":"https://api.github.com/users/mozbhearsum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozbhearsum/subscriptions","organizations_url":"https://api.github.com/users/mozbhearsum/orgs","repos_url":"https://api.github.com/users/mozbhearsum/repos","events_url":"https://api.github.com/users/mozbhearsum/events{/privacy}","received_events_url":"https://api.github.com/users/mozbhearsum/received_events","type":"User","site_admin":false},"body":"This is my attempt at a unified view for Required Signoffs, Scheduled Changes, and Signoffs. I was originally going to implement this as simple CRUD like we have for other parts of the UI, but after starting down that path I thought it was going to be much nicer to be able to see and manipulate all Required Signoffs as a group, rather than needing to flip back and forth through current/pending. I'd love to know what you think of that, and if there's things you think would make it better. I _think_ the UI is pretty self explanatory, but let me know if anything is unclear.\r\n\r\nRandom notes:\r\n- All of the Signoff/Revocation UI and controllers should be fully re-usable for Rules, Releases, and Permissions.\r\n- In order to make Scheduled Changes get enacted, I included the one line needed to finish bug 1310217.\r\n- I've tried to simplify ui/app/js/controllers/required_signoffs_modal_base_controller.js as best I can, but I realize it's still pretty tough to read. Sorry :(.\r\n- I'm not entirely happy with having a new top level nav item for Required Signoffs. I considered separating the UI into Product and Permissions, and putting the Permissions one in the Permissions drop down...but I couldn't figure out where Product Required Signoffs would go.\r\n\r\nI should mention that there's a few bugs I'm aware of:\r\n- Whenever we make multiple changes in one dialog, we send multiple requests to the backend in parallel. This means that even if one fails, the others might succeed. Ideally, we'd revert everything if anything fails, but I'm not sure this is entirely fixable right now. Eg: if the first Required Signoff is added directly, and a Scheduled Change addition fails, we can't directly delete the Required Signoff. Ultimately, I think being able to batch multiple changes together in a single HTTP request (which would put them in a single Transaction) is the right fix.\r\n- When new changes are Scheduled, the Required Signoffs they need don't show up until after a refresh (because they aren't returned by that endpoint). This is annoying in testing, because you often use a User who holds multiple Roles, which means you don't get the automatic signoff from #246. In production, Users will likely only hold one Role, and others will be loading the page from scratch before signing off anyways. I do think we should fix this, but I didn't want to block on it. If you think we should, we can do that.\r\n- History is not implemented at all. This didn't seem like a blocker, and I didn't want to further delay this project. Obviously needs to be fixed.","created_at":"2017-02-13T21:13:37Z","updated_at":"2017-02-23T21:54:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ed7cafa7f14799667cd8556de75dc9167dac0bc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/balrog/pulls/253/commits","review_comments_url":"https://api.github.com/repos/mozilla/balrog/pulls/253/comments","review_comment_url":"https://api.github.com/repos/mozilla/balrog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/balrog/issues/253/comments","statuses_url":"https://api.github.com/repos/mozilla/balrog/statuses/5aa69637fd5becb2316f4cb86104fb25d4c9ae2f","head":{"label":"mozbhearsum:rs-ui","ref":"rs-ui","sha":"5aa69637fd5becb2316f4cb86104fb25d4c9ae2f","user":{"login":"mozbhearsum","id":49649,"avatar_url":"https://avatars.githubusercontent.com/u/49649?v=3","gravatar_id":"","url":"https://api.github.com/users/mozbhearsum","html_url":"https://github.com/mozbhearsum","followers_url":"https://api.github.com/users/mozbhearsum/followers","following_url":"https://api.github.com/users/mozbhearsum/following{/other_user}","gists_url":"https://api.github.com/users/mozbhearsum/gists{/gist_id}","starred_url":"https://api.github.com/users/mozbhearsum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozbhearsum/subscriptions","organizations_url":"https://api.github.com/users/mozbhearsum/orgs","repos_url":"https://api.github.com/users/mozbhearsum/repos","events_url":"https://api.github.com/users/mozbhearsum/events{/privacy}","received_events_url":"https://api.github.com/users/mozbhearsum/received_events","type":"User","site_admin":false},"repo":{"id":2570483,"name":"balrog","full_name":"mozbhearsum/balrog","owner":{"login":"mozbhearsum","id":49649,"avatar_url":"https://avatars.githubusercontent.com/u/49649?v=3","gravatar_id":"","url":"https://api.github.com/users/mozbhearsum","html_url":"https://github.com/mozbhearsum","followers_url":"https://api.github.com/users/mozbhearsum/followers","following_url":"https://api.github.com/users/mozbhearsum/following{/other_user}","gists_url":"https://api.github.com/users/mozbhearsum/gists{/gist_id}","starred_url":"https://api.github.com/users/mozbhearsum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozbhearsum/subscriptions","organizations_url":"https://api.github.com/users/mozbhearsum/orgs","repos_url":"https://api.github.com/users/mozbhearsum/repos","events_url":"https://api.github.com/users/mozbhearsum/events{/privacy}","received_events_url":"https://api.github.com/users/mozbhearsum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mozbhearsum/balrog","description":"Next generation update service for Mozilla products","fork":true,"url":"https://api.github.com/repos/mozbhearsum/balrog","forks_url":"https://api.github.com/repos/mozbhearsum/balrog/forks","keys_url":"https://api.github.com/repos/mozbhearsum/balrog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozbhearsum/balrog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozbhearsum/balrog/teams","hooks_url":"https://api.github.com/repos/mozbhearsum/balrog/hooks","issue_events_url":"https://api.github.com/repos/mozbhearsum/balrog/issues/events{/number}","events_url":"https://api.github.com/repos/mozbhearsum/balrog/events","assignees_url":"https://api.github.com/repos/mozbhearsum/balrog/assignees{/user}","branches_url":"https://api.github.com/repos/mozbhearsum/balrog/branches{/branch}","tags_url":"https://api.github.com/repos/mozbhearsum/balrog/tags","blobs_url":"https://api.github.com/repos/mozbhearsum/balrog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozbhearsum/balrog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozbhearsum/balrog/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozbhearsum/balrog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozbhearsum/balrog/statuses/{sha}","languages_url":"https://api.github.com/repos/mozbhearsum/balrog/languages","stargazers_url":"https://api.github.com/repos/mozbhearsum/balrog/stargazers","contributors_url":"https://api.github.com/repos/mozbhearsum/balrog/contributors","subscribers_url":"https://api.github.com/repos/mozbhearsum/balrog/subscribers","subscription_url":"https://api.github.com/repos/mozbhearsum/balrog/subscription","commits_url":"https://api.github.com/repos/mozbhearsum/balrog/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozbhearsum/balrog/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozbhearsum/balrog/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozbhearsum/balrog/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozbhearsum/balrog/contents/{+path}","compare_url":"https://api.github.com/repos/mozbhearsum/balrog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozbhearsum/balrog/merges","archive_url":"https://api.github.com/repos/mozbhearsum/balrog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozbhearsum/balrog/downloads","issues_url":"https://api.github.com/repos/mozbhearsum/balrog/issues{/number}","pulls_url":"https://api.github.com/repos/mozbhearsum/balrog/pulls{/number}","milestones_url":"https://api.github.com/repos/mozbhearsum/balrog/milestones{/number}","notifications_url":"https://api.github.com/repos/mozbhearsum/balrog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozbhearsum/balrog/labels{/name}","releases_url":"https://api.github.com/repos/mozbhearsum/balrog/releases{/id}","deployments_url":"https://api.github.com/repos/mozbhearsum/balrog/deployments","created_at":"2011-10-13T15:58:54Z","updated_at":"2016-08-31T17:23:24Z","pushed_at":"2017-02-21T20:58:29Z","git_url":"git://github.com/mozbhearsum/balrog.git","ssh_url":"[email protected]:mozbhearsum/balrog.git","clone_url":"https://github.com/mozbhearsum/balrog.git","svn_url":"https://github.com/mozbhearsum/balrog","homepage":"","size":64740,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"fd03557db8d4be1ed1c5986114fc3734da0a7da8","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":2570444,"name":"balrog","full_name":"mozilla/balrog","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/balrog","description":"Next generation update service for Mozilla products","fork":false,"url":"https://api.github.com/repos/mozilla/balrog","forks_url":"https://api.github.com/repos/mozilla/balrog/forks","keys_url":"https://api.github.com/repos/mozilla/balrog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/balrog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/balrog/teams","hooks_url":"https://api.github.com/repos/mozilla/balrog/hooks","issue_events_url":"https://api.github.com/repos/mozilla/balrog/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/balrog/events","assignees_url":"https://api.github.com/repos/mozilla/balrog/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/balrog/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/balrog/tags","blobs_url":"https://api.github.com/repos/mozilla/balrog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/balrog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/balrog/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/balrog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/balrog/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/balrog/languages","stargazers_url":"https://api.github.com/repos/mozilla/balrog/stargazers","contributors_url":"https://api.github.com/repos/mozilla/balrog/contributors","subscribers_url":"https://api.github.com/repos/mozilla/balrog/subscribers","subscription_url":"https://api.github.com/repos/mozilla/balrog/subscription","commits_url":"https://api.github.com/repos/mozilla/balrog/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/balrog/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/balrog/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/balrog/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/balrog/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/balrog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/balrog/merges","archive_url":"https://api.github.com/repos/mozilla/balrog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/balrog/downloads","issues_url":"https://api.github.com/repos/mozilla/balrog/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/balrog/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/balrog/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/balrog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/balrog/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/balrog/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/balrog/deployments","created_at":"2011-10-13T15:51:47Z","updated_at":"2017-02-16T20:54:12Z","pushed_at":"2017-02-23T20:39:32Z","git_url":"git://github.com/mozilla/balrog.git","ssh_url":"[email protected]:mozilla/balrog.git","clone_url":"https://github.com/mozilla/balrog.git","svn_url":"https://github.com/mozilla/balrog","homepage":"","size":61571,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":4,"forks":73,"open_issues":4,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/balrog/pulls/253"},"html":{"href":"https://github.com/mozilla/balrog/pull/253"},"issue":{"href":"https://api.github.com/repos/mozilla/balrog/issues/253"},"comments":{"href":"https://api.github.com/repos/mozilla/balrog/issues/253/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/balrog/pulls/253/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/balrog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/balrog/pulls/253/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/balrog/statuses/5aa69637fd5becb2316f4cb86104fb25d4c9ae2f"}}}} | {
"id": 2570444,
"name": "mozilla/balrog",
"url": "https://api.github.com/repos/mozilla/balrog"
} | {
"id": 49649,
"login": "mozbhearsum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49649?",
"url": "https://api.github.com/users/mozbhearsum"
} | {
"id": 131524,
"login": "mozilla",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/131524?",
"url": "https://api.github.com/orgs/mozilla"
} | 2017-02-23T21:54:08 | 5381337324 | {"actor":{"display_login":"mozbhearsum"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments/118434123","pull_request_review_id":40224479,"id":118434123,"diff_hunk":"@@ -66,9 +72,27 @@ define(function (require, exports, module) {\n sender,\n window: win\n });\n+ },\n+\n+ /**\n+ * Check if the browser supports the FXA_STATUS request.\n+ *\n+ * @param {String} [userAgent] UA string to check.\n+ * Defaults to `this.getUserAgentString()`\n+ * @returns {Boolean}\n+ */\n+ isFxaStatusSupported (userAgent = this.getUserAgentString()) {","path":"app/scripts/lib/channels/web.js","position":46,"original_position":46,"commit_id":"b6b54c90aebd9cc8e296ebe358d03d27bf2e94ed","original_commit_id":"b6b54c90aebd9cc8e296ebe358d03d27bf2e94ed","user":{"login":"philbooth","id":64367,"avatar_url":"https://avatars1.githubusercontent.com/u/64367?v=3","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false},"body":"TIL that default values can be function calls and have access to `this`.","created_at":"2017-05-25T07:37:05Z","updated_at":"2017-05-25T07:37:05Z","html_url":"https://github.com/mozilla/fxa-content-server/pull/4695#discussion_r118434123","pull_request_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/4695","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments/118434123"},"html":{"href":"https://github.com/mozilla/fxa-content-server/pull/4695#discussion_r118434123"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/4695"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/4695","id":104300747,"html_url":"https://github.com/mozilla/fxa-content-server/pull/4695","diff_url":"https://github.com/mozilla/fxa-content-server/pull/4695.diff","patch_url":"https://github.com/mozilla/fxa-content-server/pull/4695.patch","issue_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/4695","number":4695,"state":"open","locked":false,"title":"feat(client): Sync state with the browser!","user":{"login":"shane-tomlinson","id":848085,"avatar_url":"https://avatars0.githubusercontent.com/u/848085?v=3","gravatar_id":"","url":"https://api.github.com/users/shane-tomlinson","html_url":"https://github.com/shane-tomlinson","followers_url":"https://api.github.com/users/shane-tomlinson/followers","following_url":"https://api.github.com/users/shane-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/shane-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/shane-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shane-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/shane-tomlinson/orgs","repos_url":"https://api.github.com/users/shane-tomlinson/repos","events_url":"https://api.github.com/users/shane-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/shane-tomlinson/received_events","type":"User","site_admin":false},"body":"Very early stage yet, putting this up so we don't forget about it. Goes along with https://bugzilla.mozilla.org/attachment.cgi?id=8832820\r\n\r\nPerform a handshake with the browser to use the browser as the canonical\r\nsource of truth when it comes to signed in accounts.\r\n\r\nissue #4252\r\nhttps://bugzilla.mozilla.org/show_bug.cgi?id=1308038","created_at":"2017-02-02T09:29:11Z","updated_at":"2017-05-25T07:37:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebbc28ad547494e85587b25d6a84513b1716f1e6","assignee":{"login":"vladikoff","id":128755,"avatar_url":"https://avatars0.githubusercontent.com/u/128755?v=3","gravatar_id":"","url":"https://api.github.com/users/vladikoff","html_url":"https://github.com/vladikoff","followers_url":"https://api.github.com/users/vladikoff/followers","following_url":"https://api.github.com/users/vladikoff/following{/other_user}","gists_url":"https://api.github.com/users/vladikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/vladikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladikoff/subscriptions","organizations_url":"https://api.github.com/users/vladikoff/orgs","repos_url":"https://api.github.com/users/vladikoff/repos","events_url":"https://api.github.com/users/vladikoff/events{/privacy}","received_events_url":"https://api.github.com/users/vladikoff/received_events","type":"User","site_admin":false},"assignees":[{"login":"vladikoff","id":128755,"avatar_url":"https://avatars0.githubusercontent.com/u/128755?v=3","gravatar_id":"","url":"https://api.github.com/users/vladikoff","html_url":"https://github.com/vladikoff","followers_url":"https://api.github.com/users/vladikoff/followers","following_url":"https://api.github.com/users/vladikoff/following{/other_user}","gists_url":"https://api.github.com/users/vladikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/vladikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladikoff/subscriptions","organizations_url":"https://api.github.com/users/vladikoff/orgs","repos_url":"https://api.github.com/users/vladikoff/repos","events_url":"https://api.github.com/users/vladikoff/events{/privacy}","received_events_url":"https://api.github.com/users/vladikoff/received_events","type":"User","site_admin":false},{"login":"shane-tomlinson","id":848085,"avatar_url":"https://avatars0.githubusercontent.com/u/848085?v=3","gravatar_id":"","url":"https://api.github.com/users/shane-tomlinson","html_url":"https://github.com/shane-tomlinson","followers_url":"https://api.github.com/users/shane-tomlinson/followers","following_url":"https://api.github.com/users/shane-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/shane-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/shane-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shane-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/shane-tomlinson/orgs","repos_url":"https://api.github.com/users/shane-tomlinson/repos","events_url":"https://api.github.com/users/shane-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/shane-tomlinson/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"vladikoff","id":128755,"avatar_url":"https://avatars0.githubusercontent.com/u/128755?v=3","gravatar_id":"","url":"https://api.github.com/users/vladikoff","html_url":"https://github.com/vladikoff","followers_url":"https://api.github.com/users/vladikoff/followers","following_url":"https://api.github.com/users/vladikoff/following{/other_user}","gists_url":"https://api.github.com/users/vladikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/vladikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladikoff/subscriptions","organizations_url":"https://api.github.com/users/vladikoff/orgs","repos_url":"https://api.github.com/users/vladikoff/repos","events_url":"https://api.github.com/users/vladikoff/events{/privacy}","received_events_url":"https://api.github.com/users/vladikoff/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/milestones/64","html_url":"https://github.com/mozilla/fxa-content-server/milestone/64","labels_url":"https://api.github.com/repos/mozilla/fxa-content-server/milestones/64/labels","id":1265659,"number":64,"title":"FxA-0: quality","description":"general quality improvements","creator":{"login":"rfk","id":34695,"avatar_url":"https://avatars0.githubusercontent.com/u/34695?v=3","gravatar_id":"","url":"https://api.github.com/users/rfk","html_url":"https://github.com/rfk","followers_url":"https://api.github.com/users/rfk/followers","following_url":"https://api.github.com/users/rfk/following{/other_user}","gists_url":"https://api.github.com/users/rfk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfk/subscriptions","organizations_url":"https://api.github.com/users/rfk/orgs","repos_url":"https://api.github.com/users/rfk/repos","events_url":"https://api.github.com/users/rfk/events{/privacy}","received_events_url":"https://api.github.com/users/rfk/received_events","type":"User","site_admin":false},"open_issues":48,"closed_issues":689,"state":"open","created_at":"2015-08-21T02:49:53Z","updated_at":"2017-05-24T04:45:32Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/4695/commits","review_comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/4695/comments","review_comment_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/4695/comments","statuses_url":"https://api.github.com/repos/mozilla/fxa-content-server/statuses/b6b54c90aebd9cc8e296ebe358d03d27bf2e94ed","head":{"label":"mozilla:issue-4252-sync-me-with-the-browser","ref":"issue-4252-sync-me-with-the-browser","sha":"b6b54c90aebd9cc8e296ebe358d03d27bf2e94ed","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars1.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":11778024,"name":"fxa-content-server","full_name":"mozilla/fxa-content-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars1.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-content-server","description":"Firefox Accounts Content Server","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-content-server","forks_url":"https://api.github.com/repos/mozilla/fxa-content-server/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-content-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-content-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-content-server/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-content-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-content-server/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-content-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-content-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-content-server/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-content-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-content-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-content-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-content-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-content-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-content-server/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-content-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-content-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-content-server/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-content-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-content-server/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-content-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-content-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-content-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-content-server/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/fxa-content-server/deployments","created_at":"2013-07-30T23:35:35Z","updated_at":"2017-05-21T15:00:10Z","pushed_at":"2017-05-24T21:46:44Z","git_url":"git://github.com/mozilla/fxa-content-server.git","ssh_url":"[email protected]:mozilla/fxa-content-server.git","clone_url":"https://github.com/mozilla/fxa-content-server.git","svn_url":"https://github.com/mozilla/fxa-content-server","homepage":"","size":15680,"stargazers_count":110,"watchers_count":110,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":90,"mirror_url":null,"open_issues_count":129,"forks":90,"open_issues":129,"watchers":110,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"efea8259eec9c4816511296bf914ddea44145728","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars1.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":11778024,"name":"fxa-content-server","full_name":"mozilla/fxa-content-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars1.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-content-server","description":"Firefox Accounts Content Server","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-content-server","forks_url":"https://api.github.com/repos/mozilla/fxa-content-server/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-content-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-content-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-content-server/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-content-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-content-server/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-content-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-content-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-content-server/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-content-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-content-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-content-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-content-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-content-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-content-server/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-content-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-content-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-content-server/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-content-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-content-server/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-content-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-content-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-content-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-content-server/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/fxa-content-server/deployments","created_at":"2013-07-30T23:35:35Z","updated_at":"2017-05-21T15:00:10Z","pushed_at":"2017-05-24T21:46:44Z","git_url":"git://github.com/mozilla/fxa-content-server.git","ssh_url":"[email protected]:mozilla/fxa-content-server.git","clone_url":"https://github.com/mozilla/fxa-content-server.git","svn_url":"https://github.com/mozilla/fxa-content-server","homepage":"","size":15680,"stargazers_count":110,"watchers_count":110,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":90,"mirror_url":null,"open_issues_count":129,"forks":90,"open_issues":129,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/4695"},"html":{"href":"https://github.com/mozilla/fxa-content-server/pull/4695"},"issue":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/issues/4695"},"comments":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/issues/4695/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/4695/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/4695/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/statuses/b6b54c90aebd9cc8e296ebe358d03d27bf2e94ed"}}}} | {
"id": 11778024,
"name": "mozilla/fxa-content-server",
"url": "https://api.github.com/repos/mozilla/fxa-content-server"
} | {
"id": 64367,
"login": "philbooth",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/64367?",
"url": "https://api.github.com/users/philbooth"
} | {
"id": 131524,
"login": "mozilla",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/131524?",
"url": "https://api.github.com/orgs/mozilla"
} | 2017-05-25T07:37:05 | 5939975332 | {"actor":{"display_login":"philbooth"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/comments/120937510","pull_request_review_id":42932496,"id":120937510,"diff_hunk":"@@ -1,16 +1,22 @@\n import React from 'react';\n+import { shallow } from 'enzyme';\n \n import Icon from 'ui/components/Icon';\n-import { shallowRender } from 'tests/unit/helpers';\n+\n \n describe('<Icon />', () => {\n it('maps the name to a className', () => {\n- const root = shallowRender(<Icon name=\"foo\" />);\n- expect(root.props.className).toEqual('Icon Icon-foo');\n+ const root = shallow(<Icon name=\"foo\" />);\n+\n+ expect(root.hasClass('Icon Icon-foo')).toBeTruthy();\n+ expect(root.hasClass('Icon Icon-foo')).toBeTruthy();\n });\n \n it('allows a custom className', () => {\n- const root = shallowRender(<Icon name=\"bar\" className=\"sup\" />);\n- expect(root.props.className).toEqual('Icon Icon-bar sup');\n+ const root = shallow(<Icon name=\"bar\" className=\"sup\" />);\n+\n+ expect(root.hasClass('Icon')).toBeTruthy();\n+ expect(root.hasClass('Icon-bar')).toBeTruthy();","path":"tests/unit/ui/components/TestIcon.js","position":24,"original_position":24,"commit_id":"9ecf8b9664f359e27c0269cfa29988304f781814","original_commit_id":"9ecf8b9664f359e27c0269cfa29988304f781814","user":{"login":"kumar303","id":55398,"avatar_url":"https://avatars2.githubusercontent.com/u/55398?v=3","gravatar_id":"","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"body":"`toHaveClassName`","created_at":"2017-06-08T16:34:23Z","updated_at":"2017-06-08T16:35:22Z","html_url":"https://github.com/mozilla/addons-frontend/pull/2540#discussion_r120937510","pull_request_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/2540","_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/comments/120937510"},"html":{"href":"https://github.com/mozilla/addons-frontend/pull/2540#discussion_r120937510"},"pull_request":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/2540"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/2540","id":124539034,"html_url":"https://github.com/mozilla/addons-frontend/pull/2540","diff_url":"https://github.com/mozilla/addons-frontend/pull/2540.diff","patch_url":"https://github.com/mozilla/addons-frontend/pull/2540.patch","issue_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/2540","number":2540,"state":"open","locked":false,"title":"Convert to enzyme for shallow rendering","user":{"login":"tofumatt","id":90871,"avatar_url":"https://avatars1.githubusercontent.com/u/90871?v=3","gravatar_id":"","url":"https://api.github.com/users/tofumatt","html_url":"https://github.com/tofumatt","followers_url":"https://api.github.com/users/tofumatt/followers","following_url":"https://api.github.com/users/tofumatt/following{/other_user}","gists_url":"https://api.github.com/users/tofumatt/gists{/gist_id}","starred_url":"https://api.github.com/users/tofumatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofumatt/subscriptions","organizations_url":"https://api.github.com/users/tofumatt/orgs","repos_url":"https://api.github.com/users/tofumatt/repos","events_url":"https://api.github.com/users/tofumatt/events{/privacy}","received_events_url":"https://api.github.com/users/tofumatt/received_events","type":"User","site_admin":false},"body":"Got interested in this while shallow-testing a new component and decided to see how much effort it would take to replace all our `shallowRender()` calls with Enzyme's `shallow()`. Turns out it wasn't too much so here we go.\r\n\r\nAnnoyingly the `yarn.lock` additions don't highlight this for the like 200 removed lines this actually is. 😆\r\n\r\nThis relates to #1104 but I'm not sure if we should consider it closed as that issue also mentions replacing things like `Simulate.click()` which this patch doesn't do. Maybe we should close that issue as it says \"Consider Enzyme\" which we clearly did by merging this, but make new issues for specific other tweaks we want?\r\n\r\nFixes #2508.\r\nFixes #2539.","created_at":"2017-06-07T23:27:40Z","updated_at":"2017-06-08T16:35:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0934671aaf6ae5751a224b774abab3abc2cfab63","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/2540/commits","review_comments_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/2540/comments","review_comment_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/2540/comments","statuses_url":"https://api.github.com/repos/mozilla/addons-frontend/statuses/9ecf8b9664f359e27c0269cfa29988304f781814","head":{"label":"mozilla:convert-to-enzyme-2539","ref":"convert-to-enzyme-2539","sha":"9ecf8b9664f359e27c0269cfa29988304f781814","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars1.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":52104368,"name":"addons-frontend","full_name":"mozilla/addons-frontend","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars1.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/addons-frontend","description":"Front-end to complement mozilla/addons-server","fork":false,"url":"https://api.github.com/repos/mozilla/addons-frontend","forks_url":"https://api.github.com/repos/mozilla/addons-frontend/forks","keys_url":"https://api.github.com/repos/mozilla/addons-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/addons-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/addons-frontend/teams","hooks_url":"https://api.github.com/repos/mozilla/addons-frontend/hooks","issue_events_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/addons-frontend/events","assignees_url":"https://api.github.com/repos/mozilla/addons-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/addons-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/addons-frontend/tags","blobs_url":"https://api.github.com/repos/mozilla/addons-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/addons-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/addons-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/addons-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/addons-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/addons-frontend/languages","stargazers_url":"https://api.github.com/repos/mozilla/addons-frontend/stargazers","contributors_url":"https://api.github.com/repos/mozilla/addons-frontend/contributors","subscribers_url":"https://api.github.com/repos/mozilla/addons-frontend/subscribers","subscription_url":"https://api.github.com/repos/mozilla/addons-frontend/subscription","commits_url":"https://api.github.com/repos/mozilla/addons-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/addons-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/addons-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/addons-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/addons-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/addons-frontend/merges","archive_url":"https://api.github.com/repos/mozilla/addons-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/addons-frontend/downloads","issues_url":"https://api.github.com/repos/mozilla/addons-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/addons-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/addons-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/addons-frontend/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/addons-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/addons-frontend/deployments","created_at":"2016-02-19T17:25:57Z","updated_at":"2017-06-06T00:07:53Z","pushed_at":"2017-06-08T16:11:51Z","git_url":"git://github.com/mozilla/addons-frontend.git","ssh_url":"[email protected]:mozilla/addons-frontend.git","clone_url":"https://github.com/mozilla/addons-frontend.git","svn_url":"https://github.com/mozilla/addons-frontend","homepage":"","size":258158,"stargazers_count":34,"watchers_count":34,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":257,"forks":35,"open_issues":257,"watchers":34,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"d16585ed3531c85dd3d6f65aec66622337390de7","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars1.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":52104368,"name":"addons-frontend","full_name":"mozilla/addons-frontend","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars1.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/addons-frontend","description":"Front-end to complement mozilla/addons-server","fork":false,"url":"https://api.github.com/repos/mozilla/addons-frontend","forks_url":"https://api.github.com/repos/mozilla/addons-frontend/forks","keys_url":"https://api.github.com/repos/mozilla/addons-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/addons-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/addons-frontend/teams","hooks_url":"https://api.github.com/repos/mozilla/addons-frontend/hooks","issue_events_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/addons-frontend/events","assignees_url":"https://api.github.com/repos/mozilla/addons-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/addons-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/addons-frontend/tags","blobs_url":"https://api.github.com/repos/mozilla/addons-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/addons-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/addons-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/addons-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/addons-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/addons-frontend/languages","stargazers_url":"https://api.github.com/repos/mozilla/addons-frontend/stargazers","contributors_url":"https://api.github.com/repos/mozilla/addons-frontend/contributors","subscribers_url":"https://api.github.com/repos/mozilla/addons-frontend/subscribers","subscription_url":"https://api.github.com/repos/mozilla/addons-frontend/subscription","commits_url":"https://api.github.com/repos/mozilla/addons-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/addons-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/addons-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/addons-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/addons-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/addons-frontend/merges","archive_url":"https://api.github.com/repos/mozilla/addons-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/addons-frontend/downloads","issues_url":"https://api.github.com/repos/mozilla/addons-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/addons-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/addons-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/addons-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/addons-frontend/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/addons-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/addons-frontend/deployments","created_at":"2016-02-19T17:25:57Z","updated_at":"2017-06-06T00:07:53Z","pushed_at":"2017-06-08T16:11:51Z","git_url":"git://github.com/mozilla/addons-frontend.git","ssh_url":"[email protected]:mozilla/addons-frontend.git","clone_url":"https://github.com/mozilla/addons-frontend.git","svn_url":"https://github.com/mozilla/addons-frontend","homepage":"","size":258158,"stargazers_count":34,"watchers_count":34,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":257,"forks":35,"open_issues":257,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/2540"},"html":{"href":"https://github.com/mozilla/addons-frontend/pull/2540"},"issue":{"href":"https://api.github.com/repos/mozilla/addons-frontend/issues/2540"},"comments":{"href":"https://api.github.com/repos/mozilla/addons-frontend/issues/2540/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/2540/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/addons-frontend/pulls/2540/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/addons-frontend/statuses/9ecf8b9664f359e27c0269cfa29988304f781814"}}}} | {
"id": 52104368,
"name": "mozilla/addons-frontend",
"url": "https://api.github.com/repos/mozilla/addons-frontend"
} | {
"id": 55398,
"login": "kumar303",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/55398?",
"url": "https://api.github.com/users/kumar303"
} | {
"id": 131524,
"login": "mozilla",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/131524?",
"url": "https://api.github.com/orgs/mozilla"
} | 2017-06-08T16:34:23 | 6028838606 | {"actor":{"display_login":"kumar303"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/neotoma/sync-server/pulls/comments/133942959","pull_request_review_id":57182695,"id":133942959,"diff_hunk":"@@ -69,30 +66,27 @@ var methods = Object.assign({\n * @property {string} [totalItemsAvailableFromPagePathTemplate=response.${contentTypePluralCamelName}.count] - String template used to generate object paths to value representing total items available for contentType within pages returned from source\n */\n module.exports = modelFactory.new('Source', {\n- apiVersion: String,\n- authScope: Array,\n- clientId: String,\n- clientSecret: String,\n- // contentTypes: [{ ref: 'ContentType' }],\n- itemDataObjectsFromPagePathTemplate: { type: String, default: 'data' },\n- // this is where you specifiy what you want from source\n- // itemsGetUrlTemplate: { type: String, default: 'https://${host}/${contentTypePluralCamelName}?access_token=${accessToken}&limit=${limit}&offset=${offset}' },\n+ apiVersion: String,\n+ authScope: Array,\n+ clientId: String,\n+ clientSecret: String,\n+ itemDataObjectsFromPagePathTemplate: {type: String, default: 'data'},\n \n \n- itemStorageEnabled: { type: Boolean, default: false },\n- host: String,\n- itemsLimit: { type: Number, default: 25 },\n- logoGlyphPath: String,\n- name: { type: String, required: true },\n- passportStrategy: String,\n- slug: String,\n- totalItemsAvailableFromPagePathTemplate: String\n+ itemStorageEnabled: {type: Boolean, default: false},","path":"app/models/source.js","position":null,"original_position":113,"commit_id":"2227cd7e560327864d6ac26c00cdcc3e5816ce87","original_commit_id":"2227cd7e560327864d6ac26c00cdcc3e5816ce87","user":{"login":"markmhx","id":28991,"avatar_url":"https://avatars2.githubusercontent.com/u/28991?v=4","gravatar_id":"","url":"https://api.github.com/users/markmhx","html_url":"https://github.com/markmhx","followers_url":"https://api.github.com/users/markmhx/followers","following_url":"https://api.github.com/users/markmhx/following{/other_user}","gists_url":"https://api.github.com/users/markmhx/gists{/gist_id}","starred_url":"https://api.github.com/users/markmhx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markmhx/subscriptions","organizations_url":"https://api.github.com/users/markmhx/orgs","repos_url":"https://api.github.com/users/markmhx/repos","events_url":"https://api.github.com/users/markmhx/events{/privacy}","received_events_url":"https://api.github.com/users/markmhx/received_events","type":"User","site_admin":false},"body":"Indentation issue?","created_at":"2017-08-18T12:05:47Z","updated_at":"2017-08-18T12:15:34Z","html_url":"https://github.com/neotoma/sync-server/pull/80#discussion_r133942959","pull_request_url":"https://api.github.com/repos/neotoma/sync-server/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/neotoma/sync-server/pulls/comments/133942959"},"html":{"href":"https://github.com/neotoma/sync-server/pull/80#discussion_r133942959"},"pull_request":{"href":"https://api.github.com/repos/neotoma/sync-server/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/neotoma/sync-server/pulls/80","id":135627758,"html_url":"https://github.com/neotoma/sync-server/pull/80","diff_url":"https://github.com/neotoma/sync-server/pull/80.diff","patch_url":"https://github.com/neotoma/sync-server/pull/80.patch","issue_url":"https://api.github.com/repos/neotoma/sync-server/issues/80","number":80,"state":"open","locked":false,"title":"Resolved issues #56 and #57: added sourceContentType and pulling FB photos","user":{"login":"pulpopurpura","id":7085067,"avatar_url":"https://avatars1.githubusercontent.com/u/7085067?v=4","gravatar_id":"","url":"https://api.github.com/users/pulpopurpura","html_url":"https://github.com/pulpopurpura","followers_url":"https://api.github.com/users/pulpopurpura/followers","following_url":"https://api.github.com/users/pulpopurpura/following{/other_user}","gists_url":"https://api.github.com/users/pulpopurpura/gists{/gist_id}","starred_url":"https://api.github.com/users/pulpopurpura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulpopurpura/subscriptions","organizations_url":"https://api.github.com/users/pulpopurpura/orgs","repos_url":"https://api.github.com/users/pulpopurpura/repos","events_url":"https://api.github.com/users/pulpopurpura/events{/privacy}","received_events_url":"https://api.github.com/users/pulpopurpura/received_events","type":"User","site_admin":false},"body":"Resolved git issue #56 and #57 (adding sourceContentType and addressing side effects in item.js, et al.) and grabbing FB photos -- ","created_at":"2017-08-14T15:50:07Z","updated_at":"2017-08-18T12:15:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be753456c90d07fb93b281ce4cbf08d69c76c666","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/neotoma/sync-server/pulls/80/commits","review_comments_url":"https://api.github.com/repos/neotoma/sync-server/pulls/80/comments","review_comment_url":"https://api.github.com/repos/neotoma/sync-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neotoma/sync-server/issues/80/comments","statuses_url":"https://api.github.com/repos/neotoma/sync-server/statuses/2227cd7e560327864d6ac26c00cdcc3e5816ce87","head":{"label":"neotoma:features/add-source-content-type","ref":"features/add-source-content-type","sha":"2227cd7e560327864d6ac26c00cdcc3e5816ce87","user":{"login":"neotoma","id":5330634,"avatar_url":"https://avatars3.githubusercontent.com/u/5330634?v=4","gravatar_id":"","url":"https://api.github.com/users/neotoma","html_url":"https://github.com/neotoma","followers_url":"https://api.github.com/users/neotoma/followers","following_url":"https://api.github.com/users/neotoma/following{/other_user}","gists_url":"https://api.github.com/users/neotoma/gists{/gist_id}","starred_url":"https://api.github.com/users/neotoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neotoma/subscriptions","organizations_url":"https://api.github.com/users/neotoma/orgs","repos_url":"https://api.github.com/users/neotoma/repos","events_url":"https://api.github.com/users/neotoma/events{/privacy}","received_events_url":"https://api.github.com/users/neotoma/received_events","type":"Organization","site_admin":false},"repo":{"id":17685501,"name":"sync-server","full_name":"neotoma/sync-server","owner":{"login":"neotoma","id":5330634,"avatar_url":"https://avatars3.githubusercontent.com/u/5330634?v=4","gravatar_id":"","url":"https://api.github.com/users/neotoma","html_url":"https://github.com/neotoma","followers_url":"https://api.github.com/users/neotoma/followers","following_url":"https://api.github.com/users/neotoma/following{/other_user}","gists_url":"https://api.github.com/users/neotoma/gists{/gist_id}","starred_url":"https://api.github.com/users/neotoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neotoma/subscriptions","organizations_url":"https://api.github.com/users/neotoma/orgs","repos_url":"https://api.github.com/users/neotoma/repos","events_url":"https://api.github.com/users/neotoma/events{/privacy}","received_events_url":"https://api.github.com/users/neotoma/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neotoma/sync-server","description":"Service that synchronizes data from sources to storage on behalf of users","fork":false,"url":"https://api.github.com/repos/neotoma/sync-server","forks_url":"https://api.github.com/repos/neotoma/sync-server/forks","keys_url":"https://api.github.com/repos/neotoma/sync-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neotoma/sync-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neotoma/sync-server/teams","hooks_url":"https://api.github.com/repos/neotoma/sync-server/hooks","issue_events_url":"https://api.github.com/repos/neotoma/sync-server/issues/events{/number}","events_url":"https://api.github.com/repos/neotoma/sync-server/events","assignees_url":"https://api.github.com/repos/neotoma/sync-server/assignees{/user}","branches_url":"https://api.github.com/repos/neotoma/sync-server/branches{/branch}","tags_url":"https://api.github.com/repos/neotoma/sync-server/tags","blobs_url":"https://api.github.com/repos/neotoma/sync-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neotoma/sync-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neotoma/sync-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/neotoma/sync-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neotoma/sync-server/statuses/{sha}","languages_url":"https://api.github.com/repos/neotoma/sync-server/languages","stargazers_url":"https://api.github.com/repos/neotoma/sync-server/stargazers","contributors_url":"https://api.github.com/repos/neotoma/sync-server/contributors","subscribers_url":"https://api.github.com/repos/neotoma/sync-server/subscribers","subscription_url":"https://api.github.com/repos/neotoma/sync-server/subscription","commits_url":"https://api.github.com/repos/neotoma/sync-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/neotoma/sync-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/neotoma/sync-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/neotoma/sync-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/neotoma/sync-server/contents/{+path}","compare_url":"https://api.github.com/repos/neotoma/sync-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neotoma/sync-server/merges","archive_url":"https://api.github.com/repos/neotoma/sync-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neotoma/sync-server/downloads","issues_url":"https://api.github.com/repos/neotoma/sync-server/issues{/number}","pulls_url":"https://api.github.com/repos/neotoma/sync-server/pulls{/number}","milestones_url":"https://api.github.com/repos/neotoma/sync-server/milestones{/number}","notifications_url":"https://api.github.com/repos/neotoma/sync-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neotoma/sync-server/labels{/name}","releases_url":"https://api.github.com/repos/neotoma/sync-server/releases{/id}","deployments_url":"https://api.github.com/repos/neotoma/sync-server/deployments","created_at":"2014-03-12T21:55:36Z","updated_at":"2017-06-29T17:44:08Z","pushed_at":"2017-08-17T14:23:59Z","git_url":"git://github.com/neotoma/sync-server.git","ssh_url":"[email protected]:neotoma/sync-server.git","clone_url":"https://github.com/neotoma/sync-server.git","svn_url":"https://github.com/neotoma/sync-server","homepage":"","size":1289,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":25,"forks":1,"open_issues":25,"watchers":5,"default_branch":"master"}},"base":{"label":"neotoma:master","ref":"master","sha":"22631b572c61d073c19b4bf0cd45990caa0192e4","user":{"login":"neotoma","id":5330634,"avatar_url":"https://avatars3.githubusercontent.com/u/5330634?v=4","gravatar_id":"","url":"https://api.github.com/users/neotoma","html_url":"https://github.com/neotoma","followers_url":"https://api.github.com/users/neotoma/followers","following_url":"https://api.github.com/users/neotoma/following{/other_user}","gists_url":"https://api.github.com/users/neotoma/gists{/gist_id}","starred_url":"https://api.github.com/users/neotoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neotoma/subscriptions","organizations_url":"https://api.github.com/users/neotoma/orgs","repos_url":"https://api.github.com/users/neotoma/repos","events_url":"https://api.github.com/users/neotoma/events{/privacy}","received_events_url":"https://api.github.com/users/neotoma/received_events","type":"Organization","site_admin":false},"repo":{"id":17685501,"name":"sync-server","full_name":"neotoma/sync-server","owner":{"login":"neotoma","id":5330634,"avatar_url":"https://avatars3.githubusercontent.com/u/5330634?v=4","gravatar_id":"","url":"https://api.github.com/users/neotoma","html_url":"https://github.com/neotoma","followers_url":"https://api.github.com/users/neotoma/followers","following_url":"https://api.github.com/users/neotoma/following{/other_user}","gists_url":"https://api.github.com/users/neotoma/gists{/gist_id}","starred_url":"https://api.github.com/users/neotoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neotoma/subscriptions","organizations_url":"https://api.github.com/users/neotoma/orgs","repos_url":"https://api.github.com/users/neotoma/repos","events_url":"https://api.github.com/users/neotoma/events{/privacy}","received_events_url":"https://api.github.com/users/neotoma/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neotoma/sync-server","description":"Service that synchronizes data from sources to storage on behalf of users","fork":false,"url":"https://api.github.com/repos/neotoma/sync-server","forks_url":"https://api.github.com/repos/neotoma/sync-server/forks","keys_url":"https://api.github.com/repos/neotoma/sync-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neotoma/sync-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neotoma/sync-server/teams","hooks_url":"https://api.github.com/repos/neotoma/sync-server/hooks","issue_events_url":"https://api.github.com/repos/neotoma/sync-server/issues/events{/number}","events_url":"https://api.github.com/repos/neotoma/sync-server/events","assignees_url":"https://api.github.com/repos/neotoma/sync-server/assignees{/user}","branches_url":"https://api.github.com/repos/neotoma/sync-server/branches{/branch}","tags_url":"https://api.github.com/repos/neotoma/sync-server/tags","blobs_url":"https://api.github.com/repos/neotoma/sync-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neotoma/sync-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neotoma/sync-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/neotoma/sync-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neotoma/sync-server/statuses/{sha}","languages_url":"https://api.github.com/repos/neotoma/sync-server/languages","stargazers_url":"https://api.github.com/repos/neotoma/sync-server/stargazers","contributors_url":"https://api.github.com/repos/neotoma/sync-server/contributors","subscribers_url":"https://api.github.com/repos/neotoma/sync-server/subscribers","subscription_url":"https://api.github.com/repos/neotoma/sync-server/subscription","commits_url":"https://api.github.com/repos/neotoma/sync-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/neotoma/sync-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/neotoma/sync-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/neotoma/sync-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/neotoma/sync-server/contents/{+path}","compare_url":"https://api.github.com/repos/neotoma/sync-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neotoma/sync-server/merges","archive_url":"https://api.github.com/repos/neotoma/sync-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neotoma/sync-server/downloads","issues_url":"https://api.github.com/repos/neotoma/sync-server/issues{/number}","pulls_url":"https://api.github.com/repos/neotoma/sync-server/pulls{/number}","milestones_url":"https://api.github.com/repos/neotoma/sync-server/milestones{/number}","notifications_url":"https://api.github.com/repos/neotoma/sync-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neotoma/sync-server/labels{/name}","releases_url":"https://api.github.com/repos/neotoma/sync-server/releases{/id}","deployments_url":"https://api.github.com/repos/neotoma/sync-server/deployments","created_at":"2014-03-12T21:55:36Z","updated_at":"2017-06-29T17:44:08Z","pushed_at":"2017-08-17T14:23:59Z","git_url":"git://github.com/neotoma/sync-server.git","ssh_url":"[email protected]:neotoma/sync-server.git","clone_url":"https://github.com/neotoma/sync-server.git","svn_url":"https://github.com/neotoma/sync-server","homepage":"","size":1289,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":25,"forks":1,"open_issues":25,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neotoma/sync-server/pulls/80"},"html":{"href":"https://github.com/neotoma/sync-server/pull/80"},"issue":{"href":"https://api.github.com/repos/neotoma/sync-server/issues/80"},"comments":{"href":"https://api.github.com/repos/neotoma/sync-server/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/neotoma/sync-server/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/neotoma/sync-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neotoma/sync-server/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/neotoma/sync-server/statuses/2227cd7e560327864d6ac26c00cdcc3e5816ce87"}}}} | {
"id": 17685501,
"name": "neotoma/sync-server",
"url": "https://api.github.com/repos/neotoma/sync-server"
} | {
"id": 28991,
"login": "markmhx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28991?",
"url": "https://api.github.com/users/markmhx"
} | {
"id": 5330634,
"login": "neotoma",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5330634?",
"url": "https://api.github.com/orgs/neotoma"
} | 2017-08-18T12:05:47 | 6479988089 | {"actor":{"display_login":"markmhx"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/netlify/gotrue/pulls/comments/141726180","pull_request_review_id":65987681,"id":141726180,"diff_hunk":"@@ -62,13 +68,18 @@ func (a *API) ResourceOwnerPasswordGrant(ctx context.Context, w http.ResponseWri\n \t\treturn oauthError(\"invalid_grant\", \"Invalid Password\")\n \t}\n \n+\tif cookie != \"\" && config.Cookie.Enabled {\n+\t\ta.setCookieToken(ctx, user, cookie == useSessionCookie, w)","path":"api/token.go","position":28,"original_position":28,"commit_id":"b48d5fe4964f9bb823b5beb08f41f29d8e268bbb","original_commit_id":"b48d5fe4964f9bb823b5beb08f41f29d8e268bbb","user":{"login":"calavera","id":1050,"avatar_url":"https://avatars0.githubusercontent.com/u/1050?v=4","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"body":"we should at least log the error","created_at":"2017-09-28T20:21:45Z","updated_at":"2017-09-28T20:21:50Z","html_url":"https://github.com/netlify/gotrue/pull/110#discussion_r141726180","pull_request_url":"https://api.github.com/repos/netlify/gotrue/pulls/110","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/netlify/gotrue/pulls/comments/141726180"},"html":{"href":"https://github.com/netlify/gotrue/pull/110#discussion_r141726180"},"pull_request":{"href":"https://api.github.com/repos/netlify/gotrue/pulls/110"}},"in_reply_to_id":141639205},"pull_request":{"url":"https://api.github.com/repos/netlify/gotrue/pulls/110","id":143645732,"html_url":"https://github.com/netlify/gotrue/pull/110","diff_url":"https://github.com/netlify/gotrue/pull/110.diff","patch_url":"https://github.com/netlify/gotrue/pull/110.patch","issue_url":"https://api.github.com/repos/netlify/gotrue/issues/110","number":110,"state":"open","locked":false,"title":"Set cookie with JWT when requested","user":{"login":"biilmann","id":6515,"avatar_url":"https://avatars0.githubusercontent.com/u/6515?v=4","gravatar_id":"","url":"https://api.github.com/users/biilmann","html_url":"https://github.com/biilmann","followers_url":"https://api.github.com/users/biilmann/followers","following_url":"https://api.github.com/users/biilmann/following{/other_user}","gists_url":"https://api.github.com/users/biilmann/gists{/gist_id}","starred_url":"https://api.github.com/users/biilmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biilmann/subscriptions","organizations_url":"https://api.github.com/users/biilmann/orgs","repos_url":"https://api.github.com/users/biilmann/repos","events_url":"https://api.github.com/users/biilmann/events{/privacy}","received_events_url":"https://api.github.com/users/biilmann/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for submitting a pull request!\r\n\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/netlify/gotrue/blob/master/CONTRIBUTING.md\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\", where #xxxx is the issue number.\r\n\r\nPlease provide enough information so that others can review your pull request.\r\nThe first three fields are mandatory:\r\n-->\r\n\r\n**- Summary**\r\n\r\nNetlify allows role based authentication with JWTs and this fits great with Gotrue, but requires a lot of trickery client site to set cookies, and it also means the cookies can't follow best practices like being HTTP only.\r\n\r\nThis PR allows the consumer of GoTrue to pass a \"X-Set-Cookie\" header along when requesting a token. If GoTrue has been configured to allow cookies, it will then set a cookie with a JWT in the response. This should make it much more straight forward to take advantage of Netlify's CDN based access control for static files.\r\n\r\n**- Test plan**\r\n\r\nIt's easy to verify whether we set the cookie or not, but the real test will be to integrate this with a site using Netlify's role based access control.\r\n\r\n**- Description for the changelog**\r\n\r\nSupport for setting a secure, httpOnly cookie with a JWT on authentication.\r\n","created_at":"2017-09-28T13:19:29Z","updated_at":"2017-09-28T20:21:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acdd77dcb34fa377bb9fa77880749f8a3cfde987","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/netlify/gotrue/pulls/110/commits","review_comments_url":"https://api.github.com/repos/netlify/gotrue/pulls/110/comments","review_comment_url":"https://api.github.com/repos/netlify/gotrue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netlify/gotrue/issues/110/comments","statuses_url":"https://api.github.com/repos/netlify/gotrue/statuses/b48d5fe4964f9bb823b5beb08f41f29d8e268bbb","head":{"label":"netlify:cookie","ref":"cookie","sha":"b48d5fe4964f9bb823b5beb08f41f29d8e268bbb","user":{"login":"netlify","id":7892489,"avatar_url":"https://avatars1.githubusercontent.com/u/7892489?v=4","gravatar_id":"","url":"https://api.github.com/users/netlify","html_url":"https://github.com/netlify","followers_url":"https://api.github.com/users/netlify/followers","following_url":"https://api.github.com/users/netlify/following{/other_user}","gists_url":"https://api.github.com/users/netlify/gists{/gist_id}","starred_url":"https://api.github.com/users/netlify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netlify/subscriptions","organizations_url":"https://api.github.com/users/netlify/orgs","repos_url":"https://api.github.com/users/netlify/repos","events_url":"https://api.github.com/users/netlify/events{/privacy}","received_events_url":"https://api.github.com/users/netlify/received_events","type":"Organization","site_admin":false},"repo":{"id":58974323,"name":"gotrue","full_name":"netlify/gotrue","owner":{"login":"netlify","id":7892489,"avatar_url":"https://avatars1.githubusercontent.com/u/7892489?v=4","gravatar_id":"","url":"https://api.github.com/users/netlify","html_url":"https://github.com/netlify","followers_url":"https://api.github.com/users/netlify/followers","following_url":"https://api.github.com/users/netlify/following{/other_user}","gists_url":"https://api.github.com/users/netlify/gists{/gist_id}","starred_url":"https://api.github.com/users/netlify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netlify/subscriptions","organizations_url":"https://api.github.com/users/netlify/orgs","repos_url":"https://api.github.com/users/netlify/repos","events_url":"https://api.github.com/users/netlify/events{/privacy}","received_events_url":"https://api.github.com/users/netlify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netlify/gotrue","description":"An SWT based API for managing users and issuing SWT tokens","fork":false,"url":"https://api.github.com/repos/netlify/gotrue","forks_url":"https://api.github.com/repos/netlify/gotrue/forks","keys_url":"https://api.github.com/repos/netlify/gotrue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netlify/gotrue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netlify/gotrue/teams","hooks_url":"https://api.github.com/repos/netlify/gotrue/hooks","issue_events_url":"https://api.github.com/repos/netlify/gotrue/issues/events{/number}","events_url":"https://api.github.com/repos/netlify/gotrue/events","assignees_url":"https://api.github.com/repos/netlify/gotrue/assignees{/user}","branches_url":"https://api.github.com/repos/netlify/gotrue/branches{/branch}","tags_url":"https://api.github.com/repos/netlify/gotrue/tags","blobs_url":"https://api.github.com/repos/netlify/gotrue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netlify/gotrue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netlify/gotrue/git/refs{/sha}","trees_url":"https://api.github.com/repos/netlify/gotrue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netlify/gotrue/statuses/{sha}","languages_url":"https://api.github.com/repos/netlify/gotrue/languages","stargazers_url":"https://api.github.com/repos/netlify/gotrue/stargazers","contributors_url":"https://api.github.com/repos/netlify/gotrue/contributors","subscribers_url":"https://api.github.com/repos/netlify/gotrue/subscribers","subscription_url":"https://api.github.com/repos/netlify/gotrue/subscription","commits_url":"https://api.github.com/repos/netlify/gotrue/commits{/sha}","git_commits_url":"https://api.github.com/repos/netlify/gotrue/git/commits{/sha}","comments_url":"https://api.github.com/repos/netlify/gotrue/comments{/number}","issue_comment_url":"https://api.github.com/repos/netlify/gotrue/issues/comments{/number}","contents_url":"https://api.github.com/repos/netlify/gotrue/contents/{+path}","compare_url":"https://api.github.com/repos/netlify/gotrue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netlify/gotrue/merges","archive_url":"https://api.github.com/repos/netlify/gotrue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netlify/gotrue/downloads","issues_url":"https://api.github.com/repos/netlify/gotrue/issues{/number}","pulls_url":"https://api.github.com/repos/netlify/gotrue/pulls{/number}","milestones_url":"https://api.github.com/repos/netlify/gotrue/milestones{/number}","notifications_url":"https://api.github.com/repos/netlify/gotrue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netlify/gotrue/labels{/name}","releases_url":"https://api.github.com/repos/netlify/gotrue/releases{/id}","deployments_url":"https://api.github.com/repos/netlify/gotrue/deployments","created_at":"2016-05-16T23:14:24Z","updated_at":"2017-09-28T14:13:35Z","pushed_at":"2017-09-28T13:19:29Z","git_url":"git://github.com/netlify/gotrue.git","ssh_url":"[email protected]:netlify/gotrue.git","clone_url":"https://github.com/netlify/gotrue.git","svn_url":"https://github.com/netlify/gotrue","homepage":"https://www.gotrueapi.org","size":6395,"stargazers_count":181,"watchers_count":181,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":10,"forks":17,"open_issues":10,"watchers":181,"default_branch":"master"}},"base":{"label":"netlify:master","ref":"master","sha":"9fc2dbfa92a621647076b5fb9cc675ccba85dff4","user":{"login":"netlify","id":7892489,"avatar_url":"https://avatars1.githubusercontent.com/u/7892489?v=4","gravatar_id":"","url":"https://api.github.com/users/netlify","html_url":"https://github.com/netlify","followers_url":"https://api.github.com/users/netlify/followers","following_url":"https://api.github.com/users/netlify/following{/other_user}","gists_url":"https://api.github.com/users/netlify/gists{/gist_id}","starred_url":"https://api.github.com/users/netlify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netlify/subscriptions","organizations_url":"https://api.github.com/users/netlify/orgs","repos_url":"https://api.github.com/users/netlify/repos","events_url":"https://api.github.com/users/netlify/events{/privacy}","received_events_url":"https://api.github.com/users/netlify/received_events","type":"Organization","site_admin":false},"repo":{"id":58974323,"name":"gotrue","full_name":"netlify/gotrue","owner":{"login":"netlify","id":7892489,"avatar_url":"https://avatars1.githubusercontent.com/u/7892489?v=4","gravatar_id":"","url":"https://api.github.com/users/netlify","html_url":"https://github.com/netlify","followers_url":"https://api.github.com/users/netlify/followers","following_url":"https://api.github.com/users/netlify/following{/other_user}","gists_url":"https://api.github.com/users/netlify/gists{/gist_id}","starred_url":"https://api.github.com/users/netlify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netlify/subscriptions","organizations_url":"https://api.github.com/users/netlify/orgs","repos_url":"https://api.github.com/users/netlify/repos","events_url":"https://api.github.com/users/netlify/events{/privacy}","received_events_url":"https://api.github.com/users/netlify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netlify/gotrue","description":"An SWT based API for managing users and issuing SWT tokens","fork":false,"url":"https://api.github.com/repos/netlify/gotrue","forks_url":"https://api.github.com/repos/netlify/gotrue/forks","keys_url":"https://api.github.com/repos/netlify/gotrue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netlify/gotrue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netlify/gotrue/teams","hooks_url":"https://api.github.com/repos/netlify/gotrue/hooks","issue_events_url":"https://api.github.com/repos/netlify/gotrue/issues/events{/number}","events_url":"https://api.github.com/repos/netlify/gotrue/events","assignees_url":"https://api.github.com/repos/netlify/gotrue/assignees{/user}","branches_url":"https://api.github.com/repos/netlify/gotrue/branches{/branch}","tags_url":"https://api.github.com/repos/netlify/gotrue/tags","blobs_url":"https://api.github.com/repos/netlify/gotrue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netlify/gotrue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netlify/gotrue/git/refs{/sha}","trees_url":"https://api.github.com/repos/netlify/gotrue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netlify/gotrue/statuses/{sha}","languages_url":"https://api.github.com/repos/netlify/gotrue/languages","stargazers_url":"https://api.github.com/repos/netlify/gotrue/stargazers","contributors_url":"https://api.github.com/repos/netlify/gotrue/contributors","subscribers_url":"https://api.github.com/repos/netlify/gotrue/subscribers","subscription_url":"https://api.github.com/repos/netlify/gotrue/subscription","commits_url":"https://api.github.com/repos/netlify/gotrue/commits{/sha}","git_commits_url":"https://api.github.com/repos/netlify/gotrue/git/commits{/sha}","comments_url":"https://api.github.com/repos/netlify/gotrue/comments{/number}","issue_comment_url":"https://api.github.com/repos/netlify/gotrue/issues/comments{/number}","contents_url":"https://api.github.com/repos/netlify/gotrue/contents/{+path}","compare_url":"https://api.github.com/repos/netlify/gotrue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netlify/gotrue/merges","archive_url":"https://api.github.com/repos/netlify/gotrue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netlify/gotrue/downloads","issues_url":"https://api.github.com/repos/netlify/gotrue/issues{/number}","pulls_url":"https://api.github.com/repos/netlify/gotrue/pulls{/number}","milestones_url":"https://api.github.com/repos/netlify/gotrue/milestones{/number}","notifications_url":"https://api.github.com/repos/netlify/gotrue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netlify/gotrue/labels{/name}","releases_url":"https://api.github.com/repos/netlify/gotrue/releases{/id}","deployments_url":"https://api.github.com/repos/netlify/gotrue/deployments","created_at":"2016-05-16T23:14:24Z","updated_at":"2017-09-28T14:13:35Z","pushed_at":"2017-09-28T13:19:29Z","git_url":"git://github.com/netlify/gotrue.git","ssh_url":"[email protected]:netlify/gotrue.git","clone_url":"https://github.com/netlify/gotrue.git","svn_url":"https://github.com/netlify/gotrue","homepage":"https://www.gotrueapi.org","size":6395,"stargazers_count":181,"watchers_count":181,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":10,"forks":17,"open_issues":10,"watchers":181,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netlify/gotrue/pulls/110"},"html":{"href":"https://github.com/netlify/gotrue/pull/110"},"issue":{"href":"https://api.github.com/repos/netlify/gotrue/issues/110"},"comments":{"href":"https://api.github.com/repos/netlify/gotrue/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/netlify/gotrue/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/netlify/gotrue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netlify/gotrue/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/netlify/gotrue/statuses/b48d5fe4964f9bb823b5beb08f41f29d8e268bbb"}},"author_association":"OWNER"}} | {
"id": 58974323,
"name": "netlify/gotrue",
"url": "https://api.github.com/repos/netlify/gotrue"
} | {
"id": 1050,
"login": "calavera",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1050?",
"url": "https://api.github.com/users/calavera"
} | {
"id": 7892489,
"login": "netlify",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7892489?",
"url": "https://api.github.com/orgs/netlify"
} | 2017-09-28T20:21:45 | 6651515154 | {"actor":{"display_login":"calavera"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/netlify/gotrue/pulls/comments/139493386","pull_request_review_id":63415921,"id":139493386,"diff_hunk":"@@ -2,10 +2,33 @@ package models\n \n import (\n \t\"testing\"\n+\t\"time\"\n \n \t\"github.com/stretchr/testify/require\"\n )\n \n+func TestIsLocked(t *testing.T) {\n+\ttimestamp := time.Now().Add(-time.Duration(5) * time.Minute)\n+\tu := &User{\n+\t\tLockedAt: ×tamp,\n+\t}\n+\trequire.False(t, u.IsLocked(0), \"user should not be locked\")","path":"models/user_test.go","position":14,"original_position":14,"commit_id":"d8d9083dfe2ad5f92fa0b7343614b4008a5bf845","original_commit_id":"d8d9083dfe2ad5f92fa0b7343614b4008a5bf845","user":{"login":"rybit","id":406376,"avatar_url":"https://avatars3.githubusercontent.com/u/406376?v=4","gravatar_id":"","url":"https://api.github.com/users/rybit","html_url":"https://github.com/rybit","followers_url":"https://api.github.com/users/rybit/followers","following_url":"https://api.github.com/users/rybit/following{/other_user}","gists_url":"https://api.github.com/users/rybit/gists{/gist_id}","starred_url":"https://api.github.com/users/rybit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rybit/subscriptions","organizations_url":"https://api.github.com/users/rybit/orgs","repos_url":"https://api.github.com/users/rybit/repos","events_url":"https://api.github.com/users/rybit/events{/privacy}","received_events_url":"https://api.github.com/users/rybit/received_events","type":"User","site_admin":false},"body":"personally, I don't add comments to the error unless it is unclear or I am testing something that is convoluted. But that is just personal taste - nothing to take to the bank.","created_at":"2017-09-18T17:51:38Z","updated_at":"2017-09-18T17:51:41Z","html_url":"https://github.com/netlify/gotrue/pull/104#discussion_r139493386","pull_request_url":"https://api.github.com/repos/netlify/gotrue/pulls/104","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/netlify/gotrue/pulls/comments/139493386"},"html":{"href":"https://github.com/netlify/gotrue/pull/104#discussion_r139493386"},"pull_request":{"href":"https://api.github.com/repos/netlify/gotrue/pulls/104"}}},"pull_request":{"url":"https://api.github.com/repos/netlify/gotrue/pulls/104","id":141468499,"html_url":"https://github.com/netlify/gotrue/pull/104","diff_url":"https://github.com/netlify/gotrue/pull/104.diff","patch_url":"https://github.com/netlify/gotrue/pull/104.patch","issue_url":"https://api.github.com/repos/netlify/gotrue/issues/104","number":104,"state":"open","locked":false,"title":"Reasonable Security Measures","user":{"login":"mhayes","id":125222,"avatar_url":"https://avatars1.githubusercontent.com/u/125222?v=4","gravatar_id":"","url":"https://api.github.com/users/mhayes","html_url":"https://github.com/mhayes","followers_url":"https://api.github.com/users/mhayes/followers","following_url":"https://api.github.com/users/mhayes/following{/other_user}","gists_url":"https://api.github.com/users/mhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/mhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhayes/subscriptions","organizations_url":"https://api.github.com/users/mhayes/orgs","repos_url":"https://api.github.com/users/mhayes/repos","events_url":"https://api.github.com/users/mhayes/events{/privacy}","received_events_url":"https://api.github.com/users/mhayes/received_events","type":"User","site_admin":false},"body":"**- Summary**\r\n\r\n**Note:** All changes have been tested on my local system and appear to work as expected. Looking for some feedback on if the implementation makes sense or if there are ideas of how to improve things :)\r\n\r\nThe primary goal of this PR is to provide adequate security to most users while keeping the following in mind:\r\n\r\n- Default configuration shouldn’t need to be changed\r\n- End users shouldn’t be inconvenienced (i.e. if an account is locked it will unlock itself in a relatively short amount of time automatically)\r\n- Developers working with GoTrue shouldn’t have to do more integration work\r\n\r\nThe security features available in this PR are:\r\n\r\n## 1 Request Throttling\r\n\r\n**Status:** Code checked in, tests are failing\r\n\r\nPrevent bots from attempting to brute force login or signup attempts (which can leak information about users in the system).\r\n\r\n## 2 Locking Accounts\r\n\r\n**Status:** Code checked in, tests are passing.\r\n\r\nPrevent brute force login attempts for a particular user account. Request throttling will help, but not for a distributed brute force attack.\r\n\r\n## 3 Preventing Signup from “Fake”/ “Scammy” E-Mail Providers\r\n\r\n**Status:** Code checked in, tests are passing.\r\n\r\nEnsure that people are signing up with real e-mail addresses. Even though there is already an e-mail confirmation in place it doesn’t do much good if people are using a temporary e-mail address.\r\n\r\n## 4 Password Requirements\r\n\r\n**Status:** Code checked in, tests are passing.\r\n\r\nEnsure that users are setting passwords that are not easy to brute force.\r\n\r\n**- Test plan**\r\n\r\nTests specs have been added to cover new functionality. With the exception of the throttling tests which aren't working yet.\r\n\r\nI've also taken screenshots showing all the expected responses coming back from the API:\r\n\r\n## 1 Request Throttling\r\n\r\nA simple HTTP 429 error is returned when a user is not allowed to make any more requests.\r\n\r\n\r\n\r\n## 2 Locking Accounts\r\n\r\nOnce a user has attempted to sign in too many times with the wrong password they will see:\r\n\r\n\r\n\r\n## 3 Preventing Signup from “Fake”/ “Scammy” E-Mail Providers\r\n\r\nA nice heads up that the e-mail is not allowed to register.\r\n\r\n\r\n\r\n## 4 Password Requirements\r\n\r\nAnytime a password does not meet requirements it spits out this error:\r\n\r\n\r\n\r\n\r\n**- Description for the changelog**\r\n\r\nAdds request throttling, account locking, email blacklisting, and password strength security measures.\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2017-09-17T01:08:31Z","updated_at":"2017-09-18T17:51:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5052b8edfbb5d2b3f7ebacd282fd3fdfc0d0258e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/netlify/gotrue/pulls/104/commits","review_comments_url":"https://api.github.com/repos/netlify/gotrue/pulls/104/comments","review_comment_url":"https://api.github.com/repos/netlify/gotrue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netlify/gotrue/issues/104/comments","statuses_url":"https://api.github.com/repos/netlify/gotrue/statuses/d8d9083dfe2ad5f92fa0b7343614b4008a5bf845","head":{"label":"mhayes:master","ref":"master","sha":"d8d9083dfe2ad5f92fa0b7343614b4008a5bf845","user":{"login":"mhayes","id":125222,"avatar_url":"https://avatars1.githubusercontent.com/u/125222?v=4","gravatar_id":"","url":"https://api.github.com/users/mhayes","html_url":"https://github.com/mhayes","followers_url":"https://api.github.com/users/mhayes/followers","following_url":"https://api.github.com/users/mhayes/following{/other_user}","gists_url":"https://api.github.com/users/mhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/mhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhayes/subscriptions","organizations_url":"https://api.github.com/users/mhayes/orgs","repos_url":"https://api.github.com/users/mhayes/repos","events_url":"https://api.github.com/users/mhayes/events{/privacy}","received_events_url":"https://api.github.com/users/mhayes/received_events","type":"User","site_admin":false},"repo":{"id":103691727,"name":"gotrue","full_name":"mhayes/gotrue","owner":{"login":"mhayes","id":125222,"avatar_url":"https://avatars1.githubusercontent.com/u/125222?v=4","gravatar_id":"","url":"https://api.github.com/users/mhayes","html_url":"https://github.com/mhayes","followers_url":"https://api.github.com/users/mhayes/followers","following_url":"https://api.github.com/users/mhayes/following{/other_user}","gists_url":"https://api.github.com/users/mhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/mhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhayes/subscriptions","organizations_url":"https://api.github.com/users/mhayes/orgs","repos_url":"https://api.github.com/users/mhayes/repos","events_url":"https://api.github.com/users/mhayes/events{/privacy}","received_events_url":"https://api.github.com/users/mhayes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhayes/gotrue","description":"An SWT based API for managing users and issuing SWT tokens","fork":true,"url":"https://api.github.com/repos/mhayes/gotrue","forks_url":"https://api.github.com/repos/mhayes/gotrue/forks","keys_url":"https://api.github.com/repos/mhayes/gotrue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhayes/gotrue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhayes/gotrue/teams","hooks_url":"https://api.github.com/repos/mhayes/gotrue/hooks","issue_events_url":"https://api.github.com/repos/mhayes/gotrue/issues/events{/number}","events_url":"https://api.github.com/repos/mhayes/gotrue/events","assignees_url":"https://api.github.com/repos/mhayes/gotrue/assignees{/user}","branches_url":"https://api.github.com/repos/mhayes/gotrue/branches{/branch}","tags_url":"https://api.github.com/repos/mhayes/gotrue/tags","blobs_url":"https://api.github.com/repos/mhayes/gotrue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhayes/gotrue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhayes/gotrue/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhayes/gotrue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhayes/gotrue/statuses/{sha}","languages_url":"https://api.github.com/repos/mhayes/gotrue/languages","stargazers_url":"https://api.github.com/repos/mhayes/gotrue/stargazers","contributors_url":"https://api.github.com/repos/mhayes/gotrue/contributors","subscribers_url":"https://api.github.com/repos/mhayes/gotrue/subscribers","subscription_url":"https://api.github.com/repos/mhayes/gotrue/subscription","commits_url":"https://api.github.com/repos/mhayes/gotrue/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhayes/gotrue/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhayes/gotrue/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhayes/gotrue/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhayes/gotrue/contents/{+path}","compare_url":"https://api.github.com/repos/mhayes/gotrue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhayes/gotrue/merges","archive_url":"https://api.github.com/repos/mhayes/gotrue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhayes/gotrue/downloads","issues_url":"https://api.github.com/repos/mhayes/gotrue/issues{/number}","pulls_url":"https://api.github.com/repos/mhayes/gotrue/pulls{/number}","milestones_url":"https://api.github.com/repos/mhayes/gotrue/milestones{/number}","notifications_url":"https://api.github.com/repos/mhayes/gotrue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhayes/gotrue/labels{/name}","releases_url":"https://api.github.com/repos/mhayes/gotrue/releases{/id}","deployments_url":"https://api.github.com/repos/mhayes/gotrue/deployments","created_at":"2017-09-15T19:01:35Z","updated_at":"2017-09-15T19:01:37Z","pushed_at":"2017-09-18T02:14:03Z","git_url":"git://github.com/mhayes/gotrue.git","ssh_url":"[email protected]:mhayes/gotrue.git","clone_url":"https://github.com/mhayes/gotrue.git","svn_url":"https://github.com/mhayes/gotrue","homepage":"https://www.gotrueapi.org","size":6410,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netlify:master","ref":"master","sha":"9e189c17b8d5232a949357de362a942b52b8d8e7","user":{"login":"netlify","id":7892489,"avatar_url":"https://avatars1.githubusercontent.com/u/7892489?v=4","gravatar_id":"","url":"https://api.github.com/users/netlify","html_url":"https://github.com/netlify","followers_url":"https://api.github.com/users/netlify/followers","following_url":"https://api.github.com/users/netlify/following{/other_user}","gists_url":"https://api.github.com/users/netlify/gists{/gist_id}","starred_url":"https://api.github.com/users/netlify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netlify/subscriptions","organizations_url":"https://api.github.com/users/netlify/orgs","repos_url":"https://api.github.com/users/netlify/repos","events_url":"https://api.github.com/users/netlify/events{/privacy}","received_events_url":"https://api.github.com/users/netlify/received_events","type":"Organization","site_admin":false},"repo":{"id":58974323,"name":"gotrue","full_name":"netlify/gotrue","owner":{"login":"netlify","id":7892489,"avatar_url":"https://avatars1.githubusercontent.com/u/7892489?v=4","gravatar_id":"","url":"https://api.github.com/users/netlify","html_url":"https://github.com/netlify","followers_url":"https://api.github.com/users/netlify/followers","following_url":"https://api.github.com/users/netlify/following{/other_user}","gists_url":"https://api.github.com/users/netlify/gists{/gist_id}","starred_url":"https://api.github.com/users/netlify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netlify/subscriptions","organizations_url":"https://api.github.com/users/netlify/orgs","repos_url":"https://api.github.com/users/netlify/repos","events_url":"https://api.github.com/users/netlify/events{/privacy}","received_events_url":"https://api.github.com/users/netlify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netlify/gotrue","description":"An SWT based API for managing users and issuing SWT tokens","fork":false,"url":"https://api.github.com/repos/netlify/gotrue","forks_url":"https://api.github.com/repos/netlify/gotrue/forks","keys_url":"https://api.github.com/repos/netlify/gotrue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netlify/gotrue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netlify/gotrue/teams","hooks_url":"https://api.github.com/repos/netlify/gotrue/hooks","issue_events_url":"https://api.github.com/repos/netlify/gotrue/issues/events{/number}","events_url":"https://api.github.com/repos/netlify/gotrue/events","assignees_url":"https://api.github.com/repos/netlify/gotrue/assignees{/user}","branches_url":"https://api.github.com/repos/netlify/gotrue/branches{/branch}","tags_url":"https://api.github.com/repos/netlify/gotrue/tags","blobs_url":"https://api.github.com/repos/netlify/gotrue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netlify/gotrue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netlify/gotrue/git/refs{/sha}","trees_url":"https://api.github.com/repos/netlify/gotrue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netlify/gotrue/statuses/{sha}","languages_url":"https://api.github.com/repos/netlify/gotrue/languages","stargazers_url":"https://api.github.com/repos/netlify/gotrue/stargazers","contributors_url":"https://api.github.com/repos/netlify/gotrue/contributors","subscribers_url":"https://api.github.com/repos/netlify/gotrue/subscribers","subscription_url":"https://api.github.com/repos/netlify/gotrue/subscription","commits_url":"https://api.github.com/repos/netlify/gotrue/commits{/sha}","git_commits_url":"https://api.github.com/repos/netlify/gotrue/git/commits{/sha}","comments_url":"https://api.github.com/repos/netlify/gotrue/comments{/number}","issue_comment_url":"https://api.github.com/repos/netlify/gotrue/issues/comments{/number}","contents_url":"https://api.github.com/repos/netlify/gotrue/contents/{+path}","compare_url":"https://api.github.com/repos/netlify/gotrue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netlify/gotrue/merges","archive_url":"https://api.github.com/repos/netlify/gotrue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netlify/gotrue/downloads","issues_url":"https://api.github.com/repos/netlify/gotrue/issues{/number}","pulls_url":"https://api.github.com/repos/netlify/gotrue/pulls{/number}","milestones_url":"https://api.github.com/repos/netlify/gotrue/milestones{/number}","notifications_url":"https://api.github.com/repos/netlify/gotrue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netlify/gotrue/labels{/name}","releases_url":"https://api.github.com/repos/netlify/gotrue/releases{/id}","deployments_url":"https://api.github.com/repos/netlify/gotrue/deployments","created_at":"2016-05-16T23:14:24Z","updated_at":"2017-09-18T17:10:54Z","pushed_at":"2017-09-18T02:14:04Z","git_url":"git://github.com/netlify/gotrue.git","ssh_url":"[email protected]:netlify/gotrue.git","clone_url":"https://github.com/netlify/gotrue.git","svn_url":"https://github.com/netlify/gotrue","homepage":"https://www.gotrueapi.org","size":6388,"stargazers_count":172,"watchers_count":172,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":6,"forks":17,"open_issues":6,"watchers":172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netlify/gotrue/pulls/104"},"html":{"href":"https://github.com/netlify/gotrue/pull/104"},"issue":{"href":"https://api.github.com/repos/netlify/gotrue/issues/104"},"comments":{"href":"https://api.github.com/repos/netlify/gotrue/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/netlify/gotrue/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/netlify/gotrue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netlify/gotrue/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/netlify/gotrue/statuses/d8d9083dfe2ad5f92fa0b7343614b4008a5bf845"}},"author_association":"NONE"}} | {
"id": 58974323,
"name": "netlify/gotrue",
"url": "https://api.github.com/repos/netlify/gotrue"
} | {
"id": 406376,
"login": "rybit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/406376?",
"url": "https://api.github.com/users/rybit"
} | {
"id": 7892489,
"login": "netlify",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7892489?",
"url": "https://api.github.com/orgs/netlify"
} | 2017-09-18T17:51:38 | 6604994965 | {"actor":{"display_login":"rybit"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab1-addons/pulls/comments/101888864","pull_request_review_id":22634241,"id":101888864,"diff_hunk":"@@ -1,19 +1,20 @@\n # Dropbox Synchronization Service\n \n-This service will synchronize files on your openHAB server, such as configuration and log files, to and/or from your Dropbox account.\n+This service will synchronize files on the openHAB server, such as\n+configuration and log files, to and/or from a Dropbox account.\n \n-The intended main use cases are backing up openHAB configuration and log files to a version-able cloud space and transporting changed files back to openHAB after editing them with the openHAB Designer on the administrator's desktop PC.\n+The main use case is backing up openHAB configuration and log files\n+to a version-able cloud space and transporting changed files back to openHAB\n+after editing them with the openHAB Designer on the administrator's desktop PC.\n \n-> NOTE: This service is currently disabled, due to [#4588](https://github.com/openhab/openhab1-addons/issues/4588).\n \n ## Service Configuration\n \n This service can be configured in the file `services/dropbox.cfg`.\n \n | Property | Default | Required | Description |\n |----------|---------|:--------:|-------------|\n-| appkey | `gbrwwfzvrw6a9uv` | Yes due to [#4588](https://github.com/openhab/openhab1-addons/issues/4588) | the default app key is defunct and code changes are necessary. |\n-| appsecret | `gu5v7lp1f5bbs07` | Yes due to [#4588](https://github.com/openhab/openhab1-addons/issues/4588) | the default app secret is defunct and code changes are necessary. |\n+| personalAccessToken | | Yes | This is the generated access token; see instructions below |","path":"bundles/io/org.openhab.io.dropbox/README.md","position":22,"original_position":22,"commit_id":"08c47b18e667a30970c54231d132d5e0c0e30c61","original_commit_id":"08c47b18e667a30970c54231d132d5e0c0e30c61","user":{"login":"watou","id":3008217,"avatar_url":"https://avatars.githubusercontent.com/u/3008217?v=3","gravatar_id":"","url":"https://api.github.com/users/watou","html_url":"https://github.com/watou","followers_url":"https://api.github.com/users/watou/followers","following_url":"https://api.github.com/users/watou/following{/other_user}","gists_url":"https://api.github.com/users/watou/gists{/gist_id}","starred_url":"https://api.github.com/users/watou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watou/subscriptions","organizations_url":"https://api.github.com/users/watou/orgs","repos_url":"https://api.github.com/users/watou/repos","events_url":"https://api.github.com/users/watou/events{/privacy}","received_events_url":"https://api.github.com/users/watou/received_events","type":"User","site_admin":false},"body":"It's great that all that will be needed after merge is a token, without needing negotiation steps!","created_at":"2017-02-18T09:04:40Z","updated_at":"2017-02-18T09:04:59Z","html_url":"https://github.com/openhab/openhab1-addons/pull/5080#discussion_r101888864","pull_request_url":"https://api.github.com/repos/openhab/openhab1-addons/pulls/5080","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab1-addons/pulls/comments/101888864"},"html":{"href":"https://github.com/openhab/openhab1-addons/pull/5080#discussion_r101888864"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab1-addons/pulls/5080"}}},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab1-addons/pulls/5080","id":105759634,"html_url":"https://github.com/openhab/openhab1-addons/pull/5080","diff_url":"https://github.com/openhab/openhab1-addons/pull/5080.diff","patch_url":"https://github.com/openhab/openhab1-addons/pull/5080.patch","issue_url":"https://api.github.com/repos/openhab/openhab1-addons/issues/5080","number":5080,"state":"open","locked":false,"title":"[Dropbox] Enable use of generated access token","user":{"login":"9037568","id":9916473,"avatar_url":"https://avatars.githubusercontent.com/u/9916473?v=3","gravatar_id":"","url":"https://api.github.com/users/9037568","html_url":"https://github.com/9037568","followers_url":"https://api.github.com/users/9037568/followers","following_url":"https://api.github.com/users/9037568/following{/other_user}","gists_url":"https://api.github.com/users/9037568/gists{/gist_id}","starred_url":"https://api.github.com/users/9037568/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9037568/subscriptions","organizations_url":"https://api.github.com/users/9037568/orgs","repos_url":"https://api.github.com/users/9037568/repos","events_url":"https://api.github.com/users/9037568/events{/privacy}","received_events_url":"https://api.github.com/users/9037568/received_events","type":"User","site_admin":false},"body":"Allow the Dropbox IO bundle to function by using a generated access token from a user's personal app.\r\n\r\nAlso modified the updated() method to use Objects.toString().\r\nMinor changes to formatting and grammar.\r\n\r\nFixes #4588 ","created_at":"2017-02-11T17:02:40Z","updated_at":"2017-02-18T09:04:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c9b12a2fd8f1f9fc1e67a86911001ce460eeac6","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/openhab/openhab1-addons/milestones/17","html_url":"https://github.com/openhab/openhab1-addons/milestone/17","labels_url":"https://api.github.com/repos/openhab/openhab1-addons/milestones/17/labels","id":2268436,"number":17,"title":"1.9.1","description":"","creator":{"login":"watou","id":3008217,"avatar_url":"https://avatars.githubusercontent.com/u/3008217?v=3","gravatar_id":"","url":"https://api.github.com/users/watou","html_url":"https://github.com/watou","followers_url":"https://api.github.com/users/watou/followers","following_url":"https://api.github.com/users/watou/following{/other_user}","gists_url":"https://api.github.com/users/watou/gists{/gist_id}","starred_url":"https://api.github.com/users/watou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watou/subscriptions","organizations_url":"https://api.github.com/users/watou/orgs","repos_url":"https://api.github.com/users/watou/repos","events_url":"https://api.github.com/users/watou/events{/privacy}","received_events_url":"https://api.github.com/users/watou/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":9,"state":"open","created_at":"2017-01-21T05:47:32Z","updated_at":"2017-02-16T08:25:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/openhab/openhab1-addons/pulls/5080/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab1-addons/pulls/5080/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab1-addons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab1-addons/issues/5080/comments","statuses_url":"https://api.github.com/repos/openhab/openhab1-addons/statuses/08c47b18e667a30970c54231d132d5e0c0e30c61","head":{"label":"9037568:dropbox","ref":"dropbox","sha":"08c47b18e667a30970c54231d132d5e0c0e30c61","user":{"login":"9037568","id":9916473,"avatar_url":"https://avatars.githubusercontent.com/u/9916473?v=3","gravatar_id":"","url":"https://api.github.com/users/9037568","html_url":"https://github.com/9037568","followers_url":"https://api.github.com/users/9037568/followers","following_url":"https://api.github.com/users/9037568/following{/other_user}","gists_url":"https://api.github.com/users/9037568/gists{/gist_id}","starred_url":"https://api.github.com/users/9037568/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9037568/subscriptions","organizations_url":"https://api.github.com/users/9037568/orgs","repos_url":"https://api.github.com/users/9037568/repos","events_url":"https://api.github.com/users/9037568/events{/privacy}","received_events_url":"https://api.github.com/users/9037568/received_events","type":"User","site_admin":false},"repo":{"id":33285609,"name":"openhab","full_name":"9037568/openhab","owner":{"login":"9037568","id":9916473,"avatar_url":"https://avatars.githubusercontent.com/u/9916473?v=3","gravatar_id":"","url":"https://api.github.com/users/9037568","html_url":"https://github.com/9037568","followers_url":"https://api.github.com/users/9037568/followers","following_url":"https://api.github.com/users/9037568/following{/other_user}","gists_url":"https://api.github.com/users/9037568/gists{/gist_id}","starred_url":"https://api.github.com/users/9037568/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9037568/subscriptions","organizations_url":"https://api.github.com/users/9037568/orgs","repos_url":"https://api.github.com/users/9037568/repos","events_url":"https://api.github.com/users/9037568/events{/privacy}","received_events_url":"https://api.github.com/users/9037568/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/9037568/openhab","description":"Source code of the open Home Automation Bus (openHAB)","fork":true,"url":"https://api.github.com/repos/9037568/openhab","forks_url":"https://api.github.com/repos/9037568/openhab/forks","keys_url":"https://api.github.com/repos/9037568/openhab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/9037568/openhab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/9037568/openhab/teams","hooks_url":"https://api.github.com/repos/9037568/openhab/hooks","issue_events_url":"https://api.github.com/repos/9037568/openhab/issues/events{/number}","events_url":"https://api.github.com/repos/9037568/openhab/events","assignees_url":"https://api.github.com/repos/9037568/openhab/assignees{/user}","branches_url":"https://api.github.com/repos/9037568/openhab/branches{/branch}","tags_url":"https://api.github.com/repos/9037568/openhab/tags","blobs_url":"https://api.github.com/repos/9037568/openhab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/9037568/openhab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/9037568/openhab/git/refs{/sha}","trees_url":"https://api.github.com/repos/9037568/openhab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/9037568/openhab/statuses/{sha}","languages_url":"https://api.github.com/repos/9037568/openhab/languages","stargazers_url":"https://api.github.com/repos/9037568/openhab/stargazers","contributors_url":"https://api.github.com/repos/9037568/openhab/contributors","subscribers_url":"https://api.github.com/repos/9037568/openhab/subscribers","subscription_url":"https://api.github.com/repos/9037568/openhab/subscription","commits_url":"https://api.github.com/repos/9037568/openhab/commits{/sha}","git_commits_url":"https://api.github.com/repos/9037568/openhab/git/commits{/sha}","comments_url":"https://api.github.com/repos/9037568/openhab/comments{/number}","issue_comment_url":"https://api.github.com/repos/9037568/openhab/issues/comments{/number}","contents_url":"https://api.github.com/repos/9037568/openhab/contents/{+path}","compare_url":"https://api.github.com/repos/9037568/openhab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/9037568/openhab/merges","archive_url":"https://api.github.com/repos/9037568/openhab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/9037568/openhab/downloads","issues_url":"https://api.github.com/repos/9037568/openhab/issues{/number}","pulls_url":"https://api.github.com/repos/9037568/openhab/pulls{/number}","milestones_url":"https://api.github.com/repos/9037568/openhab/milestones{/number}","notifications_url":"https://api.github.com/repos/9037568/openhab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/9037568/openhab/labels{/name}","releases_url":"https://api.github.com/repos/9037568/openhab/releases{/id}","deployments_url":"https://api.github.com/repos/9037568/openhab/deployments","created_at":"2015-04-02T02:46:54Z","updated_at":"2016-01-11T05:00:45Z","pushed_at":"2017-02-18T06:57:36Z","git_url":"git://github.com/9037568/openhab.git","ssh_url":"[email protected]:9037568/openhab.git","clone_url":"https://github.com/9037568/openhab.git","svn_url":"https://github.com/9037568/openhab","homepage":null,"size":221769,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"5f47edbefb30c6023fc572e5922dc7487814755a","user":{"login":"openhab","id":1007353,"avatar_url":"https://avatars.githubusercontent.com/u/1007353?v=3","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":12983151,"name":"openhab1-addons","full_name":"openhab/openhab1-addons","owner":{"login":"openhab","id":1007353,"avatar_url":"https://avatars.githubusercontent.com/u/1007353?v=3","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openhab/openhab1-addons","description":"Add-ons for openHAB 1.x","fork":false,"url":"https://api.github.com/repos/openhab/openhab1-addons","forks_url":"https://api.github.com/repos/openhab/openhab1-addons/forks","keys_url":"https://api.github.com/repos/openhab/openhab1-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab1-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab1-addons/teams","hooks_url":"https://api.github.com/repos/openhab/openhab1-addons/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab1-addons/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab1-addons/events","assignees_url":"https://api.github.com/repos/openhab/openhab1-addons/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab1-addons/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab1-addons/tags","blobs_url":"https://api.github.com/repos/openhab/openhab1-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab1-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab1-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab1-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab1-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab1-addons/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab1-addons/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab1-addons/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab1-addons/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab1-addons/subscription","commits_url":"https://api.github.com/repos/openhab/openhab1-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab1-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab1-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab1-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab1-addons/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab1-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab1-addons/merges","archive_url":"https://api.github.com/repos/openhab/openhab1-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab1-addons/downloads","issues_url":"https://api.github.com/repos/openhab/openhab1-addons/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab1-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab1-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab1-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab1-addons/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab1-addons/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab1-addons/deployments","created_at":"2013-09-20T20:28:43Z","updated_at":"2017-02-17T11:57:14Z","pushed_at":"2017-02-18T09:02:33Z","git_url":"git://github.com/openhab/openhab1-addons.git","ssh_url":"[email protected]:openhab/openhab1-addons.git","clone_url":"https://github.com/openhab/openhab1-addons.git","svn_url":"https://github.com/openhab/openhab1-addons","homepage":"","size":222769,"stargazers_count":3421,"watchers_count":3421,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1594,"mirror_url":null,"open_issues_count":261,"forks":1594,"open_issues":261,"watchers":3421,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab1-addons/pulls/5080"},"html":{"href":"https://github.com/openhab/openhab1-addons/pull/5080"},"issue":{"href":"https://api.github.com/repos/openhab/openhab1-addons/issues/5080"},"comments":{"href":"https://api.github.com/repos/openhab/openhab1-addons/issues/5080/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab1-addons/pulls/5080/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab1-addons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab1-addons/pulls/5080/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab1-addons/statuses/08c47b18e667a30970c54231d132d5e0c0e30c61"}}}} | {
"id": 12983151,
"name": "openhab/openhab1-addons",
"url": "https://api.github.com/repos/openhab/openhab1-addons"
} | {
"id": 3008217,
"login": "watou",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3008217?",
"url": "https://api.github.com/users/watou"
} | {
"id": 1007353,
"login": "openhab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1007353?",
"url": "https://api.github.com/orgs/openhab"
} | 2017-02-18T09:04:40 | 5348791285 | {"actor":{"display_login":"watou"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/152702396","pull_request_review_id":78604503,"id":152702396,"diff_hunk":"@@ -0,0 +1,1915 @@\n+#","path":"addons/binding/org.openhab.binding.modbus/hs_err_pid5264.log","position":null,"original_position":1,"commit_id":"b3ec6e4e4ee56058589bbe8fdfed1d3df9ffcbf5","original_commit_id":"78e1cd3e5eebf33a88aa27f3d797b6bc6e840b3d","user":{"login":"ssalonen","id":315866,"avatar_url":"https://avatars1.githubusercontent.com/u/315866?v=4","gravatar_id":"","url":"https://api.github.com/users/ssalonen","html_url":"https://github.com/ssalonen","followers_url":"https://api.github.com/users/ssalonen/followers","following_url":"https://api.github.com/users/ssalonen/following{/other_user}","gists_url":"https://api.github.com/users/ssalonen/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalonen/subscriptions","organizations_url":"https://api.github.com/users/ssalonen/orgs","repos_url":"https://api.github.com/users/ssalonen/repos","events_url":"https://api.github.com/users/ssalonen/events{/privacy}","received_events_url":"https://api.github.com/users/ssalonen/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2017-11-22T23:45:04Z","updated_at":"2017-11-22T23:45:05Z","html_url":"https://github.com/openhab/openhab2-addons/pull/2246#discussion_r152702396","pull_request_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2246","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/152702396"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/2246#discussion_r152702396"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2246"}},"in_reply_to_id":150705317},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2246","id":119345837,"html_url":"https://github.com/openhab/openhab2-addons/pull/2246","diff_url":"https://github.com/openhab/openhab2-addons/pull/2246.diff","patch_url":"https://github.com/openhab/openhab2-addons/pull/2246.patch","issue_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2246","number":2246,"state":"open","locked":false,"title":"[WIP] [modbus] Modbus openhab2 native binding","user":{"login":"ssalonen","id":315866,"avatar_url":"https://avatars1.githubusercontent.com/u/315866?v=4","gravatar_id":"","url":"https://api.github.com/users/ssalonen","html_url":"https://github.com/ssalonen","followers_url":"https://api.github.com/users/ssalonen/followers","following_url":"https://api.github.com/users/ssalonen/following{/other_user}","gists_url":"https://api.github.com/users/ssalonen/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalonen/subscriptions","organizations_url":"https://api.github.com/users/ssalonen/orgs","repos_url":"https://api.github.com/users/ssalonen/repos","events_url":"https://api.github.com/users/ssalonen/events{/privacy}","received_events_url":"https://api.github.com/users/ssalonen/received_events","type":"User","site_admin":false},"body":"As discussed in #362, a new PR for native openhab2 modbus binding.\r\n\r\nUpdate 21.10.:\r\nFunctionality should be there roughly, see discussio in the community https://community.openhab.org/t/modbus-openhab2-binding-available-for-alpha-testing/27657/154","created_at":"2017-05-07T16:55:52Z","updated_at":"2017-11-22T23:45:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65697e09a67ce2c47c7014e9f145407b233269b3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2246/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2246/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2246/comments","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/b3ec6e4e4ee56058589bbe8fdfed1d3df9ffcbf5","head":{"label":"ssalonen:modbus-openhab2-native-binding","ref":"modbus-openhab2-native-binding","sha":"b3ec6e4e4ee56058589bbe8fdfed1d3df9ffcbf5","user":{"login":"ssalonen","id":315866,"avatar_url":"https://avatars1.githubusercontent.com/u/315866?v=4","gravatar_id":"","url":"https://api.github.com/users/ssalonen","html_url":"https://github.com/ssalonen","followers_url":"https://api.github.com/users/ssalonen/followers","following_url":"https://api.github.com/users/ssalonen/following{/other_user}","gists_url":"https://api.github.com/users/ssalonen/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalonen/subscriptions","organizations_url":"https://api.github.com/users/ssalonen/orgs","repos_url":"https://api.github.com/users/ssalonen/repos","events_url":"https://api.github.com/users/ssalonen/events{/privacy}","received_events_url":"https://api.github.com/users/ssalonen/received_events","type":"User","site_admin":false},"repo":{"id":88195575,"name":"openhab2-addons","full_name":"ssalonen/openhab2-addons","owner":{"login":"ssalonen","id":315866,"avatar_url":"https://avatars1.githubusercontent.com/u/315866?v=4","gravatar_id":"","url":"https://api.github.com/users/ssalonen","html_url":"https://github.com/ssalonen","followers_url":"https://api.github.com/users/ssalonen/followers","following_url":"https://api.github.com/users/ssalonen/following{/other_user}","gists_url":"https://api.github.com/users/ssalonen/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalonen/subscriptions","organizations_url":"https://api.github.com/users/ssalonen/orgs","repos_url":"https://api.github.com/users/ssalonen/repos","events_url":"https://api.github.com/users/ssalonen/events{/privacy}","received_events_url":"https://api.github.com/users/ssalonen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ssalonen/openhab2-addons","description":"Add-ons for openHAB 2.x","fork":true,"url":"https://api.github.com/repos/ssalonen/openhab2-addons","forks_url":"https://api.github.com/repos/ssalonen/openhab2-addons/forks","keys_url":"https://api.github.com/repos/ssalonen/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ssalonen/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ssalonen/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/ssalonen/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/ssalonen/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/ssalonen/openhab2-addons/events","assignees_url":"https://api.github.com/repos/ssalonen/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/ssalonen/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/ssalonen/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/ssalonen/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ssalonen/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ssalonen/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/ssalonen/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ssalonen/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/ssalonen/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/ssalonen/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/ssalonen/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/ssalonen/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/ssalonen/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/ssalonen/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/ssalonen/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/ssalonen/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/ssalonen/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/ssalonen/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/ssalonen/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ssalonen/openhab2-addons/merges","archive_url":"https://api.github.com/repos/ssalonen/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ssalonen/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/ssalonen/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/ssalonen/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/ssalonen/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/ssalonen/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ssalonen/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/ssalonen/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/ssalonen/openhab2-addons/deployments","created_at":"2017-04-13T18:39:32Z","updated_at":"2017-11-08T11:52:49Z","pushed_at":"2017-11-22T23:42:37Z","git_url":"git://github.com/ssalonen/openhab2-addons.git","ssh_url":"[email protected]:ssalonen/openhab2-addons.git","clone_url":"https://github.com/ssalonen/openhab2-addons.git","svn_url":"https://github.com/ssalonen/openhab2-addons","homepage":"","size":87822,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"eb473ea39a0e0d2eb56033462c26caf9dcf6c0a4","user":{"login":"openhab","id":1007353,"avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":19753195,"name":"openhab2-addons","full_name":"openhab/openhab2-addons","owner":{"login":"openhab","id":1007353,"avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openhab/openhab2-addons","description":"Add-ons for openHAB 2.x","fork":false,"url":"https://api.github.com/repos/openhab/openhab2-addons","forks_url":"https://api.github.com/repos/openhab/openhab2-addons/forks","keys_url":"https://api.github.com/repos/openhab/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/openhab/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab2-addons/events","assignees_url":"https://api.github.com/repos/openhab/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/openhab/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab2-addons/merges","archive_url":"https://api.github.com/repos/openhab/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/openhab/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab2-addons/deployments","created_at":"2014-05-13T19:41:58Z","updated_at":"2017-11-22T11:25:59Z","pushed_at":"2017-11-22T23:42:39Z","git_url":"git://github.com/openhab/openhab2-addons.git","ssh_url":"[email protected]:openhab/openhab2-addons.git","clone_url":"https://github.com/openhab/openhab2-addons.git","svn_url":"https://github.com/openhab/openhab2-addons","homepage":"","size":263064,"stargazers_count":678,"watchers_count":678,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1220,"mirror_url":null,"archived":false,"open_issues_count":364,"forks":1220,"open_issues":364,"watchers":678,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2246"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/2246"},"issue":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/2246"},"comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/2246/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2246/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2246/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab2-addons/statuses/b3ec6e4e4ee56058589bbe8fdfed1d3df9ffcbf5"}},"author_association":"NONE"}} | {
"id": 19753195,
"name": "openhab/openhab2-addons",
"url": "https://api.github.com/repos/openhab/openhab2-addons"
} | {
"id": 315866,
"login": "ssalonen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/315866?",
"url": "https://api.github.com/users/ssalonen"
} | {
"id": 1007353,
"login": "openhab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1007353?",
"url": "https://api.github.com/orgs/openhab"
} | 2017-11-22T23:45:04 | 6892943448 | {"actor":{"display_login":"ssalonen"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/pulls/comments/143031143","pull_request_review_id":67483038,"id":143031143,"diff_hunk":"@@ -0,0 +1,240 @@\n+/* * This Source Code Form is subject to the terms of the Mozilla Public License,\n+ * v. 2.0. If a copy of the MPL was not distributed with this file, You can\n+ * obtain one at http://mozilla.org/MPL/2.0/. OpenMRS is also distributed under\n+ * the terms of the Healthcare Disclaimer located at http://openmrs.org/license.\n+ *\n+ * Copyright (C) OpenMRS Inc. OpenMRS is a registered trademark and the OpenMRS\n+ * graphic logo is a trademark of OpenMRS Inc.\n+ */\n+package org.openmrs.module.idgen.web.controller;\n+\n+import org.apache.commons.beanutils.PropertyUtils;\n+import org.codehaus.jackson.map.ObjectMapper;\n+import org.junit.Before;\n+import org.junit.Test;\n+import org.openmrs.api.context.Context;\n+import org.openmrs.module.idgen.IdentifierPool;\n+import org.openmrs.module.idgen.RemoteIdentifierSource;\n+import org.openmrs.module.idgen.SequentialIdentifierGenerator;\n+import org.openmrs.module.idgen.service.IdentifierSourceService;\n+import org.openmrs.module.webservices.rest.SimpleObject;\n+import org.openmrs.module.webservices.rest.web.response.ResourceDoesNotSupportOperationException;\n+import org.openmrs.module.webservices.rest.web.v1_0.controller.MainResourceControllerTest;\n+import org.springframework.mock.web.MockHttpServletRequest;\n+import org.springframework.web.bind.annotation.RequestMethod;\n+\n+import static org.junit.Assert.assertEquals;\n+import static org.junit.Assert.assertNotNull;\n+import static org.junit.Assert.assertNull;\n+import static org.junit.Assert.assertTrue;\n+import static org.junit.Assert.assertFalse;\n+\n+public class IdentifierSourceRestControllerTest extends MainResourceControllerTest {\n+\t\n+ public static final String SEQUENTIAL_IDENTIFIER_SOURCE_UUID = \"0d47284f-9e9b-4a81-a88b-8bb42bc0a901\";\n+ public static final String REMOTE_IDENTIFIER_SOURCE_UUID = \"0d47284f-9e9b-4a81-a88b-8bb42bc0a902\";\n+ public static final String POOL_SOURCE_UUID = \"0d47284f-9e9b-4a81-a88b-8bb42bc0a903\";\n+ public static final String IDENTIFIER_TYPE_UUID = \"2f470aa8-1d73-43b7-81b5-01f0c0dfa53c\";\n+ public static final String IDENTIFIER_SOURCE_TO_PURGE_UUID = \"0d47284f-9e9b-4a81-a88b-8bb42bc0a999\";\n+ public static final String SEQUENTIAL_IDENTIFIER_SOURCE_TYPE = \"SequentialIdentifierGenerator\";\n+ public static final String REMOTE_IDENTIFIER_SOURCE_TYPE = \"RemoteIdentifierSource\";\n+ public static final String IDENTIFIER_POOL_SOURCE_TYPE = \"IdentifierPool\";\n+\n+ private IdentifierSourceService service;\n+\n+ @Before\n+ public void setUp() throws Exception {\n+ executeDataSet(\"org/openmrs/module/idgen/include/TestData.xml\");\n+ this.service = Context.getService(IdentifierSourceService.class);\n+ }\n+\n+ @Override\n+ public String getURI() {\n+ return \"idgen/identifiersource\";\n+ }\n+\n+ @Override\n+ public String getUuid() {\n+ return SEQUENTIAL_IDENTIFIER_SOURCE_UUID;\n+ }\n+\n+ @Override\n+ public long getAllCount() {\n+ return service.getAllIdentifierSources(false).size();\n+ }\n+\n+ @Override\n+ @Test(expected = ResourceDoesNotSupportOperationException.class)\n+ public void shouldGetAll() throws Exception {\n+ super.shouldGetAll();\n+ }\n+\n+ @Test\n+ public void shouldGetAnIdentifierSourceByUuid() throws Exception {\n+\n+ SimpleObject result = deserialize(handle(newGetRequest(getURI() + \"/\" + getUuid())));\n+ assertNotNull(result);\n+ assertEquals(getUuid(), PropertyUtils.getProperty(result, \"uuid\"));\n+\n+ }\n+\n+ @Test\n+ public void shouldEditASequentialIdentifierSource() throws Exception {\n+","path":"omod/src/test/java/org/openmrs/module/idgen/web/controller/IdentifierSourceRestControllerTest.java","position":83,"original_position":83,"commit_id":"98691b0920fbe4f283f2a73649fa25ebcfc7e449","original_commit_id":"98691b0920fbe4f283f2a73649fa25ebcfc7e449","user":{"login":"adamsdenniskariuki","id":25571987,"avatar_url":"https://avatars0.githubusercontent.com/u/25571987?v=4","gravatar_id":"","url":"https://api.github.com/users/adamsdenniskariuki","html_url":"https://github.com/adamsdenniskariuki","followers_url":"https://api.github.com/users/adamsdenniskariuki/followers","following_url":"https://api.github.com/users/adamsdenniskariuki/following{/other_user}","gists_url":"https://api.github.com/users/adamsdenniskariuki/gists{/gist_id}","starred_url":"https://api.github.com/users/adamsdenniskariuki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamsdenniskariuki/subscriptions","organizations_url":"https://api.github.com/users/adamsdenniskariuki/orgs","repos_url":"https://api.github.com/users/adamsdenniskariuki/repos","events_url":"https://api.github.com/users/adamsdenniskariuki/events{/privacy}","received_events_url":"https://api.github.com/users/adamsdenniskariuki/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2017-10-05T19:12:55Z","updated_at":"2017-10-05T19:12:55Z","html_url":"https://github.com/openmrs/openmrs-module-idgen/pull/37#discussion_r143031143","pull_request_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/pulls/37","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-module-idgen/pulls/comments/143031143"},"html":{"href":"https://github.com/openmrs/openmrs-module-idgen/pull/37#discussion_r143031143"},"pull_request":{"href":"https://api.github.com/repos/openmrs/openmrs-module-idgen/pulls/37"}},"in_reply_to_id":143030654},"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/pulls/37","id":143251469,"html_url":"https://github.com/openmrs/openmrs-module-idgen/pull/37","diff_url":"https://github.com/openmrs/openmrs-module-idgen/pull/37.diff","patch_url":"https://github.com/openmrs/openmrs-module-idgen/pull/37.patch","issue_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/issues/37","number":37,"state":"open","locked":false,"title":"IDGEN-65 Create Manage Patient Identifier Sources RESTFUL API endpoints","user":{"login":"adamsdenniskariuki","id":25571987,"avatar_url":"https://avatars0.githubusercontent.com/u/25571987?v=4","gravatar_id":"","url":"https://api.github.com/users/adamsdenniskariuki","html_url":"https://github.com/adamsdenniskariuki","followers_url":"https://api.github.com/users/adamsdenniskariuki/followers","following_url":"https://api.github.com/users/adamsdenniskariuki/following{/other_user}","gists_url":"https://api.github.com/users/adamsdenniskariuki/gists{/gist_id}","starred_url":"https://api.github.com/users/adamsdenniskariuki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamsdenniskariuki/subscriptions","organizations_url":"https://api.github.com/users/adamsdenniskariuki/orgs","repos_url":"https://api.github.com/users/adamsdenniskariuki/repos","events_url":"https://api.github.com/users/adamsdenniskariuki/events{/privacy}","received_events_url":"https://api.github.com/users/adamsdenniskariuki/received_events","type":"User","site_admin":false},"body":"## JIRA TICKET NAME:\r\n\r\n[IDGEN-65 Create Manage Patient Identifier Sources RESTFUL API endpoints](https://issues.openmrs.org/browse/IDGEN-65)\r\n\r\n## SUMMARY:\r\n\r\nCreates REST end points that will get, save, and delete patient identifier sources.","created_at":"2017-09-26T21:48:15Z","updated_at":"2017-10-05T19:12:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76d1b45b0aa7ce6160f5959e5efaf899a445fb69","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/pulls/37/commits","review_comments_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/pulls/37/comments","review_comment_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/issues/37/comments","statuses_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/statuses/98691b0920fbe4f283f2a73649fa25ebcfc7e449","head":{"label":"adamsdenniskariuki:IDGEN-65","ref":"IDGEN-65","sha":"98691b0920fbe4f283f2a73649fa25ebcfc7e449","user":{"login":"adamsdenniskariuki","id":25571987,"avatar_url":"https://avatars0.githubusercontent.com/u/25571987?v=4","gravatar_id":"","url":"https://api.github.com/users/adamsdenniskariuki","html_url":"https://github.com/adamsdenniskariuki","followers_url":"https://api.github.com/users/adamsdenniskariuki/followers","following_url":"https://api.github.com/users/adamsdenniskariuki/following{/other_user}","gists_url":"https://api.github.com/users/adamsdenniskariuki/gists{/gist_id}","starred_url":"https://api.github.com/users/adamsdenniskariuki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamsdenniskariuki/subscriptions","organizations_url":"https://api.github.com/users/adamsdenniskariuki/orgs","repos_url":"https://api.github.com/users/adamsdenniskariuki/repos","events_url":"https://api.github.com/users/adamsdenniskariuki/events{/privacy}","received_events_url":"https://api.github.com/users/adamsdenniskariuki/received_events","type":"User","site_admin":false},"repo":{"id":104917572,"name":"openmrs-module-idgen","full_name":"adamsdenniskariuki/openmrs-module-idgen","owner":{"login":"adamsdenniskariuki","id":25571987,"avatar_url":"https://avatars0.githubusercontent.com/u/25571987?v=4","gravatar_id":"","url":"https://api.github.com/users/adamsdenniskariuki","html_url":"https://github.com/adamsdenniskariuki","followers_url":"https://api.github.com/users/adamsdenniskariuki/followers","following_url":"https://api.github.com/users/adamsdenniskariuki/following{/other_user}","gists_url":"https://api.github.com/users/adamsdenniskariuki/gists{/gist_id}","starred_url":"https://api.github.com/users/adamsdenniskariuki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamsdenniskariuki/subscriptions","organizations_url":"https://api.github.com/users/adamsdenniskariuki/orgs","repos_url":"https://api.github.com/users/adamsdenniskariuki/repos","events_url":"https://api.github.com/users/adamsdenniskariuki/events{/privacy}","received_events_url":"https://api.github.com/users/adamsdenniskariuki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamsdenniskariuki/openmrs-module-idgen","description":"Provides patient identifier generation for other OpenMRS modules","fork":true,"url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen","forks_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/forks","keys_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/teams","hooks_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/hooks","issue_events_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/issues/events{/number}","events_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/events","assignees_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/assignees{/user}","branches_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/branches{/branch}","tags_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/tags","blobs_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/statuses/{sha}","languages_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/languages","stargazers_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/stargazers","contributors_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/contributors","subscribers_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/subscribers","subscription_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/subscription","commits_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/contents/{+path}","compare_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/merges","archive_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/downloads","issues_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/issues{/number}","pulls_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/pulls{/number}","milestones_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/milestones{/number}","notifications_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/labels{/name}","releases_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/releases{/id}","deployments_url":"https://api.github.com/repos/adamsdenniskariuki/openmrs-module-idgen/deployments","created_at":"2017-09-26T17:34:47Z","updated_at":"2017-09-26T17:34:48Z","pushed_at":"2017-10-05T18:57:00Z","git_url":"git://github.com/adamsdenniskariuki/openmrs-module-idgen.git","ssh_url":"[email protected]:adamsdenniskariuki/openmrs-module-idgen.git","clone_url":"https://github.com/adamsdenniskariuki/openmrs-module-idgen.git","svn_url":"https://github.com/adamsdenniskariuki/openmrs-module-idgen","homepage":null,"size":15326,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openmrs:master","ref":"master","sha":"0420a1642e2ddb131b24939de5955fa47dd950b4","user":{"login":"openmrs","id":860776,"avatar_url":"https://avatars3.githubusercontent.com/u/860776?v=4","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"repo":{"id":6946743,"name":"openmrs-module-idgen","full_name":"openmrs/openmrs-module-idgen","owner":{"login":"openmrs","id":860776,"avatar_url":"https://avatars3.githubusercontent.com/u/860776?v=4","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmrs/openmrs-module-idgen","description":"Provides patient identifier generation for other OpenMRS modules","fork":false,"url":"https://api.github.com/repos/openmrs/openmrs-module-idgen","forks_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/forks","keys_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/teams","hooks_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/hooks","issue_events_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/issues/events{/number}","events_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/events","assignees_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/assignees{/user}","branches_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/branches{/branch}","tags_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/tags","blobs_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/statuses/{sha}","languages_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/languages","stargazers_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/stargazers","contributors_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/contributors","subscribers_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/subscribers","subscription_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/subscription","commits_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/contents/{+path}","compare_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/merges","archive_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/downloads","issues_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/issues{/number}","pulls_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/pulls{/number}","milestones_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/milestones{/number}","notifications_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/labels{/name}","releases_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/releases{/id}","deployments_url":"https://api.github.com/repos/openmrs/openmrs-module-idgen/deployments","created_at":"2012-11-30T22:18:05Z","updated_at":"2016-03-16T12:01:37Z","pushed_at":"2017-10-05T18:57:03Z","git_url":"git://github.com/openmrs/openmrs-module-idgen.git","ssh_url":"[email protected]:openmrs/openmrs-module-idgen.git","clone_url":"https://github.com/openmrs/openmrs-module-idgen.git","svn_url":"https://github.com/openmrs/openmrs-module-idgen","homepage":null,"size":15315,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":3,"forks":36,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-module-idgen/pulls/37"},"html":{"href":"https://github.com/openmrs/openmrs-module-idgen/pull/37"},"issue":{"href":"https://api.github.com/repos/openmrs/openmrs-module-idgen/issues/37"},"comments":{"href":"https://api.github.com/repos/openmrs/openmrs-module-idgen/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/openmrs/openmrs-module-idgen/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/openmrs/openmrs-module-idgen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmrs/openmrs-module-idgen/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/openmrs/openmrs-module-idgen/statuses/98691b0920fbe4f283f2a73649fa25ebcfc7e449"}},"author_association":"CONTRIBUTOR"}} | {
"id": 6946743,
"name": "openmrs/openmrs-module-idgen",
"url": "https://api.github.com/repos/openmrs/openmrs-module-idgen"
} | {
"id": 25571987,
"login": "adamsdenniskariuki",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25571987?",
"url": "https://api.github.com/users/adamsdenniskariuki"
} | {
"id": 860776,
"login": "openmrs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/860776?",
"url": "https://api.github.com/orgs/openmrs"
} | 2017-10-05T19:12:55 | 6679899143 | {"actor":{"display_login":"adamsdenniskariuki"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/117792398","pull_request_review_id":39528753,"id":117792398,"diff_hunk":"@@ -693,7 +695,7 @@ Result = KEYOP_INIT_ERROR\n Function = pkey_pss_init\n Reason = invalid salt length\n \n-# ECDH tests\n+Title ECDH tests","path":"test/evppkey.txt","position":30,"original_position":30,"commit_id":"d47957591991d89de0640c445736452f07fb2594","original_commit_id":"d47957591991d89de0640c445736452f07fb2594","user":{"login":"richsalz","id":7332500,"avatar_url":"https://avatars3.githubusercontent.com/u/7332500?v=3","gravatar_id":"","url":"https://api.github.com/users/richsalz","html_url":"https://github.com/richsalz","followers_url":"https://api.github.com/users/richsalz/followers","following_url":"https://api.github.com/users/richsalz/following{/other_user}","gists_url":"https://api.github.com/users/richsalz/gists{/gist_id}","starred_url":"https://api.github.com/users/richsalz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richsalz/subscriptions","organizations_url":"https://api.github.com/users/richsalz/orgs","repos_url":"https://api.github.com/users/richsalz/repos","events_url":"https://api.github.com/users/richsalz/events{/privacy}","received_events_url":"https://api.github.com/users/richsalz/received_events","type":"User","site_admin":false},"body":"right. that's a puzzle. looking at it.","created_at":"2017-05-22T16:43:35Z","updated_at":"2017-05-22T16:43:35Z","html_url":"https://github.com/openssl/openssl/pull/3506#discussion_r117792398","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/3506","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/117792398"},"html":{"href":"https://github.com/openssl/openssl/pull/3506#discussion_r117792398"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/3506"}}},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/3506","id":121641655,"html_url":"https://github.com/openssl/openssl/pull/3506","diff_url":"https://github.com/openssl/openssl/pull/3506.diff","patch_url":"https://github.com/openssl/openssl/pull/3506.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/3506","number":3506,"state":"open","locked":false,"title":"Evp parser tweak","user":{"login":"richsalz","id":7332500,"avatar_url":"https://avatars3.githubusercontent.com/u/7332500?v=3","gravatar_id":"","url":"https://api.github.com/users/richsalz","html_url":"https://github.com/richsalz","followers_url":"https://api.github.com/users/richsalz/followers","following_url":"https://api.github.com/users/richsalz/following{/other_user}","gists_url":"https://api.github.com/users/richsalz/gists{/gist_id}","starred_url":"https://api.github.com/users/richsalz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richsalz/subscriptions","organizations_url":"https://api.github.com/users/richsalz/orgs","repos_url":"https://api.github.com/users/richsalz/repos","events_url":"https://api.github.com/users/richsalz/events{/privacy}","received_events_url":"https://api.github.com/users/richsalz/received_events","type":"User","site_admin":false},"body":"This is the evp_test part of #3471. It moves the parsing to be more similar to bn_test. I hope my text PR in this area will refactor out common code.","created_at":"2017-05-20T23:17:47Z","updated_at":"2017-05-22T16:43:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"555630dde2710bf747f2833a12a7ba9b2a93c742","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/3506/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/3506/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/3506/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/d47957591991d89de0640c445736452f07fb2594","head":{"label":"richsalz:evp-parser-tweak","ref":"evp-parser-tweak","sha":"d47957591991d89de0640c445736452f07fb2594","user":{"login":"richsalz","id":7332500,"avatar_url":"https://avatars3.githubusercontent.com/u/7332500?v=3","gravatar_id":"","url":"https://api.github.com/users/richsalz","html_url":"https://github.com/richsalz","followers_url":"https://api.github.com/users/richsalz/followers","following_url":"https://api.github.com/users/richsalz/following{/other_user}","gists_url":"https://api.github.com/users/richsalz/gists{/gist_id}","starred_url":"https://api.github.com/users/richsalz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richsalz/subscriptions","organizations_url":"https://api.github.com/users/richsalz/orgs","repos_url":"https://api.github.com/users/richsalz/repos","events_url":"https://api.github.com/users/richsalz/events{/privacy}","received_events_url":"https://api.github.com/users/richsalz/received_events","type":"User","site_admin":false},"repo":{"id":44908226,"name":"openssl","full_name":"richsalz/openssl","owner":{"login":"richsalz","id":7332500,"avatar_url":"https://avatars3.githubusercontent.com/u/7332500?v=3","gravatar_id":"","url":"https://api.github.com/users/richsalz","html_url":"https://github.com/richsalz","followers_url":"https://api.github.com/users/richsalz/followers","following_url":"https://api.github.com/users/richsalz/following{/other_user}","gists_url":"https://api.github.com/users/richsalz/gists{/gist_id}","starred_url":"https://api.github.com/users/richsalz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richsalz/subscriptions","organizations_url":"https://api.github.com/users/richsalz/orgs","repos_url":"https://api.github.com/users/richsalz/repos","events_url":"https://api.github.com/users/richsalz/events{/privacy}","received_events_url":"https://api.github.com/users/richsalz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richsalz/openssl","description":null,"fork":true,"url":"https://api.github.com/repos/richsalz/openssl","forks_url":"https://api.github.com/repos/richsalz/openssl/forks","keys_url":"https://api.github.com/repos/richsalz/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richsalz/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richsalz/openssl/teams","hooks_url":"https://api.github.com/repos/richsalz/openssl/hooks","issue_events_url":"https://api.github.com/repos/richsalz/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/richsalz/openssl/events","assignees_url":"https://api.github.com/repos/richsalz/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/richsalz/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/richsalz/openssl/tags","blobs_url":"https://api.github.com/repos/richsalz/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richsalz/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richsalz/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/richsalz/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richsalz/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/richsalz/openssl/languages","stargazers_url":"https://api.github.com/repos/richsalz/openssl/stargazers","contributors_url":"https://api.github.com/repos/richsalz/openssl/contributors","subscribers_url":"https://api.github.com/repos/richsalz/openssl/subscribers","subscription_url":"https://api.github.com/repos/richsalz/openssl/subscription","commits_url":"https://api.github.com/repos/richsalz/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/richsalz/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/richsalz/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/richsalz/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/richsalz/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/richsalz/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richsalz/openssl/merges","archive_url":"https://api.github.com/repos/richsalz/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richsalz/openssl/downloads","issues_url":"https://api.github.com/repos/richsalz/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/richsalz/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/richsalz/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/richsalz/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richsalz/openssl/labels{/name}","releases_url":"https://api.github.com/repos/richsalz/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/richsalz/openssl/deployments","created_at":"2015-10-25T12:01:24Z","updated_at":"2017-01-13T13:28:54Z","pushed_at":"2017-05-22T13:38:56Z","git_url":"git://github.com/richsalz/openssl.git","ssh_url":"[email protected]:richsalz/openssl.git","clone_url":"https://github.com/richsalz/openssl.git","svn_url":"https://github.com/richsalz/openssl","homepage":null,"size":113215,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"7ac5b84ea7920343f5c69247251bbc84ac259b2b","user":{"login":"openssl","id":3279138,"avatar_url":"https://avatars1.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"avatar_url":"https://avatars1.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2017-05-22T16:20:44Z","pushed_at":"2017-05-22T16:39:31Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"[email protected]:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":117419,"stargazers_count":4725,"watchers_count":4725,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2444,"mirror_url":null,"open_issues_count":398,"forks":2444,"open_issues":398,"watchers":4725,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/3506"},"html":{"href":"https://github.com/openssl/openssl/pull/3506"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/3506"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/3506/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/3506/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/3506/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/d47957591991d89de0640c445736452f07fb2594"}}}} | {
"id": 7634677,
"name": "openssl/openssl",
"url": "https://api.github.com/repos/openssl/openssl"
} | {
"id": 7332500,
"login": "richsalz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7332500?",
"url": "https://api.github.com/users/richsalz"
} | {
"id": 3279138,
"login": "openssl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3279138?",
"url": "https://api.github.com/orgs/openssl"
} | 2017-05-22T16:43:35 | 5919050225 | {"actor":{"display_login":"richsalz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openucx/ucx/pulls/comments/111198674","pull_request_review_id":32427328,"id":111198674,"diff_hunk":"@@ -437,6 +437,19 @@ enum {\n \n \n /**\n+ * @ingroup UCT_RESOURCE\n+ * @brief @anchor UCT_FLUSH_FLAGS Flags that control completion semantic.\n+ */\n+enum {\n+ UCT_FLUSH_FLAG_LOCAL = 0, /**< Guarantees flush of local\n+ outstanding operations */","path":"src/uct/api/uct.h","position":9,"original_position":9,"commit_id":"513e6b46fc996fefc24cd6e618e68a0cc91b2055","original_commit_id":"513e6b46fc996fefc24cd6e618e68a0cc91b2055","user":{"login":"shamisp","id":2236120,"avatar_url":"https://avatars1.githubusercontent.com/u/2236120?v=3","gravatar_id":"","url":"https://api.github.com/users/shamisp","html_url":"https://github.com/shamisp","followers_url":"https://api.github.com/users/shamisp/followers","following_url":"https://api.github.com/users/shamisp/following{/other_user}","gists_url":"https://api.github.com/users/shamisp/gists{/gist_id}","starred_url":"https://api.github.com/users/shamisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamisp/subscriptions","organizations_url":"https://api.github.com/users/shamisp/orgs","repos_url":"https://api.github.com/users/shamisp/repos","events_url":"https://api.github.com/users/shamisp/events{/privacy}","received_events_url":"https://api.github.com/users/shamisp/received_events","type":"User","site_admin":false},"body":"What is local , what is remote , etc. It has to be defined","created_at":"2017-04-12T16:30:56Z","updated_at":"2017-04-12T16:30:56Z","html_url":"https://github.com/openucx/ucx/pull/1432#discussion_r111198674","pull_request_url":"https://api.github.com/repos/openucx/ucx/pulls/1432","_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments/111198674"},"html":{"href":"https://github.com/openucx/ucx/pull/1432#discussion_r111198674"},"pull_request":{"href":"https://api.github.com/repos/openucx/ucx/pulls/1432"}}},"pull_request":{"url":"https://api.github.com/repos/openucx/ucx/pulls/1432","id":115581515,"html_url":"https://github.com/openucx/ucx/pull/1432","diff_url":"https://github.com/openucx/ucx/pull/1432.diff","patch_url":"https://github.com/openucx/ucx/pull/1432.patch","issue_url":"https://api.github.com/repos/openucx/ucx/issues/1432","number":1432,"state":"open","locked":false,"title":"UCP/UCT/API: UCP error handling","user":{"login":"evgeny-leksikov","id":15216359,"avatar_url":"https://avatars0.githubusercontent.com/u/15216359?v=3","gravatar_id":"","url":"https://api.github.com/users/evgeny-leksikov","html_url":"https://github.com/evgeny-leksikov","followers_url":"https://api.github.com/users/evgeny-leksikov/followers","following_url":"https://api.github.com/users/evgeny-leksikov/following{/other_user}","gists_url":"https://api.github.com/users/evgeny-leksikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeny-leksikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeny-leksikov/subscriptions","organizations_url":"https://api.github.com/users/evgeny-leksikov/orgs","repos_url":"https://api.github.com/users/evgeny-leksikov/repos","events_url":"https://api.github.com/users/evgeny-leksikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgeny-leksikov/received_events","type":"User","site_admin":false},"body":"Add new UCP_FEATURE_FAULT_TOLERANCE flag\r\nDisable ucp_tag_send_sync_nb if UCP_FEATURE_FAULT_TOLERANCE flag is requested\r\nAdd test test_ucp_error_handling.disable_sync_send\r\nAdd new UCT flush extention API","created_at":"2017-04-12T16:20:15Z","updated_at":"2017-04-12T16:30:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f27849901b04492eed61d05bd1a2ff9d873a92b7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openucx/ucx/pulls/1432/commits","review_comments_url":"https://api.github.com/repos/openucx/ucx/pulls/1432/comments","review_comment_url":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openucx/ucx/issues/1432/comments","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/513e6b46fc996fefc24cd6e618e68a0cc91b2055","head":{"label":"evgeny-leksikov:err_api","ref":"err_api","sha":"513e6b46fc996fefc24cd6e618e68a0cc91b2055","user":{"login":"evgeny-leksikov","id":15216359,"avatar_url":"https://avatars0.githubusercontent.com/u/15216359?v=3","gravatar_id":"","url":"https://api.github.com/users/evgeny-leksikov","html_url":"https://github.com/evgeny-leksikov","followers_url":"https://api.github.com/users/evgeny-leksikov/followers","following_url":"https://api.github.com/users/evgeny-leksikov/following{/other_user}","gists_url":"https://api.github.com/users/evgeny-leksikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeny-leksikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeny-leksikov/subscriptions","organizations_url":"https://api.github.com/users/evgeny-leksikov/orgs","repos_url":"https://api.github.com/users/evgeny-leksikov/repos","events_url":"https://api.github.com/users/evgeny-leksikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgeny-leksikov/received_events","type":"User","site_admin":false},"repo":{"id":77319416,"name":"ucx","full_name":"evgeny-leksikov/ucx","owner":{"login":"evgeny-leksikov","id":15216359,"avatar_url":"https://avatars0.githubusercontent.com/u/15216359?v=3","gravatar_id":"","url":"https://api.github.com/users/evgeny-leksikov","html_url":"https://github.com/evgeny-leksikov","followers_url":"https://api.github.com/users/evgeny-leksikov/followers","following_url":"https://api.github.com/users/evgeny-leksikov/following{/other_user}","gists_url":"https://api.github.com/users/evgeny-leksikov/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeny-leksikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeny-leksikov/subscriptions","organizations_url":"https://api.github.com/users/evgeny-leksikov/orgs","repos_url":"https://api.github.com/users/evgeny-leksikov/repos","events_url":"https://api.github.com/users/evgeny-leksikov/events{/privacy}","received_events_url":"https://api.github.com/users/evgeny-leksikov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evgeny-leksikov/ucx","description":"Unified Communication X (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":true,"url":"https://api.github.com/repos/evgeny-leksikov/ucx","forks_url":"https://api.github.com/repos/evgeny-leksikov/ucx/forks","keys_url":"https://api.github.com/repos/evgeny-leksikov/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evgeny-leksikov/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evgeny-leksikov/ucx/teams","hooks_url":"https://api.github.com/repos/evgeny-leksikov/ucx/hooks","issue_events_url":"https://api.github.com/repos/evgeny-leksikov/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/evgeny-leksikov/ucx/events","assignees_url":"https://api.github.com/repos/evgeny-leksikov/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/evgeny-leksikov/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/evgeny-leksikov/ucx/tags","blobs_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evgeny-leksikov/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/evgeny-leksikov/ucx/languages","stargazers_url":"https://api.github.com/repos/evgeny-leksikov/ucx/stargazers","contributors_url":"https://api.github.com/repos/evgeny-leksikov/ucx/contributors","subscribers_url":"https://api.github.com/repos/evgeny-leksikov/ucx/subscribers","subscription_url":"https://api.github.com/repos/evgeny-leksikov/ucx/subscription","commits_url":"https://api.github.com/repos/evgeny-leksikov/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/evgeny-leksikov/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/evgeny-leksikov/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/evgeny-leksikov/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/evgeny-leksikov/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/evgeny-leksikov/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evgeny-leksikov/ucx/merges","archive_url":"https://api.github.com/repos/evgeny-leksikov/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evgeny-leksikov/ucx/downloads","issues_url":"https://api.github.com/repos/evgeny-leksikov/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/evgeny-leksikov/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/evgeny-leksikov/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/evgeny-leksikov/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evgeny-leksikov/ucx/labels{/name}","releases_url":"https://api.github.com/repos/evgeny-leksikov/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/evgeny-leksikov/ucx/deployments","created_at":"2016-12-25T09:34:08Z","updated_at":"2016-12-25T09:34:12Z","pushed_at":"2017-04-12T16:18:35Z","git_url":"git://github.com/evgeny-leksikov/ucx.git","ssh_url":"[email protected]:evgeny-leksikov/ucx.git","clone_url":"https://github.com/evgeny-leksikov/ucx.git","svn_url":"https://github.com/evgeny-leksikov/ucx","homepage":"http://www.openucx.org","size":7728,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openucx:master","ref":"master","sha":"8a125e2f14c3ac5dd9b7aa432673a6e6c77a3f4a","user":{"login":"openucx","id":13118737,"avatar_url":"https://avatars1.githubusercontent.com/u/13118737?v=3","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"repo":{"id":25379390,"name":"ucx","full_name":"openucx/ucx","owner":{"login":"openucx","id":13118737,"avatar_url":"https://avatars1.githubusercontent.com/u/13118737?v=3","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openucx/ucx","description":"Unified Communication X (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":false,"url":"https://api.github.com/repos/openucx/ucx","forks_url":"https://api.github.com/repos/openucx/ucx/forks","keys_url":"https://api.github.com/repos/openucx/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openucx/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openucx/ucx/teams","hooks_url":"https://api.github.com/repos/openucx/ucx/hooks","issue_events_url":"https://api.github.com/repos/openucx/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/openucx/ucx/events","assignees_url":"https://api.github.com/repos/openucx/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/openucx/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/openucx/ucx/tags","blobs_url":"https://api.github.com/repos/openucx/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openucx/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openucx/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/openucx/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/openucx/ucx/languages","stargazers_url":"https://api.github.com/repos/openucx/ucx/stargazers","contributors_url":"https://api.github.com/repos/openucx/ucx/contributors","subscribers_url":"https://api.github.com/repos/openucx/ucx/subscribers","subscription_url":"https://api.github.com/repos/openucx/ucx/subscription","commits_url":"https://api.github.com/repos/openucx/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/openucx/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/openucx/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/openucx/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/openucx/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/openucx/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openucx/ucx/merges","archive_url":"https://api.github.com/repos/openucx/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openucx/ucx/downloads","issues_url":"https://api.github.com/repos/openucx/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/openucx/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/openucx/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/openucx/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openucx/ucx/labels{/name}","releases_url":"https://api.github.com/repos/openucx/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/openucx/ucx/deployments","created_at":"2014-10-17T22:17:24Z","updated_at":"2017-04-12T13:35:55Z","pushed_at":"2017-04-12T16:30:49Z","git_url":"git://github.com/openucx/ucx.git","ssh_url":"[email protected]:openucx/ucx.git","clone_url":"https://github.com/openucx/ucx.git","svn_url":"https://github.com/openucx/ucx","homepage":"http://www.openucx.org","size":7876,"stargazers_count":55,"watchers_count":55,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":49,"mirror_url":null,"open_issues_count":96,"forks":49,"open_issues":96,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/1432"},"html":{"href":"https://github.com/openucx/ucx/pull/1432"},"issue":{"href":"https://api.github.com/repos/openucx/ucx/issues/1432"},"comments":{"href":"https://api.github.com/repos/openucx/ucx/issues/1432/comments"},"review_comments":{"href":"https://api.github.com/repos/openucx/ucx/pulls/1432/comments"},"review_comment":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openucx/ucx/pulls/1432/commits"},"statuses":{"href":"https://api.github.com/repos/openucx/ucx/statuses/513e6b46fc996fefc24cd6e618e68a0cc91b2055"}}}} | {
"id": 25379390,
"name": "openucx/ucx",
"url": "https://api.github.com/repos/openucx/ucx"
} | {
"id": 2236120,
"login": "shamisp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2236120?",
"url": "https://api.github.com/users/shamisp"
} | {
"id": 13118737,
"login": "openucx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13118737?",
"url": "https://api.github.com/orgs/openucx"
} | 2017-04-12T16:30:56 | 5677358649 | {"actor":{"display_login":"shamisp"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/otwcode/otwarchive/pulls/comments/94831635","pull_request_review_id":15371365,"id":94831635,"diff_hunk":"@@ -0,0 +1,144 @@\n+require 'spec_helper'\n+\n+describe WorkQuery do\n+\n+ it \"should allow you to perform a simple search\" do\n+ q = WorkQuery.new(query: \"unicorns\")\n+ search_body = q.generated_query\n+ expect(search_body[:query][:filtered][:query][:bool][:must]).to eq([{:query_string=>{:query=>\"unicorns\"}}])\n+ end\n+\n+ it \"should never return drafts\" do\n+ q = WorkQuery.new\n+ expect(q.filters).to include({term: { posted: 'T'} })\n+ end\n+\n+ it \"should never return hidden works\" do\n+ q = WorkQuery.new\n+ expect(q.filters).to include({term: { hidden_by_admin: 'F'} })\n+ end\n+\n+ it \"should not return unrevealed works by default\" do\n+ q = WorkQuery.new\n+ expect(q.filters).to include({term: { in_unrevealed_collection: 'F'} })\n+ end\n+\n+ it \"should return unrevealed works when filtering by a collection\" do\n+ q = WorkQuery.new(works_parent: Collection.new)\n+ expect(q.filters).not_to include({term: { in_unrevealed_collection: 'F'} })\n+ end\n+\n+ it \"should not return restricted works by default\" do\n+ q = WorkQuery.new\n+ expect(q.filters).to include({term: { restricted: 'F'} })\n+ end\n+\n+ it \"should only return restricted works when a user is logged in\" do\n+ User.current_user = User.new\n+ q = WorkQuery.new\n+ expect(q.filters).not_to include({term: { restricted: 'F'} })\n+ end\n+\n+ it \"should not return anonymous works when filtering by a pseud\" do\n+ q = WorkQuery.new(works_parent: Pseud.new)\n+ expect(q.filters).to include({term: { in_anon_collection: 'F'} })\n+ end\n+\n+ it \"should not return anonymous works when filtering by a user\" do\n+ q = WorkQuery.new(works_parent: User.new)\n+ expect(q.filters).to include({term: { in_anon_collection: 'F'} })\n+ end\n+\n+ it \"should allow you to filter for complete works\" do\n+ q = WorkQuery.new(complete: true)\n+ expect(q.filters).to include({term: { complete: 'T'} })\n+ end\n+\n+ it \"should allow you to filter for works by tag\" do\n+ tag = Tag.new\n+ tag.id = 1\n+ q = WorkQuery.new(works_parent: tag)\n+ expect(q.filters).to include({terms: { execution: 'and', filter_ids: [1]} })\n+ end\n+\n+ it \"should allow you to filter for works by collection\" do\n+ collection = Collection.new\n+ collection.id = 5\n+ q = WorkQuery.new(works_parent: collection)\n+ expect(q.filters).to include({terms: { collection_ids: [5]} })\n+ end\n+\n+ it \"should allow you to filter for works by pseud\" do\n+ pseud = Pseud.new\n+ pseud.id = 42\n+ q = WorkQuery.new(works_parent: pseud, pseud_ids: [3])\n+ expect(q.filters).to include({terms: { pseud_ids: [3, 42]} })\n+ end\n+\n+ it \"should allow you to filter for works by user\" do\n+ user = User.new\n+ user.id = 2\n+ q = WorkQuery.new(works_parent: user)\n+ expect(q.filters).to include({terms: { user_ids: [2]} })\n+ end\n+\n+ it \"should allow you to filter for works by tag ids\" do\n+ tag = Tag.new\n+ tag.id = 6\n+ q = WorkQuery.new(filter_ids: [6])\n+ expect(q.filters).to include({terms: { execution: 'and', filter_ids: [6]} })\n+ end\n+\n+ it \"should allow you to exclude works by tag ids\" do\n+ tag = FactoryGirl.create(:tag, name: \"foobar\", id: 6, canonical: true, type: 'Freeform')","path":"spec/models/work_query_spec.rb","position":93,"original_position":93,"commit_id":"cbef2aebc3a6689e25af70adf7ab9363cd7c0be8","original_commit_id":"cbef2aebc3a6689e25af70adf7ab9363cd7c0be8","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Useless assignment to variable - tag.","created_at":"2017-01-05T19:14:41Z","updated_at":"2017-01-05T19:14:41Z","html_url":"https://github.com/otwcode/otwarchive/pull/2700#discussion_r94831635","pull_request_url":"https://api.github.com/repos/otwcode/otwarchive/pulls/2700","_links":{"self":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/comments/94831635"},"html":{"href":"https://github.com/otwcode/otwarchive/pull/2700#discussion_r94831635"},"pull_request":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/2700"}}},"pull_request":{"url":"https://api.github.com/repos/otwcode/otwarchive/pulls/2700","id":100346549,"html_url":"https://github.com/otwcode/otwarchive/pull/2700","diff_url":"https://github.com/otwcode/otwarchive/pull/2700.diff","patch_url":"https://github.com/otwcode/otwarchive/pull/2700.patch","issue_url":"https://api.github.com/repos/otwcode/otwarchive/issues/2700","number":2700,"state":"open","locked":false,"title":"Elasticsearch overhaul","user":{"login":"sarken","id":907055,"avatar_url":"https://avatars.githubusercontent.com/u/907055?v=3","gravatar_id":"","url":"https://api.github.com/users/sarken","html_url":"https://github.com/sarken","followers_url":"https://api.github.com/users/sarken/followers","following_url":"https://api.github.com/users/sarken/following{/other_user}","gists_url":"https://api.github.com/users/sarken/gists{/gist_id}","starred_url":"https://api.github.com/users/sarken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarken/subscriptions","organizations_url":"https://api.github.com/users/sarken/orgs","repos_url":"https://api.github.com/users/sarken/repos","events_url":"https://api.github.com/users/sarken/events{/privacy}","received_events_url":"https://api.github.com/users/sarken/received_events","type":"User","site_admin":false},"body":"not ready, just here so we can find out what needs doing, will edit description when I'm at a computer and can find more details","created_at":"2017-01-05T19:14:15Z","updated_at":"2017-01-05T19:14:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fd533bb842d7511be510a52d0cf66f3e1b10f83","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/otwcode/otwarchive/pulls/2700/commits","review_comments_url":"https://api.github.com/repos/otwcode/otwarchive/pulls/2700/comments","review_comment_url":"https://api.github.com/repos/otwcode/otwarchive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/otwcode/otwarchive/issues/2700/comments","statuses_url":"https://api.github.com/repos/otwcode/otwarchive/statuses/cbef2aebc3a6689e25af70adf7ab9363cd7c0be8","head":{"label":"sarken:elasticsearch_overhaul_newer","ref":"elasticsearch_overhaul_newer","sha":"cbef2aebc3a6689e25af70adf7ab9363cd7c0be8","user":{"login":"sarken","id":907055,"avatar_url":"https://avatars.githubusercontent.com/u/907055?v=3","gravatar_id":"","url":"https://api.github.com/users/sarken","html_url":"https://github.com/sarken","followers_url":"https://api.github.com/users/sarken/followers","following_url":"https://api.github.com/users/sarken/following{/other_user}","gists_url":"https://api.github.com/users/sarken/gists{/gist_id}","starred_url":"https://api.github.com/users/sarken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarken/subscriptions","organizations_url":"https://api.github.com/users/sarken/orgs","repos_url":"https://api.github.com/users/sarken/repos","events_url":"https://api.github.com/users/sarken/events{/privacy}","received_events_url":"https://api.github.com/users/sarken/received_events","type":"User","site_admin":false},"repo":{"id":2028681,"name":"otwarchive","full_name":"sarken/otwarchive","owner":{"login":"sarken","id":907055,"avatar_url":"https://avatars.githubusercontent.com/u/907055?v=3","gravatar_id":"","url":"https://api.github.com/users/sarken","html_url":"https://github.com/sarken","followers_url":"https://api.github.com/users/sarken/followers","following_url":"https://api.github.com/users/sarken/following{/other_user}","gists_url":"https://api.github.com/users/sarken/gists{/gist_id}","starred_url":"https://api.github.com/users/sarken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarken/subscriptions","organizations_url":"https://api.github.com/users/sarken/orgs","repos_url":"https://api.github.com/users/sarken/repos","events_url":"https://api.github.com/users/sarken/events{/privacy}","received_events_url":"https://api.github.com/users/sarken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sarken/otwarchive","description":"The Organization for Transformative Works - Archive Project","fork":true,"url":"https://api.github.com/repos/sarken/otwarchive","forks_url":"https://api.github.com/repos/sarken/otwarchive/forks","keys_url":"https://api.github.com/repos/sarken/otwarchive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarken/otwarchive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarken/otwarchive/teams","hooks_url":"https://api.github.com/repos/sarken/otwarchive/hooks","issue_events_url":"https://api.github.com/repos/sarken/otwarchive/issues/events{/number}","events_url":"https://api.github.com/repos/sarken/otwarchive/events","assignees_url":"https://api.github.com/repos/sarken/otwarchive/assignees{/user}","branches_url":"https://api.github.com/repos/sarken/otwarchive/branches{/branch}","tags_url":"https://api.github.com/repos/sarken/otwarchive/tags","blobs_url":"https://api.github.com/repos/sarken/otwarchive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarken/otwarchive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarken/otwarchive/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarken/otwarchive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarken/otwarchive/statuses/{sha}","languages_url":"https://api.github.com/repos/sarken/otwarchive/languages","stargazers_url":"https://api.github.com/repos/sarken/otwarchive/stargazers","contributors_url":"https://api.github.com/repos/sarken/otwarchive/contributors","subscribers_url":"https://api.github.com/repos/sarken/otwarchive/subscribers","subscription_url":"https://api.github.com/repos/sarken/otwarchive/subscription","commits_url":"https://api.github.com/repos/sarken/otwarchive/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarken/otwarchive/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarken/otwarchive/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarken/otwarchive/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarken/otwarchive/contents/{+path}","compare_url":"https://api.github.com/repos/sarken/otwarchive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarken/otwarchive/merges","archive_url":"https://api.github.com/repos/sarken/otwarchive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarken/otwarchive/downloads","issues_url":"https://api.github.com/repos/sarken/otwarchive/issues{/number}","pulls_url":"https://api.github.com/repos/sarken/otwarchive/pulls{/number}","milestones_url":"https://api.github.com/repos/sarken/otwarchive/milestones{/number}","notifications_url":"https://api.github.com/repos/sarken/otwarchive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarken/otwarchive/labels{/name}","releases_url":"https://api.github.com/repos/sarken/otwarchive/releases{/id}","deployments_url":"https://api.github.com/repos/sarken/otwarchive/deployments","created_at":"2011-07-11T05:42:20Z","updated_at":"2016-08-21T02:59:41Z","pushed_at":"2017-01-04T07:41:42Z","git_url":"git://github.com/sarken/otwarchive.git","ssh_url":"[email protected]:sarken/otwarchive.git","clone_url":"https://github.com/sarken/otwarchive.git","svn_url":"https://github.com/sarken/otwarchive","homepage":"http://transformativeworks.org/projects/archive","size":52335,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"otwcode:master","ref":"master","sha":"0ffcfbd4e9e5bb24b97eb970fbe087e01443837e","user":{"login":"otwcode","id":408606,"avatar_url":"https://avatars.githubusercontent.com/u/408606?v=3","gravatar_id":"","url":"https://api.github.com/users/otwcode","html_url":"https://github.com/otwcode","followers_url":"https://api.github.com/users/otwcode/followers","following_url":"https://api.github.com/users/otwcode/following{/other_user}","gists_url":"https://api.github.com/users/otwcode/gists{/gist_id}","starred_url":"https://api.github.com/users/otwcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otwcode/subscriptions","organizations_url":"https://api.github.com/users/otwcode/orgs","repos_url":"https://api.github.com/users/otwcode/repos","events_url":"https://api.github.com/users/otwcode/events{/privacy}","received_events_url":"https://api.github.com/users/otwcode/received_events","type":"Organization","site_admin":false},"repo":{"id":1338040,"name":"otwarchive","full_name":"otwcode/otwarchive","owner":{"login":"otwcode","id":408606,"avatar_url":"https://avatars.githubusercontent.com/u/408606?v=3","gravatar_id":"","url":"https://api.github.com/users/otwcode","html_url":"https://github.com/otwcode","followers_url":"https://api.github.com/users/otwcode/followers","following_url":"https://api.github.com/users/otwcode/following{/other_user}","gists_url":"https://api.github.com/users/otwcode/gists{/gist_id}","starred_url":"https://api.github.com/users/otwcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otwcode/subscriptions","organizations_url":"https://api.github.com/users/otwcode/orgs","repos_url":"https://api.github.com/users/otwcode/repos","events_url":"https://api.github.com/users/otwcode/events{/privacy}","received_events_url":"https://api.github.com/users/otwcode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/otwcode/otwarchive","description":"The Organization for Transformative Works (OTW) - Archive Of Our Own (AO3) Project","fork":false,"url":"https://api.github.com/repos/otwcode/otwarchive","forks_url":"https://api.github.com/repos/otwcode/otwarchive/forks","keys_url":"https://api.github.com/repos/otwcode/otwarchive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otwcode/otwarchive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otwcode/otwarchive/teams","hooks_url":"https://api.github.com/repos/otwcode/otwarchive/hooks","issue_events_url":"https://api.github.com/repos/otwcode/otwarchive/issues/events{/number}","events_url":"https://api.github.com/repos/otwcode/otwarchive/events","assignees_url":"https://api.github.com/repos/otwcode/otwarchive/assignees{/user}","branches_url":"https://api.github.com/repos/otwcode/otwarchive/branches{/branch}","tags_url":"https://api.github.com/repos/otwcode/otwarchive/tags","blobs_url":"https://api.github.com/repos/otwcode/otwarchive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otwcode/otwarchive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otwcode/otwarchive/git/refs{/sha}","trees_url":"https://api.github.com/repos/otwcode/otwarchive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otwcode/otwarchive/statuses/{sha}","languages_url":"https://api.github.com/repos/otwcode/otwarchive/languages","stargazers_url":"https://api.github.com/repos/otwcode/otwarchive/stargazers","contributors_url":"https://api.github.com/repos/otwcode/otwarchive/contributors","subscribers_url":"https://api.github.com/repos/otwcode/otwarchive/subscribers","subscription_url":"https://api.github.com/repos/otwcode/otwarchive/subscription","commits_url":"https://api.github.com/repos/otwcode/otwarchive/commits{/sha}","git_commits_url":"https://api.github.com/repos/otwcode/otwarchive/git/commits{/sha}","comments_url":"https://api.github.com/repos/otwcode/otwarchive/comments{/number}","issue_comment_url":"https://api.github.com/repos/otwcode/otwarchive/issues/comments{/number}","contents_url":"https://api.github.com/repos/otwcode/otwarchive/contents/{+path}","compare_url":"https://api.github.com/repos/otwcode/otwarchive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otwcode/otwarchive/merges","archive_url":"https://api.github.com/repos/otwcode/otwarchive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otwcode/otwarchive/downloads","issues_url":"https://api.github.com/repos/otwcode/otwarchive/issues{/number}","pulls_url":"https://api.github.com/repos/otwcode/otwarchive/pulls{/number}","milestones_url":"https://api.github.com/repos/otwcode/otwarchive/milestones{/number}","notifications_url":"https://api.github.com/repos/otwcode/otwarchive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otwcode/otwarchive/labels{/name}","releases_url":"https://api.github.com/repos/otwcode/otwarchive/releases{/id}","deployments_url":"https://api.github.com/repos/otwcode/otwarchive/deployments","created_at":"2011-02-07T14:50:58Z","updated_at":"2017-01-01T22:44:01Z","pushed_at":"2017-01-05T19:14:16Z","git_url":"git://github.com/otwcode/otwarchive.git","ssh_url":"[email protected]:otwcode/otwarchive.git","clone_url":"https://github.com/otwcode/otwarchive.git","svn_url":"https://github.com/otwcode/otwarchive","homepage":"http://www.transformativeworks.org/archive_of_our_own/","size":52180,"stargazers_count":230,"watchers_count":230,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":66,"forks":141,"open_issues":66,"watchers":230,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/2700"},"html":{"href":"https://github.com/otwcode/otwarchive/pull/2700"},"issue":{"href":"https://api.github.com/repos/otwcode/otwarchive/issues/2700"},"comments":{"href":"https://api.github.com/repos/otwcode/otwarchive/issues/2700/comments"},"review_comments":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/2700/comments"},"review_comment":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/2700/commits"},"statuses":{"href":"https://api.github.com/repos/otwcode/otwarchive/statuses/cbef2aebc3a6689e25af70adf7ab9363cd7c0be8"}}}} | {
"id": 1338040,
"name": "otwcode/otwarchive",
"url": "https://api.github.com/repos/otwcode/otwarchive"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 408606,
"login": "otwcode",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/408606?",
"url": "https://api.github.com/orgs/otwcode"
} | 2017-01-05T19:14:41 | 5108934383 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/particl/partgui/pulls/comments/141999736","pull_request_review_id":66306585,"id":141999736,"diff_hunk":"@@ -32,7 +32,10 @@ export class StatusComponent implements OnInit {\n .subscribe(connections => this.peerListCount = connections)\n \n this._rpc.state.observe('encryptionstatus')\n- .subscribe(status => this.encryptionStatus = status);\n+ .subscribe(status => {","path":"src/app/core/status/status.component.ts","position":5,"original_position":5,"commit_id":"74e408afd588c11fef8d37849487869fcb5c5c34","original_commit_id":"74e408afd588c11fef8d37849487869fcb5c5c34","user":{"login":"rynomster","id":6912789,"avatar_url":"https://avatars2.githubusercontent.com/u/6912789?v=4","gravatar_id":"","url":"https://api.github.com/users/rynomster","html_url":"https://github.com/rynomster","followers_url":"https://api.github.com/users/rynomster/followers","following_url":"https://api.github.com/users/rynomster/following{/other_user}","gists_url":"https://api.github.com/users/rynomster/gists{/gist_id}","starred_url":"https://api.github.com/users/rynomster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynomster/subscriptions","organizations_url":"https://api.github.com/users/rynomster/orgs","repos_url":"https://api.github.com/users/rynomster/repos","events_url":"https://api.github.com/users/rynomster/events{/privacy}","received_events_url":"https://api.github.com/users/rynomster/received_events","type":"User","site_admin":false},"body":"This is in the wrong place... It should be in rpc-state.service, that is where we do state modifcations, lets keep it in the same place :) ","created_at":"2017-09-30T06:47:27Z","updated_at":"2017-09-30T06:50:31Z","html_url":"https://github.com/particl/partgui/pull/111#discussion_r141999736","pull_request_url":"https://api.github.com/repos/particl/partgui/pulls/111","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/particl/partgui/pulls/comments/141999736"},"html":{"href":"https://github.com/particl/partgui/pull/111#discussion_r141999736"},"pull_request":{"href":"https://api.github.com/repos/particl/partgui/pulls/111"}}},"pull_request":{"url":"https://api.github.com/repos/particl/partgui/pulls/111","id":143194146,"html_url":"https://github.com/particl/partgui/pull/111","diff_url":"https://github.com/particl/partgui/pull/111.diff","patch_url":"https://github.com/particl/partgui/pull/111.patch","issue_url":"https://api.github.com/repos/particl/partgui/issues/111","number":111,"state":"open","locked":false,"title":"Create wallet fixed","user":{"login":"vikas-cis","id":20254889,"avatar_url":"https://avatars0.githubusercontent.com/u/20254889?v=4","gravatar_id":"","url":"https://api.github.com/users/vikas-cis","html_url":"https://github.com/vikas-cis","followers_url":"https://api.github.com/users/vikas-cis/followers","following_url":"https://api.github.com/users/vikas-cis/following{/other_user}","gists_url":"https://api.github.com/users/vikas-cis/gists{/gist_id}","starred_url":"https://api.github.com/users/vikas-cis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikas-cis/subscriptions","organizations_url":"https://api.github.com/users/vikas-cis/orgs","repos_url":"https://api.github.com/users/vikas-cis/repos","events_url":"https://api.github.com/users/vikas-cis/events{/privacy}","received_events_url":"https://api.github.com/users/vikas-cis/received_events","type":"User","site_admin":false},"body":"Create wallet fixed","created_at":"2017-09-26T17:18:15Z","updated_at":"2017-09-30T06:50:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f3ea075ba23abe3b94a40fe4c571d2e19bdbdc2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/particl/partgui/pulls/111/commits","review_comments_url":"https://api.github.com/repos/particl/partgui/pulls/111/comments","review_comment_url":"https://api.github.com/repos/particl/partgui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/particl/partgui/issues/111/comments","statuses_url":"https://api.github.com/repos/particl/partgui/statuses/74e408afd588c11fef8d37849487869fcb5c5c34","head":{"label":"vikas-cis:create_wallet_fixed","ref":"create_wallet_fixed","sha":"74e408afd588c11fef8d37849487869fcb5c5c34","user":{"login":"vikas-cis","id":20254889,"avatar_url":"https://avatars0.githubusercontent.com/u/20254889?v=4","gravatar_id":"","url":"https://api.github.com/users/vikas-cis","html_url":"https://github.com/vikas-cis","followers_url":"https://api.github.com/users/vikas-cis/followers","following_url":"https://api.github.com/users/vikas-cis/following{/other_user}","gists_url":"https://api.github.com/users/vikas-cis/gists{/gist_id}","starred_url":"https://api.github.com/users/vikas-cis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikas-cis/subscriptions","organizations_url":"https://api.github.com/users/vikas-cis/orgs","repos_url":"https://api.github.com/users/vikas-cis/repos","events_url":"https://api.github.com/users/vikas-cis/events{/privacy}","received_events_url":"https://api.github.com/users/vikas-cis/received_events","type":"User","site_admin":false},"repo":{"id":101630758,"name":"partgui","full_name":"vikas-cis/partgui","owner":{"login":"vikas-cis","id":20254889,"avatar_url":"https://avatars0.githubusercontent.com/u/20254889?v=4","gravatar_id":"","url":"https://api.github.com/users/vikas-cis","html_url":"https://github.com/vikas-cis","followers_url":"https://api.github.com/users/vikas-cis/followers","following_url":"https://api.github.com/users/vikas-cis/following{/other_user}","gists_url":"https://api.github.com/users/vikas-cis/gists{/gist_id}","starred_url":"https://api.github.com/users/vikas-cis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikas-cis/subscriptions","organizations_url":"https://api.github.com/users/vikas-cis/orgs","repos_url":"https://api.github.com/users/vikas-cis/repos","events_url":"https://api.github.com/users/vikas-cis/events{/privacy}","received_events_url":"https://api.github.com/users/vikas-cis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vikas-cis/partgui","description":"Particl Angular GUI - The source for the Particl GUI.","fork":true,"url":"https://api.github.com/repos/vikas-cis/partgui","forks_url":"https://api.github.com/repos/vikas-cis/partgui/forks","keys_url":"https://api.github.com/repos/vikas-cis/partgui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vikas-cis/partgui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vikas-cis/partgui/teams","hooks_url":"https://api.github.com/repos/vikas-cis/partgui/hooks","issue_events_url":"https://api.github.com/repos/vikas-cis/partgui/issues/events{/number}","events_url":"https://api.github.com/repos/vikas-cis/partgui/events","assignees_url":"https://api.github.com/repos/vikas-cis/partgui/assignees{/user}","branches_url":"https://api.github.com/repos/vikas-cis/partgui/branches{/branch}","tags_url":"https://api.github.com/repos/vikas-cis/partgui/tags","blobs_url":"https://api.github.com/repos/vikas-cis/partgui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vikas-cis/partgui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vikas-cis/partgui/git/refs{/sha}","trees_url":"https://api.github.com/repos/vikas-cis/partgui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vikas-cis/partgui/statuses/{sha}","languages_url":"https://api.github.com/repos/vikas-cis/partgui/languages","stargazers_url":"https://api.github.com/repos/vikas-cis/partgui/stargazers","contributors_url":"https://api.github.com/repos/vikas-cis/partgui/contributors","subscribers_url":"https://api.github.com/repos/vikas-cis/partgui/subscribers","subscription_url":"https://api.github.com/repos/vikas-cis/partgui/subscription","commits_url":"https://api.github.com/repos/vikas-cis/partgui/commits{/sha}","git_commits_url":"https://api.github.com/repos/vikas-cis/partgui/git/commits{/sha}","comments_url":"https://api.github.com/repos/vikas-cis/partgui/comments{/number}","issue_comment_url":"https://api.github.com/repos/vikas-cis/partgui/issues/comments{/number}","contents_url":"https://api.github.com/repos/vikas-cis/partgui/contents/{+path}","compare_url":"https://api.github.com/repos/vikas-cis/partgui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vikas-cis/partgui/merges","archive_url":"https://api.github.com/repos/vikas-cis/partgui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vikas-cis/partgui/downloads","issues_url":"https://api.github.com/repos/vikas-cis/partgui/issues{/number}","pulls_url":"https://api.github.com/repos/vikas-cis/partgui/pulls{/number}","milestones_url":"https://api.github.com/repos/vikas-cis/partgui/milestones{/number}","notifications_url":"https://api.github.com/repos/vikas-cis/partgui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vikas-cis/partgui/labels{/name}","releases_url":"https://api.github.com/repos/vikas-cis/partgui/releases{/id}","deployments_url":"https://api.github.com/repos/vikas-cis/partgui/deployments","created_at":"2017-08-28T10:10:49Z","updated_at":"2017-08-28T10:10:51Z","pushed_at":"2017-09-29T13:57:02Z","git_url":"git://github.com/vikas-cis/partgui.git","ssh_url":"[email protected]:vikas-cis/partgui.git","clone_url":"https://github.com/vikas-cis/partgui.git","svn_url":"https://github.com/vikas-cis/partgui","homepage":"https://particl.io","size":2290,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"particl:master","ref":"master","sha":"eb120f1814648896ced093156a286b9c157de2e1","user":{"login":"particl","id":26021686,"avatar_url":"https://avatars3.githubusercontent.com/u/26021686?v=4","gravatar_id":"","url":"https://api.github.com/users/particl","html_url":"https://github.com/particl","followers_url":"https://api.github.com/users/particl/followers","following_url":"https://api.github.com/users/particl/following{/other_user}","gists_url":"https://api.github.com/users/particl/gists{/gist_id}","starred_url":"https://api.github.com/users/particl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/particl/subscriptions","organizations_url":"https://api.github.com/users/particl/orgs","repos_url":"https://api.github.com/users/particl/repos","events_url":"https://api.github.com/users/particl/events{/privacy}","received_events_url":"https://api.github.com/users/particl/received_events","type":"Organization","site_admin":false},"repo":{"id":87307942,"name":"partgui","full_name":"particl/partgui","owner":{"login":"particl","id":26021686,"avatar_url":"https://avatars3.githubusercontent.com/u/26021686?v=4","gravatar_id":"","url":"https://api.github.com/users/particl","html_url":"https://github.com/particl","followers_url":"https://api.github.com/users/particl/followers","following_url":"https://api.github.com/users/particl/following{/other_user}","gists_url":"https://api.github.com/users/particl/gists{/gist_id}","starred_url":"https://api.github.com/users/particl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/particl/subscriptions","organizations_url":"https://api.github.com/users/particl/orgs","repos_url":"https://api.github.com/users/particl/repos","events_url":"https://api.github.com/users/particl/events{/privacy}","received_events_url":"https://api.github.com/users/particl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/particl/partgui","description":"Particl Angular GUI - The source for the Particl GUI.","fork":false,"url":"https://api.github.com/repos/particl/partgui","forks_url":"https://api.github.com/repos/particl/partgui/forks","keys_url":"https://api.github.com/repos/particl/partgui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/particl/partgui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/particl/partgui/teams","hooks_url":"https://api.github.com/repos/particl/partgui/hooks","issue_events_url":"https://api.github.com/repos/particl/partgui/issues/events{/number}","events_url":"https://api.github.com/repos/particl/partgui/events","assignees_url":"https://api.github.com/repos/particl/partgui/assignees{/user}","branches_url":"https://api.github.com/repos/particl/partgui/branches{/branch}","tags_url":"https://api.github.com/repos/particl/partgui/tags","blobs_url":"https://api.github.com/repos/particl/partgui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/particl/partgui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/particl/partgui/git/refs{/sha}","trees_url":"https://api.github.com/repos/particl/partgui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/particl/partgui/statuses/{sha}","languages_url":"https://api.github.com/repos/particl/partgui/languages","stargazers_url":"https://api.github.com/repos/particl/partgui/stargazers","contributors_url":"https://api.github.com/repos/particl/partgui/contributors","subscribers_url":"https://api.github.com/repos/particl/partgui/subscribers","subscription_url":"https://api.github.com/repos/particl/partgui/subscription","commits_url":"https://api.github.com/repos/particl/partgui/commits{/sha}","git_commits_url":"https://api.github.com/repos/particl/partgui/git/commits{/sha}","comments_url":"https://api.github.com/repos/particl/partgui/comments{/number}","issue_comment_url":"https://api.github.com/repos/particl/partgui/issues/comments{/number}","contents_url":"https://api.github.com/repos/particl/partgui/contents/{+path}","compare_url":"https://api.github.com/repos/particl/partgui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/particl/partgui/merges","archive_url":"https://api.github.com/repos/particl/partgui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/particl/partgui/downloads","issues_url":"https://api.github.com/repos/particl/partgui/issues{/number}","pulls_url":"https://api.github.com/repos/particl/partgui/pulls{/number}","milestones_url":"https://api.github.com/repos/particl/partgui/milestones{/number}","notifications_url":"https://api.github.com/repos/particl/partgui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/particl/partgui/labels{/name}","releases_url":"https://api.github.com/repos/particl/partgui/releases{/id}","deployments_url":"https://api.github.com/repos/particl/partgui/deployments","created_at":"2017-04-05T12:42:16Z","updated_at":"2017-09-15T21:51:08Z","pushed_at":"2017-09-30T06:46:24Z","git_url":"git://github.com/particl/partgui.git","ssh_url":"[email protected]:particl/partgui.git","clone_url":"https://github.com/particl/partgui.git","svn_url":"https://github.com/particl/partgui","homepage":"https://particl.io","size":2308,"stargazers_count":13,"watchers_count":13,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":16,"forks":14,"open_issues":16,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/particl/partgui/pulls/111"},"html":{"href":"https://github.com/particl/partgui/pull/111"},"issue":{"href":"https://api.github.com/repos/particl/partgui/issues/111"},"comments":{"href":"https://api.github.com/repos/particl/partgui/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/particl/partgui/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/particl/partgui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/particl/partgui/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/particl/partgui/statuses/74e408afd588c11fef8d37849487869fcb5c5c34"}},"author_association":"CONTRIBUTOR"}} | {
"id": 87307942,
"name": "particl/partgui",
"url": "https://api.github.com/repos/particl/partgui"
} | {
"id": 6912789,
"login": "rynomster",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6912789?",
"url": "https://api.github.com/users/rynomster"
} | {
"id": 26021686,
"login": "particl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26021686?",
"url": "https://api.github.com/orgs/particl"
} | 2017-09-30T06:47:27 | 6657521775 | {"actor":{"display_login":"rynomster"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/percona/percona-server/pulls/comments/109628071","pull_request_review_id":30740516,"id":109628071,"diff_hunk":"@@ -0,0 +1,127 @@\n+#include <my_global.h>\n+#include \"vault_credentials_parser.h\"\n+#include <fstream>\n+#include <algorithm>\n+#include <iostream>\n+\n+namespace keyring\n+{\n+ struct Is_not_space\n+ {\n+ my_bool operator()(char c)\n+ {\n+ return !std::isspace(c);\n+ }\n+ };\n+\n+ static inline Secure_string* ltrim(Secure_string *s) {\n+ s->erase(s->begin(), std::find_if(s->begin(), s->end(),\n+ Is_not_space()));\n+ return s;\n+ }\n+\n+ // trim from end\n+ static inline Secure_string* rtrim(Secure_string *s) {\n+ s->erase(std::find_if(s->rbegin(), s->rend(),\n+ Is_not_space()).base(), s->end());\n+ return s;\n+ }\n+\n+ // trim from both ends\n+ static inline Secure_string* trim(Secure_string *s) {\n+ return ltrim(rtrim(s));\n+ }\n+\n+ void Vault_credentials_parser::reset_vault_credentials(Vault_credentials *vault_credentials)\n+ {\n+ for(Vault_credentials::iterator iter = vault_credentials->begin();\n+ iter != vault_credentials->end(); ++iter)\n+ iter->second.clear();\n+ }\n+\n+ my_bool Vault_credentials_parser::is_valid_option(Secure_string *option)\n+ {\n+ return vault_credentials_in_progress.count(*option);\n+ }\n+\n+ my_bool Vault_credentials_parser::parse_line(uint line_number, Secure_string *line, Vault_credentials *vault_credentials)\n+ {\n+ if (line->empty())\n+ return FALSE;\n+\n+ size_t eq_sign_pos = line->find('=');\n+ std::stringstream err_ss;\n+\n+ if (eq_sign_pos == std::string::npos)\n+ {\n+ err_ss << \"Could not parse credential file. Cannot find equal sign (=) in line: \";\n+ err_ss << line_number << '.';\n+ logger->log(MY_ERROR_LEVEL, err_ss.str().c_str());\n+ return TRUE;\n+ }\n+ Secure_string option = line->substr(0, eq_sign_pos);\n+ trim(&option); \n+\n+ if (is_valid_option(&option) == false)\n+ {\n+ err_ss << \"Could not parse credential file. Unknown option \\\"\" << option << \"\\\" in line: \";\n+ err_ss << line_number << '.';\n+ return TRUE;\n+ }\n+ Secure_string *value = &(*vault_credentials)[option];\n+\n+ if (value->empty() == false) //repeated option in file\n+ {\n+ err_ss << \"Could not parse credential file. Seems that value for option \" << option;\n+ err_ss << \" has been specified more than once in line: \" << line_number << '.';\n+ logger->log(MY_ERROR_LEVEL, err_ss.str().c_str());\n+ return TRUE;\n+ }\n+ *value = line->substr(eq_sign_pos + 1, line->size() - (eq_sign_pos + 1)); \n+ trim(value);\n+\n+ if (value->empty())\n+ {\n+ err_ss << \"Could not parse credential file. Seems there is no value specified \";\n+ err_ss << \"for option \" << option << \" in line: \" << line_number << '.';\n+\n+ logger->log(MY_ERROR_LEVEL, err_ss.str().c_str());\n+ return TRUE;\n+ }\n+ return FALSE;\n+ }\n+\n+ my_bool Vault_credentials_parser::parse(std::string *file_url, Vault_credentials *vault_credentials)\n+ {\n+ reset_vault_credentials(&vault_credentials_in_progress);\n+\n+ std::ifstream credentials_file(file_url->c_str());","path":"plugin/keyring_vault/vault_credentials_parser.cc","position":98,"original_position":98,"commit_id":"2dcd20ed4c7e5a1417334486ddd46e4239d7af56","original_commit_id":"2dcd20ed4c7e5a1417334486ddd46e4239d7af56","user":{"login":"laurynas-biveinis","id":58894,"avatar_url":"https://avatars0.githubusercontent.com/u/58894?v=3","gravatar_id":"","url":"https://api.github.com/users/laurynas-biveinis","html_url":"https://github.com/laurynas-biveinis","followers_url":"https://api.github.com/users/laurynas-biveinis/followers","following_url":"https://api.github.com/users/laurynas-biveinis/following{/other_user}","gists_url":"https://api.github.com/users/laurynas-biveinis/gists{/gist_id}","starred_url":"https://api.github.com/users/laurynas-biveinis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurynas-biveinis/subscriptions","organizations_url":"https://api.github.com/users/laurynas-biveinis/orgs","repos_url":"https://api.github.com/users/laurynas-biveinis/repos","events_url":"https://api.github.com/users/laurynas-biveinis/events{/privacy}","received_events_url":"https://api.github.com/users/laurynas-biveinis/received_events","type":"User","site_admin":false},"body":"PFS support is a standing requirement. But here its lack is acceptable due to small file sizes.\r\nBTW, re. PFS, curl network I/O needs to be looked at. I suspect that only thd_wait_start/end is feasible.","created_at":"2017-04-04T10:32:53Z","updated_at":"2017-04-04T10:32:53Z","html_url":"https://github.com/percona/percona-server/pull/1607#discussion_r109628071","pull_request_url":"https://api.github.com/repos/percona/percona-server/pulls/1607","_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments/109628071"},"html":{"href":"https://github.com/percona/percona-server/pull/1607#discussion_r109628071"},"pull_request":{"href":"https://api.github.com/repos/percona/percona-server/pulls/1607"}}},"pull_request":{"url":"https://api.github.com/repos/percona/percona-server/pulls/1607","id":113945231,"html_url":"https://github.com/percona/percona-server/pull/1607","diff_url":"https://github.com/percona/percona-server/pull/1607.diff","patch_url":"https://github.com/percona/percona-server/pull/1607.patch","issue_url":"https://api.github.com/repos/percona/percona-server/issues/1607","number":1607,"state":"open","locked":false,"title":"keyring_vault plugin","user":{"login":"robgolebiowski","id":13623486,"avatar_url":"https://avatars1.githubusercontent.com/u/13623486?v=3","gravatar_id":"","url":"https://api.github.com/users/robgolebiowski","html_url":"https://github.com/robgolebiowski","followers_url":"https://api.github.com/users/robgolebiowski/followers","following_url":"https://api.github.com/users/robgolebiowski/following{/other_user}","gists_url":"https://api.github.com/users/robgolebiowski/gists{/gist_id}","starred_url":"https://api.github.com/users/robgolebiowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robgolebiowski/subscriptions","organizations_url":"https://api.github.com/users/robgolebiowski/orgs","repos_url":"https://api.github.com/users/robgolebiowski/repos","events_url":"https://api.github.com/users/robgolebiowski/events{/privacy}","received_events_url":"https://api.github.com/users/robgolebiowski/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-03T14:35:44Z","updated_at":"2017-04-04T10:32:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"306b833ad07a1eb1150bf221af7b6a9438b1cca3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/percona/percona-server/pulls/1607/commits","review_comments_url":"https://api.github.com/repos/percona/percona-server/pulls/1607/comments","review_comment_url":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/percona-server/issues/1607/comments","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/2dcd20ed4c7e5a1417334486ddd46e4239d7af56","head":{"label":"robgolebiowski:5.7_keyring_vault_squashed","ref":"5.7_keyring_vault_squashed","sha":"2dcd20ed4c7e5a1417334486ddd46e4239d7af56","user":{"login":"robgolebiowski","id":13623486,"avatar_url":"https://avatars1.githubusercontent.com/u/13623486?v=3","gravatar_id":"","url":"https://api.github.com/users/robgolebiowski","html_url":"https://github.com/robgolebiowski","followers_url":"https://api.github.com/users/robgolebiowski/followers","following_url":"https://api.github.com/users/robgolebiowski/following{/other_user}","gists_url":"https://api.github.com/users/robgolebiowski/gists{/gist_id}","starred_url":"https://api.github.com/users/robgolebiowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robgolebiowski/subscriptions","organizations_url":"https://api.github.com/users/robgolebiowski/orgs","repos_url":"https://api.github.com/users/robgolebiowski/repos","events_url":"https://api.github.com/users/robgolebiowski/events{/privacy}","received_events_url":"https://api.github.com/users/robgolebiowski/received_events","type":"User","site_admin":false},"repo":{"id":78863750,"name":"percona-server","full_name":"robgolebiowski/percona-server","owner":{"login":"robgolebiowski","id":13623486,"avatar_url":"https://avatars1.githubusercontent.com/u/13623486?v=3","gravatar_id":"","url":"https://api.github.com/users/robgolebiowski","html_url":"https://github.com/robgolebiowski","followers_url":"https://api.github.com/users/robgolebiowski/followers","following_url":"https://api.github.com/users/robgolebiowski/following{/other_user}","gists_url":"https://api.github.com/users/robgolebiowski/gists{/gist_id}","starred_url":"https://api.github.com/users/robgolebiowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robgolebiowski/subscriptions","organizations_url":"https://api.github.com/users/robgolebiowski/orgs","repos_url":"https://api.github.com/users/robgolebiowski/repos","events_url":"https://api.github.com/users/robgolebiowski/events{/privacy}","received_events_url":"https://api.github.com/users/robgolebiowski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robgolebiowski/percona-server","description":"Percona Server","fork":true,"url":"https://api.github.com/repos/robgolebiowski/percona-server","forks_url":"https://api.github.com/repos/robgolebiowski/percona-server/forks","keys_url":"https://api.github.com/repos/robgolebiowski/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robgolebiowski/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robgolebiowski/percona-server/teams","hooks_url":"https://api.github.com/repos/robgolebiowski/percona-server/hooks","issue_events_url":"https://api.github.com/repos/robgolebiowski/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/robgolebiowski/percona-server/events","assignees_url":"https://api.github.com/repos/robgolebiowski/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/robgolebiowski/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/robgolebiowski/percona-server/tags","blobs_url":"https://api.github.com/repos/robgolebiowski/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robgolebiowski/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robgolebiowski/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/robgolebiowski/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robgolebiowski/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/robgolebiowski/percona-server/languages","stargazers_url":"https://api.github.com/repos/robgolebiowski/percona-server/stargazers","contributors_url":"https://api.github.com/repos/robgolebiowski/percona-server/contributors","subscribers_url":"https://api.github.com/repos/robgolebiowski/percona-server/subscribers","subscription_url":"https://api.github.com/repos/robgolebiowski/percona-server/subscription","commits_url":"https://api.github.com/repos/robgolebiowski/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/robgolebiowski/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/robgolebiowski/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/robgolebiowski/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/robgolebiowski/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/robgolebiowski/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robgolebiowski/percona-server/merges","archive_url":"https://api.github.com/repos/robgolebiowski/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robgolebiowski/percona-server/downloads","issues_url":"https://api.github.com/repos/robgolebiowski/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/robgolebiowski/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/robgolebiowski/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/robgolebiowski/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robgolebiowski/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/robgolebiowski/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/robgolebiowski/percona-server/deployments","created_at":"2017-01-13T15:57:37Z","updated_at":"2017-01-13T15:59:56Z","pushed_at":"2017-04-03T13:56:15Z","git_url":"git://github.com/robgolebiowski/percona-server.git","ssh_url":"[email protected]:robgolebiowski/percona-server.git","clone_url":"https://github.com/robgolebiowski/percona-server.git","svn_url":"https://github.com/robgolebiowski/percona-server","homepage":"https://www.percona.com/software/mysql-database/percona-server","size":903504,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.7"}},"base":{"label":"percona:5.7","ref":"5.7","sha":"c8c0e524b9338daa689cf8c1369294db6a8887a7","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars3.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":30753733,"name":"percona-server","full_name":"percona/percona-server","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars3.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/percona-server","description":"Percona Server","fork":false,"url":"https://api.github.com/repos/percona/percona-server","forks_url":"https://api.github.com/repos/percona/percona-server/forks","keys_url":"https://api.github.com/repos/percona/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-server/teams","hooks_url":"https://api.github.com/repos/percona/percona-server/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-server/events","assignees_url":"https://api.github.com/repos/percona/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-server/tags","blobs_url":"https://api.github.com/repos/percona/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-server/languages","stargazers_url":"https://api.github.com/repos/percona/percona-server/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-server/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-server/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-server/subscription","commits_url":"https://api.github.com/repos/percona/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-server/merges","archive_url":"https://api.github.com/repos/percona/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-server/downloads","issues_url":"https://api.github.com/repos/percona/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/percona/percona-server/deployments","created_at":"2015-02-13T11:32:01Z","updated_at":"2017-04-03T04:27:22Z","pushed_at":"2017-04-04T07:02:31Z","git_url":"git://github.com/percona/percona-server.git","ssh_url":"[email protected]:percona/percona-server.git","clone_url":"https://github.com/percona/percona-server.git","svn_url":"https://github.com/percona/percona-server","homepage":"https://www.percona.com/software/mysql-database/percona-server","size":541511,"stargazers_count":283,"watchers_count":283,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"open_issues_count":27,"forks":117,"open_issues":27,"watchers":283,"default_branch":"5.7"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/1607"},"html":{"href":"https://github.com/percona/percona-server/pull/1607"},"issue":{"href":"https://api.github.com/repos/percona/percona-server/issues/1607"},"comments":{"href":"https://api.github.com/repos/percona/percona-server/issues/1607/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/percona-server/pulls/1607/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/percona-server/pulls/1607/commits"},"statuses":{"href":"https://api.github.com/repos/percona/percona-server/statuses/2dcd20ed4c7e5a1417334486ddd46e4239d7af56"}}}} | {
"id": 30753733,
"name": "percona/percona-server",
"url": "https://api.github.com/repos/percona/percona-server"
} | {
"id": 58894,
"login": "laurynas-biveinis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/58894?",
"url": "https://api.github.com/users/laurynas-biveinis"
} | {
"id": 1683025,
"login": "percona",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1683025?",
"url": "https://api.github.com/orgs/percona"
} | 2017-04-04T10:32:53 | 5621647996 | {"actor":{"display_login":"laurynas-biveinis"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/percona/percona-server/pulls/comments/149305749","pull_request_review_id":74403260,"id":149305749,"diff_hunk":"@@ -110,7 +110,7 @@ Transaction_boundary_parser::get_event_boundary_type(\n if (length < header_size)\n goto end;\n \n- event_type= (Log_event_type)buf[EVENT_TYPE_OFFSET];\n+ event_type= (Log_event_type)static_cast<unsigned char>(buf[EVENT_TYPE_OFFSET]);","path":"sql/rpl_trx_boundary_parser.cc","position":5,"original_position":5,"commit_id":"b473453117ac21a4bc9a711cde3037b096af3dee","original_commit_id":"b473453117ac21a4bc9a711cde3037b096af3dee","user":{"login":"laurynas-biveinis","id":58894,"avatar_url":"https://avatars3.githubusercontent.com/u/58894?v=4","gravatar_id":"","url":"https://api.github.com/users/laurynas-biveinis","html_url":"https://github.com/laurynas-biveinis","followers_url":"https://api.github.com/users/laurynas-biveinis/followers","following_url":"https://api.github.com/users/laurynas-biveinis/following{/other_user}","gists_url":"https://api.github.com/users/laurynas-biveinis/gists{/gist_id}","starred_url":"https://api.github.com/users/laurynas-biveinis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurynas-biveinis/subscriptions","organizations_url":"https://api.github.com/users/laurynas-biveinis/orgs","repos_url":"https://api.github.com/users/laurynas-biveinis/repos","events_url":"https://api.github.com/users/laurynas-biveinis/events{/privacy}","received_events_url":"https://api.github.com/users/laurynas-biveinis/received_events","type":"User","site_admin":false},"body":"Cannot just cast to Log_event_type directly?","created_at":"2017-11-07T09:06:39Z","updated_at":"2017-11-07T09:19:33Z","html_url":"https://github.com/percona/percona-server/pull/1943#discussion_r149305749","pull_request_url":"https://api.github.com/repos/percona/percona-server/pulls/1943","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments/149305749"},"html":{"href":"https://github.com/percona/percona-server/pull/1943#discussion_r149305749"},"pull_request":{"href":"https://api.github.com/repos/percona/percona-server/pulls/1943"}}},"pull_request":{"url":"https://api.github.com/repos/percona/percona-server/pulls/1943","id":144854805,"html_url":"https://github.com/percona/percona-server/pull/1943","diff_url":"https://github.com/percona/percona-server/pull/1943.diff","patch_url":"https://github.com/percona/percona-server/pull/1943.patch","issue_url":"https://api.github.com/repos/percona/percona-server/issues/1943","number":1943,"state":"open","locked":false,"title":"Binlog encryption","user":{"login":"robgolebiowski","id":13623486,"avatar_url":"https://avatars2.githubusercontent.com/u/13623486?v=4","gravatar_id":"","url":"https://api.github.com/users/robgolebiowski","html_url":"https://github.com/robgolebiowski","followers_url":"https://api.github.com/users/robgolebiowski/followers","following_url":"https://api.github.com/users/robgolebiowski/following{/other_user}","gists_url":"https://api.github.com/users/robgolebiowski/gists{/gist_id}","starred_url":"https://api.github.com/users/robgolebiowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robgolebiowski/subscriptions","organizations_url":"https://api.github.com/users/robgolebiowski/orgs","repos_url":"https://api.github.com/users/robgolebiowski/repos","events_url":"https://api.github.com/users/robgolebiowski/events{/privacy}","received_events_url":"https://api.github.com/users/robgolebiowski/received_events","type":"User","site_admin":false},"body":"Based on MariaDB commits:\r\n\r\ncommit b85a00161e91080cb82b99e812c18eafb6467737\r\n\r\n MDEV-8264 encryption for binlog\r\n\r\n * Start_encryption_log_event\r\n * --encrypt-binlog command line option\r\n\r\n based on google patches.\r\n\r\ncommit 7bd2f20e880a5871635260c0a96448631c28b2c5\r\n\r\n make encrypt-binlog and encrypt-tmp-files to fail if no encryption\r\n\r\ncommit b5aa0f437fc595d508b9eb5d36185fd8cbaa62eb\r\n\r\n MDEV-11319 mysqlbinlog crashes or fails with out of memory while\r\n reading some encrypted binlogs support encrypted binlogs.\r\n Not decryption, but at least recognizing that event are\r\n encrypted and prining them as such\r\n\r\nServer sends additional heartbeat event to slave after\r\nreading Start_encryption_event to notify slave to update its master log\r\nposition. This is needed as Start_encryption event is never send to\r\nslave.","created_at":"2017-10-05T08:26:27Z","updated_at":"2017-11-07T09:19:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b7e278f12e15d3131cc12f128e9389dae4a20ae","assignee":{"login":"robgolebiowski","id":13623486,"avatar_url":"https://avatars2.githubusercontent.com/u/13623486?v=4","gravatar_id":"","url":"https://api.github.com/users/robgolebiowski","html_url":"https://github.com/robgolebiowski","followers_url":"https://api.github.com/users/robgolebiowski/followers","following_url":"https://api.github.com/users/robgolebiowski/following{/other_user}","gists_url":"https://api.github.com/users/robgolebiowski/gists{/gist_id}","starred_url":"https://api.github.com/users/robgolebiowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robgolebiowski/subscriptions","organizations_url":"https://api.github.com/users/robgolebiowski/orgs","repos_url":"https://api.github.com/users/robgolebiowski/repos","events_url":"https://api.github.com/users/robgolebiowski/events{/privacy}","received_events_url":"https://api.github.com/users/robgolebiowski/received_events","type":"User","site_admin":false},"assignees":[{"login":"robgolebiowski","id":13623486,"avatar_url":"https://avatars2.githubusercontent.com/u/13623486?v=4","gravatar_id":"","url":"https://api.github.com/users/robgolebiowski","html_url":"https://github.com/robgolebiowski","followers_url":"https://api.github.com/users/robgolebiowski/followers","following_url":"https://api.github.com/users/robgolebiowski/following{/other_user}","gists_url":"https://api.github.com/users/robgolebiowski/gists{/gist_id}","starred_url":"https://api.github.com/users/robgolebiowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robgolebiowski/subscriptions","organizations_url":"https://api.github.com/users/robgolebiowski/orgs","repos_url":"https://api.github.com/users/robgolebiowski/repos","events_url":"https://api.github.com/users/robgolebiowski/events{/privacy}","received_events_url":"https://api.github.com/users/robgolebiowski/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"gl-sergei","id":371194,"avatar_url":"https://avatars3.githubusercontent.com/u/371194?v=4","gravatar_id":"","url":"https://api.github.com/users/gl-sergei","html_url":"https://github.com/gl-sergei","followers_url":"https://api.github.com/users/gl-sergei/followers","following_url":"https://api.github.com/users/gl-sergei/following{/other_user}","gists_url":"https://api.github.com/users/gl-sergei/gists{/gist_id}","starred_url":"https://api.github.com/users/gl-sergei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gl-sergei/subscriptions","organizations_url":"https://api.github.com/users/gl-sergei/orgs","repos_url":"https://api.github.com/users/gl-sergei/repos","events_url":"https://api.github.com/users/gl-sergei/events{/privacy}","received_events_url":"https://api.github.com/users/gl-sergei/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/percona/percona-server/pulls/1943/commits","review_comments_url":"https://api.github.com/repos/percona/percona-server/pulls/1943/comments","review_comment_url":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/percona-server/issues/1943/comments","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/b473453117ac21a4bc9a711cde3037b096af3dee","head":{"label":"robgolebiowski:57_binlog_encryption_rebased2","ref":"57_binlog_encryption_rebased2","sha":"b473453117ac21a4bc9a711cde3037b096af3dee","user":{"login":"robgolebiowski","id":13623486,"avatar_url":"https://avatars2.githubusercontent.com/u/13623486?v=4","gravatar_id":"","url":"https://api.github.com/users/robgolebiowski","html_url":"https://github.com/robgolebiowski","followers_url":"https://api.github.com/users/robgolebiowski/followers","following_url":"https://api.github.com/users/robgolebiowski/following{/other_user}","gists_url":"https://api.github.com/users/robgolebiowski/gists{/gist_id}","starred_url":"https://api.github.com/users/robgolebiowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robgolebiowski/subscriptions","organizations_url":"https://api.github.com/users/robgolebiowski/orgs","repos_url":"https://api.github.com/users/robgolebiowski/repos","events_url":"https://api.github.com/users/robgolebiowski/events{/privacy}","received_events_url":"https://api.github.com/users/robgolebiowski/received_events","type":"User","site_admin":false},"repo":{"id":78863750,"name":"percona-server","full_name":"robgolebiowski/percona-server","owner":{"login":"robgolebiowski","id":13623486,"avatar_url":"https://avatars2.githubusercontent.com/u/13623486?v=4","gravatar_id":"","url":"https://api.github.com/users/robgolebiowski","html_url":"https://github.com/robgolebiowski","followers_url":"https://api.github.com/users/robgolebiowski/followers","following_url":"https://api.github.com/users/robgolebiowski/following{/other_user}","gists_url":"https://api.github.com/users/robgolebiowski/gists{/gist_id}","starred_url":"https://api.github.com/users/robgolebiowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robgolebiowski/subscriptions","organizations_url":"https://api.github.com/users/robgolebiowski/orgs","repos_url":"https://api.github.com/users/robgolebiowski/repos","events_url":"https://api.github.com/users/robgolebiowski/events{/privacy}","received_events_url":"https://api.github.com/users/robgolebiowski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robgolebiowski/percona-server","description":"Percona Server","fork":true,"url":"https://api.github.com/repos/robgolebiowski/percona-server","forks_url":"https://api.github.com/repos/robgolebiowski/percona-server/forks","keys_url":"https://api.github.com/repos/robgolebiowski/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robgolebiowski/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robgolebiowski/percona-server/teams","hooks_url":"https://api.github.com/repos/robgolebiowski/percona-server/hooks","issue_events_url":"https://api.github.com/repos/robgolebiowski/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/robgolebiowski/percona-server/events","assignees_url":"https://api.github.com/repos/robgolebiowski/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/robgolebiowski/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/robgolebiowski/percona-server/tags","blobs_url":"https://api.github.com/repos/robgolebiowski/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robgolebiowski/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robgolebiowski/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/robgolebiowski/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robgolebiowski/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/robgolebiowski/percona-server/languages","stargazers_url":"https://api.github.com/repos/robgolebiowski/percona-server/stargazers","contributors_url":"https://api.github.com/repos/robgolebiowski/percona-server/contributors","subscribers_url":"https://api.github.com/repos/robgolebiowski/percona-server/subscribers","subscription_url":"https://api.github.com/repos/robgolebiowski/percona-server/subscription","commits_url":"https://api.github.com/repos/robgolebiowski/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/robgolebiowski/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/robgolebiowski/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/robgolebiowski/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/robgolebiowski/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/robgolebiowski/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robgolebiowski/percona-server/merges","archive_url":"https://api.github.com/repos/robgolebiowski/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robgolebiowski/percona-server/downloads","issues_url":"https://api.github.com/repos/robgolebiowski/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/robgolebiowski/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/robgolebiowski/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/robgolebiowski/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robgolebiowski/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/robgolebiowski/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/robgolebiowski/percona-server/deployments","created_at":"2017-01-13T15:57:37Z","updated_at":"2017-01-13T15:59:56Z","pushed_at":"2017-11-06T15:46:23Z","git_url":"git://github.com/robgolebiowski/percona-server.git","ssh_url":"[email protected]:robgolebiowski/percona-server.git","clone_url":"https://github.com/robgolebiowski/percona-server.git","svn_url":"https://github.com/robgolebiowski/percona-server","homepage":"https://www.percona.com/software/mysql-database/percona-server","size":1151286,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.7"}},"base":{"label":"percona:5.7","ref":"5.7","sha":"d6b5c7ded54b61e7038ef89f73617b183f1d54a3","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":30753733,"name":"percona-server","full_name":"percona/percona-server","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/percona-server","description":"Percona Server","fork":false,"url":"https://api.github.com/repos/percona/percona-server","forks_url":"https://api.github.com/repos/percona/percona-server/forks","keys_url":"https://api.github.com/repos/percona/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-server/teams","hooks_url":"https://api.github.com/repos/percona/percona-server/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-server/events","assignees_url":"https://api.github.com/repos/percona/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-server/tags","blobs_url":"https://api.github.com/repos/percona/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-server/languages","stargazers_url":"https://api.github.com/repos/percona/percona-server/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-server/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-server/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-server/subscription","commits_url":"https://api.github.com/repos/percona/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-server/merges","archive_url":"https://api.github.com/repos/percona/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-server/downloads","issues_url":"https://api.github.com/repos/percona/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/percona/percona-server/deployments","created_at":"2015-02-13T11:32:01Z","updated_at":"2017-11-06T20:37:19Z","pushed_at":"2017-11-07T08:07:09Z","git_url":"git://github.com/percona/percona-server.git","ssh_url":"[email protected]:percona/percona-server.git","clone_url":"https://github.com/percona/percona-server.git","svn_url":"https://github.com/percona/percona-server","homepage":"https://www.percona.com/software/mysql-database/percona-server","size":565966,"stargazers_count":368,"watchers_count":368,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":148,"mirror_url":null,"archived":false,"open_issues_count":43,"forks":148,"open_issues":43,"watchers":368,"default_branch":"5.7"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/1943"},"html":{"href":"https://github.com/percona/percona-server/pull/1943"},"issue":{"href":"https://api.github.com/repos/percona/percona-server/issues/1943"},"comments":{"href":"https://api.github.com/repos/percona/percona-server/issues/1943/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/percona-server/pulls/1943/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/percona-server/pulls/1943/commits"},"statuses":{"href":"https://api.github.com/repos/percona/percona-server/statuses/b473453117ac21a4bc9a711cde3037b096af3dee"}},"author_association":"CONTRIBUTOR"}} | {
"id": 30753733,
"name": "percona/percona-server",
"url": "https://api.github.com/repos/percona/percona-server"
} | {
"id": 58894,
"login": "laurynas-biveinis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/58894?",
"url": "https://api.github.com/users/laurynas-biveinis"
} | {
"id": 1683025,
"login": "percona",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1683025?",
"url": "https://api.github.com/orgs/percona"
} | 2017-11-07T09:06:39 | 6819178393 | {"actor":{"display_login":"laurynas-biveinis"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/119801390","pull_request_review_id":41713600,"id":119801390,"diff_hunk":"@@ -1770,6 +1770,72 @@ func getTimeZone(ctx context.Context) *time.Location {\n \treturn ret\n }\n \n+// isDuration returns a boolean indicating whether the str is the format of duration.","path":"expression/builtin_time.go","position":4,"original_position":4,"commit_id":"2256ea2b5a74fab2b9f2b80483143c0636a6c94e","original_commit_id":"cda3cebe868c5ec6e48f0e6a3cb1a906d750370d","user":{"login":"hawkingrei","id":3427324,"avatar_url":"https://avatars2.githubusercontent.com/u/3427324?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkingrei","html_url":"https://github.com/hawkingrei","followers_url":"https://api.github.com/users/hawkingrei/followers","following_url":"https://api.github.com/users/hawkingrei/following{/other_user}","gists_url":"https://api.github.com/users/hawkingrei/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkingrei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkingrei/subscriptions","organizations_url":"https://api.github.com/users/hawkingrei/orgs","repos_url":"https://api.github.com/users/hawkingrei/repos","events_url":"https://api.github.com/users/hawkingrei/events{/privacy}","received_events_url":"https://api.github.com/users/hawkingrei/received_events","type":"User","site_admin":false},"body":"@XuHuaiyu Use regular expression install of the old way.","created_at":"2017-06-02T08:05:23Z","updated_at":"2017-06-02T08:05:23Z","html_url":"https://github.com/pingcap/tidb/pull/3290#discussion_r119801390","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/3290","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/119801390"},"html":{"href":"https://github.com/pingcap/tidb/pull/3290#discussion_r119801390"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/3290"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/3290","id":121079985,"html_url":"https://github.com/pingcap/tidb/pull/3290","diff_url":"https://github.com/pingcap/tidb/pull/3290.diff","patch_url":"https://github.com/pingcap/tidb/pull/3290.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/3290","number":3290,"state":"open","locked":false,"title":"expression: add builtinAddTimeSig","user":{"login":"hawkingrei","id":3427324,"avatar_url":"https://avatars2.githubusercontent.com/u/3427324?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkingrei","html_url":"https://github.com/hawkingrei","followers_url":"https://api.github.com/users/hawkingrei/followers","following_url":"https://api.github.com/users/hawkingrei/following{/other_user}","gists_url":"https://api.github.com/users/hawkingrei/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkingrei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkingrei/subscriptions","organizations_url":"https://api.github.com/users/hawkingrei/orgs","repos_url":"https://api.github.com/users/hawkingrei/repos","events_url":"https://api.github.com/users/hawkingrei/events{/privacy}","received_events_url":"https://api.github.com/users/hawkingrei/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-17T15:00:49Z","updated_at":"2017-06-02T08:05:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20728a9e298f1171b8b1b88b5f74ac8ab0daac5e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/3290/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/3290/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/3290/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/2256ea2b5a74fab2b9f2b80483143c0636a6c94e","head":{"label":"hawkingrei:expression/add_builtinAddTimeSig","ref":"expression/add_builtinAddTimeSig","sha":"2256ea2b5a74fab2b9f2b80483143c0636a6c94e","user":{"login":"hawkingrei","id":3427324,"avatar_url":"https://avatars2.githubusercontent.com/u/3427324?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkingrei","html_url":"https://github.com/hawkingrei","followers_url":"https://api.github.com/users/hawkingrei/followers","following_url":"https://api.github.com/users/hawkingrei/following{/other_user}","gists_url":"https://api.github.com/users/hawkingrei/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkingrei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkingrei/subscriptions","organizations_url":"https://api.github.com/users/hawkingrei/orgs","repos_url":"https://api.github.com/users/hawkingrei/repos","events_url":"https://api.github.com/users/hawkingrei/events{/privacy}","received_events_url":"https://api.github.com/users/hawkingrei/received_events","type":"User","site_admin":false},"repo":{"id":91561533,"name":"tidb","full_name":"hawkingrei/tidb","owner":{"login":"hawkingrei","id":3427324,"avatar_url":"https://avatars2.githubusercontent.com/u/3427324?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkingrei","html_url":"https://github.com/hawkingrei","followers_url":"https://api.github.com/users/hawkingrei/followers","following_url":"https://api.github.com/users/hawkingrei/following{/other_user}","gists_url":"https://api.github.com/users/hawkingrei/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkingrei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkingrei/subscriptions","organizations_url":"https://api.github.com/users/hawkingrei/orgs","repos_url":"https://api.github.com/users/hawkingrei/repos","events_url":"https://api.github.com/users/hawkingrei/events{/privacy}","received_events_url":"https://api.github.com/users/hawkingrei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hawkingrei/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":true,"url":"https://api.github.com/repos/hawkingrei/tidb","forks_url":"https://api.github.com/repos/hawkingrei/tidb/forks","keys_url":"https://api.github.com/repos/hawkingrei/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkingrei/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkingrei/tidb/teams","hooks_url":"https://api.github.com/repos/hawkingrei/tidb/hooks","issue_events_url":"https://api.github.com/repos/hawkingrei/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/hawkingrei/tidb/events","assignees_url":"https://api.github.com/repos/hawkingrei/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/hawkingrei/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/hawkingrei/tidb/tags","blobs_url":"https://api.github.com/repos/hawkingrei/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkingrei/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkingrei/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkingrei/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkingrei/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkingrei/tidb/languages","stargazers_url":"https://api.github.com/repos/hawkingrei/tidb/stargazers","contributors_url":"https://api.github.com/repos/hawkingrei/tidb/contributors","subscribers_url":"https://api.github.com/repos/hawkingrei/tidb/subscribers","subscription_url":"https://api.github.com/repos/hawkingrei/tidb/subscription","commits_url":"https://api.github.com/repos/hawkingrei/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkingrei/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkingrei/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkingrei/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkingrei/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/hawkingrei/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkingrei/tidb/merges","archive_url":"https://api.github.com/repos/hawkingrei/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkingrei/tidb/downloads","issues_url":"https://api.github.com/repos/hawkingrei/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/hawkingrei/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkingrei/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkingrei/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkingrei/tidb/labels{/name}","releases_url":"https://api.github.com/repos/hawkingrei/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/hawkingrei/tidb/deployments","created_at":"2017-05-17T09:56:08Z","updated_at":"2017-05-17T09:56:12Z","pushed_at":"2017-06-02T07:37:16Z","git_url":"git://github.com/hawkingrei/tidb.git","ssh_url":"[email protected]:hawkingrei/tidb.git","clone_url":"https://github.com/hawkingrei/tidb.git","svn_url":"https://github.com/hawkingrei/tidb","homepage":"","size":24793,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"01dd725090d482f6e9de31ed9237c8966ed4e8b1","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars0.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars0.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2017-06-02T06:44:46Z","pushed_at":"2017-06-02T07:37:18Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"[email protected]:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"","size":25375,"stargazers_count":8237,"watchers_count":8237,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1090,"mirror_url":null,"open_issues_count":182,"forks":1090,"open_issues":182,"watchers":8237,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/3290"},"html":{"href":"https://github.com/pingcap/tidb/pull/3290"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/3290"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/3290/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/3290/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/3290/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/2256ea2b5a74fab2b9f2b80483143c0636a6c94e"}}}} | {
"id": 41986369,
"name": "pingcap/tidb",
"url": "https://api.github.com/repos/pingcap/tidb"
} | {
"id": 3427324,
"login": "hawkingrei",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3427324?",
"url": "https://api.github.com/users/hawkingrei"
} | {
"id": 11855343,
"login": "pingcap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11855343?",
"url": "https://api.github.com/orgs/pingcap"
} | 2017-06-02T08:05:23 | 5989258578 | {"actor":{"display_login":"hawkingrei"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/104872541","pull_request_review_id":25725844,"id":104872541,"diff_hunk":"@@ -254,6 +254,31 @@ func (s *testRegionCacheSuite) TestRequestFail(c *C) {\n \tc.Assert(region.unreachableStores, HasLen, 0)\n }\n \n+func (s *testRegionCacheSuite) TestRequestFail2(c *C) {\n+\t// key range: ['' - 'm' - 'z']\n+\tregion2 := s.cluster.AllocID()\n+\tnewPeers := s.cluster.AllocIDs(2)\n+\ts.cluster.Split(s.region1, region2, []byte(\"m\"), newPeers, newPeers[0])\n+\n+\t// Check the two regions.\n+\tloc1, err := s.cache.LocateKey(s.bo, []byte(\"a\"))\n+\tc.Assert(err, IsNil)\n+\tc.Assert(loc1.Region.id, Equals, s.region1)\n+\tloc2, err := s.cache.LocateKey(s.bo, []byte(\"x\"))\n+\tc.Assert(err, IsNil)\n+\tc.Assert(loc2.Region.id, Equals, region2)\n+\n+\t// Request should fail on region1.\n+\tctx, _ := s.cache.GetRPCContext(s.bo, loc1.Region)\n+\tc.Assert(s.cache.storeMu.stores, HasLen, 1)\n+\ts.checkCache(c, 2)\n+\ts.cache.OnRequestFail(ctx)\n+\t// Both region2 and store should be dropped from cache.\n+\tc.Assert(s.cache.storeMu.stores, HasLen, 0)\n+\tc.Assert(s.cache.getRegionFromCache([]byte(\"x\")), IsNil)\n+\ts.checkCache(c, 1)","path":"store/tikv/region_cache_test.go","position":35,"original_position":35,"commit_id":"34b531210a8849cb5199ecc7cf0f639d5aaaa0a1","original_commit_id":"34b531210a8849cb5199ecc7cf0f639d5aaaa0a1","user":{"login":"disksing","id":12077877,"avatar_url":"https://avatars2.githubusercontent.com/u/12077877?v=3","gravatar_id":"","url":"https://api.github.com/users/disksing","html_url":"https://github.com/disksing","followers_url":"https://api.github.com/users/disksing/followers","following_url":"https://api.github.com/users/disksing/following{/other_user}","gists_url":"https://api.github.com/users/disksing/gists{/gist_id}","starred_url":"https://api.github.com/users/disksing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/disksing/subscriptions","organizations_url":"https://api.github.com/users/disksing/orgs","repos_url":"https://api.github.com/users/disksing/repos","events_url":"https://api.github.com/users/disksing/events{/privacy}","received_events_url":"https://api.github.com/users/disksing/received_events","type":"User","site_admin":false},"body":"region1 is not removed, we have to try its other peers before reload it from pd, because pd may not be updated in time.","created_at":"2017-03-08T09:06:09Z","updated_at":"2017-03-08T09:06:10Z","html_url":"https://github.com/pingcap/tidb/pull/2792#discussion_r104872541","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/2792","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/104872541"},"html":{"href":"https://github.com/pingcap/tidb/pull/2792#discussion_r104872541"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/2792"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/2792","id":109460137,"html_url":"https://github.com/pingcap/tidb/pull/2792","diff_url":"https://github.com/pingcap/tidb/pull/2792.diff","patch_url":"https://github.com/pingcap/tidb/pull/2792.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/2792","number":2792,"state":"open","locked":false,"title":"store/tikv: drop the unreachable store's regions from cache.","user":{"login":"disksing","id":12077877,"avatar_url":"https://avatars2.githubusercontent.com/u/12077877?v=3","gravatar_id":"","url":"https://api.github.com/users/disksing","html_url":"https://github.com/disksing","followers_url":"https://api.github.com/users/disksing/followers","following_url":"https://api.github.com/users/disksing/following{/other_user}","gists_url":"https://api.github.com/users/disksing/gists{/gist_id}","starred_url":"https://api.github.com/users/disksing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/disksing/subscriptions","organizations_url":"https://api.github.com/users/disksing/orgs","repos_url":"https://api.github.com/users/disksing/repos","events_url":"https://api.github.com/users/disksing/events{/privacy}","received_events_url":"https://api.github.com/users/disksing/received_events","type":"User","site_admin":false},"body":"When a store is down and it contains a lot of regions (maybe up to 10k+), tidb will suffer from \"connection refused\" error for a long time.\r\n\r\ncc @AndreMouche @shenli @hhkbp2 ","created_at":"2017-03-07T11:34:18Z","updated_at":"2017-03-08T09:06:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f67775777148c56fc33f0cea0cbb7965c2fa7ac7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/2792/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/2792/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/2792/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/34b531210a8849cb5199ecc7cf0f639d5aaaa0a1","head":{"label":"pingcap:disksing/request-fail","ref":"disksing/request-fail","sha":"34b531210a8849cb5199ecc7cf0f639d5aaaa0a1","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars0.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars0.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2017-03-08T08:19:07Z","pushed_at":"2017-03-08T08:52:12Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"[email protected]:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"","size":21863,"stargazers_count":7135,"watchers_count":7135,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":898,"mirror_url":null,"open_issues_count":181,"forks":898,"open_issues":181,"watchers":7135,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"abe4413bb400c3634e044a08fe2c664e896a1f40","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars0.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars0.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2017-03-08T08:19:07Z","pushed_at":"2017-03-08T08:52:12Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"[email protected]:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"","size":21863,"stargazers_count":7135,"watchers_count":7135,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":898,"mirror_url":null,"open_issues_count":181,"forks":898,"open_issues":181,"watchers":7135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/2792"},"html":{"href":"https://github.com/pingcap/tidb/pull/2792"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/2792"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/2792/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/2792/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/2792/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/34b531210a8849cb5199ecc7cf0f639d5aaaa0a1"}}}} | {
"id": 41986369,
"name": "pingcap/tidb",
"url": "https://api.github.com/repos/pingcap/tidb"
} | {
"id": 12077877,
"login": "disksing",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12077877?",
"url": "https://api.github.com/users/disksing"
} | {
"id": 11855343,
"login": "pingcap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11855343?",
"url": "https://api.github.com/orgs/pingcap"
} | 2017-03-08T09:06:09 | 5453739736 | {"actor":{"display_login":"disksing"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/rust-rocksdb/pulls/comments/122364920","pull_request_review_id":44475011,"id":122364920,"diff_hunk":"@@ -2188,6 +2195,103 @@ DB::RunManualCompaction\n custom cache\n table_properties_collectors\n */\n+struct crocksdb_tablepropertiescollectorfactorycontext_t {\n+ TablePropertiesCollectorFactory::Context rep;\n+};\n+\n+struct crocksdb_tablepropertiescollector_t : public TablePropertiesCollector {\n+ void *state_;\n+ void (*destructor_)(void *);\n+ void (*add_userkey_)(\n+ void *,\n+ const char *key, size_t key_length,\n+ const char *value, size_t value_length,\n+ int entry_type, uint64_t seq,\n+ uint64_t file_size);\n+ void (*finish_)(void *, char **keys, int *key_count, char **value, int *value_count);\n+ void (*readable_properties_)(void *);\n+ unsigned char need_compact_;\n+ const char *(*name_)(void *);\n+\n+ virtual ~crocksdb_tablepropertiescollector_t() {\n+ (*destructor_)(state_);\n+ }\n+\n+ virtual Status AddUserKey(const Slice &key, const Slice &value,\n+ EntryType type, SequenceNumber seq,\n+ uint64_t file_size) override {\n+ // For backwards-compatibility.\n+ (*add_userkey_)(\n+ state_,\n+ key.data(), key.size(),\n+ value.data(), value.size(),\n+ type,\n+ seq,\n+ file_size);\n+ return Status::OK();\n+ }\n+\n+ virtual Status Finish(UserCollectedProperties *properties) override {\n+ char **keys, **values;\n+ int keys_count, value_count;\n+ (*finish_)(state_, keys, &keys_count, values, &value_count);\n+ if (keys == NULL || values == NULL) {\n+ return Status::OK();\n+ }\n+ assert(keys_count == value_count);\n+ for (int i = 0; i < keys_count; i++) {\n+ properties->insert(std::make_pair(std::string(keys[i]), std::string(values[i])));\n+ free(keys[i]);\n+ free(values[i]);\n+ }\n+ // free the memory\n+ free(keys);\n+ free(values);\n+ return Status::OK();\n+ }\n+\n+ virtual UserCollectedProperties GetReadableProperties() const override {\n+ (*readable_properties_)(state_);\n+ return UserCollectedProperties{};\n+ }\n+\n+ virtual bool NeedCompact() const override { return need_compact_; }\n+\n+ virtual const char *Name() const override {\n+ return (*name_)(state_);\n+ }\n+};\n+\n+struct crocksdb_tablepropertiescollectorfactory_t : public TablePropertiesCollectorFactory {\n+ void *state_;\n+ void (*destructor_)(void *);\n+ crocksdb_tablepropertiescollector_t *(*create_table_properties_collector_)(\n+ void *, crocksdb_tablepropertiescollectorfactorycontext_t *context);\n+ const char *(*name_)(void *);\n+\n+ virtual ~crocksdb_tablepropertiescollectorfactory_t() { (*destructor_)(state_); }\n+\n+ virtual TablePropertiesCollector *CreateTablePropertiesCollector(\n+ TablePropertiesCollectorFactory::Context context) {\n+ crocksdb_tablepropertiescollectorfactorycontext_t ccontext;\n+ ccontext.rep = context;","path":"librocksdb_sys/crocksdb/c.cc","position":104,"original_position":104,"commit_id":"65c228b9c05abe99b4d7ca6ee371c484926cfe58","original_commit_id":"65c228b9c05abe99b4d7ca6ee371c484926cfe58","user":{"login":"andelf","id":72891,"avatar_url":"https://avatars2.githubusercontent.com/u/72891?v=3","gravatar_id":"","url":"https://api.github.com/users/andelf","html_url":"https://github.com/andelf","followers_url":"https://api.github.com/users/andelf/followers","following_url":"https://api.github.com/users/andelf/following{/other_user}","gists_url":"https://api.github.com/users/andelf/gists{/gist_id}","starred_url":"https://api.github.com/users/andelf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andelf/subscriptions","organizations_url":"https://api.github.com/users/andelf/orgs","repos_url":"https://api.github.com/users/andelf/repos","events_url":"https://api.github.com/users/andelf/events{/privacy}","received_events_url":"https://api.github.com/users/andelf/received_events","type":"User","site_admin":false},"body":"So an extra member access function is needed? For accessing context.column_family?","created_at":"2017-06-16T05:09:58Z","updated_at":"2017-06-16T05:09:58Z","html_url":"https://github.com/pingcap/rust-rocksdb/pull/66#discussion_r122364920","pull_request_url":"https://api.github.com/repos/pingcap/rust-rocksdb/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/pingcap/rust-rocksdb/pulls/comments/122364920"},"html":{"href":"https://github.com/pingcap/rust-rocksdb/pull/66#discussion_r122364920"},"pull_request":{"href":"https://api.github.com/repos/pingcap/rust-rocksdb/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/rust-rocksdb/pulls/66","id":125956203,"html_url":"https://github.com/pingcap/rust-rocksdb/pull/66","diff_url":"https://github.com/pingcap/rust-rocksdb/pull/66.diff","patch_url":"https://github.com/pingcap/rust-rocksdb/pull/66.patch","issue_url":"https://api.github.com/repos/pingcap/rust-rocksdb/issues/66","number":66,"state":"open","locked":false,"title":"Add user properties C API","user":{"login":"follitude","id":26425788,"avatar_url":"https://avatars1.githubusercontent.com/u/26425788?v=3","gravatar_id":"","url":"https://api.github.com/users/follitude","html_url":"https://github.com/follitude","followers_url":"https://api.github.com/users/follitude/followers","following_url":"https://api.github.com/users/follitude/following{/other_user}","gists_url":"https://api.github.com/users/follitude/gists{/gist_id}","starred_url":"https://api.github.com/users/follitude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/follitude/subscriptions","organizations_url":"https://api.github.com/users/follitude/orgs","repos_url":"https://api.github.com/users/follitude/repos","events_url":"https://api.github.com/users/follitude/events{/privacy}","received_events_url":"https://api.github.com/users/follitude/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-16T04:11:50Z","updated_at":"2017-06-16T05:09:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7eaa1459a8d715eec0eaa3ac9b5397bb3a63ea7f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zhangjinpeng1987","id":19700528,"avatar_url":"https://avatars1.githubusercontent.com/u/19700528?v=3","gravatar_id":"","url":"https://api.github.com/users/zhangjinpeng1987","html_url":"https://github.com/zhangjinpeng1987","followers_url":"https://api.github.com/users/zhangjinpeng1987/followers","following_url":"https://api.github.com/users/zhangjinpeng1987/following{/other_user}","gists_url":"https://api.github.com/users/zhangjinpeng1987/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangjinpeng1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangjinpeng1987/subscriptions","organizations_url":"https://api.github.com/users/zhangjinpeng1987/orgs","repos_url":"https://api.github.com/users/zhangjinpeng1987/repos","events_url":"https://api.github.com/users/zhangjinpeng1987/events{/privacy}","received_events_url":"https://api.github.com/users/zhangjinpeng1987/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/rust-rocksdb/pulls/66/commits","review_comments_url":"https://api.github.com/repos/pingcap/rust-rocksdb/pulls/66/comments","review_comment_url":"https://api.github.com/repos/pingcap/rust-rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/rust-rocksdb/issues/66/comments","statuses_url":"https://api.github.com/repos/pingcap/rust-rocksdb/statuses/65c228b9c05abe99b4d7ca6ee371c484926cfe58","head":{"label":"pingcap:yutong/user-properties-c","ref":"yutong/user-properties-c","sha":"65c228b9c05abe99b4d7ca6ee371c484926cfe58","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars0.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":78835813,"name":"rust-rocksdb","full_name":"pingcap/rust-rocksdb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars0.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/rust-rocksdb","description":"rust wrapper for rocksdb","fork":true,"url":"https://api.github.com/repos/pingcap/rust-rocksdb","forks_url":"https://api.github.com/repos/pingcap/rust-rocksdb/forks","keys_url":"https://api.github.com/repos/pingcap/rust-rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/rust-rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/rust-rocksdb/teams","hooks_url":"https://api.github.com/repos/pingcap/rust-rocksdb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/rust-rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/rust-rocksdb/events","assignees_url":"https://api.github.com/repos/pingcap/rust-rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/rust-rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/rust-rocksdb/tags","blobs_url":"https://api.github.com/repos/pingcap/rust-rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/rust-rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/rust-rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/rust-rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/rust-rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/rust-rocksdb/languages","stargazers_url":"https://api.github.com/repos/pingcap/rust-rocksdb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/rust-rocksdb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/rust-rocksdb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/rust-rocksdb/subscription","commits_url":"https://api.github.com/repos/pingcap/rust-rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/rust-rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/rust-rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/rust-rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/rust-rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/rust-rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/rust-rocksdb/merges","archive_url":"https://api.github.com/repos/pingcap/rust-rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/rust-rocksdb/downloads","issues_url":"https://api.github.com/repos/pingcap/rust-rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/rust-rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/rust-rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/rust-rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/rust-rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/rust-rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/rust-rocksdb/deployments","created_at":"2017-01-13T09:39:24Z","updated_at":"2017-06-02T13:50:16Z","pushed_at":"2017-06-16T04:11:50Z","git_url":"git://github.com/pingcap/rust-rocksdb.git","ssh_url":"[email protected]:pingcap/rust-rocksdb.git","clone_url":"https://github.com/pingcap/rust-rocksdb.git","svn_url":"https://github.com/pingcap/rust-rocksdb","homepage":null,"size":1499,"stargazers_count":12,"watchers_count":12,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":12,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"62741f9e6e5a8bef365245847b09e600eb848ee6","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars0.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":78835813,"name":"rust-rocksdb","full_name":"pingcap/rust-rocksdb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars0.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/rust-rocksdb","description":"rust wrapper for rocksdb","fork":true,"url":"https://api.github.com/repos/pingcap/rust-rocksdb","forks_url":"https://api.github.com/repos/pingcap/rust-rocksdb/forks","keys_url":"https://api.github.com/repos/pingcap/rust-rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/rust-rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/rust-rocksdb/teams","hooks_url":"https://api.github.com/repos/pingcap/rust-rocksdb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/rust-rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/rust-rocksdb/events","assignees_url":"https://api.github.com/repos/pingcap/rust-rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/rust-rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/rust-rocksdb/tags","blobs_url":"https://api.github.com/repos/pingcap/rust-rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/rust-rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/rust-rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/rust-rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/rust-rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/rust-rocksdb/languages","stargazers_url":"https://api.github.com/repos/pingcap/rust-rocksdb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/rust-rocksdb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/rust-rocksdb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/rust-rocksdb/subscription","commits_url":"https://api.github.com/repos/pingcap/rust-rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/rust-rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/rust-rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/rust-rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/rust-rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/rust-rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/rust-rocksdb/merges","archive_url":"https://api.github.com/repos/pingcap/rust-rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/rust-rocksdb/downloads","issues_url":"https://api.github.com/repos/pingcap/rust-rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/rust-rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/rust-rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/rust-rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/rust-rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/rust-rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/rust-rocksdb/deployments","created_at":"2017-01-13T09:39:24Z","updated_at":"2017-06-02T13:50:16Z","pushed_at":"2017-06-16T04:11:50Z","git_url":"git://github.com/pingcap/rust-rocksdb.git","ssh_url":"[email protected]:pingcap/rust-rocksdb.git","clone_url":"https://github.com/pingcap/rust-rocksdb.git","svn_url":"https://github.com/pingcap/rust-rocksdb","homepage":null,"size":1499,"stargazers_count":12,"watchers_count":12,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/rust-rocksdb/pulls/66"},"html":{"href":"https://github.com/pingcap/rust-rocksdb/pull/66"},"issue":{"href":"https://api.github.com/repos/pingcap/rust-rocksdb/issues/66"},"comments":{"href":"https://api.github.com/repos/pingcap/rust-rocksdb/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/rust-rocksdb/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/rust-rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/rust-rocksdb/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/rust-rocksdb/statuses/65c228b9c05abe99b4d7ca6ee371c484926cfe58"}}}} | {
"id": 78835813,
"name": "pingcap/rust-rocksdb",
"url": "https://api.github.com/repos/pingcap/rust-rocksdb"
} | {
"id": 72891,
"login": "andelf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/72891?",
"url": "https://api.github.com/users/andelf"
} | {
"id": 11855343,
"login": "pingcap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11855343?",
"url": "https://api.github.com/orgs/pingcap"
} | 2017-06-16T05:09:58 | 6077649718 | {"actor":{"display_login":"andelf"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/plaidev/easy-dc-dash/pulls/comments/121903312","pull_request_review_id":43968091,"id":121903312,"diff_hunk":"@@ -97,8 +97,10 @@ export default {\n \n </script>\n \n-<style scoped>\n-.pie-label-group text {\n- pointer-events: none;\n+<style lang=\"less\" module>\n+.chart-root {","path":"libs/chart/segment-pie.vue","position":8,"original_position":8,"commit_id":"a8726d314ddddab80f08664745b6c4c9f374e2d5","original_commit_id":"a8726d314ddddab80f08664745b6c4c9f374e2d5","user":{"login":"elcih17","id":17084445,"avatar_url":"https://avatars0.githubusercontent.com/u/17084445?v=3","gravatar_id":"","url":"https://api.github.com/users/elcih17","html_url":"https://github.com/elcih17","followers_url":"https://api.github.com/users/elcih17/followers","following_url":"https://api.github.com/users/elcih17/following{/other_user}","gists_url":"https://api.github.com/users/elcih17/gists{/gist_id}","starred_url":"https://api.github.com/users/elcih17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elcih17/subscriptions","organizations_url":"https://api.github.com/users/elcih17/orgs","repos_url":"https://api.github.com/users/elcih17/repos","events_url":"https://api.github.com/users/elcih17/events{/privacy}","received_events_url":"https://api.github.com/users/elcih17/received_events","type":"User","site_admin":false},"body":":global が抜けてますかね？","created_at":"2017-06-14T09:49:21Z","updated_at":"2017-06-14T09:52:25Z","html_url":"https://github.com/plaidev/easy-dc-dash/pull/43#discussion_r121903312","pull_request_url":"https://api.github.com/repos/plaidev/easy-dc-dash/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/plaidev/easy-dc-dash/pulls/comments/121903312"},"html":{"href":"https://github.com/plaidev/easy-dc-dash/pull/43#discussion_r121903312"},"pull_request":{"href":"https://api.github.com/repos/plaidev/easy-dc-dash/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/plaidev/easy-dc-dash/pulls/43","id":125515577,"html_url":"https://github.com/plaidev/easy-dc-dash/pull/43","diff_url":"https://github.com/plaidev/easy-dc-dash/pull/43.diff","patch_url":"https://github.com/plaidev/easy-dc-dash/pull/43.patch","issue_url":"https://api.github.com/repos/plaidev/easy-dc-dash/issues/43","number":43,"state":"open","locked":false,"title":"CSSのローカライズが働くようにする","user":{"login":"otolab","id":6499878,"avatar_url":"https://avatars3.githubusercontent.com/u/6499878?v=3","gravatar_id":"","url":"https://api.github.com/users/otolab","html_url":"https://github.com/otolab","followers_url":"https://api.github.com/users/otolab/followers","following_url":"https://api.github.com/users/otolab/following{/other_user}","gists_url":"https://api.github.com/users/otolab/gists{/gist_id}","starred_url":"https://api.github.com/users/otolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otolab/subscriptions","organizations_url":"https://api.github.com/users/otolab/orgs","repos_url":"https://api.github.com/users/otolab/repos","events_url":"https://api.github.com/users/otolab/events{/privacy}","received_events_url":"https://api.github.com/users/otolab/received_events","type":"User","site_admin":false},"body":"refs #42 ","created_at":"2017-06-14T05:51:59Z","updated_at":"2017-06-14T09:52:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d42d550e3fdd7c6f7f57f12cc479484557fe5ce8","assignee":{"login":"elcih17","id":17084445,"avatar_url":"https://avatars0.githubusercontent.com/u/17084445?v=3","gravatar_id":"","url":"https://api.github.com/users/elcih17","html_url":"https://github.com/elcih17","followers_url":"https://api.github.com/users/elcih17/followers","following_url":"https://api.github.com/users/elcih17/following{/other_user}","gists_url":"https://api.github.com/users/elcih17/gists{/gist_id}","starred_url":"https://api.github.com/users/elcih17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elcih17/subscriptions","organizations_url":"https://api.github.com/users/elcih17/orgs","repos_url":"https://api.github.com/users/elcih17/repos","events_url":"https://api.github.com/users/elcih17/events{/privacy}","received_events_url":"https://api.github.com/users/elcih17/received_events","type":"User","site_admin":false},"assignees":[{"login":"elcih17","id":17084445,"avatar_url":"https://avatars0.githubusercontent.com/u/17084445?v=3","gravatar_id":"","url":"https://api.github.com/users/elcih17","html_url":"https://github.com/elcih17","followers_url":"https://api.github.com/users/elcih17/followers","following_url":"https://api.github.com/users/elcih17/following{/other_user}","gists_url":"https://api.github.com/users/elcih17/gists{/gist_id}","starred_url":"https://api.github.com/users/elcih17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elcih17/subscriptions","organizations_url":"https://api.github.com/users/elcih17/orgs","repos_url":"https://api.github.com/users/elcih17/repos","events_url":"https://api.github.com/users/elcih17/events{/privacy}","received_events_url":"https://api.github.com/users/elcih17/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/plaidev/easy-dc-dash/pulls/43/commits","review_comments_url":"https://api.github.com/repos/plaidev/easy-dc-dash/pulls/43/comments","review_comment_url":"https://api.github.com/repos/plaidev/easy-dc-dash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plaidev/easy-dc-dash/issues/43/comments","statuses_url":"https://api.github.com/repos/plaidev/easy-dc-dash/statuses/a8726d314ddddab80f08664745b6c4c9f374e2d5","head":{"label":"plaidev:feature/42","ref":"feature/42","sha":"a8726d314ddddab80f08664745b6c4c9f374e2d5","user":{"login":"plaidev","id":5219279,"avatar_url":"https://avatars3.githubusercontent.com/u/5219279?v=3","gravatar_id":"","url":"https://api.github.com/users/plaidev","html_url":"https://github.com/plaidev","followers_url":"https://api.github.com/users/plaidev/followers","following_url":"https://api.github.com/users/plaidev/following{/other_user}","gists_url":"https://api.github.com/users/plaidev/gists{/gist_id}","starred_url":"https://api.github.com/users/plaidev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plaidev/subscriptions","organizations_url":"https://api.github.com/users/plaidev/orgs","repos_url":"https://api.github.com/users/plaidev/repos","events_url":"https://api.github.com/users/plaidev/events{/privacy}","received_events_url":"https://api.github.com/users/plaidev/received_events","type":"Organization","site_admin":false},"repo":{"id":87900730,"name":"easy-dc-dash","full_name":"plaidev/easy-dc-dash","owner":{"login":"plaidev","id":5219279,"avatar_url":"https://avatars3.githubusercontent.com/u/5219279?v=3","gravatar_id":"","url":"https://api.github.com/users/plaidev","html_url":"https://github.com/plaidev","followers_url":"https://api.github.com/users/plaidev/followers","following_url":"https://api.github.com/users/plaidev/following{/other_user}","gists_url":"https://api.github.com/users/plaidev/gists{/gist_id}","starred_url":"https://api.github.com/users/plaidev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plaidev/subscriptions","organizations_url":"https://api.github.com/users/plaidev/orgs","repos_url":"https://api.github.com/users/plaidev/repos","events_url":"https://api.github.com/users/plaidev/events{/privacy}","received_events_url":"https://api.github.com/users/plaidev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plaidev/easy-dc-dash","description":null,"fork":false,"url":"https://api.github.com/repos/plaidev/easy-dc-dash","forks_url":"https://api.github.com/repos/plaidev/easy-dc-dash/forks","keys_url":"https://api.github.com/repos/plaidev/easy-dc-dash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plaidev/easy-dc-dash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plaidev/easy-dc-dash/teams","hooks_url":"https://api.github.com/repos/plaidev/easy-dc-dash/hooks","issue_events_url":"https://api.github.com/repos/plaidev/easy-dc-dash/issues/events{/number}","events_url":"https://api.github.com/repos/plaidev/easy-dc-dash/events","assignees_url":"https://api.github.com/repos/plaidev/easy-dc-dash/assignees{/user}","branches_url":"https://api.github.com/repos/plaidev/easy-dc-dash/branches{/branch}","tags_url":"https://api.github.com/repos/plaidev/easy-dc-dash/tags","blobs_url":"https://api.github.com/repos/plaidev/easy-dc-dash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plaidev/easy-dc-dash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plaidev/easy-dc-dash/git/refs{/sha}","trees_url":"https://api.github.com/repos/plaidev/easy-dc-dash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plaidev/easy-dc-dash/statuses/{sha}","languages_url":"https://api.github.com/repos/plaidev/easy-dc-dash/languages","stargazers_url":"https://api.github.com/repos/plaidev/easy-dc-dash/stargazers","contributors_url":"https://api.github.com/repos/plaidev/easy-dc-dash/contributors","subscribers_url":"https://api.github.com/repos/plaidev/easy-dc-dash/subscribers","subscription_url":"https://api.github.com/repos/plaidev/easy-dc-dash/subscription","commits_url":"https://api.github.com/repos/plaidev/easy-dc-dash/commits{/sha}","git_commits_url":"https://api.github.com/repos/plaidev/easy-dc-dash/git/commits{/sha}","comments_url":"https://api.github.com/repos/plaidev/easy-dc-dash/comments{/number}","issue_comment_url":"https://api.github.com/repos/plaidev/easy-dc-dash/issues/comments{/number}","contents_url":"https://api.github.com/repos/plaidev/easy-dc-dash/contents/{+path}","compare_url":"https://api.github.com/repos/plaidev/easy-dc-dash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plaidev/easy-dc-dash/merges","archive_url":"https://api.github.com/repos/plaidev/easy-dc-dash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plaidev/easy-dc-dash/downloads","issues_url":"https://api.github.com/repos/plaidev/easy-dc-dash/issues{/number}","pulls_url":"https://api.github.com/repos/plaidev/easy-dc-dash/pulls{/number}","milestones_url":"https://api.github.com/repos/plaidev/easy-dc-dash/milestones{/number}","notifications_url":"https://api.github.com/repos/plaidev/easy-dc-dash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plaidev/easy-dc-dash/labels{/name}","releases_url":"https://api.github.com/repos/plaidev/easy-dc-dash/releases{/id}","deployments_url":"https://api.github.com/repos/plaidev/easy-dc-dash/deployments","created_at":"2017-04-11T06:58:30Z","updated_at":"2017-06-07T01:27:17Z","pushed_at":"2017-06-14T05:51:59Z","git_url":"git://github.com/plaidev/easy-dc-dash.git","ssh_url":"[email protected]:plaidev/easy-dc-dash.git","clone_url":"https://github.com/plaidev/easy-dc-dash.git","svn_url":"https://github.com/plaidev/easy-dc-dash","homepage":null,"size":4566,"stargazers_count":1,"watchers_count":1,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":11,"forks":2,"open_issues":11,"watchers":1,"default_branch":"master"}},"base":{"label":"plaidev:master","ref":"master","sha":"e15f3d95aebbaaf0c1eb6042a61938c8661c4a21","user":{"login":"plaidev","id":5219279,"avatar_url":"https://avatars3.githubusercontent.com/u/5219279?v=3","gravatar_id":"","url":"https://api.github.com/users/plaidev","html_url":"https://github.com/plaidev","followers_url":"https://api.github.com/users/plaidev/followers","following_url":"https://api.github.com/users/plaidev/following{/other_user}","gists_url":"https://api.github.com/users/plaidev/gists{/gist_id}","starred_url":"https://api.github.com/users/plaidev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plaidev/subscriptions","organizations_url":"https://api.github.com/users/plaidev/orgs","repos_url":"https://api.github.com/users/plaidev/repos","events_url":"https://api.github.com/users/plaidev/events{/privacy}","received_events_url":"https://api.github.com/users/plaidev/received_events","type":"Organization","site_admin":false},"repo":{"id":87900730,"name":"easy-dc-dash","full_name":"plaidev/easy-dc-dash","owner":{"login":"plaidev","id":5219279,"avatar_url":"https://avatars3.githubusercontent.com/u/5219279?v=3","gravatar_id":"","url":"https://api.github.com/users/plaidev","html_url":"https://github.com/plaidev","followers_url":"https://api.github.com/users/plaidev/followers","following_url":"https://api.github.com/users/plaidev/following{/other_user}","gists_url":"https://api.github.com/users/plaidev/gists{/gist_id}","starred_url":"https://api.github.com/users/plaidev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plaidev/subscriptions","organizations_url":"https://api.github.com/users/plaidev/orgs","repos_url":"https://api.github.com/users/plaidev/repos","events_url":"https://api.github.com/users/plaidev/events{/privacy}","received_events_url":"https://api.github.com/users/plaidev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plaidev/easy-dc-dash","description":null,"fork":false,"url":"https://api.github.com/repos/plaidev/easy-dc-dash","forks_url":"https://api.github.com/repos/plaidev/easy-dc-dash/forks","keys_url":"https://api.github.com/repos/plaidev/easy-dc-dash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plaidev/easy-dc-dash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plaidev/easy-dc-dash/teams","hooks_url":"https://api.github.com/repos/plaidev/easy-dc-dash/hooks","issue_events_url":"https://api.github.com/repos/plaidev/easy-dc-dash/issues/events{/number}","events_url":"https://api.github.com/repos/plaidev/easy-dc-dash/events","assignees_url":"https://api.github.com/repos/plaidev/easy-dc-dash/assignees{/user}","branches_url":"https://api.github.com/repos/plaidev/easy-dc-dash/branches{/branch}","tags_url":"https://api.github.com/repos/plaidev/easy-dc-dash/tags","blobs_url":"https://api.github.com/repos/plaidev/easy-dc-dash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plaidev/easy-dc-dash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plaidev/easy-dc-dash/git/refs{/sha}","trees_url":"https://api.github.com/repos/plaidev/easy-dc-dash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plaidev/easy-dc-dash/statuses/{sha}","languages_url":"https://api.github.com/repos/plaidev/easy-dc-dash/languages","stargazers_url":"https://api.github.com/repos/plaidev/easy-dc-dash/stargazers","contributors_url":"https://api.github.com/repos/plaidev/easy-dc-dash/contributors","subscribers_url":"https://api.github.com/repos/plaidev/easy-dc-dash/subscribers","subscription_url":"https://api.github.com/repos/plaidev/easy-dc-dash/subscription","commits_url":"https://api.github.com/repos/plaidev/easy-dc-dash/commits{/sha}","git_commits_url":"https://api.github.com/repos/plaidev/easy-dc-dash/git/commits{/sha}","comments_url":"https://api.github.com/repos/plaidev/easy-dc-dash/comments{/number}","issue_comment_url":"https://api.github.com/repos/plaidev/easy-dc-dash/issues/comments{/number}","contents_url":"https://api.github.com/repos/plaidev/easy-dc-dash/contents/{+path}","compare_url":"https://api.github.com/repos/plaidev/easy-dc-dash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plaidev/easy-dc-dash/merges","archive_url":"https://api.github.com/repos/plaidev/easy-dc-dash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plaidev/easy-dc-dash/downloads","issues_url":"https://api.github.com/repos/plaidev/easy-dc-dash/issues{/number}","pulls_url":"https://api.github.com/repos/plaidev/easy-dc-dash/pulls{/number}","milestones_url":"https://api.github.com/repos/plaidev/easy-dc-dash/milestones{/number}","notifications_url":"https://api.github.com/repos/plaidev/easy-dc-dash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plaidev/easy-dc-dash/labels{/name}","releases_url":"https://api.github.com/repos/plaidev/easy-dc-dash/releases{/id}","deployments_url":"https://api.github.com/repos/plaidev/easy-dc-dash/deployments","created_at":"2017-04-11T06:58:30Z","updated_at":"2017-06-07T01:27:17Z","pushed_at":"2017-06-14T05:51:59Z","git_url":"git://github.com/plaidev/easy-dc-dash.git","ssh_url":"[email protected]:plaidev/easy-dc-dash.git","clone_url":"https://github.com/plaidev/easy-dc-dash.git","svn_url":"https://github.com/plaidev/easy-dc-dash","homepage":null,"size":4566,"stargazers_count":1,"watchers_count":1,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":11,"forks":2,"open_issues":11,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plaidev/easy-dc-dash/pulls/43"},"html":{"href":"https://github.com/plaidev/easy-dc-dash/pull/43"},"issue":{"href":"https://api.github.com/repos/plaidev/easy-dc-dash/issues/43"},"comments":{"href":"https://api.github.com/repos/plaidev/easy-dc-dash/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/plaidev/easy-dc-dash/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/plaidev/easy-dc-dash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plaidev/easy-dc-dash/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/plaidev/easy-dc-dash/statuses/a8726d314ddddab80f08664745b6c4c9f374e2d5"}}}} | {
"id": 87900730,
"name": "plaidev/easy-dc-dash",
"url": "https://api.github.com/repos/plaidev/easy-dc-dash"
} | {
"id": 17084445,
"login": "elcih17",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17084445?",
"url": "https://api.github.com/users/elcih17"
} | {
"id": 5219279,
"login": "plaidev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5219279?",
"url": "https://api.github.com/orgs/plaidev"
} | 2017-06-14T09:49:21 | 6062625981 | {"actor":{"display_login":"elcih17"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/procore/particles/pulls/comments/149462534","pull_request_review_id":74856755,"id":149462534,"diff_hunk":"@@ -0,0 +1,36 @@\n+@import '../../shared/variables.scss';\n+\n+.banner {\n+ display: flex;\n+ align-items: center;\n+ color: $white;\n+ background: $info-blue;\n+ font-family: Roboto, 'Open Sans', Lato, sans-serif, Arial;\n+ height: 32px;\n+ padding: 0 24px;\n+ font-size: 15px;\n+ font-weight: bold;\n+}\n+\n+.info-icon {","path":"feedback-banner/src/FeedbackBanner.scss","position":15,"original_position":15,"commit_id":"cd8fcdf9b1288fe42e14191c6bb3889675e91047","original_commit_id":"cd8fcdf9b1288fe42e14191c6bb3889675e91047","user":{"login":"dancingshell","id":6993945,"avatar_url":"https://avatars3.githubusercontent.com/u/6993945?v=4","gravatar_id":"","url":"https://api.github.com/users/dancingshell","html_url":"https://github.com/dancingshell","followers_url":"https://api.github.com/users/dancingshell/followers","following_url":"https://api.github.com/users/dancingshell/following{/other_user}","gists_url":"https://api.github.com/users/dancingshell/gists{/gist_id}","starred_url":"https://api.github.com/users/dancingshell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dancingshell/subscriptions","organizations_url":"https://api.github.com/users/dancingshell/orgs","repos_url":"https://api.github.com/users/dancingshell/repos","events_url":"https://api.github.com/users/dancingshell/events{/privacy}","received_events_url":"https://api.github.com/users/dancingshell/received_events","type":"User","site_admin":false},"body":"nb: camelCase css names","created_at":"2017-11-07T18:34:17Z","updated_at":"2017-11-07T18:34:27Z","html_url":"https://github.com/procore/particles/pull/520#discussion_r149462534","pull_request_url":"https://api.github.com/repos/procore/particles/pulls/520","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/procore/particles/pulls/comments/149462534"},"html":{"href":"https://github.com/procore/particles/pull/520#discussion_r149462534"},"pull_request":{"href":"https://api.github.com/repos/procore/particles/pulls/520"}}},"pull_request":{"url":"https://api.github.com/repos/procore/particles/pulls/520","id":151046721,"html_url":"https://github.com/procore/particles/pull/520","diff_url":"https://github.com/procore/particles/pull/520.diff","patch_url":"https://github.com/procore/particles/pull/520.patch","issue_url":"https://api.github.com/repos/procore/particles/issues/520","number":520,"state":"open","locked":false,"title":"Feedback banner v 0.1.1","user":{"login":"Jacky-Lei","id":12858707,"avatar_url":"https://avatars2.githubusercontent.com/u/12858707?v=4","gravatar_id":"","url":"https://api.github.com/users/Jacky-Lei","html_url":"https://github.com/Jacky-Lei","followers_url":"https://api.github.com/users/Jacky-Lei/followers","following_url":"https://api.github.com/users/Jacky-Lei/following{/other_user}","gists_url":"https://api.github.com/users/Jacky-Lei/gists{/gist_id}","starred_url":"https://api.github.com/users/Jacky-Lei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jacky-Lei/subscriptions","organizations_url":"https://api.github.com/users/Jacky-Lei/orgs","repos_url":"https://api.github.com/users/Jacky-Lei/repos","events_url":"https://api.github.com/users/Jacky-Lei/events{/privacy}","received_events_url":"https://api.github.com/users/Jacky-Lei/received_events","type":"User","site_admin":false},"body":"### Summary\r\n- Title, tooltip text, button text, and button link can be configured through props. Thanks @mboperator for the `Button` and `Tooltip` atoms!\r\n\r\n### Related Issues\r\n- Built to be used initially for https://procoretech.atlassian.net/browse/CP-535\r\n\r\n### Screenshots\r\n<img width=\"1672\" alt=\"screen shot 2017-11-06 at 11 26 30 pm\" src=\"https://user-images.githubusercontent.com/12858707/32482909-9ef31300-c34e-11e7-8317-5ea933e4945d.png\">\r\n\r\n### Review Notes/ Questions/ TODOs\r\n- Check in with UX about positioning of tooltip\r\n- Check in with UX about button (size sm) no matching mock (https://procore.invisionapp.com/d/main/#/console/12148499/262028563/inspect)\r\n\r\n### Testing\r\n- [ ] Tooltip works\r\n- [ ] Button links correctly to forum","created_at":"2017-11-07T08:02:16Z","updated_at":"2017-11-07T18:34:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d4ee23c8a286956c9bcc5344a0e5cec6541ab17","assignee":{"login":"Jacky-Lei","id":12858707,"avatar_url":"https://avatars2.githubusercontent.com/u/12858707?v=4","gravatar_id":"","url":"https://api.github.com/users/Jacky-Lei","html_url":"https://github.com/Jacky-Lei","followers_url":"https://api.github.com/users/Jacky-Lei/followers","following_url":"https://api.github.com/users/Jacky-Lei/following{/other_user}","gists_url":"https://api.github.com/users/Jacky-Lei/gists{/gist_id}","starred_url":"https://api.github.com/users/Jacky-Lei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jacky-Lei/subscriptions","organizations_url":"https://api.github.com/users/Jacky-Lei/orgs","repos_url":"https://api.github.com/users/Jacky-Lei/repos","events_url":"https://api.github.com/users/Jacky-Lei/events{/privacy}","received_events_url":"https://api.github.com/users/Jacky-Lei/received_events","type":"User","site_admin":false},"assignees":[{"login":"Jacky-Lei","id":12858707,"avatar_url":"https://avatars2.githubusercontent.com/u/12858707?v=4","gravatar_id":"","url":"https://api.github.com/users/Jacky-Lei","html_url":"https://github.com/Jacky-Lei","followers_url":"https://api.github.com/users/Jacky-Lei/followers","following_url":"https://api.github.com/users/Jacky-Lei/following{/other_user}","gists_url":"https://api.github.com/users/Jacky-Lei/gists{/gist_id}","starred_url":"https://api.github.com/users/Jacky-Lei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jacky-Lei/subscriptions","organizations_url":"https://api.github.com/users/Jacky-Lei/orgs","repos_url":"https://api.github.com/users/Jacky-Lei/repos","events_url":"https://api.github.com/users/Jacky-Lei/events{/privacy}","received_events_url":"https://api.github.com/users/Jacky-Lei/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mboperator","id":1007233,"avatar_url":"https://avatars1.githubusercontent.com/u/1007233?v=4","gravatar_id":"","url":"https://api.github.com/users/mboperator","html_url":"https://github.com/mboperator","followers_url":"https://api.github.com/users/mboperator/followers","following_url":"https://api.github.com/users/mboperator/following{/other_user}","gists_url":"https://api.github.com/users/mboperator/gists{/gist_id}","starred_url":"https://api.github.com/users/mboperator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboperator/subscriptions","organizations_url":"https://api.github.com/users/mboperator/orgs","repos_url":"https://api.github.com/users/mboperator/repos","events_url":"https://api.github.com/users/mboperator/events{/privacy}","received_events_url":"https://api.github.com/users/mboperator/received_events","type":"User","site_admin":false},{"login":"rysmith","id":3280589,"avatar_url":"https://avatars0.githubusercontent.com/u/3280589?v=4","gravatar_id":"","url":"https://api.github.com/users/rysmith","html_url":"https://github.com/rysmith","followers_url":"https://api.github.com/users/rysmith/followers","following_url":"https://api.github.com/users/rysmith/following{/other_user}","gists_url":"https://api.github.com/users/rysmith/gists{/gist_id}","starred_url":"https://api.github.com/users/rysmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rysmith/subscriptions","organizations_url":"https://api.github.com/users/rysmith/orgs","repos_url":"https://api.github.com/users/rysmith/repos","events_url":"https://api.github.com/users/rysmith/events{/privacy}","received_events_url":"https://api.github.com/users/rysmith/received_events","type":"User","site_admin":false},{"login":"farism","id":3803714,"avatar_url":"https://avatars2.githubusercontent.com/u/3803714?v=4","gravatar_id":"","url":"https://api.github.com/users/farism","html_url":"https://github.com/farism","followers_url":"https://api.github.com/users/farism/followers","following_url":"https://api.github.com/users/farism/following{/other_user}","gists_url":"https://api.github.com/users/farism/gists{/gist_id}","starred_url":"https://api.github.com/users/farism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farism/subscriptions","organizations_url":"https://api.github.com/users/farism/orgs","repos_url":"https://api.github.com/users/farism/repos","events_url":"https://api.github.com/users/farism/events{/privacy}","received_events_url":"https://api.github.com/users/farism/received_events","type":"User","site_admin":false},{"login":"brock-noah","id":5582147,"avatar_url":"https://avatars2.githubusercontent.com/u/5582147?v=4","gravatar_id":"","url":"https://api.github.com/users/brock-noah","html_url":"https://github.com/brock-noah","followers_url":"https://api.github.com/users/brock-noah/followers","following_url":"https://api.github.com/users/brock-noah/following{/other_user}","gists_url":"https://api.github.com/users/brock-noah/gists{/gist_id}","starred_url":"https://api.github.com/users/brock-noah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brock-noah/subscriptions","organizations_url":"https://api.github.com/users/brock-noah/orgs","repos_url":"https://api.github.com/users/brock-noah/repos","events_url":"https://api.github.com/users/brock-noah/events{/privacy}","received_events_url":"https://api.github.com/users/brock-noah/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/procore/particles/pulls/520/commits","review_comments_url":"https://api.github.com/repos/procore/particles/pulls/520/comments","review_comment_url":"https://api.github.com/repos/procore/particles/pulls/comments{/number}","comments_url":"https://api.github.com/repos/procore/particles/issues/520/comments","statuses_url":"https://api.github.com/repos/procore/particles/statuses/cd8fcdf9b1288fe42e14191c6bb3889675e91047","head":{"label":"procore:feedback-banner-v-0.1.1","ref":"feedback-banner-v-0.1.1","sha":"cd8fcdf9b1288fe42e14191c6bb3889675e91047","user":{"login":"procore","id":145387,"avatar_url":"https://avatars1.githubusercontent.com/u/145387?v=4","gravatar_id":"","url":"https://api.github.com/users/procore","html_url":"https://github.com/procore","followers_url":"https://api.github.com/users/procore/followers","following_url":"https://api.github.com/users/procore/following{/other_user}","gists_url":"https://api.github.com/users/procore/gists{/gist_id}","starred_url":"https://api.github.com/users/procore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/procore/subscriptions","organizations_url":"https://api.github.com/users/procore/orgs","repos_url":"https://api.github.com/users/procore/repos","events_url":"https://api.github.com/users/procore/events{/privacy}","received_events_url":"https://api.github.com/users/procore/received_events","type":"Organization","site_admin":false},"repo":{"id":82836763,"name":"particles","full_name":"procore/particles","owner":{"login":"procore","id":145387,"avatar_url":"https://avatars1.githubusercontent.com/u/145387?v=4","gravatar_id":"","url":"https://api.github.com/users/procore","html_url":"https://github.com/procore","followers_url":"https://api.github.com/users/procore/followers","following_url":"https://api.github.com/users/procore/following{/other_user}","gists_url":"https://api.github.com/users/procore/gists{/gist_id}","starred_url":"https://api.github.com/users/procore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/procore/subscriptions","organizations_url":"https://api.github.com/users/procore/orgs","repos_url":"https://api.github.com/users/procore/repos","events_url":"https://api.github.com/users/procore/events{/privacy}","received_events_url":"https://api.github.com/users/procore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/procore/particles","description":"Simple. Isolated. Agnostic.","fork":false,"url":"https://api.github.com/repos/procore/particles","forks_url":"https://api.github.com/repos/procore/particles/forks","keys_url":"https://api.github.com/repos/procore/particles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/procore/particles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/procore/particles/teams","hooks_url":"https://api.github.com/repos/procore/particles/hooks","issue_events_url":"https://api.github.com/repos/procore/particles/issues/events{/number}","events_url":"https://api.github.com/repos/procore/particles/events","assignees_url":"https://api.github.com/repos/procore/particles/assignees{/user}","branches_url":"https://api.github.com/repos/procore/particles/branches{/branch}","tags_url":"https://api.github.com/repos/procore/particles/tags","blobs_url":"https://api.github.com/repos/procore/particles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/procore/particles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/procore/particles/git/refs{/sha}","trees_url":"https://api.github.com/repos/procore/particles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/procore/particles/statuses/{sha}","languages_url":"https://api.github.com/repos/procore/particles/languages","stargazers_url":"https://api.github.com/repos/procore/particles/stargazers","contributors_url":"https://api.github.com/repos/procore/particles/contributors","subscribers_url":"https://api.github.com/repos/procore/particles/subscribers","subscription_url":"https://api.github.com/repos/procore/particles/subscription","commits_url":"https://api.github.com/repos/procore/particles/commits{/sha}","git_commits_url":"https://api.github.com/repos/procore/particles/git/commits{/sha}","comments_url":"https://api.github.com/repos/procore/particles/comments{/number}","issue_comment_url":"https://api.github.com/repos/procore/particles/issues/comments{/number}","contents_url":"https://api.github.com/repos/procore/particles/contents/{+path}","compare_url":"https://api.github.com/repos/procore/particles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/procore/particles/merges","archive_url":"https://api.github.com/repos/procore/particles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/procore/particles/downloads","issues_url":"https://api.github.com/repos/procore/particles/issues{/number}","pulls_url":"https://api.github.com/repos/procore/particles/pulls{/number}","milestones_url":"https://api.github.com/repos/procore/particles/milestones{/number}","notifications_url":"https://api.github.com/repos/procore/particles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/procore/particles/labels{/name}","releases_url":"https://api.github.com/repos/procore/particles/releases{/id}","deployments_url":"https://api.github.com/repos/procore/particles/deployments","created_at":"2017-02-22T18:07:59Z","updated_at":"2017-11-06T23:58:45Z","pushed_at":"2017-11-07T17:37:06Z","git_url":"git://github.com/procore/particles.git","ssh_url":"[email protected]:procore/particles.git","clone_url":"https://github.com/procore/particles.git","svn_url":"https://github.com/procore/particles","homepage":"","size":7409,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":25,"forks":5,"open_issues":25,"watchers":16,"default_branch":"master"}},"base":{"label":"procore:master","ref":"master","sha":"42f36ef8be0579d0a388bd040fd4d80a1c26a370","user":{"login":"procore","id":145387,"avatar_url":"https://avatars1.githubusercontent.com/u/145387?v=4","gravatar_id":"","url":"https://api.github.com/users/procore","html_url":"https://github.com/procore","followers_url":"https://api.github.com/users/procore/followers","following_url":"https://api.github.com/users/procore/following{/other_user}","gists_url":"https://api.github.com/users/procore/gists{/gist_id}","starred_url":"https://api.github.com/users/procore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/procore/subscriptions","organizations_url":"https://api.github.com/users/procore/orgs","repos_url":"https://api.github.com/users/procore/repos","events_url":"https://api.github.com/users/procore/events{/privacy}","received_events_url":"https://api.github.com/users/procore/received_events","type":"Organization","site_admin":false},"repo":{"id":82836763,"name":"particles","full_name":"procore/particles","owner":{"login":"procore","id":145387,"avatar_url":"https://avatars1.githubusercontent.com/u/145387?v=4","gravatar_id":"","url":"https://api.github.com/users/procore","html_url":"https://github.com/procore","followers_url":"https://api.github.com/users/procore/followers","following_url":"https://api.github.com/users/procore/following{/other_user}","gists_url":"https://api.github.com/users/procore/gists{/gist_id}","starred_url":"https://api.github.com/users/procore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/procore/subscriptions","organizations_url":"https://api.github.com/users/procore/orgs","repos_url":"https://api.github.com/users/procore/repos","events_url":"https://api.github.com/users/procore/events{/privacy}","received_events_url":"https://api.github.com/users/procore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/procore/particles","description":"Simple. Isolated. Agnostic.","fork":false,"url":"https://api.github.com/repos/procore/particles","forks_url":"https://api.github.com/repos/procore/particles/forks","keys_url":"https://api.github.com/repos/procore/particles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/procore/particles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/procore/particles/teams","hooks_url":"https://api.github.com/repos/procore/particles/hooks","issue_events_url":"https://api.github.com/repos/procore/particles/issues/events{/number}","events_url":"https://api.github.com/repos/procore/particles/events","assignees_url":"https://api.github.com/repos/procore/particles/assignees{/user}","branches_url":"https://api.github.com/repos/procore/particles/branches{/branch}","tags_url":"https://api.github.com/repos/procore/particles/tags","blobs_url":"https://api.github.com/repos/procore/particles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/procore/particles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/procore/particles/git/refs{/sha}","trees_url":"https://api.github.com/repos/procore/particles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/procore/particles/statuses/{sha}","languages_url":"https://api.github.com/repos/procore/particles/languages","stargazers_url":"https://api.github.com/repos/procore/particles/stargazers","contributors_url":"https://api.github.com/repos/procore/particles/contributors","subscribers_url":"https://api.github.com/repos/procore/particles/subscribers","subscription_url":"https://api.github.com/repos/procore/particles/subscription","commits_url":"https://api.github.com/repos/procore/particles/commits{/sha}","git_commits_url":"https://api.github.com/repos/procore/particles/git/commits{/sha}","comments_url":"https://api.github.com/repos/procore/particles/comments{/number}","issue_comment_url":"https://api.github.com/repos/procore/particles/issues/comments{/number}","contents_url":"https://api.github.com/repos/procore/particles/contents/{+path}","compare_url":"https://api.github.com/repos/procore/particles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/procore/particles/merges","archive_url":"https://api.github.com/repos/procore/particles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/procore/particles/downloads","issues_url":"https://api.github.com/repos/procore/particles/issues{/number}","pulls_url":"https://api.github.com/repos/procore/particles/pulls{/number}","milestones_url":"https://api.github.com/repos/procore/particles/milestones{/number}","notifications_url":"https://api.github.com/repos/procore/particles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/procore/particles/labels{/name}","releases_url":"https://api.github.com/repos/procore/particles/releases{/id}","deployments_url":"https://api.github.com/repos/procore/particles/deployments","created_at":"2017-02-22T18:07:59Z","updated_at":"2017-11-06T23:58:45Z","pushed_at":"2017-11-07T17:37:06Z","git_url":"git://github.com/procore/particles.git","ssh_url":"[email protected]:procore/particles.git","clone_url":"https://github.com/procore/particles.git","svn_url":"https://github.com/procore/particles","homepage":"","size":7409,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":25,"forks":5,"open_issues":25,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/procore/particles/pulls/520"},"html":{"href":"https://github.com/procore/particles/pull/520"},"issue":{"href":"https://api.github.com/repos/procore/particles/issues/520"},"comments":{"href":"https://api.github.com/repos/procore/particles/issues/520/comments"},"review_comments":{"href":"https://api.github.com/repos/procore/particles/pulls/520/comments"},"review_comment":{"href":"https://api.github.com/repos/procore/particles/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/procore/particles/pulls/520/commits"},"statuses":{"href":"https://api.github.com/repos/procore/particles/statuses/cd8fcdf9b1288fe42e14191c6bb3889675e91047"}},"author_association":"NONE"}} | {
"id": 82836763,
"name": "procore/particles",
"url": "https://api.github.com/repos/procore/particles"
} | {
"id": 6993945,
"login": "dancingshell",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6993945?",
"url": "https://api.github.com/users/dancingshell"
} | {
"id": 145387,
"login": "procore",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/145387?",
"url": "https://api.github.com/orgs/procore"
} | 2017-11-07T18:34:17 | 6821998872 | {"actor":{"display_login":"dancingshell"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rancher/community-catalog/pulls/comments/157025524","pull_request_review_id":83600824,"id":157025524,"diff_hunk":"@@ -0,0 +1,123 @@\n+version: '2'\n+\n+catalog:\n+ name: \"openHAB\"\n+ version: \"2.1.0\"\n+ description: \"An open source, technology agnostic home automation platform\"\n+ upgrade_from: \"2.0.0\"\n+ questions:\n+ - variable: \"IMAGE_ARCHITECTURE\"\n+ label: \"Image Architecture\"\n+ description: |\n+ Use \"amd64\" for AMD/Intel 64-bit architectures (e.g. x64, x86-64, x86_64). \n+ Use \"armhf\" for ARMv7 32-bit architectures (e.g. most RaspberryPi 1/2/3).\n+ Use \"arm64\" for ARMv8 64-bit architectures (not RaspberryPi 3)\n+ required: true\n+ default: \"amd64\"\n+ type: enum\n+ options:\n+ - amd64\n+ - armhf\n+ - arm64\n+\n+ - variable: \"IMAGE_DISTRIBUTION\"\n+ label: \"Image Distribution\"\n+ description: \"The distribution on which the container image is based\"\n+ required: true\n+ default: \"debian\"\n+ type: enum\n+ options:\n+ - alpine\n+ - debian\n+\n+ - variable: \"NETWORK_MODE\"\n+ label: \"Network Mode\"\n+ description: \"The network stack to connect the container to\"\n+ required: true\n+ default: \"host\"\n+ type: enum\n+ options:\n+ - host\n+ - bridge","path":"templates/openhab/2/rancher-compose.yml","position":41,"original_position":41,"commit_id":"16608724872bb1719300d2dab74b7058debdc830","original_commit_id":"16608724872bb1719300d2dab74b7058debdc830","user":{"login":"rawmind0","id":11555446,"avatar_url":"https://avatars1.githubusercontent.com/u/11555446?v=4","gravatar_id":"","url":"https://api.github.com/users/rawmind0","html_url":"https://github.com/rawmind0","followers_url":"https://api.github.com/users/rawmind0/followers","following_url":"https://api.github.com/users/rawmind0/following{/other_user}","gists_url":"https://api.github.com/users/rawmind0/gists{/gist_id}","starred_url":"https://api.github.com/users/rawmind0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rawmind0/subscriptions","organizations_url":"https://api.github.com/users/rawmind0/orgs","repos_url":"https://api.github.com/users/rawmind0/repos","events_url":"https://api.github.com/users/rawmind0/events{/privacy}","received_events_url":"https://api.github.com/users/rawmind0/received_events","type":"User","site_admin":false},"body":"What do you think if you also add `managed` network mode option??\r\n```\r\n+ - managed\r\n```","created_at":"2017-12-14T18:31:08Z","updated_at":"2017-12-14T18:31:42Z","html_url":"https://github.com/rancher/community-catalog/pull/621#discussion_r157025524","pull_request_url":"https://api.github.com/repos/rancher/community-catalog/pulls/621","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rancher/community-catalog/pulls/comments/157025524"},"html":{"href":"https://github.com/rancher/community-catalog/pull/621#discussion_r157025524"},"pull_request":{"href":"https://api.github.com/repos/rancher/community-catalog/pulls/621"}}},"pull_request":{"url":"https://api.github.com/repos/rancher/community-catalog/pulls/621","id":141485893,"html_url":"https://github.com/rancher/community-catalog/pull/621","diff_url":"https://github.com/rancher/community-catalog/pull/621.diff","patch_url":"https://github.com/rancher/community-catalog/pull/621.patch","issue_url":"https://api.github.com/repos/rancher/community-catalog/issues/621","number":621,"state":"open","locked":false,"title":"Add openHAB","user":{"login":"wborn","id":12213581,"avatar_url":"https://avatars1.githubusercontent.com/u/12213581?v=4","gravatar_id":"","url":"https://api.github.com/users/wborn","html_url":"https://github.com/wborn","followers_url":"https://api.github.com/users/wborn/followers","following_url":"https://api.github.com/users/wborn/following{/other_user}","gists_url":"https://api.github.com/users/wborn/gists{/gist_id}","starred_url":"https://api.github.com/users/wborn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wborn/subscriptions","organizations_url":"https://api.github.com/users/wborn/orgs","repos_url":"https://api.github.com/users/wborn/repos","events_url":"https://api.github.com/users/wborn/events{/privacy}","received_events_url":"https://api.github.com/users/wborn/received_events","type":"User","site_admin":false},"body":"This PR adds support for using the openHAB Docker container in the Rancher community catalog.\r\n\r\nThe template options used for adding an openHAB stack to Rancher are based on the [openHAB Docker instructions](https://github.com/openhab/openhab-docker).\r\n\r\nIt will not provide openHAB 2.x as an upgrade option for openHAB 1.8.3 based stacks (due to incompatibilties).\r\n\r\nThe category of this catalog item is now set to \"Automation\" which does not yet exist. I.e. similar to that of the pending Home Assistant PR #604. I think it could also be categorized in the \"IoT\" category.\r\n\r\nComments by @kaikreuzer @cniweb @legacycode are also appreciated. :-)\r\n\r\nBelow follow some screenshots of the openHAB Rancher catalog entry:\r\n\r\n# Searching the catalog\r\n\r\n\r\n\r\n# Creating the stack\r\n\r\n\r\n\r\n# Showing container logging\r\n\r\n\r\n\r\n","created_at":"2017-09-17T13:15:17Z","updated_at":"2017-12-14T18:31:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fea0b4ce79c70db21695e8c8a8784f1a3bea2184","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rancher/community-catalog/pulls/621/commits","review_comments_url":"https://api.github.com/repos/rancher/community-catalog/pulls/621/comments","review_comment_url":"https://api.github.com/repos/rancher/community-catalog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rancher/community-catalog/issues/621/comments","statuses_url":"https://api.github.com/repos/rancher/community-catalog/statuses/16608724872bb1719300d2dab74b7058debdc830","head":{"label":"wborn:add-openhab","ref":"add-openhab","sha":"16608724872bb1719300d2dab74b7058debdc830","user":{"login":"wborn","id":12213581,"avatar_url":"https://avatars1.githubusercontent.com/u/12213581?v=4","gravatar_id":"","url":"https://api.github.com/users/wborn","html_url":"https://github.com/wborn","followers_url":"https://api.github.com/users/wborn/followers","following_url":"https://api.github.com/users/wborn/following{/other_user}","gists_url":"https://api.github.com/users/wborn/gists{/gist_id}","starred_url":"https://api.github.com/users/wborn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wborn/subscriptions","organizations_url":"https://api.github.com/users/wborn/orgs","repos_url":"https://api.github.com/users/wborn/repos","events_url":"https://api.github.com/users/wborn/events{/privacy}","received_events_url":"https://api.github.com/users/wborn/received_events","type":"User","site_admin":false},"repo":{"id":103381349,"name":"community-catalog","full_name":"wborn/community-catalog","owner":{"login":"wborn","id":12213581,"avatar_url":"https://avatars1.githubusercontent.com/u/12213581?v=4","gravatar_id":"","url":"https://api.github.com/users/wborn","html_url":"https://github.com/wborn","followers_url":"https://api.github.com/users/wborn/followers","following_url":"https://api.github.com/users/wborn/following{/other_user}","gists_url":"https://api.github.com/users/wborn/gists{/gist_id}","starred_url":"https://api.github.com/users/wborn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wborn/subscriptions","organizations_url":"https://api.github.com/users/wborn/orgs","repos_url":"https://api.github.com/users/wborn/repos","events_url":"https://api.github.com/users/wborn/events{/privacy}","received_events_url":"https://api.github.com/users/wborn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wborn/community-catalog","description":"Catalog entries contributed by the community","fork":true,"url":"https://api.github.com/repos/wborn/community-catalog","forks_url":"https://api.github.com/repos/wborn/community-catalog/forks","keys_url":"https://api.github.com/repos/wborn/community-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wborn/community-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wborn/community-catalog/teams","hooks_url":"https://api.github.com/repos/wborn/community-catalog/hooks","issue_events_url":"https://api.github.com/repos/wborn/community-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/wborn/community-catalog/events","assignees_url":"https://api.github.com/repos/wborn/community-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/wborn/community-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/wborn/community-catalog/tags","blobs_url":"https://api.github.com/repos/wborn/community-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wborn/community-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wborn/community-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/wborn/community-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wborn/community-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/wborn/community-catalog/languages","stargazers_url":"https://api.github.com/repos/wborn/community-catalog/stargazers","contributors_url":"https://api.github.com/repos/wborn/community-catalog/contributors","subscribers_url":"https://api.github.com/repos/wborn/community-catalog/subscribers","subscription_url":"https://api.github.com/repos/wborn/community-catalog/subscription","commits_url":"https://api.github.com/repos/wborn/community-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/wborn/community-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/wborn/community-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/wborn/community-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/wborn/community-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/wborn/community-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wborn/community-catalog/merges","archive_url":"https://api.github.com/repos/wborn/community-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wborn/community-catalog/downloads","issues_url":"https://api.github.com/repos/wborn/community-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/wborn/community-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/wborn/community-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/wborn/community-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wborn/community-catalog/labels{/name}","releases_url":"https://api.github.com/repos/wborn/community-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/wborn/community-catalog/deployments","created_at":"2017-09-13T09:36:48Z","updated_at":"2017-09-13T09:36:50Z","pushed_at":"2017-11-22T00:24:22Z","git_url":"git://github.com/wborn/community-catalog.git","ssh_url":"[email protected]:wborn/community-catalog.git","clone_url":"https://github.com/wborn/community-catalog.git","svn_url":"https://github.com/wborn/community-catalog","homepage":null,"size":6065,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rancher:master","ref":"master","sha":"75f4db112a6f453deb2e4f16aec6a36c1bce824a","user":{"login":"rancher","id":9343010,"avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"repo":{"id":50607866,"name":"community-catalog","full_name":"rancher/community-catalog","owner":{"login":"rancher","id":9343010,"avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rancher/community-catalog","description":"Catalog entries contributed by the community","fork":false,"url":"https://api.github.com/repos/rancher/community-catalog","forks_url":"https://api.github.com/repos/rancher/community-catalog/forks","keys_url":"https://api.github.com/repos/rancher/community-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rancher/community-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rancher/community-catalog/teams","hooks_url":"https://api.github.com/repos/rancher/community-catalog/hooks","issue_events_url":"https://api.github.com/repos/rancher/community-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/rancher/community-catalog/events","assignees_url":"https://api.github.com/repos/rancher/community-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/rancher/community-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/rancher/community-catalog/tags","blobs_url":"https://api.github.com/repos/rancher/community-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rancher/community-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rancher/community-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/rancher/community-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rancher/community-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/rancher/community-catalog/languages","stargazers_url":"https://api.github.com/repos/rancher/community-catalog/stargazers","contributors_url":"https://api.github.com/repos/rancher/community-catalog/contributors","subscribers_url":"https://api.github.com/repos/rancher/community-catalog/subscribers","subscription_url":"https://api.github.com/repos/rancher/community-catalog/subscription","commits_url":"https://api.github.com/repos/rancher/community-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/rancher/community-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/rancher/community-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/rancher/community-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/rancher/community-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/rancher/community-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rancher/community-catalog/merges","archive_url":"https://api.github.com/repos/rancher/community-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rancher/community-catalog/downloads","issues_url":"https://api.github.com/repos/rancher/community-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/rancher/community-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/rancher/community-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/rancher/community-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rancher/community-catalog/labels{/name}","releases_url":"https://api.github.com/repos/rancher/community-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/rancher/community-catalog/deployments","created_at":"2016-01-28T19:32:08Z","updated_at":"2017-12-07T09:08:45Z","pushed_at":"2017-12-14T17:15:58Z","git_url":"git://github.com/rancher/community-catalog.git","ssh_url":"[email protected]:rancher/community-catalog.git","clone_url":"https://github.com/rancher/community-catalog.git","svn_url":"https://github.com/rancher/community-catalog","homepage":null,"size":6217,"stargazers_count":263,"watchers_count":263,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":575,"mirror_url":null,"archived":false,"open_issues_count":98,"license":null,"forks":575,"open_issues":98,"watchers":263,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rancher/community-catalog/pulls/621"},"html":{"href":"https://github.com/rancher/community-catalog/pull/621"},"issue":{"href":"https://api.github.com/repos/rancher/community-catalog/issues/621"},"comments":{"href":"https://api.github.com/repos/rancher/community-catalog/issues/621/comments"},"review_comments":{"href":"https://api.github.com/repos/rancher/community-catalog/pulls/621/comments"},"review_comment":{"href":"https://api.github.com/repos/rancher/community-catalog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rancher/community-catalog/pulls/621/commits"},"statuses":{"href":"https://api.github.com/repos/rancher/community-catalog/statuses/16608724872bb1719300d2dab74b7058debdc830"}},"author_association":"NONE"}} | {
"id": 50607866,
"name": "rancher/community-catalog",
"url": "https://api.github.com/repos/rancher/community-catalog"
} | {
"id": 11555446,
"login": "rawmind0",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11555446?",
"url": "https://api.github.com/users/rawmind0"
} | {
"id": 9343010,
"login": "rancher",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9343010?",
"url": "https://api.github.com/orgs/rancher"
} | 2017-12-14T18:31:08 | 6990136576 | {"actor":{"display_login":"rawmind0"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rancher/storage/pulls/comments/132621917","pull_request_review_id":55722426,"id":132621917,"diff_hunk":"@@ -0,0 +1,27 @@\n+############################################################\n+# Dockerfile to build Rancher Aliyun Block Storage Containers\n+# Based on Ubuntu\n+############################################################\n+\n+# Set the base image to Ubuntu 16.04","path":"package/abs/Dockerfile","position":6,"original_position":6,"commit_id":"b2ed22a270220c2e31bc6736de0ebeb29672b83b","original_commit_id":"b2ed22a270220c2e31bc6736de0ebeb29672b83b","user":{"login":"yasker","id":3344618,"avatar_url":"https://avatars1.githubusercontent.com/u/3344618?v=4","gravatar_id":"","url":"https://api.github.com/users/yasker","html_url":"https://github.com/yasker","followers_url":"https://api.github.com/users/yasker/followers","following_url":"https://api.github.com/users/yasker/following{/other_user}","gists_url":"https://api.github.com/users/yasker/gists{/gist_id}","starred_url":"https://api.github.com/users/yasker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yasker/subscriptions","organizations_url":"https://api.github.com/users/yasker/orgs","repos_url":"https://api.github.com/users/yasker/repos","events_url":"https://api.github.com/users/yasker/events{/privacy}","received_events_url":"https://api.github.com/users/yasker/received_events","type":"User","site_admin":false},"body":"It's too obvious, you don't need to comment.","created_at":"2017-08-11T06:21:34Z","updated_at":"2017-08-11T06:51:41Z","html_url":"https://github.com/rancher/storage/pull/65#discussion_r132621917","pull_request_url":"https://api.github.com/repos/rancher/storage/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/rancher/storage/pulls/comments/132621917"},"html":{"href":"https://github.com/rancher/storage/pull/65#discussion_r132621917"},"pull_request":{"href":"https://api.github.com/repos/rancher/storage/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/rancher/storage/pulls/65","id":135041614,"html_url":"https://github.com/rancher/storage/pull/65","diff_url":"https://github.com/rancher/storage/pull/65.diff","patch_url":"https://github.com/rancher/storage/pull/65.patch","issue_url":"https://api.github.com/repos/rancher/storage/issues/65","number":65,"state":"open","locked":false,"title":"Add storage for Aliyun Block Storage","user":{"login":"thxCode","id":3394724,"avatar_url":"https://avatars1.githubusercontent.com/u/3394724?v=4","gravatar_id":"","url":"https://api.github.com/users/thxCode","html_url":"https://github.com/thxCode","followers_url":"https://api.github.com/users/thxCode/followers","following_url":"https://api.github.com/users/thxCode/following{/other_user}","gists_url":"https://api.github.com/users/thxCode/gists{/gist_id}","starred_url":"https://api.github.com/users/thxCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thxCode/subscriptions","organizations_url":"https://api.github.com/users/thxCode/orgs","repos_url":"https://api.github.com/users/thxCode/repos","events_url":"https://api.github.com/users/thxCode/events{/privacy}","received_events_url":"https://api.github.com/users/thxCode/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-10T04:57:38Z","updated_at":"2017-08-11T06:51:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84651de615964b65495188042079b522c9625d4a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rancher/storage/pulls/65/commits","review_comments_url":"https://api.github.com/repos/rancher/storage/pulls/65/comments","review_comment_url":"https://api.github.com/repos/rancher/storage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rancher/storage/issues/65/comments","statuses_url":"https://api.github.com/repos/rancher/storage/statuses/b2ed22a270220c2e31bc6736de0ebeb29672b83b","head":{"label":"thxCode:aliyun-bs","ref":"aliyun-bs","sha":"b2ed22a270220c2e31bc6736de0ebeb29672b83b","user":{"login":"thxCode","id":3394724,"avatar_url":"https://avatars1.githubusercontent.com/u/3394724?v=4","gravatar_id":"","url":"https://api.github.com/users/thxCode","html_url":"https://github.com/thxCode","followers_url":"https://api.github.com/users/thxCode/followers","following_url":"https://api.github.com/users/thxCode/following{/other_user}","gists_url":"https://api.github.com/users/thxCode/gists{/gist_id}","starred_url":"https://api.github.com/users/thxCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thxCode/subscriptions","organizations_url":"https://api.github.com/users/thxCode/orgs","repos_url":"https://api.github.com/users/thxCode/repos","events_url":"https://api.github.com/users/thxCode/events{/privacy}","received_events_url":"https://api.github.com/users/thxCode/received_events","type":"User","site_admin":false},"repo":{"id":95730994,"name":"storage","full_name":"thxCode/storage","owner":{"login":"thxCode","id":3394724,"avatar_url":"https://avatars1.githubusercontent.com/u/3394724?v=4","gravatar_id":"","url":"https://api.github.com/users/thxCode","html_url":"https://github.com/thxCode","followers_url":"https://api.github.com/users/thxCode/followers","following_url":"https://api.github.com/users/thxCode/following{/other_user}","gists_url":"https://api.github.com/users/thxCode/gists{/gist_id}","starred_url":"https://api.github.com/users/thxCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thxCode/subscriptions","organizations_url":"https://api.github.com/users/thxCode/orgs","repos_url":"https://api.github.com/users/thxCode/repos","events_url":"https://api.github.com/users/thxCode/events{/privacy}","received_events_url":"https://api.github.com/users/thxCode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thxCode/storage","description":"Rancher specific storage plugins","fork":true,"url":"https://api.github.com/repos/thxCode/storage","forks_url":"https://api.github.com/repos/thxCode/storage/forks","keys_url":"https://api.github.com/repos/thxCode/storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thxCode/storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thxCode/storage/teams","hooks_url":"https://api.github.com/repos/thxCode/storage/hooks","issue_events_url":"https://api.github.com/repos/thxCode/storage/issues/events{/number}","events_url":"https://api.github.com/repos/thxCode/storage/events","assignees_url":"https://api.github.com/repos/thxCode/storage/assignees{/user}","branches_url":"https://api.github.com/repos/thxCode/storage/branches{/branch}","tags_url":"https://api.github.com/repos/thxCode/storage/tags","blobs_url":"https://api.github.com/repos/thxCode/storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thxCode/storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thxCode/storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/thxCode/storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thxCode/storage/statuses/{sha}","languages_url":"https://api.github.com/repos/thxCode/storage/languages","stargazers_url":"https://api.github.com/repos/thxCode/storage/stargazers","contributors_url":"https://api.github.com/repos/thxCode/storage/contributors","subscribers_url":"https://api.github.com/repos/thxCode/storage/subscribers","subscription_url":"https://api.github.com/repos/thxCode/storage/subscription","commits_url":"https://api.github.com/repos/thxCode/storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/thxCode/storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/thxCode/storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/thxCode/storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/thxCode/storage/contents/{+path}","compare_url":"https://api.github.com/repos/thxCode/storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thxCode/storage/merges","archive_url":"https://api.github.com/repos/thxCode/storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thxCode/storage/downloads","issues_url":"https://api.github.com/repos/thxCode/storage/issues{/number}","pulls_url":"https://api.github.com/repos/thxCode/storage/pulls{/number}","milestones_url":"https://api.github.com/repos/thxCode/storage/milestones{/number}","notifications_url":"https://api.github.com/repos/thxCode/storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thxCode/storage/labels{/name}","releases_url":"https://api.github.com/repos/thxCode/storage/releases{/id}","deployments_url":"https://api.github.com/repos/thxCode/storage/deployments","created_at":"2017-06-29T02:35:22Z","updated_at":"2017-06-29T02:35:24Z","pushed_at":"2017-08-09T10:33:36Z","git_url":"git://github.com/thxCode/storage.git","ssh_url":"[email protected]:thxCode/storage.git","clone_url":"https://github.com/thxCode/storage.git","svn_url":"https://github.com/thxCode/storage","homepage":null,"size":1239,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rancher:master","ref":"master","sha":"d65528d5e073b5dd225bb2a6e919033795edc77b","user":{"login":"rancher","id":9343010,"avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"repo":{"id":68723459,"name":"storage","full_name":"rancher/storage","owner":{"login":"rancher","id":9343010,"avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rancher/storage","description":"Rancher specific storage plugins","fork":false,"url":"https://api.github.com/repos/rancher/storage","forks_url":"https://api.github.com/repos/rancher/storage/forks","keys_url":"https://api.github.com/repos/rancher/storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rancher/storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rancher/storage/teams","hooks_url":"https://api.github.com/repos/rancher/storage/hooks","issue_events_url":"https://api.github.com/repos/rancher/storage/issues/events{/number}","events_url":"https://api.github.com/repos/rancher/storage/events","assignees_url":"https://api.github.com/repos/rancher/storage/assignees{/user}","branches_url":"https://api.github.com/repos/rancher/storage/branches{/branch}","tags_url":"https://api.github.com/repos/rancher/storage/tags","blobs_url":"https://api.github.com/repos/rancher/storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rancher/storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rancher/storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/rancher/storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rancher/storage/statuses/{sha}","languages_url":"https://api.github.com/repos/rancher/storage/languages","stargazers_url":"https://api.github.com/repos/rancher/storage/stargazers","contributors_url":"https://api.github.com/repos/rancher/storage/contributors","subscribers_url":"https://api.github.com/repos/rancher/storage/subscribers","subscription_url":"https://api.github.com/repos/rancher/storage/subscription","commits_url":"https://api.github.com/repos/rancher/storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/rancher/storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/rancher/storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/rancher/storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/rancher/storage/contents/{+path}","compare_url":"https://api.github.com/repos/rancher/storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rancher/storage/merges","archive_url":"https://api.github.com/repos/rancher/storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rancher/storage/downloads","issues_url":"https://api.github.com/repos/rancher/storage/issues{/number}","pulls_url":"https://api.github.com/repos/rancher/storage/pulls{/number}","milestones_url":"https://api.github.com/repos/rancher/storage/milestones{/number}","notifications_url":"https://api.github.com/repos/rancher/storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rancher/storage/labels{/name}","releases_url":"https://api.github.com/repos/rancher/storage/releases{/id}","deployments_url":"https://api.github.com/repos/rancher/storage/deployments","created_at":"2016-09-20T15:00:48Z","updated_at":"2017-07-31T06:15:04Z","pushed_at":"2017-08-10T04:57:38Z","git_url":"git://github.com/rancher/storage.git","ssh_url":"[email protected]:rancher/storage.git","clone_url":"https://github.com/rancher/storage.git","svn_url":"https://github.com/rancher/storage","homepage":null,"size":1238,"stargazers_count":22,"watchers_count":22,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":11,"forks":38,"open_issues":11,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rancher/storage/pulls/65"},"html":{"href":"https://github.com/rancher/storage/pull/65"},"issue":{"href":"https://api.github.com/repos/rancher/storage/issues/65"},"comments":{"href":"https://api.github.com/repos/rancher/storage/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/rancher/storage/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/rancher/storage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rancher/storage/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/rancher/storage/statuses/b2ed22a270220c2e31bc6736de0ebeb29672b83b"}}}} | {
"id": 68723459,
"name": "rancher/storage",
"url": "https://api.github.com/repos/rancher/storage"
} | {
"id": 3344618,
"login": "yasker",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3344618?",
"url": "https://api.github.com/users/yasker"
} | {
"id": 9343010,
"login": "rancher",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9343010?",
"url": "https://api.github.com/orgs/rancher"
} | 2017-08-11T06:21:34 | 6438898783 | {"actor":{"display_login":"yasker"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/rancher/webhook-service/pulls/comments/97178371","pull_request_review_id":17788098,"id":97178371,"diff_hunk":"@@ -44,6 +44,10 @@ func (s *ScaleServiceDriver) ValidatePayload(conf interface{}, apiClient client.\n \t\treturn http.StatusBadRequest, fmt.Errorf(\"Maximum scale not provided/invalid\")\n \t}\n \n+\tif config.Min > config.Max {","path":"drivers/scale_service.go","position":4,"original_position":4,"commit_id":"9df23a21357ef2a036f4f18366eb3c863cde8a37","original_commit_id":"9df23a21357ef2a036f4f18366eb3c863cde8a37","user":{"login":"mrajashree","id":10672776,"avatar_url":"https://avatars.githubusercontent.com/u/10672776?v=3","gravatar_id":"","url":"https://api.github.com/users/mrajashree","html_url":"https://github.com/mrajashree","followers_url":"https://api.github.com/users/mrajashree/followers","following_url":"https://api.github.com/users/mrajashree/following{/other_user}","gists_url":"https://api.github.com/users/mrajashree/gists{/gist_id}","starred_url":"https://api.github.com/users/mrajashree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrajashree/subscriptions","organizations_url":"https://api.github.com/users/mrajashree/orgs","repos_url":"https://api.github.com/users/mrajashree/repos","events_url":"https://api.github.com/users/mrajashree/events{/privacy}","received_events_url":"https://api.github.com/users/mrajashree/received_events","type":"User","site_admin":false},"body":"@cjellick yes actually. I initially thought that there doesn't have to be an error thrown in that case. But I'll add that now to the condition","created_at":"2017-01-20T23:51:14Z","updated_at":"2017-01-20T23:51:14Z","html_url":"https://github.com/rancher/webhook-service/pull/27#discussion_r97178371","pull_request_url":"https://api.github.com/repos/rancher/webhook-service/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/rancher/webhook-service/pulls/comments/97178371"},"html":{"href":"https://github.com/rancher/webhook-service/pull/27#discussion_r97178371"},"pull_request":{"href":"https://api.github.com/repos/rancher/webhook-service/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/rancher/webhook-service/pulls/27","id":101980812,"html_url":"https://github.com/rancher/webhook-service/pull/27","diff_url":"https://github.com/rancher/webhook-service/pull/27.diff","patch_url":"https://github.com/rancher/webhook-service/pull/27.patch","issue_url":"https://api.github.com/repos/rancher/webhook-service/issues/27","number":27,"state":"open","locked":false,"title":"Min cannot be greater than Max","user":{"login":"mrajashree","id":10672776,"avatar_url":"https://avatars.githubusercontent.com/u/10672776?v=3","gravatar_id":"","url":"https://api.github.com/users/mrajashree","html_url":"https://github.com/mrajashree","followers_url":"https://api.github.com/users/mrajashree/followers","following_url":"https://api.github.com/users/mrajashree/following{/other_user}","gists_url":"https://api.github.com/users/mrajashree/gists{/gist_id}","starred_url":"https://api.github.com/users/mrajashree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrajashree/subscriptions","organizations_url":"https://api.github.com/users/mrajashree/orgs","repos_url":"https://api.github.com/users/mrajashree/repos","events_url":"https://api.github.com/users/mrajashree/events{/privacy}","received_events_url":"https://api.github.com/users/mrajashree/received_events","type":"User","site_admin":false},"body":"https://github.com/rancher/rancher/issues/7446\r\n\r\nDidn't add unit test because the ValidatePayload() of the mock driver only checks the values of min, max, action etc against the expectedConfig, and returns 500. So I'll add validation test after the PR: https://github.com/rancher/webhook-service/pull/26 is merged so the validation-test PRs won't clash \r\n@cjellick \r\nAlso, it's okay to have min=max right?","created_at":"2017-01-18T01:14:14Z","updated_at":"2017-01-20T23:51:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b1e38ef18e22ca44bf99bacd996db88e3b33efd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rancher/webhook-service/pulls/27/commits","review_comments_url":"https://api.github.com/repos/rancher/webhook-service/pulls/27/comments","review_comment_url":"https://api.github.com/repos/rancher/webhook-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rancher/webhook-service/issues/27/comments","statuses_url":"https://api.github.com/repos/rancher/webhook-service/statuses/9df23a21357ef2a036f4f18366eb3c863cde8a37","head":{"label":"mrajashree:minGtMax","ref":"minGtMax","sha":"9df23a21357ef2a036f4f18366eb3c863cde8a37","user":{"login":"mrajashree","id":10672776,"avatar_url":"https://avatars.githubusercontent.com/u/10672776?v=3","gravatar_id":"","url":"https://api.github.com/users/mrajashree","html_url":"https://github.com/mrajashree","followers_url":"https://api.github.com/users/mrajashree/followers","following_url":"https://api.github.com/users/mrajashree/following{/other_user}","gists_url":"https://api.github.com/users/mrajashree/gists{/gist_id}","starred_url":"https://api.github.com/users/mrajashree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrajashree/subscriptions","organizations_url":"https://api.github.com/users/mrajashree/orgs","repos_url":"https://api.github.com/users/mrajashree/repos","events_url":"https://api.github.com/users/mrajashree/events{/privacy}","received_events_url":"https://api.github.com/users/mrajashree/received_events","type":"User","site_admin":false},"repo":{"id":73122587,"name":"webhook-service","full_name":"mrajashree/webhook-service","owner":{"login":"mrajashree","id":10672776,"avatar_url":"https://avatars.githubusercontent.com/u/10672776?v=3","gravatar_id":"","url":"https://api.github.com/users/mrajashree","html_url":"https://github.com/mrajashree","followers_url":"https://api.github.com/users/mrajashree/followers","following_url":"https://api.github.com/users/mrajashree/following{/other_user}","gists_url":"https://api.github.com/users/mrajashree/gists{/gist_id}","starred_url":"https://api.github.com/users/mrajashree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrajashree/subscriptions","organizations_url":"https://api.github.com/users/mrajashree/orgs","repos_url":"https://api.github.com/users/mrajashree/repos","events_url":"https://api.github.com/users/mrajashree/events{/privacy}","received_events_url":"https://api.github.com/users/mrajashree/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrajashree/webhook-service","description":"Service for constructing and processing ","fork":true,"url":"https://api.github.com/repos/mrajashree/webhook-service","forks_url":"https://api.github.com/repos/mrajashree/webhook-service/forks","keys_url":"https://api.github.com/repos/mrajashree/webhook-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrajashree/webhook-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrajashree/webhook-service/teams","hooks_url":"https://api.github.com/repos/mrajashree/webhook-service/hooks","issue_events_url":"https://api.github.com/repos/mrajashree/webhook-service/issues/events{/number}","events_url":"https://api.github.com/repos/mrajashree/webhook-service/events","assignees_url":"https://api.github.com/repos/mrajashree/webhook-service/assignees{/user}","branches_url":"https://api.github.com/repos/mrajashree/webhook-service/branches{/branch}","tags_url":"https://api.github.com/repos/mrajashree/webhook-service/tags","blobs_url":"https://api.github.com/repos/mrajashree/webhook-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrajashree/webhook-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrajashree/webhook-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrajashree/webhook-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrajashree/webhook-service/statuses/{sha}","languages_url":"https://api.github.com/repos/mrajashree/webhook-service/languages","stargazers_url":"https://api.github.com/repos/mrajashree/webhook-service/stargazers","contributors_url":"https://api.github.com/repos/mrajashree/webhook-service/contributors","subscribers_url":"https://api.github.com/repos/mrajashree/webhook-service/subscribers","subscription_url":"https://api.github.com/repos/mrajashree/webhook-service/subscription","commits_url":"https://api.github.com/repos/mrajashree/webhook-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrajashree/webhook-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrajashree/webhook-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrajashree/webhook-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrajashree/webhook-service/contents/{+path}","compare_url":"https://api.github.com/repos/mrajashree/webhook-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrajashree/webhook-service/merges","archive_url":"https://api.github.com/repos/mrajashree/webhook-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrajashree/webhook-service/downloads","issues_url":"https://api.github.com/repos/mrajashree/webhook-service/issues{/number}","pulls_url":"https://api.github.com/repos/mrajashree/webhook-service/pulls{/number}","milestones_url":"https://api.github.com/repos/mrajashree/webhook-service/milestones{/number}","notifications_url":"https://api.github.com/repos/mrajashree/webhook-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrajashree/webhook-service/labels{/name}","releases_url":"https://api.github.com/repos/mrajashree/webhook-service/releases{/id}","deployments_url":"https://api.github.com/repos/mrajashree/webhook-service/deployments","created_at":"2016-11-07T21:29:50Z","updated_at":"2016-11-07T23:29:35Z","pushed_at":"2017-01-19T21:09:07Z","git_url":"git://github.com/mrajashree/webhook-service.git","ssh_url":"[email protected]:mrajashree/webhook-service.git","clone_url":"https://github.com/mrajashree/webhook-service.git","svn_url":"https://github.com/mrajashree/webhook-service","homepage":null,"size":3703,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rancher:master","ref":"master","sha":"9345a8478780fc72b0338668560410f57a4e837c","user":{"login":"rancher","id":9343010,"avatar_url":"https://avatars.githubusercontent.com/u/9343010?v=3","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"repo":{"id":72877710,"name":"webhook-service","full_name":"rancher/webhook-service","owner":{"login":"rancher","id":9343010,"avatar_url":"https://avatars.githubusercontent.com/u/9343010?v=3","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rancher/webhook-service","description":"Service for constructing and processing ","fork":false,"url":"https://api.github.com/repos/rancher/webhook-service","forks_url":"https://api.github.com/repos/rancher/webhook-service/forks","keys_url":"https://api.github.com/repos/rancher/webhook-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rancher/webhook-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rancher/webhook-service/teams","hooks_url":"https://api.github.com/repos/rancher/webhook-service/hooks","issue_events_url":"https://api.github.com/repos/rancher/webhook-service/issues/events{/number}","events_url":"https://api.github.com/repos/rancher/webhook-service/events","assignees_url":"https://api.github.com/repos/rancher/webhook-service/assignees{/user}","branches_url":"https://api.github.com/repos/rancher/webhook-service/branches{/branch}","tags_url":"https://api.github.com/repos/rancher/webhook-service/tags","blobs_url":"https://api.github.com/repos/rancher/webhook-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rancher/webhook-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rancher/webhook-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/rancher/webhook-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rancher/webhook-service/statuses/{sha}","languages_url":"https://api.github.com/repos/rancher/webhook-service/languages","stargazers_url":"https://api.github.com/repos/rancher/webhook-service/stargazers","contributors_url":"https://api.github.com/repos/rancher/webhook-service/contributors","subscribers_url":"https://api.github.com/repos/rancher/webhook-service/subscribers","subscription_url":"https://api.github.com/repos/rancher/webhook-service/subscription","commits_url":"https://api.github.com/repos/rancher/webhook-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/rancher/webhook-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/rancher/webhook-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/rancher/webhook-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/rancher/webhook-service/contents/{+path}","compare_url":"https://api.github.com/repos/rancher/webhook-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rancher/webhook-service/merges","archive_url":"https://api.github.com/repos/rancher/webhook-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rancher/webhook-service/downloads","issues_url":"https://api.github.com/repos/rancher/webhook-service/issues{/number}","pulls_url":"https://api.github.com/repos/rancher/webhook-service/pulls{/number}","milestones_url":"https://api.github.com/repos/rancher/webhook-service/milestones{/number}","notifications_url":"https://api.github.com/repos/rancher/webhook-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rancher/webhook-service/labels{/name}","releases_url":"https://api.github.com/repos/rancher/webhook-service/releases{/id}","deployments_url":"https://api.github.com/repos/rancher/webhook-service/deployments","created_at":"2016-11-04T19:10:52Z","updated_at":"2017-01-11T22:08:12Z","pushed_at":"2017-01-20T23:49:58Z","git_url":"git://github.com/rancher/webhook-service.git","ssh_url":"[email protected]:rancher/webhook-service.git","clone_url":"https://github.com/rancher/webhook-service.git","svn_url":"https://github.com/rancher/webhook-service","homepage":null,"size":3689,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rancher/webhook-service/pulls/27"},"html":{"href":"https://github.com/rancher/webhook-service/pull/27"},"issue":{"href":"https://api.github.com/repos/rancher/webhook-service/issues/27"},"comments":{"href":"https://api.github.com/repos/rancher/webhook-service/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/rancher/webhook-service/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/rancher/webhook-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rancher/webhook-service/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/rancher/webhook-service/statuses/9df23a21357ef2a036f4f18366eb3c863cde8a37"}}}} | {
"id": 72877710,
"name": "rancher/webhook-service",
"url": "https://api.github.com/repos/rancher/webhook-service"
} | {
"id": 10672776,
"login": "mrajashree",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10672776?",
"url": "https://api.github.com/users/mrajashree"
} | {
"id": 9343010,
"login": "rancher",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9343010?",
"url": "https://api.github.com/orgs/rancher"
} | 2017-01-20T23:51:14 | 5189556681 | {"actor":{"display_login":"mrajashree"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/128619214","pull_request_review_id":51317005,"id":128619214,"diff_hunk":"@@ -53,7 +54,7 @@ public Task GetTestSqlConnection()\n return Task.CompletedTask;\n }\n \n- [RavenAction(\"/databases/*/etl/sql/simulate\", \"POST\", \"/databases/{databaseName:string}/etl/sql/simulate\")]\n+ [RavenAction(\"/databases/*/etl/sql/simulate\", \"POST\", AuthorizationStatus.DatabaseAdmin)]","path":"src/Raven.Server/Documents/ETL/Providers/SQL/Handlers/SqlEtlHandler.cs","position":29,"original_position":29,"commit_id":"5063168cb4c0678834599a469e33ae8f568deb27","original_commit_id":"5063168cb4c0678834599a469e33ae8f568deb27","user":{"login":"ayende","id":116915,"avatar_url":"https://avatars3.githubusercontent.com/u/116915?v=4","gravatar_id":"","url":"https://api.github.com/users/ayende","html_url":"https://github.com/ayende","followers_url":"https://api.github.com/users/ayende/followers","following_url":"https://api.github.com/users/ayende/following{/other_user}","gists_url":"https://api.github.com/users/ayende/gists{/gist_id}","starred_url":"https://api.github.com/users/ayende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayende/subscriptions","organizations_url":"https://api.github.com/users/ayende/orgs","repos_url":"https://api.github.com/users/ayende/repos","events_url":"https://api.github.com/users/ayende/events{/privacy}","received_events_url":"https://api.github.com/users/ayende/received_events","type":"User","site_admin":false},"body":"done\r\n","created_at":"2017-07-20T20:13:18Z","updated_at":"2017-07-20T20:13:18Z","html_url":"https://github.com/ravendb/ravendb/pull/3095#discussion_r128619214","pull_request_url":"https://api.github.com/repos/ravendb/ravendb/pulls/3095","_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/128619214"},"html":{"href":"https://github.com/ravendb/ravendb/pull/3095#discussion_r128619214"},"pull_request":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/3095"}}},"pull_request":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/3095","id":131619488,"html_url":"https://github.com/ravendb/ravendb/pull/3095","diff_url":"https://github.com/ravendb/ravendb/pull/3095.diff","patch_url":"https://github.com/ravendb/ravendb/pull/3095.patch","issue_url":"https://api.github.com/repos/ravendb/ravendb/issues/3095","number":3095,"state":"open","locked":false,"title":"RavenDB-7769 Review RequiredAuthorization endpoints for security impl…","user":{"login":"iftahbe","id":12386147,"avatar_url":"https://avatars0.githubusercontent.com/u/12386147?v=4","gravatar_id":"","url":"https://api.github.com/users/iftahbe","html_url":"https://github.com/iftahbe","followers_url":"https://api.github.com/users/iftahbe/followers","following_url":"https://api.github.com/users/iftahbe/following{/other_user}","gists_url":"https://api.github.com/users/iftahbe/gists{/gist_id}","starred_url":"https://api.github.com/users/iftahbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iftahbe/subscriptions","organizations_url":"https://api.github.com/users/iftahbe/orgs","repos_url":"https://api.github.com/users/iftahbe/repos","events_url":"https://api.github.com/users/iftahbe/events{/privacy}","received_events_url":"https://api.github.com/users/iftahbe/received_events","type":"User","site_admin":false},"body":"…ications\r\n\r\nRavenDB-7830 Define AdminDatabase permissions\r\nRavenDB-5449 /debug/memory/stats should be admin only endpoint\r\nRavenDB-7815 fix earlier PR comments\r\nRavenDB-7785 Write test verifying that if a route have `/admin/` in it, it has `AuthorizationStatus.ServerAdmin`","created_at":"2017-07-20T18:23:12Z","updated_at":"2017-07-20T20:13:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d4ab58be9aa29672b0dfc57b6fbde1ff4993c5f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ravendb/ravendb/pulls/3095/commits","review_comments_url":"https://api.github.com/repos/ravendb/ravendb/pulls/3095/comments","review_comment_url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ravendb/ravendb/issues/3095/comments","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/5063168cb4c0678834599a469e33ae8f568deb27","head":{"label":"iftahbe:RavenDB-7769-security-endpoints","ref":"RavenDB-7769-security-endpoints","sha":"5063168cb4c0678834599a469e33ae8f568deb27","user":{"login":"iftahbe","id":12386147,"avatar_url":"https://avatars0.githubusercontent.com/u/12386147?v=4","gravatar_id":"","url":"https://api.github.com/users/iftahbe","html_url":"https://github.com/iftahbe","followers_url":"https://api.github.com/users/iftahbe/followers","following_url":"https://api.github.com/users/iftahbe/following{/other_user}","gists_url":"https://api.github.com/users/iftahbe/gists{/gist_id}","starred_url":"https://api.github.com/users/iftahbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iftahbe/subscriptions","organizations_url":"https://api.github.com/users/iftahbe/orgs","repos_url":"https://api.github.com/users/iftahbe/repos","events_url":"https://api.github.com/users/iftahbe/events{/privacy}","received_events_url":"https://api.github.com/users/iftahbe/received_events","type":"User","site_admin":false},"repo":{"id":53836398,"name":"ravendb","full_name":"iftahbe/ravendb","owner":{"login":"iftahbe","id":12386147,"avatar_url":"https://avatars0.githubusercontent.com/u/12386147?v=4","gravatar_id":"","url":"https://api.github.com/users/iftahbe","html_url":"https://github.com/iftahbe","followers_url":"https://api.github.com/users/iftahbe/followers","following_url":"https://api.github.com/users/iftahbe/following{/other_user}","gists_url":"https://api.github.com/users/iftahbe/gists{/gist_id}","starred_url":"https://api.github.com/users/iftahbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iftahbe/subscriptions","organizations_url":"https://api.github.com/users/iftahbe/orgs","repos_url":"https://api.github.com/users/iftahbe/repos","events_url":"https://api.github.com/users/iftahbe/events{/privacy}","received_events_url":"https://api.github.com/users/iftahbe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iftahbe/ravendb","description":"A linq enabled document database for .NET","fork":true,"url":"https://api.github.com/repos/iftahbe/ravendb","forks_url":"https://api.github.com/repos/iftahbe/ravendb/forks","keys_url":"https://api.github.com/repos/iftahbe/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iftahbe/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iftahbe/ravendb/teams","hooks_url":"https://api.github.com/repos/iftahbe/ravendb/hooks","issue_events_url":"https://api.github.com/repos/iftahbe/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/iftahbe/ravendb/events","assignees_url":"https://api.github.com/repos/iftahbe/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/iftahbe/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/iftahbe/ravendb/tags","blobs_url":"https://api.github.com/repos/iftahbe/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iftahbe/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iftahbe/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/iftahbe/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iftahbe/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/iftahbe/ravendb/languages","stargazers_url":"https://api.github.com/repos/iftahbe/ravendb/stargazers","contributors_url":"https://api.github.com/repos/iftahbe/ravendb/contributors","subscribers_url":"https://api.github.com/repos/iftahbe/ravendb/subscribers","subscription_url":"https://api.github.com/repos/iftahbe/ravendb/subscription","commits_url":"https://api.github.com/repos/iftahbe/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/iftahbe/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/iftahbe/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/iftahbe/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/iftahbe/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/iftahbe/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iftahbe/ravendb/merges","archive_url":"https://api.github.com/repos/iftahbe/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iftahbe/ravendb/downloads","issues_url":"https://api.github.com/repos/iftahbe/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/iftahbe/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/iftahbe/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/iftahbe/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iftahbe/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/iftahbe/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/iftahbe/ravendb/deployments","created_at":"2016-03-14T07:41:28Z","updated_at":"2016-03-14T07:41:45Z","pushed_at":"2017-07-20T18:21:39Z","git_url":"git://github.com/iftahbe/ravendb.git","ssh_url":"[email protected]:iftahbe/ravendb.git","clone_url":"https://github.com/iftahbe/ravendb.git","svn_url":"https://github.com/iftahbe/ravendb","homepage":"http://ayende.com/Blog/","size":394078,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v4.0"}},"base":{"label":"ravendb:v4.0","ref":"v4.0","sha":"23184d19db208f707e5cfb46d3654f4776f3ab91","user":{"login":"ravendb","id":213792,"avatar_url":"https://avatars0.githubusercontent.com/u/213792?v=4","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"repo":{"id":542714,"name":"ravendb","full_name":"ravendb/ravendb","owner":{"login":"ravendb","id":213792,"avatar_url":"https://avatars0.githubusercontent.com/u/213792?v=4","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ravendb/ravendb","description":"A linq enabled document database for .NET","fork":false,"url":"https://api.github.com/repos/ravendb/ravendb","forks_url":"https://api.github.com/repos/ravendb/ravendb/forks","keys_url":"https://api.github.com/repos/ravendb/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravendb/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravendb/ravendb/teams","hooks_url":"https://api.github.com/repos/ravendb/ravendb/hooks","issue_events_url":"https://api.github.com/repos/ravendb/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/ravendb/ravendb/events","assignees_url":"https://api.github.com/repos/ravendb/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/ravendb/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/ravendb/ravendb/tags","blobs_url":"https://api.github.com/repos/ravendb/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravendb/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravendb/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravendb/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/ravendb/ravendb/languages","stargazers_url":"https://api.github.com/repos/ravendb/ravendb/stargazers","contributors_url":"https://api.github.com/repos/ravendb/ravendb/contributors","subscribers_url":"https://api.github.com/repos/ravendb/ravendb/subscribers","subscription_url":"https://api.github.com/repos/ravendb/ravendb/subscription","commits_url":"https://api.github.com/repos/ravendb/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravendb/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravendb/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravendb/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravendb/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/ravendb/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravendb/ravendb/merges","archive_url":"https://api.github.com/repos/ravendb/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravendb/ravendb/downloads","issues_url":"https://api.github.com/repos/ravendb/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/ravendb/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/ravendb/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/ravendb/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravendb/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/ravendb/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/ravendb/ravendb/deployments","created_at":"2010-03-02T11:05:30Z","updated_at":"2017-07-20T11:11:21Z","pushed_at":"2017-07-20T18:23:13Z","git_url":"git://github.com/ravendb/ravendb.git","ssh_url":"[email protected]:ravendb/ravendb.git","clone_url":"https://github.com/ravendb/ravendb.git","svn_url":"https://github.com/ravendb/ravendb","homepage":"http://ravendb.net","size":405487,"stargazers_count":1707,"watchers_count":1707,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":662,"mirror_url":null,"open_issues_count":2,"forks":662,"open_issues":2,"watchers":1707,"default_branch":"v3.5"}},"_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/3095"},"html":{"href":"https://github.com/ravendb/ravendb/pull/3095"},"issue":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/3095"},"comments":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/3095/comments"},"review_comments":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/3095/comments"},"review_comment":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/3095/commits"},"statuses":{"href":"https://api.github.com/repos/ravendb/ravendb/statuses/5063168cb4c0678834599a469e33ae8f568deb27"}}}} | {
"id": 542714,
"name": "ravendb/ravendb",
"url": "https://api.github.com/repos/ravendb/ravendb"
} | {
"id": 116915,
"login": "ayende",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/116915?",
"url": "https://api.github.com/users/ayende"
} | {
"id": 213792,
"login": "ravendb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/213792?",
"url": "https://api.github.com/orgs/ravendb"
} | 2017-07-20T20:13:18 | 6298333278 | {"actor":{"display_login":"ayende"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/pulls/comments/147438924","pull_request_review_id":72538266,"id":147438924,"diff_hunk":"@@ -0,0 +1,19 @@\n+---\n+name: Martin Thompson\n+title: \"Functional Performance\"\n+length: 40 minutes\n+audience: Intermediate: Familiar with principles, not well versed in specifics\n+language: English\n+twitter: @mjpt777\n+github: mjpt777\n+icon: https://real-logic.co.uk/martin-thompson.png\n+organization: Real Logic\n+tags:\n+ - Functional Programming, Best Practices, Software Design and Architecture\n+ suggestions:\n+ - People who want to separate the hype from reality when it comes to functional programming and application performance.\n+ ---","path":"_candidates_en/MartinThompson_1.md","position":15,"original_position":15,"commit_id":"477b57b868ca182a3044d88a323b59b802f35753","original_commit_id":"477b57b868ca182a3044d88a323b59b802f35753","user":{"login":"ik11235","id":1401147,"avatar_url":"https://avatars1.githubusercontent.com/u/1401147?v=4","gravatar_id":"","url":"https://api.github.com/users/ik11235","html_url":"https://github.com/ik11235","followers_url":"https://api.github.com/users/ik11235/followers","following_url":"https://api.github.com/users/ik11235/following{/other_user}","gists_url":"https://api.github.com/users/ik11235/gists{/gist_id}","starred_url":"https://api.github.com/users/ik11235/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ik11235/subscriptions","organizations_url":"https://api.github.com/users/ik11235/orgs","repos_url":"https://api.github.com/users/ik11235/repos","events_url":"https://api.github.com/users/ik11235/events{/privacy}","received_events_url":"https://api.github.com/users/ik11235/received_events","type":"User","site_admin":false},"body":"ここも先頭のスペースで構造がおかしくなってそうです","created_at":"2017-10-27T15:17:00Z","updated_at":"2017-10-27T15:17:08Z","html_url":"https://github.com/scalajp/2018.scalamatsuri.org/pull/63#discussion_r147438924","pull_request_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/pulls/63","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/pulls/comments/147438924"},"html":{"href":"https://github.com/scalajp/2018.scalamatsuri.org/pull/63#discussion_r147438924"},"pull_request":{"href":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/pulls/63","id":149213414,"html_url":"https://github.com/scalajp/2018.scalamatsuri.org/pull/63","diff_url":"https://github.com/scalajp/2018.scalamatsuri.org/pull/63.diff","patch_url":"https://github.com/scalajp/2018.scalamatsuri.org/pull/63.patch","issue_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/issues/63","number":63,"state":"open","locked":false,"title":"Add Functional Performance","user":{"login":"Keita-N","id":2616854,"avatar_url":"https://avatars1.githubusercontent.com/u/2616854?v=4","gravatar_id":"","url":"https://api.github.com/users/Keita-N","html_url":"https://github.com/Keita-N","followers_url":"https://api.github.com/users/Keita-N/followers","following_url":"https://api.github.com/users/Keita-N/following{/other_user}","gists_url":"https://api.github.com/users/Keita-N/gists{/gist_id}","starred_url":"https://api.github.com/users/Keita-N/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keita-N/subscriptions","organizations_url":"https://api.github.com/users/Keita-N/orgs","repos_url":"https://api.github.com/users/Keita-N/repos","events_url":"https://api.github.com/users/Keita-N/events{/privacy}","received_events_url":"https://api.github.com/users/Keita-N/received_events","type":"User","site_admin":false},"body":"ref: #62","created_at":"2017-10-27T15:06:06Z","updated_at":"2017-10-27T15:17:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4ecee54e315fefb8e1320527b972ee2919a6ed2","assignee":{"login":"Keita-N","id":2616854,"avatar_url":"https://avatars1.githubusercontent.com/u/2616854?v=4","gravatar_id":"","url":"https://api.github.com/users/Keita-N","html_url":"https://github.com/Keita-N","followers_url":"https://api.github.com/users/Keita-N/followers","following_url":"https://api.github.com/users/Keita-N/following{/other_user}","gists_url":"https://api.github.com/users/Keita-N/gists{/gist_id}","starred_url":"https://api.github.com/users/Keita-N/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keita-N/subscriptions","organizations_url":"https://api.github.com/users/Keita-N/orgs","repos_url":"https://api.github.com/users/Keita-N/repos","events_url":"https://api.github.com/users/Keita-N/events{/privacy}","received_events_url":"https://api.github.com/users/Keita-N/received_events","type":"User","site_admin":false},"assignees":[{"login":"Keita-N","id":2616854,"avatar_url":"https://avatars1.githubusercontent.com/u/2616854?v=4","gravatar_id":"","url":"https://api.github.com/users/Keita-N","html_url":"https://github.com/Keita-N","followers_url":"https://api.github.com/users/Keita-N/followers","following_url":"https://api.github.com/users/Keita-N/following{/other_user}","gists_url":"https://api.github.com/users/Keita-N/gists{/gist_id}","starred_url":"https://api.github.com/users/Keita-N/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keita-N/subscriptions","organizations_url":"https://api.github.com/users/Keita-N/orgs","repos_url":"https://api.github.com/users/Keita-N/repos","events_url":"https://api.github.com/users/Keita-N/events{/privacy}","received_events_url":"https://api.github.com/users/Keita-N/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/pulls/63/commits","review_comments_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/pulls/63/comments","review_comment_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/issues/63/comments","statuses_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/statuses/477b57b868ca182a3044d88a323b59b802f35753","head":{"label":"scalajp:add_MartinThompson_1","ref":"add_MartinThompson_1","sha":"477b57b868ca182a3044d88a323b59b802f35753","user":{"login":"scalajp","id":1428976,"avatar_url":"https://avatars1.githubusercontent.com/u/1428976?v=4","gravatar_id":"","url":"https://api.github.com/users/scalajp","html_url":"https://github.com/scalajp","followers_url":"https://api.github.com/users/scalajp/followers","following_url":"https://api.github.com/users/scalajp/following{/other_user}","gists_url":"https://api.github.com/users/scalajp/gists{/gist_id}","starred_url":"https://api.github.com/users/scalajp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalajp/subscriptions","organizations_url":"https://api.github.com/users/scalajp/orgs","repos_url":"https://api.github.com/users/scalajp/repos","events_url":"https://api.github.com/users/scalajp/events{/privacy}","received_events_url":"https://api.github.com/users/scalajp/received_events","type":"Organization","site_admin":false},"repo":{"id":102383875,"name":"2018.scalamatsuri.org","full_name":"scalajp/2018.scalamatsuri.org","owner":{"login":"scalajp","id":1428976,"avatar_url":"https://avatars1.githubusercontent.com/u/1428976?v=4","gravatar_id":"","url":"https://api.github.com/users/scalajp","html_url":"https://github.com/scalajp","followers_url":"https://api.github.com/users/scalajp/followers","following_url":"https://api.github.com/users/scalajp/following{/other_user}","gists_url":"https://api.github.com/users/scalajp/gists{/gist_id}","starred_url":"https://api.github.com/users/scalajp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalajp/subscriptions","organizations_url":"https://api.github.com/users/scalajp/orgs","repos_url":"https://api.github.com/users/scalajp/repos","events_url":"https://api.github.com/users/scalajp/events{/privacy}","received_events_url":"https://api.github.com/users/scalajp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalajp/2018.scalamatsuri.org","description":"ScalaMatsuri 2018 のウェブサイト http://2018.scalamatsuri.org","fork":false,"url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org","forks_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/forks","keys_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/teams","hooks_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/hooks","issue_events_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/issues/events{/number}","events_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/events","assignees_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/assignees{/user}","branches_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/branches{/branch}","tags_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/tags","blobs_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/statuses/{sha}","languages_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/languages","stargazers_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/stargazers","contributors_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/contributors","subscribers_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/subscribers","subscription_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/subscription","commits_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/contents/{+path}","compare_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/merges","archive_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/downloads","issues_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/issues{/number}","pulls_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/pulls{/number}","milestones_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/milestones{/number}","notifications_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/labels{/name}","releases_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/releases{/id}","deployments_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/deployments","created_at":"2017-09-04T17:04:28Z","updated_at":"2017-10-20T09:15:15Z","pushed_at":"2017-10-27T15:06:07Z","git_url":"git://github.com/scalajp/2018.scalamatsuri.org.git","ssh_url":"[email protected]:scalajp/2018.scalamatsuri.org.git","clone_url":"https://github.com/scalajp/2018.scalamatsuri.org.git","svn_url":"https://github.com/scalajp/2018.scalamatsuri.org","homepage":null,"size":21318,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"scalajp:master","ref":"master","sha":"94d7de297737b9829e2a293dddd65e03e8d14e59","user":{"login":"scalajp","id":1428976,"avatar_url":"https://avatars1.githubusercontent.com/u/1428976?v=4","gravatar_id":"","url":"https://api.github.com/users/scalajp","html_url":"https://github.com/scalajp","followers_url":"https://api.github.com/users/scalajp/followers","following_url":"https://api.github.com/users/scalajp/following{/other_user}","gists_url":"https://api.github.com/users/scalajp/gists{/gist_id}","starred_url":"https://api.github.com/users/scalajp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalajp/subscriptions","organizations_url":"https://api.github.com/users/scalajp/orgs","repos_url":"https://api.github.com/users/scalajp/repos","events_url":"https://api.github.com/users/scalajp/events{/privacy}","received_events_url":"https://api.github.com/users/scalajp/received_events","type":"Organization","site_admin":false},"repo":{"id":102383875,"name":"2018.scalamatsuri.org","full_name":"scalajp/2018.scalamatsuri.org","owner":{"login":"scalajp","id":1428976,"avatar_url":"https://avatars1.githubusercontent.com/u/1428976?v=4","gravatar_id":"","url":"https://api.github.com/users/scalajp","html_url":"https://github.com/scalajp","followers_url":"https://api.github.com/users/scalajp/followers","following_url":"https://api.github.com/users/scalajp/following{/other_user}","gists_url":"https://api.github.com/users/scalajp/gists{/gist_id}","starred_url":"https://api.github.com/users/scalajp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalajp/subscriptions","organizations_url":"https://api.github.com/users/scalajp/orgs","repos_url":"https://api.github.com/users/scalajp/repos","events_url":"https://api.github.com/users/scalajp/events{/privacy}","received_events_url":"https://api.github.com/users/scalajp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalajp/2018.scalamatsuri.org","description":"ScalaMatsuri 2018 のウェブサイト http://2018.scalamatsuri.org","fork":false,"url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org","forks_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/forks","keys_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/teams","hooks_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/hooks","issue_events_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/issues/events{/number}","events_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/events","assignees_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/assignees{/user}","branches_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/branches{/branch}","tags_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/tags","blobs_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/statuses/{sha}","languages_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/languages","stargazers_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/stargazers","contributors_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/contributors","subscribers_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/subscribers","subscription_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/subscription","commits_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/contents/{+path}","compare_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/merges","archive_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/downloads","issues_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/issues{/number}","pulls_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/pulls{/number}","milestones_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/milestones{/number}","notifications_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/labels{/name}","releases_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/releases{/id}","deployments_url":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/deployments","created_at":"2017-09-04T17:04:28Z","updated_at":"2017-10-20T09:15:15Z","pushed_at":"2017-10-27T15:06:07Z","git_url":"git://github.com/scalajp/2018.scalamatsuri.org.git","ssh_url":"[email protected]:scalajp/2018.scalamatsuri.org.git","clone_url":"https://github.com/scalajp/2018.scalamatsuri.org.git","svn_url":"https://github.com/scalajp/2018.scalamatsuri.org","homepage":null,"size":21318,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/pulls/63"},"html":{"href":"https://github.com/scalajp/2018.scalamatsuri.org/pull/63"},"issue":{"href":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/issues/63"},"comments":{"href":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/scalajp/2018.scalamatsuri.org/statuses/477b57b868ca182a3044d88a323b59b802f35753"}},"author_association":"CONTRIBUTOR"}} | {
"id": 102383875,
"name": "scalajp/2018.scalamatsuri.org",
"url": "https://api.github.com/repos/scalajp/2018.scalamatsuri.org"
} | {
"id": 1401147,
"login": "ik11235",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1401147?",
"url": "https://api.github.com/users/ik11235"
} | {
"id": 1428976,
"login": "scalajp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1428976?",
"url": "https://api.github.com/orgs/scalajp"
} | 2017-10-27T15:17:00 | 6775746072 | {"actor":{"display_login":"ik11235"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/skroutz/rafka/pulls/comments/125859988","pull_request_review_id":48288668,"id":125859988,"diff_hunk":"@@ -6,10 +6,11 @@\n \"log.connection.close\": false\n },\n \"consumer\": {\n- \"go.events.channel.enable\": true,\n- \"go.application.rebalance.enable\": true,\n+ \"go.events.channel.enable\": false,","path":"kafka.json.sample","position":6,"original_position":6,"commit_id":"d54fc3ee3fdae30a132d8798b6de7cc83fe4ecba","original_commit_id":"d54fc3ee3fdae30a132d8798b6de7cc83fe4ecba","user":{"login":"ctrochalakis","id":1865,"avatar_url":"https://avatars2.githubusercontent.com/u/1865?v=3","gravatar_id":"","url":"https://api.github.com/users/ctrochalakis","html_url":"https://github.com/ctrochalakis","followers_url":"https://api.github.com/users/ctrochalakis/followers","following_url":"https://api.github.com/users/ctrochalakis/following{/other_user}","gists_url":"https://api.github.com/users/ctrochalakis/gists{/gist_id}","starred_url":"https://api.github.com/users/ctrochalakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctrochalakis/subscriptions","organizations_url":"https://api.github.com/users/ctrochalakis/orgs","repos_url":"https://api.github.com/users/ctrochalakis/repos","events_url":"https://api.github.com/users/ctrochalakis/events{/privacy}","received_events_url":"https://api.github.com/users/ctrochalakis/received_events","type":"User","site_admin":false},"body":"we can probably completely drop that setting.","created_at":"2017-07-06T10:05:04Z","updated_at":"2017-07-06T10:05:04Z","html_url":"https://github.com/skroutz/rafka/pull/20#discussion_r125859988","pull_request_url":"https://api.github.com/repos/skroutz/rafka/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/skroutz/rafka/pulls/comments/125859988"},"html":{"href":"https://github.com/skroutz/rafka/pull/20#discussion_r125859988"},"pull_request":{"href":"https://api.github.com/repos/skroutz/rafka/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/skroutz/rafka/pulls/20","id":129144201,"html_url":"https://github.com/skroutz/rafka/pull/20","diff_url":"https://github.com/skroutz/rafka/pull/20.diff","patch_url":"https://github.com/skroutz/rafka/pull/20.patch","issue_url":"https://api.github.com/repos/skroutz/rafka/issues/20","number":20,"state":"open","locked":false,"title":"consumer: Switch to Poll()","user":{"login":"agis","id":827224,"avatar_url":"https://avatars1.githubusercontent.com/u/827224?v=3","gravatar_id":"","url":"https://api.github.com/users/agis","html_url":"https://github.com/agis","followers_url":"https://api.github.com/users/agis/followers","following_url":"https://api.github.com/users/agis/following{/other_user}","gists_url":"https://api.github.com/users/agis/gists{/gist_id}","starred_url":"https://api.github.com/users/agis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agis/subscriptions","organizations_url":"https://api.github.com/users/agis/orgs","repos_url":"https://api.github.com/users/agis/repos","events_url":"https://api.github.com/users/agis/events{/privacy}","received_events_url":"https://api.github.com/users/agis/received_events","type":"User","site_admin":false},"body":"Using Poll() means we have a more direct mapping to librdkafka functionality. Poll may also prioritize messages from Kafka, whereas with the channel-based approach we may end up with outdated events.","created_at":"2017-07-06T09:45:10Z","updated_at":"2017-07-06T10:05:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"307e76a64877ff3296aa6b7dcd50ece3fe24e486","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/skroutz/rafka/milestones/1","html_url":"https://github.com/skroutz/rafka/milestone/1","labels_url":"https://api.github.com/repos/skroutz/rafka/milestones/1/labels","id":2584869,"number":1,"title":"1.0","description":"","creator":{"login":"agis","id":827224,"avatar_url":"https://avatars1.githubusercontent.com/u/827224?v=3","gravatar_id":"","url":"https://api.github.com/users/agis","html_url":"https://github.com/agis","followers_url":"https://api.github.com/users/agis/followers","following_url":"https://api.github.com/users/agis/following{/other_user}","gists_url":"https://api.github.com/users/agis/gists{/gist_id}","starred_url":"https://api.github.com/users/agis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agis/subscriptions","organizations_url":"https://api.github.com/users/agis/orgs","repos_url":"https://api.github.com/users/agis/repos","events_url":"https://api.github.com/users/agis/events{/privacy}","received_events_url":"https://api.github.com/users/agis/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":6,"state":"open","created_at":"2017-06-15T11:49:14Z","updated_at":"2017-07-06T09:45:10Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/skroutz/rafka/pulls/20/commits","review_comments_url":"https://api.github.com/repos/skroutz/rafka/pulls/20/comments","review_comment_url":"https://api.github.com/repos/skroutz/rafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skroutz/rafka/issues/20/comments","statuses_url":"https://api.github.com/repos/skroutz/rafka/statuses/d54fc3ee3fdae30a132d8798b6de7cc83fe4ecba","head":{"label":"skroutz:poll","ref":"poll","sha":"d54fc3ee3fdae30a132d8798b6de7cc83fe4ecba","user":{"login":"skroutz","id":285550,"avatar_url":"https://avatars1.githubusercontent.com/u/285550?v=3","gravatar_id":"","url":"https://api.github.com/users/skroutz","html_url":"https://github.com/skroutz","followers_url":"https://api.github.com/users/skroutz/followers","following_url":"https://api.github.com/users/skroutz/following{/other_user}","gists_url":"https://api.github.com/users/skroutz/gists{/gist_id}","starred_url":"https://api.github.com/users/skroutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skroutz/subscriptions","organizations_url":"https://api.github.com/users/skroutz/orgs","repos_url":"https://api.github.com/users/skroutz/repos","events_url":"https://api.github.com/users/skroutz/events{/privacy}","received_events_url":"https://api.github.com/users/skroutz/received_events","type":"Organization","site_admin":false},"repo":{"id":94420987,"name":"rafka","full_name":"skroutz/rafka","owner":{"login":"skroutz","id":285550,"avatar_url":"https://avatars1.githubusercontent.com/u/285550?v=3","gravatar_id":"","url":"https://api.github.com/users/skroutz","html_url":"https://github.com/skroutz","followers_url":"https://api.github.com/users/skroutz/followers","following_url":"https://api.github.com/users/skroutz/following{/other_user}","gists_url":"https://api.github.com/users/skroutz/gists{/gist_id}","starred_url":"https://api.github.com/users/skroutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skroutz/subscriptions","organizations_url":"https://api.github.com/users/skroutz/orgs","repos_url":"https://api.github.com/users/skroutz/repos","events_url":"https://api.github.com/users/skroutz/events{/privacy}","received_events_url":"https://api.github.com/users/skroutz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skroutz/rafka","description":"Kafka with a Redis API","fork":false,"url":"https://api.github.com/repos/skroutz/rafka","forks_url":"https://api.github.com/repos/skroutz/rafka/forks","keys_url":"https://api.github.com/repos/skroutz/rafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skroutz/rafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skroutz/rafka/teams","hooks_url":"https://api.github.com/repos/skroutz/rafka/hooks","issue_events_url":"https://api.github.com/repos/skroutz/rafka/issues/events{/number}","events_url":"https://api.github.com/repos/skroutz/rafka/events","assignees_url":"https://api.github.com/repos/skroutz/rafka/assignees{/user}","branches_url":"https://api.github.com/repos/skroutz/rafka/branches{/branch}","tags_url":"https://api.github.com/repos/skroutz/rafka/tags","blobs_url":"https://api.github.com/repos/skroutz/rafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skroutz/rafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skroutz/rafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/skroutz/rafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skroutz/rafka/statuses/{sha}","languages_url":"https://api.github.com/repos/skroutz/rafka/languages","stargazers_url":"https://api.github.com/repos/skroutz/rafka/stargazers","contributors_url":"https://api.github.com/repos/skroutz/rafka/contributors","subscribers_url":"https://api.github.com/repos/skroutz/rafka/subscribers","subscription_url":"https://api.github.com/repos/skroutz/rafka/subscription","commits_url":"https://api.github.com/repos/skroutz/rafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/skroutz/rafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/skroutz/rafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/skroutz/rafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/skroutz/rafka/contents/{+path}","compare_url":"https://api.github.com/repos/skroutz/rafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skroutz/rafka/merges","archive_url":"https://api.github.com/repos/skroutz/rafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skroutz/rafka/downloads","issues_url":"https://api.github.com/repos/skroutz/rafka/issues{/number}","pulls_url":"https://api.github.com/repos/skroutz/rafka/pulls{/number}","milestones_url":"https://api.github.com/repos/skroutz/rafka/milestones{/number}","notifications_url":"https://api.github.com/repos/skroutz/rafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skroutz/rafka/labels{/name}","releases_url":"https://api.github.com/repos/skroutz/rafka/releases{/id}","deployments_url":"https://api.github.com/repos/skroutz/rafka/deployments","created_at":"2017-06-15T09:01:31Z","updated_at":"2017-06-26T08:44:12Z","pushed_at":"2017-07-06T10:04:35Z","git_url":"git://github.com/skroutz/rafka.git","ssh_url":"[email protected]:skroutz/rafka.git","clone_url":"https://github.com/skroutz/rafka.git","svn_url":"https://github.com/skroutz/rafka","homepage":null,"size":89,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":5,"default_branch":"master"}},"base":{"label":"skroutz:master","ref":"master","sha":"58f44a733df2596458f9f24c76cd34368d4113ac","user":{"login":"skroutz","id":285550,"avatar_url":"https://avatars1.githubusercontent.com/u/285550?v=3","gravatar_id":"","url":"https://api.github.com/users/skroutz","html_url":"https://github.com/skroutz","followers_url":"https://api.github.com/users/skroutz/followers","following_url":"https://api.github.com/users/skroutz/following{/other_user}","gists_url":"https://api.github.com/users/skroutz/gists{/gist_id}","starred_url":"https://api.github.com/users/skroutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skroutz/subscriptions","organizations_url":"https://api.github.com/users/skroutz/orgs","repos_url":"https://api.github.com/users/skroutz/repos","events_url":"https://api.github.com/users/skroutz/events{/privacy}","received_events_url":"https://api.github.com/users/skroutz/received_events","type":"Organization","site_admin":false},"repo":{"id":94420987,"name":"rafka","full_name":"skroutz/rafka","owner":{"login":"skroutz","id":285550,"avatar_url":"https://avatars1.githubusercontent.com/u/285550?v=3","gravatar_id":"","url":"https://api.github.com/users/skroutz","html_url":"https://github.com/skroutz","followers_url":"https://api.github.com/users/skroutz/followers","following_url":"https://api.github.com/users/skroutz/following{/other_user}","gists_url":"https://api.github.com/users/skroutz/gists{/gist_id}","starred_url":"https://api.github.com/users/skroutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skroutz/subscriptions","organizations_url":"https://api.github.com/users/skroutz/orgs","repos_url":"https://api.github.com/users/skroutz/repos","events_url":"https://api.github.com/users/skroutz/events{/privacy}","received_events_url":"https://api.github.com/users/skroutz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skroutz/rafka","description":"Kafka with a Redis API","fork":false,"url":"https://api.github.com/repos/skroutz/rafka","forks_url":"https://api.github.com/repos/skroutz/rafka/forks","keys_url":"https://api.github.com/repos/skroutz/rafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skroutz/rafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skroutz/rafka/teams","hooks_url":"https://api.github.com/repos/skroutz/rafka/hooks","issue_events_url":"https://api.github.com/repos/skroutz/rafka/issues/events{/number}","events_url":"https://api.github.com/repos/skroutz/rafka/events","assignees_url":"https://api.github.com/repos/skroutz/rafka/assignees{/user}","branches_url":"https://api.github.com/repos/skroutz/rafka/branches{/branch}","tags_url":"https://api.github.com/repos/skroutz/rafka/tags","blobs_url":"https://api.github.com/repos/skroutz/rafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skroutz/rafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skroutz/rafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/skroutz/rafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skroutz/rafka/statuses/{sha}","languages_url":"https://api.github.com/repos/skroutz/rafka/languages","stargazers_url":"https://api.github.com/repos/skroutz/rafka/stargazers","contributors_url":"https://api.github.com/repos/skroutz/rafka/contributors","subscribers_url":"https://api.github.com/repos/skroutz/rafka/subscribers","subscription_url":"https://api.github.com/repos/skroutz/rafka/subscription","commits_url":"https://api.github.com/repos/skroutz/rafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/skroutz/rafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/skroutz/rafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/skroutz/rafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/skroutz/rafka/contents/{+path}","compare_url":"https://api.github.com/repos/skroutz/rafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skroutz/rafka/merges","archive_url":"https://api.github.com/repos/skroutz/rafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skroutz/rafka/downloads","issues_url":"https://api.github.com/repos/skroutz/rafka/issues{/number}","pulls_url":"https://api.github.com/repos/skroutz/rafka/pulls{/number}","milestones_url":"https://api.github.com/repos/skroutz/rafka/milestones{/number}","notifications_url":"https://api.github.com/repos/skroutz/rafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skroutz/rafka/labels{/name}","releases_url":"https://api.github.com/repos/skroutz/rafka/releases{/id}","deployments_url":"https://api.github.com/repos/skroutz/rafka/deployments","created_at":"2017-06-15T09:01:31Z","updated_at":"2017-06-26T08:44:12Z","pushed_at":"2017-07-06T10:04:35Z","git_url":"git://github.com/skroutz/rafka.git","ssh_url":"[email protected]:skroutz/rafka.git","clone_url":"https://github.com/skroutz/rafka.git","svn_url":"https://github.com/skroutz/rafka","homepage":null,"size":89,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skroutz/rafka/pulls/20"},"html":{"href":"https://github.com/skroutz/rafka/pull/20"},"issue":{"href":"https://api.github.com/repos/skroutz/rafka/issues/20"},"comments":{"href":"https://api.github.com/repos/skroutz/rafka/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/skroutz/rafka/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/skroutz/rafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skroutz/rafka/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/skroutz/rafka/statuses/d54fc3ee3fdae30a132d8798b6de7cc83fe4ecba"}}}} | {
"id": 94420987,
"name": "skroutz/rafka",
"url": "https://api.github.com/repos/skroutz/rafka"
} | {
"id": 1865,
"login": "ctrochalakis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1865?",
"url": "https://api.github.com/users/ctrochalakis"
} | {
"id": 285550,
"login": "skroutz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/285550?",
"url": "https://api.github.com/orgs/skroutz"
} | 2017-07-06T10:05:04 | 6202795029 | {"actor":{"display_login":"ctrochalakis"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/stapler/stapler/pulls/comments/102497554","pull_request_review_id":23254256,"id":102497554,"diff_hunk":"@@ -1,66 +1,146 @@\n package org.kohsuke.stapler.export;\n \n+import javax.annotation.Nonnull;\n+\n /**\n * Controls the output behaviour.\n *\n * @author Kohsuke Kawaguchi\n */\n public class ExportConfig {\n+ private final boolean prettyPrint;\n+ private final ClassAttributeBehaviour classAttribute;\n+ private final ExportInterceptor exportInterceptor;\n+ private final boolean skipIfFail;\n+ private final Flavor flavor;\n+\n /**\n- * @deprecated\n- * Use getter and setter\n+ * Creates {@link ExportConfig} with a flavor\n+ *\n+ * @param flavor must be non-null\n */\n- public boolean prettyPrint;\n-\n- private ClassAttributeBehaviour classAttribute = ClassAttributeBehaviour.IF_NEEDED;\n+ private ExportConfig(Flavor flavor, ExportInterceptor exportInterceptor,\n+ ClassAttributeBehaviour classAttribute, boolean skipIfFail, boolean prettyPrint) {\n+ this.flavor = flavor;\n+ this.prettyPrint = prettyPrint;\n+ this.classAttribute = (classAttribute == null) ? ClassAttributeBehaviour.IF_NEEDED.simple(): classAttribute;\n+ this.exportInterceptor = exportInterceptor == null ? ExportInterceptor.DEFAULT :exportInterceptor;\n+ this.skipIfFail = skipIfFail;\n+ }\n \n /**\n- * Interceptor used to check if given model object or it's property should be included in serialization\n+ * If true, output will be indented to make it easier for humans to understand.\n */\n- private ExportInterceptor exportInterceptor = ExportInterceptor.DEFAULT;\n-\n- private boolean skipIfFail = false;\n-\n public boolean isPrettyPrint() {\n return prettyPrint;\n }\n \n /**\n- * If true, output will be indented to make it easier for humans to understand.\n+ * Controls the behaviour of the class attribute to be produced.\n */\n- public ExportConfig withPrettyPrint(boolean prettyPrint) {\n- this.prettyPrint = prettyPrint;\n- return this;\n- }\n-\n public ClassAttributeBehaviour getClassAttribute() {\n return classAttribute;\n }\n \n /**\n * Controls the behaviour of the class attribute to be produced.\n */\n- public ExportConfig withClassAttribute(ClassAttributeBehaviour cab) {\n- if (cab==null) throw new NullPointerException();\n- this.classAttribute = cab;\n- return this;\n+ public ClassAttributeBehaviour getClassAttributeBehaviour(){\n+ return this.classAttribute;\n }\n \n+ /**\n+ * Gives {@link ExportInterceptor}. Always non-null.\n+ */\n public ExportInterceptor getExportInterceptor() {\n return exportInterceptor;\n }\n \n- public ExportConfig withExportInterceptor(ExportInterceptor interceptor){\n- this.exportInterceptor = interceptor;\n- return this;\n+ /**\n+ * Tells whether to skip serialization failure.\n+ */\n+ public boolean isSkipIfFail() {\n+ return skipIfFail;\n }\n \n- public ExportConfig withSkipIfFail(boolean skipIfFail){\n- this.skipIfFail = skipIfFail;\n- return this;\n+ /**\n+ * Gives {@link Flavor}. Always non-null.\n+ */\n+ public Flavor getFlavor() {\n+ return flavor;\n }\n \n- public boolean isSkipIfFail() {\n- return skipIfFail;\n+ /**\n+ * {@link ExportConfig} builder\n+ */\n+ public static class Builder{\n+ private boolean prettyPrint;\n+\n+ private ClassAttributeBehaviour classAttribute = ClassAttributeBehaviour.IF_NEEDED;\n+\n+ private ExportInterceptor exportInterceptor = ExportInterceptor.DEFAULT;\n+\n+ private boolean skipIfFail = false;\n+\n+ private final Flavor flavor;\n+\n+ public Builder(Flavor flavor){\n+ this.flavor = flavor;\n+ }\n+\n+ /**\n+ * Turn on or off pretty printing of serialized data.\n+ *\n+ * @param prettyPrint default false.\n+ *\n+ * @return {@link Builder} instance\n+ */\n+ public Builder prettyPrint(boolean prettyPrint){\n+ this.prettyPrint = prettyPrint;\n+ return this;\n+ }\n+\n+ /**\n+ * If true serialization error will be ignored","path":"core/src/main/java/org/kohsuke/stapler/export/ExportConfig.java","position":119,"original_position":132,"commit_id":"deda6c4d520fe1e2701f49bbe11f6a0482add6cf","original_commit_id":"deda6c4d520fe1e2701f49bbe11f6a0482add6cf","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"I am still a bit uneasy about this: it feels like rather than a hard-coded flag, this should just be an aspect of the behavior of `ExportInterceptor`.\r\n\r\nNow currently `ExportInterceptor` is only asked to `getValue` on a single attribute, which is too late to defend against, say, an `Object` which is neither an `@ExportedBean` nor a `CustomExportedBean`. And the handling of those cases is hard-coded in Stapler core and not customizable—except via this flag.\r\n\r\nSo perhaps that means that the design of `ExportInterceptor` is wrong—too narrowly conceived. Rather than being asked to handle individual attributes, it should be asked to deal with the entire “bean”. The default implementation would check for `CustomExportedBean` and do a replacement if indicated; then fail if not `@ExportedBean`; then produce a `Model`, iterate its properties, and tell the `DataWriter` to create an object with all those properties. A custom implementation could be more or less lenient about various error conditions, or do something else entirely when encountering certain bean types (perhaps delegating to the default interceptor in other cases).\r\n\r\n@kohsuke may want to weigh in here.","created_at":"2017-02-22T15:56:39Z","updated_at":"2017-02-22T15:59:07Z","html_url":"https://github.com/stapler/stapler/pull/106#discussion_r102497554","pull_request_url":"https://api.github.com/repos/stapler/stapler/pulls/106","_links":{"self":{"href":"https://api.github.com/repos/stapler/stapler/pulls/comments/102497554"},"html":{"href":"https://github.com/stapler/stapler/pull/106#discussion_r102497554"},"pull_request":{"href":"https://api.github.com/repos/stapler/stapler/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/stapler/stapler/pulls/106","id":105992764,"html_url":"https://github.com/stapler/stapler/pull/106","diff_url":"https://github.com/stapler/stapler/pull/106.diff","patch_url":"https://github.com/stapler/stapler/pull/106.patch","issue_url":"https://api.github.com/repos/stapler/stapler/issues/106","number":106,"state":"open","locked":false,"title":"JENKINS-40088# Configurable stapler serialization behavior","user":{"login":"vivek","id":38139,"avatar_url":"https://avatars.githubusercontent.com/u/38139?v=3","gravatar_id":"","url":"https://api.github.com/users/vivek","html_url":"https://github.com/vivek","followers_url":"https://api.github.com/users/vivek/followers","following_url":"https://api.github.com/users/vivek/following{/other_user}","gists_url":"https://api.github.com/users/vivek/gists{/gist_id}","starred_url":"https://api.github.com/users/vivek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivek/subscriptions","organizations_url":"https://api.github.com/users/vivek/orgs","repos_url":"https://api.github.com/users/vivek/repos","events_url":"https://api.github.com/users/vivek/events{/privacy}","received_events_url":"https://api.github.com/users/vivek/received_events","type":"User","site_admin":false},"body":"This PR bring customization feature where plugins like blueocean can configure stapler and participate during property serialization and decide whether to fail or skip serialization. \r\n\r\nImplementation is pretty much based on @i386 [proposal](https://docs.google.com/document/d/1AalzfYZ0HDfwtFMUNaw_okWMLaaQ0S5Q1o6L4taevL4/edit#heading=h.vr11cprbtd0) sent at dev list some time back. Further this custom serialization approach is followup of [PR 89](https://github.com/stapler/stapler/pull/89#issuecomment-272307140) to fix it in generic way.","created_at":"2017-02-13T22:24:57Z","updated_at":"2017-02-22T15:59:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c46a3f1396bdb8f0bb8464ad3793084d29e652d","assignee":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"assignees":[{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},{"login":"daniel-beck","id":1831569,"avatar_url":"https://avatars.githubusercontent.com/u/1831569?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-beck","html_url":"https://github.com/daniel-beck","followers_url":"https://api.github.com/users/daniel-beck/followers","following_url":"https://api.github.com/users/daniel-beck/following{/other_user}","gists_url":"https://api.github.com/users/daniel-beck/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-beck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-beck/subscriptions","organizations_url":"https://api.github.com/users/daniel-beck/orgs","repos_url":"https://api.github.com/users/daniel-beck/repos","events_url":"https://api.github.com/users/daniel-beck/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-beck/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stapler/stapler/pulls/106/commits","review_comments_url":"https://api.github.com/repos/stapler/stapler/pulls/106/comments","review_comment_url":"https://api.github.com/repos/stapler/stapler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stapler/stapler/issues/106/comments","statuses_url":"https://api.github.com/repos/stapler/stapler/statuses/deda6c4d520fe1e2701f49bbe11f6a0482add6cf","head":{"label":"vivek:export-interceptor","ref":"export-interceptor","sha":"deda6c4d520fe1e2701f49bbe11f6a0482add6cf","user":{"login":"vivek","id":38139,"avatar_url":"https://avatars.githubusercontent.com/u/38139?v=3","gravatar_id":"","url":"https://api.github.com/users/vivek","html_url":"https://github.com/vivek","followers_url":"https://api.github.com/users/vivek/followers","following_url":"https://api.github.com/users/vivek/following{/other_user}","gists_url":"https://api.github.com/users/vivek/gists{/gist_id}","starred_url":"https://api.github.com/users/vivek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivek/subscriptions","organizations_url":"https://api.github.com/users/vivek/orgs","repos_url":"https://api.github.com/users/vivek/repos","events_url":"https://api.github.com/users/vivek/events{/privacy}","received_events_url":"https://api.github.com/users/vivek/received_events","type":"User","site_admin":false},"repo":{"id":60638394,"name":"stapler","full_name":"vivek/stapler","owner":{"login":"vivek","id":38139,"avatar_url":"https://avatars.githubusercontent.com/u/38139?v=3","gravatar_id":"","url":"https://api.github.com/users/vivek","html_url":"https://github.com/vivek","followers_url":"https://api.github.com/users/vivek/followers","following_url":"https://api.github.com/users/vivek/following{/other_user}","gists_url":"https://api.github.com/users/vivek/gists{/gist_id}","starred_url":"https://api.github.com/users/vivek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivek/subscriptions","organizations_url":"https://api.github.com/users/vivek/orgs","repos_url":"https://api.github.com/users/vivek/repos","events_url":"https://api.github.com/users/vivek/events{/privacy}","received_events_url":"https://api.github.com/users/vivek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vivek/stapler","description":"Stapler web framework","fork":true,"url":"https://api.github.com/repos/vivek/stapler","forks_url":"https://api.github.com/repos/vivek/stapler/forks","keys_url":"https://api.github.com/repos/vivek/stapler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vivek/stapler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vivek/stapler/teams","hooks_url":"https://api.github.com/repos/vivek/stapler/hooks","issue_events_url":"https://api.github.com/repos/vivek/stapler/issues/events{/number}","events_url":"https://api.github.com/repos/vivek/stapler/events","assignees_url":"https://api.github.com/repos/vivek/stapler/assignees{/user}","branches_url":"https://api.github.com/repos/vivek/stapler/branches{/branch}","tags_url":"https://api.github.com/repos/vivek/stapler/tags","blobs_url":"https://api.github.com/repos/vivek/stapler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vivek/stapler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vivek/stapler/git/refs{/sha}","trees_url":"https://api.github.com/repos/vivek/stapler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vivek/stapler/statuses/{sha}","languages_url":"https://api.github.com/repos/vivek/stapler/languages","stargazers_url":"https://api.github.com/repos/vivek/stapler/stargazers","contributors_url":"https://api.github.com/repos/vivek/stapler/contributors","subscribers_url":"https://api.github.com/repos/vivek/stapler/subscribers","subscription_url":"https://api.github.com/repos/vivek/stapler/subscription","commits_url":"https://api.github.com/repos/vivek/stapler/commits{/sha}","git_commits_url":"https://api.github.com/repos/vivek/stapler/git/commits{/sha}","comments_url":"https://api.github.com/repos/vivek/stapler/comments{/number}","issue_comment_url":"https://api.github.com/repos/vivek/stapler/issues/comments{/number}","contents_url":"https://api.github.com/repos/vivek/stapler/contents/{+path}","compare_url":"https://api.github.com/repos/vivek/stapler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vivek/stapler/merges","archive_url":"https://api.github.com/repos/vivek/stapler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vivek/stapler/downloads","issues_url":"https://api.github.com/repos/vivek/stapler/issues{/number}","pulls_url":"https://api.github.com/repos/vivek/stapler/pulls{/number}","milestones_url":"https://api.github.com/repos/vivek/stapler/milestones{/number}","notifications_url":"https://api.github.com/repos/vivek/stapler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vivek/stapler/labels{/name}","releases_url":"https://api.github.com/repos/vivek/stapler/releases{/id}","deployments_url":"https://api.github.com/repos/vivek/stapler/deployments","created_at":"2016-06-07T18:56:10Z","updated_at":"2016-06-07T18:56:12Z","pushed_at":"2017-02-22T00:21:29Z","git_url":"git://github.com/vivek/stapler.git","ssh_url":"[email protected]:vivek/stapler.git","clone_url":"https://github.com/vivek/stapler.git","svn_url":"https://github.com/vivek/stapler","homepage":"http://stapler.kohsuke.org/","size":35377,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stapler:master","ref":"master","sha":"98dc3b304ca8b8931288f480ba116a9471e5359c","user":{"login":"stapler","id":700341,"avatar_url":"https://avatars.githubusercontent.com/u/700341?v=3","gravatar_id":"","url":"https://api.github.com/users/stapler","html_url":"https://github.com/stapler","followers_url":"https://api.github.com/users/stapler/followers","following_url":"https://api.github.com/users/stapler/following{/other_user}","gists_url":"https://api.github.com/users/stapler/gists{/gist_id}","starred_url":"https://api.github.com/users/stapler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stapler/subscriptions","organizations_url":"https://api.github.com/users/stapler/orgs","repos_url":"https://api.github.com/users/stapler/repos","events_url":"https://api.github.com/users/stapler/events{/privacy}","received_events_url":"https://api.github.com/users/stapler/received_events","type":"Organization","site_admin":false},"repo":{"id":1548514,"name":"stapler","full_name":"stapler/stapler","owner":{"login":"stapler","id":700341,"avatar_url":"https://avatars.githubusercontent.com/u/700341?v=3","gravatar_id":"","url":"https://api.github.com/users/stapler","html_url":"https://github.com/stapler","followers_url":"https://api.github.com/users/stapler/followers","following_url":"https://api.github.com/users/stapler/following{/other_user}","gists_url":"https://api.github.com/users/stapler/gists{/gist_id}","starred_url":"https://api.github.com/users/stapler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stapler/subscriptions","organizations_url":"https://api.github.com/users/stapler/orgs","repos_url":"https://api.github.com/users/stapler/repos","events_url":"https://api.github.com/users/stapler/events{/privacy}","received_events_url":"https://api.github.com/users/stapler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stapler/stapler","description":"Stapler web framework","fork":false,"url":"https://api.github.com/repos/stapler/stapler","forks_url":"https://api.github.com/repos/stapler/stapler/forks","keys_url":"https://api.github.com/repos/stapler/stapler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stapler/stapler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stapler/stapler/teams","hooks_url":"https://api.github.com/repos/stapler/stapler/hooks","issue_events_url":"https://api.github.com/repos/stapler/stapler/issues/events{/number}","events_url":"https://api.github.com/repos/stapler/stapler/events","assignees_url":"https://api.github.com/repos/stapler/stapler/assignees{/user}","branches_url":"https://api.github.com/repos/stapler/stapler/branches{/branch}","tags_url":"https://api.github.com/repos/stapler/stapler/tags","blobs_url":"https://api.github.com/repos/stapler/stapler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stapler/stapler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stapler/stapler/git/refs{/sha}","trees_url":"https://api.github.com/repos/stapler/stapler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stapler/stapler/statuses/{sha}","languages_url":"https://api.github.com/repos/stapler/stapler/languages","stargazers_url":"https://api.github.com/repos/stapler/stapler/stargazers","contributors_url":"https://api.github.com/repos/stapler/stapler/contributors","subscribers_url":"https://api.github.com/repos/stapler/stapler/subscribers","subscription_url":"https://api.github.com/repos/stapler/stapler/subscription","commits_url":"https://api.github.com/repos/stapler/stapler/commits{/sha}","git_commits_url":"https://api.github.com/repos/stapler/stapler/git/commits{/sha}","comments_url":"https://api.github.com/repos/stapler/stapler/comments{/number}","issue_comment_url":"https://api.github.com/repos/stapler/stapler/issues/comments{/number}","contents_url":"https://api.github.com/repos/stapler/stapler/contents/{+path}","compare_url":"https://api.github.com/repos/stapler/stapler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stapler/stapler/merges","archive_url":"https://api.github.com/repos/stapler/stapler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stapler/stapler/downloads","issues_url":"https://api.github.com/repos/stapler/stapler/issues{/number}","pulls_url":"https://api.github.com/repos/stapler/stapler/pulls{/number}","milestones_url":"https://api.github.com/repos/stapler/stapler/milestones{/number}","notifications_url":"https://api.github.com/repos/stapler/stapler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stapler/stapler/labels{/name}","releases_url":"https://api.github.com/repos/stapler/stapler/releases{/id}","deployments_url":"https://api.github.com/repos/stapler/stapler/deployments","created_at":"2011-03-30T22:39:45Z","updated_at":"2017-01-22T04:46:02Z","pushed_at":"2017-02-22T00:21:30Z","git_url":"git://github.com/stapler/stapler.git","ssh_url":"[email protected]:stapler/stapler.git","clone_url":"https://github.com/stapler/stapler.git","svn_url":"https://github.com/stapler/stapler","homepage":"http://stapler.kohsuke.org/","size":38825,"stargazers_count":77,"watchers_count":77,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":56,"mirror_url":null,"open_issues_count":19,"forks":56,"open_issues":19,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stapler/stapler/pulls/106"},"html":{"href":"https://github.com/stapler/stapler/pull/106"},"issue":{"href":"https://api.github.com/repos/stapler/stapler/issues/106"},"comments":{"href":"https://api.github.com/repos/stapler/stapler/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/stapler/stapler/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/stapler/stapler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stapler/stapler/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/stapler/stapler/statuses/deda6c4d520fe1e2701f49bbe11f6a0482add6cf"}}}} | {
"id": 1548514,
"name": "stapler/stapler",
"url": "https://api.github.com/repos/stapler/stapler"
} | {
"id": 154109,
"login": "jglick",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/154109?",
"url": "https://api.github.com/users/jglick"
} | {
"id": 700341,
"login": "stapler",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/700341?",
"url": "https://api.github.com/orgs/stapler"
} | 2017-02-22T15:56:39 | 5371110741 | {"actor":{"display_login":"jglick"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/systemd/systemd/pulls/comments/112541970","pull_request_review_id":33865692,"id":112541970,"diff_hunk":"@@ -949,22 +950,44 @@ static int job_dispatch_timer(sd_event_source *s, uint64_t monotonic, void *user\n return 0;\n }\n \n-int job_start_timer(Job *j) {\n+int job_start_timer(Job *j, bool job_running) {\n int r;\n+ usec_t run_begin, timeout_time, old_timeout_time;\n \n- if (j->timer_event_source)\n- return 0;\n+ if (job_running) {\n+ if (j->unit->job_running_timeout == USEC_INFINITY)\n+ return 0;\n \n- j->begin_usec = now(CLOCK_MONOTONIC);\n+ run_begin = now(CLOCK_MONOTONIC);\n+ timeout_time = usec_add(run_begin, j->unit->job_running_timeout);\n \n- if (j->unit->job_timeout == USEC_INFINITY)\n- return 0;\n+ if (j->timer_event_source) {\n+ /* Update only if JobRunningTimeoutSec= results in earlier timeout */\n+ (void) sd_event_source_get_time(j->timer_event_source, &old_timeout_time);","path":"src/core/job.c","position":31,"original_position":31,"commit_id":"54a1581ea575d5a515d086d209cd7fbe0496d7ba","original_commit_id":"9bed26d95d07f9ddc9e7550152296d7b85ef46d9","user":{"login":"keszybz","id":349618,"avatar_url":"https://avatars2.githubusercontent.com/u/349618?v=3","gravatar_id":"","url":"https://api.github.com/users/keszybz","html_url":"https://github.com/keszybz","followers_url":"https://api.github.com/users/keszybz/followers","following_url":"https://api.github.com/users/keszybz/following{/other_user}","gists_url":"https://api.github.com/users/keszybz/gists{/gist_id}","starred_url":"https://api.github.com/users/keszybz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keszybz/subscriptions","organizations_url":"https://api.github.com/users/keszybz/orgs","repos_url":"https://api.github.com/users/keszybz/repos","events_url":"https://api.github.com/users/keszybz/events{/privacy}","received_events_url":"https://api.github.com/users/keszybz/received_events","type":"User","site_admin":false},"body":"What happens if this calls returns an error? `old_timeout_time` will be used uninitialized.","created_at":"2017-04-20T19:35:10Z","updated_at":"2017-04-20T19:45:36Z","html_url":"https://github.com/systemd/systemd/pull/5164#discussion_r112541970","pull_request_url":"https://api.github.com/repos/systemd/systemd/pulls/5164","_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments/112541970"},"html":{"href":"https://github.com/systemd/systemd/pull/5164#discussion_r112541970"},"pull_request":{"href":"https://api.github.com/repos/systemd/systemd/pulls/5164"}}},"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/5164","id":103368768,"html_url":"https://github.com/systemd/systemd/pull/5164","diff_url":"https://github.com/systemd/systemd/pull/5164.diff","patch_url":"https://github.com/systemd/systemd/pull/5164.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/5164","number":5164,"state":"open","locked":false,"title":"Ordering for _netdev devices","user":{"login":"Werkov","id":630751,"avatar_url":"https://avatars3.githubusercontent.com/u/630751?v=3","gravatar_id":"","url":"https://api.github.com/users/Werkov","html_url":"https://github.com/Werkov","followers_url":"https://api.github.com/users/Werkov/followers","following_url":"https://api.github.com/users/Werkov/following{/other_user}","gists_url":"https://api.github.com/users/Werkov/gists{/gist_id}","starred_url":"https://api.github.com/users/Werkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Werkov/subscriptions","organizations_url":"https://api.github.com/users/Werkov/orgs","repos_url":"https://api.github.com/users/Werkov/repos","events_url":"https://api.github.com/users/Werkov/events{/privacy}","received_events_url":"https://api.github.com/users/Werkov/received_events","type":"User","site_admin":false},"body":"Please see respective commit messages for explanation of the changes.\r\n\r\nTL;DR Network devices (e.g. iSCSI) timeouts are effectively (and confusingly) reduced by network initialization time.\r\n\r\nTo demonstrate the effect of the patch a dummy device unit with 30 seconds job timeout was specified. Compare the ordering against the `network-online.target`.\r\n\r\nWithout patches:\r\n> Jan 26 18:56:04 localhost systemd[1]: mnt-dummy.mount: Installed new job mnt-dummy.mount/start as 263\r\n> Jan 26 18:56:04 localhost systemd[1]: dev-dummy\\x2ddevice.device: Installed new job dev-dummy\\x2ddevice.device/start as 264\r\n> Jan 26 18:56:31 germ79 systemd[1]: Reached target Network.\r\n> Jan 26 18:56:31 germ79 systemd[1]: Reached target Network is Online.\r\n> Jan 26 18:56:35 germ79 systemd[1]: dev-dummy\\x2ddevice.device: Job dev-dummy\\x2ddevice.device/start timed out.\r\n> Jan 26 18:56:35 germ79 systemd[1]: dev-dummy\\x2ddevice.device: Job dev-dummy\\x2ddevice.device/start finished, result=timeout\r\n\r\nWith the patches:\r\n> Jan 26 19:11:52 localhost systemd[1]: dev-dummy\\x2ddevice.device: Installed new job dev-dummy\\x2ddevice.device/start as 265\r\n> Jan 26 19:11:52 localhost systemd[1]: mnt-dummy.mount: Installed new job mnt-dummy.mount/start as 264\r\n> Jan 26 19:12:17 germ79 systemd[1]: Reached target Network.\r\n> Jan 26 19:12:17 germ79 systemd[1]: Reached target Network is Online.\r\n> Jan 26 19:12:47 germ79 systemd[1]: dev-dummy\\x2ddevice.device: Job dev-dummy\\x2ddevice.device/start timed out.\r\n> Jan 26 19:12:47 germ79 systemd[1]: dev-dummy\\x2ddevice.device: Job dev-dummy\\x2ddevice.device/start finished, result=timeout\r\n\r\n","created_at":"2017-01-26T19:07:13Z","updated_at":"2017-04-20T19:45:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d97bd504997a90547e754e6e40b24fb12540557","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/5164/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/5164/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/5164/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/54a1581ea575d5a515d086d209cd7fbe0496d7ba","head":{"label":"Werkov:ordering-for-_netdev-devices","ref":"ordering-for-_netdev-devices","sha":"54a1581ea575d5a515d086d209cd7fbe0496d7ba","user":{"login":"Werkov","id":630751,"avatar_url":"https://avatars3.githubusercontent.com/u/630751?v=3","gravatar_id":"","url":"https://api.github.com/users/Werkov","html_url":"https://github.com/Werkov","followers_url":"https://api.github.com/users/Werkov/followers","following_url":"https://api.github.com/users/Werkov/following{/other_user}","gists_url":"https://api.github.com/users/Werkov/gists{/gist_id}","starred_url":"https://api.github.com/users/Werkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Werkov/subscriptions","organizations_url":"https://api.github.com/users/Werkov/orgs","repos_url":"https://api.github.com/users/Werkov/repos","events_url":"https://api.github.com/users/Werkov/events{/privacy}","received_events_url":"https://api.github.com/users/Werkov/received_events","type":"User","site_admin":false},"repo":{"id":56610675,"name":"systemd","full_name":"Werkov/systemd","owner":{"login":"Werkov","id":630751,"avatar_url":"https://avatars3.githubusercontent.com/u/630751?v=3","gravatar_id":"","url":"https://api.github.com/users/Werkov","html_url":"https://github.com/Werkov","followers_url":"https://api.github.com/users/Werkov/followers","following_url":"https://api.github.com/users/Werkov/following{/other_user}","gists_url":"https://api.github.com/users/Werkov/gists{/gist_id}","starred_url":"https://api.github.com/users/Werkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Werkov/subscriptions","organizations_url":"https://api.github.com/users/Werkov/orgs","repos_url":"https://api.github.com/users/Werkov/repos","events_url":"https://api.github.com/users/Werkov/events{/privacy}","received_events_url":"https://api.github.com/users/Werkov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Werkov/systemd","description":"systemd upstream","fork":true,"url":"https://api.github.com/repos/Werkov/systemd","forks_url":"https://api.github.com/repos/Werkov/systemd/forks","keys_url":"https://api.github.com/repos/Werkov/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Werkov/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Werkov/systemd/teams","hooks_url":"https://api.github.com/repos/Werkov/systemd/hooks","issue_events_url":"https://api.github.com/repos/Werkov/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/Werkov/systemd/events","assignees_url":"https://api.github.com/repos/Werkov/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/Werkov/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/Werkov/systemd/tags","blobs_url":"https://api.github.com/repos/Werkov/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Werkov/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Werkov/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Werkov/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Werkov/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/Werkov/systemd/languages","stargazers_url":"https://api.github.com/repos/Werkov/systemd/stargazers","contributors_url":"https://api.github.com/repos/Werkov/systemd/contributors","subscribers_url":"https://api.github.com/repos/Werkov/systemd/subscribers","subscription_url":"https://api.github.com/repos/Werkov/systemd/subscription","commits_url":"https://api.github.com/repos/Werkov/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Werkov/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Werkov/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Werkov/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Werkov/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/Werkov/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Werkov/systemd/merges","archive_url":"https://api.github.com/repos/Werkov/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Werkov/systemd/downloads","issues_url":"https://api.github.com/repos/Werkov/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/Werkov/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/Werkov/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/Werkov/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Werkov/systemd/labels{/name}","releases_url":"https://api.github.com/repos/Werkov/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/Werkov/systemd/deployments","created_at":"2016-04-19T15:50:44Z","updated_at":"2016-04-19T15:50:51Z","pushed_at":"2017-04-12T14:46:07Z","git_url":"git://github.com/Werkov/systemd.git","ssh_url":"[email protected]:Werkov/systemd.git","clone_url":"https://github.com/Werkov/systemd.git","svn_url":"https://github.com/Werkov/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":69320,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"6cb484cc062b79db925f04cb8bb7a5cfac622d51","user":{"login":"systemd","id":1918868,"avatar_url":"https://avatars3.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"avatar_url":"https://avatars3.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"systemd System and Service Manager","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/systemd/systemd/deployments","created_at":"2015-03-25T15:27:27Z","updated_at":"2017-04-20T01:07:27Z","pushed_at":"2017-04-20T19:09:14Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"[email protected]:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":69502,"stargazers_count":1805,"watchers_count":1805,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":768,"mirror_url":null,"open_issues_count":663,"forks":768,"open_issues":663,"watchers":1805,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/5164"},"html":{"href":"https://github.com/systemd/systemd/pull/5164"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/5164"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/5164/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/5164/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/5164/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/54a1581ea575d5a515d086d209cd7fbe0496d7ba"}}}} | {
"id": 32873313,
"name": "systemd/systemd",
"url": "https://api.github.com/repos/systemd/systemd"
} | {
"id": 349618,
"login": "keszybz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/349618?",
"url": "https://api.github.com/users/keszybz"
} | {
"id": 1918868,
"login": "systemd",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1918868?",
"url": "https://api.github.com/orgs/systemd"
} | 2017-04-20T19:35:10 | 5726771553 | {"actor":{"display_login":"keszybz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/tableau/tableau-log-viewer/pulls/comments/146382825","pull_request_review_id":71317120,"id":146382825,"diff_hunk":"@@ -405,7 +405,7 @@ bool MainWindow::LoadLogFile(QString path)\n QFileInfo fi(path);\n if (!fi.exists() || !fi.isFile())\n {\n- statusBar()->showMessage(QString(\"Unable to locate '%1'\").arg(path), 10000);","path":"src/mainwindow.cpp","position":145,"original_position":13,"commit_id":"fc608f759975ae41687b3e847be3b69496caea6f","original_commit_id":"fcf9689814e643441b768eb819d0ecca72a21fb0","user":{"login":"terencesoh","id":22226433,"avatar_url":"https://avatars3.githubusercontent.com/u/22226433?v=4","gravatar_id":"","url":"https://api.github.com/users/terencesoh","html_url":"https://github.com/terencesoh","followers_url":"https://api.github.com/users/terencesoh/followers","following_url":"https://api.github.com/users/terencesoh/following{/other_user}","gists_url":"https://api.github.com/users/terencesoh/gists{/gist_id}","starred_url":"https://api.github.com/users/terencesoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terencesoh/subscriptions","organizations_url":"https://api.github.com/users/terencesoh/orgs","repos_url":"https://api.github.com/users/terencesoh/repos","events_url":"https://api.github.com/users/terencesoh/events{/privacy}","received_events_url":"https://api.github.com/users/terencesoh/received_events","type":"User","site_admin":false},"body":"This check is also used for \"Open (beta) log.txt\" and \"Recent files\", which is more likely to encounter this error for me. \r\nDisabling the open log menu item would be more complicated as we also need a way to monitor the file and re-enable it when the file is created again.\r\nI think someone prefers the auto-dismiss error so you won't have to click a button to dismiss it every time. But as you noted, many people might not notice the error message in status bar. Ideally it could be an auto-dismiss dialog that's noticeable enough but yet not intrusive. But last time I did a quick 1-minute search, there isn't any in Qt.","created_at":"2017-10-23T20:23:19Z","updated_at":"2017-10-23T20:23:19Z","html_url":"https://github.com/tableau/tableau-log-viewer/pull/65#discussion_r146382825","pull_request_url":"https://api.github.com/repos/tableau/tableau-log-viewer/pulls/65","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tableau/tableau-log-viewer/pulls/comments/146382825"},"html":{"href":"https://github.com/tableau/tableau-log-viewer/pull/65#discussion_r146382825"},"pull_request":{"href":"https://api.github.com/repos/tableau/tableau-log-viewer/pulls/65"}},"in_reply_to_id":145820633},"pull_request":{"url":"https://api.github.com/repos/tableau/tableau-log-viewer/pulls/65","id":147658879,"html_url":"https://github.com/tableau/tableau-log-viewer/pull/65","diff_url":"https://github.com/tableau/tableau-log-viewer/pull/65.diff","patch_url":"https://github.com/tableau/tableau-log-viewer/pull/65.patch","issue_url":"https://api.github.com/repos/tableau/tableau-log-viewer/issues/65","number":65,"state":"open","locked":false,"title":"Misc bug fixes & small improvements","user":{"login":"vogelsgesang","id":6820896,"avatar_url":"https://avatars1.githubusercontent.com/u/6820896?v=4","gravatar_id":"","url":"https://api.github.com/users/vogelsgesang","html_url":"https://github.com/vogelsgesang","followers_url":"https://api.github.com/users/vogelsgesang/followers","following_url":"https://api.github.com/users/vogelsgesang/following{/other_user}","gists_url":"https://api.github.com/users/vogelsgesang/gists{/gist_id}","starred_url":"https://api.github.com/users/vogelsgesang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogelsgesang/subscriptions","organizations_url":"https://api.github.com/users/vogelsgesang/orgs","repos_url":"https://api.github.com/users/vogelsgesang/repos","events_url":"https://api.github.com/users/vogelsgesang/events{/privacy}","received_events_url":"https://api.github.com/users/vogelsgesang/received_events","type":"User","site_admin":false},"body":"This pull request fixes some minor bugs/usability issues.\r\nThe individual commit messages contain more detailed descriptions :)","created_at":"2017-10-19T20:34:09Z","updated_at":"2017-10-23T20:23:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f52e9ddfe6247c45fb7137582cb4e46774997b0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tableau/tableau-log-viewer/pulls/65/commits","review_comments_url":"https://api.github.com/repos/tableau/tableau-log-viewer/pulls/65/comments","review_comment_url":"https://api.github.com/repos/tableau/tableau-log-viewer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tableau/tableau-log-viewer/issues/65/comments","statuses_url":"https://api.github.com/repos/tableau/tableau-log-viewer/statuses/fc608f759975ae41687b3e847be3b69496caea6f","head":{"label":"vogelsgesang:dev","ref":"dev","sha":"fc608f759975ae41687b3e847be3b69496caea6f","user":{"login":"vogelsgesang","id":6820896,"avatar_url":"https://avatars1.githubusercontent.com/u/6820896?v=4","gravatar_id":"","url":"https://api.github.com/users/vogelsgesang","html_url":"https://github.com/vogelsgesang","followers_url":"https://api.github.com/users/vogelsgesang/followers","following_url":"https://api.github.com/users/vogelsgesang/following{/other_user}","gists_url":"https://api.github.com/users/vogelsgesang/gists{/gist_id}","starred_url":"https://api.github.com/users/vogelsgesang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogelsgesang/subscriptions","organizations_url":"https://api.github.com/users/vogelsgesang/orgs","repos_url":"https://api.github.com/users/vogelsgesang/repos","events_url":"https://api.github.com/users/vogelsgesang/events{/privacy}","received_events_url":"https://api.github.com/users/vogelsgesang/received_events","type":"User","site_admin":false},"repo":{"id":103025724,"name":"tableau-log-viewer","full_name":"vogelsgesang/tableau-log-viewer","owner":{"login":"vogelsgesang","id":6820896,"avatar_url":"https://avatars1.githubusercontent.com/u/6820896?v=4","gravatar_id":"","url":"https://api.github.com/users/vogelsgesang","html_url":"https://github.com/vogelsgesang","followers_url":"https://api.github.com/users/vogelsgesang/followers","following_url":"https://api.github.com/users/vogelsgesang/following{/other_user}","gists_url":"https://api.github.com/users/vogelsgesang/gists{/gist_id}","starred_url":"https://api.github.com/users/vogelsgesang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogelsgesang/subscriptions","organizations_url":"https://api.github.com/users/vogelsgesang/orgs","repos_url":"https://api.github.com/users/vogelsgesang/repos","events_url":"https://api.github.com/users/vogelsgesang/events{/privacy}","received_events_url":"https://api.github.com/users/vogelsgesang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vogelsgesang/tableau-log-viewer","description":"Tableau Log Viewer is cross-platform tool for quickly glancing over Tableau log files","fork":true,"url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer","forks_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/forks","keys_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/teams","hooks_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/hooks","issue_events_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/issues/events{/number}","events_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/events","assignees_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/assignees{/user}","branches_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/branches{/branch}","tags_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/tags","blobs_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/git/refs{/sha}","trees_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/statuses/{sha}","languages_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/languages","stargazers_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/stargazers","contributors_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/contributors","subscribers_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/subscribers","subscription_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/subscription","commits_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/commits{/sha}","git_commits_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/git/commits{/sha}","comments_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/comments{/number}","issue_comment_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/issues/comments{/number}","contents_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/contents/{+path}","compare_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/merges","archive_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/downloads","issues_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/issues{/number}","pulls_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/pulls{/number}","milestones_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/milestones{/number}","notifications_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/labels{/name}","releases_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/releases{/id}","deployments_url":"https://api.github.com/repos/vogelsgesang/tableau-log-viewer/deployments","created_at":"2017-09-10T11:58:00Z","updated_at":"2017-09-10T11:58:01Z","pushed_at":"2017-10-19T20:33:25Z","git_url":"git://github.com/vogelsgesang/tableau-log-viewer.git","ssh_url":"[email protected]:vogelsgesang/tableau-log-viewer.git","clone_url":"https://github.com/vogelsgesang/tableau-log-viewer.git","svn_url":"https://github.com/vogelsgesang/tableau-log-viewer","homepage":"","size":767,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tableau:dev","ref":"dev","sha":"bf274efa73c9427f2f304620e89588299da143b5","user":{"login":"tableau","id":828667,"avatar_url":"https://avatars3.githubusercontent.com/u/828667?v=4","gravatar_id":"","url":"https://api.github.com/users/tableau","html_url":"https://github.com/tableau","followers_url":"https://api.github.com/users/tableau/followers","following_url":"https://api.github.com/users/tableau/following{/other_user}","gists_url":"https://api.github.com/users/tableau/gists{/gist_id}","starred_url":"https://api.github.com/users/tableau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tableau/subscriptions","organizations_url":"https://api.github.com/users/tableau/orgs","repos_url":"https://api.github.com/users/tableau/repos","events_url":"https://api.github.com/users/tableau/events{/privacy}","received_events_url":"https://api.github.com/users/tableau/received_events","type":"Organization","site_admin":false},"repo":{"id":68328227,"name":"tableau-log-viewer","full_name":"tableau/tableau-log-viewer","owner":{"login":"tableau","id":828667,"avatar_url":"https://avatars3.githubusercontent.com/u/828667?v=4","gravatar_id":"","url":"https://api.github.com/users/tableau","html_url":"https://github.com/tableau","followers_url":"https://api.github.com/users/tableau/followers","following_url":"https://api.github.com/users/tableau/following{/other_user}","gists_url":"https://api.github.com/users/tableau/gists{/gist_id}","starred_url":"https://api.github.com/users/tableau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tableau/subscriptions","organizations_url":"https://api.github.com/users/tableau/orgs","repos_url":"https://api.github.com/users/tableau/repos","events_url":"https://api.github.com/users/tableau/events{/privacy}","received_events_url":"https://api.github.com/users/tableau/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tableau/tableau-log-viewer","description":"Tableau Log Viewer is cross-platform tool for quickly glancing over Tableau log files","fork":false,"url":"https://api.github.com/repos/tableau/tableau-log-viewer","forks_url":"https://api.github.com/repos/tableau/tableau-log-viewer/forks","keys_url":"https://api.github.com/repos/tableau/tableau-log-viewer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tableau/tableau-log-viewer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tableau/tableau-log-viewer/teams","hooks_url":"https://api.github.com/repos/tableau/tableau-log-viewer/hooks","issue_events_url":"https://api.github.com/repos/tableau/tableau-log-viewer/issues/events{/number}","events_url":"https://api.github.com/repos/tableau/tableau-log-viewer/events","assignees_url":"https://api.github.com/repos/tableau/tableau-log-viewer/assignees{/user}","branches_url":"https://api.github.com/repos/tableau/tableau-log-viewer/branches{/branch}","tags_url":"https://api.github.com/repos/tableau/tableau-log-viewer/tags","blobs_url":"https://api.github.com/repos/tableau/tableau-log-viewer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tableau/tableau-log-viewer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tableau/tableau-log-viewer/git/refs{/sha}","trees_url":"https://api.github.com/repos/tableau/tableau-log-viewer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tableau/tableau-log-viewer/statuses/{sha}","languages_url":"https://api.github.com/repos/tableau/tableau-log-viewer/languages","stargazers_url":"https://api.github.com/repos/tableau/tableau-log-viewer/stargazers","contributors_url":"https://api.github.com/repos/tableau/tableau-log-viewer/contributors","subscribers_url":"https://api.github.com/repos/tableau/tableau-log-viewer/subscribers","subscription_url":"https://api.github.com/repos/tableau/tableau-log-viewer/subscription","commits_url":"https://api.github.com/repos/tableau/tableau-log-viewer/commits{/sha}","git_commits_url":"https://api.github.com/repos/tableau/tableau-log-viewer/git/commits{/sha}","comments_url":"https://api.github.com/repos/tableau/tableau-log-viewer/comments{/number}","issue_comment_url":"https://api.github.com/repos/tableau/tableau-log-viewer/issues/comments{/number}","contents_url":"https://api.github.com/repos/tableau/tableau-log-viewer/contents/{+path}","compare_url":"https://api.github.com/repos/tableau/tableau-log-viewer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tableau/tableau-log-viewer/merges","archive_url":"https://api.github.com/repos/tableau/tableau-log-viewer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tableau/tableau-log-viewer/downloads","issues_url":"https://api.github.com/repos/tableau/tableau-log-viewer/issues{/number}","pulls_url":"https://api.github.com/repos/tableau/tableau-log-viewer/pulls{/number}","milestones_url":"https://api.github.com/repos/tableau/tableau-log-viewer/milestones{/number}","notifications_url":"https://api.github.com/repos/tableau/tableau-log-viewer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tableau/tableau-log-viewer/labels{/name}","releases_url":"https://api.github.com/repos/tableau/tableau-log-viewer/releases{/id}","deployments_url":"https://api.github.com/repos/tableau/tableau-log-viewer/deployments","created_at":"2016-09-15T20:19:05Z","updated_at":"2017-10-11T22:13:22Z","pushed_at":"2017-10-19T20:34:10Z","git_url":"git://github.com/tableau/tableau-log-viewer.git","ssh_url":"[email protected]:tableau/tableau-log-viewer.git","clone_url":"https://github.com/tableau/tableau-log-viewer.git","svn_url":"https://github.com/tableau/tableau-log-viewer","homepage":"","size":751,"stargazers_count":23,"watchers_count":23,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":6,"forks":9,"open_issues":6,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tableau/tableau-log-viewer/pulls/65"},"html":{"href":"https://github.com/tableau/tableau-log-viewer/pull/65"},"issue":{"href":"https://api.github.com/repos/tableau/tableau-log-viewer/issues/65"},"comments":{"href":"https://api.github.com/repos/tableau/tableau-log-viewer/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/tableau/tableau-log-viewer/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/tableau/tableau-log-viewer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tableau/tableau-log-viewer/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/tableau/tableau-log-viewer/statuses/fc608f759975ae41687b3e847be3b69496caea6f"}},"author_association":"NONE"}} | {
"id": 68328227,
"name": "tableau/tableau-log-viewer",
"url": "https://api.github.com/repos/tableau/tableau-log-viewer"
} | {
"id": 22226433,
"login": "terencesoh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22226433?",
"url": "https://api.github.com/users/terencesoh"
} | {
"id": 828667,
"login": "tableau",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/828667?",
"url": "https://api.github.com/orgs/tableau"
} | 2017-10-23T20:23:19 | 6754566064 | {"actor":{"display_login":"terencesoh"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/teambit/bit/pulls/comments/134159632","pull_request_review_id":57418124,"id":134159632,"diff_hunk":"@@ -654,12 +655,13 @@ describe('bit import', function () {\n });\n it('should create an index.js file on the component root dir pointing to the main file', () => {\n const expectedLocation = path.join('components', 'bar', 'foo', 'index.js');\n+ console.log(expectedLocation)","path":"e2e/commands/import.e2e.js","position":91,"original_position":91,"commit_id":"390532d9d1875d9e051f172ca163fa7b38108278","original_commit_id":"390532d9d1875d9e051f172ca163fa7b38108278","user":{"login":"GiladShoham","id":3840769,"avatar_url":"https://avatars0.githubusercontent.com/u/3840769?v=4","gravatar_id":"","url":"https://api.github.com/users/GiladShoham","html_url":"https://github.com/GiladShoham","followers_url":"https://api.github.com/users/GiladShoham/followers","following_url":"https://api.github.com/users/GiladShoham/following{/other_user}","gists_url":"https://api.github.com/users/GiladShoham/gists{/gist_id}","starred_url":"https://api.github.com/users/GiladShoham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GiladShoham/subscriptions","organizations_url":"https://api.github.com/users/GiladShoham/orgs","repos_url":"https://api.github.com/users/GiladShoham/repos","events_url":"https://api.github.com/users/GiladShoham/events{/privacy}","received_events_url":"https://api.github.com/users/GiladShoham/received_events","type":"User","site_admin":false},"body":"old debug console?","created_at":"2017-08-21T07:20:15Z","updated_at":"2017-08-21T07:22:22Z","html_url":"https://github.com/teambit/bit/pull/218#discussion_r134159632","pull_request_url":"https://api.github.com/repos/teambit/bit/pulls/218","_links":{"self":{"href":"https://api.github.com/repos/teambit/bit/pulls/comments/134159632"},"html":{"href":"https://github.com/teambit/bit/pull/218#discussion_r134159632"},"pull_request":{"href":"https://api.github.com/repos/teambit/bit/pulls/218"}}},"pull_request":{"url":"https://api.github.com/repos/teambit/bit/pulls/218","id":136017636,"html_url":"https://github.com/teambit/bit/pull/218","diff_url":"https://github.com/teambit/bit/pull/218.diff","patch_url":"https://github.com/teambit/bit/pull/218.patch","issue_url":"https://api.github.com/repos/teambit/bit/issues/218","number":218,"state":"open","locked":false,"title":"Windows support","user":{"login":"amitgilad3","id":7702311,"avatar_url":"https://avatars0.githubusercontent.com/u/7702311?v=4","gravatar_id":"","url":"https://api.github.com/users/amitgilad3","html_url":"https://github.com/amitgilad3","followers_url":"https://api.github.com/users/amitgilad3/followers","following_url":"https://api.github.com/users/amitgilad3/following{/other_user}","gists_url":"https://api.github.com/users/amitgilad3/gists{/gist_id}","starred_url":"https://api.github.com/users/amitgilad3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitgilad3/subscriptions","organizations_url":"https://api.github.com/users/amitgilad3/orgs","repos_url":"https://api.github.com/users/amitgilad3/repos","events_url":"https://api.github.com/users/amitgilad3/events{/privacy}","received_events_url":"https://api.github.com/users/amitgilad3/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-16T12:58:40Z","updated_at":"2017-08-21T07:22:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2053ca09fa61b0a5695ec0da6d93bcf8215f1d91","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/teambit/bit/pulls/218/commits","review_comments_url":"https://api.github.com/repos/teambit/bit/pulls/218/comments","review_comment_url":"https://api.github.com/repos/teambit/bit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/teambit/bit/issues/218/comments","statuses_url":"https://api.github.com/repos/teambit/bit/statuses/390532d9d1875d9e051f172ca163fa7b38108278","head":{"label":"teambit:windows","ref":"windows","sha":"390532d9d1875d9e051f172ca163fa7b38108278","user":{"login":"teambit","id":24789812,"avatar_url":"https://avatars1.githubusercontent.com/u/24789812?v=4","gravatar_id":"","url":"https://api.github.com/users/teambit","html_url":"https://github.com/teambit","followers_url":"https://api.github.com/users/teambit/followers","following_url":"https://api.github.com/users/teambit/following{/other_user}","gists_url":"https://api.github.com/users/teambit/gists{/gist_id}","starred_url":"https://api.github.com/users/teambit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teambit/subscriptions","organizations_url":"https://api.github.com/users/teambit/orgs","repos_url":"https://api.github.com/users/teambit/repos","events_url":"https://api.github.com/users/teambit/events{/privacy}","received_events_url":"https://api.github.com/users/teambit/received_events","type":"Organization","site_admin":false},"repo":{"id":79723839,"name":"bit","full_name":"teambit/bit","owner":{"login":"teambit","id":24789812,"avatar_url":"https://avatars1.githubusercontent.com/u/24789812?v=4","gravatar_id":"","url":"https://api.github.com/users/teambit","html_url":"https://github.com/teambit","followers_url":"https://api.github.com/users/teambit/followers","following_url":"https://api.github.com/users/teambit/following{/other_user}","gists_url":"https://api.github.com/users/teambit/gists{/gist_id}","starred_url":"https://api.github.com/users/teambit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teambit/subscriptions","organizations_url":"https://api.github.com/users/teambit/orgs","repos_url":"https://api.github.com/users/teambit/repos","events_url":"https://api.github.com/users/teambit/events{/privacy}","received_events_url":"https://api.github.com/users/teambit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teambit/bit","description":"Turn your existing source code into a collection of reusable components. Develop and compose components from any application environment.","fork":false,"url":"https://api.github.com/repos/teambit/bit","forks_url":"https://api.github.com/repos/teambit/bit/forks","keys_url":"https://api.github.com/repos/teambit/bit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teambit/bit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teambit/bit/teams","hooks_url":"https://api.github.com/repos/teambit/bit/hooks","issue_events_url":"https://api.github.com/repos/teambit/bit/issues/events{/number}","events_url":"https://api.github.com/repos/teambit/bit/events","assignees_url":"https://api.github.com/repos/teambit/bit/assignees{/user}","branches_url":"https://api.github.com/repos/teambit/bit/branches{/branch}","tags_url":"https://api.github.com/repos/teambit/bit/tags","blobs_url":"https://api.github.com/repos/teambit/bit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teambit/bit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teambit/bit/git/refs{/sha}","trees_url":"https://api.github.com/repos/teambit/bit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teambit/bit/statuses/{sha}","languages_url":"https://api.github.com/repos/teambit/bit/languages","stargazers_url":"https://api.github.com/repos/teambit/bit/stargazers","contributors_url":"https://api.github.com/repos/teambit/bit/contributors","subscribers_url":"https://api.github.com/repos/teambit/bit/subscribers","subscription_url":"https://api.github.com/repos/teambit/bit/subscription","commits_url":"https://api.github.com/repos/teambit/bit/commits{/sha}","git_commits_url":"https://api.github.com/repos/teambit/bit/git/commits{/sha}","comments_url":"https://api.github.com/repos/teambit/bit/comments{/number}","issue_comment_url":"https://api.github.com/repos/teambit/bit/issues/comments{/number}","contents_url":"https://api.github.com/repos/teambit/bit/contents/{+path}","compare_url":"https://api.github.com/repos/teambit/bit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teambit/bit/merges","archive_url":"https://api.github.com/repos/teambit/bit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teambit/bit/downloads","issues_url":"https://api.github.com/repos/teambit/bit/issues{/number}","pulls_url":"https://api.github.com/repos/teambit/bit/pulls{/number}","milestones_url":"https://api.github.com/repos/teambit/bit/milestones{/number}","notifications_url":"https://api.github.com/repos/teambit/bit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teambit/bit/labels{/name}","releases_url":"https://api.github.com/repos/teambit/bit/releases{/id}","deployments_url":"https://api.github.com/repos/teambit/bit/deployments","created_at":"2017-01-22T14:51:43Z","updated_at":"2017-08-21T05:15:06Z","pushed_at":"2017-08-21T07:15:44Z","git_url":"git://github.com/teambit/bit.git","ssh_url":"[email protected]:teambit/bit.git","clone_url":"https://github.com/teambit/bit.git","svn_url":"https://github.com/teambit/bit","homepage":"https://bitsrc.io","size":33090,"stargazers_count":680,"watchers_count":680,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":33,"mirror_url":null,"open_issues_count":19,"forks":33,"open_issues":19,"watchers":680,"default_branch":"master"}},"base":{"label":"teambit:master","ref":"master","sha":"a191e50d9806cf52c1c73c9cae7d748666e436fa","user":{"login":"teambit","id":24789812,"avatar_url":"https://avatars1.githubusercontent.com/u/24789812?v=4","gravatar_id":"","url":"https://api.github.com/users/teambit","html_url":"https://github.com/teambit","followers_url":"https://api.github.com/users/teambit/followers","following_url":"https://api.github.com/users/teambit/following{/other_user}","gists_url":"https://api.github.com/users/teambit/gists{/gist_id}","starred_url":"https://api.github.com/users/teambit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teambit/subscriptions","organizations_url":"https://api.github.com/users/teambit/orgs","repos_url":"https://api.github.com/users/teambit/repos","events_url":"https://api.github.com/users/teambit/events{/privacy}","received_events_url":"https://api.github.com/users/teambit/received_events","type":"Organization","site_admin":false},"repo":{"id":79723839,"name":"bit","full_name":"teambit/bit","owner":{"login":"teambit","id":24789812,"avatar_url":"https://avatars1.githubusercontent.com/u/24789812?v=4","gravatar_id":"","url":"https://api.github.com/users/teambit","html_url":"https://github.com/teambit","followers_url":"https://api.github.com/users/teambit/followers","following_url":"https://api.github.com/users/teambit/following{/other_user}","gists_url":"https://api.github.com/users/teambit/gists{/gist_id}","starred_url":"https://api.github.com/users/teambit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teambit/subscriptions","organizations_url":"https://api.github.com/users/teambit/orgs","repos_url":"https://api.github.com/users/teambit/repos","events_url":"https://api.github.com/users/teambit/events{/privacy}","received_events_url":"https://api.github.com/users/teambit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teambit/bit","description":"Turn your existing source code into a collection of reusable components. Develop and compose components from any application environment.","fork":false,"url":"https://api.github.com/repos/teambit/bit","forks_url":"https://api.github.com/repos/teambit/bit/forks","keys_url":"https://api.github.com/repos/teambit/bit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teambit/bit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teambit/bit/teams","hooks_url":"https://api.github.com/repos/teambit/bit/hooks","issue_events_url":"https://api.github.com/repos/teambit/bit/issues/events{/number}","events_url":"https://api.github.com/repos/teambit/bit/events","assignees_url":"https://api.github.com/repos/teambit/bit/assignees{/user}","branches_url":"https://api.github.com/repos/teambit/bit/branches{/branch}","tags_url":"https://api.github.com/repos/teambit/bit/tags","blobs_url":"https://api.github.com/repos/teambit/bit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teambit/bit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teambit/bit/git/refs{/sha}","trees_url":"https://api.github.com/repos/teambit/bit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teambit/bit/statuses/{sha}","languages_url":"https://api.github.com/repos/teambit/bit/languages","stargazers_url":"https://api.github.com/repos/teambit/bit/stargazers","contributors_url":"https://api.github.com/repos/teambit/bit/contributors","subscribers_url":"https://api.github.com/repos/teambit/bit/subscribers","subscription_url":"https://api.github.com/repos/teambit/bit/subscription","commits_url":"https://api.github.com/repos/teambit/bit/commits{/sha}","git_commits_url":"https://api.github.com/repos/teambit/bit/git/commits{/sha}","comments_url":"https://api.github.com/repos/teambit/bit/comments{/number}","issue_comment_url":"https://api.github.com/repos/teambit/bit/issues/comments{/number}","contents_url":"https://api.github.com/repos/teambit/bit/contents/{+path}","compare_url":"https://api.github.com/repos/teambit/bit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teambit/bit/merges","archive_url":"https://api.github.com/repos/teambit/bit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teambit/bit/downloads","issues_url":"https://api.github.com/repos/teambit/bit/issues{/number}","pulls_url":"https://api.github.com/repos/teambit/bit/pulls{/number}","milestones_url":"https://api.github.com/repos/teambit/bit/milestones{/number}","notifications_url":"https://api.github.com/repos/teambit/bit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teambit/bit/labels{/name}","releases_url":"https://api.github.com/repos/teambit/bit/releases{/id}","deployments_url":"https://api.github.com/repos/teambit/bit/deployments","created_at":"2017-01-22T14:51:43Z","updated_at":"2017-08-21T05:15:06Z","pushed_at":"2017-08-21T07:15:44Z","git_url":"git://github.com/teambit/bit.git","ssh_url":"[email protected]:teambit/bit.git","clone_url":"https://github.com/teambit/bit.git","svn_url":"https://github.com/teambit/bit","homepage":"https://bitsrc.io","size":33090,"stargazers_count":680,"watchers_count":680,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":33,"mirror_url":null,"open_issues_count":19,"forks":33,"open_issues":19,"watchers":680,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/teambit/bit/pulls/218"},"html":{"href":"https://github.com/teambit/bit/pull/218"},"issue":{"href":"https://api.github.com/repos/teambit/bit/issues/218"},"comments":{"href":"https://api.github.com/repos/teambit/bit/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/teambit/bit/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/teambit/bit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/teambit/bit/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/teambit/bit/statuses/390532d9d1875d9e051f172ca163fa7b38108278"}}}} | {
"id": 79723839,
"name": "teambit/bit",
"url": "https://api.github.com/repos/teambit/bit"
} | {
"id": 3840769,
"login": "GiladShoham",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3840769?",
"url": "https://api.github.com/users/GiladShoham"
} | {
"id": 24789812,
"login": "teambit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24789812?",
"url": "https://api.github.com/orgs/teambit"
} | 2017-08-21T07:20:15 | 6490474475 | {"actor":{"display_login":"GiladShoham"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/telerik/ios-device-lib/pulls/comments/100993418","pull_request_review_id":21709254,"id":100993418,"diff_hunk":"@@ -0,0 +1,106 @@\n+\"use strict\";\n+\n+const EventEmitter = require(\"events\");\n+const path = require(\"path\");\n+const os = require(\"os\");\n+const spawn = require(\"child_process\").spawn;\n+\n+const bufferpack = require(\"bufferpack\");\n+const Constants = require(\"./constants\");\n+\n+const HeaderSize = 4;\n+\n+class IOSDeviceLibStdioHandler extends EventEmitter {\n+\tconstructor() {\n+\t\tsuper();\n+\t\tthis._unfinishedMessage = new Buffer(0);\n+\t}\n+\n+\tstartReadingData() {\n+\t\tthis._chProc = spawn(path.join(__dirname, \"bin\", os.platform(), os.arch(), \"ios-device-lib\"));\n+\t\tthis._chProc.stdout.on(\"data\", (data) => {\n+\t\t\tthis._unpackMessages(data);\n+\t\t});\n+\t}\n+\n+\twriteData(data) {\n+\t\tthis._chProc.stdin.write(data);\n+\t}\n+\n+\tdispose(signal) {\n+\t\tthis.removeAllListeners();\n+\t\tthis._chProc.removeAllListeners();\n+\t\tthis._chProc.kill(signal);\n+\t}\n+\n+\t_distributeMessage(message) {\n+\t\tif (message.event) {\n+\t\t\tswitch (message.event) {\n+\t\t\t\tcase Constants.DeviceEventEnum.kDeviceFound:\n+\t\t\t\t\tthis.emit(Constants.DeviceFoundEventName, message);\n+\t\t\t\t\tbreak;\n+\t\t\t\tcase DeviceEventEnum.kDeviceLost:\n+\t\t\t\t\tthis.emit(Constants.DeviceLostEventName, message);\n+\t\t\t\t\tbreak;\n+\t\t\t\tcase DeviceEventEnum.kDeviceTrusted:\n+\t\t\t\t\tthis.emit(Constants.DeviceLostEventName, message);\n+\t\t\t\t\tthis.emit(Constants.DeviceFoundEventName, message);\n+\t\t\t\t\tbreak;\n+\t\t\t}\n+\t\t} else {\n+\t\t\tthis.emit(Constants.DataEventName, message);\n+\t\t}\n+\t}\n+\n+\t_unpackMessages(data) {\n+\t\tif (!this._unfinishedMessage.length && data.length >= HeaderSize) {\n+\t\t\t// Get the message length header.\n+\t\t\tconst messageSizeBuffer = data.slice(0, HeaderSize);\n+\t\t\tconst messageLength = bufferpack.unpack(\">i\", messageSizeBuffer)[0];\n+\n+\t\t\tif (messageLength > data.length - HeaderSize) {\n+\t\t\t\t// Less than one message in the buffer.\n+\t\t\t\t// Store the unfinished message untill the next call of the function.\n+\t\t\t\tthis._unfinishedMessage = data;\n+\t\t\t} else if (data.length - 4 > messageLength) {\n+\t\t\t\t// More than one message in the buffer.\n+\t\t\t\tconst messageBuffer = this._getMessageFromBuffer(data, messageLength);\n+\n+\t\t\t\t// Get the rest of the message here.\n+\t\t\t\t// Since our messages are not separated by whitespace or newlie\n+\t\t\t\t// we do not need to add somethig when we slice the original buffer.\n+\t\t\t\tconst slicedBuffer = data.slice(messageBuffer.length + HeaderSize);\n+\t\t\t\tthis._distributeMessage(this._parseMessageFromBuffer(messageBuffer));\n+\t\t\t\tthis._unpackMessages(slicedBuffer);\n+\t\t\t} else {\n+\t\t\t\t// One message in the buffer.\n+\t\t\t\tconst messageBuffer = this._getMessageFromBuffer(data, messageLength);\n+\t\t\t\tthis._distributeMessage(this._parseMessageFromBuffer(messageBuffer));\n+\t\t\t}\n+\t\t} else if (this._unfinishedMessage.length && data.length >= HeaderSize) {\n+\t\t\t// Append the new data to the unfinished message and try to unpack again.\n+\t\t\tconst concatenatedMessage = Buffer.concat([this._unfinishedMessage, data]);\n+\n+\t\t\t// Clear the unfinished message buffer.\n+\t\t\tthis._unfinishedMessage = new Buffer(0);","path":"ios-device-lib-stdio-handler.js","position":85,"original_position":85,"commit_id":"9a9c4648b55b7fc5ff9a47c9afce71db204e432a","original_commit_id":"9a9c4648b55b7fc5ff9a47c9afce71db204e432a","user":{"login":"rosen-vladimirov","id":8351653,"avatar_url":"https://avatars.githubusercontent.com/u/8351653?v=3","gravatar_id":"","url":"https://api.github.com/users/rosen-vladimirov","html_url":"https://github.com/rosen-vladimirov","followers_url":"https://api.github.com/users/rosen-vladimirov/followers","following_url":"https://api.github.com/users/rosen-vladimirov/following{/other_user}","gists_url":"https://api.github.com/users/rosen-vladimirov/gists{/gist_id}","starred_url":"https://api.github.com/users/rosen-vladimirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosen-vladimirov/subscriptions","organizations_url":"https://api.github.com/users/rosen-vladimirov/orgs","repos_url":"https://api.github.com/users/rosen-vladimirov/repos","events_url":"https://api.github.com/users/rosen-vladimirov/events{/privacy}","received_events_url":"https://api.github.com/users/rosen-vladimirov/received_events","type":"User","site_admin":false},"body":"`new Buffer` is deprecated\r\nhttps://nodejs.org/api/buffer.html#buffer_new_buffer_size","created_at":"2017-02-14T09:46:38Z","updated_at":"2017-02-14T09:48:10Z","html_url":"https://github.com/telerik/ios-device-lib/pull/2#discussion_r100993418","pull_request_url":"https://api.github.com/repos/telerik/ios-device-lib/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/telerik/ios-device-lib/pulls/comments/100993418"},"html":{"href":"https://github.com/telerik/ios-device-lib/pull/2#discussion_r100993418"},"pull_request":{"href":"https://api.github.com/repos/telerik/ios-device-lib/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/telerik/ios-device-lib/pulls/2","id":105919113,"html_url":"https://github.com/telerik/ios-device-lib/pull/2","diff_url":"https://github.com/telerik/ios-device-lib/pull/2.diff","patch_url":"https://github.com/telerik/ios-device-lib/pull/2.patch","issue_url":"https://api.github.com/repos/telerik/ios-device-lib/issues/2","number":2,"state":"open","locked":false,"title":"Fix device log bug","user":{"login":"TsvetanMilanov","id":10463529,"avatar_url":"https://avatars.githubusercontent.com/u/10463529?v=3","gravatar_id":"","url":"https://api.github.com/users/TsvetanMilanov","html_url":"https://github.com/TsvetanMilanov","followers_url":"https://api.github.com/users/TsvetanMilanov/followers","following_url":"https://api.github.com/users/TsvetanMilanov/following{/other_user}","gists_url":"https://api.github.com/users/TsvetanMilanov/gists{/gist_id}","starred_url":"https://api.github.com/users/TsvetanMilanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsvetanMilanov/subscriptions","organizations_url":"https://api.github.com/users/TsvetanMilanov/orgs","repos_url":"https://api.github.com/users/TsvetanMilanov/repos","events_url":"https://api.github.com/users/TsvetanMilanov/events{/privacy}","received_events_url":"https://api.github.com/users/TsvetanMilanov/received_events","type":"User","site_admin":false},"body":"When we get the device log the C++ code starts to print on the stdout and in the JavaScript code we listen for the data event. If there is enough time between each message which is printed on the stdout the data event is raised with only one message. If the C++ code starts to print on the stdout too fast (which is the case with the device log) NodeJS buffers all the data and emits data event with all the buffered data. This breaks out code because we expect only one message. The solution for this problem is to write method which will \"parse\" the buffered data. This method should check the header of the received buffered data and read message from the buffered data. If there is full message in the buffered data we will read it. If there is no full message we should store the unfinished message and on the next received buffered data we should concat the unfinished message and the new data and try to parse the concatenated message. We rely on that the first message should have header with length. After that the method will make sure that the unfinished message will always begin with header with length and that each recursive call will receive data which begins with header with length.\r\n\r\nWhile testing the new method with 7 threads which print on the stdout we noticed that at some point the data which is printed on the stdout gets malformed. For example with this message:\r\n```JSON\r\n{\"message1\":\"Feb 10 13:59: 28 dragon - iPhone6 timed[65] <Notice> : (Error)TimeLink : B76E090A - 9807 - 4AA3 - BB01 - 3CDE3DD48D55(4 \\n- TMLSSourceDevice) send failure(Error Domain = com.apple.identityservices.error Code = 23 UserInfo=0x12fe326f0 {NSLocalizedDescription=Timed out, NSUnderlyingError=0x12fe34190 The operation couldnt be completed. (com.apple.ids.idssenderrordomain error 12.)}), will retry\"}\r\n```\r\nwe receive random number of messages before we receive one message with additional `}`. With one thread we do not receive malformed output. To solve this problem we need to add mutex in the print method and make it thread safe.","created_at":"2017-02-13T15:44:48Z","updated_at":"2017-02-14T09:48:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d31358ed216f7411a6bdb6b5145a29fdc1c2cc9","assignee":{"login":"TsvetanMilanov","id":10463529,"avatar_url":"https://avatars.githubusercontent.com/u/10463529?v=3","gravatar_id":"","url":"https://api.github.com/users/TsvetanMilanov","html_url":"https://github.com/TsvetanMilanov","followers_url":"https://api.github.com/users/TsvetanMilanov/followers","following_url":"https://api.github.com/users/TsvetanMilanov/following{/other_user}","gists_url":"https://api.github.com/users/TsvetanMilanov/gists{/gist_id}","starred_url":"https://api.github.com/users/TsvetanMilanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsvetanMilanov/subscriptions","organizations_url":"https://api.github.com/users/TsvetanMilanov/orgs","repos_url":"https://api.github.com/users/TsvetanMilanov/repos","events_url":"https://api.github.com/users/TsvetanMilanov/events{/privacy}","received_events_url":"https://api.github.com/users/TsvetanMilanov/received_events","type":"User","site_admin":false},"assignees":[{"login":"TsvetanMilanov","id":10463529,"avatar_url":"https://avatars.githubusercontent.com/u/10463529?v=3","gravatar_id":"","url":"https://api.github.com/users/TsvetanMilanov","html_url":"https://github.com/TsvetanMilanov","followers_url":"https://api.github.com/users/TsvetanMilanov/followers","following_url":"https://api.github.com/users/TsvetanMilanov/following{/other_user}","gists_url":"https://api.github.com/users/TsvetanMilanov/gists{/gist_id}","starred_url":"https://api.github.com/users/TsvetanMilanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsvetanMilanov/subscriptions","organizations_url":"https://api.github.com/users/TsvetanMilanov/orgs","repos_url":"https://api.github.com/users/TsvetanMilanov/repos","events_url":"https://api.github.com/users/TsvetanMilanov/events{/privacy}","received_events_url":"https://api.github.com/users/TsvetanMilanov/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/telerik/ios-device-lib/pulls/2/commits","review_comments_url":"https://api.github.com/repos/telerik/ios-device-lib/pulls/2/comments","review_comment_url":"https://api.github.com/repos/telerik/ios-device-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/telerik/ios-device-lib/issues/2/comments","statuses_url":"https://api.github.com/repos/telerik/ios-device-lib/statuses/9a9c4648b55b7fc5ff9a47c9afce71db204e432a","head":{"label":"telerik:milanov/fix-device-log-bug","ref":"milanov/fix-device-log-bug","sha":"9a9c4648b55b7fc5ff9a47c9afce71db204e432a","user":{"login":"telerik","id":568561,"avatar_url":"https://avatars.githubusercontent.com/u/568561?v=3","gravatar_id":"","url":"https://api.github.com/users/telerik","html_url":"https://github.com/telerik","followers_url":"https://api.github.com/users/telerik/followers","following_url":"https://api.github.com/users/telerik/following{/other_user}","gists_url":"https://api.github.com/users/telerik/gists{/gist_id}","starred_url":"https://api.github.com/users/telerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telerik/subscriptions","organizations_url":"https://api.github.com/users/telerik/orgs","repos_url":"https://api.github.com/users/telerik/repos","events_url":"https://api.github.com/users/telerik/events{/privacy}","received_events_url":"https://api.github.com/users/telerik/received_events","type":"Organization","site_admin":false},"repo":{"id":81075175,"name":"ios-device-lib","full_name":"telerik/ios-device-lib","owner":{"login":"telerik","id":568561,"avatar_url":"https://avatars.githubusercontent.com/u/568561?v=3","gravatar_id":"","url":"https://api.github.com/users/telerik","html_url":"https://github.com/telerik","followers_url":"https://api.github.com/users/telerik/followers","following_url":"https://api.github.com/users/telerik/following{/other_user}","gists_url":"https://api.github.com/users/telerik/gists{/gist_id}","starred_url":"https://api.github.com/users/telerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telerik/subscriptions","organizations_url":"https://api.github.com/users/telerik/orgs","repos_url":"https://api.github.com/users/telerik/repos","events_url":"https://api.github.com/users/telerik/events{/privacy}","received_events_url":"https://api.github.com/users/telerik/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telerik/ios-device-lib","description":"Allows interaction with iOS devices.","fork":false,"url":"https://api.github.com/repos/telerik/ios-device-lib","forks_url":"https://api.github.com/repos/telerik/ios-device-lib/forks","keys_url":"https://api.github.com/repos/telerik/ios-device-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telerik/ios-device-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telerik/ios-device-lib/teams","hooks_url":"https://api.github.com/repos/telerik/ios-device-lib/hooks","issue_events_url":"https://api.github.com/repos/telerik/ios-device-lib/issues/events{/number}","events_url":"https://api.github.com/repos/telerik/ios-device-lib/events","assignees_url":"https://api.github.com/repos/telerik/ios-device-lib/assignees{/user}","branches_url":"https://api.github.com/repos/telerik/ios-device-lib/branches{/branch}","tags_url":"https://api.github.com/repos/telerik/ios-device-lib/tags","blobs_url":"https://api.github.com/repos/telerik/ios-device-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telerik/ios-device-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telerik/ios-device-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/telerik/ios-device-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telerik/ios-device-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/telerik/ios-device-lib/languages","stargazers_url":"https://api.github.com/repos/telerik/ios-device-lib/stargazers","contributors_url":"https://api.github.com/repos/telerik/ios-device-lib/contributors","subscribers_url":"https://api.github.com/repos/telerik/ios-device-lib/subscribers","subscription_url":"https://api.github.com/repos/telerik/ios-device-lib/subscription","commits_url":"https://api.github.com/repos/telerik/ios-device-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/telerik/ios-device-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/telerik/ios-device-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/telerik/ios-device-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/telerik/ios-device-lib/contents/{+path}","compare_url":"https://api.github.com/repos/telerik/ios-device-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telerik/ios-device-lib/merges","archive_url":"https://api.github.com/repos/telerik/ios-device-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telerik/ios-device-lib/downloads","issues_url":"https://api.github.com/repos/telerik/ios-device-lib/issues{/number}","pulls_url":"https://api.github.com/repos/telerik/ios-device-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/telerik/ios-device-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/telerik/ios-device-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telerik/ios-device-lib/labels{/name}","releases_url":"https://api.github.com/repos/telerik/ios-device-lib/releases{/id}","deployments_url":"https://api.github.com/repos/telerik/ios-device-lib/deployments","created_at":"2017-02-06T10:22:44Z","updated_at":"2017-02-09T08:04:00Z","pushed_at":"2017-02-13T15:50:25Z","git_url":"git://github.com/telerik/ios-device-lib.git","ssh_url":"[email protected]:telerik/ios-device-lib.git","clone_url":"https://github.com/telerik/ios-device-lib.git","svn_url":"https://github.com/telerik/ios-device-lib","homepage":null,"size":481,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"telerik:master","ref":"master","sha":"8336a7274077689eeb24c75f1aa900cdfe623821","user":{"login":"telerik","id":568561,"avatar_url":"https://avatars.githubusercontent.com/u/568561?v=3","gravatar_id":"","url":"https://api.github.com/users/telerik","html_url":"https://github.com/telerik","followers_url":"https://api.github.com/users/telerik/followers","following_url":"https://api.github.com/users/telerik/following{/other_user}","gists_url":"https://api.github.com/users/telerik/gists{/gist_id}","starred_url":"https://api.github.com/users/telerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telerik/subscriptions","organizations_url":"https://api.github.com/users/telerik/orgs","repos_url":"https://api.github.com/users/telerik/repos","events_url":"https://api.github.com/users/telerik/events{/privacy}","received_events_url":"https://api.github.com/users/telerik/received_events","type":"Organization","site_admin":false},"repo":{"id":81075175,"name":"ios-device-lib","full_name":"telerik/ios-device-lib","owner":{"login":"telerik","id":568561,"avatar_url":"https://avatars.githubusercontent.com/u/568561?v=3","gravatar_id":"","url":"https://api.github.com/users/telerik","html_url":"https://github.com/telerik","followers_url":"https://api.github.com/users/telerik/followers","following_url":"https://api.github.com/users/telerik/following{/other_user}","gists_url":"https://api.github.com/users/telerik/gists{/gist_id}","starred_url":"https://api.github.com/users/telerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telerik/subscriptions","organizations_url":"https://api.github.com/users/telerik/orgs","repos_url":"https://api.github.com/users/telerik/repos","events_url":"https://api.github.com/users/telerik/events{/privacy}","received_events_url":"https://api.github.com/users/telerik/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telerik/ios-device-lib","description":"Allows interaction with iOS devices.","fork":false,"url":"https://api.github.com/repos/telerik/ios-device-lib","forks_url":"https://api.github.com/repos/telerik/ios-device-lib/forks","keys_url":"https://api.github.com/repos/telerik/ios-device-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telerik/ios-device-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telerik/ios-device-lib/teams","hooks_url":"https://api.github.com/repos/telerik/ios-device-lib/hooks","issue_events_url":"https://api.github.com/repos/telerik/ios-device-lib/issues/events{/number}","events_url":"https://api.github.com/repos/telerik/ios-device-lib/events","assignees_url":"https://api.github.com/repos/telerik/ios-device-lib/assignees{/user}","branches_url":"https://api.github.com/repos/telerik/ios-device-lib/branches{/branch}","tags_url":"https://api.github.com/repos/telerik/ios-device-lib/tags","blobs_url":"https://api.github.com/repos/telerik/ios-device-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telerik/ios-device-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telerik/ios-device-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/telerik/ios-device-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telerik/ios-device-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/telerik/ios-device-lib/languages","stargazers_url":"https://api.github.com/repos/telerik/ios-device-lib/stargazers","contributors_url":"https://api.github.com/repos/telerik/ios-device-lib/contributors","subscribers_url":"https://api.github.com/repos/telerik/ios-device-lib/subscribers","subscription_url":"https://api.github.com/repos/telerik/ios-device-lib/subscription","commits_url":"https://api.github.com/repos/telerik/ios-device-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/telerik/ios-device-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/telerik/ios-device-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/telerik/ios-device-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/telerik/ios-device-lib/contents/{+path}","compare_url":"https://api.github.com/repos/telerik/ios-device-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telerik/ios-device-lib/merges","archive_url":"https://api.github.com/repos/telerik/ios-device-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telerik/ios-device-lib/downloads","issues_url":"https://api.github.com/repos/telerik/ios-device-lib/issues{/number}","pulls_url":"https://api.github.com/repos/telerik/ios-device-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/telerik/ios-device-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/telerik/ios-device-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telerik/ios-device-lib/labels{/name}","releases_url":"https://api.github.com/repos/telerik/ios-device-lib/releases{/id}","deployments_url":"https://api.github.com/repos/telerik/ios-device-lib/deployments","created_at":"2017-02-06T10:22:44Z","updated_at":"2017-02-09T08:04:00Z","pushed_at":"2017-02-13T15:50:25Z","git_url":"git://github.com/telerik/ios-device-lib.git","ssh_url":"[email protected]:telerik/ios-device-lib.git","clone_url":"https://github.com/telerik/ios-device-lib.git","svn_url":"https://github.com/telerik/ios-device-lib","homepage":null,"size":481,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/telerik/ios-device-lib/pulls/2"},"html":{"href":"https://github.com/telerik/ios-device-lib/pull/2"},"issue":{"href":"https://api.github.com/repos/telerik/ios-device-lib/issues/2"},"comments":{"href":"https://api.github.com/repos/telerik/ios-device-lib/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/telerik/ios-device-lib/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/telerik/ios-device-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/telerik/ios-device-lib/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/telerik/ios-device-lib/statuses/9a9c4648b55b7fc5ff9a47c9afce71db204e432a"}}}} | {
"id": 81075175,
"name": "telerik/ios-device-lib",
"url": "https://api.github.com/repos/telerik/ios-device-lib"
} | {
"id": 8351653,
"login": "rosen-vladimirov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8351653?",
"url": "https://api.github.com/users/rosen-vladimirov"
} | {
"id": 568561,
"login": "telerik",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/568561?",
"url": "https://api.github.com/orgs/telerik"
} | 2017-02-14T09:46:38 | 5320198937 | {"actor":{"display_login":"rosen-vladimirov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/twisted/klein/pulls/comments/158428992","pull_request_review_id":85239623,"id":158428992,"diff_hunk":"@@ -0,0 +1,160 @@\n+# -*- test-case-name: klein.test.test_message -*-\n+# Copyright (c) 2017-2018. See LICENSE for details.\n+\n+\"\"\"\n+HTTP message API.\n+\"\"\"\n+\n+from typing import Any, Optional, Union\n+\n+from attr import attrib, attrs\n+from attr.validators import instance_of, optional\n+\n+from tubes.itube import IFount\n+\n+from twisted.internet.defer import Deferred, succeed\n+\n+from zope.interface import Attribute, Interface\n+\n+from ._headers import IHTTPHeaders\n+from ._tubes import bytesToFount, fountToBytes\n+\n+Any, Deferred, IFount, IHTTPHeaders, Optional # Silence linter\n+\n+\n+__all__ = ()\n+\n+\n+\n+# Interfaces\n+\n+class NoFountError(Exception):\n+ \"\"\"\n+ Request has no fount.\n+ This implies someone already accessed the body fount.\n+ \"\"\"\n+\n+\n+\n+class IHTTPMessage(Interface):\n+ \"\"\"\n+ HTTP entity.\n+ \"\"\"\n+\n+ headers = Attribute(\"Entity headers.\") # type: IHTTPHeaders\n+\n+\n+ def bodyAsFount():\n+ # type: () -> IFount\n+ \"\"\"\n+ The entity body, as a fount.\n+\n+ @note: The fount may only be accessed once.\n+ It provides a mechanism for accessing the body as a stream of data,\n+ potentially as it is read from the network, without having to cache\n+ the entire body, which may be large.\n+ Because there is no caching, it is not possible to \"start over\" by\n+ accessing the fount a second time.\n+ Attempting to do so will raise L{NoFountError}.\n+\n+ @raise NoFountError: If the fount has previously been accessed.\n+ \"\"\"\n+\n+\n+ def bodyAsBytes():\n+ # type: () -> Deferred[bytes]\n+ \"\"\"\n+ The entity body, as bytes.\n+\n+ @note: This necessarily reads the entire entity body into memory,\n+ which may be a problem if the body is large.\n+\n+ @note: This method caches the body, which means that unlike\n+ C{self.bodyAsFount}, calling it repeatedly will return the same\n+ data.\n+\n+ @note: This method accesses the fount (via C{self.bodyAsFount}), which\n+ means the fount will not be available afterwards, and that if\n+ C{self.bodyAsFount} has previously been called directly, this\n+ method will raise L{NoFountError}.\n+\n+ @raise NoFountError: If the fount has previously been accessed.\n+ \"\"\"\n+\n+\n+\n+# Code shared by internal implementations of IHTTPMessage\n+\n+InternalBody = Union[bytes, IFount]\n+\n+\n+\n+@attrs(frozen=False)\n+class MessageState(object):\n+ \"\"\"\n+ Internal mutable state for HTTP message implementations in L{klein}.\n+ \"\"\"\n+\n+ cachedBody = attrib(\n+ validator=optional(instance_of(bytes)), default=None, init=False\n+ ) # type: Optional[bytes]\n+\n+ fountExhausted = attrib(\n+ validator=instance_of(bool), default=False, init=False\n+ ) # type: bool\n+\n+\n+\n+def validateBody(instance, attribute, body):","path":"src/klein/_message.py","position":108,"original_position":108,"commit_id":"f308c46208248599231804af9784085cb81aa86b","original_commit_id":"f308c46208248599231804af9784085cb81aa86b","user":{"login":"moshez","id":422703,"avatar_url":"https://avatars0.githubusercontent.com/u/422703?v=4","gravatar_id":"","url":"https://api.github.com/users/moshez","html_url":"https://github.com/moshez","followers_url":"https://api.github.com/users/moshez/followers","following_url":"https://api.github.com/users/moshez/following{/other_user}","gists_url":"https://api.github.com/users/moshez/gists{/gist_id}","starred_url":"https://api.github.com/users/moshez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moshez/subscriptions","organizations_url":"https://api.github.com/users/moshez/orgs","repos_url":"https://api.github.com/users/moshez/repos","events_url":"https://api.github.com/users/moshez/events{/privacy}","received_events_url":"https://api.github.com/users/moshez/received_events","type":"User","site_admin":false},"body":"Can you move this function before the class definition?","created_at":"2017-12-22T04:47:48Z","updated_at":"2017-12-22T04:57:09Z","html_url":"https://github.com/twisted/klein/pull/232#discussion_r158428992","pull_request_url":"https://api.github.com/repos/twisted/klein/pulls/232","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/twisted/klein/pulls/comments/158428992"},"html":{"href":"https://github.com/twisted/klein/pull/232#discussion_r158428992"},"pull_request":{"href":"https://api.github.com/repos/twisted/klein/pulls/232"}}},"pull_request":{"url":"https://api.github.com/repos/twisted/klein/pulls/232","id":159054056,"html_url":"https://github.com/twisted/klein/pull/232","diff_url":"https://github.com/twisted/klein/pull/232.diff","patch_url":"https://github.com/twisted/klein/pull/232.patch","issue_url":"https://api.github.com/repos/twisted/klein/issues/232","number":232,"state":"open","locked":false,"title":"Add new request and response API","user":{"login":"wsanchez","id":50002,"avatar_url":"https://avatars1.githubusercontent.com/u/50002?v=4","gravatar_id":"","url":"https://api.github.com/users/wsanchez","html_url":"https://github.com/wsanchez","followers_url":"https://api.github.com/users/wsanchez/followers","following_url":"https://api.github.com/users/wsanchez/following{/other_user}","gists_url":"https://api.github.com/users/wsanchez/gists{/gist_id}","starred_url":"https://api.github.com/users/wsanchez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsanchez/subscriptions","organizations_url":"https://api.github.com/users/wsanchez/orgs","repos_url":"https://api.github.com/users/wsanchez/repos","events_url":"https://api.github.com/users/wsanchez/events{/privacy}","received_events_url":"https://api.github.com/users/wsanchez/received_events","type":"User","site_admin":false},"body":"This adds:\r\n * `_message.py`: A new `IHTTPMessage` interface and some functions for use by implementations.\r\n * `_response.py`: A new `IHTTPResponse` interface, which is a superset of `IHTTPMessage` and `FrozenHTTPResponse` implementation.\r\n * _request.py`: A new `IHTTPRequest ` interface, which is a superset of `IHTTPMessage` and `FrozenHTTPRequest ` implementation.\r\n * `_tubes.py`: Implements to code that allows converting `bytes` to a fount and back, and an `IOFount` class that wraps an FLO as a fount. This code should eventually live in Tubes. Note that the implementation of `IOFount` is not optimal, as it doesn't stream IO. That can be done later; the point here is to establish an API for streaming in `IHTTPMessage`.\r\n","created_at":"2017-12-19T00:49:48Z","updated_at":"2017-12-22T04:57:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16be4c6bde5f4a8ccfe0f295db3e2dc1c5d863ac","assignee":{"login":"wsanchez","id":50002,"avatar_url":"https://avatars1.githubusercontent.com/u/50002?v=4","gravatar_id":"","url":"https://api.github.com/users/wsanchez","html_url":"https://github.com/wsanchez","followers_url":"https://api.github.com/users/wsanchez/followers","following_url":"https://api.github.com/users/wsanchez/following{/other_user}","gists_url":"https://api.github.com/users/wsanchez/gists{/gist_id}","starred_url":"https://api.github.com/users/wsanchez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsanchez/subscriptions","organizations_url":"https://api.github.com/users/wsanchez/orgs","repos_url":"https://api.github.com/users/wsanchez/repos","events_url":"https://api.github.com/users/wsanchez/events{/privacy}","received_events_url":"https://api.github.com/users/wsanchez/received_events","type":"User","site_admin":false},"assignees":[{"login":"wsanchez","id":50002,"avatar_url":"https://avatars1.githubusercontent.com/u/50002?v=4","gravatar_id":"","url":"https://api.github.com/users/wsanchez","html_url":"https://github.com/wsanchez","followers_url":"https://api.github.com/users/wsanchez/followers","following_url":"https://api.github.com/users/wsanchez/following{/other_user}","gists_url":"https://api.github.com/users/wsanchez/gists{/gist_id}","starred_url":"https://api.github.com/users/wsanchez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsanchez/subscriptions","organizations_url":"https://api.github.com/users/wsanchez/orgs","repos_url":"https://api.github.com/users/wsanchez/repos","events_url":"https://api.github.com/users/wsanchez/events{/privacy}","received_events_url":"https://api.github.com/users/wsanchez/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/twisted/klein/pulls/232/commits","review_comments_url":"https://api.github.com/repos/twisted/klein/pulls/232/comments","review_comment_url":"https://api.github.com/repos/twisted/klein/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twisted/klein/issues/232/comments","statuses_url":"https://api.github.com/repos/twisted/klein/statuses/f308c46208248599231804af9784085cb81aa86b","head":{"label":"twisted:request","ref":"request","sha":"f308c46208248599231804af9784085cb81aa86b","user":{"login":"twisted","id":716546,"avatar_url":"https://avatars3.githubusercontent.com/u/716546?v=4","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"repo":{"id":3409513,"name":"klein","full_name":"twisted/klein","owner":{"login":"twisted","id":716546,"avatar_url":"https://avatars3.githubusercontent.com/u/716546?v=4","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twisted/klein","description":"werkzeug + twisted.web","fork":false,"url":"https://api.github.com/repos/twisted/klein","forks_url":"https://api.github.com/repos/twisted/klein/forks","keys_url":"https://api.github.com/repos/twisted/klein/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twisted/klein/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twisted/klein/teams","hooks_url":"https://api.github.com/repos/twisted/klein/hooks","issue_events_url":"https://api.github.com/repos/twisted/klein/issues/events{/number}","events_url":"https://api.github.com/repos/twisted/klein/events","assignees_url":"https://api.github.com/repos/twisted/klein/assignees{/user}","branches_url":"https://api.github.com/repos/twisted/klein/branches{/branch}","tags_url":"https://api.github.com/repos/twisted/klein/tags","blobs_url":"https://api.github.com/repos/twisted/klein/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twisted/klein/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twisted/klein/git/refs{/sha}","trees_url":"https://api.github.com/repos/twisted/klein/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twisted/klein/statuses/{sha}","languages_url":"https://api.github.com/repos/twisted/klein/languages","stargazers_url":"https://api.github.com/repos/twisted/klein/stargazers","contributors_url":"https://api.github.com/repos/twisted/klein/contributors","subscribers_url":"https://api.github.com/repos/twisted/klein/subscribers","subscription_url":"https://api.github.com/repos/twisted/klein/subscription","commits_url":"https://api.github.com/repos/twisted/klein/commits{/sha}","git_commits_url":"https://api.github.com/repos/twisted/klein/git/commits{/sha}","comments_url":"https://api.github.com/repos/twisted/klein/comments{/number}","issue_comment_url":"https://api.github.com/repos/twisted/klein/issues/comments{/number}","contents_url":"https://api.github.com/repos/twisted/klein/contents/{+path}","compare_url":"https://api.github.com/repos/twisted/klein/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twisted/klein/merges","archive_url":"https://api.github.com/repos/twisted/klein/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twisted/klein/downloads","issues_url":"https://api.github.com/repos/twisted/klein/issues{/number}","pulls_url":"https://api.github.com/repos/twisted/klein/pulls{/number}","milestones_url":"https://api.github.com/repos/twisted/klein/milestones{/number}","notifications_url":"https://api.github.com/repos/twisted/klein/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twisted/klein/labels{/name}","releases_url":"https://api.github.com/repos/twisted/klein/releases{/id}","deployments_url":"https://api.github.com/repos/twisted/klein/deployments","created_at":"2012-02-10T17:55:04Z","updated_at":"2017-12-19T15:05:36Z","pushed_at":"2017-12-19T19:30:21Z","git_url":"git://github.com/twisted/klein.git","ssh_url":"[email protected]:twisted/klein.git","clone_url":"https://github.com/twisted/klein.git","svn_url":"https://github.com/twisted/klein","homepage":"","size":597,"stargazers_count":590,"watchers_count":590,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":92,"mirror_url":null,"archived":false,"open_issues_count":56,"license":null,"forks":92,"open_issues":56,"watchers":590,"default_branch":"master"}},"base":{"label":"twisted:master","ref":"master","sha":"b423124a79b7b9917c545e1eef4d095af0cdd9d8","user":{"login":"twisted","id":716546,"avatar_url":"https://avatars3.githubusercontent.com/u/716546?v=4","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"repo":{"id":3409513,"name":"klein","full_name":"twisted/klein","owner":{"login":"twisted","id":716546,"avatar_url":"https://avatars3.githubusercontent.com/u/716546?v=4","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twisted/klein","description":"werkzeug + twisted.web","fork":false,"url":"https://api.github.com/repos/twisted/klein","forks_url":"https://api.github.com/repos/twisted/klein/forks","keys_url":"https://api.github.com/repos/twisted/klein/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twisted/klein/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twisted/klein/teams","hooks_url":"https://api.github.com/repos/twisted/klein/hooks","issue_events_url":"https://api.github.com/repos/twisted/klein/issues/events{/number}","events_url":"https://api.github.com/repos/twisted/klein/events","assignees_url":"https://api.github.com/repos/twisted/klein/assignees{/user}","branches_url":"https://api.github.com/repos/twisted/klein/branches{/branch}","tags_url":"https://api.github.com/repos/twisted/klein/tags","blobs_url":"https://api.github.com/repos/twisted/klein/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twisted/klein/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twisted/klein/git/refs{/sha}","trees_url":"https://api.github.com/repos/twisted/klein/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twisted/klein/statuses/{sha}","languages_url":"https://api.github.com/repos/twisted/klein/languages","stargazers_url":"https://api.github.com/repos/twisted/klein/stargazers","contributors_url":"https://api.github.com/repos/twisted/klein/contributors","subscribers_url":"https://api.github.com/repos/twisted/klein/subscribers","subscription_url":"https://api.github.com/repos/twisted/klein/subscription","commits_url":"https://api.github.com/repos/twisted/klein/commits{/sha}","git_commits_url":"https://api.github.com/repos/twisted/klein/git/commits{/sha}","comments_url":"https://api.github.com/repos/twisted/klein/comments{/number}","issue_comment_url":"https://api.github.com/repos/twisted/klein/issues/comments{/number}","contents_url":"https://api.github.com/repos/twisted/klein/contents/{+path}","compare_url":"https://api.github.com/repos/twisted/klein/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twisted/klein/merges","archive_url":"https://api.github.com/repos/twisted/klein/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twisted/klein/downloads","issues_url":"https://api.github.com/repos/twisted/klein/issues{/number}","pulls_url":"https://api.github.com/repos/twisted/klein/pulls{/number}","milestones_url":"https://api.github.com/repos/twisted/klein/milestones{/number}","notifications_url":"https://api.github.com/repos/twisted/klein/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twisted/klein/labels{/name}","releases_url":"https://api.github.com/repos/twisted/klein/releases{/id}","deployments_url":"https://api.github.com/repos/twisted/klein/deployments","created_at":"2012-02-10T17:55:04Z","updated_at":"2017-12-19T15:05:36Z","pushed_at":"2017-12-19T19:30:21Z","git_url":"git://github.com/twisted/klein.git","ssh_url":"[email protected]:twisted/klein.git","clone_url":"https://github.com/twisted/klein.git","svn_url":"https://github.com/twisted/klein","homepage":"","size":597,"stargazers_count":590,"watchers_count":590,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":92,"mirror_url":null,"archived":false,"open_issues_count":56,"license":null,"forks":92,"open_issues":56,"watchers":590,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twisted/klein/pulls/232"},"html":{"href":"https://github.com/twisted/klein/pull/232"},"issue":{"href":"https://api.github.com/repos/twisted/klein/issues/232"},"comments":{"href":"https://api.github.com/repos/twisted/klein/issues/232/comments"},"review_comments":{"href":"https://api.github.com/repos/twisted/klein/pulls/232/comments"},"review_comment":{"href":"https://api.github.com/repos/twisted/klein/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twisted/klein/pulls/232/commits"},"statuses":{"href":"https://api.github.com/repos/twisted/klein/statuses/f308c46208248599231804af9784085cb81aa86b"}},"author_association":"OWNER"}} | {
"id": 3409513,
"name": "twisted/klein",
"url": "https://api.github.com/repos/twisted/klein"
} | {
"id": 422703,
"login": "moshez",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/422703?",
"url": "https://api.github.com/users/moshez"
} | {
"id": 716546,
"login": "twisted",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/716546?",
"url": "https://api.github.com/orgs/twisted"
} | 2017-12-22T04:47:48 | 7021499896 | {"actor":{"display_login":"moshez"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/twitter/heron/pulls/comments/131628476","pull_request_review_id":54625568,"id":131628476,"diff_hunk":"@@ -45,3 +45,16 @@ java_library(\n srcs = glob([\"com/twitter/heron/classification/**/*.java\"]),\n resources = [\"//heron/api/src:processor-service-conf\"],\n )\n+","path":"heron/api/src/java/BUILD","position":4,"original_position":4,"commit_id":"ce687ee0940587ed1c6749814e59efd0d8c14e87","original_commit_id":"ce687ee0940587ed1c6749814e59efd0d8c14e87","user":{"login":"aahmed-se","id":8009085,"avatar_url":"https://avatars0.githubusercontent.com/u/8009085?v=4","gravatar_id":"","url":"https://api.github.com/users/aahmed-se","html_url":"https://github.com/aahmed-se","followers_url":"https://api.github.com/users/aahmed-se/followers","following_url":"https://api.github.com/users/aahmed-se/following{/other_user}","gists_url":"https://api.github.com/users/aahmed-se/gists{/gist_id}","starred_url":"https://api.github.com/users/aahmed-se/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aahmed-se/subscriptions","organizations_url":"https://api.github.com/users/aahmed-se/orgs","repos_url":"https://api.github.com/users/aahmed-se/repos","events_url":"https://api.github.com/users/aahmed-se/events{/privacy}","received_events_url":"https://api.github.com/users/aahmed-se/received_events","type":"User","site_admin":false},"body":"Will have to parameterize it to make it shareable , will do that.","created_at":"2017-08-07T11:09:57Z","updated_at":"2017-08-07T11:09:57Z","html_url":"https://github.com/twitter/heron/pull/2153#discussion_r131628476","pull_request_url":"https://api.github.com/repos/twitter/heron/pulls/2153","_links":{"self":{"href":"https://api.github.com/repos/twitter/heron/pulls/comments/131628476"},"html":{"href":"https://github.com/twitter/heron/pull/2153#discussion_r131628476"},"pull_request":{"href":"https://api.github.com/repos/twitter/heron/pulls/2153"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/heron/pulls/2153","id":134224974,"html_url":"https://github.com/twitter/heron/pull/2153","diff_url":"https://github.com/twitter/heron/pull/2153.diff","patch_url":"https://github.com/twitter/heron/pull/2153.patch","issue_url":"https://api.github.com/repos/twitter/heron/issues/2153","number":2153,"state":"open","locked":false,"title":"Add pom generation to heron-api","user":{"login":"aahmed-se","id":8009085,"avatar_url":"https://avatars0.githubusercontent.com/u/8009085?v=4","gravatar_id":"","url":"https://api.github.com/users/aahmed-se","html_url":"https://github.com/aahmed-se","followers_url":"https://api.github.com/users/aahmed-se/followers","following_url":"https://api.github.com/users/aahmed-se/following{/other_user}","gists_url":"https://api.github.com/users/aahmed-se/gists{/gist_id}","starred_url":"https://api.github.com/users/aahmed-se/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aahmed-se/subscriptions","organizations_url":"https://api.github.com/users/aahmed-se/orgs","repos_url":"https://api.github.com/users/aahmed-se/repos","events_url":"https://api.github.com/users/aahmed-se/events{/privacy}","received_events_url":"https://api.github.com/users/aahmed-se/received_events","type":"User","site_admin":false},"body":"Make version tag externally configurable in future PR","created_at":"2017-08-04T18:28:35Z","updated_at":"2017-08-07T11:09:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e7c79923efe08f9cbbaf61f6e74950e30dee72f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/twitter/heron/pulls/2153/commits","review_comments_url":"https://api.github.com/repos/twitter/heron/pulls/2153/comments","review_comment_url":"https://api.github.com/repos/twitter/heron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/heron/issues/2153/comments","statuses_url":"https://api.github.com/repos/twitter/heron/statuses/ce687ee0940587ed1c6749814e59efd0d8c14e87","head":{"label":"streamlio:api_pom","ref":"api_pom","sha":"ce687ee0940587ed1c6749814e59efd0d8c14e87","user":{"login":"streamlio","id":21353322,"avatar_url":"https://avatars2.githubusercontent.com/u/21353322?v=4","gravatar_id":"","url":"https://api.github.com/users/streamlio","html_url":"https://github.com/streamlio","followers_url":"https://api.github.com/users/streamlio/followers","following_url":"https://api.github.com/users/streamlio/following{/other_user}","gists_url":"https://api.github.com/users/streamlio/gists{/gist_id}","starred_url":"https://api.github.com/users/streamlio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streamlio/subscriptions","organizations_url":"https://api.github.com/users/streamlio/orgs","repos_url":"https://api.github.com/users/streamlio/repos","events_url":"https://api.github.com/users/streamlio/events{/privacy}","received_events_url":"https://api.github.com/users/streamlio/received_events","type":"Organization","site_admin":false},"repo":{"id":97063018,"name":"heron","full_name":"streamlio/heron","owner":{"login":"streamlio","id":21353322,"avatar_url":"https://avatars2.githubusercontent.com/u/21353322?v=4","gravatar_id":"","url":"https://api.github.com/users/streamlio","html_url":"https://github.com/streamlio","followers_url":"https://api.github.com/users/streamlio/followers","following_url":"https://api.github.com/users/streamlio/following{/other_user}","gists_url":"https://api.github.com/users/streamlio/gists{/gist_id}","starred_url":"https://api.github.com/users/streamlio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streamlio/subscriptions","organizations_url":"https://api.github.com/users/streamlio/orgs","repos_url":"https://api.github.com/users/streamlio/repos","events_url":"https://api.github.com/users/streamlio/events{/privacy}","received_events_url":"https://api.github.com/users/streamlio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/streamlio/heron","description":"Heron is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":true,"url":"https://api.github.com/repos/streamlio/heron","forks_url":"https://api.github.com/repos/streamlio/heron/forks","keys_url":"https://api.github.com/repos/streamlio/heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/streamlio/heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/streamlio/heron/teams","hooks_url":"https://api.github.com/repos/streamlio/heron/hooks","issue_events_url":"https://api.github.com/repos/streamlio/heron/issues/events{/number}","events_url":"https://api.github.com/repos/streamlio/heron/events","assignees_url":"https://api.github.com/repos/streamlio/heron/assignees{/user}","branches_url":"https://api.github.com/repos/streamlio/heron/branches{/branch}","tags_url":"https://api.github.com/repos/streamlio/heron/tags","blobs_url":"https://api.github.com/repos/streamlio/heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/streamlio/heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/streamlio/heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/streamlio/heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/streamlio/heron/statuses/{sha}","languages_url":"https://api.github.com/repos/streamlio/heron/languages","stargazers_url":"https://api.github.com/repos/streamlio/heron/stargazers","contributors_url":"https://api.github.com/repos/streamlio/heron/contributors","subscribers_url":"https://api.github.com/repos/streamlio/heron/subscribers","subscription_url":"https://api.github.com/repos/streamlio/heron/subscription","commits_url":"https://api.github.com/repos/streamlio/heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/streamlio/heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/streamlio/heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/streamlio/heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/streamlio/heron/contents/{+path}","compare_url":"https://api.github.com/repos/streamlio/heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/streamlio/heron/merges","archive_url":"https://api.github.com/repos/streamlio/heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/streamlio/heron/downloads","issues_url":"https://api.github.com/repos/streamlio/heron/issues{/number}","pulls_url":"https://api.github.com/repos/streamlio/heron/pulls{/number}","milestones_url":"https://api.github.com/repos/streamlio/heron/milestones{/number}","notifications_url":"https://api.github.com/repos/streamlio/heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/streamlio/heron/labels{/name}","releases_url":"https://api.github.com/repos/streamlio/heron/releases{/id}","deployments_url":"https://api.github.com/repos/streamlio/heron/deployments","created_at":"2017-07-13T00:26:09Z","updated_at":"2017-07-13T00:26:15Z","pushed_at":"2017-08-06T16:36:47Z","git_url":"git://github.com/streamlio/heron.git","ssh_url":"[email protected]:streamlio/heron.git","clone_url":"https://github.com/streamlio/heron.git","svn_url":"https://github.com/streamlio/heron","homepage":"http://heronstreaming.io","size":134988,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"e804c7ed600354ca73913b2d7d29630b5904cee5","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars1.githubusercontent.com/u/50278?v=4","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":43158694,"name":"heron","full_name":"twitter/heron","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars1.githubusercontent.com/u/50278?v=4","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/heron","description":"Heron is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":false,"url":"https://api.github.com/repos/twitter/heron","forks_url":"https://api.github.com/repos/twitter/heron/forks","keys_url":"https://api.github.com/repos/twitter/heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/heron/teams","hooks_url":"https://api.github.com/repos/twitter/heron/hooks","issue_events_url":"https://api.github.com/repos/twitter/heron/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/heron/events","assignees_url":"https://api.github.com/repos/twitter/heron/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/heron/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/heron/tags","blobs_url":"https://api.github.com/repos/twitter/heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/heron/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/heron/languages","stargazers_url":"https://api.github.com/repos/twitter/heron/stargazers","contributors_url":"https://api.github.com/repos/twitter/heron/contributors","subscribers_url":"https://api.github.com/repos/twitter/heron/subscribers","subscription_url":"https://api.github.com/repos/twitter/heron/subscription","commits_url":"https://api.github.com/repos/twitter/heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/heron/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/heron/merges","archive_url":"https://api.github.com/repos/twitter/heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/heron/downloads","issues_url":"https://api.github.com/repos/twitter/heron/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/heron/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/heron/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/heron/labels{/name}","releases_url":"https://api.github.com/repos/twitter/heron/releases{/id}","deployments_url":"https://api.github.com/repos/twitter/heron/deployments","created_at":"2015-09-25T16:09:24Z","updated_at":"2017-08-06T18:25:19Z","pushed_at":"2017-08-06T16:32:45Z","git_url":"git://github.com/twitter/heron.git","ssh_url":"[email protected]:twitter/heron.git","clone_url":"https://github.com/twitter/heron.git","svn_url":"https://github.com/twitter/heron","homepage":"http://heronstreaming.io","size":134672,"stargazers_count":2842,"watchers_count":2842,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":511,"mirror_url":null,"open_issues_count":282,"forks":511,"open_issues":282,"watchers":2842,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/heron/pulls/2153"},"html":{"href":"https://github.com/twitter/heron/pull/2153"},"issue":{"href":"https://api.github.com/repos/twitter/heron/issues/2153"},"comments":{"href":"https://api.github.com/repos/twitter/heron/issues/2153/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/heron/pulls/2153/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/heron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/heron/pulls/2153/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/heron/statuses/ce687ee0940587ed1c6749814e59efd0d8c14e87"}}}} | {
"id": 43158694,
"name": "twitter/heron",
"url": "https://api.github.com/repos/twitter/heron"
} | {
"id": 8009085,
"login": "aahmed-se",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8009085?",
"url": "https://api.github.com/users/aahmed-se"
} | {
"id": 50278,
"login": "twitter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/50278?",
"url": "https://api.github.com/orgs/twitter"
} | 2017-08-07T11:09:57 | 6406582840 | {"actor":{"display_login":"aahmed-se"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/typeorm/typeorm/pulls/comments/109989450","pull_request_review_id":31128098,"id":109989450,"diff_hunk":"@@ -381,33 +387,89 @@ describe(\"Connection\", () => {\n \n });\n \n- describe(\"Can change postgres default schema name\", () => {\n+ describe.only(\"Different names of the same content of the schema\", () => {\n+\n let connections: Connection[];\n beforeEach(async () => {\n- connections = await createTestingConnections({ \n- enabledDrivers: [\"postgres\"],\n- entities: [Post],\n- schemaName: \"test-schema\",\n- dropSchemaOnConnection: true\n- });\n+ const [[connection1], [connection2]] = await Promise.all([\n+ createTestingConnections({ \n+ enabledDrivers: [\"postgres\"],\n+ entities: [CommentV1, GuestV1],\n+ schemaName: \"test-schema\",\n+ dropSchemaOnConnection: true,\n+ }),\n+ createTestingConnections({ \n+ enabledDrivers: [\"postgres\"],\n+ entities: [CommentV1, GuestV1],\n+ schemaName: \"another-schema\",\n+ dropSchemaOnConnection: true\n+ })\n+ ]);\n+ connections = [connection1, connection2];\n+ });\n+ after(() => closeTestingConnections(connections));\n+ it(\"should not interfere with each other\", async () => {\n+ await Promise.all(connections.map(c => c.syncSchema()));\n+ await closeTestingConnections(connections);\n+ const [[connection1], [connection2]] = await Promise.all([\n+ createTestingConnections({ \n+ enabledDrivers: [\"postgres\"],\n+ entities: [CommentV2, GuestV2],\n+ schemaName: \"test-schema\",\n+ dropSchemaOnConnection: false,\n+ schemaCreate: true\n+ }),\n+ createTestingConnections({ \n+ enabledDrivers: [\"postgres\"],\n+ entities: [CommentV2, GuestV2],\n+ schemaName: \"another-schema\",\n+ dropSchemaOnConnection: false,\n+ schemaCreate: true\n+ })\n+ ]);\n+ connections = [connection1, connection2];\n+ });\n+ });\n+\n+ describe.only(\"Can change postgres default schema name\", () => {","path":"test/functional/connection/connection.ts","position":72,"original_position":72,"commit_id":"389c250bf1ac85638afb599e9e80fc88c4a38878","original_commit_id":"389c250bf1ac85638afb599e9e80fc88c4a38878","user":{"login":"pleerock","id":1753397,"avatar_url":"https://avatars0.githubusercontent.com/u/1753397?v=3","gravatar_id":"","url":"https://api.github.com/users/pleerock","html_url":"https://github.com/pleerock","followers_url":"https://api.github.com/users/pleerock/followers","following_url":"https://api.github.com/users/pleerock/following{/other_user}","gists_url":"https://api.github.com/users/pleerock/gists{/gist_id}","starred_url":"https://api.github.com/users/pleerock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleerock/subscriptions","organizations_url":"https://api.github.com/users/pleerock/orgs","repos_url":"https://api.github.com/users/pleerock/repos","events_url":"https://api.github.com/users/pleerock/events{/privacy}","received_events_url":"https://api.github.com/users/pleerock/received_events","type":"User","site_admin":false},"body":"don't forget to remove `. only` ","created_at":"2017-04-05T18:14:25Z","updated_at":"2017-04-05T18:14:25Z","html_url":"https://github.com/typeorm/typeorm/pull/380#discussion_r109989450","pull_request_url":"https://api.github.com/repos/typeorm/typeorm/pulls/380","_links":{"self":{"href":"https://api.github.com/repos/typeorm/typeorm/pulls/comments/109989450"},"html":{"href":"https://github.com/typeorm/typeorm/pull/380#discussion_r109989450"},"pull_request":{"href":"https://api.github.com/repos/typeorm/typeorm/pulls/380"}}},"pull_request":{"url":"https://api.github.com/repos/typeorm/typeorm/pulls/380","id":113618699,"html_url":"https://github.com/typeorm/typeorm/pull/380","diff_url":"https://github.com/typeorm/typeorm/pull/380.diff","patch_url":"https://github.com/typeorm/typeorm/pull/380.patch","issue_url":"https://api.github.com/repos/typeorm/typeorm/issues/380","number":380,"state":"open","locked":false,"title":"bugfix query condition","user":{"login":"mingyang91","id":6914730,"avatar_url":"https://avatars0.githubusercontent.com/u/6914730?v=3","gravatar_id":"","url":"https://api.github.com/users/mingyang91","html_url":"https://github.com/mingyang91","followers_url":"https://api.github.com/users/mingyang91/followers","following_url":"https://api.github.com/users/mingyang91/following{/other_user}","gists_url":"https://api.github.com/users/mingyang91/gists{/gist_id}","starred_url":"https://api.github.com/users/mingyang91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingyang91/subscriptions","organizations_url":"https://api.github.com/users/mingyang91/orgs","repos_url":"https://api.github.com/users/mingyang91/repos","events_url":"https://api.github.com/users/mingyang91/events{/privacy}","received_events_url":"https://api.github.com/users/mingyang91/received_events","type":"User","site_admin":false},"body":"I missed some special cases in the code previously submitted(#160).\r\n\r\nThis causes the second schema to be initialized in the same database, and an exception is thrown when the `DROP CONSTRAINT` is run.\r\nBecause `indicesSql`, `foreignKeysSql`, `uniqueKeysSql`, `primaryKeysSql` do not add constraints (`table_schema =?`), The query retrieves all the constraints in the entire database and deletes it in a particular schema, but it does not exist.\r\n\r\nI have fixed the problem and added the test case.","created_at":"2017-03-31T10:19:25Z","updated_at":"2017-04-05T18:14:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99b1e1d2784023912600d2322e77c7522d44488e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/typeorm/typeorm/pulls/380/commits","review_comments_url":"https://api.github.com/repos/typeorm/typeorm/pulls/380/comments","review_comment_url":"https://api.github.com/repos/typeorm/typeorm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/typeorm/typeorm/issues/380/comments","statuses_url":"https://api.github.com/repos/typeorm/typeorm/statuses/389c250bf1ac85638afb599e9e80fc88c4a38878","head":{"label":"mingyang91:master","ref":"master","sha":"389c250bf1ac85638afb599e9e80fc88c4a38878","user":{"login":"mingyang91","id":6914730,"avatar_url":"https://avatars0.githubusercontent.com/u/6914730?v=3","gravatar_id":"","url":"https://api.github.com/users/mingyang91","html_url":"https://github.com/mingyang91","followers_url":"https://api.github.com/users/mingyang91/followers","following_url":"https://api.github.com/users/mingyang91/following{/other_user}","gists_url":"https://api.github.com/users/mingyang91/gists{/gist_id}","starred_url":"https://api.github.com/users/mingyang91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingyang91/subscriptions","organizations_url":"https://api.github.com/users/mingyang91/orgs","repos_url":"https://api.github.com/users/mingyang91/repos","events_url":"https://api.github.com/users/mingyang91/events{/privacy}","received_events_url":"https://api.github.com/users/mingyang91/received_events","type":"User","site_admin":false},"repo":{"id":73370607,"name":"typeorm","full_name":"mingyang91/typeorm","owner":{"login":"mingyang91","id":6914730,"avatar_url":"https://avatars0.githubusercontent.com/u/6914730?v=3","gravatar_id":"","url":"https://api.github.com/users/mingyang91","html_url":"https://github.com/mingyang91","followers_url":"https://api.github.com/users/mingyang91/followers","following_url":"https://api.github.com/users/mingyang91/following{/other_user}","gists_url":"https://api.github.com/users/mingyang91/gists{/gist_id}","starred_url":"https://api.github.com/users/mingyang91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingyang91/subscriptions","organizations_url":"https://api.github.com/users/mingyang91/orgs","repos_url":"https://api.github.com/users/mingyang91/repos","events_url":"https://api.github.com/users/mingyang91/events{/privacy}","received_events_url":"https://api.github.com/users/mingyang91/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mingyang91/typeorm","description":"Data-Mapper ORM for TypeScript, ES7, ES6, ES5. Supports MySQL, PostgreSQL, MariaDB, SQLite, MS SQL Server, Oracle databases. Currently in active development.","fork":true,"url":"https://api.github.com/repos/mingyang91/typeorm","forks_url":"https://api.github.com/repos/mingyang91/typeorm/forks","keys_url":"https://api.github.com/repos/mingyang91/typeorm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mingyang91/typeorm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mingyang91/typeorm/teams","hooks_url":"https://api.github.com/repos/mingyang91/typeorm/hooks","issue_events_url":"https://api.github.com/repos/mingyang91/typeorm/issues/events{/number}","events_url":"https://api.github.com/repos/mingyang91/typeorm/events","assignees_url":"https://api.github.com/repos/mingyang91/typeorm/assignees{/user}","branches_url":"https://api.github.com/repos/mingyang91/typeorm/branches{/branch}","tags_url":"https://api.github.com/repos/mingyang91/typeorm/tags","blobs_url":"https://api.github.com/repos/mingyang91/typeorm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mingyang91/typeorm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mingyang91/typeorm/git/refs{/sha}","trees_url":"https://api.github.com/repos/mingyang91/typeorm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mingyang91/typeorm/statuses/{sha}","languages_url":"https://api.github.com/repos/mingyang91/typeorm/languages","stargazers_url":"https://api.github.com/repos/mingyang91/typeorm/stargazers","contributors_url":"https://api.github.com/repos/mingyang91/typeorm/contributors","subscribers_url":"https://api.github.com/repos/mingyang91/typeorm/subscribers","subscription_url":"https://api.github.com/repos/mingyang91/typeorm/subscription","commits_url":"https://api.github.com/repos/mingyang91/typeorm/commits{/sha}","git_commits_url":"https://api.github.com/repos/mingyang91/typeorm/git/commits{/sha}","comments_url":"https://api.github.com/repos/mingyang91/typeorm/comments{/number}","issue_comment_url":"https://api.github.com/repos/mingyang91/typeorm/issues/comments{/number}","contents_url":"https://api.github.com/repos/mingyang91/typeorm/contents/{+path}","compare_url":"https://api.github.com/repos/mingyang91/typeorm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mingyang91/typeorm/merges","archive_url":"https://api.github.com/repos/mingyang91/typeorm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mingyang91/typeorm/downloads","issues_url":"https://api.github.com/repos/mingyang91/typeorm/issues{/number}","pulls_url":"https://api.github.com/repos/mingyang91/typeorm/pulls{/number}","milestones_url":"https://api.github.com/repos/mingyang91/typeorm/milestones{/number}","notifications_url":"https://api.github.com/repos/mingyang91/typeorm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mingyang91/typeorm/labels{/name}","releases_url":"https://api.github.com/repos/mingyang91/typeorm/releases{/id}","deployments_url":"https://api.github.com/repos/mingyang91/typeorm/deployments","created_at":"2016-11-10T10:17:39Z","updated_at":"2016-11-10T10:17:40Z","pushed_at":"2017-04-04T07:51:17Z","git_url":"git://github.com/mingyang91/typeorm.git","ssh_url":"[email protected]:mingyang91/typeorm.git","clone_url":"https://github.com/mingyang91/typeorm.git","svn_url":"https://github.com/mingyang91/typeorm","homepage":"https://typeorm.github.io","size":2963,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"typeorm:master","ref":"master","sha":"64815d87d77b5c06cd492638d1f837096abbfac4","user":{"login":"typeorm","id":20165699,"avatar_url":"https://avatars3.githubusercontent.com/u/20165699?v=3","gravatar_id":"","url":"https://api.github.com/users/typeorm","html_url":"https://github.com/typeorm","followers_url":"https://api.github.com/users/typeorm/followers","following_url":"https://api.github.com/users/typeorm/following{/other_user}","gists_url":"https://api.github.com/users/typeorm/gists{/gist_id}","starred_url":"https://api.github.com/users/typeorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typeorm/subscriptions","organizations_url":"https://api.github.com/users/typeorm/orgs","repos_url":"https://api.github.com/users/typeorm/repos","events_url":"https://api.github.com/users/typeorm/events{/privacy}","received_events_url":"https://api.github.com/users/typeorm/received_events","type":"Organization","site_admin":false},"repo":{"id":52773157,"name":"typeorm","full_name":"typeorm/typeorm","owner":{"login":"typeorm","id":20165699,"avatar_url":"https://avatars3.githubusercontent.com/u/20165699?v=3","gravatar_id":"","url":"https://api.github.com/users/typeorm","html_url":"https://github.com/typeorm","followers_url":"https://api.github.com/users/typeorm/followers","following_url":"https://api.github.com/users/typeorm/following{/other_user}","gists_url":"https://api.github.com/users/typeorm/gists{/gist_id}","starred_url":"https://api.github.com/users/typeorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typeorm/subscriptions","organizations_url":"https://api.github.com/users/typeorm/orgs","repos_url":"https://api.github.com/users/typeorm/repos","events_url":"https://api.github.com/users/typeorm/events{/privacy}","received_events_url":"https://api.github.com/users/typeorm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/typeorm/typeorm","description":"Data-Mapper ORM for TypeScript and JavaScript (ES7, ES6, ES5). Supports MySQL, PostgreSQL, MariaDB, SQLite, MS SQL Server, Oracle, WebSQL databases. Works in Node.js and Browser.","fork":false,"url":"https://api.github.com/repos/typeorm/typeorm","forks_url":"https://api.github.com/repos/typeorm/typeorm/forks","keys_url":"https://api.github.com/repos/typeorm/typeorm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typeorm/typeorm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typeorm/typeorm/teams","hooks_url":"https://api.github.com/repos/typeorm/typeorm/hooks","issue_events_url":"https://api.github.com/repos/typeorm/typeorm/issues/events{/number}","events_url":"https://api.github.com/repos/typeorm/typeorm/events","assignees_url":"https://api.github.com/repos/typeorm/typeorm/assignees{/user}","branches_url":"https://api.github.com/repos/typeorm/typeorm/branches{/branch}","tags_url":"https://api.github.com/repos/typeorm/typeorm/tags","blobs_url":"https://api.github.com/repos/typeorm/typeorm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typeorm/typeorm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typeorm/typeorm/git/refs{/sha}","trees_url":"https://api.github.com/repos/typeorm/typeorm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typeorm/typeorm/statuses/{sha}","languages_url":"https://api.github.com/repos/typeorm/typeorm/languages","stargazers_url":"https://api.github.com/repos/typeorm/typeorm/stargazers","contributors_url":"https://api.github.com/repos/typeorm/typeorm/contributors","subscribers_url":"https://api.github.com/repos/typeorm/typeorm/subscribers","subscription_url":"https://api.github.com/repos/typeorm/typeorm/subscription","commits_url":"https://api.github.com/repos/typeorm/typeorm/commits{/sha}","git_commits_url":"https://api.github.com/repos/typeorm/typeorm/git/commits{/sha}","comments_url":"https://api.github.com/repos/typeorm/typeorm/comments{/number}","issue_comment_url":"https://api.github.com/repos/typeorm/typeorm/issues/comments{/number}","contents_url":"https://api.github.com/repos/typeorm/typeorm/contents/{+path}","compare_url":"https://api.github.com/repos/typeorm/typeorm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typeorm/typeorm/merges","archive_url":"https://api.github.com/repos/typeorm/typeorm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typeorm/typeorm/downloads","issues_url":"https://api.github.com/repos/typeorm/typeorm/issues{/number}","pulls_url":"https://api.github.com/repos/typeorm/typeorm/pulls{/number}","milestones_url":"https://api.github.com/repos/typeorm/typeorm/milestones{/number}","notifications_url":"https://api.github.com/repos/typeorm/typeorm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typeorm/typeorm/labels{/name}","releases_url":"https://api.github.com/repos/typeorm/typeorm/releases{/id}","deployments_url":"https://api.github.com/repos/typeorm/typeorm/deployments","created_at":"2016-02-29T07:41:14Z","updated_at":"2017-04-05T17:54:19Z","pushed_at":"2017-04-05T18:13:40Z","git_url":"git://github.com/typeorm/typeorm.git","ssh_url":"[email protected]:typeorm/typeorm.git","clone_url":"https://github.com/typeorm/typeorm.git","svn_url":"https://github.com/typeorm/typeorm","homepage":"https://typeorm.github.io","size":3010,"stargazers_count":1796,"watchers_count":1796,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":116,"mirror_url":null,"open_issues_count":111,"forks":116,"open_issues":111,"watchers":1796,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/typeorm/typeorm/pulls/380"},"html":{"href":"https://github.com/typeorm/typeorm/pull/380"},"issue":{"href":"https://api.github.com/repos/typeorm/typeorm/issues/380"},"comments":{"href":"https://api.github.com/repos/typeorm/typeorm/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/typeorm/typeorm/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/typeorm/typeorm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/typeorm/typeorm/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/typeorm/typeorm/statuses/389c250bf1ac85638afb599e9e80fc88c4a38878"}}}} | {
"id": 52773157,
"name": "typeorm/typeorm",
"url": "https://api.github.com/repos/typeorm/typeorm"
} | {
"id": 1753397,
"login": "pleerock",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1753397?",
"url": "https://api.github.com/users/pleerock"
} | {
"id": 20165699,
"login": "typeorm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20165699?",
"url": "https://api.github.com/orgs/typeorm"
} | 2017-04-05T18:14:25 | 5633154748 | {"actor":{"display_login":"pleerock"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/uber-go/fx/pulls/comments/134336380","pull_request_review_id":57616287,"id":134336380,"diff_hunk":"@@ -131,6 +132,24 @@ func TestPrint(t *testing.T) {\n \t\tassert.Equal(t, \"\", sink.String())\n \t})\n \n+\tt.Run(\"printStripsVendorPath\", func(t *testing.T) {\n+\t\tsink.Reset()\n+\t\t// assert is vendored within fx and is a good test case\n+\t\tlogger.PrintProvide(assert.New)\n+\t\tassert.Contains(\n+\t\t\tt, sink.String(),\n+\t\t\t\"*assert.Assertions <= vendor/github.com/stretchr/testify/assert.New()\")\n+\t})\n+\n+\tt.Run(\"printFooVendorPath\", func(t *testing.T) {","path":"internal/fxlog/fxlog_test.go","position":21,"original_position":21,"commit_id":"ae49e2934311a69c33bcb895e18fcea2262fd688","original_commit_id":"ae49e2934311a69c33bcb895e18fcea2262fd688","user":{"login":"breerly","id":263587,"avatar_url":"https://avatars1.githubusercontent.com/u/263587?v=4","gravatar_id":"","url":"https://api.github.com/users/breerly","html_url":"https://github.com/breerly","followers_url":"https://api.github.com/users/breerly/followers","following_url":"https://api.github.com/users/breerly/following{/other_user}","gists_url":"https://api.github.com/users/breerly/gists{/gist_id}","starred_url":"https://api.github.com/users/breerly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breerly/subscriptions","organizations_url":"https://api.github.com/users/breerly/orgs","repos_url":"https://api.github.com/users/breerly/repos","events_url":"https://api.github.com/users/breerly/events{/privacy}","received_events_url":"https://api.github.com/users/breerly/received_events","type":"User","site_admin":false},"body":"ty sir","created_at":"2017-08-21T21:30:08Z","updated_at":"2017-08-21T21:30:35Z","html_url":"https://github.com/uber-go/fx/pull/591#discussion_r134336380","pull_request_url":"https://api.github.com/repos/uber-go/fx/pulls/591","_links":{"self":{"href":"https://api.github.com/repos/uber-go/fx/pulls/comments/134336380"},"html":{"href":"https://github.com/uber-go/fx/pull/591#discussion_r134336380"},"pull_request":{"href":"https://api.github.com/repos/uber-go/fx/pulls/591"}}},"pull_request":{"url":"https://api.github.com/repos/uber-go/fx/pulls/591","id":134970395,"html_url":"https://github.com/uber-go/fx/pull/591","diff_url":"https://github.com/uber-go/fx/pull/591.diff","patch_url":"https://github.com/uber-go/fx/pull/591.patch","issue_url":"https://api.github.com/repos/uber-go/fx/issues/591","number":591,"state":"open","locked":false,"title":"Shorten vendored paths","user":{"login":"glibsm","id":199077,"avatar_url":"https://avatars1.githubusercontent.com/u/199077?v=4","gravatar_id":"","url":"https://api.github.com/users/glibsm","html_url":"https://github.com/glibsm","followers_url":"https://api.github.com/users/glibsm/followers","following_url":"https://api.github.com/users/glibsm/following{/other_user}","gists_url":"https://api.github.com/users/glibsm/gists{/gist_id}","starred_url":"https://api.github.com/users/glibsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glibsm/subscriptions","organizations_url":"https://api.github.com/users/glibsm/orgs","repos_url":"https://api.github.com/users/glibsm/repos","events_url":"https://api.github.com/users/glibsm/events{/privacy}","received_events_url":"https://api.github.com/users/glibsm/received_events","type":"User","site_admin":false},"body":"The vendor experience for printing out the constructor paths it not\r\ngreat, since it includes the parent package as well, making it rather\r\nlong. The important bit is what happens after the vendor, not the\r\nduplication of the current repo.\r\n\r\nFixes #539","created_at":"2017-08-09T19:23:40Z","updated_at":"2017-08-21T21:30:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed6ed0ffe4ebef1d36ff3d1adba887a07904581c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber-go/fx/pulls/591/commits","review_comments_url":"https://api.github.com/repos/uber-go/fx/pulls/591/comments","review_comment_url":"https://api.github.com/repos/uber-go/fx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber-go/fx/issues/591/comments","statuses_url":"https://api.github.com/repos/uber-go/fx/statuses/ae49e2934311a69c33bcb895e18fcea2262fd688","head":{"label":"uber-go:gsm-shorten-vendor-paths","ref":"gsm-shorten-vendor-paths","sha":"ae49e2934311a69c33bcb895e18fcea2262fd688","user":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars2.githubusercontent.com/u/19262598?v=4","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"repo":{"id":72056048,"name":"fx","full_name":"uber-go/fx","owner":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars2.githubusercontent.com/u/19262598?v=4","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber-go/fx","description":"A dependency injection based application framework for Go.","fork":false,"url":"https://api.github.com/repos/uber-go/fx","forks_url":"https://api.github.com/repos/uber-go/fx/forks","keys_url":"https://api.github.com/repos/uber-go/fx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber-go/fx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber-go/fx/teams","hooks_url":"https://api.github.com/repos/uber-go/fx/hooks","issue_events_url":"https://api.github.com/repos/uber-go/fx/issues/events{/number}","events_url":"https://api.github.com/repos/uber-go/fx/events","assignees_url":"https://api.github.com/repos/uber-go/fx/assignees{/user}","branches_url":"https://api.github.com/repos/uber-go/fx/branches{/branch}","tags_url":"https://api.github.com/repos/uber-go/fx/tags","blobs_url":"https://api.github.com/repos/uber-go/fx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber-go/fx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber-go/fx/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber-go/fx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber-go/fx/statuses/{sha}","languages_url":"https://api.github.com/repos/uber-go/fx/languages","stargazers_url":"https://api.github.com/repos/uber-go/fx/stargazers","contributors_url":"https://api.github.com/repos/uber-go/fx/contributors","subscribers_url":"https://api.github.com/repos/uber-go/fx/subscribers","subscription_url":"https://api.github.com/repos/uber-go/fx/subscription","commits_url":"https://api.github.com/repos/uber-go/fx/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber-go/fx/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber-go/fx/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber-go/fx/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber-go/fx/contents/{+path}","compare_url":"https://api.github.com/repos/uber-go/fx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber-go/fx/merges","archive_url":"https://api.github.com/repos/uber-go/fx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber-go/fx/downloads","issues_url":"https://api.github.com/repos/uber-go/fx/issues{/number}","pulls_url":"https://api.github.com/repos/uber-go/fx/pulls{/number}","milestones_url":"https://api.github.com/repos/uber-go/fx/milestones{/number}","notifications_url":"https://api.github.com/repos/uber-go/fx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber-go/fx/labels{/name}","releases_url":"https://api.github.com/repos/uber-go/fx/releases{/id}","deployments_url":"https://api.github.com/repos/uber-go/fx/deployments","created_at":"2016-10-27T00:25:00Z","updated_at":"2017-08-20T00:52:11Z","pushed_at":"2017-08-21T21:16:08Z","git_url":"git://github.com/uber-go/fx.git","ssh_url":"[email protected]:uber-go/fx.git","clone_url":"https://github.com/uber-go/fx.git","svn_url":"https://github.com/uber-go/fx","homepage":"https://go.uber.org/fx","size":1431,"stargazers_count":114,"watchers_count":114,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":3,"forks":18,"open_issues":3,"watchers":114,"default_branch":"master"}},"base":{"label":"uber-go:master","ref":"master","sha":"873aa153688137884ab4266574ab464f4ee48739","user":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars2.githubusercontent.com/u/19262598?v=4","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"repo":{"id":72056048,"name":"fx","full_name":"uber-go/fx","owner":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars2.githubusercontent.com/u/19262598?v=4","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber-go/fx","description":"A dependency injection based application framework for Go.","fork":false,"url":"https://api.github.com/repos/uber-go/fx","forks_url":"https://api.github.com/repos/uber-go/fx/forks","keys_url":"https://api.github.com/repos/uber-go/fx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber-go/fx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber-go/fx/teams","hooks_url":"https://api.github.com/repos/uber-go/fx/hooks","issue_events_url":"https://api.github.com/repos/uber-go/fx/issues/events{/number}","events_url":"https://api.github.com/repos/uber-go/fx/events","assignees_url":"https://api.github.com/repos/uber-go/fx/assignees{/user}","branches_url":"https://api.github.com/repos/uber-go/fx/branches{/branch}","tags_url":"https://api.github.com/repos/uber-go/fx/tags","blobs_url":"https://api.github.com/repos/uber-go/fx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber-go/fx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber-go/fx/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber-go/fx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber-go/fx/statuses/{sha}","languages_url":"https://api.github.com/repos/uber-go/fx/languages","stargazers_url":"https://api.github.com/repos/uber-go/fx/stargazers","contributors_url":"https://api.github.com/repos/uber-go/fx/contributors","subscribers_url":"https://api.github.com/repos/uber-go/fx/subscribers","subscription_url":"https://api.github.com/repos/uber-go/fx/subscription","commits_url":"https://api.github.com/repos/uber-go/fx/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber-go/fx/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber-go/fx/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber-go/fx/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber-go/fx/contents/{+path}","compare_url":"https://api.github.com/repos/uber-go/fx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber-go/fx/merges","archive_url":"https://api.github.com/repos/uber-go/fx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber-go/fx/downloads","issues_url":"https://api.github.com/repos/uber-go/fx/issues{/number}","pulls_url":"https://api.github.com/repos/uber-go/fx/pulls{/number}","milestones_url":"https://api.github.com/repos/uber-go/fx/milestones{/number}","notifications_url":"https://api.github.com/repos/uber-go/fx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber-go/fx/labels{/name}","releases_url":"https://api.github.com/repos/uber-go/fx/releases{/id}","deployments_url":"https://api.github.com/repos/uber-go/fx/deployments","created_at":"2016-10-27T00:25:00Z","updated_at":"2017-08-20T00:52:11Z","pushed_at":"2017-08-21T21:16:08Z","git_url":"git://github.com/uber-go/fx.git","ssh_url":"[email protected]:uber-go/fx.git","clone_url":"https://github.com/uber-go/fx.git","svn_url":"https://github.com/uber-go/fx","homepage":"https://go.uber.org/fx","size":1431,"stargazers_count":114,"watchers_count":114,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":3,"forks":18,"open_issues":3,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber-go/fx/pulls/591"},"html":{"href":"https://github.com/uber-go/fx/pull/591"},"issue":{"href":"https://api.github.com/repos/uber-go/fx/issues/591"},"comments":{"href":"https://api.github.com/repos/uber-go/fx/issues/591/comments"},"review_comments":{"href":"https://api.github.com/repos/uber-go/fx/pulls/591/comments"},"review_comment":{"href":"https://api.github.com/repos/uber-go/fx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber-go/fx/pulls/591/commits"},"statuses":{"href":"https://api.github.com/repos/uber-go/fx/statuses/ae49e2934311a69c33bcb895e18fcea2262fd688"}}}} | {
"id": 72056048,
"name": "uber-go/fx",
"url": "https://api.github.com/repos/uber-go/fx"
} | {
"id": 263587,
"login": "breerly",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/263587?",
"url": "https://api.github.com/users/breerly"
} | {
"id": 19262598,
"login": "uber-go",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19262598?",
"url": "https://api.github.com/orgs/uber-go"
} | 2017-08-21T21:30:08 | 6494378050 | {"actor":{"display_login":"breerly"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/uber-go/fx/pulls/comments/106309830","pull_request_review_id":27224568,"id":106309830,"diff_hunk":"@@ -52,36 +57,83 @@ func globalBackendStatsClient() *statsClient {\n }\n \n // New creates an async task queue ModuleProvider.\n-func New(createFunc BackendCreateFunc) service.ModuleProvider {\n+func New(createFunc BackendCreateFunc, options ...ModuleOption) service.ModuleProvider {\n \treturn service.ModuleProviderFromFunc(\"task\", func(host service.Host) (service.Module, error) {\n-\t\treturn newAsyncModuleSingleton(host, createFunc)\n+\t\treturn newAsyncModuleSingleton(host, createFunc, options...)\n \t})\n }\n \n func newAsyncModuleSingleton(\n \thost service.Host,\n \tcreateFunc BackendCreateFunc,\n+\toptions ...ModuleOption,\n ) (service.Module, error) {\n \t_once.Do(func() {\n-\t\t_asyncMod, _asyncModErr = newAsyncModule(host, createFunc)\n+\t\t_asyncMod, _asyncModErr = newAsyncModule(host, createFunc, options...)\n \t})\n \treturn _asyncMod, _asyncModErr\n }\n \n func newAsyncModule(\n \thost service.Host,\n \tcreateFunc BackendCreateFunc,\n+\toptions ...ModuleOption,\n ) (service.Module, error) {\n-\tbackend, err := createFunc(host)\n+\tconfig := &Config{}\n+\tfor _, option := range options {\n+\t\tif err := option(config); err != nil {\n+\t\t\treturn nil, err\n+\t\t}\n+\t}\n+\tb, err := createFunc(host)\n \tif err != nil {\n \t\treturn nil, err\n \t}\n+\tmBackend := &managedBackend{b, *config}\n \t_globalBackendMu.Lock()\n-\t_globalBackend = backend\n+\t_globalBackend = mBackend\n \t_globalBackendStatsClient = newStatsClient(host.Metrics())\n \t_globalBackendMu.Unlock()\n-\treturn backend, nil\n+\treturn mBackend, nil\n+}\n+\n+// managedBackend is the root for all backends and controls execution\n+type managedBackend struct {\n+\tBackend\n+\tconfig Config\n+}\n+\n+// Start implements the Module interface\n+func (b *managedBackend) Start() error {\n+\tif err := b.Backend.Start(); err != nil {\n+\t\treturn errors.Wrap(err, \"unable to start backend\")\n+\t}\n+\tif !b.config.DisableExecution {\n+\t\terrorCh := b.ExecuteAsync()","path":"modules/task/task.go","position":77,"original_position":77,"commit_id":"f86f4c50cde36c0d17a1fbd1e59b87d2f4e6e72a","original_commit_id":"f86f4c50cde36c0d17a1fbd1e59b87d2f4e6e72a","user":{"login":"alsamylkin","id":20309319,"avatar_url":"https://avatars1.githubusercontent.com/u/20309319?v=3","gravatar_id":"","url":"https://api.github.com/users/alsamylkin","html_url":"https://github.com/alsamylkin","followers_url":"https://api.github.com/users/alsamylkin/followers","following_url":"https://api.github.com/users/alsamylkin/following{/other_user}","gists_url":"https://api.github.com/users/alsamylkin/gists{/gist_id}","starred_url":"https://api.github.com/users/alsamylkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alsamylkin/subscriptions","organizations_url":"https://api.github.com/users/alsamylkin/orgs","repos_url":"https://api.github.com/users/alsamylkin/repos","events_url":"https://api.github.com/users/alsamylkin/events{/privacy}","received_events_url":"https://api.github.com/users/alsamylkin/received_events","type":"User","site_admin":false},"body":"If someone else gets b.ExecuteAsync() and will read errors, does this mean that they are going to lose some errors?","created_at":"2017-03-15T23:42:13Z","updated_at":"2017-03-15T23:46:15Z","html_url":"https://github.com/uber-go/fx/pull/413#discussion_r106309830","pull_request_url":"https://api.github.com/repos/uber-go/fx/pulls/413","_links":{"self":{"href":"https://api.github.com/repos/uber-go/fx/pulls/comments/106309830"},"html":{"href":"https://github.com/uber-go/fx/pull/413#discussion_r106309830"},"pull_request":{"href":"https://api.github.com/repos/uber-go/fx/pulls/413"}}},"pull_request":{"url":"https://api.github.com/repos/uber-go/fx/pulls/413","id":110748295,"html_url":"https://github.com/uber-go/fx/pull/413","diff_url":"https://github.com/uber-go/fx/pull/413.diff","patch_url":"https://github.com/uber-go/fx/pull/413.patch","issue_url":"https://api.github.com/repos/uber-go/fx/issues/413","number":413,"state":"open","locked":false,"title":"Add options to task module to disable execution","user":{"login":"madhuravi","id":13949271,"avatar_url":"https://avatars1.githubusercontent.com/u/13949271?v=3","gravatar_id":"","url":"https://api.github.com/users/madhuravi","html_url":"https://github.com/madhuravi","followers_url":"https://api.github.com/users/madhuravi/followers","following_url":"https://api.github.com/users/madhuravi/following{/other_user}","gists_url":"https://api.github.com/users/madhuravi/gists{/gist_id}","starred_url":"https://api.github.com/users/madhuravi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhuravi/subscriptions","organizations_url":"https://api.github.com/users/madhuravi/orgs","repos_url":"https://api.github.com/users/madhuravi/repos","events_url":"https://api.github.com/users/madhuravi/events{/privacy}","received_events_url":"https://api.github.com/users/madhuravi/received_events","type":"User","site_admin":false},"body":"Users want to run run task execution on a different cluster from task enqueue. This will let them set up a module and disable execution which means that no consumption will happen but they can still enqueue tasks.","created_at":"2017-03-15T00:46:53Z","updated_at":"2017-03-15T23:46:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc8cb77e51308652a7c4247d0eb1cc56498608f7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber-go/fx/pulls/413/commits","review_comments_url":"https://api.github.com/repos/uber-go/fx/pulls/413/comments","review_comment_url":"https://api.github.com/repos/uber-go/fx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber-go/fx/issues/413/comments","statuses_url":"https://api.github.com/repos/uber-go/fx/statuses/f86f4c50cde36c0d17a1fbd1e59b87d2f4e6e72a","head":{"label":"uber-go:task","ref":"task","sha":"f86f4c50cde36c0d17a1fbd1e59b87d2f4e6e72a","user":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars1.githubusercontent.com/u/19262598?v=3","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"repo":{"id":72056048,"name":"fx","full_name":"uber-go/fx","owner":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars1.githubusercontent.com/u/19262598?v=3","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber-go/fx","description":"[BETA] Service Framework","fork":false,"url":"https://api.github.com/repos/uber-go/fx","forks_url":"https://api.github.com/repos/uber-go/fx/forks","keys_url":"https://api.github.com/repos/uber-go/fx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber-go/fx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber-go/fx/teams","hooks_url":"https://api.github.com/repos/uber-go/fx/hooks","issue_events_url":"https://api.github.com/repos/uber-go/fx/issues/events{/number}","events_url":"https://api.github.com/repos/uber-go/fx/events","assignees_url":"https://api.github.com/repos/uber-go/fx/assignees{/user}","branches_url":"https://api.github.com/repos/uber-go/fx/branches{/branch}","tags_url":"https://api.github.com/repos/uber-go/fx/tags","blobs_url":"https://api.github.com/repos/uber-go/fx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber-go/fx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber-go/fx/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber-go/fx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber-go/fx/statuses/{sha}","languages_url":"https://api.github.com/repos/uber-go/fx/languages","stargazers_url":"https://api.github.com/repos/uber-go/fx/stargazers","contributors_url":"https://api.github.com/repos/uber-go/fx/contributors","subscribers_url":"https://api.github.com/repos/uber-go/fx/subscribers","subscription_url":"https://api.github.com/repos/uber-go/fx/subscription","commits_url":"https://api.github.com/repos/uber-go/fx/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber-go/fx/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber-go/fx/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber-go/fx/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber-go/fx/contents/{+path}","compare_url":"https://api.github.com/repos/uber-go/fx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber-go/fx/merges","archive_url":"https://api.github.com/repos/uber-go/fx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber-go/fx/downloads","issues_url":"https://api.github.com/repos/uber-go/fx/issues{/number}","pulls_url":"https://api.github.com/repos/uber-go/fx/pulls{/number}","milestones_url":"https://api.github.com/repos/uber-go/fx/milestones{/number}","notifications_url":"https://api.github.com/repos/uber-go/fx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber-go/fx/labels{/name}","releases_url":"https://api.github.com/repos/uber-go/fx/releases{/id}","deployments_url":"https://api.github.com/repos/uber-go/fx/deployments","created_at":"2016-10-27T00:25:00Z","updated_at":"2017-03-15T04:26:16Z","pushed_at":"2017-03-15T22:42:37Z","git_url":"git://github.com/uber-go/fx.git","ssh_url":"[email protected]:uber-go/fx.git","clone_url":"https://github.com/uber-go/fx.git","svn_url":"https://github.com/uber-go/fx","homepage":"","size":1171,"stargazers_count":56,"watchers_count":56,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":18,"forks":7,"open_issues":18,"watchers":56,"default_branch":"master"}},"base":{"label":"uber-go:master","ref":"master","sha":"936b4a86043af92e15c76ed529ff3168f2a04318","user":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars1.githubusercontent.com/u/19262598?v=3","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"repo":{"id":72056048,"name":"fx","full_name":"uber-go/fx","owner":{"login":"uber-go","id":19262598,"avatar_url":"https://avatars1.githubusercontent.com/u/19262598?v=3","gravatar_id":"","url":"https://api.github.com/users/uber-go","html_url":"https://github.com/uber-go","followers_url":"https://api.github.com/users/uber-go/followers","following_url":"https://api.github.com/users/uber-go/following{/other_user}","gists_url":"https://api.github.com/users/uber-go/gists{/gist_id}","starred_url":"https://api.github.com/users/uber-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber-go/subscriptions","organizations_url":"https://api.github.com/users/uber-go/orgs","repos_url":"https://api.github.com/users/uber-go/repos","events_url":"https://api.github.com/users/uber-go/events{/privacy}","received_events_url":"https://api.github.com/users/uber-go/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber-go/fx","description":"[BETA] Service Framework","fork":false,"url":"https://api.github.com/repos/uber-go/fx","forks_url":"https://api.github.com/repos/uber-go/fx/forks","keys_url":"https://api.github.com/repos/uber-go/fx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber-go/fx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber-go/fx/teams","hooks_url":"https://api.github.com/repos/uber-go/fx/hooks","issue_events_url":"https://api.github.com/repos/uber-go/fx/issues/events{/number}","events_url":"https://api.github.com/repos/uber-go/fx/events","assignees_url":"https://api.github.com/repos/uber-go/fx/assignees{/user}","branches_url":"https://api.github.com/repos/uber-go/fx/branches{/branch}","tags_url":"https://api.github.com/repos/uber-go/fx/tags","blobs_url":"https://api.github.com/repos/uber-go/fx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber-go/fx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber-go/fx/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber-go/fx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber-go/fx/statuses/{sha}","languages_url":"https://api.github.com/repos/uber-go/fx/languages","stargazers_url":"https://api.github.com/repos/uber-go/fx/stargazers","contributors_url":"https://api.github.com/repos/uber-go/fx/contributors","subscribers_url":"https://api.github.com/repos/uber-go/fx/subscribers","subscription_url":"https://api.github.com/repos/uber-go/fx/subscription","commits_url":"https://api.github.com/repos/uber-go/fx/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber-go/fx/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber-go/fx/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber-go/fx/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber-go/fx/contents/{+path}","compare_url":"https://api.github.com/repos/uber-go/fx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber-go/fx/merges","archive_url":"https://api.github.com/repos/uber-go/fx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber-go/fx/downloads","issues_url":"https://api.github.com/repos/uber-go/fx/issues{/number}","pulls_url":"https://api.github.com/repos/uber-go/fx/pulls{/number}","milestones_url":"https://api.github.com/repos/uber-go/fx/milestones{/number}","notifications_url":"https://api.github.com/repos/uber-go/fx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber-go/fx/labels{/name}","releases_url":"https://api.github.com/repos/uber-go/fx/releases{/id}","deployments_url":"https://api.github.com/repos/uber-go/fx/deployments","created_at":"2016-10-27T00:25:00Z","updated_at":"2017-03-15T04:26:16Z","pushed_at":"2017-03-15T22:42:37Z","git_url":"git://github.com/uber-go/fx.git","ssh_url":"[email protected]:uber-go/fx.git","clone_url":"https://github.com/uber-go/fx.git","svn_url":"https://github.com/uber-go/fx","homepage":"","size":1171,"stargazers_count":56,"watchers_count":56,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":18,"forks":7,"open_issues":18,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber-go/fx/pulls/413"},"html":{"href":"https://github.com/uber-go/fx/pull/413"},"issue":{"href":"https://api.github.com/repos/uber-go/fx/issues/413"},"comments":{"href":"https://api.github.com/repos/uber-go/fx/issues/413/comments"},"review_comments":{"href":"https://api.github.com/repos/uber-go/fx/pulls/413/comments"},"review_comment":{"href":"https://api.github.com/repos/uber-go/fx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber-go/fx/pulls/413/commits"},"statuses":{"href":"https://api.github.com/repos/uber-go/fx/statuses/f86f4c50cde36c0d17a1fbd1e59b87d2f4e6e72a"}}}} | {
"id": 72056048,
"name": "uber-go/fx",
"url": "https://api.github.com/repos/uber-go/fx"
} | {
"id": 20309319,
"login": "alsamylkin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20309319?",
"url": "https://api.github.com/users/alsamylkin"
} | {
"id": 19262598,
"login": "uber-go",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19262598?",
"url": "https://api.github.com/orgs/uber-go"
} | 2017-03-15T23:42:13 | 5502468297 | {"actor":{"display_login":"alsamylkin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/uktrade/directory-sso-profile/pulls/comments/108477927","pull_request_review_id":29511377,"id":108477927,"diff_hunk":"@@ -232,3 +232,13 @@\n GOOGLE_TAG_MANAGER_ID = os.environ['GOOGLE_TAG_MANAGER_ID']\n GOOGLE_TAG_MANAGER_ENV = os.getenv('GOOGLE_TAG_MANAGER_ENV', '')\n UTM_COOKIE_DOMAIN = os.environ['UTM_COOKIE_DOMAIN']\n+\n+\n+EXPORTING_IS_GREAT_API_BASIC_AUTH_USERNAME = os.environ[","path":"config/settings.py","position":6,"original_position":6,"commit_id":"1ed130e88f3c18a2ee53a3c15f045132293e46fd","original_commit_id":"1ed130e88f3c18a2ee53a3c15f045132293e46fd","user":{"login":"konradko","id":2781766,"avatar_url":"https://avatars1.githubusercontent.com/u/2781766?v=3","gravatar_id":"","url":"https://api.github.com/users/konradko","html_url":"https://github.com/konradko","followers_url":"https://api.github.com/users/konradko/followers","following_url":"https://api.github.com/users/konradko/following{/other_user}","gists_url":"https://api.github.com/users/konradko/gists{/gist_id}","starred_url":"https://api.github.com/users/konradko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konradko/subscriptions","organizations_url":"https://api.github.com/users/konradko/orgs","repos_url":"https://api.github.com/users/konradko/repos","events_url":"https://api.github.com/users/konradko/events{/privacy}","received_events_url":"https://api.github.com/users/konradko/received_events","type":"User","site_admin":false},"body":"this might need to be removed if we will get ExOpps to switch off basic auth on stage to match prod","created_at":"2017-03-28T17:02:06Z","updated_at":"2017-03-28T17:02:06Z","html_url":"https://github.com/uktrade/directory-sso-profile/pull/6#discussion_r108477927","pull_request_url":"https://api.github.com/repos/uktrade/directory-sso-profile/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/uktrade/directory-sso-profile/pulls/comments/108477927"},"html":{"href":"https://github.com/uktrade/directory-sso-profile/pull/6#discussion_r108477927"},"pull_request":{"href":"https://api.github.com/repos/uktrade/directory-sso-profile/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/uktrade/directory-sso-profile/pulls/6","id":113015687,"html_url":"https://github.com/uktrade/directory-sso-profile/pull/6","diff_url":"https://github.com/uktrade/directory-sso-profile/pull/6.diff","patch_url":"https://github.com/uktrade/directory-sso-profile/pull/6.patch","issue_url":"https://api.github.com/repos/uktrade/directory-sso-profile/issues/6","number":6,"state":"open","locked":false,"title":"Retrieve export opportunities","user":{"login":"richtier","id":5485798,"avatar_url":"https://avatars3.githubusercontent.com/u/5485798?v=3","gravatar_id":"","url":"https://api.github.com/users/richtier","html_url":"https://github.com/richtier","followers_url":"https://api.github.com/users/richtier/followers","following_url":"https://api.github.com/users/richtier/following{/other_user}","gists_url":"https://api.github.com/users/richtier/gists{/gist_id}","starred_url":"https://api.github.com/users/richtier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richtier/subscriptions","organizations_url":"https://api.github.com/users/richtier/orgs","repos_url":"https://api.github.com/users/richtier/repos","events_url":"https://api.github.com/users/richtier/events{/privacy}","received_events_url":"https://api.github.com/users/richtier/received_events","type":"User","site_admin":false},"body":"[this task](https://uktrade.atlassian.net/browse/ED-1177)\r\n\r\n\r\n","created_at":"2017-03-28T16:43:06Z","updated_at":"2017-03-28T17:02:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b19012db60ef1bbd77c259bca830ec578d383a8c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/uktrade/directory-sso-profile/pulls/6/commits","review_comments_url":"https://api.github.com/repos/uktrade/directory-sso-profile/pulls/6/comments","review_comment_url":"https://api.github.com/repos/uktrade/directory-sso-profile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uktrade/directory-sso-profile/issues/6/comments","statuses_url":"https://api.github.com/repos/uktrade/directory-sso-profile/statuses/1ed130e88f3c18a2ee53a3c15f045132293e46fd","head":{"label":"uktrade:integrate-eig","ref":"integrate-eig","sha":"1ed130e88f3c18a2ee53a3c15f045132293e46fd","user":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars1.githubusercontent.com/u/15107524?v=3","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"repo":{"id":86060866,"name":"directory-sso-profile","full_name":"uktrade/directory-sso-profile","owner":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars1.githubusercontent.com/u/15107524?v=3","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uktrade/directory-sso-profile","description":null,"fork":false,"url":"https://api.github.com/repos/uktrade/directory-sso-profile","forks_url":"https://api.github.com/repos/uktrade/directory-sso-profile/forks","keys_url":"https://api.github.com/repos/uktrade/directory-sso-profile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uktrade/directory-sso-profile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uktrade/directory-sso-profile/teams","hooks_url":"https://api.github.com/repos/uktrade/directory-sso-profile/hooks","issue_events_url":"https://api.github.com/repos/uktrade/directory-sso-profile/issues/events{/number}","events_url":"https://api.github.com/repos/uktrade/directory-sso-profile/events","assignees_url":"https://api.github.com/repos/uktrade/directory-sso-profile/assignees{/user}","branches_url":"https://api.github.com/repos/uktrade/directory-sso-profile/branches{/branch}","tags_url":"https://api.github.com/repos/uktrade/directory-sso-profile/tags","blobs_url":"https://api.github.com/repos/uktrade/directory-sso-profile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uktrade/directory-sso-profile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uktrade/directory-sso-profile/git/refs{/sha}","trees_url":"https://api.github.com/repos/uktrade/directory-sso-profile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uktrade/directory-sso-profile/statuses/{sha}","languages_url":"https://api.github.com/repos/uktrade/directory-sso-profile/languages","stargazers_url":"https://api.github.com/repos/uktrade/directory-sso-profile/stargazers","contributors_url":"https://api.github.com/repos/uktrade/directory-sso-profile/contributors","subscribers_url":"https://api.github.com/repos/uktrade/directory-sso-profile/subscribers","subscription_url":"https://api.github.com/repos/uktrade/directory-sso-profile/subscription","commits_url":"https://api.github.com/repos/uktrade/directory-sso-profile/commits{/sha}","git_commits_url":"https://api.github.com/repos/uktrade/directory-sso-profile/git/commits{/sha}","comments_url":"https://api.github.com/repos/uktrade/directory-sso-profile/comments{/number}","issue_comment_url":"https://api.github.com/repos/uktrade/directory-sso-profile/issues/comments{/number}","contents_url":"https://api.github.com/repos/uktrade/directory-sso-profile/contents/{+path}","compare_url":"https://api.github.com/repos/uktrade/directory-sso-profile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uktrade/directory-sso-profile/merges","archive_url":"https://api.github.com/repos/uktrade/directory-sso-profile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uktrade/directory-sso-profile/downloads","issues_url":"https://api.github.com/repos/uktrade/directory-sso-profile/issues{/number}","pulls_url":"https://api.github.com/repos/uktrade/directory-sso-profile/pulls{/number}","milestones_url":"https://api.github.com/repos/uktrade/directory-sso-profile/milestones{/number}","notifications_url":"https://api.github.com/repos/uktrade/directory-sso-profile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uktrade/directory-sso-profile/labels{/name}","releases_url":"https://api.github.com/repos/uktrade/directory-sso-profile/releases{/id}","deployments_url":"https://api.github.com/repos/uktrade/directory-sso-profile/deployments","created_at":"2017-03-24T11:27:04Z","updated_at":"2017-03-28T16:25:58Z","pushed_at":"2017-03-28T17:01:25Z","git_url":"git://github.com/uktrade/directory-sso-profile.git","ssh_url":"[email protected]:uktrade/directory-sso-profile.git","clone_url":"https://github.com/uktrade/directory-sso-profile.git","svn_url":"https://github.com/uktrade/directory-sso-profile","homepage":null,"size":405,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"uktrade:master","ref":"master","sha":"62485dc2c48c2b00b9b4971de78e637447c594e3","user":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars1.githubusercontent.com/u/15107524?v=3","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"repo":{"id":86060866,"name":"directory-sso-profile","full_name":"uktrade/directory-sso-profile","owner":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars1.githubusercontent.com/u/15107524?v=3","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uktrade/directory-sso-profile","description":null,"fork":false,"url":"https://api.github.com/repos/uktrade/directory-sso-profile","forks_url":"https://api.github.com/repos/uktrade/directory-sso-profile/forks","keys_url":"https://api.github.com/repos/uktrade/directory-sso-profile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uktrade/directory-sso-profile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uktrade/directory-sso-profile/teams","hooks_url":"https://api.github.com/repos/uktrade/directory-sso-profile/hooks","issue_events_url":"https://api.github.com/repos/uktrade/directory-sso-profile/issues/events{/number}","events_url":"https://api.github.com/repos/uktrade/directory-sso-profile/events","assignees_url":"https://api.github.com/repos/uktrade/directory-sso-profile/assignees{/user}","branches_url":"https://api.github.com/repos/uktrade/directory-sso-profile/branches{/branch}","tags_url":"https://api.github.com/repos/uktrade/directory-sso-profile/tags","blobs_url":"https://api.github.com/repos/uktrade/directory-sso-profile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uktrade/directory-sso-profile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uktrade/directory-sso-profile/git/refs{/sha}","trees_url":"https://api.github.com/repos/uktrade/directory-sso-profile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uktrade/directory-sso-profile/statuses/{sha}","languages_url":"https://api.github.com/repos/uktrade/directory-sso-profile/languages","stargazers_url":"https://api.github.com/repos/uktrade/directory-sso-profile/stargazers","contributors_url":"https://api.github.com/repos/uktrade/directory-sso-profile/contributors","subscribers_url":"https://api.github.com/repos/uktrade/directory-sso-profile/subscribers","subscription_url":"https://api.github.com/repos/uktrade/directory-sso-profile/subscription","commits_url":"https://api.github.com/repos/uktrade/directory-sso-profile/commits{/sha}","git_commits_url":"https://api.github.com/repos/uktrade/directory-sso-profile/git/commits{/sha}","comments_url":"https://api.github.com/repos/uktrade/directory-sso-profile/comments{/number}","issue_comment_url":"https://api.github.com/repos/uktrade/directory-sso-profile/issues/comments{/number}","contents_url":"https://api.github.com/repos/uktrade/directory-sso-profile/contents/{+path}","compare_url":"https://api.github.com/repos/uktrade/directory-sso-profile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uktrade/directory-sso-profile/merges","archive_url":"https://api.github.com/repos/uktrade/directory-sso-profile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uktrade/directory-sso-profile/downloads","issues_url":"https://api.github.com/repos/uktrade/directory-sso-profile/issues{/number}","pulls_url":"https://api.github.com/repos/uktrade/directory-sso-profile/pulls{/number}","milestones_url":"https://api.github.com/repos/uktrade/directory-sso-profile/milestones{/number}","notifications_url":"https://api.github.com/repos/uktrade/directory-sso-profile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uktrade/directory-sso-profile/labels{/name}","releases_url":"https://api.github.com/repos/uktrade/directory-sso-profile/releases{/id}","deployments_url":"https://api.github.com/repos/uktrade/directory-sso-profile/deployments","created_at":"2017-03-24T11:27:04Z","updated_at":"2017-03-28T16:25:58Z","pushed_at":"2017-03-28T17:01:25Z","git_url":"git://github.com/uktrade/directory-sso-profile.git","ssh_url":"[email protected]:uktrade/directory-sso-profile.git","clone_url":"https://github.com/uktrade/directory-sso-profile.git","svn_url":"https://github.com/uktrade/directory-sso-profile","homepage":null,"size":405,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uktrade/directory-sso-profile/pulls/6"},"html":{"href":"https://github.com/uktrade/directory-sso-profile/pull/6"},"issue":{"href":"https://api.github.com/repos/uktrade/directory-sso-profile/issues/6"},"comments":{"href":"https://api.github.com/repos/uktrade/directory-sso-profile/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/uktrade/directory-sso-profile/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/uktrade/directory-sso-profile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uktrade/directory-sso-profile/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/uktrade/directory-sso-profile/statuses/1ed130e88f3c18a2ee53a3c15f045132293e46fd"}}}} | {
"id": 86060866,
"name": "uktrade/directory-sso-profile",
"url": "https://api.github.com/repos/uktrade/directory-sso-profile"
} | {
"id": 2781766,
"login": "konradko",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2781766?",
"url": "https://api.github.com/users/konradko"
} | {
"id": 15107524,
"login": "uktrade",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15107524?",
"url": "https://api.github.com/orgs/uktrade"
} | 2017-03-28T17:02:06 | 5580628845 | {"actor":{"display_login":"konradko"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/comments/133496365","pull_request_review_id":56684036,"id":133496365,"diff_hunk":"@@ -0,0 +1,238 @@\n+from datetime import date\n+from freezegun import freeze_time\n+from rest_framework import status\n+from rest_framework.reverse import reverse\n+\n+from datahub.company.test.factories import AdviserFactory, CompanyFactory, ContactFactory\n+from datahub.core.constants import InteractionType, Service, Team\n+from datahub.core.test_utils import APITestMixin\n+from datahub.interaction.test.factories import InteractionFactory\n+from datahub.investment.test.factories import InvestmentProjectFactory\n+\n+\n+class TestInteractionV3(APITestMixin):\n+ \"\"\"Tests for v3 interaction views.\"\"\"\n+\n+ def test_interaction_detail_view(self):\n+ \"\"\"Interaction detail view.\"\"\"\n+ interaction = InteractionFactory()\n+ url = reverse('api-v3:interaction:item', kwargs={'pk': interaction.pk})\n+ response = self.api_client.get(url)\n+\n+ assert response.status_code == status.HTTP_200_OK\n+ assert response.data['id'] == str(interaction.pk)\n+\n+ @freeze_time('2017-04-18 13:25:30.986208+00:00')\n+ def test_add_interaction(self):\n+ \"\"\"Test add new interaction.\"\"\"\n+ adviser = AdviserFactory()\n+ company = CompanyFactory()\n+ contact = ContactFactory()\n+ url = reverse('api-v3:interaction:collection')\n+ request_data = {\n+ 'interaction_type': InteractionType.face_to_face.value.id,\n+ 'subject': 'whatever',\n+ 'date': date.today().isoformat(),\n+ 'dit_adviser': adviser.pk,\n+ 'notes': 'hello',\n+ 'company': company.pk,\n+ 'contact': contact.pk,\n+ 'service': Service.trade_enquiry.value.id,\n+ 'dit_team': Team.healthcare_uk.value.id\n+ }\n+ response = self.api_client.post(url, request_data, format='json')\n+\n+ assert response.status_code == status.HTTP_201_CREATED\n+ response_data = response.json()\n+ assert response_data == {\n+ 'id': response_data['id'],\n+ 'interaction_type': {\n+ 'id': InteractionType.face_to_face.value.id,\n+ 'name': InteractionType.face_to_face.value.name\n+ },\n+ 'subject': 'whatever',\n+ 'date': request_data['date'],","path":"datahub/interaction/test/test_interaction_views_v3.py","position":54,"original_position":54,"commit_id":"bb6b5516ba06cb485e71b1ca77cc562184995e04","original_commit_id":"bb6b5516ba06cb485e71b1ca77cc562184995e04","user":{"login":"marcofucci","id":178865,"avatar_url":"https://avatars3.githubusercontent.com/u/178865?v=4","gravatar_id":"","url":"https://api.github.com/users/marcofucci","html_url":"https://github.com/marcofucci","followers_url":"https://api.github.com/users/marcofucci/followers","following_url":"https://api.github.com/users/marcofucci/following{/other_user}","gists_url":"https://api.github.com/users/marcofucci/gists{/gist_id}","starred_url":"https://api.github.com/users/marcofucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcofucci/subscriptions","organizations_url":"https://api.github.com/users/marcofucci/orgs","repos_url":"https://api.github.com/users/marcofucci/repos","events_url":"https://api.github.com/users/marcofucci/events{/privacy}","received_events_url":"https://api.github.com/users/marcofucci/received_events","type":"User","site_admin":false},"body":"Ss you are adding the `extra` to the field might be worth checking for the specific value (_2017-04-18_ as you are freezing time)","created_at":"2017-08-16T16:13:02Z","updated_at":"2017-08-16T16:16:10Z","html_url":"https://github.com/uktrade/data-hub-leeloo/pull/396#discussion_r133496365","pull_request_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/396","_links":{"self":{"href":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/comments/133496365"},"html":{"href":"https://github.com/uktrade/data-hub-leeloo/pull/396#discussion_r133496365"},"pull_request":{"href":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/396"}}},"pull_request":{"url":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/396","id":136063322,"html_url":"https://github.com/uktrade/data-hub-leeloo/pull/396","diff_url":"https://github.com/uktrade/data-hub-leeloo/pull/396.diff","patch_url":"https://github.com/uktrade/data-hub-leeloo/pull/396.patch","issue_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/396","number":396,"state":"open","locked":false,"title":"Add v3 interaction endpoints","user":{"login":"reupen","id":12693549,"avatar_url":"https://avatars1.githubusercontent.com/u/12693549?v=4","gravatar_id":"","url":"https://api.github.com/users/reupen","html_url":"https://github.com/reupen","followers_url":"https://api.github.com/users/reupen/followers","following_url":"https://api.github.com/users/reupen/following{/other_user}","gists_url":"https://api.github.com/users/reupen/gists{/gist_id}","starred_url":"https://api.github.com/users/reupen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reupen/subscriptions","organizations_url":"https://api.github.com/users/reupen/orgs","repos_url":"https://api.github.com/users/reupen/repos","events_url":"https://api.github.com/users/reupen/events{/privacy}","received_events_url":"https://api.github.com/users/reupen/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-16T16:04:50Z","updated_at":"2017-08-16T16:16:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84702b94e54442f07cdffe4df19ff91089ccd385","assignee":null,"assignees":[],"requested_reviewers":[{"login":"elcct","id":5889630,"avatar_url":"https://avatars2.githubusercontent.com/u/5889630?v=4","gravatar_id":"","url":"https://api.github.com/users/elcct","html_url":"https://github.com/elcct","followers_url":"https://api.github.com/users/elcct/followers","following_url":"https://api.github.com/users/elcct/following{/other_user}","gists_url":"https://api.github.com/users/elcct/gists{/gist_id}","starred_url":"https://api.github.com/users/elcct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elcct/subscriptions","organizations_url":"https://api.github.com/users/elcct/orgs","repos_url":"https://api.github.com/users/elcct/repos","events_url":"https://api.github.com/users/elcct/events{/privacy}","received_events_url":"https://api.github.com/users/elcct/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/396/commits","review_comments_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/396/comments","review_comment_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/396/comments","statuses_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/statuses/bb6b5516ba06cb485e71b1ca77cc562184995e04","head":{"label":"uktrade:feature/v3-interactions","ref":"feature/v3-interactions","sha":"bb6b5516ba06cb485e71b1ca77cc562184995e04","user":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"repo":{"id":73379434,"name":"data-hub-leeloo","full_name":"uktrade/data-hub-leeloo","owner":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uktrade/data-hub-leeloo","description":"Django API for Data Hub frontend","fork":false,"url":"https://api.github.com/repos/uktrade/data-hub-leeloo","forks_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/forks","keys_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/teams","hooks_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/hooks","issue_events_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/events{/number}","events_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/events","assignees_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/assignees{/user}","branches_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/branches{/branch}","tags_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/tags","blobs_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/refs{/sha}","trees_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/statuses/{sha}","languages_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/languages","stargazers_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/stargazers","contributors_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/contributors","subscribers_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/subscribers","subscription_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/subscription","commits_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/commits{/sha}","git_commits_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/commits{/sha}","comments_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/comments{/number}","issue_comment_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/comments{/number}","contents_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/contents/{+path}","compare_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/merges","archive_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/downloads","issues_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues{/number}","pulls_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls{/number}","milestones_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/milestones{/number}","notifications_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/labels{/name}","releases_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/releases{/id}","deployments_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/deployments","created_at":"2016-11-10T12:21:01Z","updated_at":"2017-08-04T11:07:16Z","pushed_at":"2017-08-16T16:05:01Z","git_url":"git://github.com/uktrade/data-hub-leeloo.git","ssh_url":"[email protected]:uktrade/data-hub-leeloo.git","clone_url":"https://github.com/uktrade/data-hub-leeloo.git","svn_url":"https://github.com/uktrade/data-hub-leeloo","homepage":null,"size":2896,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"develop"}},"base":{"label":"uktrade:develop","ref":"develop","sha":"f57e03e7cec1bbe5179813902acd886e0f1dc068","user":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"repo":{"id":73379434,"name":"data-hub-leeloo","full_name":"uktrade/data-hub-leeloo","owner":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uktrade/data-hub-leeloo","description":"Django API for Data Hub frontend","fork":false,"url":"https://api.github.com/repos/uktrade/data-hub-leeloo","forks_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/forks","keys_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/teams","hooks_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/hooks","issue_events_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/events{/number}","events_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/events","assignees_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/assignees{/user}","branches_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/branches{/branch}","tags_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/tags","blobs_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/refs{/sha}","trees_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/statuses/{sha}","languages_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/languages","stargazers_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/stargazers","contributors_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/contributors","subscribers_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/subscribers","subscription_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/subscription","commits_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/commits{/sha}","git_commits_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/git/commits{/sha}","comments_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/comments{/number}","issue_comment_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/comments{/number}","contents_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/contents/{+path}","compare_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/merges","archive_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/downloads","issues_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues{/number}","pulls_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls{/number}","milestones_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/milestones{/number}","notifications_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/labels{/name}","releases_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/releases{/id}","deployments_url":"https://api.github.com/repos/uktrade/data-hub-leeloo/deployments","created_at":"2016-11-10T12:21:01Z","updated_at":"2017-08-04T11:07:16Z","pushed_at":"2017-08-16T16:05:01Z","git_url":"git://github.com/uktrade/data-hub-leeloo.git","ssh_url":"[email protected]:uktrade/data-hub-leeloo.git","clone_url":"https://github.com/uktrade/data-hub-leeloo.git","svn_url":"https://github.com/uktrade/data-hub-leeloo","homepage":null,"size":2896,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/396"},"html":{"href":"https://github.com/uktrade/data-hub-leeloo/pull/396"},"issue":{"href":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/396"},"comments":{"href":"https://api.github.com/repos/uktrade/data-hub-leeloo/issues/396/comments"},"review_comments":{"href":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/396/comments"},"review_comment":{"href":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uktrade/data-hub-leeloo/pulls/396/commits"},"statuses":{"href":"https://api.github.com/repos/uktrade/data-hub-leeloo/statuses/bb6b5516ba06cb485e71b1ca77cc562184995e04"}}}} | {
"id": 73379434,
"name": "uktrade/data-hub-leeloo",
"url": "https://api.github.com/repos/uktrade/data-hub-leeloo"
} | {
"id": 178865,
"login": "marcofucci",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/178865?",
"url": "https://api.github.com/users/marcofucci"
} | {
"id": 15107524,
"login": "uktrade",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15107524?",
"url": "https://api.github.com/orgs/uktrade"
} | 2017-08-16T16:13:02 | 6465024412 | {"actor":{"display_login":"marcofucci"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/vatesfr/xo-web/pulls/comments/151631066","pull_request_review_id":77370247,"id":151631066,"diff_hunk":"@@ -222,6 +222,31 @@ class IndividualAction extends Component {\n }\n }\n \n+class GroupedAction extends Component {\n+ _getIsDisabled = createSelector(\n+ () => this.props.disabled,\n+ () => this.props.selectedItems,\n+ () => this.props.userData,\n+ (disabled, selectedItems, userData) =>\n+ isFunction(disabled) ? disabled(selectedItems, userData) : disabled","path":"src/common/sorted-table/index.js","position":10,"original_position":10,"commit_id":"fe7141c25c50312e9c66542ae70ba5c2f39e20f0","original_commit_id":"fe7141c25c50312e9c66542ae70ba5c2f39e20f0","user":{"login":"pdonias","id":10992860,"avatar_url":"https://avatars1.githubusercontent.com/u/10992860?v=4","gravatar_id":"","url":"https://api.github.com/users/pdonias","html_url":"https://github.com/pdonias","followers_url":"https://api.github.com/users/pdonias/followers","following_url":"https://api.github.com/users/pdonias/following{/other_user}","gists_url":"https://api.github.com/users/pdonias/gists{/gist_id}","starred_url":"https://api.github.com/users/pdonias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdonias/subscriptions","organizations_url":"https://api.github.com/users/pdonias/orgs","repos_url":"https://api.github.com/users/pdonias/repos","events_url":"https://api.github.com/users/pdonias/events{/privacy}","received_events_url":"https://api.github.com/users/pdonias/received_events","type":"User","site_admin":false},"body":"I think you also need to check if all the items are selected (ie `this.state.all` is true) because in that case, you need to pass all the items to the `disabled` function.","created_at":"2017-11-17T08:55:40Z","updated_at":"2017-11-17T08:56:20Z","html_url":"https://github.com/vatesfr/xo-web/pull/2471#discussion_r151631066","pull_request_url":"https://api.github.com/repos/vatesfr/xo-web/pulls/2471","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vatesfr/xo-web/pulls/comments/151631066"},"html":{"href":"https://github.com/vatesfr/xo-web/pull/2471#discussion_r151631066"},"pull_request":{"href":"https://api.github.com/repos/vatesfr/xo-web/pulls/2471"}}},"pull_request":{"url":"https://api.github.com/repos/vatesfr/xo-web/pulls/2471","id":151111352,"html_url":"https://github.com/vatesfr/xo-web/pull/2471","diff_url":"https://github.com/vatesfr/xo-web/pull/2471.diff","patch_url":"https://github.com/vatesfr/xo-web/pull/2471.patch","issue_url":"https://api.github.com/repos/vatesfr/xo-web/issues/2471","number":2471,"state":"open","locked":false,"title":"SortedTable/groupedActions: `disabled` props","user":{"login":"Rajaa-BARHTAOUI","id":7724491,"avatar_url":"https://avatars2.githubusercontent.com/u/7724491?v=4","gravatar_id":"","url":"https://api.github.com/users/Rajaa-BARHTAOUI","html_url":"https://github.com/Rajaa-BARHTAOUI","followers_url":"https://api.github.com/users/Rajaa-BARHTAOUI/followers","following_url":"https://api.github.com/users/Rajaa-BARHTAOUI/following{/other_user}","gists_url":"https://api.github.com/users/Rajaa-BARHTAOUI/gists{/gist_id}","starred_url":"https://api.github.com/users/Rajaa-BARHTAOUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rajaa-BARHTAOUI/subscriptions","organizations_url":"https://api.github.com/users/Rajaa-BARHTAOUI/orgs","repos_url":"https://api.github.com/users/Rajaa-BARHTAOUI/repos","events_url":"https://api.github.com/users/Rajaa-BARHTAOUI/events{/privacy}","received_events_url":"https://api.github.com/users/Rajaa-BARHTAOUI/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-07T13:21:29Z","updated_at":"2017-11-17T08:56:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e20d4b8b979dc19d4220b782e69321f79af29040","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/vatesfr/xo-web/pulls/2471/commits","review_comments_url":"https://api.github.com/repos/vatesfr/xo-web/pulls/2471/comments","review_comment_url":"https://api.github.com/repos/vatesfr/xo-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vatesfr/xo-web/issues/2471/comments","statuses_url":"https://api.github.com/repos/vatesfr/xo-web/statuses/fe7141c25c50312e9c66542ae70ba5c2f39e20f0","head":{"label":"Rajaa-BARHTAOUI:sortedTable-groupedActions-disabled-props","ref":"sortedTable-groupedActions-disabled-props","sha":"fe7141c25c50312e9c66542ae70ba5c2f39e20f0","user":{"login":"Rajaa-BARHTAOUI","id":7724491,"avatar_url":"https://avatars2.githubusercontent.com/u/7724491?v=4","gravatar_id":"","url":"https://api.github.com/users/Rajaa-BARHTAOUI","html_url":"https://github.com/Rajaa-BARHTAOUI","followers_url":"https://api.github.com/users/Rajaa-BARHTAOUI/followers","following_url":"https://api.github.com/users/Rajaa-BARHTAOUI/following{/other_user}","gists_url":"https://api.github.com/users/Rajaa-BARHTAOUI/gists{/gist_id}","starred_url":"https://api.github.com/users/Rajaa-BARHTAOUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rajaa-BARHTAOUI/subscriptions","organizations_url":"https://api.github.com/users/Rajaa-BARHTAOUI/orgs","repos_url":"https://api.github.com/users/Rajaa-BARHTAOUI/repos","events_url":"https://api.github.com/users/Rajaa-BARHTAOUI/events{/privacy}","received_events_url":"https://api.github.com/users/Rajaa-BARHTAOUI/received_events","type":"User","site_admin":false},"repo":{"id":106420206,"name":"xo-web","full_name":"Rajaa-BARHTAOUI/xo-web","owner":{"login":"Rajaa-BARHTAOUI","id":7724491,"avatar_url":"https://avatars2.githubusercontent.com/u/7724491?v=4","gravatar_id":"","url":"https://api.github.com/users/Rajaa-BARHTAOUI","html_url":"https://github.com/Rajaa-BARHTAOUI","followers_url":"https://api.github.com/users/Rajaa-BARHTAOUI/followers","following_url":"https://api.github.com/users/Rajaa-BARHTAOUI/following{/other_user}","gists_url":"https://api.github.com/users/Rajaa-BARHTAOUI/gists{/gist_id}","starred_url":"https://api.github.com/users/Rajaa-BARHTAOUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rajaa-BARHTAOUI/subscriptions","organizations_url":"https://api.github.com/users/Rajaa-BARHTAOUI/orgs","repos_url":"https://api.github.com/users/Rajaa-BARHTAOUI/repos","events_url":"https://api.github.com/users/Rajaa-BARHTAOUI/events{/privacy}","received_events_url":"https://api.github.com/users/Rajaa-BARHTAOUI/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Rajaa-BARHTAOUI/xo-web","description":"Interface part of Xen Orchestra.","fork":true,"url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web","forks_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/forks","keys_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/teams","hooks_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/hooks","issue_events_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/issues/events{/number}","events_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/events","assignees_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/assignees{/user}","branches_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/branches{/branch}","tags_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/tags","blobs_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/statuses/{sha}","languages_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/languages","stargazers_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/stargazers","contributors_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/contributors","subscribers_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/subscribers","subscription_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/subscription","commits_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/contents/{+path}","compare_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/merges","archive_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/downloads","issues_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/issues{/number}","pulls_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/pulls{/number}","milestones_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/milestones{/number}","notifications_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/labels{/name}","releases_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/releases{/id}","deployments_url":"https://api.github.com/repos/Rajaa-BARHTAOUI/xo-web/deployments","created_at":"2017-10-10T13:23:32Z","updated_at":"2017-10-10T13:23:35Z","pushed_at":"2017-11-16T16:14:43Z","git_url":"git://github.com/Rajaa-BARHTAOUI/xo-web.git","ssh_url":"[email protected]:Rajaa-BARHTAOUI/xo-web.git","clone_url":"https://github.com/Rajaa-BARHTAOUI/xo-web.git","svn_url":"https://github.com/Rajaa-BARHTAOUI/xo-web","homepage":"","size":10902,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vatesfr:master","ref":"master","sha":"0178ce0a916ba645e5d62d4e1ba7b006b4ef9eb7","user":{"login":"vatesfr","id":2064170,"avatar_url":"https://avatars2.githubusercontent.com/u/2064170?v=4","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"repo":{"id":8077957,"name":"xo-web","full_name":"vatesfr/xo-web","owner":{"login":"vatesfr","id":2064170,"avatar_url":"https://avatars2.githubusercontent.com/u/2064170?v=4","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vatesfr/xo-web","description":"Interface part of Xen Orchestra.","fork":false,"url":"https://api.github.com/repos/vatesfr/xo-web","forks_url":"https://api.github.com/repos/vatesfr/xo-web/forks","keys_url":"https://api.github.com/repos/vatesfr/xo-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vatesfr/xo-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vatesfr/xo-web/teams","hooks_url":"https://api.github.com/repos/vatesfr/xo-web/hooks","issue_events_url":"https://api.github.com/repos/vatesfr/xo-web/issues/events{/number}","events_url":"https://api.github.com/repos/vatesfr/xo-web/events","assignees_url":"https://api.github.com/repos/vatesfr/xo-web/assignees{/user}","branches_url":"https://api.github.com/repos/vatesfr/xo-web/branches{/branch}","tags_url":"https://api.github.com/repos/vatesfr/xo-web/tags","blobs_url":"https://api.github.com/repos/vatesfr/xo-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vatesfr/xo-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vatesfr/xo-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/vatesfr/xo-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vatesfr/xo-web/statuses/{sha}","languages_url":"https://api.github.com/repos/vatesfr/xo-web/languages","stargazers_url":"https://api.github.com/repos/vatesfr/xo-web/stargazers","contributors_url":"https://api.github.com/repos/vatesfr/xo-web/contributors","subscribers_url":"https://api.github.com/repos/vatesfr/xo-web/subscribers","subscription_url":"https://api.github.com/repos/vatesfr/xo-web/subscription","commits_url":"https://api.github.com/repos/vatesfr/xo-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/vatesfr/xo-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/vatesfr/xo-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/vatesfr/xo-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/vatesfr/xo-web/contents/{+path}","compare_url":"https://api.github.com/repos/vatesfr/xo-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vatesfr/xo-web/merges","archive_url":"https://api.github.com/repos/vatesfr/xo-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vatesfr/xo-web/downloads","issues_url":"https://api.github.com/repos/vatesfr/xo-web/issues{/number}","pulls_url":"https://api.github.com/repos/vatesfr/xo-web/pulls{/number}","milestones_url":"https://api.github.com/repos/vatesfr/xo-web/milestones{/number}","notifications_url":"https://api.github.com/repos/vatesfr/xo-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vatesfr/xo-web/labels{/name}","releases_url":"https://api.github.com/repos/vatesfr/xo-web/releases{/id}","deployments_url":"https://api.github.com/repos/vatesfr/xo-web/deployments","created_at":"2013-02-07T17:43:01Z","updated_at":"2017-11-03T23:16:00Z","pushed_at":"2017-11-16T16:32:59Z","git_url":"git://github.com/vatesfr/xo-web.git","ssh_url":"[email protected]:vatesfr/xo-web.git","clone_url":"https://github.com/vatesfr/xo-web.git","svn_url":"https://github.com/vatesfr/xo-web","homepage":"","size":10924,"stargazers_count":105,"watchers_count":105,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":290,"forks":44,"open_issues":290,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vatesfr/xo-web/pulls/2471"},"html":{"href":"https://github.com/vatesfr/xo-web/pull/2471"},"issue":{"href":"https://api.github.com/repos/vatesfr/xo-web/issues/2471"},"comments":{"href":"https://api.github.com/repos/vatesfr/xo-web/issues/2471/comments"},"review_comments":{"href":"https://api.github.com/repos/vatesfr/xo-web/pulls/2471/comments"},"review_comment":{"href":"https://api.github.com/repos/vatesfr/xo-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vatesfr/xo-web/pulls/2471/commits"},"statuses":{"href":"https://api.github.com/repos/vatesfr/xo-web/statuses/fe7141c25c50312e9c66542ae70ba5c2f39e20f0"}},"author_association":"NONE"}} | {
"id": 8077957,
"name": "vatesfr/xo-web",
"url": "https://api.github.com/repos/vatesfr/xo-web"
} | {
"id": 10992860,
"login": "pdonias",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10992860?",
"url": "https://api.github.com/users/pdonias"
} | {
"id": 2064170,
"login": "vatesfr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2064170?",
"url": "https://api.github.com/orgs/vatesfr"
} | 2017-11-17T08:55:40 | 6868822053 | {"actor":{"display_login":"pdonias"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/vert-x3/vertx-mqtt/pulls/comments/134471807","pull_request_review_id":57766123,"id":134471807,"diff_hunk":"@@ -0,0 +1,261 @@\n+/*\n+ * Copyright 2016 Red Hat Inc.","path":"src/test/java/io/vertx/mqtt/test/server/MqttServerClientCertSslTest.java","position":2,"original_position":2,"commit_id":"e87505b8579a7717cf865c8fcf1512403662dbff","original_commit_id":"e87505b8579a7717cf865c8fcf1512403662dbff","user":{"login":"ppatierno","id":5842311,"avatar_url":"https://avatars0.githubusercontent.com/u/5842311?v=4","gravatar_id":"","url":"https://api.github.com/users/ppatierno","html_url":"https://github.com/ppatierno","followers_url":"https://api.github.com/users/ppatierno/followers","following_url":"https://api.github.com/users/ppatierno/following{/other_user}","gists_url":"https://api.github.com/users/ppatierno/gists{/gist_id}","starred_url":"https://api.github.com/users/ppatierno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppatierno/subscriptions","organizations_url":"https://api.github.com/users/ppatierno/orgs","repos_url":"https://api.github.com/users/ppatierno/repos","events_url":"https://api.github.com/users/ppatierno/events{/privacy}","received_events_url":"https://api.github.com/users/ppatierno/received_events","type":"User","site_admin":false},"body":"Having Red Hat is ok. For now let's leave 2016, then I'll change it. No worries ;)","created_at":"2017-08-22T12:58:51Z","updated_at":"2017-08-22T12:58:56Z","html_url":"https://github.com/vert-x3/vertx-mqtt/pull/42#discussion_r134471807","pull_request_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/vert-x3/vertx-mqtt/pulls/comments/134471807"},"html":{"href":"https://github.com/vert-x3/vertx-mqtt/pull/42#discussion_r134471807"},"pull_request":{"href":"https://api.github.com/repos/vert-x3/vertx-mqtt/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/vert-x3/vertx-mqtt/pulls/42","id":133207801,"html_url":"https://github.com/vert-x3/vertx-mqtt/pull/42","diff_url":"https://github.com/vert-x3/vertx-mqtt/pull/42.diff","patch_url":"https://github.com/vert-x3/vertx-mqtt/pull/42.patch","issue_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/issues/42","number":42,"state":"open","locked":false,"title":"SSL Client Certificate support","user":{"login":"dachaac","id":9357671,"avatar_url":"https://avatars1.githubusercontent.com/u/9357671?v=4","gravatar_id":"","url":"https://api.github.com/users/dachaac","html_url":"https://github.com/dachaac","followers_url":"https://api.github.com/users/dachaac/followers","following_url":"https://api.github.com/users/dachaac/following{/other_user}","gists_url":"https://api.github.com/users/dachaac/gists{/gist_id}","starred_url":"https://api.github.com/users/dachaac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachaac/subscriptions","organizations_url":"https://api.github.com/users/dachaac/orgs","repos_url":"https://api.github.com/users/dachaac/repos","events_url":"https://api.github.com/users/dachaac/events{/privacy}","received_events_url":"https://api.github.com/users/dachaac/received_events","type":"User","site_admin":false},"body":"Add support to acquire SSL Client Certificate using socket's sslSession().\r\n`Certificate[] peerCertificates = endpoint.sslSession().getPeerCertificates();`\r\n\r\nSupport for sslSession() requires latest snapshot of vert.x (https://github.com/eclipse/vert.x/commit/2dcbfac237aed48dd0d4dbeb58372be0ad59c4eb).\r\n\r\nIn addition to sslSession() one needs to ask for SSL Client Certificates, so added support to MqttServerOptions to specify setClientAuth().\r\n\r\nThen for convenience added support for MqttEndpoint#isSsl(), MqttEndpoint#localAddress() and MqttEndpoint#remoteAddress().\r\n\r\nWith these changes in my test application I was able to identify connecting MQTT client based on its SSL Client Certificate.","created_at":"2017-07-31T10:02:28Z","updated_at":"2017-08-22T12:58:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f11c76ed9efa97629165fea1253a23d6119f823","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/pulls/42/commits","review_comments_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/pulls/42/comments","review_comment_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/issues/42/comments","statuses_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/statuses/e87505b8579a7717cf865c8fcf1512403662dbff","head":{"label":"dachaac:ssl-client-certificate-support","ref":"ssl-client-certificate-support","sha":"e87505b8579a7717cf865c8fcf1512403662dbff","user":{"login":"dachaac","id":9357671,"avatar_url":"https://avatars1.githubusercontent.com/u/9357671?v=4","gravatar_id":"","url":"https://api.github.com/users/dachaac","html_url":"https://github.com/dachaac","followers_url":"https://api.github.com/users/dachaac/followers","following_url":"https://api.github.com/users/dachaac/following{/other_user}","gists_url":"https://api.github.com/users/dachaac/gists{/gist_id}","starred_url":"https://api.github.com/users/dachaac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachaac/subscriptions","organizations_url":"https://api.github.com/users/dachaac/orgs","repos_url":"https://api.github.com/users/dachaac/repos","events_url":"https://api.github.com/users/dachaac/events{/privacy}","received_events_url":"https://api.github.com/users/dachaac/received_events","type":"User","site_admin":false},"repo":{"id":98476175,"name":"vertx-mqtt","full_name":"dachaac/vertx-mqtt","owner":{"login":"dachaac","id":9357671,"avatar_url":"https://avatars1.githubusercontent.com/u/9357671?v=4","gravatar_id":"","url":"https://api.github.com/users/dachaac","html_url":"https://github.com/dachaac","followers_url":"https://api.github.com/users/dachaac/followers","following_url":"https://api.github.com/users/dachaac/following{/other_user}","gists_url":"https://api.github.com/users/dachaac/gists{/gist_id}","starred_url":"https://api.github.com/users/dachaac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachaac/subscriptions","organizations_url":"https://api.github.com/users/dachaac/orgs","repos_url":"https://api.github.com/users/dachaac/repos","events_url":"https://api.github.com/users/dachaac/events{/privacy}","received_events_url":"https://api.github.com/users/dachaac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dachaac/vertx-mqtt","description":"Vert.x MQTT","fork":true,"url":"https://api.github.com/repos/dachaac/vertx-mqtt","forks_url":"https://api.github.com/repos/dachaac/vertx-mqtt/forks","keys_url":"https://api.github.com/repos/dachaac/vertx-mqtt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dachaac/vertx-mqtt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dachaac/vertx-mqtt/teams","hooks_url":"https://api.github.com/repos/dachaac/vertx-mqtt/hooks","issue_events_url":"https://api.github.com/repos/dachaac/vertx-mqtt/issues/events{/number}","events_url":"https://api.github.com/repos/dachaac/vertx-mqtt/events","assignees_url":"https://api.github.com/repos/dachaac/vertx-mqtt/assignees{/user}","branches_url":"https://api.github.com/repos/dachaac/vertx-mqtt/branches{/branch}","tags_url":"https://api.github.com/repos/dachaac/vertx-mqtt/tags","blobs_url":"https://api.github.com/repos/dachaac/vertx-mqtt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dachaac/vertx-mqtt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dachaac/vertx-mqtt/git/refs{/sha}","trees_url":"https://api.github.com/repos/dachaac/vertx-mqtt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dachaac/vertx-mqtt/statuses/{sha}","languages_url":"https://api.github.com/repos/dachaac/vertx-mqtt/languages","stargazers_url":"https://api.github.com/repos/dachaac/vertx-mqtt/stargazers","contributors_url":"https://api.github.com/repos/dachaac/vertx-mqtt/contributors","subscribers_url":"https://api.github.com/repos/dachaac/vertx-mqtt/subscribers","subscription_url":"https://api.github.com/repos/dachaac/vertx-mqtt/subscription","commits_url":"https://api.github.com/repos/dachaac/vertx-mqtt/commits{/sha}","git_commits_url":"https://api.github.com/repos/dachaac/vertx-mqtt/git/commits{/sha}","comments_url":"https://api.github.com/repos/dachaac/vertx-mqtt/comments{/number}","issue_comment_url":"https://api.github.com/repos/dachaac/vertx-mqtt/issues/comments{/number}","contents_url":"https://api.github.com/repos/dachaac/vertx-mqtt/contents/{+path}","compare_url":"https://api.github.com/repos/dachaac/vertx-mqtt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dachaac/vertx-mqtt/merges","archive_url":"https://api.github.com/repos/dachaac/vertx-mqtt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dachaac/vertx-mqtt/downloads","issues_url":"https://api.github.com/repos/dachaac/vertx-mqtt/issues{/number}","pulls_url":"https://api.github.com/repos/dachaac/vertx-mqtt/pulls{/number}","milestones_url":"https://api.github.com/repos/dachaac/vertx-mqtt/milestones{/number}","notifications_url":"https://api.github.com/repos/dachaac/vertx-mqtt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dachaac/vertx-mqtt/labels{/name}","releases_url":"https://api.github.com/repos/dachaac/vertx-mqtt/releases{/id}","deployments_url":"https://api.github.com/repos/dachaac/vertx-mqtt/deployments","created_at":"2017-07-27T00:18:49Z","updated_at":"2017-07-27T00:18:50Z","pushed_at":"2017-08-13T07:37:57Z","git_url":"git://github.com/dachaac/vertx-mqtt.git","ssh_url":"[email protected]:dachaac/vertx-mqtt.git","clone_url":"https://github.com/dachaac/vertx-mqtt.git","svn_url":"https://github.com/dachaac/vertx-mqtt","homepage":"","size":475,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vert-x3:master","ref":"master","sha":"b07790513b7467e473f8e8fa3a6b5776b053a25c","user":{"login":"vert-x3","id":8124623,"avatar_url":"https://avatars1.githubusercontent.com/u/8124623?v=4","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"repo":{"id":69547915,"name":"vertx-mqtt","full_name":"vert-x3/vertx-mqtt","owner":{"login":"vert-x3","id":8124623,"avatar_url":"https://avatars1.githubusercontent.com/u/8124623?v=4","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vert-x3/vertx-mqtt","description":"Vert.x MQTT","fork":false,"url":"https://api.github.com/repos/vert-x3/vertx-mqtt","forks_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/forks","keys_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/teams","hooks_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/hooks","issue_events_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/issues/events{/number}","events_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/events","assignees_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/assignees{/user}","branches_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/branches{/branch}","tags_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/tags","blobs_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/git/refs{/sha}","trees_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/statuses/{sha}","languages_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/languages","stargazers_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/stargazers","contributors_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/contributors","subscribers_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/subscribers","subscription_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/subscription","commits_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/commits{/sha}","git_commits_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/git/commits{/sha}","comments_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/comments{/number}","issue_comment_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/issues/comments{/number}","contents_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/contents/{+path}","compare_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/merges","archive_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/downloads","issues_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/issues{/number}","pulls_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/pulls{/number}","milestones_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/milestones{/number}","notifications_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/labels{/name}","releases_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/releases{/id}","deployments_url":"https://api.github.com/repos/vert-x3/vertx-mqtt/deployments","created_at":"2016-09-29T08:35:24Z","updated_at":"2017-08-17T13:23:55Z","pushed_at":"2017-08-18T12:58:51Z","git_url":"git://github.com/vert-x3/vertx-mqtt.git","ssh_url":"[email protected]:vert-x3/vertx-mqtt.git","clone_url":"https://github.com/vert-x3/vertx-mqtt.git","svn_url":"https://github.com/vert-x3/vertx-mqtt","homepage":"","size":509,"stargazers_count":34,"watchers_count":34,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":8,"forks":18,"open_issues":8,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vert-x3/vertx-mqtt/pulls/42"},"html":{"href":"https://github.com/vert-x3/vertx-mqtt/pull/42"},"issue":{"href":"https://api.github.com/repos/vert-x3/vertx-mqtt/issues/42"},"comments":{"href":"https://api.github.com/repos/vert-x3/vertx-mqtt/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/vert-x3/vertx-mqtt/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/vert-x3/vertx-mqtt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vert-x3/vertx-mqtt/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/vert-x3/vertx-mqtt/statuses/e87505b8579a7717cf865c8fcf1512403662dbff"}}}} | {
"id": 69547915,
"name": "vert-x3/vertx-mqtt",
"url": "https://api.github.com/repos/vert-x3/vertx-mqtt"
} | {
"id": 5842311,
"login": "ppatierno",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5842311?",
"url": "https://api.github.com/users/ppatierno"
} | {
"id": 8124623,
"login": "vert-x3",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8124623?",
"url": "https://api.github.com/orgs/vert-x3"
} | 2017-08-22T12:58:51 | 6497127749 | {"actor":{"display_login":"ppatierno"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/webpack/webpack/pulls/comments/97859917","pull_request_review_id":18483117,"id":97859917,"diff_hunk":"@@ -35,10 +35,13 @@ function allHaveModule(someChunks, module, checkedChunks) {\n }\n \n function addToSet(set, items) {\n-\titems.forEach((item) => {\n-\t\tif(set.indexOf(item) < 0)\n+\tfor(var index = 0; index < items.length; index++) {\n+\t\tvar item = items[index];\n+\n+\t\tif(set.indexOf(item) < 0) {","path":"lib/optimize/RemoveParentModulesPlugin.js","position":9,"original_position":9,"commit_id":"588976d5e9385c878693914cf5429e7d47af378f","original_commit_id":"588976d5e9385c878693914cf5429e7d47af378f","user":{"login":"Tom910","id":2185721,"avatar_url":"https://avatars.githubusercontent.com/u/2185721?v=3","gravatar_id":"","url":"https://api.github.com/users/Tom910","html_url":"https://github.com/Tom910","followers_url":"https://api.github.com/users/Tom910/followers","following_url":"https://api.github.com/users/Tom910/following{/other_user}","gists_url":"https://api.github.com/users/Tom910/gists{/gist_id}","starred_url":"https://api.github.com/users/Tom910/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tom910/subscriptions","organizations_url":"https://api.github.com/users/Tom910/orgs","repos_url":"https://api.github.com/users/Tom910/repos","events_url":"https://api.github.com/users/Tom910/events{/privacy}","received_events_url":"https://api.github.com/users/Tom910/received_events","type":"User","site_admin":false},"body":"Set slower, I added a small hack.","created_at":"2017-01-25T19:32:39Z","updated_at":"2017-01-25T19:32:39Z","html_url":"https://github.com/webpack/webpack/pull/4089#discussion_r97859917","pull_request_url":"https://api.github.com/repos/webpack/webpack/pulls/4089","_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack/pulls/comments/97859917"},"html":{"href":"https://github.com/webpack/webpack/pull/4089#discussion_r97859917"},"pull_request":{"href":"https://api.github.com/repos/webpack/webpack/pulls/4089"}}},"pull_request":{"url":"https://api.github.com/repos/webpack/webpack/pulls/4089","id":102785410,"html_url":"https://github.com/webpack/webpack/pull/4089","diff_url":"https://github.com/webpack/webpack/pull/4089.diff","patch_url":"https://github.com/webpack/webpack/pull/4089.patch","issue_url":"https://api.github.com/repos/webpack/webpack/issues/4089","number":4089,"state":"open","locked":false,"title":"Optimize Compilation, Parse, RemoveParentModulesPlugin for each to loop and more","user":{"login":"Tom910","id":2185721,"avatar_url":"https://avatars.githubusercontent.com/u/2185721?v=3","gravatar_id":"","url":"https://api.github.com/users/Tom910","html_url":"https://github.com/Tom910","followers_url":"https://api.github.com/users/Tom910/followers","following_url":"https://api.github.com/users/Tom910/following{/other_user}","gists_url":"https://api.github.com/users/Tom910/gists{/gist_id}","starred_url":"https://api.github.com/users/Tom910/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tom910/subscriptions","organizations_url":"https://api.github.com/users/Tom910/orgs","repos_url":"https://api.github.com/users/Tom910/repos","events_url":"https://api.github.com/users/Tom910/events{/privacy}","received_events_url":"https://api.github.com/users/Tom910/received_events","type":"User","site_admin":false},"body":"What kind of change does this PR introduce?\r\nRefactoring\r\n\r\nDid you add tests for your changes?\r\nN/A\r\n\r\nSummary\r\nRewrote frequently used forEach and no optimal structure\r\n\r\nDoes this PR introduce a breaking change?\r\nNo","created_at":"2017-01-23T19:37:37Z","updated_at":"2017-01-25T19:32:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0715b9e8812b855628ef6c97dd8537dd268c3577","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/webpack/webpack/pulls/4089/commits","review_comments_url":"https://api.github.com/repos/webpack/webpack/pulls/4089/comments","review_comment_url":"https://api.github.com/repos/webpack/webpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webpack/webpack/issues/4089/comments","statuses_url":"https://api.github.com/repos/webpack/webpack/statuses/588976d5e9385c878693914cf5429e7d47af378f","head":{"label":"Tom910:master","ref":"master","sha":"588976d5e9385c878693914cf5429e7d47af378f","user":{"login":"Tom910","id":2185721,"avatar_url":"https://avatars.githubusercontent.com/u/2185721?v=3","gravatar_id":"","url":"https://api.github.com/users/Tom910","html_url":"https://github.com/Tom910","followers_url":"https://api.github.com/users/Tom910/followers","following_url":"https://api.github.com/users/Tom910/following{/other_user}","gists_url":"https://api.github.com/users/Tom910/gists{/gist_id}","starred_url":"https://api.github.com/users/Tom910/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tom910/subscriptions","organizations_url":"https://api.github.com/users/Tom910/orgs","repos_url":"https://api.github.com/users/Tom910/repos","events_url":"https://api.github.com/users/Tom910/events{/privacy}","received_events_url":"https://api.github.com/users/Tom910/received_events","type":"User","site_admin":false},"repo":{"id":79833980,"name":"webpack","full_name":"Tom910/webpack","owner":{"login":"Tom910","id":2185721,"avatar_url":"https://avatars.githubusercontent.com/u/2185721?v=3","gravatar_id":"","url":"https://api.github.com/users/Tom910","html_url":"https://github.com/Tom910","followers_url":"https://api.github.com/users/Tom910/followers","following_url":"https://api.github.com/users/Tom910/following{/other_user}","gists_url":"https://api.github.com/users/Tom910/gists{/gist_id}","starred_url":"https://api.github.com/users/Tom910/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tom910/subscriptions","organizations_url":"https://api.github.com/users/Tom910/orgs","repos_url":"https://api.github.com/users/Tom910/repos","events_url":"https://api.github.com/users/Tom910/events{/privacy}","received_events_url":"https://api.github.com/users/Tom910/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tom910/webpack","description":"A bundler for javascript and friends. Packs many modules into a few bundled assets. Code Splitting allows to load parts for the application on demand. Through \"loaders,\" modules can be CommonJs, AMD, ES6 modules, CSS, Images, JSON, Coffeescript, LESS, ... and your custom stuff.","fork":true,"url":"https://api.github.com/repos/Tom910/webpack","forks_url":"https://api.github.com/repos/Tom910/webpack/forks","keys_url":"https://api.github.com/repos/Tom910/webpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tom910/webpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tom910/webpack/teams","hooks_url":"https://api.github.com/repos/Tom910/webpack/hooks","issue_events_url":"https://api.github.com/repos/Tom910/webpack/issues/events{/number}","events_url":"https://api.github.com/repos/Tom910/webpack/events","assignees_url":"https://api.github.com/repos/Tom910/webpack/assignees{/user}","branches_url":"https://api.github.com/repos/Tom910/webpack/branches{/branch}","tags_url":"https://api.github.com/repos/Tom910/webpack/tags","blobs_url":"https://api.github.com/repos/Tom910/webpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tom910/webpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tom910/webpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tom910/webpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tom910/webpack/statuses/{sha}","languages_url":"https://api.github.com/repos/Tom910/webpack/languages","stargazers_url":"https://api.github.com/repos/Tom910/webpack/stargazers","contributors_url":"https://api.github.com/repos/Tom910/webpack/contributors","subscribers_url":"https://api.github.com/repos/Tom910/webpack/subscribers","subscription_url":"https://api.github.com/repos/Tom910/webpack/subscription","commits_url":"https://api.github.com/repos/Tom910/webpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tom910/webpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tom910/webpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tom910/webpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tom910/webpack/contents/{+path}","compare_url":"https://api.github.com/repos/Tom910/webpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tom910/webpack/merges","archive_url":"https://api.github.com/repos/Tom910/webpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tom910/webpack/downloads","issues_url":"https://api.github.com/repos/Tom910/webpack/issues{/number}","pulls_url":"https://api.github.com/repos/Tom910/webpack/pulls{/number}","milestones_url":"https://api.github.com/repos/Tom910/webpack/milestones{/number}","notifications_url":"https://api.github.com/repos/Tom910/webpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tom910/webpack/labels{/name}","releases_url":"https://api.github.com/repos/Tom910/webpack/releases{/id}","deployments_url":"https://api.github.com/repos/Tom910/webpack/deployments","created_at":"2017-01-23T18:27:36Z","updated_at":"2017-01-23T18:27:44Z","pushed_at":"2017-01-24T19:43:39Z","git_url":"git://github.com/Tom910/webpack.git","ssh_url":"[email protected]:Tom910/webpack.git","clone_url":"https://github.com/Tom910/webpack.git","svn_url":"https://github.com/Tom910/webpack","homepage":"https://webpack.js.org","size":5959,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webpack:master","ref":"master","sha":"5fde63994e4da9426320f8b3e59db1b9dc17c9ec","user":{"login":"webpack","id":2105791,"avatar_url":"https://avatars.githubusercontent.com/u/2105791?v=3","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"repo":{"id":3678731,"name":"webpack","full_name":"webpack/webpack","owner":{"login":"webpack","id":2105791,"avatar_url":"https://avatars.githubusercontent.com/u/2105791?v=3","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack/webpack","description":"A bundler for javascript and friends. Packs many modules into a few bundled assets. Code Splitting allows to load parts for the application on demand. Through \"loaders,\" modules can be CommonJs, AMD, ES6 modules, CSS, Images, JSON, Coffeescript, LESS, ... and your custom stuff.","fork":false,"url":"https://api.github.com/repos/webpack/webpack","forks_url":"https://api.github.com/repos/webpack/webpack/forks","keys_url":"https://api.github.com/repos/webpack/webpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack/webpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack/webpack/teams","hooks_url":"https://api.github.com/repos/webpack/webpack/hooks","issue_events_url":"https://api.github.com/repos/webpack/webpack/issues/events{/number}","events_url":"https://api.github.com/repos/webpack/webpack/events","assignees_url":"https://api.github.com/repos/webpack/webpack/assignees{/user}","branches_url":"https://api.github.com/repos/webpack/webpack/branches{/branch}","tags_url":"https://api.github.com/repos/webpack/webpack/tags","blobs_url":"https://api.github.com/repos/webpack/webpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack/webpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack/webpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack/webpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack/webpack/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack/webpack/languages","stargazers_url":"https://api.github.com/repos/webpack/webpack/stargazers","contributors_url":"https://api.github.com/repos/webpack/webpack/contributors","subscribers_url":"https://api.github.com/repos/webpack/webpack/subscribers","subscription_url":"https://api.github.com/repos/webpack/webpack/subscription","commits_url":"https://api.github.com/repos/webpack/webpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack/webpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack/webpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack/webpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack/webpack/contents/{+path}","compare_url":"https://api.github.com/repos/webpack/webpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack/webpack/merges","archive_url":"https://api.github.com/repos/webpack/webpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack/webpack/downloads","issues_url":"https://api.github.com/repos/webpack/webpack/issues{/number}","pulls_url":"https://api.github.com/repos/webpack/webpack/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack/webpack/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack/webpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack/webpack/labels{/name}","releases_url":"https://api.github.com/repos/webpack/webpack/releases{/id}","deployments_url":"https://api.github.com/repos/webpack/webpack/deployments","created_at":"2012-03-10T10:08:14Z","updated_at":"2017-01-25T19:08:39Z","pushed_at":"2017-01-25T19:27:44Z","git_url":"git://github.com/webpack/webpack.git","ssh_url":"[email protected]:webpack/webpack.git","clone_url":"https://github.com/webpack/webpack.git","svn_url":"https://github.com/webpack/webpack","homepage":"https://webpack.js.org","size":5967,"stargazers_count":23512,"watchers_count":23512,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2700,"mirror_url":null,"open_issues_count":692,"forks":2700,"open_issues":692,"watchers":23512,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack/pulls/4089"},"html":{"href":"https://github.com/webpack/webpack/pull/4089"},"issue":{"href":"https://api.github.com/repos/webpack/webpack/issues/4089"},"comments":{"href":"https://api.github.com/repos/webpack/webpack/issues/4089/comments"},"review_comments":{"href":"https://api.github.com/repos/webpack/webpack/pulls/4089/comments"},"review_comment":{"href":"https://api.github.com/repos/webpack/webpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webpack/webpack/pulls/4089/commits"},"statuses":{"href":"https://api.github.com/repos/webpack/webpack/statuses/588976d5e9385c878693914cf5429e7d47af378f"}}}} | {
"id": 3678731,
"name": "webpack/webpack",
"url": "https://api.github.com/repos/webpack/webpack"
} | {
"id": 2185721,
"login": "Tom910",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2185721?",
"url": "https://api.github.com/users/Tom910"
} | {
"id": 2105791,
"login": "webpack",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2105791?",
"url": "https://api.github.com/orgs/webpack"
} | 2017-01-25T19:32:39 | 5212989346 | {"actor":{"display_login":"Tom910"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/webpack/webpack-cli/pulls/comments/101918834","pull_request_review_id":22660499,"id":101918834,"diff_hunk":"@@ -0,0 +1,43 @@\n+const inquirer = require('inquirer');\n+const chalk = require('chalk');\n+\n+module.exports = function(questions, config) {\n+\tinquirer.prompt(questions).ui.process\n+ .reduce(function (newOpts, ans) {\n+\treturn attachAnswers(newOpts, ans);\n+}, Object.assign(config, require('./utils/initial-config')))\n+ .flatMap(newOpts => {\n+\tconst parser = require('./parser/index');\n+\treturn parser(null, checkEmptyAnswers(newOpts));\n+})\n+ .subscribeOnError( (err) => process.stdout.write(err.toString()));","path":"lib/inquirer-prompt.js","position":13,"original_position":13,"commit_id":"a918ac79b2f2d1014ba80e196d9d252cd13830fe","original_commit_id":"a918ac79b2f2d1014ba80e196d9d252cd13830fe","user":{"login":"okonet","id":11071,"avatar_url":"https://avatars.githubusercontent.com/u/11071?v=3","gravatar_id":"","url":"https://api.github.com/users/okonet","html_url":"https://github.com/okonet","followers_url":"https://api.github.com/users/okonet/followers","following_url":"https://api.github.com/users/okonet/following{/other_user}","gists_url":"https://api.github.com/users/okonet/gists{/gist_id}","starred_url":"https://api.github.com/users/okonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okonet/subscriptions","organizations_url":"https://api.github.com/users/okonet/orgs","repos_url":"https://api.github.com/users/okonet/repos","events_url":"https://api.github.com/users/okonet/events{/privacy}","received_events_url":"https://api.github.com/users/okonet/received_events","type":"User","site_admin":false},"body":"Extra white space or is the webpack standard?","created_at":"2017-02-19T14:23:28Z","updated_at":"2017-02-19T14:45:15Z","html_url":"https://github.com/webpack/webpack-cli/pull/59#discussion_r101918834","pull_request_url":"https://api.github.com/repos/webpack/webpack-cli/pulls/59","_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack-cli/pulls/comments/101918834"},"html":{"href":"https://github.com/webpack/webpack-cli/pull/59#discussion_r101918834"},"pull_request":{"href":"https://api.github.com/repos/webpack/webpack-cli/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/webpack/webpack-cli/pulls/59","id":106880226,"html_url":"https://github.com/webpack/webpack-cli/pull/59","diff_url":"https://github.com/webpack/webpack-cli/pull/59.diff","patch_url":"https://github.com/webpack/webpack-cli/pull/59.patch","issue_url":"https://api.github.com/repos/webpack/webpack-cli/issues/59","number":59,"state":"open","locked":false,"title":"Parser: Integrate Parser","user":{"login":"ev1stensberg","id":16735925,"avatar_url":"https://avatars.githubusercontent.com/u/16735925?v=3","gravatar_id":"","url":"https://api.github.com/users/ev1stensberg","html_url":"https://github.com/ev1stensberg","followers_url":"https://api.github.com/users/ev1stensberg/followers","following_url":"https://api.github.com/users/ev1stensberg/following{/other_user}","gists_url":"https://api.github.com/users/ev1stensberg/gists{/gist_id}","starred_url":"https://api.github.com/users/ev1stensberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev1stensberg/subscriptions","organizations_url":"https://api.github.com/users/ev1stensberg/orgs","repos_url":"https://api.github.com/users/ev1stensberg/repos","events_url":"https://api.github.com/users/ev1stensberg/events{/privacy}","received_events_url":"https://api.github.com/users/ev1stensberg/received_events","type":"User","site_admin":false},"body":"\r\n\r\n**What kind of change does this PR introduce?**\r\n\r\nIntegrates the initial structure of the parser. This allows us to extend inquirer prompts and validate file paths and the answers given to the inquirer prompt. It also allows us to build up an inquirer prompt using the `init` feature based on several packages.\r\n\r\n**Did you add tests for your changes?**\r\n\r\nYes.\r\n\r\n**If relevant, did you update the documentation?**\r\n\r\nNot relevant, no.\r\n\r\n**Summary**\r\n\r\nAdds the parser to the CLI build. Tests are included for the inquirer prompt. For the parser, we first need to add transformation rules using JSCodeshift, cause we are going to send the answers from inquirer to the AST for building up a webpack config so that `webpackOptionsValidation` doesn't throw an error.\r\n\r\n<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->\r\n\r\nv1 🎉 \r\n\r\n#57 \r\n#51 \r\n#44 \r\n#43 \r\n#41 \r\n\r\n**Does this PR introduce a breaking change?**\r\n\r\nYup\r\n\r\n**Other information**\r\n\r\nFurther work to be done after this PR is adding rules to build up a webpack config out of inquirer prompts and also adding tests to the parser. When ready for merge, me and @okonet has discussed some issues with rebasing the branch, and it seems that the branch got a \"bug\" from the commit \"Resolve Errors in Parser Validating the Wrong option\" and that it is better to either cherry pick or squash and merge the PR. ","created_at":"2017-02-18T22:56:23Z","updated_at":"2017-02-19T14:45:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f50bc0678e94e934df52db92bda7abfe43545d35","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/webpack/webpack-cli/milestones/1","html_url":"https://github.com/webpack/webpack-cli/milestone/1","labels_url":"https://api.github.com/repos/webpack/webpack-cli/milestones/1/labels","id":2227595,"number":1,"title":"v1","description":"First release approximation ","creator":{"login":"DanielaValero","id":1307954,"avatar_url":"https://avatars.githubusercontent.com/u/1307954?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielaValero","html_url":"https://github.com/DanielaValero","followers_url":"https://api.github.com/users/DanielaValero/followers","following_url":"https://api.github.com/users/DanielaValero/following{/other_user}","gists_url":"https://api.github.com/users/DanielaValero/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielaValero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielaValero/subscriptions","organizations_url":"https://api.github.com/users/DanielaValero/orgs","repos_url":"https://api.github.com/users/DanielaValero/repos","events_url":"https://api.github.com/users/DanielaValero/events{/privacy}","received_events_url":"https://api.github.com/users/DanielaValero/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":6,"state":"open","created_at":"2017-01-04T09:01:41Z","updated_at":"2017-02-18T22:56:23Z","due_on":"2017-03-03T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/webpack/webpack-cli/pulls/59/commits","review_comments_url":"https://api.github.com/repos/webpack/webpack-cli/pulls/59/comments","review_comment_url":"https://api.github.com/repos/webpack/webpack-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webpack/webpack-cli/issues/59/comments","statuses_url":"https://api.github.com/repos/webpack/webpack-cli/statuses/a918ac79b2f2d1014ba80e196d9d252cd13830fe","head":{"label":"webpack:feature/parser","ref":"feature/parser","sha":"a918ac79b2f2d1014ba80e196d9d252cd13830fe","user":{"login":"webpack","id":2105791,"avatar_url":"https://avatars.githubusercontent.com/u/2105791?v=3","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"repo":{"id":76603199,"name":"webpack-cli","full_name":"webpack/webpack-cli","owner":{"login":"webpack","id":2105791,"avatar_url":"https://avatars.githubusercontent.com/u/2105791?v=3","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack/webpack-cli","description":"webpack specific CLI for webpack & friends [WIP]","fork":false,"url":"https://api.github.com/repos/webpack/webpack-cli","forks_url":"https://api.github.com/repos/webpack/webpack-cli/forks","keys_url":"https://api.github.com/repos/webpack/webpack-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack/webpack-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack/webpack-cli/teams","hooks_url":"https://api.github.com/repos/webpack/webpack-cli/hooks","issue_events_url":"https://api.github.com/repos/webpack/webpack-cli/issues/events{/number}","events_url":"https://api.github.com/repos/webpack/webpack-cli/events","assignees_url":"https://api.github.com/repos/webpack/webpack-cli/assignees{/user}","branches_url":"https://api.github.com/repos/webpack/webpack-cli/branches{/branch}","tags_url":"https://api.github.com/repos/webpack/webpack-cli/tags","blobs_url":"https://api.github.com/repos/webpack/webpack-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack/webpack-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack/webpack-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack/webpack-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack/webpack-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack/webpack-cli/languages","stargazers_url":"https://api.github.com/repos/webpack/webpack-cli/stargazers","contributors_url":"https://api.github.com/repos/webpack/webpack-cli/contributors","subscribers_url":"https://api.github.com/repos/webpack/webpack-cli/subscribers","subscription_url":"https://api.github.com/repos/webpack/webpack-cli/subscription","commits_url":"https://api.github.com/repos/webpack/webpack-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack/webpack-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack/webpack-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack/webpack-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack/webpack-cli/contents/{+path}","compare_url":"https://api.github.com/repos/webpack/webpack-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack/webpack-cli/merges","archive_url":"https://api.github.com/repos/webpack/webpack-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack/webpack-cli/downloads","issues_url":"https://api.github.com/repos/webpack/webpack-cli/issues{/number}","pulls_url":"https://api.github.com/repos/webpack/webpack-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack/webpack-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack/webpack-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack/webpack-cli/labels{/name}","releases_url":"https://api.github.com/repos/webpack/webpack-cli/releases{/id}","deployments_url":"https://api.github.com/repos/webpack/webpack-cli/deployments","created_at":"2016-12-15T23:05:08Z","updated_at":"2017-02-17T05:30:25Z","pushed_at":"2017-02-19T14:09:29Z","git_url":"git://github.com/webpack/webpack-cli.git","ssh_url":"[email protected]:webpack/webpack-cli.git","clone_url":"https://github.com/webpack/webpack-cli.git","svn_url":"https://github.com/webpack/webpack-cli","homepage":"","size":210,"stargazers_count":81,"watchers_count":81,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":26,"forks":8,"open_issues":26,"watchers":81,"default_branch":"master"}},"base":{"label":"webpack:master","ref":"master","sha":"7284e0949937b8392987b88528f69c8c09c492c1","user":{"login":"webpack","id":2105791,"avatar_url":"https://avatars.githubusercontent.com/u/2105791?v=3","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"repo":{"id":76603199,"name":"webpack-cli","full_name":"webpack/webpack-cli","owner":{"login":"webpack","id":2105791,"avatar_url":"https://avatars.githubusercontent.com/u/2105791?v=3","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack/webpack-cli","description":"webpack specific CLI for webpack & friends [WIP]","fork":false,"url":"https://api.github.com/repos/webpack/webpack-cli","forks_url":"https://api.github.com/repos/webpack/webpack-cli/forks","keys_url":"https://api.github.com/repos/webpack/webpack-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack/webpack-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack/webpack-cli/teams","hooks_url":"https://api.github.com/repos/webpack/webpack-cli/hooks","issue_events_url":"https://api.github.com/repos/webpack/webpack-cli/issues/events{/number}","events_url":"https://api.github.com/repos/webpack/webpack-cli/events","assignees_url":"https://api.github.com/repos/webpack/webpack-cli/assignees{/user}","branches_url":"https://api.github.com/repos/webpack/webpack-cli/branches{/branch}","tags_url":"https://api.github.com/repos/webpack/webpack-cli/tags","blobs_url":"https://api.github.com/repos/webpack/webpack-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack/webpack-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack/webpack-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack/webpack-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack/webpack-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack/webpack-cli/languages","stargazers_url":"https://api.github.com/repos/webpack/webpack-cli/stargazers","contributors_url":"https://api.github.com/repos/webpack/webpack-cli/contributors","subscribers_url":"https://api.github.com/repos/webpack/webpack-cli/subscribers","subscription_url":"https://api.github.com/repos/webpack/webpack-cli/subscription","commits_url":"https://api.github.com/repos/webpack/webpack-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack/webpack-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack/webpack-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack/webpack-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack/webpack-cli/contents/{+path}","compare_url":"https://api.github.com/repos/webpack/webpack-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack/webpack-cli/merges","archive_url":"https://api.github.com/repos/webpack/webpack-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack/webpack-cli/downloads","issues_url":"https://api.github.com/repos/webpack/webpack-cli/issues{/number}","pulls_url":"https://api.github.com/repos/webpack/webpack-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack/webpack-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack/webpack-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack/webpack-cli/labels{/name}","releases_url":"https://api.github.com/repos/webpack/webpack-cli/releases{/id}","deployments_url":"https://api.github.com/repos/webpack/webpack-cli/deployments","created_at":"2016-12-15T23:05:08Z","updated_at":"2017-02-17T05:30:25Z","pushed_at":"2017-02-19T14:09:29Z","git_url":"git://github.com/webpack/webpack-cli.git","ssh_url":"[email protected]:webpack/webpack-cli.git","clone_url":"https://github.com/webpack/webpack-cli.git","svn_url":"https://github.com/webpack/webpack-cli","homepage":"","size":210,"stargazers_count":81,"watchers_count":81,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":26,"forks":8,"open_issues":26,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack-cli/pulls/59"},"html":{"href":"https://github.com/webpack/webpack-cli/pull/59"},"issue":{"href":"https://api.github.com/repos/webpack/webpack-cli/issues/59"},"comments":{"href":"https://api.github.com/repos/webpack/webpack-cli/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/webpack/webpack-cli/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/webpack/webpack-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webpack/webpack-cli/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/webpack/webpack-cli/statuses/a918ac79b2f2d1014ba80e196d9d252cd13830fe"}}}} | {
"id": 76603199,
"name": "webpack/webpack-cli",
"url": "https://api.github.com/repos/webpack/webpack-cli"
} | {
"id": 11071,
"login": "okonet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11071?",
"url": "https://api.github.com/users/okonet"
} | {
"id": 2105791,
"login": "webpack",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2105791?",
"url": "https://api.github.com/orgs/webpack"
} | 2017-02-19T14:23:28 | 5351521450 | {"actor":{"display_login":"okonet"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/wechaty/wechaty/pulls/comments/101557888","pull_request_review_id":22290205,"id":101557888,"diff_hunk":"@@ -18,8 +18,7 @@ export async function onMessage(message: Message): Promise<void> {\n \n console.log((room ? '[' + room.topic() + ']' : '')\n + '<' + sender.name() + '>'\n- + ':' + message.toStringDigest()\n- )\n+ + ':' + message.toStringDigest())","path":"example/gist-bot/on-message.ts","position":6,"original_position":6,"commit_id":"066a1a286b58213f034d8def6b5de2cbc5a1d5f7","original_commit_id":"066a1a286b58213f034d8def6b5de2cbc5a1d5f7","user":{"login":"zixia","id":1361891,"avatar_url":"https://avatars.githubusercontent.com/u/1361891?v=3","gravatar_id":"","url":"https://api.github.com/users/zixia","html_url":"https://github.com/zixia","followers_url":"https://api.github.com/users/zixia/followers","following_url":"https://api.github.com/users/zixia/following{/other_user}","gists_url":"https://api.github.com/users/zixia/gists{/gist_id}","starred_url":"https://api.github.com/users/zixia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zixia/subscriptions","organizations_url":"https://api.github.com/users/zixia/orgs","repos_url":"https://api.github.com/users/zixia/repos","events_url":"https://api.github.com/users/zixia/events{/privacy}","received_events_url":"https://api.github.com/users/zixia/received_events","type":"User","site_admin":false},"body":"Keep the original coding style of `)`","created_at":"2017-02-16T16:12:42Z","updated_at":"2017-02-16T17:02:26Z","html_url":"https://github.com/wechaty/wechaty/pull/263#discussion_r101557888","pull_request_url":"https://api.github.com/repos/wechaty/wechaty/pulls/263","_links":{"self":{"href":"https://api.github.com/repos/wechaty/wechaty/pulls/comments/101557888"},"html":{"href":"https://github.com/wechaty/wechaty/pull/263#discussion_r101557888"},"pull_request":{"href":"https://api.github.com/repos/wechaty/wechaty/pulls/263"}}},"pull_request":{"url":"https://api.github.com/repos/wechaty/wechaty/pulls/263","id":106502716,"html_url":"https://github.com/wechaty/wechaty/pull/263","diff_url":"https://github.com/wechaty/wechaty/pull/263.diff","patch_url":"https://github.com/wechaty/wechaty/pull/263.patch","issue_url":"https://api.github.com/repos/wechaty/wechaty/issues/263","number":263,"state":"open","locked":false,"title":"Add friendrequest sys message && fix for new tslint rule","user":{"login":"lijiarui","id":6419514,"avatar_url":"https://avatars.githubusercontent.com/u/6419514?v=3","gravatar_id":"","url":"https://api.github.com/users/lijiarui","html_url":"https://github.com/lijiarui","followers_url":"https://api.github.com/users/lijiarui/followers","following_url":"https://api.github.com/users/lijiarui/following{/other_user}","gists_url":"https://api.github.com/users/lijiarui/gists{/gist_id}","starred_url":"https://api.github.com/users/lijiarui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lijiarui/subscriptions","organizations_url":"https://api.github.com/users/lijiarui/orgs","repos_url":"https://api.github.com/users/lijiarui/repos","events_url":"https://api.github.com/users/lijiarui/events{/privacy}","received_events_url":"https://api.github.com/users/lijiarui/received_events","type":"User","site_admin":false},"body":"tslint #251 \r\n\r\nfix #260 ","created_at":"2017-02-16T11:09:38Z","updated_at":"2017-02-16T17:02:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e6a2f267ed9dd5c3dfec8721a8f25e262169cd7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wechaty/wechaty/pulls/263/commits","review_comments_url":"https://api.github.com/repos/wechaty/wechaty/pulls/263/comments","review_comment_url":"https://api.github.com/repos/wechaty/wechaty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wechaty/wechaty/issues/263/comments","statuses_url":"https://api.github.com/repos/wechaty/wechaty/statuses/066a1a286b58213f034d8def6b5de2cbc5a1d5f7","head":{"label":"lijiarui:251","ref":"251","sha":"066a1a286b58213f034d8def6b5de2cbc5a1d5f7","user":{"login":"lijiarui","id":6419514,"avatar_url":"https://avatars.githubusercontent.com/u/6419514?v=3","gravatar_id":"","url":"https://api.github.com/users/lijiarui","html_url":"https://github.com/lijiarui","followers_url":"https://api.github.com/users/lijiarui/followers","following_url":"https://api.github.com/users/lijiarui/following{/other_user}","gists_url":"https://api.github.com/users/lijiarui/gists{/gist_id}","starred_url":"https://api.github.com/users/lijiarui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lijiarui/subscriptions","organizations_url":"https://api.github.com/users/lijiarui/orgs","repos_url":"https://api.github.com/users/lijiarui/repos","events_url":"https://api.github.com/users/lijiarui/events{/privacy}","received_events_url":"https://api.github.com/users/lijiarui/received_events","type":"User","site_admin":false},"repo":{"id":65566664,"name":"wechaty","full_name":"lijiarui/wechaty","owner":{"login":"lijiarui","id":6419514,"avatar_url":"https://avatars.githubusercontent.com/u/6419514?v=3","gravatar_id":"","url":"https://api.github.com/users/lijiarui","html_url":"https://github.com/lijiarui","followers_url":"https://api.github.com/users/lijiarui/followers","following_url":"https://api.github.com/users/lijiarui/following{/other_user}","gists_url":"https://api.github.com/users/lijiarui/gists{/gist_id}","starred_url":"https://api.github.com/users/lijiarui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lijiarui/subscriptions","organizations_url":"https://api.github.com/users/lijiarui/orgs","repos_url":"https://api.github.com/users/lijiarui/repos","events_url":"https://api.github.com/users/lijiarui/events{/privacy}","received_events_url":"https://api.github.com/users/lijiarui/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lijiarui/wechaty","description":"Wechat for Bot. Powered by WebDriver & Node.js","fork":true,"url":"https://api.github.com/repos/lijiarui/wechaty","forks_url":"https://api.github.com/repos/lijiarui/wechaty/forks","keys_url":"https://api.github.com/repos/lijiarui/wechaty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lijiarui/wechaty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lijiarui/wechaty/teams","hooks_url":"https://api.github.com/repos/lijiarui/wechaty/hooks","issue_events_url":"https://api.github.com/repos/lijiarui/wechaty/issues/events{/number}","events_url":"https://api.github.com/repos/lijiarui/wechaty/events","assignees_url":"https://api.github.com/repos/lijiarui/wechaty/assignees{/user}","branches_url":"https://api.github.com/repos/lijiarui/wechaty/branches{/branch}","tags_url":"https://api.github.com/repos/lijiarui/wechaty/tags","blobs_url":"https://api.github.com/repos/lijiarui/wechaty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lijiarui/wechaty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lijiarui/wechaty/git/refs{/sha}","trees_url":"https://api.github.com/repos/lijiarui/wechaty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lijiarui/wechaty/statuses/{sha}","languages_url":"https://api.github.com/repos/lijiarui/wechaty/languages","stargazers_url":"https://api.github.com/repos/lijiarui/wechaty/stargazers","contributors_url":"https://api.github.com/repos/lijiarui/wechaty/contributors","subscribers_url":"https://api.github.com/repos/lijiarui/wechaty/subscribers","subscription_url":"https://api.github.com/repos/lijiarui/wechaty/subscription","commits_url":"https://api.github.com/repos/lijiarui/wechaty/commits{/sha}","git_commits_url":"https://api.github.com/repos/lijiarui/wechaty/git/commits{/sha}","comments_url":"https://api.github.com/repos/lijiarui/wechaty/comments{/number}","issue_comment_url":"https://api.github.com/repos/lijiarui/wechaty/issues/comments{/number}","contents_url":"https://api.github.com/repos/lijiarui/wechaty/contents/{+path}","compare_url":"https://api.github.com/repos/lijiarui/wechaty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lijiarui/wechaty/merges","archive_url":"https://api.github.com/repos/lijiarui/wechaty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lijiarui/wechaty/downloads","issues_url":"https://api.github.com/repos/lijiarui/wechaty/issues{/number}","pulls_url":"https://api.github.com/repos/lijiarui/wechaty/pulls{/number}","milestones_url":"https://api.github.com/repos/lijiarui/wechaty/milestones{/number}","notifications_url":"https://api.github.com/repos/lijiarui/wechaty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lijiarui/wechaty/labels{/name}","releases_url":"https://api.github.com/repos/lijiarui/wechaty/releases{/id}","deployments_url":"https://api.github.com/repos/lijiarui/wechaty/deployments","created_at":"2016-08-12T16:17:15Z","updated_at":"2016-11-26T17:00:31Z","pushed_at":"2017-02-16T11:08:50Z","git_url":"git://github.com/lijiarui/wechaty.git","ssh_url":"[email protected]:lijiarui/wechaty.git","clone_url":"https://github.com/lijiarui/wechaty.git","svn_url":"https://github.com/lijiarui/wechaty","homepage":"https://wechaty.io","size":2022,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wechaty:master","ref":"master","sha":"d65b673cb3bd1fa86c6456ebcb96ee9fb2d01806","user":{"login":"wechaty","id":21285357,"avatar_url":"https://avatars.githubusercontent.com/u/21285357?v=3","gravatar_id":"","url":"https://api.github.com/users/wechaty","html_url":"https://github.com/wechaty","followers_url":"https://api.github.com/users/wechaty/followers","following_url":"https://api.github.com/users/wechaty/following{/other_user}","gists_url":"https://api.github.com/users/wechaty/gists{/gist_id}","starred_url":"https://api.github.com/users/wechaty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wechaty/subscriptions","organizations_url":"https://api.github.com/users/wechaty/orgs","repos_url":"https://api.github.com/users/wechaty/repos","events_url":"https://api.github.com/users/wechaty/events{/privacy}","received_events_url":"https://api.github.com/users/wechaty/received_events","type":"Organization","site_admin":false},"repo":{"id":57602001,"name":"wechaty","full_name":"wechaty/wechaty","owner":{"login":"wechaty","id":21285357,"avatar_url":"https://avatars.githubusercontent.com/u/21285357?v=3","gravatar_id":"","url":"https://api.github.com/users/wechaty","html_url":"https://github.com/wechaty","followers_url":"https://api.github.com/users/wechaty/followers","following_url":"https://api.github.com/users/wechaty/following{/other_user}","gists_url":"https://api.github.com/users/wechaty/gists{/gist_id}","starred_url":"https://api.github.com/users/wechaty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wechaty/subscriptions","organizations_url":"https://api.github.com/users/wechaty/orgs","repos_url":"https://api.github.com/users/wechaty/repos","events_url":"https://api.github.com/users/wechaty/events{/privacy}","received_events_url":"https://api.github.com/users/wechaty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wechaty/wechaty","description":"Wechat for Bot. Powered by WebDriver / Node.js / Docker","fork":false,"url":"https://api.github.com/repos/wechaty/wechaty","forks_url":"https://api.github.com/repos/wechaty/wechaty/forks","keys_url":"https://api.github.com/repos/wechaty/wechaty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wechaty/wechaty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wechaty/wechaty/teams","hooks_url":"https://api.github.com/repos/wechaty/wechaty/hooks","issue_events_url":"https://api.github.com/repos/wechaty/wechaty/issues/events{/number}","events_url":"https://api.github.com/repos/wechaty/wechaty/events","assignees_url":"https://api.github.com/repos/wechaty/wechaty/assignees{/user}","branches_url":"https://api.github.com/repos/wechaty/wechaty/branches{/branch}","tags_url":"https://api.github.com/repos/wechaty/wechaty/tags","blobs_url":"https://api.github.com/repos/wechaty/wechaty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wechaty/wechaty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wechaty/wechaty/git/refs{/sha}","trees_url":"https://api.github.com/repos/wechaty/wechaty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wechaty/wechaty/statuses/{sha}","languages_url":"https://api.github.com/repos/wechaty/wechaty/languages","stargazers_url":"https://api.github.com/repos/wechaty/wechaty/stargazers","contributors_url":"https://api.github.com/repos/wechaty/wechaty/contributors","subscribers_url":"https://api.github.com/repos/wechaty/wechaty/subscribers","subscription_url":"https://api.github.com/repos/wechaty/wechaty/subscription","commits_url":"https://api.github.com/repos/wechaty/wechaty/commits{/sha}","git_commits_url":"https://api.github.com/repos/wechaty/wechaty/git/commits{/sha}","comments_url":"https://api.github.com/repos/wechaty/wechaty/comments{/number}","issue_comment_url":"https://api.github.com/repos/wechaty/wechaty/issues/comments{/number}","contents_url":"https://api.github.com/repos/wechaty/wechaty/contents/{+path}","compare_url":"https://api.github.com/repos/wechaty/wechaty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wechaty/wechaty/merges","archive_url":"https://api.github.com/repos/wechaty/wechaty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wechaty/wechaty/downloads","issues_url":"https://api.github.com/repos/wechaty/wechaty/issues{/number}","pulls_url":"https://api.github.com/repos/wechaty/wechaty/pulls{/number}","milestones_url":"https://api.github.com/repos/wechaty/wechaty/milestones{/number}","notifications_url":"https://api.github.com/repos/wechaty/wechaty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wechaty/wechaty/labels{/name}","releases_url":"https://api.github.com/repos/wechaty/wechaty/releases{/id}","deployments_url":"https://api.github.com/repos/wechaty/wechaty/deployments","created_at":"2016-05-01T14:36:45Z","updated_at":"2017-02-16T11:59:42Z","pushed_at":"2017-02-16T11:09:39Z","git_url":"git://github.com/wechaty/wechaty.git","ssh_url":"[email protected]:wechaty/wechaty.git","clone_url":"https://github.com/wechaty/wechaty.git","svn_url":"https://github.com/wechaty/wechaty","homepage":"https://blog.wechaty.io","size":1926,"stargazers_count":547,"watchers_count":547,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":97,"mirror_url":null,"open_issues_count":37,"forks":97,"open_issues":37,"watchers":547,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wechaty/wechaty/pulls/263"},"html":{"href":"https://github.com/wechaty/wechaty/pull/263"},"issue":{"href":"https://api.github.com/repos/wechaty/wechaty/issues/263"},"comments":{"href":"https://api.github.com/repos/wechaty/wechaty/issues/263/comments"},"review_comments":{"href":"https://api.github.com/repos/wechaty/wechaty/pulls/263/comments"},"review_comment":{"href":"https://api.github.com/repos/wechaty/wechaty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wechaty/wechaty/pulls/263/commits"},"statuses":{"href":"https://api.github.com/repos/wechaty/wechaty/statuses/066a1a286b58213f034d8def6b5de2cbc5a1d5f7"}}}} | {
"id": 57602001,
"name": "wechaty/wechaty",
"url": "https://api.github.com/repos/wechaty/wechaty"
} | {
"id": 1361891,
"login": "zixia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1361891?",
"url": "https://api.github.com/users/zixia"
} | {
"id": 21285357,
"login": "wechaty",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21285357?",
"url": "https://api.github.com/orgs/wechaty"
} | 2017-02-16T16:12:42 | 5338125425 | {"actor":{"display_login":"zixia"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/wiki-ai/editquality/pulls/comments/155231830","pull_request_review_id":81515605,"id":155231830,"diff_hunk":"@@ -1096,6 +1096,80 @@ eswikibooks_tuning_reports: \\\n \t\ttuning_reports/eswikibooks.damaging.md\n \t\ttuning_reports/eswikibooks.goodfaith.md\n \n+############################# Spanish Wikiquote ################################\n+\n+# From https://quarry.wmflabs.org/query/23421\n+datasets/eswikiquote.sampled_revisions.12k_2017.json:\n+\twget -qO- https://quarry.wmflabs.org/run/219894/output/0/json-lines?download=true > $@\n+\n+datasets/eswikiquote.revisions_for_review.5k_2017.json: \\\n+\t\tdatasets/eswikiquote.autolabeled_revisions.12k_2017.json\n+\t( \\\n+\t cat $< | \\\n+\t grep '\"needs_review\": true' | \\\n+\t shuf -n 2500; \\\n+\t cat $< | \\\n+\t grep '\"needs_review\": false' | \\\n+\t shuf -n 2500 \\\n+\t) | shuf > $@","path":"Makefile","position":null,"original_position":19,"commit_id":"4813659a59388d952629faaee8de6db0fbee42c4","original_commit_id":"399cedf3ac5c95ed9c75021f2b6551700e3413cc","user":{"login":"Ladsgroup","id":5351225,"avatar_url":"https://avatars1.githubusercontent.com/u/5351225?v=4","gravatar_id":"","url":"https://api.github.com/users/Ladsgroup","html_url":"https://github.com/Ladsgroup","followers_url":"https://api.github.com/users/Ladsgroup/followers","following_url":"https://api.github.com/users/Ladsgroup/following{/other_user}","gists_url":"https://api.github.com/users/Ladsgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladsgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladsgroup/subscriptions","organizations_url":"https://api.github.com/users/Ladsgroup/orgs","repos_url":"https://api.github.com/users/Ladsgroup/repos","events_url":"https://api.github.com/users/Ladsgroup/events{/privacy}","received_events_url":"https://api.github.com/users/Ladsgroup/received_events","type":"User","site_admin":false},"body":"Done, looked at old PRs. Hope that's what you mean.","created_at":"2017-12-06T13:13:19Z","updated_at":"2017-12-06T13:13:19Z","html_url":"https://github.com/wiki-ai/editquality/pull/108#discussion_r155231830","pull_request_url":"https://api.github.com/repos/wiki-ai/editquality/pulls/108","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/wiki-ai/editquality/pulls/comments/155231830"},"html":{"href":"https://github.com/wiki-ai/editquality/pull/108#discussion_r155231830"},"pull_request":{"href":"https://api.github.com/repos/wiki-ai/editquality/pulls/108"}},"in_reply_to_id":154693710},"pull_request":{"url":"https://api.github.com/repos/wiki-ai/editquality/pulls/108","id":156153397,"html_url":"https://github.com/wiki-ai/editquality/pull/108","diff_url":"https://github.com/wiki-ai/editquality/pull/108.diff","patch_url":"https://github.com/wiki-ai/editquality/pull/108.patch","issue_url":"https://api.github.com/repos/wiki-ai/editquality/issues/108","number":108,"state":"open","locked":false,"title":"Add eswikiquote reverted models and revisions for review","user":{"login":"Ladsgroup","id":5351225,"avatar_url":"https://avatars1.githubusercontent.com/u/5351225?v=4","gravatar_id":"","url":"https://api.github.com/users/Ladsgroup","html_url":"https://github.com/Ladsgroup","followers_url":"https://api.github.com/users/Ladsgroup/followers","following_url":"https://api.github.com/users/Ladsgroup/following{/other_user}","gists_url":"https://api.github.com/users/Ladsgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladsgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladsgroup/subscriptions","organizations_url":"https://api.github.com/users/Ladsgroup/orgs","repos_url":"https://api.github.com/users/Ladsgroup/repos","events_url":"https://api.github.com/users/Ladsgroup/events{/privacy}","received_events_url":"https://api.github.com/users/Ladsgroup/received_events","type":"User","site_admin":false},"body":"Made with ❤️ in stat1005 machine.\r\n\r\nBug: T177762","created_at":"2017-12-04T10:01:31Z","updated_at":"2017-12-06T13:13:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5221baded9283135e4192e351286a4588a2bcc77","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/wiki-ai/editquality/pulls/108/commits","review_comments_url":"https://api.github.com/repos/wiki-ai/editquality/pulls/108/comments","review_comment_url":"https://api.github.com/repos/wiki-ai/editquality/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wiki-ai/editquality/issues/108/comments","statuses_url":"https://api.github.com/repos/wiki-ai/editquality/statuses/4813659a59388d952629faaee8de6db0fbee42c4","head":{"label":"wiki-ai:eswikiquote","ref":"eswikiquote","sha":"4813659a59388d952629faaee8de6db0fbee42c4","user":{"login":"wiki-ai","id":12821767,"avatar_url":"https://avatars1.githubusercontent.com/u/12821767?v=4","gravatar_id":"","url":"https://api.github.com/users/wiki-ai","html_url":"https://github.com/wiki-ai","followers_url":"https://api.github.com/users/wiki-ai/followers","following_url":"https://api.github.com/users/wiki-ai/following{/other_user}","gists_url":"https://api.github.com/users/wiki-ai/gists{/gist_id}","starred_url":"https://api.github.com/users/wiki-ai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiki-ai/subscriptions","organizations_url":"https://api.github.com/users/wiki-ai/orgs","repos_url":"https://api.github.com/users/wiki-ai/repos","events_url":"https://api.github.com/users/wiki-ai/events{/privacy}","received_events_url":"https://api.github.com/users/wiki-ai/received_events","type":"Organization","site_admin":false},"repo":{"id":42016242,"name":"editquality","full_name":"wiki-ai/editquality","owner":{"login":"wiki-ai","id":12821767,"avatar_url":"https://avatars1.githubusercontent.com/u/12821767?v=4","gravatar_id":"","url":"https://api.github.com/users/wiki-ai","html_url":"https://github.com/wiki-ai","followers_url":"https://api.github.com/users/wiki-ai/followers","following_url":"https://api.github.com/users/wiki-ai/following{/other_user}","gists_url":"https://api.github.com/users/wiki-ai/gists{/gist_id}","starred_url":"https://api.github.com/users/wiki-ai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiki-ai/subscriptions","organizations_url":"https://api.github.com/users/wiki-ai/orgs","repos_url":"https://api.github.com/users/wiki-ai/repos","events_url":"https://api.github.com/users/wiki-ai/events{/privacy}","received_events_url":"https://api.github.com/users/wiki-ai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wiki-ai/editquality","description":"Supervised learning approach to determining the quality of edits in Wikipedia","fork":false,"url":"https://api.github.com/repos/wiki-ai/editquality","forks_url":"https://api.github.com/repos/wiki-ai/editquality/forks","keys_url":"https://api.github.com/repos/wiki-ai/editquality/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wiki-ai/editquality/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wiki-ai/editquality/teams","hooks_url":"https://api.github.com/repos/wiki-ai/editquality/hooks","issue_events_url":"https://api.github.com/repos/wiki-ai/editquality/issues/events{/number}","events_url":"https://api.github.com/repos/wiki-ai/editquality/events","assignees_url":"https://api.github.com/repos/wiki-ai/editquality/assignees{/user}","branches_url":"https://api.github.com/repos/wiki-ai/editquality/branches{/branch}","tags_url":"https://api.github.com/repos/wiki-ai/editquality/tags","blobs_url":"https://api.github.com/repos/wiki-ai/editquality/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wiki-ai/editquality/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wiki-ai/editquality/git/refs{/sha}","trees_url":"https://api.github.com/repos/wiki-ai/editquality/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wiki-ai/editquality/statuses/{sha}","languages_url":"https://api.github.com/repos/wiki-ai/editquality/languages","stargazers_url":"https://api.github.com/repos/wiki-ai/editquality/stargazers","contributors_url":"https://api.github.com/repos/wiki-ai/editquality/contributors","subscribers_url":"https://api.github.com/repos/wiki-ai/editquality/subscribers","subscription_url":"https://api.github.com/repos/wiki-ai/editquality/subscription","commits_url":"https://api.github.com/repos/wiki-ai/editquality/commits{/sha}","git_commits_url":"https://api.github.com/repos/wiki-ai/editquality/git/commits{/sha}","comments_url":"https://api.github.com/repos/wiki-ai/editquality/comments{/number}","issue_comment_url":"https://api.github.com/repos/wiki-ai/editquality/issues/comments{/number}","contents_url":"https://api.github.com/repos/wiki-ai/editquality/contents/{+path}","compare_url":"https://api.github.com/repos/wiki-ai/editquality/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wiki-ai/editquality/merges","archive_url":"https://api.github.com/repos/wiki-ai/editquality/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wiki-ai/editquality/downloads","issues_url":"https://api.github.com/repos/wiki-ai/editquality/issues{/number}","pulls_url":"https://api.github.com/repos/wiki-ai/editquality/pulls{/number}","milestones_url":"https://api.github.com/repos/wiki-ai/editquality/milestones{/number}","notifications_url":"https://api.github.com/repos/wiki-ai/editquality/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wiki-ai/editquality/labels{/name}","releases_url":"https://api.github.com/repos/wiki-ai/editquality/releases{/id}","deployments_url":"https://api.github.com/repos/wiki-ai/editquality/deployments","created_at":"2015-09-06T19:33:21Z","updated_at":"2017-11-22T02:37:09Z","pushed_at":"2017-12-06T13:11:15Z","git_url":"git://github.com/wiki-ai/editquality.git","ssh_url":"[email protected]:wiki-ai/editquality.git","clone_url":"https://github.com/wiki-ai/editquality.git","svn_url":"https://github.com/wiki-ai/editquality","homepage":null,"size":2104326,"stargazers_count":11,"watchers_count":11,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":11,"open_issues":5,"watchers":11,"default_branch":"master"}},"base":{"label":"wiki-ai:master","ref":"master","sha":"ac3042ee681242c64c078ca67f2dc4a4699b6bbd","user":{"login":"wiki-ai","id":12821767,"avatar_url":"https://avatars1.githubusercontent.com/u/12821767?v=4","gravatar_id":"","url":"https://api.github.com/users/wiki-ai","html_url":"https://github.com/wiki-ai","followers_url":"https://api.github.com/users/wiki-ai/followers","following_url":"https://api.github.com/users/wiki-ai/following{/other_user}","gists_url":"https://api.github.com/users/wiki-ai/gists{/gist_id}","starred_url":"https://api.github.com/users/wiki-ai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiki-ai/subscriptions","organizations_url":"https://api.github.com/users/wiki-ai/orgs","repos_url":"https://api.github.com/users/wiki-ai/repos","events_url":"https://api.github.com/users/wiki-ai/events{/privacy}","received_events_url":"https://api.github.com/users/wiki-ai/received_events","type":"Organization","site_admin":false},"repo":{"id":42016242,"name":"editquality","full_name":"wiki-ai/editquality","owner":{"login":"wiki-ai","id":12821767,"avatar_url":"https://avatars1.githubusercontent.com/u/12821767?v=4","gravatar_id":"","url":"https://api.github.com/users/wiki-ai","html_url":"https://github.com/wiki-ai","followers_url":"https://api.github.com/users/wiki-ai/followers","following_url":"https://api.github.com/users/wiki-ai/following{/other_user}","gists_url":"https://api.github.com/users/wiki-ai/gists{/gist_id}","starred_url":"https://api.github.com/users/wiki-ai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiki-ai/subscriptions","organizations_url":"https://api.github.com/users/wiki-ai/orgs","repos_url":"https://api.github.com/users/wiki-ai/repos","events_url":"https://api.github.com/users/wiki-ai/events{/privacy}","received_events_url":"https://api.github.com/users/wiki-ai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wiki-ai/editquality","description":"Supervised learning approach to determining the quality of edits in Wikipedia","fork":false,"url":"https://api.github.com/repos/wiki-ai/editquality","forks_url":"https://api.github.com/repos/wiki-ai/editquality/forks","keys_url":"https://api.github.com/repos/wiki-ai/editquality/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wiki-ai/editquality/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wiki-ai/editquality/teams","hooks_url":"https://api.github.com/repos/wiki-ai/editquality/hooks","issue_events_url":"https://api.github.com/repos/wiki-ai/editquality/issues/events{/number}","events_url":"https://api.github.com/repos/wiki-ai/editquality/events","assignees_url":"https://api.github.com/repos/wiki-ai/editquality/assignees{/user}","branches_url":"https://api.github.com/repos/wiki-ai/editquality/branches{/branch}","tags_url":"https://api.github.com/repos/wiki-ai/editquality/tags","blobs_url":"https://api.github.com/repos/wiki-ai/editquality/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wiki-ai/editquality/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wiki-ai/editquality/git/refs{/sha}","trees_url":"https://api.github.com/repos/wiki-ai/editquality/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wiki-ai/editquality/statuses/{sha}","languages_url":"https://api.github.com/repos/wiki-ai/editquality/languages","stargazers_url":"https://api.github.com/repos/wiki-ai/editquality/stargazers","contributors_url":"https://api.github.com/repos/wiki-ai/editquality/contributors","subscribers_url":"https://api.github.com/repos/wiki-ai/editquality/subscribers","subscription_url":"https://api.github.com/repos/wiki-ai/editquality/subscription","commits_url":"https://api.github.com/repos/wiki-ai/editquality/commits{/sha}","git_commits_url":"https://api.github.com/repos/wiki-ai/editquality/git/commits{/sha}","comments_url":"https://api.github.com/repos/wiki-ai/editquality/comments{/number}","issue_comment_url":"https://api.github.com/repos/wiki-ai/editquality/issues/comments{/number}","contents_url":"https://api.github.com/repos/wiki-ai/editquality/contents/{+path}","compare_url":"https://api.github.com/repos/wiki-ai/editquality/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wiki-ai/editquality/merges","archive_url":"https://api.github.com/repos/wiki-ai/editquality/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wiki-ai/editquality/downloads","issues_url":"https://api.github.com/repos/wiki-ai/editquality/issues{/number}","pulls_url":"https://api.github.com/repos/wiki-ai/editquality/pulls{/number}","milestones_url":"https://api.github.com/repos/wiki-ai/editquality/milestones{/number}","notifications_url":"https://api.github.com/repos/wiki-ai/editquality/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wiki-ai/editquality/labels{/name}","releases_url":"https://api.github.com/repos/wiki-ai/editquality/releases{/id}","deployments_url":"https://api.github.com/repos/wiki-ai/editquality/deployments","created_at":"2015-09-06T19:33:21Z","updated_at":"2017-11-22T02:37:09Z","pushed_at":"2017-12-06T13:11:15Z","git_url":"git://github.com/wiki-ai/editquality.git","ssh_url":"[email protected]:wiki-ai/editquality.git","clone_url":"https://github.com/wiki-ai/editquality.git","svn_url":"https://github.com/wiki-ai/editquality","homepage":null,"size":2104326,"stargazers_count":11,"watchers_count":11,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":11,"open_issues":5,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wiki-ai/editquality/pulls/108"},"html":{"href":"https://github.com/wiki-ai/editquality/pull/108"},"issue":{"href":"https://api.github.com/repos/wiki-ai/editquality/issues/108"},"comments":{"href":"https://api.github.com/repos/wiki-ai/editquality/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/wiki-ai/editquality/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/wiki-ai/editquality/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wiki-ai/editquality/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/wiki-ai/editquality/statuses/4813659a59388d952629faaee8de6db0fbee42c4"}},"author_association":"OWNER"}} | {
"id": 42016242,
"name": "wiki-ai/editquality",
"url": "https://api.github.com/repos/wiki-ai/editquality"
} | {
"id": 5351225,
"login": "Ladsgroup",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5351225?",
"url": "https://api.github.com/users/Ladsgroup"
} | {
"id": 12821767,
"login": "wiki-ai",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12821767?",
"url": "https://api.github.com/orgs/wiki-ai"
} | 2017-12-06T13:13:19 | 6951063765 | {"actor":{"display_login":"Ladsgroup"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/winkapp/spark-cluster-docker/pulls/comments/98792431","pull_request_review_id":19446286,"id":98792431,"diff_hunk":"@@ -1,10 +1,9 @@\n-FROM ubuntu:14.04\n-MAINTAINER Wink\n+FROM openjdk:8\n \n-RUN apt-get update; apt-get install -y curl default-jdk\n+RUN apt-get update; apt-get upgrade","path":"Dockerfile","position":6,"original_position":6,"commit_id":"436574dfe69e60206f68b781627b9c42fbb8cbd7","original_commit_id":"436574dfe69e60206f68b781627b9c42fbb8cbd7","user":{"login":"nsmith","id":116345,"avatar_url":"https://avatars.githubusercontent.com/u/116345?v=3","gravatar_id":"","url":"https://api.github.com/users/nsmith","html_url":"https://github.com/nsmith","followers_url":"https://api.github.com/users/nsmith/followers","following_url":"https://api.github.com/users/nsmith/following{/other_user}","gists_url":"https://api.github.com/users/nsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/nsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsmith/subscriptions","organizations_url":"https://api.github.com/users/nsmith/orgs","repos_url":"https://api.github.com/users/nsmith/repos","events_url":"https://api.github.com/users/nsmith/events{/privacy}","received_events_url":"https://api.github.com/users/nsmith/received_events","type":"User","site_admin":false},"body":"@kalmanchapman you sure you want to upgrade packages across the board on every build? This will make container builds non-deterministic. You could build something locally and have it run perfectly, and then the production container built in CI might fail b/c of package differences if something was updated between.","created_at":"2017-01-31T22:57:38Z","updated_at":"2017-01-31T22:57:38Z","html_url":"https://github.com/winkapp/spark-cluster-docker/pull/6#discussion_r98792431","pull_request_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/winkapp/spark-cluster-docker/pulls/comments/98792431"},"html":{"href":"https://github.com/winkapp/spark-cluster-docker/pull/6#discussion_r98792431"},"pull_request":{"href":"https://api.github.com/repos/winkapp/spark-cluster-docker/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/winkapp/spark-cluster-docker/pulls/6","id":104034127,"html_url":"https://github.com/winkapp/spark-cluster-docker/pull/6","diff_url":"https://github.com/winkapp/spark-cluster-docker/pull/6.diff","patch_url":"https://github.com/winkapp/spark-cluster-docker/pull/6.patch","issue_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/issues/6","number":6,"state":"open","locked":false,"title":"Spark 2.1.0","user":{"login":"kalmanchapman","id":22159259,"avatar_url":"https://avatars.githubusercontent.com/u/22159259?v=3","gravatar_id":"","url":"https://api.github.com/users/kalmanchapman","html_url":"https://github.com/kalmanchapman","followers_url":"https://api.github.com/users/kalmanchapman/followers","following_url":"https://api.github.com/users/kalmanchapman/following{/other_user}","gists_url":"https://api.github.com/users/kalmanchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/kalmanchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalmanchapman/subscriptions","organizations_url":"https://api.github.com/users/kalmanchapman/orgs","repos_url":"https://api.github.com/users/kalmanchapman/repos","events_url":"https://api.github.com/users/kalmanchapman/events{/privacy}","received_events_url":"https://api.github.com/users/kalmanchapman/received_events","type":"User","site_admin":false},"body":"this pr is for building a containerized spark 2.1.0 cluster.","created_at":"2017-01-31T22:10:09Z","updated_at":"2017-01-31T22:57:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f23046d66a35a8b0113828b9deb6e3f9a6baa54","assignee":{"login":"kalmanchapman","id":22159259,"avatar_url":"https://avatars.githubusercontent.com/u/22159259?v=3","gravatar_id":"","url":"https://api.github.com/users/kalmanchapman","html_url":"https://github.com/kalmanchapman","followers_url":"https://api.github.com/users/kalmanchapman/followers","following_url":"https://api.github.com/users/kalmanchapman/following{/other_user}","gists_url":"https://api.github.com/users/kalmanchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/kalmanchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalmanchapman/subscriptions","organizations_url":"https://api.github.com/users/kalmanchapman/orgs","repos_url":"https://api.github.com/users/kalmanchapman/repos","events_url":"https://api.github.com/users/kalmanchapman/events{/privacy}","received_events_url":"https://api.github.com/users/kalmanchapman/received_events","type":"User","site_admin":false},"assignees":[{"login":"kalmanchapman","id":22159259,"avatar_url":"https://avatars.githubusercontent.com/u/22159259?v=3","gravatar_id":"","url":"https://api.github.com/users/kalmanchapman","html_url":"https://github.com/kalmanchapman","followers_url":"https://api.github.com/users/kalmanchapman/followers","following_url":"https://api.github.com/users/kalmanchapman/following{/other_user}","gists_url":"https://api.github.com/users/kalmanchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/kalmanchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalmanchapman/subscriptions","organizations_url":"https://api.github.com/users/kalmanchapman/orgs","repos_url":"https://api.github.com/users/kalmanchapman/repos","events_url":"https://api.github.com/users/kalmanchapman/events{/privacy}","received_events_url":"https://api.github.com/users/kalmanchapman/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/pulls/6/commits","review_comments_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/pulls/6/comments","review_comment_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/issues/6/comments","statuses_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/statuses/436574dfe69e60206f68b781627b9c42fbb8cbd7","head":{"label":"winkapp:spark_2.1.0","ref":"spark_2.1.0","sha":"436574dfe69e60206f68b781627b9c42fbb8cbd7","user":{"login":"winkapp","id":6343197,"avatar_url":"https://avatars.githubusercontent.com/u/6343197?v=3","gravatar_id":"","url":"https://api.github.com/users/winkapp","html_url":"https://github.com/winkapp","followers_url":"https://api.github.com/users/winkapp/followers","following_url":"https://api.github.com/users/winkapp/following{/other_user}","gists_url":"https://api.github.com/users/winkapp/gists{/gist_id}","starred_url":"https://api.github.com/users/winkapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winkapp/subscriptions","organizations_url":"https://api.github.com/users/winkapp/orgs","repos_url":"https://api.github.com/users/winkapp/repos","events_url":"https://api.github.com/users/winkapp/events{/privacy}","received_events_url":"https://api.github.com/users/winkapp/received_events","type":"Organization","site_admin":false},"repo":{"id":45000002,"name":"spark-cluster-docker","full_name":"winkapp/spark-cluster-docker","owner":{"login":"winkapp","id":6343197,"avatar_url":"https://avatars.githubusercontent.com/u/6343197?v=3","gravatar_id":"","url":"https://api.github.com/users/winkapp","html_url":"https://github.com/winkapp","followers_url":"https://api.github.com/users/winkapp/followers","following_url":"https://api.github.com/users/winkapp/following{/other_user}","gists_url":"https://api.github.com/users/winkapp/gists{/gist_id}","starred_url":"https://api.github.com/users/winkapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winkapp/subscriptions","organizations_url":"https://api.github.com/users/winkapp/orgs","repos_url":"https://api.github.com/users/winkapp/repos","events_url":"https://api.github.com/users/winkapp/events{/privacy}","received_events_url":"https://api.github.com/users/winkapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/winkapp/spark-cluster-docker","description":"Basic spark image targeted at creating standalone clusters.","fork":false,"url":"https://api.github.com/repos/winkapp/spark-cluster-docker","forks_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/forks","keys_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/teams","hooks_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/hooks","issue_events_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/issues/events{/number}","events_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/events","assignees_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/assignees{/user}","branches_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/branches{/branch}","tags_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/tags","blobs_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/languages","stargazers_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/stargazers","contributors_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/contributors","subscribers_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/subscribers","subscription_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/subscription","commits_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/contents/{+path}","compare_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/merges","archive_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/downloads","issues_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/issues{/number}","pulls_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/labels{/name}","releases_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/releases{/id}","deployments_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/deployments","created_at":"2015-10-26T22:00:02Z","updated_at":"2017-01-11T19:33:45Z","pushed_at":"2017-01-31T22:52:42Z","git_url":"git://github.com/winkapp/spark-cluster-docker.git","ssh_url":"[email protected]:winkapp/spark-cluster-docker.git","clone_url":"https://github.com/winkapp/spark-cluster-docker.git","svn_url":"https://github.com/winkapp/spark-cluster-docker","homepage":null,"size":19,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"winkapp:master","ref":"master","sha":"bf7d688cdc1ea709d31d2519d431c7264b8bf6aa","user":{"login":"winkapp","id":6343197,"avatar_url":"https://avatars.githubusercontent.com/u/6343197?v=3","gravatar_id":"","url":"https://api.github.com/users/winkapp","html_url":"https://github.com/winkapp","followers_url":"https://api.github.com/users/winkapp/followers","following_url":"https://api.github.com/users/winkapp/following{/other_user}","gists_url":"https://api.github.com/users/winkapp/gists{/gist_id}","starred_url":"https://api.github.com/users/winkapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winkapp/subscriptions","organizations_url":"https://api.github.com/users/winkapp/orgs","repos_url":"https://api.github.com/users/winkapp/repos","events_url":"https://api.github.com/users/winkapp/events{/privacy}","received_events_url":"https://api.github.com/users/winkapp/received_events","type":"Organization","site_admin":false},"repo":{"id":45000002,"name":"spark-cluster-docker","full_name":"winkapp/spark-cluster-docker","owner":{"login":"winkapp","id":6343197,"avatar_url":"https://avatars.githubusercontent.com/u/6343197?v=3","gravatar_id":"","url":"https://api.github.com/users/winkapp","html_url":"https://github.com/winkapp","followers_url":"https://api.github.com/users/winkapp/followers","following_url":"https://api.github.com/users/winkapp/following{/other_user}","gists_url":"https://api.github.com/users/winkapp/gists{/gist_id}","starred_url":"https://api.github.com/users/winkapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winkapp/subscriptions","organizations_url":"https://api.github.com/users/winkapp/orgs","repos_url":"https://api.github.com/users/winkapp/repos","events_url":"https://api.github.com/users/winkapp/events{/privacy}","received_events_url":"https://api.github.com/users/winkapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/winkapp/spark-cluster-docker","description":"Basic spark image targeted at creating standalone clusters.","fork":false,"url":"https://api.github.com/repos/winkapp/spark-cluster-docker","forks_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/forks","keys_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/teams","hooks_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/hooks","issue_events_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/issues/events{/number}","events_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/events","assignees_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/assignees{/user}","branches_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/branches{/branch}","tags_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/tags","blobs_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/languages","stargazers_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/stargazers","contributors_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/contributors","subscribers_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/subscribers","subscription_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/subscription","commits_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/contents/{+path}","compare_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/merges","archive_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/downloads","issues_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/issues{/number}","pulls_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/labels{/name}","releases_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/releases{/id}","deployments_url":"https://api.github.com/repos/winkapp/spark-cluster-docker/deployments","created_at":"2015-10-26T22:00:02Z","updated_at":"2017-01-11T19:33:45Z","pushed_at":"2017-01-31T22:52:42Z","git_url":"git://github.com/winkapp/spark-cluster-docker.git","ssh_url":"[email protected]:winkapp/spark-cluster-docker.git","clone_url":"https://github.com/winkapp/spark-cluster-docker.git","svn_url":"https://github.com/winkapp/spark-cluster-docker","homepage":null,"size":19,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/winkapp/spark-cluster-docker/pulls/6"},"html":{"href":"https://github.com/winkapp/spark-cluster-docker/pull/6"},"issue":{"href":"https://api.github.com/repos/winkapp/spark-cluster-docker/issues/6"},"comments":{"href":"https://api.github.com/repos/winkapp/spark-cluster-docker/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/winkapp/spark-cluster-docker/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/winkapp/spark-cluster-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/winkapp/spark-cluster-docker/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/winkapp/spark-cluster-docker/statuses/436574dfe69e60206f68b781627b9c42fbb8cbd7"}}}} | {
"id": 45000002,
"name": "winkapp/spark-cluster-docker",
"url": "https://api.github.com/repos/winkapp/spark-cluster-docker"
} | {
"id": 116345,
"login": "nsmith",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/116345?",
"url": "https://api.github.com/users/nsmith"
} | {
"id": 6343197,
"login": "winkapp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6343197?",
"url": "https://api.github.com/orgs/winkapp"
} | 2017-01-31T22:57:38 | 5244260350 | {"actor":{"display_login":"nsmith"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/comments/99823839","pull_request_review_id":20509214,"id":99823839,"diff_hunk":"@@ -0,0 +1,184 @@\n+//","path":"Source/Notifications/SearchUserObserverCenter.swift","position":1,"original_position":1,"commit_id":"15edbb9ec9a39f541c27dbab3c1f1a65f4a3f4dc","original_commit_id":"15edbb9ec9a39f541c27dbab3c1f1a65f4a3f4dc","user":{"login":"wire-bot","id":20773876,"avatar_url":"https://avatars.githubusercontent.com/u/20773876?v=3","gravatar_id":"","url":"https://api.github.com/users/wire-bot","html_url":"https://github.com/wire-bot","followers_url":"https://api.github.com/users/wire-bot/followers","following_url":"https://api.github.com/users/wire-bot/following{/other_user}","gists_url":"https://api.github.com/users/wire-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/wire-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wire-bot/subscriptions","organizations_url":"https://api.github.com/users/wire-bot/orgs","repos_url":"https://api.github.com/users/wire-bot/repos","events_url":"https://api.github.com/users/wire-bot/events{/privacy}","received_events_url":"https://api.github.com/users/wire-bot/received_events","type":"User","site_admin":false},"body":"<table data-meta=\"generated_by_danger\">\n <tbody>\n <tr>\n <td>:warning:</td>\n <td width=\"100%\" data-sticky=\"true\"><span data-href=\"https://github.com/wireapp/wire-ios-data-model/blob/15edbb9ec9a39f541c27dbab3c1f1a65f4a3f4dc/Source/Notifications/SearchUserObserverCenter.swift#L1\"></span>Your copyright header is so last year!</td>\n </tr>\n </tbody>\n</table>\n\n\n\n","created_at":"2017-02-07T13:43:53Z","updated_at":"2017-02-07T13:43:53Z","html_url":"https://github.com/wireapp/wire-ios-data-model/pull/138#discussion_r99823839","pull_request_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/138","_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/comments/99823839"},"html":{"href":"https://github.com/wireapp/wire-ios-data-model/pull/138#discussion_r99823839"},"pull_request":{"href":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/138"}}},"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/138","id":102247393,"html_url":"https://github.com/wireapp/wire-ios-data-model/pull/138","diff_url":"https://github.com/wireapp/wire-ios-data-model/pull/138.diff","patch_url":"https://github.com/wireapp/wire-ios-data-model/pull/138.patch","issue_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/138","number":138,"state":"open","locked":false,"title":"Rewrite observer system","user":{"login":"basine","id":1119259,"avatar_url":"https://avatars.githubusercontent.com/u/1119259?v=3","gravatar_id":"","url":"https://api.github.com/users/basine","html_url":"https://github.com/basine","followers_url":"https://api.github.com/users/basine/followers","following_url":"https://api.github.com/users/basine/following{/other_user}","gists_url":"https://api.github.com/users/basine/gists{/gist_id}","starred_url":"https://api.github.com/users/basine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basine/subscriptions","organizations_url":"https://api.github.com/users/basine/orgs","repos_url":"https://api.github.com/users/basine/repos","events_url":"https://api.github.com/users/basine/events{/privacy}","received_events_url":"https://api.github.com/users/basine/received_events","type":"User","site_admin":false},"body":"**In this PR**\r\n\r\n**Note**: There are still a lot of TODOs (search for TODO Sabine) in this PR. So this is still WIP. Some of them are open questions, feel free to add your comments to those questions.\r\n\r\nOur observer system is currently very slow due to creating snapshots for almost every object in the object graph. This leads to long startup times and probably also high energy consumption. Instead of keeping snapshots of all objects, we are only creating snapshots of changed objects before the merge by getting the updated objects from the `NSManagedObjectContextDidSaveNotification` of the other context and creating snapshots for them on the other context.\r\n\r\nFor every ManagedObject we map the `keysPathsForValuesAffectedByValueForKey` of keys we want to observe in a `DependencyKeystore` object.\r\n\r\nEvery time an object changes on the context, we get the changedKeys, check for changes in dependent objects using the mapped keys in the `DependencyKeystore` and then merge all the changes we found with previous changes. When the contexts are merged or the uiContext saves, we calculate changeInfos and then post them using NSNotificationCenter.\r\n\r\nThere are serval additional objects:\r\n`VoicechannelObserverCenter`\r\n`ConversationListObserverCenter`\r\n`MessageWindowObserverCenter`\r\n`SearchUserObserverCenter`\r\nwhich are forwarded the changes calculated during the save and update their lists or snapshots accordingly.\r\n\r\n\r\n**NotificationDispatcher**\r\n* Creates Snapshots of objects before merge (via SnapshotCenter)\r\n* Processes NSManagedObjectsDidChangeNotification getting either changedValues() or using the snapshot to retrieve changes if the object is faulted\r\n* Calculates changes in other objects due to insert / deletes / updates\r\n * Uses reverse map of `keyPathsForValueAffectingValueForKey`\r\n * Checks if related objects depend on changes using “manual” relationship mappings in `SideEffectSources`:\r\nE.g. a change of a user’s name has an effect on it’s conversations’ displayNames, therefore it would add the conversations and all keys that are affected by “connection.to.name” or “otherActiveParticipants.name”\r\nSince displayName is a computed property, this change would not be noticed just inspecting changedValues or the snapshot\r\n* When contextDidSave or contextDidMerge is called:\r\n * It creates ObjectChangeInfos from the collected changes \r\n * It fires an NSNotification whose userInfo contains these changeInfos (subscribers subscribe to the NotificationCenter directly which maps the callback in its callback block)\r\n * It forwards those changeInfos to other changeInfoConsumers who were added\r\n* When the app enters the background\r\n * It stops processing and forwarding changes\r\n * It resets all current changes and clears all snapshots\r\n * It notifies all changeInfoConsumers that it went to the background\r\n* When the app enters the foreground:\r\n * It starts forwarding the changes again\r\n * It notifies all changeInfoConsumers that it went to the foreground\r\n* In addition:\r\n * Calculates changes due to userImage changes or displayName changes\t\r\n * It notifies about new unread / unsent messages\r\n * It notifies about non-CoreData changes via a notification call\r\n\r\n**ConversationListObserverCenter**\r\n* When a list is created, the list is added to the center (through a call in it’s init) and a snapshot created\r\n* The snapshots are updated when a conversation is inserted / deleted / updated\t\r\n* When the app enters the background the list snapshots are reset\r\n* When the app enters the foreground:\r\n * The UI calls a method to recreate all conversation lists which calls the center\r\n * The list snapshots are recreated\r\n\r\n\r\n\r\n\r\n**MessageWindowObserverCenter**\r\n* When a window is created, a snapshot is created - there can only be one window at a time therefore there will only be one snapshot at a time\r\n* The snapshots are updated \r\n * when a message is inserted / deleted / updated\r\n * when a user is updated whose message are contained in window\r\n* When the app enters the background we do nothing\r\n* When the app enters the foreground the window is recalculated and the change notification sent\r\n\r\n**SearchuserObserverCenter**\r\n* When the searchDirectory returns new searchUsers, snapshots for those searchusers are created when calling `searchDirectoryDidUpdate`\r\n* When the searchDirectory is tornDown, the observer center snapshots are reset\r\n* The snapshots are updated when:\r\n * The searchUser’s user changes and we receive a UserChangeInfo\r\n * The method `notifyUpdatedSearchUser` is called when the searchUser’s image changes\r\n* When the app enters the background we do nothing\r\n* When the app enters the foreground we do nothing\r\n\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2017-01-19T11:19:20Z","updated_at":"2017-02-07T13:43:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b4a2ba75a7551505b253946eb4b674c3052f19d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/138/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/138/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/138/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/statuses/15edbb9ec9a39f541c27dbab3c1f1a65f4a3f4dc","head":{"label":"wireapp:feature/new-observer-system","ref":"feature/new-observer-system","sha":"15edbb9ec9a39f541c27dbab3c1f1a65f4a3f4dc","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":57151009,"name":"wire-ios-data-model","full_name":"wireapp/wire-ios-data-model","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios-data-model","description":"Core Data model and entity classes","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios-data-model","forks_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/deployments","created_at":"2016-04-26T18:09:28Z","updated_at":"2016-11-24T10:09:34Z","pushed_at":"2017-02-07T13:42:23Z","git_url":"git://github.com/wireapp/wire-ios-data-model.git","ssh_url":"[email protected]:wireapp/wire-ios-data-model.git","clone_url":"https://github.com/wireapp/wire-ios-data-model.git","svn_url":"https://github.com/wireapp/wire-ios-data-model","homepage":"https://wire.com","size":5325,"stargazers_count":7,"watchers_count":7,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":7,"default_branch":"develop"}},"base":{"label":"wireapp:develop","ref":"develop","sha":"a47b340e744c153784088acfc28d10b5cfef15bd","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":57151009,"name":"wire-ios-data-model","full_name":"wireapp/wire-ios-data-model","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios-data-model","description":"Core Data model and entity classes","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios-data-model","forks_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/deployments","created_at":"2016-04-26T18:09:28Z","updated_at":"2016-11-24T10:09:34Z","pushed_at":"2017-02-07T13:42:23Z","git_url":"git://github.com/wireapp/wire-ios-data-model.git","ssh_url":"[email protected]:wireapp/wire-ios-data-model.git","clone_url":"https://github.com/wireapp/wire-ios-data-model.git","svn_url":"https://github.com/wireapp/wire-ios-data-model","homepage":"https://wire.com","size":5325,"stargazers_count":7,"watchers_count":7,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/138"},"html":{"href":"https://github.com/wireapp/wire-ios-data-model/pull/138"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/138"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/138/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/138/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/138/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-ios-data-model/statuses/15edbb9ec9a39f541c27dbab3c1f1a65f4a3f4dc"}}}} | {
"id": 57151009,
"name": "wireapp/wire-ios-data-model",
"url": "https://api.github.com/repos/wireapp/wire-ios-data-model"
} | {
"id": 20773876,
"login": "wire-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20773876?",
"url": "https://api.github.com/users/wire-bot"
} | {
"id": 16047324,
"login": "wireapp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16047324?",
"url": "https://api.github.com/orgs/wireapp"
} | 2017-02-07T13:43:53 | 5280240017 | {"actor":{"display_login":"wire-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/yarnpkg/website/pulls/comments/112826741","pull_request_review_id":34172923,"id":112826741,"diff_hunk":"@@ -0,0 +1,12 @@\n+<svg version=\"1.1\" xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 58 58\">\n+ <path\n+ style=\"fill:#EFCE4A\"\n+ d=\"M46.324,52.5H1.565c-1.03,0-1.779-0.978-1.51-1.973l10.166-27.871\n+ c0.184-0.682,0.803-1.156,1.51-1.156H56.49c1.03,0,1.51,0.984,1.51,1.973L47.834,51.344C47.65,52.026,47.031,52.5,46.324,52.5z\"\n+ />\n+ <path\n+ style=\"fill:#EBBA16\"","path":"assets/detail/ico-folder.svg","position":8,"original_position":8,"commit_id":"5858f673def9bb08d2915d98327e332f59cfcf4b","original_commit_id":"5858f673def9bb08d2915d98327e332f59cfcf4b","user":{"login":"Haroenv","id":6270048,"avatar_url":"https://avatars0.githubusercontent.com/u/6270048?v=3","gravatar_id":"","url":"https://api.github.com/users/Haroenv","html_url":"https://github.com/Haroenv","followers_url":"https://api.github.com/users/Haroenv/followers","following_url":"https://api.github.com/users/Haroenv/following{/other_user}","gists_url":"https://api.github.com/users/Haroenv/gists{/gist_id}","starred_url":"https://api.github.com/users/Haroenv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Haroenv/subscriptions","organizations_url":"https://api.github.com/users/Haroenv/orgs","repos_url":"https://api.github.com/users/Haroenv/repos","events_url":"https://api.github.com/users/Haroenv/events{/privacy}","received_events_url":"https://api.github.com/users/Haroenv/received_events","type":"User","site_admin":false},"body":"The colours might not really fit here. Does @Shipow have a good idea for thzt","created_at":"2017-04-23T07:02:19Z","updated_at":"2017-04-23T07:03:46Z","html_url":"https://github.com/yarnpkg/website/pull/461#discussion_r112826741","pull_request_url":"https://api.github.com/repos/yarnpkg/website/pulls/461","_links":{"self":{"href":"https://api.github.com/repos/yarnpkg/website/pulls/comments/112826741"},"html":{"href":"https://github.com/yarnpkg/website/pull/461#discussion_r112826741"},"pull_request":{"href":"https://api.github.com/repos/yarnpkg/website/pulls/461"}}},"pull_request":{"url":"https://api.github.com/repos/yarnpkg/website/pulls/461","id":117129451,"html_url":"https://github.com/yarnpkg/website/pull/461","diff_url":"https://github.com/yarnpkg/website/pull/461.diff","patch_url":"https://github.com/yarnpkg/website/pull/461.patch","issue_url":"https://api.github.com/repos/yarnpkg/website/issues/461","number":461,"state":"open","locked":false,"title":"Add file listing to package details page","user":{"login":"Daniel15","id":91933,"avatar_url":"https://avatars1.githubusercontent.com/u/91933?v=3","gravatar_id":"","url":"https://api.github.com/users/Daniel15","html_url":"https://github.com/Daniel15","followers_url":"https://api.github.com/users/Daniel15/followers","following_url":"https://api.github.com/users/Daniel15/following{/other_user}","gists_url":"https://api.github.com/users/Daniel15/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel15/subscriptions","organizations_url":"https://api.github.com/users/Daniel15/orgs","repos_url":"https://api.github.com/users/Daniel15/repos","events_url":"https://api.github.com/users/Daniel15/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel15/received_events","type":"User","site_admin":false},"body":"Whenever I want to use a package via [unpkg](https://unpkg.com/) or a similar CDN, I end up doing `yarn add foo` locally, then inspecting the `node_modules` directory to find the name of the file to use. unpkg provide directory listings (eg. https://unpkg.com/[email protected]/), but then I have to remember to switch between the Yarn details page and unpkg.\r\n\r\nHelpfully, unpkg also offers the directory listing as JSON (eg. https://unpkg.com/[email protected]/?json). I've used this to add a directory listing feature to the Yarn package details page. This pull requests add a \"Browse Files\" link next to the \"Try in RunKit\" link. When clicked, it shows a file tree for the package:\r\n\r\n\r\n\r\nClicking any file name will open the file via unpkg.\r\n\r\nThe icons aren't very nice, they're just royalty-free icons I found online. @Haroenv - Would it be possible to get some file/folder icons in the same style as the icons in the sidebar? It'd be nice to have custom file icons for most popular file types (JS, JSON, Markdown) too.\r\n\r\ncc @Haroenv ","created_at":"2017-04-22T23:31:45Z","updated_at":"2017-04-23T07:03:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"689d32fb080423da14609a0e40cf4c4448bbcf4c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yarnpkg/website/pulls/461/commits","review_comments_url":"https://api.github.com/repos/yarnpkg/website/pulls/461/comments","review_comment_url":"https://api.github.com/repos/yarnpkg/website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarnpkg/website/issues/461/comments","statuses_url":"https://api.github.com/repos/yarnpkg/website/statuses/5858f673def9bb08d2915d98327e332f59cfcf4b","head":{"label":"Daniel15:browse","ref":"browse","sha":"5858f673def9bb08d2915d98327e332f59cfcf4b","user":{"login":"Daniel15","id":91933,"avatar_url":"https://avatars1.githubusercontent.com/u/91933?v=3","gravatar_id":"","url":"https://api.github.com/users/Daniel15","html_url":"https://github.com/Daniel15","followers_url":"https://api.github.com/users/Daniel15/followers","following_url":"https://api.github.com/users/Daniel15/following{/other_user}","gists_url":"https://api.github.com/users/Daniel15/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel15/subscriptions","organizations_url":"https://api.github.com/users/Daniel15/orgs","repos_url":"https://api.github.com/users/Daniel15/repos","events_url":"https://api.github.com/users/Daniel15/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel15/received_events","type":"User","site_admin":false},"repo":{"id":70742945,"name":"yarn-website","full_name":"Daniel15/yarn-website","owner":{"login":"Daniel15","id":91933,"avatar_url":"https://avatars1.githubusercontent.com/u/91933?v=3","gravatar_id":"","url":"https://api.github.com/users/Daniel15","html_url":"https://github.com/Daniel15","followers_url":"https://api.github.com/users/Daniel15/followers","following_url":"https://api.github.com/users/Daniel15/following{/other_user}","gists_url":"https://api.github.com/users/Daniel15/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel15/subscriptions","organizations_url":"https://api.github.com/users/Daniel15/orgs","repos_url":"https://api.github.com/users/Daniel15/repos","events_url":"https://api.github.com/users/Daniel15/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel15/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Daniel15/yarn-website","description":"Yarn package manager website","fork":true,"url":"https://api.github.com/repos/Daniel15/yarn-website","forks_url":"https://api.github.com/repos/Daniel15/yarn-website/forks","keys_url":"https://api.github.com/repos/Daniel15/yarn-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Daniel15/yarn-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Daniel15/yarn-website/teams","hooks_url":"https://api.github.com/repos/Daniel15/yarn-website/hooks","issue_events_url":"https://api.github.com/repos/Daniel15/yarn-website/issues/events{/number}","events_url":"https://api.github.com/repos/Daniel15/yarn-website/events","assignees_url":"https://api.github.com/repos/Daniel15/yarn-website/assignees{/user}","branches_url":"https://api.github.com/repos/Daniel15/yarn-website/branches{/branch}","tags_url":"https://api.github.com/repos/Daniel15/yarn-website/tags","blobs_url":"https://api.github.com/repos/Daniel15/yarn-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Daniel15/yarn-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Daniel15/yarn-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/Daniel15/yarn-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Daniel15/yarn-website/statuses/{sha}","languages_url":"https://api.github.com/repos/Daniel15/yarn-website/languages","stargazers_url":"https://api.github.com/repos/Daniel15/yarn-website/stargazers","contributors_url":"https://api.github.com/repos/Daniel15/yarn-website/contributors","subscribers_url":"https://api.github.com/repos/Daniel15/yarn-website/subscribers","subscription_url":"https://api.github.com/repos/Daniel15/yarn-website/subscription","commits_url":"https://api.github.com/repos/Daniel15/yarn-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/Daniel15/yarn-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/Daniel15/yarn-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/Daniel15/yarn-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/Daniel15/yarn-website/contents/{+path}","compare_url":"https://api.github.com/repos/Daniel15/yarn-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Daniel15/yarn-website/merges","archive_url":"https://api.github.com/repos/Daniel15/yarn-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Daniel15/yarn-website/downloads","issues_url":"https://api.github.com/repos/Daniel15/yarn-website/issues{/number}","pulls_url":"https://api.github.com/repos/Daniel15/yarn-website/pulls{/number}","milestones_url":"https://api.github.com/repos/Daniel15/yarn-website/milestones{/number}","notifications_url":"https://api.github.com/repos/Daniel15/yarn-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Daniel15/yarn-website/labels{/name}","releases_url":"https://api.github.com/repos/Daniel15/yarn-website/releases{/id}","deployments_url":"https://api.github.com/repos/Daniel15/yarn-website/deployments","created_at":"2016-10-12T21:25:27Z","updated_at":"2016-10-12T21:25:37Z","pushed_at":"2017-04-22T23:27:54Z","git_url":"git://github.com/Daniel15/yarn-website.git","ssh_url":"[email protected]:Daniel15/yarn-website.git","clone_url":"https://github.com/Daniel15/yarn-website.git","svn_url":"https://github.com/Daniel15/yarn-website","homepage":"https://yarnpkg.com","size":5593,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yarnpkg:master","ref":"master","sha":"df2f282b3e8f7ef9c341c4842199692e357ea1f5","user":{"login":"yarnpkg","id":22247014,"avatar_url":"https://avatars0.githubusercontent.com/u/22247014?v=3","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"repo":{"id":68416554,"name":"website","full_name":"yarnpkg/website","owner":{"login":"yarnpkg","id":22247014,"avatar_url":"https://avatars0.githubusercontent.com/u/22247014?v=3","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarnpkg/website","description":"Yarn package manager website","fork":false,"url":"https://api.github.com/repos/yarnpkg/website","forks_url":"https://api.github.com/repos/yarnpkg/website/forks","keys_url":"https://api.github.com/repos/yarnpkg/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarnpkg/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarnpkg/website/teams","hooks_url":"https://api.github.com/repos/yarnpkg/website/hooks","issue_events_url":"https://api.github.com/repos/yarnpkg/website/issues/events{/number}","events_url":"https://api.github.com/repos/yarnpkg/website/events","assignees_url":"https://api.github.com/repos/yarnpkg/website/assignees{/user}","branches_url":"https://api.github.com/repos/yarnpkg/website/branches{/branch}","tags_url":"https://api.github.com/repos/yarnpkg/website/tags","blobs_url":"https://api.github.com/repos/yarnpkg/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarnpkg/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarnpkg/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarnpkg/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarnpkg/website/statuses/{sha}","languages_url":"https://api.github.com/repos/yarnpkg/website/languages","stargazers_url":"https://api.github.com/repos/yarnpkg/website/stargazers","contributors_url":"https://api.github.com/repos/yarnpkg/website/contributors","subscribers_url":"https://api.github.com/repos/yarnpkg/website/subscribers","subscription_url":"https://api.github.com/repos/yarnpkg/website/subscription","commits_url":"https://api.github.com/repos/yarnpkg/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarnpkg/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarnpkg/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarnpkg/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarnpkg/website/contents/{+path}","compare_url":"https://api.github.com/repos/yarnpkg/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarnpkg/website/merges","archive_url":"https://api.github.com/repos/yarnpkg/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarnpkg/website/downloads","issues_url":"https://api.github.com/repos/yarnpkg/website/issues{/number}","pulls_url":"https://api.github.com/repos/yarnpkg/website/pulls{/number}","milestones_url":"https://api.github.com/repos/yarnpkg/website/milestones{/number}","notifications_url":"https://api.github.com/repos/yarnpkg/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarnpkg/website/labels{/name}","releases_url":"https://api.github.com/repos/yarnpkg/website/releases{/id}","deployments_url":"https://api.github.com/repos/yarnpkg/website/deployments","created_at":"2016-09-16T21:44:40Z","updated_at":"2017-04-02T15:18:16Z","pushed_at":"2017-04-22T23:31:45Z","git_url":"git://github.com/yarnpkg/website.git","ssh_url":"[email protected]:yarnpkg/website.git","clone_url":"https://github.com/yarnpkg/website.git","svn_url":"https://github.com/yarnpkg/website","homepage":"https://yarnpkg.com","size":5584,"stargazers_count":97,"watchers_count":97,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":233,"mirror_url":null,"open_issues_count":55,"forks":233,"open_issues":55,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yarnpkg/website/pulls/461"},"html":{"href":"https://github.com/yarnpkg/website/pull/461"},"issue":{"href":"https://api.github.com/repos/yarnpkg/website/issues/461"},"comments":{"href":"https://api.github.com/repos/yarnpkg/website/issues/461/comments"},"review_comments":{"href":"https://api.github.com/repos/yarnpkg/website/pulls/461/comments"},"review_comment":{"href":"https://api.github.com/repos/yarnpkg/website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarnpkg/website/pulls/461/commits"},"statuses":{"href":"https://api.github.com/repos/yarnpkg/website/statuses/5858f673def9bb08d2915d98327e332f59cfcf4b"}}}} | {
"id": 68416554,
"name": "yarnpkg/website",
"url": "https://api.github.com/repos/yarnpkg/website"
} | {
"id": 6270048,
"login": "Haroenv",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6270048?",
"url": "https://api.github.com/users/Haroenv"
} | {
"id": 22247014,
"login": "yarnpkg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22247014?",
"url": "https://api.github.com/orgs/yarnpkg"
} | 2017-04-23T07:02:19 | 5738670686 | {"actor":{"display_login":"Haroenv"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments/125110746","pull_request_review_id":47473587,"id":125110746,"diff_hunk":"@@ -76,15 +76,15 @@ export default class NpmRegistry extends Registry {\n const registry = this.getRegistry(packageName || pathname);\n const requestUrl = url.resolve(registry, pathname);\n const alwaysAuth = this.getRegistryOrGlobalOption(registry, 'always-auth');\n- const customHostSuffix = this.getRegistryOrGlobalOption(registry, 'custom-host-suffix');\n \n const headers = Object.assign(\n {\n Accept: 'application/vnd.npm.install-v1+json; q=1.0, application/json; q=0.8, */*',\n },\n opts.headers,\n );\n- if (this.token || (alwaysAuth && isRequestToRegistry(requestUrl, registry, customHostSuffix))) {\n+\n+ if (alwaysAuth || (packageName || pathname)[0] === `@`) {","path":"src/registries/npm-registry.js","position":14,"original_position":14,"commit_id":"1f0a89da9f45ddf977319ba1bc29895ad42f8d1c","original_commit_id":"1f0a89da9f45ddf977319ba1bc29895ad42f8d1c","user":{"login":"bestander","id":2121048,"avatar_url":"https://avatars0.githubusercontent.com/u/2121048?v=3","gravatar_id":"","url":"https://api.github.com/users/bestander","html_url":"https://github.com/bestander","followers_url":"https://api.github.com/users/bestander/followers","following_url":"https://api.github.com/users/bestander/following{/other_user}","gists_url":"https://api.github.com/users/bestander/gists{/gist_id}","starred_url":"https://api.github.com/users/bestander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bestander/subscriptions","organizations_url":"https://api.github.com/users/bestander/orgs","repos_url":"https://api.github.com/users/bestander/repos","events_url":"https://api.github.com/users/bestander/events{/privacy}","received_events_url":"https://api.github.com/users/bestander/received_events","type":"User","site_admin":false},"body":"I don't understand the reason for this change","created_at":"2017-06-30T19:10:49Z","updated_at":"2017-06-30T19:10:50Z","html_url":"https://github.com/yarnpkg/yarn/pull/3774#discussion_r125110746","pull_request_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/3774","_links":{"self":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments/125110746"},"html":{"href":"https://github.com/yarnpkg/yarn/pull/3774#discussion_r125110746"},"pull_request":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/3774"}}},"pull_request":{"url":"https://api.github.com/repos/yarnpkg/yarn/pulls/3774","id":128345965,"html_url":"https://github.com/yarnpkg/yarn/pull/3774","diff_url":"https://github.com/yarnpkg/yarn/pull/3774.diff","patch_url":"https://github.com/yarnpkg/yarn/pull/3774.patch","issue_url":"https://api.github.com/repos/yarnpkg/yarn/issues/3774","number":3774,"state":"open","locked":false,"title":"Fixes npm auth","user":{"login":"arcanis","id":1037931,"avatar_url":"https://avatars1.githubusercontent.com/u/1037931?v=3","gravatar_id":"","url":"https://api.github.com/users/arcanis","html_url":"https://github.com/arcanis","followers_url":"https://api.github.com/users/arcanis/followers","following_url":"https://api.github.com/users/arcanis/following{/other_user}","gists_url":"https://api.github.com/users/arcanis/gists{/gist_id}","starred_url":"https://api.github.com/users/arcanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcanis/subscriptions","organizations_url":"https://api.github.com/users/arcanis/orgs","repos_url":"https://api.github.com/users/arcanis/repos","events_url":"https://api.github.com/users/arcanis/events{/privacy}","received_events_url":"https://api.github.com/users/arcanis/received_events","type":"User","site_admin":false},"body":"This commit should fix #3765. I'm not completely satisfied with hardcoding our registry, maybe that could extended at a later point with an option to \"inherit\" the auth token from npm. Not sure it would be useful, tho.","created_at":"2017-06-30T11:00:06Z","updated_at":"2017-06-30T19:10:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"991c695202e60379455012d3e4393931898f7dc7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"BYK","id":126780,"avatar_url":"https://avatars0.githubusercontent.com/u/126780?v=3","gravatar_id":"","url":"https://api.github.com/users/BYK","html_url":"https://github.com/BYK","followers_url":"https://api.github.com/users/BYK/followers","following_url":"https://api.github.com/users/BYK/following{/other_user}","gists_url":"https://api.github.com/users/BYK/gists{/gist_id}","starred_url":"https://api.github.com/users/BYK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BYK/subscriptions","organizations_url":"https://api.github.com/users/BYK/orgs","repos_url":"https://api.github.com/users/BYK/repos","events_url":"https://api.github.com/users/BYK/events{/privacy}","received_events_url":"https://api.github.com/users/BYK/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/3774/commits","review_comments_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/3774/comments","review_comment_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarnpkg/yarn/issues/3774/comments","statuses_url":"https://api.github.com/repos/yarnpkg/yarn/statuses/1f0a89da9f45ddf977319ba1bc29895ad42f8d1c","head":{"label":"arcanis:auth-fix","ref":"auth-fix","sha":"1f0a89da9f45ddf977319ba1bc29895ad42f8d1c","user":{"login":"arcanis","id":1037931,"avatar_url":"https://avatars1.githubusercontent.com/u/1037931?v=3","gravatar_id":"","url":"https://api.github.com/users/arcanis","html_url":"https://github.com/arcanis","followers_url":"https://api.github.com/users/arcanis/followers","following_url":"https://api.github.com/users/arcanis/following{/other_user}","gists_url":"https://api.github.com/users/arcanis/gists{/gist_id}","starred_url":"https://api.github.com/users/arcanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcanis/subscriptions","organizations_url":"https://api.github.com/users/arcanis/orgs","repos_url":"https://api.github.com/users/arcanis/repos","events_url":"https://api.github.com/users/arcanis/events{/privacy}","received_events_url":"https://api.github.com/users/arcanis/received_events","type":"User","site_admin":false},"repo":{"id":82685695,"name":"yarn","full_name":"arcanis/yarn","owner":{"login":"arcanis","id":1037931,"avatar_url":"https://avatars1.githubusercontent.com/u/1037931?v=3","gravatar_id":"","url":"https://api.github.com/users/arcanis","html_url":"https://github.com/arcanis","followers_url":"https://api.github.com/users/arcanis/followers","following_url":"https://api.github.com/users/arcanis/following{/other_user}","gists_url":"https://api.github.com/users/arcanis/gists{/gist_id}","starred_url":"https://api.github.com/users/arcanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcanis/subscriptions","organizations_url":"https://api.github.com/users/arcanis/orgs","repos_url":"https://api.github.com/users/arcanis/repos","events_url":"https://api.github.com/users/arcanis/events{/privacy}","received_events_url":"https://api.github.com/users/arcanis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arcanis/yarn","description":"📦🐈 Fast, reliable, and secure dependency management.","fork":true,"url":"https://api.github.com/repos/arcanis/yarn","forks_url":"https://api.github.com/repos/arcanis/yarn/forks","keys_url":"https://api.github.com/repos/arcanis/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arcanis/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arcanis/yarn/teams","hooks_url":"https://api.github.com/repos/arcanis/yarn/hooks","issue_events_url":"https://api.github.com/repos/arcanis/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/arcanis/yarn/events","assignees_url":"https://api.github.com/repos/arcanis/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/arcanis/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/arcanis/yarn/tags","blobs_url":"https://api.github.com/repos/arcanis/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arcanis/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arcanis/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/arcanis/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arcanis/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/arcanis/yarn/languages","stargazers_url":"https://api.github.com/repos/arcanis/yarn/stargazers","contributors_url":"https://api.github.com/repos/arcanis/yarn/contributors","subscribers_url":"https://api.github.com/repos/arcanis/yarn/subscribers","subscription_url":"https://api.github.com/repos/arcanis/yarn/subscription","commits_url":"https://api.github.com/repos/arcanis/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/arcanis/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/arcanis/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/arcanis/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/arcanis/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/arcanis/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arcanis/yarn/merges","archive_url":"https://api.github.com/repos/arcanis/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arcanis/yarn/downloads","issues_url":"https://api.github.com/repos/arcanis/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/arcanis/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/arcanis/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/arcanis/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arcanis/yarn/labels{/name}","releases_url":"https://api.github.com/repos/arcanis/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/arcanis/yarn/deployments","created_at":"2017-02-21T13:56:57Z","updated_at":"2017-02-21T13:57:01Z","pushed_at":"2017-06-30T11:14:14Z","git_url":"git://github.com/arcanis/yarn.git","ssh_url":"[email protected]:arcanis/yarn.git","clone_url":"https://github.com/arcanis/yarn.git","svn_url":"https://github.com/arcanis/yarn","homepage":"https://yarnpkg.com","size":111374,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yarnpkg:master","ref":"master","sha":"f5364940b60adb022352e229aa17a8a952128af0","user":{"login":"yarnpkg","id":22247014,"avatar_url":"https://avatars0.githubusercontent.com/u/22247014?v=3","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"repo":{"id":49970642,"name":"yarn","full_name":"yarnpkg/yarn","owner":{"login":"yarnpkg","id":22247014,"avatar_url":"https://avatars0.githubusercontent.com/u/22247014?v=3","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarnpkg/yarn","description":"📦🐈 Fast, reliable, and secure dependency management.","fork":false,"url":"https://api.github.com/repos/yarnpkg/yarn","forks_url":"https://api.github.com/repos/yarnpkg/yarn/forks","keys_url":"https://api.github.com/repos/yarnpkg/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarnpkg/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarnpkg/yarn/teams","hooks_url":"https://api.github.com/repos/yarnpkg/yarn/hooks","issue_events_url":"https://api.github.com/repos/yarnpkg/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/yarnpkg/yarn/events","assignees_url":"https://api.github.com/repos/yarnpkg/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/yarnpkg/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/yarnpkg/yarn/tags","blobs_url":"https://api.github.com/repos/yarnpkg/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarnpkg/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarnpkg/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarnpkg/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarnpkg/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/yarnpkg/yarn/languages","stargazers_url":"https://api.github.com/repos/yarnpkg/yarn/stargazers","contributors_url":"https://api.github.com/repos/yarnpkg/yarn/contributors","subscribers_url":"https://api.github.com/repos/yarnpkg/yarn/subscribers","subscription_url":"https://api.github.com/repos/yarnpkg/yarn/subscription","commits_url":"https://api.github.com/repos/yarnpkg/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarnpkg/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarnpkg/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarnpkg/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarnpkg/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/yarnpkg/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarnpkg/yarn/merges","archive_url":"https://api.github.com/repos/yarnpkg/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarnpkg/yarn/downloads","issues_url":"https://api.github.com/repos/yarnpkg/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/yarnpkg/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/yarnpkg/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/yarnpkg/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarnpkg/yarn/labels{/name}","releases_url":"https://api.github.com/repos/yarnpkg/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/yarnpkg/yarn/deployments","created_at":"2016-01-19T17:39:16Z","updated_at":"2017-06-30T16:57:46Z","pushed_at":"2017-06-30T18:05:45Z","git_url":"git://github.com/yarnpkg/yarn.git","ssh_url":"[email protected]:yarnpkg/yarn.git","clone_url":"https://github.com/yarnpkg/yarn.git","svn_url":"https://github.com/yarnpkg/yarn","homepage":"https://yarnpkg.com","size":111163,"stargazers_count":26026,"watchers_count":26026,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1255,"mirror_url":null,"open_issues_count":742,"forks":1255,"open_issues":742,"watchers":26026,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/3774"},"html":{"href":"https://github.com/yarnpkg/yarn/pull/3774"},"issue":{"href":"https://api.github.com/repos/yarnpkg/yarn/issues/3774"},"comments":{"href":"https://api.github.com/repos/yarnpkg/yarn/issues/3774/comments"},"review_comments":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/3774/comments"},"review_comment":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/3774/commits"},"statuses":{"href":"https://api.github.com/repos/yarnpkg/yarn/statuses/1f0a89da9f45ddf977319ba1bc29895ad42f8d1c"}}}} | {
"id": 49970642,
"name": "yarnpkg/yarn",
"url": "https://api.github.com/repos/yarnpkg/yarn"
} | {
"id": 2121048,
"login": "bestander",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2121048?",
"url": "https://api.github.com/users/bestander"
} | {
"id": 22247014,
"login": "yarnpkg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22247014?",
"url": "https://api.github.com/orgs/yarnpkg"
} | 2017-06-30T19:10:49 | 6173747396 | {"actor":{"display_login":"bestander"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/youtube/vitess/pulls/comments/106059767","pull_request_review_id":26965701,"id":106059767,"diff_hunk":"@@ -29,6 +29,11 @@ func analyzeUpdate(upd *sqlparser.Update, getTable TableGetter) (plan *ExecPlan,\n \t\treturn nil, err\n \t}\n \n+\t// Store the WHERE clause as string for the transaction serializer.\n+\tbuf := sqlparser.NewTrackedBuffer(nil)\n+\tbuf.Myprintf(\"%v\", upd.Where)","path":"go/vt/tabletserver/planbuilder/dml.go","position":null,"original_position":6,"commit_id":"54cc003339de1ad330116cb141033a68e385c0de","original_commit_id":"5ddebb917306efeede49431f68abf84cc3ac719e","user":{"login":"michael-berlin","id":3919251,"avatar_url":"https://avatars1.githubusercontent.com/u/3919251?v=3","gravatar_id":"","url":"https://api.github.com/users/michael-berlin","html_url":"https://github.com/michael-berlin","followers_url":"https://api.github.com/users/michael-berlin/followers","following_url":"https://api.github.com/users/michael-berlin/following{/other_user}","gists_url":"https://api.github.com/users/michael-berlin/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-berlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-berlin/subscriptions","organizations_url":"https://api.github.com/users/michael-berlin/orgs","repos_url":"https://api.github.com/users/michael-berlin/repos","events_url":"https://api.github.com/users/michael-berlin/events{/privacy}","received_events_url":"https://api.github.com/users/michael-berlin/received_events","type":"User","site_admin":false},"body":"Looks very good and much simpler. Thanks! :)\r\n\r\nThe semaphore basically allowed you to fold the two layers `TxSerializer` and `queue` into one and that makes the locking much easier to reason about. Additionally, it provides a lot of thread safe functionality for free which must not be implemented again.\r\n\r\nLet me look into the fairness of this tomorrow and then I'll backport it into this PR. :)","created_at":"2017-03-15T00:17:09Z","updated_at":"2017-03-15T00:17:09Z","html_url":"https://github.com/youtube/vitess/pull/2609#discussion_r106059767","pull_request_url":"https://api.github.com/repos/youtube/vitess/pulls/2609","_links":{"self":{"href":"https://api.github.com/repos/youtube/vitess/pulls/comments/106059767"},"html":{"href":"https://github.com/youtube/vitess/pull/2609#discussion_r106059767"},"pull_request":{"href":"https://api.github.com/repos/youtube/vitess/pulls/2609"}}},"pull_request":{"url":"https://api.github.com/repos/youtube/vitess/pulls/2609","id":108494167,"html_url":"https://github.com/youtube/vitess/pull/2609","diff_url":"https://github.com/youtube/vitess/pull/2609.diff","patch_url":"https://github.com/youtube/vitess/pull/2609.patch","issue_url":"https://api.github.com/repos/youtube/vitess/issues/2609","number":2609,"state":"open","locked":false,"title":"tabletserver: Protect Transaction Pool against hot rows.","user":{"login":"michael-berlin","id":3919251,"avatar_url":"https://avatars1.githubusercontent.com/u/3919251?v=3","gravatar_id":"","url":"https://api.github.com/users/michael-berlin","html_url":"https://github.com/michael-berlin","followers_url":"https://api.github.com/users/michael-berlin/followers","following_url":"https://api.github.com/users/michael-berlin/following{/other_user}","gists_url":"https://api.github.com/users/michael-berlin/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-berlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-berlin/subscriptions","organizations_url":"https://api.github.com/users/michael-berlin/orgs","repos_url":"https://api.github.com/users/michael-berlin/repos","events_url":"https://api.github.com/users/michael-berlin/events{/privacy}","received_events_url":"https://api.github.com/users/michael-berlin/received_events","type":"User","site_admin":false},"body":"During BeginExecute() do not start a second transaction if another BeginExecute() for the same row is already in progress. This avoids that updates targeted for a single row can consume all transaction pool slots.\r\n\r\nNote that the serialization is bound to the lifetime of the BeginExecute() call and not to the lifetime of the transaction. This made the implementation simpler since no additional plumbing was required. Due to the additional MySQL locking, this should result into two transaction pool slots per row at most. (One pending on COMMIT, one waiting for MySQL in BEGIN+EXECUTE.) If this is not effective enough, we will have to revise this decision.\r\n\r\nThis change reuses the Consolidator object (but it does not set and reuse the \"Result\" field of the Consolidator.)\r\n\r\nOther change:\r\n- Extended fakesqldb to run a callback before it responds to MySQL. This is required to properly synchronize the concurrent transactions. Without, they may not race and get serialized.","created_at":"2017-03-01T09:05:02Z","updated_at":"2017-03-15T00:17:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca89c2738a475ec7ff758df45d780dc41d00051d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/youtube/vitess/pulls/2609/commits","review_comments_url":"https://api.github.com/repos/youtube/vitess/pulls/2609/comments","review_comment_url":"https://api.github.com/repos/youtube/vitess/pulls/comments{/number}","comments_url":"https://api.github.com/repos/youtube/vitess/issues/2609/comments","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/54cc003339de1ad330116cb141033a68e385c0de","head":{"label":"michael-berlin:tx_consolidator","ref":"tx_consolidator","sha":"54cc003339de1ad330116cb141033a68e385c0de","user":{"login":"michael-berlin","id":3919251,"avatar_url":"https://avatars1.githubusercontent.com/u/3919251?v=3","gravatar_id":"","url":"https://api.github.com/users/michael-berlin","html_url":"https://github.com/michael-berlin","followers_url":"https://api.github.com/users/michael-berlin/followers","following_url":"https://api.github.com/users/michael-berlin/following{/other_user}","gists_url":"https://api.github.com/users/michael-berlin/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-berlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-berlin/subscriptions","organizations_url":"https://api.github.com/users/michael-berlin/orgs","repos_url":"https://api.github.com/users/michael-berlin/repos","events_url":"https://api.github.com/users/michael-berlin/events{/privacy}","received_events_url":"https://api.github.com/users/michael-berlin/received_events","type":"User","site_admin":false},"repo":{"id":30728262,"name":"vitess","full_name":"michael-berlin/vitess","owner":{"login":"michael-berlin","id":3919251,"avatar_url":"https://avatars1.githubusercontent.com/u/3919251?v=3","gravatar_id":"","url":"https://api.github.com/users/michael-berlin","html_url":"https://github.com/michael-berlin","followers_url":"https://api.github.com/users/michael-berlin/followers","following_url":"https://api.github.com/users/michael-berlin/following{/other_user}","gists_url":"https://api.github.com/users/michael-berlin/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-berlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-berlin/subscriptions","organizations_url":"https://api.github.com/users/michael-berlin/orgs","repos_url":"https://api.github.com/users/michael-berlin/repos","events_url":"https://api.github.com/users/michael-berlin/events{/privacy}","received_events_url":"https://api.github.com/users/michael-berlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michael-berlin/vitess","description":"vitess provides servers and tools which facilitate scaling of MySQL databases for large scale web services.","fork":true,"url":"https://api.github.com/repos/michael-berlin/vitess","forks_url":"https://api.github.com/repos/michael-berlin/vitess/forks","keys_url":"https://api.github.com/repos/michael-berlin/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michael-berlin/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michael-berlin/vitess/teams","hooks_url":"https://api.github.com/repos/michael-berlin/vitess/hooks","issue_events_url":"https://api.github.com/repos/michael-berlin/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/michael-berlin/vitess/events","assignees_url":"https://api.github.com/repos/michael-berlin/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/michael-berlin/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/michael-berlin/vitess/tags","blobs_url":"https://api.github.com/repos/michael-berlin/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michael-berlin/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michael-berlin/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/michael-berlin/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michael-berlin/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/michael-berlin/vitess/languages","stargazers_url":"https://api.github.com/repos/michael-berlin/vitess/stargazers","contributors_url":"https://api.github.com/repos/michael-berlin/vitess/contributors","subscribers_url":"https://api.github.com/repos/michael-berlin/vitess/subscribers","subscription_url":"https://api.github.com/repos/michael-berlin/vitess/subscription","commits_url":"https://api.github.com/repos/michael-berlin/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/michael-berlin/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/michael-berlin/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/michael-berlin/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/michael-berlin/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/michael-berlin/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michael-berlin/vitess/merges","archive_url":"https://api.github.com/repos/michael-berlin/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michael-berlin/vitess/downloads","issues_url":"https://api.github.com/repos/michael-berlin/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/michael-berlin/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/michael-berlin/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/michael-berlin/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michael-berlin/vitess/labels{/name}","releases_url":"https://api.github.com/repos/michael-berlin/vitess/releases{/id}","deployments_url":"https://api.github.com/repos/michael-berlin/vitess/deployments","created_at":"2015-02-12T22:43:14Z","updated_at":"2015-02-12T22:43:17Z","pushed_at":"2017-03-14T18:13:08Z","git_url":"git://github.com/michael-berlin/vitess.git","ssh_url":"[email protected]:michael-berlin/vitess.git","clone_url":"https://github.com/michael-berlin/vitess.git","svn_url":"https://github.com/michael-berlin/vitess","homepage":null,"size":80181,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"youtube:master","ref":"master","sha":"0e4edf39c85b24fda16f167f1e27a9c80d672d12","user":{"login":"youtube","id":4052902,"avatar_url":"https://avatars3.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"repo":{"id":11008207,"name":"vitess","full_name":"youtube/vitess","owner":{"login":"youtube","id":4052902,"avatar_url":"https://avatars3.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/youtube/vitess","description":"Vitess is a database clustering system for horizontal scaling of MySQL.","fork":false,"url":"https://api.github.com/repos/youtube/vitess","forks_url":"https://api.github.com/repos/youtube/vitess/forks","keys_url":"https://api.github.com/repos/youtube/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/youtube/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/youtube/vitess/teams","hooks_url":"https://api.github.com/repos/youtube/vitess/hooks","issue_events_url":"https://api.github.com/repos/youtube/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/youtube/vitess/events","assignees_url":"https://api.github.com/repos/youtube/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/youtube/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/youtube/vitess/tags","blobs_url":"https://api.github.com/repos/youtube/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/youtube/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/youtube/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/youtube/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/youtube/vitess/languages","stargazers_url":"https://api.github.com/repos/youtube/vitess/stargazers","contributors_url":"https://api.github.com/repos/youtube/vitess/contributors","subscribers_url":"https://api.github.com/repos/youtube/vitess/subscribers","subscription_url":"https://api.github.com/repos/youtube/vitess/subscription","commits_url":"https://api.github.com/repos/youtube/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/youtube/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/youtube/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/youtube/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/youtube/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/youtube/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/youtube/vitess/merges","archive_url":"https://api.github.com/repos/youtube/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/youtube/vitess/downloads","issues_url":"https://api.github.com/repos/youtube/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/youtube/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/youtube/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/youtube/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/youtube/vitess/labels{/name}","releases_url":"https://api.github.com/repos/youtube/vitess/releases{/id}","deployments_url":"https://api.github.com/repos/youtube/vitess/deployments","created_at":"2013-06-27T21:20:28Z","updated_at":"2017-03-14T16:52:25Z","pushed_at":"2017-03-14T23:55:14Z","git_url":"git://github.com/youtube/vitess.git","ssh_url":"[email protected]:youtube/vitess.git","clone_url":"https://github.com/youtube/vitess.git","svn_url":"https://github.com/youtube/vitess","homepage":"http://vitess.io","size":80643,"stargazers_count":4392,"watchers_count":4392,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":577,"mirror_url":null,"open_issues_count":60,"forks":577,"open_issues":60,"watchers":4392,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/youtube/vitess/pulls/2609"},"html":{"href":"https://github.com/youtube/vitess/pull/2609"},"issue":{"href":"https://api.github.com/repos/youtube/vitess/issues/2609"},"comments":{"href":"https://api.github.com/repos/youtube/vitess/issues/2609/comments"},"review_comments":{"href":"https://api.github.com/repos/youtube/vitess/pulls/2609/comments"},"review_comment":{"href":"https://api.github.com/repos/youtube/vitess/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/youtube/vitess/pulls/2609/commits"},"statuses":{"href":"https://api.github.com/repos/youtube/vitess/statuses/54cc003339de1ad330116cb141033a68e385c0de"}}}} | {
"id": 11008207,
"name": "youtube/vitess",
"url": "https://api.github.com/repos/youtube/vitess"
} | {
"id": 3919251,
"login": "michael-berlin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3919251?",
"url": "https://api.github.com/users/michael-berlin"
} | {
"id": 4052902,
"login": "youtube",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4052902?",
"url": "https://api.github.com/orgs/youtube"
} | 2017-03-15T00:17:09 | 5494572095 | {"actor":{"display_login":"michael-berlin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/zalando/nakadi/pulls/comments/116919379","pull_request_review_id":38579153,"id":116919379,"diff_hunk":"@@ -252,7 +252,7 @@ public void whenGetEventsWithUknownTopicThenTopicNotFound() {\n .then()\n .statusCode(HttpStatus.NOT_FOUND.value())\n .and()\n- .contentType(equalTo(\"application/problem+json;charset=UTF-8\"))","path":"src/acceptance-test/java/org/zalando/nakadi/webservice/EventStreamReadingAT.java","position":4,"original_position":4,"commit_id":"decb63f6c7f354b48a756894929c569f1af6a5cd","original_commit_id":"decb63f6c7f354b48a756894929c569f1af6a5cd","user":{"login":"adyach","id":4863810,"avatar_url":"https://avatars1.githubusercontent.com/u/4863810?v=3","gravatar_id":"","url":"https://api.github.com/users/adyach","html_url":"https://github.com/adyach","followers_url":"https://api.github.com/users/adyach/followers","following_url":"https://api.github.com/users/adyach/following{/other_user}","gists_url":"https://api.github.com/users/adyach/gists{/gist_id}","starred_url":"https://api.github.com/users/adyach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adyach/subscriptions","organizations_url":"https://api.github.com/users/adyach/orgs","repos_url":"https://api.github.com/users/adyach/repos","events_url":"https://api.github.com/users/adyach/events{/privacy}","received_events_url":"https://api.github.com/users/adyach/received_events","type":"User","site_admin":false},"body":"Could you elaborate on that ?","created_at":"2017-05-17T06:28:22Z","updated_at":"2017-05-17T06:28:22Z","html_url":"https://github.com/zalando/nakadi/pull/653#discussion_r116919379","pull_request_url":"https://api.github.com/repos/zalando/nakadi/pulls/653","_links":{"self":{"href":"https://api.github.com/repos/zalando/nakadi/pulls/comments/116919379"},"html":{"href":"https://github.com/zalando/nakadi/pull/653#discussion_r116919379"},"pull_request":{"href":"https://api.github.com/repos/zalando/nakadi/pulls/653"}}},"pull_request":{"url":"https://api.github.com/repos/zalando/nakadi/pulls/653","id":119666380,"html_url":"https://github.com/zalando/nakadi/pull/653","diff_url":"https://github.com/zalando/nakadi/pull/653.diff","patch_url":"https://github.com/zalando/nakadi/pull/653.patch","issue_url":"https://api.github.com/repos/zalando/nakadi/issues/653","number":653,"state":"open","locked":false,"title":"Aruha 778 db timeout","user":{"login":"lmontrieux","id":203099,"avatar_url":"https://avatars3.githubusercontent.com/u/203099?v=3","gravatar_id":"","url":"https://api.github.com/users/lmontrieux","html_url":"https://github.com/lmontrieux","followers_url":"https://api.github.com/users/lmontrieux/followers","following_url":"https://api.github.com/users/lmontrieux/following{/other_user}","gists_url":"https://api.github.com/users/lmontrieux/gists{/gist_id}","starred_url":"https://api.github.com/users/lmontrieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmontrieux/subscriptions","organizations_url":"https://api.github.com/users/lmontrieux/orgs","repos_url":"https://api.github.com/users/lmontrieux/repos","events_url":"https://api.github.com/users/lmontrieux/events{/privacy}","received_events_url":"https://api.github.com/users/lmontrieux/received_events","type":"User","site_admin":false},"body":"ARUHA-778 add timeout to database connections\r\n\r\nI'm opening this PR now, so we can test and argue over (and eventually agree on) the best value for each timeout.","created_at":"2017-05-09T13:59:22Z","updated_at":"2017-05-17T06:28:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f1839a940a5e57a556848293b40c53e628f686a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/zalando/nakadi/pulls/653/commits","review_comments_url":"https://api.github.com/repos/zalando/nakadi/pulls/653/comments","review_comment_url":"https://api.github.com/repos/zalando/nakadi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando/nakadi/issues/653/comments","statuses_url":"https://api.github.com/repos/zalando/nakadi/statuses/decb63f6c7f354b48a756894929c569f1af6a5cd","head":{"label":"zalando:aruha-778-db-timeout","ref":"aruha-778-db-timeout","sha":"decb63f6c7f354b48a756894929c569f1af6a5cd","user":{"login":"zalando","id":1564818,"avatar_url":"https://avatars3.githubusercontent.com/u/1564818?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"repo":{"id":44234368,"name":"nakadi","full_name":"zalando/nakadi","owner":{"login":"zalando","id":1564818,"avatar_url":"https://avatars3.githubusercontent.com/u/1564818?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando/nakadi","description":"A distributed event bus that implements a RESTful API abstraction instead of Kafka-like queues","fork":false,"url":"https://api.github.com/repos/zalando/nakadi","forks_url":"https://api.github.com/repos/zalando/nakadi/forks","keys_url":"https://api.github.com/repos/zalando/nakadi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando/nakadi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando/nakadi/teams","hooks_url":"https://api.github.com/repos/zalando/nakadi/hooks","issue_events_url":"https://api.github.com/repos/zalando/nakadi/issues/events{/number}","events_url":"https://api.github.com/repos/zalando/nakadi/events","assignees_url":"https://api.github.com/repos/zalando/nakadi/assignees{/user}","branches_url":"https://api.github.com/repos/zalando/nakadi/branches{/branch}","tags_url":"https://api.github.com/repos/zalando/nakadi/tags","blobs_url":"https://api.github.com/repos/zalando/nakadi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando/nakadi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando/nakadi/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando/nakadi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando/nakadi/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando/nakadi/languages","stargazers_url":"https://api.github.com/repos/zalando/nakadi/stargazers","contributors_url":"https://api.github.com/repos/zalando/nakadi/contributors","subscribers_url":"https://api.github.com/repos/zalando/nakadi/subscribers","subscription_url":"https://api.github.com/repos/zalando/nakadi/subscription","commits_url":"https://api.github.com/repos/zalando/nakadi/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando/nakadi/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando/nakadi/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando/nakadi/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando/nakadi/contents/{+path}","compare_url":"https://api.github.com/repos/zalando/nakadi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando/nakadi/merges","archive_url":"https://api.github.com/repos/zalando/nakadi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando/nakadi/downloads","issues_url":"https://api.github.com/repos/zalando/nakadi/issues{/number}","pulls_url":"https://api.github.com/repos/zalando/nakadi/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando/nakadi/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando/nakadi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando/nakadi/labels{/name}","releases_url":"https://api.github.com/repos/zalando/nakadi/releases{/id}","deployments_url":"https://api.github.com/repos/zalando/nakadi/deployments","created_at":"2015-10-14T08:30:17Z","updated_at":"2017-05-14T12:25:28Z","pushed_at":"2017-05-16T15:17:25Z","git_url":"git://github.com/zalando/nakadi.git","ssh_url":"[email protected]:zalando/nakadi.git","clone_url":"https://github.com/zalando/nakadi.git","svn_url":"https://github.com/zalando/nakadi","homepage":"","size":6007,"stargazers_count":135,"watchers_count":135,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":46,"forks":47,"open_issues":46,"watchers":135,"default_branch":"master"}},"base":{"label":"zalando:master","ref":"master","sha":"f19b06d38353d9286c2f7a21ec839de44ba2f792","user":{"login":"zalando","id":1564818,"avatar_url":"https://avatars3.githubusercontent.com/u/1564818?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"repo":{"id":44234368,"name":"nakadi","full_name":"zalando/nakadi","owner":{"login":"zalando","id":1564818,"avatar_url":"https://avatars3.githubusercontent.com/u/1564818?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando/nakadi","description":"A distributed event bus that implements a RESTful API abstraction instead of Kafka-like queues","fork":false,"url":"https://api.github.com/repos/zalando/nakadi","forks_url":"https://api.github.com/repos/zalando/nakadi/forks","keys_url":"https://api.github.com/repos/zalando/nakadi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando/nakadi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando/nakadi/teams","hooks_url":"https://api.github.com/repos/zalando/nakadi/hooks","issue_events_url":"https://api.github.com/repos/zalando/nakadi/issues/events{/number}","events_url":"https://api.github.com/repos/zalando/nakadi/events","assignees_url":"https://api.github.com/repos/zalando/nakadi/assignees{/user}","branches_url":"https://api.github.com/repos/zalando/nakadi/branches{/branch}","tags_url":"https://api.github.com/repos/zalando/nakadi/tags","blobs_url":"https://api.github.com/repos/zalando/nakadi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando/nakadi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando/nakadi/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando/nakadi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando/nakadi/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando/nakadi/languages","stargazers_url":"https://api.github.com/repos/zalando/nakadi/stargazers","contributors_url":"https://api.github.com/repos/zalando/nakadi/contributors","subscribers_url":"https://api.github.com/repos/zalando/nakadi/subscribers","subscription_url":"https://api.github.com/repos/zalando/nakadi/subscription","commits_url":"https://api.github.com/repos/zalando/nakadi/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando/nakadi/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando/nakadi/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando/nakadi/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando/nakadi/contents/{+path}","compare_url":"https://api.github.com/repos/zalando/nakadi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando/nakadi/merges","archive_url":"https://api.github.com/repos/zalando/nakadi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando/nakadi/downloads","issues_url":"https://api.github.com/repos/zalando/nakadi/issues{/number}","pulls_url":"https://api.github.com/repos/zalando/nakadi/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando/nakadi/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando/nakadi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando/nakadi/labels{/name}","releases_url":"https://api.github.com/repos/zalando/nakadi/releases{/id}","deployments_url":"https://api.github.com/repos/zalando/nakadi/deployments","created_at":"2015-10-14T08:30:17Z","updated_at":"2017-05-14T12:25:28Z","pushed_at":"2017-05-16T15:17:25Z","git_url":"git://github.com/zalando/nakadi.git","ssh_url":"[email protected]:zalando/nakadi.git","clone_url":"https://github.com/zalando/nakadi.git","svn_url":"https://github.com/zalando/nakadi","homepage":"","size":6007,"stargazers_count":135,"watchers_count":135,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":46,"forks":47,"open_issues":46,"watchers":135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando/nakadi/pulls/653"},"html":{"href":"https://github.com/zalando/nakadi/pull/653"},"issue":{"href":"https://api.github.com/repos/zalando/nakadi/issues/653"},"comments":{"href":"https://api.github.com/repos/zalando/nakadi/issues/653/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando/nakadi/pulls/653/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando/nakadi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando/nakadi/pulls/653/commits"},"statuses":{"href":"https://api.github.com/repos/zalando/nakadi/statuses/decb63f6c7f354b48a756894929c569f1af6a5cd"}}}} | {
"id": 44234368,
"name": "zalando/nakadi",
"url": "https://api.github.com/repos/zalando/nakadi"
} | {
"id": 4863810,
"login": "adyach",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4863810?",
"url": "https://api.github.com/users/adyach"
} | {
"id": 1564818,
"login": "zalando",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1564818?",
"url": "https://api.github.com/orgs/zalando"
} | 2017-05-17T06:28:22 | 5887166934 | {"actor":{"display_login":"adyach"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/1stop-st/frame/pulls/comments/105592901","pull_request_review_id":26479000,"id":105592901,"diff_hunk":"@@ -0,0 +1,162 @@\n+/*eslint-env node */\n+\n+var finalhandler = require(\"finalhandler\");\n+var serveStatic = require(\"serve-static\")(\"dest\");\n+var server = require(\"http\").createServer(function onRequest(req, res) {\n+ serveStatic(req, res, finalhandler(req, res));\n+});\n+\n+var browserstack = require(\"browserstack-local\");\n+var bsLocal = new browserstack.Local();\n+\n+var user = process.env.BS_USERNAME;\n+var key = process.env.BS_AUTHKEY;\n+\n+var repo = process.env.CIRCLE_PROJECT_REPONAME;\n+var branch = process.env.CIRCLE_BRANCH;\n+var build = process.env.CIRCLE_BUILD_NUM;\n+\n+var commonCapabilities = {\n+ \"browserstack.local\": true,\n+ build: build,\n+ project: repo + \"_\" + branch\n+};\n+\n+var capabilities = [\n+ {\n+ os: 'Windows',\n+ os_version: '10',\n+ browser: 'IE',\n+ browser_version: '11.0',\n+ resolution: '1024x768'\n+ }, {\n+ os: 'Windows',\n+ os_version: '10',\n+ browser: 'Edge',\n+ browser_version: '14.0',\n+ resolution: '1024x768'\n+ }, {\n+ os: 'Windows',\n+ os_version: '10',\n+ browser: 'Firefox',\n+ browser_version: '53.0 beta',\n+ resolution: '1024x768'\n+ }, {\n+ os: 'Windows',\n+ os_version: '10',\n+ browser: 'Chrome',\n+ browser_version: '56.0',\n+ resolution: '1024x768'\n+ }, {\n+ os: 'OS X',\n+ os_version: 'Sierra',\n+ browser: 'Safari',\n+ browser_version: '10.0',\n+ resolution: '1024x768'\n+ }, {\n+ os: 'OS X',\n+ os_version: 'Sierra',\n+ browser: 'Firefox',\n+ browser_version: '53.0 beta',\n+ resolution: '1024x768'\n+ }, {\n+ os: 'OS X',\n+ os_version: 'Sierra',\n+ browser: 'Chrome',\n+ browser_version: '56.0',\n+ resolution: '1024x768'\n+ }, {\n+ os: 'OS X',\n+ os_version: 'Sierra',\n+ browser: 'Opera',\n+ browser_version: '12.15',\n+ resolution: '1024x768'\n+ }, {\n+ browserName: 'iPhone',\n+ platform: 'MAC',\n+ device: 'iPhone 6S'\n+ }/*, {\n+ browserName: 'iPhone',\n+ platform: 'MAC',\n+ device: 'iPhone 6S Plus'\n+ }, {\n+ browserName: 'iPad',\n+ platform: 'MAC',\n+ device: 'iPad Air 2'\n+ }, {\n+ browserName: 'iPad',\n+ platform: 'MAC',\n+ device: 'iPad Pro'\n+ }, {\n+ browserName: 'iPad',\n+ platform: 'MAC',\n+ device: 'iPad Mini 4'\n+ }*/, {","path":"tests/config.js","position":94,"original_position":94,"commit_id":"40af7ac1ee8a5fc3a119cac7a136680b220c3f78","original_commit_id":"40af7ac1ee8a5fc3a119cac7a136680b220c3f78","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars3.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Comma warnings can be turned off with 'laxcomma'.","created_at":"2017-03-13T05:41:32Z","updated_at":"2017-03-13T05:41:32Z","html_url":"https://github.com/1stop-st/frame/pull/38#discussion_r105592901","pull_request_url":"https://api.github.com/repos/1stop-st/frame/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/1stop-st/frame/pulls/comments/105592901"},"html":{"href":"https://github.com/1stop-st/frame/pull/38#discussion_r105592901"},"pull_request":{"href":"https://api.github.com/repos/1stop-st/frame/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/1stop-st/frame/pulls/38","id":110342787,"html_url":"https://github.com/1stop-st/frame/pull/38","diff_url":"https://github.com/1stop-st/frame/pull/38.diff","patch_url":"https://github.com/1stop-st/frame/pull/38.patch","issue_url":"https://api.github.com/repos/1stop-st/frame/issues/38","number":38,"state":"open","locked":false,"title":"マルチブラウザテストを設定しました。Frameworkは、webdriverIO + mocha.","user":{"login":"h-ikeda","id":1414321,"avatar_url":"https://avatars1.githubusercontent.com/u/1414321?v=3","gravatar_id":"","url":"https://api.github.com/users/h-ikeda","html_url":"https://github.com/h-ikeda","followers_url":"https://api.github.com/users/h-ikeda/followers","following_url":"https://api.github.com/users/h-ikeda/following{/other_user}","gists_url":"https://api.github.com/users/h-ikeda/gists{/gist_id}","starred_url":"https://api.github.com/users/h-ikeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-ikeda/subscriptions","organizations_url":"https://api.github.com/users/h-ikeda/orgs","repos_url":"https://api.github.com/users/h-ikeda/repos","events_url":"https://api.github.com/users/h-ikeda/events{/privacy}","received_events_url":"https://api.github.com/users/h-ikeda/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-13T05:41:21Z","updated_at":"2017-03-13T05:41:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7efced87429c04f40773e9d7005b6b3bef85c1c5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/1stop-st/frame/pulls/38/commits","review_comments_url":"https://api.github.com/repos/1stop-st/frame/pulls/38/comments","review_comment_url":"https://api.github.com/repos/1stop-st/frame/pulls/comments{/number}","comments_url":"https://api.github.com/repos/1stop-st/frame/issues/38/comments","statuses_url":"https://api.github.com/repos/1stop-st/frame/statuses/40af7ac1ee8a5fc3a119cac7a136680b220c3f78","head":{"label":"1stop-st:dev","ref":"dev","sha":"40af7ac1ee8a5fc3a119cac7a136680b220c3f78","user":{"login":"1stop-st","id":1438395,"avatar_url":"https://avatars3.githubusercontent.com/u/1438395?v=3","gravatar_id":"","url":"https://api.github.com/users/1stop-st","html_url":"https://github.com/1stop-st","followers_url":"https://api.github.com/users/1stop-st/followers","following_url":"https://api.github.com/users/1stop-st/following{/other_user}","gists_url":"https://api.github.com/users/1stop-st/gists{/gist_id}","starred_url":"https://api.github.com/users/1stop-st/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1stop-st/subscriptions","organizations_url":"https://api.github.com/users/1stop-st/orgs","repos_url":"https://api.github.com/users/1stop-st/repos","events_url":"https://api.github.com/users/1stop-st/events{/privacy}","received_events_url":"https://api.github.com/users/1stop-st/received_events","type":"Organization","site_admin":false},"repo":{"id":76113078,"name":"frame","full_name":"1stop-st/frame","owner":{"login":"1stop-st","id":1438395,"avatar_url":"https://avatars3.githubusercontent.com/u/1438395?v=3","gravatar_id":"","url":"https://api.github.com/users/1stop-st","html_url":"https://github.com/1stop-st","followers_url":"https://api.github.com/users/1stop-st/followers","following_url":"https://api.github.com/users/1stop-st/following{/other_user}","gists_url":"https://api.github.com/users/1stop-st/gists{/gist_id}","starred_url":"https://api.github.com/users/1stop-st/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1stop-st/subscriptions","organizations_url":"https://api.github.com/users/1stop-st/orgs","repos_url":"https://api.github.com/users/1stop-st/repos","events_url":"https://api.github.com/users/1stop-st/events{/privacy}","received_events_url":"https://api.github.com/users/1stop-st/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/1stop-st/frame","description":null,"fork":false,"url":"https://api.github.com/repos/1stop-st/frame","forks_url":"https://api.github.com/repos/1stop-st/frame/forks","keys_url":"https://api.github.com/repos/1stop-st/frame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/1stop-st/frame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/1stop-st/frame/teams","hooks_url":"https://api.github.com/repos/1stop-st/frame/hooks","issue_events_url":"https://api.github.com/repos/1stop-st/frame/issues/events{/number}","events_url":"https://api.github.com/repos/1stop-st/frame/events","assignees_url":"https://api.github.com/repos/1stop-st/frame/assignees{/user}","branches_url":"https://api.github.com/repos/1stop-st/frame/branches{/branch}","tags_url":"https://api.github.com/repos/1stop-st/frame/tags","blobs_url":"https://api.github.com/repos/1stop-st/frame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/1stop-st/frame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/1stop-st/frame/git/refs{/sha}","trees_url":"https://api.github.com/repos/1stop-st/frame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/1stop-st/frame/statuses/{sha}","languages_url":"https://api.github.com/repos/1stop-st/frame/languages","stargazers_url":"https://api.github.com/repos/1stop-st/frame/stargazers","contributors_url":"https://api.github.com/repos/1stop-st/frame/contributors","subscribers_url":"https://api.github.com/repos/1stop-st/frame/subscribers","subscription_url":"https://api.github.com/repos/1stop-st/frame/subscription","commits_url":"https://api.github.com/repos/1stop-st/frame/commits{/sha}","git_commits_url":"https://api.github.com/repos/1stop-st/frame/git/commits{/sha}","comments_url":"https://api.github.com/repos/1stop-st/frame/comments{/number}","issue_comment_url":"https://api.github.com/repos/1stop-st/frame/issues/comments{/number}","contents_url":"https://api.github.com/repos/1stop-st/frame/contents/{+path}","compare_url":"https://api.github.com/repos/1stop-st/frame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/1stop-st/frame/merges","archive_url":"https://api.github.com/repos/1stop-st/frame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/1stop-st/frame/downloads","issues_url":"https://api.github.com/repos/1stop-st/frame/issues{/number}","pulls_url":"https://api.github.com/repos/1stop-st/frame/pulls{/number}","milestones_url":"https://api.github.com/repos/1stop-st/frame/milestones{/number}","notifications_url":"https://api.github.com/repos/1stop-st/frame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/1stop-st/frame/labels{/name}","releases_url":"https://api.github.com/repos/1stop-st/frame/releases{/id}","deployments_url":"https://api.github.com/repos/1stop-st/frame/deployments","created_at":"2016-12-10T13:06:26Z","updated_at":"2017-02-16T14:51:45Z","pushed_at":"2017-03-13T05:41:22Z","git_url":"git://github.com/1stop-st/frame.git","ssh_url":"[email protected]:1stop-st/frame.git","clone_url":"https://github.com/1stop-st/frame.git","svn_url":"https://github.com/1stop-st/frame","homepage":null,"size":98,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":1,"default_branch":"master"}},"base":{"label":"1stop-st:master","ref":"master","sha":"d75810fbba9f246bdc71cb04f1c7e775e3d70b0a","user":{"login":"1stop-st","id":1438395,"avatar_url":"https://avatars3.githubusercontent.com/u/1438395?v=3","gravatar_id":"","url":"https://api.github.com/users/1stop-st","html_url":"https://github.com/1stop-st","followers_url":"https://api.github.com/users/1stop-st/followers","following_url":"https://api.github.com/users/1stop-st/following{/other_user}","gists_url":"https://api.github.com/users/1stop-st/gists{/gist_id}","starred_url":"https://api.github.com/users/1stop-st/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1stop-st/subscriptions","organizations_url":"https://api.github.com/users/1stop-st/orgs","repos_url":"https://api.github.com/users/1stop-st/repos","events_url":"https://api.github.com/users/1stop-st/events{/privacy}","received_events_url":"https://api.github.com/users/1stop-st/received_events","type":"Organization","site_admin":false},"repo":{"id":76113078,"name":"frame","full_name":"1stop-st/frame","owner":{"login":"1stop-st","id":1438395,"avatar_url":"https://avatars3.githubusercontent.com/u/1438395?v=3","gravatar_id":"","url":"https://api.github.com/users/1stop-st","html_url":"https://github.com/1stop-st","followers_url":"https://api.github.com/users/1stop-st/followers","following_url":"https://api.github.com/users/1stop-st/following{/other_user}","gists_url":"https://api.github.com/users/1stop-st/gists{/gist_id}","starred_url":"https://api.github.com/users/1stop-st/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1stop-st/subscriptions","organizations_url":"https://api.github.com/users/1stop-st/orgs","repos_url":"https://api.github.com/users/1stop-st/repos","events_url":"https://api.github.com/users/1stop-st/events{/privacy}","received_events_url":"https://api.github.com/users/1stop-st/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/1stop-st/frame","description":null,"fork":false,"url":"https://api.github.com/repos/1stop-st/frame","forks_url":"https://api.github.com/repos/1stop-st/frame/forks","keys_url":"https://api.github.com/repos/1stop-st/frame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/1stop-st/frame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/1stop-st/frame/teams","hooks_url":"https://api.github.com/repos/1stop-st/frame/hooks","issue_events_url":"https://api.github.com/repos/1stop-st/frame/issues/events{/number}","events_url":"https://api.github.com/repos/1stop-st/frame/events","assignees_url":"https://api.github.com/repos/1stop-st/frame/assignees{/user}","branches_url":"https://api.github.com/repos/1stop-st/frame/branches{/branch}","tags_url":"https://api.github.com/repos/1stop-st/frame/tags","blobs_url":"https://api.github.com/repos/1stop-st/frame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/1stop-st/frame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/1stop-st/frame/git/refs{/sha}","trees_url":"https://api.github.com/repos/1stop-st/frame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/1stop-st/frame/statuses/{sha}","languages_url":"https://api.github.com/repos/1stop-st/frame/languages","stargazers_url":"https://api.github.com/repos/1stop-st/frame/stargazers","contributors_url":"https://api.github.com/repos/1stop-st/frame/contributors","subscribers_url":"https://api.github.com/repos/1stop-st/frame/subscribers","subscription_url":"https://api.github.com/repos/1stop-st/frame/subscription","commits_url":"https://api.github.com/repos/1stop-st/frame/commits{/sha}","git_commits_url":"https://api.github.com/repos/1stop-st/frame/git/commits{/sha}","comments_url":"https://api.github.com/repos/1stop-st/frame/comments{/number}","issue_comment_url":"https://api.github.com/repos/1stop-st/frame/issues/comments{/number}","contents_url":"https://api.github.com/repos/1stop-st/frame/contents/{+path}","compare_url":"https://api.github.com/repos/1stop-st/frame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/1stop-st/frame/merges","archive_url":"https://api.github.com/repos/1stop-st/frame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/1stop-st/frame/downloads","issues_url":"https://api.github.com/repos/1stop-st/frame/issues{/number}","pulls_url":"https://api.github.com/repos/1stop-st/frame/pulls{/number}","milestones_url":"https://api.github.com/repos/1stop-st/frame/milestones{/number}","notifications_url":"https://api.github.com/repos/1stop-st/frame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/1stop-st/frame/labels{/name}","releases_url":"https://api.github.com/repos/1stop-st/frame/releases{/id}","deployments_url":"https://api.github.com/repos/1stop-st/frame/deployments","created_at":"2016-12-10T13:06:26Z","updated_at":"2017-02-16T14:51:45Z","pushed_at":"2017-03-13T05:41:22Z","git_url":"git://github.com/1stop-st/frame.git","ssh_url":"[email protected]:1stop-st/frame.git","clone_url":"https://github.com/1stop-st/frame.git","svn_url":"https://github.com/1stop-st/frame","homepage":null,"size":98,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/1stop-st/frame/pulls/38"},"html":{"href":"https://github.com/1stop-st/frame/pull/38"},"issue":{"href":"https://api.github.com/repos/1stop-st/frame/issues/38"},"comments":{"href":"https://api.github.com/repos/1stop-st/frame/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/1stop-st/frame/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/1stop-st/frame/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/1stop-st/frame/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/1stop-st/frame/statuses/40af7ac1ee8a5fc3a119cac7a136680b220c3f78"}}}} | {
"id": 76113078,
"name": "1stop-st/frame",
"url": "https://api.github.com/repos/1stop-st/frame"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 1438395,
"login": "1stop-st",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1438395?",
"url": "https://api.github.com/orgs/1stop-st"
} | 2017-03-13T05:41:32 | 5480018762 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Carthage/Carthage/pulls/comments/135047235","pull_request_review_id":58414702,"id":135047235,"diff_hunk":"@@ -246,6 +246,19 @@ class ProjectSpec: QuickSpec {\n \t\t\t\t\tfail()\n \t\t\t\t}\n \t\t\t}\n+\t\t\t","path":"Tests/CarthageKitTests/ProjectSpec.swift","position":4,"original_position":4,"commit_id":"860c8d5a0e40abae076c97641c150635f07e2d53","original_commit_id":"860c8d5a0e40abae076c97641c150635f07e2d53","user":{"login":"jdhealy","id":782837,"avatar_url":"https://avatars2.githubusercontent.com/u/782837?v=4","gravatar_id":"","url":"https://api.github.com/users/jdhealy","html_url":"https://github.com/jdhealy","followers_url":"https://api.github.com/users/jdhealy/followers","following_url":"https://api.github.com/users/jdhealy/following{/other_user}","gists_url":"https://api.github.com/users/jdhealy/gists{/gist_id}","starred_url":"https://api.github.com/users/jdhealy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdhealy/subscriptions","organizations_url":"https://api.github.com/users/jdhealy/orgs","repos_url":"https://api.github.com/users/jdhealy/repos","events_url":"https://api.github.com/users/jdhealy/events{/privacy}","received_events_url":"https://api.github.com/users/jdhealy/received_events","type":"User","site_admin":false},"body":"Thanks for taking the time to add tests and fixtures! ☀️ ","created_at":"2017-08-24T15:24:43Z","updated_at":"2017-08-24T15:24:43Z","html_url":"https://github.com/Carthage/Carthage/pull/2126#discussion_r135047235","pull_request_url":"https://api.github.com/repos/Carthage/Carthage/pulls/2126","_links":{"self":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/comments/135047235"},"html":{"href":"https://github.com/Carthage/Carthage/pull/2126#discussion_r135047235"},"pull_request":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2126"}}},"pull_request":{"url":"https://api.github.com/repos/Carthage/Carthage/pulls/2126","id":136796701,"html_url":"https://github.com/Carthage/Carthage/pull/2126","diff_url":"https://github.com/Carthage/Carthage/pull/2126.diff","patch_url":"https://github.com/Carthage/Carthage/pull/2126.patch","issue_url":"https://api.github.com/repos/Carthage/Carthage/issues/2126","number":2126,"state":"open","locked":false,"title":"[WIP] Validating Cartfile name correctness","user":{"login":"spookyd","id":4504366,"avatar_url":"https://avatars3.githubusercontent.com/u/4504366?v=4","gravatar_id":"","url":"https://api.github.com/users/spookyd","html_url":"https://github.com/spookyd","followers_url":"https://api.github.com/users/spookyd/followers","following_url":"https://api.github.com/users/spookyd/following{/other_user}","gists_url":"https://api.github.com/users/spookyd/gists{/gist_id}","starred_url":"https://api.github.com/users/spookyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spookyd/subscriptions","organizations_url":"https://api.github.com/users/spookyd/orgs","repos_url":"https://api.github.com/users/spookyd/repos","events_url":"https://api.github.com/users/spookyd/events{/privacy}","received_events_url":"https://api.github.com/users/spookyd/received_events","type":"User","site_admin":false},"body":"Currently, validating the Cartfile and Cartfile.private files a case correct and returning a file not found error if they do not match. However, I think it should be discussed whether or not a more specific error should be returned explaining that a Cartfile was discovered but is not properly named. In other words, return an error with a suggestion.\r\n\r\nThoughts?","created_at":"2017-08-21T16:19:15Z","updated_at":"2017-08-24T15:24:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2b008fcdf606b5c92449118c4ff1720c1d85128","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Carthage/Carthage/pulls/2126/commits","review_comments_url":"https://api.github.com/repos/Carthage/Carthage/pulls/2126/comments","review_comment_url":"https://api.github.com/repos/Carthage/Carthage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Carthage/Carthage/issues/2126/comments","statuses_url":"https://api.github.com/repos/Carthage/Carthage/statuses/860c8d5a0e40abae076c97641c150635f07e2d53","head":{"label":"spookyd:feature/issue-1336","ref":"feature/issue-1336","sha":"860c8d5a0e40abae076c97641c150635f07e2d53","user":{"login":"spookyd","id":4504366,"avatar_url":"https://avatars3.githubusercontent.com/u/4504366?v=4","gravatar_id":"","url":"https://api.github.com/users/spookyd","html_url":"https://github.com/spookyd","followers_url":"https://api.github.com/users/spookyd/followers","following_url":"https://api.github.com/users/spookyd/following{/other_user}","gists_url":"https://api.github.com/users/spookyd/gists{/gist_id}","starred_url":"https://api.github.com/users/spookyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spookyd/subscriptions","organizations_url":"https://api.github.com/users/spookyd/orgs","repos_url":"https://api.github.com/users/spookyd/repos","events_url":"https://api.github.com/users/spookyd/events{/privacy}","received_events_url":"https://api.github.com/users/spookyd/received_events","type":"User","site_admin":false},"repo":{"id":100393078,"name":"Carthage","full_name":"spookyd/Carthage","owner":{"login":"spookyd","id":4504366,"avatar_url":"https://avatars3.githubusercontent.com/u/4504366?v=4","gravatar_id":"","url":"https://api.github.com/users/spookyd","html_url":"https://github.com/spookyd","followers_url":"https://api.github.com/users/spookyd/followers","following_url":"https://api.github.com/users/spookyd/following{/other_user}","gists_url":"https://api.github.com/users/spookyd/gists{/gist_id}","starred_url":"https://api.github.com/users/spookyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spookyd/subscriptions","organizations_url":"https://api.github.com/users/spookyd/orgs","repos_url":"https://api.github.com/users/spookyd/repos","events_url":"https://api.github.com/users/spookyd/events{/privacy}","received_events_url":"https://api.github.com/users/spookyd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spookyd/Carthage","description":"A simple, decentralized dependency manager for Cocoa","fork":true,"url":"https://api.github.com/repos/spookyd/Carthage","forks_url":"https://api.github.com/repos/spookyd/Carthage/forks","keys_url":"https://api.github.com/repos/spookyd/Carthage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spookyd/Carthage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spookyd/Carthage/teams","hooks_url":"https://api.github.com/repos/spookyd/Carthage/hooks","issue_events_url":"https://api.github.com/repos/spookyd/Carthage/issues/events{/number}","events_url":"https://api.github.com/repos/spookyd/Carthage/events","assignees_url":"https://api.github.com/repos/spookyd/Carthage/assignees{/user}","branches_url":"https://api.github.com/repos/spookyd/Carthage/branches{/branch}","tags_url":"https://api.github.com/repos/spookyd/Carthage/tags","blobs_url":"https://api.github.com/repos/spookyd/Carthage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spookyd/Carthage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spookyd/Carthage/git/refs{/sha}","trees_url":"https://api.github.com/repos/spookyd/Carthage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spookyd/Carthage/statuses/{sha}","languages_url":"https://api.github.com/repos/spookyd/Carthage/languages","stargazers_url":"https://api.github.com/repos/spookyd/Carthage/stargazers","contributors_url":"https://api.github.com/repos/spookyd/Carthage/contributors","subscribers_url":"https://api.github.com/repos/spookyd/Carthage/subscribers","subscription_url":"https://api.github.com/repos/spookyd/Carthage/subscription","commits_url":"https://api.github.com/repos/spookyd/Carthage/commits{/sha}","git_commits_url":"https://api.github.com/repos/spookyd/Carthage/git/commits{/sha}","comments_url":"https://api.github.com/repos/spookyd/Carthage/comments{/number}","issue_comment_url":"https://api.github.com/repos/spookyd/Carthage/issues/comments{/number}","contents_url":"https://api.github.com/repos/spookyd/Carthage/contents/{+path}","compare_url":"https://api.github.com/repos/spookyd/Carthage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spookyd/Carthage/merges","archive_url":"https://api.github.com/repos/spookyd/Carthage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spookyd/Carthage/downloads","issues_url":"https://api.github.com/repos/spookyd/Carthage/issues{/number}","pulls_url":"https://api.github.com/repos/spookyd/Carthage/pulls{/number}","milestones_url":"https://api.github.com/repos/spookyd/Carthage/milestones{/number}","notifications_url":"https://api.github.com/repos/spookyd/Carthage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spookyd/Carthage/labels{/name}","releases_url":"https://api.github.com/repos/spookyd/Carthage/releases{/id}","deployments_url":"https://api.github.com/repos/spookyd/Carthage/deployments","created_at":"2017-08-15T15:43:31Z","updated_at":"2017-08-15T15:43:34Z","pushed_at":"2017-08-21T16:10:25Z","git_url":"git://github.com/spookyd/Carthage.git","ssh_url":"[email protected]:spookyd/Carthage.git","clone_url":"https://github.com/spookyd/Carthage.git","svn_url":"https://github.com/spookyd/Carthage","homepage":"","size":13627,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Carthage:master","ref":"master","sha":"49e665797f51bed213f35d79849ab7a1ce976dd4","user":{"login":"Carthage","id":9146792,"avatar_url":"https://avatars1.githubusercontent.com/u/9146792?v=4","gravatar_id":"","url":"https://api.github.com/users/Carthage","html_url":"https://github.com/Carthage","followers_url":"https://api.github.com/users/Carthage/followers","following_url":"https://api.github.com/users/Carthage/following{/other_user}","gists_url":"https://api.github.com/users/Carthage/gists{/gist_id}","starred_url":"https://api.github.com/users/Carthage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carthage/subscriptions","organizations_url":"https://api.github.com/users/Carthage/orgs","repos_url":"https://api.github.com/users/Carthage/repos","events_url":"https://api.github.com/users/Carthage/events{/privacy}","received_events_url":"https://api.github.com/users/Carthage/received_events","type":"Organization","site_admin":false},"repo":{"id":25050844,"name":"Carthage","full_name":"Carthage/Carthage","owner":{"login":"Carthage","id":9146792,"avatar_url":"https://avatars1.githubusercontent.com/u/9146792?v=4","gravatar_id":"","url":"https://api.github.com/users/Carthage","html_url":"https://github.com/Carthage","followers_url":"https://api.github.com/users/Carthage/followers","following_url":"https://api.github.com/users/Carthage/following{/other_user}","gists_url":"https://api.github.com/users/Carthage/gists{/gist_id}","starred_url":"https://api.github.com/users/Carthage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carthage/subscriptions","organizations_url":"https://api.github.com/users/Carthage/orgs","repos_url":"https://api.github.com/users/Carthage/repos","events_url":"https://api.github.com/users/Carthage/events{/privacy}","received_events_url":"https://api.github.com/users/Carthage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Carthage/Carthage","description":"A simple, decentralized dependency manager for Cocoa","fork":false,"url":"https://api.github.com/repos/Carthage/Carthage","forks_url":"https://api.github.com/repos/Carthage/Carthage/forks","keys_url":"https://api.github.com/repos/Carthage/Carthage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Carthage/Carthage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Carthage/Carthage/teams","hooks_url":"https://api.github.com/repos/Carthage/Carthage/hooks","issue_events_url":"https://api.github.com/repos/Carthage/Carthage/issues/events{/number}","events_url":"https://api.github.com/repos/Carthage/Carthage/events","assignees_url":"https://api.github.com/repos/Carthage/Carthage/assignees{/user}","branches_url":"https://api.github.com/repos/Carthage/Carthage/branches{/branch}","tags_url":"https://api.github.com/repos/Carthage/Carthage/tags","blobs_url":"https://api.github.com/repos/Carthage/Carthage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Carthage/Carthage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Carthage/Carthage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Carthage/Carthage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Carthage/Carthage/statuses/{sha}","languages_url":"https://api.github.com/repos/Carthage/Carthage/languages","stargazers_url":"https://api.github.com/repos/Carthage/Carthage/stargazers","contributors_url":"https://api.github.com/repos/Carthage/Carthage/contributors","subscribers_url":"https://api.github.com/repos/Carthage/Carthage/subscribers","subscription_url":"https://api.github.com/repos/Carthage/Carthage/subscription","commits_url":"https://api.github.com/repos/Carthage/Carthage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Carthage/Carthage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Carthage/Carthage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Carthage/Carthage/issues/comments{/number}","contents_url":"https://api.github.com/repos/Carthage/Carthage/contents/{+path}","compare_url":"https://api.github.com/repos/Carthage/Carthage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Carthage/Carthage/merges","archive_url":"https://api.github.com/repos/Carthage/Carthage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Carthage/Carthage/downloads","issues_url":"https://api.github.com/repos/Carthage/Carthage/issues{/number}","pulls_url":"https://api.github.com/repos/Carthage/Carthage/pulls{/number}","milestones_url":"https://api.github.com/repos/Carthage/Carthage/milestones{/number}","notifications_url":"https://api.github.com/repos/Carthage/Carthage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Carthage/Carthage/labels{/name}","releases_url":"https://api.github.com/repos/Carthage/Carthage/releases{/id}","deployments_url":"https://api.github.com/repos/Carthage/Carthage/deployments","created_at":"2014-10-10T19:54:55Z","updated_at":"2017-08-24T15:00:07Z","pushed_at":"2017-08-24T13:25:43Z","git_url":"git://github.com/Carthage/Carthage.git","ssh_url":"[email protected]:Carthage/Carthage.git","clone_url":"https://github.com/Carthage/Carthage.git","svn_url":"https://github.com/Carthage/Carthage","homepage":"","size":13670,"stargazers_count":9994,"watchers_count":9994,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":901,"mirror_url":null,"open_issues_count":156,"forks":901,"open_issues":156,"watchers":9994,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2126"},"html":{"href":"https://github.com/Carthage/Carthage/pull/2126"},"issue":{"href":"https://api.github.com/repos/Carthage/Carthage/issues/2126"},"comments":{"href":"https://api.github.com/repos/Carthage/Carthage/issues/2126/comments"},"review_comments":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2126/comments"},"review_comment":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2126/commits"},"statuses":{"href":"https://api.github.com/repos/Carthage/Carthage/statuses/860c8d5a0e40abae076c97641c150635f07e2d53"}}}} | {
"id": 25050844,
"name": "Carthage/Carthage",
"url": "https://api.github.com/repos/Carthage/Carthage"
} | {
"id": 782837,
"login": "jdhealy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/782837?",
"url": "https://api.github.com/users/jdhealy"
} | {
"id": 9146792,
"login": "Carthage",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9146792?",
"url": "https://api.github.com/orgs/Carthage"
} | 2017-08-24T15:24:43 | 6508070529 | {"actor":{"display_login":"jdhealy"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Catrobat/Catroid/pulls/comments/120565273","pull_request_review_id":42536619,"id":120565273,"diff_hunk":"@@ -49,19 +49,19 @@\n <string name=\"close\">إغلاق</string>\n <string name=\"error\">خطأ</string>\n <string name=\"please_wait\">الرجاء الانتظار</string>\n- <string name=\"loading\">تحميل…</string>\n- <string name=\"search_hint\">جاري البحث…</string>\n+ <string name=\"loading\">تحميل…</string>\n+ <string name=\"search_hint\">جاري البحث…</string>\n <string name=\"no_internet\">لا يوجد إتصال بالإنترنت</string>\n- <string name=\"loading_check_token\">Token is checked on our server…</string>\n- <string name=\"loading_check_facebook_data\">يتم استرداد بيانات الفيس بوك…</string>\n- <string name=\"loading_check_email\">E-Mail availability is checked on our server…</string>\n- <string name=\"loading_check_oauth_token\">OAuth token is checked on our server…</string>\n- <string name=\"loading_check_facebook_token_validity\">Facebook token validity is checked on our server…</string>\n- <string name=\"loading_check_oauth_username\">Username availability is checked on our server…</string>\n- <string name=\"loading_facebook_exchange_token\">Facebook token is exchanged on our server…</string>\n- <string name=\"loading_facebook_login\">Facebook login is completed on our server…</string>\n- <string name=\"loading_google_exchange_code\">تم تبادل جوجل + التعليمات البرمجية على الخادم…</string>\n- <string name=\"loading_google_login\">تم إكمال عملية جوجل +تسجيل الدخول على الخادم…</string>\n+ <string name=\"loading_check_token\">Token is checked on our server…</string>\n+ <string name=\"loading_check_facebook_data\">يتم استرداد بيانات الفيس بوك…</string>\n+ <string name=\"loading_check_email\">E-Mail availability is checked on our server…</string>\n+ <string name=\"loading_check_oauth_token\">OAuth token is checked on our server…</string>\n+ <string name=\"loading_check_facebook_token_validity\">Facebook token validity is checked on our server…</string>\n+ <string name=\"loading_check_oauth_username\">Username availability is checked on our server…</string>\n+ <string name=\"loading_facebook_exchange_token\">Facebook token is exchanged on our server…</string>\n+ <string name=\"loading_facebook_login\">Facebook login is completed on our server…</string>\n+ <string name=\"loading_google_exchange_code\">تم تبادل جوجل + التعليمات البرمجية على الخادم…</string>","path":"catroid/src/main/res/values-ar/strings.xml","position":27,"original_position":27,"commit_id":"7737c65498c7fcef95a1f2b2ecc8a397c1b047e2","original_commit_id":"7737c65498c7fcef95a1f2b2ecc8a397c1b047e2","user":{"login":"84n4n4","id":15098185,"avatar_url":"https://avatars1.githubusercontent.com/u/15098185?v=3","gravatar_id":"","url":"https://api.github.com/users/84n4n4","html_url":"https://github.com/84n4n4","followers_url":"https://api.github.com/users/84n4n4/followers","following_url":"https://api.github.com/users/84n4n4/following{/other_user}","gists_url":"https://api.github.com/users/84n4n4/gists{/gist_id}","starred_url":"https://api.github.com/users/84n4n4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/84n4n4/subscriptions","organizations_url":"https://api.github.com/users/84n4n4/orgs","repos_url":"https://api.github.com/users/84n4n4/repos","events_url":"https://api.github.com/users/84n4n4/events{/privacy}","received_events_url":"https://api.github.com/users/84n4n4/received_events","type":"User","site_admin":false},"body":"those are right to left languages, so you added the \"...\" to the begin of the sentence...","created_at":"2017-06-07T08:37:15Z","updated_at":"2017-06-07T08:37:15Z","html_url":"https://github.com/Catrobat/Catroid/pull/2338#discussion_r120565273","pull_request_url":"https://api.github.com/repos/Catrobat/Catroid/pulls/2338","_links":{"self":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/comments/120565273"},"html":{"href":"https://github.com/Catrobat/Catroid/pull/2338#discussion_r120565273"},"pull_request":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/2338"}}},"pull_request":{"url":"https://api.github.com/repos/Catrobat/Catroid/pulls/2338","id":124344589,"html_url":"https://github.com/Catrobat/Catroid/pull/2338","diff_url":"https://github.com/Catrobat/Catroid/pull/2338.diff","patch_url":"https://github.com/Catrobat/Catroid/pull/2338.patch","issue_url":"https://api.github.com/repos/Catrobat/Catroid/issues/2338","number":2338,"state":"open","locked":false,"title":"CAT-2426 Fix checkstyle errors for ellipsis character","user":{"login":"M-Schiller","id":11773136,"avatar_url":"https://avatars1.githubusercontent.com/u/11773136?v=3","gravatar_id":"","url":"https://api.github.com/users/M-Schiller","html_url":"https://github.com/M-Schiller","followers_url":"https://api.github.com/users/M-Schiller/followers","following_url":"https://api.github.com/users/M-Schiller/following{/other_user}","gists_url":"https://api.github.com/users/M-Schiller/gists{/gist_id}","starred_url":"https://api.github.com/users/M-Schiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/M-Schiller/subscriptions","organizations_url":"https://api.github.com/users/M-Schiller/orgs","repos_url":"https://api.github.com/users/M-Schiller/repos","events_url":"https://api.github.com/users/M-Schiller/events{/privacy}","received_events_url":"https://api.github.com/users/M-Schiller/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-07T06:26:53Z","updated_at":"2017-06-07T08:37:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0eca1400e1a179b8206423b02d2ad8bec36b753","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Catrobat/Catroid/pulls/2338/commits","review_comments_url":"https://api.github.com/repos/Catrobat/Catroid/pulls/2338/comments","review_comment_url":"https://api.github.com/repos/Catrobat/Catroid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Catrobat/Catroid/issues/2338/comments","statuses_url":"https://api.github.com/repos/Catrobat/Catroid/statuses/7737c65498c7fcef95a1f2b2ecc8a397c1b047e2","head":{"label":"M-Schiller:checkstyleEllipsis","ref":"checkstyleEllipsis","sha":"7737c65498c7fcef95a1f2b2ecc8a397c1b047e2","user":{"login":"M-Schiller","id":11773136,"avatar_url":"https://avatars1.githubusercontent.com/u/11773136?v=3","gravatar_id":"","url":"https://api.github.com/users/M-Schiller","html_url":"https://github.com/M-Schiller","followers_url":"https://api.github.com/users/M-Schiller/followers","following_url":"https://api.github.com/users/M-Schiller/following{/other_user}","gists_url":"https://api.github.com/users/M-Schiller/gists{/gist_id}","starred_url":"https://api.github.com/users/M-Schiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/M-Schiller/subscriptions","organizations_url":"https://api.github.com/users/M-Schiller/orgs","repos_url":"https://api.github.com/users/M-Schiller/repos","events_url":"https://api.github.com/users/M-Schiller/events{/privacy}","received_events_url":"https://api.github.com/users/M-Schiller/received_events","type":"User","site_admin":false},"repo":{"id":85057782,"name":"Catroid","full_name":"M-Schiller/Catroid","owner":{"login":"M-Schiller","id":11773136,"avatar_url":"https://avatars1.githubusercontent.com/u/11773136?v=3","gravatar_id":"","url":"https://api.github.com/users/M-Schiller","html_url":"https://github.com/M-Schiller","followers_url":"https://api.github.com/users/M-Schiller/followers","following_url":"https://api.github.com/users/M-Schiller/following{/other_user}","gists_url":"https://api.github.com/users/M-Schiller/gists{/gist_id}","starred_url":"https://api.github.com/users/M-Schiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/M-Schiller/subscriptions","organizations_url":"https://api.github.com/users/M-Schiller/orgs","repos_url":"https://api.github.com/users/M-Schiller/repos","events_url":"https://api.github.com/users/M-Schiller/events{/privacy}","received_events_url":"https://api.github.com/users/M-Schiller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/M-Schiller/Catroid","description":"Writing programs on an Android device without prior knowledge.","fork":true,"url":"https://api.github.com/repos/M-Schiller/Catroid","forks_url":"https://api.github.com/repos/M-Schiller/Catroid/forks","keys_url":"https://api.github.com/repos/M-Schiller/Catroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/M-Schiller/Catroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/M-Schiller/Catroid/teams","hooks_url":"https://api.github.com/repos/M-Schiller/Catroid/hooks","issue_events_url":"https://api.github.com/repos/M-Schiller/Catroid/issues/events{/number}","events_url":"https://api.github.com/repos/M-Schiller/Catroid/events","assignees_url":"https://api.github.com/repos/M-Schiller/Catroid/assignees{/user}","branches_url":"https://api.github.com/repos/M-Schiller/Catroid/branches{/branch}","tags_url":"https://api.github.com/repos/M-Schiller/Catroid/tags","blobs_url":"https://api.github.com/repos/M-Schiller/Catroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/M-Schiller/Catroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/M-Schiller/Catroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/M-Schiller/Catroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/M-Schiller/Catroid/statuses/{sha}","languages_url":"https://api.github.com/repos/M-Schiller/Catroid/languages","stargazers_url":"https://api.github.com/repos/M-Schiller/Catroid/stargazers","contributors_url":"https://api.github.com/repos/M-Schiller/Catroid/contributors","subscribers_url":"https://api.github.com/repos/M-Schiller/Catroid/subscribers","subscription_url":"https://api.github.com/repos/M-Schiller/Catroid/subscription","commits_url":"https://api.github.com/repos/M-Schiller/Catroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/M-Schiller/Catroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/M-Schiller/Catroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/M-Schiller/Catroid/issues/comments{/number}","contents_url":"https://api.github.com/repos/M-Schiller/Catroid/contents/{+path}","compare_url":"https://api.github.com/repos/M-Schiller/Catroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/M-Schiller/Catroid/merges","archive_url":"https://api.github.com/repos/M-Schiller/Catroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/M-Schiller/Catroid/downloads","issues_url":"https://api.github.com/repos/M-Schiller/Catroid/issues{/number}","pulls_url":"https://api.github.com/repos/M-Schiller/Catroid/pulls{/number}","milestones_url":"https://api.github.com/repos/M-Schiller/Catroid/milestones{/number}","notifications_url":"https://api.github.com/repos/M-Schiller/Catroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/M-Schiller/Catroid/labels{/name}","releases_url":"https://api.github.com/repos/M-Schiller/Catroid/releases{/id}","deployments_url":"https://api.github.com/repos/M-Schiller/Catroid/deployments","created_at":"2017-03-15T10:10:37Z","updated_at":"2017-03-15T10:10:45Z","pushed_at":"2017-06-07T06:26:36Z","git_url":"git://github.com/M-Schiller/Catroid.git","ssh_url":"[email protected]:M-Schiller/Catroid.git","clone_url":"https://github.com/M-Schiller/Catroid.git","svn_url":"https://github.com/M-Schiller/Catroid","homepage":"https://share.catrob.at/pocketcode","size":119286,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Catrobat:develop","ref":"develop","sha":"1f8609002b582e4140d0c98f767ecc1bd249254f","user":{"login":"Catrobat","id":1747223,"avatar_url":"https://avatars2.githubusercontent.com/u/1747223?v=3","gravatar_id":"","url":"https://api.github.com/users/Catrobat","html_url":"https://github.com/Catrobat","followers_url":"https://api.github.com/users/Catrobat/followers","following_url":"https://api.github.com/users/Catrobat/following{/other_user}","gists_url":"https://api.github.com/users/Catrobat/gists{/gist_id}","starred_url":"https://api.github.com/users/Catrobat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Catrobat/subscriptions","organizations_url":"https://api.github.com/users/Catrobat/orgs","repos_url":"https://api.github.com/users/Catrobat/repos","events_url":"https://api.github.com/users/Catrobat/events{/privacy}","received_events_url":"https://api.github.com/users/Catrobat/received_events","type":"Organization","site_admin":false},"repo":{"id":4475999,"name":"Catroid","full_name":"Catrobat/Catroid","owner":{"login":"Catrobat","id":1747223,"avatar_url":"https://avatars2.githubusercontent.com/u/1747223?v=3","gravatar_id":"","url":"https://api.github.com/users/Catrobat","html_url":"https://github.com/Catrobat","followers_url":"https://api.github.com/users/Catrobat/followers","following_url":"https://api.github.com/users/Catrobat/following{/other_user}","gists_url":"https://api.github.com/users/Catrobat/gists{/gist_id}","starred_url":"https://api.github.com/users/Catrobat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Catrobat/subscriptions","organizations_url":"https://api.github.com/users/Catrobat/orgs","repos_url":"https://api.github.com/users/Catrobat/repos","events_url":"https://api.github.com/users/Catrobat/events{/privacy}","received_events_url":"https://api.github.com/users/Catrobat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Catrobat/Catroid","description":"Writing programs on an Android device without prior knowledge.","fork":false,"url":"https://api.github.com/repos/Catrobat/Catroid","forks_url":"https://api.github.com/repos/Catrobat/Catroid/forks","keys_url":"https://api.github.com/repos/Catrobat/Catroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Catrobat/Catroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Catrobat/Catroid/teams","hooks_url":"https://api.github.com/repos/Catrobat/Catroid/hooks","issue_events_url":"https://api.github.com/repos/Catrobat/Catroid/issues/events{/number}","events_url":"https://api.github.com/repos/Catrobat/Catroid/events","assignees_url":"https://api.github.com/repos/Catrobat/Catroid/assignees{/user}","branches_url":"https://api.github.com/repos/Catrobat/Catroid/branches{/branch}","tags_url":"https://api.github.com/repos/Catrobat/Catroid/tags","blobs_url":"https://api.github.com/repos/Catrobat/Catroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Catrobat/Catroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Catrobat/Catroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/Catrobat/Catroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Catrobat/Catroid/statuses/{sha}","languages_url":"https://api.github.com/repos/Catrobat/Catroid/languages","stargazers_url":"https://api.github.com/repos/Catrobat/Catroid/stargazers","contributors_url":"https://api.github.com/repos/Catrobat/Catroid/contributors","subscribers_url":"https://api.github.com/repos/Catrobat/Catroid/subscribers","subscription_url":"https://api.github.com/repos/Catrobat/Catroid/subscription","commits_url":"https://api.github.com/repos/Catrobat/Catroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/Catrobat/Catroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/Catrobat/Catroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/Catrobat/Catroid/issues/comments{/number}","contents_url":"https://api.github.com/repos/Catrobat/Catroid/contents/{+path}","compare_url":"https://api.github.com/repos/Catrobat/Catroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Catrobat/Catroid/merges","archive_url":"https://api.github.com/repos/Catrobat/Catroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Catrobat/Catroid/downloads","issues_url":"https://api.github.com/repos/Catrobat/Catroid/issues{/number}","pulls_url":"https://api.github.com/repos/Catrobat/Catroid/pulls{/number}","milestones_url":"https://api.github.com/repos/Catrobat/Catroid/milestones{/number}","notifications_url":"https://api.github.com/repos/Catrobat/Catroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Catrobat/Catroid/labels{/name}","releases_url":"https://api.github.com/repos/Catrobat/Catroid/releases{/id}","deployments_url":"https://api.github.com/repos/Catrobat/Catroid/deployments","created_at":"2012-05-29T00:18:04Z","updated_at":"2017-05-25T13:30:31Z","pushed_at":"2017-06-07T07:14:06Z","git_url":"git://github.com/Catrobat/Catroid.git","ssh_url":"[email protected]:Catrobat/Catroid.git","clone_url":"https://github.com/Catrobat/Catroid.git","svn_url":"https://github.com/Catrobat/Catroid","homepage":"https://share.catrob.at/pocketcode","size":143414,"stargazers_count":150,"watchers_count":150,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":245,"mirror_url":null,"open_issues_count":142,"forks":245,"open_issues":142,"watchers":150,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/2338"},"html":{"href":"https://github.com/Catrobat/Catroid/pull/2338"},"issue":{"href":"https://api.github.com/repos/Catrobat/Catroid/issues/2338"},"comments":{"href":"https://api.github.com/repos/Catrobat/Catroid/issues/2338/comments"},"review_comments":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/2338/comments"},"review_comment":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/2338/commits"},"statuses":{"href":"https://api.github.com/repos/Catrobat/Catroid/statuses/7737c65498c7fcef95a1f2b2ecc8a397c1b047e2"}}}} | {
"id": 4475999,
"name": "Catrobat/Catroid",
"url": "https://api.github.com/repos/Catrobat/Catroid"
} | {
"id": 15098185,
"login": "84n4n4",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15098185?",
"url": "https://api.github.com/users/84n4n4"
} | {
"id": 1747223,
"login": "Catrobat",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1747223?",
"url": "https://api.github.com/orgs/Catrobat"
} | 2017-06-07T08:37:15 | 6017010066 | {"actor":{"display_login":"84n4n4"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Catrobat/Catroid/pulls/comments/120564412","pull_request_review_id":42535641,"id":120564412,"diff_hunk":"@@ -0,0 +1,99 @@\n+/*\n+ * Catroid: An on-device visual programming system for Android devices\n+ * Copyright (C) 2010-2017 The Catrobat Team\n+ * (<http://developer.catrobat.org/credits>)\n+ *\n+ * This program is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU Affero General Public License as\n+ * published by the Free Software Foundation, either version 3 of the\n+ * License, or (at your option) any later version.\n+ *\n+ * An additional term exception under section 7 of the GNU Affero\n+ * General Public License, version 3, is available at\n+ * http://developer.catrobat.org/license_additional_term\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+ * GNU Affero General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU Affero General Public License\n+ * along with this program. If not, see <http://www.gnu.org/licenses/>.\n+ */\n+\n+package org.catrobat.catroid.uiespresso.content.brick;\n+\n+import android.support.test.InstrumentationRegistry;\n+import android.support.test.runner.AndroidJUnit4;\n+\n+import org.catrobat.catroid.ProjectManager;\n+import org.catrobat.catroid.R;\n+import org.catrobat.catroid.common.SoundInfo;\n+import org.catrobat.catroid.content.Script;\n+import org.catrobat.catroid.content.bricks.PlaySoundAndWaitBrick;\n+import org.catrobat.catroid.ui.ScriptActivity;\n+import org.catrobat.catroid.uiespresso.content.brick.utils.BrickTestUtils;\n+import org.catrobat.catroid.uiespresso.util.BaseActivityInstrumentationRule;\n+import org.catrobat.catroid.uiespresso.util.FileTestUtils;\n+import org.catrobat.catroid.uiespresso.util.hardware.SensorTestArduinoServerConnection;\n+import org.junit.Before;\n+import org.junit.Rule;\n+import org.junit.Test;\n+import org.junit.runner.RunWith;\n+\n+import java.io.File;\n+import java.util.List;\n+\n+import static android.support.test.espresso.Espresso.onView;\n+import static android.support.test.espresso.action.ViewActions.click;\n+import static android.support.test.espresso.matcher.ViewMatchers.withId;\n+\n+import static org.catrobat.catroid.uiespresso.content.brick.utils.BrickTestUtils.checkIfBrickAtPositionShowsString;\n+\n+@RunWith(AndroidJUnit4.class)\n+public class AudioHardwareTest {\n+\tprivate int brickPosition;\n+\n+\tprivate String soundName = \"testSound1\";\n+\tprivate String projectName = \"testProject\";\n+\tprivate File soundFile;\n+\tprivate List<SoundInfo> soundInfoList;\n+\t@Rule\n+\tpublic BaseActivityInstrumentationRule<ScriptActivity> baseActivityTestRule = new\n+\t\t\tBaseActivityInstrumentationRule<>(ScriptActivity.class, true, false);\n+\n+\t@Before\n+\tpublic void setUp() throws Exception {\n+\t\tbrickPosition = 1;\n+\t\tScript script = BrickTestUtils.createProjectAndGetStartScript(projectName);","path":"catroid/src/androidTest/java/org/catrobat/catroid/uiespresso/content/brick/AudioHardwareTest.java","position":68,"original_position":68,"commit_id":"157363f3fbc0bfd0ee14bfb62e06bf876eba8e02","original_commit_id":"157363f3fbc0bfd0ee14bfb62e06bf876eba8e02","user":{"login":"84n4n4","id":15098185,"avatar_url":"https://avatars1.githubusercontent.com/u/15098185?v=3","gravatar_id":"","url":"https://api.github.com/users/84n4n4","html_url":"https://github.com/84n4n4","followers_url":"https://api.github.com/users/84n4n4/followers","following_url":"https://api.github.com/users/84n4n4/following{/other_user}","gists_url":"https://api.github.com/users/84n4n4/gists{/gist_id}","starred_url":"https://api.github.com/users/84n4n4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/84n4n4/subscriptions","organizations_url":"https://api.github.com/users/84n4n4/orgs","repos_url":"https://api.github.com/users/84n4n4/repos","events_url":"https://api.github.com/users/84n4n4/events{/privacy}","received_events_url":"https://api.github.com/users/84n4n4/received_events","type":"User","site_admin":false},"body":"please put this in a createProject method","created_at":"2017-06-07T08:32:48Z","updated_at":"2017-06-07T08:32:48Z","html_url":"https://github.com/Catrobat/Catroid/pull/2339#discussion_r120564412","pull_request_url":"https://api.github.com/repos/Catrobat/Catroid/pulls/2339","_links":{"self":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/comments/120564412"},"html":{"href":"https://github.com/Catrobat/Catroid/pull/2339#discussion_r120564412"},"pull_request":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/2339"}}},"pull_request":{"url":"https://api.github.com/repos/Catrobat/Catroid/pulls/2339","id":124350817,"html_url":"https://github.com/Catrobat/Catroid/pull/2339","diff_url":"https://github.com/Catrobat/Catroid/pull/2339.diff","patch_url":"https://github.com/Catrobat/Catroid/pull/2339.patch","issue_url":"https://api.github.com/repos/Catrobat/Catroid/issues/2339","number":2339,"state":"open","locked":false,"title":"CAT-XP6 [MH, PH] AudioHardwareTest","user":{"login":"xsoliah","id":17855771,"avatar_url":"https://avatars2.githubusercontent.com/u/17855771?v=3","gravatar_id":"","url":"https://api.github.com/users/xsoliah","html_url":"https://github.com/xsoliah","followers_url":"https://api.github.com/users/xsoliah/followers","following_url":"https://api.github.com/users/xsoliah/following{/other_user}","gists_url":"https://api.github.com/users/xsoliah/gists{/gist_id}","starred_url":"https://api.github.com/users/xsoliah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xsoliah/subscriptions","organizations_url":"https://api.github.com/users/xsoliah/orgs","repos_url":"https://api.github.com/users/xsoliah/repos","events_url":"https://api.github.com/users/xsoliah/events{/privacy}","received_events_url":"https://api.github.com/users/xsoliah/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-07T07:14:05Z","updated_at":"2017-06-07T08:32:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b03c489f60059e9ce830223fb6ad0a0811949904","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Catrobat/Catroid/pulls/2339/commits","review_comments_url":"https://api.github.com/repos/Catrobat/Catroid/pulls/2339/comments","review_comment_url":"https://api.github.com/repos/Catrobat/Catroid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Catrobat/Catroid/issues/2339/comments","statuses_url":"https://api.github.com/repos/Catrobat/Catroid/statuses/157363f3fbc0bfd0ee14bfb62e06bf876eba8e02","head":{"label":"xsoliah:AudioHardwareTest","ref":"AudioHardwareTest","sha":"157363f3fbc0bfd0ee14bfb62e06bf876eba8e02","user":{"login":"xsoliah","id":17855771,"avatar_url":"https://avatars2.githubusercontent.com/u/17855771?v=3","gravatar_id":"","url":"https://api.github.com/users/xsoliah","html_url":"https://github.com/xsoliah","followers_url":"https://api.github.com/users/xsoliah/followers","following_url":"https://api.github.com/users/xsoliah/following{/other_user}","gists_url":"https://api.github.com/users/xsoliah/gists{/gist_id}","starred_url":"https://api.github.com/users/xsoliah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xsoliah/subscriptions","organizations_url":"https://api.github.com/users/xsoliah/orgs","repos_url":"https://api.github.com/users/xsoliah/repos","events_url":"https://api.github.com/users/xsoliah/events{/privacy}","received_events_url":"https://api.github.com/users/xsoliah/received_events","type":"User","site_admin":false},"repo":{"id":85058003,"name":"Catroid","full_name":"xsoliah/Catroid","owner":{"login":"xsoliah","id":17855771,"avatar_url":"https://avatars2.githubusercontent.com/u/17855771?v=3","gravatar_id":"","url":"https://api.github.com/users/xsoliah","html_url":"https://github.com/xsoliah","followers_url":"https://api.github.com/users/xsoliah/followers","following_url":"https://api.github.com/users/xsoliah/following{/other_user}","gists_url":"https://api.github.com/users/xsoliah/gists{/gist_id}","starred_url":"https://api.github.com/users/xsoliah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xsoliah/subscriptions","organizations_url":"https://api.github.com/users/xsoliah/orgs","repos_url":"https://api.github.com/users/xsoliah/repos","events_url":"https://api.github.com/users/xsoliah/events{/privacy}","received_events_url":"https://api.github.com/users/xsoliah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xsoliah/Catroid","description":"Writing programs on an Android device without prior knowledge.","fork":true,"url":"https://api.github.com/repos/xsoliah/Catroid","forks_url":"https://api.github.com/repos/xsoliah/Catroid/forks","keys_url":"https://api.github.com/repos/xsoliah/Catroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xsoliah/Catroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xsoliah/Catroid/teams","hooks_url":"https://api.github.com/repos/xsoliah/Catroid/hooks","issue_events_url":"https://api.github.com/repos/xsoliah/Catroid/issues/events{/number}","events_url":"https://api.github.com/repos/xsoliah/Catroid/events","assignees_url":"https://api.github.com/repos/xsoliah/Catroid/assignees{/user}","branches_url":"https://api.github.com/repos/xsoliah/Catroid/branches{/branch}","tags_url":"https://api.github.com/repos/xsoliah/Catroid/tags","blobs_url":"https://api.github.com/repos/xsoliah/Catroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xsoliah/Catroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xsoliah/Catroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/xsoliah/Catroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xsoliah/Catroid/statuses/{sha}","languages_url":"https://api.github.com/repos/xsoliah/Catroid/languages","stargazers_url":"https://api.github.com/repos/xsoliah/Catroid/stargazers","contributors_url":"https://api.github.com/repos/xsoliah/Catroid/contributors","subscribers_url":"https://api.github.com/repos/xsoliah/Catroid/subscribers","subscription_url":"https://api.github.com/repos/xsoliah/Catroid/subscription","commits_url":"https://api.github.com/repos/xsoliah/Catroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/xsoliah/Catroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/xsoliah/Catroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/xsoliah/Catroid/issues/comments{/number}","contents_url":"https://api.github.com/repos/xsoliah/Catroid/contents/{+path}","compare_url":"https://api.github.com/repos/xsoliah/Catroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xsoliah/Catroid/merges","archive_url":"https://api.github.com/repos/xsoliah/Catroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xsoliah/Catroid/downloads","issues_url":"https://api.github.com/repos/xsoliah/Catroid/issues{/number}","pulls_url":"https://api.github.com/repos/xsoliah/Catroid/pulls{/number}","milestones_url":"https://api.github.com/repos/xsoliah/Catroid/milestones{/number}","notifications_url":"https://api.github.com/repos/xsoliah/Catroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xsoliah/Catroid/labels{/name}","releases_url":"https://api.github.com/repos/xsoliah/Catroid/releases{/id}","deployments_url":"https://api.github.com/repos/xsoliah/Catroid/deployments","created_at":"2017-03-15T10:12:52Z","updated_at":"2017-03-15T10:12:59Z","pushed_at":"2017-06-07T07:12:29Z","git_url":"git://github.com/xsoliah/Catroid.git","ssh_url":"[email protected]:xsoliah/Catroid.git","clone_url":"https://github.com/xsoliah/Catroid.git","svn_url":"https://github.com/xsoliah/Catroid","homepage":"https://share.catrob.at/pocketcode","size":143325,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Catrobat:feature/MobapTestRefactoring","ref":"feature/MobapTestRefactoring","sha":"d94bbadbf6f2635ff7937b78c7a7eb532829db8a","user":{"login":"Catrobat","id":1747223,"avatar_url":"https://avatars2.githubusercontent.com/u/1747223?v=3","gravatar_id":"","url":"https://api.github.com/users/Catrobat","html_url":"https://github.com/Catrobat","followers_url":"https://api.github.com/users/Catrobat/followers","following_url":"https://api.github.com/users/Catrobat/following{/other_user}","gists_url":"https://api.github.com/users/Catrobat/gists{/gist_id}","starred_url":"https://api.github.com/users/Catrobat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Catrobat/subscriptions","organizations_url":"https://api.github.com/users/Catrobat/orgs","repos_url":"https://api.github.com/users/Catrobat/repos","events_url":"https://api.github.com/users/Catrobat/events{/privacy}","received_events_url":"https://api.github.com/users/Catrobat/received_events","type":"Organization","site_admin":false},"repo":{"id":4475999,"name":"Catroid","full_name":"Catrobat/Catroid","owner":{"login":"Catrobat","id":1747223,"avatar_url":"https://avatars2.githubusercontent.com/u/1747223?v=3","gravatar_id":"","url":"https://api.github.com/users/Catrobat","html_url":"https://github.com/Catrobat","followers_url":"https://api.github.com/users/Catrobat/followers","following_url":"https://api.github.com/users/Catrobat/following{/other_user}","gists_url":"https://api.github.com/users/Catrobat/gists{/gist_id}","starred_url":"https://api.github.com/users/Catrobat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Catrobat/subscriptions","organizations_url":"https://api.github.com/users/Catrobat/orgs","repos_url":"https://api.github.com/users/Catrobat/repos","events_url":"https://api.github.com/users/Catrobat/events{/privacy}","received_events_url":"https://api.github.com/users/Catrobat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Catrobat/Catroid","description":"Writing programs on an Android device without prior knowledge.","fork":false,"url":"https://api.github.com/repos/Catrobat/Catroid","forks_url":"https://api.github.com/repos/Catrobat/Catroid/forks","keys_url":"https://api.github.com/repos/Catrobat/Catroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Catrobat/Catroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Catrobat/Catroid/teams","hooks_url":"https://api.github.com/repos/Catrobat/Catroid/hooks","issue_events_url":"https://api.github.com/repos/Catrobat/Catroid/issues/events{/number}","events_url":"https://api.github.com/repos/Catrobat/Catroid/events","assignees_url":"https://api.github.com/repos/Catrobat/Catroid/assignees{/user}","branches_url":"https://api.github.com/repos/Catrobat/Catroid/branches{/branch}","tags_url":"https://api.github.com/repos/Catrobat/Catroid/tags","blobs_url":"https://api.github.com/repos/Catrobat/Catroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Catrobat/Catroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Catrobat/Catroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/Catrobat/Catroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Catrobat/Catroid/statuses/{sha}","languages_url":"https://api.github.com/repos/Catrobat/Catroid/languages","stargazers_url":"https://api.github.com/repos/Catrobat/Catroid/stargazers","contributors_url":"https://api.github.com/repos/Catrobat/Catroid/contributors","subscribers_url":"https://api.github.com/repos/Catrobat/Catroid/subscribers","subscription_url":"https://api.github.com/repos/Catrobat/Catroid/subscription","commits_url":"https://api.github.com/repos/Catrobat/Catroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/Catrobat/Catroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/Catrobat/Catroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/Catrobat/Catroid/issues/comments{/number}","contents_url":"https://api.github.com/repos/Catrobat/Catroid/contents/{+path}","compare_url":"https://api.github.com/repos/Catrobat/Catroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Catrobat/Catroid/merges","archive_url":"https://api.github.com/repos/Catrobat/Catroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Catrobat/Catroid/downloads","issues_url":"https://api.github.com/repos/Catrobat/Catroid/issues{/number}","pulls_url":"https://api.github.com/repos/Catrobat/Catroid/pulls{/number}","milestones_url":"https://api.github.com/repos/Catrobat/Catroid/milestones{/number}","notifications_url":"https://api.github.com/repos/Catrobat/Catroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Catrobat/Catroid/labels{/name}","releases_url":"https://api.github.com/repos/Catrobat/Catroid/releases{/id}","deployments_url":"https://api.github.com/repos/Catrobat/Catroid/deployments","created_at":"2012-05-29T00:18:04Z","updated_at":"2017-05-25T13:30:31Z","pushed_at":"2017-06-07T07:14:06Z","git_url":"git://github.com/Catrobat/Catroid.git","ssh_url":"[email protected]:Catrobat/Catroid.git","clone_url":"https://github.com/Catrobat/Catroid.git","svn_url":"https://github.com/Catrobat/Catroid","homepage":"https://share.catrob.at/pocketcode","size":143414,"stargazers_count":150,"watchers_count":150,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":245,"mirror_url":null,"open_issues_count":142,"forks":245,"open_issues":142,"watchers":150,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/2339"},"html":{"href":"https://github.com/Catrobat/Catroid/pull/2339"},"issue":{"href":"https://api.github.com/repos/Catrobat/Catroid/issues/2339"},"comments":{"href":"https://api.github.com/repos/Catrobat/Catroid/issues/2339/comments"},"review_comments":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/2339/comments"},"review_comment":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/2339/commits"},"statuses":{"href":"https://api.github.com/repos/Catrobat/Catroid/statuses/157363f3fbc0bfd0ee14bfb62e06bf876eba8e02"}}}} | {
"id": 4475999,
"name": "Catrobat/Catroid",
"url": "https://api.github.com/repos/Catrobat/Catroid"
} | {
"id": 15098185,
"login": "84n4n4",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15098185?",
"url": "https://api.github.com/users/84n4n4"
} | {
"id": 1747223,
"login": "Catrobat",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1747223?",
"url": "https://api.github.com/orgs/Catrobat"
} | 2017-06-07T08:32:48 | 6016981272 | {"actor":{"display_login":"84n4n4"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/145138353","pull_request_review_id":69893309,"id":145138353,"diff_hunk":"@@ -100,18 +100,20 @@ def post_install\n end\n \n def caveats; <<-EOS.undent\n- If builds of PostgreSQL 9 are failing and you have version 8.x installed,\n+ If builds of PostgreSQL 10 are failing and you have version 8.x installed,","path":"Formula/postgresql.rb","position":16,"original_position":16,"commit_id":"0eed922c5d90ddddfcf3558bbe82bf39e04e6f64","original_commit_id":"0eed922c5d90ddddfcf3558bbe82bf39e04e6f64","user":{"login":"aleksandrs-ledovskis","id":2079110,"avatar_url":"https://avatars1.githubusercontent.com/u/2079110?v=4","gravatar_id":"","url":"https://api.github.com/users/aleksandrs-ledovskis","html_url":"https://github.com/aleksandrs-ledovskis","followers_url":"https://api.github.com/users/aleksandrs-ledovskis/followers","following_url":"https://api.github.com/users/aleksandrs-ledovskis/following{/other_user}","gists_url":"https://api.github.com/users/aleksandrs-ledovskis/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandrs-ledovskis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandrs-ledovskis/subscriptions","organizations_url":"https://api.github.com/users/aleksandrs-ledovskis/orgs","repos_url":"https://api.github.com/users/aleksandrs-ledovskis/repos","events_url":"https://api.github.com/users/aleksandrs-ledovskis/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandrs-ledovskis/received_events","type":"User","site_admin":false},"body":"`8.x` -> `9.x`? May need to check if is relevant at all","created_at":"2017-10-17T13:58:02Z","updated_at":"2017-10-17T14:03:25Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/19062#discussion_r145138353","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/19062","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/145138353"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/19062#discussion_r145138353"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/19062"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/19062","id":145058641,"html_url":"https://github.com/Homebrew/homebrew-core/pull/19062","diff_url":"https://github.com/Homebrew/homebrew-core/pull/19062.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/19062.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/19062","number":19062,"state":"open","locked":false,"title":"PostgreSQL 10.0 and 9.6 Versioned Formula","user":{"login":"felixbuenemann","id":909587,"avatar_url":"https://avatars0.githubusercontent.com/u/909587?v=4","gravatar_id":"","url":"https://api.github.com/users/felixbuenemann","html_url":"https://github.com/felixbuenemann","followers_url":"https://api.github.com/users/felixbuenemann/followers","following_url":"https://api.github.com/users/felixbuenemann/following{/other_user}","gists_url":"https://api.github.com/users/felixbuenemann/gists{/gist_id}","starred_url":"https://api.github.com/users/felixbuenemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixbuenemann/subscriptions","organizations_url":"https://api.github.com/users/felixbuenemann/orgs","repos_url":"https://api.github.com/users/felixbuenemann/repos","events_url":"https://api.github.com/users/felixbuenemann/events{/privacy}","received_events_url":"https://api.github.com/users/felixbuenemann/received_events","type":"User","site_admin":false},"body":"This PR bumps postgresql to 10.0 and add a versioned formula for `[email protected]`.\r\n\r\nI'm not sure wether it is correct to submit the versioned formula in the same commit, I can create a separate PR if you prefer.\r\n\r\n- [x] Have you followed the [guidelines for contributing](https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md)?\r\n- [x] Have you checked that there aren't other open [pull requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [x] Have you built your formula locally with `brew install --build-from-source <formula>`, where `<formula>` is the name of the formula you're submitting?\r\n- [x] Does your build pass `brew audit --strict <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n","created_at":"2017-10-06T02:02:27Z","updated_at":"2017-10-17T14:03:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb575c71cb097aa573f1b4b1fc02592cb9fd4980","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/19062/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/19062/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/19062/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/0eed922c5d90ddddfcf3558bbe82bf39e04e6f64","head":{"label":"felixbuenemann:postgres-10","ref":"postgres-10","sha":"0eed922c5d90ddddfcf3558bbe82bf39e04e6f64","user":{"login":"felixbuenemann","id":909587,"avatar_url":"https://avatars0.githubusercontent.com/u/909587?v=4","gravatar_id":"","url":"https://api.github.com/users/felixbuenemann","html_url":"https://github.com/felixbuenemann","followers_url":"https://api.github.com/users/felixbuenemann/followers","following_url":"https://api.github.com/users/felixbuenemann/following{/other_user}","gists_url":"https://api.github.com/users/felixbuenemann/gists{/gist_id}","starred_url":"https://api.github.com/users/felixbuenemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixbuenemann/subscriptions","organizations_url":"https://api.github.com/users/felixbuenemann/orgs","repos_url":"https://api.github.com/users/felixbuenemann/repos","events_url":"https://api.github.com/users/felixbuenemann/events{/privacy}","received_events_url":"https://api.github.com/users/felixbuenemann/received_events","type":"User","site_admin":false},"repo":{"id":56945371,"name":"homebrew-core","full_name":"felixbuenemann/homebrew-core","owner":{"login":"felixbuenemann","id":909587,"avatar_url":"https://avatars0.githubusercontent.com/u/909587?v=4","gravatar_id":"","url":"https://api.github.com/users/felixbuenemann","html_url":"https://github.com/felixbuenemann","followers_url":"https://api.github.com/users/felixbuenemann/followers","following_url":"https://api.github.com/users/felixbuenemann/following{/other_user}","gists_url":"https://api.github.com/users/felixbuenemann/gists{/gist_id}","starred_url":"https://api.github.com/users/felixbuenemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixbuenemann/subscriptions","organizations_url":"https://api.github.com/users/felixbuenemann/orgs","repos_url":"https://api.github.com/users/felixbuenemann/repos","events_url":"https://api.github.com/users/felixbuenemann/events{/privacy}","received_events_url":"https://api.github.com/users/felixbuenemann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/felixbuenemann/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":true,"url":"https://api.github.com/repos/felixbuenemann/homebrew-core","forks_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/forks","keys_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/teams","hooks_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/events","assignees_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/tags","blobs_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/subscription","commits_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/merges","archive_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/downloads","issues_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/felixbuenemann/homebrew-core/deployments","created_at":"2016-04-23T23:29:54Z","updated_at":"2016-04-23T23:30:07Z","pushed_at":"2017-10-09T14:21:49Z","git_url":"git://github.com/felixbuenemann/homebrew-core.git","ssh_url":"[email protected]:felixbuenemann/homebrew-core.git","clone_url":"https://github.com/felixbuenemann/homebrew-core.git","svn_url":"https://github.com/felixbuenemann/homebrew-core","homepage":"http://brew.sh","size":144184,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"51f1df7362765093c3a5cbae09e595c4a9dd4e21","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"name":"homebrew-core","full_name":"Homebrew/homebrew-core","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-core","description":"🍻 Default formulae for the missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2017-10-17T09:19:13Z","pushed_at":"2017-10-17T13:57:43Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"[email protected]:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"https://brew.sh","size":145290,"stargazers_count":2272,"watchers_count":2272,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3350,"mirror_url":null,"open_issues_count":112,"forks":3350,"open_issues":112,"watchers":2272,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/19062"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/19062"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/19062"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/19062/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/19062/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/19062/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/0eed922c5d90ddddfcf3558bbe82bf39e04e6f64"}},"author_association":"CONTRIBUTOR"}} | {
"id": 52855516,
"name": "Homebrew/homebrew-core",
"url": "https://api.github.com/repos/Homebrew/homebrew-core"
} | {
"id": 2079110,
"login": "aleksandrs-ledovskis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2079110?",
"url": "https://api.github.com/users/aleksandrs-ledovskis"
} | {
"id": 1503512,
"login": "Homebrew",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1503512?",
"url": "https://api.github.com/orgs/Homebrew"
} | 2017-10-17T13:58:02 | 6727529625 | {"actor":{"display_login":"aleksandrs-ledovskis"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/122653629","pull_request_review_id":44786425,"id":122653629,"diff_hunk":"@@ -0,0 +1,84 @@\n+class Stubby < Formula\n+ desc \"DNS privacy enabled stub resolver service based on getdns\"\n+ homepage \"https://getdnsapi.net/blog/dns-privacy-daemon-stubby/\"\n+ url \"https://getdnsapi.net/releases/getdns-1-1-1/getdns-1.1.1.tar.gz\"\n+ sha256 \"fa414c30d5f2d2b2453b5cec77362b4cc0f44d440be5893233748d82bd6a1a56\"\n+\n+ head do\n+ url \"https://github.com/getdnsapi/getdns.git\", :branch => \"develop\"\n+\n+ depends_on \"libtool\" => :build","path":"Formula/stubby.rb","position":10,"original_position":10,"commit_id":"4d6fde939b8d823347e20eb22a7ea3dd555eee66","original_commit_id":"4d6fde939b8d823347e20eb22a7ea3dd555eee66","user":{"login":"saradickinson","id":6229980,"avatar_url":"https://avatars1.githubusercontent.com/u/6229980?v=3","gravatar_id":"","url":"https://api.github.com/users/saradickinson","html_url":"https://github.com/saradickinson","followers_url":"https://api.github.com/users/saradickinson/followers","following_url":"https://api.github.com/users/saradickinson/following{/other_user}","gists_url":"https://api.github.com/users/saradickinson/gists{/gist_id}","starred_url":"https://api.github.com/users/saradickinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saradickinson/subscriptions","organizations_url":"https://api.github.com/users/saradickinson/orgs","repos_url":"https://api.github.com/users/saradickinson/repos","events_url":"https://api.github.com/users/saradickinson/events{/privacy}","received_events_url":"https://api.github.com/users/saradickinson/received_events","type":"User","site_admin":false},"body":"Is it that you want dependancies listed alphabetically? ","created_at":"2017-06-19T08:58:48Z","updated_at":"2017-06-19T08:58:48Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/14584#discussion_r122653629","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/14584","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/122653629"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/14584#discussion_r122653629"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/14584"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/14584","id":125577080,"html_url":"https://github.com/Homebrew/homebrew-core/pull/14584","diff_url":"https://github.com/Homebrew/homebrew-core/pull/14584.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/14584.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/14584","number":14584,"state":"open","locked":false,"title":"New stubby formula","user":{"login":"saradickinson","id":6229980,"avatar_url":"https://avatars1.githubusercontent.com/u/6229980?v=3","gravatar_id":"","url":"https://api.github.com/users/saradickinson","html_url":"https://github.com/saradickinson","followers_url":"https://api.github.com/users/saradickinson/followers","following_url":"https://api.github.com/users/saradickinson/following{/other_user}","gists_url":"https://api.github.com/users/saradickinson/gists{/gist_id}","starred_url":"https://api.github.com/users/saradickinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saradickinson/subscriptions","organizations_url":"https://api.github.com/users/saradickinson/orgs","repos_url":"https://api.github.com/users/saradickinson/repos","events_url":"https://api.github.com/users/saradickinson/events{/privacy}","received_events_url":"https://api.github.com/users/saradickinson/received_events","type":"User","site_admin":false},"body":"Please only review this pull request (do not merge yet) - it is awaiting the release of 1.1.1 production release this week! It currently uses a release candidate that contains some fixes to enable the formula to work. I would like to see if this passes the tests before updating it when the 1.1.1 production release is done.\r\n\r\n- [Y] Have you followed the [guidelines for contributing](https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md)?\r\n- [Y] Have you checked that there aren't other open [pull requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [Y] Have you built your formula locally with `brew install --build-from-source <formula>`, where `<formula>` is the name of the formula you're submitting?\r\n- [N] Does your build pass `brew audit --strict <formula>` (after doing `brew install <formula>`)?\r\n=> fails because uses rc1 release\r\n\r\n\r\n","created_at":"2017-06-14T11:55:05Z","updated_at":"2017-06-19T08:58:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5b567a2bc1c07e0805e2f3b08246fa91d12039d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/14584/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/14584/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/14584/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/4d6fde939b8d823347e20eb22a7ea3dd555eee66","head":{"label":"saradickinson:new_stubby_formula","ref":"new_stubby_formula","sha":"4d6fde939b8d823347e20eb22a7ea3dd555eee66","user":{"login":"saradickinson","id":6229980,"avatar_url":"https://avatars1.githubusercontent.com/u/6229980?v=3","gravatar_id":"","url":"https://api.github.com/users/saradickinson","html_url":"https://github.com/saradickinson","followers_url":"https://api.github.com/users/saradickinson/followers","following_url":"https://api.github.com/users/saradickinson/following{/other_user}","gists_url":"https://api.github.com/users/saradickinson/gists{/gist_id}","starred_url":"https://api.github.com/users/saradickinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saradickinson/subscriptions","organizations_url":"https://api.github.com/users/saradickinson/orgs","repos_url":"https://api.github.com/users/saradickinson/repos","events_url":"https://api.github.com/users/saradickinson/events{/privacy}","received_events_url":"https://api.github.com/users/saradickinson/received_events","type":"User","site_admin":false},"repo":{"id":92847393,"name":"homebrew-core","full_name":"saradickinson/homebrew-core","owner":{"login":"saradickinson","id":6229980,"avatar_url":"https://avatars1.githubusercontent.com/u/6229980?v=3","gravatar_id":"","url":"https://api.github.com/users/saradickinson","html_url":"https://github.com/saradickinson","followers_url":"https://api.github.com/users/saradickinson/followers","following_url":"https://api.github.com/users/saradickinson/following{/other_user}","gists_url":"https://api.github.com/users/saradickinson/gists{/gist_id}","starred_url":"https://api.github.com/users/saradickinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saradickinson/subscriptions","organizations_url":"https://api.github.com/users/saradickinson/orgs","repos_url":"https://api.github.com/users/saradickinson/repos","events_url":"https://api.github.com/users/saradickinson/events{/privacy}","received_events_url":"https://api.github.com/users/saradickinson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saradickinson/homebrew-core","description":"🍻 Default formulae for the missing package manager for macOS","fork":true,"url":"https://api.github.com/repos/saradickinson/homebrew-core","forks_url":"https://api.github.com/repos/saradickinson/homebrew-core/forks","keys_url":"https://api.github.com/repos/saradickinson/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saradickinson/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saradickinson/homebrew-core/teams","hooks_url":"https://api.github.com/repos/saradickinson/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/saradickinson/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/saradickinson/homebrew-core/events","assignees_url":"https://api.github.com/repos/saradickinson/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/saradickinson/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/saradickinson/homebrew-core/tags","blobs_url":"https://api.github.com/repos/saradickinson/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saradickinson/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saradickinson/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/saradickinson/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saradickinson/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/saradickinson/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/saradickinson/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/saradickinson/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/saradickinson/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/saradickinson/homebrew-core/subscription","commits_url":"https://api.github.com/repos/saradickinson/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/saradickinson/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/saradickinson/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/saradickinson/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/saradickinson/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/saradickinson/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saradickinson/homebrew-core/merges","archive_url":"https://api.github.com/repos/saradickinson/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saradickinson/homebrew-core/downloads","issues_url":"https://api.github.com/repos/saradickinson/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/saradickinson/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/saradickinson/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/saradickinson/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saradickinson/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/saradickinson/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/saradickinson/homebrew-core/deployments","created_at":"2017-05-30T15:26:55Z","updated_at":"2017-05-30T15:27:23Z","pushed_at":"2017-06-19T08:51:10Z","git_url":"git://github.com/saradickinson/homebrew-core.git","ssh_url":"[email protected]:saradickinson/homebrew-core.git","clone_url":"https://github.com/saradickinson/homebrew-core.git","svn_url":"https://github.com/saradickinson/homebrew-core","homepage":"https://brew.sh","size":123278,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"b4f5f667591ed133cbf48a972ed2912c507b4de1","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars1.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"name":"homebrew-core","full_name":"Homebrew/homebrew-core","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars1.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-core","description":"🍻 Default formulae for the missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2017-06-19T06:28:22Z","pushed_at":"2017-06-19T08:51:16Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"[email protected]:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"https://brew.sh","size":127455,"stargazers_count":1735,"watchers_count":1735,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2796,"mirror_url":null,"open_issues_count":77,"forks":2796,"open_issues":77,"watchers":1735,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/14584"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/14584"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/14584"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/14584/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/14584/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/14584/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/4d6fde939b8d823347e20eb22a7ea3dd555eee66"}}}} | {
"id": 52855516,
"name": "Homebrew/homebrew-core",
"url": "https://api.github.com/repos/Homebrew/homebrew-core"
} | {
"id": 6229980,
"login": "saradickinson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6229980?",
"url": "https://api.github.com/users/saradickinson"
} | {
"id": 1503512,
"login": "Homebrew",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1503512?",
"url": "https://api.github.com/orgs/Homebrew"
} | 2017-06-19T08:58:48 | 6090477295 | {"actor":{"display_login":"saradickinson"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/pulls/comments/133498404","pull_request_review_id":56686330,"id":133498404,"diff_hunk":"@@ -0,0 +1,56 @@\n+/*\n+ * Copyright (C) 2014 JFrog Ltd.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+import org.artifactory.fs.ItemInfo\n+import org.artifactory.repo.RepoPathFactory\n+\n+import groovy.transform.Field\n+\n+@Field final String PROPERTIES_FILE_PATH = \"plugins/${this.class.name}.properties\"\n+\n+def config = new ConfigSlurper().parse(new File(ctx.artifactoryHome.haAwareEtcDir, PROPERTIES_FILE_PATH).toURI().toURL())\n+def repositoriesMSCWR = [:]\n+\n+log.info \"Check 'Maven Snapshot Cleanup When Release' plugin repositories list: $config.repositories\"\n+\n+config.repositories.each{ repositorySettings ->\n+\n+ def release = repositorySettings[ 0 ] ? repositorySettings[ 0 ] as String : [\"undefined\"]\n+ def snapshot = repositorySettings[ 1 ] ? repositorySettings[ 1 ] as String : [\"undefined\"]\n+\n+ def releaseConfig = repositories.getRepositoryConfiguration(release)\n+ def sapshotConfig = repositories.getRepositoryConfiguration(snapshot)\n+\n+ if (releaseConfig && 'maven' == releaseConfig.getPackageType() && releaseConfig.isHandleReleases() && sapshotConfig && 'maven' == sapshotConfig.getPackageType() && sapshotConfig.isHandleSnapshots()){\n+ repositoriesMSCWR[ release ] = snapshot\n+ }else{\n+ log.error \"Skip repositories couple $release/$snapshot (does not exist or incorrect handle policy / package type)\"\n+ }\n+}\n+\n+storage {\n+ afterCreate { ItemInfo item ->","path":"cleanup/mavenSnapshotCleanupWhenRelease/mavenSnapshotCleanupWhenRelease.groovy","position":45,"original_position":45,"commit_id":"1bb124f9b9753d6de55da8a9227a5c4864953894","original_commit_id":"1bb124f9b9753d6de55da8a9227a5c4864953894","user":{"login":"elioengcomp","id":23169901,"avatar_url":"https://avatars2.githubusercontent.com/u/23169901?v=4","gravatar_id":"","url":"https://api.github.com/users/elioengcomp","html_url":"https://github.com/elioengcomp","followers_url":"https://api.github.com/users/elioengcomp/followers","following_url":"https://api.github.com/users/elioengcomp/following{/other_user}","gists_url":"https://api.github.com/users/elioengcomp/gists{/gist_id}","starred_url":"https://api.github.com/users/elioengcomp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elioengcomp/subscriptions","organizations_url":"https://api.github.com/users/elioengcomp/orgs","repos_url":"https://api.github.com/users/elioengcomp/repos","events_url":"https://api.github.com/users/elioengcomp/events{/privacy}","received_events_url":"https://api.github.com/users/elioengcomp/received_events","type":"User","site_admin":false},"body":"It was just something to think about. If it is not sustainable, just make sure to describe this behavior on the README file. ","created_at":"2017-08-16T16:21:03Z","updated_at":"2017-08-16T16:21:03Z","html_url":"https://github.com/JFrogDev/artifactory-user-plugins/pull/126#discussion_r133498404","pull_request_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/pulls/126","_links":{"self":{"href":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/pulls/comments/133498404"},"html":{"href":"https://github.com/JFrogDev/artifactory-user-plugins/pull/126#discussion_r133498404"},"pull_request":{"href":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/pulls/126"}}},"pull_request":{"url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/pulls/126","id":136036843,"html_url":"https://github.com/JFrogDev/artifactory-user-plugins/pull/126","diff_url":"https://github.com/JFrogDev/artifactory-user-plugins/pull/126.diff","patch_url":"https://github.com/JFrogDev/artifactory-user-plugins/pull/126.patch","issue_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/issues/126","number":126,"state":"open","locked":false,"title":"Maven Snapshot Cleanup When Release feature","user":{"login":"axel3rd","id":2912441,"avatar_url":"https://avatars3.githubusercontent.com/u/2912441?v=4","gravatar_id":"","url":"https://api.github.com/users/axel3rd","html_url":"https://github.com/axel3rd","followers_url":"https://api.github.com/users/axel3rd/followers","following_url":"https://api.github.com/users/axel3rd/following{/other_user}","gists_url":"https://api.github.com/users/axel3rd/gists{/gist_id}","starred_url":"https://api.github.com/users/axel3rd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axel3rd/subscriptions","organizations_url":"https://api.github.com/users/axel3rd/orgs","repos_url":"https://api.github.com/users/axel3rd/repos","events_url":"https://api.github.com/users/axel3rd/events{/privacy}","received_events_url":"https://api.github.com/users/axel3rd/received_events","type":"User","site_admin":false},"body":"For a Maven repository who handles snapshots, its size can hugly grow up with the time.\r\n\r\n[cleanup/artifactCleanup](https://github.com/JFrogDev/artifactory-user-plugins/tree/master/cleanup/artifactCleanup) could be a solution, but a better optimised process could be: **When a component is released, the snapshot should be deleted**.\r\n\r\nIn addition of deleting completely a snapshot when becomes useless, this process promotes the release version usage.\r\n\r\nThis PR is a proposal for this feature.","created_at":"2017-08-16T14:18:10Z","updated_at":"2017-08-16T16:21:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64deeddc46c71b9107c95026ec5973c53bba0b35","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/pulls/126/commits","review_comments_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/pulls/126/comments","review_comment_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/issues/126/comments","statuses_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/statuses/1bb124f9b9753d6de55da8a9227a5c4864953894","head":{"label":"axel3rd:MavenSnaphotDeleteWhenRelease","ref":"MavenSnaphotDeleteWhenRelease","sha":"1bb124f9b9753d6de55da8a9227a5c4864953894","user":{"login":"axel3rd","id":2912441,"avatar_url":"https://avatars3.githubusercontent.com/u/2912441?v=4","gravatar_id":"","url":"https://api.github.com/users/axel3rd","html_url":"https://github.com/axel3rd","followers_url":"https://api.github.com/users/axel3rd/followers","following_url":"https://api.github.com/users/axel3rd/following{/other_user}","gists_url":"https://api.github.com/users/axel3rd/gists{/gist_id}","starred_url":"https://api.github.com/users/axel3rd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axel3rd/subscriptions","organizations_url":"https://api.github.com/users/axel3rd/orgs","repos_url":"https://api.github.com/users/axel3rd/repos","events_url":"https://api.github.com/users/axel3rd/events{/privacy}","received_events_url":"https://api.github.com/users/axel3rd/received_events","type":"User","site_admin":false},"repo":{"id":99938025,"name":"artifactory-user-plugins","full_name":"axel3rd/artifactory-user-plugins","owner":{"login":"axel3rd","id":2912441,"avatar_url":"https://avatars3.githubusercontent.com/u/2912441?v=4","gravatar_id":"","url":"https://api.github.com/users/axel3rd","html_url":"https://github.com/axel3rd","followers_url":"https://api.github.com/users/axel3rd/followers","following_url":"https://api.github.com/users/axel3rd/following{/other_user}","gists_url":"https://api.github.com/users/axel3rd/gists{/gist_id}","starred_url":"https://api.github.com/users/axel3rd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axel3rd/subscriptions","organizations_url":"https://api.github.com/users/axel3rd/orgs","repos_url":"https://api.github.com/users/axel3rd/repos","events_url":"https://api.github.com/users/axel3rd/events{/privacy}","received_events_url":"https://api.github.com/users/axel3rd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/axel3rd/artifactory-user-plugins","description":"Sample Artifactory User Plugins","fork":true,"url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins","forks_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/forks","keys_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/teams","hooks_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/hooks","issue_events_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/events","assignees_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/tags","blobs_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/languages","stargazers_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/stargazers","contributors_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/contributors","subscribers_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/subscribers","subscription_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/subscription","commits_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/merges","archive_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/downloads","issues_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/labels{/name}","releases_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/axel3rd/artifactory-user-plugins/deployments","created_at":"2017-08-10T15:29:05Z","updated_at":"2017-08-10T15:29:07Z","pushed_at":"2017-08-16T14:12:09Z","git_url":"git://github.com/axel3rd/artifactory-user-plugins.git","ssh_url":"[email protected]:axel3rd/artifactory-user-plugins.git","clone_url":"https://github.com/axel3rd/artifactory-user-plugins.git","svn_url":"https://github.com/axel3rd/artifactory-user-plugins","homepage":"http://wiki.jfrog.org/confluence/display/RTF/User+Plugins","size":16955,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JFrogDev:master","ref":"master","sha":"47082307227539b60c3b4fc5161e4791fc164189","user":{"login":"JFrogDev","id":499942,"avatar_url":"https://avatars0.githubusercontent.com/u/499942?v=4","gravatar_id":"","url":"https://api.github.com/users/JFrogDev","html_url":"https://github.com/JFrogDev","followers_url":"https://api.github.com/users/JFrogDev/followers","following_url":"https://api.github.com/users/JFrogDev/following{/other_user}","gists_url":"https://api.github.com/users/JFrogDev/gists{/gist_id}","starred_url":"https://api.github.com/users/JFrogDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JFrogDev/subscriptions","organizations_url":"https://api.github.com/users/JFrogDev/orgs","repos_url":"https://api.github.com/users/JFrogDev/repos","events_url":"https://api.github.com/users/JFrogDev/events{/privacy}","received_events_url":"https://api.github.com/users/JFrogDev/received_events","type":"Organization","site_admin":false},"repo":{"id":2574768,"name":"artifactory-user-plugins","full_name":"JFrogDev/artifactory-user-plugins","owner":{"login":"JFrogDev","id":499942,"avatar_url":"https://avatars0.githubusercontent.com/u/499942?v=4","gravatar_id":"","url":"https://api.github.com/users/JFrogDev","html_url":"https://github.com/JFrogDev","followers_url":"https://api.github.com/users/JFrogDev/followers","following_url":"https://api.github.com/users/JFrogDev/following{/other_user}","gists_url":"https://api.github.com/users/JFrogDev/gists{/gist_id}","starred_url":"https://api.github.com/users/JFrogDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JFrogDev/subscriptions","organizations_url":"https://api.github.com/users/JFrogDev/orgs","repos_url":"https://api.github.com/users/JFrogDev/repos","events_url":"https://api.github.com/users/JFrogDev/events{/privacy}","received_events_url":"https://api.github.com/users/JFrogDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JFrogDev/artifactory-user-plugins","description":"Sample Artifactory User Plugins","fork":false,"url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins","forks_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/forks","keys_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/teams","hooks_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/hooks","issue_events_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/events","assignees_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/tags","blobs_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/languages","stargazers_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/stargazers","contributors_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/contributors","subscribers_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/subscribers","subscription_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/subscription","commits_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/merges","archive_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/downloads","issues_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/labels{/name}","releases_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/deployments","created_at":"2011-10-14T07:20:20Z","updated_at":"2017-08-14T13:19:32Z","pushed_at":"2017-08-16T14:18:11Z","git_url":"git://github.com/JFrogDev/artifactory-user-plugins.git","ssh_url":"[email protected]:JFrogDev/artifactory-user-plugins.git","clone_url":"https://github.com/JFrogDev/artifactory-user-plugins.git","svn_url":"https://github.com/JFrogDev/artifactory-user-plugins","homepage":"http://wiki.jfrog.org/confluence/display/RTF/User+Plugins","size":17278,"stargazers_count":102,"watchers_count":102,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"open_issues_count":20,"forks":124,"open_issues":20,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/pulls/126"},"html":{"href":"https://github.com/JFrogDev/artifactory-user-plugins/pull/126"},"issue":{"href":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/issues/126"},"comments":{"href":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/JFrogDev/artifactory-user-plugins/statuses/1bb124f9b9753d6de55da8a9227a5c4864953894"}}}} | {
"id": 2574768,
"name": "JFrogDev/artifactory-user-plugins",
"url": "https://api.github.com/repos/JFrogDev/artifactory-user-plugins"
} | {
"id": 23169901,
"login": "elioengcomp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23169901?",
"url": "https://api.github.com/users/elioengcomp"
} | {
"id": 499942,
"login": "JFrogDev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/499942?",
"url": "https://api.github.com/orgs/JFrogDev"
} | 2017-08-16T16:21:03 | 6465063194 | {"actor":{"display_login":"elioengcomp"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/LSSTDESC/descqa/pulls/comments/158184988","pull_request_review_id":84954102,"id":158184988,"diff_hunk":"@@ -0,0 +1,353 @@\n+from __future__ import print_function, division, unicode_literals, absolute_import\n+import os\n+import math\n+try:\n+ from itertools import zip_longest\n+except ImportError:\n+ from itertools import izip_longest as zip_longest\n+\n+import numpy as np\n+from GCR import GCRQuery\n+\n+from .base import BaseValidationTest, TestResult\n+from .plotting import plt\n+from itertools import cycle\n+from itertools import count\n+\n+__all__ = ['StellarMassFunction']\n+\n+\n+class StellarMassFunction(BaseValidationTest):\n+ \"\"\"\n+ validation test to show N(z) distributions\n+ \"\"\"\n+ #setup dict with parameters needed to read in validation data\n+ possible_observations = {\n+ 'PRIMUS_2013': {\n+ 'filename_template': 'SMF/moustakas_et_al_2013/Table{}.txt',\n+ 'file-info': {'0. < z < .1':{'zlo':0., 'zhi':.1, 'table#':3, 'usecols':[0,1,2,3]},\n+ '.2 < z < .3':{'zlo':.2, 'zhi':.3, 'table#':4, 'usecols':[0,1,2,3]},\n+ '.3 < z < .4':{'zlo':.3, 'zhi':.4, 'table#':4, 'usecols':[0,6,7,8]},\n+ '.4 < z < .5':{'zlo':.4, 'zhi':.5, 'table#':4, 'usecols':[0,11,12,13]},\n+ '.5 < z < .65':{'zlo':.5, 'zhi':.65, 'table#':4, 'usecols':[0,16,17,18]},\n+ '.65 < z < .8':{'zlo':.65, 'zhi':.8, 'table#':4, 'usecols':[0,21,22,23]},\n+ '.8 < z < 1.0':{'zlo':.8, 'zhi':1.0, 'table#':4, 'usecols':[0,26,27,28]},\n+ },\n+ 'zrange': (0.0, 1.0),\n+ 'colnames': ('logM', 'log_phi', 'dlog_phi+', 'dlog_phi-'),\n+ 'label': 'Moustakas et. al. 2013',\n+ 'missingdata':'...'\n+ },\n+ }\n+ zkey_match ='< z <'\n+\n+ #plotting constants\n+ validation_color = 'black'\n+ validation_marker = 'o'\n+ default_markers = ['v', 's', 'd', 'H', '^', 'D', 'h', '<', '>', '.']\n+ msize = 4 #marker-size\n+\n+ def __init__(self, z='redshift_true', mass='stellar_mass', Nbins=25, log_Mlo=8., log_Mhi=12.,\n+ observation='', zlo=0., zhi=1.0, zint =0.2, ncolumns=2, **kwargs):\n+\n+ #catalog quantities\n+ self.zlabel = z\n+ self.Mlabel = mass\n+\n+ #z-range and mass binning\n+ self.Nbins = Nbins\n+ self.log_Mlo = log_Mlo\n+ self.log_Mhi = log_Mhi\n+ self.Mbins = np.logspace(log_Mlo, log_Mhi, Nbins+1)\n+ self.DM = (log_Mhi - log_Mlo)/Nbins\n+\n+ #validation data\n+ self.validation_data = {}\n+ self.observation = observation\n+\n+ #check for valid observations\n+ if not observation:\n+ print('Warning: no data file supplied, no observation requested; only catalog data will be shown')\n+ elif observation not in self.possible_observations:\n+ raise ValueError('Observation {} not available'.format(observation))\n+ else:\n+ self.validation_data = self.get_validation_data(observation)\n+\n+ #plotting variables\n+ self.ncolumns = int(ncolumns)\n+ self._color_iterator = ('C{}'.format(i) for i in count())\n+\n+ #setup subplot configuration and get z cuts for each plot\n+ self.z_lo, self.z_hi = self.init_plots(zlo, zhi, zint)\n+ zmin = np.min(self.z_lo)\n+ zmax = np.max(self.z_hi)\n+ self.filters = [(lambda z: (z > zmin) & (z < zmax), self.zlabel)]\n+\n+ #setup summary plot\n+ self.summary_fig, self.summary_ax = plt.subplots(self.nrows, self.ncolumns, sharex='col')\n+ self.summary_fig.text(0.04, 0.5, self.yaxis, va='center', rotation='vertical') #setup a common axis label\n+ #could plot summary validation data here if available but would need to evaluate labels, bin values etc.\n+ #otherwise setup a check so that validation data is plotted only once on summary plot\n+ self.first_pass = True\n+\n+ self._other_kwargs = kwargs\n+\n+\n+ def init_plots(self, zlo, zhi, zint):\n+ #get magnitude cuts based on validation data or default limits (only catalog data plotted)\n+ if len(self.validation_data )> 0:\n+ z_lo = [self.validation_data[k].get('zlo') for k in self.validation_data.keys() if self.zkey_match in k]\n+ z_hi = [self.validation_data[k].get('zhi') for k in self.validation_data.keys() if self.zkey_match in k]\n+ else:\n+ z_lo = np.arange(zlo, zhi, zint)\n+ z_hi = np.arange(zint, zhi+zint, zint)\n+\n+ #setup number of plots and number of rows required for subplots\n+ self.nplots = len(z_lo)\n+ self.nrows = (self.nplots+self.ncolumns-1)//self.ncolumns\n+\n+ #other plotting variables\n+ self.markers = iter(self.default_markers)\n+ self.yaxis = '$d\\phi/d\\log M (Mpc^{-3} dex^{-1})$'\n+ self.xaxis = '$M^*$'\n+\n+ #custom sizes for ticklabels (sorry Yao - need these)\n+ plt.rcParams['xtick.labelsize'] = 8\n+ plt.rcParams['ytick.labelsize'] = 8\n+\n+ return z_lo, z_hi\n+\n+\n+ def get_validation_data(self, observation):\n+ \n+ data_args = self.possible_observations[observation]\n+ validation_data = {'label':data_args['label']}\n+\n+ file_args = data_args['file-info']\n+ for zkey in file_args.keys():\n+ filename = self.possible_observations[observation]['filename_template'].format(file_args[zkey]['table#'])\n+ data_path = os.path.join(self.data_dir, filename)\n+ if not os.path.exists(data_path):\n+ raise ValueError(\"SMF data file {} not found\".format(data_path))\n+ if not os.path.getsize(data_path):\n+ raise ValueError(\"SMF data file {} is empty\".format(data_path))\n+\n+ data = np.genfromtxt(data_path, unpack=True, usecols=file_args[zkey]['usecols'], missing_values=data_args['missingdata'])\n+ validation_data[zkey] = dict(zip(data_args['colnames'], data))\n+ validation_data[zkey]['zlo'] = file_args[zkey]['zlo']\n+ validation_data[zkey]['zhi'] = file_args[zkey]['zhi']\n+\n+ return validation_data\n+\n+\n+ def run_on_single_catalog(self, catalog_instance, catalog_name, output_dir):\n+ #update color and marker to preserve catalog colors and markers across tests\n+ catalog_color = next(self._color_iterator)\n+ catalog_marker= next(self.markers)\n+\n+ #check catalog data for required quantities\n+ if not catalog_instance.has_quantities([self.zlabel,self.Mlabel]):\n+ return TestResult(skipped=True, summary='Missing required quantity {} or {}'.format(self.zlabel, self.Mlabel))\n+\n+ #setup plots\n+ fig, ax = plt.subplots(self.nrows, self.ncolumns, sharex='col')\n+ fig.text(0.04, 0.5, self.yaxis, va='center', rotation='vertical') #setup a common axis label\n+\n+ #initialize arrays for storing histogram sums\n+ N_array = np.zeros((self.nrows, self.ncolumns, len(self.Mbins)-1), dtype=np.int)\n+ sumM_array = np.zeros((self.nrows, self.ncolumns,len(self.Mbins)-1))\n+ sumM2_array = np.zeros((self.nrows, self.ncolumns,len(self.Mbins)-1))\n+\n+ #get catalog data by looping over data iterator (needed for large catalogs) and aggregate histograms\n+ for catalog_data in catalog_instance.get_quantities([self.zlabel, self.Mlabel], filters=self.filters, return_iterator=True):\n+ catalog_data = GCRQuery(*((np.isfinite, col) for col in catalog_data)).filter(catalog_data)\n+ for cut_lo, cut_hi, N, sumM, sumM2 in zip_longest(\n+ self.z_lo,\n+ self.z_hi, \n+ N_array.reshape(-1, N_array.shape[-1]), #flatten all but last dimension of array\n+ sumM_array.reshape(-1, sumM_array.shape[-1]),\n+ sumM2_array.reshape(-1, sumM2_array.shape[-1]),\n+ ):\n+ if cut_lo is not None: #cut_lo can be 0. so cannot use if cut_lo\n+ mask = (cut_lo < catalog_data[self.zlabel]) & (catalog_data[self.zlabel] < cut_hi)\n+ M_this = catalog_data[self.Mlabel][mask]\n+ del mask\n+\n+ #bin catalog_data and accumulate subplot histograms\n+ N += np.histogram(M_this, bins=self.Mbins)[0]\n+ sumM += np.histogram(M_this, bins=self.Mbins, weights=M_this)[0]\n+ sumM2 += np.histogram(M_this, bins=self.Mbins, weights=M_this**2)[0]\n+\n+ if not N.sum():\n+ return TestResult(skipped=True, summary='No data found for quantity {}'.format(self.Mlabel))\n+\n+ #loop over magnitude cuts and make plots\n+ results = {}\n+ for n, (ax_this, summary_ax_this, cut_lo, cut_hi, N, sumM, sumM2, zkey) in enumerate(zip_longest(\n+ ax.flat,\n+ self.summary_ax.flat,\n+ self.z_lo,\n+ self.z_hi,\n+ N_array.reshape(-1, N_array.shape[-1]),\n+ sumM_array.reshape(-1, sumM_array.shape[-1]),\n+ sumM2_array.reshape(-1, sumM2_array.shape[-1]),\n+ [k for k in self.validation_data.keys() if self.zkey_match in k],\n+ )):\n+ if cut_lo is None: #cut_lo is None if self.z_lo is exhausted\n+ ax_this.set_visible(False)\n+ summary_ax_this.set_visible(False)\n+ else:\n+ cut_label = '${}$'.format(zkey)\n+ Mvalues = self.get_opt_binpoints(N, sumM, sumM2, self.Mbins)\n+ sumN = N.sum()\n+ total = '(# of galaxies = {})'.format(sumN)\n+ Nerrors = np.sqrt(N)\n+ volume = self.get_sky_volume(catalog_instance, cut_hi, zlo=cut_lo)\n+ phi = N/volume/self.DM\n+ phi_errors = Nerrors/volume/self.DM\n+\n+ #make subplot\n+ validation_label = self.validation_data.get('label', '')\n+ results[zkey] = {'Mphi':Mvalues, 'total':total, 'phi':phi, 'phi+-':phi_errors}\n+ self.catalog_subplot(ax_this, Mvalues, phi, phi_errors, catalog_color, catalog_name)\n+ if zkey in self.validation_data.keys(): \n+ data = self.validation_subplot(ax_this, self.validation_data[zkey], validation_label)\n+ results[zkey].update(data)\n+ self.decorate_subplot(ax_this, n, label=cut_label)\n+\n+ #add curve for this catalog to summary plot\n+ self.catalog_subplot(summary_ax_this, Mvalues, phi, phi_errors, catalog_color, catalog_name)\n+ if self.first_pass and zkey in self.validation_data.keys(): #add validation data if evaluating first catalog\n+ self.validation_subplot(summary_ax_this, self.validation_data[zkey], validation_label)\n+ self.decorate_subplot(summary_ax_this, n, label=cut_label)\n+\n+ \n+ #save results for catalog and validation data in txt files\n+ for filename, dtype, info in zip_longest((catalog_name, self.observation), ('phi', 'data'), ('total',)):\n+ if filename:\n+ with open(os.path.join(output_dir, 'SMF_' + filename + '.txt'), 'ab') as f_handle: #open file in append mode\n+ #loop over magnitude cuts in results dict\n+ for key, value in results.items():\n+ self.save_quantities(dtype, value, f_handle, comment=' '.join((key, value.get(info, ''))))\n+\n+ if self.first_pass: #turn off validation data plot in summary for remaining catalogs\n+ self.first_pass = False\n+\n+ #make final adjustments to plots and save figure\n+ self.post_process_plot(fig)\n+ fig.savefig(os.path.join(output_dir, 'SMF_' + catalog_name + '.png'))\n+ plt.close(fig)\n+ return TestResult(0, passed=True)\n+\n+\n+ def catalog_subplot(self, ax, M, phi, phi_errors, catalog_color, catalog_label):\n+\n+ ax.plot(M, phi, label=catalog_label, color=catalog_color)\n+ ax.fill_between(M, phi - phi_errors, phi + phi_errors, alpha=0.3, facecolor=catalog_color)\n+\n+\n+ def validation_subplot(self, ax, validation_data, validation_label):\n+\n+ results={}\n+ if all(x in validation_data.keys() for x in ('logM', 'log_phi', 'dlog_phi+', 'dlog_phi-')):\n+ M = np.power(10, validation_data['logM'])\n+ phi = np.power(10, validation_data['log_phi'])\n+ dphi_hi = np.power(10, validation_data['log_phi'] + validation_data['dlog_phi+']) - phi\n+ dphi_lo = -np.power(10, validation_data['log_phi'] + validation_data['dlog_phi-']) + phi\n+ ax.errorbar(M, phi, yerr=[dphi_lo,dphi_hi], color=self.validation_color, marker=self.validation_marker, label=validation_label, ms=self.msize)\n+ results['data']=phi\n+ results['Mdata']=M\n+ results['data+'] = dphi_hi\n+ results['data-'] = dphi_lo\n+ else:\n+ raise ValueError(\"Missing expected validation-data quantitites\")\n+\n+ return results\n+\n+\n+ def decorate_subplot(self, ax, nplot, label=None):\n+ ax.set_xscale('log')\n+ ax.set_yscale('log')\n+ if label:\n+ ax.text(0.95, 0.95, label, horizontalalignment='right', verticalalignment='top', transform=ax.transAxes) \n+\n+ #add axes and legend\n+ if nplot+1 <= self.nplots-self.ncolumns: #x scales for last ncol plots only\n+ #print \"noticks\",nplot\n+ for axlabel in ax.get_xticklabels():\n+ axlabel.set_visible(False)\n+ #prevent overlapping yaxis labels\n+ ax.yaxis.get_major_ticks()[0].label1.set_visible(False)\n+ else:\n+ ax.set_xlabel(self.xaxis)\n+ for axlabel in ax.get_xticklabels():\n+ axlabel.set_visible(True)\n+ ax.legend(loc='best', fancybox=True, framealpha=0.5, numpoints=1)\n+\n+\n+ @staticmethod\n+ def post_process_plot(fig):\n+ fig.subplots_adjust(hspace=0)\n+\n+\n+ @staticmethod\n+ def save_quantities(keyname, results, filename, comment=''):\n+ if keyname in results:\n+ if keyname+'-' in results and keyname+'+' in results:\n+ fields = ('M'+keyname, keyname, keyname+'-', keyname+'+')\n+ header = ', '.join(('Data columns are: <M>', keyname, keyname+'-', keyname+'+', ' '))\n+ elif keyname+'+-' in results:\n+ fields = ('M'+keyname, keyname, keyname+'+-')\n+ header = ', '.join(('Data columns are: <M>', keyname, keyname+'+-',' '))\n+ else:\n+ fields = ('M'+keyname, keyname)\n+ header = ', '.join(('Data columns are: <M>', keyname, ' '))\n+ np.savetxt(filename, np.vstack((results[k] for k in fields)).T, fmt='%12.4e', header=header+comment)\n+\n+\n+ def conclude_test(self, output_dir):\n+ self.post_process_plot(self.summary_fig)\n+ self.summary_fig.savefig(os.path.join(output_dir, 'summary.png'))\n+ plt.close(self.summary_fig)\n+\n+\n+ @staticmethod\n+ def get_sky_volume(catalog_instance, zhi, zlo=0., distance='Mpc'):\n+ from astropy.cosmology import FlatLambdaCDM","path":"descqa/StellarMassFunction.py","position":316,"original_position":316,"commit_id":"ca965e2718e9c9c5ca0a5cade01b57b081a80e69","original_commit_id":"ca965e2718e9c9c5ca0a5cade01b57b081a80e69","user":{"login":"yymao","id":3792659,"avatar_url":"https://avatars1.githubusercontent.com/u/3792659?v=4","gravatar_id":"","url":"https://api.github.com/users/yymao","html_url":"https://github.com/yymao","followers_url":"https://api.github.com/users/yymao/followers","following_url":"https://api.github.com/users/yymao/following{/other_user}","gists_url":"https://api.github.com/users/yymao/gists{/gist_id}","starred_url":"https://api.github.com/users/yymao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yymao/subscriptions","organizations_url":"https://api.github.com/users/yymao/orgs","repos_url":"https://api.github.com/users/yymao/repos","events_url":"https://api.github.com/users/yymao/events{/privacy}","received_events_url":"https://api.github.com/users/yymao/received_events","type":"User","site_admin":false},"body":"Move import statement to the beginning of the module","created_at":"2017-12-21T02:27:10Z","updated_at":"2017-12-21T02:40:21Z","html_url":"https://github.com/LSSTDESC/descqa/pull/51#discussion_r158184988","pull_request_url":"https://api.github.com/repos/LSSTDESC/descqa/pulls/51","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/LSSTDESC/descqa/pulls/comments/158184988"},"html":{"href":"https://github.com/LSSTDESC/descqa/pull/51#discussion_r158184988"},"pull_request":{"href":"https://api.github.com/repos/LSSTDESC/descqa/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/LSSTDESC/descqa/pulls/51","id":159546655,"html_url":"https://github.com/LSSTDESC/descqa/pull/51","diff_url":"https://github.com/LSSTDESC/descqa/pull/51.diff","patch_url":"https://github.com/LSSTDESC/descqa/pull/51.patch","issue_url":"https://api.github.com/repos/LSSTDESC/descqa/issues/51","number":51,"state":"open","locked":false,"title":"Stellar mass function test","user":{"login":"evevkovacs","id":7797837,"avatar_url":"https://avatars2.githubusercontent.com/u/7797837?v=4","gravatar_id":"","url":"https://api.github.com/users/evevkovacs","html_url":"https://github.com/evevkovacs","followers_url":"https://api.github.com/users/evevkovacs/followers","following_url":"https://api.github.com/users/evevkovacs/following{/other_user}","gists_url":"https://api.github.com/users/evevkovacs/gists{/gist_id}","starred_url":"https://api.github.com/users/evevkovacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evevkovacs/subscriptions","organizations_url":"https://api.github.com/users/evevkovacs/orgs","repos_url":"https://api.github.com/users/evevkovacs/repos","events_url":"https://api.github.com/users/evevkovacs/events{/privacy}","received_events_url":"https://api.github.com/users/evevkovacs/received_events","type":"User","site_admin":false},"body":"The last 2 functions in the test could go into a utilities module as they are more generally useful.","created_at":"2017-12-21T00:03:22Z","updated_at":"2017-12-21T02:40:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5dadcba9d411861b3e00974463c1dcd99ce7bef","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/LSSTDESC/descqa/pulls/51/commits","review_comments_url":"https://api.github.com/repos/LSSTDESC/descqa/pulls/51/comments","review_comment_url":"https://api.github.com/repos/LSSTDESC/descqa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LSSTDESC/descqa/issues/51/comments","statuses_url":"https://api.github.com/repos/LSSTDESC/descqa/statuses/ca965e2718e9c9c5ca0a5cade01b57b081a80e69","head":{"label":"evevkovacs:smf_test","ref":"smf_test","sha":"ca965e2718e9c9c5ca0a5cade01b57b081a80e69","user":{"login":"evevkovacs","id":7797837,"avatar_url":"https://avatars2.githubusercontent.com/u/7797837?v=4","gravatar_id":"","url":"https://api.github.com/users/evevkovacs","html_url":"https://github.com/evevkovacs","followers_url":"https://api.github.com/users/evevkovacs/followers","following_url":"https://api.github.com/users/evevkovacs/following{/other_user}","gists_url":"https://api.github.com/users/evevkovacs/gists{/gist_id}","starred_url":"https://api.github.com/users/evevkovacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evevkovacs/subscriptions","organizations_url":"https://api.github.com/users/evevkovacs/orgs","repos_url":"https://api.github.com/users/evevkovacs/repos","events_url":"https://api.github.com/users/evevkovacs/events{/privacy}","received_events_url":"https://api.github.com/users/evevkovacs/received_events","type":"User","site_admin":false},"repo":{"id":110601877,"name":"descqa","full_name":"evevkovacs/descqa","owner":{"login":"evevkovacs","id":7797837,"avatar_url":"https://avatars2.githubusercontent.com/u/7797837?v=4","gravatar_id":"","url":"https://api.github.com/users/evevkovacs","html_url":"https://github.com/evevkovacs","followers_url":"https://api.github.com/users/evevkovacs/followers","following_url":"https://api.github.com/users/evevkovacs/following{/other_user}","gists_url":"https://api.github.com/users/evevkovacs/gists{/gist_id}","starred_url":"https://api.github.com/users/evevkovacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evevkovacs/subscriptions","organizations_url":"https://api.github.com/users/evevkovacs/orgs","repos_url":"https://api.github.com/users/evevkovacs/repos","events_url":"https://api.github.com/users/evevkovacs/events{/privacy}","received_events_url":"https://api.github.com/users/evevkovacs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evevkovacs/descqa","description":"Validation framework for mock galaxy catalogs","fork":true,"url":"https://api.github.com/repos/evevkovacs/descqa","forks_url":"https://api.github.com/repos/evevkovacs/descqa/forks","keys_url":"https://api.github.com/repos/evevkovacs/descqa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evevkovacs/descqa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evevkovacs/descqa/teams","hooks_url":"https://api.github.com/repos/evevkovacs/descqa/hooks","issue_events_url":"https://api.github.com/repos/evevkovacs/descqa/issues/events{/number}","events_url":"https://api.github.com/repos/evevkovacs/descqa/events","assignees_url":"https://api.github.com/repos/evevkovacs/descqa/assignees{/user}","branches_url":"https://api.github.com/repos/evevkovacs/descqa/branches{/branch}","tags_url":"https://api.github.com/repos/evevkovacs/descqa/tags","blobs_url":"https://api.github.com/repos/evevkovacs/descqa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evevkovacs/descqa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evevkovacs/descqa/git/refs{/sha}","trees_url":"https://api.github.com/repos/evevkovacs/descqa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evevkovacs/descqa/statuses/{sha}","languages_url":"https://api.github.com/repos/evevkovacs/descqa/languages","stargazers_url":"https://api.github.com/repos/evevkovacs/descqa/stargazers","contributors_url":"https://api.github.com/repos/evevkovacs/descqa/contributors","subscribers_url":"https://api.github.com/repos/evevkovacs/descqa/subscribers","subscription_url":"https://api.github.com/repos/evevkovacs/descqa/subscription","commits_url":"https://api.github.com/repos/evevkovacs/descqa/commits{/sha}","git_commits_url":"https://api.github.com/repos/evevkovacs/descqa/git/commits{/sha}","comments_url":"https://api.github.com/repos/evevkovacs/descqa/comments{/number}","issue_comment_url":"https://api.github.com/repos/evevkovacs/descqa/issues/comments{/number}","contents_url":"https://api.github.com/repos/evevkovacs/descqa/contents/{+path}","compare_url":"https://api.github.com/repos/evevkovacs/descqa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evevkovacs/descqa/merges","archive_url":"https://api.github.com/repos/evevkovacs/descqa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evevkovacs/descqa/downloads","issues_url":"https://api.github.com/repos/evevkovacs/descqa/issues{/number}","pulls_url":"https://api.github.com/repos/evevkovacs/descqa/pulls{/number}","milestones_url":"https://api.github.com/repos/evevkovacs/descqa/milestones{/number}","notifications_url":"https://api.github.com/repos/evevkovacs/descqa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evevkovacs/descqa/labels{/name}","releases_url":"https://api.github.com/repos/evevkovacs/descqa/releases{/id}","deployments_url":"https://api.github.com/repos/evevkovacs/descqa/deployments","created_at":"2017-11-13T21:03:37Z","updated_at":"2017-11-20T23:38:55Z","pushed_at":"2017-12-21T00:01:27Z","git_url":"git://github.com/evevkovacs/descqa.git","ssh_url":"[email protected]:evevkovacs/descqa.git","clone_url":"https://github.com/evevkovacs/descqa.git","svn_url":"https://github.com/evevkovacs/descqa","homepage":"https://portal.nersc.gov/project/lsst/descqa/v2/www/","size":26022,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LSSTDESC:master","ref":"master","sha":"734d977b78078589a2b9af6460115ee0448144e3","user":{"login":"LSSTDESC","id":2731443,"avatar_url":"https://avatars1.githubusercontent.com/u/2731443?v=4","gravatar_id":"","url":"https://api.github.com/users/LSSTDESC","html_url":"https://github.com/LSSTDESC","followers_url":"https://api.github.com/users/LSSTDESC/followers","following_url":"https://api.github.com/users/LSSTDESC/following{/other_user}","gists_url":"https://api.github.com/users/LSSTDESC/gists{/gist_id}","starred_url":"https://api.github.com/users/LSSTDESC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LSSTDESC/subscriptions","organizations_url":"https://api.github.com/users/LSSTDESC/orgs","repos_url":"https://api.github.com/users/LSSTDESC/repos","events_url":"https://api.github.com/users/LSSTDESC/events{/privacy}","received_events_url":"https://api.github.com/users/LSSTDESC/received_events","type":"Organization","site_admin":false},"repo":{"id":47784041,"name":"descqa","full_name":"LSSTDESC/descqa","owner":{"login":"LSSTDESC","id":2731443,"avatar_url":"https://avatars1.githubusercontent.com/u/2731443?v=4","gravatar_id":"","url":"https://api.github.com/users/LSSTDESC","html_url":"https://github.com/LSSTDESC","followers_url":"https://api.github.com/users/LSSTDESC/followers","following_url":"https://api.github.com/users/LSSTDESC/following{/other_user}","gists_url":"https://api.github.com/users/LSSTDESC/gists{/gist_id}","starred_url":"https://api.github.com/users/LSSTDESC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LSSTDESC/subscriptions","organizations_url":"https://api.github.com/users/LSSTDESC/orgs","repos_url":"https://api.github.com/users/LSSTDESC/repos","events_url":"https://api.github.com/users/LSSTDESC/events{/privacy}","received_events_url":"https://api.github.com/users/LSSTDESC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LSSTDESC/descqa","description":"Validation framework for mock galaxy catalogs","fork":false,"url":"https://api.github.com/repos/LSSTDESC/descqa","forks_url":"https://api.github.com/repos/LSSTDESC/descqa/forks","keys_url":"https://api.github.com/repos/LSSTDESC/descqa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LSSTDESC/descqa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LSSTDESC/descqa/teams","hooks_url":"https://api.github.com/repos/LSSTDESC/descqa/hooks","issue_events_url":"https://api.github.com/repos/LSSTDESC/descqa/issues/events{/number}","events_url":"https://api.github.com/repos/LSSTDESC/descqa/events","assignees_url":"https://api.github.com/repos/LSSTDESC/descqa/assignees{/user}","branches_url":"https://api.github.com/repos/LSSTDESC/descqa/branches{/branch}","tags_url":"https://api.github.com/repos/LSSTDESC/descqa/tags","blobs_url":"https://api.github.com/repos/LSSTDESC/descqa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LSSTDESC/descqa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LSSTDESC/descqa/git/refs{/sha}","trees_url":"https://api.github.com/repos/LSSTDESC/descqa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LSSTDESC/descqa/statuses/{sha}","languages_url":"https://api.github.com/repos/LSSTDESC/descqa/languages","stargazers_url":"https://api.github.com/repos/LSSTDESC/descqa/stargazers","contributors_url":"https://api.github.com/repos/LSSTDESC/descqa/contributors","subscribers_url":"https://api.github.com/repos/LSSTDESC/descqa/subscribers","subscription_url":"https://api.github.com/repos/LSSTDESC/descqa/subscription","commits_url":"https://api.github.com/repos/LSSTDESC/descqa/commits{/sha}","git_commits_url":"https://api.github.com/repos/LSSTDESC/descqa/git/commits{/sha}","comments_url":"https://api.github.com/repos/LSSTDESC/descqa/comments{/number}","issue_comment_url":"https://api.github.com/repos/LSSTDESC/descqa/issues/comments{/number}","contents_url":"https://api.github.com/repos/LSSTDESC/descqa/contents/{+path}","compare_url":"https://api.github.com/repos/LSSTDESC/descqa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LSSTDESC/descqa/merges","archive_url":"https://api.github.com/repos/LSSTDESC/descqa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LSSTDESC/descqa/downloads","issues_url":"https://api.github.com/repos/LSSTDESC/descqa/issues{/number}","pulls_url":"https://api.github.com/repos/LSSTDESC/descqa/pulls{/number}","milestones_url":"https://api.github.com/repos/LSSTDESC/descqa/milestones{/number}","notifications_url":"https://api.github.com/repos/LSSTDESC/descqa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LSSTDESC/descqa/labels{/name}","releases_url":"https://api.github.com/repos/LSSTDESC/descqa/releases{/id}","deployments_url":"https://api.github.com/repos/LSSTDESC/descqa/deployments","created_at":"2015-12-10T19:53:20Z","updated_at":"2017-12-14T15:58:24Z","pushed_at":"2017-12-21T00:03:23Z","git_url":"git://github.com/LSSTDESC/descqa.git","ssh_url":"[email protected]:LSSTDESC/descqa.git","clone_url":"https://github.com/LSSTDESC/descqa.git","svn_url":"https://github.com/LSSTDESC/descqa","homepage":"https://portal.nersc.gov/project/lsst/descqa/","size":26028,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":23,"license":null,"forks":9,"open_issues":23,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LSSTDESC/descqa/pulls/51"},"html":{"href":"https://github.com/LSSTDESC/descqa/pull/51"},"issue":{"href":"https://api.github.com/repos/LSSTDESC/descqa/issues/51"},"comments":{"href":"https://api.github.com/repos/LSSTDESC/descqa/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/LSSTDESC/descqa/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/LSSTDESC/descqa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LSSTDESC/descqa/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/LSSTDESC/descqa/statuses/ca965e2718e9c9c5ca0a5cade01b57b081a80e69"}},"author_association":"COLLABORATOR"}} | {
"id": 47784041,
"name": "LSSTDESC/descqa",
"url": "https://api.github.com/repos/LSSTDESC/descqa"
} | {
"id": 3792659,
"login": "yymao",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3792659?",
"url": "https://api.github.com/users/yymao"
} | {
"id": 2731443,
"login": "LSSTDESC",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2731443?",
"url": "https://api.github.com/orgs/LSSTDESC"
} | 2017-12-21T02:27:10 | 7016291903 | {"actor":{"display_login":"yymao"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/MPAS-Dev/geometric_features/pulls/comments/135602844","pull_request_review_id":59032541,"id":135602844,"diff_hunk":"@@ -0,0 +1,198 @@\n+#!/usr/bin/env python\n+\n+\"\"\"\n+This script creates region groups for ice shelves\n+","path":"driver_scripts/setup_ice_shelves.py","position":5,"original_position":5,"commit_id":"a8ca44082871ff63d2ebadecb95a2db123d7c7ec","original_commit_id":"a8ca44082871ff63d2ebadecb95a2db123d7c7ec","user":{"login":"stephenprice","id":4983771,"avatar_url":"https://avatars2.githubusercontent.com/u/4983771?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenprice","html_url":"https://github.com/stephenprice","followers_url":"https://api.github.com/users/stephenprice/followers","following_url":"https://api.github.com/users/stephenprice/following{/other_user}","gists_url":"https://api.github.com/users/stephenprice/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenprice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenprice/subscriptions","organizations_url":"https://api.github.com/users/stephenprice/orgs","repos_url":"https://api.github.com/users/stephenprice/repos","events_url":"https://api.github.com/users/stephenprice/events{/privacy}","received_events_url":"https://api.github.com/users/stephenprice/received_events","type":"User","site_admin":false},"body":"I don't know if it is worth noting in the comments here that this script needs to be run from the root level directory of 'geometric_features'? Perhaps that is already implied by all of the scripts that sit in the 'driver_scripts' subdir?","created_at":"2017-08-28T18:49:57Z","updated_at":"2017-08-28T18:49:57Z","html_url":"https://github.com/MPAS-Dev/geometric_features/pull/90#discussion_r135602844","pull_request_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/pulls/90","_links":{"self":{"href":"https://api.github.com/repos/MPAS-Dev/geometric_features/pulls/comments/135602844"},"html":{"href":"https://github.com/MPAS-Dev/geometric_features/pull/90#discussion_r135602844"},"pull_request":{"href":"https://api.github.com/repos/MPAS-Dev/geometric_features/pulls/90"}}},"pull_request":{"url":"https://api.github.com/repos/MPAS-Dev/geometric_features/pulls/90","id":137751862,"html_url":"https://github.com/MPAS-Dev/geometric_features/pull/90","diff_url":"https://github.com/MPAS-Dev/geometric_features/pull/90.diff","patch_url":"https://github.com/MPAS-Dev/geometric_features/pull/90.patch","issue_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/issues/90","number":90,"state":"open","locked":false,"title":"Add driver script for merging ice-shelf features","user":{"login":"xylar","id":4179064,"avatar_url":"https://avatars0.githubusercontent.com/u/4179064?v=4","gravatar_id":"","url":"https://api.github.com/users/xylar","html_url":"https://github.com/xylar","followers_url":"https://api.github.com/users/xylar/followers","following_url":"https://api.github.com/users/xylar/following{/other_user}","gists_url":"https://api.github.com/users/xylar/gists{/gist_id}","starred_url":"https://api.github.com/users/xylar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xylar/subscriptions","organizations_url":"https://api.github.com/users/xylar/orgs","repos_url":"https://api.github.com/users/xylar/repos","events_url":"https://api.github.com/users/xylar/events{/privacy}","received_events_url":"https://api.github.com/users/xylar/received_events","type":"User","site_admin":false},"body":"This driver merges together regions to make up 100 individual ice shelves (some of which are divided into multiple region files because they cross several IMBIE basins) and 6 analysis regions (currently: Antarctica, Peninsula, West Antarctica, East Antarctica, Filchner-Ronne and Ross).\r\n\r\nThe resulting file can be used to create masks for computing ice-shelf time series for individual ice shelves.","created_at":"2017-08-25T20:33:29Z","updated_at":"2017-08-28T18:49:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9beecc75a82007efd479470a894bfa9f213360e2","assignee":{"login":"xylar","id":4179064,"avatar_url":"https://avatars0.githubusercontent.com/u/4179064?v=4","gravatar_id":"","url":"https://api.github.com/users/xylar","html_url":"https://github.com/xylar","followers_url":"https://api.github.com/users/xylar/followers","following_url":"https://api.github.com/users/xylar/following{/other_user}","gists_url":"https://api.github.com/users/xylar/gists{/gist_id}","starred_url":"https://api.github.com/users/xylar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xylar/subscriptions","organizations_url":"https://api.github.com/users/xylar/orgs","repos_url":"https://api.github.com/users/xylar/repos","events_url":"https://api.github.com/users/xylar/events{/privacy}","received_events_url":"https://api.github.com/users/xylar/received_events","type":"User","site_admin":false},"assignees":[{"login":"xylar","id":4179064,"avatar_url":"https://avatars0.githubusercontent.com/u/4179064?v=4","gravatar_id":"","url":"https://api.github.com/users/xylar","html_url":"https://github.com/xylar","followers_url":"https://api.github.com/users/xylar/followers","following_url":"https://api.github.com/users/xylar/following{/other_user}","gists_url":"https://api.github.com/users/xylar/gists{/gist_id}","starred_url":"https://api.github.com/users/xylar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xylar/subscriptions","organizations_url":"https://api.github.com/users/xylar/orgs","repos_url":"https://api.github.com/users/xylar/repos","events_url":"https://api.github.com/users/xylar/events{/privacy}","received_events_url":"https://api.github.com/users/xylar/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/pulls/90/commits","review_comments_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/pulls/90/comments","review_comment_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/issues/90/comments","statuses_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/statuses/a8ca44082871ff63d2ebadecb95a2db123d7c7ec","head":{"label":"xylar:add_ice_shelf_driver","ref":"add_ice_shelf_driver","sha":"a8ca44082871ff63d2ebadecb95a2db123d7c7ec","user":{"login":"xylar","id":4179064,"avatar_url":"https://avatars0.githubusercontent.com/u/4179064?v=4","gravatar_id":"","url":"https://api.github.com/users/xylar","html_url":"https://github.com/xylar","followers_url":"https://api.github.com/users/xylar/followers","following_url":"https://api.github.com/users/xylar/following{/other_user}","gists_url":"https://api.github.com/users/xylar/gists{/gist_id}","starred_url":"https://api.github.com/users/xylar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xylar/subscriptions","organizations_url":"https://api.github.com/users/xylar/orgs","repos_url":"https://api.github.com/users/xylar/repos","events_url":"https://api.github.com/users/xylar/events{/privacy}","received_events_url":"https://api.github.com/users/xylar/received_events","type":"User","site_admin":false},"repo":{"id":50114596,"name":"geometric_features","full_name":"xylar/geometric_features","owner":{"login":"xylar","id":4179064,"avatar_url":"https://avatars0.githubusercontent.com/u/4179064?v=4","gravatar_id":"","url":"https://api.github.com/users/xylar","html_url":"https://github.com/xylar","followers_url":"https://api.github.com/users/xylar/followers","following_url":"https://api.github.com/users/xylar/following{/other_user}","gists_url":"https://api.github.com/users/xylar/gists{/gist_id}","starred_url":"https://api.github.com/users/xylar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xylar/subscriptions","organizations_url":"https://api.github.com/users/xylar/orgs","repos_url":"https://api.github.com/users/xylar/repos","events_url":"https://api.github.com/users/xylar/events{/privacy}","received_events_url":"https://api.github.com/users/xylar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xylar/geometric_features","description":"This repository will house geometric features relevant for climate science.","fork":true,"url":"https://api.github.com/repos/xylar/geometric_features","forks_url":"https://api.github.com/repos/xylar/geometric_features/forks","keys_url":"https://api.github.com/repos/xylar/geometric_features/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xylar/geometric_features/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xylar/geometric_features/teams","hooks_url":"https://api.github.com/repos/xylar/geometric_features/hooks","issue_events_url":"https://api.github.com/repos/xylar/geometric_features/issues/events{/number}","events_url":"https://api.github.com/repos/xylar/geometric_features/events","assignees_url":"https://api.github.com/repos/xylar/geometric_features/assignees{/user}","branches_url":"https://api.github.com/repos/xylar/geometric_features/branches{/branch}","tags_url":"https://api.github.com/repos/xylar/geometric_features/tags","blobs_url":"https://api.github.com/repos/xylar/geometric_features/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xylar/geometric_features/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xylar/geometric_features/git/refs{/sha}","trees_url":"https://api.github.com/repos/xylar/geometric_features/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xylar/geometric_features/statuses/{sha}","languages_url":"https://api.github.com/repos/xylar/geometric_features/languages","stargazers_url":"https://api.github.com/repos/xylar/geometric_features/stargazers","contributors_url":"https://api.github.com/repos/xylar/geometric_features/contributors","subscribers_url":"https://api.github.com/repos/xylar/geometric_features/subscribers","subscription_url":"https://api.github.com/repos/xylar/geometric_features/subscription","commits_url":"https://api.github.com/repos/xylar/geometric_features/commits{/sha}","git_commits_url":"https://api.github.com/repos/xylar/geometric_features/git/commits{/sha}","comments_url":"https://api.github.com/repos/xylar/geometric_features/comments{/number}","issue_comment_url":"https://api.github.com/repos/xylar/geometric_features/issues/comments{/number}","contents_url":"https://api.github.com/repos/xylar/geometric_features/contents/{+path}","compare_url":"https://api.github.com/repos/xylar/geometric_features/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xylar/geometric_features/merges","archive_url":"https://api.github.com/repos/xylar/geometric_features/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xylar/geometric_features/downloads","issues_url":"https://api.github.com/repos/xylar/geometric_features/issues{/number}","pulls_url":"https://api.github.com/repos/xylar/geometric_features/pulls{/number}","milestones_url":"https://api.github.com/repos/xylar/geometric_features/milestones{/number}","notifications_url":"https://api.github.com/repos/xylar/geometric_features/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xylar/geometric_features/labels{/name}","releases_url":"https://api.github.com/repos/xylar/geometric_features/releases{/id}","deployments_url":"https://api.github.com/repos/xylar/geometric_features/deployments","created_at":"2016-01-21T14:54:48Z","updated_at":"2016-01-21T20:48:30Z","pushed_at":"2017-08-25T20:26:32Z","git_url":"git://github.com/xylar/geometric_features.git","ssh_url":"[email protected]:xylar/geometric_features.git","clone_url":"https://github.com/xylar/geometric_features.git","svn_url":"https://github.com/xylar/geometric_features","homepage":null,"size":70785,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MPAS-Dev:master","ref":"master","sha":"c7feb8d42e641d48bbfbb821f74923dc0b42ee58","user":{"login":"MPAS-Dev","id":4063217,"avatar_url":"https://avatars0.githubusercontent.com/u/4063217?v=4","gravatar_id":"","url":"https://api.github.com/users/MPAS-Dev","html_url":"https://github.com/MPAS-Dev","followers_url":"https://api.github.com/users/MPAS-Dev/followers","following_url":"https://api.github.com/users/MPAS-Dev/following{/other_user}","gists_url":"https://api.github.com/users/MPAS-Dev/gists{/gist_id}","starred_url":"https://api.github.com/users/MPAS-Dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MPAS-Dev/subscriptions","organizations_url":"https://api.github.com/users/MPAS-Dev/orgs","repos_url":"https://api.github.com/users/MPAS-Dev/repos","events_url":"https://api.github.com/users/MPAS-Dev/events{/privacy}","received_events_url":"https://api.github.com/users/MPAS-Dev/received_events","type":"Organization","site_admin":false},"repo":{"id":41449790,"name":"geometric_features","full_name":"MPAS-Dev/geometric_features","owner":{"login":"MPAS-Dev","id":4063217,"avatar_url":"https://avatars0.githubusercontent.com/u/4063217?v=4","gravatar_id":"","url":"https://api.github.com/users/MPAS-Dev","html_url":"https://github.com/MPAS-Dev","followers_url":"https://api.github.com/users/MPAS-Dev/followers","following_url":"https://api.github.com/users/MPAS-Dev/following{/other_user}","gists_url":"https://api.github.com/users/MPAS-Dev/gists{/gist_id}","starred_url":"https://api.github.com/users/MPAS-Dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MPAS-Dev/subscriptions","organizations_url":"https://api.github.com/users/MPAS-Dev/orgs","repos_url":"https://api.github.com/users/MPAS-Dev/repos","events_url":"https://api.github.com/users/MPAS-Dev/events{/privacy}","received_events_url":"https://api.github.com/users/MPAS-Dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MPAS-Dev/geometric_features","description":"This repository will house geometric features relevant for climate science.","fork":false,"url":"https://api.github.com/repos/MPAS-Dev/geometric_features","forks_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/forks","keys_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/teams","hooks_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/hooks","issue_events_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/issues/events{/number}","events_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/events","assignees_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/assignees{/user}","branches_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/branches{/branch}","tags_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/tags","blobs_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/git/refs{/sha}","trees_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/statuses/{sha}","languages_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/languages","stargazers_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/stargazers","contributors_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/contributors","subscribers_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/subscribers","subscription_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/subscription","commits_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/commits{/sha}","git_commits_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/git/commits{/sha}","comments_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/comments{/number}","issue_comment_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/issues/comments{/number}","contents_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/contents/{+path}","compare_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/merges","archive_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/downloads","issues_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/issues{/number}","pulls_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/pulls{/number}","milestones_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/milestones{/number}","notifications_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/labels{/name}","releases_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/releases{/id}","deployments_url":"https://api.github.com/repos/MPAS-Dev/geometric_features/deployments","created_at":"2015-08-26T21:04:07Z","updated_at":"2017-06-30T14:06:26Z","pushed_at":"2017-08-25T20:33:29Z","git_url":"git://github.com/MPAS-Dev/geometric_features.git","ssh_url":"[email protected]:MPAS-Dev/geometric_features.git","clone_url":"https://github.com/MPAS-Dev/geometric_features.git","svn_url":"https://github.com/MPAS-Dev/geometric_features","homepage":null,"size":69526,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":13,"forks":8,"open_issues":13,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MPAS-Dev/geometric_features/pulls/90"},"html":{"href":"https://github.com/MPAS-Dev/geometric_features/pull/90"},"issue":{"href":"https://api.github.com/repos/MPAS-Dev/geometric_features/issues/90"},"comments":{"href":"https://api.github.com/repos/MPAS-Dev/geometric_features/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/MPAS-Dev/geometric_features/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/MPAS-Dev/geometric_features/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MPAS-Dev/geometric_features/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/MPAS-Dev/geometric_features/statuses/a8ca44082871ff63d2ebadecb95a2db123d7c7ec"}}}} | {
"id": 41449790,
"name": "MPAS-Dev/geometric_features",
"url": "https://api.github.com/repos/MPAS-Dev/geometric_features"
} | {
"id": 4983771,
"login": "stephenprice",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4983771?",
"url": "https://api.github.com/users/stephenprice"
} | {
"id": 4063217,
"login": "MPAS-Dev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4063217?",
"url": "https://api.github.com/orgs/MPAS-Dev"
} | 2017-08-28T18:49:57 | 6521012266 | {"actor":{"display_login":"stephenprice"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/ovirt/pulls/comments/135319228","pull_request_review_id":58723810,"id":135319228,"diff_hunk":"@@ -467,5 +464,21 @@ def full_version\n v = v.sub(\"-\", \".\").split(\".\")[0..3]\n Hash[[:major, :minor, :revision, :build].zip(v)]\n end\n+\n+ #\n+ # Returns a file object containing the trusted CA certificates. The file will be created if it\n+ # doesn't exist, and it shouldn't be removed or modified by the caller.\n+ #\n+ # @return [File] The temporary file containing the trusted CA certificates, or nil if no custom\n+ # CA certificates are used by the connection.\n+ #\n+ def ca_file\n+ if !@ca_file && @ca_certs","path":"lib/ovirt/service.rb","position":50,"original_position":50,"commit_id":"9017c5c580aaa056ba4274344afa6b556bada011","original_commit_id":"9017c5c580aaa056ba4274344afa6b556bada011","user":{"login":"jhernand","id":1423971,"avatar_url":"https://avatars3.githubusercontent.com/u/1423971?v=4","gravatar_id":"","url":"https://api.github.com/users/jhernand","html_url":"https://github.com/jhernand","followers_url":"https://api.github.com/users/jhernand/followers","following_url":"https://api.github.com/users/jhernand/following{/other_user}","gists_url":"https://api.github.com/users/jhernand/gists{/gist_id}","starred_url":"https://api.github.com/users/jhernand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhernand/subscriptions","organizations_url":"https://api.github.com/users/jhernand/orgs","repos_url":"https://api.github.com/users/jhernand/repos","events_url":"https://api.github.com/users/jhernand/events{/privacy}","received_events_url":"https://api.github.com/users/jhernand/received_events","type":"User","site_admin":false},"body":"Yes, that makes sense, I am changing it, thanks @bdunne.","created_at":"2017-08-25T18:04:00Z","updated_at":"2017-08-25T18:04:00Z","html_url":"https://github.com/ManageIQ/ovirt/pull/88#discussion_r135319228","pull_request_url":"https://api.github.com/repos/ManageIQ/ovirt/pulls/88","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/ovirt/pulls/comments/135319228"},"html":{"href":"https://github.com/ManageIQ/ovirt/pull/88#discussion_r135319228"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/ovirt/pulls/88"}},"in_reply_to_id":135318671},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/ovirt/pulls/88","id":137630086,"html_url":"https://github.com/ManageIQ/ovirt/pull/88","diff_url":"https://github.com/ManageIQ/ovirt/pull/88.diff","patch_url":"https://github.com/ManageIQ/ovirt/pull/88.patch","issue_url":"https://api.github.com/repos/ManageIQ/ovirt/issues/88","number":88,"state":"open","locked":false,"title":"Create trusted CA certificates file when needed","user":{"login":"jhernand","id":1423971,"avatar_url":"https://avatars3.githubusercontent.com/u/1423971?v=4","gravatar_id":"","url":"https://api.github.com/users/jhernand","html_url":"https://github.com/jhernand","followers_url":"https://api.github.com/users/jhernand/followers","following_url":"https://api.github.com/users/jhernand/following{/other_user}","gists_url":"https://api.github.com/users/jhernand/gists{/gist_id}","starred_url":"https://api.github.com/users/jhernand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhernand/subscriptions","organizations_url":"https://api.github.com/users/jhernand/orgs","repos_url":"https://api.github.com/users/jhernand/repos","events_url":"https://api.github.com/users/jhernand/events{/privacy}","received_events_url":"https://api.github.com/users/jhernand/received_events","type":"User","site_admin":false},"body":"Currently the gem creates the temporary file contining the trusted CA\r\ncertificates when the 'Service' class is instantiated, and removes it\r\nwhen the 'disconnect' method is called. But there are situations where\r\nthe instance is used *after* the 'disconnect' method has been called. In\r\nthose situations the trusted CA certificates won't be available, and the\r\nconnection will fail. To avoid that problem this patch changes the\r\n'Service' class so that the temporary file is created when needed,\r\nregardless of when the 'disconnect' method is called.\r\n\r\nThis patch addresses the following bug:\r\n\r\n Service order request for VM provision from template fail on SSL Certificate verification\r\n https://bugzilla.redhat.com/1483303","created_at":"2017-08-25T09:08:59Z","updated_at":"2017-08-25T18:04:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7abc4110961295073889b7c45642511b0e4b0164","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/ovirt/pulls/88/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/ovirt/pulls/88/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/ovirt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/ovirt/issues/88/comments","statuses_url":"https://api.github.com/repos/ManageIQ/ovirt/statuses/9017c5c580aaa056ba4274344afa6b556bada011","head":{"label":"jhernand:create_ca_trusted_certificates_file_when_needed","ref":"create_ca_trusted_certificates_file_when_needed","sha":"9017c5c580aaa056ba4274344afa6b556bada011","user":{"login":"jhernand","id":1423971,"avatar_url":"https://avatars3.githubusercontent.com/u/1423971?v=4","gravatar_id":"","url":"https://api.github.com/users/jhernand","html_url":"https://github.com/jhernand","followers_url":"https://api.github.com/users/jhernand/followers","following_url":"https://api.github.com/users/jhernand/following{/other_user}","gists_url":"https://api.github.com/users/jhernand/gists{/gist_id}","starred_url":"https://api.github.com/users/jhernand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhernand/subscriptions","organizations_url":"https://api.github.com/users/jhernand/orgs","repos_url":"https://api.github.com/users/jhernand/repos","events_url":"https://api.github.com/users/jhernand/events{/privacy}","received_events_url":"https://api.github.com/users/jhernand/received_events","type":"User","site_admin":false},"repo":{"id":54486776,"name":"ovirt","full_name":"jhernand/ovirt","owner":{"login":"jhernand","id":1423971,"avatar_url":"https://avatars3.githubusercontent.com/u/1423971?v=4","gravatar_id":"","url":"https://api.github.com/users/jhernand","html_url":"https://github.com/jhernand","followers_url":"https://api.github.com/users/jhernand/followers","following_url":"https://api.github.com/users/jhernand/following{/other_user}","gists_url":"https://api.github.com/users/jhernand/gists{/gist_id}","starred_url":"https://api.github.com/users/jhernand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhernand/subscriptions","organizations_url":"https://api.github.com/users/jhernand/orgs","repos_url":"https://api.github.com/users/jhernand/repos","events_url":"https://api.github.com/users/jhernand/events{/privacy}","received_events_url":"https://api.github.com/users/jhernand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhernand/ovirt","description":"Ovirt provides a simple Object Oriented interface to the REST API of oVirt and RHEV-M servers","fork":true,"url":"https://api.github.com/repos/jhernand/ovirt","forks_url":"https://api.github.com/repos/jhernand/ovirt/forks","keys_url":"https://api.github.com/repos/jhernand/ovirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhernand/ovirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhernand/ovirt/teams","hooks_url":"https://api.github.com/repos/jhernand/ovirt/hooks","issue_events_url":"https://api.github.com/repos/jhernand/ovirt/issues/events{/number}","events_url":"https://api.github.com/repos/jhernand/ovirt/events","assignees_url":"https://api.github.com/repos/jhernand/ovirt/assignees{/user}","branches_url":"https://api.github.com/repos/jhernand/ovirt/branches{/branch}","tags_url":"https://api.github.com/repos/jhernand/ovirt/tags","blobs_url":"https://api.github.com/repos/jhernand/ovirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhernand/ovirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhernand/ovirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhernand/ovirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhernand/ovirt/statuses/{sha}","languages_url":"https://api.github.com/repos/jhernand/ovirt/languages","stargazers_url":"https://api.github.com/repos/jhernand/ovirt/stargazers","contributors_url":"https://api.github.com/repos/jhernand/ovirt/contributors","subscribers_url":"https://api.github.com/repos/jhernand/ovirt/subscribers","subscription_url":"https://api.github.com/repos/jhernand/ovirt/subscription","commits_url":"https://api.github.com/repos/jhernand/ovirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhernand/ovirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhernand/ovirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhernand/ovirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhernand/ovirt/contents/{+path}","compare_url":"https://api.github.com/repos/jhernand/ovirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhernand/ovirt/merges","archive_url":"https://api.github.com/repos/jhernand/ovirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhernand/ovirt/downloads","issues_url":"https://api.github.com/repos/jhernand/ovirt/issues{/number}","pulls_url":"https://api.github.com/repos/jhernand/ovirt/pulls{/number}","milestones_url":"https://api.github.com/repos/jhernand/ovirt/milestones{/number}","notifications_url":"https://api.github.com/repos/jhernand/ovirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhernand/ovirt/labels{/name}","releases_url":"https://api.github.com/repos/jhernand/ovirt/releases{/id}","deployments_url":"https://api.github.com/repos/jhernand/ovirt/deployments","created_at":"2016-03-22T15:31:25Z","updated_at":"2016-03-22T15:31:26Z","pushed_at":"2017-08-25T09:24:39Z","git_url":"git://github.com/jhernand/ovirt.git","ssh_url":"[email protected]:jhernand/ovirt.git","clone_url":"https://github.com/jhernand/ovirt.git","svn_url":"https://github.com/jhernand/ovirt","homepage":"","size":274,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"cf6fd72f2fb3ef7ff6d7881e3c55ee1e3c5f74d5","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":24246824,"name":"ovirt","full_name":"ManageIQ/ovirt","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/ovirt","description":"Ovirt provides a simple Object Oriented interface to the REST API of oVirt and RHEV-M servers","fork":false,"url":"https://api.github.com/repos/ManageIQ/ovirt","forks_url":"https://api.github.com/repos/ManageIQ/ovirt/forks","keys_url":"https://api.github.com/repos/ManageIQ/ovirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/ovirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/ovirt/teams","hooks_url":"https://api.github.com/repos/ManageIQ/ovirt/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/ovirt/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/ovirt/events","assignees_url":"https://api.github.com/repos/ManageIQ/ovirt/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/ovirt/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/ovirt/tags","blobs_url":"https://api.github.com/repos/ManageIQ/ovirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/ovirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/ovirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/ovirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/ovirt/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/ovirt/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/ovirt/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/ovirt/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/ovirt/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/ovirt/subscription","commits_url":"https://api.github.com/repos/ManageIQ/ovirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/ovirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/ovirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/ovirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/ovirt/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/ovirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/ovirt/merges","archive_url":"https://api.github.com/repos/ManageIQ/ovirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/ovirt/downloads","issues_url":"https://api.github.com/repos/ManageIQ/ovirt/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/ovirt/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/ovirt/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/ovirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/ovirt/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/ovirt/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/ovirt/deployments","created_at":"2014-09-19T21:59:15Z","updated_at":"2017-06-07T17:17:18Z","pushed_at":"2017-08-25T09:24:41Z","git_url":"git://github.com/ManageIQ/ovirt.git","ssh_url":"[email protected]:ManageIQ/ovirt.git","clone_url":"https://github.com/ManageIQ/ovirt.git","svn_url":"https://github.com/ManageIQ/ovirt","homepage":"","size":274,"stargazers_count":14,"watchers_count":14,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":2,"forks":28,"open_issues":2,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/ovirt/pulls/88"},"html":{"href":"https://github.com/ManageIQ/ovirt/pull/88"},"issue":{"href":"https://api.github.com/repos/ManageIQ/ovirt/issues/88"},"comments":{"href":"https://api.github.com/repos/ManageIQ/ovirt/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/ovirt/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/ovirt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/ovirt/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/ovirt/statuses/9017c5c580aaa056ba4274344afa6b556bada011"}}}} | {
"id": 24246824,
"name": "ManageIQ/ovirt",
"url": "https://api.github.com/repos/ManageIQ/ovirt"
} | {
"id": 1423971,
"login": "jhernand",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1423971?",
"url": "https://api.github.com/users/jhernand"
} | {
"id": 1125575,
"login": "ManageIQ",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1125575?",
"url": "https://api.github.com/orgs/ManageIQ"
} | 2017-08-25T18:04:00 | 6513346055 | {"actor":{"display_login":"jhernand"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/comments/131191177","pull_request_review_id":54148775,"id":131191177,"diff_hunk":"@@ -418,7 +418,7 @@ def get_pods_graph(inv)\n \n # polymorphic, relation disambiguates parent\n def get_container_conditions_graph(parent, hashes)\n- model_name = parent.inventory_collection.model_class.name\n+ model_name = parent.inventory_collection.model_class.base_class.name","path":"app/models/manageiq/providers/kubernetes/container_manager/refresh_parser.rb","position":5,"original_position":5,"commit_id":"8baff02d000007e9420d1010a3ccc394b175ecd8","original_commit_id":"7419a05bc7e7a2585ecb70ece3e0beb03938c616","user":{"login":"cben","id":273688,"avatar_url":"https://avatars2.githubusercontent.com/u/273688?v=4","gravatar_id":"","url":"https://api.github.com/users/cben","html_url":"https://github.com/cben","followers_url":"https://api.github.com/users/cben/followers","following_url":"https://api.github.com/users/cben/following{/other_user}","gists_url":"https://api.github.com/users/cben/gists{/gist_id}","starred_url":"https://api.github.com/users/cben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cben/subscriptions","organizations_url":"https://api.github.com/users/cben/orgs","repos_url":"https://api.github.com/users/cben/repos","events_url":"https://api.github.com/users/cben/events{/privacy}","received_events_url":"https://api.github.com/users/cben/received_events","type":"User","site_admin":false},"body":"You're right we shouldn't need it, but experimentally we do :-\\ Without it, in https://github.com/ManageIQ/manageiq-providers-openshift/pull/28 refresher specs,\r\nI get weird `Invalid single-table inheritance type: ManageIQ::Providers::Openshift::ContainerManager::ContainerTemplate is not a subclass of ManageIQ::Providers::ContainerManager::ContainerTemplate`\r\n\r\nThis `parent`-sniffing magic is too fragile, I'm gonna replace it with something more explicit (plus give inventory collections unique `.name`s for debugging). But for now let's get back to green.","created_at":"2017-08-03T16:26:25Z","updated_at":"2017-08-03T16:26:25Z","html_url":"https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/81#discussion_r131191177","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/81","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/comments/131191177"},"html":{"href":"https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/81#discussion_r131191177"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/81"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/81","id":133929331,"html_url":"https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/81","diff_url":"https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/81.diff","patch_url":"https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/81.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/issues/81","number":81,"state":"open","locked":false,"title":"Fix fallouts from ContainerTemplate STI","user":{"login":"cben","id":273688,"avatar_url":"https://avatars2.githubusercontent.com/u/273688?v=4","gravatar_id":"","url":"https://api.github.com/users/cben","html_url":"https://github.com/cben","followers_url":"https://api.github.com/users/cben/followers","following_url":"https://api.github.com/users/cben/following{/other_user}","gists_url":"https://api.github.com/users/cben/gists{/gist_id}","starred_url":"https://api.github.com/users/cben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cben/subscriptions","organizations_url":"https://api.github.com/users/cben/orgs","repos_url":"https://api.github.com/users/cben/repos","events_url":"https://api.github.com/users/cben/events{/privacy}","received_events_url":"https://api.github.com/users/cben/received_events","type":"User","site_admin":false},"body":"I assumed in this code the model used when defining these collections is same model as the `parent` for which we are looking them up, which is wrong given STI.\r\nThis fixes errors in manageiq-providers-openshift repo:\r\n```\r\n can't save: missing @inv_collections[[:custom_attributes_for, \"ContainerTemplate\", \"labels\"]]\r\n can't save: missing @inv_collections[[:custom_attributes_for, \"ManageIQ::Providers::Kubernetes::ContainerManager::ContainerTemplate\", \"labels\"]]\r\n```\r\nfollowing https://github.com/ManageIQ/manageiq-providers-openshift/pull/28 and related PRs.\r\n\r\nI'm still seeing other errors in openshift specs locally, but this gets us closer to green...\r\n\r\n@lfu @moolitayer @Ladas please review.","created_at":"2017-08-03T12:14:00Z","updated_at":"2017-08-03T16:26:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98ebbfb135716f2baedaf7e1f68b37fd748ce413","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/81/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/81/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/issues/81/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/statuses/8baff02d000007e9420d1010a3ccc394b175ecd8","head":{"label":"cben:graph-STI-fixes","ref":"graph-STI-fixes","sha":"8baff02d000007e9420d1010a3ccc394b175ecd8","user":{"login":"cben","id":273688,"avatar_url":"https://avatars2.githubusercontent.com/u/273688?v=4","gravatar_id":"","url":"https://api.github.com/users/cben","html_url":"https://github.com/cben","followers_url":"https://api.github.com/users/cben/followers","following_url":"https://api.github.com/users/cben/following{/other_user}","gists_url":"https://api.github.com/users/cben/gists{/gist_id}","starred_url":"https://api.github.com/users/cben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cben/subscriptions","organizations_url":"https://api.github.com/users/cben/orgs","repos_url":"https://api.github.com/users/cben/repos","events_url":"https://api.github.com/users/cben/events{/privacy}","received_events_url":"https://api.github.com/users/cben/received_events","type":"User","site_admin":false},"repo":{"id":89673659,"name":"manageiq-providers-kubernetes","full_name":"cben/manageiq-providers-kubernetes","owner":{"login":"cben","id":273688,"avatar_url":"https://avatars2.githubusercontent.com/u/273688?v=4","gravatar_id":"","url":"https://api.github.com/users/cben","html_url":"https://github.com/cben","followers_url":"https://api.github.com/users/cben/followers","following_url":"https://api.github.com/users/cben/following{/other_user}","gists_url":"https://api.github.com/users/cben/gists{/gist_id}","starred_url":"https://api.github.com/users/cben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cben/subscriptions","organizations_url":"https://api.github.com/users/cben/orgs","repos_url":"https://api.github.com/users/cben/repos","events_url":"https://api.github.com/users/cben/events{/privacy}","received_events_url":"https://api.github.com/users/cben/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cben/manageiq-providers-kubernetes","description":"ManageIQ plugin for the Kubernetes provider","fork":true,"url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes","forks_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/forks","keys_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/teams","hooks_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/events","assignees_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/tags","blobs_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/languages","stargazers_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/subscription","commits_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/merges","archive_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/downloads","issues_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/cben/manageiq-providers-kubernetes/deployments","created_at":"2017-04-28T06:12:47Z","updated_at":"2017-04-28T06:12:48Z","pushed_at":"2017-08-03T16:15:45Z","git_url":"git://github.com/cben/manageiq-providers-kubernetes.git","ssh_url":"[email protected]:cben/manageiq-providers-kubernetes.git","clone_url":"https://github.com/cben/manageiq-providers-kubernetes.git","svn_url":"https://github.com/cben/manageiq-providers-kubernetes","homepage":null,"size":1963,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"880cc581d24c6c1586d70d22f10b0332eed88949","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":87439629,"name":"manageiq-providers-kubernetes","full_name":"ManageIQ/manageiq-providers-kubernetes","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-providers-kubernetes","description":"ManageIQ plugin for the Kubernetes provider","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/deployments","created_at":"2017-04-06T14:37:31Z","updated_at":"2017-05-23T13:57:18Z","pushed_at":"2017-08-03T16:15:47Z","git_url":"git://github.com/ManageIQ/manageiq-providers-kubernetes.git","ssh_url":"[email protected]:ManageIQ/manageiq-providers-kubernetes.git","clone_url":"https://github.com/ManageIQ/manageiq-providers-kubernetes.git","svn_url":"https://github.com/ManageIQ/manageiq-providers-kubernetes","homepage":null,"size":1942,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":22,"forks":27,"open_issues":22,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/81"},"html":{"href":"https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/81"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/issues/81"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/statuses/8baff02d000007e9420d1010a3ccc394b175ecd8"}}}} | {
"id": 87439629,
"name": "ManageIQ/manageiq-providers-kubernetes",
"url": "https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes"
} | {
"id": 273688,
"login": "cben",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/273688?",
"url": "https://api.github.com/users/cben"
} | {
"id": 1125575,
"login": "ManageIQ",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1125575?",
"url": "https://api.github.com/orgs/ManageIQ"
} | 2017-08-03T16:26:25 | 6388878157 | {"actor":{"display_login":"cben"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/comments/101800281","pull_request_review_id":22542707,"id":101800281,"diff_hunk":"@@ -0,0 +1,11 @@\n+import './_ss-card.sass';\n+import templateUrl from './ss-card.html';\n+\n+export const SSCardComponent = {\n+ bindings: {\n+ header: '<',\n+ description: '<',\n+ image: '<',\n+ },\n+ templateUrl,","path":"client/app/shared/ss-card/ss-card.component.js","position":10,"original_position":10,"commit_id":"deb55c7449a7401e452359569b3720123e28f6fd","original_commit_id":"deb55c7449a7401e452359569b3720123e28f6fd","user":{"login":"AllenBW","id":6640236,"avatar_url":"https://avatars.githubusercontent.com/u/6640236?v=3","gravatar_id":"","url":"https://api.github.com/users/AllenBW","html_url":"https://github.com/AllenBW","followers_url":"https://api.github.com/users/AllenBW/followers","following_url":"https://api.github.com/users/AllenBW/following{/other_user}","gists_url":"https://api.github.com/users/AllenBW/gists{/gist_id}","starred_url":"https://api.github.com/users/AllenBW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AllenBW/subscriptions","organizations_url":"https://api.github.com/users/AllenBW/orgs","repos_url":"https://api.github.com/users/AllenBW/repos","events_url":"https://api.github.com/users/AllenBW/events{/privacy}","received_events_url":"https://api.github.com/users/AllenBW/received_events","type":"User","site_admin":false},"body":" ` controllerAs: 'vm',` ? (ill make the case below)","created_at":"2017-02-17T17:02:02Z","updated_at":"2017-02-17T17:31:39Z","html_url":"https://github.com/ManageIQ/manageiq-ui-service/pull/519#discussion_r101800281","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/519","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/comments/101800281"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-service/pull/519#discussion_r101800281"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/519"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/519","id":106614064,"html_url":"https://github.com/ManageIQ/manageiq-ui-service/pull/519","diff_url":"https://github.com/ManageIQ/manageiq-ui-service/pull/519.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-service/pull/519.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/519","number":519,"state":"open","locked":false,"title":"Extract 'app.shared' module from 'app.components'","user":{"login":"jjlangholtz","id":6842753,"avatar_url":"https://avatars.githubusercontent.com/u/6842753?v=3","gravatar_id":"","url":"https://api.github.com/users/jjlangholtz","html_url":"https://github.com/jjlangholtz","followers_url":"https://api.github.com/users/jjlangholtz/followers","following_url":"https://api.github.com/users/jjlangholtz/following{/other_user}","gists_url":"https://api.github.com/users/jjlangholtz/gists{/gist_id}","starred_url":"https://api.github.com/users/jjlangholtz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjlangholtz/subscriptions","organizations_url":"https://api.github.com/users/jjlangholtz/orgs","repos_url":"https://api.github.com/users/jjlangholtz/repos","events_url":"https://api.github.com/users/jjlangholtz/events{/privacy}","received_events_url":"https://api.github.com/users/jjlangholtz/received_events","type":"User","site_admin":false},"body":"Begin breaking down the grab-bag components module into a more modular\r\nfeature structure. Pull all filters, directives, and components that are\r\nused in more than one feature area into the `SharedModule`. This module\r\nwill then be imported into each individual feature module.\r\n\r\nThis sets up follow-up PRs to create feature modules for each area of\r\nthe application (services, catalogs, dialogs, etc.). Units specific to\r\neach area have been marked in both `app.core` (factories/services) and\r\n`app.components`.\r\n\r\nAdditionally, adjust the webpack config to include the sass root when\r\nusing `@import`. Now it is very easy to import sass files directly by\r\nthe components that use them instead of maintaining a parallel file\r\nstructure for styles.\r\n\r\nhttps://www.pivotaltracker.com/story/show/138278069\r\n\r\n@miq-bot add_label euwe/no, refactoring, housekeeping","created_at":"2017-02-16T21:07:04Z","updated_at":"2017-02-17T17:31:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"084ac38295ecaf030429272338690e659563a035","assignee":{"login":"chriskacerguis","id":2414647,"avatar_url":"https://avatars.githubusercontent.com/u/2414647?v=3","gravatar_id":"","url":"https://api.github.com/users/chriskacerguis","html_url":"https://github.com/chriskacerguis","followers_url":"https://api.github.com/users/chriskacerguis/followers","following_url":"https://api.github.com/users/chriskacerguis/following{/other_user}","gists_url":"https://api.github.com/users/chriskacerguis/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskacerguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskacerguis/subscriptions","organizations_url":"https://api.github.com/users/chriskacerguis/orgs","repos_url":"https://api.github.com/users/chriskacerguis/repos","events_url":"https://api.github.com/users/chriskacerguis/events{/privacy}","received_events_url":"https://api.github.com/users/chriskacerguis/received_events","type":"User","site_admin":false},"assignees":[{"login":"chriskacerguis","id":2414647,"avatar_url":"https://avatars.githubusercontent.com/u/2414647?v=3","gravatar_id":"","url":"https://api.github.com/users/chriskacerguis","html_url":"https://github.com/chriskacerguis","followers_url":"https://api.github.com/users/chriskacerguis/followers","following_url":"https://api.github.com/users/chriskacerguis/following{/other_user}","gists_url":"https://api.github.com/users/chriskacerguis/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskacerguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskacerguis/subscriptions","organizations_url":"https://api.github.com/users/chriskacerguis/orgs","repos_url":"https://api.github.com/users/chriskacerguis/repos","events_url":"https://api.github.com/users/chriskacerguis/events{/privacy}","received_events_url":"https://api.github.com/users/chriskacerguis/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/milestones/19","html_url":"https://github.com/ManageIQ/manageiq-ui-service/milestone/19","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/milestones/19/labels","id":2322212,"number":19,"title":"Sprint 55 Ending Feb 27, 2017","description":"","creator":{"login":"chessbyte","id":82161,"avatar_url":"https://avatars.githubusercontent.com/u/82161?v=3","gravatar_id":"","url":"https://api.github.com/users/chessbyte","html_url":"https://github.com/chessbyte","followers_url":"https://api.github.com/users/chessbyte/followers","following_url":"https://api.github.com/users/chessbyte/following{/other_user}","gists_url":"https://api.github.com/users/chessbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/chessbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessbyte/subscriptions","organizations_url":"https://api.github.com/users/chessbyte/orgs","repos_url":"https://api.github.com/users/chessbyte/repos","events_url":"https://api.github.com/users/chessbyte/events{/privacy}","received_events_url":"https://api.github.com/users/chessbyte/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":6,"state":"open","created_at":"2017-02-14T16:25:43Z","updated_at":"2017-02-17T16:43:56Z","due_on":"2017-02-27T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/519/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/519/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/519/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/statuses/deb55c7449a7401e452359569b3720123e28f6fd","head":{"label":"jjlangholtz:extract-shared-module","ref":"extract-shared-module","sha":"deb55c7449a7401e452359569b3720123e28f6fd","user":{"login":"jjlangholtz","id":6842753,"avatar_url":"https://avatars.githubusercontent.com/u/6842753?v=3","gravatar_id":"","url":"https://api.github.com/users/jjlangholtz","html_url":"https://github.com/jjlangholtz","followers_url":"https://api.github.com/users/jjlangholtz/followers","following_url":"https://api.github.com/users/jjlangholtz/following{/other_user}","gists_url":"https://api.github.com/users/jjlangholtz/gists{/gist_id}","starred_url":"https://api.github.com/users/jjlangholtz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjlangholtz/subscriptions","organizations_url":"https://api.github.com/users/jjlangholtz/orgs","repos_url":"https://api.github.com/users/jjlangholtz/repos","events_url":"https://api.github.com/users/jjlangholtz/events{/privacy}","received_events_url":"https://api.github.com/users/jjlangholtz/received_events","type":"User","site_admin":false},"repo":{"id":72210228,"name":"manageiq-ui-service","full_name":"jjlangholtz/manageiq-ui-service","owner":{"login":"jjlangholtz","id":6842753,"avatar_url":"https://avatars.githubusercontent.com/u/6842753?v=3","gravatar_id":"","url":"https://api.github.com/users/jjlangholtz","html_url":"https://github.com/jjlangholtz","followers_url":"https://api.github.com/users/jjlangholtz/followers","following_url":"https://api.github.com/users/jjlangholtz/following{/other_user}","gists_url":"https://api.github.com/users/jjlangholtz/gists{/gist_id}","starred_url":"https://api.github.com/users/jjlangholtz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjlangholtz/subscriptions","organizations_url":"https://api.github.com/users/jjlangholtz/orgs","repos_url":"https://api.github.com/users/jjlangholtz/repos","events_url":"https://api.github.com/users/jjlangholtz/events{/privacy}","received_events_url":"https://api.github.com/users/jjlangholtz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jjlangholtz/manageiq-ui-service","description":"Service UI for ManageIQ","fork":true,"url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service","forks_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/forks","keys_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/teams","hooks_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/hooks","issue_events_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/issues/events{/number}","events_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/events","assignees_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/assignees{/user}","branches_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/branches{/branch}","tags_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/tags","blobs_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/statuses/{sha}","languages_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/languages","stargazers_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/stargazers","contributors_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/contributors","subscribers_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/subscribers","subscription_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/subscription","commits_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/contents/{+path}","compare_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/merges","archive_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/downloads","issues_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/issues{/number}","pulls_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/pulls{/number}","milestones_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/milestones{/number}","notifications_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/labels{/name}","releases_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/releases{/id}","deployments_url":"https://api.github.com/repos/jjlangholtz/manageiq-ui-service/deployments","created_at":"2016-10-28T13:34:40Z","updated_at":"2016-10-28T13:34:42Z","pushed_at":"2017-02-17T16:16:46Z","git_url":"git://github.com/jjlangholtz/manageiq-ui-service.git","ssh_url":"[email protected]:jjlangholtz/manageiq-ui-service.git","clone_url":"https://github.com/jjlangholtz/manageiq-ui-service.git","svn_url":"https://github.com/jjlangholtz/manageiq-ui-service","homepage":"","size":5758,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"5042c5b4d79485e0382f883e63cc04eb98db5e53","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":51539656,"name":"manageiq-ui-service","full_name":"ManageIQ/manageiq-ui-service","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-ui-service","description":"Service UI for ManageIQ","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/deployments","created_at":"2016-02-11T19:17:13Z","updated_at":"2017-01-04T19:30:01Z","pushed_at":"2017-02-17T16:53:16Z","git_url":"git://github.com/ManageIQ/manageiq-ui-service.git","ssh_url":"[email protected]:ManageIQ/manageiq-ui-service.git","clone_url":"https://github.com/ManageIQ/manageiq-ui-service.git","svn_url":"https://github.com/ManageIQ/manageiq-ui-service","homepage":"","size":5724,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":6,"forks":41,"open_issues":6,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/519"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-service/pull/519"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/519"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/519/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/519/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/519/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/statuses/deb55c7449a7401e452359569b3720123e28f6fd"}}}} | {
"id": 51539656,
"name": "ManageIQ/manageiq-ui-service",
"url": "https://api.github.com/repos/ManageIQ/manageiq-ui-service"
} | {
"id": 6640236,
"login": "AllenBW",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6640236?",
"url": "https://api.github.com/users/AllenBW"
} | {
"id": 1125575,
"login": "ManageIQ",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1125575?",
"url": "https://api.github.com/orgs/ManageIQ"
} | 2017-02-17T17:02:02 | 5345660400 | {"actor":{"display_login":"AllenBW"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/134200149","pull_request_review_id":57462863,"id":134200149,"diff_hunk":"@@ -60,10 +60,10 @@ def pytest_generate_tests(metafunc):\n \n @pytest.fixture(scope=\"function\")\n def setup_pxe_servers_vm_prov(pxe_server, pxe_cust_template, provisioning):\n- if not pxe_server.exists:\n+ if not pxe_server.exists():\n pxe_server.create()\n pxe_server.set_pxe_image_type(provisioning['pxe_image'], provisioning['pxe_image_type'])\n- if not pxe_cust_template.exists:\n+ if not pxe_cust_template.exists():","path":"cfme/tests/infrastructure/test_pxe_provisioning.py","position":9,"original_position":9,"commit_id":"4119837c95d5265c8241d367de0abf9e81afd7b2","original_commit_id":"888ab640961f4bd04fe0994721fc53ff5e2ae920","user":{"login":"izapolsk","id":21039333,"avatar_url":"https://avatars2.githubusercontent.com/u/21039333?v=4","gravatar_id":"","url":"https://api.github.com/users/izapolsk","html_url":"https://github.com/izapolsk","followers_url":"https://api.github.com/users/izapolsk/followers","following_url":"https://api.github.com/users/izapolsk/following{/other_user}","gists_url":"https://api.github.com/users/izapolsk/gists{/gist_id}","starred_url":"https://api.github.com/users/izapolsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izapolsk/subscriptions","organizations_url":"https://api.github.com/users/izapolsk/orgs","repos_url":"https://api.github.com/users/izapolsk/repos","events_url":"https://api.github.com/users/izapolsk/events{/privacy}","received_events_url":"https://api.github.com/users/izapolsk/received_events","type":"User","site_admin":false},"body":"After talking to jkrocil and ronny, I figured out that these methods cannot be converted to properties right now. \r\nThis was a mistake to remove () in tests.","created_at":"2017-08-21T10:41:40Z","updated_at":"2017-08-21T10:41:40Z","html_url":"https://github.com/ManageIQ/integration_tests/pull/5013#discussion_r134200149","pull_request_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/5013","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/134200149"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/5013#discussion_r134200149"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/5013"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/5013","id":131712912,"html_url":"https://github.com/ManageIQ/integration_tests/pull/5013","diff_url":"https://github.com/ManageIQ/integration_tests/pull/5013.diff","patch_url":"https://github.com/ManageIQ/integration_tests/pull/5013.patch","issue_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/5013","number":5013,"state":"open","locked":false,"title":"[1LP][WIP] Widgetastic PXE","user":{"login":"izapolsk","id":21039333,"avatar_url":"https://avatars2.githubusercontent.com/u/21039333?v=4","gravatar_id":"","url":"https://api.github.com/users/izapolsk","html_url":"https://github.com/izapolsk","followers_url":"https://api.github.com/users/izapolsk/followers","following_url":"https://api.github.com/users/izapolsk/following{/other_user}","gists_url":"https://api.github.com/users/izapolsk/gists{/gist_id}","starred_url":"https://api.github.com/users/izapolsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izapolsk/subscriptions","organizations_url":"https://api.github.com/users/izapolsk/orgs","repos_url":"https://api.github.com/users/izapolsk/repos","events_url":"https://api.github.com/users/izapolsk/events{/privacy}","received_events_url":"https://api.github.com/users/izapolsk/received_events","type":"User","site_admin":false},"body":"{{pytest: cfme/tests/infrastructure/test_iso_datastore.py cfme/tests/infrastructure/test_iso_provisioning.py cfme/tests/infrastructure/test_pxe.py cfme/tests/infrastructure/test_pxe_provisioning.py cfme/tests/infrastructure/test_system_image_type.py cfme/tests/services/test_pxe_service_catalogs.py cfme/tests/services/test_iso_service_catalogs.py}}","created_at":"2017-07-21T07:23:31Z","updated_at":"2017-08-21T10:41:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e039be7991289c7e699022fa0a0b3c6633d7e64","assignee":null,"assignees":[],"requested_reviewers":[{"login":"psav","id":5639745,"avatar_url":"https://avatars0.githubusercontent.com/u/5639745?v=4","gravatar_id":"","url":"https://api.github.com/users/psav","html_url":"https://github.com/psav","followers_url":"https://api.github.com/users/psav/followers","following_url":"https://api.github.com/users/psav/following{/other_user}","gists_url":"https://api.github.com/users/psav/gists{/gist_id}","starred_url":"https://api.github.com/users/psav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psav/subscriptions","organizations_url":"https://api.github.com/users/psav/orgs","repos_url":"https://api.github.com/users/psav/repos","events_url":"https://api.github.com/users/psav/events{/privacy}","received_events_url":"https://api.github.com/users/psav/received_events","type":"User","site_admin":false},{"login":"mshriver","id":21315076,"avatar_url":"https://avatars3.githubusercontent.com/u/21315076?v=4","gravatar_id":"","url":"https://api.github.com/users/mshriver","html_url":"https://github.com/mshriver","followers_url":"https://api.github.com/users/mshriver/followers","following_url":"https://api.github.com/users/mshriver/following{/other_user}","gists_url":"https://api.github.com/users/mshriver/gists{/gist_id}","starred_url":"https://api.github.com/users/mshriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshriver/subscriptions","organizations_url":"https://api.github.com/users/mshriver/orgs","repos_url":"https://api.github.com/users/mshriver/repos","events_url":"https://api.github.com/users/mshriver/events{/privacy}","received_events_url":"https://api.github.com/users/mshriver/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/5013/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/5013/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/5013/comments","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/4119837c95d5265c8241d367de0abf9e81afd7b2","head":{"label":"izapolsk:widgetastic_pxe","ref":"widgetastic_pxe","sha":"4119837c95d5265c8241d367de0abf9e81afd7b2","user":{"login":"izapolsk","id":21039333,"avatar_url":"https://avatars2.githubusercontent.com/u/21039333?v=4","gravatar_id":"","url":"https://api.github.com/users/izapolsk","html_url":"https://github.com/izapolsk","followers_url":"https://api.github.com/users/izapolsk/followers","following_url":"https://api.github.com/users/izapolsk/following{/other_user}","gists_url":"https://api.github.com/users/izapolsk/gists{/gist_id}","starred_url":"https://api.github.com/users/izapolsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izapolsk/subscriptions","organizations_url":"https://api.github.com/users/izapolsk/orgs","repos_url":"https://api.github.com/users/izapolsk/repos","events_url":"https://api.github.com/users/izapolsk/events{/privacy}","received_events_url":"https://api.github.com/users/izapolsk/received_events","type":"User","site_admin":false},"repo":{"id":65739373,"name":"integration_tests","full_name":"izapolsk/integration_tests","owner":{"login":"izapolsk","id":21039333,"avatar_url":"https://avatars2.githubusercontent.com/u/21039333?v=4","gravatar_id":"","url":"https://api.github.com/users/izapolsk","html_url":"https://github.com/izapolsk","followers_url":"https://api.github.com/users/izapolsk/followers","following_url":"https://api.github.com/users/izapolsk/following{/other_user}","gists_url":"https://api.github.com/users/izapolsk/gists{/gist_id}","starred_url":"https://api.github.com/users/izapolsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izapolsk/subscriptions","organizations_url":"https://api.github.com/users/izapolsk/orgs","repos_url":"https://api.github.com/users/izapolsk/repos","events_url":"https://api.github.com/users/izapolsk/events{/privacy}","received_events_url":"https://api.github.com/users/izapolsk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/izapolsk/integration_tests","description":"ManageIQ integration tests","fork":true,"url":"https://api.github.com/repos/izapolsk/integration_tests","forks_url":"https://api.github.com/repos/izapolsk/integration_tests/forks","keys_url":"https://api.github.com/repos/izapolsk/integration_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/izapolsk/integration_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/izapolsk/integration_tests/teams","hooks_url":"https://api.github.com/repos/izapolsk/integration_tests/hooks","issue_events_url":"https://api.github.com/repos/izapolsk/integration_tests/issues/events{/number}","events_url":"https://api.github.com/repos/izapolsk/integration_tests/events","assignees_url":"https://api.github.com/repos/izapolsk/integration_tests/assignees{/user}","branches_url":"https://api.github.com/repos/izapolsk/integration_tests/branches{/branch}","tags_url":"https://api.github.com/repos/izapolsk/integration_tests/tags","blobs_url":"https://api.github.com/repos/izapolsk/integration_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/izapolsk/integration_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/izapolsk/integration_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/izapolsk/integration_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/izapolsk/integration_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/izapolsk/integration_tests/languages","stargazers_url":"https://api.github.com/repos/izapolsk/integration_tests/stargazers","contributors_url":"https://api.github.com/repos/izapolsk/integration_tests/contributors","subscribers_url":"https://api.github.com/repos/izapolsk/integration_tests/subscribers","subscription_url":"https://api.github.com/repos/izapolsk/integration_tests/subscription","commits_url":"https://api.github.com/repos/izapolsk/integration_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/izapolsk/integration_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/izapolsk/integration_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/izapolsk/integration_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/izapolsk/integration_tests/contents/{+path}","compare_url":"https://api.github.com/repos/izapolsk/integration_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/izapolsk/integration_tests/merges","archive_url":"https://api.github.com/repos/izapolsk/integration_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/izapolsk/integration_tests/downloads","issues_url":"https://api.github.com/repos/izapolsk/integration_tests/issues{/number}","pulls_url":"https://api.github.com/repos/izapolsk/integration_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/izapolsk/integration_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/izapolsk/integration_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/izapolsk/integration_tests/labels{/name}","releases_url":"https://api.github.com/repos/izapolsk/integration_tests/releases{/id}","deployments_url":"https://api.github.com/repos/izapolsk/integration_tests/deployments","created_at":"2016-08-15T14:40:51Z","updated_at":"2016-08-15T14:40:54Z","pushed_at":"2017-08-21T10:39:08Z","git_url":"git://github.com/izapolsk/integration_tests.git","ssh_url":"[email protected]:izapolsk/integration_tests.git","clone_url":"https://github.com/izapolsk/integration_tests.git","svn_url":"https://github.com/izapolsk/integration_tests","homepage":"","size":17383,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"25ca0a83897c24c8f601e90cbb1d36c10955d805","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":8061086,"name":"integration_tests","full_name":"ManageIQ/integration_tests","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/integration_tests","description":"ManageIQ integration tests","fork":false,"url":"https://api.github.com/repos/ManageIQ/integration_tests","forks_url":"https://api.github.com/repos/ManageIQ/integration_tests/forks","keys_url":"https://api.github.com/repos/ManageIQ/integration_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/integration_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/integration_tests/teams","hooks_url":"https://api.github.com/repos/ManageIQ/integration_tests/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/integration_tests/events","assignees_url":"https://api.github.com/repos/ManageIQ/integration_tests/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/integration_tests/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/tags","blobs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/integration_tests/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/integration_tests/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/integration_tests/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscription","commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/integration_tests/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/integration_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/integration_tests/merges","archive_url":"https://api.github.com/repos/ManageIQ/integration_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/integration_tests/downloads","issues_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/integration_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/integration_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/integration_tests/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/integration_tests/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/integration_tests/deployments","created_at":"2013-02-06T21:59:17Z","updated_at":"2017-07-30T15:38:02Z","pushed_at":"2017-08-21T10:39:10Z","git_url":"git://github.com/ManageIQ/integration_tests.git","ssh_url":"[email protected]:ManageIQ/integration_tests.git","clone_url":"https://github.com/ManageIQ/integration_tests.git","svn_url":"https://github.com/ManageIQ/integration_tests","homepage":"","size":17112,"stargazers_count":42,"watchers_count":42,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"open_issues_count":132,"forks":91,"open_issues":132,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/5013"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/5013"},"issue":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/5013"},"comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/5013/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/5013/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/5013/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/4119837c95d5265c8241d367de0abf9e81afd7b2"}}}} | {
"id": 8061086,
"name": "ManageIQ/integration_tests",
"url": "https://api.github.com/repos/ManageIQ/integration_tests"
} | {
"id": 21039333,
"login": "izapolsk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21039333?",
"url": "https://api.github.com/users/izapolsk"
} | {
"id": 1125575,
"login": "ManageIQ",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1125575?",
"url": "https://api.github.com/orgs/ManageIQ"
} | 2017-08-21T10:41:40 | 6491689101 | {"actor":{"display_login":"izapolsk"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments/122963462","pull_request_review_id":45122272,"id":122963462,"diff_hunk":"@@ -367,6 +367,7 @@ def report_data\n if options.nil? || options[:view].nil?\n model_view = process_params_model_view(params, options)\n @edit = session[:edit]\n+ options_from_session(options)","path":"app/controllers/application_controller.rb","position":4,"original_position":4,"commit_id":"3ae97012561b8f70c150baab3f9783def93854e1","original_commit_id":"3ae97012561b8f70c150baab3f9783def93854e1","user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars0.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"body":"Generally I consider the idea of \"Fixed `report_data` to take `options`(set in get_view) into account\" a step back.\r\n\r\nActually we need to prevent using anything from the session here. The report endpoint needs simplifycation and clean up. All the necessary options should come from the request.\r\n\r\nThe goal is to have this in the API. The has to be stateles so adding more state (session) is a step back.\r\n","created_at":"2017-06-20T12:41:56Z","updated_at":"2017-06-20T12:41:56Z","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1553#discussion_r122963462","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1553","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments/122963462"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1553#discussion_r122963462"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1553"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1553","id":125933769,"html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1553","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1553.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1553.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1553","number":1553,"state":"open","locked":false,"title":"Display Physical Servers with Host in Physical Infra Textual Summary and listnav","user":{"login":"AparnaKarve","id":1538216,"avatar_url":"https://avatars0.githubusercontent.com/u/1538216?v=3","gravatar_id":"","url":"https://api.github.com/users/AparnaKarve","html_url":"https://github.com/AparnaKarve","followers_url":"https://api.github.com/users/AparnaKarve/followers","following_url":"https://api.github.com/users/AparnaKarve/following{/other_user}","gists_url":"https://api.github.com/users/AparnaKarve/gists{/gist_id}","starred_url":"https://api.github.com/users/AparnaKarve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AparnaKarve/subscriptions","organizations_url":"https://api.github.com/users/AparnaKarve/orgs","repos_url":"https://api.github.com/users/AparnaKarve/repos","events_url":"https://api.github.com/users/AparnaKarve/events{/privacy}","received_events_url":"https://api.github.com/users/AparnaKarve/received_events","type":"User","site_admin":false},"body":"The Physical Infra Summary screen now displays a link for `Physical Servers with Host` which is clickable if the Physical Servers are greater than 0.\r\n(basically addressed the pending items in this PR: https://github.com/ManageIQ/manageiq-ui-classic/pull/1458 specified in the comment https://github.com/ManageIQ/manageiq-ui-classic/pull/1458#issuecomment-306570215\r\n\r\n\r\n<img width=\"1422\" alt=\"screen shot 2017-06-15 at 4 28 24 pm\" src=\"https://user-images.githubusercontent.com/1538216/27205977-04fe6df2-51e9-11e7-9471-eb6252dfa1ea.png\">\r\n\r\n<img width=\"1420\" alt=\"screen shot 2017-06-15 at 4 18 45 pm\" src=\"https://user-images.githubusercontent.com/1538216/27205994-1d6dd3e6-51e9-11e7-8977-5b5a0ec24959.png\">\r\n\r\n","created_at":"2017-06-15T23:40:23Z","updated_at":"2017-06-20T12:41:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f11cf8fedd489e87037644f3df592a9fd0fd1f0a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1553/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1553/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1553/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/3ae97012561b8f70c150baab3f9783def93854e1","head":{"label":"AparnaKarve:display_physical_servers_with_host","ref":"display_physical_servers_with_host","sha":"3ae97012561b8f70c150baab3f9783def93854e1","user":{"login":"AparnaKarve","id":1538216,"avatar_url":"https://avatars0.githubusercontent.com/u/1538216?v=3","gravatar_id":"","url":"https://api.github.com/users/AparnaKarve","html_url":"https://github.com/AparnaKarve","followers_url":"https://api.github.com/users/AparnaKarve/followers","following_url":"https://api.github.com/users/AparnaKarve/following{/other_user}","gists_url":"https://api.github.com/users/AparnaKarve/gists{/gist_id}","starred_url":"https://api.github.com/users/AparnaKarve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AparnaKarve/subscriptions","organizations_url":"https://api.github.com/users/AparnaKarve/orgs","repos_url":"https://api.github.com/users/AparnaKarve/repos","events_url":"https://api.github.com/users/AparnaKarve/events{/privacy}","received_events_url":"https://api.github.com/users/AparnaKarve/received_events","type":"User","site_admin":false},"repo":{"id":77175364,"name":"manageiq-ui-classic","full_name":"AparnaKarve/manageiq-ui-classic","owner":{"login":"AparnaKarve","id":1538216,"avatar_url":"https://avatars0.githubusercontent.com/u/1538216?v=3","gravatar_id":"","url":"https://api.github.com/users/AparnaKarve","html_url":"https://github.com/AparnaKarve","followers_url":"https://api.github.com/users/AparnaKarve/followers","following_url":"https://api.github.com/users/AparnaKarve/following{/other_user}","gists_url":"https://api.github.com/users/AparnaKarve/gists{/gist_id}","starred_url":"https://api.github.com/users/AparnaKarve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AparnaKarve/subscriptions","organizations_url":"https://api.github.com/users/AparnaKarve/orgs","repos_url":"https://api.github.com/users/AparnaKarve/repos","events_url":"https://api.github.com/users/AparnaKarve/events{/privacy}","received_events_url":"https://api.github.com/users/AparnaKarve/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AparnaKarve/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":true,"url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic","forks_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/AparnaKarve/manageiq-ui-classic/deployments","created_at":"2016-12-22T20:57:20Z","updated_at":"2016-12-22T20:57:27Z","pushed_at":"2017-06-16T14:03:19Z","git_url":"git://github.com/AparnaKarve/manageiq-ui-classic.git","ssh_url":"[email protected]:AparnaKarve/manageiq-ui-classic.git","clone_url":"https://github.com/AparnaKarve/manageiq-ui-classic.git","svn_url":"https://github.com/AparnaKarve/manageiq-ui-classic","homepage":null,"size":44424,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"fa8751d6455cccd5b0593886c072296feeafc5d4","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars3.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":77085298,"name":"manageiq-ui-classic","full_name":"ManageIQ/manageiq-ui-classic","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars3.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/deployments","created_at":"2016-12-21T20:53:08Z","updated_at":"2017-04-28T15:50:11Z","pushed_at":"2017-06-20T12:38:56Z","git_url":"git://github.com/ManageIQ/manageiq-ui-classic.git","ssh_url":"[email protected]:ManageIQ/manageiq-ui-classic.git","clone_url":"https://github.com/ManageIQ/manageiq-ui-classic.git","svn_url":"https://github.com/ManageIQ/manageiq-ui-classic","homepage":null,"size":45479,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":144,"mirror_url":null,"open_issues_count":190,"forks":144,"open_issues":190,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1553"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1553"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1553"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1553/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1553/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1553/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/3ae97012561b8f70c150baab3f9783def93854e1"}}}} | {
"id": 77085298,
"name": "ManageIQ/manageiq-ui-classic",
"url": "https://api.github.com/repos/ManageIQ/manageiq-ui-classic"
} | {
"id": 51095,
"login": "martinpovolny",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/51095?",
"url": "https://api.github.com/users/martinpovolny"
} | {
"id": 1125575,
"login": "ManageIQ",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1125575?",
"url": "https://api.github.com/orgs/ManageIQ"
} | 2017-06-20T12:41:56 | 6100473652 | {"actor":{"display_login":"martinpovolny"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/NU-CBITS/rails-templates/pulls/comments/95590600","pull_request_review_id":16150583,"id":95590600,"diff_hunk":"@@ -0,0 +1,273 @@\n+question_color = :cyan\n+install_whenever = yes?(\"Does this app need whenever? (y/n)\", question_color)\n+install_rails_admin = yes?(\"Does this app need Rails Admin? (y/n)\", question_color)\n+install_token_auth = yes?(\"Does this app need mobile data synchronization? (y/n)\", question_color)\n+timezone = ask(\"What is the default timezone for this app? ('Central Time (US & Canada)')\", question_color)\n+timezone = timezone.blank? ? \"Central Time (US & Canada)\" : timezone\n+\n+# Override method to allow copying files/directories from this directory into\n+# new application.\n+def source_paths\n+ Array(super) +\n+ [File.join(File.expand_path(File.dirname(__FILE__)), \"rails_root\")]\n+end\n+\n+if install_whenever\n+ # Cron job management\n+ gem \"whenever\", \"~> 0.9.X\", require: false\n+end\n+\n+if install_rails_admin\n+ # Admin dashboard\n+ gem \"rails_admin\", \"~> 1.X\"\n+end\n+\n+if install_token_auth\n+ # Token authentication/data sync API\n+ gem \"token_auth\", \"~> 0.3.X\"\n+ inside \"app/controllers\" do\n+ directory \"token_auth\"\n+ end\n+ inside \"config/initializers\" do\n+ copy_file \"active_model_serializers.rb\"\n+ copy_file \"syncable_resources.rb\"\n+ end\n+end\n+\n+# App styles and icons\n+gem \"bootstrap\", \"~> 4.0.X\"\n+gem \"font-awesome-rails\", \"~> 4.X\"\n+add_source \"https://rails-assets.org\" do\n+ # In combination with Bootstrap\n+ gem \"rails-assets-tether\", \">= 1.1.0\"\n+end\n+\n+# Email styles\n+gem \"inky-rb\", \"~> 1.X\", require: \"inky\"\n+gem \"premailer-rails\", \"~> 1.X\"\n+inside \"config/initializers\" do\n+\tinsert_into_file \"assets.rb\",\n+\t\t\t\t\t\t\t\t\t \"\\nRails.application.config.assets.precompile += %w( foundation_emails.css )\",\n+\t\t\t\t\t\t\t\t\t after: \"# Rails.application.config.assets.precompile += %w( search.js )\"\n+end\n+\n+# Authentication\n+gem \"devise\", \"~> 4.X\"\n+# Translations for Devise\n+gem \"devise-i18n\", \"~> 1.X\"\n+\n+# Exception reporting\n+gem \"sentry-raven\", \"~> 2.X\"\n+\n+gem_group :development do\n+ # Internal tool for tagging releases\n+ gem \"git_tagger\", \"~> 1.X\"\n+end\n+\n+gem_group :development, :test do\n+ # Static code analysis and code convention checking\n+ gem \"rubocop\", \"~> 0.46\"\n+ # Static application security analysis\n+ gem \"brakeman\"\n+ # Gemfile.lock dependency security analysis\n+ gem \"bundler-audit\", require: false\n+ # Testing framework\n+ gem \"rspec-rails\", \"~> 3.5.X\"\n+ # Legacy Rails controller testing methods\n+ gem \"rails-controller-testing\", \"~> 0.X\"\n+end\n+\n+gem_group :test do\n+ # DOM interaction for testing\n+ gem \"capybara\"\n+ # Code coverage analysis for testing\n+ gem \"simplecov\", require: false\n+ # Model object factories\n+ gem \"factory_girl_rails\", \"~> 4.0\"\n+end\n+\n+# Copy files and directories\n+copy_file \".ruby-version\"\n+create_file \".ruby-gemset\", app_name\n+copy_file \".travis.yml\"\n+inside \"lib\" do\n+ copy_file \"app_name.rb\", \"#{app_name}.rb\"\n+\tgsub_file \"#{app_name}.rb\",\n+ /APPLICATION_UNDERSCORE_NAME/,\n+ app_name\n+\tgsub_file \"#{app_name}.rb\",\n+ /APPLICATION_NAME/,\n+ app_name.camelize\n+ directory \"app_name\", \"#{app_name}\"\n+\tgsub_file \"#{app_name}/version.rb\",\n+ /APPLICATION_NAME/,\n+ app_name.camelize\n+ inside \"tasks\" do\n+ copy_file \"default.rake\"\n+ copy_file \"seed.rake\"\n+ end\n+end\n+\n+# Set default mailer URL base for email link generation\n+environment \"config.action_mailer.default_url_options = { host: \\\"http://localhost:3000\\\" }\", env: \"development\"\n+environment \"config.action_mailer.default_url_options = { host: \\\"http://localhost:3000\\\" }\", env: \"test\"\n+\n+run \"rvm gemset create #{app_name}\"\n+rvm_do = \"rvm @#{app_name} do\"\n+run \"#{rvm_do} gem install bundler\"\n+run \"#{rvm_do} bundle install\"\n+run \"#{rvm_do} bundle binstubs brakeman\"\n+\n+# Install default Devise configuration\n+run \"#{rvm_do} rails generate devise:install\"\n+# Override Devise views with translated Bootstrapped/Inky views\n+inside \"app/views\" do\n+ directory \"devise\"\n+end\n+# Create User model\n+run \"#{rvm_do} rails generate devise User\"\n+inside \"app/models\" do\n+ insert_into_file \"user.rb\",\n+ \"# Person with access to the dashboard.\\n\",\n+ before: \"class User < ApplicationRecord\"\n+ gsub_file \"user.rb\",\n+ /:registerable/,\n+ \":lockable, :confirmable, :timeoutable\"\n+end\n+migration_file = Dir.glob(File.join(destination_root, \"db\", \"migrate\", \"*_devise_create_users.rb\")).first\n+gsub_file migration_file,\n+ /# t.string :confirmation_token/,\n+ \"t.string :confirmation_token\"\n+gsub_file migration_file,\n+ /# t.datetime :confirmed_at/,\n+ \"t.datetime :confirmed_at\"\n+gsub_file migration_file,\n+ /# t.datetime :confirmation_sent_at/,\n+ \"t.datetime :confirmation_sent_at\"\n+gsub_file migration_file,\n+ /# t.string :unconfirmed_email/,\n+ \"t.string :unconfirmed_email\"\n+gsub_file migration_file,\n+ /# t.integer :failed_attempts/,\n+ \"t.integer :failed_attempts\"\n+gsub_file migration_file,\n+ /# t.string :unlock_token/,\n+ \"t.string :unlock_token\"\n+gsub_file migration_file,\n+ /# t.datetime :locked_at/,\n+ \"t.datetime :locked_at\"\n+gsub_file migration_file,\n+ /# add_index :users, :confirmation_token/,\n+ \"add_index :users, :confirmation_token\"\n+gsub_file migration_file,\n+ /# add_index :users, :unlock_token/,\n+ \"add_index :users, :unlock_token\"\n+\n+# Configure mailer previews\n+inside \"config\" do\n+ insert_into_file \"application.rb\",\n+ \"\\n config.action_mailer.preview_path = \\\"\\#{Rails.root}/spec/mailers/previews\\\"\",\n+ after: \"class Application < Rails::Application\"\n+end\n+# Copy mailer preview class\n+directory \"spec/mailers/previews\"\n+\n+# Configure RSpec\n+run \"#{rvm_do} rails generate rspec:install\"\n+append_to_file \".rspec\",\n+ \"\\n--color\\n--format documentation\"\n+inside \"spec\" do\n+ prepend_to_file \"rails_helper.rb\",\n+ \"require \\\"simplecov\\\"\\nSimpleCov.start \\\"rails\\\"\\n\\n\"\n+ insert_into_file \"rails_helper.rb\",\n+ \"\\nrequire \\\"support/factory_girl\\\"\",\n+ after: \"require 'rspec/rails'\"\n+ directory \"support\"\n+ directory \"factories\"\n+end\n+\n+# Optionally configure Rails Admin\n+if install_rails_admin\n+ run \"#{rvm_do} rails generate rails_admin:install\"\n+ inside \"config/initializers\" do\n+ gsub_file \"rails_admin.rb\",\n+ /# config.authenticate_with do/,\n+ \"config.authenticate_with do\"\n+ gsub_file \"rails_admin.rb\",\n+ /# warden.authenticate! scope: :user/,\n+ \" warden.authenticate! scope: :user\"\n+ gsub_file \"rails_admin.rb\",\n+ /# end/,\n+ \"end\"\n+ gsub_file \"rails_admin.rb\",\n+ /# config.current_user_method\\(&:current_user\\)/,\n+ \"config.current_user_method(&:current_user)\"\n+ end\n+end\n+\n+# Configure exception logging with Raven/Sentry\n+inside \"config/initializers\" do\n+\tcopy_file \"raven.rb\"\n+\tgsub_file \"raven.rb\",\n+ /APPLICATION_UNDERSCORE_NAME/,\n+ app_name\n+\tgsub_file \"raven.rb\",\n+ /APPLICATION_NAME/,\n+ app_name.camelize\n+end\n+\n+# Misc. configuration\n+inside \"app/jobs\" do\n+ remove_file \"application_job.rb\"\n+end\n+inside \"config\" do\n+ insert_into_file \"application.rb\",\n+ \"\\n config.time_zone = \\\"#{timezone}\\\"\\n\",\n+ after: \"class Application < Rails::Application\"\n+end\n+\n+# Update with code conventions\n+copy_file \".rubocop.yml\"\n+run \"#{rvm_do} rubocop -a\"\n+inside \"app\" do\n+ insert_into_file \"controllers/application_controller.rb\",\n+ \"# Controller superclass.\\n\",\n+ before: \"class ApplicationController < ActionController::Base\"\n+ insert_into_file \"helpers/application_helper.rb\",\n+ \"# Default helper module.\\n\",\n+ before: \"module ApplicationHelper\"\n+ insert_into_file \"mailers/application_mailer.rb\",\n+ \"# Mailer superclass.\\n\",\n+ before: \"class ApplicationMailer < ActionMailer::Base\"\n+ insert_into_file \"models/application_record.rb\",\n+ \"# Persisted model superclass.\\n\",\n+ before: \"class ApplicationRecord < ActiveRecord::Base\"\n+end\n+\n+# Prepare database\n+run \"#{rvm_do} rails db:create db:migrate\"","path":"rails5.rb","position":248,"original_position":248,"commit_id":"3fdf514155e6d09f7e4cdda44620851cbf2695b2","original_commit_id":"3fdf514155e6d09f7e4cdda44620851cbf2695b2","user":{"login":"ericcf","id":58693,"avatar_url":"https://avatars.githubusercontent.com/u/58693?v=3","gravatar_id":"","url":"https://api.github.com/users/ericcf","html_url":"https://github.com/ericcf","followers_url":"https://api.github.com/users/ericcf/followers","following_url":"https://api.github.com/users/ericcf/following{/other_user}","gists_url":"https://api.github.com/users/ericcf/gists{/gist_id}","starred_url":"https://api.github.com/users/ericcf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericcf/subscriptions","organizations_url":"https://api.github.com/users/ericcf/orgs","repos_url":"https://api.github.com/users/ericcf/repos","events_url":"https://api.github.com/users/ericcf/events{/privacy}","received_events_url":"https://api.github.com/users/ericcf/received_events","type":"User","site_admin":false},"body":"Yeah, I didn't realize that `rails db:create` creates both test and development databases, but migrate only migrates the current environment...","created_at":"2017-01-11T14:43:04Z","updated_at":"2017-01-11T14:43:04Z","html_url":"https://github.com/NU-CBITS/rails-templates/pull/1#discussion_r95590600","pull_request_url":"https://api.github.com/repos/NU-CBITS/rails-templates/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/NU-CBITS/rails-templates/pulls/comments/95590600"},"html":{"href":"https://github.com/NU-CBITS/rails-templates/pull/1#discussion_r95590600"},"pull_request":{"href":"https://api.github.com/repos/NU-CBITS/rails-templates/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/NU-CBITS/rails-templates/pulls/1","id":100949323,"html_url":"https://github.com/NU-CBITS/rails-templates/pull/1","diff_url":"https://github.com/NU-CBITS/rails-templates/pull/1.diff","patch_url":"https://github.com/NU-CBITS/rails-templates/pull/1.patch","issue_url":"https://api.github.com/repos/NU-CBITS/rails-templates/issues/1","number":1,"state":"open","locked":false,"title":"create initial template for Rails 5 apps","user":{"login":"ericcf","id":58693,"avatar_url":"https://avatars.githubusercontent.com/u/58693?v=3","gravatar_id":"","url":"https://api.github.com/users/ericcf","html_url":"https://github.com/ericcf","followers_url":"https://api.github.com/users/ericcf/followers","following_url":"https://api.github.com/users/ericcf/following{/other_user}","gists_url":"https://api.github.com/users/ericcf/gists{/gist_id}","starred_url":"https://api.github.com/users/ericcf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericcf/subscriptions","organizations_url":"https://api.github.com/users/ericcf/orgs","repos_url":"https://api.github.com/users/ericcf/repos","events_url":"https://api.github.com/users/ericcf/events{/privacy}","received_events_url":"https://api.github.com/users/ericcf/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-10T20:39:06Z","updated_at":"2017-01-11T14:43:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3188198eef894003b269f2e7e44cbadd2c16f928","assignee":{"login":"michaelwehrley","id":526136,"avatar_url":"https://avatars.githubusercontent.com/u/526136?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelwehrley","html_url":"https://github.com/michaelwehrley","followers_url":"https://api.github.com/users/michaelwehrley/followers","following_url":"https://api.github.com/users/michaelwehrley/following{/other_user}","gists_url":"https://api.github.com/users/michaelwehrley/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwehrley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwehrley/subscriptions","organizations_url":"https://api.github.com/users/michaelwehrley/orgs","repos_url":"https://api.github.com/users/michaelwehrley/repos","events_url":"https://api.github.com/users/michaelwehrley/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwehrley/received_events","type":"User","site_admin":false},"assignees":[{"login":"michaelwehrley","id":526136,"avatar_url":"https://avatars.githubusercontent.com/u/526136?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelwehrley","html_url":"https://github.com/michaelwehrley","followers_url":"https://api.github.com/users/michaelwehrley/followers","following_url":"https://api.github.com/users/michaelwehrley/following{/other_user}","gists_url":"https://api.github.com/users/michaelwehrley/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwehrley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwehrley/subscriptions","organizations_url":"https://api.github.com/users/michaelwehrley/orgs","repos_url":"https://api.github.com/users/michaelwehrley/repos","events_url":"https://api.github.com/users/michaelwehrley/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwehrley/received_events","type":"User","site_admin":false},{"login":"eschlange","id":4666065,"avatar_url":"https://avatars.githubusercontent.com/u/4666065?v=3","gravatar_id":"","url":"https://api.github.com/users/eschlange","html_url":"https://github.com/eschlange","followers_url":"https://api.github.com/users/eschlange/followers","following_url":"https://api.github.com/users/eschlange/following{/other_user}","gists_url":"https://api.github.com/users/eschlange/gists{/gist_id}","starred_url":"https://api.github.com/users/eschlange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eschlange/subscriptions","organizations_url":"https://api.github.com/users/eschlange/orgs","repos_url":"https://api.github.com/users/eschlange/repos","events_url":"https://api.github.com/users/eschlange/events{/privacy}","received_events_url":"https://api.github.com/users/eschlange/received_events","type":"User","site_admin":false},{"login":"cbrenner04","id":7211856,"avatar_url":"https://avatars.githubusercontent.com/u/7211856?v=3","gravatar_id":"","url":"https://api.github.com/users/cbrenner04","html_url":"https://github.com/cbrenner04","followers_url":"https://api.github.com/users/cbrenner04/followers","following_url":"https://api.github.com/users/cbrenner04/following{/other_user}","gists_url":"https://api.github.com/users/cbrenner04/gists{/gist_id}","starred_url":"https://api.github.com/users/cbrenner04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbrenner04/subscriptions","organizations_url":"https://api.github.com/users/cbrenner04/orgs","repos_url":"https://api.github.com/users/cbrenner04/repos","events_url":"https://api.github.com/users/cbrenner04/events{/privacy}","received_events_url":"https://api.github.com/users/cbrenner04/received_events","type":"User","site_admin":false},{"login":"a-ashbeck","id":17259710,"avatar_url":"https://avatars.githubusercontent.com/u/17259710?v=3","gravatar_id":"","url":"https://api.github.com/users/a-ashbeck","html_url":"https://github.com/a-ashbeck","followers_url":"https://api.github.com/users/a-ashbeck/followers","following_url":"https://api.github.com/users/a-ashbeck/following{/other_user}","gists_url":"https://api.github.com/users/a-ashbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/a-ashbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-ashbeck/subscriptions","organizations_url":"https://api.github.com/users/a-ashbeck/orgs","repos_url":"https://api.github.com/users/a-ashbeck/repos","events_url":"https://api.github.com/users/a-ashbeck/events{/privacy}","received_events_url":"https://api.github.com/users/a-ashbeck/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NU-CBITS/rails-templates/pulls/1/commits","review_comments_url":"https://api.github.com/repos/NU-CBITS/rails-templates/pulls/1/comments","review_comment_url":"https://api.github.com/repos/NU-CBITS/rails-templates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NU-CBITS/rails-templates/issues/1/comments","statuses_url":"https://api.github.com/repos/NU-CBITS/rails-templates/statuses/3fdf514155e6d09f7e4cdda44620851cbf2695b2","head":{"label":"NU-CBITS:ecf-rails5","ref":"ecf-rails5","sha":"3fdf514155e6d09f7e4cdda44620851cbf2695b2","user":{"login":"NU-CBITS","id":3345230,"avatar_url":"https://avatars.githubusercontent.com/u/3345230?v=3","gravatar_id":"","url":"https://api.github.com/users/NU-CBITS","html_url":"https://github.com/NU-CBITS","followers_url":"https://api.github.com/users/NU-CBITS/followers","following_url":"https://api.github.com/users/NU-CBITS/following{/other_user}","gists_url":"https://api.github.com/users/NU-CBITS/gists{/gist_id}","starred_url":"https://api.github.com/users/NU-CBITS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NU-CBITS/subscriptions","organizations_url":"https://api.github.com/users/NU-CBITS/orgs","repos_url":"https://api.github.com/users/NU-CBITS/repos","events_url":"https://api.github.com/users/NU-CBITS/events{/privacy}","received_events_url":"https://api.github.com/users/NU-CBITS/received_events","type":"Organization","site_admin":false},"repo":{"id":17408907,"name":"rails-templates","full_name":"NU-CBITS/rails-templates","owner":{"login":"NU-CBITS","id":3345230,"avatar_url":"https://avatars.githubusercontent.com/u/3345230?v=3","gravatar_id":"","url":"https://api.github.com/users/NU-CBITS","html_url":"https://github.com/NU-CBITS","followers_url":"https://api.github.com/users/NU-CBITS/followers","following_url":"https://api.github.com/users/NU-CBITS/following{/other_user}","gists_url":"https://api.github.com/users/NU-CBITS/gists{/gist_id}","starred_url":"https://api.github.com/users/NU-CBITS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NU-CBITS/subscriptions","organizations_url":"https://api.github.com/users/NU-CBITS/orgs","repos_url":"https://api.github.com/users/NU-CBITS/repos","events_url":"https://api.github.com/users/NU-CBITS/events{/privacy}","received_events_url":"https://api.github.com/users/NU-CBITS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NU-CBITS/rails-templates","description":"Templates for common CBITs Rails setups.","fork":false,"url":"https://api.github.com/repos/NU-CBITS/rails-templates","forks_url":"https://api.github.com/repos/NU-CBITS/rails-templates/forks","keys_url":"https://api.github.com/repos/NU-CBITS/rails-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NU-CBITS/rails-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NU-CBITS/rails-templates/teams","hooks_url":"https://api.github.com/repos/NU-CBITS/rails-templates/hooks","issue_events_url":"https://api.github.com/repos/NU-CBITS/rails-templates/issues/events{/number}","events_url":"https://api.github.com/repos/NU-CBITS/rails-templates/events","assignees_url":"https://api.github.com/repos/NU-CBITS/rails-templates/assignees{/user}","branches_url":"https://api.github.com/repos/NU-CBITS/rails-templates/branches{/branch}","tags_url":"https://api.github.com/repos/NU-CBITS/rails-templates/tags","blobs_url":"https://api.github.com/repos/NU-CBITS/rails-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NU-CBITS/rails-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NU-CBITS/rails-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/NU-CBITS/rails-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NU-CBITS/rails-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/NU-CBITS/rails-templates/languages","stargazers_url":"https://api.github.com/repos/NU-CBITS/rails-templates/stargazers","contributors_url":"https://api.github.com/repos/NU-CBITS/rails-templates/contributors","subscribers_url":"https://api.github.com/repos/NU-CBITS/rails-templates/subscribers","subscription_url":"https://api.github.com/repos/NU-CBITS/rails-templates/subscription","commits_url":"https://api.github.com/repos/NU-CBITS/rails-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/NU-CBITS/rails-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/NU-CBITS/rails-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/NU-CBITS/rails-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/NU-CBITS/rails-templates/contents/{+path}","compare_url":"https://api.github.com/repos/NU-CBITS/rails-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NU-CBITS/rails-templates/merges","archive_url":"https://api.github.com/repos/NU-CBITS/rails-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NU-CBITS/rails-templates/downloads","issues_url":"https://api.github.com/repos/NU-CBITS/rails-templates/issues{/number}","pulls_url":"https://api.github.com/repos/NU-CBITS/rails-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/NU-CBITS/rails-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/NU-CBITS/rails-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NU-CBITS/rails-templates/labels{/name}","releases_url":"https://api.github.com/repos/NU-CBITS/rails-templates/releases{/id}","deployments_url":"https://api.github.com/repos/NU-CBITS/rails-templates/deployments","created_at":"2014-03-04T16:36:17Z","updated_at":"2016-05-23T14:32:26Z","pushed_at":"2017-01-10T20:39:06Z","git_url":"git://github.com/NU-CBITS/rails-templates.git","ssh_url":"[email protected]:NU-CBITS/rails-templates.git","clone_url":"https://github.com/NU-CBITS/rails-templates.git","svn_url":"https://github.com/NU-CBITS/rails-templates","homepage":"","size":13,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"NU-CBITS:master","ref":"master","sha":"2419e1487e110b31d8dfbb60d38291b86e3db03d","user":{"login":"NU-CBITS","id":3345230,"avatar_url":"https://avatars.githubusercontent.com/u/3345230?v=3","gravatar_id":"","url":"https://api.github.com/users/NU-CBITS","html_url":"https://github.com/NU-CBITS","followers_url":"https://api.github.com/users/NU-CBITS/followers","following_url":"https://api.github.com/users/NU-CBITS/following{/other_user}","gists_url":"https://api.github.com/users/NU-CBITS/gists{/gist_id}","starred_url":"https://api.github.com/users/NU-CBITS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NU-CBITS/subscriptions","organizations_url":"https://api.github.com/users/NU-CBITS/orgs","repos_url":"https://api.github.com/users/NU-CBITS/repos","events_url":"https://api.github.com/users/NU-CBITS/events{/privacy}","received_events_url":"https://api.github.com/users/NU-CBITS/received_events","type":"Organization","site_admin":false},"repo":{"id":17408907,"name":"rails-templates","full_name":"NU-CBITS/rails-templates","owner":{"login":"NU-CBITS","id":3345230,"avatar_url":"https://avatars.githubusercontent.com/u/3345230?v=3","gravatar_id":"","url":"https://api.github.com/users/NU-CBITS","html_url":"https://github.com/NU-CBITS","followers_url":"https://api.github.com/users/NU-CBITS/followers","following_url":"https://api.github.com/users/NU-CBITS/following{/other_user}","gists_url":"https://api.github.com/users/NU-CBITS/gists{/gist_id}","starred_url":"https://api.github.com/users/NU-CBITS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NU-CBITS/subscriptions","organizations_url":"https://api.github.com/users/NU-CBITS/orgs","repos_url":"https://api.github.com/users/NU-CBITS/repos","events_url":"https://api.github.com/users/NU-CBITS/events{/privacy}","received_events_url":"https://api.github.com/users/NU-CBITS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NU-CBITS/rails-templates","description":"Templates for common CBITs Rails setups.","fork":false,"url":"https://api.github.com/repos/NU-CBITS/rails-templates","forks_url":"https://api.github.com/repos/NU-CBITS/rails-templates/forks","keys_url":"https://api.github.com/repos/NU-CBITS/rails-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NU-CBITS/rails-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NU-CBITS/rails-templates/teams","hooks_url":"https://api.github.com/repos/NU-CBITS/rails-templates/hooks","issue_events_url":"https://api.github.com/repos/NU-CBITS/rails-templates/issues/events{/number}","events_url":"https://api.github.com/repos/NU-CBITS/rails-templates/events","assignees_url":"https://api.github.com/repos/NU-CBITS/rails-templates/assignees{/user}","branches_url":"https://api.github.com/repos/NU-CBITS/rails-templates/branches{/branch}","tags_url":"https://api.github.com/repos/NU-CBITS/rails-templates/tags","blobs_url":"https://api.github.com/repos/NU-CBITS/rails-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NU-CBITS/rails-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NU-CBITS/rails-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/NU-CBITS/rails-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NU-CBITS/rails-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/NU-CBITS/rails-templates/languages","stargazers_url":"https://api.github.com/repos/NU-CBITS/rails-templates/stargazers","contributors_url":"https://api.github.com/repos/NU-CBITS/rails-templates/contributors","subscribers_url":"https://api.github.com/repos/NU-CBITS/rails-templates/subscribers","subscription_url":"https://api.github.com/repos/NU-CBITS/rails-templates/subscription","commits_url":"https://api.github.com/repos/NU-CBITS/rails-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/NU-CBITS/rails-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/NU-CBITS/rails-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/NU-CBITS/rails-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/NU-CBITS/rails-templates/contents/{+path}","compare_url":"https://api.github.com/repos/NU-CBITS/rails-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NU-CBITS/rails-templates/merges","archive_url":"https://api.github.com/repos/NU-CBITS/rails-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NU-CBITS/rails-templates/downloads","issues_url":"https://api.github.com/repos/NU-CBITS/rails-templates/issues{/number}","pulls_url":"https://api.github.com/repos/NU-CBITS/rails-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/NU-CBITS/rails-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/NU-CBITS/rails-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NU-CBITS/rails-templates/labels{/name}","releases_url":"https://api.github.com/repos/NU-CBITS/rails-templates/releases{/id}","deployments_url":"https://api.github.com/repos/NU-CBITS/rails-templates/deployments","created_at":"2014-03-04T16:36:17Z","updated_at":"2016-05-23T14:32:26Z","pushed_at":"2017-01-10T20:39:06Z","git_url":"git://github.com/NU-CBITS/rails-templates.git","ssh_url":"[email protected]:NU-CBITS/rails-templates.git","clone_url":"https://github.com/NU-CBITS/rails-templates.git","svn_url":"https://github.com/NU-CBITS/rails-templates","homepage":"","size":13,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NU-CBITS/rails-templates/pulls/1"},"html":{"href":"https://github.com/NU-CBITS/rails-templates/pull/1"},"issue":{"href":"https://api.github.com/repos/NU-CBITS/rails-templates/issues/1"},"comments":{"href":"https://api.github.com/repos/NU-CBITS/rails-templates/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/NU-CBITS/rails-templates/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/NU-CBITS/rails-templates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NU-CBITS/rails-templates/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/NU-CBITS/rails-templates/statuses/3fdf514155e6d09f7e4cdda44620851cbf2695b2"}}}} | {
"id": 17408907,
"name": "NU-CBITS/rails-templates",
"url": "https://api.github.com/repos/NU-CBITS/rails-templates"
} | {
"id": 58693,
"login": "ericcf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/58693?",
"url": "https://api.github.com/users/ericcf"
} | {
"id": 3345230,
"login": "NU-CBITS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3345230?",
"url": "https://api.github.com/orgs/NU-CBITS"
} | 2017-01-11T14:43:04 | 5136194976 | {"actor":{"display_login":"ericcf"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/pulls/comments/99650484","pull_request_review_id":20333752,"id":99650484,"diff_hunk":"@@ -117,26 +138,37 @@ function getAppInfo() {\n }\n \n var scopes = scriptTag.getAttribute(\"scopes\");\n- if (!scopes) {\n- alert(\"the odauth script tag needs a scopes attribute set to the scopes your app needs\");\n- }\n+ // if (!scopes) {","path":"odauth.js","position":64,"original_position":64,"commit_id":"ae57ffc649147fc56adf0a17967ae5d578758e3b","original_commit_id":"ae57ffc649147fc56adf0a17967ae5d578758e3b","user":{"login":"rgregg","id":1435771,"avatar_url":"https://avatars.githubusercontent.com/u/1435771?v=3","gravatar_id":"","url":"https://api.github.com/users/rgregg","html_url":"https://github.com/rgregg","followers_url":"https://api.github.com/users/rgregg/followers","following_url":"https://api.github.com/users/rgregg/following{/other_user}","gists_url":"https://api.github.com/users/rgregg/gists{/gist_id}","starred_url":"https://api.github.com/users/rgregg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgregg/subscriptions","organizations_url":"https://api.github.com/users/rgregg/orgs","repos_url":"https://api.github.com/users/rgregg/repos","events_url":"https://api.github.com/users/rgregg/events{/privacy}","received_events_url":"https://api.github.com/users/rgregg/received_events","type":"User","site_admin":false},"body":"You left it there :).","created_at":"2017-02-06T18:26:45Z","updated_at":"2017-02-06T18:26:46Z","html_url":"https://github.com/OneDrive/onedrive-explorer-js/pull/7#discussion_r99650484","pull_request_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/pulls/comments/99650484"},"html":{"href":"https://github.com/OneDrive/onedrive-explorer-js/pull/7#discussion_r99650484"},"pull_request":{"href":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/pulls/7","id":104719371,"html_url":"https://github.com/OneDrive/onedrive-explorer-js/pull/7","diff_url":"https://github.com/OneDrive/onedrive-explorer-js/pull/7.diff","patch_url":"https://github.com/OneDrive/onedrive-explorer-js/pull/7.patch","issue_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/issues/7","number":7,"state":"open","locked":false,"title":"Update sample for Microsoft Graph","user":{"login":"rgregg","id":1435771,"avatar_url":"https://avatars.githubusercontent.com/u/1435771?v=3","gravatar_id":"","url":"https://api.github.com/users/rgregg","html_url":"https://github.com/rgregg","followers_url":"https://api.github.com/users/rgregg/followers","following_url":"https://api.github.com/users/rgregg/following{/other_user}","gists_url":"https://api.github.com/users/rgregg/gists{/gist_id}","starred_url":"https://api.github.com/users/rgregg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgregg/subscriptions","organizations_url":"https://api.github.com/users/rgregg/orgs","repos_url":"https://api.github.com/users/rgregg/repos","events_url":"https://api.github.com/users/rgregg/events{/privacy}","received_events_url":"https://api.github.com/users/rgregg/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-05T22:42:45Z","updated_at":"2017-02-06T18:26:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7c1c0e909c03327d1feccf6d27a16da912270cf","assignee":{"login":"rgregg","id":1435771,"avatar_url":"https://avatars.githubusercontent.com/u/1435771?v=3","gravatar_id":"","url":"https://api.github.com/users/rgregg","html_url":"https://github.com/rgregg","followers_url":"https://api.github.com/users/rgregg/followers","following_url":"https://api.github.com/users/rgregg/following{/other_user}","gists_url":"https://api.github.com/users/rgregg/gists{/gist_id}","starred_url":"https://api.github.com/users/rgregg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgregg/subscriptions","organizations_url":"https://api.github.com/users/rgregg/orgs","repos_url":"https://api.github.com/users/rgregg/repos","events_url":"https://api.github.com/users/rgregg/events{/privacy}","received_events_url":"https://api.github.com/users/rgregg/received_events","type":"User","site_admin":false},"assignees":[{"login":"rgregg","id":1435771,"avatar_url":"https://avatars.githubusercontent.com/u/1435771?v=3","gravatar_id":"","url":"https://api.github.com/users/rgregg","html_url":"https://github.com/rgregg","followers_url":"https://api.github.com/users/rgregg/followers","following_url":"https://api.github.com/users/rgregg/following{/other_user}","gists_url":"https://api.github.com/users/rgregg/gists{/gist_id}","starred_url":"https://api.github.com/users/rgregg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgregg/subscriptions","organizations_url":"https://api.github.com/users/rgregg/orgs","repos_url":"https://api.github.com/users/rgregg/repos","events_url":"https://api.github.com/users/rgregg/events{/privacy}","received_events_url":"https://api.github.com/users/rgregg/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/pulls/7/commits","review_comments_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/pulls/7/comments","review_comment_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/issues/7/comments","statuses_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/statuses/ae57ffc649147fc56adf0a17967ae5d578758e3b","head":{"label":"rgregg:graph-api-update","ref":"graph-api-update","sha":"ae57ffc649147fc56adf0a17967ae5d578758e3b","user":{"login":"rgregg","id":1435771,"avatar_url":"https://avatars.githubusercontent.com/u/1435771?v=3","gravatar_id":"","url":"https://api.github.com/users/rgregg","html_url":"https://github.com/rgregg","followers_url":"https://api.github.com/users/rgregg/followers","following_url":"https://api.github.com/users/rgregg/following{/other_user}","gists_url":"https://api.github.com/users/rgregg/gists{/gist_id}","starred_url":"https://api.github.com/users/rgregg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgregg/subscriptions","organizations_url":"https://api.github.com/users/rgregg/orgs","repos_url":"https://api.github.com/users/rgregg/repos","events_url":"https://api.github.com/users/rgregg/events{/privacy}","received_events_url":"https://api.github.com/users/rgregg/received_events","type":"User","site_admin":false},"repo":{"id":33144190,"name":"onedrive-explorer-js","full_name":"rgregg/onedrive-explorer-js","owner":{"login":"rgregg","id":1435771,"avatar_url":"https://avatars.githubusercontent.com/u/1435771?v=3","gravatar_id":"","url":"https://api.github.com/users/rgregg","html_url":"https://github.com/rgregg","followers_url":"https://api.github.com/users/rgregg/followers","following_url":"https://api.github.com/users/rgregg/following{/other_user}","gists_url":"https://api.github.com/users/rgregg/gists{/gist_id}","starred_url":"https://api.github.com/users/rgregg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgregg/subscriptions","organizations_url":"https://api.github.com/users/rgregg/orgs","repos_url":"https://api.github.com/users/rgregg/repos","events_url":"https://api.github.com/users/rgregg/events{/privacy}","received_events_url":"https://api.github.com/users/rgregg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rgregg/onedrive-explorer-js","description":null,"fork":true,"url":"https://api.github.com/repos/rgregg/onedrive-explorer-js","forks_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/forks","keys_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/teams","hooks_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/hooks","issue_events_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/issues/events{/number}","events_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/events","assignees_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/assignees{/user}","branches_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/branches{/branch}","tags_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/tags","blobs_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/statuses/{sha}","languages_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/languages","stargazers_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/stargazers","contributors_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/contributors","subscribers_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/subscribers","subscription_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/subscription","commits_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/contents/{+path}","compare_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/merges","archive_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/downloads","issues_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/issues{/number}","pulls_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/pulls{/number}","milestones_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/milestones{/number}","notifications_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/labels{/name}","releases_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/releases{/id}","deployments_url":"https://api.github.com/repos/rgregg/onedrive-explorer-js/deployments","created_at":"2015-03-30T19:47:24Z","updated_at":"2015-05-01T01:36:15Z","pushed_at":"2017-02-05T23:05:24Z","git_url":"git://github.com/rgregg/onedrive-explorer-js.git","ssh_url":"[email protected]:rgregg/onedrive-explorer-js.git","clone_url":"https://github.com/rgregg/onedrive-explorer-js.git","svn_url":"https://github.com/rgregg/onedrive-explorer-js","homepage":null,"size":46,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OneDrive:master","ref":"master","sha":"f7199b0523f5216e0a79baea1df2279903fa7b04","user":{"login":"OneDrive","id":7130569,"avatar_url":"https://avatars.githubusercontent.com/u/7130569?v=3","gravatar_id":"","url":"https://api.github.com/users/OneDrive","html_url":"https://github.com/OneDrive","followers_url":"https://api.github.com/users/OneDrive/followers","following_url":"https://api.github.com/users/OneDrive/following{/other_user}","gists_url":"https://api.github.com/users/OneDrive/gists{/gist_id}","starred_url":"https://api.github.com/users/OneDrive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneDrive/subscriptions","organizations_url":"https://api.github.com/users/OneDrive/orgs","repos_url":"https://api.github.com/users/OneDrive/repos","events_url":"https://api.github.com/users/OneDrive/events{/privacy}","received_events_url":"https://api.github.com/users/OneDrive/received_events","type":"Organization","site_admin":false},"repo":{"id":31246769,"name":"onedrive-explorer-js","full_name":"OneDrive/onedrive-explorer-js","owner":{"login":"OneDrive","id":7130569,"avatar_url":"https://avatars.githubusercontent.com/u/7130569?v=3","gravatar_id":"","url":"https://api.github.com/users/OneDrive","html_url":"https://github.com/OneDrive","followers_url":"https://api.github.com/users/OneDrive/followers","following_url":"https://api.github.com/users/OneDrive/following{/other_user}","gists_url":"https://api.github.com/users/OneDrive/gists{/gist_id}","starred_url":"https://api.github.com/users/OneDrive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneDrive/subscriptions","organizations_url":"https://api.github.com/users/OneDrive/orgs","repos_url":"https://api.github.com/users/OneDrive/repos","events_url":"https://api.github.com/users/OneDrive/events{/privacy}","received_events_url":"https://api.github.com/users/OneDrive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OneDrive/onedrive-explorer-js","description":"OneDrive sample application for JavaScript.","fork":false,"url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js","forks_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/forks","keys_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/teams","hooks_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/hooks","issue_events_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/issues/events{/number}","events_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/events","assignees_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/assignees{/user}","branches_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/branches{/branch}","tags_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/tags","blobs_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/statuses/{sha}","languages_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/languages","stargazers_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/stargazers","contributors_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/contributors","subscribers_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/subscribers","subscription_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/subscription","commits_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/contents/{+path}","compare_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/merges","archive_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/downloads","issues_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/issues{/number}","pulls_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/pulls{/number}","milestones_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/milestones{/number}","notifications_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/labels{/name}","releases_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/releases{/id}","deployments_url":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/deployments","created_at":"2015-02-24T05:52:11Z","updated_at":"2017-02-03T09:43:54Z","pushed_at":"2017-02-05T23:05:25Z","git_url":"git://github.com/OneDrive/onedrive-explorer-js.git","ssh_url":"[email protected]:OneDrive/onedrive-explorer-js.git","clone_url":"https://github.com/OneDrive/onedrive-explorer-js.git","svn_url":"https://github.com/OneDrive/onedrive-explorer-js","homepage":null,"size":20,"stargazers_count":44,"watchers_count":44,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":4,"forks":38,"open_issues":4,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/pulls/7"},"html":{"href":"https://github.com/OneDrive/onedrive-explorer-js/pull/7"},"issue":{"href":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/issues/7"},"comments":{"href":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/OneDrive/onedrive-explorer-js/statuses/ae57ffc649147fc56adf0a17967ae5d578758e3b"}}}} | {
"id": 31246769,
"name": "OneDrive/onedrive-explorer-js",
"url": "https://api.github.com/repos/OneDrive/onedrive-explorer-js"
} | {
"id": 1435771,
"login": "rgregg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1435771?",
"url": "https://api.github.com/users/rgregg"
} | {
"id": 7130569,
"login": "OneDrive",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7130569?",
"url": "https://api.github.com/orgs/OneDrive"
} | 2017-02-06T18:26:45 | 5274629160 | {"actor":{"display_login":"rgregg"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OpenGrok/OpenGrok/pulls/comments/127217976","pull_request_review_id":49779078,"id":127217976,"diff_hunk":"@@ -129,28 +147,28 @@ public void setUp() throws Exception {\n directory = FileUtilities.createTemporaryDirectory(\"directory\");\n \n entries = new FileEntry[3];\n- entries[0] = new FileEntry(\"foo.c\", \"foo.c\", 0, 1);\n- entries[1] = new FileEntry(\"bar.h\", \"bar.h\", Long.MAX_VALUE, 0);\n- entries[2] = null;\n+ entries[0] = new FileEntry(\"foo.c\", \"foo.c\", 0, 112, null);\n+ entries[1] = new FileEntry(\"bar.h\", \"bar.h\", Long.MAX_VALUE, 0, null);\n+ // Will test getSimplifiedPath() behavior for ignored directories.\n+ // Use DIRECTORY_INTERNAL_SIZE value for length so it is checked as the directory\n+ // should contain \"-\" (DIRECTORY_SIZE_PLACEHOLDER) string.\n+ entries[2] = new FileEntry(\"subdir\", \"subdir/\", 0, DIRECTORY_INTERNAL_SIZE, Arrays.asList(\n+ new FileEntry[]{\n+ new FileEntry(\"SCCS\", \"SCCS\", 0, DIRECTORY_INTERNAL_SIZE, Arrays.asList(","path":"test/org/opensolaris/opengrok/web/DirectoryListingTest.java","position":null,"original_position":148,"commit_id":"fc875148584e36fb6f91cd80d0f466a9dd01eaf6","original_commit_id":"75e0b09a49261d1a719f3e1a65652d780282ced3","user":{"login":"tulinkry","id":6997160,"avatar_url":"https://avatars2.githubusercontent.com/u/6997160?v=3","gravatar_id":"","url":"https://api.github.com/users/tulinkry","html_url":"https://github.com/tulinkry","followers_url":"https://api.github.com/users/tulinkry/followers","following_url":"https://api.github.com/users/tulinkry/following{/other_user}","gists_url":"https://api.github.com/users/tulinkry/gists{/gist_id}","starred_url":"https://api.github.com/users/tulinkry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tulinkry/subscriptions","organizations_url":"https://api.github.com/users/tulinkry/orgs","repos_url":"https://api.github.com/users/tulinkry/repos","events_url":"https://api.github.com/users/tulinkry/events{/privacy}","received_events_url":"https://api.github.com/users/tulinkry/received_events","type":"User","site_admin":false},"body":"yes it should, changed","created_at":"2017-07-13T13:36:52Z","updated_at":"2017-07-13T13:36:52Z","html_url":"https://github.com/OpenGrok/OpenGrok/pull/1617#discussion_r127217976","pull_request_url":"https://api.github.com/repos/OpenGrok/OpenGrok/pulls/1617","_links":{"self":{"href":"https://api.github.com/repos/OpenGrok/OpenGrok/pulls/comments/127217976"},"html":{"href":"https://github.com/OpenGrok/OpenGrok/pull/1617#discussion_r127217976"},"pull_request":{"href":"https://api.github.com/repos/OpenGrok/OpenGrok/pulls/1617"}}},"pull_request":{"url":"https://api.github.com/repos/OpenGrok/OpenGrok/pulls/1617","id":122900165,"html_url":"https://github.com/OpenGrok/OpenGrok/pull/1617","diff_url":"https://github.com/OpenGrok/OpenGrok/pull/1617.diff","patch_url":"https://github.com/OpenGrok/OpenGrok/pull/1617.patch","issue_url":"https://api.github.com/repos/OpenGrok/OpenGrok/issues/1617","number":1617,"state":"open","locked":false,"title":"removing the size for a directory in directory listing","user":{"login":"tulinkry","id":6997160,"avatar_url":"https://avatars2.githubusercontent.com/u/6997160?v=3","gravatar_id":"","url":"https://api.github.com/users/tulinkry","html_url":"https://github.com/tulinkry","followers_url":"https://api.github.com/users/tulinkry/followers","following_url":"https://api.github.com/users/tulinkry/following{/other_user}","gists_url":"https://api.github.com/users/tulinkry/gists{/gist_id}","starred_url":"https://api.github.com/users/tulinkry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tulinkry/subscriptions","organizations_url":"https://api.github.com/users/tulinkry/orgs","repos_url":"https://api.github.com/users/tulinkry/repos","events_url":"https://api.github.com/users/tulinkry/events{/privacy}","received_events_url":"https://api.github.com/users/tulinkry/received_events","type":"User","site_admin":false},"body":"fixes #1552\r\n\r\nReplaced with '-'.\r\n\r\n\r\n\r\n\r\nTablesorters return 0 for all directories (unparseable size):\r\n```\r\n if (parts === null || parts.length < 3) {\r\n return 0;\r\n }\r\n```","created_at":"2017-05-29T13:57:42Z","updated_at":"2017-07-13T13:36:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a2c533ee2a8323a61b2e93a3de0d2b91b0ae860","assignee":{"login":"tulinkry","id":6997160,"avatar_url":"https://avatars2.githubusercontent.com/u/6997160?v=3","gravatar_id":"","url":"https://api.github.com/users/tulinkry","html_url":"https://github.com/tulinkry","followers_url":"https://api.github.com/users/tulinkry/followers","following_url":"https://api.github.com/users/tulinkry/following{/other_user}","gists_url":"https://api.github.com/users/tulinkry/gists{/gist_id}","starred_url":"https://api.github.com/users/tulinkry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tulinkry/subscriptions","organizations_url":"https://api.github.com/users/tulinkry/orgs","repos_url":"https://api.github.com/users/tulinkry/repos","events_url":"https://api.github.com/users/tulinkry/events{/privacy}","received_events_url":"https://api.github.com/users/tulinkry/received_events","type":"User","site_admin":false},"assignees":[{"login":"tulinkry","id":6997160,"avatar_url":"https://avatars2.githubusercontent.com/u/6997160?v=3","gravatar_id":"","url":"https://api.github.com/users/tulinkry","html_url":"https://github.com/tulinkry","followers_url":"https://api.github.com/users/tulinkry/followers","following_url":"https://api.github.com/users/tulinkry/following{/other_user}","gists_url":"https://api.github.com/users/tulinkry/gists{/gist_id}","starred_url":"https://api.github.com/users/tulinkry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tulinkry/subscriptions","organizations_url":"https://api.github.com/users/tulinkry/orgs","repos_url":"https://api.github.com/users/tulinkry/repos","events_url":"https://api.github.com/users/tulinkry/events{/privacy}","received_events_url":"https://api.github.com/users/tulinkry/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/OpenGrok/OpenGrok/milestones/3","html_url":"https://github.com/OpenGrok/OpenGrok/milestone/3","labels_url":"https://api.github.com/repos/OpenGrok/OpenGrok/milestones/3/labels","id":2294864,"number":3,"title":"1.1","description":"","creator":{"login":"vladak","id":2934284,"avatar_url":"https://avatars0.githubusercontent.com/u/2934284?v=3","gravatar_id":"","url":"https://api.github.com/users/vladak","html_url":"https://github.com/vladak","followers_url":"https://api.github.com/users/vladak/followers","following_url":"https://api.github.com/users/vladak/following{/other_user}","gists_url":"https://api.github.com/users/vladak/gists{/gist_id}","starred_url":"https://api.github.com/users/vladak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladak/subscriptions","organizations_url":"https://api.github.com/users/vladak/orgs","repos_url":"https://api.github.com/users/vladak/repos","events_url":"https://api.github.com/users/vladak/events{/privacy}","received_events_url":"https://api.github.com/users/vladak/received_events","type":"User","site_admin":false},"open_issues":38,"closed_issues":76,"state":"open","created_at":"2017-02-02T11:28:01Z","updated_at":"2017-07-13T13:08:25Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/OpenGrok/OpenGrok/pulls/1617/commits","review_comments_url":"https://api.github.com/repos/OpenGrok/OpenGrok/pulls/1617/comments","review_comment_url":"https://api.github.com/repos/OpenGrok/OpenGrok/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenGrok/OpenGrok/issues/1617/comments","statuses_url":"https://api.github.com/repos/OpenGrok/OpenGrok/statuses/fc875148584e36fb6f91cd80d0f466a9dd01eaf6","head":{"label":"tulinkry:directory-listing","ref":"directory-listing","sha":"fc875148584e36fb6f91cd80d0f466a9dd01eaf6","user":{"login":"tulinkry","id":6997160,"avatar_url":"https://avatars2.githubusercontent.com/u/6997160?v=3","gravatar_id":"","url":"https://api.github.com/users/tulinkry","html_url":"https://github.com/tulinkry","followers_url":"https://api.github.com/users/tulinkry/followers","following_url":"https://api.github.com/users/tulinkry/following{/other_user}","gists_url":"https://api.github.com/users/tulinkry/gists{/gist_id}","starred_url":"https://api.github.com/users/tulinkry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tulinkry/subscriptions","organizations_url":"https://api.github.com/users/tulinkry/orgs","repos_url":"https://api.github.com/users/tulinkry/repos","events_url":"https://api.github.com/users/tulinkry/events{/privacy}","received_events_url":"https://api.github.com/users/tulinkry/received_events","type":"User","site_admin":false},"repo":{"id":42504970,"name":"OpenGrok","full_name":"tulinkry/OpenGrok","owner":{"login":"tulinkry","id":6997160,"avatar_url":"https://avatars2.githubusercontent.com/u/6997160?v=3","gravatar_id":"","url":"https://api.github.com/users/tulinkry","html_url":"https://github.com/tulinkry","followers_url":"https://api.github.com/users/tulinkry/followers","following_url":"https://api.github.com/users/tulinkry/following{/other_user}","gists_url":"https://api.github.com/users/tulinkry/gists{/gist_id}","starred_url":"https://api.github.com/users/tulinkry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tulinkry/subscriptions","organizations_url":"https://api.github.com/users/tulinkry/orgs","repos_url":"https://api.github.com/users/tulinkry/repos","events_url":"https://api.github.com/users/tulinkry/events{/privacy}","received_events_url":"https://api.github.com/users/tulinkry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tulinkry/OpenGrok","description":"Main {OpenGrok git repository","fork":true,"url":"https://api.github.com/repos/tulinkry/OpenGrok","forks_url":"https://api.github.com/repos/tulinkry/OpenGrok/forks","keys_url":"https://api.github.com/repos/tulinkry/OpenGrok/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tulinkry/OpenGrok/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tulinkry/OpenGrok/teams","hooks_url":"https://api.github.com/repos/tulinkry/OpenGrok/hooks","issue_events_url":"https://api.github.com/repos/tulinkry/OpenGrok/issues/events{/number}","events_url":"https://api.github.com/repos/tulinkry/OpenGrok/events","assignees_url":"https://api.github.com/repos/tulinkry/OpenGrok/assignees{/user}","branches_url":"https://api.github.com/repos/tulinkry/OpenGrok/branches{/branch}","tags_url":"https://api.github.com/repos/tulinkry/OpenGrok/tags","blobs_url":"https://api.github.com/repos/tulinkry/OpenGrok/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tulinkry/OpenGrok/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tulinkry/OpenGrok/git/refs{/sha}","trees_url":"https://api.github.com/repos/tulinkry/OpenGrok/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tulinkry/OpenGrok/statuses/{sha}","languages_url":"https://api.github.com/repos/tulinkry/OpenGrok/languages","stargazers_url":"https://api.github.com/repos/tulinkry/OpenGrok/stargazers","contributors_url":"https://api.github.com/repos/tulinkry/OpenGrok/contributors","subscribers_url":"https://api.github.com/repos/tulinkry/OpenGrok/subscribers","subscription_url":"https://api.github.com/repos/tulinkry/OpenGrok/subscription","commits_url":"https://api.github.com/repos/tulinkry/OpenGrok/commits{/sha}","git_commits_url":"https://api.github.com/repos/tulinkry/OpenGrok/git/commits{/sha}","comments_url":"https://api.github.com/repos/tulinkry/OpenGrok/comments{/number}","issue_comment_url":"https://api.github.com/repos/tulinkry/OpenGrok/issues/comments{/number}","contents_url":"https://api.github.com/repos/tulinkry/OpenGrok/contents/{+path}","compare_url":"https://api.github.com/repos/tulinkry/OpenGrok/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tulinkry/OpenGrok/merges","archive_url":"https://api.github.com/repos/tulinkry/OpenGrok/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tulinkry/OpenGrok/downloads","issues_url":"https://api.github.com/repos/tulinkry/OpenGrok/issues{/number}","pulls_url":"https://api.github.com/repos/tulinkry/OpenGrok/pulls{/number}","milestones_url":"https://api.github.com/repos/tulinkry/OpenGrok/milestones{/number}","notifications_url":"https://api.github.com/repos/tulinkry/OpenGrok/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tulinkry/OpenGrok/labels{/name}","releases_url":"https://api.github.com/repos/tulinkry/OpenGrok/releases{/id}","deployments_url":"https://api.github.com/repos/tulinkry/OpenGrok/deployments","created_at":"2015-09-15T08:23:31Z","updated_at":"2016-01-27T10:55:51Z","pushed_at":"2017-07-13T13:35:22Z","git_url":"git://github.com/tulinkry/OpenGrok.git","ssh_url":"[email protected]:tulinkry/OpenGrok.git","clone_url":"https://github.com/tulinkry/OpenGrok.git","svn_url":"https://github.com/tulinkry/OpenGrok","homepage":"http://opengrok.github.io/OpenGrok/","size":17886,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenGrok:master","ref":"master","sha":"541a45fac2d1352b9e8aad12f291d1922d156209","user":{"login":"OpenGrok","id":3205691,"avatar_url":"https://avatars2.githubusercontent.com/u/3205691?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenGrok","html_url":"https://github.com/OpenGrok","followers_url":"https://api.github.com/users/OpenGrok/followers","following_url":"https://api.github.com/users/OpenGrok/following{/other_user}","gists_url":"https://api.github.com/users/OpenGrok/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenGrok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenGrok/subscriptions","organizations_url":"https://api.github.com/users/OpenGrok/orgs","repos_url":"https://api.github.com/users/OpenGrok/repos","events_url":"https://api.github.com/users/OpenGrok/events{/privacy}","received_events_url":"https://api.github.com/users/OpenGrok/received_events","type":"Organization","site_admin":false},"repo":{"id":7481569,"name":"OpenGrok","full_name":"OpenGrok/OpenGrok","owner":{"login":"OpenGrok","id":3205691,"avatar_url":"https://avatars2.githubusercontent.com/u/3205691?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenGrok","html_url":"https://github.com/OpenGrok","followers_url":"https://api.github.com/users/OpenGrok/followers","following_url":"https://api.github.com/users/OpenGrok/following{/other_user}","gists_url":"https://api.github.com/users/OpenGrok/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenGrok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenGrok/subscriptions","organizations_url":"https://api.github.com/users/OpenGrok/orgs","repos_url":"https://api.github.com/users/OpenGrok/repos","events_url":"https://api.github.com/users/OpenGrok/events{/privacy}","received_events_url":"https://api.github.com/users/OpenGrok/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenGrok/OpenGrok","description":"Main {OpenGrok git repository","fork":false,"url":"https://api.github.com/repos/OpenGrok/OpenGrok","forks_url":"https://api.github.com/repos/OpenGrok/OpenGrok/forks","keys_url":"https://api.github.com/repos/OpenGrok/OpenGrok/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenGrok/OpenGrok/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenGrok/OpenGrok/teams","hooks_url":"https://api.github.com/repos/OpenGrok/OpenGrok/hooks","issue_events_url":"https://api.github.com/repos/OpenGrok/OpenGrok/issues/events{/number}","events_url":"https://api.github.com/repos/OpenGrok/OpenGrok/events","assignees_url":"https://api.github.com/repos/OpenGrok/OpenGrok/assignees{/user}","branches_url":"https://api.github.com/repos/OpenGrok/OpenGrok/branches{/branch}","tags_url":"https://api.github.com/repos/OpenGrok/OpenGrok/tags","blobs_url":"https://api.github.com/repos/OpenGrok/OpenGrok/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenGrok/OpenGrok/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenGrok/OpenGrok/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenGrok/OpenGrok/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenGrok/OpenGrok/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenGrok/OpenGrok/languages","stargazers_url":"https://api.github.com/repos/OpenGrok/OpenGrok/stargazers","contributors_url":"https://api.github.com/repos/OpenGrok/OpenGrok/contributors","subscribers_url":"https://api.github.com/repos/OpenGrok/OpenGrok/subscribers","subscription_url":"https://api.github.com/repos/OpenGrok/OpenGrok/subscription","commits_url":"https://api.github.com/repos/OpenGrok/OpenGrok/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenGrok/OpenGrok/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenGrok/OpenGrok/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenGrok/OpenGrok/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenGrok/OpenGrok/contents/{+path}","compare_url":"https://api.github.com/repos/OpenGrok/OpenGrok/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenGrok/OpenGrok/merges","archive_url":"https://api.github.com/repos/OpenGrok/OpenGrok/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenGrok/OpenGrok/downloads","issues_url":"https://api.github.com/repos/OpenGrok/OpenGrok/issues{/number}","pulls_url":"https://api.github.com/repos/OpenGrok/OpenGrok/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenGrok/OpenGrok/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenGrok/OpenGrok/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenGrok/OpenGrok/labels{/name}","releases_url":"https://api.github.com/repos/OpenGrok/OpenGrok/releases{/id}","deployments_url":"https://api.github.com/repos/OpenGrok/OpenGrok/deployments","created_at":"2013-01-07T11:49:18Z","updated_at":"2017-07-13T12:59:24Z","pushed_at":"2017-07-13T13:35:23Z","git_url":"git://github.com/OpenGrok/OpenGrok.git","ssh_url":"[email protected]:OpenGrok/OpenGrok.git","clone_url":"https://github.com/OpenGrok/OpenGrok.git","svn_url":"https://github.com/OpenGrok/OpenGrok","homepage":"http://opengrok.github.io/OpenGrok/","size":17816,"stargazers_count":1618,"watchers_count":1618,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":330,"mirror_url":null,"open_issues_count":397,"forks":330,"open_issues":397,"watchers":1618,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenGrok/OpenGrok/pulls/1617"},"html":{"href":"https://github.com/OpenGrok/OpenGrok/pull/1617"},"issue":{"href":"https://api.github.com/repos/OpenGrok/OpenGrok/issues/1617"},"comments":{"href":"https://api.github.com/repos/OpenGrok/OpenGrok/issues/1617/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenGrok/OpenGrok/pulls/1617/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenGrok/OpenGrok/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenGrok/OpenGrok/pulls/1617/commits"},"statuses":{"href":"https://api.github.com/repos/OpenGrok/OpenGrok/statuses/fc875148584e36fb6f91cd80d0f466a9dd01eaf6"}}}} | {
"id": 7481569,
"name": "OpenGrok/OpenGrok",
"url": "https://api.github.com/repos/OpenGrok/OpenGrok"
} | {
"id": 6997160,
"login": "tulinkry",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6997160?",
"url": "https://api.github.com/users/tulinkry"
} | {
"id": 3205691,
"login": "OpenGrok",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3205691?",
"url": "https://api.github.com/orgs/OpenGrok"
} | 2017-07-13T13:36:52 | 6249552534 | {"actor":{"display_login":"tulinkry"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments/124738579","pull_request_review_id":47055132,"id":124738579,"diff_hunk":"@@ -0,0 +1,326 @@\n+#pragma region Copyright (c) 2014-2017 OpenRCT2 Developers\n+/*****************************************************************************\n+ * OpenRCT2, an open source clone of Roller Coaster Tycoon 2.\n+ *\n+ * OpenRCT2 is the work of many authors, a full list can be found in contributors.md\n+ * For more information, visit https://github.com/OpenRCT2/OpenRCT2\n+ *\n+ * OpenRCT2 is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU General Public License as published by\n+ * the Free Software Foundation, either version 3 of the License, or\n+ * (at your option) any later version.\n+ *\n+ * A full copy of the GNU General Public License can be found in licence.txt\n+ *****************************************************************************/\n+#pragma endregion\n+\n+#include \"../interface/widget.h\"\n+#include \"../interface/window.h\"\n+#include \"../localisation/localisation.h\"\n+#include \"../object/ObjectManager.h\"\n+#include \"../object.h\"\n+#include \"../platform/platform.h\"\n+#include \"../sprites.h\"\n+#include \"../util/util.h\"\n+\n+enum WINDOW_OBJECT_LOAD_ERROR_WIDGET_IDX {\n+ WIDX_BACKGROUND,\n+ WIDX_TITLE,\n+ WIDX_CLOSE,\n+ WIDX_COLUMN_OBJECT_NAME,\n+ WIDX_COLUMN_OBJECT_TYPE,\n+ WIDX_SCROLL,\n+ WIDX_COPY_CURRENT,\n+ WIDX_COPY_ALL\n+};\n+\n+#define WW 400\n+#define WH 400\n+#define LIST_ITEM_HEIGHT 10\n+\n+rct_widget window_object_load_error_widgets[] = {\n+ { WWT_FRAME, 0, 0, WW - 1, 0, WH - 1, STR_NONE, STR_NONE }, // Background\n+ { WWT_CAPTION, 0, 1, WW - 2, 1, 14, STR_OBJECT_LOAD_ERROR_TITLE, STR_WINDOW_TITLE_TIP }, // Title bar\n+ { WWT_CLOSEBOX, 0, WW - 13, WW - 3, 2, 13, STR_CLOSE_X, STR_CLOSE_WINDOW_TIP }, // Close button\n+ { WWT_13, 0, 4, (WW - 5) / 3, 57, 68, STR_OBJECT_NAME, STR_NONE }, // 'Object name' header\n+ { WWT_13, 0, (WW - 5) / 3 + 1, WW - 5 - 1, 57, 68, STR_OBJECT_TYPE, STR_NONE }, // 'Object type' header\n+ { WWT_SCROLL, 0, 4, WW - 5, 68, WH - 40, SCROLL_VERTICAL, STR_NONE }, // Scrollable list area\n+ { WWT_CLOSEBOX, 0, 20, 200, WW - 32, WW - 12, STR_COPY_SELECTED, STR_NONE }, // Copy selected btn\n+ { WWT_CLOSEBOX, 0, 200, 370, WW - 32, WW - 12, STR_COPY_ALL, STR_NONE }, // Copy all btn\n+ { WIDGETS_END },\n+};\n+\n+static rct_string_id get_object_type_string(const rct_object_entry *entry);\n+static void window_object_load_error_close(rct_window *w);\n+static void window_object_load_error_update(rct_window *w);\n+static void window_object_load_error_mouseup(rct_window *w, rct_widgetindex widgetIndex);\n+static void window_object_load_error_scrollgetsize(rct_window *w, sint32 scrollIndex, sint32 *width, sint32 *height);\n+static void window_object_load_error_scrollmouseover(rct_window *w, sint32 scrollIndex, sint32 x, sint32 y);\n+static void window_object_load_error_scrollmousedown(rct_window *w, sint32 scrollIndex, sint32 x, sint32 y);\n+static void window_object_load_error_paint(rct_window *w, rct_drawpixelinfo *dpi);\n+static void window_object_load_error_scrollpaint(rct_window *w, rct_drawpixelinfo *dpi, sint32 scrollIndex);\n+\n+static rct_window_event_list window_object_load_error_events = {\n+ window_object_load_error_close,\n+ window_object_load_error_mouseup,\n+ NULL,\n+ NULL,\n+ NULL,\n+ NULL,\n+ window_object_load_error_update,\n+ NULL,\n+ NULL,\n+ NULL,\n+ NULL,\n+ NULL,\n+ NULL,\n+ NULL,\n+ NULL,\n+ window_object_load_error_scrollgetsize,\n+ window_object_load_error_scrollmousedown,\n+ NULL,\n+ window_object_load_error_scrollmouseover,\n+ NULL,\n+ NULL,\n+ NULL,\n+ NULL,\n+ NULL,\n+ NULL,\n+ NULL,\n+ window_object_load_error_paint,\n+ window_object_load_error_scrollpaint\n+};\n+\n+rct_object_entry * * invalid_entries = NULL;\n+sint32 highlighted_index = -1;\n+utf8* file_path = NULL;\n+\n+/**\n+* Returns an rct_string_id that represents an rct_object_entry's type.\n+*\n+* Could possibly be moved out of the window file if other\n+* uses exist and a suitable location is found.\n+*/\n+static rct_string_id get_object_type_string(const rct_object_entry *entry)\n+{\n+ rct_string_id result;\n+ uint8 objectType = entry->flags & 0x0F;\n+ switch (objectType) {\n+ case OBJECT_TYPE_RIDE:\n+ result = STR_OBJECT_SELECTION_RIDE_VEHICLES_ATTRACTIONS;\n+ break;\n+ case OBJECT_TYPE_SMALL_SCENERY:\n+ result = STR_OBJECT_SELECTION_SMALL_SCENERY;\n+ break;\n+ case OBJECT_TYPE_LARGE_SCENERY:\n+ result = STR_OBJECT_SELECTION_LARGE_SCENERY;\n+ break;\n+ case OBJECT_TYPE_WALLS:\n+ result = STR_OBJECT_SELECTION_WALLS_FENCES;\n+ break;\n+ case OBJECT_TYPE_BANNERS:\n+ result = STR_OBJECT_SELECTION_PATH_SIGNS;\n+ break;\n+ case OBJECT_TYPE_PATHS:\n+ result = STR_OBJECT_SELECTION_FOOTPATHS;\n+ break;\n+ case OBJECT_TYPE_PATH_BITS:\n+ result = STR_OBJECT_SELECTION_PATH_EXTRAS;\n+ break;\n+ case OBJECT_TYPE_SCENERY_SETS:\n+ result = STR_OBJECT_SELECTION_SCENERY_GROUPS;\n+ break;\n+ case OBJECT_TYPE_PARK_ENTRANCE:\n+ result = STR_OBJECT_SELECTION_PARK_ENTRANCE;\n+ break;\n+ case OBJECT_TYPE_WATER:\n+ result = STR_OBJECT_SELECTION_WATER;\n+ break;\n+ case OBJECT_TYPE_SCENARIO_TEXT:\n+ result = STR_OBJECT_SELECTION_SCENARIO_DESCRIPTION;\n+ break;\n+ default:\n+ result = STR_UNKNOWN_OBJECT_TYPE;\n+ }\n+ return result;\n+}\n+\n+/**\n+* Returns a newline-separated string listing all object names.\n+* Used for placing all names on the clipboard.\n+*/\n+static utf8* combine_object_names(rct_window *w)\n+{\n+ if (w->no_list_items > OBJECT_ENTRY_COUNT || w->no_list_items == 0) {\n+ // Something's gone wrong, this shouldn't happen\n+ // We don't want to allocate stupidly large amounts of memory\n+ // for no reason, so bail\n+ return NULL;\n+ }\n+ utf8* buffer;\n+ utf8* line_sep = platform_get_line_separator();","path":"src/openrct2/windows/object_load_error.c","position":161,"original_position":161,"commit_id":"feb207a5313efc4e4b0030d8d2b3cd01aef84232","original_commit_id":"feb207a5313efc4e4b0030d8d2b3cd01aef84232","user":{"login":"rwjuk","id":16639257,"avatar_url":"https://avatars0.githubusercontent.com/u/16639257?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjuk","html_url":"https://github.com/rwjuk","followers_url":"https://api.github.com/users/rwjuk/followers","following_url":"https://api.github.com/users/rwjuk/following{/other_user}","gists_url":"https://api.github.com/users/rwjuk/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjuk/subscriptions","organizations_url":"https://api.github.com/users/rwjuk/orgs","repos_url":"https://api.github.com/users/rwjuk/repos","events_url":"https://api.github.com/users/rwjuk/events{/privacy}","received_events_url":"https://api.github.com/users/rwjuk/received_events","type":"User","site_admin":false},"body":"Ahhh, it's `PLATFORM_NEWLINE`, for some reason I only searched for variations on 'separator.","created_at":"2017-06-29T08:21:28Z","updated_at":"2017-06-29T08:21:28Z","html_url":"https://github.com/OpenRCT2/OpenRCT2/pull/5624#discussion_r124738579","pull_request_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/5624","_links":{"self":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments/124738579"},"html":{"href":"https://github.com/OpenRCT2/OpenRCT2/pull/5624#discussion_r124738579"},"pull_request":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/5624"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/5624","id":125843420,"html_url":"https://github.com/OpenRCT2/OpenRCT2/pull/5624","diff_url":"https://github.com/OpenRCT2/OpenRCT2/pull/5624.diff","patch_url":"https://github.com/OpenRCT2/OpenRCT2/pull/5624.patch","issue_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/5624","number":5624,"state":"open","locked":false,"title":"Implement window displaying object load failures","user":{"login":"rwjuk","id":16639257,"avatar_url":"https://avatars0.githubusercontent.com/u/16639257?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjuk","html_url":"https://github.com/rwjuk","followers_url":"https://api.github.com/users/rwjuk/followers","following_url":"https://api.github.com/users/rwjuk/following{/other_user}","gists_url":"https://api.github.com/users/rwjuk/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjuk/subscriptions","organizations_url":"https://api.github.com/users/rwjuk/orgs","repos_url":"https://api.github.com/users/rwjuk/repos","events_url":"https://api.github.com/users/rwjuk/events{/privacy}","received_events_url":"https://api.github.com/users/rwjuk/received_events","type":"User","site_admin":false},"body":"In its current state, this partially resolves #1399, I have some more work to do (see below) that will cover more of the ideas there. This also resolves #5177.\r\n\r\nHere's an SV6 with invalid objects for testing purposes: https://github.com/OpenRCT2/OpenRCT2/files/741918/autosave_2017-01-31_23-17-53.zip\r\n\r\nTODO:\r\n* [x] Implement 'copy current item to clipboard'\r\n* [x] Implement 'copy whole list to clipboard'.","created_at":"2017-06-15T15:04:30Z","updated_at":"2017-06-29T08:21:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61dcecb0512badda94badfde656409cfb96d7e1a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/milestones/7","html_url":"https://github.com/OpenRCT2/OpenRCT2/milestone/7","labels_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/milestones/7/labels","id":2468925,"number":7,"title":"v0.1.0","description":"","creator":{"login":"Gymnasiast","id":1478678,"avatar_url":"https://avatars1.githubusercontent.com/u/1478678?v=3","gravatar_id":"","url":"https://api.github.com/users/Gymnasiast","html_url":"https://github.com/Gymnasiast","followers_url":"https://api.github.com/users/Gymnasiast/followers","following_url":"https://api.github.com/users/Gymnasiast/following{/other_user}","gists_url":"https://api.github.com/users/Gymnasiast/gists{/gist_id}","starred_url":"https://api.github.com/users/Gymnasiast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gymnasiast/subscriptions","organizations_url":"https://api.github.com/users/Gymnasiast/orgs","repos_url":"https://api.github.com/users/Gymnasiast/repos","events_url":"https://api.github.com/users/Gymnasiast/events{/privacy}","received_events_url":"https://api.github.com/users/Gymnasiast/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":5,"state":"open","created_at":"2017-04-20T08:06:29Z","updated_at":"2017-06-28T20:57:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/5624/commits","review_comments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/5624/comments","review_comment_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/5624/comments","statuses_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/statuses/feb207a5313efc4e4b0030d8d2b3cd01aef84232","head":{"label":"rwjuk:objectwindow","ref":"objectwindow","sha":"feb207a5313efc4e4b0030d8d2b3cd01aef84232","user":{"login":"rwjuk","id":16639257,"avatar_url":"https://avatars0.githubusercontent.com/u/16639257?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjuk","html_url":"https://github.com/rwjuk","followers_url":"https://api.github.com/users/rwjuk/followers","following_url":"https://api.github.com/users/rwjuk/following{/other_user}","gists_url":"https://api.github.com/users/rwjuk/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjuk/subscriptions","organizations_url":"https://api.github.com/users/rwjuk/orgs","repos_url":"https://api.github.com/users/rwjuk/repos","events_url":"https://api.github.com/users/rwjuk/events{/privacy}","received_events_url":"https://api.github.com/users/rwjuk/received_events","type":"User","site_admin":false},"repo":{"id":86361058,"name":"OpenRCT2","full_name":"rwjuk/OpenRCT2","owner":{"login":"rwjuk","id":16639257,"avatar_url":"https://avatars0.githubusercontent.com/u/16639257?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjuk","html_url":"https://github.com/rwjuk","followers_url":"https://api.github.com/users/rwjuk/followers","following_url":"https://api.github.com/users/rwjuk/following{/other_user}","gists_url":"https://api.github.com/users/rwjuk/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjuk/subscriptions","organizations_url":"https://api.github.com/users/rwjuk/orgs","repos_url":"https://api.github.com/users/rwjuk/repos","events_url":"https://api.github.com/users/rwjuk/events{/privacy}","received_events_url":"https://api.github.com/users/rwjuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwjuk/OpenRCT2","description":"An open source re-implementation of RollerCoaster Tycoon 2 🎢","fork":true,"url":"https://api.github.com/repos/rwjuk/OpenRCT2","forks_url":"https://api.github.com/repos/rwjuk/OpenRCT2/forks","keys_url":"https://api.github.com/repos/rwjuk/OpenRCT2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwjuk/OpenRCT2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwjuk/OpenRCT2/teams","hooks_url":"https://api.github.com/repos/rwjuk/OpenRCT2/hooks","issue_events_url":"https://api.github.com/repos/rwjuk/OpenRCT2/issues/events{/number}","events_url":"https://api.github.com/repos/rwjuk/OpenRCT2/events","assignees_url":"https://api.github.com/repos/rwjuk/OpenRCT2/assignees{/user}","branches_url":"https://api.github.com/repos/rwjuk/OpenRCT2/branches{/branch}","tags_url":"https://api.github.com/repos/rwjuk/OpenRCT2/tags","blobs_url":"https://api.github.com/repos/rwjuk/OpenRCT2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwjuk/OpenRCT2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwjuk/OpenRCT2/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwjuk/OpenRCT2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwjuk/OpenRCT2/statuses/{sha}","languages_url":"https://api.github.com/repos/rwjuk/OpenRCT2/languages","stargazers_url":"https://api.github.com/repos/rwjuk/OpenRCT2/stargazers","contributors_url":"https://api.github.com/repos/rwjuk/OpenRCT2/contributors","subscribers_url":"https://api.github.com/repos/rwjuk/OpenRCT2/subscribers","subscription_url":"https://api.github.com/repos/rwjuk/OpenRCT2/subscription","commits_url":"https://api.github.com/repos/rwjuk/OpenRCT2/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwjuk/OpenRCT2/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwjuk/OpenRCT2/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwjuk/OpenRCT2/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwjuk/OpenRCT2/contents/{+path}","compare_url":"https://api.github.com/repos/rwjuk/OpenRCT2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwjuk/OpenRCT2/merges","archive_url":"https://api.github.com/repos/rwjuk/OpenRCT2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwjuk/OpenRCT2/downloads","issues_url":"https://api.github.com/repos/rwjuk/OpenRCT2/issues{/number}","pulls_url":"https://api.github.com/repos/rwjuk/OpenRCT2/pulls{/number}","milestones_url":"https://api.github.com/repos/rwjuk/OpenRCT2/milestones{/number}","notifications_url":"https://api.github.com/repos/rwjuk/OpenRCT2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwjuk/OpenRCT2/labels{/name}","releases_url":"https://api.github.com/repos/rwjuk/OpenRCT2/releases{/id}","deployments_url":"https://api.github.com/repos/rwjuk/OpenRCT2/deployments","created_at":"2017-03-27T16:53:04Z","updated_at":"2017-04-18T00:28:44Z","pushed_at":"2017-06-29T00:47:01Z","git_url":"git://github.com/rwjuk/OpenRCT2.git","ssh_url":"[email protected]:rwjuk/OpenRCT2.git","clone_url":"https://github.com/rwjuk/OpenRCT2.git","svn_url":"https://github.com/rwjuk/OpenRCT2","homepage":"http://openrct2.website","size":53926,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"OpenRCT2:develop","ref":"develop","sha":"41cdf32f7ebd77a52f39c5b5742b5412474b7100","user":{"login":"OpenRCT2","id":8473908,"avatar_url":"https://avatars3.githubusercontent.com/u/8473908?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRCT2","html_url":"https://github.com/OpenRCT2","followers_url":"https://api.github.com/users/OpenRCT2/followers","following_url":"https://api.github.com/users/OpenRCT2/following{/other_user}","gists_url":"https://api.github.com/users/OpenRCT2/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRCT2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRCT2/subscriptions","organizations_url":"https://api.github.com/users/OpenRCT2/orgs","repos_url":"https://api.github.com/users/OpenRCT2/repos","events_url":"https://api.github.com/users/OpenRCT2/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRCT2/received_events","type":"Organization","site_admin":false},"repo":{"id":18348651,"name":"OpenRCT2","full_name":"OpenRCT2/OpenRCT2","owner":{"login":"OpenRCT2","id":8473908,"avatar_url":"https://avatars3.githubusercontent.com/u/8473908?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRCT2","html_url":"https://github.com/OpenRCT2","followers_url":"https://api.github.com/users/OpenRCT2/followers","following_url":"https://api.github.com/users/OpenRCT2/following{/other_user}","gists_url":"https://api.github.com/users/OpenRCT2/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRCT2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRCT2/subscriptions","organizations_url":"https://api.github.com/users/OpenRCT2/orgs","repos_url":"https://api.github.com/users/OpenRCT2/repos","events_url":"https://api.github.com/users/OpenRCT2/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRCT2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRCT2/OpenRCT2","description":"An open source re-implementation of RollerCoaster Tycoon 2 🎢","fork":false,"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2","forks_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/forks","keys_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/teams","hooks_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/hooks","issue_events_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/events","assignees_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/tags","blobs_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/languages","stargazers_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/stargazers","contributors_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/contributors","subscribers_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/subscribers","subscription_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/subscription","commits_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/merges","archive_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/downloads","issues_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/labels{/name}","releases_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/releases{/id}","deployments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/deployments","created_at":"2014-04-01T23:32:25Z","updated_at":"2017-06-28T12:59:28Z","pushed_at":"2017-06-29T08:17:32Z","git_url":"git://github.com/OpenRCT2/OpenRCT2.git","ssh_url":"[email protected]:OpenRCT2/OpenRCT2.git","clone_url":"https://github.com/OpenRCT2/OpenRCT2.git","svn_url":"https://github.com/OpenRCT2/OpenRCT2","homepage":"http://openrct2.website","size":53826,"stargazers_count":2806,"watchers_count":2806,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":458,"mirror_url":null,"open_issues_count":637,"forks":458,"open_issues":637,"watchers":2806,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/5624"},"html":{"href":"https://github.com/OpenRCT2/OpenRCT2/pull/5624"},"issue":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/5624"},"comments":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/5624/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/5624/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/5624/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/statuses/feb207a5313efc4e4b0030d8d2b3cd01aef84232"}}}} | {
"id": 18348651,
"name": "OpenRCT2/OpenRCT2",
"url": "https://api.github.com/repos/OpenRCT2/OpenRCT2"
} | {
"id": 16639257,
"login": "rwjuk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16639257?",
"url": "https://api.github.com/users/rwjuk"
} | {
"id": 8473908,
"login": "OpenRCT2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8473908?",
"url": "https://api.github.com/orgs/OpenRCT2"
} | 2017-06-29T08:21:28 | 6161296280 | {"actor":{"display_login":"rwjuk"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/comments/120924260","pull_request_review_id":42930747,"id":120924260,"diff_hunk":"@@ -0,0 +1,116 @@\n+<Group id=\"auditing\">\n+\t<title>Auditing</title>\n+\t<description>Auditing rules</description>\n+\n+\n+\t<Rule id=\"jboss_roll_over_transfer_logs\" severity=\"medium\">\n+\t\t<title>JBoss servers must be configured to roll over and transfer logs on a minimum weekly basis.</title>\n+\t\t<description>Information stored in one location is vulnerable to accidental or incidental deletion or\n+\t\t\talteration. Protecting log data is important during a forensic investigation to ensure \n+\t\t\tinvestigators can track and understand what may have occurred. Off-loading should be set up \n+\t\t\tas a scheduled task but can be configured to be run manually, if other processes during \n+\t\t\tthe off-loading are manual. Off-loading is a common process in information systems with \n+\t\t\tlimited log storage capacity.</description>\n+\t\t<rationale>Logs preservation and size limits can be implicitly incurred via periodic log rolling</rationale>\n+\t\t<ident cce=\"\"/>\n+\t\t<ref ossrg=\"SRG-APP-000515-AS-000203\" stigid=\"000735\" />","path":"JBoss/EAP/6/input/xccdf/application/tmp.xml","position":16,"original_position":16,"commit_id":"85de4e630e013e0adabef3f919b18217ad59bc20","original_commit_id":"a6cb479731fca27d282119b512dd7fb74794265f","user":{"login":"redhatrises","id":8398836,"avatar_url":"https://avatars1.githubusercontent.com/u/8398836?v=3","gravatar_id":"","url":"https://api.github.com/users/redhatrises","html_url":"https://github.com/redhatrises","followers_url":"https://api.github.com/users/redhatrises/followers","following_url":"https://api.github.com/users/redhatrises/following{/other_user}","gists_url":"https://api.github.com/users/redhatrises/gists{/gist_id}","starred_url":"https://api.github.com/users/redhatrises/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhatrises/subscriptions","organizations_url":"https://api.github.com/users/redhatrises/orgs","repos_url":"https://api.github.com/users/redhatrises/repos","events_url":"https://api.github.com/users/redhatrises/events{/privacy}","received_events_url":"https://api.github.com/users/redhatrises/received_events","type":"User","site_admin":false},"body":"Thanks @shawndwells ","created_at":"2017-06-08T15:41:48Z","updated_at":"2017-06-08T15:41:48Z","html_url":"https://github.com/OpenSCAP/scap-security-guide/pull/2054#discussion_r120924260","pull_request_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/2054","_links":{"self":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/comments/120924260"},"html":{"href":"https://github.com/OpenSCAP/scap-security-guide/pull/2054#discussion_r120924260"},"pull_request":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/2054"}}},"pull_request":{"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/2054","id":124519167,"html_url":"https://github.com/OpenSCAP/scap-security-guide/pull/2054","diff_url":"https://github.com/OpenSCAP/scap-security-guide/pull/2054.diff","patch_url":"https://github.com/OpenSCAP/scap-security-guide/pull/2054.patch","issue_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/2054","number":2054,"state":"open","locked":false,"title":"[wip] Create eap6","user":{"login":"neiloy","id":2693277,"avatar_url":"https://avatars3.githubusercontent.com/u/2693277?v=3","gravatar_id":"","url":"https://api.github.com/users/neiloy","html_url":"https://github.com/neiloy","followers_url":"https://api.github.com/users/neiloy/followers","following_url":"https://api.github.com/users/neiloy/following{/other_user}","gists_url":"https://api.github.com/users/neiloy/gists{/gist_id}","starred_url":"https://api.github.com/users/neiloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neiloy/subscriptions","organizations_url":"https://api.github.com/users/neiloy/orgs","repos_url":"https://api.github.com/users/neiloy/repos","events_url":"https://api.github.com/users/neiloy/events{/privacy}","received_events_url":"https://api.github.com/users/neiloy/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-07T21:11:58Z","updated_at":"2017-06-08T15:41:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c31e1de61fe2e87def35f4211640242a428310e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/2054/commits","review_comments_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/2054/comments","review_comment_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/2054/comments","statuses_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/statuses/85de4e630e013e0adabef3f919b18217ad59bc20","head":{"label":"neiloy:create_eap6","ref":"create_eap6","sha":"85de4e630e013e0adabef3f919b18217ad59bc20","user":{"login":"neiloy","id":2693277,"avatar_url":"https://avatars3.githubusercontent.com/u/2693277?v=3","gravatar_id":"","url":"https://api.github.com/users/neiloy","html_url":"https://github.com/neiloy","followers_url":"https://api.github.com/users/neiloy/followers","following_url":"https://api.github.com/users/neiloy/following{/other_user}","gists_url":"https://api.github.com/users/neiloy/gists{/gist_id}","starred_url":"https://api.github.com/users/neiloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neiloy/subscriptions","organizations_url":"https://api.github.com/users/neiloy/orgs","repos_url":"https://api.github.com/users/neiloy/repos","events_url":"https://api.github.com/users/neiloy/events{/privacy}","received_events_url":"https://api.github.com/users/neiloy/received_events","type":"User","site_admin":false},"repo":{"id":93673334,"name":"scap-security-guide","full_name":"neiloy/scap-security-guide","owner":{"login":"neiloy","id":2693277,"avatar_url":"https://avatars3.githubusercontent.com/u/2693277?v=3","gravatar_id":"","url":"https://api.github.com/users/neiloy","html_url":"https://github.com/neiloy","followers_url":"https://api.github.com/users/neiloy/followers","following_url":"https://api.github.com/users/neiloy/following{/other_user}","gists_url":"https://api.github.com/users/neiloy/gists{/gist_id}","starred_url":"https://api.github.com/users/neiloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neiloy/subscriptions","organizations_url":"https://api.github.com/users/neiloy/orgs","repos_url":"https://api.github.com/users/neiloy/repos","events_url":"https://api.github.com/users/neiloy/events{/privacy}","received_events_url":"https://api.github.com/users/neiloy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neiloy/scap-security-guide","description":"Baseline compliance content in SCAP formats","fork":true,"url":"https://api.github.com/repos/neiloy/scap-security-guide","forks_url":"https://api.github.com/repos/neiloy/scap-security-guide/forks","keys_url":"https://api.github.com/repos/neiloy/scap-security-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neiloy/scap-security-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neiloy/scap-security-guide/teams","hooks_url":"https://api.github.com/repos/neiloy/scap-security-guide/hooks","issue_events_url":"https://api.github.com/repos/neiloy/scap-security-guide/issues/events{/number}","events_url":"https://api.github.com/repos/neiloy/scap-security-guide/events","assignees_url":"https://api.github.com/repos/neiloy/scap-security-guide/assignees{/user}","branches_url":"https://api.github.com/repos/neiloy/scap-security-guide/branches{/branch}","tags_url":"https://api.github.com/repos/neiloy/scap-security-guide/tags","blobs_url":"https://api.github.com/repos/neiloy/scap-security-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neiloy/scap-security-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neiloy/scap-security-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/neiloy/scap-security-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neiloy/scap-security-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/neiloy/scap-security-guide/languages","stargazers_url":"https://api.github.com/repos/neiloy/scap-security-guide/stargazers","contributors_url":"https://api.github.com/repos/neiloy/scap-security-guide/contributors","subscribers_url":"https://api.github.com/repos/neiloy/scap-security-guide/subscribers","subscription_url":"https://api.github.com/repos/neiloy/scap-security-guide/subscription","commits_url":"https://api.github.com/repos/neiloy/scap-security-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/neiloy/scap-security-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/neiloy/scap-security-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/neiloy/scap-security-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/neiloy/scap-security-guide/contents/{+path}","compare_url":"https://api.github.com/repos/neiloy/scap-security-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neiloy/scap-security-guide/merges","archive_url":"https://api.github.com/repos/neiloy/scap-security-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neiloy/scap-security-guide/downloads","issues_url":"https://api.github.com/repos/neiloy/scap-security-guide/issues{/number}","pulls_url":"https://api.github.com/repos/neiloy/scap-security-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/neiloy/scap-security-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/neiloy/scap-security-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neiloy/scap-security-guide/labels{/name}","releases_url":"https://api.github.com/repos/neiloy/scap-security-guide/releases{/id}","deployments_url":"https://api.github.com/repos/neiloy/scap-security-guide/deployments","created_at":"2017-06-07T19:47:01Z","updated_at":"2017-06-07T19:47:08Z","pushed_at":"2017-06-08T15:38:55Z","git_url":"git://github.com/neiloy/scap-security-guide.git","ssh_url":"[email protected]:neiloy/scap-security-guide.git","clone_url":"https://github.com/neiloy/scap-security-guide.git","svn_url":"https://github.com/neiloy/scap-security-guide","homepage":"https://www.open-scap.org/security-policies/scap-security-guide","size":18154,"stargazers_count":0,"watchers_count":0,"language":"XSLT","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenSCAP:master","ref":"master","sha":"10e81fb0cdd01d4c7366314ca216744c5d271b01","user":{"login":"OpenSCAP","id":7439934,"avatar_url":"https://avatars2.githubusercontent.com/u/7439934?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenSCAP","html_url":"https://github.com/OpenSCAP","followers_url":"https://api.github.com/users/OpenSCAP/followers","following_url":"https://api.github.com/users/OpenSCAP/following{/other_user}","gists_url":"https://api.github.com/users/OpenSCAP/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSCAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSCAP/subscriptions","organizations_url":"https://api.github.com/users/OpenSCAP/orgs","repos_url":"https://api.github.com/users/OpenSCAP/repos","events_url":"https://api.github.com/users/OpenSCAP/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSCAP/received_events","type":"Organization","site_admin":false},"repo":{"id":19279458,"name":"scap-security-guide","full_name":"OpenSCAP/scap-security-guide","owner":{"login":"OpenSCAP","id":7439934,"avatar_url":"https://avatars2.githubusercontent.com/u/7439934?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenSCAP","html_url":"https://github.com/OpenSCAP","followers_url":"https://api.github.com/users/OpenSCAP/followers","following_url":"https://api.github.com/users/OpenSCAP/following{/other_user}","gists_url":"https://api.github.com/users/OpenSCAP/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSCAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSCAP/subscriptions","organizations_url":"https://api.github.com/users/OpenSCAP/orgs","repos_url":"https://api.github.com/users/OpenSCAP/repos","events_url":"https://api.github.com/users/OpenSCAP/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSCAP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenSCAP/scap-security-guide","description":"Baseline compliance content in SCAP formats","fork":false,"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide","forks_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/forks","keys_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/teams","hooks_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/hooks","issue_events_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/events{/number}","events_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/events","assignees_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/assignees{/user}","branches_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/branches{/branch}","tags_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/tags","blobs_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/languages","stargazers_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/stargazers","contributors_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/contributors","subscribers_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/subscribers","subscription_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/subscription","commits_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/contents/{+path}","compare_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/merges","archive_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/downloads","issues_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues{/number}","pulls_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/labels{/name}","releases_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/releases{/id}","deployments_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/deployments","created_at":"2014-04-29T14:32:02Z","updated_at":"2017-06-07T14:45:09Z","pushed_at":"2017-06-08T15:38:56Z","git_url":"git://github.com/OpenSCAP/scap-security-guide.git","ssh_url":"[email protected]:OpenSCAP/scap-security-guide.git","clone_url":"https://github.com/OpenSCAP/scap-security-guide.git","svn_url":"https://github.com/OpenSCAP/scap-security-guide","homepage":"https://www.open-scap.org/security-policies/scap-security-guide","size":18149,"stargazers_count":270,"watchers_count":270,"language":"XSLT","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":155,"forks":141,"open_issues":155,"watchers":270,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/2054"},"html":{"href":"https://github.com/OpenSCAP/scap-security-guide/pull/2054"},"issue":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/2054"},"comments":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/2054/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/2054/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/2054/commits"},"statuses":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/statuses/85de4e630e013e0adabef3f919b18217ad59bc20"}}}} | {
"id": 19279458,
"name": "OpenSCAP/scap-security-guide",
"url": "https://api.github.com/repos/OpenSCAP/scap-security-guide"
} | {
"id": 8398836,
"login": "redhatrises",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8398836?",
"url": "https://api.github.com/users/redhatrises"
} | {
"id": 7439934,
"login": "OpenSCAP",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7439934?",
"url": "https://api.github.com/orgs/OpenSCAP"
} | 2017-06-08T15:41:48 | 6028416239 | {"actor":{"display_login":"redhatrises"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Scribery/cockpit/pulls/comments/139123824","pull_request_review_id":63013859,"id":139123824,"diff_hunk":"@@ -450,6 +450,47 @@\n let RecordingList = class extends React.Component {\n constructor(props) {\n super(props);\n+ this.handleColumnClick = this.handleColumnClick.bind(this);\n+ this.getSortedList = this.getSortedList.bind(this);\n+ this.drawSortDir = this.drawSortDir.bind(this);\n+ this.state = {\n+ sorting_field: \"start\",\n+ sorting_asc: false,","path":"pkg/session_recording/recordings.jsx","position":9,"original_position":9,"commit_id":"a88b9873fde6cd477de81049108bbc7514906c6a","original_commit_id":"a88b9873fde6cd477de81049108bbc7514906c6a","user":{"login":"spbnick","id":549246,"avatar_url":"https://avatars3.githubusercontent.com/u/549246?v=4","gravatar_id":"","url":"https://api.github.com/users/spbnick","html_url":"https://github.com/spbnick","followers_url":"https://api.github.com/users/spbnick/followers","following_url":"https://api.github.com/users/spbnick/following{/other_user}","gists_url":"https://api.github.com/users/spbnick/gists{/gist_id}","starred_url":"https://api.github.com/users/spbnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spbnick/subscriptions","organizations_url":"https://api.github.com/users/spbnick/orgs","repos_url":"https://api.github.com/users/spbnick/repos","events_url":"https://api.github.com/users/spbnick/events{/privacy}","received_events_url":"https://api.github.com/users/spbnick/received_events","type":"User","site_admin":false},"body":"This is opposite to the order `this.props.list` is in, did you intend it to be so?","created_at":"2017-09-15T11:16:48Z","updated_at":"2017-09-15T11:21:20Z","html_url":"https://github.com/Scribery/cockpit/pull/31#discussion_r139123824","pull_request_url":"https://api.github.com/repos/Scribery/cockpit/pulls/31","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Scribery/cockpit/pulls/comments/139123824"},"html":{"href":"https://github.com/Scribery/cockpit/pull/31#discussion_r139123824"},"pull_request":{"href":"https://api.github.com/repos/Scribery/cockpit/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/Scribery/cockpit/pulls/31","id":139349164,"html_url":"https://github.com/Scribery/cockpit/pull/31","diff_url":"https://github.com/Scribery/cockpit/pull/31.diff","patch_url":"https://github.com/Scribery/cockpit/pull/31.patch","issue_url":"https://api.github.com/repos/Scribery/cockpit/issues/31","number":31,"state":"open","locked":false,"title":"Add sorting","user":{"login":"sabbaka","id":5558501,"avatar_url":"https://avatars0.githubusercontent.com/u/5558501?v=4","gravatar_id":"","url":"https://api.github.com/users/sabbaka","html_url":"https://github.com/sabbaka","followers_url":"https://api.github.com/users/sabbaka/followers","following_url":"https://api.github.com/users/sabbaka/following{/other_user}","gists_url":"https://api.github.com/users/sabbaka/gists{/gist_id}","starred_url":"https://api.github.com/users/sabbaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabbaka/subscriptions","organizations_url":"https://api.github.com/users/sabbaka/orgs","repos_url":"https://api.github.com/users/sabbaka/repos","events_url":"https://api.github.com/users/sabbaka/events{/privacy}","received_events_url":"https://api.github.com/users/sabbaka/received_events","type":"User","site_admin":false},"body":"#26 \r\nIt's just a first version, will work more on looks.\r\n\r\nHere is short demo: https://youtu.be/irg2FrWfOLY","created_at":"2017-09-05T15:11:22Z","updated_at":"2017-09-15T11:21:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d58ccff6b85b54ac9ceab08ef4fed1111067776","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Scribery/cockpit/pulls/31/commits","review_comments_url":"https://api.github.com/repos/Scribery/cockpit/pulls/31/comments","review_comment_url":"https://api.github.com/repos/Scribery/cockpit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Scribery/cockpit/issues/31/comments","statuses_url":"https://api.github.com/repos/Scribery/cockpit/statuses/a88b9873fde6cd477de81049108bbc7514906c6a","head":{"label":"sabbaka:sorting","ref":"sorting","sha":"a88b9873fde6cd477de81049108bbc7514906c6a","user":{"login":"sabbaka","id":5558501,"avatar_url":"https://avatars0.githubusercontent.com/u/5558501?v=4","gravatar_id":"","url":"https://api.github.com/users/sabbaka","html_url":"https://github.com/sabbaka","followers_url":"https://api.github.com/users/sabbaka/followers","following_url":"https://api.github.com/users/sabbaka/following{/other_user}","gists_url":"https://api.github.com/users/sabbaka/gists{/gist_id}","starred_url":"https://api.github.com/users/sabbaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabbaka/subscriptions","organizations_url":"https://api.github.com/users/sabbaka/orgs","repos_url":"https://api.github.com/users/sabbaka/repos","events_url":"https://api.github.com/users/sabbaka/events{/privacy}","received_events_url":"https://api.github.com/users/sabbaka/received_events","type":"User","site_admin":false},"repo":{"id":97018539,"name":"cockpit","full_name":"sabbaka/cockpit","owner":{"login":"sabbaka","id":5558501,"avatar_url":"https://avatars0.githubusercontent.com/u/5558501?v=4","gravatar_id":"","url":"https://api.github.com/users/sabbaka","html_url":"https://github.com/sabbaka","followers_url":"https://api.github.com/users/sabbaka/followers","following_url":"https://api.github.com/users/sabbaka/following{/other_user}","gists_url":"https://api.github.com/users/sabbaka/gists{/gist_id}","starred_url":"https://api.github.com/users/sabbaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabbaka/subscriptions","organizations_url":"https://api.github.com/users/sabbaka/orgs","repos_url":"https://api.github.com/users/sabbaka/repos","events_url":"https://api.github.com/users/sabbaka/events{/privacy}","received_events_url":"https://api.github.com/users/sabbaka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sabbaka/cockpit","description":"Cockpit fork for work on Session Recording UI","fork":true,"url":"https://api.github.com/repos/sabbaka/cockpit","forks_url":"https://api.github.com/repos/sabbaka/cockpit/forks","keys_url":"https://api.github.com/repos/sabbaka/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sabbaka/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sabbaka/cockpit/teams","hooks_url":"https://api.github.com/repos/sabbaka/cockpit/hooks","issue_events_url":"https://api.github.com/repos/sabbaka/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/sabbaka/cockpit/events","assignees_url":"https://api.github.com/repos/sabbaka/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/sabbaka/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/sabbaka/cockpit/tags","blobs_url":"https://api.github.com/repos/sabbaka/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sabbaka/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sabbaka/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/sabbaka/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sabbaka/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/sabbaka/cockpit/languages","stargazers_url":"https://api.github.com/repos/sabbaka/cockpit/stargazers","contributors_url":"https://api.github.com/repos/sabbaka/cockpit/contributors","subscribers_url":"https://api.github.com/repos/sabbaka/cockpit/subscribers","subscription_url":"https://api.github.com/repos/sabbaka/cockpit/subscription","commits_url":"https://api.github.com/repos/sabbaka/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/sabbaka/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/sabbaka/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/sabbaka/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/sabbaka/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/sabbaka/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sabbaka/cockpit/merges","archive_url":"https://api.github.com/repos/sabbaka/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sabbaka/cockpit/downloads","issues_url":"https://api.github.com/repos/sabbaka/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/sabbaka/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/sabbaka/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/sabbaka/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sabbaka/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/sabbaka/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/sabbaka/cockpit/deployments","created_at":"2017-07-12T14:39:05Z","updated_at":"2017-07-12T14:39:11Z","pushed_at":"2017-09-15T10:55:23Z","git_url":"git://github.com/sabbaka/cockpit.git","ssh_url":"[email protected]:sabbaka/cockpit.git","clone_url":"https://github.com/sabbaka/cockpit.git","svn_url":"https://github.com/sabbaka/cockpit","homepage":"http://www.cockpit-project.org/","size":34473,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Scribery:scribery_poc","ref":"scribery_poc","sha":"42f304c3348d7b8c63cc46860d5a9f99e7def1e5","user":{"login":"Scribery","id":17722920,"avatar_url":"https://avatars2.githubusercontent.com/u/17722920?v=4","gravatar_id":"","url":"https://api.github.com/users/Scribery","html_url":"https://github.com/Scribery","followers_url":"https://api.github.com/users/Scribery/followers","following_url":"https://api.github.com/users/Scribery/following{/other_user}","gists_url":"https://api.github.com/users/Scribery/gists{/gist_id}","starred_url":"https://api.github.com/users/Scribery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scribery/subscriptions","organizations_url":"https://api.github.com/users/Scribery/orgs","repos_url":"https://api.github.com/users/Scribery/repos","events_url":"https://api.github.com/users/Scribery/events{/privacy}","received_events_url":"https://api.github.com/users/Scribery/received_events","type":"Organization","site_admin":false},"repo":{"id":96337975,"name":"cockpit","full_name":"Scribery/cockpit","owner":{"login":"Scribery","id":17722920,"avatar_url":"https://avatars2.githubusercontent.com/u/17722920?v=4","gravatar_id":"","url":"https://api.github.com/users/Scribery","html_url":"https://github.com/Scribery","followers_url":"https://api.github.com/users/Scribery/followers","following_url":"https://api.github.com/users/Scribery/following{/other_user}","gists_url":"https://api.github.com/users/Scribery/gists{/gist_id}","starred_url":"https://api.github.com/users/Scribery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scribery/subscriptions","organizations_url":"https://api.github.com/users/Scribery/orgs","repos_url":"https://api.github.com/users/Scribery/repos","events_url":"https://api.github.com/users/Scribery/events{/privacy}","received_events_url":"https://api.github.com/users/Scribery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Scribery/cockpit","description":"Cockpit fork for work on Session Recording UI","fork":true,"url":"https://api.github.com/repos/Scribery/cockpit","forks_url":"https://api.github.com/repos/Scribery/cockpit/forks","keys_url":"https://api.github.com/repos/Scribery/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Scribery/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Scribery/cockpit/teams","hooks_url":"https://api.github.com/repos/Scribery/cockpit/hooks","issue_events_url":"https://api.github.com/repos/Scribery/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/Scribery/cockpit/events","assignees_url":"https://api.github.com/repos/Scribery/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/Scribery/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/Scribery/cockpit/tags","blobs_url":"https://api.github.com/repos/Scribery/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Scribery/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Scribery/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Scribery/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Scribery/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/Scribery/cockpit/languages","stargazers_url":"https://api.github.com/repos/Scribery/cockpit/stargazers","contributors_url":"https://api.github.com/repos/Scribery/cockpit/contributors","subscribers_url":"https://api.github.com/repos/Scribery/cockpit/subscribers","subscription_url":"https://api.github.com/repos/Scribery/cockpit/subscription","commits_url":"https://api.github.com/repos/Scribery/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Scribery/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Scribery/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Scribery/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Scribery/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/Scribery/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Scribery/cockpit/merges","archive_url":"https://api.github.com/repos/Scribery/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Scribery/cockpit/downloads","issues_url":"https://api.github.com/repos/Scribery/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/Scribery/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/Scribery/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/Scribery/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Scribery/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/Scribery/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/Scribery/cockpit/deployments","created_at":"2017-07-05T16:08:47Z","updated_at":"2017-07-13T21:05:31Z","pushed_at":"2017-09-15T10:55:25Z","git_url":"git://github.com/Scribery/cockpit.git","ssh_url":"[email protected]:Scribery/cockpit.git","clone_url":"https://github.com/Scribery/cockpit.git","svn_url":"https://github.com/Scribery/cockpit","homepage":"http://www.cockpit-project.org/","size":34454,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":15,"forks":1,"open_issues":15,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Scribery/cockpit/pulls/31"},"html":{"href":"https://github.com/Scribery/cockpit/pull/31"},"issue":{"href":"https://api.github.com/repos/Scribery/cockpit/issues/31"},"comments":{"href":"https://api.github.com/repos/Scribery/cockpit/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/Scribery/cockpit/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/Scribery/cockpit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Scribery/cockpit/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/Scribery/cockpit/statuses/a88b9873fde6cd477de81049108bbc7514906c6a"}},"author_association":"NONE"}} | {
"id": 96337975,
"name": "Scribery/cockpit",
"url": "https://api.github.com/repos/Scribery/cockpit"
} | {
"id": 549246,
"login": "spbnick",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/549246?",
"url": "https://api.github.com/users/spbnick"
} | {
"id": 17722920,
"login": "Scribery",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17722920?",
"url": "https://api.github.com/orgs/Scribery"
} | 2017-09-15T11:16:48 | 6595215863 | {"actor":{"display_login":"spbnick"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Teamwork/utils/pulls/comments/146767913","pull_request_review_id":71756194,"id":146767913,"diff_hunk":"@@ -0,0 +1,54 @@\n+// Package cryptoutil provides a set of functions for 2-way encryption and hashing.\n+package cryptoutil // import \"github.com/teamwork/utils/cryptoutil\"","path":"cryptoutil/cryptoutil.go","position":2,"original_position":2,"commit_id":"c677e9aad9bfd2b6366dde835adfaabe759d5974","original_commit_id":"c677e9aad9bfd2b6366dde835adfaabe759d5974","user":{"login":"Carpetsmoker","id":1032692,"avatar_url":"https://avatars1.githubusercontent.com/u/1032692?v=4","gravatar_id":"","url":"https://api.github.com/users/Carpetsmoker","html_url":"https://github.com/Carpetsmoker","followers_url":"https://api.github.com/users/Carpetsmoker/followers","following_url":"https://api.github.com/users/Carpetsmoker/following{/other_user}","gists_url":"https://api.github.com/users/Carpetsmoker/gists{/gist_id}","starred_url":"https://api.github.com/users/Carpetsmoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carpetsmoker/subscriptions","organizations_url":"https://api.github.com/users/Carpetsmoker/orgs","repos_url":"https://api.github.com/users/Carpetsmoker/repos","events_url":"https://api.github.com/users/Carpetsmoker/events{/privacy}","received_events_url":"https://api.github.com/users/Carpetsmoker/received_events","type":"User","site_admin":false},"body":"Also – I just remembered this – in Desk we added an `Encrypt()` and `Decrypt()` based on nacl: https://github.com/Teamwork/desk/blob/master/modules/crypto/crypto.go#L22\r\n\r\nThis is, I think, a better approach than using AES directly. For example the Go docs say:\r\n\r\n\r\n\t// It's important to remember that ciphertexts must be authenticated\r\n\t// (i.e. by using crypto/hmac) as well as being encrypted in order to\r\n\t// be secure.\r\n\r\nAnd I think there may be some other caveats as well.\r\n\r\nnacl is designed to think about these things \"for you\", and should be more secure.","created_at":"2017-10-25T06:53:17Z","updated_at":"2017-10-25T06:53:17Z","html_url":"https://github.com/Teamwork/utils/pull/8#discussion_r146767913","pull_request_url":"https://api.github.com/repos/Teamwork/utils/pulls/8","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Teamwork/utils/pulls/comments/146767913"},"html":{"href":"https://github.com/Teamwork/utils/pull/8#discussion_r146767913"},"pull_request":{"href":"https://api.github.com/repos/Teamwork/utils/pulls/8"}},"in_reply_to_id":146641910},"pull_request":{"url":"https://api.github.com/repos/Teamwork/utils/pulls/8","id":148466732,"html_url":"https://github.com/Teamwork/utils/pull/8","diff_url":"https://github.com/Teamwork/utils/pull/8.diff","patch_url":"https://github.com/Teamwork/utils/pull/8.patch","issue_url":"https://api.github.com/repos/Teamwork/utils/issues/8","number":8,"state":"open","locked":false,"title":"Add cryptoutil","user":{"login":"ripexz","id":1633829,"avatar_url":"https://avatars3.githubusercontent.com/u/1633829?v=4","gravatar_id":"","url":"https://api.github.com/users/ripexz","html_url":"https://github.com/ripexz","followers_url":"https://api.github.com/users/ripexz/followers","following_url":"https://api.github.com/users/ripexz/following{/other_user}","gists_url":"https://api.github.com/users/ripexz/gists{/gist_id}","starred_url":"https://api.github.com/users/ripexz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripexz/subscriptions","organizations_url":"https://api.github.com/users/ripexz/orgs","repos_url":"https://api.github.com/users/ripexz/repos","events_url":"https://api.github.com/users/ripexz/events{/privacy}","received_events_url":"https://api.github.com/users/ripexz/received_events","type":"User","site_admin":false},"body":"Allows for easy AES encryption and decryption of data to base64 strings.\r\n\r\nCurrent prime use case - in launchpad we want to support legacy form submission but we cannot prefill the login fields with plaintext passwords due to security issues, so we encrypt the password (string in this case).\r\n\r\nSimilarly this will be needed by launchpad in the future for temporary token generation in app login flow (struct serialized to json string).\r\n\r\n### Usage example\r\n**Encrypt**\r\n```\r\nres, err := cryptoutil.Encrypt(viper.GetString(\"ENCRYPT_AESKEY\"), []byte(\"SUPER SECRET MESSAGE\"))\r\nlog.Printf(\"Result: %s\", res)\r\n}\r\n```\r\n\r\n**Decrypt**\r\n```\r\nres, err := cryptoutil.Decrypt(viper.GetString(\"ENCRYPT_AESKEY\"), \"nIN0_Qc0qZOogG3CPnHdT64te8JWVs2Fv3fp\")\r\nlog.Printf(\"Secret: %s\", res)\r\n```","created_at":"2017-10-24T17:44:08Z","updated_at":"2017-10-25T06:53:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8789fff8de3b668cf9b51b82a873d49c43b35cd5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Teamwork/utils/pulls/8/commits","review_comments_url":"https://api.github.com/repos/Teamwork/utils/pulls/8/comments","review_comment_url":"https://api.github.com/repos/Teamwork/utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Teamwork/utils/issues/8/comments","statuses_url":"https://api.github.com/repos/Teamwork/utils/statuses/c677e9aad9bfd2b6366dde835adfaabe759d5974","head":{"label":"Teamwork:cryptoutil","ref":"cryptoutil","sha":"c677e9aad9bfd2b6366dde835adfaabe759d5974","user":{"login":"Teamwork","id":4037476,"avatar_url":"https://avatars2.githubusercontent.com/u/4037476?v=4","gravatar_id":"","url":"https://api.github.com/users/Teamwork","html_url":"https://github.com/Teamwork","followers_url":"https://api.github.com/users/Teamwork/followers","following_url":"https://api.github.com/users/Teamwork/following{/other_user}","gists_url":"https://api.github.com/users/Teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/Teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teamwork/subscriptions","organizations_url":"https://api.github.com/users/Teamwork/orgs","repos_url":"https://api.github.com/users/Teamwork/repos","events_url":"https://api.github.com/users/Teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/Teamwork/received_events","type":"Organization","site_admin":false},"repo":{"id":57156654,"name":"utils","full_name":"Teamwork/utils","owner":{"login":"Teamwork","id":4037476,"avatar_url":"https://avatars2.githubusercontent.com/u/4037476?v=4","gravatar_id":"","url":"https://api.github.com/users/Teamwork","html_url":"https://github.com/Teamwork","followers_url":"https://api.github.com/users/Teamwork/followers","following_url":"https://api.github.com/users/Teamwork/following{/other_user}","gists_url":"https://api.github.com/users/Teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/Teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teamwork/subscriptions","organizations_url":"https://api.github.com/users/Teamwork/orgs","repos_url":"https://api.github.com/users/Teamwork/repos","events_url":"https://api.github.com/users/Teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/Teamwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Teamwork/utils","description":"A collection of small and often used extensions to Go's standard library","fork":false,"url":"https://api.github.com/repos/Teamwork/utils","forks_url":"https://api.github.com/repos/Teamwork/utils/forks","keys_url":"https://api.github.com/repos/Teamwork/utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Teamwork/utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Teamwork/utils/teams","hooks_url":"https://api.github.com/repos/Teamwork/utils/hooks","issue_events_url":"https://api.github.com/repos/Teamwork/utils/issues/events{/number}","events_url":"https://api.github.com/repos/Teamwork/utils/events","assignees_url":"https://api.github.com/repos/Teamwork/utils/assignees{/user}","branches_url":"https://api.github.com/repos/Teamwork/utils/branches{/branch}","tags_url":"https://api.github.com/repos/Teamwork/utils/tags","blobs_url":"https://api.github.com/repos/Teamwork/utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Teamwork/utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Teamwork/utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/Teamwork/utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Teamwork/utils/statuses/{sha}","languages_url":"https://api.github.com/repos/Teamwork/utils/languages","stargazers_url":"https://api.github.com/repos/Teamwork/utils/stargazers","contributors_url":"https://api.github.com/repos/Teamwork/utils/contributors","subscribers_url":"https://api.github.com/repos/Teamwork/utils/subscribers","subscription_url":"https://api.github.com/repos/Teamwork/utils/subscription","commits_url":"https://api.github.com/repos/Teamwork/utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/Teamwork/utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/Teamwork/utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/Teamwork/utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/Teamwork/utils/contents/{+path}","compare_url":"https://api.github.com/repos/Teamwork/utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Teamwork/utils/merges","archive_url":"https://api.github.com/repos/Teamwork/utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Teamwork/utils/downloads","issues_url":"https://api.github.com/repos/Teamwork/utils/issues{/number}","pulls_url":"https://api.github.com/repos/Teamwork/utils/pulls{/number}","milestones_url":"https://api.github.com/repos/Teamwork/utils/milestones{/number}","notifications_url":"https://api.github.com/repos/Teamwork/utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Teamwork/utils/labels{/name}","releases_url":"https://api.github.com/repos/Teamwork/utils/releases{/id}","deployments_url":"https://api.github.com/repos/Teamwork/utils/deployments","created_at":"2016-04-26T19:38:06Z","updated_at":"2017-09-15T19:21:18Z","pushed_at":"2017-10-24T17:44:08Z","git_url":"git://github.com/Teamwork/utils.git","ssh_url":"[email protected]:Teamwork/utils.git","clone_url":"https://github.com/Teamwork/utils.git","svn_url":"https://github.com/Teamwork/utils","homepage":"","size":75,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"Teamwork:master","ref":"master","sha":"f599ad6ee5755d986d956b6c61cef005be2a4c2e","user":{"login":"Teamwork","id":4037476,"avatar_url":"https://avatars2.githubusercontent.com/u/4037476?v=4","gravatar_id":"","url":"https://api.github.com/users/Teamwork","html_url":"https://github.com/Teamwork","followers_url":"https://api.github.com/users/Teamwork/followers","following_url":"https://api.github.com/users/Teamwork/following{/other_user}","gists_url":"https://api.github.com/users/Teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/Teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teamwork/subscriptions","organizations_url":"https://api.github.com/users/Teamwork/orgs","repos_url":"https://api.github.com/users/Teamwork/repos","events_url":"https://api.github.com/users/Teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/Teamwork/received_events","type":"Organization","site_admin":false},"repo":{"id":57156654,"name":"utils","full_name":"Teamwork/utils","owner":{"login":"Teamwork","id":4037476,"avatar_url":"https://avatars2.githubusercontent.com/u/4037476?v=4","gravatar_id":"","url":"https://api.github.com/users/Teamwork","html_url":"https://github.com/Teamwork","followers_url":"https://api.github.com/users/Teamwork/followers","following_url":"https://api.github.com/users/Teamwork/following{/other_user}","gists_url":"https://api.github.com/users/Teamwork/gists{/gist_id}","starred_url":"https://api.github.com/users/Teamwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teamwork/subscriptions","organizations_url":"https://api.github.com/users/Teamwork/orgs","repos_url":"https://api.github.com/users/Teamwork/repos","events_url":"https://api.github.com/users/Teamwork/events{/privacy}","received_events_url":"https://api.github.com/users/Teamwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Teamwork/utils","description":"A collection of small and often used extensions to Go's standard library","fork":false,"url":"https://api.github.com/repos/Teamwork/utils","forks_url":"https://api.github.com/repos/Teamwork/utils/forks","keys_url":"https://api.github.com/repos/Teamwork/utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Teamwork/utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Teamwork/utils/teams","hooks_url":"https://api.github.com/repos/Teamwork/utils/hooks","issue_events_url":"https://api.github.com/repos/Teamwork/utils/issues/events{/number}","events_url":"https://api.github.com/repos/Teamwork/utils/events","assignees_url":"https://api.github.com/repos/Teamwork/utils/assignees{/user}","branches_url":"https://api.github.com/repos/Teamwork/utils/branches{/branch}","tags_url":"https://api.github.com/repos/Teamwork/utils/tags","blobs_url":"https://api.github.com/repos/Teamwork/utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Teamwork/utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Teamwork/utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/Teamwork/utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Teamwork/utils/statuses/{sha}","languages_url":"https://api.github.com/repos/Teamwork/utils/languages","stargazers_url":"https://api.github.com/repos/Teamwork/utils/stargazers","contributors_url":"https://api.github.com/repos/Teamwork/utils/contributors","subscribers_url":"https://api.github.com/repos/Teamwork/utils/subscribers","subscription_url":"https://api.github.com/repos/Teamwork/utils/subscription","commits_url":"https://api.github.com/repos/Teamwork/utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/Teamwork/utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/Teamwork/utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/Teamwork/utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/Teamwork/utils/contents/{+path}","compare_url":"https://api.github.com/repos/Teamwork/utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Teamwork/utils/merges","archive_url":"https://api.github.com/repos/Teamwork/utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Teamwork/utils/downloads","issues_url":"https://api.github.com/repos/Teamwork/utils/issues{/number}","pulls_url":"https://api.github.com/repos/Teamwork/utils/pulls{/number}","milestones_url":"https://api.github.com/repos/Teamwork/utils/milestones{/number}","notifications_url":"https://api.github.com/repos/Teamwork/utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Teamwork/utils/labels{/name}","releases_url":"https://api.github.com/repos/Teamwork/utils/releases{/id}","deployments_url":"https://api.github.com/repos/Teamwork/utils/deployments","created_at":"2016-04-26T19:38:06Z","updated_at":"2017-09-15T19:21:18Z","pushed_at":"2017-10-24T17:44:08Z","git_url":"git://github.com/Teamwork/utils.git","ssh_url":"[email protected]:Teamwork/utils.git","clone_url":"https://github.com/Teamwork/utils.git","svn_url":"https://github.com/Teamwork/utils","homepage":"","size":75,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Teamwork/utils/pulls/8"},"html":{"href":"https://github.com/Teamwork/utils/pull/8"},"issue":{"href":"https://api.github.com/repos/Teamwork/utils/issues/8"},"comments":{"href":"https://api.github.com/repos/Teamwork/utils/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/Teamwork/utils/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/Teamwork/utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Teamwork/utils/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/Teamwork/utils/statuses/c677e9aad9bfd2b6366dde835adfaabe759d5974"}},"author_association":"MEMBER"}} | {
"id": 57156654,
"name": "Teamwork/utils",
"url": "https://api.github.com/repos/Teamwork/utils"
} | {
"id": 1032692,
"login": "Carpetsmoker",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1032692?",
"url": "https://api.github.com/users/Carpetsmoker"
} | {
"id": 4037476,
"login": "Teamwork",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4037476?",
"url": "https://api.github.com/orgs/Teamwork"
} | 2017-10-25T06:53:17 | 6762208159 | {"actor":{"display_login":"Carpetsmoker"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Teradata/presto/pulls/comments/131379004","pull_request_review_id":54355075,"id":131379004,"diff_hunk":"@@ -91,7 +91,22 @@ private static SymbolStatsEstimate subtractColumnStats(\n .build();\n }\n \n- public static PlanNodeStatsEstimate addStats(PlanNodeStatsEstimate left, PlanNodeStatsEstimate right)\n+ private interface AdditionRangeStrategy","path":"presto-main/src/main/java/com/facebook/presto/cost/PlanNodeStatsEstimateMath.java","position":5,"original_position":5,"commit_id":"c8d0fc9ca7daee1a0a0c5704af1902193782b081","original_commit_id":"c8d0fc9ca7daee1a0a0c5704af1902193782b081","user":{"login":"rschlussel","id":10963789,"avatar_url":"https://avatars2.githubusercontent.com/u/10963789?v=4","gravatar_id":"","url":"https://api.github.com/users/rschlussel","html_url":"https://github.com/rschlussel","followers_url":"https://api.github.com/users/rschlussel/followers","following_url":"https://api.github.com/users/rschlussel/following{/other_user}","gists_url":"https://api.github.com/users/rschlussel/gists{/gist_id}","starred_url":"https://api.github.com/users/rschlussel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rschlussel/subscriptions","organizations_url":"https://api.github.com/users/rschlussel/orgs","repos_url":"https://api.github.com/users/rschlussel/repos","events_url":"https://api.github.com/users/rschlussel/events{/privacy}","received_events_url":"https://api.github.com/users/rschlussel/received_events","type":"User","site_admin":false},"body":"Thanks! it was modeled on @fiedukow's approach for subtraction. ","created_at":"2017-08-04T12:40:05Z","updated_at":"2017-08-04T12:40:06Z","html_url":"https://github.com/Teradata/presto/pull/665#discussion_r131379004","pull_request_url":"https://api.github.com/repos/Teradata/presto/pulls/665","_links":{"self":{"href":"https://api.github.com/repos/Teradata/presto/pulls/comments/131379004"},"html":{"href":"https://github.com/Teradata/presto/pull/665#discussion_r131379004"},"pull_request":{"href":"https://api.github.com/repos/Teradata/presto/pulls/665"}}},"pull_request":{"url":"https://api.github.com/repos/Teradata/presto/pulls/665","id":134017926,"html_url":"https://github.com/Teradata/presto/pull/665","diff_url":"https://github.com/Teradata/presto/pull/665.diff","patch_url":"https://github.com/Teradata/presto/pull/665.patch","issue_url":"https://api.github.com/repos/Teradata/presto/issues/665","number":665,"state":"open","locked":false,"title":"Don't sum distinct values counts in UnionStatsRule","user":{"login":"rschlussel","id":10963789,"avatar_url":"https://avatars2.githubusercontent.com/u/10963789?v=4","gravatar_id":"","url":"https://api.github.com/users/rschlussel","html_url":"https://github.com/rschlussel","followers_url":"https://api.github.com/users/rschlussel/followers","following_url":"https://api.github.com/users/rschlussel/following{/other_user}","gists_url":"https://api.github.com/users/rschlussel/gists{/gist_id}","starred_url":"https://api.github.com/users/rschlussel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rschlussel/subscriptions","organizations_url":"https://api.github.com/users/rschlussel/orgs","repos_url":"https://api.github.com/users/rschlussel/repos","events_url":"https://api.github.com/users/rschlussel/events{/privacy}","received_events_url":"https://api.github.com/users/rschlussel/received_events","type":"User","site_admin":false},"body":"When we combined statistics for unionall queries we estimated the\r\ndistinct values count as the sum of the left and right distinct values\r\ncounts. We've found that a better heuristic is to take the max distinct\r\nvalues for the percent that they overlap, and then add the\r\ndistinct values for the non-overlapping percent.\r\n\r\nI decided not to change the behavior of other StatsRules using addStats() without data to indicate that a different approach would be better. But I can if people think that it would be more reasonable for those cases too.","created_at":"2017-08-03T19:01:44Z","updated_at":"2017-08-04T12:40:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3ad9aeee15a7d41b7f6c942c2684d0aa95c7f98","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Teradata/presto/pulls/665/commits","review_comments_url":"https://api.github.com/repos/Teradata/presto/pulls/665/comments","review_comment_url":"https://api.github.com/repos/Teradata/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Teradata/presto/issues/665/comments","statuses_url":"https://api.github.com/repos/Teradata/presto/statuses/c8d0fc9ca7daee1a0a0c5704af1902193782b081","head":{"label":"Teradata:fix-union-stats","ref":"fix-union-stats","sha":"c8d0fc9ca7daee1a0a0c5704af1902193782b081","user":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars1.githubusercontent.com/u/1615979?v=4","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"repo":{"id":36903368,"name":"presto","full_name":"Teradata/presto","owner":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars1.githubusercontent.com/u/1615979?v=4","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Teradata/presto","description":"Teradata Distribution of Presto -- A Distributed SQL Query Engine for Big Data","fork":true,"url":"https://api.github.com/repos/Teradata/presto","forks_url":"https://api.github.com/repos/Teradata/presto/forks","keys_url":"https://api.github.com/repos/Teradata/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Teradata/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Teradata/presto/teams","hooks_url":"https://api.github.com/repos/Teradata/presto/hooks","issue_events_url":"https://api.github.com/repos/Teradata/presto/issues/events{/number}","events_url":"https://api.github.com/repos/Teradata/presto/events","assignees_url":"https://api.github.com/repos/Teradata/presto/assignees{/user}","branches_url":"https://api.github.com/repos/Teradata/presto/branches{/branch}","tags_url":"https://api.github.com/repos/Teradata/presto/tags","blobs_url":"https://api.github.com/repos/Teradata/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Teradata/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Teradata/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Teradata/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Teradata/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/Teradata/presto/languages","stargazers_url":"https://api.github.com/repos/Teradata/presto/stargazers","contributors_url":"https://api.github.com/repos/Teradata/presto/contributors","subscribers_url":"https://api.github.com/repos/Teradata/presto/subscribers","subscription_url":"https://api.github.com/repos/Teradata/presto/subscription","commits_url":"https://api.github.com/repos/Teradata/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Teradata/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Teradata/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Teradata/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Teradata/presto/contents/{+path}","compare_url":"https://api.github.com/repos/Teradata/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Teradata/presto/merges","archive_url":"https://api.github.com/repos/Teradata/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Teradata/presto/downloads","issues_url":"https://api.github.com/repos/Teradata/presto/issues{/number}","pulls_url":"https://api.github.com/repos/Teradata/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/Teradata/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/Teradata/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Teradata/presto/labels{/name}","releases_url":"https://api.github.com/repos/Teradata/presto/releases{/id}","deployments_url":"https://api.github.com/repos/Teradata/presto/deployments","created_at":"2015-06-05T00:38:37Z","updated_at":"2017-06-27T21:21:21Z","pushed_at":"2017-08-04T12:39:51Z","git_url":"git://github.com/Teradata/presto.git","ssh_url":"[email protected]:Teradata/presto.git","clone_url":"https://github.com/Teradata/presto.git","svn_url":"https://github.com/Teradata/presto","homepage":"http://www.teradata.com/presto","size":196388,"stargazers_count":74,"watchers_count":74,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":32,"forks":19,"open_issues":32,"watchers":74,"default_branch":"master"}},"base":{"label":"Teradata:release-0.179-t","ref":"release-0.179-t","sha":"3e8e93788a35647393ee142bd6dc103129017de0","user":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars1.githubusercontent.com/u/1615979?v=4","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"repo":{"id":36903368,"name":"presto","full_name":"Teradata/presto","owner":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars1.githubusercontent.com/u/1615979?v=4","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Teradata/presto","description":"Teradata Distribution of Presto -- A Distributed SQL Query Engine for Big Data","fork":true,"url":"https://api.github.com/repos/Teradata/presto","forks_url":"https://api.github.com/repos/Teradata/presto/forks","keys_url":"https://api.github.com/repos/Teradata/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Teradata/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Teradata/presto/teams","hooks_url":"https://api.github.com/repos/Teradata/presto/hooks","issue_events_url":"https://api.github.com/repos/Teradata/presto/issues/events{/number}","events_url":"https://api.github.com/repos/Teradata/presto/events","assignees_url":"https://api.github.com/repos/Teradata/presto/assignees{/user}","branches_url":"https://api.github.com/repos/Teradata/presto/branches{/branch}","tags_url":"https://api.github.com/repos/Teradata/presto/tags","blobs_url":"https://api.github.com/repos/Teradata/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Teradata/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Teradata/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Teradata/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Teradata/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/Teradata/presto/languages","stargazers_url":"https://api.github.com/repos/Teradata/presto/stargazers","contributors_url":"https://api.github.com/repos/Teradata/presto/contributors","subscribers_url":"https://api.github.com/repos/Teradata/presto/subscribers","subscription_url":"https://api.github.com/repos/Teradata/presto/subscription","commits_url":"https://api.github.com/repos/Teradata/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Teradata/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Teradata/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Teradata/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Teradata/presto/contents/{+path}","compare_url":"https://api.github.com/repos/Teradata/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Teradata/presto/merges","archive_url":"https://api.github.com/repos/Teradata/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Teradata/presto/downloads","issues_url":"https://api.github.com/repos/Teradata/presto/issues{/number}","pulls_url":"https://api.github.com/repos/Teradata/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/Teradata/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/Teradata/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Teradata/presto/labels{/name}","releases_url":"https://api.github.com/repos/Teradata/presto/releases{/id}","deployments_url":"https://api.github.com/repos/Teradata/presto/deployments","created_at":"2015-06-05T00:38:37Z","updated_at":"2017-06-27T21:21:21Z","pushed_at":"2017-08-04T12:39:51Z","git_url":"git://github.com/Teradata/presto.git","ssh_url":"[email protected]:Teradata/presto.git","clone_url":"https://github.com/Teradata/presto.git","svn_url":"https://github.com/Teradata/presto","homepage":"http://www.teradata.com/presto","size":196388,"stargazers_count":74,"watchers_count":74,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":32,"forks":19,"open_issues":32,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Teradata/presto/pulls/665"},"html":{"href":"https://github.com/Teradata/presto/pull/665"},"issue":{"href":"https://api.github.com/repos/Teradata/presto/issues/665"},"comments":{"href":"https://api.github.com/repos/Teradata/presto/issues/665/comments"},"review_comments":{"href":"https://api.github.com/repos/Teradata/presto/pulls/665/comments"},"review_comment":{"href":"https://api.github.com/repos/Teradata/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Teradata/presto/pulls/665/commits"},"statuses":{"href":"https://api.github.com/repos/Teradata/presto/statuses/c8d0fc9ca7daee1a0a0c5704af1902193782b081"}}}} | {
"id": 36903368,
"name": "Teradata/presto",
"url": "https://api.github.com/repos/Teradata/presto"
} | {
"id": 10963789,
"login": "rschlussel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10963789?",
"url": "https://api.github.com/users/rschlussel"
} | {
"id": 1615979,
"login": "Teradata",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1615979?",
"url": "https://api.github.com/orgs/Teradata"
} | 2017-08-04T12:40:05 | 6395214331 | {"actor":{"display_login":"rschlussel"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/govuk_elements/pulls/comments/142640378","pull_request_review_id":67027589,"id":142640378,"diff_hunk":"@@ -1,6 +1,6 @@\n <div class=\"notice\">\n <i class=\"icon icon-important\">\n- <span class=\"visually-hidden\">Warning</span>\n+ <span class=\"visually-hidden\">Important</span>","path":"app/views/snippets/typography_warning_text.html","position":4,"original_position":4,"commit_id":"b7137b027210b4ed5d63c1d3da8d1534e07fe4ed","original_commit_id":"b7137b027210b4ed5d63c1d3da8d1534e07fe4ed","user":{"login":"stevenaproctor","id":11977962,"avatar_url":"https://avatars3.githubusercontent.com/u/11977962?v=4","gravatar_id":"","url":"https://api.github.com/users/stevenaproctor","html_url":"https://github.com/stevenaproctor","followers_url":"https://api.github.com/users/stevenaproctor/followers","following_url":"https://api.github.com/users/stevenaproctor/following{/other_user}","gists_url":"https://api.github.com/users/stevenaproctor/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenaproctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenaproctor/subscriptions","organizations_url":"https://api.github.com/users/stevenaproctor/orgs","repos_url":"https://api.github.com/users/stevenaproctor/repos","events_url":"https://api.github.com/users/stevenaproctor/events{/privacy}","received_events_url":"https://api.github.com/users/stevenaproctor/received_events","type":"User","site_admin":false},"body":"I think the spans and i class space the reading out of the text in most, if not all, cases. I do not think it needs a separator like a colon.","created_at":"2017-10-04T11:02:07Z","updated_at":"2017-10-04T11:02:07Z","html_url":"https://github.com/alphagov/govuk_elements/pull/564#discussion_r142640378","pull_request_url":"https://api.github.com/repos/alphagov/govuk_elements/pulls/564","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk_elements/pulls/comments/142640378"},"html":{"href":"https://github.com/alphagov/govuk_elements/pull/564#discussion_r142640378"},"pull_request":{"href":"https://api.github.com/repos/alphagov/govuk_elements/pulls/564"}},"in_reply_to_id":142626124},"pull_request":{"url":"https://api.github.com/repos/alphagov/govuk_elements/pulls/564","id":144447752,"html_url":"https://github.com/alphagov/govuk_elements/pull/564","diff_url":"https://github.com/alphagov/govuk_elements/pull/564.diff","patch_url":"https://github.com/alphagov/govuk_elements/pull/564.patch","issue_url":"https://api.github.com/repos/alphagov/govuk_elements/issues/564","number":564,"state":"open","locked":false,"title":"[Discuss] Improve legal text","user":{"login":"selfthinker","id":108893,"avatar_url":"https://avatars3.githubusercontent.com/u/108893?v=4","gravatar_id":"","url":"https://api.github.com/users/selfthinker","html_url":"https://github.com/selfthinker","followers_url":"https://api.github.com/users/selfthinker/followers","following_url":"https://api.github.com/users/selfthinker/following{/other_user}","gists_url":"https://api.github.com/users/selfthinker/gists{/gist_id}","starred_url":"https://api.github.com/users/selfthinker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selfthinker/subscriptions","organizations_url":"https://api.github.com/users/selfthinker/orgs","repos_url":"https://api.github.com/users/selfthinker/repos","events_url":"https://api.github.com/users/selfthinker/events{/privacy}","received_events_url":"https://api.github.com/users/selfthinker/received_events","type":"User","site_admin":false},"body":"## What problem does the pull request solve?\r\n\r\nIt all started with @stevenaproctor and @chrismoorembe from HMRC asking us why the visually hidden text for so-called \"legal text\" is \"warning\". They found that text is \"rather extreme\".\r\nI then found that the PR which introduced it (#116) had started it as \"warning text\" and that GOV.UK (Govspeak and other GOV.UK Components) are also calling it \"warning callout\". But the visually hidden text varies (\"Help\", \"Notice\", etc.).\r\nIt was called \"legal text\" to avoid being misused and over-used. But I assume it didn't work out as I've seen cases where it is simply used to highlight something. If it is not used as intended, it makes sense to use a broader term and to clarify the use.\r\n\r\nThis is making a couple of related changes:\r\n\r\n* Avoid duplication of intro by rewriting intro on the icons page\r\n* Make people aware of hidden text (because it often gets forgotten which can lead to less accessible content)\r\n* Change hidden text from 'Warning' to 'Important'\r\n* Rename 'legal text' to 'warning text' to reflect the reality of how it's used and add that it should be used sparingly\r\n* Rename 'inset text' to 'important text' to describe semantics and not style... The fact that there is a style for \"important\" text above the other \"important\" text got me stumped. I'm not sure how to best distinguish the two while also treating them consistently? Can users tell what the difference is between the two?\r\n\r\n## How has this been tested?\r\nThis is more or less only a copy change. But as such it should ideally be user-tested. And it would be ideal if we knew how services are implementing the pattern.\r\nI haven't done any research on it, but it would be good to know if others have.\r\n\r\n## Has the documentation been updated?\r\nYup.\r\n\r\n## Please discuss\r\n\r\nI'm happy to make single PRs out of this one, so we can merge only some of them. Please discuss which of these changes you find useful and which not and why.","created_at":"2017-10-03T15:05:37Z","updated_at":"2017-10-04T11:02:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a48e43e6322dd0bd96fe0dea99184140aa7a794","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/govuk_elements/pulls/564/commits","review_comments_url":"https://api.github.com/repos/alphagov/govuk_elements/pulls/564/comments","review_comment_url":"https://api.github.com/repos/alphagov/govuk_elements/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/govuk_elements/issues/564/comments","statuses_url":"https://api.github.com/repos/alphagov/govuk_elements/statuses/b7137b027210b4ed5d63c1d3da8d1534e07fe4ed","head":{"label":"alphagov:warning-text","ref":"warning-text","sha":"b7137b027210b4ed5d63c1d3da8d1534e07fe4ed","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":17901778,"name":"govuk_elements","full_name":"alphagov/govuk_elements","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk_elements","description":"GOV.UK Elements form the building blocks from which all pages are made.","fork":false,"url":"https://api.github.com/repos/alphagov/govuk_elements","forks_url":"https://api.github.com/repos/alphagov/govuk_elements/forks","keys_url":"https://api.github.com/repos/alphagov/govuk_elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk_elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk_elements/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk_elements/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk_elements/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk_elements/events","assignees_url":"https://api.github.com/repos/alphagov/govuk_elements/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk_elements/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk_elements/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk_elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk_elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk_elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk_elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk_elements/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk_elements/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk_elements/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk_elements/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk_elements/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk_elements/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk_elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk_elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk_elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk_elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk_elements/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk_elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk_elements/merges","archive_url":"https://api.github.com/repos/alphagov/govuk_elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk_elements/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk_elements/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk_elements/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk_elements/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk_elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk_elements/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk_elements/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk_elements/deployments","created_at":"2014-03-19T11:29:16Z","updated_at":"2017-09-17T11:18:48Z","pushed_at":"2017-10-04T09:02:51Z","git_url":"git://github.com/alphagov/govuk_elements.git","ssh_url":"[email protected]:alphagov/govuk_elements.git","clone_url":"https://github.com/alphagov/govuk_elements.git","svn_url":"https://github.com/alphagov/govuk_elements","homepage":"https://govuk-elements.herokuapp.com/","size":17270,"stargazers_count":188,"watchers_count":188,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":38,"forks":85,"open_issues":38,"watchers":188,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"7d845267dbe01a2e963194b0ac960acae23640d2","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":17901778,"name":"govuk_elements","full_name":"alphagov/govuk_elements","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk_elements","description":"GOV.UK Elements form the building blocks from which all pages are made.","fork":false,"url":"https://api.github.com/repos/alphagov/govuk_elements","forks_url":"https://api.github.com/repos/alphagov/govuk_elements/forks","keys_url":"https://api.github.com/repos/alphagov/govuk_elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk_elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk_elements/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk_elements/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk_elements/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk_elements/events","assignees_url":"https://api.github.com/repos/alphagov/govuk_elements/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk_elements/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk_elements/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk_elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk_elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk_elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk_elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk_elements/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk_elements/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk_elements/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk_elements/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk_elements/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk_elements/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk_elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk_elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk_elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk_elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk_elements/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk_elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk_elements/merges","archive_url":"https://api.github.com/repos/alphagov/govuk_elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk_elements/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk_elements/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk_elements/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk_elements/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk_elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk_elements/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk_elements/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk_elements/deployments","created_at":"2014-03-19T11:29:16Z","updated_at":"2017-09-17T11:18:48Z","pushed_at":"2017-10-04T09:02:51Z","git_url":"git://github.com/alphagov/govuk_elements.git","ssh_url":"[email protected]:alphagov/govuk_elements.git","clone_url":"https://github.com/alphagov/govuk_elements.git","svn_url":"https://github.com/alphagov/govuk_elements","homepage":"https://govuk-elements.herokuapp.com/","size":17270,"stargazers_count":188,"watchers_count":188,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":38,"forks":85,"open_issues":38,"watchers":188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk_elements/pulls/564"},"html":{"href":"https://github.com/alphagov/govuk_elements/pull/564"},"issue":{"href":"https://api.github.com/repos/alphagov/govuk_elements/issues/564"},"comments":{"href":"https://api.github.com/repos/alphagov/govuk_elements/issues/564/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/govuk_elements/pulls/564/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/govuk_elements/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/govuk_elements/pulls/564/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/govuk_elements/statuses/b7137b027210b4ed5d63c1d3da8d1534e07fe4ed"}},"author_association":"CONTRIBUTOR"}} | {
"id": 17901778,
"name": "alphagov/govuk_elements",
"url": "https://api.github.com/repos/alphagov/govuk_elements"
} | {
"id": 11977962,
"login": "stevenaproctor",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11977962?",
"url": "https://api.github.com/users/stevenaproctor"
} | {
"id": 596977,
"login": "alphagov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/596977?",
"url": "https://api.github.com/orgs/alphagov"
} | 2017-10-04T11:02:07 | 6672304018 | {"actor":{"display_login":"stevenaproctor"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/paas-cf/pulls/comments/99330549","pull_request_review_id":20004522,"id":99330549,"diff_hunk":"@@ -46,7 +46,7 @@ lint_yaml:\n lint_terraform: dev\n \t$(eval export TF_VAR_system_dns_zone_name=$SYSTEM_DNS_ZONE_NAME)\n \t$(eval export TF_VAR_apps_dns_zone_name=$APPS_DNS_ZONE_NAME)\n-\tfind terraform -mindepth 1 -maxdepth 1 -type d -not -path 'terraform/providers' -not -path 'terraform/scripts' -print0 | xargs -0 -n 1 -t terraform graph > /dev/null\n+\tfind terraform -mindepth 1 -maxdepth 1 -type d -not -path 'terraform/providers' -not -path 'terraform/scripts' -print0 | xargs -0 -n 1 -t sh -c 'terraform get $$1 && terraform graph $$1' -- > /dev/null","path":"Makefile","position":null,"original_position":5,"commit_id":"efeb6ee110a19a2379c56df7c07ceeab48681a17","original_commit_id":"94c595fde4dabd770504bddb40a41ee1ac1250c7","user":{"login":"paroxp","id":2418945,"avatar_url":"https://avatars.githubusercontent.com/u/2418945?v=3","gravatar_id":"","url":"https://api.github.com/users/paroxp","html_url":"https://github.com/paroxp","followers_url":"https://api.github.com/users/paroxp/followers","following_url":"https://api.github.com/users/paroxp/following{/other_user}","gists_url":"https://api.github.com/users/paroxp/gists{/gist_id}","starred_url":"https://api.github.com/users/paroxp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paroxp/subscriptions","organizations_url":"https://api.github.com/users/paroxp/orgs","repos_url":"https://api.github.com/users/paroxp/repos","events_url":"https://api.github.com/users/paroxp/events{/privacy}","received_events_url":"https://api.github.com/users/paroxp/received_events","type":"User","site_admin":false},"body":"This has now been extracted into a separate file.\r\n\r\nI would like to point out, that this command will fail locally, as it did before with two `provider pingdom couldn't be found` errors.","created_at":"2017-02-03T12:45:45Z","updated_at":"2017-02-03T12:45:45Z","html_url":"https://github.com/alphagov/paas-cf/pull/753#discussion_r99330549","pull_request_url":"https://api.github.com/repos/alphagov/paas-cf/pulls/753","_links":{"self":{"href":"https://api.github.com/repos/alphagov/paas-cf/pulls/comments/99330549"},"html":{"href":"https://github.com/alphagov/paas-cf/pull/753#discussion_r99330549"},"pull_request":{"href":"https://api.github.com/repos/alphagov/paas-cf/pulls/753"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/paas-cf/pulls/753","id":104380724,"html_url":"https://github.com/alphagov/paas-cf/pull/753","diff_url":"https://github.com/alphagov/paas-cf/pull/753.diff","patch_url":"https://github.com/alphagov/paas-cf/pull/753.patch","issue_url":"https://api.github.com/repos/alphagov/paas-cf/issues/753","number":753,"state":"open","locked":false,"title":"[#136353673] Add ability to create CDNs programmatically","user":{"login":"paroxp","id":2418945,"avatar_url":"https://avatars.githubusercontent.com/u/2418945?v=3","gravatar_id":"","url":"https://api.github.com/users/paroxp","html_url":"https://github.com/paroxp","followers_url":"https://api.github.com/users/paroxp/followers","following_url":"https://api.github.com/users/paroxp/following{/other_user}","gists_url":"https://api.github.com/users/paroxp/gists{/gist_id}","starred_url":"https://api.github.com/users/paroxp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paroxp/subscriptions","organizations_url":"https://api.github.com/users/paroxp/orgs","repos_url":"https://api.github.com/users/paroxp/repos","events_url":"https://api.github.com/users/paroxp/events{/privacy}","received_events_url":"https://api.github.com/users/paroxp/received_events","type":"User","site_admin":false},"body":"## What\r\n\r\nWe would like to create a CDN for the PaaS Documentation and the Product Page and be able to access it, from the new subdomain.\r\n\r\nThis change, should allow any user with an access, create CloudFront Distributions. The CNAME record, will be created as part of the system domain name, for each distribution.\r\n\r\n## How to review\r\n\r\n1. Run `create-cloudfoundry` pipeline from this branch\r\n1. Run `ACTION=plan make dev setup_cdn_instances`\r\n1. Experience no errors from the above\r\n1. Run `ACTION=apply make dev setup_cdn_instances`\r\n1. Experience no errors from the above\r\n1. Wait... This may take a while. I suggest logging into AWS Console and monitoring CloudFront Distributions\r\n1. Visiting `docs.${DEPLOY_ENV}.dev.cloudpipeline.digital` should result in `paas-tech-docs`\r\n1. Visiting `www.${DEPLOY_ENV}.dev.cloudpipeline.digital` should result in `paas-product-page`\r\n\r\n## Who can review\r\n\r\nNot @paroxp","created_at":"2017-02-02T17:03:47Z","updated_at":"2017-02-03T12:45:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5ef885ab1e435fd2ed15f559d200a8d5f49b928","assignee":{"login":"alext","id":5560,"avatar_url":"https://avatars.githubusercontent.com/u/5560?v=3","gravatar_id":"","url":"https://api.github.com/users/alext","html_url":"https://github.com/alext","followers_url":"https://api.github.com/users/alext/followers","following_url":"https://api.github.com/users/alext/following{/other_user}","gists_url":"https://api.github.com/users/alext/gists{/gist_id}","starred_url":"https://api.github.com/users/alext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alext/subscriptions","organizations_url":"https://api.github.com/users/alext/orgs","repos_url":"https://api.github.com/users/alext/repos","events_url":"https://api.github.com/users/alext/events{/privacy}","received_events_url":"https://api.github.com/users/alext/received_events","type":"User","site_admin":false},"assignees":[{"login":"alext","id":5560,"avatar_url":"https://avatars.githubusercontent.com/u/5560?v=3","gravatar_id":"","url":"https://api.github.com/users/alext","html_url":"https://github.com/alext","followers_url":"https://api.github.com/users/alext/followers","following_url":"https://api.github.com/users/alext/following{/other_user}","gists_url":"https://api.github.com/users/alext/gists{/gist_id}","starred_url":"https://api.github.com/users/alext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alext/subscriptions","organizations_url":"https://api.github.com/users/alext/orgs","repos_url":"https://api.github.com/users/alext/repos","events_url":"https://api.github.com/users/alext/events{/privacy}","received_events_url":"https://api.github.com/users/alext/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/paas-cf/pulls/753/commits","review_comments_url":"https://api.github.com/repos/alphagov/paas-cf/pulls/753/comments","review_comment_url":"https://api.github.com/repos/alphagov/paas-cf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/paas-cf/issues/753/comments","statuses_url":"https://api.github.com/repos/alphagov/paas-cf/statuses/efeb6ee110a19a2379c56df7c07ceeab48681a17","head":{"label":"alphagov:docs_available_136353673","ref":"docs_available_136353673","sha":"efeb6ee110a19a2379c56df7c07ceeab48681a17","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":46716359,"name":"paas-cf","full_name":"alphagov/paas-cf","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/paas-cf","description":"Government PaaS - Cloud Foundry","fork":false,"url":"https://api.github.com/repos/alphagov/paas-cf","forks_url":"https://api.github.com/repos/alphagov/paas-cf/forks","keys_url":"https://api.github.com/repos/alphagov/paas-cf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/paas-cf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/paas-cf/teams","hooks_url":"https://api.github.com/repos/alphagov/paas-cf/hooks","issue_events_url":"https://api.github.com/repos/alphagov/paas-cf/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/paas-cf/events","assignees_url":"https://api.github.com/repos/alphagov/paas-cf/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/paas-cf/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/paas-cf/tags","blobs_url":"https://api.github.com/repos/alphagov/paas-cf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/paas-cf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/paas-cf/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/paas-cf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/paas-cf/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/paas-cf/languages","stargazers_url":"https://api.github.com/repos/alphagov/paas-cf/stargazers","contributors_url":"https://api.github.com/repos/alphagov/paas-cf/contributors","subscribers_url":"https://api.github.com/repos/alphagov/paas-cf/subscribers","subscription_url":"https://api.github.com/repos/alphagov/paas-cf/subscription","commits_url":"https://api.github.com/repos/alphagov/paas-cf/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/paas-cf/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/paas-cf/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/paas-cf/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/paas-cf/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/paas-cf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/paas-cf/merges","archive_url":"https://api.github.com/repos/alphagov/paas-cf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/paas-cf/downloads","issues_url":"https://api.github.com/repos/alphagov/paas-cf/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/paas-cf/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/paas-cf/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/paas-cf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/paas-cf/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/paas-cf/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/paas-cf/deployments","created_at":"2015-11-23T11:36:57Z","updated_at":"2017-01-05T19:43:13Z","pushed_at":"2017-02-03T12:44:38Z","git_url":"git://github.com/alphagov/paas-cf.git","ssh_url":"[email protected]:alphagov/paas-cf.git","clone_url":"https://github.com/alphagov/paas-cf.git","svn_url":"https://github.com/alphagov/paas-cf","homepage":null,"size":16950,"stargazers_count":29,"watchers_count":29,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":11,"forks":8,"open_issues":11,"watchers":29,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"730b37b87fc81fef73aa042b906c072f2bfe87dd","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":46716359,"name":"paas-cf","full_name":"alphagov/paas-cf","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/paas-cf","description":"Government PaaS - Cloud Foundry","fork":false,"url":"https://api.github.com/repos/alphagov/paas-cf","forks_url":"https://api.github.com/repos/alphagov/paas-cf/forks","keys_url":"https://api.github.com/repos/alphagov/paas-cf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/paas-cf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/paas-cf/teams","hooks_url":"https://api.github.com/repos/alphagov/paas-cf/hooks","issue_events_url":"https://api.github.com/repos/alphagov/paas-cf/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/paas-cf/events","assignees_url":"https://api.github.com/repos/alphagov/paas-cf/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/paas-cf/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/paas-cf/tags","blobs_url":"https://api.github.com/repos/alphagov/paas-cf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/paas-cf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/paas-cf/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/paas-cf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/paas-cf/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/paas-cf/languages","stargazers_url":"https://api.github.com/repos/alphagov/paas-cf/stargazers","contributors_url":"https://api.github.com/repos/alphagov/paas-cf/contributors","subscribers_url":"https://api.github.com/repos/alphagov/paas-cf/subscribers","subscription_url":"https://api.github.com/repos/alphagov/paas-cf/subscription","commits_url":"https://api.github.com/repos/alphagov/paas-cf/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/paas-cf/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/paas-cf/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/paas-cf/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/paas-cf/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/paas-cf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/paas-cf/merges","archive_url":"https://api.github.com/repos/alphagov/paas-cf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/paas-cf/downloads","issues_url":"https://api.github.com/repos/alphagov/paas-cf/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/paas-cf/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/paas-cf/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/paas-cf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/paas-cf/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/paas-cf/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/paas-cf/deployments","created_at":"2015-11-23T11:36:57Z","updated_at":"2017-01-05T19:43:13Z","pushed_at":"2017-02-03T12:44:38Z","git_url":"git://github.com/alphagov/paas-cf.git","ssh_url":"[email protected]:alphagov/paas-cf.git","clone_url":"https://github.com/alphagov/paas-cf.git","svn_url":"https://github.com/alphagov/paas-cf","homepage":null,"size":16950,"stargazers_count":29,"watchers_count":29,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":11,"forks":8,"open_issues":11,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/paas-cf/pulls/753"},"html":{"href":"https://github.com/alphagov/paas-cf/pull/753"},"issue":{"href":"https://api.github.com/repos/alphagov/paas-cf/issues/753"},"comments":{"href":"https://api.github.com/repos/alphagov/paas-cf/issues/753/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/paas-cf/pulls/753/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/paas-cf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/paas-cf/pulls/753/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/paas-cf/statuses/efeb6ee110a19a2379c56df7c07ceeab48681a17"}}}} | {
"id": 46716359,
"name": "alphagov/paas-cf",
"url": "https://api.github.com/repos/alphagov/paas-cf"
} | {
"id": 2418945,
"login": "paroxp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2418945?",
"url": "https://api.github.com/users/paroxp"
} | {
"id": 596977,
"login": "alphagov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/596977?",
"url": "https://api.github.com/orgs/alphagov"
} | 2017-02-03T12:45:45 | 5261386520 | {"actor":{"display_login":"paroxp"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/comments/100768465","pull_request_review_id":21482167,"id":100768465,"diff_hunk":"@@ -187,57 +187,56 @@ def start_new_draft_service(framework_slug, lot_slug):\n )\n \n section = content.get_section(content.get_next_editable_section_id())\n+ if section is None:\n+ section = content.get_section(content.get_next_section_id(None))","path":"app/main/views/services.py","position":14,"original_position":14,"commit_id":"8afd636e7c025735ee0777c4ebb8b77876536ca9","original_commit_id":"219fb4dfb4f2ee5ea8970b5c62d687236a3f90b2","user":{"login":"TheDoubleK","id":6525554,"avatar_url":"https://avatars.githubusercontent.com/u/6525554?v=3","gravatar_id":"","url":"https://api.github.com/users/TheDoubleK","html_url":"https://github.com/TheDoubleK","followers_url":"https://api.github.com/users/TheDoubleK/followers","following_url":"https://api.github.com/users/TheDoubleK/following{/other_user}","gists_url":"https://api.github.com/users/TheDoubleK/gists{/gist_id}","starred_url":"https://api.github.com/users/TheDoubleK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheDoubleK/subscriptions","organizations_url":"https://api.github.com/users/TheDoubleK/orgs","repos_url":"https://api.github.com/users/TheDoubleK/repos","events_url":"https://api.github.com/users/TheDoubleK/events{/privacy}","received_events_url":"https://api.github.com/users/TheDoubleK/received_events","type":"User","site_admin":false},"body":"Nice.","created_at":"2017-02-13T10:55:30Z","updated_at":"2017-02-13T10:55:30Z","html_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend/pull/609#discussion_r100768465","pull_request_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/609","_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/comments/100768465"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-supplier-frontend/pull/609#discussion_r100768465"},"pull_request":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/609"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/609","id":105233569,"html_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend/pull/609","diff_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend/pull/609.diff","patch_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend/pull/609.patch","issue_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/609","number":609,"state":"open","locked":false,"title":"[194] One question per page","user":{"login":"samuelhwilliams","id":2920760,"avatar_url":"https://avatars.githubusercontent.com/u/2920760?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelhwilliams","html_url":"https://github.com/samuelhwilliams","followers_url":"https://api.github.com/users/samuelhwilliams/followers","following_url":"https://api.github.com/users/samuelhwilliams/following{/other_user}","gists_url":"https://api.github.com/users/samuelhwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelhwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelhwilliams/subscriptions","organizations_url":"https://api.github.com/users/samuelhwilliams/orgs","repos_url":"https://api.github.com/users/samuelhwilliams/repos","events_url":"https://api.github.com/users/samuelhwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/samuelhwilliams/received_events","type":"User","site_admin":false},"body":"One question per page flow for supplier services.\r\n\r\nThis changes the service specification flow for suppliers and moves towards a 'one question per page' standard. On the summary page, per-section editing is disabled and a link to add/edit answers is shown next to each question. As you work through the service spec, each question will follow on to the next question in the same section; when you reach the end of the section you will be returned to the service summary.\r\n\r\nIncluded in this PR is a bugfix for multiquestions that will allow them to display any question type as children without individually specifying/checking the type each time.","created_at":"2017-02-08T14:59:47Z","updated_at":"2017-02-13T10:55:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"212441a62eb8e6c27c513981a98456e3267d18ea","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/609/commits","review_comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/609/comments","review_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/609/comments","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/statuses/8afd636e7c025735ee0777c4ebb8b77876536ca9","head":{"label":"alphagov:shw-one-question-per-page","ref":"shw-one-question-per-page","sha":"8afd636e7c025735ee0777c4ebb8b77876536ca9","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":31256533,"name":"digitalmarketplace-supplier-frontend","full_name":"alphagov/digitalmarketplace-supplier-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend","description":"Frontend supplier application for the digital marketplace.","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/deployments","created_at":"2015-02-24T11:10:47Z","updated_at":"2016-10-24T15:23:17Z","pushed_at":"2017-02-13T10:47:47Z","git_url":"git://github.com/alphagov/digitalmarketplace-supplier-frontend.git","ssh_url":"[email protected]:alphagov/digitalmarketplace-supplier-frontend.git","clone_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend.git","svn_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend","homepage":null,"size":2307,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":2,"forks":10,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"23dc2bd67533a32115329672efcceef154a9f4ee","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":31256533,"name":"digitalmarketplace-supplier-frontend","full_name":"alphagov/digitalmarketplace-supplier-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend","description":"Frontend supplier application for the digital marketplace.","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/deployments","created_at":"2015-02-24T11:10:47Z","updated_at":"2016-10-24T15:23:17Z","pushed_at":"2017-02-13T10:47:47Z","git_url":"git://github.com/alphagov/digitalmarketplace-supplier-frontend.git","ssh_url":"[email protected]:alphagov/digitalmarketplace-supplier-frontend.git","clone_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend.git","svn_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend","homepage":null,"size":2307,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":2,"forks":10,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/609"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-supplier-frontend/pull/609"},"issue":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/609"},"comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/609/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/609/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/609/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/statuses/8afd636e7c025735ee0777c4ebb8b77876536ca9"}}}} | {
"id": 31256533,
"name": "alphagov/digitalmarketplace-supplier-frontend",
"url": "https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend"
} | {
"id": 6525554,
"login": "TheDoubleK",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6525554?",
"url": "https://api.github.com/users/TheDoubleK"
} | {
"id": 596977,
"login": "alphagov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/596977?",
"url": "https://api.github.com/orgs/alphagov"
} | 2017-02-13T10:55:30 | 5313045395 | {"actor":{"display_login":"TheDoubleK"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/audiokit/AudioKit/pulls/comments/97045722","pull_request_review_id":17647922,"id":97045722,"diff_hunk":"@@ -0,0 +1,40 @@\n+//\n+// MIDIPacketListGenerator.swift\n+// AudioKit\n+//\n+// Created by Aurelius Prochazka, revision history on Github.\n+// Copyright © 2016 AudioKit. All rights reserved.\n+//\n+\n+/// Generator for MIDIPacketList allowing iteration over its list of MIDIPacket objects.\n+public struct MIDIPacketListGenerator: IteratorProtocol {\n+ public typealias Element = MIDIPacket\n+ \n+ /// Initialize the packet list generator with a packet list\n+ ///\n+ /// - parameter packetList: MIDI Packet List\n+ ///\n+ init(packetList: MIDIPacketList) {\n+ let ptr = UnsafeMutablePointer<MIDIPacket>.allocate(capacity: 1)\n+ ptr.initialize(to: packetList.packet)\n+ self.packet = ptr\n+ self.count = packetList.numPackets\n+ }\n+ \n+ /// Provide the next element (packet)\n+ public mutating func next() -> Element? {\n+ guard self.packet != nil && self.index < self.count else { return nil }\n+ \n+ let lastPacket = self.packet!\n+ self.packet = MIDIPacketNext(self.packet!)\n+ self.index += 1\n+ return lastPacket.pointee\n+ }\n+ \n+ // Extracted packet list info\n+ var count: UInt32\n+ var index: UInt32 = 0\n+ ","path":"AudioKit/Common/MIDI/Packets/MIDIPacketListGenerator.swift","position":37,"original_position":37,"commit_id":"0179a706447b59a7fc9e6f4472962b812d163710","original_commit_id":"0179a706447b59a7fc9e6f4472962b812d163710","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)","created_at":"2017-01-20T10:22:12Z","updated_at":"2017-01-20T10:22:13Z","html_url":"https://github.com/audiokit/AudioKit/pull/700#discussion_r97045722","pull_request_url":"https://api.github.com/repos/audiokit/AudioKit/pulls/700","_links":{"self":{"href":"https://api.github.com/repos/audiokit/AudioKit/pulls/comments/97045722"},"html":{"href":"https://github.com/audiokit/AudioKit/pull/700#discussion_r97045722"},"pull_request":{"href":"https://api.github.com/repos/audiokit/AudioKit/pulls/700"}}},"pull_request":{"url":"https://api.github.com/repos/audiokit/AudioKit/pulls/700","id":102436824,"html_url":"https://github.com/audiokit/AudioKit/pull/700","diff_url":"https://github.com/audiokit/AudioKit/pull/700.diff","patch_url":"https://github.com/audiokit/AudioKit/pull/700.patch","issue_url":"https://api.github.com/repos/audiokit/AudioKit/issues/700","number":700,"state":"open","locked":false,"title":"Fix crash with AKMIDISampler and AKSequencer","user":{"login":"allanweir","id":2892400,"avatar_url":"https://avatars.githubusercontent.com/u/2892400?v=3","gravatar_id":"","url":"https://api.github.com/users/allanweir","html_url":"https://github.com/allanweir","followers_url":"https://api.github.com/users/allanweir/followers","following_url":"https://api.github.com/users/allanweir/following{/other_user}","gists_url":"https://api.github.com/users/allanweir/gists{/gist_id}","starred_url":"https://api.github.com/users/allanweir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanweir/subscriptions","organizations_url":"https://api.github.com/users/allanweir/orgs","repos_url":"https://api.github.com/users/allanweir/repos","events_url":"https://api.github.com/users/allanweir/events{/privacy}","received_events_url":"https://api.github.com/users/allanweir/received_events","type":"User","site_admin":false},"body":"It looks a rewrite of how the MIDIPacketList iterator worked between version 3.5 and 3.5.1 led to crashes in an app which used MP3's or WAV's via AKMIDISampler.\r\n\r\nThe guard statement in MIDIPacketList+SequenceType which deallocated packets was triggering a object freed before being allocated error. I assume there was a reason it was rewritten so if there's a way to reincorporate those changes whilst making it safe for use in the situations I've found let me know and hopefully we can solve it.","created_at":"2017-01-20T10:22:05Z","updated_at":"2017-01-20T10:22:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00bc97bc05a3e30a8777cf0cf6021ba4d42056ca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/audiokit/AudioKit/pulls/700/commits","review_comments_url":"https://api.github.com/repos/audiokit/AudioKit/pulls/700/comments","review_comment_url":"https://api.github.com/repos/audiokit/AudioKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/audiokit/AudioKit/issues/700/comments","statuses_url":"https://api.github.com/repos/audiokit/AudioKit/statuses/0179a706447b59a7fc9e6f4472962b812d163710","head":{"label":"allanweir:master","ref":"master","sha":"0179a706447b59a7fc9e6f4472962b812d163710","user":{"login":"allanweir","id":2892400,"avatar_url":"https://avatars.githubusercontent.com/u/2892400?v=3","gravatar_id":"","url":"https://api.github.com/users/allanweir","html_url":"https://github.com/allanweir","followers_url":"https://api.github.com/users/allanweir/followers","following_url":"https://api.github.com/users/allanweir/following{/other_user}","gists_url":"https://api.github.com/users/allanweir/gists{/gist_id}","starred_url":"https://api.github.com/users/allanweir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanweir/subscriptions","organizations_url":"https://api.github.com/users/allanweir/orgs","repos_url":"https://api.github.com/users/allanweir/repos","events_url":"https://api.github.com/users/allanweir/events{/privacy}","received_events_url":"https://api.github.com/users/allanweir/received_events","type":"User","site_admin":false},"repo":{"id":79468946,"name":"AudioKit","full_name":"allanweir/AudioKit","owner":{"login":"allanweir","id":2892400,"avatar_url":"https://avatars.githubusercontent.com/u/2892400?v=3","gravatar_id":"","url":"https://api.github.com/users/allanweir","html_url":"https://github.com/allanweir","followers_url":"https://api.github.com/users/allanweir/followers","following_url":"https://api.github.com/users/allanweir/following{/other_user}","gists_url":"https://api.github.com/users/allanweir/gists{/gist_id}","starred_url":"https://api.github.com/users/allanweir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanweir/subscriptions","organizations_url":"https://api.github.com/users/allanweir/orgs","repos_url":"https://api.github.com/users/allanweir/repos","events_url":"https://api.github.com/users/allanweir/events{/privacy}","received_events_url":"https://api.github.com/users/allanweir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/allanweir/AudioKit","description":"Open-source audio synthesis, processing, & analysis platform.","fork":true,"url":"https://api.github.com/repos/allanweir/AudioKit","forks_url":"https://api.github.com/repos/allanweir/AudioKit/forks","keys_url":"https://api.github.com/repos/allanweir/AudioKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allanweir/AudioKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allanweir/AudioKit/teams","hooks_url":"https://api.github.com/repos/allanweir/AudioKit/hooks","issue_events_url":"https://api.github.com/repos/allanweir/AudioKit/issues/events{/number}","events_url":"https://api.github.com/repos/allanweir/AudioKit/events","assignees_url":"https://api.github.com/repos/allanweir/AudioKit/assignees{/user}","branches_url":"https://api.github.com/repos/allanweir/AudioKit/branches{/branch}","tags_url":"https://api.github.com/repos/allanweir/AudioKit/tags","blobs_url":"https://api.github.com/repos/allanweir/AudioKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allanweir/AudioKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allanweir/AudioKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/allanweir/AudioKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allanweir/AudioKit/statuses/{sha}","languages_url":"https://api.github.com/repos/allanweir/AudioKit/languages","stargazers_url":"https://api.github.com/repos/allanweir/AudioKit/stargazers","contributors_url":"https://api.github.com/repos/allanweir/AudioKit/contributors","subscribers_url":"https://api.github.com/repos/allanweir/AudioKit/subscribers","subscription_url":"https://api.github.com/repos/allanweir/AudioKit/subscription","commits_url":"https://api.github.com/repos/allanweir/AudioKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/allanweir/AudioKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/allanweir/AudioKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/allanweir/AudioKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/allanweir/AudioKit/contents/{+path}","compare_url":"https://api.github.com/repos/allanweir/AudioKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allanweir/AudioKit/merges","archive_url":"https://api.github.com/repos/allanweir/AudioKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allanweir/AudioKit/downloads","issues_url":"https://api.github.com/repos/allanweir/AudioKit/issues{/number}","pulls_url":"https://api.github.com/repos/allanweir/AudioKit/pulls{/number}","milestones_url":"https://api.github.com/repos/allanweir/AudioKit/milestones{/number}","notifications_url":"https://api.github.com/repos/allanweir/AudioKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allanweir/AudioKit/labels{/name}","releases_url":"https://api.github.com/repos/allanweir/AudioKit/releases{/id}","deployments_url":"https://api.github.com/repos/allanweir/AudioKit/deployments","created_at":"2017-01-19T15:52:58Z","updated_at":"2017-01-19T15:53:05Z","pushed_at":"2017-01-20T10:18:20Z","git_url":"git://github.com/allanweir/AudioKit.git","ssh_url":"[email protected]:allanweir/AudioKit.git","clone_url":"https://github.com/allanweir/AudioKit.git","svn_url":"https://github.com/allanweir/AudioKit","homepage":"http://audiokit.io/","size":183676,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"audiokit:master","ref":"master","sha":"b5e727b13f4ed7c460a85eaebdd14d371d4b733f","user":{"login":"audiokit","id":6593633,"avatar_url":"https://avatars.githubusercontent.com/u/6593633?v=3","gravatar_id":"","url":"https://api.github.com/users/audiokit","html_url":"https://github.com/audiokit","followers_url":"https://api.github.com/users/audiokit/followers","following_url":"https://api.github.com/users/audiokit/following{/other_user}","gists_url":"https://api.github.com/users/audiokit/gists{/gist_id}","starred_url":"https://api.github.com/users/audiokit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/audiokit/subscriptions","organizations_url":"https://api.github.com/users/audiokit/orgs","repos_url":"https://api.github.com/users/audiokit/repos","events_url":"https://api.github.com/users/audiokit/events{/privacy}","received_events_url":"https://api.github.com/users/audiokit/received_events","type":"Organization","site_admin":false},"repo":{"id":16096528,"name":"AudioKit","full_name":"audiokit/AudioKit","owner":{"login":"audiokit","id":6593633,"avatar_url":"https://avatars.githubusercontent.com/u/6593633?v=3","gravatar_id":"","url":"https://api.github.com/users/audiokit","html_url":"https://github.com/audiokit","followers_url":"https://api.github.com/users/audiokit/followers","following_url":"https://api.github.com/users/audiokit/following{/other_user}","gists_url":"https://api.github.com/users/audiokit/gists{/gist_id}","starred_url":"https://api.github.com/users/audiokit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/audiokit/subscriptions","organizations_url":"https://api.github.com/users/audiokit/orgs","repos_url":"https://api.github.com/users/audiokit/repos","events_url":"https://api.github.com/users/audiokit/events{/privacy}","received_events_url":"https://api.github.com/users/audiokit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/audiokit/AudioKit","description":"Open-source audio synthesis, processing, & analysis platform.","fork":false,"url":"https://api.github.com/repos/audiokit/AudioKit","forks_url":"https://api.github.com/repos/audiokit/AudioKit/forks","keys_url":"https://api.github.com/repos/audiokit/AudioKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/audiokit/AudioKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/audiokit/AudioKit/teams","hooks_url":"https://api.github.com/repos/audiokit/AudioKit/hooks","issue_events_url":"https://api.github.com/repos/audiokit/AudioKit/issues/events{/number}","events_url":"https://api.github.com/repos/audiokit/AudioKit/events","assignees_url":"https://api.github.com/repos/audiokit/AudioKit/assignees{/user}","branches_url":"https://api.github.com/repos/audiokit/AudioKit/branches{/branch}","tags_url":"https://api.github.com/repos/audiokit/AudioKit/tags","blobs_url":"https://api.github.com/repos/audiokit/AudioKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/audiokit/AudioKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/audiokit/AudioKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/audiokit/AudioKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/audiokit/AudioKit/statuses/{sha}","languages_url":"https://api.github.com/repos/audiokit/AudioKit/languages","stargazers_url":"https://api.github.com/repos/audiokit/AudioKit/stargazers","contributors_url":"https://api.github.com/repos/audiokit/AudioKit/contributors","subscribers_url":"https://api.github.com/repos/audiokit/AudioKit/subscribers","subscription_url":"https://api.github.com/repos/audiokit/AudioKit/subscription","commits_url":"https://api.github.com/repos/audiokit/AudioKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/audiokit/AudioKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/audiokit/AudioKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/audiokit/AudioKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/audiokit/AudioKit/contents/{+path}","compare_url":"https://api.github.com/repos/audiokit/AudioKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/audiokit/AudioKit/merges","archive_url":"https://api.github.com/repos/audiokit/AudioKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/audiokit/AudioKit/downloads","issues_url":"https://api.github.com/repos/audiokit/AudioKit/issues{/number}","pulls_url":"https://api.github.com/repos/audiokit/AudioKit/pulls{/number}","milestones_url":"https://api.github.com/repos/audiokit/AudioKit/milestones{/number}","notifications_url":"https://api.github.com/repos/audiokit/AudioKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/audiokit/AudioKit/labels{/name}","releases_url":"https://api.github.com/repos/audiokit/AudioKit/releases{/id}","deployments_url":"https://api.github.com/repos/audiokit/AudioKit/deployments","created_at":"2014-01-21T08:16:07Z","updated_at":"2017-01-20T10:07:20Z","pushed_at":"2017-01-20T10:22:06Z","git_url":"git://github.com/audiokit/AudioKit.git","ssh_url":"[email protected]:audiokit/AudioKit.git","clone_url":"https://github.com/audiokit/AudioKit.git","svn_url":"https://github.com/audiokit/AudioKit","homepage":"http://audiokit.io/","size":183929,"stargazers_count":2955,"watchers_count":2955,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":449,"mirror_url":null,"open_issues_count":8,"forks":449,"open_issues":8,"watchers":2955,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/audiokit/AudioKit/pulls/700"},"html":{"href":"https://github.com/audiokit/AudioKit/pull/700"},"issue":{"href":"https://api.github.com/repos/audiokit/AudioKit/issues/700"},"comments":{"href":"https://api.github.com/repos/audiokit/AudioKit/issues/700/comments"},"review_comments":{"href":"https://api.github.com/repos/audiokit/AudioKit/pulls/700/comments"},"review_comment":{"href":"https://api.github.com/repos/audiokit/AudioKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/audiokit/AudioKit/pulls/700/commits"},"statuses":{"href":"https://api.github.com/repos/audiokit/AudioKit/statuses/0179a706447b59a7fc9e6f4472962b812d163710"}}}} | {
"id": 16096528,
"name": "audiokit/AudioKit",
"url": "https://api.github.com/repos/audiokit/AudioKit"
} | {
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
} | {
"id": 6593633,
"login": "audiokit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6593633?",
"url": "https://api.github.com/orgs/audiokit"
} | 2017-01-20T10:22:12 | 5185420884 | {"actor":{"display_login":"houndci-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/bigmlcom/python/pulls/comments/114444759","pull_request_review_id":35911678,"id":114444759,"diff_hunk":"@@ -4120,6 +4119,52 @@ argument with code ``0`` to use ``last prediction`` and ``1`` for\n local_model.predict({\"petal length\": 3, \"petal width\": 1},\n missing_strategy=PROPORTIONAL)\n \n+If you would like a per-class prediction of the confidence or","path":"docs/index.rst","position":40,"original_position":40,"commit_id":"a40e752cc7f7cf6446d6d5ef9f3c015ce11258a7","original_commit_id":"a40e752cc7f7cf6446d6d5ef9f3c015ce11258a7","user":{"login":"mmerce","id":722203,"avatar_url":"https://avatars3.githubusercontent.com/u/722203?v=3","gravatar_id":"","url":"https://api.github.com/users/mmerce","html_url":"https://github.com/mmerce","followers_url":"https://api.github.com/users/mmerce/followers","following_url":"https://api.github.com/users/mmerce/following{/other_user}","gists_url":"https://api.github.com/users/mmerce/gists{/gist_id}","starred_url":"https://api.github.com/users/mmerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmerce/subscriptions","organizations_url":"https://api.github.com/users/mmerce/orgs","repos_url":"https://api.github.com/users/mmerce/repos","events_url":"https://api.github.com/users/mmerce/events{/privacy}","received_events_url":"https://api.github.com/users/mmerce/received_events","type":"User","site_admin":false},"body":"Maybe something like:\r\n\r\nFor classification models, it may be useful sometimes to get the predicted probabilites (or confidences) associated to every possible category in our objective field. In this case, you can use the ...","created_at":"2017-05-02T22:58:56Z","updated_at":"2017-05-02T22:58:56Z","html_url":"https://github.com/bigmlcom/python/pull/203#discussion_r114444759","pull_request_url":"https://api.github.com/repos/bigmlcom/python/pulls/203","_links":{"self":{"href":"https://api.github.com/repos/bigmlcom/python/pulls/comments/114444759"},"html":{"href":"https://github.com/bigmlcom/python/pull/203#discussion_r114444759"},"pull_request":{"href":"https://api.github.com/repos/bigmlcom/python/pulls/203"}}},"pull_request":{"url":"https://api.github.com/repos/bigmlcom/python/pulls/203","id":118192699,"html_url":"https://github.com/bigmlcom/python/pull/203","diff_url":"https://github.com/bigmlcom/python/pull/203.diff","patch_url":"https://github.com/bigmlcom/python/pull/203.patch","issue_url":"https://api.github.com/repos/bigmlcom/python/issues/203","number":203,"state":"open","locked":false,"title":"Addition of `predict_probability` for supervised models","user":{"login":"charleslparker","id":1085239,"avatar_url":"https://avatars2.githubusercontent.com/u/1085239?v=3","gravatar_id":"","url":"https://api.github.com/users/charleslparker","html_url":"https://github.com/charleslparker","followers_url":"https://api.github.com/users/charleslparker/followers","following_url":"https://api.github.com/users/charleslparker/following{/other_user}","gists_url":"https://api.github.com/users/charleslparker/gists{/gist_id}","starred_url":"https://api.github.com/users/charleslparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charleslparker/subscriptions","organizations_url":"https://api.github.com/users/charleslparker/orgs","repos_url":"https://api.github.com/users/charleslparker/repos","events_url":"https://api.github.com/users/charleslparker/events{/privacy}","received_events_url":"https://api.github.com/users/charleslparker/received_events","type":"User","site_admin":false},"body":"With the changes requested by @mmerce in her initial mini-review","created_at":"2017-04-28T16:51:51Z","updated_at":"2017-05-02T22:58:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2af9db62e50e39b4b39ac7a8c7dd73648ead59b","assignee":{"login":"mmerce","id":722203,"avatar_url":"https://avatars3.githubusercontent.com/u/722203?v=3","gravatar_id":"","url":"https://api.github.com/users/mmerce","html_url":"https://github.com/mmerce","followers_url":"https://api.github.com/users/mmerce/followers","following_url":"https://api.github.com/users/mmerce/following{/other_user}","gists_url":"https://api.github.com/users/mmerce/gists{/gist_id}","starred_url":"https://api.github.com/users/mmerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmerce/subscriptions","organizations_url":"https://api.github.com/users/mmerce/orgs","repos_url":"https://api.github.com/users/mmerce/repos","events_url":"https://api.github.com/users/mmerce/events{/privacy}","received_events_url":"https://api.github.com/users/mmerce/received_events","type":"User","site_admin":false},"assignees":[{"login":"mmerce","id":722203,"avatar_url":"https://avatars3.githubusercontent.com/u/722203?v=3","gravatar_id":"","url":"https://api.github.com/users/mmerce","html_url":"https://github.com/mmerce","followers_url":"https://api.github.com/users/mmerce/followers","following_url":"https://api.github.com/users/mmerce/following{/other_user}","gists_url":"https://api.github.com/users/mmerce/gists{/gist_id}","starred_url":"https://api.github.com/users/mmerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmerce/subscriptions","organizations_url":"https://api.github.com/users/mmerce/orgs","repos_url":"https://api.github.com/users/mmerce/repos","events_url":"https://api.github.com/users/mmerce/events{/privacy}","received_events_url":"https://api.github.com/users/mmerce/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bigmlcom/python/pulls/203/commits","review_comments_url":"https://api.github.com/repos/bigmlcom/python/pulls/203/comments","review_comment_url":"https://api.github.com/repos/bigmlcom/python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigmlcom/python/issues/203/comments","statuses_url":"https://api.github.com/repos/bigmlcom/python/statuses/a40e752cc7f7cf6446d6d5ef9f3c015ce11258a7","head":{"label":"bigmlcom:not-xamxor","ref":"not-xamxor","sha":"a40e752cc7f7cf6446d6d5ef9f3c015ce11258a7","user":{"login":"bigmlcom","id":702185,"avatar_url":"https://avatars1.githubusercontent.com/u/702185?v=3","gravatar_id":"","url":"https://api.github.com/users/bigmlcom","html_url":"https://github.com/bigmlcom","followers_url":"https://api.github.com/users/bigmlcom/followers","following_url":"https://api.github.com/users/bigmlcom/following{/other_user}","gists_url":"https://api.github.com/users/bigmlcom/gists{/gist_id}","starred_url":"https://api.github.com/users/bigmlcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigmlcom/subscriptions","organizations_url":"https://api.github.com/users/bigmlcom/orgs","repos_url":"https://api.github.com/users/bigmlcom/repos","events_url":"https://api.github.com/users/bigmlcom/events{/privacy}","received_events_url":"https://api.github.com/users/bigmlcom/received_events","type":"Organization","site_admin":false},"repo":{"id":4196332,"name":"python","full_name":"bigmlcom/python","owner":{"login":"bigmlcom","id":702185,"avatar_url":"https://avatars1.githubusercontent.com/u/702185?v=3","gravatar_id":"","url":"https://api.github.com/users/bigmlcom","html_url":"https://github.com/bigmlcom","followers_url":"https://api.github.com/users/bigmlcom/followers","following_url":"https://api.github.com/users/bigmlcom/following{/other_user}","gists_url":"https://api.github.com/users/bigmlcom/gists{/gist_id}","starred_url":"https://api.github.com/users/bigmlcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigmlcom/subscriptions","organizations_url":"https://api.github.com/users/bigmlcom/orgs","repos_url":"https://api.github.com/users/bigmlcom/repos","events_url":"https://api.github.com/users/bigmlcom/events{/privacy}","received_events_url":"https://api.github.com/users/bigmlcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigmlcom/python","description":"Simple Python bindings for BigML.io","fork":false,"url":"https://api.github.com/repos/bigmlcom/python","forks_url":"https://api.github.com/repos/bigmlcom/python/forks","keys_url":"https://api.github.com/repos/bigmlcom/python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigmlcom/python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigmlcom/python/teams","hooks_url":"https://api.github.com/repos/bigmlcom/python/hooks","issue_events_url":"https://api.github.com/repos/bigmlcom/python/issues/events{/number}","events_url":"https://api.github.com/repos/bigmlcom/python/events","assignees_url":"https://api.github.com/repos/bigmlcom/python/assignees{/user}","branches_url":"https://api.github.com/repos/bigmlcom/python/branches{/branch}","tags_url":"https://api.github.com/repos/bigmlcom/python/tags","blobs_url":"https://api.github.com/repos/bigmlcom/python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigmlcom/python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigmlcom/python/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigmlcom/python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigmlcom/python/statuses/{sha}","languages_url":"https://api.github.com/repos/bigmlcom/python/languages","stargazers_url":"https://api.github.com/repos/bigmlcom/python/stargazers","contributors_url":"https://api.github.com/repos/bigmlcom/python/contributors","subscribers_url":"https://api.github.com/repos/bigmlcom/python/subscribers","subscription_url":"https://api.github.com/repos/bigmlcom/python/subscription","commits_url":"https://api.github.com/repos/bigmlcom/python/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigmlcom/python/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigmlcom/python/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigmlcom/python/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigmlcom/python/contents/{+path}","compare_url":"https://api.github.com/repos/bigmlcom/python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigmlcom/python/merges","archive_url":"https://api.github.com/repos/bigmlcom/python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigmlcom/python/downloads","issues_url":"https://api.github.com/repos/bigmlcom/python/issues{/number}","pulls_url":"https://api.github.com/repos/bigmlcom/python/pulls{/number}","milestones_url":"https://api.github.com/repos/bigmlcom/python/milestones{/number}","notifications_url":"https://api.github.com/repos/bigmlcom/python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigmlcom/python/labels{/name}","releases_url":"https://api.github.com/repos/bigmlcom/python/releases{/id}","deployments_url":"https://api.github.com/repos/bigmlcom/python/deployments","created_at":"2012-05-01T20:42:24Z","updated_at":"2017-04-29T06:43:05Z","pushed_at":"2017-05-01T21:42:21Z","git_url":"git://github.com/bigmlcom/python.git","ssh_url":"[email protected]:bigmlcom/python.git","clone_url":"https://github.com/bigmlcom/python.git","svn_url":"https://github.com/bigmlcom/python","homepage":null,"size":3067,"stargazers_count":232,"watchers_count":232,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":1,"forks":99,"open_issues":1,"watchers":232,"default_branch":"master"}},"base":{"label":"bigmlcom:master","ref":"master","sha":"c14ac889d7401e6849e92c15390471fd557d53d5","user":{"login":"bigmlcom","id":702185,"avatar_url":"https://avatars1.githubusercontent.com/u/702185?v=3","gravatar_id":"","url":"https://api.github.com/users/bigmlcom","html_url":"https://github.com/bigmlcom","followers_url":"https://api.github.com/users/bigmlcom/followers","following_url":"https://api.github.com/users/bigmlcom/following{/other_user}","gists_url":"https://api.github.com/users/bigmlcom/gists{/gist_id}","starred_url":"https://api.github.com/users/bigmlcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigmlcom/subscriptions","organizations_url":"https://api.github.com/users/bigmlcom/orgs","repos_url":"https://api.github.com/users/bigmlcom/repos","events_url":"https://api.github.com/users/bigmlcom/events{/privacy}","received_events_url":"https://api.github.com/users/bigmlcom/received_events","type":"Organization","site_admin":false},"repo":{"id":4196332,"name":"python","full_name":"bigmlcom/python","owner":{"login":"bigmlcom","id":702185,"avatar_url":"https://avatars1.githubusercontent.com/u/702185?v=3","gravatar_id":"","url":"https://api.github.com/users/bigmlcom","html_url":"https://github.com/bigmlcom","followers_url":"https://api.github.com/users/bigmlcom/followers","following_url":"https://api.github.com/users/bigmlcom/following{/other_user}","gists_url":"https://api.github.com/users/bigmlcom/gists{/gist_id}","starred_url":"https://api.github.com/users/bigmlcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigmlcom/subscriptions","organizations_url":"https://api.github.com/users/bigmlcom/orgs","repos_url":"https://api.github.com/users/bigmlcom/repos","events_url":"https://api.github.com/users/bigmlcom/events{/privacy}","received_events_url":"https://api.github.com/users/bigmlcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigmlcom/python","description":"Simple Python bindings for BigML.io","fork":false,"url":"https://api.github.com/repos/bigmlcom/python","forks_url":"https://api.github.com/repos/bigmlcom/python/forks","keys_url":"https://api.github.com/repos/bigmlcom/python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigmlcom/python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigmlcom/python/teams","hooks_url":"https://api.github.com/repos/bigmlcom/python/hooks","issue_events_url":"https://api.github.com/repos/bigmlcom/python/issues/events{/number}","events_url":"https://api.github.com/repos/bigmlcom/python/events","assignees_url":"https://api.github.com/repos/bigmlcom/python/assignees{/user}","branches_url":"https://api.github.com/repos/bigmlcom/python/branches{/branch}","tags_url":"https://api.github.com/repos/bigmlcom/python/tags","blobs_url":"https://api.github.com/repos/bigmlcom/python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigmlcom/python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigmlcom/python/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigmlcom/python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigmlcom/python/statuses/{sha}","languages_url":"https://api.github.com/repos/bigmlcom/python/languages","stargazers_url":"https://api.github.com/repos/bigmlcom/python/stargazers","contributors_url":"https://api.github.com/repos/bigmlcom/python/contributors","subscribers_url":"https://api.github.com/repos/bigmlcom/python/subscribers","subscription_url":"https://api.github.com/repos/bigmlcom/python/subscription","commits_url":"https://api.github.com/repos/bigmlcom/python/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigmlcom/python/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigmlcom/python/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigmlcom/python/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigmlcom/python/contents/{+path}","compare_url":"https://api.github.com/repos/bigmlcom/python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigmlcom/python/merges","archive_url":"https://api.github.com/repos/bigmlcom/python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigmlcom/python/downloads","issues_url":"https://api.github.com/repos/bigmlcom/python/issues{/number}","pulls_url":"https://api.github.com/repos/bigmlcom/python/pulls{/number}","milestones_url":"https://api.github.com/repos/bigmlcom/python/milestones{/number}","notifications_url":"https://api.github.com/repos/bigmlcom/python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigmlcom/python/labels{/name}","releases_url":"https://api.github.com/repos/bigmlcom/python/releases{/id}","deployments_url":"https://api.github.com/repos/bigmlcom/python/deployments","created_at":"2012-05-01T20:42:24Z","updated_at":"2017-04-29T06:43:05Z","pushed_at":"2017-05-01T21:42:21Z","git_url":"git://github.com/bigmlcom/python.git","ssh_url":"[email protected]:bigmlcom/python.git","clone_url":"https://github.com/bigmlcom/python.git","svn_url":"https://github.com/bigmlcom/python","homepage":null,"size":3067,"stargazers_count":232,"watchers_count":232,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":1,"forks":99,"open_issues":1,"watchers":232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigmlcom/python/pulls/203"},"html":{"href":"https://github.com/bigmlcom/python/pull/203"},"issue":{"href":"https://api.github.com/repos/bigmlcom/python/issues/203"},"comments":{"href":"https://api.github.com/repos/bigmlcom/python/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/bigmlcom/python/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/bigmlcom/python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigmlcom/python/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/bigmlcom/python/statuses/a40e752cc7f7cf6446d6d5ef9f3c015ce11258a7"}}}} | {
"id": 4196332,
"name": "bigmlcom/python",
"url": "https://api.github.com/repos/bigmlcom/python"
} | {
"id": 722203,
"login": "mmerce",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/722203?",
"url": "https://api.github.com/users/mmerce"
} | {
"id": 702185,
"login": "bigmlcom",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/702185?",
"url": "https://api.github.com/orgs/bigmlcom"
} | 2017-05-02T22:58:56 | 5797798385 | {"actor":{"display_login":"mmerce"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/caicloud/ingress-admin/pulls/comments/96571692","pull_request_review_id":17155242,"id":96571692,"diff_hunk":"@@ -0,0 +1,159 @@\n+package main\n+\n+import (\n+\t\"fmt\"\n+\t\"os\"\n+\t\"reflect\"\n+\t\"sort\"\n+\t\"text/template\"\n+\t\"time\"\n+\n+\t\"k8s.io/client-go/kubernetes\"\n+\t\"k8s.io/kubernetes/pkg/util/exec\"\n+\tmeta_v1 \"k8s.io/apimachinery/pkg/apis/meta/v1\"\n+\t\"k8s.io/kubernetes/pkg/util/wait\"\n+\n+\t\"github.com/golang/glog\"\n+)\n+\n+type keepalivedController struct {\n+\tclientset *kubernetes.Clientset\n+\tkeepalived *keepalived\n+\n+\tnamespace string\n+\tserviceName string\n+\tpodName string\n+\n+\ttemplate *template.Template\n+\tconfig map[string]interface{}\n+}\n+\n+func newKeepalivedController(clientset *kubernetes.Clientset, namespace, serviceName, podName string) (*keepalivedController, error) {\n+\tc := &keepalivedController{\n+\t\tclientset: clientset,\n+\t\tkeepalived: &keepalived{},\n+\n+\t\tnamespace: namespace,\n+\t\tserviceName: serviceName,\n+\t\tpodName: podName,\n+\n+\t\tconfig: make(map[string]interface{}),\n+\t}\n+\n+\ttmpl, err := template.ParseFiles(keepalivedTmpl)\n+\tif err != nil {\n+\t\treturn nil, fmt.Errorf(\"failed to parse keepalived config template due to: %v\", err)\n+\t}\n+\tc.template = tmpl\n+\n+\treturn c, nil\n+}\n+\n+func (c *keepalivedController) Run(period time.Duration, stopCh <-chan struct{}) {\n+\tgo c.keepalived.Start()\n+\n+\tgo wait.Until(func() {\n+\t\tif err := c.Sync(); err != nil {\n+\t\t\tglog.Error(err)\n+\t\t}\n+\t}, period, stopCh)\n+\n+\t<-stopCh\n+}\n+\n+func (c *keepalivedController) Stop() error {\n+\tvip := c.config[\"vip\"]\n+\tiface := c.config[\"iface\"]\n+\n+\tdefer c.keepalived.Stop()\n+\n+\treturn c.removeVIP(iface.(string), vip.(string))","path":"keepalived-vip/controller.go","position":70,"original_position":70,"commit_id":"6d03c95d207a1d7f7e07b7e3a88d2109a40c90ba","original_commit_id":"6d03c95d207a1d7f7e07b7e3a88d2109a40c90ba","user":{"login":"ddysher","id":2191361,"avatar_url":"https://avatars.githubusercontent.com/u/2191361?v=3","gravatar_id":"","url":"https://api.github.com/users/ddysher","html_url":"https://github.com/ddysher","followers_url":"https://api.github.com/users/ddysher/followers","following_url":"https://api.github.com/users/ddysher/following{/other_user}","gists_url":"https://api.github.com/users/ddysher/gists{/gist_id}","starred_url":"https://api.github.com/users/ddysher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddysher/subscriptions","organizations_url":"https://api.github.com/users/ddysher/orgs","repos_url":"https://api.github.com/users/ddysher/repos","events_url":"https://api.github.com/users/ddysher/events{/privacy}","received_events_url":"https://api.github.com/users/ddysher/received_events","type":"User","site_admin":false},"body":"Is it safe to do type assertion here ?","created_at":"2017-01-18T05:59:22Z","updated_at":"2017-01-18T06:01:34Z","html_url":"https://github.com/caicloud/ingress-admin/pull/1#discussion_r96571692","pull_request_url":"https://api.github.com/repos/caicloud/ingress-admin/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/caicloud/ingress-admin/pulls/comments/96571692"},"html":{"href":"https://github.com/caicloud/ingress-admin/pull/1#discussion_r96571692"},"pull_request":{"href":"https://api.github.com/repos/caicloud/ingress-admin/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/caicloud/ingress-admin/pulls/1","id":102001411,"html_url":"https://github.com/caicloud/ingress-admin/pull/1","diff_url":"https://github.com/caicloud/ingress-admin/pull/1.diff","patch_url":"https://github.com/caicloud/ingress-admin/pull/1.patch","issue_url":"https://api.github.com/repos/caicloud/ingress-admin/issues/1","number":1,"state":"open","locked":false,"title":"Keepalived vip side car container","user":{"login":"mqliang","id":12423751,"avatar_url":"https://avatars.githubusercontent.com/u/12423751?v=3","gravatar_id":"","url":"https://api.github.com/users/mqliang","html_url":"https://github.com/mqliang","followers_url":"https://api.github.com/users/mqliang/followers","following_url":"https://api.github.com/users/mqliang/following{/other_user}","gists_url":"https://api.github.com/users/mqliang/gists{/gist_id}","starred_url":"https://api.github.com/users/mqliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqliang/subscriptions","organizations_url":"https://api.github.com/users/mqliang/orgs","repos_url":"https://api.github.com/users/mqliang/repos","events_url":"https://api.github.com/users/mqliang/events{/privacy}","received_events_url":"https://api.github.com/users/mqliang/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-18T05:23:01Z","updated_at":"2017-01-18T06:01:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ac7b04d78218a2100b8dac03c0d74026cd0076b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/caicloud/ingress-admin/pulls/1/commits","review_comments_url":"https://api.github.com/repos/caicloud/ingress-admin/pulls/1/comments","review_comment_url":"https://api.github.com/repos/caicloud/ingress-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caicloud/ingress-admin/issues/1/comments","statuses_url":"https://api.github.com/repos/caicloud/ingress-admin/statuses/6d03c95d207a1d7f7e07b7e3a88d2109a40c90ba","head":{"label":"mqliang:keepalived-vip","ref":"keepalived-vip","sha":"6d03c95d207a1d7f7e07b7e3a88d2109a40c90ba","user":{"login":"mqliang","id":12423751,"avatar_url":"https://avatars.githubusercontent.com/u/12423751?v=3","gravatar_id":"","url":"https://api.github.com/users/mqliang","html_url":"https://github.com/mqliang","followers_url":"https://api.github.com/users/mqliang/followers","following_url":"https://api.github.com/users/mqliang/following{/other_user}","gists_url":"https://api.github.com/users/mqliang/gists{/gist_id}","starred_url":"https://api.github.com/users/mqliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqliang/subscriptions","organizations_url":"https://api.github.com/users/mqliang/orgs","repos_url":"https://api.github.com/users/mqliang/repos","events_url":"https://api.github.com/users/mqliang/events{/privacy}","received_events_url":"https://api.github.com/users/mqliang/received_events","type":"User","site_admin":false},"repo":{"id":79300276,"name":"ingress-admin","full_name":"mqliang/ingress-admin","owner":{"login":"mqliang","id":12423751,"avatar_url":"https://avatars.githubusercontent.com/u/12423751?v=3","gravatar_id":"","url":"https://api.github.com/users/mqliang","html_url":"https://github.com/mqliang","followers_url":"https://api.github.com/users/mqliang/followers","following_url":"https://api.github.com/users/mqliang/following{/other_user}","gists_url":"https://api.github.com/users/mqliang/gists{/gist_id}","starred_url":"https://api.github.com/users/mqliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqliang/subscriptions","organizations_url":"https://api.github.com/users/mqliang/orgs","repos_url":"https://api.github.com/users/mqliang/repos","events_url":"https://api.github.com/users/mqliang/events{/privacy}","received_events_url":"https://api.github.com/users/mqliang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mqliang/ingress-admin","description":"Kubernetes ingress resource, claim and administration","fork":true,"url":"https://api.github.com/repos/mqliang/ingress-admin","forks_url":"https://api.github.com/repos/mqliang/ingress-admin/forks","keys_url":"https://api.github.com/repos/mqliang/ingress-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mqliang/ingress-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mqliang/ingress-admin/teams","hooks_url":"https://api.github.com/repos/mqliang/ingress-admin/hooks","issue_events_url":"https://api.github.com/repos/mqliang/ingress-admin/issues/events{/number}","events_url":"https://api.github.com/repos/mqliang/ingress-admin/events","assignees_url":"https://api.github.com/repos/mqliang/ingress-admin/assignees{/user}","branches_url":"https://api.github.com/repos/mqliang/ingress-admin/branches{/branch}","tags_url":"https://api.github.com/repos/mqliang/ingress-admin/tags","blobs_url":"https://api.github.com/repos/mqliang/ingress-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mqliang/ingress-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mqliang/ingress-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mqliang/ingress-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mqliang/ingress-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/mqliang/ingress-admin/languages","stargazers_url":"https://api.github.com/repos/mqliang/ingress-admin/stargazers","contributors_url":"https://api.github.com/repos/mqliang/ingress-admin/contributors","subscribers_url":"https://api.github.com/repos/mqliang/ingress-admin/subscribers","subscription_url":"https://api.github.com/repos/mqliang/ingress-admin/subscription","commits_url":"https://api.github.com/repos/mqliang/ingress-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mqliang/ingress-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mqliang/ingress-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mqliang/ingress-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mqliang/ingress-admin/contents/{+path}","compare_url":"https://api.github.com/repos/mqliang/ingress-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mqliang/ingress-admin/merges","archive_url":"https://api.github.com/repos/mqliang/ingress-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mqliang/ingress-admin/downloads","issues_url":"https://api.github.com/repos/mqliang/ingress-admin/issues{/number}","pulls_url":"https://api.github.com/repos/mqliang/ingress-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/mqliang/ingress-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/mqliang/ingress-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mqliang/ingress-admin/labels{/name}","releases_url":"https://api.github.com/repos/mqliang/ingress-admin/releases{/id}","deployments_url":"https://api.github.com/repos/mqliang/ingress-admin/deployments","created_at":"2017-01-18T03:39:09Z","updated_at":"2017-01-18T02:18:37Z","pushed_at":"2017-01-18T05:31:10Z","git_url":"git://github.com/mqliang/ingress-admin.git","ssh_url":"[email protected]:mqliang/ingress-admin.git","clone_url":"https://github.com/mqliang/ingress-admin.git","svn_url":"https://github.com/mqliang/ingress-admin","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"caicloud:master","ref":"master","sha":"60e05f403a397d8f630f50e672cd68d92b85700f","user":{"login":"caicloud","id":12522124,"avatar_url":"https://avatars.githubusercontent.com/u/12522124?v=3","gravatar_id":"","url":"https://api.github.com/users/caicloud","html_url":"https://github.com/caicloud","followers_url":"https://api.github.com/users/caicloud/followers","following_url":"https://api.github.com/users/caicloud/following{/other_user}","gists_url":"https://api.github.com/users/caicloud/gists{/gist_id}","starred_url":"https://api.github.com/users/caicloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caicloud/subscriptions","organizations_url":"https://api.github.com/users/caicloud/orgs","repos_url":"https://api.github.com/users/caicloud/repos","events_url":"https://api.github.com/users/caicloud/events{/privacy}","received_events_url":"https://api.github.com/users/caicloud/received_events","type":"Organization","site_admin":false},"repo":{"id":79294383,"name":"ingress-admin","full_name":"caicloud/ingress-admin","owner":{"login":"caicloud","id":12522124,"avatar_url":"https://avatars.githubusercontent.com/u/12522124?v=3","gravatar_id":"","url":"https://api.github.com/users/caicloud","html_url":"https://github.com/caicloud","followers_url":"https://api.github.com/users/caicloud/followers","following_url":"https://api.github.com/users/caicloud/following{/other_user}","gists_url":"https://api.github.com/users/caicloud/gists{/gist_id}","starred_url":"https://api.github.com/users/caicloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caicloud/subscriptions","organizations_url":"https://api.github.com/users/caicloud/orgs","repos_url":"https://api.github.com/users/caicloud/repos","events_url":"https://api.github.com/users/caicloud/events{/privacy}","received_events_url":"https://api.github.com/users/caicloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caicloud/ingress-admin","description":"Kubernetes ingress resource, claim and administration","fork":false,"url":"https://api.github.com/repos/caicloud/ingress-admin","forks_url":"https://api.github.com/repos/caicloud/ingress-admin/forks","keys_url":"https://api.github.com/repos/caicloud/ingress-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caicloud/ingress-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caicloud/ingress-admin/teams","hooks_url":"https://api.github.com/repos/caicloud/ingress-admin/hooks","issue_events_url":"https://api.github.com/repos/caicloud/ingress-admin/issues/events{/number}","events_url":"https://api.github.com/repos/caicloud/ingress-admin/events","assignees_url":"https://api.github.com/repos/caicloud/ingress-admin/assignees{/user}","branches_url":"https://api.github.com/repos/caicloud/ingress-admin/branches{/branch}","tags_url":"https://api.github.com/repos/caicloud/ingress-admin/tags","blobs_url":"https://api.github.com/repos/caicloud/ingress-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caicloud/ingress-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caicloud/ingress-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/caicloud/ingress-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caicloud/ingress-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/caicloud/ingress-admin/languages","stargazers_url":"https://api.github.com/repos/caicloud/ingress-admin/stargazers","contributors_url":"https://api.github.com/repos/caicloud/ingress-admin/contributors","subscribers_url":"https://api.github.com/repos/caicloud/ingress-admin/subscribers","subscription_url":"https://api.github.com/repos/caicloud/ingress-admin/subscription","commits_url":"https://api.github.com/repos/caicloud/ingress-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/caicloud/ingress-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/caicloud/ingress-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/caicloud/ingress-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/caicloud/ingress-admin/contents/{+path}","compare_url":"https://api.github.com/repos/caicloud/ingress-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caicloud/ingress-admin/merges","archive_url":"https://api.github.com/repos/caicloud/ingress-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caicloud/ingress-admin/downloads","issues_url":"https://api.github.com/repos/caicloud/ingress-admin/issues{/number}","pulls_url":"https://api.github.com/repos/caicloud/ingress-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/caicloud/ingress-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/caicloud/ingress-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caicloud/ingress-admin/labels{/name}","releases_url":"https://api.github.com/repos/caicloud/ingress-admin/releases{/id}","deployments_url":"https://api.github.com/repos/caicloud/ingress-admin/deployments","created_at":"2017-01-18T02:18:37Z","updated_at":"2017-01-18T02:18:37Z","pushed_at":"2017-01-18T05:31:10Z","git_url":"git://github.com/caicloud/ingress-admin.git","ssh_url":"[email protected]:caicloud/ingress-admin.git","clone_url":"https://github.com/caicloud/ingress-admin.git","svn_url":"https://github.com/caicloud/ingress-admin","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caicloud/ingress-admin/pulls/1"},"html":{"href":"https://github.com/caicloud/ingress-admin/pull/1"},"issue":{"href":"https://api.github.com/repos/caicloud/ingress-admin/issues/1"},"comments":{"href":"https://api.github.com/repos/caicloud/ingress-admin/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/caicloud/ingress-admin/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/caicloud/ingress-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caicloud/ingress-admin/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/caicloud/ingress-admin/statuses/6d03c95d207a1d7f7e07b7e3a88d2109a40c90ba"}}}} | {
"id": 79294383,
"name": "caicloud/ingress-admin",
"url": "https://api.github.com/repos/caicloud/ingress-admin"
} | {
"id": 2191361,
"login": "ddysher",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2191361?",
"url": "https://api.github.com/users/ddysher"
} | {
"id": 12522124,
"login": "caicloud",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12522124?",
"url": "https://api.github.com/orgs/caicloud"
} | 2017-01-18T05:59:22 | 5170415427 | {"actor":{"display_login":"ddysher"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/comments/149441132","pull_request_review_id":74834152,"id":149441132,"diff_hunk":"@@ -66,7 +67,12 @@ def _get_containerid_from_pid(self, pid):\n cont_pid = int(state['Pid'])\n cont_child_pids = self._get_children_pids(cont_pid)\n if pid in cont_child_pids:\n- return inspect['Name']\n+ labels = inspect['Config']['Labels']\n+ pod_ns = labels.get('io.kubernetes.pod.namespace', 'NA')\n+ pod_name = labels.get('io.kubernetes.pod.name', 'NA')\n+ training_id = labels.get('training_id', pod_name)\n+ name = \"{}.{}\".format(pod_ns, training_id)\n+ return name","path":"crawler/plugins/systems/gpu_host_crawler.py","position":null,"original_position":18,"commit_id":"bfec6937b69cc06680273b4dba163fe06ae83f98","original_commit_id":"b88363d78975904224f262673c64512a02cfceb9","user":{"login":"sahilsuneja1","id":6835847,"avatar_url":"https://avatars0.githubusercontent.com/u/6835847?v=4","gravatar_id":"","url":"https://api.github.com/users/sahilsuneja1","html_url":"https://github.com/sahilsuneja1","followers_url":"https://api.github.com/users/sahilsuneja1/followers","following_url":"https://api.github.com/users/sahilsuneja1/following{/other_user}","gists_url":"https://api.github.com/users/sahilsuneja1/gists{/gist_id}","starred_url":"https://api.github.com/users/sahilsuneja1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahilsuneja1/subscriptions","organizations_url":"https://api.github.com/users/sahilsuneja1/orgs","repos_url":"https://api.github.com/users/sahilsuneja1/repos","events_url":"https://api.github.com/users/sahilsuneja1/events{/privacy}","received_events_url":"https://api.github.com/users/sahilsuneja1/received_events","type":"User","site_admin":false},"body":"Thanks!\r\n","created_at":"2017-11-07T17:14:46Z","updated_at":"2017-11-07T17:14:46Z","html_url":"https://github.com/cloudviz/agentless-system-crawler/pull/344#discussion_r149441132","pull_request_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/344","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/comments/149441132"},"html":{"href":"https://github.com/cloudviz/agentless-system-crawler/pull/344#discussion_r149441132"},"pull_request":{"href":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/344"}},"in_reply_to_id":149379475},"pull_request":{"url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/344","id":150926289,"html_url":"https://github.com/cloudviz/agentless-system-crawler/pull/344","diff_url":"https://github.com/cloudviz/agentless-system-crawler/pull/344.diff","patch_url":"https://github.com/cloudviz/agentless-system-crawler/pull/344.patch","issue_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/issues/344","number":344,"state":"open","locked":false,"title":"Dlaas metric metadata changes","user":{"login":"nadgowdas","id":8685412,"avatar_url":"https://avatars3.githubusercontent.com/u/8685412?v=4","gravatar_id":"","url":"https://api.github.com/users/nadgowdas","html_url":"https://github.com/nadgowdas","followers_url":"https://api.github.com/users/nadgowdas/followers","following_url":"https://api.github.com/users/nadgowdas/following{/other_user}","gists_url":"https://api.github.com/users/nadgowdas/gists{/gist_id}","starred_url":"https://api.github.com/users/nadgowdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadgowdas/subscriptions","organizations_url":"https://api.github.com/users/nadgowdas/orgs","repos_url":"https://api.github.com/users/nadgowdas/repos","events_url":"https://api.github.com/users/nadgowdas/events{/privacy}","received_events_url":"https://api.github.com/users/nadgowdas/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Shripad Nadgowda <[email protected]>\r\n\r\nChanges include:\r\n1. Remove \"containerid\" string from metric name\r\n2. Add only k8s-namespace and training-id or pod-name in the metric name\r\n\r\n","created_at":"2017-11-06T18:32:23Z","updated_at":"2017-11-07T17:14:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9a09dcd94300ec0b912b1e030ce775e1bf16895","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/344/commits","review_comments_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/344/comments","review_comment_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/issues/344/comments","statuses_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/statuses/bfec6937b69cc06680273b4dba163fe06ae83f98","head":{"label":"nadgowdas:dlaas","ref":"dlaas","sha":"bfec6937b69cc06680273b4dba163fe06ae83f98","user":{"login":"nadgowdas","id":8685412,"avatar_url":"https://avatars3.githubusercontent.com/u/8685412?v=4","gravatar_id":"","url":"https://api.github.com/users/nadgowdas","html_url":"https://github.com/nadgowdas","followers_url":"https://api.github.com/users/nadgowdas/followers","following_url":"https://api.github.com/users/nadgowdas/following{/other_user}","gists_url":"https://api.github.com/users/nadgowdas/gists{/gist_id}","starred_url":"https://api.github.com/users/nadgowdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadgowdas/subscriptions","organizations_url":"https://api.github.com/users/nadgowdas/orgs","repos_url":"https://api.github.com/users/nadgowdas/repos","events_url":"https://api.github.com/users/nadgowdas/events{/privacy}","received_events_url":"https://api.github.com/users/nadgowdas/received_events","type":"User","site_admin":false},"repo":{"id":88876776,"name":"agentless-system-crawler","full_name":"nadgowdas/agentless-system-crawler","owner":{"login":"nadgowdas","id":8685412,"avatar_url":"https://avatars3.githubusercontent.com/u/8685412?v=4","gravatar_id":"","url":"https://api.github.com/users/nadgowdas","html_url":"https://github.com/nadgowdas","followers_url":"https://api.github.com/users/nadgowdas/followers","following_url":"https://api.github.com/users/nadgowdas/following{/other_user}","gists_url":"https://api.github.com/users/nadgowdas/gists{/gist_id}","starred_url":"https://api.github.com/users/nadgowdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadgowdas/subscriptions","organizations_url":"https://api.github.com/users/nadgowdas/orgs","repos_url":"https://api.github.com/users/nadgowdas/repos","events_url":"https://api.github.com/users/nadgowdas/events{/privacy}","received_events_url":"https://api.github.com/users/nadgowdas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nadgowdas/agentless-system-crawler","description":"A tool to crawl systems like crawlers for the web","fork":true,"url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler","forks_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/forks","keys_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/teams","hooks_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/hooks","issue_events_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/issues/events{/number}","events_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/events","assignees_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/assignees{/user}","branches_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/branches{/branch}","tags_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/tags","blobs_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/git/refs{/sha}","trees_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/statuses/{sha}","languages_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/languages","stargazers_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/stargazers","contributors_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/contributors","subscribers_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/subscribers","subscription_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/subscription","commits_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/commits{/sha}","git_commits_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/git/commits{/sha}","comments_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/comments{/number}","issue_comment_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/issues/comments{/number}","contents_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/contents/{+path}","compare_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/merges","archive_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/downloads","issues_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/issues{/number}","pulls_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/pulls{/number}","milestones_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/milestones{/number}","notifications_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/labels{/name}","releases_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/releases{/id}","deployments_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/deployments","created_at":"2017-04-20T14:43:59Z","updated_at":"2017-07-26T15:00:03Z","pushed_at":"2017-11-07T16:50:43Z","git_url":"git://github.com/nadgowdas/agentless-system-crawler.git","ssh_url":"[email protected]:nadgowdas/agentless-system-crawler.git","clone_url":"https://github.com/nadgowdas/agentless-system-crawler.git","svn_url":"https://github.com/nadgowdas/agentless-system-crawler","homepage":"","size":2079,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudviz:master","ref":"master","sha":"c2f02849437d7382a25ee24deffd8eb0034f4dab","user":{"login":"cloudviz","id":13337905,"avatar_url":"https://avatars2.githubusercontent.com/u/13337905?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudviz","html_url":"https://github.com/cloudviz","followers_url":"https://api.github.com/users/cloudviz/followers","following_url":"https://api.github.com/users/cloudviz/following{/other_user}","gists_url":"https://api.github.com/users/cloudviz/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudviz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudviz/subscriptions","organizations_url":"https://api.github.com/users/cloudviz/orgs","repos_url":"https://api.github.com/users/cloudviz/repos","events_url":"https://api.github.com/users/cloudviz/events{/privacy}","received_events_url":"https://api.github.com/users/cloudviz/received_events","type":"Organization","site_admin":false},"repo":{"id":39209164,"name":"agentless-system-crawler","full_name":"cloudviz/agentless-system-crawler","owner":{"login":"cloudviz","id":13337905,"avatar_url":"https://avatars2.githubusercontent.com/u/13337905?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudviz","html_url":"https://github.com/cloudviz","followers_url":"https://api.github.com/users/cloudviz/followers","following_url":"https://api.github.com/users/cloudviz/following{/other_user}","gists_url":"https://api.github.com/users/cloudviz/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudviz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudviz/subscriptions","organizations_url":"https://api.github.com/users/cloudviz/orgs","repos_url":"https://api.github.com/users/cloudviz/repos","events_url":"https://api.github.com/users/cloudviz/events{/privacy}","received_events_url":"https://api.github.com/users/cloudviz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudviz/agentless-system-crawler","description":"A tool to crawl systems like crawlers for the web","fork":false,"url":"https://api.github.com/repos/cloudviz/agentless-system-crawler","forks_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/forks","keys_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/teams","hooks_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/hooks","issue_events_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/issues/events{/number}","events_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/events","assignees_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/assignees{/user}","branches_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/branches{/branch}","tags_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/tags","blobs_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/languages","stargazers_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/stargazers","contributors_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/contributors","subscribers_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/subscribers","subscription_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/subscription","commits_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/contents/{+path}","compare_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/merges","archive_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/downloads","issues_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/issues{/number}","pulls_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/labels{/name}","releases_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/releases{/id}","deployments_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/deployments","created_at":"2015-07-16T16:51:58Z","updated_at":"2017-11-03T20:08:44Z","pushed_at":"2017-11-07T16:50:45Z","git_url":"git://github.com/cloudviz/agentless-system-crawler.git","ssh_url":"[email protected]:cloudviz/agentless-system-crawler.git","clone_url":"https://github.com/cloudviz/agentless-system-crawler.git","svn_url":"https://github.com/cloudviz/agentless-system-crawler","homepage":"","size":2081,"stargazers_count":65,"watchers_count":65,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":41,"forks":36,"open_issues":41,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/344"},"html":{"href":"https://github.com/cloudviz/agentless-system-crawler/pull/344"},"issue":{"href":"https://api.github.com/repos/cloudviz/agentless-system-crawler/issues/344"},"comments":{"href":"https://api.github.com/repos/cloudviz/agentless-system-crawler/issues/344/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/344/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/344/commits"},"statuses":{"href":"https://api.github.com/repos/cloudviz/agentless-system-crawler/statuses/bfec6937b69cc06680273b4dba163fe06ae83f98"}},"author_association":"CONTRIBUTOR"}} | {
"id": 39209164,
"name": "cloudviz/agentless-system-crawler",
"url": "https://api.github.com/repos/cloudviz/agentless-system-crawler"
} | {
"id": 6835847,
"login": "sahilsuneja1",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6835847?",
"url": "https://api.github.com/users/sahilsuneja1"
} | {
"id": 13337905,
"login": "cloudviz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13337905?",
"url": "https://api.github.com/orgs/cloudviz"
} | 2017-11-07T17:14:46 | 6821605359 | {"actor":{"display_login":"sahilsuneja1"}} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.