type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
334k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cloudwan/gohan/pulls/comments/102024960","pull_request_review_id":22767690,"id":102024960,"diff_hunk":"@@ -107,6 +107,29 @@ func (_m *Transaction) Fetch(_a0 *schema.Schema, _a1 transaction.Filter) (*schem\n \treturn r0, r1\n }\n \n+// LockFetch mock\n+func (_m *Transaction) LockFetch(_a0 *schema.Schema, _a1 transaction.Filter) (*schema.Resource, error) {","path":"db/transaction/mocks/Transaction.go","position":5,"original_position":5,"commit_id":"b74e54faeea2d855d2a2049820d4855ae1844236","original_commit_id":"b74e54faeea2d855d2a2049820d4855ae1844236","user":{"login":"p-kozlowski","id":6004891,"avatar_url":"https://avatars.githubusercontent.com/u/6004891?v=3","gravatar_id":"","url":"https://api.github.com/users/p-kozlowski","html_url":"https://github.com/p-kozlowski","followers_url":"https://api.github.com/users/p-kozlowski/followers","following_url":"https://api.github.com/users/p-kozlowski/following{/other_user}","gists_url":"https://api.github.com/users/p-kozlowski/gists{/gist_id}","starred_url":"https://api.github.com/users/p-kozlowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-kozlowski/subscriptions","organizations_url":"https://api.github.com/users/p-kozlowski/orgs","repos_url":"https://api.github.com/users/p-kozlowski/repos","events_url":"https://api.github.com/users/p-kozlowski/events{/privacy}","received_events_url":"https://api.github.com/users/p-kozlowski/received_events","type":"User","site_admin":false},"body":"sort of auto generated (have a look at whole file). BTW @mmatczuk would probably not agree about the naming ;)","created_at":"2017-02-20T14:09:50Z","updated_at":"2017-02-20T14:09:50Z","html_url":"https://github.com/cloudwan/gohan/pull/389#discussion_r102024960","pull_request_url":"https://api.github.com/repos/cloudwan/gohan/pulls/389","_links":{"self":{"href":"https://api.github.com/repos/cloudwan/gohan/pulls/comments/102024960"},"html":{"href":"https://github.com/cloudwan/gohan/pull/389#discussion_r102024960"},"pull_request":{"href":"https://api.github.com/repos/cloudwan/gohan/pulls/389"}}},"pull_request":{"url":"https://api.github.com/repos/cloudwan/gohan/pulls/389","id":106998870,"html_url":"https://github.com/cloudwan/gohan/pull/389","diff_url":"https://github.com/cloudwan/gohan/pull/389.diff","patch_url":"https://github.com/cloudwan/gohan/pull/389.patch","issue_url":"https://api.github.com/repos/cloudwan/gohan/issues/389","number":389,"state":"open","locked":false,"title":"Allow executing SELECT ... FOR UPDATE type queries","user":{"login":"p-kozlowski","id":6004891,"avatar_url":"https://avatars.githubusercontent.com/u/6004891?v=3","gravatar_id":"","url":"https://api.github.com/users/p-kozlowski","html_url":"https://github.com/p-kozlowski","followers_url":"https://api.github.com/users/p-kozlowski/followers","following_url":"https://api.github.com/users/p-kozlowski/following{/other_user}","gists_url":"https://api.github.com/users/p-kozlowski/gists{/gist_id}","starred_url":"https://api.github.com/users/p-kozlowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-kozlowski/subscriptions","organizations_url":"https://api.github.com/users/p-kozlowski/orgs","repos_url":"https://api.github.com/users/p-kozlowski/repos","events_url":"https://api.github.com/users/p-kozlowski/events{/privacy}","received_events_url":"https://api.github.com/users/p-kozlowski/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-20T12:46:09Z","updated_at":"2017-02-20T14:09:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3342867c789d47d2934925b82e5e4267ea7ae529","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudwan/gohan/pulls/389/commits","review_comments_url":"https://api.github.com/repos/cloudwan/gohan/pulls/389/comments","review_comment_url":"https://api.github.com/repos/cloudwan/gohan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudwan/gohan/issues/389/comments","statuses_url":"https://api.github.com/repos/cloudwan/gohan/statuses/b74e54faeea2d855d2a2049820d4855ae1844236","head":{"label":"p-kozlowski:lock-for-update","ref":"lock-for-update","sha":"b74e54faeea2d855d2a2049820d4855ae1844236","user":{"login":"p-kozlowski","id":6004891,"avatar_url":"https://avatars.githubusercontent.com/u/6004891?v=3","gravatar_id":"","url":"https://api.github.com/users/p-kozlowski","html_url":"https://github.com/p-kozlowski","followers_url":"https://api.github.com/users/p-kozlowski/followers","following_url":"https://api.github.com/users/p-kozlowski/following{/other_user}","gists_url":"https://api.github.com/users/p-kozlowski/gists{/gist_id}","starred_url":"https://api.github.com/users/p-kozlowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-kozlowski/subscriptions","organizations_url":"https://api.github.com/users/p-kozlowski/orgs","repos_url":"https://api.github.com/users/p-kozlowski/repos","events_url":"https://api.github.com/users/p-kozlowski/events{/privacy}","received_events_url":"https://api.github.com/users/p-kozlowski/received_events","type":"User","site_admin":false},"repo":{"id":70707745,"name":"gohan","full_name":"p-kozlowski/gohan","owner":{"login":"p-kozlowski","id":6004891,"avatar_url":"https://avatars.githubusercontent.com/u/6004891?v=3","gravatar_id":"","url":"https://api.github.com/users/p-kozlowski","html_url":"https://github.com/p-kozlowski","followers_url":"https://api.github.com/users/p-kozlowski/followers","following_url":"https://api.github.com/users/p-kozlowski/following{/other_user}","gists_url":"https://api.github.com/users/p-kozlowski/gists{/gist_id}","starred_url":"https://api.github.com/users/p-kozlowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-kozlowski/subscriptions","organizations_url":"https://api.github.com/users/p-kozlowski/orgs","repos_url":"https://api.github.com/users/p-kozlowski/repos","events_url":"https://api.github.com/users/p-kozlowski/events{/privacy}","received_events_url":"https://api.github.com/users/p-kozlowski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/p-kozlowski/gohan","description":"Gohan is an API Gateway Server written by Go that makes it easy for developers to create and maintain REST-style APIGohan is an API Gateway Server written by Go that makes it easy for developers to create and maintain REST-style API","fork":true,"url":"https://api.github.com/repos/p-kozlowski/gohan","forks_url":"https://api.github.com/repos/p-kozlowski/gohan/forks","keys_url":"https://api.github.com/repos/p-kozlowski/gohan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p-kozlowski/gohan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p-kozlowski/gohan/teams","hooks_url":"https://api.github.com/repos/p-kozlowski/gohan/hooks","issue_events_url":"https://api.github.com/repos/p-kozlowski/gohan/issues/events{/number}","events_url":"https://api.github.com/repos/p-kozlowski/gohan/events","assignees_url":"https://api.github.com/repos/p-kozlowski/gohan/assignees{/user}","branches_url":"https://api.github.com/repos/p-kozlowski/gohan/branches{/branch}","tags_url":"https://api.github.com/repos/p-kozlowski/gohan/tags","blobs_url":"https://api.github.com/repos/p-kozlowski/gohan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p-kozlowski/gohan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p-kozlowski/gohan/git/refs{/sha}","trees_url":"https://api.github.com/repos/p-kozlowski/gohan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p-kozlowski/gohan/statuses/{sha}","languages_url":"https://api.github.com/repos/p-kozlowski/gohan/languages","stargazers_url":"https://api.github.com/repos/p-kozlowski/gohan/stargazers","contributors_url":"https://api.github.com/repos/p-kozlowski/gohan/contributors","subscribers_url":"https://api.github.com/repos/p-kozlowski/gohan/subscribers","subscription_url":"https://api.github.com/repos/p-kozlowski/gohan/subscription","commits_url":"https://api.github.com/repos/p-kozlowski/gohan/commits{/sha}","git_commits_url":"https://api.github.com/repos/p-kozlowski/gohan/git/commits{/sha}","comments_url":"https://api.github.com/repos/p-kozlowski/gohan/comments{/number}","issue_comment_url":"https://api.github.com/repos/p-kozlowski/gohan/issues/comments{/number}","contents_url":"https://api.github.com/repos/p-kozlowski/gohan/contents/{+path}","compare_url":"https://api.github.com/repos/p-kozlowski/gohan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p-kozlowski/gohan/merges","archive_url":"https://api.github.com/repos/p-kozlowski/gohan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p-kozlowski/gohan/downloads","issues_url":"https://api.github.com/repos/p-kozlowski/gohan/issues{/number}","pulls_url":"https://api.github.com/repos/p-kozlowski/gohan/pulls{/number}","milestones_url":"https://api.github.com/repos/p-kozlowski/gohan/milestones{/number}","notifications_url":"https://api.github.com/repos/p-kozlowski/gohan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p-kozlowski/gohan/labels{/name}","releases_url":"https://api.github.com/repos/p-kozlowski/gohan/releases{/id}","deployments_url":"https://api.github.com/repos/p-kozlowski/gohan/deployments","created_at":"2016-10-12T14:25:13Z","updated_at":"2016-10-12T14:25:14Z","pushed_at":"2017-02-20T12:38:20Z","git_url":"git://github.com/p-kozlowski/gohan.git","ssh_url":"[email protected]:p-kozlowski/gohan.git","clone_url":"https://github.com/p-kozlowski/gohan.git","svn_url":"https://github.com/p-kozlowski/gohan","homepage":"http://www.slideshare.net/natiueno/gohan-61170476","size":18311,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudwan:master","ref":"master","sha":"dbd6ec734dcc3cbee1f2dca77ba7813b80f96025","user":{"login":"cloudwan","id":13223939,"avatar_url":"https://avatars.githubusercontent.com/u/13223939?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudwan","html_url":"https://github.com/cloudwan","followers_url":"https://api.github.com/users/cloudwan/followers","following_url":"https://api.github.com/users/cloudwan/following{/other_user}","gists_url":"https://api.github.com/users/cloudwan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudwan/subscriptions","organizations_url":"https://api.github.com/users/cloudwan/orgs","repos_url":"https://api.github.com/users/cloudwan/repos","events_url":"https://api.github.com/users/cloudwan/events{/privacy}","received_events_url":"https://api.github.com/users/cloudwan/received_events","type":"Organization","site_admin":false},"repo":{"id":43838360,"name":"gohan","full_name":"cloudwan/gohan","owner":{"login":"cloudwan","id":13223939,"avatar_url":"https://avatars.githubusercontent.com/u/13223939?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudwan","html_url":"https://github.com/cloudwan","followers_url":"https://api.github.com/users/cloudwan/followers","following_url":"https://api.github.com/users/cloudwan/following{/other_user}","gists_url":"https://api.github.com/users/cloudwan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudwan/subscriptions","organizations_url":"https://api.github.com/users/cloudwan/orgs","repos_url":"https://api.github.com/users/cloudwan/repos","events_url":"https://api.github.com/users/cloudwan/events{/privacy}","received_events_url":"https://api.github.com/users/cloudwan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudwan/gohan","description":"Gohan is an API Gateway Server written by Go that makes it easy for developers to create and maintain REST-style API","fork":false,"url":"https://api.github.com/repos/cloudwan/gohan","forks_url":"https://api.github.com/repos/cloudwan/gohan/forks","keys_url":"https://api.github.com/repos/cloudwan/gohan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudwan/gohan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudwan/gohan/teams","hooks_url":"https://api.github.com/repos/cloudwan/gohan/hooks","issue_events_url":"https://api.github.com/repos/cloudwan/gohan/issues/events{/number}","events_url":"https://api.github.com/repos/cloudwan/gohan/events","assignees_url":"https://api.github.com/repos/cloudwan/gohan/assignees{/user}","branches_url":"https://api.github.com/repos/cloudwan/gohan/branches{/branch}","tags_url":"https://api.github.com/repos/cloudwan/gohan/tags","blobs_url":"https://api.github.com/repos/cloudwan/gohan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudwan/gohan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudwan/gohan/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudwan/gohan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudwan/gohan/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudwan/gohan/languages","stargazers_url":"https://api.github.com/repos/cloudwan/gohan/stargazers","contributors_url":"https://api.github.com/repos/cloudwan/gohan/contributors","subscribers_url":"https://api.github.com/repos/cloudwan/gohan/subscribers","subscription_url":"https://api.github.com/repos/cloudwan/gohan/subscription","commits_url":"https://api.github.com/repos/cloudwan/gohan/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudwan/gohan/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudwan/gohan/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudwan/gohan/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudwan/gohan/contents/{+path}","compare_url":"https://api.github.com/repos/cloudwan/gohan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudwan/gohan/merges","archive_url":"https://api.github.com/repos/cloudwan/gohan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudwan/gohan/downloads","issues_url":"https://api.github.com/repos/cloudwan/gohan/issues{/number}","pulls_url":"https://api.github.com/repos/cloudwan/gohan/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudwan/gohan/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudwan/gohan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudwan/gohan/labels{/name}","releases_url":"https://api.github.com/repos/cloudwan/gohan/releases{/id}","deployments_url":"https://api.github.com/repos/cloudwan/gohan/deployments","created_at":"2015-10-07T19:01:47Z","updated_at":"2017-02-20T10:12:44Z","pushed_at":"2017-02-20T13:12:27Z","git_url":"git://github.com/cloudwan/gohan.git","ssh_url":"[email protected]:cloudwan/gohan.git","clone_url":"https://github.com/cloudwan/gohan.git","svn_url":"https://github.com/cloudwan/gohan","homepage":"http://www.slideshare.net/natiueno/gohan-61170476","size":18298,"stargazers_count":76,"watchers_count":76,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":36,"mirror_url":null,"open_issues_count":52,"forks":36,"open_issues":52,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudwan/gohan/pulls/389"},"html":{"href":"https://github.com/cloudwan/gohan/pull/389"},"issue":{"href":"https://api.github.com/repos/cloudwan/gohan/issues/389"},"comments":{"href":"https://api.github.com/repos/cloudwan/gohan/issues/389/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudwan/gohan/pulls/389/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudwan/gohan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudwan/gohan/pulls/389/commits"},"statuses":{"href":"https://api.github.com/repos/cloudwan/gohan/statuses/b74e54faeea2d855d2a2049820d4855ae1844236"}}}} | {
"id": 43838360,
"name": "cloudwan/gohan",
"url": "https://api.github.com/repos/cloudwan/gohan"
} | {
"id": 6004891,
"login": "p-kozlowski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6004891?",
"url": "https://api.github.com/users/p-kozlowski"
} | {
"id": 13223939,
"login": "cloudwan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13223939?",
"url": "https://api.github.com/orgs/cloudwan"
} | 2017-02-20T14:09:50 | 5355842385 | {"actor":{"display_login":"p-kozlowski"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cp3-llbb/Datasets/pulls/comments/141347753","pull_request_review_id":65547302,"id":141347753,"diff_hunk":"@@ -0,0 +1,11 @@\n+{\n+ \"name\": \"HtoZAAnalysis\",\n+ \"configuration\": \"cp3_llbb/ZAAnalysis/test/HtoZAConfiguration.py\",\n+ \"splitting\": \"relative:1\",\n+ \"samples\": {\n+ \"mc\": [\n+ \"HToZA\", \"DY_NLO\", \"DY_NLO_NJetsBins\", \"TT_powheg_inclusive\", \"ZZ\"","path":"analyses/HtoZA.json","position":7,"original_position":7,"commit_id":"ba8c8c93d878b5db7328d1db60058092349b56e1","original_commit_id":"ba8c8c93d878b5db7328d1db60058092349b56e1","user":{"login":"OlivierBondu","id":2760084,"avatar_url":"https://avatars0.githubusercontent.com/u/2760084?v=4","gravatar_id":"","url":"https://api.github.com/users/OlivierBondu","html_url":"https://github.com/OlivierBondu","followers_url":"https://api.github.com/users/OlivierBondu/followers","following_url":"https://api.github.com/users/OlivierBondu/following{/other_user}","gists_url":"https://api.github.com/users/OlivierBondu/gists{/gist_id}","starred_url":"https://api.github.com/users/OlivierBondu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlivierBondu/subscriptions","organizations_url":"https://api.github.com/users/OlivierBondu/orgs","repos_url":"https://api.github.com/users/OlivierBondu/repos","events_url":"https://api.github.com/users/OlivierBondu/events{/privacy}","received_events_url":"https://api.github.com/users/OlivierBondu/received_events","type":"User","site_admin":false},"body":"would you mind adding at least ZH and single top ?","created_at":"2017-09-27T13:48:28Z","updated_at":"2017-09-27T13:48:43Z","html_url":"https://github.com/cp3-llbb/Datasets/pull/50#discussion_r141347753","pull_request_url":"https://api.github.com/repos/cp3-llbb/Datasets/pulls/50","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/cp3-llbb/Datasets/pulls/comments/141347753"},"html":{"href":"https://github.com/cp3-llbb/Datasets/pull/50#discussion_r141347753"},"pull_request":{"href":"https://api.github.com/repos/cp3-llbb/Datasets/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/cp3-llbb/Datasets/pulls/50","id":143394265,"html_url":"https://github.com/cp3-llbb/Datasets/pull/50","diff_url":"https://github.com/cp3-llbb/Datasets/pull/50.diff","patch_url":"https://github.com/cp3-llbb/Datasets/pull/50.patch","issue_url":"https://api.github.com/repos/cp3-llbb/Datasets/issues/50","number":50,"state":"open","locked":false,"title":"add HtoZA signal files","user":{"login":"alesaggio","id":16693208,"avatar_url":"https://avatars3.githubusercontent.com/u/16693208?v=4","gravatar_id":"","url":"https://api.github.com/users/alesaggio","html_url":"https://github.com/alesaggio","followers_url":"https://api.github.com/users/alesaggio/followers","following_url":"https://api.github.com/users/alesaggio/following{/other_user}","gists_url":"https://api.github.com/users/alesaggio/gists{/gist_id}","starred_url":"https://api.github.com/users/alesaggio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alesaggio/subscriptions","organizations_url":"https://api.github.com/users/alesaggio/orgs","repos_url":"https://api.github.com/users/alesaggio/repos","events_url":"https://api.github.com/users/alesaggio/events{/privacy}","received_events_url":"https://api.github.com/users/alesaggio/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-27T13:35:55Z","updated_at":"2017-09-27T13:48:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a24910823da41b9b24f52b2bbc2956ca94e91ff7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cp3-llbb/Datasets/pulls/50/commits","review_comments_url":"https://api.github.com/repos/cp3-llbb/Datasets/pulls/50/comments","review_comment_url":"https://api.github.com/repos/cp3-llbb/Datasets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cp3-llbb/Datasets/issues/50/comments","statuses_url":"https://api.github.com/repos/cp3-llbb/Datasets/statuses/ba8c8c93d878b5db7328d1db60058092349b56e1","head":{"label":"alesaggio:RunIISummer16MiniAODv2","ref":"RunIISummer16MiniAODv2","sha":"ba8c8c93d878b5db7328d1db60058092349b56e1","user":{"login":"alesaggio","id":16693208,"avatar_url":"https://avatars3.githubusercontent.com/u/16693208?v=4","gravatar_id":"","url":"https://api.github.com/users/alesaggio","html_url":"https://github.com/alesaggio","followers_url":"https://api.github.com/users/alesaggio/followers","following_url":"https://api.github.com/users/alesaggio/following{/other_user}","gists_url":"https://api.github.com/users/alesaggio/gists{/gist_id}","starred_url":"https://api.github.com/users/alesaggio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alesaggio/subscriptions","organizations_url":"https://api.github.com/users/alesaggio/orgs","repos_url":"https://api.github.com/users/alesaggio/repos","events_url":"https://api.github.com/users/alesaggio/events{/privacy}","received_events_url":"https://api.github.com/users/alesaggio/received_events","type":"User","site_admin":false},"repo":{"id":105021042,"name":"Datasets","full_name":"alesaggio/Datasets","owner":{"login":"alesaggio","id":16693208,"avatar_url":"https://avatars3.githubusercontent.com/u/16693208?v=4","gravatar_id":"","url":"https://api.github.com/users/alesaggio","html_url":"https://github.com/alesaggio","followers_url":"https://api.github.com/users/alesaggio/followers","following_url":"https://api.github.com/users/alesaggio/following{/other_user}","gists_url":"https://api.github.com/users/alesaggio/gists{/gist_id}","starred_url":"https://api.github.com/users/alesaggio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alesaggio/subscriptions","organizations_url":"https://api.github.com/users/alesaggio/orgs","repos_url":"https://api.github.com/users/alesaggio/repos","events_url":"https://api.github.com/users/alesaggio/events{/privacy}","received_events_url":"https://api.github.com/users/alesaggio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alesaggio/Datasets","description":"DAS datasets to be used in GridIn","fork":true,"url":"https://api.github.com/repos/alesaggio/Datasets","forks_url":"https://api.github.com/repos/alesaggio/Datasets/forks","keys_url":"https://api.github.com/repos/alesaggio/Datasets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alesaggio/Datasets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alesaggio/Datasets/teams","hooks_url":"https://api.github.com/repos/alesaggio/Datasets/hooks","issue_events_url":"https://api.github.com/repos/alesaggio/Datasets/issues/events{/number}","events_url":"https://api.github.com/repos/alesaggio/Datasets/events","assignees_url":"https://api.github.com/repos/alesaggio/Datasets/assignees{/user}","branches_url":"https://api.github.com/repos/alesaggio/Datasets/branches{/branch}","tags_url":"https://api.github.com/repos/alesaggio/Datasets/tags","blobs_url":"https://api.github.com/repos/alesaggio/Datasets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alesaggio/Datasets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alesaggio/Datasets/git/refs{/sha}","trees_url":"https://api.github.com/repos/alesaggio/Datasets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alesaggio/Datasets/statuses/{sha}","languages_url":"https://api.github.com/repos/alesaggio/Datasets/languages","stargazers_url":"https://api.github.com/repos/alesaggio/Datasets/stargazers","contributors_url":"https://api.github.com/repos/alesaggio/Datasets/contributors","subscribers_url":"https://api.github.com/repos/alesaggio/Datasets/subscribers","subscription_url":"https://api.github.com/repos/alesaggio/Datasets/subscription","commits_url":"https://api.github.com/repos/alesaggio/Datasets/commits{/sha}","git_commits_url":"https://api.github.com/repos/alesaggio/Datasets/git/commits{/sha}","comments_url":"https://api.github.com/repos/alesaggio/Datasets/comments{/number}","issue_comment_url":"https://api.github.com/repos/alesaggio/Datasets/issues/comments{/number}","contents_url":"https://api.github.com/repos/alesaggio/Datasets/contents/{+path}","compare_url":"https://api.github.com/repos/alesaggio/Datasets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alesaggio/Datasets/merges","archive_url":"https://api.github.com/repos/alesaggio/Datasets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alesaggio/Datasets/downloads","issues_url":"https://api.github.com/repos/alesaggio/Datasets/issues{/number}","pulls_url":"https://api.github.com/repos/alesaggio/Datasets/pulls{/number}","milestones_url":"https://api.github.com/repos/alesaggio/Datasets/milestones{/number}","notifications_url":"https://api.github.com/repos/alesaggio/Datasets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alesaggio/Datasets/labels{/name}","releases_url":"https://api.github.com/repos/alesaggio/Datasets/releases{/id}","deployments_url":"https://api.github.com/repos/alesaggio/Datasets/deployments","created_at":"2017-09-27T13:22:49Z","updated_at":"2017-09-27T13:22:51Z","pushed_at":"2017-09-27T13:34:49Z","git_url":"git://github.com/alesaggio/Datasets.git","ssh_url":"[email protected]:alesaggio/Datasets.git","clone_url":"https://github.com/alesaggio/Datasets.git","svn_url":"https://github.com/alesaggio/Datasets","homepage":null,"size":80,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"RunIISummer16MiniAODv2"}},"base":{"label":"cp3-llbb:RunIISummer16MiniAODv2","ref":"RunIISummer16MiniAODv2","sha":"2317bf4eacf172ddfb8062333cd0c0df3dc5c1ed","user":{"login":"cp3-llbb","id":12397486,"avatar_url":"https://avatars1.githubusercontent.com/u/12397486?v=4","gravatar_id":"","url":"https://api.github.com/users/cp3-llbb","html_url":"https://github.com/cp3-llbb","followers_url":"https://api.github.com/users/cp3-llbb/followers","following_url":"https://api.github.com/users/cp3-llbb/following{/other_user}","gists_url":"https://api.github.com/users/cp3-llbb/gists{/gist_id}","starred_url":"https://api.github.com/users/cp3-llbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cp3-llbb/subscriptions","organizations_url":"https://api.github.com/users/cp3-llbb/orgs","repos_url":"https://api.github.com/users/cp3-llbb/repos","events_url":"https://api.github.com/users/cp3-llbb/events{/privacy}","received_events_url":"https://api.github.com/users/cp3-llbb/received_events","type":"Organization","site_admin":false},"repo":{"id":49949964,"name":"Datasets","full_name":"cp3-llbb/Datasets","owner":{"login":"cp3-llbb","id":12397486,"avatar_url":"https://avatars1.githubusercontent.com/u/12397486?v=4","gravatar_id":"","url":"https://api.github.com/users/cp3-llbb","html_url":"https://github.com/cp3-llbb","followers_url":"https://api.github.com/users/cp3-llbb/followers","following_url":"https://api.github.com/users/cp3-llbb/following{/other_user}","gists_url":"https://api.github.com/users/cp3-llbb/gists{/gist_id}","starred_url":"https://api.github.com/users/cp3-llbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cp3-llbb/subscriptions","organizations_url":"https://api.github.com/users/cp3-llbb/orgs","repos_url":"https://api.github.com/users/cp3-llbb/repos","events_url":"https://api.github.com/users/cp3-llbb/events{/privacy}","received_events_url":"https://api.github.com/users/cp3-llbb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cp3-llbb/Datasets","description":"DAS datasets to be used in GridIn","fork":false,"url":"https://api.github.com/repos/cp3-llbb/Datasets","forks_url":"https://api.github.com/repos/cp3-llbb/Datasets/forks","keys_url":"https://api.github.com/repos/cp3-llbb/Datasets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cp3-llbb/Datasets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cp3-llbb/Datasets/teams","hooks_url":"https://api.github.com/repos/cp3-llbb/Datasets/hooks","issue_events_url":"https://api.github.com/repos/cp3-llbb/Datasets/issues/events{/number}","events_url":"https://api.github.com/repos/cp3-llbb/Datasets/events","assignees_url":"https://api.github.com/repos/cp3-llbb/Datasets/assignees{/user}","branches_url":"https://api.github.com/repos/cp3-llbb/Datasets/branches{/branch}","tags_url":"https://api.github.com/repos/cp3-llbb/Datasets/tags","blobs_url":"https://api.github.com/repos/cp3-llbb/Datasets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cp3-llbb/Datasets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cp3-llbb/Datasets/git/refs{/sha}","trees_url":"https://api.github.com/repos/cp3-llbb/Datasets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cp3-llbb/Datasets/statuses/{sha}","languages_url":"https://api.github.com/repos/cp3-llbb/Datasets/languages","stargazers_url":"https://api.github.com/repos/cp3-llbb/Datasets/stargazers","contributors_url":"https://api.github.com/repos/cp3-llbb/Datasets/contributors","subscribers_url":"https://api.github.com/repos/cp3-llbb/Datasets/subscribers","subscription_url":"https://api.github.com/repos/cp3-llbb/Datasets/subscription","commits_url":"https://api.github.com/repos/cp3-llbb/Datasets/commits{/sha}","git_commits_url":"https://api.github.com/repos/cp3-llbb/Datasets/git/commits{/sha}","comments_url":"https://api.github.com/repos/cp3-llbb/Datasets/comments{/number}","issue_comment_url":"https://api.github.com/repos/cp3-llbb/Datasets/issues/comments{/number}","contents_url":"https://api.github.com/repos/cp3-llbb/Datasets/contents/{+path}","compare_url":"https://api.github.com/repos/cp3-llbb/Datasets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cp3-llbb/Datasets/merges","archive_url":"https://api.github.com/repos/cp3-llbb/Datasets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cp3-llbb/Datasets/downloads","issues_url":"https://api.github.com/repos/cp3-llbb/Datasets/issues{/number}","pulls_url":"https://api.github.com/repos/cp3-llbb/Datasets/pulls{/number}","milestones_url":"https://api.github.com/repos/cp3-llbb/Datasets/milestones{/number}","notifications_url":"https://api.github.com/repos/cp3-llbb/Datasets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cp3-llbb/Datasets/labels{/name}","releases_url":"https://api.github.com/repos/cp3-llbb/Datasets/releases{/id}","deployments_url":"https://api.github.com/repos/cp3-llbb/Datasets/deployments","created_at":"2016-01-19T12:02:19Z","updated_at":"2016-04-05T10:09:08Z","pushed_at":"2017-09-27T13:35:55Z","git_url":"git://github.com/cp3-llbb/Datasets.git","ssh_url":"[email protected]:cp3-llbb/Datasets.git","clone_url":"https://github.com/cp3-llbb/Datasets.git","svn_url":"https://github.com/cp3-llbb/Datasets","homepage":null,"size":80,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":1,"forks":7,"open_issues":1,"watchers":0,"default_branch":"RunIISummer16MiniAODv2"}},"_links":{"self":{"href":"https://api.github.com/repos/cp3-llbb/Datasets/pulls/50"},"html":{"href":"https://github.com/cp3-llbb/Datasets/pull/50"},"issue":{"href":"https://api.github.com/repos/cp3-llbb/Datasets/issues/50"},"comments":{"href":"https://api.github.com/repos/cp3-llbb/Datasets/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/cp3-llbb/Datasets/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/cp3-llbb/Datasets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cp3-llbb/Datasets/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/cp3-llbb/Datasets/statuses/ba8c8c93d878b5db7328d1db60058092349b56e1"}},"author_association":"NONE"}} | {
"id": 49949964,
"name": "cp3-llbb/Datasets",
"url": "https://api.github.com/repos/cp3-llbb/Datasets"
} | {
"id": 2760084,
"login": "OlivierBondu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2760084?",
"url": "https://api.github.com/users/OlivierBondu"
} | {
"id": 12397486,
"login": "cp3-llbb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12397486?",
"url": "https://api.github.com/orgs/cp3-llbb"
} | 2017-09-27T13:48:28 | 6644116556 | {"actor":{"display_login":"OlivierBondu"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/comments/134113941","pull_request_review_id":57370761,"id":134113941,"diff_hunk":"@@ -208,22 +208,27 @@ private void printStep(TestStep testStep, Result result) {\n }\n \n String formatStepText(String keyword, String stepText, Format textFormat, Format argFormat, List<Argument> arguments) {\n- int textStart = 0;\n+ int beginIndex = 0;\n StringBuilder result = new StringBuilder(textFormat.text(keyword));\n for (Argument argument : arguments) {\n // can be null if the argument is missing.\n if (argument.getOffset() != null) {\n- String text = stepText.substring(textStart, argument.getOffset());\n+ int argumentOffset = argument.getOffset();\n+ if (argumentOffset < beginIndex ) { // a nested argument starts before the enclosing argument ends; ignore it when formatting\n+ continue;\n+ }\n+ String text = stepText.substring(beginIndex, argumentOffset);\n result.append(textFormat.text(text));\n }\n // val can be null if the argument isn't there, for example @And(\"(it )?has something\")\n if (argument.getVal() != null) {\n result.append(argFormat.text(argument.getVal()));\n- textStart = argument.getOffset() + argument.getVal().length();\n+ int argumentEnd = argument.getOffset() + argument.getVal().length(); // end of current argument; can be < 0 for nested argument\n+ beginIndex = argumentEnd;\n }\n }\n- if (textStart != stepText.length()) {\n- String text = stepText.substring(textStart, stepText.length());\n+ if (beginIndex != stepText.length() && beginIndex >= 0) {","path":"core/src/main/java/cucumber/runtime/formatter/PrettyFormatter.java","position":28,"original_position":28,"commit_id":"0a04969b7a21d1c3325f1211f3e261b20a297c8e","original_commit_id":"0a04969b7a21d1c3325f1211f3e261b20a297c8e","user":{"login":"mlvandijk","id":20927578,"avatar_url":"https://avatars0.githubusercontent.com/u/20927578?v=4","gravatar_id":"","url":"https://api.github.com/users/mlvandijk","html_url":"https://github.com/mlvandijk","followers_url":"https://api.github.com/users/mlvandijk/followers","following_url":"https://api.github.com/users/mlvandijk/following{/other_user}","gists_url":"https://api.github.com/users/mlvandijk/gists{/gist_id}","starred_url":"https://api.github.com/users/mlvandijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlvandijk/subscriptions","organizations_url":"https://api.github.com/users/mlvandijk/orgs","repos_url":"https://api.github.com/users/mlvandijk/repos","events_url":"https://api.github.com/users/mlvandijk/events{/privacy}","received_events_url":"https://api.github.com/users/mlvandijk/received_events","type":"User","site_admin":false},"body":"Huh, you're right! I added it before, because it was throwing exception here also.. will update","created_at":"2017-08-20T12:17:23Z","updated_at":"2017-08-20T12:17:23Z","html_url":"https://github.com/cucumber/cucumber-jvm/pull/1200#discussion_r134113941","pull_request_url":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/1200","_links":{"self":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/comments/134113941"},"html":{"href":"https://github.com/cucumber/cucumber-jvm/pull/1200#discussion_r134113941"},"pull_request":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/1200"}}},"pull_request":{"url":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/1200","id":136318928,"html_url":"https://github.com/cucumber/cucumber-jvm/pull/1200","diff_url":"https://github.com/cucumber/cucumber-jvm/pull/1200.diff","patch_url":"https://github.com/cucumber/cucumber-jvm/pull/1200.patch","issue_url":"https://api.github.com/repos/cucumber/cucumber-jvm/issues/1200","number":1200,"state":"open","locked":false,"title":"[Core] Fix PrettyFormatter exception on nested arguments","user":{"login":"mlvandijk","id":20927578,"avatar_url":"https://avatars0.githubusercontent.com/u/20927578?v=4","gravatar_id":"","url":"https://api.github.com/users/mlvandijk","html_url":"https://github.com/mlvandijk","followers_url":"https://api.github.com/users/mlvandijk/followers","following_url":"https://api.github.com/users/mlvandijk/following{/other_user}","gists_url":"https://api.github.com/users/mlvandijk/gists{/gist_id}","starred_url":"https://api.github.com/users/mlvandijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlvandijk/subscriptions","organizations_url":"https://api.github.com/users/mlvandijk/orgs","repos_url":"https://api.github.com/users/mlvandijk/repos","events_url":"https://api.github.com/users/mlvandijk/events{/privacy}","received_events_url":"https://api.github.com/users/mlvandijk/received_events","type":"User","site_admin":false},"body":"## Summary\r\nFixed to ignore formatting for nested capture groups (arguments), as they are already formatted as an argument as part of the enclosing capture group (argument), thus no longer throwing StringIndexOutOfBoundsException which prevented additional scenarios/ features from running (#619).\r\n\r\n## Details\r\n\r\nAdded 2 tests to verify formatting of nested capture groups\r\nAdded 2 checks on variables passed to substring() to prevent StringIndexOutOfBoundsException (see more below).\r\nAlso did a minor refactor (=renamed these variables) for clarity.\r\nAdditionally, fixed a typo in PrettyFormatterTest\r\n\r\n## Motivation and Context\r\nNested capture groups could not be handled by the PrettyFormatter. Since each capture groups maps to an argument, this sort of gives an argument in an argument. A nested argument starts before the enclosing argument ends, throwing a StringIndexOutOfBoundsException on stepText.substring().\r\n\r\npublic String substring(int beginIndex, int endIndex) throws: IndexOutOfBoundsException - if the beginIndex is negative, or endIndex is larger than the length of this String object, or beginIndex is larger than endIndex.\r\n\r\n* beginIndex = argument offset + length of argument\r\n* endIndex = argumentOffset\r\n\r\nThe expected value for argument.offset is always *negative* for nested capture groups, as a nested argument starts before the previous (=enclosing) argument ends. \r\nThis means: \r\n* beginIndex could be < 0, throwing an Exception -> Added check to verify beginIndex >= 0 \r\n* beginIndex could be larger than endIndex -> Added check verify endIndex < beginIndex\r\n** Note: endIndex (argumentOffset) will not be larger than the length of this String object (stepText) -> no check needed\r\n\r\n## How Has This Been Tested?\r\n\r\n1. Reproduce original bug by creating a test expecting StringIndexOutOfBoundsException. Removed this test once it failed after implementation of the fix.\r\n2. Added 2 tests to test that nested argument(s) is/are formatted as part of the enclosing argument (and no Exception is thrown).\r\n3. Clean/install cucumber-jvm core (i.e. checking all other tests still pass).\r\n\r\n## Screenshots (if appropriate):\r\nN/A\r\n\r\n## Types of changes\r\n- [x] Bug fix (non-breaking change which fixes an issue).\r\n- [ ] New feature (non-breaking change which adds functionality).\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).\r\n\r\n## Checklist:\r\n- [x] I've added tests for my code.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n\r\nIf necessary, add some documentation about PrettyFormatter (provided by @mpkorstanje ):\r\n\r\nThe pretty formatter creates a pretty looking text on the command line output. On windows this is white and plain, but when using a Unix Ansi compatible terminal this output is colored and **has formatting**.\r\n\r\nColor and other formatting is enabled by printing a special escape sequence at the start of the part that should be colored. At the end of the markup a reset symbol is printed. \r\n\r\nSo the text `Given text arg1 text arg2` is rendered as \"Given text **arg1** text **arg2**\".\r\n\r\nYou can see an example of this in `should_mark_arguments_in_steps`.\r\n\r\nA nested capture group is a capture group inside a regex that is placed inside another capture group. For example: `the order is placed( and (not yet )? confirmed)?`\r\n\r\nThis means that all these are valid steps:\r\n\r\n```\r\nGiven the order is placed\r\nGiven the order is placed and confirmed\r\nGiven the order is placed and not yet confirmed\r\n```\r\n\r\nThe step `Given the order is placed and not yet confirmed` has two Arguments. \r\n\r\n```\r\nnew Argument(20, \"and not yet confirmed\")\r\nnew Argument(-21, \"not yet\")\r\n```\r\n\r\nAnd should be formatted as: \"Given the order is placed **and not yet confirmed**\". It is acceptable to completely skip the nested argument as the enclosing step has already been formatted from end to end.","created_at":"2017-08-17T18:07:45Z","updated_at":"2017-08-20T12:17:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d524fa91a264b0cacaf43516d238e2e5e9e3b03","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/1200/commits","review_comments_url":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/1200/comments","review_comment_url":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cucumber/cucumber-jvm/issues/1200/comments","statuses_url":"https://api.github.com/repos/cucumber/cucumber-jvm/statuses/0a04969b7a21d1c3325f1211f3e261b20a297c8e","head":{"label":"mlvandijk:pretty-formatter-nested-args","ref":"pretty-formatter-nested-args","sha":"0a04969b7a21d1c3325f1211f3e261b20a297c8e","user":{"login":"mlvandijk","id":20927578,"avatar_url":"https://avatars0.githubusercontent.com/u/20927578?v=4","gravatar_id":"","url":"https://api.github.com/users/mlvandijk","html_url":"https://github.com/mlvandijk","followers_url":"https://api.github.com/users/mlvandijk/followers","following_url":"https://api.github.com/users/mlvandijk/following{/other_user}","gists_url":"https://api.github.com/users/mlvandijk/gists{/gist_id}","starred_url":"https://api.github.com/users/mlvandijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlvandijk/subscriptions","organizations_url":"https://api.github.com/users/mlvandijk/orgs","repos_url":"https://api.github.com/users/mlvandijk/repos","events_url":"https://api.github.com/users/mlvandijk/events{/privacy}","received_events_url":"https://api.github.com/users/mlvandijk/received_events","type":"User","site_admin":false},"repo":{"id":99586183,"name":"cucumber-jvm","full_name":"mlvandijk/cucumber-jvm","owner":{"login":"mlvandijk","id":20927578,"avatar_url":"https://avatars0.githubusercontent.com/u/20927578?v=4","gravatar_id":"","url":"https://api.github.com/users/mlvandijk","html_url":"https://github.com/mlvandijk","followers_url":"https://api.github.com/users/mlvandijk/followers","following_url":"https://api.github.com/users/mlvandijk/following{/other_user}","gists_url":"https://api.github.com/users/mlvandijk/gists{/gist_id}","starred_url":"https://api.github.com/users/mlvandijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlvandijk/subscriptions","organizations_url":"https://api.github.com/users/mlvandijk/orgs","repos_url":"https://api.github.com/users/mlvandijk/repos","events_url":"https://api.github.com/users/mlvandijk/events{/privacy}","received_events_url":"https://api.github.com/users/mlvandijk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mlvandijk/cucumber-jvm","description":"Cucumber for the JVM","fork":true,"url":"https://api.github.com/repos/mlvandijk/cucumber-jvm","forks_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/forks","keys_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/teams","hooks_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/hooks","issue_events_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/issues/events{/number}","events_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/events","assignees_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/assignees{/user}","branches_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/branches{/branch}","tags_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/tags","blobs_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/statuses/{sha}","languages_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/languages","stargazers_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/stargazers","contributors_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/contributors","subscribers_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/subscribers","subscription_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/subscription","commits_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/contents/{+path}","compare_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/merges","archive_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/downloads","issues_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/issues{/number}","pulls_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/pulls{/number}","milestones_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/milestones{/number}","notifications_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/labels{/name}","releases_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/releases{/id}","deployments_url":"https://api.github.com/repos/mlvandijk/cucumber-jvm/deployments","created_at":"2017-08-07T14:22:58Z","updated_at":"2017-08-09T13:43:49Z","pushed_at":"2017-08-18T13:07:32Z","git_url":"git://github.com/mlvandijk/cucumber-jvm.git","ssh_url":"[email protected]:mlvandijk/cucumber-jvm.git","clone_url":"https://github.com/mlvandijk/cucumber-jvm.git","svn_url":"https://github.com/mlvandijk/cucumber-jvm","homepage":"https://cucumber.io","size":17597,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cucumber:master","ref":"master","sha":"41ceadbe104848ecf35a4de16520c693e33e0359","user":{"login":"cucumber","id":320565,"avatar_url":"https://avatars0.githubusercontent.com/u/320565?v=4","gravatar_id":"","url":"https://api.github.com/users/cucumber","html_url":"https://github.com/cucumber","followers_url":"https://api.github.com/users/cucumber/followers","following_url":"https://api.github.com/users/cucumber/following{/other_user}","gists_url":"https://api.github.com/users/cucumber/gists{/gist_id}","starred_url":"https://api.github.com/users/cucumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cucumber/subscriptions","organizations_url":"https://api.github.com/users/cucumber/orgs","repos_url":"https://api.github.com/users/cucumber/repos","events_url":"https://api.github.com/users/cucumber/events{/privacy}","received_events_url":"https://api.github.com/users/cucumber/received_events","type":"Organization","site_admin":false},"repo":{"id":1962219,"name":"cucumber-jvm","full_name":"cucumber/cucumber-jvm","owner":{"login":"cucumber","id":320565,"avatar_url":"https://avatars0.githubusercontent.com/u/320565?v=4","gravatar_id":"","url":"https://api.github.com/users/cucumber","html_url":"https://github.com/cucumber","followers_url":"https://api.github.com/users/cucumber/followers","following_url":"https://api.github.com/users/cucumber/following{/other_user}","gists_url":"https://api.github.com/users/cucumber/gists{/gist_id}","starred_url":"https://api.github.com/users/cucumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cucumber/subscriptions","organizations_url":"https://api.github.com/users/cucumber/orgs","repos_url":"https://api.github.com/users/cucumber/repos","events_url":"https://api.github.com/users/cucumber/events{/privacy}","received_events_url":"https://api.github.com/users/cucumber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cucumber/cucumber-jvm","description":"Cucumber for the JVM","fork":false,"url":"https://api.github.com/repos/cucumber/cucumber-jvm","forks_url":"https://api.github.com/repos/cucumber/cucumber-jvm/forks","keys_url":"https://api.github.com/repos/cucumber/cucumber-jvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cucumber/cucumber-jvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cucumber/cucumber-jvm/teams","hooks_url":"https://api.github.com/repos/cucumber/cucumber-jvm/hooks","issue_events_url":"https://api.github.com/repos/cucumber/cucumber-jvm/issues/events{/number}","events_url":"https://api.github.com/repos/cucumber/cucumber-jvm/events","assignees_url":"https://api.github.com/repos/cucumber/cucumber-jvm/assignees{/user}","branches_url":"https://api.github.com/repos/cucumber/cucumber-jvm/branches{/branch}","tags_url":"https://api.github.com/repos/cucumber/cucumber-jvm/tags","blobs_url":"https://api.github.com/repos/cucumber/cucumber-jvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cucumber/cucumber-jvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cucumber/cucumber-jvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/cucumber/cucumber-jvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cucumber/cucumber-jvm/statuses/{sha}","languages_url":"https://api.github.com/repos/cucumber/cucumber-jvm/languages","stargazers_url":"https://api.github.com/repos/cucumber/cucumber-jvm/stargazers","contributors_url":"https://api.github.com/repos/cucumber/cucumber-jvm/contributors","subscribers_url":"https://api.github.com/repos/cucumber/cucumber-jvm/subscribers","subscription_url":"https://api.github.com/repos/cucumber/cucumber-jvm/subscription","commits_url":"https://api.github.com/repos/cucumber/cucumber-jvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/cucumber/cucumber-jvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/cucumber/cucumber-jvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/cucumber/cucumber-jvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/cucumber/cucumber-jvm/contents/{+path}","compare_url":"https://api.github.com/repos/cucumber/cucumber-jvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cucumber/cucumber-jvm/merges","archive_url":"https://api.github.com/repos/cucumber/cucumber-jvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cucumber/cucumber-jvm/downloads","issues_url":"https://api.github.com/repos/cucumber/cucumber-jvm/issues{/number}","pulls_url":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls{/number}","milestones_url":"https://api.github.com/repos/cucumber/cucumber-jvm/milestones{/number}","notifications_url":"https://api.github.com/repos/cucumber/cucumber-jvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cucumber/cucumber-jvm/labels{/name}","releases_url":"https://api.github.com/repos/cucumber/cucumber-jvm/releases{/id}","deployments_url":"https://api.github.com/repos/cucumber/cucumber-jvm/deployments","created_at":"2011-06-27T19:49:46Z","updated_at":"2017-08-18T08:56:31Z","pushed_at":"2017-08-20T09:19:25Z","git_url":"git://github.com/cucumber/cucumber-jvm.git","ssh_url":"[email protected]:cucumber/cucumber-jvm.git","clone_url":"https://github.com/cucumber/cucumber-jvm.git","svn_url":"https://github.com/cucumber/cucumber-jvm","homepage":"https://cucumber.io","size":17605,"stargazers_count":1525,"watchers_count":1525,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1305,"mirror_url":null,"open_issues_count":112,"forks":1305,"open_issues":112,"watchers":1525,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/1200"},"html":{"href":"https://github.com/cucumber/cucumber-jvm/pull/1200"},"issue":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/issues/1200"},"comments":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/issues/1200/comments"},"review_comments":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/1200/comments"},"review_comment":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/1200/commits"},"statuses":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/statuses/0a04969b7a21d1c3325f1211f3e261b20a297c8e"}}}} | {
"id": 1962219,
"name": "cucumber/cucumber-jvm",
"url": "https://api.github.com/repos/cucumber/cucumber-jvm"
} | {
"id": 20927578,
"login": "mlvandijk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20927578?",
"url": "https://api.github.com/users/mlvandijk"
} | {
"id": 320565,
"login": "cucumber",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/320565?",
"url": "https://api.github.com/orgs/cucumber"
} | 2017-08-20T12:17:23 | 6487872468 | {"actor":{"display_login":"mlvandijk"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/datastax/java-driver/pulls/comments/97994138","pull_request_review_id":18621514,"id":97994138,"diff_hunk":"@@ -0,0 +1,136 @@\n+/*\n+ * Copyright (C) 2012-2015 DataStax Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package com.datastax.driver.core;\n+\n+import com.datastax.driver.core.exceptions.NoHostAvailableException;\n+import com.datastax.driver.core.exceptions.UnsupportedProtocolVersionException;\n+import org.testng.annotations.Test;\n+\n+import static com.datastax.driver.core.ProtocolVersion.*;\n+import static org.assertj.core.api.Assertions.assertThat;\n+\n+@CreateCCM(CreateCCM.TestMode.PER_METHOD)\n+public class ProtocolVersionRenegotiationTest extends CCMTestsSupport {\n+\n+ /**\n+ * @jira_ticket JAVA-1367\n+ */\n+ @Test(groups = \"short\")\n+ @CCMConfig(version = \"3.6\", createCluster = false)\n+ public void should_fail_when_renegotiation_disabled_3_6() throws Exception {\n+ UnsupportedProtocolVersionException e = connectWithUnsupportedVersion(V1);\n+ assertThat(e.getUnsupportedVersion()).isEqualTo(V1);\n+ // pre-CASSANDRA-11464: server replies with its own version\n+ assertThat(e.getServerVersion()).isEqualTo(V4);\n+ }\n+\n+ /**\n+ * @jira_ticket JAVA-1367\n+ */\n+ @Test(groups = \"short\")\n+ @CCMConfig(version = \"3.10\", createCluster = false)\n+ public void should_fail_when_renegotiation_disabled_3_10() throws Exception {\n+ UnsupportedProtocolVersionException e = connectWithUnsupportedVersion(V1);\n+ assertThat(e.getUnsupportedVersion()).isEqualTo(V1);\n+ // post-CASSANDRA-11464: server replies with client's version\n+ assertThat(e.getServerVersion()).isEqualTo(V1);\n+ }\n+\n+ /**\n+ * @jira_ticket JAVA-1367\n+ */\n+ @Test(groups = \"short\")\n+ @CCMConfig(version = \"2.1.16\", createCluster = false)\n+ public void should_fail_when_initial_version_is_beta() throws Exception {\n+ UnsupportedProtocolVersionException e = connectWithUnsupportedBetaVersion();\n+ assertThat(e.getUnsupportedVersion()).isEqualTo(V5);\n+ assertThat(e.getServerVersion()).isEqualTo(V3);\n+ }\n+\n+ /**\n+ * @jira_ticket JAVA-1367\n+ */\n+ @Test(groups = \"short\")\n+ @CCMConfig(version = \"1.2.19\", createCluster = false)\n+ public void should_renegotiate_when_renegotiation_enabled_and_initial_version_too_high_1_2_19() throws Exception {\n+ Cluster cluster = connectWithoutVersion();\n+ assertThat(actualProtocolVersion(cluster)).isEqualTo(V1);\n+ }\n+\n+ /**\n+ * @jira_ticket JAVA-1367\n+ */\n+ @Test(groups = \"short\")\n+ @CCMConfig(version = \"2.0.17\", createCluster = false)\n+ public void should_renegotiate_when_renegotiation_enabled_and_initial_version_too_high_2_0_17() throws Exception {","path":"driver-core/src/test/java/com/datastax/driver/core/ProtocolVersionRenegotiationTest.java","position":78,"original_position":78,"commit_id":"98b9960f10e486de5590b914015e27309e369617","original_commit_id":"98b9960f10e486de5590b914015e27309e369617","user":{"login":"adutra","id":463876,"avatar_url":"https://avatars.githubusercontent.com/u/463876?v=3","gravatar_id":"","url":"https://api.github.com/users/adutra","html_url":"https://github.com/adutra","followers_url":"https://api.github.com/users/adutra/followers","following_url":"https://api.github.com/users/adutra/following{/other_user}","gists_url":"https://api.github.com/users/adutra/gists{/gist_id}","starred_url":"https://api.github.com/users/adutra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adutra/subscriptions","organizations_url":"https://api.github.com/users/adutra/orgs","repos_url":"https://api.github.com/users/adutra/repos","events_url":"https://api.github.com/users/adutra/events{/privacy}","received_events_url":"https://api.github.com/users/adutra/received_events","type":"User","site_admin":false},"body":"`@CCMConfig(version = \"XXX\")` forces a specific version instead of skipping the test if the version doesn't match the default one. I think it is required sometimes too, as tests like these could fail if run against any other version.","created_at":"2017-01-26T13:38:11Z","updated_at":"2017-01-26T13:38:11Z","html_url":"https://github.com/datastax/java-driver/pull/790#discussion_r97994138","pull_request_url":"https://api.github.com/repos/datastax/java-driver/pulls/790","_links":{"self":{"href":"https://api.github.com/repos/datastax/java-driver/pulls/comments/97994138"},"html":{"href":"https://github.com/datastax/java-driver/pull/790#discussion_r97994138"},"pull_request":{"href":"https://api.github.com/repos/datastax/java-driver/pulls/790"}}},"pull_request":{"url":"https://api.github.com/repos/datastax/java-driver/pulls/790","id":103112358,"html_url":"https://github.com/datastax/java-driver/pull/790","diff_url":"https://github.com/datastax/java-driver/pull/790.diff","patch_url":"https://github.com/datastax/java-driver/pull/790.patch","issue_url":"https://api.github.com/repos/datastax/java-driver/issues/790","number":790,"state":"open","locked":false,"title":"JAVA-1367: Make protocol negotiation more resilient","user":{"login":"adutra","id":463876,"avatar_url":"https://avatars.githubusercontent.com/u/463876?v=3","gravatar_id":"","url":"https://api.github.com/users/adutra","html_url":"https://github.com/adutra","followers_url":"https://api.github.com/users/adutra/followers","following_url":"https://api.github.com/users/adutra/following{/other_user}","gists_url":"https://api.github.com/users/adutra/gists{/gist_id}","starred_url":"https://api.github.com/users/adutra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adutra/subscriptions","organizations_url":"https://api.github.com/users/adutra/orgs","repos_url":"https://api.github.com/users/adutra/repos","events_url":"https://api.github.com/users/adutra/events{/privacy}","received_events_url":"https://api.github.com/users/adutra/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nCASSANDRA-11464 introduced in 3.0.8+, 3.8+ changed logic of protocol\r\nerror messages to be sent with the protocol version requested\r\nby the client, instead of a version that the server supports,\r\nto ensure that the client will be able to decode the response properly.\r\n\r\nThe driver currently uses the returned protocol version to determine\r\nwhat protocol version to downgrade to and reattempt connection.\r\nBecause of this, the driver would retry the same protocol version and\r\nfail again.\r\n\r\nModifications:\r\n\r\nModify the protocol renegotiation protocol algorithm as follows:\r\n1) assume the best version is the one that the server replied with;\r\n2) if this version is actually the very same one that we just tried\r\nalready, then downgrade if possible to the highest lower version\r\nsupported, and retry.\r\n3) if the version cannot be downgraded, then rethrow the\r\noriginal exception.\r\n\r\nResult:\r\n\r\nDriver is compatible with Cassandra 3.0.8+, 3.8+.","created_at":"2017-01-25T12:48:24Z","updated_at":"2017-01-26T13:38:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5302d60042a18e6e5b99c3f69eff25e467a17391","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/datastax/java-driver/milestones/17","html_url":"https://github.com/datastax/java-driver/milestone/17","labels_url":"https://api.github.com/repos/datastax/java-driver/milestones/17/labels","id":1917679,"number":17,"title":"3.2.0","description":null,"creator":{"login":"adutra","id":463876,"avatar_url":"https://avatars.githubusercontent.com/u/463876?v=3","gravatar_id":"","url":"https://api.github.com/users/adutra","html_url":"https://github.com/adutra","followers_url":"https://api.github.com/users/adutra/followers","following_url":"https://api.github.com/users/adutra/following{/other_user}","gists_url":"https://api.github.com/users/adutra/gists{/gist_id}","starred_url":"https://api.github.com/users/adutra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adutra/subscriptions","organizations_url":"https://api.github.com/users/adutra/orgs","repos_url":"https://api.github.com/users/adutra/repos","events_url":"https://api.github.com/users/adutra/events{/privacy}","received_events_url":"https://api.github.com/users/adutra/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":5,"state":"open","created_at":"2016-08-02T08:38:19Z","updated_at":"2017-01-25T15:44:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/datastax/java-driver/pulls/790/commits","review_comments_url":"https://api.github.com/repos/datastax/java-driver/pulls/790/comments","review_comment_url":"https://api.github.com/repos/datastax/java-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datastax/java-driver/issues/790/comments","statuses_url":"https://api.github.com/repos/datastax/java-driver/statuses/98b9960f10e486de5590b914015e27309e369617","head":{"label":"datastax:java1367","ref":"java1367","sha":"98b9960f10e486de5590b914015e27309e369617","user":{"login":"datastax","id":573369,"avatar_url":"https://avatars.githubusercontent.com/u/573369?v=3","gravatar_id":"","url":"https://api.github.com/users/datastax","html_url":"https://github.com/datastax","followers_url":"https://api.github.com/users/datastax/followers","following_url":"https://api.github.com/users/datastax/following{/other_user}","gists_url":"https://api.github.com/users/datastax/gists{/gist_id}","starred_url":"https://api.github.com/users/datastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datastax/subscriptions","organizations_url":"https://api.github.com/users/datastax/orgs","repos_url":"https://api.github.com/users/datastax/repos","events_url":"https://api.github.com/users/datastax/events{/privacy}","received_events_url":"https://api.github.com/users/datastax/received_events","type":"Organization","site_admin":false},"repo":{"id":6765281,"name":"java-driver","full_name":"datastax/java-driver","owner":{"login":"datastax","id":573369,"avatar_url":"https://avatars.githubusercontent.com/u/573369?v=3","gravatar_id":"","url":"https://api.github.com/users/datastax","html_url":"https://github.com/datastax","followers_url":"https://api.github.com/users/datastax/followers","following_url":"https://api.github.com/users/datastax/following{/other_user}","gists_url":"https://api.github.com/users/datastax/gists{/gist_id}","starred_url":"https://api.github.com/users/datastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datastax/subscriptions","organizations_url":"https://api.github.com/users/datastax/orgs","repos_url":"https://api.github.com/users/datastax/repos","events_url":"https://api.github.com/users/datastax/events{/privacy}","received_events_url":"https://api.github.com/users/datastax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datastax/java-driver","description":"DataStax Java Driver for Apache Cassandra","fork":false,"url":"https://api.github.com/repos/datastax/java-driver","forks_url":"https://api.github.com/repos/datastax/java-driver/forks","keys_url":"https://api.github.com/repos/datastax/java-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datastax/java-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datastax/java-driver/teams","hooks_url":"https://api.github.com/repos/datastax/java-driver/hooks","issue_events_url":"https://api.github.com/repos/datastax/java-driver/issues/events{/number}","events_url":"https://api.github.com/repos/datastax/java-driver/events","assignees_url":"https://api.github.com/repos/datastax/java-driver/assignees{/user}","branches_url":"https://api.github.com/repos/datastax/java-driver/branches{/branch}","tags_url":"https://api.github.com/repos/datastax/java-driver/tags","blobs_url":"https://api.github.com/repos/datastax/java-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datastax/java-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datastax/java-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/datastax/java-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datastax/java-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/datastax/java-driver/languages","stargazers_url":"https://api.github.com/repos/datastax/java-driver/stargazers","contributors_url":"https://api.github.com/repos/datastax/java-driver/contributors","subscribers_url":"https://api.github.com/repos/datastax/java-driver/subscribers","subscription_url":"https://api.github.com/repos/datastax/java-driver/subscription","commits_url":"https://api.github.com/repos/datastax/java-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/datastax/java-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/datastax/java-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/datastax/java-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/datastax/java-driver/contents/{+path}","compare_url":"https://api.github.com/repos/datastax/java-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datastax/java-driver/merges","archive_url":"https://api.github.com/repos/datastax/java-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datastax/java-driver/downloads","issues_url":"https://api.github.com/repos/datastax/java-driver/issues{/number}","pulls_url":"https://api.github.com/repos/datastax/java-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/datastax/java-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/datastax/java-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datastax/java-driver/labels{/name}","releases_url":"https://api.github.com/repos/datastax/java-driver/releases{/id}","deployments_url":"https://api.github.com/repos/datastax/java-driver/deployments","created_at":"2012-11-19T18:44:41Z","updated_at":"2017-01-22T07:22:09Z","pushed_at":"2017-01-26T11:51:15Z","git_url":"git://github.com/datastax/java-driver.git","ssh_url":"[email protected]:datastax/java-driver.git","clone_url":"https://github.com/datastax/java-driver.git","svn_url":"https://github.com/datastax/java-driver","homepage":null,"size":23102,"stargazers_count":742,"watchers_count":742,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":541,"mirror_url":null,"open_issues_count":39,"forks":541,"open_issues":39,"watchers":742,"default_branch":"3.x"}},"base":{"label":"datastax:3.x","ref":"3.x","sha":"61954196b71ad200cba9e59478111e3edd309586","user":{"login":"datastax","id":573369,"avatar_url":"https://avatars.githubusercontent.com/u/573369?v=3","gravatar_id":"","url":"https://api.github.com/users/datastax","html_url":"https://github.com/datastax","followers_url":"https://api.github.com/users/datastax/followers","following_url":"https://api.github.com/users/datastax/following{/other_user}","gists_url":"https://api.github.com/users/datastax/gists{/gist_id}","starred_url":"https://api.github.com/users/datastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datastax/subscriptions","organizations_url":"https://api.github.com/users/datastax/orgs","repos_url":"https://api.github.com/users/datastax/repos","events_url":"https://api.github.com/users/datastax/events{/privacy}","received_events_url":"https://api.github.com/users/datastax/received_events","type":"Organization","site_admin":false},"repo":{"id":6765281,"name":"java-driver","full_name":"datastax/java-driver","owner":{"login":"datastax","id":573369,"avatar_url":"https://avatars.githubusercontent.com/u/573369?v=3","gravatar_id":"","url":"https://api.github.com/users/datastax","html_url":"https://github.com/datastax","followers_url":"https://api.github.com/users/datastax/followers","following_url":"https://api.github.com/users/datastax/following{/other_user}","gists_url":"https://api.github.com/users/datastax/gists{/gist_id}","starred_url":"https://api.github.com/users/datastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datastax/subscriptions","organizations_url":"https://api.github.com/users/datastax/orgs","repos_url":"https://api.github.com/users/datastax/repos","events_url":"https://api.github.com/users/datastax/events{/privacy}","received_events_url":"https://api.github.com/users/datastax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datastax/java-driver","description":"DataStax Java Driver for Apache Cassandra","fork":false,"url":"https://api.github.com/repos/datastax/java-driver","forks_url":"https://api.github.com/repos/datastax/java-driver/forks","keys_url":"https://api.github.com/repos/datastax/java-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datastax/java-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datastax/java-driver/teams","hooks_url":"https://api.github.com/repos/datastax/java-driver/hooks","issue_events_url":"https://api.github.com/repos/datastax/java-driver/issues/events{/number}","events_url":"https://api.github.com/repos/datastax/java-driver/events","assignees_url":"https://api.github.com/repos/datastax/java-driver/assignees{/user}","branches_url":"https://api.github.com/repos/datastax/java-driver/branches{/branch}","tags_url":"https://api.github.com/repos/datastax/java-driver/tags","blobs_url":"https://api.github.com/repos/datastax/java-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datastax/java-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datastax/java-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/datastax/java-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datastax/java-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/datastax/java-driver/languages","stargazers_url":"https://api.github.com/repos/datastax/java-driver/stargazers","contributors_url":"https://api.github.com/repos/datastax/java-driver/contributors","subscribers_url":"https://api.github.com/repos/datastax/java-driver/subscribers","subscription_url":"https://api.github.com/repos/datastax/java-driver/subscription","commits_url":"https://api.github.com/repos/datastax/java-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/datastax/java-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/datastax/java-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/datastax/java-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/datastax/java-driver/contents/{+path}","compare_url":"https://api.github.com/repos/datastax/java-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datastax/java-driver/merges","archive_url":"https://api.github.com/repos/datastax/java-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datastax/java-driver/downloads","issues_url":"https://api.github.com/repos/datastax/java-driver/issues{/number}","pulls_url":"https://api.github.com/repos/datastax/java-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/datastax/java-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/datastax/java-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datastax/java-driver/labels{/name}","releases_url":"https://api.github.com/repos/datastax/java-driver/releases{/id}","deployments_url":"https://api.github.com/repos/datastax/java-driver/deployments","created_at":"2012-11-19T18:44:41Z","updated_at":"2017-01-22T07:22:09Z","pushed_at":"2017-01-26T11:51:15Z","git_url":"git://github.com/datastax/java-driver.git","ssh_url":"[email protected]:datastax/java-driver.git","clone_url":"https://github.com/datastax/java-driver.git","svn_url":"https://github.com/datastax/java-driver","homepage":null,"size":23102,"stargazers_count":742,"watchers_count":742,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":541,"mirror_url":null,"open_issues_count":39,"forks":541,"open_issues":39,"watchers":742,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/datastax/java-driver/pulls/790"},"html":{"href":"https://github.com/datastax/java-driver/pull/790"},"issue":{"href":"https://api.github.com/repos/datastax/java-driver/issues/790"},"comments":{"href":"https://api.github.com/repos/datastax/java-driver/issues/790/comments"},"review_comments":{"href":"https://api.github.com/repos/datastax/java-driver/pulls/790/comments"},"review_comment":{"href":"https://api.github.com/repos/datastax/java-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datastax/java-driver/pulls/790/commits"},"statuses":{"href":"https://api.github.com/repos/datastax/java-driver/statuses/98b9960f10e486de5590b914015e27309e369617"}}}} | {
"id": 6765281,
"name": "datastax/java-driver",
"url": "https://api.github.com/repos/datastax/java-driver"
} | {
"id": 463876,
"login": "adutra",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/463876?",
"url": "https://api.github.com/users/adutra"
} | {
"id": 573369,
"login": "datastax",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/573369?",
"url": "https://api.github.com/orgs/datastax"
} | 2017-01-26T13:38:11 | 5217347486 | {"actor":{"display_login":"adutra"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/datopian/ourbot/pulls/comments/135232527","pull_request_review_id":58622730,"id":135232527,"diff_hunk":"@@ -33,63 +33,103 @@ module.exports = (robot) => {\n }\n })\n \n- robot.hear(/bot create milestone|bot close milestone/i, (res) => {\n- var message = res.message.text\n+ robot.hear(/bot create milestone/i, (res) => {\n+ let message = res.message.text\n message = message.split(' ')\n- if(message.length === 7 && message[0] === \"bot\" && message[1] === \"create\" && message[2] === \"milestone\") {\n- var repos = message[6]\n- repos = repos.split('/')\n- var title = message[3]+\" \"+message[4]+\" \"+message[5]\n- const myDate = moment(title, 'DD-MMM-YYYY').toDate()\n- if(myDate == \"Invalid Date\") {\n- res.reply(\"Title format is invalid\")\n- }\n- else {\n- createMilestone(repos[0], repos[1], title, myDate)\n- res.reply(\"Milestone successfully created at 'https://github.com/\"+repos[0]+\"/\"+repos[1]+\"/milestones\")\n- }\n- }\n- else if(message.length === 7 && message[0] === \"bot\" && message[1] === \"close\" && message[2] === \"milestone\") {\n- var repos = message[6]\n- repos = repos.split('/')\n- var title = message[3]+\" \"+message[4]+\" \"+message[5]\n- title = \"Sprint - \"+title\n- const myDate = moment(title, 'DD-MMM-YYYY').toDate()\n- if(myDate == \"Invalid Date\") {\n- res.reply(\"Title format is invalid\")\n- }\n- else {\n- closeMilestone(repos[0], repos[1], title)\n- res.reply(\"Milestone successfully closed at 'https://github.com/\"+repos[0]+\"/\"+repos[1]+\"/milestones\")\n- }\n- }\n- \n- else if(message.length === 6 && message[0] === \"bot\" && message[1] === \"close\" && message[2] === \"milestone\") {\n- var title = message[3]+\" \"+message[4]+\" \"+message[5]\n- title = \"Sprint - \"+title\n- const myDate = moment(title, 'DD-MMM-YYYY').toDate()\n- if(myDate == \"Invalid Date\") {\n- res.reply(\"Title format is invalid\")\n- }\n- else {\n- closeMilestoneAll(title)\n- res.reply(\"Milestones successfully closed\")\n- }\n- }\n- else if(message.length === 6 && message[0] === \"bot\" && message[1] === \"create\" && message[2] === \"milestone\"){\n- var title = message[3]+\" \"+message[4]+\" \"+message[5]\n- const myDate = moment(title, 'DD-MMM-YYYY').toDate()\n- if(myDate == \"Invalid Date\") {\n- res.reply(\"Title format is invalid\")\n- }\n- else {\n- createMilestoneAll(title, myDate)\n- res.reply(\"Milestones successfully created\")\n+ if(message[0] === \"bot\" && message[1] === \"create\" && message[2] === \"milestone\") {\n+ switch(message.length) {\n+ case 7: ","path":"scripts/main.js","position":null,"original_position":69,"commit_id":"3fb38e89ee3944a0ea7dedd22ec5eca8afdc457b","original_commit_id":"3fb38e89ee3944a0ea7dedd22ec5eca8afdc457b","user":{"login":"zelima","id":15143785,"avatar_url":"https://avatars3.githubusercontent.com/u/15143785?v=4","gravatar_id":"","url":"https://api.github.com/users/zelima","html_url":"https://github.com/zelima","followers_url":"https://api.github.com/users/zelima/followers","following_url":"https://api.github.com/users/zelima/following{/other_user}","gists_url":"https://api.github.com/users/zelima/gists{/gist_id}","starred_url":"https://api.github.com/users/zelima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zelima/subscriptions","organizations_url":"https://api.github.com/users/zelima/orgs","repos_url":"https://api.github.com/users/zelima/repos","events_url":"https://api.github.com/users/zelima/events{/privacy}","received_events_url":"https://api.github.com/users/zelima/received_events","type":"User","site_admin":false},"body":"I don't think this should be depended on the length of the message or exact/predefined titles for the backlog. I I should be able to give any title to the milestone I want. ","created_at":"2017-08-25T10:49:53Z","updated_at":"2017-08-25T10:52:39Z","html_url":"https://github.com/datopian/ourbot/pull/57#discussion_r135232527","pull_request_url":"https://api.github.com/repos/datopian/ourbot/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/datopian/ourbot/pulls/comments/135232527"},"html":{"href":"https://github.com/datopian/ourbot/pull/57#discussion_r135232527"},"pull_request":{"href":"https://api.github.com/repos/datopian/ourbot/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/datopian/ourbot/pulls/57","id":137553739,"html_url":"https://github.com/datopian/ourbot/pull/57","diff_url":"https://github.com/datopian/ourbot/pull/57.diff","patch_url":"https://github.com/datopian/ourbot/pull/57.patch","issue_url":"https://api.github.com/repos/datopian/ourbot/issues/57","number":57,"state":"open","locked":false,"title":"Features/milestone commands","user":{"login":"Mikanebu","id":19908588,"avatar_url":"https://avatars2.githubusercontent.com/u/19908588?v=4","gravatar_id":"","url":"https://api.github.com/users/Mikanebu","html_url":"https://github.com/Mikanebu","followers_url":"https://api.github.com/users/Mikanebu/followers","following_url":"https://api.github.com/users/Mikanebu/following{/other_user}","gists_url":"https://api.github.com/users/Mikanebu/gists{/gist_id}","starred_url":"https://api.github.com/users/Mikanebu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mikanebu/subscriptions","organizations_url":"https://api.github.com/users/Mikanebu/orgs","repos_url":"https://api.github.com/users/Mikanebu/repos","events_url":"https://api.github.com/users/Mikanebu/events{/privacy}","received_events_url":"https://api.github.com/users/Mikanebu/received_events","type":"User","site_admin":false},"body":"* created GitHub token to create a milestone\r\n* created function `hear` in `main.js`\r\n* created separate file`milestone.js` with 4 functions: createMilestone, closeMilestone\r\n* wrote unittest\r\n* updated `README.md`\r\n* updated `config.json` by adding repos list of objects\r\n* removed `extras/createMilestone.js` and `extras/closeMilestone.js` files, since they were refactored and moved into `milestone.js`\r\n* added env.variable `GITHUB_TOKEN` into `env.template`","created_at":"2017-08-24T21:17:33Z","updated_at":"2017-08-25T10:52:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef8de3f3f04e48d9c477109707d554c805197d7c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/datopian/ourbot/pulls/57/commits","review_comments_url":"https://api.github.com/repos/datopian/ourbot/pulls/57/comments","review_comment_url":"https://api.github.com/repos/datopian/ourbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datopian/ourbot/issues/57/comments","statuses_url":"https://api.github.com/repos/datopian/ourbot/statuses/3fb38e89ee3944a0ea7dedd22ec5eca8afdc457b","head":{"label":"datopian:features/milestone-commands","ref":"features/milestone-commands","sha":"3fb38e89ee3944a0ea7dedd22ec5eca8afdc457b","user":{"login":"datopian","id":24832801,"avatar_url":"https://avatars2.githubusercontent.com/u/24832801?v=4","gravatar_id":"","url":"https://api.github.com/users/datopian","html_url":"https://github.com/datopian","followers_url":"https://api.github.com/users/datopian/followers","following_url":"https://api.github.com/users/datopian/following{/other_user}","gists_url":"https://api.github.com/users/datopian/gists{/gist_id}","starred_url":"https://api.github.com/users/datopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datopian/subscriptions","organizations_url":"https://api.github.com/users/datopian/orgs","repos_url":"https://api.github.com/users/datopian/repos","events_url":"https://api.github.com/users/datopian/events{/privacy}","received_events_url":"https://api.github.com/users/datopian/received_events","type":"Organization","site_admin":false},"repo":{"id":84362882,"name":"ourbot","full_name":"datopian/ourbot","owner":{"login":"datopian","id":24832801,"avatar_url":"https://avatars2.githubusercontent.com/u/24832801?v=4","gravatar_id":"","url":"https://api.github.com/users/datopian","html_url":"https://github.com/datopian","followers_url":"https://api.github.com/users/datopian/followers","following_url":"https://api.github.com/users/datopian/following{/other_user}","gists_url":"https://api.github.com/users/datopian/gists{/gist_id}","starred_url":"https://api.github.com/users/datopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datopian/subscriptions","organizations_url":"https://api.github.com/users/datopian/orgs","repos_url":"https://api.github.com/users/datopian/repos","events_url":"https://api.github.com/users/datopian/events{/privacy}","received_events_url":"https://api.github.com/users/datopian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datopian/ourbot","description":"Our personalized bot","fork":false,"url":"https://api.github.com/repos/datopian/ourbot","forks_url":"https://api.github.com/repos/datopian/ourbot/forks","keys_url":"https://api.github.com/repos/datopian/ourbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datopian/ourbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datopian/ourbot/teams","hooks_url":"https://api.github.com/repos/datopian/ourbot/hooks","issue_events_url":"https://api.github.com/repos/datopian/ourbot/issues/events{/number}","events_url":"https://api.github.com/repos/datopian/ourbot/events","assignees_url":"https://api.github.com/repos/datopian/ourbot/assignees{/user}","branches_url":"https://api.github.com/repos/datopian/ourbot/branches{/branch}","tags_url":"https://api.github.com/repos/datopian/ourbot/tags","blobs_url":"https://api.github.com/repos/datopian/ourbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datopian/ourbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datopian/ourbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/datopian/ourbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datopian/ourbot/statuses/{sha}","languages_url":"https://api.github.com/repos/datopian/ourbot/languages","stargazers_url":"https://api.github.com/repos/datopian/ourbot/stargazers","contributors_url":"https://api.github.com/repos/datopian/ourbot/contributors","subscribers_url":"https://api.github.com/repos/datopian/ourbot/subscribers","subscription_url":"https://api.github.com/repos/datopian/ourbot/subscription","commits_url":"https://api.github.com/repos/datopian/ourbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/datopian/ourbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/datopian/ourbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/datopian/ourbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/datopian/ourbot/contents/{+path}","compare_url":"https://api.github.com/repos/datopian/ourbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datopian/ourbot/merges","archive_url":"https://api.github.com/repos/datopian/ourbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datopian/ourbot/downloads","issues_url":"https://api.github.com/repos/datopian/ourbot/issues{/number}","pulls_url":"https://api.github.com/repos/datopian/ourbot/pulls{/number}","milestones_url":"https://api.github.com/repos/datopian/ourbot/milestones{/number}","notifications_url":"https://api.github.com/repos/datopian/ourbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datopian/ourbot/labels{/name}","releases_url":"https://api.github.com/repos/datopian/ourbot/releases{/id}","deployments_url":"https://api.github.com/repos/datopian/ourbot/deployments","created_at":"2017-03-08T20:24:59Z","updated_at":"2017-07-31T19:29:26Z","pushed_at":"2017-08-25T10:31:47Z","git_url":"git://github.com/datopian/ourbot.git","ssh_url":"[email protected]:datopian/ourbot.git","clone_url":"https://github.com/datopian/ourbot.git","svn_url":"https://github.com/datopian/ourbot","homepage":null,"size":79,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":5,"default_branch":"master"}},"base":{"label":"datopian:master","ref":"master","sha":"6587b19fb5872acff15cbe252ad1dba819c004e8","user":{"login":"datopian","id":24832801,"avatar_url":"https://avatars2.githubusercontent.com/u/24832801?v=4","gravatar_id":"","url":"https://api.github.com/users/datopian","html_url":"https://github.com/datopian","followers_url":"https://api.github.com/users/datopian/followers","following_url":"https://api.github.com/users/datopian/following{/other_user}","gists_url":"https://api.github.com/users/datopian/gists{/gist_id}","starred_url":"https://api.github.com/users/datopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datopian/subscriptions","organizations_url":"https://api.github.com/users/datopian/orgs","repos_url":"https://api.github.com/users/datopian/repos","events_url":"https://api.github.com/users/datopian/events{/privacy}","received_events_url":"https://api.github.com/users/datopian/received_events","type":"Organization","site_admin":false},"repo":{"id":84362882,"name":"ourbot","full_name":"datopian/ourbot","owner":{"login":"datopian","id":24832801,"avatar_url":"https://avatars2.githubusercontent.com/u/24832801?v=4","gravatar_id":"","url":"https://api.github.com/users/datopian","html_url":"https://github.com/datopian","followers_url":"https://api.github.com/users/datopian/followers","following_url":"https://api.github.com/users/datopian/following{/other_user}","gists_url":"https://api.github.com/users/datopian/gists{/gist_id}","starred_url":"https://api.github.com/users/datopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datopian/subscriptions","organizations_url":"https://api.github.com/users/datopian/orgs","repos_url":"https://api.github.com/users/datopian/repos","events_url":"https://api.github.com/users/datopian/events{/privacy}","received_events_url":"https://api.github.com/users/datopian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datopian/ourbot","description":"Our personalized bot","fork":false,"url":"https://api.github.com/repos/datopian/ourbot","forks_url":"https://api.github.com/repos/datopian/ourbot/forks","keys_url":"https://api.github.com/repos/datopian/ourbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datopian/ourbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datopian/ourbot/teams","hooks_url":"https://api.github.com/repos/datopian/ourbot/hooks","issue_events_url":"https://api.github.com/repos/datopian/ourbot/issues/events{/number}","events_url":"https://api.github.com/repos/datopian/ourbot/events","assignees_url":"https://api.github.com/repos/datopian/ourbot/assignees{/user}","branches_url":"https://api.github.com/repos/datopian/ourbot/branches{/branch}","tags_url":"https://api.github.com/repos/datopian/ourbot/tags","blobs_url":"https://api.github.com/repos/datopian/ourbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datopian/ourbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datopian/ourbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/datopian/ourbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datopian/ourbot/statuses/{sha}","languages_url":"https://api.github.com/repos/datopian/ourbot/languages","stargazers_url":"https://api.github.com/repos/datopian/ourbot/stargazers","contributors_url":"https://api.github.com/repos/datopian/ourbot/contributors","subscribers_url":"https://api.github.com/repos/datopian/ourbot/subscribers","subscription_url":"https://api.github.com/repos/datopian/ourbot/subscription","commits_url":"https://api.github.com/repos/datopian/ourbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/datopian/ourbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/datopian/ourbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/datopian/ourbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/datopian/ourbot/contents/{+path}","compare_url":"https://api.github.com/repos/datopian/ourbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datopian/ourbot/merges","archive_url":"https://api.github.com/repos/datopian/ourbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datopian/ourbot/downloads","issues_url":"https://api.github.com/repos/datopian/ourbot/issues{/number}","pulls_url":"https://api.github.com/repos/datopian/ourbot/pulls{/number}","milestones_url":"https://api.github.com/repos/datopian/ourbot/milestones{/number}","notifications_url":"https://api.github.com/repos/datopian/ourbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datopian/ourbot/labels{/name}","releases_url":"https://api.github.com/repos/datopian/ourbot/releases{/id}","deployments_url":"https://api.github.com/repos/datopian/ourbot/deployments","created_at":"2017-03-08T20:24:59Z","updated_at":"2017-07-31T19:29:26Z","pushed_at":"2017-08-25T10:31:47Z","git_url":"git://github.com/datopian/ourbot.git","ssh_url":"[email protected]:datopian/ourbot.git","clone_url":"https://github.com/datopian/ourbot.git","svn_url":"https://github.com/datopian/ourbot","homepage":null,"size":79,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datopian/ourbot/pulls/57"},"html":{"href":"https://github.com/datopian/ourbot/pull/57"},"issue":{"href":"https://api.github.com/repos/datopian/ourbot/issues/57"},"comments":{"href":"https://api.github.com/repos/datopian/ourbot/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/datopian/ourbot/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/datopian/ourbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datopian/ourbot/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/datopian/ourbot/statuses/3fb38e89ee3944a0ea7dedd22ec5eca8afdc457b"}}}} | {
"id": 84362882,
"name": "datopian/ourbot",
"url": "https://api.github.com/repos/datopian/ourbot"
} | {
"id": 15143785,
"login": "zelima",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15143785?",
"url": "https://api.github.com/users/zelima"
} | {
"id": 24832801,
"login": "datopian",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24832801?",
"url": "https://api.github.com/orgs/datopian"
} | 2017-08-25T10:49:53 | 6511671579 | {"actor":{"display_login":"zelima"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/dbsystel/1BahnQL/pulls/comments/128431087","pull_request_review_id":51107719,"id":128431087,"diff_hunk":"@@ -32,23 +33,30 @@ const parkingspaceService = new ParkingspaceService(parkingspaceLoader);\n const operationLocationService = new OperationLocationService(operationLocationLoader);\n const stationService = new StationService(stationLoader);\n const nearbyStationService = new NearbyStationService(stationService);\n+const routingService = new RoutingService();\n \n // Relationships\n stationService.relationships = new StationRelationships(parkingspaceService);\n parkingspaceService.relationships = new ParkingspaceRelationships(parkingspaceService, stationService);\n+routingService.relationships = new RouteRelationships(stationService);\n \n // Queries\n const root = {\n- routeSearch: (args) => {\n- const routeSearch = new TrainRouteSearch(args.from, args.to).options;\n- return routeSearch.then(options => [options[0]]);\n- },\n parkingSpace: args => parkingspaceService.parkingspaceBySpaceId(args.id),\n stationWith: args => stationService.stationByEvaId(args.evaId),\n search: args => ({ stations: stationService.searchStations(args.searchTerm), operationLocations: operationLocationService.searchOperationLocations(args.searchTerm) }),\n nearby: args => new NearbyQuery(args.latitude, args.longitude, nearbyStationService, parkingspaceService),\n };\n \n+const experimental = process.env.experimental","path":"index.js","position":43,"original_position":43,"commit_id":"9beab29db14ad697b73f0941dd9dadfcf68e3a84","original_commit_id":"9beab29db14ad697b73f0941dd9dadfcf68e3a84","user":{"login":"lightsprint09","id":3703083,"avatar_url":"https://avatars1.githubusercontent.com/u/3703083?v=4","gravatar_id":"","url":"https://api.github.com/users/lightsprint09","html_url":"https://github.com/lightsprint09","followers_url":"https://api.github.com/users/lightsprint09/followers","following_url":"https://api.github.com/users/lightsprint09/following{/other_user}","gists_url":"https://api.github.com/users/lightsprint09/gists{/gist_id}","starred_url":"https://api.github.com/users/lightsprint09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightsprint09/subscriptions","organizations_url":"https://api.github.com/users/lightsprint09/orgs","repos_url":"https://api.github.com/users/lightsprint09/repos","events_url":"https://api.github.com/users/lightsprint09/events{/privacy}","received_events_url":"https://api.github.com/users/lightsprint09/received_events","type":"User","site_admin":false},"body":"it is only for queries ","created_at":"2017-07-20T06:02:25Z","updated_at":"2017-07-20T06:02:25Z","html_url":"https://github.com/dbsystel/1BahnQL/pull/18#discussion_r128431087","pull_request_url":"https://api.github.com/repos/dbsystel/1BahnQL/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/dbsystel/1BahnQL/pulls/comments/128431087"},"html":{"href":"https://github.com/dbsystel/1BahnQL/pull/18#discussion_r128431087"},"pull_request":{"href":"https://api.github.com/repos/dbsystel/1BahnQL/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/dbsystel/1BahnQL/pulls/18","id":131072836,"html_url":"https://github.com/dbsystel/1BahnQL/pull/18","diff_url":"https://github.com/dbsystel/1BahnQL/pull/18.diff","patch_url":"https://github.com/dbsystel/1BahnQL/pull/18.patch","issue_url":"https://api.github.com/repos/dbsystel/1BahnQL/issues/18","number":18,"state":"open","locked":false,"title":"Refactor routing a bit","user":{"login":"lightsprint09","id":3703083,"avatar_url":"https://avatars1.githubusercontent.com/u/3703083?v=4","gravatar_id":"","url":"https://api.github.com/users/lightsprint09","html_url":"https://github.com/lightsprint09","followers_url":"https://api.github.com/users/lightsprint09/followers","following_url":"https://api.github.com/users/lightsprint09/following{/other_user}","gists_url":"https://api.github.com/users/lightsprint09/gists{/gist_id}","starred_url":"https://api.github.com/users/lightsprint09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightsprint09/subscriptions","organizations_url":"https://api.github.com/users/lightsprint09/orgs","repos_url":"https://api.github.com/users/lightsprint09/repos","events_url":"https://api.github.com/users/lightsprint09/events{/privacy}","received_events_url":"https://api.github.com/users/lightsprint09/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-18T12:20:17Z","updated_at":"2017-07-20T06:02:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8b46c8402380604d2162f9fc036cb6381748556","assignee":{"login":"lightsprint09","id":3703083,"avatar_url":"https://avatars1.githubusercontent.com/u/3703083?v=4","gravatar_id":"","url":"https://api.github.com/users/lightsprint09","html_url":"https://github.com/lightsprint09","followers_url":"https://api.github.com/users/lightsprint09/followers","following_url":"https://api.github.com/users/lightsprint09/following{/other_user}","gists_url":"https://api.github.com/users/lightsprint09/gists{/gist_id}","starred_url":"https://api.github.com/users/lightsprint09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightsprint09/subscriptions","organizations_url":"https://api.github.com/users/lightsprint09/orgs","repos_url":"https://api.github.com/users/lightsprint09/repos","events_url":"https://api.github.com/users/lightsprint09/events{/privacy}","received_events_url":"https://api.github.com/users/lightsprint09/received_events","type":"User","site_admin":false},"assignees":[{"login":"lightsprint09","id":3703083,"avatar_url":"https://avatars1.githubusercontent.com/u/3703083?v=4","gravatar_id":"","url":"https://api.github.com/users/lightsprint09","html_url":"https://github.com/lightsprint09","followers_url":"https://api.github.com/users/lightsprint09/followers","following_url":"https://api.github.com/users/lightsprint09/following{/other_user}","gists_url":"https://api.github.com/users/lightsprint09/gists{/gist_id}","starred_url":"https://api.github.com/users/lightsprint09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightsprint09/subscriptions","organizations_url":"https://api.github.com/users/lightsprint09/orgs","repos_url":"https://api.github.com/users/lightsprint09/repos","events_url":"https://api.github.com/users/lightsprint09/events{/privacy}","received_events_url":"https://api.github.com/users/lightsprint09/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dbsystel/1BahnQL/pulls/18/commits","review_comments_url":"https://api.github.com/repos/dbsystel/1BahnQL/pulls/18/comments","review_comment_url":"https://api.github.com/repos/dbsystel/1BahnQL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dbsystel/1BahnQL/issues/18/comments","statuses_url":"https://api.github.com/repos/dbsystel/1BahnQL/statuses/9beab29db14ad697b73f0941dd9dadfcf68e3a84","head":{"label":"dbsystel:feature/experimental-routing","ref":"feature/experimental-routing","sha":"9beab29db14ad697b73f0941dd9dadfcf68e3a84","user":{"login":"dbsystel","id":20337168,"avatar_url":"https://avatars0.githubusercontent.com/u/20337168?v=4","gravatar_id":"","url":"https://api.github.com/users/dbsystel","html_url":"https://github.com/dbsystel","followers_url":"https://api.github.com/users/dbsystel/followers","following_url":"https://api.github.com/users/dbsystel/following{/other_user}","gists_url":"https://api.github.com/users/dbsystel/gists{/gist_id}","starred_url":"https://api.github.com/users/dbsystel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbsystel/subscriptions","organizations_url":"https://api.github.com/users/dbsystel/orgs","repos_url":"https://api.github.com/users/dbsystel/repos","events_url":"https://api.github.com/users/dbsystel/events{/privacy}","received_events_url":"https://api.github.com/users/dbsystel/received_events","type":"Organization","site_admin":false},"repo":{"id":90628690,"name":"1BahnQL","full_name":"dbsystel/1BahnQL","owner":{"login":"dbsystel","id":20337168,"avatar_url":"https://avatars0.githubusercontent.com/u/20337168?v=4","gravatar_id":"","url":"https://api.github.com/users/dbsystel","html_url":"https://github.com/dbsystel","followers_url":"https://api.github.com/users/dbsystel/followers","following_url":"https://api.github.com/users/dbsystel/following{/other_user}","gists_url":"https://api.github.com/users/dbsystel/gists{/gist_id}","starred_url":"https://api.github.com/users/dbsystel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbsystel/subscriptions","organizations_url":"https://api.github.com/users/dbsystel/orgs","repos_url":"https://api.github.com/users/dbsystel/repos","events_url":"https://api.github.com/users/dbsystel/events{/privacy}","received_events_url":"https://api.github.com/users/dbsystel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dbsystel/1BahnQL","description":"Single unified API for all DBOpenData APIs implemented with GraphQL.","fork":false,"url":"https://api.github.com/repos/dbsystel/1BahnQL","forks_url":"https://api.github.com/repos/dbsystel/1BahnQL/forks","keys_url":"https://api.github.com/repos/dbsystel/1BahnQL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbsystel/1BahnQL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbsystel/1BahnQL/teams","hooks_url":"https://api.github.com/repos/dbsystel/1BahnQL/hooks","issue_events_url":"https://api.github.com/repos/dbsystel/1BahnQL/issues/events{/number}","events_url":"https://api.github.com/repos/dbsystel/1BahnQL/events","assignees_url":"https://api.github.com/repos/dbsystel/1BahnQL/assignees{/user}","branches_url":"https://api.github.com/repos/dbsystel/1BahnQL/branches{/branch}","tags_url":"https://api.github.com/repos/dbsystel/1BahnQL/tags","blobs_url":"https://api.github.com/repos/dbsystel/1BahnQL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbsystel/1BahnQL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbsystel/1BahnQL/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbsystel/1BahnQL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbsystel/1BahnQL/statuses/{sha}","languages_url":"https://api.github.com/repos/dbsystel/1BahnQL/languages","stargazers_url":"https://api.github.com/repos/dbsystel/1BahnQL/stargazers","contributors_url":"https://api.github.com/repos/dbsystel/1BahnQL/contributors","subscribers_url":"https://api.github.com/repos/dbsystel/1BahnQL/subscribers","subscription_url":"https://api.github.com/repos/dbsystel/1BahnQL/subscription","commits_url":"https://api.github.com/repos/dbsystel/1BahnQL/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbsystel/1BahnQL/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbsystel/1BahnQL/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbsystel/1BahnQL/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbsystel/1BahnQL/contents/{+path}","compare_url":"https://api.github.com/repos/dbsystel/1BahnQL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbsystel/1BahnQL/merges","archive_url":"https://api.github.com/repos/dbsystel/1BahnQL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbsystel/1BahnQL/downloads","issues_url":"https://api.github.com/repos/dbsystel/1BahnQL/issues{/number}","pulls_url":"https://api.github.com/repos/dbsystel/1BahnQL/pulls{/number}","milestones_url":"https://api.github.com/repos/dbsystel/1BahnQL/milestones{/number}","notifications_url":"https://api.github.com/repos/dbsystel/1BahnQL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbsystel/1BahnQL/labels{/name}","releases_url":"https://api.github.com/repos/dbsystel/1BahnQL/releases{/id}","deployments_url":"https://api.github.com/repos/dbsystel/1BahnQL/deployments","created_at":"2017-05-08T13:02:30Z","updated_at":"2017-07-18T12:08:16Z","pushed_at":"2017-07-20T05:55:30Z","git_url":"git://github.com/dbsystel/1BahnQL.git","ssh_url":"[email protected]:dbsystel/1BahnQL.git","clone_url":"https://github.com/dbsystel/1BahnQL.git","svn_url":"https://github.com/dbsystel/1BahnQL","homepage":"","size":381,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":12,"forks":1,"open_issues":12,"watchers":5,"default_branch":"develop"}},"base":{"label":"dbsystel:develop","ref":"develop","sha":"bb0aa28bd54036522c1c1ecf8243ded42f07f405","user":{"login":"dbsystel","id":20337168,"avatar_url":"https://avatars0.githubusercontent.com/u/20337168?v=4","gravatar_id":"","url":"https://api.github.com/users/dbsystel","html_url":"https://github.com/dbsystel","followers_url":"https://api.github.com/users/dbsystel/followers","following_url":"https://api.github.com/users/dbsystel/following{/other_user}","gists_url":"https://api.github.com/users/dbsystel/gists{/gist_id}","starred_url":"https://api.github.com/users/dbsystel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbsystel/subscriptions","organizations_url":"https://api.github.com/users/dbsystel/orgs","repos_url":"https://api.github.com/users/dbsystel/repos","events_url":"https://api.github.com/users/dbsystel/events{/privacy}","received_events_url":"https://api.github.com/users/dbsystel/received_events","type":"Organization","site_admin":false},"repo":{"id":90628690,"name":"1BahnQL","full_name":"dbsystel/1BahnQL","owner":{"login":"dbsystel","id":20337168,"avatar_url":"https://avatars0.githubusercontent.com/u/20337168?v=4","gravatar_id":"","url":"https://api.github.com/users/dbsystel","html_url":"https://github.com/dbsystel","followers_url":"https://api.github.com/users/dbsystel/followers","following_url":"https://api.github.com/users/dbsystel/following{/other_user}","gists_url":"https://api.github.com/users/dbsystel/gists{/gist_id}","starred_url":"https://api.github.com/users/dbsystel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbsystel/subscriptions","organizations_url":"https://api.github.com/users/dbsystel/orgs","repos_url":"https://api.github.com/users/dbsystel/repos","events_url":"https://api.github.com/users/dbsystel/events{/privacy}","received_events_url":"https://api.github.com/users/dbsystel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dbsystel/1BahnQL","description":"Single unified API for all DBOpenData APIs implemented with GraphQL.","fork":false,"url":"https://api.github.com/repos/dbsystel/1BahnQL","forks_url":"https://api.github.com/repos/dbsystel/1BahnQL/forks","keys_url":"https://api.github.com/repos/dbsystel/1BahnQL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbsystel/1BahnQL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbsystel/1BahnQL/teams","hooks_url":"https://api.github.com/repos/dbsystel/1BahnQL/hooks","issue_events_url":"https://api.github.com/repos/dbsystel/1BahnQL/issues/events{/number}","events_url":"https://api.github.com/repos/dbsystel/1BahnQL/events","assignees_url":"https://api.github.com/repos/dbsystel/1BahnQL/assignees{/user}","branches_url":"https://api.github.com/repos/dbsystel/1BahnQL/branches{/branch}","tags_url":"https://api.github.com/repos/dbsystel/1BahnQL/tags","blobs_url":"https://api.github.com/repos/dbsystel/1BahnQL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbsystel/1BahnQL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbsystel/1BahnQL/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbsystel/1BahnQL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbsystel/1BahnQL/statuses/{sha}","languages_url":"https://api.github.com/repos/dbsystel/1BahnQL/languages","stargazers_url":"https://api.github.com/repos/dbsystel/1BahnQL/stargazers","contributors_url":"https://api.github.com/repos/dbsystel/1BahnQL/contributors","subscribers_url":"https://api.github.com/repos/dbsystel/1BahnQL/subscribers","subscription_url":"https://api.github.com/repos/dbsystel/1BahnQL/subscription","commits_url":"https://api.github.com/repos/dbsystel/1BahnQL/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbsystel/1BahnQL/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbsystel/1BahnQL/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbsystel/1BahnQL/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbsystel/1BahnQL/contents/{+path}","compare_url":"https://api.github.com/repos/dbsystel/1BahnQL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbsystel/1BahnQL/merges","archive_url":"https://api.github.com/repos/dbsystel/1BahnQL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbsystel/1BahnQL/downloads","issues_url":"https://api.github.com/repos/dbsystel/1BahnQL/issues{/number}","pulls_url":"https://api.github.com/repos/dbsystel/1BahnQL/pulls{/number}","milestones_url":"https://api.github.com/repos/dbsystel/1BahnQL/milestones{/number}","notifications_url":"https://api.github.com/repos/dbsystel/1BahnQL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbsystel/1BahnQL/labels{/name}","releases_url":"https://api.github.com/repos/dbsystel/1BahnQL/releases{/id}","deployments_url":"https://api.github.com/repos/dbsystel/1BahnQL/deployments","created_at":"2017-05-08T13:02:30Z","updated_at":"2017-07-18T12:08:16Z","pushed_at":"2017-07-20T05:55:30Z","git_url":"git://github.com/dbsystel/1BahnQL.git","ssh_url":"[email protected]:dbsystel/1BahnQL.git","clone_url":"https://github.com/dbsystel/1BahnQL.git","svn_url":"https://github.com/dbsystel/1BahnQL","homepage":"","size":381,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":12,"forks":1,"open_issues":12,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dbsystel/1BahnQL/pulls/18"},"html":{"href":"https://github.com/dbsystel/1BahnQL/pull/18"},"issue":{"href":"https://api.github.com/repos/dbsystel/1BahnQL/issues/18"},"comments":{"href":"https://api.github.com/repos/dbsystel/1BahnQL/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/dbsystel/1BahnQL/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/dbsystel/1BahnQL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dbsystel/1BahnQL/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/dbsystel/1BahnQL/statuses/9beab29db14ad697b73f0941dd9dadfcf68e3a84"}}}} | {
"id": 90628690,
"name": "dbsystel/1BahnQL",
"url": "https://api.github.com/repos/dbsystel/1BahnQL"
} | {
"id": 3703083,
"login": "lightsprint09",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3703083?",
"url": "https://api.github.com/users/lightsprint09"
} | {
"id": 20337168,
"login": "dbsystel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20337168?",
"url": "https://api.github.com/orgs/dbsystel"
} | 2017-07-20T06:02:25 | 6292524663 | {"actor":{"display_login":"lightsprint09"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/124528522","pull_request_review_id":46824514,"id":124528522,"diff_hunk":"@@ -129,11 +115,20 @@ void check_invariant(\n #else\n out << \"Backtraces not supported\\n\" << std::flush;\n #endif\n+}\n \n-\n-#ifdef CPROVER_INVARIANT_PRINT_STACK_TRACE\n- abort();\n-#else\n- throw invariant_failedt(out.str());\n-#endif\n+/// Returns a backtrace\n+///\n+/// \\param file : C string giving the name of the file.\n+/// \\param function : C string giving the name of the function.\n+/// \\param line : The line number of the invariant\n+/// \\return backtrace with a file / function / line header.\n+std::string get_backtrace(\n+ const char * const file,\n+ const char * const function,","path":"src/util/invariant.cpp","position":57,"original_position":57,"commit_id":"3871f8f343536cc67093d39014f991bca4afd922","original_commit_id":"3871f8f343536cc67093d39014f991bca4afd922","user":{"login":"tautschnig","id":1144736,"avatar_url":"https://avatars0.githubusercontent.com/u/1144736?v=3","gravatar_id":"","url":"https://api.github.com/users/tautschnig","html_url":"https://github.com/tautschnig","followers_url":"https://api.github.com/users/tautschnig/followers","following_url":"https://api.github.com/users/tautschnig/following{/other_user}","gists_url":"https://api.github.com/users/tautschnig/gists{/gist_id}","starred_url":"https://api.github.com/users/tautschnig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tautschnig/subscriptions","organizations_url":"https://api.github.com/users/tautschnig/orgs","repos_url":"https://api.github.com/users/tautschnig/repos","events_url":"https://api.github.com/users/tautschnig/events{/privacy}","received_events_url":"https://api.github.com/users/tautschnig/received_events","type":"User","site_admin":false},"body":"But then the compiler would happily build `const std::string` objects from those?","created_at":"2017-06-28T12:37:58Z","updated_at":"2017-06-28T12:37:58Z","html_url":"https://github.com/diffblue/cbmc/pull/1063#discussion_r124528522","pull_request_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1063","_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/124528522"},"html":{"href":"https://github.com/diffblue/cbmc/pull/1063#discussion_r124528522"},"pull_request":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1063"}}},"pull_request":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/1063","id":127655927,"html_url":"https://github.com/diffblue/cbmc/pull/1063","diff_url":"https://github.com/diffblue/cbmc/pull/1063.diff","patch_url":"https://github.com/diffblue/cbmc/pull/1063.patch","issue_url":"https://api.github.com/repos/diffblue/cbmc/issues/1063","number":1063,"state":"open","locked":false,"title":"Improved invariants","user":{"login":"smowton","id":283483,"avatar_url":"https://avatars0.githubusercontent.com/u/283483?v=3","gravatar_id":"","url":"https://api.github.com/users/smowton","html_url":"https://github.com/smowton","followers_url":"https://api.github.com/users/smowton/followers","following_url":"https://api.github.com/users/smowton/following{/other_user}","gists_url":"https://api.github.com/users/smowton/gists{/gist_id}","starred_url":"https://api.github.com/users/smowton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smowton/subscriptions","organizations_url":"https://api.github.com/users/smowton/orgs","repos_url":"https://api.github.com/users/smowton/repos","events_url":"https://api.github.com/users/smowton/events{/privacy}","received_events_url":"https://api.github.com/users/smowton/received_events","type":"User","site_admin":false},"body":"Based on recent discussions about the shortcomings of the `INVARIANT` family of macros, here are some improvements:\r\n\r\n1. Most importantly, invariants can now be structured. `INVARIANT(false, \"Hello world\")` still works and produces an `invariant_failedt` as before, but one can also derive from `invariant_failedt`, add fields to describe an error in a more useful way, and override `pretty_print` to render them into a human-readable error message. This means that even before catching invariants becomes allowed practice we can be producing structured invariants ready for if and when that changes. The update to tests demonstrates this feature in use.\r\n2. For consistency, the throw / abort behaviour of invariants is no longer dependent on compile-time conditional definitions; it will now function one way and do that dependably on both development and production builds, hopefully reducing the chance of a surprise in production. Currently it *always aborts* owing to @martin-cs concerns that a `catch(...)` may accidentally swallow in invariant it didn't mean to.\r\n3. (Incidental) the `reason` expression, whether structured or a simple string, is now lazily evaluated (e.g. `INVARIANT(x==y, str1+str2)` will only perform the string concatenation if the test fails).\r\n\r\nPlease get in there *now* with your design concerns rather than objecting to down-the-line PRs that use these features!","created_at":"2017-06-27T10:03:14Z","updated_at":"2017-06-28T12:37:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5fb3d797717e7a88d8377c6a1eecc2962ac1711","assignee":null,"assignees":[],"requested_reviewers":[{"login":"reuk","id":3016418,"avatar_url":"https://avatars2.githubusercontent.com/u/3016418?v=3","gravatar_id":"","url":"https://api.github.com/users/reuk","html_url":"https://github.com/reuk","followers_url":"https://api.github.com/users/reuk/followers","following_url":"https://api.github.com/users/reuk/following{/other_user}","gists_url":"https://api.github.com/users/reuk/gists{/gist_id}","starred_url":"https://api.github.com/users/reuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reuk/subscriptions","organizations_url":"https://api.github.com/users/reuk/orgs","repos_url":"https://api.github.com/users/reuk/repos","events_url":"https://api.github.com/users/reuk/events{/privacy}","received_events_url":"https://api.github.com/users/reuk/received_events","type":"User","site_admin":false},{"login":"martin-cs","id":5333188,"avatar_url":"https://avatars3.githubusercontent.com/u/5333188?v=3","gravatar_id":"","url":"https://api.github.com/users/martin-cs","html_url":"https://github.com/martin-cs","followers_url":"https://api.github.com/users/martin-cs/followers","following_url":"https://api.github.com/users/martin-cs/following{/other_user}","gists_url":"https://api.github.com/users/martin-cs/gists{/gist_id}","starred_url":"https://api.github.com/users/martin-cs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martin-cs/subscriptions","organizations_url":"https://api.github.com/users/martin-cs/orgs","repos_url":"https://api.github.com/users/martin-cs/repos","events_url":"https://api.github.com/users/martin-cs/events{/privacy}","received_events_url":"https://api.github.com/users/martin-cs/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1063/commits","review_comments_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1063/comments","review_comment_url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diffblue/cbmc/issues/1063/comments","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/3871f8f343536cc67093d39014f991bca4afd922","head":{"label":"smowton:smowton/feature/improved_invariants","ref":"smowton/feature/improved_invariants","sha":"3871f8f343536cc67093d39014f991bca4afd922","user":{"login":"smowton","id":283483,"avatar_url":"https://avatars0.githubusercontent.com/u/283483?v=3","gravatar_id":"","url":"https://api.github.com/users/smowton","html_url":"https://github.com/smowton","followers_url":"https://api.github.com/users/smowton/followers","following_url":"https://api.github.com/users/smowton/following{/other_user}","gists_url":"https://api.github.com/users/smowton/gists{/gist_id}","starred_url":"https://api.github.com/users/smowton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smowton/subscriptions","organizations_url":"https://api.github.com/users/smowton/orgs","repos_url":"https://api.github.com/users/smowton/repos","events_url":"https://api.github.com/users/smowton/events{/privacy}","received_events_url":"https://api.github.com/users/smowton/received_events","type":"User","site_admin":false},"repo":{"id":75178953,"name":"cbmc","full_name":"smowton/cbmc","owner":{"login":"smowton","id":283483,"avatar_url":"https://avatars0.githubusercontent.com/u/283483?v=3","gravatar_id":"","url":"https://api.github.com/users/smowton","html_url":"https://github.com/smowton","followers_url":"https://api.github.com/users/smowton/followers","following_url":"https://api.github.com/users/smowton/following{/other_user}","gists_url":"https://api.github.com/users/smowton/gists{/gist_id}","starred_url":"https://api.github.com/users/smowton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smowton/subscriptions","organizations_url":"https://api.github.com/users/smowton/orgs","repos_url":"https://api.github.com/users/smowton/repos","events_url":"https://api.github.com/users/smowton/events{/privacy}","received_events_url":"https://api.github.com/users/smowton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smowton/cbmc","description":"C Bounded Model Checker","fork":true,"url":"https://api.github.com/repos/smowton/cbmc","forks_url":"https://api.github.com/repos/smowton/cbmc/forks","keys_url":"https://api.github.com/repos/smowton/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smowton/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smowton/cbmc/teams","hooks_url":"https://api.github.com/repos/smowton/cbmc/hooks","issue_events_url":"https://api.github.com/repos/smowton/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/smowton/cbmc/events","assignees_url":"https://api.github.com/repos/smowton/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/smowton/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/smowton/cbmc/tags","blobs_url":"https://api.github.com/repos/smowton/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smowton/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smowton/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/smowton/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smowton/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/smowton/cbmc/languages","stargazers_url":"https://api.github.com/repos/smowton/cbmc/stargazers","contributors_url":"https://api.github.com/repos/smowton/cbmc/contributors","subscribers_url":"https://api.github.com/repos/smowton/cbmc/subscribers","subscription_url":"https://api.github.com/repos/smowton/cbmc/subscription","commits_url":"https://api.github.com/repos/smowton/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/smowton/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/smowton/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/smowton/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/smowton/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/smowton/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smowton/cbmc/merges","archive_url":"https://api.github.com/repos/smowton/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smowton/cbmc/downloads","issues_url":"https://api.github.com/repos/smowton/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/smowton/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/smowton/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/smowton/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smowton/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/smowton/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/smowton/cbmc/deployments","created_at":"2016-11-30T11:02:38Z","updated_at":"2016-11-30T11:02:46Z","pushed_at":"2017-06-28T12:23:07Z","git_url":"git://github.com/smowton/cbmc.git","ssh_url":"[email protected]:smowton/cbmc.git","clone_url":"https://github.com/smowton/cbmc.git","svn_url":"https://github.com/smowton/cbmc","homepage":"http://www.cprover.org/cbmc","size":26897,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"diffblue:master","ref":"master","sha":"e0b45158389556bc0f705ba3400a358a367bd9ef","user":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars3.githubusercontent.com/u/17216098?v=3","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"repo":{"id":51877056,"name":"cbmc","full_name":"diffblue/cbmc","owner":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars3.githubusercontent.com/u/17216098?v=3","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diffblue/cbmc","description":"C Bounded Model Checker","fork":false,"url":"https://api.github.com/repos/diffblue/cbmc","forks_url":"https://api.github.com/repos/diffblue/cbmc/forks","keys_url":"https://api.github.com/repos/diffblue/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diffblue/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diffblue/cbmc/teams","hooks_url":"https://api.github.com/repos/diffblue/cbmc/hooks","issue_events_url":"https://api.github.com/repos/diffblue/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/diffblue/cbmc/events","assignees_url":"https://api.github.com/repos/diffblue/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/diffblue/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/diffblue/cbmc/tags","blobs_url":"https://api.github.com/repos/diffblue/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diffblue/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diffblue/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/diffblue/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/diffblue/cbmc/languages","stargazers_url":"https://api.github.com/repos/diffblue/cbmc/stargazers","contributors_url":"https://api.github.com/repos/diffblue/cbmc/contributors","subscribers_url":"https://api.github.com/repos/diffblue/cbmc/subscribers","subscription_url":"https://api.github.com/repos/diffblue/cbmc/subscription","commits_url":"https://api.github.com/repos/diffblue/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/diffblue/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/diffblue/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/diffblue/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/diffblue/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/diffblue/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diffblue/cbmc/merges","archive_url":"https://api.github.com/repos/diffblue/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diffblue/cbmc/downloads","issues_url":"https://api.github.com/repos/diffblue/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/diffblue/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/diffblue/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/diffblue/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diffblue/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/diffblue/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/diffblue/cbmc/deployments","created_at":"2016-02-16T23:03:52Z","updated_at":"2017-06-28T11:31:48Z","pushed_at":"2017-06-28T12:23:08Z","git_url":"git://github.com/diffblue/cbmc.git","ssh_url":"[email protected]:diffblue/cbmc.git","clone_url":"https://github.com/diffblue/cbmc.git","svn_url":"https://github.com/diffblue/cbmc","homepage":"http://www.cprover.org/cbmc","size":20785,"stargazers_count":53,"watchers_count":53,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":259,"forks":60,"open_issues":259,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1063"},"html":{"href":"https://github.com/diffblue/cbmc/pull/1063"},"issue":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/1063"},"comments":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/1063/comments"},"review_comments":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1063/comments"},"review_comment":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1063/commits"},"statuses":{"href":"https://api.github.com/repos/diffblue/cbmc/statuses/3871f8f343536cc67093d39014f991bca4afd922"}}}} | {
"id": 51877056,
"name": "diffblue/cbmc",
"url": "https://api.github.com/repos/diffblue/cbmc"
} | {
"id": 1144736,
"login": "tautschnig",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1144736?",
"url": "https://api.github.com/users/tautschnig"
} | {
"id": 17216098,
"login": "diffblue",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17216098?",
"url": "https://api.github.com/orgs/diffblue"
} | 2017-06-28T12:37:58 | 6154413210 | {"actor":{"display_login":"tautschnig"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/109129028","pull_request_review_id":30210749,"id":109129028,"diff_hunk":"@@ -993,9 +992,10 @@ void goto_checkt::pointer_validity_check(\n const dereference_exprt &expr,\n const guardt &guard,\n const exprt &access_lb,\n- const exprt &access_ub)\n+ const exprt &access_ub,\n+ const irep_idt &mode)\n {\n- if(!enable_pointer_check)\n+ if(mode!=ID_java && !enable_pointer_check)","path":"src/analyses/goto_check.cpp","position":44,"original_position":40,"commit_id":"b993b266e7d3abfd5f4809fb50776407ceab970b","original_commit_id":"5dada64c927f0ed5b0ead6cf5f2341dd0242d5e6","user":{"login":"tautschnig","id":1144736,"avatar_url":"https://avatars0.githubusercontent.com/u/1144736?v=3","gravatar_id":"","url":"https://api.github.com/users/tautschnig","html_url":"https://github.com/tautschnig","followers_url":"https://api.github.com/users/tautschnig/followers","following_url":"https://api.github.com/users/tautschnig/following{/other_user}","gists_url":"https://api.github.com/users/tautschnig/gists{/gist_id}","starred_url":"https://api.github.com/users/tautschnig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tautschnig/subscriptions","organizations_url":"https://api.github.com/users/tautschnig/orgs","repos_url":"https://api.github.com/users/tautschnig/repos","events_url":"https://api.github.com/users/tautschnig/events{/privacy}","received_events_url":"https://api.github.com/users/tautschnig/received_events","type":"User","site_admin":false},"body":"Ok; I'd thus suggestion that the help output for --pointer-check be amended to say \"C/C++ only\".","created_at":"2017-03-31T10:08:59Z","updated_at":"2017-03-31T10:08:59Z","html_url":"https://github.com/diffblue/cbmc/pull/737#discussion_r109129028","pull_request_url":"https://api.github.com/repos/diffblue/cbmc/pulls/737","_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/109129028"},"html":{"href":"https://github.com/diffblue/cbmc/pull/737#discussion_r109129028"},"pull_request":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/737"}}},"pull_request":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/737","id":113468800,"html_url":"https://github.com/diffblue/cbmc/pull/737","diff_url":"https://github.com/diffblue/cbmc/pull/737.diff","patch_url":"https://github.com/diffblue/cbmc/pull/737.patch","issue_url":"https://api.github.com/repos/diffblue/cbmc/issues/737","number":737,"state":"open","locked":false,"title":"Always check Java pointers for null before deref","user":{"login":"smowton","id":283483,"avatar_url":"https://avatars0.githubusercontent.com/u/283483?v=3","gravatar_id":"","url":"https://api.github.com/users/smowton","html_url":"https://github.com/smowton","followers_url":"https://api.github.com/users/smowton/followers","following_url":"https://api.github.com/users/smowton/following{/other_user}","gists_url":"https://api.github.com/users/smowton/gists{/gist_id}","starred_url":"https://api.github.com/users/smowton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smowton/subscriptions","organizations_url":"https://api.github.com/users/smowton/orgs","repos_url":"https://api.github.com/users/smowton/repos","events_url":"https://api.github.com/users/smowton/events{/privacy}","received_events_url":"https://api.github.com/users/smowton/received_events","type":"User","site_admin":false},"body":"This also improves goto-check's resolution for finding symbol modes by finding the function in the symbol table and parameterising from above.\r\n\r\nI wrote this because the test generator was producing strange results due to missing null checks. Before the test generator became a separate module it twiddled the command-line options to add `pointer-check`; however I think doing it this way is better, as it is never semantically sane to analyse Java-but-null-pointers-are-wild.","created_at":"2017-03-30T16:19:06Z","updated_at":"2017-03-31T10:08:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01722ed161c2d63fdc97cb4e07d3cf5cbdb57492","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/diffblue/cbmc/pulls/737/commits","review_comments_url":"https://api.github.com/repos/diffblue/cbmc/pulls/737/comments","review_comment_url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diffblue/cbmc/issues/737/comments","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/b993b266e7d3abfd5f4809fb50776407ceab970b","head":{"label":"smowton:java_null_checks","ref":"java_null_checks","sha":"b993b266e7d3abfd5f4809fb50776407ceab970b","user":{"login":"smowton","id":283483,"avatar_url":"https://avatars0.githubusercontent.com/u/283483?v=3","gravatar_id":"","url":"https://api.github.com/users/smowton","html_url":"https://github.com/smowton","followers_url":"https://api.github.com/users/smowton/followers","following_url":"https://api.github.com/users/smowton/following{/other_user}","gists_url":"https://api.github.com/users/smowton/gists{/gist_id}","starred_url":"https://api.github.com/users/smowton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smowton/subscriptions","organizations_url":"https://api.github.com/users/smowton/orgs","repos_url":"https://api.github.com/users/smowton/repos","events_url":"https://api.github.com/users/smowton/events{/privacy}","received_events_url":"https://api.github.com/users/smowton/received_events","type":"User","site_admin":false},"repo":{"id":75178953,"name":"cbmc","full_name":"smowton/cbmc","owner":{"login":"smowton","id":283483,"avatar_url":"https://avatars0.githubusercontent.com/u/283483?v=3","gravatar_id":"","url":"https://api.github.com/users/smowton","html_url":"https://github.com/smowton","followers_url":"https://api.github.com/users/smowton/followers","following_url":"https://api.github.com/users/smowton/following{/other_user}","gists_url":"https://api.github.com/users/smowton/gists{/gist_id}","starred_url":"https://api.github.com/users/smowton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smowton/subscriptions","organizations_url":"https://api.github.com/users/smowton/orgs","repos_url":"https://api.github.com/users/smowton/repos","events_url":"https://api.github.com/users/smowton/events{/privacy}","received_events_url":"https://api.github.com/users/smowton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smowton/cbmc","description":"C Bounded Model Checker","fork":true,"url":"https://api.github.com/repos/smowton/cbmc","forks_url":"https://api.github.com/repos/smowton/cbmc/forks","keys_url":"https://api.github.com/repos/smowton/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smowton/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smowton/cbmc/teams","hooks_url":"https://api.github.com/repos/smowton/cbmc/hooks","issue_events_url":"https://api.github.com/repos/smowton/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/smowton/cbmc/events","assignees_url":"https://api.github.com/repos/smowton/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/smowton/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/smowton/cbmc/tags","blobs_url":"https://api.github.com/repos/smowton/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smowton/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smowton/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/smowton/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smowton/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/smowton/cbmc/languages","stargazers_url":"https://api.github.com/repos/smowton/cbmc/stargazers","contributors_url":"https://api.github.com/repos/smowton/cbmc/contributors","subscribers_url":"https://api.github.com/repos/smowton/cbmc/subscribers","subscription_url":"https://api.github.com/repos/smowton/cbmc/subscription","commits_url":"https://api.github.com/repos/smowton/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/smowton/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/smowton/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/smowton/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/smowton/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/smowton/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smowton/cbmc/merges","archive_url":"https://api.github.com/repos/smowton/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smowton/cbmc/downloads","issues_url":"https://api.github.com/repos/smowton/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/smowton/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/smowton/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/smowton/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smowton/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/smowton/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/smowton/cbmc/deployments","created_at":"2016-11-30T11:02:38Z","updated_at":"2016-11-30T11:02:46Z","pushed_at":"2017-03-30T16:43:47Z","git_url":"git://github.com/smowton/cbmc.git","ssh_url":"[email protected]:smowton/cbmc.git","clone_url":"https://github.com/smowton/cbmc.git","svn_url":"https://github.com/smowton/cbmc","homepage":"http://www.cprover.org/cbmc","size":51535,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"diffblue:master","ref":"master","sha":"610e9e41ab52b7bae31f78f3ad942fb96998e224","user":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars3.githubusercontent.com/u/17216098?v=3","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"repo":{"id":51877056,"name":"cbmc","full_name":"diffblue/cbmc","owner":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars3.githubusercontent.com/u/17216098?v=3","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diffblue/cbmc","description":"C Bounded Model Checker","fork":false,"url":"https://api.github.com/repos/diffblue/cbmc","forks_url":"https://api.github.com/repos/diffblue/cbmc/forks","keys_url":"https://api.github.com/repos/diffblue/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diffblue/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diffblue/cbmc/teams","hooks_url":"https://api.github.com/repos/diffblue/cbmc/hooks","issue_events_url":"https://api.github.com/repos/diffblue/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/diffblue/cbmc/events","assignees_url":"https://api.github.com/repos/diffblue/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/diffblue/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/diffblue/cbmc/tags","blobs_url":"https://api.github.com/repos/diffblue/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diffblue/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diffblue/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/diffblue/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/diffblue/cbmc/languages","stargazers_url":"https://api.github.com/repos/diffblue/cbmc/stargazers","contributors_url":"https://api.github.com/repos/diffblue/cbmc/contributors","subscribers_url":"https://api.github.com/repos/diffblue/cbmc/subscribers","subscription_url":"https://api.github.com/repos/diffblue/cbmc/subscription","commits_url":"https://api.github.com/repos/diffblue/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/diffblue/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/diffblue/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/diffblue/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/diffblue/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/diffblue/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diffblue/cbmc/merges","archive_url":"https://api.github.com/repos/diffblue/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diffblue/cbmc/downloads","issues_url":"https://api.github.com/repos/diffblue/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/diffblue/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/diffblue/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/diffblue/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diffblue/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/diffblue/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/diffblue/cbmc/deployments","created_at":"2016-02-16T23:03:52Z","updated_at":"2017-03-28T20:13:09Z","pushed_at":"2017-03-31T08:51:41Z","git_url":"git://github.com/diffblue/cbmc.git","ssh_url":"[email protected]:diffblue/cbmc.git","clone_url":"https://github.com/diffblue/cbmc.git","svn_url":"https://github.com/diffblue/cbmc","homepage":"http://www.cprover.org/cbmc","size":18172,"stargazers_count":37,"watchers_count":37,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":209,"forks":48,"open_issues":209,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/737"},"html":{"href":"https://github.com/diffblue/cbmc/pull/737"},"issue":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/737"},"comments":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/737/comments"},"review_comments":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/737/comments"},"review_comment":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/737/commits"},"statuses":{"href":"https://api.github.com/repos/diffblue/cbmc/statuses/b993b266e7d3abfd5f4809fb50776407ceab970b"}}}} | {
"id": 51877056,
"name": "diffblue/cbmc",
"url": "https://api.github.com/repos/diffblue/cbmc"
} | {
"id": 1144736,
"login": "tautschnig",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1144736?",
"url": "https://api.github.com/users/tautschnig"
} | {
"id": 17216098,
"login": "diffblue",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17216098?",
"url": "https://api.github.com/orgs/diffblue"
} | 2017-03-31T10:08:59 | 5602016403 | {"actor":{"display_login":"tautschnig"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/druid/pulls/comments/148374654","pull_request_review_id":73607550,"id":148374654,"diff_hunk":"@@ -417,89 +466,91 @@ private void loadAllLookupsAndInitStateRef()\n return lookups;\n }\n \n- private List<LookupBean> getLookupsListFromLookupConfig()\n- {\n- List<LookupBean> lookupBeanList;\n- if (lookupConfig.getEnableLookupSyncOnStartup()) {\n- String tier = lookupListeningAnnouncerConfig.getLookupTier();\n- lookupBeanList = getLookupListFromCoordinator(tier);\n- if (lookupBeanList == null) {\n- LOG.info(\"Coordinator is unavailable. Loading saved snapshot instead\");\n- lookupBeanList = getLookupListFromSnapshot();\n- }\n- } else {\n- lookupBeanList = getLookupListFromSnapshot();\n- }\n- return lookupBeanList;\n- }\n-\n- private void startLookups(List<LookupBean> lookupBeanList)\n+ private void startLookups(final List<LookupBean> lookupBeanList)\n {\n ImmutableMap.Builder<String, LookupExtractorFactoryContainer> builder = ImmutableMap.builder();\n ExecutorService executorService = Execs.multiThreaded(\n lookupConfig.getNumLookupLoadingThreads(),\n \"LookupReferencesManager-Startup-%s\"\n );\n- ExecutorCompletionService completionService = new ExecutorCompletionService(executorService);\n- List<Future<Map.Entry>> futures = new ArrayList<>();\n+ CompletionService<Map.Entry<String, LookupExtractorFactoryContainer>> completionService =\n+ new ExecutorCompletionService<>(executorService);\n try {\n LOG.info(\"Starting lookup loading process\");\n- for (LookupBean lookupBean : lookupBeanList) {\n- futures.add(\n- completionService.submit(\n- () -> {\n- LookupExtractorFactoryContainer container = lookupBean.getContainer();\n- LOG.info(\n- \"Starting lookup [%s]:[%s]\",\n- lookupBean.getName(),\n- container\n- );\n- if (container.getLookupExtractorFactory().start()) {\n- LOG.info(\n- \"Started lookup [%s]:[%s]\",\n- lookupBean.getName(),\n- container\n- );\n- return new AbstractMap.SimpleImmutableEntry<>(lookupBean.getName(), container);\n- } else {\n- LOG.error(\n- \"Failed to start lookup [%s]:[%s]\",\n- lookupBean.getName(),\n- container\n- );\n- return null;\n- }\n- }\n- )\n- );\n- }\n- for (int i = 0; i < futures.size(); i++) {\n- try {\n- final Future<AbstractMap.SimpleImmutableEntry<String, LookupExtractorFactoryContainer>> completedFuture = completionService\n- .take();\n- final AbstractMap.SimpleImmutableEntry<String, LookupExtractorFactoryContainer> lookupResult = completedFuture\n- .get();\n- if (lookupResult != null) {\n- builder.put(lookupResult);\n- }\n- }\n- catch (ExecutionException e) {\n- LOG.error(e, \"Execution error during lookup loading.\");\n+ List<LookupBean> remainingLookups = lookupBeanList;\n+ for (int i = 0; i < lookupConfig.getLookupStartRetries(); i++) {\n+ LOG.info(\"Round of attempts #%d, [%d] lookups\", i + 1, remainingLookups.size());\n+ Map<String, LookupExtractorFactoryContainer> successfulLookups =\n+ startLookups(remainingLookups, completionService);\n+ builder.putAll(successfulLookups);\n+ List<LookupBean> failedLookups = remainingLookups\n+ .stream()\n+ .filter(l -> !successfulLookups.containsKey(l.getName()))\n+ .collect(Collectors.toList());\n+ if (failedLookups.isEmpty()) {\n+ break;\n+ } else {\n+ // next round\n+ remainingLookups = failedLookups;\n }\n }\n stateRef.set(new LookupUpdateState(builder.build(), ImmutableList.of(), ImmutableList.of()));\n }\n- catch (Exception e) {\n+ catch (InterruptedException | RuntimeException e) {\n LOG.error(e, \"Failed to finish lookup load process.\");\n- for (Future future : futures) {\n- future.cancel(true);\n- }\n }\n finally {\n executorService.shutdownNow();\n }\n }\n \n+ /**\n+ * @return a map with successful lookups\n+ */\n+ private Map<String, LookupExtractorFactoryContainer> startLookups(\n+ List<LookupBean> lookupBeans,\n+ CompletionService<Map.Entry<String, LookupExtractorFactoryContainer>> completionService\n+ ) throws InterruptedException\n+ {\n+ for (LookupBean lookupBean : lookupBeans) {\n+ completionService.submit(() -> startLookup(lookupBean));\n+ }\n+ Map<String, LookupExtractorFactoryContainer> successfulLookups = new HashMap<>();\n+ for (int i = 0; i < lookupBeans.size(); i++) {\n+ Future<Map.Entry<String, LookupExtractorFactoryContainer>> completedFuture = completionService.take();\n+ try {\n+ Map.Entry<String, LookupExtractorFactoryContainer> lookupResult = completedFuture.get();\n+ if (lookupResult != null) {\n+ successfulLookups.put(lookupResult.getKey(), lookupResult.getValue());\n+ }\n+ }\n+ catch (ExecutionException e) {\n+ LOG.error(e.getCause(), \"Exception while starting a lookup\");\n+ // not adding to successfulLookups\n+ }\n+ }\n+ return successfulLookups;\n+ }\n+\n+ @Nullable\n+ private Map.Entry<String, LookupExtractorFactoryContainer> startLookup(LookupBean lookupBean)\n+ {\n+ LookupExtractorFactoryContainer container = lookupBean.getContainer();\n+ LOG.info(\"Starting lookup [%s]:[%s]\", lookupBean.getName(), container);\n+ try {\n+ if (container.getLookupExtractorFactory().start()) {\n+ LOG.info(\"Started lookup [%s]:[%s]\", lookupBean.getName(), container);\n+ return new AbstractMap.SimpleImmutableEntry<>(lookupBean.getName(), container);\n+ } else {\n+ LOG.error(\"Failed to start lookup [%s]:[%s]\", lookupBean.getName(), container);\n+ return null;\n+ }\n+ }\n+ catch (RuntimeException e) {\n+ throw new RE(e, \"Failed to start lookup [%s]:[%s]\", lookupBean.getName(), container);","path":"server/src/main/java/io/druid/query/lookup/LookupReferencesManager.java","position":329,"original_position":323,"commit_id":"59c5c9d8f39ec73f430b8b9db12256e331031f49","original_commit_id":"0c281fb836ff637bfb637fa1511949afe2d22148","user":{"login":"leventov","id":609240,"avatar_url":"https://avatars0.githubusercontent.com/u/609240?v=4","gravatar_id":"","url":"https://api.github.com/users/leventov","html_url":"https://github.com/leventov","followers_url":"https://api.github.com/users/leventov/followers","following_url":"https://api.github.com/users/leventov/following{/other_user}","gists_url":"https://api.github.com/users/leventov/gists{/gist_id}","starred_url":"https://api.github.com/users/leventov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leventov/subscriptions","organizations_url":"https://api.github.com/users/leventov/orgs","repos_url":"https://api.github.com/users/leventov/repos","events_url":"https://api.github.com/users/leventov/events{/privacy}","received_events_url":"https://api.github.com/users/leventov/received_events","type":"User","site_admin":false},"body":"I changed from that version exactly to the current on @drcrallen's suggestion: https://github.com/druid-io/druid/pull/5029#discussion_r148146459 ","created_at":"2017-11-01T20:27:13Z","updated_at":"2017-11-01T20:27:13Z","html_url":"https://github.com/druid-io/druid/pull/5029#discussion_r148374654","pull_request_url":"https://api.github.com/repos/druid-io/druid/pulls/5029","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments/148374654"},"html":{"href":"https://github.com/druid-io/druid/pull/5029#discussion_r148374654"},"pull_request":{"href":"https://api.github.com/repos/druid-io/druid/pulls/5029"}},"in_reply_to_id":148370173},"pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/5029","id":149909755,"html_url":"https://github.com/druid-io/druid/pull/5029","diff_url":"https://github.com/druid-io/druid/pull/5029.diff","patch_url":"https://github.com/druid-io/druid/pull/5029.patch","issue_url":"https://api.github.com/repos/druid-io/druid/issues/5029","number":5029,"state":"open","locked":false,"title":"Add retries for coordinator fetch and lookup start in LookupReferencesManager","user":{"login":"leventov","id":609240,"avatar_url":"https://avatars0.githubusercontent.com/u/609240?v=4","gravatar_id":"","url":"https://api.github.com/users/leventov","html_url":"https://github.com/leventov","followers_url":"https://api.github.com/users/leventov/followers","following_url":"https://api.github.com/users/leventov/following{/other_user}","gists_url":"https://api.github.com/users/leventov/gists{/gist_id}","starred_url":"https://api.github.com/users/leventov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leventov/subscriptions","organizations_url":"https://api.github.com/users/leventov/orgs","repos_url":"https://api.github.com/users/leventov/repos","events_url":"https://api.github.com/users/leventov/events{/privacy}","received_events_url":"https://api.github.com/users/leventov/received_events","type":"User","site_admin":false},"body":"Fixes #5018","created_at":"2017-10-31T21:14:29Z","updated_at":"2017-11-01T20:27:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0392fc82da14df260ba3d73d48fb66a148b58734","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/druid-io/druid/milestones/23","html_url":"https://github.com/druid-io/druid/milestone/23","labels_url":"https://api.github.com/repos/druid-io/druid/milestones/23/labels","id":2338417,"number":23,"title":"0.11.0","description":"","creator":{"login":"gianm","id":1214075,"avatar_url":"https://avatars3.githubusercontent.com/u/1214075?v=4","gravatar_id":"","url":"https://api.github.com/users/gianm","html_url":"https://github.com/gianm","followers_url":"https://api.github.com/users/gianm/followers","following_url":"https://api.github.com/users/gianm/following{/other_user}","gists_url":"https://api.github.com/users/gianm/gists{/gist_id}","starred_url":"https://api.github.com/users/gianm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gianm/subscriptions","organizations_url":"https://api.github.com/users/gianm/orgs","repos_url":"https://api.github.com/users/gianm/repos","events_url":"https://api.github.com/users/gianm/events{/privacy}","received_events_url":"https://api.github.com/users/gianm/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":235,"state":"open","created_at":"2017-02-21T17:48:27Z","updated_at":"2017-11-01T19:00:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/druid-io/druid/pulls/5029/commits","review_comments_url":"https://api.github.com/repos/druid-io/druid/pulls/5029/comments","review_comment_url":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/5029/comments","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/59c5c9d8f39ec73f430b8b9db12256e331031f49","head":{"label":"metamx:lookup-retries","ref":"lookup-retries","sha":"59c5c9d8f39ec73f430b8b9db12256e331031f49","user":{"login":"metamx","id":299329,"avatar_url":"https://avatars1.githubusercontent.com/u/299329?v=4","gravatar_id":"","url":"https://api.github.com/users/metamx","html_url":"https://github.com/metamx","followers_url":"https://api.github.com/users/metamx/followers","following_url":"https://api.github.com/users/metamx/following{/other_user}","gists_url":"https://api.github.com/users/metamx/gists{/gist_id}","starred_url":"https://api.github.com/users/metamx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamx/subscriptions","organizations_url":"https://api.github.com/users/metamx/orgs","repos_url":"https://api.github.com/users/metamx/repos","events_url":"https://api.github.com/users/metamx/events{/privacy}","received_events_url":"https://api.github.com/users/metamx/received_events","type":"Organization","site_admin":false},"repo":{"id":28248872,"name":"druid","full_name":"metamx/druid","owner":{"login":"metamx","id":299329,"avatar_url":"https://avatars1.githubusercontent.com/u/299329?v=4","gravatar_id":"","url":"https://api.github.com/users/metamx","html_url":"https://github.com/metamx","followers_url":"https://api.github.com/users/metamx/followers","following_url":"https://api.github.com/users/metamx/following{/other_user}","gists_url":"https://api.github.com/users/metamx/gists{/gist_id}","starred_url":"https://api.github.com/users/metamx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamx/subscriptions","organizations_url":"https://api.github.com/users/metamx/orgs","repos_url":"https://api.github.com/users/metamx/repos","events_url":"https://api.github.com/users/metamx/events{/privacy}","received_events_url":"https://api.github.com/users/metamx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metamx/druid","description":"Real²time Exploratory Analytics on Large Datasets","fork":true,"url":"https://api.github.com/repos/metamx/druid","forks_url":"https://api.github.com/repos/metamx/druid/forks","keys_url":"https://api.github.com/repos/metamx/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metamx/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metamx/druid/teams","hooks_url":"https://api.github.com/repos/metamx/druid/hooks","issue_events_url":"https://api.github.com/repos/metamx/druid/issues/events{/number}","events_url":"https://api.github.com/repos/metamx/druid/events","assignees_url":"https://api.github.com/repos/metamx/druid/assignees{/user}","branches_url":"https://api.github.com/repos/metamx/druid/branches{/branch}","tags_url":"https://api.github.com/repos/metamx/druid/tags","blobs_url":"https://api.github.com/repos/metamx/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metamx/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metamx/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/metamx/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metamx/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/metamx/druid/languages","stargazers_url":"https://api.github.com/repos/metamx/druid/stargazers","contributors_url":"https://api.github.com/repos/metamx/druid/contributors","subscribers_url":"https://api.github.com/repos/metamx/druid/subscribers","subscription_url":"https://api.github.com/repos/metamx/druid/subscription","commits_url":"https://api.github.com/repos/metamx/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/metamx/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/metamx/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/metamx/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/metamx/druid/contents/{+path}","compare_url":"https://api.github.com/repos/metamx/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metamx/druid/merges","archive_url":"https://api.github.com/repos/metamx/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metamx/druid/downloads","issues_url":"https://api.github.com/repos/metamx/druid/issues{/number}","pulls_url":"https://api.github.com/repos/metamx/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/metamx/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/metamx/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metamx/druid/labels{/name}","releases_url":"https://api.github.com/repos/metamx/druid/releases{/id}","deployments_url":"https://api.github.com/repos/metamx/druid/deployments","created_at":"2014-12-19T22:30:25Z","updated_at":"2017-10-12T01:10:42Z","pushed_at":"2017-11-01T20:26:19Z","git_url":"git://github.com/metamx/druid.git","ssh_url":"[email protected]:metamx/druid.git","clone_url":"https://github.com/metamx/druid.git","svn_url":"https://github.com/metamx/druid","homepage":"http://druid.io","size":132046,"stargazers_count":92,"watchers_count":92,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":30,"open_issues":2,"watchers":92,"default_branch":"0.11.0-mmx"}},"base":{"label":"druid-io:master","ref":"master","sha":"e96daa2593808d7e10d833525066d4b9e455de4f","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars0.githubusercontent.com/u/4203474?v=4","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"name":"druid","full_name":"druid-io/druid","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars0.githubusercontent.com/u/4203474?v=4","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":false,"url":"https://api.github.com/repos/druid-io/druid","forks_url":"https://api.github.com/repos/druid-io/druid/forks","keys_url":"https://api.github.com/repos/druid-io/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid/teams","hooks_url":"https://api.github.com/repos/druid-io/druid/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid/events","assignees_url":"https://api.github.com/repos/druid-io/druid/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid/tags","blobs_url":"https://api.github.com/repos/druid-io/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid/subscription","commits_url":"https://api.github.com/repos/druid-io/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/druid-io/druid/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid/merges","archive_url":"https://api.github.com/repos/druid-io/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid/downloads","issues_url":"https://api.github.com/repos/druid-io/druid/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid/releases{/id}","deployments_url":"https://api.github.com/repos/druid-io/druid/deployments","created_at":"2012-10-23T19:08:07Z","updated_at":"2017-11-01T20:17:04Z","pushed_at":"2017-11-01T20:26:20Z","git_url":"git://github.com/druid-io/druid.git","ssh_url":"[email protected]:druid-io/druid.git","clone_url":"https://github.com/druid-io/druid.git","svn_url":"https://github.com/druid-io/druid","homepage":"http://druid.io","size":128592,"stargazers_count":5626,"watchers_count":5626,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1375,"mirror_url":null,"archived":false,"open_issues_count":846,"forks":1375,"open_issues":846,"watchers":5626,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/5029"},"html":{"href":"https://github.com/druid-io/druid/pull/5029"},"issue":{"href":"https://api.github.com/repos/druid-io/druid/issues/5029"},"comments":{"href":"https://api.github.com/repos/druid-io/druid/issues/5029/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/druid/pulls/5029/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druid-io/druid/pulls/5029/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/druid/statuses/59c5c9d8f39ec73f430b8b9db12256e331031f49"}},"author_association":"MEMBER"}} | {
"id": 6358188,
"name": "druid-io/druid",
"url": "https://api.github.com/repos/druid-io/druid"
} | {
"id": 609240,
"login": "leventov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/609240?",
"url": "https://api.github.com/users/leventov"
} | {
"id": 4203474,
"login": "druid-io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4203474?",
"url": "https://api.github.com/orgs/druid-io"
} | 2017-11-01T20:27:13 | 6796840123 | {"actor":{"display_login":"leventov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/druid/pulls/comments/103041663","pull_request_review_id":23821251,"id":103041663,"diff_hunk":"@@ -0,0 +1,238 @@\n+/*\n+ * Licensed to Metamarkets Group Inc. (Metamarkets) under one\n+ * or more contributor license agreements. See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership. Metamarkets licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied. See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+\n+package io.druid.concurrent;\n+\n+import java.util.concurrent.locks.AbstractQueuedSynchronizer;\n+\n+/**\n+ * A synchronization tool for lifecycled objects (see {@link io.druid.java.util.common.lifecycle.Lifecycle}, that need\n+ * happens-before between start() and other methods and/or to check that the object was successfully started in other\n+ * methods.\n+ *\n+ * Guarantees in terms of JMM: happens-before between {@link #exitStart()} and {@link #isStarted()},\n+ * exitStart() and {@link #canStop()}, if it returns {@code true}.\n+ *\n+ * Example:\n+ * class ExampleLifecycledClass\n+ * {\n+ * final LifecycleLock lifecycleLock = new LifecycleLock();\n+ *\n+ * void start()\n+ * {\n+ * if (!lifecycleLock.canStart()) {\n+ * .. return or throw exception\n+ * }\n+ * try {\n+ * .. do start\n+ * lifecycleLock.started();\n+ * }\n+ * finally {\n+ * lifecycleLock.exitStart();\n+ * }\n+ * }\n+ *\n+ * void otherMethod()\n+ * {\n+ * Preconditions.checkState(lifecycleLock.isStarted());\n+ * // all actions done in start() are visible here\n+ * .. do stuff\n+ * }\n+ *\n+ * void stop()\n+ * {\n+ * if (!lifecycleLock.canStop()) {\n+ * .. return or throw exception\n+ * }\n+ * // all actions done in start() are visible here\n+ * .. do stop\n+ * }\n+ * }\n+ */\n+public final class LifecycleLock\n+{\n+ private static class Sync extends AbstractQueuedSynchronizer\n+ {\n+ private static final int NOT_STARTED = 0;\n+ private static final int STARTING = 1;\n+ private static final int STARTED = 2;\n+ private static final int START_EXITED_SUCCESSFUL = 3;\n+ private static final int START_EXITED_FAIL = 4;\n+ private static final int STOPPING = 5;\n+ private static final int STOPPED = 6;\n+\n+ boolean canStart()\n+ {\n+ return compareAndSetState(NOT_STARTED, STARTING);\n+ }\n+\n+ void started()\n+ {\n+ if (!compareAndSetState(STARTING, STARTED)) {\n+ throw new IllegalMonitorStateException(\"Called started() not in the context of start()\");\n+ }\n+ }\n+\n+ void exitStart()\n+ {\n+ // see tryReleaseShared()\n+ releaseShared(1);\n+ }\n+\n+ @Override\n+ protected boolean tryReleaseShared(int ignore)\n+ {\n+ while (true) {\n+ int state = getState();\n+ if (state == STARTING) {\n+ if (compareAndSetState(STARTING, START_EXITED_FAIL)) {\n+ return true;\n+ }\n+ } else if (state == STARTED) {\n+ if (compareAndSetState(STARTED, START_EXITED_SUCCESSFUL)) {\n+ return true;\n+ }\n+ } else {\n+ throw new IllegalMonitorStateException(\"exitStart() called not in the end of the start() method\");\n+ }\n+ }\n+ }\n+\n+ boolean isStarted()","path":"common/src/main/java/io/druid/concurrent/LifecycleLock.java","position":117,"original_position":117,"commit_id":"08f9cf081535bd37cce292988d74c0756ff40bfd","original_commit_id":"08f9cf081535bd37cce292988d74c0756ff40bfd","user":{"login":"himanshug","id":246308,"avatar_url":"https://avatars.githubusercontent.com/u/246308?v=3","gravatar_id":"","url":"https://api.github.com/users/himanshug","html_url":"https://github.com/himanshug","followers_url":"https://api.github.com/users/himanshug/followers","following_url":"https://api.github.com/users/himanshug/following{/other_user}","gists_url":"https://api.github.com/users/himanshug/gists{/gist_id}","starred_url":"https://api.github.com/users/himanshug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanshug/subscriptions","organizations_url":"https://api.github.com/users/himanshug/orgs","repos_url":"https://api.github.com/users/himanshug/repos","events_url":"https://api.github.com/users/himanshug/events{/privacy}","received_events_url":"https://api.github.com/users/himanshug/received_events","type":"User","site_admin":false},"body":"well i would need it in https://github.com/druid-io/druid/pull/3855 , so that requests from coordinator don't wait but rather fail","created_at":"2017-02-24T21:57:15Z","updated_at":"2017-02-24T21:57:15Z","html_url":"https://github.com/druid-io/druid/pull/3964#discussion_r103041663","pull_request_url":"https://api.github.com/repos/druid-io/druid/pulls/3964","_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments/103041663"},"html":{"href":"https://github.com/druid-io/druid/pull/3964#discussion_r103041663"},"pull_request":{"href":"https://api.github.com/repos/druid-io/druid/pulls/3964"}}},"pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/3964","id":107527858,"html_url":"https://github.com/druid-io/druid/pull/3964","diff_url":"https://github.com/druid-io/druid/pull/3964.diff","patch_url":"https://github.com/druid-io/druid/pull/3964.patch","issue_url":"https://api.github.com/repos/druid-io/druid/issues/3964","number":3964,"state":"open","locked":false,"title":"LifecycleLock for better synchronization in lifecycled objects","user":{"login":"leventov","id":609240,"avatar_url":"https://avatars.githubusercontent.com/u/609240?v=3","gravatar_id":"","url":"https://api.github.com/users/leventov","html_url":"https://github.com/leventov","followers_url":"https://api.github.com/users/leventov/followers","following_url":"https://api.github.com/users/leventov/following{/other_user}","gists_url":"https://api.github.com/users/leventov/gists{/gist_id}","starred_url":"https://api.github.com/users/leventov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leventov/subscriptions","organizations_url":"https://api.github.com/users/leventov/orgs","repos_url":"https://api.github.com/users/leventov/repos","events_url":"https://api.github.com/users/leventov/events{/privacy}","received_events_url":"https://api.github.com/users/leventov/received_events","type":"User","site_admin":false},"body":"**Why**\r\n - Almost lock-free\r\n - Harder to make a mistake than with usual `lock` + `started` flag combination, because user needs to manipulate less entities and LifecycleLock's methods have meaningful names.\r\n - Doesn't allow starting again after stop, for any case.","created_at":"2017-02-23T00:02:53Z","updated_at":"2017-02-24T21:57:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf6ff9e780e623d3257814374346261eb730f799","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/druid-io/druid/pulls/3964/commits","review_comments_url":"https://api.github.com/repos/druid-io/druid/pulls/3964/comments","review_comment_url":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/3964/comments","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/08f9cf081535bd37cce292988d74c0756ff40bfd","head":{"label":"metamx:lifecycle-lock","ref":"lifecycle-lock","sha":"08f9cf081535bd37cce292988d74c0756ff40bfd","user":{"login":"metamx","id":299329,"avatar_url":"https://avatars.githubusercontent.com/u/299329?v=3","gravatar_id":"","url":"https://api.github.com/users/metamx","html_url":"https://github.com/metamx","followers_url":"https://api.github.com/users/metamx/followers","following_url":"https://api.github.com/users/metamx/following{/other_user}","gists_url":"https://api.github.com/users/metamx/gists{/gist_id}","starred_url":"https://api.github.com/users/metamx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamx/subscriptions","organizations_url":"https://api.github.com/users/metamx/orgs","repos_url":"https://api.github.com/users/metamx/repos","events_url":"https://api.github.com/users/metamx/events{/privacy}","received_events_url":"https://api.github.com/users/metamx/received_events","type":"Organization","site_admin":false},"repo":{"id":28248872,"name":"druid","full_name":"metamx/druid","owner":{"login":"metamx","id":299329,"avatar_url":"https://avatars.githubusercontent.com/u/299329?v=3","gravatar_id":"","url":"https://api.github.com/users/metamx","html_url":"https://github.com/metamx","followers_url":"https://api.github.com/users/metamx/followers","following_url":"https://api.github.com/users/metamx/following{/other_user}","gists_url":"https://api.github.com/users/metamx/gists{/gist_id}","starred_url":"https://api.github.com/users/metamx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamx/subscriptions","organizations_url":"https://api.github.com/users/metamx/orgs","repos_url":"https://api.github.com/users/metamx/repos","events_url":"https://api.github.com/users/metamx/events{/privacy}","received_events_url":"https://api.github.com/users/metamx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metamx/druid","description":"Real²time Exploratory Analytics on Large Datasets","fork":true,"url":"https://api.github.com/repos/metamx/druid","forks_url":"https://api.github.com/repos/metamx/druid/forks","keys_url":"https://api.github.com/repos/metamx/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metamx/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metamx/druid/teams","hooks_url":"https://api.github.com/repos/metamx/druid/hooks","issue_events_url":"https://api.github.com/repos/metamx/druid/issues/events{/number}","events_url":"https://api.github.com/repos/metamx/druid/events","assignees_url":"https://api.github.com/repos/metamx/druid/assignees{/user}","branches_url":"https://api.github.com/repos/metamx/druid/branches{/branch}","tags_url":"https://api.github.com/repos/metamx/druid/tags","blobs_url":"https://api.github.com/repos/metamx/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metamx/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metamx/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/metamx/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metamx/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/metamx/druid/languages","stargazers_url":"https://api.github.com/repos/metamx/druid/stargazers","contributors_url":"https://api.github.com/repos/metamx/druid/contributors","subscribers_url":"https://api.github.com/repos/metamx/druid/subscribers","subscription_url":"https://api.github.com/repos/metamx/druid/subscription","commits_url":"https://api.github.com/repos/metamx/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/metamx/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/metamx/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/metamx/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/metamx/druid/contents/{+path}","compare_url":"https://api.github.com/repos/metamx/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metamx/druid/merges","archive_url":"https://api.github.com/repos/metamx/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metamx/druid/downloads","issues_url":"https://api.github.com/repos/metamx/druid/issues{/number}","pulls_url":"https://api.github.com/repos/metamx/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/metamx/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/metamx/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metamx/druid/labels{/name}","releases_url":"https://api.github.com/repos/metamx/druid/releases{/id}","deployments_url":"https://api.github.com/repos/metamx/druid/deployments","created_at":"2014-12-19T22:30:25Z","updated_at":"2017-02-21T05:00:31Z","pushed_at":"2017-02-24T19:31:16Z","git_url":"git://github.com/metamx/druid.git","ssh_url":"[email protected]:metamx/druid.git","clone_url":"https://github.com/metamx/druid.git","svn_url":"https://github.com/metamx/druid","homepage":"http://druid.io","size":120509,"stargazers_count":81,"watchers_count":81,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":5,"forks":25,"open_issues":5,"watchers":81,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"02fc625b5f895848a918539b2b183d4e7cb034f3","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"name":"druid","full_name":"druid-io/druid","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":false,"url":"https://api.github.com/repos/druid-io/druid","forks_url":"https://api.github.com/repos/druid-io/druid/forks","keys_url":"https://api.github.com/repos/druid-io/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid/teams","hooks_url":"https://api.github.com/repos/druid-io/druid/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid/events","assignees_url":"https://api.github.com/repos/druid-io/druid/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid/tags","blobs_url":"https://api.github.com/repos/druid-io/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid/subscription","commits_url":"https://api.github.com/repos/druid-io/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/druid-io/druid/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid/merges","archive_url":"https://api.github.com/repos/druid-io/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid/downloads","issues_url":"https://api.github.com/repos/druid-io/druid/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid/releases{/id}","deployments_url":"https://api.github.com/repos/druid-io/druid/deployments","created_at":"2012-10-23T19:08:07Z","updated_at":"2017-02-24T20:42:31Z","pushed_at":"2017-02-24T19:31:19Z","git_url":"git://github.com/druid-io/druid.git","ssh_url":"[email protected]:druid-io/druid.git","clone_url":"https://github.com/druid-io/druid.git","svn_url":"https://github.com/druid-io/druid","homepage":"http://druid.io","size":117944,"stargazers_count":4483,"watchers_count":4483,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1058,"mirror_url":null,"open_issues_count":599,"forks":1058,"open_issues":599,"watchers":4483,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/3964"},"html":{"href":"https://github.com/druid-io/druid/pull/3964"},"issue":{"href":"https://api.github.com/repos/druid-io/druid/issues/3964"},"comments":{"href":"https://api.github.com/repos/druid-io/druid/issues/3964/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/druid/pulls/3964/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druid-io/druid/pulls/3964/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/druid/statuses/08f9cf081535bd37cce292988d74c0756ff40bfd"}}}} | {
"id": 6358188,
"name": "druid-io/druid",
"url": "https://api.github.com/repos/druid-io/druid"
} | {
"id": 246308,
"login": "himanshug",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/246308?",
"url": "https://api.github.com/users/himanshug"
} | {
"id": 4203474,
"login": "druid-io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4203474?",
"url": "https://api.github.com/orgs/druid-io"
} | 2017-02-24T21:57:15 | 5388401444 | {"actor":{"display_login":"himanshug"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/druid/pulls/comments/123701701","pull_request_review_id":45931520,"id":123701701,"diff_hunk":"@@ -94,4 +94,25 @@ public static String stripQuotes(String input)\n }\n return input;\n }\n+\n+ public static String replace(String text, String searchString, String replacement)","path":"java-util/src/main/java/io/druid/java/util/common/parsers/ParserUtils.java","position":5,"original_position":5,"commit_id":"e97e2370d1fd6155aaa0e7769fbd7f36d1e84115","original_commit_id":"e97e2370d1fd6155aaa0e7769fbd7f36d1e84115","user":{"login":"jihoonson","id":2322288,"avatar_url":"https://avatars0.githubusercontent.com/u/2322288?v=3","gravatar_id":"","url":"https://api.github.com/users/jihoonson","html_url":"https://github.com/jihoonson","followers_url":"https://api.github.com/users/jihoonson/followers","following_url":"https://api.github.com/users/jihoonson/following{/other_user}","gists_url":"https://api.github.com/users/jihoonson/gists{/gist_id}","starred_url":"https://api.github.com/users/jihoonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihoonson/subscriptions","organizations_url":"https://api.github.com/users/jihoonson/orgs","repos_url":"https://api.github.com/users/jihoonson/repos","events_url":"https://api.github.com/users/jihoonson/events{/privacy}","received_events_url":"https://api.github.com/users/jihoonson/received_events","type":"User","site_admin":false},"body":"Would you elaborate more why this method is needed? There are ```String.replace()``` or ```String.replaceAll()```, but they aren't enough?","created_at":"2017-06-23T08:56:19Z","updated_at":"2017-06-23T08:57:12Z","html_url":"https://github.com/druid-io/druid/pull/4419#discussion_r123701701","pull_request_url":"https://api.github.com/repos/druid-io/druid/pulls/4419","_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments/123701701"},"html":{"href":"https://github.com/druid-io/druid/pull/4419#discussion_r123701701"},"pull_request":{"href":"https://api.github.com/repos/druid-io/druid/pulls/4419"}}},"pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/4419","id":125976118,"html_url":"https://github.com/druid-io/druid/pull/4419","diff_url":"https://github.com/druid-io/druid/pull/4419.diff","patch_url":"https://github.com/druid-io/druid/pull/4419.patch","issue_url":"https://api.github.com/repos/druid-io/druid/issues/4419","number":4419,"state":"open","locked":false,"title":"Fix #4082 when timestamp separator by space #4411","user":{"login":"warmbreeze","id":4353307,"avatar_url":"https://avatars0.githubusercontent.com/u/4353307?v=3","gravatar_id":"","url":"https://api.github.com/users/warmbreeze","html_url":"https://github.com/warmbreeze","followers_url":"https://api.github.com/users/warmbreeze/followers","following_url":"https://api.github.com/users/warmbreeze/following{/other_user}","gists_url":"https://api.github.com/users/warmbreeze/gists{/gist_id}","starred_url":"https://api.github.com/users/warmbreeze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warmbreeze/subscriptions","organizations_url":"https://api.github.com/users/warmbreeze/orgs","repos_url":"https://api.github.com/users/warmbreeze/repos","events_url":"https://api.github.com/users/warmbreeze/events{/privacy}","received_events_url":"https://api.github.com/users/warmbreeze/received_events","type":"User","site_admin":false},"body":"Timestamp format \"auto\" can detect iso8601-but-with-space-separator(#4082)","created_at":"2017-06-16T07:37:53Z","updated_at":"2017-06-23T08:57:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a508d3ec8d4003428a7962b61f7f77af2b23bfd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/druid-io/druid/pulls/4419/commits","review_comments_url":"https://api.github.com/repos/druid-io/druid/pulls/4419/comments","review_comment_url":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/4419/comments","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/e97e2370d1fd6155aaa0e7769fbd7f36d1e84115","head":{"label":"warmbreeze:master","ref":"master","sha":"e97e2370d1fd6155aaa0e7769fbd7f36d1e84115","user":{"login":"warmbreeze","id":4353307,"avatar_url":"https://avatars0.githubusercontent.com/u/4353307?v=3","gravatar_id":"","url":"https://api.github.com/users/warmbreeze","html_url":"https://github.com/warmbreeze","followers_url":"https://api.github.com/users/warmbreeze/followers","following_url":"https://api.github.com/users/warmbreeze/following{/other_user}","gists_url":"https://api.github.com/users/warmbreeze/gists{/gist_id}","starred_url":"https://api.github.com/users/warmbreeze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warmbreeze/subscriptions","organizations_url":"https://api.github.com/users/warmbreeze/orgs","repos_url":"https://api.github.com/users/warmbreeze/repos","events_url":"https://api.github.com/users/warmbreeze/events{/privacy}","received_events_url":"https://api.github.com/users/warmbreeze/received_events","type":"User","site_admin":false},"repo":{"id":89583819,"name":"druid","full_name":"warmbreeze/druid","owner":{"login":"warmbreeze","id":4353307,"avatar_url":"https://avatars0.githubusercontent.com/u/4353307?v=3","gravatar_id":"","url":"https://api.github.com/users/warmbreeze","html_url":"https://github.com/warmbreeze","followers_url":"https://api.github.com/users/warmbreeze/followers","following_url":"https://api.github.com/users/warmbreeze/following{/other_user}","gists_url":"https://api.github.com/users/warmbreeze/gists{/gist_id}","starred_url":"https://api.github.com/users/warmbreeze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warmbreeze/subscriptions","organizations_url":"https://api.github.com/users/warmbreeze/orgs","repos_url":"https://api.github.com/users/warmbreeze/repos","events_url":"https://api.github.com/users/warmbreeze/events{/privacy}","received_events_url":"https://api.github.com/users/warmbreeze/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/warmbreeze/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":true,"url":"https://api.github.com/repos/warmbreeze/druid","forks_url":"https://api.github.com/repos/warmbreeze/druid/forks","keys_url":"https://api.github.com/repos/warmbreeze/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/warmbreeze/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/warmbreeze/druid/teams","hooks_url":"https://api.github.com/repos/warmbreeze/druid/hooks","issue_events_url":"https://api.github.com/repos/warmbreeze/druid/issues/events{/number}","events_url":"https://api.github.com/repos/warmbreeze/druid/events","assignees_url":"https://api.github.com/repos/warmbreeze/druid/assignees{/user}","branches_url":"https://api.github.com/repos/warmbreeze/druid/branches{/branch}","tags_url":"https://api.github.com/repos/warmbreeze/druid/tags","blobs_url":"https://api.github.com/repos/warmbreeze/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/warmbreeze/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/warmbreeze/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/warmbreeze/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/warmbreeze/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/warmbreeze/druid/languages","stargazers_url":"https://api.github.com/repos/warmbreeze/druid/stargazers","contributors_url":"https://api.github.com/repos/warmbreeze/druid/contributors","subscribers_url":"https://api.github.com/repos/warmbreeze/druid/subscribers","subscription_url":"https://api.github.com/repos/warmbreeze/druid/subscription","commits_url":"https://api.github.com/repos/warmbreeze/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/warmbreeze/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/warmbreeze/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/warmbreeze/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/warmbreeze/druid/contents/{+path}","compare_url":"https://api.github.com/repos/warmbreeze/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/warmbreeze/druid/merges","archive_url":"https://api.github.com/repos/warmbreeze/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/warmbreeze/druid/downloads","issues_url":"https://api.github.com/repos/warmbreeze/druid/issues{/number}","pulls_url":"https://api.github.com/repos/warmbreeze/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/warmbreeze/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/warmbreeze/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/warmbreeze/druid/labels{/name}","releases_url":"https://api.github.com/repos/warmbreeze/druid/releases{/id}","deployments_url":"https://api.github.com/repos/warmbreeze/druid/deployments","created_at":"2017-04-27T10:05:00Z","updated_at":"2017-04-27T10:05:15Z","pushed_at":"2017-06-16T07:34:30Z","git_url":"git://github.com/warmbreeze/druid.git","ssh_url":"[email protected]:warmbreeze/druid.git","clone_url":"https://github.com/warmbreeze/druid.git","svn_url":"https://github.com/warmbreeze/druid","homepage":"http://druid.io","size":121810,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"e78d8584a1298e79c17a45e01f79062b55c9f703","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars3.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"name":"druid","full_name":"druid-io/druid","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars3.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":false,"url":"https://api.github.com/repos/druid-io/druid","forks_url":"https://api.github.com/repos/druid-io/druid/forks","keys_url":"https://api.github.com/repos/druid-io/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid/teams","hooks_url":"https://api.github.com/repos/druid-io/druid/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid/events","assignees_url":"https://api.github.com/repos/druid-io/druid/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid/tags","blobs_url":"https://api.github.com/repos/druid-io/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid/subscription","commits_url":"https://api.github.com/repos/druid-io/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/druid-io/druid/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid/merges","archive_url":"https://api.github.com/repos/druid-io/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid/downloads","issues_url":"https://api.github.com/repos/druid-io/druid/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid/releases{/id}","deployments_url":"https://api.github.com/repos/druid-io/druid/deployments","created_at":"2012-10-23T19:08:07Z","updated_at":"2017-06-23T03:14:30Z","pushed_at":"2017-06-23T00:51:17Z","git_url":"git://github.com/druid-io/druid.git","ssh_url":"[email protected]:druid-io/druid.git","clone_url":"https://github.com/druid-io/druid.git","svn_url":"https://github.com/druid-io/druid","homepage":"http://druid.io","size":122053,"stargazers_count":5032,"watchers_count":5032,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1218,"mirror_url":null,"open_issues_count":727,"forks":1218,"open_issues":727,"watchers":5032,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/4419"},"html":{"href":"https://github.com/druid-io/druid/pull/4419"},"issue":{"href":"https://api.github.com/repos/druid-io/druid/issues/4419"},"comments":{"href":"https://api.github.com/repos/druid-io/druid/issues/4419/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/druid/pulls/4419/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druid-io/druid/pulls/4419/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/druid/statuses/e97e2370d1fd6155aaa0e7769fbd7f36d1e84115"}}}} | {
"id": 6358188,
"name": "druid-io/druid",
"url": "https://api.github.com/repos/druid-io/druid"
} | {
"id": 2322288,
"login": "jihoonson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2322288?",
"url": "https://api.github.com/users/jihoonson"
} | {
"id": 4203474,
"login": "druid-io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4203474?",
"url": "https://api.github.com/orgs/druid-io"
} | 2017-06-23T08:56:19 | 6124498587 | {"actor":{"display_login":"jihoonson"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/eHarmony/aloha/pulls/comments/105019212","pull_request_review_id":25879367,"id":105019212,"diff_hunk":"@@ -0,0 +1,165 @@\n+package com.eharmony.aloha.factory.avro\n+\n+import java.io.{File, InputStream}\n+\n+import com.eharmony.aloha.audit.impl.avro.{AvroScoreAuditor, Score}\n+import com.eharmony.aloha.factory.ModelFactory\n+import com.eharmony.aloha.factory.ex.AlohaFactoryException\n+import com.eharmony.aloha.io.vfs.Vfs\n+import com.eharmony.aloha.reflect.{RefInfo, RefInfoOps}\n+import com.eharmony.aloha.semantics.compiled.CompiledSemantics\n+import com.eharmony.aloha.semantics.compiled.compiler.TwitterEvalCompiler\n+import com.eharmony.aloha.semantics.compiled.plugin.avro.CompiledSemanticsAvroPlugin\n+import org.apache.avro.Schema\n+import org.apache.avro.generic.GenericRecord\n+import org.apache.commons.io.IOUtils\n+\n+import scala.concurrent.ExecutionContext.Implicits.global\n+import scala.util.{Failure, Success, Try}\n+\n+/**\n+ * A configuration object for Avro model factories.\n+ */\n+sealed abstract class FactoryConfig {\n+\n+ /**\n+ * Attempt to create a factory.\n+ * @return\n+ */\n+ def apply(): Try[ModelFactory[GenericRecord, Score]]\n+\n+ protected[this] def semantics(s: Schema,\n+ imports: Seq[String],\n+ classCacheDir: Option[File],\n+ dereferenceAsOptional: Boolean): CompiledSemantics[GenericRecord] = {\n+ val p = CompiledSemanticsAvroPlugin[GenericRecord](s, dereferenceAsOptional)\n+ CompiledSemantics(TwitterEvalCompiler(classCacheDir = classCacheDir), p, imports)\n+ }\n+\n+ protected[this] def auditor[A](refInfo: RefInfo[A]): Try[AvroScoreAuditor[A]] =\n+ AvroScoreAuditor(refInfo).map(Success.apply).getOrElse(\n+ Failure(new AlohaFactoryException(\n+ s\"Couldn't create AvroScoreAuditor for ${RefInfoOps.toString(refInfo)}\")))\n+\n+ protected[this] def refInfo(refInfoStr: String): Try[RefInfo[Any]] =\n+ RefInfo.fromString(refInfoStr) match {\n+ case Left(err) => Failure(new AlohaFactoryException(err))\n+ case Right(success) => Success(success.asInstanceOf[RefInfo[Any]])\n+ }\n+}\n+\n+// TODO: If desired, you can expose the Magnet pattern to provide convenience syntax.\n+// See Spray's [[http://spray.io/blog/2012-12-13-the-magnet-pattern/ Magnet pattern]]\n+// article for more information. Just add implicits to this companion object.\n+object FactoryConfig {\n+\n+ /**\n+ * Pass through successes and wrap failures in an AlohaFactoryException.\n+ * @param t a try whose failures should be wrapped in an AlohaFactoryException.\n+ * @tparam A type of Try.\n+ * @return Successes are unchanged, Failures are wrapped in an AlohaFactoryException.\n+ */\n+ private[avro] def wrapException[A](t: Try[A]): Try[A] =\n+ t.transform(\n+ s => Success(s),\n+ f => Failure(new AlohaFactoryException(\"Problem creating Avro Factory.\", f))\n+ )\n+}\n+\n+/**\n+ * Provides an easy interface for creating ModelFactory instances that both take and\n+ * return Avro objects.\n+ *\n+ * This is especially useful for creating factories in generic services because the\n+ * `modelCodomainRefInfoStr` is a string rather than `RefInfo` so it can come from a\n+ * property file.\n+ *\n+ * @param schema an Avro Schema that represents the data passed to models created by this factory.\n+ * @param modelCodomainRefInfoStr A string representation of a `com.eharmony.aloha.reflect.RefInfo`.\n+ * @param imports imports to be injected into feature functions synthesized by the factory.\n+ * @param classCacheDir a cache directory on the local machine used to cache class files of\n+ * the created feature functions used in the models produced by the\n+ * factory.\n+ * @param dereferenceAsOptional whether to treat the dereferencing of repeated variables as\n+ * an optional type. This avoids index out of bounds exceptions\n+ * and is safer but slightly slower.\n+ */\n+case class SchemaConfig(\n+ schema: Schema,\n+ modelCodomainRefInfoStr: String,\n+ imports: Seq[String] = Nil,\n+ classCacheDir: Option[File] = None,\n+ dereferenceAsOptional: Boolean = true\n+) extends FactoryConfig {\n+\n+ /**\n+ * @return A Try of a ModelFactory that creates models taking `GenericRecord` instances as\n+ * input and returns `com.eharmony.aloha.audit.impl.avro.Score` as output.\n+ */\n+ def apply(): Try[ModelFactory[GenericRecord, Score]] = {\n+ val f = for {\n+ ri <- refInfo(modelCodomainRefInfoStr)\n+ a <- auditor(ri)\n+ s = semantics(schema, imports, classCacheDir, dereferenceAsOptional)\n+ mf = ModelFactory.defaultFactory(s, a)(ri)\n+ } yield mf\n+\n+ FactoryConfig.wrapException(f)\n+ }\n+}\n+\n+/**\n+ * Provides an easy interface for creating ModelFactory instances that both take and\n+ * return Avro objects.\n+ *\n+ * This is especially useful for creating factories in generic services because the\n+ * `modelCodomainRefInfoStr` is a string rather than `RefInfo` so it can come from a\n+ * property file.\n+ *\n+ * @param vfs A [[com.eharmony.aloha.io.vfs.Vfs]] wrapper around a URL pointing to a JSON Avro\n+ * Schema that represents the data passed to models created by this factory.\n+ * @param modelCodomainRefInfoStr A string representation of a `com.eharmony.aloha.reflect.RefInfo`.\n+ * @param imports imports to be injected into feature functions synthesized by the factory.\n+ * @param classCacheDir a cache directory on the local machine used to cache class files of\n+ * the created feature functions used in the models produced by the\n+ * factory.\n+ * @param dereferenceAsOptional whether to treat the dereferencing of repeated variables as\n+ * an optional type. This avoids index out of bounds exceptions\n+ * and is safer but slightly slower.\n+ */\n+case class UrlConfig(\n+ vfs: Vfs,","path":"aloha-io-avro/src/main/scala/com/eharmony/aloha/factory/avro/factory_config.scala","position":131,"original_position":131,"commit_id":"988198f24b1f67c339b703f2e9cd22f4ad4a7745","original_commit_id":"988198f24b1f67c339b703f2e9cd22f4ad4a7745","user":{"login":"jmorra","id":117275,"avatar_url":"https://avatars1.githubusercontent.com/u/117275?v=3","gravatar_id":"","url":"https://api.github.com/users/jmorra","html_url":"https://github.com/jmorra","followers_url":"https://api.github.com/users/jmorra/followers","following_url":"https://api.github.com/users/jmorra/following{/other_user}","gists_url":"https://api.github.com/users/jmorra/gists{/gist_id}","starred_url":"https://api.github.com/users/jmorra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmorra/subscriptions","organizations_url":"https://api.github.com/users/jmorra/orgs","repos_url":"https://api.github.com/users/jmorra/repos","events_url":"https://api.github.com/users/jmorra/events{/privacy}","received_events_url":"https://api.github.com/users/jmorra/received_events","type":"User","site_admin":false},"body":"I think the way it is is fine. I like this.","created_at":"2017-03-08T20:51:10Z","updated_at":"2017-03-08T20:51:42Z","html_url":"https://github.com/eHarmony/aloha/pull/140#discussion_r105019212","pull_request_url":"https://api.github.com/repos/eHarmony/aloha/pulls/140","_links":{"self":{"href":"https://api.github.com/repos/eHarmony/aloha/pulls/comments/105019212"},"html":{"href":"https://github.com/eHarmony/aloha/pull/140#discussion_r105019212"},"pull_request":{"href":"https://api.github.com/repos/eHarmony/aloha/pulls/140"}}},"pull_request":{"url":"https://api.github.com/repos/eHarmony/aloha/pulls/140","id":109390078,"html_url":"https://github.com/eHarmony/aloha/pull/140","diff_url":"https://github.com/eHarmony/aloha/pull/140.diff","patch_url":"https://github.com/eHarmony/aloha/pull/140.patch","issue_url":"https://api.github.com/repos/eHarmony/aloha/issues/140","number":140,"state":"open","locked":false,"title":"Closes #139","user":{"login":"deaktator","id":6218239,"avatar_url":"https://avatars2.githubusercontent.com/u/6218239?v=3","gravatar_id":"","url":"https://api.github.com/users/deaktator","html_url":"https://github.com/deaktator","followers_url":"https://api.github.com/users/deaktator/followers","following_url":"https://api.github.com/users/deaktator/following{/other_user}","gists_url":"https://api.github.com/users/deaktator/gists{/gist_id}","starred_url":"https://api.github.com/users/deaktator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deaktator/subscriptions","organizations_url":"https://api.github.com/users/deaktator/orgs","repos_url":"https://api.github.com/users/deaktator/repos","events_url":"https://api.github.com/users/deaktator/events{/privacy}","received_events_url":"https://api.github.com/users/deaktator/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-07T01:51:51Z","updated_at":"2017-03-08T20:51:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72b16dfa2ab7c7b6357302067dd112b2f0a0edf3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eHarmony/aloha/pulls/140/commits","review_comments_url":"https://api.github.com/repos/eHarmony/aloha/pulls/140/comments","review_comment_url":"https://api.github.com/repos/eHarmony/aloha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eHarmony/aloha/issues/140/comments","statuses_url":"https://api.github.com/repos/eHarmony/aloha/statuses/988198f24b1f67c339b703f2e9cd22f4ad4a7745","head":{"label":"eHarmony:139-addl-avro-factory-conv-method","ref":"139-addl-avro-factory-conv-method","sha":"988198f24b1f67c339b703f2e9cd22f4ad4a7745","user":{"login":"eHarmony","id":1245717,"avatar_url":"https://avatars2.githubusercontent.com/u/1245717?v=3","gravatar_id":"","url":"https://api.github.com/users/eHarmony","html_url":"https://github.com/eHarmony","followers_url":"https://api.github.com/users/eHarmony/followers","following_url":"https://api.github.com/users/eHarmony/following{/other_user}","gists_url":"https://api.github.com/users/eHarmony/gists{/gist_id}","starred_url":"https://api.github.com/users/eHarmony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eHarmony/subscriptions","organizations_url":"https://api.github.com/users/eHarmony/orgs","repos_url":"https://api.github.com/users/eHarmony/repos","events_url":"https://api.github.com/users/eHarmony/events{/privacy}","received_events_url":"https://api.github.com/users/eHarmony/received_events","type":"Organization","site_admin":false},"repo":{"id":38333748,"name":"aloha","full_name":"eHarmony/aloha","owner":{"login":"eHarmony","id":1245717,"avatar_url":"https://avatars2.githubusercontent.com/u/1245717?v=3","gravatar_id":"","url":"https://api.github.com/users/eHarmony","html_url":"https://github.com/eHarmony","followers_url":"https://api.github.com/users/eHarmony/followers","following_url":"https://api.github.com/users/eHarmony/following{/other_user}","gists_url":"https://api.github.com/users/eHarmony/gists{/gist_id}","starred_url":"https://api.github.com/users/eHarmony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eHarmony/subscriptions","organizations_url":"https://api.github.com/users/eHarmony/orgs","repos_url":"https://api.github.com/users/eHarmony/repos","events_url":"https://api.github.com/users/eHarmony/events{/privacy}","received_events_url":"https://api.github.com/users/eHarmony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eHarmony/aloha","description":"A scala-based feature generation and modeling framework","fork":false,"url":"https://api.github.com/repos/eHarmony/aloha","forks_url":"https://api.github.com/repos/eHarmony/aloha/forks","keys_url":"https://api.github.com/repos/eHarmony/aloha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eHarmony/aloha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eHarmony/aloha/teams","hooks_url":"https://api.github.com/repos/eHarmony/aloha/hooks","issue_events_url":"https://api.github.com/repos/eHarmony/aloha/issues/events{/number}","events_url":"https://api.github.com/repos/eHarmony/aloha/events","assignees_url":"https://api.github.com/repos/eHarmony/aloha/assignees{/user}","branches_url":"https://api.github.com/repos/eHarmony/aloha/branches{/branch}","tags_url":"https://api.github.com/repos/eHarmony/aloha/tags","blobs_url":"https://api.github.com/repos/eHarmony/aloha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eHarmony/aloha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eHarmony/aloha/git/refs{/sha}","trees_url":"https://api.github.com/repos/eHarmony/aloha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eHarmony/aloha/statuses/{sha}","languages_url":"https://api.github.com/repos/eHarmony/aloha/languages","stargazers_url":"https://api.github.com/repos/eHarmony/aloha/stargazers","contributors_url":"https://api.github.com/repos/eHarmony/aloha/contributors","subscribers_url":"https://api.github.com/repos/eHarmony/aloha/subscribers","subscription_url":"https://api.github.com/repos/eHarmony/aloha/subscription","commits_url":"https://api.github.com/repos/eHarmony/aloha/commits{/sha}","git_commits_url":"https://api.github.com/repos/eHarmony/aloha/git/commits{/sha}","comments_url":"https://api.github.com/repos/eHarmony/aloha/comments{/number}","issue_comment_url":"https://api.github.com/repos/eHarmony/aloha/issues/comments{/number}","contents_url":"https://api.github.com/repos/eHarmony/aloha/contents/{+path}","compare_url":"https://api.github.com/repos/eHarmony/aloha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eHarmony/aloha/merges","archive_url":"https://api.github.com/repos/eHarmony/aloha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eHarmony/aloha/downloads","issues_url":"https://api.github.com/repos/eHarmony/aloha/issues{/number}","pulls_url":"https://api.github.com/repos/eHarmony/aloha/pulls{/number}","milestones_url":"https://api.github.com/repos/eHarmony/aloha/milestones{/number}","notifications_url":"https://api.github.com/repos/eHarmony/aloha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eHarmony/aloha/labels{/name}","releases_url":"https://api.github.com/repos/eHarmony/aloha/releases{/id}","deployments_url":"https://api.github.com/repos/eHarmony/aloha/deployments","created_at":"2015-06-30T21:21:33Z","updated_at":"2017-03-08T20:33:42Z","pushed_at":"2017-03-08T20:01:53Z","git_url":"git://github.com/eHarmony/aloha.git","ssh_url":"[email protected]:eHarmony/aloha.git","clone_url":"https://github.com/eHarmony/aloha.git","svn_url":"https://github.com/eHarmony/aloha","homepage":"http://eharmony.github.io/aloha","size":8377,"stargazers_count":32,"watchers_count":32,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":30,"forks":8,"open_issues":30,"watchers":32,"default_branch":"master"}},"base":{"label":"eHarmony:master","ref":"master","sha":"966a03042cb2da7c367fcc09fa81b68b38e16a9e","user":{"login":"eHarmony","id":1245717,"avatar_url":"https://avatars2.githubusercontent.com/u/1245717?v=3","gravatar_id":"","url":"https://api.github.com/users/eHarmony","html_url":"https://github.com/eHarmony","followers_url":"https://api.github.com/users/eHarmony/followers","following_url":"https://api.github.com/users/eHarmony/following{/other_user}","gists_url":"https://api.github.com/users/eHarmony/gists{/gist_id}","starred_url":"https://api.github.com/users/eHarmony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eHarmony/subscriptions","organizations_url":"https://api.github.com/users/eHarmony/orgs","repos_url":"https://api.github.com/users/eHarmony/repos","events_url":"https://api.github.com/users/eHarmony/events{/privacy}","received_events_url":"https://api.github.com/users/eHarmony/received_events","type":"Organization","site_admin":false},"repo":{"id":38333748,"name":"aloha","full_name":"eHarmony/aloha","owner":{"login":"eHarmony","id":1245717,"avatar_url":"https://avatars2.githubusercontent.com/u/1245717?v=3","gravatar_id":"","url":"https://api.github.com/users/eHarmony","html_url":"https://github.com/eHarmony","followers_url":"https://api.github.com/users/eHarmony/followers","following_url":"https://api.github.com/users/eHarmony/following{/other_user}","gists_url":"https://api.github.com/users/eHarmony/gists{/gist_id}","starred_url":"https://api.github.com/users/eHarmony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eHarmony/subscriptions","organizations_url":"https://api.github.com/users/eHarmony/orgs","repos_url":"https://api.github.com/users/eHarmony/repos","events_url":"https://api.github.com/users/eHarmony/events{/privacy}","received_events_url":"https://api.github.com/users/eHarmony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eHarmony/aloha","description":"A scala-based feature generation and modeling framework","fork":false,"url":"https://api.github.com/repos/eHarmony/aloha","forks_url":"https://api.github.com/repos/eHarmony/aloha/forks","keys_url":"https://api.github.com/repos/eHarmony/aloha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eHarmony/aloha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eHarmony/aloha/teams","hooks_url":"https://api.github.com/repos/eHarmony/aloha/hooks","issue_events_url":"https://api.github.com/repos/eHarmony/aloha/issues/events{/number}","events_url":"https://api.github.com/repos/eHarmony/aloha/events","assignees_url":"https://api.github.com/repos/eHarmony/aloha/assignees{/user}","branches_url":"https://api.github.com/repos/eHarmony/aloha/branches{/branch}","tags_url":"https://api.github.com/repos/eHarmony/aloha/tags","blobs_url":"https://api.github.com/repos/eHarmony/aloha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eHarmony/aloha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eHarmony/aloha/git/refs{/sha}","trees_url":"https://api.github.com/repos/eHarmony/aloha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eHarmony/aloha/statuses/{sha}","languages_url":"https://api.github.com/repos/eHarmony/aloha/languages","stargazers_url":"https://api.github.com/repos/eHarmony/aloha/stargazers","contributors_url":"https://api.github.com/repos/eHarmony/aloha/contributors","subscribers_url":"https://api.github.com/repos/eHarmony/aloha/subscribers","subscription_url":"https://api.github.com/repos/eHarmony/aloha/subscription","commits_url":"https://api.github.com/repos/eHarmony/aloha/commits{/sha}","git_commits_url":"https://api.github.com/repos/eHarmony/aloha/git/commits{/sha}","comments_url":"https://api.github.com/repos/eHarmony/aloha/comments{/number}","issue_comment_url":"https://api.github.com/repos/eHarmony/aloha/issues/comments{/number}","contents_url":"https://api.github.com/repos/eHarmony/aloha/contents/{+path}","compare_url":"https://api.github.com/repos/eHarmony/aloha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eHarmony/aloha/merges","archive_url":"https://api.github.com/repos/eHarmony/aloha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eHarmony/aloha/downloads","issues_url":"https://api.github.com/repos/eHarmony/aloha/issues{/number}","pulls_url":"https://api.github.com/repos/eHarmony/aloha/pulls{/number}","milestones_url":"https://api.github.com/repos/eHarmony/aloha/milestones{/number}","notifications_url":"https://api.github.com/repos/eHarmony/aloha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eHarmony/aloha/labels{/name}","releases_url":"https://api.github.com/repos/eHarmony/aloha/releases{/id}","deployments_url":"https://api.github.com/repos/eHarmony/aloha/deployments","created_at":"2015-06-30T21:21:33Z","updated_at":"2017-03-08T20:33:42Z","pushed_at":"2017-03-08T20:01:53Z","git_url":"git://github.com/eHarmony/aloha.git","ssh_url":"[email protected]:eHarmony/aloha.git","clone_url":"https://github.com/eHarmony/aloha.git","svn_url":"https://github.com/eHarmony/aloha","homepage":"http://eharmony.github.io/aloha","size":8377,"stargazers_count":32,"watchers_count":32,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":30,"forks":8,"open_issues":30,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eHarmony/aloha/pulls/140"},"html":{"href":"https://github.com/eHarmony/aloha/pull/140"},"issue":{"href":"https://api.github.com/repos/eHarmony/aloha/issues/140"},"comments":{"href":"https://api.github.com/repos/eHarmony/aloha/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/eHarmony/aloha/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/eHarmony/aloha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eHarmony/aloha/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/eHarmony/aloha/statuses/988198f24b1f67c339b703f2e9cd22f4ad4a7745"}}}} | {
"id": 38333748,
"name": "eHarmony/aloha",
"url": "https://api.github.com/repos/eHarmony/aloha"
} | {
"id": 117275,
"login": "jmorra",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/117275?",
"url": "https://api.github.com/users/jmorra"
} | {
"id": 1245717,
"login": "eHarmony",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1245717?",
"url": "https://api.github.com/orgs/eHarmony"
} | 2017-03-08T20:51:10 | 5458153498 | {"actor":{"display_login":"jmorra"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/eilslabs/Roddy/pulls/comments/102212797","pull_request_review_id":22961469,"id":102212797,"diff_hunk":"@@ -876,49 +876,52 @@ public class ConfigurationFactory {\n }\n \n // A file can have several defined child files\n- List<ToolEntry.ToolFileParameter> subParameters = new LinkedList<ToolEntry.ToolFileParameter>();\n+ List<ToolFileParameter> subParameters = new LinkedList<ToolFileParameter>();\n for (NodeChild fileChild in child.children()) {\n- subParameters << (ToolEntry.ToolFileParameter) parseToolParameter(toolID, fileChild);\n+ subParameters << (ToolFileParameter) parseToolParameter(toolID, fileChild);\n }\n- ToolEntry.ToolFileParameter tp = new ToolEntry.ToolFileParameter(_cls, constraints, pName, check, fnpSelTag, subParameters, parentFileVariable);\n+ ToolFileParameter tp = new ToolFileParameter(_cls, constraints, pName, check, fnpSelTag, subParameters, parentFileVariable);\n \n return tp;\n }\n \n @groovy.transform.CompileStatic(TypeCheckingMode.SKIP)\n- private ToolEntry.ToolTupleParameter parseTuple(NodeChild child, String toolID) {\n+ static ToolTupleParameter parseTuple(NodeChild child, String toolID) {\n int tupleSize = child.children().size();\n if (!FileObjectTupleFactory.isValidSize(tupleSize)) {\n logger.severe(\"Tuple is of wrong size for tool ${toolID}.\")\n }\n- List<ToolEntry.ToolFileParameter> subParameters = new LinkedList<ToolEntry.ToolFileParameter>();\n+ List<ToolFileParameter> subParameters = new LinkedList<ToolFileParameter>();\n for (NodeChild fileChild in child.children()) {\n- subParameters << (ToolEntry.ToolFileParameter) parseToolParameter(toolID, fileChild);\n+ subParameters << (ToolFileParameter) parseToolParameter(toolID, fileChild);\n }\n- return new ToolEntry.ToolTupleParameter(subParameters);\n+ return new ToolTupleParameter(subParameters);\n }\n \n @groovy.transform.CompileStatic(TypeCheckingMode.SKIP)\n- public ToolEntry.ToolFileGroupParameter parseFileGroup(NodeChild child, String toolID) {\n+ static ToolFileGroupParameter parseFileGroup(NodeChild child, String toolID) {\n String cls = [email protected]();\n Class filegroupClass = LibrariesFactory.getInstance().loadRealOrSyntheticClass(cls, FileGroup.class);\n \n PassOptions passas = Enum.valueOf(PassOptions.class, extractAttributeText(child, \"passas\", PassOptions.parameters.name()));\n+ ToolFileGroupParameter.IndexOptions indexOptions = Enum.valueOf(ToolFileGroupParameter.IndexOptions.class, extractAttributeText(child, \"indices\", ToolFileGroupParameter.IndexOptions.numeric.name()))\n+\n Class genericFileClass = null\n String fileclass = extractAttributeText(child, \"fileclass\", null);\n if (fileclass) {\n genericFileClass = LibrariesFactory.getInstance().loadRealOrSyntheticClass(fileclass, BaseFile.class)\n }\n String pName = [email protected]();\n \n- List<ToolEntry.ToolFileParameter> subParameters = new LinkedList<ToolEntry.ToolFileParameter>();\n+\n+ List<ToolFileParameter> subParameters = new LinkedList<ToolFileParameter>();\n int childCount = child.children().size();\n if (childCount == 0 && passas != PassOptions.array)\n logger.severe(\"No files in the file group. Configuration is not valid.\")\n for (NodeChild fileChild in child.children()) {\n- subParameters << (ToolEntry.ToolFileParameter) parseToolParameter(toolID, fileChild);\n+ subParameters << (ToolFileParameter) parseToolParameter(toolID, fileChild);\n }\n- ToolEntry.ToolFileGroupParameter tpg = new ToolEntry.ToolFileGroupParameter(filegroupClass, genericFileClass, subParameters, pName, passas);\n+ ToolFileGroupParameter tpg = new ToolFileGroupParameter(filegroupClass, genericFileClass, subParameters, pName, passas, indexOptions);","path":"RoddyCore/src/de/dkfz/roddy/config/ConfigurationFactory.groovy","position":null,"original_position":196,"commit_id":"1c3b4de4a88e4bd58a099c8799186c44753f0fe8","original_commit_id":"c50bab88fccec8f0af6ee420b106c98bc58083d1","user":{"login":"dankwart-de","id":6582183,"avatar_url":"https://avatars.githubusercontent.com/u/6582183?v=3","gravatar_id":"","url":"https://api.github.com/users/dankwart-de","html_url":"https://github.com/dankwart-de","followers_url":"https://api.github.com/users/dankwart-de/followers","following_url":"https://api.github.com/users/dankwart-de/following{/other_user}","gists_url":"https://api.github.com/users/dankwart-de/gists{/gist_id}","starred_url":"https://api.github.com/users/dankwart-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankwart-de/subscriptions","organizations_url":"https://api.github.com/users/dankwart-de/orgs","repos_url":"https://api.github.com/users/dankwart-de/repos","events_url":"https://api.github.com/users/dankwart-de/events{/privacy}","received_events_url":"https://api.github.com/users/dankwart-de/received_events","type":"User","site_admin":false},"body":"That is because in the xml it is without camel case. Can change that.","created_at":"2017-02-21T14:02:35Z","updated_at":"2017-02-21T14:06:19Z","html_url":"https://github.com/eilslabs/Roddy/pull/17#discussion_r102212797","pull_request_url":"https://api.github.com/repos/eilslabs/Roddy/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/eilslabs/Roddy/pulls/comments/102212797"},"html":{"href":"https://github.com/eilslabs/Roddy/pull/17#discussion_r102212797"},"pull_request":{"href":"https://api.github.com/repos/eilslabs/Roddy/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/eilslabs/Roddy/pulls/17","id":105962266,"html_url":"https://github.com/eilslabs/Roddy/pull/17","diff_url":"https://github.com/eilslabs/Roddy/pull/17.diff","patch_url":"https://github.com/eilslabs/Roddy/pull/17.patch","issue_url":"https://api.github.com/repos/eilslabs/Roddy/issues/17","number":17,"state":"open","locked":false,"title":"Correct File group return value","user":{"login":"dankwart-de","id":6582183,"avatar_url":"https://avatars.githubusercontent.com/u/6582183?v=3","gravatar_id":"","url":"https://api.github.com/users/dankwart-de","html_url":"https://github.com/dankwart-de","followers_url":"https://api.github.com/users/dankwart-de/followers","following_url":"https://api.github.com/users/dankwart-de/following{/other_user}","gists_url":"https://api.github.com/users/dankwart-de/gists{/gist_id}","starred_url":"https://api.github.com/users/dankwart-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankwart-de/subscriptions","organizations_url":"https://api.github.com/users/dankwart-de/orgs","repos_url":"https://api.github.com/users/dankwart-de/repos","events_url":"https://api.github.com/users/dankwart-de/events{/privacy}","received_events_url":"https://api.github.com/users/dankwart-de/received_events","type":"User","site_admin":false},"body":"Add some code for the libraries factory class. This can already be reviewed. Still working on the code for the filegroup return type.","created_at":"2017-02-13T19:28:57Z","updated_at":"2017-02-21T14:06:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c490aa67ec52c89fbf95b812381b71dfdb9c300","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eilslabs/Roddy/pulls/17/commits","review_comments_url":"https://api.github.com/repos/eilslabs/Roddy/pulls/17/comments","review_comment_url":"https://api.github.com/repos/eilslabs/Roddy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eilslabs/Roddy/issues/17/comments","statuses_url":"https://api.github.com/repos/eilslabs/Roddy/statuses/1c3b4de4a88e4bd58a099c8799186c44753f0fe8","head":{"label":"eilslabs:FileGroupReturnValue","ref":"FileGroupReturnValue","sha":"1c3b4de4a88e4bd58a099c8799186c44753f0fe8","user":{"login":"eilslabs","id":20515839,"avatar_url":"https://avatars.githubusercontent.com/u/20515839?v=3","gravatar_id":"","url":"https://api.github.com/users/eilslabs","html_url":"https://github.com/eilslabs","followers_url":"https://api.github.com/users/eilslabs/followers","following_url":"https://api.github.com/users/eilslabs/following{/other_user}","gists_url":"https://api.github.com/users/eilslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/eilslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eilslabs/subscriptions","organizations_url":"https://api.github.com/users/eilslabs/orgs","repos_url":"https://api.github.com/users/eilslabs/repos","events_url":"https://api.github.com/users/eilslabs/events{/privacy}","received_events_url":"https://api.github.com/users/eilslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":63849581,"name":"Roddy","full_name":"eilslabs/Roddy","owner":{"login":"eilslabs","id":20515839,"avatar_url":"https://avatars.githubusercontent.com/u/20515839?v=3","gravatar_id":"","url":"https://api.github.com/users/eilslabs","html_url":"https://github.com/eilslabs","followers_url":"https://api.github.com/users/eilslabs/followers","following_url":"https://api.github.com/users/eilslabs/following{/other_user}","gists_url":"https://api.github.com/users/eilslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/eilslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eilslabs/subscriptions","organizations_url":"https://api.github.com/users/eilslabs/orgs","repos_url":"https://api.github.com/users/eilslabs/repos","events_url":"https://api.github.com/users/eilslabs/events{/privacy}","received_events_url":"https://api.github.com/users/eilslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eilslabs/Roddy","description":"The Roddy workflow development and management system.","fork":false,"url":"https://api.github.com/repos/eilslabs/Roddy","forks_url":"https://api.github.com/repos/eilslabs/Roddy/forks","keys_url":"https://api.github.com/repos/eilslabs/Roddy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eilslabs/Roddy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eilslabs/Roddy/teams","hooks_url":"https://api.github.com/repos/eilslabs/Roddy/hooks","issue_events_url":"https://api.github.com/repos/eilslabs/Roddy/issues/events{/number}","events_url":"https://api.github.com/repos/eilslabs/Roddy/events","assignees_url":"https://api.github.com/repos/eilslabs/Roddy/assignees{/user}","branches_url":"https://api.github.com/repos/eilslabs/Roddy/branches{/branch}","tags_url":"https://api.github.com/repos/eilslabs/Roddy/tags","blobs_url":"https://api.github.com/repos/eilslabs/Roddy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eilslabs/Roddy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eilslabs/Roddy/git/refs{/sha}","trees_url":"https://api.github.com/repos/eilslabs/Roddy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eilslabs/Roddy/statuses/{sha}","languages_url":"https://api.github.com/repos/eilslabs/Roddy/languages","stargazers_url":"https://api.github.com/repos/eilslabs/Roddy/stargazers","contributors_url":"https://api.github.com/repos/eilslabs/Roddy/contributors","subscribers_url":"https://api.github.com/repos/eilslabs/Roddy/subscribers","subscription_url":"https://api.github.com/repos/eilslabs/Roddy/subscription","commits_url":"https://api.github.com/repos/eilslabs/Roddy/commits{/sha}","git_commits_url":"https://api.github.com/repos/eilslabs/Roddy/git/commits{/sha}","comments_url":"https://api.github.com/repos/eilslabs/Roddy/comments{/number}","issue_comment_url":"https://api.github.com/repos/eilslabs/Roddy/issues/comments{/number}","contents_url":"https://api.github.com/repos/eilslabs/Roddy/contents/{+path}","compare_url":"https://api.github.com/repos/eilslabs/Roddy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eilslabs/Roddy/merges","archive_url":"https://api.github.com/repos/eilslabs/Roddy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eilslabs/Roddy/downloads","issues_url":"https://api.github.com/repos/eilslabs/Roddy/issues{/number}","pulls_url":"https://api.github.com/repos/eilslabs/Roddy/pulls{/number}","milestones_url":"https://api.github.com/repos/eilslabs/Roddy/milestones{/number}","notifications_url":"https://api.github.com/repos/eilslabs/Roddy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eilslabs/Roddy/labels{/name}","releases_url":"https://api.github.com/repos/eilslabs/Roddy/releases{/id}","deployments_url":"https://api.github.com/repos/eilslabs/Roddy/deployments","created_at":"2016-07-21T08:04:37Z","updated_at":"2016-11-24T17:15:33Z","pushed_at":"2017-02-21T12:36:45Z","git_url":"git://github.com/eilslabs/Roddy.git","ssh_url":"[email protected]:eilslabs/Roddy.git","clone_url":"https://github.com/eilslabs/Roddy.git","svn_url":"https://github.com/eilslabs/Roddy","homepage":null,"size":273689,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"eilslabs:develop","ref":"develop","sha":"3733c4293d5f83b5405ac3a04198ac10e9e82ff4","user":{"login":"eilslabs","id":20515839,"avatar_url":"https://avatars.githubusercontent.com/u/20515839?v=3","gravatar_id":"","url":"https://api.github.com/users/eilslabs","html_url":"https://github.com/eilslabs","followers_url":"https://api.github.com/users/eilslabs/followers","following_url":"https://api.github.com/users/eilslabs/following{/other_user}","gists_url":"https://api.github.com/users/eilslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/eilslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eilslabs/subscriptions","organizations_url":"https://api.github.com/users/eilslabs/orgs","repos_url":"https://api.github.com/users/eilslabs/repos","events_url":"https://api.github.com/users/eilslabs/events{/privacy}","received_events_url":"https://api.github.com/users/eilslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":63849581,"name":"Roddy","full_name":"eilslabs/Roddy","owner":{"login":"eilslabs","id":20515839,"avatar_url":"https://avatars.githubusercontent.com/u/20515839?v=3","gravatar_id":"","url":"https://api.github.com/users/eilslabs","html_url":"https://github.com/eilslabs","followers_url":"https://api.github.com/users/eilslabs/followers","following_url":"https://api.github.com/users/eilslabs/following{/other_user}","gists_url":"https://api.github.com/users/eilslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/eilslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eilslabs/subscriptions","organizations_url":"https://api.github.com/users/eilslabs/orgs","repos_url":"https://api.github.com/users/eilslabs/repos","events_url":"https://api.github.com/users/eilslabs/events{/privacy}","received_events_url":"https://api.github.com/users/eilslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eilslabs/Roddy","description":"The Roddy workflow development and management system.","fork":false,"url":"https://api.github.com/repos/eilslabs/Roddy","forks_url":"https://api.github.com/repos/eilslabs/Roddy/forks","keys_url":"https://api.github.com/repos/eilslabs/Roddy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eilslabs/Roddy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eilslabs/Roddy/teams","hooks_url":"https://api.github.com/repos/eilslabs/Roddy/hooks","issue_events_url":"https://api.github.com/repos/eilslabs/Roddy/issues/events{/number}","events_url":"https://api.github.com/repos/eilslabs/Roddy/events","assignees_url":"https://api.github.com/repos/eilslabs/Roddy/assignees{/user}","branches_url":"https://api.github.com/repos/eilslabs/Roddy/branches{/branch}","tags_url":"https://api.github.com/repos/eilslabs/Roddy/tags","blobs_url":"https://api.github.com/repos/eilslabs/Roddy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eilslabs/Roddy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eilslabs/Roddy/git/refs{/sha}","trees_url":"https://api.github.com/repos/eilslabs/Roddy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eilslabs/Roddy/statuses/{sha}","languages_url":"https://api.github.com/repos/eilslabs/Roddy/languages","stargazers_url":"https://api.github.com/repos/eilslabs/Roddy/stargazers","contributors_url":"https://api.github.com/repos/eilslabs/Roddy/contributors","subscribers_url":"https://api.github.com/repos/eilslabs/Roddy/subscribers","subscription_url":"https://api.github.com/repos/eilslabs/Roddy/subscription","commits_url":"https://api.github.com/repos/eilslabs/Roddy/commits{/sha}","git_commits_url":"https://api.github.com/repos/eilslabs/Roddy/git/commits{/sha}","comments_url":"https://api.github.com/repos/eilslabs/Roddy/comments{/number}","issue_comment_url":"https://api.github.com/repos/eilslabs/Roddy/issues/comments{/number}","contents_url":"https://api.github.com/repos/eilslabs/Roddy/contents/{+path}","compare_url":"https://api.github.com/repos/eilslabs/Roddy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eilslabs/Roddy/merges","archive_url":"https://api.github.com/repos/eilslabs/Roddy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eilslabs/Roddy/downloads","issues_url":"https://api.github.com/repos/eilslabs/Roddy/issues{/number}","pulls_url":"https://api.github.com/repos/eilslabs/Roddy/pulls{/number}","milestones_url":"https://api.github.com/repos/eilslabs/Roddy/milestones{/number}","notifications_url":"https://api.github.com/repos/eilslabs/Roddy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eilslabs/Roddy/labels{/name}","releases_url":"https://api.github.com/repos/eilslabs/Roddy/releases{/id}","deployments_url":"https://api.github.com/repos/eilslabs/Roddy/deployments","created_at":"2016-07-21T08:04:37Z","updated_at":"2016-11-24T17:15:33Z","pushed_at":"2017-02-21T12:36:45Z","git_url":"git://github.com/eilslabs/Roddy.git","ssh_url":"[email protected]:eilslabs/Roddy.git","clone_url":"https://github.com/eilslabs/Roddy.git","svn_url":"https://github.com/eilslabs/Roddy","homepage":null,"size":273689,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/eilslabs/Roddy/pulls/17"},"html":{"href":"https://github.com/eilslabs/Roddy/pull/17"},"issue":{"href":"https://api.github.com/repos/eilslabs/Roddy/issues/17"},"comments":{"href":"https://api.github.com/repos/eilslabs/Roddy/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/eilslabs/Roddy/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/eilslabs/Roddy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eilslabs/Roddy/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/eilslabs/Roddy/statuses/1c3b4de4a88e4bd58a099c8799186c44753f0fe8"}}}} | {
"id": 63849581,
"name": "eilslabs/Roddy",
"url": "https://api.github.com/repos/eilslabs/Roddy"
} | {
"id": 6582183,
"login": "dankwart-de",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6582183?",
"url": "https://api.github.com/users/dankwart-de"
} | {
"id": 20515839,
"login": "eilslabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20515839?",
"url": "https://api.github.com/orgs/eilslabs"
} | 2017-02-21T14:02:35 | 5362425063 | {"actor":{"display_login":"dankwart-de"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/eos-desktop/pulls/comments/104578142","pull_request_review_id":25420071,"id":104578142,"diff_hunk":"@@ -652,38 +879,103 @@ const CodingManager = new Lang.Class({\n });\n },\n \n- _animateButtons: function(src, dst) {\n- src.show();\n- dst.show();\n- dst.opacity = 0;\n- src.opacity = 255;\n- Tweener.addTween(src, {\n- opacity: 0,\n- time: WINDOW_ANIMATION_TIME,\n- transition: 'linear',\n- onComplete: function(button) { button.hide();\n- button.opacity = 255; },\n- onCompleteParams: [src]\n- });\n+ // We need to keep these separate here so that they can be called\n+ // by killEffects later if required.\n+ _rotateInCompleted: function() {\n+ let actor = this._rotatingInActor;\n+ if (!actor)\n+ return;\n \n- Tweener.addTween(dst, {\n- opacity: 255,\n- delay: WINDOW_ANIMATION_TIME * 4,\n- time: WINDOW_ANIMATION_TIME * 4,\n- transition: 'linear'\n- });\n+ Tweener.removeTweens(actor);\n+ actor.opacity = 255;\n+ actor.rotation_angle_y = 0;\n+ actor.set_cull_back_face(false);\n+ this._rotatingInActor = null;\n },\n \n- _removeEffect: function(list, actor) {\n- let idx = list.indexOf(actor);\n- if (idx != -1) {\n- list.splice(idx, 1);\n- return true;\n+ _rotateOutCompleted: function() {\n+ let actor = this._rotatingOutActor;\n+ if (!actor)\n+ return;\n+\n+ Tweener.removeTweens(actor);\n+ actor.hide();\n+ actor.rotation_angle_y = 0;\n+ actor.set_cull_back_face(false);\n+ this._rotatingOutActor = null;\n+ },\n+\n+ _stopWatchingForBuilderWindowToComeOnline: function() {\n+ let tracker = Shell.WindowTracker.get_default();\n+ tracker.untrack_coding_app_window();\n+ if (this._watchdogId !== 0) {\n+ Mainloop.source_remove(this._watchdogId);\n+ this._watchdogId = 0;\n }\n+\n+ this._watchdogId = 0;","path":"js/ui/codingManager.js","position":1292,"original_position":1292,"commit_id":"a23e6ed823b2c62c93e729ccb552946863a01e9d","original_commit_id":"a23e6ed823b2c62c93e729ccb552946863a01e9d","user":{"login":"cosimoc","id":13906,"avatar_url":"https://avatars2.githubusercontent.com/u/13906?v=3","gravatar_id":"","url":"https://api.github.com/users/cosimoc","html_url":"https://github.com/cosimoc","followers_url":"https://api.github.com/users/cosimoc/followers","following_url":"https://api.github.com/users/cosimoc/following{/other_user}","gists_url":"https://api.github.com/users/cosimoc/gists{/gist_id}","starred_url":"https://api.github.com/users/cosimoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosimoc/subscriptions","organizations_url":"https://api.github.com/users/cosimoc/orgs","repos_url":"https://api.github.com/users/cosimoc/repos","events_url":"https://api.github.com/users/cosimoc/events{/privacy}","received_events_url":"https://api.github.com/users/cosimoc/received_events","type":"User","site_admin":false},"body":"Remove this","created_at":"2017-03-07T02:49:58Z","updated_at":"2017-03-07T02:59:34Z","html_url":"https://github.com/endlessm/eos-desktop/pull/244#discussion_r104578142","pull_request_url":"https://api.github.com/repos/endlessm/eos-desktop/pulls/244","_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-desktop/pulls/comments/104578142"},"html":{"href":"https://github.com/endlessm/eos-desktop/pull/244#discussion_r104578142"},"pull_request":{"href":"https://api.github.com/repos/endlessm/eos-desktop/pulls/244"}}},"pull_request":{"url":"https://api.github.com/repos/endlessm/eos-desktop/pulls/244","id":108837228,"html_url":"https://github.com/endlessm/eos-desktop/pull/244","diff_url":"https://github.com/endlessm/eos-desktop/pull/244.diff","patch_url":"https://github.com/endlessm/eos-desktop/pull/244.patch","issue_url":"https://api.github.com/repos/endlessm/eos-desktop/issues/244","number":244,"state":"open","locked":false,"title":"T15681 Additional refactoring with button animations","user":{"login":"erikos","id":3714785,"avatar_url":"https://avatars2.githubusercontent.com/u/3714785?v=3","gravatar_id":"","url":"https://api.github.com/users/erikos","html_url":"https://github.com/erikos","followers_url":"https://api.github.com/users/erikos/followers","following_url":"https://api.github.com/users/erikos/following{/other_user}","gists_url":"https://api.github.com/users/erikos/gists{/gist_id}","starred_url":"https://api.github.com/users/erikos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikos/subscriptions","organizations_url":"https://api.github.com/users/erikos/orgs","repos_url":"https://api.github.com/users/erikos/repos","events_url":"https://api.github.com/users/erikos/events{/privacy}","received_events_url":"https://api.github.com/users/erikos/received_events","type":"User","site_admin":false},"body":"https://phabricator.endlessm.com/T15681","created_at":"2017-03-02T19:52:24Z","updated_at":"2017-03-07T02:59:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51717f6f8e27c97a4229a3d35c5b72a68a11540b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/eos-desktop/pulls/244/commits","review_comments_url":"https://api.github.com/repos/endlessm/eos-desktop/pulls/244/comments","review_comment_url":"https://api.github.com/repos/endlessm/eos-desktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/eos-desktop/issues/244/comments","statuses_url":"https://api.github.com/repos/endlessm/eos-desktop/statuses/a23e6ed823b2c62c93e729ccb552946863a01e9d","head":{"label":"endlessm:T15681-additional-refactoring-buttonAnim","ref":"T15681-additional-refactoring-buttonAnim","sha":"a23e6ed823b2c62c93e729ccb552946863a01e9d","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":32344042,"name":"eos-desktop","full_name":"endlessm/eos-desktop","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-desktop","description":"Endless Desktop","fork":false,"url":"https://api.github.com/repos/endlessm/eos-desktop","forks_url":"https://api.github.com/repos/endlessm/eos-desktop/forks","keys_url":"https://api.github.com/repos/endlessm/eos-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-desktop/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-desktop/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-desktop/events","assignees_url":"https://api.github.com/repos/endlessm/eos-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-desktop/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-desktop/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-desktop/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-desktop/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-desktop/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-desktop/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-desktop/merges","archive_url":"https://api.github.com/repos/endlessm/eos-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-desktop/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-desktop/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-desktop/deployments","created_at":"2015-03-16T18:15:46Z","updated_at":"2017-02-22T04:22:43Z","pushed_at":"2017-03-06T23:23:43Z","git_url":"git://github.com/endlessm/eos-desktop.git","ssh_url":"[email protected]:endlessm/eos-desktop.git","clone_url":"https://github.com/endlessm/eos-desktop.git","svn_url":"https://github.com/endlessm/eos-desktop","homepage":"http://endlessm.com","size":31162,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":18,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"3c38fa1870297322aeaf2ae87097dded7573403a","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":32344042,"name":"eos-desktop","full_name":"endlessm/eos-desktop","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-desktop","description":"Endless Desktop","fork":false,"url":"https://api.github.com/repos/endlessm/eos-desktop","forks_url":"https://api.github.com/repos/endlessm/eos-desktop/forks","keys_url":"https://api.github.com/repos/endlessm/eos-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-desktop/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-desktop/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-desktop/events","assignees_url":"https://api.github.com/repos/endlessm/eos-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-desktop/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-desktop/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-desktop/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-desktop/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-desktop/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-desktop/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-desktop/merges","archive_url":"https://api.github.com/repos/endlessm/eos-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-desktop/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-desktop/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-desktop/deployments","created_at":"2015-03-16T18:15:46Z","updated_at":"2017-02-22T04:22:43Z","pushed_at":"2017-03-06T23:23:43Z","git_url":"git://github.com/endlessm/eos-desktop.git","ssh_url":"[email protected]:endlessm/eos-desktop.git","clone_url":"https://github.com/endlessm/eos-desktop.git","svn_url":"https://github.com/endlessm/eos-desktop","homepage":"http://endlessm.com","size":31162,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-desktop/pulls/244"},"html":{"href":"https://github.com/endlessm/eos-desktop/pull/244"},"issue":{"href":"https://api.github.com/repos/endlessm/eos-desktop/issues/244"},"comments":{"href":"https://api.github.com/repos/endlessm/eos-desktop/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/eos-desktop/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/eos-desktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/eos-desktop/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/eos-desktop/statuses/a23e6ed823b2c62c93e729ccb552946863a01e9d"}}}} | {
"id": 32344042,
"name": "endlessm/eos-desktop",
"url": "https://api.github.com/repos/endlessm/eos-desktop"
} | {
"id": 13906,
"login": "cosimoc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13906?",
"url": "https://api.github.com/users/cosimoc"
} | {
"id": 1930958,
"login": "endlessm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1930958?",
"url": "https://api.github.com/orgs/endlessm"
} | 2017-03-07T02:49:58 | 5444485315 | {"actor":{"display_login":"cosimoc"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/comments/103713840","pull_request_review_id":24508967,"id":103713840,"diff_hunk":"@@ -76,7 +76,7 @@ while read extent_i extent_size; do\n \n if [ ${i} -lt ${extent_i} ]; then","path":"eos-image-boot-dm-setup","position":14,"original_position":14,"commit_id":"54f1c8cdfdca4ccb43c27d988685d99514f852ce","original_commit_id":"54f1c8cdfdca4ccb43c27d988685d99514f852ce","user":{"login":"wjt","id":86760,"avatar_url":"https://avatars1.githubusercontent.com/u/86760?v=3","gravatar_id":"","url":"https://api.github.com/users/wjt","html_url":"https://github.com/wjt","followers_url":"https://api.github.com/users/wjt/followers","following_url":"https://api.github.com/users/wjt/following{/other_user}","gists_url":"https://api.github.com/users/wjt/gists{/gist_id}","starred_url":"https://api.github.com/users/wjt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjt/subscriptions","organizations_url":"https://api.github.com/users/wjt/orgs","repos_url":"https://api.github.com/users/wjt/repos","events_url":"https://api.github.com/users/wjt/events{/privacy}","received_events_url":"https://api.github.com/users/wjt/received_events","type":"User","site_admin":false},"body":"I'm a bit suspicious of this comparison -- shouldn't this condition always be true, and wouldn't the mapped device get messed up if it's not?","created_at":"2017-03-01T15:42:14Z","updated_at":"2017-03-01T15:42:14Z","html_url":"https://github.com/endlessm/eos-boot-helper/pull/98#discussion_r103713840","pull_request_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/98","_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/comments/103713840"},"html":{"href":"https://github.com/endlessm/eos-boot-helper/pull/98#discussion_r103713840"},"pull_request":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/98","id":108564201,"html_url":"https://github.com/endlessm/eos-boot-helper/pull/98","diff_url":"https://github.com/endlessm/eos-boot-helper/pull/98.diff","patch_url":"https://github.com/endlessm/eos-boot-helper/pull/98.patch","issue_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/98","number":98,"state":"open","locked":false,"title":"image-boot-dm-setup: use zero, not error, for holes","user":{"login":"wjt","id":86760,"avatar_url":"https://avatars1.githubusercontent.com/u/86760?v=3","gravatar_id":"","url":"https://api.github.com/users/wjt","html_url":"https://github.com/wjt","followers_url":"https://api.github.com/users/wjt/followers","following_url":"https://api.github.com/users/wjt/following{/other_user}","gists_url":"https://api.github.com/users/wjt/gists{/gist_id}","starred_url":"https://api.github.com/users/wjt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjt/subscriptions","organizations_url":"https://api.github.com/users/wjt/orgs","repos_url":"https://api.github.com/users/wjt/repos","events_url":"https://api.github.com/users/wjt/events{/privacy}","received_events_url":"https://api.github.com/users/wjt/received_events","type":"User","site_admin":false},"body":"If there happens to be a hole just before the end of the disk, `mount`\nand friends try to read it while probing the filesystem type. This\nfails, so the drive can't be mounted. (`mount -t ntfs-3g\n/dev/mapper/endless-image-device /mnt` works fine -- it is not ntfs-3g\nwhich is reading inside the holes.)\n\nThe 'zero' dm target returns zeros when read and discards all writes,\nlike /dev/zero.\n\nhttps://phabricator.endlessm.com/T15818","created_at":"2017-03-01T15:40:11Z","updated_at":"2017-03-01T15:42:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9dd12fa16442bdba53a6a2417b0179aa0e96fa20","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/98/commits","review_comments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/98/comments","review_comment_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/98/comments","statuses_url":"https://api.github.com/repos/endlessm/eos-boot-helper/statuses/54f1c8cdfdca4ccb43c27d988685d99514f852ce","head":{"label":"endlessm:T15818","ref":"T15818","sha":"54f1c8cdfdca4ccb43c27d988685d99514f852ce","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":17601935,"name":"eos-boot-helper","full_name":"endlessm/eos-boot-helper","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-boot-helper","description":"Endless OS services required for booting","fork":false,"url":"https://api.github.com/repos/endlessm/eos-boot-helper","forks_url":"https://api.github.com/repos/endlessm/eos-boot-helper/forks","keys_url":"https://api.github.com/repos/endlessm/eos-boot-helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-boot-helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-boot-helper/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-boot-helper/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-boot-helper/events","assignees_url":"https://api.github.com/repos/endlessm/eos-boot-helper/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-boot-helper/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-boot-helper/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-boot-helper/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-boot-helper/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-boot-helper/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-boot-helper/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-boot-helper/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-boot-helper/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-boot-helper/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-boot-helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-boot-helper/merges","archive_url":"https://api.github.com/repos/endlessm/eos-boot-helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-boot-helper/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-boot-helper/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-boot-helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-boot-helper/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-boot-helper/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/deployments","created_at":"2014-03-10T17:39:28Z","updated_at":"2016-11-02T20:32:37Z","pushed_at":"2017-03-01T15:40:12Z","git_url":"git://github.com/endlessm/eos-boot-helper.git","ssh_url":"[email protected]:endlessm/eos-boot-helper.git","clone_url":"https://github.com/endlessm/eos-boot-helper.git","svn_url":"https://github.com/endlessm/eos-boot-helper","homepage":"","size":171,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"d7dd154a7a59781d871ad5bd4c25e26adbf18e89","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":17601935,"name":"eos-boot-helper","full_name":"endlessm/eos-boot-helper","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-boot-helper","description":"Endless OS services required for booting","fork":false,"url":"https://api.github.com/repos/endlessm/eos-boot-helper","forks_url":"https://api.github.com/repos/endlessm/eos-boot-helper/forks","keys_url":"https://api.github.com/repos/endlessm/eos-boot-helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-boot-helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-boot-helper/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-boot-helper/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-boot-helper/events","assignees_url":"https://api.github.com/repos/endlessm/eos-boot-helper/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-boot-helper/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-boot-helper/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-boot-helper/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-boot-helper/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-boot-helper/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-boot-helper/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-boot-helper/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-boot-helper/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-boot-helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-boot-helper/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-boot-helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-boot-helper/merges","archive_url":"https://api.github.com/repos/endlessm/eos-boot-helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-boot-helper/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-boot-helper/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-boot-helper/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-boot-helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-boot-helper/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-boot-helper/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-boot-helper/deployments","created_at":"2014-03-10T17:39:28Z","updated_at":"2016-11-02T20:32:37Z","pushed_at":"2017-03-01T15:40:12Z","git_url":"git://github.com/endlessm/eos-boot-helper.git","ssh_url":"[email protected]:endlessm/eos-boot-helper.git","clone_url":"https://github.com/endlessm/eos-boot-helper.git","svn_url":"https://github.com/endlessm/eos-boot-helper","homepage":"","size":171,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/98"},"html":{"href":"https://github.com/endlessm/eos-boot-helper/pull/98"},"issue":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/98"},"comments":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/eos-boot-helper/statuses/54f1c8cdfdca4ccb43c27d988685d99514f852ce"}}}} | {
"id": 17601935,
"name": "endlessm/eos-boot-helper",
"url": "https://api.github.com/repos/endlessm/eos-boot-helper"
} | {
"id": 86760,
"login": "wjt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/86760?",
"url": "https://api.github.com/users/wjt"
} | {
"id": 1930958,
"login": "endlessm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1930958?",
"url": "https://api.github.com/orgs/endlessm"
} | 2017-03-01T15:42:14 | 5412951951 | {"actor":{"display_login":"wjt"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/comments/132198478","pull_request_review_id":55252940,"id":132198478,"diff_hunk":"@@ -288,6 +294,118 @@ gis_driver_get_mode (GisDriver *driver)\n }\n \n gboolean\n+gis_driver_is_in_demo_mode (GisDriver *driver)\n+{\n+ GisDriverPrivate *priv = gis_driver_get_instance_private (driver);\n+ return priv->is_in_demo_mode;\n+}\n+\n+#define DEMO_ACCOUNT_USERNAME \"demo-guest\"\n+#define DEMO_ACCOUNT_FULLNAME \"Demo\"\n+\n+static void\n+handle_demo_mode_error (GError *error)\n+{\n+ GtkWidget *dialog;\n+\n+ g_warning (\"%s\", error->message);\n+ dialog = gtk_message_dialog_new (NULL,\n+ GTK_DIALOG_DESTROY_WITH_PARENT,\n+ GTK_MESSAGE_ERROR,\n+ GTK_BUTTONS_CLOSE,\n+ \"Failed to enter demo mode: %s\",\n+ error->message);\n+ gtk_dialog_run (GTK_DIALOG (dialog));\n+ gtk_widget_destroy (dialog);\n+ g_error_free (error);\n+}\n+\n+G_DEFINE_AUTOPTR_CLEANUP_FUNC (ActUser, g_object_unref)\n+\n+static gboolean\n+create_demo_user (GisDriver *driver)\n+{\n+ GisDriverPrivate *priv = gis_driver_get_instance_private (driver);\n+ g_autoptr(ActUser) user;\n+ GError *error = NULL;\n+ const gchar *language;\n+\n+ error = NULL;\n+ user = act_user_manager_create_user (act_user_manager_get_default (),\n+ DEMO_ACCOUNT_USERNAME,\n+ DEMO_ACCOUNT_FULLNAME,\n+ ACT_USER_ACCOUNT_TYPE_ADMINISTRATOR,\n+ &error);\n+ if (error)\n+ {\n+ handle_demo_mode_error (error);\n+ return FALSE;\n+ }\n+\n+ act_user_set_password_mode (user, ACT_USER_PASSWORD_MODE_NONE);\n+ act_user_set_automatic_login (user, FALSE);\n+\n+ language = gis_driver_get_user_language (driver);\n+\n+ if (language)\n+ act_user_set_language (user, language);\n+\n+ gis_driver_set_user_permissions (driver, user, NULL);\n+ if (!gis_pkexec (LIBEXECDIR \"/eos-setup-demo-user\",\n+ \"user\",\n+ DEMO_ACCOUNT_USERNAME,\n+ &error))\n+ {\n+ handle_demo_mode_error (error);\n+ return FALSE;\n+ }\n+\n+ if (!gis_pkexec (LIBEXECDIR \"/eos-setup-demo-user-autologin\",\n+ NULL,\n+ NULL,\n+ &error))\n+ {\n+ handle_demo_mode_error (error);\n+ return FALSE;\n+ }\n+\n+ gis_update_login_keyring_password (\"\");\n+\n+ return TRUE;\n+}\n+\n+void\n+gis_driver_enter_demo_mode (GisDriver *driver)\n+{\n+ GisDriverPrivate *priv = gis_driver_get_instance_private (driver);\n+\n+ if (priv->is_in_demo_mode)\n+ return;\n+\n+ /* Enter test mode.\n+ *\n+ * After this point, all data on the system will become ephemeral,\n+ * including /home, which means any changes will be lost on reboot.\n+ */\n+ GError *error = NULL;\n+ if (!gis_pkexec (LIBEXECDIR \"/eos-test-mode\", NULL, NULL, &error)) {","path":"gnome-initial-setup/gis-driver.c","position":null,"original_position":118,"commit_id":"f8311165da762b59e0bf03f868d34dfad8e7bd29","original_commit_id":"9c8730e26048fec57121d1543333ff7b2c1c7984","user":{"login":"smspillaz","id":775309,"avatar_url":"https://avatars3.githubusercontent.com/u/775309?v=4","gravatar_id":"","url":"https://api.github.com/users/smspillaz","html_url":"https://github.com/smspillaz","followers_url":"https://api.github.com/users/smspillaz/followers","following_url":"https://api.github.com/users/smspillaz/following{/other_user}","gists_url":"https://api.github.com/users/smspillaz/gists{/gist_id}","starred_url":"https://api.github.com/users/smspillaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smspillaz/subscriptions","organizations_url":"https://api.github.com/users/smspillaz/orgs","repos_url":"https://api.github.com/users/smspillaz/repos","events_url":"https://api.github.com/users/smspillaz/events{/privacy}","received_events_url":"https://api.github.com/users/smspillaz/received_events","type":"User","site_admin":false},"body":"Ack, some trickery in moving back and forth between here and GDM I suspect ...","created_at":"2017-08-09T14:24:07Z","updated_at":"2017-08-09T14:24:07Z","html_url":"https://github.com/endlessm/gnome-initial-setup/pull/192#discussion_r132198478","pull_request_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/192","_links":{"self":{"href":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/comments/132198478"},"html":{"href":"https://github.com/endlessm/gnome-initial-setup/pull/192#discussion_r132198478"},"pull_request":{"href":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/192"}}},"pull_request":{"url":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/192","id":134610912,"html_url":"https://github.com/endlessm/gnome-initial-setup/pull/192","diff_url":"https://github.com/endlessm/gnome-initial-setup/pull/192.diff","patch_url":"https://github.com/endlessm/gnome-initial-setup/pull/192.patch","issue_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues/192","number":192,"state":"open","locked":false,"title":"T18383","user":{"login":"smspillaz","id":775309,"avatar_url":"https://avatars3.githubusercontent.com/u/775309?v=4","gravatar_id":"","url":"https://api.github.com/users/smspillaz","html_url":"https://github.com/smspillaz","followers_url":"https://api.github.com/users/smspillaz/followers","following_url":"https://api.github.com/users/smspillaz/following{/other_user}","gists_url":"https://api.github.com/users/smspillaz/gists{/gist_id}","starred_url":"https://api.github.com/users/smspillaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smspillaz/subscriptions","organizations_url":"https://api.github.com/users/smspillaz/orgs","repos_url":"https://api.github.com/users/smspillaz/repos","events_url":"https://api.github.com/users/smspillaz/events{/privacy}","received_events_url":"https://api.github.com/users/smspillaz/received_events","type":"User","site_admin":false},"body":"Add prompts and hooks in gnome-initial-setup to enter a \"demo mode\"\r\n\r\nhttps://phabricator.endlessm.com/T18383","created_at":"2017-08-08T09:08:50Z","updated_at":"2017-08-09T14:24:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15ac7e087cae07d91642072cbc21e85085c310c7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/192/commits","review_comments_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/192/comments","review_comment_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues/192/comments","statuses_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/statuses/f8311165da762b59e0bf03f868d34dfad8e7bd29","head":{"label":"endlessm:T18383","ref":"T18383","sha":"f8311165da762b59e0bf03f868d34dfad8e7bd29","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":17677386,"name":"gnome-initial-setup","full_name":"endlessm/gnome-initial-setup","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/gnome-initial-setup","description":"Fork of gnome-initial-setup with endless customizations and translations","fork":false,"url":"https://api.github.com/repos/endlessm/gnome-initial-setup","forks_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/forks","keys_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/teams","hooks_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/hooks","issue_events_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/events","assignees_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/tags","blobs_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/languages","stargazers_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/stargazers","contributors_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/contributors","subscribers_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/subscribers","subscription_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/subscription","commits_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/merges","archive_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/downloads","issues_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/deployments","created_at":"2014-03-12T18:10:28Z","updated_at":"2017-05-24T05:25:01Z","pushed_at":"2017-08-09T14:23:38Z","git_url":"git://github.com/endlessm/gnome-initial-setup.git","ssh_url":"[email protected]:endlessm/gnome-initial-setup.git","clone_url":"https://github.com/endlessm/gnome-initial-setup.git","svn_url":"https://github.com/endlessm/gnome-initial-setup","homepage":null,"size":8326,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"e4ac6eefee78f597d0dabceb40f237e8e6cd2e36","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":17677386,"name":"gnome-initial-setup","full_name":"endlessm/gnome-initial-setup","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/gnome-initial-setup","description":"Fork of gnome-initial-setup with endless customizations and translations","fork":false,"url":"https://api.github.com/repos/endlessm/gnome-initial-setup","forks_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/forks","keys_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/teams","hooks_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/hooks","issue_events_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/events","assignees_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/tags","blobs_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/languages","stargazers_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/stargazers","contributors_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/contributors","subscribers_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/subscribers","subscription_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/subscription","commits_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/merges","archive_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/downloads","issues_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/gnome-initial-setup/deployments","created_at":"2014-03-12T18:10:28Z","updated_at":"2017-05-24T05:25:01Z","pushed_at":"2017-08-09T14:23:38Z","git_url":"git://github.com/endlessm/gnome-initial-setup.git","ssh_url":"[email protected]:endlessm/gnome-initial-setup.git","clone_url":"https://github.com/endlessm/gnome-initial-setup.git","svn_url":"https://github.com/endlessm/gnome-initial-setup","homepage":null,"size":8326,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/192"},"html":{"href":"https://github.com/endlessm/gnome-initial-setup/pull/192"},"issue":{"href":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues/192"},"comments":{"href":"https://api.github.com/repos/endlessm/gnome-initial-setup/issues/192/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/192/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/gnome-initial-setup/pulls/192/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/gnome-initial-setup/statuses/f8311165da762b59e0bf03f868d34dfad8e7bd29"}}}} | {
"id": 17677386,
"name": "endlessm/gnome-initial-setup",
"url": "https://api.github.com/repos/endlessm/gnome-initial-setup"
} | {
"id": 775309,
"login": "smspillaz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/775309?",
"url": "https://api.github.com/users/smspillaz"
} | {
"id": 1930958,
"login": "endlessm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1930958?",
"url": "https://api.github.com/orgs/endlessm"
} | 2017-08-09T14:24:07 | 6424879727 | {"actor":{"display_login":"smspillaz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/comments/96464193","pull_request_review_id":17046695,"id":96464193,"diff_hunk":"@@ -1465,6 +1534,11 @@ bool StructType::isImplicitlyConvertibleTo(const Type& _convertTo) const\n \treturn this->m_struct == convertTo.m_struct;\n }\n \n+string StructType::identifier() const\n+{\n+\treturn \"t_struct_\" + m_struct.name() + \"_\" + std::to_string(m_struct.id()) + identifierLocationSuffix();","path":"libsolidity/ast/Types.cpp","position":144,"original_position":144,"commit_id":"3e7dc50167a9346b31006ff2e045e32fffd3e84a","original_commit_id":"3e7dc50167a9346b31006ff2e045e32fffd3e84a","user":{"login":"chriseth","id":9073706,"avatar_url":"https://avatars.githubusercontent.com/u/9073706?v=3","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"body":"certainly.","created_at":"2017-01-17T17:27:31Z","updated_at":"2017-01-17T17:27:31Z","html_url":"https://github.com/ethereum/solidity/pull/1576#discussion_r96464193","pull_request_url":"https://api.github.com/repos/ethereum/solidity/pulls/1576","_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments/96464193"},"html":{"href":"https://github.com/ethereum/solidity/pull/1576#discussion_r96464193"},"pull_request":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/1576"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/1576","id":101860326,"html_url":"https://github.com/ethereum/solidity/pull/1576","diff_url":"https://github.com/ethereum/solidity/pull/1576.diff","patch_url":"https://github.com/ethereum/solidity/pull/1576.patch","issue_url":"https://api.github.com/repos/ethereum/solidity/issues/1576","number":1576,"state":"open","locked":false,"title":"Type identifiers.","user":{"login":"chriseth","id":9073706,"avatar_url":"https://avatars.githubusercontent.com/u/9073706?v=3","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"body":"The purpose of this PR is to generate unique names for all types that compare different to each other, so that these names can later be used for assembly function names.\r\n\r\nThis probably has to be improved, currently it is possible to game the system by using specially crafted names for structs and contracts. Furthermore, I'm not 100% sure that this system actually provide unique identifiers, especially since most types are composed by prefixing, but arrays are composed by suffixing.\r\n\r\nMy proposal would be to escape or specially mark user-supplied names (e.g. `$UserSuppliedName$`, where `$`-symbols in `UserSuppliedName` are replaced by some escape sequence), but I don't have a good proposal how to reflect the associative structure of e.g. tuple types.","created_at":"2017-01-17T13:10:22Z","updated_at":"2017-01-17T17:27:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"952dd37ca7c2d88775c81dd91ce9be710169198e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/solidity/pulls/1576/commits","review_comments_url":"https://api.github.com/repos/ethereum/solidity/pulls/1576/comments","review_comment_url":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/1576/comments","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/3e7dc50167a9346b31006ff2e045e32fffd3e84a","head":{"label":"ethereum:typeIdentifiers","ref":"typeIdentifiers","sha":"3e7dc50167a9346b31006ff2e045e32fffd3e84a","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"name":"solidity","full_name":"ethereum/solidity","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/solidity","description":"The Solidity Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2017-01-15T10:44:59Z","pushed_at":"2017-01-17T17:27:25Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"[email protected]:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"","size":10598,"stargazers_count":528,"watchers_count":528,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":235,"mirror_url":null,"open_issues_count":248,"forks":235,"open_issues":248,"watchers":528,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"a466f26c459c8df27b0b25e53b897461fdc8fd63","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"name":"solidity","full_name":"ethereum/solidity","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/solidity","description":"The Solidity Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2017-01-15T10:44:59Z","pushed_at":"2017-01-17T17:27:25Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"[email protected]:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"","size":10598,"stargazers_count":528,"watchers_count":528,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":235,"mirror_url":null,"open_issues_count":248,"forks":235,"open_issues":248,"watchers":528,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/1576"},"html":{"href":"https://github.com/ethereum/solidity/pull/1576"},"issue":{"href":"https://api.github.com/repos/ethereum/solidity/issues/1576"},"comments":{"href":"https://api.github.com/repos/ethereum/solidity/issues/1576/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/1576/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/1576/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/solidity/statuses/3e7dc50167a9346b31006ff2e045e32fffd3e84a"}}}} | {
"id": 40892817,
"name": "ethereum/solidity",
"url": "https://api.github.com/repos/ethereum/solidity"
} | {
"id": 9073706,
"login": "chriseth",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9073706?",
"url": "https://api.github.com/users/chriseth"
} | {
"id": 6250754,
"login": "ethereum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6250754?",
"url": "https://api.github.com/orgs/ethereum"
} | 2017-01-17T17:27:31 | 5166946658 | {"actor":{"display_login":"chriseth"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments/120591572","pull_request_review_id":42565434,"id":120591572,"diff_hunk":"@@ -130,6 +130,34 @@ func PaddedBigBytes(bigint *big.Int, n int) []byte {\n \treturn ret\n }\n \n+// bigEndianByteAt returns the byte at position n,\n+// if bigint is considered big-endian.\n+// So n==0 returns the least significant byte\n+func bigEndianByteAt(bigint *big.Int, n int) byte {\n+\twords := bigint.Bits()\n+\t// Check word-bucket the byte will reside in\n+\ti := n / wordBytes\n+\tif i >= len(words) {\n+\t\treturn byte(0)\n+\t}\n+\tword := words[i]\n+\t// Offset of the byte\n+\tshift := 8 * uint(n%wordBytes)\n+\n+\treturn byte(word >> shift)\n+}\n+\n+// Byte returns the byte at position n,\n+// if bigint is considered little-endian with the supplied padlength.\n+// n==0 returns the most significant byte\n+// bigint '5', padlength 32, n=31 => 5\n+func Byte(bigint *big.Int, padlength, n int) byte {\n+\tif n >= padlength {\n+\t\treturn byte(0)\n+\t}\n+\treturn bigEndianByteAt(bigint, padlength-1-n)\n+}","path":"common/math/big.go","position":30,"original_position":30,"commit_id":"1496b3aff6a537a1c5597ec55b8d3b25afded26c","original_commit_id":"1496b3aff6a537a1c5597ec55b8d3b25afded26c","user":{"login":"fjl","id":6915,"avatar_url":"https://avatars3.githubusercontent.com/u/6915?v=3","gravatar_id":"","url":"https://api.github.com/users/fjl","html_url":"https://github.com/fjl","followers_url":"https://api.github.com/users/fjl/followers","following_url":"https://api.github.com/users/fjl/following{/other_user}","gists_url":"https://api.github.com/users/fjl/gists{/gist_id}","starred_url":"https://api.github.com/users/fjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjl/subscriptions","organizations_url":"https://api.github.com/users/fjl/orgs","repos_url":"https://api.github.com/users/fjl/repos","events_url":"https://api.github.com/users/fjl/events{/privacy}","received_events_url":"https://api.github.com/users/fjl/received_events","type":"User","site_admin":false},"body":"Oops, sorry, got confused myself. The comment is fine. ","created_at":"2017-06-07T10:42:38Z","updated_at":"2017-06-07T10:42:38Z","html_url":"https://github.com/ethereum/go-ethereum/pull/14581#discussion_r120591572","pull_request_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/14581","_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments/120591572"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/14581#discussion_r120591572"},"pull_request":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/14581"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/14581","id":123923038,"html_url":"https://github.com/ethereum/go-ethereum/pull/14581","diff_url":"https://github.com/ethereum/go-ethereum/pull/14581.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/14581.patch","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/14581","number":14581,"state":"open","locked":false,"title":"Improve opByte","user":{"login":"holiman","id":142290,"avatar_url":"https://avatars2.githubusercontent.com/u/142290?v=3","gravatar_id":"","url":"https://api.github.com/users/holiman","html_url":"https://github.com/holiman","followers_url":"https://api.github.com/users/holiman/followers","following_url":"https://api.github.com/users/holiman/following{/other_user}","gists_url":"https://api.github.com/users/holiman/gists{/gist_id}","starred_url":"https://api.github.com/users/holiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holiman/subscriptions","organizations_url":"https://api.github.com/users/holiman/orgs","repos_url":"https://api.github.com/users/holiman/repos","events_url":"https://api.github.com/users/holiman/events{/privacy}","received_events_url":"https://api.github.com/users/holiman/received_events","type":"User","site_admin":false},"body":"This PR makes the `BYTE` operation much faster, since \r\n* it does not need to allocate a full bytearray (which is then discarded)\r\n* it does not go through the entire `bigint`, but insted reaches directly into the desired byte. \r\n\r\n","created_at":"2017-06-05T06:51:24Z","updated_at":"2017-06-07T10:42:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb376b419bcab8458a179929f9cfb2a26b72edfa","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/14581/commits","review_comments_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/14581/comments","review_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/14581/comments","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/1496b3aff6a537a1c5597ec55b8d3b25afded26c","head":{"label":"holiman:byte_opt","ref":"byte_opt","sha":"1496b3aff6a537a1c5597ec55b8d3b25afded26c","user":{"login":"holiman","id":142290,"avatar_url":"https://avatars2.githubusercontent.com/u/142290?v=3","gravatar_id":"","url":"https://api.github.com/users/holiman","html_url":"https://github.com/holiman","followers_url":"https://api.github.com/users/holiman/followers","following_url":"https://api.github.com/users/holiman/following{/other_user}","gists_url":"https://api.github.com/users/holiman/gists{/gist_id}","starred_url":"https://api.github.com/users/holiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holiman/subscriptions","organizations_url":"https://api.github.com/users/holiman/orgs","repos_url":"https://api.github.com/users/holiman/repos","events_url":"https://api.github.com/users/holiman/events{/privacy}","received_events_url":"https://api.github.com/users/holiman/received_events","type":"User","site_admin":false},"repo":{"id":75061513,"name":"go-ethereum","full_name":"holiman/go-ethereum","owner":{"login":"holiman","id":142290,"avatar_url":"https://avatars2.githubusercontent.com/u/142290?v=3","gravatar_id":"","url":"https://api.github.com/users/holiman","html_url":"https://github.com/holiman","followers_url":"https://api.github.com/users/holiman/followers","following_url":"https://api.github.com/users/holiman/following{/other_user}","gists_url":"https://api.github.com/users/holiman/gists{/gist_id}","starred_url":"https://api.github.com/users/holiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holiman/subscriptions","organizations_url":"https://api.github.com/users/holiman/orgs","repos_url":"https://api.github.com/users/holiman/repos","events_url":"https://api.github.com/users/holiman/events{/privacy}","received_events_url":"https://api.github.com/users/holiman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/holiman/go-ethereum","description":"Official Go implementation of the Ethereum protocol","fork":true,"url":"https://api.github.com/repos/holiman/go-ethereum","forks_url":"https://api.github.com/repos/holiman/go-ethereum/forks","keys_url":"https://api.github.com/repos/holiman/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holiman/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holiman/go-ethereum/teams","hooks_url":"https://api.github.com/repos/holiman/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/holiman/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/holiman/go-ethereum/events","assignees_url":"https://api.github.com/repos/holiman/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/holiman/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/holiman/go-ethereum/tags","blobs_url":"https://api.github.com/repos/holiman/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holiman/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holiman/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/holiman/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holiman/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/holiman/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/holiman/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/holiman/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/holiman/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/holiman/go-ethereum/subscription","commits_url":"https://api.github.com/repos/holiman/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/holiman/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/holiman/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/holiman/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/holiman/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/holiman/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holiman/go-ethereum/merges","archive_url":"https://api.github.com/repos/holiman/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holiman/go-ethereum/downloads","issues_url":"https://api.github.com/repos/holiman/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/holiman/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/holiman/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/holiman/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holiman/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/holiman/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/holiman/go-ethereum/deployments","created_at":"2016-11-29T08:48:37Z","updated_at":"2016-11-29T08:48:45Z","pushed_at":"2017-06-07T09:14:34Z","git_url":"git://github.com/holiman/go-ethereum.git","ssh_url":"[email protected]:holiman/go-ethereum.git","clone_url":"https://github.com/holiman/go-ethereum.git","svn_url":"https://github.com/holiman/go-ethereum","homepage":"https://geth.ethereum.org","size":86371,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"6171d01b1195abd7ac75044dcd507d4758d83cde","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars0.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15452919,"name":"go-ethereum","full_name":"ethereum/go-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars0.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/go-ethereum","description":"Official Go implementation of the Ethereum protocol","fork":false,"url":"https://api.github.com/repos/ethereum/go-ethereum","forks_url":"https://api.github.com/repos/ethereum/go-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/go-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/go-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/go-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/go-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/go-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/go-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/go-ethereum/deployments","created_at":"2013-12-26T13:05:46Z","updated_at":"2017-06-07T09:17:21Z","pushed_at":"2017-06-07T10:06:26Z","git_url":"git://github.com/ethereum/go-ethereum.git","ssh_url":"[email protected]:ethereum/go-ethereum.git","clone_url":"https://github.com/ethereum/go-ethereum.git","svn_url":"https://github.com/ethereum/go-ethereum","homepage":"https://geth.ethereum.org","size":86356,"stargazers_count":4594,"watchers_count":4594,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1498,"mirror_url":null,"open_issues_count":372,"forks":1498,"open_issues":372,"watchers":4594,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/14581"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/14581"},"issue":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/14581"},"comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/14581/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/14581/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/14581/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/go-ethereum/statuses/1496b3aff6a537a1c5597ec55b8d3b25afded26c"}}}} | {
"id": 15452919,
"name": "ethereum/go-ethereum",
"url": "https://api.github.com/repos/ethereum/go-ethereum"
} | {
"id": 6915,
"login": "fjl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6915?",
"url": "https://api.github.com/users/fjl"
} | {
"id": 6250754,
"login": "ethereum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6250754?",
"url": "https://api.github.com/orgs/ethereum"
} | 2017-06-07T10:42:38 | 6017850585 | {"actor":{"display_login":"fjl"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/remix/pulls/comments/96680404","pull_request_review_id":17268886,"id":96680404,"diff_hunk":"@@ -50,8 +50,8 @@ class TreeView {\n return yo`<ul style=${this.cssList}>${children}</ul>`\n }\n \n- formatDataDefault (key, self, children, expand) {\n- var label = yo`<span style=${this.cssLabel}><label style='width: 10px'></label><label>${key}: ${self}</label></span>`\n+ formatDataInternal (key, data, children, expand) {","path":"src/ui/TreeView.js","position":15,"original_position":15,"commit_id":"7f30c45859f0b5483b66c6d27e309f39bfca0426","original_commit_id":"7f30c45859f0b5483b66c6d27e309f39bfca0426","user":{"login":"chriseth","id":9073706,"avatar_url":"https://avatars.githubusercontent.com/u/9073706?v=3","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"body":"Hm, I would swap the naming here, `formatData` is kind of more internal than `formatDataInternal` ;-)\r\nWhat about: `formatData` for the general thing and `formatSelf` for what is called `formatData` in your PR?","created_at":"2017-01-18T16:50:51Z","updated_at":"2017-01-18T16:51:46Z","html_url":"https://github.com/ethereum/remix/pull/179#discussion_r96680404","pull_request_url":"https://api.github.com/repos/ethereum/remix/pulls/179","_links":{"self":{"href":"https://api.github.com/repos/ethereum/remix/pulls/comments/96680404"},"html":{"href":"https://github.com/ethereum/remix/pull/179#discussion_r96680404"},"pull_request":{"href":"https://api.github.com/repos/ethereum/remix/pulls/179"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/remix/pulls/179","id":102102791,"html_url":"https://github.com/ethereum/remix/pull/179","diff_url":"https://github.com/ethereum/remix/pull/179.diff","patch_url":"https://github.com/ethereum/remix/pull/179.patch","issue_url":"https://api.github.com/repos/ethereum/remix/issues/179","number":179,"state":"open","locked":false,"title":"Treeview - Add solidity type","user":{"login":"yann300","id":6940742,"avatar_url":"https://avatars.githubusercontent.com/u/6940742?v=3","gravatar_id":"","url":"https://api.github.com/users/yann300","html_url":"https://github.com/yann300","followers_url":"https://api.github.com/users/yann300/followers","following_url":"https://api.github.com/users/yann300/following{/other_user}","gists_url":"https://api.github.com/users/yann300/gists{/gist_id}","starred_url":"https://api.github.com/users/yann300/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yann300/subscriptions","organizations_url":"https://api.github.com/users/yann300/orgs","repos_url":"https://api.github.com/users/yann300/repos","events_url":"https://api.github.com/users/yann300/events{/privacy}","received_events_url":"https://api.github.com/users/yann300/received_events","type":"User","site_admin":false},"body":"address\r\nhttps://github.com/ethereum/remix/issues/173\r\nhttps://github.com/ethereum/remix/issues/172","created_at":"2017-01-18T16:40:25Z","updated_at":"2017-01-18T16:51:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e0fd6eb5f00f3705362c86e847b7d34f7d98556","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/remix/pulls/179/commits","review_comments_url":"https://api.github.com/repos/ethereum/remix/pulls/179/comments","review_comment_url":"https://api.github.com/repos/ethereum/remix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/remix/issues/179/comments","statuses_url":"https://api.github.com/repos/ethereum/remix/statuses/7f30c45859f0b5483b66c6d27e309f39bfca0426","head":{"label":"ethereum:treeView","ref":"treeView","sha":"7f30c45859f0b5483b66c6d27e309f39bfca0426","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":55957418,"name":"remix","full_name":"ethereum/remix","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/remix","description":"Ethereum IDE and tools for the web","fork":false,"url":"https://api.github.com/repos/ethereum/remix","forks_url":"https://api.github.com/repos/ethereum/remix/forks","keys_url":"https://api.github.com/repos/ethereum/remix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/remix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/remix/teams","hooks_url":"https://api.github.com/repos/ethereum/remix/hooks","issue_events_url":"https://api.github.com/repos/ethereum/remix/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/remix/events","assignees_url":"https://api.github.com/repos/ethereum/remix/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/remix/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/remix/tags","blobs_url":"https://api.github.com/repos/ethereum/remix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/remix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/remix/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/remix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/remix/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/remix/languages","stargazers_url":"https://api.github.com/repos/ethereum/remix/stargazers","contributors_url":"https://api.github.com/repos/ethereum/remix/contributors","subscribers_url":"https://api.github.com/repos/ethereum/remix/subscribers","subscription_url":"https://api.github.com/repos/ethereum/remix/subscription","commits_url":"https://api.github.com/repos/ethereum/remix/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/remix/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/remix/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/remix/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/remix/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/remix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/remix/merges","archive_url":"https://api.github.com/repos/ethereum/remix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/remix/downloads","issues_url":"https://api.github.com/repos/ethereum/remix/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/remix/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/remix/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/remix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/remix/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/remix/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/remix/deployments","created_at":"2016-04-11T09:05:03Z","updated_at":"2017-01-15T18:35:15Z","pushed_at":"2017-01-18T16:40:26Z","git_url":"git://github.com/ethereum/remix.git","ssh_url":"[email protected]:ethereum/remix.git","clone_url":"https://github.com/ethereum/remix.git","svn_url":"https://github.com/ethereum/remix","homepage":null,"size":1306,"stargazers_count":75,"watchers_count":75,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":28,"mirror_url":null,"open_issues_count":24,"forks":28,"open_issues":24,"watchers":75,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"0de7453651d04e22321306b8fa0b1e28b4bf8f87","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":55957418,"name":"remix","full_name":"ethereum/remix","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/remix","description":"Ethereum IDE and tools for the web","fork":false,"url":"https://api.github.com/repos/ethereum/remix","forks_url":"https://api.github.com/repos/ethereum/remix/forks","keys_url":"https://api.github.com/repos/ethereum/remix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/remix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/remix/teams","hooks_url":"https://api.github.com/repos/ethereum/remix/hooks","issue_events_url":"https://api.github.com/repos/ethereum/remix/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/remix/events","assignees_url":"https://api.github.com/repos/ethereum/remix/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/remix/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/remix/tags","blobs_url":"https://api.github.com/repos/ethereum/remix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/remix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/remix/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/remix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/remix/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/remix/languages","stargazers_url":"https://api.github.com/repos/ethereum/remix/stargazers","contributors_url":"https://api.github.com/repos/ethereum/remix/contributors","subscribers_url":"https://api.github.com/repos/ethereum/remix/subscribers","subscription_url":"https://api.github.com/repos/ethereum/remix/subscription","commits_url":"https://api.github.com/repos/ethereum/remix/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/remix/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/remix/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/remix/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/remix/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/remix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/remix/merges","archive_url":"https://api.github.com/repos/ethereum/remix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/remix/downloads","issues_url":"https://api.github.com/repos/ethereum/remix/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/remix/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/remix/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/remix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/remix/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/remix/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/remix/deployments","created_at":"2016-04-11T09:05:03Z","updated_at":"2017-01-15T18:35:15Z","pushed_at":"2017-01-18T16:40:26Z","git_url":"git://github.com/ethereum/remix.git","ssh_url":"[email protected]:ethereum/remix.git","clone_url":"https://github.com/ethereum/remix.git","svn_url":"https://github.com/ethereum/remix","homepage":null,"size":1306,"stargazers_count":75,"watchers_count":75,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":28,"mirror_url":null,"open_issues_count":24,"forks":28,"open_issues":24,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/remix/pulls/179"},"html":{"href":"https://github.com/ethereum/remix/pull/179"},"issue":{"href":"https://api.github.com/repos/ethereum/remix/issues/179"},"comments":{"href":"https://api.github.com/repos/ethereum/remix/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/remix/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/remix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/remix/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/remix/statuses/7f30c45859f0b5483b66c6d27e309f39bfca0426"}}}} | {
"id": 55957418,
"name": "ethereum/remix",
"url": "https://api.github.com/repos/ethereum/remix"
} | {
"id": 9073706,
"login": "chriseth",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9073706?",
"url": "https://api.github.com/users/chriseth"
} | {
"id": 6250754,
"login": "ethereum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6250754?",
"url": "https://api.github.com/orgs/ethereum"
} | 2017-01-18T16:50:51 | 5173769393 | {"actor":{"display_login":"chriseth"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/euranova/code_retreat/pulls/comments/137731897","pull_request_review_id":61437207,"id":137731897,"diff_hunk":"@@ -1,3 +1,3 @@\n #!/bin/bash\n \n-docker run -it --rm -v $PWD:/app -w /app/src/CodeRetreat microsoft/dotnet:1.1-sdk-projectjson bash\n+docker run -it --rm -v ${PWD}:/app -w /app/CodeRetreat.Tests microsoft/dotnet:2.0.0-sdk bash","path":"scaffolds/csharp/docker.sh","position":null,"original_position":4,"commit_id":"741aa077b57727df1e493737e4500364c9b07a58","original_commit_id":"36072936e11cf29339923e7abd773338463979c8","user":{"login":"poulinjulien","id":1919739,"avatar_url":"https://avatars0.githubusercontent.com/u/1919739?v=4","gravatar_id":"","url":"https://api.github.com/users/poulinjulien","html_url":"https://github.com/poulinjulien","followers_url":"https://api.github.com/users/poulinjulien/followers","following_url":"https://api.github.com/users/poulinjulien/following{/other_user}","gists_url":"https://api.github.com/users/poulinjulien/gists{/gist_id}","starred_url":"https://api.github.com/users/poulinjulien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poulinjulien/subscriptions","organizations_url":"https://api.github.com/users/poulinjulien/orgs","repos_url":"https://api.github.com/users/poulinjulien/repos","events_url":"https://api.github.com/users/poulinjulien/events{/privacy}","received_events_url":"https://api.github.com/users/poulinjulien/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2017-09-08T08:08:16Z","updated_at":"2017-09-08T08:08:17Z","html_url":"https://github.com/euranova/code_retreat/pull/13#discussion_r137731897","pull_request_url":"https://api.github.com/repos/euranova/code_retreat/pulls/13","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/euranova/code_retreat/pulls/comments/137731897"},"html":{"href":"https://github.com/euranova/code_retreat/pull/13#discussion_r137731897"},"pull_request":{"href":"https://api.github.com/repos/euranova/code_retreat/pulls/13"}},"in_reply_to_id":137502826},"pull_request":{"url":"https://api.github.com/repos/euranova/code_retreat/pulls/13","id":139308523,"html_url":"https://github.com/euranova/code_retreat/pull/13","diff_url":"https://github.com/euranova/code_retreat/pull/13.diff","patch_url":"https://github.com/euranova/code_retreat/pull/13.patch","issue_url":"https://api.github.com/repos/euranova/code_retreat/issues/13","number":13,"state":"open","locked":false,"title":"Update C# scaffold to use .NET Core 2.0","user":{"login":"poulinjulien","id":1919739,"avatar_url":"https://avatars0.githubusercontent.com/u/1919739?v=4","gravatar_id":"","url":"https://api.github.com/users/poulinjulien","html_url":"https://github.com/poulinjulien","followers_url":"https://api.github.com/users/poulinjulien/followers","following_url":"https://api.github.com/users/poulinjulien/following{/other_user}","gists_url":"https://api.github.com/users/poulinjulien/gists{/gist_id}","starred_url":"https://api.github.com/users/poulinjulien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poulinjulien/subscriptions","organizations_url":"https://api.github.com/users/poulinjulien/orgs","repos_url":"https://api.github.com/users/poulinjulien/repos","events_url":"https://api.github.com/users/poulinjulien/events{/privacy}","received_events_url":"https://api.github.com/users/poulinjulien/received_events","type":"User","site_admin":false},"body":"I've updated the C# scaffold project and the Docker image to use the new .NET Core 2.0.","created_at":"2017-09-05T12:15:42Z","updated_at":"2017-09-08T08:08:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d15ecb714a686e0aa365346164021b749e0dd4e9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/euranova/code_retreat/pulls/13/commits","review_comments_url":"https://api.github.com/repos/euranova/code_retreat/pulls/13/comments","review_comment_url":"https://api.github.com/repos/euranova/code_retreat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/euranova/code_retreat/issues/13/comments","statuses_url":"https://api.github.com/repos/euranova/code_retreat/statuses/741aa077b57727df1e493737e4500364c9b07a58","head":{"label":"poulinjulien:csharp-net-core-2","ref":"csharp-net-core-2","sha":"741aa077b57727df1e493737e4500364c9b07a58","user":{"login":"poulinjulien","id":1919739,"avatar_url":"https://avatars0.githubusercontent.com/u/1919739?v=4","gravatar_id":"","url":"https://api.github.com/users/poulinjulien","html_url":"https://github.com/poulinjulien","followers_url":"https://api.github.com/users/poulinjulien/followers","following_url":"https://api.github.com/users/poulinjulien/following{/other_user}","gists_url":"https://api.github.com/users/poulinjulien/gists{/gist_id}","starred_url":"https://api.github.com/users/poulinjulien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poulinjulien/subscriptions","organizations_url":"https://api.github.com/users/poulinjulien/orgs","repos_url":"https://api.github.com/users/poulinjulien/repos","events_url":"https://api.github.com/users/poulinjulien/events{/privacy}","received_events_url":"https://api.github.com/users/poulinjulien/received_events","type":"User","site_admin":false},"repo":{"id":61749067,"name":"code_retreat","full_name":"poulinjulien/code_retreat","owner":{"login":"poulinjulien","id":1919739,"avatar_url":"https://avatars0.githubusercontent.com/u/1919739?v=4","gravatar_id":"","url":"https://api.github.com/users/poulinjulien","html_url":"https://github.com/poulinjulien","followers_url":"https://api.github.com/users/poulinjulien/followers","following_url":"https://api.github.com/users/poulinjulien/following{/other_user}","gists_url":"https://api.github.com/users/poulinjulien/gists{/gist_id}","starred_url":"https://api.github.com/users/poulinjulien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poulinjulien/subscriptions","organizations_url":"https://api.github.com/users/poulinjulien/orgs","repos_url":"https://api.github.com/users/poulinjulien/repos","events_url":"https://api.github.com/users/poulinjulien/events{/privacy}","received_events_url":"https://api.github.com/users/poulinjulien/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/poulinjulien/code_retreat","description":"Materials for ENX code retreat","fork":true,"url":"https://api.github.com/repos/poulinjulien/code_retreat","forks_url":"https://api.github.com/repos/poulinjulien/code_retreat/forks","keys_url":"https://api.github.com/repos/poulinjulien/code_retreat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poulinjulien/code_retreat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poulinjulien/code_retreat/teams","hooks_url":"https://api.github.com/repos/poulinjulien/code_retreat/hooks","issue_events_url":"https://api.github.com/repos/poulinjulien/code_retreat/issues/events{/number}","events_url":"https://api.github.com/repos/poulinjulien/code_retreat/events","assignees_url":"https://api.github.com/repos/poulinjulien/code_retreat/assignees{/user}","branches_url":"https://api.github.com/repos/poulinjulien/code_retreat/branches{/branch}","tags_url":"https://api.github.com/repos/poulinjulien/code_retreat/tags","blobs_url":"https://api.github.com/repos/poulinjulien/code_retreat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poulinjulien/code_retreat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poulinjulien/code_retreat/git/refs{/sha}","trees_url":"https://api.github.com/repos/poulinjulien/code_retreat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poulinjulien/code_retreat/statuses/{sha}","languages_url":"https://api.github.com/repos/poulinjulien/code_retreat/languages","stargazers_url":"https://api.github.com/repos/poulinjulien/code_retreat/stargazers","contributors_url":"https://api.github.com/repos/poulinjulien/code_retreat/contributors","subscribers_url":"https://api.github.com/repos/poulinjulien/code_retreat/subscribers","subscription_url":"https://api.github.com/repos/poulinjulien/code_retreat/subscription","commits_url":"https://api.github.com/repos/poulinjulien/code_retreat/commits{/sha}","git_commits_url":"https://api.github.com/repos/poulinjulien/code_retreat/git/commits{/sha}","comments_url":"https://api.github.com/repos/poulinjulien/code_retreat/comments{/number}","issue_comment_url":"https://api.github.com/repos/poulinjulien/code_retreat/issues/comments{/number}","contents_url":"https://api.github.com/repos/poulinjulien/code_retreat/contents/{+path}","compare_url":"https://api.github.com/repos/poulinjulien/code_retreat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poulinjulien/code_retreat/merges","archive_url":"https://api.github.com/repos/poulinjulien/code_retreat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poulinjulien/code_retreat/downloads","issues_url":"https://api.github.com/repos/poulinjulien/code_retreat/issues{/number}","pulls_url":"https://api.github.com/repos/poulinjulien/code_retreat/pulls{/number}","milestones_url":"https://api.github.com/repos/poulinjulien/code_retreat/milestones{/number}","notifications_url":"https://api.github.com/repos/poulinjulien/code_retreat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poulinjulien/code_retreat/labels{/name}","releases_url":"https://api.github.com/repos/poulinjulien/code_retreat/releases{/id}","deployments_url":"https://api.github.com/repos/poulinjulien/code_retreat/deployments","created_at":"2016-06-22T20:23:42Z","updated_at":"2016-06-22T20:23:43Z","pushed_at":"2017-09-08T08:06:52Z","git_url":"git://github.com/poulinjulien/code_retreat.git","ssh_url":"[email protected]:poulinjulien/code_retreat.git","clone_url":"https://github.com/poulinjulien/code_retreat.git","svn_url":"https://github.com/poulinjulien/code_retreat","homepage":null,"size":40,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"euranova:master","ref":"master","sha":"37bfeccdb064c7e0d475e83761b339db1fc88db5","user":{"login":"euranova","id":2103558,"avatar_url":"https://avatars2.githubusercontent.com/u/2103558?v=4","gravatar_id":"","url":"https://api.github.com/users/euranova","html_url":"https://github.com/euranova","followers_url":"https://api.github.com/users/euranova/followers","following_url":"https://api.github.com/users/euranova/following{/other_user}","gists_url":"https://api.github.com/users/euranova/gists{/gist_id}","starred_url":"https://api.github.com/users/euranova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euranova/subscriptions","organizations_url":"https://api.github.com/users/euranova/orgs","repos_url":"https://api.github.com/users/euranova/repos","events_url":"https://api.github.com/users/euranova/events{/privacy}","received_events_url":"https://api.github.com/users/euranova/received_events","type":"Organization","site_admin":false},"repo":{"id":60595880,"name":"code_retreat","full_name":"euranova/code_retreat","owner":{"login":"euranova","id":2103558,"avatar_url":"https://avatars2.githubusercontent.com/u/2103558?v=4","gravatar_id":"","url":"https://api.github.com/users/euranova","html_url":"https://github.com/euranova","followers_url":"https://api.github.com/users/euranova/followers","following_url":"https://api.github.com/users/euranova/following{/other_user}","gists_url":"https://api.github.com/users/euranova/gists{/gist_id}","starred_url":"https://api.github.com/users/euranova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euranova/subscriptions","organizations_url":"https://api.github.com/users/euranova/orgs","repos_url":"https://api.github.com/users/euranova/repos","events_url":"https://api.github.com/users/euranova/events{/privacy}","received_events_url":"https://api.github.com/users/euranova/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/euranova/code_retreat","description":"Materials for ENX code retreat","fork":false,"url":"https://api.github.com/repos/euranova/code_retreat","forks_url":"https://api.github.com/repos/euranova/code_retreat/forks","keys_url":"https://api.github.com/repos/euranova/code_retreat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/euranova/code_retreat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/euranova/code_retreat/teams","hooks_url":"https://api.github.com/repos/euranova/code_retreat/hooks","issue_events_url":"https://api.github.com/repos/euranova/code_retreat/issues/events{/number}","events_url":"https://api.github.com/repos/euranova/code_retreat/events","assignees_url":"https://api.github.com/repos/euranova/code_retreat/assignees{/user}","branches_url":"https://api.github.com/repos/euranova/code_retreat/branches{/branch}","tags_url":"https://api.github.com/repos/euranova/code_retreat/tags","blobs_url":"https://api.github.com/repos/euranova/code_retreat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/euranova/code_retreat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/euranova/code_retreat/git/refs{/sha}","trees_url":"https://api.github.com/repos/euranova/code_retreat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/euranova/code_retreat/statuses/{sha}","languages_url":"https://api.github.com/repos/euranova/code_retreat/languages","stargazers_url":"https://api.github.com/repos/euranova/code_retreat/stargazers","contributors_url":"https://api.github.com/repos/euranova/code_retreat/contributors","subscribers_url":"https://api.github.com/repos/euranova/code_retreat/subscribers","subscription_url":"https://api.github.com/repos/euranova/code_retreat/subscription","commits_url":"https://api.github.com/repos/euranova/code_retreat/commits{/sha}","git_commits_url":"https://api.github.com/repos/euranova/code_retreat/git/commits{/sha}","comments_url":"https://api.github.com/repos/euranova/code_retreat/comments{/number}","issue_comment_url":"https://api.github.com/repos/euranova/code_retreat/issues/comments{/number}","contents_url":"https://api.github.com/repos/euranova/code_retreat/contents/{+path}","compare_url":"https://api.github.com/repos/euranova/code_retreat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/euranova/code_retreat/merges","archive_url":"https://api.github.com/repos/euranova/code_retreat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/euranova/code_retreat/downloads","issues_url":"https://api.github.com/repos/euranova/code_retreat/issues{/number}","pulls_url":"https://api.github.com/repos/euranova/code_retreat/pulls{/number}","milestones_url":"https://api.github.com/repos/euranova/code_retreat/milestones{/number}","notifications_url":"https://api.github.com/repos/euranova/code_retreat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/euranova/code_retreat/labels{/name}","releases_url":"https://api.github.com/repos/euranova/code_retreat/releases{/id}","deployments_url":"https://api.github.com/repos/euranova/code_retreat/deployments","created_at":"2016-06-07T08:26:29Z","updated_at":"2017-02-10T15:13:21Z","pushed_at":"2017-09-08T08:06:53Z","git_url":"git://github.com/euranova/code_retreat.git","ssh_url":"[email protected]:euranova/code_retreat.git","clone_url":"https://github.com/euranova/code_retreat.git","svn_url":"https://github.com/euranova/code_retreat","homepage":null,"size":35,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/euranova/code_retreat/pulls/13"},"html":{"href":"https://github.com/euranova/code_retreat/pull/13"},"issue":{"href":"https://api.github.com/repos/euranova/code_retreat/issues/13"},"comments":{"href":"https://api.github.com/repos/euranova/code_retreat/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/euranova/code_retreat/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/euranova/code_retreat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/euranova/code_retreat/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/euranova/code_retreat/statuses/741aa077b57727df1e493737e4500364c9b07a58"}},"author_association":"CONTRIBUTOR"}} | {
"id": 60595880,
"name": "euranova/code_retreat",
"url": "https://api.github.com/repos/euranova/code_retreat"
} | {
"id": 1919739,
"login": "poulinjulien",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1919739?",
"url": "https://api.github.com/users/poulinjulien"
} | {
"id": 2103558,
"login": "euranova",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2103558?",
"url": "https://api.github.com/orgs/euranova"
} | 2017-09-08T08:08:16 | 6565390996 | {"actor":{"display_login":"poulinjulien"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/exercism/ceylon/pulls/comments/134820549","pull_request_review_id":58156918,"id":134820549,"diff_hunk":"@@ -0,0 +1,31 @@\n+import ceylon.test { ... }\n+\n+// Tests adapted from x-common version 1.0.0","path":"exercises/rna-transcription/source/rnatranscription/RNAtest.ceylon","position":3,"original_position":3,"commit_id":"6ccbd0bf57d66e0f218756fc9550e86ef9f52d69","original_commit_id":"6ccbd0bf57d66e0f218756fc9550e86ef9f52d69","user":{"login":"petertseng","id":346181,"avatar_url":"https://avatars2.githubusercontent.com/u/346181?v=4","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"body":"given that problem-specifications is currently at 1.0.1, why not say adapted from 1.0.1?","created_at":"2017-08-23T17:42:51Z","updated_at":"2017-08-23T17:52:51Z","html_url":"https://github.com/exercism/ceylon/pull/47#discussion_r134820549","pull_request_url":"https://api.github.com/repos/exercism/ceylon/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/exercism/ceylon/pulls/comments/134820549"},"html":{"href":"https://github.com/exercism/ceylon/pull/47#discussion_r134820549"},"pull_request":{"href":"https://api.github.com/repos/exercism/ceylon/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/exercism/ceylon/pulls/47","id":137126255,"html_url":"https://github.com/exercism/ceylon/pull/47","diff_url":"https://github.com/exercism/ceylon/pull/47.diff","patch_url":"https://github.com/exercism/ceylon/pull/47.patch","issue_url":"https://api.github.com/repos/exercism/ceylon/issues/47","number":47,"state":"open","locked":false,"title":"[[New Exercise]] RNA Transcription","user":{"login":"WammKD","id":10533934,"avatar_url":"https://avatars0.githubusercontent.com/u/10533934?v=4","gravatar_id":"","url":"https://api.github.com/users/WammKD","html_url":"https://github.com/WammKD","followers_url":"https://api.github.com/users/WammKD/followers","following_url":"https://api.github.com/users/WammKD/following{/other_user}","gists_url":"https://api.github.com/users/WammKD/gists{/gist_id}","starred_url":"https://api.github.com/users/WammKD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WammKD/subscriptions","organizations_url":"https://api.github.com/users/WammKD/orgs","repos_url":"https://api.github.com/users/WammKD/repos","events_url":"https://api.github.com/users/WammKD/events{/privacy}","received_events_url":"https://api.github.com/users/WammKD/received_events","type":"User","site_admin":false},"body":"I think I took care of all required files but let me know if I missed anything.\r\n\r\nAdded the exercise to the config.json file and added the required files (an example under the corresponding directory and module file, file for writing the exercise, and the file containing tests under the source directory) along with updating the README.md.","created_at":"2017-08-23T04:03:58Z","updated_at":"2017-08-23T17:52:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca50e632aff0bfb418933581cb9eff94cfe251fd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/exercism/ceylon/pulls/47/commits","review_comments_url":"https://api.github.com/repos/exercism/ceylon/pulls/47/comments","review_comment_url":"https://api.github.com/repos/exercism/ceylon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exercism/ceylon/issues/47/comments","statuses_url":"https://api.github.com/repos/exercism/ceylon/statuses/6ccbd0bf57d66e0f218756fc9550e86ef9f52d69","head":{"label":"WammKD:master","ref":"master","sha":"6ccbd0bf57d66e0f218756fc9550e86ef9f52d69","user":{"login":"WammKD","id":10533934,"avatar_url":"https://avatars0.githubusercontent.com/u/10533934?v=4","gravatar_id":"","url":"https://api.github.com/users/WammKD","html_url":"https://github.com/WammKD","followers_url":"https://api.github.com/users/WammKD/followers","following_url":"https://api.github.com/users/WammKD/following{/other_user}","gists_url":"https://api.github.com/users/WammKD/gists{/gist_id}","starred_url":"https://api.github.com/users/WammKD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WammKD/subscriptions","organizations_url":"https://api.github.com/users/WammKD/orgs","repos_url":"https://api.github.com/users/WammKD/repos","events_url":"https://api.github.com/users/WammKD/events{/privacy}","received_events_url":"https://api.github.com/users/WammKD/received_events","type":"User","site_admin":false},"repo":{"id":101001816,"name":"ceylon","full_name":"WammKD/ceylon","owner":{"login":"WammKD","id":10533934,"avatar_url":"https://avatars0.githubusercontent.com/u/10533934?v=4","gravatar_id":"","url":"https://api.github.com/users/WammKD","html_url":"https://github.com/WammKD","followers_url":"https://api.github.com/users/WammKD/followers","following_url":"https://api.github.com/users/WammKD/following{/other_user}","gists_url":"https://api.github.com/users/WammKD/gists{/gist_id}","starred_url":"https://api.github.com/users/WammKD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WammKD/subscriptions","organizations_url":"https://api.github.com/users/WammKD/orgs","repos_url":"https://api.github.com/users/WammKD/repos","events_url":"https://api.github.com/users/WammKD/events{/privacy}","received_events_url":"https://api.github.com/users/WammKD/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WammKD/ceylon","description":"Exercism exercises in Ceylon.","fork":true,"url":"https://api.github.com/repos/WammKD/ceylon","forks_url":"https://api.github.com/repos/WammKD/ceylon/forks","keys_url":"https://api.github.com/repos/WammKD/ceylon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WammKD/ceylon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WammKD/ceylon/teams","hooks_url":"https://api.github.com/repos/WammKD/ceylon/hooks","issue_events_url":"https://api.github.com/repos/WammKD/ceylon/issues/events{/number}","events_url":"https://api.github.com/repos/WammKD/ceylon/events","assignees_url":"https://api.github.com/repos/WammKD/ceylon/assignees{/user}","branches_url":"https://api.github.com/repos/WammKD/ceylon/branches{/branch}","tags_url":"https://api.github.com/repos/WammKD/ceylon/tags","blobs_url":"https://api.github.com/repos/WammKD/ceylon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WammKD/ceylon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WammKD/ceylon/git/refs{/sha}","trees_url":"https://api.github.com/repos/WammKD/ceylon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WammKD/ceylon/statuses/{sha}","languages_url":"https://api.github.com/repos/WammKD/ceylon/languages","stargazers_url":"https://api.github.com/repos/WammKD/ceylon/stargazers","contributors_url":"https://api.github.com/repos/WammKD/ceylon/contributors","subscribers_url":"https://api.github.com/repos/WammKD/ceylon/subscribers","subscription_url":"https://api.github.com/repos/WammKD/ceylon/subscription","commits_url":"https://api.github.com/repos/WammKD/ceylon/commits{/sha}","git_commits_url":"https://api.github.com/repos/WammKD/ceylon/git/commits{/sha}","comments_url":"https://api.github.com/repos/WammKD/ceylon/comments{/number}","issue_comment_url":"https://api.github.com/repos/WammKD/ceylon/issues/comments{/number}","contents_url":"https://api.github.com/repos/WammKD/ceylon/contents/{+path}","compare_url":"https://api.github.com/repos/WammKD/ceylon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WammKD/ceylon/merges","archive_url":"https://api.github.com/repos/WammKD/ceylon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WammKD/ceylon/downloads","issues_url":"https://api.github.com/repos/WammKD/ceylon/issues{/number}","pulls_url":"https://api.github.com/repos/WammKD/ceylon/pulls{/number}","milestones_url":"https://api.github.com/repos/WammKD/ceylon/milestones{/number}","notifications_url":"https://api.github.com/repos/WammKD/ceylon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WammKD/ceylon/labels{/name}","releases_url":"https://api.github.com/repos/WammKD/ceylon/releases{/id}","deployments_url":"https://api.github.com/repos/WammKD/ceylon/deployments","created_at":"2017-08-21T23:54:20Z","updated_at":"2017-08-21T23:54:21Z","pushed_at":"2017-08-23T03:54:58Z","git_url":"git://github.com/WammKD/ceylon.git","ssh_url":"[email protected]:WammKD/ceylon.git","clone_url":"https://github.com/WammKD/ceylon.git","svn_url":"https://github.com/WammKD/ceylon","homepage":"http://exercism.io/languages/ceylon","size":85,"stargazers_count":0,"watchers_count":0,"language":"Ceylon","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exercism:master","ref":"master","sha":"7f1c38cf74bdc12c766aacfb0139baff625542e4","user":{"login":"exercism","id":5624255,"avatar_url":"https://avatars0.githubusercontent.com/u/5624255?v=4","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"repo":{"id":62950843,"name":"ceylon","full_name":"exercism/ceylon","owner":{"login":"exercism","id":5624255,"avatar_url":"https://avatars0.githubusercontent.com/u/5624255?v=4","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exercism/ceylon","description":"Exercism exercises in Ceylon.","fork":false,"url":"https://api.github.com/repos/exercism/ceylon","forks_url":"https://api.github.com/repos/exercism/ceylon/forks","keys_url":"https://api.github.com/repos/exercism/ceylon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exercism/ceylon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exercism/ceylon/teams","hooks_url":"https://api.github.com/repos/exercism/ceylon/hooks","issue_events_url":"https://api.github.com/repos/exercism/ceylon/issues/events{/number}","events_url":"https://api.github.com/repos/exercism/ceylon/events","assignees_url":"https://api.github.com/repos/exercism/ceylon/assignees{/user}","branches_url":"https://api.github.com/repos/exercism/ceylon/branches{/branch}","tags_url":"https://api.github.com/repos/exercism/ceylon/tags","blobs_url":"https://api.github.com/repos/exercism/ceylon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exercism/ceylon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exercism/ceylon/git/refs{/sha}","trees_url":"https://api.github.com/repos/exercism/ceylon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exercism/ceylon/statuses/{sha}","languages_url":"https://api.github.com/repos/exercism/ceylon/languages","stargazers_url":"https://api.github.com/repos/exercism/ceylon/stargazers","contributors_url":"https://api.github.com/repos/exercism/ceylon/contributors","subscribers_url":"https://api.github.com/repos/exercism/ceylon/subscribers","subscription_url":"https://api.github.com/repos/exercism/ceylon/subscription","commits_url":"https://api.github.com/repos/exercism/ceylon/commits{/sha}","git_commits_url":"https://api.github.com/repos/exercism/ceylon/git/commits{/sha}","comments_url":"https://api.github.com/repos/exercism/ceylon/comments{/number}","issue_comment_url":"https://api.github.com/repos/exercism/ceylon/issues/comments{/number}","contents_url":"https://api.github.com/repos/exercism/ceylon/contents/{+path}","compare_url":"https://api.github.com/repos/exercism/ceylon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exercism/ceylon/merges","archive_url":"https://api.github.com/repos/exercism/ceylon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exercism/ceylon/downloads","issues_url":"https://api.github.com/repos/exercism/ceylon/issues{/number}","pulls_url":"https://api.github.com/repos/exercism/ceylon/pulls{/number}","milestones_url":"https://api.github.com/repos/exercism/ceylon/milestones{/number}","notifications_url":"https://api.github.com/repos/exercism/ceylon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exercism/ceylon/labels{/name}","releases_url":"https://api.github.com/repos/exercism/ceylon/releases{/id}","deployments_url":"https://api.github.com/repos/exercism/ceylon/deployments","created_at":"2016-07-09T13:30:01Z","updated_at":"2017-06-18T15:55:54Z","pushed_at":"2017-08-23T04:03:59Z","git_url":"git://github.com/exercism/ceylon.git","ssh_url":"[email protected]:exercism/ceylon.git","clone_url":"https://github.com/exercism/ceylon.git","svn_url":"https://github.com/exercism/ceylon","homepage":"http://exercism.io/languages/ceylon","size":80,"stargazers_count":1,"watchers_count":1,"language":"Ceylon","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exercism/ceylon/pulls/47"},"html":{"href":"https://github.com/exercism/ceylon/pull/47"},"issue":{"href":"https://api.github.com/repos/exercism/ceylon/issues/47"},"comments":{"href":"https://api.github.com/repos/exercism/ceylon/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/exercism/ceylon/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/exercism/ceylon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exercism/ceylon/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/exercism/ceylon/statuses/6ccbd0bf57d66e0f218756fc9550e86ef9f52d69"}}}} | {
"id": 62950843,
"name": "exercism/ceylon",
"url": "https://api.github.com/repos/exercism/ceylon"
} | {
"id": 346181,
"login": "petertseng",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/346181?",
"url": "https://api.github.com/users/petertseng"
} | {
"id": 5624255,
"login": "exercism",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5624255?",
"url": "https://api.github.com/orgs/exercism"
} | 2017-08-23T17:42:51 | 6503695541 | {"actor":{"display_login":"petertseng"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/exercism/problem-specifications/pulls/comments/149822149","pull_request_review_id":75277340,"id":149822149,"diff_hunk":"@@ -0,0 +1,143 @@\n+{\n+ \"exercise\": \"protein-translation\",\n+ \"version\": \"1.0.0\",\n+ \"cases\": [\n+ {\n+ \"description\": \"Translate input RNA sequences into proteins\",\n+ \"comments\": [\n+ \"Returns the name of the protein if given RNA is valid, \"\n+ , \"else throws an error. \"\n+ ],\n+ \"cases\": [\n+ {\n+ \"description\": \"Methionine RNA sequence\",\n+ \"property\": \"translate\",\n+ \"strand\": \"AUG\",\n+ \"expected\": [\"Methionine\"]\n+ },\n+ {\n+ \"description\": \"Phenylalanine RNA sequence 1\",\n+ \"property\": \"translate\",\n+ \"strand\": \"UUU\",\n+ \"expected\": [\"Phenylalanine\"]\n+ },\n+ {\n+ \"description\": \"Phenylalanine RNA sequence 2\",\n+ \"property\": \"translate\",\n+ \"strand\": \"UUC\",\n+ \"expected\": [\"Phenylalanine\"]\n+ },\n+ {\n+ \"description\": \"Leucine RNA sequence 1\",\n+ \"property\": \"translate\",\n+ \"strand\": \"UUA\",\n+ \"expected\": [\"Leucine\"]\n+ },\n+ {\n+ \"description\": \"Leucine RNA sequence 2\",\n+ \"property\": \"translate\",\n+ \"strand\": \"UUG\",\n+ \"expected\": [\"Leucine\"]\n+ },\n+ {\n+ \"description\": \"Serine RNA sequence 1\",\n+ \"property\": \"translate\",\n+ \"strand\": \"UCU\",\n+ \"expected\": [\"Serine\"]\n+ },\n+ {\n+ \"description\": \"Serine RNA sequence 2\",\n+ \"property\": \"translate\",\n+ \"strand\": \"UCC\",\n+ \"expected\": [\"Serine\"]\n+ },\n+ {\n+ \"description\": \"Serine RNA sequence 3\",\n+ \"property\": \"translate\",\n+ \"strand\": \"UCA\",\n+ \"expected\": [\"Serine\"]\n+ },\n+ {\n+ \"description\": \"Serine RNA sequence 4\",\n+ \"property\": \"translate\",\n+ \"strand\": \"UCG\",\n+ \"expected\": [\"Serine\"]\n+ },\n+ {\n+ \"description\": \"Tyrosine RNA sequence 1\",\n+ \"property\": \"translate\",\n+ \"strand\": \"UAU\",\n+ \"expected\": [\"Tyrosine\"]\n+ },\n+ {\n+ \"description\": \"Tyrosine RNA sequence 2\",\n+ \"property\": \"translate\",\n+ \"strand\": \"UAC\",\n+ \"expected\": [\"Tyrosine\"]\n+ },\n+ {\n+ \"description\": \"Cysteine RNA sequence 1\",\n+ \"property\": \"translate\",\n+ \"strand\": \"UGU\",\n+ \"expected\": [\"Cysteine\"]\n+ },\n+ {\n+ \"description\": \"Cysteine RNA sequence 2\",\n+ \"property\": \"translate\",\n+ \"strand\": \"UGC\",\n+ \"expected\": [\"Cysteine\"]\n+ },\n+ {\n+ \"description\": \"Tryptophan RNA sequence\",\n+ \"property\": \"translate\",\n+ \"strand\": \"UGG\",\n+ \"expected\": [\"Tryptophan\"]\n+ },\n+ {\n+ \"description\": \"STOP codon RNA sequence 1\",\n+ \"property\": \"translate\",\n+ \"strand\": \"UAA\",\n+ \"expected\": []\n+ },\n+ {\n+ \"description\": \"STOP codon RNA sequence 2\",\n+ \"property\": \"translate\",\n+ \"strand\": \"UAG\",\n+ \"expected\": []\n+ },\n+ {\n+ \"description\": \"STOP codon RNA sequence 3\",","path":"exercises/protein-translation/canonical-data.json","position":109,"original_position":109,"commit_id":"a0be642b0fc97dff07410a116e2e1e49f18fbfc4","original_commit_id":"a0be642b0fc97dff07410a116e2e1e49f18fbfc4","user":{"login":"Insti","id":5096681,"avatar_url":"https://avatars2.githubusercontent.com/u/5096681?v=4","gravatar_id":"","url":"https://api.github.com/users/Insti","html_url":"https://github.com/Insti","followers_url":"https://api.github.com/users/Insti/followers","following_url":"https://api.github.com/users/Insti/following{/other_user}","gists_url":"https://api.github.com/users/Insti/gists{/gist_id}","starred_url":"https://api.github.com/users/Insti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Insti/subscriptions","organizations_url":"https://api.github.com/users/Insti/orgs","repos_url":"https://api.github.com/users/Insti/repos","events_url":"https://api.github.com/users/Insti/events{/privacy}","received_events_url":"https://api.github.com/users/Insti/received_events","type":"User","site_admin":false},"body":"I'd like to see tests for more of the simple STOP codon sequences.\r\n`UAGUGG`\r\n`UGGUAG`\r\n`UGGUAGUGG`","created_at":"2017-11-08T22:56:11Z","updated_at":"2017-11-08T22:59:08Z","html_url":"https://github.com/exercism/problem-specifications/pull/997#discussion_r149822149","pull_request_url":"https://api.github.com/repos/exercism/problem-specifications/pulls/997","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/exercism/problem-specifications/pulls/comments/149822149"},"html":{"href":"https://github.com/exercism/problem-specifications/pull/997#discussion_r149822149"},"pull_request":{"href":"https://api.github.com/repos/exercism/problem-specifications/pulls/997"}}},"pull_request":{"url":"https://api.github.com/repos/exercism/problem-specifications/pulls/997","id":151416750,"html_url":"https://github.com/exercism/problem-specifications/pull/997","diff_url":"https://github.com/exercism/problem-specifications/pull/997.diff","patch_url":"https://github.com/exercism/problem-specifications/pull/997.patch","issue_url":"https://api.github.com/repos/exercism/problem-specifications/issues/997","number":997,"state":"open","locked":false,"title":"protein-translation: Add canonical data.","user":{"login":"sjwarner-bp","id":30871823,"avatar_url":"https://avatars3.githubusercontent.com/u/30871823?v=4","gravatar_id":"","url":"https://api.github.com/users/sjwarner-bp","html_url":"https://github.com/sjwarner-bp","followers_url":"https://api.github.com/users/sjwarner-bp/followers","following_url":"https://api.github.com/users/sjwarner-bp/following{/other_user}","gists_url":"https://api.github.com/users/sjwarner-bp/gists{/gist_id}","starred_url":"https://api.github.com/users/sjwarner-bp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjwarner-bp/subscriptions","organizations_url":"https://api.github.com/users/sjwarner-bp/orgs","repos_url":"https://api.github.com/users/sjwarner-bp/repos","events_url":"https://api.github.com/users/sjwarner-bp/events{/privacy}","received_events_url":"https://api.github.com/users/sjwarner-bp/received_events","type":"User","site_admin":false},"body":"Add protein translation canonical data as per #577.\r\n\r\nAfter going to implement this exercise in Java, and realising that there is not a `canonical-data.json` for the problem, I decided to do this. I have helped a friend complete this exercise on the Python track, and believe the Python tests to be very comprehensive, so I have used them as my main source of data.\r\n\r\nPlease let me know if this is too long for a `canonical-data.json`, as there are about 20 tests...","created_at":"2017-11-08T15:41:28Z","updated_at":"2017-11-08T22:59:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9c6e2cc5caee24dedb27c5253377dcf6bc035bb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/exercism/problem-specifications/pulls/997/commits","review_comments_url":"https://api.github.com/repos/exercism/problem-specifications/pulls/997/comments","review_comment_url":"https://api.github.com/repos/exercism/problem-specifications/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exercism/problem-specifications/issues/997/comments","statuses_url":"https://api.github.com/repos/exercism/problem-specifications/statuses/a0be642b0fc97dff07410a116e2e1e49f18fbfc4","head":{"label":"sjwarner-bp:protein-translation-canonical-data","ref":"protein-translation-canonical-data","sha":"a0be642b0fc97dff07410a116e2e1e49f18fbfc4","user":{"login":"sjwarner-bp","id":30871823,"avatar_url":"https://avatars3.githubusercontent.com/u/30871823?v=4","gravatar_id":"","url":"https://api.github.com/users/sjwarner-bp","html_url":"https://github.com/sjwarner-bp","followers_url":"https://api.github.com/users/sjwarner-bp/followers","following_url":"https://api.github.com/users/sjwarner-bp/following{/other_user}","gists_url":"https://api.github.com/users/sjwarner-bp/gists{/gist_id}","starred_url":"https://api.github.com/users/sjwarner-bp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjwarner-bp/subscriptions","organizations_url":"https://api.github.com/users/sjwarner-bp/orgs","repos_url":"https://api.github.com/users/sjwarner-bp/repos","events_url":"https://api.github.com/users/sjwarner-bp/events{/privacy}","received_events_url":"https://api.github.com/users/sjwarner-bp/received_events","type":"User","site_admin":false},"repo":{"id":105127276,"name":"problem-specifications","full_name":"sjwarner-bp/problem-specifications","owner":{"login":"sjwarner-bp","id":30871823,"avatar_url":"https://avatars3.githubusercontent.com/u/30871823?v=4","gravatar_id":"","url":"https://api.github.com/users/sjwarner-bp","html_url":"https://github.com/sjwarner-bp","followers_url":"https://api.github.com/users/sjwarner-bp/followers","following_url":"https://api.github.com/users/sjwarner-bp/following{/other_user}","gists_url":"https://api.github.com/users/sjwarner-bp/gists{/gist_id}","starred_url":"https://api.github.com/users/sjwarner-bp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjwarner-bp/subscriptions","organizations_url":"https://api.github.com/users/sjwarner-bp/orgs","repos_url":"https://api.github.com/users/sjwarner-bp/repos","events_url":"https://api.github.com/users/sjwarner-bp/events{/privacy}","received_events_url":"https://api.github.com/users/sjwarner-bp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sjwarner-bp/problem-specifications","description":"Shared metadata for exercism exercises.","fork":true,"url":"https://api.github.com/repos/sjwarner-bp/problem-specifications","forks_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/forks","keys_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/teams","hooks_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/hooks","issue_events_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/issues/events{/number}","events_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/events","assignees_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/assignees{/user}","branches_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/branches{/branch}","tags_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/tags","blobs_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/statuses/{sha}","languages_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/languages","stargazers_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/stargazers","contributors_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/contributors","subscribers_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/subscribers","subscription_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/subscription","commits_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/contents/{+path}","compare_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/merges","archive_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/downloads","issues_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/issues{/number}","pulls_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/pulls{/number}","milestones_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/milestones{/number}","notifications_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/labels{/name}","releases_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/releases{/id}","deployments_url":"https://api.github.com/repos/sjwarner-bp/problem-specifications/deployments","created_at":"2017-09-28T09:10:25Z","updated_at":"2017-09-28T09:10:27Z","pushed_at":"2017-11-08T16:47:42Z","git_url":"git://github.com/sjwarner-bp/problem-specifications.git","ssh_url":"[email protected]:sjwarner-bp/problem-specifications.git","clone_url":"https://github.com/sjwarner-bp/problem-specifications.git","svn_url":"https://github.com/sjwarner-bp/problem-specifications","homepage":null,"size":1270,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exercism:master","ref":"master","sha":"e93924e30cc78384c692305314d47f6cdb86914b","user":{"login":"exercism","id":5624255,"avatar_url":"https://avatars0.githubusercontent.com/u/5624255?v=4","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"repo":{"id":17259886,"name":"problem-specifications","full_name":"exercism/problem-specifications","owner":{"login":"exercism","id":5624255,"avatar_url":"https://avatars0.githubusercontent.com/u/5624255?v=4","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exercism/problem-specifications","description":"Shared metadata for exercism exercises.","fork":false,"url":"https://api.github.com/repos/exercism/problem-specifications","forks_url":"https://api.github.com/repos/exercism/problem-specifications/forks","keys_url":"https://api.github.com/repos/exercism/problem-specifications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exercism/problem-specifications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exercism/problem-specifications/teams","hooks_url":"https://api.github.com/repos/exercism/problem-specifications/hooks","issue_events_url":"https://api.github.com/repos/exercism/problem-specifications/issues/events{/number}","events_url":"https://api.github.com/repos/exercism/problem-specifications/events","assignees_url":"https://api.github.com/repos/exercism/problem-specifications/assignees{/user}","branches_url":"https://api.github.com/repos/exercism/problem-specifications/branches{/branch}","tags_url":"https://api.github.com/repos/exercism/problem-specifications/tags","blobs_url":"https://api.github.com/repos/exercism/problem-specifications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exercism/problem-specifications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exercism/problem-specifications/git/refs{/sha}","trees_url":"https://api.github.com/repos/exercism/problem-specifications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exercism/problem-specifications/statuses/{sha}","languages_url":"https://api.github.com/repos/exercism/problem-specifications/languages","stargazers_url":"https://api.github.com/repos/exercism/problem-specifications/stargazers","contributors_url":"https://api.github.com/repos/exercism/problem-specifications/contributors","subscribers_url":"https://api.github.com/repos/exercism/problem-specifications/subscribers","subscription_url":"https://api.github.com/repos/exercism/problem-specifications/subscription","commits_url":"https://api.github.com/repos/exercism/problem-specifications/commits{/sha}","git_commits_url":"https://api.github.com/repos/exercism/problem-specifications/git/commits{/sha}","comments_url":"https://api.github.com/repos/exercism/problem-specifications/comments{/number}","issue_comment_url":"https://api.github.com/repos/exercism/problem-specifications/issues/comments{/number}","contents_url":"https://api.github.com/repos/exercism/problem-specifications/contents/{+path}","compare_url":"https://api.github.com/repos/exercism/problem-specifications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exercism/problem-specifications/merges","archive_url":"https://api.github.com/repos/exercism/problem-specifications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exercism/problem-specifications/downloads","issues_url":"https://api.github.com/repos/exercism/problem-specifications/issues{/number}","pulls_url":"https://api.github.com/repos/exercism/problem-specifications/pulls{/number}","milestones_url":"https://api.github.com/repos/exercism/problem-specifications/milestones{/number}","notifications_url":"https://api.github.com/repos/exercism/problem-specifications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exercism/problem-specifications/labels{/name}","releases_url":"https://api.github.com/repos/exercism/problem-specifications/releases{/id}","deployments_url":"https://api.github.com/repos/exercism/problem-specifications/deployments","created_at":"2014-02-27T18:40:48Z","updated_at":"2017-11-06T00:21:36Z","pushed_at":"2017-11-08T22:57:58Z","git_url":"git://github.com/exercism/problem-specifications.git","ssh_url":"[email protected]:exercism/problem-specifications.git","clone_url":"https://github.com/exercism/problem-specifications.git","svn_url":"https://github.com/exercism/problem-specifications","homepage":null,"size":1253,"stargazers_count":119,"watchers_count":119,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":280,"mirror_url":null,"archived":false,"open_issues_count":86,"forks":280,"open_issues":86,"watchers":119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exercism/problem-specifications/pulls/997"},"html":{"href":"https://github.com/exercism/problem-specifications/pull/997"},"issue":{"href":"https://api.github.com/repos/exercism/problem-specifications/issues/997"},"comments":{"href":"https://api.github.com/repos/exercism/problem-specifications/issues/997/comments"},"review_comments":{"href":"https://api.github.com/repos/exercism/problem-specifications/pulls/997/comments"},"review_comment":{"href":"https://api.github.com/repos/exercism/problem-specifications/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exercism/problem-specifications/pulls/997/commits"},"statuses":{"href":"https://api.github.com/repos/exercism/problem-specifications/statuses/a0be642b0fc97dff07410a116e2e1e49f18fbfc4"}},"author_association":"CONTRIBUTOR"}} | {
"id": 17259886,
"name": "exercism/problem-specifications",
"url": "https://api.github.com/repos/exercism/problem-specifications"
} | {
"id": 5096681,
"login": "Insti",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5096681?",
"url": "https://api.github.com/users/Insti"
} | {
"id": 5624255,
"login": "exercism",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5624255?",
"url": "https://api.github.com/orgs/exercism"
} | 2017-11-08T22:56:11 | 6829134471 | {"actor":{"display_login":"Insti"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/exercism/elixir/pulls/comments/144806815","pull_request_review_id":69513564,"id":144806815,"diff_hunk":"@@ -1,59 +1,51 @@\n defmodule Luhn do\n- @doc \"\"\"\n- Calculates the total checksum of a number\n- \"\"\"\n- @spec checksum(String.t()) :: integer\n- def checksum(number) do\n- number\n- |> String.reverse\n- |> String.graphemes\n- |> Enum.with_index\n- |> Enum.map(&do_checksum/1)\n- |> Enum.sum\n- end\n-\n- defp do_checksum({digit, index}) do\n- digit\n- |> String.to_integer\n- |> double_if_even_index(index)\n- |> compact\n- end\n-\n- defp compact(num) when num < 10, do: num\n- defp compact(num) do\n- num\n- |> Integer.digits\n- |> Enum.sum\n- |> compact\n- end\n \n @doc \"\"\"\n Checks if the given number is valid via the luhn formula\n \"\"\"\n @spec valid?(String.t()) :: boolean\n def valid?(number) do\n- number |> checksum |> rem(10) == 0\n+\n+ with number <- String.replace(number, \" \", \"\"),\n+ {_, \"\"} <- Integer.parse(number),\n+ true <- String.length(number) > 1,\n+ true <- checksum(number)\n+ do\n+ true\n+ else\n+ _ -> false\n+ end\n end\n \n @doc \"\"\"\n- Creates a valid number by adding the correct\n- checksum digit to the end of the number\n+ Applies the luhn formula to a string only containing integers ","path":"exercises/luhn/example.exs","position":51,"original_position":51,"commit_id":"bc008da96f80fec121db516ea99a55e18219ca49","original_commit_id":"bc008da96f80fec121db516ea99a55e18219ca49","user":{"login":"devonestes","id":8422484,"avatar_url":"https://avatars1.githubusercontent.com/u/8422484?v=4","gravatar_id":"","url":"https://api.github.com/users/devonestes","html_url":"https://github.com/devonestes","followers_url":"https://api.github.com/users/devonestes/followers","following_url":"https://api.github.com/users/devonestes/following{/other_user}","gists_url":"https://api.github.com/users/devonestes/gists{/gist_id}","starred_url":"https://api.github.com/users/devonestes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devonestes/subscriptions","organizations_url":"https://api.github.com/users/devonestes/orgs","repos_url":"https://api.github.com/users/devonestes/repos","events_url":"https://api.github.com/users/devonestes/events{/privacy}","received_events_url":"https://api.github.com/users/devonestes/received_events","type":"User","site_admin":false},"body":"The reason CI is failing right now is because all `@doc` tags on private functions are discarded. If you still feel like you need to document this, you can do so with normal comments, but given that this is just a sort of \"proof of concept\" for the exercise showing that it's possible to solve all the tests in the suite, I think you can safely delete them.","created_at":"2017-10-16T10:14:51Z","updated_at":"2017-10-16T10:20:37Z","html_url":"https://github.com/exercism/elixir/pull/376#discussion_r144806815","pull_request_url":"https://api.github.com/repos/exercism/elixir/pulls/376","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/exercism/elixir/pulls/comments/144806815"},"html":{"href":"https://github.com/exercism/elixir/pull/376#discussion_r144806815"},"pull_request":{"href":"https://api.github.com/repos/exercism/elixir/pulls/376"}}},"pull_request":{"url":"https://api.github.com/repos/exercism/elixir/pulls/376","id":146605586,"html_url":"https://github.com/exercism/elixir/pull/376","diff_url":"https://github.com/exercism/elixir/pull/376.diff","patch_url":"https://github.com/exercism/elixir/pull/376.patch","issue_url":"https://api.github.com/repos/exercism/elixir/issues/376","number":376,"state":"open","locked":false,"title":"Changes to Luhn exercise","user":{"login":"stfnsr","id":4975791,"avatar_url":"https://avatars0.githubusercontent.com/u/4975791?v=4","gravatar_id":"","url":"https://api.github.com/users/stfnsr","html_url":"https://github.com/stfnsr","followers_url":"https://api.github.com/users/stfnsr/followers","following_url":"https://api.github.com/users/stfnsr/following{/other_user}","gists_url":"https://api.github.com/users/stfnsr/gists{/gist_id}","starred_url":"https://api.github.com/users/stfnsr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stfnsr/subscriptions","organizations_url":"https://api.github.com/users/stfnsr/orgs","repos_url":"https://api.github.com/users/stfnsr/repos","events_url":"https://api.github.com/users/stfnsr/events{/privacy}","received_events_url":"https://api.github.com/users/stfnsr/received_events","type":"User","site_admin":false},"body":"I updated the tests for Luhn (#285),\r\nit was also neccessary to rewrite the implementation in example.exs.\r\nIf this is unidiomatic or bad in other ways, i welcome feedback :)\r\n\r\n","created_at":"2017-10-14T14:42:39Z","updated_at":"2017-10-16T10:20:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e68542de93a10a4e97624c25d91a9568cca7b1f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/exercism/elixir/pulls/376/commits","review_comments_url":"https://api.github.com/repos/exercism/elixir/pulls/376/comments","review_comment_url":"https://api.github.com/repos/exercism/elixir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exercism/elixir/issues/376/comments","statuses_url":"https://api.github.com/repos/exercism/elixir/statuses/bc008da96f80fec121db516ea99a55e18219ca49","head":{"label":"stfnsr:master","ref":"master","sha":"bc008da96f80fec121db516ea99a55e18219ca49","user":{"login":"stfnsr","id":4975791,"avatar_url":"https://avatars0.githubusercontent.com/u/4975791?v=4","gravatar_id":"","url":"https://api.github.com/users/stfnsr","html_url":"https://github.com/stfnsr","followers_url":"https://api.github.com/users/stfnsr/followers","following_url":"https://api.github.com/users/stfnsr/following{/other_user}","gists_url":"https://api.github.com/users/stfnsr/gists{/gist_id}","starred_url":"https://api.github.com/users/stfnsr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stfnsr/subscriptions","organizations_url":"https://api.github.com/users/stfnsr/orgs","repos_url":"https://api.github.com/users/stfnsr/repos","events_url":"https://api.github.com/users/stfnsr/events{/privacy}","received_events_url":"https://api.github.com/users/stfnsr/received_events","type":"User","site_admin":false},"repo":{"id":106922506,"name":"elixir","full_name":"stfnsr/elixir","owner":{"login":"stfnsr","id":4975791,"avatar_url":"https://avatars0.githubusercontent.com/u/4975791?v=4","gravatar_id":"","url":"https://api.github.com/users/stfnsr","html_url":"https://github.com/stfnsr","followers_url":"https://api.github.com/users/stfnsr/followers","following_url":"https://api.github.com/users/stfnsr/following{/other_user}","gists_url":"https://api.github.com/users/stfnsr/gists{/gist_id}","starred_url":"https://api.github.com/users/stfnsr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stfnsr/subscriptions","organizations_url":"https://api.github.com/users/stfnsr/orgs","repos_url":"https://api.github.com/users/stfnsr/repos","events_url":"https://api.github.com/users/stfnsr/events{/privacy}","received_events_url":"https://api.github.com/users/stfnsr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stfnsr/elixir","description":"Exercism exercises in Elixir.","fork":true,"url":"https://api.github.com/repos/stfnsr/elixir","forks_url":"https://api.github.com/repos/stfnsr/elixir/forks","keys_url":"https://api.github.com/repos/stfnsr/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stfnsr/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stfnsr/elixir/teams","hooks_url":"https://api.github.com/repos/stfnsr/elixir/hooks","issue_events_url":"https://api.github.com/repos/stfnsr/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/stfnsr/elixir/events","assignees_url":"https://api.github.com/repos/stfnsr/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/stfnsr/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/stfnsr/elixir/tags","blobs_url":"https://api.github.com/repos/stfnsr/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stfnsr/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stfnsr/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/stfnsr/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stfnsr/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/stfnsr/elixir/languages","stargazers_url":"https://api.github.com/repos/stfnsr/elixir/stargazers","contributors_url":"https://api.github.com/repos/stfnsr/elixir/contributors","subscribers_url":"https://api.github.com/repos/stfnsr/elixir/subscribers","subscription_url":"https://api.github.com/repos/stfnsr/elixir/subscription","commits_url":"https://api.github.com/repos/stfnsr/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/stfnsr/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/stfnsr/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/stfnsr/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/stfnsr/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/stfnsr/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stfnsr/elixir/merges","archive_url":"https://api.github.com/repos/stfnsr/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stfnsr/elixir/downloads","issues_url":"https://api.github.com/repos/stfnsr/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/stfnsr/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/stfnsr/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/stfnsr/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stfnsr/elixir/labels{/name}","releases_url":"https://api.github.com/repos/stfnsr/elixir/releases{/id}","deployments_url":"https://api.github.com/repos/stfnsr/elixir/deployments","created_at":"2017-10-14T11:32:03Z","updated_at":"2017-10-14T11:32:05Z","pushed_at":"2017-10-14T14:36:37Z","git_url":"git://github.com/stfnsr/elixir.git","ssh_url":"[email protected]:stfnsr/elixir.git","clone_url":"https://github.com/stfnsr/elixir.git","svn_url":"https://github.com/stfnsr/elixir","homepage":"http://exercism.io/languages/elixir","size":706,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exercism:master","ref":"master","sha":"fdf70cf1b6947b6219dcc6d44ed0586ea83aaf58","user":{"login":"exercism","id":5624255,"avatar_url":"https://avatars0.githubusercontent.com/u/5624255?v=4","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"repo":{"id":17271271,"name":"elixir","full_name":"exercism/elixir","owner":{"login":"exercism","id":5624255,"avatar_url":"https://avatars0.githubusercontent.com/u/5624255?v=4","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exercism/elixir","description":"Exercism exercises in Elixir.","fork":false,"url":"https://api.github.com/repos/exercism/elixir","forks_url":"https://api.github.com/repos/exercism/elixir/forks","keys_url":"https://api.github.com/repos/exercism/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exercism/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exercism/elixir/teams","hooks_url":"https://api.github.com/repos/exercism/elixir/hooks","issue_events_url":"https://api.github.com/repos/exercism/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/exercism/elixir/events","assignees_url":"https://api.github.com/repos/exercism/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/exercism/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/exercism/elixir/tags","blobs_url":"https://api.github.com/repos/exercism/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exercism/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exercism/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/exercism/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exercism/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/exercism/elixir/languages","stargazers_url":"https://api.github.com/repos/exercism/elixir/stargazers","contributors_url":"https://api.github.com/repos/exercism/elixir/contributors","subscribers_url":"https://api.github.com/repos/exercism/elixir/subscribers","subscription_url":"https://api.github.com/repos/exercism/elixir/subscription","commits_url":"https://api.github.com/repos/exercism/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/exercism/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/exercism/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/exercism/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/exercism/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/exercism/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exercism/elixir/merges","archive_url":"https://api.github.com/repos/exercism/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exercism/elixir/downloads","issues_url":"https://api.github.com/repos/exercism/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/exercism/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/exercism/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/exercism/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exercism/elixir/labels{/name}","releases_url":"https://api.github.com/repos/exercism/elixir/releases{/id}","deployments_url":"https://api.github.com/repos/exercism/elixir/deployments","created_at":"2014-02-28T01:19:15Z","updated_at":"2017-10-15T13:48:45Z","pushed_at":"2017-10-15T15:38:21Z","git_url":"git://github.com/exercism/elixir.git","ssh_url":"[email protected]:exercism/elixir.git","clone_url":"https://github.com/exercism/elixir.git","svn_url":"https://github.com/exercism/elixir","homepage":"http://exercism.io/languages/elixir","size":700,"stargazers_count":193,"watchers_count":193,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":9,"forks":145,"open_issues":9,"watchers":193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exercism/elixir/pulls/376"},"html":{"href":"https://github.com/exercism/elixir/pull/376"},"issue":{"href":"https://api.github.com/repos/exercism/elixir/issues/376"},"comments":{"href":"https://api.github.com/repos/exercism/elixir/issues/376/comments"},"review_comments":{"href":"https://api.github.com/repos/exercism/elixir/pulls/376/comments"},"review_comment":{"href":"https://api.github.com/repos/exercism/elixir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exercism/elixir/pulls/376/commits"},"statuses":{"href":"https://api.github.com/repos/exercism/elixir/statuses/bc008da96f80fec121db516ea99a55e18219ca49"}},"author_association":"NONE"}} | {
"id": 17271271,
"name": "exercism/elixir",
"url": "https://api.github.com/repos/exercism/elixir"
} | {
"id": 8422484,
"login": "devonestes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8422484?",
"url": "https://api.github.com/users/devonestes"
} | {
"id": 5624255,
"login": "exercism",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5624255?",
"url": "https://api.github.com/orgs/exercism"
} | 2017-10-16T10:14:51 | 6721107251 | {"actor":{"display_login":"devonestes"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/exercism/xhaskell/pulls/comments/109304934","pull_request_review_id":30400593,"id":109304934,"diff_hunk":"@@ -0,0 +1 @@\n+resolver: lts-8.6","path":"exercises/pangram/stack.yaml","position":1,"original_position":1,"commit_id":"3cdeaea85df8d71673d3cf03f7381cf32793f970","original_commit_id":"3cdeaea85df8d71673d3cf03f7381cf32793f970","user":{"login":"lpalma","id":1479232,"avatar_url":"https://avatars3.githubusercontent.com/u/1479232?v=3","gravatar_id":"","url":"https://api.github.com/users/lpalma","html_url":"https://github.com/lpalma","followers_url":"https://api.github.com/users/lpalma/followers","following_url":"https://api.github.com/users/lpalma/following{/other_user}","gists_url":"https://api.github.com/users/lpalma/gists{/gist_id}","starred_url":"https://api.github.com/users/lpalma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpalma/subscriptions","organizations_url":"https://api.github.com/users/lpalma/orgs","repos_url":"https://api.github.com/users/lpalma/repos","events_url":"https://api.github.com/users/lpalma/events{/privacy}","received_events_url":"https://api.github.com/users/lpalma/received_events","type":"User","site_admin":false},"body":"Ah, I just read the [instructions](https://github.com/exercism/xhaskell#exercise-structure) again and realised I may have misunderstood this bit:\r\n\r\n>* `stack.yaml` has just one line specifying the current [Stack snapshot](https://www.stackage.org/snapshots). We use the same resolver for all the exercises.\r\n\r\nThe first part suggests we should include the current Snapshot from the link given, but the second part says we should use the same resolver for all exercises!!!11one\r\n\r\nI'd prefer consistency within the track, so either downgrade this one to `lts-8.2`, or upgrade the others.\r\n\r\nPerhaps we could fix the resolver version in a config file within `xhaskell` and then create a bin in `xhaskell/bin` that will generate the `stack.yaml` for a given path? Starting with `stack.yaml`, this could evolve to a file that would generate the full exercise structure.","created_at":"2017-04-02T09:54:22Z","updated_at":"2017-04-02T09:54:22Z","html_url":"https://github.com/exercism/xhaskell/pull/511#discussion_r109304934","pull_request_url":"https://api.github.com/repos/exercism/xhaskell/pulls/511","_links":{"self":{"href":"https://api.github.com/repos/exercism/xhaskell/pulls/comments/109304934"},"html":{"href":"https://github.com/exercism/xhaskell/pull/511#discussion_r109304934"},"pull_request":{"href":"https://api.github.com/repos/exercism/xhaskell/pulls/511"}}},"pull_request":{"url":"https://api.github.com/repos/exercism/xhaskell/pulls/511","id":113045468,"html_url":"https://github.com/exercism/xhaskell/pull/511","diff_url":"https://github.com/exercism/xhaskell/pull/511.diff","patch_url":"https://github.com/exercism/xhaskell/pull/511.patch","issue_url":"https://api.github.com/repos/exercism/xhaskell/issues/511","number":511,"state":"open","locked":false,"title":"Add Pangram Exercise","user":{"login":"lpalma","id":1479232,"avatar_url":"https://avatars3.githubusercontent.com/u/1479232?v=3","gravatar_id":"","url":"https://api.github.com/users/lpalma","html_url":"https://github.com/lpalma","followers_url":"https://api.github.com/users/lpalma/followers","following_url":"https://api.github.com/users/lpalma/following{/other_user}","gists_url":"https://api.github.com/users/lpalma/gists{/gist_id}","starred_url":"https://api.github.com/users/lpalma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpalma/subscriptions","organizations_url":"https://api.github.com/users/lpalma/orgs","repos_url":"https://api.github.com/users/lpalma/repos","events_url":"https://api.github.com/users/lpalma/events{/privacy}","received_events_url":"https://api.github.com/users/lpalma/received_events","type":"User","site_admin":false},"body":"I think this exercise is fairly trivial to be implemented. Plus, it is good to have more exercises between Bob and Run Length Encoding, since the first is much simpler than the latter.","created_at":"2017-03-28T19:14:07Z","updated_at":"2017-04-02T09:54:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1ecaa302977b4a7c82660ee88dfee827a90f72b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/exercism/xhaskell/pulls/511/commits","review_comments_url":"https://api.github.com/repos/exercism/xhaskell/pulls/511/comments","review_comment_url":"https://api.github.com/repos/exercism/xhaskell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exercism/xhaskell/issues/511/comments","statuses_url":"https://api.github.com/repos/exercism/xhaskell/statuses/3cdeaea85df8d71673d3cf03f7381cf32793f970","head":{"label":"lpalma:add-pangram","ref":"add-pangram","sha":"3cdeaea85df8d71673d3cf03f7381cf32793f970","user":{"login":"lpalma","id":1479232,"avatar_url":"https://avatars3.githubusercontent.com/u/1479232?v=3","gravatar_id":"","url":"https://api.github.com/users/lpalma","html_url":"https://github.com/lpalma","followers_url":"https://api.github.com/users/lpalma/followers","following_url":"https://api.github.com/users/lpalma/following{/other_user}","gists_url":"https://api.github.com/users/lpalma/gists{/gist_id}","starred_url":"https://api.github.com/users/lpalma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpalma/subscriptions","organizations_url":"https://api.github.com/users/lpalma/orgs","repos_url":"https://api.github.com/users/lpalma/repos","events_url":"https://api.github.com/users/lpalma/events{/privacy}","received_events_url":"https://api.github.com/users/lpalma/received_events","type":"User","site_admin":false},"repo":{"id":84590748,"name":"xhaskell","full_name":"lpalma/xhaskell","owner":{"login":"lpalma","id":1479232,"avatar_url":"https://avatars3.githubusercontent.com/u/1479232?v=3","gravatar_id":"","url":"https://api.github.com/users/lpalma","html_url":"https://github.com/lpalma","followers_url":"https://api.github.com/users/lpalma/followers","following_url":"https://api.github.com/users/lpalma/following{/other_user}","gists_url":"https://api.github.com/users/lpalma/gists{/gist_id}","starred_url":"https://api.github.com/users/lpalma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpalma/subscriptions","organizations_url":"https://api.github.com/users/lpalma/orgs","repos_url":"https://api.github.com/users/lpalma/repos","events_url":"https://api.github.com/users/lpalma/events{/privacy}","received_events_url":"https://api.github.com/users/lpalma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lpalma/xhaskell","description":"Exercism Exercises in Haskell","fork":true,"url":"https://api.github.com/repos/lpalma/xhaskell","forks_url":"https://api.github.com/repos/lpalma/xhaskell/forks","keys_url":"https://api.github.com/repos/lpalma/xhaskell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lpalma/xhaskell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lpalma/xhaskell/teams","hooks_url":"https://api.github.com/repos/lpalma/xhaskell/hooks","issue_events_url":"https://api.github.com/repos/lpalma/xhaskell/issues/events{/number}","events_url":"https://api.github.com/repos/lpalma/xhaskell/events","assignees_url":"https://api.github.com/repos/lpalma/xhaskell/assignees{/user}","branches_url":"https://api.github.com/repos/lpalma/xhaskell/branches{/branch}","tags_url":"https://api.github.com/repos/lpalma/xhaskell/tags","blobs_url":"https://api.github.com/repos/lpalma/xhaskell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lpalma/xhaskell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lpalma/xhaskell/git/refs{/sha}","trees_url":"https://api.github.com/repos/lpalma/xhaskell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lpalma/xhaskell/statuses/{sha}","languages_url":"https://api.github.com/repos/lpalma/xhaskell/languages","stargazers_url":"https://api.github.com/repos/lpalma/xhaskell/stargazers","contributors_url":"https://api.github.com/repos/lpalma/xhaskell/contributors","subscribers_url":"https://api.github.com/repos/lpalma/xhaskell/subscribers","subscription_url":"https://api.github.com/repos/lpalma/xhaskell/subscription","commits_url":"https://api.github.com/repos/lpalma/xhaskell/commits{/sha}","git_commits_url":"https://api.github.com/repos/lpalma/xhaskell/git/commits{/sha}","comments_url":"https://api.github.com/repos/lpalma/xhaskell/comments{/number}","issue_comment_url":"https://api.github.com/repos/lpalma/xhaskell/issues/comments{/number}","contents_url":"https://api.github.com/repos/lpalma/xhaskell/contents/{+path}","compare_url":"https://api.github.com/repos/lpalma/xhaskell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lpalma/xhaskell/merges","archive_url":"https://api.github.com/repos/lpalma/xhaskell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lpalma/xhaskell/downloads","issues_url":"https://api.github.com/repos/lpalma/xhaskell/issues{/number}","pulls_url":"https://api.github.com/repos/lpalma/xhaskell/pulls{/number}","milestones_url":"https://api.github.com/repos/lpalma/xhaskell/milestones{/number}","notifications_url":"https://api.github.com/repos/lpalma/xhaskell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lpalma/xhaskell/labels{/name}","releases_url":"https://api.github.com/repos/lpalma/xhaskell/releases{/id}","deployments_url":"https://api.github.com/repos/lpalma/xhaskell/deployments","created_at":"2017-03-10T18:47:42Z","updated_at":"2017-03-10T18:47:44Z","pushed_at":"2017-04-01T14:03:55Z","git_url":"git://github.com/lpalma/xhaskell.git","ssh_url":"[email protected]:lpalma/xhaskell.git","clone_url":"https://github.com/lpalma/xhaskell.git","svn_url":"https://github.com/lpalma/xhaskell","homepage":null,"size":887,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exercism:master","ref":"master","sha":"59e0e16ac599c031f6d15532d8142f6c7d267d87","user":{"login":"exercism","id":5624255,"avatar_url":"https://avatars3.githubusercontent.com/u/5624255?v=3","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"repo":{"id":17273391,"name":"xhaskell","full_name":"exercism/xhaskell","owner":{"login":"exercism","id":5624255,"avatar_url":"https://avatars3.githubusercontent.com/u/5624255?v=3","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exercism/xhaskell","description":"Exercism Exercises in Haskell","fork":false,"url":"https://api.github.com/repos/exercism/xhaskell","forks_url":"https://api.github.com/repos/exercism/xhaskell/forks","keys_url":"https://api.github.com/repos/exercism/xhaskell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exercism/xhaskell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exercism/xhaskell/teams","hooks_url":"https://api.github.com/repos/exercism/xhaskell/hooks","issue_events_url":"https://api.github.com/repos/exercism/xhaskell/issues/events{/number}","events_url":"https://api.github.com/repos/exercism/xhaskell/events","assignees_url":"https://api.github.com/repos/exercism/xhaskell/assignees{/user}","branches_url":"https://api.github.com/repos/exercism/xhaskell/branches{/branch}","tags_url":"https://api.github.com/repos/exercism/xhaskell/tags","blobs_url":"https://api.github.com/repos/exercism/xhaskell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exercism/xhaskell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exercism/xhaskell/git/refs{/sha}","trees_url":"https://api.github.com/repos/exercism/xhaskell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exercism/xhaskell/statuses/{sha}","languages_url":"https://api.github.com/repos/exercism/xhaskell/languages","stargazers_url":"https://api.github.com/repos/exercism/xhaskell/stargazers","contributors_url":"https://api.github.com/repos/exercism/xhaskell/contributors","subscribers_url":"https://api.github.com/repos/exercism/xhaskell/subscribers","subscription_url":"https://api.github.com/repos/exercism/xhaskell/subscription","commits_url":"https://api.github.com/repos/exercism/xhaskell/commits{/sha}","git_commits_url":"https://api.github.com/repos/exercism/xhaskell/git/commits{/sha}","comments_url":"https://api.github.com/repos/exercism/xhaskell/comments{/number}","issue_comment_url":"https://api.github.com/repos/exercism/xhaskell/issues/comments{/number}","contents_url":"https://api.github.com/repos/exercism/xhaskell/contents/{+path}","compare_url":"https://api.github.com/repos/exercism/xhaskell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exercism/xhaskell/merges","archive_url":"https://api.github.com/repos/exercism/xhaskell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exercism/xhaskell/downloads","issues_url":"https://api.github.com/repos/exercism/xhaskell/issues{/number}","pulls_url":"https://api.github.com/repos/exercism/xhaskell/pulls{/number}","milestones_url":"https://api.github.com/repos/exercism/xhaskell/milestones{/number}","notifications_url":"https://api.github.com/repos/exercism/xhaskell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exercism/xhaskell/labels{/name}","releases_url":"https://api.github.com/repos/exercism/xhaskell/releases{/id}","deployments_url":"https://api.github.com/repos/exercism/xhaskell/deployments","created_at":"2014-02-28T02:59:12Z","updated_at":"2017-04-02T03:01:27Z","pushed_at":"2017-04-01T14:05:54Z","git_url":"git://github.com/exercism/xhaskell.git","ssh_url":"[email protected]:exercism/xhaskell.git","clone_url":"https://github.com/exercism/xhaskell.git","svn_url":"https://github.com/exercism/xhaskell","homepage":null,"size":871,"stargazers_count":83,"watchers_count":83,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":8,"forks":50,"open_issues":8,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exercism/xhaskell/pulls/511"},"html":{"href":"https://github.com/exercism/xhaskell/pull/511"},"issue":{"href":"https://api.github.com/repos/exercism/xhaskell/issues/511"},"comments":{"href":"https://api.github.com/repos/exercism/xhaskell/issues/511/comments"},"review_comments":{"href":"https://api.github.com/repos/exercism/xhaskell/pulls/511/comments"},"review_comment":{"href":"https://api.github.com/repos/exercism/xhaskell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exercism/xhaskell/pulls/511/commits"},"statuses":{"href":"https://api.github.com/repos/exercism/xhaskell/statuses/3cdeaea85df8d71673d3cf03f7381cf32793f970"}}}} | {
"id": 17273391,
"name": "exercism/xhaskell",
"url": "https://api.github.com/repos/exercism/xhaskell"
} | {
"id": 1479232,
"login": "lpalma",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1479232?",
"url": "https://api.github.com/users/lpalma"
} | {
"id": 5624255,
"login": "exercism",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5624255?",
"url": "https://api.github.com/orgs/exercism"
} | 2017-04-02T09:54:22 | 5610146813 | {"actor":{"display_login":"lpalma"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/exercism/xrust/pulls/comments/99273691","pull_request_review_id":19945661,"id":99273691,"diff_hunk":"@@ -0,0 +1,4 @@\n+[package]\n+name = \"rotational-cipher\"\n+version = \"0.0.0\"\n+authors = [\"Chad Baxter <[email protected]>\"]","path":"exercises/rotational-cipher/Cargo.toml","position":4,"original_position":4,"commit_id":"ca95371940b054ffccc22ff1ed4e4ef34053c209","original_commit_id":"ca95371940b054ffccc22ff1ed4e4ef34053c209","user":{"login":"petertseng","id":346181,"avatar_url":"https://avatars.githubusercontent.com/u/346181?v=3","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"body":"Since there is prior precedent, I don't object, though I won't speak for anyone else who may feel more strongly.\r\n\r\nI will note that you will probably want to put yourself as the source when adding the exercise to x-common, as there is a source and source_url in metadata - example at https://github.com/exercism/x-common/blob/master/exercises/paasio/metadata.yml#L3\r\n\r\nUnless you think that should be a wikipedia link","created_at":"2017-02-03T04:07:07Z","updated_at":"2017-02-03T04:07:07Z","html_url":"https://github.com/exercism/xrust/pull/257#discussion_r99273691","pull_request_url":"https://api.github.com/repos/exercism/xrust/pulls/257","_links":{"self":{"href":"https://api.github.com/repos/exercism/xrust/pulls/comments/99273691"},"html":{"href":"https://github.com/exercism/xrust/pull/257#discussion_r99273691"},"pull_request":{"href":"https://api.github.com/repos/exercism/xrust/pulls/257"}}},"pull_request":{"url":"https://api.github.com/repos/exercism/xrust/pulls/257","id":104451832,"html_url":"https://github.com/exercism/xrust/pull/257","diff_url":"https://github.com/exercism/xrust/pull/257.diff","patch_url":"https://github.com/exercism/xrust/pull/257.patch","issue_url":"https://api.github.com/repos/exercism/xrust/issues/257","number":257,"state":"open","locked":false,"title":"added rotational-cipher exercise","user":{"login":"LogoiLab","id":5545218,"avatar_url":"https://avatars.githubusercontent.com/u/5545218?v=3","gravatar_id":"","url":"https://api.github.com/users/LogoiLab","html_url":"https://github.com/LogoiLab","followers_url":"https://api.github.com/users/LogoiLab/followers","following_url":"https://api.github.com/users/LogoiLab/following{/other_user}","gists_url":"https://api.github.com/users/LogoiLab/gists{/gist_id}","starred_url":"https://api.github.com/users/LogoiLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LogoiLab/subscriptions","organizations_url":"https://api.github.com/users/LogoiLab/orgs","repos_url":"https://api.github.com/users/LogoiLab/repos","events_url":"https://api.github.com/users/LogoiLab/events{/privacy}","received_events_url":"https://api.github.com/users/LogoiLab/received_events","type":"User","site_admin":false},"body":"This cipher is the same as atbash except it is implemented in a way that allows for 26 possible keys. Some call this the Caesar cipher but the official cryptography term is rotational cipher. For more info see the readme in this pull request.\r\n\r\nThis exercise should come right after the atbash cipher in terms of ordering and difficulty.","created_at":"2017-02-03T00:10:29Z","updated_at":"2017-02-03T04:07:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f4e94aea530a9f25ba999ce0c1c02f59f7bea07","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/exercism/xrust/pulls/257/commits","review_comments_url":"https://api.github.com/repos/exercism/xrust/pulls/257/comments","review_comment_url":"https://api.github.com/repos/exercism/xrust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exercism/xrust/issues/257/comments","statuses_url":"https://api.github.com/repos/exercism/xrust/statuses/ca95371940b054ffccc22ff1ed4e4ef34053c209","head":{"label":"LogoiLab:master","ref":"master","sha":"ca95371940b054ffccc22ff1ed4e4ef34053c209","user":{"login":"LogoiLab","id":5545218,"avatar_url":"https://avatars.githubusercontent.com/u/5545218?v=3","gravatar_id":"","url":"https://api.github.com/users/LogoiLab","html_url":"https://github.com/LogoiLab","followers_url":"https://api.github.com/users/LogoiLab/followers","following_url":"https://api.github.com/users/LogoiLab/following{/other_user}","gists_url":"https://api.github.com/users/LogoiLab/gists{/gist_id}","starred_url":"https://api.github.com/users/LogoiLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LogoiLab/subscriptions","organizations_url":"https://api.github.com/users/LogoiLab/orgs","repos_url":"https://api.github.com/users/LogoiLab/repos","events_url":"https://api.github.com/users/LogoiLab/events{/privacy}","received_events_url":"https://api.github.com/users/LogoiLab/received_events","type":"User","site_admin":false},"repo":{"id":80761102,"name":"xrust","full_name":"LogoiLab/xrust","owner":{"login":"LogoiLab","id":5545218,"avatar_url":"https://avatars.githubusercontent.com/u/5545218?v=3","gravatar_id":"","url":"https://api.github.com/users/LogoiLab","html_url":"https://github.com/LogoiLab","followers_url":"https://api.github.com/users/LogoiLab/followers","following_url":"https://api.github.com/users/LogoiLab/following{/other_user}","gists_url":"https://api.github.com/users/LogoiLab/gists{/gist_id}","starred_url":"https://api.github.com/users/LogoiLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LogoiLab/subscriptions","organizations_url":"https://api.github.com/users/LogoiLab/orgs","repos_url":"https://api.github.com/users/LogoiLab/repos","events_url":"https://api.github.com/users/LogoiLab/events{/privacy}","received_events_url":"https://api.github.com/users/LogoiLab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LogoiLab/xrust","description":"Exercism Exercises in Rust","fork":true,"url":"https://api.github.com/repos/LogoiLab/xrust","forks_url":"https://api.github.com/repos/LogoiLab/xrust/forks","keys_url":"https://api.github.com/repos/LogoiLab/xrust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LogoiLab/xrust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LogoiLab/xrust/teams","hooks_url":"https://api.github.com/repos/LogoiLab/xrust/hooks","issue_events_url":"https://api.github.com/repos/LogoiLab/xrust/issues/events{/number}","events_url":"https://api.github.com/repos/LogoiLab/xrust/events","assignees_url":"https://api.github.com/repos/LogoiLab/xrust/assignees{/user}","branches_url":"https://api.github.com/repos/LogoiLab/xrust/branches{/branch}","tags_url":"https://api.github.com/repos/LogoiLab/xrust/tags","blobs_url":"https://api.github.com/repos/LogoiLab/xrust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LogoiLab/xrust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LogoiLab/xrust/git/refs{/sha}","trees_url":"https://api.github.com/repos/LogoiLab/xrust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LogoiLab/xrust/statuses/{sha}","languages_url":"https://api.github.com/repos/LogoiLab/xrust/languages","stargazers_url":"https://api.github.com/repos/LogoiLab/xrust/stargazers","contributors_url":"https://api.github.com/repos/LogoiLab/xrust/contributors","subscribers_url":"https://api.github.com/repos/LogoiLab/xrust/subscribers","subscription_url":"https://api.github.com/repos/LogoiLab/xrust/subscription","commits_url":"https://api.github.com/repos/LogoiLab/xrust/commits{/sha}","git_commits_url":"https://api.github.com/repos/LogoiLab/xrust/git/commits{/sha}","comments_url":"https://api.github.com/repos/LogoiLab/xrust/comments{/number}","issue_comment_url":"https://api.github.com/repos/LogoiLab/xrust/issues/comments{/number}","contents_url":"https://api.github.com/repos/LogoiLab/xrust/contents/{+path}","compare_url":"https://api.github.com/repos/LogoiLab/xrust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LogoiLab/xrust/merges","archive_url":"https://api.github.com/repos/LogoiLab/xrust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LogoiLab/xrust/downloads","issues_url":"https://api.github.com/repos/LogoiLab/xrust/issues{/number}","pulls_url":"https://api.github.com/repos/LogoiLab/xrust/pulls{/number}","milestones_url":"https://api.github.com/repos/LogoiLab/xrust/milestones{/number}","notifications_url":"https://api.github.com/repos/LogoiLab/xrust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LogoiLab/xrust/labels{/name}","releases_url":"https://api.github.com/repos/LogoiLab/xrust/releases{/id}","deployments_url":"https://api.github.com/repos/LogoiLab/xrust/deployments","created_at":"2017-02-02T19:34:11Z","updated_at":"2017-02-02T19:34:12Z","pushed_at":"2017-02-03T00:06:54Z","git_url":"git://github.com/LogoiLab/xrust.git","ssh_url":"[email protected]:LogoiLab/xrust.git","clone_url":"https://github.com/LogoiLab/xrust.git","svn_url":"https://github.com/LogoiLab/xrust","homepage":null,"size":384,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exercism:master","ref":"master","sha":"6bfaeeb03256777702ddeaecbd1711051cef78eb","user":{"login":"exercism","id":5624255,"avatar_url":"https://avatars.githubusercontent.com/u/5624255?v=3","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"repo":{"id":17276332,"name":"xrust","full_name":"exercism/xrust","owner":{"login":"exercism","id":5624255,"avatar_url":"https://avatars.githubusercontent.com/u/5624255?v=3","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exercism/xrust","description":"Exercism Exercises in Rust","fork":false,"url":"https://api.github.com/repos/exercism/xrust","forks_url":"https://api.github.com/repos/exercism/xrust/forks","keys_url":"https://api.github.com/repos/exercism/xrust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exercism/xrust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exercism/xrust/teams","hooks_url":"https://api.github.com/repos/exercism/xrust/hooks","issue_events_url":"https://api.github.com/repos/exercism/xrust/issues/events{/number}","events_url":"https://api.github.com/repos/exercism/xrust/events","assignees_url":"https://api.github.com/repos/exercism/xrust/assignees{/user}","branches_url":"https://api.github.com/repos/exercism/xrust/branches{/branch}","tags_url":"https://api.github.com/repos/exercism/xrust/tags","blobs_url":"https://api.github.com/repos/exercism/xrust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exercism/xrust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exercism/xrust/git/refs{/sha}","trees_url":"https://api.github.com/repos/exercism/xrust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exercism/xrust/statuses/{sha}","languages_url":"https://api.github.com/repos/exercism/xrust/languages","stargazers_url":"https://api.github.com/repos/exercism/xrust/stargazers","contributors_url":"https://api.github.com/repos/exercism/xrust/contributors","subscribers_url":"https://api.github.com/repos/exercism/xrust/subscribers","subscription_url":"https://api.github.com/repos/exercism/xrust/subscription","commits_url":"https://api.github.com/repos/exercism/xrust/commits{/sha}","git_commits_url":"https://api.github.com/repos/exercism/xrust/git/commits{/sha}","comments_url":"https://api.github.com/repos/exercism/xrust/comments{/number}","issue_comment_url":"https://api.github.com/repos/exercism/xrust/issues/comments{/number}","contents_url":"https://api.github.com/repos/exercism/xrust/contents/{+path}","compare_url":"https://api.github.com/repos/exercism/xrust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exercism/xrust/merges","archive_url":"https://api.github.com/repos/exercism/xrust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exercism/xrust/downloads","issues_url":"https://api.github.com/repos/exercism/xrust/issues{/number}","pulls_url":"https://api.github.com/repos/exercism/xrust/pulls{/number}","milestones_url":"https://api.github.com/repos/exercism/xrust/milestones{/number}","notifications_url":"https://api.github.com/repos/exercism/xrust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exercism/xrust/labels{/name}","releases_url":"https://api.github.com/repos/exercism/xrust/releases{/id}","deployments_url":"https://api.github.com/repos/exercism/xrust/deployments","created_at":"2014-02-28T05:33:52Z","updated_at":"2017-01-29T07:01:30Z","pushed_at":"2017-02-03T04:04:18Z","git_url":"git://github.com/exercism/xrust.git","ssh_url":"[email protected]:exercism/xrust.git","clone_url":"https://github.com/exercism/xrust.git","svn_url":"https://github.com/exercism/xrust","homepage":null,"size":383,"stargazers_count":103,"watchers_count":103,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":9,"forks":62,"open_issues":9,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exercism/xrust/pulls/257"},"html":{"href":"https://github.com/exercism/xrust/pull/257"},"issue":{"href":"https://api.github.com/repos/exercism/xrust/issues/257"},"comments":{"href":"https://api.github.com/repos/exercism/xrust/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/exercism/xrust/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/exercism/xrust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exercism/xrust/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/exercism/xrust/statuses/ca95371940b054ffccc22ff1ed4e4ef34053c209"}}}} | {
"id": 17276332,
"name": "exercism/xrust",
"url": "https://api.github.com/repos/exercism/xrust"
} | {
"id": 346181,
"login": "petertseng",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/346181?",
"url": "https://api.github.com/users/petertseng"
} | {
"id": 5624255,
"login": "exercism",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5624255?",
"url": "https://api.github.com/orgs/exercism"
} | 2017-02-03T04:07:07 | 5259465331 | {"actor":{"display_login":"petertseng"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/152840139","pull_request_review_id":78764264,"id":152840139,"diff_hunk":"@@ -419,16 +420,21 @@ class FlatList<ItemT> extends React.PureComponent<Props<ItemT>, void> {\n 'changing the number of columns to force a fresh render of the component.',\n );\n invariant(\n- nextProps.onViewableItemsChanged === this.props.onViewableItemsChanged,\n+ areEqual(\n+ nextProps.onViewableItemsChanged, \n+ this.props.onViewableItemsChanged\n+ ),\n 'Changing onViewableItemsChanged on the fly is not supported',\n );\n invariant(\n- nextProps.viewabilityConfig === this.props.viewabilityConfig,\n+ areEqual(nextProps.viewabilityConfig, this.props.viewabilityConfig),\n 'Changing viewabilityConfig on the fly is not supported',\n );\n invariant(\n- nextProps.viewabilityConfigCallbackPairs ===\n- this.props.viewabilityConfigCallbackPairs,\n+ areEqual(\n+ nextProps.viewabilityConfigCallbackPairs, ","path":"Libraries/Lists/FlatList.js","position":null,"original_position":28,"commit_id":"db06d53cc430b954999b4b65343341afb761a8ea","original_commit_id":"9a2badaac275cd47d34afa35128aff3d65c50a45","user":{"login":"eballeste","id":6924108,"avatar_url":"https://avatars3.githubusercontent.com/u/6924108?v=4","gravatar_id":"","url":"https://api.github.com/users/eballeste","html_url":"https://github.com/eballeste","followers_url":"https://api.github.com/users/eballeste/followers","following_url":"https://api.github.com/users/eballeste/following{/other_user}","gists_url":"https://api.github.com/users/eballeste/gists{/gist_id}","starred_url":"https://api.github.com/users/eballeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eballeste/subscriptions","organizations_url":"https://api.github.com/users/eballeste/orgs","repos_url":"https://api.github.com/users/eballeste/repos","events_url":"https://api.github.com/users/eballeste/events{/privacy}","received_events_url":"https://api.github.com/users/eballeste/received_events","type":"User","site_admin":false},"body":"???","created_at":"2017-11-23T16:26:41Z","updated_at":"2017-11-23T16:27:05Z","html_url":"https://github.com/facebook/react-native/pull/16776#discussion_r152840139","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/16776","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/152840139"},"html":{"href":"https://github.com/facebook/react-native/pull/16776#discussion_r152840139"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/16776"}},"in_reply_to_id":152838228},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/16776","id":151724338,"html_url":"https://github.com/facebook/react-native/pull/16776","diff_url":"https://github.com/facebook/react-native/pull/16776.diff","patch_url":"https://github.com/facebook/react-native/pull/16776.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/16776","number":16776,"state":"open","locked":false,"title":"[Bugfix][FlatList] Objects as props trigger invariant errors","user":{"login":"eballeste","id":6924108,"avatar_url":"https://avatars3.githubusercontent.com/u/6924108?v=4","gravatar_id":"","url":"https://api.github.com/users/eballeste","html_url":"https://github.com/eballeste","followers_url":"https://api.github.com/users/eballeste/followers","following_url":"https://api.github.com/users/eballeste/following{/other_user}","gists_url":"https://api.github.com/users/eballeste/gists{/gist_id}","starred_url":"https://api.github.com/users/eballeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eballeste/subscriptions","organizations_url":"https://api.github.com/users/eballeste/orgs","repos_url":"https://api.github.com/users/eballeste/repos","events_url":"https://api.github.com/users/eballeste/events{/privacy}","received_events_url":"https://api.github.com/users/eballeste/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for sending the PR! We appreciate you spending the time to work on these changes. \r\n\r\nHelp us understand your motivation by explaining why you decided to make this change.\r\n\r\nYou can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html\r\n\r\nHappy contributing!\r\n\r\n-->\r\n\r\n## Motivation\r\n\r\nFixes invariant errors introduced in https://github.com/facebook/react-native/commit/ad733ad430a4b1d69b89041be8b227e2dfdb5501 triggered when using objects for certain FlatList props, leverages fbjs `areEqual` to test for equality.\r\n\r\n**Original Issue**:\r\nhttps://github.com/facebook/react-native/issues/16710\r\n\r\n## Test Plan\r\nSetting a value to `viewAreaCoveragePercentThreshold` key of `viewabilityConfig` prop should no longer trigger invariant error. \r\n\r\n <FlatList\r\n ItemSeparatorComponent={() => <separator />}\r\n ListEmptyComponent={() => <empty />}\r\n ListFooterComponent={() => <footer />}\r\n ListHeaderComponent={() => <header />}\r\n data={new Array(5).fill().map((_, ii) => ({id: String(ii)}))}\r\n keyExtractor={(item, index) => item.id}\r\n getItemLayout={({index}) => ({length: 50, offset: index * 50})}\r\n numColumns={2}\r\n refreshing={false}\r\n onRefresh={jest.fn()}\r\n renderItem={({item}) => <item value={item.id} />}\r\n viewabilityConfig={{ viewAreaCoveragePercentThreshold: 50 }}\r\n />,\r\n\r\n## Release Notes\r\n<!--\r\nHelp reviewers and the release process by writing your own release notes\r\n\r\n**INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**\r\n\r\n CATEGORY\r\n[----------] TYPE\r\n[ CLI ] [-------------] LOCATION\r\n[ DOCS ] [ BREAKING ] [-------------]\r\n[ GENERAL ] [ BUGFIX ] [-{Component}-]\r\n[ INTERNAL ] [ ENHANCEMENT ] [ {File} ]\r\n[ IOS ] [ FEATURE ] [ {Directory} ] |-----------|\r\n[ ANDROID ] [ MINOR ] [ {Framework} ] - | {Message} |\r\n[----------] [-------------] [-------------] |-----------|\r\n\r\n[CATEGORY] [TYPE] [LOCATION] - MESSAGE\r\n\r\n EXAMPLES:\r\n\r\n [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things\r\n [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput\r\n [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with\r\n [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word\r\n [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position\r\n [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see\r\n-->\r\n","created_at":"2017-11-09T18:12:06Z","updated_at":"2017-11-23T16:27:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f4e1f5101aa85d52c4fd53b8bdaac3f9e732ae8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/16776/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/16776/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/16776/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/db06d53cc430b954999b4b65343341afb761a8ea","head":{"label":"eballeste:fix_flatlist_props_bugs","ref":"fix_flatlist_props_bugs","sha":"db06d53cc430b954999b4b65343341afb761a8ea","user":{"login":"eballeste","id":6924108,"avatar_url":"https://avatars3.githubusercontent.com/u/6924108?v=4","gravatar_id":"","url":"https://api.github.com/users/eballeste","html_url":"https://github.com/eballeste","followers_url":"https://api.github.com/users/eballeste/followers","following_url":"https://api.github.com/users/eballeste/following{/other_user}","gists_url":"https://api.github.com/users/eballeste/gists{/gist_id}","starred_url":"https://api.github.com/users/eballeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eballeste/subscriptions","organizations_url":"https://api.github.com/users/eballeste/orgs","repos_url":"https://api.github.com/users/eballeste/repos","events_url":"https://api.github.com/users/eballeste/events{/privacy}","received_events_url":"https://api.github.com/users/eballeste/received_events","type":"User","site_admin":false},"repo":{"id":110052732,"name":"react-native","full_name":"eballeste/react-native","owner":{"login":"eballeste","id":6924108,"avatar_url":"https://avatars3.githubusercontent.com/u/6924108?v=4","gravatar_id":"","url":"https://api.github.com/users/eballeste","html_url":"https://github.com/eballeste","followers_url":"https://api.github.com/users/eballeste/followers","following_url":"https://api.github.com/users/eballeste/following{/other_user}","gists_url":"https://api.github.com/users/eballeste/gists{/gist_id}","starred_url":"https://api.github.com/users/eballeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eballeste/subscriptions","organizations_url":"https://api.github.com/users/eballeste/orgs","repos_url":"https://api.github.com/users/eballeste/repos","events_url":"https://api.github.com/users/eballeste/events{/privacy}","received_events_url":"https://api.github.com/users/eballeste/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eballeste/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/eballeste/react-native","forks_url":"https://api.github.com/repos/eballeste/react-native/forks","keys_url":"https://api.github.com/repos/eballeste/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eballeste/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eballeste/react-native/teams","hooks_url":"https://api.github.com/repos/eballeste/react-native/hooks","issue_events_url":"https://api.github.com/repos/eballeste/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/eballeste/react-native/events","assignees_url":"https://api.github.com/repos/eballeste/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/eballeste/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/eballeste/react-native/tags","blobs_url":"https://api.github.com/repos/eballeste/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eballeste/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eballeste/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/eballeste/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eballeste/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/eballeste/react-native/languages","stargazers_url":"https://api.github.com/repos/eballeste/react-native/stargazers","contributors_url":"https://api.github.com/repos/eballeste/react-native/contributors","subscribers_url":"https://api.github.com/repos/eballeste/react-native/subscribers","subscription_url":"https://api.github.com/repos/eballeste/react-native/subscription","commits_url":"https://api.github.com/repos/eballeste/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/eballeste/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/eballeste/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/eballeste/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/eballeste/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/eballeste/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eballeste/react-native/merges","archive_url":"https://api.github.com/repos/eballeste/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eballeste/react-native/downloads","issues_url":"https://api.github.com/repos/eballeste/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/eballeste/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/eballeste/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/eballeste/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eballeste/react-native/labels{/name}","releases_url":"https://api.github.com/repos/eballeste/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/eballeste/react-native/deployments","created_at":"2017-11-09T01:45:15Z","updated_at":"2017-11-09T01:45:38Z","pushed_at":"2017-11-23T16:22:56Z","git_url":"git://github.com/eballeste/react-native.git","ssh_url":"[email protected]:eballeste/react-native.git","clone_url":"https://github.com/eballeste/react-native.git","svn_url":"https://github.com/eballeste/react-native","homepage":"http://facebook.github.io/react-native/","size":147861,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"260e6d23554a8e7f1743263894c9ca9a0cfbf01e","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2017-11-23T16:13:55Z","pushed_at":"2017-11-23T16:22:58Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"[email protected]:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":148829,"stargazers_count":56262,"watchers_count":56262,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13078,"mirror_url":null,"archived":false,"open_issues_count":727,"forks":13078,"open_issues":727,"watchers":56262,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/16776"},"html":{"href":"https://github.com/facebook/react-native/pull/16776"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/16776"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/16776/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/16776/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/16776/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/db06d53cc430b954999b4b65343341afb761a8ea"}},"author_association":"NONE"}} | {
"id": 29028775,
"name": "facebook/react-native",
"url": "https://api.github.com/repos/facebook/react-native"
} | {
"id": 6924108,
"login": "eballeste",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6924108?",
"url": "https://api.github.com/users/eballeste"
} | {
"id": 69631,
"login": "facebook",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/69631?",
"url": "https://api.github.com/orgs/facebook"
} | 2017-11-23T16:26:41 | 6896147642 | {"actor":{"display_login":"eballeste"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/facebook/jest/pulls/comments/142187675","pull_request_review_id":66512573,"id":142187675,"diff_hunk":"@@ -0,0 +1,182 @@\n+/**\n+ * Copyright (c) 2017-present, Facebook, Inc.\n+ * All rights reserved.\n+ *\n+ * This source code is licensed under the BSD-style license found in the\n+ * LICENSE file in the root directory of this source tree. An additional grant\n+ * of patent rights can be found in the PATENTS file in the same directory.\n+ */\n+\n+'use strict';\n+\n+const mergeStream = require('merge-stream');\n+const path = require('path');\n+\n+const JestWorker = require('./worker');\n+\n+import type {JestApi, JestFarmOptions} from './types';\n+import type {Readable} from 'stream';\n+\n+/**\n+ * The Jest farm is a class that allows you to queue methods across multiple\n+ * child processes, in order to parallelize work. This is done by providing an\n+ * absolute path to a module that will be loaded on each of the child\n+ * processes, and bridged to the main process.\n+ *\n+ * Bridged methods are specified by using the \"exposedMethods\" property of the\n+ * options \"object\". This is an array of strings, where each of them corresponds\n+ * to the exported name in the loaded module.\n+ *\n+ * You can also control the amount of workers by using the \"workers\" property of\n+ * the \"options\" object, and the settings passed to fork the process through\n+ * the \"forkOptions\" property.\n+ *\n+ * Queueing calls can be done in two ways:\n+ * - Standard method: calls will be redirected to the first available worker,\n+ * so they will get executed as soon as they can.\n+ *\n+ * - Sticky method: if a \"getWorkerKey\" method is provided within the config,\n+ * the resulting string of this method will be used as a key. Everytime this\n+ * key is returned, it is guaranteed that your job will be processed by the\n+ * same worker. This is specially useful if your workers are caching\n+ * results.\n+ */\n+class JestFarm {\n+ _aggregagedStdout: Readable;\n+ _aggregagedStderr: Readable;\n+ _api: JestApi;\n+ _ending: boolean;\n+ _hashes: {[string]: JestWorker};\n+ _options: JestFarmOptions;\n+ _workers: Array<JestWorker>;\n+\n+ constructor(options: JestFarmOptions) {\n+ const api = this._makeCall.bind(this, '');\n+ const aggregatedStdout = mergeStream();\n+ const aggregatedStderr = mergeStream();\n+ const workers = [];\n+\n+ if (!path.isAbsolute(options.workerPath)) {","path":"packages/jest-parallel/src/index.js","position":59,"original_position":59,"commit_id":"1319e67c79537c9f421c77462564754d62501866","original_commit_id":"1319e67c79537c9f421c77462564754d62501866","user":{"login":"cpojer","id":13352,"avatar_url":"https://avatars0.githubusercontent.com/u/13352?v=4","gravatar_id":"","url":"https://api.github.com/users/cpojer","html_url":"https://github.com/cpojer","followers_url":"https://api.github.com/users/cpojer/followers","following_url":"https://api.github.com/users/cpojer/following{/other_user}","gists_url":"https://api.github.com/users/cpojer/gists{/gist_id}","starred_url":"https://api.github.com/users/cpojer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpojer/subscriptions","organizations_url":"https://api.github.com/users/cpojer/orgs","repos_url":"https://api.github.com/users/cpojer/repos","events_url":"https://api.github.com/users/cpojer/events{/privacy}","received_events_url":"https://api.github.com/users/cpojer/received_events","type":"User","site_admin":false},"body":"Nah, I think that's going too far. It should either be a pre-resolved module or a node_module.","created_at":"2017-10-02T16:25:54Z","updated_at":"2017-10-02T16:25:54Z","html_url":"https://github.com/facebook/jest/pull/4497#discussion_r142187675","pull_request_url":"https://api.github.com/repos/facebook/jest/pulls/4497","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/facebook/jest/pulls/comments/142187675"},"html":{"href":"https://github.com/facebook/jest/pull/4497#discussion_r142187675"},"pull_request":{"href":"https://api.github.com/repos/facebook/jest/pulls/4497"}},"in_reply_to_id":140887216},"pull_request":{"url":"https://api.github.com/repos/facebook/jest/pulls/4497","id":141492637,"html_url":"https://github.com/facebook/jest/pull/4497","diff_url":"https://github.com/facebook/jest/pull/4497.diff","patch_url":"https://github.com/facebook/jest/pull/4497.patch","issue_url":"https://api.github.com/repos/facebook/jest/issues/4497","number":4497,"state":"open","locked":false,"title":"Initial version of jest-parallel","user":{"login":"mjesun","id":829269,"avatar_url":"https://avatars3.githubusercontent.com/u/829269?v=4","gravatar_id":"","url":"https://api.github.com/users/mjesun","html_url":"https://github.com/mjesun","followers_url":"https://api.github.com/users/mjesun/followers","following_url":"https://api.github.com/users/mjesun/following{/other_user}","gists_url":"https://api.github.com/users/mjesun/gists{/gist_id}","starred_url":"https://api.github.com/users/mjesun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjesun/subscriptions","organizations_url":"https://api.github.com/users/mjesun/orgs","repos_url":"https://api.github.com/users/mjesun/repos","events_url":"https://api.github.com/users/mjesun/events{/privacy}","received_events_url":"https://api.github.com/users/mjesun/received_events","type":"User","site_admin":false},"body":"This PR introduces a new module, `jest-parallel`, intended to allow heavy task parallelization over multiple workers. \r\n\r\nThe module has a few advantages over the currently one used both in `jest` and `metro-bundler`:\r\n\r\n* 100% `flow`-ified.\r\n\r\n* 100% test coverage on it, all statements, methods and branches.\r\n\r\n* Slightly faster than the currenly used one.\r\n\r\n* Natively provides a `Promise` based interface, which allow us to avoid the extra wrapping layer in order to be used with `async`/`await.\r\n\r\n* It only has one single dependency (`merge-stream`), which we could also remove.\r\n\r\n* Lazily instantiated code in worker, meaning no code is loaded on child processes until the first call is done (lazy require). This allows to spawn a farm with minimal RAM consumption, and only load them when needed.\r\n\r\n* Sticky workers: tasks will be processed by the first available worker if no stickyness is needed, or by a particular one if the task is forced to do so. Specially useful for workers implementing caches.\r\n\r\n\r\n## Performance test\r\n\r\nIt can be run by doing `node --expose-gc test.js` under `__performance_tests__`. Note that the percentage improvement shown (~ 5%) applies to 10,000 calls, meaning the performance improvement per single call is negligible. The test implements a `Promise` wrapper over the current implementation, so we can equivalently test both implementations as we use them in real scenarios.\r\n\r\n```\r\n---------------------------------------------------------------------------\r\njest-parallel: { globalTime: 735, processingTime: 713 }\r\nworker-farm: { globalTime: 777, processingTime: 757 }\r\n---------------------------------------------------------------------------\r\njest-parallel: { globalTime: 753, processingTime: 734 }\r\nworker-farm: { globalTime: 854, processingTime: 838 }\r\n---------------------------------------------------------------------------\r\njest-parallel: { globalTime: 752, processingTime: 732 }\r\nworker-farm: { globalTime: 771, processingTime: 753 }\r\n---------------------------------------------------------------------------\r\njest-parallel: { globalTime: 733, processingTime: 709 }\r\nworker-farm: { globalTime: 815, processingTime: 798 }\r\n---------------------------------------------------------------------------\r\njest-parallel: { globalTime: 766, processingTime: 747 }\r\nworker-farm: { globalTime: 750, processingTime: 731 }\r\n---------------------------------------------------------------------------\r\njest-parallel: { globalTime: 740, processingTime: 721 }\r\nworker-farm: { globalTime: 782, processingTime: 764 }\r\n---------------------------------------------------------------------------\r\njest-parallel: { globalTime: 733, processingTime: 708 }\r\nworker-farm: { globalTime: 766, processingTime: 753 }\r\n---------------------------------------------------------------------------\r\njest-parallel: { globalTime: 752, processingTime: 731 }\r\nworker-farm: { globalTime: 770, processingTime: 751 }\r\n---------------------------------------------------------------------------\r\njest-parallel: { globalTime: 743, processingTime: 721 }\r\nworker-farm: { globalTime: 790, processingTime: 772 }\r\n---------------------------------------------------------------------------\r\njest-parallel: { globalTime: 745, processingTime: 726 }\r\nworker-farm: { globalTime: 769, processingTime: 752 }\r\n---------------------------------------------------------------------------\r\ntotal worker-farm: { wFGT: 7844, wFPT: 7669 }\r\ntotal jest-parallel: { jPGT: 7452, jPPT: 7242 }\r\n---------------------------------------------------------------------------\r\n% improvement over 10000 calls (global time): 4.997450280469148\r\n% improvement over 10000 calls (processing time): 5.567870648063633\r\n```\r\n\r\n\r\n## Coverage\r\n\r\n","created_at":"2017-09-17T16:26:27Z","updated_at":"2017-10-02T16:25:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"704b12702a792dbd647a00a8121700bbd0ba2f1a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/jest/pulls/4497/commits","review_comments_url":"https://api.github.com/repos/facebook/jest/pulls/4497/comments","review_comment_url":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/jest/issues/4497/comments","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/1319e67c79537c9f421c77462564754d62501866","head":{"label":"mjesun:jest-parallel","ref":"jest-parallel","sha":"1319e67c79537c9f421c77462564754d62501866","user":{"login":"mjesun","id":829269,"avatar_url":"https://avatars3.githubusercontent.com/u/829269?v=4","gravatar_id":"","url":"https://api.github.com/users/mjesun","html_url":"https://github.com/mjesun","followers_url":"https://api.github.com/users/mjesun/followers","following_url":"https://api.github.com/users/mjesun/following{/other_user}","gists_url":"https://api.github.com/users/mjesun/gists{/gist_id}","starred_url":"https://api.github.com/users/mjesun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjesun/subscriptions","organizations_url":"https://api.github.com/users/mjesun/orgs","repos_url":"https://api.github.com/users/mjesun/repos","events_url":"https://api.github.com/users/mjesun/events{/privacy}","received_events_url":"https://api.github.com/users/mjesun/received_events","type":"User","site_admin":false},"repo":{"id":94242212,"name":"jest","full_name":"mjesun/jest","owner":{"login":"mjesun","id":829269,"avatar_url":"https://avatars3.githubusercontent.com/u/829269?v=4","gravatar_id":"","url":"https://api.github.com/users/mjesun","html_url":"https://github.com/mjesun","followers_url":"https://api.github.com/users/mjesun/followers","following_url":"https://api.github.com/users/mjesun/following{/other_user}","gists_url":"https://api.github.com/users/mjesun/gists{/gist_id}","starred_url":"https://api.github.com/users/mjesun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjesun/subscriptions","organizations_url":"https://api.github.com/users/mjesun/orgs","repos_url":"https://api.github.com/users/mjesun/repos","events_url":"https://api.github.com/users/mjesun/events{/privacy}","received_events_url":"https://api.github.com/users/mjesun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjesun/jest","description":"🃏 Delightful JavaScript Testing.","fork":true,"url":"https://api.github.com/repos/mjesun/jest","forks_url":"https://api.github.com/repos/mjesun/jest/forks","keys_url":"https://api.github.com/repos/mjesun/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjesun/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjesun/jest/teams","hooks_url":"https://api.github.com/repos/mjesun/jest/hooks","issue_events_url":"https://api.github.com/repos/mjesun/jest/issues/events{/number}","events_url":"https://api.github.com/repos/mjesun/jest/events","assignees_url":"https://api.github.com/repos/mjesun/jest/assignees{/user}","branches_url":"https://api.github.com/repos/mjesun/jest/branches{/branch}","tags_url":"https://api.github.com/repos/mjesun/jest/tags","blobs_url":"https://api.github.com/repos/mjesun/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjesun/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjesun/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjesun/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjesun/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/mjesun/jest/languages","stargazers_url":"https://api.github.com/repos/mjesun/jest/stargazers","contributors_url":"https://api.github.com/repos/mjesun/jest/contributors","subscribers_url":"https://api.github.com/repos/mjesun/jest/subscribers","subscription_url":"https://api.github.com/repos/mjesun/jest/subscription","commits_url":"https://api.github.com/repos/mjesun/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjesun/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjesun/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjesun/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjesun/jest/contents/{+path}","compare_url":"https://api.github.com/repos/mjesun/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjesun/jest/merges","archive_url":"https://api.github.com/repos/mjesun/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjesun/jest/downloads","issues_url":"https://api.github.com/repos/mjesun/jest/issues{/number}","pulls_url":"https://api.github.com/repos/mjesun/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/mjesun/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/mjesun/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjesun/jest/labels{/name}","releases_url":"https://api.github.com/repos/mjesun/jest/releases{/id}","deployments_url":"https://api.github.com/repos/mjesun/jest/deployments","created_at":"2017-06-13T18:00:17Z","updated_at":"2017-06-13T18:00:22Z","pushed_at":"2017-09-22T17:35:17Z","git_url":"git://github.com/mjesun/jest.git","ssh_url":"[email protected]:mjesun/jest.git","clone_url":"https://github.com/mjesun/jest.git","svn_url":"https://github.com/mjesun/jest","homepage":"http://facebook.github.io/jest/","size":19489,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"f92c3be685c529e7885e546e2b90bf0f8374e171","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":15062869,"name":"jest","full_name":"facebook/jest","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/jest","description":"🃏 Delightful JavaScript Testing.","fork":false,"url":"https://api.github.com/repos/facebook/jest","forks_url":"https://api.github.com/repos/facebook/jest/forks","keys_url":"https://api.github.com/repos/facebook/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/jest/teams","hooks_url":"https://api.github.com/repos/facebook/jest/hooks","issue_events_url":"https://api.github.com/repos/facebook/jest/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/jest/events","assignees_url":"https://api.github.com/repos/facebook/jest/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/jest/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/jest/tags","blobs_url":"https://api.github.com/repos/facebook/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/jest/languages","stargazers_url":"https://api.github.com/repos/facebook/jest/stargazers","contributors_url":"https://api.github.com/repos/facebook/jest/contributors","subscribers_url":"https://api.github.com/repos/facebook/jest/subscribers","subscription_url":"https://api.github.com/repos/facebook/jest/subscription","commits_url":"https://api.github.com/repos/facebook/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/jest/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/jest/merges","archive_url":"https://api.github.com/repos/facebook/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/jest/downloads","issues_url":"https://api.github.com/repos/facebook/jest/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/jest/labels{/name}","releases_url":"https://api.github.com/repos/facebook/jest/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/jest/deployments","created_at":"2013-12-10T00:18:04Z","updated_at":"2017-10-02T12:48:19Z","pushed_at":"2017-10-02T08:12:06Z","git_url":"git://github.com/facebook/jest.git","ssh_url":"[email protected]:facebook/jest.git","clone_url":"https://github.com/facebook/jest.git","svn_url":"https://github.com/facebook/jest","homepage":"http://facebook.github.io/jest/","size":22197,"stargazers_count":12422,"watchers_count":12422,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1583,"mirror_url":null,"open_issues_count":209,"forks":1583,"open_issues":209,"watchers":12422,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/jest/pulls/4497"},"html":{"href":"https://github.com/facebook/jest/pull/4497"},"issue":{"href":"https://api.github.com/repos/facebook/jest/issues/4497"},"comments":{"href":"https://api.github.com/repos/facebook/jest/issues/4497/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/jest/pulls/4497/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/jest/pulls/4497/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/jest/statuses/1319e67c79537c9f421c77462564754d62501866"}},"author_association":"CONTRIBUTOR"}} | {
"id": 15062869,
"name": "facebook/jest",
"url": "https://api.github.com/repos/facebook/jest"
} | {
"id": 13352,
"login": "cpojer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13352?",
"url": "https://api.github.com/users/cpojer"
} | {
"id": 69631,
"login": "facebook",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/69631?",
"url": "https://api.github.com/orgs/facebook"
} | 2017-10-02T16:25:54 | 6663449283 | {"actor":{"display_login":"cpojer"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/112349318","pull_request_review_id":33657325,"id":112349318,"diff_hunk":"@@ -618,14 +620,24 @@ Cache::Handle* ClockCacheShard::Lookup(const Slice& key, uint32_t hash) {\n return reinterpret_cast<Cache::Handle*>(handle);\n }\n \n-void ClockCacheShard::Release(Cache::Handle* h) {\n+bool ClockCacheShard::Release(Cache::Handle* h, bool force_erase) {\n CleanupContext context;\n CacheHandle* handle = reinterpret_cast<CacheHandle*>(h);\n Unref(handle, true, &context);\n Cleanup(context);\n+ auto erased = context.to_delete_value.size() > 0;\n+ if (!force_erase || erased) {\n+ return erased;\n+ } else {\n+ return EraseAndConfirm(handle->key, handle->hash);","path":"cache/clock_cache.cc","position":26,"original_position":26,"commit_id":"4d518290953a76d6464b0e10b7829c1e20695164","original_commit_id":"4d518290953a76d6464b0e10b7829c1e20695164","user":{"login":"yiwu-arbug","id":2606959,"avatar_url":"https://avatars0.githubusercontent.com/u/2606959?v=3","gravatar_id":"","url":"https://api.github.com/users/yiwu-arbug","html_url":"https://github.com/yiwu-arbug","followers_url":"https://api.github.com/users/yiwu-arbug/followers","following_url":"https://api.github.com/users/yiwu-arbug/following{/other_user}","gists_url":"https://api.github.com/users/yiwu-arbug/gists{/gist_id}","starred_url":"https://api.github.com/users/yiwu-arbug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiwu-arbug/subscriptions","organizations_url":"https://api.github.com/users/yiwu-arbug/orgs","repos_url":"https://api.github.com/users/yiwu-arbug/repos","events_url":"https://api.github.com/users/yiwu-arbug/events{/privacy}","received_events_url":"https://api.github.com/users/yiwu-arbug/received_events","type":"User","site_admin":false},"body":"Pass context to EraseAndConfirm()?","created_at":"2017-04-20T01:32:54Z","updated_at":"2017-04-20T01:40:57Z","html_url":"https://github.com/facebook/rocksdb/pull/2180#discussion_r112349318","pull_request_url":"https://api.github.com/repos/facebook/rocksdb/pulls/2180","_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/112349318"},"html":{"href":"https://github.com/facebook/rocksdb/pull/2180#discussion_r112349318"},"pull_request":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/2180"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/2180","id":116624983,"html_url":"https://github.com/facebook/rocksdb/pull/2180","diff_url":"https://github.com/facebook/rocksdb/pull/2180.diff","patch_url":"https://github.com/facebook/rocksdb/pull/2180.patch","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/2180","number":2180,"state":"open","locked":false,"title":"Add erase option to release cache","user":{"login":"maysamyabandeh","id":1167741,"avatar_url":"https://avatars1.githubusercontent.com/u/1167741?v=3","gravatar_id":"","url":"https://api.github.com/users/maysamyabandeh","html_url":"https://github.com/maysamyabandeh","followers_url":"https://api.github.com/users/maysamyabandeh/followers","following_url":"https://api.github.com/users/maysamyabandeh/following{/other_user}","gists_url":"https://api.github.com/users/maysamyabandeh/gists{/gist_id}","starred_url":"https://api.github.com/users/maysamyabandeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maysamyabandeh/subscriptions","organizations_url":"https://api.github.com/users/maysamyabandeh/orgs","repos_url":"https://api.github.com/users/maysamyabandeh/repos","events_url":"https://api.github.com/users/maysamyabandeh/events{/privacy}","received_events_url":"https://api.github.com/users/maysamyabandeh/received_events","type":"User","site_admin":false},"body":"This is useful when we put the entries in the block cache for accounting\r\npurposes and do not expect it to be used after it is released. If the cache does not\r\nerase the item in such cases not only the performance of cache is\r\nnegatively affected but the item's destructor not being called at the\r\ntime of release might violate the assumptions about the lifetime of the\r\nobject.\r\n\r\nThe new change adds a force_erase option to the Release method and\r\nreturns a boolean to indicate whehter the item is successfully deleted.","created_at":"2017-04-19T19:37:25Z","updated_at":"2017-04-20T01:40:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3c79e0d7c77d928d76c90708de9603de922364f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/rocksdb/pulls/2180/commits","review_comments_url":"https://api.github.com/repos/facebook/rocksdb/pulls/2180/comments","review_comment_url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/2180/comments","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/4d518290953a76d6464b0e10b7829c1e20695164","head":{"label":"maysamyabandeh:realease-and-erase","ref":"realease-and-erase","sha":"4d518290953a76d6464b0e10b7829c1e20695164","user":{"login":"maysamyabandeh","id":1167741,"avatar_url":"https://avatars1.githubusercontent.com/u/1167741?v=3","gravatar_id":"","url":"https://api.github.com/users/maysamyabandeh","html_url":"https://github.com/maysamyabandeh","followers_url":"https://api.github.com/users/maysamyabandeh/followers","following_url":"https://api.github.com/users/maysamyabandeh/following{/other_user}","gists_url":"https://api.github.com/users/maysamyabandeh/gists{/gist_id}","starred_url":"https://api.github.com/users/maysamyabandeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maysamyabandeh/subscriptions","organizations_url":"https://api.github.com/users/maysamyabandeh/orgs","repos_url":"https://api.github.com/users/maysamyabandeh/repos","events_url":"https://api.github.com/users/maysamyabandeh/events{/privacy}","received_events_url":"https://api.github.com/users/maysamyabandeh/received_events","type":"User","site_admin":false},"repo":{"id":73221890,"name":"rocksdb","full_name":"maysamyabandeh/rocksdb","owner":{"login":"maysamyabandeh","id":1167741,"avatar_url":"https://avatars1.githubusercontent.com/u/1167741?v=3","gravatar_id":"","url":"https://api.github.com/users/maysamyabandeh","html_url":"https://github.com/maysamyabandeh","followers_url":"https://api.github.com/users/maysamyabandeh/followers","following_url":"https://api.github.com/users/maysamyabandeh/following{/other_user}","gists_url":"https://api.github.com/users/maysamyabandeh/gists{/gist_id}","starred_url":"https://api.github.com/users/maysamyabandeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maysamyabandeh/subscriptions","organizations_url":"https://api.github.com/users/maysamyabandeh/orgs","repos_url":"https://api.github.com/users/maysamyabandeh/repos","events_url":"https://api.github.com/users/maysamyabandeh/events{/privacy}","received_events_url":"https://api.github.com/users/maysamyabandeh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maysamyabandeh/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":true,"url":"https://api.github.com/repos/maysamyabandeh/rocksdb","forks_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/forks","keys_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/teams","hooks_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/events","assignees_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/tags","blobs_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/languages","stargazers_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/subscription","commits_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/merges","archive_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/downloads","issues_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/deployments","created_at":"2016-11-08T19:56:13Z","updated_at":"2016-11-08T19:56:19Z","pushed_at":"2017-04-19T23:40:26Z","git_url":"git://github.com/maysamyabandeh/rocksdb.git","ssh_url":"[email protected]:maysamyabandeh/rocksdb.git","clone_url":"https://github.com/maysamyabandeh/rocksdb.git","svn_url":"https://github.com/maysamyabandeh/rocksdb","homepage":"http://rocksdb.org","size":99572,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"1dd7760513806bf9b24dcc3aad744789ca320a46","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6934395,"name":"rocksdb","full_name":"facebook/rocksdb","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":false,"url":"https://api.github.com/repos/facebook/rocksdb","forks_url":"https://api.github.com/repos/facebook/rocksdb/forks","keys_url":"https://api.github.com/repos/facebook/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/rocksdb/teams","hooks_url":"https://api.github.com/repos/facebook/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/facebook/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/rocksdb/events","assignees_url":"https://api.github.com/repos/facebook/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/rocksdb/tags","blobs_url":"https://api.github.com/repos/facebook/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/rocksdb/languages","stargazers_url":"https://api.github.com/repos/facebook/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/facebook/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/facebook/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/facebook/rocksdb/subscription","commits_url":"https://api.github.com/repos/facebook/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/rocksdb/merges","archive_url":"https://api.github.com/repos/facebook/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/rocksdb/downloads","issues_url":"https://api.github.com/repos/facebook/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/facebook/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/rocksdb/deployments","created_at":"2012-11-30T06:16:18Z","updated_at":"2017-04-19T23:21:53Z","pushed_at":"2017-04-20T00:29:53Z","git_url":"git://github.com/facebook/rocksdb.git","ssh_url":"[email protected]:facebook/rocksdb.git","clone_url":"https://github.com/facebook/rocksdb.git","svn_url":"https://github.com/facebook/rocksdb","homepage":"http://rocksdb.org","size":99870,"stargazers_count":7455,"watchers_count":7455,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1587,"mirror_url":null,"open_issues_count":421,"forks":1587,"open_issues":421,"watchers":7455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/2180"},"html":{"href":"https://github.com/facebook/rocksdb/pull/2180"},"issue":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/2180"},"comments":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/2180/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/2180/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/2180/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/rocksdb/statuses/4d518290953a76d6464b0e10b7829c1e20695164"}}}} | {
"id": 6934395,
"name": "facebook/rocksdb",
"url": "https://api.github.com/repos/facebook/rocksdb"
} | {
"id": 2606959,
"login": "yiwu-arbug",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2606959?",
"url": "https://api.github.com/users/yiwu-arbug"
} | {
"id": 69631,
"login": "facebook",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/69631?",
"url": "https://api.github.com/orgs/facebook"
} | 2017-04-20T01:32:54 | 5720414952 | {"actor":{"display_login":"yiwu-arbug"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/facebook/jest/pulls/comments/111315844","pull_request_review_id":32551665,"id":111315844,"diff_hunk":"@@ -60,7 +61,7 @@ const print = (\n ) => {\n let result = colors.tag.open + '<';\n const elementName = element.constructor","path":"packages/pretty-format/src/plugins/HTMLElement.js","position":null,"original_position":11,"commit_id":"b08ee74dc4f6c3a309f1a8c0ebf29db92ce0c336","original_commit_id":"b08ee74dc4f6c3a309f1a8c0ebf29db92ce0c336","user":{"login":"mute","id":730349,"avatar_url":"https://avatars2.githubusercontent.com/u/730349?v=3","gravatar_id":"","url":"https://api.github.com/users/mute","html_url":"https://github.com/mute","followers_url":"https://api.github.com/users/mute/followers","following_url":"https://api.github.com/users/mute/following{/other_user}","gists_url":"https://api.github.com/users/mute/gists{/gist_id}","starred_url":"https://api.github.com/users/mute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mute/subscriptions","organizations_url":"https://api.github.com/users/mute/orgs","repos_url":"https://api.github.com/users/mute/repos","events_url":"https://api.github.com/users/mute/events{/privacy}","received_events_url":"https://api.github.com/users/mute/received_events","type":"User","site_admin":false},"body":"`tagName` defaults to all uppercase, which felt odd to me -- should I leave it that way or is the `.toLowerCase()` call okay here?","created_at":"2017-04-13T05:54:48Z","updated_at":"2017-04-13T05:54:48Z","html_url":"https://github.com/facebook/jest/pull/3230#discussion_r111315844","pull_request_url":"https://api.github.com/repos/facebook/jest/pulls/3230","_links":{"self":{"href":"https://api.github.com/repos/facebook/jest/pulls/comments/111315844"},"html":{"href":"https://github.com/facebook/jest/pull/3230#discussion_r111315844"},"pull_request":{"href":"https://api.github.com/repos/facebook/jest/pulls/3230"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/jest/pulls/3230","id":113348671,"html_url":"https://github.com/facebook/jest/pull/3230","diff_url":"https://github.com/facebook/jest/pull/3230.diff","patch_url":"https://github.com/facebook/jest/pull/3230.patch","issue_url":"https://api.github.com/repos/facebook/jest/issues/3230","number":3230,"state":"open","locked":false,"title":"Adds HtmlElement pretty-format plugin.","user":{"login":"mute","id":730349,"avatar_url":"https://avatars2.githubusercontent.com/u/730349?v=3","gravatar_id":"","url":"https://api.github.com/users/mute","html_url":"https://github.com/mute","followers_url":"https://api.github.com/users/mute/followers","following_url":"https://api.github.com/users/mute/following{/other_user}","gists_url":"https://api.github.com/users/mute/gists{/gist_id}","starred_url":"https://api.github.com/users/mute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mute/subscriptions","organizations_url":"https://api.github.com/users/mute/orgs","repos_url":"https://api.github.com/users/mute/repos","events_url":"https://api.github.com/users/mute/events{/privacy}","received_events_url":"https://api.github.com/users/mute/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory. -->\r\n\r\n**Summary**\r\n\r\nThis addresses the issue noted in #2146, with `jsdom` HTMLElement's producing an absurdly long string when pretty formatted. It adds an `HTMLElement` plugin which can be used to appropriately `pretty-format` these elements.\r\n\r\n**Test plan**\r\n\r\nI tested this using a variety of unit tests, similar to the existing tests that were covering `ReactElement`.\r\n\r\nThe cases I covered were ensuring that the class / title properties would pretty-format correctly, along with attributes on single elements and nested elements.\r\n\r\nHere is the output from running those tests: \r\n","created_at":"2017-03-30T05:27:22Z","updated_at":"2017-04-13T05:54:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0000fc519208f8e24aef02fa58703c5f16279ade","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/jest/pulls/3230/commits","review_comments_url":"https://api.github.com/repos/facebook/jest/pulls/3230/comments","review_comment_url":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/jest/issues/3230/comments","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/b08ee74dc4f6c3a309f1a8c0ebf29db92ce0c336","head":{"label":"mute:2146-pretty-jsdom","ref":"2146-pretty-jsdom","sha":"b08ee74dc4f6c3a309f1a8c0ebf29db92ce0c336","user":{"login":"mute","id":730349,"avatar_url":"https://avatars2.githubusercontent.com/u/730349?v=3","gravatar_id":"","url":"https://api.github.com/users/mute","html_url":"https://github.com/mute","followers_url":"https://api.github.com/users/mute/followers","following_url":"https://api.github.com/users/mute/following{/other_user}","gists_url":"https://api.github.com/users/mute/gists{/gist_id}","starred_url":"https://api.github.com/users/mute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mute/subscriptions","organizations_url":"https://api.github.com/users/mute/orgs","repos_url":"https://api.github.com/users/mute/repos","events_url":"https://api.github.com/users/mute/events{/privacy}","received_events_url":"https://api.github.com/users/mute/received_events","type":"User","site_admin":false},"repo":{"id":85146390,"name":"jest","full_name":"mute/jest","owner":{"login":"mute","id":730349,"avatar_url":"https://avatars2.githubusercontent.com/u/730349?v=3","gravatar_id":"","url":"https://api.github.com/users/mute","html_url":"https://github.com/mute","followers_url":"https://api.github.com/users/mute/followers","following_url":"https://api.github.com/users/mute/following{/other_user}","gists_url":"https://api.github.com/users/mute/gists{/gist_id}","starred_url":"https://api.github.com/users/mute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mute/subscriptions","organizations_url":"https://api.github.com/users/mute/orgs","repos_url":"https://api.github.com/users/mute/repos","events_url":"https://api.github.com/users/mute/events{/privacy}","received_events_url":"https://api.github.com/users/mute/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mute/jest","description":"🃏 Painless JavaScript Testing.","fork":true,"url":"https://api.github.com/repos/mute/jest","forks_url":"https://api.github.com/repos/mute/jest/forks","keys_url":"https://api.github.com/repos/mute/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mute/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mute/jest/teams","hooks_url":"https://api.github.com/repos/mute/jest/hooks","issue_events_url":"https://api.github.com/repos/mute/jest/issues/events{/number}","events_url":"https://api.github.com/repos/mute/jest/events","assignees_url":"https://api.github.com/repos/mute/jest/assignees{/user}","branches_url":"https://api.github.com/repos/mute/jest/branches{/branch}","tags_url":"https://api.github.com/repos/mute/jest/tags","blobs_url":"https://api.github.com/repos/mute/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mute/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mute/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/mute/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mute/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/mute/jest/languages","stargazers_url":"https://api.github.com/repos/mute/jest/stargazers","contributors_url":"https://api.github.com/repos/mute/jest/contributors","subscribers_url":"https://api.github.com/repos/mute/jest/subscribers","subscription_url":"https://api.github.com/repos/mute/jest/subscription","commits_url":"https://api.github.com/repos/mute/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/mute/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/mute/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/mute/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/mute/jest/contents/{+path}","compare_url":"https://api.github.com/repos/mute/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mute/jest/merges","archive_url":"https://api.github.com/repos/mute/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mute/jest/downloads","issues_url":"https://api.github.com/repos/mute/jest/issues{/number}","pulls_url":"https://api.github.com/repos/mute/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/mute/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/mute/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mute/jest/labels{/name}","releases_url":"https://api.github.com/repos/mute/jest/releases{/id}","deployments_url":"https://api.github.com/repos/mute/jest/deployments","created_at":"2017-03-16T03:05:12Z","updated_at":"2017-03-16T03:05:16Z","pushed_at":"2017-04-13T05:45:51Z","git_url":"git://github.com/mute/jest.git","ssh_url":"[email protected]:mute/jest.git","clone_url":"https://github.com/mute/jest.git","svn_url":"https://github.com/mute/jest","homepage":"http://facebook.github.io/jest/","size":13387,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"b93f9c665ddc2e6ba856483a14412a767ba0846e","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":15062869,"name":"jest","full_name":"facebook/jest","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/jest","description":"🃏 Painless JavaScript Testing.","fork":false,"url":"https://api.github.com/repos/facebook/jest","forks_url":"https://api.github.com/repos/facebook/jest/forks","keys_url":"https://api.github.com/repos/facebook/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/jest/teams","hooks_url":"https://api.github.com/repos/facebook/jest/hooks","issue_events_url":"https://api.github.com/repos/facebook/jest/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/jest/events","assignees_url":"https://api.github.com/repos/facebook/jest/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/jest/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/jest/tags","blobs_url":"https://api.github.com/repos/facebook/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/jest/languages","stargazers_url":"https://api.github.com/repos/facebook/jest/stargazers","contributors_url":"https://api.github.com/repos/facebook/jest/contributors","subscribers_url":"https://api.github.com/repos/facebook/jest/subscribers","subscription_url":"https://api.github.com/repos/facebook/jest/subscription","commits_url":"https://api.github.com/repos/facebook/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/jest/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/jest/merges","archive_url":"https://api.github.com/repos/facebook/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/jest/downloads","issues_url":"https://api.github.com/repos/facebook/jest/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/jest/labels{/name}","releases_url":"https://api.github.com/repos/facebook/jest/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/jest/deployments","created_at":"2013-12-10T00:18:04Z","updated_at":"2017-04-13T05:30:52Z","pushed_at":"2017-04-13T05:45:53Z","git_url":"git://github.com/facebook/jest.git","ssh_url":"[email protected]:facebook/jest.git","clone_url":"https://github.com/facebook/jest.git","svn_url":"https://github.com/facebook/jest","homepage":"http://facebook.github.io/jest/","size":13440,"stargazers_count":9180,"watchers_count":9180,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1119,"mirror_url":null,"open_issues_count":123,"forks":1119,"open_issues":123,"watchers":9180,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/jest/pulls/3230"},"html":{"href":"https://github.com/facebook/jest/pull/3230"},"issue":{"href":"https://api.github.com/repos/facebook/jest/issues/3230"},"comments":{"href":"https://api.github.com/repos/facebook/jest/issues/3230/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/jest/pulls/3230/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/jest/pulls/3230/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/jest/statuses/b08ee74dc4f6c3a309f1a8c0ebf29db92ce0c336"}}}} | {
"id": 15062869,
"name": "facebook/jest",
"url": "https://api.github.com/repos/facebook/jest"
} | {
"id": 730349,
"login": "mute",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/730349?",
"url": "https://api.github.com/users/mute"
} | {
"id": 69631,
"login": "facebook",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/69631?",
"url": "https://api.github.com/orgs/facebook"
} | 2017-04-13T05:54:48 | 5681324896 | {"actor":{"display_login":"mute"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/facebook/prepack/pulls/comments/114936251","pull_request_review_id":36438793,"id":114936251,"diff_hunk":"@@ -750,6 +750,100 @@ export class Serializer {\n return t.arrayExpression(elems);\n }\n \n+ _serializeValueMap(name: string, val: ObjectValue, reasons: Array<string>): BabelNodeExpression {\n+ let kind = val.getKind();\n+ let elems = [];\n+\n+ let entries;\n+ if (kind === \"Map\") {\n+ entries = val.$MapData;\n+ } else {\n+ invariant(kind === \"WeakMap\");\n+ entries = val.$WeakMapData;\n+ }\n+ invariant(entries !== undefined);\n+ let len = entries.length;\n+\n+ for (let i = 0; i < len; i++) {\n+ let entry = entries[i];\n+ let key = entry.$Key;\n+ let value = entry.$Value;\n+ if (key === undefined || value === undefined) continue;","path":"src/serializer/serializer.js","position":22,"original_position":22,"commit_id":"f89224f56c83a7fa597c79ca92848163c8dc9072","original_commit_id":"f89224f56c83a7fa597c79ca92848163c8dc9072","user":{"login":"NTillmann","id":6457462,"avatar_url":"https://avatars1.githubusercontent.com/u/6457462?v=3","gravatar_id":"","url":"https://api.github.com/users/NTillmann","html_url":"https://github.com/NTillmann","followers_url":"https://api.github.com/users/NTillmann/followers","following_url":"https://api.github.com/users/NTillmann/following{/other_user}","gists_url":"https://api.github.com/users/NTillmann/gists{/gist_id}","starred_url":"https://api.github.com/users/NTillmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NTillmann/subscriptions","organizations_url":"https://api.github.com/users/NTillmann/orgs","repos_url":"https://api.github.com/users/NTillmann/repos","events_url":"https://api.github.com/users/NTillmann/events{/privacy}","received_events_url":"https://api.github.com/users/NTillmann/received_events","type":"User","site_admin":false},"body":"I don't see how this is covered by any test case. Call .clear to trigger it.","created_at":"2017-05-05T06:09:51Z","updated_at":"2017-05-05T06:12:31Z","html_url":"https://github.com/facebook/prepack/pull/565#discussion_r114936251","pull_request_url":"https://api.github.com/repos/facebook/prepack/pulls/565","_links":{"self":{"href":"https://api.github.com/repos/facebook/prepack/pulls/comments/114936251"},"html":{"href":"https://github.com/facebook/prepack/pull/565#discussion_r114936251"},"pull_request":{"href":"https://api.github.com/repos/facebook/prepack/pulls/565"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/prepack/pulls/565","id":119090404,"html_url":"https://github.com/facebook/prepack/pull/565","diff_url":"https://github.com/facebook/prepack/pull/565.diff","patch_url":"https://github.com/facebook/prepack/pull/565.patch","issue_url":"https://api.github.com/repos/facebook/prepack/issues/565","number":565,"state":"open","locked":false,"title":"Serializer support for maps and sets","user":{"login":"hermanventer","id":4325251,"avatar_url":"https://avatars1.githubusercontent.com/u/4325251?v=3","gravatar_id":"","url":"https://api.github.com/users/hermanventer","html_url":"https://github.com/hermanventer","followers_url":"https://api.github.com/users/hermanventer/followers","following_url":"https://api.github.com/users/hermanventer/following{/other_user}","gists_url":"https://api.github.com/users/hermanventer/gists{/gist_id}","starred_url":"https://api.github.com/users/hermanventer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hermanventer/subscriptions","organizations_url":"https://api.github.com/users/hermanventer/orgs","repos_url":"https://api.github.com/users/hermanventer/repos","events_url":"https://api.github.com/users/hermanventer/events{/privacy}","received_events_url":"https://api.github.com/users/hermanventer/received_events","type":"User","site_admin":false},"body":"Map, Set, WeakMap and WeakSet can now be serialized.","created_at":"2017-05-05T00:00:09Z","updated_at":"2017-05-05T06:12:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18e9aca11cd2d1db5cca6052ddb8d144e1d77e50","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/prepack/pulls/565/commits","review_comments_url":"https://api.github.com/repos/facebook/prepack/pulls/565/comments","review_comment_url":"https://api.github.com/repos/facebook/prepack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/prepack/issues/565/comments","statuses_url":"https://api.github.com/repos/facebook/prepack/statuses/f89224f56c83a7fa597c79ca92848163c8dc9072","head":{"label":"facebook:setmap","ref":"setmap","sha":"f89224f56c83a7fa597c79ca92848163c8dc9072","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":45147841,"name":"prepack","full_name":"facebook/prepack","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/prepack","description":"Prepack is a partial evaluator for JavaScript. Prepack rewrites a JavaScript bundle, resulting in JavaScript code that executes more efficiently.","fork":false,"url":"https://api.github.com/repos/facebook/prepack","forks_url":"https://api.github.com/repos/facebook/prepack/forks","keys_url":"https://api.github.com/repos/facebook/prepack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/prepack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/prepack/teams","hooks_url":"https://api.github.com/repos/facebook/prepack/hooks","issue_events_url":"https://api.github.com/repos/facebook/prepack/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/prepack/events","assignees_url":"https://api.github.com/repos/facebook/prepack/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/prepack/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/prepack/tags","blobs_url":"https://api.github.com/repos/facebook/prepack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/prepack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/prepack/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/prepack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/prepack/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/prepack/languages","stargazers_url":"https://api.github.com/repos/facebook/prepack/stargazers","contributors_url":"https://api.github.com/repos/facebook/prepack/contributors","subscribers_url":"https://api.github.com/repos/facebook/prepack/subscribers","subscription_url":"https://api.github.com/repos/facebook/prepack/subscription","commits_url":"https://api.github.com/repos/facebook/prepack/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/prepack/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/prepack/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/prepack/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/prepack/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/prepack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/prepack/merges","archive_url":"https://api.github.com/repos/facebook/prepack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/prepack/downloads","issues_url":"https://api.github.com/repos/facebook/prepack/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/prepack/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/prepack/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/prepack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/prepack/labels{/name}","releases_url":"https://api.github.com/repos/facebook/prepack/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/prepack/deployments","created_at":"2015-10-28T23:25:08Z","updated_at":"2017-05-05T06:11:57Z","pushed_at":"2017-05-05T04:26:31Z","git_url":"git://github.com/facebook/prepack.git","ssh_url":"[email protected]:facebook/prepack.git","clone_url":"https://github.com/facebook/prepack.git","svn_url":"https://github.com/facebook/prepack","homepage":"https://prepack.io","size":1331,"stargazers_count":5580,"watchers_count":5580,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":105,"mirror_url":null,"open_issues_count":78,"forks":105,"open_issues":78,"watchers":5580,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"2e0ff63a697d95460174ca90e334588f122f023f","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":45147841,"name":"prepack","full_name":"facebook/prepack","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/prepack","description":"Prepack is a partial evaluator for JavaScript. Prepack rewrites a JavaScript bundle, resulting in JavaScript code that executes more efficiently.","fork":false,"url":"https://api.github.com/repos/facebook/prepack","forks_url":"https://api.github.com/repos/facebook/prepack/forks","keys_url":"https://api.github.com/repos/facebook/prepack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/prepack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/prepack/teams","hooks_url":"https://api.github.com/repos/facebook/prepack/hooks","issue_events_url":"https://api.github.com/repos/facebook/prepack/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/prepack/events","assignees_url":"https://api.github.com/repos/facebook/prepack/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/prepack/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/prepack/tags","blobs_url":"https://api.github.com/repos/facebook/prepack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/prepack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/prepack/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/prepack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/prepack/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/prepack/languages","stargazers_url":"https://api.github.com/repos/facebook/prepack/stargazers","contributors_url":"https://api.github.com/repos/facebook/prepack/contributors","subscribers_url":"https://api.github.com/repos/facebook/prepack/subscribers","subscription_url":"https://api.github.com/repos/facebook/prepack/subscription","commits_url":"https://api.github.com/repos/facebook/prepack/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/prepack/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/prepack/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/prepack/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/prepack/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/prepack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/prepack/merges","archive_url":"https://api.github.com/repos/facebook/prepack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/prepack/downloads","issues_url":"https://api.github.com/repos/facebook/prepack/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/prepack/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/prepack/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/prepack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/prepack/labels{/name}","releases_url":"https://api.github.com/repos/facebook/prepack/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/prepack/deployments","created_at":"2015-10-28T23:25:08Z","updated_at":"2017-05-05T06:11:57Z","pushed_at":"2017-05-05T04:26:31Z","git_url":"git://github.com/facebook/prepack.git","ssh_url":"[email protected]:facebook/prepack.git","clone_url":"https://github.com/facebook/prepack.git","svn_url":"https://github.com/facebook/prepack","homepage":"https://prepack.io","size":1331,"stargazers_count":5580,"watchers_count":5580,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":105,"mirror_url":null,"open_issues_count":78,"forks":105,"open_issues":78,"watchers":5580,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/prepack/pulls/565"},"html":{"href":"https://github.com/facebook/prepack/pull/565"},"issue":{"href":"https://api.github.com/repos/facebook/prepack/issues/565"},"comments":{"href":"https://api.github.com/repos/facebook/prepack/issues/565/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/prepack/pulls/565/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/prepack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/prepack/pulls/565/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/prepack/statuses/f89224f56c83a7fa597c79ca92848163c8dc9072"}}}} | {
"id": 45147841,
"name": "facebook/prepack",
"url": "https://api.github.com/repos/facebook/prepack"
} | {
"id": 6457462,
"login": "NTillmann",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6457462?",
"url": "https://api.github.com/users/NTillmann"
} | {
"id": 69631,
"login": "facebook",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/69631?",
"url": "https://api.github.com/orgs/facebook"
} | 2017-05-05T06:09:51 | 5814841366 | {"actor":{"display_login":"NTillmann"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/comments/99362829","pull_request_review_id":20033173,"id":99362829,"diff_hunk":"@@ -0,0 +1,55 @@\n+/**\n+ * Copyright (c) 2015-present, Facebook, Inc.\n+ * All rights reserved.\n+ *\n+ * This source code is licensed under the BSD-style license found in the\n+ * LICENSE file in the root directory of this source tree. An additional grant\n+ * of patent rights can be found in the PATENTS file in the same directory.\n+ */\n+\n+#import <XCTest/XCTest.h>\n+\n+\n+NS_ASSUME_NONNULL_BEGIN\n+\n+@interface FBClassChainElement : NSObject\n+\n+/*! Element's position */\n+@property (readonly) NSInteger position;\n+/*! Element's type */\n+@property (readonly) XCUIElementType type;\n+\n+/**\n+ Instance constructor, which allows to set element type and position\n+ \n+ @param type on of supoported element types declared in XCUIElementType enum\n+ @param position element position relative to its sibling element. Numeration\n+ starts with 1. Zero value means that all sibling element should be selected.\n+ Negative value means that numeration starts from the last element, for example\n+ -1 is the last child element and -2 is the second last element\n+ @return FBClassChainElement instance\n+ */\n+- (id) initWithType:(XCUIElementType)type position:(NSInteger)position;","path":"WebDriverAgentLib/Utilities/FBClassChainQueryParser.h","position":32,"original_position":32,"commit_id":"38a88b857969ad0f0f9ca3d7ccf1aa028ee95bba","original_commit_id":"38a88b857969ad0f0f9ca3d7ccf1aa028ee95bba","user":{"login":"marekcirkos","id":1397422,"avatar_url":"https://avatars.githubusercontent.com/u/1397422?v=3","gravatar_id":"","url":"https://api.github.com/users/marekcirkos","html_url":"https://github.com/marekcirkos","followers_url":"https://api.github.com/users/marekcirkos/followers","following_url":"https://api.github.com/users/marekcirkos/following{/other_user}","gists_url":"https://api.github.com/users/marekcirkos/gists{/gist_id}","starred_url":"https://api.github.com/users/marekcirkos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marekcirkos/subscriptions","organizations_url":"https://api.github.com/users/marekcirkos/orgs","repos_url":"https://api.github.com/users/marekcirkos/repos","events_url":"https://api.github.com/users/marekcirkos/events{/privacy}","received_events_url":"https://api.github.com/users/marekcirkos/received_events","type":"User","site_admin":false},"body":"Kill space after `(id)`. I noticed it in few other places cross diff..","created_at":"2017-02-03T15:48:51Z","updated_at":"2017-02-03T15:53:48Z","html_url":"https://github.com/facebook/WebDriverAgent/pull/442#discussion_r99362829","pull_request_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/442","_links":{"self":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/comments/99362829"},"html":{"href":"https://github.com/facebook/WebDriverAgent/pull/442#discussion_r99362829"},"pull_request":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/442"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/442","id":100658743,"html_url":"https://github.com/facebook/WebDriverAgent/pull/442","diff_url":"https://github.com/facebook/WebDriverAgent/pull/442.diff","patch_url":"https://github.com/facebook/WebDriverAgent/pull/442.patch","issue_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/442","number":442,"state":"open","locked":false,"title":"Element search by 'class chain' locator type ","user":{"login":"mykola-mokhnach","id":7767781,"avatar_url":"https://avatars.githubusercontent.com/u/7767781?v=3","gravatar_id":"","url":"https://api.github.com/users/mykola-mokhnach","html_url":"https://github.com/mykola-mokhnach","followers_url":"https://api.github.com/users/mykola-mokhnach/followers","following_url":"https://api.github.com/users/mykola-mokhnach/following{/other_user}","gists_url":"https://api.github.com/users/mykola-mokhnach/gists{/gist_id}","starred_url":"https://api.github.com/users/mykola-mokhnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykola-mokhnach/subscriptions","organizations_url":"https://api.github.com/users/mykola-mokhnach/orgs","repos_url":"https://api.github.com/users/mykola-mokhnach/repos","events_url":"https://api.github.com/users/mykola-mokhnach/events{/privacy}","received_events_url":"https://api.github.com/users/mykola-mokhnach/received_events","type":"User","site_admin":false},"body":"The idea for this PR is borrowed from Adobe Flex open-source testing framework, where xpath queries are not supported natively. I did it, because I observe many people still build xpath queries, like this\r\n\r\n```\r\n/XCUIElementTypeApplication/XCUIElementTypeWindow/XCUIElementTypeOther/XCUIElementTypeOther/XCUIElementTypeOther[2]/XCUIElementTypeOther/XCUIElementTypeOther/XCUIElementTypeOther/XCUIElementTypeOther/XCUIElementTypeOther/XCUIElementTypeOther/XCUIElementTypeOther/XCUIElementTypeTable/XCUIElementTypeCell/XCUIElementTypeStaticText[2]\r\n```\r\n\r\nAnd they are quite slow, since xpath is not natively supported by XCTest.\r\n\r\nMy implementation uses the same query syntax as xpath (only class names and indexes are supported though), but the search itself takes much less time in comparison to xpath, because it looks for direct child nodes only and uses single native method call (_childrenMatchingType_) for this purpose. Examples of valid class chain queries:\r\n\r\n```\r\nXCUIElementTypeWindow/XCUIElementTypeButton[3] - select the third child button of the first child window element (indexing starts from 1. zero index is invalid, negative indexes are allowed)\r\n\r\nXCUIElementTypeWindow - select all the children windows\r\n\r\nXCUIElementTypeWindow[2] - select the second child window in the hierarchy. Indexing starts at 1\r\n\r\nXCUIElementTypeWindow/XCUIElementTypeAny[3] - select the third child (of any type) of the first child window\r\n\r\nXCUIElementTypeWindow/*[3] - same as above\r\n\r\nXCUIElementTypeWindow[2]/XCUIElementTypeAny - select all the children of the second child window\r\n\r\nXCUIElementTypeWindow[2]/XCUIElementTypeAny[-2] - select the second last child of the second child window\r\n```\r\n\r\nI've also implemented nice descriptions for syntax errors.","created_at":"2017-01-09T10:05:11Z","updated_at":"2017-02-03T15:53:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1abb2a5f053bbfbbeac2bc1f81a00425d50788e5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/442/commits","review_comments_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/442/comments","review_comment_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/442/comments","statuses_url":"https://api.github.com/repos/facebook/WebDriverAgent/statuses/38a88b857969ad0f0f9ca3d7ccf1aa028ee95bba","head":{"label":"mykola-mokhnach:class_chain_search","ref":"class_chain_search","sha":"38a88b857969ad0f0f9ca3d7ccf1aa028ee95bba","user":{"login":"mykola-mokhnach","id":7767781,"avatar_url":"https://avatars.githubusercontent.com/u/7767781?v=3","gravatar_id":"","url":"https://api.github.com/users/mykola-mokhnach","html_url":"https://github.com/mykola-mokhnach","followers_url":"https://api.github.com/users/mykola-mokhnach/followers","following_url":"https://api.github.com/users/mykola-mokhnach/following{/other_user}","gists_url":"https://api.github.com/users/mykola-mokhnach/gists{/gist_id}","starred_url":"https://api.github.com/users/mykola-mokhnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykola-mokhnach/subscriptions","organizations_url":"https://api.github.com/users/mykola-mokhnach/orgs","repos_url":"https://api.github.com/users/mykola-mokhnach/repos","events_url":"https://api.github.com/users/mykola-mokhnach/events{/privacy}","received_events_url":"https://api.github.com/users/mykola-mokhnach/received_events","type":"User","site_admin":false},"repo":{"id":69477973,"name":"WebDriverAgent","full_name":"mykola-mokhnach/WebDriverAgent","owner":{"login":"mykola-mokhnach","id":7767781,"avatar_url":"https://avatars.githubusercontent.com/u/7767781?v=3","gravatar_id":"","url":"https://api.github.com/users/mykola-mokhnach","html_url":"https://github.com/mykola-mokhnach","followers_url":"https://api.github.com/users/mykola-mokhnach/followers","following_url":"https://api.github.com/users/mykola-mokhnach/following{/other_user}","gists_url":"https://api.github.com/users/mykola-mokhnach/gists{/gist_id}","starred_url":"https://api.github.com/users/mykola-mokhnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykola-mokhnach/subscriptions","organizations_url":"https://api.github.com/users/mykola-mokhnach/orgs","repos_url":"https://api.github.com/users/mykola-mokhnach/repos","events_url":"https://api.github.com/users/mykola-mokhnach/events{/privacy}","received_events_url":"https://api.github.com/users/mykola-mokhnach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mykola-mokhnach/WebDriverAgent","description":"A WebDriver server for iOS that runs inside the Simulator.","fork":true,"url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent","forks_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/forks","keys_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/teams","hooks_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/hooks","issue_events_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/issues/events{/number}","events_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/events","assignees_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/assignees{/user}","branches_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/branches{/branch}","tags_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/tags","blobs_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/git/refs{/sha}","trees_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/statuses/{sha}","languages_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/languages","stargazers_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/stargazers","contributors_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/contributors","subscribers_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/subscribers","subscription_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/subscription","commits_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/commits{/sha}","git_commits_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/git/commits{/sha}","comments_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/comments{/number}","issue_comment_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/issues/comments{/number}","contents_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/contents/{+path}","compare_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/merges","archive_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/downloads","issues_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/issues{/number}","pulls_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/pulls{/number}","milestones_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/milestones{/number}","notifications_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/labels{/name}","releases_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/releases{/id}","deployments_url":"https://api.github.com/repos/mykola-mokhnach/WebDriverAgent/deployments","created_at":"2016-09-28T15:36:31Z","updated_at":"2016-09-28T15:36:33Z","pushed_at":"2017-02-03T13:23:28Z","git_url":"git://github.com/mykola-mokhnach/WebDriverAgent.git","ssh_url":"[email protected]:mykola-mokhnach/WebDriverAgent.git","clone_url":"https://github.com/mykola-mokhnach/WebDriverAgent.git","svn_url":"https://github.com/mykola-mokhnach/WebDriverAgent","homepage":null,"size":15379,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"04d1b342b7b272c9818ba2e7b981724a458aaba5","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":41855272,"name":"WebDriverAgent","full_name":"facebook/WebDriverAgent","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/WebDriverAgent","description":"A WebDriver server for iOS that runs inside the Simulator.","fork":false,"url":"https://api.github.com/repos/facebook/WebDriverAgent","forks_url":"https://api.github.com/repos/facebook/WebDriverAgent/forks","keys_url":"https://api.github.com/repos/facebook/WebDriverAgent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/WebDriverAgent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/WebDriverAgent/teams","hooks_url":"https://api.github.com/repos/facebook/WebDriverAgent/hooks","issue_events_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/WebDriverAgent/events","assignees_url":"https://api.github.com/repos/facebook/WebDriverAgent/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/WebDriverAgent/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/WebDriverAgent/tags","blobs_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/WebDriverAgent/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/WebDriverAgent/languages","stargazers_url":"https://api.github.com/repos/facebook/WebDriverAgent/stargazers","contributors_url":"https://api.github.com/repos/facebook/WebDriverAgent/contributors","subscribers_url":"https://api.github.com/repos/facebook/WebDriverAgent/subscribers","subscription_url":"https://api.github.com/repos/facebook/WebDriverAgent/subscription","commits_url":"https://api.github.com/repos/facebook/WebDriverAgent/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/WebDriverAgent/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/WebDriverAgent/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/WebDriverAgent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/WebDriverAgent/merges","archive_url":"https://api.github.com/repos/facebook/WebDriverAgent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/WebDriverAgent/downloads","issues_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/WebDriverAgent/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/WebDriverAgent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/WebDriverAgent/labels{/name}","releases_url":"https://api.github.com/repos/facebook/WebDriverAgent/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/WebDriverAgent/deployments","created_at":"2015-09-03T11:00:00Z","updated_at":"2017-02-03T09:17:34Z","pushed_at":"2017-02-02T16:02:38Z","git_url":"git://github.com/facebook/WebDriverAgent.git","ssh_url":"[email protected]:facebook/WebDriverAgent.git","clone_url":"https://github.com/facebook/WebDriverAgent.git","svn_url":"https://github.com/facebook/WebDriverAgent","homepage":null,"size":15327,"stargazers_count":648,"watchers_count":648,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":168,"mirror_url":null,"open_issues_count":16,"forks":168,"open_issues":16,"watchers":648,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/442"},"html":{"href":"https://github.com/facebook/WebDriverAgent/pull/442"},"issue":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/issues/442"},"comments":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/issues/442/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/442/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/442/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/statuses/38a88b857969ad0f0f9ca3d7ccf1aa028ee95bba"}}}} | {
"id": 41855272,
"name": "facebook/WebDriverAgent",
"url": "https://api.github.com/repos/facebook/WebDriverAgent"
} | {
"id": 1397422,
"login": "marekcirkos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1397422?",
"url": "https://api.github.com/users/marekcirkos"
} | {
"id": 69631,
"login": "facebook",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/69631?",
"url": "https://api.github.com/orgs/facebook"
} | 2017-02-03T15:48:51 | 5262484412 | {"actor":{"display_login":"marekcirkos"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/fossasia/phimpme-android/pulls/comments/132891564","pull_request_review_id":56014442,"id":132891564,"diff_hunk":"@@ -0,0 +1,452 @@\n+\n+//\n+// This file is auto-generated. Please don't modify it!\n+//\n+package org.opencv.ml;\n+\n+import org.opencv.core.Mat;\n+\n+// C++: class CvSVM\n+/**\n+ * <p>Support Vector Machines.</p>\n+ *\n+ * <p>Note:</p>\n+ * <ul>\n+ * <li> (Python) An example of digit recognition using SVM can be found at\n+ * opencv_source/samples/python2/digits.py\n+ * <li> (Python) An example of grid search digit recognition using SVM can be\n+ * found at opencv_source/samples/python2/digits_adjust.py\n+ * <li> (Python) An example of video digit recognition using SVM can be found\n+ * at opencv_source/samples/python2/digits_video.py\n+ * </ul>\n+ *\n+ * @see <a href=\"http://docs.opencv.org/modules/ml/doc/support_vector_machines.html#cvsvm\">org.opencv.ml.CvSVM : public CvStatModel</a>\n+ */\n+public class CvSVM extends CvStatModel {\n+\n+ protected CvSVM(long addr) { super(addr); }\n+\n+\n+ public static final int\n+ C_SVC = 100,\n+ NU_SVC = 101,\n+ ONE_CLASS = 102,\n+ EPS_SVR = 103,\n+ NU_SVR = 104,\n+ LINEAR = 0,\n+ POLY = 1,\n+ RBF = 2,\n+ SIGMOID = 3,\n+ C = 0,\n+ GAMMA = 1,\n+ P = 2,\n+ NU = 3,\n+ COEF = 4,\n+ DEGREE = 5;\n+\n+\n+ //\n+ // C++: CvSVM::CvSVM()\n+ //\n+\n+/**\n+ * <p>Default and training constructors.</p>\n+ *\n+ * <p>The constructors follow conventions of \"CvStatModel.CvStatModel\". See\n+ * \"CvStatModel.train\" for parameters descriptions.</p>\n+ *\n+ * @see <a href=\"http://docs.opencv.org/modules/ml/doc/support_vector_machines.html#cvsvm-cvsvm\">org.opencv.ml.CvSVM.CvSVM</a>\n+ */\n+ public CvSVM()\n+ {\n+\n+ super( CvSVM_0() );\n+\n+ return;\n+ }\n+\n+\n+ //\n+ // C++: CvSVM::CvSVM(Mat trainData, Mat responses, Mat varIdx = cv::Mat(), Mat sampleIdx = cv::Mat(), CvSVMParams params = CvSVMParams())\n+ //\n+\n+/**\n+ * <p>Default and training constructors.</p>\n+ *\n+ * <p>The constructors follow conventions of \"CvStatModel.CvStatModel\". See\n+ * \"CvStatModel.train\" for parameters descriptions.</p>\n+ *\n+ * @param trainData a trainData\n+ * @param responses a responses\n+ * @param varIdx a varIdx\n+ * @param sampleIdx a sampleIdx\n+ * @param params a params\n+ *\n+ * @see <a href=\"http://docs.opencv.org/modules/ml/doc/support_vector_machines.html#cvsvm-cvsvm\">org.opencv.ml.CvSVM.CvSVM</a>\n+ */\n+ public CvSVM(Mat trainData, Mat responses, Mat varIdx, Mat sampleIdx, CvSVMParams params)\n+ {\n+\n+ super( CvSVM_1(trainData.nativeObj, responses.nativeObj, varIdx.nativeObj, sampleIdx.nativeObj, params.nativeObj) );\n+\n+ return;\n+ }\n+\n+/**\n+ * <p>Default and training constructors.</p>\n+ *\n+ * <p>The constructors follow conventions of \"CvStatModel.CvStatModel\". See\n+ * \"CvStatModel.train\" for parameters descriptions.</p>\n+ *\n+ * @param trainData a trainData\n+ * @param responses a responses\n+ *\n+ * @see <a href=\"http://docs.opencv.org/modules/ml/doc/support_vector_machines.html#cvsvm-cvsvm\">org.opencv.ml.CvSVM.CvSVM</a>\n+ */\n+ public CvSVM(Mat trainData, Mat responses)\n+ {\n+\n+ super( CvSVM_2(trainData.nativeObj, responses.nativeObj) );\n+\n+ return;\n+ }\n+\n+\n+ //\n+ // C++: void CvSVM::clear()\n+ //\n+\n+ public void clear()\n+ {\n+\n+ clear_0(nativeObj);\n+\n+ return;\n+ }\n+\n+\n+ //\n+ // C++: int CvSVM::get_support_vector_count()\n+ //\n+\n+ public int get_support_vector_count()\n+ {\n+\n+ int retVal = get_support_vector_count_0(nativeObj);\n+\n+ return retVal;\n+ }\n+\n+\n+ //\n+ // C++: int CvSVM::get_var_count()\n+ //\n+\n+/**\n+ * <p>Returns the number of used features (variables count).</p>\n+ *\n+ * @see <a href=\"http://docs.opencv.org/modules/ml/doc/support_vector_machines.html#cvsvm-get-var-count\">org.opencv.ml.CvSVM.get_var_count</a>\n+ */\n+ public int get_var_count()\n+ {\n+\n+ int retVal = get_var_count_0(nativeObj);\n+\n+ return retVal;\n+ }\n+\n+\n+ //\n+ // C++: float CvSVM::predict(Mat sample, bool returnDFVal = false)\n+ //\n+\n+/**\n+ * <p>Predicts the response for input sample(s).</p>\n+ *\n+ * <p>If you pass one sample then prediction result is returned. If you want to get\n+ * responses for several samples then you should pass the <code>results</code>\n+ * matrix where prediction results will be stored.</p>\n+ *\n+ * <p>The function is parallelized with the TBB library.</p>\n+ *\n+ * @param sample Input sample for prediction.\n+ * @param returnDFVal Specifies a type of the return value. If <code>true</code>\n+ * and the problem is 2-class classification then the method returns the\n+ * decision function value that is signed distance to the margin, else the\n+ * function returns a class label (classification) or estimated function value\n+ * (regression).\n+ *\n+ * @see <a href=\"http://docs.opencv.org/modules/ml/doc/support_vector_machines.html#cvsvm-predict\">org.opencv.ml.CvSVM.predict</a>\n+ */\n+ public float predict(Mat sample, boolean returnDFVal)\n+ {\n+\n+ float retVal = predict_0(nativeObj, sample.nativeObj, returnDFVal);\n+\n+ return retVal;\n+ }\n+\n+/**\n+ * <p>Predicts the response for input sample(s).</p>\n+ *\n+ * <p>If you pass one sample then prediction result is returned. If you want to get\n+ * responses for several samples then you should pass the <code>results</code>\n+ * matrix where prediction results will be stored.</p>\n+ *\n+ * <p>The function is parallelized with the TBB library.</p>\n+ *\n+ * @param sample Input sample for prediction.\n+ *\n+ * @see <a href=\"http://docs.opencv.org/modules/ml/doc/support_vector_machines.html#cvsvm-predict\">org.opencv.ml.CvSVM.predict</a>\n+ */\n+ public float predict(Mat sample)\n+ {\n+\n+ float retVal = predict_1(nativeObj, sample.nativeObj);\n+\n+ return retVal;\n+ }\n+\n+\n+ //\n+ // C++: void CvSVM::predict(Mat samples, Mat& results)\n+ //\n+\n+/**\n+ * <p>Predicts the response for input sample(s).</p>\n+ *\n+ * <p>If you pass one sample then prediction result is returned. If you want to get\n+ * responses for several samples then you should pass the <code>results</code>\n+ * matrix where prediction results will be stored.</p>\n+ *\n+ * <p>The function is parallelized with the TBB library.</p>\n+ *\n+ * @param samples Input samples for prediction.\n+ * @param results Output prediction responses for corresponding samples.\n+ *\n+ * @see <a href=\"http://docs.opencv.org/modules/ml/doc/support_vector_machines.html#cvsvm-predict\">org.opencv.ml.CvSVM.predict</a>\n+ */\n+ public void predict_all(Mat samples, Mat results)\n+ {\n+\n+ predict_all_0(nativeObj, samples.nativeObj, results.nativeObj);\n+\n+ return;\n+ }\n+\n+\n+ //\n+ // C++: bool CvSVM::train(Mat trainData, Mat responses, Mat varIdx = cv::Mat(), Mat sampleIdx = cv::Mat(), CvSVMParams params = CvSVMParams())\n+ //\n+\n+/**\n+ * <p>Trains an SVM.</p>\n+ *\n+ * <p>The method trains the SVM model. It follows the conventions of the generic\n+ * \"CvStatModel.train\" approach with the following limitations:</p>\n+ * <ul>\n+ * <li> Only the <code>CV_ROW_SAMPLE</code> data layout is supported.\n+ * <li> Input variables are all ordered.\n+ * <li> Output variables can be either categorical (<code>params.svm_type=CvSVM.C_SVC</code>\n+ * or <code>params.svm_type=CvSVM.NU_SVC</code>), or ordered (<code>params.svm_type=CvSVM.EPS_SVR</code>\n+ * or <code>params.svm_type=CvSVM.NU_SVR</code>), or not required at all\n+ * (<code>params.svm_type=CvSVM.ONE_CLASS</code>).\n+ * <li> Missing measurements are not supported.\n+ * </ul>\n+ *\n+ * <p>All the other parameters are gathered in the \"CvSVMParams\" structure.</p>\n+ *\n+ * @param trainData a trainData\n+ * @param responses a responses\n+ * @param varIdx a varIdx\n+ * @param sampleIdx a sampleIdx\n+ * @param params a params\n+ *\n+ * @see <a href=\"http://docs.opencv.org/modules/ml/doc/support_vector_machines.html#cvsvm-train\">org.opencv.ml.CvSVM.train</a>\n+ */\n+ public boolean train(Mat trainData, Mat responses, Mat varIdx, Mat sampleIdx, CvSVMParams params)\n+ {\n+\n+ boolean retVal = train_0(nativeObj, trainData.nativeObj, responses.nativeObj, varIdx.nativeObj, sampleIdx.nativeObj, params.nativeObj);\n+\n+ return retVal;\n+ }\n+\n+/**\n+ * <p>Trains an SVM.</p>\n+ *\n+ * <p>The method trains the SVM model. It follows the conventions of the generic\n+ * \"CvStatModel.train\" approach with the following limitations:</p>\n+ * <ul>\n+ * <li> Only the <code>CV_ROW_SAMPLE</code> data layout is supported.\n+ * <li> Input variables are all ordered.\n+ * <li> Output variables can be either categorical (<code>params.svm_type=CvSVM.C_SVC</code>\n+ * or <code>params.svm_type=CvSVM.NU_SVC</code>), or ordered (<code>params.svm_type=CvSVM.EPS_SVR</code>\n+ * or <code>params.svm_type=CvSVM.NU_SVR</code>), or not required at all\n+ * (<code>params.svm_type=CvSVM.ONE_CLASS</code>).\n+ * <li> Missing measurements are not supported.\n+ * </ul>\n+ *\n+ * <p>All the other parameters are gathered in the \"CvSVMParams\" structure.</p>\n+ *\n+ * @param trainData a trainData\n+ * @param responses a responses\n+ *\n+ * @see <a href=\"http://docs.opencv.org/modules/ml/doc/support_vector_machines.html#cvsvm-train\">org.opencv.ml.CvSVM.train</a>\n+ */\n+ public boolean train(Mat trainData, Mat responses)\n+ {\n+\n+ boolean retVal = train_1(nativeObj, trainData.nativeObj, responses.nativeObj);\n+\n+ return retVal;\n+ }\n+\n+\n+ //\n+ // C++: bool CvSVM::train_auto(Mat trainData, Mat responses, Mat varIdx, Mat sampleIdx, CvSVMParams params, int k_fold = 10, CvParamGrid Cgrid = CvSVM::get_default_grid(CvSVM::C), CvParamGrid gammaGrid = CvSVM::get_default_grid(CvSVM::GAMMA), CvParamGrid pGrid = CvSVM::get_default_grid(CvSVM::P), CvParamGrid nuGrid = CvSVM::get_default_grid(CvSVM::NU), CvParamGrid coeffGrid = CvSVM::get_default_grid(CvSVM::COEF), CvParamGrid degreeGrid = CvSVM::get_default_grid(CvSVM::DEGREE), bool balanced = false)\n+ //\n+\n+/**\n+ * <p>Trains an SVM with optimal parameters.</p>\n+ *\n+ * <p>The method trains the SVM model automatically by choosing the optimal\n+ * parameters <code>C</code>, <code>gamma</code>, <code>p</code>,\n+ * <code>nu</code>, <code>coef0</code>, <code>degree</code> from \"CvSVMParams\".\n+ * Parameters are considered optimal when the cross-validation estimate of the\n+ * test set error is minimal.</p>\n+ *\n+ * <p>If there is no need to optimize a parameter, the corresponding grid step\n+ * should be set to any value less than or equal to 1. For example, to avoid\n+ * optimization in <code>gamma</code>, set <code>gamma_grid.step = 0</code>,\n+ * <code>gamma_grid.min_val</code>, <code>gamma_grid.max_val</code> as arbitrary\n+ * numbers. In this case, the value <code>params.gamma</code> is taken for\n+ * <code>gamma</code>.</p>\n+ *\n+ * <p>And, finally, if the optimization in a parameter is required but the\n+ * corresponding grid is unknown, you may call the function \"CvSVM.get_default_grid\".\n+ * To generate a grid, for example, for <code>gamma</code>, call\n+ * <code>CvSVM.get_default_grid(CvSVM.GAMMA)</code>.</p>\n+ *\n+ * <p>This function works for the classification (<code>params.svm_type=CvSVM.C_SVC</code>\n+ * or <code>params.svm_type=CvSVM.NU_SVC</code>) as well as for the regression\n+ * (<code>params.svm_type=CvSVM.EPS_SVR</code> or <code>params.svm_type=CvSVM.NU_SVR</code>).\n+ * If <code>params.svm_type=CvSVM.ONE_CLASS</code>, no optimization is made and\n+ * the usual SVM with parameters specified in <code>params</code> is executed.</p>\n+ *\n+ * @param trainData a trainData\n+ * @param responses a responses\n+ * @param varIdx a varIdx\n+ * @param sampleIdx a sampleIdx\n+ * @param params a params\n+ * @param k_fold Cross-validation parameter. The training set is divided into\n+ * <code>k_fold</code> subsets. One subset is used to test the model, the others\n+ * form the train set. So, the SVM algorithm is executed <code>k_fold</code>\n+ * times.\n+ * @param Cgrid a Cgrid\n+ * @param gammaGrid Iteration grid for the corresponding SVM parameter.\n+ * @param pGrid Iteration grid for the corresponding SVM parameter.\n+ * @param nuGrid Iteration grid for the corresponding SVM parameter.\n+ * @param coeffGrid Iteration grid for the corresponding SVM parameter.\n+ * @param degreeGrid Iteration grid for the corresponding SVM parameter.\n+ * @param balanced If <code>true</code> and the problem is 2-class\n+ * classification then the method creates more balanced cross-validation subsets\n+ * that is proportions between classes in subsets are close to such proportion\n+ * in the whole train dataset.\n+ *\n+ * @see <a href=\"http://docs.opencv.org/modules/ml/doc/support_vector_machines.html#cvsvm-train-auto\">org.opencv.ml.CvSVM.train_auto</a>\n+ */\n+ public boolean train_auto(Mat trainData, Mat responses, Mat varIdx, Mat sampleIdx, CvSVMParams params, int k_fold, CvParamGrid Cgrid, CvParamGrid gammaGrid, CvParamGrid pGrid, CvParamGrid nuGrid, CvParamGrid coeffGrid, CvParamGrid degreeGrid, boolean balanced)\n+ {\n+\n+ boolean retVal = train_auto_0(nativeObj, trainData.nativeObj, responses.nativeObj, varIdx.nativeObj, sampleIdx.nativeObj, params.nativeObj, k_fold, Cgrid.nativeObj, gammaGrid.nativeObj, pGrid.nativeObj, nuGrid.nativeObj, coeffGrid.nativeObj, degreeGrid.nativeObj, balanced);\n+\n+ return retVal;\n+ }\n+\n+/**\n+ * <p>Trains an SVM with optimal parameters.</p>\n+ *\n+ * <p>The method trains the SVM model automatically by choosing the optimal\n+ * parameters <code>C</code>, <code>gamma</code>, <code>p</code>,\n+ * <code>nu</code>, <code>coef0</code>, <code>degree</code> from \"CvSVMParams\".\n+ * Parameters are considered optimal when the cross-validation estimate of the\n+ * test set error is minimal.</p>\n+ *\n+ * <p>If there is no need to optimize a parameter, the corresponding grid step\n+ * should be set to any value less than or equal to 1. For example, to avoid\n+ * optimization in <code>gamma</code>, set <code>gamma_grid.step = 0</code>,\n+ * <code>gamma_grid.min_val</code>, <code>gamma_grid.max_val</code> as arbitrary\n+ * numbers. In this case, the value <code>params.gamma</code> is taken for\n+ * <code>gamma</code>.</p>\n+ *\n+ * <p>And, finally, if the optimization in a parameter is required but the\n+ * corresponding grid is unknown, you may call the function \"CvSVM.get_default_grid\".\n+ * To generate a grid, for example, for <code>gamma</code>, call\n+ * <code>CvSVM.get_default_grid(CvSVM.GAMMA)</code>.</p>\n+ *\n+ * <p>This function works for the classification (<code>params.svm_type=CvSVM.C_SVC</code>\n+ * or <code>params.svm_type=CvSVM.NU_SVC</code>) as well as for the regression\n+ * (<code>params.svm_type=CvSVM.EPS_SVR</code> or <code>params.svm_type=CvSVM.NU_SVR</code>).\n+ * If <code>params.svm_type=CvSVM.ONE_CLASS</code>, no optimization is made and\n+ * the usual SVM with parameters specified in <code>params</code> is executed.</p>\n+ *\n+ * @param trainData a trainData\n+ * @param responses a responses\n+ * @param varIdx a varIdx\n+ * @param sampleIdx a sampleIdx\n+ * @param params a params\n+ *\n+ * @see <a href=\"http://docs.opencv.org/modules/ml/doc/support_vector_machines.html#cvsvm-train-auto\">org.opencv.ml.CvSVM.train_auto</a>\n+ */\n+ public boolean train_auto(Mat trainData, Mat responses, Mat varIdx, Mat sampleIdx, CvSVMParams params)\n+ {\n+\n+ boolean retVal = train_auto_1(nativeObj, trainData.nativeObj, responses.nativeObj, varIdx.nativeObj, sampleIdx.nativeObj, params.nativeObj);\n+\n+ return retVal;\n+ }\n+\n+\n+ @Override\n+ protected void finalize() throws Throwable {\n+ delete(nativeObj);\n+ }\n+\n+\n+\n+ // C++: CvSVM::CvSVM()\n+ private static native long CvSVM_0();","path":"openCVLibrary24133/src/main/java/org/opencv/ml/CvSVM.java","position":419,"original_position":419,"commit_id":"79d39d13652cf0a03b0a5694dd7fa41411c69f7f","original_commit_id":"79d39d13652cf0a03b0a5694dd7fa41411c69f7f","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Method names should not contain underscores](https://www.codacy.com/app/harshithdwivedi/phimpme-android/pullRequest?prid=838106)","created_at":"2017-08-14T07:55:39Z","updated_at":"2017-08-14T07:55:39Z","html_url":"https://github.com/fossasia/phimpme-android/pull/1018#discussion_r132891564","pull_request_url":"https://api.github.com/repos/fossasia/phimpme-android/pulls/1018","_links":{"self":{"href":"https://api.github.com/repos/fossasia/phimpme-android/pulls/comments/132891564"},"html":{"href":"https://github.com/fossasia/phimpme-android/pull/1018#discussion_r132891564"},"pull_request":{"href":"https://api.github.com/repos/fossasia/phimpme-android/pulls/1018"}}},"pull_request":{"url":"https://api.github.com/repos/fossasia/phimpme-android/pulls/1018","id":135496644,"html_url":"https://github.com/fossasia/phimpme-android/pull/1018","diff_url":"https://github.com/fossasia/phimpme-android/pull/1018.diff","patch_url":"https://github.com/fossasia/phimpme-android/pull/1018.patch","issue_url":"https://api.github.com/repos/fossasia/phimpme-android/issues/1018","number":1018,"state":"open","locked":false,"title":"Reduced apk size and created single apk","user":{"login":"vinaysajjanapu","id":15368561,"avatar_url":"https://avatars3.githubusercontent.com/u/15368561?v=4","gravatar_id":"","url":"https://api.github.com/users/vinaysajjanapu","html_url":"https://github.com/vinaysajjanapu","followers_url":"https://api.github.com/users/vinaysajjanapu/followers","following_url":"https://api.github.com/users/vinaysajjanapu/following{/other_user}","gists_url":"https://api.github.com/users/vinaysajjanapu/gists{/gist_id}","starred_url":"https://api.github.com/users/vinaysajjanapu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinaysajjanapu/subscriptions","organizations_url":"https://api.github.com/users/vinaysajjanapu/orgs","repos_url":"https://api.github.com/users/vinaysajjanapu/repos","events_url":"https://api.github.com/users/vinaysajjanapu/events{/privacy}","received_events_url":"https://api.github.com/users/vinaysajjanapu/received_events","type":"User","site_admin":false},"body":"Fix #1016 \r\nChanges: \r\nChanged the variant of opencv\r\nremoved additional support for overlapping platforms and mips cpu","created_at":"2017-08-13T14:51:28Z","updated_at":"2017-08-14T07:55:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad67dd232b13b0157be1a21e46a31f4cc3deaa59","assignee":{"login":"vinaysajjanapu","id":15368561,"avatar_url":"https://avatars3.githubusercontent.com/u/15368561?v=4","gravatar_id":"","url":"https://api.github.com/users/vinaysajjanapu","html_url":"https://github.com/vinaysajjanapu","followers_url":"https://api.github.com/users/vinaysajjanapu/followers","following_url":"https://api.github.com/users/vinaysajjanapu/following{/other_user}","gists_url":"https://api.github.com/users/vinaysajjanapu/gists{/gist_id}","starred_url":"https://api.github.com/users/vinaysajjanapu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinaysajjanapu/subscriptions","organizations_url":"https://api.github.com/users/vinaysajjanapu/orgs","repos_url":"https://api.github.com/users/vinaysajjanapu/repos","events_url":"https://api.github.com/users/vinaysajjanapu/events{/privacy}","received_events_url":"https://api.github.com/users/vinaysajjanapu/received_events","type":"User","site_admin":false},"assignees":[{"login":"vinaysajjanapu","id":15368561,"avatar_url":"https://avatars3.githubusercontent.com/u/15368561?v=4","gravatar_id":"","url":"https://api.github.com/users/vinaysajjanapu","html_url":"https://github.com/vinaysajjanapu","followers_url":"https://api.github.com/users/vinaysajjanapu/followers","following_url":"https://api.github.com/users/vinaysajjanapu/following{/other_user}","gists_url":"https://api.github.com/users/vinaysajjanapu/gists{/gist_id}","starred_url":"https://api.github.com/users/vinaysajjanapu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinaysajjanapu/subscriptions","organizations_url":"https://api.github.com/users/vinaysajjanapu/orgs","repos_url":"https://api.github.com/users/vinaysajjanapu/repos","events_url":"https://api.github.com/users/vinaysajjanapu/events{/privacy}","received_events_url":"https://api.github.com/users/vinaysajjanapu/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"pa1pal","id":6936968,"avatar_url":"https://avatars3.githubusercontent.com/u/6936968?v=4","gravatar_id":"","url":"https://api.github.com/users/pa1pal","html_url":"https://github.com/pa1pal","followers_url":"https://api.github.com/users/pa1pal/followers","following_url":"https://api.github.com/users/pa1pal/following{/other_user}","gists_url":"https://api.github.com/users/pa1pal/gists{/gist_id}","starred_url":"https://api.github.com/users/pa1pal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pa1pal/subscriptions","organizations_url":"https://api.github.com/users/pa1pal/orgs","repos_url":"https://api.github.com/users/pa1pal/repos","events_url":"https://api.github.com/users/pa1pal/events{/privacy}","received_events_url":"https://api.github.com/users/pa1pal/received_events","type":"User","site_admin":false},{"login":"mohitmanuja","id":9361754,"avatar_url":"https://avatars0.githubusercontent.com/u/9361754?v=4","gravatar_id":"","url":"https://api.github.com/users/mohitmanuja","html_url":"https://github.com/mohitmanuja","followers_url":"https://api.github.com/users/mohitmanuja/followers","following_url":"https://api.github.com/users/mohitmanuja/following{/other_user}","gists_url":"https://api.github.com/users/mohitmanuja/gists{/gist_id}","starred_url":"https://api.github.com/users/mohitmanuja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohitmanuja/subscriptions","organizations_url":"https://api.github.com/users/mohitmanuja/orgs","repos_url":"https://api.github.com/users/mohitmanuja/repos","events_url":"https://api.github.com/users/mohitmanuja/events{/privacy}","received_events_url":"https://api.github.com/users/mohitmanuja/received_events","type":"User","site_admin":false},{"login":"Subhankar29","id":17337006,"avatar_url":"https://avatars3.githubusercontent.com/u/17337006?v=4","gravatar_id":"","url":"https://api.github.com/users/Subhankar29","html_url":"https://github.com/Subhankar29","followers_url":"https://api.github.com/users/Subhankar29/followers","following_url":"https://api.github.com/users/Subhankar29/following{/other_user}","gists_url":"https://api.github.com/users/Subhankar29/gists{/gist_id}","starred_url":"https://api.github.com/users/Subhankar29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subhankar29/subscriptions","organizations_url":"https://api.github.com/users/Subhankar29/orgs","repos_url":"https://api.github.com/users/Subhankar29/repos","events_url":"https://api.github.com/users/Subhankar29/events{/privacy}","received_events_url":"https://api.github.com/users/Subhankar29/received_events","type":"User","site_admin":false},{"login":"anantprsd5","id":20367966,"avatar_url":"https://avatars1.githubusercontent.com/u/20367966?v=4","gravatar_id":"","url":"https://api.github.com/users/anantprsd5","html_url":"https://github.com/anantprsd5","followers_url":"https://api.github.com/users/anantprsd5/followers","following_url":"https://api.github.com/users/anantprsd5/following{/other_user}","gists_url":"https://api.github.com/users/anantprsd5/gists{/gist_id}","starred_url":"https://api.github.com/users/anantprsd5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anantprsd5/subscriptions","organizations_url":"https://api.github.com/users/anantprsd5/orgs","repos_url":"https://api.github.com/users/anantprsd5/repos","events_url":"https://api.github.com/users/anantprsd5/events{/privacy}","received_events_url":"https://api.github.com/users/anantprsd5/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/fossasia/phimpme-android/milestones/16","html_url":"https://github.com/fossasia/phimpme-android/milestone/16","labels_url":"https://api.github.com/repos/fossasia/phimpme-android/milestones/16/labels","id":2697852,"number":16,"title":"Milestone 15 (GSoC 2017)","description":"Instructions: * Create issues to work on * Assign the issue to the milestone * Assign the issue to a user (yourself) * Tag a release * Deploy on a server * Completed Milestone: Create a blog post describing what has been done","creator":{"login":"pa1pal","id":6936968,"avatar_url":"https://avatars3.githubusercontent.com/u/6936968?v=4","gravatar_id":"","url":"https://api.github.com/users/pa1pal","html_url":"https://github.com/pa1pal","followers_url":"https://api.github.com/users/pa1pal/followers","following_url":"https://api.github.com/users/pa1pal/following{/other_user}","gists_url":"https://api.github.com/users/pa1pal/gists{/gist_id}","starred_url":"https://api.github.com/users/pa1pal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pa1pal/subscriptions","organizations_url":"https://api.github.com/users/pa1pal/orgs","repos_url":"https://api.github.com/users/pa1pal/repos","events_url":"https://api.github.com/users/pa1pal/events{/privacy}","received_events_url":"https://api.github.com/users/pa1pal/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":0,"state":"open","created_at":"2017-08-12T15:44:16Z","updated_at":"2017-08-14T04:12:10Z","due_on":"2017-08-20T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/fossasia/phimpme-android/pulls/1018/commits","review_comments_url":"https://api.github.com/repos/fossasia/phimpme-android/pulls/1018/comments","review_comment_url":"https://api.github.com/repos/fossasia/phimpme-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fossasia/phimpme-android/issues/1018/comments","statuses_url":"https://api.github.com/repos/fossasia/phimpme-android/statuses/79d39d13652cf0a03b0a5694dd7fa41411c69f7f","head":{"label":"vinaysajjanapu:apksize","ref":"apksize","sha":"79d39d13652cf0a03b0a5694dd7fa41411c69f7f","user":{"login":"vinaysajjanapu","id":15368561,"avatar_url":"https://avatars3.githubusercontent.com/u/15368561?v=4","gravatar_id":"","url":"https://api.github.com/users/vinaysajjanapu","html_url":"https://github.com/vinaysajjanapu","followers_url":"https://api.github.com/users/vinaysajjanapu/followers","following_url":"https://api.github.com/users/vinaysajjanapu/following{/other_user}","gists_url":"https://api.github.com/users/vinaysajjanapu/gists{/gist_id}","starred_url":"https://api.github.com/users/vinaysajjanapu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinaysajjanapu/subscriptions","organizations_url":"https://api.github.com/users/vinaysajjanapu/orgs","repos_url":"https://api.github.com/users/vinaysajjanapu/repos","events_url":"https://api.github.com/users/vinaysajjanapu/events{/privacy}","received_events_url":"https://api.github.com/users/vinaysajjanapu/received_events","type":"User","site_admin":false},"repo":{"id":87229157,"name":"phimpme-android","full_name":"vinaysajjanapu/phimpme-android","owner":{"login":"vinaysajjanapu","id":15368561,"avatar_url":"https://avatars3.githubusercontent.com/u/15368561?v=4","gravatar_id":"","url":"https://api.github.com/users/vinaysajjanapu","html_url":"https://github.com/vinaysajjanapu","followers_url":"https://api.github.com/users/vinaysajjanapu/followers","following_url":"https://api.github.com/users/vinaysajjanapu/following{/other_user}","gists_url":"https://api.github.com/users/vinaysajjanapu/gists{/gist_id}","starred_url":"https://api.github.com/users/vinaysajjanapu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinaysajjanapu/subscriptions","organizations_url":"https://api.github.com/users/vinaysajjanapu/orgs","repos_url":"https://api.github.com/users/vinaysajjanapu/repos","events_url":"https://api.github.com/users/vinaysajjanapu/events{/privacy}","received_events_url":"https://api.github.com/users/vinaysajjanapu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vinaysajjanapu/phimpme-android","description":"Phimp.me - Photo App https://github.com/fossasia/phimpme-android/raw/apk/app-debug.apk","fork":true,"url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android","forks_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/forks","keys_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/teams","hooks_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/hooks","issue_events_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/issues/events{/number}","events_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/events","assignees_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/assignees{/user}","branches_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/branches{/branch}","tags_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/tags","blobs_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/statuses/{sha}","languages_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/languages","stargazers_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/stargazers","contributors_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/contributors","subscribers_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/subscribers","subscription_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/subscription","commits_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/contents/{+path}","compare_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/merges","archive_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/downloads","issues_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/issues{/number}","pulls_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/pulls{/number}","milestones_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/milestones{/number}","notifications_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/labels{/name}","releases_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/releases{/id}","deployments_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/deployments","created_at":"2017-04-04T19:56:35Z","updated_at":"2017-07-08T20:27:00Z","pushed_at":"2017-08-14T07:51:12Z","git_url":"git://github.com/vinaysajjanapu/phimpme-android.git","ssh_url":"[email protected]:vinaysajjanapu/phimpme-android.git","clone_url":"https://github.com/vinaysajjanapu/phimpme-android.git","svn_url":"https://github.com/vinaysajjanapu/phimpme-android","homepage":"http://phimp.me","size":157192,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"fossasia:development","ref":"development","sha":"68598c7ff947a7f594ad494ccb032ece569d2029","user":{"login":"fossasia","id":6295529,"avatar_url":"https://avatars3.githubusercontent.com/u/6295529?v=4","gravatar_id":"","url":"https://api.github.com/users/fossasia","html_url":"https://github.com/fossasia","followers_url":"https://api.github.com/users/fossasia/followers","following_url":"https://api.github.com/users/fossasia/following{/other_user}","gists_url":"https://api.github.com/users/fossasia/gists{/gist_id}","starred_url":"https://api.github.com/users/fossasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossasia/subscriptions","organizations_url":"https://api.github.com/users/fossasia/orgs","repos_url":"https://api.github.com/users/fossasia/repos","events_url":"https://api.github.com/users/fossasia/events{/privacy}","received_events_url":"https://api.github.com/users/fossasia/received_events","type":"Organization","site_admin":false},"repo":{"id":5713702,"name":"phimpme-android","full_name":"fossasia/phimpme-android","owner":{"login":"fossasia","id":6295529,"avatar_url":"https://avatars3.githubusercontent.com/u/6295529?v=4","gravatar_id":"","url":"https://api.github.com/users/fossasia","html_url":"https://github.com/fossasia","followers_url":"https://api.github.com/users/fossasia/followers","following_url":"https://api.github.com/users/fossasia/following{/other_user}","gists_url":"https://api.github.com/users/fossasia/gists{/gist_id}","starred_url":"https://api.github.com/users/fossasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossasia/subscriptions","organizations_url":"https://api.github.com/users/fossasia/orgs","repos_url":"https://api.github.com/users/fossasia/repos","events_url":"https://api.github.com/users/fossasia/events{/privacy}","received_events_url":"https://api.github.com/users/fossasia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fossasia/phimpme-android","description":"Phimp.me - Photo App http://phimp.me","fork":false,"url":"https://api.github.com/repos/fossasia/phimpme-android","forks_url":"https://api.github.com/repos/fossasia/phimpme-android/forks","keys_url":"https://api.github.com/repos/fossasia/phimpme-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fossasia/phimpme-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fossasia/phimpme-android/teams","hooks_url":"https://api.github.com/repos/fossasia/phimpme-android/hooks","issue_events_url":"https://api.github.com/repos/fossasia/phimpme-android/issues/events{/number}","events_url":"https://api.github.com/repos/fossasia/phimpme-android/events","assignees_url":"https://api.github.com/repos/fossasia/phimpme-android/assignees{/user}","branches_url":"https://api.github.com/repos/fossasia/phimpme-android/branches{/branch}","tags_url":"https://api.github.com/repos/fossasia/phimpme-android/tags","blobs_url":"https://api.github.com/repos/fossasia/phimpme-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fossasia/phimpme-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fossasia/phimpme-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/fossasia/phimpme-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fossasia/phimpme-android/statuses/{sha}","languages_url":"https://api.github.com/repos/fossasia/phimpme-android/languages","stargazers_url":"https://api.github.com/repos/fossasia/phimpme-android/stargazers","contributors_url":"https://api.github.com/repos/fossasia/phimpme-android/contributors","subscribers_url":"https://api.github.com/repos/fossasia/phimpme-android/subscribers","subscription_url":"https://api.github.com/repos/fossasia/phimpme-android/subscription","commits_url":"https://api.github.com/repos/fossasia/phimpme-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/fossasia/phimpme-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/fossasia/phimpme-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/fossasia/phimpme-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/fossasia/phimpme-android/contents/{+path}","compare_url":"https://api.github.com/repos/fossasia/phimpme-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fossasia/phimpme-android/merges","archive_url":"https://api.github.com/repos/fossasia/phimpme-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fossasia/phimpme-android/downloads","issues_url":"https://api.github.com/repos/fossasia/phimpme-android/issues{/number}","pulls_url":"https://api.github.com/repos/fossasia/phimpme-android/pulls{/number}","milestones_url":"https://api.github.com/repos/fossasia/phimpme-android/milestones{/number}","notifications_url":"https://api.github.com/repos/fossasia/phimpme-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fossasia/phimpme-android/labels{/name}","releases_url":"https://api.github.com/repos/fossasia/phimpme-android/releases{/id}","deployments_url":"https://api.github.com/repos/fossasia/phimpme-android/deployments","created_at":"2012-09-07T07:14:54Z","updated_at":"2017-08-12T17:18:16Z","pushed_at":"2017-08-14T07:51:13Z","git_url":"git://github.com/fossasia/phimpme-android.git","ssh_url":"[email protected]:fossasia/phimpme-android.git","clone_url":"https://github.com/fossasia/phimpme-android.git","svn_url":"https://github.com/fossasia/phimpme-android","homepage":"","size":180096,"stargazers_count":107,"watchers_count":107,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":116,"mirror_url":null,"open_issues_count":25,"forks":116,"open_issues":25,"watchers":107,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/fossasia/phimpme-android/pulls/1018"},"html":{"href":"https://github.com/fossasia/phimpme-android/pull/1018"},"issue":{"href":"https://api.github.com/repos/fossasia/phimpme-android/issues/1018"},"comments":{"href":"https://api.github.com/repos/fossasia/phimpme-android/issues/1018/comments"},"review_comments":{"href":"https://api.github.com/repos/fossasia/phimpme-android/pulls/1018/comments"},"review_comment":{"href":"https://api.github.com/repos/fossasia/phimpme-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fossasia/phimpme-android/pulls/1018/commits"},"statuses":{"href":"https://api.github.com/repos/fossasia/phimpme-android/statuses/79d39d13652cf0a03b0a5694dd7fa41411c69f7f"}}}} | {
"id": 5713702,
"name": "fossasia/phimpme-android",
"url": "https://api.github.com/repos/fossasia/phimpme-android"
} | {
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
} | {
"id": 6295529,
"login": "fossasia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6295529?",
"url": "https://api.github.com/orgs/fossasia"
} | 2017-08-14T07:55:39 | 6447556563 | {"actor":{"display_login":"codacy-bot"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/fossasia/phimpme-android/pulls/comments/127962490","pull_request_review_id":50595670,"id":127962490,"diff_hunk":"@@ -0,0 +1,67 @@\n+package org.fossasia.phimpme.sharetoflickr;\n+\n+import com.googlecode.flickrjandroid.Flickr;\n+import com.googlecode.flickrjandroid.REST;\n+import com.googlecode.flickrjandroid.RequestContext;\n+import com.googlecode.flickrjandroid.interestingness.InterestingnessInterface;\n+import com.googlecode.flickrjandroid.oauth.OAuth;\n+import com.googlecode.flickrjandroid.oauth.OAuthToken;\n+import com.googlecode.flickrjandroid.photos.PhotosInterface;\n+\n+import javax.xml.parsers.ParserConfigurationException;\n+\n+public final class FlickrHelper {\n+\n+\tprivate static FlickrHelper instance = null;\n+\tprivate static final String API_KEY = \"4837a3356cf697f7ef6c8b287297f19a\";","path":"app/src/main/java/org/fossasia/phimpme/sharetoflickr/FlickrHelper.java","position":16,"original_position":16,"commit_id":"38fc7e9d9cc1c09b693644393633aec8f71ce9ce","original_commit_id":"38fc7e9d9cc1c09b693644393633aec8f71ce9ce","user":{"login":"vinaysajjanapu","id":15368561,"avatar_url":"https://avatars3.githubusercontent.com/u/15368561?v=4","gravatar_id":"","url":"https://api.github.com/users/vinaysajjanapu","html_url":"https://github.com/vinaysajjanapu","followers_url":"https://api.github.com/users/vinaysajjanapu/followers","following_url":"https://api.github.com/users/vinaysajjanapu/following{/other_user}","gists_url":"https://api.github.com/users/vinaysajjanapu/gists{/gist_id}","starred_url":"https://api.github.com/users/vinaysajjanapu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinaysajjanapu/subscriptions","organizations_url":"https://api.github.com/users/vinaysajjanapu/orgs","repos_url":"https://api.github.com/users/vinaysajjanapu/repos","events_url":"https://api.github.com/users/vinaysajjanapu/events{/privacy}","received_events_url":"https://api.github.com/users/vinaysajjanapu/received_events","type":"User","site_admin":false},"body":"@the-dagger Wouldn't it be better if we remove the API keys when shifting code to master branch? As it will be easier for testing in development branch for other members of phimpme. they don't need to request api keys just to test the feature. Please suggest.\n\n_Sent from my Xiaomi Redmi Note 4 using [FastHub](https://play.google.com/store/apps/details?id=com.fastaccess.github)_","created_at":"2017-07-18T12:39:54Z","updated_at":"2017-07-18T12:39:54Z","html_url":"https://github.com/fossasia/phimpme-android/pull/820#discussion_r127962490","pull_request_url":"https://api.github.com/repos/fossasia/phimpme-android/pulls/820","_links":{"self":{"href":"https://api.github.com/repos/fossasia/phimpme-android/pulls/comments/127962490"},"html":{"href":"https://github.com/fossasia/phimpme-android/pull/820#discussion_r127962490"},"pull_request":{"href":"https://api.github.com/repos/fossasia/phimpme-android/pulls/820"}}},"pull_request":{"url":"https://api.github.com/repos/fossasia/phimpme-android/pulls/820","id":130959065,"html_url":"https://github.com/fossasia/phimpme-android/pull/820","diff_url":"https://github.com/fossasia/phimpme-android/pull/820.diff","patch_url":"https://github.com/fossasia/phimpme-android/pull/820.patch","issue_url":"https://api.github.com/repos/fossasia/phimpme-android/issues/820","number":820,"state":"open","locked":false,"title":"Added share image to Flickr feature","user":{"login":"vinaysajjanapu","id":15368561,"avatar_url":"https://avatars3.githubusercontent.com/u/15368561?v=4","gravatar_id":"","url":"https://api.github.com/users/vinaysajjanapu","html_url":"https://github.com/vinaysajjanapu","followers_url":"https://api.github.com/users/vinaysajjanapu/followers","following_url":"https://api.github.com/users/vinaysajjanapu/following{/other_user}","gists_url":"https://api.github.com/users/vinaysajjanapu/gists{/gist_id}","starred_url":"https://api.github.com/users/vinaysajjanapu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinaysajjanapu/subscriptions","organizations_url":"https://api.github.com/users/vinaysajjanapu/orgs","repos_url":"https://api.github.com/users/vinaysajjanapu/repos","events_url":"https://api.github.com/users/vinaysajjanapu/events{/privacy}","received_events_url":"https://api.github.com/users/vinaysajjanapu/received_events","type":"User","site_admin":false},"body":"Fix #809 \r\n\r\nChanges: Added functions and tasks for authenticating and sharing image to flickr.\r\n\r\nTesting:\r\nAdd account by clicking Flickr item in account activity.\r\nThen click Flickr in sharing activity.","created_at":"2017-07-17T21:46:26Z","updated_at":"2017-07-18T12:39:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79477d8e1ca83c13b75b77fb4a85f071ce68f409","assignee":{"login":"vinaysajjanapu","id":15368561,"avatar_url":"https://avatars3.githubusercontent.com/u/15368561?v=4","gravatar_id":"","url":"https://api.github.com/users/vinaysajjanapu","html_url":"https://github.com/vinaysajjanapu","followers_url":"https://api.github.com/users/vinaysajjanapu/followers","following_url":"https://api.github.com/users/vinaysajjanapu/following{/other_user}","gists_url":"https://api.github.com/users/vinaysajjanapu/gists{/gist_id}","starred_url":"https://api.github.com/users/vinaysajjanapu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinaysajjanapu/subscriptions","organizations_url":"https://api.github.com/users/vinaysajjanapu/orgs","repos_url":"https://api.github.com/users/vinaysajjanapu/repos","events_url":"https://api.github.com/users/vinaysajjanapu/events{/privacy}","received_events_url":"https://api.github.com/users/vinaysajjanapu/received_events","type":"User","site_admin":false},"assignees":[{"login":"vinaysajjanapu","id":15368561,"avatar_url":"https://avatars3.githubusercontent.com/u/15368561?v=4","gravatar_id":"","url":"https://api.github.com/users/vinaysajjanapu","html_url":"https://github.com/vinaysajjanapu","followers_url":"https://api.github.com/users/vinaysajjanapu/followers","following_url":"https://api.github.com/users/vinaysajjanapu/following{/other_user}","gists_url":"https://api.github.com/users/vinaysajjanapu/gists{/gist_id}","starred_url":"https://api.github.com/users/vinaysajjanapu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinaysajjanapu/subscriptions","organizations_url":"https://api.github.com/users/vinaysajjanapu/orgs","repos_url":"https://api.github.com/users/vinaysajjanapu/repos","events_url":"https://api.github.com/users/vinaysajjanapu/events{/privacy}","received_events_url":"https://api.github.com/users/vinaysajjanapu/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"pa1pal","id":6936968,"avatar_url":"https://avatars3.githubusercontent.com/u/6936968?v=4","gravatar_id":"","url":"https://api.github.com/users/pa1pal","html_url":"https://github.com/pa1pal","followers_url":"https://api.github.com/users/pa1pal/followers","following_url":"https://api.github.com/users/pa1pal/following{/other_user}","gists_url":"https://api.github.com/users/pa1pal/gists{/gist_id}","starred_url":"https://api.github.com/users/pa1pal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pa1pal/subscriptions","organizations_url":"https://api.github.com/users/pa1pal/orgs","repos_url":"https://api.github.com/users/pa1pal/repos","events_url":"https://api.github.com/users/pa1pal/events{/privacy}","received_events_url":"https://api.github.com/users/pa1pal/received_events","type":"User","site_admin":false},{"login":"mohitmanuja","id":9361754,"avatar_url":"https://avatars0.githubusercontent.com/u/9361754?v=4","gravatar_id":"","url":"https://api.github.com/users/mohitmanuja","html_url":"https://github.com/mohitmanuja","followers_url":"https://api.github.com/users/mohitmanuja/followers","following_url":"https://api.github.com/users/mohitmanuja/following{/other_user}","gists_url":"https://api.github.com/users/mohitmanuja/gists{/gist_id}","starred_url":"https://api.github.com/users/mohitmanuja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohitmanuja/subscriptions","organizations_url":"https://api.github.com/users/mohitmanuja/orgs","repos_url":"https://api.github.com/users/mohitmanuja/repos","events_url":"https://api.github.com/users/mohitmanuja/events{/privacy}","received_events_url":"https://api.github.com/users/mohitmanuja/received_events","type":"User","site_admin":false},{"login":"Subhankar29","id":17337006,"avatar_url":"https://avatars3.githubusercontent.com/u/17337006?v=4","gravatar_id":"","url":"https://api.github.com/users/Subhankar29","html_url":"https://github.com/Subhankar29","followers_url":"https://api.github.com/users/Subhankar29/followers","following_url":"https://api.github.com/users/Subhankar29/following{/other_user}","gists_url":"https://api.github.com/users/Subhankar29/gists{/gist_id}","starred_url":"https://api.github.com/users/Subhankar29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subhankar29/subscriptions","organizations_url":"https://api.github.com/users/Subhankar29/orgs","repos_url":"https://api.github.com/users/Subhankar29/repos","events_url":"https://api.github.com/users/Subhankar29/events{/privacy}","received_events_url":"https://api.github.com/users/Subhankar29/received_events","type":"User","site_admin":false},{"login":"anantprsd5","id":20367966,"avatar_url":"https://avatars1.githubusercontent.com/u/20367966?v=4","gravatar_id":"","url":"https://api.github.com/users/anantprsd5","html_url":"https://github.com/anantprsd5","followers_url":"https://api.github.com/users/anantprsd5/followers","following_url":"https://api.github.com/users/anantprsd5/following{/other_user}","gists_url":"https://api.github.com/users/anantprsd5/gists{/gist_id}","starred_url":"https://api.github.com/users/anantprsd5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anantprsd5/subscriptions","organizations_url":"https://api.github.com/users/anantprsd5/orgs","repos_url":"https://api.github.com/users/anantprsd5/repos","events_url":"https://api.github.com/users/anantprsd5/events{/privacy}","received_events_url":"https://api.github.com/users/anantprsd5/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/fossasia/phimpme-android/milestones/12","html_url":"https://github.com/fossasia/phimpme-android/milestone/12","labels_url":"https://api.github.com/repos/fossasia/phimpme-android/milestones/12/labels","id":2643556,"number":12,"title":"Milestone 11 (GSoC 2017)","description":"Instructions: * Create issues to work on * Assign the issue to the milestone * Assign the issue to a user (yourself) * Tag a release * Deploy on a server * Completed Milestone: Create a blog post describing what has been done","creator":{"login":"pa1pal","id":6936968,"avatar_url":"https://avatars3.githubusercontent.com/u/6936968?v=4","gravatar_id":"","url":"https://api.github.com/users/pa1pal","html_url":"https://github.com/pa1pal","followers_url":"https://api.github.com/users/pa1pal/followers","following_url":"https://api.github.com/users/pa1pal/following{/other_user}","gists_url":"https://api.github.com/users/pa1pal/gists{/gist_id}","starred_url":"https://api.github.com/users/pa1pal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pa1pal/subscriptions","organizations_url":"https://api.github.com/users/pa1pal/orgs","repos_url":"https://api.github.com/users/pa1pal/repos","events_url":"https://api.github.com/users/pa1pal/events{/privacy}","received_events_url":"https://api.github.com/users/pa1pal/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":9,"state":"open","created_at":"2017-07-16T18:35:38Z","updated_at":"2017-07-18T11:31:11Z","due_on":"2017-07-23T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/fossasia/phimpme-android/pulls/820/commits","review_comments_url":"https://api.github.com/repos/fossasia/phimpme-android/pulls/820/comments","review_comment_url":"https://api.github.com/repos/fossasia/phimpme-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fossasia/phimpme-android/issues/820/comments","statuses_url":"https://api.github.com/repos/fossasia/phimpme-android/statuses/38fc7e9d9cc1c09b693644393633aec8f71ce9ce","head":{"label":"vinaysajjanapu:flickr_share","ref":"flickr_share","sha":"38fc7e9d9cc1c09b693644393633aec8f71ce9ce","user":{"login":"vinaysajjanapu","id":15368561,"avatar_url":"https://avatars3.githubusercontent.com/u/15368561?v=4","gravatar_id":"","url":"https://api.github.com/users/vinaysajjanapu","html_url":"https://github.com/vinaysajjanapu","followers_url":"https://api.github.com/users/vinaysajjanapu/followers","following_url":"https://api.github.com/users/vinaysajjanapu/following{/other_user}","gists_url":"https://api.github.com/users/vinaysajjanapu/gists{/gist_id}","starred_url":"https://api.github.com/users/vinaysajjanapu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinaysajjanapu/subscriptions","organizations_url":"https://api.github.com/users/vinaysajjanapu/orgs","repos_url":"https://api.github.com/users/vinaysajjanapu/repos","events_url":"https://api.github.com/users/vinaysajjanapu/events{/privacy}","received_events_url":"https://api.github.com/users/vinaysajjanapu/received_events","type":"User","site_admin":false},"repo":{"id":87229157,"name":"phimpme-android","full_name":"vinaysajjanapu/phimpme-android","owner":{"login":"vinaysajjanapu","id":15368561,"avatar_url":"https://avatars3.githubusercontent.com/u/15368561?v=4","gravatar_id":"","url":"https://api.github.com/users/vinaysajjanapu","html_url":"https://github.com/vinaysajjanapu","followers_url":"https://api.github.com/users/vinaysajjanapu/followers","following_url":"https://api.github.com/users/vinaysajjanapu/following{/other_user}","gists_url":"https://api.github.com/users/vinaysajjanapu/gists{/gist_id}","starred_url":"https://api.github.com/users/vinaysajjanapu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinaysajjanapu/subscriptions","organizations_url":"https://api.github.com/users/vinaysajjanapu/orgs","repos_url":"https://api.github.com/users/vinaysajjanapu/repos","events_url":"https://api.github.com/users/vinaysajjanapu/events{/privacy}","received_events_url":"https://api.github.com/users/vinaysajjanapu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vinaysajjanapu/phimpme-android","description":"Phimp.me - Photo App https://github.com/fossasia/phimpme-android/raw/apk/app-debug.apk","fork":true,"url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android","forks_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/forks","keys_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/teams","hooks_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/hooks","issue_events_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/issues/events{/number}","events_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/events","assignees_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/assignees{/user}","branches_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/branches{/branch}","tags_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/tags","blobs_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/statuses/{sha}","languages_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/languages","stargazers_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/stargazers","contributors_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/contributors","subscribers_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/subscribers","subscription_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/subscription","commits_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/contents/{+path}","compare_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/merges","archive_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/downloads","issues_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/issues{/number}","pulls_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/pulls{/number}","milestones_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/milestones{/number}","notifications_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/labels{/name}","releases_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/releases{/id}","deployments_url":"https://api.github.com/repos/vinaysajjanapu/phimpme-android/deployments","created_at":"2017-04-04T19:56:35Z","updated_at":"2017-07-08T20:27:00Z","pushed_at":"2017-07-18T08:38:54Z","git_url":"git://github.com/vinaysajjanapu/phimpme-android.git","ssh_url":"[email protected]:vinaysajjanapu/phimpme-android.git","clone_url":"https://github.com/vinaysajjanapu/phimpme-android.git","svn_url":"https://github.com/vinaysajjanapu/phimpme-android","homepage":"http://phimp.me","size":154006,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"fossasia:development","ref":"development","sha":"1435e5a8d619c313ed9ad237d85204daec2e6cd1","user":{"login":"fossasia","id":6295529,"avatar_url":"https://avatars3.githubusercontent.com/u/6295529?v=4","gravatar_id":"","url":"https://api.github.com/users/fossasia","html_url":"https://github.com/fossasia","followers_url":"https://api.github.com/users/fossasia/followers","following_url":"https://api.github.com/users/fossasia/following{/other_user}","gists_url":"https://api.github.com/users/fossasia/gists{/gist_id}","starred_url":"https://api.github.com/users/fossasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossasia/subscriptions","organizations_url":"https://api.github.com/users/fossasia/orgs","repos_url":"https://api.github.com/users/fossasia/repos","events_url":"https://api.github.com/users/fossasia/events{/privacy}","received_events_url":"https://api.github.com/users/fossasia/received_events","type":"Organization","site_admin":false},"repo":{"id":5713702,"name":"phimpme-android","full_name":"fossasia/phimpme-android","owner":{"login":"fossasia","id":6295529,"avatar_url":"https://avatars3.githubusercontent.com/u/6295529?v=4","gravatar_id":"","url":"https://api.github.com/users/fossasia","html_url":"https://github.com/fossasia","followers_url":"https://api.github.com/users/fossasia/followers","following_url":"https://api.github.com/users/fossasia/following{/other_user}","gists_url":"https://api.github.com/users/fossasia/gists{/gist_id}","starred_url":"https://api.github.com/users/fossasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossasia/subscriptions","organizations_url":"https://api.github.com/users/fossasia/orgs","repos_url":"https://api.github.com/users/fossasia/repos","events_url":"https://api.github.com/users/fossasia/events{/privacy}","received_events_url":"https://api.github.com/users/fossasia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fossasia/phimpme-android","description":"Phimp.me - Photo App http://phimp.me","fork":false,"url":"https://api.github.com/repos/fossasia/phimpme-android","forks_url":"https://api.github.com/repos/fossasia/phimpme-android/forks","keys_url":"https://api.github.com/repos/fossasia/phimpme-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fossasia/phimpme-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fossasia/phimpme-android/teams","hooks_url":"https://api.github.com/repos/fossasia/phimpme-android/hooks","issue_events_url":"https://api.github.com/repos/fossasia/phimpme-android/issues/events{/number}","events_url":"https://api.github.com/repos/fossasia/phimpme-android/events","assignees_url":"https://api.github.com/repos/fossasia/phimpme-android/assignees{/user}","branches_url":"https://api.github.com/repos/fossasia/phimpme-android/branches{/branch}","tags_url":"https://api.github.com/repos/fossasia/phimpme-android/tags","blobs_url":"https://api.github.com/repos/fossasia/phimpme-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fossasia/phimpme-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fossasia/phimpme-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/fossasia/phimpme-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fossasia/phimpme-android/statuses/{sha}","languages_url":"https://api.github.com/repos/fossasia/phimpme-android/languages","stargazers_url":"https://api.github.com/repos/fossasia/phimpme-android/stargazers","contributors_url":"https://api.github.com/repos/fossasia/phimpme-android/contributors","subscribers_url":"https://api.github.com/repos/fossasia/phimpme-android/subscribers","subscription_url":"https://api.github.com/repos/fossasia/phimpme-android/subscription","commits_url":"https://api.github.com/repos/fossasia/phimpme-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/fossasia/phimpme-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/fossasia/phimpme-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/fossasia/phimpme-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/fossasia/phimpme-android/contents/{+path}","compare_url":"https://api.github.com/repos/fossasia/phimpme-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fossasia/phimpme-android/merges","archive_url":"https://api.github.com/repos/fossasia/phimpme-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fossasia/phimpme-android/downloads","issues_url":"https://api.github.com/repos/fossasia/phimpme-android/issues{/number}","pulls_url":"https://api.github.com/repos/fossasia/phimpme-android/pulls{/number}","milestones_url":"https://api.github.com/repos/fossasia/phimpme-android/milestones{/number}","notifications_url":"https://api.github.com/repos/fossasia/phimpme-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fossasia/phimpme-android/labels{/name}","releases_url":"https://api.github.com/repos/fossasia/phimpme-android/releases{/id}","deployments_url":"https://api.github.com/repos/fossasia/phimpme-android/deployments","created_at":"2012-09-07T07:14:54Z","updated_at":"2017-07-15T20:00:35Z","pushed_at":"2017-07-18T11:52:23Z","git_url":"git://github.com/fossasia/phimpme-android.git","ssh_url":"[email protected]:fossasia/phimpme-android.git","clone_url":"https://github.com/fossasia/phimpme-android.git","svn_url":"https://github.com/fossasia/phimpme-android","homepage":"","size":191860,"stargazers_count":100,"watchers_count":100,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":110,"mirror_url":null,"open_issues_count":28,"forks":110,"open_issues":28,"watchers":100,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/fossasia/phimpme-android/pulls/820"},"html":{"href":"https://github.com/fossasia/phimpme-android/pull/820"},"issue":{"href":"https://api.github.com/repos/fossasia/phimpme-android/issues/820"},"comments":{"href":"https://api.github.com/repos/fossasia/phimpme-android/issues/820/comments"},"review_comments":{"href":"https://api.github.com/repos/fossasia/phimpme-android/pulls/820/comments"},"review_comment":{"href":"https://api.github.com/repos/fossasia/phimpme-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fossasia/phimpme-android/pulls/820/commits"},"statuses":{"href":"https://api.github.com/repos/fossasia/phimpme-android/statuses/38fc7e9d9cc1c09b693644393633aec8f71ce9ce"}}}} | {
"id": 5713702,
"name": "fossasia/phimpme-android",
"url": "https://api.github.com/repos/fossasia/phimpme-android"
} | {
"id": 15368561,
"login": "vinaysajjanapu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15368561?",
"url": "https://api.github.com/users/vinaysajjanapu"
} | {
"id": 6295529,
"login": "fossasia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6295529?",
"url": "https://api.github.com/orgs/fossasia"
} | 2017-07-18T12:39:54 | 6277606341 | {"actor":{"display_login":"vinaysajjanapu"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/gitpoint/git-point/pulls/comments/141427996","pull_request_review_id":65640461,"id":141427996,"diff_hunk":"@@ -110,6 +116,16 @@ const styles = StyleSheet.create({\n textAlign: 'center',\n ...fonts.fontPrimary,\n },\n+ markAllAsReadButton: {\n+ marginTop: 3,\n+ paddingTop: 3,\n+ paddingBottom: 3,\n+ marginLeft: 11,\n+ marginRight: 11,\n+ borderColor: colors.mercury,\n+ borderWidth: 1,\n+ borderRadius: 3,\n+ },\n });","path":"src/notifications/screens/notifications.screen.js","position":71,"original_position":71,"commit_id":"5770590af64869a5fe5add41a49b2769529f3534","original_commit_id":"5770590af64869a5fe5add41a49b2769529f3534","user":{"login":"machour","id":304450,"avatar_url":"https://avatars2.githubusercontent.com/u/304450?v=4","gravatar_id":"","url":"https://api.github.com/users/machour","html_url":"https://github.com/machour","followers_url":"https://api.github.com/users/machour/followers","following_url":"https://api.github.com/users/machour/following{/other_user}","gists_url":"https://api.github.com/users/machour/gists{/gist_id}","starred_url":"https://api.github.com/users/machour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/machour/subscriptions","organizations_url":"https://api.github.com/users/machour/orgs","repos_url":"https://api.github.com/users/machour/repos","events_url":"https://api.github.com/users/machour/events{/privacy}","received_events_url":"https://api.github.com/users/machour/received_events","type":"User","site_admin":false},"body":"Absolutely! Right after commenting on this, I started implementing a standard <Button /> component to be used everywhere (small/normal/big, info/danger/..) :)","created_at":"2017-09-27T18:23:56Z","updated_at":"2017-09-27T18:23:56Z","html_url":"https://github.com/gitpoint/git-point/pull/371#discussion_r141427996","pull_request_url":"https://api.github.com/repos/gitpoint/git-point/pulls/371","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gitpoint/git-point/pulls/comments/141427996"},"html":{"href":"https://github.com/gitpoint/git-point/pull/371#discussion_r141427996"},"pull_request":{"href":"https://api.github.com/repos/gitpoint/git-point/pulls/371"}},"in_reply_to_id":141419929},"pull_request":{"url":"https://api.github.com/repos/gitpoint/git-point/pulls/371","id":143456305,"html_url":"https://github.com/gitpoint/git-point/pull/371","diff_url":"https://github.com/gitpoint/git-point/pull/371.diff","patch_url":"https://github.com/gitpoint/git-point/pull/371.patch","issue_url":"https://api.github.com/repos/gitpoint/git-point/issues/371","number":371,"state":"open","locked":false,"title":"feat(notifications): add button to mark all notifications as read","user":{"login":"lex111","id":4408379,"avatar_url":"https://avatars2.githubusercontent.com/u/4408379?v=4","gravatar_id":"","url":"https://api.github.com/users/lex111","html_url":"https://github.com/lex111","followers_url":"https://api.github.com/users/lex111/followers","following_url":"https://api.github.com/users/lex111/following{/other_user}","gists_url":"https://api.github.com/users/lex111/gists{/gist_id}","starred_url":"https://api.github.com/users/lex111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lex111/subscriptions","organizations_url":"https://api.github.com/users/lex111/orgs","repos_url":"https://api.github.com/users/lex111/repos","events_url":"https://api.github.com/users/lex111/events{/privacy}","received_events_url":"https://api.github.com/users/lex111/received_events","type":"User","site_admin":false},"body":"\r\n","created_at":"2017-09-27T17:38:55Z","updated_at":"2017-09-27T18:23:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2a1b2e6dc8a629a2ee79f5754123260b18e71af","assignee":null,"assignees":[],"requested_reviewers":[{"login":"patw0929","id":3055294,"avatar_url":"https://avatars0.githubusercontent.com/u/3055294?v=4","gravatar_id":"","url":"https://api.github.com/users/patw0929","html_url":"https://github.com/patw0929","followers_url":"https://api.github.com/users/patw0929/followers","following_url":"https://api.github.com/users/patw0929/following{/other_user}","gists_url":"https://api.github.com/users/patw0929/gists{/gist_id}","starred_url":"https://api.github.com/users/patw0929/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patw0929/subscriptions","organizations_url":"https://api.github.com/users/patw0929/orgs","repos_url":"https://api.github.com/users/patw0929/repos","events_url":"https://api.github.com/users/patw0929/events{/privacy}","received_events_url":"https://api.github.com/users/patw0929/received_events","type":"User","site_admin":false},{"login":"housseindjirdeh","id":12476932,"avatar_url":"https://avatars3.githubusercontent.com/u/12476932?v=4","gravatar_id":"","url":"https://api.github.com/users/housseindjirdeh","html_url":"https://github.com/housseindjirdeh","followers_url":"https://api.github.com/users/housseindjirdeh/followers","following_url":"https://api.github.com/users/housseindjirdeh/following{/other_user}","gists_url":"https://api.github.com/users/housseindjirdeh/gists{/gist_id}","starred_url":"https://api.github.com/users/housseindjirdeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/housseindjirdeh/subscriptions","organizations_url":"https://api.github.com/users/housseindjirdeh/orgs","repos_url":"https://api.github.com/users/housseindjirdeh/repos","events_url":"https://api.github.com/users/housseindjirdeh/events{/privacy}","received_events_url":"https://api.github.com/users/housseindjirdeh/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/gitpoint/git-point/pulls/371/commits","review_comments_url":"https://api.github.com/repos/gitpoint/git-point/pulls/371/comments","review_comment_url":"https://api.github.com/repos/gitpoint/git-point/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gitpoint/git-point/issues/371/comments","statuses_url":"https://api.github.com/repos/gitpoint/git-point/statuses/5770590af64869a5fe5add41a49b2769529f3534","head":{"label":"gitpoint:mark-all-notifications-as-read","ref":"mark-all-notifications-as-read","sha":"5770590af64869a5fe5add41a49b2769529f3534","user":{"login":"gitpoint","id":30082377,"avatar_url":"https://avatars0.githubusercontent.com/u/30082377?v=4","gravatar_id":"","url":"https://api.github.com/users/gitpoint","html_url":"https://github.com/gitpoint","followers_url":"https://api.github.com/users/gitpoint/followers","following_url":"https://api.github.com/users/gitpoint/following{/other_user}","gists_url":"https://api.github.com/users/gitpoint/gists{/gist_id}","starred_url":"https://api.github.com/users/gitpoint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitpoint/subscriptions","organizations_url":"https://api.github.com/users/gitpoint/orgs","repos_url":"https://api.github.com/users/gitpoint/repos","events_url":"https://api.github.com/users/gitpoint/events{/privacy}","received_events_url":"https://api.github.com/users/gitpoint/received_events","type":"Organization","site_admin":false},"repo":{"id":86202845,"name":"git-point","full_name":"gitpoint/git-point","owner":{"login":"gitpoint","id":30082377,"avatar_url":"https://avatars0.githubusercontent.com/u/30082377?v=4","gravatar_id":"","url":"https://api.github.com/users/gitpoint","html_url":"https://github.com/gitpoint","followers_url":"https://api.github.com/users/gitpoint/followers","following_url":"https://api.github.com/users/gitpoint/following{/other_user}","gists_url":"https://api.github.com/users/gitpoint/gists{/gist_id}","starred_url":"https://api.github.com/users/gitpoint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitpoint/subscriptions","organizations_url":"https://api.github.com/users/gitpoint/orgs","repos_url":"https://api.github.com/users/gitpoint/repos","events_url":"https://api.github.com/users/gitpoint/events{/privacy}","received_events_url":"https://api.github.com/users/gitpoint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gitpoint/git-point","description":"GitHub in your pocket :iphone:","fork":false,"url":"https://api.github.com/repos/gitpoint/git-point","forks_url":"https://api.github.com/repos/gitpoint/git-point/forks","keys_url":"https://api.github.com/repos/gitpoint/git-point/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gitpoint/git-point/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gitpoint/git-point/teams","hooks_url":"https://api.github.com/repos/gitpoint/git-point/hooks","issue_events_url":"https://api.github.com/repos/gitpoint/git-point/issues/events{/number}","events_url":"https://api.github.com/repos/gitpoint/git-point/events","assignees_url":"https://api.github.com/repos/gitpoint/git-point/assignees{/user}","branches_url":"https://api.github.com/repos/gitpoint/git-point/branches{/branch}","tags_url":"https://api.github.com/repos/gitpoint/git-point/tags","blobs_url":"https://api.github.com/repos/gitpoint/git-point/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gitpoint/git-point/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gitpoint/git-point/git/refs{/sha}","trees_url":"https://api.github.com/repos/gitpoint/git-point/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gitpoint/git-point/statuses/{sha}","languages_url":"https://api.github.com/repos/gitpoint/git-point/languages","stargazers_url":"https://api.github.com/repos/gitpoint/git-point/stargazers","contributors_url":"https://api.github.com/repos/gitpoint/git-point/contributors","subscribers_url":"https://api.github.com/repos/gitpoint/git-point/subscribers","subscription_url":"https://api.github.com/repos/gitpoint/git-point/subscription","commits_url":"https://api.github.com/repos/gitpoint/git-point/commits{/sha}","git_commits_url":"https://api.github.com/repos/gitpoint/git-point/git/commits{/sha}","comments_url":"https://api.github.com/repos/gitpoint/git-point/comments{/number}","issue_comment_url":"https://api.github.com/repos/gitpoint/git-point/issues/comments{/number}","contents_url":"https://api.github.com/repos/gitpoint/git-point/contents/{+path}","compare_url":"https://api.github.com/repos/gitpoint/git-point/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gitpoint/git-point/merges","archive_url":"https://api.github.com/repos/gitpoint/git-point/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gitpoint/git-point/downloads","issues_url":"https://api.github.com/repos/gitpoint/git-point/issues{/number}","pulls_url":"https://api.github.com/repos/gitpoint/git-point/pulls{/number}","milestones_url":"https://api.github.com/repos/gitpoint/git-point/milestones{/number}","notifications_url":"https://api.github.com/repos/gitpoint/git-point/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gitpoint/git-point/labels{/name}","releases_url":"https://api.github.com/repos/gitpoint/git-point/releases{/id}","deployments_url":"https://api.github.com/repos/gitpoint/git-point/deployments","created_at":"2017-03-26T02:45:46Z","updated_at":"2017-09-27T13:34:44Z","pushed_at":"2017-09-27T18:19:46Z","git_url":"git://github.com/gitpoint/git-point.git","ssh_url":"[email protected]:gitpoint/git-point.git","clone_url":"https://github.com/gitpoint/git-point.git","svn_url":"https://github.com/gitpoint/git-point","homepage":"https://gitpoint.co/","size":2955,"stargazers_count":2288,"watchers_count":2288,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":178,"mirror_url":null,"open_issues_count":99,"forks":178,"open_issues":99,"watchers":2288,"default_branch":"master"}},"base":{"label":"gitpoint:master","ref":"master","sha":"901f9d16c38dfabbe686149f1ea9a64e4820cf26","user":{"login":"gitpoint","id":30082377,"avatar_url":"https://avatars0.githubusercontent.com/u/30082377?v=4","gravatar_id":"","url":"https://api.github.com/users/gitpoint","html_url":"https://github.com/gitpoint","followers_url":"https://api.github.com/users/gitpoint/followers","following_url":"https://api.github.com/users/gitpoint/following{/other_user}","gists_url":"https://api.github.com/users/gitpoint/gists{/gist_id}","starred_url":"https://api.github.com/users/gitpoint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitpoint/subscriptions","organizations_url":"https://api.github.com/users/gitpoint/orgs","repos_url":"https://api.github.com/users/gitpoint/repos","events_url":"https://api.github.com/users/gitpoint/events{/privacy}","received_events_url":"https://api.github.com/users/gitpoint/received_events","type":"Organization","site_admin":false},"repo":{"id":86202845,"name":"git-point","full_name":"gitpoint/git-point","owner":{"login":"gitpoint","id":30082377,"avatar_url":"https://avatars0.githubusercontent.com/u/30082377?v=4","gravatar_id":"","url":"https://api.github.com/users/gitpoint","html_url":"https://github.com/gitpoint","followers_url":"https://api.github.com/users/gitpoint/followers","following_url":"https://api.github.com/users/gitpoint/following{/other_user}","gists_url":"https://api.github.com/users/gitpoint/gists{/gist_id}","starred_url":"https://api.github.com/users/gitpoint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitpoint/subscriptions","organizations_url":"https://api.github.com/users/gitpoint/orgs","repos_url":"https://api.github.com/users/gitpoint/repos","events_url":"https://api.github.com/users/gitpoint/events{/privacy}","received_events_url":"https://api.github.com/users/gitpoint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gitpoint/git-point","description":"GitHub in your pocket :iphone:","fork":false,"url":"https://api.github.com/repos/gitpoint/git-point","forks_url":"https://api.github.com/repos/gitpoint/git-point/forks","keys_url":"https://api.github.com/repos/gitpoint/git-point/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gitpoint/git-point/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gitpoint/git-point/teams","hooks_url":"https://api.github.com/repos/gitpoint/git-point/hooks","issue_events_url":"https://api.github.com/repos/gitpoint/git-point/issues/events{/number}","events_url":"https://api.github.com/repos/gitpoint/git-point/events","assignees_url":"https://api.github.com/repos/gitpoint/git-point/assignees{/user}","branches_url":"https://api.github.com/repos/gitpoint/git-point/branches{/branch}","tags_url":"https://api.github.com/repos/gitpoint/git-point/tags","blobs_url":"https://api.github.com/repos/gitpoint/git-point/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gitpoint/git-point/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gitpoint/git-point/git/refs{/sha}","trees_url":"https://api.github.com/repos/gitpoint/git-point/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gitpoint/git-point/statuses/{sha}","languages_url":"https://api.github.com/repos/gitpoint/git-point/languages","stargazers_url":"https://api.github.com/repos/gitpoint/git-point/stargazers","contributors_url":"https://api.github.com/repos/gitpoint/git-point/contributors","subscribers_url":"https://api.github.com/repos/gitpoint/git-point/subscribers","subscription_url":"https://api.github.com/repos/gitpoint/git-point/subscription","commits_url":"https://api.github.com/repos/gitpoint/git-point/commits{/sha}","git_commits_url":"https://api.github.com/repos/gitpoint/git-point/git/commits{/sha}","comments_url":"https://api.github.com/repos/gitpoint/git-point/comments{/number}","issue_comment_url":"https://api.github.com/repos/gitpoint/git-point/issues/comments{/number}","contents_url":"https://api.github.com/repos/gitpoint/git-point/contents/{+path}","compare_url":"https://api.github.com/repos/gitpoint/git-point/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gitpoint/git-point/merges","archive_url":"https://api.github.com/repos/gitpoint/git-point/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gitpoint/git-point/downloads","issues_url":"https://api.github.com/repos/gitpoint/git-point/issues{/number}","pulls_url":"https://api.github.com/repos/gitpoint/git-point/pulls{/number}","milestones_url":"https://api.github.com/repos/gitpoint/git-point/milestones{/number}","notifications_url":"https://api.github.com/repos/gitpoint/git-point/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gitpoint/git-point/labels{/name}","releases_url":"https://api.github.com/repos/gitpoint/git-point/releases{/id}","deployments_url":"https://api.github.com/repos/gitpoint/git-point/deployments","created_at":"2017-03-26T02:45:46Z","updated_at":"2017-09-27T13:34:44Z","pushed_at":"2017-09-27T18:19:46Z","git_url":"git://github.com/gitpoint/git-point.git","ssh_url":"[email protected]:gitpoint/git-point.git","clone_url":"https://github.com/gitpoint/git-point.git","svn_url":"https://github.com/gitpoint/git-point","homepage":"https://gitpoint.co/","size":2955,"stargazers_count":2288,"watchers_count":2288,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":178,"mirror_url":null,"open_issues_count":99,"forks":178,"open_issues":99,"watchers":2288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gitpoint/git-point/pulls/371"},"html":{"href":"https://github.com/gitpoint/git-point/pull/371"},"issue":{"href":"https://api.github.com/repos/gitpoint/git-point/issues/371"},"comments":{"href":"https://api.github.com/repos/gitpoint/git-point/issues/371/comments"},"review_comments":{"href":"https://api.github.com/repos/gitpoint/git-point/pulls/371/comments"},"review_comment":{"href":"https://api.github.com/repos/gitpoint/git-point/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gitpoint/git-point/pulls/371/commits"},"statuses":{"href":"https://api.github.com/repos/gitpoint/git-point/statuses/5770590af64869a5fe5add41a49b2769529f3534"}},"author_association":"MEMBER"}} | {
"id": 86202845,
"name": "gitpoint/git-point",
"url": "https://api.github.com/repos/gitpoint/git-point"
} | {
"id": 304450,
"login": "machour",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/304450?",
"url": "https://api.github.com/users/machour"
} | {
"id": 30082377,
"login": "gitpoint",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30082377?",
"url": "https://api.github.com/orgs/gitpoint"
} | 2017-09-27T18:23:56 | 6645544214 | {"actor":{"display_login":"machour"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/glayzzle/php-parser/pulls/comments/159038468","pull_request_review_id":85926673,"id":159038468,"diff_hunk":"@@ -204,28 +204,28 @@ module.exports = {\n case this.tok.T_NEW:\n return this.next().read_new_expr();\n \n- case this.tok.T_ISSET:\n+ case this.tok.T_ISSET: {","path":"src/parser/expr.js","position":69,"original_position":69,"commit_id":"7b9e542e9289e2c6ede2e8cf5cc8fffd5f450722","original_commit_id":"7b9e542e9289e2c6ede2e8cf5cc8fffd5f450722","user":{"login":"ichiriac","id":173203,"avatar_url":"https://avatars2.githubusercontent.com/u/173203?v=4","gravatar_id":"","url":"https://api.github.com/users/ichiriac","html_url":"https://github.com/ichiriac","followers_url":"https://api.github.com/users/ichiriac/followers","following_url":"https://api.github.com/users/ichiriac/following{/other_user}","gists_url":"https://api.github.com/users/ichiriac/gists{/gist_id}","starred_url":"https://api.github.com/users/ichiriac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ichiriac/subscriptions","organizations_url":"https://api.github.com/users/ichiriac/orgs","repos_url":"https://api.github.com/users/ichiriac/repos","events_url":"https://api.github.com/users/ichiriac/events{/privacy}","received_events_url":"https://api.github.com/users/ichiriac/received_events","type":"User","site_admin":false},"body":"why surrounding with `{` ... `}` ? It it a linter directive or is it better ?","created_at":"2017-12-29T09:05:15Z","updated_at":"2017-12-29T09:09:16Z","html_url":"https://github.com/glayzzle/php-parser/pull/109#discussion_r159038468","pull_request_url":"https://api.github.com/repos/glayzzle/php-parser/pulls/109","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/glayzzle/php-parser/pulls/comments/159038468"},"html":{"href":"https://github.com/glayzzle/php-parser/pull/109#discussion_r159038468"},"pull_request":{"href":"https://api.github.com/repos/glayzzle/php-parser/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/glayzzle/php-parser/pulls/109","id":160437810,"html_url":"https://github.com/glayzzle/php-parser/pull/109","diff_url":"https://github.com/glayzzle/php-parser/pull/109.diff","patch_url":"https://github.com/glayzzle/php-parser/pull/109.patch","issue_url":"https://api.github.com/repos/glayzzle/php-parser/issues/109","number":109,"state":"open","locked":false,"title":"Use let or const instead of var","user":{"login":"czosel","id":7962156,"avatar_url":"https://avatars2.githubusercontent.com/u/7962156?v=4","gravatar_id":"","url":"https://api.github.com/users/czosel","html_url":"https://github.com/czosel","followers_url":"https://api.github.com/users/czosel/followers","following_url":"https://api.github.com/users/czosel/following{/other_user}","gists_url":"https://api.github.com/users/czosel/gists{/gist_id}","starred_url":"https://api.github.com/users/czosel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czosel/subscriptions","organizations_url":"https://api.github.com/users/czosel/orgs","repos_url":"https://api.github.com/users/czosel/repos","events_url":"https://api.github.com/users/czosel/events{/privacy}","received_events_url":"https://api.github.com/users/czosel/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-28T20:17:46Z","updated_at":"2017-12-29T09:09:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f974ff80f12c03f22d2cf3545f02ee2156a2719a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/glayzzle/php-parser/pulls/109/commits","review_comments_url":"https://api.github.com/repos/glayzzle/php-parser/pulls/109/comments","review_comment_url":"https://api.github.com/repos/glayzzle/php-parser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/glayzzle/php-parser/issues/109/comments","statuses_url":"https://api.github.com/repos/glayzzle/php-parser/statuses/7b9e542e9289e2c6ede2e8cf5cc8fffd5f450722","head":{"label":"czosel:eslint_no_var","ref":"eslint_no_var","sha":"7b9e542e9289e2c6ede2e8cf5cc8fffd5f450722","user":{"login":"czosel","id":7962156,"avatar_url":"https://avatars2.githubusercontent.com/u/7962156?v=4","gravatar_id":"","url":"https://api.github.com/users/czosel","html_url":"https://github.com/czosel","followers_url":"https://api.github.com/users/czosel/followers","following_url":"https://api.github.com/users/czosel/following{/other_user}","gists_url":"https://api.github.com/users/czosel/gists{/gist_id}","starred_url":"https://api.github.com/users/czosel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czosel/subscriptions","organizations_url":"https://api.github.com/users/czosel/orgs","repos_url":"https://api.github.com/users/czosel/repos","events_url":"https://api.github.com/users/czosel/events{/privacy}","received_events_url":"https://api.github.com/users/czosel/received_events","type":"User","site_admin":false},"repo":{"id":115433575,"name":"php-parser","full_name":"czosel/php-parser","owner":{"login":"czosel","id":7962156,"avatar_url":"https://avatars2.githubusercontent.com/u/7962156?v=4","gravatar_id":"","url":"https://api.github.com/users/czosel","html_url":"https://github.com/czosel","followers_url":"https://api.github.com/users/czosel/followers","following_url":"https://api.github.com/users/czosel/following{/other_user}","gists_url":"https://api.github.com/users/czosel/gists{/gist_id}","starred_url":"https://api.github.com/users/czosel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czosel/subscriptions","organizations_url":"https://api.github.com/users/czosel/orgs","repos_url":"https://api.github.com/users/czosel/repos","events_url":"https://api.github.com/users/czosel/events{/privacy}","received_events_url":"https://api.github.com/users/czosel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/czosel/php-parser","description":":herb: NodeJS PHP Parser - extract AST or tokens (PHP5 and PHP7)","fork":true,"url":"https://api.github.com/repos/czosel/php-parser","forks_url":"https://api.github.com/repos/czosel/php-parser/forks","keys_url":"https://api.github.com/repos/czosel/php-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/czosel/php-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/czosel/php-parser/teams","hooks_url":"https://api.github.com/repos/czosel/php-parser/hooks","issue_events_url":"https://api.github.com/repos/czosel/php-parser/issues/events{/number}","events_url":"https://api.github.com/repos/czosel/php-parser/events","assignees_url":"https://api.github.com/repos/czosel/php-parser/assignees{/user}","branches_url":"https://api.github.com/repos/czosel/php-parser/branches{/branch}","tags_url":"https://api.github.com/repos/czosel/php-parser/tags","blobs_url":"https://api.github.com/repos/czosel/php-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/czosel/php-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/czosel/php-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/czosel/php-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/czosel/php-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/czosel/php-parser/languages","stargazers_url":"https://api.github.com/repos/czosel/php-parser/stargazers","contributors_url":"https://api.github.com/repos/czosel/php-parser/contributors","subscribers_url":"https://api.github.com/repos/czosel/php-parser/subscribers","subscription_url":"https://api.github.com/repos/czosel/php-parser/subscription","commits_url":"https://api.github.com/repos/czosel/php-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/czosel/php-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/czosel/php-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/czosel/php-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/czosel/php-parser/contents/{+path}","compare_url":"https://api.github.com/repos/czosel/php-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/czosel/php-parser/merges","archive_url":"https://api.github.com/repos/czosel/php-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/czosel/php-parser/downloads","issues_url":"https://api.github.com/repos/czosel/php-parser/issues{/number}","pulls_url":"https://api.github.com/repos/czosel/php-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/czosel/php-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/czosel/php-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/czosel/php-parser/labels{/name}","releases_url":"https://api.github.com/repos/czosel/php-parser/releases{/id}","deployments_url":"https://api.github.com/repos/czosel/php-parser/deployments","created_at":"2017-12-26T15:28:40Z","updated_at":"2017-12-26T15:28:42Z","pushed_at":"2017-12-29T07:20:13Z","git_url":"git://github.com/czosel/php-parser.git","ssh_url":"[email protected]:czosel/php-parser.git","clone_url":"https://github.com/czosel/php-parser.git","svn_url":"https://github.com/czosel/php-parser","homepage":"https://astexplorer.net/#/gist/c5098fd3b19f3c0da9de29986aa553d9/578cf3e85d8b5e4aee923e3fa3a24e9de93def19","size":2070,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"glayzzle:master","ref":"master","sha":"5e77f7bed6de066de6e1345f03620a5b3e0c63a1","user":{"login":"glayzzle","id":7166545,"avatar_url":"https://avatars2.githubusercontent.com/u/7166545?v=4","gravatar_id":"","url":"https://api.github.com/users/glayzzle","html_url":"https://github.com/glayzzle","followers_url":"https://api.github.com/users/glayzzle/followers","following_url":"https://api.github.com/users/glayzzle/following{/other_user}","gists_url":"https://api.github.com/users/glayzzle/gists{/gist_id}","starred_url":"https://api.github.com/users/glayzzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glayzzle/subscriptions","organizations_url":"https://api.github.com/users/glayzzle/orgs","repos_url":"https://api.github.com/users/glayzzle/repos","events_url":"https://api.github.com/users/glayzzle/events{/privacy}","received_events_url":"https://api.github.com/users/glayzzle/received_events","type":"Organization","site_admin":false},"repo":{"id":27666196,"name":"php-parser","full_name":"glayzzle/php-parser","owner":{"login":"glayzzle","id":7166545,"avatar_url":"https://avatars2.githubusercontent.com/u/7166545?v=4","gravatar_id":"","url":"https://api.github.com/users/glayzzle","html_url":"https://github.com/glayzzle","followers_url":"https://api.github.com/users/glayzzle/followers","following_url":"https://api.github.com/users/glayzzle/following{/other_user}","gists_url":"https://api.github.com/users/glayzzle/gists{/gist_id}","starred_url":"https://api.github.com/users/glayzzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glayzzle/subscriptions","organizations_url":"https://api.github.com/users/glayzzle/orgs","repos_url":"https://api.github.com/users/glayzzle/repos","events_url":"https://api.github.com/users/glayzzle/events{/privacy}","received_events_url":"https://api.github.com/users/glayzzle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/glayzzle/php-parser","description":":herb: NodeJS PHP Parser - extract AST or tokens (PHP5 and PHP7)","fork":false,"url":"https://api.github.com/repos/glayzzle/php-parser","forks_url":"https://api.github.com/repos/glayzzle/php-parser/forks","keys_url":"https://api.github.com/repos/glayzzle/php-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glayzzle/php-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glayzzle/php-parser/teams","hooks_url":"https://api.github.com/repos/glayzzle/php-parser/hooks","issue_events_url":"https://api.github.com/repos/glayzzle/php-parser/issues/events{/number}","events_url":"https://api.github.com/repos/glayzzle/php-parser/events","assignees_url":"https://api.github.com/repos/glayzzle/php-parser/assignees{/user}","branches_url":"https://api.github.com/repos/glayzzle/php-parser/branches{/branch}","tags_url":"https://api.github.com/repos/glayzzle/php-parser/tags","blobs_url":"https://api.github.com/repos/glayzzle/php-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glayzzle/php-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glayzzle/php-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/glayzzle/php-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glayzzle/php-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/glayzzle/php-parser/languages","stargazers_url":"https://api.github.com/repos/glayzzle/php-parser/stargazers","contributors_url":"https://api.github.com/repos/glayzzle/php-parser/contributors","subscribers_url":"https://api.github.com/repos/glayzzle/php-parser/subscribers","subscription_url":"https://api.github.com/repos/glayzzle/php-parser/subscription","commits_url":"https://api.github.com/repos/glayzzle/php-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/glayzzle/php-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/glayzzle/php-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/glayzzle/php-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/glayzzle/php-parser/contents/{+path}","compare_url":"https://api.github.com/repos/glayzzle/php-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glayzzle/php-parser/merges","archive_url":"https://api.github.com/repos/glayzzle/php-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glayzzle/php-parser/downloads","issues_url":"https://api.github.com/repos/glayzzle/php-parser/issues{/number}","pulls_url":"https://api.github.com/repos/glayzzle/php-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/glayzzle/php-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/glayzzle/php-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glayzzle/php-parser/labels{/name}","releases_url":"https://api.github.com/repos/glayzzle/php-parser/releases{/id}","deployments_url":"https://api.github.com/repos/glayzzle/php-parser/deployments","created_at":"2014-12-07T10:11:57Z","updated_at":"2017-12-28T16:09:46Z","pushed_at":"2017-12-29T08:49:55Z","git_url":"git://github.com/glayzzle/php-parser.git","ssh_url":"[email protected]:glayzzle/php-parser.git","clone_url":"https://github.com/glayzzle/php-parser.git","svn_url":"https://github.com/glayzzle/php-parser","homepage":"https://astexplorer.net/#/gist/c5098fd3b19f3c0da9de29986aa553d9/578cf3e85d8b5e4aee923e3fa3a24e9de93def19","size":2054,"stargazers_count":159,"watchers_count":159,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"bsd-3-clause","name":"BSD 3-clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":24,"open_issues":11,"watchers":159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/glayzzle/php-parser/pulls/109"},"html":{"href":"https://github.com/glayzzle/php-parser/pull/109"},"issue":{"href":"https://api.github.com/repos/glayzzle/php-parser/issues/109"},"comments":{"href":"https://api.github.com/repos/glayzzle/php-parser/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/glayzzle/php-parser/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/glayzzle/php-parser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/glayzzle/php-parser/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/glayzzle/php-parser/statuses/7b9e542e9289e2c6ede2e8cf5cc8fffd5f450722"}},"author_association":"CONTRIBUTOR"}} | {
"id": 27666196,
"name": "glayzzle/php-parser",
"url": "https://api.github.com/repos/glayzzle/php-parser"
} | {
"id": 173203,
"login": "ichiriac",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/173203?",
"url": "https://api.github.com/users/ichiriac"
} | {
"id": 7166545,
"login": "glayzzle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7166545?",
"url": "https://api.github.com/orgs/glayzzle"
} | 2017-12-29T09:05:15 | 7039746237 | {"actor":{"display_login":"ichiriac"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/go-gitea/gitea/pulls/comments/154732092","pull_request_review_id":80939125,"id":154732092,"diff_hunk":"@@ -0,0 +1,145 @@\n+// Copyright 2017 The Gitea Authors. All rights reserved.\n+// Use of this source code is governed by a MIT-style\n+// license that can be found in the LICENSE file.\n+\n+package models\n+\n+import (\n+\t\"code.gitea.io/gitea/modules/setting\"\n+\t\"time\"\n+)\n+\n+// IssueDependency represents an issue dependency\n+type IssueDependency struct {\n+\tID int64 `xorm:\"pk autoincr\"`\n+\tUserID int64 `xorm:\"NOT NULL\"`\n+\tIssueID int64 `xorm:\"UNIQUE(issue_dependency) NOT NULL\"`\n+\tDependencyID int64 `xorm:\"UNIQUE(issue_dependency) NOT NULL\"`\n+\tCreated time.Time `xorm:\"-\"`\n+\tCreatedUnix int64 `xorm:\"INDEX created\"`\n+\tUpdated time.Time `xorm:\"-\"`\n+\tUpdatedUnix int64 `xorm:\"updated\"`\n+}\n+\n+// DependencyType Defines Dependency Type Constants\n+type DependencyType int\n+\n+// Define Dependency Types\n+const (\n+\tDependencyTypeBlockedBy DependencyType = iota\n+\tDependencyTypeBlocking\n+)\n+\n+// CreateIssueDependency creates a new dependency for an issue\n+func CreateIssueDependency(user *User, issue, dep *Issue) (exists, circular bool, err error) {\n+\tsess := x.NewSession()\n+\n+\t// Check if it aleready exists\n+\texists, circular, err = issueDepExists(x, issue.ID, dep.ID)\n+\tif err != nil {\n+\t\treturn\n+\t}\n+\n+\t// If it not exists, create it, otherwise show an error message\n+\tif !exists && !circular {\n+\t\tnewIssueDependency := &IssueDependency{\n+\t\t\tUserID: user.ID,\n+\t\t\tIssueID: issue.ID,\n+\t\t\tDependencyID: dep.ID,\n+\t\t}\n+\n+\t\tif _, err := x.Insert(newIssueDependency); err != nil {\n+\t\t\treturn exists, circular, err\n+\t\t}\n+\n+\t\t// Add comment referencing the new dependency\n+\t\tif _, err = createIssueDependencyComment(sess, user, issue, dep, true); err != nil {\n+\t\t\treturn\n+\t\t}\n+\n+\t\t// Create a new comment for the dependent issue\n+\t\tif _, err = createIssueDependencyComment(sess, user, dep, issue, true); err != nil {\n+\t\t\treturn\n+\t\t}\n+\t}\n+\treturn exists, circular, nil\n+}\n+\n+// RemoveIssueDependency removes a dependency from an issue\n+func RemoveIssueDependency(user *User, issue *Issue, dep *Issue, depType DependencyType) (err error) {\n+\tsess := x.NewSession()\n+\n+\t// Check if it exists\n+\tvar exists bool\n+\tif exists, _, err = issueDepExists(x, issue.ID, dep.ID); err != nil {\n+\t\treturn err\n+\t}\n+\n+\t// If it exists, remove it, otherwise show an error message\n+\tif exists {\n+\n+\t\tvar issueDepToDelete IssueDependency\n+\n+\t\tswitch depType {\n+\t\tcase DependencyTypeBlockedBy:\n+\t\t\tissueDepToDelete = IssueDependency{IssueID: issue.ID, DependencyID: dep.ID}\n+\t\tcase DependencyTypeBlocking:\n+\t\t\tissueDepToDelete = IssueDependency{IssueID: dep.ID, DependencyID: issue.ID}\n+\t\tdefault:\n+\t\t\treturn\n+\t\t}\n+\n+\t\tif _, err := x.Delete(&issueDepToDelete); err != nil {","path":"models/issue_dependency.go","position":null,"original_position":92,"commit_id":"25427aee25d70e1895bbe0098f10d07902ab1639","original_commit_id":"fae44666ec0968612f11593031caa0c8ee613a98","user":{"login":"kolaente","id":13721712,"avatar_url":"https://avatars0.githubusercontent.com/u/13721712?v=4","gravatar_id":"","url":"https://api.github.com/users/kolaente","html_url":"https://github.com/kolaente","followers_url":"https://api.github.com/users/kolaente/followers","following_url":"https://api.github.com/users/kolaente/following{/other_user}","gists_url":"https://api.github.com/users/kolaente/gists{/gist_id}","starred_url":"https://api.github.com/users/kolaente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kolaente/subscriptions","organizations_url":"https://api.github.com/users/kolaente/orgs","repos_url":"https://api.github.com/users/kolaente/repos","events_url":"https://api.github.com/users/kolaente/events{/privacy}","received_events_url":"https://api.github.com/users/kolaente/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2017-12-04T18:23:56Z","updated_at":"2017-12-04T18:23:56Z","html_url":"https://github.com/go-gitea/gitea/pull/2531#discussion_r154732092","pull_request_url":"https://api.github.com/repos/go-gitea/gitea/pulls/2531","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/go-gitea/gitea/pulls/comments/154732092"},"html":{"href":"https://github.com/go-gitea/gitea/pull/2531#discussion_r154732092"},"pull_request":{"href":"https://api.github.com/repos/go-gitea/gitea/pulls/2531"}},"in_reply_to_id":154651196},"pull_request":{"url":"https://api.github.com/repos/go-gitea/gitea/pulls/2531","id":141494381,"html_url":"https://github.com/go-gitea/gitea/pull/2531","diff_url":"https://github.com/go-gitea/gitea/pull/2531.diff","patch_url":"https://github.com/go-gitea/gitea/pull/2531.patch","issue_url":"https://api.github.com/repos/go-gitea/gitea/issues/2531","number":2531,"state":"open","locked":false,"title":"Added dependencies for issues (#2196)","user":{"login":"kolaente","id":13721712,"avatar_url":"https://avatars0.githubusercontent.com/u/13721712?v=4","gravatar_id":"","url":"https://api.github.com/users/kolaente","html_url":"https://github.com/kolaente","followers_url":"https://api.github.com/users/kolaente/followers","following_url":"https://api.github.com/users/kolaente/following{/other_user}","gists_url":"https://api.github.com/users/kolaente/gists{/gist_id}","starred_url":"https://api.github.com/users/kolaente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kolaente/subscriptions","organizations_url":"https://api.github.com/users/kolaente/orgs","repos_url":"https://api.github.com/users/kolaente/repos","events_url":"https://api.github.com/users/kolaente/events{/privacy}","received_events_url":"https://api.github.com/users/kolaente/received_events","type":"User","site_admin":false},"body":"## Introduction\r\nThis PR implements dependencies for issues, as described in #2196.\r\n\r\nIt lets you define anonther issue as a dependency for an issue. You the cannot close the issue if it has any dependent issues which aren't closed. If you try to autoclose an issue via commit message which still has dependencies left, autoclose will simply not close the issue, but the commit will **not** fail.\r\n\r\nYou can disable dependencies in the repo settings.\r\n\r\nExample: You set #2, #3 and #4 as a dependency of #1. Now you need to close all #2, #3 and #4, before you can close #1.\r\n\r\n## Screenshots\r\n\r\nOverview of Issue Dependencies (sidebar):\r\n\r\n\r\n\r\nComments after adding a new dependency:\r\n\r\n\r\n## Questions\r\n\r\nCurrently, i would describe this as \"working, but not finished\", as there are some questions i have:\r\n1. For now, you need the issue ID (not the index) to create a dependency. This is not very user-friendly, I'd like to have some kind of search bar where you search for the issue title/index select it, and it'll do the rest. **Problem:** There is no API-Endpoint to search for issues like that (Or just returns a list of all issues as JSON). I think this should be implemented first.\r\nIf such thing already exists, please point me to it, I haven't found any.\r\n2. It is currently possible to create dependencies with issues from other repositories. Is this okay? Or should one not be able to do this, as it could create a massive overhead with all permission-checking etc.\r\n3. There is some work to be done with migrations etc, currently i simply put the xorm-call at the beginning of the function, which probably shouldn't be there. Where is the appropriate place to put this?\r\n\r\nThis is my first time I've done something like this in Go, before i've only played around with Go but never really did anything bigger. So, there are probably some things I didn't got right as a novice. Looking forward to hear your improvents to be made! Also thanks to @JonasFranzDEV who has helped me a lot.","created_at":"2017-09-17T17:18:46Z","updated_at":"2017-12-04T18:23:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"def6b8a59ec809882c263ddbaded66f383e32bc3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/go-gitea/gitea/milestones/4","html_url":"https://github.com/go-gitea/gitea/milestone/4","labels_url":"https://api.github.com/repos/go-gitea/gitea/milestones/4/labels","id":2111552,"number":4,"title":"1.x.x","description":"","creator":{"login":"tboerger","id":156964,"avatar_url":"https://avatars3.githubusercontent.com/u/156964?v=4","gravatar_id":"","url":"https://api.github.com/users/tboerger","html_url":"https://github.com/tboerger","followers_url":"https://api.github.com/users/tboerger/followers","following_url":"https://api.github.com/users/tboerger/following{/other_user}","gists_url":"https://api.github.com/users/tboerger/gists{/gist_id}","starred_url":"https://api.github.com/users/tboerger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tboerger/subscriptions","organizations_url":"https://api.github.com/users/tboerger/orgs","repos_url":"https://api.github.com/users/tboerger/repos","events_url":"https://api.github.com/users/tboerger/events{/privacy}","received_events_url":"https://api.github.com/users/tboerger/received_events","type":"User","site_admin":false},"open_issues":369,"closed_issues":0,"state":"open","created_at":"2016-11-03T08:40:47Z","updated_at":"2017-12-04T04:50:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/go-gitea/gitea/pulls/2531/commits","review_comments_url":"https://api.github.com/repos/go-gitea/gitea/pulls/2531/comments","review_comment_url":"https://api.github.com/repos/go-gitea/gitea/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-gitea/gitea/issues/2531/comments","statuses_url":"https://api.github.com/repos/go-gitea/gitea/statuses/25427aee25d70e1895bbe0098f10d07902ab1639","head":{"label":"kolaente:master","ref":"master","sha":"25427aee25d70e1895bbe0098f10d07902ab1639","user":{"login":"kolaente","id":13721712,"avatar_url":"https://avatars0.githubusercontent.com/u/13721712?v=4","gravatar_id":"","url":"https://api.github.com/users/kolaente","html_url":"https://github.com/kolaente","followers_url":"https://api.github.com/users/kolaente/followers","following_url":"https://api.github.com/users/kolaente/following{/other_user}","gists_url":"https://api.github.com/users/kolaente/gists{/gist_id}","starred_url":"https://api.github.com/users/kolaente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kolaente/subscriptions","organizations_url":"https://api.github.com/users/kolaente/orgs","repos_url":"https://api.github.com/users/kolaente/repos","events_url":"https://api.github.com/users/kolaente/events{/privacy}","received_events_url":"https://api.github.com/users/kolaente/received_events","type":"User","site_admin":false},"repo":{"id":99831354,"name":"gitea","full_name":"kolaente/gitea","owner":{"login":"kolaente","id":13721712,"avatar_url":"https://avatars0.githubusercontent.com/u/13721712?v=4","gravatar_id":"","url":"https://api.github.com/users/kolaente","html_url":"https://github.com/kolaente","followers_url":"https://api.github.com/users/kolaente/followers","following_url":"https://api.github.com/users/kolaente/following{/other_user}","gists_url":"https://api.github.com/users/kolaente/gists{/gist_id}","starred_url":"https://api.github.com/users/kolaente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kolaente/subscriptions","organizations_url":"https://api.github.com/users/kolaente/orgs","repos_url":"https://api.github.com/users/kolaente/repos","events_url":"https://api.github.com/users/kolaente/events{/privacy}","received_events_url":"https://api.github.com/users/kolaente/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kolaente/gitea","description":"Gitea: Git with a cup of tea","fork":true,"url":"https://api.github.com/repos/kolaente/gitea","forks_url":"https://api.github.com/repos/kolaente/gitea/forks","keys_url":"https://api.github.com/repos/kolaente/gitea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kolaente/gitea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kolaente/gitea/teams","hooks_url":"https://api.github.com/repos/kolaente/gitea/hooks","issue_events_url":"https://api.github.com/repos/kolaente/gitea/issues/events{/number}","events_url":"https://api.github.com/repos/kolaente/gitea/events","assignees_url":"https://api.github.com/repos/kolaente/gitea/assignees{/user}","branches_url":"https://api.github.com/repos/kolaente/gitea/branches{/branch}","tags_url":"https://api.github.com/repos/kolaente/gitea/tags","blobs_url":"https://api.github.com/repos/kolaente/gitea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kolaente/gitea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kolaente/gitea/git/refs{/sha}","trees_url":"https://api.github.com/repos/kolaente/gitea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kolaente/gitea/statuses/{sha}","languages_url":"https://api.github.com/repos/kolaente/gitea/languages","stargazers_url":"https://api.github.com/repos/kolaente/gitea/stargazers","contributors_url":"https://api.github.com/repos/kolaente/gitea/contributors","subscribers_url":"https://api.github.com/repos/kolaente/gitea/subscribers","subscription_url":"https://api.github.com/repos/kolaente/gitea/subscription","commits_url":"https://api.github.com/repos/kolaente/gitea/commits{/sha}","git_commits_url":"https://api.github.com/repos/kolaente/gitea/git/commits{/sha}","comments_url":"https://api.github.com/repos/kolaente/gitea/comments{/number}","issue_comment_url":"https://api.github.com/repos/kolaente/gitea/issues/comments{/number}","contents_url":"https://api.github.com/repos/kolaente/gitea/contents/{+path}","compare_url":"https://api.github.com/repos/kolaente/gitea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kolaente/gitea/merges","archive_url":"https://api.github.com/repos/kolaente/gitea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kolaente/gitea/downloads","issues_url":"https://api.github.com/repos/kolaente/gitea/issues{/number}","pulls_url":"https://api.github.com/repos/kolaente/gitea/pulls{/number}","milestones_url":"https://api.github.com/repos/kolaente/gitea/milestones{/number}","notifications_url":"https://api.github.com/repos/kolaente/gitea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kolaente/gitea/labels{/name}","releases_url":"https://api.github.com/repos/kolaente/gitea/releases{/id}","deployments_url":"https://api.github.com/repos/kolaente/gitea/deployments","created_at":"2017-08-09T16:45:04Z","updated_at":"2017-08-09T16:45:07Z","pushed_at":"2017-12-04T18:23:45Z","git_url":"git://github.com/kolaente/gitea.git","ssh_url":"[email protected]:kolaente/gitea.git","clone_url":"https://github.com/kolaente/gitea.git","svn_url":"https://github.com/kolaente/gitea","homepage":"http://gitea.io","size":106628,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"go-gitea:master","ref":"master","sha":"c0a7899416af728634b2dc52a27b31255285ae7e","user":{"login":"go-gitea","id":12724356,"avatar_url":"https://avatars1.githubusercontent.com/u/12724356?v=4","gravatar_id":"","url":"https://api.github.com/users/go-gitea","html_url":"https://github.com/go-gitea","followers_url":"https://api.github.com/users/go-gitea/followers","following_url":"https://api.github.com/users/go-gitea/following{/other_user}","gists_url":"https://api.github.com/users/go-gitea/gists{/gist_id}","starred_url":"https://api.github.com/users/go-gitea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-gitea/subscriptions","organizations_url":"https://api.github.com/users/go-gitea/orgs","repos_url":"https://api.github.com/users/go-gitea/repos","events_url":"https://api.github.com/users/go-gitea/events{/privacy}","received_events_url":"https://api.github.com/users/go-gitea/received_events","type":"Organization","site_admin":false},"repo":{"id":72495579,"name":"gitea","full_name":"go-gitea/gitea","owner":{"login":"go-gitea","id":12724356,"avatar_url":"https://avatars1.githubusercontent.com/u/12724356?v=4","gravatar_id":"","url":"https://api.github.com/users/go-gitea","html_url":"https://github.com/go-gitea","followers_url":"https://api.github.com/users/go-gitea/followers","following_url":"https://api.github.com/users/go-gitea/following{/other_user}","gists_url":"https://api.github.com/users/go-gitea/gists{/gist_id}","starred_url":"https://api.github.com/users/go-gitea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-gitea/subscriptions","organizations_url":"https://api.github.com/users/go-gitea/orgs","repos_url":"https://api.github.com/users/go-gitea/repos","events_url":"https://api.github.com/users/go-gitea/events{/privacy}","received_events_url":"https://api.github.com/users/go-gitea/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-gitea/gitea","description":"Gitea: Git with a cup of tea","fork":false,"url":"https://api.github.com/repos/go-gitea/gitea","forks_url":"https://api.github.com/repos/go-gitea/gitea/forks","keys_url":"https://api.github.com/repos/go-gitea/gitea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-gitea/gitea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-gitea/gitea/teams","hooks_url":"https://api.github.com/repos/go-gitea/gitea/hooks","issue_events_url":"https://api.github.com/repos/go-gitea/gitea/issues/events{/number}","events_url":"https://api.github.com/repos/go-gitea/gitea/events","assignees_url":"https://api.github.com/repos/go-gitea/gitea/assignees{/user}","branches_url":"https://api.github.com/repos/go-gitea/gitea/branches{/branch}","tags_url":"https://api.github.com/repos/go-gitea/gitea/tags","blobs_url":"https://api.github.com/repos/go-gitea/gitea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-gitea/gitea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-gitea/gitea/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-gitea/gitea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-gitea/gitea/statuses/{sha}","languages_url":"https://api.github.com/repos/go-gitea/gitea/languages","stargazers_url":"https://api.github.com/repos/go-gitea/gitea/stargazers","contributors_url":"https://api.github.com/repos/go-gitea/gitea/contributors","subscribers_url":"https://api.github.com/repos/go-gitea/gitea/subscribers","subscription_url":"https://api.github.com/repos/go-gitea/gitea/subscription","commits_url":"https://api.github.com/repos/go-gitea/gitea/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-gitea/gitea/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-gitea/gitea/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-gitea/gitea/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-gitea/gitea/contents/{+path}","compare_url":"https://api.github.com/repos/go-gitea/gitea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-gitea/gitea/merges","archive_url":"https://api.github.com/repos/go-gitea/gitea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-gitea/gitea/downloads","issues_url":"https://api.github.com/repos/go-gitea/gitea/issues{/number}","pulls_url":"https://api.github.com/repos/go-gitea/gitea/pulls{/number}","milestones_url":"https://api.github.com/repos/go-gitea/gitea/milestones{/number}","notifications_url":"https://api.github.com/repos/go-gitea/gitea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-gitea/gitea/labels{/name}","releases_url":"https://api.github.com/repos/go-gitea/gitea/releases{/id}","deployments_url":"https://api.github.com/repos/go-gitea/gitea/deployments","created_at":"2016-11-01T02:13:26Z","updated_at":"2017-12-04T16:41:54Z","pushed_at":"2017-12-04T18:23:47Z","git_url":"git://github.com/go-gitea/gitea.git","ssh_url":"[email protected]:go-gitea/gitea.git","clone_url":"https://github.com/go-gitea/gitea.git","svn_url":"https://github.com/go-gitea/gitea","homepage":"http://gitea.io","size":106493,"stargazers_count":4365,"watchers_count":4365,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":482,"mirror_url":null,"archived":false,"open_issues_count":593,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":482,"open_issues":593,"watchers":4365,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-gitea/gitea/pulls/2531"},"html":{"href":"https://github.com/go-gitea/gitea/pull/2531"},"issue":{"href":"https://api.github.com/repos/go-gitea/gitea/issues/2531"},"comments":{"href":"https://api.github.com/repos/go-gitea/gitea/issues/2531/comments"},"review_comments":{"href":"https://api.github.com/repos/go-gitea/gitea/pulls/2531/comments"},"review_comment":{"href":"https://api.github.com/repos/go-gitea/gitea/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-gitea/gitea/pulls/2531/commits"},"statuses":{"href":"https://api.github.com/repos/go-gitea/gitea/statuses/25427aee25d70e1895bbe0098f10d07902ab1639"}},"author_association":"NONE"}} | {
"id": 72495579,
"name": "go-gitea/gitea",
"url": "https://api.github.com/repos/go-gitea/gitea"
} | {
"id": 13721712,
"login": "kolaente",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13721712?",
"url": "https://api.github.com/users/kolaente"
} | {
"id": 12724356,
"login": "go-gitea",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12724356?",
"url": "https://api.github.com/orgs/go-gitea"
} | 2017-12-04T18:23:56 | 6940955247 | {"actor":{"display_login":"kolaente"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/113450132","pull_request_review_id":34839023,"id":113450132,"diff_hunk":"@@ -296,9 +296,9 @@ object EmailNewsletters {\n teaser = \"Uncover unconventional destinations and rediscover old favourites - let our travel editors guide you to trips worth taking\",\n description = \"Weekly travel inspiration. Off-piste attractions, budget breaks, top 10s and reader reviews. Uncover unconventional destinations and rediscover old favourites - let our travel editors guide you to trips worth taking\",\n frequency = \"Every Wednesday\",\n- listId = 2211,\n+ listId = 3806,\n tone = Some(\"feature\"),\n- aliases = List(3806, 3807),\n+ aliases = List(2211, 3807),\n signupPage = Some(\"/travel/2016/aug/18/sign-up-to-the-flyer\"),\n exampleUrl = Some(\"/email/the-flyer?format=email-connected\")","path":"common/app/model/EmailNewsletters.scala","position":10,"original_position":10,"commit_id":"6bd1c744c1b43c1dcaa527cc16942315ac890212","original_commit_id":"6bd1c744c1b43c1dcaa527cc16942315ac890212","user":{"login":"katebee","id":8607683,"avatar_url":"https://avatars0.githubusercontent.com/u/8607683?v=3","gravatar_id":"","url":"https://api.github.com/users/katebee","html_url":"https://github.com/katebee","followers_url":"https://api.github.com/users/katebee/followers","following_url":"https://api.github.com/users/katebee/following{/other_user}","gists_url":"https://api.github.com/users/katebee/gists{/gist_id}","starred_url":"https://api.github.com/users/katebee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katebee/subscriptions","organizations_url":"https://api.github.com/users/katebee/orgs","repos_url":"https://api.github.com/users/katebee/repos","events_url":"https://api.github.com/users/katebee/events{/privacy}","received_events_url":"https://api.github.com/users/katebee/received_events","type":"User","site_admin":false},"body":"`connected` was associated with 3807? The exampleUrl should be switched to the `cards` (?3806) version:\r\nhttps://www.theguardian.com/email/the-flyer?format=email","created_at":"2017-04-26T13:26:26Z","updated_at":"2017-04-26T13:26:26Z","html_url":"https://github.com/guardian/frontend/pull/16562#discussion_r113450132","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/16562","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/113450132"},"html":{"href":"https://github.com/guardian/frontend/pull/16562#discussion_r113450132"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/16562"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/16562","id":117711656,"html_url":"https://github.com/guardian/frontend/pull/16562","diff_url":"https://github.com/guardian/frontend/pull/16562.diff","patch_url":"https://github.com/guardian/frontend/pull/16562.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/16562","number":16562,"state":"open","locked":false,"title":"Remove flyer email a/b test","user":{"login":"davidfurey","id":2619836,"avatar_url":"https://avatars3.githubusercontent.com/u/2619836?v=3","gravatar_id":"","url":"https://api.github.com/users/davidfurey","html_url":"https://github.com/davidfurey","followers_url":"https://api.github.com/users/davidfurey/followers","following_url":"https://api.github.com/users/davidfurey/following{/other_user}","gists_url":"https://api.github.com/users/davidfurey/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfurey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfurey/subscriptions","organizations_url":"https://api.github.com/users/davidfurey/orgs","repos_url":"https://api.github.com/users/davidfurey/repos","events_url":"https://api.github.com/users/davidfurey/events{/privacy}","received_events_url":"https://api.github.com/users/davidfurey/received_events","type":"User","site_admin":false},"body":"## What does this change?\r\n\r\nRemoves flyer email a/b test. Also switches the default list id to 3806, requested by Celine. Follow up PR will remove the aliases once the list ids have been merged.\r\n\r\n## What is the value of this and can you measure success?\r\n\r\nTest is complete, this is just tidying up\r\n\r\n## Does this affect other platforms - Amp, Apps, etc?\r\n\r\nNo\r\n\r\n## Screenshots\r\n\r\n## Tested in CODE?\r\n\r\nNo\r\n\r\n<!-- AB test? https://git.io/v1V0x -->\r\n<!-- AMP question? https://git.io/v1V0p -->\r\n<!-- Does this PR meet the contributing guidelines? https://git.io/v1VEJ -->\r\n","created_at":"2017-04-26T13:16:49Z","updated_at":"2017-04-26T13:26:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"716a8568134c0dde30f441411c359e158268cdd7","assignee":{"login":"lmath","id":3072877,"avatar_url":"https://avatars2.githubusercontent.com/u/3072877?v=3","gravatar_id":"","url":"https://api.github.com/users/lmath","html_url":"https://github.com/lmath","followers_url":"https://api.github.com/users/lmath/followers","following_url":"https://api.github.com/users/lmath/following{/other_user}","gists_url":"https://api.github.com/users/lmath/gists{/gist_id}","starred_url":"https://api.github.com/users/lmath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmath/subscriptions","organizations_url":"https://api.github.com/users/lmath/orgs","repos_url":"https://api.github.com/users/lmath/repos","events_url":"https://api.github.com/users/lmath/events{/privacy}","received_events_url":"https://api.github.com/users/lmath/received_events","type":"User","site_admin":false},"assignees":[{"login":"lmath","id":3072877,"avatar_url":"https://avatars2.githubusercontent.com/u/3072877?v=3","gravatar_id":"","url":"https://api.github.com/users/lmath","html_url":"https://github.com/lmath","followers_url":"https://api.github.com/users/lmath/followers","following_url":"https://api.github.com/users/lmath/following{/other_user}","gists_url":"https://api.github.com/users/lmath/gists{/gist_id}","starred_url":"https://api.github.com/users/lmath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmath/subscriptions","organizations_url":"https://api.github.com/users/lmath/orgs","repos_url":"https://api.github.com/users/lmath/repos","events_url":"https://api.github.com/users/lmath/events{/privacy}","received_events_url":"https://api.github.com/users/lmath/received_events","type":"User","site_admin":false},{"login":"joelochlann","id":5122968,"avatar_url":"https://avatars0.githubusercontent.com/u/5122968?v=3","gravatar_id":"","url":"https://api.github.com/users/joelochlann","html_url":"https://github.com/joelochlann","followers_url":"https://api.github.com/users/joelochlann/followers","following_url":"https://api.github.com/users/joelochlann/following{/other_user}","gists_url":"https://api.github.com/users/joelochlann/gists{/gist_id}","starred_url":"https://api.github.com/users/joelochlann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelochlann/subscriptions","organizations_url":"https://api.github.com/users/joelochlann/orgs","repos_url":"https://api.github.com/users/joelochlann/repos","events_url":"https://api.github.com/users/joelochlann/events{/privacy}","received_events_url":"https://api.github.com/users/joelochlann/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/16562/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/16562/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/16562/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/6bd1c744c1b43c1dcaa527cc16942315ac890212","head":{"label":"guardian:disable-flyer-test","ref":"disable-flyer-test","sha":"6bd1c744c1b43c1dcaa527cc16942315ac890212","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars3.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars3.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2017-04-26T13:09:22Z","pushed_at":"2017-04-26T13:16:49Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"[email protected]:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"https://www.theguardian.com","size":517653,"stargazers_count":3551,"watchers_count":3551,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":383,"mirror_url":null,"open_issues_count":45,"forks":383,"open_issues":45,"watchers":3551,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"89fbbc9808c01a90e4074a24ec762b4cb2d80665","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars3.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars3.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2017-04-26T13:09:22Z","pushed_at":"2017-04-26T13:16:49Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"[email protected]:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"https://www.theguardian.com","size":517653,"stargazers_count":3551,"watchers_count":3551,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":383,"mirror_url":null,"open_issues_count":45,"forks":383,"open_issues":45,"watchers":3551,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/16562"},"html":{"href":"https://github.com/guardian/frontend/pull/16562"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/16562"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/16562/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/16562/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/16562/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/6bd1c744c1b43c1dcaa527cc16942315ac890212"}}}} | {
"id": 4370755,
"name": "guardian/frontend",
"url": "https://api.github.com/repos/guardian/frontend"
} | {
"id": 8607683,
"login": "katebee",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8607683?",
"url": "https://api.github.com/users/katebee"
} | {
"id": 164318,
"login": "guardian",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/164318?",
"url": "https://api.github.com/orgs/guardian"
} | 2017-04-26T13:26:26 | 5760473602 | {"actor":{"display_login":"katebee"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/123716270","pull_request_review_id":45948038,"id":123716270,"diff_hunk":"@@ -35,9 +33,13 @@ define([\n showForSensitive: true,\n \n pageCheck: function(page) {\n- return page.keywordIds &&\n+ var isElection = page.keywordIds &&\n page.keywordIds.includes('general-election-2017') &&\n page.contentType === 'Interactive';\n+\n+ var isFootball = page.pageId.indexOf('transfer-window-2017-every-deal-in-europes-top-five-leagues') > -1;","path":"static/src/javascripts-legacy/projects/common/modules/experiments/tests/acquisitions-epic-election-interactive-end.js","position":45,"original_position":45,"commit_id":"764d2f43e38efe7dbb8f606f657e5c55e262b59f","original_commit_id":"764d2f43e38efe7dbb8f606f657e5c55e262b59f","user":{"login":"joelochlann","id":5122968,"avatar_url":"https://avatars0.githubusercontent.com/u/5122968?v=3","gravatar_id":"","url":"https://api.github.com/users/joelochlann","html_url":"https://github.com/joelochlann","followers_url":"https://api.github.com/users/joelochlann/followers","following_url":"https://api.github.com/users/joelochlann/following{/other_user}","gists_url":"https://api.github.com/users/joelochlann/gists{/gist_id}","starred_url":"https://api.github.com/users/joelochlann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelochlann/subscriptions","organizations_url":"https://api.github.com/users/joelochlann/orgs","repos_url":"https://api.github.com/users/joelochlann/repos","events_url":"https://api.github.com/users/joelochlann/events{/privacy}","received_events_url":"https://api.github.com/users/joelochlann/received_events","type":"User","site_admin":false},"body":"I think you could use `.includes()` here - should be polyfilled","created_at":"2017-06-23T10:13:25Z","updated_at":"2017-06-23T10:13:44Z","html_url":"https://github.com/guardian/frontend/pull/17249#discussion_r123716270","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/17249","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/123716270"},"html":{"href":"https://github.com/guardian/frontend/pull/17249#discussion_r123716270"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/17249"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/17249","id":127174981,"html_url":"https://github.com/guardian/frontend/pull/17249","diff_url":"https://github.com/guardian/frontend/pull/17249.diff","patch_url":"https://github.com/guardian/frontend/pull/17249.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/17249","number":17249,"state":"open","locked":false,"title":"Add Epic to end of football interactive","user":{"login":"desbo","id":1064734,"avatar_url":"https://avatars0.githubusercontent.com/u/1064734?v=3","gravatar_id":"","url":"https://api.github.com/users/desbo","html_url":"https://github.com/desbo","followers_url":"https://api.github.com/users/desbo/followers","following_url":"https://api.github.com/users/desbo/following{/other_user}","gists_url":"https://api.github.com/users/desbo/gists{/gist_id}","starred_url":"https://api.github.com/users/desbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desbo/subscriptions","organizations_url":"https://api.github.com/users/desbo/orgs","repos_url":"https://api.github.com/users/desbo/repos","events_url":"https://api.github.com/users/desbo/events{/privacy}","received_events_url":"https://api.github.com/users/desbo/received_events","type":"User","site_admin":false},"body":"## What does this change?\r\nAdds the Epic to the end of a football interactive. ","created_at":"2017-06-23T10:07:40Z","updated_at":"2017-06-23T10:13:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dac5793a7721a9447c9ecd84e01f6686983cc07e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/17249/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/17249/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/17249/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/764d2f43e38efe7dbb8f606f657e5c55e262b59f","head":{"label":"guardian:football-interactive","ref":"football-interactive","sha":"764d2f43e38efe7dbb8f606f657e5c55e262b59f","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars3.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars3.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2017-06-22T23:25:18Z","pushed_at":"2017-06-23T10:08:13Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"[email protected]:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"https://www.theguardian.com","size":528625,"stargazers_count":3586,"watchers_count":3586,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":389,"mirror_url":null,"open_issues_count":49,"forks":389,"open_issues":49,"watchers":3586,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"a7e9b9aa7edfd44c10f6d15a18776d3b8dc99340","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars3.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars3.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2017-06-22T23:25:18Z","pushed_at":"2017-06-23T10:08:13Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"[email protected]:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"https://www.theguardian.com","size":528625,"stargazers_count":3586,"watchers_count":3586,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":389,"mirror_url":null,"open_issues_count":49,"forks":389,"open_issues":49,"watchers":3586,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/17249"},"html":{"href":"https://github.com/guardian/frontend/pull/17249"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/17249"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/17249/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/17249/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/17249/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/764d2f43e38efe7dbb8f606f657e5c55e262b59f"}}}} | {
"id": 4370755,
"name": "guardian/frontend",
"url": "https://api.github.com/repos/guardian/frontend"
} | {
"id": 5122968,
"login": "joelochlann",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5122968?",
"url": "https://api.github.com/users/joelochlann"
} | {
"id": 164318,
"login": "guardian",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/164318?",
"url": "https://api.github.com/orgs/guardian"
} | 2017-06-23T10:13:25 | 6124968220 | {"actor":{"display_login":"joelochlann"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/guardian/facia-scala-client/pulls/comments/137513351","pull_request_review_id":61189768,"id":137513351,"diff_hunk":"@@ -3,7 +3,8 @@ package com.gu.facia.client.json\n import org.joda.time.DateTime\n import org.joda.time.format.ISODateTimeFormat\n import play.api.libs.json._\n-import scala.util.control.Exception.nonFatalCatch\n+\n+import scala.util.control.Exception.allCatch","path":"facia-json/src/main/scala/com/gu/facia/client/json/JodaFormat.scala","position":6,"original_position":6,"commit_id":"4f7805ca26e0146e729bb85761eeffb10f43dc92","original_commit_id":"4f7805ca26e0146e729bb85761eeffb10f43dc92","user":{"login":"TBonnin","id":233326,"avatar_url":"https://avatars2.githubusercontent.com/u/233326?v=4","gravatar_id":"","url":"https://api.github.com/users/TBonnin","html_url":"https://github.com/TBonnin","followers_url":"https://api.github.com/users/TBonnin/followers","following_url":"https://api.github.com/users/TBonnin/following{/other_user}","gists_url":"https://api.github.com/users/TBonnin/gists{/gist_id}","starred_url":"https://api.github.com/users/TBonnin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TBonnin/subscriptions","organizations_url":"https://api.github.com/users/TBonnin/orgs","repos_url":"https://api.github.com/users/TBonnin/repos","events_url":"https://api.github.com/users/TBonnin/events{/privacy}","received_events_url":"https://api.github.com/users/TBonnin/received_events","type":"User","site_admin":false},"body":"not related to the PR but a improvement nonetheless","created_at":"2017-09-07T11:26:21Z","updated_at":"2017-09-07T11:26:21Z","html_url":"https://github.com/guardian/facia-scala-client/pull/196#discussion_r137513351","pull_request_url":"https://api.github.com/repos/guardian/facia-scala-client/pulls/196","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/guardian/facia-scala-client/pulls/comments/137513351"},"html":{"href":"https://github.com/guardian/facia-scala-client/pull/196#discussion_r137513351"},"pull_request":{"href":"https://api.github.com/repos/guardian/facia-scala-client/pulls/196"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/facia-scala-client/pulls/196","id":139780547,"html_url":"https://github.com/guardian/facia-scala-client/pull/196","diff_url":"https://github.com/guardian/facia-scala-client/pull/196.diff","patch_url":"https://github.com/guardian/facia-scala-client/pull/196.patch","issue_url":"https://api.github.com/repos/guardian/facia-scala-client/issues/196","number":196,"state":"open","locked":false,"title":"Take timezone offset when parsing DateTime","user":{"login":"TBonnin","id":233326,"avatar_url":"https://avatars2.githubusercontent.com/u/233326?v=4","gravatar_id":"","url":"https://api.github.com/users/TBonnin","html_url":"https://github.com/TBonnin","followers_url":"https://api.github.com/users/TBonnin/followers","following_url":"https://api.github.com/users/TBonnin/following{/other_user}","gists_url":"https://api.github.com/users/TBonnin/gists{/gist_id}","starred_url":"https://api.github.com/users/TBonnin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TBonnin/subscriptions","organizations_url":"https://api.github.com/users/TBonnin/orgs","repos_url":"https://api.github.com/users/TBonnin/repos","events_url":"https://api.github.com/users/TBonnin/events{/privacy}","received_events_url":"https://api.github.com/users/TBonnin/received_events","type":"User","site_admin":false},"body":"Previous version of DateTime deserialiser was not taking into account timezone offset","created_at":"2017-09-07T11:25:54Z","updated_at":"2017-09-07T11:26:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30a40dea1c88ff85e4b748b3992805dad511a04e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"janua","id":445472,"avatar_url":"https://avatars2.githubusercontent.com/u/445472?v=4","gravatar_id":"","url":"https://api.github.com/users/janua","html_url":"https://github.com/janua","followers_url":"https://api.github.com/users/janua/followers","following_url":"https://api.github.com/users/janua/following{/other_user}","gists_url":"https://api.github.com/users/janua/gists{/gist_id}","starred_url":"https://api.github.com/users/janua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janua/subscriptions","organizations_url":"https://api.github.com/users/janua/orgs","repos_url":"https://api.github.com/users/janua/repos","events_url":"https://api.github.com/users/janua/events{/privacy}","received_events_url":"https://api.github.com/users/janua/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/facia-scala-client/pulls/196/commits","review_comments_url":"https://api.github.com/repos/guardian/facia-scala-client/pulls/196/comments","review_comment_url":"https://api.github.com/repos/guardian/facia-scala-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/facia-scala-client/issues/196/comments","statuses_url":"https://api.github.com/repos/guardian/facia-scala-client/statuses/4f7805ca26e0146e729bb85761eeffb10f43dc92","head":{"label":"guardian:tbonnin/fix-test-timezone","ref":"tbonnin/fix-test-timezone","sha":"4f7805ca26e0146e729bb85761eeffb10f43dc92","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":20723151,"name":"facia-scala-client","full_name":"guardian/facia-scala-client","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/facia-scala-client","description":"Low level client for the Facia JSON API","fork":false,"url":"https://api.github.com/repos/guardian/facia-scala-client","forks_url":"https://api.github.com/repos/guardian/facia-scala-client/forks","keys_url":"https://api.github.com/repos/guardian/facia-scala-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/facia-scala-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/facia-scala-client/teams","hooks_url":"https://api.github.com/repos/guardian/facia-scala-client/hooks","issue_events_url":"https://api.github.com/repos/guardian/facia-scala-client/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/facia-scala-client/events","assignees_url":"https://api.github.com/repos/guardian/facia-scala-client/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/facia-scala-client/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/facia-scala-client/tags","blobs_url":"https://api.github.com/repos/guardian/facia-scala-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/facia-scala-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/facia-scala-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/facia-scala-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/facia-scala-client/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/facia-scala-client/languages","stargazers_url":"https://api.github.com/repos/guardian/facia-scala-client/stargazers","contributors_url":"https://api.github.com/repos/guardian/facia-scala-client/contributors","subscribers_url":"https://api.github.com/repos/guardian/facia-scala-client/subscribers","subscription_url":"https://api.github.com/repos/guardian/facia-scala-client/subscription","commits_url":"https://api.github.com/repos/guardian/facia-scala-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/facia-scala-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/facia-scala-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/facia-scala-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/facia-scala-client/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/facia-scala-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/facia-scala-client/merges","archive_url":"https://api.github.com/repos/guardian/facia-scala-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/facia-scala-client/downloads","issues_url":"https://api.github.com/repos/guardian/facia-scala-client/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/facia-scala-client/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/facia-scala-client/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/facia-scala-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/facia-scala-client/labels{/name}","releases_url":"https://api.github.com/repos/guardian/facia-scala-client/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/facia-scala-client/deployments","created_at":"2014-06-11T11:45:55Z","updated_at":"2016-11-15T11:42:12Z","pushed_at":"2017-09-07T11:25:55Z","git_url":"git://github.com/guardian/facia-scala-client.git","ssh_url":"[email protected]:guardian/facia-scala-client.git","clone_url":"https://github.com/guardian/facia-scala-client.git","svn_url":"https://github.com/guardian/facia-scala-client","homepage":null,"size":974,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"52b1d9b15e7770c04e421482c506f066f4b6a30d","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":20723151,"name":"facia-scala-client","full_name":"guardian/facia-scala-client","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/facia-scala-client","description":"Low level client for the Facia JSON API","fork":false,"url":"https://api.github.com/repos/guardian/facia-scala-client","forks_url":"https://api.github.com/repos/guardian/facia-scala-client/forks","keys_url":"https://api.github.com/repos/guardian/facia-scala-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/facia-scala-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/facia-scala-client/teams","hooks_url":"https://api.github.com/repos/guardian/facia-scala-client/hooks","issue_events_url":"https://api.github.com/repos/guardian/facia-scala-client/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/facia-scala-client/events","assignees_url":"https://api.github.com/repos/guardian/facia-scala-client/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/facia-scala-client/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/facia-scala-client/tags","blobs_url":"https://api.github.com/repos/guardian/facia-scala-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/facia-scala-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/facia-scala-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/facia-scala-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/facia-scala-client/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/facia-scala-client/languages","stargazers_url":"https://api.github.com/repos/guardian/facia-scala-client/stargazers","contributors_url":"https://api.github.com/repos/guardian/facia-scala-client/contributors","subscribers_url":"https://api.github.com/repos/guardian/facia-scala-client/subscribers","subscription_url":"https://api.github.com/repos/guardian/facia-scala-client/subscription","commits_url":"https://api.github.com/repos/guardian/facia-scala-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/facia-scala-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/facia-scala-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/facia-scala-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/facia-scala-client/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/facia-scala-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/facia-scala-client/merges","archive_url":"https://api.github.com/repos/guardian/facia-scala-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/facia-scala-client/downloads","issues_url":"https://api.github.com/repos/guardian/facia-scala-client/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/facia-scala-client/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/facia-scala-client/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/facia-scala-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/facia-scala-client/labels{/name}","releases_url":"https://api.github.com/repos/guardian/facia-scala-client/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/facia-scala-client/deployments","created_at":"2014-06-11T11:45:55Z","updated_at":"2016-11-15T11:42:12Z","pushed_at":"2017-09-07T11:25:55Z","git_url":"git://github.com/guardian/facia-scala-client.git","ssh_url":"[email protected]:guardian/facia-scala-client.git","clone_url":"https://github.com/guardian/facia-scala-client.git","svn_url":"https://github.com/guardian/facia-scala-client","homepage":null,"size":974,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/facia-scala-client/pulls/196"},"html":{"href":"https://github.com/guardian/facia-scala-client/pull/196"},"issue":{"href":"https://api.github.com/repos/guardian/facia-scala-client/issues/196"},"comments":{"href":"https://api.github.com/repos/guardian/facia-scala-client/issues/196/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/facia-scala-client/pulls/196/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/facia-scala-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/facia-scala-client/pulls/196/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/facia-scala-client/statuses/4f7805ca26e0146e729bb85761eeffb10f43dc92"}},"author_association":"MEMBER"}} | {
"id": 20723151,
"name": "guardian/facia-scala-client",
"url": "https://api.github.com/repos/guardian/facia-scala-client"
} | {
"id": 233326,
"login": "TBonnin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/233326?",
"url": "https://api.github.com/users/TBonnin"
} | {
"id": 164318,
"login": "guardian",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/164318?",
"url": "https://api.github.com/orgs/guardian"
} | 2017-09-07T11:26:21 | 6560968636 | {"actor":{"display_login":"TBonnin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hawkular/hawkular-commons/pulls/comments/151508835","pull_request_review_id":77229323,"id":151508835,"diff_hunk":"@@ -104,26 +110,35 @@ public static Builder builder() {\n @JsonInclude(Include.NON_NULL)\n private final MetricUnit unit;\n \n- @DocModelProperty(description = \"Metric labels.\",\n+ @DocModelProperty(description = \"Metric expression used to evaluate the metric value. If not set, assume $metric.\",","path":"hawkular-inventory-parent/hawkular-inventory-api/src/main/java/org/hawkular/inventory/api/model/Metric.java","position":31,"original_position":31,"commit_id":"538f64d1ca579bbd1f8087290bb4be8f4de094ca","original_commit_id":"538f64d1ca579bbd1f8087290bb4be8f4de094ca","user":{"login":"jshaughn","id":2104052,"avatar_url":"https://avatars1.githubusercontent.com/u/2104052?v=4","gravatar_id":"","url":"https://api.github.com/users/jshaughn","html_url":"https://github.com/jshaughn","followers_url":"https://api.github.com/users/jshaughn/followers","following_url":"https://api.github.com/users/jshaughn/following{/other_user}","gists_url":"https://api.github.com/users/jshaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/jshaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jshaughn/subscriptions","organizations_url":"https://api.github.com/users/jshaughn/orgs","repos_url":"https://api.github.com/users/jshaughn/repos","events_url":"https://api.github.com/users/jshaughn/events{/privacy}","received_events_url":"https://api.github.com/users/jshaughn/received_events","type":"User","site_admin":false},"body":"I think this should always be set, right?","created_at":"2017-11-16T19:08:40Z","updated_at":"2017-11-16T19:08:41Z","html_url":"https://github.com/hawkular/hawkular-commons/pull/192#discussion_r151508835","pull_request_url":"https://api.github.com/repos/hawkular/hawkular-commons/pulls/192","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-commons/pulls/comments/151508835"},"html":{"href":"https://github.com/hawkular/hawkular-commons/pull/192#discussion_r151508835"},"pull_request":{"href":"https://api.github.com/repos/hawkular/hawkular-commons/pulls/192"}}},"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-commons/pulls/192","id":153098459,"html_url":"https://github.com/hawkular/hawkular-commons/pull/192","diff_url":"https://github.com/hawkular/hawkular-commons/pull/192.diff","patch_url":"https://github.com/hawkular/hawkular-commons/pull/192.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-commons/issues/192","number":192,"state":"open","locked":false,"title":"add expression to Metric API","user":{"login":"jmazzitelli","id":2029470,"avatar_url":"https://avatars0.githubusercontent.com/u/2029470?v=4","gravatar_id":"","url":"https://api.github.com/users/jmazzitelli","html_url":"https://github.com/jmazzitelli","followers_url":"https://api.github.com/users/jmazzitelli/followers","following_url":"https://api.github.com/users/jmazzitelli/following{/other_user}","gists_url":"https://api.github.com/users/jmazzitelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jmazzitelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmazzitelli/subscriptions","organizations_url":"https://api.github.com/users/jmazzitelli/orgs","repos_url":"https://api.github.com/users/jmazzitelli/repos","events_url":"https://api.github.com/users/jmazzitelli/events{/privacy}","received_events_url":"https://api.github.com/users/jmazzitelli/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-16T17:08:52Z","updated_at":"2017-11-16T19:08:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55b952c09eb60eb772ffe17f2663076ab3015c0a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-commons/pulls/192/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-commons/pulls/192/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-commons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-commons/issues/192/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-commons/statuses/538f64d1ca579bbd1f8087290bb4be8f4de094ca","head":{"label":"jmazzitelli:metric-expression","ref":"metric-expression","sha":"538f64d1ca579bbd1f8087290bb4be8f4de094ca","user":{"login":"jmazzitelli","id":2029470,"avatar_url":"https://avatars0.githubusercontent.com/u/2029470?v=4","gravatar_id":"","url":"https://api.github.com/users/jmazzitelli","html_url":"https://github.com/jmazzitelli","followers_url":"https://api.github.com/users/jmazzitelli/followers","following_url":"https://api.github.com/users/jmazzitelli/following{/other_user}","gists_url":"https://api.github.com/users/jmazzitelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jmazzitelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmazzitelli/subscriptions","organizations_url":"https://api.github.com/users/jmazzitelli/orgs","repos_url":"https://api.github.com/users/jmazzitelli/repos","events_url":"https://api.github.com/users/jmazzitelli/events{/privacy}","received_events_url":"https://api.github.com/users/jmazzitelli/received_events","type":"User","site_admin":false},"repo":{"id":60123439,"name":"hawkular-commons","full_name":"jmazzitelli/hawkular-commons","owner":{"login":"jmazzitelli","id":2029470,"avatar_url":"https://avatars0.githubusercontent.com/u/2029470?v=4","gravatar_id":"","url":"https://api.github.com/users/jmazzitelli","html_url":"https://github.com/jmazzitelli","followers_url":"https://api.github.com/users/jmazzitelli/followers","following_url":"https://api.github.com/users/jmazzitelli/following{/other_user}","gists_url":"https://api.github.com/users/jmazzitelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jmazzitelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmazzitelli/subscriptions","organizations_url":"https://api.github.com/users/jmazzitelli/orgs","repos_url":"https://api.github.com/users/jmazzitelli/repos","events_url":"https://api.github.com/users/jmazzitelli/events{/privacy}","received_events_url":"https://api.github.com/users/jmazzitelli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmazzitelli/hawkular-commons","description":null,"fork":true,"url":"https://api.github.com/repos/jmazzitelli/hawkular-commons","forks_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/forks","keys_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/teams","hooks_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/hooks","issue_events_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/issues/events{/number}","events_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/events","assignees_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/assignees{/user}","branches_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/branches{/branch}","tags_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/tags","blobs_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/languages","stargazers_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/stargazers","contributors_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/contributors","subscribers_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/subscribers","subscription_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/subscription","commits_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/contents/{+path}","compare_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/merges","archive_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/downloads","issues_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/issues{/number}","pulls_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/labels{/name}","releases_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/releases{/id}","deployments_url":"https://api.github.com/repos/jmazzitelli/hawkular-commons/deployments","created_at":"2016-05-31T21:06:29Z","updated_at":"2016-05-31T21:06:30Z","pushed_at":"2017-11-16T17:07:56Z","git_url":"git://github.com/jmazzitelli/hawkular-commons.git","ssh_url":"[email protected]:jmazzitelli/hawkular-commons.git","clone_url":"https://github.com/jmazzitelli/hawkular-commons.git","svn_url":"https://github.com/jmazzitelli/hawkular-commons","homepage":null,"size":1511,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:hawkular-1275","ref":"hawkular-1275","sha":"81f97d6fe89b714c9f1797a3326e42befeb94e55","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars2.githubusercontent.com/u/10179627?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":36057427,"name":"hawkular-commons","full_name":"hawkular/hawkular-commons","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars2.githubusercontent.com/u/10179627?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-commons","description":null,"fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-commons","forks_url":"https://api.github.com/repos/hawkular/hawkular-commons/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-commons/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-commons/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-commons/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-commons/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-commons/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-commons/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-commons/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-commons/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-commons/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-commons/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-commons/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-commons/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-commons/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-commons/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-commons/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-commons/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-commons/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-commons/releases{/id}","deployments_url":"https://api.github.com/repos/hawkular/hawkular-commons/deployments","created_at":"2015-05-22T07:03:53Z","updated_at":"2017-10-20T07:30:47Z","pushed_at":"2017-11-16T17:08:53Z","git_url":"git://github.com/hawkular/hawkular-commons.git","ssh_url":"[email protected]:hawkular/hawkular-commons.git","clone_url":"https://github.com/hawkular/hawkular-commons.git","svn_url":"https://github.com/hawkular/hawkular-commons","homepage":null,"size":1512,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":17,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-commons/pulls/192"},"html":{"href":"https://github.com/hawkular/hawkular-commons/pull/192"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-commons/issues/192"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-commons/issues/192/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-commons/pulls/192/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-commons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-commons/pulls/192/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-commons/statuses/538f64d1ca579bbd1f8087290bb4be8f4de094ca"}},"author_association":"CONTRIBUTOR"}} | {
"id": 36057427,
"name": "hawkular/hawkular-commons",
"url": "https://api.github.com/repos/hawkular/hawkular-commons"
} | {
"id": 2104052,
"login": "jshaughn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2104052?",
"url": "https://api.github.com/users/jshaughn"
} | {
"id": 10179627,
"login": "hawkular",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10179627?",
"url": "https://api.github.com/orgs/hawkular"
} | 2017-11-16T19:08:40 | 6866112390 | {"actor":{"display_login":"jshaughn"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/comments/128606105","pull_request_review_id":51302197,"id":128606105,"diff_hunk":"@@ -0,0 +1,158 @@\n+/*\n+ * Copyright 2014-2017 Red Hat, Inc. and/or its affiliates\n+ * and other contributors as indicated by the @author tags.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.hawkular.openshift.auth.org.hawkular.openshift.namespace;\n+\n+import java.io.IOException;\n+import java.io.InputStream;\n+import java.net.URL;\n+import java.util.HashMap;\n+import java.util.Map;\n+\n+import javax.net.ssl.HttpsURLConnection;\n+\n+import org.jboss.logging.Logger;\n+\n+import com.fasterxml.jackson.core.JsonFactory;\n+import com.fasterxml.jackson.core.JsonParser;\n+import com.fasterxml.jackson.databind.JsonNode;\n+import com.fasterxml.jackson.databind.ObjectMapper;\n+\n+/**\n+ *\n+ */\n+public class NamespaceListener {\n+\n+ private static final Logger log = Logger.getLogger(NamespaceListener.class);\n+\n+ // The authentication token used by the filter to connect to the OpenShift Master API\n+ private final String token;\n+\n+ // Maps the namespace name to the namespace id\n+ private final Map<String, String> namespaces;\n+\n+ private boolean run = true;\n+\n+ /**\n+ *\n+ * @param token The token to be used by the\n+ */\n+ public NamespaceListener(String token) {\n+ log.debug(\"Creating NamespaceListener\");\n+ this.token = token;\n+\n+ namespaces = new HashMap<>();\n+ log.debug(\"Namespace listener starting\");\n+ new Thread(new Listener()).start();\n+ }\n+\n+ public void stop() {\n+ run = false;\n+ }\n+\n+ /**\n+ * Returns the namespace id for a particular namespace name\n+ * @param namespaceName The name of the namespace\n+ * @return The id of the namespace or null if the namespace does not exist\n+ */\n+ public String getNamespaceId(String namespaceName) {\n+ return namespaces.get(namespaceName);\n+ }\n+\n+ private class Listener implements Runnable {\n+\n+ @Override\n+ public void run() {\n+ while(run) {\n+ try {\n+ String path = \"api/v1/namespaces\";\n+ URL url = new URL(NamespaceHandler.KUBERNETES_MASTER_URL + \"/\" + path + \"?watch=true\");\n+\n+ HttpsURLConnection connection = (HttpsURLConnection) url.openConnection();\n+ connection.setRequestMethod(\"GET\");\n+\n+ connection.setRequestProperty(\"Accept\", \"application/json\");\n+ connection.setRequestProperty(\"Authorization\", \"Bearer \" + token);\n+\n+ connection.setConnectTimeout(5000);\n+\n+ // Since the connection is left open for new events, set to 0 which indicates an infinite timeout\n+ // Note that the server will eventually close this connection, so we will need to reconnect when this happens\n+ connection.setReadTimeout(0);\n+\n+ connection.connect();\n+ int responseCode = connection.getResponseCode();\n+\n+ if (responseCode == 200) {\n+\n+ JsonFactory jsonFactory = new JsonFactory();\n+ jsonFactory.setCodec(new ObjectMapper());\n+\n+ InputStream inputStream = connection.getInputStream();\n+ JsonParser jsonParser = jsonFactory.createParser(inputStream);\n+\n+ // this will fetch all the available tenants and will then wait until new tenant events occur\n+ JsonNode jsonNode = jsonParser.readValueAsTree();\n+\n+ // When the connection is closed, the response is null\n+ while (jsonNode != null) {\n+ JsonNode metaData = jsonNode.get(\"object\").get(\"metadata\");\n+ String projectName = metaData.get(\"name\").asText();\n+ String projectID = metaData.get(\"uid\").asText();\n+\n+ String action = jsonNode.get(\"type\").asText();\n+\n+ if (action.equals(\"ADDED\")) {\n+ log.debug(\"Project \" + projectName + \"[\" + projectID + \"] has been added.\");\n+ namespaces.put(projectName, projectID);\n+ } else if (action.equals(\"DELETED\")) {\n+ log.debug(\"Project \" + projectName + \"[\" + projectID + \"] has been removed.\");\n+ namespaces.remove(projectName, projectID);\n+ }\n+\n+ // this will read the next available tenant if available or wait until the next available\n+ // tenant event occurs\n+ jsonNode = jsonParser.readValueAsTree();\n+ }\n+\n+ jsonParser.close();\n+ inputStream.close();\n+ namespaces.clear();\n+\n+ } else {\n+ log.error(\"Error getting metadata. Response code \" + responseCode);\n+ try {\n+ // try again after a second\n+ Thread.sleep(1000);\n+ } catch (InterruptedException e) {\n+ log.error(e);","path":"containers/hawkular-openshift-security-filter/src/main/java/org/hawkular/openshift/auth/org/hawkular/openshift/namespace/NamespaceListener.java","position":142,"original_position":142,"commit_id":"99c7b8911ad95de9e5f89b8af8c532b47bcb865e","original_commit_id":"99c7b8911ad95de9e5f89b8af8c532b47bcb865e","user":{"login":"mwringe","id":691166,"avatar_url":"https://avatars0.githubusercontent.com/u/691166?v=4","gravatar_id":"","url":"https://api.github.com/users/mwringe","html_url":"https://github.com/mwringe","followers_url":"https://api.github.com/users/mwringe/followers","following_url":"https://api.github.com/users/mwringe/following{/other_user}","gists_url":"https://api.github.com/users/mwringe/gists{/gist_id}","starred_url":"https://api.github.com/users/mwringe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwringe/subscriptions","organizations_url":"https://api.github.com/users/mwringe/orgs","repos_url":"https://api.github.com/users/mwringe/repos","events_url":"https://api.github.com/users/mwringe/events{/privacy}","received_events_url":"https://api.github.com/users/mwringe/received_events","type":"User","site_admin":false},"body":"ok","created_at":"2017-07-20T19:11:17Z","updated_at":"2017-07-20T19:11:17Z","html_url":"https://github.com/hawkular/hawkular-metrics/pull/846#discussion_r128606105","pull_request_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/846","_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/comments/128606105"},"html":{"href":"https://github.com/hawkular/hawkular-metrics/pull/846#discussion_r128606105"},"pull_request":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/846"}}},"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/846","id":130432954,"html_url":"https://github.com/hawkular/hawkular-metrics/pull/846","diff_url":"https://github.com/hawkular/hawkular-metrics/pull/846.diff","patch_url":"https://github.com/hawkular/hawkular-metrics/pull/846.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/846","number":846,"state":"open","locked":false,"title":"Update the tenant filter to use project id's as tenant name","user":{"login":"mwringe","id":691166,"avatar_url":"https://avatars0.githubusercontent.com/u/691166?v=4","gravatar_id":"","url":"https://api.github.com/users/mwringe","html_url":"https://github.com/mwringe","followers_url":"https://api.github.com/users/mwringe/followers","following_url":"https://api.github.com/users/mwringe/following{/other_user}","gists_url":"https://api.github.com/users/mwringe/gists{/gist_id}","starred_url":"https://api.github.com/users/mwringe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwringe/subscriptions","organizations_url":"https://api.github.com/users/mwringe/orgs","repos_url":"https://api.github.com/users/mwringe/repos","events_url":"https://api.github.com/users/mwringe/events{/privacy}","received_events_url":"https://api.github.com/users/mwringe/received_events","type":"User","site_admin":false},"body":"This updates the current filter to use ${OPENSHIFT_PROJECT_NAME}:${OPENSHIFT_PROJECT_ID} as the tenant name in Hawkular Metrics, instead of relying just on the project name","created_at":"2017-07-13T18:08:19Z","updated_at":"2017-07-20T19:11:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42704de8aa14a050d6e509e2b7928c65aa1a1c6b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/846/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/846/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/846/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-metrics/statuses/99c7b8911ad95de9e5f89b8af8c532b47bcb865e","head":{"label":"mwringe:openshift-tenant-id","ref":"openshift-tenant-id","sha":"99c7b8911ad95de9e5f89b8af8c532b47bcb865e","user":{"login":"mwringe","id":691166,"avatar_url":"https://avatars0.githubusercontent.com/u/691166?v=4","gravatar_id":"","url":"https://api.github.com/users/mwringe","html_url":"https://github.com/mwringe","followers_url":"https://api.github.com/users/mwringe/followers","following_url":"https://api.github.com/users/mwringe/following{/other_user}","gists_url":"https://api.github.com/users/mwringe/gists{/gist_id}","starred_url":"https://api.github.com/users/mwringe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwringe/subscriptions","organizations_url":"https://api.github.com/users/mwringe/orgs","repos_url":"https://api.github.com/users/mwringe/repos","events_url":"https://api.github.com/users/mwringe/events{/privacy}","received_events_url":"https://api.github.com/users/mwringe/received_events","type":"User","site_admin":false},"repo":{"id":31267192,"name":"hawkular-metrics","full_name":"mwringe/hawkular-metrics","owner":{"login":"mwringe","id":691166,"avatar_url":"https://avatars0.githubusercontent.com/u/691166?v=4","gravatar_id":"","url":"https://api.github.com/users/mwringe","html_url":"https://github.com/mwringe","followers_url":"https://api.github.com/users/mwringe/followers","following_url":"https://api.github.com/users/mwringe/following{/other_user}","gists_url":"https://api.github.com/users/mwringe/gists{/gist_id}","starred_url":"https://api.github.com/users/mwringe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwringe/subscriptions","organizations_url":"https://api.github.com/users/mwringe/orgs","repos_url":"https://api.github.com/users/mwringe/repos","events_url":"https://api.github.com/users/mwringe/events{/privacy}","received_events_url":"https://api.github.com/users/mwringe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwringe/hawkular-metrics","description":"Time Series Metrics Engine based on Cassandra","fork":true,"url":"https://api.github.com/repos/mwringe/hawkular-metrics","forks_url":"https://api.github.com/repos/mwringe/hawkular-metrics/forks","keys_url":"https://api.github.com/repos/mwringe/hawkular-metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwringe/hawkular-metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwringe/hawkular-metrics/teams","hooks_url":"https://api.github.com/repos/mwringe/hawkular-metrics/hooks","issue_events_url":"https://api.github.com/repos/mwringe/hawkular-metrics/issues/events{/number}","events_url":"https://api.github.com/repos/mwringe/hawkular-metrics/events","assignees_url":"https://api.github.com/repos/mwringe/hawkular-metrics/assignees{/user}","branches_url":"https://api.github.com/repos/mwringe/hawkular-metrics/branches{/branch}","tags_url":"https://api.github.com/repos/mwringe/hawkular-metrics/tags","blobs_url":"https://api.github.com/repos/mwringe/hawkular-metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwringe/hawkular-metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwringe/hawkular-metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwringe/hawkular-metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwringe/hawkular-metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/mwringe/hawkular-metrics/languages","stargazers_url":"https://api.github.com/repos/mwringe/hawkular-metrics/stargazers","contributors_url":"https://api.github.com/repos/mwringe/hawkular-metrics/contributors","subscribers_url":"https://api.github.com/repos/mwringe/hawkular-metrics/subscribers","subscription_url":"https://api.github.com/repos/mwringe/hawkular-metrics/subscription","commits_url":"https://api.github.com/repos/mwringe/hawkular-metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwringe/hawkular-metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwringe/hawkular-metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwringe/hawkular-metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwringe/hawkular-metrics/contents/{+path}","compare_url":"https://api.github.com/repos/mwringe/hawkular-metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwringe/hawkular-metrics/merges","archive_url":"https://api.github.com/repos/mwringe/hawkular-metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwringe/hawkular-metrics/downloads","issues_url":"https://api.github.com/repos/mwringe/hawkular-metrics/issues{/number}","pulls_url":"https://api.github.com/repos/mwringe/hawkular-metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/mwringe/hawkular-metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/mwringe/hawkular-metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwringe/hawkular-metrics/labels{/name}","releases_url":"https://api.github.com/repos/mwringe/hawkular-metrics/releases{/id}","deployments_url":"https://api.github.com/repos/mwringe/hawkular-metrics/deployments","created_at":"2015-02-24T15:44:53Z","updated_at":"2016-02-08T20:46:14Z","pushed_at":"2017-07-17T21:53:48Z","git_url":"git://github.com/mwringe/hawkular-metrics.git","ssh_url":"[email protected]:mwringe/hawkular-metrics.git","clone_url":"https://github.com/mwringe/hawkular-metrics.git","svn_url":"https://github.com/mwringe/hawkular-metrics","homepage":"","size":16389,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"cb7481f2be9284d9da38bd7503c0bb8e3970c2bb","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars2.githubusercontent.com/u/10179627?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":17705626,"name":"hawkular-metrics","full_name":"hawkular/hawkular-metrics","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars2.githubusercontent.com/u/10179627?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-metrics","description":"Time Series Metrics Engine based on Cassandra","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-metrics","forks_url":"https://api.github.com/repos/hawkular/hawkular-metrics/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-metrics/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-metrics/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-metrics/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-metrics/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-metrics/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-metrics/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-metrics/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-metrics/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-metrics/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-metrics/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-metrics/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-metrics/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-metrics/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-metrics/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-metrics/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-metrics/releases{/id}","deployments_url":"https://api.github.com/repos/hawkular/hawkular-metrics/deployments","created_at":"2014-03-13T10:07:30Z","updated_at":"2017-07-14T22:44:19Z","pushed_at":"2017-07-20T19:09:07Z","git_url":"git://github.com/hawkular/hawkular-metrics.git","ssh_url":"[email protected]:hawkular/hawkular-metrics.git","clone_url":"https://github.com/hawkular/hawkular-metrics.git","svn_url":"https://github.com/hawkular/hawkular-metrics","homepage":"","size":21126,"stargazers_count":159,"watchers_count":159,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":28,"forks":63,"open_issues":28,"watchers":159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/846"},"html":{"href":"https://github.com/hawkular/hawkular-metrics/pull/846"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/846"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/846/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/846/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/846/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/statuses/99c7b8911ad95de9e5f89b8af8c532b47bcb865e"}}}} | {
"id": 17705626,
"name": "hawkular/hawkular-metrics",
"url": "https://api.github.com/repos/hawkular/hawkular-metrics"
} | {
"id": 691166,
"login": "mwringe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/691166?",
"url": "https://api.github.com/users/mwringe"
} | {
"id": 10179627,
"login": "hawkular",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10179627?",
"url": "https://api.github.com/orgs/hawkular"
} | 2017-07-20T19:11:17 | 6297912611 | {"actor":{"display_login":"mwringe"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/hpi-swt2/sport-portal/pulls/comments/158743729","pull_request_review_id":85594677,"id":158743729,"diff_hunk":"@@ -45,6 +45,24 @@\n deadline { Date.current - 1 }\n end\n \n+ trait :with_teams do\n+ transient do\n+ teams_count 5","path":"spec/factories/events.rb","position":6,"original_position":6,"commit_id":"149ad64eaf2a9439fe5beec9f5a91e033ca9dfe0","original_commit_id":"4c0702c090af5d2f26909037c1764abbab58267e","user":{"login":"Askir","id":10251955,"avatar_url":"https://avatars3.githubusercontent.com/u/10251955?v=4","gravatar_id":"","url":"https://api.github.com/users/Askir","html_url":"https://github.com/Askir","followers_url":"https://api.github.com/users/Askir/followers","following_url":"https://api.github.com/users/Askir/following{/other_user}","gists_url":"https://api.github.com/users/Askir/gists{/gist_id}","starred_url":"https://api.github.com/users/Askir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Askir/subscriptions","organizations_url":"https://api.github.com/users/Askir/orgs","repos_url":"https://api.github.com/users/Askir/repos","events_url":"https://api.github.com/users/Askir/events{/privacy}","received_events_url":"https://api.github.com/users/Askir/received_events","type":"User","site_admin":false},"body":"teams_count is just a default value here. You can override it by setting `teams_count: your number`","created_at":"2017-12-26T22:12:39Z","updated_at":"2017-12-26T22:12:39Z","html_url":"https://github.com/hpi-swt2/sport-portal/pull/276#discussion_r158743729","pull_request_url":"https://api.github.com/repos/hpi-swt2/sport-portal/pulls/276","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hpi-swt2/sport-portal/pulls/comments/158743729"},"html":{"href":"https://github.com/hpi-swt2/sport-portal/pull/276#discussion_r158743729"},"pull_request":{"href":"https://api.github.com/repos/hpi-swt2/sport-portal/pulls/276"}},"in_reply_to_id":158654416},"pull_request":{"url":"https://api.github.com/repos/hpi-swt2/sport-portal/pulls/276","id":159754622,"html_url":"https://github.com/hpi-swt2/sport-portal/pull/276","diff_url":"https://github.com/hpi-swt2/sport-portal/pull/276.diff","patch_url":"https://github.com/hpi-swt2/sport-portal/pull/276.patch","issue_url":"https://api.github.com/repos/hpi-swt2/sport-portal/issues/276","number":276,"state":"open","locked":false,"title":"Bruteforce/145/gamedayduration for leagues","user":{"login":"Askir","id":10251955,"avatar_url":"https://avatars3.githubusercontent.com/u/10251955?v=4","gravatar_id":"","url":"https://api.github.com/users/Askir","html_url":"https://github.com/Askir","followers_url":"https://api.github.com/users/Askir/followers","following_url":"https://api.github.com/users/Askir/following{/other_user}","gists_url":"https://api.github.com/users/Askir/gists{/gist_id}","starred_url":"https://api.github.com/users/Askir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Askir/subscriptions","organizations_url":"https://api.github.com/users/Askir/orgs","repos_url":"https://api.github.com/users/Askir/repos","events_url":"https://api.github.com/users/Askir/events{/privacy}","received_events_url":"https://api.github.com/users/Askir/received_events","type":"User","site_admin":false},"body":"Kinda work in progress right now. I'm not very happy with the view code yet. Still would love some input here :)\r\nThis is how the view looks right now:\r\n\r\n\r\nNot very pretty I know but it probably fullfills the acceptance cirteria :P\r\n","created_at":"2017-12-21T21:33:41Z","updated_at":"2017-12-26T22:12:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab6107397a36c75960e6e1ffb57f0a9e7a820419","assignee":{"login":"Askir","id":10251955,"avatar_url":"https://avatars3.githubusercontent.com/u/10251955?v=4","gravatar_id":"","url":"https://api.github.com/users/Askir","html_url":"https://github.com/Askir","followers_url":"https://api.github.com/users/Askir/followers","following_url":"https://api.github.com/users/Askir/following{/other_user}","gists_url":"https://api.github.com/users/Askir/gists{/gist_id}","starred_url":"https://api.github.com/users/Askir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Askir/subscriptions","organizations_url":"https://api.github.com/users/Askir/orgs","repos_url":"https://api.github.com/users/Askir/repos","events_url":"https://api.github.com/users/Askir/events{/privacy}","received_events_url":"https://api.github.com/users/Askir/received_events","type":"User","site_admin":false},"assignees":[{"login":"Askir","id":10251955,"avatar_url":"https://avatars3.githubusercontent.com/u/10251955?v=4","gravatar_id":"","url":"https://api.github.com/users/Askir","html_url":"https://github.com/Askir","followers_url":"https://api.github.com/users/Askir/followers","following_url":"https://api.github.com/users/Askir/following{/other_user}","gists_url":"https://api.github.com/users/Askir/gists{/gist_id}","starred_url":"https://api.github.com/users/Askir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Askir/subscriptions","organizations_url":"https://api.github.com/users/Askir/orgs","repos_url":"https://api.github.com/users/Askir/repos","events_url":"https://api.github.com/users/Askir/events{/privacy}","received_events_url":"https://api.github.com/users/Askir/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"erksch","id":19290349,"avatar_url":"https://avatars2.githubusercontent.com/u/19290349?v=4","gravatar_id":"","url":"https://api.github.com/users/erksch","html_url":"https://github.com/erksch","followers_url":"https://api.github.com/users/erksch/followers","following_url":"https://api.github.com/users/erksch/following{/other_user}","gists_url":"https://api.github.com/users/erksch/gists{/gist_id}","starred_url":"https://api.github.com/users/erksch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erksch/subscriptions","organizations_url":"https://api.github.com/users/erksch/orgs","repos_url":"https://api.github.com/users/erksch/repos","events_url":"https://api.github.com/users/erksch/events{/privacy}","received_events_url":"https://api.github.com/users/erksch/received_events","type":"User","site_admin":false},{"login":"CoderWombat","id":27901680,"avatar_url":"https://avatars3.githubusercontent.com/u/27901680?v=4","gravatar_id":"","url":"https://api.github.com/users/CoderWombat","html_url":"https://github.com/CoderWombat","followers_url":"https://api.github.com/users/CoderWombat/followers","following_url":"https://api.github.com/users/CoderWombat/following{/other_user}","gists_url":"https://api.github.com/users/CoderWombat/gists{/gist_id}","starred_url":"https://api.github.com/users/CoderWombat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoderWombat/subscriptions","organizations_url":"https://api.github.com/users/CoderWombat/orgs","repos_url":"https://api.github.com/users/CoderWombat/repos","events_url":"https://api.github.com/users/CoderWombat/events{/privacy}","received_events_url":"https://api.github.com/users/CoderWombat/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hpi-swt2/sport-portal/pulls/276/commits","review_comments_url":"https://api.github.com/repos/hpi-swt2/sport-portal/pulls/276/comments","review_comment_url":"https://api.github.com/repos/hpi-swt2/sport-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpi-swt2/sport-portal/issues/276/comments","statuses_url":"https://api.github.com/repos/hpi-swt2/sport-portal/statuses/149ad64eaf2a9439fe5beec9f5a91e033ca9dfe0","head":{"label":"hpi-swt2:bruteforce/145/gamedayduration-for-leagues","ref":"bruteforce/145/gamedayduration-for-leagues","sha":"149ad64eaf2a9439fe5beec9f5a91e033ca9dfe0","user":{"login":"hpi-swt2","id":6618414,"avatar_url":"https://avatars3.githubusercontent.com/u/6618414?v=4","gravatar_id":"","url":"https://api.github.com/users/hpi-swt2","html_url":"https://github.com/hpi-swt2","followers_url":"https://api.github.com/users/hpi-swt2/followers","following_url":"https://api.github.com/users/hpi-swt2/following{/other_user}","gists_url":"https://api.github.com/users/hpi-swt2/gists{/gist_id}","starred_url":"https://api.github.com/users/hpi-swt2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpi-swt2/subscriptions","organizations_url":"https://api.github.com/users/hpi-swt2/orgs","repos_url":"https://api.github.com/users/hpi-swt2/repos","events_url":"https://api.github.com/users/hpi-swt2/events{/privacy}","received_events_url":"https://api.github.com/users/hpi-swt2/received_events","type":"Organization","site_admin":false},"repo":{"id":104343602,"name":"sport-portal","full_name":"hpi-swt2/sport-portal","owner":{"login":"hpi-swt2","id":6618414,"avatar_url":"https://avatars3.githubusercontent.com/u/6618414?v=4","gravatar_id":"","url":"https://api.github.com/users/hpi-swt2","html_url":"https://github.com/hpi-swt2","followers_url":"https://api.github.com/users/hpi-swt2/followers","following_url":"https://api.github.com/users/hpi-swt2/following{/other_user}","gists_url":"https://api.github.com/users/hpi-swt2/gists{/gist_id}","starred_url":"https://api.github.com/users/hpi-swt2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpi-swt2/subscriptions","organizations_url":"https://api.github.com/users/hpi-swt2/orgs","repos_url":"https://api.github.com/users/hpi-swt2/repos","events_url":"https://api.github.com/users/hpi-swt2/events{/privacy}","received_events_url":"https://api.github.com/users/hpi-swt2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpi-swt2/sport-portal","description":"Manage and organize sport events and sports leagues","fork":false,"url":"https://api.github.com/repos/hpi-swt2/sport-portal","forks_url":"https://api.github.com/repos/hpi-swt2/sport-portal/forks","keys_url":"https://api.github.com/repos/hpi-swt2/sport-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpi-swt2/sport-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpi-swt2/sport-portal/teams","hooks_url":"https://api.github.com/repos/hpi-swt2/sport-portal/hooks","issue_events_url":"https://api.github.com/repos/hpi-swt2/sport-portal/issues/events{/number}","events_url":"https://api.github.com/repos/hpi-swt2/sport-portal/events","assignees_url":"https://api.github.com/repos/hpi-swt2/sport-portal/assignees{/user}","branches_url":"https://api.github.com/repos/hpi-swt2/sport-portal/branches{/branch}","tags_url":"https://api.github.com/repos/hpi-swt2/sport-portal/tags","blobs_url":"https://api.github.com/repos/hpi-swt2/sport-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpi-swt2/sport-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpi-swt2/sport-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpi-swt2/sport-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpi-swt2/sport-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/hpi-swt2/sport-portal/languages","stargazers_url":"https://api.github.com/repos/hpi-swt2/sport-portal/stargazers","contributors_url":"https://api.github.com/repos/hpi-swt2/sport-portal/contributors","subscribers_url":"https://api.github.com/repos/hpi-swt2/sport-portal/subscribers","subscription_url":"https://api.github.com/repos/hpi-swt2/sport-portal/subscription","commits_url":"https://api.github.com/repos/hpi-swt2/sport-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpi-swt2/sport-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpi-swt2/sport-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpi-swt2/sport-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpi-swt2/sport-portal/contents/{+path}","compare_url":"https://api.github.com/repos/hpi-swt2/sport-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpi-swt2/sport-portal/merges","archive_url":"https://api.github.com/repos/hpi-swt2/sport-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpi-swt2/sport-portal/downloads","issues_url":"https://api.github.com/repos/hpi-swt2/sport-portal/issues{/number}","pulls_url":"https://api.github.com/repos/hpi-swt2/sport-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/hpi-swt2/sport-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/hpi-swt2/sport-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpi-swt2/sport-portal/labels{/name}","releases_url":"https://api.github.com/repos/hpi-swt2/sport-portal/releases{/id}","deployments_url":"https://api.github.com/repos/hpi-swt2/sport-portal/deployments","created_at":"2017-09-21T12:10:32Z","updated_at":"2017-12-14T11:27:08Z","pushed_at":"2017-12-26T22:11:19Z","git_url":"git://github.com/hpi-swt2/sport-portal.git","ssh_url":"[email protected]:hpi-swt2/sport-portal.git","clone_url":"https://github.com/hpi-swt2/sport-portal.git","svn_url":"https://github.com/hpi-swt2/sport-portal","homepage":null,"size":4201,"stargazers_count":15,"watchers_count":15,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1,"open_issues":98,"watchers":15,"default_branch":"dev"}},"base":{"label":"hpi-swt2:dev","ref":"dev","sha":"32d57bd226ded4b5bc39d9bcbde2febe369963f9","user":{"login":"hpi-swt2","id":6618414,"avatar_url":"https://avatars3.githubusercontent.com/u/6618414?v=4","gravatar_id":"","url":"https://api.github.com/users/hpi-swt2","html_url":"https://github.com/hpi-swt2","followers_url":"https://api.github.com/users/hpi-swt2/followers","following_url":"https://api.github.com/users/hpi-swt2/following{/other_user}","gists_url":"https://api.github.com/users/hpi-swt2/gists{/gist_id}","starred_url":"https://api.github.com/users/hpi-swt2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpi-swt2/subscriptions","organizations_url":"https://api.github.com/users/hpi-swt2/orgs","repos_url":"https://api.github.com/users/hpi-swt2/repos","events_url":"https://api.github.com/users/hpi-swt2/events{/privacy}","received_events_url":"https://api.github.com/users/hpi-swt2/received_events","type":"Organization","site_admin":false},"repo":{"id":104343602,"name":"sport-portal","full_name":"hpi-swt2/sport-portal","owner":{"login":"hpi-swt2","id":6618414,"avatar_url":"https://avatars3.githubusercontent.com/u/6618414?v=4","gravatar_id":"","url":"https://api.github.com/users/hpi-swt2","html_url":"https://github.com/hpi-swt2","followers_url":"https://api.github.com/users/hpi-swt2/followers","following_url":"https://api.github.com/users/hpi-swt2/following{/other_user}","gists_url":"https://api.github.com/users/hpi-swt2/gists{/gist_id}","starred_url":"https://api.github.com/users/hpi-swt2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpi-swt2/subscriptions","organizations_url":"https://api.github.com/users/hpi-swt2/orgs","repos_url":"https://api.github.com/users/hpi-swt2/repos","events_url":"https://api.github.com/users/hpi-swt2/events{/privacy}","received_events_url":"https://api.github.com/users/hpi-swt2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpi-swt2/sport-portal","description":"Manage and organize sport events and sports leagues","fork":false,"url":"https://api.github.com/repos/hpi-swt2/sport-portal","forks_url":"https://api.github.com/repos/hpi-swt2/sport-portal/forks","keys_url":"https://api.github.com/repos/hpi-swt2/sport-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpi-swt2/sport-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpi-swt2/sport-portal/teams","hooks_url":"https://api.github.com/repos/hpi-swt2/sport-portal/hooks","issue_events_url":"https://api.github.com/repos/hpi-swt2/sport-portal/issues/events{/number}","events_url":"https://api.github.com/repos/hpi-swt2/sport-portal/events","assignees_url":"https://api.github.com/repos/hpi-swt2/sport-portal/assignees{/user}","branches_url":"https://api.github.com/repos/hpi-swt2/sport-portal/branches{/branch}","tags_url":"https://api.github.com/repos/hpi-swt2/sport-portal/tags","blobs_url":"https://api.github.com/repos/hpi-swt2/sport-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpi-swt2/sport-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpi-swt2/sport-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpi-swt2/sport-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpi-swt2/sport-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/hpi-swt2/sport-portal/languages","stargazers_url":"https://api.github.com/repos/hpi-swt2/sport-portal/stargazers","contributors_url":"https://api.github.com/repos/hpi-swt2/sport-portal/contributors","subscribers_url":"https://api.github.com/repos/hpi-swt2/sport-portal/subscribers","subscription_url":"https://api.github.com/repos/hpi-swt2/sport-portal/subscription","commits_url":"https://api.github.com/repos/hpi-swt2/sport-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpi-swt2/sport-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpi-swt2/sport-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpi-swt2/sport-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpi-swt2/sport-portal/contents/{+path}","compare_url":"https://api.github.com/repos/hpi-swt2/sport-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpi-swt2/sport-portal/merges","archive_url":"https://api.github.com/repos/hpi-swt2/sport-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpi-swt2/sport-portal/downloads","issues_url":"https://api.github.com/repos/hpi-swt2/sport-portal/issues{/number}","pulls_url":"https://api.github.com/repos/hpi-swt2/sport-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/hpi-swt2/sport-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/hpi-swt2/sport-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpi-swt2/sport-portal/labels{/name}","releases_url":"https://api.github.com/repos/hpi-swt2/sport-portal/releases{/id}","deployments_url":"https://api.github.com/repos/hpi-swt2/sport-portal/deployments","created_at":"2017-09-21T12:10:32Z","updated_at":"2017-12-14T11:27:08Z","pushed_at":"2017-12-26T22:11:19Z","git_url":"git://github.com/hpi-swt2/sport-portal.git","ssh_url":"[email protected]:hpi-swt2/sport-portal.git","clone_url":"https://github.com/hpi-swt2/sport-portal.git","svn_url":"https://github.com/hpi-swt2/sport-portal","homepage":null,"size":4201,"stargazers_count":15,"watchers_count":15,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1,"open_issues":98,"watchers":15,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/hpi-swt2/sport-portal/pulls/276"},"html":{"href":"https://github.com/hpi-swt2/sport-portal/pull/276"},"issue":{"href":"https://api.github.com/repos/hpi-swt2/sport-portal/issues/276"},"comments":{"href":"https://api.github.com/repos/hpi-swt2/sport-portal/issues/276/comments"},"review_comments":{"href":"https://api.github.com/repos/hpi-swt2/sport-portal/pulls/276/comments"},"review_comment":{"href":"https://api.github.com/repos/hpi-swt2/sport-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpi-swt2/sport-portal/pulls/276/commits"},"statuses":{"href":"https://api.github.com/repos/hpi-swt2/sport-portal/statuses/149ad64eaf2a9439fe5beec9f5a91e033ca9dfe0"}},"author_association":"CONTRIBUTOR"}} | {
"id": 104343602,
"name": "hpi-swt2/sport-portal",
"url": "https://api.github.com/repos/hpi-swt2/sport-portal"
} | {
"id": 10251955,
"login": "Askir",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10251955?",
"url": "https://api.github.com/users/Askir"
} | {
"id": 6618414,
"login": "hpi-swt2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6618414?",
"url": "https://api.github.com/orgs/hpi-swt2"
} | 2017-12-26T22:12:39 | 7031943378 | {"actor":{"display_login":"Askir"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/idaholab/moose/pulls/comments/101325874","pull_request_review_id":22050783,"id":101325874,"diff_hunk":"@@ -52,17 +52,6 @@ DOFMapOutput::DOFMapOutput(const InputParameters & parameters) :\n _system_name(getParam<std::string>(\"system_name\")),\n _mesh(_problem_ptr->mesh())\n {\n- // Set output coloring\n- if (Moose::_color_console)\n- {\n- char * term_env = getenv(\"TERM\");\n- if (term_env)\n- {\n- std::string term(term_env);\n- if (term != \"xterm-256color\" && term != \"xterm\")","path":"framework/src/outputs/DOFMapOutput.C","position":11,"original_position":11,"commit_id":"3a8c383759683994ddb71cfa1601787b266d9264","original_commit_id":"3a8c383759683994ddb71cfa1601787b266d9264","user":{"login":"permcody","id":3036960,"avatar_url":"https://avatars.githubusercontent.com/u/3036960?v=3","gravatar_id":"","url":"https://api.github.com/users/permcody","html_url":"https://github.com/permcody","followers_url":"https://api.github.com/users/permcody/followers","following_url":"https://api.github.com/users/permcody/following{/other_user}","gists_url":"https://api.github.com/users/permcody/gists{/gist_id}","starred_url":"https://api.github.com/users/permcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/permcody/subscriptions","organizations_url":"https://api.github.com/users/permcody/orgs","repos_url":"https://api.github.com/users/permcody/repos","events_url":"https://api.github.com/users/permcody/events{/privacy}","received_events_url":"https://api.github.com/users/permcody/received_events","type":"User","site_admin":false},"body":"Let's not drop this logic. It's been awhile since I've been on a dumb terminal but we really don't want colors on in that case. It'll hose you big time. ","created_at":"2017-02-15T16:54:34Z","updated_at":"2017-02-15T16:54:52Z","html_url":"https://github.com/idaholab/moose/pull/8476#discussion_r101325874","pull_request_url":"https://api.github.com/repos/idaholab/moose/pulls/8476","_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments/101325874"},"html":{"href":"https://github.com/idaholab/moose/pull/8476#discussion_r101325874"},"pull_request":{"href":"https://api.github.com/repos/idaholab/moose/pulls/8476"}}},"pull_request":{"url":"https://api.github.com/repos/idaholab/moose/pulls/8476","id":104832045,"html_url":"https://github.com/idaholab/moose/pull/8476","diff_url":"https://github.com/idaholab/moose/pull/8476.diff","patch_url":"https://github.com/idaholab/moose/pull/8476.patch","issue_url":"https://api.github.com/repos/idaholab/moose/issues/8476","number":8476,"state":"open","locked":false,"title":"retry auto-detect environment for (not) using color output","user":{"login":"rwcarlsen","id":1351242,"avatar_url":"https://avatars.githubusercontent.com/u/1351242?v=3","gravatar_id":"","url":"https://api.github.com/users/rwcarlsen","html_url":"https://github.com/rwcarlsen","followers_url":"https://api.github.com/users/rwcarlsen/followers","following_url":"https://api.github.com/users/rwcarlsen/following{/other_user}","gists_url":"https://api.github.com/users/rwcarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/rwcarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwcarlsen/subscriptions","organizations_url":"https://api.github.com/users/rwcarlsen/orgs","repos_url":"https://api.github.com/users/rwcarlsen/repos","events_url":"https://api.github.com/users/rwcarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/rwcarlsen/received_events","type":"User","site_admin":false},"body":"Small tweaks to #7825. The objection/problem with the previous PR was no color was output in MPI runs. This (mostly) fixes that. The only case where you still wouldn't get color in MPI is if the number of processors is equal to one. Feel free to merge or close as desired.","created_at":"2017-02-06T16:29:11Z","updated_at":"2017-02-15T16:54:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bce7b9f47245c582556a0971e1b13b83ca40671","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/idaholab/moose/pulls/8476/commits","review_comments_url":"https://api.github.com/repos/idaholab/moose/pulls/8476/comments","review_comment_url":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/8476/comments","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/3a8c383759683994ddb71cfa1601787b266d9264","head":{"label":"rwcarlsen:fix-color","ref":"fix-color","sha":"3a8c383759683994ddb71cfa1601787b266d9264","user":{"login":"rwcarlsen","id":1351242,"avatar_url":"https://avatars.githubusercontent.com/u/1351242?v=3","gravatar_id":"","url":"https://api.github.com/users/rwcarlsen","html_url":"https://github.com/rwcarlsen","followers_url":"https://api.github.com/users/rwcarlsen/followers","following_url":"https://api.github.com/users/rwcarlsen/following{/other_user}","gists_url":"https://api.github.com/users/rwcarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/rwcarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwcarlsen/subscriptions","organizations_url":"https://api.github.com/users/rwcarlsen/orgs","repos_url":"https://api.github.com/users/rwcarlsen/repos","events_url":"https://api.github.com/users/rwcarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/rwcarlsen/received_events","type":"User","site_admin":false},"repo":{"id":68224891,"name":"moose","full_name":"rwcarlsen/moose","owner":{"login":"rwcarlsen","id":1351242,"avatar_url":"https://avatars.githubusercontent.com/u/1351242?v=3","gravatar_id":"","url":"https://api.github.com/users/rwcarlsen","html_url":"https://github.com/rwcarlsen","followers_url":"https://api.github.com/users/rwcarlsen/followers","following_url":"https://api.github.com/users/rwcarlsen/following{/other_user}","gists_url":"https://api.github.com/users/rwcarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/rwcarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwcarlsen/subscriptions","organizations_url":"https://api.github.com/users/rwcarlsen/orgs","repos_url":"https://api.github.com/users/rwcarlsen/repos","events_url":"https://api.github.com/users/rwcarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/rwcarlsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwcarlsen/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":true,"url":"https://api.github.com/repos/rwcarlsen/moose","forks_url":"https://api.github.com/repos/rwcarlsen/moose/forks","keys_url":"https://api.github.com/repos/rwcarlsen/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwcarlsen/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwcarlsen/moose/teams","hooks_url":"https://api.github.com/repos/rwcarlsen/moose/hooks","issue_events_url":"https://api.github.com/repos/rwcarlsen/moose/issues/events{/number}","events_url":"https://api.github.com/repos/rwcarlsen/moose/events","assignees_url":"https://api.github.com/repos/rwcarlsen/moose/assignees{/user}","branches_url":"https://api.github.com/repos/rwcarlsen/moose/branches{/branch}","tags_url":"https://api.github.com/repos/rwcarlsen/moose/tags","blobs_url":"https://api.github.com/repos/rwcarlsen/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwcarlsen/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwcarlsen/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwcarlsen/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwcarlsen/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/rwcarlsen/moose/languages","stargazers_url":"https://api.github.com/repos/rwcarlsen/moose/stargazers","contributors_url":"https://api.github.com/repos/rwcarlsen/moose/contributors","subscribers_url":"https://api.github.com/repos/rwcarlsen/moose/subscribers","subscription_url":"https://api.github.com/repos/rwcarlsen/moose/subscription","commits_url":"https://api.github.com/repos/rwcarlsen/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwcarlsen/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwcarlsen/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwcarlsen/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwcarlsen/moose/contents/{+path}","compare_url":"https://api.github.com/repos/rwcarlsen/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwcarlsen/moose/merges","archive_url":"https://api.github.com/repos/rwcarlsen/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwcarlsen/moose/downloads","issues_url":"https://api.github.com/repos/rwcarlsen/moose/issues{/number}","pulls_url":"https://api.github.com/repos/rwcarlsen/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/rwcarlsen/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/rwcarlsen/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwcarlsen/moose/labels{/name}","releases_url":"https://api.github.com/repos/rwcarlsen/moose/releases{/id}","deployments_url":"https://api.github.com/repos/rwcarlsen/moose/deployments","created_at":"2016-09-14T16:48:53Z","updated_at":"2016-09-14T16:49:08Z","pushed_at":"2017-02-15T16:45:34Z","git_url":"git://github.com/rwcarlsen/moose.git","ssh_url":"[email protected]:rwcarlsen/moose.git","clone_url":"https://github.com/rwcarlsen/moose.git","svn_url":"https://github.com/rwcarlsen/moose","homepage":"http://www.mooseframework.org","size":161925,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"idaholab:devel","ref":"devel","sha":"9275d99568ce6fb7ddf8213a64a18f69315c6438","user":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"repo":{"id":16851223,"name":"moose","full_name":"idaholab/moose","owner":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idaholab/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":false,"url":"https://api.github.com/repos/idaholab/moose","forks_url":"https://api.github.com/repos/idaholab/moose/forks","keys_url":"https://api.github.com/repos/idaholab/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idaholab/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idaholab/moose/teams","hooks_url":"https://api.github.com/repos/idaholab/moose/hooks","issue_events_url":"https://api.github.com/repos/idaholab/moose/issues/events{/number}","events_url":"https://api.github.com/repos/idaholab/moose/events","assignees_url":"https://api.github.com/repos/idaholab/moose/assignees{/user}","branches_url":"https://api.github.com/repos/idaholab/moose/branches{/branch}","tags_url":"https://api.github.com/repos/idaholab/moose/tags","blobs_url":"https://api.github.com/repos/idaholab/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idaholab/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idaholab/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/idaholab/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/idaholab/moose/languages","stargazers_url":"https://api.github.com/repos/idaholab/moose/stargazers","contributors_url":"https://api.github.com/repos/idaholab/moose/contributors","subscribers_url":"https://api.github.com/repos/idaholab/moose/subscribers","subscription_url":"https://api.github.com/repos/idaholab/moose/subscription","commits_url":"https://api.github.com/repos/idaholab/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/idaholab/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/idaholab/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/idaholab/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/idaholab/moose/contents/{+path}","compare_url":"https://api.github.com/repos/idaholab/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idaholab/moose/merges","archive_url":"https://api.github.com/repos/idaholab/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idaholab/moose/downloads","issues_url":"https://api.github.com/repos/idaholab/moose/issues{/number}","pulls_url":"https://api.github.com/repos/idaholab/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/idaholab/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/idaholab/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idaholab/moose/labels{/name}","releases_url":"https://api.github.com/repos/idaholab/moose/releases{/id}","deployments_url":"https://api.github.com/repos/idaholab/moose/deployments","created_at":"2014-02-14T22:26:15Z","updated_at":"2017-02-13T03:45:41Z","pushed_at":"2017-02-15T16:49:47Z","git_url":"git://github.com/idaholab/moose.git","ssh_url":"[email protected]:idaholab/moose.git","clone_url":"https://github.com/idaholab/moose.git","svn_url":"https://github.com/idaholab/moose","homepage":"http://www.mooseframework.org","size":171700,"stargazers_count":188,"watchers_count":188,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":321,"mirror_url":null,"open_issues_count":646,"forks":321,"open_issues":646,"watchers":188,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/8476"},"html":{"href":"https://github.com/idaholab/moose/pull/8476"},"issue":{"href":"https://api.github.com/repos/idaholab/moose/issues/8476"},"comments":{"href":"https://api.github.com/repos/idaholab/moose/issues/8476/comments"},"review_comments":{"href":"https://api.github.com/repos/idaholab/moose/pulls/8476/comments"},"review_comment":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/idaholab/moose/pulls/8476/commits"},"statuses":{"href":"https://api.github.com/repos/idaholab/moose/statuses/3a8c383759683994ddb71cfa1601787b266d9264"}}}} | {
"id": 16851223,
"name": "idaholab/moose",
"url": "https://api.github.com/repos/idaholab/moose"
} | {
"id": 3036960,
"login": "permcody",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3036960?",
"url": "https://api.github.com/users/permcody"
} | {
"id": 3855370,
"login": "idaholab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3855370?",
"url": "https://api.github.com/orgs/idaholab"
} | 2017-02-15T16:54:34 | 5330373291 | {"actor":{"display_login":"permcody"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments/101627135","pull_request_review_id":22362774,"id":101627135,"diff_hunk":"@@ -123,7 +123,7 @@\n \"e2e\": \"protractor <%= TEST_SRC_DIR %>protractor.conf.js\",\n \"postinstall\": \"webdriver-manager update && <%= clientPackageManager %> run webpack:build\"\n <%_ } else { _%>\n- \"postinstall\": \"<%= clientPackageManager %> run webpack:build\"\n+ \"postinstall\": \"node node_modules/pngquant-bin/lib/install.js && node node_modules/phantomjs-prebuilt/install.js && <%= clientPackageManager %> run webpack:build\"","path":"generators/client/templates/angular/_package.json","position":5,"original_position":5,"commit_id":"da24c3a7a89064a6f2e99a8bda3b1aee859303bf","original_commit_id":"da24c3a7a89064a6f2e99a8bda3b1aee859303bf","user":{"login":"pascalgrimaud","id":9156882,"avatar_url":"https://avatars.githubusercontent.com/u/9156882?v=3","gravatar_id":"","url":"https://api.github.com/users/pascalgrimaud","html_url":"https://github.com/pascalgrimaud","followers_url":"https://api.github.com/users/pascalgrimaud/followers","following_url":"https://api.github.com/users/pascalgrimaud/following{/other_user}","gists_url":"https://api.github.com/users/pascalgrimaud/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalgrimaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalgrimaud/subscriptions","organizations_url":"https://api.github.com/users/pascalgrimaud/orgs","repos_url":"https://api.github.com/users/pascalgrimaud/repos","events_url":"https://api.github.com/users/pascalgrimaud/events{/privacy}","received_events_url":"https://api.github.com/users/pascalgrimaud/received_events","type":"User","site_admin":false},"body":"@ruddell : should we add this `node node_modules/pngquant-bin/lib/install.js && node node_modules/phantomjs-prebuilt/install.js` to postInstall for protractor too ?","created_at":"2017-02-16T21:10:28Z","updated_at":"2017-02-16T21:10:28Z","html_url":"https://github.com/jhipster/generator-jhipster/pull/5230#discussion_r101627135","pull_request_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/5230","_links":{"self":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments/101627135"},"html":{"href":"https://github.com/jhipster/generator-jhipster/pull/5230#discussion_r101627135"},"pull_request":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/5230"}}},"pull_request":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/5230","id":106476891,"html_url":"https://github.com/jhipster/generator-jhipster/pull/5230","diff_url":"https://github.com/jhipster/generator-jhipster/pull/5230.diff","patch_url":"https://github.com/jhipster/generator-jhipster/pull/5230.patch","issue_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/5230","number":5230,"state":"closed","locked":false,"title":"add pngquant and phantomjs rebuild to postinstall","user":{"login":"ruddell","id":4294623,"avatar_url":"https://avatars.githubusercontent.com/u/4294623?v=3","gravatar_id":"","url":"https://api.github.com/users/ruddell","html_url":"https://github.com/ruddell","followers_url":"https://api.github.com/users/ruddell/followers","following_url":"https://api.github.com/users/ruddell/following{/other_user}","gists_url":"https://api.github.com/users/ruddell/gists{/gist_id}","starred_url":"https://api.github.com/users/ruddell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruddell/subscriptions","organizations_url":"https://api.github.com/users/ruddell/orgs","repos_url":"https://api.github.com/users/ruddell/repos","events_url":"https://api.github.com/users/ruddell/events{/privacy}","received_events_url":"https://api.github.com/users/ruddell/received_events","type":"User","site_admin":false},"body":"Related to #5225 https://github.com/jhipster/generator-jhipster/issues/5188#issuecomment-280256476\r\n\r\n```\r\nERROR in ./src/main/webapp/content/images/hipster.png\r\nModule build failed: Error: spawn /home/vagrant/projects/jhipster-gradle/node_modules/pngquant-bin/vendor/pngquant ENOENT\r\n at exports._errnoException (util.js:1022:11)\r\n at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)\r\n at onErrorNT (internal/child_process.js:359:16)\r\n at _combinedTickCallback (internal/process/next_tick.js:74:11)\r\n at process._tickCallback (internal/process/next_tick.js:98:9)\r\n @ ./~/css-loader!./src/main/webapp/app/home/home.css 6:307-350\r\n @ ./src/main/webapp/app/home/home.css\r\n @ ./src/main/webapp/app/home/home.component.ts\r\n @ ./src/main/webapp/app/home/index.ts\r\n @ ./src/main/webapp/app/app.module.ts\r\n @ ./src/main/webapp/app/app.main.ts\r\n```","created_at":"2017-02-16T08:35:29Z","updated_at":"2017-02-16T21:10:28Z","closed_at":"2017-02-16T18:01:36Z","merged_at":"2017-02-16T18:01:36Z","merge_commit_sha":"057001e4e08b7f67d72237c57d809067c6d6253f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/5230/commits","review_comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/5230/comments","review_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/5230/comments","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/da24c3a7a89064a6f2e99a8bda3b1aee859303bf","head":{"label":"ruddell:rebuild-pngquant-and-phatomjs","ref":"rebuild-pngquant-and-phatomjs","sha":"da24c3a7a89064a6f2e99a8bda3b1aee859303bf","user":{"login":"ruddell","id":4294623,"avatar_url":"https://avatars.githubusercontent.com/u/4294623?v=3","gravatar_id":"","url":"https://api.github.com/users/ruddell","html_url":"https://github.com/ruddell","followers_url":"https://api.github.com/users/ruddell/followers","following_url":"https://api.github.com/users/ruddell/following{/other_user}","gists_url":"https://api.github.com/users/ruddell/gists{/gist_id}","starred_url":"https://api.github.com/users/ruddell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruddell/subscriptions","organizations_url":"https://api.github.com/users/ruddell/orgs","repos_url":"https://api.github.com/users/ruddell/repos","events_url":"https://api.github.com/users/ruddell/events{/privacy}","received_events_url":"https://api.github.com/users/ruddell/received_events","type":"User","site_admin":false},"repo":{"id":49409828,"name":"generator-jhipster","full_name":"ruddell/generator-jhipster","owner":{"login":"ruddell","id":4294623,"avatar_url":"https://avatars.githubusercontent.com/u/4294623?v=3","gravatar_id":"","url":"https://api.github.com/users/ruddell","html_url":"https://github.com/ruddell","followers_url":"https://api.github.com/users/ruddell/followers","following_url":"https://api.github.com/users/ruddell/following{/other_user}","gists_url":"https://api.github.com/users/ruddell/gists{/gist_id}","starred_url":"https://api.github.com/users/ruddell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruddell/subscriptions","organizations_url":"https://api.github.com/users/ruddell/orgs","repos_url":"https://api.github.com/users/ruddell/repos","events_url":"https://api.github.com/users/ruddell/events{/privacy}","received_events_url":"https://api.github.com/users/ruddell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ruddell/generator-jhipster","description":"Hipster stack for Java developers. Yeoman + Maven + Spring + AngularJS in one handy generator.","fork":true,"url":"https://api.github.com/repos/ruddell/generator-jhipster","forks_url":"https://api.github.com/repos/ruddell/generator-jhipster/forks","keys_url":"https://api.github.com/repos/ruddell/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruddell/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruddell/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/ruddell/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/ruddell/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/ruddell/generator-jhipster/events","assignees_url":"https://api.github.com/repos/ruddell/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/ruddell/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/ruddell/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/ruddell/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruddell/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruddell/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruddell/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruddell/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/ruddell/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/ruddell/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/ruddell/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/ruddell/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/ruddell/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/ruddell/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruddell/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruddell/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruddell/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruddell/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/ruddell/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruddell/generator-jhipster/merges","archive_url":"https://api.github.com/repos/ruddell/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruddell/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/ruddell/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/ruddell/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/ruddell/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/ruddell/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruddell/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/ruddell/generator-jhipster/releases{/id}","deployments_url":"https://api.github.com/repos/ruddell/generator-jhipster/deployments","created_at":"2016-01-11T07:35:45Z","updated_at":"2016-01-11T07:35:47Z","pushed_at":"2017-02-16T18:57:17Z","git_url":"git://github.com/ruddell/generator-jhipster.git","ssh_url":"[email protected]:ruddell/generator-jhipster.git","clone_url":"https://github.com/ruddell/generator-jhipster.git","svn_url":"https://github.com/ruddell/generator-jhipster","homepage":"http://jhipster.github.io","size":17735,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jhipster:master","ref":"master","sha":"b1a2375a3dc418efca9cfc199e284d526203a58d","user":{"login":"jhipster","id":6059488,"avatar_url":"https://avatars.githubusercontent.com/u/6059488?v=3","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"repo":{"id":13753636,"name":"generator-jhipster","full_name":"jhipster/generator-jhipster","owner":{"login":"jhipster","id":6059488,"avatar_url":"https://avatars.githubusercontent.com/u/6059488?v=3","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jhipster/generator-jhipster","description":"Open Source application generator for creating Spring Boot + Angular projects in seconds!","fork":false,"url":"https://api.github.com/repos/jhipster/generator-jhipster","forks_url":"https://api.github.com/repos/jhipster/generator-jhipster/forks","keys_url":"https://api.github.com/repos/jhipster/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhipster/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhipster/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/jhipster/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/jhipster/generator-jhipster/events","assignees_url":"https://api.github.com/repos/jhipster/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/jhipster/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/jhipster/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/jhipster/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/jhipster/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhipster/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/jhipster/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhipster/generator-jhipster/merges","archive_url":"https://api.github.com/repos/jhipster/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhipster/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/jhipster/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/jhipster/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhipster/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/jhipster/generator-jhipster/releases{/id}","deployments_url":"https://api.github.com/repos/jhipster/generator-jhipster/deployments","created_at":"2013-10-21T20:07:22Z","updated_at":"2017-02-16T21:07:13Z","pushed_at":"2017-02-16T18:01:37Z","git_url":"git://github.com/jhipster/generator-jhipster.git","ssh_url":"[email protected]:jhipster/generator-jhipster.git","clone_url":"https://github.com/jhipster/generator-jhipster.git","svn_url":"https://github.com/jhipster/generator-jhipster","homepage":"http://jhipster.github.io","size":17738,"stargazers_count":6153,"watchers_count":6153,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1406,"mirror_url":null,"open_issues_count":41,"forks":1406,"open_issues":41,"watchers":6153,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/5230"},"html":{"href":"https://github.com/jhipster/generator-jhipster/pull/5230"},"issue":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/5230"},"comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/5230/comments"},"review_comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/5230/comments"},"review_comment":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/5230/commits"},"statuses":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/da24c3a7a89064a6f2e99a8bda3b1aee859303bf"}}}} | {
"id": 13753636,
"name": "jhipster/generator-jhipster",
"url": "https://api.github.com/repos/jhipster/generator-jhipster"
} | {
"id": 9156882,
"login": "pascalgrimaud",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9156882?",
"url": "https://api.github.com/users/pascalgrimaud"
} | {
"id": 6059488,
"login": "jhipster",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6059488?",
"url": "https://api.github.com/orgs/jhipster"
} | 2017-02-16T21:10:28 | 5339744768 | {"actor":{"display_login":"pascalgrimaud"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/kubeless/kubeless/pulls/comments/146449126","pull_request_review_id":71360385,"id":146449126,"diff_hunk":"@@ -100,14 +119,246 @@ func parseMemory(mem string) (resource.Quantity, error) {\n \treturn quantity, nil\n }\n \n-func getFunctionDescription(funcName, ns, handler, funcContent, deps, runtime, topic, schedule, runtimeImage, mem string, triggerHTTP bool, envs, labels []string, defaultFunction spec.Function) (f *spec.Function, err error) {\n+func getFileSha256(file string) (sha256Sum [32]byte, checksum string, err error) {\n+\tcontent, err := ioutil.ReadFile(file)\n+\tif err != nil {\n+\t\treturn\n+\t}\n+\th := sha256.New()\n+\tff, err := os.Open(file)\n+\tif err != nil {\n+\t\treturn\n+\t}\n+\tdefer ff.Close()\n+\t_, err = io.Copy(h, ff)\n+\tif err != nil {\n+\t\treturn\n+\t}\n+\tsha256Sum = sha256.Sum256(content)\n+\tchecksum = hex.EncodeToString(h.Sum(nil))\n+\treturn\n+}\n+\n+type defaultPortForwarder struct {\n+\tcmdOut, cmdErr io.Writer\n+}\n+\n+func (f *defaultPortForwarder) ForwardPorts(method string, url *url.URL, opts k8scmd.PortForwardOptions) error {\n+\tdialer, err := remotecommand.NewExecutor(opts.Config, method, url)\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\tfw, err := portforward.New(dialer, opts.Ports, opts.StopChannel, opts.ReadyChannel, f.cmdOut, f.cmdErr)\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\treturn fw.ForwardPorts()\n+}\n+\n+func getLocalPort() (string, error) {\n+\tfor i := 30000; i < 65535; i++ {\n+\t\tconn, err := net.Dial(\"tcp\", \"127.0.0.1:\"+strconv.Itoa(i))\n+\t\tif err != nil {\n+\t\t\treturn strconv.Itoa(i), nil\n+\t\t}\n+\t\tconn.Close()\n+\t}\n+\treturn \"\", errors.New(\"Can not find an unassigned port\")\n+}\n+\n+const (\n+\tmaxRetries = 5\n+\tdefaultTimeSleep = 1\n+)\n+\n+func waitForHTTPServer(host, port string) error {\n+\t// Build the request\n+\treq, err := http.NewRequest(\n+\t\t\"GET\",\n+\t\t\"http://\"+host+\":\"+port,\n+\t\tnil,\n+\t)\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\n+\t// Execute the request\n+\tresp, err := http.DefaultClient.Do(req)\n+\tretries := 0\n+\tfor err != nil && retries < maxRetries {\n+\t\tretries++\n+\t\ttime.Sleep(time.Duration(time.Second))\n+\t\tresp, err = http.DefaultClient.Do(req)\n+\t}\n+\tresp.Body.Close()\n+\treturn err\n+}\n+\n+func runPortForward(f cmdutil.Factory, k8sClient *rest.RESTClient, podName, port string) (err error) {\n+\tclientset, err := f.ClientSet()\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\tk8sClientConfig, err := f.ClientConfig()\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\n+\tportSlice := []string{port + \":9000\"}\n+\tgo func() {\n+\t\tdevNull, err := os.Open(os.DevNull)\n+\t\tif err != nil {\n+\t\t\tlogrus.Fatal(err)\n+\t\t}\n+\t\tpfo := k8scmd.PortForwardOptions{\n+\t\t\tRESTClient: k8sClient,\n+\t\t\tNamespace: \"kubeless\",\n+\t\t\tConfig: k8sClientConfig,\n+\t\t\tPodName: podName,\n+\t\t\tPodClient: clientset.Core(),\n+\t\t\tPorts: portSlice,\n+\t\t\tPortForwarder: &defaultPortForwarder{\n+\t\t\t\tcmdOut: devNull,\n+\t\t\t\tcmdErr: os.Stderr,\n+\t\t\t},\n+\t\t\tStopChannel: make(chan struct{}, 1),\n+\t\t\tReadyChannel: make(chan struct{}),\n+\t\t}\n+\t\terr = pfo.RunPortForward()\n+\t\tif err != nil {\n+\t\t\tlogrus.Fatalf(\"Connection failed: %v\", err)\n+\t\t}\n+\n+\t}()\n+\treturn\n+}\n+\n+func getMinioURLFromOutsideCluster() (url string, err error) {\n+\tf := cmdutil.NewFactory(nil)","path":"cmd/kubeless/function.go","position":155,"original_position":155,"commit_id":"7c1df5ce26b7db8d701d7738dc6b8687f373dd54","original_commit_id":"7c1df5ce26b7db8d701d7738dc6b8687f373dd54","user":{"login":"anguslees","id":224224,"avatar_url":"https://avatars0.githubusercontent.com/u/224224?v=4","gravatar_id":"","url":"https://api.github.com/users/anguslees","html_url":"https://github.com/anguslees","followers_url":"https://api.github.com/users/anguslees/followers","following_url":"https://api.github.com/users/anguslees/following{/other_user}","gists_url":"https://api.github.com/users/anguslees/gists{/gist_id}","starred_url":"https://api.github.com/users/anguslees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anguslees/subscriptions","organizations_url":"https://api.github.com/users/anguslees/orgs","repos_url":"https://api.github.com/users/anguslees/repos","events_url":"https://api.github.com/users/anguslees/events{/privacy}","received_events_url":"https://api.github.com/users/anguslees/received_events","type":"User","site_admin":false},"body":"Avoid using `cmdutil` wherever possible - that's the `kubectl`-internal code that I'm trying to get rid of in another PR. Here, you should be using:\r\n```golang\r\nfunc getMinioURLFromOutsideCluster(clientset kubernetes.Interface) (string, error) {\r\n opts := metav1.ListOptions{LabelSelector: \"kubeless=minio\"}\r\n pods, err := clientset.CoreV1().Pods(\"kubeless\").List(opts)\r\n ...\r\n}\r\n```","created_at":"2017-10-24T04:06:23Z","updated_at":"2017-10-24T04:51:49Z","html_url":"https://github.com/kubeless/kubeless/pull/394#discussion_r146449126","pull_request_url":"https://api.github.com/repos/kubeless/kubeless/pulls/394","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubeless/kubeless/pulls/comments/146449126"},"html":{"href":"https://github.com/kubeless/kubeless/pull/394#discussion_r146449126"},"pull_request":{"href":"https://api.github.com/repos/kubeless/kubeless/pulls/394"}}},"pull_request":{"url":"https://api.github.com/repos/kubeless/kubeless/pulls/394","id":148189010,"html_url":"https://github.com/kubeless/kubeless/pull/394","diff_url":"https://github.com/kubeless/kubeless/pull/394.diff","patch_url":"https://github.com/kubeless/kubeless/pull/394.patch","issue_url":"https://api.github.com/repos/kubeless/kubeless/issues/394","number":394,"state":"open","locked":false,"title":"WIP: Add Minio backend for functions storage","user":{"login":"andresmgot","id":4025665,"avatar_url":"https://avatars0.githubusercontent.com/u/4025665?v=4","gravatar_id":"","url":"https://api.github.com/users/andresmgot","html_url":"https://github.com/andresmgot","followers_url":"https://api.github.com/users/andresmgot/followers","following_url":"https://api.github.com/users/andresmgot/following{/other_user}","gists_url":"https://api.github.com/users/andresmgot/gists{/gist_id}","starred_url":"https://api.github.com/users/andresmgot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresmgot/subscriptions","organizations_url":"https://api.github.com/users/andresmgot/orgs","repos_url":"https://api.github.com/users/andresmgot/repos","events_url":"https://api.github.com/users/andresmgot/events{/privacy}","received_events_url":"https://api.github.com/users/andresmgot/received_events","type":"User","site_admin":false},"body":"This PR substitutes the usage of ConfigMaps for storing functions code (#355) with an storage service (Minio).\r\n\r\nSummary:\r\n\r\nWe have changed the function spec definition, now instead of holding the code of the function it has a reference to the file name stored in Minio and its checksum. To avoid overwriting existing functions the files are stored in Minio as `filename.ext.sha256`.\r\n\r\nTo access the Minio service the CLI creates a port forward tunnel to access the service at `localhost:port`. We need to do the above since (for being S3 compliant) the URL cannot contain relative paths (we cannot use `<endpoint>/api/v1/api/v1/proxy/namespaces/kubeless/services/minio` since it is not a valid URL).\r\n\r\nThe init container downloads the file for the Minio bucket and in case it is a Zip file it extracts its content.\r\n\r\nTODOs:\r\n- [ ] Garbage collector mechanism\r\n- [ ] Unit tests\r\n- [ ] Update Docs\r\n- [ ] Adapt kubeless UI\r\n- [ ] Adapt serverless plugin\r\n- [ ] Jsonnet manifest for Minio\r\n- [ ] Rebuild init images to include required build tools\r\n","created_at":"2017-10-23T17:11:11Z","updated_at":"2017-10-24T04:51:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a813bbdb67c879fbcbdd4c11ce1068f51b1763c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubeless/kubeless/pulls/394/commits","review_comments_url":"https://api.github.com/repos/kubeless/kubeless/pulls/394/comments","review_comment_url":"https://api.github.com/repos/kubeless/kubeless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeless/kubeless/issues/394/comments","statuses_url":"https://api.github.com/repos/kubeless/kubeless/statuses/7c1df5ce26b7db8d701d7738dc6b8687f373dd54","head":{"label":"andresmgot:minio","ref":"minio","sha":"7c1df5ce26b7db8d701d7738dc6b8687f373dd54","user":{"login":"andresmgot","id":4025665,"avatar_url":"https://avatars0.githubusercontent.com/u/4025665?v=4","gravatar_id":"","url":"https://api.github.com/users/andresmgot","html_url":"https://github.com/andresmgot","followers_url":"https://api.github.com/users/andresmgot/followers","following_url":"https://api.github.com/users/andresmgot/following{/other_user}","gists_url":"https://api.github.com/users/andresmgot/gists{/gist_id}","starred_url":"https://api.github.com/users/andresmgot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresmgot/subscriptions","organizations_url":"https://api.github.com/users/andresmgot/orgs","repos_url":"https://api.github.com/users/andresmgot/repos","events_url":"https://api.github.com/users/andresmgot/events{/privacy}","received_events_url":"https://api.github.com/users/andresmgot/received_events","type":"User","site_admin":false},"repo":{"id":98203770,"name":"kubeless","full_name":"andresmgot/kubeless","owner":{"login":"andresmgot","id":4025665,"avatar_url":"https://avatars0.githubusercontent.com/u/4025665?v=4","gravatar_id":"","url":"https://api.github.com/users/andresmgot","html_url":"https://github.com/andresmgot","followers_url":"https://api.github.com/users/andresmgot/followers","following_url":"https://api.github.com/users/andresmgot/following{/other_user}","gists_url":"https://api.github.com/users/andresmgot/gists{/gist_id}","starred_url":"https://api.github.com/users/andresmgot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresmgot/subscriptions","organizations_url":"https://api.github.com/users/andresmgot/orgs","repos_url":"https://api.github.com/users/andresmgot/repos","events_url":"https://api.github.com/users/andresmgot/events{/privacy}","received_events_url":"https://api.github.com/users/andresmgot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andresmgot/kubeless","description":"Kubernetes Native Serverless Framework","fork":true,"url":"https://api.github.com/repos/andresmgot/kubeless","forks_url":"https://api.github.com/repos/andresmgot/kubeless/forks","keys_url":"https://api.github.com/repos/andresmgot/kubeless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andresmgot/kubeless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andresmgot/kubeless/teams","hooks_url":"https://api.github.com/repos/andresmgot/kubeless/hooks","issue_events_url":"https://api.github.com/repos/andresmgot/kubeless/issues/events{/number}","events_url":"https://api.github.com/repos/andresmgot/kubeless/events","assignees_url":"https://api.github.com/repos/andresmgot/kubeless/assignees{/user}","branches_url":"https://api.github.com/repos/andresmgot/kubeless/branches{/branch}","tags_url":"https://api.github.com/repos/andresmgot/kubeless/tags","blobs_url":"https://api.github.com/repos/andresmgot/kubeless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andresmgot/kubeless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andresmgot/kubeless/git/refs{/sha}","trees_url":"https://api.github.com/repos/andresmgot/kubeless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andresmgot/kubeless/statuses/{sha}","languages_url":"https://api.github.com/repos/andresmgot/kubeless/languages","stargazers_url":"https://api.github.com/repos/andresmgot/kubeless/stargazers","contributors_url":"https://api.github.com/repos/andresmgot/kubeless/contributors","subscribers_url":"https://api.github.com/repos/andresmgot/kubeless/subscribers","subscription_url":"https://api.github.com/repos/andresmgot/kubeless/subscription","commits_url":"https://api.github.com/repos/andresmgot/kubeless/commits{/sha}","git_commits_url":"https://api.github.com/repos/andresmgot/kubeless/git/commits{/sha}","comments_url":"https://api.github.com/repos/andresmgot/kubeless/comments{/number}","issue_comment_url":"https://api.github.com/repos/andresmgot/kubeless/issues/comments{/number}","contents_url":"https://api.github.com/repos/andresmgot/kubeless/contents/{+path}","compare_url":"https://api.github.com/repos/andresmgot/kubeless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andresmgot/kubeless/merges","archive_url":"https://api.github.com/repos/andresmgot/kubeless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andresmgot/kubeless/downloads","issues_url":"https://api.github.com/repos/andresmgot/kubeless/issues{/number}","pulls_url":"https://api.github.com/repos/andresmgot/kubeless/pulls{/number}","milestones_url":"https://api.github.com/repos/andresmgot/kubeless/milestones{/number}","notifications_url":"https://api.github.com/repos/andresmgot/kubeless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andresmgot/kubeless/labels{/name}","releases_url":"https://api.github.com/repos/andresmgot/kubeless/releases{/id}","deployments_url":"https://api.github.com/repos/andresmgot/kubeless/deployments","created_at":"2017-07-24T15:06:42Z","updated_at":"2017-07-24T15:06:44Z","pushed_at":"2017-10-23T16:56:33Z","git_url":"git://github.com/andresmgot/kubeless.git","ssh_url":"[email protected]:andresmgot/kubeless.git","clone_url":"https://github.com/andresmgot/kubeless.git","svn_url":"https://github.com/andresmgot/kubeless","homepage":"http://kubeless.io","size":39588,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubeless:master","ref":"master","sha":"431ae11666d2d2200aea8db6028c55078bae3296","user":{"login":"kubeless","id":25339039,"avatar_url":"https://avatars3.githubusercontent.com/u/25339039?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeless","html_url":"https://github.com/kubeless","followers_url":"https://api.github.com/users/kubeless/followers","following_url":"https://api.github.com/users/kubeless/following{/other_user}","gists_url":"https://api.github.com/users/kubeless/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeless/subscriptions","organizations_url":"https://api.github.com/users/kubeless/orgs","repos_url":"https://api.github.com/users/kubeless/repos","events_url":"https://api.github.com/users/kubeless/events{/privacy}","received_events_url":"https://api.github.com/users/kubeless/received_events","type":"Organization","site_admin":false},"repo":{"id":73902337,"name":"kubeless","full_name":"kubeless/kubeless","owner":{"login":"kubeless","id":25339039,"avatar_url":"https://avatars3.githubusercontent.com/u/25339039?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeless","html_url":"https://github.com/kubeless","followers_url":"https://api.github.com/users/kubeless/followers","following_url":"https://api.github.com/users/kubeless/following{/other_user}","gists_url":"https://api.github.com/users/kubeless/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeless/subscriptions","organizations_url":"https://api.github.com/users/kubeless/orgs","repos_url":"https://api.github.com/users/kubeless/repos","events_url":"https://api.github.com/users/kubeless/events{/privacy}","received_events_url":"https://api.github.com/users/kubeless/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubeless/kubeless","description":"Kubernetes Native Serverless Framework","fork":false,"url":"https://api.github.com/repos/kubeless/kubeless","forks_url":"https://api.github.com/repos/kubeless/kubeless/forks","keys_url":"https://api.github.com/repos/kubeless/kubeless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeless/kubeless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeless/kubeless/teams","hooks_url":"https://api.github.com/repos/kubeless/kubeless/hooks","issue_events_url":"https://api.github.com/repos/kubeless/kubeless/issues/events{/number}","events_url":"https://api.github.com/repos/kubeless/kubeless/events","assignees_url":"https://api.github.com/repos/kubeless/kubeless/assignees{/user}","branches_url":"https://api.github.com/repos/kubeless/kubeless/branches{/branch}","tags_url":"https://api.github.com/repos/kubeless/kubeless/tags","blobs_url":"https://api.github.com/repos/kubeless/kubeless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeless/kubeless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeless/kubeless/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeless/kubeless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeless/kubeless/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeless/kubeless/languages","stargazers_url":"https://api.github.com/repos/kubeless/kubeless/stargazers","contributors_url":"https://api.github.com/repos/kubeless/kubeless/contributors","subscribers_url":"https://api.github.com/repos/kubeless/kubeless/subscribers","subscription_url":"https://api.github.com/repos/kubeless/kubeless/subscription","commits_url":"https://api.github.com/repos/kubeless/kubeless/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeless/kubeless/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeless/kubeless/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeless/kubeless/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeless/kubeless/contents/{+path}","compare_url":"https://api.github.com/repos/kubeless/kubeless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeless/kubeless/merges","archive_url":"https://api.github.com/repos/kubeless/kubeless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeless/kubeless/downloads","issues_url":"https://api.github.com/repos/kubeless/kubeless/issues{/number}","pulls_url":"https://api.github.com/repos/kubeless/kubeless/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeless/kubeless/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeless/kubeless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeless/kubeless/labels{/name}","releases_url":"https://api.github.com/repos/kubeless/kubeless/releases{/id}","deployments_url":"https://api.github.com/repos/kubeless/kubeless/deployments","created_at":"2016-11-16T09:03:03Z","updated_at":"2017-10-24T03:53:43Z","pushed_at":"2017-10-23T19:38:52Z","git_url":"git://github.com/kubeless/kubeless.git","ssh_url":"[email protected]:kubeless/kubeless.git","clone_url":"https://github.com/kubeless/kubeless.git","svn_url":"https://github.com/kubeless/kubeless","homepage":"http://kubeless.io","size":39523,"stargazers_count":1229,"watchers_count":1229,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"archived":false,"open_issues_count":49,"forks":105,"open_issues":49,"watchers":1229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeless/kubeless/pulls/394"},"html":{"href":"https://github.com/kubeless/kubeless/pull/394"},"issue":{"href":"https://api.github.com/repos/kubeless/kubeless/issues/394"},"comments":{"href":"https://api.github.com/repos/kubeless/kubeless/issues/394/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeless/kubeless/pulls/394/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeless/kubeless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeless/kubeless/pulls/394/commits"},"statuses":{"href":"https://api.github.com/repos/kubeless/kubeless/statuses/7c1df5ce26b7db8d701d7738dc6b8687f373dd54"}},"author_association":"CONTRIBUTOR"}} | {
"id": 73902337,
"name": "kubeless/kubeless",
"url": "https://api.github.com/repos/kubeless/kubeless"
} | {
"id": 224224,
"login": "anguslees",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/224224?",
"url": "https://api.github.com/users/anguslees"
} | {
"id": 25339039,
"login": "kubeless",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25339039?",
"url": "https://api.github.com/orgs/kubeless"
} | 2017-10-24T04:06:23 | 6756076646 | {"actor":{"display_login":"anguslees"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/linagora/james-project/pulls/comments/131645016","pull_request_review_id":54641454,"id":131645016,"diff_hunk":"@@ -66,12 +66,7 @@\n public class JPAMessageMapper extends JPATransactionalMapper implements MessageMapper {\n private static final int UNLIMIT_MAX_SIZE = -1;\n private static final int UNLIMITED = -1;\n- private static final Function<MailboxMessage, MessageUid> TO_UID = new Function<MailboxMessage, MessageUid>() {\n- @Override\n- public MessageUid apply(MailboxMessage mailboxMessage) {\n- return mailboxMessage.getUid();\n- }\n- };\n+ private static final Function<MailboxMessage, MessageUid> TO_UID = MailboxMessage::getUid;","path":"mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/mail/JPAMessageMapper.java","position":10,"original_position":10,"commit_id":"36c9f996931928492145e59abbea9ab843c075e5","original_commit_id":"719cb7fc0c3ae3330b423dc87106ace15887ce63","user":{"login":"mbaechler","id":708318,"avatar_url":"https://avatars2.githubusercontent.com/u/708318?v=4","gravatar_id":"","url":"https://api.github.com/users/mbaechler","html_url":"https://github.com/mbaechler","followers_url":"https://api.github.com/users/mbaechler/followers","following_url":"https://api.github.com/users/mbaechler/following{/other_user}","gists_url":"https://api.github.com/users/mbaechler/gists{/gist_id}","starred_url":"https://api.github.com/users/mbaechler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbaechler/subscriptions","organizations_url":"https://api.github.com/users/mbaechler/orgs","repos_url":"https://api.github.com/users/mbaechler/repos","events_url":"https://api.github.com/users/mbaechler/events{/privacy}","received_events_url":"https://api.github.com/users/mbaechler/received_events","type":"User","site_admin":false},"body":"should be inline","created_at":"2017-08-07T12:48:55Z","updated_at":"2017-08-07T12:56:50Z","html_url":"https://github.com/linagora/james-project/pull/920#discussion_r131645016","pull_request_url":"https://api.github.com/repos/linagora/james-project/pulls/920","_links":{"self":{"href":"https://api.github.com/repos/linagora/james-project/pulls/comments/131645016"},"html":{"href":"https://github.com/linagora/james-project/pull/920#discussion_r131645016"},"pull_request":{"href":"https://api.github.com/repos/linagora/james-project/pulls/920"}}},"pull_request":{"url":"https://api.github.com/repos/linagora/james-project/pulls/920","id":133884992,"html_url":"https://github.com/linagora/james-project/pull/920","diff_url":"https://github.com/linagora/james-project/pull/920.diff","patch_url":"https://github.com/linagora/james-project/pull/920.patch","issue_url":"https://api.github.com/repos/linagora/james-project/issues/920","number":920,"state":"open","locked":false,"title":"JAMES-2107 Java-8 migration + automatic refactoring","user":{"login":"chibenwa","id":6928740,"avatar_url":"https://avatars1.githubusercontent.com/u/6928740?v=4","gravatar_id":"","url":"https://api.github.com/users/chibenwa","html_url":"https://github.com/chibenwa","followers_url":"https://api.github.com/users/chibenwa/followers","following_url":"https://api.github.com/users/chibenwa/following{/other_user}","gists_url":"https://api.github.com/users/chibenwa/gists{/gist_id}","starred_url":"https://api.github.com/users/chibenwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chibenwa/subscriptions","organizations_url":"https://api.github.com/users/chibenwa/orgs","repos_url":"https://api.github.com/users/chibenwa/repos","events_url":"https://api.github.com/users/chibenwa/events{/privacy}","received_events_url":"https://api.github.com/users/chibenwa/received_events","type":"User","site_admin":false},"body":"Includes automatic IntelliJ refactorings:\r\n - From imperative to Streams\r\n - From anonymous to lambdas\r\n - Remove no more needed explicit\r\n - Some call chain simplification\r\n\r\nThis PR is based on https://github.com/linagora/james-project/pull/918\r\n\r\nIt is run directly by a custom CI JOB as it is not compatible with CI current state. See https://github.com/linagora/james-jenkins/pull/77. \r\n\r\nDirect link to CI Job: https://james.open-paas.org/job/build%20JAMES-2107-2/","created_at":"2017-08-03T08:23:39Z","updated_at":"2017-08-07T12:56:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ec3d1bb47dffc8565043574c5e5c05b8d2f6d25","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/linagora/james-project/pulls/920/commits","review_comments_url":"https://api.github.com/repos/linagora/james-project/pulls/920/comments","review_comment_url":"https://api.github.com/repos/linagora/james-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linagora/james-project/issues/920/comments","statuses_url":"https://api.github.com/repos/linagora/james-project/statuses/36c9f996931928492145e59abbea9ab843c075e5","head":{"label":"chibenwa:JAMES-2107-2","ref":"JAMES-2107-2","sha":"36c9f996931928492145e59abbea9ab843c075e5","user":{"login":"chibenwa","id":6928740,"avatar_url":"https://avatars1.githubusercontent.com/u/6928740?v=4","gravatar_id":"","url":"https://api.github.com/users/chibenwa","html_url":"https://github.com/chibenwa","followers_url":"https://api.github.com/users/chibenwa/followers","following_url":"https://api.github.com/users/chibenwa/following{/other_user}","gists_url":"https://api.github.com/users/chibenwa/gists{/gist_id}","starred_url":"https://api.github.com/users/chibenwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chibenwa/subscriptions","organizations_url":"https://api.github.com/users/chibenwa/orgs","repos_url":"https://api.github.com/users/chibenwa/repos","events_url":"https://api.github.com/users/chibenwa/events{/privacy}","received_events_url":"https://api.github.com/users/chibenwa/received_events","type":"User","site_admin":false},"repo":{"id":42459504,"name":"james-project","full_name":"chibenwa/james-project","owner":{"login":"chibenwa","id":6928740,"avatar_url":"https://avatars1.githubusercontent.com/u/6928740?v=4","gravatar_id":"","url":"https://api.github.com/users/chibenwa","html_url":"https://github.com/chibenwa","followers_url":"https://api.github.com/users/chibenwa/followers","following_url":"https://api.github.com/users/chibenwa/following{/other_user}","gists_url":"https://api.github.com/users/chibenwa/gists{/gist_id}","starred_url":"https://api.github.com/users/chibenwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chibenwa/subscriptions","organizations_url":"https://api.github.com/users/chibenwa/orgs","repos_url":"https://api.github.com/users/chibenwa/repos","events_url":"https://api.github.com/users/chibenwa/events{/privacy}","received_events_url":"https://api.github.com/users/chibenwa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chibenwa/james-project","description":"Mirror of Apache James Project","fork":true,"url":"https://api.github.com/repos/chibenwa/james-project","forks_url":"https://api.github.com/repos/chibenwa/james-project/forks","keys_url":"https://api.github.com/repos/chibenwa/james-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chibenwa/james-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chibenwa/james-project/teams","hooks_url":"https://api.github.com/repos/chibenwa/james-project/hooks","issue_events_url":"https://api.github.com/repos/chibenwa/james-project/issues/events{/number}","events_url":"https://api.github.com/repos/chibenwa/james-project/events","assignees_url":"https://api.github.com/repos/chibenwa/james-project/assignees{/user}","branches_url":"https://api.github.com/repos/chibenwa/james-project/branches{/branch}","tags_url":"https://api.github.com/repos/chibenwa/james-project/tags","blobs_url":"https://api.github.com/repos/chibenwa/james-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chibenwa/james-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chibenwa/james-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/chibenwa/james-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chibenwa/james-project/statuses/{sha}","languages_url":"https://api.github.com/repos/chibenwa/james-project/languages","stargazers_url":"https://api.github.com/repos/chibenwa/james-project/stargazers","contributors_url":"https://api.github.com/repos/chibenwa/james-project/contributors","subscribers_url":"https://api.github.com/repos/chibenwa/james-project/subscribers","subscription_url":"https://api.github.com/repos/chibenwa/james-project/subscription","commits_url":"https://api.github.com/repos/chibenwa/james-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/chibenwa/james-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/chibenwa/james-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/chibenwa/james-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/chibenwa/james-project/contents/{+path}","compare_url":"https://api.github.com/repos/chibenwa/james-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chibenwa/james-project/merges","archive_url":"https://api.github.com/repos/chibenwa/james-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chibenwa/james-project/downloads","issues_url":"https://api.github.com/repos/chibenwa/james-project/issues{/number}","pulls_url":"https://api.github.com/repos/chibenwa/james-project/pulls{/number}","milestones_url":"https://api.github.com/repos/chibenwa/james-project/milestones{/number}","notifications_url":"https://api.github.com/repos/chibenwa/james-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chibenwa/james-project/labels{/name}","releases_url":"https://api.github.com/repos/chibenwa/james-project/releases{/id}","deployments_url":"https://api.github.com/repos/chibenwa/james-project/deployments","created_at":"2015-09-14T15:57:25Z","updated_at":"2017-02-08T09:35:46Z","pushed_at":"2017-08-07T10:18:26Z","git_url":"git://github.com/chibenwa/james-project.git","ssh_url":"[email protected]:chibenwa/james-project.git","clone_url":"https://github.com/chibenwa/james-project.git","svn_url":"https://github.com/chibenwa/james-project","homepage":null,"size":29154,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"trunk"}},"base":{"label":"linagora:master","ref":"master","sha":"7c333a50d85ff43ed64a5931063abf35e7dfeccb","user":{"login":"linagora","id":1230365,"avatar_url":"https://avatars3.githubusercontent.com/u/1230365?v=4","gravatar_id":"","url":"https://api.github.com/users/linagora","html_url":"https://github.com/linagora","followers_url":"https://api.github.com/users/linagora/followers","following_url":"https://api.github.com/users/linagora/following{/other_user}","gists_url":"https://api.github.com/users/linagora/gists{/gist_id}","starred_url":"https://api.github.com/users/linagora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linagora/subscriptions","organizations_url":"https://api.github.com/users/linagora/orgs","repos_url":"https://api.github.com/users/linagora/repos","events_url":"https://api.github.com/users/linagora/events{/privacy}","received_events_url":"https://api.github.com/users/linagora/received_events","type":"Organization","site_admin":false},"repo":{"id":39182136,"name":"james-project","full_name":"linagora/james-project","owner":{"login":"linagora","id":1230365,"avatar_url":"https://avatars3.githubusercontent.com/u/1230365?v=4","gravatar_id":"","url":"https://api.github.com/users/linagora","html_url":"https://github.com/linagora","followers_url":"https://api.github.com/users/linagora/followers","following_url":"https://api.github.com/users/linagora/following{/other_user}","gists_url":"https://api.github.com/users/linagora/gists{/gist_id}","starred_url":"https://api.github.com/users/linagora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linagora/subscriptions","organizations_url":"https://api.github.com/users/linagora/orgs","repos_url":"https://api.github.com/users/linagora/repos","events_url":"https://api.github.com/users/linagora/events{/privacy}","received_events_url":"https://api.github.com/users/linagora/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linagora/james-project","description":"Mirror of Apache James Project","fork":true,"url":"https://api.github.com/repos/linagora/james-project","forks_url":"https://api.github.com/repos/linagora/james-project/forks","keys_url":"https://api.github.com/repos/linagora/james-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linagora/james-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linagora/james-project/teams","hooks_url":"https://api.github.com/repos/linagora/james-project/hooks","issue_events_url":"https://api.github.com/repos/linagora/james-project/issues/events{/number}","events_url":"https://api.github.com/repos/linagora/james-project/events","assignees_url":"https://api.github.com/repos/linagora/james-project/assignees{/user}","branches_url":"https://api.github.com/repos/linagora/james-project/branches{/branch}","tags_url":"https://api.github.com/repos/linagora/james-project/tags","blobs_url":"https://api.github.com/repos/linagora/james-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linagora/james-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linagora/james-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/linagora/james-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linagora/james-project/statuses/{sha}","languages_url":"https://api.github.com/repos/linagora/james-project/languages","stargazers_url":"https://api.github.com/repos/linagora/james-project/stargazers","contributors_url":"https://api.github.com/repos/linagora/james-project/contributors","subscribers_url":"https://api.github.com/repos/linagora/james-project/subscribers","subscription_url":"https://api.github.com/repos/linagora/james-project/subscription","commits_url":"https://api.github.com/repos/linagora/james-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/linagora/james-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/linagora/james-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/linagora/james-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/linagora/james-project/contents/{+path}","compare_url":"https://api.github.com/repos/linagora/james-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linagora/james-project/merges","archive_url":"https://api.github.com/repos/linagora/james-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linagora/james-project/downloads","issues_url":"https://api.github.com/repos/linagora/james-project/issues{/number}","pulls_url":"https://api.github.com/repos/linagora/james-project/pulls{/number}","milestones_url":"https://api.github.com/repos/linagora/james-project/milestones{/number}","notifications_url":"https://api.github.com/repos/linagora/james-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linagora/james-project/labels{/name}","releases_url":"https://api.github.com/repos/linagora/james-project/releases{/id}","deployments_url":"https://api.github.com/repos/linagora/james-project/deployments","created_at":"2015-07-16T07:04:59Z","updated_at":"2017-06-30T07:13:12Z","pushed_at":"2017-08-07T10:18:28Z","git_url":"git://github.com/linagora/james-project.git","ssh_url":"[email protected]:linagora/james-project.git","clone_url":"https://github.com/linagora/james-project.git","svn_url":"https://github.com/linagora/james-project","homepage":null,"size":22704,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":33,"forks":16,"open_issues":33,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linagora/james-project/pulls/920"},"html":{"href":"https://github.com/linagora/james-project/pull/920"},"issue":{"href":"https://api.github.com/repos/linagora/james-project/issues/920"},"comments":{"href":"https://api.github.com/repos/linagora/james-project/issues/920/comments"},"review_comments":{"href":"https://api.github.com/repos/linagora/james-project/pulls/920/comments"},"review_comment":{"href":"https://api.github.com/repos/linagora/james-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linagora/james-project/pulls/920/commits"},"statuses":{"href":"https://api.github.com/repos/linagora/james-project/statuses/36c9f996931928492145e59abbea9ab843c075e5"}}}} | {
"id": 39182136,
"name": "linagora/james-project",
"url": "https://api.github.com/repos/linagora/james-project"
} | {
"id": 708318,
"login": "mbaechler",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/708318?",
"url": "https://api.github.com/users/mbaechler"
} | {
"id": 1230365,
"login": "linagora",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1230365?",
"url": "https://api.github.com/orgs/linagora"
} | 2017-08-07T12:48:55 | 6407195681 | {"actor":{"display_login":"mbaechler"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/linagora/james-project/pulls/comments/136954469","pull_request_review_id":60561287,"id":136954469,"diff_hunk":"@@ -823,4 +830,23 @@ public void pipelineShouldSendSeveralJSONOverRabbitMQWhenSeveralAttachments() th\n assertThat(amqpRule.readContent()).isEmpty();\n }\n \n+ @Test\n+ public void mailShouldNotContainCalendarContentInTextBodyButAttachment() throws Exception {\n+ Mail mail = FakeMail.builder()\n+ .mimeMessage(calendarMessage)\n+ .sender(new MailAddress(FROM))\n+ .recipient(new MailAddress(RECIPIENT))\n+ .build();\n+\n+ try (SMTPMessageSender messageSender = SMTPMessageSender.noAuthentication(LOCALHOST_IP, SMTP_PORT, JAMES_APACHE_ORG);\n+ IMAPMessageReader imapMessageReader = new IMAPMessageReader(LOCALHOST_IP, IMAP_PORT)) {","path":"server/mailet/integration-testing/src/test/java/org/apache/james/transport/mailets/ICSAttachmentWorkflowTest.java","position":69,"original_position":69,"commit_id":"3cf52958dc89f6f2034a79c34f792294ea8bd86e","original_commit_id":"3cf52958dc89f6f2034a79c34f792294ea8bd86e","user":{"login":"chibenwa","id":6928740,"avatar_url":"https://avatars1.githubusercontent.com/u/6928740?v=4","gravatar_id":"","url":"https://api.github.com/users/chibenwa","html_url":"https://github.com/chibenwa","followers_url":"https://api.github.com/users/chibenwa/followers","following_url":"https://api.github.com/users/chibenwa/following{/other_user}","gists_url":"https://api.github.com/users/chibenwa/gists{/gist_id}","starred_url":"https://api.github.com/users/chibenwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chibenwa/subscriptions","organizations_url":"https://api.github.com/users/chibenwa/orgs","repos_url":"https://api.github.com/users/chibenwa/repos","events_url":"https://api.github.com/users/chibenwa/events{/privacy}","received_events_url":"https://api.github.com/users/chibenwa/received_events","type":"User","site_admin":false},"body":"Ident issue","created_at":"2017-09-05T10:53:56Z","updated_at":"2017-09-05T10:53:56Z","html_url":"https://github.com/linagora/james-project/pull/955#discussion_r136954469","pull_request_url":"https://api.github.com/repos/linagora/james-project/pulls/955","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/linagora/james-project/pulls/comments/136954469"},"html":{"href":"https://github.com/linagora/james-project/pull/955#discussion_r136954469"},"pull_request":{"href":"https://api.github.com/repos/linagora/james-project/pulls/955"}}},"pull_request":{"url":"https://api.github.com/repos/linagora/james-project/pulls/955","id":138830179,"html_url":"https://github.com/linagora/james-project/pull/955","diff_url":"https://github.com/linagora/james-project/pull/955.diff","patch_url":"https://github.com/linagora/james-project/pull/955.patch","issue_url":"https://api.github.com/repos/linagora/james-project/issues/955","number":955,"state":"open","locked":false,"title":"JAMES-2135 text/calendar bodies should not be displayed in textBody","user":{"login":"quynhn","id":296170,"avatar_url":"https://avatars2.githubusercontent.com/u/296170?v=4","gravatar_id":"","url":"https://api.github.com/users/quynhn","html_url":"https://github.com/quynhn","followers_url":"https://api.github.com/users/quynhn/followers","following_url":"https://api.github.com/users/quynhn/following{/other_user}","gists_url":"https://api.github.com/users/quynhn/gists{/gist_id}","starred_url":"https://api.github.com/users/quynhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quynhn/subscriptions","organizations_url":"https://api.github.com/users/quynhn/orgs","repos_url":"https://api.github.com/users/quynhn/repos","events_url":"https://api.github.com/users/quynhn/events{/privacy}","received_events_url":"https://api.github.com/users/quynhn/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-01T07:23:26Z","updated_at":"2017-09-05T10:53:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d694f50867d3adbfa2e3ac488e27af29c200923e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/linagora/james-project/pulls/955/commits","review_comments_url":"https://api.github.com/repos/linagora/james-project/pulls/955/comments","review_comment_url":"https://api.github.com/repos/linagora/james-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linagora/james-project/issues/955/comments","statuses_url":"https://api.github.com/repos/linagora/james-project/statuses/3cf52958dc89f6f2034a79c34f792294ea8bd86e","head":{"label":"quynhn:JAMES-2135","ref":"JAMES-2135","sha":"3cf52958dc89f6f2034a79c34f792294ea8bd86e","user":{"login":"quynhn","id":296170,"avatar_url":"https://avatars2.githubusercontent.com/u/296170?v=4","gravatar_id":"","url":"https://api.github.com/users/quynhn","html_url":"https://github.com/quynhn","followers_url":"https://api.github.com/users/quynhn/followers","following_url":"https://api.github.com/users/quynhn/following{/other_user}","gists_url":"https://api.github.com/users/quynhn/gists{/gist_id}","starred_url":"https://api.github.com/users/quynhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quynhn/subscriptions","organizations_url":"https://api.github.com/users/quynhn/orgs","repos_url":"https://api.github.com/users/quynhn/repos","events_url":"https://api.github.com/users/quynhn/events{/privacy}","received_events_url":"https://api.github.com/users/quynhn/received_events","type":"User","site_admin":false},"repo":{"id":58912828,"name":"james-project","full_name":"quynhn/james-project","owner":{"login":"quynhn","id":296170,"avatar_url":"https://avatars2.githubusercontent.com/u/296170?v=4","gravatar_id":"","url":"https://api.github.com/users/quynhn","html_url":"https://github.com/quynhn","followers_url":"https://api.github.com/users/quynhn/followers","following_url":"https://api.github.com/users/quynhn/following{/other_user}","gists_url":"https://api.github.com/users/quynhn/gists{/gist_id}","starred_url":"https://api.github.com/users/quynhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quynhn/subscriptions","organizations_url":"https://api.github.com/users/quynhn/orgs","repos_url":"https://api.github.com/users/quynhn/repos","events_url":"https://api.github.com/users/quynhn/events{/privacy}","received_events_url":"https://api.github.com/users/quynhn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/quynhn/james-project","description":"Mirror of Apache James Project","fork":true,"url":"https://api.github.com/repos/quynhn/james-project","forks_url":"https://api.github.com/repos/quynhn/james-project/forks","keys_url":"https://api.github.com/repos/quynhn/james-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quynhn/james-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quynhn/james-project/teams","hooks_url":"https://api.github.com/repos/quynhn/james-project/hooks","issue_events_url":"https://api.github.com/repos/quynhn/james-project/issues/events{/number}","events_url":"https://api.github.com/repos/quynhn/james-project/events","assignees_url":"https://api.github.com/repos/quynhn/james-project/assignees{/user}","branches_url":"https://api.github.com/repos/quynhn/james-project/branches{/branch}","tags_url":"https://api.github.com/repos/quynhn/james-project/tags","blobs_url":"https://api.github.com/repos/quynhn/james-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quynhn/james-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quynhn/james-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/quynhn/james-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quynhn/james-project/statuses/{sha}","languages_url":"https://api.github.com/repos/quynhn/james-project/languages","stargazers_url":"https://api.github.com/repos/quynhn/james-project/stargazers","contributors_url":"https://api.github.com/repos/quynhn/james-project/contributors","subscribers_url":"https://api.github.com/repos/quynhn/james-project/subscribers","subscription_url":"https://api.github.com/repos/quynhn/james-project/subscription","commits_url":"https://api.github.com/repos/quynhn/james-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/quynhn/james-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/quynhn/james-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/quynhn/james-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/quynhn/james-project/contents/{+path}","compare_url":"https://api.github.com/repos/quynhn/james-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quynhn/james-project/merges","archive_url":"https://api.github.com/repos/quynhn/james-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quynhn/james-project/downloads","issues_url":"https://api.github.com/repos/quynhn/james-project/issues{/number}","pulls_url":"https://api.github.com/repos/quynhn/james-project/pulls{/number}","milestones_url":"https://api.github.com/repos/quynhn/james-project/milestones{/number}","notifications_url":"https://api.github.com/repos/quynhn/james-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quynhn/james-project/labels{/name}","releases_url":"https://api.github.com/repos/quynhn/james-project/releases{/id}","deployments_url":"https://api.github.com/repos/quynhn/james-project/deployments","created_at":"2016-05-16T07:35:33Z","updated_at":"2016-05-16T07:35:44Z","pushed_at":"2017-09-05T09:54:47Z","git_url":"git://github.com/quynhn/james-project.git","ssh_url":"[email protected]:quynhn/james-project.git","clone_url":"https://github.com/quynhn/james-project.git","svn_url":"https://github.com/quynhn/james-project","homepage":null,"size":25060,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linagora:master","ref":"master","sha":"fd1c775e74815cab1f1aa6f71968c90a185a8ec9","user":{"login":"linagora","id":1230365,"avatar_url":"https://avatars3.githubusercontent.com/u/1230365?v=4","gravatar_id":"","url":"https://api.github.com/users/linagora","html_url":"https://github.com/linagora","followers_url":"https://api.github.com/users/linagora/followers","following_url":"https://api.github.com/users/linagora/following{/other_user}","gists_url":"https://api.github.com/users/linagora/gists{/gist_id}","starred_url":"https://api.github.com/users/linagora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linagora/subscriptions","organizations_url":"https://api.github.com/users/linagora/orgs","repos_url":"https://api.github.com/users/linagora/repos","events_url":"https://api.github.com/users/linagora/events{/privacy}","received_events_url":"https://api.github.com/users/linagora/received_events","type":"Organization","site_admin":false},"repo":{"id":39182136,"name":"james-project","full_name":"linagora/james-project","owner":{"login":"linagora","id":1230365,"avatar_url":"https://avatars3.githubusercontent.com/u/1230365?v=4","gravatar_id":"","url":"https://api.github.com/users/linagora","html_url":"https://github.com/linagora","followers_url":"https://api.github.com/users/linagora/followers","following_url":"https://api.github.com/users/linagora/following{/other_user}","gists_url":"https://api.github.com/users/linagora/gists{/gist_id}","starred_url":"https://api.github.com/users/linagora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linagora/subscriptions","organizations_url":"https://api.github.com/users/linagora/orgs","repos_url":"https://api.github.com/users/linagora/repos","events_url":"https://api.github.com/users/linagora/events{/privacy}","received_events_url":"https://api.github.com/users/linagora/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linagora/james-project","description":"Mirror of Apache James Project","fork":true,"url":"https://api.github.com/repos/linagora/james-project","forks_url":"https://api.github.com/repos/linagora/james-project/forks","keys_url":"https://api.github.com/repos/linagora/james-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linagora/james-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linagora/james-project/teams","hooks_url":"https://api.github.com/repos/linagora/james-project/hooks","issue_events_url":"https://api.github.com/repos/linagora/james-project/issues/events{/number}","events_url":"https://api.github.com/repos/linagora/james-project/events","assignees_url":"https://api.github.com/repos/linagora/james-project/assignees{/user}","branches_url":"https://api.github.com/repos/linagora/james-project/branches{/branch}","tags_url":"https://api.github.com/repos/linagora/james-project/tags","blobs_url":"https://api.github.com/repos/linagora/james-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linagora/james-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linagora/james-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/linagora/james-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linagora/james-project/statuses/{sha}","languages_url":"https://api.github.com/repos/linagora/james-project/languages","stargazers_url":"https://api.github.com/repos/linagora/james-project/stargazers","contributors_url":"https://api.github.com/repos/linagora/james-project/contributors","subscribers_url":"https://api.github.com/repos/linagora/james-project/subscribers","subscription_url":"https://api.github.com/repos/linagora/james-project/subscription","commits_url":"https://api.github.com/repos/linagora/james-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/linagora/james-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/linagora/james-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/linagora/james-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/linagora/james-project/contents/{+path}","compare_url":"https://api.github.com/repos/linagora/james-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linagora/james-project/merges","archive_url":"https://api.github.com/repos/linagora/james-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linagora/james-project/downloads","issues_url":"https://api.github.com/repos/linagora/james-project/issues{/number}","pulls_url":"https://api.github.com/repos/linagora/james-project/pulls{/number}","milestones_url":"https://api.github.com/repos/linagora/james-project/milestones{/number}","notifications_url":"https://api.github.com/repos/linagora/james-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linagora/james-project/labels{/name}","releases_url":"https://api.github.com/repos/linagora/james-project/releases{/id}","deployments_url":"https://api.github.com/repos/linagora/james-project/deployments","created_at":"2015-07-16T07:04:59Z","updated_at":"2017-06-30T07:13:12Z","pushed_at":"2017-09-05T09:54:49Z","git_url":"git://github.com/linagora/james-project.git","ssh_url":"[email protected]:linagora/james-project.git","clone_url":"https://github.com/linagora/james-project.git","svn_url":"https://github.com/linagora/james-project","homepage":null,"size":24494,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":19,"forks":16,"open_issues":19,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linagora/james-project/pulls/955"},"html":{"href":"https://github.com/linagora/james-project/pull/955"},"issue":{"href":"https://api.github.com/repos/linagora/james-project/issues/955"},"comments":{"href":"https://api.github.com/repos/linagora/james-project/issues/955/comments"},"review_comments":{"href":"https://api.github.com/repos/linagora/james-project/pulls/955/comments"},"review_comment":{"href":"https://api.github.com/repos/linagora/james-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linagora/james-project/pulls/955/commits"},"statuses":{"href":"https://api.github.com/repos/linagora/james-project/statuses/3cf52958dc89f6f2034a79c34f792294ea8bd86e"}},"author_association":"NONE"}} | {
"id": 39182136,
"name": "linagora/james-project",
"url": "https://api.github.com/repos/linagora/james-project"
} | {
"id": 6928740,
"login": "chibenwa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6928740?",
"url": "https://api.github.com/users/chibenwa"
} | {
"id": 1230365,
"login": "linagora",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1230365?",
"url": "https://api.github.com/orgs/linagora"
} | 2017-09-05T10:53:56 | 6550400537 | {"actor":{"display_login":"chibenwa"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/linchpin/mesh/pulls/comments/132993616","pull_request_review_id":56126639,"id":132993616,"diff_hunk":"@@ -30,64 +30,66 @@\n */\n require_once LINCHPIN_MESH___PLUGIN_DIR . '/lib/parsedown/Parsedown.php';\n \n-$Parsedown = new Parsedown();\n+$parsedown = new Parsedown();\n ?>\n <div class=\"mesh-wrap\" id=\"mesh-settings\">\n- <div class=\"table\">\n- <img class=\"mesh-logo table-cell\" src=\"<?php echo ( LINCHPIN_MESH___PLUGIN_URL . 'assets/images/mesh-tagline-logo.png' ); ?>\" alt=\"Mesh\" />\n- <h3 class=\"com-button table-cell\">\n- <?php\n- printf( __( '<a href=\"%s\" class=\"button\" target=\"_blank\">%s</a>', 'mesh' ), esc_url( 'https://meshplugin.com' ), esc_html( 'Visit MeshPlugin.com' ) );\n- ?>\n- </h3>\n-\n- <div class=\"clearfix\"></div>\n- </div>\n+\t<div class=\"table\">\n+\t\t<img class=\"mesh-logo table-cell\" src=\"<?php echo esc_url( LINCHPIN_MESH___PLUGIN_URL . 'assets/images/mesh-tagline-logo.png' ); ?>\" alt=\"<?php esc_attr_e( 'Mesh', 'mesh' ); ?>\" />\n+\t\t<h3 class=\"com-button table-cell\">\n+\t\t<?php\n+\t\t\t// translators: %1$s: Mesh Website URL %2$s: Visit CTA. WPCS: xss ok.\n+\t\t\tprintf( wp_kses_post( __( '<a href=\"%1$s\" class=\"button\" target=\"_blank\">%2$s</a>', 'mesh' ) ), esc_url( 'https://meshplugin.com' ), esc_html__( 'Visit MeshPlugin.com', 'mesh' ) ); // WPCS: xss ok.\n+\t\t?>\n+\t\t</h3>\n+\t\t<div class=\"clearfix\"></div>\n+\t</div>\n \t<?php settings_errors( self::$plugin_name . '-notices' ); ?>\n \t<h2 class=\"nav-tab-wrapper negative-bg\">\n \t\t<?php\n \t\tforeach ( $tabs as $tab_slug => $tab_name ) :\n \n \t\t\t$tab_url = add_query_arg( array(\n \t\t\t\t'settings-updated' => false,\n-\t\t\t\t'tab' => esc_attr( $tab_slug ),\n+\t\t\t\t'tab' => $tab_slug,\n \t\t\t) );\n \n \t\t\t$active = ( $active_tab === $tab_slug ) ? ' nav-tab-active' : '';\n \n \t\t\t?>\n- <a href=\"<?php echo esc_url( $tab_url ); ?>\" title=\"<?php echo esc_attr( $tab_name ); ?>\" class=\"nav-tab <?php echo esc_attr( $active ); ?>\">\n+\t\t\t<a href=\"<?php echo esc_url( $tab_url ); ?>\" title=\"<?php echo esc_attr( $tab_name ); ?>\" class=\"nav-tab <?php echo esc_attr( $active ); ?>\">\n \t\t\t\t<?php echo esc_html( $tab_name ); ?>\n- </a>\n+\t\t\t</a>\n \t\t<?php endforeach; ?>\n- </h2>\n+\t</h2>\n \n- <div id=\"poststuff\">\n- <div id=\"post-body\" class=\"metabox-holder\">\n- <div id=\"postbox-container\" class=\"postbox-container\">\n+\t<div id=\"poststuff\">\n+\t\t<div id=\"post-body\" class=\"metabox-holder\">\n+\t\t\t<div id=\"postbox-container\" class=\"postbox-container\">\n \t\t\t\t<?php if ( 'settings' === $active_tab ) : ?>\n- <div id=\"settings\">\n- <?php include_once( LINCHPIN_MESH___PLUGIN_DIR . '/admin/settings-meta-box-display.php' ); ?>\n- </div>\n+\t\t\t\t\t<div id=\"settings\">\n+\t\t\t\t\t\t<?php include_once( LINCHPIN_MESH___PLUGIN_DIR . '/admin/settings-meta-box-display.php' ); ?>\n+\t\t\t\t\t</div>\n \t\t\t\t<?php elseif ( 'changelog' === $active_tab ) : ?>\n \t\t\t\t\t<div class=\"changelog\">\n- <?php\n+\t\t\t\t\t<?php\n \t\t\t\t\t$changelog_path = LINCHPIN_MESH___PLUGIN_DIR . '/CHANGELOG.md';\n \n \t\t\t\t\tif ( file_exists( $changelog_path ) ) {\n \t\t\t\t\t\t$changelog = file_get_contents( $changelog_path, true );\n-\t\t\t\t\t\techo $Parsedown->text( $changelog ); // WPCS: ok.\n+\n+\t\t\t\t\t\t// WPCS: sanitization ok.\n+\t\t\t\t\t\techo wp_kses_post( $parsedown->text( $changelog ) );\n \t\t\t\t\t}\n \t\t\t\t\t?>\n- </div>\n+\t\t\t\t\t</div>\n \t\t\t\t<?php elseif ( 'about' === $active_tab ) : ?>\n- <?php include_once( LINCHPIN_MESH___PLUGIN_DIR . '/admin/settings-about-mesh.php' ); ?>\n- <?php elseif ( 'new' === $active_tab ) : ?>\n- <?php include_once( LINCHPIN_MESH___PLUGIN_DIR . '/admin/settings-whats-new.php' ); ?>\n- <?php else : ?>\n- <?php do_action('mesh_setting_' . $active_tab ); ?>\n+\t\t\t\t\t<?php include_once( LINCHPIN_MESH___PLUGIN_DIR . '/admin/settings-about-mesh.php' ); ?>\n+\t\t\t\t<?php elseif ( 'new' === $active_tab ) : ?>\n+\t\t\t\t\t<?php include_once( LINCHPIN_MESH___PLUGIN_DIR . '/admin/settings-whats-new.php' ); ?>\n+\t\t\t\t<?php else : ?>\n+\t\t\t\t\t<?php do_action( 'mesh_setting_' . $active_tab ); ?>\n \t\t\t\t<?php endif; ?>\n- </div>\n- </div>\n- </div>\n+\t\t\t</div>\n+\t\t</div>\n+\t</div>\n </div>","path":"admin/settings.php","position":98,"original_position":98,"commit_id":"0d0eb5838f4650d0827a747e188140127608c052","original_commit_id":"0d0eb5838f4650d0827a747e188140127608c052","user":{"login":"maxinacube","id":3216640,"avatar_url":"https://avatars3.githubusercontent.com/u/3216640?v=4","gravatar_id":"","url":"https://api.github.com/users/maxinacube","html_url":"https://github.com/maxinacube","followers_url":"https://api.github.com/users/maxinacube/followers","following_url":"https://api.github.com/users/maxinacube/following{/other_user}","gists_url":"https://api.github.com/users/maxinacube/gists{/gist_id}","starred_url":"https://api.github.com/users/maxinacube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxinacube/subscriptions","organizations_url":"https://api.github.com/users/maxinacube/orgs","repos_url":"https://api.github.com/users/maxinacube/repos","events_url":"https://api.github.com/users/maxinacube/events{/privacy}","received_events_url":"https://api.github.com/users/maxinacube/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2017-08-14T16:16:12Z","updated_at":"2017-08-14T16:16:12Z","html_url":"https://github.com/linchpin/mesh/pull/152#discussion_r132993616","pull_request_url":"https://api.github.com/repos/linchpin/mesh/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/linchpin/mesh/pulls/comments/132993616"},"html":{"href":"https://github.com/linchpin/mesh/pull/152#discussion_r132993616"},"pull_request":{"href":"https://api.github.com/repos/linchpin/mesh/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/linchpin/mesh/pulls/152","id":135465505,"html_url":"https://github.com/linchpin/mesh/pull/152","diff_url":"https://github.com/linchpin/mesh/pull/152.diff","patch_url":"https://github.com/linchpin/mesh/pull/152.patch","issue_url":"https://api.github.com/repos/linchpin/mesh/issues/152","number":152,"state":"open","locked":false,"title":"Release/1.2.0","user":{"login":"aaronware","id":3390827,"avatar_url":"https://avatars2.githubusercontent.com/u/3390827?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronware","html_url":"https://github.com/aaronware","followers_url":"https://api.github.com/users/aaronware/followers","following_url":"https://api.github.com/users/aaronware/following{/other_user}","gists_url":"https://api.github.com/users/aaronware/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronware/subscriptions","organizations_url":"https://api.github.com/users/aaronware/orgs","repos_url":"https://api.github.com/users/aaronware/repos","events_url":"https://api.github.com/users/aaronware/events{/privacy}","received_events_url":"https://api.github.com/users/aaronware/received_events","type":"User","site_admin":false},"body":"This merge might be a bit dicey. I did a ton of little WPCS changes. Some security fixes based on WPCS and also this merged in 146 all at the same time. So I expect some merge conflicts.","created_at":"2017-08-12T16:38:02Z","updated_at":"2017-08-14T16:16:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6da9eb4c8d0db1dea1a43274b05ab577b9129e2e","assignee":{"login":"aaronware","id":3390827,"avatar_url":"https://avatars2.githubusercontent.com/u/3390827?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronware","html_url":"https://github.com/aaronware","followers_url":"https://api.github.com/users/aaronware/followers","following_url":"https://api.github.com/users/aaronware/following{/other_user}","gists_url":"https://api.github.com/users/aaronware/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronware/subscriptions","organizations_url":"https://api.github.com/users/aaronware/orgs","repos_url":"https://api.github.com/users/aaronware/repos","events_url":"https://api.github.com/users/aaronware/events{/privacy}","received_events_url":"https://api.github.com/users/aaronware/received_events","type":"User","site_admin":false},"assignees":[{"login":"aaronware","id":3390827,"avatar_url":"https://avatars2.githubusercontent.com/u/3390827?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronware","html_url":"https://github.com/aaronware","followers_url":"https://api.github.com/users/aaronware/followers","following_url":"https://api.github.com/users/aaronware/following{/other_user}","gists_url":"https://api.github.com/users/aaronware/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronware/subscriptions","organizations_url":"https://api.github.com/users/aaronware/orgs","repos_url":"https://api.github.com/users/aaronware/repos","events_url":"https://api.github.com/users/aaronware/events{/privacy}","received_events_url":"https://api.github.com/users/aaronware/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"desrosj","id":359867,"avatar_url":"https://avatars2.githubusercontent.com/u/359867?v=4","gravatar_id":"","url":"https://api.github.com/users/desrosj","html_url":"https://github.com/desrosj","followers_url":"https://api.github.com/users/desrosj/followers","following_url":"https://api.github.com/users/desrosj/following{/other_user}","gists_url":"https://api.github.com/users/desrosj/gists{/gist_id}","starred_url":"https://api.github.com/users/desrosj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desrosj/subscriptions","organizations_url":"https://api.github.com/users/desrosj/orgs","repos_url":"https://api.github.com/users/desrosj/repos","events_url":"https://api.github.com/users/desrosj/events{/privacy}","received_events_url":"https://api.github.com/users/desrosj/received_events","type":"User","site_admin":false},{"login":"nate-allen","id":8797898,"avatar_url":"https://avatars3.githubusercontent.com/u/8797898?v=4","gravatar_id":"","url":"https://api.github.com/users/nate-allen","html_url":"https://github.com/nate-allen","followers_url":"https://api.github.com/users/nate-allen/followers","following_url":"https://api.github.com/users/nate-allen/following{/other_user}","gists_url":"https://api.github.com/users/nate-allen/gists{/gist_id}","starred_url":"https://api.github.com/users/nate-allen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nate-allen/subscriptions","organizations_url":"https://api.github.com/users/nate-allen/orgs","repos_url":"https://api.github.com/users/nate-allen/repos","events_url":"https://api.github.com/users/nate-allen/events{/privacy}","received_events_url":"https://api.github.com/users/nate-allen/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/linchpin/mesh/pulls/152/commits","review_comments_url":"https://api.github.com/repos/linchpin/mesh/pulls/152/comments","review_comment_url":"https://api.github.com/repos/linchpin/mesh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linchpin/mesh/issues/152/comments","statuses_url":"https://api.github.com/repos/linchpin/mesh/statuses/0d0eb5838f4650d0827a747e188140127608c052","head":{"label":"linchpin:release/1.2.0","ref":"release/1.2.0","sha":"0d0eb5838f4650d0827a747e188140127608c052","user":{"login":"linchpin","id":8070351,"avatar_url":"https://avatars1.githubusercontent.com/u/8070351?v=4","gravatar_id":"","url":"https://api.github.com/users/linchpin","html_url":"https://github.com/linchpin","followers_url":"https://api.github.com/users/linchpin/followers","following_url":"https://api.github.com/users/linchpin/following{/other_user}","gists_url":"https://api.github.com/users/linchpin/gists{/gist_id}","starred_url":"https://api.github.com/users/linchpin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linchpin/subscriptions","organizations_url":"https://api.github.com/users/linchpin/orgs","repos_url":"https://api.github.com/users/linchpin/repos","events_url":"https://api.github.com/users/linchpin/events{/privacy}","received_events_url":"https://api.github.com/users/linchpin/received_events","type":"Organization","site_admin":false},"repo":{"id":56555906,"name":"mesh","full_name":"linchpin/mesh","owner":{"login":"linchpin","id":8070351,"avatar_url":"https://avatars1.githubusercontent.com/u/8070351?v=4","gravatar_id":"","url":"https://api.github.com/users/linchpin","html_url":"https://github.com/linchpin","followers_url":"https://api.github.com/users/linchpin/followers","following_url":"https://api.github.com/users/linchpin/following{/other_user}","gists_url":"https://api.github.com/users/linchpin/gists{/gist_id}","starred_url":"https://api.github.com/users/linchpin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linchpin/subscriptions","organizations_url":"https://api.github.com/users/linchpin/orgs","repos_url":"https://api.github.com/users/linchpin/repos","events_url":"https://api.github.com/users/linchpin/events{/privacy}","received_events_url":"https://api.github.com/users/linchpin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linchpin/mesh","description":"A page builder, simplified. Get the most flexibility to display content by adding multiple content sections within Pages, Posts, or Custom Post Types.","fork":false,"url":"https://api.github.com/repos/linchpin/mesh","forks_url":"https://api.github.com/repos/linchpin/mesh/forks","keys_url":"https://api.github.com/repos/linchpin/mesh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linchpin/mesh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linchpin/mesh/teams","hooks_url":"https://api.github.com/repos/linchpin/mesh/hooks","issue_events_url":"https://api.github.com/repos/linchpin/mesh/issues/events{/number}","events_url":"https://api.github.com/repos/linchpin/mesh/events","assignees_url":"https://api.github.com/repos/linchpin/mesh/assignees{/user}","branches_url":"https://api.github.com/repos/linchpin/mesh/branches{/branch}","tags_url":"https://api.github.com/repos/linchpin/mesh/tags","blobs_url":"https://api.github.com/repos/linchpin/mesh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linchpin/mesh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linchpin/mesh/git/refs{/sha}","trees_url":"https://api.github.com/repos/linchpin/mesh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linchpin/mesh/statuses/{sha}","languages_url":"https://api.github.com/repos/linchpin/mesh/languages","stargazers_url":"https://api.github.com/repos/linchpin/mesh/stargazers","contributors_url":"https://api.github.com/repos/linchpin/mesh/contributors","subscribers_url":"https://api.github.com/repos/linchpin/mesh/subscribers","subscription_url":"https://api.github.com/repos/linchpin/mesh/subscription","commits_url":"https://api.github.com/repos/linchpin/mesh/commits{/sha}","git_commits_url":"https://api.github.com/repos/linchpin/mesh/git/commits{/sha}","comments_url":"https://api.github.com/repos/linchpin/mesh/comments{/number}","issue_comment_url":"https://api.github.com/repos/linchpin/mesh/issues/comments{/number}","contents_url":"https://api.github.com/repos/linchpin/mesh/contents/{+path}","compare_url":"https://api.github.com/repos/linchpin/mesh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linchpin/mesh/merges","archive_url":"https://api.github.com/repos/linchpin/mesh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linchpin/mesh/downloads","issues_url":"https://api.github.com/repos/linchpin/mesh/issues{/number}","pulls_url":"https://api.github.com/repos/linchpin/mesh/pulls{/number}","milestones_url":"https://api.github.com/repos/linchpin/mesh/milestones{/number}","notifications_url":"https://api.github.com/repos/linchpin/mesh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linchpin/mesh/labels{/name}","releases_url":"https://api.github.com/repos/linchpin/mesh/releases{/id}","deployments_url":"https://api.github.com/repos/linchpin/mesh/deployments","created_at":"2016-04-19T01:50:39Z","updated_at":"2017-08-11T12:14:52Z","pushed_at":"2017-08-12T16:38:29Z","git_url":"git://github.com/linchpin/mesh.git","ssh_url":"[email protected]:linchpin/mesh.git","clone_url":"https://github.com/linchpin/mesh.git","svn_url":"https://github.com/linchpin/mesh","homepage":"https://meshplugin.com/","size":6532,"stargazers_count":18,"watchers_count":18,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":48,"forks":8,"open_issues":48,"watchers":18,"default_branch":"develop"}},"base":{"label":"linchpin:develop","ref":"develop","sha":"7a640b6f6347cf9b2ab7772215c8d5032fa26861","user":{"login":"linchpin","id":8070351,"avatar_url":"https://avatars1.githubusercontent.com/u/8070351?v=4","gravatar_id":"","url":"https://api.github.com/users/linchpin","html_url":"https://github.com/linchpin","followers_url":"https://api.github.com/users/linchpin/followers","following_url":"https://api.github.com/users/linchpin/following{/other_user}","gists_url":"https://api.github.com/users/linchpin/gists{/gist_id}","starred_url":"https://api.github.com/users/linchpin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linchpin/subscriptions","organizations_url":"https://api.github.com/users/linchpin/orgs","repos_url":"https://api.github.com/users/linchpin/repos","events_url":"https://api.github.com/users/linchpin/events{/privacy}","received_events_url":"https://api.github.com/users/linchpin/received_events","type":"Organization","site_admin":false},"repo":{"id":56555906,"name":"mesh","full_name":"linchpin/mesh","owner":{"login":"linchpin","id":8070351,"avatar_url":"https://avatars1.githubusercontent.com/u/8070351?v=4","gravatar_id":"","url":"https://api.github.com/users/linchpin","html_url":"https://github.com/linchpin","followers_url":"https://api.github.com/users/linchpin/followers","following_url":"https://api.github.com/users/linchpin/following{/other_user}","gists_url":"https://api.github.com/users/linchpin/gists{/gist_id}","starred_url":"https://api.github.com/users/linchpin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linchpin/subscriptions","organizations_url":"https://api.github.com/users/linchpin/orgs","repos_url":"https://api.github.com/users/linchpin/repos","events_url":"https://api.github.com/users/linchpin/events{/privacy}","received_events_url":"https://api.github.com/users/linchpin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linchpin/mesh","description":"A page builder, simplified. Get the most flexibility to display content by adding multiple content sections within Pages, Posts, or Custom Post Types.","fork":false,"url":"https://api.github.com/repos/linchpin/mesh","forks_url":"https://api.github.com/repos/linchpin/mesh/forks","keys_url":"https://api.github.com/repos/linchpin/mesh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linchpin/mesh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linchpin/mesh/teams","hooks_url":"https://api.github.com/repos/linchpin/mesh/hooks","issue_events_url":"https://api.github.com/repos/linchpin/mesh/issues/events{/number}","events_url":"https://api.github.com/repos/linchpin/mesh/events","assignees_url":"https://api.github.com/repos/linchpin/mesh/assignees{/user}","branches_url":"https://api.github.com/repos/linchpin/mesh/branches{/branch}","tags_url":"https://api.github.com/repos/linchpin/mesh/tags","blobs_url":"https://api.github.com/repos/linchpin/mesh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linchpin/mesh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linchpin/mesh/git/refs{/sha}","trees_url":"https://api.github.com/repos/linchpin/mesh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linchpin/mesh/statuses/{sha}","languages_url":"https://api.github.com/repos/linchpin/mesh/languages","stargazers_url":"https://api.github.com/repos/linchpin/mesh/stargazers","contributors_url":"https://api.github.com/repos/linchpin/mesh/contributors","subscribers_url":"https://api.github.com/repos/linchpin/mesh/subscribers","subscription_url":"https://api.github.com/repos/linchpin/mesh/subscription","commits_url":"https://api.github.com/repos/linchpin/mesh/commits{/sha}","git_commits_url":"https://api.github.com/repos/linchpin/mesh/git/commits{/sha}","comments_url":"https://api.github.com/repos/linchpin/mesh/comments{/number}","issue_comment_url":"https://api.github.com/repos/linchpin/mesh/issues/comments{/number}","contents_url":"https://api.github.com/repos/linchpin/mesh/contents/{+path}","compare_url":"https://api.github.com/repos/linchpin/mesh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linchpin/mesh/merges","archive_url":"https://api.github.com/repos/linchpin/mesh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linchpin/mesh/downloads","issues_url":"https://api.github.com/repos/linchpin/mesh/issues{/number}","pulls_url":"https://api.github.com/repos/linchpin/mesh/pulls{/number}","milestones_url":"https://api.github.com/repos/linchpin/mesh/milestones{/number}","notifications_url":"https://api.github.com/repos/linchpin/mesh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linchpin/mesh/labels{/name}","releases_url":"https://api.github.com/repos/linchpin/mesh/releases{/id}","deployments_url":"https://api.github.com/repos/linchpin/mesh/deployments","created_at":"2016-04-19T01:50:39Z","updated_at":"2017-08-11T12:14:52Z","pushed_at":"2017-08-12T16:38:29Z","git_url":"git://github.com/linchpin/mesh.git","ssh_url":"[email protected]:linchpin/mesh.git","clone_url":"https://github.com/linchpin/mesh.git","svn_url":"https://github.com/linchpin/mesh","homepage":"https://meshplugin.com/","size":6532,"stargazers_count":18,"watchers_count":18,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":48,"forks":8,"open_issues":48,"watchers":18,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/linchpin/mesh/pulls/152"},"html":{"href":"https://github.com/linchpin/mesh/pull/152"},"issue":{"href":"https://api.github.com/repos/linchpin/mesh/issues/152"},"comments":{"href":"https://api.github.com/repos/linchpin/mesh/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/linchpin/mesh/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/linchpin/mesh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linchpin/mesh/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/linchpin/mesh/statuses/0d0eb5838f4650d0827a747e188140127608c052"}}}} | {
"id": 56555906,
"name": "linchpin/mesh",
"url": "https://api.github.com/repos/linchpin/mesh"
} | {
"id": 3216640,
"login": "maxinacube",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3216640?",
"url": "https://api.github.com/users/maxinacube"
} | {
"id": 8070351,
"login": "linchpin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8070351?",
"url": "https://api.github.com/orgs/linchpin"
} | 2017-08-14T16:16:12 | 6449487413 | {"actor":{"display_login":"maxinacube"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/comments/149889201","pull_request_review_id":74501602,"id":149889201,"diff_hunk":"@@ -528,12 +549,42 @@ RouterException getChunkException() {\n * created as part of this poll operation.\n */\n void poll(RequestRegistrationCallback<GetOperation> requestRegistrationCallback) {\n- //First, check if any of the existing requests have timed out.\n- cleanupExpiredInFlightRequests();\n- checkAndMaybeComplete();\n- if (!isComplete()) {\n- fetchRequests(requestRegistrationCallback);\n+ if (!mayBeProcessDecryptCallbackAndCompleteOperation()) {\n+ //First, check if any of the existing requests have timed out.\n+ cleanupExpiredInFlightRequests();\n+ checkAndMaybeComplete();\n+ if (!isComplete() && !onDecryptMode()) {\n+ fetchRequests(requestRegistrationCallback);\n+ }\n+ }\n+ }\n+\n+ /**\n+ * May be process decrypt callback and complete the operation if applicable. This is a no-op for non-encrypted blobs\n+ * @return {@code true} if the operation is complete, {@code false} otherwise\n+ */\n+ boolean mayBeProcessDecryptCallbackAndCompleteOperation() {\n+ if (onDecryptMode() && decryptCallbackResultAvailable) {\n+ logger.trace(\"Processing decrypt callback stored result for data chunk {}\", chunkBlobId);\n+ if (decryptCallbackException == null && (getChunkException() == null || (getChunkException() != null\n+ && !retainChunkExceptionOnSuccess))) {\n+ chunkIndexToBuffer.put(chunkIndex, filterChunkToRange(decryptCallbackResult.getDecryptedBlobContent()));\n+ numChunksRetrieved++;\n+ logger.trace(\"Decrypt result successfully updated for data chunk {}\", chunkBlobId);\n+ } else {\n+ logger.error(\"Setting operation exception as decryption callback invoked with exception {} for data chunk {}\",\n+ decryptCallbackException.getCause(), chunkBlobId);\n+ setOperationException(\n+ new RouterException(\"Exception thrown on decrypting the content for data chunk \" + chunkBlobId,\n+ RouterErrorCode.UnexpectedInternalError));\n+ }\n+ logger.trace(\"Marking blob content available to process for data chunk {}\", chunkBlobId);\n+ blobContentAvailableToProcess = true;\n+ checkAndMaybeComplete();","path":"ambry-router/src/main/java/com.github.ambry.router/GetBlobOperation.java","position":117,"original_position":117,"commit_id":"fa9120c3dbe5379e2266549c1f2beb60fd35ff0c","original_commit_id":"fa9120c3dbe5379e2266549c1f2beb60fd35ff0c","user":{"login":"cgtz","id":3821381,"avatar_url":"https://avatars2.githubusercontent.com/u/3821381?v=4","gravatar_id":"","url":"https://api.github.com/users/cgtz","html_url":"https://github.com/cgtz","followers_url":"https://api.github.com/users/cgtz/followers","following_url":"https://api.github.com/users/cgtz/following{/other_user}","gists_url":"https://api.github.com/users/cgtz/gists{/gist_id}","starred_url":"https://api.github.com/users/cgtz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgtz/subscriptions","organizations_url":"https://api.github.com/users/cgtz/orgs","repos_url":"https://api.github.com/users/cgtz/repos","events_url":"https://api.github.com/users/cgtz/events{/privacy}","received_events_url":"https://api.github.com/users/cgtz/received_events","type":"User","site_admin":false},"body":"I also don't think that this method should complete the operation, because the Chunk-level poll method will take care of that, right?","created_at":"2017-11-09T08:14:05Z","updated_at":"2017-11-09T08:21:23Z","html_url":"https://github.com/linkedin/ambry/pull/801#discussion_r149889201","pull_request_url":"https://api.github.com/repos/linkedin/ambry/pulls/801","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments/149889201"},"html":{"href":"https://github.com/linkedin/ambry/pull/801#discussion_r149889201"},"pull_request":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/801"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/801","id":150590885,"html_url":"https://github.com/linkedin/ambry/pull/801","diff_url":"https://github.com/linkedin/ambry/pull/801.diff","patch_url":"https://github.com/linkedin/ambry/pull/801.patch","issue_url":"https://api.github.com/repos/linkedin/ambry/issues/801","number":801,"state":"open","locked":false,"title":"Adding encryption support to Router","user":{"login":"nsivabalan","id":513218,"avatar_url":"https://avatars2.githubusercontent.com/u/513218?v=4","gravatar_id":"","url":"https://api.github.com/users/nsivabalan","html_url":"https://github.com/nsivabalan","followers_url":"https://api.github.com/users/nsivabalan/followers","following_url":"https://api.github.com/users/nsivabalan/following{/other_user}","gists_url":"https://api.github.com/users/nsivabalan/gists{/gist_id}","starred_url":"https://api.github.com/users/nsivabalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsivabalan/subscriptions","organizations_url":"https://api.github.com/users/nsivabalan/orgs","repos_url":"https://api.github.com/users/nsivabalan/repos","events_url":"https://api.github.com/users/nsivabalan/events{/privacy}","received_events_url":"https://api.github.com/users/nsivabalan/received_events","type":"User","site_admin":false},"body":"This patch adds encryption support to Router. Router relies on isEncrypted() in BlobProperties to determine if the blob needs to be encrypted or not during uploads. If set, both userMetadata and blob content will be encrypted. On Get path, the same will be decrypted before responding. In other words, the stream that comes out of router for a GetRequest will always match the plain content passed in. \r\n\r\nWill update the link to the design doc in sometime.\r\n\r\n```\r\nSince this is a huge patch, I have dissected the patch into smaller modules for ease of review.\r\n\r\nModules in the patch are\r\n1. CryptoJob and associated pieces\r\n - Since we need to encrypt blob content and user-metadata together, have fixed EncryptJob accordingly.\r\n - Since we migth decrypt either of blob content or user-metada or both(depending on GetOptions in the GetRequest), have fixed DecryptJob as well\r\n - Have fixed all tests\r\n2. GetBlobInfoOperation\r\n - Added support for encryption\r\n - Fixed and added tests for the same \r\n3. GetBlobOperation\r\n - Added support for encryption\r\n - Fixed and added tests for the same \r\n4. PutOperation \r\n - Added support for encryption\r\n - Fixed and added tests for the same \r\n5. Common files\r\n - Some of the files apply for most of the cases. But involves minor changes only. So please review these too. \r\n6. Misc\r\n - Some files have been modified to enable new BlobProperties and new Header format. Will be removed once other patch(#800) is merged. \r\n\r\nGuidelines for reviewing. This sections enlists the list of files that needs review for each of the above module.\r\n\r\n1. CryptoJob and associated pieces\r\n\tProd files\r\n\t DecryptJob\r\n\t EncryptJob\r\n\tMinor files (refactoring, wiring, cosmetic changes) \r\n GCMCryptoServiceFactory\r\n SingleKeyManagementServiceFactory\r\n Test files\r\n CryptoJobExecutorServiceTest\r\n SingleKeyManagementServiceTest\r\n\r\n2. GetBlobInfoOperation\r\n Prod files\r\n GetBlobInfoOperation\r\n NonBlockingRouterFactory\r\n Minor files (refactoring, wiring, cosmetic changes) \r\n GetManager\r\n GetOperation\r\n NonBlockingRouter\r\n Test files\r\n MockServer\r\n GetBlobInfoOperationTest\r\n\r\n3. GetBlobOperation\r\n Prod files\r\n GetBlobOperation\r\n NonBlockingRouterFactory\r\n Minor files (refactoring, wiring, cosmetic changes) \r\n GetManager\r\n GetOperation\r\n NonBlockingRouter\r\n Test files\r\n MockServer\r\n GetBlobOperationTest\r\n GetManagerTest \r\n\r\n4. PutOperation\r\n Prod files\r\n PutOperation\r\n NonBlockingRouterFactory\r\n Minor files (refactoring, wiring, cosmetic changes) \r\n PutManager\r\n NonBlockingRouter\r\n Test files\r\n PutManagerTest\r\n\r\n5. Misc files\r\n RouterConfig\r\n RouterFactoryTest\r\n RouterTestHelpers\r\n\r\n6. Do not bother reviewing these files. Will go away once #800 is merged. \r\n BlobPropertiesSerDe\r\n MessageFormatRecord\r\n GetResponse\r\n ReplicaMetadataResponse\r\n MessageFormatRecordTest\r\n\r\nAssigning different modules to different reviewers so as to not flood any single person\r\n\r\n1. CryptoJob and associated pieces: David : 20 mins\r\n2. GetBlobInfoOperation: Gopal and Priyesh : 15 mins\r\n3. GetBlobOperation : Priyesh and Casey : 30 mins\r\n4. PutOperation : Gopal and Casey : 30 mins\r\n5. Everyone : 5 mins\r\n\r\nClarifications\r\n1. Haven't added encryption tests for PutOperation. Most of the the coverage for PutOperation comes via PutManagerTest and hence. And also, manipulating each poll() call in operation may not work well with encryption in the picture. \r\n\r\nPending tasks:\r\n1. Some test classes are yet to be tested with encryption. Enlisting them here. Will add them in the next couple of days\r\n ChunkFillTest\r\n NonBlockingRouterTest\r\n2. Adding metrics to track encryption. \r\n```","created_at":"2017-11-03T17:50:22Z","updated_at":"2017-11-09T08:21:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95b7f250c7ab117a9d6d608574efd997c75aec23","assignee":{"login":"nsivabalan","id":513218,"avatar_url":"https://avatars2.githubusercontent.com/u/513218?v=4","gravatar_id":"","url":"https://api.github.com/users/nsivabalan","html_url":"https://github.com/nsivabalan","followers_url":"https://api.github.com/users/nsivabalan/followers","following_url":"https://api.github.com/users/nsivabalan/following{/other_user}","gists_url":"https://api.github.com/users/nsivabalan/gists{/gist_id}","starred_url":"https://api.github.com/users/nsivabalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsivabalan/subscriptions","organizations_url":"https://api.github.com/users/nsivabalan/orgs","repos_url":"https://api.github.com/users/nsivabalan/repos","events_url":"https://api.github.com/users/nsivabalan/events{/privacy}","received_events_url":"https://api.github.com/users/nsivabalan/received_events","type":"User","site_admin":false},"assignees":[{"login":"nsivabalan","id":513218,"avatar_url":"https://avatars2.githubusercontent.com/u/513218?v=4","gravatar_id":"","url":"https://api.github.com/users/nsivabalan","html_url":"https://github.com/nsivabalan","followers_url":"https://api.github.com/users/nsivabalan/followers","following_url":"https://api.github.com/users/nsivabalan/following{/other_user}","gists_url":"https://api.github.com/users/nsivabalan/gists{/gist_id}","starred_url":"https://api.github.com/users/nsivabalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsivabalan/subscriptions","organizations_url":"https://api.github.com/users/nsivabalan/orgs","repos_url":"https://api.github.com/users/nsivabalan/repos","events_url":"https://api.github.com/users/nsivabalan/events{/privacy}","received_events_url":"https://api.github.com/users/nsivabalan/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dharju","id":31049200,"avatar_url":"https://avatars2.githubusercontent.com/u/31049200?v=4","gravatar_id":"","url":"https://api.github.com/users/dharju","html_url":"https://github.com/dharju","followers_url":"https://api.github.com/users/dharju/followers","following_url":"https://api.github.com/users/dharju/following{/other_user}","gists_url":"https://api.github.com/users/dharju/gists{/gist_id}","starred_url":"https://api.github.com/users/dharju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dharju/subscriptions","organizations_url":"https://api.github.com/users/dharju/orgs","repos_url":"https://api.github.com/users/dharju/repos","events_url":"https://api.github.com/users/dharju/events{/privacy}","received_events_url":"https://api.github.com/users/dharju/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/ambry/pulls/801/commits","review_comments_url":"https://api.github.com/repos/linkedin/ambry/pulls/801/comments","review_comment_url":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/ambry/issues/801/comments","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/fa9120c3dbe5379e2266549c1f2beb60fd35ff0c","head":{"label":"nsivabalan:RouterEncryption","ref":"RouterEncryption","sha":"fa9120c3dbe5379e2266549c1f2beb60fd35ff0c","user":{"login":"nsivabalan","id":513218,"avatar_url":"https://avatars2.githubusercontent.com/u/513218?v=4","gravatar_id":"","url":"https://api.github.com/users/nsivabalan","html_url":"https://github.com/nsivabalan","followers_url":"https://api.github.com/users/nsivabalan/followers","following_url":"https://api.github.com/users/nsivabalan/following{/other_user}","gists_url":"https://api.github.com/users/nsivabalan/gists{/gist_id}","starred_url":"https://api.github.com/users/nsivabalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsivabalan/subscriptions","organizations_url":"https://api.github.com/users/nsivabalan/orgs","repos_url":"https://api.github.com/users/nsivabalan/repos","events_url":"https://api.github.com/users/nsivabalan/events{/privacy}","received_events_url":"https://api.github.com/users/nsivabalan/received_events","type":"User","site_admin":false},"repo":{"id":20119917,"name":"ambry","full_name":"nsivabalan/ambry","owner":{"login":"nsivabalan","id":513218,"avatar_url":"https://avatars2.githubusercontent.com/u/513218?v=4","gravatar_id":"","url":"https://api.github.com/users/nsivabalan","html_url":"https://github.com/nsivabalan","followers_url":"https://api.github.com/users/nsivabalan/followers","following_url":"https://api.github.com/users/nsivabalan/following{/other_user}","gists_url":"https://api.github.com/users/nsivabalan/gists{/gist_id}","starred_url":"https://api.github.com/users/nsivabalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsivabalan/subscriptions","organizations_url":"https://api.github.com/users/nsivabalan/orgs","repos_url":"https://api.github.com/users/nsivabalan/repos","events_url":"https://api.github.com/users/nsivabalan/events{/privacy}","received_events_url":"https://api.github.com/users/nsivabalan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nsivabalan/ambry","description":"Immutable blob store","fork":true,"url":"https://api.github.com/repos/nsivabalan/ambry","forks_url":"https://api.github.com/repos/nsivabalan/ambry/forks","keys_url":"https://api.github.com/repos/nsivabalan/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nsivabalan/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nsivabalan/ambry/teams","hooks_url":"https://api.github.com/repos/nsivabalan/ambry/hooks","issue_events_url":"https://api.github.com/repos/nsivabalan/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/nsivabalan/ambry/events","assignees_url":"https://api.github.com/repos/nsivabalan/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/nsivabalan/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/nsivabalan/ambry/tags","blobs_url":"https://api.github.com/repos/nsivabalan/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nsivabalan/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nsivabalan/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/nsivabalan/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nsivabalan/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/nsivabalan/ambry/languages","stargazers_url":"https://api.github.com/repos/nsivabalan/ambry/stargazers","contributors_url":"https://api.github.com/repos/nsivabalan/ambry/contributors","subscribers_url":"https://api.github.com/repos/nsivabalan/ambry/subscribers","subscription_url":"https://api.github.com/repos/nsivabalan/ambry/subscription","commits_url":"https://api.github.com/repos/nsivabalan/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/nsivabalan/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/nsivabalan/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/nsivabalan/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/nsivabalan/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/nsivabalan/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nsivabalan/ambry/merges","archive_url":"https://api.github.com/repos/nsivabalan/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nsivabalan/ambry/downloads","issues_url":"https://api.github.com/repos/nsivabalan/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/nsivabalan/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/nsivabalan/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/nsivabalan/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nsivabalan/ambry/labels{/name}","releases_url":"https://api.github.com/repos/nsivabalan/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/nsivabalan/ambry/deployments","created_at":"2014-05-24T02:15:09Z","updated_at":"2016-11-06T07:47:22Z","pushed_at":"2017-11-09T04:00:03Z","git_url":"git://github.com/nsivabalan/ambry.git","ssh_url":"[email protected]:nsivabalan/ambry.git","clone_url":"https://github.com/nsivabalan/ambry.git","svn_url":"https://github.com/nsivabalan/ambry","homepage":null,"size":12146,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"9ef1084af0fb67a07a5acacf649c7f8ec48f92dc","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":13870893,"name":"ambry","full_name":"linkedin/ambry","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/ambry","description":"Distributed object store","fork":false,"url":"https://api.github.com/repos/linkedin/ambry","forks_url":"https://api.github.com/repos/linkedin/ambry/forks","keys_url":"https://api.github.com/repos/linkedin/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/ambry/teams","hooks_url":"https://api.github.com/repos/linkedin/ambry/hooks","issue_events_url":"https://api.github.com/repos/linkedin/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/ambry/events","assignees_url":"https://api.github.com/repos/linkedin/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/ambry/tags","blobs_url":"https://api.github.com/repos/linkedin/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/ambry/languages","stargazers_url":"https://api.github.com/repos/linkedin/ambry/stargazers","contributors_url":"https://api.github.com/repos/linkedin/ambry/contributors","subscribers_url":"https://api.github.com/repos/linkedin/ambry/subscribers","subscription_url":"https://api.github.com/repos/linkedin/ambry/subscription","commits_url":"https://api.github.com/repos/linkedin/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/ambry/merges","archive_url":"https://api.github.com/repos/linkedin/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/ambry/downloads","issues_url":"https://api.github.com/repos/linkedin/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/ambry/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/ambry/deployments","created_at":"2013-10-25T20:04:54Z","updated_at":"2017-11-08T18:34:39Z","pushed_at":"2017-11-09T04:00:04Z","git_url":"git://github.com/linkedin/ambry.git","ssh_url":"[email protected]:linkedin/ambry.git","clone_url":"https://github.com/linkedin/ambry.git","svn_url":"https://github.com/linkedin/ambry","homepage":"https://github.com/linkedin/ambry/wiki","size":11222,"stargazers_count":958,"watchers_count":958,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":173,"mirror_url":null,"archived":false,"open_issues_count":74,"forks":173,"open_issues":74,"watchers":958,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/801"},"html":{"href":"https://github.com/linkedin/ambry/pull/801"},"issue":{"href":"https://api.github.com/repos/linkedin/ambry/issues/801"},"comments":{"href":"https://api.github.com/repos/linkedin/ambry/issues/801/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/801/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/801/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/ambry/statuses/fa9120c3dbe5379e2266549c1f2beb60fd35ff0c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 13870893,
"name": "linkedin/ambry",
"url": "https://api.github.com/repos/linkedin/ambry"
} | {
"id": 3821381,
"login": "cgtz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3821381?",
"url": "https://api.github.com/users/cgtz"
} | {
"id": 357098,
"login": "linkedin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/357098?",
"url": "https://api.github.com/orgs/linkedin"
} | 2017-11-09T08:14:05 | 6830745744 | {"actor":{"display_login":"cgtz"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/pinot/pulls/comments/119722272","pull_request_review_id":41629837,"id":119722272,"diff_hunk":"@@ -63,6 +69,16 @@ public SegmentZKMetadata(ZNRecord znRecord) {\n _totalRawDocs = znRecord.getLongField(CommonConstants.Segment.TOTAL_DOCS, -1);\n _crc = znRecord.getLongField(CommonConstants.Segment.CRC, -1);\n _creationTime = znRecord.getLongField(CommonConstants.Segment.CREATION_TIME, -1);\n+\n+ try {\n+ String partitionMetadataJson = znRecord.getSimpleField(CommonConstants.Segment.PARTITION_METADATA);\n+ if (partitionMetadataJson != null) {\n+ _partitionMetadata = SegmentPartitionMetadata.fromJsonString(partitionMetadataJson);\n+ }\n+ } catch (IOException e) {\n+ LOGGER.error(\"Exception caught while reading partition info from segment zk metadata.\", e);","path":"pinot-common/src/main/java/com/linkedin/pinot/common/metadata/segment/SegmentZKMetadata.java","position":47,"original_position":47,"commit_id":"e2bfaa8d497702f7655676bf6341a7253a877e26","original_commit_id":"e2bfaa8d497702f7655676bf6341a7253a877e26","user":{"login":"mcvsubbu","id":2279037,"avatar_url":"https://avatars0.githubusercontent.com/u/2279037?v=3","gravatar_id":"","url":"https://api.github.com/users/mcvsubbu","html_url":"https://github.com/mcvsubbu","followers_url":"https://api.github.com/users/mcvsubbu/followers","following_url":"https://api.github.com/users/mcvsubbu/following{/other_user}","gists_url":"https://api.github.com/users/mcvsubbu/gists{/gist_id}","starred_url":"https://api.github.com/users/mcvsubbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcvsubbu/subscriptions","organizations_url":"https://api.github.com/users/mcvsubbu/orgs","repos_url":"https://api.github.com/users/mcvsubbu/repos","events_url":"https://api.github.com/users/mcvsubbu/events{/privacy}","received_events_url":"https://api.github.com/users/mcvsubbu/received_events","type":"User","site_admin":false},"body":"Log the table name, or segment zk path name where the error happened. \r\n\r\nConsider setting partition data to null? I am sure we have code that brings all segment metadata in a loop (e.g. retention manager). Consider whether we want this one exception to stop processing other segments for this table (or worse, for all tables, giving up altogether, depending on how the caller is coded).","created_at":"2017-06-01T20:37:35Z","updated_at":"2017-06-01T20:45:44Z","html_url":"https://github.com/linkedin/pinot/pull/1505#discussion_r119722272","pull_request_url":"https://api.github.com/repos/linkedin/pinot/pulls/1505","_links":{"self":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/comments/119722272"},"html":{"href":"https://github.com/linkedin/pinot/pull/1505#discussion_r119722272"},"pull_request":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/1505"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/pinot/pulls/1505","id":123382390,"html_url":"https://github.com/linkedin/pinot/pull/1505","diff_url":"https://github.com/linkedin/pinot/pull/1505.diff","patch_url":"https://github.com/linkedin/pinot/pull/1505.patch","issue_url":"https://api.github.com/repos/linkedin/pinot/issues/1505","number":1505,"state":"open","locked":false,"title":"Add partiton metadata into SegmentZkMetadata.","user":{"login":"mayankshriv","id":12615885,"avatar_url":"https://avatars3.githubusercontent.com/u/12615885?v=3","gravatar_id":"","url":"https://api.github.com/users/mayankshriv","html_url":"https://github.com/mayankshriv","followers_url":"https://api.github.com/users/mayankshriv/followers","following_url":"https://api.github.com/users/mayankshriv/following{/other_user}","gists_url":"https://api.github.com/users/mayankshriv/gists{/gist_id}","starred_url":"https://api.github.com/users/mayankshriv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayankshriv/subscriptions","organizations_url":"https://api.github.com/users/mayankshriv/orgs","repos_url":"https://api.github.com/users/mayankshriv/repos","events_url":"https://api.github.com/users/mayankshriv/events{/privacy}","received_events_url":"https://api.github.com/users/mayankshriv/received_events","type":"User","site_admin":false},"body":"1. Added SegmentPartitionMetadata class that contains\nColumnPartitionMetadata for each column that the data is partitioned on.\n\n2. SegmentPartitionMetadata is built from SegmentMetadata and is JSON\nserialzed and stored as a simple filed in the ZnRecord of\nSegmentZkMetadata. The JSON string gets appropriately de-serialized when\nbuilding SegmentZkMetadata from ZnRecord.\n\n3. Added unit test for the new code.","created_at":"2017-05-31T22:21:13Z","updated_at":"2017-06-01T20:45:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"539348694e83cf1eb8c06278704ae2c89b3b15dc","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/pinot/pulls/1505/commits","review_comments_url":"https://api.github.com/repos/linkedin/pinot/pulls/1505/comments","review_comment_url":"https://api.github.com/repos/linkedin/pinot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/pinot/issues/1505/comments","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/e2bfaa8d497702f7655676bf6341a7253a877e26","head":{"label":"linkedin:partition-zkmetadata-pr","ref":"partition-zkmetadata-pr","sha":"e2bfaa8d497702f7655676bf6341a7253a877e26","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars0.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":19961085,"name":"pinot","full_name":"linkedin/pinot","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars0.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/pinot","description":"A realtime distributed OLAP datastore","fork":false,"url":"https://api.github.com/repos/linkedin/pinot","forks_url":"https://api.github.com/repos/linkedin/pinot/forks","keys_url":"https://api.github.com/repos/linkedin/pinot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/pinot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/pinot/teams","hooks_url":"https://api.github.com/repos/linkedin/pinot/hooks","issue_events_url":"https://api.github.com/repos/linkedin/pinot/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/pinot/events","assignees_url":"https://api.github.com/repos/linkedin/pinot/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/pinot/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/pinot/tags","blobs_url":"https://api.github.com/repos/linkedin/pinot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/pinot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/pinot/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/pinot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/pinot/languages","stargazers_url":"https://api.github.com/repos/linkedin/pinot/stargazers","contributors_url":"https://api.github.com/repos/linkedin/pinot/contributors","subscribers_url":"https://api.github.com/repos/linkedin/pinot/subscribers","subscription_url":"https://api.github.com/repos/linkedin/pinot/subscription","commits_url":"https://api.github.com/repos/linkedin/pinot/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/pinot/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/pinot/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/pinot/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/pinot/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/pinot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/pinot/merges","archive_url":"https://api.github.com/repos/linkedin/pinot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/pinot/downloads","issues_url":"https://api.github.com/repos/linkedin/pinot/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/pinot/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/pinot/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/pinot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/pinot/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/pinot/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/pinot/deployments","created_at":"2014-05-19T23:27:48Z","updated_at":"2017-05-30T17:21:37Z","pushed_at":"2017-06-01T19:24:04Z","git_url":"git://github.com/linkedin/pinot.git","ssh_url":"[email protected]:linkedin/pinot.git","clone_url":"https://github.com/linkedin/pinot.git","svn_url":"https://github.com/linkedin/pinot","homepage":"https://github.com/linkedin/pinot/wiki","size":139707,"stargazers_count":1512,"watchers_count":1512,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":264,"mirror_url":null,"open_issues_count":111,"forks":264,"open_issues":111,"watchers":1512,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"7f50830d8e02fba8f020fc8fc546bdd91da46f19","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars0.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":19961085,"name":"pinot","full_name":"linkedin/pinot","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars0.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/pinot","description":"A realtime distributed OLAP datastore","fork":false,"url":"https://api.github.com/repos/linkedin/pinot","forks_url":"https://api.github.com/repos/linkedin/pinot/forks","keys_url":"https://api.github.com/repos/linkedin/pinot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/pinot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/pinot/teams","hooks_url":"https://api.github.com/repos/linkedin/pinot/hooks","issue_events_url":"https://api.github.com/repos/linkedin/pinot/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/pinot/events","assignees_url":"https://api.github.com/repos/linkedin/pinot/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/pinot/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/pinot/tags","blobs_url":"https://api.github.com/repos/linkedin/pinot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/pinot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/pinot/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/pinot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/pinot/languages","stargazers_url":"https://api.github.com/repos/linkedin/pinot/stargazers","contributors_url":"https://api.github.com/repos/linkedin/pinot/contributors","subscribers_url":"https://api.github.com/repos/linkedin/pinot/subscribers","subscription_url":"https://api.github.com/repos/linkedin/pinot/subscription","commits_url":"https://api.github.com/repos/linkedin/pinot/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/pinot/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/pinot/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/pinot/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/pinot/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/pinot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/pinot/merges","archive_url":"https://api.github.com/repos/linkedin/pinot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/pinot/downloads","issues_url":"https://api.github.com/repos/linkedin/pinot/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/pinot/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/pinot/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/pinot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/pinot/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/pinot/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/pinot/deployments","created_at":"2014-05-19T23:27:48Z","updated_at":"2017-05-30T17:21:37Z","pushed_at":"2017-06-01T19:24:04Z","git_url":"git://github.com/linkedin/pinot.git","ssh_url":"[email protected]:linkedin/pinot.git","clone_url":"https://github.com/linkedin/pinot.git","svn_url":"https://github.com/linkedin/pinot","homepage":"https://github.com/linkedin/pinot/wiki","size":139707,"stargazers_count":1512,"watchers_count":1512,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":264,"mirror_url":null,"open_issues_count":111,"forks":264,"open_issues":111,"watchers":1512,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/1505"},"html":{"href":"https://github.com/linkedin/pinot/pull/1505"},"issue":{"href":"https://api.github.com/repos/linkedin/pinot/issues/1505"},"comments":{"href":"https://api.github.com/repos/linkedin/pinot/issues/1505/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/1505/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/1505/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/pinot/statuses/e2bfaa8d497702f7655676bf6341a7253a877e26"}}}} | {
"id": 19961085,
"name": "linkedin/pinot",
"url": "https://api.github.com/repos/linkedin/pinot"
} | {
"id": 2279037,
"login": "mcvsubbu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2279037?",
"url": "https://api.github.com/users/mcvsubbu"
} | {
"id": 357098,
"login": "linkedin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/357098?",
"url": "https://api.github.com/orgs/linkedin"
} | 2017-06-01T20:37:35 | 5986445726 | {"actor":{"display_login":"mcvsubbu"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/pinot/pulls/comments/105962569","pull_request_review_id":26864082,"id":105962569,"diff_hunk":"@@ -225,8 +271,46 @@ public long getOffset() {\n }\n \n public String toJsonString() {\n- return \"{\\\"\" + STATUS_KEY + \"\\\":\" + \"\\\"\" + _status.name() + \"\\\",\" +\n- \"\\\"\" + OFFSET_KEY + \"\\\":\" + _offset + \"}\";\n+ StringBuilder builder = new StringBuilder();\n+ builder.append(\"{\\\"\" + STATUS_KEY + \"\\\":\" + \"\\\"\" + _status.name() + \"\\\",\" + \"\\\"\" + OFFSET_KEY + \"\\\":\" + _offset);\n+ builder.append(\"}\");\n+ return builder.toString();\n+ }\n+\n+ public static class Params {\n+ private static ControllerResponseStatus DEFAULT_RESPONSE_STATUS = ControllerResponseStatus.FAILED;\n+ private static long DEFAULT_RESP_OFFSET = -1L;\n+\n+ ControllerResponseStatus _status;","path":"pinot-common/src/main/java/com/linkedin/pinot/common/protocols/SegmentCompletionProtocol.java","position":179,"original_position":179,"commit_id":"6eaf071dcb15e3e5151fa7b0a05cb1ec239f37e2","original_commit_id":"6eaf071dcb15e3e5151fa7b0a05cb1ec239f37e2","user":{"login":"jfim","id":246807,"avatar_url":"https://avatars1.githubusercontent.com/u/246807?v=3","gravatar_id":"","url":"https://api.github.com/users/jfim","html_url":"https://github.com/jfim","followers_url":"https://api.github.com/users/jfim/followers","following_url":"https://api.github.com/users/jfim/following{/other_user}","gists_url":"https://api.github.com/users/jfim/gists{/gist_id}","starred_url":"https://api.github.com/users/jfim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfim/subscriptions","organizations_url":"https://api.github.com/users/jfim/orgs","repos_url":"https://api.github.com/users/jfim/repos","events_url":"https://api.github.com/users/jfim/events{/privacy}","received_events_url":"https://api.github.com/users/jfim/received_events","type":"User","site_admin":false},"body":"`private`","created_at":"2017-03-14T16:44:14Z","updated_at":"2017-03-14T16:52:23Z","html_url":"https://github.com/linkedin/pinot/pull/1142#discussion_r105962569","pull_request_url":"https://api.github.com/repos/linkedin/pinot/pulls/1142","_links":{"self":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/comments/105962569"},"html":{"href":"https://github.com/linkedin/pinot/pull/1142#discussion_r105962569"},"pull_request":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/1142"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/pinot/pulls/1142","id":110665027,"html_url":"https://github.com/linkedin/pinot/pull/1142","diff_url":"https://github.com/linkedin/pinot/pull/1142.diff","patch_url":"https://github.com/linkedin/pinot/pull/1142.patch","issue_url":"https://api.github.com/repos/linkedin/pinot/issues/1142","number":1142,"state":"open","locked":false,"title":"[PINOT-4603] Re-factor parameter passing in Segment Completion Protocol","user":{"login":"mcvsubbu","id":2279037,"avatar_url":"https://avatars0.githubusercontent.com/u/2279037?v=3","gravatar_id":"","url":"https://api.github.com/users/mcvsubbu","html_url":"https://github.com/mcvsubbu","followers_url":"https://api.github.com/users/mcvsubbu/followers","following_url":"https://api.github.com/users/mcvsubbu/following{/other_user}","gists_url":"https://api.github.com/users/mcvsubbu/gists{/gist_id}","starred_url":"https://api.github.com/users/mcvsubbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcvsubbu/subscriptions","organizations_url":"https://api.github.com/users/mcvsubbu/orgs","repos_url":"https://api.github.com/users/mcvsubbu/repos","events_url":"https://api.github.com/users/mcvsubbu/events{/privacy}","received_events_url":"https://api.github.com/users/mcvsubbu/received_events","type":"User","site_admin":false},"body":"This is the first check-in towards adding a lease-based segment build time.\nChanging the parmeters to be a class makes it easier to add additional parameters\nand features around it","created_at":"2017-03-14T16:40:58Z","updated_at":"2017-03-14T16:52:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45f99b9d86526dcaa60c4d435ae079b2a341abeb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/pinot/pulls/1142/commits","review_comments_url":"https://api.github.com/repos/linkedin/pinot/pulls/1142/comments","review_comment_url":"https://api.github.com/repos/linkedin/pinot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/pinot/issues/1142/comments","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/6eaf071dcb15e3e5151fa7b0a05cb1ec239f37e2","head":{"label":"linkedin:PINOT-4603","ref":"PINOT-4603","sha":"6eaf071dcb15e3e5151fa7b0a05cb1ec239f37e2","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars0.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":19961085,"name":"pinot","full_name":"linkedin/pinot","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars0.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/pinot","description":"A realtime distributed OLAP datastore","fork":false,"url":"https://api.github.com/repos/linkedin/pinot","forks_url":"https://api.github.com/repos/linkedin/pinot/forks","keys_url":"https://api.github.com/repos/linkedin/pinot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/pinot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/pinot/teams","hooks_url":"https://api.github.com/repos/linkedin/pinot/hooks","issue_events_url":"https://api.github.com/repos/linkedin/pinot/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/pinot/events","assignees_url":"https://api.github.com/repos/linkedin/pinot/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/pinot/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/pinot/tags","blobs_url":"https://api.github.com/repos/linkedin/pinot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/pinot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/pinot/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/pinot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/pinot/languages","stargazers_url":"https://api.github.com/repos/linkedin/pinot/stargazers","contributors_url":"https://api.github.com/repos/linkedin/pinot/contributors","subscribers_url":"https://api.github.com/repos/linkedin/pinot/subscribers","subscription_url":"https://api.github.com/repos/linkedin/pinot/subscription","commits_url":"https://api.github.com/repos/linkedin/pinot/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/pinot/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/pinot/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/pinot/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/pinot/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/pinot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/pinot/merges","archive_url":"https://api.github.com/repos/linkedin/pinot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/pinot/downloads","issues_url":"https://api.github.com/repos/linkedin/pinot/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/pinot/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/pinot/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/pinot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/pinot/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/pinot/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/pinot/deployments","created_at":"2014-05-19T23:27:48Z","updated_at":"2017-03-14T08:29:08Z","pushed_at":"2017-03-14T16:40:58Z","git_url":"git://github.com/linkedin/pinot.git","ssh_url":"[email protected]:linkedin/pinot.git","clone_url":"https://github.com/linkedin/pinot.git","svn_url":"https://github.com/linkedin/pinot","homepage":"https://github.com/linkedin/pinot/wiki","size":137244,"stargazers_count":1443,"watchers_count":1443,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":252,"mirror_url":null,"open_issues_count":100,"forks":252,"open_issues":100,"watchers":1443,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"ba64d34c2159a8c2e5f5429a17179a9f57c9c65a","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars0.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":19961085,"name":"pinot","full_name":"linkedin/pinot","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars0.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/pinot","description":"A realtime distributed OLAP datastore","fork":false,"url":"https://api.github.com/repos/linkedin/pinot","forks_url":"https://api.github.com/repos/linkedin/pinot/forks","keys_url":"https://api.github.com/repos/linkedin/pinot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/pinot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/pinot/teams","hooks_url":"https://api.github.com/repos/linkedin/pinot/hooks","issue_events_url":"https://api.github.com/repos/linkedin/pinot/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/pinot/events","assignees_url":"https://api.github.com/repos/linkedin/pinot/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/pinot/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/pinot/tags","blobs_url":"https://api.github.com/repos/linkedin/pinot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/pinot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/pinot/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/pinot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/pinot/languages","stargazers_url":"https://api.github.com/repos/linkedin/pinot/stargazers","contributors_url":"https://api.github.com/repos/linkedin/pinot/contributors","subscribers_url":"https://api.github.com/repos/linkedin/pinot/subscribers","subscription_url":"https://api.github.com/repos/linkedin/pinot/subscription","commits_url":"https://api.github.com/repos/linkedin/pinot/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/pinot/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/pinot/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/pinot/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/pinot/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/pinot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/pinot/merges","archive_url":"https://api.github.com/repos/linkedin/pinot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/pinot/downloads","issues_url":"https://api.github.com/repos/linkedin/pinot/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/pinot/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/pinot/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/pinot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/pinot/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/pinot/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/pinot/deployments","created_at":"2014-05-19T23:27:48Z","updated_at":"2017-03-14T08:29:08Z","pushed_at":"2017-03-14T16:40:58Z","git_url":"git://github.com/linkedin/pinot.git","ssh_url":"[email protected]:linkedin/pinot.git","clone_url":"https://github.com/linkedin/pinot.git","svn_url":"https://github.com/linkedin/pinot","homepage":"https://github.com/linkedin/pinot/wiki","size":137244,"stargazers_count":1443,"watchers_count":1443,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":252,"mirror_url":null,"open_issues_count":100,"forks":252,"open_issues":100,"watchers":1443,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/1142"},"html":{"href":"https://github.com/linkedin/pinot/pull/1142"},"issue":{"href":"https://api.github.com/repos/linkedin/pinot/issues/1142"},"comments":{"href":"https://api.github.com/repos/linkedin/pinot/issues/1142/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/1142/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/1142/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/pinot/statuses/6eaf071dcb15e3e5151fa7b0a05cb1ec239f37e2"}}}} | {
"id": 19961085,
"name": "linkedin/pinot",
"url": "https://api.github.com/repos/linkedin/pinot"
} | {
"id": 246807,
"login": "jfim",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/246807?",
"url": "https://api.github.com/users/jfim"
} | {
"id": 357098,
"login": "linkedin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/357098?",
"url": "https://api.github.com/orgs/linkedin"
} | 2017-03-14T16:44:14 | 5491706075 | {"actor":{"display_login":"jfim"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/102138786","pull_request_review_id":22884334,"id":102138786,"diff_hunk":"@@ -0,0 +1,100 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements. See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership. The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied. See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+package gobblin.converter;\n+\n+import java.nio.ByteBuffer;\n+import java.nio.charset.Charset;\n+import java.util.List;\n+\n+import com.google.common.collect.ImmutableList;\n+import com.google.gson.Gson;\n+import com.google.gson.GsonBuilder;\n+import com.google.gson.JsonElement;\n+\n+import gobblin.configuration.WorkUnitState;\n+import gobblin.type.RecordWithMetadata;\n+import gobblin.type.SerializedRecord;\n+import gobblin.type.SerializedRecordWithMetadata;\n+\n+\n+/**\n+ * Converts multiple source objects to a SerializedRecord object.\n+ */\n+public class AnyToSerializedRecordConverter extends Converter<String, String, Object, SerializedRecord> {\n+\n+ private final static List<String> BINARY_CONTENT_TYPE = ImmutableList.of(\"application/octet-stream\");\n+ private final static List<String> JSON_CONTENT_TYPE = ImmutableList.of(\"application/json\");\n+ private final static Gson GSON = new GsonBuilder().disableHtmlEscaping().create();","path":"gobblin-core-base/src/main/java/gobblin/converter/AnyToSerializedRecordConverter.java","position":43,"original_position":43,"commit_id":"909d22bb6b5d642c3c33e5cd51b47bd63a93d4ad","original_commit_id":"909d22bb6b5d642c3c33e5cd51b47bd63a93d4ad","user":{"login":"eogren","id":5913279,"avatar_url":"https://avatars.githubusercontent.com/u/5913279?v=3","gravatar_id":"","url":"https://api.github.com/users/eogren","html_url":"https://github.com/eogren","followers_url":"https://api.github.com/users/eogren/followers","following_url":"https://api.github.com/users/eogren/following{/other_user}","gists_url":"https://api.github.com/users/eogren/gists{/gist_id}","starred_url":"https://api.github.com/users/eogren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eogren/subscriptions","organizations_url":"https://api.github.com/users/eogren/orgs","repos_url":"https://api.github.com/users/eogren/repos","events_url":"https://api.github.com/users/eogren/events{/privacy}","received_events_url":"https://api.github.com/users/eogren/received_events","type":"User","site_admin":false},"body":"If I didn't disable html encoding, Gson was turning the string \"abc==\" to \"abc\\u003d\\u003d\", so it was wasting a bunch of space. It's possible they all should; it's also possible there should just be one global Gson object across the system. I don't know if there's a way to do that and let you register custom serializers though...","created_at":"2017-02-21T06:22:26Z","updated_at":"2017-02-21T06:22:26Z","html_url":"https://github.com/linkedin/gobblin/pull/1620#discussion_r102138786","pull_request_url":"https://api.github.com/repos/linkedin/gobblin/pulls/1620","_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/102138786"},"html":{"href":"https://github.com/linkedin/gobblin/pull/1620#discussion_r102138786"},"pull_request":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/1620"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/1620","id":105990216,"html_url":"https://github.com/linkedin/gobblin/pull/1620","diff_url":"https://github.com/linkedin/gobblin/pull/1620.diff","patch_url":"https://github.com/linkedin/gobblin/pull/1620.patch","issue_url":"https://api.github.com/repos/linkedin/gobblin/issues/1620","number":1620,"state":"open","locked":false,"title":"RecordWMetadata -> EncryptedRecordWMetadata converter","user":{"login":"eogren","id":5913279,"avatar_url":"https://avatars.githubusercontent.com/u/5913279?v=3","gravatar_id":"","url":"https://api.github.com/users/eogren","html_url":"https://github.com/eogren","followers_url":"https://api.github.com/users/eogren/followers","following_url":"https://api.github.com/users/eogren/following{/other_user}","gists_url":"https://api.github.com/users/eogren/gists{/gist_id}","starred_url":"https://api.github.com/users/eogren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eogren/subscriptions","organizations_url":"https://api.github.com/users/eogren/orgs","repos_url":"https://api.github.com/users/eogren/repos","events_url":"https://api.github.com/users/eogren/events{/privacy}","received_events_url":"https://api.github.com/users/eogren/received_events","type":"User","site_admin":false},"body":"for record by record encryption\r\n\r\nI relaxed the emptyOrNull constraint in ForkOperatorUtils.getPropertyNameForBranch() so I can call getPropertyName(\"\", <branchInfo>) to get the suffix that would be added on to all config parameters for a given branch","created_at":"2017-02-13T22:09:44Z","updated_at":"2017-02-21T06:22:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5abc26268bd1852c9ce082dd600f71b2630854d9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/gobblin/pulls/1620/commits","review_comments_url":"https://api.github.com/repos/linkedin/gobblin/pulls/1620/comments","review_comment_url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/gobblin/issues/1620/comments","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/909d22bb6b5d642c3c33e5cd51b47bd63a93d4ad","head":{"label":"eogren:encrypted_converter","ref":"encrypted_converter","sha":"909d22bb6b5d642c3c33e5cd51b47bd63a93d4ad","user":{"login":"eogren","id":5913279,"avatar_url":"https://avatars.githubusercontent.com/u/5913279?v=3","gravatar_id":"","url":"https://api.github.com/users/eogren","html_url":"https://github.com/eogren","followers_url":"https://api.github.com/users/eogren/followers","following_url":"https://api.github.com/users/eogren/following{/other_user}","gists_url":"https://api.github.com/users/eogren/gists{/gist_id}","starred_url":"https://api.github.com/users/eogren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eogren/subscriptions","organizations_url":"https://api.github.com/users/eogren/orgs","repos_url":"https://api.github.com/users/eogren/repos","events_url":"https://api.github.com/users/eogren/events{/privacy}","received_events_url":"https://api.github.com/users/eogren/received_events","type":"User","site_admin":false},"repo":{"id":80959829,"name":"gobblin","full_name":"eogren/gobblin","owner":{"login":"eogren","id":5913279,"avatar_url":"https://avatars.githubusercontent.com/u/5913279?v=3","gravatar_id":"","url":"https://api.github.com/users/eogren","html_url":"https://github.com/eogren","followers_url":"https://api.github.com/users/eogren/followers","following_url":"https://api.github.com/users/eogren/following{/other_user}","gists_url":"https://api.github.com/users/eogren/gists{/gist_id}","starred_url":"https://api.github.com/users/eogren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eogren/subscriptions","organizations_url":"https://api.github.com/users/eogren/orgs","repos_url":"https://api.github.com/users/eogren/repos","events_url":"https://api.github.com/users/eogren/events{/privacy}","received_events_url":"https://api.github.com/users/eogren/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eogren/gobblin","description":"Gobblin is a distributed big data integration framework (ingestion, replication, compliance, retention) for batch and streaming systems. Gobblin features integrations with Apache Hadoop, Apache Kafka, Salesforce, S3, MySQL, Google etc.","fork":true,"url":"https://api.github.com/repos/eogren/gobblin","forks_url":"https://api.github.com/repos/eogren/gobblin/forks","keys_url":"https://api.github.com/repos/eogren/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eogren/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eogren/gobblin/teams","hooks_url":"https://api.github.com/repos/eogren/gobblin/hooks","issue_events_url":"https://api.github.com/repos/eogren/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/eogren/gobblin/events","assignees_url":"https://api.github.com/repos/eogren/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/eogren/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/eogren/gobblin/tags","blobs_url":"https://api.github.com/repos/eogren/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eogren/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eogren/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/eogren/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eogren/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/eogren/gobblin/languages","stargazers_url":"https://api.github.com/repos/eogren/gobblin/stargazers","contributors_url":"https://api.github.com/repos/eogren/gobblin/contributors","subscribers_url":"https://api.github.com/repos/eogren/gobblin/subscribers","subscription_url":"https://api.github.com/repos/eogren/gobblin/subscription","commits_url":"https://api.github.com/repos/eogren/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/eogren/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/eogren/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/eogren/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/eogren/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/eogren/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eogren/gobblin/merges","archive_url":"https://api.github.com/repos/eogren/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eogren/gobblin/downloads","issues_url":"https://api.github.com/repos/eogren/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/eogren/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/eogren/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/eogren/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eogren/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/eogren/gobblin/releases{/id}","deployments_url":"https://api.github.com/repos/eogren/gobblin/deployments","created_at":"2017-02-05T01:06:53Z","updated_at":"2017-02-05T01:07:01Z","pushed_at":"2017-02-17T23:47:45Z","git_url":"git://github.com/eogren/gobblin.git","ssh_url":"[email protected]:eogren/gobblin.git","clone_url":"https://github.com/eogren/gobblin.git","svn_url":"https://github.com/eogren/gobblin","homepage":"https://github.com/linkedin/gobblin/wiki","size":107682,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"408d7d3b3099dc85d9ab2ddb5c1b5f887c50c4d9","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":27392543,"name":"gobblin","full_name":"linkedin/gobblin","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/gobblin","description":"Gobblin is a distributed big data integration framework (ingestion, replication, compliance, retention) for batch and streaming systems. Gobblin features integrations with Apache Hadoop, Apache Kafka, Salesforce, S3, MySQL, Google etc.","fork":false,"url":"https://api.github.com/repos/linkedin/gobblin","forks_url":"https://api.github.com/repos/linkedin/gobblin/forks","keys_url":"https://api.github.com/repos/linkedin/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/gobblin/teams","hooks_url":"https://api.github.com/repos/linkedin/gobblin/hooks","issue_events_url":"https://api.github.com/repos/linkedin/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/gobblin/events","assignees_url":"https://api.github.com/repos/linkedin/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/gobblin/tags","blobs_url":"https://api.github.com/repos/linkedin/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/gobblin/languages","stargazers_url":"https://api.github.com/repos/linkedin/gobblin/stargazers","contributors_url":"https://api.github.com/repos/linkedin/gobblin/contributors","subscribers_url":"https://api.github.com/repos/linkedin/gobblin/subscribers","subscription_url":"https://api.github.com/repos/linkedin/gobblin/subscription","commits_url":"https://api.github.com/repos/linkedin/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/gobblin/merges","archive_url":"https://api.github.com/repos/linkedin/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/gobblin/downloads","issues_url":"https://api.github.com/repos/linkedin/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/gobblin/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/gobblin/deployments","created_at":"2014-12-01T18:10:50Z","updated_at":"2017-02-19T13:58:44Z","pushed_at":"2017-02-20T08:36:43Z","git_url":"git://github.com/linkedin/gobblin.git","ssh_url":"[email protected]:linkedin/gobblin.git","clone_url":"https://github.com/linkedin/gobblin.git","svn_url":"https://github.com/linkedin/gobblin","homepage":"https://github.com/linkedin/gobblin/wiki","size":107588,"stargazers_count":866,"watchers_count":866,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":357,"mirror_url":null,"open_issues_count":122,"forks":357,"open_issues":122,"watchers":866,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/1620"},"html":{"href":"https://github.com/linkedin/gobblin/pull/1620"},"issue":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/1620"},"comments":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/1620/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/1620/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/1620/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/gobblin/statuses/909d22bb6b5d642c3c33e5cd51b47bd63a93d4ad"}}}} | {
"id": 27392543,
"name": "linkedin/gobblin",
"url": "https://api.github.com/repos/linkedin/gobblin"
} | {
"id": 5913279,
"login": "eogren",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5913279?",
"url": "https://api.github.com/users/eogren"
} | {
"id": 357098,
"login": "linkedin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/357098?",
"url": "https://api.github.com/orgs/linkedin"
} | 2017-02-21T06:22:26 | 5360017817 | {"actor":{"display_login":"eogren"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/comments/147541629","pull_request_review_id":72608739,"id":147541629,"diff_hunk":"@@ -79,122 +84,117 @@ public MessageFormatSend(MessageReadSet readSet, MessageFormatFlags flag, Messag\n sizeWrittenFromCurrentIndex = 0;\n }\n \n- // calculates the offsets from the MessageReadSet that needs to be sent over the network\n- // based on the type of data requested as indicated by the flags\n+ /**\n+ * Calculates the offsets from the MessageReadSet that needs to be sent over the network\n+ * based on the type of data requested as indicated by the flags\n+ */\n private void calculateOffsets() throws IOException, MessageFormatException {\n try {\n // get size\n int messageCount = readSet.count();\n // for each message, determine the offset and size that needs to be sent based on the flag\n- infoList = new ArrayList<SendInfo>(messageCount);\n+ sendInfoList = new ArrayList<>(messageCount);\n+ messageMetadataList = new ArrayList<>(messageCount);\n logger.trace(\"Calculate offsets of messages for one partition, MessageFormatFlag : {} number of messages : {}\",\n flag, messageCount);\n for (int i = 0; i < messageCount; i++) {\n if (flag == MessageFormatFlags.All) {\n // just copy over the total size and use relative offset to be 0\n // We do not have to check any version in this case as we dont\n // have to read any data to deserialize anything.\n- infoList.add(i, new SendInfo(0, readSet.sizeInBytes(i)));\n+ sendInfoList.add(i, new SendInfo(0, readSet.sizeInBytes(i)));\n+ messageMetadataList.add(i, null);\n totalSizeToWrite += readSet.sizeInBytes(i);\n } else {\n // read header version\n long startTime = SystemTime.getInstance().milliseconds();\n- ByteBuffer headerVersion = ByteBuffer.allocate(MessageFormatRecord.Version_Field_Size_In_Bytes);\n+ ByteBuffer headerVersion = ByteBuffer.allocate(Version_Field_Size_In_Bytes);\n readSet.writeTo(i, Channels.newChannel(new ByteBufferOutputStream(headerVersion)), 0,\n- MessageFormatRecord.Version_Field_Size_In_Bytes);\n+ Version_Field_Size_In_Bytes);\n logger.trace(\"Calculate offsets, read header version time: {}\",\n SystemTime.getInstance().milliseconds() - startTime);\n \n headerVersion.flip();\n short version = headerVersion.getShort();\n- switch (version) {\n- case MessageFormatRecord.Message_Header_Version_V1:\n-\n- // read the header\n- startTime = SystemTime.getInstance().milliseconds();\n- ByteBuffer header = ByteBuffer.allocate(MessageFormatRecord.MessageHeader_Format_V1.getHeaderSize());\n- headerVersion.clear();\n- header.putShort(headerVersion.getShort());\n- readSet.writeTo(i, Channels.newChannel(new ByteBufferOutputStream(header)),\n- MessageFormatRecord.Version_Field_Size_In_Bytes,\n- MessageFormatRecord.MessageHeader_Format_V1.getHeaderSize()\n- - MessageFormatRecord.Version_Field_Size_In_Bytes);\n- logger.trace(\"Calculate offsets, read header time: {}\",\n- SystemTime.getInstance().milliseconds() - startTime);\n-\n- startTime = SystemTime.getInstance().milliseconds();\n- header.flip();\n- MessageFormatRecord.MessageHeader_Format_V1 headerFormat =\n- new MessageFormatRecord.MessageHeader_Format_V1(header);\n- headerFormat.verifyHeader();\n- StoreKey storeKey = storeKeyFactory.getStoreKey(\n- new DataInputStream(new MessageReadSetIndexInputStream(readSet, i, header.capacity())));\n- if (storeKey.compareTo(readSet.getKeyAt(i)) != 0) {\n- throw new MessageFormatException(\n- \"Id mismatch between metadata and store - metadataId \" + readSet.getKeyAt(i) + \" storeId \"\n- + storeKey, MessageFormatErrorCodes.Store_Key_Id_MisMatch);\n- }\n- logger.trace(\"Calculate offsets, verify header time: {}\",\n- SystemTime.getInstance().milliseconds() - startTime);\n-\n- startTime = SystemTime.getInstance().milliseconds();\n- if (flag == MessageFormatFlags.BlobProperties) {\n- int blobPropertiesRecordSize = headerFormat.getUserMetadataRecordRelativeOffset()\n- - headerFormat.getBlobPropertiesRecordRelativeOffset();\n+ if (version != Message_Header_Version_V1 && version != Message_Header_Version_V2) {","path":"ambry-messageformat/src/main/java/com.github.ambry.messageformat/MessageFormatSend.java","position":107,"original_position":107,"commit_id":"f74b4ae09942b0760cda490b4b160e6130e08dfa","original_commit_id":"f74b4ae09942b0760cda490b4b160e6130e08dfa","user":{"login":"vgkholla","id":288834,"avatar_url":"https://avatars2.githubusercontent.com/u/288834?v=4","gravatar_id":"","url":"https://api.github.com/users/vgkholla","html_url":"https://github.com/vgkholla","followers_url":"https://api.github.com/users/vgkholla/followers","following_url":"https://api.github.com/users/vgkholla/following{/other_user}","gists_url":"https://api.github.com/users/vgkholla/gists{/gist_id}","starred_url":"https://api.github.com/users/vgkholla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgkholla/subscriptions","organizations_url":"https://api.github.com/users/vgkholla/orgs","repos_url":"https://api.github.com/users/vgkholla/repos","events_url":"https://api.github.com/users/vgkholla/events{/privacy}","received_events_url":"https://api.github.com/users/vgkholla/received_events","type":"User","site_admin":false},"body":"use method in `MessageFormatRecord`","created_at":"2017-10-28T01:03:41Z","updated_at":"2017-10-28T01:35:12Z","html_url":"https://github.com/linkedin/ambry/pull/782#discussion_r147541629","pull_request_url":"https://api.github.com/repos/linkedin/ambry/pulls/782","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments/147541629"},"html":{"href":"https://github.com/linkedin/ambry/pull/782#discussion_r147541629"},"pull_request":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/782"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/782","id":145637254,"html_url":"https://github.com/linkedin/ambry/pull/782","diff_url":"https://github.com/linkedin/ambry/pull/782.diff","patch_url":"https://github.com/linkedin/ambry/pull/782.patch","issue_url":"https://api.github.com/repos/linkedin/ambry/issues/782","number":782,"state":"open","locked":false,"title":"Add Message Format support for encryption","user":{"login":"pnarayanan","id":1454915,"avatar_url":"https://avatars2.githubusercontent.com/u/1454915?v=4","gravatar_id":"","url":"https://api.github.com/users/pnarayanan","html_url":"https://github.com/pnarayanan","followers_url":"https://api.github.com/users/pnarayanan/followers","following_url":"https://api.github.com/users/pnarayanan/following{/other_user}","gists_url":"https://api.github.com/users/pnarayanan/gists{/gist_id}","starred_url":"https://api.github.com/users/pnarayanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnarayanan/subscriptions","organizations_url":"https://api.github.com/users/pnarayanan/orgs","repos_url":"https://api.github.com/users/pnarayanan/repos","events_url":"https://api.github.com/users/pnarayanan/events{/privacy}","received_events_url":"https://api.github.com/users/pnarayanan/received_events","type":"User","site_admin":false},"body":"To support encryption at rest,\r\n- Introduce a new MessageFormat Blob Encryption Key Record.\r\n- Introduce a new version of the MessageFormat Header to support\r\n the new record.\r\n- Introduce a new versioned MessageFormat MessageMetadata associated\r\n with each message that is sent out via MessageFormatSend. The first\r\n version of MessageMetadata will only contain the encryption key.\r\n- Broaden MessageInfoListSerDe to also include MessageMetadata as part\r\n of it (and so rename it to MessageInfoListAndMetadataSerDe). Every\r\n message in PartitionResponseInfo will therefore have a MessageInfo\r\n and an optional MessageMetadata.\r\n- Introduce encryption flag in BlobProperties and add a new version of\r\n BlobPropertiesSerDe to support the new field.\r\n- Add/update tests for coverage of the above changes.\r\n\r\n[This is a gist](https://gist.github.com/pnarayanan/40478d72249f4645f5afbbabd7c4eef5) with additional information about this change.","created_at":"2017-10-10T09:13:16Z","updated_at":"2017-10-28T01:35:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f745a819c35d3213d92813b969380bcfb4277895","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/ambry/pulls/782/commits","review_comments_url":"https://api.github.com/repos/linkedin/ambry/pulls/782/comments","review_comment_url":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/ambry/issues/782/comments","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/f74b4ae09942b0760cda490b4b160e6130e08dfa","head":{"label":"pnarayanan:MsgFmt","ref":"MsgFmt","sha":"f74b4ae09942b0760cda490b4b160e6130e08dfa","user":{"login":"pnarayanan","id":1454915,"avatar_url":"https://avatars2.githubusercontent.com/u/1454915?v=4","gravatar_id":"","url":"https://api.github.com/users/pnarayanan","html_url":"https://github.com/pnarayanan","followers_url":"https://api.github.com/users/pnarayanan/followers","following_url":"https://api.github.com/users/pnarayanan/following{/other_user}","gists_url":"https://api.github.com/users/pnarayanan/gists{/gist_id}","starred_url":"https://api.github.com/users/pnarayanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnarayanan/subscriptions","organizations_url":"https://api.github.com/users/pnarayanan/orgs","repos_url":"https://api.github.com/users/pnarayanan/repos","events_url":"https://api.github.com/users/pnarayanan/events{/privacy}","received_events_url":"https://api.github.com/users/pnarayanan/received_events","type":"User","site_admin":false},"repo":{"id":25383889,"name":"ambry","full_name":"pnarayanan/ambry","owner":{"login":"pnarayanan","id":1454915,"avatar_url":"https://avatars2.githubusercontent.com/u/1454915?v=4","gravatar_id":"","url":"https://api.github.com/users/pnarayanan","html_url":"https://github.com/pnarayanan","followers_url":"https://api.github.com/users/pnarayanan/followers","following_url":"https://api.github.com/users/pnarayanan/following{/other_user}","gists_url":"https://api.github.com/users/pnarayanan/gists{/gist_id}","starred_url":"https://api.github.com/users/pnarayanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnarayanan/subscriptions","organizations_url":"https://api.github.com/users/pnarayanan/orgs","repos_url":"https://api.github.com/users/pnarayanan/repos","events_url":"https://api.github.com/users/pnarayanan/events{/privacy}","received_events_url":"https://api.github.com/users/pnarayanan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pnarayanan/ambry","description":"Immutable blob store","fork":true,"url":"https://api.github.com/repos/pnarayanan/ambry","forks_url":"https://api.github.com/repos/pnarayanan/ambry/forks","keys_url":"https://api.github.com/repos/pnarayanan/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pnarayanan/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pnarayanan/ambry/teams","hooks_url":"https://api.github.com/repos/pnarayanan/ambry/hooks","issue_events_url":"https://api.github.com/repos/pnarayanan/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/pnarayanan/ambry/events","assignees_url":"https://api.github.com/repos/pnarayanan/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/pnarayanan/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/pnarayanan/ambry/tags","blobs_url":"https://api.github.com/repos/pnarayanan/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pnarayanan/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pnarayanan/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/pnarayanan/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pnarayanan/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/pnarayanan/ambry/languages","stargazers_url":"https://api.github.com/repos/pnarayanan/ambry/stargazers","contributors_url":"https://api.github.com/repos/pnarayanan/ambry/contributors","subscribers_url":"https://api.github.com/repos/pnarayanan/ambry/subscribers","subscription_url":"https://api.github.com/repos/pnarayanan/ambry/subscription","commits_url":"https://api.github.com/repos/pnarayanan/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/pnarayanan/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/pnarayanan/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/pnarayanan/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/pnarayanan/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/pnarayanan/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pnarayanan/ambry/merges","archive_url":"https://api.github.com/repos/pnarayanan/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pnarayanan/ambry/downloads","issues_url":"https://api.github.com/repos/pnarayanan/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/pnarayanan/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/pnarayanan/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/pnarayanan/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pnarayanan/ambry/labels{/name}","releases_url":"https://api.github.com/repos/pnarayanan/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/pnarayanan/ambry/deployments","created_at":"2014-10-18T01:44:12Z","updated_at":"2016-11-04T00:08:34Z","pushed_at":"2017-10-26T01:57:48Z","git_url":"git://github.com/pnarayanan/ambry.git","ssh_url":"[email protected]:pnarayanan/ambry.git","clone_url":"https://github.com/pnarayanan/ambry.git","svn_url":"https://github.com/pnarayanan/ambry","homepage":null,"size":11232,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"454967fad6582175ffe75e246dc9180eaa74d1a3","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":13870893,"name":"ambry","full_name":"linkedin/ambry","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/ambry","description":"Distributed object store","fork":false,"url":"https://api.github.com/repos/linkedin/ambry","forks_url":"https://api.github.com/repos/linkedin/ambry/forks","keys_url":"https://api.github.com/repos/linkedin/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/ambry/teams","hooks_url":"https://api.github.com/repos/linkedin/ambry/hooks","issue_events_url":"https://api.github.com/repos/linkedin/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/ambry/events","assignees_url":"https://api.github.com/repos/linkedin/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/ambry/tags","blobs_url":"https://api.github.com/repos/linkedin/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/ambry/languages","stargazers_url":"https://api.github.com/repos/linkedin/ambry/stargazers","contributors_url":"https://api.github.com/repos/linkedin/ambry/contributors","subscribers_url":"https://api.github.com/repos/linkedin/ambry/subscribers","subscription_url":"https://api.github.com/repos/linkedin/ambry/subscription","commits_url":"https://api.github.com/repos/linkedin/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/ambry/merges","archive_url":"https://api.github.com/repos/linkedin/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/ambry/downloads","issues_url":"https://api.github.com/repos/linkedin/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/ambry/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/ambry/deployments","created_at":"2013-10-25T20:04:54Z","updated_at":"2017-10-24T18:24:59Z","pushed_at":"2017-10-26T01:57:50Z","git_url":"git://github.com/linkedin/ambry.git","ssh_url":"[email protected]:linkedin/ambry.git","clone_url":"https://github.com/linkedin/ambry.git","svn_url":"https://github.com/linkedin/ambry","homepage":"https://github.com/linkedin/ambry/wiki","size":11061,"stargazers_count":951,"watchers_count":951,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":173,"mirror_url":null,"archived":false,"open_issues_count":76,"forks":173,"open_issues":76,"watchers":951,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/782"},"html":{"href":"https://github.com/linkedin/ambry/pull/782"},"issue":{"href":"https://api.github.com/repos/linkedin/ambry/issues/782"},"comments":{"href":"https://api.github.com/repos/linkedin/ambry/issues/782/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/782/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/782/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/ambry/statuses/f74b4ae09942b0760cda490b4b160e6130e08dfa"}},"author_association":"CONTRIBUTOR"}} | {
"id": 13870893,
"name": "linkedin/ambry",
"url": "https://api.github.com/repos/linkedin/ambry"
} | {
"id": 288834,
"login": "vgkholla",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/288834?",
"url": "https://api.github.com/users/vgkholla"
} | {
"id": 357098,
"login": "linkedin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/357098?",
"url": "https://api.github.com/orgs/linkedin"
} | 2017-10-28T01:03:41 | 6777828870 | {"actor":{"display_login":"vgkholla"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/metabase/metabase/pulls/comments/143316964","pull_request_review_id":67819256,"id":143316964,"diff_hunk":"@@ -0,0 +1,136 @@\n+# #-#-#-#-# metabase-backend.pot (metabase) #-#-#-#-#\n+# German translations for metabase package.\n+# Copyright (C) 2017 Metabase <[email protected]>\n+# This file is distributed under the same license as the metabase package.\n+# Tom Robinson <[email protected]>, 2017.\n+#\n+msgid \"\"\n+msgstr \"\"\n+\"Project-Id-Version: metabase\\n\"\n+\"Report-Msgid-Bugs-To: [email protected]\\n\"\n+\"POT-Creation-Date: 2017-08-21 21:54+0200\\n\"\n+\"PO-Revision-Date: 2017-08-21 21:17+0200\\n\"\n+\"Last-Translator: Tom Robinson <[email protected]>\\n\"\n+\"Language-Team: German <[email protected]>\\n\"\n+\"Language: de\\n\"\n+\"MIME-Version: 1.0\\n\"\n+\"Content-Type: text/plain; charset=UTF-8\\n\"\n+\"Content-Transfer-Encoding: 8bit\\n\"\n+\"#-#-#-#-# metabase-frontend.pot #-#-#-#-#\\n\"\n+\"Plural-Forms: nplurals=2; plural=(n != 1);\\n\"\n+\"#-#-#-#-# metabase-backend.pot (metabase) #-#-#-#-#\\n\"\n+\n+#: frontend/src/metabase/home/components/Activity.jsx:131\n+msgid \"Hello World!\"\n+msgstr \"Hallo Welt!\"\n+\n+#: frontend/src/metabase/home/components/Activity.jsx:132","path":"locales/de.po","position":27,"original_position":27,"commit_id":"ec539989144ef9d59c07e5ebe0acd12e042e29e5","original_commit_id":"ec539989144ef9d59c07e5ebe0acd12e042e29e5","user":{"login":"senior","id":215910,"avatar_url":"https://avatars3.githubusercontent.com/u/215910?v=4","gravatar_id":"","url":"https://api.github.com/users/senior","html_url":"https://github.com/senior","followers_url":"https://api.github.com/users/senior/followers","following_url":"https://api.github.com/users/senior/following{/other_user}","gists_url":"https://api.github.com/users/senior/gists{/gist_id}","starred_url":"https://api.github.com/users/senior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senior/subscriptions","organizations_url":"https://api.github.com/users/senior/orgs","repos_url":"https://api.github.com/users/senior/repos","events_url":"https://api.github.com/users/senior/events{/privacy}","received_events_url":"https://api.github.com/users/senior/received_events","type":"User","site_admin":false},"body":"That's why in my opinion it's important to get these updates happening out of our normal dev flow. AFAIK having the line numbers is required for the translation software we're using. Any change to a file that changes the line number of a translation, needs to have this updated. Because of that, there's the potential for a lot of churn on this file. Also since it's a separate thing thats needs to be ran, we're pretty likely to forget it.","created_at":"2017-10-07T00:34:07Z","updated_at":"2017-10-07T00:34:07Z","html_url":"https://github.com/metabase/metabase/pull/5803#discussion_r143316964","pull_request_url":"https://api.github.com/repos/metabase/metabase/pulls/5803","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/metabase/metabase/pulls/comments/143316964"},"html":{"href":"https://github.com/metabase/metabase/pull/5803#discussion_r143316964"},"pull_request":{"href":"https://api.github.com/repos/metabase/metabase/pulls/5803"}},"in_reply_to_id":143314764},"pull_request":{"url":"https://api.github.com/repos/metabase/metabase/pulls/5803","id":137268180,"html_url":"https://github.com/metabase/metabase/pull/5803","diff_url":"https://github.com/metabase/metabase/pull/5803.diff","patch_url":"https://github.com/metabase/metabase/pull/5803.patch","issue_url":"https://api.github.com/repos/metabase/metabase/issues/5803","number":5803,"state":"open","locked":false,"title":"Internationalization","user":{"login":"tlrobinson","id":18193,"avatar_url":"https://avatars0.githubusercontent.com/u/18193?v=4","gravatar_id":"","url":"https://api.github.com/users/tlrobinson","html_url":"https://github.com/tlrobinson","followers_url":"https://api.github.com/users/tlrobinson/followers","following_url":"https://api.github.com/users/tlrobinson/following{/other_user}","gists_url":"https://api.github.com/users/tlrobinson/gists{/gist_id}","starred_url":"https://api.github.com/users/tlrobinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlrobinson/subscriptions","organizations_url":"https://api.github.com/users/tlrobinson/orgs","repos_url":"https://api.github.com/users/tlrobinson/repos","events_url":"https://api.github.com/users/tlrobinson/events{/privacy}","received_events_url":"https://api.github.com/users/tlrobinson/received_events","type":"User","site_admin":false},"body":"I've extracted the internationalization work I've done into it's own PR here, and added locale negotiation based on what the user's browser sends in the `Accept-Language` header.\r\n\r\nBasically, here's the workflow:\r\n\r\n1. Tag strings in the frontend using `t` and `jt` ES6 template literals (see more details in https://c-3po.js.org/):\r\n\r\n```javascript\r\nconst someString = t`Hello ${name}!`;\r\nconst someJSX = <div>{ jt`Hello ${name}` }</div>\r\n```\r\n\r\nand in the backend using `trs` and related macros (see more details in https://github.com/puppetlabs/clj-i18n):\r\n\r\n```clojure\r\n(trs \"Hello {0}!\" name)\r\n```\r\n\r\n2. When you have added/edited tagged strings in the code, run `./bin/i18n/update-translations` to update the base `locales/metabase.pot` template and each existing `locales/LOCALE.po`\r\n3. To add a new translaction run `./bin/i18n/update-translation LOCALE`\r\n4. Edit translation in `locales/LOCALE.po`\r\n5. Run `./bin/i18n/build-translation-resources` to compile translations for frontend and backend\r\n6. Restart or rebuild Metabase\r\n\r\nTo try it out, change your browser's language (e.x. chrome://settings/?search=language) to one of the locales to see it working. Run metabase with the `JAVA_TOOL_OPTIONS=-Duser.language=LOCALE` environment variable set to set the locale on the backend, e.x. for pulses and emails (eventually we'll also add a setting in the app)\r\n","created_at":"2017-08-23T16:54:20Z","updated_at":"2017-10-07T00:34:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd121ac40f809d41e85058da7e6af1f2f640372d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/metabase/metabase/pulls/5803/commits","review_comments_url":"https://api.github.com/repos/metabase/metabase/pulls/5803/comments","review_comment_url":"https://api.github.com/repos/metabase/metabase/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metabase/metabase/issues/5803/comments","statuses_url":"https://api.github.com/repos/metabase/metabase/statuses/ec539989144ef9d59c07e5ebe0acd12e042e29e5","head":{"label":"metabase:i18n","ref":"i18n","sha":"ec539989144ef9d59c07e5ebe0acd12e042e29e5","user":{"login":"metabase","id":10520629,"avatar_url":"https://avatars1.githubusercontent.com/u/10520629?v=4","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"repo":{"id":30203935,"name":"metabase","full_name":"metabase/metabase","owner":{"login":"metabase","id":10520629,"avatar_url":"https://avatars1.githubusercontent.com/u/10520629?v=4","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metabase/metabase","description":"The simplest, fastest way to get business intelligence and analytics to everyone in your company :yum:","fork":false,"url":"https://api.github.com/repos/metabase/metabase","forks_url":"https://api.github.com/repos/metabase/metabase/forks","keys_url":"https://api.github.com/repos/metabase/metabase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metabase/metabase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metabase/metabase/teams","hooks_url":"https://api.github.com/repos/metabase/metabase/hooks","issue_events_url":"https://api.github.com/repos/metabase/metabase/issues/events{/number}","events_url":"https://api.github.com/repos/metabase/metabase/events","assignees_url":"https://api.github.com/repos/metabase/metabase/assignees{/user}","branches_url":"https://api.github.com/repos/metabase/metabase/branches{/branch}","tags_url":"https://api.github.com/repos/metabase/metabase/tags","blobs_url":"https://api.github.com/repos/metabase/metabase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metabase/metabase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metabase/metabase/git/refs{/sha}","trees_url":"https://api.github.com/repos/metabase/metabase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metabase/metabase/statuses/{sha}","languages_url":"https://api.github.com/repos/metabase/metabase/languages","stargazers_url":"https://api.github.com/repos/metabase/metabase/stargazers","contributors_url":"https://api.github.com/repos/metabase/metabase/contributors","subscribers_url":"https://api.github.com/repos/metabase/metabase/subscribers","subscription_url":"https://api.github.com/repos/metabase/metabase/subscription","commits_url":"https://api.github.com/repos/metabase/metabase/commits{/sha}","git_commits_url":"https://api.github.com/repos/metabase/metabase/git/commits{/sha}","comments_url":"https://api.github.com/repos/metabase/metabase/comments{/number}","issue_comment_url":"https://api.github.com/repos/metabase/metabase/issues/comments{/number}","contents_url":"https://api.github.com/repos/metabase/metabase/contents/{+path}","compare_url":"https://api.github.com/repos/metabase/metabase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metabase/metabase/merges","archive_url":"https://api.github.com/repos/metabase/metabase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metabase/metabase/downloads","issues_url":"https://api.github.com/repos/metabase/metabase/issues{/number}","pulls_url":"https://api.github.com/repos/metabase/metabase/pulls{/number}","milestones_url":"https://api.github.com/repos/metabase/metabase/milestones{/number}","notifications_url":"https://api.github.com/repos/metabase/metabase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metabase/metabase/labels{/name}","releases_url":"https://api.github.com/repos/metabase/metabase/releases{/id}","deployments_url":"https://api.github.com/repos/metabase/metabase/deployments","created_at":"2015-02-02T19:25:47Z","updated_at":"2017-10-06T22:43:39Z","pushed_at":"2017-10-06T23:41:42Z","git_url":"git://github.com/metabase/metabase.git","ssh_url":"[email protected]:metabase/metabase.git","clone_url":"https://github.com/metabase/metabase.git","svn_url":"https://github.com/metabase/metabase","homepage":"http://metabase.com","size":54445,"stargazers_count":7024,"watchers_count":7024,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":793,"mirror_url":null,"open_issues_count":1250,"forks":793,"open_issues":1250,"watchers":7024,"default_branch":"master"}},"base":{"label":"metabase:master","ref":"master","sha":"8bf09e36947cb2befb333813eea53387e5e1d13f","user":{"login":"metabase","id":10520629,"avatar_url":"https://avatars1.githubusercontent.com/u/10520629?v=4","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"repo":{"id":30203935,"name":"metabase","full_name":"metabase/metabase","owner":{"login":"metabase","id":10520629,"avatar_url":"https://avatars1.githubusercontent.com/u/10520629?v=4","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metabase/metabase","description":"The simplest, fastest way to get business intelligence and analytics to everyone in your company :yum:","fork":false,"url":"https://api.github.com/repos/metabase/metabase","forks_url":"https://api.github.com/repos/metabase/metabase/forks","keys_url":"https://api.github.com/repos/metabase/metabase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metabase/metabase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metabase/metabase/teams","hooks_url":"https://api.github.com/repos/metabase/metabase/hooks","issue_events_url":"https://api.github.com/repos/metabase/metabase/issues/events{/number}","events_url":"https://api.github.com/repos/metabase/metabase/events","assignees_url":"https://api.github.com/repos/metabase/metabase/assignees{/user}","branches_url":"https://api.github.com/repos/metabase/metabase/branches{/branch}","tags_url":"https://api.github.com/repos/metabase/metabase/tags","blobs_url":"https://api.github.com/repos/metabase/metabase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metabase/metabase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metabase/metabase/git/refs{/sha}","trees_url":"https://api.github.com/repos/metabase/metabase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metabase/metabase/statuses/{sha}","languages_url":"https://api.github.com/repos/metabase/metabase/languages","stargazers_url":"https://api.github.com/repos/metabase/metabase/stargazers","contributors_url":"https://api.github.com/repos/metabase/metabase/contributors","subscribers_url":"https://api.github.com/repos/metabase/metabase/subscribers","subscription_url":"https://api.github.com/repos/metabase/metabase/subscription","commits_url":"https://api.github.com/repos/metabase/metabase/commits{/sha}","git_commits_url":"https://api.github.com/repos/metabase/metabase/git/commits{/sha}","comments_url":"https://api.github.com/repos/metabase/metabase/comments{/number}","issue_comment_url":"https://api.github.com/repos/metabase/metabase/issues/comments{/number}","contents_url":"https://api.github.com/repos/metabase/metabase/contents/{+path}","compare_url":"https://api.github.com/repos/metabase/metabase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metabase/metabase/merges","archive_url":"https://api.github.com/repos/metabase/metabase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metabase/metabase/downloads","issues_url":"https://api.github.com/repos/metabase/metabase/issues{/number}","pulls_url":"https://api.github.com/repos/metabase/metabase/pulls{/number}","milestones_url":"https://api.github.com/repos/metabase/metabase/milestones{/number}","notifications_url":"https://api.github.com/repos/metabase/metabase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metabase/metabase/labels{/name}","releases_url":"https://api.github.com/repos/metabase/metabase/releases{/id}","deployments_url":"https://api.github.com/repos/metabase/metabase/deployments","created_at":"2015-02-02T19:25:47Z","updated_at":"2017-10-06T22:43:39Z","pushed_at":"2017-10-06T23:41:42Z","git_url":"git://github.com/metabase/metabase.git","ssh_url":"[email protected]:metabase/metabase.git","clone_url":"https://github.com/metabase/metabase.git","svn_url":"https://github.com/metabase/metabase","homepage":"http://metabase.com","size":54445,"stargazers_count":7024,"watchers_count":7024,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":793,"mirror_url":null,"open_issues_count":1250,"forks":793,"open_issues":1250,"watchers":7024,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metabase/metabase/pulls/5803"},"html":{"href":"https://github.com/metabase/metabase/pull/5803"},"issue":{"href":"https://api.github.com/repos/metabase/metabase/issues/5803"},"comments":{"href":"https://api.github.com/repos/metabase/metabase/issues/5803/comments"},"review_comments":{"href":"https://api.github.com/repos/metabase/metabase/pulls/5803/comments"},"review_comment":{"href":"https://api.github.com/repos/metabase/metabase/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metabase/metabase/pulls/5803/commits"},"statuses":{"href":"https://api.github.com/repos/metabase/metabase/statuses/ec539989144ef9d59c07e5ebe0acd12e042e29e5"}},"author_association":"OWNER"}} | {
"id": 30203935,
"name": "metabase/metabase",
"url": "https://api.github.com/repos/metabase/metabase"
} | {
"id": 215910,
"login": "senior",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/215910?",
"url": "https://api.github.com/users/senior"
} | {
"id": 10520629,
"login": "metabase",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10520629?",
"url": "https://api.github.com/orgs/metabase"
} | 2017-10-07T00:34:07 | 6685761032 | {"actor":{"display_login":"senior"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/odlgroup/odl/pulls/comments/99559569","pull_request_review_id":20238419,"id":99559569,"diff_hunk":"@@ -180,6 +180,48 @@ def pywt_coeff_shapes(shape, wavelet, nlevels, mode):\n return shape_list\n \n \n+def pywt_max_nlevels(shape, wavelet):\n+ \"\"\"Return the maximum nlevels option.\n+\n+ Parameters\n+ ----------\n+ shape : sequence\n+ Shape of an input to the transform.\n+ wavelet : string or `pywt.Wavelet`\n+ Specification of the wavelet to be used in the transform.\n+ If a string is given, it is converted to a `pywt.Wavelet`.\n+ Use `pywt.wavelist` to get a list of available wavelets.\n+\n+ Returns\n+ -------\n+ max_nlevels : int\n+ Maximum value for the nlevels option.\n+\n+ Examples\n+ --------\n+ Find maximum nlevels for Haar wavelet.\n+\n+ >>> pywt_max_nlevels([10], 'haar')\n+ 3\n+ >>> pywt_max_nlevels([1024], 'haar')\n+ 10\n+\n+ For multiple axes, the maximum nlevels is determined by the smallest shape:\n+\n+ >>> pywt_max_nlevels([10, 1024], 'haar')\n+ 3\n+ \"\"\"\n+","path":"odl/trafos/backends/pywt_bindings.py","position":44,"original_position":44,"commit_id":"d8ea0248fabe63cac505724af3a9244831f39928","original_commit_id":"d8ea0248fabe63cac505724af3a9244831f39928","user":{"login":"adler-j","id":2202312,"avatar_url":"https://avatars.githubusercontent.com/u/2202312?v=3","gravatar_id":"","url":"https://api.github.com/users/adler-j","html_url":"https://github.com/adler-j","followers_url":"https://api.github.com/users/adler-j/followers","following_url":"https://api.github.com/users/adler-j/following{/other_user}","gists_url":"https://api.github.com/users/adler-j/gists{/gist_id}","starred_url":"https://api.github.com/users/adler-j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adler-j/subscriptions","organizations_url":"https://api.github.com/users/adler-j/orgs","repos_url":"https://api.github.com/users/adler-j/repos","events_url":"https://api.github.com/users/adler-j/events{/privacy}","received_events_url":"https://api.github.com/users/adler-j/received_events","type":"User","site_admin":false},"body":"Extra line, remove","created_at":"2017-02-06T10:47:44Z","updated_at":"2017-02-06T10:47:44Z","html_url":"https://github.com/odlgroup/odl/pull/880#discussion_r99559569","pull_request_url":"https://api.github.com/repos/odlgroup/odl/pulls/880","_links":{"self":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/comments/99559569"},"html":{"href":"https://github.com/odlgroup/odl/pull/880#discussion_r99559569"},"pull_request":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/880"}}},"pull_request":{"url":"https://api.github.com/repos/odlgroup/odl/pulls/880","id":104774005,"html_url":"https://github.com/odlgroup/odl/pull/880","diff_url":"https://github.com/odlgroup/odl/pull/880.diff","patch_url":"https://github.com/odlgroup/odl/pull/880.patch","issue_url":"https://api.github.com/repos/odlgroup/odl/issues/880","number":880,"state":"open","locked":false,"title":"ENH: add default nlevels to wavelet trafo, closes #866","user":{"login":"adler-j","id":2202312,"avatar_url":"https://avatars.githubusercontent.com/u/2202312?v=3","gravatar_id":"","url":"https://api.github.com/users/adler-j","html_url":"https://github.com/adler-j","followers_url":"https://api.github.com/users/adler-j/followers","following_url":"https://api.github.com/users/adler-j/following{/other_user}","gists_url":"https://api.github.com/users/adler-j/gists{/gist_id}","starred_url":"https://api.github.com/users/adler-j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adler-j/subscriptions","organizations_url":"https://api.github.com/users/adler-j/orgs","repos_url":"https://api.github.com/users/adler-j/repos","events_url":"https://api.github.com/users/adler-j/events{/privacy}","received_events_url":"https://api.github.com/users/adler-j/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-06T10:47:25Z","updated_at":"2017-02-06T10:47:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75e8241a4b4995e50bdb8a7379af7da96f451f77","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/odlgroup/odl/pulls/880/commits","review_comments_url":"https://api.github.com/repos/odlgroup/odl/pulls/880/comments","review_comment_url":"https://api.github.com/repos/odlgroup/odl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odlgroup/odl/issues/880/comments","statuses_url":"https://api.github.com/repos/odlgroup/odl/statuses/d8ea0248fabe63cac505724af3a9244831f39928","head":{"label":"adler-j:issue-866__default_wavelet_nlevels","ref":"issue-866__default_wavelet_nlevels","sha":"d8ea0248fabe63cac505724af3a9244831f39928","user":{"login":"adler-j","id":2202312,"avatar_url":"https://avatars.githubusercontent.com/u/2202312?v=3","gravatar_id":"","url":"https://api.github.com/users/adler-j","html_url":"https://github.com/adler-j","followers_url":"https://api.github.com/users/adler-j/followers","following_url":"https://api.github.com/users/adler-j/following{/other_user}","gists_url":"https://api.github.com/users/adler-j/gists{/gist_id}","starred_url":"https://api.github.com/users/adler-j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adler-j/subscriptions","organizations_url":"https://api.github.com/users/adler-j/orgs","repos_url":"https://api.github.com/users/adler-j/repos","events_url":"https://api.github.com/users/adler-j/events{/privacy}","received_events_url":"https://api.github.com/users/adler-j/received_events","type":"User","site_admin":false},"repo":{"id":79385329,"name":"odl","full_name":"adler-j/odl","owner":{"login":"adler-j","id":2202312,"avatar_url":"https://avatars.githubusercontent.com/u/2202312?v=3","gravatar_id":"","url":"https://api.github.com/users/adler-j","html_url":"https://github.com/adler-j","followers_url":"https://api.github.com/users/adler-j/followers","following_url":"https://api.github.com/users/adler-j/following{/other_user}","gists_url":"https://api.github.com/users/adler-j/gists{/gist_id}","starred_url":"https://api.github.com/users/adler-j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adler-j/subscriptions","organizations_url":"https://api.github.com/users/adler-j/orgs","repos_url":"https://api.github.com/users/adler-j/repos","events_url":"https://api.github.com/users/adler-j/events{/privacy}","received_events_url":"https://api.github.com/users/adler-j/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adler-j/odl","description":"Operator Discretization Library","fork":true,"url":"https://api.github.com/repos/adler-j/odl","forks_url":"https://api.github.com/repos/adler-j/odl/forks","keys_url":"https://api.github.com/repos/adler-j/odl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adler-j/odl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adler-j/odl/teams","hooks_url":"https://api.github.com/repos/adler-j/odl/hooks","issue_events_url":"https://api.github.com/repos/adler-j/odl/issues/events{/number}","events_url":"https://api.github.com/repos/adler-j/odl/events","assignees_url":"https://api.github.com/repos/adler-j/odl/assignees{/user}","branches_url":"https://api.github.com/repos/adler-j/odl/branches{/branch}","tags_url":"https://api.github.com/repos/adler-j/odl/tags","blobs_url":"https://api.github.com/repos/adler-j/odl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adler-j/odl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adler-j/odl/git/refs{/sha}","trees_url":"https://api.github.com/repos/adler-j/odl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adler-j/odl/statuses/{sha}","languages_url":"https://api.github.com/repos/adler-j/odl/languages","stargazers_url":"https://api.github.com/repos/adler-j/odl/stargazers","contributors_url":"https://api.github.com/repos/adler-j/odl/contributors","subscribers_url":"https://api.github.com/repos/adler-j/odl/subscribers","subscription_url":"https://api.github.com/repos/adler-j/odl/subscription","commits_url":"https://api.github.com/repos/adler-j/odl/commits{/sha}","git_commits_url":"https://api.github.com/repos/adler-j/odl/git/commits{/sha}","comments_url":"https://api.github.com/repos/adler-j/odl/comments{/number}","issue_comment_url":"https://api.github.com/repos/adler-j/odl/issues/comments{/number}","contents_url":"https://api.github.com/repos/adler-j/odl/contents/{+path}","compare_url":"https://api.github.com/repos/adler-j/odl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adler-j/odl/merges","archive_url":"https://api.github.com/repos/adler-j/odl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adler-j/odl/downloads","issues_url":"https://api.github.com/repos/adler-j/odl/issues{/number}","pulls_url":"https://api.github.com/repos/adler-j/odl/pulls{/number}","milestones_url":"https://api.github.com/repos/adler-j/odl/milestones{/number}","notifications_url":"https://api.github.com/repos/adler-j/odl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adler-j/odl/labels{/name}","releases_url":"https://api.github.com/repos/adler-j/odl/releases{/id}","deployments_url":"https://api.github.com/repos/adler-j/odl/deployments","created_at":"2017-01-18T21:18:17Z","updated_at":"2017-01-18T21:18:20Z","pushed_at":"2017-02-06T10:47:10Z","git_url":"git://github.com/adler-j/odl.git","ssh_url":"[email protected]:adler-j/odl.git","clone_url":"https://github.com/adler-j/odl.git","svn_url":"https://github.com/adler-j/odl","homepage":null,"size":19354,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"odlgroup:master","ref":"master","sha":"799925d90789548e3277c6fae4caf44c82fb0203","user":{"login":"odlgroup","id":15667171,"avatar_url":"https://avatars.githubusercontent.com/u/15667171?v=3","gravatar_id":"","url":"https://api.github.com/users/odlgroup","html_url":"https://github.com/odlgroup","followers_url":"https://api.github.com/users/odlgroup/followers","following_url":"https://api.github.com/users/odlgroup/following{/other_user}","gists_url":"https://api.github.com/users/odlgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/odlgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odlgroup/subscriptions","organizations_url":"https://api.github.com/users/odlgroup/orgs","repos_url":"https://api.github.com/users/odlgroup/repos","events_url":"https://api.github.com/users/odlgroup/events{/privacy}","received_events_url":"https://api.github.com/users/odlgroup/received_events","type":"Organization","site_admin":false},"repo":{"id":45596393,"name":"odl","full_name":"odlgroup/odl","owner":{"login":"odlgroup","id":15667171,"avatar_url":"https://avatars.githubusercontent.com/u/15667171?v=3","gravatar_id":"","url":"https://api.github.com/users/odlgroup","html_url":"https://github.com/odlgroup","followers_url":"https://api.github.com/users/odlgroup/followers","following_url":"https://api.github.com/users/odlgroup/following{/other_user}","gists_url":"https://api.github.com/users/odlgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/odlgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odlgroup/subscriptions","organizations_url":"https://api.github.com/users/odlgroup/orgs","repos_url":"https://api.github.com/users/odlgroup/repos","events_url":"https://api.github.com/users/odlgroup/events{/privacy}","received_events_url":"https://api.github.com/users/odlgroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odlgroup/odl","description":"Operator Discretization Library","fork":false,"url":"https://api.github.com/repos/odlgroup/odl","forks_url":"https://api.github.com/repos/odlgroup/odl/forks","keys_url":"https://api.github.com/repos/odlgroup/odl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odlgroup/odl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odlgroup/odl/teams","hooks_url":"https://api.github.com/repos/odlgroup/odl/hooks","issue_events_url":"https://api.github.com/repos/odlgroup/odl/issues/events{/number}","events_url":"https://api.github.com/repos/odlgroup/odl/events","assignees_url":"https://api.github.com/repos/odlgroup/odl/assignees{/user}","branches_url":"https://api.github.com/repos/odlgroup/odl/branches{/branch}","tags_url":"https://api.github.com/repos/odlgroup/odl/tags","blobs_url":"https://api.github.com/repos/odlgroup/odl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odlgroup/odl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odlgroup/odl/git/refs{/sha}","trees_url":"https://api.github.com/repos/odlgroup/odl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odlgroup/odl/statuses/{sha}","languages_url":"https://api.github.com/repos/odlgroup/odl/languages","stargazers_url":"https://api.github.com/repos/odlgroup/odl/stargazers","contributors_url":"https://api.github.com/repos/odlgroup/odl/contributors","subscribers_url":"https://api.github.com/repos/odlgroup/odl/subscribers","subscription_url":"https://api.github.com/repos/odlgroup/odl/subscription","commits_url":"https://api.github.com/repos/odlgroup/odl/commits{/sha}","git_commits_url":"https://api.github.com/repos/odlgroup/odl/git/commits{/sha}","comments_url":"https://api.github.com/repos/odlgroup/odl/comments{/number}","issue_comment_url":"https://api.github.com/repos/odlgroup/odl/issues/comments{/number}","contents_url":"https://api.github.com/repos/odlgroup/odl/contents/{+path}","compare_url":"https://api.github.com/repos/odlgroup/odl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odlgroup/odl/merges","archive_url":"https://api.github.com/repos/odlgroup/odl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odlgroup/odl/downloads","issues_url":"https://api.github.com/repos/odlgroup/odl/issues{/number}","pulls_url":"https://api.github.com/repos/odlgroup/odl/pulls{/number}","milestones_url":"https://api.github.com/repos/odlgroup/odl/milestones{/number}","notifications_url":"https://api.github.com/repos/odlgroup/odl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odlgroup/odl/labels{/name}","releases_url":"https://api.github.com/repos/odlgroup/odl/releases{/id}","deployments_url":"https://api.github.com/repos/odlgroup/odl/deployments","created_at":"2015-11-05T07:57:55Z","updated_at":"2016-12-22T17:15:26Z","pushed_at":"2017-02-06T10:47:26Z","git_url":"git://github.com/odlgroup/odl.git","ssh_url":"[email protected]:odlgroup/odl.git","clone_url":"https://github.com/odlgroup/odl.git","svn_url":"https://github.com/odlgroup/odl","homepage":null,"size":74425,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":166,"forks":10,"open_issues":166,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/880"},"html":{"href":"https://github.com/odlgroup/odl/pull/880"},"issue":{"href":"https://api.github.com/repos/odlgroup/odl/issues/880"},"comments":{"href":"https://api.github.com/repos/odlgroup/odl/issues/880/comments"},"review_comments":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/880/comments"},"review_comment":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odlgroup/odl/pulls/880/commits"},"statuses":{"href":"https://api.github.com/repos/odlgroup/odl/statuses/d8ea0248fabe63cac505724af3a9244831f39928"}}}} | {
"id": 45596393,
"name": "odlgroup/odl",
"url": "https://api.github.com/repos/odlgroup/odl"
} | {
"id": 2202312,
"login": "adler-j",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2202312?",
"url": "https://api.github.com/users/adler-j"
} | {
"id": 15667171,
"login": "odlgroup",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15667171?",
"url": "https://api.github.com/orgs/odlgroup"
} | 2017-02-06T10:47:44 | 5271798915 | {"actor":{"display_login":"adler-j"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/openSUSE/osem/pulls/comments/136309893","pull_request_review_id":59828536,"id":136309893,"diff_hunk":"@@ -2,7 +2,7 @@\n - if @program.event_types.any?\n You can submit proposals for\n = \"#{event_types(@conference)}.\"\n- - if @program.tracks.any?\n+ - if @program.tracks.confirmed.cfp_active.first","path":"app/views/proposals/_encouragement_text.html.haml","position":5,"original_position":5,"commit_id":"b216da0ff35422a42d01bcb4d669765640dfd323","original_commit_id":"b216da0ff35422a42d01bcb4d669765640dfd323","user":{"login":"namangupta01","id":20709985,"avatar_url":"https://avatars3.githubusercontent.com/u/20709985?v=4","gravatar_id":"","url":"https://api.github.com/users/namangupta01","html_url":"https://github.com/namangupta01","followers_url":"https://api.github.com/users/namangupta01/followers","following_url":"https://api.github.com/users/namangupta01/following{/other_user}","gists_url":"https://api.github.com/users/namangupta01/gists{/gist_id}","starred_url":"https://api.github.com/users/namangupta01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namangupta01/subscriptions","organizations_url":"https://api.github.com/users/namangupta01/orgs","repos_url":"https://api.github.com/users/namangupta01/repos","events_url":"https://api.github.com/users/namangupta01/events{/privacy}","received_events_url":"https://api.github.com/users/namangupta01/received_events","type":"User","site_admin":false},"body":"@differentreality Yes, its better!","created_at":"2017-08-31T11:26:57Z","updated_at":"2017-08-31T11:26:57Z","html_url":"https://github.com/openSUSE/osem/pull/1670#discussion_r136309893","pull_request_url":"https://api.github.com/repos/openSUSE/osem/pulls/1670","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/comments/136309893"},"html":{"href":"https://github.com/openSUSE/osem/pull/1670#discussion_r136309893"},"pull_request":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/1670"}},"in_reply_to_id":136279499},"pull_request":{"url":"https://api.github.com/repos/openSUSE/osem/pulls/1670","id":138605609,"html_url":"https://github.com/openSUSE/osem/pull/1670","diff_url":"https://github.com/openSUSE/osem/pull/1670.diff","patch_url":"https://github.com/openSUSE/osem/pull/1670.patch","issue_url":"https://api.github.com/repos/openSUSE/osem/issues/1670","number":1670,"state":"open","locked":false,"title":"Showing of tracks when there are no tracks in proposals is fixed","user":{"login":"namangupta01","id":20709985,"avatar_url":"https://avatars3.githubusercontent.com/u/20709985?v=4","gravatar_id":"","url":"https://api.github.com/users/namangupta01","html_url":"https://github.com/namangupta01","followers_url":"https://api.github.com/users/namangupta01/followers","following_url":"https://api.github.com/users/namangupta01/following{/other_user}","gists_url":"https://api.github.com/users/namangupta01/gists{/gist_id}","starred_url":"https://api.github.com/users/namangupta01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namangupta01/subscriptions","organizations_url":"https://api.github.com/users/namangupta01/orgs","repos_url":"https://api.github.com/users/namangupta01/repos","events_url":"https://api.github.com/users/namangupta01/events{/privacy}","received_events_url":"https://api.github.com/users/namangupta01/received_events","type":"User","site_admin":false},"body":"#1668 ","created_at":"2017-08-31T08:15:58Z","updated_at":"2017-08-31T11:26:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01e54345811730286664c55d0b1c5b2469353e48","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openSUSE/osem/pulls/1670/commits","review_comments_url":"https://api.github.com/repos/openSUSE/osem/pulls/1670/comments","review_comment_url":"https://api.github.com/repos/openSUSE/osem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openSUSE/osem/issues/1670/comments","statuses_url":"https://api.github.com/repos/openSUSE/osem/statuses/b216da0ff35422a42d01bcb4d669765640dfd323","head":{"label":"namangupta01:tracks_in_proposals","ref":"tracks_in_proposals","sha":"b216da0ff35422a42d01bcb4d669765640dfd323","user":{"login":"namangupta01","id":20709985,"avatar_url":"https://avatars3.githubusercontent.com/u/20709985?v=4","gravatar_id":"","url":"https://api.github.com/users/namangupta01","html_url":"https://github.com/namangupta01","followers_url":"https://api.github.com/users/namangupta01/followers","following_url":"https://api.github.com/users/namangupta01/following{/other_user}","gists_url":"https://api.github.com/users/namangupta01/gists{/gist_id}","starred_url":"https://api.github.com/users/namangupta01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namangupta01/subscriptions","organizations_url":"https://api.github.com/users/namangupta01/orgs","repos_url":"https://api.github.com/users/namangupta01/repos","events_url":"https://api.github.com/users/namangupta01/events{/privacy}","received_events_url":"https://api.github.com/users/namangupta01/received_events","type":"User","site_admin":false},"repo":{"id":99269676,"name":"osem","full_name":"namangupta01/osem","owner":{"login":"namangupta01","id":20709985,"avatar_url":"https://avatars3.githubusercontent.com/u/20709985?v=4","gravatar_id":"","url":"https://api.github.com/users/namangupta01","html_url":"https://github.com/namangupta01","followers_url":"https://api.github.com/users/namangupta01/followers","following_url":"https://api.github.com/users/namangupta01/following{/other_user}","gists_url":"https://api.github.com/users/namangupta01/gists{/gist_id}","starred_url":"https://api.github.com/users/namangupta01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namangupta01/subscriptions","organizations_url":"https://api.github.com/users/namangupta01/orgs","repos_url":"https://api.github.com/users/namangupta01/repos","events_url":"https://api.github.com/users/namangupta01/events{/privacy}","received_events_url":"https://api.github.com/users/namangupta01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/namangupta01/osem","description":"Open Source Event Manager. An event management tool tailored to Free and Open Source Software conferences.","fork":true,"url":"https://api.github.com/repos/namangupta01/osem","forks_url":"https://api.github.com/repos/namangupta01/osem/forks","keys_url":"https://api.github.com/repos/namangupta01/osem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/namangupta01/osem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/namangupta01/osem/teams","hooks_url":"https://api.github.com/repos/namangupta01/osem/hooks","issue_events_url":"https://api.github.com/repos/namangupta01/osem/issues/events{/number}","events_url":"https://api.github.com/repos/namangupta01/osem/events","assignees_url":"https://api.github.com/repos/namangupta01/osem/assignees{/user}","branches_url":"https://api.github.com/repos/namangupta01/osem/branches{/branch}","tags_url":"https://api.github.com/repos/namangupta01/osem/tags","blobs_url":"https://api.github.com/repos/namangupta01/osem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/namangupta01/osem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/namangupta01/osem/git/refs{/sha}","trees_url":"https://api.github.com/repos/namangupta01/osem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/namangupta01/osem/statuses/{sha}","languages_url":"https://api.github.com/repos/namangupta01/osem/languages","stargazers_url":"https://api.github.com/repos/namangupta01/osem/stargazers","contributors_url":"https://api.github.com/repos/namangupta01/osem/contributors","subscribers_url":"https://api.github.com/repos/namangupta01/osem/subscribers","subscription_url":"https://api.github.com/repos/namangupta01/osem/subscription","commits_url":"https://api.github.com/repos/namangupta01/osem/commits{/sha}","git_commits_url":"https://api.github.com/repos/namangupta01/osem/git/commits{/sha}","comments_url":"https://api.github.com/repos/namangupta01/osem/comments{/number}","issue_comment_url":"https://api.github.com/repos/namangupta01/osem/issues/comments{/number}","contents_url":"https://api.github.com/repos/namangupta01/osem/contents/{+path}","compare_url":"https://api.github.com/repos/namangupta01/osem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/namangupta01/osem/merges","archive_url":"https://api.github.com/repos/namangupta01/osem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/namangupta01/osem/downloads","issues_url":"https://api.github.com/repos/namangupta01/osem/issues{/number}","pulls_url":"https://api.github.com/repos/namangupta01/osem/pulls{/number}","milestones_url":"https://api.github.com/repos/namangupta01/osem/milestones{/number}","notifications_url":"https://api.github.com/repos/namangupta01/osem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/namangupta01/osem/labels{/name}","releases_url":"https://api.github.com/repos/namangupta01/osem/releases{/id}","deployments_url":"https://api.github.com/repos/namangupta01/osem/deployments","created_at":"2017-08-03T19:52:54Z","updated_at":"2017-08-03T19:52:57Z","pushed_at":"2017-08-31T08:13:43Z","git_url":"git://github.com/namangupta01/osem.git","ssh_url":"[email protected]:namangupta01/osem.git","clone_url":"https://github.com/namangupta01/osem.git","svn_url":"https://github.com/namangupta01/osem","homepage":"http://osem.io","size":40233,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openSUSE:master","ref":"master","sha":"de1fa448a21eeb7d159312d6658aab6e151ff847","user":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars2.githubusercontent.com/u/623819?v=4","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":5911225,"name":"osem","full_name":"openSUSE/osem","owner":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars2.githubusercontent.com/u/623819?v=4","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openSUSE/osem","description":"Open Source Event Manager. An event management tool tailored to Free and Open Source Software conferences.","fork":false,"url":"https://api.github.com/repos/openSUSE/osem","forks_url":"https://api.github.com/repos/openSUSE/osem/forks","keys_url":"https://api.github.com/repos/openSUSE/osem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openSUSE/osem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openSUSE/osem/teams","hooks_url":"https://api.github.com/repos/openSUSE/osem/hooks","issue_events_url":"https://api.github.com/repos/openSUSE/osem/issues/events{/number}","events_url":"https://api.github.com/repos/openSUSE/osem/events","assignees_url":"https://api.github.com/repos/openSUSE/osem/assignees{/user}","branches_url":"https://api.github.com/repos/openSUSE/osem/branches{/branch}","tags_url":"https://api.github.com/repos/openSUSE/osem/tags","blobs_url":"https://api.github.com/repos/openSUSE/osem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openSUSE/osem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openSUSE/osem/git/refs{/sha}","trees_url":"https://api.github.com/repos/openSUSE/osem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openSUSE/osem/statuses/{sha}","languages_url":"https://api.github.com/repos/openSUSE/osem/languages","stargazers_url":"https://api.github.com/repos/openSUSE/osem/stargazers","contributors_url":"https://api.github.com/repos/openSUSE/osem/contributors","subscribers_url":"https://api.github.com/repos/openSUSE/osem/subscribers","subscription_url":"https://api.github.com/repos/openSUSE/osem/subscription","commits_url":"https://api.github.com/repos/openSUSE/osem/commits{/sha}","git_commits_url":"https://api.github.com/repos/openSUSE/osem/git/commits{/sha}","comments_url":"https://api.github.com/repos/openSUSE/osem/comments{/number}","issue_comment_url":"https://api.github.com/repos/openSUSE/osem/issues/comments{/number}","contents_url":"https://api.github.com/repos/openSUSE/osem/contents/{+path}","compare_url":"https://api.github.com/repos/openSUSE/osem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openSUSE/osem/merges","archive_url":"https://api.github.com/repos/openSUSE/osem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openSUSE/osem/downloads","issues_url":"https://api.github.com/repos/openSUSE/osem/issues{/number}","pulls_url":"https://api.github.com/repos/openSUSE/osem/pulls{/number}","milestones_url":"https://api.github.com/repos/openSUSE/osem/milestones{/number}","notifications_url":"https://api.github.com/repos/openSUSE/osem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openSUSE/osem/labels{/name}","releases_url":"https://api.github.com/repos/openSUSE/osem/releases{/id}","deployments_url":"https://api.github.com/repos/openSUSE/osem/deployments","created_at":"2012-09-22T07:40:18Z","updated_at":"2017-08-31T09:49:07Z","pushed_at":"2017-08-31T08:15:59Z","git_url":"git://github.com/openSUSE/osem.git","ssh_url":"[email protected]:openSUSE/osem.git","clone_url":"https://github.com/openSUSE/osem.git","svn_url":"https://github.com/openSUSE/osem","homepage":"http://osem.io","size":40235,"stargazers_count":317,"watchers_count":317,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":252,"mirror_url":null,"open_issues_count":165,"forks":252,"open_issues":165,"watchers":317,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/1670"},"html":{"href":"https://github.com/openSUSE/osem/pull/1670"},"issue":{"href":"https://api.github.com/repos/openSUSE/osem/issues/1670"},"comments":{"href":"https://api.github.com/repos/openSUSE/osem/issues/1670/comments"},"review_comments":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/1670/comments"},"review_comment":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/1670/commits"},"statuses":{"href":"https://api.github.com/repos/openSUSE/osem/statuses/b216da0ff35422a42d01bcb4d669765640dfd323"}},"author_association":"NONE"}} | {
"id": 5911225,
"name": "openSUSE/osem",
"url": "https://api.github.com/repos/openSUSE/osem"
} | {
"id": 20709985,
"login": "namangupta01",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20709985?",
"url": "https://api.github.com/users/namangupta01"
} | {
"id": 623819,
"login": "openSUSE",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/623819?",
"url": "https://api.github.com/orgs/openSUSE"
} | 2017-08-31T11:26:57 | 6534592265 | {"actor":{"display_login":"namangupta01"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/opnsense/plugins/pulls/comments/142072689","pull_request_review_id":66381703,"id":142072689,"diff_hunk":"@@ -111,4 +111,14 @@ LoadPlugin write_graphite\n {% endif %}\n {% endif %}\n \n+{% if helpers.exists('OPNsense.collectd.general.p_openvpn_enable') and OPNsense.collectd.general.p_openvpn_enable == '1' %}\n+<Plugin openvpn>\n+ StatusFile \"{{ OPNsense.collectd.general.p_openvpn_statusfile }}\"","path":"net-mgmt/collectd/src/opnsense/service/templates/OPNsense/Collectd/collectd.conf","position":6,"original_position":6,"commit_id":"0238f6d53a2d4f4ea8330623471a2c7e845b0f55","original_commit_id":"0238f6d53a2d4f4ea8330623471a2c7e845b0f55","user":{"login":"mimugmail","id":20438689,"avatar_url":"https://avatars3.githubusercontent.com/u/20438689?v=4","gravatar_id":"","url":"https://api.github.com/users/mimugmail","html_url":"https://github.com/mimugmail","followers_url":"https://api.github.com/users/mimugmail/followers","following_url":"https://api.github.com/users/mimugmail/following{/other_user}","gists_url":"https://api.github.com/users/mimugmail/gists{/gist_id}","starred_url":"https://api.github.com/users/mimugmail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mimugmail/subscriptions","organizations_url":"https://api.github.com/users/mimugmail/orgs","repos_url":"https://api.github.com/users/mimugmail/repos","events_url":"https://api.github.com/users/mimugmail/events{/privacy}","received_events_url":"https://api.github.com/users/mimugmail/received_events","type":"User","site_admin":false},"body":"If you make required Y in model this is ok without if clause","created_at":"2017-10-02T07:53:40Z","updated_at":"2017-10-02T07:56:21Z","html_url":"https://github.com/opnsense/plugins/pull/303#discussion_r142072689","pull_request_url":"https://api.github.com/repos/opnsense/plugins/pulls/303","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/opnsense/plugins/pulls/comments/142072689"},"html":{"href":"https://github.com/opnsense/plugins/pull/303#discussion_r142072689"},"pull_request":{"href":"https://api.github.com/repos/opnsense/plugins/pulls/303"}}},"pull_request":{"url":"https://api.github.com/repos/opnsense/plugins/pulls/303","id":144083290,"html_url":"https://github.com/opnsense/plugins/pull/303","diff_url":"https://github.com/opnsense/plugins/pull/303.diff","patch_url":"https://github.com/opnsense/plugins/pull/303.patch","issue_url":"https://api.github.com/repos/opnsense/plugins/issues/303","number":303,"state":"open","locked":false,"title":"Add Advanced field (Collectd plugin)","user":{"login":"fprina","id":8728834,"avatar_url":"https://avatars1.githubusercontent.com/u/8728834?v=4","gravatar_id":"","url":"https://api.github.com/users/fprina","html_url":"https://github.com/fprina","followers_url":"https://api.github.com/users/fprina/followers","following_url":"https://api.github.com/users/fprina/following{/other_user}","gists_url":"https://api.github.com/users/fprina/gists{/gist_id}","starred_url":"https://api.github.com/users/fprina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fprina/subscriptions","organizations_url":"https://api.github.com/users/fprina/orgs","repos_url":"https://api.github.com/users/fprina/repos","events_url":"https://api.github.com/users/fprina/events{/privacy}","received_events_url":"https://api.github.com/users/fprina/received_events","type":"User","site_admin":false},"body":"* Add Advanced field\r\n Needed to append generic configurations to collecd.conf\r\n\r\n* bump version","created_at":"2017-10-01T18:57:03Z","updated_at":"2017-10-02T07:56:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5aeb6b1ff6bf69779f8d72aaa8df9c95c488fb2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/opnsense/plugins/pulls/303/commits","review_comments_url":"https://api.github.com/repos/opnsense/plugins/pulls/303/comments","review_comment_url":"https://api.github.com/repos/opnsense/plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opnsense/plugins/issues/303/comments","statuses_url":"https://api.github.com/repos/opnsense/plugins/statuses/0238f6d53a2d4f4ea8330623471a2c7e845b0f55","head":{"label":"fprina:master","ref":"master","sha":"0238f6d53a2d4f4ea8330623471a2c7e845b0f55","user":{"login":"fprina","id":8728834,"avatar_url":"https://avatars1.githubusercontent.com/u/8728834?v=4","gravatar_id":"","url":"https://api.github.com/users/fprina","html_url":"https://github.com/fprina","followers_url":"https://api.github.com/users/fprina/followers","following_url":"https://api.github.com/users/fprina/following{/other_user}","gists_url":"https://api.github.com/users/fprina/gists{/gist_id}","starred_url":"https://api.github.com/users/fprina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fprina/subscriptions","organizations_url":"https://api.github.com/users/fprina/orgs","repos_url":"https://api.github.com/users/fprina/repos","events_url":"https://api.github.com/users/fprina/events{/privacy}","received_events_url":"https://api.github.com/users/fprina/received_events","type":"User","site_admin":false},"repo":{"id":105465554,"name":"plugins","full_name":"fprina/plugins","owner":{"login":"fprina","id":8728834,"avatar_url":"https://avatars1.githubusercontent.com/u/8728834?v=4","gravatar_id":"","url":"https://api.github.com/users/fprina","html_url":"https://github.com/fprina","followers_url":"https://api.github.com/users/fprina/followers","following_url":"https://api.github.com/users/fprina/following{/other_user}","gists_url":"https://api.github.com/users/fprina/gists{/gist_id}","starred_url":"https://api.github.com/users/fprina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fprina/subscriptions","organizations_url":"https://api.github.com/users/fprina/orgs","repos_url":"https://api.github.com/users/fprina/repos","events_url":"https://api.github.com/users/fprina/events{/privacy}","received_events_url":"https://api.github.com/users/fprina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fprina/plugins","description":"OPNsense plugin collection","fork":true,"url":"https://api.github.com/repos/fprina/plugins","forks_url":"https://api.github.com/repos/fprina/plugins/forks","keys_url":"https://api.github.com/repos/fprina/plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fprina/plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fprina/plugins/teams","hooks_url":"https://api.github.com/repos/fprina/plugins/hooks","issue_events_url":"https://api.github.com/repos/fprina/plugins/issues/events{/number}","events_url":"https://api.github.com/repos/fprina/plugins/events","assignees_url":"https://api.github.com/repos/fprina/plugins/assignees{/user}","branches_url":"https://api.github.com/repos/fprina/plugins/branches{/branch}","tags_url":"https://api.github.com/repos/fprina/plugins/tags","blobs_url":"https://api.github.com/repos/fprina/plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fprina/plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fprina/plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/fprina/plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fprina/plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/fprina/plugins/languages","stargazers_url":"https://api.github.com/repos/fprina/plugins/stargazers","contributors_url":"https://api.github.com/repos/fprina/plugins/contributors","subscribers_url":"https://api.github.com/repos/fprina/plugins/subscribers","subscription_url":"https://api.github.com/repos/fprina/plugins/subscription","commits_url":"https://api.github.com/repos/fprina/plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/fprina/plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/fprina/plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/fprina/plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/fprina/plugins/contents/{+path}","compare_url":"https://api.github.com/repos/fprina/plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fprina/plugins/merges","archive_url":"https://api.github.com/repos/fprina/plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fprina/plugins/downloads","issues_url":"https://api.github.com/repos/fprina/plugins/issues{/number}","pulls_url":"https://api.github.com/repos/fprina/plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/fprina/plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/fprina/plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fprina/plugins/labels{/name}","releases_url":"https://api.github.com/repos/fprina/plugins/releases{/id}","deployments_url":"https://api.github.com/repos/fprina/plugins/deployments","created_at":"2017-10-01T18:50:19Z","updated_at":"2017-10-01T18:50:21Z","pushed_at":"2017-10-02T07:25:07Z","git_url":"git://github.com/fprina/plugins.git","ssh_url":"[email protected]:fprina/plugins.git","clone_url":"https://github.com/fprina/plugins.git","svn_url":"https://github.com/fprina/plugins","homepage":"https://opnsense.org/","size":1450,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opnsense:master","ref":"master","sha":"f10979b82e1f0b47bb11ace3f5281d1fa43337b5","user":{"login":"opnsense","id":9979117,"avatar_url":"https://avatars3.githubusercontent.com/u/9979117?v=4","gravatar_id":"","url":"https://api.github.com/users/opnsense","html_url":"https://github.com/opnsense","followers_url":"https://api.github.com/users/opnsense/followers","following_url":"https://api.github.com/users/opnsense/following{/other_user}","gists_url":"https://api.github.com/users/opnsense/gists{/gist_id}","starred_url":"https://api.github.com/users/opnsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opnsense/subscriptions","organizations_url":"https://api.github.com/users/opnsense/orgs","repos_url":"https://api.github.com/users/opnsense/repos","events_url":"https://api.github.com/users/opnsense/events{/privacy}","received_events_url":"https://api.github.com/users/opnsense/received_events","type":"Organization","site_admin":false},"repo":{"id":38818223,"name":"plugins","full_name":"opnsense/plugins","owner":{"login":"opnsense","id":9979117,"avatar_url":"https://avatars3.githubusercontent.com/u/9979117?v=4","gravatar_id":"","url":"https://api.github.com/users/opnsense","html_url":"https://github.com/opnsense","followers_url":"https://api.github.com/users/opnsense/followers","following_url":"https://api.github.com/users/opnsense/following{/other_user}","gists_url":"https://api.github.com/users/opnsense/gists{/gist_id}","starred_url":"https://api.github.com/users/opnsense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opnsense/subscriptions","organizations_url":"https://api.github.com/users/opnsense/orgs","repos_url":"https://api.github.com/users/opnsense/repos","events_url":"https://api.github.com/users/opnsense/events{/privacy}","received_events_url":"https://api.github.com/users/opnsense/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opnsense/plugins","description":"OPNsense plugin collection","fork":false,"url":"https://api.github.com/repos/opnsense/plugins","forks_url":"https://api.github.com/repos/opnsense/plugins/forks","keys_url":"https://api.github.com/repos/opnsense/plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opnsense/plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opnsense/plugins/teams","hooks_url":"https://api.github.com/repos/opnsense/plugins/hooks","issue_events_url":"https://api.github.com/repos/opnsense/plugins/issues/events{/number}","events_url":"https://api.github.com/repos/opnsense/plugins/events","assignees_url":"https://api.github.com/repos/opnsense/plugins/assignees{/user}","branches_url":"https://api.github.com/repos/opnsense/plugins/branches{/branch}","tags_url":"https://api.github.com/repos/opnsense/plugins/tags","blobs_url":"https://api.github.com/repos/opnsense/plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opnsense/plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opnsense/plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/opnsense/plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opnsense/plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/opnsense/plugins/languages","stargazers_url":"https://api.github.com/repos/opnsense/plugins/stargazers","contributors_url":"https://api.github.com/repos/opnsense/plugins/contributors","subscribers_url":"https://api.github.com/repos/opnsense/plugins/subscribers","subscription_url":"https://api.github.com/repos/opnsense/plugins/subscription","commits_url":"https://api.github.com/repos/opnsense/plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/opnsense/plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/opnsense/plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/opnsense/plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/opnsense/plugins/contents/{+path}","compare_url":"https://api.github.com/repos/opnsense/plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opnsense/plugins/merges","archive_url":"https://api.github.com/repos/opnsense/plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opnsense/plugins/downloads","issues_url":"https://api.github.com/repos/opnsense/plugins/issues{/number}","pulls_url":"https://api.github.com/repos/opnsense/plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/opnsense/plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/opnsense/plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opnsense/plugins/labels{/name}","releases_url":"https://api.github.com/repos/opnsense/plugins/releases{/id}","deployments_url":"https://api.github.com/repos/opnsense/plugins/deployments","created_at":"2015-07-09T12:13:51Z","updated_at":"2017-09-24T13:57:33Z","pushed_at":"2017-10-02T07:25:09Z","git_url":"git://github.com/opnsense/plugins.git","ssh_url":"[email protected]:opnsense/plugins.git","clone_url":"https://github.com/opnsense/plugins.git","svn_url":"https://github.com/opnsense/plugins","homepage":"https://opnsense.org/","size":1444,"stargazers_count":35,"watchers_count":35,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":43,"forks":45,"open_issues":43,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opnsense/plugins/pulls/303"},"html":{"href":"https://github.com/opnsense/plugins/pull/303"},"issue":{"href":"https://api.github.com/repos/opnsense/plugins/issues/303"},"comments":{"href":"https://api.github.com/repos/opnsense/plugins/issues/303/comments"},"review_comments":{"href":"https://api.github.com/repos/opnsense/plugins/pulls/303/comments"},"review_comment":{"href":"https://api.github.com/repos/opnsense/plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opnsense/plugins/pulls/303/commits"},"statuses":{"href":"https://api.github.com/repos/opnsense/plugins/statuses/0238f6d53a2d4f4ea8330623471a2c7e845b0f55"}},"author_association":"NONE"}} | {
"id": 38818223,
"name": "opnsense/plugins",
"url": "https://api.github.com/repos/opnsense/plugins"
} | {
"id": 20438689,
"login": "mimugmail",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20438689?",
"url": "https://api.github.com/users/mimugmail"
} | {
"id": 9979117,
"login": "opnsense",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9979117?",
"url": "https://api.github.com/orgs/opnsense"
} | 2017-10-02T07:53:40 | 6661298564 | {"actor":{"display_login":"mimugmail"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/oscarlab/graphene/pulls/comments/155813322","pull_request_review_id":82043449,"id":155813322,"diff_hunk":"@@ -0,0 +1,1037 @@\n+/*\n+ * graphene-sandbox.c\n+ *\n+ * Copyright (C) 2013-, Chia-Che Tsai, Bhushan Jain and Donald Porter\n+ *\n+ * Manage the graphene information and security policies.\n+ */\n+\n+#include <linux/version.h>\n+#include <linux/slab.h>\n+#include <linux/sched.h>\n+#include <linux/fs.h>\n+#include <linux/file.h>\n+#include <linux/fs_struct.h>\n+#include <linux/fdtable.h>\n+#include <linux/namei.h>\n+#include <linux/dcache.h>\n+#include <linux/mount.h>\n+#include <linux/uaccess.h>\n+#include <linux/socket.h>\n+#include <linux/un.h>\n+#include <linux/net.h>\n+#include <linux/atomic.h>\n+#include <net/sock.h>\n+#include <net/inet_sock.h>\n+#include <net/tcp_states.h>\n+\n+#include \"graphene-sandbox.h\"\n+#include \"util.h\"\n+\n+enum {\n+\tOP_OPEN,\n+\tOP_STAT,\n+\tOP_BIND,\n+\tOP_CONNECT,\n+\tOP_SENDMSG,\n+\tOP_RECVMSG,\n+};\n+\n+static atomic_t sandbox_ids = ATOMIC_INIT(0);\n+\n+static void drop_graphene_info(struct graphene_info *info)\n+{\n+\tstruct graphene_path *p, *n;\n+\n+\tlist_for_each_entry_safe(p, n, &info->gi_paths, list) {\n+\t\t__putname(p->path->name);\n+\t\tkfree(p->path);\n+\t\tkfree(p);\n+\t}\n+\n+\tlist_for_each_entry_safe(p, n, &info->gi_rpaths, list) {\n+\t\t__putname(p->path->name);\n+\t\tkfree(p->path);\n+\t\tkfree(p);\n+\t}\n+\n+\tif (info->gi_loader_name) {\n+\t\t__putname(info->gi_loader_name->name);\n+\t\tkfree(info->gi_loader_name);\n+\t}\n+\n+\tif (info->gi_mcast_sock)\n+\t\tfput(info->gi_mcast_sock);\n+\n+\tkfree(info);\n+}\n+\n+void put_graphene_info(struct graphene_info *info)\n+{\n+\tif (!atomic_dec_return(&info->gi_count))\n+\t\tdrop_graphene_info(info);\n+}\n+\n+static int check_path(struct graphene_path *gp,\n+\t\t const char *path, int len, u32 mask,\n+\t\t int is_recursive)\n+{\n+\tif (unlikely(!gp->path_len)) {\n+\t\tif (path[0] != '/')\n+\t\t\tgoto matched;\n+\t\treturn 0;\n+\t}\n+\n+\tif (gp->path_len == len) {\n+\t\tif (!strncmp(gp->path->name, path, len))\n+\t\t\tgoto matched;\n+\t} else if (is_recursive &&\n+\t\t gp->path_len < len) {\n+\t\tif (!strncmp(gp->path->name, path, gp->path_len) &&\n+\t\t path[gp->path_len] == '/')\n+\t\t\tgoto matched;\n+\t}\n+\n+\treturn 0;\n+\n+matched:\n+\tif (mask & (MAY_READ|MAY_EXEC|MAY_ACCESS)) {\n+\t\tif (!(gp->type & GRAPHENE_FS_READ))\n+\t\t\treturn -EPERM;\n+\t}\n+\n+\tif (mask & (MAY_WRITE|MAY_APPEND)) {\n+\t\tif (!(gp->type & GRAPHENE_FS_WRITE))\n+\t\t\treturn -EPERM;\n+\t}\n+\n+\treturn 1;\n+}\n+\n+static int __common_file_perm(struct graphene_info *gi,\n+\t\t\t const char *path, u32 mask)\n+{\n+\tstruct graphene_path *p;\n+\tint len = strlen(path);\n+\tint rv = 0;\n+\n+\tlist_for_each_entry(p, &gi->gi_paths, list) {\n+\t\trv = check_path(p, path, len, mask, false);\n+\t\tif (rv)\n+\t\t\tgoto out;\n+\t}\n+\n+\tlist_for_each_entry(p, &gi->gi_rpaths, list) {\n+\t\trv = check_path(p, path, len, mask, true);\n+\t\tif (rv)\n+\t\t\tgoto out;\n+\t}\n+\n+\trv = -EPERM;\n+out:\n+\tif (rv >= 0) {\n+\t\trv = 0;\n+#ifdef GRAPHENE_DEBUG\n+\t\tprintk(KERN_INFO \"Graphene: PID %d PATH %s PASSED\\n\",\n+\t\t current->pid, path);\n+#endif\n+\t} else {\n+\t\tprintk(KERN_INFO \"Graphene: PID %d PATH %s DENIED\\n\",\n+\t\t current->pid, path);\n+\t}\n+\treturn rv;\n+}\n+\n+int check_open_path(struct graphene_info *gi, const char *path,\n+\t\t int flags)\n+{\n+\treturn __common_file_perm(gi, path, ACC_MODE(flags));\n+}\n+\n+int check_stat_path(struct graphene_info *gi, const char *path)\n+{\n+\treturn __common_file_perm(gi, path, MAY_ACCESS);\n+}\n+\n+int __unix_perm(struct graphene_info *gi,\n+\t\tstruct sockaddr *address, int addrlen)\n+{\n+\tconst char * sun_path =\n+\t\t((struct sockaddr_un *) address)->sun_path;\n+\n+\tif (!memcmp(sun_path, gi->gi_unix, GRAPHENE_UNIX_PREFIX_SIZE)) {\n+#ifdef GRAPHENE_DEBUG\n+\t\tprintk(KERN_INFO \"Graphene: PID %d UNIX @%s PASSED\\n\",\n+\t\t current->pid, sun_path + 1);\n+#endif\n+\t\treturn 0;\n+\t}\n+\n+\tprintk(KERN_INFO \"Graphene: PID %d UNIX @%s DENIED\\n\",\n+\t current->pid, sun_path + 1);\n+\treturn -EPERM;\n+}\n+\n+static int net_cmp(int family, bool addr_any, bool port_any,\n+\t\t struct graphene_net_addr *ga,\n+\t\t struct sockaddr *addr, int addrlen)","path":"Pal/security/linux/graphene-sandbox.c","position":177,"original_position":177,"commit_id":"60148faea6306302c88c6e433dc774ee700d1eb8","original_commit_id":"60148faea6306302c88c6e433dc774ee700d1eb8","user":{"login":"mkow","id":5244565,"avatar_url":"https://avatars0.githubusercontent.com/u/5244565?v=4","gravatar_id":"","url":"https://api.github.com/users/mkow","html_url":"https://github.com/mkow","followers_url":"https://api.github.com/users/mkow/followers","following_url":"https://api.github.com/users/mkow/following{/other_user}","gists_url":"https://api.github.com/users/mkow/gists{/gist_id}","starred_url":"https://api.github.com/users/mkow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkow/subscriptions","organizations_url":"https://api.github.com/users/mkow/orgs","repos_url":"https://api.github.com/users/mkow/repos","events_url":"https://api.github.com/users/mkow/events{/privacy}","received_events_url":"https://api.github.com/users/mkow/received_events","type":"User","site_admin":false},"body":"`int` -> `size_t`","created_at":"2017-12-08T16:10:45Z","updated_at":"2017-12-08T16:35:46Z","html_url":"https://github.com/oscarlab/graphene/pull/139#discussion_r155813322","pull_request_url":"https://api.github.com/repos/oscarlab/graphene/pulls/139","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/oscarlab/graphene/pulls/comments/155813322"},"html":{"href":"https://github.com/oscarlab/graphene/pull/139#discussion_r155813322"},"pull_request":{"href":"https://api.github.com/repos/oscarlab/graphene/pulls/139"}}},"pull_request":{"url":"https://api.github.com/repos/oscarlab/graphene/pulls/139","id":157049950,"html_url":"https://github.com/oscarlab/graphene/pull/139","diff_url":"https://github.com/oscarlab/graphene/pull/139.diff","patch_url":"https://github.com/oscarlab/graphene/pull/139.patch","issue_url":"https://api.github.com/repos/oscarlab/graphene/issues/139","number":139,"state":"open","locked":false,"title":"Graphene Sandboxing Design and Static Binary Support","user":{"login":"chiache","id":339249,"avatar_url":"https://avatars0.githubusercontent.com/u/339249?v=4","gravatar_id":"","url":"https://api.github.com/users/chiache","html_url":"https://github.com/chiache","followers_url":"https://api.github.com/users/chiache/followers","following_url":"https://api.github.com/users/chiache/following{/other_user}","gists_url":"https://api.github.com/users/chiache/gists{/gist_id}","starred_url":"https://api.github.com/users/chiache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chiache/subscriptions","organizations_url":"https://api.github.com/users/chiache/orgs","repos_url":"https://api.github.com/users/chiache/repos","events_url":"https://api.github.com/users/chiache/events{/privacy}","received_events_url":"https://api.github.com/users/chiache/received_events","type":"User","site_admin":false},"body":"This patch primarily contains three changes:\r\n- Complete rework of the Graphene reference monitor (Linux only) as a kernel module\r\n- Improvement of Secommp filtering. Allowing child processes to inherit PC-related rules by loading PAL at the same address as inside of the parent process. \r\n- Supporting static binaries and system calls from inline assembly code.","created_at":"2017-12-07T17:02:49Z","updated_at":"2017-12-08T16:35:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ba52e219a42b87f484077ea61a16c11d768ede8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"donporter","id":7039633,"avatar_url":"https://avatars2.githubusercontent.com/u/7039633?v=4","gravatar_id":"","url":"https://api.github.com/users/donporter","html_url":"https://github.com/donporter","followers_url":"https://api.github.com/users/donporter/followers","following_url":"https://api.github.com/users/donporter/following{/other_user}","gists_url":"https://api.github.com/users/donporter/gists{/gist_id}","starred_url":"https://api.github.com/users/donporter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donporter/subscriptions","organizations_url":"https://api.github.com/users/donporter/orgs","repos_url":"https://api.github.com/users/donporter/repos","events_url":"https://api.github.com/users/donporter/events{/privacy}","received_events_url":"https://api.github.com/users/donporter/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/oscarlab/graphene/pulls/139/commits","review_comments_url":"https://api.github.com/repos/oscarlab/graphene/pulls/139/comments","review_comment_url":"https://api.github.com/repos/oscarlab/graphene/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oscarlab/graphene/issues/139/comments","statuses_url":"https://api.github.com/repos/oscarlab/graphene/statuses/60148faea6306302c88c6e433dc774ee700d1eb8","head":{"label":"oscarlab:rm-module-merge","ref":"rm-module-merge","sha":"60148faea6306302c88c6e433dc774ee700d1eb8","user":{"login":"oscarlab","id":7105811,"avatar_url":"https://avatars0.githubusercontent.com/u/7105811?v=4","gravatar_id":"","url":"https://api.github.com/users/oscarlab","html_url":"https://github.com/oscarlab","followers_url":"https://api.github.com/users/oscarlab/followers","following_url":"https://api.github.com/users/oscarlab/following{/other_user}","gists_url":"https://api.github.com/users/oscarlab/gists{/gist_id}","starred_url":"https://api.github.com/users/oscarlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscarlab/subscriptions","organizations_url":"https://api.github.com/users/oscarlab/orgs","repos_url":"https://api.github.com/users/oscarlab/repos","events_url":"https://api.github.com/users/oscarlab/events{/privacy}","received_events_url":"https://api.github.com/users/oscarlab/received_events","type":"Organization","site_admin":false},"repo":{"id":18259989,"name":"graphene","full_name":"oscarlab/graphene","owner":{"login":"oscarlab","id":7105811,"avatar_url":"https://avatars0.githubusercontent.com/u/7105811?v=4","gravatar_id":"","url":"https://api.github.com/users/oscarlab","html_url":"https://github.com/oscarlab","followers_url":"https://api.github.com/users/oscarlab/followers","following_url":"https://api.github.com/users/oscarlab/following{/other_user}","gists_url":"https://api.github.com/users/oscarlab/gists{/gist_id}","starred_url":"https://api.github.com/users/oscarlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscarlab/subscriptions","organizations_url":"https://api.github.com/users/oscarlab/orgs","repos_url":"https://api.github.com/users/oscarlab/repos","events_url":"https://api.github.com/users/oscarlab/events{/privacy}","received_events_url":"https://api.github.com/users/oscarlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oscarlab/graphene","description":"Graphene / Graphene-SGX Library OS - a library OS for Linux multi-process applications, with Intel SGX support","fork":false,"url":"https://api.github.com/repos/oscarlab/graphene","forks_url":"https://api.github.com/repos/oscarlab/graphene/forks","keys_url":"https://api.github.com/repos/oscarlab/graphene/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oscarlab/graphene/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oscarlab/graphene/teams","hooks_url":"https://api.github.com/repos/oscarlab/graphene/hooks","issue_events_url":"https://api.github.com/repos/oscarlab/graphene/issues/events{/number}","events_url":"https://api.github.com/repos/oscarlab/graphene/events","assignees_url":"https://api.github.com/repos/oscarlab/graphene/assignees{/user}","branches_url":"https://api.github.com/repos/oscarlab/graphene/branches{/branch}","tags_url":"https://api.github.com/repos/oscarlab/graphene/tags","blobs_url":"https://api.github.com/repos/oscarlab/graphene/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oscarlab/graphene/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oscarlab/graphene/git/refs{/sha}","trees_url":"https://api.github.com/repos/oscarlab/graphene/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oscarlab/graphene/statuses/{sha}","languages_url":"https://api.github.com/repos/oscarlab/graphene/languages","stargazers_url":"https://api.github.com/repos/oscarlab/graphene/stargazers","contributors_url":"https://api.github.com/repos/oscarlab/graphene/contributors","subscribers_url":"https://api.github.com/repos/oscarlab/graphene/subscribers","subscription_url":"https://api.github.com/repos/oscarlab/graphene/subscription","commits_url":"https://api.github.com/repos/oscarlab/graphene/commits{/sha}","git_commits_url":"https://api.github.com/repos/oscarlab/graphene/git/commits{/sha}","comments_url":"https://api.github.com/repos/oscarlab/graphene/comments{/number}","issue_comment_url":"https://api.github.com/repos/oscarlab/graphene/issues/comments{/number}","contents_url":"https://api.github.com/repos/oscarlab/graphene/contents/{+path}","compare_url":"https://api.github.com/repos/oscarlab/graphene/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oscarlab/graphene/merges","archive_url":"https://api.github.com/repos/oscarlab/graphene/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oscarlab/graphene/downloads","issues_url":"https://api.github.com/repos/oscarlab/graphene/issues{/number}","pulls_url":"https://api.github.com/repos/oscarlab/graphene/pulls{/number}","milestones_url":"https://api.github.com/repos/oscarlab/graphene/milestones{/number}","notifications_url":"https://api.github.com/repos/oscarlab/graphene/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oscarlab/graphene/labels{/name}","releases_url":"https://api.github.com/repos/oscarlab/graphene/releases{/id}","deployments_url":"https://api.github.com/repos/oscarlab/graphene/deployments","created_at":"2014-03-30T07:58:58Z","updated_at":"2017-12-08T09:31:20Z","pushed_at":"2017-12-08T15:19:01Z","git_url":"git://github.com/oscarlab/graphene.git","ssh_url":"[email protected]:oscarlab/graphene.git","clone_url":"https://github.com/oscarlab/graphene.git","svn_url":"https://github.com/oscarlab/graphene","homepage":"https://github.com/oscarlab/graphene/wiki","size":383637,"stargazers_count":113,"watchers_count":113,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":48,"open_issues":45,"watchers":113,"default_branch":"master"}},"base":{"label":"oscarlab:master","ref":"master","sha":"62f07c7181755b408f606b170a84a6f25e412c7b","user":{"login":"oscarlab","id":7105811,"avatar_url":"https://avatars0.githubusercontent.com/u/7105811?v=4","gravatar_id":"","url":"https://api.github.com/users/oscarlab","html_url":"https://github.com/oscarlab","followers_url":"https://api.github.com/users/oscarlab/followers","following_url":"https://api.github.com/users/oscarlab/following{/other_user}","gists_url":"https://api.github.com/users/oscarlab/gists{/gist_id}","starred_url":"https://api.github.com/users/oscarlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscarlab/subscriptions","organizations_url":"https://api.github.com/users/oscarlab/orgs","repos_url":"https://api.github.com/users/oscarlab/repos","events_url":"https://api.github.com/users/oscarlab/events{/privacy}","received_events_url":"https://api.github.com/users/oscarlab/received_events","type":"Organization","site_admin":false},"repo":{"id":18259989,"name":"graphene","full_name":"oscarlab/graphene","owner":{"login":"oscarlab","id":7105811,"avatar_url":"https://avatars0.githubusercontent.com/u/7105811?v=4","gravatar_id":"","url":"https://api.github.com/users/oscarlab","html_url":"https://github.com/oscarlab","followers_url":"https://api.github.com/users/oscarlab/followers","following_url":"https://api.github.com/users/oscarlab/following{/other_user}","gists_url":"https://api.github.com/users/oscarlab/gists{/gist_id}","starred_url":"https://api.github.com/users/oscarlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscarlab/subscriptions","organizations_url":"https://api.github.com/users/oscarlab/orgs","repos_url":"https://api.github.com/users/oscarlab/repos","events_url":"https://api.github.com/users/oscarlab/events{/privacy}","received_events_url":"https://api.github.com/users/oscarlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oscarlab/graphene","description":"Graphene / Graphene-SGX Library OS - a library OS for Linux multi-process applications, with Intel SGX support","fork":false,"url":"https://api.github.com/repos/oscarlab/graphene","forks_url":"https://api.github.com/repos/oscarlab/graphene/forks","keys_url":"https://api.github.com/repos/oscarlab/graphene/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oscarlab/graphene/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oscarlab/graphene/teams","hooks_url":"https://api.github.com/repos/oscarlab/graphene/hooks","issue_events_url":"https://api.github.com/repos/oscarlab/graphene/issues/events{/number}","events_url":"https://api.github.com/repos/oscarlab/graphene/events","assignees_url":"https://api.github.com/repos/oscarlab/graphene/assignees{/user}","branches_url":"https://api.github.com/repos/oscarlab/graphene/branches{/branch}","tags_url":"https://api.github.com/repos/oscarlab/graphene/tags","blobs_url":"https://api.github.com/repos/oscarlab/graphene/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oscarlab/graphene/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oscarlab/graphene/git/refs{/sha}","trees_url":"https://api.github.com/repos/oscarlab/graphene/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oscarlab/graphene/statuses/{sha}","languages_url":"https://api.github.com/repos/oscarlab/graphene/languages","stargazers_url":"https://api.github.com/repos/oscarlab/graphene/stargazers","contributors_url":"https://api.github.com/repos/oscarlab/graphene/contributors","subscribers_url":"https://api.github.com/repos/oscarlab/graphene/subscribers","subscription_url":"https://api.github.com/repos/oscarlab/graphene/subscription","commits_url":"https://api.github.com/repos/oscarlab/graphene/commits{/sha}","git_commits_url":"https://api.github.com/repos/oscarlab/graphene/git/commits{/sha}","comments_url":"https://api.github.com/repos/oscarlab/graphene/comments{/number}","issue_comment_url":"https://api.github.com/repos/oscarlab/graphene/issues/comments{/number}","contents_url":"https://api.github.com/repos/oscarlab/graphene/contents/{+path}","compare_url":"https://api.github.com/repos/oscarlab/graphene/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oscarlab/graphene/merges","archive_url":"https://api.github.com/repos/oscarlab/graphene/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oscarlab/graphene/downloads","issues_url":"https://api.github.com/repos/oscarlab/graphene/issues{/number}","pulls_url":"https://api.github.com/repos/oscarlab/graphene/pulls{/number}","milestones_url":"https://api.github.com/repos/oscarlab/graphene/milestones{/number}","notifications_url":"https://api.github.com/repos/oscarlab/graphene/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oscarlab/graphene/labels{/name}","releases_url":"https://api.github.com/repos/oscarlab/graphene/releases{/id}","deployments_url":"https://api.github.com/repos/oscarlab/graphene/deployments","created_at":"2014-03-30T07:58:58Z","updated_at":"2017-12-08T09:31:20Z","pushed_at":"2017-12-08T15:19:01Z","git_url":"git://github.com/oscarlab/graphene.git","ssh_url":"[email protected]:oscarlab/graphene.git","clone_url":"https://github.com/oscarlab/graphene.git","svn_url":"https://github.com/oscarlab/graphene","homepage":"https://github.com/oscarlab/graphene/wiki","size":383637,"stargazers_count":113,"watchers_count":113,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":48,"open_issues":45,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oscarlab/graphene/pulls/139"},"html":{"href":"https://github.com/oscarlab/graphene/pull/139"},"issue":{"href":"https://api.github.com/repos/oscarlab/graphene/issues/139"},"comments":{"href":"https://api.github.com/repos/oscarlab/graphene/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/oscarlab/graphene/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/oscarlab/graphene/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oscarlab/graphene/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/oscarlab/graphene/statuses/60148faea6306302c88c6e433dc774ee700d1eb8"}},"author_association":"OWNER"}} | {
"id": 18259989,
"name": "oscarlab/graphene",
"url": "https://api.github.com/repos/oscarlab/graphene"
} | {
"id": 5244565,
"login": "mkow",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5244565?",
"url": "https://api.github.com/users/mkow"
} | {
"id": 7105811,
"login": "oscarlab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7105811?",
"url": "https://api.github.com/orgs/oscarlab"
} | 2017-12-08T16:10:45 | 6963227512 | {"actor":{"display_login":"mkow"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/client/pulls/comments/149356388","pull_request_review_id":74734829,"id":149356388,"diff_hunk":"@@ -0,0 +1,291 @@\n+/*\n+ * Copyright (C) by Ahmed Ammar <[email protected]>\n+ *\n+ * This program is free software; you can redistribute it and/or modify\n+ * it under the terms of the GNU General Public License as published by\n+ * the Free Software Foundation; either version 2 of the License, or\n+ * (at your option) any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful, but\n+ * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY\n+ * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License\n+ * for more details.\n+ */\n+\n+#include \"config.h\"\n+#include \"owncloudpropagator_p.h\"\n+#include \"propagatedownload.h\"\n+#include \"networkjobs.h\"\n+#include \"account.h\"\n+#include \"common/syncjournaldb.h\"\n+#include \"common/syncjournalfilerecord.h\"\n+#include \"common/utility.h\"\n+#include \"filesystem.h\"\n+#include \"propagatorjobs.h\"\n+#include \"common/checksums.h\"\n+#include \"common/asserts.h\"\n+\n+#include <QLoggingCategory>\n+#include <QNetworkAccessManager>\n+#include <QFileInfo>\n+#include <QDir>\n+#include <QTemporaryFile>\n+#include <cmath>\n+\n+#ifdef Q_OS_UNIX\n+#include <unistd.h>\n+#endif\n+\n+namespace OCC {\n+\n+// DOES NOT take ownership of the device.\n+GETFileZsyncJob::GETFileZsyncJob(AccountPtr account, SyncFileItemPtr &item, OwncloudPropagator *propagator,\n+ const QString &remotepath, const QString &localpath, const QString &localtmppath, QFile *device,\n+ const QMap<QByteArray, QByteArray> &headers, const QByteArray &expectedEtagForResume,\n+ const QByteArray &zsyncData, QObject *parent)\n+ : GETJob(account, remotepath, parent)\n+ , _device(device)\n+ , _item(item)\n+ , _propagator(propagator)\n+ , _headers(headers)\n+ , _expectedEtagForResume(expectedEtagForResume)\n+ , _hasEmittedFinishedSignal(false)\n+ , _zsyncData(zsyncData)\n+ , _localpath(localpath)\n+ , _localtmppath(localtmppath)\n+{\n+}\n+\n+void GETFileZsyncJob::startCurrentRange(quint64 start, quint64 end)\n+{\n+ _headers[\"Range\"] = \"bytes=\" + QByteArray::number(start) + '-' + QByteArray::number(end);\n+\n+ qCDebug(lcZsyncGet) << path() << \"HTTP GET with range\" << _headers[\"Range\"];\n+\n+ QNetworkRequest req;\n+ for (QMap<QByteArray, QByteArray>::const_iterator it = _headers.begin(); it != _headers.end(); ++it) {\n+ req.setRawHeader(it.key(), it.value());\n+ }\n+ req.setPriority(QNetworkRequest::LowPriority); // Long downloads must not block non-propagation jobs.\n+\n+ sendRequest(\"GET\", makeDavUrl(path()), req);\n+\n+ reply()->setReadBufferSize(16 * 1024); // keep low so we can easier limit the bandwidth\n+ qCDebug(lcZsyncGet) << _bandwidthManager << _bandwidthChoked << _bandwidthLimited;\n+ if (_bandwidthManager) {\n+ _bandwidthManager->registerDownloadJob(this);\n+ }\n+\n+ if (reply()->error() != QNetworkReply::NoError) {\n+ qCWarning(lcZsyncGet) << \" Network error: \" << errorString();\n+ }\n+\n+ _pos = 0;\n+\n+ connect(reply(), &QNetworkReply::downloadProgress, this, &GETFileZsyncJob::slotOverallDownloadProgress);\n+ connect(reply(), &QIODevice::readyRead, this, &GETFileZsyncJob::slotReadyRead);\n+ connect(reply(), &QNetworkReply::metaDataChanged, this, &GETFileZsyncJob::slotMetaDataChanged);\n+ connect(this, &AbstractNetworkJob::networkActivity, account().data(), &Account::propagatorNetworkActivity);\n+\n+ AbstractNetworkJob::start();\n+}\n+\n+bool GETFileZsyncJob::finished()\n+{\n+ if (reply()->bytesAvailable()) {\n+ return false;\n+ }\n+\n+ if (_current < _nrange - 1) {\n+ _current++;\n+ startCurrentRange(_zbyterange.get()[2*_current],_zbyterange.get()[(2*_current)+1]);\n+ return false;\n+ }\n+\n+ if (!_hasEmittedFinishedSignal) {\n+ emit finishedSignal();\n+ }\n+\n+ _hasEmittedFinishedSignal = true;\n+\n+ return true; // discard\n+}\n+\n+void GETFileZsyncJob::seedFinished(void* zs)\n+{\n+ _zs = zsync_unique_ptr<struct zsync_state> ((struct zsync_state*)zs, [](struct zsync_state* zs) {\n+ zsync_complete(zs);\n+ zsync_end(zs);\n+ });\n+ if (!_zs) {\n+ _errorString = tr(\"Unable to parse zsync.\");\n+ _errorStatus = SyncFileItem::NormalError;\n+ qCDebug(lcZsyncGet) << _errorString;\n+ emit finishedSignal();\n+ return;\n+ }\n+\n+ { /* And print how far we've progressed towards the target file */\n+ long long done, total;\n+\n+ zsync_progress(_zs.get(), &done, &total);\n+ qCInfo(lcZsyncGet).nospace() << \"Done reading: \"\n+ << _localpath << \" \" << fixed << qSetRealNumberPrecision(1) << (100.0f * done) / total\n+ << \"% of target seeded.\";\n+\n+ }\n+\n+ /* Get a set of byte ranges that we need to complete the target */\n+ _zbyterange = zsync_unique_ptr<off_t> (zsync_needed_byte_ranges(_zs.get(), &_nrange, 0), [](off_t* zbr) {\n+ free(zbr);\n+ });\n+ if (!_zbyterange) {\n+ _errorString = tr(\"Failed to get zsync byte ranges.\");\n+ _errorStatus = SyncFileItem::NormalError;\n+ qCDebug(lcZsyncGet) << _errorString;\n+ emit finishedSignal();\n+ return;\n+ }\n+\n+ qCDebug(lcZsyncGet) << \"Number of ranges:\" << _nrange;\n+\n+ /* If we have no ranges then we have equal files and we are done */\n+ if (_nrange == 0) {\n+ _propagator->reportFileTotal(*_item, 0);\n+ _errorStatus = SyncFileItem::FileIgnored;\n+ emit finishedSignal();\n+ return;\n+ }\n+\n+ _zr = zsync_unique_ptr<struct zsync_receiver> (zsync_begin_receive(_zs.get(), 0), [](struct zsync_receiver* zr) {\n+ zsync_end_receive(zr);\n+ });\n+ if(!_zr) {\n+ _errorString = tr(\"Failed to initialize zsync receive structure.\");\n+ _errorStatus = SyncFileItem::NormalError;\n+ qCDebug(lcZsyncGet) << _errorString;\n+ emit finishedSignal();\n+ return;\n+ }\n+\n+ quint64 totalBytes = 0;\n+ for (int i=0; i<_nrange; i++) {\n+ totalBytes += _zbyterange.get()[(2*i)+1] - _zbyterange.get()[(2*i)];\n+ }\n+ qCDebug(lcZsyncGet) << \"Total bytes:\" << totalBytes;\n+ _propagator->reportFileTotal(*_item, totalBytes);\n+\n+ /* start getting bytes for first zsync byte range */\n+ startCurrentRange(_zbyterange.get()[0],_zbyterange.get()[1]);\n+}\n+\n+void GETFileZsyncJob::seedFailed(QString errorString)\n+{\n+ _errorString = errorString;\n+ _errorStatus = SyncFileItem::NormalError;","path":"src/libsync/propagatedownloadzsync.cpp","position":185,"original_position":185,"commit_id":"de9e704d1d9c182385078f98c95b4521949436d1","original_commit_id":"2fb10ce03c0e45708898dbc7aa7cf1ea238187e6","user":{"login":"ahmedammar","id":144686,"avatar_url":"https://avatars0.githubusercontent.com/u/144686?v=4","gravatar_id":"","url":"https://api.github.com/users/ahmedammar","html_url":"https://github.com/ahmedammar","followers_url":"https://api.github.com/users/ahmedammar/followers","following_url":"https://api.github.com/users/ahmedammar/following{/other_user}","gists_url":"https://api.github.com/users/ahmedammar/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmedammar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmedammar/subscriptions","organizations_url":"https://api.github.com/users/ahmedammar/orgs","repos_url":"https://api.github.com/users/ahmedammar/repos","events_url":"https://api.github.com/users/ahmedammar/events{/privacy}","received_events_url":"https://api.github.com/users/ahmedammar/received_events","type":"User","site_admin":false},"body":"Also worth noting that `GETFileZsyncJob::seedFailed` is not expected to be called, it would usually mean a corrupt .zsync file on remote. So I would think deleting the remote .zsync is the best/only option.","created_at":"2017-11-07T12:46:56Z","updated_at":"2017-11-07T12:46:57Z","html_url":"https://github.com/owncloud/client/pull/6131#discussion_r149356388","pull_request_url":"https://api.github.com/repos/owncloud/client/pulls/6131","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/owncloud/client/pulls/comments/149356388"},"html":{"href":"https://github.com/owncloud/client/pull/6131#discussion_r149356388"},"pull_request":{"href":"https://api.github.com/repos/owncloud/client/pulls/6131"}},"in_reply_to_id":149333555},"pull_request":{"url":"https://api.github.com/repos/owncloud/client/pulls/6131","id":149304323,"html_url":"https://github.com/owncloud/client/pull/6131","diff_url":"https://github.com/owncloud/client/pull/6131.diff","patch_url":"https://github.com/owncloud/client/pull/6131.patch","issue_url":"https://api.github.com/repos/owncloud/client/issues/6131","number":6131,"state":"open","locked":false,"title":" Implementation of delta-sync support on client-side.","user":{"login":"ahmedammar","id":144686,"avatar_url":"https://avatars0.githubusercontent.com/u/144686?v=4","gravatar_id":"","url":"https://api.github.com/users/ahmedammar","html_url":"https://github.com/ahmedammar","followers_url":"https://api.github.com/users/ahmedammar/followers","following_url":"https://api.github.com/users/ahmedammar/following{/other_user}","gists_url":"https://api.github.com/users/ahmedammar/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmedammar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmedammar/subscriptions","organizations_url":"https://api.github.com/users/ahmedammar/orgs","repos_url":"https://api.github.com/users/ahmedammar/repos","events_url":"https://api.github.com/users/ahmedammar/events{/privacy}","received_events_url":"https://api.github.com/users/ahmedammar/received_events","type":"User","site_admin":false},"body":"This commit adds client-side support for delta-sync, this adds a new 3rdparty submodule `gh:ahmedammar/zsync`. This zsync tree is a modified version of upstream; to add some needed support for the upload path.\r\n\r\nIf the server does not announce the required `zsync` capability then a full upload/download is fallen back to.\r\n\r\nOn both upload and download paths a check is made for the existance of a zsync metadata file on the server for given path. If it doesn't exist the code reverts back to complete upload or download paths, i.e. previous implementations. In the case of upload, a new zsync metadata file will be uploaded as part of the synchromization and future synchronizations will be delta-sync capable.\r\n\r\nChunked uploads no longer use sequential file names for each chunk, instead they are named as the byte offset into the remote file, this is a minimally intrusive modification to allow fo delta-sync and legacy code paths to run seamlessly. A new http header `OC-Total-File-Length` is sent, which informs the server of the final expected size of the file not just the total transmitted bytes as reported by `OC-Total-Length`.\r\n\r\nThe seeding of the zsync metadata file is done in a seperate thread since this is a cpu intensive task, ensuring main thread is not blocked.\r\n\r\nAdded configuration and command-line options to gui and cmd applications. Delta-sync is disabled by default, this can be changed once more testing is done.","created_at":"2017-10-27T23:20:09Z","updated_at":"2017-11-07T12:46:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac0fdbdf64fe8ae2a1e9c0fc3337b2228e97b7f0","assignee":{"login":"ckamm","id":833306,"avatar_url":"https://avatars0.githubusercontent.com/u/833306?v=4","gravatar_id":"","url":"https://api.github.com/users/ckamm","html_url":"https://github.com/ckamm","followers_url":"https://api.github.com/users/ckamm/followers","following_url":"https://api.github.com/users/ckamm/following{/other_user}","gists_url":"https://api.github.com/users/ckamm/gists{/gist_id}","starred_url":"https://api.github.com/users/ckamm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckamm/subscriptions","organizations_url":"https://api.github.com/users/ckamm/orgs","repos_url":"https://api.github.com/users/ckamm/repos","events_url":"https://api.github.com/users/ckamm/events{/privacy}","received_events_url":"https://api.github.com/users/ckamm/received_events","type":"User","site_admin":false},"assignees":[{"login":"ckamm","id":833306,"avatar_url":"https://avatars0.githubusercontent.com/u/833306?v=4","gravatar_id":"","url":"https://api.github.com/users/ckamm","html_url":"https://github.com/ckamm","followers_url":"https://api.github.com/users/ckamm/followers","following_url":"https://api.github.com/users/ckamm/following{/other_user}","gists_url":"https://api.github.com/users/ckamm/gists{/gist_id}","starred_url":"https://api.github.com/users/ckamm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckamm/subscriptions","organizations_url":"https://api.github.com/users/ckamm/orgs","repos_url":"https://api.github.com/users/ckamm/repos","events_url":"https://api.github.com/users/ckamm/events{/privacy}","received_events_url":"https://api.github.com/users/ckamm/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ogoffart","id":959326,"avatar_url":"https://avatars3.githubusercontent.com/u/959326?v=4","gravatar_id":"","url":"https://api.github.com/users/ogoffart","html_url":"https://github.com/ogoffart","followers_url":"https://api.github.com/users/ogoffart/followers","following_url":"https://api.github.com/users/ogoffart/following{/other_user}","gists_url":"https://api.github.com/users/ogoffart/gists{/gist_id}","starred_url":"https://api.github.com/users/ogoffart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogoffart/subscriptions","organizations_url":"https://api.github.com/users/ogoffart/orgs","repos_url":"https://api.github.com/users/ogoffart/repos","events_url":"https://api.github.com/users/ogoffart/events{/privacy}","received_events_url":"https://api.github.com/users/ogoffart/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/owncloud/client/milestones/42","html_url":"https://github.com/owncloud/client/milestone/42","labels_url":"https://api.github.com/repos/owncloud/client/milestones/42/labels","id":2582505,"number":42,"title":"2.5.0","description":"","creator":{"login":"guruz","id":959327,"avatar_url":"https://avatars3.githubusercontent.com/u/959327?v=4","gravatar_id":"","url":"https://api.github.com/users/guruz","html_url":"https://github.com/guruz","followers_url":"https://api.github.com/users/guruz/followers","following_url":"https://api.github.com/users/guruz/following{/other_user}","gists_url":"https://api.github.com/users/guruz/gists{/gist_id}","starred_url":"https://api.github.com/users/guruz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guruz/subscriptions","organizations_url":"https://api.github.com/users/guruz/orgs","repos_url":"https://api.github.com/users/guruz/repos","events_url":"https://api.github.com/users/guruz/events{/privacy}","received_events_url":"https://api.github.com/users/guruz/received_events","type":"User","site_admin":false},"open_issues":50,"closed_issues":2,"state":"open","created_at":"2017-06-14T10:52:21Z","updated_at":"2017-11-06T12:37:41Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/owncloud/client/pulls/6131/commits","review_comments_url":"https://api.github.com/repos/owncloud/client/pulls/6131/comments","review_comment_url":"https://api.github.com/repos/owncloud/client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/client/issues/6131/comments","statuses_url":"https://api.github.com/repos/owncloud/client/statuses/de9e704d1d9c182385078f98c95b4521949436d1","head":{"label":"ahmedammar:master","ref":"master","sha":"de9e704d1d9c182385078f98c95b4521949436d1","user":{"login":"ahmedammar","id":144686,"avatar_url":"https://avatars0.githubusercontent.com/u/144686?v=4","gravatar_id":"","url":"https://api.github.com/users/ahmedammar","html_url":"https://github.com/ahmedammar","followers_url":"https://api.github.com/users/ahmedammar/followers","following_url":"https://api.github.com/users/ahmedammar/following{/other_user}","gists_url":"https://api.github.com/users/ahmedammar/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmedammar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmedammar/subscriptions","organizations_url":"https://api.github.com/users/ahmedammar/orgs","repos_url":"https://api.github.com/users/ahmedammar/repos","events_url":"https://api.github.com/users/ahmedammar/events{/privacy}","received_events_url":"https://api.github.com/users/ahmedammar/received_events","type":"User","site_admin":false},"repo":{"id":108590367,"name":"client","full_name":"ahmedammar/client","owner":{"login":"ahmedammar","id":144686,"avatar_url":"https://avatars0.githubusercontent.com/u/144686?v=4","gravatar_id":"","url":"https://api.github.com/users/ahmedammar","html_url":"https://github.com/ahmedammar","followers_url":"https://api.github.com/users/ahmedammar/followers","following_url":"https://api.github.com/users/ahmedammar/following{/other_user}","gists_url":"https://api.github.com/users/ahmedammar/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmedammar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmedammar/subscriptions","organizations_url":"https://api.github.com/users/ahmedammar/orgs","repos_url":"https://api.github.com/users/ahmedammar/repos","events_url":"https://api.github.com/users/ahmedammar/events{/privacy}","received_events_url":"https://api.github.com/users/ahmedammar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahmedammar/client","description":":computer: Desktop Syncing Client for ownCloud","fork":true,"url":"https://api.github.com/repos/ahmedammar/client","forks_url":"https://api.github.com/repos/ahmedammar/client/forks","keys_url":"https://api.github.com/repos/ahmedammar/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahmedammar/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahmedammar/client/teams","hooks_url":"https://api.github.com/repos/ahmedammar/client/hooks","issue_events_url":"https://api.github.com/repos/ahmedammar/client/issues/events{/number}","events_url":"https://api.github.com/repos/ahmedammar/client/events","assignees_url":"https://api.github.com/repos/ahmedammar/client/assignees{/user}","branches_url":"https://api.github.com/repos/ahmedammar/client/branches{/branch}","tags_url":"https://api.github.com/repos/ahmedammar/client/tags","blobs_url":"https://api.github.com/repos/ahmedammar/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahmedammar/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahmedammar/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahmedammar/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahmedammar/client/statuses/{sha}","languages_url":"https://api.github.com/repos/ahmedammar/client/languages","stargazers_url":"https://api.github.com/repos/ahmedammar/client/stargazers","contributors_url":"https://api.github.com/repos/ahmedammar/client/contributors","subscribers_url":"https://api.github.com/repos/ahmedammar/client/subscribers","subscription_url":"https://api.github.com/repos/ahmedammar/client/subscription","commits_url":"https://api.github.com/repos/ahmedammar/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahmedammar/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahmedammar/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahmedammar/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahmedammar/client/contents/{+path}","compare_url":"https://api.github.com/repos/ahmedammar/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahmedammar/client/merges","archive_url":"https://api.github.com/repos/ahmedammar/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahmedammar/client/downloads","issues_url":"https://api.github.com/repos/ahmedammar/client/issues{/number}","pulls_url":"https://api.github.com/repos/ahmedammar/client/pulls{/number}","milestones_url":"https://api.github.com/repos/ahmedammar/client/milestones{/number}","notifications_url":"https://api.github.com/repos/ahmedammar/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahmedammar/client/labels{/name}","releases_url":"https://api.github.com/repos/ahmedammar/client/releases{/id}","deployments_url":"https://api.github.com/repos/ahmedammar/client/deployments","created_at":"2017-10-27T19:59:50Z","updated_at":"2017-10-27T19:59:55Z","pushed_at":"2017-11-07T12:22:27Z","git_url":"git://github.com/ahmedammar/client.git","ssh_url":"[email protected]:ahmedammar/client.git","clone_url":"https://github.com/ahmedammar/client.git","svn_url":"https://github.com/ahmedammar/client","homepage":"","size":144502,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"d903afc4bf30953c3bfafc71120ba8f8a095634c","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550623,"name":"client","full_name":"owncloud/client","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/client","description":":computer: Desktop Syncing Client for ownCloud","fork":false,"url":"https://api.github.com/repos/owncloud/client","forks_url":"https://api.github.com/repos/owncloud/client/forks","keys_url":"https://api.github.com/repos/owncloud/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/client/teams","hooks_url":"https://api.github.com/repos/owncloud/client/hooks","issue_events_url":"https://api.github.com/repos/owncloud/client/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/client/events","assignees_url":"https://api.github.com/repos/owncloud/client/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/client/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/client/tags","blobs_url":"https://api.github.com/repos/owncloud/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/client/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/client/languages","stargazers_url":"https://api.github.com/repos/owncloud/client/stargazers","contributors_url":"https://api.github.com/repos/owncloud/client/contributors","subscribers_url":"https://api.github.com/repos/owncloud/client/subscribers","subscription_url":"https://api.github.com/repos/owncloud/client/subscription","commits_url":"https://api.github.com/repos/owncloud/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/client/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/client/merges","archive_url":"https://api.github.com/repos/owncloud/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/client/downloads","issues_url":"https://api.github.com/repos/owncloud/client/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/client/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/client/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/client/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/client/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/client/deployments","created_at":"2012-08-25T10:44:53Z","updated_at":"2017-11-06T21:05:19Z","pushed_at":"2017-11-07T12:22:29Z","git_url":"git://github.com/owncloud/client.git","ssh_url":"[email protected]:owncloud/client.git","clone_url":"https://github.com/owncloud/client.git","svn_url":"https://github.com/owncloud/client","homepage":"","size":144393,"stargazers_count":886,"watchers_count":886,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":521,"mirror_url":null,"archived":false,"open_issues_count":552,"forks":521,"open_issues":552,"watchers":886,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/client/pulls/6131"},"html":{"href":"https://github.com/owncloud/client/pull/6131"},"issue":{"href":"https://api.github.com/repos/owncloud/client/issues/6131"},"comments":{"href":"https://api.github.com/repos/owncloud/client/issues/6131/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/client/pulls/6131/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/client/pulls/6131/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/client/statuses/de9e704d1d9c182385078f98c95b4521949436d1"}},"author_association":"NONE"}} | {
"id": 5550623,
"name": "owncloud/client",
"url": "https://api.github.com/repos/owncloud/client"
} | {
"id": 144686,
"login": "ahmedammar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/144686?",
"url": "https://api.github.com/users/ahmedammar"
} | {
"id": 1645051,
"login": "owncloud",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1645051?",
"url": "https://api.github.com/orgs/owncloud"
} | 2017-11-07T12:46:56 | 6820113041 | {"actor":{"display_login":"ahmedammar"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/145044943","pull_request_review_id":69784107,"id":145044943,"diff_hunk":"@@ -0,0 +1,70 @@\n+<?php\n+/**\n+ * @author Thomas Müller <[email protected]>\n+ *\n+ * @copyright Copyright (c) 2017, ownCloud GmbH\n+ * @license AGPL-3.0\n+ *\n+ * This code is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU Affero General Public License, version 3,\n+ * as published by the Free Software Foundation.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+ * GNU Affero General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU Affero General Public License, version 3,\n+ * along with this program. If not, see <http://www.gnu.org/licenses/>\n+ *\n+ */\n+\n+\n+namespace OC\\Files\\Meta;\n+\n+\n+use OC\\Files\\Node\\AbstractFile;\n+use OC\\Files\\Node\\File;\n+use OC\\Files\\Storage\\IVersionedStorage;\n+use OCP\\Files\\NotPermittedException;\n+use OCP\\Files\\Storage;\n+\n+class MetaFileVersionNode extends AbstractFile {","path":"lib/private/Files/Meta/MetaFileVersionNode.php","position":32,"original_position":32,"commit_id":"2eb9262b50db3b84cf7e923d51e2bfee862fb7e8","original_commit_id":"2eb9262b50db3b84cf7e923d51e2bfee862fb7e8","user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars2.githubusercontent.com/u/277525?v=4","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"body":"phpdoc","created_at":"2017-10-17T07:19:16Z","updated_at":"2017-10-17T07:39:38Z","html_url":"https://github.com/owncloud/core/pull/29207#discussion_r145044943","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/29207","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/145044943"},"html":{"href":"https://github.com/owncloud/core/pull/29207#discussion_r145044943"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/29207"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/29207","id":145926565,"html_url":"https://github.com/owncloud/core/pull/29207","diff_url":"https://github.com/owncloud/core/pull/29207.diff","patch_url":"https://github.com/owncloud/core/pull/29207.patch","issue_url":"https://api.github.com/repos/owncloud/core/issues/29207","number":29207,"state":"open","locked":false,"title":"Adding meta data file tree to node api","user":{"login":"DeepDiver1975","id":1005065,"avatar_url":"https://avatars2.githubusercontent.com/u/1005065?v=4","gravatar_id":"","url":"https://api.github.com/users/DeepDiver1975","html_url":"https://github.com/DeepDiver1975","followers_url":"https://api.github.com/users/DeepDiver1975/followers","following_url":"https://api.github.com/users/DeepDiver1975/following{/other_user}","gists_url":"https://api.github.com/users/DeepDiver1975/gists{/gist_id}","starred_url":"https://api.github.com/users/DeepDiver1975/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeepDiver1975/subscriptions","organizations_url":"https://api.github.com/users/DeepDiver1975/orgs","repos_url":"https://api.github.com/users/DeepDiver1975/repos","events_url":"https://api.github.com/users/DeepDiver1975/events{/privacy}","received_events_url":"https://api.github.com/users/DeepDiver1975/received_events","type":"User","site_admin":false},"body":"## Description\r\nAdds files versions api on php level to the node api\r\n\r\n## Related Issue\r\nrefs #29087 \r\n\r\n## Motivation and Context\r\nAdding a public api for versions on php level\r\n\r\n## How Has This Been Tested?\r\nUnit tests have been added\r\n\r\n## Types of changes\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n\r\n","created_at":"2017-10-11T11:46:24Z","updated_at":"2017-10-17T07:39:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e02f2dde85a342fb617c37912f7ec2a84d1ef4fa","assignee":{"login":"DeepDiver1975","id":1005065,"avatar_url":"https://avatars2.githubusercontent.com/u/1005065?v=4","gravatar_id":"","url":"https://api.github.com/users/DeepDiver1975","html_url":"https://github.com/DeepDiver1975","followers_url":"https://api.github.com/users/DeepDiver1975/followers","following_url":"https://api.github.com/users/DeepDiver1975/following{/other_user}","gists_url":"https://api.github.com/users/DeepDiver1975/gists{/gist_id}","starred_url":"https://api.github.com/users/DeepDiver1975/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeepDiver1975/subscriptions","organizations_url":"https://api.github.com/users/DeepDiver1975/orgs","repos_url":"https://api.github.com/users/DeepDiver1975/repos","events_url":"https://api.github.com/users/DeepDiver1975/events{/privacy}","received_events_url":"https://api.github.com/users/DeepDiver1975/received_events","type":"User","site_admin":false},"assignees":[{"login":"DeepDiver1975","id":1005065,"avatar_url":"https://avatars2.githubusercontent.com/u/1005065?v=4","gravatar_id":"","url":"https://api.github.com/users/DeepDiver1975","html_url":"https://github.com/DeepDiver1975","followers_url":"https://api.github.com/users/DeepDiver1975/followers","following_url":"https://api.github.com/users/DeepDiver1975/following{/other_user}","gists_url":"https://api.github.com/users/DeepDiver1975/gists{/gist_id}","starred_url":"https://api.github.com/users/DeepDiver1975/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeepDiver1975/subscriptions","organizations_url":"https://api.github.com/users/DeepDiver1975/orgs","repos_url":"https://api.github.com/users/DeepDiver1975/repos","events_url":"https://api.github.com/users/DeepDiver1975/events{/privacy}","received_events_url":"https://api.github.com/users/DeepDiver1975/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/117","html_url":"https://github.com/owncloud/core/milestone/117","labels_url":"https://api.github.com/repos/owncloud/core/milestones/117/labels","id":2619154,"number":117,"title":"development","description":"10.0.4","creator":{"login":"PVince81","id":277525,"avatar_url":"https://avatars2.githubusercontent.com/u/277525?v=4","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"open_issues":107,"closed_issues":191,"state":"open","created_at":"2017-07-03T15:30:42Z","updated_at":"2017-10-17T07:28:13Z","due_on":"2017-10-09T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/owncloud/core/pulls/29207/commits","review_comments_url":"https://api.github.com/repos/owncloud/core/pulls/29207/comments","review_comment_url":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/core/issues/29207/comments","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/2eb9262b50db3b84cf7e923d51e2bfee862fb7e8","head":{"label":"owncloud:feature/29087","ref":"feature/29087","sha":"2eb9262b50db3b84cf7e923d51e2bfee862fb7e8","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":":cloud: ownCloud web server core (Files, DAV, etc.)","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/core/deployments","created_at":"2012-08-25T10:32:48Z","updated_at":"2017-10-17T06:38:36Z","pushed_at":"2017-10-17T07:34:15Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"[email protected]:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":"https://owncloud.org/","size":226613,"stargazers_count":5563,"watchers_count":5563,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1747,"mirror_url":null,"open_issues_count":1709,"forks":1747,"open_issues":1709,"watchers":5563,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"8cbc3d07442bd2f3fb650f64be7a0259ca255b31","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":":cloud: ownCloud web server core (Files, DAV, etc.)","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/core/deployments","created_at":"2012-08-25T10:32:48Z","updated_at":"2017-10-17T06:38:36Z","pushed_at":"2017-10-17T07:34:15Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"[email protected]:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":"https://owncloud.org/","size":226613,"stargazers_count":5563,"watchers_count":5563,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1747,"mirror_url":null,"open_issues_count":1709,"forks":1747,"open_issues":1709,"watchers":5563,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/29207"},"html":{"href":"https://github.com/owncloud/core/pull/29207"},"issue":{"href":"https://api.github.com/repos/owncloud/core/issues/29207"},"comments":{"href":"https://api.github.com/repos/owncloud/core/issues/29207/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/core/pulls/29207/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/core/pulls/29207/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/core/statuses/2eb9262b50db3b84cf7e923d51e2bfee862fb7e8"}},"author_association":"OWNER"}} | {
"id": 5550552,
"name": "owncloud/core",
"url": "https://api.github.com/repos/owncloud/core"
} | {
"id": 277525,
"login": "PVince81",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/277525?",
"url": "https://api.github.com/users/PVince81"
} | {
"id": 1645051,
"login": "owncloud",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1645051?",
"url": "https://api.github.com/orgs/owncloud"
} | 2017-10-17T07:19:16 | 6725836114 | {"actor":{"display_login":"PVince81"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/palantir/blueprint/pulls/comments/100436022","pull_request_review_id":21144361,"id":100436022,"diff_hunk":"@@ -381,6 +392,18 @@ describe(\"<NumericInput>\", () => {\n const newValue = component.state().value;\n expect(newValue).to.equal(MIN_VALUE.toString());\n });\n+\n+ it(\"fires onValueChange with clamped value if props.min was updated to exceed current value \", () => {\n+ const onValueChangeSpy = sinon.spy();\n+ const component = mount(<NumericInput value={-10} onValueChange={onValueChangeSpy} />);\n+\n+ component.setProps({ min: 0 });\n+\n+ const newValue = component.state().value;\n+ expect(newValue).to.equal(\"0\");\n+ expect(onValueChangeSpy.calledOnce).to.be.true;\n+ expect(onValueChangeSpy.firstCall.args).to.deep.equal([0, \"0\"]);\n+ });","path":"packages/core/test/controls/numericInputTests.tsx","position":33,"original_position":33,"commit_id":"724cd9e6defa69f1bd2f44a4aee8334f50507b86","original_commit_id":"724cd9e6defa69f1bd2f44a4aee8334f50507b86","user":{"login":"cmslewis","id":443450,"avatar_url":"https://avatars.githubusercontent.com/u/443450?v=3","gravatar_id":"","url":"https://api.github.com/users/cmslewis","html_url":"https://github.com/cmslewis","followers_url":"https://api.github.com/users/cmslewis/followers","following_url":"https://api.github.com/users/cmslewis/following{/other_user}","gists_url":"https://api.github.com/users/cmslewis/gists{/gist_id}","starred_url":"https://api.github.com/users/cmslewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmslewis/subscriptions","organizations_url":"https://api.github.com/users/cmslewis/orgs","repos_url":"https://api.github.com/users/cmslewis/repos","events_url":"https://api.github.com/users/cmslewis/events{/privacy}","received_events_url":"https://api.github.com/users/cmslewis/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2017-02-09T23:07:34Z","updated_at":"2017-02-09T23:07:34Z","html_url":"https://github.com/palantir/blueprint/pull/659#discussion_r100436022","pull_request_url":"https://api.github.com/repos/palantir/blueprint/pulls/659","_links":{"self":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/comments/100436022"},"html":{"href":"https://github.com/palantir/blueprint/pull/659#discussion_r100436022"},"pull_request":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/659"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/blueprint/pulls/659","id":105526648,"html_url":"https://github.com/palantir/blueprint/pull/659","diff_url":"https://github.com/palantir/blueprint/pull/659.diff","patch_url":"https://github.com/palantir/blueprint/pull/659.patch","issue_url":"https://api.github.com/repos/palantir/blueprint/issues/659","number":659,"state":"open","locked":false,"title":"[Numeric Input] Fire onValueChange when min/max updated","user":{"login":"cmslewis","id":443450,"avatar_url":"https://avatars.githubusercontent.com/u/443450?v=3","gravatar_id":"","url":"https://api.github.com/users/cmslewis","html_url":"https://github.com/cmslewis","followers_url":"https://api.github.com/users/cmslewis/followers","following_url":"https://api.github.com/users/cmslewis/following{/other_user}","gists_url":"https://api.github.com/users/cmslewis/gists{/gist_id}","starred_url":"https://api.github.com/users/cmslewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmslewis/subscriptions","organizations_url":"https://api.github.com/users/cmslewis/orgs","repos_url":"https://api.github.com/users/cmslewis/repos","events_url":"https://api.github.com/users/cmslewis/events{/privacy}","received_events_url":"https://api.github.com/users/cmslewis/received_events","type":"User","site_admin":false},"body":"#### (No issue filed)\r\n\r\n#### Checklist\r\n\r\n- [x] Include tests\r\n\r\n#### Changes proposed in this pull request:\r\n\r\n- _Bugfix:_ When `props.min` or `props.max` are updated such that the current value is now out of bounds, fire `onValueChange` with the clamped value to prevent the parent component from \"remembering\" the unclamped value.\r\n\r\n#### Screenshot\r\n\r\n_Before:_\r\nOriginal value is shown if a bound changes to something else and back.\r\n\r\n\r\n\r\n_After:_\r\nOriginal value is replaced with the clamped value, such that the clamped value stays as is when the bounds change.\r\n\r\n\r\n","created_at":"2017-02-09T22:24:04Z","updated_at":"2017-02-09T23:07:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5912c5b18a7ab7e2eef9ca601634cc79367e4911","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/blueprint/pulls/659/commits","review_comments_url":"https://api.github.com/repos/palantir/blueprint/pulls/659/comments","review_comment_url":"https://api.github.com/repos/palantir/blueprint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/blueprint/issues/659/comments","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/724cd9e6defa69f1bd2f44a4aee8334f50507b86","head":{"label":"palantir:cl/fix-numeric-input-max-min-clamping","ref":"cl/fix-numeric-input-max-min-clamping","sha":"724cd9e6defa69f1bd2f44a4aee8334f50507b86","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":71939872,"name":"blueprint","full_name":"palantir/blueprint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/blueprint","description":"A React-based UI toolkit for the web","fork":false,"url":"https://api.github.com/repos/palantir/blueprint","forks_url":"https://api.github.com/repos/palantir/blueprint/forks","keys_url":"https://api.github.com/repos/palantir/blueprint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/blueprint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/blueprint/teams","hooks_url":"https://api.github.com/repos/palantir/blueprint/hooks","issue_events_url":"https://api.github.com/repos/palantir/blueprint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/blueprint/events","assignees_url":"https://api.github.com/repos/palantir/blueprint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/blueprint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/blueprint/tags","blobs_url":"https://api.github.com/repos/palantir/blueprint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/blueprint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/blueprint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/blueprint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/blueprint/languages","stargazers_url":"https://api.github.com/repos/palantir/blueprint/stargazers","contributors_url":"https://api.github.com/repos/palantir/blueprint/contributors","subscribers_url":"https://api.github.com/repos/palantir/blueprint/subscribers","subscription_url":"https://api.github.com/repos/palantir/blueprint/subscription","commits_url":"https://api.github.com/repos/palantir/blueprint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/blueprint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/blueprint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/blueprint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/blueprint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/blueprint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/blueprint/merges","archive_url":"https://api.github.com/repos/palantir/blueprint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/blueprint/downloads","issues_url":"https://api.github.com/repos/palantir/blueprint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/blueprint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/blueprint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/blueprint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/blueprint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/blueprint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/blueprint/deployments","created_at":"2016-10-25T21:17:50Z","updated_at":"2017-02-09T19:05:01Z","pushed_at":"2017-02-09T22:24:04Z","git_url":"git://github.com/palantir/blueprint.git","ssh_url":"[email protected]:palantir/blueprint.git","clone_url":"https://github.com/palantir/blueprint.git","svn_url":"https://github.com/palantir/blueprint","homepage":"http://blueprintjs.com/","size":14707,"stargazers_count":5467,"watchers_count":5467,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":240,"mirror_url":null,"open_issues_count":127,"forks":240,"open_issues":127,"watchers":5467,"default_branch":"master"}},"base":{"label":"palantir:master","ref":"master","sha":"28e4ed5d685a66251961b73a7f11c83ed4a1d991","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":71939872,"name":"blueprint","full_name":"palantir/blueprint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/blueprint","description":"A React-based UI toolkit for the web","fork":false,"url":"https://api.github.com/repos/palantir/blueprint","forks_url":"https://api.github.com/repos/palantir/blueprint/forks","keys_url":"https://api.github.com/repos/palantir/blueprint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/blueprint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/blueprint/teams","hooks_url":"https://api.github.com/repos/palantir/blueprint/hooks","issue_events_url":"https://api.github.com/repos/palantir/blueprint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/blueprint/events","assignees_url":"https://api.github.com/repos/palantir/blueprint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/blueprint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/blueprint/tags","blobs_url":"https://api.github.com/repos/palantir/blueprint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/blueprint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/blueprint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/blueprint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/blueprint/languages","stargazers_url":"https://api.github.com/repos/palantir/blueprint/stargazers","contributors_url":"https://api.github.com/repos/palantir/blueprint/contributors","subscribers_url":"https://api.github.com/repos/palantir/blueprint/subscribers","subscription_url":"https://api.github.com/repos/palantir/blueprint/subscription","commits_url":"https://api.github.com/repos/palantir/blueprint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/blueprint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/blueprint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/blueprint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/blueprint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/blueprint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/blueprint/merges","archive_url":"https://api.github.com/repos/palantir/blueprint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/blueprint/downloads","issues_url":"https://api.github.com/repos/palantir/blueprint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/blueprint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/blueprint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/blueprint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/blueprint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/blueprint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/blueprint/deployments","created_at":"2016-10-25T21:17:50Z","updated_at":"2017-02-09T19:05:01Z","pushed_at":"2017-02-09T22:24:04Z","git_url":"git://github.com/palantir/blueprint.git","ssh_url":"[email protected]:palantir/blueprint.git","clone_url":"https://github.com/palantir/blueprint.git","svn_url":"https://github.com/palantir/blueprint","homepage":"http://blueprintjs.com/","size":14707,"stargazers_count":5467,"watchers_count":5467,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":240,"mirror_url":null,"open_issues_count":127,"forks":240,"open_issues":127,"watchers":5467,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/659"},"html":{"href":"https://github.com/palantir/blueprint/pull/659"},"issue":{"href":"https://api.github.com/repos/palantir/blueprint/issues/659"},"comments":{"href":"https://api.github.com/repos/palantir/blueprint/issues/659/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/659/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/659/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/blueprint/statuses/724cd9e6defa69f1bd2f44a4aee8334f50507b86"}}}} | {
"id": 71939872,
"name": "palantir/blueprint",
"url": "https://api.github.com/repos/palantir/blueprint"
} | {
"id": 443450,
"login": "cmslewis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/443450?",
"url": "https://api.github.com/users/cmslewis"
} | {
"id": 303157,
"login": "palantir",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/303157?",
"url": "https://api.github.com/orgs/palantir"
} | 2017-02-09T23:07:34 | 5299138407 | {"actor":{"display_login":"cmslewis"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/platanus/potassium/pulls/comments/136622658","pull_request_review_id":60192148,"id":136622658,"diff_hunk":"@@ -0,0 +1,24 @@\n+module ApiVersioned","path":"lib/potassium/assets/api/api_versioned.rb","position":1,"original_position":1,"commit_id":"144c84585f2aa49bdcc6d6a88315b5c5c4a51a5e","original_commit_id":"144c84585f2aa49bdcc6d6a88315b5c5c4a51a5e","user":{"login":"ldlsegovia","id":3026413,"avatar_url":"https://avatars1.githubusercontent.com/u/3026413?v=4","gravatar_id":"","url":"https://api.github.com/users/ldlsegovia","html_url":"https://github.com/ldlsegovia","followers_url":"https://api.github.com/users/ldlsegovia/followers","following_url":"https://api.github.com/users/ldlsegovia/following{/other_user}","gists_url":"https://api.github.com/users/ldlsegovia/gists{/gist_id}","starred_url":"https://api.github.com/users/ldlsegovia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldlsegovia/subscriptions","organizations_url":"https://api.github.com/users/ldlsegovia/orgs","repos_url":"https://api.github.com/users/ldlsegovia/repos","events_url":"https://api.github.com/users/ldlsegovia/events{/privacy}","received_events_url":"https://api.github.com/users/ldlsegovia/received_events","type":"User","site_admin":false},"body":"@camilo9020 ignorá los comentarios en este archivo. Habría que reemplazar el contenido por esto\r\n```ruby\r\nmodule Api::Versioned\r\n extend ActiveSupport::Concern\r\n\r\n AVAILABLE_API_VERSIONS = 1\r\n\r\n included do\r\n before_action :check_api_version!\r\n after_action :set_content_type\r\n end\r\n\r\n private\r\n\r\n def check_api_version!\r\n accept_header = request.headers[:accept]\r\n @version_number = accept_header.to_s.match(/version=(\\d+)/).try(:captures).try(:first).to_i\r\n @version_number = 1 if @version_number.zero?\r\n fail \"invalid API version\" unless (1..AVAILABLE_API_VERSIONS) === @version_number\r\n end\r\n\r\n def set_content_type\r\n content_type_header = response.headers[\"Content-Type\"]\r\n parts = !content_type_header ? [] : content_type_header.split(\";\").map(&:strip)\r\n parts << \"version=#{@version_number}\"\r\n response.headers[\"Content-Type\"] = parts.join(\"; \")\r\n end\r\nend\r\n```","created_at":"2017-09-01T17:08:29Z","updated_at":"2017-09-01T17:08:29Z","html_url":"https://github.com/platanus/potassium/pull/148#discussion_r136622658","pull_request_url":"https://api.github.com/repos/platanus/potassium/pulls/148","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/platanus/potassium/pulls/comments/136622658"},"html":{"href":"https://github.com/platanus/potassium/pull/148#discussion_r136622658"},"pull_request":{"href":"https://api.github.com/repos/platanus/potassium/pulls/148"}}},"pull_request":{"url":"https://api.github.com/repos/platanus/potassium/pulls/148","id":134186526,"html_url":"https://github.com/platanus/potassium/pull/148","diff_url":"https://github.com/platanus/potassium/pull/148.diff","patch_url":"https://github.com/platanus/potassium/pull/148.patch","issue_url":"https://api.github.com/repos/platanus/potassium/issues/148","number":148,"state":"open","locked":false,"title":"feat(recipes/api): adding assets to configurate api structure","user":{"login":"camilo9020","id":13052112,"avatar_url":"https://avatars1.githubusercontent.com/u/13052112?v=4","gravatar_id":"","url":"https://api.github.com/users/camilo9020","html_url":"https://github.com/camilo9020","followers_url":"https://api.github.com/users/camilo9020/followers","following_url":"https://api.github.com/users/camilo9020/following{/other_user}","gists_url":"https://api.github.com/users/camilo9020/gists{/gist_id}","starred_url":"https://api.github.com/users/camilo9020/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camilo9020/subscriptions","organizations_url":"https://api.github.com/users/camilo9020/orgs","repos_url":"https://api.github.com/users/camilo9020/repos","events_url":"https://api.github.com/users/camilo9020/events{/privacy}","received_events_url":"https://api.github.com/users/camilo9020/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-04T14:58:28Z","updated_at":"2017-09-01T17:08:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3685215e2c4127c6f5d73914e5549dc703535af9","assignee":{"login":"felbalart","id":1797242,"avatar_url":"https://avatars3.githubusercontent.com/u/1797242?v=4","gravatar_id":"","url":"https://api.github.com/users/felbalart","html_url":"https://github.com/felbalart","followers_url":"https://api.github.com/users/felbalart/followers","following_url":"https://api.github.com/users/felbalart/following{/other_user}","gists_url":"https://api.github.com/users/felbalart/gists{/gist_id}","starred_url":"https://api.github.com/users/felbalart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felbalart/subscriptions","organizations_url":"https://api.github.com/users/felbalart/orgs","repos_url":"https://api.github.com/users/felbalart/repos","events_url":"https://api.github.com/users/felbalart/events{/privacy}","received_events_url":"https://api.github.com/users/felbalart/received_events","type":"User","site_admin":false},"assignees":[{"login":"felbalart","id":1797242,"avatar_url":"https://avatars3.githubusercontent.com/u/1797242?v=4","gravatar_id":"","url":"https://api.github.com/users/felbalart","html_url":"https://github.com/felbalart","followers_url":"https://api.github.com/users/felbalart/followers","following_url":"https://api.github.com/users/felbalart/following{/other_user}","gists_url":"https://api.github.com/users/felbalart/gists{/gist_id}","starred_url":"https://api.github.com/users/felbalart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felbalart/subscriptions","organizations_url":"https://api.github.com/users/felbalart/orgs","repos_url":"https://api.github.com/users/felbalart/repos","events_url":"https://api.github.com/users/felbalart/events{/privacy}","received_events_url":"https://api.github.com/users/felbalart/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bunzli","id":741483,"avatar_url":"https://avatars2.githubusercontent.com/u/741483?v=4","gravatar_id":"","url":"https://api.github.com/users/bunzli","html_url":"https://github.com/bunzli","followers_url":"https://api.github.com/users/bunzli/followers","following_url":"https://api.github.com/users/bunzli/following{/other_user}","gists_url":"https://api.github.com/users/bunzli/gists{/gist_id}","starred_url":"https://api.github.com/users/bunzli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bunzli/subscriptions","organizations_url":"https://api.github.com/users/bunzli/orgs","repos_url":"https://api.github.com/users/bunzli/repos","events_url":"https://api.github.com/users/bunzli/events{/privacy}","received_events_url":"https://api.github.com/users/bunzli/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/platanus/potassium/pulls/148/commits","review_comments_url":"https://api.github.com/repos/platanus/potassium/pulls/148/comments","review_comment_url":"https://api.github.com/repos/platanus/potassium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/platanus/potassium/issues/148/comments","statuses_url":"https://api.github.com/repos/platanus/potassium/statuses/144c84585f2aa49bdcc6d6a88315b5c5c4a51a5e","head":{"label":"platanus:good-practices-api","ref":"good-practices-api","sha":"144c84585f2aa49bdcc6d6a88315b5c5c4a51a5e","user":{"login":"platanus","id":1158740,"avatar_url":"https://avatars3.githubusercontent.com/u/1158740?v=4","gravatar_id":"","url":"https://api.github.com/users/platanus","html_url":"https://github.com/platanus","followers_url":"https://api.github.com/users/platanus/followers","following_url":"https://api.github.com/users/platanus/following{/other_user}","gists_url":"https://api.github.com/users/platanus/gists{/gist_id}","starred_url":"https://api.github.com/users/platanus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platanus/subscriptions","organizations_url":"https://api.github.com/users/platanus/orgs","repos_url":"https://api.github.com/users/platanus/repos","events_url":"https://api.github.com/users/platanus/events{/privacy}","received_events_url":"https://api.github.com/users/platanus/received_events","type":"Organization","site_admin":false},"repo":{"id":35299873,"name":"potassium","full_name":"platanus/potassium","owner":{"login":"platanus","id":1158740,"avatar_url":"https://avatars3.githubusercontent.com/u/1158740?v=4","gravatar_id":"","url":"https://api.github.com/users/platanus","html_url":"https://github.com/platanus","followers_url":"https://api.github.com/users/platanus/followers","following_url":"https://api.github.com/users/platanus/following{/other_user}","gists_url":"https://api.github.com/users/platanus/gists{/gist_id}","starred_url":"https://api.github.com/users/platanus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platanus/subscriptions","organizations_url":"https://api.github.com/users/platanus/orgs","repos_url":"https://api.github.com/users/platanus/repos","events_url":"https://api.github.com/users/platanus/events{/privacy}","received_events_url":"https://api.github.com/users/platanus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/platanus/potassium","description":"The father to every Platanus Rails proyect","fork":false,"url":"https://api.github.com/repos/platanus/potassium","forks_url":"https://api.github.com/repos/platanus/potassium/forks","keys_url":"https://api.github.com/repos/platanus/potassium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/platanus/potassium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/platanus/potassium/teams","hooks_url":"https://api.github.com/repos/platanus/potassium/hooks","issue_events_url":"https://api.github.com/repos/platanus/potassium/issues/events{/number}","events_url":"https://api.github.com/repos/platanus/potassium/events","assignees_url":"https://api.github.com/repos/platanus/potassium/assignees{/user}","branches_url":"https://api.github.com/repos/platanus/potassium/branches{/branch}","tags_url":"https://api.github.com/repos/platanus/potassium/tags","blobs_url":"https://api.github.com/repos/platanus/potassium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/platanus/potassium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/platanus/potassium/git/refs{/sha}","trees_url":"https://api.github.com/repos/platanus/potassium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/platanus/potassium/statuses/{sha}","languages_url":"https://api.github.com/repos/platanus/potassium/languages","stargazers_url":"https://api.github.com/repos/platanus/potassium/stargazers","contributors_url":"https://api.github.com/repos/platanus/potassium/contributors","subscribers_url":"https://api.github.com/repos/platanus/potassium/subscribers","subscription_url":"https://api.github.com/repos/platanus/potassium/subscription","commits_url":"https://api.github.com/repos/platanus/potassium/commits{/sha}","git_commits_url":"https://api.github.com/repos/platanus/potassium/git/commits{/sha}","comments_url":"https://api.github.com/repos/platanus/potassium/comments{/number}","issue_comment_url":"https://api.github.com/repos/platanus/potassium/issues/comments{/number}","contents_url":"https://api.github.com/repos/platanus/potassium/contents/{+path}","compare_url":"https://api.github.com/repos/platanus/potassium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/platanus/potassium/merges","archive_url":"https://api.github.com/repos/platanus/potassium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/platanus/potassium/downloads","issues_url":"https://api.github.com/repos/platanus/potassium/issues{/number}","pulls_url":"https://api.github.com/repos/platanus/potassium/pulls{/number}","milestones_url":"https://api.github.com/repos/platanus/potassium/milestones{/number}","notifications_url":"https://api.github.com/repos/platanus/potassium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/platanus/potassium/labels{/name}","releases_url":"https://api.github.com/repos/platanus/potassium/releases{/id}","deployments_url":"https://api.github.com/repos/platanus/potassium/deployments","created_at":"2015-05-08T20:16:55Z","updated_at":"2017-06-30T02:50:08Z","pushed_at":"2017-09-01T16:11:06Z","git_url":"git://github.com/platanus/potassium.git","ssh_url":"[email protected]:platanus/potassium.git","clone_url":"https://github.com/platanus/potassium.git","svn_url":"https://github.com/platanus/potassium","homepage":"","size":414,"stargazers_count":15,"watchers_count":15,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":14,"forks":0,"open_issues":14,"watchers":15,"default_branch":"master"}},"base":{"label":"platanus:master","ref":"master","sha":"a2d55f93e2da2314314eac8e4ccab1745c789f5f","user":{"login":"platanus","id":1158740,"avatar_url":"https://avatars3.githubusercontent.com/u/1158740?v=4","gravatar_id":"","url":"https://api.github.com/users/platanus","html_url":"https://github.com/platanus","followers_url":"https://api.github.com/users/platanus/followers","following_url":"https://api.github.com/users/platanus/following{/other_user}","gists_url":"https://api.github.com/users/platanus/gists{/gist_id}","starred_url":"https://api.github.com/users/platanus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platanus/subscriptions","organizations_url":"https://api.github.com/users/platanus/orgs","repos_url":"https://api.github.com/users/platanus/repos","events_url":"https://api.github.com/users/platanus/events{/privacy}","received_events_url":"https://api.github.com/users/platanus/received_events","type":"Organization","site_admin":false},"repo":{"id":35299873,"name":"potassium","full_name":"platanus/potassium","owner":{"login":"platanus","id":1158740,"avatar_url":"https://avatars3.githubusercontent.com/u/1158740?v=4","gravatar_id":"","url":"https://api.github.com/users/platanus","html_url":"https://github.com/platanus","followers_url":"https://api.github.com/users/platanus/followers","following_url":"https://api.github.com/users/platanus/following{/other_user}","gists_url":"https://api.github.com/users/platanus/gists{/gist_id}","starred_url":"https://api.github.com/users/platanus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platanus/subscriptions","organizations_url":"https://api.github.com/users/platanus/orgs","repos_url":"https://api.github.com/users/platanus/repos","events_url":"https://api.github.com/users/platanus/events{/privacy}","received_events_url":"https://api.github.com/users/platanus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/platanus/potassium","description":"The father to every Platanus Rails proyect","fork":false,"url":"https://api.github.com/repos/platanus/potassium","forks_url":"https://api.github.com/repos/platanus/potassium/forks","keys_url":"https://api.github.com/repos/platanus/potassium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/platanus/potassium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/platanus/potassium/teams","hooks_url":"https://api.github.com/repos/platanus/potassium/hooks","issue_events_url":"https://api.github.com/repos/platanus/potassium/issues/events{/number}","events_url":"https://api.github.com/repos/platanus/potassium/events","assignees_url":"https://api.github.com/repos/platanus/potassium/assignees{/user}","branches_url":"https://api.github.com/repos/platanus/potassium/branches{/branch}","tags_url":"https://api.github.com/repos/platanus/potassium/tags","blobs_url":"https://api.github.com/repos/platanus/potassium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/platanus/potassium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/platanus/potassium/git/refs{/sha}","trees_url":"https://api.github.com/repos/platanus/potassium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/platanus/potassium/statuses/{sha}","languages_url":"https://api.github.com/repos/platanus/potassium/languages","stargazers_url":"https://api.github.com/repos/platanus/potassium/stargazers","contributors_url":"https://api.github.com/repos/platanus/potassium/contributors","subscribers_url":"https://api.github.com/repos/platanus/potassium/subscribers","subscription_url":"https://api.github.com/repos/platanus/potassium/subscription","commits_url":"https://api.github.com/repos/platanus/potassium/commits{/sha}","git_commits_url":"https://api.github.com/repos/platanus/potassium/git/commits{/sha}","comments_url":"https://api.github.com/repos/platanus/potassium/comments{/number}","issue_comment_url":"https://api.github.com/repos/platanus/potassium/issues/comments{/number}","contents_url":"https://api.github.com/repos/platanus/potassium/contents/{+path}","compare_url":"https://api.github.com/repos/platanus/potassium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/platanus/potassium/merges","archive_url":"https://api.github.com/repos/platanus/potassium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/platanus/potassium/downloads","issues_url":"https://api.github.com/repos/platanus/potassium/issues{/number}","pulls_url":"https://api.github.com/repos/platanus/potassium/pulls{/number}","milestones_url":"https://api.github.com/repos/platanus/potassium/milestones{/number}","notifications_url":"https://api.github.com/repos/platanus/potassium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/platanus/potassium/labels{/name}","releases_url":"https://api.github.com/repos/platanus/potassium/releases{/id}","deployments_url":"https://api.github.com/repos/platanus/potassium/deployments","created_at":"2015-05-08T20:16:55Z","updated_at":"2017-06-30T02:50:08Z","pushed_at":"2017-09-01T16:11:06Z","git_url":"git://github.com/platanus/potassium.git","ssh_url":"[email protected]:platanus/potassium.git","clone_url":"https://github.com/platanus/potassium.git","svn_url":"https://github.com/platanus/potassium","homepage":"","size":414,"stargazers_count":15,"watchers_count":15,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":14,"forks":0,"open_issues":14,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/platanus/potassium/pulls/148"},"html":{"href":"https://github.com/platanus/potassium/pull/148"},"issue":{"href":"https://api.github.com/repos/platanus/potassium/issues/148"},"comments":{"href":"https://api.github.com/repos/platanus/potassium/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/platanus/potassium/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/platanus/potassium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/platanus/potassium/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/platanus/potassium/statuses/144c84585f2aa49bdcc6d6a88315b5c5c4a51a5e"}},"author_association":"MEMBER"}} | {
"id": 35299873,
"name": "platanus/potassium",
"url": "https://api.github.com/repos/platanus/potassium"
} | {
"id": 3026413,
"login": "ldlsegovia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3026413?",
"url": "https://api.github.com/users/ldlsegovia"
} | {
"id": 1158740,
"login": "platanus",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1158740?",
"url": "https://api.github.com/orgs/platanus"
} | 2017-09-01T17:08:29 | 6540844065 | {"actor":{"display_login":"ldlsegovia"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/praekelt/molo/pulls/comments/129111606","pull_request_review_id":51851593,"id":129111606,"diff_hunk":"@@ -270,3 +285,122 @@ def copy_site_languages(self):\n locale=content['locale'],\n is_active=content['is_active'],\n language_setting=language_setting)\n+\n+ def fetch_and_create_image(self):\n+ # create image object\n+ # update self.image_map\n+ # return image\n+ pass\n+\n+ def attach_image(self):\n+ # if not (image has already been imported)\n+ # get_image()\n+ # attach image\n+ pass\n+\n+ def create_page(self, parent, content):\n+ print(\"creating 'new_id' with title: {} and parent {}\".format(\n+ content[\"title\"], parent.id))\n+\n+ fields, nested_fields = separate_fields(content)\n+\n+ # handle the unwanted fields\n+ foreign_id = content.pop('id')\n+\n+ page = None\n+ if content[\"meta\"][\"type\"] == \"core.SectionPage\":\n+ page = SectionPage(**fields)\n+ elif content[\"meta\"][\"type\"] == \"core.ArticlePage\":\n+ page = ArticlePage(**fields)\n+ # TODO: handle other Page types\n+\n+ parent.add_child(instance=page)\n+\n+ # TODO: handle live/published\n+ # Need to review this line:\n+ # handle drafts and 'not live' content\n+ parent.save_revision().publish()\n+\n+ self.id_map[foreign_id] = page.id\n+ print(\"PAGE ID IS {}\".format(page.id))\n+\n+ # time\n+ if ((\"time\" in nested_fields) and\n+ nested_fields[\"time\"]):\n+ page.time = json.dumps(nested_fields[\"time\"])\n+\n+ # section_tags/nav_tags\n+ # list -> [\"tag\"][\"id\"]\n+ # -> Need to fetch and create the nav tags\n+ # THEN create the link between page and nav_tag\n+ if ((\"section_tags\" in nested_fields) and\n+ nested_fields[\"section_tags\"]):\n+ self.section_tags[page.id] = []\n+ for section_tag in nested_fields[\"section_tags\"]:\n+ self.section_tags[page.id].append(\n+ section_tag[\"tag\"][\"id\"])\n+\n+ # nav_tags\n+ # list -> [\"tag\"][\"id\"]\n+ # -> Need to fetch and create the nav tags\n+ # THEN create the link between page and nav_tag\n+ if ((\"nav_tags\" in nested_fields) and\n+ nested_fields[\"nav_tags\"]):\n+ self.nav_tags[page.id] = []\n+ for nav_tag in nested_fields[\"nav_tags\"]:\n+ self.nav_tags[page.id].append(\n+ nav_tag[\"tag\"][\"id\"])\n+\n+ # reaction_questions\n+ # list -> [\"reaction_question\"][\"id\"]\n+ # -> Need to fetch and create the reaction questions\n+ # THEN create the link between page and reaction question\n+ if ((\"reaction_questions\" in nested_fields) and\n+ nested_fields[\"reaction_questions\"]):\n+ self.reaction_questions[page.id] = []\n+ for reaction_question in nested_fields[\"reaction_questions\"]:\n+ self.reaction_questions[page.id].append(\n+ reaction_question[\"reaction_question\"][\"id\"])\n+\n+ # recommended_articles\n+ # list -> [\"recommended_article\"][\"id\"]\n+ # -> Only need to create the relationship\n+ if ((\"recommended_articles\" in nested_fields) and\n+ nested_fields[\"recommended_articles\"]):\n+ self.recommended_articles[page.id] = []\n+ for recommended_article in nested_fields[\"recommended_articles\"]:\n+ self.recommended_articles[page.id].append(\n+ recommended_article[\"recommended_article\"][\"id\"])\n+\n+ # related_sections\n+ # list -> [\"section\"][\"id\"]\n+ # -> Only need to create the relationship\n+ if ((\"related_sections\" in nested_fields) and\n+ nested_fields[\"related_sections\"]):\n+ self.related_sections[page.id] = []\n+ for related_section in nested_fields[\"related_sections\"]:\n+ self.related_sections[page.id].append(\n+ related_section[\"section\"][\"id\"])\n+\n+ if (\"body\" in nested_fields) and nested_fields[\"body\"]:\n+ page.body = json.dumps(nested_fields[\"body\"])\n+\n+ if (\"tags\" in nested_fields) and nested_fields[\"tags\"]:\n+ for tag in nested_fields[\"tags\"]:\n+ page.tags.add(tag)\n+\n+ if ((\"metadata_tags\" in nested_fields) and\n+ nested_fields[\"metadata_tags\"]):\n+ for tag in nested_fields[\"metadata_tags\"]:\n+ page.metadata_tags.add(tag)\n+\n+ if ((\"social_media_image\" in nested_fields) and","path":"molo/core/api/importers.py","position":null,"original_position":135,"commit_id":"87ef05b0a32ed0988a4baec54c2bf58ad4d5b9d6","original_commit_id":"7c32895dd9a4b9dcb12e7f20e785aa9b88291a7e","user":{"login":"nathanbegbie","id":7100966,"avatar_url":"https://avatars0.githubusercontent.com/u/7100966?v=4","gravatar_id":"","url":"https://api.github.com/users/nathanbegbie","html_url":"https://github.com/nathanbegbie","followers_url":"https://api.github.com/users/nathanbegbie/followers","following_url":"https://api.github.com/users/nathanbegbie/following{/other_user}","gists_url":"https://api.github.com/users/nathanbegbie/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanbegbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanbegbie/subscriptions","organizations_url":"https://api.github.com/users/nathanbegbie/orgs","repos_url":"https://api.github.com/users/nathanbegbie/repos","events_url":"https://api.github.com/users/nathanbegbie/events{/privacy}","received_events_url":"https://api.github.com/users/nathanbegbie/received_events","type":"User","site_admin":false},"body":"I've refactored all of the other functions, but I'm going to leave the refactoring of the image functions to https://github.com/praekelt/molo/pull/418 as it explicitly deals with images and the implementation of those functions.","created_at":"2017-07-24T18:09:25Z","updated_at":"2017-07-24T18:09:25Z","html_url":"https://github.com/praekelt/molo/pull/411#discussion_r129111606","pull_request_url":"https://api.github.com/repos/praekelt/molo/pulls/411","_links":{"self":{"href":"https://api.github.com/repos/praekelt/molo/pulls/comments/129111606"},"html":{"href":"https://github.com/praekelt/molo/pull/411#discussion_r129111606"},"pull_request":{"href":"https://api.github.com/repos/praekelt/molo/pulls/411"}}},"pull_request":{"url":"https://api.github.com/repos/praekelt/molo/pulls/411","id":131063635,"html_url":"https://github.com/praekelt/molo/pull/411","diff_url":"https://github.com/praekelt/molo/pull/411.diff","patch_url":"https://github.com/praekelt/molo/pull/411.patch","issue_url":"https://api.github.com/repos/praekelt/molo/issues/411","number":411,"state":"open","locked":false,"title":"Add article and section import functionality","user":{"login":"nathanbegbie","id":7100966,"avatar_url":"https://avatars0.githubusercontent.com/u/7100966?v=4","gravatar_id":"","url":"https://api.github.com/users/nathanbegbie","html_url":"https://github.com/nathanbegbie","followers_url":"https://api.github.com/users/nathanbegbie/followers","following_url":"https://api.github.com/users/nathanbegbie/following{/other_user}","gists_url":"https://api.github.com/users/nathanbegbie/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanbegbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanbegbie/subscriptions","organizations_url":"https://api.github.com/users/nathanbegbie/orgs","repos_url":"https://api.github.com/users/nathanbegbie/repos","events_url":"https://api.github.com/users/nathanbegbie/events{/privacy}","received_events_url":"https://api.github.com/users/nathanbegbie/received_events","type":"User","site_admin":false},"body":"Dependent on https://github.com/praekelt/molo/pull/409\r\n\r\nThis PR achieves 2 things \r\n- the ability to read `ArticlePages` and `SectionPages` from the api\r\n- using that 'api-readable' structure, create `ArticlePages` and `SectionPages` from that data\r\n\r\nThere are 3 things that are not handled in the creation of a page or section:\r\n- Translations\r\n- relationships with other pages (e.g. Tags, Recommended Articles, Related Sections etc.)\r\n- Images\r\n\r\nThe framework is in place for this using the attributes on the `SiteImporter` class and this functionality will be added in a further PR.","created_at":"2017-07-18T11:27:51Z","updated_at":"2017-07-24T18:09:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed44a6e2640ce9fd81dfa44693c8b78af165889b","assignee":{"login":"nathanbegbie","id":7100966,"avatar_url":"https://avatars0.githubusercontent.com/u/7100966?v=4","gravatar_id":"","url":"https://api.github.com/users/nathanbegbie","html_url":"https://github.com/nathanbegbie","followers_url":"https://api.github.com/users/nathanbegbie/followers","following_url":"https://api.github.com/users/nathanbegbie/following{/other_user}","gists_url":"https://api.github.com/users/nathanbegbie/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanbegbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanbegbie/subscriptions","organizations_url":"https://api.github.com/users/nathanbegbie/orgs","repos_url":"https://api.github.com/users/nathanbegbie/repos","events_url":"https://api.github.com/users/nathanbegbie/events{/privacy}","received_events_url":"https://api.github.com/users/nathanbegbie/received_events","type":"User","site_admin":false},"assignees":[{"login":"nathanbegbie","id":7100966,"avatar_url":"https://avatars0.githubusercontent.com/u/7100966?v=4","gravatar_id":"","url":"https://api.github.com/users/nathanbegbie","html_url":"https://github.com/nathanbegbie","followers_url":"https://api.github.com/users/nathanbegbie/followers","following_url":"https://api.github.com/users/nathanbegbie/following{/other_user}","gists_url":"https://api.github.com/users/nathanbegbie/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanbegbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanbegbie/subscriptions","organizations_url":"https://api.github.com/users/nathanbegbie/orgs","repos_url":"https://api.github.com/users/nathanbegbie/repos","events_url":"https://api.github.com/users/nathanbegbie/events{/privacy}","received_events_url":"https://api.github.com/users/nathanbegbie/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/praekelt/molo/pulls/411/commits","review_comments_url":"https://api.github.com/repos/praekelt/molo/pulls/411/comments","review_comment_url":"https://api.github.com/repos/praekelt/molo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/praekelt/molo/issues/411/comments","statuses_url":"https://api.github.com/repos/praekelt/molo/statuses/87ef05b0a32ed0988a4baec54c2bf58ad4d5b9d6","head":{"label":"praekelt:add-article-and-section-import-functionality","ref":"add-article-and-section-import-functionality","sha":"87ef05b0a32ed0988a4baec54c2bf58ad4d5b9d6","user":{"login":"praekelt","id":81810,"avatar_url":"https://avatars2.githubusercontent.com/u/81810?v=4","gravatar_id":"","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"repo":{"id":36491915,"name":"molo","full_name":"praekelt/molo","owner":{"login":"praekelt","id":81810,"avatar_url":"https://avatars2.githubusercontent.com/u/81810?v=4","gravatar_id":"","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/praekelt/molo","description":"Molo is a set of tools for publishing low end mobi sites with a community focus.","fork":false,"url":"https://api.github.com/repos/praekelt/molo","forks_url":"https://api.github.com/repos/praekelt/molo/forks","keys_url":"https://api.github.com/repos/praekelt/molo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praekelt/molo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praekelt/molo/teams","hooks_url":"https://api.github.com/repos/praekelt/molo/hooks","issue_events_url":"https://api.github.com/repos/praekelt/molo/issues/events{/number}","events_url":"https://api.github.com/repos/praekelt/molo/events","assignees_url":"https://api.github.com/repos/praekelt/molo/assignees{/user}","branches_url":"https://api.github.com/repos/praekelt/molo/branches{/branch}","tags_url":"https://api.github.com/repos/praekelt/molo/tags","blobs_url":"https://api.github.com/repos/praekelt/molo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praekelt/molo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praekelt/molo/git/refs{/sha}","trees_url":"https://api.github.com/repos/praekelt/molo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praekelt/molo/statuses/{sha}","languages_url":"https://api.github.com/repos/praekelt/molo/languages","stargazers_url":"https://api.github.com/repos/praekelt/molo/stargazers","contributors_url":"https://api.github.com/repos/praekelt/molo/contributors","subscribers_url":"https://api.github.com/repos/praekelt/molo/subscribers","subscription_url":"https://api.github.com/repos/praekelt/molo/subscription","commits_url":"https://api.github.com/repos/praekelt/molo/commits{/sha}","git_commits_url":"https://api.github.com/repos/praekelt/molo/git/commits{/sha}","comments_url":"https://api.github.com/repos/praekelt/molo/comments{/number}","issue_comment_url":"https://api.github.com/repos/praekelt/molo/issues/comments{/number}","contents_url":"https://api.github.com/repos/praekelt/molo/contents/{+path}","compare_url":"https://api.github.com/repos/praekelt/molo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praekelt/molo/merges","archive_url":"https://api.github.com/repos/praekelt/molo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praekelt/molo/downloads","issues_url":"https://api.github.com/repos/praekelt/molo/issues{/number}","pulls_url":"https://api.github.com/repos/praekelt/molo/pulls{/number}","milestones_url":"https://api.github.com/repos/praekelt/molo/milestones{/number}","notifications_url":"https://api.github.com/repos/praekelt/molo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praekelt/molo/labels{/name}","releases_url":"https://api.github.com/repos/praekelt/molo/releases{/id}","deployments_url":"https://api.github.com/repos/praekelt/molo/deployments","created_at":"2015-05-29T08:38:53Z","updated_at":"2017-05-24T11:00:08Z","pushed_at":"2017-07-24T18:01:31Z","git_url":"git://github.com/praekelt/molo.git","ssh_url":"[email protected]:praekelt/molo.git","clone_url":"https://github.com/praekelt/molo.git","svn_url":"https://github.com/praekelt/molo","homepage":"http://molo.rtfd.org","size":14604,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":45,"forks":1,"open_issues":45,"watchers":17,"default_branch":"develop"}},"base":{"label":"praekelt:feature/api_work","ref":"feature/api_work","sha":"f022f05d55153ae6ff74fd52cce78832a64de900","user":{"login":"praekelt","id":81810,"avatar_url":"https://avatars2.githubusercontent.com/u/81810?v=4","gravatar_id":"","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"repo":{"id":36491915,"name":"molo","full_name":"praekelt/molo","owner":{"login":"praekelt","id":81810,"avatar_url":"https://avatars2.githubusercontent.com/u/81810?v=4","gravatar_id":"","url":"https://api.github.com/users/praekelt","html_url":"https://github.com/praekelt","followers_url":"https://api.github.com/users/praekelt/followers","following_url":"https://api.github.com/users/praekelt/following{/other_user}","gists_url":"https://api.github.com/users/praekelt/gists{/gist_id}","starred_url":"https://api.github.com/users/praekelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekelt/subscriptions","organizations_url":"https://api.github.com/users/praekelt/orgs","repos_url":"https://api.github.com/users/praekelt/repos","events_url":"https://api.github.com/users/praekelt/events{/privacy}","received_events_url":"https://api.github.com/users/praekelt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/praekelt/molo","description":"Molo is a set of tools for publishing low end mobi sites with a community focus.","fork":false,"url":"https://api.github.com/repos/praekelt/molo","forks_url":"https://api.github.com/repos/praekelt/molo/forks","keys_url":"https://api.github.com/repos/praekelt/molo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praekelt/molo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praekelt/molo/teams","hooks_url":"https://api.github.com/repos/praekelt/molo/hooks","issue_events_url":"https://api.github.com/repos/praekelt/molo/issues/events{/number}","events_url":"https://api.github.com/repos/praekelt/molo/events","assignees_url":"https://api.github.com/repos/praekelt/molo/assignees{/user}","branches_url":"https://api.github.com/repos/praekelt/molo/branches{/branch}","tags_url":"https://api.github.com/repos/praekelt/molo/tags","blobs_url":"https://api.github.com/repos/praekelt/molo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praekelt/molo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praekelt/molo/git/refs{/sha}","trees_url":"https://api.github.com/repos/praekelt/molo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praekelt/molo/statuses/{sha}","languages_url":"https://api.github.com/repos/praekelt/molo/languages","stargazers_url":"https://api.github.com/repos/praekelt/molo/stargazers","contributors_url":"https://api.github.com/repos/praekelt/molo/contributors","subscribers_url":"https://api.github.com/repos/praekelt/molo/subscribers","subscription_url":"https://api.github.com/repos/praekelt/molo/subscription","commits_url":"https://api.github.com/repos/praekelt/molo/commits{/sha}","git_commits_url":"https://api.github.com/repos/praekelt/molo/git/commits{/sha}","comments_url":"https://api.github.com/repos/praekelt/molo/comments{/number}","issue_comment_url":"https://api.github.com/repos/praekelt/molo/issues/comments{/number}","contents_url":"https://api.github.com/repos/praekelt/molo/contents/{+path}","compare_url":"https://api.github.com/repos/praekelt/molo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praekelt/molo/merges","archive_url":"https://api.github.com/repos/praekelt/molo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praekelt/molo/downloads","issues_url":"https://api.github.com/repos/praekelt/molo/issues{/number}","pulls_url":"https://api.github.com/repos/praekelt/molo/pulls{/number}","milestones_url":"https://api.github.com/repos/praekelt/molo/milestones{/number}","notifications_url":"https://api.github.com/repos/praekelt/molo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praekelt/molo/labels{/name}","releases_url":"https://api.github.com/repos/praekelt/molo/releases{/id}","deployments_url":"https://api.github.com/repos/praekelt/molo/deployments","created_at":"2015-05-29T08:38:53Z","updated_at":"2017-05-24T11:00:08Z","pushed_at":"2017-07-24T18:01:31Z","git_url":"git://github.com/praekelt/molo.git","ssh_url":"[email protected]:praekelt/molo.git","clone_url":"https://github.com/praekelt/molo.git","svn_url":"https://github.com/praekelt/molo","homepage":"http://molo.rtfd.org","size":14604,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":45,"forks":1,"open_issues":45,"watchers":17,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/praekelt/molo/pulls/411"},"html":{"href":"https://github.com/praekelt/molo/pull/411"},"issue":{"href":"https://api.github.com/repos/praekelt/molo/issues/411"},"comments":{"href":"https://api.github.com/repos/praekelt/molo/issues/411/comments"},"review_comments":{"href":"https://api.github.com/repos/praekelt/molo/pulls/411/comments"},"review_comment":{"href":"https://api.github.com/repos/praekelt/molo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/praekelt/molo/pulls/411/commits"},"statuses":{"href":"https://api.github.com/repos/praekelt/molo/statuses/87ef05b0a32ed0988a4baec54c2bf58ad4d5b9d6"}}}} | {
"id": 36491915,
"name": "praekelt/molo",
"url": "https://api.github.com/repos/praekelt/molo"
} | {
"id": 7100966,
"login": "nathanbegbie",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7100966?",
"url": "https://api.github.com/users/nathanbegbie"
} | {
"id": 81810,
"login": "praekelt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/81810?",
"url": "https://api.github.com/orgs/praekelt"
} | 2017-07-24T18:09:25 | 6317664833 | {"actor":{"display_login":"nathanbegbie"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/122087996","pull_request_review_id":44173244,"id":122087996,"diff_hunk":"@@ -0,0 +1,76 @@\n+/*\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package com.facebook.presto.connector.thrift;\n+\n+import com.facebook.presto.spi.ConnectorSplit;\n+import com.facebook.presto.spi.HostAddress;\n+import com.fasterxml.jackson.annotation.JsonCreator;\n+import com.fasterxml.jackson.annotation.JsonProperty;\n+import com.google.common.collect.ImmutableList;\n+\n+import java.util.List;\n+\n+import static com.facebook.presto.connector.thrift.api.utils.ByteUtils.summarize;\n+import static com.google.common.base.MoreObjects.toStringHelper;\n+import static java.util.Objects.requireNonNull;\n+\n+public class ThriftConnectorSplit\n+ implements ConnectorSplit\n+{\n+ private final byte[] splitId;","path":"presto-thrift-connector/src/main/java/com/facebook/presto/connector/thrift/ThriftConnectorSplit.java","position":null,"original_position":31,"commit_id":"9644fb319d37a3c8fbfe0d99196b88300221258c","original_commit_id":"c56b053a674a248936882a99d308981b714aaca8","user":{"login":"AlekseiS","id":6320556,"avatar_url":"https://avatars2.githubusercontent.com/u/6320556?v=3","gravatar_id":"","url":"https://api.github.com/users/AlekseiS","html_url":"https://github.com/AlekseiS","followers_url":"https://api.github.com/users/AlekseiS/followers","following_url":"https://api.github.com/users/AlekseiS/following{/other_user}","gists_url":"https://api.github.com/users/AlekseiS/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseiS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseiS/subscriptions","organizations_url":"https://api.github.com/users/AlekseiS/orgs","repos_url":"https://api.github.com/users/AlekseiS/repos","events_url":"https://api.github.com/users/AlekseiS/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseiS/received_events","type":"User","site_admin":false},"body":"It's already done in the latest version.","created_at":"2017-06-14T23:20:23Z","updated_at":"2017-06-14T23:20:23Z","html_url":"https://github.com/prestodb/presto/pull/7119#discussion_r122087996","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/7119","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/122087996"},"html":{"href":"https://github.com/prestodb/presto/pull/7119#discussion_r122087996"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/7119"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/7119","id":101991282,"html_url":"https://github.com/prestodb/presto/pull/7119","diff_url":"https://github.com/prestodb/presto/pull/7119.diff","patch_url":"https://github.com/prestodb/presto/pull/7119.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/7119","number":7119,"state":"open","locked":false,"title":"Initial commit for Thrift connector","user":{"login":"AlekseiS","id":6320556,"avatar_url":"https://avatars2.githubusercontent.com/u/6320556?v=3","gravatar_id":"","url":"https://api.github.com/users/AlekseiS","html_url":"https://github.com/AlekseiS","followers_url":"https://api.github.com/users/AlekseiS/followers","following_url":"https://api.github.com/users/AlekseiS/following{/other_user}","gists_url":"https://api.github.com/users/AlekseiS/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseiS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseiS/subscriptions","organizations_url":"https://api.github.com/users/AlekseiS/orgs","repos_url":"https://api.github.com/users/AlekseiS/repos","events_url":"https://api.github.com/users/AlekseiS/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseiS/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-18T03:03:07Z","updated_at":"2017-06-14T23:20:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb403f0b5fd3e78e35cfcb810e90ad0211dc2cd5","assignee":{"login":"AlekseiS","id":6320556,"avatar_url":"https://avatars2.githubusercontent.com/u/6320556?v=3","gravatar_id":"","url":"https://api.github.com/users/AlekseiS","html_url":"https://github.com/AlekseiS","followers_url":"https://api.github.com/users/AlekseiS/followers","following_url":"https://api.github.com/users/AlekseiS/following{/other_user}","gists_url":"https://api.github.com/users/AlekseiS/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseiS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseiS/subscriptions","organizations_url":"https://api.github.com/users/AlekseiS/orgs","repos_url":"https://api.github.com/users/AlekseiS/repos","events_url":"https://api.github.com/users/AlekseiS/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseiS/received_events","type":"User","site_admin":false},"assignees":[{"login":"AlekseiS","id":6320556,"avatar_url":"https://avatars2.githubusercontent.com/u/6320556?v=3","gravatar_id":"","url":"https://api.github.com/users/AlekseiS","html_url":"https://github.com/AlekseiS","followers_url":"https://api.github.com/users/AlekseiS/followers","following_url":"https://api.github.com/users/AlekseiS/following{/other_user}","gists_url":"https://api.github.com/users/AlekseiS/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseiS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseiS/subscriptions","organizations_url":"https://api.github.com/users/AlekseiS/orgs","repos_url":"https://api.github.com/users/AlekseiS/repos","events_url":"https://api.github.com/users/AlekseiS/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseiS/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/7119/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/7119/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/7119/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/9644fb319d37a3c8fbfe0d99196b88300221258c","head":{"label":"AlekseiS:initial-thrift","ref":"initial-thrift","sha":"9644fb319d37a3c8fbfe0d99196b88300221258c","user":{"login":"AlekseiS","id":6320556,"avatar_url":"https://avatars2.githubusercontent.com/u/6320556?v=3","gravatar_id":"","url":"https://api.github.com/users/AlekseiS","html_url":"https://github.com/AlekseiS","followers_url":"https://api.github.com/users/AlekseiS/followers","following_url":"https://api.github.com/users/AlekseiS/following{/other_user}","gists_url":"https://api.github.com/users/AlekseiS/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseiS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseiS/subscriptions","organizations_url":"https://api.github.com/users/AlekseiS/orgs","repos_url":"https://api.github.com/users/AlekseiS/repos","events_url":"https://api.github.com/users/AlekseiS/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseiS/received_events","type":"User","site_admin":false},"repo":{"id":66317591,"name":"presto","full_name":"AlekseiS/presto","owner":{"login":"AlekseiS","id":6320556,"avatar_url":"https://avatars2.githubusercontent.com/u/6320556?v=3","gravatar_id":"","url":"https://api.github.com/users/AlekseiS","html_url":"https://github.com/AlekseiS","followers_url":"https://api.github.com/users/AlekseiS/followers","following_url":"https://api.github.com/users/AlekseiS/following{/other_user}","gists_url":"https://api.github.com/users/AlekseiS/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseiS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseiS/subscriptions","organizations_url":"https://api.github.com/users/AlekseiS/orgs","repos_url":"https://api.github.com/users/AlekseiS/repos","events_url":"https://api.github.com/users/AlekseiS/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseiS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlekseiS/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/AlekseiS/presto","forks_url":"https://api.github.com/repos/AlekseiS/presto/forks","keys_url":"https://api.github.com/repos/AlekseiS/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlekseiS/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlekseiS/presto/teams","hooks_url":"https://api.github.com/repos/AlekseiS/presto/hooks","issue_events_url":"https://api.github.com/repos/AlekseiS/presto/issues/events{/number}","events_url":"https://api.github.com/repos/AlekseiS/presto/events","assignees_url":"https://api.github.com/repos/AlekseiS/presto/assignees{/user}","branches_url":"https://api.github.com/repos/AlekseiS/presto/branches{/branch}","tags_url":"https://api.github.com/repos/AlekseiS/presto/tags","blobs_url":"https://api.github.com/repos/AlekseiS/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlekseiS/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlekseiS/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlekseiS/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlekseiS/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/AlekseiS/presto/languages","stargazers_url":"https://api.github.com/repos/AlekseiS/presto/stargazers","contributors_url":"https://api.github.com/repos/AlekseiS/presto/contributors","subscribers_url":"https://api.github.com/repos/AlekseiS/presto/subscribers","subscription_url":"https://api.github.com/repos/AlekseiS/presto/subscription","commits_url":"https://api.github.com/repos/AlekseiS/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlekseiS/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlekseiS/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlekseiS/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlekseiS/presto/contents/{+path}","compare_url":"https://api.github.com/repos/AlekseiS/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlekseiS/presto/merges","archive_url":"https://api.github.com/repos/AlekseiS/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlekseiS/presto/downloads","issues_url":"https://api.github.com/repos/AlekseiS/presto/issues{/number}","pulls_url":"https://api.github.com/repos/AlekseiS/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/AlekseiS/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/AlekseiS/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlekseiS/presto/labels{/name}","releases_url":"https://api.github.com/repos/AlekseiS/presto/releases{/id}","deployments_url":"https://api.github.com/repos/AlekseiS/presto/deployments","created_at":"2016-08-23T00:13:30Z","updated_at":"2016-08-23T00:13:45Z","pushed_at":"2017-06-14T21:29:29Z","git_url":"git://github.com/AlekseiS/presto.git","ssh_url":"[email protected]:AlekseiS/presto.git","clone_url":"https://github.com/AlekseiS/presto.git","svn_url":"https://github.com/AlekseiS/presto","homepage":"https://prestodb.io","size":74392,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"12188921904004d969423e2181930773f731c851","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars3.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars3.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2017-06-14T22:59:59Z","pushed_at":"2017-06-14T22:50:41Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"[email protected]:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":74274,"stargazers_count":6136,"watchers_count":6136,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1987,"mirror_url":null,"open_issues_count":960,"forks":1987,"open_issues":960,"watchers":6136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/7119"},"html":{"href":"https://github.com/prestodb/presto/pull/7119"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/7119"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/7119/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/7119/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/7119/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/9644fb319d37a3c8fbfe0d99196b88300221258c"}}}} | {
"id": 5349565,
"name": "prestodb/presto",
"url": "https://api.github.com/repos/prestodb/presto"
} | {
"id": 6320556,
"login": "AlekseiS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6320556?",
"url": "https://api.github.com/users/AlekseiS"
} | {
"id": 6882181,
"login": "prestodb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6882181?",
"url": "https://api.github.com/orgs/prestodb"
} | 2017-06-14T23:20:23 | 6068322717 | {"actor":{"display_login":"AlekseiS"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/113019388","pull_request_review_id":34377384,"id":113019388,"diff_hunk":"@@ -0,0 +1,246 @@\n+/*\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package com.facebook.presto.tpcds;\n+\n+import com.facebook.presto.spi.ColumnHandle;\n+import com.facebook.presto.spi.ColumnMetadata;\n+import com.facebook.presto.spi.ConnectorSession;\n+import com.facebook.presto.spi.ConnectorTableHandle;\n+import com.facebook.presto.spi.ConnectorTableLayout;\n+import com.facebook.presto.spi.ConnectorTableLayoutHandle;\n+import com.facebook.presto.spi.ConnectorTableLayoutResult;\n+import com.facebook.presto.spi.ConnectorTableMetadata;\n+import com.facebook.presto.spi.Constraint;\n+import com.facebook.presto.spi.SchemaTableName;\n+import com.facebook.presto.spi.SchemaTablePrefix;\n+import com.facebook.presto.spi.connector.ConnectorMetadata;\n+import com.facebook.presto.spi.predicate.TupleDomain;\n+import com.facebook.presto.spi.type.BigintType;\n+import com.facebook.presto.spi.type.DateType;\n+import com.facebook.presto.spi.type.IntegerType;\n+import com.facebook.presto.spi.type.TimeType;\n+import com.facebook.presto.spi.type.Type;\n+import com.google.common.collect.ImmutableList;\n+import com.google.common.collect.ImmutableMap;\n+import com.google.common.collect.ImmutableSet;\n+import com.teradata.tpcds.Table;\n+import com.teradata.tpcds.column.Column;\n+import com.teradata.tpcds.column.ColumnType;\n+\n+import java.util.List;\n+import java.util.Map;\n+import java.util.Optional;\n+import java.util.Set;\n+\n+import static com.facebook.presto.spi.type.CharType.createCharType;\n+import static com.facebook.presto.spi.type.DecimalType.createDecimalType;\n+import static com.facebook.presto.spi.type.VarcharType.createVarcharType;\n+import static com.facebook.presto.tpcds.Types.checkType;\n+import static java.lang.String.format;\n+import static java.util.Locale.ENGLISH;\n+import static java.util.Objects.requireNonNull;\n+\n+public class TpcdsMetadata\n+ implements ConnectorMetadata\n+{\n+ public static final List<String> SCHEMA_NAMES = ImmutableList.of(\n+ \"sf1\", \"sf10\", \"sf100\", \"sf300\", \"sf1000\", \"sf3000\", \"sf10000\", \"sf30000\", \"sf100000\");\n+\n+ private final Set<String> tableNames;\n+\n+ public TpcdsMetadata()\n+ {\n+ ImmutableSet.Builder<String> tableNames = ImmutableSet.builder();\n+ for (Table tpcdsTable : Table.getBaseTables()) {\n+ tableNames.add(tpcdsTable.getName().toLowerCase(ENGLISH));\n+ }\n+ this.tableNames = tableNames.build();\n+ }\n+\n+ @Override\n+ public List<String> listSchemaNames(ConnectorSession session)\n+ {\n+ return SCHEMA_NAMES;\n+ }\n+\n+ @Override\n+ public ConnectorTableHandle getTableHandle(ConnectorSession session, SchemaTableName tableName)\n+ {\n+ requireNonNull(tableName, \"tableName is null\");\n+ if (!tableNames.contains(tableName.getTableName())) {\n+ return null;\n+ }\n+\n+ // parse the scale factor\n+ int scaleFactor = schemaNameToScaleFactor(tableName.getSchemaName());\n+ if (scaleFactor < 0) {\n+ return null;\n+ }\n+\n+ return new TpcdsTableHandle(tableName.getTableName(), scaleFactor);\n+ }\n+\n+ @Override\n+ public List<ConnectorTableLayoutResult> getTableLayouts(\n+ ConnectorSession session,\n+ ConnectorTableHandle table,\n+ Constraint<ColumnHandle> constraint,\n+ Optional<Set<ColumnHandle>> desiredColumns)\n+ {\n+ TpcdsTableHandle tableHandle = checkType(table, TpcdsTableHandle.class, \"table\");","path":"presto-tpcds/src/main/java/com/facebook/presto/tpcds/TpcdsMetadata.java","position":101,"original_position":101,"commit_id":"5ff00214074992641a6ae8533274df239b4437ed","original_commit_id":"5ff00214074992641a6ae8533274df239b4437ed","user":{"login":"petroav","id":665991,"avatar_url":"https://avatars2.githubusercontent.com/u/665991?v=3","gravatar_id":"","url":"https://api.github.com/users/petroav","html_url":"https://github.com/petroav","followers_url":"https://api.github.com/users/petroav/followers","following_url":"https://api.github.com/users/petroav/following{/other_user}","gists_url":"https://api.github.com/users/petroav/gists{/gist_id}","starred_url":"https://api.github.com/users/petroav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petroav/subscriptions","organizations_url":"https://api.github.com/users/petroav/orgs","repos_url":"https://api.github.com/users/petroav/repos","events_url":"https://api.github.com/users/petroav/events{/privacy}","received_events_url":"https://api.github.com/users/petroav/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-04-24T18:19:44Z","updated_at":"2017-04-24T18:19:44Z","html_url":"https://github.com/prestodb/presto/pull/6374#discussion_r113019388","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/6374","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/113019388"},"html":{"href":"https://github.com/prestodb/presto/pull/6374#discussion_r113019388"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/6374"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/6374","id":89687365,"html_url":"https://github.com/prestodb/presto/pull/6374","diff_url":"https://github.com/prestodb/presto/pull/6374.diff","patch_url":"https://github.com/prestodb/presto/pull/6374.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/6374","number":6374,"state":"open","locked":false,"title":"TPCDS connector","user":{"login":"petroav","id":665991,"avatar_url":"https://avatars2.githubusercontent.com/u/665991?v=3","gravatar_id":"","url":"https://api.github.com/users/petroav","html_url":"https://github.com/petroav","followers_url":"https://api.github.com/users/petroav/followers","following_url":"https://api.github.com/users/petroav/following{/other_user}","gists_url":"https://api.github.com/users/petroav/gists{/gist_id}","starred_url":"https://api.github.com/users/petroav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petroav/subscriptions","organizations_url":"https://api.github.com/users/petroav/orgs","repos_url":"https://api.github.com/users/petroav/repos","events_url":"https://api.github.com/users/petroav/events{/privacy}","received_events_url":"https://api.github.com/users/petroav/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-17T19:33:47Z","updated_at":"2017-04-24T18:19:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66351905e6eb313d37868ee51f8d0419f5e92855","assignee":{"login":"petroav","id":665991,"avatar_url":"https://avatars2.githubusercontent.com/u/665991?v=3","gravatar_id":"","url":"https://api.github.com/users/petroav","html_url":"https://github.com/petroav","followers_url":"https://api.github.com/users/petroav/followers","following_url":"https://api.github.com/users/petroav/following{/other_user}","gists_url":"https://api.github.com/users/petroav/gists{/gist_id}","starred_url":"https://api.github.com/users/petroav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petroav/subscriptions","organizations_url":"https://api.github.com/users/petroav/orgs","repos_url":"https://api.github.com/users/petroav/repos","events_url":"https://api.github.com/users/petroav/events{/privacy}","received_events_url":"https://api.github.com/users/petroav/received_events","type":"User","site_admin":false},"assignees":[{"login":"petroav","id":665991,"avatar_url":"https://avatars2.githubusercontent.com/u/665991?v=3","gravatar_id":"","url":"https://api.github.com/users/petroav","html_url":"https://github.com/petroav","followers_url":"https://api.github.com/users/petroav/followers","following_url":"https://api.github.com/users/petroav/following{/other_user}","gists_url":"https://api.github.com/users/petroav/gists{/gist_id}","starred_url":"https://api.github.com/users/petroav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petroav/subscriptions","organizations_url":"https://api.github.com/users/petroav/orgs","repos_url":"https://api.github.com/users/petroav/repos","events_url":"https://api.github.com/users/petroav/events{/privacy}","received_events_url":"https://api.github.com/users/petroav/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/6374/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/6374/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/6374/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/5ff00214074992641a6ae8533274df239b4437ed","head":{"label":"Teradata:tpcds-connector","ref":"tpcds-connector","sha":"5ff00214074992641a6ae8533274df239b4437ed","user":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars2.githubusercontent.com/u/1615979?v=3","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"repo":{"id":36903368,"name":"presto","full_name":"Teradata/presto","owner":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars2.githubusercontent.com/u/1615979?v=3","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Teradata/presto","description":"Teradata Distribution of Presto -- A Distributed SQL Query Engine for Big Data","fork":true,"url":"https://api.github.com/repos/Teradata/presto","forks_url":"https://api.github.com/repos/Teradata/presto/forks","keys_url":"https://api.github.com/repos/Teradata/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Teradata/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Teradata/presto/teams","hooks_url":"https://api.github.com/repos/Teradata/presto/hooks","issue_events_url":"https://api.github.com/repos/Teradata/presto/issues/events{/number}","events_url":"https://api.github.com/repos/Teradata/presto/events","assignees_url":"https://api.github.com/repos/Teradata/presto/assignees{/user}","branches_url":"https://api.github.com/repos/Teradata/presto/branches{/branch}","tags_url":"https://api.github.com/repos/Teradata/presto/tags","blobs_url":"https://api.github.com/repos/Teradata/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Teradata/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Teradata/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Teradata/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Teradata/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/Teradata/presto/languages","stargazers_url":"https://api.github.com/repos/Teradata/presto/stargazers","contributors_url":"https://api.github.com/repos/Teradata/presto/contributors","subscribers_url":"https://api.github.com/repos/Teradata/presto/subscribers","subscription_url":"https://api.github.com/repos/Teradata/presto/subscription","commits_url":"https://api.github.com/repos/Teradata/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Teradata/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Teradata/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Teradata/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Teradata/presto/contents/{+path}","compare_url":"https://api.github.com/repos/Teradata/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Teradata/presto/merges","archive_url":"https://api.github.com/repos/Teradata/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Teradata/presto/downloads","issues_url":"https://api.github.com/repos/Teradata/presto/issues{/number}","pulls_url":"https://api.github.com/repos/Teradata/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/Teradata/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/Teradata/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Teradata/presto/labels{/name}","releases_url":"https://api.github.com/repos/Teradata/presto/releases{/id}","deployments_url":"https://api.github.com/repos/Teradata/presto/deployments","created_at":"2015-06-05T00:38:37Z","updated_at":"2017-04-21T15:45:48Z","pushed_at":"2017-04-24T18:12:30Z","git_url":"git://github.com/Teradata/presto.git","ssh_url":"[email protected]:Teradata/presto.git","clone_url":"https://github.com/Teradata/presto.git","svn_url":"https://github.com/Teradata/presto","homepage":"http://www.teradata.com/presto","size":183205,"stargazers_count":73,"watchers_count":73,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":22,"forks":19,"open_issues":22,"watchers":73,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"cb24ac877e0587555bbcb590bbfe725201a71954","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars3.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars3.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2017-04-24T17:50:05Z","pushed_at":"2017-04-24T18:09:30Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"[email protected]:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":71112,"stargazers_count":5902,"watchers_count":5902,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1905,"mirror_url":null,"open_issues_count":898,"forks":1905,"open_issues":898,"watchers":5902,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/6374"},"html":{"href":"https://github.com/prestodb/presto/pull/6374"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/6374"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/6374/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/6374/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/6374/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/5ff00214074992641a6ae8533274df239b4437ed"}}}} | {
"id": 5349565,
"name": "prestodb/presto",
"url": "https://api.github.com/repos/prestodb/presto"
} | {
"id": 665991,
"login": "petroav",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/665991?",
"url": "https://api.github.com/users/petroav"
} | {
"id": 6882181,
"login": "prestodb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6882181?",
"url": "https://api.github.com/orgs/prestodb"
} | 2017-04-24T18:19:44 | 5746217184 | {"actor":{"display_login":"petroav"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/scylladb/scylla-code-samples/pulls/comments/124770092","pull_request_review_id":47090376,"id":124770092,"diff_hunk":"@@ -0,0 +1,59 @@\n+General info and prerequisites\n+==============================\n+\n+This ansible script will deploy, install and configure ScyllaDB on all supported OS.\n+- RHEL7\n+- Centos7\n+- Ubuntu 14.04\n+- Ubuntu 16.04\n+- Debian 8\n+\n+Prerequisites:\n+- Ansible 2.3\n+- Python 2.7\n+\n+\n+Instructions\n+============\n+\n+This playbook assumes you are installing Scylla using the same disks and NIC for all nodes","path":"deploy_and_install_scylla_ansible_script/README.md","position":19,"original_position":19,"commit_id":"30fc6417b724d3bb1d387e509353e5472061a4c3","original_commit_id":"62e92ffd352adf2e2e22405c70068f29de50bbdb","user":{"login":"tzach","id":170200,"avatar_url":"https://avatars2.githubusercontent.com/u/170200?v=3","gravatar_id":"","url":"https://api.github.com/users/tzach","html_url":"https://github.com/tzach","followers_url":"https://api.github.com/users/tzach/followers","following_url":"https://api.github.com/users/tzach/following{/other_user}","gists_url":"https://api.github.com/users/tzach/gists{/gist_id}","starred_url":"https://api.github.com/users/tzach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzach/subscriptions","organizations_url":"https://api.github.com/users/tzach/orgs","repos_url":"https://api.github.com/users/tzach/repos","events_url":"https://api.github.com/users/tzach/events{/privacy}","received_events_url":"https://api.github.com/users/tzach/received_events","type":"User","site_admin":false},"body":"The example file is server_example.ini, but the READ use servers.ini\r\nPlease fix one","created_at":"2017-06-29T11:00:49Z","updated_at":"2017-06-29T11:00:49Z","html_url":"https://github.com/scylladb/scylla-code-samples/pull/5#discussion_r124770092","pull_request_url":"https://api.github.com/repos/scylladb/scylla-code-samples/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/scylladb/scylla-code-samples/pulls/comments/124770092"},"html":{"href":"https://github.com/scylladb/scylla-code-samples/pull/5#discussion_r124770092"},"pull_request":{"href":"https://api.github.com/repos/scylladb/scylla-code-samples/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/scylladb/scylla-code-samples/pulls/5","id":127650517,"html_url":"https://github.com/scylladb/scylla-code-samples/pull/5","diff_url":"https://github.com/scylladb/scylla-code-samples/pull/5.diff","patch_url":"https://github.com/scylladb/scylla-code-samples/pull/5.patch","issue_url":"https://api.github.com/repos/scylladb/scylla-code-samples/issues/5","number":5,"state":"open","locked":false,"title":"adding scylla_deployment_ansible_script","user":{"login":"tomer-sandler","id":25585995,"avatar_url":"https://avatars1.githubusercontent.com/u/25585995?v=3","gravatar_id":"","url":"https://api.github.com/users/tomer-sandler","html_url":"https://github.com/tomer-sandler","followers_url":"https://api.github.com/users/tomer-sandler/followers","following_url":"https://api.github.com/users/tomer-sandler/following{/other_user}","gists_url":"https://api.github.com/users/tomer-sandler/gists{/gist_id}","starred_url":"https://api.github.com/users/tomer-sandler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomer-sandler/subscriptions","organizations_url":"https://api.github.com/users/tomer-sandler/orgs","repos_url":"https://api.github.com/users/tomer-sandler/repos","events_url":"https://api.github.com/users/tomer-sandler/events{/privacy}","received_events_url":"https://api.github.com/users/tomer-sandler/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-27T09:36:48Z","updated_at":"2017-06-29T11:00:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad2892acded0eb5bf19c46148ed4b11e9de154d9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/scylladb/scylla-code-samples/pulls/5/commits","review_comments_url":"https://api.github.com/repos/scylladb/scylla-code-samples/pulls/5/comments","review_comment_url":"https://api.github.com/repos/scylladb/scylla-code-samples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scylladb/scylla-code-samples/issues/5/comments","statuses_url":"https://api.github.com/repos/scylladb/scylla-code-samples/statuses/30fc6417b724d3bb1d387e509353e5472061a4c3","head":{"label":"tomer-sandler:master","ref":"master","sha":"30fc6417b724d3bb1d387e509353e5472061a4c3","user":{"login":"tomer-sandler","id":25585995,"avatar_url":"https://avatars1.githubusercontent.com/u/25585995?v=3","gravatar_id":"","url":"https://api.github.com/users/tomer-sandler","html_url":"https://github.com/tomer-sandler","followers_url":"https://api.github.com/users/tomer-sandler/followers","following_url":"https://api.github.com/users/tomer-sandler/following{/other_user}","gists_url":"https://api.github.com/users/tomer-sandler/gists{/gist_id}","starred_url":"https://api.github.com/users/tomer-sandler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomer-sandler/subscriptions","organizations_url":"https://api.github.com/users/tomer-sandler/orgs","repos_url":"https://api.github.com/users/tomer-sandler/repos","events_url":"https://api.github.com/users/tomer-sandler/events{/privacy}","received_events_url":"https://api.github.com/users/tomer-sandler/received_events","type":"User","site_admin":false},"repo":{"id":84710007,"name":"scylla-code-samples","full_name":"tomer-sandler/scylla-code-samples","owner":{"login":"tomer-sandler","id":25585995,"avatar_url":"https://avatars1.githubusercontent.com/u/25585995?v=3","gravatar_id":"","url":"https://api.github.com/users/tomer-sandler","html_url":"https://github.com/tomer-sandler","followers_url":"https://api.github.com/users/tomer-sandler/followers","following_url":"https://api.github.com/users/tomer-sandler/following{/other_user}","gists_url":"https://api.github.com/users/tomer-sandler/gists{/gist_id}","starred_url":"https://api.github.com/users/tomer-sandler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomer-sandler/subscriptions","organizations_url":"https://api.github.com/users/tomer-sandler/orgs","repos_url":"https://api.github.com/users/tomer-sandler/repos","events_url":"https://api.github.com/users/tomer-sandler/events{/privacy}","received_events_url":"https://api.github.com/users/tomer-sandler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomer-sandler/scylla-code-samples","description":"Code samples for working with ScyllaDB","fork":true,"url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples","forks_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/forks","keys_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/teams","hooks_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/hooks","issue_events_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/issues/events{/number}","events_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/events","assignees_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/assignees{/user}","branches_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/branches{/branch}","tags_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/tags","blobs_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/languages","stargazers_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/stargazers","contributors_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/contributors","subscribers_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/subscribers","subscription_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/subscription","commits_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/contents/{+path}","compare_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/merges","archive_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/downloads","issues_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/issues{/number}","pulls_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/labels{/name}","releases_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/releases{/id}","deployments_url":"https://api.github.com/repos/tomer-sandler/scylla-code-samples/deployments","created_at":"2017-03-12T08:04:44Z","updated_at":"2017-03-12T08:19:32Z","pushed_at":"2017-06-27T17:31:54Z","git_url":"git://github.com/tomer-sandler/scylla-code-samples.git","ssh_url":"[email protected]:tomer-sandler/scylla-code-samples.git","clone_url":"https://github.com/tomer-sandler/scylla-code-samples.git","svn_url":"https://github.com/tomer-sandler/scylla-code-samples","homepage":null,"size":20,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scylladb:master","ref":"master","sha":"571e93777af7fd566abc06011ae32f07110c402f","user":{"login":"scylladb","id":14364730,"avatar_url":"https://avatars1.githubusercontent.com/u/14364730?v=3","gravatar_id":"","url":"https://api.github.com/users/scylladb","html_url":"https://github.com/scylladb","followers_url":"https://api.github.com/users/scylladb/followers","following_url":"https://api.github.com/users/scylladb/following{/other_user}","gists_url":"https://api.github.com/users/scylladb/gists{/gist_id}","starred_url":"https://api.github.com/users/scylladb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scylladb/subscriptions","organizations_url":"https://api.github.com/users/scylladb/orgs","repos_url":"https://api.github.com/users/scylladb/repos","events_url":"https://api.github.com/users/scylladb/events{/privacy}","received_events_url":"https://api.github.com/users/scylladb/received_events","type":"Organization","site_admin":false},"repo":{"id":83970554,"name":"scylla-code-samples","full_name":"scylladb/scylla-code-samples","owner":{"login":"scylladb","id":14364730,"avatar_url":"https://avatars1.githubusercontent.com/u/14364730?v=3","gravatar_id":"","url":"https://api.github.com/users/scylladb","html_url":"https://github.com/scylladb","followers_url":"https://api.github.com/users/scylladb/followers","following_url":"https://api.github.com/users/scylladb/following{/other_user}","gists_url":"https://api.github.com/users/scylladb/gists{/gist_id}","starred_url":"https://api.github.com/users/scylladb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scylladb/subscriptions","organizations_url":"https://api.github.com/users/scylladb/orgs","repos_url":"https://api.github.com/users/scylladb/repos","events_url":"https://api.github.com/users/scylladb/events{/privacy}","received_events_url":"https://api.github.com/users/scylladb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scylladb/scylla-code-samples","description":"Code samples for working with ScyllaDB","fork":false,"url":"https://api.github.com/repos/scylladb/scylla-code-samples","forks_url":"https://api.github.com/repos/scylladb/scylla-code-samples/forks","keys_url":"https://api.github.com/repos/scylladb/scylla-code-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scylladb/scylla-code-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scylladb/scylla-code-samples/teams","hooks_url":"https://api.github.com/repos/scylladb/scylla-code-samples/hooks","issue_events_url":"https://api.github.com/repos/scylladb/scylla-code-samples/issues/events{/number}","events_url":"https://api.github.com/repos/scylladb/scylla-code-samples/events","assignees_url":"https://api.github.com/repos/scylladb/scylla-code-samples/assignees{/user}","branches_url":"https://api.github.com/repos/scylladb/scylla-code-samples/branches{/branch}","tags_url":"https://api.github.com/repos/scylladb/scylla-code-samples/tags","blobs_url":"https://api.github.com/repos/scylladb/scylla-code-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scylladb/scylla-code-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scylladb/scylla-code-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/scylladb/scylla-code-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scylladb/scylla-code-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/scylladb/scylla-code-samples/languages","stargazers_url":"https://api.github.com/repos/scylladb/scylla-code-samples/stargazers","contributors_url":"https://api.github.com/repos/scylladb/scylla-code-samples/contributors","subscribers_url":"https://api.github.com/repos/scylladb/scylla-code-samples/subscribers","subscription_url":"https://api.github.com/repos/scylladb/scylla-code-samples/subscription","commits_url":"https://api.github.com/repos/scylladb/scylla-code-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/scylladb/scylla-code-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/scylladb/scylla-code-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/scylladb/scylla-code-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/scylladb/scylla-code-samples/contents/{+path}","compare_url":"https://api.github.com/repos/scylladb/scylla-code-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scylladb/scylla-code-samples/merges","archive_url":"https://api.github.com/repos/scylladb/scylla-code-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scylladb/scylla-code-samples/downloads","issues_url":"https://api.github.com/repos/scylladb/scylla-code-samples/issues{/number}","pulls_url":"https://api.github.com/repos/scylladb/scylla-code-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/scylladb/scylla-code-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/scylladb/scylla-code-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scylladb/scylla-code-samples/labels{/name}","releases_url":"https://api.github.com/repos/scylladb/scylla-code-samples/releases{/id}","deployments_url":"https://api.github.com/repos/scylladb/scylla-code-samples/deployments","created_at":"2017-03-05T13:07:03Z","updated_at":"2017-05-24T06:09:23Z","pushed_at":"2017-06-27T17:31:55Z","git_url":"git://github.com/scylladb/scylla-code-samples.git","ssh_url":"[email protected]:scylladb/scylla-code-samples.git","clone_url":"https://github.com/scylladb/scylla-code-samples.git","svn_url":"https://github.com/scylladb/scylla-code-samples","homepage":null,"size":44,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scylladb/scylla-code-samples/pulls/5"},"html":{"href":"https://github.com/scylladb/scylla-code-samples/pull/5"},"issue":{"href":"https://api.github.com/repos/scylladb/scylla-code-samples/issues/5"},"comments":{"href":"https://api.github.com/repos/scylladb/scylla-code-samples/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/scylladb/scylla-code-samples/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/scylladb/scylla-code-samples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scylladb/scylla-code-samples/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/scylladb/scylla-code-samples/statuses/30fc6417b724d3bb1d387e509353e5472061a4c3"}}}} | {
"id": 83970554,
"name": "scylladb/scylla-code-samples",
"url": "https://api.github.com/repos/scylladb/scylla-code-samples"
} | {
"id": 170200,
"login": "tzach",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/170200?",
"url": "https://api.github.com/users/tzach"
} | {
"id": 14364730,
"login": "scylladb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14364730?",
"url": "https://api.github.com/orgs/scylladb"
} | 2017-06-29T11:00:49 | 6162330480 | {"actor":{"display_login":"tzach"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/comments/131875555","pull_request_review_id":54893854,"id":131875555,"diff_hunk":"@@ -0,0 +1,86 @@\n+// -*- Mode: Go; indent-tabs-mode: t -*-\n+\n+/*\n+ * Copyright (C) 2017 Canonical Ltd\n+ *\n+ * This program is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU General Public License version 3 as\n+ * published by the Free Software Foundation.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+ * GNU General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU General Public License\n+ * along with this program. If not, see <http://www.gnu.org/licenses/>.\n+ *\n+ */\n+\n+package dbus\n+\n+import (\n+\t\"net/url\"\n+\t\"os/exec\"\n+\n+\t\"fmt\"\n+\n+\t\"github.com/godbus/dbus\"\n+\t\"github.com/snapcore/snapd/strutil\"\n+)\n+\n+const safeLauncherIntrospectionXML = `\n+<interface name='io.snapcraft.SafeLauncher'>\n+\t<method name='OpenURL'>\n+\t\t<arg type='s' name='url' direction='in'/>\n+\t</method>\n+</interface>`\n+\n+var (\n+\tallowedURLSchemes = []string{\"http\", \"https\", \"mailto\"}\n+)\n+\n+// SafeLauncher implements the 'io.snapcraft.SafeLauncher' DBus interface","path":"dbus/safelauncher.go","position":43,"original_position":43,"commit_id":"d98eafb66a1825477c2fae0b9c103820cd6880a7","original_commit_id":"d98eafb66a1825477c2fae0b9c103820cd6880a7","user":{"login":"zyga","id":784262,"avatar_url":"https://avatars0.githubusercontent.com/u/784262?v=4","gravatar_id":"","url":"https://api.github.com/users/zyga","html_url":"https://github.com/zyga","followers_url":"https://api.github.com/users/zyga/followers","following_url":"https://api.github.com/users/zyga/following{/other_user}","gists_url":"https://api.github.com/users/zyga/gists{/gist_id}","starred_url":"https://api.github.com/users/zyga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyga/subscriptions","organizations_url":"https://api.github.com/users/zyga/orgs","repos_url":"https://api.github.com/users/zyga/repos","events_url":"https://api.github.com/users/zyga/events{/privacy}","received_events_url":"https://api.github.com/users/zyga/received_events","type":"User","site_admin":false},"body":"Nitpick: it would be nice if those would end with a dot like proper sentence.","created_at":"2017-08-08T10:25:34Z","updated_at":"2017-08-08T10:40:35Z","html_url":"https://github.com/snapcore/snapd/pull/3260#discussion_r131875555","pull_request_url":"https://api.github.com/repos/snapcore/snapd/pulls/3260","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments/131875555"},"html":{"href":"https://github.com/snapcore/snapd/pull/3260#discussion_r131875555"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/3260"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/3260","id":118556679,"html_url":"https://github.com/snapcore/snapd/pull/3260","diff_url":"https://github.com/snapcore/snapd/pull/3260.diff","patch_url":"https://github.com/snapcore/snapd/pull/3260.patch","issue_url":"https://api.github.com/repos/snapcore/snapd/issues/3260","number":3260,"state":"open","locked":false,"title":"cmd/snap: implement userd command as replacement for snapd-xdg-open","user":{"login":"morphis","id":433752,"avatar_url":"https://avatars2.githubusercontent.com/u/433752?v=4","gravatar_id":"","url":"https://api.github.com/users/morphis","html_url":"https://github.com/morphis","followers_url":"https://api.github.com/users/morphis/followers","following_url":"https://api.github.com/users/morphis/following{/other_user}","gists_url":"https://api.github.com/users/morphis/gists{/gist_id}","starred_url":"https://api.github.com/users/morphis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morphis/subscriptions","organizations_url":"https://api.github.com/users/morphis/orgs","repos_url":"https://api.github.com/users/morphis/repos","events_url":"https://api.github.com/users/morphis/events{/privacy}","received_events_url":"https://api.github.com/users/morphis/received_events","type":"User","site_admin":false},"body":"In https://forum.snapcraft.io/t/integrate-snapd-xdg-open-into-snapd-repository/100 we decided to implement a `snap userd` command which replaces `snapd-xdg-open`.\r\n\r\nBased on discussion from https://forum.snapcraft.io/t/integrate-snapd-xdg-open-into-snapd-repository/100","created_at":"2017-05-02T13:36:49Z","updated_at":"2017-08-08T10:40:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b18ad284226dea8f6daf6afbebb66c6cfd0fe1b7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapd/pulls/3260/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapd/pulls/3260/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapd/issues/3260/comments","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/d98eafb66a1825477c2fae0b9c103820cd6880a7","head":{"label":"morphis:f/snapd-user-instance","ref":"f/snapd-user-instance","sha":"d98eafb66a1825477c2fae0b9c103820cd6880a7","user":{"login":"morphis","id":433752,"avatar_url":"https://avatars2.githubusercontent.com/u/433752?v=4","gravatar_id":"","url":"https://api.github.com/users/morphis","html_url":"https://github.com/morphis","followers_url":"https://api.github.com/users/morphis/followers","following_url":"https://api.github.com/users/morphis/following{/other_user}","gists_url":"https://api.github.com/users/morphis/gists{/gist_id}","starred_url":"https://api.github.com/users/morphis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morphis/subscriptions","organizations_url":"https://api.github.com/users/morphis/orgs","repos_url":"https://api.github.com/users/morphis/repos","events_url":"https://api.github.com/users/morphis/events{/privacy}","received_events_url":"https://api.github.com/users/morphis/received_events","type":"User","site_admin":false},"repo":{"id":56325721,"name":"snapd","full_name":"morphis/snapd","owner":{"login":"morphis","id":433752,"avatar_url":"https://avatars2.githubusercontent.com/u/433752?v=4","gravatar_id":"","url":"https://api.github.com/users/morphis","html_url":"https://github.com/morphis","followers_url":"https://api.github.com/users/morphis/followers","following_url":"https://api.github.com/users/morphis/following{/other_user}","gists_url":"https://api.github.com/users/morphis/gists{/gist_id}","starred_url":"https://api.github.com/users/morphis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morphis/subscriptions","organizations_url":"https://api.github.com/users/morphis/orgs","repos_url":"https://api.github.com/users/morphis/repos","events_url":"https://api.github.com/users/morphis/events{/privacy}","received_events_url":"https://api.github.com/users/morphis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/morphis/snapd","description":"Snappy is the software at the heart of Ubuntu Core.","fork":true,"url":"https://api.github.com/repos/morphis/snapd","forks_url":"https://api.github.com/repos/morphis/snapd/forks","keys_url":"https://api.github.com/repos/morphis/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/morphis/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/morphis/snapd/teams","hooks_url":"https://api.github.com/repos/morphis/snapd/hooks","issue_events_url":"https://api.github.com/repos/morphis/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/morphis/snapd/events","assignees_url":"https://api.github.com/repos/morphis/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/morphis/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/morphis/snapd/tags","blobs_url":"https://api.github.com/repos/morphis/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/morphis/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/morphis/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/morphis/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/morphis/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/morphis/snapd/languages","stargazers_url":"https://api.github.com/repos/morphis/snapd/stargazers","contributors_url":"https://api.github.com/repos/morphis/snapd/contributors","subscribers_url":"https://api.github.com/repos/morphis/snapd/subscribers","subscription_url":"https://api.github.com/repos/morphis/snapd/subscription","commits_url":"https://api.github.com/repos/morphis/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/morphis/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/morphis/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/morphis/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/morphis/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/morphis/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/morphis/snapd/merges","archive_url":"https://api.github.com/repos/morphis/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/morphis/snapd/downloads","issues_url":"https://api.github.com/repos/morphis/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/morphis/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/morphis/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/morphis/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/morphis/snapd/labels{/name}","releases_url":"https://api.github.com/repos/morphis/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/morphis/snapd/deployments","created_at":"2016-04-15T14:21:22Z","updated_at":"2017-06-26T05:47:52Z","pushed_at":"2017-08-07T15:19:10Z","git_url":"git://github.com/morphis/snapd.git","ssh_url":"[email protected]:morphis/snapd.git","clone_url":"https://github.com/morphis/snapd.git","svn_url":"https://github.com/morphis/snapd","homepage":null,"size":50574,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"0cb950e3d0adec22d17c1112a3029cff94da7f89","user":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":44672744,"name":"snapd","full_name":"snapcore/snapd","owner":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":false,"url":"https://api.github.com/repos/snapcore/snapd","forks_url":"https://api.github.com/repos/snapcore/snapd/forks","keys_url":"https://api.github.com/repos/snapcore/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapd/teams","hooks_url":"https://api.github.com/repos/snapcore/snapd/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapd/events","assignees_url":"https://api.github.com/repos/snapcore/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapd/tags","blobs_url":"https://api.github.com/repos/snapcore/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapd/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapd/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapd/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapd/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapd/subscription","commits_url":"https://api.github.com/repos/snapcore/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapd/merges","archive_url":"https://api.github.com/repos/snapcore/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapd/downloads","issues_url":"https://api.github.com/repos/snapcore/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapd/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapd/deployments","created_at":"2015-10-21T11:51:46Z","updated_at":"2017-08-06T05:23:50Z","pushed_at":"2017-08-08T09:57:16Z","git_url":"git://github.com/snapcore/snapd.git","ssh_url":"[email protected]:snapcore/snapd.git","clone_url":"https://github.com/snapcore/snapd.git","svn_url":"https://github.com/snapcore/snapd","homepage":"","size":50621,"stargazers_count":762,"watchers_count":762,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":194,"mirror_url":null,"open_issues_count":45,"forks":194,"open_issues":45,"watchers":762,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/3260"},"html":{"href":"https://github.com/snapcore/snapd/pull/3260"},"issue":{"href":"https://api.github.com/repos/snapcore/snapd/issues/3260"},"comments":{"href":"https://api.github.com/repos/snapcore/snapd/issues/3260/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/3260/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/3260/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapd/statuses/d98eafb66a1825477c2fae0b9c103820cd6880a7"}}}} | {
"id": 44672744,
"name": "snapcore/snapd",
"url": "https://api.github.com/repos/snapcore/snapd"
} | {
"id": 784262,
"login": "zyga",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/784262?",
"url": "https://api.github.com/users/zyga"
} | {
"id": 19532717,
"login": "snapcore",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19532717?",
"url": "https://api.github.com/orgs/snapcore"
} | 2017-08-08T10:25:34 | 6414636869 | {"actor":{"display_login":"zyga"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/comments/133393623","pull_request_review_id":56567026,"id":133393623,"diff_hunk":"@@ -21,7 +21,14 @@ SYSTEMD_UNITS_DESTDIR=\"lib/systemd/system/\"\n # work around that by constructing the appropriate -I flag by hand.\n GCCGO := $(shell go tool dist env > /dev/null 2>&1 && echo no || echo yes)\n \n-BUILDFLAGS:=-buildmode=pie -pkgdir=$(CURDIR)/_build/std\n+# Disable -buildmode=pie mode on i386 as can panics in spectacular\n+# ways (LP: #1711052).\n+# See also https://forum.snapcraft.io/t/artful-i386-panics/\n+BUILDFLAGS:=-pkgdir=$(CURDIR)/_build/std","path":"packaging/ubuntu-16.04/rules","position":8,"original_position":8,"commit_id":"62680cd943bb2f8ee7b6f8b4d1ce828f649751fb","original_commit_id":"62680cd943bb2f8ee7b6f8b4d1ce828f649751fb","user":{"login":"mwhudson","id":672022,"avatar_url":"https://avatars3.githubusercontent.com/u/672022?v=4","gravatar_id":"","url":"https://api.github.com/users/mwhudson","html_url":"https://github.com/mwhudson","followers_url":"https://api.github.com/users/mwhudson/followers","following_url":"https://api.github.com/users/mwhudson/following{/other_user}","gists_url":"https://api.github.com/users/mwhudson/gists{/gist_id}","starred_url":"https://api.github.com/users/mwhudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwhudson/subscriptions","organizations_url":"https://api.github.com/users/mwhudson/orgs","repos_url":"https://api.github.com/users/mwhudson/repos","events_url":"https://api.github.com/users/mwhudson/events{/privacy}","received_events_url":"https://api.github.com/users/mwhudson/received_events","type":"User","site_admin":false},"body":"It's not really important but you don't need to set -pkgdir unless you are also setting -buildmode=pie","created_at":"2017-08-16T08:57:59Z","updated_at":"2017-08-16T08:58:41Z","html_url":"https://github.com/snapcore/snapd/pull/3737#discussion_r133393623","pull_request_url":"https://api.github.com/repos/snapcore/snapd/pulls/3737","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments/133393623"},"html":{"href":"https://github.com/snapcore/snapd/pull/3737#discussion_r133393623"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/3737"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/3737","id":135958877,"html_url":"https://github.com/snapcore/snapd/pull/3737","diff_url":"https://github.com/snapcore/snapd/pull/3737.diff","patch_url":"https://github.com/snapcore/snapd/pull/3737.patch","issue_url":"https://api.github.com/repos/snapcore/snapd/issues/3737","number":3737,"state":"open","locked":false,"title":"debian: do not build with -buildmode=pie on i386 (2.27)","user":{"login":"mvo5","id":914418,"avatar_url":"https://avatars3.githubusercontent.com/u/914418?v=4","gravatar_id":"","url":"https://api.github.com/users/mvo5","html_url":"https://github.com/mvo5","followers_url":"https://api.github.com/users/mvo5/followers","following_url":"https://api.github.com/users/mvo5/following{/other_user}","gists_url":"https://api.github.com/users/mvo5/gists{/gist_id}","starred_url":"https://api.github.com/users/mvo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvo5/subscriptions","organizations_url":"https://api.github.com/users/mvo5/orgs","repos_url":"https://api.github.com/users/mvo5/repos","events_url":"https://api.github.com/users/mvo5/events{/privacy}","received_events_url":"https://api.github.com/users/mvo5/received_events","type":"User","site_admin":false},"body":"With -buildmode=pie mode on i386 snapd panics in spectacular\r\nways (LP: #1711052) so we need to disable it for the time\r\nbeing.\r\n\r\nSee also https://forum.snapcraft.io/t/artful-i386-panics/","created_at":"2017-08-16T07:35:30Z","updated_at":"2017-08-16T08:58:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39b5d4adca3ad78dc0f7ca7d31422de29b31535e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chipaca","id":1543430,"avatar_url":"https://avatars1.githubusercontent.com/u/1543430?v=4","gravatar_id":"","url":"https://api.github.com/users/chipaca","html_url":"https://github.com/chipaca","followers_url":"https://api.github.com/users/chipaca/followers","following_url":"https://api.github.com/users/chipaca/following{/other_user}","gists_url":"https://api.github.com/users/chipaca/gists{/gist_id}","starred_url":"https://api.github.com/users/chipaca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chipaca/subscriptions","organizations_url":"https://api.github.com/users/chipaca/orgs","repos_url":"https://api.github.com/users/chipaca/repos","events_url":"https://api.github.com/users/chipaca/events{/privacy}","received_events_url":"https://api.github.com/users/chipaca/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/snapcore/snapd/milestones/12","html_url":"https://github.com/snapcore/snapd/milestone/12","labels_url":"https://api.github.com/repos/snapcore/snapd/milestones/12/labels","id":2526465,"number":12,"title":"2.27","description":"","creator":{"login":"mvo5","id":914418,"avatar_url":"https://avatars3.githubusercontent.com/u/914418?v=4","gravatar_id":"","url":"https://api.github.com/users/mvo5","html_url":"https://github.com/mvo5","followers_url":"https://api.github.com/users/mvo5/followers","following_url":"https://api.github.com/users/mvo5/following{/other_user}","gists_url":"https://api.github.com/users/mvo5/gists{/gist_id}","starred_url":"https://api.github.com/users/mvo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvo5/subscriptions","organizations_url":"https://api.github.com/users/mvo5/orgs","repos_url":"https://api.github.com/users/mvo5/repos","events_url":"https://api.github.com/users/mvo5/events{/privacy}","received_events_url":"https://api.github.com/users/mvo5/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":24,"state":"open","created_at":"2017-05-17T09:03:08Z","updated_at":"2017-08-16T07:36:35Z","due_on":"2017-08-14T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/snapcore/snapd/pulls/3737/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapd/pulls/3737/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapd/issues/3737/comments","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/62680cd943bb2f8ee7b6f8b4d1ce828f649751fb","head":{"label":"mvo5:no-pie-on-i386-2.27","ref":"no-pie-on-i386-2.27","sha":"62680cd943bb2f8ee7b6f8b4d1ce828f649751fb","user":{"login":"mvo5","id":914418,"avatar_url":"https://avatars3.githubusercontent.com/u/914418?v=4","gravatar_id":"","url":"https://api.github.com/users/mvo5","html_url":"https://github.com/mvo5","followers_url":"https://api.github.com/users/mvo5/followers","following_url":"https://api.github.com/users/mvo5/following{/other_user}","gists_url":"https://api.github.com/users/mvo5/gists{/gist_id}","starred_url":"https://api.github.com/users/mvo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvo5/subscriptions","organizations_url":"https://api.github.com/users/mvo5/orgs","repos_url":"https://api.github.com/users/mvo5/repos","events_url":"https://api.github.com/users/mvo5/events{/privacy}","received_events_url":"https://api.github.com/users/mvo5/received_events","type":"User","site_admin":false},"repo":{"id":45067233,"name":"snappy","full_name":"mvo5/snappy","owner":{"login":"mvo5","id":914418,"avatar_url":"https://avatars3.githubusercontent.com/u/914418?v=4","gravatar_id":"","url":"https://api.github.com/users/mvo5","html_url":"https://github.com/mvo5","followers_url":"https://api.github.com/users/mvo5/followers","following_url":"https://api.github.com/users/mvo5/following{/other_user}","gists_url":"https://api.github.com/users/mvo5/gists{/gist_id}","starred_url":"https://api.github.com/users/mvo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvo5/subscriptions","organizations_url":"https://api.github.com/users/mvo5/orgs","repos_url":"https://api.github.com/users/mvo5/repos","events_url":"https://api.github.com/users/mvo5/events{/privacy}","received_events_url":"https://api.github.com/users/mvo5/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mvo5/snappy","description":"Snappy is the software at the heart of Ubuntu Core.","fork":true,"url":"https://api.github.com/repos/mvo5/snappy","forks_url":"https://api.github.com/repos/mvo5/snappy/forks","keys_url":"https://api.github.com/repos/mvo5/snappy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mvo5/snappy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mvo5/snappy/teams","hooks_url":"https://api.github.com/repos/mvo5/snappy/hooks","issue_events_url":"https://api.github.com/repos/mvo5/snappy/issues/events{/number}","events_url":"https://api.github.com/repos/mvo5/snappy/events","assignees_url":"https://api.github.com/repos/mvo5/snappy/assignees{/user}","branches_url":"https://api.github.com/repos/mvo5/snappy/branches{/branch}","tags_url":"https://api.github.com/repos/mvo5/snappy/tags","blobs_url":"https://api.github.com/repos/mvo5/snappy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mvo5/snappy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mvo5/snappy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mvo5/snappy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mvo5/snappy/statuses/{sha}","languages_url":"https://api.github.com/repos/mvo5/snappy/languages","stargazers_url":"https://api.github.com/repos/mvo5/snappy/stargazers","contributors_url":"https://api.github.com/repos/mvo5/snappy/contributors","subscribers_url":"https://api.github.com/repos/mvo5/snappy/subscribers","subscription_url":"https://api.github.com/repos/mvo5/snappy/subscription","commits_url":"https://api.github.com/repos/mvo5/snappy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mvo5/snappy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mvo5/snappy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mvo5/snappy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mvo5/snappy/contents/{+path}","compare_url":"https://api.github.com/repos/mvo5/snappy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mvo5/snappy/merges","archive_url":"https://api.github.com/repos/mvo5/snappy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mvo5/snappy/downloads","issues_url":"https://api.github.com/repos/mvo5/snappy/issues{/number}","pulls_url":"https://api.github.com/repos/mvo5/snappy/pulls{/number}","milestones_url":"https://api.github.com/repos/mvo5/snappy/milestones{/number}","notifications_url":"https://api.github.com/repos/mvo5/snappy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mvo5/snappy/labels{/name}","releases_url":"https://api.github.com/repos/mvo5/snappy/releases{/id}","deployments_url":"https://api.github.com/repos/mvo5/snappy/deployments","created_at":"2015-10-27T20:12:18Z","updated_at":"2016-01-11T10:04:34Z","pushed_at":"2017-08-16T07:36:34Z","git_url":"git://github.com/mvo5/snappy.git","ssh_url":"[email protected]:mvo5/snappy.git","clone_url":"https://github.com/mvo5/snappy.git","svn_url":"https://github.com/mvo5/snappy","homepage":null,"size":53140,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:release/2.27","ref":"release/2.27","sha":"191f8e956d4f0b15f6bd4b83a3852808d970843c","user":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":44672744,"name":"snapd","full_name":"snapcore/snapd","owner":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":false,"url":"https://api.github.com/repos/snapcore/snapd","forks_url":"https://api.github.com/repos/snapcore/snapd/forks","keys_url":"https://api.github.com/repos/snapcore/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapd/teams","hooks_url":"https://api.github.com/repos/snapcore/snapd/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapd/events","assignees_url":"https://api.github.com/repos/snapcore/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapd/tags","blobs_url":"https://api.github.com/repos/snapcore/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapd/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapd/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapd/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapd/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapd/subscription","commits_url":"https://api.github.com/repos/snapcore/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapd/merges","archive_url":"https://api.github.com/repos/snapcore/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapd/downloads","issues_url":"https://api.github.com/repos/snapcore/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapd/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapd/deployments","created_at":"2015-10-21T11:51:46Z","updated_at":"2017-08-16T00:40:42Z","pushed_at":"2017-08-16T08:49:35Z","git_url":"git://github.com/snapcore/snapd.git","ssh_url":"[email protected]:snapcore/snapd.git","clone_url":"https://github.com/snapcore/snapd.git","svn_url":"https://github.com/snapcore/snapd","homepage":"","size":51104,"stargazers_count":767,"watchers_count":767,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":195,"mirror_url":null,"open_issues_count":42,"forks":195,"open_issues":42,"watchers":767,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/3737"},"html":{"href":"https://github.com/snapcore/snapd/pull/3737"},"issue":{"href":"https://api.github.com/repos/snapcore/snapd/issues/3737"},"comments":{"href":"https://api.github.com/repos/snapcore/snapd/issues/3737/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/3737/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/3737/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapd/statuses/62680cd943bb2f8ee7b6f8b4d1ce828f649751fb"}}}} | {
"id": 44672744,
"name": "snapcore/snapd",
"url": "https://api.github.com/repos/snapcore/snapd"
} | {
"id": 672022,
"login": "mwhudson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/672022?",
"url": "https://api.github.com/users/mwhudson"
} | {
"id": 19532717,
"login": "snapcore",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19532717?",
"url": "https://api.github.com/orgs/snapcore"
} | 2017-08-16T08:57:59 | 6461765683 | {"actor":{"display_login":"mwhudson"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/threadly/litesockets/pulls/comments/115260954","pull_request_review_id":36785936,"id":115260954,"diff_hunk":"@@ -0,0 +1,277 @@\n+package org.threadly.litesockets.buffers;\n+\n+import static org.junit.Assert.*;\n+\n+import java.nio.BufferUnderflowException;\n+import java.nio.ByteBuffer;\n+import java.util.Random;\n+\n+import org.junit.After;\n+import org.junit.Test;\n+import org.threadly.litesockets.buffers.MergedByteBuffers;\n+import org.threadly.litesockets.buffers.ReuseableMergedByteBuffers;\n+import org.threadly.litesockets.buffers.SimpleMergedByteBuffers;\n+\n+public class SimpleMergedByteBuffersTests {","path":"src/test/java/org/threadly/litesockets/buffers/SimpleMergedByteBuffersTests.java","position":15,"original_position":15,"commit_id":"dfc1e46d978b657f309802470c49b06f0a43e56c","original_commit_id":"dfc1e46d978b657f309802470c49b06f0a43e56c","user":{"login":"lwahlmeier","id":4663016,"avatar_url":"https://avatars1.githubusercontent.com/u/4663016?v=3","gravatar_id":"","url":"https://api.github.com/users/lwahlmeier","html_url":"https://github.com/lwahlmeier","followers_url":"https://api.github.com/users/lwahlmeier/followers","following_url":"https://api.github.com/users/lwahlmeier/following{/other_user}","gists_url":"https://api.github.com/users/lwahlmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/lwahlmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwahlmeier/subscriptions","organizations_url":"https://api.github.com/users/lwahlmeier/orgs","repos_url":"https://api.github.com/users/lwahlmeier/repos","events_url":"https://api.github.com/users/lwahlmeier/events{/privacy}","received_events_url":"https://api.github.com/users/lwahlmeier/received_events","type":"User","site_admin":false},"body":"A lot of them already do, for the different SocketExecuters, I thought about it for this, but it does get a little complicated with how the MergedByteBuffers are constructed and added to differently.","created_at":"2017-05-08T14:28:13Z","updated_at":"2017-05-08T14:28:14Z","html_url":"https://github.com/threadly/litesockets/pull/42#discussion_r115260954","pull_request_url":"https://api.github.com/repos/threadly/litesockets/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/threadly/litesockets/pulls/comments/115260954"},"html":{"href":"https://github.com/threadly/litesockets/pull/42#discussion_r115260954"},"pull_request":{"href":"https://api.github.com/repos/threadly/litesockets/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/threadly/litesockets/pulls/42","id":119359582,"html_url":"https://github.com/threadly/litesockets/pull/42","diff_url":"https://github.com/threadly/litesockets/pull/42.diff","patch_url":"https://github.com/threadly/litesockets/pull/42.patch","issue_url":"https://api.github.com/repos/threadly/litesockets/issues/42","number":42,"state":"open","locked":false,"title":"Mbb changes","user":{"login":"lwahlmeier","id":4663016,"avatar_url":"https://avatars1.githubusercontent.com/u/4663016?v=3","gravatar_id":"","url":"https://api.github.com/users/lwahlmeier","html_url":"https://github.com/lwahlmeier","followers_url":"https://api.github.com/users/lwahlmeier/followers","following_url":"https://api.github.com/users/lwahlmeier/following{/other_user}","gists_url":"https://api.github.com/users/lwahlmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/lwahlmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwahlmeier/subscriptions","organizations_url":"https://api.github.com/users/lwahlmeier/orgs","repos_url":"https://api.github.com/users/lwahlmeier/repos","events_url":"https://api.github.com/users/lwahlmeier/events{/privacy}","received_events_url":"https://api.github.com/users/lwahlmeier/received_events","type":"User","site_admin":false},"body":"This improved the MBB interface a bit and added another MBB implementation, SimpleMergedByteBuffers, which are much less costly to construct, but also cant be appended/added to.","created_at":"2017-05-07T23:43:31Z","updated_at":"2017-05-08T14:28:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7a16ed76c08dee3996c87894aea4c4273517394","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/threadly/litesockets/pulls/42/commits","review_comments_url":"https://api.github.com/repos/threadly/litesockets/pulls/42/comments","review_comment_url":"https://api.github.com/repos/threadly/litesockets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/threadly/litesockets/issues/42/comments","statuses_url":"https://api.github.com/repos/threadly/litesockets/statuses/dfc1e46d978b657f309802470c49b06f0a43e56c","head":{"label":"threadly:mbb-changes","ref":"mbb-changes","sha":"dfc1e46d978b657f309802470c49b06f0a43e56c","user":{"login":"threadly","id":4627301,"avatar_url":"https://avatars3.githubusercontent.com/u/4627301?v=3","gravatar_id":"","url":"https://api.github.com/users/threadly","html_url":"https://github.com/threadly","followers_url":"https://api.github.com/users/threadly/followers","following_url":"https://api.github.com/users/threadly/following{/other_user}","gists_url":"https://api.github.com/users/threadly/gists{/gist_id}","starred_url":"https://api.github.com/users/threadly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threadly/subscriptions","organizations_url":"https://api.github.com/users/threadly/orgs","repos_url":"https://api.github.com/users/threadly/repos","events_url":"https://api.github.com/users/threadly/events{/privacy}","received_events_url":"https://api.github.com/users/threadly/received_events","type":"Organization","site_admin":false},"repo":{"id":29884068,"name":"litesockets","full_name":"threadly/litesockets","owner":{"login":"threadly","id":4627301,"avatar_url":"https://avatars3.githubusercontent.com/u/4627301?v=3","gravatar_id":"","url":"https://api.github.com/users/threadly","html_url":"https://github.com/threadly","followers_url":"https://api.github.com/users/threadly/followers","following_url":"https://api.github.com/users/threadly/following{/other_user}","gists_url":"https://api.github.com/users/threadly/gists{/gist_id}","starred_url":"https://api.github.com/users/threadly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threadly/subscriptions","organizations_url":"https://api.github.com/users/threadly/orgs","repos_url":"https://api.github.com/users/threadly/repos","events_url":"https://api.github.com/users/threadly/events{/privacy}","received_events_url":"https://api.github.com/users/threadly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/threadly/litesockets","description":"Light weight socket library which relies heavily on threadly concurrency tools.","fork":false,"url":"https://api.github.com/repos/threadly/litesockets","forks_url":"https://api.github.com/repos/threadly/litesockets/forks","keys_url":"https://api.github.com/repos/threadly/litesockets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/threadly/litesockets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/threadly/litesockets/teams","hooks_url":"https://api.github.com/repos/threadly/litesockets/hooks","issue_events_url":"https://api.github.com/repos/threadly/litesockets/issues/events{/number}","events_url":"https://api.github.com/repos/threadly/litesockets/events","assignees_url":"https://api.github.com/repos/threadly/litesockets/assignees{/user}","branches_url":"https://api.github.com/repos/threadly/litesockets/branches{/branch}","tags_url":"https://api.github.com/repos/threadly/litesockets/tags","blobs_url":"https://api.github.com/repos/threadly/litesockets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/threadly/litesockets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/threadly/litesockets/git/refs{/sha}","trees_url":"https://api.github.com/repos/threadly/litesockets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/threadly/litesockets/statuses/{sha}","languages_url":"https://api.github.com/repos/threadly/litesockets/languages","stargazers_url":"https://api.github.com/repos/threadly/litesockets/stargazers","contributors_url":"https://api.github.com/repos/threadly/litesockets/contributors","subscribers_url":"https://api.github.com/repos/threadly/litesockets/subscribers","subscription_url":"https://api.github.com/repos/threadly/litesockets/subscription","commits_url":"https://api.github.com/repos/threadly/litesockets/commits{/sha}","git_commits_url":"https://api.github.com/repos/threadly/litesockets/git/commits{/sha}","comments_url":"https://api.github.com/repos/threadly/litesockets/comments{/number}","issue_comment_url":"https://api.github.com/repos/threadly/litesockets/issues/comments{/number}","contents_url":"https://api.github.com/repos/threadly/litesockets/contents/{+path}","compare_url":"https://api.github.com/repos/threadly/litesockets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/threadly/litesockets/merges","archive_url":"https://api.github.com/repos/threadly/litesockets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/threadly/litesockets/downloads","issues_url":"https://api.github.com/repos/threadly/litesockets/issues{/number}","pulls_url":"https://api.github.com/repos/threadly/litesockets/pulls{/number}","milestones_url":"https://api.github.com/repos/threadly/litesockets/milestones{/number}","notifications_url":"https://api.github.com/repos/threadly/litesockets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/threadly/litesockets/labels{/name}","releases_url":"https://api.github.com/repos/threadly/litesockets/releases{/id}","deployments_url":"https://api.github.com/repos/threadly/litesockets/deployments","created_at":"2015-01-26T22:05:45Z","updated_at":"2017-05-05T14:04:00Z","pushed_at":"2017-05-07T23:43:31Z","git_url":"git://github.com/threadly/litesockets.git","ssh_url":"[email protected]:threadly/litesockets.git","clone_url":"https://github.com/threadly/litesockets.git","svn_url":"https://github.com/threadly/litesockets","homepage":null,"size":1068,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"threadly:master","ref":"master","sha":"a2ceb6857e2dcbc091db313670535eec6a6e9e30","user":{"login":"threadly","id":4627301,"avatar_url":"https://avatars3.githubusercontent.com/u/4627301?v=3","gravatar_id":"","url":"https://api.github.com/users/threadly","html_url":"https://github.com/threadly","followers_url":"https://api.github.com/users/threadly/followers","following_url":"https://api.github.com/users/threadly/following{/other_user}","gists_url":"https://api.github.com/users/threadly/gists{/gist_id}","starred_url":"https://api.github.com/users/threadly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threadly/subscriptions","organizations_url":"https://api.github.com/users/threadly/orgs","repos_url":"https://api.github.com/users/threadly/repos","events_url":"https://api.github.com/users/threadly/events{/privacy}","received_events_url":"https://api.github.com/users/threadly/received_events","type":"Organization","site_admin":false},"repo":{"id":29884068,"name":"litesockets","full_name":"threadly/litesockets","owner":{"login":"threadly","id":4627301,"avatar_url":"https://avatars3.githubusercontent.com/u/4627301?v=3","gravatar_id":"","url":"https://api.github.com/users/threadly","html_url":"https://github.com/threadly","followers_url":"https://api.github.com/users/threadly/followers","following_url":"https://api.github.com/users/threadly/following{/other_user}","gists_url":"https://api.github.com/users/threadly/gists{/gist_id}","starred_url":"https://api.github.com/users/threadly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threadly/subscriptions","organizations_url":"https://api.github.com/users/threadly/orgs","repos_url":"https://api.github.com/users/threadly/repos","events_url":"https://api.github.com/users/threadly/events{/privacy}","received_events_url":"https://api.github.com/users/threadly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/threadly/litesockets","description":"Light weight socket library which relies heavily on threadly concurrency tools.","fork":false,"url":"https://api.github.com/repos/threadly/litesockets","forks_url":"https://api.github.com/repos/threadly/litesockets/forks","keys_url":"https://api.github.com/repos/threadly/litesockets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/threadly/litesockets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/threadly/litesockets/teams","hooks_url":"https://api.github.com/repos/threadly/litesockets/hooks","issue_events_url":"https://api.github.com/repos/threadly/litesockets/issues/events{/number}","events_url":"https://api.github.com/repos/threadly/litesockets/events","assignees_url":"https://api.github.com/repos/threadly/litesockets/assignees{/user}","branches_url":"https://api.github.com/repos/threadly/litesockets/branches{/branch}","tags_url":"https://api.github.com/repos/threadly/litesockets/tags","blobs_url":"https://api.github.com/repos/threadly/litesockets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/threadly/litesockets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/threadly/litesockets/git/refs{/sha}","trees_url":"https://api.github.com/repos/threadly/litesockets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/threadly/litesockets/statuses/{sha}","languages_url":"https://api.github.com/repos/threadly/litesockets/languages","stargazers_url":"https://api.github.com/repos/threadly/litesockets/stargazers","contributors_url":"https://api.github.com/repos/threadly/litesockets/contributors","subscribers_url":"https://api.github.com/repos/threadly/litesockets/subscribers","subscription_url":"https://api.github.com/repos/threadly/litesockets/subscription","commits_url":"https://api.github.com/repos/threadly/litesockets/commits{/sha}","git_commits_url":"https://api.github.com/repos/threadly/litesockets/git/commits{/sha}","comments_url":"https://api.github.com/repos/threadly/litesockets/comments{/number}","issue_comment_url":"https://api.github.com/repos/threadly/litesockets/issues/comments{/number}","contents_url":"https://api.github.com/repos/threadly/litesockets/contents/{+path}","compare_url":"https://api.github.com/repos/threadly/litesockets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/threadly/litesockets/merges","archive_url":"https://api.github.com/repos/threadly/litesockets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/threadly/litesockets/downloads","issues_url":"https://api.github.com/repos/threadly/litesockets/issues{/number}","pulls_url":"https://api.github.com/repos/threadly/litesockets/pulls{/number}","milestones_url":"https://api.github.com/repos/threadly/litesockets/milestones{/number}","notifications_url":"https://api.github.com/repos/threadly/litesockets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/threadly/litesockets/labels{/name}","releases_url":"https://api.github.com/repos/threadly/litesockets/releases{/id}","deployments_url":"https://api.github.com/repos/threadly/litesockets/deployments","created_at":"2015-01-26T22:05:45Z","updated_at":"2017-05-05T14:04:00Z","pushed_at":"2017-05-07T23:43:31Z","git_url":"git://github.com/threadly/litesockets.git","ssh_url":"[email protected]:threadly/litesockets.git","clone_url":"https://github.com/threadly/litesockets.git","svn_url":"https://github.com/threadly/litesockets","homepage":null,"size":1068,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/threadly/litesockets/pulls/42"},"html":{"href":"https://github.com/threadly/litesockets/pull/42"},"issue":{"href":"https://api.github.com/repos/threadly/litesockets/issues/42"},"comments":{"href":"https://api.github.com/repos/threadly/litesockets/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/threadly/litesockets/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/threadly/litesockets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/threadly/litesockets/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/threadly/litesockets/statuses/dfc1e46d978b657f309802470c49b06f0a43e56c"}}}} | {
"id": 29884068,
"name": "threadly/litesockets",
"url": "https://api.github.com/repos/threadly/litesockets"
} | {
"id": 4663016,
"login": "lwahlmeier",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4663016?",
"url": "https://api.github.com/users/lwahlmeier"
} | {
"id": 4627301,
"login": "threadly",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4627301?",
"url": "https://api.github.com/orgs/threadly"
} | 2017-05-08T14:28:13 | 5829384476 | {"actor":{"display_login":"lwahlmeier"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/AgriCraft/AgriCraft/pulls/comments/123872024","pull_request_review_id":46120884,"id":123872024,"diff_hunk":"@@ -56,44 +63,130 @@ public float getAngle() {\n //this saves the data on the tile entity\n @Override\n public void writeTileNBT(NBTTagCompound tag) {\n- if (this.counter > 0) {\n+ if (this.counter > 0)\n tag.setInteger(AgriNBT.LEVEL, this.counter);\n- }\n tag.setBoolean(AgriNBT.ACTIVE, active);\n+ if (this.buffer > 0)\n+ tag.setInteger(AgriNBT.BUFFER, this.buffer);\n+ if (this.columnCounter > 0)\n+ tag.setInteger(AgriNBT.COLUMN_COUNTER, this.columnCounter);\n+ if (this.waterUsageRemainingMillibuckets < Integer.MAX_VALUE)\n+ tag.setInteger(AgriNBT.WATER_USAGE_REMAINING_MILLIBUCKETS, this.waterUsageRemainingMillibuckets);\n+ if (this.waterUsageRemainingTicks > 0)\n+ tag.setInteger(AgriNBT.WATER_USAGE_REMAINING_TICKS, this.waterUsageRemainingTicks);\n }\n \n //this loads the saved data for the tile entity\n @Override\n public void readTileNBT(NBTTagCompound tag) {\n- if (tag.hasKey(AgriNBT.LEVEL)) {\n- this.counter = tag.getInteger(AgriNBT.LEVEL);\n- } else {\n- this.counter = 0;\n- }\n-\n- if (tag.hasKey(AgriNBT.ACTIVE)) {\n- this.active = tag.getBoolean(AgriNBT.ACTIVE);\n- } else {\n- this.active = false;\n- }\n+ this.counter\n+ = tag.hasKey( AgriNBT.LEVEL)\n+ ? tag.getInteger(AgriNBT.LEVEL)\n+ : 0;\n+ this.active\n+ = tag.hasKey( AgriNBT.ACTIVE)\n+ ? tag.getBoolean(AgriNBT.ACTIVE)\n+ : false;\n+ this.buffer\n+ = tag.hasKey( AgriNBT.BUFFER)\n+ ? tag.getInteger(AgriNBT.BUFFER)\n+ : 0;\n+ this.columnCounter\n+ = tag.hasKey( AgriNBT.COLUMN_COUNTER)\n+ ? tag.getInteger(AgriNBT.COLUMN_COUNTER)\n+ : 0;\n+ this.waterUsageRemainingMillibuckets\n+ = tag.hasKey( AgriNBT.WATER_USAGE_REMAINING_MILLIBUCKETS)\n+ ? tag.getInteger(AgriNBT.WATER_USAGE_REMAINING_MILLIBUCKETS)\n+ : Integer.MAX_VALUE;\n+ this.waterUsageRemainingTicks\n+ = tag.hasKey( AgriNBT.WATER_USAGE_REMAINING_TICKS)\n+ ? tag.getInteger(AgriNBT.WATER_USAGE_REMAINING_TICKS)\n+ : 0;\n }\n \n //checks if the sprinkler is CONNECTED to an irrigation channel\n public boolean isConnected() {\n- return this.worldObj != null && this.worldObj.getBlockState(getPos().add(0, 1, 0)).getBlock() instanceof BlockWaterChannel;\n+ return this.worldObj != null && this.worldObj.getBlockState(getPos().up()).getBlock() instanceof BlockWaterChannel;\n }\n \n @Override\n public void update() {\n- if (!worldObj.isRemote && this.isActive()) {\n- this.counter = (counter + 1) % AgriCraftConfig.sprinklerGrowthIntervalTicks;\n- this.buffer -= 10;\n- this.range.stream().forEach(p -> this.irrigate(p, false));\n+ if (!worldObj.isRemote) {\n+ // Step 1: Check if we need to refresh the water usage variables\n+ if (waterUsageRemainingTicks <= 0) {\n+ this.waterUsageRemainingMillibuckets = AgriCraftConfig.sprinklerRatePerSecond;\n+ this.waterUsageRemainingTicks = TICKS_PER_SECOND;\n+ }\n+\n+ // Step 2: Update the per-tick rate.\n+ // Note: This math executes regardless of actual consumption occuring, so\n+ // that the usage rate refresh still happens every twenty ticks.\n+ final int waterUsageThisTick = this.waterUsageRemainingMillibuckets / this.waterUsageRemainingTicks;\n+ this.waterUsageRemainingMillibuckets -= waterUsageThisTick;\n+ this.waterUsageRemainingTicks -= 1;\n+\n+ // Step 3: Check if there is enough water to irrigate this tick, and if this is a change.\n+ final boolean currentActiveness = (this.buffer >= waterUsageThisTick && this.buffer > 0);\n+ if (currentActiveness != this.active) {\n+ this.active = currentActiveness;\n+ this.markForUpdate();\n+ }\n+\n+ // Step 4: If we can, sprinkle!\n+ if (this.active) {\n+ this.buffer -= waterUsageThisTick;\n+ doSprinkle();\n+ }\n } else if (this.active) {\n this.renderLiquidSpray();\n }\n }\n \n+ public void doSprinkle() {","path":"src/main/java/com/infinityraider/agricraft/tiles/irrigation/TileEntitySprinkler.java","position":142,"original_position":151,"commit_id":"91529366817c9c9f4b3c40da6b24fa18e50d1a99","original_commit_id":"db0c0b02ec250ae914d50d8a801b2ed2aa59f417","user":{"login":"CodesCubesAndCrashes","id":28678248,"avatar_url":"https://avatars0.githubusercontent.com/u/28678248?v=3","gravatar_id":"","url":"https://api.github.com/users/CodesCubesAndCrashes","html_url":"https://github.com/CodesCubesAndCrashes","followers_url":"https://api.github.com/users/CodesCubesAndCrashes/followers","following_url":"https://api.github.com/users/CodesCubesAndCrashes/following{/other_user}","gists_url":"https://api.github.com/users/CodesCubesAndCrashes/gists{/gist_id}","starred_url":"https://api.github.com/users/CodesCubesAndCrashes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodesCubesAndCrashes/subscriptions","organizations_url":"https://api.github.com/users/CodesCubesAndCrashes/orgs","repos_url":"https://api.github.com/users/CodesCubesAndCrashes/repos","events_url":"https://api.github.com/users/CodesCubesAndCrashes/events{/privacy}","received_events_url":"https://api.github.com/users/CodesCubesAndCrashes/received_events","type":"User","site_admin":false},"body":"If you check line 103, I found an opportunity to simplify the check using `WorldHelper`. Thanks!","created_at":"2017-06-24T06:39:23Z","updated_at":"2017-06-24T06:39:23Z","html_url":"https://github.com/AgriCraft/AgriCraft/pull/1008#discussion_r123872024","pull_request_url":"https://api.github.com/repos/AgriCraft/AgriCraft/pulls/1008","_links":{"self":{"href":"https://api.github.com/repos/AgriCraft/AgriCraft/pulls/comments/123872024"},"html":{"href":"https://github.com/AgriCraft/AgriCraft/pull/1008#discussion_r123872024"},"pull_request":{"href":"https://api.github.com/repos/AgriCraft/AgriCraft/pulls/1008"}}},"pull_request":{"url":"https://api.github.com/repos/AgriCraft/AgriCraft/pulls/1008","id":125733954,"html_url":"https://github.com/AgriCraft/AgriCraft/pull/1008","diff_url":"https://github.com/AgriCraft/AgriCraft/pull/1008.diff","patch_url":"https://github.com/AgriCraft/AgriCraft/pull/1008.patch","issue_url":"https://api.github.com/repos/AgriCraft/AgriCraft/issues/1008","number":1008,"state":"open","locked":false,"title":"Improving the updates and irrigation for Sprinklers","user":{"login":"CodesCubesAndCrashes","id":28678248,"avatar_url":"https://avatars0.githubusercontent.com/u/28678248?v=3","gravatar_id":"","url":"https://api.github.com/users/CodesCubesAndCrashes","html_url":"https://github.com/CodesCubesAndCrashes","followers_url":"https://api.github.com/users/CodesCubesAndCrashes/followers","following_url":"https://api.github.com/users/CodesCubesAndCrashes/following{/other_user}","gists_url":"https://api.github.com/users/CodesCubesAndCrashes/gists{/gist_id}","starred_url":"https://api.github.com/users/CodesCubesAndCrashes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodesCubesAndCrashes/subscriptions","organizations_url":"https://api.github.com/users/CodesCubesAndCrashes/orgs","repos_url":"https://api.github.com/users/CodesCubesAndCrashes/repos","events_url":"https://api.github.com/users/CodesCubesAndCrashes/events{/privacy}","received_events_url":"https://api.github.com/users/CodesCubesAndCrashes/received_events","type":"User","site_admin":false},"body":"This new pull request hopefully implements the feedback provided in two previous threads: \r\n* https://github.com/AgriCraft/AgriCraft/pull/973#issuecomment-306102765 \r\n* https://github.com/AgriCraft/AgriCraft/issues/862#issuecomment-302941453\r\n\r\nConsolidated features to be edited in here.\r\n\r\nThere's also been discussion about even more intelligent looping and tracking, but this version works well already, and can be replaced later.","created_at":"2017-06-15T03:18:13Z","updated_at":"2017-06-24T06:39:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e145595de4458e56b25f23cf26ca13e431546765","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/AgriCraft/AgriCraft/pulls/1008/commits","review_comments_url":"https://api.github.com/repos/AgriCraft/AgriCraft/pulls/1008/comments","review_comment_url":"https://api.github.com/repos/AgriCraft/AgriCraft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AgriCraft/AgriCraft/issues/1008/comments","statuses_url":"https://api.github.com/repos/AgriCraft/AgriCraft/statuses/91529366817c9c9f4b3c40da6b24fa18e50d1a99","head":{"label":"CodesCubesAndCrashes:patch-sprinklers-improved","ref":"patch-sprinklers-improved","sha":"91529366817c9c9f4b3c40da6b24fa18e50d1a99","user":{"login":"CodesCubesAndCrashes","id":28678248,"avatar_url":"https://avatars0.githubusercontent.com/u/28678248?v=3","gravatar_id":"","url":"https://api.github.com/users/CodesCubesAndCrashes","html_url":"https://github.com/CodesCubesAndCrashes","followers_url":"https://api.github.com/users/CodesCubesAndCrashes/followers","following_url":"https://api.github.com/users/CodesCubesAndCrashes/following{/other_user}","gists_url":"https://api.github.com/users/CodesCubesAndCrashes/gists{/gist_id}","starred_url":"https://api.github.com/users/CodesCubesAndCrashes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodesCubesAndCrashes/subscriptions","organizations_url":"https://api.github.com/users/CodesCubesAndCrashes/orgs","repos_url":"https://api.github.com/users/CodesCubesAndCrashes/repos","events_url":"https://api.github.com/users/CodesCubesAndCrashes/events{/privacy}","received_events_url":"https://api.github.com/users/CodesCubesAndCrashes/received_events","type":"User","site_admin":false},"repo":{"id":91205592,"name":"AgriCraft","full_name":"CodesCubesAndCrashes/AgriCraft","owner":{"login":"CodesCubesAndCrashes","id":28678248,"avatar_url":"https://avatars0.githubusercontent.com/u/28678248?v=3","gravatar_id":"","url":"https://api.github.com/users/CodesCubesAndCrashes","html_url":"https://github.com/CodesCubesAndCrashes","followers_url":"https://api.github.com/users/CodesCubesAndCrashes/followers","following_url":"https://api.github.com/users/CodesCubesAndCrashes/following{/other_user}","gists_url":"https://api.github.com/users/CodesCubesAndCrashes/gists{/gist_id}","starred_url":"https://api.github.com/users/CodesCubesAndCrashes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodesCubesAndCrashes/subscriptions","organizations_url":"https://api.github.com/users/CodesCubesAndCrashes/orgs","repos_url":"https://api.github.com/users/CodesCubesAndCrashes/repos","events_url":"https://api.github.com/users/CodesCubesAndCrashes/events{/privacy}","received_events_url":"https://api.github.com/users/CodesCubesAndCrashes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CodesCubesAndCrashes/AgriCraft","description":"The source code for the Minecraft mod: AgriCraft","fork":true,"url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft","forks_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/forks","keys_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/teams","hooks_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/hooks","issue_events_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/issues/events{/number}","events_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/events","assignees_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/assignees{/user}","branches_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/branches{/branch}","tags_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/tags","blobs_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/statuses/{sha}","languages_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/languages","stargazers_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/stargazers","contributors_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/contributors","subscribers_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/subscribers","subscription_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/subscription","commits_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/contents/{+path}","compare_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/merges","archive_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/downloads","issues_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/issues{/number}","pulls_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/pulls{/number}","milestones_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/milestones{/number}","notifications_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/labels{/name}","releases_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/releases{/id}","deployments_url":"https://api.github.com/repos/CodesCubesAndCrashes/AgriCraft/deployments","created_at":"2017-05-13T22:10:30Z","updated_at":"2017-06-05T18:42:06Z","pushed_at":"2017-06-24T06:25:48Z","git_url":"git://github.com/CodesCubesAndCrashes/AgriCraft.git","ssh_url":"[email protected]:CodesCubesAndCrashes/AgriCraft.git","clone_url":"https://github.com/CodesCubesAndCrashes/AgriCraft.git","svn_url":"https://github.com/CodesCubesAndCrashes/AgriCraft","homepage":null,"size":7976,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AgriCraft:master","ref":"master","sha":"a27738c3c98cdd96cbf7e17f0951c0ac4692aa7b","user":{"login":"AgriCraft","id":18352825,"avatar_url":"https://avatars0.githubusercontent.com/u/18352825?v=3","gravatar_id":"","url":"https://api.github.com/users/AgriCraft","html_url":"https://github.com/AgriCraft","followers_url":"https://api.github.com/users/AgriCraft/followers","following_url":"https://api.github.com/users/AgriCraft/following{/other_user}","gists_url":"https://api.github.com/users/AgriCraft/gists{/gist_id}","starred_url":"https://api.github.com/users/AgriCraft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgriCraft/subscriptions","organizations_url":"https://api.github.com/users/AgriCraft/orgs","repos_url":"https://api.github.com/users/AgriCraft/repos","events_url":"https://api.github.com/users/AgriCraft/events{/privacy}","received_events_url":"https://api.github.com/users/AgriCraft/received_events","type":"Organization","site_admin":false},"repo":{"id":26712042,"name":"AgriCraft","full_name":"AgriCraft/AgriCraft","owner":{"login":"AgriCraft","id":18352825,"avatar_url":"https://avatars0.githubusercontent.com/u/18352825?v=3","gravatar_id":"","url":"https://api.github.com/users/AgriCraft","html_url":"https://github.com/AgriCraft","followers_url":"https://api.github.com/users/AgriCraft/followers","following_url":"https://api.github.com/users/AgriCraft/following{/other_user}","gists_url":"https://api.github.com/users/AgriCraft/gists{/gist_id}","starred_url":"https://api.github.com/users/AgriCraft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgriCraft/subscriptions","organizations_url":"https://api.github.com/users/AgriCraft/orgs","repos_url":"https://api.github.com/users/AgriCraft/repos","events_url":"https://api.github.com/users/AgriCraft/events{/privacy}","received_events_url":"https://api.github.com/users/AgriCraft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AgriCraft/AgriCraft","description":"The source code for the Minecraft mod: AgriCraft","fork":false,"url":"https://api.github.com/repos/AgriCraft/AgriCraft","forks_url":"https://api.github.com/repos/AgriCraft/AgriCraft/forks","keys_url":"https://api.github.com/repos/AgriCraft/AgriCraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AgriCraft/AgriCraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AgriCraft/AgriCraft/teams","hooks_url":"https://api.github.com/repos/AgriCraft/AgriCraft/hooks","issue_events_url":"https://api.github.com/repos/AgriCraft/AgriCraft/issues/events{/number}","events_url":"https://api.github.com/repos/AgriCraft/AgriCraft/events","assignees_url":"https://api.github.com/repos/AgriCraft/AgriCraft/assignees{/user}","branches_url":"https://api.github.com/repos/AgriCraft/AgriCraft/branches{/branch}","tags_url":"https://api.github.com/repos/AgriCraft/AgriCraft/tags","blobs_url":"https://api.github.com/repos/AgriCraft/AgriCraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AgriCraft/AgriCraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AgriCraft/AgriCraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/AgriCraft/AgriCraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AgriCraft/AgriCraft/statuses/{sha}","languages_url":"https://api.github.com/repos/AgriCraft/AgriCraft/languages","stargazers_url":"https://api.github.com/repos/AgriCraft/AgriCraft/stargazers","contributors_url":"https://api.github.com/repos/AgriCraft/AgriCraft/contributors","subscribers_url":"https://api.github.com/repos/AgriCraft/AgriCraft/subscribers","subscription_url":"https://api.github.com/repos/AgriCraft/AgriCraft/subscription","commits_url":"https://api.github.com/repos/AgriCraft/AgriCraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/AgriCraft/AgriCraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/AgriCraft/AgriCraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/AgriCraft/AgriCraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/AgriCraft/AgriCraft/contents/{+path}","compare_url":"https://api.github.com/repos/AgriCraft/AgriCraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AgriCraft/AgriCraft/merges","archive_url":"https://api.github.com/repos/AgriCraft/AgriCraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AgriCraft/AgriCraft/downloads","issues_url":"https://api.github.com/repos/AgriCraft/AgriCraft/issues{/number}","pulls_url":"https://api.github.com/repos/AgriCraft/AgriCraft/pulls{/number}","milestones_url":"https://api.github.com/repos/AgriCraft/AgriCraft/milestones{/number}","notifications_url":"https://api.github.com/repos/AgriCraft/AgriCraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AgriCraft/AgriCraft/labels{/name}","releases_url":"https://api.github.com/repos/AgriCraft/AgriCraft/releases{/id}","deployments_url":"https://api.github.com/repos/AgriCraft/AgriCraft/deployments","created_at":"2014-11-16T11:26:36Z","updated_at":"2017-06-21T16:29:14Z","pushed_at":"2017-06-24T06:25:49Z","git_url":"git://github.com/AgriCraft/AgriCraft.git","ssh_url":"[email protected]:AgriCraft/AgriCraft.git","clone_url":"https://github.com/AgriCraft/AgriCraft.git","svn_url":"https://github.com/AgriCraft/AgriCraft","homepage":null,"size":7951,"stargazers_count":108,"watchers_count":108,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":45,"forks":57,"open_issues":45,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AgriCraft/AgriCraft/pulls/1008"},"html":{"href":"https://github.com/AgriCraft/AgriCraft/pull/1008"},"issue":{"href":"https://api.github.com/repos/AgriCraft/AgriCraft/issues/1008"},"comments":{"href":"https://api.github.com/repos/AgriCraft/AgriCraft/issues/1008/comments"},"review_comments":{"href":"https://api.github.com/repos/AgriCraft/AgriCraft/pulls/1008/comments"},"review_comment":{"href":"https://api.github.com/repos/AgriCraft/AgriCraft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AgriCraft/AgriCraft/pulls/1008/commits"},"statuses":{"href":"https://api.github.com/repos/AgriCraft/AgriCraft/statuses/91529366817c9c9f4b3c40da6b24fa18e50d1a99"}}}} | {
"id": 26712042,
"name": "AgriCraft/AgriCraft",
"url": "https://api.github.com/repos/AgriCraft/AgriCraft"
} | {
"id": 28678248,
"login": "CodesCubesAndCrashes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28678248?",
"url": "https://api.github.com/users/CodesCubesAndCrashes"
} | {
"id": 18352825,
"login": "AgriCraft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18352825?",
"url": "https://api.github.com/orgs/AgriCraft"
} | 2017-06-24T06:39:23 | 6130569375 | {"actor":{"display_login":"CodesCubesAndCrashes"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/123654787","pull_request_review_id":45876380,"id":123654787,"diff_hunk":"@@ -51,6 +51,11 @@ void Copter::motor_test_output()\n // calculate pwm based on throttle type\n switch (motor_test_throttle_type) {\n \n+ case MOTOR_TEST_COMPASS_CAL:\n+ compass.set_voltage(battery.voltage());","path":"ArduCopter/motor_test.cpp","position":48,"original_position":5,"commit_id":"f35ebece067fa61e21f5b135af68c60ee68b203b","original_commit_id":"5abd58fe1e9a2514f0800f8c0f9244ac2f15eb2d","user":{"login":"OXINARF","id":1778527,"avatar_url":"https://avatars1.githubusercontent.com/u/1778527?v=3","gravatar_id":"","url":"https://api.github.com/users/OXINARF","html_url":"https://github.com/OXINARF","followers_url":"https://api.github.com/users/OXINARF/followers","following_url":"https://api.github.com/users/OXINARF/following{/other_user}","gists_url":"https://api.github.com/users/OXINARF/gists{/gist_id}","starred_url":"https://api.github.com/users/OXINARF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OXINARF/subscriptions","organizations_url":"https://api.github.com/users/OXINARF/orgs","repos_url":"https://api.github.com/users/OXINARF/repos","events_url":"https://api.github.com/users/OXINARF/events{/privacy}","received_events_url":"https://api.github.com/users/OXINARF/received_events","type":"User","site_admin":false},"body":"Any reason to do this here? Without reading the battery again, this should always be setting the same value.","created_at":"2017-06-23T01:05:58Z","updated_at":"2017-06-23T01:27:22Z","html_url":"https://github.com/ArduPilot/ardupilot/pull/6448#discussion_r123654787","pull_request_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/6448","_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/123654787"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/6448#discussion_r123654787"},"pull_request":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/6448"}}},"pull_request":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/6448","id":126142976,"html_url":"https://github.com/ArduPilot/ardupilot/pull/6448","diff_url":"https://github.com/ArduPilot/ardupilot/pull/6448.diff","patch_url":"https://github.com/ArduPilot/ardupilot/pull/6448.patch","issue_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/6448","number":6448,"state":"open","locked":false,"title":"Compass: implement per-motor compass compensation","user":{"login":"tridge","id":831867,"avatar_url":"https://avatars1.githubusercontent.com/u/831867?v=3","gravatar_id":"","url":"https://api.github.com/users/tridge","html_url":"https://github.com/tridge","followers_url":"https://api.github.com/users/tridge/followers","following_url":"https://api.github.com/users/tridge/following{/other_user}","gists_url":"https://api.github.com/users/tridge/gists{/gist_id}","starred_url":"https://api.github.com/users/tridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridge/subscriptions","organizations_url":"https://api.github.com/users/tridge/orgs","repos_url":"https://api.github.com/users/tridge/repos","events_url":"https://api.github.com/users/tridge/events{/privacy}","received_events_url":"https://api.github.com/users/tridge/received_events","type":"User","site_admin":false},"body":"This implements an alternative form of motor interference compass compensation for small vehicles. It learns offsets per-motor, which makes for much more accurate compensation, and uses a scaling factor between demanded output, voltage and magnetic interference. \r\nThe result is remarkably good compass compensation when motors and wiring are very close to a compass in a small quadcopter.\r\nThe code is quadcopter specific (though could work on a quadplane). It could be extended to work for other multicopters with more parameters, although the need isn't clear as other multirotor types tend to be larger and it is easier to move the compass to a better location.\r\nThe calibration process uses the existing motortest code, which is very convenient, and also provides for a simple way to test the results.\r\n","created_at":"2017-06-17T04:45:00Z","updated_at":"2017-06-23T01:27:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d5367af4c197e26e769608f1c567c10c82d1ce6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/6448/commits","review_comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/6448/comments","review_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/6448/comments","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/f35ebece067fa61e21f5b135af68c60ee68b203b","head":{"label":"tridge:pr-compass-per-motor","ref":"pr-compass-per-motor","sha":"f35ebece067fa61e21f5b135af68c60ee68b203b","user":{"login":"tridge","id":831867,"avatar_url":"https://avatars1.githubusercontent.com/u/831867?v=3","gravatar_id":"","url":"https://api.github.com/users/tridge","html_url":"https://github.com/tridge","followers_url":"https://api.github.com/users/tridge/followers","following_url":"https://api.github.com/users/tridge/following{/other_user}","gists_url":"https://api.github.com/users/tridge/gists{/gist_id}","starred_url":"https://api.github.com/users/tridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridge/subscriptions","organizations_url":"https://api.github.com/users/tridge/orgs","repos_url":"https://api.github.com/users/tridge/repos","events_url":"https://api.github.com/users/tridge/events{/privacy}","received_events_url":"https://api.github.com/users/tridge/received_events","type":"User","site_admin":false},"repo":{"id":7513848,"name":"ardupilot","full_name":"tridge/ardupilot","owner":{"login":"tridge","id":831867,"avatar_url":"https://avatars1.githubusercontent.com/u/831867?v=3","gravatar_id":"","url":"https://api.github.com/users/tridge","html_url":"https://github.com/tridge","followers_url":"https://api.github.com/users/tridge/followers","following_url":"https://api.github.com/users/tridge/following{/other_user}","gists_url":"https://api.github.com/users/tridge/gists{/gist_id}","starred_url":"https://api.github.com/users/tridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridge/subscriptions","organizations_url":"https://api.github.com/users/tridge/orgs","repos_url":"https://api.github.com/users/tridge/repos","events_url":"https://api.github.com/users/tridge/events{/privacy}","received_events_url":"https://api.github.com/users/tridge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tridge/ardupilot","description":null,"fork":true,"url":"https://api.github.com/repos/tridge/ardupilot","forks_url":"https://api.github.com/repos/tridge/ardupilot/forks","keys_url":"https://api.github.com/repos/tridge/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tridge/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tridge/ardupilot/teams","hooks_url":"https://api.github.com/repos/tridge/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/tridge/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/tridge/ardupilot/events","assignees_url":"https://api.github.com/repos/tridge/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/tridge/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/tridge/ardupilot/tags","blobs_url":"https://api.github.com/repos/tridge/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tridge/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tridge/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/tridge/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tridge/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/tridge/ardupilot/languages","stargazers_url":"https://api.github.com/repos/tridge/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/tridge/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/tridge/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/tridge/ardupilot/subscription","commits_url":"https://api.github.com/repos/tridge/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/tridge/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/tridge/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/tridge/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/tridge/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/tridge/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tridge/ardupilot/merges","archive_url":"https://api.github.com/repos/tridge/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tridge/ardupilot/downloads","issues_url":"https://api.github.com/repos/tridge/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/tridge/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/tridge/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/tridge/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tridge/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/tridge/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/tridge/ardupilot/deployments","created_at":"2013-01-09T02:57:15Z","updated_at":"2016-11-14T02:01:06Z","pushed_at":"2017-06-21T10:34:30Z","git_url":"git://github.com/tridge/ardupilot.git","ssh_url":"[email protected]:tridge/ardupilot.git","clone_url":"https://github.com/tridge/ardupilot.git","svn_url":"https://github.com/tridge/ardupilot","homepage":null,"size":96362,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":12,"default_branch":"master"}},"base":{"label":"ArduPilot:master","ref":"master","sha":"92cdb541769dc47f6f9d8e920de3672a7f917c9c","user":{"login":"ArduPilot","id":17919847,"avatar_url":"https://avatars0.githubusercontent.com/u/17919847?v=3","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"repo":{"id":7512484,"name":"ardupilot","full_name":"ArduPilot/ardupilot","owner":{"login":"ArduPilot","id":17919847,"avatar_url":"https://avatars0.githubusercontent.com/u/17919847?v=3","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ArduPilot/ardupilot","description":"ArduPlane, ArduCopter, ArduRover source","fork":false,"url":"https://api.github.com/repos/ArduPilot/ardupilot","forks_url":"https://api.github.com/repos/ArduPilot/ardupilot/forks","keys_url":"https://api.github.com/repos/ArduPilot/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArduPilot/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArduPilot/ardupilot/teams","hooks_url":"https://api.github.com/repos/ArduPilot/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/ArduPilot/ardupilot/events","assignees_url":"https://api.github.com/repos/ArduPilot/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/ArduPilot/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/tags","blobs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/ArduPilot/ardupilot/languages","stargazers_url":"https://api.github.com/repos/ArduPilot/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/ArduPilot/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscription","commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArduPilot/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/ArduPilot/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArduPilot/ardupilot/merges","archive_url":"https://api.github.com/repos/ArduPilot/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArduPilot/ardupilot/downloads","issues_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/ArduPilot/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/ArduPilot/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArduPilot/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/ArduPilot/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/ArduPilot/ardupilot/deployments","created_at":"2013-01-09T00:58:52Z","updated_at":"2017-06-22T10:46:31Z","pushed_at":"2017-06-22T23:43:59Z","git_url":"git://github.com/ArduPilot/ardupilot.git","ssh_url":"[email protected]:ArduPilot/ardupilot.git","clone_url":"https://github.com/ArduPilot/ardupilot.git","svn_url":"https://github.com/ArduPilot/ardupilot","homepage":"http://ardupilot.org/","size":89341,"stargazers_count":2575,"watchers_count":2575,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5364,"mirror_url":null,"open_issues_count":971,"forks":5364,"open_issues":971,"watchers":2575,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/6448"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/6448"},"issue":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/6448"},"comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/6448/comments"},"review_comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/6448/comments"},"review_comment":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/6448/commits"},"statuses":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/f35ebece067fa61e21f5b135af68c60ee68b203b"}}}} | {
"id": 7512484,
"name": "ArduPilot/ardupilot",
"url": "https://api.github.com/repos/ArduPilot/ardupilot"
} | {
"id": 1778527,
"login": "OXINARF",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1778527?",
"url": "https://api.github.com/users/OXINARF"
} | {
"id": 17919847,
"login": "ArduPilot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17919847?",
"url": "https://api.github.com/orgs/ArduPilot"
} | 2017-06-23T01:05:58 | 6122806693 | {"actor":{"display_login":"OXINARF"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Comunitea/CMNT_004_15/pulls/comments/115784763","pull_request_review_id":37354008,"id":115784763,"diff_hunk":"@@ -0,0 +1,137 @@\n+# -*- coding: utf-8 -*-\n+##############################################################################\n+#\n+# OpenERP, Open Source Management Solution\n+# Copyright (C) 2004-today OpenERP SA (<http://www.openerp.com>)\n+#\n+# This program is free software: you can redistribute it and/or modify\n+# it under the terms of the GNU Affero General Public License as\n+# published by the Free Software Foundation, either version 3 of the\n+# License, or (at your option) any later version.\n+#\n+# This program is distributed in the hope that it will be useful,\n+# but WITHOUT ANY WARRANTY; without even the implied warranty of\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+# GNU Affero General Public License for more details.\n+#\n+# You should have received a copy of the GNU Affero General Public License\n+# along with this program. If not, see <http://www.gnu.org/licenses/>.\n+#\n+##############################################################################\n+from openerp import models, fields, api, exceptions, _\n+from openerp.exceptions import except_orm\n+from datetime import datetime\n+\n+class partner_visit(models.Model):\n+ \"\"\" Model for Partner Visits \"\"\"\n+ _name = \"partner.visit\"\n+ _rec_name = \"partner_id\"\n+ _description = \"Partner Visit\"\n+ _order = \"visit_date desc\"\n+\n+ create_date = fields.Datetime('Creation Date', readonly=True, default=fields.Datetime.now)\n+ visit_date = fields.Datetime('Visit Date', required=True)\n+ user_id = fields.Many2one('res.users', 'External salesperson', readonly=True)\n+ partner_id = fields.Many2one('res.partner', 'Partner', required=True)\n+ partner_address = fields.Char('Address', readonly=True, compute='get_address')\n+ description = fields.Text('Summary', required=True)\n+ visit_state = fields.Selection([('log', 'Log'), ('schedule', 'Schedule')], string='Status', readonly=True)\n+ email_sent = fields.Boolean('Email sent', default=False, readonly=True)\n+ salesperson_select = fields.Many2one('res.users', 'Notify to', readonly=True,\n+ compute='get_internal_salesperson', store=True)\n+ confirm_done = fields.Boolean('Done', default=False)\n+\n+ _defaults = {\n+ 'create_date': fields.Datetime.now(),\n+ 'user_id': lambda self, cr, uid, ctx: uid\n+ }\n+\n+ @api.multi\n+ def validate_fields(self, self_data, changes):","path":"project-addons/external_salesperson_visit/partner_visit.py","position":null,"original_position":50,"commit_id":"6dcaf609040a3011aa701b05aef48bd0aeb1fef9","original_commit_id":"3c2fa1862ee60fb7ed2944fb1abc22939c2cd2b9","user":{"login":"Naferreyra","id":26384249,"avatar_url":"https://avatars0.githubusercontent.com/u/26384249?v=3","gravatar_id":"","url":"https://api.github.com/users/Naferreyra","html_url":"https://github.com/Naferreyra","followers_url":"https://api.github.com/users/Naferreyra/followers","following_url":"https://api.github.com/users/Naferreyra/following{/other_user}","gists_url":"https://api.github.com/users/Naferreyra/gists{/gist_id}","starred_url":"https://api.github.com/users/Naferreyra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Naferreyra/subscriptions","organizations_url":"https://api.github.com/users/Naferreyra/orgs","repos_url":"https://api.github.com/users/Naferreyra/repos","events_url":"https://api.github.com/users/Naferreyra/events{/privacy}","received_events_url":"https://api.github.com/users/Naferreyra/received_events","type":"User","site_admin":false},"body":"Vale. Lo dejamos como está e incorporo el cambio que me comentas en el próximo Pull Request.","created_at":"2017-05-10T16:12:54Z","updated_at":"2017-05-10T16:12:54Z","html_url":"https://github.com/Comunitea/CMNT_004_15/pull/22#discussion_r115784763","pull_request_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/Comunitea/CMNT_004_15/pulls/comments/115784763"},"html":{"href":"https://github.com/Comunitea/CMNT_004_15/pull/22#discussion_r115784763"},"pull_request":{"href":"https://api.github.com/repos/Comunitea/CMNT_004_15/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/Comunitea/CMNT_004_15/pulls/22","id":119004449,"html_url":"https://github.com/Comunitea/CMNT_004_15/pull/22","diff_url":"https://github.com/Comunitea/CMNT_004_15/pull/22.diff","patch_url":"https://github.com/Comunitea/CMNT_004_15/pull/22.patch","issue_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/issues/22","number":22,"state":"open","locked":false,"title":"Cambios realizados","user":{"login":"Naferreyra","id":26384249,"avatar_url":"https://avatars0.githubusercontent.com/u/26384249?v=3","gravatar_id":"","url":"https://api.github.com/users/Naferreyra","html_url":"https://github.com/Naferreyra","followers_url":"https://api.github.com/users/Naferreyra/followers","following_url":"https://api.github.com/users/Naferreyra/following{/other_user}","gists_url":"https://api.github.com/users/Naferreyra/gists{/gist_id}","starred_url":"https://api.github.com/users/Naferreyra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Naferreyra/subscriptions","organizations_url":"https://api.github.com/users/Naferreyra/orgs","repos_url":"https://api.github.com/users/Naferreyra/repos","events_url":"https://api.github.com/users/Naferreyra/events{/privacy}","received_events_url":"https://api.github.com/users/Naferreyra/received_events","type":"User","site_admin":false},"body":"- [FIX] 'custom_partner': Uso datos línea de facturas en cálculo margen medio\r\n- [IMP] 'external_salesperson_visit': Nuevo módulo para registrar visitas a clientes\r\n- [IMP] 'custom_account': Uso de commercial_partner_id en el buscador de análisis de facturas\r\n- [IMP] 'custom_account': Uso de 'commercial_partner_id' en búsqueda de Facturas y en agrupaciones\r\n- [IMP] 'external_salesperson_visit': Comercial a notificar automático en función del cliente seleccionado y literales\r\n- [IMP] 'crm_claim_rma_custom': Nuevo valor en selector tipo de llamada y literales","created_at":"2017-05-04T15:42:01Z","updated_at":"2017-05-10T16:12:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4f0e0a1f37e17ae737ab9b1691963e73166e1b5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/pulls/22/commits","review_comments_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/pulls/22/comments","review_comment_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/issues/22/comments","statuses_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/statuses/6dcaf609040a3011aa701b05aef48bd0aeb1fef9","head":{"label":"jgmanzanas:master","ref":"master","sha":"6dcaf609040a3011aa701b05aef48bd0aeb1fef9","user":{"login":"jgmanzanas","id":22660449,"avatar_url":"https://avatars0.githubusercontent.com/u/22660449?v=3","gravatar_id":"","url":"https://api.github.com/users/jgmanzanas","html_url":"https://github.com/jgmanzanas","followers_url":"https://api.github.com/users/jgmanzanas/followers","following_url":"https://api.github.com/users/jgmanzanas/following{/other_user}","gists_url":"https://api.github.com/users/jgmanzanas/gists{/gist_id}","starred_url":"https://api.github.com/users/jgmanzanas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgmanzanas/subscriptions","organizations_url":"https://api.github.com/users/jgmanzanas/orgs","repos_url":"https://api.github.com/users/jgmanzanas/repos","events_url":"https://api.github.com/users/jgmanzanas/events{/privacy}","received_events_url":"https://api.github.com/users/jgmanzanas/received_events","type":"User","site_admin":false},"repo":{"id":72113082,"name":"CMNT_004_15","full_name":"jgmanzanas/CMNT_004_15","owner":{"login":"jgmanzanas","id":22660449,"avatar_url":"https://avatars0.githubusercontent.com/u/22660449?v=3","gravatar_id":"","url":"https://api.github.com/users/jgmanzanas","html_url":"https://github.com/jgmanzanas","followers_url":"https://api.github.com/users/jgmanzanas/followers","following_url":"https://api.github.com/users/jgmanzanas/following{/other_user}","gists_url":"https://api.github.com/users/jgmanzanas/gists{/gist_id}","starred_url":"https://api.github.com/users/jgmanzanas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgmanzanas/subscriptions","organizations_url":"https://api.github.com/users/jgmanzanas/orgs","repos_url":"https://api.github.com/users/jgmanzanas/repos","events_url":"https://api.github.com/users/jgmanzanas/events{/privacy}","received_events_url":"https://api.github.com/users/jgmanzanas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgmanzanas/CMNT_004_15","description":null,"fork":true,"url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15","forks_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/forks","keys_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/teams","hooks_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/hooks","issue_events_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/issues/events{/number}","events_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/events","assignees_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/assignees{/user}","branches_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/branches{/branch}","tags_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/tags","blobs_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/statuses/{sha}","languages_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/languages","stargazers_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/stargazers","contributors_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/contributors","subscribers_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/subscribers","subscription_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/subscription","commits_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/contents/{+path}","compare_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/merges","archive_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/downloads","issues_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/issues{/number}","pulls_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/pulls{/number}","milestones_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/milestones{/number}","notifications_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/labels{/name}","releases_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/releases{/id}","deployments_url":"https://api.github.com/repos/jgmanzanas/CMNT_004_15/deployments","created_at":"2016-10-27T13:52:57Z","updated_at":"2017-03-22T17:03:54Z","pushed_at":"2017-05-10T15:55:50Z","git_url":"git://github.com/jgmanzanas/CMNT_004_15.git","ssh_url":"[email protected]:jgmanzanas/CMNT_004_15.git","clone_url":"https://github.com/jgmanzanas/CMNT_004_15.git","svn_url":"https://github.com/jgmanzanas/CMNT_004_15","homepage":null,"size":2584,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Comunitea:master","ref":"master","sha":"0d65e261ae35c7ba8472e28be336ec0552cf3e07","user":{"login":"Comunitea","id":11162919,"avatar_url":"https://avatars2.githubusercontent.com/u/11162919?v=3","gravatar_id":"","url":"https://api.github.com/users/Comunitea","html_url":"https://github.com/Comunitea","followers_url":"https://api.github.com/users/Comunitea/followers","following_url":"https://api.github.com/users/Comunitea/following{/other_user}","gists_url":"https://api.github.com/users/Comunitea/gists{/gist_id}","starred_url":"https://api.github.com/users/Comunitea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Comunitea/subscriptions","organizations_url":"https://api.github.com/users/Comunitea/orgs","repos_url":"https://api.github.com/users/Comunitea/repos","events_url":"https://api.github.com/users/Comunitea/events{/privacy}","received_events_url":"https://api.github.com/users/Comunitea/received_events","type":"Organization","site_admin":false},"repo":{"id":36653955,"name":"CMNT_004_15","full_name":"Comunitea/CMNT_004_15","owner":{"login":"Comunitea","id":11162919,"avatar_url":"https://avatars2.githubusercontent.com/u/11162919?v=3","gravatar_id":"","url":"https://api.github.com/users/Comunitea","html_url":"https://github.com/Comunitea","followers_url":"https://api.github.com/users/Comunitea/followers","following_url":"https://api.github.com/users/Comunitea/following{/other_user}","gists_url":"https://api.github.com/users/Comunitea/gists{/gist_id}","starred_url":"https://api.github.com/users/Comunitea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Comunitea/subscriptions","organizations_url":"https://api.github.com/users/Comunitea/orgs","repos_url":"https://api.github.com/users/Comunitea/repos","events_url":"https://api.github.com/users/Comunitea/events{/privacy}","received_events_url":"https://api.github.com/users/Comunitea/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Comunitea/CMNT_004_15","description":null,"fork":true,"url":"https://api.github.com/repos/Comunitea/CMNT_004_15","forks_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/forks","keys_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/teams","hooks_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/hooks","issue_events_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/issues/events{/number}","events_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/events","assignees_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/assignees{/user}","branches_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/branches{/branch}","tags_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/tags","blobs_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/git/refs{/sha}","trees_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/statuses/{sha}","languages_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/languages","stargazers_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/stargazers","contributors_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/contributors","subscribers_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/subscribers","subscription_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/subscription","commits_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/commits{/sha}","git_commits_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/git/commits{/sha}","comments_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/comments{/number}","issue_comment_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/issues/comments{/number}","contents_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/contents/{+path}","compare_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/merges","archive_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/downloads","issues_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/issues{/number}","pulls_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/pulls{/number}","milestones_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/milestones{/number}","notifications_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/labels{/name}","releases_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/releases{/id}","deployments_url":"https://api.github.com/repos/Comunitea/CMNT_004_15/deployments","created_at":"2015-06-01T10:32:07Z","updated_at":"2016-10-24T14:00:48Z","pushed_at":"2017-05-10T15:55:52Z","git_url":"git://github.com/Comunitea/CMNT_004_15.git","ssh_url":"[email protected]:Comunitea/CMNT_004_15.git","clone_url":"https://github.com/Comunitea/CMNT_004_15.git","svn_url":"https://github.com/Comunitea/CMNT_004_15","homepage":null,"size":2563,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Comunitea/CMNT_004_15/pulls/22"},"html":{"href":"https://github.com/Comunitea/CMNT_004_15/pull/22"},"issue":{"href":"https://api.github.com/repos/Comunitea/CMNT_004_15/issues/22"},"comments":{"href":"https://api.github.com/repos/Comunitea/CMNT_004_15/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/Comunitea/CMNT_004_15/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/Comunitea/CMNT_004_15/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Comunitea/CMNT_004_15/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/Comunitea/CMNT_004_15/statuses/6dcaf609040a3011aa701b05aef48bd0aeb1fef9"}}}} | {
"id": 36653955,
"name": "Comunitea/CMNT_004_15",
"url": "https://api.github.com/repos/Comunitea/CMNT_004_15"
} | {
"id": 26384249,
"login": "Naferreyra",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26384249?",
"url": "https://api.github.com/users/Naferreyra"
} | {
"id": 11162919,
"login": "Comunitea",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11162919?",
"url": "https://api.github.com/orgs/Comunitea"
} | 2017-05-10T16:12:54 | 5846458295 | {"actor":{"display_login":"Naferreyra"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/comments/152807779","pull_request_review_id":78725991,"id":152807779,"diff_hunk":"@@ -262,13 +288,19 @@ public function call($method, $headers = [], $body = '')\n while (!$response && count($hostConfigs)) {\n reset($hostConfigs);\n $numRetriesLeft = count($hostConfigs) - 1;\n- $hostName = key($hostConfigs);\n- $this->lastHost = $hostName;\n+\n+ // If we already have a socket for this pid and cluster, then we first try to reuse it","path":"src/Client.php","position":99,"original_position":99,"commit_id":"a6eb0af1152fbd84fb6666e42bc5f86ce57bea1c","original_commit_id":"a6eb0af1152fbd84fb6666e42bc5f86ce57bea1c","user":{"login":"flodnv","id":4164921,"avatar_url":"https://avatars3.githubusercontent.com/u/4164921?v=4","gravatar_id":"","url":"https://api.github.com/users/flodnv","html_url":"https://github.com/flodnv","followers_url":"https://api.github.com/users/flodnv/followers","following_url":"https://api.github.com/users/flodnv/following{/other_user}","gists_url":"https://api.github.com/users/flodnv/gists{/gist_id}","starred_url":"https://api.github.com/users/flodnv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flodnv/subscriptions","organizations_url":"https://api.github.com/users/flodnv/orgs","repos_url":"https://api.github.com/users/flodnv/repos","events_url":"https://api.github.com/users/flodnv/events{/privacy}","received_events_url":"https://api.github.com/users/flodnv/received_events","type":"User","site_admin":false},"body":"`- for this pid`","created_at":"2017-11-23T14:02:16Z","updated_at":"2017-11-23T14:02:46Z","html_url":"https://github.com/Expensify/Bedrock-PHP/pull/61#discussion_r152807779","pull_request_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/61","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/comments/152807779"},"html":{"href":"https://github.com/Expensify/Bedrock-PHP/pull/61#discussion_r152807779"},"pull_request":{"href":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/61","id":153628417,"html_url":"https://github.com/Expensify/Bedrock-PHP/pull/61","diff_url":"https://github.com/Expensify/Bedrock-PHP/pull/61.diff","patch_url":"https://github.com/Expensify/Bedrock-PHP/pull/61.patch","issue_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues/61","number":61,"state":"open","locked":false,"title":"[HOLD] Reuse sockets","user":{"login":"iwiznia","id":521248,"avatar_url":"https://avatars1.githubusercontent.com/u/521248?v=4","gravatar_id":"","url":"https://api.github.com/users/iwiznia","html_url":"https://github.com/iwiznia","followers_url":"https://api.github.com/users/iwiznia/followers","following_url":"https://api.github.com/users/iwiznia/following{/other_user}","gists_url":"https://api.github.com/users/iwiznia/gists{/gist_id}","starred_url":"https://api.github.com/users/iwiznia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iwiznia/subscriptions","organizations_url":"https://api.github.com/users/iwiznia/orgs","repos_url":"https://api.github.com/users/iwiznia/repos","events_url":"https://api.github.com/users/iwiznia/events{/privacy}","received_events_url":"https://api.github.com/users/iwiznia/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/Expensify/Expensify/issues/66144\r\n\r\nThis introduces socket reutilization to the bedrock Client class. In order to support being used in a multi threaded environment, like in BWM, it stores the sockets per pid, cluster and host name.\r\n\r\n/cc @quinthar ","created_at":"2017-11-20T13:25:28Z","updated_at":"2017-11-23T14:02:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e74974688565ed2b5dcf838fa3713982cbd5f9ea","assignee":{"login":"iwiznia","id":521248,"avatar_url":"https://avatars1.githubusercontent.com/u/521248?v=4","gravatar_id":"","url":"https://api.github.com/users/iwiznia","html_url":"https://github.com/iwiznia","followers_url":"https://api.github.com/users/iwiznia/followers","following_url":"https://api.github.com/users/iwiznia/following{/other_user}","gists_url":"https://api.github.com/users/iwiznia/gists{/gist_id}","starred_url":"https://api.github.com/users/iwiznia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iwiznia/subscriptions","organizations_url":"https://api.github.com/users/iwiznia/orgs","repos_url":"https://api.github.com/users/iwiznia/repos","events_url":"https://api.github.com/users/iwiznia/events{/privacy}","received_events_url":"https://api.github.com/users/iwiznia/received_events","type":"User","site_admin":false},"assignees":[{"login":"iwiznia","id":521248,"avatar_url":"https://avatars1.githubusercontent.com/u/521248?v=4","gravatar_id":"","url":"https://api.github.com/users/iwiznia","html_url":"https://github.com/iwiznia","followers_url":"https://api.github.com/users/iwiznia/followers","following_url":"https://api.github.com/users/iwiznia/following{/other_user}","gists_url":"https://api.github.com/users/iwiznia/gists{/gist_id}","starred_url":"https://api.github.com/users/iwiznia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iwiznia/subscriptions","organizations_url":"https://api.github.com/users/iwiznia/orgs","repos_url":"https://api.github.com/users/iwiznia/repos","events_url":"https://api.github.com/users/iwiznia/events{/privacy}","received_events_url":"https://api.github.com/users/iwiznia/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/61/commits","review_comments_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/61/comments","review_comment_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues/61/comments","statuses_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/statuses/a6eb0af1152fbd84fb6666e42bc5f86ce57bea1c","head":{"label":"Expensify:ionatan_reuse_sockets","ref":"ionatan_reuse_sockets","sha":"a6eb0af1152fbd84fb6666e42bc5f86ce57bea1c","user":{"login":"Expensify","id":476779,"avatar_url":"https://avatars0.githubusercontent.com/u/476779?v=4","gravatar_id":"","url":"https://api.github.com/users/Expensify","html_url":"https://github.com/Expensify","followers_url":"https://api.github.com/users/Expensify/followers","following_url":"https://api.github.com/users/Expensify/following{/other_user}","gists_url":"https://api.github.com/users/Expensify/gists{/gist_id}","starred_url":"https://api.github.com/users/Expensify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Expensify/subscriptions","organizations_url":"https://api.github.com/users/Expensify/orgs","repos_url":"https://api.github.com/users/Expensify/repos","events_url":"https://api.github.com/users/Expensify/events{/privacy}","received_events_url":"https://api.github.com/users/Expensify/received_events","type":"Organization","site_admin":false},"repo":{"id":68838259,"name":"Bedrock-PHP","full_name":"Expensify/Bedrock-PHP","owner":{"login":"Expensify","id":476779,"avatar_url":"https://avatars0.githubusercontent.com/u/476779?v=4","gravatar_id":"","url":"https://api.github.com/users/Expensify","html_url":"https://github.com/Expensify","followers_url":"https://api.github.com/users/Expensify/followers","following_url":"https://api.github.com/users/Expensify/following{/other_user}","gists_url":"https://api.github.com/users/Expensify/gists{/gist_id}","starred_url":"https://api.github.com/users/Expensify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Expensify/subscriptions","organizations_url":"https://api.github.com/users/Expensify/orgs","repos_url":"https://api.github.com/users/Expensify/repos","events_url":"https://api.github.com/users/Expensify/events{/privacy}","received_events_url":"https://api.github.com/users/Expensify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Expensify/Bedrock-PHP","description":null,"fork":false,"url":"https://api.github.com/repos/Expensify/Bedrock-PHP","forks_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/forks","keys_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/teams","hooks_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/hooks","issue_events_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues/events{/number}","events_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/events","assignees_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/assignees{/user}","branches_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/branches{/branch}","tags_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/tags","blobs_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/refs{/sha}","trees_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/statuses/{sha}","languages_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/languages","stargazers_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/stargazers","contributors_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/contributors","subscribers_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/subscribers","subscription_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/subscription","commits_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/commits{/sha}","git_commits_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/commits{/sha}","comments_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/comments{/number}","issue_comment_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues/comments{/number}","contents_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/contents/{+path}","compare_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/merges","archive_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/downloads","issues_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues{/number}","pulls_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls{/number}","milestones_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/milestones{/number}","notifications_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/labels{/name}","releases_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/releases{/id}","deployments_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/deployments","created_at":"2016-09-21T16:52:46Z","updated_at":"2017-11-17T07:47:14Z","pushed_at":"2017-11-23T12:40:21Z","git_url":"git://github.com/Expensify/Bedrock-PHP.git","ssh_url":"[email protected]:Expensify/Bedrock-PHP.git","clone_url":"https://github.com/Expensify/Bedrock-PHP.git","svn_url":"https://github.com/Expensify/Bedrock-PHP","homepage":null,"size":245,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":5,"default_branch":"master"}},"base":{"label":"Expensify:master","ref":"master","sha":"e7e7582a53d1b17bcab6298ee4a03d86e106d657","user":{"login":"Expensify","id":476779,"avatar_url":"https://avatars0.githubusercontent.com/u/476779?v=4","gravatar_id":"","url":"https://api.github.com/users/Expensify","html_url":"https://github.com/Expensify","followers_url":"https://api.github.com/users/Expensify/followers","following_url":"https://api.github.com/users/Expensify/following{/other_user}","gists_url":"https://api.github.com/users/Expensify/gists{/gist_id}","starred_url":"https://api.github.com/users/Expensify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Expensify/subscriptions","organizations_url":"https://api.github.com/users/Expensify/orgs","repos_url":"https://api.github.com/users/Expensify/repos","events_url":"https://api.github.com/users/Expensify/events{/privacy}","received_events_url":"https://api.github.com/users/Expensify/received_events","type":"Organization","site_admin":false},"repo":{"id":68838259,"name":"Bedrock-PHP","full_name":"Expensify/Bedrock-PHP","owner":{"login":"Expensify","id":476779,"avatar_url":"https://avatars0.githubusercontent.com/u/476779?v=4","gravatar_id":"","url":"https://api.github.com/users/Expensify","html_url":"https://github.com/Expensify","followers_url":"https://api.github.com/users/Expensify/followers","following_url":"https://api.github.com/users/Expensify/following{/other_user}","gists_url":"https://api.github.com/users/Expensify/gists{/gist_id}","starred_url":"https://api.github.com/users/Expensify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Expensify/subscriptions","organizations_url":"https://api.github.com/users/Expensify/orgs","repos_url":"https://api.github.com/users/Expensify/repos","events_url":"https://api.github.com/users/Expensify/events{/privacy}","received_events_url":"https://api.github.com/users/Expensify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Expensify/Bedrock-PHP","description":null,"fork":false,"url":"https://api.github.com/repos/Expensify/Bedrock-PHP","forks_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/forks","keys_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/teams","hooks_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/hooks","issue_events_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues/events{/number}","events_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/events","assignees_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/assignees{/user}","branches_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/branches{/branch}","tags_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/tags","blobs_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/refs{/sha}","trees_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/statuses/{sha}","languages_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/languages","stargazers_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/stargazers","contributors_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/contributors","subscribers_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/subscribers","subscription_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/subscription","commits_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/commits{/sha}","git_commits_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/git/commits{/sha}","comments_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/comments{/number}","issue_comment_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues/comments{/number}","contents_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/contents/{+path}","compare_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/merges","archive_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/downloads","issues_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues{/number}","pulls_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls{/number}","milestones_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/milestones{/number}","notifications_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/labels{/name}","releases_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/releases{/id}","deployments_url":"https://api.github.com/repos/Expensify/Bedrock-PHP/deployments","created_at":"2016-09-21T16:52:46Z","updated_at":"2017-11-17T07:47:14Z","pushed_at":"2017-11-23T12:40:21Z","git_url":"git://github.com/Expensify/Bedrock-PHP.git","ssh_url":"[email protected]:Expensify/Bedrock-PHP.git","clone_url":"https://github.com/Expensify/Bedrock-PHP.git","svn_url":"https://github.com/Expensify/Bedrock-PHP","homepage":null,"size":245,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/61"},"html":{"href":"https://github.com/Expensify/Bedrock-PHP/pull/61"},"issue":{"href":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues/61"},"comments":{"href":"https://api.github.com/repos/Expensify/Bedrock-PHP/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Expensify/Bedrock-PHP/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/Expensify/Bedrock-PHP/statuses/a6eb0af1152fbd84fb6666e42bc5f86ce57bea1c"}},"author_association":"CONTRIBUTOR"}} | {
"id": 68838259,
"name": "Expensify/Bedrock-PHP",
"url": "https://api.github.com/repos/Expensify/Bedrock-PHP"
} | {
"id": 4164921,
"login": "flodnv",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4164921?",
"url": "https://api.github.com/users/flodnv"
} | {
"id": 476779,
"login": "Expensify",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/476779?",
"url": "https://api.github.com/orgs/Expensify"
} | 2017-11-23T14:02:16 | 6895484094 | {"actor":{"display_login":"flodnv"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Expensify/CameraKit-Android/pulls/comments/138515445","pull_request_review_id":62320096,"id":138515445,"diff_hunk":"@@ -419,27 +419,52 @@ private void adjustCameraParameters() {\n initResolutions();\n \n boolean invertPreviewSizes = mDisplayOrientation%180 != 0;\n- mPreview.setTruePreviewSize(\n- invertPreviewSizes? getPreviewResolution().getHeight() : getPreviewResolution().getWidth(),\n- invertPreviewSizes? getPreviewResolution().getWidth() : getPreviewResolution().getHeight()\n- );\n-\n- mCameraParameters.setPreviewSize(\n- getPreviewResolution().getWidth(),\n- getPreviewResolution().getHeight()\n- );\n-\n- mCameraParameters.setPictureSize(\n- getCaptureResolution().getWidth(),\n- getCaptureResolution().getHeight()\n- );\n+ Camera.Parameters resolutionLess = mCamera.getParameters();\n+ boolean have_to_readjust = false;\n+ if (getPreviewResolution() != null) {\n+ mPreview.setTruePreviewSize(\n+ invertPreviewSizes ? getPreviewResolution().getHeight() : getPreviewResolution().getWidth(),\n+ invertPreviewSizes ? getPreviewResolution().getWidth() : getPreviewResolution().getHeight()\n+ );\n+\n+ mCameraParameters.setPreviewSize(\n+ getPreviewResolution().getWidth(),\n+ getPreviewResolution().getHeight()\n+ );\n+ try{\n+ mCamera.setParameters(mCameraParameters);\n+ }catch(Exception e){\n+ e.printStackTrace();\n+ mCameraParameters = resolutionLess; //some phones can't set parameters that camerakit has chosen, so fallback to defaults\n+ }\n+ }else{\n+ have_to_readjust = true;\n+ }\n+ if (getCaptureResolution() != null) {\n+ mCameraParameters.setPictureSize(\n+ getCaptureResolution().getWidth(),\n+ getCaptureResolution().getHeight()\n+ );\n+ try{\n+ mCamera.setParameters(mCameraParameters);\n+ }catch(Exception e){\n+ e.printStackTrace();\n+ mCameraParameters = resolutionLess; //some phones can't set parameters that camerakit has chosen, so fallback to defaults\n+ }\n+ }else{\n+ have_to_readjust = true;\n+ }\n int rotation = calculateCaptureRotation();\n mCameraParameters.setRotation(rotation);\n \n setFocus(mFocus);\n setFlash(mFlash);\n \n mCamera.setParameters(mCameraParameters);\n+ if (have_to_readjust){","path":"camerakit/src/main/api16/com/flurgle/camerakit/Camera1.java","position":60,"original_position":60,"commit_id":"5489e3433a8bf49eee71595145c94452be2ff0be","original_commit_id":"5489e3433a8bf49eee71595145c94452be2ff0be","user":{"login":"gasoline-joe","id":9942061,"avatar_url":"https://avatars0.githubusercontent.com/u/9942061?v=4","gravatar_id":"","url":"https://api.github.com/users/gasoline-joe","html_url":"https://github.com/gasoline-joe","followers_url":"https://api.github.com/users/gasoline-joe/followers","following_url":"https://api.github.com/users/gasoline-joe/following{/other_user}","gists_url":"https://api.github.com/users/gasoline-joe/gists{/gist_id}","starred_url":"https://api.github.com/users/gasoline-joe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasoline-joe/subscriptions","organizations_url":"https://api.github.com/users/gasoline-joe/orgs","repos_url":"https://api.github.com/users/gasoline-joe/repos","events_url":"https://api.github.com/users/gasoline-joe/events{/privacy}","received_events_url":"https://api.github.com/users/gasoline-joe/received_events","type":"User","site_admin":false},"body":"Just in theory. In practice camera should have both parameters initialized to just be able to show preview and make pictures, so that is fallback solution if 100ms for syncronisation isn't enough. I could add a counter to remove any possibility.","created_at":"2017-09-13T03:08:31Z","updated_at":"2017-09-13T03:08:31Z","html_url":"https://github.com/Expensify/CameraKit-Android/pull/1#discussion_r138515445","pull_request_url":"https://api.github.com/repos/Expensify/CameraKit-Android/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Expensify/CameraKit-Android/pulls/comments/138515445"},"html":{"href":"https://github.com/Expensify/CameraKit-Android/pull/1#discussion_r138515445"},"pull_request":{"href":"https://api.github.com/repos/Expensify/CameraKit-Android/pulls/1"}},"in_reply_to_id":138427973},"pull_request":{"url":"https://api.github.com/repos/Expensify/CameraKit-Android/pulls/1","id":140492129,"html_url":"https://github.com/Expensify/CameraKit-Android/pull/1","diff_url":"https://github.com/Expensify/CameraKit-Android/pull/1.diff","patch_url":"https://github.com/Expensify/CameraKit-Android/pull/1.patch","issue_url":"https://api.github.com/repos/Expensify/CameraKit-Android/issues/1","number":1,"state":"open","locked":false,"title":"Fixed race condition for size.getwidth() NPE","user":{"login":"gasoline-joe","id":9942061,"avatar_url":"https://avatars0.githubusercontent.com/u/9942061?v=4","gravatar_id":"","url":"https://api.github.com/users/gasoline-joe","html_url":"https://github.com/gasoline-joe","followers_url":"https://api.github.com/users/gasoline-joe/followers","following_url":"https://api.github.com/users/gasoline-joe/following{/other_user}","gists_url":"https://api.github.com/users/gasoline-joe/gists{/gist_id}","starred_url":"https://api.github.com/users/gasoline-joe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasoline-joe/subscriptions","organizations_url":"https://api.github.com/users/gasoline-joe/orgs","repos_url":"https://api.github.com/users/gasoline-joe/repos","events_url":"https://api.github.com/users/gasoline-joe/events{/privacy}","received_events_url":"https://api.github.com/users/gasoline-joe/received_events","type":"User","site_admin":false},"body":"added check for null objects in adjustCameraParameters, added setParameters error handling and fallback if there is still a sync issue","created_at":"2017-09-12T05:38:27Z","updated_at":"2017-09-13T03:08:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c96fa50814e6a9dd3eeb97400907dff0ee59d161","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Expensify/CameraKit-Android/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Expensify/CameraKit-Android/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Expensify/CameraKit-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Expensify/CameraKit-Android/issues/1/comments","statuses_url":"https://api.github.com/repos/Expensify/CameraKit-Android/statuses/5489e3433a8bf49eee71595145c94452be2ff0be","head":{"label":"gasoline-joe:master","ref":"master","sha":"5489e3433a8bf49eee71595145c94452be2ff0be","user":{"login":"gasoline-joe","id":9942061,"avatar_url":"https://avatars0.githubusercontent.com/u/9942061?v=4","gravatar_id":"","url":"https://api.github.com/users/gasoline-joe","html_url":"https://github.com/gasoline-joe","followers_url":"https://api.github.com/users/gasoline-joe/followers","following_url":"https://api.github.com/users/gasoline-joe/following{/other_user}","gists_url":"https://api.github.com/users/gasoline-joe/gists{/gist_id}","starred_url":"https://api.github.com/users/gasoline-joe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasoline-joe/subscriptions","organizations_url":"https://api.github.com/users/gasoline-joe/orgs","repos_url":"https://api.github.com/users/gasoline-joe/repos","events_url":"https://api.github.com/users/gasoline-joe/events{/privacy}","received_events_url":"https://api.github.com/users/gasoline-joe/received_events","type":"User","site_admin":false},"repo":{"id":103216890,"name":"CameraKit-Android","full_name":"gasoline-joe/CameraKit-Android","owner":{"login":"gasoline-joe","id":9942061,"avatar_url":"https://avatars0.githubusercontent.com/u/9942061?v=4","gravatar_id":"","url":"https://api.github.com/users/gasoline-joe","html_url":"https://github.com/gasoline-joe","followers_url":"https://api.github.com/users/gasoline-joe/followers","following_url":"https://api.github.com/users/gasoline-joe/following{/other_user}","gists_url":"https://api.github.com/users/gasoline-joe/gists{/gist_id}","starred_url":"https://api.github.com/users/gasoline-joe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasoline-joe/subscriptions","organizations_url":"https://api.github.com/users/gasoline-joe/orgs","repos_url":"https://api.github.com/users/gasoline-joe/repos","events_url":"https://api.github.com/users/gasoline-joe/events{/privacy}","received_events_url":"https://api.github.com/users/gasoline-joe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gasoline-joe/CameraKit-Android","description":"One of the hardest Android APIs made into a high level and easy to use library that solves all of your problems.","fork":true,"url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android","forks_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/forks","keys_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/teams","hooks_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/hooks","issue_events_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/issues/events{/number}","events_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/events","assignees_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/assignees{/user}","branches_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/branches{/branch}","tags_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/tags","blobs_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/languages","stargazers_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/stargazers","contributors_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/contributors","subscribers_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/subscribers","subscription_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/subscription","commits_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/contents/{+path}","compare_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/merges","archive_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/downloads","issues_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/issues{/number}","pulls_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/labels{/name}","releases_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/releases{/id}","deployments_url":"https://api.github.com/repos/gasoline-joe/CameraKit-Android/deployments","created_at":"2017-09-12T03:22:07Z","updated_at":"2017-09-12T03:22:08Z","pushed_at":"2017-09-12T05:35:58Z","git_url":"git://github.com/gasoline-joe/CameraKit-Android.git","ssh_url":"[email protected]:gasoline-joe/CameraKit-Android.git","clone_url":"https://github.com/gasoline-joe/CameraKit-Android.git","svn_url":"https://github.com/gasoline-joe/CameraKit-Android","homepage":"","size":17419,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Expensify:master","ref":"master","sha":"b99cc8f746ba56d6c2e790b9dd1edad8e3480002","user":{"login":"Expensify","id":476779,"avatar_url":"https://avatars0.githubusercontent.com/u/476779?v=4","gravatar_id":"","url":"https://api.github.com/users/Expensify","html_url":"https://github.com/Expensify","followers_url":"https://api.github.com/users/Expensify/followers","following_url":"https://api.github.com/users/Expensify/following{/other_user}","gists_url":"https://api.github.com/users/Expensify/gists{/gist_id}","starred_url":"https://api.github.com/users/Expensify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Expensify/subscriptions","organizations_url":"https://api.github.com/users/Expensify/orgs","repos_url":"https://api.github.com/users/Expensify/repos","events_url":"https://api.github.com/users/Expensify/events{/privacy}","received_events_url":"https://api.github.com/users/Expensify/received_events","type":"Organization","site_admin":false},"repo":{"id":100977066,"name":"CameraKit-Android","full_name":"Expensify/CameraKit-Android","owner":{"login":"Expensify","id":476779,"avatar_url":"https://avatars0.githubusercontent.com/u/476779?v=4","gravatar_id":"","url":"https://api.github.com/users/Expensify","html_url":"https://github.com/Expensify","followers_url":"https://api.github.com/users/Expensify/followers","following_url":"https://api.github.com/users/Expensify/following{/other_user}","gists_url":"https://api.github.com/users/Expensify/gists{/gist_id}","starred_url":"https://api.github.com/users/Expensify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Expensify/subscriptions","organizations_url":"https://api.github.com/users/Expensify/orgs","repos_url":"https://api.github.com/users/Expensify/repos","events_url":"https://api.github.com/users/Expensify/events{/privacy}","received_events_url":"https://api.github.com/users/Expensify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Expensify/CameraKit-Android","description":"One of the hardest Android APIs made into a high level and easy to use library that solves all of your problems.","fork":true,"url":"https://api.github.com/repos/Expensify/CameraKit-Android","forks_url":"https://api.github.com/repos/Expensify/CameraKit-Android/forks","keys_url":"https://api.github.com/repos/Expensify/CameraKit-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Expensify/CameraKit-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Expensify/CameraKit-Android/teams","hooks_url":"https://api.github.com/repos/Expensify/CameraKit-Android/hooks","issue_events_url":"https://api.github.com/repos/Expensify/CameraKit-Android/issues/events{/number}","events_url":"https://api.github.com/repos/Expensify/CameraKit-Android/events","assignees_url":"https://api.github.com/repos/Expensify/CameraKit-Android/assignees{/user}","branches_url":"https://api.github.com/repos/Expensify/CameraKit-Android/branches{/branch}","tags_url":"https://api.github.com/repos/Expensify/CameraKit-Android/tags","blobs_url":"https://api.github.com/repos/Expensify/CameraKit-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Expensify/CameraKit-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Expensify/CameraKit-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/Expensify/CameraKit-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Expensify/CameraKit-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/Expensify/CameraKit-Android/languages","stargazers_url":"https://api.github.com/repos/Expensify/CameraKit-Android/stargazers","contributors_url":"https://api.github.com/repos/Expensify/CameraKit-Android/contributors","subscribers_url":"https://api.github.com/repos/Expensify/CameraKit-Android/subscribers","subscription_url":"https://api.github.com/repos/Expensify/CameraKit-Android/subscription","commits_url":"https://api.github.com/repos/Expensify/CameraKit-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/Expensify/CameraKit-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/Expensify/CameraKit-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/Expensify/CameraKit-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/Expensify/CameraKit-Android/contents/{+path}","compare_url":"https://api.github.com/repos/Expensify/CameraKit-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Expensify/CameraKit-Android/merges","archive_url":"https://api.github.com/repos/Expensify/CameraKit-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Expensify/CameraKit-Android/downloads","issues_url":"https://api.github.com/repos/Expensify/CameraKit-Android/issues{/number}","pulls_url":"https://api.github.com/repos/Expensify/CameraKit-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/Expensify/CameraKit-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/Expensify/CameraKit-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Expensify/CameraKit-Android/labels{/name}","releases_url":"https://api.github.com/repos/Expensify/CameraKit-Android/releases{/id}","deployments_url":"https://api.github.com/repos/Expensify/CameraKit-Android/deployments","created_at":"2017-08-21T17:37:00Z","updated_at":"2017-08-21T17:37:02Z","pushed_at":"2017-09-12T05:38:28Z","git_url":"git://github.com/Expensify/CameraKit-Android.git","ssh_url":"[email protected]:Expensify/CameraKit-Android.git","clone_url":"https://github.com/Expensify/CameraKit-Android.git","svn_url":"https://github.com/Expensify/CameraKit-Android","homepage":"","size":17418,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Expensify/CameraKit-Android/pulls/1"},"html":{"href":"https://github.com/Expensify/CameraKit-Android/pull/1"},"issue":{"href":"https://api.github.com/repos/Expensify/CameraKit-Android/issues/1"},"comments":{"href":"https://api.github.com/repos/Expensify/CameraKit-Android/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Expensify/CameraKit-Android/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Expensify/CameraKit-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Expensify/CameraKit-Android/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Expensify/CameraKit-Android/statuses/5489e3433a8bf49eee71595145c94452be2ff0be"}},"author_association":"NONE"}} | {
"id": 100977066,
"name": "Expensify/CameraKit-Android",
"url": "https://api.github.com/repos/Expensify/CameraKit-Android"
} | {
"id": 9942061,
"login": "gasoline-joe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9942061?",
"url": "https://api.github.com/users/gasoline-joe"
} | {
"id": 476779,
"login": "Expensify",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/476779?",
"url": "https://api.github.com/orgs/Expensify"
} | 2017-09-13T03:08:31 | 6583089732 | {"actor":{"display_login":"gasoline-joe"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/pulls/comments/123683837","pull_request_review_id":45911694,"id":123683837,"diff_hunk":"@@ -31,6 +31,9 @@ interface VcsRootLocator {\n }\n \n interface BuildLocator {\n+ fun withId(buildId: BuildId): BuildLocator","path":"src/main/kotlin/org/jetbrains/teamcity/rest/api.kt","position":4,"original_position":4,"commit_id":"30503f54d0684727ecd7ab6a740b808be926547e","original_commit_id":"30503f54d0684727ecd7ab6a740b808be926547e","user":{"login":"chashnikov","id":978014,"avatar_url":"https://avatars3.githubusercontent.com/u/978014?v=3","gravatar_id":"","url":"https://api.github.com/users/chashnikov","html_url":"https://github.com/chashnikov","followers_url":"https://api.github.com/users/chashnikov/followers","following_url":"https://api.github.com/users/chashnikov/following{/other_user}","gists_url":"https://api.github.com/users/chashnikov/gists{/gist_id}","starred_url":"https://api.github.com/users/chashnikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chashnikov/subscriptions","organizations_url":"https://api.github.com/users/chashnikov/orgs","repos_url":"https://api.github.com/users/chashnikov/repos","events_url":"https://api.github.com/users/chashnikov/events{/privacy}","received_events_url":"https://api.github.com/users/chashnikov/received_events","type":"User","site_admin":false},"body":"It looks like we have different opinions about goals of this library. It isn't supposed to be be dummy wrapper around REST API for those who know REST API. I think it's much better to provide convenient access to TeamCity for those who just want to interact with TeamCity in scripts. So it shouldn't keep names of attributes in REST API if we can invent more comprehensible names. If REST provides too generic API for something and we don't know about real use cases for that it's better to provide more specific API in the library to make it easier to use.\r\n\r\nI already had similar discussion in other pull requests (e.g. [here](https://github.com/JetBrains/teamcity-rest-client/pull/15#discussion_r120849639)). If you don't agree with me let's discuss this in person.","created_at":"2017-06-23T07:01:43Z","updated_at":"2017-06-23T07:01:43Z","html_url":"https://github.com/JetBrains/teamcity-rest-client/pull/20#discussion_r123683837","pull_request_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/JetBrains/teamcity-rest-client/pulls/comments/123683837"},"html":{"href":"https://github.com/JetBrains/teamcity-rest-client/pull/20#discussion_r123683837"},"pull_request":{"href":"https://api.github.com/repos/JetBrains/teamcity-rest-client/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/pulls/20","id":125007801,"html_url":"https://github.com/JetBrains/teamcity-rest-client/pull/20","diff_url":"https://github.com/JetBrains/teamcity-rest-client/pull/20.diff","patch_url":"https://github.com/JetBrains/teamcity-rest-client/pull/20.patch","issue_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/issues/20","number":20,"state":"open","locked":false,"title":"Since build","user":{"login":"goodwinnk","id":908958,"avatar_url":"https://avatars2.githubusercontent.com/u/908958?v=3","gravatar_id":"","url":"https://api.github.com/users/goodwinnk","html_url":"https://github.com/goodwinnk","followers_url":"https://api.github.com/users/goodwinnk/followers","following_url":"https://api.github.com/users/goodwinnk/following{/other_user}","gists_url":"https://api.github.com/users/goodwinnk/gists{/gist_id}","starred_url":"https://api.github.com/users/goodwinnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goodwinnk/subscriptions","organizations_url":"https://api.github.com/users/goodwinnk/orgs","repos_url":"https://api.github.com/users/goodwinnk/repos","events_url":"https://api.github.com/users/goodwinnk/events{/privacy}","received_events_url":"https://api.github.com/users/goodwinnk/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-10T23:33:14Z","updated_at":"2017-06-23T07:01:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0cd1a5df074547a54174c5a99a7a49a0cb833e9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/pulls/20/commits","review_comments_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/pulls/20/comments","review_comment_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/issues/20/comments","statuses_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/statuses/30503f54d0684727ecd7ab6a740b808be926547e","head":{"label":"goodwinnk:sinceBuild","ref":"sinceBuild","sha":"30503f54d0684727ecd7ab6a740b808be926547e","user":{"login":"goodwinnk","id":908958,"avatar_url":"https://avatars2.githubusercontent.com/u/908958?v=3","gravatar_id":"","url":"https://api.github.com/users/goodwinnk","html_url":"https://github.com/goodwinnk","followers_url":"https://api.github.com/users/goodwinnk/followers","following_url":"https://api.github.com/users/goodwinnk/following{/other_user}","gists_url":"https://api.github.com/users/goodwinnk/gists{/gist_id}","starred_url":"https://api.github.com/users/goodwinnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goodwinnk/subscriptions","organizations_url":"https://api.github.com/users/goodwinnk/orgs","repos_url":"https://api.github.com/users/goodwinnk/repos","events_url":"https://api.github.com/users/goodwinnk/events{/privacy}","received_events_url":"https://api.github.com/users/goodwinnk/received_events","type":"User","site_admin":false},"repo":{"id":92671590,"name":"teamcity-rest-client","full_name":"goodwinnk/teamcity-rest-client","owner":{"login":"goodwinnk","id":908958,"avatar_url":"https://avatars2.githubusercontent.com/u/908958?v=3","gravatar_id":"","url":"https://api.github.com/users/goodwinnk","html_url":"https://github.com/goodwinnk","followers_url":"https://api.github.com/users/goodwinnk/followers","following_url":"https://api.github.com/users/goodwinnk/following{/other_user}","gists_url":"https://api.github.com/users/goodwinnk/gists{/gist_id}","starred_url":"https://api.github.com/users/goodwinnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goodwinnk/subscriptions","organizations_url":"https://api.github.com/users/goodwinnk/orgs","repos_url":"https://api.github.com/users/goodwinnk/repos","events_url":"https://api.github.com/users/goodwinnk/events{/privacy}","received_events_url":"https://api.github.com/users/goodwinnk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/goodwinnk/teamcity-rest-client","description":"Client for TeamCity REST API written in Kotlin","fork":true,"url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client","forks_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/forks","keys_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/teams","hooks_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/hooks","issue_events_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/issues/events{/number}","events_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/events","assignees_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/assignees{/user}","branches_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/branches{/branch}","tags_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/tags","blobs_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/statuses/{sha}","languages_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/languages","stargazers_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/stargazers","contributors_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/contributors","subscribers_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/subscribers","subscription_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/subscription","commits_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/contents/{+path}","compare_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/merges","archive_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/downloads","issues_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/issues{/number}","pulls_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/pulls{/number}","milestones_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/milestones{/number}","notifications_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/labels{/name}","releases_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/releases{/id}","deployments_url":"https://api.github.com/repos/goodwinnk/teamcity-rest-client/deployments","created_at":"2017-05-28T16:01:57Z","updated_at":"2017-05-28T16:01:59Z","pushed_at":"2017-06-12T22:45:11Z","git_url":"git://github.com/goodwinnk/teamcity-rest-client.git","ssh_url":"[email protected]:goodwinnk/teamcity-rest-client.git","clone_url":"https://github.com/goodwinnk/teamcity-rest-client.git","svn_url":"https://github.com/goodwinnk/teamcity-rest-client","homepage":null,"size":223,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JetBrains:master","ref":"master","sha":"a8250ff46457728b348a4e0d276de8fe39219d29","user":{"login":"JetBrains","id":878437,"avatar_url":"https://avatars1.githubusercontent.com/u/878437?v=3","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"repo":{"id":33492697,"name":"teamcity-rest-client","full_name":"JetBrains/teamcity-rest-client","owner":{"login":"JetBrains","id":878437,"avatar_url":"https://avatars1.githubusercontent.com/u/878437?v=3","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JetBrains/teamcity-rest-client","description":"Client for TeamCity REST API written in Kotlin","fork":false,"url":"https://api.github.com/repos/JetBrains/teamcity-rest-client","forks_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/forks","keys_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/teams","hooks_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/hooks","issue_events_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/issues/events{/number}","events_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/events","assignees_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/assignees{/user}","branches_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/branches{/branch}","tags_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/tags","blobs_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/statuses/{sha}","languages_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/languages","stargazers_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/stargazers","contributors_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/contributors","subscribers_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/subscribers","subscription_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/subscription","commits_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/contents/{+path}","compare_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/merges","archive_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/downloads","issues_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/issues{/number}","pulls_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/pulls{/number}","milestones_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/milestones{/number}","notifications_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/labels{/name}","releases_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/releases{/id}","deployments_url":"https://api.github.com/repos/JetBrains/teamcity-rest-client/deployments","created_at":"2015-04-06T16:40:25Z","updated_at":"2017-06-18T04:00:45Z","pushed_at":"2017-06-21T16:31:39Z","git_url":"git://github.com/JetBrains/teamcity-rest-client.git","ssh_url":"[email protected]:JetBrains/teamcity-rest-client.git","clone_url":"https://github.com/JetBrains/teamcity-rest-client.git","svn_url":"https://github.com/JetBrains/teamcity-rest-client","homepage":null,"size":222,"stargazers_count":14,"watchers_count":14,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":6,"forks":10,"open_issues":6,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JetBrains/teamcity-rest-client/pulls/20"},"html":{"href":"https://github.com/JetBrains/teamcity-rest-client/pull/20"},"issue":{"href":"https://api.github.com/repos/JetBrains/teamcity-rest-client/issues/20"},"comments":{"href":"https://api.github.com/repos/JetBrains/teamcity-rest-client/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/JetBrains/teamcity-rest-client/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/JetBrains/teamcity-rest-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JetBrains/teamcity-rest-client/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/JetBrains/teamcity-rest-client/statuses/30503f54d0684727ecd7ab6a740b808be926547e"}}}} | {
"id": 33492697,
"name": "JetBrains/teamcity-rest-client",
"url": "https://api.github.com/repos/JetBrains/teamcity-rest-client"
} | {
"id": 978014,
"login": "chashnikov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/978014?",
"url": "https://api.github.com/users/chashnikov"
} | {
"id": 878437,
"login": "JetBrains",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/878437?",
"url": "https://api.github.com/orgs/JetBrains"
} | 2017-06-23T07:01:43 | 6123898447 | {"actor":{"display_login":"chashnikov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/JetBrains/kotlin-native/pulls/comments/156423538","pull_request_review_id":82897886,"id":156423538,"diff_hunk":"@@ -536,8 +539,17 @@ internal class CAdapterGenerator(val context: Context,\n output(\".IsInstance = IsInstanceImpl,\", 1)\n makeScopeDefinitions(top, DefinitionKind.C_SOURCE_STRUCT, 1)\n output(\"};\")\n- output(\"RUNTIME_USED ${prefix}_ExportedSymbols* ${prefix}_symbols(void) { return &__konan_symbols;}\")\n+ output(\"RUNTIME_USED ${prefix}_ExportedSymbols* $exportedSymbol(void) { return &__konan_symbols;}\")\n outputStreamWriter.close()\n+\n+ if (context.config.targetManager.target == KonanTarget.MINGW) {","path":"backend.native/compiler/ir/backend.native/src/org/jetbrains/kotlin/backend/konan/CAdapterGenerator.kt","position":43,"original_position":43,"commit_id":"285ccbe96e736d59202c20b1d5c6a1ab6ab74b8a","original_commit_id":"285ccbe96e736d59202c20b1d5c6a1ab6ab74b8a","user":{"login":"olonho","id":2600522,"avatar_url":"https://avatars1.githubusercontent.com/u/2600522?v=4","gravatar_id":"","url":"https://api.github.com/users/olonho","html_url":"https://github.com/olonho","followers_url":"https://api.github.com/users/olonho/followers","following_url":"https://api.github.com/users/olonho/following{/other_user}","gists_url":"https://api.github.com/users/olonho/gists{/gist_id}","starred_url":"https://api.github.com/users/olonho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olonho/subscriptions","organizations_url":"https://api.github.com/users/olonho/orgs","repos_url":"https://api.github.com/users/olonho/repos","events_url":"https://api.github.com/users/olonho/events{/privacy}","received_events_url":"https://api.github.com/users/olonho/received_events","type":"User","site_admin":false},"body":"context.config.targetManager.target.family == Family.WINDOWS","created_at":"2017-12-12T16:39:59Z","updated_at":"2017-12-12T16:39:59Z","html_url":"https://github.com/JetBrains/kotlin-native/pull/1137#discussion_r156423538","pull_request_url":"https://api.github.com/repos/JetBrains/kotlin-native/pulls/1137","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/JetBrains/kotlin-native/pulls/comments/156423538"},"html":{"href":"https://github.com/JetBrains/kotlin-native/pull/1137#discussion_r156423538"},"pull_request":{"href":"https://api.github.com/repos/JetBrains/kotlin-native/pulls/1137"}}},"pull_request":{"url":"https://api.github.com/repos/JetBrains/kotlin-native/pulls/1137","id":157842180,"html_url":"https://github.com/JetBrains/kotlin-native/pull/1137","diff_url":"https://github.com/JetBrains/kotlin-native/pull/1137.diff","patch_url":"https://github.com/JetBrains/kotlin-native/pull/1137.patch","issue_url":"https://api.github.com/repos/JetBrains/kotlin-native/issues/1137","number":1137,"state":"open","locked":false,"title":"Produce windows .def files together with .dlls.","user":{"login":"alexander-gorshenev","id":23235396,"avatar_url":"https://avatars3.githubusercontent.com/u/23235396?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-gorshenev","html_url":"https://github.com/alexander-gorshenev","followers_url":"https://api.github.com/users/alexander-gorshenev/followers","following_url":"https://api.github.com/users/alexander-gorshenev/following{/other_user}","gists_url":"https://api.github.com/users/alexander-gorshenev/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-gorshenev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-gorshenev/subscriptions","organizations_url":"https://api.github.com/users/alexander-gorshenev/orgs","repos_url":"https://api.github.com/users/alexander-gorshenev/repos","events_url":"https://api.github.com/users/alexander-gorshenev/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-gorshenev/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-12T14:27:34Z","updated_at":"2017-12-12T16:39:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b05a5da3e1320250dcbe518e973730f3de150c4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/JetBrains/kotlin-native/pulls/1137/commits","review_comments_url":"https://api.github.com/repos/JetBrains/kotlin-native/pulls/1137/comments","review_comment_url":"https://api.github.com/repos/JetBrains/kotlin-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JetBrains/kotlin-native/issues/1137/comments","statuses_url":"https://api.github.com/repos/JetBrains/kotlin-native/statuses/285ccbe96e736d59202c20b1d5c6a1ab6ab74b8a","head":{"label":"JetBrains:def_dll","ref":"def_dll","sha":"285ccbe96e736d59202c20b1d5c6a1ab6ab74b8a","user":{"login":"JetBrains","id":878437,"avatar_url":"https://avatars2.githubusercontent.com/u/878437?v=4","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"repo":{"id":58957623,"name":"kotlin-native","full_name":"JetBrains/kotlin-native","owner":{"login":"JetBrains","id":878437,"avatar_url":"https://avatars2.githubusercontent.com/u/878437?v=4","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JetBrains/kotlin-native","description":"Kotlin/Native infrastructure","fork":false,"url":"https://api.github.com/repos/JetBrains/kotlin-native","forks_url":"https://api.github.com/repos/JetBrains/kotlin-native/forks","keys_url":"https://api.github.com/repos/JetBrains/kotlin-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JetBrains/kotlin-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JetBrains/kotlin-native/teams","hooks_url":"https://api.github.com/repos/JetBrains/kotlin-native/hooks","issue_events_url":"https://api.github.com/repos/JetBrains/kotlin-native/issues/events{/number}","events_url":"https://api.github.com/repos/JetBrains/kotlin-native/events","assignees_url":"https://api.github.com/repos/JetBrains/kotlin-native/assignees{/user}","branches_url":"https://api.github.com/repos/JetBrains/kotlin-native/branches{/branch}","tags_url":"https://api.github.com/repos/JetBrains/kotlin-native/tags","blobs_url":"https://api.github.com/repos/JetBrains/kotlin-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JetBrains/kotlin-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JetBrains/kotlin-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/JetBrains/kotlin-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JetBrains/kotlin-native/statuses/{sha}","languages_url":"https://api.github.com/repos/JetBrains/kotlin-native/languages","stargazers_url":"https://api.github.com/repos/JetBrains/kotlin-native/stargazers","contributors_url":"https://api.github.com/repos/JetBrains/kotlin-native/contributors","subscribers_url":"https://api.github.com/repos/JetBrains/kotlin-native/subscribers","subscription_url":"https://api.github.com/repos/JetBrains/kotlin-native/subscription","commits_url":"https://api.github.com/repos/JetBrains/kotlin-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/JetBrains/kotlin-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/JetBrains/kotlin-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/JetBrains/kotlin-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/JetBrains/kotlin-native/contents/{+path}","compare_url":"https://api.github.com/repos/JetBrains/kotlin-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JetBrains/kotlin-native/merges","archive_url":"https://api.github.com/repos/JetBrains/kotlin-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JetBrains/kotlin-native/downloads","issues_url":"https://api.github.com/repos/JetBrains/kotlin-native/issues{/number}","pulls_url":"https://api.github.com/repos/JetBrains/kotlin-native/pulls{/number}","milestones_url":"https://api.github.com/repos/JetBrains/kotlin-native/milestones{/number}","notifications_url":"https://api.github.com/repos/JetBrains/kotlin-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JetBrains/kotlin-native/labels{/name}","releases_url":"https://api.github.com/repos/JetBrains/kotlin-native/releases{/id}","deployments_url":"https://api.github.com/repos/JetBrains/kotlin-native/deployments","created_at":"2016-05-16T18:40:45Z","updated_at":"2017-12-12T13:30:28Z","pushed_at":"2017-12-12T16:37:58Z","git_url":"git://github.com/JetBrains/kotlin-native.git","ssh_url":"[email protected]:JetBrains/kotlin-native.git","clone_url":"https://github.com/JetBrains/kotlin-native.git","svn_url":"https://github.com/JetBrains/kotlin-native","homepage":"","size":29975,"stargazers_count":2806,"watchers_count":2806,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":165,"open_issues":57,"watchers":2806,"default_branch":"master"}},"base":{"label":"JetBrains:master","ref":"master","sha":"bb47a28c15db068d83283f5ade69e0059a9b1dde","user":{"login":"JetBrains","id":878437,"avatar_url":"https://avatars2.githubusercontent.com/u/878437?v=4","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"repo":{"id":58957623,"name":"kotlin-native","full_name":"JetBrains/kotlin-native","owner":{"login":"JetBrains","id":878437,"avatar_url":"https://avatars2.githubusercontent.com/u/878437?v=4","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JetBrains/kotlin-native","description":"Kotlin/Native infrastructure","fork":false,"url":"https://api.github.com/repos/JetBrains/kotlin-native","forks_url":"https://api.github.com/repos/JetBrains/kotlin-native/forks","keys_url":"https://api.github.com/repos/JetBrains/kotlin-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JetBrains/kotlin-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JetBrains/kotlin-native/teams","hooks_url":"https://api.github.com/repos/JetBrains/kotlin-native/hooks","issue_events_url":"https://api.github.com/repos/JetBrains/kotlin-native/issues/events{/number}","events_url":"https://api.github.com/repos/JetBrains/kotlin-native/events","assignees_url":"https://api.github.com/repos/JetBrains/kotlin-native/assignees{/user}","branches_url":"https://api.github.com/repos/JetBrains/kotlin-native/branches{/branch}","tags_url":"https://api.github.com/repos/JetBrains/kotlin-native/tags","blobs_url":"https://api.github.com/repos/JetBrains/kotlin-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JetBrains/kotlin-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JetBrains/kotlin-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/JetBrains/kotlin-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JetBrains/kotlin-native/statuses/{sha}","languages_url":"https://api.github.com/repos/JetBrains/kotlin-native/languages","stargazers_url":"https://api.github.com/repos/JetBrains/kotlin-native/stargazers","contributors_url":"https://api.github.com/repos/JetBrains/kotlin-native/contributors","subscribers_url":"https://api.github.com/repos/JetBrains/kotlin-native/subscribers","subscription_url":"https://api.github.com/repos/JetBrains/kotlin-native/subscription","commits_url":"https://api.github.com/repos/JetBrains/kotlin-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/JetBrains/kotlin-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/JetBrains/kotlin-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/JetBrains/kotlin-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/JetBrains/kotlin-native/contents/{+path}","compare_url":"https://api.github.com/repos/JetBrains/kotlin-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JetBrains/kotlin-native/merges","archive_url":"https://api.github.com/repos/JetBrains/kotlin-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JetBrains/kotlin-native/downloads","issues_url":"https://api.github.com/repos/JetBrains/kotlin-native/issues{/number}","pulls_url":"https://api.github.com/repos/JetBrains/kotlin-native/pulls{/number}","milestones_url":"https://api.github.com/repos/JetBrains/kotlin-native/milestones{/number}","notifications_url":"https://api.github.com/repos/JetBrains/kotlin-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JetBrains/kotlin-native/labels{/name}","releases_url":"https://api.github.com/repos/JetBrains/kotlin-native/releases{/id}","deployments_url":"https://api.github.com/repos/JetBrains/kotlin-native/deployments","created_at":"2016-05-16T18:40:45Z","updated_at":"2017-12-12T13:30:28Z","pushed_at":"2017-12-12T16:37:58Z","git_url":"git://github.com/JetBrains/kotlin-native.git","ssh_url":"[email protected]:JetBrains/kotlin-native.git","clone_url":"https://github.com/JetBrains/kotlin-native.git","svn_url":"https://github.com/JetBrains/kotlin-native","homepage":"","size":29975,"stargazers_count":2806,"watchers_count":2806,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":165,"open_issues":57,"watchers":2806,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JetBrains/kotlin-native/pulls/1137"},"html":{"href":"https://github.com/JetBrains/kotlin-native/pull/1137"},"issue":{"href":"https://api.github.com/repos/JetBrains/kotlin-native/issues/1137"},"comments":{"href":"https://api.github.com/repos/JetBrains/kotlin-native/issues/1137/comments"},"review_comments":{"href":"https://api.github.com/repos/JetBrains/kotlin-native/pulls/1137/comments"},"review_comment":{"href":"https://api.github.com/repos/JetBrains/kotlin-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JetBrains/kotlin-native/pulls/1137/commits"},"statuses":{"href":"https://api.github.com/repos/JetBrains/kotlin-native/statuses/285ccbe96e736d59202c20b1d5c6a1ab6ab74b8a"}},"author_association":"COLLABORATOR"}} | {
"id": 58957623,
"name": "JetBrains/kotlin-native",
"url": "https://api.github.com/repos/JetBrains/kotlin-native"
} | {
"id": 2600522,
"login": "olonho",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2600522?",
"url": "https://api.github.com/users/olonho"
} | {
"id": 878437,
"login": "JetBrains",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/878437?",
"url": "https://api.github.com/orgs/JetBrains"
} | 2017-12-12T16:39:59 | 6978156103 | {"actor":{"display_login":"olonho"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/pulls/comments/108879891","pull_request_review_id":29941513,"id":108879891,"diff_hunk":"@@ -71,7 +71,7 @@ class IntelliJPlugin implements Plugin<Project> {\n \n if (JavaPlugin.hasProperty('COMPILE_ONLY_CONFIGURATION_NAME')) {\n project.configurations.getByName(JavaPlugin.COMPILE_ONLY_CONFIGURATION_NAME).extendsFrom idea, ideaPlugins\n- project.configurations.getByName(JavaPlugin.TEST_COMPILE_ONLY_CONFIGURATION_NAME).extendsFrom idea, ideaPlugins\n+ project.configurations.getByName(JavaPlugin.TEST_COMPILE_CONFIGURATION_NAME).extendsFrom idea, ideaPlugins","path":"src/main/groovy/org/jetbrains/intellij/IntelliJPlugin.groovy","position":5,"original_position":5,"commit_id":"db5ad62947c70fb1cb8d2687ed7da485eb4aefdd","original_commit_id":"db5ad62947c70fb1cb8d2687ed7da485eb4aefdd","user":{"login":"zolotov","id":140920,"avatar_url":"https://avatars2.githubusercontent.com/u/140920?v=3","gravatar_id":"","url":"https://api.github.com/users/zolotov","html_url":"https://github.com/zolotov","followers_url":"https://api.github.com/users/zolotov/followers","following_url":"https://api.github.com/users/zolotov/following{/other_user}","gists_url":"https://api.github.com/users/zolotov/gists{/gist_id}","starred_url":"https://api.github.com/users/zolotov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zolotov/subscriptions","organizations_url":"https://api.github.com/users/zolotov/orgs","repos_url":"https://api.github.com/users/zolotov/repos","events_url":"https://api.github.com/users/zolotov/events{/privacy}","received_events_url":"https://api.github.com/users/zolotov/received_events","type":"User","site_admin":false},"body":"Oh, I see. Then let's keep `idea` in classpath and exclude `ideaPlugins` from it.\r\n\r\nTest Fixture loads all plugins from `idea.plugins.path` property and each plugin have its own ClassLoader to load classes from a corresponding directory, so having them in classpath look redundant at least.","created_at":"2017-03-30T09:28:43Z","updated_at":"2017-03-30T09:28:43Z","html_url":"https://github.com/JetBrains/gradle-intellij-plugin/pull/191#discussion_r108879891","pull_request_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/pulls/191","_links":{"self":{"href":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/pulls/comments/108879891"},"html":{"href":"https://github.com/JetBrains/gradle-intellij-plugin/pull/191#discussion_r108879891"},"pull_request":{"href":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/pulls/191"}}},"pull_request":{"url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/pulls/191","id":113270252,"html_url":"https://github.com/JetBrains/gradle-intellij-plugin/pull/191","diff_url":"https://github.com/JetBrains/gradle-intellij-plugin/pull/191.diff","patch_url":"https://github.com/JetBrains/gradle-intellij-plugin/pull/191.patch","issue_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/issues/191","number":191,"state":"open","locked":false,"title":"Fix test classpath","user":{"login":"madisp","id":1147723,"avatar_url":"https://avatars2.githubusercontent.com/u/1147723?v=3","gravatar_id":"","url":"https://api.github.com/users/madisp","html_url":"https://github.com/madisp","followers_url":"https://api.github.com/users/madisp/followers","following_url":"https://api.github.com/users/madisp/following{/other_user}","gists_url":"https://api.github.com/users/madisp/gists{/gist_id}","starred_url":"https://api.github.com/users/madisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madisp/subscriptions","organizations_url":"https://api.github.com/users/madisp/orgs","repos_url":"https://api.github.com/users/madisp/repos","events_url":"https://api.github.com/users/madisp/events{/privacy}","received_events_url":"https://api.github.com/users/madisp/received_events","type":"User","site_admin":false},"body":"Fixes test classpath by placing idea dependencies on compile (and\r\nruntime) dependencies instead of compileOnly.","created_at":"2017-03-29T19:00:09Z","updated_at":"2017-03-30T09:28:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ecf48b85b4688ede4d0a507b4f5273a474050c8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/pulls/191/commits","review_comments_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/pulls/191/comments","review_comment_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/issues/191/comments","statuses_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/statuses/db5ad62947c70fb1cb8d2687ed7da485eb4aefdd","head":{"label":"madisp:madis/fix-test-classpath","ref":"madis/fix-test-classpath","sha":"db5ad62947c70fb1cb8d2687ed7da485eb4aefdd","user":{"login":"madisp","id":1147723,"avatar_url":"https://avatars2.githubusercontent.com/u/1147723?v=3","gravatar_id":"","url":"https://api.github.com/users/madisp","html_url":"https://github.com/madisp","followers_url":"https://api.github.com/users/madisp/followers","following_url":"https://api.github.com/users/madisp/following{/other_user}","gists_url":"https://api.github.com/users/madisp/gists{/gist_id}","starred_url":"https://api.github.com/users/madisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madisp/subscriptions","organizations_url":"https://api.github.com/users/madisp/orgs","repos_url":"https://api.github.com/users/madisp/repos","events_url":"https://api.github.com/users/madisp/events{/privacy}","received_events_url":"https://api.github.com/users/madisp/received_events","type":"User","site_admin":false},"repo":{"id":84241487,"name":"gradle-intellij-plugin","full_name":"madisp/gradle-intellij-plugin","owner":{"login":"madisp","id":1147723,"avatar_url":"https://avatars2.githubusercontent.com/u/1147723?v=3","gravatar_id":"","url":"https://api.github.com/users/madisp","html_url":"https://github.com/madisp","followers_url":"https://api.github.com/users/madisp/followers","following_url":"https://api.github.com/users/madisp/following{/other_user}","gists_url":"https://api.github.com/users/madisp/gists{/gist_id}","starred_url":"https://api.github.com/users/madisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madisp/subscriptions","organizations_url":"https://api.github.com/users/madisp/orgs","repos_url":"https://api.github.com/users/madisp/repos","events_url":"https://api.github.com/users/madisp/events{/privacy}","received_events_url":"https://api.github.com/users/madisp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/madisp/gradle-intellij-plugin","description":"Plugin for building plugins for IntelliJ IDEs","fork":true,"url":"https://api.github.com/repos/madisp/gradle-intellij-plugin","forks_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/forks","keys_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/teams","hooks_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/hooks","issue_events_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/events","assignees_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/tags","blobs_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/languages","stargazers_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/stargazers","contributors_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/contributors","subscribers_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/subscribers","subscription_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/subscription","commits_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/merges","archive_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/downloads","issues_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/labels{/name}","releases_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/madisp/gradle-intellij-plugin/deployments","created_at":"2017-03-07T20:11:04Z","updated_at":"2017-03-07T20:11:06Z","pushed_at":"2017-03-29T19:07:51Z","git_url":"git://github.com/madisp/gradle-intellij-plugin.git","ssh_url":"[email protected]:madisp/gradle-intellij-plugin.git","clone_url":"https://github.com/madisp/gradle-intellij-plugin.git","svn_url":"https://github.com/madisp/gradle-intellij-plugin","homepage":null,"size":644,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JetBrains:master","ref":"master","sha":"2014c85e3f281b41ed04886b1d55ad230e624663","user":{"login":"JetBrains","id":878437,"avatar_url":"https://avatars1.githubusercontent.com/u/878437?v=3","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"repo":{"id":33932778,"name":"gradle-intellij-plugin","full_name":"JetBrains/gradle-intellij-plugin","owner":{"login":"JetBrains","id":878437,"avatar_url":"https://avatars1.githubusercontent.com/u/878437?v=3","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JetBrains/gradle-intellij-plugin","description":"Plugin for building plugins for IntelliJ IDEs","fork":false,"url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin","forks_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/forks","keys_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/teams","hooks_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/hooks","issue_events_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/events","assignees_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/tags","blobs_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/languages","stargazers_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/stargazers","contributors_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/contributors","subscribers_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/subscribers","subscription_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/subscription","commits_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/merges","archive_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/downloads","issues_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/labels{/name}","releases_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/deployments","created_at":"2015-04-14T13:18:35Z","updated_at":"2017-03-28T15:43:16Z","pushed_at":"2017-03-30T08:56:22Z","git_url":"git://github.com/JetBrains/gradle-intellij-plugin.git","ssh_url":"[email protected]:JetBrains/gradle-intellij-plugin.git","clone_url":"https://github.com/JetBrains/gradle-intellij-plugin.git","svn_url":"https://github.com/JetBrains/gradle-intellij-plugin","homepage":null,"size":642,"stargazers_count":215,"watchers_count":215,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":18,"forks":51,"open_issues":18,"watchers":215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/pulls/191"},"html":{"href":"https://github.com/JetBrains/gradle-intellij-plugin/pull/191"},"issue":{"href":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/issues/191"},"comments":{"href":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/JetBrains/gradle-intellij-plugin/statuses/db5ad62947c70fb1cb8d2687ed7da485eb4aefdd"}}}} | {
"id": 33932778,
"name": "JetBrains/gradle-intellij-plugin",
"url": "https://api.github.com/repos/JetBrains/gradle-intellij-plugin"
} | {
"id": 140920,
"login": "zolotov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/140920?",
"url": "https://api.github.com/users/zolotov"
} | {
"id": 878437,
"login": "JetBrains",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/878437?",
"url": "https://api.github.com/orgs/JetBrains"
} | 2017-03-30T09:28:43 | 5593813656 | {"actor":{"display_login":"zolotov"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/pulls/comments/136338631","pull_request_review_id":59862388,"id":136338631,"diff_hunk":"@@ -16,6 +16,7 @@\n </ResourceDictionary>\n </UserControl.Resources>\n <Button\n+ Height=\"17\" Width=\"17\" Padding=\"-1\"","path":"code/src/UI/Controls/InformationButton.xaml","position":4,"original_position":4,"commit_id":"619539551bc55b87e66750b92c4ca8cce1995d01","original_commit_id":"619539551bc55b87e66750b92c4ca8cce1995d01","user":{"login":"mvegaca","id":5556784,"avatar_url":"https://avatars2.githubusercontent.com/u/5556784?v=4","gravatar_id":"","url":"https://api.github.com/users/mvegaca","html_url":"https://github.com/mvegaca","followers_url":"https://api.github.com/users/mvegaca/followers","following_url":"https://api.github.com/users/mvegaca/following{/other_user}","gists_url":"https://api.github.com/users/mvegaca/gists{/gist_id}","starred_url":"https://api.github.com/users/mvegaca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvegaca/subscriptions","organizations_url":"https://api.github.com/users/mvegaca/orgs","repos_url":"https://api.github.com/users/mvegaca/repos","events_url":"https://api.github.com/users/mvegaca/events{/privacy}","received_events_url":"https://api.github.com/users/mvegaca/received_events","type":"User","site_admin":false},"body":"Updates are included in control because BlueBaseTemplateInfoButtonStyle is used in more than one place.","created_at":"2017-08-31T13:45:29Z","updated_at":"2017-08-31T13:45:29Z","html_url":"https://github.com/Microsoft/WindowsTemplateStudio/pull/1038#discussion_r136338631","pull_request_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/pulls/1038","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/pulls/comments/136338631"},"html":{"href":"https://github.com/Microsoft/WindowsTemplateStudio/pull/1038#discussion_r136338631"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/pulls/1038"}},"in_reply_to_id":136108880},"pull_request":{"url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/pulls/1038","id":138443816,"html_url":"https://github.com/Microsoft/WindowsTemplateStudio/pull/1038","diff_url":"https://github.com/Microsoft/WindowsTemplateStudio/pull/1038.diff","patch_url":"https://github.com/Microsoft/WindowsTemplateStudio/pull/1038.patch","issue_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/issues/1038","number":1038,"state":"open","locked":false,"title":"Fix focus visual state on information button","user":{"login":"mvegaca","id":5556784,"avatar_url":"https://avatars2.githubusercontent.com/u/5556784?v=4","gravatar_id":"","url":"https://api.github.com/users/mvegaca","html_url":"https://github.com/mvegaca","followers_url":"https://api.github.com/users/mvegaca/followers","following_url":"https://api.github.com/users/mvegaca/following{/other_user}","gists_url":"https://api.github.com/users/mvegaca/gists{/gist_id}","starred_url":"https://api.github.com/users/mvegaca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvegaca/subscriptions","organizations_url":"https://api.github.com/users/mvegaca/orgs","repos_url":"https://api.github.com/users/mvegaca/repos","events_url":"https://api.github.com/users/mvegaca/events{/privacy}","received_events_url":"https://api.github.com/users/mvegaca/received_events","type":"User","site_admin":false},"body":"#1029\r\n","created_at":"2017-08-30T14:37:01Z","updated_at":"2017-08-31T13:45:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb72461e8fb8dc1d18c2d73705b8c0c1d03d3dfa","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/pulls/1038/commits","review_comments_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/pulls/1038/comments","review_comment_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/issues/1038/comments","statuses_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/statuses/619539551bc55b87e66750b92c4ca8cce1995d01","head":{"label":"mvegaca:Issue1029-focusvisualstate","ref":"Issue1029-focusvisualstate","sha":"619539551bc55b87e66750b92c4ca8cce1995d01","user":{"login":"mvegaca","id":5556784,"avatar_url":"https://avatars2.githubusercontent.com/u/5556784?v=4","gravatar_id":"","url":"https://api.github.com/users/mvegaca","html_url":"https://github.com/mvegaca","followers_url":"https://api.github.com/users/mvegaca/followers","following_url":"https://api.github.com/users/mvegaca/following{/other_user}","gists_url":"https://api.github.com/users/mvegaca/gists{/gist_id}","starred_url":"https://api.github.com/users/mvegaca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvegaca/subscriptions","organizations_url":"https://api.github.com/users/mvegaca/orgs","repos_url":"https://api.github.com/users/mvegaca/repos","events_url":"https://api.github.com/users/mvegaca/events{/privacy}","received_events_url":"https://api.github.com/users/mvegaca/received_events","type":"User","site_admin":false},"repo":{"id":101181501,"name":"WindowsTemplateStudio","full_name":"mvegaca/WindowsTemplateStudio","owner":{"login":"mvegaca","id":5556784,"avatar_url":"https://avatars2.githubusercontent.com/u/5556784?v=4","gravatar_id":"","url":"https://api.github.com/users/mvegaca","html_url":"https://github.com/mvegaca","followers_url":"https://api.github.com/users/mvegaca/followers","following_url":"https://api.github.com/users/mvegaca/following{/other_user}","gists_url":"https://api.github.com/users/mvegaca/gists{/gist_id}","starred_url":"https://api.github.com/users/mvegaca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvegaca/subscriptions","organizations_url":"https://api.github.com/users/mvegaca/orgs","repos_url":"https://api.github.com/users/mvegaca/repos","events_url":"https://api.github.com/users/mvegaca/events{/privacy}","received_events_url":"https://api.github.com/users/mvegaca/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mvegaca/WindowsTemplateStudio","description":"Windows Template Studio quickly builds a UWP app, using a wizard-based UI to turn your needs into a foundation of Windows 10 patterns and best practices.","fork":true,"url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio","forks_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/forks","keys_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/teams","hooks_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/hooks","issue_events_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/issues/events{/number}","events_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/events","assignees_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/assignees{/user}","branches_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/branches{/branch}","tags_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/tags","blobs_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/statuses/{sha}","languages_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/languages","stargazers_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/stargazers","contributors_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/contributors","subscribers_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/subscribers","subscription_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/subscription","commits_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/contents/{+path}","compare_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/merges","archive_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/downloads","issues_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/issues{/number}","pulls_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/pulls{/number}","milestones_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/milestones{/number}","notifications_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/labels{/name}","releases_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/releases{/id}","deployments_url":"https://api.github.com/repos/mvegaca/WindowsTemplateStudio/deployments","created_at":"2017-08-23T13:11:16Z","updated_at":"2017-08-23T13:11:19Z","pushed_at":"2017-08-31T13:36:23Z","git_url":"git://github.com/mvegaca/WindowsTemplateStudio.git","ssh_url":"[email protected]:mvegaca/WindowsTemplateStudio.git","clone_url":"https://github.com/mvegaca/WindowsTemplateStudio.git","svn_url":"https://github.com/mvegaca/WindowsTemplateStudio","homepage":"https://aka.ms/wtsinstall","size":17989,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:dev","ref":"dev","sha":"fbf37034493c9108c0257bf3a68683b8759295e8","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":77063606,"name":"WindowsTemplateStudio","full_name":"Microsoft/WindowsTemplateStudio","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/WindowsTemplateStudio","description":"Windows Template Studio quickly builds a UWP app, using a wizard-based UI to turn your needs into a foundation of Windows 10 patterns and best practices.","fork":false,"url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio","forks_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/forks","keys_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/teams","hooks_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/events","assignees_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/tags","blobs_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/languages","stargazers_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/subscription","commits_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/merges","archive_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/downloads","issues_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/deployments","created_at":"2016-12-21T15:31:29Z","updated_at":"2017-08-31T10:40:00Z","pushed_at":"2017-08-31T13:20:16Z","git_url":"git://github.com/Microsoft/WindowsTemplateStudio.git","ssh_url":"[email protected]:Microsoft/WindowsTemplateStudio.git","clone_url":"https://github.com/Microsoft/WindowsTemplateStudio.git","svn_url":"https://github.com/Microsoft/WindowsTemplateStudio","homepage":"https://aka.ms/wtsinstall","size":17939,"stargazers_count":662,"watchers_count":662,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":181,"forks":92,"open_issues":181,"watchers":662,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/pulls/1038"},"html":{"href":"https://github.com/Microsoft/WindowsTemplateStudio/pull/1038"},"issue":{"href":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/issues/1038"},"comments":{"href":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/issues/1038/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/pulls/1038/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/pulls/1038/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/statuses/619539551bc55b87e66750b92c4ca8cce1995d01"}},"author_association":"MEMBER"}} | {
"id": 77063606,
"name": "Microsoft/WindowsTemplateStudio",
"url": "https://api.github.com/repos/Microsoft/WindowsTemplateStudio"
} | {
"id": 5556784,
"login": "mvegaca",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5556784?",
"url": "https://api.github.com/users/mvegaca"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2017-08-31T13:45:29 | 6535168043 | {"actor":{"display_login":"mvegaca"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/comments/153687073","pull_request_review_id":79729107,"id":153687073,"diff_hunk":"@@ -470,8 +470,7 @@ private DateTimeResolutionResult ParseDurationWithAgoAndLater(string text, DateO\n config.DurationParser,\n config.UnitMap,\n config.UnitRegex,\n- config.UtilityConfiguration,\n- AgoLaterUtil.AgoLaterMode.Date","path":".NET/Microsoft.Recognizers.Text.DateTime/Parsers/BaseDateParser.cs","position":5,"original_position":5,"commit_id":"fb5c8ae7d9f9b9809a2aa84df8f971814ca0cfa8","original_commit_id":"fb5c8ae7d9f9b9809a2aa84df8f971814ca0cfa8","user":{"login":"rubio41","id":15685095,"avatar_url":"https://avatars2.githubusercontent.com/u/15685095?v=4","gravatar_id":"","url":"https://api.github.com/users/rubio41","html_url":"https://github.com/rubio41","followers_url":"https://api.github.com/users/rubio41/followers","following_url":"https://api.github.com/users/rubio41/following{/other_user}","gists_url":"https://api.github.com/users/rubio41/gists{/gist_id}","starred_url":"https://api.github.com/users/rubio41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubio41/subscriptions","organizations_url":"https://api.github.com/users/rubio41/orgs","repos_url":"https://api.github.com/users/rubio41/repos","events_url":"https://api.github.com/users/rubio41/events{/privacy}","received_events_url":"https://api.github.com/users/rubio41/received_events","type":"User","site_admin":false},"body":"yes. Determined the mode in the code before.","created_at":"2017-11-29T03:35:47Z","updated_at":"2017-11-29T03:35:47Z","html_url":"https://github.com/Microsoft/Recognizers-Text/pull/223#discussion_r153687073","pull_request_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/223","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/comments/153687073"},"html":{"href":"https://github.com/Microsoft/Recognizers-Text/pull/223#discussion_r153687073"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/223"}},"in_reply_to_id":153421493},"pull_request":{"url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/223","id":154974984,"html_url":"https://github.com/Microsoft/Recognizers-Text/pull/223","diff_url":"https://github.com/Microsoft/Recognizers-Text/pull/223.diff","patch_url":"https://github.com/Microsoft/Recognizers-Text/pull/223.patch","issue_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/223","number":223,"state":"open","locked":false,"title":"Support multi duration ","user":{"login":"rubio41","id":15685095,"avatar_url":"https://avatars2.githubusercontent.com/u/15685095?v=4","gravatar_id":"","url":"https://api.github.com/users/rubio41","html_url":"https://github.com/rubio41","followers_url":"https://api.github.com/users/rubio41/followers","following_url":"https://api.github.com/users/rubio41/following{/other_user}","gists_url":"https://api.github.com/users/rubio41/gists{/gist_id}","starred_url":"https://api.github.com/users/rubio41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubio41/subscriptions","organizations_url":"https://api.github.com/users/rubio41/orgs","repos_url":"https://api.github.com/users/rubio41/repos","events_url":"https://api.github.com/users/rubio41/events{/privacy}","received_events_url":"https://api.github.com/users/rubio41/received_events","type":"User","site_admin":false},"body":"Support multi duration such as \"1 month 21 day\"","created_at":"2017-11-28T04:02:48Z","updated_at":"2017-11-29T03:35:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"032fd206d6263f92b64c5014cb6f8879b1ac8773","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/223/commits","review_comments_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/223/comments","review_comment_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/223/comments","statuses_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/statuses/fb5c8ae7d9f9b9809a2aa84df8f971814ca0cfa8","head":{"label":"rubio41:MergedDuration","ref":"MergedDuration","sha":"fb5c8ae7d9f9b9809a2aa84df8f971814ca0cfa8","user":{"login":"rubio41","id":15685095,"avatar_url":"https://avatars2.githubusercontent.com/u/15685095?v=4","gravatar_id":"","url":"https://api.github.com/users/rubio41","html_url":"https://github.com/rubio41","followers_url":"https://api.github.com/users/rubio41/followers","following_url":"https://api.github.com/users/rubio41/following{/other_user}","gists_url":"https://api.github.com/users/rubio41/gists{/gist_id}","starred_url":"https://api.github.com/users/rubio41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubio41/subscriptions","organizations_url":"https://api.github.com/users/rubio41/orgs","repos_url":"https://api.github.com/users/rubio41/repos","events_url":"https://api.github.com/users/rubio41/events{/privacy}","received_events_url":"https://api.github.com/users/rubio41/received_events","type":"User","site_admin":false},"repo":{"id":94398472,"name":"Recognizers-Text","full_name":"rubio41/Recognizers-Text","owner":{"login":"rubio41","id":15685095,"avatar_url":"https://avatars2.githubusercontent.com/u/15685095?v=4","gravatar_id":"","url":"https://api.github.com/users/rubio41","html_url":"https://github.com/rubio41","followers_url":"https://api.github.com/users/rubio41/followers","following_url":"https://api.github.com/users/rubio41/following{/other_user}","gists_url":"https://api.github.com/users/rubio41/gists{/gist_id}","starred_url":"https://api.github.com/users/rubio41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubio41/subscriptions","organizations_url":"https://api.github.com/users/rubio41/orgs","repos_url":"https://api.github.com/users/rubio41/repos","events_url":"https://api.github.com/users/rubio41/events{/privacy}","received_events_url":"https://api.github.com/users/rubio41/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rubio41/Recognizers-Text","description":"Microsoft.Recognizers.Text.Number provides robust recognition and resolution of numbers expressed in English, Spanish and Chinese.","fork":true,"url":"https://api.github.com/repos/rubio41/Recognizers-Text","forks_url":"https://api.github.com/repos/rubio41/Recognizers-Text/forks","keys_url":"https://api.github.com/repos/rubio41/Recognizers-Text/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubio41/Recognizers-Text/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubio41/Recognizers-Text/teams","hooks_url":"https://api.github.com/repos/rubio41/Recognizers-Text/hooks","issue_events_url":"https://api.github.com/repos/rubio41/Recognizers-Text/issues/events{/number}","events_url":"https://api.github.com/repos/rubio41/Recognizers-Text/events","assignees_url":"https://api.github.com/repos/rubio41/Recognizers-Text/assignees{/user}","branches_url":"https://api.github.com/repos/rubio41/Recognizers-Text/branches{/branch}","tags_url":"https://api.github.com/repos/rubio41/Recognizers-Text/tags","blobs_url":"https://api.github.com/repos/rubio41/Recognizers-Text/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubio41/Recognizers-Text/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubio41/Recognizers-Text/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubio41/Recognizers-Text/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubio41/Recognizers-Text/statuses/{sha}","languages_url":"https://api.github.com/repos/rubio41/Recognizers-Text/languages","stargazers_url":"https://api.github.com/repos/rubio41/Recognizers-Text/stargazers","contributors_url":"https://api.github.com/repos/rubio41/Recognizers-Text/contributors","subscribers_url":"https://api.github.com/repos/rubio41/Recognizers-Text/subscribers","subscription_url":"https://api.github.com/repos/rubio41/Recognizers-Text/subscription","commits_url":"https://api.github.com/repos/rubio41/Recognizers-Text/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubio41/Recognizers-Text/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubio41/Recognizers-Text/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubio41/Recognizers-Text/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubio41/Recognizers-Text/contents/{+path}","compare_url":"https://api.github.com/repos/rubio41/Recognizers-Text/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubio41/Recognizers-Text/merges","archive_url":"https://api.github.com/repos/rubio41/Recognizers-Text/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubio41/Recognizers-Text/downloads","issues_url":"https://api.github.com/repos/rubio41/Recognizers-Text/issues{/number}","pulls_url":"https://api.github.com/repos/rubio41/Recognizers-Text/pulls{/number}","milestones_url":"https://api.github.com/repos/rubio41/Recognizers-Text/milestones{/number}","notifications_url":"https://api.github.com/repos/rubio41/Recognizers-Text/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubio41/Recognizers-Text/labels{/name}","releases_url":"https://api.github.com/repos/rubio41/Recognizers-Text/releases{/id}","deployments_url":"https://api.github.com/repos/rubio41/Recognizers-Text/deployments","created_at":"2017-06-15T04:07:38Z","updated_at":"2017-07-25T03:48:10Z","pushed_at":"2017-11-28T05:12:04Z","git_url":"git://github.com/rubio41/Recognizers-Text.git","ssh_url":"[email protected]:rubio41/Recognizers-Text.git","clone_url":"https://github.com/rubio41/Recognizers-Text.git","svn_url":"https://github.com/rubio41/Recognizers-Text","homepage":"","size":11781,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"1357488698c6068846e51fa4f95bdb8090d99fc0","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":88544417,"name":"Recognizers-Text","full_name":"Microsoft/Recognizers-Text","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/Recognizers-Text","description":"Microsoft.Recognizers.Text provides robust recognition and resolution of numbers, units, and date/time expressed in multiple languages. Support for English, Spanish, Chinese, and French (full); and Portuguese (partial). Contributions are greatly welcome. Packages are available in nuget.org at: https://www.nuget.org/profiles/Recognizers.Text","fork":false,"url":"https://api.github.com/repos/Microsoft/Recognizers-Text","forks_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/forks","keys_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/teams","hooks_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/events","assignees_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/tags","blobs_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/languages","stargazers_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/subscription","commits_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/merges","archive_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/downloads","issues_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/deployments","created_at":"2017-04-17T19:45:47Z","updated_at":"2017-11-28T00:08:53Z","pushed_at":"2017-11-28T08:22:07Z","git_url":"git://github.com/Microsoft/Recognizers-Text.git","ssh_url":"[email protected]:Microsoft/Recognizers-Text.git","clone_url":"https://github.com/Microsoft/Recognizers-Text.git","svn_url":"https://github.com/Microsoft/Recognizers-Text","homepage":"","size":6122,"stargazers_count":61,"watchers_count":61,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":33,"open_issues":28,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/223"},"html":{"href":"https://github.com/Microsoft/Recognizers-Text/pull/223"},"issue":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/223"},"comments":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/223/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/223/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/statuses/fb5c8ae7d9f9b9809a2aa84df8f971814ca0cfa8"}},"author_association":"MEMBER"}} | {
"id": 88544417,
"name": "Microsoft/Recognizers-Text",
"url": "https://api.github.com/repos/Microsoft/Recognizers-Text"
} | {
"id": 15685095,
"login": "rubio41",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15685095?",
"url": "https://api.github.com/users/rubio41"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2017-11-29T03:35:47 | 6916608342 | {"actor":{"display_login":"rubio41"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/YamUI/pulls/comments/139230303","pull_request_review_id":63139235,"id":139230303,"diff_hunk":"@@ -91,13 +91,13 @@\n \"watch:css:components\": \"postcss \\\"src/components/**/*.css\\\" --dir \\\"dist/components\\\" --base \\\"src/components\\\" --watch\",\n \"watch:ts:components\": \"tsc --project . --watch\",\n \"watch\": \"run-p watch:**\",\n- \"start:dev\": \"yarn build && run-p watch storybook:start\",\n+ \"start:dev\": \"npm-run-all build --parallel watch storybook:start\",","path":"package.json","position":14,"original_position":14,"commit_id":"15f7f6a03a2c8dcba8148e8b08283607bc61c1e8","original_commit_id":"15f7f6a03a2c8dcba8148e8b08283607bc61c1e8","user":{"login":"unindented","id":69485,"avatar_url":"https://avatars1.githubusercontent.com/u/69485?v=4","gravatar_id":"","url":"https://api.github.com/users/unindented","html_url":"https://github.com/unindented","followers_url":"https://api.github.com/users/unindented/followers","following_url":"https://api.github.com/users/unindented/following{/other_user}","gists_url":"https://api.github.com/users/unindented/gists{/gist_id}","starred_url":"https://api.github.com/users/unindented/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unindented/subscriptions","organizations_url":"https://api.github.com/users/unindented/orgs","repos_url":"https://api.github.com/users/unindented/repos","events_url":"https://api.github.com/users/unindented/events{/privacy}","received_events_url":"https://api.github.com/users/unindented/received_events","type":"User","site_admin":false},"body":"Yup. I didn't want to do the same thing in two different ways. I was also unsure how `&&` behaves on Windows.","created_at":"2017-09-15T19:20:22Z","updated_at":"2017-09-15T19:20:22Z","html_url":"https://github.com/Microsoft/YamUI/pull/54#discussion_r139230303","pull_request_url":"https://api.github.com/repos/Microsoft/YamUI/pulls/54","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/YamUI/pulls/comments/139230303"},"html":{"href":"https://github.com/Microsoft/YamUI/pull/54#discussion_r139230303"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/YamUI/pulls/54"}},"in_reply_to_id":139229414},"pull_request":{"url":"https://api.github.com/repos/Microsoft/YamUI/pulls/54","id":141201443,"html_url":"https://github.com/Microsoft/YamUI/pull/54","diff_url":"https://github.com/Microsoft/YamUI/pull/54.diff","patch_url":"https://github.com/Microsoft/YamUI/pull/54.patch","issue_url":"https://api.github.com/repos/Microsoft/YamUI/issues/54","number":54,"state":"open","locked":false,"title":"Deploy Storybook to gh-pages from Travis","user":{"login":"unindented","id":69485,"avatar_url":"https://avatars1.githubusercontent.com/u/69485?v=4","gravatar_id":"","url":"https://api.github.com/users/unindented","html_url":"https://github.com/unindented","followers_url":"https://api.github.com/users/unindented/followers","following_url":"https://api.github.com/users/unindented/following{/other_user}","gists_url":"https://api.github.com/users/unindented/gists{/gist_id}","starred_url":"https://api.github.com/users/unindented/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unindented/subscriptions","organizations_url":"https://api.github.com/users/unindented/orgs","repos_url":"https://api.github.com/users/unindented/repos","events_url":"https://api.github.com/users/unindented/events{/privacy}","received_events_url":"https://api.github.com/users/unindented/received_events","type":"User","site_admin":false},"body":"Instead of committing the `docs` folder as part of every PR, I propose building it when Travis runs after a merge into master, and committing to `gh-pages` from Travis itself using a deploy key.\r\n\r\nFixes #6\r\nFixes #53","created_at":"2017-09-14T23:48:56Z","updated_at":"2017-09-15T19:20:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d37d63fc09d9986443cb72a38d0e4e5bf13300d6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/YamUI/pulls/54/commits","review_comments_url":"https://api.github.com/repos/Microsoft/YamUI/pulls/54/comments","review_comment_url":"https://api.github.com/repos/Microsoft/YamUI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/YamUI/issues/54/comments","statuses_url":"https://api.github.com/repos/Microsoft/YamUI/statuses/15f7f6a03a2c8dcba8148e8b08283607bc61c1e8","head":{"label":"Microsoft:dalvarez-gh-pages","ref":"dalvarez-gh-pages","sha":"15f7f6a03a2c8dcba8148e8b08283607bc61c1e8","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":97036342,"name":"YamUI","full_name":"Microsoft/YamUI","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/YamUI","description":"Reusable component framework for Yammer.com","fork":false,"url":"https://api.github.com/repos/Microsoft/YamUI","forks_url":"https://api.github.com/repos/Microsoft/YamUI/forks","keys_url":"https://api.github.com/repos/Microsoft/YamUI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/YamUI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/YamUI/teams","hooks_url":"https://api.github.com/repos/Microsoft/YamUI/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/YamUI/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/YamUI/events","assignees_url":"https://api.github.com/repos/Microsoft/YamUI/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/YamUI/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/YamUI/tags","blobs_url":"https://api.github.com/repos/Microsoft/YamUI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/YamUI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/YamUI/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/YamUI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/YamUI/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/YamUI/languages","stargazers_url":"https://api.github.com/repos/Microsoft/YamUI/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/YamUI/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/YamUI/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/YamUI/subscription","commits_url":"https://api.github.com/repos/Microsoft/YamUI/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/YamUI/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/YamUI/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/YamUI/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/YamUI/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/YamUI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/YamUI/merges","archive_url":"https://api.github.com/repos/Microsoft/YamUI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/YamUI/downloads","issues_url":"https://api.github.com/repos/Microsoft/YamUI/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/YamUI/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/YamUI/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/YamUI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/YamUI/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/YamUI/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/YamUI/deployments","created_at":"2017-07-12T17:43:12Z","updated_at":"2017-09-14T22:52:38Z","pushed_at":"2017-09-15T19:03:57Z","git_url":"git://github.com/Microsoft/YamUI.git","ssh_url":"[email protected]:Microsoft/YamUI.git","clone_url":"https://github.com/Microsoft/YamUI.git","svn_url":"https://github.com/Microsoft/YamUI","homepage":"https://microsoft.github.io/YamUI/","size":7505,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":19,"forks":2,"open_issues":19,"watchers":4,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"21ce980df84323f2c6dfdaaa2dffbd578959f7e2","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":97036342,"name":"YamUI","full_name":"Microsoft/YamUI","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/YamUI","description":"Reusable component framework for Yammer.com","fork":false,"url":"https://api.github.com/repos/Microsoft/YamUI","forks_url":"https://api.github.com/repos/Microsoft/YamUI/forks","keys_url":"https://api.github.com/repos/Microsoft/YamUI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/YamUI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/YamUI/teams","hooks_url":"https://api.github.com/repos/Microsoft/YamUI/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/YamUI/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/YamUI/events","assignees_url":"https://api.github.com/repos/Microsoft/YamUI/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/YamUI/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/YamUI/tags","blobs_url":"https://api.github.com/repos/Microsoft/YamUI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/YamUI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/YamUI/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/YamUI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/YamUI/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/YamUI/languages","stargazers_url":"https://api.github.com/repos/Microsoft/YamUI/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/YamUI/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/YamUI/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/YamUI/subscription","commits_url":"https://api.github.com/repos/Microsoft/YamUI/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/YamUI/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/YamUI/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/YamUI/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/YamUI/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/YamUI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/YamUI/merges","archive_url":"https://api.github.com/repos/Microsoft/YamUI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/YamUI/downloads","issues_url":"https://api.github.com/repos/Microsoft/YamUI/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/YamUI/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/YamUI/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/YamUI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/YamUI/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/YamUI/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/YamUI/deployments","created_at":"2017-07-12T17:43:12Z","updated_at":"2017-09-14T22:52:38Z","pushed_at":"2017-09-15T19:03:57Z","git_url":"git://github.com/Microsoft/YamUI.git","ssh_url":"[email protected]:Microsoft/YamUI.git","clone_url":"https://github.com/Microsoft/YamUI.git","svn_url":"https://github.com/Microsoft/YamUI","homepage":"https://microsoft.github.io/YamUI/","size":7505,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":19,"forks":2,"open_issues":19,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/YamUI/pulls/54"},"html":{"href":"https://github.com/Microsoft/YamUI/pull/54"},"issue":{"href":"https://api.github.com/repos/Microsoft/YamUI/issues/54"},"comments":{"href":"https://api.github.com/repos/Microsoft/YamUI/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/YamUI/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/YamUI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/YamUI/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/YamUI/statuses/15f7f6a03a2c8dcba8148e8b08283607bc61c1e8"}},"author_association":"CONTRIBUTOR"}} | {
"id": 97036342,
"name": "Microsoft/YamUI",
"url": "https://api.github.com/repos/Microsoft/YamUI"
} | {
"id": 69485,
"login": "unindented",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/69485?",
"url": "https://api.github.com/users/unindented"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2017-09-15T19:20:22 | 6597245381 | {"actor":{"display_login":"unindented"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments/134783313","pull_request_review_id":58116437,"id":134783313,"diff_hunk":"@@ -77,7 +77,7 @@\n # Search the package files for differences (Unless the user doesn't want to log all changes and we already know the package xml changed)\n $newPackagePath = Join-Path $NewPackageRoot $packageName\n $oldPackagePath = Join-Path $OldPackageRoot $packageName\n- if (Find-FileChanges $newPackagePath $oldPackagePath $LogIndent -LogAllChanges:$LogAllChanges)\n+ if ((Test-Path $newPackagePath) -and (Find-FileChanges $newPackagePath $oldPackagePath $LogIndent -LogAllChanges:$LogAllChanges))","path":"Tasks/ServiceFabricUpdateAppVersions/Update-PackageVersion.psm1","position":5,"original_position":5,"commit_id":"4b13a0d1609a869b23bbe6e1f81cdb07ba682abe","original_commit_id":"4b13a0d1609a869b23bbe6e1f81cdb07ba682abe","user":{"login":"bishal-pdMSFT","id":7830141,"avatar_url":"https://avatars3.githubusercontent.com/u/7830141?v=4","gravatar_id":"","url":"https://api.github.com/users/bishal-pdMSFT","html_url":"https://github.com/bishal-pdMSFT","followers_url":"https://api.github.com/users/bishal-pdMSFT/followers","following_url":"https://api.github.com/users/bishal-pdMSFT/following{/other_user}","gists_url":"https://api.github.com/users/bishal-pdMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/bishal-pdMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bishal-pdMSFT/subscriptions","organizations_url":"https://api.github.com/users/bishal-pdMSFT/orgs","repos_url":"https://api.github.com/users/bishal-pdMSFT/repos","events_url":"https://api.github.com/users/bishal-pdMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/bishal-pdMSFT/received_events","type":"User","site_admin":false},"body":"What about a scenario(in increasing order of time):\r\n1. Deploy application with a service having config package version 1.0\r\n2. Upgrade application with same service having no config package ==> this would be fine as there is no new package and hence version does not matter\r\n3, Deploy application with same service having new config package ==> no old package exists, but we would still need to bump up version to 2.0(or whatever)\r\n\r\nI think this scenario is very corner and it is okay if we don't want to solve it.","created_at":"2017-08-23T15:18:58Z","updated_at":"2017-08-23T15:18:58Z","html_url":"https://github.com/Microsoft/vsts-tasks/pull/5090#discussion_r134783313","pull_request_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/5090","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments/134783313"},"html":{"href":"https://github.com/Microsoft/vsts-tasks/pull/5090#discussion_r134783313"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/5090"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/5090","id":137029820,"html_url":"https://github.com/Microsoft/vsts-tasks/pull/5090","diff_url":"https://github.com/Microsoft/vsts-tasks/pull/5090.diff","patch_url":"https://github.com/Microsoft/vsts-tasks/pull/5090.patch","issue_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/5090","number":5090,"state":"open","locked":false,"title":"Fix SF update app versions bug when package folder doesn't exist","user":{"login":"mthalman-msft","id":15789599,"avatar_url":"https://avatars1.githubusercontent.com/u/15789599?v=4","gravatar_id":"","url":"https://api.github.com/users/mthalman-msft","html_url":"https://github.com/mthalman-msft","followers_url":"https://api.github.com/users/mthalman-msft/followers","following_url":"https://api.github.com/users/mthalman-msft/following{/other_user}","gists_url":"https://api.github.com/users/mthalman-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/mthalman-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mthalman-msft/subscriptions","organizations_url":"https://api.github.com/users/mthalman-msft/orgs","repos_url":"https://api.github.com/users/mthalman-msft/repos","events_url":"https://api.github.com/users/mthalman-msft/events{/privacy}","received_events_url":"https://api.github.com/users/mthalman-msft/received_events","type":"User","site_admin":false},"body":"When using Docker-based Service Fabric service projects, there will not exist a code package within the service package generated by the build. This is simply because a code package is not relevant; the code exists in the Docker image. In such a scenario, however, the ServiceFabricUpdateAppVersions task fails its validation logic because it assumes a Code folder will exist in the service package since the service manifest described a Code package. This leads to an error when running that task.\r\n\r\nThe solution is to change the logic in the task to account for the situation where the folder does not exist. If it doesn't, then it simply skips further analysis of that folder.","created_at":"2017-08-22T16:52:54Z","updated_at":"2017-08-23T15:18:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"073a9583f4d532b0d673c55904de397a32585613","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kmkumaran","id":11780076,"avatar_url":"https://avatars2.githubusercontent.com/u/11780076?v=4","gravatar_id":"","url":"https://api.github.com/users/kmkumaran","html_url":"https://github.com/kmkumaran","followers_url":"https://api.github.com/users/kmkumaran/followers","following_url":"https://api.github.com/users/kmkumaran/following{/other_user}","gists_url":"https://api.github.com/users/kmkumaran/gists{/gist_id}","starred_url":"https://api.github.com/users/kmkumaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmkumaran/subscriptions","organizations_url":"https://api.github.com/users/kmkumaran/orgs","repos_url":"https://api.github.com/users/kmkumaran/repos","events_url":"https://api.github.com/users/kmkumaran/events{/privacy}","received_events_url":"https://api.github.com/users/kmkumaran/received_events","type":"User","site_admin":false},{"login":"sachinma","id":17923727,"avatar_url":"https://avatars2.githubusercontent.com/u/17923727?v=4","gravatar_id":"","url":"https://api.github.com/users/sachinma","html_url":"https://github.com/sachinma","followers_url":"https://api.github.com/users/sachinma/followers","following_url":"https://api.github.com/users/sachinma/following{/other_user}","gists_url":"https://api.github.com/users/sachinma/gists{/gist_id}","starred_url":"https://api.github.com/users/sachinma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachinma/subscriptions","organizations_url":"https://api.github.com/users/sachinma/orgs","repos_url":"https://api.github.com/users/sachinma/repos","events_url":"https://api.github.com/users/sachinma/events{/privacy}","received_events_url":"https://api.github.com/users/sachinma/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/5090/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/5090/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/5090/comments","statuses_url":"https://api.github.com/repos/Microsoft/vsts-tasks/statuses/4b13a0d1609a869b23bbe6e1f81cdb07ba682abe","head":{"label":"Microsoft:users/mthalman/UpdateVersionsFix","ref":"users/mthalman/UpdateVersionsFix","sha":"4b13a0d1609a869b23bbe6e1f81cdb07ba682abe","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":27631673,"name":"vsts-tasks","full_name":"Microsoft/vsts-tasks","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vsts-tasks","description":"Build and Release Tasks for Visual Studio Team Services and Team Foundation Server","fork":false,"url":"https://api.github.com/repos/Microsoft/vsts-tasks","forks_url":"https://api.github.com/repos/Microsoft/vsts-tasks/forks","keys_url":"https://api.github.com/repos/Microsoft/vsts-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vsts-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vsts-tasks/teams","hooks_url":"https://api.github.com/repos/Microsoft/vsts-tasks/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vsts-tasks/events","assignees_url":"https://api.github.com/repos/Microsoft/vsts-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vsts-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vsts-tasks/tags","blobs_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vsts-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vsts-tasks/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vsts-tasks/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vsts-tasks/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vsts-tasks/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vsts-tasks/subscription","commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vsts-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vsts-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vsts-tasks/merges","archive_url":"https://api.github.com/repos/Microsoft/vsts-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vsts-tasks/downloads","issues_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vsts-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vsts-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vsts-tasks/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vsts-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/deployments","created_at":"2014-12-06T11:11:46Z","updated_at":"2017-08-23T09:26:27Z","pushed_at":"2017-08-23T15:11:46Z","git_url":"git://github.com/Microsoft/vsts-tasks.git","ssh_url":"[email protected]:Microsoft/vsts-tasks.git","clone_url":"https://github.com/Microsoft/vsts-tasks.git","svn_url":"https://github.com/Microsoft/vsts-tasks","homepage":"https://aka.ms/tfbuild","size":33219,"stargazers_count":644,"watchers_count":644,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":587,"mirror_url":null,"open_issues_count":208,"forks":587,"open_issues":208,"watchers":644,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"aa98a8931b5d8f66b244a5828c759f18bf72bf18","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":27631673,"name":"vsts-tasks","full_name":"Microsoft/vsts-tasks","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vsts-tasks","description":"Build and Release Tasks for Visual Studio Team Services and Team Foundation Server","fork":false,"url":"https://api.github.com/repos/Microsoft/vsts-tasks","forks_url":"https://api.github.com/repos/Microsoft/vsts-tasks/forks","keys_url":"https://api.github.com/repos/Microsoft/vsts-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vsts-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vsts-tasks/teams","hooks_url":"https://api.github.com/repos/Microsoft/vsts-tasks/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vsts-tasks/events","assignees_url":"https://api.github.com/repos/Microsoft/vsts-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vsts-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vsts-tasks/tags","blobs_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vsts-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vsts-tasks/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vsts-tasks/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vsts-tasks/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vsts-tasks/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vsts-tasks/subscription","commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vsts-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vsts-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vsts-tasks/merges","archive_url":"https://api.github.com/repos/Microsoft/vsts-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vsts-tasks/downloads","issues_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vsts-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vsts-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vsts-tasks/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vsts-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/deployments","created_at":"2014-12-06T11:11:46Z","updated_at":"2017-08-23T09:26:27Z","pushed_at":"2017-08-23T15:11:46Z","git_url":"git://github.com/Microsoft/vsts-tasks.git","ssh_url":"[email protected]:Microsoft/vsts-tasks.git","clone_url":"https://github.com/Microsoft/vsts-tasks.git","svn_url":"https://github.com/Microsoft/vsts-tasks","homepage":"https://aka.ms/tfbuild","size":33219,"stargazers_count":644,"watchers_count":644,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":587,"mirror_url":null,"open_issues_count":208,"forks":587,"open_issues":208,"watchers":644,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/5090"},"html":{"href":"https://github.com/Microsoft/vsts-tasks/pull/5090"},"issue":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/5090"},"comments":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/5090/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/5090/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/5090/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/statuses/4b13a0d1609a869b23bbe6e1f81cdb07ba682abe"}}}} | {
"id": 27631673,
"name": "Microsoft/vsts-tasks",
"url": "https://api.github.com/repos/Microsoft/vsts-tasks"
} | {
"id": 7830141,
"login": "bishal-pdMSFT",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7830141?",
"url": "https://api.github.com/users/bishal-pdMSFT"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2017-08-23T15:18:58 | 6502983645 | {"actor":{"display_login":"bishal-pdMSFT"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/comments/97893653","pull_request_review_id":18518669,"id":97893653,"diff_hunk":"@@ -0,0 +1,258 @@\n+namespace Microsoft.ApplicationInsights.Extensibility.PerfCounterCollector.Implementation.QuickPulse.PerfLib\n+{\n+ using System;\n+ using System.Collections.Generic;\n+ using System.Globalization;\n+ using System.Runtime.InteropServices;\n+\n+ internal class CategorySample\n+ {\n+ public Dictionary<int, CounterDefinitionSample> CounterTable;","path":"Src/PerformanceCollector/Shared/Implementation/QuickPulse/Process/PerfLib/CategorySample.cs","position":10,"original_position":10,"commit_id":"70100c36b5aa2f14bab9770a148dab708b7e872a","original_commit_id":"20d5cd82150de88a37545a69b76f056b092e395f","user":{"login":"tokaplan","id":8517601,"avatar_url":"https://avatars.githubusercontent.com/u/8517601?v=3","gravatar_id":"","url":"https://api.github.com/users/tokaplan","html_url":"https://github.com/tokaplan","followers_url":"https://api.github.com/users/tokaplan/followers","following_url":"https://api.github.com/users/tokaplan/following{/other_user}","gists_url":"https://api.github.com/users/tokaplan/gists{/gist_id}","starred_url":"https://api.github.com/users/tokaplan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokaplan/subscriptions","organizations_url":"https://api.github.com/users/tokaplan/orgs","repos_url":"https://api.github.com/users/tokaplan/repos","events_url":"https://api.github.com/users/tokaplan/events{/privacy}","received_events_url":"https://api.github.com/users/tokaplan/received_events","type":"User","site_admin":false},"body":"That's an option, but that would mean an extra constructor in the production implementation that we don't need (and it would make zero sense semantically, too). My judgement call is that we're ok without the readonly keyword here.","created_at":"2017-01-25T22:26:19Z","updated_at":"2017-01-25T22:26:19Z","html_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server/pull/269#discussion_r97893653","pull_request_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/269","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/comments/97893653"},"html":{"href":"https://github.com/Microsoft/ApplicationInsights-dotnet-server/pull/269#discussion_r97893653"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/269"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/269","id":97813406,"html_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server/pull/269","diff_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server/pull/269.diff","patch_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server/pull/269.patch","issue_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues/269","number":269,"state":"open","locked":false,"title":"Top processes by CPU for QuickPulse","user":{"login":"tokaplan","id":8517601,"avatar_url":"https://avatars.githubusercontent.com/u/8517601?v=3","gravatar_id":"","url":"https://api.github.com/users/tokaplan","html_url":"https://github.com/tokaplan","followers_url":"https://api.github.com/users/tokaplan/followers","following_url":"https://api.github.com/users/tokaplan/following{/other_user}","gists_url":"https://api.github.com/users/tokaplan/gists{/gist_id}","starred_url":"https://api.github.com/users/tokaplan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokaplan/subscriptions","organizations_url":"https://api.github.com/users/tokaplan/orgs","repos_url":"https://api.github.com/users/tokaplan/repos","events_url":"https://api.github.com/users/tokaplan/events{/privacy}","received_events_url":"https://api.github.com/users/tokaplan/received_events","type":"User","site_admin":false},"body":"This feature allows QuickPulseTelemetryModule to collect a list of top CPU consuming processes on the machine and send it along with the rest of the data for QPS to process and UX to display.","created_at":"2016-12-13T18:59:24Z","updated_at":"2017-01-25T22:26:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a05bce798222c57b6336700f8c10a0f15ee2867c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/269/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/269/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues/269/comments","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/statuses/70100c36b5aa2f14bab9770a148dab708b7e872a","head":{"label":"Microsoft:qps/TopCpu","ref":"qps/TopCpu","sha":"70100c36b5aa2f14bab9770a148dab708b7e872a","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":44223665,"name":"ApplicationInsights-dotnet-server","full_name":"Microsoft/ApplicationInsights-dotnet-server","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server","description":"Microsoft Application Insights for .NET Web Applications","fork":false,"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server","forks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/forks","keys_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/teams","hooks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/events","assignees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/tags","blobs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/subscription","commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/merges","archive_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/downloads","issues_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/deployments","created_at":"2015-10-14T04:20:22Z","updated_at":"2017-01-24T19:57:29Z","pushed_at":"2017-01-25T19:44:40Z","git_url":"git://github.com/Microsoft/ApplicationInsights-dotnet-server.git","ssh_url":"[email protected]:Microsoft/ApplicationInsights-dotnet-server.git","clone_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server.git","svn_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server","homepage":"https://azure.microsoft.com/en-us/services/application-insights/","size":4679,"stargazers_count":32,"watchers_count":32,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":51,"forks":20,"open_issues":51,"watchers":32,"default_branch":"develop"}},"base":{"label":"Microsoft:develop","ref":"develop","sha":"02bcc057569edf914155eaeb0a88186093b16908","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":44223665,"name":"ApplicationInsights-dotnet-server","full_name":"Microsoft/ApplicationInsights-dotnet-server","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server","description":"Microsoft Application Insights for .NET Web Applications","fork":false,"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server","forks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/forks","keys_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/teams","hooks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/events","assignees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/tags","blobs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/subscription","commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/merges","archive_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/downloads","issues_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/deployments","created_at":"2015-10-14T04:20:22Z","updated_at":"2017-01-24T19:57:29Z","pushed_at":"2017-01-25T19:44:40Z","git_url":"git://github.com/Microsoft/ApplicationInsights-dotnet-server.git","ssh_url":"[email protected]:Microsoft/ApplicationInsights-dotnet-server.git","clone_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server.git","svn_url":"https://github.com/Microsoft/ApplicationInsights-dotnet-server","homepage":"https://azure.microsoft.com/en-us/services/application-insights/","size":4679,"stargazers_count":32,"watchers_count":32,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":51,"forks":20,"open_issues":51,"watchers":32,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/269"},"html":{"href":"https://github.com/Microsoft/ApplicationInsights-dotnet-server/pull/269"},"issue":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues/269"},"comments":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/issues/269/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/269/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/pulls/269/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server/statuses/70100c36b5aa2f14bab9770a148dab708b7e872a"}}}} | {
"id": 44223665,
"name": "Microsoft/ApplicationInsights-dotnet-server",
"url": "https://api.github.com/repos/Microsoft/ApplicationInsights-dotnet-server"
} | {
"id": 8517601,
"login": "tokaplan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8517601?",
"url": "https://api.github.com/users/tokaplan"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2017-01-25T22:26:19 | 5214040851 | {"actor":{"display_login":"tokaplan"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vstest-docs/pulls/comments/125846007","pull_request_review_id":48273102,"id":125846007,"diff_hunk":"@@ -0,0 +1,76 @@\n+# 0011 Discover for Only Test Projects\n+\n+## Summary\n+This note outlines the proposed changes to the TestWindow component inside VS IDE,\n+for making improvements in the test discovery.\n+\n+## Motivation\n+* Scope of improvement in discovery through TestExplorer. See [here](#Discovery.Proof)\n+* Need to standardize the rules for identifying Test projects.\n+\n+## Problem\n+TestWindow component inside VS IDE currently sends all the projects present in the solution for discovery.\n+This list of projects includes projects that do not contain any tests.\n+Sending redundant projects to the runner creates an overhead. Each adapter will try and fail to discover any tests inside such projects.\n+\n+### Scenarios\n+There are two ways user can author C# based tests\n+1. Create a test project using Unit Test template\n+2. Add the appropriate adapter or framework references to a class library project. \n+\n+### Current State\n+There are existing ways to identify if a project is a test project. Brief explanation is as follows.\n+\n+#### Test project Guid\n+All C# based classic Unit tests which are created using the default templates have a special ProjectType guid to be identified as Test project. \n+```\n+<ProjectTypeGuids>{3AC096D0-A1C2-E12C-1390-A8335801FDAB}<ProjectTypeGuids>\n+```\n+\n+#### Test Service Guid\n+Currently, there is another special guid that we dynamically add to projects that contain tests and were not created via default template.\n+How this works is, since all the projects are used for discovery, the projects which actually contain tests are identified post discovery\n+operation and a service guid is added to them.\n+\n+```\n+ <ItemGroup>\t\t\n+ <Service Include=\"{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}\" />\t\t\n+ </ItemGroup>\n+```\n+\n+#### Test container capability\n+The latest and recommended way of getting a project identified as a Test project is adding\n+*TestContainer* capability.\n+.Net core based test projects created using the template have this capabilty by default.\n+\n+```\n+<ItemGroup>\n+ <ProjectCapability Include=\"TestContainer\" />\n+</ItemGroup>\n+```\n+\n+## Proposed Changes\n+Add an ability to identify the test projects using all the three rules mentioned above.\n+Also, provide user an option to run discovery operation for test projects only.\n+\n+User will be provide with two options,","path":"RFCs/0011-Discover-Only-TestProjects.md","position":56,"original_position":56,"commit_id":"bfb9ca3bba4f1ab0d6e739dd3b2b9c87b70b2454","original_commit_id":"bfb9ca3bba4f1ab0d6e739dd3b2b9c87b70b2454","user":{"login":"singhsarab","id":18569990,"avatar_url":"https://avatars3.githubusercontent.com/u/18569990?v=3","gravatar_id":"","url":"https://api.github.com/users/singhsarab","html_url":"https://github.com/singhsarab","followers_url":"https://api.github.com/users/singhsarab/followers","following_url":"https://api.github.com/users/singhsarab/following{/other_user}","gists_url":"https://api.github.com/users/singhsarab/gists{/gist_id}","starred_url":"https://api.github.com/users/singhsarab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singhsarab/subscriptions","organizations_url":"https://api.github.com/users/singhsarab/orgs","repos_url":"https://api.github.com/users/singhsarab/repos","events_url":"https://api.github.com/users/singhsarab/events{/privacy}","received_events_url":"https://api.github.com/users/singhsarab/received_events","type":"User","site_admin":false},"body":"Yes.","created_at":"2017-07-06T08:59:28Z","updated_at":"2017-07-06T08:59:28Z","html_url":"https://github.com/Microsoft/vstest-docs/pull/60#discussion_r125846007","pull_request_url":"https://api.github.com/repos/Microsoft/vstest-docs/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vstest-docs/pulls/comments/125846007"},"html":{"href":"https://github.com/Microsoft/vstest-docs/pull/60#discussion_r125846007"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vstest-docs/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vstest-docs/pulls/60","id":128830261,"html_url":"https://github.com/Microsoft/vstest-docs/pull/60","diff_url":"https://github.com/Microsoft/vstest-docs/pull/60.diff","patch_url":"https://github.com/Microsoft/vstest-docs/pull/60.patch","issue_url":"https://api.github.com/repos/Microsoft/vstest-docs/issues/60","number":60,"state":"open","locked":false,"title":"RFC for proposal for discovering only test projects.","user":{"login":"singhsarab","id":18569990,"avatar_url":"https://avatars3.githubusercontent.com/u/18569990?v=3","gravatar_id":"","url":"https://api.github.com/users/singhsarab","html_url":"https://github.com/singhsarab","followers_url":"https://api.github.com/users/singhsarab/followers","following_url":"https://api.github.com/users/singhsarab/following{/other_user}","gists_url":"https://api.github.com/users/singhsarab/gists{/gist_id}","starred_url":"https://api.github.com/users/singhsarab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singhsarab/subscriptions","organizations_url":"https://api.github.com/users/singhsarab/orgs","repos_url":"https://api.github.com/users/singhsarab/repos","events_url":"https://api.github.com/users/singhsarab/events{/privacy}","received_events_url":"https://api.github.com/users/singhsarab/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-04T15:55:32Z","updated_at":"2017-07-06T08:59:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44a6ad5242f1e0437e63b6e3bd5e5d1db248acec","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vstest-docs/pulls/60/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vstest-docs/pulls/60/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vstest-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vstest-docs/issues/60/comments","statuses_url":"https://api.github.com/repos/Microsoft/vstest-docs/statuses/bfb9ca3bba4f1ab0d6e739dd3b2b9c87b70b2454","head":{"label":"singhsarab:DiscoveryRFC","ref":"DiscoveryRFC","sha":"bfb9ca3bba4f1ab0d6e739dd3b2b9c87b70b2454","user":{"login":"singhsarab","id":18569990,"avatar_url":"https://avatars3.githubusercontent.com/u/18569990?v=3","gravatar_id":"","url":"https://api.github.com/users/singhsarab","html_url":"https://github.com/singhsarab","followers_url":"https://api.github.com/users/singhsarab/followers","following_url":"https://api.github.com/users/singhsarab/following{/other_user}","gists_url":"https://api.github.com/users/singhsarab/gists{/gist_id}","starred_url":"https://api.github.com/users/singhsarab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singhsarab/subscriptions","organizations_url":"https://api.github.com/users/singhsarab/orgs","repos_url":"https://api.github.com/users/singhsarab/repos","events_url":"https://api.github.com/users/singhsarab/events{/privacy}","received_events_url":"https://api.github.com/users/singhsarab/received_events","type":"User","site_admin":false},"repo":{"id":81945757,"name":"vstest-docs","full_name":"singhsarab/vstest-docs","owner":{"login":"singhsarab","id":18569990,"avatar_url":"https://avatars3.githubusercontent.com/u/18569990?v=3","gravatar_id":"","url":"https://api.github.com/users/singhsarab","html_url":"https://github.com/singhsarab","followers_url":"https://api.github.com/users/singhsarab/followers","following_url":"https://api.github.com/users/singhsarab/following{/other_user}","gists_url":"https://api.github.com/users/singhsarab/gists{/gist_id}","starred_url":"https://api.github.com/users/singhsarab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singhsarab/subscriptions","organizations_url":"https://api.github.com/users/singhsarab/orgs","repos_url":"https://api.github.com/users/singhsarab/repos","events_url":"https://api.github.com/users/singhsarab/events{/privacy}","received_events_url":"https://api.github.com/users/singhsarab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/singhsarab/vstest-docs","description":"Documentation for the Visual Studio Test Platform. ","fork":true,"url":"https://api.github.com/repos/singhsarab/vstest-docs","forks_url":"https://api.github.com/repos/singhsarab/vstest-docs/forks","keys_url":"https://api.github.com/repos/singhsarab/vstest-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/singhsarab/vstest-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/singhsarab/vstest-docs/teams","hooks_url":"https://api.github.com/repos/singhsarab/vstest-docs/hooks","issue_events_url":"https://api.github.com/repos/singhsarab/vstest-docs/issues/events{/number}","events_url":"https://api.github.com/repos/singhsarab/vstest-docs/events","assignees_url":"https://api.github.com/repos/singhsarab/vstest-docs/assignees{/user}","branches_url":"https://api.github.com/repos/singhsarab/vstest-docs/branches{/branch}","tags_url":"https://api.github.com/repos/singhsarab/vstest-docs/tags","blobs_url":"https://api.github.com/repos/singhsarab/vstest-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/singhsarab/vstest-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/singhsarab/vstest-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/singhsarab/vstest-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/singhsarab/vstest-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/singhsarab/vstest-docs/languages","stargazers_url":"https://api.github.com/repos/singhsarab/vstest-docs/stargazers","contributors_url":"https://api.github.com/repos/singhsarab/vstest-docs/contributors","subscribers_url":"https://api.github.com/repos/singhsarab/vstest-docs/subscribers","subscription_url":"https://api.github.com/repos/singhsarab/vstest-docs/subscription","commits_url":"https://api.github.com/repos/singhsarab/vstest-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/singhsarab/vstest-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/singhsarab/vstest-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/singhsarab/vstest-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/singhsarab/vstest-docs/contents/{+path}","compare_url":"https://api.github.com/repos/singhsarab/vstest-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/singhsarab/vstest-docs/merges","archive_url":"https://api.github.com/repos/singhsarab/vstest-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/singhsarab/vstest-docs/downloads","issues_url":"https://api.github.com/repos/singhsarab/vstest-docs/issues{/number}","pulls_url":"https://api.github.com/repos/singhsarab/vstest-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/singhsarab/vstest-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/singhsarab/vstest-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/singhsarab/vstest-docs/labels{/name}","releases_url":"https://api.github.com/repos/singhsarab/vstest-docs/releases{/id}","deployments_url":"https://api.github.com/repos/singhsarab/vstest-docs/deployments","created_at":"2017-02-14T13:02:29Z","updated_at":"2017-02-13T17:37:45Z","pushed_at":"2017-07-04T16:50:19Z","git_url":"git://github.com/singhsarab/vstest-docs.git","ssh_url":"[email protected]:singhsarab/vstest-docs.git","clone_url":"https://github.com/singhsarab/vstest-docs.git","svn_url":"https://github.com/singhsarab/vstest-docs","homepage":"","size":923,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"14c835c6b2cd9a116a30f9a8a140762da1f37cf6","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":62620160,"name":"vstest-docs","full_name":"Microsoft/vstest-docs","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vstest-docs","description":"Documentation for the Visual Studio Test Platform. ","fork":false,"url":"https://api.github.com/repos/Microsoft/vstest-docs","forks_url":"https://api.github.com/repos/Microsoft/vstest-docs/forks","keys_url":"https://api.github.com/repos/Microsoft/vstest-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vstest-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vstest-docs/teams","hooks_url":"https://api.github.com/repos/Microsoft/vstest-docs/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vstest-docs/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vstest-docs/events","assignees_url":"https://api.github.com/repos/Microsoft/vstest-docs/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vstest-docs/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vstest-docs/tags","blobs_url":"https://api.github.com/repos/Microsoft/vstest-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vstest-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vstest-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vstest-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vstest-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vstest-docs/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vstest-docs/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vstest-docs/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vstest-docs/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vstest-docs/subscription","commits_url":"https://api.github.com/repos/Microsoft/vstest-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vstest-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vstest-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vstest-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vstest-docs/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vstest-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vstest-docs/merges","archive_url":"https://api.github.com/repos/Microsoft/vstest-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vstest-docs/downloads","issues_url":"https://api.github.com/repos/Microsoft/vstest-docs/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vstest-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vstest-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vstest-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vstest-docs/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vstest-docs/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vstest-docs/deployments","created_at":"2016-07-05T08:40:43Z","updated_at":"2017-05-25T23:28:05Z","pushed_at":"2017-07-05T05:38:01Z","git_url":"git://github.com/Microsoft/vstest-docs.git","ssh_url":"[email protected]:Microsoft/vstest-docs.git","clone_url":"https://github.com/Microsoft/vstest-docs.git","svn_url":"https://github.com/Microsoft/vstest-docs","homepage":"","size":910,"stargazers_count":40,"watchers_count":40,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":4,"forks":18,"open_issues":4,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vstest-docs/pulls/60"},"html":{"href":"https://github.com/Microsoft/vstest-docs/pull/60"},"issue":{"href":"https://api.github.com/repos/Microsoft/vstest-docs/issues/60"},"comments":{"href":"https://api.github.com/repos/Microsoft/vstest-docs/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vstest-docs/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vstest-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vstest-docs/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vstest-docs/statuses/bfb9ca3bba4f1ab0d6e739dd3b2b9c87b70b2454"}}}} | {
"id": 62620160,
"name": "Microsoft/vstest-docs",
"url": "https://api.github.com/repos/Microsoft/vstest-docs"
} | {
"id": 18569990,
"login": "singhsarab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18569990?",
"url": "https://api.github.com/users/singhsarab"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2017-07-06T08:59:28 | 6202344620 | {"actor":{"display_login":"singhsarab"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/comments/107283211","pull_request_review_id":28243049,"id":107283211,"diff_hunk":"@@ -10621,6 +10621,73 @@ void Sema::DiagnoseSelfMove(const Expr *LHSExpr, const Expr *RHSExpr,\n << RHSExpr->getSourceRange();\n }\n \n+\n+//===--- CHECK: Checked scope -------------------------===//\n+void Sema::DiagnoseCheckedDecl(const DeclStmt *DS) {\n+ // Checked C - check consistency between compound stmt checked property\n+ // and declaration type\n+ DeclGroupRef DG = DS->getDeclGroup();\n+ for (DeclGroupRef::const_iterator D = DG.begin(), DEnd = DG.end(); D != DEnd;\n+ ++D) {\n+ if (const VarDecl *VD = dyn_cast<VarDecl>(*D)) {\n+ DiagnoseCheckedDecl(VD);\n+ }\n+ }\n+}\n+\n+// type restrictions on declaration in checked blocks\n+void Sema::DiagnoseCheckedDecl(const DeclaratorDecl *Decl) {\n+ // Checked C - check consistency between checked property and declaration\n+ // checked pointer type or unchecked pointer type with bounds-safe interface\n+ // is only allowed in checked scope or funcion\n+ const DeclaratorDecl *TargetDecl = nullptr;\n+ int DeclKind;\n+ QualType Ty;\n+ if (const ParmVarDecl *Parm = dyn_cast<ParmVarDecl>(Decl)) {\n+ TargetDecl = Parm;\n+ DeclKind = 0; // function param\n+ Ty = Parm->getType();\n+ }\n+ else if (const FunctionDecl *Func = dyn_cast<FunctionDecl>(Decl)) {\n+ TargetDecl = Func;\n+ DeclKind = 1; // function return\n+ Ty = Func->getReturnType();\n+ }\n+ else if (const VarDecl *Var = dyn_cast<VarDecl>(Decl)) {\n+ TargetDecl = Var;\n+ DeclKind = 2; // decl var\n+ Ty = Var->getType();\n+ }\n+ else if (const FieldDecl *Field = dyn_cast<FieldDecl>(Decl)) {\n+ TargetDecl = Field;\n+ DeclKind = 3; // member\n+ Ty = Field->getType();\n+ }\n+\n+ bool checkedScopeError = false;\n+ int TypeKind = 0;\n+ if (TargetDecl) {\n+ // type is unchecked pointer w/o bounds-safe interface\n+ // type is unchecked pointer & its bounds-safe interface is also unchecked\n+ QualType InterOpTy = GetCheckedCInteropType(TargetDecl);\n+ if ((Ty->isUncheckedPointerType() || Ty->isUncheckedArrayType()) &&\n+ (InterOpTy.isNull() || (InterOpTy->isUncheckedPointerType() ||\n+ InterOpTy->isUncheckedArrayType()))) {\n+ checkedScopeError = true;\n+ TypeKind =","path":"lib/Sema/SemaChecking.cpp","position":57,"original_position":57,"commit_id":"43ccad3405255d803b7c84cf705f83ac0a8d98b5","original_commit_id":"43ccad3405255d803b7c84cf705f83ac0a8d98b5","user":{"login":"dtarditi","id":11841034,"avatar_url":"https://avatars0.githubusercontent.com/u/11841034?v=3","gravatar_id":"","url":"https://api.github.com/users/dtarditi","html_url":"https://github.com/dtarditi","followers_url":"https://api.github.com/users/dtarditi/followers","following_url":"https://api.github.com/users/dtarditi/following{/other_user}","gists_url":"https://api.github.com/users/dtarditi/gists{/gist_id}","starred_url":"https://api.github.com/users/dtarditi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtarditi/subscriptions","organizations_url":"https://api.github.com/users/dtarditi/orgs","repos_url":"https://api.github.com/users/dtarditi/repos","events_url":"https://api.github.com/users/dtarditi/events{/privacy}","received_events_url":"https://api.github.com/users/dtarditi/received_events","type":"User","site_admin":false},"body":"I think this should just be:\r\n\r\nTypeKind = (Ty->isUncheckedPointerType()) ? 0 : 1\r\n","created_at":"2017-03-21T21:41:54Z","updated_at":"2017-03-21T21:42:28Z","html_url":"https://github.com/Microsoft/checkedc-clang/pull/193#discussion_r107283211","pull_request_url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/193","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/comments/107283211"},"html":{"href":"https://github.com/Microsoft/checkedc-clang/pull/193#discussion_r107283211"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/193"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/193","id":110998208,"html_url":"https://github.com/Microsoft/checkedc-clang/pull/193","diff_url":"https://github.com/Microsoft/checkedc-clang/pull/193.diff","patch_url":"https://github.com/Microsoft/checkedc-clang/pull/193.patch","issue_url":"https://api.github.com/repos/Microsoft/checkedc-clang/issues/193","number":193,"state":"open","locked":false,"title":"Add initial version of checked scope/function implementation","user":{"login":"wonsubkim","id":25519089,"avatar_url":"https://avatars2.githubusercontent.com/u/25519089?v=3","gravatar_id":"","url":"https://api.github.com/users/wonsubkim","html_url":"https://github.com/wonsubkim","followers_url":"https://api.github.com/users/wonsubkim/followers","following_url":"https://api.github.com/users/wonsubkim/following{/other_user}","gists_url":"https://api.github.com/users/wonsubkim/gists{/gist_id}","starred_url":"https://api.github.com/users/wonsubkim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wonsubkim/subscriptions","organizations_url":"https://api.github.com/users/wonsubkim/orgs","repos_url":"https://api.github.com/users/wonsubkim/repos","events_url":"https://api.github.com/users/wonsubkim/events{/privacy}","received_events_url":"https://api.github.com/users/wonsubkim/received_events","type":"User","site_admin":false},"body":"Implemented checked scope/function\r\nchecked function\r\n - checked keyword is before function definition\r\n - checked keyword is regarded as function specifier in implementation\r\n - checked function specifier affects function declaration scope & function definition scope\r\n - in function declaration, it checks if function parameter type & return type is proper for checked scope\r\n - in function definition, it checks if function definition statement body is regarded as checked compound scope\r\n\r\nchecked scope\r\n - checked keyword is before l_brace\r\n - this compound statment is regarded as checked block\r\n - in checked compound statments, all declaration can have checked pointer type or unchecked pointer type with bounds-safe interface\r\n - otherwise, compiler emits compilation error\r\n\r\nAlso relative alignment bug fix is added in this pull request","created_at":"2017-03-16T05:54:21Z","updated_at":"2017-03-21T21:42:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e4159d098a48364c589f0de559dbf47e4fe801f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/193/commits","review_comments_url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/193/comments","review_comment_url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/checkedc-clang/issues/193/comments","statuses_url":"https://api.github.com/repos/Microsoft/checkedc-clang/statuses/43ccad3405255d803b7c84cf705f83ac0a8d98b5","head":{"label":"wonsubkim:issue-189","ref":"issue-189","sha":"43ccad3405255d803b7c84cf705f83ac0a8d98b5","user":{"login":"wonsubkim","id":25519089,"avatar_url":"https://avatars2.githubusercontent.com/u/25519089?v=3","gravatar_id":"","url":"https://api.github.com/users/wonsubkim","html_url":"https://github.com/wonsubkim","followers_url":"https://api.github.com/users/wonsubkim/followers","following_url":"https://api.github.com/users/wonsubkim/following{/other_user}","gists_url":"https://api.github.com/users/wonsubkim/gists{/gist_id}","starred_url":"https://api.github.com/users/wonsubkim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wonsubkim/subscriptions","organizations_url":"https://api.github.com/users/wonsubkim/orgs","repos_url":"https://api.github.com/users/wonsubkim/repos","events_url":"https://api.github.com/users/wonsubkim/events{/privacy}","received_events_url":"https://api.github.com/users/wonsubkim/received_events","type":"User","site_admin":false},"repo":{"id":80797887,"name":"checkedc-clang","full_name":"wonsubkim/checkedc-clang","owner":{"login":"wonsubkim","id":25519089,"avatar_url":"https://avatars2.githubusercontent.com/u/25519089?v=3","gravatar_id":"","url":"https://api.github.com/users/wonsubkim","html_url":"https://github.com/wonsubkim","followers_url":"https://api.github.com/users/wonsubkim/followers","following_url":"https://api.github.com/users/wonsubkim/following{/other_user}","gists_url":"https://api.github.com/users/wonsubkim/gists{/gist_id}","starred_url":"https://api.github.com/users/wonsubkim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wonsubkim/subscriptions","organizations_url":"https://api.github.com/users/wonsubkim/orgs","repos_url":"https://api.github.com/users/wonsubkim/repos","events_url":"https://api.github.com/users/wonsubkim/events{/privacy}","received_events_url":"https://api.github.com/users/wonsubkim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wonsubkim/checkedc-clang","description":"This repo contains a version of clang that is being modified to support Checked C. Checked C is an extension to C that adds checking to detect or prevent common programming errors such as out-of-bounds memory accesses.","fork":true,"url":"https://api.github.com/repos/wonsubkim/checkedc-clang","forks_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/forks","keys_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/teams","hooks_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/hooks","issue_events_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/issues/events{/number}","events_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/events","assignees_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/assignees{/user}","branches_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/branches{/branch}","tags_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/tags","blobs_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/git/refs{/sha}","trees_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/statuses/{sha}","languages_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/languages","stargazers_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/stargazers","contributors_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/contributors","subscribers_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/subscribers","subscription_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/subscription","commits_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/commits{/sha}","git_commits_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/git/commits{/sha}","comments_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/comments{/number}","issue_comment_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/issues/comments{/number}","contents_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/contents/{+path}","compare_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/merges","archive_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/downloads","issues_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/issues{/number}","pulls_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/pulls{/number}","milestones_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/milestones{/number}","notifications_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/labels{/name}","releases_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/releases{/id}","deployments_url":"https://api.github.com/repos/wonsubkim/checkedc-clang/deployments","created_at":"2017-02-03T04:47:46Z","updated_at":"2017-02-03T04:48:13Z","pushed_at":"2017-03-21T09:46:49Z","git_url":"git://github.com/wonsubkim/checkedc-clang.git","ssh_url":"[email protected]:wonsubkim/checkedc-clang.git","clone_url":"https://github.com/wonsubkim/checkedc-clang.git","svn_url":"https://github.com/wonsubkim/checkedc-clang","homepage":"","size":272229,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"be76e36f61d516c27622fb9153b66470e4d25cc9","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":60645050,"name":"checkedc-clang","full_name":"Microsoft/checkedc-clang","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/checkedc-clang","description":"This repo contains a version of clang that is being modified to support Checked C. Checked C is an extension to C that adds checking to detect or prevent common programming errors such as out-of-bounds memory accesses.","fork":false,"url":"https://api.github.com/repos/Microsoft/checkedc-clang","forks_url":"https://api.github.com/repos/Microsoft/checkedc-clang/forks","keys_url":"https://api.github.com/repos/Microsoft/checkedc-clang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/checkedc-clang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/checkedc-clang/teams","hooks_url":"https://api.github.com/repos/Microsoft/checkedc-clang/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/checkedc-clang/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/checkedc-clang/events","assignees_url":"https://api.github.com/repos/Microsoft/checkedc-clang/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/checkedc-clang/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/checkedc-clang/tags","blobs_url":"https://api.github.com/repos/Microsoft/checkedc-clang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/checkedc-clang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/checkedc-clang/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/checkedc-clang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/checkedc-clang/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/checkedc-clang/languages","stargazers_url":"https://api.github.com/repos/Microsoft/checkedc-clang/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/checkedc-clang/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/checkedc-clang/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/checkedc-clang/subscription","commits_url":"https://api.github.com/repos/Microsoft/checkedc-clang/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/checkedc-clang/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/checkedc-clang/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/checkedc-clang/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/checkedc-clang/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/checkedc-clang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/checkedc-clang/merges","archive_url":"https://api.github.com/repos/Microsoft/checkedc-clang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/checkedc-clang/downloads","issues_url":"https://api.github.com/repos/Microsoft/checkedc-clang/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/checkedc-clang/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/checkedc-clang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/checkedc-clang/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/checkedc-clang/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/checkedc-clang/deployments","created_at":"2016-06-07T20:43:32Z","updated_at":"2017-03-21T14:44:03Z","pushed_at":"2017-03-21T17:24:19Z","git_url":"git://github.com/Microsoft/checkedc-clang.git","ssh_url":"[email protected]:Microsoft/checkedc-clang.git","clone_url":"https://github.com/Microsoft/checkedc-clang.git","svn_url":"https://github.com/Microsoft/checkedc-clang","homepage":"","size":271920,"stargazers_count":116,"watchers_count":116,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":61,"forks":16,"open_issues":61,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/193"},"html":{"href":"https://github.com/Microsoft/checkedc-clang/pull/193"},"issue":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/issues/193"},"comments":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/statuses/43ccad3405255d803b7c84cf705f83ac0a8d98b5"}}}} | {
"id": 60645050,
"name": "Microsoft/checkedc-clang",
"url": "https://api.github.com/repos/Microsoft/checkedc-clang"
} | {
"id": 11841034,
"login": "dtarditi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11841034?",
"url": "https://api.github.com/users/dtarditi"
} | {
"id": 6154722,
"login": "Microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6154722?",
"url": "https://api.github.com/orgs/Microsoft"
} | 2017-03-21T21:41:54 | 5537290492 | {"actor":{"display_login":"dtarditi"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/pulls/comments/148177255","pull_request_review_id":73378785,"id":148177255,"diff_hunk":"@@ -70,183 +71,99 @@ def parse(self, utterance):\n return None\n \n \n-class WAApi(Api):\n- def __init__(self):\n- super(WAApi, self).__init__(\"wa\")\n-\n- def get_data(self, response):\n- return response\n-\n- def query(self, input):\n- data = self.request({\"query\": {\"input\": input}})\n- return wolframalpha.Result(StringIO(data.content))\n-\n-\n class WolframAlphaSkill(FallbackSkill):\n- PIDS = ['Value', 'NotableFacts:PeopleData', 'BasicInformation:PeopleData',\n- 'Definition', 'DecimalApproximation']\n \n def __init__(self):\n FallbackSkill.__init__(self, name=\"WolframAlphaSkill\")\n- self.__init_client()\n- self.question_parser = EnglishQuestionParser()\n \n- def __init_client(self):\n- key = self.config.get('api_key')\n- if key and not self.config.get('proxy'):\n- self.client = wolframalpha.Client(key)\n- else:\n- self.client = WAApi()\n+ # Support 'api_key' in the old mycroft.conf location\n+ self.api_key = self.config.get('api_key')\n+\n+ # TODO: Localization support for questions in other languages\n+ self.question_parser = EnglishQuestionParser()\n \n def initialize(self):\n- self.init_dialog(dirname(__file__))\n self.register_fallback(self.handle_fallback, 8)\n \n- def get_result(self, res):\n- try:\n- return next(res.results).text\n- except:\n- result = None\n- try:\n- for pid in self.PIDS:\n- result = self.__find_pod_id(res.pods, pid)\n- if result:\n- result = result[:5]\n- break\n- if not result:\n- result = self.__find_num(res.pods, '200')\n- return result\n- except:\n- return result\n-\n- # TODO: Localization\n def handle_fallback(self, message):\n+ if not self.api_key:\n+ # attempt to get from webUI\n+ self.api_key = self.settings.get('api_key', None)\n+ if not self.api_key:\n+ # still not found, prompt user to get a key\n+ self.speak_dialog(\"need.api.key\")\n+ return","path":"__init__.py","position":144,"original_position":144,"commit_id":"4a499e5c08ae210e5702d4681fa5447ba449cd48","original_commit_id":"4a499e5c08ae210e5702d4681fa5447ba449cd48","user":{"login":"MatthewScholefield","id":5875019,"avatar_url":"https://avatars0.githubusercontent.com/u/5875019?v=4","gravatar_id":"","url":"https://api.github.com/users/MatthewScholefield","html_url":"https://github.com/MatthewScholefield","followers_url":"https://api.github.com/users/MatthewScholefield/followers","following_url":"https://api.github.com/users/MatthewScholefield/following{/other_user}","gists_url":"https://api.github.com/users/MatthewScholefield/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewScholefield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewScholefield/subscriptions","organizations_url":"https://api.github.com/users/MatthewScholefield/orgs","repos_url":"https://api.github.com/users/MatthewScholefield/repos","events_url":"https://api.github.com/users/MatthewScholefield/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewScholefield/received_events","type":"User","site_admin":false},"body":"This should return `True` to consume the message. Otherwise, an extra `Sorry, I didn't catch that` is spoken.","created_at":"2017-11-01T03:47:00Z","updated_at":"2017-11-01T03:47:00Z","html_url":"https://github.com/MycroftAI/fallback-wolfram-alpha/pull/3#discussion_r148177255","pull_request_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/pulls/3","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/pulls/comments/148177255"},"html":{"href":"https://github.com/MycroftAI/fallback-wolfram-alpha/pull/3#discussion_r148177255"},"pull_request":{"href":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/pulls/3","id":149071590,"html_url":"https://github.com/MycroftAI/fallback-wolfram-alpha/pull/3","diff_url":"https://github.com/MycroftAI/fallback-wolfram-alpha/pull/3.diff","patch_url":"https://github.com/MycroftAI/fallback-wolfram-alpha/pull/3.patch","issue_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/issues/3","number":3,"state":"open","locked":false,"title":"WolframAlpha rework","user":{"login":"penrods","id":16079445,"avatar_url":"https://avatars3.githubusercontent.com/u/16079445?v=4","gravatar_id":"","url":"https://api.github.com/users/penrods","html_url":"https://github.com/penrods","followers_url":"https://api.github.com/users/penrods/followers","following_url":"https://api.github.com/users/penrods/following{/other_user}","gists_url":"https://api.github.com/users/penrods/gists{/gist_id}","starred_url":"https://api.github.com/users/penrods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penrods/subscriptions","organizations_url":"https://api.github.com/users/penrods/orgs","repos_url":"https://api.github.com/users/penrods/repos","events_url":"https://api.github.com/users/penrods/events{/privacy}","received_events_url":"https://api.github.com/users/penrods/received_events","type":"User","site_admin":false},"body":"Several changes to start this rework:\r\n* For some reason the 'wolframalpha' module was generating an SSL error on some queries (just different query strings). Eliminating that usage and calling the simple Wolfram Alpha API directly.\r\n* Removed the attempt to read back the question. It was awkward at best and unnecessary -- just give me the answer!\r\n* A personal AppID can now be entered in the webUI. Visit home.mycroft.ai to enter the value. A personal key entered in mycroft.conf will still work, but this is deprecated.","created_at":"2017-10-26T23:46:57Z","updated_at":"2017-11-01T03:47:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69640415d8fb930e58c9ccdea2c64d76803aa8c9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/pulls/3/commits","review_comments_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/pulls/3/comments","review_comment_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/issues/3/comments","statuses_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/statuses/4a499e5c08ae210e5702d4681fa5447ba449cd48","head":{"label":"MycroftAI:feature/rework","ref":"feature/rework","sha":"4a499e5c08ae210e5702d4681fa5447ba449cd48","user":{"login":"MycroftAI","id":14171097,"avatar_url":"https://avatars0.githubusercontent.com/u/14171097?v=4","gravatar_id":"","url":"https://api.github.com/users/MycroftAI","html_url":"https://github.com/MycroftAI","followers_url":"https://api.github.com/users/MycroftAI/followers","following_url":"https://api.github.com/users/MycroftAI/following{/other_user}","gists_url":"https://api.github.com/users/MycroftAI/gists{/gist_id}","starred_url":"https://api.github.com/users/MycroftAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MycroftAI/subscriptions","organizations_url":"https://api.github.com/users/MycroftAI/orgs","repos_url":"https://api.github.com/users/MycroftAI/repos","events_url":"https://api.github.com/users/MycroftAI/events{/privacy}","received_events_url":"https://api.github.com/users/MycroftAI/received_events","type":"Organization","site_admin":false},"repo":{"id":99016668,"name":"fallback-wolfram-alpha","full_name":"MycroftAI/fallback-wolfram-alpha","owner":{"login":"MycroftAI","id":14171097,"avatar_url":"https://avatars0.githubusercontent.com/u/14171097?v=4","gravatar_id":"","url":"https://api.github.com/users/MycroftAI","html_url":"https://github.com/MycroftAI","followers_url":"https://api.github.com/users/MycroftAI/followers","following_url":"https://api.github.com/users/MycroftAI/following{/other_user}","gists_url":"https://api.github.com/users/MycroftAI/gists{/gist_id}","starred_url":"https://api.github.com/users/MycroftAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MycroftAI/subscriptions","organizations_url":"https://api.github.com/users/MycroftAI/orgs","repos_url":"https://api.github.com/users/MycroftAI/repos","events_url":"https://api.github.com/users/MycroftAI/events{/privacy}","received_events_url":"https://api.github.com/users/MycroftAI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MycroftAI/fallback-wolfram-alpha","description":"Wolfram Alpha Skill for Mycroft","fork":false,"url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha","forks_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/forks","keys_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/teams","hooks_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/hooks","issue_events_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/issues/events{/number}","events_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/events","assignees_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/assignees{/user}","branches_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/branches{/branch}","tags_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/tags","blobs_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/git/refs{/sha}","trees_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/statuses/{sha}","languages_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/languages","stargazers_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/stargazers","contributors_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/contributors","subscribers_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/subscribers","subscription_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/subscription","commits_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/commits{/sha}","git_commits_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/git/commits{/sha}","comments_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/comments{/number}","issue_comment_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/issues/comments{/number}","contents_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/contents/{+path}","compare_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/merges","archive_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/downloads","issues_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/issues{/number}","pulls_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/pulls{/number}","milestones_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/milestones{/number}","notifications_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/labels{/name}","releases_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/releases{/id}","deployments_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/deployments","created_at":"2017-08-01T15:33:43Z","updated_at":"2017-08-01T16:02:27Z","pushed_at":"2017-11-01T01:54:08Z","git_url":"git://github.com/MycroftAI/fallback-wolfram-alpha.git","ssh_url":"[email protected]:MycroftAI/fallback-wolfram-alpha.git","clone_url":"https://github.com/MycroftAI/fallback-wolfram-alpha.git","svn_url":"https://github.com/MycroftAI/fallback-wolfram-alpha","homepage":null,"size":16,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"MycroftAI:master","ref":"master","sha":"4f34bad2d648277908a6864d9fb16e9101c1e2b2","user":{"login":"MycroftAI","id":14171097,"avatar_url":"https://avatars0.githubusercontent.com/u/14171097?v=4","gravatar_id":"","url":"https://api.github.com/users/MycroftAI","html_url":"https://github.com/MycroftAI","followers_url":"https://api.github.com/users/MycroftAI/followers","following_url":"https://api.github.com/users/MycroftAI/following{/other_user}","gists_url":"https://api.github.com/users/MycroftAI/gists{/gist_id}","starred_url":"https://api.github.com/users/MycroftAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MycroftAI/subscriptions","organizations_url":"https://api.github.com/users/MycroftAI/orgs","repos_url":"https://api.github.com/users/MycroftAI/repos","events_url":"https://api.github.com/users/MycroftAI/events{/privacy}","received_events_url":"https://api.github.com/users/MycroftAI/received_events","type":"Organization","site_admin":false},"repo":{"id":99016668,"name":"fallback-wolfram-alpha","full_name":"MycroftAI/fallback-wolfram-alpha","owner":{"login":"MycroftAI","id":14171097,"avatar_url":"https://avatars0.githubusercontent.com/u/14171097?v=4","gravatar_id":"","url":"https://api.github.com/users/MycroftAI","html_url":"https://github.com/MycroftAI","followers_url":"https://api.github.com/users/MycroftAI/followers","following_url":"https://api.github.com/users/MycroftAI/following{/other_user}","gists_url":"https://api.github.com/users/MycroftAI/gists{/gist_id}","starred_url":"https://api.github.com/users/MycroftAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MycroftAI/subscriptions","organizations_url":"https://api.github.com/users/MycroftAI/orgs","repos_url":"https://api.github.com/users/MycroftAI/repos","events_url":"https://api.github.com/users/MycroftAI/events{/privacy}","received_events_url":"https://api.github.com/users/MycroftAI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MycroftAI/fallback-wolfram-alpha","description":"Wolfram Alpha Skill for Mycroft","fork":false,"url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha","forks_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/forks","keys_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/teams","hooks_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/hooks","issue_events_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/issues/events{/number}","events_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/events","assignees_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/assignees{/user}","branches_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/branches{/branch}","tags_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/tags","blobs_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/git/refs{/sha}","trees_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/statuses/{sha}","languages_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/languages","stargazers_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/stargazers","contributors_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/contributors","subscribers_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/subscribers","subscription_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/subscription","commits_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/commits{/sha}","git_commits_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/git/commits{/sha}","comments_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/comments{/number}","issue_comment_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/issues/comments{/number}","contents_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/contents/{+path}","compare_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/merges","archive_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/downloads","issues_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/issues{/number}","pulls_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/pulls{/number}","milestones_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/milestones{/number}","notifications_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/labels{/name}","releases_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/releases{/id}","deployments_url":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/deployments","created_at":"2017-08-01T15:33:43Z","updated_at":"2017-08-01T16:02:27Z","pushed_at":"2017-11-01T01:54:08Z","git_url":"git://github.com/MycroftAI/fallback-wolfram-alpha.git","ssh_url":"[email protected]:MycroftAI/fallback-wolfram-alpha.git","clone_url":"https://github.com/MycroftAI/fallback-wolfram-alpha.git","svn_url":"https://github.com/MycroftAI/fallback-wolfram-alpha","homepage":null,"size":16,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/pulls/3"},"html":{"href":"https://github.com/MycroftAI/fallback-wolfram-alpha/pull/3"},"issue":{"href":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/issues/3"},"comments":{"href":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha/statuses/4a499e5c08ae210e5702d4681fa5447ba449cd48"}},"author_association":"OWNER"}} | {
"id": 99016668,
"name": "MycroftAI/fallback-wolfram-alpha",
"url": "https://api.github.com/repos/MycroftAI/fallback-wolfram-alpha"
} | {
"id": 5875019,
"login": "MatthewScholefield",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5875019?",
"url": "https://api.github.com/users/MatthewScholefield"
} | {
"id": 14171097,
"login": "MycroftAI",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14171097?",
"url": "https://api.github.com/orgs/MycroftAI"
} | 2017-11-01T03:47:00 | 6792922288 | {"actor":{"display_login":"MatthewScholefield"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/94841419","pull_request_review_id":15381675,"id":94841419,"diff_hunk":"@@ -42,6 +41,11 @@\n &:active {\n color: $ms-color-themePrimary;\n }\n+\n+ &:focus {","path":"packages/office-ui-fabric-react/src/components/Link/Link.scss","position":null,"original_position":13,"commit_id":"f4eeadb277572a26242603dddfb26fed40f31740","original_commit_id":"72b0b11aaea8cdd61630fcb8d879efd5935c9afa","user":{"login":"mikewheaton","id":1382445,"avatar_url":"https://avatars.githubusercontent.com/u/1382445?v=3","gravatar_id":"","url":"https://api.github.com/users/mikewheaton","html_url":"https://github.com/mikewheaton","followers_url":"https://api.github.com/users/mikewheaton/followers","following_url":"https://api.github.com/users/mikewheaton/following{/other_user}","gists_url":"https://api.github.com/users/mikewheaton/gists{/gist_id}","starred_url":"https://api.github.com/users/mikewheaton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikewheaton/subscriptions","organizations_url":"https://api.github.com/users/mikewheaton/orgs","repos_url":"https://api.github.com/users/mikewheaton/repos","events_url":"https://api.github.com/users/mikewheaton/events{/privacy}","received_events_url":"https://api.github.com/users/mikewheaton/received_events","type":"User","site_admin":false},"body":"Done. I've split out several styles like this that only need to apply to buttons or anchors, not both.","created_at":"2017-01-05T20:06:49Z","updated_at":"2017-01-05T20:06:49Z","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/741#discussion_r94841419","pull_request_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/741","_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/94841419"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/741#discussion_r94841419"},"pull_request":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/741"}}},"pull_request":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/741","id":100219501,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/741","diff_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/741.diff","patch_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/741.patch","issue_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/741","number":741,"state":"open","locked":false,"title":"Link: Fix focus border positioning","user":{"login":"mikewheaton","id":1382445,"avatar_url":"https://avatars.githubusercontent.com/u/1382445?v=3","gravatar_id":"","url":"https://api.github.com/users/mikewheaton","html_url":"https://github.com/mikewheaton","followers_url":"https://api.github.com/users/mikewheaton/followers","following_url":"https://api.github.com/users/mikewheaton/following{/other_user}","gists_url":"https://api.github.com/users/mikewheaton/gists{/gist_id}","starred_url":"https://api.github.com/users/mikewheaton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikewheaton/subscriptions","organizations_url":"https://api.github.com/users/mikewheaton/orgs","repos_url":"https://api.github.com/users/mikewheaton/repos","events_url":"https://api.github.com/users/mikewheaton/events{/privacy}","received_events_url":"https://api.github.com/users/mikewheaton/received_events","type":"User","site_admin":false},"body":"#### Pull request checklist\r\n\r\n- [x] Addresses an existing issue: #688\r\n- [x] Include a change request file if publishing <!-- see notes below -->\r\n- [x] New feature, bugfix, or enhancement\r\n- [x] Documentation update\r\n\r\n#### Description of changes\r\n\r\nInstead of using the `focus-border()` mixin, this PR adds custom `:focus` styles to the link component. By using the browser's default `outline` property we can have outlines that wrap multiple lines. Also updated the documentation to more clearly indicate how the specified props relate to the element rendered.\r\n\r\nBefore:\r\n\r\n\r\nAfter:\r\n\r\n\r\n#### Focus areas to test\r\n\r\nLinks with an `href` prop (rendered as an anchor tag) that span multiple lines.","created_at":"2017-01-05T01:24:14Z","updated_at":"2017-01-05T20:06:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efa8fa6de0cb60effe78aed73e0ca3616901d2fb","assignee":{"login":"dzearing","id":1110944,"avatar_url":"https://avatars.githubusercontent.com/u/1110944?v=3","gravatar_id":"","url":"https://api.github.com/users/dzearing","html_url":"https://github.com/dzearing","followers_url":"https://api.github.com/users/dzearing/followers","following_url":"https://api.github.com/users/dzearing/following{/other_user}","gists_url":"https://api.github.com/users/dzearing/gists{/gist_id}","starred_url":"https://api.github.com/users/dzearing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzearing/subscriptions","organizations_url":"https://api.github.com/users/dzearing/orgs","repos_url":"https://api.github.com/users/dzearing/repos","events_url":"https://api.github.com/users/dzearing/events{/privacy}","received_events_url":"https://api.github.com/users/dzearing/received_events","type":"User","site_admin":false},"assignees":[{"login":"dzearing","id":1110944,"avatar_url":"https://avatars.githubusercontent.com/u/1110944?v=3","gravatar_id":"","url":"https://api.github.com/users/dzearing","html_url":"https://github.com/dzearing","followers_url":"https://api.github.com/users/dzearing/followers","following_url":"https://api.github.com/users/dzearing/following{/other_user}","gists_url":"https://api.github.com/users/dzearing/gists{/gist_id}","starred_url":"https://api.github.com/users/dzearing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzearing/subscriptions","organizations_url":"https://api.github.com/users/dzearing/orgs","repos_url":"https://api.github.com/users/dzearing/repos","events_url":"https://api.github.com/users/dzearing/events{/privacy}","received_events_url":"https://api.github.com/users/dzearing/received_events","type":"User","site_admin":false},{"login":"joschect","id":20801176,"avatar_url":"https://avatars.githubusercontent.com/u/20801176?v=3","gravatar_id":"","url":"https://api.github.com/users/joschect","html_url":"https://github.com/joschect","followers_url":"https://api.github.com/users/joschect/followers","following_url":"https://api.github.com/users/joschect/following{/other_user}","gists_url":"https://api.github.com/users/joschect/gists{/gist_id}","starred_url":"https://api.github.com/users/joschect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joschect/subscriptions","organizations_url":"https://api.github.com/users/joschect/orgs","repos_url":"https://api.github.com/users/joschect/repos","events_url":"https://api.github.com/users/joschect/events{/privacy}","received_events_url":"https://api.github.com/users/joschect/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/741/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/741/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/741/comments","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/f4eeadb277572a26242603dddfb26fed40f31740","head":{"label":"mikewheaton:miwhea/link-focus-border","ref":"miwhea/link-focus-border","sha":"f4eeadb277572a26242603dddfb26fed40f31740","user":{"login":"mikewheaton","id":1382445,"avatar_url":"https://avatars.githubusercontent.com/u/1382445?v=3","gravatar_id":"","url":"https://api.github.com/users/mikewheaton","html_url":"https://github.com/mikewheaton","followers_url":"https://api.github.com/users/mikewheaton/followers","following_url":"https://api.github.com/users/mikewheaton/following{/other_user}","gists_url":"https://api.github.com/users/mikewheaton/gists{/gist_id}","starred_url":"https://api.github.com/users/mikewheaton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikewheaton/subscriptions","organizations_url":"https://api.github.com/users/mikewheaton/orgs","repos_url":"https://api.github.com/users/mikewheaton/repos","events_url":"https://api.github.com/users/mikewheaton/events{/privacy}","received_events_url":"https://api.github.com/users/mikewheaton/received_events","type":"User","site_admin":false},"repo":{"id":65421901,"name":"office-ui-fabric-react","full_name":"mikewheaton/office-ui-fabric-react","owner":{"login":"mikewheaton","id":1382445,"avatar_url":"https://avatars.githubusercontent.com/u/1382445?v=3","gravatar_id":"","url":"https://api.github.com/users/mikewheaton","html_url":"https://github.com/mikewheaton","followers_url":"https://api.github.com/users/mikewheaton/followers","following_url":"https://api.github.com/users/mikewheaton/following{/other_user}","gists_url":"https://api.github.com/users/mikewheaton/gists{/gist_id}","starred_url":"https://api.github.com/users/mikewheaton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikewheaton/subscriptions","organizations_url":"https://api.github.com/users/mikewheaton/orgs","repos_url":"https://api.github.com/users/mikewheaton/repos","events_url":"https://api.github.com/users/mikewheaton/events{/privacy}","received_events_url":"https://api.github.com/users/mikewheaton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikewheaton/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":true,"url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react","forks_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/mikewheaton/office-ui-fabric-react/deployments","created_at":"2016-08-10T22:58:58Z","updated_at":"2016-08-10T22:59:00Z","pushed_at":"2017-01-05T20:05:24Z","git_url":"git://github.com/mikewheaton/office-ui-fabric-react.git","ssh_url":"[email protected]:mikewheaton/office-ui-fabric-react.git","clone_url":"https://github.com/mikewheaton/office-ui-fabric-react.git","svn_url":"https://github.com/mikewheaton/office-ui-fabric-react","homepage":"http://dev.office.com/fabric","size":3236,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OfficeDev:master","ref":"master","sha":"b4611e8c555142c0647efa8dc14ba744f2a3775a","user":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars.githubusercontent.com/u/6789362?v=3","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":60537144,"name":"office-ui-fabric-react","full_name":"OfficeDev/office-ui-fabric-react","owner":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars.githubusercontent.com/u/6789362?v=3","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":false,"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react","forks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/deployments","created_at":"2016-06-06T15:03:44Z","updated_at":"2017-01-05T11:40:36Z","pushed_at":"2017-01-05T20:05:25Z","git_url":"git://github.com/OfficeDev/office-ui-fabric-react.git","ssh_url":"[email protected]:OfficeDev/office-ui-fabric-react.git","clone_url":"https://github.com/OfficeDev/office-ui-fabric-react.git","svn_url":"https://github.com/OfficeDev/office-ui-fabric-react","homepage":"http://dev.office.com/fabric#/components","size":3264,"stargazers_count":815,"watchers_count":815,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":105,"mirror_url":null,"open_issues_count":73,"forks":105,"open_issues":73,"watchers":815,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/741"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/741"},"issue":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/741"},"comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/741/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/741/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/741/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/f4eeadb277572a26242603dddfb26fed40f31740"}}}} | {
"id": 60537144,
"name": "OfficeDev/office-ui-fabric-react",
"url": "https://api.github.com/repos/OfficeDev/office-ui-fabric-react"
} | {
"id": 1382445,
"login": "mikewheaton",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1382445?",
"url": "https://api.github.com/users/mikewheaton"
} | {
"id": 6789362,
"login": "OfficeDev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6789362?",
"url": "https://api.github.com/orgs/OfficeDev"
} | 2017-01-05T20:06:49 | 5109219050 | {"actor":{"display_login":"mikewheaton"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/118558032","pull_request_review_id":40362118,"id":118558032,"diff_hunk":"@@ -6,6 +6,8 @@ import {\n import { IResizeGroupProps } from './ResizeGroup.Props';\n import styles = require('./ResizeGroup.scss');\n \n+const RESIZE_DELAY = 16;","path":"packages/office-ui-fabric-react/src/components/ResizeGroup/ResizeGroup.tsx","position":4,"original_position":4,"commit_id":"12bcc2421442c34f5b045175f329251d45311d55","original_commit_id":"d6ce23aad061ac48e743330bbd8497b4393063d7","user":{"login":"christiango","id":1581488,"avatar_url":"https://avatars1.githubusercontent.com/u/1581488?v=3","gravatar_id":"","url":"https://api.github.com/users/christiango","html_url":"https://github.com/christiango","followers_url":"https://api.github.com/users/christiango/followers","following_url":"https://api.github.com/users/christiango/following{/other_user}","gists_url":"https://api.github.com/users/christiango/gists{/gist_id}","starred_url":"https://api.github.com/users/christiango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christiango/subscriptions","organizations_url":"https://api.github.com/users/christiango/orgs","repos_url":"https://api.github.com/users/christiango/repos","events_url":"https://api.github.com/users/christiango/events{/privacy}","received_events_url":"https://api.github.com/users/christiango/received_events","type":"User","site_admin":false},"body":"100ms is pretty noticeable, the top gif is 100ms, as you can see it doesn't keep up with the user resizing the window. \r\n\r\n\r\n\r\n","created_at":"2017-05-25T18:53:06Z","updated_at":"2017-05-25T18:53:06Z","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/1864#discussion_r118558032","pull_request_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/1864","_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/118558032"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/1864#discussion_r118558032"},"pull_request":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/1864"}}},"pull_request":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/1864","id":122490283,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/1864","diff_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/1864.diff","patch_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/1864.patch","issue_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/1864","number":1864,"state":"open","locked":false,"title":"ResizeGroup: Debounce window resize events to improve performance","user":{"login":"christiango","id":1581488,"avatar_url":"https://avatars1.githubusercontent.com/u/1581488?v=3","gravatar_id":"","url":"https://api.github.com/users/christiango","html_url":"https://github.com/christiango","followers_url":"https://api.github.com/users/christiango/followers","following_url":"https://api.github.com/users/christiango/following{/other_user}","gists_url":"https://api.github.com/users/christiango/gists{/gist_id}","starred_url":"https://api.github.com/users/christiango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christiango/subscriptions","organizations_url":"https://api.github.com/users/christiango/orgs","repos_url":"https://api.github.com/users/christiango/repos","events_url":"https://api.github.com/users/christiango/events{/privacy}","received_events_url":"https://api.github.com/users/christiango/received_events","type":"User","site_admin":false},"body":"#### Pull request checklist\r\n\r\n- [ ] Addresses an existing issue: Fixes #0000\r\n- [x] Include a change request file using `$ npm run change`\r\n\r\n#### Description of changes\r\nDebounce window resize events for ResizeGroup to improve performance when resizing the window. Testing on a windows machine and using the keyboard to resize a Chrome window shows that this reduces the calls to set state by ~20% when setting the debouncing timeout to 16ms. \r\n","created_at":"2017-05-25T17:50:32Z","updated_at":"2017-05-25T18:53:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20960cf47d35acf6fab59d2ab9f698446533e84b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"micahgodbolt","id":1434956,"avatar_url":"https://avatars1.githubusercontent.com/u/1434956?v=3","gravatar_id":"","url":"https://api.github.com/users/micahgodbolt","html_url":"https://github.com/micahgodbolt","followers_url":"https://api.github.com/users/micahgodbolt/followers","following_url":"https://api.github.com/users/micahgodbolt/following{/other_user}","gists_url":"https://api.github.com/users/micahgodbolt/gists{/gist_id}","starred_url":"https://api.github.com/users/micahgodbolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micahgodbolt/subscriptions","organizations_url":"https://api.github.com/users/micahgodbolt/orgs","repos_url":"https://api.github.com/users/micahgodbolt/repos","events_url":"https://api.github.com/users/micahgodbolt/events{/privacy}","received_events_url":"https://api.github.com/users/micahgodbolt/received_events","type":"User","site_admin":false},{"login":"jair-cazarin","id":13274263,"avatar_url":"https://avatars3.githubusercontent.com/u/13274263?v=3","gravatar_id":"","url":"https://api.github.com/users/jair-cazarin","html_url":"https://github.com/jair-cazarin","followers_url":"https://api.github.com/users/jair-cazarin/followers","following_url":"https://api.github.com/users/jair-cazarin/following{/other_user}","gists_url":"https://api.github.com/users/jair-cazarin/gists{/gist_id}","starred_url":"https://api.github.com/users/jair-cazarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jair-cazarin/subscriptions","organizations_url":"https://api.github.com/users/jair-cazarin/orgs","repos_url":"https://api.github.com/users/jair-cazarin/repos","events_url":"https://api.github.com/users/jair-cazarin/events{/privacy}","received_events_url":"https://api.github.com/users/jair-cazarin/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/1864/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/1864/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/1864/comments","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/12bcc2421442c34f5b045175f329251d45311d55","head":{"label":"christiango:resizegroup-debounce","ref":"resizegroup-debounce","sha":"12bcc2421442c34f5b045175f329251d45311d55","user":{"login":"christiango","id":1581488,"avatar_url":"https://avatars1.githubusercontent.com/u/1581488?v=3","gravatar_id":"","url":"https://api.github.com/users/christiango","html_url":"https://github.com/christiango","followers_url":"https://api.github.com/users/christiango/followers","following_url":"https://api.github.com/users/christiango/following{/other_user}","gists_url":"https://api.github.com/users/christiango/gists{/gist_id}","starred_url":"https://api.github.com/users/christiango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christiango/subscriptions","organizations_url":"https://api.github.com/users/christiango/orgs","repos_url":"https://api.github.com/users/christiango/repos","events_url":"https://api.github.com/users/christiango/events{/privacy}","received_events_url":"https://api.github.com/users/christiango/received_events","type":"User","site_admin":false},"repo":{"id":84107423,"name":"office-ui-fabric-react","full_name":"christiango/office-ui-fabric-react","owner":{"login":"christiango","id":1581488,"avatar_url":"https://avatars1.githubusercontent.com/u/1581488?v=3","gravatar_id":"","url":"https://api.github.com/users/christiango","html_url":"https://github.com/christiango","followers_url":"https://api.github.com/users/christiango/followers","following_url":"https://api.github.com/users/christiango/following{/other_user}","gists_url":"https://api.github.com/users/christiango/gists{/gist_id}","starred_url":"https://api.github.com/users/christiango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christiango/subscriptions","organizations_url":"https://api.github.com/users/christiango/orgs","repos_url":"https://api.github.com/users/christiango/repos","events_url":"https://api.github.com/users/christiango/events{/privacy}","received_events_url":"https://api.github.com/users/christiango/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christiango/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":true,"url":"https://api.github.com/repos/christiango/office-ui-fabric-react","forks_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/christiango/office-ui-fabric-react/deployments","created_at":"2017-03-06T18:35:50Z","updated_at":"2017-03-06T18:35:53Z","pushed_at":"2017-05-25T18:23:29Z","git_url":"git://github.com/christiango/office-ui-fabric-react.git","ssh_url":"[email protected]:christiango/office-ui-fabric-react.git","clone_url":"https://github.com/christiango/office-ui-fabric-react.git","svn_url":"https://github.com/christiango/office-ui-fabric-react","homepage":"http://dev.office.com/fabric#/components","size":10672,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OfficeDev:master","ref":"master","sha":"f3b5400c99c8c441ba776f9d4cf62367a51ec961","user":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars1.githubusercontent.com/u/6789362?v=3","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":60537144,"name":"office-ui-fabric-react","full_name":"OfficeDev/office-ui-fabric-react","owner":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars1.githubusercontent.com/u/6789362?v=3","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":false,"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react","forks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/deployments","created_at":"2016-06-06T15:03:44Z","updated_at":"2017-05-25T06:59:11Z","pushed_at":"2017-05-25T18:43:35Z","git_url":"git://github.com/OfficeDev/office-ui-fabric-react.git","ssh_url":"[email protected]:OfficeDev/office-ui-fabric-react.git","clone_url":"https://github.com/OfficeDev/office-ui-fabric-react.git","svn_url":"https://github.com/OfficeDev/office-ui-fabric-react","homepage":"http://dev.office.com/fabric#/components","size":10982,"stargazers_count":1150,"watchers_count":1150,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":224,"mirror_url":null,"open_issues_count":254,"forks":224,"open_issues":254,"watchers":1150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/1864"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/1864"},"issue":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/1864"},"comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/1864/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/1864/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/1864/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/12bcc2421442c34f5b045175f329251d45311d55"}}}} | {
"id": 60537144,
"name": "OfficeDev/office-ui-fabric-react",
"url": "https://api.github.com/repos/OfficeDev/office-ui-fabric-react"
} | {
"id": 1581488,
"login": "christiango",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1581488?",
"url": "https://api.github.com/users/christiango"
} | {
"id": 6789362,
"login": "OfficeDev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6789362?",
"url": "https://api.github.com/orgs/OfficeDev"
} | 2017-05-25T18:53:06 | 5943961825 | {"actor":{"display_login":"christiango"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/comments/108848846","pull_request_review_id":29908334,"id":108848846,"diff_hunk":"@@ -405,16 +406,37 @@ Task(\"Restore\")\n RunTool(env.DotNetCommand, \"restore OmniSharp.sln\", env.WorkingDirectory)\n .ExceptionOnError(\"Failed to restore projects in OmniSharp.sln.\");\n \n+ // Restore test assets","path":"build.cake","position":12,"original_position":12,"commit_id":"6b3106332573b15f519254ee7a04070a682e69d7","original_commit_id":"6b3106332573b15f519254ee7a04070a682e69d7","user":{"login":"filipw","id":1710369,"avatar_url":"https://avatars3.githubusercontent.com/u/1710369?v=3","gravatar_id":"","url":"https://api.github.com/users/filipw","html_url":"https://github.com/filipw","followers_url":"https://api.github.com/users/filipw/followers","following_url":"https://api.github.com/users/filipw/following{/other_user}","gists_url":"https://api.github.com/users/filipw/gists{/gist_id}","starred_url":"https://api.github.com/users/filipw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipw/subscriptions","organizations_url":"https://api.github.com/users/filipw/orgs","repos_url":"https://api.github.com/users/filipw/repos","events_url":"https://api.github.com/users/filipw/events{/privacy}","received_events_url":"https://api.github.com/users/filipw/received_events","type":"User","site_admin":false},"body":"the build file is closing on 1000 lines 😄 ","created_at":"2017-03-30T06:24:09Z","updated_at":"2017-03-30T06:24:09Z","html_url":"https://github.com/OmniSharp/omnisharp-roslyn/pull/808#discussion_r108848846","pull_request_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/808","_links":{"self":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/comments/108848846"},"html":{"href":"https://github.com/OmniSharp/omnisharp-roslyn/pull/808#discussion_r108848846"},"pull_request":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/808"}}},"pull_request":{"url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/808","id":113322089,"html_url":"https://github.com/OmniSharp/omnisharp-roslyn/pull/808","diff_url":"https://github.com/OmniSharp/omnisharp-roslyn/pull/808.diff","patch_url":"https://github.com/OmniSharp/omnisharp-roslyn/pull/808.patch","issue_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/808","number":808,"state":"open","locked":false,"title":".NET Core RTM 'dotnet test' support","user":{"login":"DustinCampbell","id":116161,"avatar_url":"https://avatars3.githubusercontent.com/u/116161?v=3","gravatar_id":"","url":"https://api.github.com/users/DustinCampbell","html_url":"https://github.com/DustinCampbell","followers_url":"https://api.github.com/users/DustinCampbell/followers","following_url":"https://api.github.com/users/DustinCampbell/following{/other_user}","gists_url":"https://api.github.com/users/DustinCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/DustinCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DustinCampbell/subscriptions","organizations_url":"https://api.github.com/users/DustinCampbell/orgs","repos_url":"https://api.github.com/users/DustinCampbell/repos","events_url":"https://api.github.com/users/DustinCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/DustinCampbell/received_events","type":"User","site_admin":false},"body":"This PR represents a big refactoring (with tests!) of the existing 'dotnet test' support. In addition, it adds support for the VSTest protocol that is used in .NET CLI builds after 'preview2' -- that is, for csproj-based .NET Core projects.\r\n\r\nA couple of caveats:\r\n\r\n* I haven't sorted out how to get debugging of tests working in VS Code yet for csproj. These changes dutifully return the information provided by the VSTest protocol, but it's not clear yet how to actually launch the debugger with that information. I have a side conversation happening to try and get more detail.\r\n* NUnit is not yet supported for 'dotnet test' RTM. Until that happens, there are a number of tests that are disabled.\r\n* There's a lot of hardening I'd like to do here around the various processes and sockets that are used.\r\n* I'd like to add better reporting of progress during test runs.","created_at":"2017-03-30T00:17:00Z","updated_at":"2017-03-30T06:24:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9dd0d9e3e388031c21aed93589abcf13b74d6f4b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/808/commits","review_comments_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/808/comments","review_comment_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/808/comments","statuses_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/statuses/6b3106332573b15f519254ee7a04070a682e69d7","head":{"label":"DustinCampbell:vstest-support","ref":"vstest-support","sha":"6b3106332573b15f519254ee7a04070a682e69d7","user":{"login":"DustinCampbell","id":116161,"avatar_url":"https://avatars3.githubusercontent.com/u/116161?v=3","gravatar_id":"","url":"https://api.github.com/users/DustinCampbell","html_url":"https://github.com/DustinCampbell","followers_url":"https://api.github.com/users/DustinCampbell/followers","following_url":"https://api.github.com/users/DustinCampbell/following{/other_user}","gists_url":"https://api.github.com/users/DustinCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/DustinCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DustinCampbell/subscriptions","organizations_url":"https://api.github.com/users/DustinCampbell/orgs","repos_url":"https://api.github.com/users/DustinCampbell/repos","events_url":"https://api.github.com/users/DustinCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/DustinCampbell/received_events","type":"User","site_admin":false},"repo":{"id":28405827,"name":"omnisharp-roslyn","full_name":"DustinCampbell/omnisharp-roslyn","owner":{"login":"DustinCampbell","id":116161,"avatar_url":"https://avatars3.githubusercontent.com/u/116161?v=3","gravatar_id":"","url":"https://api.github.com/users/DustinCampbell","html_url":"https://github.com/DustinCampbell","followers_url":"https://api.github.com/users/DustinCampbell/followers","following_url":"https://api.github.com/users/DustinCampbell/following{/other_user}","gists_url":"https://api.github.com/users/DustinCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/DustinCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DustinCampbell/subscriptions","organizations_url":"https://api.github.com/users/DustinCampbell/orgs","repos_url":"https://api.github.com/users/DustinCampbell/repos","events_url":"https://api.github.com/users/DustinCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/DustinCampbell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DustinCampbell/omnisharp-roslyn","description":"OmniSharp based on roslyn workspaces","fork":true,"url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn","forks_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/forks","keys_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/teams","hooks_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/hooks","issue_events_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/events","assignees_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/tags","blobs_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/languages","stargazers_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/stargazers","contributors_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/contributors","subscribers_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/subscribers","subscription_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/subscription","commits_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/merges","archive_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/downloads","issues_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/labels{/name}","releases_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/deployments","created_at":"2014-12-23T15:45:56Z","updated_at":"2016-01-21T16:49:16Z","pushed_at":"2017-03-30T00:10:40Z","git_url":"git://github.com/DustinCampbell/omnisharp-roslyn.git","ssh_url":"[email protected]:DustinCampbell/omnisharp-roslyn.git","clone_url":"https://github.com/DustinCampbell/omnisharp-roslyn.git","svn_url":"https://github.com/DustinCampbell/omnisharp-roslyn","homepage":"","size":2890,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OmniSharp:dev","ref":"dev","sha":"d87dcbc814ab2e10fa2a67f899ee715710d94d27","user":{"login":"OmniSharp","id":9420663,"avatar_url":"https://avatars2.githubusercontent.com/u/9420663?v=3","gravatar_id":"","url":"https://api.github.com/users/OmniSharp","html_url":"https://github.com/OmniSharp","followers_url":"https://api.github.com/users/OmniSharp/followers","following_url":"https://api.github.com/users/OmniSharp/following{/other_user}","gists_url":"https://api.github.com/users/OmniSharp/gists{/gist_id}","starred_url":"https://api.github.com/users/OmniSharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmniSharp/subscriptions","organizations_url":"https://api.github.com/users/OmniSharp/orgs","repos_url":"https://api.github.com/users/OmniSharp/repos","events_url":"https://api.github.com/users/OmniSharp/events{/privacy}","received_events_url":"https://api.github.com/users/OmniSharp/received_events","type":"Organization","site_admin":false},"repo":{"id":27927984,"name":"omnisharp-roslyn","full_name":"OmniSharp/omnisharp-roslyn","owner":{"login":"OmniSharp","id":9420663,"avatar_url":"https://avatars2.githubusercontent.com/u/9420663?v=3","gravatar_id":"","url":"https://api.github.com/users/OmniSharp","html_url":"https://github.com/OmniSharp","followers_url":"https://api.github.com/users/OmniSharp/followers","following_url":"https://api.github.com/users/OmniSharp/following{/other_user}","gists_url":"https://api.github.com/users/OmniSharp/gists{/gist_id}","starred_url":"https://api.github.com/users/OmniSharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmniSharp/subscriptions","organizations_url":"https://api.github.com/users/OmniSharp/orgs","repos_url":"https://api.github.com/users/OmniSharp/repos","events_url":"https://api.github.com/users/OmniSharp/events{/privacy}","received_events_url":"https://api.github.com/users/OmniSharp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OmniSharp/omnisharp-roslyn","description":"OmniSharp based on roslyn workspaces","fork":false,"url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn","forks_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/forks","keys_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/teams","hooks_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/hooks","issue_events_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/events","assignees_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/tags","blobs_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/languages","stargazers_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/stargazers","contributors_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/contributors","subscribers_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/subscribers","subscription_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/subscription","commits_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/merges","archive_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/downloads","issues_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/labels{/name}","releases_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/deployments","created_at":"2014-12-12T16:21:03Z","updated_at":"2017-03-29T07:21:14Z","pushed_at":"2017-03-30T00:17:01Z","git_url":"git://github.com/OmniSharp/omnisharp-roslyn.git","ssh_url":"[email protected]:OmniSharp/omnisharp-roslyn.git","clone_url":"https://github.com/OmniSharp/omnisharp-roslyn.git","svn_url":"https://github.com/OmniSharp/omnisharp-roslyn","homepage":"","size":5816,"stargazers_count":396,"watchers_count":396,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":139,"mirror_url":null,"open_issues_count":138,"forks":139,"open_issues":138,"watchers":396,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/808"},"html":{"href":"https://github.com/OmniSharp/omnisharp-roslyn/pull/808"},"issue":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/808"},"comments":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/808/comments"},"review_comments":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/808/comments"},"review_comment":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/808/commits"},"statuses":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/statuses/6b3106332573b15f519254ee7a04070a682e69d7"}}}} | {
"id": 27927984,
"name": "OmniSharp/omnisharp-roslyn",
"url": "https://api.github.com/repos/OmniSharp/omnisharp-roslyn"
} | {
"id": 1710369,
"login": "filipw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1710369?",
"url": "https://api.github.com/users/filipw"
} | {
"id": 9420663,
"login": "OmniSharp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9420663?",
"url": "https://api.github.com/orgs/OmniSharp"
} | 2017-03-30T06:24:09 | 5592815668 | {"actor":{"display_login":"filipw"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/OpenGenus/cosmos/pulls/comments/146112099","pull_request_review_id":71013918,"id":146112099,"diff_hunk":"@@ -1,41 +1,57 @@\n-import random\n-# Part of Cosmos by OpenGenus Foundation\n-num_of_nums = 100\n+#Program for InsertionSort sorting\n+\n+import numpy as np\n+import cProfile\n+\n+#Function to return sorted list using Insertion sort.\n+def insertion_sort(L):\n+\tlength = len(L)\n+\tfor i in range(length):\n+\t\tkey = L[i]\n+\t\tj = i - 1\n+\t\twhile j >= 0:\n+\t\t\tif key < L[j]:\n+\t\t\t\tj -= 1\n+\t\t\telse:\n+\t\t\t\tbreak\n+\t\tj += 1\n+\t\tL.insert(j,L.pop(i))\n+\treturn L\n+\n+\n+if __name__ == \"__main__\":\n+\n+\t#creating a random array of length 100\n+\tL = np.random.random_integers(100,size = (100,)).tolist()\n+\tprint (\"Given array : \\n\",L)\n+\tprint (\"Sorted array : \\n\",insertion_sort(L))\n+\t\n+\t\n+\n+\n+\n+\n+\n+","path":"code/sorting/insertion_sort/insertion_sort.py","position":37,"original_position":38,"commit_id":"66681d6d1b858a27f2b78686bcddca501a92d1c5","original_commit_id":"66681d6d1b858a27f2b78686bcddca501a92d1c5","user":{"login":"arnavb","id":30810402,"avatar_url":"https://avatars0.githubusercontent.com/u/30810402?v=4","gravatar_id":"","url":"https://api.github.com/users/arnavb","html_url":"https://github.com/arnavb","followers_url":"https://api.github.com/users/arnavb/followers","following_url":"https://api.github.com/users/arnavb/following{/other_user}","gists_url":"https://api.github.com/users/arnavb/gists{/gist_id}","starred_url":"https://api.github.com/users/arnavb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnavb/subscriptions","organizations_url":"https://api.github.com/users/arnavb/orgs","repos_url":"https://api.github.com/users/arnavb/repos","events_url":"https://api.github.com/users/arnavb/events{/privacy}","received_events_url":"https://api.github.com/users/arnavb/received_events","type":"User","site_admin":false},"body":"Get rid of all these spaces.","created_at":"2017-10-21T18:29:37Z","updated_at":"2017-10-21T18:29:41Z","html_url":"https://github.com/OpenGenus/cosmos/pull/2243#discussion_r146112099","pull_request_url":"https://api.github.com/repos/OpenGenus/cosmos/pulls/2243","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenGenus/cosmos/pulls/comments/146112099"},"html":{"href":"https://github.com/OpenGenus/cosmos/pull/2243#discussion_r146112099"},"pull_request":{"href":"https://api.github.com/repos/OpenGenus/cosmos/pulls/2243"}}},"pull_request":{"url":"https://api.github.com/repos/OpenGenus/cosmos/pulls/2243","id":147943031,"html_url":"https://github.com/OpenGenus/cosmos/pull/2243","diff_url":"https://github.com/OpenGenus/cosmos/pull/2243.diff","patch_url":"https://github.com/OpenGenus/cosmos/pull/2243.patch","issue_url":"https://api.github.com/repos/OpenGenus/cosmos/issues/2243","number":2243,"state":"open","locked":false,"title":"Update insertionsort.py code","user":{"login":"satishjasthi","id":15075900,"avatar_url":"https://avatars3.githubusercontent.com/u/15075900?v=4","gravatar_id":"","url":"https://api.github.com/users/satishjasthi","html_url":"https://github.com/satishjasthi","followers_url":"https://api.github.com/users/satishjasthi/followers","following_url":"https://api.github.com/users/satishjasthi/following{/other_user}","gists_url":"https://api.github.com/users/satishjasthi/gists{/gist_id}","starred_url":"https://api.github.com/users/satishjasthi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satishjasthi/subscriptions","organizations_url":"https://api.github.com/users/satishjasthi/orgs","repos_url":"https://api.github.com/users/satishjasthi/repos","events_url":"https://api.github.com/users/satishjasthi/events{/privacy}","received_events_url":"https://api.github.com/users/satishjasthi/received_events","type":"User","site_admin":false},"body":"Update the code to perform insertion sort more efficiently compared to previous version of code. This PR is a part of Hacktoberfest.\r\n\r\n**Fixes issue:** \r\nImprove performance of insertionsort.py code\r\n\r\n**Changes:**\r\nEntire code is rewritten to perform insertion sort in an efficient way. I have provided time profiling information to compare between older and new version of insertionsort.py code in [modified_insertion_sort_cProfiling_data.txt](https://github.com/OpenGenus/cosmos/files/1404104/modified_insertion_sort_cProfiling_data.txt)\r\n","created_at":"2017-10-21T12:57:57Z","updated_at":"2017-10-21T18:29:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f7b816bb242e689d1c78e4e0fbc8bc480f6753f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenGenus/cosmos/pulls/2243/commits","review_comments_url":"https://api.github.com/repos/OpenGenus/cosmos/pulls/2243/comments","review_comment_url":"https://api.github.com/repos/OpenGenus/cosmos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenGenus/cosmos/issues/2243/comments","statuses_url":"https://api.github.com/repos/OpenGenus/cosmos/statuses/66681d6d1b858a27f2b78686bcddca501a92d1c5","head":{"label":"satishjasthi:satish_jasthi","ref":"satish_jasthi","sha":"66681d6d1b858a27f2b78686bcddca501a92d1c5","user":{"login":"satishjasthi","id":15075900,"avatar_url":"https://avatars3.githubusercontent.com/u/15075900?v=4","gravatar_id":"","url":"https://api.github.com/users/satishjasthi","html_url":"https://github.com/satishjasthi","followers_url":"https://api.github.com/users/satishjasthi/followers","following_url":"https://api.github.com/users/satishjasthi/following{/other_user}","gists_url":"https://api.github.com/users/satishjasthi/gists{/gist_id}","starred_url":"https://api.github.com/users/satishjasthi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satishjasthi/subscriptions","organizations_url":"https://api.github.com/users/satishjasthi/orgs","repos_url":"https://api.github.com/users/satishjasthi/repos","events_url":"https://api.github.com/users/satishjasthi/events{/privacy}","received_events_url":"https://api.github.com/users/satishjasthi/received_events","type":"User","site_admin":false},"repo":{"id":107256896,"name":"cosmos","full_name":"satishjasthi/cosmos","owner":{"login":"satishjasthi","id":15075900,"avatar_url":"https://avatars3.githubusercontent.com/u/15075900?v=4","gravatar_id":"","url":"https://api.github.com/users/satishjasthi","html_url":"https://github.com/satishjasthi","followers_url":"https://api.github.com/users/satishjasthi/followers","following_url":"https://api.github.com/users/satishjasthi/following{/other_user}","gists_url":"https://api.github.com/users/satishjasthi/gists{/gist_id}","starred_url":"https://api.github.com/users/satishjasthi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satishjasthi/subscriptions","organizations_url":"https://api.github.com/users/satishjasthi/orgs","repos_url":"https://api.github.com/users/satishjasthi/repos","events_url":"https://api.github.com/users/satishjasthi/events{/privacy}","received_events_url":"https://api.github.com/users/satishjasthi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/satishjasthi/cosmos","description":" [Show :heart: love by 🌟] Your personal library of every algorithm and data structure code that you will ever encounter","fork":true,"url":"https://api.github.com/repos/satishjasthi/cosmos","forks_url":"https://api.github.com/repos/satishjasthi/cosmos/forks","keys_url":"https://api.github.com/repos/satishjasthi/cosmos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/satishjasthi/cosmos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/satishjasthi/cosmos/teams","hooks_url":"https://api.github.com/repos/satishjasthi/cosmos/hooks","issue_events_url":"https://api.github.com/repos/satishjasthi/cosmos/issues/events{/number}","events_url":"https://api.github.com/repos/satishjasthi/cosmos/events","assignees_url":"https://api.github.com/repos/satishjasthi/cosmos/assignees{/user}","branches_url":"https://api.github.com/repos/satishjasthi/cosmos/branches{/branch}","tags_url":"https://api.github.com/repos/satishjasthi/cosmos/tags","blobs_url":"https://api.github.com/repos/satishjasthi/cosmos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/satishjasthi/cosmos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/satishjasthi/cosmos/git/refs{/sha}","trees_url":"https://api.github.com/repos/satishjasthi/cosmos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/satishjasthi/cosmos/statuses/{sha}","languages_url":"https://api.github.com/repos/satishjasthi/cosmos/languages","stargazers_url":"https://api.github.com/repos/satishjasthi/cosmos/stargazers","contributors_url":"https://api.github.com/repos/satishjasthi/cosmos/contributors","subscribers_url":"https://api.github.com/repos/satishjasthi/cosmos/subscribers","subscription_url":"https://api.github.com/repos/satishjasthi/cosmos/subscription","commits_url":"https://api.github.com/repos/satishjasthi/cosmos/commits{/sha}","git_commits_url":"https://api.github.com/repos/satishjasthi/cosmos/git/commits{/sha}","comments_url":"https://api.github.com/repos/satishjasthi/cosmos/comments{/number}","issue_comment_url":"https://api.github.com/repos/satishjasthi/cosmos/issues/comments{/number}","contents_url":"https://api.github.com/repos/satishjasthi/cosmos/contents/{+path}","compare_url":"https://api.github.com/repos/satishjasthi/cosmos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/satishjasthi/cosmos/merges","archive_url":"https://api.github.com/repos/satishjasthi/cosmos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/satishjasthi/cosmos/downloads","issues_url":"https://api.github.com/repos/satishjasthi/cosmos/issues{/number}","pulls_url":"https://api.github.com/repos/satishjasthi/cosmos/pulls{/number}","milestones_url":"https://api.github.com/repos/satishjasthi/cosmos/milestones{/number}","notifications_url":"https://api.github.com/repos/satishjasthi/cosmos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/satishjasthi/cosmos/labels{/name}","releases_url":"https://api.github.com/repos/satishjasthi/cosmos/releases{/id}","deployments_url":"https://api.github.com/repos/satishjasthi/cosmos/deployments","created_at":"2017-10-17T11:04:53Z","updated_at":"2017-10-17T11:04:57Z","pushed_at":"2017-10-21T18:28:14Z","git_url":"git://github.com/satishjasthi/cosmos.git","ssh_url":"[email protected]:satishjasthi/cosmos.git","clone_url":"https://github.com/satishjasthi/cosmos.git","svn_url":"https://github.com/satishjasthi/cosmos","homepage":"","size":7567,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenGenus:master","ref":"master","sha":"afd1ab96939ae4b0380386883a95caae922b5197","user":{"login":"OpenGenus","id":18506046,"avatar_url":"https://avatars3.githubusercontent.com/u/18506046?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenGenus","html_url":"https://github.com/OpenGenus","followers_url":"https://api.github.com/users/OpenGenus/followers","following_url":"https://api.github.com/users/OpenGenus/following{/other_user}","gists_url":"https://api.github.com/users/OpenGenus/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenGenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenGenus/subscriptions","organizations_url":"https://api.github.com/users/OpenGenus/orgs","repos_url":"https://api.github.com/users/OpenGenus/repos","events_url":"https://api.github.com/users/OpenGenus/events{/privacy}","received_events_url":"https://api.github.com/users/OpenGenus/received_events","type":"Organization","site_admin":false},"repo":{"id":103749180,"name":"cosmos","full_name":"OpenGenus/cosmos","owner":{"login":"OpenGenus","id":18506046,"avatar_url":"https://avatars3.githubusercontent.com/u/18506046?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenGenus","html_url":"https://github.com/OpenGenus","followers_url":"https://api.github.com/users/OpenGenus/followers","following_url":"https://api.github.com/users/OpenGenus/following{/other_user}","gists_url":"https://api.github.com/users/OpenGenus/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenGenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenGenus/subscriptions","organizations_url":"https://api.github.com/users/OpenGenus/orgs","repos_url":"https://api.github.com/users/OpenGenus/repos","events_url":"https://api.github.com/users/OpenGenus/events{/privacy}","received_events_url":"https://api.github.com/users/OpenGenus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenGenus/cosmos","description":" [Show :heart: love by 🌟] Your personal library of every algorithm and data structure code that you will ever encounter","fork":false,"url":"https://api.github.com/repos/OpenGenus/cosmos","forks_url":"https://api.github.com/repos/OpenGenus/cosmos/forks","keys_url":"https://api.github.com/repos/OpenGenus/cosmos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenGenus/cosmos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenGenus/cosmos/teams","hooks_url":"https://api.github.com/repos/OpenGenus/cosmos/hooks","issue_events_url":"https://api.github.com/repos/OpenGenus/cosmos/issues/events{/number}","events_url":"https://api.github.com/repos/OpenGenus/cosmos/events","assignees_url":"https://api.github.com/repos/OpenGenus/cosmos/assignees{/user}","branches_url":"https://api.github.com/repos/OpenGenus/cosmos/branches{/branch}","tags_url":"https://api.github.com/repos/OpenGenus/cosmos/tags","blobs_url":"https://api.github.com/repos/OpenGenus/cosmos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenGenus/cosmos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenGenus/cosmos/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenGenus/cosmos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenGenus/cosmos/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenGenus/cosmos/languages","stargazers_url":"https://api.github.com/repos/OpenGenus/cosmos/stargazers","contributors_url":"https://api.github.com/repos/OpenGenus/cosmos/contributors","subscribers_url":"https://api.github.com/repos/OpenGenus/cosmos/subscribers","subscription_url":"https://api.github.com/repos/OpenGenus/cosmos/subscription","commits_url":"https://api.github.com/repos/OpenGenus/cosmos/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenGenus/cosmos/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenGenus/cosmos/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenGenus/cosmos/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenGenus/cosmos/contents/{+path}","compare_url":"https://api.github.com/repos/OpenGenus/cosmos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenGenus/cosmos/merges","archive_url":"https://api.github.com/repos/OpenGenus/cosmos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenGenus/cosmos/downloads","issues_url":"https://api.github.com/repos/OpenGenus/cosmos/issues{/number}","pulls_url":"https://api.github.com/repos/OpenGenus/cosmos/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenGenus/cosmos/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenGenus/cosmos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenGenus/cosmos/labels{/name}","releases_url":"https://api.github.com/repos/OpenGenus/cosmos/releases{/id}","deployments_url":"https://api.github.com/repos/OpenGenus/cosmos/deployments","created_at":"2017-09-16T12:07:05Z","updated_at":"2017-10-21T18:29:04Z","pushed_at":"2017-10-21T18:28:16Z","git_url":"git://github.com/OpenGenus/cosmos.git","ssh_url":"[email protected]:OpenGenus/cosmos.git","clone_url":"https://github.com/OpenGenus/cosmos.git","svn_url":"https://github.com/OpenGenus/cosmos","homepage":"","size":9086,"stargazers_count":3830,"watchers_count":3830,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1232,"mirror_url":null,"archived":false,"open_issues_count":513,"forks":1232,"open_issues":513,"watchers":3830,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenGenus/cosmos/pulls/2243"},"html":{"href":"https://github.com/OpenGenus/cosmos/pull/2243"},"issue":{"href":"https://api.github.com/repos/OpenGenus/cosmos/issues/2243"},"comments":{"href":"https://api.github.com/repos/OpenGenus/cosmos/issues/2243/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenGenus/cosmos/pulls/2243/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenGenus/cosmos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenGenus/cosmos/pulls/2243/commits"},"statuses":{"href":"https://api.github.com/repos/OpenGenus/cosmos/statuses/66681d6d1b858a27f2b78686bcddca501a92d1c5"}},"author_association":"NONE"}} | {
"id": 103749180,
"name": "OpenGenus/cosmos",
"url": "https://api.github.com/repos/OpenGenus/cosmos"
} | {
"id": 30810402,
"login": "arnavb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30810402?",
"url": "https://api.github.com/users/arnavb"
} | {
"id": 18506046,
"login": "OpenGenus",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18506046?",
"url": "https://api.github.com/orgs/OpenGenus"
} | 2017-10-21T18:29:37 | 6747616520 | {"actor":{"display_login":"arnavb"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments/147860446","pull_request_review_id":73009117,"id":147860446,"diff_hunk":"@@ -1,208 +1,175 @@\n import numpy as np\n-from functools import reduce\n+from collections import namedtuple, UserDict\n from typing import Dict, List\n+from functools import partial\n+from numpy.linalg import inv\n+from functools import reduce\n \n-from opentrons.containers.placeable import WellSeries\n-from opentrons.trackers.move_msgs import new_pos_msg\n-from opentrons.broker import topics, subscribe\n+ROOT = 'root'","path":"api/opentrons/trackers/pose_tracker.py","position":12,"original_position":12,"commit_id":"a66908b4da69102db41143b4422b987e35bd383d","original_commit_id":"a66908b4da69102db41143b4422b987e35bd383d","user":{"login":"mcous","id":2963448,"avatar_url":"https://avatars1.githubusercontent.com/u/2963448?v=4","gravatar_id":"","url":"https://api.github.com/users/mcous","html_url":"https://github.com/mcous","followers_url":"https://api.github.com/users/mcous/followers","following_url":"https://api.github.com/users/mcous/following{/other_user}","gists_url":"https://api.github.com/users/mcous/gists{/gist_id}","starred_url":"https://api.github.com/users/mcous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcous/subscriptions","organizations_url":"https://api.github.com/users/mcous/orgs","repos_url":"https://api.github.com/users/mcous/repos","events_url":"https://api.github.com/users/mcous/events{/privacy}","received_events_url":"https://api.github.com/users/mcous/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2017-10-30T23:15:48Z","updated_at":"2017-10-30T23:22:34Z","html_url":"https://github.com/Opentrons/opentrons/pull/384#discussion_r147860446","pull_request_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/384","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments/147860446"},"html":{"href":"https://github.com/Opentrons/opentrons/pull/384#discussion_r147860446"},"pull_request":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/384"}}},"pull_request":{"url":"https://api.github.com/repos/Opentrons/opentrons/pulls/384","id":149094396,"html_url":"https://github.com/Opentrons/opentrons/pull/384","diff_url":"https://github.com/Opentrons/opentrons/pull/384.diff","patch_url":"https://github.com/Opentrons/opentrons/pull/384.patch","issue_url":"https://api.github.com/repos/Opentrons/opentrons/issues/384","number":384,"state":"open","locked":false,"title":"Functional pose tracker, fixing tests, linting","user":{"login":"astaff","id":1032174,"avatar_url":"https://avatars3.githubusercontent.com/u/1032174?v=4","gravatar_id":"","url":"https://api.github.com/users/astaff","html_url":"https://github.com/astaff","followers_url":"https://api.github.com/users/astaff/followers","following_url":"https://api.github.com/users/astaff/following{/other_user}","gists_url":"https://api.github.com/users/astaff/gists{/gist_id}","starred_url":"https://api.github.com/users/astaff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astaff/subscriptions","organizations_url":"https://api.github.com/users/astaff/orgs","repos_url":"https://api.github.com/users/astaff/repos","events_url":"https://api.github.com/users/astaff/events{/privacy}","received_events_url":"https://api.github.com/users/astaff/received_events","type":"User","site_admin":false},"body":"# TODO\r\n\r\n- [ ] test on a robot\r\n- [ ] integrate tests from #381\r\n\r\n## Making tests green and fixing linting errors\r\n\r\n* Tests are green ✅🎉. There was a cluster of tests we disabled that has to deal with getting plunger position — currently not implemented in actuator or not tracked in pose tracker), calibration data —expected values are way off and i would like to open a next PR with refactored calibration and troubleshoot remaining tests in that branch\r\n* Linting errors fixed with `autopep8` in the future let's make sure to not let these go out of control and install a pep8 plugin into our IDEs\r\n* Coverage is down to 69% — mostly due to pipette tests being commented out. Let's bring it back to 90% by the end of this week.\r\n\r\n## Pose tracker\r\n\r\n* Separates data from functions, turning PoseTracker into a tree,\r\nthat connects objects with their corresponding transformation values. The immutable\r\ntree is stored as `poses` in the robot and passed to movement-related functions.\r\n* Makes necessary updates to gantry, mount, instrument, to pass state around,\r\nwhile making code cleanups along the way.\r\n* In a few instances `self.poses` is being accessed directly from non-robot\r\nfunctions — this should be updated in future refactorings.\r\n\r\n## Driver\r\n\r\nRefactors homing sequence, stores position tracking information to reduce\r\nserial interface chatter. Driver accepts and returns physical coordinates, and\r\nuses calibration values from cli tool for conversion.\r\n","created_at":"2017-10-27T03:38:50Z","updated_at":"2017-10-30T23:22:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3f052d09c3cf37b563f70cf2830a2d9a0abba93","assignee":null,"assignees":[],"requested_reviewers":[{"login":"btmorr","id":5034659,"avatar_url":"https://avatars2.githubusercontent.com/u/5034659?v=4","gravatar_id":"","url":"https://api.github.com/users/btmorr","html_url":"https://github.com/btmorr","followers_url":"https://api.github.com/users/btmorr/followers","following_url":"https://api.github.com/users/btmorr/following{/other_user}","gists_url":"https://api.github.com/users/btmorr/gists{/gist_id}","starred_url":"https://api.github.com/users/btmorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btmorr/subscriptions","organizations_url":"https://api.github.com/users/btmorr/orgs","repos_url":"https://api.github.com/users/btmorr/repos","events_url":"https://api.github.com/users/btmorr/events{/privacy}","received_events_url":"https://api.github.com/users/btmorr/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/384/commits","review_comments_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/384/comments","review_comment_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/issues/384/comments","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/a66908b4da69102db41143b4422b987e35bd383d","head":{"label":"Opentrons:376-functional-pose-tracker-v3a","ref":"376-functional-pose-tracker-v3a","sha":"a66908b4da69102db41143b4422b987e35bd383d","user":{"login":"Opentrons","id":6139147,"avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"repo":{"id":38644841,"name":"opentrons","full_name":"Opentrons/opentrons","owner":{"login":"Opentrons","id":6139147,"avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Opentrons/opentrons","description":"Python API for writing protocols and running them on Opentrons robots","fork":false,"url":"https://api.github.com/repos/Opentrons/opentrons","forks_url":"https://api.github.com/repos/Opentrons/opentrons/forks","keys_url":"https://api.github.com/repos/Opentrons/opentrons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Opentrons/opentrons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Opentrons/opentrons/teams","hooks_url":"https://api.github.com/repos/Opentrons/opentrons/hooks","issue_events_url":"https://api.github.com/repos/Opentrons/opentrons/issues/events{/number}","events_url":"https://api.github.com/repos/Opentrons/opentrons/events","assignees_url":"https://api.github.com/repos/Opentrons/opentrons/assignees{/user}","branches_url":"https://api.github.com/repos/Opentrons/opentrons/branches{/branch}","tags_url":"https://api.github.com/repos/Opentrons/opentrons/tags","blobs_url":"https://api.github.com/repos/Opentrons/opentrons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Opentrons/opentrons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Opentrons/opentrons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Opentrons/opentrons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/{sha}","languages_url":"https://api.github.com/repos/Opentrons/opentrons/languages","stargazers_url":"https://api.github.com/repos/Opentrons/opentrons/stargazers","contributors_url":"https://api.github.com/repos/Opentrons/opentrons/contributors","subscribers_url":"https://api.github.com/repos/Opentrons/opentrons/subscribers","subscription_url":"https://api.github.com/repos/Opentrons/opentrons/subscription","commits_url":"https://api.github.com/repos/Opentrons/opentrons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Opentrons/opentrons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Opentrons/opentrons/issues/comments{/number}","contents_url":"https://api.github.com/repos/Opentrons/opentrons/contents/{+path}","compare_url":"https://api.github.com/repos/Opentrons/opentrons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Opentrons/opentrons/merges","archive_url":"https://api.github.com/repos/Opentrons/opentrons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Opentrons/opentrons/downloads","issues_url":"https://api.github.com/repos/Opentrons/opentrons/issues{/number}","pulls_url":"https://api.github.com/repos/Opentrons/opentrons/pulls{/number}","milestones_url":"https://api.github.com/repos/Opentrons/opentrons/milestones{/number}","notifications_url":"https://api.github.com/repos/Opentrons/opentrons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Opentrons/opentrons/labels{/name}","releases_url":"https://api.github.com/repos/Opentrons/opentrons/releases{/id}","deployments_url":"https://api.github.com/repos/Opentrons/opentrons/deployments","created_at":"2015-07-06T20:41:01Z","updated_at":"2017-10-27T20:37:27Z","pushed_at":"2017-10-30T22:33:09Z","git_url":"git://github.com/Opentrons/opentrons.git","ssh_url":"[email protected]:Opentrons/opentrons.git","clone_url":"https://github.com/Opentrons/opentrons.git","svn_url":"https://github.com/Opentrons/opentrons","homepage":"","size":19668,"stargazers_count":35,"watchers_count":35,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":51,"forks":23,"open_issues":51,"watchers":35,"default_branch":"develop"}},"base":{"label":"Opentrons:v3a","ref":"v3a","sha":"e685a7c8f119e11adefbd4a2c2cc95b9cee939fe","user":{"login":"Opentrons","id":6139147,"avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"repo":{"id":38644841,"name":"opentrons","full_name":"Opentrons/opentrons","owner":{"login":"Opentrons","id":6139147,"avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Opentrons/opentrons","description":"Python API for writing protocols and running them on Opentrons robots","fork":false,"url":"https://api.github.com/repos/Opentrons/opentrons","forks_url":"https://api.github.com/repos/Opentrons/opentrons/forks","keys_url":"https://api.github.com/repos/Opentrons/opentrons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Opentrons/opentrons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Opentrons/opentrons/teams","hooks_url":"https://api.github.com/repos/Opentrons/opentrons/hooks","issue_events_url":"https://api.github.com/repos/Opentrons/opentrons/issues/events{/number}","events_url":"https://api.github.com/repos/Opentrons/opentrons/events","assignees_url":"https://api.github.com/repos/Opentrons/opentrons/assignees{/user}","branches_url":"https://api.github.com/repos/Opentrons/opentrons/branches{/branch}","tags_url":"https://api.github.com/repos/Opentrons/opentrons/tags","blobs_url":"https://api.github.com/repos/Opentrons/opentrons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Opentrons/opentrons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Opentrons/opentrons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Opentrons/opentrons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/{sha}","languages_url":"https://api.github.com/repos/Opentrons/opentrons/languages","stargazers_url":"https://api.github.com/repos/Opentrons/opentrons/stargazers","contributors_url":"https://api.github.com/repos/Opentrons/opentrons/contributors","subscribers_url":"https://api.github.com/repos/Opentrons/opentrons/subscribers","subscription_url":"https://api.github.com/repos/Opentrons/opentrons/subscription","commits_url":"https://api.github.com/repos/Opentrons/opentrons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Opentrons/opentrons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Opentrons/opentrons/issues/comments{/number}","contents_url":"https://api.github.com/repos/Opentrons/opentrons/contents/{+path}","compare_url":"https://api.github.com/repos/Opentrons/opentrons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Opentrons/opentrons/merges","archive_url":"https://api.github.com/repos/Opentrons/opentrons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Opentrons/opentrons/downloads","issues_url":"https://api.github.com/repos/Opentrons/opentrons/issues{/number}","pulls_url":"https://api.github.com/repos/Opentrons/opentrons/pulls{/number}","milestones_url":"https://api.github.com/repos/Opentrons/opentrons/milestones{/number}","notifications_url":"https://api.github.com/repos/Opentrons/opentrons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Opentrons/opentrons/labels{/name}","releases_url":"https://api.github.com/repos/Opentrons/opentrons/releases{/id}","deployments_url":"https://api.github.com/repos/Opentrons/opentrons/deployments","created_at":"2015-07-06T20:41:01Z","updated_at":"2017-10-27T20:37:27Z","pushed_at":"2017-10-30T22:33:09Z","git_url":"git://github.com/Opentrons/opentrons.git","ssh_url":"[email protected]:Opentrons/opentrons.git","clone_url":"https://github.com/Opentrons/opentrons.git","svn_url":"https://github.com/Opentrons/opentrons","homepage":"","size":19668,"stargazers_count":35,"watchers_count":35,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":51,"forks":23,"open_issues":51,"watchers":35,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/384"},"html":{"href":"https://github.com/Opentrons/opentrons/pull/384"},"issue":{"href":"https://api.github.com/repos/Opentrons/opentrons/issues/384"},"comments":{"href":"https://api.github.com/repos/Opentrons/opentrons/issues/384/comments"},"review_comments":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/384/comments"},"review_comment":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/384/commits"},"statuses":{"href":"https://api.github.com/repos/Opentrons/opentrons/statuses/a66908b4da69102db41143b4422b987e35bd383d"}},"author_association":"CONTRIBUTOR"}} | {
"id": 38644841,
"name": "Opentrons/opentrons",
"url": "https://api.github.com/repos/Opentrons/opentrons"
} | {
"id": 2963448,
"login": "mcous",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2963448?",
"url": "https://api.github.com/users/mcous"
} | {
"id": 6139147,
"login": "Opentrons",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6139147?",
"url": "https://api.github.com/orgs/Opentrons"
} | 2017-10-30T23:15:48 | 6786718756 | {"actor":{"display_login":"mcous"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/TASVideos/desmume/pulls/comments/133053638","pull_request_review_id":56194493,"id":133053638,"diff_hunk":"@@ -59,14 +59,14 @@ armcpu_t NDS_ARM9;\n static void\n stall_cpu( void *instance) {\n armcpu_t *armcpu = (armcpu_t *)instance;\n- printf(\"STALL\\n\");\n+ puts(\"STALL\");","path":"desmume/src/armcpu.cpp","position":14,"original_position":14,"commit_id":"25615a6506f149995bbd73c3194c782f9476d286","original_commit_id":"25615a6506f149995bbd73c3194c782f9476d286","user":{"login":"RyDroid","id":4244587,"avatar_url":"https://avatars0.githubusercontent.com/u/4244587?v=4","gravatar_id":"","url":"https://api.github.com/users/RyDroid","html_url":"https://github.com/RyDroid","followers_url":"https://api.github.com/users/RyDroid/followers","following_url":"https://api.github.com/users/RyDroid/following{/other_user}","gists_url":"https://api.github.com/users/RyDroid/gists{/gist_id}","starred_url":"https://api.github.com/users/RyDroid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyDroid/subscriptions","organizations_url":"https://api.github.com/users/RyDroid/orgs","repos_url":"https://api.github.com/users/RyDroid/repos","events_url":"https://api.github.com/users/RyDroid/events{/privacy}","received_events_url":"https://api.github.com/users/RyDroid/received_events","type":"User","site_admin":false},"body":"Faster and shorter","created_at":"2017-08-14T20:32:47Z","updated_at":"2017-08-14T20:32:47Z","html_url":"https://github.com/TASVideos/desmume/pull/91#discussion_r133053638","pull_request_url":"https://api.github.com/repos/TASVideos/desmume/pulls/91","_links":{"self":{"href":"https://api.github.com/repos/TASVideos/desmume/pulls/comments/133053638"},"html":{"href":"https://github.com/TASVideos/desmume/pull/91#discussion_r133053638"},"pull_request":{"href":"https://api.github.com/repos/TASVideos/desmume/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/TASVideos/desmume/pulls/91","id":135472735,"html_url":"https://github.com/TASVideos/desmume/pull/91","diff_url":"https://github.com/TASVideos/desmume/pull/91.diff","patch_url":"https://github.com/TASVideos/desmume/pull/91.patch","issue_url":"https://api.github.com/repos/TASVideos/desmume/issues/91","number":91,"state":"open","locked":false,"title":"Tiny changes in C++","user":{"login":"RyDroid","id":4244587,"avatar_url":"https://avatars0.githubusercontent.com/u/4244587?v=4","gravatar_id":"","url":"https://api.github.com/users/RyDroid","html_url":"https://github.com/RyDroid","followers_url":"https://api.github.com/users/RyDroid/followers","following_url":"https://api.github.com/users/RyDroid/following{/other_user}","gists_url":"https://api.github.com/users/RyDroid/gists{/gist_id}","starred_url":"https://api.github.com/users/RyDroid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyDroid/subscriptions","organizations_url":"https://api.github.com/users/RyDroid/orgs","repos_url":"https://api.github.com/users/RyDroid/repos","events_url":"https://api.github.com/users/RyDroid/events{/privacy}","received_events_url":"https://api.github.com/users/RyDroid/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-12T21:00:21Z","updated_at":"2017-08-14T20:32:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d96bf366634992407bd9b206114e121696173289","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/TASVideos/desmume/pulls/91/commits","review_comments_url":"https://api.github.com/repos/TASVideos/desmume/pulls/91/comments","review_comment_url":"https://api.github.com/repos/TASVideos/desmume/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TASVideos/desmume/issues/91/comments","statuses_url":"https://api.github.com/repos/TASVideos/desmume/statuses/25615a6506f149995bbd73c3194c782f9476d286","head":{"label":"RyDroid:minor-cpp","ref":"minor-cpp","sha":"25615a6506f149995bbd73c3194c782f9476d286","user":{"login":"RyDroid","id":4244587,"avatar_url":"https://avatars0.githubusercontent.com/u/4244587?v=4","gravatar_id":"","url":"https://api.github.com/users/RyDroid","html_url":"https://github.com/RyDroid","followers_url":"https://api.github.com/users/RyDroid/followers","following_url":"https://api.github.com/users/RyDroid/following{/other_user}","gists_url":"https://api.github.com/users/RyDroid/gists{/gist_id}","starred_url":"https://api.github.com/users/RyDroid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyDroid/subscriptions","organizations_url":"https://api.github.com/users/RyDroid/orgs","repos_url":"https://api.github.com/users/RyDroid/repos","events_url":"https://api.github.com/users/RyDroid/events{/privacy}","received_events_url":"https://api.github.com/users/RyDroid/received_events","type":"User","site_admin":false},"repo":{"id":89615551,"name":"desmume","full_name":"RyDroid/desmume","owner":{"login":"RyDroid","id":4244587,"avatar_url":"https://avatars0.githubusercontent.com/u/4244587?v=4","gravatar_id":"","url":"https://api.github.com/users/RyDroid","html_url":"https://github.com/RyDroid","followers_url":"https://api.github.com/users/RyDroid/followers","following_url":"https://api.github.com/users/RyDroid/following{/other_user}","gists_url":"https://api.github.com/users/RyDroid/gists{/gist_id}","starred_url":"https://api.github.com/users/RyDroid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyDroid/subscriptions","organizations_url":"https://api.github.com/users/RyDroid/orgs","repos_url":"https://api.github.com/users/RyDroid/repos","events_url":"https://api.github.com/users/RyDroid/events{/privacy}","received_events_url":"https://api.github.com/users/RyDroid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RyDroid/desmume","description":"DeSmuME is a Nintendo DS emulator","fork":true,"url":"https://api.github.com/repos/RyDroid/desmume","forks_url":"https://api.github.com/repos/RyDroid/desmume/forks","keys_url":"https://api.github.com/repos/RyDroid/desmume/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RyDroid/desmume/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RyDroid/desmume/teams","hooks_url":"https://api.github.com/repos/RyDroid/desmume/hooks","issue_events_url":"https://api.github.com/repos/RyDroid/desmume/issues/events{/number}","events_url":"https://api.github.com/repos/RyDroid/desmume/events","assignees_url":"https://api.github.com/repos/RyDroid/desmume/assignees{/user}","branches_url":"https://api.github.com/repos/RyDroid/desmume/branches{/branch}","tags_url":"https://api.github.com/repos/RyDroid/desmume/tags","blobs_url":"https://api.github.com/repos/RyDroid/desmume/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RyDroid/desmume/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RyDroid/desmume/git/refs{/sha}","trees_url":"https://api.github.com/repos/RyDroid/desmume/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RyDroid/desmume/statuses/{sha}","languages_url":"https://api.github.com/repos/RyDroid/desmume/languages","stargazers_url":"https://api.github.com/repos/RyDroid/desmume/stargazers","contributors_url":"https://api.github.com/repos/RyDroid/desmume/contributors","subscribers_url":"https://api.github.com/repos/RyDroid/desmume/subscribers","subscription_url":"https://api.github.com/repos/RyDroid/desmume/subscription","commits_url":"https://api.github.com/repos/RyDroid/desmume/commits{/sha}","git_commits_url":"https://api.github.com/repos/RyDroid/desmume/git/commits{/sha}","comments_url":"https://api.github.com/repos/RyDroid/desmume/comments{/number}","issue_comment_url":"https://api.github.com/repos/RyDroid/desmume/issues/comments{/number}","contents_url":"https://api.github.com/repos/RyDroid/desmume/contents/{+path}","compare_url":"https://api.github.com/repos/RyDroid/desmume/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RyDroid/desmume/merges","archive_url":"https://api.github.com/repos/RyDroid/desmume/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RyDroid/desmume/downloads","issues_url":"https://api.github.com/repos/RyDroid/desmume/issues{/number}","pulls_url":"https://api.github.com/repos/RyDroid/desmume/pulls{/number}","milestones_url":"https://api.github.com/repos/RyDroid/desmume/milestones{/number}","notifications_url":"https://api.github.com/repos/RyDroid/desmume/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RyDroid/desmume/labels{/name}","releases_url":"https://api.github.com/repos/RyDroid/desmume/releases{/id}","deployments_url":"https://api.github.com/repos/RyDroid/desmume/deployments","created_at":"2017-04-27T15:59:44Z","updated_at":"2017-04-27T15:59:54Z","pushed_at":"2017-08-12T20:59:28Z","git_url":"git://github.com/RyDroid/desmume.git","ssh_url":"[email protected]:RyDroid/desmume.git","clone_url":"https://github.com/RyDroid/desmume.git","svn_url":"https://github.com/RyDroid/desmume","homepage":"http://desmume.org","size":72028,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TASVideos:master","ref":"master","sha":"623d490393fd2c5e7934c930e1293a3c2facb91c","user":{"login":"TASVideos","id":11743303,"avatar_url":"https://avatars0.githubusercontent.com/u/11743303?v=4","gravatar_id":"","url":"https://api.github.com/users/TASVideos","html_url":"https://github.com/TASVideos","followers_url":"https://api.github.com/users/TASVideos/followers","following_url":"https://api.github.com/users/TASVideos/following{/other_user}","gists_url":"https://api.github.com/users/TASVideos/gists{/gist_id}","starred_url":"https://api.github.com/users/TASVideos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TASVideos/subscriptions","organizations_url":"https://api.github.com/users/TASVideos/orgs","repos_url":"https://api.github.com/users/TASVideos/repos","events_url":"https://api.github.com/users/TASVideos/events{/privacy}","received_events_url":"https://api.github.com/users/TASVideos/received_events","type":"Organization","site_admin":false},"repo":{"id":74630515,"name":"desmume","full_name":"TASVideos/desmume","owner":{"login":"TASVideos","id":11743303,"avatar_url":"https://avatars0.githubusercontent.com/u/11743303?v=4","gravatar_id":"","url":"https://api.github.com/users/TASVideos","html_url":"https://github.com/TASVideos","followers_url":"https://api.github.com/users/TASVideos/followers","following_url":"https://api.github.com/users/TASVideos/following{/other_user}","gists_url":"https://api.github.com/users/TASVideos/gists{/gist_id}","starred_url":"https://api.github.com/users/TASVideos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TASVideos/subscriptions","organizations_url":"https://api.github.com/users/TASVideos/orgs","repos_url":"https://api.github.com/users/TASVideos/repos","events_url":"https://api.github.com/users/TASVideos/events{/privacy}","received_events_url":"https://api.github.com/users/TASVideos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TASVideos/desmume","description":"DeSmuME is a Nintendo DS emulator","fork":false,"url":"https://api.github.com/repos/TASVideos/desmume","forks_url":"https://api.github.com/repos/TASVideos/desmume/forks","keys_url":"https://api.github.com/repos/TASVideos/desmume/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TASVideos/desmume/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TASVideos/desmume/teams","hooks_url":"https://api.github.com/repos/TASVideos/desmume/hooks","issue_events_url":"https://api.github.com/repos/TASVideos/desmume/issues/events{/number}","events_url":"https://api.github.com/repos/TASVideos/desmume/events","assignees_url":"https://api.github.com/repos/TASVideos/desmume/assignees{/user}","branches_url":"https://api.github.com/repos/TASVideos/desmume/branches{/branch}","tags_url":"https://api.github.com/repos/TASVideos/desmume/tags","blobs_url":"https://api.github.com/repos/TASVideos/desmume/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TASVideos/desmume/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TASVideos/desmume/git/refs{/sha}","trees_url":"https://api.github.com/repos/TASVideos/desmume/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TASVideos/desmume/statuses/{sha}","languages_url":"https://api.github.com/repos/TASVideos/desmume/languages","stargazers_url":"https://api.github.com/repos/TASVideos/desmume/stargazers","contributors_url":"https://api.github.com/repos/TASVideos/desmume/contributors","subscribers_url":"https://api.github.com/repos/TASVideos/desmume/subscribers","subscription_url":"https://api.github.com/repos/TASVideos/desmume/subscription","commits_url":"https://api.github.com/repos/TASVideos/desmume/commits{/sha}","git_commits_url":"https://api.github.com/repos/TASVideos/desmume/git/commits{/sha}","comments_url":"https://api.github.com/repos/TASVideos/desmume/comments{/number}","issue_comment_url":"https://api.github.com/repos/TASVideos/desmume/issues/comments{/number}","contents_url":"https://api.github.com/repos/TASVideos/desmume/contents/{+path}","compare_url":"https://api.github.com/repos/TASVideos/desmume/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TASVideos/desmume/merges","archive_url":"https://api.github.com/repos/TASVideos/desmume/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TASVideos/desmume/downloads","issues_url":"https://api.github.com/repos/TASVideos/desmume/issues{/number}","pulls_url":"https://api.github.com/repos/TASVideos/desmume/pulls{/number}","milestones_url":"https://api.github.com/repos/TASVideos/desmume/milestones{/number}","notifications_url":"https://api.github.com/repos/TASVideos/desmume/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TASVideos/desmume/labels{/name}","releases_url":"https://api.github.com/repos/TASVideos/desmume/releases{/id}","deployments_url":"https://api.github.com/repos/TASVideos/desmume/deployments","created_at":"2016-11-24T02:20:36Z","updated_at":"2017-08-08T16:31:43Z","pushed_at":"2017-08-13T06:05:55Z","git_url":"git://github.com/TASVideos/desmume.git","ssh_url":"[email protected]:TASVideos/desmume.git","clone_url":"https://github.com/TASVideos/desmume.git","svn_url":"https://github.com/TASVideos/desmume","homepage":"http://desmume.org","size":80616,"stargazers_count":124,"watchers_count":124,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":18,"forks":39,"open_issues":18,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TASVideos/desmume/pulls/91"},"html":{"href":"https://github.com/TASVideos/desmume/pull/91"},"issue":{"href":"https://api.github.com/repos/TASVideos/desmume/issues/91"},"comments":{"href":"https://api.github.com/repos/TASVideos/desmume/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/TASVideos/desmume/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/TASVideos/desmume/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TASVideos/desmume/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/TASVideos/desmume/statuses/25615a6506f149995bbd73c3194c782f9476d286"}}}} | {
"id": 74630515,
"name": "TASVideos/desmume",
"url": "https://api.github.com/repos/TASVideos/desmume"
} | {
"id": 4244587,
"login": "RyDroid",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4244587?",
"url": "https://api.github.com/users/RyDroid"
} | {
"id": 11743303,
"login": "TASVideos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11743303?",
"url": "https://api.github.com/orgs/TASVideos"
} | 2017-08-14T20:32:47 | 6450508307 | {"actor":{"display_login":"RyDroid"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/127925329","pull_request_review_id":50554843,"id":127925329,"diff_hunk":"@@ -458,4 +457,10 @@ public static String convertToRequiredFormat(String date, String hour, String mi\n \n }\n \n+ public static TimeZone getTimeZoneFromDoubleOffset(double sessionTimeZone) {\n+ int hours = (int) sessionTimeZone;\n+ int minutes = (int) ((Math.abs(sessionTimeZone) - Math.floor(Math.abs(sessionTimeZone))) * 60);\n+ return TimeZone.getTimeZone(String.format(\"GMT%+03d:%02d\", hours, minutes));","path":"src/main/java/teammates/common/util/TimeHelper.java","position":35,"original_position":35,"commit_id":"3fae35770563fb6f6866ef4ddc94fc3ee96a1e65","original_commit_id":"3fae35770563fb6f6866ef4ddc94fc3ee96a1e65","user":{"login":"HirdayGupta","id":18088721,"avatar_url":"https://avatars2.githubusercontent.com/u/18088721?v=4","gravatar_id":"","url":"https://api.github.com/users/HirdayGupta","html_url":"https://github.com/HirdayGupta","followers_url":"https://api.github.com/users/HirdayGupta/followers","following_url":"https://api.github.com/users/HirdayGupta/following{/other_user}","gists_url":"https://api.github.com/users/HirdayGupta/gists{/gist_id}","starred_url":"https://api.github.com/users/HirdayGupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HirdayGupta/subscriptions","organizations_url":"https://api.github.com/users/HirdayGupta/orgs","repos_url":"https://api.github.com/users/HirdayGupta/repos","events_url":"https://api.github.com/users/HirdayGupta/events{/privacy}","received_events_url":"https://api.github.com/users/HirdayGupta/received_events","type":"User","site_admin":false},"body":"Can change from GMT to UTC?","created_at":"2017-07-18T09:27:33Z","updated_at":"2017-07-18T09:27:33Z","html_url":"https://github.com/TEAMMATES/teammates/pull/7616#discussion_r127925329","pull_request_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7616","_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/127925329"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/7616#discussion_r127925329"},"pull_request":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7616"}}},"pull_request":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7616","id":127628954,"html_url":"https://github.com/TEAMMATES/teammates/pull/7616","diff_url":"https://github.com/TEAMMATES/teammates/pull/7616.diff","patch_url":"https://github.com/TEAMMATES/teammates/pull/7616.patch","issue_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/7616","number":7616,"state":"open","locked":false,"title":"Display comment time in the session's time zone #4488","user":{"login":"Mynk96","id":17481466,"avatar_url":"https://avatars2.githubusercontent.com/u/17481466?v=4","gravatar_id":"","url":"https://api.github.com/users/Mynk96","html_url":"https://github.com/Mynk96","followers_url":"https://api.github.com/users/Mynk96/followers","following_url":"https://api.github.com/users/Mynk96/following{/other_user}","gists_url":"https://api.github.com/users/Mynk96/gists{/gist_id}","starred_url":"https://api.github.com/users/Mynk96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mynk96/subscriptions","organizations_url":"https://api.github.com/users/Mynk96/orgs","repos_url":"https://api.github.com/users/Mynk96/repos","events_url":"https://api.github.com/users/Mynk96/events{/privacy}","received_events_url":"https://api.github.com/users/Mynk96/received_events","type":"User","site_admin":false},"body":"Fixes #4488 ","created_at":"2017-06-27T07:35:38Z","updated_at":"2017-07-18T09:27:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55ee1d842a28055e9ebbdf852edccf3c685a3c03","assignee":{"login":"leeyimin","id":6365864,"avatar_url":"https://avatars3.githubusercontent.com/u/6365864?v=4","gravatar_id":"","url":"https://api.github.com/users/leeyimin","html_url":"https://github.com/leeyimin","followers_url":"https://api.github.com/users/leeyimin/followers","following_url":"https://api.github.com/users/leeyimin/following{/other_user}","gists_url":"https://api.github.com/users/leeyimin/gists{/gist_id}","starred_url":"https://api.github.com/users/leeyimin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeyimin/subscriptions","organizations_url":"https://api.github.com/users/leeyimin/orgs","repos_url":"https://api.github.com/users/leeyimin/repos","events_url":"https://api.github.com/users/leeyimin/events{/privacy}","received_events_url":"https://api.github.com/users/leeyimin/received_events","type":"User","site_admin":false},"assignees":[{"login":"leeyimin","id":6365864,"avatar_url":"https://avatars3.githubusercontent.com/u/6365864?v=4","gravatar_id":"","url":"https://api.github.com/users/leeyimin","html_url":"https://github.com/leeyimin","followers_url":"https://api.github.com/users/leeyimin/followers","following_url":"https://api.github.com/users/leeyimin/following{/other_user}","gists_url":"https://api.github.com/users/leeyimin/gists{/gist_id}","starred_url":"https://api.github.com/users/leeyimin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeyimin/subscriptions","organizations_url":"https://api.github.com/users/leeyimin/orgs","repos_url":"https://api.github.com/users/leeyimin/repos","events_url":"https://api.github.com/users/leeyimin/events{/privacy}","received_events_url":"https://api.github.com/users/leeyimin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/TEAMMATES/teammates/milestones/253","html_url":"https://github.com/TEAMMATES/teammates/milestone/253","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/milestones/253/labels","id":2607622,"number":253,"title":"V5.110","description":"Release 261","creator":{"login":"whipermr5","id":6811428,"avatar_url":"https://avatars0.githubusercontent.com/u/6811428?v=4","gravatar_id":"","url":"https://api.github.com/users/whipermr5","html_url":"https://github.com/whipermr5","followers_url":"https://api.github.com/users/whipermr5/followers","following_url":"https://api.github.com/users/whipermr5/following{/other_user}","gists_url":"https://api.github.com/users/whipermr5/gists{/gist_id}","starred_url":"https://api.github.com/users/whipermr5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whipermr5/subscriptions","organizations_url":"https://api.github.com/users/whipermr5/orgs","repos_url":"https://api.github.com/users/whipermr5/repos","events_url":"https://api.github.com/users/whipermr5/events{/privacy}","received_events_url":"https://api.github.com/users/whipermr5/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":0,"state":"open","created_at":"2017-06-27T16:00:06Z","updated_at":"2017-07-18T08:56:25Z","due_on":"2017-07-28T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7616/commits","review_comments_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7616/comments","review_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/7616/comments","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/3fae35770563fb6f6866ef4ddc94fc3ee96a1e65","head":{"label":"Mynk96:4488-Display-comment-time-in-the-session-time-zone","ref":"4488-Display-comment-time-in-the-session-time-zone","sha":"3fae35770563fb6f6866ef4ddc94fc3ee96a1e65","user":{"login":"Mynk96","id":17481466,"avatar_url":"https://avatars2.githubusercontent.com/u/17481466?v=4","gravatar_id":"","url":"https://api.github.com/users/Mynk96","html_url":"https://github.com/Mynk96","followers_url":"https://api.github.com/users/Mynk96/followers","following_url":"https://api.github.com/users/Mynk96/following{/other_user}","gists_url":"https://api.github.com/users/Mynk96/gists{/gist_id}","starred_url":"https://api.github.com/users/Mynk96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mynk96/subscriptions","organizations_url":"https://api.github.com/users/Mynk96/orgs","repos_url":"https://api.github.com/users/Mynk96/repos","events_url":"https://api.github.com/users/Mynk96/events{/privacy}","received_events_url":"https://api.github.com/users/Mynk96/received_events","type":"User","site_admin":false},"repo":{"id":88467207,"name":"teammates","full_name":"Mynk96/teammates","owner":{"login":"Mynk96","id":17481466,"avatar_url":"https://avatars2.githubusercontent.com/u/17481466?v=4","gravatar_id":"","url":"https://api.github.com/users/Mynk96","html_url":"https://github.com/Mynk96","followers_url":"https://api.github.com/users/Mynk96/followers","following_url":"https://api.github.com/users/Mynk96/following{/other_user}","gists_url":"https://api.github.com/users/Mynk96/gists{/gist_id}","starred_url":"https://api.github.com/users/Mynk96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mynk96/subscriptions","organizations_url":"https://api.github.com/users/Mynk96/orgs","repos_url":"https://api.github.com/users/Mynk96/repos","events_url":"https://api.github.com/users/Mynk96/events{/privacy}","received_events_url":"https://api.github.com/users/Mynk96/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mynk96/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":true,"url":"https://api.github.com/repos/Mynk96/teammates","forks_url":"https://api.github.com/repos/Mynk96/teammates/forks","keys_url":"https://api.github.com/repos/Mynk96/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mynk96/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mynk96/teammates/teams","hooks_url":"https://api.github.com/repos/Mynk96/teammates/hooks","issue_events_url":"https://api.github.com/repos/Mynk96/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/Mynk96/teammates/events","assignees_url":"https://api.github.com/repos/Mynk96/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/Mynk96/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/Mynk96/teammates/tags","blobs_url":"https://api.github.com/repos/Mynk96/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mynk96/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mynk96/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mynk96/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mynk96/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/Mynk96/teammates/languages","stargazers_url":"https://api.github.com/repos/Mynk96/teammates/stargazers","contributors_url":"https://api.github.com/repos/Mynk96/teammates/contributors","subscribers_url":"https://api.github.com/repos/Mynk96/teammates/subscribers","subscription_url":"https://api.github.com/repos/Mynk96/teammates/subscription","commits_url":"https://api.github.com/repos/Mynk96/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mynk96/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mynk96/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mynk96/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mynk96/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/Mynk96/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mynk96/teammates/merges","archive_url":"https://api.github.com/repos/Mynk96/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mynk96/teammates/downloads","issues_url":"https://api.github.com/repos/Mynk96/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/Mynk96/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/Mynk96/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/Mynk96/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mynk96/teammates/labels{/name}","releases_url":"https://api.github.com/repos/Mynk96/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/Mynk96/teammates/deployments","created_at":"2017-04-17T04:13:06Z","updated_at":"2017-04-17T04:13:12Z","pushed_at":"2017-07-18T06:38:31Z","git_url":"git://github.com/Mynk96/teammates.git","ssh_url":"[email protected]:Mynk96/teammates.git","clone_url":"https://github.com/Mynk96/teammates.git","svn_url":"https://github.com/Mynk96/teammates","homepage":"http://teammatesv4.appspot.com/","size":187405,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TEAMMATES:master","ref":"master","sha":"56b26f9bd4bec31a0024812abee6163880f59864","user":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars2.githubusercontent.com/u/7374810?v=4","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"name":"teammates","full_name":"TEAMMATES/teammates","owner":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars2.githubusercontent.com/u/7374810?v=4","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":false,"url":"https://api.github.com/repos/TEAMMATES/teammates","forks_url":"https://api.github.com/repos/TEAMMATES/teammates/forks","keys_url":"https://api.github.com/repos/TEAMMATES/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/teammates/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/teammates/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/teammates/events","assignees_url":"https://api.github.com/repos/TEAMMATES/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/teammates/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/teammates/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/teammates/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/teammates/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/teammates/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/teammates/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/TEAMMATES/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/teammates/merges","archive_url":"https://api.github.com/repos/TEAMMATES/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/teammates/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/TEAMMATES/teammates/deployments","created_at":"2014-05-02T07:43:00Z","updated_at":"2017-07-17T14:05:57Z","pushed_at":"2017-07-18T09:25:59Z","git_url":"git://github.com/TEAMMATES/teammates.git","ssh_url":"[email protected]:TEAMMATES/teammates.git","clone_url":"https://github.com/TEAMMATES/teammates.git","svn_url":"https://github.com/TEAMMATES/teammates","homepage":"https://teammatesv4.appspot.com/","size":189065,"stargazers_count":375,"watchers_count":375,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":867,"mirror_url":null,"open_issues_count":292,"forks":867,"open_issues":292,"watchers":375,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7616"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/7616"},"issue":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/7616"},"comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/7616/comments"},"review_comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7616/comments"},"review_comment":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7616/commits"},"statuses":{"href":"https://api.github.com/repos/TEAMMATES/teammates/statuses/3fae35770563fb6f6866ef4ddc94fc3ee96a1e65"}}}} | {
"id": 19369035,
"name": "TEAMMATES/teammates",
"url": "https://api.github.com/repos/TEAMMATES/teammates"
} | {
"id": 18088721,
"login": "HirdayGupta",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18088721?",
"url": "https://api.github.com/users/HirdayGupta"
} | {
"id": 7374810,
"login": "TEAMMATES",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7374810?",
"url": "https://api.github.com/orgs/TEAMMATES"
} | 2017-07-18T09:27:33 | 6276392180 | {"actor":{"display_login":"HirdayGupta"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/99277338","pull_request_review_id":19949114,"id":99277338,"diff_hunk":"@@ -314,36 +336,30 @@ private static String trimIfNotNull(String string) {\n * @param text\n * @return safer version of the text for XPath\n */\n- public static String convertStringForXPath(String text) {\n+ public static String sanitizeStringForXPath(String text) {\n StringBuilder result = new StringBuilder();\n- int startPos = 0;\n- int i = 0;\n- while (i < text.length()) {\n- while (i < text.length() && text.charAt(i) != '\\'') {\n- i++;\n- }\n- if (startPos < i) {\n- result.append('\\'').append(text.substring(startPos, i)).append(\"',\");\n- startPos = i;\n+ int startOfChain = 0;\n+ int textLength = text.length();\n+ boolean isSingleQuotationChain = false;\n+ // currentPos iterates one position beyond text length to include last chain\n+ for (int currentPos = 0; currentPos <= textLength; currentPos++) {\n+ boolean isChainBroken = currentPos >= textLength\n+ || isSingleQuotationChain && text.charAt(currentPos) != '\\''\n+ || !isSingleQuotationChain && text.charAt(currentPos) == '\\'';","path":"src/main/java/teammates/common/util/SanitizationHelper.java","position":240,"original_position":240,"commit_id":"c73050a21039561c9b70eae28e775401758f0a77","original_commit_id":"c73050a21039561c9b70eae28e775401758f0a77","user":{"login":"samsontmr","id":15007950,"avatar_url":"https://avatars.githubusercontent.com/u/15007950?v=3","gravatar_id":"","url":"https://api.github.com/users/samsontmr","html_url":"https://github.com/samsontmr","followers_url":"https://api.github.com/users/samsontmr/followers","following_url":"https://api.github.com/users/samsontmr/following{/other_user}","gists_url":"https://api.github.com/users/samsontmr/gists{/gist_id}","starred_url":"https://api.github.com/users/samsontmr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsontmr/subscriptions","organizations_url":"https://api.github.com/users/samsontmr/orgs","repos_url":"https://api.github.com/users/samsontmr/repos","events_url":"https://api.github.com/users/samsontmr/events{/privacy}","received_events_url":"https://api.github.com/users/samsontmr/received_events","type":"User","site_admin":false},"body":"Here as well, I suggest the `||` be in line with the `c` of `currentPos` for readability","created_at":"2017-02-03T05:04:01Z","updated_at":"2017-02-03T05:25:44Z","html_url":"https://github.com/TEAMMATES/teammates/pull/6523#discussion_r99277338","pull_request_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/6523","_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/99277338"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/6523#discussion_r99277338"},"pull_request":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/6523"}}},"pull_request":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/6523","id":104194564,"html_url":"https://github.com/TEAMMATES/teammates/pull/6523","diff_url":"https://github.com/TEAMMATES/teammates/pull/6523.diff","patch_url":"https://github.com/TEAMMATES/teammates/pull/6523.patch","issue_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/6523","number":6523,"state":"open","locked":false,"title":"Refactor StringHelper and Sanitizer class #6518","user":{"login":"leeyimin","id":6365864,"avatar_url":"https://avatars.githubusercontent.com/u/6365864?v=3","gravatar_id":"","url":"https://api.github.com/users/leeyimin","html_url":"https://github.com/leeyimin","followers_url":"https://api.github.com/users/leeyimin/followers","following_url":"https://api.github.com/users/leeyimin/following{/other_user}","gists_url":"https://api.github.com/users/leeyimin/gists{/gist_id}","starred_url":"https://api.github.com/users/leeyimin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeyimin/subscriptions","organizations_url":"https://api.github.com/users/leeyimin/orgs","repos_url":"https://api.github.com/users/leeyimin/repos","events_url":"https://api.github.com/users/leeyimin/events{/privacy}","received_events_url":"https://api.github.com/users/leeyimin/received_events","type":"User","site_admin":false},"body":"Fixes #6518\r\n\r\n- [x] Combine sanitize and desanitizer functions under SanitizationHelper\r\n- [x] Shift sanitization-unrelated methods to StringHelper\r\n- [ ] Add tests for untested sanitization and desanitization methods\r\n<!--\r\nPlease follow the naming conventions in the \"guidelines for contributing\" link above or the pull request may be rejected.\r\n\r\nAlso, do consider outlining the solution taken as doing so will likely help in the reviewing process\r\n(e.g., when the pull request involves non-trivial changes)\r\n-->\r\n","created_at":"2017-02-01T18:33:21Z","updated_at":"2017-02-03T05:25:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28f198c61631044f5ffdf380ad75012f4d4a3c14","assignee":{"login":"wkurniawan07","id":7261051,"avatar_url":"https://avatars.githubusercontent.com/u/7261051?v=3","gravatar_id":"","url":"https://api.github.com/users/wkurniawan07","html_url":"https://github.com/wkurniawan07","followers_url":"https://api.github.com/users/wkurniawan07/followers","following_url":"https://api.github.com/users/wkurniawan07/following{/other_user}","gists_url":"https://api.github.com/users/wkurniawan07/gists{/gist_id}","starred_url":"https://api.github.com/users/wkurniawan07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkurniawan07/subscriptions","organizations_url":"https://api.github.com/users/wkurniawan07/orgs","repos_url":"https://api.github.com/users/wkurniawan07/repos","events_url":"https://api.github.com/users/wkurniawan07/events{/privacy}","received_events_url":"https://api.github.com/users/wkurniawan07/received_events","type":"User","site_admin":false},"assignees":[{"login":"wkurniawan07","id":7261051,"avatar_url":"https://avatars.githubusercontent.com/u/7261051?v=3","gravatar_id":"","url":"https://api.github.com/users/wkurniawan07","html_url":"https://github.com/wkurniawan07","followers_url":"https://api.github.com/users/wkurniawan07/followers","following_url":"https://api.github.com/users/wkurniawan07/following{/other_user}","gists_url":"https://api.github.com/users/wkurniawan07/gists{/gist_id}","starred_url":"https://api.github.com/users/wkurniawan07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkurniawan07/subscriptions","organizations_url":"https://api.github.com/users/wkurniawan07/orgs","repos_url":"https://api.github.com/users/wkurniawan07/repos","events_url":"https://api.github.com/users/wkurniawan07/events{/privacy}","received_events_url":"https://api.github.com/users/wkurniawan07/received_events","type":"User","site_admin":false},{"login":"boxin-yang","id":16921967,"avatar_url":"https://avatars.githubusercontent.com/u/16921967?v=3","gravatar_id":"","url":"https://api.github.com/users/boxin-yang","html_url":"https://github.com/boxin-yang","followers_url":"https://api.github.com/users/boxin-yang/followers","following_url":"https://api.github.com/users/boxin-yang/following{/other_user}","gists_url":"https://api.github.com/users/boxin-yang/gists{/gist_id}","starred_url":"https://api.github.com/users/boxin-yang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boxin-yang/subscriptions","organizations_url":"https://api.github.com/users/boxin-yang/orgs","repos_url":"https://api.github.com/users/boxin-yang/repos","events_url":"https://api.github.com/users/boxin-yang/events{/privacy}","received_events_url":"https://api.github.com/users/boxin-yang/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/6523/commits","review_comments_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/6523/comments","review_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/6523/comments","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/c73050a21039561c9b70eae28e775401758f0a77","head":{"label":"leeyimin:6518-refactor-sanitizer","ref":"6518-refactor-sanitizer","sha":"c73050a21039561c9b70eae28e775401758f0a77","user":{"login":"leeyimin","id":6365864,"avatar_url":"https://avatars.githubusercontent.com/u/6365864?v=3","gravatar_id":"","url":"https://api.github.com/users/leeyimin","html_url":"https://github.com/leeyimin","followers_url":"https://api.github.com/users/leeyimin/followers","following_url":"https://api.github.com/users/leeyimin/following{/other_user}","gists_url":"https://api.github.com/users/leeyimin/gists{/gist_id}","starred_url":"https://api.github.com/users/leeyimin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeyimin/subscriptions","organizations_url":"https://api.github.com/users/leeyimin/orgs","repos_url":"https://api.github.com/users/leeyimin/repos","events_url":"https://api.github.com/users/leeyimin/events{/privacy}","received_events_url":"https://api.github.com/users/leeyimin/received_events","type":"User","site_admin":false},"repo":{"id":78658959,"name":"teammates","full_name":"leeyimin/teammates","owner":{"login":"leeyimin","id":6365864,"avatar_url":"https://avatars.githubusercontent.com/u/6365864?v=3","gravatar_id":"","url":"https://api.github.com/users/leeyimin","html_url":"https://github.com/leeyimin","followers_url":"https://api.github.com/users/leeyimin/followers","following_url":"https://api.github.com/users/leeyimin/following{/other_user}","gists_url":"https://api.github.com/users/leeyimin/gists{/gist_id}","starred_url":"https://api.github.com/users/leeyimin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeyimin/subscriptions","organizations_url":"https://api.github.com/users/leeyimin/orgs","repos_url":"https://api.github.com/users/leeyimin/repos","events_url":"https://api.github.com/users/leeyimin/events{/privacy}","received_events_url":"https://api.github.com/users/leeyimin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leeyimin/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":true,"url":"https://api.github.com/repos/leeyimin/teammates","forks_url":"https://api.github.com/repos/leeyimin/teammates/forks","keys_url":"https://api.github.com/repos/leeyimin/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leeyimin/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leeyimin/teammates/teams","hooks_url":"https://api.github.com/repos/leeyimin/teammates/hooks","issue_events_url":"https://api.github.com/repos/leeyimin/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/leeyimin/teammates/events","assignees_url":"https://api.github.com/repos/leeyimin/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/leeyimin/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/leeyimin/teammates/tags","blobs_url":"https://api.github.com/repos/leeyimin/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leeyimin/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leeyimin/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/leeyimin/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leeyimin/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/leeyimin/teammates/languages","stargazers_url":"https://api.github.com/repos/leeyimin/teammates/stargazers","contributors_url":"https://api.github.com/repos/leeyimin/teammates/contributors","subscribers_url":"https://api.github.com/repos/leeyimin/teammates/subscribers","subscription_url":"https://api.github.com/repos/leeyimin/teammates/subscription","commits_url":"https://api.github.com/repos/leeyimin/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/leeyimin/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/leeyimin/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/leeyimin/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/leeyimin/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/leeyimin/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leeyimin/teammates/merges","archive_url":"https://api.github.com/repos/leeyimin/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leeyimin/teammates/downloads","issues_url":"https://api.github.com/repos/leeyimin/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/leeyimin/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/leeyimin/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/leeyimin/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leeyimin/teammates/labels{/name}","releases_url":"https://api.github.com/repos/leeyimin/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/leeyimin/teammates/deployments","created_at":"2017-01-11T16:47:00Z","updated_at":"2017-01-11T16:47:07Z","pushed_at":"2017-02-03T04:58:35Z","git_url":"git://github.com/leeyimin/teammates.git","ssh_url":"[email protected]:leeyimin/teammates.git","clone_url":"https://github.com/leeyimin/teammates.git","svn_url":"https://github.com/leeyimin/teammates","homepage":"http://teammatesv4.appspot.com/","size":172983,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TEAMMATES:master","ref":"master","sha":"ef5d21e4508fc210dc8d63d837d6de05d8b19327","user":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"name":"teammates","full_name":"TEAMMATES/teammates","owner":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":false,"url":"https://api.github.com/repos/TEAMMATES/teammates","forks_url":"https://api.github.com/repos/TEAMMATES/teammates/forks","keys_url":"https://api.github.com/repos/TEAMMATES/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/teammates/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/teammates/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/teammates/events","assignees_url":"https://api.github.com/repos/TEAMMATES/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/teammates/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/teammates/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/teammates/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/teammates/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/teammates/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/teammates/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/TEAMMATES/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/teammates/merges","archive_url":"https://api.github.com/repos/TEAMMATES/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/teammates/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/TEAMMATES/teammates/deployments","created_at":"2014-05-02T07:43:00Z","updated_at":"2017-02-03T00:09:46Z","pushed_at":"2017-02-03T04:58:37Z","git_url":"git://github.com/TEAMMATES/teammates.git","ssh_url":"[email protected]:TEAMMATES/teammates.git","clone_url":"https://github.com/TEAMMATES/teammates.git","svn_url":"https://github.com/TEAMMATES/teammates","homepage":"http://teammatesv4.appspot.com/","size":175588,"stargazers_count":226,"watchers_count":226,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":508,"mirror_url":null,"open_issues_count":489,"forks":508,"open_issues":489,"watchers":226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/6523"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/6523"},"issue":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/6523"},"comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/6523/comments"},"review_comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/6523/comments"},"review_comment":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/6523/commits"},"statuses":{"href":"https://api.github.com/repos/TEAMMATES/teammates/statuses/c73050a21039561c9b70eae28e775401758f0a77"}}}} | {
"id": 19369035,
"name": "TEAMMATES/teammates",
"url": "https://api.github.com/repos/TEAMMATES/teammates"
} | {
"id": 15007950,
"login": "samsontmr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15007950?",
"url": "https://api.github.com/users/samsontmr"
} | {
"id": 7374810,
"login": "TEAMMATES",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7374810?",
"url": "https://api.github.com/orgs/TEAMMATES"
} | 2017-02-03T05:04:01 | 5259659258 | {"actor":{"display_login":"samsontmr"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments/152300609","pull_request_review_id":78140681,"id":152300609,"diff_hunk":"@@ -73,6 +73,12 @@ function gutenberg_get_script_polyfill( $tests ) {\n * @since 0.1.0\n */\n function gutenberg_register_scripts_and_styles() {\n+\t// We need to return early when this GET variable is set. This happens when the editor loads the metaboxes and for\n+\t// this case we don't need to register scripts and styles.","path":"lib/client-assets.php","position":5,"original_position":5,"commit_id":"d4f40bfac155b552e7cf4ff2a087adeafa02c7cd","original_commit_id":"d4f40bfac155b552e7cf4ff2a087adeafa02c7cd","user":{"login":"youknowriad","id":272444,"avatar_url":"https://avatars3.githubusercontent.com/u/272444?v=4","gravatar_id":"","url":"https://api.github.com/users/youknowriad","html_url":"https://github.com/youknowriad","followers_url":"https://api.github.com/users/youknowriad/followers","following_url":"https://api.github.com/users/youknowriad/following{/other_user}","gists_url":"https://api.github.com/users/youknowriad/gists{/gist_id}","starred_url":"https://api.github.com/users/youknowriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youknowriad/subscriptions","organizations_url":"https://api.github.com/users/youknowriad/orgs","repos_url":"https://api.github.com/users/youknowriad/repos","events_url":"https://api.github.com/users/youknowriad/events{/privacy}","received_events_url":"https://api.github.com/users/youknowriad/received_events","type":"User","site_admin":false},"body":"Just curious how why we do not want to register the scripts and styles in this case? I mean why registering the scripts/styles breaks the desired output. If we register something it's not enqueued directly unless I'm missing something?","created_at":"2017-11-21T15:02:28Z","updated_at":"2017-11-21T15:02:28Z","html_url":"https://github.com/WordPress/gutenberg/pull/3593#discussion_r152300609","pull_request_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/3593","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments/152300609"},"html":{"href":"https://github.com/WordPress/gutenberg/pull/3593#discussion_r152300609"},"pull_request":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/3593"}}},"pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/3593","id":153910179,"html_url":"https://github.com/WordPress/gutenberg/pull/3593","diff_url":"https://github.com/WordPress/gutenberg/pull/3593.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/3593.patch","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/3593","number":3593,"state":"open","locked":false,"title":"Fix an issue where the editor specific styles are not applied when the metaboxes are loaded.","user":{"login":"kmgalanakis","id":1268089,"avatar_url":"https://avatars1.githubusercontent.com/u/1268089?v=4","gravatar_id":"","url":"https://api.github.com/users/kmgalanakis","html_url":"https://github.com/kmgalanakis","followers_url":"https://api.github.com/users/kmgalanakis/followers","following_url":"https://api.github.com/users/kmgalanakis/following{/other_user}","gists_url":"https://api.github.com/users/kmgalanakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kmgalanakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmgalanakis/subscriptions","organizations_url":"https://api.github.com/users/kmgalanakis/orgs","repos_url":"https://api.github.com/users/kmgalanakis/repos","events_url":"https://api.github.com/users/kmgalanakis/events{/privacy}","received_events_url":"https://api.github.com/users/kmgalanakis/received_events","type":"User","site_admin":false},"body":"## Description\r\nWhen loading the metaboxes the GET variable `classic-editor` is set to true to the `_wpMetaBoxUrl`. So when `admin_enqueue_scripts` is called then and Gutenberg initializes, the initialization ends soon as this GET variable is set. At that time while `gutenberg_register_scripts_and_styles` is executed, `gutenberg_editor_scripts_and_styles` is not, so this is why the editor specific styles are not applied.\r\n\r\n## How Has This Been Tested?\r\nVisual testing.\r\n\r\n## Types of changes\r\nFixes a bug.\r\n\r\n## Checklist:\r\n- [x] My code is tested.\r\n- [x] My code follows the WordPress code style.\r\n- [x] My code follows has proper inline documentation.","created_at":"2017-11-21T14:48:19Z","updated_at":"2017-11-21T15:02:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e445becb8836fa66203328b23570bc515c0e3a45","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/3593/commits","review_comments_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/3593/comments","review_comment_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/3593/comments","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/d4f40bfac155b552e7cf4ff2a087adeafa02c7cd","head":{"label":"kmgalanakis:fix/3592-editor-specific-styles","ref":"fix/3592-editor-specific-styles","sha":"d4f40bfac155b552e7cf4ff2a087adeafa02c7cd","user":{"login":"kmgalanakis","id":1268089,"avatar_url":"https://avatars1.githubusercontent.com/u/1268089?v=4","gravatar_id":"","url":"https://api.github.com/users/kmgalanakis","html_url":"https://github.com/kmgalanakis","followers_url":"https://api.github.com/users/kmgalanakis/followers","following_url":"https://api.github.com/users/kmgalanakis/following{/other_user}","gists_url":"https://api.github.com/users/kmgalanakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kmgalanakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmgalanakis/subscriptions","organizations_url":"https://api.github.com/users/kmgalanakis/orgs","repos_url":"https://api.github.com/users/kmgalanakis/repos","events_url":"https://api.github.com/users/kmgalanakis/events{/privacy}","received_events_url":"https://api.github.com/users/kmgalanakis/received_events","type":"User","site_admin":false},"repo":{"id":111559957,"name":"gutenberg","full_name":"kmgalanakis/gutenberg","owner":{"login":"kmgalanakis","id":1268089,"avatar_url":"https://avatars1.githubusercontent.com/u/1268089?v=4","gravatar_id":"","url":"https://api.github.com/users/kmgalanakis","html_url":"https://github.com/kmgalanakis","followers_url":"https://api.github.com/users/kmgalanakis/followers","following_url":"https://api.github.com/users/kmgalanakis/following{/other_user}","gists_url":"https://api.github.com/users/kmgalanakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kmgalanakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmgalanakis/subscriptions","organizations_url":"https://api.github.com/users/kmgalanakis/orgs","repos_url":"https://api.github.com/users/kmgalanakis/repos","events_url":"https://api.github.com/users/kmgalanakis/events{/privacy}","received_events_url":"https://api.github.com/users/kmgalanakis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kmgalanakis/gutenberg","description":"Printing since 1440. Development hub for the editor focus in core. Beta plugin is available from the official WordPress repository.","fork":true,"url":"https://api.github.com/repos/kmgalanakis/gutenberg","forks_url":"https://api.github.com/repos/kmgalanakis/gutenberg/forks","keys_url":"https://api.github.com/repos/kmgalanakis/gutenberg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kmgalanakis/gutenberg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kmgalanakis/gutenberg/teams","hooks_url":"https://api.github.com/repos/kmgalanakis/gutenberg/hooks","issue_events_url":"https://api.github.com/repos/kmgalanakis/gutenberg/issues/events{/number}","events_url":"https://api.github.com/repos/kmgalanakis/gutenberg/events","assignees_url":"https://api.github.com/repos/kmgalanakis/gutenberg/assignees{/user}","branches_url":"https://api.github.com/repos/kmgalanakis/gutenberg/branches{/branch}","tags_url":"https://api.github.com/repos/kmgalanakis/gutenberg/tags","blobs_url":"https://api.github.com/repos/kmgalanakis/gutenberg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kmgalanakis/gutenberg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kmgalanakis/gutenberg/git/refs{/sha}","trees_url":"https://api.github.com/repos/kmgalanakis/gutenberg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kmgalanakis/gutenberg/statuses/{sha}","languages_url":"https://api.github.com/repos/kmgalanakis/gutenberg/languages","stargazers_url":"https://api.github.com/repos/kmgalanakis/gutenberg/stargazers","contributors_url":"https://api.github.com/repos/kmgalanakis/gutenberg/contributors","subscribers_url":"https://api.github.com/repos/kmgalanakis/gutenberg/subscribers","subscription_url":"https://api.github.com/repos/kmgalanakis/gutenberg/subscription","commits_url":"https://api.github.com/repos/kmgalanakis/gutenberg/commits{/sha}","git_commits_url":"https://api.github.com/repos/kmgalanakis/gutenberg/git/commits{/sha}","comments_url":"https://api.github.com/repos/kmgalanakis/gutenberg/comments{/number}","issue_comment_url":"https://api.github.com/repos/kmgalanakis/gutenberg/issues/comments{/number}","contents_url":"https://api.github.com/repos/kmgalanakis/gutenberg/contents/{+path}","compare_url":"https://api.github.com/repos/kmgalanakis/gutenberg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kmgalanakis/gutenberg/merges","archive_url":"https://api.github.com/repos/kmgalanakis/gutenberg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kmgalanakis/gutenberg/downloads","issues_url":"https://api.github.com/repos/kmgalanakis/gutenberg/issues{/number}","pulls_url":"https://api.github.com/repos/kmgalanakis/gutenberg/pulls{/number}","milestones_url":"https://api.github.com/repos/kmgalanakis/gutenberg/milestones{/number}","notifications_url":"https://api.github.com/repos/kmgalanakis/gutenberg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kmgalanakis/gutenberg/labels{/name}","releases_url":"https://api.github.com/repos/kmgalanakis/gutenberg/releases{/id}","deployments_url":"https://api.github.com/repos/kmgalanakis/gutenberg/deployments","created_at":"2017-11-21T14:32:33Z","updated_at":"2017-11-21T14:32:36Z","pushed_at":"2017-11-21T14:47:07Z","git_url":"git://github.com/kmgalanakis/gutenberg.git","ssh_url":"[email protected]:kmgalanakis/gutenberg.git","clone_url":"https://github.com/kmgalanakis/gutenberg.git","svn_url":"https://github.com/kmgalanakis/gutenberg","homepage":"https://wordpress.org/plugins/gutenberg/ ","size":7135,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WordPress:master","ref":"master","sha":"359f11fc8b1671d25298b6b3a2dd7d44dd1d86e0","user":{"login":"WordPress","id":276006,"avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"repo":{"id":80862584,"name":"gutenberg","full_name":"WordPress/gutenberg","owner":{"login":"WordPress","id":276006,"avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WordPress/gutenberg","description":"Printing since 1440. Development hub for the editor focus in core. Beta plugin is available from the official WordPress repository.","fork":false,"url":"https://api.github.com/repos/WordPress/gutenberg","forks_url":"https://api.github.com/repos/WordPress/gutenberg/forks","keys_url":"https://api.github.com/repos/WordPress/gutenberg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WordPress/gutenberg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WordPress/gutenberg/teams","hooks_url":"https://api.github.com/repos/WordPress/gutenberg/hooks","issue_events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/events{/number}","events_url":"https://api.github.com/repos/WordPress/gutenberg/events","assignees_url":"https://api.github.com/repos/WordPress/gutenberg/assignees{/user}","branches_url":"https://api.github.com/repos/WordPress/gutenberg/branches{/branch}","tags_url":"https://api.github.com/repos/WordPress/gutenberg/tags","blobs_url":"https://api.github.com/repos/WordPress/gutenberg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WordPress/gutenberg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WordPress/gutenberg/git/refs{/sha}","trees_url":"https://api.github.com/repos/WordPress/gutenberg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/{sha}","languages_url":"https://api.github.com/repos/WordPress/gutenberg/languages","stargazers_url":"https://api.github.com/repos/WordPress/gutenberg/stargazers","contributors_url":"https://api.github.com/repos/WordPress/gutenberg/contributors","subscribers_url":"https://api.github.com/repos/WordPress/gutenberg/subscribers","subscription_url":"https://api.github.com/repos/WordPress/gutenberg/subscription","commits_url":"https://api.github.com/repos/WordPress/gutenberg/commits{/sha}","git_commits_url":"https://api.github.com/repos/WordPress/gutenberg/git/commits{/sha}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/comments{/number}","issue_comment_url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments{/number}","contents_url":"https://api.github.com/repos/WordPress/gutenberg/contents/{+path}","compare_url":"https://api.github.com/repos/WordPress/gutenberg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WordPress/gutenberg/merges","archive_url":"https://api.github.com/repos/WordPress/gutenberg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WordPress/gutenberg/downloads","issues_url":"https://api.github.com/repos/WordPress/gutenberg/issues{/number}","pulls_url":"https://api.github.com/repos/WordPress/gutenberg/pulls{/number}","milestones_url":"https://api.github.com/repos/WordPress/gutenberg/milestones{/number}","notifications_url":"https://api.github.com/repos/WordPress/gutenberg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WordPress/gutenberg/labels{/name}","releases_url":"https://api.github.com/repos/WordPress/gutenberg/releases{/id}","deployments_url":"https://api.github.com/repos/WordPress/gutenberg/deployments","created_at":"2017-02-03T19:34:19Z","updated_at":"2017-11-21T13:49:38Z","pushed_at":"2017-11-21T14:48:20Z","git_url":"git://github.com/WordPress/gutenberg.git","ssh_url":"[email protected]:WordPress/gutenberg.git","clone_url":"https://github.com/WordPress/gutenberg.git","svn_url":"https://github.com/WordPress/gutenberg","homepage":"https://wordpress.org/plugins/gutenberg/ ","size":7135,"stargazers_count":1280,"watchers_count":1280,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":260,"mirror_url":null,"archived":false,"open_issues_count":520,"forks":260,"open_issues":520,"watchers":1280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/3593"},"html":{"href":"https://github.com/WordPress/gutenberg/pull/3593"},"issue":{"href":"https://api.github.com/repos/WordPress/gutenberg/issues/3593"},"comments":{"href":"https://api.github.com/repos/WordPress/gutenberg/issues/3593/comments"},"review_comments":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/3593/comments"},"review_comment":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/3593/commits"},"statuses":{"href":"https://api.github.com/repos/WordPress/gutenberg/statuses/d4f40bfac155b552e7cf4ff2a087adeafa02c7cd"}},"author_association":"NONE"}} | {
"id": 80862584,
"name": "WordPress/gutenberg",
"url": "https://api.github.com/repos/WordPress/gutenberg"
} | {
"id": 272444,
"login": "youknowriad",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/272444?",
"url": "https://api.github.com/users/youknowriad"
} | {
"id": 276006,
"login": "WordPress",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/276006?",
"url": "https://api.github.com/orgs/WordPress"
} | 2017-11-21T15:02:28 | 6885060059 | {"actor":{"display_login":"youknowriad"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/all-of-us/workbench/pulls/comments/133535834","pull_request_review_id":56727747,"id":133535834,"diff_hunk":"@@ -184,6 +276,43 @@ definitions:\n description: levels of access to data in the curated data repository\n enum: &DATA_ACCESS_LEVEL [registered, protected]\n \n+ WorkspaceListResponse:\n+ type: \"object\"\n+ required:\n+ - \"items\"\n+ properties:\n+ items:\n+ type: \"array\"\n+ items:\n+ $ref: \"#/definitions/Workspace\"\n+\n+ Workspace:\n+ type: \"object\"\n+ required:\n+ - \"name\"\n+ - \"cohorts\"\n+ properties:\n+ id:\n+ type: string\n+ name:\n+ type: string\n+ namespace:\n+ type: string\n+ description:\n+ type: string\n+ creator:\n+ type: string\n+ creationTime:\n+ type: string\n+ format: date-time\n+ lastModifiedTime:\n+ type: string\n+ format: date-time","path":"api/src/main/resources/workbench.yaml","position":134,"original_position":134,"commit_id":"6bea777650ed36aab3c8d2f9f30aacacff330ea2","original_commit_id":"6bea777650ed36aab3c8d2f9f30aacacff330ea2","user":{"login":"danqrodney","id":12536316,"avatar_url":"https://avatars0.githubusercontent.com/u/12536316?v=4","gravatar_id":"","url":"https://api.github.com/users/danqrodney","html_url":"https://github.com/danqrodney","followers_url":"https://api.github.com/users/danqrodney/followers","following_url":"https://api.github.com/users/danqrodney/following{/other_user}","gists_url":"https://api.github.com/users/danqrodney/gists{/gist_id}","starred_url":"https://api.github.com/users/danqrodney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danqrodney/subscriptions","organizations_url":"https://api.github.com/users/danqrodney/orgs","repos_url":"https://api.github.com/users/danqrodney/repos","events_url":"https://api.github.com/users/danqrodney/events{/privacy}","received_events_url":"https://api.github.com/users/danqrodney/received_events","type":"User","site_admin":false},"body":"Other fields I think we'll want in here:\r\n\r\ndataAccessLevel (enum)\r\nresearchPurpose (enum)\r\ncdrVersionId (string)\r\n\r\nThough we could add these later.","created_at":"2017-08-16T18:51:28Z","updated_at":"2017-08-16T18:56:47Z","html_url":"https://github.com/all-of-us/workbench/pull/74#discussion_r133535834","pull_request_url":"https://api.github.com/repos/all-of-us/workbench/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/comments/133535834"},"html":{"href":"https://github.com/all-of-us/workbench/pull/74#discussion_r133535834"},"pull_request":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/all-of-us/workbench/pulls/74","id":135818111,"html_url":"https://github.com/all-of-us/workbench/pull/74","diff_url":"https://github.com/all-of-us/workbench/pull/74.diff","patch_url":"https://github.com/all-of-us/workbench/pull/74.patch","issue_url":"https://api.github.com/repos/all-of-us/workbench/issues/74","number":74,"state":"open","locked":false,"title":"Blrubenstein/workspaces swagger","user":{"login":"blrubenstein","id":15351021,"avatar_url":"https://avatars0.githubusercontent.com/u/15351021?v=4","gravatar_id":"","url":"https://api.github.com/users/blrubenstein","html_url":"https://github.com/blrubenstein","followers_url":"https://api.github.com/users/blrubenstein/followers","following_url":"https://api.github.com/users/blrubenstein/following{/other_user}","gists_url":"https://api.github.com/users/blrubenstein/gists{/gist_id}","starred_url":"https://api.github.com/users/blrubenstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blrubenstein/subscriptions","organizations_url":"https://api.github.com/users/blrubenstein/orgs","repos_url":"https://api.github.com/users/blrubenstein/repos","events_url":"https://api.github.com/users/blrubenstein/events{/privacy}","received_events_url":"https://api.github.com/users/blrubenstein/received_events","type":"User","site_admin":false},"body":"I generated the swagger classes that I imagine that we will use for workspaces. \r\n\r\nI'm holding off on the back-end code for that because I would like to talk more with Dan regarding interfacing with the Firecloud API/what our plans are regarding back-end code for workspace management.","created_at":"2017-08-15T14:53:14Z","updated_at":"2017-08-16T18:56:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6223836d4c011ca732bcfb284138596da2971be","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/all-of-us/workbench/pulls/74/commits","review_comments_url":"https://api.github.com/repos/all-of-us/workbench/pulls/74/comments","review_comment_url":"https://api.github.com/repos/all-of-us/workbench/pulls/comments{/number}","comments_url":"https://api.github.com/repos/all-of-us/workbench/issues/74/comments","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/6bea777650ed36aab3c8d2f9f30aacacff330ea2","head":{"label":"all-of-us:blrubenstein/workspaces-swagger","ref":"blrubenstein/workspaces-swagger","sha":"6bea777650ed36aab3c8d2f9f30aacacff330ea2","user":{"login":"all-of-us","id":22846942,"avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"repo":{"id":95247186,"name":"workbench","full_name":"all-of-us/workbench","owner":{"login":"all-of-us","id":22846942,"avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/all-of-us/workbench","description":null,"fork":false,"url":"https://api.github.com/repos/all-of-us/workbench","forks_url":"https://api.github.com/repos/all-of-us/workbench/forks","keys_url":"https://api.github.com/repos/all-of-us/workbench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all-of-us/workbench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all-of-us/workbench/teams","hooks_url":"https://api.github.com/repos/all-of-us/workbench/hooks","issue_events_url":"https://api.github.com/repos/all-of-us/workbench/issues/events{/number}","events_url":"https://api.github.com/repos/all-of-us/workbench/events","assignees_url":"https://api.github.com/repos/all-of-us/workbench/assignees{/user}","branches_url":"https://api.github.com/repos/all-of-us/workbench/branches{/branch}","tags_url":"https://api.github.com/repos/all-of-us/workbench/tags","blobs_url":"https://api.github.com/repos/all-of-us/workbench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all-of-us/workbench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all-of-us/workbench/git/refs{/sha}","trees_url":"https://api.github.com/repos/all-of-us/workbench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/{sha}","languages_url":"https://api.github.com/repos/all-of-us/workbench/languages","stargazers_url":"https://api.github.com/repos/all-of-us/workbench/stargazers","contributors_url":"https://api.github.com/repos/all-of-us/workbench/contributors","subscribers_url":"https://api.github.com/repos/all-of-us/workbench/subscribers","subscription_url":"https://api.github.com/repos/all-of-us/workbench/subscription","commits_url":"https://api.github.com/repos/all-of-us/workbench/commits{/sha}","git_commits_url":"https://api.github.com/repos/all-of-us/workbench/git/commits{/sha}","comments_url":"https://api.github.com/repos/all-of-us/workbench/comments{/number}","issue_comment_url":"https://api.github.com/repos/all-of-us/workbench/issues/comments{/number}","contents_url":"https://api.github.com/repos/all-of-us/workbench/contents/{+path}","compare_url":"https://api.github.com/repos/all-of-us/workbench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all-of-us/workbench/merges","archive_url":"https://api.github.com/repos/all-of-us/workbench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all-of-us/workbench/downloads","issues_url":"https://api.github.com/repos/all-of-us/workbench/issues{/number}","pulls_url":"https://api.github.com/repos/all-of-us/workbench/pulls{/number}","milestones_url":"https://api.github.com/repos/all-of-us/workbench/milestones{/number}","notifications_url":"https://api.github.com/repos/all-of-us/workbench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all-of-us/workbench/labels{/name}","releases_url":"https://api.github.com/repos/all-of-us/workbench/releases{/id}","deployments_url":"https://api.github.com/repos/all-of-us/workbench/deployments","created_at":"2017-06-23T18:44:24Z","updated_at":"2017-08-10T18:39:46Z","pushed_at":"2017-08-16T18:48:38Z","git_url":"git://github.com/all-of-us/workbench.git","ssh_url":"[email protected]:all-of-us/workbench.git","clone_url":"https://github.com/all-of-us/workbench.git","svn_url":"https://github.com/all-of-us/workbench","homepage":null,"size":12805,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"all-of-us:master","ref":"master","sha":"8bfa8c98b87721fb7a125bb6238a862723fd13c6","user":{"login":"all-of-us","id":22846942,"avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"repo":{"id":95247186,"name":"workbench","full_name":"all-of-us/workbench","owner":{"login":"all-of-us","id":22846942,"avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/all-of-us/workbench","description":null,"fork":false,"url":"https://api.github.com/repos/all-of-us/workbench","forks_url":"https://api.github.com/repos/all-of-us/workbench/forks","keys_url":"https://api.github.com/repos/all-of-us/workbench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all-of-us/workbench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all-of-us/workbench/teams","hooks_url":"https://api.github.com/repos/all-of-us/workbench/hooks","issue_events_url":"https://api.github.com/repos/all-of-us/workbench/issues/events{/number}","events_url":"https://api.github.com/repos/all-of-us/workbench/events","assignees_url":"https://api.github.com/repos/all-of-us/workbench/assignees{/user}","branches_url":"https://api.github.com/repos/all-of-us/workbench/branches{/branch}","tags_url":"https://api.github.com/repos/all-of-us/workbench/tags","blobs_url":"https://api.github.com/repos/all-of-us/workbench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all-of-us/workbench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all-of-us/workbench/git/refs{/sha}","trees_url":"https://api.github.com/repos/all-of-us/workbench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/{sha}","languages_url":"https://api.github.com/repos/all-of-us/workbench/languages","stargazers_url":"https://api.github.com/repos/all-of-us/workbench/stargazers","contributors_url":"https://api.github.com/repos/all-of-us/workbench/contributors","subscribers_url":"https://api.github.com/repos/all-of-us/workbench/subscribers","subscription_url":"https://api.github.com/repos/all-of-us/workbench/subscription","commits_url":"https://api.github.com/repos/all-of-us/workbench/commits{/sha}","git_commits_url":"https://api.github.com/repos/all-of-us/workbench/git/commits{/sha}","comments_url":"https://api.github.com/repos/all-of-us/workbench/comments{/number}","issue_comment_url":"https://api.github.com/repos/all-of-us/workbench/issues/comments{/number}","contents_url":"https://api.github.com/repos/all-of-us/workbench/contents/{+path}","compare_url":"https://api.github.com/repos/all-of-us/workbench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all-of-us/workbench/merges","archive_url":"https://api.github.com/repos/all-of-us/workbench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all-of-us/workbench/downloads","issues_url":"https://api.github.com/repos/all-of-us/workbench/issues{/number}","pulls_url":"https://api.github.com/repos/all-of-us/workbench/pulls{/number}","milestones_url":"https://api.github.com/repos/all-of-us/workbench/milestones{/number}","notifications_url":"https://api.github.com/repos/all-of-us/workbench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all-of-us/workbench/labels{/name}","releases_url":"https://api.github.com/repos/all-of-us/workbench/releases{/id}","deployments_url":"https://api.github.com/repos/all-of-us/workbench/deployments","created_at":"2017-06-23T18:44:24Z","updated_at":"2017-08-10T18:39:46Z","pushed_at":"2017-08-16T18:48:38Z","git_url":"git://github.com/all-of-us/workbench.git","ssh_url":"[email protected]:all-of-us/workbench.git","clone_url":"https://github.com/all-of-us/workbench.git","svn_url":"https://github.com/all-of-us/workbench","homepage":null,"size":12805,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/74"},"html":{"href":"https://github.com/all-of-us/workbench/pull/74"},"issue":{"href":"https://api.github.com/repos/all-of-us/workbench/issues/74"},"comments":{"href":"https://api.github.com/repos/all-of-us/workbench/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/all-of-us/workbench/statuses/6bea777650ed36aab3c8d2f9f30aacacff330ea2"}}}} | {
"id": 95247186,
"name": "all-of-us/workbench",
"url": "https://api.github.com/repos/all-of-us/workbench"
} | {
"id": 12536316,
"login": "danqrodney",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12536316?",
"url": "https://api.github.com/users/danqrodney"
} | {
"id": 22846942,
"login": "all-of-us",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22846942?",
"url": "https://api.github.com/orgs/all-of-us"
} | 2017-08-16T18:51:28 | 6466235351 | {"actor":{"display_login":"danqrodney"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/all-of-us/workbench/pulls/comments/144589706","pull_request_review_id":69270245,"id":144589706,"diff_hunk":"@@ -25,6 +25,14 @@ public void testDirectoryServiceUsernameIsTaken() {\n assertThat(service.isUsernameTaken(\"directory-service\")).isTrue();\n }\n \n+ @Test\n+ public void testCreateAndDeleteTestUser() {\n+ service.createUser(\"Integration\", \"Test\", \"integration.test\", \"notasecret\");","path":"api/src/integration/java/org/pmiops/workbench/google/DirectoryServiceImplIntegrationTest.java","position":6,"original_position":6,"commit_id":"cad614371e1f914eeebc7ed045641014850319a8","original_commit_id":"e247f5ff926954620e6f0765e03d82e0b32a4b46","user":{"login":"danqrodney","id":12536316,"avatar_url":"https://avatars0.githubusercontent.com/u/12536316?v=4","gravatar_id":"","url":"https://api.github.com/users/danqrodney","html_url":"https://github.com/danqrodney","followers_url":"https://api.github.com/users/danqrodney/followers","following_url":"https://api.github.com/users/danqrodney/following{/other_user}","gists_url":"https://api.github.com/users/danqrodney/gists{/gist_id}","starred_url":"https://api.github.com/users/danqrodney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danqrodney/subscriptions","organizations_url":"https://api.github.com/users/danqrodney/orgs","repos_url":"https://api.github.com/users/danqrodney/repos","events_url":"https://api.github.com/users/danqrodney/events{/privacy}","received_events_url":"https://api.github.com/users/danqrodney/received_events","type":"User","site_admin":false},"body":"On another note: if our test dies / loses connectivity after creating a user but before deleting it, this test will start failing. \r\n\r\nYou might want to issue a deleteUser first before doing the create just to handle that case.","created_at":"2017-10-13T15:44:54Z","updated_at":"2017-10-13T15:44:54Z","html_url":"https://github.com/all-of-us/workbench/pull/185#discussion_r144589706","pull_request_url":"https://api.github.com/repos/all-of-us/workbench/pulls/185","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/comments/144589706"},"html":{"href":"https://github.com/all-of-us/workbench/pull/185#discussion_r144589706"},"pull_request":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/185"}},"in_reply_to_id":144589358},"pull_request":{"url":"https://api.github.com/repos/all-of-us/workbench/pulls/185","id":146308994,"html_url":"https://github.com/all-of-us/workbench/pull/185","diff_url":"https://github.com/all-of-us/workbench/pull/185.diff","patch_url":"https://github.com/all-of-us/workbench/pull/185.patch","issue_url":"https://api.github.com/repos/all-of-us/workbench/issues/185","number":185,"state":"open","locked":false,"title":"API for GSuite account creation","user":{"login":"dmohs","id":1545444,"avatar_url":"https://avatars2.githubusercontent.com/u/1545444?v=4","gravatar_id":"","url":"https://api.github.com/users/dmohs","html_url":"https://github.com/dmohs","followers_url":"https://api.github.com/users/dmohs/followers","following_url":"https://api.github.com/users/dmohs/following{/other_user}","gists_url":"https://api.github.com/users/dmohs/gists{/gist_id}","starred_url":"https://api.github.com/users/dmohs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmohs/subscriptions","organizations_url":"https://api.github.com/users/dmohs/orgs","repos_url":"https://api.github.com/users/dmohs/repos","events_url":"https://api.github.com/users/dmohs/events{/privacy}","received_events_url":"https://api.github.com/users/dmohs/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-12T20:40:11Z","updated_at":"2017-10-13T15:44:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12825959e856663b7b21d03ec4531c1881743ee9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"markfickett","id":307950,"avatar_url":"https://avatars1.githubusercontent.com/u/307950?v=4","gravatar_id":"","url":"https://api.github.com/users/markfickett","html_url":"https://github.com/markfickett","followers_url":"https://api.github.com/users/markfickett/followers","following_url":"https://api.github.com/users/markfickett/following{/other_user}","gists_url":"https://api.github.com/users/markfickett/gists{/gist_id}","starred_url":"https://api.github.com/users/markfickett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfickett/subscriptions","organizations_url":"https://api.github.com/users/markfickett/orgs","repos_url":"https://api.github.com/users/markfickett/repos","events_url":"https://api.github.com/users/markfickett/events{/privacy}","received_events_url":"https://api.github.com/users/markfickett/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/all-of-us/workbench/pulls/185/commits","review_comments_url":"https://api.github.com/repos/all-of-us/workbench/pulls/185/comments","review_comment_url":"https://api.github.com/repos/all-of-us/workbench/pulls/comments{/number}","comments_url":"https://api.github.com/repos/all-of-us/workbench/issues/185/comments","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/cad614371e1f914eeebc7ed045641014850319a8","head":{"label":"all-of-us:dmohs/create-account","ref":"dmohs/create-account","sha":"cad614371e1f914eeebc7ed045641014850319a8","user":{"login":"all-of-us","id":22846942,"avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"repo":{"id":95247186,"name":"workbench","full_name":"all-of-us/workbench","owner":{"login":"all-of-us","id":22846942,"avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/all-of-us/workbench","description":null,"fork":false,"url":"https://api.github.com/repos/all-of-us/workbench","forks_url":"https://api.github.com/repos/all-of-us/workbench/forks","keys_url":"https://api.github.com/repos/all-of-us/workbench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all-of-us/workbench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all-of-us/workbench/teams","hooks_url":"https://api.github.com/repos/all-of-us/workbench/hooks","issue_events_url":"https://api.github.com/repos/all-of-us/workbench/issues/events{/number}","events_url":"https://api.github.com/repos/all-of-us/workbench/events","assignees_url":"https://api.github.com/repos/all-of-us/workbench/assignees{/user}","branches_url":"https://api.github.com/repos/all-of-us/workbench/branches{/branch}","tags_url":"https://api.github.com/repos/all-of-us/workbench/tags","blobs_url":"https://api.github.com/repos/all-of-us/workbench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all-of-us/workbench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all-of-us/workbench/git/refs{/sha}","trees_url":"https://api.github.com/repos/all-of-us/workbench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/{sha}","languages_url":"https://api.github.com/repos/all-of-us/workbench/languages","stargazers_url":"https://api.github.com/repos/all-of-us/workbench/stargazers","contributors_url":"https://api.github.com/repos/all-of-us/workbench/contributors","subscribers_url":"https://api.github.com/repos/all-of-us/workbench/subscribers","subscription_url":"https://api.github.com/repos/all-of-us/workbench/subscription","commits_url":"https://api.github.com/repos/all-of-us/workbench/commits{/sha}","git_commits_url":"https://api.github.com/repos/all-of-us/workbench/git/commits{/sha}","comments_url":"https://api.github.com/repos/all-of-us/workbench/comments{/number}","issue_comment_url":"https://api.github.com/repos/all-of-us/workbench/issues/comments{/number}","contents_url":"https://api.github.com/repos/all-of-us/workbench/contents/{+path}","compare_url":"https://api.github.com/repos/all-of-us/workbench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all-of-us/workbench/merges","archive_url":"https://api.github.com/repos/all-of-us/workbench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all-of-us/workbench/downloads","issues_url":"https://api.github.com/repos/all-of-us/workbench/issues{/number}","pulls_url":"https://api.github.com/repos/all-of-us/workbench/pulls{/number}","milestones_url":"https://api.github.com/repos/all-of-us/workbench/milestones{/number}","notifications_url":"https://api.github.com/repos/all-of-us/workbench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all-of-us/workbench/labels{/name}","releases_url":"https://api.github.com/repos/all-of-us/workbench/releases{/id}","deployments_url":"https://api.github.com/repos/all-of-us/workbench/deployments","created_at":"2017-06-23T18:44:24Z","updated_at":"2017-10-11T18:32:03Z","pushed_at":"2017-10-13T15:26:47Z","git_url":"git://github.com/all-of-us/workbench.git","ssh_url":"[email protected]:all-of-us/workbench.git","clone_url":"https://github.com/all-of-us/workbench.git","svn_url":"https://github.com/all-of-us/workbench","homepage":null,"size":1163,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"all-of-us:master","ref":"master","sha":"ee391c028cb5816de64a7406d680eed97db68d9f","user":{"login":"all-of-us","id":22846942,"avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"repo":{"id":95247186,"name":"workbench","full_name":"all-of-us/workbench","owner":{"login":"all-of-us","id":22846942,"avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/all-of-us/workbench","description":null,"fork":false,"url":"https://api.github.com/repos/all-of-us/workbench","forks_url":"https://api.github.com/repos/all-of-us/workbench/forks","keys_url":"https://api.github.com/repos/all-of-us/workbench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all-of-us/workbench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all-of-us/workbench/teams","hooks_url":"https://api.github.com/repos/all-of-us/workbench/hooks","issue_events_url":"https://api.github.com/repos/all-of-us/workbench/issues/events{/number}","events_url":"https://api.github.com/repos/all-of-us/workbench/events","assignees_url":"https://api.github.com/repos/all-of-us/workbench/assignees{/user}","branches_url":"https://api.github.com/repos/all-of-us/workbench/branches{/branch}","tags_url":"https://api.github.com/repos/all-of-us/workbench/tags","blobs_url":"https://api.github.com/repos/all-of-us/workbench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all-of-us/workbench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all-of-us/workbench/git/refs{/sha}","trees_url":"https://api.github.com/repos/all-of-us/workbench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/{sha}","languages_url":"https://api.github.com/repos/all-of-us/workbench/languages","stargazers_url":"https://api.github.com/repos/all-of-us/workbench/stargazers","contributors_url":"https://api.github.com/repos/all-of-us/workbench/contributors","subscribers_url":"https://api.github.com/repos/all-of-us/workbench/subscribers","subscription_url":"https://api.github.com/repos/all-of-us/workbench/subscription","commits_url":"https://api.github.com/repos/all-of-us/workbench/commits{/sha}","git_commits_url":"https://api.github.com/repos/all-of-us/workbench/git/commits{/sha}","comments_url":"https://api.github.com/repos/all-of-us/workbench/comments{/number}","issue_comment_url":"https://api.github.com/repos/all-of-us/workbench/issues/comments{/number}","contents_url":"https://api.github.com/repos/all-of-us/workbench/contents/{+path}","compare_url":"https://api.github.com/repos/all-of-us/workbench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all-of-us/workbench/merges","archive_url":"https://api.github.com/repos/all-of-us/workbench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all-of-us/workbench/downloads","issues_url":"https://api.github.com/repos/all-of-us/workbench/issues{/number}","pulls_url":"https://api.github.com/repos/all-of-us/workbench/pulls{/number}","milestones_url":"https://api.github.com/repos/all-of-us/workbench/milestones{/number}","notifications_url":"https://api.github.com/repos/all-of-us/workbench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all-of-us/workbench/labels{/name}","releases_url":"https://api.github.com/repos/all-of-us/workbench/releases{/id}","deployments_url":"https://api.github.com/repos/all-of-us/workbench/deployments","created_at":"2017-06-23T18:44:24Z","updated_at":"2017-10-11T18:32:03Z","pushed_at":"2017-10-13T15:26:47Z","git_url":"git://github.com/all-of-us/workbench.git","ssh_url":"[email protected]:all-of-us/workbench.git","clone_url":"https://github.com/all-of-us/workbench.git","svn_url":"https://github.com/all-of-us/workbench","homepage":null,"size":1163,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/185"},"html":{"href":"https://github.com/all-of-us/workbench/pull/185"},"issue":{"href":"https://api.github.com/repos/all-of-us/workbench/issues/185"},"comments":{"href":"https://api.github.com/repos/all-of-us/workbench/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/all-of-us/workbench/statuses/cad614371e1f914eeebc7ed045641014850319a8"}},"author_association":"COLLABORATOR"}} | {
"id": 95247186,
"name": "all-of-us/workbench",
"url": "https://api.github.com/repos/all-of-us/workbench"
} | {
"id": 12536316,
"login": "danqrodney",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12536316?",
"url": "https://api.github.com/users/danqrodney"
} | {
"id": 22846942,
"login": "all-of-us",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22846942?",
"url": "https://api.github.com/orgs/all-of-us"
} | 2017-10-13T15:44:54 | 6714135695 | {"actor":{"display_login":"danqrodney"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/all-of-us/workbench/pulls/comments/153941664","pull_request_review_id":80028375,"id":153941664,"diff_hunk":"@@ -967,6 +995,59 @@ definitions:\n format: int64\n description: Milliseconds since the UNIX epoch.\n \n+ MaterializeCohortRequest:\n+ type: object\n+ properties:\n+ cohortName:\n+ description: >\n+ The name of a cohort that is to be evaluated. Either this or cohortSpec should be specified\n+ type: string\n+ cohortSpec:\n+ description: >\n+ JSON representation of a cohort to be evaluated (using the same format used for saved\n+ cohorts). Either this or cohortName should be specified\n+ type: string\n+ statusFilter:\n+ description: >\n+ An array of status values; participants with these statuses will be included.\n+ Defaults to [NOT_REVIEWED, INCLUDED, NEEDS_FURTHER_REVIEW] -- everything but EXCLUDED.","path":"api/src/main/resources/workbench.yaml","position":54,"original_position":54,"commit_id":"bee6beeb7f4460c7679ee5ca3e4263000e9ca53f","original_commit_id":"ce04ac58429d727659b0727b43e9c1478388dfc4","user":{"login":"danqrodney","id":12536316,"avatar_url":"https://avatars0.githubusercontent.com/u/12536316?v=4","gravatar_id":"","url":"https://api.github.com/users/danqrodney","html_url":"https://github.com/danqrodney","followers_url":"https://api.github.com/users/danqrodney/followers","following_url":"https://api.github.com/users/danqrodney/following{/other_user}","gists_url":"https://api.github.com/users/danqrodney/gists{/gist_id}","starred_url":"https://api.github.com/users/danqrodney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danqrodney/subscriptions","organizations_url":"https://api.github.com/users/danqrodney/orgs","repos_url":"https://api.github.com/users/danqrodney/repos","events_url":"https://api.github.com/users/danqrodney/events{/privacy}","received_events_url":"https://api.github.com/users/danqrodney/received_events","type":"User","site_admin":false},"body":"For a bit more info, see:\r\n\r\nhttps://docs.google.com/document/d/1JrzQgxq9vB42sHKwMDI8CKzAADNY7r7WUfVQX3mc8Nw/edit#heading=h.da49ri852lfy","created_at":"2017-11-29T23:01:53Z","updated_at":"2017-11-29T23:01:54Z","html_url":"https://github.com/all-of-us/workbench/pull/314#discussion_r153941664","pull_request_url":"https://api.github.com/repos/all-of-us/workbench/pulls/314","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/comments/153941664"},"html":{"href":"https://github.com/all-of-us/workbench/pull/314#discussion_r153941664"},"pull_request":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/314"}},"in_reply_to_id":153928372},"pull_request":{"url":"https://api.github.com/repos/all-of-us/workbench/pulls/314","id":155460058,"html_url":"https://github.com/all-of-us/workbench/pull/314","diff_url":"https://github.com/all-of-us/workbench/pull/314.diff","patch_url":"https://github.com/all-of-us/workbench/pull/314.patch","issue_url":"https://api.github.com/repos/all-of-us/workbench/issues/314","number":314,"state":"open","locked":false,"title":"[RW-122] Stub endpoint for materializing a cohort ","user":{"login":"danqrodney","id":12536316,"avatar_url":"https://avatars0.githubusercontent.com/u/12536316?v=4","gravatar_id":"","url":"https://api.github.com/users/danqrodney","html_url":"https://github.com/danqrodney","followers_url":"https://api.github.com/users/danqrodney/followers","following_url":"https://api.github.com/users/danqrodney/following{/other_user}","gists_url":"https://api.github.com/users/danqrodney/gists{/gist_id}","starred_url":"https://api.github.com/users/danqrodney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danqrodney/subscriptions","organizations_url":"https://api.github.com/users/danqrodney/orgs","repos_url":"https://api.github.com/users/danqrodney/repos","events_url":"https://api.github.com/users/danqrodney/events{/privacy}","received_events_url":"https://api.github.com/users/danqrodney/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-29T21:41:19Z","updated_at":"2017-11-29T23:01:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bd130f8d6c12d758b9e8837c76fb1f70a4addf8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jmandel","id":313089,"avatar_url":"https://avatars0.githubusercontent.com/u/313089?v=4","gravatar_id":"","url":"https://api.github.com/users/jmandel","html_url":"https://github.com/jmandel","followers_url":"https://api.github.com/users/jmandel/followers","following_url":"https://api.github.com/users/jmandel/following{/other_user}","gists_url":"https://api.github.com/users/jmandel/gists{/gist_id}","starred_url":"https://api.github.com/users/jmandel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmandel/subscriptions","organizations_url":"https://api.github.com/users/jmandel/orgs","repos_url":"https://api.github.com/users/jmandel/repos","events_url":"https://api.github.com/users/jmandel/events{/privacy}","received_events_url":"https://api.github.com/users/jmandel/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/all-of-us/workbench/pulls/314/commits","review_comments_url":"https://api.github.com/repos/all-of-us/workbench/pulls/314/comments","review_comment_url":"https://api.github.com/repos/all-of-us/workbench/pulls/comments{/number}","comments_url":"https://api.github.com/repos/all-of-us/workbench/issues/314/comments","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/bee6beeb7f4460c7679ee5ca3e4263000e9ca53f","head":{"label":"all-of-us:danrodney/materialize","ref":"danrodney/materialize","sha":"bee6beeb7f4460c7679ee5ca3e4263000e9ca53f","user":{"login":"all-of-us","id":22846942,"avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"repo":{"id":95247186,"name":"workbench","full_name":"all-of-us/workbench","owner":{"login":"all-of-us","id":22846942,"avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/all-of-us/workbench","description":null,"fork":false,"url":"https://api.github.com/repos/all-of-us/workbench","forks_url":"https://api.github.com/repos/all-of-us/workbench/forks","keys_url":"https://api.github.com/repos/all-of-us/workbench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all-of-us/workbench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all-of-us/workbench/teams","hooks_url":"https://api.github.com/repos/all-of-us/workbench/hooks","issue_events_url":"https://api.github.com/repos/all-of-us/workbench/issues/events{/number}","events_url":"https://api.github.com/repos/all-of-us/workbench/events","assignees_url":"https://api.github.com/repos/all-of-us/workbench/assignees{/user}","branches_url":"https://api.github.com/repos/all-of-us/workbench/branches{/branch}","tags_url":"https://api.github.com/repos/all-of-us/workbench/tags","blobs_url":"https://api.github.com/repos/all-of-us/workbench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all-of-us/workbench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all-of-us/workbench/git/refs{/sha}","trees_url":"https://api.github.com/repos/all-of-us/workbench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/{sha}","languages_url":"https://api.github.com/repos/all-of-us/workbench/languages","stargazers_url":"https://api.github.com/repos/all-of-us/workbench/stargazers","contributors_url":"https://api.github.com/repos/all-of-us/workbench/contributors","subscribers_url":"https://api.github.com/repos/all-of-us/workbench/subscribers","subscription_url":"https://api.github.com/repos/all-of-us/workbench/subscription","commits_url":"https://api.github.com/repos/all-of-us/workbench/commits{/sha}","git_commits_url":"https://api.github.com/repos/all-of-us/workbench/git/commits{/sha}","comments_url":"https://api.github.com/repos/all-of-us/workbench/comments{/number}","issue_comment_url":"https://api.github.com/repos/all-of-us/workbench/issues/comments{/number}","contents_url":"https://api.github.com/repos/all-of-us/workbench/contents/{+path}","compare_url":"https://api.github.com/repos/all-of-us/workbench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all-of-us/workbench/merges","archive_url":"https://api.github.com/repos/all-of-us/workbench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all-of-us/workbench/downloads","issues_url":"https://api.github.com/repos/all-of-us/workbench/issues{/number}","pulls_url":"https://api.github.com/repos/all-of-us/workbench/pulls{/number}","milestones_url":"https://api.github.com/repos/all-of-us/workbench/milestones{/number}","notifications_url":"https://api.github.com/repos/all-of-us/workbench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all-of-us/workbench/labels{/name}","releases_url":"https://api.github.com/repos/all-of-us/workbench/releases{/id}","deployments_url":"https://api.github.com/repos/all-of-us/workbench/deployments","created_at":"2017-06-23T18:44:24Z","updated_at":"2017-10-11T18:32:03Z","pushed_at":"2017-11-29T22:58:24Z","git_url":"git://github.com/all-of-us/workbench.git","ssh_url":"[email protected]:all-of-us/workbench.git","clone_url":"https://github.com/all-of-us/workbench.git","svn_url":"https://github.com/all-of-us/workbench","homepage":null,"size":10360,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":1,"open_issues":8,"watchers":1,"default_branch":"master"}},"base":{"label":"all-of-us:master","ref":"master","sha":"8aa992047d76543554fd5de9126f4c54e65cf7c8","user":{"login":"all-of-us","id":22846942,"avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"repo":{"id":95247186,"name":"workbench","full_name":"all-of-us/workbench","owner":{"login":"all-of-us","id":22846942,"avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/all-of-us/workbench","description":null,"fork":false,"url":"https://api.github.com/repos/all-of-us/workbench","forks_url":"https://api.github.com/repos/all-of-us/workbench/forks","keys_url":"https://api.github.com/repos/all-of-us/workbench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all-of-us/workbench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all-of-us/workbench/teams","hooks_url":"https://api.github.com/repos/all-of-us/workbench/hooks","issue_events_url":"https://api.github.com/repos/all-of-us/workbench/issues/events{/number}","events_url":"https://api.github.com/repos/all-of-us/workbench/events","assignees_url":"https://api.github.com/repos/all-of-us/workbench/assignees{/user}","branches_url":"https://api.github.com/repos/all-of-us/workbench/branches{/branch}","tags_url":"https://api.github.com/repos/all-of-us/workbench/tags","blobs_url":"https://api.github.com/repos/all-of-us/workbench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all-of-us/workbench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all-of-us/workbench/git/refs{/sha}","trees_url":"https://api.github.com/repos/all-of-us/workbench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/{sha}","languages_url":"https://api.github.com/repos/all-of-us/workbench/languages","stargazers_url":"https://api.github.com/repos/all-of-us/workbench/stargazers","contributors_url":"https://api.github.com/repos/all-of-us/workbench/contributors","subscribers_url":"https://api.github.com/repos/all-of-us/workbench/subscribers","subscription_url":"https://api.github.com/repos/all-of-us/workbench/subscription","commits_url":"https://api.github.com/repos/all-of-us/workbench/commits{/sha}","git_commits_url":"https://api.github.com/repos/all-of-us/workbench/git/commits{/sha}","comments_url":"https://api.github.com/repos/all-of-us/workbench/comments{/number}","issue_comment_url":"https://api.github.com/repos/all-of-us/workbench/issues/comments{/number}","contents_url":"https://api.github.com/repos/all-of-us/workbench/contents/{+path}","compare_url":"https://api.github.com/repos/all-of-us/workbench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all-of-us/workbench/merges","archive_url":"https://api.github.com/repos/all-of-us/workbench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all-of-us/workbench/downloads","issues_url":"https://api.github.com/repos/all-of-us/workbench/issues{/number}","pulls_url":"https://api.github.com/repos/all-of-us/workbench/pulls{/number}","milestones_url":"https://api.github.com/repos/all-of-us/workbench/milestones{/number}","notifications_url":"https://api.github.com/repos/all-of-us/workbench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all-of-us/workbench/labels{/name}","releases_url":"https://api.github.com/repos/all-of-us/workbench/releases{/id}","deployments_url":"https://api.github.com/repos/all-of-us/workbench/deployments","created_at":"2017-06-23T18:44:24Z","updated_at":"2017-10-11T18:32:03Z","pushed_at":"2017-11-29T22:58:24Z","git_url":"git://github.com/all-of-us/workbench.git","ssh_url":"[email protected]:all-of-us/workbench.git","clone_url":"https://github.com/all-of-us/workbench.git","svn_url":"https://github.com/all-of-us/workbench","homepage":null,"size":10360,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":1,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/314"},"html":{"href":"https://github.com/all-of-us/workbench/pull/314"},"issue":{"href":"https://api.github.com/repos/all-of-us/workbench/issues/314"},"comments":{"href":"https://api.github.com/repos/all-of-us/workbench/issues/314/comments"},"review_comments":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/314/comments"},"review_comment":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/314/commits"},"statuses":{"href":"https://api.github.com/repos/all-of-us/workbench/statuses/bee6beeb7f4460c7679ee5ca3e4263000e9ca53f"}},"author_association":"CONTRIBUTOR"}} | {
"id": 95247186,
"name": "all-of-us/workbench",
"url": "https://api.github.com/repos/all-of-us/workbench"
} | {
"id": 12536316,
"login": "danqrodney",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12536316?",
"url": "https://api.github.com/users/danqrodney"
} | {
"id": 22846942,
"login": "all-of-us",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22846942?",
"url": "https://api.github.com/orgs/all-of-us"
} | 2017-11-29T23:01:53 | 6921684935 | {"actor":{"display_login":"danqrodney"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/analyzere/analyzere-python-extras/pulls/comments/97997204","pull_request_review_id":18624701,"id":97997204,"diff_hunk":"@@ -0,0 +1,272 @@\n+import hashlib\n+\n+from analyzere import LayerView\n+from datetime import datetime\n+from graphviz import Digraph\n+from IPython.display import FileLink\n+from sys import float_info\n+\n+\n+class LayerViewVisualizer(object):\n+ \"\"\"Class that provides simple visualization an Analyze Re LayerViews.\n+\n+ Using the 'graphviz' python package, this class enables users to\n+ visualize Analyze Re LayerView objects.\n+\n+ The class has two main visualization methods:","path":"analyzere/extras/visualizations.py","position":16,"original_position":16,"commit_id":"7f0eb83acf662535d183f0cd4262832ea91ff111","original_commit_id":"7f0eb83acf662535d183f0cd4262832ea91ff111","user":{"login":"sbchisholm","id":1753278,"avatar_url":"https://avatars.githubusercontent.com/u/1753278?v=3","gravatar_id":"","url":"https://api.github.com/users/sbchisholm","html_url":"https://github.com/sbchisholm","followers_url":"https://api.github.com/users/sbchisholm/followers","following_url":"https://api.github.com/users/sbchisholm/following{/other_user}","gists_url":"https://api.github.com/users/sbchisholm/gists{/gist_id}","starred_url":"https://api.github.com/users/sbchisholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbchisholm/subscriptions","organizations_url":"https://api.github.com/users/sbchisholm/orgs","repos_url":"https://api.github.com/users/sbchisholm/repos","events_url":"https://api.github.com/users/sbchisholm/events{/privacy}","received_events_url":"https://api.github.com/users/sbchisholm/received_events","type":"User","site_admin":false},"body":"This comment is a bit redundant. If you take a look at the output of `help(visualizations)` you'll see that this same information is displayed right below since you've included it as part of the download and view method comments.","created_at":"2017-01-26T13:55:41Z","updated_at":"2017-01-26T14:02:43Z","html_url":"https://github.com/analyzere/analyzere-python-extras/pull/1#discussion_r97997204","pull_request_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/analyzere/analyzere-python-extras/pulls/comments/97997204"},"html":{"href":"https://github.com/analyzere/analyzere-python-extras/pull/1#discussion_r97997204"},"pull_request":{"href":"https://api.github.com/repos/analyzere/analyzere-python-extras/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/analyzere/analyzere-python-extras/pulls/1","id":103179463,"html_url":"https://github.com/analyzere/analyzere-python-extras/pull/1","diff_url":"https://github.com/analyzere/analyzere-python-extras/pull/1.diff","patch_url":"https://github.com/analyzere/analyzere-python-extras/pull/1.patch","issue_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/issues/1","number":1,"state":"open","locked":false,"title":"Initial version of extras.visualizations","user":{"login":"sbmacdonald","id":2412361,"avatar_url":"https://avatars.githubusercontent.com/u/2412361?v=3","gravatar_id":"","url":"https://api.github.com/users/sbmacdonald","html_url":"https://github.com/sbmacdonald","followers_url":"https://api.github.com/users/sbmacdonald/followers","following_url":"https://api.github.com/users/sbmacdonald/following{/other_user}","gists_url":"https://api.github.com/users/sbmacdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/sbmacdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbmacdonald/subscriptions","organizations_url":"https://api.github.com/users/sbmacdonald/orgs","repos_url":"https://api.github.com/users/sbmacdonald/repos","events_url":"https://api.github.com/users/sbmacdonald/events{/privacy}","received_events_url":"https://api.github.com/users/sbmacdonald/received_events","type":"User","site_admin":false},"body":"Sample notebook usage:\r\n\r\n\r\n","created_at":"2017-01-25T18:48:28Z","updated_at":"2017-01-26T14:02:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2174ac2986f6afeacad79115d5f9a38080880f8","assignee":{"login":"obaltzer","id":261547,"avatar_url":"https://avatars.githubusercontent.com/u/261547?v=3","gravatar_id":"","url":"https://api.github.com/users/obaltzer","html_url":"https://github.com/obaltzer","followers_url":"https://api.github.com/users/obaltzer/followers","following_url":"https://api.github.com/users/obaltzer/following{/other_user}","gists_url":"https://api.github.com/users/obaltzer/gists{/gist_id}","starred_url":"https://api.github.com/users/obaltzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obaltzer/subscriptions","organizations_url":"https://api.github.com/users/obaltzer/orgs","repos_url":"https://api.github.com/users/obaltzer/repos","events_url":"https://api.github.com/users/obaltzer/events{/privacy}","received_events_url":"https://api.github.com/users/obaltzer/received_events","type":"User","site_admin":false},"assignees":[{"login":"obaltzer","id":261547,"avatar_url":"https://avatars.githubusercontent.com/u/261547?v=3","gravatar_id":"","url":"https://api.github.com/users/obaltzer","html_url":"https://github.com/obaltzer","followers_url":"https://api.github.com/users/obaltzer/followers","following_url":"https://api.github.com/users/obaltzer/following{/other_user}","gists_url":"https://api.github.com/users/obaltzer/gists{/gist_id}","starred_url":"https://api.github.com/users/obaltzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obaltzer/subscriptions","organizations_url":"https://api.github.com/users/obaltzer/orgs","repos_url":"https://api.github.com/users/obaltzer/repos","events_url":"https://api.github.com/users/obaltzer/events{/privacy}","received_events_url":"https://api.github.com/users/obaltzer/received_events","type":"User","site_admin":false},{"login":"DanielArndt","id":607732,"avatar_url":"https://avatars.githubusercontent.com/u/607732?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielArndt","html_url":"https://github.com/DanielArndt","followers_url":"https://api.github.com/users/DanielArndt/followers","following_url":"https://api.github.com/users/DanielArndt/following{/other_user}","gists_url":"https://api.github.com/users/DanielArndt/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielArndt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielArndt/subscriptions","organizations_url":"https://api.github.com/users/DanielArndt/orgs","repos_url":"https://api.github.com/users/DanielArndt/repos","events_url":"https://api.github.com/users/DanielArndt/events{/privacy}","received_events_url":"https://api.github.com/users/DanielArndt/received_events","type":"User","site_admin":false},{"login":"sbchisholm","id":1753278,"avatar_url":"https://avatars.githubusercontent.com/u/1753278?v=3","gravatar_id":"","url":"https://api.github.com/users/sbchisholm","html_url":"https://github.com/sbchisholm","followers_url":"https://api.github.com/users/sbchisholm/followers","following_url":"https://api.github.com/users/sbchisholm/following{/other_user}","gists_url":"https://api.github.com/users/sbchisholm/gists{/gist_id}","starred_url":"https://api.github.com/users/sbchisholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbchisholm/subscriptions","organizations_url":"https://api.github.com/users/sbchisholm/orgs","repos_url":"https://api.github.com/users/sbchisholm/repos","events_url":"https://api.github.com/users/sbchisholm/events{/privacy}","received_events_url":"https://api.github.com/users/sbchisholm/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/pulls/1/commits","review_comments_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/pulls/1/comments","review_comment_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/pulls/comments{/number}","comments_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/issues/1/comments","statuses_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/statuses/7f0eb83acf662535d183f0cd4262832ea91ff111","head":{"label":"analyzere:ARE-4048-add-analyzere-extras","ref":"ARE-4048-add-analyzere-extras","sha":"7f0eb83acf662535d183f0cd4262832ea91ff111","user":{"login":"analyzere","id":2906686,"avatar_url":"https://avatars.githubusercontent.com/u/2906686?v=3","gravatar_id":"","url":"https://api.github.com/users/analyzere","html_url":"https://github.com/analyzere","followers_url":"https://api.github.com/users/analyzere/followers","following_url":"https://api.github.com/users/analyzere/following{/other_user}","gists_url":"https://api.github.com/users/analyzere/gists{/gist_id}","starred_url":"https://api.github.com/users/analyzere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analyzere/subscriptions","organizations_url":"https://api.github.com/users/analyzere/orgs","repos_url":"https://api.github.com/users/analyzere/repos","events_url":"https://api.github.com/users/analyzere/events{/privacy}","received_events_url":"https://api.github.com/users/analyzere/received_events","type":"Organization","site_admin":false},"repo":{"id":79946308,"name":"analyzere-python-extras","full_name":"analyzere/analyzere-python-extras","owner":{"login":"analyzere","id":2906686,"avatar_url":"https://avatars.githubusercontent.com/u/2906686?v=3","gravatar_id":"","url":"https://api.github.com/users/analyzere","html_url":"https://github.com/analyzere","followers_url":"https://api.github.com/users/analyzere/followers","following_url":"https://api.github.com/users/analyzere/following{/other_user}","gists_url":"https://api.github.com/users/analyzere/gists{/gist_id}","starred_url":"https://api.github.com/users/analyzere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analyzere/subscriptions","organizations_url":"https://api.github.com/users/analyzere/orgs","repos_url":"https://api.github.com/users/analyzere/repos","events_url":"https://api.github.com/users/analyzere/events{/privacy}","received_events_url":"https://api.github.com/users/analyzere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/analyzere/analyzere-python-extras","description":"An extension to faciliate visualization of Analyze Re LayerView","fork":false,"url":"https://api.github.com/repos/analyzere/analyzere-python-extras","forks_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/forks","keys_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/teams","hooks_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/hooks","issue_events_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/issues/events{/number}","events_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/events","assignees_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/assignees{/user}","branches_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/branches{/branch}","tags_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/tags","blobs_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/languages","stargazers_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/stargazers","contributors_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/contributors","subscribers_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/subscribers","subscription_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/subscription","commits_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/contents/{+path}","compare_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/merges","archive_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/downloads","issues_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/issues{/number}","pulls_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/labels{/name}","releases_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/releases{/id}","deployments_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/deployments","created_at":"2017-01-24T19:32:12Z","updated_at":"2017-01-25T17:47:38Z","pushed_at":"2017-01-25T18:48:28Z","git_url":"git://github.com/analyzere/analyzere-python-extras.git","ssh_url":"[email protected]:analyzere/analyzere-python-extras.git","clone_url":"https://github.com/analyzere/analyzere-python-extras.git","svn_url":"https://github.com/analyzere/analyzere-python-extras","homepage":null,"size":8,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"analyzere:master","ref":"master","sha":"d97ba6e94b0f6f04620ed45c4c2bbd6691f182ed","user":{"login":"analyzere","id":2906686,"avatar_url":"https://avatars.githubusercontent.com/u/2906686?v=3","gravatar_id":"","url":"https://api.github.com/users/analyzere","html_url":"https://github.com/analyzere","followers_url":"https://api.github.com/users/analyzere/followers","following_url":"https://api.github.com/users/analyzere/following{/other_user}","gists_url":"https://api.github.com/users/analyzere/gists{/gist_id}","starred_url":"https://api.github.com/users/analyzere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analyzere/subscriptions","organizations_url":"https://api.github.com/users/analyzere/orgs","repos_url":"https://api.github.com/users/analyzere/repos","events_url":"https://api.github.com/users/analyzere/events{/privacy}","received_events_url":"https://api.github.com/users/analyzere/received_events","type":"Organization","site_admin":false},"repo":{"id":79946308,"name":"analyzere-python-extras","full_name":"analyzere/analyzere-python-extras","owner":{"login":"analyzere","id":2906686,"avatar_url":"https://avatars.githubusercontent.com/u/2906686?v=3","gravatar_id":"","url":"https://api.github.com/users/analyzere","html_url":"https://github.com/analyzere","followers_url":"https://api.github.com/users/analyzere/followers","following_url":"https://api.github.com/users/analyzere/following{/other_user}","gists_url":"https://api.github.com/users/analyzere/gists{/gist_id}","starred_url":"https://api.github.com/users/analyzere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analyzere/subscriptions","organizations_url":"https://api.github.com/users/analyzere/orgs","repos_url":"https://api.github.com/users/analyzere/repos","events_url":"https://api.github.com/users/analyzere/events{/privacy}","received_events_url":"https://api.github.com/users/analyzere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/analyzere/analyzere-python-extras","description":"An extension to faciliate visualization of Analyze Re LayerView","fork":false,"url":"https://api.github.com/repos/analyzere/analyzere-python-extras","forks_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/forks","keys_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/teams","hooks_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/hooks","issue_events_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/issues/events{/number}","events_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/events","assignees_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/assignees{/user}","branches_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/branches{/branch}","tags_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/tags","blobs_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/languages","stargazers_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/stargazers","contributors_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/contributors","subscribers_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/subscribers","subscription_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/subscription","commits_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/contents/{+path}","compare_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/merges","archive_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/downloads","issues_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/issues{/number}","pulls_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/labels{/name}","releases_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/releases{/id}","deployments_url":"https://api.github.com/repos/analyzere/analyzere-python-extras/deployments","created_at":"2017-01-24T19:32:12Z","updated_at":"2017-01-25T17:47:38Z","pushed_at":"2017-01-25T18:48:28Z","git_url":"git://github.com/analyzere/analyzere-python-extras.git","ssh_url":"[email protected]:analyzere/analyzere-python-extras.git","clone_url":"https://github.com/analyzere/analyzere-python-extras.git","svn_url":"https://github.com/analyzere/analyzere-python-extras","homepage":null,"size":8,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/analyzere/analyzere-python-extras/pulls/1"},"html":{"href":"https://github.com/analyzere/analyzere-python-extras/pull/1"},"issue":{"href":"https://api.github.com/repos/analyzere/analyzere-python-extras/issues/1"},"comments":{"href":"https://api.github.com/repos/analyzere/analyzere-python-extras/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/analyzere/analyzere-python-extras/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/analyzere/analyzere-python-extras/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/analyzere/analyzere-python-extras/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/analyzere/analyzere-python-extras/statuses/7f0eb83acf662535d183f0cd4262832ea91ff111"}}}} | {
"id": 79946308,
"name": "analyzere/analyzere-python-extras",
"url": "https://api.github.com/repos/analyzere/analyzere-python-extras"
} | {
"id": 1753278,
"login": "sbchisholm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1753278?",
"url": "https://api.github.com/users/sbchisholm"
} | {
"id": 2906686,
"login": "analyzere",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2906686?",
"url": "https://api.github.com/orgs/analyzere"
} | 2017-01-26T13:55:41 | 5217476987 | {"actor":{"display_login":"sbchisholm"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/bitwarden/mobile/pulls/comments/156482373","pull_request_review_id":82966559,"id":156482373,"diff_hunk":"@@ -15,13 +16,15 @@ public DismissModalToolBarItem(ContentPage page, string text = null, Action canc\n // TODO: init and dispose events from pages\n InitEvents();\n Text = text ?? AppResources.Close;\n+ Icon = Helpers.ToolbarImage(\"ion_chevron_left.png\");\n Priority = -1;\n }\n \n protected async override void ClickedItem(object sender, EventArgs e)\n {\n base.ClickedItem(sender, e);\n- await _page.Navigation.PopModalAsync();\n+\n+ await _page.Navigation.PopForDeviceAsync();","path":"src/App/Controls/DismissModalToolBarItem.cs","position":19,"original_position":19,"commit_id":"7a8e88c4937f3d90a20e3a820c0494dc7eed1021","original_commit_id":"7a8e88c4937f3d90a20e3a820c0494dc7eed1021","user":{"login":"kspearrin","id":1190944,"avatar_url":"https://avatars3.githubusercontent.com/u/1190944?v=4","gravatar_id":"","url":"https://api.github.com/users/kspearrin","html_url":"https://github.com/kspearrin","followers_url":"https://api.github.com/users/kspearrin/followers","following_url":"https://api.github.com/users/kspearrin/following{/other_user}","gists_url":"https://api.github.com/users/kspearrin/gists{/gist_id}","starred_url":"https://api.github.com/users/kspearrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kspearrin/subscriptions","organizations_url":"https://api.github.com/users/kspearrin/orgs","repos_url":"https://api.github.com/users/kspearrin/repos","events_url":"https://api.github.com/users/kspearrin/events{/privacy}","received_events_url":"https://api.github.com/users/kspearrin/received_events","type":"User","site_admin":false},"body":"undo new line changes.","created_at":"2017-12-12T20:11:00Z","updated_at":"2017-12-12T20:11:52Z","html_url":"https://github.com/bitwarden/mobile/pull/199#discussion_r156482373","pull_request_url":"https://api.github.com/repos/bitwarden/mobile/pulls/199","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/bitwarden/mobile/pulls/comments/156482373"},"html":{"href":"https://github.com/bitwarden/mobile/pull/199#discussion_r156482373"},"pull_request":{"href":"https://api.github.com/repos/bitwarden/mobile/pulls/199"}}},"pull_request":{"url":"https://api.github.com/repos/bitwarden/mobile/pulls/199","id":156901074,"html_url":"https://github.com/bitwarden/mobile/pull/199","diff_url":"https://github.com/bitwarden/mobile/pull/199.diff","patch_url":"https://github.com/bitwarden/mobile/pull/199.patch","issue_url":"https://api.github.com/repos/bitwarden/mobile/issues/199","number":199,"state":"open","locked":false,"title":"Improve the navigation on Windows platforms","user":{"login":"alistair23","id":171674,"avatar_url":"https://avatars0.githubusercontent.com/u/171674?v=4","gravatar_id":"","url":"https://api.github.com/users/alistair23","html_url":"https://github.com/alistair23","followers_url":"https://api.github.com/users/alistair23/followers","following_url":"https://api.github.com/users/alistair23/following{/other_user}","gists_url":"https://api.github.com/users/alistair23/gists{/gist_id}","starred_url":"https://api.github.com/users/alistair23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alistair23/subscriptions","organizations_url":"https://api.github.com/users/alistair23/orgs","repos_url":"https://api.github.com/users/alistair23/repos","events_url":"https://api.github.com/users/alistair23/events{/privacy}","received_events_url":"https://api.github.com/users/alistair23/received_events","type":"User","site_admin":false},"body":"Modal pages don't get back arrows on Windows desktop apps. To match the usual UWP style remove most of the cancel buttons and mark a large number of pages as non-modal to get a back button.","created_at":"2017-12-07T04:14:36Z","updated_at":"2017-12-12T20:11:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8b180444840e2cbdcf7169ca81be8bf94dd3346","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitwarden/mobile/pulls/199/commits","review_comments_url":"https://api.github.com/repos/bitwarden/mobile/pulls/199/comments","review_comment_url":"https://api.github.com/repos/bitwarden/mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitwarden/mobile/issues/199/comments","statuses_url":"https://api.github.com/repos/bitwarden/mobile/statuses/7a8e88c4937f3d90a20e3a820c0494dc7eed1021","head":{"label":"alistair23:alistair/modal","ref":"alistair/modal","sha":"7a8e88c4937f3d90a20e3a820c0494dc7eed1021","user":{"login":"alistair23","id":171674,"avatar_url":"https://avatars0.githubusercontent.com/u/171674?v=4","gravatar_id":"","url":"https://api.github.com/users/alistair23","html_url":"https://github.com/alistair23","followers_url":"https://api.github.com/users/alistair23/followers","following_url":"https://api.github.com/users/alistair23/following{/other_user}","gists_url":"https://api.github.com/users/alistair23/gists{/gist_id}","starred_url":"https://api.github.com/users/alistair23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alistair23/subscriptions","organizations_url":"https://api.github.com/users/alistair23/orgs","repos_url":"https://api.github.com/users/alistair23/repos","events_url":"https://api.github.com/users/alistair23/events{/privacy}","received_events_url":"https://api.github.com/users/alistair23/received_events","type":"User","site_admin":false},"repo":{"id":100552995,"name":"bitwarden-mobile","full_name":"alistair23/bitwarden-mobile","owner":{"login":"alistair23","id":171674,"avatar_url":"https://avatars0.githubusercontent.com/u/171674?v=4","gravatar_id":"","url":"https://api.github.com/users/alistair23","html_url":"https://github.com/alistair23","followers_url":"https://api.github.com/users/alistair23/followers","following_url":"https://api.github.com/users/alistair23/following{/other_user}","gists_url":"https://api.github.com/users/alistair23/gists{/gist_id}","starred_url":"https://api.github.com/users/alistair23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alistair23/subscriptions","organizations_url":"https://api.github.com/users/alistair23/orgs","repos_url":"https://api.github.com/users/alistair23/repos","events_url":"https://api.github.com/users/alistair23/events{/privacy}","received_events_url":"https://api.github.com/users/alistair23/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alistair23/bitwarden-mobile","description":"The mobile vault (iOS and Android).","fork":true,"url":"https://api.github.com/repos/alistair23/bitwarden-mobile","forks_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/forks","keys_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/teams","hooks_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/hooks","issue_events_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/events","assignees_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/tags","blobs_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/languages","stargazers_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/stargazers","contributors_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/contributors","subscribers_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/subscribers","subscription_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/subscription","commits_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/merges","archive_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/downloads","issues_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/labels{/name}","releases_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/alistair23/bitwarden-mobile/deployments","created_at":"2017-08-17T02:32:15Z","updated_at":"2017-12-06T18:19:34Z","pushed_at":"2017-12-12T16:42:31Z","git_url":"git://github.com/alistair23/bitwarden-mobile.git","ssh_url":"[email protected]:alistair23/bitwarden-mobile.git","clone_url":"https://github.com/alistair23/bitwarden-mobile.git","svn_url":"https://github.com/alistair23/bitwarden-mobile","homepage":"https://bitwarden.com","size":25619,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitwarden:master","ref":"master","sha":"baf785d9f1385e79b1cadc900a730492e4354e25","user":{"login":"bitwarden","id":15990069,"avatar_url":"https://avatars0.githubusercontent.com/u/15990069?v=4","gravatar_id":"","url":"https://api.github.com/users/bitwarden","html_url":"https://github.com/bitwarden","followers_url":"https://api.github.com/users/bitwarden/followers","following_url":"https://api.github.com/users/bitwarden/following{/other_user}","gists_url":"https://api.github.com/users/bitwarden/gists{/gist_id}","starred_url":"https://api.github.com/users/bitwarden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitwarden/subscriptions","organizations_url":"https://api.github.com/users/bitwarden/orgs","repos_url":"https://api.github.com/users/bitwarden/repos","events_url":"https://api.github.com/users/bitwarden/events{/privacy}","received_events_url":"https://api.github.com/users/bitwarden/received_events","type":"Organization","site_admin":false},"repo":{"id":57452143,"name":"mobile","full_name":"bitwarden/mobile","owner":{"login":"bitwarden","id":15990069,"avatar_url":"https://avatars0.githubusercontent.com/u/15990069?v=4","gravatar_id":"","url":"https://api.github.com/users/bitwarden","html_url":"https://github.com/bitwarden","followers_url":"https://api.github.com/users/bitwarden/followers","following_url":"https://api.github.com/users/bitwarden/following{/other_user}","gists_url":"https://api.github.com/users/bitwarden/gists{/gist_id}","starred_url":"https://api.github.com/users/bitwarden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitwarden/subscriptions","organizations_url":"https://api.github.com/users/bitwarden/orgs","repos_url":"https://api.github.com/users/bitwarden/repos","events_url":"https://api.github.com/users/bitwarden/events{/privacy}","received_events_url":"https://api.github.com/users/bitwarden/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitwarden/mobile","description":"The mobile vault (iOS and Android).","fork":false,"url":"https://api.github.com/repos/bitwarden/mobile","forks_url":"https://api.github.com/repos/bitwarden/mobile/forks","keys_url":"https://api.github.com/repos/bitwarden/mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitwarden/mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitwarden/mobile/teams","hooks_url":"https://api.github.com/repos/bitwarden/mobile/hooks","issue_events_url":"https://api.github.com/repos/bitwarden/mobile/issues/events{/number}","events_url":"https://api.github.com/repos/bitwarden/mobile/events","assignees_url":"https://api.github.com/repos/bitwarden/mobile/assignees{/user}","branches_url":"https://api.github.com/repos/bitwarden/mobile/branches{/branch}","tags_url":"https://api.github.com/repos/bitwarden/mobile/tags","blobs_url":"https://api.github.com/repos/bitwarden/mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitwarden/mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitwarden/mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitwarden/mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitwarden/mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/bitwarden/mobile/languages","stargazers_url":"https://api.github.com/repos/bitwarden/mobile/stargazers","contributors_url":"https://api.github.com/repos/bitwarden/mobile/contributors","subscribers_url":"https://api.github.com/repos/bitwarden/mobile/subscribers","subscription_url":"https://api.github.com/repos/bitwarden/mobile/subscription","commits_url":"https://api.github.com/repos/bitwarden/mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitwarden/mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitwarden/mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitwarden/mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitwarden/mobile/contents/{+path}","compare_url":"https://api.github.com/repos/bitwarden/mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitwarden/mobile/merges","archive_url":"https://api.github.com/repos/bitwarden/mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitwarden/mobile/downloads","issues_url":"https://api.github.com/repos/bitwarden/mobile/issues{/number}","pulls_url":"https://api.github.com/repos/bitwarden/mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/bitwarden/mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/bitwarden/mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitwarden/mobile/labels{/name}","releases_url":"https://api.github.com/repos/bitwarden/mobile/releases{/id}","deployments_url":"https://api.github.com/repos/bitwarden/mobile/deployments","created_at":"2016-04-30T16:43:17Z","updated_at":"2017-12-10T03:09:18Z","pushed_at":"2017-12-12T16:42:33Z","git_url":"git://github.com/bitwarden/mobile.git","ssh_url":"[email protected]:bitwarden/mobile.git","clone_url":"https://github.com/bitwarden/mobile.git","svn_url":"https://github.com/bitwarden/mobile","homepage":"https://bitwarden.com","size":25589,"stargazers_count":303,"watchers_count":303,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":59,"open_issues":68,"watchers":303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitwarden/mobile/pulls/199"},"html":{"href":"https://github.com/bitwarden/mobile/pull/199"},"issue":{"href":"https://api.github.com/repos/bitwarden/mobile/issues/199"},"comments":{"href":"https://api.github.com/repos/bitwarden/mobile/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/bitwarden/mobile/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/bitwarden/mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitwarden/mobile/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/bitwarden/mobile/statuses/7a8e88c4937f3d90a20e3a820c0494dc7eed1021"}},"author_association":"CONTRIBUTOR"}} | {
"id": 57452143,
"name": "bitwarden/mobile",
"url": "https://api.github.com/repos/bitwarden/mobile"
} | {
"id": 1190944,
"login": "kspearrin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1190944?",
"url": "https://api.github.com/users/kspearrin"
} | {
"id": 15990069,
"login": "bitwarden",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15990069?",
"url": "https://api.github.com/orgs/bitwarden"
} | 2017-12-12T20:11:00 | 6979211286 | {"actor":{"display_login":"kspearrin"}} |
PullRequestReviewCommentEvent | true | {"action":"created","comment":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/comments/102232358","pull_request_review_id":22982188,"id":102232358,"diff_hunk":"@@ -134,6 +134,13 @@ class RaisedButton extends Component {\n */\n className: PropTypes.string,\n /**\n+ * An element like Link tag or a string can be used inside RaisedButton.","path":"src/RaisedButton/RaisedButton.js","position":null,"original_position":4,"commit_id":"731b6e08c56b28e104f73736deeb889d7dc2f0b9","original_commit_id":"8097359741d77cb055e6b8f9c7835848e53838fa","user":{"login":"Shahrukh-Zindani","id":14262127,"avatar_url":"https://avatars.githubusercontent.com/u/14262127?v=3","gravatar_id":"","url":"https://api.github.com/users/Shahrukh-Zindani","html_url":"https://github.com/Shahrukh-Zindani","followers_url":"https://api.github.com/users/Shahrukh-Zindani/followers","following_url":"https://api.github.com/users/Shahrukh-Zindani/following{/other_user}","gists_url":"https://api.github.com/users/Shahrukh-Zindani/gists{/gist_id}","starred_url":"https://api.github.com/users/Shahrukh-Zindani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shahrukh-Zindani/subscriptions","organizations_url":"https://api.github.com/users/Shahrukh-Zindani/orgs","repos_url":"https://api.github.com/users/Shahrukh-Zindani/repos","events_url":"https://api.github.com/users/Shahrukh-Zindani/events{/privacy}","received_events_url":"https://api.github.com/users/Shahrukh-Zindani/received_events","type":"User","site_admin":false},"body":"Updated it and made a PR for FlatButton.","created_at":"2017-02-21T15:22:29Z","updated_at":"2017-02-21T15:22:29Z","html_url":"https://github.com/callemall/material-ui/pull/6199#discussion_r102232358","pull_request_url":"https://api.github.com/repos/callemall/material-ui/pulls/6199","_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments/102232358"},"html":{"href":"https://github.com/callemall/material-ui/pull/6199#discussion_r102232358"},"pull_request":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/6199"}}},"pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/6199","id":107089200,"html_url":"https://github.com/callemall/material-ui/pull/6199","diff_url":"https://github.com/callemall/material-ui/pull/6199.diff","patch_url":"https://github.com/callemall/material-ui/pull/6199.patch","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/6199","number":6199,"state":"open","locked":false,"title":"[Docs] Add documentation for containerElement in RaisedButon","user":{"login":"Shahrukh-Zindani","id":14262127,"avatar_url":"https://avatars.githubusercontent.com/u/14262127?v=3","gravatar_id":"","url":"https://api.github.com/users/Shahrukh-Zindani","html_url":"https://github.com/Shahrukh-Zindani","followers_url":"https://api.github.com/users/Shahrukh-Zindani/followers","following_url":"https://api.github.com/users/Shahrukh-Zindani/following{/other_user}","gists_url":"https://api.github.com/users/Shahrukh-Zindani/gists{/gist_id}","starred_url":"https://api.github.com/users/Shahrukh-Zindani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shahrukh-Zindani/subscriptions","organizations_url":"https://api.github.com/users/Shahrukh-Zindani/orgs","repos_url":"https://api.github.com/users/Shahrukh-Zindani/repos","events_url":"https://api.github.com/users/Shahrukh-Zindani/events{/privacy}","received_events_url":"https://api.github.com/users/Shahrukh-Zindani/received_events","type":"User","site_admin":false},"body":"Documentation for containerElement in RaisedButton. \r\nClose issue #5647 \r\n","created_at":"2017-02-20T23:07:25Z","updated_at":"2017-02-21T15:22:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af498a32ca4cf90b445bf5d977a0df0088254394","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/callemall/material-ui/pulls/6199/commits","review_comments_url":"https://api.github.com/repos/callemall/material-ui/pulls/6199/comments","review_comment_url":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/6199/comments","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/731b6e08c56b28e104f73736deeb889d7dc2f0b9","head":{"label":"Shahrukh-Zindani:add/containerDocs","ref":"add/containerDocs","sha":"731b6e08c56b28e104f73736deeb889d7dc2f0b9","user":{"login":"Shahrukh-Zindani","id":14262127,"avatar_url":"https://avatars.githubusercontent.com/u/14262127?v=3","gravatar_id":"","url":"https://api.github.com/users/Shahrukh-Zindani","html_url":"https://github.com/Shahrukh-Zindani","followers_url":"https://api.github.com/users/Shahrukh-Zindani/followers","following_url":"https://api.github.com/users/Shahrukh-Zindani/following{/other_user}","gists_url":"https://api.github.com/users/Shahrukh-Zindani/gists{/gist_id}","starred_url":"https://api.github.com/users/Shahrukh-Zindani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shahrukh-Zindani/subscriptions","organizations_url":"https://api.github.com/users/Shahrukh-Zindani/orgs","repos_url":"https://api.github.com/users/Shahrukh-Zindani/repos","events_url":"https://api.github.com/users/Shahrukh-Zindani/events{/privacy}","received_events_url":"https://api.github.com/users/Shahrukh-Zindani/received_events","type":"User","site_admin":false},"repo":{"id":81582854,"name":"material-ui","full_name":"Shahrukh-Zindani/material-ui","owner":{"login":"Shahrukh-Zindani","id":14262127,"avatar_url":"https://avatars.githubusercontent.com/u/14262127?v=3","gravatar_id":"","url":"https://api.github.com/users/Shahrukh-Zindani","html_url":"https://github.com/Shahrukh-Zindani","followers_url":"https://api.github.com/users/Shahrukh-Zindani/followers","following_url":"https://api.github.com/users/Shahrukh-Zindani/following{/other_user}","gists_url":"https://api.github.com/users/Shahrukh-Zindani/gists{/gist_id}","starred_url":"https://api.github.com/users/Shahrukh-Zindani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shahrukh-Zindani/subscriptions","organizations_url":"https://api.github.com/users/Shahrukh-Zindani/orgs","repos_url":"https://api.github.com/users/Shahrukh-Zindani/repos","events_url":"https://api.github.com/users/Shahrukh-Zindani/events{/privacy}","received_events_url":"https://api.github.com/users/Shahrukh-Zindani/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Shahrukh-Zindani/material-ui","description":"React Components that Implement Google's Material Design.","fork":true,"url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui","forks_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/forks","keys_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/teams","hooks_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/hooks","issue_events_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/events","assignees_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/tags","blobs_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/languages","stargazers_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/stargazers","contributors_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/contributors","subscribers_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/subscribers","subscription_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/subscription","commits_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/merges","archive_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/downloads","issues_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Shahrukh-Zindani/material-ui/deployments","created_at":"2017-02-10T16:19:03Z","updated_at":"2017-02-10T16:19:07Z","pushed_at":"2017-02-21T15:21:48Z","git_url":"git://github.com/Shahrukh-Zindani/material-ui.git","ssh_url":"[email protected]:Shahrukh-Zindani/material-ui.git","clone_url":"https://github.com/Shahrukh-Zindani/material-ui.git","svn_url":"https://github.com/Shahrukh-Zindani/material-ui","homepage":"http://www.material-ui.com","size":80232,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"callemall:master","ref":"master","sha":"547178d1939e50598b28cd7aec09a8e2cb31fef9","user":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"repo":{"id":23083156,"name":"material-ui","full_name":"callemall/material-ui","owner":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callemall/material-ui","description":"React Components that Implement Google's Material Design.","fork":false,"url":"https://api.github.com/repos/callemall/material-ui","forks_url":"https://api.github.com/repos/callemall/material-ui/forks","keys_url":"https://api.github.com/repos/callemall/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callemall/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callemall/material-ui/teams","hooks_url":"https://api.github.com/repos/callemall/material-ui/hooks","issue_events_url":"https://api.github.com/repos/callemall/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/callemall/material-ui/events","assignees_url":"https://api.github.com/repos/callemall/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/callemall/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/callemall/material-ui/tags","blobs_url":"https://api.github.com/repos/callemall/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callemall/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callemall/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/callemall/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/callemall/material-ui/languages","stargazers_url":"https://api.github.com/repos/callemall/material-ui/stargazers","contributors_url":"https://api.github.com/repos/callemall/material-ui/contributors","subscribers_url":"https://api.github.com/repos/callemall/material-ui/subscribers","subscription_url":"https://api.github.com/repos/callemall/material-ui/subscription","commits_url":"https://api.github.com/repos/callemall/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/callemall/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/callemall/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/callemall/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/callemall/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/callemall/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callemall/material-ui/merges","archive_url":"https://api.github.com/repos/callemall/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callemall/material-ui/downloads","issues_url":"https://api.github.com/repos/callemall/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/callemall/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/callemall/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/callemall/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callemall/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/callemall/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/callemall/material-ui/deployments","created_at":"2014-08-18T19:11:54Z","updated_at":"2017-02-21T15:07:51Z","pushed_at":"2017-02-21T15:22:08Z","git_url":"git://github.com/callemall/material-ui.git","ssh_url":"[email protected]:callemall/material-ui.git","clone_url":"https://github.com/callemall/material-ui.git","svn_url":"https://github.com/callemall/material-ui","homepage":"http://www.material-ui.com","size":80224,"stargazers_count":23325,"watchers_count":23325,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4202,"mirror_url":null,"open_issues_count":630,"forks":4202,"open_issues":630,"watchers":23325,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/6199"},"html":{"href":"https://github.com/callemall/material-ui/pull/6199"},"issue":{"href":"https://api.github.com/repos/callemall/material-ui/issues/6199"},"comments":{"href":"https://api.github.com/repos/callemall/material-ui/issues/6199/comments"},"review_comments":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/6199/comments"},"review_comment":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/6199/commits"},"statuses":{"href":"https://api.github.com/repos/callemall/material-ui/statuses/731b6e08c56b28e104f73736deeb889d7dc2f0b9"}}}} | {
"id": 23083156,
"name": "callemall/material-ui",
"url": "https://api.github.com/repos/callemall/material-ui"
} | {
"id": 14262127,
"login": "Shahrukh-Zindani",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14262127?",
"url": "https://api.github.com/users/Shahrukh-Zindani"
} | {
"id": 1262264,
"login": "callemall",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1262264?",
"url": "https://api.github.com/orgs/callemall"
} | 2017-02-21T15:22:29 | 5362982491 | {"actor":{"display_login":"Shahrukh-Zindani"}} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.